text:
Fix SMs count update

Merging for deplyoment to test env

authors: alexmpa bpetridis

repo: phantasma-io/PhantasmaExplorer


text:
変数宣言の重複を削除

$extendのコードを読んで、推測で修正しています。
間違っていたらゴメンなさい。

@techno-cat san
確かにこれでいけますね!
リファクタリングありがとうございます:D

source: gharchive/pull-request

authors: phi-jp techno-cat

license: MIT

license_type: permissive

license_source: github-api


text:
Linux下载安装包到33M就停了

这个应该跟你网络有关系吧，下载服务是走的 github 托管服务

source: gharchive/issue

authors: liu-jianhao phobal

repo: phobal/ivideo


text:
Assignment 2 commit

closing without accepting.  please include the jpegs in the README.md as per the instructions


text:
Add iOS 13-availability check to the test classes

Please let the test fail, if not tested on iOS 13+

Done.

authors: fredpi knothed

repo: piknotech/SFSafeSymbols


text:
Added more range operators; deprecated time_quantum for indexes.

Coverage remained the same at 100.0% when pulling b9aae933c58ae467dcbd7fc71f0aa693df7c6f48 on yuce:more-range-operators-deprecate-index-options into ce8102653a074176ea6f1120c65a6ec3846e0a35 on pilosa:master.

authors: coveralls yuce

repo: pilosa/python-pilosa


text:
1.162.1

Merged, thanks @mmanciop

repo: pivotal-cf/docs-instana


text:
Remove Noisy Logs

Turns out removing these causes the app boot to fail.. we should close this for now and revisit.

repo: pluralsight/hydra


text:
make Node a sequence so that we can lazy it

Html is now its own repo!

authors: mbrandonw stephencelis

repo: pointfreeco/swift-web

license: mit

license_source: bigquery


text:
Pr/371

test comment

test 1

test 2

repo: polatengin/terratest


text:
[FIX] avoid using $HOME for storing templates

Confirmed to solve the issue for a user https://neurostars.org/t/filenotfounderror-errno-2-no-such-file-or-directory-home-fmriprep-cache/3770/8. I recommend merging and publishing new release on Monday.

repo: poldracklab/fmriprep


text:
Part9

Принято полностью.

authors: akkalomator dormidon


text:
Implement Shuffle Extension for IAsyncEnumerable

Does Shuffle make sense on IAsyncEnumerable. IAsyncEnumerable basically represents a stream of in.coming events .
Shuffle can only be implemented in an eager way, therefore we need to wait until the Enumeration is enumerated completley before we can shuffle. Therefore there is no benefit in offering such a function, the output  will allways be synchronous.
The correct solution would be something like this:
(await asyncEnumerable.ToListAsync).Shuffle();

I am not sure if we talk past each other, let's say we have an IAsyncEnumerable, so the MoveNextAsync is implemented as async. The shuffle needs to call MoveNextAsync until the end of the whole IAsyncEnumerable because the last element could be the first one after the shuffle. Actually it's like the AggregateAsync extension function, which we could in theory use to create the shuffled list.
The consequence is, that the return type of Shuffle cannot be IAsyncEnumerable, but Task<IEnumerable>

I am pretty sure the only return-type which makes sense is Task<IEnumerable>
I am unsure if this could be confusing, or if we should refrain from implmenting such a extension.

merged in funcky3

authors: FreeApophis bash

repo: polyadic/funcky


text:
Last Week in Pony - January 5, 2020

Version 0.5.0 of ponyup has been released.
See the release notes for more details.

authors: Theodus ponylang-main

repo: ponylang/ponylang-website


text:
CI-285 Use the correct issue type when raising JIRA tickets

I've picked that commit into the separate #14

Nice and simple 👍

authors: dylanmckay erikfercak

repo: powershop/SquareSquash-web


text:
Navigation section links are not translated

@miltontony ready for review :)

:+1:

repo: praekelt/molo-babycenter


text:
new-feature: Add some comments

Not sure if your are a bot or not but these changes aren't really useful. Sorry will close it.

repo: praveenpuglia/vuetify-daterange-picker


text:
Add details on PubMatic adSlot now being optional as Prebid v2.13.0

Code change was already merged and released as part of Prebid.js v.2.13.0


text:
[Docs]: Add Issue Template, Pull Request template, Code Of Conduct

please assign me this issue.

please assign me this issue.

JOB done @preeti13456  https://github.com/preeti13456/CityonBikes/pull/20

JOB done @preeti13456  https://github.com/preeti13456/CityonBikes/pull/20


text:
[full dmmf] figure out if we could make nested updates work

We can't

repo: prisma/prisma-client-go


text:
Remove unnecessary print in node command

LGTM

authors: TrimBiggs robbrockbank

repo: projectcalico/calico-docker


text:
Add ETCD_VERSION parameter and bump other versions

Looks like some tests are failing - I'll raise an issue

repo: projectcalico/libcalico-go


text:
Please, make object rule open for subclassing

It is not open intentionally. Please use protocol Rule for defining custom rules.

repo: ptiz/bender


text:
CollaborativeReading - UserFilter

先算步驟

能夠選擇同儕

能夠顯示文字雲

能夠動態排序
go

要讓它可以選擇...

先做個測試

防不勝防就跑出來了

布布！！

未免也太可愛，可以接受

其實做出來之後，意外的還蠻有趣的
我喜歡~~
再來要來做歡樂的圖表嗎？不要了，我們回去吧

忘了記錄現在的進度了，開始

努力撐下去啊...好睏...

有點...感動...

repo: pulipulichen/PACOR


text:
Port .hgignore to .gitignore

I didn't removed .hgignore in case someone still wants to use some kind of bridge between Git and Mercurial.

authors: berkerpeksag brettcannon

repo: python/devinabox


text:
博客的图片均无法显示，尝试了好几种路径表示方法都无效，请问这可能是什么问题？

一个是你图片的后缀名.png与.PNG不同，大写变小写无法显示
我看了看你自己github repo里面的post 图片可以显示，现在好了吗？如果没好，看看图片后缀名是大写的还是小写的，我之前也有这个问题，大写变小写以后就ok了

一个是你图片的后缀名.png与.PNG不同，大写变小写无法显示
我看了看你自己github repo里面的post 图片可以显示，现在好了吗？如果没好，看看图片后缀名是大写的还是小写的，我之前也有这个问题，大写变小写以后就ok了

post的正文图片无法显示 本地md可以正常渲染 推到github库里打开也能显示 但是 通过github pages 打开 正文里的图片就显示不了啊https://github.com/qiubaiying/qiubaiying.github.io/issues/383

authors: Jim-Carrey WindyTouch liunima1129


text:
Is it posiible to make fluids and blocks goes through portals?

That'd be interesting, would fix the visual oddity of water cutting off halfway below alternate2 generation

water logged portal block when

I would actually love this, I wonder how they would do it though with water in the nether though. I think it would be cool to see something more than just a harsh stop of all the water, but I don't know what else they could do about it.

Maybe when water flows down in the Nether it turns into Hot Water

Maybe they can only add it for the overworld portals but not for netherportals like with entities

authors: BbrbP Jarfeh Jkmcameron MCSuperplayer Ookidablobida WinnerSonX

repo: qouteall/ImmersivePortalsMod


text:
Chapter 5

Currently working on the text to go along with the code

It is also rude to hand someone over a distribution when all the asked for was an estimate. -> *he (not your typo but might as well fix it).

"We can turn this reasoning around: the least-squares model is not try to predict the best (according to a stock-loss definition of predict). "

"We will attempt to implement Tim's winning solution using PyMC" -> PyMC3

exp_mass_large = pm.Uniform("exp_mass_large", 40, 180)
mass_large = pm.Deterministic("mass_large", np.log(exp_max_large))
``` -> That code does not seem to match with the model below.

                    tangential_distance(T.as_tensor(data[:,:2]), halo_position))
``` That line break looks pretty bad in nbviewer.

step = pm.NUTS(scaling=model.dict_to_array(sds)) this should require is_cov=True.

See comments but otherwise looks great!

authors: mmargenot twiecki


text:
[WIP] 1260 - feat - escan role

@guillaumededrie Are we still using nobody user for probe_app ? I need it to be a real user, can switching user can be planned for this release ?

PR against testing: https://github.com/quarkslab/irma-ansible/pull/79

repo: quarkslab/irma-ansible


text:
Fix link to "source" file on GitHub

@ilyahal Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@ilyahal Thank you for signing the Contributor License Agreement!

Thank you. Will deploy this live in a few hours.

repo: rabbitmq/rabbitmq-website


text:
reducer/display: display modes need tests

/close due to inactivity

authors: aeneasr macrozone

repo: react-page/react-page


text:
[Fix #358] menu button fit its content size

It's fixed

repo: readium/readium-desktop


text:
Add license.

Have we agreed on the licence or are we releasing everything with MIT? Can't remember

Id Rather do MiT for all the repos, but @VoyTechnology this was your project originally do you have a preference

talked in person ok to merge after rebase

authors: CSmartt VoyTechnology butlerx


text:
Register redpen jar files to the Maven central repository

Kuromoji was registered Maven central. I think it is a good time to try.

done!

Great! :+1:

authors: takahi-i yusuke

repo: redpen-cc/redpen


text:
readme: tweaks

Looks good, thanks :D

authors: memoryruins rep-nop


text:
Do you have plan to release the train code and the data for the siamrpn? thanks

The data (youtub) is too big to upload.
The code may release later but not recently.
You can use some third party siamrpn training code on github now, since some other researchers have reproduced my result as far as I  know.

thanks a lot

repo: researchmm/SiamDW


text:
Added dtoverlay=w1-gpio to docs

LGTM

authors: josephroberts shaunmulligan

repo: resin-io/docs


text:
Fix specs

:+1:

authors: Nitrodist rheaton

repo: rheaton/carrierwave-video


text:
Q: Why the function has to be recursive even if it should not

What do you mean? Please show an example.

authors: mrkaspa rhysd

repo: rhysd/gocaml


text:
能不能发群公告

可以的，用Cool Q HTTP API，不过是实验性的api，可能会有问题，

API参考链接：https://cqhttp.cc/docs/4.10/#/API?id=_send_group_notice-发布群公告

API参考链接：https://cqhttp.cc/docs/4.10/#/API?id=_send_group_notice-发布群公告

谢谢

repo: richardchien/nonebot


text:
merge

Thanks for the update

authors: MahmoudFayed ringjstorm

repo: ring-lang/ring


text:
Handle 64 bit integers in JSON by converting to string.

@nbougalis and I have discussed this problem in the past.
I'm initially very skeptical about this solution, even though it has the advantage of brevity.
It means that one integral type becomes a string but the rest stay integers.  "Round trips" - transformations C++ class -> json -> C++ or json -> C++ -> json - these are already broken, but this makes the brokenness permanent.
It means that two very similar seeming lines of code can result in Json with different types. It means that (a == b) && (Json::Value(a) != Json::Value(b)) is now possible.
Is there an actual issue we need to solve?  If there isn't something pressing, my first thought would be to leave well enough alone.
IF we wanted to make this change, I have a counterproposal:

My counterproposal:

We should make the base integer type of Json::Value std::int64_t.

Existing code would be unaffected - in particular, Json::Value::toInt() and Json::Value::toUInt() would return exactly the same values they return now.

There would be two new constructors (uint64 and int64).

There would be one new ValueType - longValue.

And this would require asLong() and isLong() and changes to isIntegral()' and 'isNumeric()

Note that in the 64-bit case I'm proposing we don't distinguish between signed and unsigned.  This means we do a poor job on numbers between std::numeric_limits<std::int64_t>::max() and std::numeric_limits<std::uint64_t>::max() but this isn't really an issue because:

Right now we do a poor job on numbers above std::numeric_limits<std::uint32_t>::max() so we'd doing a lot better.

If we're at the point where we really need that 64th bit to represent numbers, then we're screwed anyway.

Again, the big advantage to the counterproposal is that old code is guaranteed to be unaffected but also that we preserve round-trip.

We're logging counters that have a tendency to exceed 32bits very rapidly, and I'll be logging more like this in instrumentation code that I'm working on. It is a workaround for something broken in JSON. Your counterproposal seems like a lot of work, and it's not going to solve the problem I'm facing, which is how to get JSON to represent 64bit integers.

@mtrippled If this is for instrumentation purposes you could just use std::to_string instead of tinkering with the JSON library. It would be safer.

It wouldn't be that much work!  :-)

authors: mtrippled rec vinniefalco

repo: ripple/rippled

license: ISC


text:
Create my-slide

my-slide

repo: rjgcdgszy/github-slideshow


text:
Add Korean captions

Oops, I meant to commit them only to my forked repo except first one.
Sorry.


text:
ObjectID: Include NULL names

This was merged in #417

authors: Adam- Sethtroll

repo: runelite/runelite


text:
Deprecate the util::contracthash module

@sgeisler superceded by Miniscript. There is some key-tweaking logic in there that doesn't exist elsewhere but it's not hard to implement independently.

...and I am planning to implement it in rust-miniscript, when we update our Liquid code to use this version of rust-bitcoin

I chased a warning on deprecated empty test for half an hour until I've found that this was the culprit :(
https://pastebin.com/raw/SyJvV5p8
Can we please add a reason to ease finding the source? (ie  #![deprecated = "superceded by Miniscript"])

I chased a warning on deprecated empty test for half an hour until I've found that this was the culprit :(
https://pastebin.com/raw/SyJvV5p8
Can we please add a reason to ease finding the source? (ie #![deprecated = "superceded by Miniscript"])

Saw this now: https://github.com/rust-bitcoin/rust-bitcoin/pull/475/commits/05f3451b108c5fdec518c0a54d6ebace07990e3c sigh.

authors: apoelstra elichai stevenroose

repo: rust-bitcoin/rust-bitcoin


text:
Fix readme typos

:+1: thanks

authors: KeenRegard rwz

repo: rwz/ember-cli-rails


text:
Add Day0 Solution in Swift language

@penelopearaujo  thaks for taking up it in swift i will create an issue for adding soln in swift too.  then you can start working on more.

@penelopearaujo i have created an issue for this can you add a comment over there telling which Day question you are working on.

Great! Thanks!


text:
SAK-40477 - JSF upgrade to 2.3.6. Weld to 3.0.5

What was the reason for using the shaded jar? why would we add it to master? as the tools can declare the version they would like to use.

It's fine @ern, thanks

authors: ern mpellicer

repo: sakaiproject/sakai


text:
Consider using res.sakuraMeta rather than res.locals

after some internal discussions with others... no one cares so this isn't getting changed (for the moment at least).

repo: sakuraapi/api


text:
test

i managed to trigger both bots in one issue, amazing

repo: sample-text-here/community-mod

license: WTFPL


text:
support i18n

accept language header

repo: satokazuma/kalar-core


text:
Fix typo

Can you please sign the CLA?

CLA check for DmytroMitin failed
Please sign the Scala CLA to contribute to Scalameta
Go to https://www.lightbend.com/contribute/cla/scala and then resubmit this pull request

I signed the CLA.

authors: DmytroMitin olafurpg

repo: scalameta/scalameta


text:
splash doesn't stop request processing when client disconnects

Sometimes when I kill a splash request the next request fails immediately, I don't remember what error did it get or under what conditions it happens. I suspect some state might be kept somewhere and carried over to the next request.

@Youwotma are you using splash directly? Can it be an issue with a load balancer?

I'm running it directly but with a  pretty long running lua script that and I kill the spider if I see something wrong without waiting for it to finish.

@Youwotma your error looks different; if you can find an example it'd be good to open a new ticket.

authors: Youwotma kmike

repo: scrapinghub/splash


text:
How to remove this tool?

Please ask user issues on the Gitter channel provided from our website. Issues are for feature requests and defects.

repo: sdkman/sdkman-cli


text:
added name to guestbook

Thank you!

authors: atmichel seankross

repo: seankross/the-unix-workbench


text:
feature: mybatis not return auto increment id faq.

Please update the english version

@lovepoem I am English poor. Whether to find someone else to help.

authors: jsbxyyx lovepoem


text:
Fixed my error

(I added the awaiting changes label to let me know I'm waiting on a change from you before merging)

I'm going to merge but your parter will note any issues later today.


text:
cleanup: remove unused variable

rerun selenium-tests

rerun skydive-functional-tests-backend-elasticsearch

repo: skydive-project/skydive


text:
logging: move to graffiti

run compile-tests
run unit-tests
run scale-tests
run functional-tests-backend-elasticsearch

run cdd-overview-tests
run compile-tests
run unit-tests

run compile-tests

run compile-tests

run compile-tests


text:
Cloudmade tiles for the demo sites are not working

+1

same for me. Can't see anything on the demo pages.

Fixed by 403c1ca: see http://smeijer.github.io/L.GeoSearch for a working demo.
Thanks for reporting.

authors: codeofsumit smeijer ustroetz valioDOTch


text:
Twine Integration

Hey all! If people are still interested in this functionality, I actually have used the MIT-licensed YarnSpinner pretty extensively, and I think Twine integration would provide a ton of value in terms of rapid prototyping. If there's still interest for this feature I'd like to get a handle on what people would like to see Twine Integration mean. So:

Do we want a one-off translation layer, where a twine file can be made into a Flowchart that is then customized? (Fungus is the content authority after import)
Do we want a runtime translation layer, where a twine file is made into a Flowchart during scene initialization or the like and changes are discarded from the Flowchart? (Twine is the content authority)
The intense option: do we want a bi-directional translation layer, where a Twine file can be imported into a flowchart, but the flowchart can then be exported to a Twine file? (A lawless land where there is no authority and everyone is king)

Also, do people see a value in being able to bind macros for example to Command scripts? Things like that. Thanks in advance!

Hi Conrad. Pretty sure there'd be a lot of interest in this feature if you could get it going. One issue is that the Unity UI text doesn't support hyperlinks in the text. This could be solved now by using Text Mesh Pro which does support hyperlinks, though the Writer class would probably need a bit of a redesign to work properly with all the special tags that Text Mesh Pro supports.
If you want more feedback I'd suggest posting about this again on the Fungus forums as that gets a lot more traffic than github.
Regarding the integration, maybe you don't need to generate Flowcharts at all? You could have a 'Yarn' command that can load and run a Yarn file using the Say Dialog and Menu Dialogs directly - something along the lines of how the Conversation command works. Macros could then be used to control stuff like selecting characters and setting the various dialog options. There could also be Event Handlers to allow flowchart's to handle events raised by the Yarn script.

Hey Conrad, I'd personally be very interested in Twine/Yarn-to-Flowchart integration, particularly if the import tool could be used to map tags to something.

authors: RonanPearce catherineomega chrisgregan konistehrad

repo: snozbot/fungus


text:
fix travis release branch conditonal

@ggilmore could you give a PR description? What problem does this fix?

When you push a tag v.X.X.X to github, Travis sees the branch name as v.X.X.X, not master. This means that the release job for the binaries will never run.
See https://github.com/travis-ci/travis-ci/issues/8518

And why do we need to build the Docker images on tags? Since every tag is for a commit, that same commit will have already been build, so wouldn't we build it twice?

ping @ggilmore

Sorry I missed this. You're right that it's redundant, but I don't see it
as really that big a deal for now (especially since we release so
infrequently)
On Wed, Jun 13, 2018 at 2:10 PM Felix Becker notifications@github.com
wrote:

ping @ggilmore https://github.com/ggilmore
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sourcegraph/lsp-adapter/pull/85#issuecomment-397087906,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AImqOwzpNJLSKoxKIZxJvX4uXloP7_GLks5t8X-5gaJpZM4UZzJK
.

So all we need to do is revert this PR?

No, because then pushing tags to make a new release won't work.
On Wed, Jun 13, 2018 at 2:47 PM Felix Becker notifications@github.com
wrote:

So all we need to do is revert this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sourcegraph/lsp-adapter/pull/85#issuecomment-397098495,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AImqO4o2kQw-mHAlKM1OtuRGFkpplbVtks5t8YiBgaJpZM4UZzJK
.

This PR is still valuable, it just that it also builds redundant images as
you pointed out
On Wed, Jun 13, 2018 at 2:48 PM Geoffrey Gilmore geoffrey@sourcegraph.com
wrote:

No, because then pushing tags to make a new release won't work.
On Wed, Jun 13, 2018 at 2:47 PM Felix Becker notifications@github.com
wrote:

So all we need to do is revert this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sourcegraph/lsp-adapter/pull/85#issuecomment-397098495,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AImqO4o2kQw-mHAlKM1OtuRGFkpplbVtks5t8YiBgaJpZM4UZzJK
.

authors: felixfbecker ggilmore

repo: sourcegraph/lsp-adapter


text:
Cookie sort/order reminder

https://github.com/soyuka/explorer/commit/16011d9ef9c57f3cd4a2e5d73b68d04925722c6f

repo: soyuka/explorer


text:
Fixed a bug where we assumed the hands were empty before even checking

Shouldn't you be using phab for this?

Phab is verboten

I found Phab to be complicated and there has been little to no activity lately

Yeah, I asked about it on IRC after this got merged, bye phab

authors: PJB3005 RednoWCirabrab volundr-


text:
Note about timing of spawned child processes.

Note that I probably was wrong about os.times()[2] not measuring grandchild process time, the documentation was somewhat ambiguous.
In principle, it would be possible to measure process_time() + os.times()[2] --- however, that timer apparently has a rather poor resolution (10ms on ubuntu 14.10).

Maybe we merge this, but open a new issue that it would be nice to solve the "measuring child process time" problem at some point?

Sounds good.

authors: mdboom pv

repo: spacetelescope/asv


text:
Remove show_in_footer, Fix Specs

@nishant-cyro Please describe why you removed show_in_footer.

@Mafi88 - According to the new designs of Spree, there is no footer in it.

@nishant-cyro Thanks.
:+1:

@nishant-cyro can you sync with master? Thanks :)

@damianlegawiec - done!

@damianlegawiec - Fixed, using html now.

authors: Mafi88 damianlegawiec nishant-cyro


text:
Fix spelling mistake.

Codecov Report

Merging #1164 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1164      +/-   ##
============================================
- Coverage      77.7%   77.49%   -0.21%
+ Complexity      949      948       -1
============================================
  Files           112      112
  Lines          3373     3373
  Branches        466      466
============================================
- Hits           2621     2614       -7
- Misses          580      589       +9
+ Partials        172      170       -2

Impacted Files
Coverage Δ
Complexity Δ

...fig/client/ConfigServicePropertySourceLocator.java
65.95% <0%> (-3.55%)
25% <0%> (ø)

...rk/cloud/config/client/ConfigClientProperties.java
89.65% <0%> (-1.73%)
40% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abbd14f...0e01941. Read the comment docs.

authors: codecov-io xiaolongzuo

repo: spring-cloud/spring-cloud-config


text:
User git publish plugin

@amontenegro Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

authors: amontenegro pivotal-issuemaster

repo: spring-projects/spring-social-facebook


text:
when press Ctrl

when press Ctrl+D by mistake, the current ipython console will be closed.But this can't be unabled

Unfortunately IPython console shortcuts can't be configured right now, i.e. they are hard-coded. This is a known limitation and we'll try to address it in the future.

repo: spyder-ide/spyder


text:
CamelCase typedefs

@sroby conflict resolved ready for review

repo: sroby/f-type


text:
为什么是kotin写法，有没有纯Java写法

有java demo

依赖的 medule就是kotin

@ruanguihua android studio menu -> tool -> kotlin -> showKotlinByte -> decomplie 可以看到反编译后的java代码

不过建议还是学下kotlin

authors: LuckyJayce ruanguihua ssseasonnn

repo: ssseasonnn/RxDownload


text:
[doc] Overview section

Very nice. I think the file ur5.urdf should also be included within pinocchio (I would say in the folder models), especially if the example is meant to be automatically built and tested.

@gabrielebndn we had romeo's urdf included within pinocchio before, and I suggested to remove it in #424.
It doesn't change anything for CI automation, as it can be installed with all the other dependencies.

I like all changes. My comments follow. I've already mentioned some to Nicolas

I'm ok with not including ur5.urdf within pinocchio, but then a better link should be provided to the file. First of all, I was forced to dig inside the repo until I found the one file I was looking for, which is not nice. Most importantly, I could not find ur5.urdf. Instead, I found ur5.urdf.xacro, which I needed to convert to urdf with ROS. I do not think we should expect the user to that, nor should pinocchio testing routines depend on ROS

concerning the examples inverse-kinematics: the python example employs jointJacobian, while the one in C++ employs computeJointJacobians followed by getJointJacobian. Nicolas told me he could not make the two examples to be identical because of problems with deprecated methods. So I dug deep into the code, and I found some critical points.
First of all, the easy part: in  o use jointJacobian in C++, the correct procedure is the following:
se3::Data::Matrix6x J(6,model.nv); J.setZero(); se3::jointJacobian(model,data,q,JOINT_ID,J);
while the following procedure
se3::Data::Matrix6x J = se3::jointJacobian(model,data,q,JOINT_ID);
is deprecated.
Then there is a bigger problem: if you try to use the above line in Nicolas' example, it won't work. You also need to call forwardKinematics (before or after, it does not make a difference). You do not need it in python. Why? Because the python method jointJacobian DOES NOT call its corresponding C++ function. Instead, it internally calls computeJointJacobians followed by getJointJacobian, and computeJointJacobians internally does the equivalent of forwardKinematics, which C++ jointJacobian does not. In Nicolas' example, forwardKinematics is needed later in order to correctly retrieve data.oMi[i]. I opened an issue on the point, you can check #545

@nmansard ok

I think we have discussed enough about this. My suggestion:

Rebase topic/doc-v2 to bring it on par with the latest progress on devel
Address all comments made by me and @jcarpent
For the Jacobians in the inverse kinematics examples: let's freeze the discussion on the API. Here we have four options, listed from the ones I deem most to least desirable:

switch to computeJointJacobian + getJointJacobian in python
keep the two examples as they are, with a slight inconsistency between the two. In the text, just present the two methods as two alternative ways of achieving the same result.
use jointJacobian in C++, but add a call to forwardKinematics() in C++. Explain why this is needed.
use jointJacobian in C++, add a call to forwardKinematics() in C++, and also add a (useless) call to forwardKinematics() in python (notice that this would still not fully eliminate all inconsistencies).

merge in devel and close.
I would happily do the job myself, but the changes are in Nicolas' repo

Update: I will think about it by doing a PR on nicolas' repo.

Ping. I've done my part.You can find the changes in Nicolas repo, PR#4.

@gabrielebndn I marked some of the request changes of @jcarpent as resolved, but I am not sure of the other ones. Could you double check then merge?

Ok, so I marked as solved most of Justin's comments, except for 6:

4 in the code of i-inverse-kinematics.cpp . I preferred not to follow them. I think we can agree these are secondary and we should not focus on this piece of code
1 in overview-simple.py . I preferred not to follow it
1 About the supported systems. I mostly followed Justin's advice, mentioning Ubuntu 18.04 and Mac OS X, but I did not explicitly mention other systems. Probably I should have. What else do we support? Fedora, BSD and ... ? Maybe Nicolas can add a sentence when he makes his last modifications

Justin, if you agree with things as they are now, you can mark your unresolved changes as resolved yourself.

It seems fine for me now.

authors: gabrielebndn jcarpent nim65s nmansard

repo: stack-of-tasks/pinocchio


text:
Clouds.yaml, no_gateway_ip, subnetpool allocation

Added another commit that supports deleting networks with routers on them.

repo: stackhpc/ansible-role-os-networks


text:
Add TS types

There is a better way of writing these types so that it's not manually encoding by quantity, but I can't quite remember how it was right now. Anyway good to merge for the time being.

authors: Andarist staltz

repo: staltz/callbag-pipe


text:
Update ordering of installation instructions

Thanks! I actually copied lapack to anaconda channel so now it should work right away.

Solved by adding lapack to the conda channel

authors: kidzik spMohanty

repo: stanfordnmbl/osim-rl


text:
Extended tx submission logging feature flag

It seems that extended logging doesn't cause any problems and can help better understand possible issues in txsub package.

repo: stellar/go


text:
Glue Connection properties is not permitted for use due to plaintext credentials

connection_properties is required https://www.terraform.io/docs/providers/aws/r/glue_connection.html#connection_properties
I'm writing the rule to fail if PASSWORD is present in the connection_properties.
  - id: GLUE_CONNECTION_PROPERTIES     message: Glue connection properties cannot specify plaintext passwords     resource: aws_glue_connection     severity: FAILURE     assertions:       - key: connection_properties[].PASSWORD | [0]         op: absent     tags:       - glue

repo: stelligent/config-lint


text:
Removed typo from file name

Coverage remained the same at 100.0% when pulling 73add4c412c6a398dd783e6d6b199d30890ca4c7 on Rayne:typo into 5383a6ba21e7200dbbf503a0ba59712269d4d647 on straker:master.

authors: Rayne coveralls

repo: straker/kontra


text:
Fix typo

Thanks, and sorry for the delay in merging!

authors: jeffwidman krisreeves-stripe

repo: stripe/datadog-checks


text:
SB-887: remote  RSS index download for Nuget remote repository [in progress]

Thanks! :)

authors: carlspring sbespalov

repo: strongbox/strongbox


text:
Update README with migration instructions

@miguel-s thanks for the review. I updated the text with your suggestions along with a couple of other adjustments. I also moved the "Limitations of the converter" up so the user can be aware of them before running it.

As the migration instructions gets improved, it's starting to pollute the README.md file a lot. I'll move it to its own file MIGRATING.md

I found the tiniest issue in the converter with my project, the indentation was slightly wrong in this case:
Original
def render(assigns) do
  ~H"""

    ...

  """
end

Converted
def render(assigns) do
  ~F"""

 <- missing one whitespace
    ...

  """
end

@miguel-s yeah, I need to make a small change in the converter.

authors: miguel-s msaraiva

repo: surface-ui/surface


text:
doc(readme): add codebeat badge

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #85   +/-   ##
=======================================
  Coverage   86.91%   86.91%
=======================================
  Files           5        5
  Lines         657      657
=======================================
  Hits          571      571
  Misses         54       54
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b6d10...b044606. Read the comment docs.

LGTM

repo: swaggo/swag


text:
Progress bar

@gajerachintan9 Issue resolved
Thank You for looking into thr issue and tried to solve it.

repo: swapnilsparsh/YoutubeDownloader


text:
small fixes

Thanks!

repo: sycamore-rs/sycamore


text:
增加每日歌单推荐频道

额, 原来是独立于豆瓣FM之外的功能

改版后 API http://douban.fm/j/v2/songlist/user_daily/?kbps=192


text:
Can we use lib to increment time instead of decreasing it.?

@karimkhamwani pull requests are welcome

authors: karimkhamwani talalmajali


text:
Make some minor grammatical tweaks to the readme

Thanks!

authors: ajpiano tbranyen

repo: tbranyen/backbone-boilerplate


text:
Fix link to Swift string literals

Thanks @ugultopu!

authors: mmkal ugultopu


text:
Save stdout of every encoder_example run

Done.

repo: tdaede/awcy


text:
Imports more stuff from digital-citizenship-functions

Warnings

:warning:
Please include a Pivotal story at the beginning of the PR title (see below).

:warning:
Please include a description of your PR changes.

Example of PR titles that include pivotal stories:

single story: [#123456] my PR title
multiple stories: [#123456,#123457,#123458] my PR title

New dependencies added: applicationinsights, unified, rehype-stringify, remark-parse and remark-rehype.
applicationinsights
Author: Unknown
Description: Microsoft Application Insights module for Node.js
Homepage: https://github.com/Microsoft/ApplicationInsights-node.js#readme

Createdalmost 5 years agoLast Updated24 days agoLicenseMITMaintainers1Releases58Direct Dependenciescls-hooked, continuation-local-storage, diagnostic-channel and diagnostic-channel-publishersKeywordsexception monitoring, request monitoring, performance monitoring, application insights, microsoft, azure, cloud, tracing, telemetry, analytics and apm

This README is too long to show.
unified
Author: Titus Wormer
Description: Interface for processing text using syntax trees
Homepage: https://unified.js.org

Createdalmost 4 years agoLast Updated2 days agoLicenseMITMaintainers1Releases31Direct Dependenciesbail, extend, is-plain-obj, trough and vfileKeywordsprocess, parse, transform, compile, stringify, rehype, retext and remark

This README is too long to show.
rehype-stringify
Author: Titus Wormer
Description: HTML compiler for rehype
Homepage: https://github.com/rehypejs/rehype

Createdabout 3 years agoLast Updated24 days agoLicenseMITMaintainers1Releases8Direct Dependencieshast-util-to-html and xtendKeywordshtml, abstract, syntax, tree, ast and stringify

README
rehype-stringify

rehype plugin to stringify HTML.
Compiler for unified.
Stringifies hast syntax trees to HTML.
Used in the rehype processor but can be used on its own as
well.
If you’re in a browser, trust the content, and value a smaller bundle size, use
rehype-dom-stringify instead.
Sponsors

🥇
      ZEIT

🥇
      Gatsby

🥉
      Compositor

Holloway

You?

Read more about the unified collective on Medium »
Install
npm:
npm install rehype-stringify

Use
var unified = require('unified')
var createStream = require('unified-stream')
var parse = require('rehype-parse')
var stringify = require('rehype-stringify')

var processor = unified()
  .use(parse)
  .use(stringify, {
    quoteSmart: true,
    closeSelfClosing: true,
    omitOptionalTags: true,
    entities: {useShortestReferences: true}
  })

process.stdin.pipe(createStream(processor)).pipe(process.stdout)

API
processor.use(stringify[, options])
Configure processor to stringify hast syntax trees to HTML.
options
Options can be passed when using processor.use(stringify, options) or with
processor.data('settings', options).
All settings are passed to hast-util-to-html.
Contribute
See contributing.md in rehypejs/.github for ways
to get started.
See support.md for ways to get help.
Ideas for new plugins and tools can be posted in rehypejs/ideas.
A curated list of awesome rehype resources can be found in awesome
rehype.
This project has a Code of Conduct.
By interacting with this repository, organisation, or community you agree to
abide by its terms.
License
MIT © Titus Wormer

remark-parse
Author: Titus Wormer
Description: Markdown parser for remark
Homepage: https://remark.js.org

Createdabout 3 years agoLast Updated5 months agoLicenseMITMaintainers5Releases17Direct Dependenciescollapse-white-space, is-alphabetical, is-decimal, is-whitespace-character, is-word-character, markdown-escapes, parse-entities, repeat-string, state-toggle, trim, trim-trailing-lines, unherit, unist-util-remove-position, vfile-location and xtendKeywordsmarkdown, abstract, syntax, tree, ast and parse

This README is too long to show.
remark-rehype
Author: Titus Wormer
Description: remark plugin to transform to rehype
Homepage: https://github.com/remarkjs/remark-rehype#readme

Createdabout 3 years agoLast Updated10 days agoLicenseMITMaintainers5Releases12Direct Dependenciesmdast-util-to-hastKeywordsunified, remark, rehype, plugin, html, hast, mdast and markdown

README
remark-rehype

remark plugin to bridge or mutate to rehype.

Note: remark-rehype doesn’t deal with HTML inside the Markdown.
You’ll need rehype-raw if you’re planning on doing that.

Install
npm:
npm install remark-rehype

Use
Say we have the following file, example.md:
# Hello world

> Block quote.

Some _emphasis_, **importance**, and `code`.

And our script, example.js, looks as follows:
var vfile = require('to-vfile')
var report = require('vfile-reporter')
var unified = require('unified')
var markdown = require('remark-parse')
var remark2rehype = require('remark-rehype')
var doc = require('rehype-document')
var format = require('rehype-format')
var html = require('rehype-stringify')

unified()
  .use(markdown)
  .use(remark2rehype)
  .use(doc)
  .use(format)
  .use(html)
  .process(vfile.readSync('example.md'), function(err, file) {
    console.error(report(err || file))
    console.log(String(file))
  })

Now, running node example yields:
example.md: no issues found
<!DOCTYPE html>

    <meta charset="utf-8">
    <title>example</title>
    <meta name="viewport" content="width=device-width, initial-scale=1">

Hello world

Block quote.

Some emphasis, importance, and code.

API
origin.use(remark2rehype[, destination][, options])
remark (mdast) plugin to bridge or mutate to
rehype (hast).
destination
If a Unified processor is given, runs the destination processor
with the new hast tree, then, after running discards that tree and continues on
running the origin processor with the original tree (bridge mode).
Otherwise, passes the tree to further plugins (mutate mode).
options
Passed to mdast-util-to-hast.
Related

rehype-raw
— Properly deal with HTML in Markdown (used after remark-rehype)
rehype-remark
— Transform HTML (hast) to Markdown (mdast)
rehype-retext
— Transform HTML (hast) to natural language (nlcst)
remark-retext
— Transform Markdown (mdast) to natural language (nlcst)

Contribute
See contributing.md in remarkjs/.github for ways
to get started.
See support.md for ways to get help.
This project has a Code of Conduct.
By interacting with this repository, organisation, or community you agree to
abide by its terms.
License
MIT © Titus Wormer

  Generated by :no_entry_sign: dangerJS against 4a827daa99f6b5d00ace91c8b42efb503ae4caa5

authors: cloudify digitalcitizenship

repo: teamdigitale/io-functions-commons


text:
Add 2/25 Meeting Notes

See https://github.com/tengen-io/notes

repo: tengen-io/go-stop-go


text:
Refactor styles so that mixins are used if possible

Is it possible for vars() to be used in transitions for the colors... if so... we could probably eliminate the color specific CSS for LED.

Leaving this open until we can discuss any other vars/mixins that may prove fruitful.

authors: ktiedt teomaragakis

repo: teomaragakis/polymer-knobs


text:
Logarithmic IDF document embedding weighting

Code looks good, can you maybe add a test that covers the weighting? For example here: https://github.com/textpipe/textpipe/blob/fix/naive-idf-reweighting/tests/test_doc.py#L144.

authors: AIJoris dodijk

repo: textpipe/textpipe


text:
[POC] Add Flink nightly end to end test

See https://github.com/theopenlab/openlab-zuul-jobs/pull/650

repo: theopenlab/openlab-zuul-jobs


text:
Add sort

Tested in https://github.com/tier4/autoware-spell-check-dict/pull/3

@kenji-miyake Thank you for the useful script!
BTW, Can I rename the sort.sh to sort_words.sh to clarify the intended use of the script?

@kmiya Yes, of course! I'll do it.

But actually, it sorts not only words but also ignorePath. sort_json.sh is more appropriate?

or sort_dict, sort_json_dict, sort_cspell_json?

As it's only for .cspell.json, I chose sort_cspell_json.sh. Is it okay for you?

@kenji-miyake Yeah, it's perfect!

Retested https://github.com/tier4/autoware-spell-check-dict/pull/3/commits/094b96bcc41895a1c1a9185b1ff761ed7c926dac.

authors: kenji-miyake kmiya


text:
Prepare for the 0.4.1 release

bors r+

repo: timescale/promscale


text:
krakenticker open

can you also fix the broken unit test?

Is there a way to combine these commits into one?  the test fails because of this.  I validated it locally. anyway if not I will figure out in the coming days.

I merged it. Hopefully it will pass now.

thanks. looks ok
2017-12-05 13:05 GMT+02:00 Tim Molter notifications@github.com:

I merged it. Hopefully it will pass now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/timmolter/XChange/pull/1916#issuecomment-349271653,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC0pw3YO8MlE8bJ_JoJLf0LwGxY3vZQks5s9SOOgaJpZM4QusIe
.

authors: jcuypers timmolter

repo: timmolter/XChange


text:
issue #925 CORS security flaw

Thanks!

authors: Jerbell tipsy

repo: tipsy/javalin


text:
Add stub reading from file

Looks good to me, besides 1 comment, I think it's a typo. Would be nice to create a few tomato test example, and unit test for the stub read func

Awesome job, thanks for taking action so quickly

authors: alileza martroosaare snagles

repo: tomatool/tomato


text:
Chore remove bower

Fixed https://github.com/tomchentw/react-google-maps/issues/33

repo: tomchentw/react-toastr


text:
Update Mocha link

thanks @mortonfox!

authors: mortonfox tomwayson

repo: tomwayson/esri-karma-tutorial


text:
Be able to highlight Canvas based on selection in sequence view

We needed to be able to select in the canvas and for the selection to the highlighted in the sequence view. This has been implemented. Close.

authors: ClairePA tony-yuan

repo: tony-yuan/JsHELM


text:
fix read me typo

Files changed 120。 don't commits wrap files, meta files, just commits bugs

authors: lexnewgate topameng

repo: topameng/tolua


text:
Set grub cmdline args in grub.d/ file, account for local defaults file

Tested in GCE:
root@dan-worker-testing:~# cat /proc/cmdline
BOOT_IMAGE=/boot/vmlinuz-3.19.0-25-generic root=UUID=3fe10351-012c-4a61-9c3a-0e991108f2f5 ro cgroup_enable=memory s
wapaccount=1 apparmor=0 console=ttyS0
root@dan-worker-testing:~# apparmor_status
apparmor module is loaded.
apparmor filesystem is not mounted.
root@dan-worker-testing:~# grep /etc/default /etc/init/travis-worker.conf
  if [ -f /etc/default/travis-enterprise ] ; then
    . /etc/default/travis-enterprise
  if [ -f /etc/default/travis-worker ] ; then
    . /etc/default/travis-worker
  if [ -f /etc/default/travis-worker-local ] ; then
    . /etc/default/travis-worker-local

repo: travis-ci/worker


text:
Ability to specify specific source for package installation through oneget

Nice one

authors: talcloudshare trondhindenes


text:
FIX long|short used instead of qqe_long|qqe_short

Hello @M6stafa,
I am not opposed to the renaming of the long and short variables. Are they creating conflicts or bad data downstream somewhere that I am not aware of? Just curious.
Thanks,
KJ

Hello @M6stafa,
I am not opposed to the renaming of the long and short variables. Are they creating conflicts or bad data downstream somewhere that I am not aware of? Just curious.
Thanks,
KJ

That's not just a rename, you have two variable for each long and short like: long and qqe_long.
You return the qqe_long and qqe_short but use long and short in fillna and set column names.
I faced this bug when used fillna and still has NaN in the output.

That's not just a rename, you have two variable for each long and short like: long and qqe_long.
You return the qqe_long and qqe_short but use long and short in fillna and set column names.
I faced this bug when used fillna and still has NaN in the output.

@M6stafa,
Ok. Thanks for clarifying. I will roll this into development. It helps having a little more context like in your last PR. I appreciate your help in making this library better for all.
Thanks,
KJ

@M6stafa,
Ok. Thanks for clarifying. I will roll this into development. It helps having a little more context like in your last PR. I appreciate your help in making this library better for all.
Thanks,
KJ

repo: twopirllc/pandas-ta


text:
Set cookie expiry to 1 week

I see that these failing tests shouldn't be related to the change in this PR, but they make me a little nervous so it would be good to get them figured out sometime.
The expire query param posted in the tests is confusing because it doesn't look like it is used anywhere.  What do you think about removing it from the test suite?

I've been able to sort the issue with the randomly failing tests :) It looks like the RegEx we used to parse the Authorization header wasn't valid for all the JWT tokens.
I will remove the query param in the next PR, thanks for your feedback :).
I will go ahead and merge this one for now as Rees needs it ASAP.

authors: cjcolvar okeen

repo: ubiquitypress/hyku-api


text:
add upper limit on n_children and depth to shiny_test

app can crash if this gets too high

repo: ukgovdatascience/orgsurveyr


text:
[WEBDEV-390] Add error handling for invalid IDs

Coverage decreased (-5.2%) to 94.845% when pulling 073fbba85621649ccea4068f436d8eb2ebfd84e8 on bryonywatson1:bryonywatson1/webdev-390_invalid-id-error-handling into bb513cdc36985556395c7ab98f0218e6520e1aec on ukparliament:master.

Coverage remained the same at 100.0% when pulling c8ce51147cea52daa3e084743e9d5ddf09181e26 on bryonywatson1:bryonywatson1/webdev-390_invalid-id-error-handling into bb513cdc36985556395c7ab98f0218e6520e1aec on ukparliament:master.

Coverage remained the same at 100.0% when pulling c6722873677299a2fdb65039516139b2072a445b on bryonywatson1:bryonywatson1/webdev-390_invalid-id-error-handling into bb513cdc36985556395c7ab98f0218e6520e1aec on ukparliament:master.

repo: ukparliament/parliament-ruby


text:
Sign electron executables for all OSes

Check with SignPath.io whether they work with Macs (probably not).

In the process of getting a code signing certificate from Sectigo. This will take a little while.

authors: devowit zmbq


text:
tests for ptx output width, -w 50 fails

more tests is great :)

@mike-kfed some of the tests are failing, could you please have a look?

that's kind of the point of those tests, to show that one is failing - the one with -w 50. That's why I added this as an issue #1807 and not a PR, it needs fixing ;).
When trying to implement #1763 I found even more output inconsistencies so I am inclined to wait for PR #1602 to be merged before I look into what exactly is causing that behaviour. I assume fixing the output algo will maybe close this -w arg issue too?

closing for now, sorry for jumping on the gun :)

authors: mike-kfed sylvestre

repo: uutils/coreutils


text:
Clean up predicate ref

Coverage increased (+0.73%) to 57.83% when pulling 52f1efee257c92d95ad07c78d34d01f46e2a7e19 on predicateRef into 60c011908bc5f1676e59652b62fff94c71085435 on v2.

authors: arvind coveralls

repo: uwdata/vega


text:
Add features to include all contributions (records) in Event, Stack and News

Merged.

authors: Yexiaoxing incrediblink


text:
怎么以docker或这后台启动算法插件（./bin/run.sh text）

你可以尝试这条命令 nohup ./bin/run.sh text &

repo: vearch/vearch


text:
Add diversity filter.

@havardpe Let's discuss this one. The essense is in the if branch in matchtoolsfactory.

Closing as this on is superceeded by #6535

repo: vespa-engine/vespa


text:
traduction de class-and-style.md

Merci pour la review :)
J'ai intégré la plupart des modifs, puisqu'elles étaient toutes censée.
Il y a juste le cas où j'ai répondu en commentaire, ou je n'arrive pas à trouver quelque chose de très satisfaisant.

Merci pour les review, je pense avoir fait le tour :)

Bon évidemment c'est quand j'appuie sur le bouton "merge" que les fautes me sautent aux yeux
Un S en trop ici :

La concaténations

Les S en trop ici :

". Il est également possible de lier une propriétés calculées qui retourne un objet. "

manque un S :

une liste de classe

tu crées une autre PR pour corriger ces fautes ?

@Teraglehn l'a déjà fait et c'est mergé : https://github.com/vuejs-fr/vuejs.org/pull/17


text:
Add Changelog

added

repo: watson-developer-cloud/ios-sdk


text:
Create .gitignore for builds

Thanks!

repo: weetmuts/xmq


text:
implemented to show the slack notification popover

EditorモードでのSlackのPopoverが出現するように実装しました。

原因を調査したところ

Bootstrapのdata-toggle="popover"が発火しない事が原因であることがわかりました。
ここの原因を解明する事ができなかったのですが、代替案としてreactstrapが提供するUncontrolledPopoverを使用しようと考えました。

しかしUncontrolledPopoverはpopoverの対象にidを指定しないといけないが、同ページに同じコンポーネントのUncontrolledPopoverが呼び出されているため、呼び出し側で定義したidを受け渡すことにより、それぞれのコンポーネントで一意のidを受け渡すように実装をしました。
よろしくお願いします。

repo: weseek/growi


text:
[ISSUE-22] Put transformed classes into appropriate packages

When I was playing with your asm transformer I discovered an issue - it is not some transforming someclasses. I tested it with servlet-2.3-api.jar and I can see two classes javax/servlet/jsp/tagext/TryCatchFinally.class & javax/servlet/SingleThreadModel.class were not transformed.

https://github.com/wildfly-extras/batavia/pull/24 doesn't look right, I'll merge your pr and check again.

Thanks for these changes, looks great.  I'll create a new pr or adjust https://github.com/wildfly-extras/batavia/pull/24 for the issue you mentioned.

Thanks for review & merge @scottmarlow

authors: ropalka scottmarlow

repo: wildfly-extras/batavia


text:
Jakartaee rest

@xstefank BTW is this a blocker for the quickstarts?

@xstefank @rhusar  @darranl my understanding from F2F is we are moving away from this specific archetype approach in favor of start.microprofile.io , and I'm not considering it anymore critical. Am I wrong? If not I can close the PR

@maeste That was not my impression. First of all, there are "problems" publishing WildFly in the starter, moreover, the starter will use galleon provisioning, which I don't think is going to be supported from EAP from the beginning.

Overall the full flow is still to be reviewed, but initially as it stands today we don't have archetypes for EAP so can't be basing WildFly quickstarts on them.  For the short term it sounds like we need to use the Maven archetypes already available to us and then work out the full flow for later releases which could use starter, or could still use an alternative approach such as this archetype.

@rhusar problems? I have the planning in my email from people involved to have it published as soon as we will have a final (and I have already seen a test environment using Beta1).
@darranl it was my understanding too, using the ones we already have w/o pushing for a new one (this one). Anyway, we need to write it in a document because it doesn't seem clear to everyone. It could be part of the full flow review, but maybe it's better to clarify the short term approach perhaps in our next weekly call
closing the PR

Sorry for the late entry. Yes, this is also my understanding that for now until we have the archetype available in the product we will use Maven archetypes. So this is not a blocker for QS that I've worked on.

authors: darranl maeste rhusar xstefank

repo: wildfly/wildfly-archetypes


text:
WFCORE-3226: Legacy slaves can't understand new enum version value

Once ready this will need a 3.x branch variant as well as this will end up in WF 11.

As part of this work, please send up PRs to full to change the mixed domain test to use the enum.

@bstansberry 3.x is here:
https://github.com/jbossas/wildfly-core-eap/pull/403
I'll update it with changes after I've pushed them here.

Core - Full Integration Build 5760 outcome was FAILURE using a merge of 6d44eec7d335909728cf0fae93d94d1c3f0edec0
Summary: Tests failed: 1 (1 new), passed: 4119, ignored: 110 Build time: 01:27:47
Failed tests
org.wildfly.test.integration.elytron.audit.TCPSyslogAuditLogTestCase.testSuccessfulAuth: java.lang.AssertionError: Successful authentication was not logged
	at org.wildfly.test.integration.elytron.audit.AbstractSyslogAuditLogTestCase.testSuccessfulAuth(AbstractSyslogAuditLogTestCase.java:59)

Full integration - Windows Build 4184 outcome was FAILURE using a merge of 4d4f055612c1dbbb2c28ae7c29b9b1aa5398be00
Summary: Tests failed: 1 (1 new), passed: 4115, ignored: 112 Build time: 01:44:44
Failed tests
org.jboss.as.test.manualmode.security.SecuredDataSourceTestCase.test:  at org.jboss.jca.adapters.jdbc.WrapperDataSource.getConnection(WrapperDataSource.java:146)
 at org.jboss.as.connector.subsystems.datasources.WildFlyDataSource.getConnection(WildFlyDataSource.java:64)
 at org.jboss.as.test.integration.security.common.servlets.DataSourceTestServlet.doGet(DataSourceTestServlet.java:85)
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:687)
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
 at io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:85)
 at io.undertow.servlet.handlers.security.ServletSecurityRoleHandler.handleRequest(ServletSecurityRoleHandler.java:62)
 at io.undertow.servlet.handlers.ServletDispatchingHandler.handleRequest(ServletDispatchingHandler.java:36)
 at org.wildfly.extension.undertow.security.SecurityContextAssociationHandler.handleRequest(SecurityContextAssociationHandler.java:78)
 at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
 at io.undertow.servlet.handlers.security.SSLInformationAssociationHandler.handleRequest(SSLInformationAssociationHandler.java:131)
 at io.undertow.servlet.handlers.security.ServletAuthenticationCallHandler.handleRequest(ServletAuthenticationCallHandler.java:57)
 at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
 at io.undertow.security.handlers.AbstractConfidentialityHandler.handleRequest(AbstractConfidentialityHandler.java:46)
 at io.undertow.servlet.handlers.security.ServletConfidentialityConstraintHandler.handleRequest(ServletConfidentialityConstraintHandler.java:64)
 at io.undertow.security.handlers.AuthenticationMechanismsHandler.handleRequest(AuthenticationMechanismsHandler.java:60)
 at io.undertow.servlet.handlers.security.CachedAuthenticatedSessionHandler.handleRequest(CachedAuthenticatedSessionHandler.java:77)
 at io.undertow.security.handlers.NotificationReceiverHandler.handleRequest(NotificationReceiverHandler.java:50)
 at io.undertow.security.handlers.AbstractSecurityContextAssociationHandler.handleRequest(AbstractSecurityContextAssociationHandler.java:43)
 at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
 at org.wildfly.extension.undertow.security.jacc.JACCContextIdHandler.handleRequest(JACCContextIdHandler.java:61)
 at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
 at org.wildfly.extension.undertow.deployment.GlobalRequestControllerHandler.handleRequest(GlobalRequestControllerHandler.java:68)
 at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)
 at io.undertow.servlet.handlers.ServletInitialHandler.handleFirstRequest(ServletInitialHandler.java:292)
 at io.undertow.servlet.handlers.ServletInitialHandler.access$100(ServletInitialHandler.java:81)
 at io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:138)
 at io.undertow.servlet.handlers.ServletInitialHandler$2.call(ServletInitialHandler.java:135)
 at io.undertow.servlet.core.ServletRequestContextThreadSetupAction$1.call(ServletRequestContextThreadSetupAction.java:48)
 at io.undertow.servlet.core.ContextClassLoaderSetupAction$1.call(ContextClassLoaderSetupAction.java:43)
 at org.wildfly.extension.undertow.security.SecurityContextThreadSetupAction.lambda$create$0(SecurityContextThreadSetupAction.java:105)
 at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1508)
 at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1508)
 at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1508)
 at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService$UndertowThreadSetupAction.lambda$create$0(UndertowDeploymentInfoService.java:1508)
 at io.undertow.servlet.handlers.ServletInitialHandler.dispatchRequest(ServletInitialHandler.java:272)
 at io.undertow.servlet.handlers.ServletInitialHandler.access$000(ServletInitialHandler.java:81)
 at io.undertow.servlet.handlers.ServletInitialHandler$1.handleRequest(ServletInitialHandler.java:104)
 at io.undertow.server.Connectors.executeRootHandler(Connectors.java:326)
 at io.undertow.server.HttpServerExchange$1.run(HttpServerExchange.java:812)
 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
 at java.lang.Thread.run(Thread.java:745)
Caused by: javax.resource.ResourceException: IJ000453: Unable to get managed connection for java:jboss/datasources/SecuredDataSourceTestCase
 at org.jboss.jca.core.connectionmanager.AbstractConnectionManager.getManagedConnection(AbstractConnectionManager.java:690)
 at org.jboss.jca.core.connectionmanager.tx.TxConnectionManagerImpl.getManagedConnection(TxConnectionManagerImpl.java:430)
 at org.jboss.jca.core.connectionmanager.AbstractConnectionManager.allocateConnection(AbstractConnectionManager.java:789)
 at org.jboss.jca.adapters.jdbc.WrapperDataSource.getConnection(WrapperDataSource.java:138)
 ... 42 more
Caused by: javax.resource.ResourceException: IJ031084: Unable to create connection
 at org.jboss.jca.adapters.jdbc.local.LocalManagedConnectionFactory.createLocalManagedConnection(LocalManagedConnectionFactory.java:345)

@luck3y LGTM. Please ping me when the PR to change DomainHostExcludes700TestCase is up and we'll run a custom job to prove the combination passes.

authors: bstansberry luck3y wildfly-ci

repo: wildfly/wildfly-core