text:
Searching for text in webpages

This is a Bug Report

Problem:  User experience when searching for text in webpage : https://kubernetes.io/docs/reference/kubectl/quick-reference/
E.g. when searching for rollout word first 6 hits are most probably from the navigation tree and they're not highlighted nor the cursor is moved to the result, making the search experience somehow confusing.

Proposed Solution:
NA
Page to Update:
https://kubernetes.io/docs/reference/kubectl/quick-reference/

/language en
/sig docs

/retitle Lack of visual cues for search matches in left-side menu items using browser find on webpage
/area web-development

/remove-language en

it is the browser feature not a k8s web functionality.
it cannot be resolved.

/remove kind-bug

/remove-kind bug

it is the browser feature not a k8s web functionality. it cannot be resolved. @tamilselvan1102  how did you reach this conclusion?
The issue is reproducible on other browsers e.g. edge

Interesting. @dejanu, there is a solution of hiding the hits using ~magic~ code. But I can see some future complaints rising from that too.

To be quite honest I've heard others complaining too, maybe make that the search results from the page content is shown first, instead of the search hits from the navigation tree

@dejanu
[Ctrl+f] function is common for all the browsers. if do search after expanding the left menu, browser automatically navigate to the keyword.  [Ctrl+f] function we can override but it is not prescribed.

@dejanu
attached image for your reference

A workaround: put the left nav last on the page in terms of its order in the HTML source, but leave it where it is visually.

This might duplicate https://github.com/kubernetes/website/issues/41469

/triage duplicate
/close not-planned
See issue #41469

authors: dejanu dipesh-rawat sftim tamilselvan1102 thisisharrsh


text:
umbrella issue for InPlacePodVerticalScaling documentation

What would you like to be added
### Tasks
- [ ] Documentation about new /resize subresource. (#128266)
- [ ] kubectl command for pod resize (#128296)
- [ ] Advise cluster admin to ensure validating / mutating admission policies are updated to also register for and handle `UPDATE pods/resize` requests

Why is this needed
Comments

/triage accepted

/retitle umbrella issue for InPlacePodVerticalScaling documentation

/assign
placeholder PRs:
https://github.com/kubernetes/website/pull/48503
https://github.com/kubernetes/website/pull/48576

source: gharchive/issue

authors: AnishShah sftim tallclair

repo: kubernetes/website

license_type: permissive

license_source: github-api


text:
Issue with k8s.io/docs/tutorials/stateful-application/cassandra/

This is a.

[x] Feature Request
[ ] Bug Report

Problem:
In this example, each cassandra Pod need to found a node for registring.
The pod reference is passed by parameters as
- name: CASSANDRA_SEEDS
            value: "cassandra-0.cassandra.default.svc.cluster.local"

In my case, i deploy this cluster in a namespace called nsvv.
How can i change this parameter and removing the "default" namespace WITHOUT replacing it by "nsvv" ?
is it possible to refer something like that ?
- name: CASSANDRA_SEEDS
            value: "cassandra-0.cassandra.${namespace}.svc.cluster.local"

Kubernetes Version: 1.8

One workaround is to use downward API as describe here: https://kubernetes.io/docs/tasks/inject-data-application/environment-variable-expose-pod-information/

authors: giblunziz tengqm


text:
Remove resources folder from Git

Somehow the resources folder keeps ending up in master (likely due to merges). This PR adds that folder to .gitignore to prevent this from happening.
It probably doesn't hurt to have that folder around but it's a potential source of confusion so better to eliminate it until we need it.

/assign @zparnold

@lucperkins Do you want to wait for review by @zparnold. Or would it be OK for me to just go ahead and merge this?

@steveperry-53 Feel free to merge. This folder is definitely not being used currently.

Agree about the potential for reducing confusion (I know the presence of the folder when I build locally has been an issue for me ...)
/lgtm
/approve

source: gharchive/pull-request


text:
update zh docs/tasks/administer-cluster/dns-debugging-resolution.md

To address k8smeetup/website-tasks#3609
经比对，release-1.14 到release-1.16,文档内容没有实质性修改，只有部分示例command内容发生了修改
原修改：https://github.com/kubernetes/website/commit/cad2e5c006df725b26ea89835fd152bf806740d6#diff-108b8d55763a7f2d881b894d15e12901

I don't speak Chinese, sorry
/uncc

authors: lichuqiang sftim


text:
ZH-trans：update the yaml file name

original:
For example, here’s the configuration file with a Pod name as `nginx-demo` and a Container name as `nginx`:

/lgtm

/cc @markthink

authors: tanjunchen xichengliudui


text:
Removing references of kubectl rolling-update  command

Removing references of deprecated kubectl rolling-update command. kubectl rolling-update has been deprecated and hidden since April 2018 in v1.11, and has been removed for v1.18.
Please note as part of this PR, I am removing a page https://kubernetes.io/docs/tasks/run-application/rolling-update-replication-controller/ as it uses kubectl rolling-update for replication controller.
This pull request closes #19439

Hey @rajeshdeshpande02 please address the conflicting files. Thanks!

/kind cleanup
/lgtm
/approve

/lgtm

authors: jimangel rajeshdeshpande02 tengqm


text:
remove repeat space in yamls

see  https://github.com/kubernetes/website/pull/19882/files#diff-19ab59a3d52a81dcc002f84e31511907R12
when I try to sync en/ to zh/ by scripts , I find that  . I guess that we can remove this repeat space.

/cc @sftim
Please review this change. Thanks

@rajeshdeshpande02
Thanks

/lgtm
/approve
nice-to-have

authors: tanjunchen tengqm


text:
Black Lives Matter announcement

Verbiage for Black Lives Matter announcement, discussed with @kubernetes/steering-committee earlier today.
Signed-off-by: Stephen Augustus saugustus@vmware.com
/assign @zacharysarah
Special thanks to @celestehorgan for working on the announcement support! :two_hearts:
/hold for SC review
ref: https://kubernetes.slack.com/archives/CPNFRNLTS/p1591214537073500

@justaugustus you'll want to toggle announcement true

:facepalm:

/hold for a quick edit

Great catch, @celestehorgan!
/lgtm

+1 from me

+1 on the latest revision
/lgtm

/lgtm 👯

/lgtm

/lgtm

/lgtm

Sh-sh-ship it! :shipit:
/hold cancel

/approve

authors: celestehorgan derekwaynecarr dims jimangel justaugustus onlydole spiffxp zacharysarah


text:
zh docs: add announcement in zh packages

/language zh

I don't think this localization is necessary.


text:
Fix issue with links to already translated documents

Closes #23997
Update the following documents contain the document links which are already translated into Korean:

[x] content/ko/docs/concepts/services-networking/dual-stack.md
[x] content/ko/docs/contribute/participate/roles-and-responsibilities.md
[x] content/ko/docs/reference/_index.md
[x] content/ko/docs/reference/command-line-tools-reference/feature-gates.md
[x] content/ko/docs/setup/production-environment/windows/user-guide-windows-containers.md
[x] content/ko/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade.md
[x] content/ko/docs/tutorials/stateful-application/mysql-wordpress-persistent-volume.md

/assign @jmyung

@pjhwa It seems @jmyung is working on other contributions ! :)
Let me handle this PR.
By the way,
/lgtm
;)

감사합니다! ^^
/approve

authors: pjhwa seokho-son


text:
[id] Fix list all uniq container images

en PR https://github.com/kubernetes/website/pull/28030/files
/assign @girikuncoro

thanks for the fix @Arhell
/lgtm
/approve

authors: Arhell girikuncoro


text:
Updated _index.md

Description:
Bolding style error in the passage under static pod definition.
Proposed Solution:
Update the style error by adding a space between character(*) and the word
Page to Update:
https://kubernetes.io/zh-cn/docs/concepts/workloads/pods/#static-pods
fixes: #37248

Hi, @cheeseq @windsonsea found this issue please take a look.

/retitle [zh] Fix text style in Pod concept page

The preview looks good to me:
https://deploy-preview-37367--kubernetes-io-main-staging.netlify.app/zh-cn/docs/concepts/workloads/pods/

Fixed in PR #37531.
Thanks. 🙇♂
/close

Thanks @windsonsea @Sea-n for reviewing this PR.

authors: Sea-n sftim utkarsh-singh1 windsonsea


text:
Restore an important note about API proxy

This was dropped in 1eef7424651bdc681711572e1042169faebe8e81 - I am sure it was an accident.
Originally added in https://github.com/kubernetes/website/pull/29752
Fixes https://github.com/kubernetes/kubernetes/issues/114670

/lgtm

Credit goes to @jkh52

authors: liggitt thockin


text:
Ptbr/index

[pt-br] Add content/pt-br/docs/tasks/configure-pod-container/_index.md

nothing


text:
[zh-cn] Update subject-access-review-v1.md

Formtmismatch: shoud be like this

but got this

This PR partially fixes the indentation issues. Need a followup for a more comprehensive fix.
/lgtm
/approve

authors: mahmut-Abi tengqm


text:
Add seifrajhi as approver and reviewer for Arabic localisations docs

This commit will add seifrajhi  as an owner (approver) and reviewer for Arabic content on the website.

/assign @adowair
/assign @mboukhalfa

/approve

/lgtm

/approve
Thank you @seifrajhi

authors: adowair mboukhalfa seifrajhi


text:
bugfix of gc-pipeline

fix bug of global gc-pipelinerun
add feature of gc-pipelinerun of each pipeline

reference issue: 266

/bugfix

/lgtm
/approve

/lgtm
/approve

repo: kubesphere-sigs/ks

license: MIT


text:
📖 Fix typo in doc menu

Summary
This PR adds the letter "g" where it is missing.
Related issue(s)
Fixes #

/cc @KPRoche
/cc @clubanderson

/lgtm
/approve

authors: MikeSpreitzer clubanderson

repo: kubestellar/kubestellar


text:
feat: add libc6-compat library to fix dynamic linking issue in alpine…

add libc6-compat library to fix dynamic linking issue in alpine for provider built with ubuntu. add ca-certificates to add well known cers to the truststore.

@ramekris3163 What are the problems the two lib solved? Can you give a more detailed explaination?

@ramekris3163 What are the problems the two lib solved? Can you give a more detailed explanation?

The libc6-compat apk allows alpine to support dynamic linking in libraries. For ex when a provider is built in ubuntu , by default it has dynamic linking of libraries, when we try to use the library in alpine it fails like this https://github.com/hashicorp/terraform-provider-helm/issues/59 and to fix this we need to add libc6-compat  library.
The ca-certificates apk adds well known certificates to the trust store of the container so that it will be able to connect to SSL with root CA Certificates.

Got it. LGTM!

repo: kubevela/terraform-controller


text:
Bug 2175641: Add volume from existing PVC not working

📝 Description
creating a volume from the 'use existing PVC' in Add volume modal dialog is creating a non functional PVC due to missing annotation to bind CDI to the DV
🎥 Demo

/lgtm

/bugzilla refresh

authors: avivtur metalice

repo: kubevirt-ui/kubevirt-plugin


text:
Bug 2137241: Checkbox about delete vm disks is not loaded while deleting VM

Signed-off-by: Aviv Turgeman aturgema@redhat.com
📝 Description

DataVolume is now garbage collected after creating the PVC, when trying to delete the DataVolume it no longer exists which causes it to not find the proper resource to delete.

🎥 Demo
Before:

After:

/lgtm


text:
IOThreads IOThreads Policies [test_id:864][ref_id:2065] Should honor a mix of shared and dedicated ioThreadsPolicy

/kind bug
/triage build-officer
What happened:
IOThreads IOThreads Policies [test_id:864][ref_id:2065] Should honor a mix of shared and dedicated ioThreadsPolicy
/root/go/src/kubevirt.io/kubevirt/tests/vmi_iothreads_test.go:85
Unexpected Warning event received: testvmiw6xhgk4fsg8h7668gcbsnm8lbbnbtmqx6c7d296k9s577xrv,c2f27921-31ab-4dcf-a0a5-bcf42ba2e24e: server error. command SyncVMI failed: "failed to invoke qemu-img: open /dev/null: operation not permitted"
Expected
    <string>: Warning
not to equal
    <string>: Warning
/root/go/src/kubevirt.io/kubevirt/tests/utils.go:410

How to reproduce it (as minimally and precisely as possible):
Prow Job Link
Lane:
pull-kubevirt-e2e-kind-k8s-1.17.0-ipv6

/close
Thanks @tiraboschi, closing this as duplicate of #2566

authors: rmohr tiraboschi

repo: kubevirt/kubevirt


text:
storage tests: remove standalone nfs access tests via ipv4/ipv6

What this PR does
Arguably, it's none of kubevirt's business to test that an nfs server
is reachable via it's ipv4/ipv6 IP. this is something that kubelet
should cover and is seamless from the kubevirt perpsective when
the storage is available to the pod.
this was previously discussed in https://github.com/kubevirt/kubevirt/pull/7324#issuecomment-1077350079

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

/test pull-kubevirt-e2e-k8s-1.31-sig-storage

/cc @vladikr @xpivarc
Hey! I need some help here; context https://github.com/kubevirt/kubevirt/pull/4659/commits/7d696ec551fa80de83863e268339444ae50f6064
When I rewrite the non qemu owned test to use a hostPath source instead of NFS, it fails.
Reading the code I am pretty sure the only time we will chown, is when the volume source is HostDisk, so, this test was probably just passing as a fluke. Can you point me at something that will chown the PVC sources?
(as that commit originally intended)

/cc @vladikr @xpivarc
Hey! I need some help here; context 7d696ec When I rewrite the non qemu owned test to use a hostPath source instead of NFS, it fails. Reading the code I am pretty sure the only time we will chown, is when the volume source is HostDisk, so, this test was probably just passing as a fluke
https://github.com/kubevirt/kubevirt/blob/09e7adbdbf94fefc74a3d68acd0a5b698415a25c/pkg/virt-handler/non-root.go#L66-L81
Can you point me at something that will chown the PVC sources?
(as that commit originally intended)

Please ignore! just need your review now.
The issue was https://github.com/kubevirt/kubevirt/compare/61b001608cd9742b7d23049f1bc956fd7cd4b61e..9b9541456faa248adf66309afeeb9b92c15ecc40

/cc @vladikr @xpivarc
Hey! I need some help here; context 7d696ec When I rewrite the non qemu owned test to use a hostPath source instead of NFS, it fails. Reading the code I am pretty sure the only time we will chown, is when the volume source is HostDisk, so, this test was probably just passing as a fluke
https://github.com/kubevirt/kubevirt/blob/09e7adbdbf94fefc74a3d68acd0a5b698415a25c/pkg/virt-handler/non-root.go#L66-L81
Can you point me at something that will chown the PVC sources?
(as that commit originally intended)

The intention was that https://github.com/kubevirt/kubevirt/blob/main/pkg/host-disk/host-disk.go#L232 would cover this.

/cc @vladikr @xpivarc
Hey! I need some help here; context 7d696ec When I rewrite the non qemu owned test to use a hostPath source instead of NFS, it fails. Reading the code I am pretty sure the only time we will chown, is when the volume source is HostDisk, so, this test was probably just passing as a fluke
https://github.com/kubevirt/kubevirt/blob/09e7adbdbf94fefc74a3d68acd0a5b698415a25c/pkg/virt-handler/non-root.go#L66-L81
Can you point me at something that will chown the PVC sources?
(as that commit originally intended)

The intention was that https://github.com/kubevirt/kubevirt/blob/main/pkg/host-disk/host-disk.go#L232 would cover this.

Yep, I figured that out, it's just that my grep lost this because it's using the deprecated version of chown https://github.com/kubevirt/kubevirt/blob/9b9541456faa248adf66309afeeb9b92c15ecc40/pkg/ephemeral-disk-utils/utils.go#L122-L123 https://github.com/kubevirt/kubevirt/blob/9b9541456faa248adf66309afeeb9b92c15ecc40/pkg/host-disk/host-disk.go#L257
So, 2 questions as a conclusion:

Should it be using the deprecated variation?
Do we intend to only chown the disk file (and not the entire mount recursively)?
(context-https://github.com/kubevirt/kubevirt/compare/61b001608cd9742b7d23049f1bc956fd7cd4b61e..9b9541456faa248adf66309afeeb9b92c15ecc40)

yay, I hate those tests, glad they are getting removed
/lgtm

/test pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations
/test pull-kubevirt-e2e-k8s-1.31-sig-compute-serial

/test pull-kubevirt-generate

authors: akalenyu awels xpivarc


text:
Add proxy binding mechanism.

Changes:

added new interface type (proxy)
added coreos/iptables package into glide
added unit tests
added functinal tests
updated some packages

What this PR does / why we need it:
Add a new binding mechanism call proxy.
This implementation insert iptable rules on the virt-launcher pod.
MASQUERADE all the outgoing traffic from the vm with the ip of the pod.
NAT (SNAT and DNAT) all the ports configured on the vm yaml.
NAT all the localhost traffic from the configured ports to the vm.
Release note:

proxy binding mechanism

This change is

/cc @rmohr
Can you please take a look.

/cc @phoracek @booxter
Can you please take a look on this PR ?

Rebase

There is an error for the masquerade test
{"component":"virt-launcher","kind":"","level":"error","msg":"Defining the VirtualMachineInstance failed.","name":"testvmiswlkx788gh4wjpwz78wlj55nmq8n8zft9rz66snkwq4wgnmf","namespace":"kubevirt-test-default","pos":"libvirt_helper.go:101","reason":"virError(Code=8, Domain=44, Message='invalid argument: could not find capabilities for arch=x86_64 domaintype=kvm ')","timestamp":"2018-12-02T16:40:29.751213Z","uid":"f0262580-f650-11e8-b453-525500d15501"}

for reference
https://jenkins.ovirt.org/job/kubevirt_kubevirt_standard-check-pr/2726//artifact/check-patch.k8s-multus-1.11.1-release.el7.x86_64/mock_logs/script/stdout_stderr.log
I will try to run the tests again

ci test please

@fabiand Change the interface as requested can you please take a look

Multiple error on the tests
â€¢ Failure [109.562 seconds]
Networking
/root/go/src/kubevirt.io/kubevirt/tests/vmi_networking_test.go:48
  VirtualMachineInstance with masquerade binding mechanism
  /root/go/src/kubevirt.io/kubevirt/tests/vmi_networking_test.go:616
    should allow regular network connection [It]
    /root/go/src/kubevirt.io/kubevirt/tests/vmi_networking_test.go:620

    Expected error:
        <expect.TimeoutError>: 30000000000
        expect: timer expired after 30 seconds
    not to have occurred

    /root/go/src/kubevirt.io/kubevirt/tests/vmi_networking_test.go:671
------------------------------
STEP: creating two virtual machines
STEP: waiting for the virtual machines to become ready
{"component":"tests","kind":"VirtualMachineInstance","level":"info","msg":"Created virtual machine pod virt-launcher-testvmi7tqnq7hzsqmpv45n4jdll8bfkvt5fcvxsq4679bsd9","name":"testvmi7tqnq7hzsqmpv45n4jdll8bfkvt5fcvxsq467g4gdsf6vn48","namespace":"kubevirt-test-default","pos":"utils.go:270","timestamp":"2018-12-02T21:06:03.306216Z","uid":"13adb077-f676-11e8-8b73-525500d15501"}
{"component":"tests","kind":"VirtualMachineInstance","level":"info","msg":"VirtualMachineInstance defined.","name":"testvmi7tqnq7hzsqmpv45n4jdll8bfkvt5fcvxsq467g4gdsf6vn48","namespace":"kubevirt-test-default","pos":"utils.go:270","timestamp":"2018-12-02T21:06:18.189213Z","uid":"13adb077-f676-11e8-8b73-525500d15501"}
{"component":"tests","kind":"VirtualMachineInstance","level":"info","msg":"VirtualMachineInstance started.","name":"testvmi7tqnq7hzsqmpv45n4jdll8bfkvt5fcvxsq467g4gdsf6vn48","namespace":"kubevirt-test-default","pos":"utils.go:270","timestamp":"2018-12-02T21:06:18.207509Z","uid":"13adb077-f676-11e8-8b73-525500d15501"}
{"component":"tests","kind":"VirtualMachineInstance","level":"info","msg":"Created virtual machine pod virt-launcher-testvmi2mlr9ggcv8mrsdz2bt4n2bm5pv4nclwqp9pwcfw9ps","name":"testvmi2mlr9ggcv8mrsdz2bt4n2bm5pv4nclwqp9pwc6cpk8pztr6z","namespace":"kubevirt-test-default","pos":"utils.go:270","timestamp":"2018-12-02T21:07:06.265913Z","uid":"13b2a684-f676-11e8-8b73-525500d15501"}
{"component":"tests","kind":"VirtualMachineInstance","level":"info","msg":"VirtualMachineInstance defined.","name":"testvmi2mlr9ggcv8mrsdz2bt4n2bm5pv4nclwqp9pwc6cpk8pztr6z","namespace":"kubevirt-test-default","pos":"utils.go:270","timestamp":"2018-12-02T21:07:06.266135Z","uid":"13b2a684-f676-11e8-8b73-525500d15501"}
{"component":"tests","kind":"VirtualMachineInstance","level":"info","msg":"VirtualMachineInstance started.","name":"testvmi2mlr9ggcv8mrsdz2bt4n2bm5pv4nclwqp9pwc6cpk8pztr6z","namespace":"kubevirt-test-default","pos":"utils.go:270","timestamp":"2018-12-02T21:07:06.266509Z","uid":"13b2a684-f676-11e8-8b73-525500d15501"}
STEP: expose service for the server virtual machine
STEP: check ping to google
STEP: start a tcp server
STEP: Connect from the client
{"component":"tests","kind":"VirtualMachineInstance","level":"info","msg":"[{1 \r\n\r\n$  [$ ]} {3 echo test | nc -w 1 server-tcp 8080 1\u003e /dev/null\r\nnc: bad address 'server-tcp'\r\n$  [$ ]} {5 echo $?\r\n1\r\n$  []}]","name":"testvmi2mlr9ggcv8mrsdz2bt4n2bm5pv4nclwqp9pwc6cpk8pztr6z","namespace":"kubevirt-test-default","pos":"utils.go:1712","timestamp":"2018-12-02T21:07:48.452142Z","uid":""}
â€¢ [SLOW TEST:40.909 seconds]

Run functional tests with focus
/hold

@SchSeba you need to rebase it. Also, is hold label valid still?

@booxter I will wait for the CI to finish and then I will remove the hold

The logs look good now.
on the network provider there is one error related to a know issue we have of the mac starting with "fe"
Now I think this PR is ready to be merge.
/hold cancel

@mfranczy do you mind doing a sanity check?
If @booxter can then give it's blessing the we should be good I guess.
As always: Please keep an eye on the tests.

@SchSeba please add docs

authors: SchSeba booxter fabiand


text:
refactor, network: Remove pidnicfactory

What this PR does / why we need it:
There is a global variale to at virt-launcher/virtwrap/network to mock
the podNIC interface to test the SetupPodPhase1 and SetupPodPhase2
functions, the reality is that only the generation of the nics is tested
and the rest is just passing the domain or the pid from one function to
the other.
This change remove the podNIC interface and rename podNICImpl
to podNIC and move all the code to getNICs and create a new struct
VMINetworking with the Setup functions.
The only mocked part is the NetworkHandler and it's passed from top
VMINetworking to the individual podN
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Depends on https://github.com/kubevirt/kubevirt/pull/4977
Release note:

NONE

/cc @qinqon

/uncc @AlonaKaplan @vladikr @qinqon

/cc @maiqueb

/cc @EdDev @AlonaKaplan

/retest

force-push: Rebased on latest https://github.com/kubevirt/kubevirt/pull/4977

force-push: Moved the podnic initialization code to a newPodNIC constructor

force-push: encpasulated interface finding and returning error if network is not found.

Shouldn't this PR also update the production code to use these new structs ?

https://github.com/kubevirt/kubevirt/blob/b7a0b1164be47c34e572977bcc2830d297ba23cf/pkg/virt-handler/vm.go#L488
https://github.com/kubevirt/kubevirt/blob/2d2cf7cbc234fd65c4faa99f26fd3a17cb09061b/pkg/virt-launcher/virtwrap/manager.go#L1244

AFAIU, this PR removes the need for the network mocks - the only mock required would be the driver.
You can remove the generate annotation in
https://github.com/kubevirt/kubevirt/blob/739b47753b42b30d4b9f2307d06b274579be4538/pkg/virt-launcher/virtwrap/network/network.go#L22
, right ?

There is an interface there so is good to generate a mock for it
type podNIC interface {
    PlugPhase1(vmi *v1.VirtualMachineInstance, iface *v1.Interface, network *v1.Network, podInterfaceName string, pid int) error
    PlugPhase2(vmi *v1.VirtualMachineInstance, iface *v1.Interface, network *v1.Network, domain *api.Domain, podInterfaceName string) error
}

AFAIU, this PR removes the need for the network mocks - the only mock required would be the driver.
You can remove the generate annotation in
https://github.com/kubevirt/kubevirt/blob/739b47753b42b30d4b9f2307d06b274579be4538/pkg/virt-launcher/virtwrap/network/network.go#L22
, right ?

Totally, rebasing, and fixing, thanks

Rebased on the base PR

/retest
network hiccup
pull-kubevirt-build
Unable to find image 'quay.io/kubevirt/builder:2103251826-514132c73' locally
2103251826-514132c73: Pulling from kubevirt/builder
docker: Get "https://quay.io/v2/kubevirt/builder/manifests/sha256:dc74806d77f4efaa04cf873af050cf543fca28bda24aafa48e58ea93013ba73f": net/http: TLS handshake timeout.
See 'docker run --help'.
make: *** [Makefile:9: all] Error 125
+ EXIT_VALUE=2
+ set +o xtrace
Cl

/retest

You're going to have to rebase; would you also consider splitting this commit into more than one ? Isolating the algorithm change, for change, so the reviewer has an easier time focusing on the relevant changes ?

rebased

force-push: Address @AlonaKaplan comments

Thanks!
/approve

/hold until https://github.com/kubevirt/kubevirt/pull/5062#discussion_r623038617 is replied.

/hold cancel
It's not a deal breaker; can happen in a follow up.

/retest

/retest

/restart

/retest

/retest

/retest

/retest

/retest

authors: AlonaKaplan maiqueb qinqon


text:
Write virtctl errors to stderr

Signed-off-by: Orel Misan omisan@redhat.com

What this PR does / why we need it:
virtctl was writing errors to stdout so errors couldn't be differentiated from regular output
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

virtctl errors are written to stderr instead of stdout

/cc @EdDev

@orelmisan I think this seemingly minor change does require some release notes - i.e. if I (for whatever reason) have some automation relying on the stdout of this command, it'll break).

Nice. Have you managed to check it really works?

@maiqueb you are right, a release note was added, thanks

Nice. Have you managed to check it really works?

@EdDev this was tested using manual IO redirection, for example:
$ virtctl foo 2> /dev/null
$ virtctl ssh nonexistentvm 2> /dev/null
$ virtctl ssh 2> /dev/null

Clarification: this PR lets the user the ability to differentiate errors (stderr) from general output (stdout).
A user can filter stdout, stderr or both using the shell's IO redirection feature:
$ virtctl foo 2> virtctl_errors.log
$ virtctl ssh nonexistentvm 2>> virtctl_errors.log
$ virtctl ssh >> virtctl.log 2> /dev/null

/retest-required

/approve

/retest-required

/test pull-kubevirt-e2e-k8s-1.20-operator-nonroot
/test pull-kubevirt-e2e-k8s-1.20-sig-compute-nonroot

/test pull-kubevirt-e2e-k8s-1.20-sig-compute-nonroot

authors: AlonaKaplan EdDev maiqueb orelmisan


text:
net, netstat: Remove pod network iface name normalization

What this PR does / why we need it:
Back in https://github.com/kubevirt/kubevirt/pull/1595 (from 2018), a
normalization has been added to populate the pod network iface name in
case it was missing, for compatibility reasons.
Since, another restriction was added: Only when the domain is not
reporting this iface as part of it.
As the normalization is performed now for more than 3 years and such old
virt-launchers are not expected to be supported by current
virt-handlers, this should be safer to remove.
The comment on the API, about making the iface name mandatory is also
removed, as this is known to be a valid option. Ifaces detected in the
guest by the guest-agent, with no ability to link them to an existing
network in the VMI spec will miss the name.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Depends on #6781 , please review here only the last commit in the chain.
Release note:
NONE

/sig network
/cc @AlonaKaplan @maiqueb

change: Rebase over #6781

change: Rebase

/retest

/approve

/lgtm

/retest

authors: AlonaKaplan EdDev


text:
Release Community meeting recording (July)

Acceptance criteria

[x] Upload the recording on our youtube channel
To double check:

[x] Recording is ordered (should be last one)
[x] Recording has description

Description:
This meeting’s agenda:
1.14 release
  - Workaround for PolicyServer certificates
  - Domain qualified finalizers
  - New host capability & cel-policy update
  - kwctl scaffold vap

Policies changes and fixes
  - User-group-policy now is able to check container image user
  - Env-var-policy know can validate names only

What’s coming next

Recording link
https://zoom.us/rec/play/-EAI3oA8glc16SguF7XRUvv4SPdyVhzW13aNkM8AA2p-tb-merCo-GMU1klxlj15bfuWh67_SPMZ9buf.BvEF_gunJDnvQq36?canPlayFromShare=true&from=my_recording&startTime=1720713709000&componentName=rec-play&originRequestUrl=https%3A%2F%2Fzoom.us%2Frec%2Fshare%2FefsnUg8t0ui7BUiGpJjPYEFzFilq1Ws3WhqvYmeakx4IBdu6A8oZVPTpQ25T4O-U.BnUywpxArhryFQai%3FstartTime%3D1720713709000

This is done.

authors: kravciak robertsirc

repo: kubewarden/community


text:
Added a /_health endpoint

Signed-off-by: Miquel Sabaté Solà msabate@suse.com

See https://github.com/kubic-project/caasp-container-manifests/pull/42#issuecomment-300477906

Done

Sorry about the broken build, if you rebase to master it should be green.

authors: ereslibre mssola

repo: kubic-project/velum


text:
js: removal of pending acceptance state

We are storing the minion id in session storage while it goes under
pending acceptance state. However we were not handling its removal if
the acceptance succeeded or if an error happened after the request.
This patch fixes those scenarios avoiding unwanted user experiences.
bsc#1093869
Signed-off-by: Vítor Avelino vavelino@suse.com
(cherry picked from commit a660c5b273befe3427f04036719c035fcf0635e1)

 Bug 1093869 - New nodes never leave "Acceptance in progress"


text:
Add itertools, typemap

Propose itertools and typemap.
Disclosure: I maintain itertools.

Good idea, thanks.


text:
Cannot find check file agent_pure needed for check type agent_pure

Hi, got this error while activating:

Despite the fact that the checks are running fine:

Traceback (most recent call last):
File "/omd/sites/xxxxx/lib/python3/cmk/base/automations/check_mk.py", line 1006, in execute
do_restart(
File "/omd/sites/xxxxx/lib/python3/cmk/base/core.py", line 66, in do_restart
core_config.do_create_config(core, hosts_to_update=hosts_to_update)
File "/omd/sites/xxxxx/lib/python3/cmk/base/core_config.py", line 309, in do_create_config
_create_core_config(core, hosts_to_update=hosts_to_update)
File "/omd/sites/xxxxx/lib/python3/cmk/base/core_config.py", line 381, in _create_core_config
core.create_config(config_path, config_cache, hosts_to_update=hosts_to_update)
File "/omd/sites/xxxxx/lib/python3/cmk/base/core_nagios.py", line 76, in create_config
self._precompile_hostchecks(config_path)
File "/omd/sites/xxxxx/lib/python3/cmk/base/core_nagios.py", line 94, in _precompile_hostchecks
_precompile_hostchecks(config_path)
File "/omd/sites/xxxxx/lib/python3/cmk/base/core_nagios.py", line 1076, in _precompile_hostchecks
host_check = _dump_precompiled_hostcheck(
File "/omd/sites/xxxxx/lib/python3/cmk/base/core_nagios.py", line 1217, in _dump_precompiled_hostcheck
file_list = sorted(_get_legacy_check_file_names_to_load(needed_legacy_check_plugin_names))
File "/omd/sites/xxxxx/lib/python3/cmk/base/core_nagios.py", line 1413, in _get_legacy_check_file_names_to_load
raise MKGeneralException(
cmk.utils.exceptions.MKGeneralException: Cannot find check file agent_pure needed for check type agent_pure
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/omd/sites/xxxxx/bin/check_mk", line 92, in
exit_status = modes.call(mode_name, mode_args, opts, args)
File "/omd/sites/xxxxx/lib/python3/cmk/base/modes/init.py", line 69, in call
return handler(*handler_args)
File "/omd/sites/xxxxx/lib/python3/cmk/base/modes/check_mk.py", line 1413, in mode_automation
sys.exit(automations.automations.execute(args[0], args[1:]))
File "/omd/sites/xxxxx/lib/python3/cmk/base/automations/init.py", line 60, in execute
result = automation.execute(args)
File "/omd/sites/xxxxx/lib/python3/cmk/base/automations/check_mk.py", line 1012, in execute
raise MKAutomationError(str(e))
cmk.base.automations.MKAutomationError: Cannot find check file agent_pure needed for check type agent_pure

Hello, with 1.3.1 every problem should be fixed now.

Hi, sorry for the delay.
Same issue with 1.3.1 and 1.4

same issue after upgrading to 2.1.0p28

solved it by renaming pure_agent to agent_pure in /local/share/check_mk/checks

Are you are using nagios as core?

Am 07.06.2023 um 13:03 schrieb Raphaël SCHITZ @.***>:
solved it by renaming pure_agent to agent_pure in /local/share/check_mk/checks
https://user-images.githubusercontent.com/8385646/244028801-012c06d8-0447-4d71-9157-552ad3c62f35.png
—
Reply to this email directly, view it on GitHub https://github.com/kuhn-ruess/Checkmk-Checks/issues/42#issuecomment-1580538263, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG3QJWZILDGSMJ73SWNIQDXKBNWZANCNFSM6AAAAAAR2WAG3I.
You are receiving this because you modified the open/close state.

ah thanks, then you have the slow nagios as core and that would be the reason I never noticed a problem.

Am 14.06.2023 um 15:21 schrieb Raphaël SCHITZ @.***>:
i'm not sure, it's a stock Checkmk Raw Edition installed on debian 11
—
Reply to this email directly, view it on GitHub https://github.com/kuhn-ruess/Checkmk-Checks/issues/42#issuecomment-1591199997, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG3QJREVR6PFWUQAYK6U5TXLG3GFANCNFSM6AAAAAAR2WAG3I.
You are receiving this because you modified the open/close state.

didnt know the other version have a different and faster core, looks fast enough to me already :D

You will notice the difference quickly if you have more than about 20–30 Hosts :)
Thanks, then, for the Feedback, I will make sure to fix that soon.

Am 14.06.2023 um 15:25 schrieb Raphaël SCHITZ @.***>:
didnt know the other version have a different and faster core, looks fast enough to me already :D
—
Reply to this email directly, view it on GitHub https://github.com/kuhn-ruess/Checkmk-Checks/issues/42#issuecomment-1591206024, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG3QJWB5VN7JI23L55GT2TXLG3S5ANCNFSM6AAAAAAR2WAG3I.
You are receiving this because you modified the open/close state.

authors: Bastian-Kuhn rschitz

repo: kuhn-ruess/Checkmk-Checks


text:
User Applied Filters and Custom Transformations

Story
As a data processor I want to apply some operation to my time series and then store the output time series in an MTH5.
These operations might be of two flavors:

Some linear filter that I can characterize using the existing filters in mt_metadata.
Some operator (maybe defined within a method, perhaps non-linear)

I would like to add an annotation to my MTH5 so that when I come back to open the file later (or share it with another person) there is a record of the process that was applied.
In case (1) I should be able to describe my filter using one of the pre-existing containers (e.g. PoleZeroFilter, TimeDelay, etc.).
In case (2), I may not have completely characterized the operator in terms of its complex response – the operator may be not even have a simple inverse, or at least not a known one.  At a minimum I would like to describe the process with a keyword or name, any parameters that were applied to the operator, and the order in which it was applied (if I did several of these transformations).
These filters are in general not removed by  default when calibrating the data, i.e. calling remove_instrument_response.
Background:
Currently, MTH5 offers a Filters Group, that can be used to keep an archive of filter operations during data acquisition.  Typical  examples of these filters are the transducer response, analog to digital converter, or really, any other stage of linear analog or digital operation on the data before it is archived.
Under the Station > Run > Channel level of the MTH5, each channel is associated with calibration filter information via a list of keywords, which specify the filters, and a corresponding list of booleans, describing if the archived data have the filter applied, or not applied.
The Calibration stage of processing uses these information to determine how to transform the data into physical units from what is stored in the MTH5.
Potential Solution:
Requirements:

Provides a record of additional filters applied to a channel
If these are linear, we can represent it as PoleZero, FIR, coefficient, etc.
Can also be defined by a method filter_operator(data, *args, **kwargs)

Ideally, we would augmenting the filters_list of ChannelResponse with the additional user_applied filters

Solution (1)  Allow augmenting of ChannelResponse with additional filters

Case (1): Working with "standard linear filters"

use the existing classes in mt_metadata

Set their “applied” booleans to True.

This would require additional logic in remove_channel_response because we would generally not want to remove these filters during calibration.

We could add an attribute to the FilterBase called user_applied which defaults to False, and then make user_applied filters get ignored by default in calibration / remove_intstrument_response.
i.e. calibration has a step get_list_of_filters_to_remove(self, include_decimation=False, include_delay=False), this could be modified to get_list_of_filters_to_remove(self, include_decimation=False, include_delay=False, include_user_applied=False)
when user applying custom filters they would tag user_applied=True
Note that remove_instrument_response does support a general kwarg filters_list, which the user can leverage if they want to unapply their filters.

Case (2): Custom (possibly non-linear, applied via algorithm), applied filters

Create a new class for these that extends FilterBase
For now this could be SpecialFilter

this would have  user_applied=True by default
would not have things like obspy_mapping, calibration_date, and may not have a complex_response,
may rely on name and description to tell the user about itself.
may have standard properties like units in, units_out,

This should at least support a record of a filtering workflow.
The other way around this would be to create an attribute, similar to ChannelReponse, called say UserAppliedFilters, or similar that lives at the same level as  ChannelReponse, but that seems more complicated.

To prototype this, most changes will be in mt_metadata, but mth5 ts_filters will also need an update.
Steps:

Add user_applied attr to FilterBase.  The default value will be false.

If we wish this attr to be required set required=true, if not, we will need to add a method to FilterBase class user_applied that tries to return self.user_applied, and if it gets and attribute error, returns False
Seems like required=true is simpler

{
   "user_applied": {
       "type": "bool",
       "required": true,
       "style": "name",
       "units": null,
       "description": "If True, filter was generated by user, not calibration metadata.",
       "options": [],
       "alias": [],
       "example": true,
   	"default": false
   },

Update mt_metadata channel_response.py:

Functions get_indices_of_filters_to_remove, and get_list_of_filters_to_remove both need kwargs include_user_applied=False
Logic in both the functions needs updating to ignore filters with user_applied=True

Update mth5 remove_instrument_response

takes kwarg include_user_applied=None
call to get_list_of_filters_to_remove updated with this kwarg
filters_to_remove = self.channel_response.get_list_of_filters_to_remove(
include_decimation=include_decimation, include_delay=include_delay)
include_user_applied=include_user_applied

update tests


text:
does run time means inference time  ?

how to calculate run time on kitti is it the same inference time min on every check point?

Run-time is the inference time (of the selected checkpoint) averaged over .. say a few hundred samples.

repo: kujason/avod


text:
Doesn't work in Jupyter Lab

First thanks a lot for the great work, I am using log_progress in a couple of Notebooks and it improves presentations to my customers a lot.
Currently I am shifting to Jupyter Lab and as I was running my Notebooks in Lab, I recognized, that the Progress bar isn't rendered only the VBox object text representation is appearing as a result
VBox(children=(HTML(value=''), IntProgress(value=0, max=84)))

You need to enable ipythonwidgets by running
jupyter nbextension enable --py widgetsnbextension
You can read more on install guide

Duplicate of #14

authors: PavlosMelissinos janostik pinkerltm

repo: kuk/log-progress