text:
FLEX-2851 ~ Improves documentation regarding development image.

All is well.

All is well.

 All committers of the pull request should sign our Contributor License Agreement in order to get your pull request merged.1 out of 2 committers have signed the CLA.:white_check_mark: kevinsmeets:x: web-flow

All is well.

source: gharchive/pull-request

repo: OSGP/Documentation

license_type: permissive

license_source: bigquery


text:
Flex 3448 update web net management schedule management testcode

All is well.

This pull request makes the build fail.

This pull request makes the build fail.

This pull request makes the build fail.

Pull request failed on SonarQube. Buid and tests work fine.

repo: OSGP/Integration-Tests


text:
Remove wiki and improve and update documentation on omnidb.org

Done in 2.0.3

source: gharchive/issue

repo: OmniDB/OmniDB

license: mit


text:
Config loader - check timezone valid and in country

Done!


text:
Fix dupe ids

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: rjchow yehjxraymond

repo: OpenCerts/certificate-cli

license_source: github-api


text:
New payment options sms

Also there is a merge conflict

authors: abobwhite ctwoolsey

repo: OpenDataSTL/STLCourts-client


text:
Updated vapor socks version to support vapor 1.0.0

Thanks! I'll tag a new release.

repo: OpenKitten/MongoKitten


text:
Add missing permission check for recommendation extension field.

Ok.

authors: emanuelschuetze normanjaeckel

repo: OpenSlides/OpenSlides

license: MIT


text:
TB-15 Fix wrong word

@wsj31013
Hot fix.


text:
Added Tutanota

@elijh just a gentle reminder... :-)

@elijh may I ask you to accept the pull request?

repo: OpenTechFund/secure-email


text:
Create superlinter.yml

Just learning how to use github actions. Please ignore.

repo: OperatingSystemRocket/RocketOS


text:
Change to use overc-ctl

only one minor comment about the paths, but otherwise this looks fine.

Outside of the bind mounts, this looks reasonable.
I couldn't find the immediate use of the bind mounts, I assume it is in the overc-ctl script (and I missed it?)
Depending on the answer about the impact of the bind mounts not being done, we can get some of this queued for merge.

The bind mounts are forward ported from pulsa-8, they are needed by host upgrading which is done on dom0. I can understand your concern, although, to remove the dependency to /essential(on dom0), by changing it to executing upgrading commands directly on essential, we will have to change a lot of code currently in overc python scripts. But I will do that, please ignore this bind mounts patch and merge other then, thanks.

ok. I'll cherry pick most of the patches on Friday, skipping that one. If I miss anything, just re-send them with the fixed up script.
It doesn't work now, so we can't break it :D

I've merged what I can from this.

repo: OverC/meta-overc


text:
V1.1 branch

/test presubmit-kubeflow-e2e

/retest

/retest

/retest

repo: PatrickXYS/kubeflow


text:
Code | Numeric Pattern 139

@aryashah2k kindly assign this one to me.

repo: PatternHouse/Java-PatternHouse


text:
Change license to Apache 2.0.

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   27.91%   27.91%
=======================================
  Files          23       23
  Lines        3557     3557
=======================================
  Hits          993      993
  Misses       2462     2462
  Partials      102      102

Impacted Files
Coverage Δ

cmd/fake_exporter/faker.go
86.58% <ø> (ø)
:arrow_up:

storages/test/test.go
100% <ø> (ø)
:arrow_up:

handlers/prom.go
38.97% <ø> (ø)
:arrow_up:

cmd/fake_exporter/exporter.go
0% <ø> (ø)
:arrow_up:

utils/gofuzz/gofuzz_disabled.go
100% <ø> (ø)
:arrow_up:

utils/duration/duration.go
0% <ø> (ø)
:arrow_up:

storages/clickhouse/rawsql.go
0% <ø> (ø)
:arrow_up:

cmd/promload/exporter.go
28.1% <ø> (ø)
:arrow_up:

storages/base/base.go
80.76% <ø> (ø)
:arrow_up:

cmd/fake_exporter/main.go
0% <ø> (ø)
:arrow_up:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c147b2a...e2e108f. Read the comment docs.

@vadimtk PTAL

authors: AlekSi codecov-io

repo: Percona-Lab/PromHouse


text:
Support SSL? If not,please support SSL.

SSL is supported. I added --sslcert and --sslkey arguments to the HTTP server.

authors: kjessup xuephil

repo: PerfectlySoft/Perfect


text:
Persian/Farsi Translation Added .

Thank you!

authors: Perfomer sinadalvand

repo: Perfomer/blitz


text:
All processing occurs on the main thread

Working on a solution in https://github.com/Pixplicity/sharp/tree/thread-safe.

[x] Callbacks to load SVGs in a background thread
[x] Make invocations of setLayerType() thread-safe
[ ] Make invocations of into() or intoBackground() thread-safe
[ ] By default, use background threads when loading SVGs using into() or intoBackground()

In retrospect, using background threads by default for into() and intoBackground() is perhaps not very wise. There's no facility to opt-out of this behavior, so perhaps it's best that the implementing application takes care of this.

repo: Pixplicity/sharp


text:
test: add test covergate to PushDividendPayment procedure

:tada: This PR is included in version 2.0.1-beta.59 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: polymath-devops shuffledex

repo: PolymathNetwork/polymath-sdk


text:
add cmake support

This might fail on OS X, which has cuda in lib instead of lib64.
On Thu, Dec 3, 2015 at 3:51 PM, Fisher Yu notifications@github.com
wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/PrincetonVision/marvin/pull/24
-- Commit Summary --

add cmake support
-- File Changes --
A CMakeLists.txt (18)
-- Patch Links --
https://github.com/PrincetonVision/marvin/pull/24.patch
https://github.com/PrincetonVision/marvin/pull/24.diff

Reply to this email directly or view it on GitHub:
https://github.com/PrincetonVision/marvin/pull/24

@danielsuo Can you test it on Mac? I think it will work. I do want to clean up the file in a following commit.

Resolved both the lib vs lib64 issue and the pthread problem. It turns out
that TRY_COMPILE on OS X doesn't want to work for pthread.h because we need
to enable both C and CXX in the project command.
On Thu, Dec 3, 2015 at 5:01 PM, Fisher Yu notifications@github.com wrote:

@danielsuo https://github.com/danielsuo Can you test it on Mac? I think
it will work. I do want to clean up the file in a following commit.
—
Reply to this email directly or view it on GitHub
https://github.com/PrincetonVision/marvin/pull/24#issuecomment-161798718
.

Both 2cf9229 and c7b834c cause the error pasted below on Ubuntu 15.04 for me. Fixed with 6f9f4f0.
/usr/bin/ld: CMakeFiles/marvin.dir/marvin_generated_marvin.cu.o: undefined reference to symbol 'pthread_create@@GLIBC_2.2.5'
/lib/x86_64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
CMakeFiles/marvin.dir/build.make:375: recipe for target 'marvin' failed
make[2]: *** [marvin] Error 1
CMakeFiles/Makefile2:60: recipe for target 'CMakeFiles/marvin.dir/all' failed
make[1]: *** [CMakeFiles/marvin.dir/all] Error 2
Makefile:75: recipe for target 'all' failed
make: *** [all] Error 2

Resolved by commit @947c456d80e4710d130b13ac4314029f3cf48259

authors: danielsuo fyu

repo: PrincetonVision/marvin


text:
The repo is empty

Can confirm this is in fact an issue.
Duplicate of #1

I could hardly wait to read sourceCode

Repo no longer empty. Issue closed.

authors: LomyCool ProjectDent chriszielinski dillingham

repo: ProjectDent/ARKit-CoreLocation


text:
Fixed import for Mac Os

Fixed in latest release v1.0.4.

authors: colemancda serhii-londar

repo: PureSwift/CFreeType


text:
Add launch_bounds

Wait for CI pass

repo: ROCmSoftwarePlatform/rocPRIM


text:
【修改】：线程执行函数类型，以兼容 IAR

@armink

repo: RT-Thread-packages/azure-iot-sdk


text:
The comments in a thread forum should be their own mongodb objects.

and have their own unique ids

authors: NikolasHadjipanayi mircealungu


text:
Add more information to the bower configuration file

:shipit:


text:
Criar a documentação do caso de uso: Alterar dados do perfil

Documentação Enviada na Quinta-feira pronta.

Descrever as consequências dos fluxos alternativos

Inseri mais alguns fluxos alternativos. Fiz de acordo com o prototipo que fiz de preenchimento de dados do perfil.

Brener, utilize o comando \ref{} para referenciar as figuras (veja que por isso o número das figuras estão errados). Ao se referenciar a elas use F maiúsculo: Figura.
No fluxo básico somente o usuário faz coisas, o sistema não responde suas ações?
Utilize subtópicos para estruturar seus fluxos alternativos.

realizei as alterações.

O documento não está compilado em PDF. Aguardo  a correção.

As figuras não estão referenciadas corretamente.

No fluxo alternativo, para cada item de exceção colocado especifique como o sistema deve tratá-lo (o que o sistema deve fazer). Não basta apenas citar o que pode acontecer.

Assim que o pessoal que criaram as figuras decidirem os nomes delas eu altero.

Realizei mais umas alterações.

Brener, nos tópicos não use a estrutura: Usuário: Clicar..., escreva no lugar O usuário clica... evite esse dois pontos no meio, porque todos os outros casos de uso estão escritos assim, até mesmo nos seus.
Reveja os fluxos alternativos, sempre que você colocar uma possibilidade de uso ou problema, você deve descrever os subpassos.
Veja:
Sistema Offline
– Usuário desconectado.
O que Usuário desconectado descreve sobre como tratar o caso do Sistema Offline?

Não foi feito. (2 semanas de atraso)

Realizei outras modificações, no aguardo!
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Livre
de vírus. www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail.
<#m_2069527319274945198_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
2017-10-01 17:09 GMT-03:00 Ronneesley Moura Teles notifications@github.com
:

Não foi feito. (2 semanas de atraso)
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/Ronneesley/redesocial/issues/128#issuecomment-333403087,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdH7Nm18wUJH_ws_SwSdWp0NKURDkUeqks5sn_FngaJpZM4O1Nm0
.

Vi que melhorou colocando "Sistema exibe...", mas ainda tem casos em "Usuario: ..."
Retire esses dois pontos e redija uma frase.
Mesmo assim considerarei fechada, mas aguardo essa correção.

authors: EXOxShiro Ronneesley

repo: Ronneesley/redesocial


text:
Add Edwin L to Contributors list

Hi  @cslasher, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

authors: Roshanjossey cslasher

repo: Roshanjossey/first-contributions


text:
Add Mangalnathan to Contributors list

Hi  @mangalnathanvg, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

authors: Roshanjossey mangalnathanvg


text:
Add Marcus C to Contributors list

Hi  @marcus290, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


text:
Added Rohan to Contributors List

Hi  @themathgeek13, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

Hi @Roshanjossey, I have mostly been using GitHub as a repository for my own code, and this is the first time I am making a pull request. I have used code from GitHub numerous times, and I feel it is time for me to give back! Your repository was excellent and very easy to understand and follow, thanks!

I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh


text:
Add John Paul Santos to Contributors list

Hi  @jpsantosdeveloper7, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


text:
Replace prints to stdout/stderr with FSTLogger

cool, thanks

authors: RuedigerMoeller cakofony

repo: RuedigerMoeller/fast-serialization


text:
Fix metric call

Coverage remained the same at 86.648% when pulling 2753fb8dadbfd88ae5884e29490682c13a07921e on fix_metric into acaea93412c06e1453030a61483f4841dd9ae95b on develop.

repo: RulersOfAsgard/ALAMO-scheduler


text:
Added open source license (MIT).

Hey sorry, this just has way too many changes. The {1..9}.hs are there for teaching newcomers a progression that starts very very simple and eventually becomes near useful. If you submit another pull request with just the license change I'd be happy to merge.

Oh. Forgot to point the PR to a specific commit, sorry. I'm opening a new PR with just the LICENSE file, as it was meant in the first place.


text:
Why are negative samples not used when calculating the xent ?

If negative samples means the events with negative feedback, the answer is NO. They are indeed used for calculating xent loss;
If negative samples means the counterfactual event, the answer is YES because we do not know the true feedback of these events.

repo: RyanWangZf/CVIB-Rec


text:
Implement subcommand for fetching secrets from Key Vault (KV)

Could be used e.g. to fetch & rotate certificate/key pairs.

repo: SRE-PRG/azmitool


text:
How can I get this to work with gradle?

Hi @chrisdchristo, try using this gradle configuration inside your test block:
reports {
  junitXml.isEnabled = true
}

and set report_paths: '**/build/test-results/test/TEST-*.xml'

Instructions included in readme as well.

authors: chrisdchristo jmisur

repo: ScaCap/action-surefire-report


text:
Pagination

hello

add pagination


text:
能获取预览帧的回调数据吗？

记得是可以做到的，后续加上

新版本已添加，参考 onPreviewFrame#setCameraPreviewListener 方法


text:
#44 Create submit email logic while registration

if you want to check this functionality you have to write your email and password in application.properties

repo: SoftServe-Social-Projects/GreenCity


text:
close img html tag, main.js --> main.ts in contributing part of readme

Already fixed that!

@SpacingBat3 you didn't change the main.js to main.ts in https://github.com/SpacingBat3/electron-discord-webapp#want-to-contribute-to-my-project


text:
Page

Coverage remained the same at ?% when pulling 4da4de9ac990fa290ceec10f4bc22ff872e76de6 on page into a511e301cc820acab059a63bd4a53cb738842738 on development.

authors: LocoDelAssembly coveralls

repo: SpeciesFileGroup/taxonworks


text:
Update AUTHORS

Hi @harsha3002,
Thank you for your input. Can you describe a briefly why such modification is important to you?

repo: SpiderLabs/ModSecurity


text:
SVM Analysis with PCA

This reduces the number of features to 20 from 70. (By keeping 95% of data variation)

repo: SpoonLabs/coming


text:
RFR: Update dir and cwd parameters in runners

LGTM, +1

authors: Kami lakshmi-kannan


text:
Generate a downloadable package

Just trying to update some of these: Lily has made a working example of this, right? Not sure where it is though

Just trying to update some of these: Lily has made a working example of this, right? Not sure where it is though

This is the closed PR where Lily had worked on this: https://github.com/SuffolkLITLab/docassemble-assemblylinewizard/pull/112
Includes helpful notes

authors: BryceStevenWilley nonprofittechy


text:
Clean up to work with 0.2 of montague

This fixes #1


text:
Add CGPoint extension and test it

Thanks a lot for contributing, but I don't think we should merge this. You see, a vector has a magnitude and a direction, but a point doesn't. We can add vectors, but it doesn't make sense to add points, and so on..

authors: Maryom Mazyod

repo: SwiftKitz/Graphicz


text:
Add ShowsIndicators Function to CocoaList

@Overcot I'm not sure whether this is the most Apple-like way to expose this API, given that ScrollView in SwiftUI takes in "showsIndicators" in its initializer and not as a view modifier. Thoughts?

Your point makes sense but also, we better stay with
var scrollViewConfiguration = CocoaScrollViewConfiguration

which is neat way to store everything related to scrollView configuration. If we to move showsIndicators inside all inits, in my opinion it will introduce a lot of unrelated boilerplate code which is not very convenient to support in future.
For me, ScrollView api in SwiftUI is very-very poor and IMO more appropriate comparison will be with Button and NavigationView. They both have .smthStyle() function to configure their appearance.
We could also this technique to provide function which does same.
For example, for CocoaList it could be
public func listStyle(_ style: CocoaScrollViewStyle) -> Self

or
public func listConfiguration(_ configuration: CocoaScrollViewConfiguration) -> Self

and provide api users with init for CocoaScrollViewConfiguration.
But in my opinion this option in future could slow down implementing new properties (if needed) for CocoaScrollViewConfiguration. I know that api for SwiftUIX is not stable and subject to change at any time but still a point to consider.
What I do like in your approach is using simple functions that change only one property. If api user ever needs to call several of them he can create his own ViewModifier with wrapper around them. Your approach is quite flexible to add new features to configuration and that's why I implemented this feature this way

@Overcot you're spot on with the "style" suggestion, I was thinking something more general - scroll indicator list styles. For example - HiddenScrollViewIndicatorStyle(horizontal: true|false, vertical: true|false) (similar naming to HiddenTitleBarWindowStyle). What do you think?

As for the scrollViewConfiguration - I'm making it even more flexible by moving it to EnvironmentValues (just like I've done for CollectionView). Applying HiddenScrollViewIndicatorStyle could simply transform the environment and set the required properties, without needing any further boilerplate/modifications to CocoaList.

so you think about moving from
        showsVerticalScrollIndicator = configuration.showsIndicators
        showsHorizontalScrollIndicator = configuration.showsIndicators

to
        showsVerticalScrollIndicator = showsVerticalScrollIndicator
        showsHorizontalScrollIndicator = showsHorizontalScrollIndicator

?
I Guess your approach could work.
Aren't you afraid creating multiple non interfering styles protocols for each view style configuration?
IMO for me these swiftUI Styles are not neccessarily the best api that they created. They just create method
  func style(Style) -> Self

and then create multiple structs that users can create and not necessarily create custom themselves. I guess that they went with this approach instead of enums to not deal with @unknown but meh, I would I prefer cases instead of empty Structs, but I guess we stuck with it.
So for me I don't mind creating HiddenScrollViewIndicatorStyle based api but I would like to discuss its interface.
So we create, for example
public protocol IndicatorStyle {}

Then we create one or two style(s)
public struct HiddenScrollViewIndicatorStyle: IndicatorStyle {
  public init()
}

And there im lost :)

@SapaTech @Overcot this is now fixed with a HiddenScrollIndicatorStyle!

authors: Overcot vmanot

repo: SwiftUIX/SwiftUIX


text:
4.0.1

          1 Message

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

  Generated by :no_entry_sign: Danger

authors: SwifterSwiftBot omaralbeik

repo: SwifterSwift/SwifterSwift


text:
Add facet selections to the display below search box in order they are selected

This behavior seems to be in place already.
In both Firefox and Chrome, the facet selections appear in the order they're added, with the newest on the left and the oldest on the right.

On the other hand, this doesn't appear to be the case on demos:
https://demos.library.tamu.edu/sage/discovery-context/berger-cloonan?f.genre=Tiger eye marbled papers&f.content_type=StillImage

It seems they re-order the applied filters in the same order as the facets on the sidebar.

This does not look like it will be an easy feature.
https://github.com/TAMULib/SAGE/blob/master/src/main/java/edu/tamu/sage/service/SolrDiscoveryService.java#L109
They are applied as selected on the front end, but the back end rebuilds the applied filters in the order of the facets on the discovery context.

authors: jcreel jsavell wwelling

repo: TAMULib/SAGE


text:
Update item

Build failed because of:
Integration tests have failed for unclear reasons. Please run locally for more info and/or ask for help on #landscapers-help on slack.cncf.io

Build failed because of:
Integration tests have failed for unclear reasons. Please run locally for more info and/or ask for help on #landscapers-help on slack.cncf.io

Build failed because of:
Integration tests have failed for unclear reasons. Please run locally for more info and/or ask for help on #landscapers-help on slack.cncf.io

authors: CNCF-Bot KatharineOzil


text:
fix select placeholder color in dark theme

Related https://github.com/angular/material/issues/3379

authors: alinanmorariu krokofant

repo: Teleopti/styleguide


text:
Issue #11 Add AbstractPersistentConcurrentOffHeapCache superclass

Not too familiar with the type hierarchy(ies) in there, but from what I gathered, the new abstract class introduced does not invalidate any of the existing types.
So except that test refactor remark :smile: it looks good to me.

authors: chrisdennis ljacomet

repo: Terracotta-OSS/offheap-store


text:
Auto-Recursive-Loop, when useRoddyVersion is set in ini file! (Even CLI does not change it...)

Never came up again. Close it.

repo: TheRoddyWMS/Roddy


text:
Beta

:tada: This PR is included in version 1.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: TomokiMiyauci/fonction


text:
React folder

@KiranPoudel98 looks like none of the images are working, can you update them?

@KiranPoudel98 looks like none of the images are working, can you update them?

This has been merged to the new branch and now in master together with updated doc.

authors: coolprobn poudelprakash

repo: TruemarkDev/handbook


text:
fix: Update dependencies

:tada: This PR is included in version 2.4.2 :tada:
The release is available on:

v2.4.2
GitHub release

Your semantic-release bot :package::rocket:

repo: TypedProject/tsed-cli


text:
language specification

small list of languages added. needs to be reviewed.

list added

authors: cgb37 enprieto tibbben

repo: UMiamiLibraries/sword-deposit


text:
updated casing on Dockerfile verbs

James, your PRs are quality 👍

authors: jameslamb ntdef

repo: UptakeOpenSource/cran-server


text:
Added the things you wanted

Thanks for this

authors: Vapor-Wave mrdnomaid


text:
Set response status code

Maybe add a payload: kwarg then? So that we do not have both a payload pos argument and a keyword argument in one? Will be a breaking API change but we can adjust

Adding the payload kwarg feels verbose to me. I think most of the time you just want send a response and no need to set a status code (or anything else).
What is the drawback of having both a pos and kw arg in one method definition?

The drawback is small-ish but significant. Most of the time the thing-you-make-json will come as the first argument, and it will be a Hash. Therefore if you do a call without a status: keyword, can you tell me whether the method will do the right thing (knowing it also accepts keyword arguments)?
json_response({error: "The word contained 500x more spaces than characters, status: 'bug_closed'})
In this example, if json_response accepts a generic options Hash instead of strict kwargs, can you tell me what the behavior/handling of status: key will be?

def json_response(payload, status: 200)
	puts "Called with:"
	puts "-payload: " + payload.inspect
	puts "-status: " + status.to_s
	{
		payload: payload,
		status: status
	}
end

if json_response('payload')[:status] != 200
	puts "Failed"
end

if json_response({payload: 'payload', status: 300}, status: 201)[:status] != 201
	puts "Failed"
end

if json_response({payload: 'payload', status: 300})[:status] != 200
	puts "Failed"
end

# This is the only situation where if you look at it quickly the results might be not what you expect
if json_response(payload: 'payload', status: 300)[:status] != 300
	puts "Failed"
end

Ok then

authors: dennisvdvliet julik

repo: WeTransfer/apiculture


text:
For all fields, the choices should be ordered alphabetically

Related to https://github.com/Woseseltops/signbank/issues/8

Related to https://github.com/Woseseltops/signbank/issues/8

This one was a real pain: the plugin used by stuff turned out not to support ordering the dropdown options. Fortunately, more people turned out to have this problem, and somebody has found an ugly but functional workaround.
http://stackoverflow.com/questions/18340283/jeditable-select-dropdowns-change-the-order-of-the-options

This one was a real pain: the plugin used by stuff turned out not to support ordering the dropdown options. Fortunately, more people turned out to have this problem, and somebody has found an ugly but functional workaround.
http://stackoverflow.com/questions/18340283/jeditable-select-dropdowns-change-the-order-of-the-options

repo: Woseseltops/signbank


text:
Here's another one.

Welcome aboard :) It's great to have you!

authors: anxlgit neauoire

repo: XXIIVV/webring


text:
Annotation String needs better formatting

Fixed by: 906ee66e7


text:
Create LICENSE

Finish to merge

repo: acerwebai/Main-tc


text:
refactored code to store thumbnails and most recent users - #19

PR for issue #19


text:
Renaming

Merged as f77e459af7265f2050fe846ac9ac972b5d1ce58e.

authors: agacek backesj

repo: agacek/jkind


text:
Infer operations with other query params

Coverage decreased (-5.02%) to 94.614% when pulling 37a78ec600d7dfa4f505b6f7e5ffd6d238f02b6b on quintype:dynamic_operations into 7e4824a01d38414986dc145ba251752468067e28 on agschwender:master.

When using both rotate and resize operations, the order can matter. When auto-rotating JPEGs from EXIF orientation data, if you do op=resize,rotate you can get a different result than op=rotate,resize. Something to be aware of if you're inferring those options.

I always prefer explicit to implicit as I think it makes things clearer to the implementer. However if this is something you'd prefer, I'd recommend implementing it as an extension via overwriting the get_argument method.

authors: agschwender coveralls gja xtagon

repo: agschwender/pilbox


text:
Run the config file through ERB to pull secrets in from ENV

@jimmyngo I've rebased this on master and it's passing the build now.

We don't encrypt our config file, so it would be insecure to commit them to the repo. We prefer using ENV for this, the secrets can still be put in the ENV directly if that's what you want to do, but this just enables you to be more secure with your secrets.

There's a few new classes of errors that can occur when calling ERB.new with invalid syntax/usage. We should handle them all, or change the error handling to something more generic.

authors: JKHiggins jimmyngo

repo: airbnb/interferon


text:
tvOS support

:+1:  Thanks!

authors: aleclarson yonaskolb

repo: aleclarson/emitter-kit


text:
bugfix: prevent exceptions when no transform options are specified

I can't merge this pull request, because it has a lot of changes not related with a fix itself. Please, try to provide smaller diff without:

file renames,
remove of ,
comments rename

Also in tests I don't use to., simply throw, not.throw.

authors: alekseykulikov jameslnewell

repo: alekseykulikov/browserify-test


text:
Make it compatible to browserify

:+1:

This is working for you? I'm having no luck.
package.json:
"dependencies": {
  "ng-img-crop": "git://github.com/herpiko/ngImgCrop.git"
}

module:
require('ng-file-upload')
require('ng-img-crop')

var group = angular.module('group', ['auth', 'ngFileUpload', 'ngImgCrop'])

error in console:
angular.js:13271Error: [$injector:unpr] Unknown provider: eProvider <- e <- imgCropDirective

authors: damionvega herpiko keithbranton


text:
AndFix能替换xml文件吗

应该不能。特殊xml文件比如layout和strings和value都被aapt编译成了resources.asrc文件了，地址偏移理论上每次编译都不一样（除非用public.xml铆定），所以Andfix的dex patch方法不可能改变它。

我测试过，的确不能

不能，也试过的

authors: Comori J-mate chundongwang sukeygithub

repo: alibaba/AndFix


text:
Improve user experience

Codecov Report

Merging #162 into master will decrease coverage by 0.14%.
The diff coverage is 70.83%.

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   85.73%   85.58%   -0.15%
==========================================
  Files          50       50
  Lines        2979     2997      +18
==========================================
+ Hits         2554     2565      +11
- Misses        313      316       +3
- Partials      112      116       +4

Impacted Files
Coverage Δ

openapi/output_filter.go
98.73% <100%> (+0.04%)
:arrow_up:

openapi/pager.go
82.72% <61.11%> (-4.65%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6c51d...e9ad38c. Read the comment docs.

要测试覆盖到哦。

authors: JacksonTian codecov-io night556

repo: aliyun/aliyun-cli


text:
DO NOT MERGE Add backwards compatibility with Elements

Wondering if we can leave the assets folder out.
Instructions would include copying your assets folder to lib/backwards-compatibility/govuk-elements so that you're in the same situation you were in before

closing in favour of #553

repo: alphagov/govuk-prototype-kit


text:
Update graceful-fs to remove deprecated natives dependency

This should fix https://github.com/andrewrk/node-s3-client/issues/215, right?

Hi,
Any update on this? We all urgently need it, as the node 12 is a minimum requirement for our projects.

authors: andjosh gtzinos josephfrazier


text:
Also install bc in the installation script

Did you check if the eurosys one liners run without error with this update?

Yes I did run a subset of them on my machine and the execution times are properly reported.

@nvasilakis Update image served by img.pash.ndr.md

authors: angelhof nvasilakis zyrolasting

repo: andromeda/pash


text:
build: do not remove html and css from the release

LGTM

authors: hansl jelbourn


text:
Sjf: OS page replacement algorithm

Could you write info about the program as a comment in the start?

sure @aniketsharma00411

@aniketsharma00411 may be now its good to go with that short introduction of what it is :)


text:
Issue 1

Fixes AB#10

Reopened


text:
check for the proper functioning of the code

I would like to work on this issue :)

I would like to work on this issue.

assigned to both of you, join the channel and discuss it further

I would like to work on this issue.

assigned to youas well, join the channel for this particular issue and discuss it further

I would like to work on this issue #6.Please assign me.

I would like to work on this issue #6.Please assign me.

I want to work on this issue

I want to work on this issue

I would like to work on this issue

I would like to work on this issue

I am looking forward to work on this issue

I am looking forward to work on this issue

Assigned to @sagnik1511  for now, if It isn't completed, it will be assigned to the next person.

Assigned to @sagnik1511  for now, if It isn't completed, it will be assigned to the next person.


text:
Use Hadoop 3 exclusively for Accumulo 2.0

I tested this with uno and Hadoop 3.0.2 and it worked fine.

I tested this with uno and Hadoop 3.0.2 and it worked fine.

Have you tried 3.1.0? Last I heard, 3.1.0 is closer to what they'll call "GA" than 3.0.x

I did not see 3.1.0 on the Hadoop website! I saw 3.0.3 as the latest, but it wouldn't download from Maven, so I dropped back to 3.0.2. I would be happy to try with 3.1.0, though.

I found it. It was further down on the list.

3.1.0 seems to have problems with resource utilization on my laptop... I'm not able to get it to run, but I'll try on a beefier machine another time.

What happens if a user tries to use Accumulo 2.0 with Hadoop 2.x?  If there isn't a proper error message currently, I think it would be good to create an issue.

@mikewalch We're not banning the use of Hadoop 2.x... we're just changing the build and testing to expect it by default. It's possible it will still work... if the user deploys it with an appropriate class path (in fact, it definitely still works now). This isn't about forcing users to use a particular version... it's just about what we're focusing our support around.
Similarly, we wouldn't give an error message if a user used log4j 1.2.15, even though we're using 1.2.17; I don't think we should give an error message here, either.

@ctubbsii, sounds good to me. I thought this PR meant Hadoop 2.x would not work in the future. I didn't want users to get weird errors and not know it was due to using Hadoop 2.x. If it "works" but it isn't officially supported, that works for me.

authors: ctubbsii joshelser mikewalch

repo: apache/accumulo


text:
GUACAMOLE-656: Explicitly depend on maven-surefire-plugin 3.0.0-M1 due to SUREFIRE-1588.

Yikes! Glad it's an easy fix.

authors: jmuehlner mike-jumper

repo: apache/guacamole-client


text:
Ignite 2.1.1.b6

PR is not associated with a ticket. Apache Ignite issues are managed under Apache JIRA: https://issues.apache.org/jira/projects/IGNITE/
Please see how to associate ticket and PR in:
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-Creation
Closing PR (which seems to be test-only) due to inactivity.
Feel free to reopen this PR if it is actual.

authors: apopovgg dspavlov

repo: apache/ignite


text:
HAWQ-1480 - Added documentation for packcore utility

@dyozie this PR is pending for review. The packcore utility is already committed in hawq branch. This PR addresses its usage.

@janebeckman Thank you for the review. Incorporated your review comments in the latest commit.

repo: apache/incubator-hawq-docs


text:
Where can I find detailed documents about Executor class!

The api docs are currently available alongside the implementation. https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/executor.py

@apache/mxnet-committers: This issue has been inactive for the past 90 days. It has no label and needs triage.
For general "how-to" questions, our user forum (and Chinese version) is a good place to get help.

@szha this issue has been idle for a while. Can this be closed ?

repo: apache/incubator-mxnet


text:
fix typo in comment: 'snaphots' to 'snapshots'

Lgtm

authors: bhamail oscerd

repo: apache/karaf


text:
KYLIN-3527 fix grunt script - font build

Can one of the admins verify this patch?

repo: apache/kylin


text:
[64-bit] Patches to support running on 64-bit architectures.

could you prefix and name commits similar to rest of the code?  ie
"porting: Add support for running on 64-bit architectures"

authors: sjanc turon

repo: apache/mynewt-nimble


text:
PARQUET-1033: Improve documentation about WriteBatchSpaced

+1 LGTM after pushing the commit.

authors: majetideepak xhochy

repo: apache/parquet-cpp


text:
PARQUET-1255: Fix error message when PARQUET_TEST_DATA isn't defined

@xhochy I tried to merge this commit yesterday and followed the instructions in dev/committers-guide.md  at 2. Add your gpg key to the Apache Parquet {format,mr,cpp} KEYS file:
I get the following error:
$ git clone git@github.com:apache/parquet-cpp.git
Cloning into 'parquet-cpp'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Can you help me? Thanks!

@majetideepak Make sure your ASF and github account is correctly linked: https://gitbox.apache.org/ (you will need to activate 2 factor auth in Github).

I missed this step! Thank you!
On Thu, Mar 29, 2018 at 7:40 AM, Uwe L. Korn notifications@github.com
wrote:

@majetideepak https://github.com/majetideepak Make sure your ASF and
github account is correctly linked: https://gitbox.apache.org/ (you will
need to activate 2 factor auth in Github).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/parquet-cpp/pull/448#issuecomment-377208606,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE2vV4L6IqMoBeE2q5Rbw2vh6O2uth8nks5tjMgugaJpZM4S87n4
.

--
regards,
Deepak Majeti

authors: majetideepak pitrou xhochy


text:
update data catalog jsons

self-merging again :)


text:
How to reset SessionId

SessionIdStorage.resetSessionId(getApplicationContext());

repo: api-ai/apiai-android-client


text:
Document supported and unsupported recursive referencing

IIRC a few circular mixins are not supported. @w-vi will have a better idea. We need to add that.

@pksunkara I don't see a case where it is supported via mixins during my own testing. My changes state it does not work in Type Inheritance (section 5) where Mixins are a subsection of Type Inheritance thus I stated this is not supported for Mixins.

So I looked at the fixtures and code and the way it is described in the spec is good.

👍

authors: kylef pksunkara w-vi

repo: apiaryio/mson


text:
Add "SE-0187 Introduce Sequence.filterMap(_:)"

Please ignore me, I somehow was looking in the wrong directory.

authors: moiseev rjmccall

repo: apple/swift-evolution


text:
[Swift] Need to qualify StringRef after some header cleanup

@swift-ci Please test

repo: apple/swift-lldb


text:
Some more spring cleaning trying to get the bots green.

@swift-ci test and merge

TestLongLoops passes unexpectedly on the bots but fails in PR testing.
@alexbbrown I'm at a loss here, can you please take a look?
(if you can't right away, I'll just skip this test, because it's too flakey to run in a PR setting).

@swift-ci please test macOS

@swift-ci test and merge


text:
Merge master into master-next and fix conflicts

@swift-ci please smoke test

repo: apple/swift


text:
UnXFAIL Runtime/async_task_handle_cancellation.swift

@swift-ci Please smoke test and merge


text:
os overlay: Fix XPC dependencies. Hopefully the last change with this

@swift-ci please smoke test

@swift-ci Please test macOS

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 582c6bd16b5008c6fe141382cb6d015013fc9072
Test requested by - @shahmishal

This failed because it was already merged.

authors: erg shahmishal swift-ci zisko


text:
Misc/update names

I can't access this branch because the branch name includes a "/".
Our local Git Guro says as follows:
Please rename your branch name to not use slash.
The slash is used for origin purposes, e.g. origin/master, which is this branch's case would result in origin/misc/update-names' which will require extra escaping when used.   In general /and:` should be avoided when naming branches.

authors: Infernion yonatanLehman


text:
Fix typo: corosponding -> corresponding

I feel like you def have signed that CLA!

Hm this is odd. I had pushed the code under the wrong email at first, then amended the correct email. The CLA never got fixed. I'm going to close this PR and try opening another one.

authors: austinkelleher brianleroux

repo: arc-repos/arc-workflows


text:
Add section on readme about how to remove/uninstall connector from the device

Actually we need to implement the uninstall functionality directly into the connector :smiley:
Anyway i.e. on a raspberry pi the following commands can be issued to clean completely the connector installation

authors: rsora smellai

repo: arduino/arduino-connector


text:
Timezone support using django.utils.timezone

Coverage increased (+1.3%) to 56.026% when pulling 0c3959d96d39db24e167df60a756d31847964b0a on perroOne:patch-3 into 147e8d169324d8e196936b4eea11e27b17b8683e on arteria:master.

@perroOne let me know if i can help you with your pull request.
Arte there some issues with using django.utils.timezone?

Hi Walter
I ve tried to use it but as I'm not an expert, when Travis run tests there
is an error.
In my projet and my use case it works.
I will try when I will have time to understand that error on Travis to
solve it.
Thanks a lot,
Le 27 janv. 2017 09:32, "Walter Renner" notifications@github.com a écrit :

@perroOne https://github.com/perroOne let me know if i can help you
with your pull request.
Arte there some issues with using django.utils.timezone?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/arteria/django-openinghours/pull/20#issuecomment-275613770,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALDyWdvDKSO1l67ezychRHLX7afTiwRWks5rWausgaJpZM4LvKcD
.

I haven't seen the error travis is running into, but when you leave your PR open we can have a look and maybe help you fixing it.

authors: coveralls perroOne walterrenner

repo: arteria/django-openinghours


text:
WIP disable livefyre/enable GH issues

Closing until we're ready.

@Rick-Anderson It's my understanding that we'll have to force a publish when the docfx.json file changes. Do we know how to accomplish that in the OPS Portal?

I know how to if you need help @scottaddie. But usually docfx.json changes automatically trigger one. Even the PR already properly shows the buttons on the pages.

authors: Rick-Anderson mairaw scottaddie

repo: aspnet/Docs


text:
Left padding incorrect in upload control when no icon used

Fixed.

repo: asyncdesign/webui


text:
Make csv importer use GraphBuilder

Current coverage is 87.67% (diff: 100%)

Merging #2600 into master will decrease coverage by 0.08%

@@             master      #2600   diff @@
==========================================
  Files           237        237
  Lines         17929      17913    -16
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits          15735      15706    -29
- Misses         1950       1965    +15
+ Partials        244        242     -2

Diff Coverage
File Path

•••••••••• 100%
samples/go/csv/read.go

Powered by Codecov. Last update 1b256fa...1bc2238

I didn't understand the codecov/changes failure list above. I looked and I can now see it is highlighting some lines that are no longer being called which is useful. Please remove goMapToNomsMap function as it is now dead code. You might examine the other highlighted items too to see if these are expected not to be called any more.

How does this affect perf ooc?
On Wednesday, September 21, 2016, Mike Gray notifications@github.com
wrote:

I didn't understand the codecov/changes failure list above. I looked and I
can now see it is highlighting some lines that are no longer being called
which is useful. Please remove goMapToNomsMap function as it is now dead
code. You might examine the other highlighted items too to see if these are
expected not to be called any more.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/attic-labs/noms/pull/2600#issuecomment-248614543, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAE6BIgiBD9xefhNOvYGZ6F16qq-W-WBks5qsTMVgaJpZM4KCP61
.

--
a (phone)

@aboodman see comment above - already looped in @kalman to make sure we have a before/after picture of nested maps.

@boodman @kalman @mikegray It's unclear what the performance implications will be for this change. We were doing all this in memory before and now we're writing to disks. My guess is that it will make tests that were using a small to moderate amount of memory a bit slower. The real benefit is on test cases that work on really large maps that overly tax memory consumption.

It is private data, but this would be a good test to show the benefit of less memory consumption:
https://github.com/attic-labs/testdata/tree/master/fm-loan

It is private data

testdata is public

Okay, read the README - the data isn't there - we can't share it - but you can download it and use it.

I do agree it would be good to add a perf test for this (prior to checking this in, so we get a diff).
Incidentally we do record memory usage stats, sort of - the memory usage after running the test. If we wanted to actually determine something interesting, we'd want to:

record a memory-before stat as well
surface memory usage in the UI
convince ourselves it's actually reliable (I doubt it)

the data isn't there - we can't share it - but you can download it and use it

Hm, ok. Can't use it for perf tests then.

@mikegray PTAL

doesn't look like you removed the dead code - goMapToNomsMap.

back to you

@mikegray PTAL

lgtm, once you add a comment to the primaryKeyValuesFromFields as suggested above.

lgtm

authors: aboodman codecov-io kalman mikegray willhite

repo: attic-labs/noms


text:
Update jspm

@EisenbergEffect can you merge that one next time we create a release?

Closing as there has been a newer version released and we'll fix this up as part of a set of repo maintenance including this, new linting and docs generation.

repo: aurelia/animator-css


text:
Any usage indication plz ?

Hi,
The documentation of CoreBundle is here: https://github.com/avoo/QcmCoreBundle/blob/master/README.md
If you want to use all fonctionality, please install "qcm-standard". See the documetnation here:
https://github.com/avoo/qcm-standard/blob/master/README.md
Thanks,
Avoo

authors: NadaTc avoo

repo: avoo/QcmCoreBundle


text:
self host duniverse!

This is now ready for merge.  One hitch is that the duniverse'd up repository doesn't build with dune-master, due to the dune.configurator builtin library not being found.
$ make
dune build
File "duniverse/base/src/discover/dune", line 1, characters 41-58:
1 | (executables (names discover) (libraries dune.configurator)
                                             ^^^^^^^^^^^^^^^^^
Error: Library "dune.configurator" not found.
Hint: try: dune external-lib-deps --missing @@default
Makefile:6: recipe for target 'build' failed

I've filed https://github.com/ocaml/dune/issues/2679 upstream to figure this out, but the current tree is mergeable with dune 1.11.3

Note:

I've disabled the OCAMLFORMAT tests, as they break with the dune file generated the duniverse. I don't think its worth bringing ocamlformat back until the tool is more stable.
The CI now builds with a git clone; dune build and then does the opam installation.

Can you point to one of the failures with ocamlformat? If it's easy enough to fix I'd like to keep that check!

Another remark I have is that now that we vendor dependencies it might make more sense to remove them from the opam file.
I think it'll be hard to keep valid constraints there since opam isn't part of the duniverse development workflow anymore. I agree we can't do it now as we don't have a pure duniverse way of upgrading to the latest opam version but I think we should try to integrate that ASAP!
What do you think?

authors: NathanReb avsm

repo: avsm/duniverse

license: ISC


text:
update: remove config option for no-did-mount-set-state rule

LGTM

authors: paulyoung rygine

repo: awakenetworks/eslint-config-awake


text:
Add bootstarpServers and headers to Kafka event

Codecov Report

Merging #385 (20a2917) into master (99b35f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   72.22%   72.22%
=======================================
  Files          19       19
  Lines         738      738
=======================================
  Hits          533      533
  Misses        138      138
  Partials       67       67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99b35f2...20a2917. Read the comment docs.

authors: codecov-commenter ianpyw

repo: aws/aws-lambda-go


text:
Update 2.6 documentation issue #459

LGTM

authors: hluu logiclord

repo: azkaban/azkaban


text:
Replaced code -> js

😄 Thanks

authors: ellenaua hzoo


text:
pull

comment

repo: barryclark/jekyll-now


text:
Remove admin_secret from riak-cs.conf and stanchion.conf [JIRA: RCS-307]

Maybe, stanchion too.

Working branches:

https://github.com/basho/riak_cs/compare/2.1...ku/remove-admin-secret
https://github.com/basho/stanchion/compare/2.1...ku/remove-admin-secret

Pull requests (now running RT):

https://github.com/basho/riak_cs/pull/1279
https://github.com/basho/stanchion/pull/108

Memo: doc change needed.

Change summary:
Riak CS and Stanchion both used riak-cs.conf or stanchion.conf to tell the system who was the administrator, with admin.key and admin.secret. Writing down admin.secret in non-encrypted form may risk the whole system of the secret being stolen. Administrator is able to (1) list all users, (2) disable/enable other users, (3) changing user accounts. Workaround for this is probably encrypting the partition that includes /etc/riak-cs directory.
These changes will enable Riak CS and Stanchion start up without admin.secret specified in configuration files, while admin.key is still needed. Even if admin.secret is written in those files, Riak CS and Stanchion ignores them. Initial procedure to create the very first account starting anonymous_user_creation = true does not change, though.

Another related PR: https://github.com/basho/riak_cs_multibag/pull/33

hey guys -- could you update http://docs.basho.com/riak/cs/2.1.1/cookbooks/configuration/riak-cs/ to reflect the current correct and best practices in regard to the admin secret? I'm confused.

Plus one. Do we need to put the admin secrets in the file or not?

authors: ParthKolekar TJC kuenishi shino


text:
#134: use prebuild composer from composer:latest docker image

LGTM!

authors: ceckoslab eliskovets

repo: basicrum/backoffice


text:
High-level UX / UI Approach

@mzmichellesmith - I think there has been a mistake in assigning this to me. I am not familiar with this project.

@mzmichellesmith - I think there has been a mistake in assigning this to me. I am not familiar with this project.

@mzmichellesmith I think there has been a mistake in assigning this to me. I am not part of this project.

@mzmichellesmith I think there has been a mistake in assigning this to me. I am not part of this project.

authors: beyro byronbcgov mzmichellesmith

repo: bcgov/SIMS


text:
failling a participant should fail questions too

This issue was moved to Dallinger/Dallinger#136

authors: DallingerBot thomasmorgan

repo: berkeley-cocosci/Wallace


text:
Add a colon to chat name autocomplete

Will that autocomplete all mentions of a name with :?
If so I suggest you instead do the following:

If the tab-completed word is the first in the line, add the :
if it's anywhere else in the line, do not.

This way I can autocomplete like this:
sele<TAB> did you read edn<TAB>'s blog post? to
selenamarie: did you read ednapiranha's blog post?

authors: fwenzel selenamarie

repo: bigboringsystem/bigboringsystem


text:
Add test_package

@grafikrobot


text:
memote CLI should provide help info if no args given

At the moment the tool is set up to run the test suite without subcommands. I could change that and then print out the help without arguments. Or I could add the hint to run memote -h to the current complaint about there being no model.

repo: biosustain/memote


text:
Change rate and filling level command

I cherry-picked the two relevant commits now.


text:
Added new location for docker bosh release

@dpb587-pivotal CFCR maintains that repository. I am not sure if you still need to support old link. My understanding was that you'll check the load and eventually delete the old link when it is not accessed anymore.

What we typically do is just stop following/listing the original repository, if that's okay with you? If you know your users are tracking bosh.io for the release, you'll just want to make sure they're aware it will stop listing new versions.

I went ahead and removed the cf-platform-eng/docker-boshrelease release; they should still be accessible on bosh.io for existing consumers, but cloudfoundry-incubator/docker-boshrelease should be recommended for new consumers and versions.
Let me know if that becomes an issue for some reason and we can restore it for a grace period.

FYI, a few semi-recent versions needed to be skipped due to missing golang packages. I think we discussed those package/blob issues in Slack or somewhere previously.

repo: bosh-io/releases


text:
Issue 17 device lock

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #20   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          35     35
  Lines        1005   1012    +7
=====================================
+ Hits         1005   1012    +7

Impacted Files
Coverage Δ

cmd/list_thermostats.go
100% <100%> (ø)
:arrow_up:

cmd/list_switches.go
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f8e09...59d409b. Read the comment docs.

authors: bpicode codecov-io

repo: bpicode/fritzctl


text:
Add Frideos library sample

Cool, thanks so much! Always happy to see new techniques :)
I'll do a thorough code review in the next couple of days.

Perfect! Hope my implementation it is not too simplified, my aim was to make a "light" implementation of the BLoC pattern (maybe not 100% compliant) to be easier to adopt

@brianegan many thanks for accepting the PR and for the feedback:-) I cleaned up the code, improved the readme of my sample and edited the readme.md and index.html.

It seems that after my changes my sample doesn't pass the travis tests, but I did only small changes and I don't have such issues running the tests locally (both unit tests and flutter drive). Is this related to the timeout or is indeed a problem on my changes?

@mmcc007 Does #123 resolve the testing issue here?

#123 is unrelated to unit/widget testing part of the build.
In each project directory 'script/runTests.sh'  calls:
flutter test --coverage

This command is failing in frideos_library project directory. The command is also hanging causing the build to timeout (after 10 minutes).
The command apparently works for all other projects. So there is probably something specific to the frideos_library that is causing this command to fail.

BTW: it is possible to reproduce this problem on desktop using something like:
git clone https://github.com/frideosapps/flutter_architecture_samples.git
cd flutter_architecture_samples
git checkout remotes/origin/frideos_library
cd frideos_library
flutter test --coverage

I don't see anything obvious that might be causing this problem but suspect a versioning/config issue. As a 'sanity' test, might be worth writing a simple dummy test, to see if testing with coverage will run in the project.

@mmcc007 Thanks for the help! I didn't realize the problem was the coverage option, because without it the tests passed with no issues.
Debugging my code I found this was caused by a call to an empty function that I thought it wouldn't cause any flaws. I haven't clearly understood why the first time the test passed. I fixed this bug and looking at the travis testing process it seems that it works now.

@frideosapps Glad you got it working.
The code coverage tooling in Flutter injects a layer between the test and the Flutter engine to produce a code coverage file. I'm guessing this can lead to timing assumptions about the tests that have isolates/threads/futures, etc.. that don't surface during normal test runs.
Should probably add something to docs for guiding contributors to run coverage reports.
BTW: can run coverage report on project locally using something like:
brew install lcov
...
flutter test --coverage
genhtml coverage/lcov.info -o coverage --no-function-coverage -s -p `pwd`
open coverage/index.html

@frideosapps I wouldn't worry about the small change in code coverage.
The number to roughly meet or exceed is the current overall code coverage which is 67.12%.
Your project is 66.1% which takes the overall coverage to 67.08% which is enough to trigger a rule somewhere.
If so inclined, you can add some more tests to avoid triggering rule.
BTW: running report on project locally will give you the same 66.1% so can use it as a guide.

@mmcc007 Sure, I'll work on tests to increase the tests coverage. I am on windows so I can't use genhtml (even if I've seen there is a way to use it on msys2) but I found an extension for atom, that it seems working nice.

@mmcc007 I added some tests, now my local test coverage is 80.67%, but it seems now some samples are failing on this:
"brew install cocoapods || echo 'ignore exit(1)'
brew link --overwrite cocoapods
Error: No such keg: /usr/local/Cellar/cocoapods
The command "brew link --overwrite cocoapods" failed and exited with 1 during.".

Restarted failing jobs (looked like transient travis failures)... so should be good to go.

Thanks for all the help @mmcc007 and @frideosapps  :)

LGTM

Green build:) Thanks for the support @mmcc007 and @brianegan, and again for considering my contribution.

Absolutely, thanks again for the wonderful contribution :)

authors: brianegan frideosapps mmcc007


text:
merged t2d and master gradle dependencies

jenkins

repo: broadinstitute/hail


text:
Fix for https://github.com/brocaar/loraserver-docker/issues/5

Good catch! 👍

authors: adarshmammen brocaar

repo: brocaar/loraserver-docker


text:
Add config option to opt out of sending anonymous statistics

Great Idea!

However, I will change the name of the config option to "nostatistics".

authors: josselex rbannat

repo: browser-update/browser-update


text:
Add scalastyle to build process

Spring clean-up. Abandoning. Busy Machines commons shall rise again from its ashes.

authors: lorandszakacs paulsabou

repo: busymachines/busymachines-commons


text:
ci: cache npm dependencies

:tada: This PR is included in version 1.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

repo: bylapidist/website


text:
make dependencies go getable

@yunxing Can you take this one?

repo: c-fs/cfs


text:
[zh-*]Translate Error message for JSON validation

Thanks

authors: caouecs overtrue

repo: caouecs/Laravel-lang


text:
Can we use Jira Collector against a Kanban board of multiples projects?

@vram001 , thank you for reaching out regarding your Jira Collector question.  Unfortunately, the Feature widget will only work for one project/scope at a time as it is currently designed.  You will need to make multiple dashboards for each "team" (project).
That being said, the recent back-end changes to the Jira feature content now allow you to configure workflow mapping for any statuses in your Jira instance, including Kanban fields.  Please look into taking advantage of this new feature.

@tabladrum , This issue can be closed, as the user's direct question was answered.

repo: capitalone/Hygieia


text:
aggressively refetch puzzle list when tags change

I started looking at it after the call, I won't have time to do it tonight but I'll take a longer look tomorrow morning. It looks like in the case of adding/removing a meta tag I'll have to fetch that puzzle record too, I saw that there's already a call to Puzzle.objects.get(name=tag.name, hunt=puzzle.hunt), but that doesn't return with the same type of puzzle object that the PuzzleSerializer is expecting. If you'd like to give me a hint, I think the best way to approach fetching the meta is what I'm most hurting for.

I started looking at it after the call, I won't have time to do it tonight but I'll take a longer look tomorrow morning. It looks like in the case of adding/removing a meta tag I'll have to fetch that puzzle record too, I saw that there's already a call to Puzzle.objects.get(name=tag.name, hunt=puzzle.hunt), but that doesn't return with the same type of puzzle object that the PuzzleSerializer is expecting. If you'd like to give me a hint, I think the best way to approach fetching the meta is what I'm most hurting for.

I started looking at it after the call, I won't have time to do it tonight but I'll take a longer look tomorrow morning. It looks like in the case of adding/removing a meta tag I'll have to fetch that puzzle record too, I saw that there's already a call to Puzzle.objects.get(name=tag.name, hunt=puzzle.hunt), but that doesn't return with the same type of puzzle object that the PuzzleSerializer is expecting. If you'd like to give me a hint, I think the best way to approach fetching the meta is what I'm most hurting for.

I think Puzzle.objects.get should return a Puzzle object and PuzzleSerializer should be able to handle that-- I think if you do something like
puzzle = none
meta = None
with transaction.atomic():
    # ....
    # meta = Puzzle.objects.get(name = tag.name, hunt=puzzle.hunt)
    # ....

if meta:
    return Response([PuzzleSerializer(puzzle).data, PuzzleSerializer(meta).data])
else:
    return Response([PuzzleSerializer(puzzle).data])

that should probably be enough for the destroy call (+ a similar change to the create call). Then on the front-end the thunks can return this response instead of the response from fetchPuzzles, and you already updated the reducers to expect a list of puzzles so nothing to change there. Lmk if that doesn't work or make sense.

I started looking at it after the call, I won't have time to do it tonight but I'll take a longer look tomorrow morning. It looks like in the case of adding/removing a meta tag I'll have to fetch that puzzle record too, I saw that there's already a call to Puzzle.objects.get(name=tag.name, hunt=puzzle.hunt), but that doesn't return with the same type of puzzle object that the PuzzleSerializer is expecting. If you'd like to give me a hint, I think the best way to approach fetching the meta is what I'm most hurting for.

I think Puzzle.objects.get should return a Puzzle object and PuzzleSerializer should be able to handle that-- I think if you do something like
puzzle = none
meta = None
with transaction.atomic():
    # ....
    # meta = Puzzle.objects.get(name = tag.name, hunt=puzzle.hunt)
    # ....

if meta:
    return Response([PuzzleSerializer(puzzle).data, PuzzleSerializer(meta).data])
else:
    return Response([PuzzleSerializer(puzzle).data])

that should probably be enough for the destroy call (+ a similar change to the create call). Then on the front-end the thunks can return this response instead of the response from fetchPuzzles, and you already updated the reducers to expect a list of puzzles so nothing to change there. Lmk if that doesn't work or make sense.

I rudely just changed it myself because we want to merge everything now.
Thanks for fixing this!!!

I rudely just changed it myself because we want to merge everything now.
Thanks for fixing this!!!

authors: pcvera rgossiaux

repo: cardinalitypuzzles/smallboard


text:
Add docs on using Hermit in Jenkins

Awesome, thanks!

authors: alecthomas jstrachan

repo: cashapp/hermit


text:
updated navicat-premium-essentials (11.1.15)

Merged as 84f3ccd962c16af0ec068ceadbebc84712cd25d9.

repo: caskroom/homebrew-cask


text:
Add TorBrowser.app v4.0.4 (Chinese)

I'm curious, is there a project or something your working on that you need all the different Tor browser versions for?

Not really. I only needed a few of those, but then decided why not add all of them if I already started. The Chinese version was the last.

authors: Ngrd fanquake

repo: caskroom/homebrew-versions


text:
Box dots and default box do not work together as expected in 5.1.0

Fixed in 5.1.1

repo: cdgriffith/Box


text:
CI for Node

Initializes with two players (5 ms)

repo: chandoyo/github-actions-for-ci


text:
Add Pierce Moore to maintainers

¡WOO!

authors: josephholsten rex

repo: chef-brigade/mongodb-cookbook


text:
remove logic that changes hostname to an ip

:+1:

authors: jgoulah jkeiser

repo: chef/chef-provisioning-docker


text:
CI for Node

Initializes with two players

repo: chlbri/github-actions-for-ci


text:
Incorporate new Redbook material

Already reviewed.

repo: cicsdev/cics-java-liberty-restapp-ext


text:
Create runstate dir expected by circonus-inside plugin

LGTM

authors: esproul postwait

repo: circonus-labs/nad


text:
fix codeforall link

Good catch, thanks @techieshark

authors: ondrae techieshark

repo: codeforamerica/brigade-alpha


text:
regenerate session key on login to prevent session fixation

Fixed.

repo: codingchili/webshoppe


text:
Create "program yourself the algorithm"-prototype (eval with unit-tests)

ideas for algs to implement:

linear regression (L1 und L2, do optimization for both via gradient descent; extend to logistic later)
random forests (re-using R's CART implementation rpart)
cross validation
ROC curve calculator + AUC
grid search

maybe see https://github.com/statsmaths/casl and associated book and steal from there

authors: fabian-s tpielok


text:
Remove Polish and Estonian as CODAP doesn't support them

@dstrawberrygirl   You'll see this also aligns it with the dropdown language menu in index.tsx:
        options: [
          {langCode: "en-US", label: "English"},
          {langCode: "es", label: "Español"},
          {langCode: "el", label: "Ελληνικά"},
          {langCode: "de", label: "Deutsch"},
          {langCode: "he", label: "עברית"},
          {langCode: "nb", label: "Bokmål"},
          {langCode: "nn", label: "Nynorsk"},
          {langCode: "tr", label: "Türkçe"},
          {langCode: "zh", label: "中文"},
        ],

@dstrawberrygirl I reassigned these to Piotr since he is now working on Sage.

repo: concord-consortium/sage-modeler-site


text:
next release

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

authors: conda-forge-linter holgern

repo: conda-forge/beem-feedstock


text:
update to 2.7.3.1

Hi! This is the friendly automated conda-forge-linting service.
I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

authors: conda-forge-linter sannykr


text:
-> 1.7.0-RC9

@confluentinc It looks like @jliunyu just signed our Contributor License Agreement. :+1:
Always at your service,
clabot

authors: ConfluentCLABot jliunyu

repo: confluentinc/confluent-kafka-dotnet


text:
KSTREAMS-2772: update readme

eams-examples: pint merge kafka-streams-examples -fb 5.0.3-post

repo: confluentinc/kafka-streams-examples


text:
create SSP information to imtoken

请移除其他文件修改   0xb1cfb2421f6f12ebda4f9b8d0336518c82e63b2c.json

repo: consenlabs/token-profile


text:
Add Adpower

你好，请按照提交资料信息，提交正确的代币信息，谢谢。


text:
fixed issue #1

This is a good first approach, however, there are fields that are actually lists:
AU Sun, ZW
   Russell, TP
AF Sun, Zhiwei
   Russell, Thomas P.

and also (most important maybe)
CR Bai W, 2015, MACROMOLECULES, V48, P8574, DOI 10.1021/acs.macromol.5b02174
   Bosworth JK, 2011, MACROMOLECULES, V44, P9196, DOI 10.1021/ma201967a
   Bosworth JK, 2010, J PHOTOPOLYM SCI TEC, V23, P145, DOI 10.2494/photopolymer.23.145
   Chai J, 2008, ACS NANO, V2, P489, DOI 10.1021/nn700341s
   Chai J, 2007, NAT NANOTECHNOL, V2, P500, DOI 10.1038/nnano.2007.227
   Choi S, 2012, SOFT MATTER, V8, P3463, DOI 10.1039/c2sm07297a
   Di ZY, 2012, MACROMOLECULES, V45, P5185, DOI 10.1021/ma3004136
   ...

we need to find out wich fields can be lists, and which are not.

authors: EmPiFree odarbelaeze

repo: coreofscience/python-wostools


text:
Added @UseSemiJoins annotation to randomize semi-joins in tests.

Codecov Report

Merging #6279 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6279      +/-   ##
============================================
+ Coverage     83.23%   83.23%   +<.01%
- Complexity    12819    12832      +13
============================================
  Files          1479     1479
  Lines         48506    48506
  Branches       5924     5924
============================================
+ Hits          40373    40376       +3
- Misses         5364     5366       +2
+ Partials       2769     2764       -5

Impacted Files
Coverage Δ
Complexity Δ

...o/crate/analyze/SafeExpressionToStringVisitor.java
83.33% <0%> (-16.67%)
7% <0%> (-1%)

...ration/reference/doc/lucene/IpColumnReference.java
72.72% <0%> (-13.64%)
5% <0%> (ø)

...rc/main/java/io/crate/analyze/UnboundAnalyzer.java
81.81% <0%> (-9.1%)
2% <0%> (ø)

...peration/collect/BatchIteratorCollectorBridge.java
65.78% <0%> (-7.9%)
2% <0%> (ø)

...or/transport/distributed/DistributingConsumer.java
75.96% <0%> (-3.85%)
21% <0%> (ø)

...rc/main/java/io/crate/blob/BlobTransferTarget.java
81.09% <0%> (-3.05%)
25% <0%> (-1%)

...rc/main/java/io/crate/analyze/symbol/Function.java
94.11% <0%> (-2.95%)
17% <0%> (-1%)

...transport/executionphases/ExecutionPhasesTask.java
91.74% <0%> (-2.76%)
24% <0%> (ø)

.../java/io/crate/protocols/http/HttpBlobHandler.java
66.41% <0%> (-1.53%)
48% <0%> (-1%)

sql/src/main/java/io/crate/planner/Planner.java
85.71% <0%> (-1.25%)
39% <0%> (-1%)

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a40a001...2490949. Read the comment docs.

We already execute the semi-join tests with both the rewrite and without. So this doesn't really introduce new tests. How about we get rid of the annotation and randomize execution of semi-joins by default in tests (unless they are explicitly executed twice)?

@mxm but then how can we implement this: https://github.com/crate/crate/pull/6279/files#diff-ab3b276bdac1913b910c3e6fb5086f0bR45

@matriv We could enable/disable that on the test base.

IMHO The annotation is much more elegant when you want to override default usage.
Otherwise, you'd need for class level override to set some flag on the SQLTransportExecutor and on method level you'd need to have another "execute" implementation that overrides, or set a flag and unset it at the end of the test, or maybe I'm don't get your suggestion :-)

@UseSemiJoins doesn't interfere with @UseJdbc. Check the code here: https://github.com/crate/crate/pull/6279/files#diff-8098880df0a6537ed3b305a506b16bd0R137
It can be applied for both for postgres and http.

authors: codecov-io matriv mxm

repo: crate/crate


text:
feat: update package dependencies ⬆

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: crystal-ball/svg-symbol-sprite-loader


text:
chore(package): upgrade typescript to 3.0

Pull Request Test Coverage Report for Build 87

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.84%

Totals

Change from base Build 86:
0.0%

Covered Lines:
112

Relevant Lines:
121

💛  - Coveralls

authors: coveralls csvenke

repo: csvenke/react-semantics


text:
fix schema

Changes Unknown when pulling 09c84097e8b0770ba0f1da54abc796af8d71c49b on nobodyiam:fix-schema into ** on ctripcorp:master**.

Codecov Report

Merging #752 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #752   +/-   ##
=========================================
  Coverage     47.02%   47.02%
  Complexity     1543     1543
=========================================
  Files           352      352
  Lines          9683     9683
  Branches        959      959
=========================================
  Hits           4553     4553
  Misses         4790     4790
  Partials        340      340

Impacted Files
Coverage Δ
Complexity Δ

...ervice/service/ReleaseMessageServiceWithCache.java
84.52% <0%> (-1.2%)
23% <0%> (-1%)

.../apollo/internals/RemoteConfigLongPollService.java
77.91% <0%> (+0.61%)
28% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe4f3b8...09c8409. Read the comment docs.

Changes Unknown when pulling 09c84097e8b0770ba0f1da54abc796af8d71c49b on nobodyiam:fix-schema into ** on ctripcorp:master**.

authors: codecov-io coveralls nobodyiam

repo: ctripcorp/apollo


text:
Dev Customs

Coverage increased (+0.3%) to 70.009% when pulling db7caa673fffcd723fa37ab8522ca09de037f6fe on SirDimas:dev into 1b7ae0e78c13ee6a6c3d15f7da761759489f3dd9 on danliris:dev.

authors: SirDimas coveralls

repo: danliris/dl-module


text:
Update flutter to 0.0.18

TBR – going to try a deploy and see what happens

repo: dart-lang/pub-dartlang-dart


text:
Make fullPath() method dry and path calculation fix.

Great, thanks @hdogan!

authors: davidyell hdogan


text:
Update dependencies, fix the tests add node 7 to travis

Coverage remained the same at 100.0% when pulling 3d1c819a529ed1e93db854d70f1aee7670a897db on #39_update_dependencies into 69ba316e44c275db13c7c1bcd7032f85f17de073 on development.

Current coverage is 100% (diff: 100%)

Merging #40 into development will not change coverage

@@           development   #40   diff @@
========================================
  Files                9     9
  Lines              525   525
  Methods            103   103
  Messages             0     0
  Branches            68    68
========================================
  Hits               525   525
  Misses               0     0
  Partials             0     0

Powered by Codecov. Last update 69ba316...3d1c819

authors: codecov-io coveralls deadratfink

repo: deadratfink/jy-transform


text:
Fix base64 for 1.16

has this been tested?

Yes, it’s tested working. For future proofing it may be better to check if the version is 1.16 or newer in a better/different way, but yes this does work.

Thank you for adding this! :)

authors: deanveloper jmanpenilla

repo: deanveloper/SkullCreator


text:
Add support for Google Analytics

LGTM now, but seems to need a rebase. Will leave it to you folks to merge it. Thanks!

authors: gunnarmorling uidoyen


text:
Fix release notes link

Thanks, @jpechane!

authors: gunnarmorling jpechane

repo: debezium/debezium


text:
create necessary stub notes on import

shipped in 0.11.1

repo: dendronhq/dendron


text:
Update SABER title to include [CLOSED]

I think this was superceded by #37? Can we close this one without merging?

authors: RobertAlexanderUSDS jordangov


text:
Label suggestion

Closing as no label has been provided.


text:
bump version to 0.14.3 in preparation for new release

Pull Request Test Coverage Report for Build 406

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.796%

Totals

Change from base Build 404:
0.0%

Covered Lines:
1185

Relevant Lines:
1237

💛  - Coveralls

Pull Request Test Coverage Report for Build 406

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.796%

Totals

Change from base Build 404:
0.0%

Covered Lines:
1185

Relevant Lines:
1237

💛  - Coveralls

authors: coveralls olbrich

repo: devise-security/devise-security


text:
Feature/improved doc

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 4 committers have signed the CLA.:x: maweck:x: productionline:x: pdehnel:x: cdjahanYou have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant maweck


text:
Feat/travis integration

Changes Unknown when pulling 0570323a1b8922f0f072cd4f1ed0fbd59eac824c on feat/travis-integration into ** on master**.

authors: coveralls tiagoloureiro

repo: dipcode-software/django-obfuscator


text:
Audio stops from once scene to another

To fix this issue i created an empty game object on my first scene and via c# i wrote the following code:
void Start () {
	GetComponent<AudioSource>().PlayOneShot (bgSound);
	DontDestroyOnLoad(this.gameObject);

}

Basically i am stating so when the scene loads the music starts playing and i wont destroy the audio game object between a scene and another.

repo: distractoo/underwaterGame

license: unlicense


text:
Fixed #24324 -- Fixed migrations test failure on Oracle.

Fixed in f7d34fe741ea64f3ec89f1d742d47182065e2c2a.

repo: django/django


text:
Fixed #24773 -- Provide a json() method on a test response.

buildbot, test this please.

Thanks for feedback @coldmind, all sounds good to me.

buildbot, test this please.

Oh what buildbot won't run tests for me? :(

buildbot, ok to test.

Please add a mention in the 1.9 release notes as well.

merged in 4525a0c4669dccb3a4c5d865184f8bb8e4a89ec8, thanks!

thanks for the help

authors: MarkusH andymckay timgraham


text:
fix OpInfo for concat and softmaxOutput

@hjk41 I've met the same checking error. Something wrong with the engine?

@sxjscience probably. Let me try again

repo: dmlc/mxnet


text:
uri_encode() and uri_decode() should not croak() if given an empty string

Fixed in commit e87b46c0b99791599b00747c55bdd9095fd3dc63

repo: dnmfarrell/URI-Encode-XS


text:
Fix typo

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:mgrachev/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Thanks!

authors: GordonTheTurtle mgrachev shin-

repo: docker/machine


text:
HA Replication for MySQL backend

done for postgresql

authors: mark-church spara

repo: dockersamples/atsea-sample-shop-app


text:
Переключение темы оформления

https://user-images.githubusercontent.com/6412192/126958795-16ce2395-07a7-4079-a570-91e51808baa0.mp4

@monochromer, привет! В сборке, не подключились стили, темы не переключаются, но при клике на иконки солнца и луны, срабатывает тогглер.

По какой причине?

@monochromer, привет! В сборке, не подключились стили, темы не переключаются, но при клике на иконки солнца и луны, срабатывает тогглер.

По какой причине? Может быть, просто кэш.

Да, скорее всего кэш. Я склонировал заново, всё работает. Спасибо.

Сейчас кнопка сделана чекбоксом и это скорее хак, чем подходящее решение. Я бы сделал это кнопкой-тоглером, как в статье.

Статьи по теме:

Prefers-color-scheme: Hello darkness, my old friend
Building a color scheme
Improved dark mode default styling with the color-scheme CSS property and the corresponding meta tag

Насчёт кнопки - согласен.
Разделение на отдельные файлы для светлой и тёмной неудобно, так как они реализуются в виде модификаторов одного блока.
Принцип работы сейчас такой: изначально, исходя из предпочтений пользователя, выбирается тема - светлая или темная. Если браузер не поддерживает соответствующую media query, то выбирается светлая тема. Затем, если пользователь нажимает на кнопку, то выбирается соответствующая тема и сохраняется в localStorage. Это выбор идет в приоритете, игнорируя настройки ОС.

Разделение на отдельные файлы для светлой и тёмной неудобно, так как они реализуются в виде модификаторов одного блока.

Я думал, что мы будем не хардкодить модификаторы, а использовать кастомные свойства для такого. Их как раз можно легко переключать браузерными механизмами. Может пересмотрим решение и будем меньше писать руками? По сути сейчас твой скрипт делает при загрузке то, что браузер уже умеет делать и делает хорошо.
Я бы также подумал про sessionStorage, чтобы после закрытия вкладки мы снова фолбэчились на системную настройку. Но это так, мысли по ходу — можно почитать про опыт больших компаний, посмотреть на их реализации и уже подтюнить.

В общем, если выбираеть между БЭМ-пуризмом (хотя там наследование модификатора, хех) и кастомными свойствами — я бы выбрал второе и позволил браузеру выбирать подходящие стили.

Получается дублирование - должен быть CSS-класс условно dark-theme (чтобы js'ом переключать) и media-выражение:
.dark-theme {
  --color: #fff;
}

@media (prefers-color-scheme: dark) {
  :root {
    --color: #fff;
  }
}

Если нужно закладываться на поддержку с отключенным js, то это нужно обговорить сразу.

Если нужно закладываться на поддержку с отключенным js, то это нужно обговорить сразу.

Речь не о том, чтобы закладываться на отключенный JS, а потом, чтобы не ставить JS на критическом пути загрузки стилей. Даже если в тёмном браузере мелькнёт светлая тема (или наоборот) — это уже плохо. Только браузер сможет сразу загрузить нужные стили мгновенно их применить.

Скрипты, как стили, можно внедрить в страницу. Их не так много, чтобы существенно оказывать на размер html.

Скрипты, как стили, можно внедрить в страницу. Их не так много, чтобы существенно оказывать на размер html.

Так а зачем трюковать, если можно сделать через кастомные свойства без трюков? Неужели так хочется остаться в понятиях БЭМа и переключать классы? Хочется как-то современнее, что ли. Раз уж в браузеры встроили такую возможность и мы можем позволить себе не сильно думать про старые браузеры из-за характера проекта.

Так а зачем трюковать, если можно сделать через кастомные свойства без трюков? Неужели так хочется остаться в понятиях БЭМа и переключать классы? Хочется как-то современнее, что ли. Раз уж в браузеры встроили такую возможность и мы можем позволить себе не сильно думать про старые браузеры из-за характера проекта.

Так там и так кастомные свойства, но подход позволяет добавить почти бесплатно 3-ую, 4-ую и т.д. тему оформления, то есть легко масштабируется; позволяет использовать темы одновременно, например, покрасить сайт темной темой, а демку - светлой.

позволяет добавить почти бесплатно 3-ую, 4-ую и т.д. тему оформления
позволяет использовать темы одновременно, например, покрасить сайт темной темой, а демку - светлой.

У нас задача проще: есть всего две темы. Демки у нас в отдельных фреймах и скорее всего будут краситься сами, без стилей платформы. Так что я бы не пытался внедрить масштабируемое решение для простой задачи. Чем ближе мы будем к платформе и меньше будет сложностей, тем лучше для опенсорсного проекта.
Правда, давай напишем простую систему для светлой и тёмной темы, которую можно будет показывать как отличное решение тех, кому нужны просто светлая и тёмная тема, как и нам.

Сделал рефакторинг

Добавил переключение тем без использования CSS-классов путём блокировки тегов style, в которые загружены стили.
Смущает момент, что при переключении тем c помощью кнопки js'ом приходится на теге с тёмной темой делать style.media = 'all', чтобы они применялись всегда независимо от настроек ОС.

Изменил подключение через <link>. Для него (в отличие от <style>), атрибут disabled является нестандартным  и не работает в Chrome, поэтому отключение сделал через media='none'.

authors: furtivite monochromer pepelsbey

repo: doka-guide/platform


text:
x/dotc: add streams for unexported types

Codecov Report

Merging #227 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   99.47%   99.48%   +<.01%
==========================================
  Files          65       61       -4
  Lines        2867     2527     -340
==========================================
- Hits         2852     2514     -338
+ Misses          8        7       -1
+ Partials        7        6       -1

Flag
Coverage Δ

#dot
99.48% <100%> (?)

#dot_changes
100% <ø> (ø)
:arrow_up:

#dot_changes_diff
100% <ø> (ø)
:arrow_up:

#dot_changes_run
100% <ø> (ø)
:arrow_up:

#dot_changes_table
100% <ø> (ø)
:arrow_up:

#dot_changes_types
100% <ø> (ø)
:arrow_up:

#dot_ops
98.76% <ø> (ø)
:arrow_up:

#dot_ops_bolt
97.56% <ø> (ø)
:arrow_up:

#dot_ops_nw
100% <ø> (ø)
:arrow_up:

#dot_ops_pg
97.39% <ø> (ø)
:arrow_up:

#dot_refs
100% <ø> (ø)
:arrow_up:

#dot_streams
100% <ø> (ø)
:arrow_up:

#dot_streams_undo
100% <ø> (ø)
:arrow_up:

#dot_test_seqtest
100% <ø> (ø)
:arrow_up:

#dot_x_dotc
95.8% <100%> (+1.2%)
:arrow_up:

#dot_x_fold
100% <ø> (ø)
:arrow_up:

#dot_x_rt
?

#dot_x_ui_collab
?

#dot_x_ui_dom
100% <ø> (ø)
:arrow_up:

#dot_x_ui_html
100% <ø> (ø)
:arrow_up:

#dot_x_ui_input
100% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

x/dotc/dotc.go
89.28% <ø> (-0.88%)
:arrow_down:

x/dotc/slices.go
100% <100%> (ø)
:arrow_up:

x/dotc/structs.go
100% <100%> (+14.28%)
:arrow_up:

x/dotc/field.go
100% <100%> (ø)
:arrow_up:

x/ui/collab/keyboard.go

x/rt/formatted.go

x/ui/collab/node.go

x/ui/collab/text.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eac4238...a4d4440. Read the comment docs.

authors: codecov-io rameshvk

repo: dotchain/dot


text:
.NET Core 2.1.1 doc updates

The SDK dlc links at https://download.microsoft.com/download/D/0/4/D04C5489-278D-4C11-9BD3-6128472A7626 aren't working. Just mentioning in case it isn't a known issue.

Nice, updating homebrew casks now

authors: dasMulli preetikr

repo: dotnet/core


text:
Update README.md to add FAQ section

This is covered by #291

repo: dotnet/upgrade-assistant


text:
add support for STAMINCHIA with parameter ?sud=1

Maybe an endpoint for this? Such a different use case than #6

+1

As a sicilian I agree this is really needed!
Anyway consider this should not conflict with #6. E.g. Normal: "staminchia" , big: "stagranminchia"

I would probably use a parameter like "locale" to handle multiple regions: ?locale=sicily

@enrichman nice idea! :D

authors: Dreeg dottorblaster enrichman lmammino nicola

repo: dottorblaster/stocazzo


text:
Rule updates 2018 04.v2

testing new falco integration

repo: draios/falco


text:
upgraded to 7.0.0.Beta6

@psiroky can you ack this please?

repo: droolsjbpm/drools-website


text:
Another round of minor fixes

@Hasys I see that this PR does a lot of work around closing streams. However, it doesn't close them correctly...
See here: http://stackoverflow.com/questions/2699209/java-io-ugly-try-finally-block

@triceo Thank you for your reply. Yes I did it not fully in right way, but because this method throws an IOEcxeption. I guessed this exceptions was expected so I just leave it like it was except closing streams. Maybe I should to investigate it little bit deeper how it's work.

You can re-throw the exception if you like. But the important point is that, even when the exception is thrown, you still need to close the streams properly.

@Hasys it looks like this PR also does not include the fix for problems in DesignerInjectionFilter introduced in your last PR - is this something that you could please add to this one or you plan to do another?

@triceo @tsurdilo Thank you for your replays. Fixed.

No tests?

Good point, @porcelli - we'll need to add those.

authors: Hasys porcelli triceo tsurdilo

repo: droolsjbpm/jbpm-designer


text:
remove loading image message in image viewer

Added an event handler to the OpenSeadragon viewer to remove the "loading..." message from the display upon the first tile load.  It should no longer be present once the image starts loading

repo: dulibrarytech/digitaldu-frontend


text:
添加历史轨迹功能，用于原有的漫游的功能

功能已完成

repo: dvgis/dc-sdk


text:
Update ABI Stability section

Build status:

Linux
Windows

repo: eProsima/Micro-XRCE-DDS-Client


text:
Update build

Failing CI due to https://github.com/eXist-db/public-repo/issues/74 and https://github.com/eXist-db/node-exist/issues/222

repo: eXistSolutions/exist-jwt


text:
Design: Dynamic stats for summary

Accommodate variable number of stats for each category in the summary tab.

@ashwathgovind close this?

Lets keep this open till we touch base on design.

authors: ashwathgovind samarthbhargav

repo: egovernments/analytics


text:
Updated for most recent libstorage

[Current coverage][cc-pull] is 70.76%

Merging [#66][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master        #66   diff @@
==========================================
  Files             6          6
  Lines           513        513
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            363        363
  Misses           99         99
  Partials         51         51

Powered by Codecov. Last updated by [5bd8f86...161e37c][cc-compare]
[cc-base-branch]: https://codecov.io/gh/emccode/polly/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/emccode/polly/compare/5bd8f865fea0ae8fd6559b71da740fece8e988b3...161e37c8cbcdb520281aca88bdc70ffc05b55af8
[cc-pull]: https://codecov.io/gh/emccode/polly/pull/66?src=pr

authors: clintonskitson codecov-io

repo: emccode/polly


text:
Move to new .dev domain

emerconghaile.dev domain has been purchased via Netlify
Automatic DNS propagation and SSL/TLS certificates are in progress

This repo has been renamed to emerconghaile.dev
emerconghaile.github.io is now a separate repo
Next step is to make emerconghaile.github.io point and redirect to the new domain

https://emerconghaile.github.io is now redirecting https://emerconghaile.dev
Closing


text:
add plugin support to emu-utils.sh for optional utilities, auto enable certain plugins based on current active openpilot fork

these should support python and shell scripts (hopefully via python autodetection, or by the fpath env variable)

This is half done it seems. @ShaneSmiskol you mentioned you wanted to have plugins toggle based on the current fork. Is this something you're still interested in doing?


text:
Fails to write CustardList in python

Maybe bug in the to_json. Unnecessary label custards:  applied to the list.
#desired
[
    custard1,
    custard2,
    custard3,
]

#now
{
    "custards": [
        custard1,
        custard2,
        custard3,
    ]
}

I think this is because CustardList has a member named custards and now we use to_json for instances of CustardList.

If you want to put lists, you need to use to_json for the member custards of CustardList.

class CustardJSONEncoder(json.JSONEncoder):
    def default(self, o):
        if isinstance(o, Custard):
            return to_json(o)
        if isinstance(o, CustardList):
            return to_json(o.custards)
        # 他の型はdefaultのエンコード方式を使用
        return super(CustardJSONEncoder, self).default(o)

It results as desired. Nice!

authors: ensan-hcl shundroid

repo: ensan-hcl/CustardKit


text:
Smoke:Deployments

To check if:

auth service is running in proper number of replicas
rabbitmq is running in proper number of replicas
call auth service: status code 200 or 403
call auth service API with admin credentials

authors: mmakow przemyslawdy

repo: epiphany-platform/epiphany


text:
upgrade packages + pass title to pages

Deploy preview for bettertw ready!
Built with commit 159cf28f2205478c50d57f9d9731b4416f42b37f
https://deploy-preview-12--bettertw.netlify.com


text:
Added WRDS RNN,MLP experiments with readme

Lashkay, This looks good. Thanks for all the work! Let's catch up about why the MSE in the training is so high and why the predictions in the pretty_print_pred=True mode look so far off. Maybe because you are training with only 10 securities? Why not the whole universe?

Hi John,
Sure, we can have a call tomorrow to discuss that.
I did not pay attention to the MSE or the output much as I was just putting
together the mechanics of it. I had stopped the training just after first
few epochs, so probably that's why MSE and predictions are off. If I let it
run throughout, I'm sure it will get better. I can run the 2000 stock list
today and we can discuss the results.
Lakshay
On Mon, Mar 5, 2018 at 1:07 PM, John Alberg notifications@github.com
wrote:

Merged #6 https://github.com/euclidjda/deep-quant/pull/6.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/euclidjda/deep-quant/pull/6#event-1504740585, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AcfL1pTXds-JiAUQFXKA0Qbflm545Fu6ks5tbX65gaJpZM4Sba5O
.

--
Lakshay K Chauhan

authors: euclidjda lakshaykc

repo: euclidjda/deep-quant


text:
Move metrics and format

Pull Request Test Coverage Report for Build 113

27 of 45 (60.0%)  changed or added relevant lines in 8 files are covered.
4 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-9.9%) to 68.862%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sequentially/src/main/scala/com/evolutiongaming/concurrent/sequentially/AsyncHandlerMap.scala
5
6
83.33%

sequentially/src/main/scala/com/evolutiongaming/concurrent/sequentially/AsyncMap.scala
3
4
75.0%

sequentially/src/main/scala/com/evolutiongaming/concurrent/sequentially/SequentialMap.scala
1
2
50.0%

sequentially/src/main/scala/com/evolutiongaming/concurrent/sequentially/Sequentially.scala
11
12
91.67%

sequentially/src/main/scala/com/evolutiongaming/concurrent/sequentially/SequentiallyAsync.scala
4
5
80.0%

sequentially/src/main/scala/com/evolutiongaming/concurrent/MeteredSequentiallyAsync.scala
0
6
0.0%

sequentially/src/main/scala/com/evolutiongaming/concurrent/SequentiallyMetrics.scala
0
7
0.0%

Files with Coverage Reduction
New Missed Lines
%

sequentially/src/main/scala/com/evolutiongaming/concurrent/sequentially/SequentiallyAsync.scala
1
78.95%

sequentially/src/main/scala/com/evolutiongaming/concurrent/sequentially/SequentiallyHandler.scala
1
94.74%

sequentially/src/main/scala/com/evolutiongaming/concurrent/sequentially/Sequentially.scala
2
88.37%

Totals

Change from base Build 111:
-9.9%

Covered Lines:
115

Relevant Lines:
167

💛  - Coveralls

repo: evolution-gaming/sequentially


text:
feat: add empty text for select. update select events and flow

:tada: This PR is included in version 2.0.0-beta.13 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

repo: exadel-inc/esl