text:
cubiomes-viewer: 2.3.3 -> 2.4.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/Cubitect/cubiomes-viewer/releases.
meta.description for cubiomes-viewer is: "A graphical Minecraft seed finder and map viewer"
meta.homepage for cubiomes-viewer is: "https://github.com/Cubitect/cubiomes-viewer"
meta.changelog for cubiomes-viewer is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.4.0 with grep in /nix/store/zls6lhmx47r07kpxnm396c6w5s48s3zy-cubiomes-viewer-2.4.0
found 2.4.0 in filename of file in /nix/store/zls6lhmx47r07kpxnm396c6w5s48s3zy-cubiomes-viewer-2.4.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
cubiomes-viewer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/zls6lhmx47r07kpxnm396c6w5s48s3zy-cubiomes-viewer-2.4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cubiomes-viewer https://github.com/r-ryantm/nixpkgs/archive/f989bc9a2e1452027bf5d2abebfbc7a29a89431d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/zls6lhmx47r07kpxnm396c6w5s48s3zy-cubiomes-viewer-2.4.0
ls -la /nix/store/zls6lhmx47r07kpxnm396c6w5s48s3zy-cubiomes-viewer-2.4.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

cubiomes-viewer

Maintainer pings
cc @hqurve for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/Cubitect/cubiomes-viewer/releases.
meta.description for cubiomes-viewer is: "A graphical Minecraft seed finder and map viewer"
meta.homepage for cubiomes-viewer is: "https://github.com/Cubitect/cubiomes-viewer"
meta.changelog for cubiomes-viewer is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.4.1 with grep in /nix/store/b0zfflzpij9s7p9x1v75rzx3sm6qzm6n-cubiomes-viewer-2.4.1
found 2.4.1 in filename of file in /nix/store/b0zfflzpij9s7p9x1v75rzx3sm6qzm6n-cubiomes-viewer-2.4.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
cubiomes-viewer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/b0zfflzpij9s7p9x1v75rzx3sm6qzm6n-cubiomes-viewer-2.4.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cubiomes-viewer https://github.com/r-ryantm/nixpkgs/archive/a5516ce26e4481adf6c0c20b86ca7b2bb1e38089.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/b0zfflzpij9s7p9x1v75rzx3sm6qzm6n-cubiomes-viewer-2.4.1
ls -la /nix/store/b0zfflzpij9s7p9x1v75rzx3sm6qzm6n-cubiomes-viewer-2.4.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

cubiomes-viewer

Maintainer pings
cc @hqurve for testing.


text:
baresip: 2.8.1 -> 2.8.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/baresip/baresip/releases.
meta.description for baresip is: "A modular SIP User-Agent with audio and video support"
meta.homepage for baresip is: "https://github.com/baresip/baresip"
meta.changelog for baresip is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.8.2 with grep in /nix/store/flmip13jvriiz8cfklqvybg1xmswsh2z-baresip-2.8.2
found 2.8.2 in filename of file in /nix/store/flmip13jvriiz8cfklqvybg1xmswsh2z-baresip-2.8.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
baresip

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/flmip13jvriiz8cfklqvybg1xmswsh2z-baresip-2.8.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A baresip https://github.com/r-ryantm/nixpkgs/archive/cd81115e20defb47a56e75974f927aef42b8e110.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/flmip13jvriiz8cfklqvybg1xmswsh2z-baresip-2.8.2
ls -la /nix/store/flmip13jvriiz8cfklqvybg1xmswsh2z-baresip-2.8.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

baresip

Maintainer pings
cc @elohmeier @7c6f434c for testing.

There are some wired errors, looks like missing dependency or unpatched binaries?
[nix-shell:~/.cache/nixpkgs-review/pr-195546]$ ./results/baresip/bin/baresip
baresip v2.8.2 Copyright (C) 2010 - 2022 Alfred E. Heggestad et al.
Local network addresses:
    enp0s25:  192.168.178.43
      wlan0:  192.168.178.114
      wlan0:  169.254.179.29
    enp0s25:  2a02:8071:3e86:5ea0:c364:fbcb:619f:a3a0
    enp0s25:  2a02:8071:3e86:5ea0:8634:97ff:fe24:4d9b
    enp0s25:  fe80::8634:97ff:fe24:4d9b
      wlan0:  2a02:8071:3e86:5ea0:2c0a:b3ff:fe91:38ac
      wlan0:  fe80::2c0a:b3ff:fe91:38ac
ua: adding SIP CA file: /etc/ssl/certs/ca-certificates.crt
ua: adding SIP CA path:
dl: mod: /nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/stdio.so (/nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/stdio.so: cannot open shared object file: No such file or directory)
module stdio.so: No such file or directory [2]
dl: mod: /nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/g711.so (/nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/g711.so: cannot open shared object file: No such file or directory)
module g711.so: No such file or directory [2]
dl: mod: /nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/auconv.so (/nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/auconv.so: cannot open shared object file: No such file or directory)
module auconv.so: No such file or directory [2]
dl: mod: /nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/auresamp.so (/nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/auresamp.so: cannot open shared object file: No such file or directory)
module auresamp.so: No such file or directory [2]
dl: mod: /nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/alsa.so (/nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/alsa.so: cannot open shared object file: No such file or directory)
module alsa.so: No such file or directory [2]
dl: mod: /nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/uuid.so (/nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/uuid.so: cannot open shared object file: No such file or directory)
module uuid.so: No such file or directory [2]
dl: mod: /nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/stun.so (/nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/stun.so: cannot open shared object file: No such file or directory)
module stun.so: No such file or directory [2]
dl: mod: /nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/turn.so (/nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/turn.so: cannot open shared object file: No such file or directory)
module turn.so: No such file or directory [2]
dl: mod: /nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/ice.so (/nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/ice.so: cannot open shared object file: No such file or directory)
module ice.so: No such file or directory [2]
dl: mod: /nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/account.so (/nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/account.so: cannot open shared object file: No such file or directory)
module account.so: No such file or directory [2]
dl: mod: /nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/contact.so (/nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/contact.so: cannot open shared object file: No such file or directory)
module contact.so: No such file or directory [2]
dl: mod: /nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/debug_cmd.so (/nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/debug_cmd.so: cannot open shared object file: No such file or directory)
module debug_cmd.so: No such file or directory [2]
dl: mod: /nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/menu.so (/nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/menu.so: cannot open shared object file: No such file or directory)
module menu.so: No such file or directory [2]
dl: mod: /nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/netroam.so (/nix/store/hqx4c5sm0rmiprayn4jyryllsfx36g05-baresip-2.6.0/lib/baresip/modules/netroam.so: cannot open shared object file: No such file or directory)
module netroam.so: No such file or directory [2]
Populated 0 audio codecs
Populated 0 audio filters
Populated 0 video codecs
Populated 0 video filters
baresip is ready.

@onny could you check your baresip user config? It might be populated by a prior baresip run with outdated store paths for the module paths.

Ah this was the issue, thank you!

source: gharchive/pull-request

authors: elohmeier onny r-ryantm

repo: NixOS/nixpkgs

license: MIT

license_type: permissive

license_source: github-api


text:
ocaml-cstruct: 1.6.0 -> 2.3.0

cc @vbgl
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change
[x] Fits CONTRIBUTING.md.

This commit also refactors the expression.

This breaks ocamlPackages.cstruct: can we avoid that?

@vbgl no, I did some testing, it does not work.
This is the error with standard ocamlPackages:
configuring
ocamlfind: Package `ppx_tools.metaquot' not found
W: Field 'pkg_ppx_tools_metaquot' is not set: Command ''/nix/store/pxrr9pa01bazbcjy4kdf6kyvr8il70cd-ocaml-findlib-1.6.1/bin/ocamlfind' query -format %d ppx_tools.metaquot > '/tmp/nix-build-ocaml-cstruct-2.3.0.drv-0/oasis-5b264d.txt'' terminated with error code 2
E: Cannot find findlib package ppx_tools.metaquot
E: Failure("1 configuration error")

Even with withPpx = false this error does not occur in ocamlPackages_4_02.

@vbgl Do you think, I'd be better to put the new version into a separate package? I guess this is necessary, I wouldn't mind it.

Done in 2d136204c47985c9518105e1af9e14810c8319ec

@vbgl So this can be closed?

authors: sternenseemann vbgl


text:
teams-for-linux: add libpulseaudio to LD_LIBRARY_PATH

Description of changes
Fix audio bug
cc @aacebedo
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@ofborg eval
(I'm not sure why the ofborg eval says "commit not found" but I'm assuming it's a transient error)

@ofborg eval
(maybe it'll work this time)

that solves the audio problem but now the screen sharing is making it segfaulting.

I can't find any particularly useful information on the seg fault, but I can replicate it. It looks like it does not occur if I override teams-for-linux to use electron_21 instead of electron though, so perhaps it's some bug in the Electron v22 release

authors: aacebedo lilyinstarlight muscaln


text:
python310Packages.asn1tools: 0.164.0 -> 0.165.0

Diff: https://github.com/eerimoq/asn1tools/compare/0.164.0...0.165.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 206615 run on x86_64-linux 1

2 packages marked as broken and skipped:

paperless
paperless-ng

44 packages built:

baserow
buildbot (python310Packages.buildbot)
buildbot-full (python310Packages.buildbot-full)
buildbot-ui (python310Packages.buildbot-ui)
buildbot-worker (python310Packages.buildbot-worker)
crackmapexec
gnome-keysign
grab-site
magic-wormhole (python310Packages.magic-wormhole)
paperless-ngx
python310Packages.aardwolf
python310Packages.asn1tools
python310Packages.autobahn
python310Packages.cairo-lang
python310Packages.channels
python310Packages.channels-redis
python310Packages.daphne
python310Packages.eth-account
python310Packages.eth-keyfile
python310Packages.eth-keys
python310Packages.labgrid
python310Packages.magic-wormhole-mailbox-server
python310Packages.magic-wormhole-transit-relay
python310Packages.web3
python39Packages.aardwolf
python39Packages.asn1tools
python39Packages.autobahn
python39Packages.buildbot
python39Packages.buildbot-full
python39Packages.buildbot-ui
python39Packages.buildbot-worker
python39Packages.cairo-lang
python39Packages.channels
python39Packages.channels-redis
python39Packages.daphne
python39Packages.eth-account
python39Packages.eth-keyfile
python39Packages.eth-keys
python39Packages.labgrid
python39Packages.magic-wormhole
python39Packages.magic-wormhole-mailbox-server
python39Packages.magic-wormhole-transit-relay
python39Packages.web3
tahoe-lafs


text:
licensor: fix tests, this time in a longterm way

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Here's the failure on Hydra:
https://hydra.nixos.org/build/205557556


text:
suricata: 6.0.8 -> 6.0.10

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/suricata/versions.
meta.description for suricata is: A free and open source, mature, fast and robust network threat detection engine
meta.homepage for suricata is: https://suricata.io
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 6.0.10 with grep in /nix/store/v48p55n6mdshjrd56xsm8bf7vs77gqjp-suricata-6.0.10
found 6.0.10 in filename of file in /nix/store/v48p55n6mdshjrd56xsm8bf7vs77gqjp-suricata-6.0.10

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
suricata

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/v48p55n6mdshjrd56xsm8bf7vs77gqjp-suricata-6.0.10 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A suricata https://github.com/r-ryantm/nixpkgs/archive/ba7956304ab932264eceac27fa79f4fa748fc905.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/v48p55n6mdshjrd56xsm8bf7vs77gqjp-suricata-6.0.10
ls -la /nix/store/v48p55n6mdshjrd56xsm8bf7vs77gqjp-suricata-6.0.10/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

suricata

Maintainer pings
cc @magenbluten for testing.

#201254 for aarch64-linux.

authors: r-ryantm wegank


text:
termscp: 0.10.0 -> 0.11.0

Diff: https://github.com/veeso/termscp/compare/v0.10.0...v0.11.0
Changelog: https://github.com/veeso/termscp/blob/v0.11.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 217582 run on x86_64-linux 1

1 package built:

termscp


text:
Darwin gtk quartz follow up

Motivation for this change
Adjusting packages which  expect the x11 backend for gdk/gtk.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Some binaries need DYLD_FRAMEWORK_PATH=/System/Library/Frameworks set as a workaround for #12346


text:
python311Packages.pytest-ansible: 3.0.0 -> 3.1.5

Changelog: https://github.com/ansible-community/pytest-ansible/releases/tag/v3.1.5
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 232730 run on x86_64-linux 1

2 packages built:

python310Packages.pytest-ansible
python311Packages.pytest-ansible


text:
crowdin-cli: 3.11.0 -> 3.11.1

Description of changes

fix: Upgrade Gradle and dependencies to fix Java 20 by @Myself5 in https://github.com/crowdin/crowdin-cli/pull/573
ci: generate code coverage only on ubuntu-latest by @andrii-bodnar in https://github.com/crowdin/crowdin-cli/pull/576
ci: run tests on windows by @yzerk in https://github.com/crowdin/crowdin-cli/pull/575
fix: support double curly braces by @yzerk in https://github.com/crowdin/crowdin-cli/pull/572
fix: download multiple sources with the same destination by @yzerk in https://github.com/crowdin/crowdin-cli/pull/574

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 233201 run on x86_64-linux 1

1 package built:

crowdin-cli

Binary works fine for me.

Thank you very much

authors: DamienCassou pbek


text:
python310Packages.vunit: init at 4.7.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2770

authors: jleightcap nixos-discourse


text:
python311Packages.appthreat-vulnerability-db: 5.1.4 -> 5.2.0

Diff: https://github.com/AppThreat/vulnerability-db/compare/refs/tags/v5.1.4...v5.2.0
Changelog: https://github.com/AppThreat/vulnerability-db/releases/tag/v5.2.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 240889 run on x86_64-linux 1

6 packages built:

appthreat-depscan
appthreat-depscan.dist
python310Packages.appthreat-vulnerability-db
python310Packages.appthreat-vulnerability-db.dist
python311Packages.appthreat-vulnerability-db
python311Packages.appthreat-vulnerability-db.dist


text:
python310Packages.mypy-boto3-s3: 1.26.163 -> 1.28.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.mypy-boto3-s3 is: Type annotations for boto3.s3
meta.homepage for python310Packages.mypy-boto3-s3 is: https://github.com/youtype/mypy_boto3_builder
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.28.0 with grep in /nix/store/9k8h0lah3nshk64pg7djz259c76rkci5-python3.10-mypy-boto3-s3-1.28.0
found 1.28.0 in filename of file in /nix/store/9k8h0lah3nshk64pg7djz259c76rkci5-python3.10-mypy-boto3-s3-1.28.0

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.dependency-injector
python310Packages.mypy-boto3-s3
python311Packages.dependency-injector
python311Packages.mypy-boto3-s3
toil

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/9k8h0lah3nshk64pg7djz259c76rkci5-python3.10-mypy-boto3-s3-1.28.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.mypy-boto3-s3 https://github.com/r-ryantm/nixpkgs/archive/ad2ad1b5506094ede1ba30a8491575be2291b166.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/9k8h0lah3nshk64pg7djz259c76rkci5-python3.10-mypy-boto3-s3-1.28.0
ls -la /nix/store/9k8h0lah3nshk64pg7djz259c76rkci5-python3.10-mypy-boto3-s3-1.28.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

5 packages built:

python310Packages.dependency-injector
python310Packages.mypy-boto3-s3
python311Packages.dependency-injector
python311Packages.mypy-boto3-s3
toil

Maintainer pings
cc @fabaff for testing.

Result of nixpkgs-review pr 242020 run on aarch64-darwin 1

10 packages built:

python310Packages.dependency-injector
python310Packages.dependency-injector.dist
python310Packages.mypy-boto3-s3
python310Packages.mypy-boto3-s3.dist
python311Packages.dependency-injector
python311Packages.dependency-injector.dist
python311Packages.mypy-boto3-s3
python311Packages.mypy-boto3-s3.dist
toil
toil.dist


text:
cloudfoundry-cli: 8.7.1 -> 8.7.2

Description of changes
change log: https://github.com/cloudfoundry/cli/releases/tag/v8.7.2
diff: https://github.com/cloudfoundry/cli/compare/v8.7.1...v8.7.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 253333 run on x86_64-linux 1

1 package built:

cloudfoundry-cli


text:
zpaqfranz: init at 58.9

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 255976 run on x86_64-linux 1

1 package built:

zpaqfranz

authors: AndersonTorres lucasew


text:
unpoller: 2.8.3 -> 2.9.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/unpoller/unpoller/releases.
meta.description for unpoller is: Collect ALL UniFi Controller, Site, Device & Client Data - Export to InfluxDB or Prometheus
meta.homepage for unpoller is: https://github.com/unpoller/unpoller
meta.changelog for unpoller is: https://github.com/unpoller/unpoller/releases/tag/v2.9.2
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.9.2 with grep in /nix/store/cd9bdizrrg7m3aanl87qyxasnwrm2fjp-unpoller-2.9.2
found 2.9.2 in filename of file in /nix/store/cd9bdizrrg7m3aanl87qyxasnwrm2fjp-unpoller-2.9.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
unpoller

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/cd9bdizrrg7m3aanl87qyxasnwrm2fjp-unpoller-2.9.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A unpoller https://github.com/r-ryantm/nixpkgs/archive/e2738b7c5df5a0e4b3fed403bf1896156c844471.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/e2738b7c5df5a0e4b3fed403bf1896156c844471#unpoller

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/cd9bdizrrg7m3aanl87qyxasnwrm2fjp-unpoller-2.9.2
ls -la /nix/store/cd9bdizrrg7m3aanl87qyxasnwrm2fjp-unpoller-2.9.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

unpoller

Maintainer pings
cc @Frostman for testing.

@ofborg build unpoller unpoller.passthru.tests


text:
cockroachdb-bin: Expose version

Description of changes
Changes the name from cockroachdb to cockroachdb-${version} so that the version is visible in tools such as nix search. Also adds pname and version.
Does not modify the name given to buildFHSEnv as that will influence the name of the binary it creates.
I'd be happy to hear if this is consistent with best practices/style.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

LGTM thanks @sebastianblunt

authors: neosimsim sebastianblunt


text:
nixos/systemd-boot: Add support for an XBOOTLDR partition

Description of changes
It is possible that the size of the ESP partition is very small (say 100MB), for e.g., when dual booting with Windows. Currently, systemd-boot install entries only to the ESP partition, which results in "Out of disk space" errors when trying to store multiple kernel generations. This PR adds support for an additional XBOOTLDR partition as described in the Boot Loader Specification, which helps sidestep the issue.
This is an draft PR for feedback. The changes in systemd-boot nixos module were straighforward. However, to add tests, I had to make some invasive changes to the qemu and disk image modules. Perhaps there is a less invasive way by creating a custom VM only for these specific tests? Atleast the code in the disk image module will need to be replicated though.
Thanks to @colemickens for encouraging me to further expand on his PR #226692.
Cc @ElvishJerricco @RaitoBezarius, can you take a look.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I separated out the changes to different modules and added comments.
I also added a release note for 23.11, although I'm not sure if this will be merged in time for the release.
@ElvishJerricco @RaitoBezarius Can you take a look now? Thanks.

@RaitoBezarius @ElvishJerricco Not sure if you've seen this yet. Maybe there is still time to get this merged for 23.11?
I think this is an important feature. I'm actually surprised it isn't already added. Perhaps most NixOS users don't dual boot with Windows or somehow work around the limited ESP partition size.

Thanks @ElvishJerricco. Is there anything else I need to do to get this merged?

Thanks for the ping! I'll take a look sometime later this week.

@danielfullmer are you ok being added as a maintainer of these tests?

@danielfullmer are you ok being added as a maintainer of these tests?

I honestly was planning to remove Daniel from maintainers of systemd-boot (tests included) because I don't think he has been very active around them (which is fine).
@JulienMalka told me in private communications that he may be interested in taking over systemd-boot maintenance, at least, for the tests side.

Ah right I copied the maintainer values too.
Actually, if you want, I can be a (co-)maintainer. I got a good enough understanding of how the systemd-boot installation and tests work and can help out with that atleast.

Can we get this merged for 23.11? What are the remaining blockers?
@ElvishJerricco

I'm ok with merging. @RaitoBezarius are we ok with the maintainers field in the test here?

I'm ok with merging. @RaitoBezarius are we ok with the maintainers field in the test here?

Nope, I don't think I have seen the people set in that maintainers field saying they were okay with that, cc @Enzime @danielfullmer.
Please remove them and add yourself.

@JulienMalka as the new maintainer of the systemd boot builder script, you should review this.

I will review this change shortly

I'm not a big fan of how intrusive supporting XBOOTLDR is, it seems fragile

@RaitoBezarius Can you say more on why you think it's fragile. The changes are a little intrusive, yes. especially in make-disk-image.nix, which need to setup two boot partitions instead of one. However, I think the code is well isolated behind the configured flag. I also think anyone should be able to quickly catch on what's happening if they understand the rest of the code.
And yeah I'm planning to stick around and help out as needed.

@ofborg test systemd-boot

@JulienMalka @ElvishJerricco I addressed the comments in a new commit to make it easy to review again. Once ready to merge, I'll do a final squash.

@JulienMalka ping ^

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/boot-partition-and-mount-point-with-dual-boot-windows/38512/4

Friendly ping @ElvishJerricco, your currently standing review is the last blocker for this.

Friendly ping @ElvishJerricco, your currently standing review is the last blocker for this.

It also needs a rebase :3

@sdht0 I've gone ahead and rebased, resolved conflicts, and cleaned up the git history in my branch: https://github.com/NixOS/nixpkgs/compare/master...ElvishJerricco:nixpkgs:systemd-boot-xbootldr
The only significant conflict was a slight refactor of systemd-boot-builder.py, so I edited the changes to adhere to that refactor. Do you mind if I push that to this PR?

@ElvishJerricco nit: maybe remove the stray /EFI capitalization if it's lowercase everywhere else, otherwise looks good. Alright. let's do this!

maybe remove the stray /EFI capitalization if it's lowercase everywhere else

Fair enough. Though, I would like to have that change eventually, because if you load a driver for a case-sensitive file system, it does actually matter. We can leave it for later though

@ofborg eval

Meant to send this comment last night, but I tested this (the latest variable commit) on a new Rock5b install with split efi and (ext)boot and it worked perfectly.

@JulienMalka It looks good to me now. Feel free to double check since I rebased it.
@RaitoBezarius

I'm not a big fan of how intrusive supporting XBOOTLDR is, it seems fragile, and I am not sure any of the active maintainer will be able to support it, so please be certain that you will be around to actively tend to it if we end up merging this.

Are your concerns here sufficiently alleviated?

No, the QEMU VM is still too much from my personal perspective, but I won't block on that, if we have any issue with this, I will just ping the maintainer at that time and if we cannot get it to work, I will schedule it for removal.
@Nikstur and I have been planning a bunch of overhauls for the QEMU VM framework interface, and we would like to keep the module modifications to a minimal until we can get started.
In my ideal world, XBOOTLDR should just be normal operations of ESP + a weird /boot partition and all of that has nothing to do in internals like qemu-vm.nix, I made my point, I unfortunately don't have much time to stick around.

I'm really quite opposed to the changes to the qemu-vm.nix module and I also believe they are not needed.

I also think anyone should be able to quickly catch on what's happening if they understand the rest of the code.

I do not feel that way. I've read and changed the qemu-vm.nix code many times and its convoluted and confusingly mixes concepts all the time. It is extremely hard to change and even harder to change without breaking things. I feel like your change would pile on to this and make the issue worse.
Additionally, XBOOTLDR is generally not very useful for VMs because you typically can just make the ESP as large as you need in a virtual image. The only real value then lies in testing. However, I don't want to treat qemu-vm as the kitchen sink where we implement all sorts of testing features.
Instead of changing qemu-vm.nix, you should do:

Create the image with an XBOOTLDR partition in the test that requires it by directly calling make-disk-image
Tell the test driver to use this image instead by pointing NIX_DISK_IMAGE to your image. You can find an example of how this works here: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/appliance-repart-image.nix#L100

You could put this in a fixture so that it can be reused by others if that's a concern.

Deleted the branch by an incorrect push, sorry.
@nikstur @RaitoBezarius After many struggles, I've managed to figure out how to avoid changed in qemu-vm. Can you please take a look at https://github.com/NixOS/nixpkgs/pull/285401/commits/7afa4bcdf9ed42fb6538055db5901910a789e5e4#diff-f71ea5f910763bce18731f20cfb7fa3c6f31d4ebecf3a37c75cf410858b5bb53.
@JulienMalka @ElvishJerricco the rest of the changes remain the same in the new PR, but please do take another look.

authors: ElvishJerricco JulienMalka RaitoBezarius colemickens nikstur nixos-discourse nyabinary sdht0


text:
fix #26379

Motivation for this change
Fix #26379
regression after https://github.com/NixOS/nixpkgs/commit/aa86d9fa7a93023f6c54f45631505375dc628b91
@FRidh if you insist on https://github.com/NixOS/nixpkgs/commit/aa86d9fa7a93023f6c54f45631505375dc628b91 please review all 41 usages of wrapPythonPrograms. Some of them might have something to wrap in other directories than $out/bin. It is already the second found regression of that commit (another is https://github.com/NixOS/nixpkgs/pull/26375)

Can you rename this commit following our guidelines; the package name is missing.

authors: FRidh volth


text:
exiv2: 0.28.0 -> 0.28.1

Description of changes
https://github.com/Exiv2/exiv2/blob/v0.28.1/doc/ChangeLog
Fixes CVE-2023-44398 (High).
https://github.com/Exiv2/exiv2/issues/2762 is now fixed upstream, so make checkPhase run unconditionally again.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Just add "-DCMAKE_INSTALL_DATADIR=${placeholder "dev"}/share" to cmakeFlags.

@ofborg build photoqt

@ofborg build digikam

Yes, this PR needs to provide patches for digikam, kphotoalbum and photoqt.

https://invent.kde.org/graphics/digikam/-/commit/f5ea91a7f6c1926815ec68f3e0176d6c15b83051 could probably help.

No more regression on x86_64-linux.

Result of nixpkgs-review pr 266341 run on aarch64-darwin 1

38 packages marked as broken and skipped:

cataract
cataract-unstable
entangle
gimp-with-plugins
gnome.nautilus-python
gnome.nautilus-python.dev
gnome.nautilus-python.devdoc
gnome.nautilus-python.doc
kphotoalbum
krename
latte-dock
libsForQt5.arianna
libsForQt5.bismuth
libsForQt5.krohnkite
libsForQt5.kwin-dynamic-workspaces
libsForQt5.kwin-tiling
libsForQt5.kzones
libsForQt5.parachute
lightly-boehs
lightly-qt
nordic
nordic.sddm
plasma5Packages.arianna
plasma5Packages.bismuth
plasma5Packages.krohnkite
plasma5Packages.kwin-dynamic-workspaces
plasma5Packages.kwin-tiling
plasma5Packages.kzones
plasma5Packages.parachute
python310Packages.py3exiv2
python310Packages.py3exiv2.dist
python311Packages.py3exiv2
python311Packages.py3exiv2.dist
toppler
variety
variety.dist
vimiv-qt
vimiv-qt.dist

29 packages built:

darktable
exiv2
exiv2.dev
exiv2.doc
exiv2.lib
exiv2.man
gegl
gegl.dev
gegl.devdoc
gexiv2
gexiv2.dev
gexiv2.devdoc
gimp (gimpPlugins.gimp)
gimp.dev (gimpPlugins.gimp.dev)
gimpPlugins.gmic
gnunet
gnunet-gtk
gpscorrelate
gramps
gramps.dist
libextractor
libsForQt5.kfilemetadata (plasma5Packages.kfilemetadata)
libsForQt5.kfilemetadata.bin (plasma5Packages.kfilemetadata.bin)
libsForQt5.kfilemetadata.dev (plasma5Packages.kfilemetadata.dev)
merkaartor
nomacs
photoqt
tracker-miners
viking

authors: 6t8k risicle wegank


text:
haskell.packagse.ghc96.cborg-json remove unnecessary jailbreak

cborg-json 0.2.5.0 was jailbroken on ghc9.6.x due to invalid bounds, this has been fixed upstream
This is blocking me.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

n/a For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

sandbox = relaxed
sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
n/a Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

n/a (Package updates) Added a release notes entry if the change is major or breaking
n/a (Module updates) Added a release notes entry if the change is significant
n/a (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

thx!

thank you for your ultra fast review! that's awesome @maralorn !!!

turns out there are more packages affected lol

authors: MangoIV maralorn


text:
djlint: 1.32.1 -> 1.34.1

Description of changes
Changelog: https://github.com/djlint/djLint/releases
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 277309 run on x86_64-linux 1

2 packages built:

djlint
djlint.dist

This package is broken after the update, nixos has pathspec version 0.11 and djlint now wants version at least 0.12

authors: Tom-Hubrecht traxys


text:
python311Packages.pycfmodel: 0.21.1 -> 0.21.2

Diff: https://github.com/Skyscanner/pycfmodel/compare/refs/tags/v0.21.1...v0.21.2
Changelog: https://github.com/Skyscanner/pycfmodel/releases/tag/v0.21.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 279688 run on x86_64-linux 1

6 packages built:

cfripper
cfripper.dist
python310Packages.pycfmodel
python310Packages.pycfmodel.dist
python311Packages.pycfmodel
python311Packages.pycfmodel.dist

Result of nixpkgs-review pr 279688 run on aarch64-darwin 1

6 packages built:

cfripper
cfripper.dist
python310Packages.pycfmodel
python310Packages.pycfmodel.dist
python311Packages.pycfmodel
python311Packages.pycfmodel.dist

Result of nixpkgs-review pr 279688 run on aarch64-linux 1

6 packages built:

cfripper
cfripper.dist
python310Packages.pycfmodel
python310Packages.pycfmodel.dist
python311Packages.pycfmodel
python311Packages.pycfmodel.dist


text:
stgit: 2.4.3 -> 2.4.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/stacked-git/stgit/releases.
meta.description for stgit is: A patch manager implemented on top of Git
meta.homepage for stgit is: https://stacked-git.github.io/
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.4.4 with grep in /nix/store/29vdwwwr7jp1sbsmyaxya401l7xsbm5x-stgit-2.4.4
found 2.4.4 in filename of file in /nix/store/29vdwwwr7jp1sbsmyaxya401l7xsbm5x-stgit-2.4.4

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
stgit

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/29vdwwwr7jp1sbsmyaxya401l7xsbm5x-stgit-2.4.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A stgit https://github.com/r-ryantm/nixpkgs/archive/e5d0eda6d7b06613da9840f28204d0ad9d50375e.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/e5d0eda6d7b06613da9840f28204d0ad9d50375e#stgit

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/29vdwwwr7jp1sbsmyaxya401l7xsbm5x-stgit-2.4.4
ls -la /nix/store/29vdwwwr7jp1sbsmyaxya401l7xsbm5x-stgit-2.4.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

stgit

Maintainer pings
cc @jshholland for testing.

@NickCao would you be interested in taking over maintainership for stgit? I don't really use it any more and you've merged the last few r-ryantm updates.

@NickCao would you be interested in taking over maintainership for stgit? I don't really use it any more and you've merged the last few r-ryantm updates.

I'm afraid not.

authors: NickCao jshholland r-ryantm


text:
Update default.nix

File name in help message was incorrect
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Please familiarize yourself with the contributing guide https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md

Superseded by #323667.

authors: SuperSandro2000 jrobinson-uk wegank


text:
hekatomb: init at 1.5.14-unstable-2024-02-14

Description of changes
Tool to connect to LDAP directory to retrieve informations
https://github.com/ProcessusT/HEKATOMB
Related to https://github.com/NixOS/nixpkgs/issues/81418

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 296623 run on x86_64-linux 1

2 packages built:

hekatomb
hekatomb.dist


text:
python312Packages.apsw: 3.45.2.0 -> 3.45.3.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.apsw is: A Python wrapper for the SQLite embedded relational database engine
meta.homepage for python312Packages.apsw is: https://github.com/rogerbinns/apsw
meta.changelog for python312Packages.apsw is: https://github.com/rogerbinns/apsw/releases/tag/3.45.3.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.45.3.0 with grep in /nix/store/gy09m8x1db0qazl5r5m3jahg7kpb55lr-python3.12-apsw-3.45.3.0
found 3.45.3.0 in filename of file in /nix/store/gy09m8x1db0qazl5r5m3jahg7kpb55lr-python3.12-apsw-3.45.3.0

Rebuild report (if merged into master) (click to expand)

56 total rebuild path(s)

56 package rebuild(s)

First fifty rebuilds by attrpath
activitywatch
aw-qt
aw-watcher-afk
aw-watcher-window
calibre
cozy
etesync-dav
frigate
gkraken
gwe
home-assistant-component-tests.matrix
khoj
matrix-commander
opsdroid
pantalaimon
pantalaimon-headless
pgadmin4
pgadmin4-desktopmode
python311Packages.apsw
python311Packages.aw-client
python311Packages.aw-core
python311Packages.etesync
python311Packages.flask-admin
python311Packages.flask-security-too
python311Packages.llama-index-vector-stores-postgres
python311Packages.matrix-nio
python311Packages.nplusone
python311Packages.peewee
python311Packages.peewee-migrate
python311Packages.pgvector
python311Packages.wtf-peewee
python311Packages.yfinance
python311Packages.zulip
python312Packages.apsw
python312Packages.aw-client
python312Packages.aw-core
python312Packages.etesync
python312Packages.flask-admin
python312Packages.llama-index-vector-stores-postgres
python312Packages.matrix-nio
python312Packages.nplusone
python312Packages.peewee
python312Packages.peewee-migrate
python312Packages.pgvector
python312Packages.wtf-peewee
python312Packages.yfinance
python312Packages.zulip
s3ql
semgrep
sqlite-web

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gy09m8x1db0qazl5r5m3jahg7kpb55lr-python3.12-apsw-3.45.3.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.apsw https://github.com/r-ryantm/nixpkgs/archive/7a6a2708daeb52af16f7bae18a81b26054668d5d.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7a6a2708daeb52af16f7bae18a81b26054668d5d#python312Packages.apsw

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gy09m8x1db0qazl5r5m3jahg7kpb55lr-python3.12-apsw-3.45.3.0
ls -la /nix/store/gy09m8x1db0qazl5r5m3jahg7kpb55lr-python3.12-apsw-3.45.3.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

6 packages marked as broken and skipped:

khoj
khoj.dist
python311Packages.nplusone
python311Packages.nplusone.dist
python312Packages.nplusone
python312Packages.nplusone.dist

2 packages failed to build:

s3ql
s3ql.dist

95 packages built:

activitywatch
aw-qt
aw-qt.dist
aw-watcher-afk
aw-watcher-afk.dist
aw-watcher-window
aw-watcher-window.dist
calibre
cozy
etesync-dav
etesync-dav.dist
frigate
gkraken
gwe
home-assistant-component-tests.matrix
matrix-commander
matrix-commander.dist
opsdroid
opsdroid.dist
pantalaimon
pantalaimon-headless
pantalaimon-headless.dist
pantalaimon.dist
pgadmin4
pgadmin4-desktopmode
pgadmin4-desktopmode.dist
pgadmin4.dist
python311Packages.apsw
python311Packages.apsw.dist
python311Packages.aw-client
python311Packages.aw-client.dist
python311Packages.aw-core
python311Packages.aw-core.dist
python311Packages.etesync
python311Packages.etesync.dist
python311Packages.flask-admin
python311Packages.flask-admin.dist
python311Packages.flask-security-too
python311Packages.flask-security-too.dist
python311Packages.llama-index-vector-stores-postgres
python311Packages.llama-index-vector-stores-postgres.dist
python311Packages.matrix-nio
python311Packages.matrix-nio.dist
python311Packages.peewee
python311Packages.peewee-migrate
python311Packages.peewee-migrate.dist
python311Packages.peewee.dist
python311Packages.pgvector
python311Packages.pgvector.dist
python311Packages.wtf-peewee
python311Packages.wtf-peewee.dist
python311Packages.yfinance
python311Packages.yfinance.dist
python311Packages.zulip
python311Packages.zulip.dist
python312Packages.apsw
python312Packages.apsw.dist
python312Packages.aw-client
python312Packages.aw-client.dist
python312Packages.aw-core
python312Packages.aw-core.dist
python312Packages.etesync
python312Packages.etesync.dist
python312Packages.flask-admin
python312Packages.flask-admin.dist
python312Packages.llama-index-vector-stores-postgres
python312Packages.llama-index-vector-stores-postgres.dist
python312Packages.matrix-nio
python312Packages.matrix-nio.dist
python312Packages.peewee
python312Packages.peewee-migrate
python312Packages.peewee-migrate.dist
python312Packages.peewee.dist
python312Packages.pgvector
python312Packages.pgvector.dist
python312Packages.wtf-peewee
python312Packages.wtf-peewee.dist
python312Packages.yfinance
python312Packages.yfinance.dist
python312Packages.zulip
python312Packages.zulip.dist
semgrep
semgrep.dist
sqlite-web
sqlite-web.dist
sublime-music
sublime-music.dist
unbook
visidata
visidata.dist
vorta
vorta.dist
weechatScripts.weechat-matrix
zulip-term
zulip-term.dist

Maintainer pings
cc @gador for testing.

Result of nixpkgs-review pr 304703 run on x86_64-linux 1

6 packages marked as broken and skipped:

khoj
khoj.dist
python311Packages.nplusone
python311Packages.nplusone.dist
python312Packages.nplusone
python312Packages.nplusone.dist

97 packages built:

activitywatch
aw-qt
aw-qt.dist
aw-watcher-afk
aw-watcher-afk.dist
aw-watcher-window
aw-watcher-window.dist
calibre
cozy
etesync-dav
etesync-dav.dist
frigate
gkraken
gwe
home-assistant-component-tests.matrix
matrix-commander
matrix-commander.dist
opsdroid
opsdroid.dist
pantalaimon
pantalaimon-headless
pantalaimon-headless.dist
pantalaimon.dist
pgadmin4
pgadmin4-desktopmode
pgadmin4-desktopmode.dist
pgadmin4.dist
python311Packages.apsw
python311Packages.apsw.dist
python311Packages.aw-client
python311Packages.aw-client.dist
python311Packages.aw-core
python311Packages.aw-core.dist
python311Packages.etesync
python311Packages.etesync.dist
python311Packages.flask-admin
python311Packages.flask-admin.dist
python311Packages.flask-security-too
python311Packages.flask-security-too.dist
python311Packages.llama-index-vector-stores-postgres
python311Packages.llama-index-vector-stores-postgres.dist
python311Packages.matrix-nio
python311Packages.matrix-nio.dist
python311Packages.peewee
python311Packages.peewee-migrate
python311Packages.peewee-migrate.dist
python311Packages.peewee.dist
python311Packages.pgvector
python311Packages.pgvector.dist
python311Packages.wtf-peewee
python311Packages.wtf-peewee.dist
python311Packages.yfinance
python311Packages.yfinance.dist
python311Packages.zulip
python311Packages.zulip.dist
python312Packages.apsw
python312Packages.apsw.dist
python312Packages.aw-client
python312Packages.aw-client.dist
python312Packages.aw-core
python312Packages.aw-core.dist
python312Packages.etesync
python312Packages.etesync.dist
python312Packages.flask-admin
python312Packages.flask-admin.dist
python312Packages.llama-index-vector-stores-postgres
python312Packages.llama-index-vector-stores-postgres.dist
python312Packages.matrix-nio
python312Packages.matrix-nio.dist
python312Packages.peewee
python312Packages.peewee-migrate
python312Packages.peewee-migrate.dist
python312Packages.peewee.dist
python312Packages.pgvector
python312Packages.pgvector.dist
python312Packages.wtf-peewee
python312Packages.wtf-peewee.dist
python312Packages.yfinance
python312Packages.yfinance.dist
python312Packages.zulip
python312Packages.zulip.dist
s3ql
s3ql.dist
semgrep
semgrep.dist
sqlite-web
sqlite-web.dist
sublime-music
sublime-music.dist
unbook
visidata
visidata.dist
vorta
vorta.dist
weechatScripts.weechat-matrix
zulip-term
zulip-term.dist

authors: matthiasbeyer r-ryantm


text:
multicompiler: add multicompiler package

Motivation for this change
Adds the multicompiler, which is a fork of the llvm-based clang which provides artificial software diversity to protect software from code-reuse attacks.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Please note that the checks fail due to the Travis timeout on the build job; building llvm+clang takes longer than Travis will allow, but I have built this successfully in a local sandbox... several times, unfortunately :-).

Can you update this for latest master?
I'll review this shortly...
Also pinging cc-wrapper maintainers @Erickson2314 @orivej

Oh! I am sorry I didn't see this earlier. I have in fact used the multicompiler.

This had looked pretty good modulo @dtzWill's comments. Now that we support cross compilation with llvm, it should be even easier.

authors: Ericson2314 dtzWill kquick


text:
yabai: pkgs/os-specific -> pkgs/by-name

Description of changes
Looking to take advantage of nixpkgs-merge-bot for some of the packages I maintain. Moving these to by-name.
Splitting off https://github.com/NixOS/nixpkgs/pull/303961

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@GrahamcOfBorg build yabai


text:
cascadia-code: 2111.01 -> 2404.23

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/microsoft/cascadia-code/releases.
meta.description for cascadia-code is: Monospaced font that includes programming ligatures and is designed to enhance the modern look and feel of the Windows Terminal
meta.homepage for cascadia-code is: https://github.com/microsoft/cascadia-code
meta.changelog for cascadia-code is: https://github.com/microsoft/cascadia-code/raw/v2404.23/FONTLOG.txt
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2404.23 with grep in /nix/store/f0syrnk3ywp6s7xg0qzmw9mfvg4lylaw-cascadia-code-2404.23
found 2404.23 in filename of file in /nix/store/f0syrnk3ywp6s7xg0qzmw9mfvg4lylaw-cascadia-code-2404.23

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

cascadia-code

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/f0syrnk3ywp6s7xg0qzmw9mfvg4lylaw-cascadia-code-2404.23 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cascadia-code https://github.com/r-ryantm/nixpkgs/archive/7cc05430c59a4ca4e302703765d83b04c3965895.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7cc05430c59a4ca4e302703765d83b04c3965895#cascadia-code

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/f0syrnk3ywp6s7xg0qzmw9mfvg4lylaw-cascadia-code-2404.23
ls -la /nix/store/f0syrnk3ywp6s7xg0qzmw9mfvg4lylaw-cascadia-code-2404.23/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

cascadia-code

Maintainer pings

Duplicate of https://github.com/NixOS/nixpkgs/pull/308135

authors: r-ryantm zendo


text:
cbmc: 5.91.0 -> 5.95.1

Description of changes

https://github.com/diffblue/cbmc/releases/tag/cbmc-5.95.1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 309880 run on aarch64-linux 1

1 package built:

cbmc

please mark broken no x86_64-darwin
https://hydra.nixos.org/job/nixpkgs/trunk/cbmc.x86_64-darwin

please mark broken on x86_64-darwin https://hydra.nixos.org/job/nixpkgs/trunk/cbmc.x86_64-darwin

Done

fixes https://hydra.nixos.org/build/202332940 hence zhf https://github.com/NixOS/nixpkgs/issues/309482

authors: getchoo jiegec pbsds


text:
home-assistant.python.pkgs.pytest-homeassistant-custom-component: init at 0.13.147

We'd need to have Home Assistant be available as home-assistant.python.pkgs.homeassistant, similarly to how poetry does it. Should we do that?
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

We'd need to have Home Assistant be available as home-assistant.python.pkgs.homeassistant, similarly to how poetry does it. Should we do that?

Does that even work? I would suspect this triggering an infinite recursion.

We'd need to have Home Assistant be available as home-assistant.python.pkgs.homeassistant, similarly to how poetry does it. Should we do that?

Yes.

Does that even work? I would suspect this triggering an infinite recursion.

It doesn't if done right. Check out https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/package-management/poetry/default.nix.

Don't we just need

home-assistant = self.toPythonModule home-assistant;

in the package set?

Yes, that works.
music-assistant/mass> Executing pytestCheckPhase
music-assistant/mass> ============================= test session starts ==============================
music-assistant/mass> platform linux -- Python 3.12.4, pytest-8.2.2, pluggy-1.5.0
music-assistant/mass> rootdir: /build/source
music-assistant/mass> configfile: pyproject.toml
music-assistant/mass> plugins: homeassistant-custom-component-0.13.147, anyio-4.3.0, asyncio-0.23.6, socket-0.7.0, requests-mock-1.12.1, syrupy-4.6.1
music-assistant/mass> asyncio: mode=Mode.AUTO
music-assistant/mass> collected 7 items
music-assistant/mass>
music-assistant/mass> tests/test_config_flow.py .......                                        [100%]
music-assistant/mass>
music-assistant/mass> ============================== 7 passed in 0.78s ===============================

+      home-assistant = self.toPythonModule home-assistant;

True, that also works as long as no overrides happen.

The custom components are just dropped into /var/lib/hass/custom_components by the module. There is no connection that I can see, that would tie them together.

There is no connection that I can see, that would tie them together.

True, especially since custom modules are also built with top-level home-assistant's Python packages.

I fail to understand why govee-lan's tests don't work:
============================= test session starts ==============================
platform linux -- Python 3.12.4, pytest-8.2.2, pluggy-1.5.0
rootdir: /build/source
configfile: setup.cfg
testpaths: tests
plugins: homeassistant-custom-component-0.13.147, anyio-4.3.0, asyncio-0.23.6, socket-0.7.0, requests-mock-1.12.1, syrupy-4.6.1
asyncio: mode=Mode.STRICT
collected 1 item

tests/test_init.py s                                                     [100%]

=============================== warnings summary ===============================
tests/test_init.py::test_async_setup
  /nix/store/6m4rxk7rn1ncads8mfjp55hxphzyfr2j-python3.12-pytest-8.2.2/lib/python3.12/site-packages/_pytest/python.py:151: PytestUnhandledCoroutineWarning: async def functions are not natively supported and have been skipped.
  You need to install a suitable plugin for your async framework, for example:
    - anyio
    - pytest-asyncio
    - pytest-tornasync
    - pytest-trio
    - pytest-twisted
    warnings.warn(PytestUnhandledCoroutineWarning(msg.format(nodeid)))

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================== 1 skipped, 1 warning in 0.19s =========================

Missing @pytest.mark.asyncio on the test?

I now get
_______________________________ test_async_setup _______________________________

hass = <async_generator object hass at 0x7ffff183aac0>

    @pytest.mark.asyncio
    async def test_async_setup(hass):
        """Test the component gets setup."""
>       assert await async_setup_component(hass, DOMAIN, {}) is True

tests/test_init.py:12:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

hass = <async_generator object hass at 0x7ffff183aac0>, domain = 'govee_lan'
config = {}

    async def async_setup_component(
        hass: core.HomeAssistant, domain: str, config: ConfigType
    ) -> bool:
        """Set up a component and all its dependencies.

        This method is a coroutine.
        """
>       if domain in hass.config.components:
E       AttributeError: 'async_generator' object has no attribute 'config'

and that sounds more like the internal Home Assistant API changed.

authors: SuperSandro2000 dotlambda mweinelt


text:
zfs_2_2: fix latestCompatibleLinuxPackages

Broken in ba0d495264c67cdb306a3aa7200e8ed7ebb548ae, which removed Linux 6.8 and 6.9, so now 6.6 is the latest compatible.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

No need for a backport btw because I already did the correct thing in https://github.com/NixOS/nixpkgs/pull/334640 (because the last 2.2 bump wasn't backported).


text:
python312Packages.multiset: 3.1.0 -> 3.2.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.multiset is: Implementation of a multiset
meta.homepage for python312Packages.multiset is: https://github.com/wheerd/multiset
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.2.0 with grep in /nix/store/3byz226lsws14dkp7aa6lxn01jp3j3w1-python3.12-multiset-3.2.0
found 3.2.0 in filename of file in /nix/store/3byz226lsws14dkp7aa6lxn01jp3j3w1-python3.12-multiset-3.2.0

Rebuild report (if merged into master) (click to expand)

10 total rebuild path(s)

10 package rebuild(s)

First fifty rebuilds by attrpath

python311Packages.loopy
python311Packages.matchpy
python311Packages.multiset
python311Packages.pymbolic
python311Packages.uarray
python312Packages.matchpy
python312Packages.multiset
python312Packages.pymbolic
python312Packages.uarray

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3byz226lsws14dkp7aa6lxn01jp3j3w1-python3.12-multiset-3.2.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.multiset https://github.com/r-ryantm/nixpkgs/archive/f33eea32b2a11fdffb4a0fc8c75d313f522f48ea.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/f33eea32b2a11fdffb4a0fc8c75d313f522f48ea#python312Packages.multiset

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3byz226lsws14dkp7aa6lxn01jp3j3w1-python3.12-multiset-3.2.0
ls -la /nix/store/3byz226lsws14dkp7aa6lxn01jp3j3w1-python3.12-multiset-3.2.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

18 packages built:

python311Packages.loopy
python311Packages.loopy.dist
python311Packages.matchpy
python311Packages.matchpy.dist
python311Packages.multiset
python311Packages.multiset.dist
python311Packages.pymbolic
python311Packages.pymbolic.dist
python311Packages.uarray
python311Packages.uarray.dist
python312Packages.matchpy
python312Packages.matchpy.dist
python312Packages.multiset
python312Packages.multiset.dist
python312Packages.pymbolic
python312Packages.pymbolic.dist
python312Packages.uarray
python312Packages.uarray.dist

Maintainer pings

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 337723 run on x86_64-linux 1

18 packages built:

python311Packages.loopy
python311Packages.loopy.dist
python311Packages.matchpy
python311Packages.matchpy.dist
python311Packages.multiset
python311Packages.multiset.dist
python311Packages.pymbolic
python311Packages.pymbolic.dist
python311Packages.uarray
python311Packages.uarray.dist
python312Packages.matchpy
python312Packages.matchpy.dist
python312Packages.multiset
python312Packages.multiset.dist
python312Packages.pymbolic
python312Packages.pymbolic.dist
python312Packages.uarray
python312Packages.uarray.dist

authors: fabaff r-ryantm


text:
gitify: init at 5.16.1

Description of changes
Adds gitify package
closes #250470

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1942

@Luflosi Thanks for the suggestion!
I have updated the commit.

I used to use this app on macOS. How can I run it on Linux? I tried simply executing bin/gitify but nothing seems to happen. Maybe it doesn't work with GNOME? Or do I need to actually install it?

I'm using it on gnome now, so I'm not sure what the issue is..
When I first ran it, it only showed a status icon (you may need a gnome extension to show the status icons). Double-clicking the icon showed the application window.

Thanks for the hint. I got it working by installing gnomeExtensions.appindicator.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1960

Updated the package since

there was a new version available
the update to pnpm was causing the pnpmDeps hash to change

The build is failing on x86_64-darwin.
I will update the commit when I fix the issue.

authors: Luflosi nixos-discourse pineapplehunter


text:
measureme: 11.0.1 -> 12.0.0

Description of changes
Version bump and moved to by-name

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Can you make the by-name change a separate commit?


text:
python312Packages.google-cloud-logging: 3.10.0 -> 3.11.2

Changelog: https://github.com/googleapis/python-logging/blob/v3.11.2/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 339491 run on x86_64-linux 1

8 packages marked as broken and skipped:

python311Packages.distrax
python311Packages.distrax.dist
python311Packages.elegy
python311Packages.elegy.dist
python311Packages.rlax
python311Packages.rlax.dist
python311Packages.treex
python311Packages.treex.dist

24 packages built:

python311Packages.dalle-mini
python311Packages.dalle-mini.dist
python311Packages.dm-haiku
python311Packages.dm-haiku.dist
python311Packages.evosax
python311Packages.evosax.dist
python311Packages.flax
python311Packages.flax.dist
python311Packages.flowmc
python311Packages.flowmc.dist
python311Packages.google-cloud-error-reporting
python311Packages.google-cloud-error-reporting.dist
python311Packages.google-cloud-logging
python311Packages.google-cloud-logging.dist
python311Packages.orbax-checkpoint
python311Packages.orbax-checkpoint.dist
python311Packages.vqgan-jax
python311Packages.vqgan-jax.dist
python312Packages.google-cloud-error-reporting
python312Packages.google-cloud-error-reporting.dist
python312Packages.google-cloud-logging
python312Packages.google-cloud-logging.dist
python312Packages.orbax-checkpoint
python312Packages.orbax-checkpoint.dist


text:
numbat: 1.12.0 -> 1.13.0

Description of changes
https://github.com/sharkdp/numbat/releases/tag/v1.13.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 341128 run on x86_64-linux 1

1 package built:

numbat

Looks good to me!

Tests fail on darwin

@donovanglover does the result work in your manual testing? If so we could simply disable checks on darwin for now.

What are we going to do about Darwin?
I think if we don't get feedback from a Darwin user on whether the application works fine with doCheck = false in the next few days, we'll have to mark it as broken.

Approve is regarding patching/in general for linux platforms, will wait on input from darwin contributors/maintainers

@xeals could you set numbat to be broken on darwin? Then we can merge.

Result of nixpkgs-review pr 341128 run on x86_64-linux 1

1 package built:

numbat

authors: Atemu donovanglover fabianhjr giomf xeals


text:
materialgram: 5.6.1.1 -> 5.7.0.1

Diff: https://github.com/kukuruzka165/materialgram/compare/refs/tags/v5.6.1.1...v5.7.0.1
Changelog: https://github.com/kukuruzka165/materialgram/releases/tag/v5.7.0.1

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 353423

x86_64-linux

:x: 1 package failed to build:

materialgram

:(

Already part of https://github.com/NixOS/nixpkgs/pull/353524

authors: NickCao oluceps