text:
Add Cockpit CMS service / template

Changes

Added Cockpit headless CMS (MIT licensed) to templates

Thank you for the PR 💜.

authors: aheinze peaklabs-dev


text:
fix: install graphviz for missing dot binary

Why?
Missing dot binary(provided by graphviz) was causing plantuml diagram to not be rendered in techdocs.
Changes
Install graphviz in techdocs image.
Fixed #1421

Should we pin the version?

Should we pin the version?

@hawi74 I am not sure about that. The version of graphviz we are installing is 2.42.2-7+b3. Also, it doesn't look like it has multiple installation candidate either. Pinning the version might break the build, if debian updates the package in their repo.

source: gharchive/pull-request

repo: coopnorge/engineering-docker-images

license: MIT

license_type: permissive

license_source: github-api


text:
[1.11.2] Backpacks break when killed by a creeper

Heya,
as far as i know the backpack should place itself when the player dies, which works in all cases except for when a creeper explodes. I understand that the backpacks are not immune to explosions, but when a creeper kills me, shouldn't that explosion ignore the backpack and just place it down? Is it being placed too early before the explosion is breaking blocks perhaps?
Using the latest verison,
Thanks,
SC

Hmm. Interesting. I don't think that was an issue with BetterStorage, and if I remember correctly it used the same events. I might look into it at some point, perhaps give the backpack explosion immunity for a few ticks if it turns out there is no other way around this.

Found out the issue, might as well leave it here for the record.
Explosions work this way:

Collect all blocks that would be destroyed by the explosion.
Damage entities.
Destroy all collected blocks.

Player dies in the second step and the backpack is placed. It is then destroyed in the third step, and the placed block might as well be bedrock, as the explosion resistance is only checked in the first step.

Thanks a lot for fixing this! :D

Unfortunately I had to break another part of the mod. The fix required me to use a different method to drop the backpack itself when the block is broken. So instead of dropping it the intended, normal way (through getDrops), it drops along with the contents. This means you'll get the backpack when breaking it in creative, too. I guess I could treat that as a feature, though. Minecraft modding is a mess.

source: gharchive/issue

authors: Kiyaku copygirl

repo: copygirl/WearableBackpacks

license: mit

license_source: bigquery


text:
Separate out bodyprocessor implementations for TinyGo

This splits out the bodyprocessor change from #254 to make it easier to review, especially since it introduces a new dependency.
JSON processing is tweaked to only use encoding/json (based on reflection) with gjson (not reflection since only supports decoding of map). The change is conservative to not change the normal path, but we could consider only using gjson for both paths in the future since it probably has better performance (their benchmarks show 2x better)
XML processing is tweaked to be disabled on TinyGo, we will look at how to make it work there in the future.

Thank you for contributing to Coraza WAF, your effort is greatly appreciated
Before submitting check if what you want to add to coraza list meets quality standards before sending pull request. Thanks!

Note: that go.mod and go.sum can only be modified for tested dependency updates or justified new features.
Make sure that you've checked the boxes below before you submit PR:

[X] My code includes positive and negative tests.
[X] I have an appropriate description with correct grammar.
[X] I have read Contribution guidelines, maintainers note and Quality standard.

Thanks for your PR :heart:

Using gjson for the sake of maintainability + performance is a good call
IMHO. What do you think @jptosso @fzipitria?
On Mon, 8 Aug 2022, 07:45 Anuraag Agrawal, @.***> wrote:

This splits out the bodyprocessor change from #254
https://github.com/corazawaf/coraza/pull/254 to make it easier to
review, especially since it introduces a new dependency.
JSON processing is tweaked to only use encoding/json (based on
reflection) with gjson (not reflection since only supports decoding of map).
The change is conservative to not change the normal path, but we could
consider only using gjson for both paths in the future since it probably
has better performance (their benchmarks show 2x better)
XML processing is tweaked to be disabled on TinyGo, we will look at how to
make it work there in the future.
Thank you for contributing to Coraza WAF, your effort is greatly
appreciated
Before submitting check if what you want to add to coraza list meets quality
standards
https://github.com/corazawaf/coraza/blob/master/CONTRIBUTING.md#quality-standards
before sending pull request. Thanks!
Note: that go.mod and go.sum can only be modified for tested
dependency updates or justified new features.
Make sure that you've checked the boxes below before you submit PR:

My code includes positive and negative tests.
I have an appropriate description with correct grammar.
I have read Contribution guidelines
https://github.com/corazawaf/coraza/blob/master/CONTRIBUTING.md#contribution-guidelines,
maintainers note
https://github.com/corazawaf/coraza/blob/master/CONTRIBUTING.md#maintainers
and Quality standard
https://github.com/github.com/corazawaf/coraza/v2sso/coraza-waf/blob/master/CONTRIBUTING.md#quality-standards
.

Thanks for your PR ❤
You can view, comment on, or merge this pull request online at:
https://github.com/corazawaf/coraza/pull/311
Commit Summary

92a6412
https://github.com/corazawaf/coraza/pull/311/commits/92a641299cdea56c4dec19783a6493e6ab4b07dd
Separate out bodyprocessor implementations for TinyGo

File Changes
(8 files https://github.com/corazawaf/coraza/pull/311/files)

M bodyprocessors/json.go
https://github.com/corazawaf/coraza/pull/311/files#diff-5a9c587073623d7b03866faac6d91020a61d7227173850e7785a225038b1c9ba
(7)
A bodyprocessors/json_unmarshaler.go
https://github.com/corazawaf/coraza/pull/311/files#diff-3b8b9579dc7064f8ff2c6f47324af012e31cdd2fdbc42c22243fb0effa213adb
(29)
A bodyprocessors/json_unmarshaler_tinygo.go
https://github.com/corazawaf/coraza/pull/311/files#diff-19f72b164c9bf4910cf01e0b0bb573c575dee540370bc62555bc27dc92f08188
(26)
M bodyprocessors/xml.go
https://github.com/corazawaf/coraza/pull/311/files#diff-9536f3310e45496ccbcd1652976fec1d8e42d9addde10adeb878be3b7e4e5763
(3)
A bodyprocessors/xml_test.go
https://github.com/corazawaf/coraza/pull/311/files#diff-259f1b76a24e15211a09ebeba3c166a78abf7012b2af27db2ff63f87a5f1bf1a
(65)
A bodyprocessors/xml_tinygo.go
https://github.com/corazawaf/coraza/pull/311/files#diff-166290197409a475d80e6cc80571620ab58a857bc0ad5de31c6743ba44c4c7cd
(44)
M go.mod
https://github.com/corazawaf/coraza/pull/311/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6
(1)
M go.sum
https://github.com/corazawaf/coraza/pull/311/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63
(6)

Patch Links:

https://github.com/corazawaf/coraza/pull/311.patch
https://github.com/corazawaf/coraza/pull/311.diff

—
Reply to this email directly, view it on GitHub
https://github.com/corazawaf/coraza/pull/311, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXOYARMR4UGHTQ3IP6X5ODVYCNHXANCNFSM5532JYJA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Sorry, fixed the tinygo test

Sorry, I failed to fix conflicts, could you run a go mod tidy to fix the files?

Thanks @jptosso merged

authors: anuraaga jcchavezs jptosso

repo: corazawaf/coraza


text:
🛑 Guangdianyun is down

In ae9acaf, Guangdianyun (https://www.guangdianyun.tv) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Guangdianyun is back up in 062fd11.

repo: corcd/charlotte


text:
Fix nil dereference in example

The example user-data has no 'update' section, so simply using the
config.rb sample and user-data sample will fail w/ a nil dereference.
Guard against this.

thanks! LGTM

authors: flandr jonboulle

repo: coreos/coreos-vagrant


text:
error resources: ID already exists.

Im running dex v2.2.2 on kubernetes, after a pod restarts, i see multiple lines of failed creating third party resources: ID already exists.
should this be an error? should it log it once and maybe as info? or is it standard that I go in after each restart and update the client-id?

@yawboateng I think https://github.com/coreos/dex/pull/815 is causing this. I don't think it's actually going to cause bad behavior, but yeah we should correct the if condition.

Sending a fix now. We'll backport and release a 2.2.3 today.

authors: ericchiang yawboateng

repo: coreos/dex


text:
controller: change etcd-backup-operator controller naming

change etcd-backup-operator/controller to controller/backup-operator

cc/ @hasbro17 @hongchaodeng

cc/ @hongchaodeng fixed naming

lgtm

authors: fanminshi hongchaodeng

repo: coreos/etcd-operator


text:
Cannot set --name correctly in etcd 2.0.0-rc.1

I'm currently the v2.0.0-rc1 version on my Mac.
It works when I use the default machine name "default".
Both of following commands work:
./etcd
./etcd --name 'default'

But it doesn't work when I assign another name
MacBook-Pro:try willy$ ./etcd --name default2
2015/01/13 17:57:58 no data-dir provided, using default data-dir ./default2.etcd
2015/01/13 17:57:58 etcd: listening for peers on http://localhost:2380
2015/01/13 17:57:58 etcd: listening for peers on http://localhost:7001
2015/01/13 17:57:58 etcd: listening for client requests on http://localhost:2379
2015/01/13 17:57:58 etcd: listening for client requests on http://localhost:4001
2015/01/13 17:57:58 etcd: stopping listening for client requests on http://localhost:4001
2015/01/13 17:57:58 etcd: stopping listening for client requests on http://localhost:2379
2015/01/13 17:57:58 etcd: stopping listening for peers on http://localhost:7001
2015/01/13 17:57:58 etcd: stopping listening for peers on http://localhost:2380
2015/01/13 17:57:58 etcd: couldn't find local name "default2" in the initial cluster configuration

The name you give to etcd must match the name you have in the initial cluster configuration. The default ones are matched. If you change the name, then you need to change the initial cluster configuration.
Please refer https://github.com/coreos/etcd/blob/master/Documentation/2.0/clustering.md

repo: coreos/etcd


text:
jsonnet/kube-prometheus-prometheus-adapter: fix node query

Currently, we use the node:node_memory_bytes_total:sum and node:node_memory_bytes_available:sum
recording rules for the memory node query.
These recording rules have been removed in https://github.com/coreos/kube-prometheus/pull/191.
This fixes it by using raw queries.
/cc @paulfantom @brancz I verified this in a running clusters and it seems to work fine.

/lgtm
:shipit:

authors: paulfantom s-urbaniak

repo: coreos/kube-prometheus


text:
1.5 patchset

cc @aaronlevy

lgtm

repo: coreos/kubernetes


text:
contrib/kube-prometheus: fix GKE cAdvisor readme link

I noticed this when reading the docs: https://github.com/coreos/prometheus-operator/tree/master/contrib/kube-prometheus#error-retrieving-kubelet-metrics

Thanks!

authors: adamdecaf brancz

repo: coreos/prometheus-operator


text:
prometheus: make node sync periodic instead of watching

@fabxc

Just curious , what was wrong with node watchers?

We still have to investigate the core of the issue, but the leak seemed to come from the StreamWatcher of the Node Informer. This "solution" merely avoids that code path, but we still have to investigate why this is happening, we have planned to do so over the coming weeks, but fix the leak with a pragmatic approach for now.

authors: brancz redbaron


text:
TestUserns fails on CentOS 7

TestUserns fails on CentOS 7:
$ make functional-check GO_TEST_FUNC_ARGS='-run TestUser'
  GO TEST      github.com/coreos/rkt/tests
=== RUN TestUserns
--- FAIL: TestUserns (11.77s)
	rkt_userns_test.go:65: Running 'run' test #0: /var/tmp/rkt/builds/build-rkt-coreos-/build-rkt-0.14.0+git/bin/rkt --dir=/tmp/datadir-750947925 --local-config=/tmp/localdir-981642672 --system-config=/tmp/systemdir-222893903 --debug --insecure-options=image run  --no-overlay --set-env=FILE=/ --mds-register=false /var/tmp/rkt/builds/build-rkt-coreos-/build-rkt-0.14.0+git/tmp/functional/test-tmp/rkt-inspect-stat.aci
	rkt_userns_test.go:65: Running 'run' test #0: /var/tmp/rkt/builds/build-rkt-coreos-/build-rkt-0.14.0+git/bin/rkt --dir=/tmp/datadir-701898850 --local-config=/tmp/localdir-603407961 --system-config=/tmp/systemdir-166618084 --debug --insecure-options=image run --private-users --no-overlay --set-env=FILE=/ --mds-register=false /var/tmp/rkt/builds/build-rkt-coreos-/build-rkt-0.14.0+git/tmp/functional/test-tmp/rkt-inspect-stat.aci
	rkt_userns_test.go:73: Expected "drwxr-xr-x" but not found: rkt: using image from file /var/tmp/rkt/builds/build-rkt-coreos-/build-rkt-0.14.0+git/bin/stage1-coreos.aci
		rkt: using image from file /var/tmp/rkt/builds/build-rkt-coreos-/build-rkt-0.14.0+git/tmp/functional/test-tmp/rkt-inspect-stat.aci
		2015/12/29 21:30:48 Preparing stage1
		2015/12/29 21:30:51 Writing image manifest
		2015/12/29 21:30:51 Loading image sha512-5b92352f7806f6311e94d7cb16b80bc3b728307c86af58b2d52b2f4b59b9e75b
		2015/12/29 21:30:52 Writing image manifest
		2015/12/29 21:30:52 Writing pod manifest
		2015/12/29 21:30:52 Setting up stage1
		2015/12/29 21:30:52 Wrote filesystem to /tmp/datadir-701898850/pods/run/8797eae9-08f7-485b-b2e1-7bdbecff792c
		2015/12/29 21:30:52 Pivoting to filesystem /tmp/datadir-701898850/pods/run/8797eae9-08f7-485b-b2e1-7bdbecff792c
		2015/12/29 21:30:52 Execing /init
		2015/12/29 21:30:52 Loading networks from /tmp/localdir-603407961/net.d
		2015/12/29 21:30:52 Loading network default with type ptp
		Spawning container rkt-8797eae9-08f7-485b-b2e1-7bdbecff792c on /tmp/datadir-701898850/pods/run/8797eae9-08f7-485b-b2e1-7bdbecff792c/stage1/rootfs.
		Press ^] three times within 1s to kill container.
		Using user namespaces with base 787742720 and range 65536.
		Failed to fork inner child: Invalid argument
FAIL

Logs from strace:
[pid 23608] chroot(".")                 = 0
[pid 23608] chdir("/")                  = 0
[pid 23608] clone(child_stack=0, flags=CLONE_NEWNS|CLONE_NEWUTS|CLONE_NEWIPC|CLONE_NEWUSER|CLONE_NEWPID|SIGCHLD) = -1 EINVAL (Invalid argument)
[pid 23608] writev(2, [{"Failed to fork inner child: Invalid argument", 44}, {"\n", 1}], 2) = 45

But user namespaces are enabled in the kernel so this should work:
$ grep USER_NS /boot/config-$(uname -r)
CONFIG_USER_NS=y

This was tested using #1925.

User namespaces are enabled, and /proc/self/uid_map is available. But it does not work nonetheless:
# strace unshare -U -f
unshare(CLONE_NEWUSER)                  = -1 EINVAL (Invalid argument)

According to https://bugzilla.redhat.com/show_bug.cgi?id=1168776#c5, this is an issue with the CentOS 7 kernel.
I don't know if we should detect this somehow and disable the test in this case?

"fixed" by #1947

authors: alban jonboulle

repo: coreos/rkt


text:
Investigate more isolation between stage1 and stage2

systemd in stage1 needs more capabilities than the apps in stage2. To make it more difficult for apps to acquire new caps from systemd, stage1 and stage2 could be more isolated. At the moment, they are separated by a chroot, which is not a security isolation.
Systemd has several parameters to setup a new mount namespace:

ReadWriteDirectories=, ReadOnlyDirectories=, InaccessibleDirectories=
RootDirectory= (see also #679)

stage2 would need to use MountFlags=slave.

I guess https://github.com/coreos/rkt/pull/2603 closes this

Closed via #2603

authors: alban iaguis


text:
documentation missing from networking section for --dns=host

It took me a while to figure out the problem was I was missing the --dns=host.  There should be more documentation about --dns on the main networking help pages for rkt to save people time and pain figuring out why networking does not 'just work'.  Especially with --net=host.
https://coreos.com/rkt/docs/latest/networking/overview.html
Environment
rkt Version: 1.18.0
appc Version: 0.8.8
Go Version: go1.7.3
Go OS/Arch: linux/amd64
Features: -TPM +SDJOURNAL
--
Linux 4.7.3-coreos-r2 x86_64
--
NAME="Container Linux by CoreOS"
ID=coreos
VERSION=1235.6.0
VERSION_ID=1235.6.0
BUILD_ID=2017-01-10-0545
PRETTY_NAME="Container Linux by CoreOS 1235.6.0 (Ladybug)"
ANSI_COLOR="38;5;75"
HOME_URL="https://coreos.com/"
BUG_REPORT_URL="https://github.com/coreos/bugs/issues"
--
systemd 231
+PAM +AUDIT +SELINUX +IMA -APPARMOR +SMACK -SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT -GNUTLS -ACL +XZ -LZ4 +SECCOMP +BLKID -ELFUTILS +KMOD -IDN

What did you do?
rkt run --net=host something
What did you expect to see?
networking works
What did you see instead?
dns resolution failures
dial tcp: lookup somedomain.net on [::1]:53: read udp [::1]:40449->[::1]:53: read: connection refused

/cc @squeed

authors: jeremyd lucab


text:
Configuration on crs-setup.conf does not work

Describe the bug
Configuration in the crs-setup.conf in :
SecAction \
    "id:900100,\
    phase:1,\
    pass,\
    t:none,\
    nolog,\
    tag:'OWASP_CRS',\
    ver:'OWASP_CRS/4.3.0',\
    setvar:tx.critical_anomaly_score=7,\
    setvar:tx.error_anomaly_score=4,\
    setvar:tx.warning_anomaly_score=3,\
    setvar:tx.notice_anomaly_score=2"

SecAction \
    "id:900991,\
    phase:1,\
    pass,\
    t:none,\
    nolog,\
    tag:'OWASP_CRS',\
    setvar:'tx.sql_injection_score=0',\
    setvar:'tx.xss_score=0',\
    setvar:'tx.lfi=7',\
    setvar:'tx.rfi_score=7'"

On desperation I also edit in the REQUEST-901-INITIALIZATION.conf
by modify this :
    "id:901140,\
    phase:1,\
    pass,\
    nolog,\
    tag:'OWASP_CRS',\
    ver:'OWASP_CRS/4.3.0',\
    setvar:'tx.critical_anomaly_score=7'"

Tested using this url
curl 'https://example.com/.bash_'
Log :
ModSecurity: Warning. Matched "Operator PmFromFile' with parameter restricted-files.data' against variable REQUEST_FILENAME' (Value: /.bash_' ) [file "/etc/apache2/modsecurity.d/owasp-crs/rules/REQUEST-930-APPLICATION-ATTACK-LFI.conf"] [line "124"] [id "930130"] [rev ""] [msg "Restricted File Access Attempt"] [data "Matched Data: .bash_ found within REQUEST_FILENAME: /.bash_"] [severity "2"] [ver "OWASP_CRS/4.3.0"] [maturity "0"] [accuracy "0"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-lfi"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/255/153/126"] [tag "PCI/6.5.4"] [hostname "example.com"] [uri "/.bash_"] [unique_id "171893186374.358779"] [ref "o1,6v4,7t:utf8toUnicode,t:urlDecodeUni,t:normalizePathWin"]
Steps to reproduce
Tested using this url
curl 'https://example.com/.bash_'
Expected behaviour
If the rules triggered a CRITICAL it should be blocked.  On that configuration the initial value of threshold is 7, so any CRITICAL rules triggered, it should get blocked.
If the rules are based on RFI or LFI it should get blocked.
should be blocked based on the setting in the crs-setup.conf
Actual behavior
This configuration is not working :
setvar:tx.critical_anomaly_score=7,\ and setvar:'tx.rfi_score=7'"
The crs use no value to accumulative anomaly score to block the request
Your Environment
init.conf file content :
   # Include OWASP ModSecurity CRS rules if installed
   Include "/etc/apache2/modsecurity.d/modsecurity.conf"
   Include /etc/apache2/modsecurity.d/owasp-crs/crs-setup.conf
   Include /etc/apache2/modsecurity.d/owasp-crs/plugins/*-config.conf
   Include /etc/apache2/modsecurity.d/owasp-crs/plugins/*-before.conf
   Include /etc/apache2/modsecurity.d/owasp-crs/rules/*.conf
   Include /etc/apache2/modsecurity.d/owasp-crs/plugins/*-after.conf

CRS version 4.3.0:
Paranoia level setting: df
ModSecurity version 3.0.12:
Web Server and version : Apache - 2.4.41
Operating System and version: Ubuntu 20.04

Hi @navotera. I agree that it looks like the request should have been blocked. We need more information on your setup:

was that the only log entry written for that request?
did you upgrade your setup from CRS <= 3 or is this a fresh installation?
did you modify anything in modsecurity.conf?

Hello @theseion
Thank you for your reply.
Here is the answer for your question :
was that the only log entry written for that request?
That is the only log entry.
did you upgrade your setup from CRS <= 3 or is this a fresh installation?
I remember I have upgrade the CRS before, I have remove all the file and replace with new installation. There is no other config in the crs-setup.conf other than I have written.
I also make sure the mode is using anomaly scoring. :
SecDefaultAction "phase:1,log,auditlog,pass" SecDefaultAction "phase:2,log,auditlog,pass"
did you modify anything in modsecurity.conf?
No modification on modsecurity.conf
Just add SecRuleEngine On

I have another question :
I also try to made another request that trigger 2 CRITICAL :
curl 'https://example.com/?foo=/etc/passwd&bar=/bin/sh'
in the log entry :
ModSecurity: Warning. Matched "Operator `PmFromFile' with parameter `lfi-os-files.data' against variable `ARGS:foo' (Value: `/etc/passwd' ) [file "/etc/apache2/modsecurity.d/owasp-crs/rules/REQUEST-930-APPLICATION-ATTACK-LFI.conf"] [line "97"] [id "930120"] [rev ""] [msg "OS File Access Attempt"] [data "Matched Data: etc/passwd found within ARGS:foo: /etc/passwd"] [severity "2"] [ver "OWASP_CRS/4.3.0"] [maturity "0"] [accuracy "0"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-lfi"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/255/153/126"] [tag "PCI/6.5.4"] [hostname "openjournaltheme.com"] [uri "/"] [unique_id "171895386136.224761"] [ref "o1,10v10,11t:utf8toUnicode,t:urlDecodeUni,t:normalizePathWin"]
ModSecurity: Warning. Matched "Operator `PmFromFile' with parameter `unix-shell.data' against variable `ARGS:bar' (Value: `/bin/sh' ) [file "/etc/apache2/modsecurity.d/owasp-crs/rules/REQUEST-932-APPLICATION-ATTACK-RCE.conf"] [line "556"] [id "932160"] [rev ""] [msg "Remote Command Execution: Unix Shell Code Found"] [data "Matched Data: bin/sh found within ARGS:bar: /bin/sh"] [severity "2"] [ver "OWASP_CRS/4.3.0"] [maturity "0"] [accuracy "0"] [tag "application-multi"] [tag "language-shell"] [tag "platform-unix"] [tag "attack-rce"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/152/248/88"] [tag "PCI/6.5.2"] [hostname "openjournaltheme.com"] [uri "/"] [unique_id "171895386136.224761"] [ref "o1,10v10,11t:cmdLine,t:normalizePatho1,6v26,7t:cmdLine,t:normalizePath"]

Although this request is blocked.
Why this resulted value of anomaly score (severity) for each CRITICAL as 2 (4 as accumulated total). ?
As I know in the doc, the CRITICAL have each 5 (should be total 10).
Thank you for any of guidance.

@navotera As i already told you on stackexchange, your CRS installation is broken. You are probably using crs-setup.conf from some very old CRS version. Reinstall CRS from scratch.

Hello @azurit
What I elaborate in the stack exchange and this is different context. The issue on stack exchange caused by the usage of feature that is taken from the old docs.
Now after digging to the INITiAZION conf i change it to the configuration that is compatible based on the respective version.

Please reinstall it from scratch (delete everything and do clean install) and then send new logs, thanks.

Hi @azurit
I have replace all the folder of crs in my server with the latest release, then I have added this :
`SecAction
"id:900991,
phase:1,
pass,
t:none,
nolog,
tag:'OWASP_CRS',
setvar:'tx.sql_injection_score=0',
setvar:'tx.xss_score=0',
setvar:'tx.lfi_score=7',
setvar:'tx.rfi_score=7'"

This is the log :
ModSecurity: Warning. Matched "Operator `PmFromFile' with parameter `restricted-files.data' against variable `REQUEST_FILENAME' (Value: `/.bash_' ) [file "/etc/apache2/modsecurity.d/owasp-crs/rules/REQUEST-930-APPLICATION-ATTACK-LFI.conf"] [line "124"] [id "930130"] [rev ""] [msg "Restricted File Access Attempt"] [data "Matched Data: .bash_ found within REQUEST_FILENAME: /.bash_"] [severity "2"] [ver "OWASP_CRS/4.3.0"] [maturity "0"] [accuracy "0"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-lfi"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/255/153/126"] [tag "PCI/6.5.4"] [hostname "example.com"] [uri "/.bash_"] [unique_id "171897244335.936775"] [ref "o1,6v4,7t:utf8toUnicode,t:urlDecodeUni,t:normalizePathWin"]

Still not blocking based on the modified of default lfi_score threshold

I have replace all the folder of crs in my server with the latest release, then I have added this :

Why are you doing this? You are breaking your CRS installation with things like this. Stop touching internal CRS variables, these are not intended to be modified by a user. Modify only variables inside crs-setup.conf.
Have you replaced also crs-setup.conf? You need to delete your old one (which is broken) and install original one.
You have to do a clean install without breaking it again.

I think you got it wrong.
I not configure anything inside rules folder.
I doing this in crs-setup.conf

You cannot do it.

Do NOT add any new rules into crs-config.conf, only modify or uncomment existing ones.

See in the conf-setup.example on line 266 - 277, configure the initiation of critical_anomaly_score is available to be modified in the crs-setup.conf.
You need to understand, because this line does not work, I have try another approach by increasing lfi_score and both does not work.

There is no such rule with id 900991 in crs-setup.conf.

@navotera Look, you are doing things wrong and i told you it multiple times. Either start following my advices or we cannot help you.

I have added this in crs-setup.conf :
SecAction \
    "id:900991,\
    phase:1,\
    pass,\
    t:none,\
    nolog,\
    tag:'OWASP_CRS',\
    setvar:'tx.sql_injection_score=0',\
    setvar:'tx.xss_score=0',\
    setvar:'tx.lfi_score=7',\
    setvar:'tx.rfi_score=7'"

This, rule doesn't exists in crs-setup and you have added it.

So delete your crs-setup.conf, download a new one and DO NOT add any new rules into it, only uncomment (whole, not only partially) existing rules and modify values in them. That is all you are supposed to do inside crs-setup.conf.

Hello @azurit
You need to read my report in a little slow. I am doing two mechanisme or approach.
First : adding inititation of critical anomaly score to 7 as available in crs-setup.conf
Second : because the first step does not work, I doing another approach by adding it or overwrite in crs-setup.conf first to test the lfi_score initiate score.
Both of this approach does not work.

Sorry, i cannot help you.

Sorry @navotera, let's start back again.
Can you explain here what are you trying to do? Not HOW. Just the what.

Hello @fzipi
In the first post.
I try to add initiation score for critical by adding this in crs-setup.conf :
setvar:tx.critical_anomaly_score=7
Testing it with :
curl 'https://example.com/.bash_'
because it will trigger the rules : 930130 which is severity : CRITICAL and it should get blocked because it have 14 score of anomaly.
But it does not work. The request does not get blocked

Just so you have more context: any lfi attack is catalogued as critical. E.g. setvar:'tx.lfi_score=+%{tx.critical_anomaly_score}'". So you don't need to add or change anything for this to work.
In my case, your example triggers as expected:

I only get one error log in the audit log (see above).
I also use the modsecurity 3 (latest)

I'm tracking this internally already. But please confirm: are you using nginx? Which version? Plus the connector version.
Thanks!

@navotera You could set SecDebugLog to some file and SecDebugLogLevel to 9. Then send us the output for that single request. That will tell us exactly what's happening.

After reinstall ModSecurity and ApacheConnector observe the additional secRules. We found out that there is a additional custom rule that caused this issue to emerge.
Sorry for the false positive bug.

After reinstall ModSecurity and ApacheConnector

Please note that the Apache connector for libmodsecurity3 is still not production ready. I suggest you NOT to use it.

Thank you for your valuable feedback @airween

@navotera Thanks for letting us know. Please note that i was telling you from the beginning that your installation is broken somehow and needs to be created from scratch (without custom modifications).

authors: airween azurit fzipi navotera theseion

repo: coreruleset/coreruleset


text:
Adds common and uniform http headers to tests

This is a heavy to review patch. Fixes #2344

I've tried to split commits one per directory, so they can be reviewed independently.
There are lots of formatting changes, but I think they will be good afterwards.

There were some failed test, so I have collected the reasons.
The list of the errors:
https://github.com/coreruleset/coreruleset/runs/4929701146?check_suite_focus=true#step:4:2837
The cases:
913100
I'm not sure we can change the User-Agent header, because that's the meaning of the rule, eg:
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-70624f5dbe4122947942480691f9b72512dd30dabd9166dc05e0db5ec5e72800R22
but the original was:
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-70624f5dbe4122947942480691f9b72512dd30dabd9166dc05e0db5ec5e72800L24-L25
List of patterns of User-Agent here:
https://github.com/coreruleset/coreruleset/blob/v3.4/dev/rules/scanners-user-agents.data#L86
913101
same issue, the new one wants to "attack" with "ModSecurity CRS 3 Tests"
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-2922dcf98b8f8dee3d675929e442f95d33b2d0e63ed71adda8628ea7ba72b59bR17
the old one:
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-2922dcf98b8f8dee3d675929e442f95d33b2d0e63ed71adda8628ea7ba72b59bL19
920280
rule triggered if Host header is missing. The new test contains the Host header, therefore the test will failed
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-c96cb52bca62ee17f2b134623c8a56f1eac4b54224d21417f335c9b6b78f7241R17
920290
similar, but rule checks that Host is empty or not. The new test contains a non-empty header:
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-e49afdd6a642183ac7dc12d3abba290e9ebe8b13124dfa30fe77715ae5963500R19
920300
rule triggered if Accept header is missing, but the new test contains it:
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-ee6875766a99f60dfa20e64b019683b48975cc4b8988c97ea49fb77aeaae7696R22
920310
rule checks that Accept is missing or not; the new test contains it:
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-01122e22d5867c9262e294bc166a3f0ce84b9882b612ebf28d581a62579b1c65R16
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-01122e22d5867c9262e294bc166a3f0ce84b9882b612ebf28d581a62579b1c65R53
920311
rule is sibling of 920310, but test contains the header:
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-f763e4c512d9f5a8c6ac46811fb2d76053ed9fd54fdc542b3045d9a26a24b96eR16
920320
rule checks that User-Agent is missing, but new test contains it:
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-9e2096d0b529994db5084342b0caa92508c6e65e3db07a50770d38487ab7bdb9R16
920330
rule checks that User-Agent is empty, but new test contains a non-empty value:
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-7c30048b0bf1a8c7f564f3bc2f5ebde0b7871fcd04938571176a2703721da84dR15
920350
this rule checks Host header contins an IP address or not, we can't change that header for positive checks:
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-96990e7711d7b6a503e66afefac09b8d60cd308a10ea20c45954ee8ca9413356R17
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-96990e7711d7b6a503e66afefac09b8d60cd308a10ea20c45954ee8ca9413356R47
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-96990e7711d7b6a503e66afefac09b8d60cd308a10ea20c45954ee8ca9413356R62
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-96990e7711d7b6a503e66afefac09b8d60cd308a10ea20c45954ee8ca9413356R77
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-96990e7711d7b6a503e66afefac09b8d60cd308a10ea20c45954ee8ca9413356R92
920490
rule checks x-up-devcap-post-charset; if it exists, then checks the User-Agent, which has to contains string 'up'. The new one doesn't contains.
the old one:
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-e46cb93e7c78522861930602c6c6e6f5b67c7fc835bd805847e667479081cd93L46
the new:
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-e46cb93e7c78522861930602c6c6e6f5b67c7fc835bd805847e667479081cd93R16
931130
this rules checks the arguments with an URI-like schema; if it matches, checks compares the Host header with a transaction variable, so I think we can't change it
the old tests:
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-baf121d9cfd54321b35a246c96295de823021919a0892fa144e01ea95026a657L154
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-baf121d9cfd54321b35a246c96295de823021919a0892fa144e01ea95026a657L188
the new ones:
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-baf121d9cfd54321b35a246c96295de823021919a0892fa144e01ea95026a657R144
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-baf121d9cfd54321b35a246c96295de823021919a0892fa144e01ea95026a657R176
941100
this is an XSS rule, some part of the request must have contains the attack
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-e27ff48fe39e5d0486a366f191daac5352729810270ee84ef44e6024df474e11L52
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-e27ff48fe39e5d0486a366f191daac5352729810270ee84ef44e6024df474e11R48
941110
same as 941100
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-481b31a2307b10c6a65c37181b76163eab6cc559b6e1195d13129611dfa48a31L53
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-481b31a2307b10c6a65c37181b76163eab6cc559b6e1195d13129611dfa48a31R49
941160-8
this is a "NoScript InjectionChecker" rule, the affected header is the User-Agent - we can't change the old one:
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-fdbcc26676eab1de35a89bc6a3e0e930bdbf6c976396570d61c883543b095f48L132
https://github.com/coreruleset/coreruleset/pull/2362/files#diff-fdbcc26676eab1de35a89bc6a3e0e930bdbf6c976396570d61c883543b095f48R123
If you need any other help, just let me know.
Btw: why do we want to use ModSecurity CRS 3 Tests as User-Agent? Would be enough that just CRS 3 Tests?

I second the CRS tests user agent change, but also, will it depend on major version? E.g. when CRS 4.x is out, are we changing that?

I second the CRS tests user agent change, but also, will it depend on major version? E.g. when CRS 4.x is out, are we changing that?

Hmmm... good question.
A crazy idea, but can we detach the test set from the rule set? I mean now you've started to add/modify the headers for the better consistency, so we can say this is a new version of our test set.
May be we can use some new format, like:
CRS Test v1.1, for version 3.4.0-dev
And if we release the 4.0, the we replace the version at the end.

All tests passing now.

I'd hate to do separate versioning for the tests. This is making things so complicated. In fact I do not think we need any version in the test UA. Tests are always run in a controlled environment so when something needs debugging you can easily find out the test that triggered. Having the test-ID submitted as part of the test would be more interested (unless we have that already :)
What I would suggest, though, would be to add the CRS test suite user agent string to any existing attacking test string we have already. Thus libwww-perl; OWASP ModSecurity Core Rule Set Test.

I've reviewed the modified tests, and most of them are done.
There you have all the converted tests and no new tests.
These issues are what I've found:
920171-1

this test contains an encoded_request in base64 format, which includes the necessary headers. I think we should left the headers from here and change those values in the base64 encoded string.

920171-2

this test contains an encoded_request in base64 format, which includes the necessary headers. I think we should left the headers from here and change those values in the base64 encoded string.

920171-3

this test contains an encoded_request in base64 format, which includes the necessary headers. I think we should left the headers from here and change those values in the base64 encoded string.

920300-1

wrong comment, the correct should be "test needs a missing 'Accept' header"

920300-2

wrong comment, the correct should be "test needs a missing 'Accept' header"

920300-3

wrong comment, the correct should be "test needs a missing 'Accept' header"

920300-4

'User-Agent' not uniform, should be "ModSecurity CRS 3 Tests AppleWebKit/537.36"
wrong comment, the correct should be "test needs a missing 'Accept' header"

920310-5

'User-Agent' not uniform, should be "ModSecurity CRS 3 Tests Business/6.6.1.2"

920310-6

'User-Agent' not uniform, should be "ModSecurity CRS 3 Tests Entreprise/6.5.0.177"

944200-1

this test contains an encoded_request in base64 format, which includes the necessary headers in right form. I think we can remove the necessary headers from here.

Thanks @airween for the thorough review!
Included all your comments. This should be ready now.... unless you want to change all user agents to OWASP ModSecurity Core Rule Set Test and that is a PITN.

Included all your comments.

great, thanks!

This should be ready now.... unless you want to change all user agents to OWASP ModSecurity Core Rule Set Test and that is a PITN.

I don't know, what would be the best solution - I wrote my suggestions above based on @dune73 's comment:
What I would suggest, though, would be to add the CRS test suite user agent string to any existing attacking test string we have already. Thus libwww-perl; OWASP ModSecurity Core Rule Set Test.
More thoughts about tests: I think it would be good to extend the list of skeleton tests, eg. add skeleton for encoding_request. Also we should fix these uniform headers in those skeletons. A small documentation also is missing now.
(I can add these after the merge, if you want to apply this patch.)
Ideas?

To be honest, I think this is massive and don't want to hold it too much. Drift is happening on every merge, and I was careful to create commits separated, so it is a pain to update.
@dune73 @airween I would do this:

merge this one.
if we want to change the user agent (which I think makes sense), let's go for a new issue and PR
new issue and PR for the skeleton tests

LGTM!

Agreed on the plan.
And thank you for this huge PR @fzipi and the timely review @airween.

authors: airween dune73 fzipi


text:
Set real ip for nginx

The apache container has a config to set the trusted proxy address.
However, for nginx I didn't found an equivalent for it.
See https://nginx.org/en/docs/http/ngx_http_realip_module.html for details.

Is the default client coming from localhost? Or from a docker network internal ip? (didn't verified this)

If the file needs to be pre-processed, we need to add it to the list in the docker-entrypoint.sh.
The PR #105 is supposed to help with this by moving files to templates that generate the actual config files.

Ah, I missed that one. On my local installation I added it directly to the default.conf and saw just in the repo that it included the proxy file and moved it quickly...
On my installation the default IP was the one from the Docker host (172.17.0.1).

@theMiddleBlue Can you review this one?

@theMiddleBlue Can you review this one?

LGTM, can we just rename the ENV variable with something similar to the config directive set_real_ip_from instead of trusted_proxy? Also, what if I need to set IPv4 and IPv6 classes? Is there a way to add multiple set_real_ip_from directives and add a real_ip_recursive on;?

@LotusAxt Can you make those changes? Something is failing in alpine build also...

@LotusAxt Are you up to solving conflicts and taking on comments?

Sorry, messed this up. Will open a new PR.

authors: LotusAxt fzipi theMiddleBlue theseion

repo: coreruleset/modsecurity-docker


text:
Upgraded versions to Scala 2.12

I want to make a tutorial with Scala 2.12. Is there any chance you merge and publish this version?

Yea sounds good :)

io.surfkit
scalajs-google-maps_sjs0.6_2.12
0.0.3-SNAPSHOT

repo: coreyauger/scalajs-google-maps


text:
Pop Arrow disappears when table view pop over drawn below its button

I want table view pop over below its button but when I make it down arrow disappears
Here is my code:-
  let startPoint = CGPoint(x: self.view.frame.width - 60, y: self.rightButtomButton.frame.origin.y + self.rightButtomButton.frame.size.height)

    let tableView = UITableView(frame: CGRect(x: 0, y: 0, width: self.view.frame.width, height: 135))
    tableView.delegate = self
    tableView.dataSource = self
    tableView.isScrollEnabled = false
    let popover1 = Popover(options: nil, showHandler: nil, dismissHandler: nil)

    popover1.show(tableView, point: startPoint)

Here is screen shot:-

Why I am not able to get arrow in case of table view ? If delegate & datasource not given then arrow will appear.
Please guide me.
Thanks,
Zalak

Have u found any solution to this ?

yes i have this issue too, so fall bak to version 1.0.4

+1

To fix it on this version, create one UIView and add items programmatically . Don't use tableview

It is displayed in the demo project, but where is the difference?

Try to set the arrow size with the options
popover = Popover(
                    options: [
                        .type(PopoverType.down),
                        PopoverOption.blackOverlayColor(UIColor.black.withAlphaComponent(0.7)),
                        PopoverOption.sideEdge(8),
                        PopoverOption.arrowSize(CGSize(width: 12, height: 6))], //here
                    showHandler: nil, dismissHandler: nil)

you just need to clear background of view actually

I discovered that commenting out Popover.layoutSubviews() fixes this problem. I don't if that breaks other use cases, however.
The change offered by salvasp above doesn't work for me.

I have same too.

I have the same issue, I'm using swift 4

Any luck so far with latest version?

try to use Mask replay Fill

authors: CoderFenchHU Maxatma ZalakSA alexsteinerde chetan-duke corin8823 incidiuz kramsretep ktinguer l12ab nandankd salvasp


text:
how can i get the files in the corresponding  params folders on the neural networks

i read the file in the params folder ,i am not understand why it is the 27 files? The first arr_0, i think it is the first conv layer weight params and the arr_3 is the sencond conv layer weight params ,but the arr_1,arr_2 what does it correspond ? Can you answer my confusion ? Otherwise, how can i get the 27 files in the neural networks ?

@rzhao01
thanks for your help.
I tried a new cifar100 dataset on the board, and I first replaced the test dataset section in the data folder and then looked at the results of the run,  identifying a high error rate. Then I extracted a new training parameter from the training network, replaced the zip file in the params folder,  and the results showed that the error rate was reduced, but the accuracy of the recognition was still different from the training.
Now is the data folder cpp_ * These nine documents on the final operating results have an impact? These nine documents were expressed conv and dense layer of output data, or input data?  Now I want to ask you how i can replace these files, and I hope you can give some hints.
thank you.

The only files in the data folder which matter to the classification is cifar10_test_inputs.zip and cifar10_test_lables.zip. The other files are intermediate layer data which is used for the per-layer testbenches.
Due to quantization and etc, there will be some accuracy differences between software (Python) and FPGA. But without details I can't say much more.

@rzhao01
ok, thank you so much

Hello,
As you said before, in Courbariaux's code each layer has weights, biases, and 4 batch norm parameters.  So could you please give some hints about how can I calculate k and h from the 4 batch norm parameters?
Really appreciate.

The calculation is Equation 4 in our paper.

repo: cornell-zhang/bnn-fpga


text:
[Unit test] Several external links are not mocked during unit test

Avoid duplicates

[x] Bug is not mentioned in the FAQ
[x] Bug is specific for iOS only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[x] Bug is not already reported in another issue

Technical details

Device name: Xcode simulator / iPhone 8
iOS version: Xcode simulator / iOS 15
App version: current latest under development / branch release/2.15.x

Describe the bug

In the unit tests for UITesting, the external links are usually mocked. They don't open the given URL, but show a message box instead. The reason for this mock is to reduce external dependencies, especially to the network infrastructure, and to make the unit tests more robust.
However, during analysis of #2179 I found several links that are not mocked in the unit test.
To be more precise, I found the following:

informations in easy language and sign language from App information / About the app - AppStrings.AppInformation.aboutLink
contact form on the Imprint page - AppStrings.AppInformation.imprintSectionContactFormLink
link to the Blog from info page for statistics tiles - AppStrings.Links.statisticsInfoBlog
FAQ from notification settings (only with active notifications) - AppStrings.Links.notificationSettingsFAQ
FAQ from info page for the QR code of a vaccination certificate - AppStrings.CovPass.Information.faqLink
two links from health certificate, scroll down to the bottom - "https://reopen.europa.eu/de" and "https://reopen.europa.eu/en"
another two links from certificate validation info page - AppStrings.Links.healthCertificateValidationFAQ and AppStrings.Links.healthCertificateValidationEU
FAQ for booster vaccination - AppStrings.Links.healthCertificateBoosterFAQ

Steps to reproduce the issue

Use one of the two tricks at #3804 to execute cwa on the simulator in unit test mode (with mocks active).
open one of the given pages
click on the given link
Expected: network access is mocked, the URL is shown on a message
Observed: the URL opens

Expected behaviour
During unit testing, the links should be mocked. This will increase robustness of the unit tests

Possible Fix

Additional context

I am volunteering to submit a PR with a fix.

@dsarkar I have prepared PR #3877 with a fix - please apply the labels.
Thanks!

The PR was expected and is already merged.
Closing as fixed.

repo: corona-warn-app/cwa-app-ios


text:
Please merge the 2.29.0 & 3.0.0 milestone

[X] None of the other issue templates apply to this issue.

Could you please merge the 2.29.0 & 3.0.0 milestone? This would be easiest by just renaming the 2.29.0 one and deleting the 3.0.0. All PRs earlier assigned to the 3.0.0 milestone, which you delete, should then be assigned to the renamed 2.29.0 one.

@naveeddotio Would you do that, please?

Reminder that this is still a problem. @brianebeling maybe it makes sense to create a JIRA ticket for this?

@Ein-Tim
Thanks for opening this issue. I have merged all issues from the 2.29.0 milestone into the 3.0.0 milestone. In addition to that, I deleted the 2.29.0 as it is not needed anymore.

authors: Ein-Tim larswmh


text:
Decide for either CRLF or LF line endings and add .gitattributes file

Current Implementation

Because this repo doesn't contain a .gitattributes file, line endings differ from contributor to contributor causing unwanted diffs in checkins.
Suggested Enhancement

Add .gitattributes file to this repo and decide wether you prefer Windows-style CRLF or Unix-style LF line endings.
See https://help.github.com/en/github/using-git/configuring-git-to-handle-line-endings how to do this.
I suggest to add the follwing lines to .gitattributes:
*.java text eol=lf
*.yml text eol=lf

Expected Benefits

Fewer diffs when contributing a pull request and easier to read history.

Normally this problem should not arise if everyone uses editorconfig correctly.

I think git decides at commit time if and how to convert.
It's not depending in your IDE.

authors: dfischer-tech martinmuellerrohde

repo: corona-warn-app/cwa-verification-server


text:
Added specific element attribute in FAQ page

In this PR, I added data-e2e attribute as mentioned in README.md as a best practice for FAQ page.

@UzaeirAzhar
You are right that there is a best-practice recommendation, however we are in the ramp-down phase of this project and the best practice recommendation is more about ensuring the long-term maintainability of Cypress tests. In practice this recommendation has not been followed in the past. The test cypress/e2e/app_to_web.cy.js is already working correctly and satisfactorily. It seems like your change only affects one of the tests, so to be consistent all of the other tests would need to be changed.
Considering that the test works correctly without this PR I would suggest not to use this PR, unless there is some advantage which I have not understood.
(For future PRs you should always branch off the master branch when you create changes to submit as a PR (see https://github.com/corona-warn-app/cwa-website/blob/master/CONTRIBUTING.md#pull-request-checklist). Also it is quite helpful to first open an issue, if you have a bug or an idea for an enhancement, to check whether the team agrees with any proposed changes.)

@MikeMcC399  Thanks for your comment. I understood your point. I'm closing this PR and will keep in mind points you mentioned above.

@UzaeirAzhar
Thank you for understanding my feedback! I am working on restructuring the testing documentation and I will probably take out that particular best practices recommendation and replace it instead with a link to Cypress' Best practices documentation to make it more general.

repo: corona-warn-app/cwa-website


text:
[Bug]: toxic proc-macro2 version

Description
Hi folks,
As you may or may not be aware, there was recently a push to prod made by the Rust dev team (see https://github.com/rust-lang/rust/issues/113152) that depreciated several nightly APIs.
Furthermore, proc-macro2 actually depended on one of these APIs.
This was all very promptly addressed and fixed in proc-macro2 versions >=1.0.60 (see https://github.com/dtolnay/proc-macro2/pull/391 )
Attempting to consume corrosion with rust nightly toolchain >=nightly-2023-06-28 will result in an breaking error something like the following:
error[E0635]: unknown feature `proc_macro_span_shrink`
  --> /home/gutenfries/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.52/src/lib.rs:92:30
   |
92 |     feature(proc_macro_span, proc_macro_span_shrink)
   |                              ^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0635`.
error: could not compile `proc-macro2` (lib) due to previous error
error: failed to compile `corrosion-generator v0.1.0 (/home/gutenfries/Desktop/mille/build/linux/x64/release/_deps/corrosion-src/generator)`, intermediate artifacts can be found at `/home/gutenfries/Desktop/mille/build/linux/x64/release/_deps/corrosion-src/generator/target`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.
CMake Error at /home/gutenfries/Desktop/mille/build/linux/x64/release/_deps/corrosion-src/cmake/Corrosion.cmake:594 (message):
  Building CMake Generator for Corrosion - failed
Call Stack (most recent call first):
  /home/gutenfries/Desktop/mille/build/linux/x64/release/_deps/corrosion-src/CMakeLists.txt:73 (include)

Additional Context
My CMake call looks like this: (Note that this is NOT the issue)
# We include Corrosion inline here, but ideally in a project with many
# dependencies we would need to install Corrosion on the system. See
# instructions on https://github.com/AndrewGaspar/corrosion#cmake-install Once
# done, uncomment this line: find_package(Corrosion REQUIRED)

include(FetchContent)

FetchContent_Declare(
  Corrosion
  GIT_REPOSITORY https://github.com/AndrewGaspar/corrosion.git
  GIT_TAG origin/master # Optionally specify a version tag or branch here
)

FetchContent_MakeAvailable(Corrosion)

corrosion_import_crate(MANIFEST_PATH ../native/Cargo.toml)

# Flutter-specific

set(CRATE_NAME "native")

target_link_libraries(${BINARY_NAME} PRIVATE ${CRATE_NAME})

list(APPEND PLUGIN_BUNDLED_LIBRARIES $<TARGET_FILE:${CRATE_NAME}-shared>)

Environment

tool
version

OS
Like Ubuntu 20.04

CMake
3.16.3

clang++
10.0.0-4ubuntu1

Expected Behavior
Not to throw a compile error :smile:
Steps To Reproduce
Consume Corrorsion in any environment using rust toolchain nightly-2023-06-28 or higher
Proposed fix(es)
the issue has  been resolved within proc-macro2, and versions >=1.0.60 appropriately address this.
simply bumping this ASAP should be adequate to address this.
I will open a PR in a minute with the changes.

Will this affect stable starting with Rust 1.72? This is a bit unfortunate, since bumping proc macro2 also means bumping the minimum supported Rust version for the generator.

Will this affect stable starting with Rust 1.72?

No. From my understanding this only affects nightly rust. (proc_maro2 has a build script that detects nightly)

My apologies on not making it clear, this is ONLY for the nightly toolchain.

[...] since bumping proc macro2 also means bumping the minimum supported Rust version for the generator.

It is unfortunate, should this move the (nightly) MSRV up, however, from my perspective, the choices are to either let the MSRV go up marginally, or have to enforce a maximum supported nightly version.

Will this affect stable starting with Rust 1.72?

No. From my understanding this only affects nightly rust. (proc_maro2 has a build script that detects nightly)

This is correct.

I run into this error, but im not sure how to figure out the offending crate
cargo tree | grep proc-macro2 shows all dependencies seem to be using v1.0.66.
│   │   ├── proc-macro2 v1.0.66
│   │   │   └── proc-macro2 v1.0.66 (*)
│   │       ├── proc-macro2 v1.0.66 (*)
│           ├── proc-macro2 v1.0.66 (*)
│               ├── proc-macro2 v1.0.66 (*)
│   │       ├── proc-macro2 v1.0.66 (*)
    │   ├── proc-macro2 v1.0.66 (*)
│               ├── proc-macro2 v1.0.66 (*)
│               │   ├── proc-macro2 v1.0.66 (*)
│       ├── proc-macro2 v1.0.66 (*)

But my build error shows
```error[E0635]: unknown feature proc_macro_span_shrink
--> /home/thomas/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.58/src/lib.rs:92:30
|
92 |     feature(proc_macro_span, proc_macro_span_shrink)

I saw this before and `cargo update` seemed to make the problem go away but that does not seem to work here

It is unfortunate, should this move the (nightly) MSRV up,

I don't really care about a nightly MSRV, but updating the lockfile means dropping support for anything before stable Rust 1.56, since the newer version of proc macro2 is Rust 2021 edition.
I added a workaround in #430 to avoid this by shipping two lockfiles with corrosion and selecting the correct one based on the Rust version, thus preserving compatibility with old stable versions and fixing the build with nightly Rust.

Idea: corrosion could detect nightly rust and run cargo update in that case. (Possibly with -p proc_macro2)
But maybe that's overkill.
(Personally I'd be fine raising the msrv to 1.56)

This should be fixed by #430 @gutenfries could you verify if current master works for you?

FetchContent_Declare(
 Corrosion
 GIT_REPOSITORY https://github.com/AndrewGaspar/corrosion.git
 GIT_TAG origin/master # Optionally specify a version tag or branch here
)

FYI, you should probably change master here to the stable/v0.4. branch or the v0.4 tag.
As announced in the release notes for v0.4, this the last corrosion version supporting older CMake versions and support for the versions will be removed from master in the next weeks or months.

authors: TomzBench gutenfries jschwe ogoffart

repo: corrosion-rs/corrosion


text:
[Snyk] Upgrade material-table from 1.69.3 to 2.0.3

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade material-table from 1.69.3 to 2.0.3.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

Warning: This is a major version upgrade, and may be a breaking change.

The recommended version is 4 versions ahead of your current version.
The recommended version was released a year ago, on 2022-03-12.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Do we know what this major version actually entails? I don't even see this version on their GitHub...

authors: FoodProduct nikhilunni

repo: cortexapps/backstage-plugin


text:
Cannot read property 'crash' of undefined - on android

I got this for android using;
react-native-cli: 1.3.0
react-native: 0.38.0
and
"react-native-fabric": "^0.3.2"  in package.json

Followed this resource, but still the same error
I imported the class in both ways as;
import Fabric, {Crashlytics} from 'react-native-fabric';
and secondly as
var Fabric = require('react-native-fabric');
var {Crashlytics} = Fabric;
In both cases, it gave the same error.  :(
trace from VS Code debugger:
Cannot read property 'crash' of undefined
Cannot read property 'crash' of undefined
Module AppRegistry is not a registered callable module (calling runApplication)
Unable to symbolicate stack trace: The stack is null
Unable to symbolicate stack trace: The stack is null

Any one came up with the solution to this, buddies !

This looks like you havent properly set up the Fabric Android SDK

@corymsmith
I have followed the steps as described for Android Without Android Studio from here https://github.com/corymsmith/react-native-fabric
The included libraries (in MainApplication.java) are as under;
import com.smixx.fabric.FabricPackage;
import com.crashlytics.android.Crashlytics;
import io.fabric.sdk.android.Fabric;

I came across the following errors
First error (in VS-Code debugger): error: package com.smixx.fabric does not exist
Second error (in VS-Code debugger): error: cannot find symbol new FabricPackage()
Third error (on emulator, after build): Cannot read property 'crash' of undefined
The 'First error disappears when i remove this reference import com.smixx.fabric.FabricPackage;.
The 'Second error' disappears when i remove this call new FabricPackage().
After removing the above errors (i know that's not the solution 👎 ),, the code is built successfully and a new error appears on the emulator, i-e Cannot read property 'crash' of undefined
My guesses: A reference to the SDK file or (its CDN url) is missing
Any clue for this issue ?

The error says
undefined is not an object (evaluating 'SMXCrashlytics.crash')

<unknown>
Crashlytics.js:11

which refers to
module.exports = {

  crash: SMXCrashlytics.crash, // this line

so i guess, problem with the SDK configuration

I think i have the same error. The app crashed on Android and won't load. On iOS everything works fine.  01-13 17:18:01.920  5610  5641 E ReactNativeJS: undefined is not an object (evaluating 's.crash') 01-13 17:18:01.932  5610  5641 E ReactNativeJS: Module AppRegistry is not a registered callable module (calling runApplication) 01-13 17:18:02.043  5610  5641 E ReactNativeJS: Module AppRegistry is not a registered callable module (calling unmountApplicationComponentAtRootTag)

@vdlindenmark This means you don't have the native module registered correctly for Android.

That's right @corymsmith
I figured out that while using the react-native-navigation library, the iOS version works perfect, but for android, we change MainApplication.java class to extend to NavigationApplication which creates a problem for react-native-fabric
This is how is got it working with react-native-navigation
public class MainApplication extends NavigationApplication {

    @Override
    public boolean isDebug() {
        // Make sure you are using BuildConfig from your own application
        return BuildConfig.DEBUG;
    }

    @Override
    public List<ReactPackage> createAdditionalReactPackages() {
        // Add the packages you require here.
        // No need to add RnnPackage and MainReactPackage
        return Arrays.<ReactPackage>asList(
                new FabricPackage(),
                new VectorIconsPackage(),
                new LinearGradientPackage(),
                new CodePush(getResources().getString(R.string.reactNativeCodePush_androidDeploymentKey), getApplicationContext(), BuildConfig.DEBUG)
        );
    }

    private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) {

        @Override
        protected String getJSBundleFile() {
            return CodePush.getJSBundleFile();
        }

        @Override
        protected boolean getUseDeveloperSupport() {
            return BuildConfig.DEBUG;
        }

        @Override
        protected List<ReactPackage> getPackages() {
            return Arrays.<ReactPackage>asList(
                    new MainReactPackage()
            );
        }
    };

    @Override
    public ReactNativeHost getReactNativeHost() {
        return mReactNativeHost;
    }

    @Override
    public void onCreate() {
        super.onCreate();
        Fabric.with(this, new Crashlytics());
        SoLoader.init(this, /* native exopackage */ false);
    }
}

Hope this helps!

@corymsmith can you tell me how i can fix this?
I used rnpm to install and crashlytics works great, also checked the manual installation and everything was good. BUT. When i use Answers, Android don't work...

At this moment i figured out that when i don't import react-native-fabric like this:
var Fabric = require('react-native-fabric');
var { Crashlytics, Answers } = Fabric;

With or without that, on iOS everything works fine. Without that it works also fine for Android, bit with that, i get that error... :-(

@s2zaman Did you ever resolve this?

@vdlindenmark Can you clarify what the problem is? Maybe post some code that works and then code that doesn't work? From what you're saying it seems like its not configured properly on Android...

Hi. I get the same error for ios.
undefined is not an object (evaluating 'SMXCrashlytics.crash')

<unknown>
Crashlytics.js:11

It only occurs, when running on a simulator. When I build the app in Xcode and run there (on hardware or simulator) it works.
Any Ideas?
package.json (excerpt):

  },
  "dependencies": {
    "native-base": "0.5.13",
    "react": "~15.3.1",
    "react-native": "0.37.0",
    "react-native-fabric": "0.3.2",
    "react-native-router-flux": "3.37.0",
    "react-native-vector-icons": "^3.0.0",
    "whatwg-fetch": "^1.0.0"
  },

@wunderkind2k1 did you try to reset your simulator? ("iOS Simulator" -> "Reset Content and Settings...")
@corymsmith at this moment, for me it's fixed now.

@wunderkind2k1 How did you install the Fabric SDK?

Hi. First I tried the 'react-native install' automatic way which didn't work. After that I started from scratch with the installation via fabric app. That way it works but only on xcode.

@wunderkind2k1 Regardless of whether you do react-native install you should install the Fabric SDK either via their app or from CocoaPods. The install process only links this library, you still have to have Crashlytics set up in your XCode project.

I did the installation via their app. To say it exactly: I can see the events and logs in the fabric dashboard. But only when running on device or from XCode.

.. by the way: resetting the simulator didn't help either. Bummer. But I just want to say that I really appreciate your help and the work you put into this project.

@wunderkind2k1 Sometimes there can be a delay for events showing up in the dashboard, I've noticed that sometimes backgrounding the app will cause events to be flushed from the queue. I believe that in DEBUG mode they may not send some / all events, can't quite recall exactly

Its true. The events do have a delay when the app is running. But the problem is of course the app crash in the simulator.

Hi. We found a solution today!
We had the build scheme in XCode set to Release (for deployment). This setting didn't fit well with fabric when run with react-native build tools on the simulator.
Since we switched back to the react-native default "debug" - everything works fine with the react-native and the XCode Build-Tools.
So for iOS be sure to: open your project in Xcode and select Product → Scheme → Edit Scheme... (or press ⌘ + <). Next, select Run from the menu on the left and change the Build Configuration to Debug.

Closing this issue, as the current topic is more related to this new issue

@corymsmith !
yupp, i solved it by following the official docs again from the start.
And secondly, from an article, i read about it that this Crash somehow encounters only when we are in Debugging mode on emulator. But once all configured, and installed on a device or emulator, it works okay 👍 !

Android - Faced same issue. Turns out I missed out on linking the library as it is not specifically mentioned anywhere on the npm page.
Executed react-native link and that solved the problem for me. Hope this helps somebody.

repo: corymsmith/react-native-fabric


text:
Is there a complete installation tutorial for MAC?

Is there a complete installation tutorial for MAC?
The commands in README file don't work, I believe it's for Linux and I only found the link for Windows.
And to install on an online server, which one do you recommend?

No, there is not. You can use one of AI tools to get help on that.
And to install on an online server, which one do you recommend?
* I don't have any recommendation. You should do your own research.

authors: coskundeniz kyhos

repo: coskundeniz/google-ad-clicker-premium


text:
E2E: Investigate Running a whole test suite per host

Summary
Investigate running a whole test suite on a single GH runner to check performance vs running a single test per host.
ref #3329

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

I think a situation in which we run each over a separate channel, but all one one host could reduce runner usage drastically. As long as we are still able to run individual tests locally this could be a win-win

repo: cosmos/ibc-go


text:
Update peggy setup instructions

This setup doc refers to a peggy:all target that no longer exists.
Would the following be a good replacement?
yarn migrate
yarn peggy:setup
yarn token:mint
yarn token:approve

Ah nevermind. I was running yarn from testnet-contracts instead of root.

repo: cosmos/peggy


text:
Figure out why applying same fix of #389 to push replicator breaks few unit test cases.

Push replicator might require same fix.
Unit Test might be based on in-correct replicator behavior.

PusherInternal.waitForPendingFutures () method immediately exists from method if waitingForPendingFutures  is true, which means waitForPendingFutures() is running. See following link:
https://github.com/couchbase/couchbase-lite-java-core/blob/a7328ec061983f129b6e77bb2ab2f2afc9771b6f/src/main/java/com/couchbase/lite/replicator/PusherInternal.java#L120-L123
By calling fireTrigger(ReplicationTrigger.WAITING_FOR_CHANGES); after waitForPendingFutures(); in  public void changed(EventType type, Object o, BlockingQueue queue) callback, it causes to send IDLE state too early if changed() received more than two times.
This is why fix for #389 can not applicable to push replicator.
Instead, push replicator calls fireTrigger(ReplicationTrigger.WAITING_FOR_CHANGES); at end of waitForPendingFutures() method.
https://github.com/couchbase/couchbase-lite-java-core/blob/a7328ec061983f129b6e77bb2ab2f2afc9771b6f/src/main/java/com/couchbase/lite/replicator/PusherInternal.java#L168
No Issues. But there are inconsistency between push replicator and pull replicator.

repo: couchbase/couchbase-lite-java-core


text:
Made multi operations 'options' parameter optional

As stated in the documentation the 'options' parameter of 'Multi' operations should be optional.
This branch makes it so.
Feedback and criticism would be greatly appreciated.
Documentation mentioned:
http://www.couchbase.com/autodocs/couchbase-node-client-0.1.0/index.html

Closing, no longer relevant.

repo: couchbase/couchnode


text:
Fix libevent issue in configure script

Hi guys
There is a problem with "--with-libevent" option in configure.pl. It just doesn't work :)

To ensure quality review, Couchbase employs a code review system based on Gerrit to manage the workflow of changes in addition to tracking our contributor agreements.
To get this change in and collaborate in code review, please register on Gerrit and accept our CLA.  More detailed instructions are available here: https://developer.couchbase.com/open-source-projects#how-to-contribute-code.

Will be closing this pull request in 1 week if there is no further activity. The patch is OK, but for legal reasons we require you to go through our code review system and sign the CLA.

Okay, I've got it, If you don't mind I'll do it a bit later.

authors: maxim-ky mnunberg

repo: couchbase/libcouchbase


text:
Add Search for Scopes, Collection and Document Ids

In the plugin tree, the user should be able to search for a scope, collection and when possible, document ids. The search should be done via shortcut, and should not be always visible.
Please check how datagrip search works for more:
https://www.youtube.com/watch?v=U5SOD-eeK50&ab_channel=JetBrains

maybe we could get that integrated into the IDE's search


text:
Add API to list versions

Use like
import scala.concurrent.ExecutionContext.Implicits.global
import coursier._
val availableVersions = Versions()
  .withModule(mod"org.scala-lang:scala-library")
  .versions()
  .unsafeRun()
  .available // Seq[String]

Wow, this looks like it could be used in Scala Steward to find new versions instead of going through sbt and sbt-updates. This has the potential to make Scala Steward a lot faster.
Thanks @alexarchambault!

@fthomas But don't you need to start sbt anyway to know about the dependencies themselves (before checking for possible updates)?

FYI, I have a project in the work, that aims to list dependencies outside of sbt itself, like this. With those files, it should be possible to e.g. have a single JVM checking for updates for as many projects as necessary. (My goal was to ping you about it as a I'll publicly announce it :)

You're right. Not all invocations of sbt can be eliminated only those that check for updates of all known dependencies.
deps looks cool. Finally a principled way to organize dependencies where it is totally clear where version numbers are defined! It should be easy for Scala Steward to also update deps.json files. Even if a project does not use sbt. This is exciting!

@alexarchambault I'm now using Coursier exclusively to find new updates (https://github.com/fthomas/scala-steward/pull/1209) and it is working great so far. Going through all repos now takes 30-40 minutes instead of 5-6 hours. It is so fast now that it had been blacklisted by Maven Central a few times and I had to add a rate limiter to slow it down. :-)
Thanks again for this great addition to Coursier!

Thanks for the feedback, @fthomas!

authors: alexarchambault fthomas

repo: coursier/coursier


text:
Tweak file locks handling

Fixes https://github.com/coursier/coursier/issues/1444.

Fixes https://github.com/coursier/coursier/issues/1444.

Travis CI is green too.


text:
Update case-app to 2.0.1

Updates com.github.alexarchambault:case-app from 1.2.0 to 2.0.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.alexarchambault", artifactId = "case-app" } ]

labels: library-update, semver-major

Superseded by https://github.com/coursier/http-server/pull/38.

Superseded by #53.

authors: alexarchambault scala-steward

repo: coursier/http-server


text:
Update sbt-pack to 0.18

About this PR
📦 Updates org.xerial.sbt:sbt-pack from 0.13 to 0.18
📜 GitHub Release Notes - Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.xerial.sbt", artifactId = "sbt-pack" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.xerial.sbt", artifactId = "sbt-pack" }
}]

labels: sbt-plugin-update, commit-count:1

Superseded by #67.


text:
Add getSearchParams util in UrlUtil

Proposed Changes
Added a small util to that parses the current url and returns the search params as an object. I added a new lib at the same time that handles query-strings in a graceful way. I will need this lib in some incoming PR.
I didn't do any tests for that one because its simply impossible to mock window.location in any way with jasmine :hankey:
Potential Breaking Changes
None
Acceptance Criteria

[ ] The proposed changes are covered by unit tests
[ ] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

Codecov Report

Merging #1311 into add-missing-hoc-table-utils will not change coverage.
The diff coverage is n/a.

@@                     Coverage Diff                      @@
##           add-missing-hoc-table-utils    #1311   +/-   ##
============================================================
  Coverage                        99.44%   99.44%
============================================================
  Files                              362      362
  Lines                             9082     9082
  Branches                          2146     2146
============================================================
  Hits                              9032     9032
  Misses                              50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77449ee...ed3ad1e. Read the comment docs.

authors: codecov-io gdostie

repo: coveo/react-vapor


text:
Display before day Confirmed, Recovered, Deceased cases

Would be good, if the app can display a day before active, recovered ,deceased cases like in below image,
This would give a glimpse on how our country is overcoming the virus day by day
we can change display colour to green if today confirmed cases are less than yesterday and red if they more and vice-versa for deceased and recovered cases
Note: I have shown the sample data only for active cases (like how it can be if this feature addition gets approved)

Solution: i am still going through the code, but this can be doable, i will produce the possible solution in day or two

I don't see any particular need for doing this. The trend of daily increase in cases can already be seen in the charts

authors: saandeepgithub shuklaayush


text:
Make npm test work on a fresh clone

These commits allow us to run
git clone https://github.com/covidatlas/li
cd li
npm install
npm test

and have the test suite run successfully, as is customary for Node packages.
I've also amended the instructions to use this workflow; they're a bunch shorter now as a result. I believe most people tend to have origin as the upstream remote, and some other name (joliss for me) for their forks. This is what I've been doing, and all Node packages I've encountered so far have been amenable to this workflow.

Wait. Renaming tests/integration/shared/sources/gitdiff.json.example to tests/integration/shared/sources/gitdiff.json is going to be a nuisance for you, @jzohrab, since you're not using "origin/master", so it'll always show as modified. I'll have to come up with a better way to do this.

Okay, it now simply uses origin/master as a default when there's no gitdiff.json file. This should be better.
The tests for this PR are red only because of #588, but other than that the test suite passes. So this PR is ready for review now!

Odd that the tests failed ... they had been working, I added those checks b/c the old code wasn't double-checking those cases.

Thanks @joliss!

authors: joliss jzohrab

repo: covidatlas/li


text:
scrape new AU headless AngularJS table

Summary
Its dynamic so we have to crawl headless :(
But there are Deaths counts now :)

Blocked by headless scrapes failing in CI (looks like its trying to run head-ful)


text:
Implementing "UIApplicationDidFinishLaunchingNotification"

I have been trying to implement catching "UIApplicationDidFinishLaunchingNotification" to this plugin but have not been able to achieve it with my limited Swift skills...
I am able to implement a javascript callback to a geofence transition on iOS when the app :
(1) is in the foreground,
(2) is alive in the background
(3) was killed (in which case iOS just opens up the app again before executing my JS callback.
However, in case (3), the app proceeds to load as usual, therefore synchronising content from the cloud that is not necessary as the app is launched in the background and invisible to the user. In order to avoid this, it is my understanding that we need to catch 'UIApplicationDidFinishLaunchingNotification'.
What I thought might work was adding the following inside the pluginInitialize function :
        NSNotificationCenter.defaultCenter().addObserver(
            self,
            selector: "didFinishLaunching:",
            name: "UIApplicationDidFinishLaunchingNotification",
            object: nil
        )

and the following function (which I have not finished since it is not working for now..) :
    func didFinishLaunching (notification: NSNotification) {
        log("didFinishLaunching")
        if let userInfo = notification.userInfo as? Dictionary<String,String> {
            if let s = userInfo["UIApplicationLaunchOptionsLocationKey"] {
                log("UIApplicationLaunchOptionsLocationKey")
            }
        }
    }

didFinishLaunching is not even getting called as didFinishLaunching never appears in my logs. I am however 100% sure that my app is launching after I killed it due to a geofence event as I can see the app being re-oponed and my callback called in the logs.
Perhaps someone could help implement this ? I was hoping to add a function for example like window.geofence.hasUIApplicationLaunchOptionsLocationKey() which would return a boolean :) Sounds like a good new feature for this plugin.

+1
without the didFinishLaunching I can't seem to get the updates to process in the background on region transition change.
something like:

(BOOL)application:(UIApplication*)application didFinishLaunchingWithOptions:(NSDictionary*)launchOptions{
self.viewController = [[MainViewController alloc] init];
if (launchOptions[UIApplicationLaunchOptionsLocationKey]) {
GeoNotificationManager *geoManager = [[GeoNotificationManager alloc] init];
[geoManager.locationManager startUpdatingLocation];
}
return [super application:application didFinishLaunchingWithOptions:launchOptions];
}

authors: Wade-BuildOtto goyavo

repo: cowbell/cordova-plugin-geofence


text:
first letter of rain is not white

Seems that with the merga of the DOD branch the white leading character was left out.     Probably  will make it a command line argument.

I will close this now that is has been added.


text:
add a change log @coderabbitai

updates CI triggers
adds a workflow to bump version numbers and create a GitHub release

The new changelog is hosted in docs, but it is not updated until bumping version numbers (and creating a release). The intention is to keep merge conflicts minimal among simultaneous PRs.

Summary by CodeRabbit
Release Notes

New Features

Implemented a new changelog configuration for better tracking of changes.
Added a comprehensive changelog to document notable changes.
Created a link to the changelog in the documentation for easier access.

Bug Fixes

Enhanced spell checker configuration to recognize additional terms.

Documentation

Updated documentation structure to include a link to the changelog.

Chores

Various updates to GitHub Actions workflows for improved automation and management.

@coderabbitai resolve

@coderabbitai help

@coderabbitai update this PR's title.


text:
XCode crash fix

Same changes which has been made for cpp-netlib/uri https://github.com/cpp-netlib/uri/commit/143d4264b8db77cf5b77f8975b3ec8c118bb8a80
XCode crashed when boost::network::uri class was used in code and user tried to start application under debugger.
After fix crash has gone

LGTM -- Awesome stuff, thanks @TheAquaMan!

authors: TheAquaMan deanberris

repo: cpp-netlib/cpp-netlib


text:
SnippetTest.java:69-71: Enable PlaceTest and UnplaceTest...

The puzzle 526-1315d399 from #526 has to be resolved:
https://github.com/cqfn/eo/blob/b2b8dac2c97071920f068a74aba30ff575bf7f23/eo-maven-plugin/src/test/java/org/eolang/maven/SnippetTest.java#L69-L71
The puzzle was created by @baudoliver7 on 28-Dec-21.
Estimate: 30 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@yegor256 please, assign

repo: cqfn/eo


text:
No license?

Hi, given the restrictive default copyrights of an unlicensed github repo ("no one may reproduce, distribute, or create derivative works from your work."), is there any hope that this repo gets a more open license eventually? Mostly thinking about the NPSS code that people could use and share.
Info:
https://help.github.com/en/github/creating-cloning-and-archiving-repositories/licensing-a-repository
Thanks!

Thank you we have added license to our repository. You can use our work to reproduce results or even create multiple derivative works from this repo.

authors: AnkurMali XefPatterson


text:
Update npm and composer commands to use site containers

Description
Right now, both of the npm and composer commands create a temporary container based on the path of the command. This is useful for running these commands on directories that will never be related to a "site" in Nitro context. However, the 80 percent use case is to run npm or composer within the context of a site. Therefore these commands should be more "site aware" but fall back to a standalone container if it cannot determine the part is part of a site.
We need to update the commands to use the sites container as those containers now include node, npm, and composer by default.

Hi, we are closing this issue as we have decided to retire Nitro, so no additional work will occur on this project. You can read the official blog post here https://craftcms.com/blog/retiring-craft-nitro. We appreciate everyones feedback and involvement and we look forward to refocusing our efforts on Cloud!
If you're looking for a new local development environment, we recommend DDEV and have a knowledge base article to help you with the transition: https://craftcms.com/knowledge-base/migrating-from-craft-nitro-to-ddev.

repo: craftcms/nitro


text:
Crafty.map.search revision

May I suggest a few usability changes to Crafty.map.search?

Allow negative width/height. Canvas allows it as well, and it goes nicely with implementing a standard RTS multiple unit selection rectangle.
The function uses both _x and x, but it's not well documented which one is for what. Can there be only x?
Would it be sensible to change the function signature to x, y, w, h, filter?
More documentation needed on crafty's website for the whole Crafty.map namespace.

I'm going to go ahead and close this, since the assumption that we're dealing with an object with _x, _y, _w and _h is pretty pervasive throughout the map code.
I could imagine rewriting the whole thing to take arguments in a different way, but that would only make sense in the face of some other large changes.
The documentation thing is still a problem, but that's already tracked in our bugs for revamping the docs.  :)

authors: kanecko starwed

repo: craftyjs/Crafty


text:
Update init.py

This should fix the async execution error, however there's more work that needs to be done on config_entries.py:
Error setting up entry for panasonic_cc
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 594, in async_setup
result = await component.async_setup_entry(hass, self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/panasonic_cc/init.py", line 72, in async_setup_entry
devices = await hass.async_add_executor_job(api.get_devices)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/panasonic_cc/pcomfortcloud/session.py", line 362, in get_devices
for group in self._groups['groupList']:
~~~~~~~~~~~~^^^^^^^^^^^^^
TypeError: 'NoneType' object is not subscriptable

You've already figured it out.

Thanks @grinco,
Unfortunately the alert for this got lost in all the issue notifications and I only noticed after I had merged the update pcomfortcloud logic.
Appreciate the effort

authors: craibo grinco


text:
centos host image site is not available

we are not able to get chef/centos 6.6 hots site

I think they have been moved to: https://atlas.hashicorp.com/bento/

Fixed by PR #4

I merged PR #5 which should fix your issue.
Sorry for the massive delay.

Thank you so much
On Thu, May 26, 2016 at 12:55 AM, Craig S notifications@github.com wrote:

Closed #2 https://github.com/craig5/salt-essentials-utils/issues/2.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/craig5/salt-essentials-utils/issues/2#event-672255835

authors: craig5 ismayilkm jeton pabranch


text:
Chore: A few adjustments after migrating the code base

A few details have been missed when migrating the code base. This patch adjusts them. There will probably be more.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.62%. Comparing base (4a42711) to head (356e75a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   84.51%   84.62%   +0.10%
==========================================
  Files          14       14
  Lines         917      917
==========================================
+ Hits          775      776       +1
+ Misses        142      141       -1

Flag
Coverage Δ

main
84.62% <100.00%> (+0.10%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

authors: amotl codecov-commenter

repo: crate-workbench/sqlalchemy-cratedb


text:
Create dependabot.yml with monthly updates

I've enable dependabot in the settings for this repo.

Absolutely! I never got to that part... :-). Should be good now for review @alexdametto

repo: crate/crate-gc-admin


text:
Performance degradation when using aliases with date_format in order by clause

CrateDB version:
3.0.0-SNAPSHOT-01a5fae
Environment description: Centos 7.4
Problem description:
When using aliases and ordering by them, query times take longer to return results. This appears to be an issue when using the date_format function. We haven't tried other functions.
Steps to reproduce:
SELECT colA, date_format('%Y-%m-%dT%H:%i:%s.%fZ', startdate) as start_date FROM table ORDER BY start_date desc

This query takes ~8s
SELECT colA, date_format('%Y-%m-%dT%H:%i:%s.%fZ', startdate) as start_date FROM table ORDER BY startdate desc

This query takes <1s
startdate's type: timestamp

If you sort on the timestamp column it can internally utilize a column store data structure to do efficient sorting. If instead you sort on the date_format function it has first to evaluate that function on all records, this is expected to be slower.

@mfussenegger Makes sense....I'll close unless you think further action is needed.

authors: bputt mfussenegger

repo: crate/crate


text:
Documentation: Improve page about the HTTP endpoint/interface

About
Improve documentation page about the HTTP endpoint/interface.
Preview

https://crate--16733.org.readthedocs.build/en/16733/interfaces/http.html

Details

Group concerns about bulk operations (general vs. error handling) together, to improve context, as suggested by @amotl.

Elaborate better about two different kinds of errors that may happen when processing bulk operation requests, and about their behaviour, as suggested by @matriv.

References

https://github.com/crate/crate/issues/16617#issuecomment-2375305018
https://github.com/crate/crate/issues/16683#issuecomment-2376499787

Failure looks related:
======================================================================
ERROR: test_docs (unittest.loader._FailedTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/CrateDB/crate_on_pr/blackbox/test_docs.py", line 442, in load_tests
    docsuite(
  File "/usr/lib/python3.9/doctest.py", line 2508, in DocFileSuite
    suite.addTest(DocFileTest(path, **kw))
  File "/usr/lib/python3.9/doctest.py", line 2440, in DocFileTest
    test = parser.get_doctest(doc, globs, name, path, 0)
  File "/usr/lib/python3.9/doctest.py", line 675, in get_doctest
    return DocTest(self.get_examples(string, name), globs,
  File "/usr/lib/python3.9/doctest.py", line 689, in get_examples
    return [x for x in self.parse(string, name)
  File "/var/lib/jenkins/workspace/CrateDB/crate_on_pr/blackbox/.venv/lib/python3.9/site-packages/zc/customdoctests/__init__.py", line 51, in parse
    r =doctest.DocTestParser.parse(self, string, name)
  File "/usr/lib/python3.9/doctest.py", line 651, in parse
    self._parse_example(m, name, lineno)
  File "/usr/lib/python3.9/doctest.py", line 709, in _parse_example
    self._check_prompt_blank(source_lines, indent, name, lineno)
  File "/usr/lib/python3.9/doctest.py", line 793, in _check_prompt_blank
    raise ValueError('line %r of the docstring for %s '
ValueError: line 470 of the docstring for http.rst lacks blank after    : "    ... -X POST '127.0.0.1:4200/_sql' -d@- <<- EOF"

A few people already contributed to the improvements on this page. Thanks! Because a few others have also been interested about this, I am humbly asking them to have another look: If anything else comes to mind you would like to see mentioned here, or elaborated upon, a good chance is now to express your feelings and ideas.
/cc @karynzv, @hlcianfagna, @wierdvanderhaar, @zolbatar, @ckurze

authors: amotl mfussenegger


text:
Exploratory data analysis with PyCaret and CrateDB

Summary of the changes / Why this is an improvement

Exploratory data analysis with CrateDB and pycaret

Checklist

[ ] Link to issue this PR refers to (if applicable):
[ ] CLA is signed

will close this PR and open a new one.

repo: crate/cratedb-examples


text:
'Caught SIGBUS, dumping stack' and unstable connection to rtorrent

I have this repeated error in logs:
rtorrent-rutorrent_1  | Caught SIGBUS, dumping stack:
rtorrent-rutorrent_1  | Stack dump not enabled.
rtorrent-rutorrent_1  |
rtorrent-rutorrent_1  | Error: No error information
rtorrent-rutorrent_1  | Signal code '2': Non-existent physical address.
rtorrent-rutorrent_1  | Fault address: 0x7fb6217cd000
rtorrent-rutorrent_1  | The fault address is not part of any chunk.

And connection to rtorrent is unstable.

I have about 300 torrents and they cannot be checked and change status to 'uploading'.
My .rtorrent.rc:
# Maximum and minimum number of peers to connect to per torrent
throttle.min_peers.normal.set = 1
throttle.max_peers.normal.set = 100

# Same as above but for seeding completed torrents (-1 = same as downloading)
throttle.min_peers.seed.set = 1
throttle.max_peers.seed.set = 50

# Maximum number of simultanious uploads per torrent
throttle.max_uploads.set = 15

# Global upload and download rate in KiB. "0" for unlimited
throttle.global_down.max_rate.set_kb = 0
throttle.global_up.max_rate.set_kb = 0

# Enable DHT support for trackerless torrents or when all trackers are down
# May be set to "disable" (completely disable DHT), "off" (do not start DHT),
# "auto" (start and stop DHT as needed), or "on" (start DHT immediately)
dht.mode.set = auto

# Enable peer exchange (for torrents not marked private)
protocol.pex.set = yes

# Check hash for finished torrents. Might be usefull until the bug is
# fixed that causes lack of diskspace not to be properly reported
pieces.hash.on_completion.set = yes

# Set whether the client should try to connect to UDP trackers
#trackers.use_udp.set = yes

# Set the max amount of memory address space used to mapping file chunks. This refers to memory mapping, not
# physical memory allocation. Default: 1GB (max_memory_usage)
# This may also be set using ulimit -m where 3/4 will be allocated to file chunks
#pieces.memory.max.set = 1GB

# Alternative calls to bind and ip that should handle dynamic ip's
#schedule2 = ip_tick,0,1800,ip=rakshasa
#schedule2 = bind_tick,0,1800,bind=rakshasa
schedule = watch_directory_1, 5, 5, ((load.start, /downloads/p2p/pool/*.torrent, "d.custom.set = watchdir, /downloads/p2p/pool/", "d.directory.set = $d.custom=watchdir"))
schedule = watch_directory_4, 5, 5, ((load.start, /downloads/_torr/*.torrent, "d.custom.set = watchdir, /downloads/_torr/", "d.directory.set = $d.custom=watchdir"))
schedule = watch_directory_6, 5, 5, ((load.start, /downloads/ftpuser/*.torrent, "d.custom.set = watchdir, /downloads/ftpuser/", "d.directory.set = $d.custom=watchdir"))

# Changing names of downloading and downloaded torrents
method.insert = d.renamed_suffix,   simple, "if = $d.complete=, +++, ---"
# - WORKAROUND: extra / at beginning needed because $d.tied_to_file= begins with //
method.insert = d.renamed_file,     simple, "cat = /, $d.custom=watchdir, /, $d.renamed_suffix=, ., $d.name=, .torrent"
method.insert = d.rename_file,      simple, "execute = mv, --, $d.tied_to_file=, $d.renamed_file=; d.tied_to_file.set = $d.renamed_file="
method.insert = d.safe_rename_file, simple, "branch = ((equal, d.tied_to_file=, d.renamed_file=)), , d.rename_file="
method.set_key = event.download.inserted_new,   rename_loaded,  d.safe_rename_file=
method.set_key = event.download.resumed,        rename_resumed, d.safe_rename_file=
method.set_key = event.download.finished,       rename_finished,d.safe_rename_file=

# Watch a directory for torrents, and remove those that have been deleted.
schedule = watch_untied, 5, 5, ((remove_untied))

# Set default view
schedule = default_view, 1, 0, ui.current_view.set=incomplete

# Periodically save session data
schedule = session_save,240,300,session_save=

directory = /downloads/incoming
#session = /config/rtorrent/rtorrent_sess

# Encryption options, set to none (default) or any combination of the following:
# allow_incoming, try_outgoing, require, require_RC4, enable_retry, prefer_plaintext
protocol.encryption.set = allow_incoming,try_outgoing,enable_retry

# Set the umask for this process, which is applied to all files created by the program
system.umask.set = 0022

# Add a preferred filename encoding to the list
encoding.add = UTF-8

# Watch a directory for new torrents, and stop those that have been deleted
#schedule2 = watch_directory, 1, 1, (cat,"load.start=",(cfg.watch),"*.torrent")
#schedule2 = untied_directory, 5, 5, (cat,"stop_untied=",(cfg.watch),"*.torrent")

# Close torrents when diskspace is low
#schedule2 = monitor_diskspace, 15, 60, ((close_low_diskspace,1000M))

# Move finished (no need Autotools/Automove plugin on ruTorrent)
#method.insert = d.get_finished_dir, simple, "cat=$cfg.download_complete=,$d.custom1="
#method.insert = d.move_to_complete, simple, "d.directory.set=$argument.1=; execute=mkdir,-p,$argument.1=; execute=mv,-u,$argument.0=,$argument.1=; d.save_full_session="
#method.set_key = event.download.finished,move_complete,"d.move_to_complete=$d.data_path=,$d.get_finished_dir="

# Erase data when torrent deleted (no need erasedata plugin on ruTorrent)
method.set_key = event.download.erased,delete_erased,"execute=rm,-rf,--,$d.data_path="

Looks to be an issue with rtorrent related to your FS: https://bbs.archlinux.org/viewtopic.php?id=122267
Open an issue on https://github.com/rakshasa/rtorrent for support

authors: aryadovoy crazy-max

repo: crazy-max/docker-rtorrent-rutorrent


text:
Empleado Favorito

Hacer que cuando le de clic al corazón del empleado se me registre en el apartado de favoritos.

PROYECTO CERRADO

authors: antonioEsB yahirsaavedra

repo: createchsoftware/armony

license: Unlicense


text:
Watermark view cannot handle images that do not have EXIF data

The utility function watermark(image_url, image_info) returns watermarked, exif where exif will be None if the image at the URL lacks EXIF data embedded in it.
This breaks down in the next line exif_bytes = piexif.dump(exif)
To Reproduce
Visit /watermark/{identifier} for an image without EXIF.
Expected behavior
The watermarked image should be returned without EXIF, like the source image.
The solution is simply to check for exif being None and not embedding exif_bytes in the response. Can I open a PR with this solution?

I could open a PR with this but it is bound to conflict with a PR towards the resolution #243. This being a rather minor change, could also be worked on in conjunction with issue #243, if @aldenstpage so wishes. This is also affecting the testing of PR #242.

Fixed in #252

authors: aldenstpage dhruvkb

repo: creativecommons/cccatalog-api