text:
[Bug Report] el-input by Chinese type input method, will enter into pinyin, input box component automatically brings out Pinyin when entering Chinese

Element UI version
2.6.1
OS/Browsers version
XP系统//Chrome49版本
Vue version
2.6.8
Reproduction Link
https://jsfiddle.net/mmx38qxw/
Steps to reproduce
el-inpu组件在输入中文时，会自动带出拼音！只有在XP系统，Chrome49环境下会有这个问题！
What is Expected?
期待能够帮解决！
What is actually happening?
希望可以解决！

2.4.11及一下版本没有这个问题！

试试这个 https://jsfiddle.net/da40mcgq/


text:
Max-height Failure of [Bug Report] 2.8.2 el-table

Element UI version
2.8.2
OS/Browsers version
任何浏览器
Vue version
2.6.10
Reproduction Link
https://codepen.io/didkobravo/pen/MvMYrV
Steps to reproduce
使用2.8.2版本的elUI，任何版本的VUE，都可以重现问题，max-height无效。
解决方法：退回2.4.11版本就没问题
What is Expected?
max-height正常
What is actually happening?
max-height无效，高度只有一行
注：上面的Reproduction Link乱写的。

2.7.2 及以下都没问题，因为2.8有一个Bug修复是说保持height和max-height的一致性。结果导致了2.8+的版本全部出现你说的这个问题https://github.com/ElemeFE/element/pull/14660https://github.com/ElemeFE/element/issues/15281

2.8的max-height始终是60px

#15309

临时解决方案，覆盖element自带样式
.el-table--scrollable-y .el-table__body-wrapper {
max-height: inherit !important;
}

source: gharchive/issue

repo: ElemeFE/element

license: MIT

license_type: permissive

license_source: github-api


text:
[Feature Request] el-table sort-change needs to distinguish between user clicks and default-sort

Existing Component
是
Component Name
el-table
Description
对element ui封装后,用户点表头触发sort-change中会执行查询,而default-sort触发sort-change是不需要查询的,缺个prop区分

@lightning0016 提供一个 demo 描述你的问题。

这个问题与https://github.com/ElemeFE/element/issues/11966相似,解决其中一个,即可解决项目bug
描述:
列表显示时不查询,点击排序时,会执行查询,但是如果有默认排序,会触发排序,也就会走查询,因为没法区分.


text:
[feature request] tool tip hopes to customize the closing delay time

Existing Component
是
Component Name
Tooltip
Description
Tooltip希望可以自定义关闭延迟时间，有时候并不需要延迟关闭。
https://github.com/ElemeFE/element/blob/8168d14e67b4982d5afebb82170c7eb2cfb421e6/packages/tooltip/src/main.js#L75

添加closeDelay属性
this.$nextTick(() => {
      this.debounceClose = debounce(this.closeDelay, () => this.handleClosePopper());
});

https://github.com/Const-Team/Element

最新版本并没有加，实际需要控制关闭时间。
应用场景是有滚动条的div，里面的元素用到el-tooltip，此时滚动条较快时，会有tooltips超出div的现象。如果能缩短关闭时间，用户体验会更好。

authors: fengdanbailu sjlei wangdaodao


text:
Feature request: Collapsible navbar menus and collapsible drawar/sidebar

This is the  main feature missing in element which prevents me from adopting it. It is important for hybrid mobile/desktop responsive web apps.

element-ui however may not be responsive...

@reverland , grid is already responsive

No, it is not intended for mobile platform.
As far as I see, the components may not well designed for mobile apps.
You may find mint-ui useful?

Developing for mobile and desktop separately is a double work, and repeating is cause of most bugs.

Not really, you may prefer material-design if you want more than just a PC website.
you should notice that the date-picker, slider, dialog, loading breadcrumbs, select and so on are not designed for mobile platform.
implement a responsive component library is hard, as far as I can see, I don't think element-ui will consider responsive.

Element is design for backstage management system and have no plan for responsive design. I'm totally agreed with @reverland , implement a  responsive component is not a good idea actually. In  grid, we just provide responsive props to make the flexible layout.

authors: baiyaaaaa otabekgb reverland


text:
Can [Feature Request] Select components develop search capabilities?

Existing Component
否
Component Name
Select选择器
Description
RT
Select组件 并没有可以应对options非常多这种情况的解决方案，可以考虑增加搜索过滤功能么？

试试filterable选项


text:
[Bug Report] cannot update the display of the form of a certain item in error under special circumstances

Element UI version
1.3.7
OS/Browsers version
windows 10/ chrome 54
Vue version
2.4.1
Reproduction Link
https://github.com/xiangnanscu/core-test/tree/form
Steps to reproduce
依次点击:
1.提交
2.获取验证码(此时错误会更新)
3.提交
4.获取验证码 (此时错误不会更新)
What is Expected?
第二次点击获取验证码的时候应该显示错误"请先输手机号"
What is actually happening?
没有这样显示

为节约时间, 这里贴上主要代码
<template>
  <el-form :model="formData" :rules="rules" ref="registerForm" label-position="right" label-width="6em">
    <el-alert v-if="errors.__all" :title="errors.__all" type="error" :closable="false"></el-alert>
    <el-form-item label="手机号" prop="phone" :error="errors.phone">
      <el-input v-model="formData.phone" auto-complete="off" placeholder="请输入11位手机号"></el-input>
    </el-form-item>
    <el-form-item label="验证码" prop="code" :error="errors.code">
      <el-row>
        <el-col :span="12">
          <el-input v-model="formData.code" auto-complete="off" width="50px"></el-input>
        </el-col>
        <el-col :span="12">
          <el-button type="primary" @click="sendCode" style="margin-left:8px">
            获取验证码
          </el-button>
        </el-col>
      </el-row>

验证码已发送, 请注意查看手机

    </el-form-item>
    <el-form-item>
      <el-button type="primary" @click="submitForm">
        提交
      </el-button>
    </el-form-item>
  </el-form>
</template>

不建议 rules 和 error 混在一起使用。如果一定要用的话，可以这样绕一下：https://jsfiddle.net/aew4kxdz/ （40 行至 43 行）

@Leopoldthecoder 其实我也不想混用, 但是似乎没有办法可以直接操作form内建的errors状态(就我所知,似乎只能通过validate方法产生, 通过提交合法的输入消除)

@Leopoldthecoder 请教一下, 在表单提交之后, 后端可能还会返回一个出错信息对象, 比如{phone: '又一个出错', code: '再一个错误'}, 那么, 用这个出错对象来触发form的错误渲染的正确姿势是什么呢? element form 支持这样做吗?

还是通过给 this.errors 赋值来实现。事实上 error 属性就是为后端返回的出错信息设计的，在你的例子里，「请先输手机号」这个错误其实可以用自定义校验规则来产生，而不是使用 error 属性。

@Leopoldthecoder 但是直接赋值this.errors的话有这个bug: 在你输入了前端合法的数据后, 比如phone:13508198877, code:111111, 然后首次点击"提交"会如期返回无效手机号, 紧接着再点击"提交", phone错误信息就消失了. 但实际上期望的是后端再次返回一个出错对象, element应该渲染相同的错误.
    submitForm() {
      this.$refs.registerForm.validate((valid) => {
        if (valid) {
          setTimeout(() => {
            this.errors = {phone: '无效手机号'}
          }, 1000)
        } else {
          return false;
        }
      });
    },

@Leopoldthecoder 刚测试了下, 如果清空rules就完全正常了. 这样的话是不是意味着如果我想渲染来自后端的错误, 就不能直接同时使用rules了? 如果一定要用的话, 就需要按照你之前的那个绕过技巧来?

@Leopoldthecoder 我又进行了另外一个测试, 在混用的情况下, 如果某个字段比如phone后端返回的错误信息和上次不一样, 那么element会渲染出来. 如果和上次一样, 那么就会有之前提到的bug

不是 bug，因为内部是 watch 了 error，所以它发生变化才会渲染出来。
   submitForm() {
      this.$refs.registerForm.validate((valid) => {
        if (valid) {
          this.errors = {phone: ''}
          setTimeout(() => {
            this.errors = {phone: '无效手机号'}
          }, 1000)
        } else {
          return false;
        }
      });
    },

所以你前端验证通过之后把 this.errors.phone 置空，然后再根据后端的返回重新赋值就可以了。

@Leopoldthecoder 好的. 感谢指点.  建议, 当error没有发生变化的时候, 不要清空之前的错误显示就更好了.

错误被清空只是因为你的 rules 校验被通过了。
试想这样一个场景：用户输入了一个合法的手机号，点击提交，rules 校验通过，这时没有错误信息。数据提交给服务器后，后端返回了一个错误，你通过 error 展示出来。这时用户输入 另一个 合法的手机号，点击提交，此时因为手机号格式是合法的，rules 校验通过，所以错误信息是应该被清空的（因为前端此时并不知道这个手机号能否通过服务器的校验）。

@Leopoldthecoder 第二次提交的时候, rules校验通过,错误信息清空, 但1秒后this.errors = {phone: '无效手机号'}使得错误信息又被赋值,  此时应像第一次提交那样渲染相同错误信息的吧?
此外rules和errors混用应该是不可避免的吧? rules渲染前端的错误(比如正则不匹配之类的), errors负责渲染后端返回的错误. 那么除了你提到的那个绕过技巧之外, 可以从设计层面解决这个问题吗? 即:errors.phone既然有值, 那么对应的错误就应该显示出来. 如果赋值之前要先置空, 总觉得有些不够优雅.

authors: Leopoldthecoder xiangnanscu


text:
折线图的空心圆点能设置成实心的吗、线条能改成渐变色吗

Summary 简述
Expect 期望结果
Reproduce 重现示例

https://jsfiddle.net/vue_echarts/aa7ojxyt/212/
看下是不是这种样式。

authors: lihanyu xiguaxigua

repo: ElemeFE/v-charts

license: mit

license_source: bigquery


text:
http://localhost:9000/

localhost:9000
this bug

Hello @Coffstation.
Were there any error messages in your console?
Infinite loader happens if filteredPosts located inside src/components/MainCard/index.js has 0 length.
There is also filterPosts() function inside that file where you can try to console log posts and filtered to check if it fetches or filters the posts correctly.

Hi @EllisMin , there was no console error but   http://localhost:8000/  It's working correctly, I do not understand what happens. i am learning the gatsby environment 🔢 .
I can't find the error

class MainCard extends Component {
  state = {
    selectedTag: TAG.ALL,
    filteredPosts: [],
    tags: [],
  }

  componentDidMount() {
    // Get current viewing tag from storage
    let curTag = sessionStorage.getItem("curTag") || TAG.ALL
    const tagExists = this.checkTag(curTag)
    // If saved tag in storage doesn't exist among posts, set to "all"
    if (!tagExists) {
      curTag = TAG.ALL
    }
    this.setState({ selectedTag: curTag }, () => {
      this.filterPosts()
      this.filterTags()
    })
  }

  // Check if tag in storage exists
  checkTag = storageTag => {
    // Input checks
    if (!storageTag) {
      return false
    }
    if (storageTag === TAG.ALL) {
      return true
    }
    const posts = this.props.posts
    for (let i = 0; i < posts.length; i++) {
      const tags = posts[i].node.frontmatter.tags
      if (tags && tags.length > 0 && tags.includes(storageTag)) {
        return true
      }
    }
    return false
  }

  // Filter tags and sort them by occurrences
  filterTags = () => {
    const posts = this.props.posts
    const tagsByFrequency = {}
    const sortedTags = []
    // Exclude about page & dummy page
    const filteredPosts = posts.filter(
      post =>
        post.node.fields.slug !== "/about/" &&
        post.node.fields.slug !== "/__do-not-remove/"
    )
    filteredPosts.forEach(post => {
      let tags = post.node.frontmatter.tags

      if (!tags) {
        // Register tag to the post if does not have any
        post.node.frontmatter.tags = ["Uncategorized"]
        tags = ["Uncategorized"]
      }

      tags.forEach(tag => {
        if (tagsByFrequency[tag]) {
          tagsByFrequency[tag] = tagsByFrequency[tag] + 1 // update frequency
        } else {
          tagsByFrequency[tag] = 1
          sortedTags.push(tag)
        }
      })
    })

    sortedTags.sort(function(a, b) {
      return tagsByFrequency[b] - tagsByFrequency[a]
    })

    this.setState({ tags: sortedTags })
  }

  filterPosts = () => {
    const posts = this.props.posts
    const filtered = posts.filter(({ node }, i) => {
      return (
        this.state.selectedTag === TAG.ALL ||
        (node.frontmatter.tags &&
          node.frontmatter.tags.includes(this.state.selectedTag))
      )
    })

    this.setState({ filteredPosts: filtered })
  }

  handleSelectTag = async tag => {
    // Save current tag in storage
    sessionStorage.setItem("curTag", tag)
    await this.setState({ selectedTag: tag })
    await this.filterPosts()
  }

  render() {
    return (
      <StyledMainCard className="main-card">
        <StyledSwitchContainer className="switch-container">
          <ToggleMode />
        </StyledSwitchContainer>
        <StyledSubMain className="sub-main">
          <StyledSubMainInner>
            <Profile home />
            {this.state.filteredPosts.length > 0 ? (
              <StyledTagsPosts>
                <Tags
                  selectedTag={this.state.selectedTag}
                  selectTag={this.handleSelectTag}
                  tags={this.state.tags}
                />
                <PostList
                  posts={this.state.filteredPosts.slice(0, this.props.loads)}
                />
              </StyledTagsPosts>
            ) : (
              <div style={{ textAlign: "center" }}>
                <Loader />
              </div>
            )}
          </StyledSubMainInner>
        </StyledSubMain>
      </StyledMainCard>
    )
  }
}

export default MainCard

let StyledTagsPosts = styled.div``

StyledTagsPosts = styled.div`
  position: relative;
  display: flex;
  flex-direction: column;

  .moveToBot {
    position: sticky;
    top: 0;
    padding-top: 2.5rem;
    padding-bottom: 2.5rem;
    .tag-list {
      .tag-horizontal {
        font-size: 0.85rem;
      }
    }
  }

  .moveToBotAnimate {
    position: sticky;
    top: 0;
    transition: padding 300ms ease-in;
    padding-top: 2.5rem;
    padding-bottom: 2.5rem;
    .tag-list {
      .tag-horizontal {
        transition: font-size 300ms ease-in;
        font-size: 0.85rem;
      }
    }
  }
`
if (!isMobile) {
  StyledTagsPosts = styled.div`
    position: relative;
    display: grid;
    grid-template-columns: 0.25fr auto;
    padding: 0.5rem 1.5rem 1.5rem 1.5rem;

    @media (max-width: 500px) {
      padding: 0rem 1rem 1rem 1rem;
    }
  `
}

const StyledMainCard = styled.div`
  position: relative;
  padding: 0 1rem 1rem 1rem;

  @media (max-width: 500px) {
    padding: 0;
  }
`

const StyledSubMain = styled.div`
  position: relative;
  margin-top: 3rem;
  border-radius: 10px;

  @media (max-width: 500px) {
    margin-top: 1rem;
    border-radius: 0px;
  }
`

let StyledSubMainInner = styled.div``

if (!isMobile) {
  StyledSubMainInner = styled.div`
    transform: translateY(-25px);
  `
}

const StyledSwitchContainer = styled.div`
  position: absolute;
  text-align: end;
  margin: 0 0.4rem;
  top: 12px;
  right: 25px;
  z-index: 2;

  @media (max-width: 500px) {
    right: 10px;
  }
`

@Coffstation

Do you use npm start or gatsby develop to start the development server?

If yes, try starting the server with gatsby develop -p 9000 by specifying your port number to 9000. The default port for gatsby develop is set to 8000, hence you need -p flag.

If you're using gatsby serve, the default port is 9000. However, gatsby serve is to run the production build for testing. You'd need to run gatsby build first before using gatsby serve

thanks you , :3.

authors: Coffstation EllisMin coffstation

repo: EllisMin/gatsby-blog-mdx


text:
Better "404 - Page not Found" page

Create a better design for the  "404 - Page not Found" page (NotFound Component).
Currently it only displays a h1 with the "404 - Page not Found" text and with no styling... 🤔
The objective is to give it some nice styling so that the 404 page could potentially fit any project created from this template and needing little to no changes.

I would like to give it a try. 💪🏻

@BillNas Thank you for your effort. Let me know if you need any help! 👌👍

authors: BillNas EmanuelGF

repo: EmanuelGF/template-react-ui


text:
Update lints to embark lints 0.3

Fixes https://github.com/EmbarkStudios/tame-gcs/issues/45
One of the biggest changes impacts tests that have been ignored. I tried running them by removing the ignore, but they seem to rely on an ENV VAR that I don't have (TAME_GCS_TEST_SVC_ACCOUNT, TAME_GCS_TEST_BUCKET, TAME_GCS_TEST_OBJECT). These seem like things that maybe run in CI, but I couldn't see any references to that in the repo.

Unfortunately, if I just revert that the lint's won't pass. It was replacing unsafe code with (I am pretty sure, I can't double check on my phone) safe code. It didn't seem like the kind of code that necessitated ignoring the lint, but also reimplementing the solution in that crate also seemed like overkill. If that unsafe code is needed I can always ignore the lint

Yes, it's fine to turn off the lint in just that one function.

@Jake-Shadle So, I couldn't quite bring myself to allowing the no unsafe lint without one more shot. This time I mostly kept the original code while modifying it based on that other package. Let me know if that works

source: gharchive/pull-request

authors: DeanBDean Jake-Shadle

repo: EmbarkStudios/tame-gcs


text:
Dev el

Enhancements regarding reproducibility.

The "docs/dag.png" file seems to be the filegraph. I'm merging the PR now, but it can be replaced at a later stage. Thank you for the contributions, @eliasinul!

The "docs/dag.png" file was fine, you can disregard the previous commit message @eliasinul.

repo: EmiFej/DRB-OSeMOSYS-model


text:
MemoryError while extracting metadata using PNG Extraction Module

While extracting metadata using the PNG Extraction Module (CommonHeadersOnly - true), all the DICOM tags are collected stored in a CSV format using pandas.
The memory error occurs because - in some instances, the DICOM Images could have a large no. of tags than expected which creates a sparse CSV file resulting in a large data frame that cannot be saved using pandas.
The error can be fixed by transferring such DICOM files (which have a large no. of tags) into a new folder in failed-dicom folder in the same module.

Fixed the issue in PR - 271. But did not transfer the failing DICOMs to a new folder. I will submit a new PR to perform the operation.

Hy @anbhimi & @pradeeban, Please give me example of  the DICOM Images who have a large no. of tags than expected.

@pradeeban ok

Fixed by @anbhimi

#293

authors: Nitesh639 anbhimi pradeeban

repo: Emory-HITI/Niffler


text:
Hash Password

We cannot deploy without hashed passwords. I believe this functionality is in the code, but it was implemented awhile ago and needs further testing

Closed by #127

authors: koseward mcauley-penney

repo: Empyrean-Capstone/Empyrean


text:
Fill kubeDomain based on api url

Type of change

Enhancement

Description

Fill kube domain based on api url for local development

@enmasse-ci run tests profile=shared testcase=isolated.web.FirefoxConsoleTest#testLoginLogout crc test_only

:heavy_exclamation_mark: Build Failed :heavy_exclamation_mark:

@enmasse-ci run tests profile=isolated testcase=isolated.web.FirefoxConsoleTest#testLoginLogout crc test_only

:heavy_check_mark: Test Summary :heavy_check_mark:
TEST_PROFILE: isolated
TEST_CASE: isolated.web.FirefoxConsoleTest#testLoginLogout
TOTAL: 1
PASS: 1
FAIL: 0
SKIP: 0
BUILD_NUMBER: 401

authors: enmasse-ci kornys

repo: EnMasseProject/enmasse


text:
HTTP POST - response fo succecful HTTP 200 change to 202 after a request charge or chargelink

If the content complies with the applicable rules, 202 Accepted will be returned from DataHub instead of 200 as we use today.
Acc:
Accepted 202 will be returned from DataHub after receive chargelink
Acc:
Accepted 202 will be returned from DataHub after receive charge

duplicate of #1127

authors: IreneDataHub prtandrup

repo: Energinet-DataHub/geh-charges


text:
Try branch coverage

Description
Try add branch coverage for codecov

No difference - closing PR

repo: Energinet-DataHub/geh-market-roles


text:
Deployment of custom login and sign up layout

Currently the custom login layout is uploaded manually to blob storage which is not ideal.
We should create a more formalized way of updating the custom login layout.
Maybe a custom static application with a webpack config or something?
Currently B2C is pointing at https://stordesignendku.z6.web.core.windows.net/login-unified.html
This should be changed to the correct environment as well.
Due the fact that we're now hosted at a static web app and not a storage account, please take into account that we can't just upload and test it manually. We need to find a solution for this as well (also how to handle changes, when we're live).
Please also note that CORS has been setup at the storage account for each b2c environment here
And the file is located here in the repository:
libs/dh/shared/assets/src/assets/login-page/login-unified.html
Acceptance criteria:

[ ] Custom login layout is deployed in the build pipeline like the rest of our applications
[ ] Adjust B2C to point at the correct environments (see getting-started.md) - Reach out to Daniel (Mighty Ducks)
[ ] Make it possible to test pages locally

Tech notes:

Try to reuse some of the styling (colors, sizes etc.)

Closing, this is now owned by Racoons.

authors: ManBearTM mknic

repo: Energinet-DataHub/greenforce-frontend


text:
example: Refactor input and output example

https://github.com/EnotionZ/GpiO/pull/49# was merged but not in master so I am making a new PR.
Do you plan @EnotionZ to update npm package, soon ?

I actually did a manual merge into master already. Looks like there's additional changes here, I'll merge this and will update package.

authors: EnotionZ rzr

repo: EnotionZ/GpiO


text:
Enhance Carousal by exposing more configuration options

Expose the following options for the Carousal widget, sample values below from the flutter package -
  aspectRatio: 16/9,
  viewportFraction: 0.8,
  autoPlayAnimationDuration: Duration(milliseconds: 800),
  autoPlayCurve: Curves.fastOutSlowIn, //support most of the Curves
  enlargeCenterPage: true,
  enlargeFactor: 0.3,
  onPageChanged: callbackFunction,
  scrollDirection: Axis.horizontal //or Axis.vertical

also the carousal widget today is slow as it doesn't use the builder pattern and tries to draw all the items at the same time instead of on-demand.
Please add an option called -
buildOnDemand: boolean
Default is false when item count <= 5
Default is true when item count >6
When true, use the itemBuilder pattern to draw widgets on demand

There is a lot there that we are not exposing. Also lots of room for performance improvement

cc @vusters

@snehmehta Can you check this PR - #1179

repo: EnsembleUI/ensemble


text:
Implement State Overrides for Simulations

This PR adds support for state overrides to the simulator.
At first, I wanted to use some of the built-in state overriding methods to the foundry_evm::Executor (namely set_balance and set_nonce). The issue was that the foundry_evm::Executor does not expose APIs for overriding code or storage slots. If you use foundry_evm::Executor::backend_mut, you additionally get  foundry_evm::Backend::insert_account_info, but since there is no direct mutable access to the underlying revm::CacheDB instance (it is private unfortunately) you still cannot override storage slots. In a slightly more recent version of foundry_evm (would require updating the version in Cargo.toml which felt a bit more delecate), they added methods for manipulating account storage but there is still no way to completely override the storage for an account (when using storageOverrides[address].state and not stateDiff).
The solution is to use revm::DatabaseCommit implementation (since Backend is an revm database that implements this) and update the database as if a transaction happened.
Test Plan
Should I implement automated tests for this?.
I did some (admittedly) not very complete manual testing locally:
Get vitalik.eth's CoW Protocol token balance
curl -s http://localhost:8080/api/v1/simulate -H 'Content-Type: application/json' --data '@-' <<JSON | jq
{
  "chainId": 1,
  "from": "0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045",
  "to": "0xDEf1CA1fb7FBcDC777520aa7f396b4E015F497aB",
  "data": "0x70a08231000000000000000000000000d8da6bf26964af9d7eed9e03e53415d37aa96045",
  "gasLimit": 500000,
  "value": "0",
  "blockNumber": 18175734
}
JSON

{
  "simulationId": 1,
  "gasUsed": 23994,
  "blockNumber": 18175734,
  "success": true,
  "trace": [
    {
      "callType": "CALL",
      "from": "0xd8da6bf26964af9d7eed9e03e53415d37aa96045",
      "to": "0xdef1ca1fb7fbcdc777520aa7f396b4e015f497ab",
      "value": "0x0"
    }
  ],
  "formattedTrace": null,
  "logs": [],
  "exitReason": "Return",
  "returnData": "0x0000000000000000000000000000000000000000000000000de0b6b3a7640000"
}

Turn vitalik.eth into a CoW Protocol maxi
curl -s http://localhost:8080/api/v1/simulate -H 'Content-Type: application/json' --data '@-' <<JSON | jq
{
  "chainId": 1,
  "from": "0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045",
  "to": "0xDEf1CA1fb7FBcDC777520aa7f396b4E015F497aB",
  "data": "0x70a08231000000000000000000000000d8da6bf26964af9d7eed9e03e53415d37aa96045",
  "gasLimit": 500000,
  "value": "0",
  "blockNumber": 18175734,
  "stateOverrides": {
    "0xDEf1CA1fb7FBcDC777520aa7f396b4E015F497aB": {
      "stateDiff": {
        "0xfca351f4d96129454cfc8ef7930b638ac71fea35eb69ee3b8d959496beb04a33":
          "100000000000000000000000000000000000000"
      }
    }
  }
}
JSON

{
  "simulationId": 1,
  "gasUsed": 23994,
  "blockNumber": 18175734,
  "success": true,
  "trace": [
    {
      "callType": "CALL",
      "from": "0xd8da6bf26964af9d7eed9e03e53415d37aa96045",
      "to": "0xdef1ca1fb7fbcdc777520aa7f396b4e015f497ab",
      "value": "0x0"
    }
  ],
  "formattedTrace": null,
  "logs": [],
  "exitReason": "Return",
  "returnData": "0x000000000000000000000000000000004b3b4ca85a86c47a098a224000000000"
}

I tried to propose a change to make replace_account_storage public in foundry_evm (https://github.com/foundry-rs/foundry/pull/5861) which would allow this PR to implemented by copy-pasting anvil code instead of using the "lower-level" revm::DatabaseCommit API.

Hey @nlordell, firstly thanks a lot for contributing! 🙏
Makes sense to go down to the revm::DatabaseCommit implementation but I see that your PR (https://github.com/foundry-rs/foundry/pull/5861) was merged and we are open to pointing to the latest Foundry code if you want to open a subsequent PR for that after we get this in?
I've just merged another PR which means there are some small conflicts. Do you mind resolving those please?
Finally, could you update the README to clarify that state_overrides can now be set in the request body and add an integration test into tests/api.rs?
Once these items are closed off super happy to get this in.

if you want to open a subsequent PR for that after we get this in?

This makes the most sense to me. AFAICT there might be some small breaking changes that will affect other code so it makes sense to do it separately.

could you update the README [...] and add an integration test into tests/api.rs?

👍

I've just merged another PR which means there are some small conflicts

Ah, nice - you merged the #[serde(rename_all)] change (I can get rid of my manual renames then 🎉).

@devanoneth - updated the README with the new format and added an E2E test. Let me know if it looks OK.
I also decided to go for "simpler" types to describe the state override object. Alternatively, you could specify it like (if my TS serves me well):
export type StateOverride = {
  balance?: string;
  nonce?: number;
  code?: string;
} & StateOverrideState;

export type StateOverrideState =
  | { state?: Record<string, string>, stateDiff: undefined }
  | { state: undefined, stateDiff?: Record<string, string> }

But I found this harder to grok with little benefit over the current type (which also more closely matches how the type is represented on online documentation - for example Geth RPC documentation).

we are open to pointing to the latest Foundry code if you want to open a subsequent PR

I started down this path, but it quite annoying ATM - it seems like Foundry is half using the new alloy types, some revm specific types, and the old ethers/ethereum_types as well. Its a bit of a mess and annoying to get working; will try to pick this up sometime, but no promises as of yet.

authors: devanoneth nlordell

repo: EnsoFinance/transaction-simulator


text:
🛑 HorizonTimes is down

In b643f49, HorizonTimes (https://times.horizonfx.id) was down:

HTTP code: 502
Response time: 968 ms

Resolved: HorizonTimes is back up in a0d4f1e after 3 minutes.

repo: EnvyxLinzie/times-hzfx


text:
include schema property in route object

Currently the route object only contains the method, url, prefix and the hooks.
https://github.com/Eomm/fastify-overview/blob/140b0ee77c7ac3d6b06a5485337382ec3a4d9244/lib/utils.js#L37-L42
Maybe we can provide a plugin option to optionally get the route schema. Another idea would be, for example, to give a function as a plugin option that transforms the routeOptions object. This would give the user complete control over what is contained in the route object.

Maybe we can provide a plugin option to optionally get the route schema

TBH I can't see the PRO on this feature. This plugin is intended to:

debug the application low-lever structure
provide a solid data structure that can be visualized

The schemas do not have a constant structure, if a dev customizes the schemaController, schemas are not a JSON too, so it would create caos to use the returned data-structure.

Another idea would be, for example, to give a function as a plugin option that transforms the routeOptions object

That indeed is a generic approach that could be useful tho, and if users want the schema (whatever format it is) they could implement by themself

Are you open for a PR for the second approach? Maybe my usecase for this Feature is helpful: I want to use this Plugin to go through my Fastify Application and generate test cases for routes and decorators. To generate valid route test cases I need the validation schemas of the routes

Are you open for a PR for the second approach?

Sure

I want to use this Plugin to go through my Fastify Application and generate test cases for routes and decorators

Wow, I would like to see it in action! Did not think about this use case

Happy to ping you if I have a prototype! I think it could even be a nice feature for the fastify-cli like fastify generate-test-cases

Closed with #96

authors: Eomm matthyk

repo: Eomm/fastify-overview


text:
Fix controller button messages not being sent

At the moment pressing and releasing gamepad buttons doesn't send any data back to UE. With this fix the messages are sent.
However, the triggers on an Xbox gamepad don't seem to work still. The messages send (and I can log them out in UE) but they don't have the same result as connecting a gamepad to UE locally.

Hey there @sheepsteak.
I've been looking into the shoulder issue you brought up in your PR.
I'm unable to reproduce this issue using the latest version of Pixel Streaming found in UE5-Main (https://github.com/EpicGames/UnrealEngine/tree/ue5-main).
I'm not sure what version you were using, and with a refactor recently being completed on how Pixel Streaming handles input from the browser it's likely this issue was fixed then.
Let me know how you go!

Thanks, @Belchy06. They seem to not work in 5.0.3 and earlier. It's like it was mapped to the wrong thing (possibly right shoulder button?).
We tried ue5-main ourselves just now and it looks like it's working as expected 👍🏻

repo: EpicGames/PixelStreamingInfrastructure


text:
Support new Roblox Core UI

Introduce support for the new Roblox Chrome Core UI & its breaking changes to screen insets. A draft for now, to ensure correct behavior & support.

It would be easier than merging a pull

Like the pull can be merged before Roblox enables the feature

hmm

Hmmm

Maybe have a flag in Variables.lua to turn this and the legacy behavior on/off. It would be easier than merging a pull
...
Like the pull can be merged before Roblox enables the feature

??? idk what you're trying to say but this feature is already enabled in A/B testing (you can also force it with a beta feature in Studio). this should be backward compatible too, because that's simply how the new APIs/properties work...

Maybe have a flag in Variables.lua to turn this and the legacy behavior on/off. It would be easier than merging a pull
...
Like the pull can be merged before Roblox enables the feature

??? idk what you're trying to say but this feature is already enabled in A/B testing since Monday (you can also force it with a beta feature in Studio). this should be backward compatible too, because that's simply how the new APIs/properties work...

Then why is this pull a draft?

🥱 moo1210 moment

@moo1210 Btw you could just set ignoreguiinset and set anchor point to .5,0 and set the position to .5,0,0,0

That change accounts for any type of core UI

Why.

repo: Epix-Incorporated/Adonis


text:
Part 1 Step 7 needs to report 0x00 in any byte of CVN

See #156 for details

Alternatively,
6.1.7.2 Fail Criteria
a. Fail if total number of reported CAL IDs is < user entered value for number of emission or diagnostic critical control units (test 6.1.2).
b. For responses from OBD ECUs:
i. Fail if <> 1 CVN for every CAL ID.
ii. Fail if CAL ID not formatted correctly (printable ASCII, padded incorrectly, etc.).
iii. Fail if any received CAL ID is all 0xFFh or any CVN is all 0x00h.
iv. Fail if CVN padded with 16-binary zeros (where either the 1st two bytes are both 00h or the last two bytes both 00h). Note HD OBD CVNs are required to be 32-bits.
6.1.7.3 Warn Criteria
a. Warn if total number of reported CAL IDs is > user entered value for number of emission or diagnostic critical control units (test 6.1.2).
b. Warn if more than one CAL ID and CVN pair is provided in a single DM19 message.
c. For responses from OBD ECUs, warn if 00h is observed in either the first or fourth bytes.
d. For responses from non-OBD ECUs:
i. Warn if any non-OBD ECU provides CAL ID.
ii. Warn if <> 1 CVN for every CAL ID.
iii. Warn if CAL ID not formatted correctly (contains non-printable ASCII, padded incorrectly, etc.).
iv. Warn if any received CAL ID is all 0xFFh or any CVN is all 0x00h.
v. Warn if CVN padded incorrectly (must use 0x00h in MSB for unused bytes).

In order keep track of all the moving parts on this project, I try to keep the changes to the 'document' in tickets which are separate from the 'code' tickets.  This is one such case. Currently the code matches the document as supplied "originally",   #156 is a ticket to update the document; this ticket is to update the source code (so we remember to do both)
At this time, I have this issue marked as "future enhancement" indicating that we are not planning to implement this change in the current release of the software.  It's believe this can wait for the "NOx Binning" changes in V4 of the software.
@ericthomasswenson, do you concur with that?

The SOW text should define the current intent.
Revisit after the next release.

authors: ericthomasswenson gumbelmj


text:
Fix #1276

@battjt

wrong branch


text:
Is there an independent and repetitive simulation for each pair of ligands?

Have you evaluated stability?

For this paper, we only did one calculation for each pair due to the large number of pairs in total. We have used ATM for a while now and the algorithm is quite stable.  When the ATM simulation crashes,  it is mostly because of inappropriate system preparation or the mismatched ligand atom index in the ATM control file.

Thank you.


text:
新版界面移动端饰品价格详情错误

最低寄售价和最高求购价反了。寄售价比求购价还低

感谢反馈！线上版本已修正该问题，文档图例预计近期修正。

文档图例已修正


text:
OpenSSL 1.0.2 update causes unresolved symbols on iOS/armv7 + darwin

OpenSSL has been updated from version 1.0.1h to 1.0.2 in commit 3f34e4bb8c50ea4286cc142e202ccd48be9e8d0b.
Unfortunately, 1.0.2 does currently not compile on armv7 (iOS) due to unresolved symbols in the openssl linking step. This is probably a OpenSSL issue, but I have filed it here just for consistency.
To work around this issue, the above commit can be reverted so that 1.0.1h is used for armv7.
Problem also occurs on OS X.

Can you paste the error messages, plus some lines above?

I hit what might be this problem on OS X (bunch of undefined symbols in the linking step) -- wiping out the source directory and rebuilding fixed it.

I'm seeing this on armv7s - https://gist.githubusercontent.com/ford-prefect/0ede4650aa86e1807363/raw/8bf46b90c08689ce3f09700ec365140813bdcbe0/openssl-compile.log

The error messages are identical to those posted by ford-prefect.

I've got a fix for this at https://github.com/nirbheek/cerbero/pull/12 -- not merging it directly because I'd like to make sure the openssl patch looks okay to push upstream as well

Update: problem also occurs on OS X.

This is fixed in the Cerbero build thanks to @ford-prefect's patch.

I'm getting OpenSSL build issues again after updating yesterday. So are others: https://github.com/EricssonResearch/openwebrtc/issues/233#issuecomment-83256448 I checked the config.log and it showed that the check for SSL_library_init failed due to unresolved symbols. Are we really sure it is linking against the correct OpenSSL?

The cause: We're no longer using the pkgconfig patch, and the autoconf just does -lssl (and not -lcrypto). On static builds, -lcrypto is not pulled by dependency, and that's why autoconf fails.
https://github.com/nirbheek/cerbero/commit/5eae63059643751862534a7a1053129245c001e2 should fix this by removing OpenSSL dependency entirely.

@superdump, could you test this and see if the problem has gone away?

I rebuilt on my laptop just now and it seems to be fine. @ijsf do you still see this or is this OK to close?

@superdump, unfortunately this is still happening on my system. Log: https://gist.github.com/ijsf/65fc28c9fc01c9559f3b
Not sure why this is happening.

@ijsf do you still see this or can we close it?

Reopened as this is still not fixed on OS X...

Does building from scratch work?

Strangely enough the problem seems to have fixed itself after a ./cerbero-uninstalled wipe. Apparently removal of the sources directory is not enough.

Still having issues, I've narrowed it down to the following:
./cerbero-uninstalled -c config/darwin-x86_64.config buildone openssl fails at building OpenSSL.
./cerbero-uninstalled buildone openssl succeeds at building OpenSSL.

authors: ford-prefect ijsf ikonst nirbheek sdroege superdump

repo: EricssonResearch/openwebrtc


text:
misprint: Ice controlling mode is not under control

https://github.com/EricssonResearch/openwebrtc/blob/master/transport/owr_transport_agent.c#L559
missprint: the second separator is underscore.

If you mean that first it says 'ice-controlling' and then 'ice_controlling'
I've learned that that is actually correct.
On Mon, Oct 17, 2016 at 2:10 PM, Dmitry Zhadinets notifications@github.com
wrote:

https://github.com/EricssonResearch/openwebrtc/blob/master/transport/owr_
transport_agent.c#L559
missprint: the second separator is underscore.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/EricssonResearch/openwebrtc/issues/650, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABICrmmkLxCE1lV0G2M4uxKmQEAI5yjPks5q02W-gaJpZM4KYjGU
.

I mean ... "ice-controlling_mode" ... . It should be "ice-controlling-mode"
Because during init it binds NiceAgent property to this one
https://github.com/EricssonResearch/openwebrtc/blob/master/transport/owr_transport_agent.c#L450
where
g_object_bind_property(transport_agent, "ice-controlling-mode", priv->nice_agent,
"controlling-mode", G_BINDING_SYNC_CREATE);

I mean ... "ice-controlling_mode" ... . It should be "ice-controlling-mode"
Because during init it binds NiceAgent property to this one
https://github.com/EricssonResearch/openwebrtc/blob/master/transport/owr_transport_agent.c#L450
where
g_object_bind_property(transport_agent, "ice-controlling-mode", priv->nice_agent,
"controlling-mode", G_BINDING_SYNC_CREATE);

I think you are 100% right!
On Tue, Oct 18, 2016 at 9:17 AM, Dmitry Zhadinets notifications@github.com
wrote:

I mean ... "ice-controlling_mode" ... . It should be "ice-controlling-mode"
Because during init it binds NiceAgent property to this one
https://github.com/EricssonResearch/openwebrtc/blob/master/transport/owr_
transport_agent.c#L450
where
g_object_bind_property(transport_agent, "ice-controlling-mode",
priv->nice_agent,
"controlling-mode", G_BINDING_SYNC_CREATE);
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/EricssonResearch/openwebrtc/issues/650#issuecomment-254426471,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABICrlWOZ-1Hte8yFBLCJzPn9NRlZ-z5ks5q1HKJgaJpZM4KYjGU
.

authors: dzhadinets stefhak


text:
When matching on Windows, incorrect paths are returned

I'm using pattern like C:\nuke** (or C:/nuke/** - it doesn't matter, the bug still happens).
When running on Windows, I iterate through paths and if there is only top level, like in pattern above, I get incorrect paths where the first letter of top-level directory:
C:/uke/CustomMergeBlue.gizmo
C:/uke/CustomGizmo.gizmo
etc.
If it's C:/nuke/plugins/**, the paths are correct, i.e. the top-level directory doesn't have first letter removed.

Please provide code that shows the problem and I'll reopen the issue. Eg:
System.out.println(new Paths().glob("C:\\", "nuke**"));

I'm sorry - I see it's fixed, I had older version of the library.

authors: NathanSweet grzegorzgoldapl

repo: EsotericSoftware/wildcard


text:
Unexpected margin below Switch component

There appears to be 1.55rem of margin added to the bottom of Switches, is this intended? I'm trying to center the switch vertically but it there's that 1.55rem of margin that keeps it from lining up correctly.

I tried creating a styled component for the Switch but changing the margin on that only changes the margin on the child checkbox.
The switches in the docs have the same margin below them if you want to check those out

I'm seeing that the margin comes from the baseline variable in CalciteTheme.js. Is there an easier way to override just the margin or will I have to override the entire theme?

repo: Esri/calcite-react


text:
Clearification regarding "resampling" in wiki needed

In the documentation on the wiki page of this repo in the section  updateRasterInfo() there are some information about the keyword "resampling". I've been playing a little with this parameter while trying to to get a python raster function to behave as we want. I've a few questions regarding this parameter.

Should the parameter name be "Resampling" instead of "resampling"? Using kwargs['output_info']['Resampling'] = False has some effect but not kwargs['output_info']['resampling'] = False
The documentation says that the default value of resampling is False but I've the experience of the opposite. I'm aware of the 'inheritProperties' and 'invalidateProperties' parameters of get configuration. But I'm not able to configure those so that False becomes the default value of 'Resampling'.
In getConfiguration() i've found that adding a keword of "Resampling" or "resampling" has effect on kwargs['output_info']['Resampling'] in  updateRasterInfo() . What is the effect of setting this paramter to True/False? Is it the same as changing it in

On the wiki page I also founds some information regarding selectRasters(). But I can't trigger this to run. Is it possilbe to get it to run on a single raster dataset?

@simjoh please see below:

The keywork is “resampling” only. It's suggested to set this property in .getConfiguration() as well as .updateRasterInfo().
As per the code, it seems like if the property is set in .getConfiguration() you don’t need to set the property in .updateRasterInfo(). It should already have the correct value. Setting the property only in .updateRasterInfo() may not work as expected.
If this doesn’t work, please share your py script with us and so we can take a look.
The default value is False. Probably #1 above is affecting your workflow.
Please see 1 – the resampling flag is read from the properties returned by .getConfiguration() and then passed along to .updateRasterInfo().

@shenganzhan Thanks for your input. I've changed the code by  setting resampling in getConfiguration(). But If it is suggested to set the propery in .getConfiguration() and updateRasterInfo(), then I think 'Resampling' is needed in updateRasterInfo.
Regarding default property my exceprience with the current dataset is that the default is False. Maybe it is a property of the dataset but I try to ovverride inheritence of properties by
'inheritProperties': 1,#
'invalidateProperties': 1| 2 | 4 |8,      # invalidate histogram and statistics because we are modifying pixel values

In my first post I also mentioned the method -selectRasters() how do I use that. I don't get it to run in my prf.

@simjoh selectRasters works on multiple raster inputs

authors: shenganzhan simjoh

repo: Esri/raster-functions


text:
Finish auto-book program

Introduction
The auto-book program enables us to schedule a meeting room at CSUF.
Steps

[x] Log in
[ ] Check if bookings are able to be created
[ ] Create a booking at a valid date and time
[ ] Screenshot and log the result
[ ] Profit

https://titans.service-now.com/library/library_catalog.do

TODO: Rewrite in Deno Astral.

repo: EthanThatOneKid/auto-book

license: WTFPL


text:
SVG text not parsed correctly in Delphi 10.4

After upgrading a project from Delphi 10.1 to Delphi 10.4.2 we noticed that the svg text of certain icons was not parsed correctly anymore. It looks like css style classes are ignored. For example the following text produces an icon in 10.1 and a black square in 10.4.2:
<?xml version="1.0" `encoding="utf-8"?>
<!-- Generator: Adobe Illustrator 25.2.0, SVG Export Plug-In . SVG Version: 6.00 Build 0)  -->
<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
	 viewBox="0 0 21 21" style="enable-background:new 0 0 21 21;" xml:space="preserve">
<style type="text/css">
	.st0{fill:none;stroke:#324E83;stroke-linecap:round;stroke-linejoin:round;stroke-miterlimit:1;}
	.st1{opacity:0.5;fill:none;stroke:#324E83;stroke-linejoin:round;stroke-miterlimit:1;enable-background:new    ;}
</style>
<path class="st0" d="M16.3,19.5v-18H1.5v18H16.3z"/>
<path class="st1" d="M5.2,12.8H4.1 M3.1,12.8H2 M7.3,12.8H6.2 M9.4,12.8H8.4 M11.5,12.8h-1.1 M13.7,12.8h-1.1 M15.8,12.8h-1.1
	 M12.1,6.5v1.1 M12.1,4.3v1.1 M12.1,2v1.1 M12.1,8.8V10 M12.1,11.1v1.1 M12.1,13.4v1.1 M12.1,15.6v1.1 M12.1,17.9V19"/>
</svg>

Take care of the engine you are using. Into SVGIconImageList.inc you can switch between native TSVG engine or Prefer Direct2D engine. This icon is rendered only with native TSVG Engine, the blank square is visible using Direct2D.
You must remove this directive {$DEFINE PreferNativeSvgSupport} to use TSVG engine.

Ah thank you for the reaction. We will look into switching engines.

repo: EtheaDev/SVGIconImageList


text:
安装是出现”nginx 无法执行“错误

[root@******** ~]# curl https://raw.githubusercontent.com/EtherDream/jsproxy/0.1.0/i.sh | bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5435  100  5435    0     0  32267      0 --:--:-- --:--:-- --:--:--  758k
[jsproxy 22:52:27] 自动安装脚本开始执行
[jsproxy 22:52:27] 切换到 jsproxy 用户，执行安装脚本 ...
[jsproxy 22:52:27] 下载 nginx 程序 ...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 10.6M  100 10.6M    0     0  1153k      0  0:00:09  0:00:09 --:--:-- 1222k
[jsproxy 22:52:37] /home/jsproxy/openresty/nginx/sbin/nginx 无法执行！尝试编译安装
[jsproxy 22:52:37] 安装完成。后续维护参考 https://github.com/EtherDream/jsproxy

如果执行手动安装，在make install的时候报了以下错误。
....
configure: error: Invalid C++ compiler or C++ compiler flags
make[2]: *** [/tmp/tmp.rlj3kVR1PK/openresty-1.15.8.1/../pcre-8.43/Makefile] 错误 1
make[2]: Leaving directory `/tmp/tmp.rlj3kVR1PK/openresty-1.15.8.1/build/nginx-1.15.8'
make[1]: *** [build] 错误 2
make[1]: Leaving directory `/tmp/tmp.rlj3kVR1PK/openresty-1.15.8.1/build/nginx-1.15.8'
make: *** [all] 错误 2

不知道要如何解决这个问题。
如果自行yum install nginx再和 jsproxy 关联起来，不知道是不是可行呢？

cc指令没了，ln链接一下gcc

試一下安裝 g++
apt install g++ || yum install g++

authors: McDull-GitHub h5mcbox undeadway

repo: EtherDream/jsproxy


text:
js和css无法加载

你的演示站可以加载js和css，但源码搭建的不行。
是不是还有什么配置调整了但源码里没有反馈出来

被代理页面的 JS 和 CSS 无法加载吗？

是的。
测试站 proxy.liyunbin.com

把服务端 nginx.conf 里的 http2 选项关闭再试一下？我发现有些 js 文件的请求会报错：
* HTTP/2 stream 1 was not closed cleanly: INTERNAL_ERROR (err 2)
* Closing connection 0
* TLSv1.2 (OUT), TLS alert, Client hello (1):
curl: (92) HTTP/2 stream 1 was not closed cleanly: INTERNAL_ERROR (err 2)

被代理页面的 JS 和 CSS 无法加载吗？

冤枉作者了，原来的测试在一个俄罗斯的VPS，版本 CentOS Linux release 7.6.1810 (Core)
换了一个美国的VPS，版本 CentOS Linux 7.2.1511 (Core)，没有问题了，不知道作者有没有兴趣拿那个VPS探究一下。

authors: EtherDream vitoland


text:
Кнопка в тулбаре в новостях и галерее

Неправильно отображаемая кнопка в тулбаре этих экранов. Нужно заменить ее на что-то.

Исправлено.

repo: Ethosa/KTC


text:
Skip Language Files

Is possible to skip some php language files ?

In current version(2.0.4) does not provide this functionality, but it may change in the next releases.

authors: EugeneMeles fatoskurtishi


text:
How to resize pane in Terminus?

Could terminus support pane resize

Just drag the border between the panes to either side

authors: DevelooperQ Eugeny

repo: Eugeny/terminus


text:
Focus on terminus instead of hide it

Windows 10 x64 Version 2004 Build 19041 Insider Preview - Release
I have few monitors and when I open terminus on one of my monitors but focus on some other program (Google Chrome) on other and I press "Toggle terminal window" hotkey - it hides Terminus instead of just focus it.

Should be fixed by now - please test the latest release.


text:
SSH Connection to different hosts in the same terminal window (Split)

Is it possible for a new SSH connection to start on a split terminal? I want to split one terminal and have multiple different SSH connections in it.

Actually. This is more general. When splitting a window the new terminal gets the same type of window as the original one. If it was ssh it creates another ssh pane into the same server. This looks convenient but it is limited. Split should accept an option to open a new pane with either a regular profile or ssh profile selected.


text:
Feature/task 12/dz1 table

добавив перше завдання

Якщо зображення не використовується у файлі то його потрібно видалити

authors: Evan-Kork nesmeyanov


text:
-bash: expo: command not found

Dear Evan,
After cloned and installed npm when I run the command expo start --web in Terminal, I am getting error like expo command not found.
In Package.json the scripts are like this,
"scripts": {
"start": "expo start",
"android": "expo start --android",
"ios": "expo start --ios",
"web": "expo start --web",
"build": "expo build:web",
"eject": "expo eject",
"test": "jest --watchAll",
"update-webpack-config": "cp -r ../../expo-cli/packages/webpack-config/ node_modules/\@expo/webpack-config/",
"deploy": "netlify deploy --prod --dir web-build"
},
What I'm doing wrong here? Pls suggest. Thank you in Advance!

Sorry it was a Permission issue.
Issue resolved by adding,
mkdir ~/.npm-global
npm config set prefix '~/.npm-global'
export PATH=~/.npm-global/bin:$PATH
Thank you :)

repo: EvanBacon/Lego-Expo


text:
How to FaceFormer output arkit blendshape coefficient instead of vertices?

The work is remarkable.
How to FaceFormer output arkit blendshape coefficient instead of vertices? Very Thanks.

If faceformer supports arkit-blendshape-coefficient output, it can support other 3D templates.

@youngstu Did u get a way to do this? I got some problem

The work is remarkable. How to FaceFormer output arkit blendshape coefficient instead of vertices? Very Thanks.

Hi, for the current model, the output representation is vertex positions. The training datasets we used do not contain the blendshape coefficients ground truth, so the model was not able to learn such information during training.  I guess some other techniques based on inverse graphics may be required to convert the vertex positions into 51 blendshape coefficients.

The work is remarkable. How to FaceFormer output arkit blendshape coefficient instead of vertices? Very Thanks.

Hi, for the current model, the output representation is vertex positions. The training datasets we used do not contain the blendshape coefficients ground truth, so the model was not able to learn such information during training. I guess some other techniques based on inverse graphics may be required to convert the vertex positions into 51 blendshape coefficients.

I want to know if i have the blendshape coefficients groud truth, why in the render video, the lip animation is not evident

@youngstu Did u get a way to do this? I got some problem

what's problem did you encounter, and  did you solve it

@zhaiyuan0217 not yet, did u able to get 51 blendshapes ?

@zhaiyuan0217 not yet, did u able to get 51 blendshapes ?

we have blendshapes with our data, after traing the model with our data and blendshapes, the rendered video is not well, but traing the model with vertices, the rendered video is well.

@zhaiyuan0217 Hi, what do u mean training the model with vertices

@zhaiyuan0217 not yet, did u able to get 51 blendshapes ?

we have blendshapes with our data, after traing the model with our data and blendshapes, the rendered video is not well, but traing the model with vertices, the rendered video is well.

i have same question

May I ask how you create your own dataset? Can you be specific? Thank you！ @zhaiyuan0217 @xiaodongyichuan

@zhaiyuan0217 not yet, did u able to get 51 blendshapes ?

we have blendshapes with our data, after traing the model with our data and blendshapes, the rendered video is not well, but traing the model with vertices, the rendered video is well.

Did you solve this problem? I also trained with wav and blendshape data, and the final driving effect is that the mouth basically does not open

I was trying to train on DECA expressions but the mouth is not moving when rendering the result.

repo: EvelynFan/FaceFormer


text:
Fix creation of literal columns

Describe the bug
Creation of a literal column breaks:
df = DataFrame.from_pydict({"foo": [1, 2, 3]})
df.with_column("lit_col", lit(1))
df.collect()

Fixed in #445

repo: Eventual-Inc/Daft


text:
Dynamically adding rows?

Is your feature request related to a problem? Please describe.
Hey! First off just wanna say this is an awesome project! Its super useful for my ml workflows. However, for some usecases I want to ingest and add new data (rows) while also using daft to query + apply functions on a combination of the old data + the new data. Not sure if I missed it in the docs, but is that usage available right now in daft? Thanks!

Thanks @shyamsn97! Keep letting us know how we can make Daft more useful for you :)
We don't have this function right now, but I think we will want to add an API to do a "row-wise join".
df1.concat(df2)
Under the hood we actually already have a lot of this functionality built out on our underlying Table datastructure, but we need to expose this on the DataFrame level.
Would this help your use-case here? Something like:
df = daft.read_csv(...)
additional_data = daft.from_pydict({"foo": [1, 2, 3]})
df = df.concat(additional_data)

The tricky bit here is when concatting, we'll need to make sure that the schemas of both DataFrames match up, or perform some kind of schema resolution (essentially, casting the schema of the incoming dataframe to the source of truth dataframe, or throwing an error if this cannot be achieved).
Let me know what you think!

This would be perfect! Exactly what I’m looking for

Thanks so much, looking forward to it!
And likewise, great to see you’re doing awesome stuff 🙂

Implemented in: https://github.com/Eventual-Inc/Daft/pull/1023


text:
tidy up

A general tidy up the repo, putting files in various sensible directories.

okayed by @seimtpow

repo: ExCALIBUR-NEPTUNE/NESO-UQ


text:
Updating the environments.

I was testing our environments and I found some missing things.

@bourque Does this look like the same issue you were having with the travis build?

repo: ExoCTK/exoctk


text:
feat: linter mode (WIP)

Usage example:
const { validator } = require('@exodus/schemasafe')
const fs = require('fs')
const path = require('path')

const dir = 'schemas/json'
const files = fs.readdirSync(dir).sort().map(x => path.join(dir, x))
const schemas = files.map(x => [x, JSON.parse(fs.readFileSync(x, 'utf-8'))])

for (const [name, schema] of schemas) {
  try {
    //validator(schema, { requireValidation: true  })
    const errors = validator(schema, { lint: true })
    for (const e of errors) {
      console.log(name, ': ', e.message)
    }
  } catch (e) {
    console.log(name, ': ', e)
  }
}

Codecov Report

Merging #160 (b27904b) into master (b5450e8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Files Changed
Coverage Δ

src/compile.js
99.55% <100.00%> (+<0.01%)
:arrow_up:

src/index.js
100.00% <100.00%> (ø)

authors: ChALkeR codecov-commenter

repo: ExodusMovement/schemasafe


text:
IOU - No "Decline" button appears next to each of the report requests

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to URL https://staging.new.expensify.com/
Log in HT account
Navigate to a conversation with a user that you don't have any past IOUs.
Complete the request money flow and send three payment requests, varying the length of the input string, to another account you have access to
Log-in to the other account and click the view details button on the request in the DM
Verify that the decline button is alongside the two expenses on the IOU

Expected Result:
"Decline" button should be appear next to each of the report requests
Actual Result:
No "Decline" button appears next to each of the report requests
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.11.2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/236636866-349883be-817f-49a1-b5ab-e0029b4128fc.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

This seem to done by design on this PR

Thanks @Natnael-Guchima - I agree this looks expected - I'll remove DeployBlockerCash and ask @luacmartins if you can confirm that this is now expected? If yes let's get testrail updated

@vitHoracek confirmed this is the expected behavior now - @kbecciv can you make a note to remove this from testrail? I believe there will be lots of new checklist items once the "Manual requests" project is completed (cc @luacmartins @Julesssss )

@luacmartins Please submit a "QA - Add/Update test to TestRail" ticket.

authors: Beamanator Natnael-Guchima OSBotify kbecciv

repo: Expensify/App


text:
[$1000] Web - Login - "Incorrect magic code" error if click "Go back" in 2FA input page

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:
Precondition - User has setup a 2FA to log into account

Open https://staging.new.expensify.com/

Input email for account from the precondition

Click "Continue"
4.Input magic code

Click "Continue

Click "Go back"

Expected Result:
User lands in login page with no errors
Actual Result:
User lands in login page with an error about incorrect magic code displayed - "Incorrect magic code. Please try again or request a new code".
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.19-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://platform.applause.com/services/links/v1/external/3596f7837798799b4e8a1c4b5c79788313ea4432330c560a05b867dc2b19bb3c

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0117c06543ed99c789
Upwork Job ID: 1663137767104331776
Last Price Increase: 2023-05-29

Hello team I just wanted to let you know I originally reported this issue here on slack.

Reproduced.

I can fix this bug. Let's discuss more detail.

I am reassigning this due to me going on extended leave.

Thanks @rushatgabhane! I agree that the proposal looks good!

@luacmartins @rushatgabhane Seems this issue is similar.

No problem @rushatgabhane - let's leave it a daily for the moment just so the priority is still correct, but noted that it won't be completed until next week

@rushatgabhane just a reminder to complete the checklist this week when you get a chance - thanks!

@rushatgabhane thanks for completing the checklist!
Happy to switch this to a weekly. Just a note on that — that means I won't be checking this issue every day, so if you can ping here once the new payment method is ready to go, I'll get that payment processed ASAP.

Awesome — OK, we can close this out, thanks everyone!

authors: JavSFDev Nathan-Mulugeta avi-shek-jha bfitzexpensify kavimuru luacmartins tgolen


text:
[Hold App#20404] [$1000] Web - emoji picker hides on resize window

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to any chat
Open emoji picker
Resize window (<800)

Expected Result:
Emoji picker should not hide
Actual Result:
Emoji picker hides
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.30-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/2f5def1a-4ab0-4b3a-8240-d1535260159b
https://github.com/Expensify/App/assets/93399543/26dbee70-cfa6-4dde-9a1b-8058eb9eec6e
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687410686033509
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01004df42b8a89b793
Upwork Job ID: 1674401243450486784
Last Price Increase: 2023-06-29

Proposal
Please re-state the problem that we are trying to solve in this issue.

When resizing the browser window, the emoji picker closes. When moving from small width to large width and vice versa.

What is the root cause of that problem?

The cause is that the emoji picker unmounts when the window is resized, this happens due to the PopoverWithMeasuredContent used in EmojiPicker.
The isContentMeasured state is set to false when the window is resized, which causes the emoji picker to unmount.

What changes do you think we should make in order to solve the problem?

We can add a local variable in EmojiPickerAction file like activeType and a function like setActiveType to set the active type and getActiveType to get the active type.
The activeType could vary depending on use case like COMPOSE for emoji button from composer input and if from AddReactionBubble which is down at chat can have REACTION_BUBBLE_${reportActionId}. Now whenever we call showEmojiPicker from any of this places we pass actionType and set it in the file.
Thus after resizing the window the Composer Emoji Button or The Reaction Bubble re-mounts and then we can check if getActiveType() is same then we call their own showEmojiPicker function.

 Code Changes Explaination:

We need to add a local variable in EmojiPickerAction file like activeType and a function like setActiveType to set the active type and getActiveType to get the active type.
Now we set activeType in showEmojiPicker to provided type from params and also set it to null in hideEmojiPicker function.
We also need to set activeType to null in EmojiPicker's hideEmojiPicker function.
Now we need to add a useEffect in EmojiPickerButton to check if the activeType is 'COMPOSE' then call showEmojiPicker function. (Dependencies of useEffect will be empty as we only want to call it once)
Now we need to add a useEffect in AddReactionBubble to check if the activeType is ADD_REACTION_BUBBLE_${props.reportAction.reportActionID} then call the showEmojiPicker function. (Dependencies of useEffect will be empty as we only want to call it once)

Note: I am still not able to fix the picker closing issue for MiniQuickEmojiReaction. (Will try to fix that.)

 Fixed Video
https://github.com/Expensify/App/assets/78416198/f7b2616c-662b-44f4-b2ef-77fc877c8d9f

What alternative solutions did you explore? (Optional)

N/A

Was able to recreate, so going to get eyes on the two proposals above

@abdulrahuman5196 To be honest, I have been out the last two months, so wasn't sure about this change. But no worries. Can you reference where the conversation was had about not prioritizing these issues, so I can take a look?

I was ooo this week. We got couple of problems raised which are tied to the fact the navigators unmount and mount again when resizing.
In case of this one i think we should close this and do nothing in this issue. We will be discussing with SWM if there is a way to find an updated way to handle the navigators so we do not change between them which would be the root cause solution rather than solving all the symptoms of the updated architecture.
cc @adamgrzybowski @WoLewicki

Currently working on the solution for resizing without remounting navigators.

Same issue on this https://github.com/Expensify/App/issues/22196

Removing the Help Wanted so people dont spend time on the proposals. I believe this should be fixed once Adam implements the change to how resize is implemented.

@adamgrzybowski is still owrking on the styling solution without remounting

This is on hold and can be weekly

On hold

No update yet 👍

Heading OoO until 8/14 so re-assigning BZ to keep an eye on it while I'm out 👍

Still on hold makin gthi monthly

This is fixed partially (from large to small)
But problem persists from going small to large

Thanks @shubham1206agra updated the instructios

@mountiny I have found the problem and will post a solution tomorrow.
I need to check for regression in my solution.

Proof
https://github.com/Expensify/App/assets/58412969/b2de6616-e5e0-4e15-8107-ed826536eae2

Thank you @shubham1206agra
Just to note status, We are waiting on proposal on this issue

Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - emoji picker hides on resize window
What is the root cause of that problem?
In
https://github.com/Expensify/App/blob/ebcc8d045695871d8189a6335c6cdfeede657deb/src/components/PopoverProvider/index.js#L105-L107
We are checking for equality for ref instead of content cause multiple Popovers may have the same content (for example - EmojiPicker in different places).
But here
https://github.com/Expensify/App/blob/ebcc8d045695871d8189a6335c6cdfeede657deb/src/components/Popover/index.js#L30-L33
We are unmounting the PopoverWithoutOverlay when going to the small screen width config and remounting when going out of the small screen width config. This will destroy the ref and re-create in this cycle. This causes the equality to become false, thus closing the popover.
What changes do you think we should make in order to solve the problem?
Take the ref out of
https://github.com/Expensify/App/blob/ebcc8d045695871d8189a6335c6cdfeede657deb/src/components/PopoverWithoutOverlay/index.js#L13
to the
https://github.com/Expensify/App/blob/ebcc8d045695871d8189a6335c6cdfeede657deb/src/components/Popover/index.js#L13
and pass it as a prop in
https://github.com/Expensify/App/blob/ebcc8d045695871d8189a6335c6cdfeede657deb/src/components/Popover/index.js#L30-L33
like this
createPortal(<PopoverWithoutOverlay {...props} withoutOverlayRef={refWithoutOverlay} />, document.body);

What alternative solutions did you explore? (Optional)
We can disable the withoutOverlay, but this is not recommended.

@CortneyOfstad  I'm off this week, can you please keep 👀 on this then I'll snag it back on Monday?  Thx

@mallenexpensify of course! No worries!

@abdulrahuman5196 Thoughts on the proposal above?

@abdulrahuman5196 lets triage the proposals now please

Thanks @CortneyOfstad for 👀, unassigning.

Reviewing now

@shubham1206agra The solution is working.
But I am not sure if the root cause is correct. I tried to put console logs and the popover is not closing at the mentioned pointer.
https://github.com/Expensify/App/blob/ebcc8d045695871d8189a6335c6cdfeede657deb/src/components/PopoverProvider/index.js#L105-L107

We are checking for equality for ref instead of content cause multiple Popovers may have the same content (for example - EmojiPicker in different places).

@abdulrahuman5196 it's really hard to check using console.log cause ref gets updated quickly

@abdulrahuman5196 it's really hard to check using console.log cause ref gets updated quickly

@shubham1206agra We have to confirm on the root cause. If we don't confirm the root cause, for worst case the code be fix which could break later.
Or could you let me know how you verified and arrived at the root cause so that I could try to understand the same.

Just put a trace on hideModal method. Maybe that will help

@abdulrahuman5196 how is this one looking?

Bump @abdulrahuman5196

Friendly bump @abdulrahuman5196

asking for a proposal review in slack

Just an update. On last check, the solution was working fine and theoritically correct but hard to verify the root cause. I will try today again on root cause and post update accordingly.

Reviewing now again.

@shubham1206agra 's proposal here https://github.com/Expensify/App/issues/21560#issuecomment-1705301225 looks good and works well. I was able to re-confirm the root cause as well atlast.
🎀 👀 🎀
C+ Reviewed
cc: @mountiny

@mountiny Please assign here

Pending on @mountiny 's review here

Assigned, thanks!

@mountiny Kindly assign me as well C+ here

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

IMO not a regression from a single change. This is something which wasn't working after navigation refractors.

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Go to any chat
Open emoji picker
Resize window (<800)
Resize the window to a wider view

@mallenexpensify

Lets make that regression test

Issue created here https://github.com/Expensify/Expensify/issues/326639

Thanks @mountiny !
Issue reporter: @gadhiyamanan due $250 via Upwork
Contributor: @shubham1206agra paid $750 via Upwork, inc. urgency bonus.
Contributor+: @abdulrahuman5196 paid $750 via Upwork, inc. urgency bonus.
@gadhiyamanan, I needed to create a new job to pay you, can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~0105078349f662f2d1

@mallenexpensify offer accepted, thanks!

Thanks @gadhiyamanan
I updated my comment above to denote you've been paid!

authors: CortneyOfstad abdulrahuman5196 adamgrzybowski gadhiyamanan jeet-dhandha kbecciv mallenexpensify mountiny shubham1206agra


text:
[$500]  WS - Members - 'Invite' button cannot be selected using a key combination unlike previous page

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.80-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com or open Desktop App
Login with expensifail account
Open existing or create new workspace
Go to Workspace > Members
Click 'Invite' button
Select some users with 'Enter' key
Press CMD+ENTER to go next to page 'Add message'
On 'Add message' page press CMD+ENTER

Expected Result:
'Invite' button pressed, flow completed
Actual Result:
Nothing happens. The button 'Invite' cannot be pressed using a key combination.
It can only be clicked using a mouse/touchpad
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop
https://github.com/Expensify/App/assets/78819774/1cb73807-11be-46fb-8a18-a6a37eb472c5

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b7a282bd0ebe6183
Upwork Job ID: 1718925423033479168
Last Price Increase: 2023-11-06

reviewing today!

Sorry, Money2020 had me pulled away. I'm reviewing this now!

Proposal
Please re-state the problem that we are trying to solve in this issue.

WS - Members - 'Invite' button cannot be selected using a key combination unlike previous page

What is the root cause of that problem?

We are not handling events clicking on CTRL+ENTER in WorkspaceInviteMessagePage

What changes do you think we should make in order to solve the problem?

In other page, like NewTaskPage, pressing on ENTER button will submit the form. We can do it by using FormAlertWithSubmitButton with param disablePressOnEnter: false.
https://github.com/Expensify/App/blob/18c219f490885e14e6eac747406675bcc3389012/src/pages/tasks/NewTaskPage.js#L205
And the Button used in the FormAlertWithSubmitButton has a logic that subscribe clicking ENTER event.
https://github.com/Expensify/App/blob/18c219f490885e14e6eac747406675bcc3389012/src/components/Button/index.js#L171-L179

So with the CTRL+ENTER event, we can also subscribe the event CTRL+ENTER in the Button and create the pressOnCtrlEnter to check should we handle event CTRL+ENTER or not.

Then, in WorkspaceInviteMessagePage, set pressOnCtrlEnter: true

Other sections need trigger CTRL+ENTER just set pressOnCtrlEnter: true  as well.

What alternative solutions did you explore? (Optional)

NA

@rushatgabhane to review proposal ^

bump @rushatgabhane

reviewing

c+ reviewed 🎀 👀 🎀
i like @DylanDylann's proposal.

nice! seems we agree - let's get that PR up @DylanDylann! 🙌

@dylanexpensify yeah, I am working on it

@rushatgabhane PR https://github.com/Expensify/App/pull/31341 is ready to review

woot! bump @rushatgabhane! Nice work @DylanDylann !

payment coming!

Payment summary:

Contributor: @DylanDylann $500
Contributor+: @rushatgabhane $500

Please apply here!

bump @DylanDylann @rushatgabhane

Thanks for your remainder

Payment summary:

@dylanexpensify I've applied, thanks 🙏

Manual request here - https://staging.new.expensify.com/r/1763218076515618

Perfect! Paying out today!

offer sent @DylanDylann !

$500 payment approved for @rushatgabhane based on this comment.

all done

authors: DylanDylann JmillsExpensify dylanexpensify lanitochka17 rushatgabhane


text:
Android & iOS - Attachment - App crashes when closing attachment while it is loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

**Version Number:**1.4.25-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Issue found when executing PR https://github.com/Expensify/App/pull/33643
Action Performed:

Go to any chat
Upload a PDF file
After uploading, open the file
Tap back button while the file is still rendering

Expected Result:
App does not crash
Actual Result:
App crashes
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/8e05e4e4-5685-47fd-a1c4-54c19fd0f6d0
logs.txt
View all open jobs on GitHub

Being fixed here https://github.com/Expensify/App/pull/34513

Fix CPed. Closing this issue.


text:
[$500] Task - The assignee ">" arrow is not grayed out when creating tasks offline

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.32-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Open a chat
Navigate to offline mode
Go to the assign task, enter the title, and complete the flow
Click on the task and hover over the assignee

Expected Result:
The Assignee and arrow should be grayed out when creating tasks offline
Actual Result:
The assignee ">" arrow is not grayed out when creating tasks offline
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/f9d4d899-fd01-4d15-ab85-dd922436a9ba
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c0e46b804f5e69b6
Upwork Job ID: 1750639313882955776
Last Price Increase: 2024-01-25

We think that this bug might be related to #vip-vsp
CC @quinthar

@fedirjh can you please complete the checklist above?

Payments made, just waiting on checklist.


text:
[$500] Web - Thread - Console error ERR_FAILED 404 shows up when opening thread

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.51-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Action Performed:

Go to staging.new.expensify.com.
Go to any chat.
Send a message.
Right click on the message > Reply in thread.

Expected Result:
No console error will show up.
Actual Result:
Console error ERR_FAILED 404 shows up.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/ba188fd2-e232-4a3b-92d4-828256000e08
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01bff0ded70edc9c84
Upwork Job ID: 1768311805142413312
Last Price Increase: 2024-03-14
Automatic offers:

Pujan92 | Reviewer | 0
tienifr | Contributor | 0

Reviewing today!

Found the issue in the logs. It seems like we're trying to subscribe to the report channel before the report is created, so there's a race condition somewhere.

Proposal
Please re-state the problem that we are trying to solve in this issue.
We have authenticate pusher console error when opening a thread.
What is the root cause of that problem?
We try to subscribe to the pusher before the report is created. We currently have 2 subscriptions, one in the report screen and one in the report actions view.
https://github.com/Expensify/App/blob/00315b1b3f8ee7a3adb86464f449d1c097a60f21/src/pages/home/ReportScreen.tsx#L437-L441
https://github.com/Expensify/App/blob/00315b1b3f8ee7a3adb86464f449d1c097a60f21/src/pages/home/report/ReportActionsView.tsx#L146-L150
The problem is in the report screen. When we open a new thread, it's possible that the report onyx data is not available yet, so the didCreateReportSuccessfully condition will return true because the pending fields are empty.
What changes do you think we should make in order to solve the problem?

We can add a new check to make sure the report object has a report ID.
const didCreateReportSuccessfully = report.reportID && (!report.pendingFields || (!report.pendingFields.addWorkspaceRoom && !report.pendingFields.createChat));

What alternative solutions did you explore? (Optional)
Move the subscription to the report actions view too because it's only rendered when the report is already loaded.

Thanks for the proposals. Both have covered the RCA correctly which seems to be Report onyx data might not be available post navigating to the thread. Regarding the solutions @tienifr I don't think we need to compare the route report id and onyx report id, because if it is still old report then didSubscribeToReportLeavingEvents ref value is enough to identify and avoid subscribing the events. Validating reportID of report onyx data is enough and seems correct to me. With that, we can go with @bernhardoj's proposal.
🎀👀🎀 C+ reviewed

Just FYI, I actually prefer my alternative solution, that is moving the subscription down to ReportActionsView, so we won't need to check the reportID anymore, including this one.
https://github.com/Expensify/App/blob/ea1bbc387bc56062f04f414085bc830b80736c53/src/pages/home/ReportScreen.tsx#L430-L432

@Pujan92 This will be true only if didCreateReportSuccessfully was also true for the old report, only then, the didSubscribeToReportLeavingEvents.current of the old report will be set to true here. Although rarely, if the old report was also an optimistic report, it will not subscribe to the user leaving event, and in this case didSubscribeToReportLeavingEvents (of the old report) won't save us from the bug as you suggested.

@tienifr Sorry but I am not following exactly here, is this something we can reproduce? I tried to create nested threads offline and switch to online but I am not seeing any AuthenticatePusher error.

Just FYI, I actually prefer my alternative solution, that is moving the subscription down to ReportActionsView, so we won't need to check the reportID anymore, including this one.

Yes, I checked but forgot to mention it in the earlier comment. The only concern is why ReportLeavingEvents logic added specifically in the ReportScreen when there was similar ReportTypingEvents logic already presented in ReportActionsView. I believe it's good to combine both part over there but we need to confirm/find the reason of the split if any.

The only concern is why ReportLeavingEvents logic added specifically in the ReportScreen when there was similar ReportTypingEvents logic already presented in ReportActionsView

I'm not sure, but I guess it's because the leaving redirection logic is put in ReportScreen, so they put the subscription in report screen too and not aware that we are doing a typing subscription in ReportActionsView. (here is the PR that implements it)
About the concern of having the old report in a new report screen, that is not valid anymore. Each report screen is a separate screen. The onyx data are not shared between the screens. The issue have specifically here is that the report object is not available yet, thus the reportID is undefined.
The existing logic to compare the reportID from Onyx with the reportID from params is from the ancient code where we used MainDrawerNavigator, where there could only be one report screen.

Thanks @bernhardoj for the explanation, club both events to one place makes sense to me.

There're certain scenarios where the ReportActionsView won't be rendered, see here. If the user was removed from the room while the ReportActionsView was not rendered, the leaving redirection logic won't work.

Thanks for flagging this @tienifr , I believe one use case where it fails is when user is leaving the room from the first device and on the second device the ReportActionsView is in a loading state then it might be possible that it won't navigate to Concierge. Because of the condition !prevUserLeavingStatus && !!userLeavingStatus won't be true which I think added for this multi device purpose only. This case might be rare but still I think it is a valid point. Thoughts @bernhardoj ?
@luacmartins Instead of breaking some other things I think it is better to validate only reportID here as a safer side.

I agree that we should minimize these changes to avoid other regressions

This case might be rare but still I think it is a valid point.
Instead of breaking some other things I think it is better to validate only reportID here as a safer side.

Oh yes, that's technically possible. I agree to just validate the reportID.

@luacmartins Can you plz check the review comment and other followed comments to decide whom to assign? Also, both contributors have provided valuable inputs so we may consider the bounty split if you think the same.

I agree that both contributors added value to this issue, so we can split the bounty. As for the proposal, I like @tienifr's solution more since it's stricter.

nice!

Merged, waiting for regression period then paying out!

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[X] [@Pujan92] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/24407
[X] [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/24407/files#r1576748976
[X] [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[X] [@Pujan92] Determine if we should create a regression test for this bug. Yes
[X] [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Open report
On any message(which isn't replied before) open context menu and select reply in thread
Verify thread report opens and isn't showing a AuthenticatePusher 404 error in the console

Do you agree 👍 or 👎 ?

@dylanexpensify seems automation is broken for this issue.

Updated the issue. Bump @dylanexpensify for payment

Paid out!

done!

authors: Pujan92 bernhardoj dylanexpensify kbecciv luacmartins


text:
[TS migration] Migrate tests to Typescript (react-native-onyx)

Typescript migration (react-native-onyx)
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
components/ViewWithCollections.js
components/ViewWithObject.js
components/ViewWithText.js
unit/storage/providers/IDBKeyvalProviderTest.js
unit/storage/providers/StorageProviderTest.js
unit/DevToolsTest.js
unit/cacheEvictionTest.js
unit/fastMergeTest.js
unit/onyxCacheTest.js
unit/onyxClearNativeStorageTest.js
unit/onyxClearWebStorageTest.js
unit/onyxMultiMergeWebStorageTest.js
unit/onyxTest.js
unit/subscribeToPropertiesTest.js
unit/useOnyxTest.ts
unit/withOnyxTest.js
utils/waitForPromisesToResolve.js

I'd like to work on it.

@smelaa from SWM will handle this one

Hi Błażej, thanks for taking over :) I'm assigning you to this issue

👋 @blazejkustra any updates on this issue?

I migrated all files yesterday, today it should be ready for internal review 👌

PR was merged! We can close this issue now. Thanks for your patience @sonialiap 😄

Handled by SWM, no payment needed

authors: MahmudjonToraqulov blazejkustra mountiny smelaa sonialiap


text:
Desktop - After update app reopened with blank screen and some lines of code

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Update the desktop app and wait for it to reopen

Expected Result:
App should reopen without any white screen
Actual Result:
After update app reopened with a blank screen with some lines of code
Workaround:
Closing and reopening solves the issue.
Platform:
Where is this issue occurring?

[ ] Web
[ ] iOS
[ ] Android
[ ] Desktop App
[ ] Mobile Web

Version Number: 1.0.79-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
View all open jobs on Upwork

From @arielgreen https://expensify.slack.com/archives/C01GTK53T8Q/p1627321718290400

App updated, and when it opened, it looked like this. Exiting/reopening resolved it.

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@cead22 per this SO, if this can be worked on by a contributor, please add External so we can get it posted to Upwork. Otherwise, add Internal.

Whoops, checking with engineering-chat since I think it can be posted to Upwork but I'm not 100% sure

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@chiragsalian mentioned he couldn't repro on prod

Is anyone able to reproduce this? I updated to v1.0.80-2 on desktop and didn't get the error. @parasharrajat you mentioned something in the Slack thread about what the cause might be?

@trjExpensify Huh... This is 4 days overdue. Who can take care of this?

I've been OoO, Melvin! Either way, is anyone able to reproduce this? I just updated desktop to v1.0.82-3 without a hitch.

Alright, seems like @conorpendergrast ran into it earlier so there seems to be something lingering:

Posted to Upwork here.

Triggered auto assignment to @thienlnam (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Waiting for proposals, seems like the workaround is to restart the app

Still waiting for proposals, it appears that this issue is not consistently reproducible

Maybe let's give it another week, and if we have no new reports, close it out? I haven't had this happen since I originally reported this.

Anyone heard anymore on this? Let me know if we're good to take the Upwork post down.

Nope, I think we're good to close it out and remove the Upwork post.

authors: MelvinBot arielgreen cead22 isagoico thienlnam trjExpensify


text:
Update app modal does not display

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Receive an app-update notification on desktop
Click on the notification.

Expected Result:
An modal is displayed asking if you want to update and restart the app.
Actual Result:
The app is focused, but no modal is displayed. The user must use the app menu to update.
Workaround:
Use the app menu to update:

Platform:

Desktop App

Version Number: 1.0.83.0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
View all open jobs on Upwork

Triggered auto assignment to @jboniface (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

I believe this regression was most likely caused by https://github.com/Expensify/App/pull/4406, but haven't confirmed.

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Shouldn't have included the AutoAssignerTriage label, my bad @jboniface.

@alex-mechler observed this bug on desktop v1.0.81-6, which means that it's present on production. Demoting this from deploy blocker to regular bug...

Also going to drop to a daily instead of hourly, but I still think this is quite important

This is caused by a break-in in the Onyx architecture. https://github.com/Expensify/App/issues/4500

ok. @alex-mechler

For users who have once received the update will set the ONYKEYS.UPDATE_AVAILABLE to true.
We have an issue in Onyx where if the value does not change, Onyx will not trigger an update notification to the component.
Each time you start the app, we ignore the stored value of ONYKEYS.UPDATE_AVAILABLE which is already true as you once received the update.
Now on next time you receive the update, Set ``ONYKEYS.UPDATE_AVAILABLE` to true which will not have any effect as Onyx will not set the notification to UpdateModal component, and thus component will never be shown.

Ah okay that makes more sense! Thanks for the explanation. It looks like we are actively working on that issue then, so does it make sense to wait to see if that fixes the issue?

Yes

This has not happened to me again since that PR went out to staging. Thanks @parasharrajat!

authors: MelvinBot OSBotify alex-mechler parasharrajat roryabraham


text:
Desktop - Scan - Amount field appears on confirmation page during scan expense flow

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.20-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:

Launch New Expensify desktop app
Go to workspace chat
Open + > Submit expense > Scan
Upload a receipt
On confirmation page, exit the flow
Open + > Track expense > Scan
Upload a receipt
Note that Amount field appears on the confirmation page when it is a scan expense
Might need to repeat Step 3 to 7 until the result is Step 8

Expected Result:
Amount field will not appear on the confirmation page when it is a scan expense
Actual Result:
In Step 8, amount field appears on the confirmation page when it is a scan expense
This issue happens when exiting scan expense flow and then starting another scan expense flow (from submit scan to track scan or vice versa)
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/22fbe1fa-6c8a-4c08-bd3f-bea50334c907
View all open jobs on GitHub

Production:
https://github.com/user-attachments/assets/85a10cd1-a1b5-4be5-8e74-3f48e76bf436

let's make this external

Bumped in slack: https://expensify.enterprise.slack.com/archives/C01GTK53T8Q/p1724615061325589

@roryabraham Can you please give the receipt pdf file example
I couldn't reproduce this issue on Desktop

requested retest: https://expensify.slack.com/archives/C9YU7BX5M/p1724715028460549, but note that in the issue description it does say that "you might have to try multiple times". Going to mark this one as Needs Reproduction

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Not reproducible
https://github.com/user-attachments/assets/e706e73c-ad56-4e31-a2e0-ab8e00b30276