text:
PageName didn't allow special chacater #955

Description
Page names were not accepting special characters , there is a function 'resolveAsSpaceChar' in helpers , that converted any special character to a space , which was being used in the page name editor , ''onNameEdit" , I have removed this from the part and thus now special characters are allowed. Solving issue #955
Fixes # (issue)

Fixes issue #955

Type of change

Changed a minor thing , that is onNameEdit inside the entity.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Tested on Code and demo
Checklist:

[ Y ] My code follows the style guidelines of this project
[ Y ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ Y ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ Y  ] New and existing unit tests pass locally with my changes

Sorry Some errors !


text:
chore: Optimizing code-split for mapStateToProps and mapDispatchToProps

Description
Optimizing code-split for mapStateToProps and mapDispatchToProps
PR fixes following issue(s)
Fixes # (issue number)
Type of change

Chore (housekeeping or task changes that don't impact user perception)

Testing
How Has This Been Tested?

[x] Manual
[ ] JUnit
[ ] Jest
[x] Cypress

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

source: gharchive/pull-request

repo: appsmithorg/appsmith

license_type: permissive

license_source: github-api


text:
feat: allow multiple lines in alert component

Description
Fixes : #30851
I have raised this pr in-order to allow multiple lines in alert message
Screenshots
passing \n in the message

unable to parse \n

After issue is resolved

Cypress Testing video
https://github.com/user-attachments/assets/ec826cef-664f-4392-b81e-9974178e65ec

Summary by CodeRabbit

New Features

Introduced automated tests for the button widget's alert functionality, ensuring correct display of messages with newline characters.
Enhanced the Toast component to better render content, improving readability by preserving whitespace and formatting.

Bug Fixes

Improved the display of alert messages in toast notifications, ensuring they respect original formatting.

@appsmithorg/query-js-pod , Please review this pr if you have enough bandwidth.
Thanks in advance.

/build-deploy-preview skip-tests=true

@saiprabhu-dandanayak Could you please fix the lint and prettier checks that are failing for the PR?

Hi @rishabhrathod01 , fixed the lint and prettier checks ,  could you pls check ??

Hi @rishabhrathod01 , if you have enough bandwidth , can you pls review this pr , i would be happy to work on comments if any.
Thanks in advance.

@carinanfonseca can you please check the design changes here

hello @saiprabhu-dandanayak
thank you for your contribution.
It makes sense to recognize the \n when we are in JS mode, but in non-JS mode, a user shouldn't be expected to use \n to create a new line. In that mode, pressing 'Enter' in the text area itself should work, like this:

let me know if this is possible. I am happy to answer any questions.

Hi @carinanfonseca  , the screenshot i have added in PR description have double \n , so the spacing is more and even in non-JS mode if we provide  Enter it will work as expected , In non-JS mode even if we provide \n it is being resolved automatically.
Please let me know this is expected behaviour or not.

@saiprabhu-dandanayak could you fix the storybook checks that are failing for the PR?

Hi @rishabhrathod01 , The error is showing it lacks  Project token and i am not sure how to fix this.
Any suggestions would be helpfull.
Thank You.

@saiprabhu-dandanayak you could ignore the storybook failure for now. The Appsmith team will forward the designs for the Toast UI to be implemented here.
cc: @carinanfonseca

/build-deploy-preview skip-tests=true

@saiprabhu-dandanayak could merge the latest release branch to the PR? Will need trigger the workflow again.

Hi @rishabhrathod01 , took recent pull from release branch and updated the source branch , pls check.
Thank you.

Shadow PR for Cypress run

https://github.com/appsmithorg/appsmith/pull/36514
https://github.com/appsmithorg/appsmith-ee/pull/5218

Test has passed for the shadow PR - https://github.com/appsmithorg/appsmith/pull/36514
This PR is safe to merge

@saiprabhu-dandanayak  We are reverting this PR since it is causing below issues.

There was a white space in front of the content which was fixed by https://github.com/appsmithorg/appsmith/pull/36629
Content is not getting wrapped. https://github.com/appsmithorg/appsmith/issues/36642
While running this change in storybook, the toast is expanded in height.

authors: NilanshBansal albinAppsmith carinanfonseca rishabhrathod01 saiprabhu-dandanayak


text:
[TEMPLATE] Calendly clone with stripe integration

Describe the template
This App is the perfect clone of the Calendly app it has Stripe integration which makes the person who wants to have a meeting with the person needs to pay before he can schedule his meeting in the respective timing. The price for the meeting is set by the developer or the account user. This uses the meeting scheduler template from appsmith
Link to the public app
Link
Integrations and features
A list of specific integrations, data sources, and specific features

Google Calendar
Stripe API
Zoom API

JSON File
Meeting Scheduler Copy.json.zip
Screenshots

@rlnorthcutt I have made the changes

source: gharchive/issue

repo: appsmithorg/foundry

license: MIT


text:
Getting an error when new project is setup.

Describe the bug
Hello, I am getting the following error when launcing npm init sass-boilerplate
below is the full error description.
`
Performing system check:
✔ Checking if docker is installed... it is!
✔ Checking if pnpm is installed... it is!
✔ Checking if nx is installed... it is!
Error: Init directory must be empty!
npm ERR! code 1
npm ERR! path /Volumes/Work/Github/Marcus-Finley/nucleus
npm ERR! command failed
npm ERR! command sh -c create-saas-boilerplate
npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/devteam/.npm/_logs/2023-07-21T10_48_01_997Z-debug-0.log
`
How I can solve this issue?
Steps to reproduce

go to Terminal on Mac
launch the following command
npm init sass-boilerplate

System Info
System:
    OS: macOS 13.4.1
    CPU: (4) x64 Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz
    Memory: 823.09 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 16.14.2 - ~/.nvm/versions/node/v16.14.2/bin/node
    Yarn: 1.22.18 - ~/.nvm/versions/node/v16.14.2/bin/yarn
    npm: 8.5.0 - ~/.nvm/versions/node/v16.14.2/bin/npm
    pnpm: 8.6.9 - ~/.nvm/versions/node/v16.14.2/bin/pnpm
  Browsers:
    Chrome: 114.0.5735.198
    Safari: 16.5.2

Logs
No response
Validations

[X] Follow our Code of Conduct.
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

Hi,
The answer is right there in your log
Error: Init directory must be empty!
You're probably running the command in a directory that is not empty, but it should.

@pziemkowski Thanks for your reply,
I tried it in an empty directory but got the same error.

Can you try this node script to see what it returns?
If it says null it means it didn't find any files in the directory. Maybe you have some hidden files there?
Just change the './init-dir' to the directory you try to run the init script in.
const fs = require('fs').promises;

const directory = fs.opendir('./init-dir').then((directory) => {
    return directory.read().then((entry) => {
        console.log(entry)
    }).then(() => {
        directory.close()
    })
});

Thanks, solved the issue,
I found the git hidden files in my folder.
Thanks again.

authors: pziemkowski timeisgolden

repo: apptension/saas-boilerplate


text:
Define browser support

We should probably define some level of browser support.
Our applications currently support the following browsers: Chrome, Safari and Firefox.
Maybe we can extend this with Microsoft Edge support.

Since “new Edge” uses the Chromium engine it seems reasonable to support it.
I would not support older browsers like IE11, although we could probably test and apply some fixes at some point to make it render reasonably well. So I would label that as “Partial support” (With guideline: avoid using CSS grid style components when you need legacy support / Remove animations by flagging a variable in the globals)
I would support Chrome (Desktop), Chrome (Android), Safari, Mobile Safari, Firefox and new Edge. I think that covers most usage.

authors: Dietr Wolfr

repo: appuniversum/appuniversum


text:
Close button visibility

Wifi loading and "PLEASE TURN ON" string should have some margin because while loading progress bar is little hidden under text view. Check screenshot.

Is there any callback/listener for a successful connection, so that we can do some work after connection established.

It's not an issue actually. It would be great if we can enable/disable close button or change its visibility so that we can have the non-cancelable dialog.

Hi.
Please update to version 1.1.3
Here you can find a callback for internet connection, and you can set the dialog cancelable or not.
All this you can do right from builder.

authors: pratikghosalkar robertlevonyan

repo: appwise-labs/NoInternetDialog


text:
Implement sendWhatsAppMessage() Appwrite Function ⚡

Introduction
Appwrite Functions allow you to extend and customize your Appwrite server functionality by executing your custom code 🤩 You can learn more at our official Appwrite Functions docs.
Your task is to implement sendWhatsAppMessage function. You can look at the existing Appwrite Functions demo in the coding language you prefer to see how it works.
This function should take phoneNumber and text as input and send a WhatsApp message using Twilio to this number.

Please make sure to store all configurable parameters as environment variables, so others can start using your script without having to edit it. If some data is different for each execution, make sure to use APPWRITE_FUNCTION_EVENT_DATA or APPWRITE_FUNCTION_DATA environment variable.

Tasks summary:

[ ] Fork & clone this repository
[ ] Create feat-implement-send-whats-app-msg-X branch where X is programming language you used
[ ] Write code for the function
[ ] Test the function using Appwrite
[ ] Write a README.md explaining what function does, how to use and customize it. Here is an example.
[ ] Submit pull request

If you need any help, reach out to us on our Discord server.
Are you ready to work on this issue? 🤔 Let us know, and we will assign it to you 😊 There are 9 languages in which you can implement this function. When requesting to be assigned, please mention which language would you like to use.
Assignees table
✅ = Done - This language has already been finished
⚒ = In progress - Someone is already working on this language
❌ = Unassigned yet - This language can be assigned to you

Function / Language
Deno
NodeJS
PHP
Python
Ruby
Dart
.NET
Java
Kotlin

sendWhatsAppMessage
❌
❌
❌
❌
⚒ DonnC
❌
❌
⚒ ssm0801
❌

Happy Appwriting!

Can I take this ? I'll work in python

@Meldiron Can I choose to implement this in multiple languages?

@Meldiron I would like to implement this is python.

@Meldiron  I can implement this in PHP and Kotlin

I would like to go for python

I would like to work on this ?
I will code in Java

@DonnC @ssm0801 Assigned it to you! All the best 🚀

@Shylajhaa Looks like you have some issues assigned to you already. We request you to complete those before requesting assignments on new ones. Also, please consider picking a different type of issue so other contributors can try this one.

@DonnC @ssm0801 Assigned it to you! All the best 🚀

thank you but i requested for python can you confirm

@DonnC Whoops, my bad, thanks for the correction. Sure, python is yours 🥳

@Meldiron assign for nodejs to me

@mukeshmjn Assigned it to you! All the best 🚀

@Meldiron I would like to work in dart

Can I work in this issue in PHP language?

@niyoj Assigned it to you! All the best 🚀

i can implement in kotlin
please assign to me

@alfiankan assigned kotlin to you. All the best 🚀

authors: DonnC Meldiron Phoenix-031 Shylajhaa alfiankan divyanshkul lohanidamodar mukeshmjn niyoj ssm0801

repo: appwrite/demos-for-functions


text:
Demo to create user profile document upon a new user account creation…

… - issue#288

Hi @Meldiron - suggested changes are implemented. Please take a look.

Hello @Meldiron  - can you check this pls?


text:
Offer a pure dart package

It would be awesome if this package could also be offered as a plain dart package. For example you can create your own packages in flutter and define there your API with this package and keeping the flutter root directory pristine.

It shouldn't be hard, since only reason that there is a Flutter dependency is because package uses shared preferences. We already accept any compatible storage in constructor, so it's just extracting core to another package.
If anyone knowns about how monorepo function in dart/flutter, I'm open for PR

why dont we move to hive instead of shared preference
this will remove the dependency on flutter

We don't know where we can save data without Flutter. For that reason there are separate packages for hive: hive and hive_flutter. See hive docs.
It's all about convenience. We can either use some storage for Flutter, or use any generic storage but require user install additional package and manually provide path.
So I choose this:
import 'package:directus/directus.dart';

final sdk = await Directus('http://localhost:8055').init();

over something like this:
import 'package:directus/directus.dart';
import 'package:path_provider/path_provider.dart';

var appDir = await getApplicationDocumentsDirectory();
final sdk = await Directus('http://localhost:8055', appDir).init();

There is now directus_core package that does not require Flutter

authors: apstanisic ngjoni workatease

repo: apstanisic/directus-dart


text:
fix log drain tests

https://github.com/aptible/ember-cli-aptible-shared/pull/152 exposed some flakey tests in the log drain module.  These tests are particularly flakey because they are "guessing" at the number of assertions for a given test. It's not always guaranteed how many polling attempts will be hit for a given test.
This PR fixes that by limiting the polling attempt to 1, so the number of assertions can be guaranteed each test.

Closing for now -- master doesn't yet reference a released version of shared(0.0.106+) that includes that fix.

license: mit

license_source: bigquery


text:
[Feature Request]: Making register form for Hostel Management project

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I want to add register page in hostel management project , there is an option to register , but there is no page for registration
Use Case
It would help new customers to join
Benefits
No response
Add ScreenShots
This is the login page , I want to make similar register page

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[ ] I'm a SSOC'24 contributor
[X] I have starred the repository

@apu52 Please assign it to me

@Maana-Ajmera can u please double check it , I think the register page also exists in the website

yes sorry , it exists , I am closing this issue


text:
Fix dropout issues

fix dropout issues in parameters
allow to change dropout in resnet model
fix minor bug in SVM commandline

I'll merge this PR.
Thanks @14thibea !

repo: aramis-lab/AD-DL


text:
Support MySQL CAST_NCHAR function.

What this PR does:
Which issue(s) this PR fixes:

Fixes #483
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report
Base: 36.10% // Head: 35.68% // Decreases project coverage by -0.42% :warning:

Coverage data is based on head (59f9d38) compared to base (66321cf).
Patch coverage: 71.64% of modified lines in pull request are covered.

:exclamation: Current head 59f9d38 differs from pull request most recent head 135ba2f. Consider uploading reports for the commit 135ba2f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   36.10%   35.68%   -0.43%
==========================================
  Files         147      149       +2
  Lines       21089    21311     +222
==========================================
- Hits         7615     7605      -10
- Misses      12643    12890     +247
+ Partials      831      816      -15

Impacted Files
Coverage Δ

pkg/runtime/function2/cast_nchar.go
63.88% <63.88%> (ø)

pkg/runtime/function2/mod.go
80.64% <80.64%> (ø)

pkg/boot/discovery_watch.go
9.27% <0.00%> (-15.47%)
:arrow_down:

pkg/boot/watcher.go
0.47% <0.00%> (-7.33%)
:arrow_down:

pkg/boot/boot.go
45.00% <0.00%> (-6.88%)
:arrow_down:

pkg/boot/discovery.go
28.22% <0.00%> (-5.84%)
:arrow_down:

pkg/dataset/priority_queue.go
64.35% <0.00%> (-1.00%)
:arrow_down:

pkg/config/tenant.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Please rebase the master, I remember there's MOD exist on the master branch.

authors: codecov-commenter gongna-au jjeffcaii

repo: arana-db/arana


text:
General questions for arangodb based application architecture

My Environment

ArangoDB Version: 3.8.1
Storage Engine: RocksDB
Deployment Mode: Single Server | Leader/Follower ("Master/Slave") | Active Failover
Deployment Strategy:   Manual Start in Docker | ArangoDB Starter in Docker
Configuration:details, notable server settings, etc. -->
Infrastructure: own
Operating System: Ubuntu 20.04
Total RAM in your machine: 32Gb or more.
Disks in use: SSD
Used Package: Docker - official Docker library

Component, Query & Data
Affected feature: Performance
Size of your Dataset on disk:  in Terabytes or more eventually
Replication Factor & Number of Shards (Cluster only): TBD
Questions
I understand that we can use this API to connect to multiple databases on the same server. Referring back to the architecture that I need for my product, following questions arise

How many databases can be created on a single server instance?
How many parallel connections can be maintained to a server instance?
How many parallel connections can be maintained to a database?
What is the performance benchmark on database swapping for executing a query?

Problem:
https://stackoverflow.com/questions/69687128/connecting-to-multiple-databases-with-arangodb
Expected result:
Possibility to arrive at the right architecture based on answers.

@gitgkk You can find documentation here: https://www.arangodb.com/docs/stable/http/database-notes-on-databases.html
The limitation details can be found here: https://www.arangodb.com/docs/stable/http/database-database-management.html
If you run a cluster (which is advisable at the scale you mentioned) then we scale up linearly in the agency. The impact on server behavior will only be increased usage of resources. As long as you have provisioned the right-sized machines to handle the disk/memory needed you should be good to go.

Hello, I also encountered this problem in version 3.6.5, but the cluster configuration of version 3.6.5 does not have keepalive related configuration. I would like to ask you what http mode will the java client use to request arangodb cluster server by default

repo: arangodb/arangodb


text:
Datafile for collection corrupt (no apparent reason), but can't delete collection

my environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[x] 3.2

Mode:

[x] Single-Server

Storage-Engine:

[x] mmfiles

On this operating system:

[x] Linux

[x] Ubuntu .deb

Hello,
For some unknown reason, I got a datafile corrupt for one collection. This is the problem reported:
2017-12-27T21:26:36Z [1929] WARNING crc mismatch found in datafile '/var/lib/arangodb3/databases/database-1489771778867/collection-1489743768287-1811945200/journal-1489772003064.db' of size 33554432, at position 56
2017-12-27T21:26:36Z [1929] WARNING crc mismatch found inside marker of type 'document' and size 114. expected crc: 4102192310, actual crc: 4093630817
2017-12-27T21:26:36Z [1929] INFO last good marker found at: 0x0000000000000020
2017-12-27T21:26:36Z [1929] INFO raw marker data following:
2017-12-27T21:26:36Z [1929] INFO type: document, size: 114, crc: 4093630817
2017-12-27T21:26:36Z [1929] INFO (expected layout: size (4 bytes), crc (4 bytes), type and tick (8 bytes), payload following)
2017-12-27T21:26:36Z [1929] INFO 0x0000000000000038: 72 00 00 00 61 D9 FF F3  F8 BE 54 DD 5A 01 00 1E   r...a... ..T.Z...
2017-12-27T21:26:36Z [1929] INFO 0x0000000000000048: F4 BE 54 DD 5A 01 00 00  0B 5A 05 31 4C 33 34 34   ..T.Z... .Z.1L344
2017-12-27T21:26:36Z [1929] INFO 0x0000000000000058: 37 38 39 31 36 39 30 35  34 33 F3 DF EA A5 DB 5A   78916905 43.....Z
2017-12-27T21:26:36Z [1929] INFO 0x0000000000000068: 01 00 00 34 53 74 61 78  65 6E 74 2F 33 33 37 39   ...4Stax ent/3379
2017-12-27T21:26:36Z [1929] INFO 0x0000000000000078: 39 34 33 39 36 35 37 34  32 30 31 37 2D 31 32 2D   94396574 2017-12-
2017-12-27T21:26:36Z [1929] INFO 0x0000000000000088: 31 37 54 30 36 3A 32 35  3A 30 31 5A 20 5B 36 34   17T06:25 :01Z [64
2017-12-27T21:26:36Z [1929] INFO 0x0000000000000098: 38 39 5D 20 49 4E 46 4F  20 68 61 6E 67 75 70 20   89] INFO  hangup
2017-12-27T21:26:36Z [1929] INFO 0x00000000000000A8: 72 65 63 65 69 76 65 64  2C 20 61 62 6F 75 74 20   received , about
2017-12-27T21:26:36Z [1929] INFO 0x00000000000000B8: 74 6F 20 72 65 6F 70 65                            to reope
2017-12-27T21:26:36Z [1929] WARNING data directly following this marker cannot be analyzed
2017-12-27T21:26:36Z [1929] ERROR datafile '/var/lib/arangodb3/databases/database-1489771778867/collection-1489743768287-1811945200/journal-1489772003064.db' is corrupt
2017-12-27T21:26:36Z [1929] ERROR unable to close datafile '/var/lib/arangodb3/databases/database-1489771778867/collection-1489743768287-1811945200/journal-1489772003064.db': -1
2017-12-27T21:26:36Z [1929] ERROR {datafiles} cannot open datafile '/var/lib/arangodb3/databases/database-1489771778867/collection-1489743768287-1811945200/journal-1489772003064.db': corrupted datafile
2017-12-27T21:26:36Z [1929] ERROR caught exception while opening collection 'HAS_QUALITY': cannot open document collection from path '/var/lib/arangodb3/databases/database-1489771778867/collection-1489743768287-1811945200': corrupted datafile

Luckily, this was not a problem for me because I only had dummy data there, however, I'd like to restart the server normally, but I can't delete the corrupt collection through arangosh: db._collection('HAS_QUALITY').drop() throws an error.
Is there any other way I can I delete the corrupt collection? I need the data from the other collections, so I need to restart the server and have db access. (EDIT: of course I have db access with the option to ignore errors, I meant that I need to get the website online again normally!)
Let me know if I can help in further investigating the problem, in case it's a bug.
Cheers,
Miguel

Ok, I manually moved the corrupt datafile away and also one of the logfiles (which was corrupt also), and managed to restart the db normally.
Anyway, let me know if you want to inspect the problem further. Is it possible to have any idea of what caused this problem? It's scary because I have important data in other collections (which is backed-up, but anyway...)
Best,
Miguel

We assume this is a duplicate of https://github.com/arangodb/arangodb/issues/3632 which will be fixed in the upcoming release.

Please report to the other bug or reopen this bug in case you have reason to believe the bugs are not the same.

Hmm... maybe the same, though I don't remember having problems on upgrading. The files were already corrupt before I tried to upgrade to 3.2.10.
But let's see how it goes now.

Hi Miguel,
it becomes visible whenever ArangoDB is restarted. For people who have dedicated servers this happens mostly during upgrades.
Cheers

Yep, it's probably the same! Thanks,
Best,
Miguel

authors: ObiWahn miguel-porto


text:
reduce memory usage for incremental sync replication

Scope & Purpose
Backport of https://github.com/arangodb/arangodb/pull/18833
the incremental sync protocol that was used for collections created with 3.8 or higher had memory usage issues in case the follower already had some local data and its dataset was much larger than the leader's. For example, this can happen if a follower gets disconnected, then a lot of document removals happen on the leader and afterwards the follower tries to get back into sync.
in this case, the follower buffered the ids of documents it had to remove locally in a vector, which could grow arbitrarily large. the removal of the documents contained in this vector would only happen at the end, potentially even without performing intermediate commits.
the change in this PR is to trigger the document removal earlier, once the vector has reached some size threshold, and also to use intermediate commits during the removals.

[x] :hankey: Bugfix
[ ] :pizza: New feature
[x] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Checklist

[ ] Tests

[ ] Regression tests
[ ] C++ Unit tests
[ ] integration tests
[ ] resilience tests

[ ] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[x] Backport for 3.11: https://github.com/arangodb/arangodb/pull/18834
[x] Backport for 3.10: https://github.com/arangodb/arangodb/pull/18835
[x] Backport for 3.9: this PR
[ ] Backport for 3.8: -

Related Information

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket:
[ ] Design document:

Added DO_NOT_MERGE label simply because we need thorough reviews and ideally some manual testing before releasing it in a stable branch.


text:
Allow TreeTraversal to run individual queries in non-batch mode

Related to https://github.com/arborx/ArborX/pull/542, https://github.com/arborx/ArborX/pull/784, and https://github.com/arborx/ArborX/pull/903.
This pull request allows creating a TreeTraversal object without specifying predicates and running the queries in non-batch mode using a search() member function. Since we are in a Detail namespace, there is no need to be backward-compatible.

Trying this in the BVH benchmark gives somewhat mixed results, see https://code.ornl.gov/ecpcitest/alexa/-/jobs/1927138.
BM_radius_callback_search<ArborX::BVH<Serial>>/1000/1000/10/1/0/0/2/manual_time_median                    +0.0055         +0.0055          3452          3471          3459          3478
BM_radius_callback_search<ArborX::BVH<Serial>>/10000/10000/10/1/0/0/2/manual_time_median                  +0.0463         +0.0463         39708         41546         39710         41550
BM_radius_callback_search<ArborX::BVH<Serial>>/100000/100000/10/1/0/0/2/manual_time_median                +0.1011         +0.1011        414191        456052        414136        455992
BM_radius_callback_search<ArborX::BVH<Serial>>/1000/1000/10/1/0/1/3/manual_time_median                    +0.0498         +0.0495          1753          1840          1761          1848
BM_radius_callback_search<ArborX::BVH<Serial>>/10000/10000/10/1/0/1/3/manual_time_median                  +0.1800         +0.1800         12476         14721         12482         14729
BM_radius_callback_search<ArborX::BVH<Serial>>/100000/100000/10/1/0/1/3/manual_time_median                +0.1787         +0.1786         95215        112227         95212        112220
BM_radius_callback_search<ArborX::BVH<OpenMP>>/1000/1000/10/1/0/0/2/manual_time_median                    -0.8553         -0.8444           674            97           682           106
BM_radius_callback_search<ArborX::BVH<OpenMP>>/10000/10000/10/1/0/0/2/manual_time_median                  -0.3657         -0.3620          1559           989          1570          1002
BM_radius_callback_search<ArborX::BVH<OpenMP>>/100000/100000/10/1/0/0/2/manual_time_median                -0.0261         +0.0083         10659         10380         10328         10413
BM_radius_callback_search<ArborX::BVH<OpenMP>>/1000/1000/10/1/0/1/3/manual_time_median                    -0.9084         -0.8959           625            57           634            66
BM_radius_callback_search<ArborX::BVH<OpenMP>>/10000/10000/10/1/0/1/3/manual_time_median                  -0.6674         -0.5906          1157           385           968           396
BM_radius_callback_search<ArborX::BVH<OpenMP>>/100000/100000/10/1/0/1/3/manual_time_median                -0.5546         +0.1590          6124          2728          2382          2761
BM_radius_callback_search<ArborX::BVH<Cuda>>/10000/10000/10/1/0/0/2/manual_time_median                    -0.6594         -0.5967           444           151           489           197
BM_radius_callback_search<ArborX::BVH<Cuda>>/100000/100000/10/1/0/0/2/manual_time_median                  -0.6442         -0.6231          1331           474          1388           523
BM_radius_callback_search<ArborX::BVH<Cuda>>/1000000/1000000/10/1/0/0/2/manual_time_median                +2.1922         +1.9718          6323         20183          7031         20893
BM_radius_callback_search<ArborX::BVH<Cuda>>/10000/10000/10/1/0/1/3/manual_time_median                    -0.7617         -0.6858           405            96           450           141
BM_radius_callback_search<ArborX::BVH<Cuda>>/100000/100000/10/1/0/1/3/manual_time_median                  -0.8177         -0.7874          1198           218          1254           267
BM_radius_callback_search<ArborX::BVH<Cuda>>/1000000/1000000/10/1/0/1/3/manual_time_median                -0.4627         -0.3820          3379          1816          4087          2526

Trying this in the BVH benchmark gives somewhat mixed results

This is likely because we ran sorted queries in Gitlab regression suite, but the current patch does not sort them. So, it's not comparing identical paths.

This is likely because we ran sorted queries in Gitlab regression suite, but the current patch does not sort them. So, it's not comparing identical paths.

Yes, I didn't mean to say that we were comparing the same code path. I merely wanted to express that we don't overly bad results when not sorting.

change operator() to take in a predicate instead of index, modify the parallel loops in the other constructors to grab a predicate

We can't use a KOKKOS_LAMBDA in a constructor because nvcc doesn't like it, we need to use a call operator. To avoid selecting the wrong overload, I introduced a tag for the "normal" tree traversal. Not sure if this better than having a search() member function and leave the other member functions as-is, though.

@aprokop I tried to address your suggestions.

One of the builds fail with a real error.

HIP and SYCL were timing out.

Retest this please.

authors: aprokop masterleinad

repo: arborx/ArborX


text:
🛑 ARCaptcha S3 is down

In c033d35, ARCaptcha S3 (https://api.arcaptcha.ir/arcaptcha/api/s3) was down:

HTTP code: 400
Response time: 326 ms

Resolved: ARCaptcha S3 is back up in 87d4aac.

repo: arcaptcha/ARCaptcha-monitoring


text:
No data returned at all

Hi, I'm using soccer-cli (0.1.0.0) and it returns no data, for example:
$ soccer --players --team=BM
No data for the team. Please check the team code.

No standings, no players, nothing at all. Is this project alive?
The python version is 3.6.7
Thanks in advance

You should still be able to get some data.
Although, the data source changed its API which is why if you try to get standings for the English Premier League for example, you will get data from last season (2017/2018).
The code would need to be adjusted to support the new API. As well as potentially updated to support the various access tiers which include support for different leagues/statistics etc.
https://www.football-data.org/documentation/api

authors: Saturn sebelk

repo: architv/soccer-cli


text:
Config snapToNext animation duration?

Is this a bug report, a feature request, or a question?
Question
Is there any way to configure the snapToNext() animation duration?
I have a next button which onPressed will programmatically trigger Carousel to snap to the next item.  However, in Android, the animation seems too fast to me and I'd like to slow it down to perhaps 500ms.
What I'm seeing is like 100-150ms snap which is lightning fast. Worth mentioning, I've only tested this on Google Pixel 3a emulator. Could it be emulator issue? I'm not sure.

@heesienooi Unfortunately, this is something we've been asking for years to the React Native team (literally, see #203 for example) to no avail so far. ScrollView's scrollTo() method just won't take any duration. And yes, that's a real bummer.
If things were to change on RN's side, I can guarantee you we'd be the first to implement it ;-)

authors: bd-arc heesienooi

repo: archriss/react-native-snap-carousel


text:
Modal.error 设置closable不生效，react版arco生效

[ ] I'm sure this does not appear in the issue list of the repository

Basic Info

Package Name And Version: @arco-design/web-vue@2.44.1
Browser: chrome110.0.0.0

simple 设置为false即可显示关闭按钮，但是希望关闭按钮脱离 simple控制

repo: arco-design/arco-design-vue


text:
Want to lighten the comment color

I am studying the colors/nord.vim pallet because I would like to lighten the comments a bit. With the terminal opacity set to 80, comments tend to blend too much with the background. So I would like to have a bit litten comments. I see there is a variable called comment_brightness but not sure where exactly to activate it. Also this is for vim in terminal, not on GUI.

Hi @Jzarecta 👋
The nord_comment_brightness plugin configuration variable is deprecated since plugin version 0.10.0 and is not loaded anymore because the default comment color was changed according to https://github.com/arcticicestudio/nord/issues/94.
To customize the theme to fit your needs, check out Nord Vim's official “Customization“ port project documentation.
The style key for comments is Comment, so you can change it to any other value like e.g. nord6:
augroup nord-theme-overrides
  autocmd!
  " Use 'nord6' as foreground color for all comments.
  autocmd ColorScheme nord highlight Comment ctermfg=15 guifg=#ECEFF4
augroup END

@Jzarecta  btw be sure yours  set termguicolors works properly, actually setting t_8f and other stuff as needed consumed a lot of time

authors: Jzarecta arcticicestudio dagolinuxoid

repo: arcticicestudio/nord-vim


text:
test handler

Can we put the handler tests in their own directory?

We can at the app layer because these packages are not reusable so we don't need to think in terms of unit tests. This helps reduce the number of instances of the DB we need to start to run the tests.
At the business and foundation layers we need to keep the tests with the package we are testing.

authors: David-Kalashir ardan-bkennedy

repo: ardanlabs/service


text:
When blocks viewed in backend, possible to change block titles dynamically?

Hi,
Is it possible to change the block titles that appear in the backend- eg in the example below, "Project preview" would be replaced with the title of each project?

Hi Seb,
it is not possible with the current implementation but we could provide a hook in the form of a helper function you have to redefine. Here's the code that's currently pulling the title of each block from configuration:
https://github.com/area17/twill/blob/209e63f0d21e909cba6370d9d853c66a1b9fabf0/src/Repositories/Behaviors/HandleBlocks.php#L112-L125
I'm thinking we could replace line 123 by something like:
'title' => getBlockCustomTitle($block, $blockTypeConfig['title']),

where the first parameter is the block object itself, so you can access browsers data inside and use that information as the title, and the second is the default value, which is the current value being used from configuration. The default implementation of this function coming with Twill would only return the default value.

Thanks for going into so much detail. Where/how would I redefine this function? (Sorry if that's a bit of a beginner question!)

You could override the existing function in your Module Repository.
Example:
<?php

namespace App\Repositories;

use A17\Twill\Repositories\Behaviors\HandleBlocks;
use A17\Twill\Repositories\ModuleRepository;
use App\Models\Article;

class ArticleRepository extends ModuleRepository
{
    use HandleBlocks;

    //...

    public function getFormFieldsHandleBlocks($object, $fields)
    {
        $fields['blocks'] = null;
        if ($object->has('blocks')) {
            $blocksConfig = config('twill.block_editor');
            foreach ($object->blocks as $block) {
                $isInRepeater = isset($block->parent_id);
                $configKey = $isInRepeater ? 'repeaters' : 'blocks';
                $blockTypeConfig = $blocksConfig[$configKey][$block->type] ?? null;
                if (is_null($blockTypeConfig)) {
                    continue;
                }
                $blockItem = [
                    'id' => $block->id,
                    'type' => $blockTypeConfig['component'],
                    'title' => getBlockCustomTitle($block, $blockTypeConfig['title']),
                    'attributes' => $blockTypeConfig['attributes'] ?? [],
                ];
                if ($isInRepeater) {
                    $fields['blocksRepeaters']["blocks-{$block->parent_id}_{$block->child_key}"][] = $blockItem + [
                        'max' => $blockTypeConfig['max'],
                        'trigger' => $blockTypeConfig['trigger'],
                    ];
                } else {
                    $fields['blocks'][] = $blockItem + [
                        'icon' => $blockTypeConfig['icon'],
                    ];
                }
                $fields['blocksFields'][] = collect($block['content'])->filter(function ($value, $key) {
                    return $key !== "browsers";
                })->map(function ($value, $key) use ($block) {
                    return [
                        'name' => "blocks[$block->id][$key]",
                        'value' => $value,
                    ];
                })->filter()->values()->toArray();
                $blockFormFields = app(BlockRepository::class)->getFormFields($block);
                $medias = $blockFormFields['medias'];
                if ($medias) {
                    $fields['blocksMedias'][] = collect($medias)->mapWithKeys(function ($value, $key) use ($block) {
                        return [
                            "blocks[$block->id][$key]" => $value,
                        ];
                    })->filter()->toArray();
                }
                $files = $blockFormFields['files'];
                if ($files) {
                    collect($files)->each(function ($rolesWithFiles, $locale) use (&$fields, $block) {
                        $fields['blocksFiles'][] = collect($rolesWithFiles)->mapWithKeys(function ($files, $role) use ($locale, $block) {
                            return [
                                "blocks[$block->id][$role][$locale]" => $files,
                            ];
                        })->toArray();
                    });
                }
                if (isset($block['content']['browsers'])) {
                    $fields['blocksBrowsers'][] = $this->getBlockBrowsers($block);
                }
            }
            if ($fields['blocksFields'] ?? false) {
                $fields['blocksFields'] = call_user_func_array('array_merge', $fields['blocksFields'] ?? []);
            }
            if ($fields['blocksMedias'] ?? false) {
                $fields['blocksMedias'] = call_user_func_array('array_merge', $fields['blocksMedias'] ?? []);
            }
            if ($fields['blocksFiles'] ?? false) {
                $fields['blocksFiles'] = call_user_func_array('array_merge', $fields['blocksFiles'] ?? []);
            }
            if ($fields['blocksBrowsers'] ?? false) {
                $fields['blocksBrowsers'] = call_user_func_array('array_merge', $fields['blocksBrowsers'] ?? []);
            }
        }
        return $fields;
    }
}

@sebastianlenton &  @ifox - The idea is good, but which title should be shown if you have more then one entry in the Browser block?

Thanks @noxify for taking the time to explain that to me- much appreciated, looks like I'm on the right track now.
In my case I'm only allowing one item to be selected in the browser field, but aside from that you raise a very good point!

If you have some minutes, I can give you a running version ;)

Here my running version.
https://gist.github.com/noxify/237b7ee4b5cecffa1feaf5fb5be033fc#file-articlerepository-php-L34

Nice @noxify! However I would not recommend overriding the entire getFormFieldsHandleBlocks function as it is pretty complex and critical (which tells me we should probably split it for better extensibility). This is the only solution for now though, so thanks for sharing, but I think we should update Twill to call that function if it is defined instead.

@ifox - absolutely!
As a temporary solution the code snippet it should be good enough to continue, but it's not maintainable :) looking forward how this could be solved in the future.
Idea: maybe it's possible to create a "flat browser list" or "simple relation list" where the selected relations are shown directly without the "accordion".

Closing for inactivity.

authors: ifox noxify sebastianlenton yanhao-li


text:
ADBDEV-2402 Test pipeline, NOT MERGE

Here are some reminders before you submit the pull request

[ ] Add tests for the change
[ ] Document changes
[ ] Communicate in the mailing list if needed
[ ] Pass make installcheck
[ ] Review a PR in return to support the community

Please, reopen it if needed.

repo: arenadata/gpdb


text:
Consumer group names that are just hex - confusing

We should prefix the consumer group (or durable name) names with a helpful prefix, e.g.
dataflow-${pipelineName}-

Can I work on this?

Please!

I actually suggest a new format for the name.
dataflow-${cluterName[0:3]}-${namespace[0:3]}-${pipeline[0:3]}-s-${source[0:3]}-${hash}
In needs to be:

< 255 characters long (Kafka limitation)
globally unique
easier than hex for a human to at least guess which pipeline it might be

authors: alexec pradeepnnv

repo: argoproj-labs/argo-dataflow


text:
Corrected Dex ClientID

Corrected the ClientID that is used for Dex to achieve OpenShift authentication

LGTM

This PR has been included and merged as part of https://github.com/argoproj-labs/argocd-operator/pull/257.
Please close this PR.  @sabre1041

repo: argoproj-labs/argocd-operator


text:
Independent suspension nodes

Summary
Currently if 2 independent branches of a DAG pause execution because of SuspendTemplate node it is not possible to resume only one branch. Clicking "Resume" leads to resuming both branches. I understand that apparently as for now "suspended" state is global for the whole workflow, and it is expected behavior. But it is highly desired feature to allow independent resuming of suspension nodes.

Use Cases
I use suspension nodes for operator to manually approve some further actions. If a DAG has 2 independent branches with different actions I want to approve them independently.

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Yes, we would also prefer to see this feature in action. I also have the same use case where it would be cool to have independent resuming of suspension nodes.

authors: daniel-winter keshamin

repo: argoproj/argo-workflows


text:
fix(executor): emissary - make /var/run/argo files readable from non-root users. Fixes #6238

Fixes #6238
In this PR, I verified a real workflow works end to end with non-root users.
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: hello-world-
spec:
  entrypoint: hw
  templates:
  - name: hw
    container:
      image: curlimages/curl:latest
      command: [sh, -c, "echo hello"]

Tips:

Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
Sign-off your commits to pass the DCO check: git commit --signoff.
Run make pre-commit -B to fix codegen or lint problems.
Say how how you tested your changes. If you changed the UI, attach screenshots.

cc @alexec, after verification, I fixed remaining issues with emissary executor + nonroot


text:
Recommended resources for workflow controller

On 2.7.1 getting OOMKilled from kubernetes on workflow-controller causing constant restarts.  This was with memory limit and requests set to 1Gi.
I'm also getting this error, which then doesn't get retried (presumably because pod is down and controller not able to grab the pod change as it happens): https://github.com/argoproj/argo/blob/v2.7.1/workflow/controller/operator.go#L792
seems to be happier with 4Gi, though I'll let it run for a while
Questions:

Is running more than 1 workflow-controller an option so that wf don't fail, or is argo designed such that replicaCount must be 1?
What are the recommended resource requests for the workflow controller?  The base manifests don't impose resource restrictions.

This is a really good pair of questions:

No, you must only run one controller per instance ID, typically people don't use this (it can be a workaround).
Great question. I think the memory usage will grow liniarly with the number of workflow you're using - thought 4GB seems a lot.

Are there recommendations on running a high-availability argo in production?  We have had other workflows fail when the argo workflow controller restarts for some reason (ie. postgres connection dropped, underlying node issue).  We currently manually alert and re-run on these situations, as workflows are not retried in these scenarios even though we have retries enabled.
I believe the instance ID would alleviate load on a particular controller, but wouldn't address the need for it always being available.
Any tips would be appreciated.

authors: alexec ddseapy

repo: argoproj/argo


text:
Provide data type validation for default value of Argument

Given the following code:
        parser.addArgument("--message-create-time")
                .required(false)
                .setDefault(-1)
                .type(Long.class)

Argument class should provide data type validation for default value.
In the above case, the proper default value should be -1L

I think this would be a valuable addition, but unfortunately it is too costly. See below.
This can only be done if setDefault(…) is always invoked after type(…), as the default type is StringArgumentType. So in your example setDefault(-1) would fail because at that moment a string is still expected.
Adding a new requirement about the order in which setDefault(…) and type(…) have to be called, will break backward incompatibility. That is the main reason for not adding the validation.
The type checking would also have to be recursive, because the default value can be a collection. This makes the implementation more complex, and it may be even impossible to behave correctly under all conditions, as element types of collections, etc. may not be known.
We could add another method addTypeWithDefault(...). But this too would break backward incompatibility. And 6 overloaded methods would have to be introduced, because both setDefault(...) and type(...) have multiple overloads. It would also introduce an inconsistency: addTypeWithDefault(...) does check that the default value is of the correct type, but the combination of setDefault(...) and type(...) does not.
So unless there is a compelling use case besides a developer not paying enough attention, I am against implementing this.

This won't be implemented. It only prevents a problem that can easily be fixed before shipping the code.. Breaking backward compatibility for it is not worth the added benefit.

authors: jstuyts tedyu


text:
fix weak kex check

Looks like the tasks for setting the KEXs is using the wrong property (ssh_server_weak_hmac) to check if weak KEXs should be used. ssh_server_weak_kex should be correct

Thanks for the patch


text:
Implement handling for Ansible 2.2 changes to the Role Test Framework

eos_module.yml:
Add task for using eos_config Ansible module (to replace the use of eos_template in later versions of Ansible)
test_module.py:
Determine what version of Ansible is being used and process the playbooks accordingly.
Earlier versions of Ansible can use eos_template. Later versions must use eos_config.
Update the validation routines for 'present' and 'absent' config data in the test cases.
Update the test case setup and teardown for eos_template/eos_config.
Create a new format_config_list method to break a multi-level configuration string into a list of top-level configurations for use with eos_config.
Update response matching regex.
Update global setup and teardown for eos_template/eos_config handling.
Other minor changes.

fixes #1

repo: arista-eosplus/arista-ansible-role-test


text:
Updating source ports to ma0 for modular switches

Enhancement summary
Currently when we set modular platform, the management port is correctly set to "Management0"
spine:
  defaults:
    platform: 7500R3

However some services such as ntp, logging etc are still set to source Management1 by default. Ansible does not allow not setting the source interface or it will report an error:
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'dict object' has no attribute 'source_interface'
fatal: [spine01 -> localhost]: FAILED! => {"changed": false, "msg": "AnsibleUndefinedVariable: 'dict object' has no attribute 'source_interface'"}

Then all the services (in this case the spines) need to be overwritten to set the source to the correct port Management0. We would like this to be automatically set as well when selecting a modular platform and avoid the following configuration and avoid the following explicit configuration:
---
type: spine

custom_structured_configuration_logging:
...
  vrfs:
    MGMT:
      source_interface: Management0
      ...

custom_structured_configuration_snmp_server:
  local_interfaces:
    Management0:
      vrf: MGMT

custom_structured_configuration_ntp:
  local_interface:
    vrf: MGMT
    name: Management0

custom_structured_configuration_ip_tacacs_source_interfaces:
    - name: Management0
      vrf: MGMT

custom_structured_configuration_ip_ssh_client_source_interfaces:
    - name: Management0
      vrf: MGMT

Which component of AVD is impacted
eos_designs
Use case example
Using modular switches as spines.
Describe the solution you would like
Update the source interfaces correctly as part of selecting the modular platform.
Describe alternatives you have considered
No response
Additional context
No response
Contributing Guide

[X] I agree to follow this project's Code of Conduct

You can use the AVD magic variable (switch.mgmt_interface), instead of specifying the interface name itself.
For example:
custom_structured_configuration_logging:
...
  vrfs:
    MGMT:
      source_interface: "{{ switch.mgmt_interface }}"
      ...

custom_vrf_config:
  vrf: MGMT

custom_structured_configuration_snmp_server:
  local_interfaces:
    "{{ { switch.mgmt_interface: custom_vrf_config } }}"

custom_structured_configuration_ntp:
  local_interface:
    vrf: MGMT
    name: "{{ switch.mgmt_interface }}"

custom_structured_configuration_ip_tacacs_source_interfaces:
    - name: "{{ switch.mgmt_interface }}"
      vrf: MGMT

custom_structured_configuration_ip_ssh_client_source_interfaces:
    - name: "{{ switch.mgmt_interface }}"
      vrf: MGMT

Hi @tgodaA thanks for following up on this. I think even with this they still need a separate yaml file for the spines isnt it? What the customer was looking is to set automatically the source port for the required services based on the platform.
Today we already set the management port based on this:
https://avd.sh/en/latest/roles/eos_designs/doc/platform-settings.html
But ntp, logging etc still require a separate custom config to overwrite the default Management1 port. Hence the ask, to automate this with eos_designs with the right source port.
@gmuloc will follow up with the customer since im currently working in another project, to double check the functionality that they expect.
Many thanks,
David

This will set the management port based on the switch specific platform. This is common for all switches.

Hi @tgodaA , I am working with @gmuloc on this request from customer side.
I have updated our config reflecting the changes mentioned under EOS_designs config and this is working however i'm unsure how i would reflect the "{{ switch.mgmt_interface }}" magic variable for snmp as this structure references Management1 as a variable under local_interfaces: ie
snmp_server:
local_interfaces:
Management1:
vrf: MGMT
https://avd.sh/en/latest/roles/eos_cli_config_gen/index.html#snmp-settings
Above shows ability to define multiple interfaces but doesn't seem to allow for magic variable?
snmp_server:
local_interfaces:
< interface_name_1 >:
vrf: < vrf_name >
< interface_name_2 >:
< interface_name_3 >:
vrf: < vrf_name >
Would this still require a custom_structured_snmp_server: under a separate file?
Thanks
Mark

authors: dgonzalez85 markcheverton tgodaA

repo: aristanetworks/ansible-avd


text:
WhenStatusChanged returns incorrect status after adapter is turned off/on

Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[x] iOS
[] Android
[] tvOS
[] macOS
[] .NET Standard
UWP IS NOT SUPPORTED DURING THE BETA PERIOD - ONLY PRs ARE WELCOME FOR NOW

Version of OS(s) listed above with issue
iOS 12.1
Version of Library
6.2.2
Expected Behaviour
Steps to reproduce

Connect to BLE device
When the device is connected, turn off phone bluetooth adapter from the OS settings
Turn off the BLE device (or put it in a state where connections are not possible)
Turn on the phone bluetooth adapter.
WhenStatusChanged should be fired with Status == Connecting

Actual Behavior
If applicable, please include entire exception - type, message, stacktrace
WhenStatusChanged is fired with Status == Connected.
The convenience method device.WhenConnected() also returns immediately due to this issue.
Code of Conduct

No Library Update Requests
No Timeline Requests
Please read through the documentation and FAQs
If you have a complaint about the docs, FIX IT - DO NOT FILE IT HERE!  I won't guarantee everything is always 100% up-to-date since I am just 1 person.
Please be respectful of my time. I put a lot of effort into my libraries.  I try to support the issue requests within a day.  I'm not psychic, so please take the time to fill out the above form as complete as possible

Make sure background mode for peripherals is enabled.  Also note, you may need to hook to whenstaterestored

Please submit code as well.  Explanations are really not sufficient with this library

Just for clarification, is the device actually connected at the end of this - you are just expecting to see a Connecting event?

The device is not connected at the end of this and I'm expecting to see a Connecting event.
I have hooked into WhenStateRestored and also enabled the BLE background mode.
I will make a simple reproducible code sample and share it with you.

You should be listening for the connected event only.  Connecting is a bonus that isn’t always guaranteed especially in background scenarios.
Android & iOS are 2 completely different animals so try not to compare

Agreed. The event that I'm currently seeing is Connected when my device is off. Its the end of the day here so I'll investigate further and send you a code sample tomorrow.
Thanks for your quick response.

Ok the problem here is fundamentals.  That method is going to be trimmed if your app goes to the background.  Only the delegate will remains.  You need to subscribe to the delegate and store the subscription externally.  I don’t see WhenStateRestored being hooked anywhere.  Also, for issues like this, you really need to submit a small project to see all of the moving parts.
In any case, this is outside a scope of an issue based on what I’m seeing.  If you submit a better end to end taste case, I’m happy to take a look, but right now this looks more of a support case which I don’t do.  If you need something beyond this, I do offer consulting.

From looking into the code in more detail, I believe this behaviour is because of
https://github.com/aritchie/bluetoothle/blob/b46ad0db9d4b79af2a1427b41281d4f6003e78ed/Plugin.BluetoothLE/Platforms/Apple/Device.cs#L141-L142
I'm not sure I understand what the purpose of these lines are, but this would lead WhenStatusChanged to emit the previous state on a new subscription.

I don't want to go into potential "what ifs" on this.  I did give you some feedback on the initial issue with your approach.  If you can give me a reproducible sample with the feedback in place, I am happy to take a look or even fix an issue where applicable

authors: aritchie pravincarvalho

repo: aritchie/bluetoothle


text:
Missing method exception in Android although Init is present.

Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[] iOS
[] Android x
[] UWP
[] PCL

Version of OS(s) listed above with issue
7
Version of ACR UserDialogs Library
6.3.1
Expected Behaviour
Show loading dialog
Actual Behavior
Hi Alan,
Thanks for the library I use it in all my projects.
Dialog displays correctly in UWP but not in android. In MainActivity I have
UserDialogs.Init(() => (Activity)Forms.Context);
The application does not start (I cannot debug in any part of the app, the error comes before)
I tried different linker options, disable fast deploy but behavior is the same but somehow something tells me is either a bug or something very easy to fix but haven't found the solution yet.
12-07 16:44:00.535 E/mono    ( 1913): Unhandled Exception:
12-07 16:44:00.535 E/mono    ( 1913): System.MissingMethodException: Method 'Acr.UserDialogs.UserDialogs.Init' not found.
12-07 16:44:00.535 E/mono-rt ( 1913): [ERROR] FATAL UNHANDLED EXCEPTION: System.MissingMethodException: Method 'Acr.UserDialogs.UserDialogs.Init' not found.
Code of Conduct

No Library Update Requests
No Timeline Requests
Please read through the documentation and FAQs
Please be respectful of my time. I put a lot of effort into my libraries.  I try to support the issue requests within a day.  I'm not psychic, so please take the time to fill out the above form as complete as possible

Try uninstalling acr.userdialogs from all of your projects and reinstalling.  You could also delete all bin/obj folders before recompiling.  This is likely some compiler bug as I haven't had any issues like this before.
If that still doesn't work, please provide a reproducible sample

Hi,
Reinstalling the libraries fixed it. Thank you. I will close the issue.
Regards

authors: MrCapuchino aritchie

repo: aritchie/userdialogs


text:
Generic pairings for BW6

Part of the project of getting BW6-767 the outer curve for BLS12-381 into arkworks, supersedes (fixes) https://github.com/arkworks-rs/algebra/pull/624
Implements pairings for the BW6 family in a generic way, following https://yelhousni.github.io/phd.pdf, section 4.4.2

Introduces generic BW6 curve parameters: CM lifting cofactors and "trace modulo r"
Makes the existing miller loop implementation support both BW6-761 and BW6-767. It conflicts with https://github.com/arkworks-rs/algebra/pull/617. I suggest we adapt the latter later.
Implements the hard part of the final exponentiation in generic way ~for curves with "trace modulo r" = 0 (this is BW6-767)~
The existing hand-optimized hard part for BW6-761 moved to the curve specification.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (master)
[x] Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
[x] Wrote unit tests
[x] Updated relevant documentation in the code
[x] Added a relevant changelog entry to the Pending section in CHANGELOG.md
[x] Re-reviewed Files changed in the GitHub PR explorer

A fun observation. In the Miller loop computation we are currently free to get rid of
        if Self::ATE_LOOP_COUNT_1_IS_NEGATIVE {
            f_1.cyclotomic_inverse_in_place();
        }

For BW6-761 nothing changes as it has X > 0. BW6-767 isn't used afaik, so we have freedom here. @yelhousni wdyt

@swasilyev On second thoughts this should go into breaking changes not features section in the CHANGELOG, WDYT?

Btw, i think that currently the change is not breaking, as i moved the existing curve-specific implementation to the curve definition in https://github.com/arkworks-rs/curves/pull/156. Though i would remove it later in another pr.

I think it's still a breaking change because defining a BW6 curve now requires specifying more constants.

@swasilyev I think the last part is to move the CHANGELOG entry from features to breaking changes: I agree with Pratyush that is indeed a breaking change on the API.

authors: Pratyush mmagician swasilyev

repo: arkworks-rs/algebra


text:
KZG10::open and friends visibility

Summary

Streamline visibility in mod kzg: currently it offers entities which can be obtained only from other modules which is confusing.
Problem Definition

fn open... are pub(crate) and it seems like it's the only way to get Proof in kzg10; of course, it is used in other modules, but it makes disentangling that thing quite confusing.
Proposal

Either pub those functions from kzg, either pub use entities from kzg in modules where they can actually be obtained and pub(crate) them in kzg.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Thanks for noticing this papercut! Making the methods pub would be fine; would you like to make a PR?

Yep! Just wasn't sure which path was better, now that's clear.

authors: Pratyush skaunov

repo: arkworks-rs/poly-commit


text:
merge from template-sync/template-arlac77-github

.github/workflows/update_package_lock.yml

chore: add gr2m/create-or-update-pull-request-action@v1.10.0 (jobs.update_package_lock.steps.uses)

.github/workflows/update_readme_api.yml

chore: add gr2m/create-or-update-pull-request-action@v1.10.0 (jobs.update_readme_api.steps.uses)

Pull Request Test Coverage Report for Build 11166946897
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.807%

Totals

Change from base Build 11077550130:
0.0%

Covered Lines:
436

Relevant Lines:
461

💛  - Coveralls


text:
🛑 Maisondejuncarot is down

In bcb3168, Maisondejuncarot (https://maisondejuncarot.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Maisondejuncarot is back up in 8a819bd.

repo: armandleopold/statuspage


text:
Scan doesn't continue after switch on

Hello Armel, I have mapped this function to a long press of the side button F1. If i start scanning by long pressing the "*" key, switch off then on the transceiver, then scanning continues. But not in case if i start scanning by long pressing the side button.

Hello,
Thank you. That's correct.
This problem has already been reported and will be fixed in the next release.
Armel F4HWN.

Fixed in v3.7 😌

authors: armel kocickamia


text:
Got Response 422 "worker: OS and/or package manager are not supported"

Hello everyone,
I am using clair scanner, and while i start the scan "clair-scanner-master ./clair-scanner --ip 192.168.1.100  alpine:edge"
where 192.168.1.100 is my en0 address. i am running into below issue , Can anyone see what could be causing this issue ?
➜  clair-scanner-master ./clair-scanner --ip 192.168.1.100  alpine:edge
2020/11/19 07:38:30 [INFO] ▶ Start clair-scanner
2020/11/19 07:38:30 [INFO] ▶ Server listening on port 9279
2020/11/19 07:38:30 [INFO] ▶ Analyzing 59091c18eee0b24b5e9777d96b4681f10972f689173768864bfc2cb78fbbf244
2020/11/19 07:38:31 [CRIT] ▶ Could not analyze layer: Clair responded with a failure: Got response 422 with message {"Error":{"Message":"worker: OS and/or package manager are not supported"}}

I got the same error when scanning an image based on almalinux.  Really strange.

Me too

authors: DonaldKallman JDuvillard kalrashubham49

repo: arminc/clair-scanner


text:
🛑 NWTFV is down

In a1e3d21, NWTFV (https://nwtfv.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: NWTFV is back up in 8be651c.

repo: arnef/status


text:
🛑 NWTFV is down

In 94dba39, NWTFV (https://nwtfv.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: NWTFV is back up in 854a489.


text:
🛑 NWTFV is down

In 6b3ad82, NWTFV (https://nwtfv.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: NWTFV is back up in 1f6256e after 282 days, 7 hours, 24 minutes.


text:
exceed Table for long links

Thank you for reporting this issue. Will get this fixed in a patch release as soon as possible.

repo: arnellebalane/simple-todo


text:
fix js-loader on pretty much all branches

change jsx to js in test-property and rm questionmark

fixed on all branches, left jsxon electron branch so react can be easily used

repo: arno-s/webpack-starter

license: isc


text:
stage.tasks.signals.countChanged error after updating a surface representation

Hi, this pen should clarify what i mean. In the console is thrown an error: Maximum call stack size exceeded at e.setParameters

don't see that in the latest version anymore, see https://codepen.io/arose/pen/QQyVKr?editors=0010

Thank you!

authors: arose giagitom

repo: arose/ngl


text:
added video of more than 15 mins on css

link for video:https://drive.google.com/file/d/1x-lA5OGtdxSz7g_RqsnwU4QGsBzV-U8Y/view?usp=sharing

🛠 Fixes Issue

👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

@myhacktech ur voice volume is very low i guess from next try to improve it either use a earphone or speak loudly

@myhacktech this time give u lvl 2 but from next time add at least 2 videos of 10-15 mins min for lvl2


text:
intersect -wo showed 1bp error

Here is the result of bedtools intersect -wo -a XXX -b YYY

Chr1    PHAST   phastCons_predicted     4109    4111    11.7179378236474        +       .       gene_ID "12";        Chr1    3995    4276    2

Actually the overlapped length should be 3bp (4109, 4110 and 4111) rather than 2.

Can you please show the original intervals from XXX and YYY?

XXX

Chr1    PHAST   phastCons_predicted     4109    4111    11.7179378236474        +       .       gene_ID "12";

YYY

Chr1    3995    4276

$ bedtools intersect -wo -a /tmp/a.gtf -b /tmp/b.bed
Chr1	PHAST	phastCons_predicted	4109	4111	11.7179378236474	+	.	gene_ID "12";	Chr1	3995	4276	2

# Switching the files gives the correct result for  the overlap.
$ bedtools intersect -wo -b /tmp/a.gtf -a /tmp/b.bed
Chr1	3995	4276	Chr1	PHAST	phastCons_predicted	4109	4111	11.7179378236474	+.	gene_ID "12";	3

Thanks. But how to avoid this except switching files?

Are you aware that the bed file format is 0-based and half-closed, which means that the end coordinate is not included in intersection calculations? That is why the overlap is 2.

The XXX file is gtf format instead of bed

@arq5x This problem still happens, could you please show how to fix it?

@yewero
The following commit fixes this problem: -wo must report 1 bp of overlap b/w VCF SNP and overlapping 1bp BED. … https://github.com/arq5x/bedtools2/commit/5e74a17da4c044c732050349271b20bd46cb07c3 as it checks if the input record is zero or one based when it calculates the number of overlapping bases.
$ ./bedtools intersect -wo -a /tmp/a.gtf -b /tmp/b.bed
Chr1    PHAST   phastCons_predicted     4109    4111    11.7179378236474        +       .       gene_ID "12";       Chr1    3995    4276    3

$ ./bedtools intersect -wo -b /tmp/a.gtf -a /tmp/b.bed
Chr1    3995    4276    Chr1    PHAST   phastCons_predicted     4109    4111    11.7179378236474   +.       gene_ID "12";   3

@ghuls Thanks. So can the lastest version produce correct output?

authors: ATpoint arq5x ghuls yewero


text:
Parallel Bedtools

Hi Bedtools Team,
Is there a way to run genomeCoverageBed in parallel on multiple threads? Or is GNU parallel the only way? Kindly advice. Thanks.

Unfortunately there is no such option at this point.


text:
Gemini API Provider

I'm currently working on a Gemini API (Google) provider for this project. I'm doing it for a personal project of mine, but I figure it would be useful if I made a pull request with my code.
Would this be something the project would benefit from?

A couple things I noticed that might be useful to change (outside of the actual Google provider).

Consider creating types for each individual provider. Right now, you can mix-and-match different LLM models and providers - even if those providers don't match to that model. I assume it will give an error later, but TypeScript should give an error natively no? Here's what I mean in code.

/** Change this **/
export interface CopilotOptions {
  provider?: CopilotProvider;
  model?: CopilotModel | CustomCopilotModel;
}

/** To this *//

export interface CopilotOptions {
  provider?: CopilotProvider;
  model?: AnthropicOptions | OpenAIOptions | GroqOptions | GoogleOptions
}

export interface AnthropicOptions { /** You could add a parent interface to extend off of to maintain consistency among  different options interfaces **/

  provider: "anthropic"
  model: AnthropicModel

}

/** ... continue for OpenAI, Groq and Gemini models **/

Give more info in error messages. To trace errors when developing, I had to use console log and trace down the specific HTTP library used and console.log my error message there. This could be solved by including the actual error message given by the different APIs.

/** Current implementation for error handling **/

const request = async <
  ResponseType,
  BodyType = undefined,
  MethodType extends Method = Method,
>(
  url: string,
  method: MethodType,
  options: RequestOptions<BodyType, MethodType> = {},
): Promise<ResponseType> => {
  const headers = {
    'Content-Type': 'application/json',
    ...options.headers,
  };

  const body =
    method === 'POST' && options.body
      ? JSON.stringify(options.body)
      : undefined;

  const response = await fetch(url, {
    method: method,
    headers,
    body,
    signal: options.signal,
  });

  if (!response.ok) {
    throw new Error(
      `${response.statusText || options.fallbackError || 'Network error'}`,
    );
  }

  return response.json() as Promise<ResponseType>;
};

/** Possibly improved implementation **/

const request = async <
  ResponseType,
  BodyType = undefined,
  MethodType extends Method = Method,
>(
  url: string,
  method: MethodType,
  options: RequestOptions<BodyType, MethodType> = {},
): Promise<ResponseType> => {
  const headers = {
    'Content-Type': 'application/json',
    ...options.headers,
  };

  const body =
    method === 'POST' && options.body
      ? JSON.stringify(options.body)
      : undefined;

  const response = await fetch(url, {
    method: method,
    headers,
    body,
    signal: options.signal,
  });

  if (!response.ok) {
    throw new Error(
      `${await response.json() || ""}${response.statusText || options.fallbackError || 'Network error'}`,
    );
  }

  return response.json() as Promise<ResponseType>;
};

Let me know if any of these changes could be useful - I will be happy to help implement them!

Thank you! The Gemini API was exactly what I was thinking about adding to Monacopilot, and you made it happen. The suggestions are great, and I can implement them in your PR. Again, thank you!

authors: arshad-yaseen leftmove

repo: arshad-yaseen/monacopilot


text:
Objects should reflect parse-rules, not ast nodes

As the title says, I should refactor to have a one-to-one correspondence of objects to parse rules and leave AST nodes out of the parsing control flow.

This would also allow to separate ir-generation from parsing as the former is implemented on the AST classes rather than on objects

repo: artemisYo/tara

license: Unlicense


text:
Automate the gathering and publishing of new toolchain versions

An attempt at automatically updating the toolchain version.
In short what this PR does:

Get the current RUST_VERSION from the Rakefile
I originally though of using some grep/regex magic to get this value, but thought: "Ruby knows best what it's looking for".
Get the latest release from rust-lang/rust (This is what github determines as "latest" - so there is some limitation there if patches for older versions are released)
IF the values are different:

update the value with sed magic in the file (Makes me second guess my "ruby knows best" comment above) and runs bundle exec rake toolchain:sync
Create[/Update] a PR to merge.

I've had some success running this action with act, however for some reason I'm getting a "Could not read from remote repository" when it tries to run git remote prune origin here: https://github.com/peter-evans/create-pull-request/blob/main/src/create-pull-request.ts#L138. (running with act -s GITHUB_TOKEN="$(gh auth token)" -j check-toolchain-version, have also tried a hardcoded PAT token, to no success).
I can confirm everything works up until the git pr/commit part of it, so that's all good. In theory the last PR part should "Just work", but it might be a wait and see on the next rust release. I fear having a dirty tree (only easy way to test this) is causing some issue somewhere.
Fixes: #192

@lopopolo Woo! https://github.com/b-n/gh-action-test/blob/main/.github/workflows/create-pr.yaml generates https://github.com/b-n/gh-action-test/pull/1 so the answer is yes - we can play with variables, and yes - it works. I added you as a contributor to that repo so you can press the play button here: https://github.com/b-n/gh-action-test/actions/workflows/create-pr.yaml (if you just want to see it working :sweat_smile:
I'll fix up this PR tomorrow at some point. The key takeaways:

It works
It supports variable interpolation
It does require some permissions on the action runner - I'll see if I can find the values in terraform and add to project-infrastructure if applicable.

w.r.t runner permissions: I can't find a terraform setting for this specific switch: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#preventing-github-actions-from-creating-or-approving-pull-requests.
Apparently it's possible to just us gh commands on github runners without having to use this particular setting (haven't tested). It seems a bit redundant though whether it's from a action or whether it's from your own gh scripting to restrict this functionality, so I'm not sure what's the best course.
The create-pull-request does use just the plain github api from what it looks. I do wonder whether providing a machine token to the token: attribute (e.g. a machine PAT token) would actually circumvent this setting. Is the one available for the artichoke org?

@lopopolo I have one tiny other little idea:

Even though not "needed", we can create a rust-toolchain.toml file in this repo.
In the rakefile, we read the current version from rust-toolchain.toml instead of inside the artichoke main repo: https://github.com/artichoke/artichoke/blob/trunk/Rakefile#L201
We read/update the value in rust-toolchain.toml via grep/sed.

Why? Because then we can use the exact same github action in this repo as we can in the main artichoke repo. Thoughts?

Sorry, another message - eventually I might try and commit a dependabot-core for rust-toolchain. Looks like an old issue is people wanting it a long time ago: https://github.com/dependabot/dependabot-core/issues/1758#issuecomment-834333421
Dependabot-core usage restricts the running of pre-post commit things, but there is apparently a way to bump commits on top of dependabot PRs, so that could be done for the toolchain:sync part: https://github.com/dependabot/dependabot-core/issues/1758#issuecomment-834333421 (This is a big TIL for me today - kinda cool :sweat_smile:)

w.r.t runner permissions: I can't find a terraform setting for this specific switch: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#preventing-github-actions-from-creating-or-approving-pull-requests.

at https://github.com/artichoke/docker-artichoke-nightly/settings/actions:

There's an org setting I can flip to enable us turning that on in this repo. Let me look to see if I can terraform this.

@lopopolo I have one tiny other little idea:

Even though not "needed", we can create a rust-toolchain.toml file in this repo.
In the rakefile, we read the current version from rust-toolchain.toml instead of inside the artichoke main repo: https://github.com/artichoke/artichoke/blob/trunk/Rakefile#L201
We read/update the value in rust-toolchain.toml via grep/sed.

Why? Because then we can use the exact same github action in this repo as we can in the main artichoke repo. Thoughts?
Could also make it a published action. e.g.
- uses: artichoke/rust-toolchain-dependabot
  with:
    toolchain_path: ./rust-toolchain.toml
    toolchain_syntax: toml
    pre_commit_command: "bundle exec rake toolchain:sync"

"A github action that will check and update the rust toolchain. You can provide your own command to update any other files prior to commiting"

this sounds pretty sweet and I'd be interested to experiment here. Let me know if you want me to set up a repo for you

@lopopolo I'll merge this one for now after incorporating the feedback. I'm sure the action will fail on the run unless those options are action perms are added.
Also, more than happy to give a generic action a go, so yes please to a repo!

I tweaked the setting and bumped the job. It worked!

https://github.com/artichoke/docker-artichoke-nightly/pull/198

It looks like PRs created with this workflow don't trigger github status checks to run on PRs: https://github.com/peter-evans/create-pull-request/issues/48
A workaround I've found is to close and then reopen the PR.

authors: b-n lopopolo

repo: artichoke/docker-artichoke-nightly


text:
Trained model output seems illegible

I trained both redpajama-3b and llama-7b for about 1000 iterations.
The loss converged to a pretty low value (0.3) by this time.
But when I load the adapter and try to predict something (using inference notebook code as well as generate.py), I get random unicode tokens in my ouput. Then english answers are not related too much to the original code.
What can be the reason for this?

7B is a tiny model. You cannot expect any quality in the output.

No I meant it should still be slightly relatable and not filled with gibberish tokens.

@KKcorps were you able to find the issue and get any meaningful output from the trained models?

@KKcorps this happened when my learning rate was too high.

@KKcorps this happened when my learning rate was too high.

I was able to solve this using a different base model.
but if learning rate it too high then the training/validation loss should also not keep on dropping right?

authors: Birch-san KKcorps amdnsr phalexo

repo: artidoro/qlora