text:
Develop/dispatcher demo

This PR introduces a two new libraries (rmf_battery & rmf_task) along with significant changes to the fleet adapters as summarized below:

rmf_battery
The objective of this library is to model the battery drain of mobile robots due to locomotion and on-board devices.

rmf_battery::agv::BatterySystem class which is a container for battery properties of the vehicle.
rmf_battery::agv::MechanicalSystem class which is a container for mechanical properties of the vehicle.
rmf_battery::agv::PowerSystem class which is a container for power system/device properties of the vehicle.
rmf_battery::MotionPowerSink pure abstract class which contains compute_change_in_charge(rmf_traffic::Trajectory trajectory). A sample implementation is provided by rmf_battery::agv::SimpleMotionPowerSink
rmf_battery::DevicePowerSink pure abstract class which contains compute_change_in_charge(double run_time). A sample implementation is provided by rmf_battery::agv::SimpleDevicePowerSink

The expectation is for the user to use a combination of MotionPowerSink and DevicePowerSink(s) to compute the expected battery drain for various applications

rmf_task
The objective of this library is to define various task "requests" and a task allocation solver to assign n task requests across m robots while factoring in the battery drain for the robots. Charging tasks are automatically included in the plan such that robots will head back to their chargers to recharge before continuing with the remaining tasks.

Factories for ChargeBattery, Clean, Deliver and Loop task requests (rmf_task::requests::...)
rmf_task::agv::TaskPlanner: API for solving task allocation problem. Contains greedy_solve() and optimal_solve() methods. (With caching, the optimal_solve() method has comparable run times with the greedy_solve() method and produces solutions with lower costs)

Changes to rmf_fleet_adapter

The soon-to-be deprecated full_control example updates the RMF schedule with the itinerary of waypoints in the docking path of a robot in docking mode
Integration with dispatcher framework. FleetUpdateHandle subscribes to rmf_task/bid_notice topic to receive a new task request to accommodate into the robot's schedule. A proposal is computed and submitted via rmf_task/bid_proposal to the dispatcher node. When a DispatchRequest msg is received via rmf_task/dispatch_request, the schedule of the robot is updated with the previously computed proposal.
Added set_task_planner_params() , set_recharge_threshold(),  accept_task_requests() functions to FleetUpdateHandle API.
Added update_battery_soc() and get_participant() methods to RobotUpdateHandle API.
Various modifications to RobotContext, Task and TaskManager APIs. The TaskManager now has a timer which periodically checks if the next task in its queue is ready for deployment and if so will begin execution of the same.
Added factories for converting rmf_task::Request into rmf_fleet_adapter::Task for various task requests (ChargeBattery, Clean, Delivery & Loop). These are found in src/rmf_fleet_adapter/tasks/
WaitForCharge phase which finishes execution when the battery soc of the robot reaches/exceeds an expected percentage.
Updates to the full_control launch file to capture parameters required for battery modelling and task allocation planning.

rmf_fleet_msgs

Added Dock, DockParameter and DockSummary msgs to propagate information on the docking paths for fleets. Presently, a mock_docker node publishes this information via a dock_summary topic which the fleet adapter subscribes to.

rmf_task_msgs

Added BidNotice, BidProposal, DispatchRequest, TaskProfile, TaskType msgs which are used during the bidding process.

Summary of Dispatcher framework:

With the new system, we have a Dispatcher Node that initiates a bidding process for new task requests.  When the Dispatcher receives a new request from a UI, it sends out a BidNotice msg to all the fleet adapters. If a fleet adapter is able to process that request, it submits a BidProposal back to the Dispatcher. (The TaskPlanner is used by the fleet adapters to determine how best to accommodate the new request). The Dispatcher compares all the BidProposals received and then submits a DispatchRequest msg with the fleet name of the robot that the bid is awarded to. There are a couple different ways the Dispatcher evaluates the proposals such as fastest to finish, lowest cost,etc which can be configured.
Battery recharging is tightly integrated with the new task planner. ChargeBattery tasks are optimally injected into a robot's schedule when the robot has insufficient charge to fulfill a series of tasks. Currently we assume each robot in the map has a dedicated charging location as annotated with the is_charger option in the traffic editor map.

This all looks go to me. Let's just update the CHANGELOGs now to reflect the content of this PR.
I think the changes are sort of incomplete without https://github.com/osrf/rmf_core/pull/228, so I would suggest we get that to an approved state, then merge it into this PR, and then merge them both into master together.

authors: Yadunund mxgrey


text:
Feature: define the starter workflows

User who install scorecards from the GH market place will see a default workflow automatically generated.
This PR defines the workflow that is used as template by GH market place. Note that we need to submit a PR at https://github.com/actions/starter-workflows for the changes to take effect. This PR only defines them locally in our repo so that we can discuss it and keep a copy of what it is.
Note: this PR follows the naming conventions of https://github.com/actions/starter-workflows for files and folders

friendly ping. This is blocking the the submission of the workflow to GitHub, which in turn is blocking the verification of our action on the market place.

Thanks everyone. Let's merge and we can re-visit. I want to get feedback from GitHub as well in the meantime

source: gharchive/pull-request

repo: ossf/scorecard-action

license_type: permissive

license_source: github-api


text:
:warning: OSV scanner integration

What kind of change does this PR introduce?
Feature

[X] PR title follows the guidelines defined in our pull request documentation

What is the current behavior?
Currently the vulnerability check only checks if the HEAD commit hash has any vulnerability specified in OSV.dev. Most of the time this will return 10/10.
What is the new behavior (if this is a feature change)?**
This integrates the OSV-Scanner library, which will scan for manifest and SBOM files, retrieve the dependencies, and match those dependencies with OSV.dev database as well. (The commit hash check is still being done, though through the osvscanner library rather than directly setting up a client to use the OSV API).

[X] Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes
Fixes #2162
Special notes for your reviewer
Currently the e2e tests fail because the Scorecard score has changed since osvscanner found 3 vulnerabilities. I can change the expected results to match, but this might cause more issues in the future as new vulnerabilities are discovered, causing tests to break even though there are no code changes. Not sure what the best way to resolve this.
Does this PR introduce a user-facing change?
Yes, TODO.

TODO!

a challenge to adding the unit tests for this is /that it will be picked up as a vulnerability, even though it's part of the test data in the repository. Any ideas for a quick fix? Eventually we want to have project level ignore files for osv-scanner.

unit tests should be hermetic and should not be making any network calls. You can use the mocks generated for the interfaces to write any unit tests and it shouldn't affect any vulnerability finding.

unit tests should be hermetic and should not be making any network calls. You can use the mocks generated for the interfaces to write any unit tests and it shouldn't affect any vulnerability finding.

That makes sense, what about e2e tests? It looks like a some repositories are set up in ossf-tests, can I set up a project with some lockfiles that contain known vulnerable dependencies?

unit tests should be hermetic and should not be making any network calls. You can use the mocks generated for the interfaces to write any unit tests and it shouldn't affect any vulnerability finding.

That makes sense, what about e2e tests? It looks like a some repositories are set up in ossf-tests, can I set up a project with some lockfiles that contain known vulnerable dependencies?

Yes that's possible. Curious, does OSV-Scanner look at direct dependencies only or transitive dependencies too?

unit tests should be hermetic and should not be making any network calls. You can use the mocks generated for the interfaces to write any unit tests and it shouldn't affect any vulnerability finding.

That makes sense, what about e2e tests? It looks like a some repositories are set up in ossf-tests, can I set up a project with some lockfiles that contain known vulnerable dependencies?

Yes that's possible. Curious, does OSV-Scanner look at direct dependencies only or transitive dependencies too?

https://github.com/ossf-tests/scorecard-check-osv-e2e
Send a PR and cc me on it - I don't receive notifications automatically for these repos

@another-rex - Please try to finish this soon, so a scorecard release can be cut by end of week or coming Monday.

unit tests should be hermetic and should not be making any network calls. You can use the mocks generated for the interfaces to write any unit tests and it shouldn't affect any vulnerability finding.

That makes sense, what about e2e tests? It looks like a some repositories are set up in ossf-tests, can I set up a project with some lockfiles that contain known vulnerable dependencies?

Yes that's possible. Curious, does OSV-Scanner look at direct dependencies only or transitive dependencies too?

OSV-Scanner also looks at transitive dependencies, since it scans the lockfile, which generally lists the transitive dependencies.

@another-rex - Please try to finish this soon, so a scorecard release can be cut by end of week or coming Monday.

Is there a specific reason we want to cut a release?

@another-rex - Please try to finish this soon, so a scorecard release can be cut by end of week or coming Monday.

Is there a specific reason we want to cut a release?

I mean this is a very strong feature where scorecard was not looking at transitive deps before and can now can look at vulns transitively. By release, i just meant a minor release (not major announcement or anything for scorecard). OSV-scanner will go out next week, so it will be nice for people to try in scorecard too, not a big deal if you need more review time.

@another-rex - Please try to finish this soon, so a scorecard release can be cut by end of week or coming Monday.

Is there a specific reason we want to cut a release?

I mean this is a very strong feature where scorecard was not looking at transitive deps before and can now can look at vulns transitively. By release, i just meant a minor release (not major announcement or anything for scorecard). OSV-scanner will go out next week, so it will be nice for people to try in scorecard too, not a big deal if you need more review time.

Yes, that makes sense! 👍
Thanks for the update. We need to get better at releases. To be honest, we need to improve our release process by calling out new features and breaking changes in the release notes.

Integration tests success for
[f405955]
(https://github.com/ossf/scorecard/actions/runs/3654448698)

Can you please rebase with the main? Also, DCO is missing. Thanks

Can you please rebase with the main? Also, DCO is missing. Thanks

Done!

authors: another-rex azeemshaikh38 inferno-chromium laurentsimon naveensrinivasan

repo: ossf/scorecard


text:
SECURITY.md

As part of the ongoing community health check effort, each WG should have a SECURITY.md in place. Currently all WGs do not have one and the first repo found with one was Scorecard.
Please review and modify the example below to serve as the template for each WG to use or build from as their SECURITY.md. Would a week be long enough to provide input? If so, this can be presented to the TAC at the next meeting on 17Oct2023. Open to other timelines as well.
Reporting Security Issues
To report a security issue, please email [---] with a description of the issue, the steps you took to create the issue, affected versions, and, if known, mitigations for the issue.
Our vulnerability management team will respond within 3 working days of your email. If the issue is confirmed as a vulnerability, we will open a Security Advisory and acknowledge your contributions as part of it. This project follows a 90 day disclosure timeline.

Hi - are you sure?
I think we generally do NOT want people to report a vulnerability to the WG. All the WG will do is eventually pass the report down to the responsible project. That extra step would add unnecessary delay. It would also mean that the project wouldn't (at first) be directly talking with the finders. All bad things.
The general policy of the LF is to contact the specific project in charge of the vulnerable component. That speeds response.
I walked through all the code repos, and almost all of them already have SECURITY.md files. I think that's the better measure. I didn't check on SECURITY.md files at the working group level, because I thought that's frankly too high a level.
So: I'm not sure we want any WG to have a SECURITY.md file. Are we sure?  I guess they could remind people to report to the specific project, and then only report to the WG or OpenSSF if they got no response from the project. That kind of SECURITY.md file would NOT look anything like a "send a message here to get a security response" message. So if you think WGs should have SECURITY.md files, I suggest something like this:
Per the Linux Foundation Vulnerability Disclosure Policy, if you find a vulnerability in a project maintained by the OpenSSF, please report that directly to the project maintaining that code. If you've been unable to find a way to report it, or have received no response after repeated attempts, please contact the OpenSSF security contact email, security @ openssf.org. Thank you.

I agree with David, under our charter WG are not software focused, projects are. So, on that basis we should rather make sure that all projects have a SECURITY.md file, not WGs.

Thank you for the feedback. This gets us to where we want to be with consistency across repos. Can we proceed with David's suggestion as a second line of defense at the WG level? Staff will continue the audit and work with individual projects if security.md files are missing.
 Per the [Linux Foundation Vulnerability Disclosure Policy](https://www.linuxfoundation.org/security), if you find a vulnerability in a project maintained by the OpenSSF, please report that directly to the project maintaining that code. If you've been unable to find a way to report it, or have received no response after repeated attempts, please contact the OpenSSF security contact email, security @ openssf.org. Thank you.

+1 to David's proposal.

Discussed during Best WG meeting. No opposition to David's recommendation. Shared with WG leads and will update repos this week. WGs have been asked to modify and/or merge the PRs by end of month.

source: gharchive/issue

authors: afmarcum david-a-wheeler drusso-rh lehors

repo: ossf/wg-best-practices-os-developers


text:
C fallthrough: Which version of the Linux kernel?

The current text says, "The C17 standard does not provide a mechanism to mark intentional fallthroughs....". It then notes the Linux kernel. Is it version 5.10 or 6.4 that started using this?

Commits I've found for fallthrough

https://github.com/torvalds/linux/commit/f7a858bffcddaaf70c71b6b656e7cc21b6107cec v6.4-rc1
https://github.com/torvalds/linux/commit/192614010a5052fe92611c7076ef664fd9bb60e8 (v4.11-rc1)
https://github.com/torvalds/linux/commit/b5bf1733d6a391c4e90ea8f8468d83023be74a2a (v4.11-rc1)

Could be missing some bits. I've not found a reference around 5.10

I am also not sure where the reference to 5.10 originates from. I was responsible for adding the last sentence of the section, referring to 6.4 after I also found https://github.com/torvalds/linux/commit/192614010a5052fe92611c7076ef664fd9bb60e8 to be the first commit with fallthrough in the form the guide originally referred to.
Addressing this inconsistency in #494 that also removes the redundant note below the example.

authors: 06kellyjac david-a-wheeler thomasnyman


text:
Code blocks do not wrap lines, such as shell blocks.(shell code )

Code blocks do not wrap lines, such as shell blocks.(shell code )

@itldr it seems to me that this is intentional.  That's what GitHub itself does, e.g.:

The code block (denoted by three tildes: ```...```) is a separate entity, and not supposed to have word wrap, whereas the inline code (denoted by one tilde: `...`) is just a normal sentence except it's styled as code, and therefore it should be wrapped as normal sentences are.

Note:
Inline, three tildes (```) has the same effect as a single tilde (`).  e.g: this is made by three tildes: code, this is made by one tilde: code.
When opening ``` is on one line and the closing ``` is on another, it becomes a code block:
code

Not so, though, for the single tilde:
code

Note:
Inline, three tildes (```) has the same effect as a single tilde (). e.g: this is made by three tildes: code, this is made by one tilde: code`.
When opening is on one line and the closing is on another, it becomes a code block:
code

Not so, though, for the single tilde:
code

What you said is very reasonable. Thank you.However, if each line of code in the block is too long, it will feel incongruous to display it on the page.

Then, I think you should always use single tildes (`) for these pages.  That should make word wrap always happen.

Then, I think you should always use single tildes (`) for these pages. That should make word wrap always happen.

Yes, I should use (`) more than ().For me () is a convenient way to write it, maybe I'm lazy, haha.You always know so much, and I will continue to learn from you.thank you！

authors: bl-ue itldr

license: mit

license_source: bigquery


text:
Practice

I still couldn't test the last feature of the blog: "Show the 10 most recent entries". I tried to mock some objects to count the number of method calls but it didn't worked. I left the approach commented on the last test called whenShowRecentthen10MoreRecent. I would like to fix this before doing merge but I requested the pull so you can see my code.

Manu try to read a little more about mocking. Think about your mock must return whatever you need when you need to invoke some method.
It means :
when yourMock.methodA then return valueA

Ok, now you can see some mocking. Tell what you think about.

Great! You can merge it now.

authors: otromanuel scalderon


text:
How to get a standalone browser client js?

I need to work this without require dependencies
How to export a standalone client js version?

It is on npm: https://www.npmjs.com/package/rich-text

I do install by npm, but I see no dist/standalone js in the package.

My mistake--I mistook this project for another one I have. There is no browser build. You need to use webpack, browserify or something for use on the browser client.

repo: ottypes/rich-text


text:
[DSI-6] New versioning scheme

Description
Versioning for this OFH design system toolkit will start from v2 and a new Changelog will be maintained (see the JIRA ticket for more details and context).
This PR sets up the new Changelog (after renaming the original one) with the very first release as v2.0.0-alpha.0. I've also added instructions to the README for making a new release (we can move this to proper dev docs in the future once we decide how we want to do that).
I'll finish making the new release after this PR is merged, to follow the process laid out in the README (with the main difference being the name of this branch, since this is a special branch to set things up in the first place).

@simonplend-yld – I've pushed up a fixup commit (https://github.com/ourfuturehealth/design-system-toolkit/pull/6/commits/4088cb0950e11f6b80c995f029b98759f4bb88dd) to address your comments 👍🏽

repo: ourfuturehealth/design-system-toolkit

license: MIT


text:
Recursive Pydantic objects are not supported for basic patterns

Recursive Pydantic definitions seem unsupported for lists, unions, and optionals. My understanding is these are the basic use cases.
A reproducible example is provided below:
import json

from typing import List, Optional, Union
from pydantic import BaseModel

from outlines.text.json_schema import build_regex_from_schema

class TaskOptional(BaseModel):
    subtask: Optional['TaskOptional']

class TaskWrapperOptional(BaseModel):
    task: TaskOptional

class TaskUnion(BaseModel):
    subtask: Union['TaskUnion', None]

class TaskWrapperUnion(BaseModel):
    task: TaskUnion

class TaskList(BaseModel):
    subtask: List['TaskList']

class TaskWrapperList(BaseModel):
    task: TaskList

TaskWrapperOptional.model_rebuild()
TaskWrapperUnion.model_rebuild()
TaskWrapperList.model_rebuild()

regex = build_regex_from_schema(json.dumps(TaskWrapperOptional.model_json_schema()))
# NotImplementedError:
# @ outlines/text/json_schema.py:308

regex = build_regex_from_schema(json.dumps(TaskWrapperUnion.model_json_schema()))
# NotImplementedError:
# @ outlines/text/json_schema.py:308

regex = build_regex_from_schema(json.dumps(TaskWrapperList.model_json_schema()))
# RecursionError: maximum recursion depth exceeded while calling a Python object
# @ outlines/text/json_schema.py:174

I'd be interested in adding this functionality but I'm unsure as to what an "unrolled" recursive definition would look like in terms of the generated regex.

Thank you for opening an issue! It looks like something we should be able to support. Do you mind pasting the JSON schema for these 3 models here?

In all cases, the schema is available through TaskWrapperxxx.model_json_schema(). I'll post an example of each here as well.
TaskWrapperOptional
{
    "$defs": {
        "Task": {
            "properties": {
                "name": {
                    "title": "Name",
                    "type": "string"
                },
                "subtasks": {
                    "default": [],
                    "items": {
                        "$ref": "#/$defs/Task"
                    },
                    "title": "Subtasks",
                    "type": "array"
                }
            },
            "required": [
                "name"
            ],
            "title": "Task",
            "type": "object"
        },
        "TaskOptional": {
            "properties": {
                "subtask": {
                    "anyOf": [
                        {
                            "$ref": "#/$defs/Task"
                        },
                        {
                            "type": "null"
                        }
                    ]
                }
            },
            "required": [
                "subtask"
            ],
            "title": "TaskOptional",
            "type": "object"
        }
    },
    "properties": {
        "task": {
            "$ref": "#/$defs/TaskOptional"
        }
    },
    "required": [
        "task"
    ],
    "title": "TaskWrapperOptional",
    "type": "object"
}

TaskWrapperUnion
{
    "$defs": {
        "TaskUnion": {
            "properties": {
                "subtask": {
                    "anyOf": [
                        {
                            "$ref": "#/$defs/TaskUnion"
                        },
                        {
                            "type": "null"
                        }
                    ]
                }
            },
            "required": [
                "subtask"
            ],
            "title": "TaskUnion",
            "type": "object"
        }
    },
    "properties": {
        "task": {
            "$ref": "#/$defs/TaskUnion"
        }
    },
    "required": [
        "task"
    ],
    "title": "TaskWrapperUnion",
    "type": "object"
}

TaskWrapperList
{
    "$defs": {
        "TaskList": {
            "properties": {
                "subtask": {
                    "items": {
                        "$ref": "#/$defs/TaskList"
                    },
                    "title": "Subtask",
                    "type": "array"
                }
            },
            "required": [
                "subtask"
            ],
            "title": "TaskList",
            "type": "object"
        }
    },
    "properties": {
        "task": {
            "$ref": "#/$defs/TaskList"
        }
    },
    "required": [
        "task"
    ],
    "title": "TaskWrapperList",
    "type": "object"
}

Anyone who's interested in this feature should know that CFG-structured generation is required to truly support it.

I saw there is a pull request that implement a beta version of CFG guided generation, which is amazing. But the request failed, is that everything thats necessary to get this functionality available?
The PR failed due to a regression in a performance benchmark, i believe in a measurement that didnt really exist before, so is there anything that i can do to test/help get this recursive field functionaility over the line?
I really need this recursive functionality, and am considering switching to a different structured generation library (https://github.com/noamgat/lm-format-enforcer), however that one seems like it is much less mature and i do intend to use this for production usecases.
Anyway, if there is anything i can do to help please let me know.

@hugocool To have stable CFG-based JSON generation we need

Tooling like https://github.com/dottxt-ai/outlines/blob/main/outlines/fsm/json_schema.py which, instead of converting to regex, constructs an appropriate Lark grammar.

Completion of https://github.com/dottxt-ai/outlines/issues/1151

There may be other paths forward, but this is the approach immediately obvious to me.
This isn't an area of focus of mine at the moment, but if you're interested in tackling either issue, please let me know what questions you have!

Okay, i am willing to pick this up.
So i have some questions, what is the current state of the Lark grammer generation? Which elements of the PR (https://github.com/lapp0/outlines/pull/85) can i build upon? or any attempt for that matter?
Are you aware of lm-format-enforcer and their approach to solving this problem? What elements of their learnings should we incorporate?
I think i would start with generating a Lark grammer for my specific usecase, which is recursive JSON. Then if that works we can see how to generalize it so it can work for any arbitrary JSON schema.
I am assuming i should build of of these examples:

https://dottxt-ai.github.io/outlines/latest/reference/generation/cfg/
https://lark-parser.readthedocs.io/en/stable/json_tutorial.html
https://github.com/dottxt-ai/outlines?tab=readme-ov-file#using-context-free-grammars-to-guide-generation
https://github.com/dottxt-ai/outlines/blob/main/outlines/grammars/json.lark

Are there any more resources i should be aware off?
Lastly, i am assuming that the second issue you mentioned, would come into play once we would like to generalize the solution to JSON more broadly, right?

authors: brandonwillard hugocool lapp0 rlouf sahewat

repo: outlines-dev/outlines


text:
Clean the transformers and llamacpp interfaces

Closes #723

This is good to merge. Let's now adopt the same pattern in #593.


text:
Update sbt to 1.5.1

Updates org.scala-sbt:sbt from 1.5.0 to 1.5.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, semver-patch

Superseded by #15.

repo: outr/moduload


text:
问一下

现在还有人维护吗

项目还在线上运行，依然可用。但是不再维护，不再添加新功能。从提交记录可以看到，最近5年没有更新。

authors: SmileForU SubiRUN

repo: outstudio/easywechat


text:
cls.toggle is not very nice to use.

I feel like cls.toggle is in stark contrast to other class definitions in outwatch.
Take a look at the following code:
val disabled: Rx[Boolean] = ???

button(
  cls := "btn",
  cls.toggle("disabled") <-- disabled
)

It feels like this should be the other way round. cls.toggle(disabled) := "disabled".

Do you have a good idea for another name or should we just repurpose the method?

I am not sure if and how we could handle it cleanly.
We could just inverse the relation, but since we have both <-- and  := that isn't very nice.
Maybe we should really get rid of <-- first.
But constructs like cls.toggle(someRx) := someRxOfString can still exist which is kinda ugly.

Agreed to get rid of <--.
Another syntax could be:
(cls := "disabled").toggle(someBoolRx)

I do not feel that strongly about <-- and until now we did not manage to write proper overloads for the := function - so I would put this on hold for now.
We could use the same construct as with VModifier.ifTrue(...)(...). Thereby, we can make the second parameter list call-by-name and thereby lazy. This is useful if we are toggeling bigger VModifiers - that you do not want to construct when you do not render them.

I think we should make an effort to keep this feature concise. It is mostly a convenience feature anyways and should flow nicely with other class declarations.
If it weren't present at all one could also do the following:
div(
  someObservableBool.map(b => Option.when(!b)(cls := "disabled"))
)

On that note. We should align with the std library (Option here) and rename VModifier.ifTrue to when and ifNot to whenNot.

Good point about concise. How about we keep it similar and even name it when. Toggle is a bit ambiguous anyhow.
div(
cls.when(Boolean or Observable[Boolean]) := "disabled"
)

An alternative could be to add operators to colibri for observables. Something like this:
div(
  // could also be named ifElse/ifElseEmpty
  boolObservable.whenOr(cls :=  "disabled", VModifier.empty)
  // or even for monoid
  boolObservable.whenOrEmpty(cls := "disabled")
)

The toggle method is now deprecated without replacement :)
Please reopen if you think, we still need something else than asIf.

authors: busti cornerman fdietze

repo: outwatch/outwatch


text:
Request 01: HTTP black padlock / HTTPS green padlock

Hi, I'm using FF Beta 61.0b6.
At ShadowFoxCSS padlock is always blue. Please, I need a script for the padlock:
For HTTP => Black padlock (if possible, black bold)
For HTTPS => Green padlock (if possible, green bold)
Thanks in advance!

https://www.reddit.com/r/FirefoxCSS/comments/8kssmf/http_padlock_black_https_padlock_green/

Thanks @overdodactyl.
I read the Wiki link you posted (thank you!). Sorry I didn't read before. Now I understand how to customize padlock color. However, I still don't know how to have both colors, green for HTTPS, and black for HTTP.
It will be great if you can help me.
Thanks a lot!

@Overdodactyl ... P-E-R-F-E-C-T !!!!!!!! Everything works perfect! Thank you!
After your explanation, it was easy to change padlock color. Again, sorry I didn't read the Wiki before.
Black padlock in HTTP... also perfect!
https://old.reddit.com/r/FirefoxCSS/comments/8kssmf/http_padlock_black_https_padlock_green/

authors: EstherMoellman overdodactyl

repo: overdodactyl/ShadowFox


text:
Remove canary logic

In the case of a canary event, the orchestrator should call the profiles service as normal, but pass the canary=true URL param.

This PR was successfully deployed to production by CircleCI build 29 at 2016-12-19 14:53 GMT.

This PR was successfully deployed to production by CircleCI build 30 at 2016-12-19 17:48 GMT.

repo: ovotech/comms-orchestration


text:
Paymaster Templates

NFT-based paymaster access

some sort of rate limiting (gas use / month)
Look into Uniswap rate limiting?
User can spend x gas / month (paymaster bal)

/cib

add paymaster contract to the contracts folder and add tests

authors: corbanvilla vszammit

repo: owlprotocol/contracts


text:
ocis 1.0.0-beta6

Tasks

[x] Integrate TUS endpoint with ocis-proxy https://github.com/owncloud/product/issues/72

[x] update reva in ocis-reva: https://github.com/owncloud/ocis-reva/pull/261
[x] release ocis-proxy (with the reva TUS fix)
[x] release ocis-migration (with some fix for a compilation issue related to accounts API)
[x] release ocis-reva (with the reva changes for the TUS fix for proxy)

[x] public link upload/download

[x] update reva in ocis-reva: https://github.com/owncloud/ocis-reva/pull/261

[x] ocis-reva EOS change in storage drivers names
[x] ocis-reva release
[x] ocis-phoenix release https://github.com/owncloud/ocis-phoenix/releases/tag/v0.8.0
[x] Auto Create home folders
[x] Release phoenix
[x] Release ocis-phoenix
[x] update go.mod in ocis for ocis-proxy, ocis-migration and ocis-reva: https://github.com/owncloud/ocis/pull/334
[x] release ocis-beta6

Out of scope

Single file sharing it's in!
New ocis accounts features
Permission handling in shares
Public link password check not enforced for API access (only first access in UI): https://github.com/owncloud/ocis-reva/issues/312

Due to additional issues we'll need to release the following modules:

[ ] release ocis-proxy (with the reva TUS fix)
[ ] release ocis-migration (with some fix for a compilation issue related to accounts API)
[ ] release ocis-reva (with the reva changes for the TUS fix for proxy)
[ ] update go.mod in ocis for ocis-proxy, ocis-migration and ocis-reva

@HanaGemela @felixboehm JFYI

https://github.com/owncloud/ocis-reva/pull/261 was merged so ocis-proxy (TUS) and public link stuff is merged.
next up is fixing EOS config in ocis-reva

@micbar I've added "permission handling" in "out of scope" as I remembered that it's not implemented. See https://github.com/owncloud/ocis-reva/issues/292
in case it matters for communication

added to "out of scope": Public link password check not enforced for API access (only first access in UI)
it's not implemented yet.

the release is out: https://github.com/owncloud/ocis/releases/tag/v1.0.0-beta6

repo: owncloud/ocis


text:
[full-ci] POC Replacement for TokenInfo endpoint

Description

Related Issue

https://github.com/owncloud/ocis/issues/8858
Motivation and Context

How Has This Been Tested?

test environment:
test case 1:
test case 2:
...

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

I'm not 100% sure here, but after a quick research I think we can't get rid of the browser auth popup when sending a 401 response code and the WWW-Authenticate header. So we might need to find a slightly different solution. Things that come to my mind:

Changing the status code to e.g. 400 (semantically not correct though).
Remove the WWW-Authenticate header so clients need differentiate based on the returned error message. I guess that would be okay if we don't plan to translate it.

@JammingBen I removed the WWW-Authenticate Basic header
The popup authentication also made the webUITest faled
Please try without authentication popup

@JammingBen I removed the WWW-Authenticate Basic header The popup authentication also made the webUITest faled Please try without authentication popup

Yup that works 👍 I'm simply checking the error message now: https://github.com/owncloud/web/pull/10869/files#diff-90681f8aba50079e5c32cf69d1f1c61af3dbf496f0adfd5fa45936a5647eb767R144. If @micbar or @rhafer don't have any objections I'm fine with that.

@2403905 Now that the reva part is merged we can rebase and remove the reva replacement.

authors: 2403905 JammingBen rhafer


text:
CMake must be installed to build OSQP

It seems this package needs CMake during a pip install.
RuntimeError: CMake must be installed to build OSQP
If I do pip install cmake  it works after.
Can't cmake be added to the setup_requires field in setup.py?
This would make the installation process smoother for many libraries that depend on this one.
I'll make a PR if this can be done?

It is a good idea.   Please make a PR.

From: Krishnan R notifications@github.com
Sent: Thursday, May 31, 2018 10:47:21 AM
To: oxfordcontrol/osqp-python
Cc: Subscribed
Subject: [oxfordcontrol/osqp-python] CMake must be installed to build OSQP (#4)
It seems this package needs CMake during a pip install.
RuntimeError: CMake must be installed to build OSQP
If I do pip install cmake it works after.
Can't cmake be added to the setup_requires field in setup.py?
This would make the installation process smoother from many libraries that depend on this one.
I'll make a PR if this can be done?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/oxfordcontrol/osqp-python/issues/4, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGhaqTnntQ8VG4VrShmLh5IMn_IBWGcPks5t37wpgaJpZM4UUvo2.

Thanks! Added it in 4078327

I'm sorry this doesn't work as expected. The setup_requires option does not install the package in a full fledged way, it only downloads it temporarily into a local folder, making packages importable. It works for cases like numpy, where it can be imported from within a custom command in setup.py. But cmake is called in setup.py as a subprocess (also before the setup function), which requires it to be in the sys path. Perhaps cmake needs to be called as a python module.
I tried installing the master branch, but doesn't work.

The best option is to install cmake separately independently from the language. That's what we suggest in the instructions.
The fact that OSQP is not directly installed using a binary is probably because you are using pip and linux (see #3). Note that cmake is also needed for code generation.

Yes you are right. I guess then CMake is best installed separately.

I have reverted the commit in 8336546. I will close the issue since it looks like it will not appear again when we release the manylinux binaries.

Hi. I was installing scikit-survival, which has OSQP as one of its requirements (?), and it kept throwing some errors. I stumbled across this thread and did python3 -m pip install --user cmake and afterwards python3 -m pip install --user scikit-survival finally worked.
I'm on a 2016 MacBook Pro macOS 11.0.1 with python 3.8. I don't know if this will inform your development any.

authors: ChemGuy88 bstellato goulart-paul krishnan-r

repo: oxfordcontrol/osqp-python


text:
Update CMakeLists.txt to use correct library directory under linux.

I found a some files that went into /usr/lib when building on 64-bit architectures
I think that if I build for 64-bit, it should go to /usr/lib64 with this changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage remained the same at 91.249% when pulling 1356232eec9961a41a7662ecea0a9ecc5c71cf41 on kevinsmia1939:patch-1 into da403d4b41e86b7dc00237047ea4f00354d902ed on oxfordcontrol:master.

@kevinsmia1939 sorry for the delay in merging this.

repo: oxfordcontrol/osqp


text:
Add timeout for /is_synced endpoint in sidecar.py

In out prod environment we could observe that requests piling up as there is no timeout in default requests get method. Here we timeout and close the connection timely to avoid the piling up.
This is an alternative way to fix the issue mentioned here https://github.com/oxheadalpha/tezos-k8s/pull/562

please see my latest comment
I have  updated the comment with right probe filed name, please have a review


text:
CLI: Generate on build autocomplete and man

Autocompletion for various shells are generated on build in the target/{debug,release}/build/oxigraph-cli-<hash>/out/complete directory.
Similarly, man pages are generated in the target/{debug,release}/build/oxigraph-cli-<hash>/out/man directory.

CC @jonassmedegaard Would it be easy to integrate these generated autocompletions and man in the debian package?

Wonderful!
Yes, that should be easy to integrate with the Debian package (haven't tested yet, only skimmed the source code). Thanks for asking!
By the way, please consider shaping at least the initial paragraph as imperative (I think, see below) not passive, and omit final full stop.
Example: "Creates database backup into a target directory." -> "Create database backup into a target directory"
I am not really sure if the correct term is "imperative" - what I mean is to do similar to man find and man git-commit.
Please do tell if better to create a separate issue for that...

@jonassmedegaard Thank you! Done in 0d0cc23a1932fbe41a64b1446cfe9182b95d5529

authors: Tpt jonassmedegaard

repo: oxigraph/oxigraph


text:
Highlight c compound_statement

Makes it so that braces indicating scoping in c also get highlighted.
before:

after:

Thanks!


text:
[PSA] counter size S

For counters that have a number of counters that is an exact power of
2, e.g. 1024, a single type S that is bit<10> is just right for the
'index' parameter to 'count', but it is 1 bit too small for the
'n_counters' parameter of the constructor.  Might be good to have a
separate type for the 'n_counters' paremeter?

Latest PSA draft as of today has changes that address this comment, by always using bit<32> type for n_counters.

authors: hanw jafingerhut


text:
Question: In P4_14, why are header_ref.valid and header_ref both keys?

There seem to be two ways to check the validity of a header in a table:
header some_type_t h;

table t1 {
  reads { h.valid : exact; }
  ...
}

table t2 {
  reads { h : valid; }
  ...
}

The former is undocumented and only appears in the BNF rule for table reads (Section 11), from what I can tell.  Assuming the intention is to provide access to the validity bit associated with the header, then h.valid : exact is equivalent to h : valid, but also supports more functionality, eg. h.valid : ternary.
Why do both exist?  Can we remove the valid match type in favor of the valid pseudo-field?  If not, perhaps the documentation in Section 11 (and/or 2.2.1?) can be updated to explain the two different ways to check validity.

EDIT: Change examples to use P4_14 syntax (reads) rather than P4_16 syntax (keys).

Historically, for a long time only the second one existed.
This is what P4-16 did: remove the second one and only use the first one.
The second one must exist for backwards compatibility.

@cole-barefoot your question seems to mix P4_14 and P4_16.
In the context of P4_14, As @mbudiu-vmw indicated, the .valid pseudo-header was only added in the past year (version 1.04 IIRC?). It seemed dangerous to remove the valid match kind since that might break existing programs.
The standard library for P4_16 (as defined in core.p4) doesn't have a valid match_kind.

No, this is for the P4_14 spec.  Sorry, I should have specified that in the issue title, which I've now edited.
Reading through the P4_14 spec, Section 11 (Table Declarations) shows a grammar fragment that accepts both h.valid : exact and h : valid.
The change log in that document shows that the .valid pseudo-field was added in v1.0.4 (see Section 15.3.1).
I don't see any other mention of the .valid pseudo-field in the P4_14 spec.

Minor: the keys syntax is P4_16. In P4_14, it's reads.

Indeed, we should have added at least 1-2 sentences of explanation for the .valid pseudo-field.

authors: cole-barefoot jnfoster mbudiu-vmw


text:
Invalid coding

Certificate for SSL can not be applied as all the reference links are coded with http and no coding for https - any workarounds available ?

If you installed pH7Builder (pH7CMS) with http, then moved to HTTPS, you will have to clear the caches in order to regenerate the URLs and get them with HTTPS. Go to your Admin Panel, -> Tool -> Caches -> Caches Manager.
FYI, the software automatically checks the protocol (http/https).
This is done is your _constants.php file (around line 23) located in the root folder after the installation of the software has been done.
Let me know if this helps.
Have a great weekend anyway :tada:

Finally, do you mind to Star the repo @marketing720?

	Thank you sir - how do you get the phone app to work or do you have any documentation or a paid service I can use to finish it up?

	Get Outlook for iOS

On Sat, Feb 16, 2019 at 4:25 PM -0800, "♚ PH⑦ de Soria™♛" notifications@github.com wrote:
Assigned #442 to @marketing720.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi @marketing720
Can you please create a new "Issue" if the problem is different. This helps to keep each thread tiny and avoiding confusions in there. Finally, do you mind to Star the repo?

@marketing720   Finally, do you mind to Star the repo?

I will close this one by now @marketing720. Please let me know if there is any more issues with https (if it's still the case...).
Thanks. Enjoy your day 🎉


text:
(ดู~หนัง) เวน่อม มหาศึกอสูรอหังการ เต็มเรื่องฟรี - พากย์ ไทย

(ดู~หนัง) เวน่อม มหาศึกอสูรอหังการ (Venom The Last Dance 2024) เต็มเรื่องฟรี พากย์ เวน่อม มหาศึกอสูรอหังการ - Venom The Last Dance ดู เวน่อม มหาศึกอสูรอหังการ Netflix เต็มเรื่อง - หนัง ดูออนไลน์ฟรี 123 เรื่องเต็ม พากย์
ดูที่นี่ :: เวน่อม มหาศึกอสูรอหังการ เต็มเรื่อง 2024 พากย์
ดูที่นี่ :: เวน่อม มหาศึกอสูรอหังการ เต็มเรื่อง 2024 พากย์
เวน่อม มหาศึกอสูรอหังการ - Venom The Last Dance ดู เวน่อม มหาศึกอสูรอหังการ Netflix เต็มเรื่อง - หนัง ดูออนไลน์ฟรี 123 เรื่องเต็ม พากย์ กลับมาอีกครั้งกับภาพยนตร์วัยรุ่นที่ทุกคนรอคอยในภาคต่อสุดมันส์อย่าง เวน่อม มหาศึกอสูรอหังการ (Venom The Last Dance 2024) ที่นำเสนอบทเรียนชีวิตและมิตรภาพในแบบของเด็กนักเรียนชาย ที่มีทั้งความดุดัน ความตลก และความซาบซึ้งในเวลาเดียวกัน ภาคนี้เป็นการเล่าเรื่องต่อจากภาคแรกที่เคยสร้างปรากฏการณ์ความสนุกให้กับผู้ชมทั่วประเทศ ซึ่งแน่นอนว่าเต็มไปด้วยความเข้มข้นและการเผชิญหน้ากับปัญหาชีวิตที่สมจริงยิ่งขึ้น
เวน่อม มหาศึกอสูรอหังการ - Venom The Last Dance ดู เวน่อม มหาศึกอสูรอหังการ Netflix เต็มเรื่อง - หนัง ดูออนไลน์ฟรี 123 เรื่องเต็ม พากย์ ใน Venom The Last Dance เรื่องราวยังคงโฟกัสไปที่กลุ่มเพื่อนนักเรียนกลุ่มหนึ่งที่มีความผูกพันกันอย่างแน่นแฟ้น แต่ต้องเผชิญกับความท้าทายที่เข้ามาในชีวิตอย่างต่อเนื่อง หลังจากเหตุการณ์ในภาคแรก ความสงบสุขที่พวกเขาพยายามจะรักษาไว้ได้กลับถูกทดสอบอีกครั้ง เมื่อกลุ่มนักเลงจากโรงเรียนคู่แข่งได้พยายามเข้ามาท้าทายความเป็นหนึ่ง และทำให้มิตรภาพของพวกเขาต้องเผชิญกับการทดสอบครั้งใหม่ ตัวละครหลักอย่าง เป้ง ที่นำแสดงโดยนักแสดงรุ่นใหม่ไฟแรง ยังคงต้องรับบทเป็นผู้นำกลุ่มที่ต้องแบกรับความรับผิดชอบในการปกป้องเพื่อน ๆ ของเขา พร้อมกับการค้นหาความหมายที่แท้จริงของการเป็น "นักเลงขาสั้น" ที่ไม่ใช่เพียงแค่การใช้กำลัง แต่ยังรวมถึงการตัดสินใจที่ยากลำบาก และการทำในสิ่งที่ถูกต้องเพื่อคนรอบข้าง
เวน่อม มหาศึกอสูรอหังการ - Venom The Last Dance ดู เวน่อม มหาศึกอสูรอหังการ Netflix เต็มเรื่อง - หนัง ดูออนไลน์ฟรี 123 เรื่องเต็ม พากย์ ภาพยนตร์ เวน่อม มหาศึกอสูรอหังการ ได้รับการพัฒนาทั้งในด้านบทภาพยนตร์และการกำกับ ทำให้สามารถผสมผสานระหว่างฉากแอ็คชันที่ดุเดือด และฉากดราม่าที่เข้าถึงหัวใจของผู้ชมได้อย่างลงตัว ฉากการต่อสู้ที่มีสไตล์เฉพาะตัว และการใช้มุมกล้องที่สร้างสรรค์ ทำให้การเล่าเรื่องมีความน่าตื่นเต้นและติดตามได้อย่างต่อเนื่อง นอกจากนี้ เนื้อหายังสอดแทรกแง่คิดเกี่ยวกับการเป็นวัยรุ่นและการเติบโต ที่สามารถเชื่อมโยงกับผู้ชมได้ทุกเพศทุกวัย
เวน่อม มหาศึกอสูรอหังการ - Venom The Last Dance ดู เวน่อม มหาศึกอสูรอหังการ Netflix เต็มเรื่อง - หนัง ดูออนไลน์ฟรี 123 เรื่องเต็ม พากย์ ทีมงานและนักแสดงจากภาคแรกได้กลับมารวมตัวกันอีกครั้งในภาคนี้ นำโดยนักแสดงรุ่นใหม่ที่ได้รับการชื่นชมในบทบาทการแสดงที่เป็นธรรมชาติและเต็มไปด้วยชีวิตชีวา การกลับมาของพวกเขาทำให้ผู้ชมได้เห็นถึงเคมีที่เข้ากันอย่างดีระหว่างตัวละคร ทำให้เรื่องราวมีความสมจริงและน่าสนใจมากยิ่งขึ้น นอกจากนี้ ภาคนี้ยังได้มีการเพิ่มนักแสดงใหม่ ๆ ที่มาสร้างสีสันให้กับเนื้อเรื่องและเพิ่มความหลากหลายให้กับตัวละคร
เวน่อม มหาศึกอสูรอหังการ - Venom The Last Dance ดู เวน่อม มหาศึกอสูรอหังการ Netflix เต็มเรื่อง - หนัง ดูออนไลน์ฟรี 123 เรื่องเต็ม พากย์ สำหรับผู้ชมที่ต้องการรับชม Venom The Last Dance แบบพากย์ สามารถสัมผัสกับประสบการณ์การรับชมสุดพิเศษที่มาพร้อมกับเสียงพากย์ที่มีคุณภาพ ทำให้สามารถเข้าถึงอารมณ์ของตัวละครได้ดียิ่งขึ้น ไม่ว่าจะเป็นความดุดันของฉากต่อสู้ หรือความอบอุ่นในฉากดราม่า ทั้งหมดถูกถ่ายทอดผ่านเสียงพากย์ที่สมบูรณ์แบบ เพื่อให้ผู้ชมได้รับความสนุกสนานอย่างเต็มที่ ภาพยนตร์เรื่องนี้สามารถรับชมแบบเต็มเรื่องได้ฟรีผ่านทางแพลตฟอร์มสตรีมมิ่งต่าง ๆ ที่เปิดให้บริการในรูปแบบออนไลน์ ผู้ชมสามารถเลือกค้นหาภาพยนตร์บนเว็บไซต์หรือแอปพลิเคชันที่ให้บริการสตรีมมิ่งเพื่อเข้าถึงภาพยนตร์ได้อย่างสะดวกสบาย ไม่ว่าจะรับชมผ่านโทรศัพท์มือถือหรืออุปกรณ์อื่น ๆ
เวน่อม มหาศึกอสูรอหังการ - Venom The Last Dance ดู เวน่อม มหาศึกอสูรอหังการ Netflix เต็มเรื่อง - หนัง ดูออนไลน์ฟรี 123 เรื่องเต็ม พากย์ เวน่อม มหาศึกอสูรอหังการ ไม่เพียงแต่เป็นภาพยนตร์ที่เน้นการต่อสู้และแอ็คชันเท่านั้น แต่ยังแฝงไปด้วยเรื่องราวของมิตรภาพและการเติบโตของกลุ่มเพื่อนที่ต้องเผชิญหน้ากับปัญหาต่าง ๆ ที่เป็นบทเรียนสำคัญในชีวิตของวัยรุ่น ภาพยนตร์นี้สามารถสร้างความสนุกและความตื่นเต้นให้กับผู้ชมได้อย่างแน่นอน อีกทั้งยังเป็นภาพยนตร์ที่สามารถเชื่อมโยงกับผู้ชมทุกคนที่เคยผ่านช่วงเวลาของวัยเรียนและการเรียนรู้ในการเผชิญหน้ากับโลกที่ซับซ้อนยิ่งขึ้น อย่าพลาดชม เวน่อม มหาศึกอสูรอหังการ เต็มเรื่องพากย์ เพื่อสัมผัสกับการผจญภัยสุดมันส์และเรื่องราวที่ตรึงใจ พร้อมกับความหมายที่ลึกซึ้งของคำว่า "มิตรภาพ" และ "การเป็นนักเลงขาสั้น" ที่แท้จริง!


text:
Theming

Use chakra ui theme

How should this be manually tested?

Step 1 : clone and run
Step 2 : check if theme is present

Other changes
Boyscout

LGTM

repo: paastech-cloud/website


text:
Expose HttpServletRequest's request url for web context

Avoids casting down to JEEContext.

OK. I understand.
There is a problem though: this is a breaking change and this cannot be done for a minor version.
Hopefully, we can workaround that problem: can you propose a default implementation of getRequestURL in the WebContext interface which just removes the query string from the getFullRequestURL method if it exist (like you do in MockWebContext)?
Thanks

Sure. Will do.

This is done.
PS I will also be posting a new PR shortly to support SAML2 Scoping in authentication requests.

Two last points:

with the default implementation of getRequestURL in the WebContext, do you still need an implementation in JEEContext?
can you drop a line in the release notes?

I updated the release notes.
I think it's safest for the JEEContext to override the default implementation, since it delegates to the real request, and real implementations might want to handle this scenario differently. I wouldn't want to interfere with that.

OK. Thanks

authors: leleuj mmoayyed


text:
Fix btrfs-tool version check

Tweak Docker version check regex and reuse that.
I have signed the CLA.

Oh, I see #69 is pretty extensive and covers this.  Your choice as to which to take.

Since this one's ready to go now I'm going to merge it in.
Many thanks! If you drop me a line at jd@pachyderm.io with your tshirt size I'll get you some swag.

Hey, mines ready too! :) haha
On Wednesday, June 24, 2015, Joe Doliner notifications@github.com wrote:

Merged #93 https://github.com/pachyderm/pfs/pull/93.
—
Reply to this email directly or view it on GitHub
https://github.com/pachyderm/pfs/pull/93#event-338366935.

Oh, didn't realize that :p. I'll get that merged in as well.

authors: bitwiseman jdoliner peter-edge

repo: pachyderm/pfs


text:
variance in weight-at-age -- how to model and project

See https://github.com/seastateinc/PollockGrowth and https://github.com/jimianelli/fishBodyMassAtAge for ideas for 2022 assessment.

2022 Assessment
SRG Request # 13

Uncertainty in weight-at-age is not accounted for in the stock assessment and a five-year average of recent observations is used for all years of the projections. The SRG requests that the JTC explore alternative methods for forecasting weight-at-age and evaluate whether they can improve projections.

Moving to next year's assessment, re-open in 2023.
2023 Assessment

repo: pacific-hake/hake-assessment


text:
Identical implementation for collaborators (Github Project)

In GithubProject class there is identical implementation for who_can_close_issue and who_can_merge_pr, is it intentional? Or can we factor it out since it's identical?

Yes, we can extract that logic to some helper private function.

authors: lachmanfrantisek mfocko

repo: packit-service/ogr


text:
Provide a /packit help comment command

I've seen an occurrence of /packit help comment command and found it interesting -- can't we provide a nice help message?
Implementation:

Create a new handler for /packit help command.
React in form of a comment and provide:

A list of relevant/all commands Packit supports.
Relevant links to the documentation.
Contact / or a link to contact.

Still relevant.

authors: lachmanfrantisek nforro

repo: packit/packit-service


text:
fix(tf): add the ‹canceled› state

Fixes #2339

what about reporting this? Should we report is as neutral state?

authors: lbarcziova mfocko


text:
Fix CursorRow::get_text

Update fetch_size for the Indicator::NoTotal case in CursorRow::get_text.

Pull Request Test Coverage Report for Build cf865b0fbeeb172bc20d4d2c3f4f8ae0334294e5-PR-290

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 83.42%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

odbc-api/src/cursor.rs
0
1
0.0%

Totals

Change from base Build 69b0c007b8df7c1b01b77be780c721939f2aaf76:
-0.02%

Covered Lines:
4166

Relevant Lines:
4994

💛  - Coveralls

Hi @blankname ,
thanks for the Bugfix. Any hint how to reproduce this? What DB did it occur for you, in which value type. I prefer to have a reproducing test before merging a Bugfix. From what I can see though, the code really has a Bug and you did fix it, so thanks.
Best, Markus

Hi @pacman82,
I encountered the bug when running the following against db2 for ibm i (using unixodbc):
match conn.execute("values QSYS2.JOB_NAME", ()) {
  Ok(Some(mut cursor)) => {
    if let Ok(Some(mut row)) = cursor.next_row() {
      let mut buf = Vec::new();
      row.get_text(1, &mut buf);
    }
  },
    _ => panic!(),
}

QSYS2.JOB_NAME is a built-in global variable (varchar(28)).
I also tried selecting a column (varchar(128)) view and that didn't trigger the bug.
It's possible? that the column and the global variable have different character encodings.
I wonder if it would be possible to reproduce this with a database that's used in the test suite by selecting a large object column (ex. Blob).
I can probably take a look next weekend.

I wonder if it would be possible to reproduce this with a database that's used in the test suite by selecting a large object column (ex. Blob).

Explored that option here: https://github.com/pacman82/odbc-api/blob/400282bba8d575bffac2f748f855c0c7458c29fb/odbc-api/tests/integration.rs#L2263
Next I'll try fetching a fixed size column with a buffer too small.

Since the obvious attempts to reproduce fail, I'll merge this as is. If you have some insight for me how much effort it would be to add db2 to my test suite please tell me. Is there a docker image I could directly use in CI?

On second thought, I think the logic for fetch_size must be different.
let old_len = buf.len();
// Use an exponential strategy for increasing buffer size.
buf.resize(old_len * 2, 0);
let buf_extend = &mut buf[(old_len - 1)..];
fetch_size = buf_extend.len();
target = VarCharSliceMut::from_buffer(buf_extend, Indicator::Null);
self.get_data(col_or_param_num, &mut target)?;

releasing odbc-api 0.50.3. Contains a fix. Hopefully 😓

@blankname Please let me know if the issue is resolved for you, and if you have any tipps how to reproduce.
Cheers, Markus

@pacman82
There's a db2 for Unix, Linux, Windows, but I believe it requires a license.
I did some source searching of ODBC drivers for databases that are already used in this repo's tests to try to find cases where they will return SQL_NO_TOTAL.
Postgres:
https://github.com/iress/psqlodbc/blob/4bfff48941cc81f7a1b26fc7cae253fdfb30f040/pgtypes.c#L972
MariaDB:
https://github.com/mariadb-corporation/mariadb-connector-odbc/search?q=SQL_NO_TOTAL
I plan on trying to reproduce the issue this weekend.

On second thought, I think the logic for fetch_size must be different.

The new logic you implemented is a cleaner solution.
To make sure I understand what was wrong if there was a bug in my original fix: Will buf_extend.len() ever be different from old_len + 1 since the buffer is being doubled (and we're overwriting the existing null at the end of the buffer)?

To make sure I understand what was wrong if there was a bug in my original fix

Nope, do not think you had a Bug. Just was to tired to see that it is the same thing. 😓  One thing I did though is to apply the same fix to the binary get_data as well.

I plan on trying to reproduce the issue this weekend.

If you can come up with a way to cover this code via integration testing, I would be thankful. I still have not figured out how to make the coverage information publicly available (not the percentage, but what lines of code precisly). If you can tell me, I'd be happy to do set the necessary permissions. That might be helpful if working on a branch.
Of course a good old printf debugging might also do the trick.
Again much thank you very much for reporting and analyising the issue and sorry you had to experience a Bug!
Best, Markus

Tested with Postgres BYTEA, but did not cover NO_TOTAL: https://github.com/pacman82/odbc-api/blob/d267163aa113e58d2668cb56fbdf0f411c4cf4e9/odbc-api/tests/integration.rs#L2256

I wasn't able to figure out a way to get either MariaDB or PostgreSQL to return SQL_NO_TOTAL.
I tried building both drivers with debug info and stepping through using GDB, but SQLGetData seems like it doesn't get the length using any of the functions I was seeing return SQL_NO_TOTAL.
Thanks for the library and your commitment to maintaining good code coverage!

Yeah, I could of course restructure the code to have a lower level unit test, but so far the intergration tests have been very good at defeating my bias of what I thought the drivers would do. Thanks for opening a Bug report and providing a fix.
FYI: If you do not need to stream really large individual field values, you get much better performance (often two orders of magnitude) if you bind buffers to the cursor instead of using get_data.
Best, Markus

authors: blankname coveralls pacman82


text:
make yarn lint pass

Yarn lint currently fails locally (and presumably in CI)

fixed by #113

repo: paddymul/buckaroo


text:
[Bug] Large Image - Broken

Bug description

Image that represents Large Image is not rendering on theme preview page

Expected outcome

Example of large image

Steps to reproduce

Visit theme preview

Technical info
What device were you using when you encountered the bug?

Laptop

What operating system were you using? What version is the operating system?

Macbook Air, 2020

What web browser were you using? What version is the web browser?

Chrome 98.0.4758.80 (Official Build) (x86_64)

Assistive technology and version (optional)

no

Additional information

code points to URL: https://guides.github.com/activities/hello-world/branching.png
this url redirects to "https://docs.github.com/en"

Image - Screenshot

This broke in all themes after Docs migration from Help. There's a PR e. g. here https://github.com/pages-themes/hacker/pull/94 but this would need updating in all the themes.

authors: janbrasna sarah-peacock

repo: pages-themes/minimal


text:
BREAKING: Drop support for Node.js 14-15,17,19

While the package itself still runs on node 14, release-it bump from 15 to 16 introduced devDependencies with minimum Node.js version 16.
Node.js 14 is EoL as of 2023-04-30.

Support for Node < 18 was dropped already. Thank you anyway.

authors: fdc-viktor-luft legobeat

repo: pahen/madge


text:
Windows path not supported as srting values

I have simple toml file like that:
IntegrationBaseDirectory = "c:\tmp\INT"

But Nett fails to parse it and fails with exception:
Exception: Line 1, Column 28: String 'c:\tmp\INT' contains the invalid escape sequence '\:'.

This is definitely a bug, since even toml repository says that Windows path should be supported.

Ok, maybe not a bug... specification says about literal strings and that in this case single quotes should be used...

repo: paiden/Nett


text:
SBoM of Docker image contains test dependencies

Hi,
We opened this issue in the context of the Spring Boot project, but according to the developers, the issue lies in the executable-jar framework,
Expected Behavior
The SBoM should not contain test dependencies from the Maven pom file in general.
Current Behavior
When creating the Docker image for a Maven project, the resulting SBoM files contain entries for the test dependencies.
Motivations
This is an issue as vulnerability scanners use these meta files to check the image for security violations. In our case this leads to various false positives that have to be checked manually.
Thank you and best regards
Nils

The Java buildpacks are not making any decisions about which JAR files from your application to include or not include in the resulting image. When you run a build, you either a.) pass in a pre-compiled JAR file or b.) the buildpack runs maven/gradle/etc... and which builds a JAR file. In either case, the buildpacks operate on that JAR file and whatever is in that JAR file ends up in your image. Thus the first, and most likely place from which unwanted JARs would come is your application's build system (i.e. gradle/maven/etc..). You can test this easily by running a build locally and looking at the contents of the JAR for the offending files.
Some buildpacks will add tools, like the Spring Boot buildpack which can add in the Spring Cloud Bindings JAR file, or an APM buildpack that installs a JAR file Agent to run the APM tools. I cannot think of any that would install testing tools off the top of my head, but if you told me specifically what JARs you're seeing I could confirm.
Also, can you tell me how you are procuring the SBOM file? There are two sets of SBOM files generated by buildpacks. The first is from build-time. It scans the application source code and it will include tools like Maven because they are present at build-time. The second is from run-time. This is a picture of what ends up in the often much smaller run-time container. If you're using the build-time SBOM then I know for a fact you'll see the build tool, but I suppose you might see other build-time only things like testing libraries as well.

authors: dmikusa nils-christian

repo: paketo-buildpacks/executable-jar


text:
Watchexec missing to enable BP_LIVE_RELOAD_ENABLED=true

Describe the Enhancement

To enable BP_LIVE_RELOAD_ENABLED on php buildpacks
https://github.com/paketo-buildpacks/php-start/blob/main/integration/httpd_reload_test.go#L98
It requires watchexec to be in default, which is not included at the moment.
https://github.com/paketo-buildpacks/php-start/blob/main/integration/httpd_reload_test.go#L133
Possible Solution

N/A
Motivation

Want to allow live reload for PHP

@mhoshi-vm thanks for the issue - you're totally right I have no idea how we missed adding the buildpack to the PHP language family buildpack. I'll open a PR for that.

authors: mhoshi-vm sophiewigmore

repo: paketo-buildpacks/php


text:
--experimentalDecorators not recognized

I still get the following error:
Experimental support for decorators is a feature that is subject to change in a future release. Specify '--experimentalDecorators' to remove this warning.
I enabled the checkbox Enable experimental support for ES7 decorators and an according entry is present in the preferences file: compiler.experimentalDecorators=true.
Installed plugin info:
  TypeScript	1.5.0.v20150620-1653	com.palantir.typescript.feature.feature.group	Palantir Technologies, Inc.

Applying the following changes fixed the problem for some reason. Don't exactly know why:

May have been caused by delayed updates of eclipse, since not much time has passed between recognizing these errors and changing the config file.

Weird, it looks properly hooked up to me. Gonna close this for now. Please lemme know if you hit any additional issues.

Occasionally this error still pops up in the editor and is removed automatically shortly after (around 5 seconds). The tree in the package explorer gets no error decorators anyway.

I wonder if the setting only propagated to some of the language services. Can you try rebooting Eclipse and see if it still occurs?

authors: Waog derekcicerone

repo: palantir/eclipse-typescript


text:
Make palera1n.sh not directory dependant

Sometimes we can't run palera1n.sh in the directory itself. However this will cause issues. So, I have made palera1n.sh not directory dependent

The last commit uses pushd and popd to cd in and out in a lifo structure

Has this been tested

yes


text:
Fix remote debugging for web API functional tests

The problem is that when you run web API functional tests with debugger, it tries to connect to PHPStorm on the host originating the call (guest machine), and obviously fails. Change of remote connect back to static IP in XDebug configuration should help, but need to make sure that it will always work in other cases.
Temporary workaround if you need to run debugging for web API functional tests is:

On the guest (if using PHP 7): vim /etc/php/7.0/cli/conf.d/20-xdebug.ini
Change xdebug.remote_connect_back=1 to xdebug.remote_host=192.168.10.1 (or whatever is your host IP)

Fixed in scope of #54


text:
fix: missing newline before require

What is the purpose of this pull request?
Fixes missing newline before require in application.rb when running the install template.
application.rb before fix:
# you've limited to :test, :development, or :production.require "view_component/engine"

Bundler.require(*Rails.groups)

After fix:
# you've limited to :test, :development, or :production.
require "view_component/engine"

Bundler.require(*Rails.groups)

Thanks!

authors: budu palkan


text:
Invoking group with subcommand

Hi,
I've searched whole documentation and code and I cannot find answer.
Is it possible to invoke group with subcommand from other command?
Something like:
ctx.invoke(group, grop_arg1=value, subcommand=subcommand, subcommand_arg1=value)

Please use StackOverflow for this.

authors: Nihn untitaker

repo: pallets/click


text:
ZSH completions escape

Completion in ZSH usually escapes spaces and other special characters in file names etc. I think this is the expected behavior.
As I see -Q has been introduced in https://github.com/stopthatcow/click/commit/13b84c5c4982f35988b812484cf9b76c8eba4ae6 which fixed sorting. However this options seems unnecessary and unrelated to sort order.
Also, I haven't found a straightforward way to test this. In case this breaks something else I'd figure out a way to override the default completion function.

I'm unclear why you want to remove it. I had a hard time finding documentation on the -Q option to _describe, but it looks like that's what quotes values, which you said was expected.

authors: davidism timka


text:
Disable OS-level autocorrect in the interactive debugger

If you’re using the interactive debugger in the web browser, and autocorrect is feeling aggressive, it can kick in and try to “fix” the Python commands you’re typing. This is annoying for the end-user, and rarely helpful as autocorrect doesn’t know about Python. More than once this has bitten me, causing me to write invalid Python, or for variable names to change case mid-command.
I don’t have time to create a patch now, but I think the fix is just adding the following attribute to the <input> tag where you type commands:
autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false"

This probably isn’t really Flask’s fault – the OS is what actually makes the unhelpful autocorrections – but it seems like something Flask should be able to fix.
I spotted this on the developer builds of OS X Sierra, where autocorrect seems noticeably keener (especially in <input> fields) than older versions.

Python 3.5.0
Flask 0.11.1
Werkzeug 0.11.10

Good idea, spell checking etc makes zero sense for fields where you enter code

Fixing the debugger seems to be a single-line change: https://github.com/alexwlchan/werkzeug/commit/7a427e914a7075f0e50b207995b183b0d0ac72eb
I’m going to run with this fix locally for a few days and see if I spot any untoward behaviour; if not, I’ll open a pull request against the Werkzeug repo.
(I only did the interactive Python prompt in the debugger, because that’s the only place I can think of where you enter code. Is there anywhere in the debugger I should sort out at the same time?)

Thanks, could you file a pull request?

authors: ThiefMaster alexwlchan untitaker

repo: pallets/flask


text:
path converter doesn't redirect to trailing slash

It seems to me that the automatic redirect for URLs with trailing shlashes (like /user → /user/) described in Flask docs and Werkzeug docs does not work if you use PathConverter in an URL definition.
I have this straightforward Flask application to reproduce the problem:
from flask import Flask, Response

app = Flask(__name__)

@app.route('/')
@app.route('/<path:username>/')
def main(username=None):
    return Response(f"It works! Hello, {username}")

In werkzeug 2.1.2, it works as expected and if you send a request to /user, it redirects you via HTTP/308 to /user/. The log is:
* Running on http://127.0.0.1:5000 (Press CTRL+C to quit)
127.0.0.1 - - [12/Oct/2022 14:47:37] "GET / HTTP/1.1" 200 -
127.0.0.1 - - [12/Oct/2022 14:47:45] "GET /user HTTP/1.1" 308 -
127.0.0.1 - - [12/Oct/2022 14:47:45] "GET /user/ HTTP/1.1" 200 -

But when I use werkzeug 2.2.0, the same request gives me HTTP/404:
 * Running on http://127.0.0.1:5000 (Press CTRL+C to quit)
127.0.0.1 - - [12/Oct/2022 14:48:43] "GET /fooo HTTP/1.1" 404 -

I've tried a bisection of all the commits between those versions to see whether this was an intentional change or not and find that the difference has been introduced in: https://github.com/pallets/werkzeug/commit/5a7c0dec029d296a5e8131c8db51ce19e28c0c58
The workaround for this is to define both possible URLs for a single endpoint but it's not pretty. Also, the difference might cause problems if you still support Python 3.6 because pip installs older Flask and werkzeug for Python 3.6 where the redirect works fine and newer packages for Python 3.7+ where it does not.
Is this behavior intentional and if so, could you please add it to the documentation?

Thanks for the quick response but even with the latest version 2.2.2 together with Flask 2.2.2, the problem is still the same. Could you please reopen this issue?

Is it possible that the mentioned fix fixes only the RegexConverter but not the PathConverter where slashes are also allowed?

@pgjones looks like the path converter swallows the trailing slash before matching finishes?

I think is is that the match isn't possible without a trailing slash (it isn't considered optional for a final part). I'll look into this.

authors: davidism frenzymadness pgjones

repo: pallets/werkzeug


text:
WIP Convert the compass evm contract to solana-rs

https://github.com/palomachain/paloma/issues/350
Background
We'd like a rust version of the Solana compass contract. This is a start.
Testing completed

[ ] N/A, pr is WIP

Going to give this a second shot, probably in anchor.

repo: palomachain/paloma-rs


text:
can not use raw in join statement

input:
select(
'BOOK_ID', 'WRITER.NAME', 'BOOK.STOCK'
).from('BOOK ')
.join(
sqb.raw('inner join WRITER on BOOK.BOOK_ID = WRITER.WRITER_ID')
)
output:
TypeError: Invalid argument in method "join"

join method does not accept Raw objects. We can add this functionality in next releases.

authors: ecemerimguner erayhanoglu

repo: panates/sqb


text:
Series.groupby(by: Series) should not return SeriesGroupBy[S1, tuple]

Describe the bug
When using a Series in a groupby, the byT type is supposed to be tuple because Series is included in the TypeVar GroupByObjectNonScalar, but since there is only one Series, it should not be a tuple, but rather the type of the Series we use in the groupby.
See how the GroupByObjectNonScalar is declared here : https://github.com/pandas-dev/pandas-stubs/blob/70c412c84ec70fabdeb6b774b06811758b1b4b2b/pandas-stubs/_typing.pyi#L435 (note how it includes both Series and list[Series], same goes with Function or Grouper probably.
See how the resulting groupby is decided to be SeriesGroupBy[S1, tuple] here when by is either a MultiIndex or a GroupByObjectNonScalar : https://github.com/pandas-dev/pandas-stubs/blob/70c412c84ec70fabdeb6b774b06811758b1b4b2b/pandas-stubs/core/series.pyi#L627
It seems to me that the GroupByObjectNonScalar is a bit too broad and includes both objects representing only one grouper and multiple groupers (where the SeriesGroupBy[S1, tuple] is consistent). So maybe we should divide this TypeVar in two and change the groupby overloads so that when only one grouper is present, the type is Any ?
_typing.pyi
MultiGroupByObjectNonScalar: TypeAlias = (
    tuple
    | list[_HashableTa]
    | list[Function]
    | list[Series]
    | np.ndarray
    | list[np.ndarray]
    | list[Mapping[Label, Any]]
    | list[Index]
    | list[Grouper]
)
MonoGroupByObjectNonScalar: TypeAlias = (
    Function
    | Series
    | Mapping[Label, Any]
    | Grouper
)

core/series.pyi
    @overload
    def groupby(
        self,
        by: MultiIndex | MultiGroupByObjectNonScalar = ...,
        axis: AxisIndex = ...,
        level: Level | None = ...,
        as_index: _bool = ...,
        sort: _bool = ...,
        group_keys: _bool = ...,
        squeeze: _bool = ...,
        observed: _bool = ...,
        dropna: _bool = ...,
    ) -> SeriesGroupBy[S1, tuple]: ...
    @overload
    def groupby(
        self,
        by: CategoricalIndex | Index | MonoGroupByObjectNonScalar,
        axis: AxisIndex = ...,
        level: Level | None = ...,
        as_index: _bool = ...,
        sort: _bool = ...,
        group_keys: _bool = ...,
        squeeze: _bool = ...,
        observed: _bool = ...,
        dropna: _bool = ...,
    ) -> SeriesGroupBy[S1, Any]: ...

Note that I did not include the np.ndarray object in MonoGroupByObjectNonScalar since it can be 2D. Not sure how this one should be treated.
Of course this proposition is just an illustration, I suppose such division would call for many other modification elsewhere, especially within core/frame.pyi and that there might be better solution.
To Reproduce
The following example shows that the type of output is deduced to be list[tuple[tuple, Series]] while it should be list[tuple[bool, Series]]
import pandas as pd
import numpy as np
from typing import reveal_type

series = pd.Series(np.random.randn(10))
above_0 = series > 0

output = list(series.groupby(above_0))

print(output)
reveal_type(output)

output when running with python :
[(False, 0   -0.666977
2   -1.586030
3   -0.862037
5   -0.617085
6   -1.553402
8   -0.694892
9   -0.492148
dtype: float64), (True, 1    0.848925
4    0.603415
7    0.938546
dtype: float64)]

Output when running with pyright
example.py:11:13 - information: Type of "output" is "list[tuple[tuple[Unknown, ...], Series[Unknown]]]"

This happens because the list function calls the __iter__ method which is typed here : https://github.com/pandas-dev/pandas-stubs/blob/70c412c84ec70fabdeb6b774b06811758b1b4b2b/pandas-stubs/core/groupby/generic.pyi#L143
Please complete the following information:

OS: Ubuntu
OS 22.04
python version : 3.10
version of type checker : pyright v1.1.298
version of installed pandas-stubs : 2.0.1.230501

I'm open to a PR that would address this.

If you want Series[S1].groupby() to allow a Series[S2] as an argument, where S1 and S2 are really covering the same types, but you want the result of SeriesGroupBy[S1, S2], then you would need to duplicate the TypeVar of S1 and define S2.  We had to do that with HashableT# .
Note:  I'm pretty sure this is what you'd need to do to get it to work, but not 100% sure.

authors: ClementPinard Dr-Irv

repo: pandas-dev/pandas-stubs


text:
Bibliography place: control the placement of a citeproc bibliography in a Pandoc template

Useful to place something between the end of text and the bibliography when using citeproc. The filter places any citeproc generated bibliography Div in a metadata variable, referencesblock, that can then be printed anywhere in a custom template. Since the entire Div is passed on, any formating pandoc/citeproc applies to it for various outputs is preserved.
The filter does not affect biblatex / natbib outputs, so it can be used with a custom template that caters for all bibliography engines.

In the first version only the Div with identifierrefs was captured. But this may be preceded by a header. In the new version the filter captures both the references and whatever heading immediately precedes them.

repo: pandoc/lua-filters


text:
Use more common expression for 24/7

Normally, it's 24/7, not 7/24 (ref: https://en.wikipedia.org/wiki/24/7_service)

Thank you @rassie 🚀

authors: omeraplak rassie

repo: pankod/refine


text:
Optimistic store updates, update store before navigation happens.

Describe the problem
When writing to a query param the store only updates once the navigation has finished, this can cause a non-instant change when using user input like a select. This feels janky and isn't good UX. This is especially noticable when load functions are doing work since navigation only resolves once the load function finishes.
Describe the proposed solution
I don't know if this is technically feasable within the library but my proposal is to optimistically update the store. So instead of just mutating the URL and letting the subscribe handle the updates you can optimistically set the store before the navigation even happens so the store is updated immediately.
Downside would be that the update would cause subscribers to get notified 2 times. (Unless you can detect the value was updated optimistically and only update if the optimistic value doesn't match the actual URL value).

this should be fixed by #60 since the navigation only happens after the debounce but if you have an actual example i can try

repo: paoloricciuti/sveltekit-search-params


text:
Support LINE Profile+

Motivation
Profile API endpoint (https://api.line.me/v2/profile) doesn't support LINE Profile+. If we want to retrieve LINE Profile+, we should use ID token verification https://api.line.me/oauth2/v2.1/verify.
Changes
All of following include breaking changes.

Modify UserInformationEndpoint

https://api.line.me/v2/profile -> https://api.line.me/oauth2/v2.1/verify

Remove AppId / AppSecret properties, because these are alias properties
Modify class prefix

LineXxx -> LineOAuthXxx

Set only openid as the initial value of the Scope property


text:
Support multi-level partition tables

What feature are you requesting?
Support for foreign tables in a multi-level partitioned table setup (see example).
Why are you requesting this feature?
When you have a lot of large files in one object store key/directory, scanning all of the files can be prohibitively time consuming. Changing the storage structure to support hive keys may not always be an option.
What is your proposed implementation for this feature?
This is an example of a multi-level partition table, but in many cases only the first partition level would be needed.
Example:
A “root” table that will have two partition “levels”:
CREATE TABLE my_table(
  <column definitions>
) PARTITION BY list(id_1);

The table for the first partition level:
create table if not exists my_table_123
partition of my_table
for values in ('123') partition by list(id_2);

Many partition tables may be created at this level - one for each id_1 value in the root table.
Note: If these first two tables have to be created as foreign tables in order for the last partition level table to be a foreign table, they shouldn’t require a files option.
The table for the next partition level looks like this:
create foreign table if not exists my_table_123_abc
partition of my_table_123
for values in ('abc')
options (files 's3://<bucket_name>/.../<filename>.parquet');

Many partition tables may be created at this level as well - one for each id_2 value in the first partition level tables.
Note: when creating this final “leaf” partition table as a foreign table, a files option should be required.
So, when querying the root table with a where clause like this:
select *
from my_table
where id_1 = '123'
and   id_2 = 'abc'

...only one parquet file should be scanned - the one specified by the files option of the “leaf” partition table. Or, if a glob pattern is used in the files option of the leaf partition table, only the (ideally) few number of matching files will be scanned.
Full Name:
Patrick Park
Affiliation:
Payzer

Hi @philippemnoel , I am interested to work on this feature, could you please assign it to me

Hi @philippemnoel , I am interested to work on this feature, could you please assign it to me

Absolutely, it is yours! Thank you for your work :)

authors: pdpark philippemnoel shamb0

license: PostgreSQL


text:
Unify build_empty_payload and default_ethereum_payload_builder function

Describe the feature
the logic of both is the same
https://github.com/paradigmxyz/reth/blob/020597da32ae5e94a473ab002462f3d5cb004132/crates/ethereum/payload/src/lib.rs#L80-L91
and could be unified if default_ethereum_payload_builder already gets the tx iterator and not the pool.
the empty payload would then simply call this with std::iter::empty()
and try_build with the pool's iterator
https://github.com/paradigmxyz/reth/blob/020597da32ae5e94a473ab002462f3d5cb004132/crates/ethereum/payload/src/lib.rs#L302-L305
or better would be a closure that returns the iterator so we can create it when we need it
Additional context
No response

Feel free to assign

authors: emnul mattsse

repo: paradigmxyz/reth


text:
feat(optimism): Canyon Hardfork Tracker

Describe the feature
The Canyon hardfork for the OP Stack is currently in-development upstream. This issue will serve as the meta-tracker for all tickets created for implementing support for this next hardfork in op-reth.
Schedule
Note: The hardfork has not yet been scheduled on any network. This ticket will be updated with the timestamp of each network's transition time as they are scheduled

Network
Timestamp

Goerli
1699981200

Sepolia
1699981200

Mainnet
n/a

Tickets
### Canyon Hardfork Tasks
- [ ] Add Canyon hardfork types
- [ ] Activate Shanghai alongside Canyon
- [ ] Change EIP-1559 parameters on Canyon transition
- [ ] Fix bug where the `deposit_nonce` is not included in the receipts root hashing in `op-geth` + `op-erigon`.
- [ ] Deploy the `create2Deployer` on the Canyon transition for Base Mainnet only.
- [x] Add `Canyon` hardfork to `revm`

Additional context
Resources

Reference tracking issue. Contains links to reference implementations of the required changes.
Reference testing plan
Shanghai Activation Specification

Canyon hardfork definition in revm: https://github.com/bluealloy/revm/pull/871

Closing as done 😄
reference PRs:
#5551
-> #5542
--> #5527
---> #5526
----> #5504
-----> #5503
------> https://github.com/paradigmxyz/reth/pull/5519


text:
chore(txpool): add pooled transaction function to get full tx object

ref #1482
with eth68, tx hashes are no longer sufficient.
we need a function to get all transactions objects instead.

ah, needs to fix conflicts with #1482

authors: Rjected mattsse


text:
feat(net): added NetworkMetrics

Closes #684

Codecov Report

Merging #708 (5227e63) into main (93b6ce5) will decrease coverage by 0.01%.
The diff coverage is 46.15%.

@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
- Coverage   72.90%   72.88%   -0.02%
==========================================
  Files         263      264       +1
  Lines       26949    26960      +11
==========================================
+ Hits        19646    19650       +4
- Misses       7303     7310       +7

Flag
Coverage Δ

unit-tests
72.88% <46.15%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/net/network/src/lib.rs
100.00% <ø> (ø)

crates/net/network/src/metrics.rs
0.00% <0.00%> (ø)

crates/net/network/src/manager.rs
47.23% <54.54%> (+0.17%)
:arrow_up:

crates/net/eth-wire/src/capability.rs
61.79% <0.00%> (-1.13%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

authors: TechieBoy codecov-commenter


text:
default state for hacking/picking should be open

Avoid use.
Remove hackable/pickable tags when success.

Done.

repo: paralinguist/Heist-Server


text:
Added authenticatable model class in config file

In case if you use observer on model FilamentComment to send email notification with queue like this:
class CommentObserver
{
    public function created(FilamentComment $comment): void
    {
        if ($manager = $comment->user->manager) {
            Mail::to($manager)->queue(new CommentMail($comment));
        }
    }
}

you will catch an error:
local.ERROR: Cannot use "::class" on value of type null {"exception":"[object] (TypeError(code: 0): Cannot use \"::class\" on value of type null at .../vendor/parallax/filament-comments/src/Models/FilamentComment.php:28).
So, maybe it's better to set up variable $authenticatable from config file.

That's great thank you @PetroZaburko! This will be included in the next release.

authors: PetroZaburko luke-parallax

repo: parallax/filament-comments


text:
refactor updates

Changes

Implement TryFrom<libp2p::gossipsub::Message> for pchain Message.
Moved EngineError to mod engine and renamed to EngineStartError
Removed PeerBuilder struct
Peer created through Peer::start()
Engine::start() no longer returns peer but the JoinHandle and Sender

@AlvinHon Please also advise on whether EngineCommand should be moved into engine.rs or in peer.rs

@AlvinHon Please also advise on whether EngineCommand should be moved into engine.rs or in peer.rs

It should be in engine.rs. EngineCommand is provided by engine. engine mainly provides function start. Imagine that collaborators will search how to use function start, and they will also need to know what are the commands. Then, engine.rs is reasonable place.

I have some comments:

the module engine seems not necessary when we now have the Peer struct as a handle of the pchain-network, so you can

remove engine and replace its functionality with Peer
rename the joinhandle as handle, the mpsc sender as just sender, EngineCommand as PeerAction

in conversion.rs,

rename ConversionError to PeerIdTryFromPublicAddressError.
directly use DecodingError in TryFrom<PeerId> for PublicAddress

in the start function, it is better to document more about what are the handlers about.

authors: AlvinHon manngayin612 ong-jonas

repo: parallelchain-io/pchain-network


text:
ELINK_MAILBOXSTAT always zero

not empty flag is never updated

How do you know if the register readback is broken/times out?
On Mon, Jan 18, 2016 at 8:57 AM, Ola Jeppsson notifications@github.com
wrote:

not empty flag is never updated
—
Reply to this email directly or view it on GitHub
https://github.com/parallella/oh/issues/35.

--
Andreas Olofsson, CEO/Founder at Adapteva
Cell: +1 781 325 6688
Twitter: @adapteva
Web: adapteva.com
Linkedin: linkedin.com/in/andreasolofsson
http://www.adapteva.com/

$ dmesg
...
Unhandled fault: external abort on non-linefetch (0x1018) at 0xb6984210

On 2016-01-18 15:03, Andreas Olofsson wrote:

How do you know if the register readback is broken/times out?
On Mon, Jan 18, 2016 at 8:57 AM, Ola Jeppsson notifications@github.com
wrote:

not empty flag is never updated
—
Reply to this email directly or view it on GitHub
https://github.com/parallella/oh/issues/35.

--
Andreas Olofsson, CEO/Founder at Adapteva
Cell: +1 781 325 6688
Twitter: @adapteva
Web: adapteva.com
Linkedin: linkedin.com/in/andreasolofsson
http://www.adapteva.com/
—
Reply to this email directly or view it on GitHub https://github.com/parallella/oh/issues/35#issuecomment-172534097.

--
Phone: +46.733208642
Skype: olajep
Email: ola@adapteva.com

... and the program gets aborted with a  bus error signal

Might be a hint:
https://github.com/parallella/oh/blob/master/emailbox/hdl/emailbox.v#L125
//TODO: check that high bits stay high

My point was that if the readback is broken, then everything is broken
(including readback from mailbox).
On Mon, Jan 18, 2016 at 9:30 AM, Ola Jeppsson notifications@github.com
wrote:

Might be a hint:
https://github.com/parallella/oh/blob/master/emailbox/hdl/emailbox.v#L125
//TODO: check that high bits stay high
—
Reply to this email directly or view it on GitHub
https://github.com/parallella/oh/issues/35#issuecomment-172541217.

--
Andreas Olofsson, CEO/Founder at Adapteva
Cell: +1 781 325 6688
Twitter: @adapteva
Web: adapteva.com
Linkedin: linkedin.com/in/andreasolofsson
http://www.adapteva.com/

I can do a 64-bit write to E_MAILBOXLO from Epiphany and then read out the value from ARM via E_MAILBOXLO / E_MAILBOXHI.
On 2016-01-18 15:42, Andreas Olofsson wrote:

My point was that if the readback is broken, then everything is broken
(including readback from mailbox).
On Mon, Jan 18, 2016 at 9:30 AM, Ola Jeppsson notifications@github.com
wrote:

Might be a hint:
https://github.com/parallella/oh/blob/master/emailbox/hdl/emailbox.v#L125
//TODO: check that high bits stay high
—
Reply to this email directly or view it on GitHub
https://github.com/parallella/oh/issues/35#issuecomment-172541217.

--
Andreas Olofsson, CEO/Founder at Adapteva
Cell: +1 781 325 6688
Twitter: @adapteva
Web: adapteva.com
Linkedin: linkedin.com/in/andreasolofsson
http://www.adapteva.com/
—
Reply to this email directly or view it on GitHub https://github.com/parallella/oh/issues/35#issuecomment-172546230.

--
Phone: +46.733208642
Skype: olajep
Email: ola@adapteva.com

That seems very unlikely based on current bug...but I will keep checking.
On Mon, Jan 18, 2016 at 9:46 AM, Ola Jeppsson notifications@github.com
wrote:

I can do a 64-bit write to E_MAILBOXLO from Epiphany and then read out the
value from ARM via E_MAILBOXLO / E_MAILBOXHI.
On 2016-01-18 15:42, Andreas Olofsson wrote:

My point was that if the readback is broken, then everything is broken
(including readback from mailbox).
On Mon, Jan 18, 2016 at 9:30 AM, Ola Jeppsson notifications@github.com
wrote:

Might be a hint:

https://github.com/parallella/oh/blob/master/emailbox/hdl/emailbox.v#L125

//TODO: check that high bits stay high
—
Reply to this email directly or view it on GitHub
https://github.com/parallella/oh/issues/35#issuecomment-172541217.

--
Andreas Olofsson, CEO/Founder at Adapteva
Cell: +1 781 325 6688
Twitter: @adapteva
Web: adapteva.com
Linkedin: linkedin.com/in/andreasolofsson
http://www.adapteva.com/
—
Reply to this email directly or view it on GitHub <
https://github.com/parallella/oh/issues/35#issuecomment-172546230>.

--
Phone: +46.733208642
Skype: olajep
Email: ola@adapteva.com
—
Reply to this email directly or view it on GitHub
https://github.com/parallella/oh/issues/35#issuecomment-172548206.

--
Andreas Olofsson, CEO/Founder at Adapteva
Cell: +1 781 325 6688
Twitter: @adapteva
Web: adapteva.com
Linkedin: linkedin.com/in/andreasolofsson
http://www.adapteva.com/

fixed

authors: aolofsson olajep

repo: parallella/oh


text:
Does it take in account deletion of a property with a patch ?

Hi @pardahlman,
I don't know .NET (at all), so, sorry if I'm wrong!
I see that line in the serialiazer : https://github.com/pardahlman/akeneo-csharp/blob/master/Akeneo/Serialization/AkeneoSerializerSettings.cs#L17
I suppose it ignores null values in an object no ?
If it's the case, it would be impossible to delete a variant group of an existing product with a patch.
PATCH api/rest/v1/products/id_01

{
    "variant_group": null
}

Of course, it works with any nullable properties to delete a property (parent of a category for example).

@ahocquard - thanks for raising the question! I think you are right, but I'd like to ask some follow-up questions on the topic. Let me get back to you in a few days!

Hello again, @ahocquard
I've played around with the API and here's the current take on the payload I'm sending:

If a property is null, like variant_group in your example, but also in patching scenarios of product values like the once in the documentation, null is passed to the API so that values can be removed.
When creating a new product, if no explicit value is provided for the array properties (like values, association etc) an empty array is passed along as property value (previously entire property was omitted)

Does this make sense to you? Can you think of any other "null related" scenarios that I need to consider? 🙂
Do I understand correctly that there is no way to remove an attribute from a product all together, the only thing I can remove is the attributes value?

Hi @pardahlman,
From what you are saying I don't know if it behaves correctly. Let me describe it more precisely.
Imagine you have an attribute with variant group_group foo and family bar.
Your simplified product will be:
{
  "code":"my_code",
  "variant_group":"foo",
  "family":"bar"
}

Now, if you want to delete the variant group, you should do this request:
PATCH api/rest/v1/products/my_code

{
    "variant_group": null
}

You should not be forced to GET the product before doing this operation. After all, you are not using the other value family, just deleting variant_group value.
So, it could be complicated to know in an object Product if the property variant_group has null value due to the initialisation of the object or because you are setting it at null intentionally.
But it seems to work differently between Java and .NET.
In java:
Product product = new Product();
System.out.println(product.getVariantGroup()); // print null but because it's a new object, but should not be displayed in the serialised JSON
product.setVariantGroup(null);
System.out.println(product.getVariantGroup()); // print null but because you set it manually, and should be displayed in the serialised JSON to delete the value

So, you see in the example above that it's complicated to know when serialising the object if it's null intentionally or not.

@ahocquard I see what you are saying. It is problematic as null is the default value of an unassigned reference type, but if explicitly set to null it should be passed to the API.
I understand that you are writing a PHP client, too... I'm guessing that you will run into a similar problem in that client. Do you know how you plan to  solve it?

@pardahlman We will use array in PHP. It's in the DNA of the language and not surprising. Also, it means far less coupling between the client and the server too.
For example, adding a property in a resource = 0 maintenance with array. Not the case with object (you have to add the property in the object).
And the goal of an API is to avoid coupling between client server, so let's use array in PHP.
But we tried with object too and that's why I've seen that problem ;) And object is not an option in Java or .NET, because these languages are fully OOP.
There are some solutions, but unfortunately I don't know the best one.

Use a kind of constant when setting with null. Because the "null" value of an unassigned  reference type is actually not

the same value as a "null" of an assigned reference type.

I've seen that in Java, you have Optional now (https://docs.oracle.com/javase/8/docs/api/java/util/Optional.html). Don't know if it exists in .NET, I don't think so.

use a list of modified properties in the object. Then , when you are serialising, the object know which properties that should be in the JSON.
But it implies to use different objects:

object used by the serialiser when setting the value in a GET request. The properties are not considered modified in that case.
object used by the user. Each modified property should be registered in that case.

I've searched a design pattern but without any success. I think that it's because PATCH is generally not used so much. With PUT, you don't have this problem, and it's the default verb in REST when updating. Not very useable in the PIM context though.

@ahocquard - thanks for letting me know. I guess it almost becomes a philosophical question at this point, the array solution indeed decouples the client from the api, but it does not give the end user the same effortless usage of the client as you would need to know what the expected property names are 🙂
I've been thinking along the line of your suggestion, but right now I'm leaning toward using .NET's dynamic object.
client.UpdateAsync<Product>("product_id", new { variant_group : null});

I'll try it out and let you know how it goes!

@pardahlman yep, it really depends of the philosophy of the language. Array are so convenient in PHP (it's almost JSON), it will be easy to manipulate just by reading the documentation. Same in JS (because it's directly JSON ;) ).
And it offers the possibility to implement object "client" using the "array" client by composition (one package using another one). Then you would have 2 clients : object client + array client.
In Java, you have List (numerical array of PHP) and Map (associative array of PHP), it's far less convenient to generate a JSON ! You had to implement it with object. I would choose Java 8 Optional I think.
I don't know how to handle it in .NET properly : do your best ;)

@ahocquard perhaps I'm missing something... but, I think it is strange that when I create a product, if I omit properties like variant_group  the API silently ignores it and falls back to some default (like "no variant group"). However, if I omit locale or scope from an entry in the values array, the API complains that it is not present. I think it would make sense if if was interpreted the same way as if null was provided for these values.

@ahocquard added documentation about the update behaviour: http://akeneonet.readthedocs.io/en/latest/updating-resources.html
care to read and give your input on it?

Hello @pardahlman I was pretty busy but I will try to read it this week and give a feedback :)

Hello @pardahlman and sorry for the delay.
The documentation is clear.
I don't understand the sentence "This approach requires no extra round-trip, but gives the caller greater greater responsibility." in "Delete values" chapter, could you explain me why ?
Btw, good job for the documentation 👍

Hello, I think we can close this discussion :)

authors: ahocquard pardahlman

repo: pardahlman/akeneo-csharp