text:
Is a hash-based license detector the right choice of backend?

(Generalising from #40)
Looking at the https://github.com/go-enry/go-license-detector README, I noticed

The detection algorithm is not template matching; this directly implies that go-license-detector does not provide any legal guarantees. The intended area of it's usage is data mining.

That suggests to me that wwhrd is using https://github.com/go-enry/go-license-detector outside of its intended scope, in its role as a license checker.

I've outlined some specific concerns/observations with the hash-based approach below.
I suspect the has-based approach of https://github.com/go-enry/go-license-detector is going to be hard to manipulate to fix for #40 when two licenses have overlapping text (as ISC and 0BSD do). My suspicion is the hashing/weighting algorithm is giving more weight to the exact-match 0BSD with interposed extra text, compared to the ISC exact-match-with-optional-and-alts.
There's a few other inexplicable 'UNKNOWN' results in the relevant build-log, e.g.
https://github.com/spf13/cobra is detected as UNKNOWN despite a LICENSE.txt which is a 1:1 match to https://github.com/spdx/license-list-data/blob/master/text/Apache-2.0.txt (data source for go-license-detector) once whitespace is normalised and the appendix is dropped.
I'm somewhat suspicious that go-license-detector might need to clean its dataset, as I suspect the problem here is that it has included the appendix in its hash, even though it is not part of the license itself, and the source dataset marks it as optional.
But I haven't tried to pull go-license-detector apart hard enough to know if I'm right about these issues, or even assigning the issue in the right place. At this point, I consider them symptomatic and likely to reoccur across licenses due to the nature and design intention of the library, i.e. working-as-intended as a fast and rough datamining support library.

I also have some problems with the license detection (see #41).
One approach could be to let wwhrd support multiple license detection packages.

Just did a quick look at the old license detection package (github.com/ryanuber/go-license) and I agree, that the approach taken there is pretty rough and maybe error prone. Basically for each license, that is recognized, there is a single sequence of word, that needs to be present in the license (https://github.com/ryanuber/go-license/blob/master/license.go#L162-L221).
I would be interested to know how the other packages in https://github.com/go-enry/go-license-detector#quality actually work and if there is a way to either combine them or give the user a choice.

In that comparison, a notable absence is the (regex-based) one used by pkg.go.dev, https://github.com/google/licensecheck. A different (hash-based) license checker from Google, https://github.com/google/licenseclassifier is part of the comparison.

@TBBle and @breml, thanks for the comments and the insights.
The reason to move away from the original library was to improve license recognition; at the time of the decision, the best option was to use a hash-based detection. Empirical tests proved to be much more accurate.
I admittedly didn't pay much attention to this space, but I really like the approach google/licensecheck is using.
I'm interested in providing the most accurate reporting possible, so I'll give google/licensecheck a try and maybe implement an interface for multiple backends.
Thanks again for helping through this.

One big advantage of github.com/google/licensecheck specifically is that because it's used by https://pkg.go.dev/, there's positive pressure to either account for more random variations seen in Go packages in the wild, or for the Go packages with random variations to change to conform to what github.com/google/licensecheck can recognise.
Since Go packages is what wwhrd cares about, that seems like a good thing.
Of course, the flip-side is that if github.com/google/licensecheck wrong, then wwhrd is as wrong as pkg.go.dev. github.com/google/licensecheck specifically calls out "no false positives" as a goal, so an incorrect detection should result in "UNKNOWN" and manual follow-up rather than misidentified licenses and accidental violations.

@TBBle @breml I found the time to implement google/licensecheck as the backend in a new release and cut an RC tag for 0.4.0.
I plan to make the backend pluggable and add an interface for it before cutting a GA tag, but I would appreciate some feedback on the new detection engine 😄

I did some checks on our mono repo and the results do look promising. I was able to remove all exceptions from the .wwhrd.yml config file and github.com/davecgh/go-spew/spew is now correctly recognized as ISC (this has not been the case before, because ISC was not yet on the whitelist but wwhrd did never complain).
I also could remove some of the licenses from my config, where I suspect, that these have been cases of non deterministic results in the past, especially: 0BSD, MPL-2.0-no-copyleft-exception and Mup.
From what I can tell, at least the following cases have changed:

package
old
new

github.com/davecgh/go-spew/spew
0BSD
ISC

github.com/go-sql-driver/mysql
MPL-2.0-no-copyleft-exception
MPL

The case for Mup I am no longer able to reproduce, I assume, that this case already vanished in one of the previous updates of wwhrd.
Additionally, I opened #49.

Sorry, I took a while to get back to this, and try it against https://github.com/docker/compose-on-kubernetes/. Compared to https://github.com/docker/compose-on-kubernetes/pull/170 (as at https://github.com/docker/compose-on-kubernetes/pull/170/commits/5f3cab14ede0e0d8c2b6e5cf249256fd78576333), I was able to remove almost all the exceptions, except:

github.com/munnerz/goautoneg which still reports as UNKNOWN as it's a single-file module with an inline license; and
github.com/opencontainers/go-digest which detects as CC-BY-SA-4.0 (found in LICENSE.docs) rather than Apache-2.0 (found in LICENSE.code). This oddity was fixed upstream in https://github.com/opencontainers/go-digest/issues/37 so there's nothing WWHRD need to do about this.

So overall, a major win.
I have a concern that the license for github.com/hashicorp/golang-lru is detected as MPL-2.0, not MPL-2.0-no-copyleft-exception. I have re-added those modules as exceptions so that this distinction is not lost, as it's the reason for blacklisting GPL and related licenses.
Since the https://github.com/docker/compose-on-kubernetes/ CI pipeline always uses the latest wwhrd, I plan to recreate that PR, to take advantage of the massive improvements in wwhrd.

Cool! Looks like this is a significant step in the right direction. I'll continue fixing bugs over the holiday and cut a proper v0.4.0 release in the new year.

Just cut v0.4.0-rc.2 which is going to be the last RC before cutting the release, probably tomorrow or next week.
Please give it a try and thanks again for the help troubleshooting and fixing issues.

Just cut v0.4.0-rc.2 which is going to be the last RC before cutting the release, probably tomorrow or next week.
Please give it a try and thanks again for the help troubleshooting and fixing issues.

v0.4.0 has been tagged and wwhrd now uses the github.com/google/licensecheck library for license detection.
I'll enqueue an issue to make the license library pluggable in v0.5.0, for now, I will close this issue.
Thanks a lot for your help in making wwhrd better! 🎉

v0.4.0 has been tagged and wwhrd now uses the github.com/google/licensecheck library for license detection.
I'll enqueue an issue to make the license library pluggable in v0.5.0, for now, I will close this issue.
Thanks a lot for your help in making wwhrd better! 🎉

authors: TBBle breml frapposelli

repo: frapposelli/wwhrd


text:
Typo fix

changed
'bower isntall chartist'
to
'bower install chartist'

Ah, thanks for pointing it out!

source: gharchive/pull-request

authors: NerdCowboy fraserxu

repo: fraserxu/react-chartist

license: mit

license_type: permissive

license_source: bigquery


text:
FormButtonWrapper absolute positioning breaks when adding content in skill page

When selecting skill categories, the content below (textarea and checkbox) is pushed over the FromButtonWrapper:

This could be fixed with IntersectionObserver. Eg. By watching the overlap between the button wrapper and the form content wrapper

Or we could use a min-height on the form content itself that would be 100vh - navbar - page headers - buttons

source: gharchive/issue

repo: freddydumont/dhamma-list

license: MIT

license_source: github-api


text:
🛑 EC is down

In 587803d, EC (https://ec.tut.ac.za) was down:

HTTP code: 0
Response time: 0 ms

Resolved: EC is back up in 8af6d3f.

repo: fredre/ecMonitor


text:
License not showing on pypi.org page

For some reason, the MIT license is not shown on https://pypi.org/project/creosote/

Fixed.

repo: fredrikaverpil/creosote


text:
Life cycle diagram for install, bootstrap, pre- and post- stages

Relevant to https://github.com/fredrikhgrelland/vagrant-hashistack/pull/386

Relevant #399

repo: fredrikhgrelland/vagrant-hashistack


text:
Develop - members section

Add members sections/cards along with focus and hobbies

Great job! Removed spacing for section end comments and removed contact section.

repo: free-code-camp-ashburn/website


text:
feat: flexbox example the odin project

Checklist:

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #XXXXX

I am not sure why the linter is so whiney.

I'll take a peek.

authors: Sembauke naomi-lgbt

repo: freeCodeCamp/demo-projects


text:
Ordered and Unordered list can be empty

Probably not a big deal, but in the ordered and unordered list session the tests pass even if the list items are empty
https://learn.freecodecamp.org/responsive-web-design/basic-html-and-html5/create-a-bulleted-unordered-list

Browser Name: Chrome
Browser Version: 69.0.3497.32 (Official Build) beta (64-bit)
Operating System: Mac OS High Seirra

@raisedadead I will do that and work on it.

@raisedadead Thank you for the response. I was able to reproduce this bug locally. Would you like me to work on it?

Sure thing. All yours! Happy contributing!

@raisedadead Is it possible for you to assign this issue to me? This will save us from any duplicate work.

Hi, is anyone currently working on this issue? or can I have a go at it?
@raisedadead @aditijoshi14 ?

Hey @co16353sidak there are several issues that we could use your help on. Have a look on the open issue. Feel free to tag me or others from the mods team for queries, including pointers to codebase.
Can you check back on this specific issue in a few days? If @aditijoshi14 has not requested more time by then you could look into next week.
Thanks a lot for you help. Happy contributing!

@co16353sidak Hi, thank you for checking. I am currently working on it!

Awesome @aditijoshi14, do tell me how it pans out.

@co16353sidak sure!

@raisedadead I was thinking of using regex to match the text inside  tags. I was just wondering if we should just accept alphabets(A-Za-z) or should we accept numbers and symbols as well?

@aditijoshi14 I say they should probably contain anything except only white space characters.

@RandellDawson Thank you so much for your response. I will work on that.

@aditijoshi14 If you get stuck, let me know.  I have come up with an assert which I think will work well.

@RandellDawson Thank you so much for asking. I am making some progress but I will definitely let you know if I get stuck.

repo: freeCodeCamp/freeCodeCamp


text:
"Run the Tests" button on freeCodeCamp doesn´t work

I have a problem that the button doesn´t work AT ALL. It starts at "if/else" statements on the Javascript course. The button doesn´t run the code, literally nothing happens. I search already on the web for a solution but nothing, and I can´t continue practicing with this situation.

@aguskurincic Do you see any errors showing in the browser console (not the FCC console)?

Can you be more specific about your problem @aguskurincic? what exactly are you doing that causes this, what browser/operating system you are using - maybe some screen shots. Anything to help us understand the problem is a big help. Is it only one specific challenge? or is it many/all of the challenges?

Hi @aguskurincic let us know with additional clarifications as requested above and we can have this re-opened. You can also reach out to our community forum for more help.

@RandellDawson it shows an undefined error in the console, but never happened with this page. The button must run the code anyways

@moT01 I´m almost 67/68% of the course complete using Chrome, always works good. When this happens I change to Firefox, but still the same, it looks like is problem of the page. I´m using Widnwos 10 Pro. But this doesnt make sense, I did amost 3/4 parts of the course without problem, the page has a bug there I think. It´s the "Chaining If Else Statements" challenge. But the one before starts with this problem, somehow I could run it.

Hi @aguskurincic let us know with additional clarifications as requested above and we can have this re-opened. You can also reach out to our community forum for more help.

Would be cool if you re-open this.

Forget it, I could solve it! Thanks

@aguskurincic What was the issue?

It had a couple of { } more than I need, really weird that the page doesn´t show you what is going on, since you are learning...

@RandellDawson It had a couple of { } more than I need, really weird that the page doesn´t show you what is going on, since you are learning...

@aguskurincic do you remember what the buggy code was?  The console should be more informative than 'undefined error'.

authors: RandellDawson aguskurincic moT01 ojeytonwilliams raisedadead


text:
fix/clarification of console.log in the browser

Pre-Submission Checklist

[X] Your pull request targets the staging branch of freeCodeCamp.

[X] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)

[X] You have only one commit (if not, squash them into one commit).

[X] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue (replace XXXX with an issue no): Closes #15242

Description

I've created a new challenge which goes through the process of looking at console logs and step by step encourages the user to see how each console log is processed through the tests.  Then there is a possible fix if the user would like to only console.log one variable using console.clear and finally a reference to the console web API on MDN that has many useful console.log options.
In the future might need to practice some squashing of commits...
I noticed that I spelled begining incorrectly should be beginning, but I'm guessing there might be a few more edits on this first round....

@ed42311 thanks for opening this PR.
@HKuz Since you created the Debugging section, could you take a look at this? I see a few minor issues with it (JavaScript isn't properly capitalized). I just want to make sure this challenge is as clear as can be.
Also, I think instead of sending people to the MDN, we should try to explain the concept as well as possible ourselves. Each of these challenges will have corresponding wiki articles, which they can link to from there.

Hi folks, sorry for the delayed response, you caught me switching to a new computer and in the middle of a move. I'm on spotty wifi, so likely will be early next week when I'm able to give this a proper look. Thanks for your patience, @ed42311 !

no worries @HKuz let me know what I can do to help.  Thanks for the followup @QuincyLarson.

Hey @QuincyLarson, this is a bit off topic, but thought it might be a decent place to start the conversation anyway.  Interest in helping with the editing on Medium for FCC, not sure you still need it since  this post was awhile ago.  If you still need it, I'm down to jump in somewhere. Let me know where to jump to that conversation if it's still relevant.

@HKuz OK - sounds good. We will wait for your word on this.
@ed42311 Please send an email to submit@freecodecamp.org and we can correspond regarding the volunteer Medium editing role :)

@HKuz Awesome!  Thanks for all the edits and the clarity of thought as well, I'll take a deeper look and update the pull when work and life look away for a moment and I'm allowed some space.  :)

kk,

[x]  'message: Use console.log() to print the outputTwice variable.  In your Browser Console this should print out the value of the variable two times.'
[x]  'message: Use console.log() to print the outputFour variable.  In your Browser Console this should print out the value of the variable four times.'
[x] optional test, does it need to be there? Take out the test, but leave in the ability to try it.
[x] minor tweak: "...which one prints" -> "which statement prints"
[x] delete unneccesary code block after // Modify...
[x] // Open browser console
[x] OutputTwo/four specfic
[x] Remove MDN link
[x] "cycles, "

LMKWYT 😸

@HKuz @QuincyLarson let me know how the changes look...

@HKuz could you take a look at this when you get a moment since you're more familiar with it? If it's ready, you can merge.

No worries @HKuz.  Hope to get to this by tonight/wednesday after that it might be next week.  Going into the  mountains ⛰ for awhile.  Thanks for the edits.

Hey @HKuz I stepped back a bit and removed the outputFour, it wasn't very clear what I was trying to do there I think, just testing for the original case of the double run through and then the option to have someone clear the console and print a single variable.  LMK what you think, I'll keep an eye on this so we can get it wrapped up.  Cheers.

Thanks, @ed42311 ! I'll take a look at this tonight or tomorrow!

LGTM!! 👍 🥇 💻
Thanks for adding this challenge (and for your patience during the review process) @ed42311 !! I just made one minor change on top of yours to remove a reference to a function that's no longer in the challenge so we could get this merged. 💥

Ah so cool @HKuz  Thanks for all the effort in reviewing.  It's been fun.  Hope to see a few more I can work on...  Cheers.

authors: HKuz QuincyLarson ed42311


text:
fix(styles): Overlay js warning to preserve preview pane height

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #16804
Closes #16839
Description

@Bouncey, @BerkeleyTrue I just QA'd the changes.
Now, during JS warning scroll bar in the preview pane isn't working.

authors: Bouncey vkWeb


text:
Updated Layer 4 Description

Description

Pre-Submission Checklist
Common mandatory requirements

[ ] This pull request targets the master branch of freeCodeCamp.
[ ] Branch starts with either fix/, feature/, or translate/
(e.g. fix/signin-issue)
[ ] Reviewed necessary guidelines in CONTRIBUTING.md.

By submitting this pull request, I have verified the following:

[ ] Added descriptive name to pull request. (mandatory)
Your PR should NOT be called Update index.md, since it does not help the maintainer understand what has been changed.
Good Guide PR title examples:
fix(guide): Git - edit Git Commit article
feat(guide): PHP - create PHP section and add Data Structures article

Good Coding challenge PR title examples:
fix(coding): add tests to Basic HTML challenge
fix(coding): update instructions to CSS Grid challenge

Good Learning platform PR title examples:
fix(platform): fixed sign in api
fix(platform): removed css from editor

Issues Closures

[ ] Addressed currently open issue. (replace XXXXX with an issue no in next line)

Closes #XXXXX
Since this change is a copy edit or translation for Guide articles or Coding Challenges:

[ ] I confirm no plagiarized, duplicate, or repetitive content that has been directly copied from another source.
[ ] I am adding only https links to external sources.
[ ] I am not adding short links instead of full URLs to webpages.
[ ] I have followed the recomended style guides for the copy edit.

Requirements, for changes which are NOT simple copy editing or translations:
You may skip the below ONLY if your changes do not touch tests, ui logic, api-server, etc. Your PR may not be accepted, if you did not meet these mandatory requirements. Simply put, we can't assume it will work if we never saw it working.
Since this change adds, updates or removes coding challenge tests:

[ ] I completed the coding challenge locally, and the changes look good.
[ ] Other tests or user stories in instructions are not affected.

Since this change is for the Learning platform (UI, logic, etc.):

[ ] I confirm my changes look good by running freeCodeCamp locally.
[ ] All new and existing tests pass the command npm test.

(Optional) Additional Context and Screenshots:

As noted in the review of #18377 (which touches the same file) - I'm closing this PR and ask that you move these changes over there. Thanks!


text:
Add this changes.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Please refer to the style guide. All code blocks should be formatted using the appropriate markdown.

Hi @JamyangLotus, thank you for the PR! However, I will have to close it because it does not conform with our Style Guide.
Feel free to open a new PR, though. Happy coding!

authors: ArielLeslie JamyangLotus huyenltnguyen


text:
Changed spacing in the CSS for consistency

This change would make the CSS code more consistent with the other examples

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Closed and Reopened this PR in an attempt to attempt to break out of the Travis build pending status.

@deveshp Thank you for your contribution. At this time we have decided not to merge your pull request. We welcome future pull requests from you.
Reason:
The modifications in this PR do not significantly improve the previous material and may introduce new issues.
Happy Coding!

authors: RandellDawson deveshp nikrb


text:
Create carro.py

[x] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Meu codigo é de loja de carros

Hi,
Thanks for this pull request (PR).
Unfortunately, we are marking this PR invalid for hacktoberfest. We believe it does not follow the recommended guidelines:

Quality Standards
In line with Hacktoberfest value #2 (Quantity is fun, Quality is key), we have provided examples of the quality standards we encourage. This applies mainly to beginners.

PRs that are automated e.g. scripted opening PRs to remove whitespace / optimize images.
PRs that are disruptive e.g. taking someone else's branch/commits and making a PR.
PRs that are regarded by a project maintainer as a hindrance vs. helping.
Something that's clearly an attempt to simply +1 your PR count for October.

Learn more at https://hacktoberfest.digitalocean.com/details


text:
Made the Escaping literal quotes channel accept the dot inside the double quotes too

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #40398

As discussed in the issue, now both versions of the string pass:
I am a "double quoted" string inside "double quotes".
I am a "double quoted" string inside "double quotes."

regex changed to as per requests below ."|".

I am good with these changes.  Need another approval.

authors: RandellDawson ieahleen


text:
fix: Remove unnecessary comments

https://github.com/freeCodeCamp/freeCodeCamp/pull/41612
Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Hi, thanks for creating this PR, but this not a change we will be making at this time.
While we cannot accept this contribution, if you would like to help out, please take a look at our contributing guide for other things you can do.

authors: emerconghaile ojeytonwilliams


text:
Remove port 8080 in URLs in Google API config guide and add missing project creation step

https://github.com/freeCodeCamp/mail-for-good/wiki/How-to-configure-your-Google-API-Keys
We need to add Project creation step for creating a Mail for Good project
I think we need to look into the docs completely and try the setup once to see if the docs are up to date with the new code and config

Similar to #194

The current docs aren't update to with the update Google Api Keys site, I will sent a pull request to fix this soon.

@wadleo Not really. I think it's up to date. Can you be more specific on what's missing ?

yeah, you are correct the guide here matches the Google API management site, but I think developers who are new to using the Google API site would find it difficult because you have to start by selecting a project or creating a new project, before following the steps in the guide. I think that is the only step missing. When the user logins into Google API site, selects the project(mail-for-good) on the top left drop-down or add another project on the dialog box that opens. before following all the steps here. I think this will make the guide more explicit and least confusing. If this is ok with you, I will send a PR to update this guide and the ports mentioned above.

Oh yes. I did think about the project creation

@wadleo Sure! PRs are welcome :smile:

Hi @karuppiah7890 here is my change, https://github.com/wadleo/mail-for-good-wiki but I need help to create a PR to this issue, since it is not possible to send pull request for wikis on github, since there aren't part of the cloned or forked project.

Oh yes, I know. Also, remove the port number 80 in the file, as it's not needed. Just http://localhost is fine, as browsers will try to access port 80 by default when the protocol is http as 80 is the default listening port for HTTP servers
Hey @zhakkarn can you help here in merging this Wiki ?

ok I will update the guide

@wadleo Thank you for raising this to our attention.
@karuppiah7890 @wadleo Has this been addressed? If so we can close this.

@AndrewGHC No, it hasn't been addressed

I think this problem has been completely solved now from the commits above. I think we can close this issue now

authors: AndrewGHC karuppiah7890 wadleo

repo: freeCodeCamp/mail-for-good


text:
Installworld failed:ERROR: Required ntpd user is missing

I try to build img for pine64. then fail when installworld.
$ cat /usr/crochet/work/_.installworld.aarch64.log
make[1]: "/usr/crochet/work/obj/usr/src/arm64.aarch64/toolchain-metadata.mk" line 1: Using cached toolchain metadata from build at freebsd on Thu Nov  8 11:24:53 UTC 2018
ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
*** Error code 1

Stop.
make[1]: stopped in /usr/src
*** Error code 1

Stop.
make: stopped in /usr/src

This issue occur when build in "freebsd 11.02".
Finally I use "freebsd 12.0-BETA3 amd64" in my virtualbox to build and everything is ok.

@zqb-all I'm working in a qemu image, and FreeBSDs later than 11.2 won't even boot.

Getting this error now.
Raspberry Pi, FreeBSD 12.0-RELEASE.  The ntpd user and group are present in the building host.  src is borrowed from my poudriere jail created just today (poudriere jail -c -j FreeBSD:12:amd64 -v 12.0-RELEASE -a amd64).  My crochet is also from today (master, zip).

I experience the same problem as @tldrm Maybe this bug should be reopened.

authors: kozross reezer tldrm zqb-all

repo: freebsd/crochet


text:
Bump sbt to 1.2.6; update dependencies

Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
Bump sbt version to 1.2.6
Update dependency versions

Why the explicit reference to junit?
I was running into problems with transitive dependencies, specifically:
Symbol 'term org.junit' is missing from the classpath.
I suspect this is due to interaction between the latest version of sbt and org.scala-sbt.ivy. It may be because junit is special - it's pure Java and independent of the Scala compiler. Forcing a more recent version of junit seemed to resolve those problems.

@ucbjrl can you add a comment about that? That is a bit weird...

The:
Symbol 'term org.junit' is missing from the classpath
occurred when running tests under Scala 2.11.12.
sbt test

and
sbt "++2.12.7" test

both work correctly. But
sbt +test

and
sbt "++2.11.12" test

both fail with
[error] /nscratch/ucbjrl/firrtl/src/test/scala/firrtlTests/FirrtlSpec.scala:193:18: Symbol 'term org.junit' is missing from the classpath.
[error] This symbol is required by 'class org.scalatest.junit.JUnitRunner'.
[error] Make sure that term junit is in your classpath and check for conflicting dependencies with `-Ylog-classpath`.
[error] A full rebuild may help if 'JUnitRunner.class' was compiled against an incompatible version of org.
[error]   implicit class TestingFunctionsOnCircuit(val circuit: Circuit) extends AnyVal {
[error]                  ^
[warn] one warning found
[error] one error found
[error] (Test / compileIncremental) Compilation failed

when compiling for 2.11.12. Adding a specific dependency on junit in build.sbt seems to alleviate the issue.
NOTE:  mill has a similar problem, so it may be a ammonite issue.

Would you mind adding a short explanation as a comment in the build.sbt?

authors: jackkoenig ucbjrl


text:
threefold/actions_3script

branch development_web3gw

These are tools to process incoming 3script actions and then talk to threefold/web3gw to get things executed
make some good examples in 3script in .md files
dependencies
#243

work pending on this https://github.com/freeflowuniverse/crystallib/issues/243

so far issue is kinda fixed, except for the money.v here I didn't get what should be done there method names and args are not clear also some of them not compatible with the methods in rpc
created a new issue here https://github.com/freeflowuniverse/crystallib/issues/285 to be tracked

need to see together what we have and how far we got,

authors: Omarabdul3ziz ashraffouda despiegk

repo: freeflowuniverse/crystallib


text:
Fixes proto code generator for repeated types

This PR fixes list types as repeated (for custom types) in the generated proto files.
case class Foo(bar: List[CustomType])

Results as:
message Foo {
   repeated CustomType bar = 1;
}

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   10.75%   10.75%
=======================================
  Files          20       20
  Lines         279      279
  Branches        0        1    +1
=======================================
  Hits           30       30
  Misses        249      249

Impacted Files
Coverage Δ

rpc/src/main/scala/proto/converters.scala
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a1dd6c...6eb9590. Read the comment docs.

authors: codecov-io juanpedromoreno

repo: frees-io/freestyle-rpc


text:
NER to include endpoint of resource

When you perform NER on a text, you get the resources of the entities. However, when more information is needed about a resource, by using e-Link, the endpoint is needed, because we need the endpoint to create a template.
Is it possible to add the endpoint for each resource to the NIF?
This is especially important when the NIF is being used by multiple services, as a certain service might not know on which dataset e-entity was performed earlier on in the process.

Is it possible to add the endpoint for each resource to the NIF?

By adding this info to each entity will increase the NIF size significantly.
What if we better documented the templates. So that we include information such as: "this template can be used if you performed NER using the DBpedia dataset?". Will this help?

But then you still have to know which dataset was used for e-entity, and this is not always the case.

well, maybe you can derive the dataset by looking at the entity URIs?
http://dbpedia.org/resource/ for DBpedia
http://orcid.org/ for ORCID
...

This is not possible, as the entity URI do not have to be related to the endpoint URI.

true, but also entity URI does not need to be present in any endpoint.
Also note that for entity linking is used data which not necessarily should be deployed in some endpoint. So there are two assumptions here:

the client should be aware about the entity links from which domain they come
the clint should be aware in which datasets these entities are described

IMO this is big and open research question: know in which endpoint a resource can be found. Closing the issue.

repo: freme-project/e-Entity


text:
Not an issue, more of a question {endpoints}

I'm trying to create a express app where it would communicate with Lavalink was wondering if there is a way of getting guild data such as the queue etc to display on the website? I have my discord bot connected to Lavalink and that returns data such as what's in the queue, how many players are connected to that 'node'. I've tried using the same technique connecting using my express app but it doesn't show the same data... Is this because the 'node' creates instances?
Thanks

Lavalink doesn't have the concept of a queue.
Lavalink doesn't currently have an endpoint to check what track (if any) is playing for a guild. You could get that data from your client

authors: MarquesCoding freyacodes

repo: freyacodes/Lavalink


text:
FR: addressbook-query restrict result properties

Following https://tools.ietf.org/html/rfc6352#section-10.4 it is possible to limit the properties of the vcards to be returned by a addressbook-query.
So basically we should be capable to process a request like this
<?xml version="1.0" encoding="UTF-8"?>
<C:addressbook-query xmlns:D="DAV:" xmlns:C="urn:ietf:params:xml:ns:carddav">
  <D:prop>
    <D:getetag/>
    <C:address-data>
      <C:prop name="VERSION"/>
      <C:prop name="UID"/>
      <C:prop name="NICKNAME"/>
      <C:prop name="EMAIL"/>
      <C:prop name="FN"/>
      <C:prop name="TEL"/>
    </C:address-data>
  </D:prop>
</C:addressbook-query>

@evert are you interested in accepting an PR on this?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/37992122-fr-addressbook-query-restrict-result-properties?utm_campaign=plugin&utm_content=tracker%2F294006&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F294006&utm_medium=issues&utm_source=github).

Yes, I think this would be awesome! I feel that it would be good to:

Consider the CalDAV variant, even if you don't implement it right away. At least think about how that would work as well, because as usual the CalDAV variant is more complex than the CardDAV variant and generally there's some benefits to doing the harder one first.
Always include certain properties whether they were requested or not. Specifically, VERSION, UID should always be in there and maybe also FN. This way if a client requests a minimal object, the vcard will always still be valid. I realize this is a deviation of the spec, but I think it's worth it.

Hey @DeepDiver1975 ,
Thanks for all the commits. Must have been a lot of work. Especially with the subtle changes between versions. If you ever run into this again, I wanted to give you a small tip:

Don't bother with versions you don't care about. I don't think owncloud uses 3.0 any more, so 3.1 onwards would have been fine. I only care about adding features to older versions if anyone wants them, and even then I rather not. So basically pick ownclouds minimum sabre/dav version and go with that.
I find it easier to implement the feature at the oldest version, and then merge upwards. So I'd first develop it in 3.0, then merge it into 3.1, then 3.2, etc. This makes things a lot easier because things are typically more easily forwards compatible, and I this is how I literally always merge (always forward, never backward) so up to this day it should always be pretty easy to merge from any version to the next.

You might have done this too, I wasn't sure... but if you started with the newest and worked backwards it was probably a bit harder than it should have been.
cheers and thanks again!

I'm happy to help out with stuff like this. Given a decent unit test suite backports are not that hard :wink:

repo: fruux/sabre-dav


text:
[#FLAT-500 #FLAT-501] Security headers updates

https://sourceclear.atlassian.net/browse/FLAT-500
https://sourceclear.atlassian.net/browse/FLAT-501

Looks :ok: !

authors: ArthurZaharov RamilGilmanov

repo: fs/security-headers


text:
npm WARN deprecated fsevents@1.2.4: Way too old

I'm getting npm WARN deprecated fsevents@1.2.4: Way too old as well as a bunch of related, for example:
../fsevents.cc:50:32: error: no template named 'Handle' in namespace 'v8' static void Initialize(v8::Handlev8::Object exports);
after running npm install -g elm-test node-test-runner. I'm using elm v19.
running node v12.10.0 and npm v6.11.3, OSX Mojave 10.14.6
I've posted the problem in both repos.  Don't know where to even start on this issue.

I'll answer my own question here
https://github.com/yarnpkg/yarn/issues/3678
run yarn global add node-pre-gyp

repo: fsevents/fsevents


text:
Add an extension point to paket pack to specify dependancies by framework

to make it possibile to support dependencies by framework (like .NET Core) until #913 is ready
I think two command line arguments are enough, it's a temporary but can help a lot, and low regression (replacement/addition are done after nuspec is generated)
an example:

paket pack --defaultgroup net40 to put generated nuspec deps inside a group

paket pack --additionaldeps "path/to/file" and path/to/file contains the other groups in nuspec format
<group targetFramework="DNXCore5.0">
   <dependency id="Microsoft.FSharp.Core.netcore" version="[1.0.0-alpha-151221, )" />
   <dependency id="NETStandard.Library" version="[1.0.0-rc2-23811, )" />
 </group>
 ```

mhm. can you come up with a syntax for paket.template instead?

I dont know enough about resolution and backward compatibility to comment about paket.template syntax.
I know that's an hack, i was trying to find something safe and easy to implement
But maybe it's better to wait template support, more clean, i'll close

Let's keep it open for discussion. I will revisit soon

Dunno, probably that's not the best way, or is not ok.
It's a bit selfish, but i just need something to add .NET Core framework to nuget packages created with paket pack atm is really an hack ( ref chessie https://github.com/fsprojects/Chessie/pull/43/commits/eef358e50b5c2f57ca3b93f3c391eb82a975f8b7 ) for dependencies ( unzip nuspec from nupkg, modify nuspec xml, zip back ).
Maybe some way to change the nuspec before the nupkg is created is ok too.
I can add the hack in FAKE as target, but not everyone who use paket use fake too, so it's a annoying

I have a need for this as well. Specifically I'll need to express something along the lines of in the template file:
<dependencies>
    <group targetFramework=".NETFramework3.5">
        <dependency id="TaskParallelLibrary" version="1.0.2856" />
    </group>
    <group targetFramework=".NETFramework4.0" />
</dependencies>

authors: cdrnet enricosada forki

repo: fsprojects/Paket


text:
netcoreapp5.0 -> net5.0

This cherry-picks @thinkbeforecoding's fix for net50 to the bugfix branch so that the 5.x stables can use net5.0 as well.

I tried to release this but seems the certificate for signing paket.exe is outdated. paging @agross

This is now released

excellent! thank you for running this down :)

authors: baronfel forki


text:
chore(main): release veto 0.3.15

:robot: I have created a release beep boop
0.3.15 (2024-05-22)
Bug Fixes

veto: use dts-bundle-generator to generate types bundle (b82220b)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/fuf-stack/uniform/releases/tag/veto-v0.3.15 :sunflower:

repo: fuf-stack/uniform


text:
🛑 Waddle Penguins Island - API is down

In 7ef56c9, Waddle Penguins Island - API (https://api.waddlepenguins.me/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Waddle Penguins Island - API is back up in 9fd5c63 after 10 minutes.

repo: fullmoondev/status


text:
🛑 Orders Service is down

In 3afe21e, Orders Service (https://api.waypath.io/orders/health-monitor) was down:

HTTP code: 404
Response time: 103 ms

Resolved: Orders Service is back up in e74df42.


text:
✨ Create demo app

Create an app for demo purposes.

Yes I totally agree

@fum4 You are the best


text:
Add option to store min/max of datasets in snapshots

This is useful when displaying a snapshot to infer an appropriate contrast range automatically.
I tried to store a dictionary {'valueRange': {'min': , 'max': }} but that does not seem to work with hdf5
If there is a way to actually do that in hdf5, please let me know.
Note: dumping as json string stores a string (and not a json/dictionary object)

I actually prefer a tuple over two values (I assumed that wouldn't work either, as dictionary did not work). As for the naming convention, Java prefers camel case but I can live with underscore.

We could even pass a callback to be more flexible.

Thanks!

authors: funkey hanslovsky

repo: funkey/gunpowder


text:
User list.append instead of yield

generators are not fast.
We could instead use:
_w = []
_a = _w.append
_a(element...)
...
return _w

Including a block then becomes:
_w.extend(self.block(context))

This has traditionally been a very fast way to construct and return lists.

Attempted this on a branch and it proved slower, probably because of all the additional calls.
Tried optimising sequential appends to be extends... still slower.

repo: funkybob/knights-templater


text:
chore: Upgrade Go version to 1.23

Upgrade Go from 1.18 → 1.23.
Upgrade golangci-lint from v1.55.2 → v1.61.0.
Upgrade sigs.k8s.io/controller-tools from v0.8.0 to v0.14.0, see https://github.com/kubernetes-sigs/controller-tools/issues/880.
Add copyloopvar lint rule since Go 1.22 introduced per-iteration variables in for loops.

Tests are still failing, we'll fix them in another PR.

repo: furiko-io/furiko


text:
Implemented Masonry Layout

(Finally closes #16 )
Looks like this now

I have implemented the React Masonry. I was very hard. Today I got to know the reason why people hate material UI. Its grid is very complex. It was not compatible with masonry. So I have to bring in the grid part of materialize css. But it turned out great at last.
HOPE THIS HELPS YOU
      const Harshit = new Developer()

I agree!! Well Done even Chuck Norris would like it! Keep up the Hard Work.

repo: fus-marcom/bulletin-react


text:
FuseBox don't load other bundle in the same folder (Nodejs Context)

It's related to this issue: #217
I try all the possibilities FuseBox.import, require & import es6 to get the p1.js but it is always undefined.
As I said in the previous issue, p1.js & bundle.js are the output.
I think it's a bug but please can you confirm.

After a discussion with @devmondo, my requirements are fulfilled and now i will build the beast!

repo: fuse-box/fuse-box


text:
Passing chokidar options to run doesn't work

Passing chokidar options to run doesn't work.

Could you be more specific please

Doesn't work:
const chokidar = { usePolling: true }

fuse.bundle('web.js')
  .instructions(`> web/web-fuse.ts`)
  .hmr()
  .watch() // <-- this calls `chokidar.watch`

fuse.run({ chokidar }) // <-- optioptions known only here

Also probably chokidar default ignored option should be /node_modules/. But at least docs should state that if one do not exclude modules folder it may significantly slow down things.

Fixed in 2.2.0-beta.1

authors: nchanged whitecolor


text:
Fuse apps on iPhone X

Asked for on Community.
With the new hairline of iPhone X, we should look into how Fuse apps are rendered on one. It is reported that currently the rendering doesn't take advantage of the extra screen real estate. No physical devices at this point, but XCode 9 comes with a Simulator at least.

The forum thread Xcode 9 and iPhone X posted by Luis Rodriguez was linked to this issue.

Is there an estimation when this would be supported?

No, not yet.

Hi everyone,
I resolve it by add to build/iOS/{BuildType}/{AppName}-Info.plist
<key>UILaunchStoryboardName</key>
<string>CDVLaunchScreen</string>

For permanent changes edit /usr/local/share/uno/Packages/UnoCore/1.4.3/Targets/iOS/Yoboresto/Yoboresto-Info.plist , and add before </dict>.
#if @(Project.iOS.PList.UILaunchStoryboardName:IsSet)
	<key>UILaunchStoryboardName</key>
	<string>@(Project.iOS.PList.UILaunchStoryboardName)</string>
#endif

PS: Sorry for my english i'm french speaker.

A Korea community member shared another solution by adding two additional LaunchImage screens:
[Adding the followings with images into Images.xcassets/contents.json]
{
      "extent" : "full-screen",
      "idiom" : "iphone",
      "subtype" : "2436h",
      "filename" : "iPhone_Portrait_iPhoneX_3X.png",
      "minimum-system-version" : "11.0",
      "orientation" : "portrait",
      "scale" : "3x"
    },
    {
      "extent" : "full-screen",
      "idiom" : "iphone",
      "subtype" : "2436h",
      "filename" : "iPhone_Landscape_iPhoneX_3X.png",
      "minimum-system-version" : "11.0",
      "orientation" : "landscape",
      "scale" : "3x"
    },

From my testing with adding two images (1125x2436 for iPhone_Portrait_iPhoneX_3X.png and 2436x1125 for iPhone_Landscape_iPhoneX_3X.png), it seems working well :)
[Before]

[Launch screen]

[hikr example]

@ianychoi: That fix has already been implemented a while ago. But thanks for the input :)

authors: badlee eksperts fusebuild ianychoi kusma ruudvanham

repo: fusetools/fuselibs-public


text:
Update .codeclimate.yml

Abby from Code Climate here!
As per our email, this will add ratings and exclusions to your .codeclimate.yml. :)

Current coverage is 79.39% (diff: 100%)

Merging #19 into development will not change coverage

@@           development        #19   diff @@
=============================================
  Files               43         43
  Lines              398        398
  Methods             40         40
  Messages             0          0
  Branches            19         19
=============================================
  Hits               316        316
  Misses              82         82
  Partials             0          0

Powered by Codecov. Last update 4c2434d...fc47261

authors: abbyarmada codecov-io


text:
Add Token dependencies to readme

Fixes #61   | Rendered: link

Problem/Rationale
Documentation regarding Fusion API is out of date given recent changes to leverage new Dependency Injection architecture.
Solution/Change/Deliverable
Update documentation

!merge

repo: fusionjs/fusion-plugin-universal-logger


text:
Update protocol 408

I cant use my own version.
So it's just to inform you that you have to add compatibility to the protocol 408
Thanks!

It will be updated tonight (3-4 hours later) in JST! Thank you for the PR!

authors: Willoxey fuyutsuki

repo: fuyutsuki/Texter

license: NCSA


text:
This macro is only reporting warning and doesn't work when called fro…

…m inside a osxcross generated environment.

Please don't tag me as a reviewer for systray. I don't have anything set up to test that with.

This is fixed by also upgrading to llvm v14 which require no code maintenance for us. Seems better.

authors: Bluebugs Jacalz

repo: fyne-io/systray


text:
"on" popup when hovering

When hovering a star that doesn't have a title, it will show an "on" popup

The title of each star image is the value of the input.
If you do this:
```<input type="radio" value="on" ````
...then it will show title "on".
This isn't a bug, it's the desired behaviour.
Please submit code sample if you believe this is incorrect.

repo: fyneworks/star-rating


text:
dateBetween($format = 'Y-m-d')

You have dateTimeBetween but no simple dateBetween.

You can simply do
$dt = $faker->dateTimeBetween($startDate = '-30 years', $endDate = 'now');
$date = $dt->format("Y-m-d"); // 1994-09-24

I know that that can be done, but why not a simple method to do that in one line? There are many other methods too but that was just one suggestion.

What's the reason for 'between' in your proposal when you supply just the format?
There is already a date($format = 'Y-m-d', $max = 'now')

Faker is like a pack of Lego™ bricks. I'm amazed by all the wonders you guys manage to build with it, but it doesn't mean that these wonders should be provided out of the box.
So we won't implement this. As @Powerhead13 said, it's a 2-liner.

@fzaninotto @Powerhamster
Saying your "amazed by us being able to build stuff with it" is totally unnecessary thing to say. It's a pretty reasonable request, dateBetween makes a lot of sense - especially when it comes to the unique() and other modifiers.
If you do:
$dt = $faker->unique()->dateTimeBetween($startDate = '-30 years', $endDate = 'now');

You'll end up with lots of unique date AND times - this is not what you want, you simply want unique dates between a given range. There are ways around it, like generating a random number and adding on those number of days etc, but that's not as explicit and a bit more clunky. Since there already is a dateTimeBetween it makes sense to have a corresponding dateBetween as well.

+1 $date = $this->faker->unique()->dateBetween('now', '+15 days');

+1 $date = $this->faker->unique()->dateBetween('now', '+15 days');

@fzaninotto Using dateTimeBetween() with unique() is still a issue. please reopen this or suggest a solution.

authors: Oxicode Powerhead13 bubblemedialtd fzaninotto garygreen hafezdivandari mstnorris the-noob

repo: fzaninotto/Faker


text:
Update Text.php

need both of this -—

Thanks

authors: fzaninotto gulaandrij


text:
update polish titles method that breaks the code

There was a call in static function to non-static methods that caused crashes. It is now fixed along with minor PHPdoc update

Can you paste a way to reproduce the crash this PR is supposed to fix? Even better: write a unit test about it.

@zkisly-toucan bump

I am going to close this PR since it is stale. Feel free to reopen it if needed later on.
Thanks for contributing!

authors: fzaninotto pimjansen zkisly-toucan


text:
🛑 Netxcloud is down

In 184ac00, Netxcloud (https://questioning-bird-5561.dataplicity.io/nextcloud/) was down:

HTTP code: 503
Response time: 1641 ms

Resolved: Netxcloud is back up in 7aea3e2.


text:
Move to using MiB for defining Task memory requirements

AWS Batch, Azure Kubernetes, and GCP all seem to use MiB for memory definitions. They also use integer instead of number
Propose we move to this model for defining Task memory requirements over a double GB.

I agree on using MiB. Besides the reason you state, we recently encountered some issues in Cromwell as users were making hyperoptimized WDLs and running afoul of things as they didn't understand the difference (WDL supports both units). What we wound up doing was always treating MB as MiB (and so forth up the unit chain) as for those types of users that's usually what they meant anyways, and MiB > MB so it was the safer fallback

authors: delagoya geoffjentry


text:
Fields of type"typing.Annotated" are not supported in pydantic

#490
Reproduced the issue with pydantic==1.7.4. After looking at the pydantic changelog v1.8 2021-02-26 introduced support for typing.Annotated hints on model fields. After installing pydantic==1.8 and trying to reproduce the issue, no errors were produced.

Thanks! In the github yaml files, the pydantic version is hardcoded for the unit tests, can you set it to 1.8.0 instead of just 1.* so that our unit tests run with the oldest version possible? Thanks!

Thanks! In the github yaml files, the pydantic version is hardcoded for the unit tests, can you set it to 1.8.0 instead of just 1.* so that our unit tests run with the oldest version possible? Thanks!

@gabrieldemarmiesse after modifying the pydantic version in the github jobs, lots of tests are failing. Upon taking a look at the stacktrace seems like the pydantic object is missing the __version__ attribute. This issue was fixed in version 1.9 according to the changelog. So either:

We modify the job to use version 1.9 (not the oldest version), which wouldn't tell us whether a new change breaks compatability with version 1.8; or
Modify both minimum supported version and job version to use 1.9; or
Modify references to __version__ and obtain the version by some other means.

We can se the minimul version to 1.9. That why we have our CI!

@gabrieldemarmiesse I've updated CI to use pydantic==1.9.

Many thanks!

repo: gabrieldemarmiesse/python-on-whales


text:
Improve typing of run()

This does duplicate the parameters one time, but this duplication can be removed once Python 3.10 is dropped. Or, the duplication could be removed today by having kwargs typed as Any on older version of Python. The implementation would need to be tweaked to use kwargs instead of individual named parameters for either of these.

Hi, thanks for this PR, I'm not opposed to such a change, but I'm a big worried the duplication will cause issues. (we'll update a signature and forget to update the other). I'm happy to merge such a change when we drop support to python 3.10 (~1.5 years for now). Sorry for that, we need to kkeep the project as low-maintenance as possible

I'm not opposed to such a change, but I'm a big worried the duplication will cause issues.

As I mention in the description, if you don't mind a partial loss of typing information on Python <3.11, then we can remove that duplication today. So Python 3.11+ gets the full typing support with correct return types, while older version of Python will see def run(**kwargs: Any) -> Union[...]. This loses some precision for older users (who already have awkwardly unusable return types), but increases precision for newer users.

I understand, but that would be considered a regression. And python 3.10 is still alive for two more years, so those users are still first class citizens in the eyes of the project. We'll stay with the status quo for a bit longer

No problem, I'll leave it up to you. But, from my perspective, the loss on 3.10 is minor (essentially .run(this_is_not_valid=1) won't produce a type error anymore) whereas the current problem with return types is unavoidable (the types in the union are completely incompatible, so doing anything with the return value will cause a type error without asserting the correct type first).

There is no problem to use Unpack in versions below Python 3.11, almost everything from stdlib typing could be imported from typing_extensions module

We already have typing-extensions as a dependency, feel free to use it :)

Ah, maybe I misread it earlier. Will update later.

That should be fine now. I'd note that it's probably worth introducing mypy to the project. I tried to check the code with mypy and there appeared to be >200 type errors already present in the code (without adding an extra strictness settings).

Thank you, before merging this, I'll try to see how it behaves in different IDEs. You don't need to do anything, I'm just running some tests to see if it's well supported :)

Sorry for the huge delay. I tried your PR with Pycharm and here is what I get:

As you can see, pycharm sees **kwargs but doesn't understand the TypedDict behind it. I'm using python 3.10.13 here, and pycharm 2024.1.1.
So I'm all for improving the typing experience, so in my eyes this PR still has a lot of value, but we'll wait until at vscode and pycharm both can understand the function signature before pushing forward.
I think you can convert this pull request to "Draft" and we'll reopen it when the two majors IDEs support this feature. Does that sound good to you?

So I'm all for improving the typing experience, so in my eyes this PR still has a lot of value, but we'll wait until at vscode and pycharm both can understand the function signature before pushing forward.

I feel like we have different priorities. As someone that is checking code with mypy and trying to have type safe code, the current state is unusable, as you will always get type errors due to the return type being incorrect. Whereas seeing the kwargs in an IDE seems like a nice-to-have, you can always look at the documentation if it's missing.
But, a quick search suggests that Pycharm 2024.1.2 already has support: https://blog.jetbrains.com/pycharm/2024/05/pycharm-2024-1-2/#code-assistance-for-typeddict-and-unpack
I'm pretty sure VSCode is built on top of pyright, which has supported Unpack for probably atleast a year, so I'd also be surprised if that really doesn't work with it (maybe it will error when you put the wrong kwarg in, even if it doesn't display the kwargs?).

pycharm 2024.1.1

So, looks like you were one patch release short of the Unpack support.

I'll retry it then, thanks for the info!
On Sun, 21 Jul 2024, 13:51 Sam Bull, @.***> wrote:

pycharm 2024.1.1
So, looks like you were one patch release short of the Unpack support.
—
Reply to this email directly, view it on GitHub
https://github.com/gabrieldemarmiesse/python-on-whales/pull/580#issuecomment-2241581551,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADCLMK4CU67IPBM34MGZMGLZNOOETAVCNFSM6AAAAABGQSZY7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBRGU4DCNJVGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

@Dreamsorcerer I retried and it works on VSCode and Pycharm :) I think we can merge this PR. Can you rebase/merge master into your branch? Afterwards we should be good to go :)

I forgot to check if the documentation generation works well with it. I'm sorry about that, the PR has far reaching consequences that are sometimes hard to find.

It seems we lose all the default values for the arguments in the docs. It looks like this now:

I wonder if it's better to duplicate all the default values in the docstring, or to just say that we won't be mypy-compatible until Python creates a typing feature that allows us to dedupe arguments in overloads. I'll think about it.

Yes, that'd be expected. I'm not aware of any plans currently to introduce defaults in this way, so I wouldn't want to wait on that.

The vast majority of them default to None or an empty list, which is probably not so important to document. I'd consider just manually documenting defaults for the few that are not obvious.

FWIW I agree with @gabrieldemarmiesse in being hesitant about this change... It's a slight sacrifice of readability in the function signature for the sake of cutting-edge and slightly immature typing features, not a totally obvious choice to me. I understand the issue with using a type checker under status quo, but I just use typing.cast().

but I just use typing.cast().

Sure, but then you have no type safety. A safer approach would be litter the code with isinstance() asserts, but it's rather annoying and unnecessary when the correct information is available.

FWIW I agree with @gabrieldemarmiesse in being hesitant about this change... It's a slight sacrifice of readability in the function signature for the sake of cutting-edge and slightly immature typing features, not a totally obvious choice to me. I understand the issue with using a type checker under status quo, but I just use typing.cast().

Having been using this package in a more tightly type-checked codebase I'd like to take back my hesitation and make myself +1 for this kind of change. Python's typing is unquestionably problematic in some areas, but in this case I agree with @Dreamsorcerer  that this provides net benefit.

The vast majority of them default to None or an empty list, which is probably not so important to document. I'd consider just manually documenting defaults for the few that are not obvious.

I'm on board with this for this case where defaults are generally unimportant, simply representing "not passed". (In fact, the distinction between "not passed" and "default value" should be made clearer with all args defaulting to None, see https://github.com/gabrieldemarmiesse/python-on-whales/pull/620 where passing an empty list should have had meaning).
Could we add overloads for Container.execute() as well?

authors: Dreamsorcerer LewisGaul Taragolis gabrieldemarmiesse


text:
Limiting the bars that show up

I was wondering how to get just a couple of health bars to show up only like the breakable tail and exhaust and can't figure out how to get that to work. Any help would be great.

As for now you can only set a timeout for the parts that are not changed to be hidden (after the trigger of the timer)

you can do that by changing this part on config.json
on
MonsterWidget.IncludePartGroupIdRegex : ".*",
to
MonsterWidget.IncludePartGroupIdRegex : "Removable",
this will show only removable part. for other stuff like status i havent try it myself. i remember the original post on nexusmod include  how to exclude some part / status by using the regex in config.json , but it seems i cant it. i cant remember is it in the description or in the post.

repo: gabrielefilipp/SmartHunter


text:
sitemaps for multiple domain name single app

i have exact same issue like this meteor forum post https://forums.meteor.com/t/using-meteor-with-multiple-domains
we have an app for multiple domain name, and the only way to get the domain name is from req.headers.host, can you add in the "req" or "req.headers" object to sitemaps.add function just like the solutions suggested in the forum post?

@chongwang87
#47 the newest version will match your need

Seems like this is causing a problem with the robots.txt since the sitemap added automatically there does not match the domain name.

authors: Taakn chongwang87 nlhuykhang

repo: gadicc/meteor-sitemaps


text:
🛑 Dissenter is down

In 5532d1f, Dissenter (https://dissenter.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Dissenter is back up in 6fff717 after 28 minutes.

repo: gadmln/gabstatus


text:
Schema.define could return associated instance

Found myself expecting Schema.define() to return the Schema instance when doing:
// In './Group.js'
import { arrayOf } from 'normalizr';
import User from './User';

export default new Schema('groups').define({
  users: arrayOf(User)
});

Thought it'd be a good idea if it did return it.

Yup, I think this is fine.

@xuoe could you add a unit test that checks that the instance is returned?

Nevermind, I'll add it myself.

@gaearon You may want to revert this one too if you think fluent APIs don't make sense here.

Yeah, sorry about the churn. We want to be very clear about which methods are mutating.

authors: gaearon unindented xuoe

repo: gaearon/normalizr


text:
Memory leak on server side!

Rendering this module on the server side generate a memory leak!

Please help fix it? 😉

Yep i'll try to take some time to investigate, this is not so easy to localise ^^

@ludoblues - do you have any more info on this? This is after calling DocumentTitle.rewind(), right?

We stopped using it, i'll reopen if i can reproduce it.

ok, thanks @ludoblues. Out of interest, what do you use instead? If there's a memory leak, it's likely that hints at a problem with the underlying react-side-effect library, so it'd be useful to know whether this was simply a case of omitting DocumentTitle.rewind() or whether there's a genuine memory leak somewhere.

@leebenson Yes we invoked DocumentTitle.rewind(), we are using Helmet instead, which also use react-side-effect. I didn't notice any memory leak.
I'll try to replace Helmet by react-document-title the week to see how it goes, i'll reopen if i notice something wrong!

Thanks @ludoblues

authors: gaearon leebenson ludoblues

repo: gaearon/react-document-title


text:
Add some minor grammar changes to README

Uses some different words to make things more readable

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   60.98%   60.98%
=======================================
  Files          18       18
  Lines        1548     1548
=======================================
  Hits          944      944
  Misses        500      500
  Partials      104      104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d975c...7b525c2. Read the comment docs.

@rprotasov Hello and Welcome! Thank you very much for your contribution! :)

Also a warm welcome from my side @rprotasov 🤗
Thanks a lot! ❤

authors: Skarlso codecov-io michelvocks rprotasov

repo: gaia-pipeline/gaia


text:
SearchGUI produces empty result

Running search_gui 3.3.10.1 and get an empty output (0 bytes) .. the tool is shown as successful (green).
stdout
X!Tandem,MSGF,OMSSA
DB: CBDB1_Proteome.fasta sequences: 1458
Spectrums:FileConverter on data 15: out(API:e0ad502b326926d4)
Setting paths
Path configuration completed.
Creating decoy database.
Reindexing: input_database.fasta.

Picked up _JAVA_OPTIONS: -Xmx6g -Xms256m
Picked up _JAVA_OPTIONS: -Xmx6g -Xms256m

stderr
cp: cannot stat â€˜input_database_concatenated_target_decoy.fastaâ€™: No such file or directory

In order to make the tool catch the error: For the cp: the commands in the tool command block should be separated by && or the tool profile should be >=20.09.
But I guess the error is elsewhere.

The original problem seems to be fixed + follow up fix here: https://github.com/galaxyproteomics/tools-galaxyp/pull/572

repo: galaxyproteomics/tools-galaxyp


text:
[GAL-329] Fix broken OG Image link

Changes

Set initial height to image since some SVG dont have it
Trim the nft description on single nft preview link

Before/After - NFT Description

Before/After - Single NFT (SVG)

Before/After - Collection with NFT (SVG)

follow-up: looks like i broke it 😓
using width: 100% only stretched it out lol

confusing though because it looks fine on the preview URL 🤔
https://gallery.so/opengraph/collection/27JCqjzgKo6zicp0RZ5l2rhCuZ7

Yo @Robinnnnn . Thats weird, I test the main branch on og image locally seems fine 🤔

Seems like 2/3 cases still need to fix.

thank you @jakzaizzat !

authors: Robinnnnn jakzaizzat

repo: gallery-so/gallery


text:
Kube config file can't use.

I try to create a keycloak-proxy in kubernetes by the yaml file your provided in the kube directory, but it does not work.
First I created a secret named config by using config_sample.yml file.
My secret shows as follow:
Name:		config
Namespace:	sync
Labels:
Annotations:
Type:	Opaque
Data
forwarding.yml:	3439 bytes
Then I create a keycloak by the yaml file with the latest image, but I get the error shows as follows:
[error] invalid options, flag provided but not defined: -config /etc/secrets/forwarding.yml
flag provided but not defined: -config /etc/secrets/forwarding.yml
@gambol99

You need
--config

instead of
-config

Yes, I already used --config, but it not work.

No idea. Maybe --config=/etc/secrets/forwarding.yml -> try to add that "=".
BTW: you have published full config of your IdP client.

hi @Frank-auckland ... was issue resolved? ... can i close the ticket

I give up, it still doesn't work, by our team change to another solution. So you can close it. If our team come back to this and there still have the problem, could I reopen it?

authors: Frank-auckland gambol99 jangaraj


text:
Party member stamped on screen after triggering Siegfried event in ghost train

Some party members might get stamped on screen if you trigger siegfried event in ghost train (after opening chest and fighting him).
https://media.discordapp.net/attachments/1018903473036738640/1020356146671915079/unknown.png?width=1193&height=671
https://media.discordapp.net/attachments/1018903473036738640/1020356515263152239/unknown.png?width=1194&height=670

Need to either fix the scene or just change the treasure to empty...

I just wound up engaging the boss fight and opening the empty box with no talking or acting.


text:
Little change can make vast impact on this existing application.

Enhance basic functionality to Skip with the file name, Skip All button on Confirm Action option.

This feature can help to continue from where you have stopped file transfer work.

Please add "Cancel (X)" Button to stop the process. Allow multiple file transfer upto 10 files at a time.

This feature can improve control over the process and add speed.

Add Social media logos at the bottom of the explorer main window so that credit visibility increase.

What is the solution to copy missing pictures from my collection folder from dicm folder? Means, if we have already copied one 1 file say new.jpeg and if again copy it will create new(1).jpeg.
So, this is creating confusions, so I have demanded one small change and big impact.

Due to the MTP connectivity complications it isn't possible to cancel a transfer, yes weird!

How do you cancel transfer then? No data will be corrupted if I will detach the cable?

authors: meihol sataset

repo: ganeshrvel/openmtp


text:
🛑 La Casa Agency is down

In 37c2059, La Casa Agency (https://www.lacasa.net/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: La Casa Agency is back up in d95d15b.


text:
#wizard - add welcome message to wizard module

add welcome message to the wizard module.

New commit has been fix this issue.
if you find any bugs pls make new issue
Regards,
~Ryu

repo: garasijogi/mosacc-backend


text:
Specify minAllowed for the gardener-resource-manager VPA

/area control-plane
/area auto-scaling
/kind enhancement
Release note:

The gardener-resource-manager VPA does now specify minAllowed values to prevent too low resource recommendations from VPA that lead to OOM.

The flaky test is unrelated to the PR and gets fixed with https://github.com/gardener/gardener/pull/5117

From my observations:

GRM in Shoot controlplane

on avg. the leading replica is consuming 70Mi-150Mi
the idling ones - 15Mi-40Mi

GRM in the garden ns of the Seed

the memory usage of the leading replicas rely varies on the Seed usage

for a Seed with a single Shoot - 70Mi
for a Seed with ~10 Shoots - 380Mi
for a Seed with 165 Shoots - up to 2Gi

the idling ones are again consuming 15Mi-40Mi

Hence, for the GRM in the Shoot controlplane I set:
      minAllowed:
        cpu: 20m
        memory: 30Mi

For the one in the garden ns in the Seed:
      minAllowed:
        cpu: 20m
        memory: 64Mi

/cc @voelzmo @shreyas-s-rao

authors: ialidzhikov rfranzke

repo: gardener/gardener


text:
adapt esreporter to ginkgo v2 report type

How to categorize this PR?

/area testing
/kind cleanup
What this PR does / why we need it:
Following the switch to ginkgo v2, the custom reporter still implemented DeprecatedReporter and was invoked via ReportViaDeprecatedReporter .  The PR drops the usage of deprecated structures and interfaces and implements a custom reporting using the new Report type only.
Which issue(s) this PR fixes:
Fixes #5321
Special notes for your reviewer:
/invite @dguendisch @timebertt @rfranzke
I'm not entirely sure regarding the categorization of the release note. @timebertt would be great, if you could double-check. Thanks!
Release note:

Use ginkgo v2 `Report` structures and drop usage of deprecated custom reporter. To adapt, replace the call of `reporters.ReportViaDeprecatedReporter` within any `ReportAfterSuite` node with `reporter.ReportResults(*reportFilePath, *esIndex, report)`

Testing
Since there are no unit/integration tests and the expected output structure contains timestamps / durations, I did a smal manual testing to qualify things.
Reports generated by testruns are attached to this PR, but here are also snippets to compare the relevant structure.
using the new reporter - succeeded step
{ "index": { "_index": "gardener-testsuite", "_type": "_doc" } }
{"suite":{"name":"Shoot Test Suite","phase":"Failed","tests":9,"failures":8,"errors":0,"duration":367.428},"name":"[DEFAULT] [RELEASE] [SHOOT] should download shoot kubeconfig successfully","shortName":"[DEFAULT] [RELEASE] [SHOOT] should download shoot kubeconfig successfully","phase":"Succeeded","duration":0.080158809}

using the deprecated reporter - succeeded step
{ "index": { "_index": "gardener-testsuite", "_type": "_doc" } }
{"suite":{"name":"Shoot Test Suite","phase":"Failed","tests":9,"failures":8,"errors":0,"duration":366.86},"name":"[DEFAULT] [RELEASE] [SHOOT] should download shoot kubeconfig successfully","shortName":"[DEFAULT] [RELEASE] [SHOOT] should download shoot kubeconfig successfully","phase":"Succeeded","duration":0.069546686}

using the new reporter - failed step
{"index": { "_index": "gardener-testsuite", "_type": "_doc" } }
{"suite":{"name":"Shoot Test Suite","phase":"Failed","tests":9,"failures":8,"errors":0,"duration":367.428},"name":" [DEFAULT] [SHOOT] should read runtime metrics","shortName":"[DEFAULT] [SHOOT] should read runtime metrics","phase":"Failed","failure":{"type":"Failed","message":"/go/src/github.com/gardener/gardener/test/framework/gingko_utils.go:26\nUnexpected error:\n    \u003c*errors.errorString | 0xc000b8a1a0\u003e: {\n        s: \"could not find template in \\\"/go/src/github.com/gardener/gardener/test/testmachinery/framework/resources/templates/simple-load-deployment.yaml.tpl\\\"\",\n    }\n    could not find template in \"/go/src/github.com/gardener/gardener/test/testmachinery/framework/resources/templates/simple-load-deployment.yaml.tpl\"\noccurred\n/go/src/github.com/gardener/gardener/test/testmachinery/shoots/applications/metrics.go:71"},"duration":10.507470436,"system-out":"[BeforeEach] Shoot application metrics testing..."}

using the deprecated reporter - failed step
{ "index": { "_index": "gardener-testsuite", "_type": "_doc" } }
{"suite":{"name":"Shoot Test Suite","phase":"Failed","tests":9,"failures":8,"errors":0,"duration":366.86},"name":" [DEFAULT] [SHOOT] should read runtime metrics","shortName":"[DEFAULT] [SHOOT] should read runtime metrics","phase":"Failed","failure":{"type":"Failed","message":"/go/src/github.com/gardener/gardener/test/framework/gingko_utils.go:26\nUnexpected error:\n    \u003c*errors.errorString | 0xc000be2f20\u003e: {\n        s: \"could not find template in \\\"/go/src/github.com/gardener/gardener/test/testmachinery/framework/resources/templates/simple-load-deployment.yaml.tpl\\\"\",\n    }\n    could not find template in \"/go/src/github.com/gardener/gardener/test/testmachinery/framework/resources/templates/simple-load-deployment.yaml.tpl\"\noccurred\n/go/src/github.com/gardener/gardener/test/testmachinery/shoots/applications/metrics.go:71"},"duration":10.346779425,"system-out":"[BeforeEach] Shoot application metrics testing..."}

deprecated_report.txt
new_report.txt

/invite @acumino

Does it make sense to add a unit tests specifically for this reporting (like what you did manually)? Would potentially give us more confidence in future ginkgo updates.

@dguendisch @acumino thanks for your suggestions.
I moved processing of the ginkgo report to separate function and added some basic tests for it. This should give us some confidence going forward while avoiding to parse & validate the json dump that is produced for the upload to an elasticsearch instance.

Thanks @hendrikKahl!

authors: dguendisch hendrikKahl rfranzke timebertt


text:
Wait for CSINode object before scheduling workload pods

How to categorize this PR?
/area robustness
/kind enhancement
What this PR does / why we need it:
Building upon #7406, this PR extends the node controller in the gardener-resource-manager to also take the readiness of CSI Drivers into consideration. See the proposal issue or documentation for more details.
Which issue(s) this PR fixes:
Contributes to #7117
Special notes for your reviewer:
Release note:
Gardener considers the readiness of CSI Drivers on the node before scheduling user workload. Please refer to the [documentation](https://github.com/gardener/gardener/blob/master/docs/usage/node-readiness.md) for more details.

Extensions should label `csi-driver-node` pods that they manage with `node.gardener.cloud/wait-for-csi-node-<suffix>=<driver-name>` to ensure user workload is only scheduled to nodes once the driver is properly registered. Please refer to the [documentation](https://github.com/gardener/gardener/blob/master/docs/usage/node-readiness.md) for more details.

/retest-required

/assign

/assign

/lgtm
/approve

authors: SimonKienzler acumino rfranzke


text:
Adding pictures of Fork and Clone#33

Added images and content
Fixes #33
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@garimasingh128 please review my PR

I will. Please move on to the next issue or create one.

@madhhuurrii pls change the base branch to master!

Ok

@garimasingh128 done.

Conflicting files
README.md

Please do a git pull and resolve this conflict!


text:
这个samba3.X的版本没有Ui吗？

这个samba3.X的版本没有Ui吗
samb4的就有ui

samba3.X请用ksmbd替代,

samba3.X请用ksmbd替代，

这个ui使用的版本和中文包的版本不一致是什么情况###

samba3.X请用ksmbd替代,

samba4也存在ui和语言包版本不匹配，然后语言包问题导致汉化无法使用

确实是否有安装对应的语言包
ctrl+F5 刷新浏览器缓存

UI和翻译版本还是不一致，为什么会这样？


text:
Change pybind11 source

He canviat l'origen del pybind compiler.

Proba


text:
Create 0000-01-02-gatoratemylips.md

created a branch, created a file and made a commit, and opened a pull request

update

repo: gatoratemylips/github-slideshow


text:
Use up-to-date transformers library

New and useful fixes have been added to the transformers library since the 4.10.2 release from September 2021 (https://github.com/huggingface/transformers/pull/13220). Can we remove the transformers==4.10.2 restriction from setup.py, so that including adaptor in the dependencies of a project no longer downgrades transformers?

Thanks!

repo: gaussalgo/adaptor


text:
writing registers with modpoll - how to do....?  ...reading works fine !

Hello together,
i use modpoll many time to read chinese inverters. ...works fine....
Next step - to give parameters to the inverters.
i understand csv-file....but i receive error messages from modpoll....
"UnboundLocalError: local variable 'ref' referenced before assignment"
The csv is:
device,wr1,1,,
poll holding_register, 300, 50, BE_BE
ref,cmax,332,Uint16,w
...it should write in Register 332 what on mqtt-broker is.... !?
someone have a idea....?
Thanks......

Hi, the holding_register writing function can be achieved via MQTT publish, take the online modsim as an example, when you run modpoll with MQTT broker specified,
modpoll --tcp modsim.topmaker.net --config https://raw.githubusercontent.com/gavinying/modpoll/master/examples/modsim.csv --mqtt-host mqtt.eclipseprojects.io

the tool will automatically subscribe to the topic modpoll/modsim001/set, so if you want to write to a specific holding_register, you can use any MQTT client tool, like mosquitto_client or MQTTX, publish the following message to the target device's topic, e.g. modpoll/modsim001/set for device modsim001,
{
  "object_type": "holding_register",
  "address": 40001,
  "value": 12
}

After the message succesfully published, you will see the value changed in modpoll output.

Hope it helps.
Thanks for your interest for modpoll. Cheers.
Gavin

BTW, you can find more details here in README.

Hi Gavin, with your documentation i've no positive result on my RPi-system....
now I've check what journalctl says to published messages on the modpoll RPi.....
My Inverter has a Remote Shutdown Register : {"object_type": "holding_register", "address": 420, "value": 0} to swich off (..and on)
Modpoll has in .csv the lines:

device,wr1,1,,
poll,holding_register,200,50,BE_BE
ref,rs1,420,int16,rw       # ( rs1 means remote switch 1 )

In mosquitto broker will publish the register in /hs36/wr/wr1/rs1/"1" (...for ON)
...works fine....
Now I published with mosquitto_pub:
mosquitto_pub -h xxx.xxx.xxx.xxx -p 1883 -t /hs36/wr/wr1/set -m "{"object_type": "holding_register", "address": 420, "value": 0}" for shut down the inverter...
journalctl shows an error:
Fail to parse json message: b'{object_type: holding_register, address: 420, value: 0}'

If I give the message without -m "{.........}"  as {....}
Error Message from mosquitto:
Error: Unknown option 'holding_register,'.

If I give the message with -m '{....}'
It will break the modpoll completly....
AttributeError: 'ModbusIOExeption' object has no attribute 'function_code'

...what other solutions I've to test....?
Thanks for help....

Hello again,
the right mosquitto_pub line is:
mosquitto_pub -h xxx.xxx.xxx.xxx -p 1883  -t /hs36/wr/wr1/set -m '{"object_type": "holding_register", "address": 406, "value": 1}'
(for example)
In journalctl i've see that the message arrive....after polling all csv-lines modpoll give the message:

Writing Register(s): device=wr1, address=406, value=1 -

...after that modpoll stops with errorcode:
return.result.function_code < 0x80
AttributError: 'ModbusIOException' object has no attribute 'function_code'
My Inverter need to write a register the functioncode 10H .....
modpoll has the possibility to give the function_code "10H" to the inverter ?
Thanks a lot.....

Yes, modpoll does support "10H", which writes mutiple registers, but in your case, looks only writing a single register, which shall use function code "06".
In fact, modpoll supports the following function codes, fyi.

read coils (01)
read descrete inputs (02)
read holding registers (03)
read input registers (04)
write single coil (05)
write single register (06)
write multiple coils (15 or 0x0F)
write multiple registers (16 or 0x10)

Can you share the complete logs? including the command you used to start modpoll for further investigation.

...now I try "minimalmodbus" to write the Inverter registers - it works fine....
The correct "minimalmodbus"-Line here is:
instrument.write_register(324, 560, 0, 16)
324 is the registeraddress
560 is the value without decimal - means 56.0 Volt finaly
0 - i dont know for what....
16 is the right command to write the register
I think modpoll should use the "16" command to write - not "10" or "6"....
Ii it possible to advise modpoll to use the 16 command for writing registers...?
tks.....

Close it due to no activities for long time.

authors: gavinying pythonlubo

repo: gavinying/modpoll


text:
Replace GTS with CDT

This removes the dependency on GTS.

It removes the Mesh boolean operations functions, which were part of the building editor in Gazebo-classic but are unused in modern gazebo.
It replaces the GTS delaunay triangulation with the header-only CDT library.

gts dep removal in the gz-common6-release repo when this lands: https://github.com/gazebo-release/gz-common6-release/pull/4

I tested this with the polylines.sdf world and I think some of the triangles may be oriented incorrectly, i.e. normals are in the opposite direction:
left: GTS vs right: CDT

I tested this with the polylines.sdf world and I think some of the triangles may be oriented incorrectly, i.e. normals are in the opposite direction:

I added a printout to the DelaunayTriangulation test to show the vertices for the triangles:
patch

diff --git a/graphics/src/DelaunayTriangulation_TEST.cc b/graphics/src/DelaunayTriangulation_TEST.cc
index df919d3..c441257 100644
--- a/graphics/src/DelaunayTriangulation_TEST.cc
+++ b/graphics/src/DelaunayTriangulation_TEST.cc
@@ -69,6 +69,32 @@ TEST_F(DelaunayTriangulation, DelaunayTriangulation)
   // same as number of vertices in the path
   EXPECT_EQ(subMesh.VertexCount(), 8u);

+  std::cerr << subMesh.Max() << '\n';
+  std::cerr << subMesh.Min() << '\n';
+  // Print vertices
+  std::cerr << "vertices: \n";
+  for (int v = 0; v < subMesh.VertexCount(); ++v)
+  {
+    std::cerr << subMesh.Vertex(v) << '\n';
+  }
+  // Print normals
+  std::cerr << "normals: \n";
+  for (int v = 0; v < subMesh.NormalCount(); ++v)
+  {
+    std::cerr << subMesh.Normal(v) << '\n';
+  }
+
   // there should be 8 triangles.
   EXPECT_EQ(subMesh.IndexCount() / 3u, 8u);
+  // Print triangles
+  std::cerr << "triangles: \n";
+  for (int i = 0; i < subMesh.IndexCount() / 3u; ++i)
+  {
+    int i1 = subMesh.Index(i*3 + 0);
+    int i2 = subMesh.Index(i*3 + 1);
+    int i3 = subMesh.Index(i*3 + 2);
+    std::cerr << '[' << subMesh.Vertex(i1) << "]\n"
+              << '[' << subMesh.Vertex(i2) << "]\n"
+              << '[' << subMesh.Vertex(i3) << "]\n\n";
+  }
 }

output with GTS

[ RUN      ] GTSMeshUtils.DelaunayTriangulation
1 1 0
0 0 0
vertices:
0.75 0.75 0
1 0 0
1 1 0
0.75 0.25 0
0.25 0.75 0
0 1 0
0.25 0.25 0
0 0 0
normals:
triangles:
[0.75 0.75 0]
[1 1 0]
[1 0 0]

[0.75 0.25 0]
[0.75 0.75 0]
[1 0 0]

[0.25 0.75 0]
[0.25 0.25 0]
[0 1 0]

[0.75 0.25 0]
[1 0 0]
[0.25 0.25 0]

[1 0 0]
[0 0 0]
[0.25 0.25 0]

[0.25 0.25 0]
[0 0 0]
[0 1 0]

[0.75 0.75 0]
[0.25 0.75 0]
[1 1 0]

[0.25 0.75 0]
[0 1 0]
[1 1 0]

[       OK ] GTSMeshUtils.DelaunayTriangulation (1 ms)

output with CDT

[ RUN      ] DelaunayTriangulation.DelaunayTriangulation
1 1 0
0 0 0
vertices:
0 0 0
1 0 0
1 1 0
0 1 0
0.25 0.25 0
0.25 0.75 0
0.75 0.75 0
0.75 0.25 0
normals:
triangles:
[0.75 0.75 0]
[1 1 0]
[0 1 0]

[0.25 0.75 0]
[0.75 0.75 0]
[0 1 0]

[0.25 0.25 0]
[0 1 0]
[0 0 0]

[0.75 0.25 0]
[0.25 0.25 0]
[1 0 0]

[0.25 0.75 0]
[0 1 0]
[0.25 0.25 0]

[0.75 0.25 0]
[1 0 0]
[0.75 0.75 0]

[1 0 0]
[1 1 0]
[0.75 0.75 0]

[1 0 0]
[0.25 0.25 0]
[0 0 0]

[       OK ] DelaunayTriangulation.DelaunayTriangulation (1 ms)

I tested this with the polylines.sdf world and I think some of the triangles may be oriented incorrectly, i.e. normals are in the opposite direction:

I added a printout to the DelaunayTriangulation test to show the vertices for the triangles:
patch
output with GTS
output with CDT

Thanks, I created a fix for this in #623. It also addresses other feedback in this PR.

I think we could ignore graphics/src/CDT in codecov.yml

I think we could ignore graphics/src/CDT in codecov.yml

I updated the ignore files in 7ddc32a

removed gts dep from package.xml in a159b79

authors: iche033 mjcarroll scpeters

repo: gazebosim/gz-common


text:
Sensor  has no effect

I've been constructing my own model drone and need to place 4 lidar sensors in specific places. I assumed since the docs say that if i add true to my sensor i can see the rays that make up the lidar, but when I open the model in Gazebo, the sensor is not visible. Am I misunderstanding the functionality of this feature?

The functionality is available via the "Visualize Lidar" GUI plugin in Gazebo, but it currently doesn't automatically get loaded when <visualize> is true. You'd have to manually add the plugin.

authors: NoelCav azeey

repo: gazebosim/gz-sensors


text:
Gazebo Server on Docker Container in EC2 instance & Gazebo Client on MacOS

Hello,
I have Gazebo Harmonic installed on both my Mac and my AWS EC2 instance Docker container. I am trying to run Gazebo on that EC2 instance, but unfortunately it is headless. I first tried setting up X11 forwarding, but this fails because of a wrong OpenGL version on my Mac.
I then tried instead to make the EC2 instance run only the server of Gazebo, and on my Mac run the client only. However, these two programs are running on different networks. I hence tried using VSCode TCP forwarding to forward all ports from the server to my Mac's localhost, but still encountered an issue with discovery.
I ran the following on my Mac Terminal:
GZ_IP=127.0.0.1 GZ_PARTITION=127.0.0.1:ros GZ_VERBOSE=1 gz sim -v 4 -g

and the following on a VSCode Terminal (so that TCP port forwarding happens automatically) on my EC2 instance within the Docker container:
GZ_IP=127.0.0.1 GZ_PARTITION=127.0.0.1:ros GZ_VERBOSE=1 gz sim shapes.sdf -s -v

The problem is that the UDP discovery process doesn't happen properly, since VSCode only forwards TCP, and hence the client keeps printing:
[GUI] [Dbg] [Gui.cc:343] GUI requesting list of world names. The server may be busy downloading resources. Please be patient

I could not find any straightforward way to get around the UDP discovery. UDP forwarding does not seem to be trivial? Do you know how to fix this? What is the recommended way to have a Gazebo server and client running on two different networks?
Thank you for your help,
Scott

Hi,
I am also trying to run the gazebo client and server on aws and a real computer and here is what can help to solve this problem:
If multicast traffic does not pass between the client and the server, then it is worth using a vpn that handle udp multicast to let server and client talk with each other.
If you dont want to use vpn, try the GZ_RELAY variable on each client pointed to server ip.
Please, let me know if this helps,
Roman

Thanks for the issue, but this is a type of question that is best asked on https://robotics.stackexchange.com/. I encourage you to post your question there and if you find that there's a specific bug or feature request, come back and create a new issue here. In the mean time, I'll go ahead and close this.

authors: Scott-Hickmann azeey rom341

repo: gazebosim/gz-transport


text:
Change template structure

I suggest to change current structure from this
.repo_name
├── ...
├── Library submodule
├── src
|    └── ...
└── ...

to this
.repo_name
├── ...
├── project_name
│   ├── __init__.py
│   ├── src
|        └── ...
|   └── Library submodule(s)
└── ...

This way we could get rid of sys.path.append('..') needed now for .py files in src that import stuff from submodules, and use project_name as a module.

Update to the proposal:
.repo_name
├── ...
├── src
│   ├── __init__.py
│   ├── Library submodule(s)
|   └── ...
└── ...

 Поменять структуру проекта в шаблоне

authors: a-arefina dpodvyaznikov


text:
Fix "POP AF" flags

The table lists flags "Z N H C" for opcode F1 ("POP AF"). This is incorrect, as none of the flags are affected by this instruction (which is also true for the other three POP instructions C1, D1 and E1).

Wrong. Check https://rednex.github.io/rgbds/gbz80.7.html#POP_AF

authors: avivace weibell

repo: gbdev/gb-opcodes


text:
check if image is avaiable before printing it on programme pages

If there is no images, then don't print them at:
https://demo.gbif-dev.org/programme/living-atlases
The problem seem to be that there is no image url and no check

Fixed as https://github.com/gbif/portal16/commit/5d3a151369e92dbfd601cd264dead21f554bcd0f

authors: MortenHofft burkeker


text:
feat: Support isakbm/gitgraph.nvim

https://github.com/isakbm/gitgraph.nvim

Can you add this in readme in the plugin support section?

Done!

authors: Isrothy gbprod

license: WTFPL


text:
widen reader environment

Unless I'm missing a trick somewhere, there's not an easy way to widen the E in ReaderTaskEither<E, L, A>. It seems like this is a natural thing to want to do, e.g.

db library exports a query function that is (sql: string) => ReaderTaskEither<{ db: DbConnection }, Error, Row[]>
logging library that exports a function like (msg: string) => ReaderTaskEither<{ log: LogService }, Error, string>

You might want to use these two functions in the same function and export a single merged reader environment. I think something like:
export const widen = <E, L, A, F extends E>(f: (a: A) => ReaderTaskEither<E, L, A>) => (a: A): ReaderTaskEither<F, L, A> => {
  return new ReaderTaskEither<F, L, A>(f(a).value)
}

Giving:
interface Environment {
  db: DbConnection;
  log: LogService;
}

const queryAndLog = () =>
  readerTaskEither
    .of<Environment, Error, object[]>([])
    .chain(widen(() => query('select * from customers')))
    .chain(widen((rows: object[]) => logInfo(`found ${rows.length} rows`).map(() => rows))) // have to annotate rows here to guide the inference

Is that something you would be interested having a PR for? Or is there a more elegant solution that I'm not seeing? (there normally is 😅 )

I'm using the following approach with overloadings:
function combine<E, P>(a: Reader<E, CT<P>>): Reader<E, [CT<P>]>;
function combine<E1, P1, E2, P2>(a: Reader<E1, CT<P1>>, b: Reader<E2, CT<P2>>): Reader<E1 & E2, [CT<P1>, CT<P2>]>;
function combine<E1, P1, E2, P2, E3, P3>(
	a: Reader<E1, CT<P1>>,
	b: Reader<E2, CT<P2>>,
	c: Reader<E3, CT<P3>>,
): Reader<E1 & E2 & E3, [CT<P1>, CT<P2>, CT<P3>]>;
function combine<E1, P1, E2, P2, E3, P3, E4, P4>(
	a: Reader<E1, CT<P1>>,
	b: Reader<E2, CT<P2>>,
	c: Reader<E3, CT<P3>>,
	d: Reader<E4, CT<P4>>,
): Reader<E1 & E2 & E3 & E4, [CT<P1>, CT<P2>, CT<P3>, CT<P4>]>;
function combine<E, P>(...readers: Reader<E, CT<P>>[]): Reader<E, CT<P>[]> {
	return asks((env: E) => readers.map(reader => reader.run(env)));
}

This allows you to compose different environments just using structural typing:
type AEnv = {
	a: string;
};
type BEnv = {
	b: number;
};
const a = asks((e: AEnv) => `A${a}`);
const b = asks((e: BEnv) => `B${b}`);
const ab: Reader<AEnv & BEnv, string> = combine(a, b).map(([a, b]) => `A&B: ${a} ${b}`);

I think this could be generalized for any ADT with a Reader interface.

I'm using the following approach with overloadings:
function combine<E, A>(a: Reader<E, A>): Reader<E, [A]>;
function combine<E1, A, E2, B>(a: Reader<E1, A>, b: Reader<E2, B>): Reader<E1 & E2, [A, B]>;
function combine<E1, A, E2, B, E3, C>(
	a: Reader<E1, A>,
	b: Reader<E2, B>,
	c: Reader<E3, C>,
): Reader<E1 & E2 & E3, [A, B, C]>;
function combine<E1, A, E2, B, E3, C, E4, D>(
	a: Reader<E1, A>,
	b: Reader<E2, B>,
	c: Reader<E3, C>,
	d: Reader<E4, D>,
): Reader<E1 & E2 & E3 & E4, [A, B, C, D]>;
function combine<E, P>(...readers: Reader<E, CT<P>>[]): Reader<E, CT<P>[]> {
	return asks((env: E) => readers.map(reader => reader.run(env)));
}

This allows you to compose different environments just using structural typing:
type AEnv = {
	a: string;
};
type BEnv = {
	b: number;
};
const a = asks((e: AEnv) => `A${e.a}`);
const b = asks((e: BEnv) => `B${e.b}`);
const ab = combine(a, b).map(([a, b]) => `A&B: ${a} ${b}`); //Reader<AEnv & BEnv, string>

I think this could be generalized for any ADT with a Reader interface.

Slightly related:
I've read quite a bit online that seems to suggest that the local function should be able to change the environment type, however fp-ts's implementation of local does not support this. Note that implementations of local that do support changing the environment type do not require the new environment type to be a super type of the current.
I guess what I'm saying is that while I agree that we should have a means to widen the environment type, we could also consider updating the local function to support arbitrary (making no assumptions about sub/super types) changing of the environment type.
Thoughts? Admittedly, this is probably a separate issue.

@tbrisbane Agree, I already have const mapE = <E, E2>(f: (e: E2) => E) => <A>(fa: Reader<E, A>): Reader<E2, A> => asks(e2 => fa.run(f(e2))); which is essentially local. I don't see any reasons to restrict the env type.

Between the new definitions of local and functions like mapE above I think this issue can be closed. 👍

authors: leemhenson raveclassic tbrisbane

repo: gcanti/fp-ts