text:
Check IP on DNSBL

Waiting on new patch from labo

Patch has been installed.
Feature has been added to the application.

repo: ghermans/globe


text:
Figure out how to configure variable tick times for different gadget

Should be a per gadget variable for all gadgets with a timed effect, a 1 minute default for each of them is probably okay.

Fixed in 6793c094527cecb5d2ff14aca934718e830b3e7d and 54a929f5a32183cad4f4b1909f8692e4e3bf956b

source: gharchive/issue

repo: gmlaxfanatic/Contraptions

license: mit

license_type: permissive

license_source: bigquery


text:
forms: type=number requires [pattern] on iOS

Whoops!
There were 58 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/fundamentals/design-and-ux/input/forms/index.md - No wf_blink_components field found in metadata. Add if appropriate.
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L19 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L25 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L31 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L37 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L39 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L58 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L75 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L132 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L142 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L151 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L161 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L180 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L189 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L207 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L224 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L242 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L245 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L247 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L251 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L255 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L257 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L270 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L273 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L296 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L319 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L322 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L328 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L330 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L459 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L482 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L486 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L488 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L523 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L527 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L531 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L535 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L543 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L607 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L626 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L630 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L634 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L638 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L642 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L658 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L661 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L670 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L673 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L691 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L695 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L699 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L703 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L707 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L711 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L723 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L726 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L729 - Line must be at most 100 characters
src/content/en/fundamentals/design-and-ux/input/forms/index.md#L732 - Line must be at most 100 characters

I'm just gonna double check this because the suggestion in this article is different to fillament group's suggestion.

https://jsbin.com/fijurozela < tests... works

source: gharchive/pull-request

authors: PaulKinlan WebFundBot paulirish

repo: google/WebFundamentals


text:
Fix a couple of sequencer issues

Any background on why returning entries in sequenced order is helpful?

Well, it seems like GetSequencedEntries() should really return them in sequence order, but the way I discovered that it wasn't doing that was that it caused NextAvailableSequenceNumber() to return something way too low (because it just checks the last entry in the returned list.)  I could've fixed it there too by making that O(N) and scanning.

LGTM

authors: AlCutter pphaneuf

repo: google/certificate-transparency


text:
refactor: remove eslint and prettier

Codecov Report

Merging #75 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   97.16%   97.16%
=======================================
  Files           8        8
  Lines        1479     1479
  Branches       68       68
=======================================
  Hits         1437     1437
  Misses         30       30
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22f4029...59b9d89. Read the comment docs.

authors: JustinBeckwith codecov-io

repo: googleapis/nodejs-common-grpc


text:
Local fix

ok

repo: gothinkster/flask-realworld-example-app

license: MIT

license_source: github-api


text:
xFilesFactor is an optional parameter for removeEmptySeries

Codecov Report

Merging #2495 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2495   +/-   ##
=======================================
  Coverage   80.01%   80.01%
=======================================
  Files          85       85
  Lines        9131     9131
  Branches     1948     1948
=======================================
  Hits         7306     7306
  Misses       1544     1544
  Partials      281      281

Impacted Files
Coverage Δ

webapp/graphite/render/functions.py
96.26% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4941cc...c1c5f8d. Read the comment docs.

authors: DanCech codecov-io

repo: graphite-project/graphite-web


text:
feat(asCol): add asCol HOC

:tada: This PR is included in version 16.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: arahansen obartra

repo: gymnastjs/gymnast


text:
fix (auth): Correcting path of folder with the settings

thx

authors: Fumesover pirate

repo: hackmdio/codimd-cli


text:
Implement upload progress monitoring for URLSession

Removing URLSession driver for now. There's no resource to maintain.

authors: anieduard magyarosibotond

repo: halcyonmobile/RestBird


text:
document new captain.yml format

done

repo: harbur/captain


text:
Best block height shown in status

I ACK this pull request but I wanted to clarify the behaviour here for posterity. The reported block hash and block height here is an approximation. The node (the STM code) doesn't really know at what height the wallet really is. It can guess those values when the wallet requests a block download from a given block hash for example. If we wanted to report the correct value (block hash and height with respect to the wallet) we would have to look in the wallet database and report the values there directly. But haskoin-node doesn't have access to the wallet database.

authors: plaprade xenog

repo: haskoin/haskoin

license: unlicense


text:
Add missing gdscript listing in modules.org

Sorry, wasn't too sure if I should make the pull request directly to master. But now that I think about it, I probably should've :x

Thanks!

authors: hlissner zackteo

repo: hlissner/doom-emacs


text:
CDSR-152: corrected Your claim submission failed page

Working on test cases

repo: hmrc/cds-reimbursement-claim-frontend


text:
Depths for braids not calculated correctly

This is hopefully fixed now. The new way to calculate depths appears to make sense and works on the examples that I have tried.

repo: homotopy-io/homotopy-rs


text:
Ich möchte Architekturänderungen vornehmen, damit auch der nächste Jahrgang noch mit dem Tool arbeiten kann.

@jcremerius Nächster Jahrgang dankt 👍

repo: hpi-swa-teaching/ChangesBrowser


text:
Fix UserInfo with plus sign (#2713)

@rossabaker Thanks for the guidance, I wasn't entirely sure which way to fix it...


text:
How to change calendar's language to English?

look at this package solar
All of the ui base your draw with canvas.

Thanks. Now i want to swipe down to expand calendar to Full screen style. How to do (or where to modify) it?

in this package，download demo
so easy to using.

Hello,where is the action " Swipe up: shrink calendar, hide monthview and show weekview, and Swipe down: expand calendar, show monthview and hide weekview" in your code? I want to modify it.

If you just want to use a system-style calendar, just use CalendarView. If you want to use the WeekView, use CalendarLayout in the outer layer of CalendarView, which controls the switching of the CalendarView.

sorry my english not well, so i can't explain the detail.
please watch this video. you'll undersand what i want to do.
https://drive.google.com/file/d/14mcIAhkwzt-hbI1IDvGee8GtBdQO-bqX/view

I understand, and this is also a good feature. You want to switch to full_style when you slide down again when the MonthView is fully expanded? I am trying to add this feature to the next version.

Hello, how to change Calendar SchemeDate's height?

Hello,  how to move from day to day of the week.
Is there a function for this?
something like this but for day
mCalendarView.scrollToNext();

repo: huanghaibin-dev/CalendarView


text:
Create clatest

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant hudl-cla

repo: hudl/numba-munkres


text:
Cleanup

LGTM

authors: gao-feng laijs

repo: hyperhq/hyperstart


text:
Feature/rc 1 16 0

@WadeBarnes @ianco I finally looked at the problem with DCO of commits in master and rc branches and other related stuff like merge problems.
Here is my understanding of some facts, please check if you find it correct:

There was a commit with broken DCO https://github.com/hyperledger/indy-sdk/commit/f84e91f6ef618398f7a593499ea30e83b246ddb6
It was merged to master in #2285 by setting this check to pass manually
The copy of this commit and probably more alternative history now in rc branch. https://github.com/hyperledger/indy-sdk/commit/0bf0748d08ad295044c1d1c916b453ce86dc6bb0
and it was merged in #2289 to RC

As a result of 1-3 we have a divergence of history in rc and master.
My thoughts/suggestions

I think we should keep rc and master branches in the state which will allow us to do merges in both directions
As far as I know we should have all commits in every history branch to do 1st point without the overhead and problems like Ian saw while trying to apply iOS fixes in #2302 pr #2303
One way is to force-push one of the alternative histories and override rc or master or both
Another option is to just merge the original master history with broken DCO to rc. So it's the current PR. (DCO is set to pass manually again here)

Summary
I don't know other principal ways to sync branches in addition to 3rd or 4th options in the list above. Between 2 of them in a personal repo I would strongly prefer to follow the override option. But in our case (public repo) overriding history may confuse a lot of contributors so the 4th one seems more reasonable.

Hi @jovfer, thanks for looking into this!
Just one correction - when I PR'ed the "bad" commit into the rc branch I fixed the DCO problem.  However I didn't/don't have the permissions to fix the commit in the master branch (and I'm a bit nervous to start messing around with the commit history in master).  Right now rc has the same updates as in master (as in the same set of file changes) - I've cherry-picked commits to bring the rc branch up-to-date, but making sure all the commits have properly signed off DCO.
I agree that option 4 is the most straightforward approach, as this keeps all the commits the same in both branches, and simplifies merges that we will need to do in the future.  However it leaves the "bad" commit in place without a proper DCO signoff, and will require a manual override every time we need to merge branches.
If we are going to go with option 3 (would force everyone to update their fork but long-term would solve the DCO problem) then the sooner the better, the more development that happens the deeper the DCO problem becomes.
@ryjones @WadeBarnes

@ianco I'd like to double-check if we are on the same page

and will require a manual override every time we need to merge branches.

do you mean merges of these branches to some others and overriding the DCO check?

@jovfer  yes that's what I meant, overriding the DCO check.

@jovfer, @ianco,  My take on this is we need to amend the offending commit in master.  That will require amending the commit and rebasing the remainder of the commits on top of that, which will require a force push due to the resulting change in history.  The sooner we do this the better.  This would need to be done in co-ordination with an admin on the repo as some branch protection settings would need to be temporarily disabled.
The unfortunate consequence is this will mess with developer history and require developers to resync with the new state of master.  We can decide what to do with the rc branch once the state of mater has been repaired.
If we don't do this the offending commit will constantly and continually be an issue moving forward.
cc @ryjones

@ryjones could you approve re-writing history of the master branch and give me enough permissions to do so?

@ryjones could you approve re-writing history of the master branch and give me enough permissions to do so?

With great power, etc.

Closed as the master was fixed in #2313

authors: WadeBarnes ianco jovfer ryjones

repo: hyperledger/indy-sdk


text:
IS46-CLUSTER-SETUP Copy the docker.service file to the correct path

LGTM

authors: firecyberice mjgorman

repo: hypriot/cluster-lab


text:
匯出漢字照口語調斷詞語料

Coverage decreased (-8.2%) to 74.519% when pulling 36f26c11f91ccf6c9b0a67531e14a342bffb08a9 on 匯出漢字照口語調斷詞語料 into c096d456036b4f691831e8ff0a43fdc1ee2af251 on master.


text:
Error message specific to no logs to send

Coverage decreased (-0.2%) to 82.568% when pulling 046d931d5d908caa630b2474d64e231defb84fbc on mohlogan-patch-2 into 9416ad5dc29f3e73f613e24319125642109ddd94 on development.

Coverage decreased (-0.2%) to 82.568% when pulling da4a18079de043861f3d65e538e0dbafa15ae2d0 on mohlogan-patch-2 into 9416ad5dc29f3e73f613e24319125642109ddd94 on development.

Coverage increased (+0.8%) to 83.51% when pulling b28aecd123c286ea7c9a898ad22195a95d6cc142 on mohlogan-patch-2 into 9416ad5dc29f3e73f613e24319125642109ddd94 on development.

authors: coveralls mohlogan


text:
feature/age-detection

I fixed the ROI issue just transforming the list into an String... That maybe not very good to other languages to understand. I now there are things on python to work it around, but it will be probably be best to find another way to serialize it!!

repo: igormcsouza/online-age-detection


text:
Use buffer directly

Yeah, slightly faster.
// bench.js
'use strict';

const fs = require('fs');
const Bluebird = require('bluebird');
const imageminMozjpeg = require(process.argv[2]);

const LABEL = process.argv[3];
const image = fs.readFileSync('fixture.jpg');
console.time(LABEL);

Bluebird.reduce(new Array(100).fill(image), (_, buf) => imageminMozjpeg()(buf).then(() => 0))
.then(() => console.timeEnd(LABEL));

./fixture.jpg
$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.11.5
BuildVersion:	15F34

$ node --version
v6.3.0

$ npm --version
3.10.5

$ node bench imagemin-mozjpeg v6.0.0
v6.0.0: 2606.592ms

$ node bench ./buffer-directly.js buffer-directly
buffer-directly: 2535.597ms

Sorry I just reverted this change in https://github.com/imagemin/imagemin-mozjpeg/pull/17, because images can be more than 10 MB and execa throws max buffer exceeded error in that case.
Though we can expose maxBuffer option for this plugin, we should not force end users to care about it. Also performance improvement is not so large.

v6.0.0: 2606.592ms
buffer-directly: 2535.597ms

repo: imagemin/imagemin-mozjpeg


text:
docs: fix video player scrolling on chrome

Nice catch, thanks!

:tada: This PR is included in version 5.3.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: aleclarson mweststrate rchod

repo: immerjs/immer


text:
removed JMS stuff

From the german version as well please.

done, but via editor on github ;-)

Ah, ok. :smile:

not so nice, but it works

authors: OskarStark sagikazarmark

repo: indigophp/sonata-admin-print-bundle


text:
bump query parser

Also, can you change the commit message to be setup: bump inspire... and add the JIRA task in the message as well?
This is typically the format we use for commit messages:
{area changed} : {description of the change}

{JIRA TASK}
{any needed operations like migrating, reindexing etc.}
{extra info}

authors: MJedr monaawi

repo: inspirehep/inspirehep


text:
Speed up reference loading.

Changes of note:

use ujson to parse, if it is installed. Actually, that's not even necessarily the fastest, but it seems very common
option "simple templates" which, if True, uses replace instead of jinja
LRU cache for the templating (is simple_templates is False)
quicker exit from building the directory cache

One obvious thing not implemented here is to have the directory listing be lazy, rather than computed up front. That will become more important when the size of the reference set itself becomes significant.

Folded into #640


text:
Upgrade OPAE to v1.4.0-1

@hectoragb test failure seems to be caused by CI issue:
[Pipeline] withDockerRegistry

$ docker login -u k8s-bot -p ******** https://cloud-native-image-registry.westus.cloudapp.azure.com/

WARNING! Using --password via the CLI is insecure. Use --password-stdin.

Error response from daemon: Get https://cloud-native-image-registry.westus.cloudapp.azure.com/v2/: x509: certificate has expired or is not yet valid

[Pipeline] // withDockerRegistry

Error when executing success post condition:

hudson.AbortException: docker login failed

	at org.jenkinsci.plugins.docker.commons.impl.RegistryKeyMaterialFactory.materialize(RegistryKeyMaterialFactory.java:102)

	at org.jenkinsci.plugins.docker.workflow.AbstractEndpointStepExecution2.doStart(AbstractEndpointStepExecution2.java:53)

	at org.jenkinsci.plugins.workflow.steps.GeneralNonBlockingStepExecution.lambda$run$0(GeneralNonBlockingStepExecution.java:77)

	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)

	at java.util.concurrent.FutureTask.run(FutureTask.java:266)

	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)

	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)

	at java.lang.Thread.run(Thread.java:748)

Please fix ASAP. Thanks.

Please fix ASAP. Thanks.

It should be fixed. Did you re-push today?

@mythi  no, I didn't know it's fixed. will do. Thanks for pointing this out to me.


text:
Added citation

Can one of the admins verify this patch?

I have read the CLA Document and I hereby sign the CLA

recheck

@sarthakpati I removed azure-pipelines.yaml since this is not related to citation part(so, I believe we need further discussion on that) and after that it can be merged via separate PR.

repo: intel/openfl


text:
Translations (FR / EN)

@SBriere, Should add translations to nodejs process. Tools and buttons are hard coded to french at the moment.

@SBriere, Should add translations to nodejs process. Tools and buttons are hard coded to french at the moment.

authors: SBriere doumdi

repo: introlab/opentera


text:
Cargo.lock: bump dependencies

Codecov Report

Merging #197 (d684258) into develop (6447348) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #197      +/-   ##
===========================================
- Coverage    58.41%   58.36%   -0.06%
===========================================
  Files           31       31
  Lines         1426     1429       +3
===========================================
+ Hits           833      834       +1
- Misses         593      595       +2

Impacted Files
Coverage Δ

rust/src/derive_helpers.rs
61.29% <0.00%> (-4.23%)
:arrow_down:

rust/src/decoder/sequence/state.rs
64.10% <0.00%> (-1.69%)
:arrow_down:

rust/src/decoder/sequence/decoder.rs
63.38% <0.00%> (+1.40%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6447348...d684258. Read the comment docs.

authors: codecov-io tony-iqlusion

repo: iqlusioninc/veriform


text:
Feature/231 deep resolve

ack

authors: jukart lumannnn

repo: iris-dni/iris-service


text:
Bump version to 1.2.0 (tentative next)

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

authors: istio-testing ldemailly

repo: istio/fortio


text:
Translate help/ops/traffic-management into Chinese

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rootsongjc
If they are not already assigned, you can assign the PR to them by writing /assign @rootsongjc in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content_zh/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @DavadDi. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/approve
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fleeto
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content_zh/OWNERS [fleeto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

authors: DavadDi fleeto istio-testing


text:
small improvements

changes are in #562

Jenkins job istio.github.io/presubmit passed

authors: frankbu istio-testing ldemailly


text:
Update WORKSPACE

Jenkins job manager/presubmit passed

authors: istio-testing kyessenov

repo: istio/manager


text:
Update ignition-math5.rb

build bottle

Build finished. No test results found.

build bottle

build bottle

build bottle

build bottle

build bottle

build bottle

build bottle

authors: j-rivero osrf-jenkins

repo: j-rivero/homebrew-simulation


text:
fixed a small readme typo illustrating the authorization point implementation

Changes Unknown when pulling 027d956dd3c3e34887696f021be9b26ac78910a4 on IrfanBaqui:readme-typo-fix into ** on jaredhanson:master**.

authors: IrfanBaqui coveralls


text:
add template for SLES 11 SP4

works for me with puppet 🆗

authors: mmoll xalopp


text:
correction on a variable name

Jenkins » email-ext-plugin #22 SUCCESS
This pull request looks good
(what's this?)

Jenkins » email-ext-plugin #23 SUCCESS
This pull request looks good
(what's this?)

authors: CedricLevasseur buildhive

repo: jenkinsci/email-ext-plugin


text:
Ubuntu 软件相关

ibus-rime
更改ubuntu下ibus-rime的字号、字体、皮肤颜色
需要 gnome-tweak-tool， gnome主题（可以在https://www.gnome-look.org 下载并按照步骤安装）
修改主题的 gnome-shell.css 文件
修改字号
打开gnome-shell.css 文件，搜索 .candidate-popup-content 字段（如果没有就新建一个）：
.candidate-popup-content {
       /* 设置字体 */
	font-family: "Microsoft YaHei UI", serif,cantarell,sans-serif;
       /* 设置号 */
	font-size: 15px;
}

.candidate-box {
       /* 设置字体 */
	font-family: "Microsoft YaHei UI", serif,cantarell,sans-serif;
       /* 设置号 */
	font-size: 15px;
}

修改后打开gnome-tweak-tool的appearance中shell theme，重新应用这个theme，查看变化，如果shell theme不可选择，则在extensions中打开 user themes即可。
修改颜色
.candidate-popup-boxpointer {
  -arrow-border-radius: 1px;
  -arrow-background-color: #d4d4d4;
  -arrow-border-width: 5px;/*输入法边框*/
  -arrow-border-color: #d4d4d4;
  /*-arrow-border-color: transparent;*/
  -arrow-base: 0;
  -arrow-rise: 0;
  -arrow-box-shadow: none;
  margin: 0.3em 0.8em;
  background-color: #ffffff;
  box-shadow: 0 2px 4px 0 rgba(0, 0, 0, 0.4);
  border-radius: 1px; }

...中间代码省略

.candidate-popup-content {
  padding: 0.4em;
  spacing: 0.1em;/*拼音和汉字的间距*/
  font-family: "WenQuanYi Micro Hei", serif,cantarell,sans-serif;
  font-size: 16pt;
  background-color: #eeeeec;
  color: #000000;}

.candidate-box {
  font-family: "WenQuanYi Micro Hei", serif,cantarell,sans-serif;
  font-size: 16pt;
  padding: 0.3em 0.5em 0.3em 0.5em;
  border-radius: 1px;}
  .candidate-box:selected, .candidate-box:hover {
    background-color: #0a3afa;
    color: #ffffff; }

对颜色修改，然后应用
修改后的样式如下，选中的标号颜色还不太好


text:
Updated README

Add BG96-driver & update README


text:
Fixed JFXRadioButton with graphics

@rufio1987 before merging with master can you explain the issue?

There were 2 problems:
1 - A JFXRadioButton with graphics had the class list "getChildren().get(i).getStyleClass()" empty, so it would throw an arrayoutofboundsException. (lines 233/239)
2 - The JFXRadioButton with no text (but only graphic) threw another exception because the getChildren().get(1) had no textProperty (lines 212/217)

Thanks @rufio1987 for pointing out the issue 👍 , I'd rather fix it a bit different though.
Regards,

repo: jfoenixadmin/JFoenix


text:
Switch cache_path to pull from R package, similar to OsteoSort and QA3D

Finished


text:
Update test values to reflect CODATA update in astropy

closes #21

repo: joergdietrich/NFW


text:
Js breakout

In testing as latest but shows to be working


text:
move the tags on the left on the aws detail template

done

repo: jparicka/cloudly


text:
add on tsdb installation instructions

done


text:
Update EDA.Rmd

Thanks!

authors: dongzhuoer jrnold


text:
Add and fix typescript types for recursive

please add a  test usage in typescript tests

I have moved on to other things since this was created. Sorry.

authors: ollef phadej

repo: jsverify/jsverify


text:
Mb misc

Codecov Report

Merging #68 (c730d71) into master (04a8160) will decrease coverage by 7.03%.
The diff coverage is 74.07%.

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   98.39%   91.35%   -7.04%
==========================================
  Files          40       40
  Lines        2237     2243       +6
==========================================
- Hits         2201     2049     -152
- Misses         36      194     +158

Flag
Coverage Δ

integration
?

unit
91.35% <74.07%> (-0.12%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

authors: codecov-commenter jtpavlock

repo: jtpavlock/Moe


text:
✨ XML cards and link-details converted to JS objects!

Closes #22

repo: karimeij/iCOV-interactive-concernschema


text:
Update code example

Thanks!

authors: kean vox-humana

repo: kean/Pulse


text:
澳门首家线上赌场上线了，性感荷官在线发牌！

李时珍的皮

害我撸了

nishibushi sha

我为什么点了进来？

找到 浏览器 w w w点TL 238816点c om   真实的现场，
美女值播 发牌

authors: CxDtreeg ScarlettRay cowkeys cyleonebk q906624488 sunmaoxiang

repo: kelseyhightower/nocode


text:
git clone generates code in .git directory

This might be a bug with Git?

authors: nathan-osman petermbenjamin


text:
grid activity form

#70

do move on, will review as soon as i get a chance :)


text:
为什么X 轴 Y轴坐标对不齐

原始代码又问题，yAxisOffset他写死成10了

那应该改成多少呢？

authors: RiberWang edison0951 pengwanwan

repo: kevinzhow/PNChart


text:
add NoCreate to GetMatadata args

:no_entry: Error rendering the commits b330f02a7daa...cd35d31deafd on linux. :mag_right: 25 errored, 7 new, 132 changed

Error in cd35d31deafd: Chat_No_Conversation-normal-ERROR

Error in cd35d31deafd: Chat_Inbox-Normal-ERROR

Error in b330f02a7daa: Devices_Devices_List-Devices-ERROR

Error in cd35d31deafd: Devices_Devices_List-Devices-ERROR

Error in b330f02a7daa: Chat_Participant_Rekey-Normal-ERROR

Error in b330f02a7daa: Chat_Input-Normal-ERROR

Error in cd35d31deafd: Chat_Input-Normal-ERROR

Error in b330f02a7daa: Chat_Inbox-You_Rekey_Selected-ERROR (view)
Error in cd35d31deafd: Chat_Inbox-You_Rekey_Selected-ERROR (view)
Error in b330f02a7daa: Chat_Inbox-You_Rekey-ERROR (view)
Error in cd35d31deafd: Chat_Inbox-You_Rekey-ERROR (view)
Error in b330f02a7daa: Chat_Inbox-Selected_Normal-ERROR (view)
Error in cd35d31deafd: Chat_Inbox-Selected_Normal-ERROR (view)
Error in b330f02a7daa: Chat_Inbox-Selected_Muted-ERROR (view)
Error in cd35d31deafd: Chat_Inbox-Selected_Muted-ERROR (view)
Error in b330f02a7daa: Chat_Inbox-Part_Rekey_Selected-ERROR (view)
Error in cd35d31deafd: Chat_Inbox-Part_Rekey_Selected-ERROR (view)
Error in b330f02a7daa: Chat_Inbox-Part_Rekey-ERROR (view)
Error in cd35d31deafd: Chat_Inbox-Part_Rekey-ERROR (view)
Error in b330f02a7daa: Chat_Inbox-Long_Top-ERROR (view)
Error in cd35d31deafd: Chat_Inbox-Long_Top-ERROR (view)
Error in b330f02a7daa: Chat_Inbox-Long_Bottom-ERROR (view)
Error in cd35d31deafd: Chat_Inbox-Long_Bottom-ERROR (view)
Error in b330f02a7daa: Chat_Inbox-Empty-ERROR (view)
Error in cd35d31deafd: Chat_Inbox-Empty-ERROR (view)
Added: Chat_Participant_Rekey-Normal (view)
Added: Chat_Banner_Invite-Invite (view)
Added: Chat_Banner_Info-Info (view)
Added: Chat_Banner_Error-Error (view)
Added: Chat_Banner_Broken-Broken_Tracker_3 (view)
Added: Chat_Banner_Broken-Broken_Tracker_2 (view)
Added: Chat_Banner_Broken-Broken_Tracker_1 (view)
Changed: You_Rekey-Normal (before) (after) (diff)
Changed: Text-Terminal_Terminal (before) (after) (diff)
Changed: Text-Terminal_Success (before) (after) (diff)
Changed: Text-Terminal_Inline_Terminal (before) (after) (diff)
Changed: Text-Terminal_Inline_Documentation (before) (after) (diff)
Changed: Text-Terminal_Empty_Information (before) (after) (diff)
Changed: Text-Terminal_Empty_Documentation (before) (after) (diff)
Changed: Text-Terminal_Empty_Announcements (before) (after) (diff)
Changed: Text-Terminal_Comment_Information (before) (after) (diff)
Changed: Text-Header_Terminal (before) (after) (diff)
Changed: Text-Header_Success (before) (after) (diff)
Changed: Text-Header_Link_Terminal (before) (after) (diff)
Changed: Text-Header_Link_Documentation (before) (after) (diff)
Changed: Text-Header_Big_Terminal (before) (after) (diff)
Changed: Text-Header_Big_Success (before) (after) (diff)
Changed: Text-Header_Big_High_Risk (before) (after) (diff)
Changed: Text-Body_Wrap_Normal (before) (after) (diff)
Changed: Text-Body_Wrap_Information (before) (after) (diff)
Changed: Text-Body_Wrap_Announcements (before) (after) (diff)
Changed: Text-Body_Success_Terminal (before) (after) (diff)
Changed: Text-Body_Success_Success (before) (after) (diff)
Changed: Text-Body_Success_High_Risk (before) (after) (diff)
Changed: Text-Body_Small_Terminal (before) (after) (diff)
Changed: Text-Body_Small_Success_Normal (before) (after) (diff)
Changed: Text-Body_Small_Success_Announcements (before) (after) (diff)
Changed: Text-Body_Small_Success (before) (after) (diff)
Changed: Text-Body_Small_Semibold_Terminal (before) (after) (diff)
Changed: Text-Body_Small_Semibold_Italic_Information (before) (after) (diff)
Changed: Text-Body_Small_Semibold_Italic_Documentation (before) (after) (diff)
Changed: Text-Body_Small_Semibold_Inline_Link_Terminal (before) (after) (diff)
Changed: Text-Body_Small_Semibold_Inline_Link_Success (before) (after) (diff)
Changed: Text-Body_Small_Semibold_Inline_Link_High_Risk (before) (after) (diff)
Changed: Text-Body_Small_Semibold_Documentation (before) (after) (diff)
Changed: Text-Body_Small_Secondary_Link_Normal (before) (after) (diff)
Changed: Text-Body_Small_Secondary_Link_Information (before) (after) (diff)
Changed: Text-Body_Small_Secondary_Link_Documentation (before) (after) (diff)
Changed: Text-Body_Small_Secondary_Link_Announcements (before) (after) (diff)
Changed: Text-Body_Small_Primary_Link_Information (before) (after) (diff)
Changed: Text-Body_Small_Primary_Link_Documentation (before) (after) (diff)
Changed: Text-Body_Small_Primary_Link_Announcements (before) (after) (diff)
Changed: Text-Body_Small_Italic_Success (before) (after) (diff)
Changed: Text-Body_Small_Italic_High_Risk (before) (after) (diff)
Changed: Text-Body_Small_Inline_Link_Terminal (before) (after) (diff)
Changed: Text-Body_Small_Inline_Link_Success (before) (after) (diff)
Changed: Text-Body_Small_Inline_Link_High_Risk (before) (after) (diff)
Changed: Text-Body_Small_Error_Normal (before) (after) (diff)
Changed: Text-Body_Small_Error_Information (before) (after) (diff)
Changed: Text-Body_Small_Error_Announcements (before) (after) (diff)
Changed: Text-Body_Semibold_Normal (before) (after) (diff)
Changed: Text-Body_Semibold_Link_Normal (before) (after) (diff)
Changed: Text-Body_Semibold_Link_Announcements (before) (after) (diff)
Changed: Text-Body_Semibold_Italic_Normal (before) (after) (diff)
Changed: Text-Body_Semibold_Italic_High_Risk (before) (after) (diff)
Changed: Text-Body_Semibold_Information (before) (after) (diff)
Changed: Text-Body_Semibold_Announcements (before) (after) (diff)
Changed: Text-Body_Secondary_Link_Success (before) (after) (diff)
Changed: Text-Body_Secondary_Link_High_Risk (before) (after) (diff)
Changed: Text-Body_Primary_Link_Normal (before) (after) (diff)
Changed: Text-Body_Primary_Link_High_Risk (before) (after) (diff)
Changed: Text-Body_Normal (before) (after) (diff)
Changed: Text-Body_Information (before) (after) (diff)
Changed: Text-Body_Error_Terminal (before) (after) (diff)
Changed: Text-Body_Error_Success (before) (after) (diff)
Changed: Text-Body_Error_High_Risk (before) (after) (diff)
Changed: Text-Body_Documentation (before) (after) (diff)
Changed: Text-Body_Big_Link_Information (before) (after) (diff)
Changed: Text-Body_Big_Link_Documentation (before) (after) (diff)
Changed: Text-Body_Big_Link_Announcements (before) (after) (diff)
Changed: Text-Body_Big_Information (before) (after) (diff)
Changed: Text-Body_Big_Documentation (before) (after) (diff)
Changed: Text-Body_Announcements (before) (after) (diff)
Changed: Standard_Screen-Success_w_Custom_Notification_Element (before) (after) (diff)
Changed: Standard_Screen-Error_w_Back_Button (before) (after) (diff)
Changed: Standard_Screen-Error (before) (after) (diff)
Changed: Standard_Screen-Back_Button (before) (after) (diff)
Changed: Popup_Dialog-Normal (before) (after) (diff)
Changed: Markdown-Quotes (before) (after) (diff)
Changed: Markdown-Code_block (before) (after) (diff)
Changed: Markdown-Blank_lines (before) (after) (diff)
Changed: List_Item-Small_list_item_with_text_action (before) (after) (diff)
Changed: List_Item-Small_list_item_with_icon_desktop_only (before) (after) (diff)
Changed: List_Item-Small_list_item_with_button_action (before) (after) (diff)
Changed: List_Item-Small_list_item_with_avatar_40_mobile_only (before) (after) (diff)
Changed: Input-Password_visible_filled (before) (after) (diff)
Changed: Input-Password_filled (before) (after) (diff)
Changed: Input-Multiline_error (before) (after) (diff)
Changed: Input-Multi_Label_Styled (before) (after) (diff)
Changed: Input-Long_Multiline_rows_Max_1 (before) (after) (diff)
Changed: Input-Long_Multiline (before) (after) (diff)
Changed: Input-Hint_Multiline_Empty (before) (after) (diff)
Changed: Input-Floating_Label_Multiline_Filled_Long (before) (after) (diff)
Changed: Input-Floating_Label_Multiline_Filled (before) (after) (diff)
Changed: Input-Floating_Label_Multiline_Empty (before) (after) (diff)
Changed: Input-Default_Filled (before) (after) (diff)
Changed: Input-Default_Empty (before) (after) (diff)
Changed: Input-Auto_cap_sentences (before) (after) (diff)
Changed: Input-Auto_cap_none (before) (after) (diff)
Changed: Icon-Icon_Icon_Font (before) (after) (diff)
Changed: Colors-white_ffffff (before) (after) (diff)
Changed: Colors-white_40_rgba_255_255_255_0_40 (before) (after) (diff)
Changed: Colors-white_20_rgba_255_255_255_0_20 (before) (after) (diff)
Changed: Colors-white_0_rgba_255_255_255_0 (before) (after) (diff)
Changed: Colors-grey_cccccc (before) (after) (diff)
Changed: Colors-green_3_E_8_FAF_3 (before) (after) (diff)
Changed: Colors-green_2_36_b_37_c (before) (after) (diff)
Changed: Colors-blue_5_F_8_FAFD (before) (after) (diff)
Changed: Colors-blue_4_ebf_5_fc (before) (after) (diff)
Changed: Colors-blue_3_60_rgba_168_215_255_0_6 (before) (after) (diff)
Changed: Colors-black_10_rgba_0_0_0_0_10 (before) (after) (diff)
Changed: Colors-black_05_rgba_0_0_0_0_05 (before) (after) (diff)
Changed: Colors-black_000000 (before) (after) (diff)
Changed: Buttons-Secondary_waiting (before) (after) (diff)
Changed: Buttons-Secondary_small_waiting (before) (after) (diff)
Changed: Buttons-Secondary_full_Width_waiting (before) (after) (diff)
Changed: Buttons-Secondary_full_Width (before) (after) (diff)
Changed: Buttons-Secondary_disabled (before) (after) (diff)
Changed: Buttons-Follow_small_waiting (before) (after) (diff)
Changed: Buttons-Danger_small_waiting (before) (after) (diff)
Changed: Buttons-Danger_full_Width (before) (after) (diff)
Changed: Buttons-Danger (before) (after) (diff)
Changed: Avatar-Normal_x_40 (before) (after) (diff)
Changed: Avatar-Normal_x_32 (before) (after) (diff)
Changed: Avatar-Normal_x_24 (before) (after) (diff)
Changed: Avatar-Mutual_Follow_x_80 (before) (after) (diff)
Changed: Avatar-Mutual_Follow_x_64 (before) (after) (diff)
Changed: Avatar-Mutual_Follow_x_48 (before) (after) (diff)
Changed: Avatar-Follows_You_x_80 (before) (after) (diff)
Changed: Avatar-Follows_You_x_176 (before) (after) (diff)
Changed: Avatar-Follows_You_x_112 (before) (after) (diff)
Changed: Avatar-Following_x_176 (before) (after) (diff)
Changed: Avatar-Fallback_x_24 (before) (after) (diff)
Changed: Avatar-Fallback_x_16 (before) (after) (diff)

authors: keybase-ci-visdiff songgao

repo: keybase/client


text:
gitattributes + minimize jbossNexus addition + use optaplanner-build-parent for multiproject

Need to rerun again tomorrow, when the new SNAPSHOTs are built. Until then, this will be red.

Rerunning

repo: kiegroup/optaplanner-quickstarts


text:
MMB: update menu design to be Android compatible

Will this work for groups with one child?

I think this bug is not fixed yet - this just updates the design to the Android-friendly:

Ok, will you please make a task for it, so I can keep track of it?

authors: mrtnzlml tbergq

repo: kiwicom/mobile


text:
fix default value of query paramter

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@cca229b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #18   +/-   ##
=========================================
  Coverage          ?   92.30%
=========================================
  Files             ?        2
  Lines             ?      260
  Branches          ?        0
=========================================
  Hits              ?      240
  Misses            ?       20
  Partials          ?        0

Flag
Coverage Δ

#unittests
92.30% <0.00%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca229b...d7e4a7c. Read the comment docs.

authors: codecov-commenter koxudaxi

repo: koxudaxi/fastapi-code-generator


text:
chore(release): 26.5.6

Pull Request Test Coverage Report for Build 813533417

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.936%

Totals

Change from base Build 813511041:
0.0%

Covered Lines:
1004

Relevant Lines:
1034

💛  - Coveralls

authors: ahnpnl coveralls

repo: kulshekhar/ts-jest


text:
User can favorite a post.

[ ] add a heart or something below each tweet
[ ] make a favorites button in the nav bar

repo: laduke/twitter


text:
[5.2] make:event command no longer overwrites existing events

I don't think this will work for core events. What if the $rawName is Illuminate\Database\Events\BeganTransaction because that's what I have in my $listen property on my EventServiceProvider?

This is the make:event          Create a new event class command, not the event:generate one.

Will this be replaced with another fix?

Sure, feel free to send over another PR if you can. I need an example also
of how I can recreate the bug.
On Wed, Jan 13, 2016 at 9:09 AM, Arthur Kirkosa notifications@github.com
wrote:

Will this be replaced with another fix?
—
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/pull/11797#issuecomment-171323733.

Example:
php artisan make:event SomeEvent

// modify the class

php artisan make:event SomeEvent

// see the class overwriten

authors: arthurkirkosa taylorotwell

repo: laravel/framework


text:
Testing

Description?

authors: tillkruss umair-gujjar


text:
[5.1] Deprecated push queues

Push queues are not all of IronMQ, just the marshal, subscribe stuff and related logic.

IronMQ only supports push queues though?

Oh right. My bad. :)

What's the reason for depreciating them, by the way?

I think Push Queues made more sense when queues where quite new to the PHP
scene and it was meant as a introduction to queues without being too
intimidating. Now that people are more accustomed to queues in general and
we have easy ways to set them up (Forge, etc.), I think it makes sense to
remove this special feature.
On Wed, Jun 3, 2015 at 1:07 PM, Franz Liedke notifications@github.com
wrote:

What's the reason for depreciating them, by the way?
—
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/pull/9038#issuecomment-108551166.

Cool, thanks for explaining!

so @taylorotwell, is your recommendation then to use the database queue setting and configure Supervisor (via forge or directly) so that jobs are queued and run asynchronously without going through a 3rd party?

That would be my recommendation, yes.
On Sun, Oct 18, 2015 at 2:56 AM, Bobby Springston
notifications@github.com wrote:

so @taylorotwell, is your recommendation then to use the database queue setting and configure Supervisor (via forge or directly) so that jobs are queued and run asynchronously without going through a 3rd party?
Reply to this email directly or view it on GitHub:
https://github.com/laravel/framework/pull/9038#issuecomment-148987676

authors: GrahamCampbell bspringston franzliedke taylorotwell


text:
Better effects for search input

Really appreciate this and it's a good idea, but this is about to be dropped for a new bar entirely. So I'm going to reject this.
Also, we try very hard to avoid !important, and it should really never be necessary.

authors: Plasmmer kauffj

repo: lbryio/lbry-app


text:
Add stream and blob availability commands

Note that this doesn't redirect calls to the deprecated get_availability to the new stream_availability, I'll add that

repo: lbryio/lbry


text:
4.4-8.0, 其他android版本可用吗?

还没有测试过。在模拟器中可能可以，在真机中大概率不行。

9.0的真机可以不

4.4也不行

华为荣耀 android8.0不行

ioctl分支真机不行，adb shell am force-stop 执行后进程被杀死，并没有重新启动

repo: lcodecorex/KeepAlive


text:
BugFix So Post, Put and Delete Requests work

I don't know why but without this line the Requests didn't work on my machine

repo: leanix/leanix-sdk-csharp


text:
Enso drafting

Cancel and recreate PR


text:
remove errant parenthesis in README

I kind of liked it being there. So long!

authors: levlaz ndintenfass

repo: levlaz/braindump


text:
BlobStore changes to support dynamic Read-Write/Read-Only change (#771)

Codecov Report

Merging #779 into master will increase coverage by 0.01%.
The diff coverage is 93.33%.

@@             Coverage Diff              @@
##             master     #779      +/-   ##
============================================
+ Coverage     66.01%   66.03%   +0.01%
- Complexity     3924     3934      +10
============================================
  Files           340      341       +1
  Lines         25856    25891      +35
  Branches       3239     3242       +3
============================================
+ Hits          17070    17097      +27
- Misses         7887     7888       +1
- Partials        899      906       +7

Impacted Files
Coverage Δ
Complexity Δ

...main/java/com.github.ambry.server/AmbryServer.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...main/java/com.github.ambry/config/StoreConfig.java
100% <100%> (ø)
1 <0> (ø)
:arrow_down:

.../clustermap/ClusterManagerWriteStatusDelegate.java
100% <100%> (ø)
3 <3> (?)

...n/java/com.github.ambry.store/StoreDescriptor.java
88.37% <100%> (+0.56%)
7 <1> (+1)
:arrow_up:

.../main/java/com.github.ambry.store/DiskManager.java
94.31% <100%> (-0.13%)
19 <0> (ø)

...in/java/com.github.ambry.store/StorageManager.java
89.28% <100%> (ø)
20 <0> (ø)
:arrow_down:

...rc/main/java/com.github.ambry.store/BlobStore.java
88.84% <89.65%> (+1.13%)
51 <12> (+6)
:arrow_up:

...github.ambry.rest/AsyncRequestResponseHandler.java
88.52% <0%> (-2.3%)
23% <0%> (ø)

...b.ambry.network/BlockingChannelConnectionPool.java
64.03% <0%> (-2.2%)
8% <0%> (ø)

...in/java/com.github.ambry.network/SocketServer.java
82.78% <0%> (-0.41%)
13% <0%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1a688e...bbc26bf. Read the comment docs.

@vgkholla how does it look now?

@dharju please make sure that all changed files are formatted (should probably find something for intellij to do it automatically).

@vgkholla looks like I can reformat everything by highlighting in the project window and doing the format short cut (command + alt + L).  I'll do that from now on

Hi @pnarayanan you want to take a peek at this to see if it's all good?

@pnarayanan looks good now?

@pnarayanan how does it look now?

Changed method name

Looks good to me. @dharju do you want to include a description in the commit message? (there doesn't seem to be any).

authors: codecov-io dharju pnarayanan vgkholla

repo: linkedin/ambry


text:
Add locale selection mechanisms (to support i18n)

Codecov Report

Merging #743 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #743   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          42     42
  Lines        1275   1282    +7
=====================================
+ Hits         1275   1282    +7

Impacted Files
Coverage Δ

app/controllers/static_pages_controller.rb
100% <100%> (ø)
:arrow_up:

app/controllers/application_controller.rb
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff01d1...27ca8f8. Read the comment docs.

We're not done, but this is a big step forward in internationalization.
I'm merging this in, because we can now select locales, several pages have implemented it, and we even have a start in French (fr).

authors: codecov-io david-a-wheeler


text:
Add RabbitMQ topology setup before connecting consumers to queues

Awesome work! Will check it!

authors: JohannesSoots llxff

repo: llxff/coney


text:
topic2

As I commented on previous code reviews, you must not include .classpath, eclipse configuration files or version control files. Build output is being generated by Maven on target folder, you must not include that folder in commits or pull requests too. Please fix and I will review.

authors: jordanholtz lucast-globant

repo: lucast-globant/java-bootcamp-bahia


text:
Make cards wait to be rendered until all images have been fetched

done with a loader that displays the capitol while waiting for the image to load

repo: luiscarlin/representatives

license: WTFPL


text:
local caching

How do users specify where they want the local cache file to be?  How do they specify that they want to clear it?  Will this automatically detect function signature changes?

How do users specify where they want the local cache file to be?  How do they specify that they want to clear it?  Will this automatically detect function signature changes?

How do users specify where they want the local cache file to be?
We use the working dir which in local execute is just a filepath rather than auto-deleting tmp dir. @kumare3 suggested moving this to a dir in the user's home directory. i can also make the file within the directory configurable as well.

How do they specify that they want to clear it?
Do we have any semantics around cache busting right now? Suggestions on a good interface? You can clear it currently as is done in tests but that's not exactly documented.

Will this automatically detect function signature changes?
Yes

How do users specify where they want the local cache file to be?
We use the working dir which in local execute is just a filepath rather than auto-deleting tmp dir. @kumare3 suggested moving this to a dir in the user's home directory. i can also make the file within the directory configurable as well.

How do they specify that they want to clear it?
Do we have any semantics around cache busting right now? Suggestions on a good interface? You can clear it currently as is done in tests but that's not exactly documented.

Will this automatically detect function signature changes?
Yes

closing due to issues with joblib. will put out an alternate proposal for caching

closing due to issues with joblib. will put out an alternate proposal for caching

authors: katrogan wild-endeavor

repo: lyft/flytekit


text:
add archflags to FFLAGS environment variable

Could you edit the description so we'll know why you want to do this? Makes reading your change easier.

This is not the correct way to fix this. The bug appears to have been introduced in aa375e5, where it was incorrectly assumed that the environment variable corresponding to $tool is always [string toupper $tool]FLAGS. This does not hold for f77 and FFLAGS.
A special case needs to be added on line 904 in master.

authors: MarcusCalhoun-Lopez jmroot pmetzger

repo: macports/macports-base


text:
Solve best time to buy and sell stock

There are other variants of the buy/sell stock problem, so I had to rename the file. Other than that you did a great job.

Thanks!


text:
Changed header

stormphp

repo: margas-git/site


text:
makePaths fails with h5 sinks

remove name.h5


text:
Renamed Video and Audio calling, adding more info

Combined in another commit to the changelog. Will go through PM review when the changelog PR gets merged.

repo: mattermost/docs


text:
v3.8 Changelog

Closing. I committed the changes to the v3.8-documentation branch instead of to separate branches.


text:
Fix the 'random' import error, close #4

Ah, you beat me. :)
thx! :cake:

Lemme clean some stuff up since I haven't touched this in a while, and I'll push a new release to pypi.


text:
Create ignore

test

repo: mendersoftware/mender-docs


text:
repo: release marathon-lb 1.13.0

@ryadav88 request you to please review the update to marathon-LB universe package

authors: GoelDeepak jkoelker

repo: mesosphere/universe


text:
Add support for paginated endpoints

Currently (for messages, doesn't matter for reactions) only supports from newest to oldest pagination

at amy how do you feel about adding stream based methods for iterable endpoints

I think it could be a good idea, just not sure if it'd be appropriate to include in this PR

authors: natanbc queer

repo: mewna/catnip


text:
Better error message.

What are those two „Merge branch 'master' into crypto_fix“? Is this merging of the master into the branch, instead of rebasing the branch? If so, what's the advantage?

authors: weingart wmark

repo: mholt/caddy


text:
REST API for repos should pull in topics

I've verified there is more backend work required on this one.

I want to contribute in this issue.What should  i do to solve the issue.

i can resolve this issue

i can resolve this issue

@jeffwilcox @emmairwin

Unfortunately this issue requires backend changes that are in a closed-source API server. This is tracked here for transparency. I'm going to remove the stale label but am not sure when this could improve. Once the API server is updated, the frontend would need corresponding fixes, too.


text:
How to set different page margin on first page in wkhtmltopdf?

This is not a bug. Please check the README and the manual of wkhtmltopdf.

I already saw it but i have not found any solution for this.

I'm sorry, but I can't provide support for wkhtmltopdf itself. This library is just a wrapper to make it easier to use it from PHP.

authors: kamalsamra mikehaertl

repo: mikehaertl/phpwkhtmltopdf


text:
DT-1638 Upgrades

Didn't think the swagger changes would work out of the box as is?

I don't understand - I haven't changed the springfox version in this PR.


text:
Web GUI

Hi ! It would be a pleasure to help ! Are you planning to use Express to make the website ? It's quite efficient and practical for a small web app like this

@Vertmo it's already work in progress at miscord/dashboard, but not published yet, I'll push an initial commit soon

Oh OK ! Well I'll keep an eye on that then !

authors: Bjornskjald Vertmo

repo: miscord/miscord


text:
new abgestures tracking

onTouch now doesn't consume touch, and using the Decor view of the window to be the last on the hierarchy to get the touch.

repo: mixpanel/mixpanel-android


text:
MLDB-2050 auto id use _ instead of -

Anyone knows if the doc needs to be updated?

+1

"make autotest" passes locally.

authors: FinchPowers guyd

repo: mldbai/mldb


text:
ENH: Add --filterchpi to mne browse_raw

cc @espressofiend we can get this one, too

repo: mne-tools/mne-python


text:
Add advanced binary verification user guide

+guide

@qubenix what about adding wget instruction for servers without graphics? I think people who are running Linux servers might be interested by such options.

@el00ruobuob I added a wget option to sections 3.1 and 4.1 of the guide. Let me know if there's anything else.

Looks good to me. Perhaps a last one on 2.1 for fluffy hog key?

Great! I have no right to do so, but I approve this PR! Just wait for the merge to work on the French version.

Made one more fix in section 2.1: s/On Windows and Mac/On Windows or Mac/.

@qubenix The French index is conflicting since i added the basic binary verification link (which was missing) in a commit pushed yesterday by @luigi1111

Maybe not good, lol. Not sure what I need to do to fix this up and I don't really have the time to focus on it for a while...unless someone wants to give me a nice hint. :wink:

It's still showing conflict on _i18n/fr/resources/user-guides/index.md.
I believe you should better solve this on github directly.
Click on solve, then check on the file, keep the existing version and re-add the line for your new guide.

Or guive me write access on your PR if you want me to try.

Or Check this URL
Are you using CLI ?

Just try:
git pull upstream master
atom _i18n/fr/resources/user-guides/index.md (or whatever editor you use) => Keep HEAD (where your changes are) => Save and close
git add .
git commit --amend
Enjoy!

I clone your repo and did this on my side to see if it works. So you can just add me as a contributor and i git push --force for you.

Added you @el00ruobuob, thanks.

humm... cannot push --force

@erciccione i think this great job from @qubenix is ready for review/aproval from officials.

Going to correct a small inversion in headers numbers 4.2 vs. 4.3 in the links of the summary.

Update for the guide name in root/ressources/user-guide/file

@rehrar Checked (and corrected) on my test env:
| Edge | IE 11 | Chrome | Firefox | Opera | Vivaldi
-- | -- | -- | -- | -- | -- | --
Windows 7 | - | OK | OK | OK | OK | OK
Windows 10 | OK | OK | OK | OK | OK | OK
Ubuntu 18.04 | - | - | OK | OK | OK | OK
CentOS 7 | - | - | - | OK | OK | OK

pinging reviewers, in the hope they'll approve :rofl:  @mattcode55 @MaxXor

I did review, but can't approve.

Another reviewer here? @erciccione @mattcode55 @MaxXor maybe we could get it merged soon? @rehrar as there is no impact with #744, it could be merged anytime.

@luigi1111 rebased it is. Building for tests.

Shouldn't be the commit authored by both you @el00ruobuob and @qubenix . If that's the situation could you run git commit --amend --no-edit  --author=qubenix?

ping @rehrar & @luigi1111 Could we merge this?

authors: el00ruobuob erciccione qubenix

repo: monero-project/monero-site


text:
Upgrade react version to 15.x to be compatible with Compass

Merged.

authors: durran rueckstiess

repo: mongodb-js/hadron-app-registry


text:
[fix bug 1282452] Update basket for nda subscription.

Coverage decreased (-0.007%) to 92.53% when pulling cb0165d8674fc8df7f1067ad82a0ac7f15a6e68c on akatsoulas:1282452-nda-subscription into 3cf4043a9d559a318df7e97dde45e7d111dab917 on mozilla:master.

Coverage increased (+0.01%) to 92.549% when pulling b0e919a1f665f52bd767a8f4f3392b9b512c3777 on akatsoulas:1282452-nda-subscription into 3cf4043a9d559a318df7e97dde45e7d111dab917 on mozilla:master.

@johngian r?

Let's also add a test for cases that user was member of group NDA but now state is pending.

r+wc

Coverage increased (+0.01%) to 92.549% when pulling cb65049e363d0f5d21ccf2b33038336c071c121a on akatsoulas:1282452-nda-subscription into 3cf4043a9d559a318df7e97dde45e7d111dab917 on mozilla:master.

Coverage increased (+0.02%) to 92.554% when pulling cb65049e363d0f5d21ccf2b33038336c071c121a on akatsoulas:1282452-nda-subscription into 3cf4043a9d559a318df7e97dde45e7d111dab917 on mozilla:master.

authors: akatsoulas coveralls johngian

repo: mozilla/mozillians


text:
Duration

Closing—duplicate.

repo: mplusmuseum/mplusmuseum-stories


text:
Updated certificates

@mohandatla,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Currently used certificate subject is in lower case so added lower case CN. Please let me know if you think it has to be Upper case for some other reason.

authors: mohandatla msftclas

repo: ms-iot/samples


text:
select object (web) is only available for css locator

Already fixed.

repo: munichbughunter/SevenFacette


text:
Dependency on gaze preventing installation with node 0.11.x and iojs

https://github.com/shama/gaze/issues/173

I think we can make gaze and watching a dev- dependency or use something more lightweight for the job.
Thank you for the info!

Fixed: bf4c25510cffdd9045c6be9552478c8dd09d4bf0
Chokidar is awesome.

authors: aurri babsonmatt tipiirai

repo: muut/riotjs


text:
Bug fix 2016 - v3.0.0

Sorry, didn't mean to open this PR.

repo: mycolorway/simditor-mention


text:
fix min.js statement and same-sign.js needed answer this commit fixes #8

issue #8

repo: nan-academy/js-training


text:
Remove check for valid doc

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant josesimoes

repo: nanoframework/nf-github-bot


text:
mana admin 命令bug

mana admin sql_modu, 感觉这个命令不是很好, 因为内置的admin是不希望暴露给使用者的.


text:
[Proposal] delegate closed check to underlying session

This is related to #7. It provides a simple interface to ask the underlying session if it is closed. It does not alter any of the looping/threading logic that already exists.

Do you have real word use for this?
I'd be much more happy to integrate something that's been proved to be usefull vs something that we think might be usefull.

The use case I outlined in #7.
Basically, I'm having a case where the underlying session is dying because the connection is closed by the end server.
I need to know when that happens so I can take action to kill processes that use the tunnel. Right now the gateway/tunnel acts like everything is fine. My processes just hang forever.

Can you post some code? I think i understand the usecase, but the devil is in details, so it would be good to see some code achieving what you want.

Like this? This is a simplified version of what I'm doing in production right now. I have a thread that loops over my set of tunnels (wrappers around Gateway instances). The tunnel closes the gateway if the gateway's session is closed.
Thread.new do
  loop do
    tunnels.each do |t|
      t.disconnect if t.gateway.closed?
    end

    sleep 10
  end
end

I dunno … it just seems odd that the gateway acts like everything is fine if the underlying session is closed. That seems like a bug to me. I'm trying to make it easy by suggesting it as a feature. Maybe that's the wrong approach.

If I was going to fix the bug in net-ssh-gateway, I would change this code:
    def initiate_event_loop!
      @active = true

      @thread = Thread.new do
        while @active
          @session_mutex.synchronize do
            @session.process(@loop_wait)
            raise IOError.new("Session closed") if @session.closed?
          end
          Thread.pass
        end
      end
      @thread.abort_on_exception = true
    end

But that's a kill-everything sort of scenario because of abort_on_exception.

Or maybe this is better:
   def initiate_event_loop!
      @active = true

      @thread = Thread.new do
        while @active
          @session_mutex.synchronize do
            @session.process(@loop_wait)
          end
          shutdown! if @session.closed?
          Thread.pass
        end
      end
    end

I can try that in production to see how it runs.

Actually, that might be a problem because shutdown! waits for @thread.join … so that's no good.

Ugh, threads in Ruby.

How about this:
    def initiate_event_loop!
      @active = true

      initiate_session_watcher!

      @thread = Thread.new do
        while @active
          @session_mutex.synchronize do
            @session.process(@loop_wait)
          end
          Thread.pass
        end
      end
    end

    def initiate_session_watcher!
      Thread.new do
        while @active
          shutdown! if @session.closed?

          sleep @watcher_wait
        end
      end
    end

I could go either way. Or none at all. I'm happy to just subclass gateway in my own code and close this.

This PR was just the most simple way I could think that would allow a user of the gateway to handle watching for abnormal closing without changing net-ssh-gateway too much.

@tpitale thanks for looking into it. Can we clarify the original issue?
So you connect to a gateway you start some services but the gateway closed. But the existing tunnels port are not closed, and kept around forever?
This sounds like more a bug than we need a feature for. But let me try to repro it to see i fully understand the issue.
Miklos

I'll open a new issue for cleaner discussion.

authors: mfazekas tpitale

repo: net-ssh/net-ssh-gateway


text:
MacOS 10.15 基本数据类型都转成了NSString类型,没区分开

有区分的


text:
Fixes #478 by documenting run.time in the UserManual

This looks fine and thanks @fritzo for cleaning up my lapse on this.  I would have made fewer assumptions about different timing needs and when they might arise, and instead simply have presented how run.time works and let different programmers determine their needs for it, e.g. timing different steps of a function.  E.g. we've used it to collect times of each sampler in an MCMC.

authors: fritzo perrydv

repo: nimble-dev/nimble


text:
Changed year from 2020 to 2021  at footer

/rebase

/rebase

Done

authors: dashersw muratcanoguzhan

repo: nimbleturkiye/quovote


text:
Replace moment with dayjs

Could you please update your local node.js version? Currently, package-lock.json has 15.000 lines whereas it should maybe be 10

/rebase

authors: dashersw dogukani murerkinn


text:
chore(ci): add codecov

Codecov Report

Merging #428 into master will increase coverage by 13.30%.
The diff coverage is 60.43%.

@@             Coverage Diff             @@
##           master     #428       +/-   ##
===========================================
+ Coverage   46.85%   60.16%   +13.30%
===========================================
  Files          16       70       +54
  Lines         621     4029     +3408
===========================================
+ Hits          291     2424     +2133
- Misses        328     1410     +1082
- Partials        2      195      +193

Impacted Files
Coverage Δ

pkg/eventbus/event.go
0.00% <0.00%> (ø)

pkg/exchange/manager.go
0.00% <0.00%> (ø)

pkg/http/router/context.go
0.00% <0.00%> (ø)

pkg/log/writer_string.go
0.00% <0.00%> (ø)

pkg/object/dump.go
0.00% <0.00%> (ø)

pkg/orchestrator/queue.go
0.00% <0.00%> (ø)

pkg/sqlobjectstore/options.go
100.00% <ø> (ø)

pkg/sqlobjectstore/pubsub_filters.go
70.58% <ø> (ø)

pkg/sqlobjectstore/store_sql.go
58.78% <ø> (ø)

pkg/stream/common.go
17.24% <ø> (ø)

... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77f44b8...86745df. Read the comment docs.

authors: codecov-commenter geoah

repo: nimona/go-nimona


text:
Unit tests for ‘loca’ table

hey maybe adding --compilers js:babel/register to mocha execution and the package babel so unit tests can be written in ES6/7

Done; now using Babel.

sorry, i'm adding more tasks, but it this might needs a think. usage of .babelrc with:
{
  "optional": [
    "es7.asyncFunctions",
    "es7.classProperties"
  ]
}

both aren't stable yet. but async functions can make async tests really easy. the usage of this options, is debatable,  might need discussions.
@fdb what do you think?

Thanks for the tests.
I'm not a big fan of including babel, though. It think it more difficult for new people to contribute. For example, we have to explain that everything in src is written in one language (ES5), and everything in test is written in another language (ES2015).
Since it doesn't seem your current test code uses any of the ES2015 features, I suggest removing babel for now.

@oriSomething as for async, I've just added loadSync so we can avoid async loading in test code.

I've now added a basic regression test, also using mocha (but without babel).
If you want I can merge this PR myself, or if you prefer you can update it by pulling from master.

Updated; have another look?

@fdb, what do you think, OK to merge?

Just merged. Thanks for the changes!

authors: brawer fdb oriSomething


text:
Build is breaking in latest version.

Do you mean building from source with docker is not working? What kind of error are you getting? Works fine for me at least on Fedora with podman, so I can't really say what could be wrong without more info

Thanks for the info, I tried with a small webpack demo but wasn't able to reproduce the issue noppa/text-security-webpack-demo
do you notice some notable differences between that demo and your setup?

This happens on both Windows and Linux with text-security version 3.2.0. It is a vuejs application created with vue-cli version 3.11.0. In main.js file I'm doing
import Vue from 'vue';
import 'text-security/text-security-disc.css';
And that's where the build is breaking.
I tried your demo build and it's working, so maybe the problem is that I'm running a vuejs app.
"npm run dev" is the same as "npx vue-cli-service serve".

@green-pigeon Thanks, I was able to repro the issue with vue-cli 3.11.0. It seems that the postcss version that it uses wasn't able to handle @supports (selector( .. )) construct that was in the CSS. I replaced it with a bit simpler -moz-appearance:meter check to detect Firefox. Try version 3.2.1 and reopen if the build still fails.

I confirm it is fixed. Thank you!

authors: green-pigeon noppa nsisodiya

repo: noppa/text-security


text:
[T3A2][F11-A4] Cara Leong Su-Yi

Ready for review

Ready for review

@craaaa Please acknowledge and close PR. We are now advised to follow this protocol for PR closing to ensure student read our comments.


text:
Update to use vessel

This is #74 without commits found in other PRs.

repo: obsidiansystems/rhyolite


text:
Fix a minor issue in the documentation of bigarray_of_array

Thank you.

authors: dsheets yallop

repo: ocamllabs/ocaml-ctypes


text:
Use Jasmine instead of Mocha for testing

And have to change script setting of .travis.yml file

repo: oh-my-github/oh-my-github


text:
FosUserBundle enhancement

#845

repo: okulbilisim/ojs


text:
Implémenter l'affichage des formules Latex depuis l'interface

les commentaires ;; commentaires ne sont pas dismiss par le parseur latex

repo: olzd/touist


text:
only one face detected , i tried with multiple personnes but it only detects one face

@DeboubaAfef  Have you done it with multiple persons ? . If yes please tell me How ?


text:
Allow Either Files or Base64 encoded branding images

@pld I made the changes.

repo: onaio/ansible-superset


text:
Fix multiple times enqueue

fixing this issue: #81

repo: ondrejbartas/sidekiq-cron


text:
Volume knob needed

http://react-components.com/component/react-bootstrap-native-slider

Volume control::
amixer set PCM -- -9999  # off, -99.99dB
amixer set PCM -- 400    # full, +4.00dB

Going with buttons for now because sliders in react suuuuuck

repo: onewheelskyward/automatic-pancake


text:
docs: add changelog

Codecov Report

Merging #55 (aa1e6c2) into master (fa69ef9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   71.33%   71.33%
=======================================
  Files          99       99
  Lines        4546     4546
  Branches     1079     1079
=======================================
  Hits         3243     3243
  Misses       1155     1155
  Partials      148      148

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa69ef9...aa1e6c2. Read the comment docs.

authors: codecov-io rsdmike

repo: open-amt-cloud-toolkit/ui-toolkit


text:
Fake data for PHP & Java 0.2 to generate image

Can this be closed?

authors: austinlparker lizthegrey


text: added Lehigh County, PA, USA

authors: migurski trescube

repo: openaddresses/openaddresses


text:
integrate ci

Signed-off-by: binh nguyen binhn@us.ibm.com

trouble in the pull request

repo: openblockchain/obc-peer


text:
[tansignari] impostare immagine condivisione social per questo repository

Fatto dai settings del repo.
E adesso è così

bella mi piace :-)

authors: aborruso gbvitrano

repo: opendatasicilia/tansignari


text:
Add missing goog.require

Looks good to me. Please merge.

authors: elemoine fredj


text:
Allow text selection

replaced with #6741

authors: drnextgis fredj

repo: openlayers/openlayers


text:
Up profile+contributors+octocat

Sure, thanks for notifying the file. It was actually a mistakenly uploaded file also noticed some issues with the uploads regarding the author, things got fixed now.


text:
[WIP] Fix appveyor build (setting JAVA_HOME).

Thanks @chrisdembia Is that because default install location of Java has changed on appveyor? Branch pr builds were passing but master wasn't I think

Yes, Chocolatey updated jdk8 from 1.8.0_121 to 1.8.0_152. I'm hoping these changes will help us avoid disruptions the next time Chocolately updates jdk8.
I think even the PR builds are failing.

AppVeyor build still failing because can't find java

@chrisdembia This feels so painful and time consuming, maybe we can use the full path to java.exe instead of adding to the path? Thanks for all your work on this, appreciate it.

Yes, pretty frustrating. Good idea, but it's Ant that is trying to use java.exe, not us. I'm not sure how to tell Ant what to do.

@chrisdembia one more thought, could it be permissions on java.exe (not executable)? The dir command earlier shows only "a" permission, is that expected? Just trying to get the automated build upagain. Thanks.

authors: aymanhab chrisdembia

repo: opensim-org/opensim-gui


text:
Move drug profile page GraphQL queries to .gql files

Fixed except for the Profile query which is dynamic and cannot be extracted.

work done

authors: LucaFumis andrewhercules ktsirigos

repo: opentargets/platform


text:
the oraclize call back not working now on the rinkeby testnet

We had a node/server issue, with space having run out. It was put back in working order yesterday and posted on our gitter channel. There may be some downtime today, as there was maintenance scheduled.

authors: D-Nice godink

repo: oraclize/ethereum-api


text:
fixed specified

Thanks for the PR @0xflotus, good catch!

Thanks for your first PR, @0xflotus. :)

authors: 0xflotus RichardLitt haadcode

repo: orbitdb/orbit-db


text:
Implement random stock from market & sector

Implemented feature. Added query parameter for sector in random stock routes. Queried market pandas dataframes by sector.

repo: oscjaimes/wsb-rand-stock


text:
New check: code is scanning for secrets

A check that something like trufflehog (or other secret scanners) are running would be nice:

https://github.com/dxa4481/truffleHog
https://github.com/marketplace/actions/trufflehog-actions-scan

Some examples from Google VRP program, see here - https://docs.google.com/document/d/10GWKW55YD6ZmHcJmQ2ZFu7jv75zyasHvx2O3yyRrfDI/edit

Some examples from Google VRP program, see here - https://docs.google.com/document/d/10GWKW55YD6ZmHcJmQ2ZFu7jv75zyasHvx2O3yyRrfDI/edit

Don't have access to the doc.

We may check for the presence of this .gitignore and be sure sensitive files like private keys, password, etc are listed.

There's also https://github.blog/2022-12-15-leaked-a-secret-check-your-github-alerts-for-free/, which shows a setting we could use.

This feature does not align with the current project focus. If there is no feedback in the next 7 days to the contrary, then this issue will be closed.

Keeping open as there was interest here: #3399

Unless this can check for Snyk secret scanning, the output will be noisy.

TAC requested adding secret scanning and push protection to the security baseline,  ossf/tac#333. This check will be a super helpful verification and audit tool

authors: Danajoyluck afmarcum inferno-chromium kimsterv laurentsimon lucasgonze mwarkentin naveensrinivasan spencerschrock

repo: ossf/scorecard


text: Mark honest answer

repo: oughtinc/mosaic


text:
[Backend] Added Delete Product Function & Fixed Minio Connection Refused Bug.

@MartinLam-Oursky please also resolve conflicts at .gitignore


text:
testnet network support - 3bifpavuyvdxk - validator,rpc,api

@kaustubhkapatral, Your Moniker and validator addresses are required, please update the PR with those details.

@kaustubhkapatral, Your Moniker and validator addresses are required, please update the PR with those details.

Moniker: Witval
Validator address: akashvaloper1vpgevmr5cnp2av7tv0mckl88ufkz46eq29xqph

Moniker: Witval
Validator address: akashvaloper1vpgevmr5cnp2av7tv0mckl88ufkz46eq29xqph

authors: PrathyushaLakkireddy kaustubhkapatral

repo: ovrclk/net


text:
🧪  Make sure that all tests are passing

Fixed by #27

repo: owowagency/laravel-resources


text:
Fixing formatting for cdc-parent/README

Merging as is only README change.

repo: pabloem/DataflowTemplates


text:
chore: Update README.md

merged, insubstantial

repo: paritytech/substrate-light-ui


text:
initial commit of jenkins.template

lgtm if you can reformat to make syntax more terse and human readable

authors: ironmanwaring paulSambolin

repo: pariveda/honey-badger-cloud-formation


text:
Implementation of SSD in PyTorch

Complete plagiarism. Closed.

repo: pclubiitk/model-zoo


text:
kettle

Hello, This is an automated comment from our build system. Since this pull request originated from a user  not in the Pentaho organization, we will not proceed  with automatic validation of the pull request.  However, rest assured that it will be reviewed manually as soon  as we get the chance. Thanks for your contribution!

authors: pubEgg wingman-pentaho

repo: pentaho/pentaho-kettle


text:
comments added to item java class in domain

created item class for domain

created item class for domain


text:
When no subtype results, report "NA" in subtype field

Fixed in #78

Should apply a better solution as described at #79

repo: phac-nml/biohansel


text:
New section on cursor

Done


text:
Adding in wikitude docs

I think we should rename the title Wikitude and Augmented Reality to Augmented Reality

authors: mwbrooks timkim

repo: phonegap/phonegap-docs


text:
Upgrade OpenCVSharp to 4.5.0

Is there a docker image based on pi-top os we can use to compile this code?

Is there a docker image based on pi-top os we can use to compile this code?

Not yet - let's figure out a more sustainable solution when we have a few more pressing things ironed out

authors: colombod m-roberts


text:
Do not display success messages if nothing was imported

lgtm

authors: bakongo rkenzhebekov


text:
Add code coverage to CI

Changes Unknown when pulling cd83a4ef2d3293fe280e134fe577561846ffa27e on AddCoverageCI into ** on master**.

authors: coveralls pinicarus

repo: pinicarus/piquouze


text:
Use NSLock instead of a semaphore for locking

I think that something like this would be a bit more performant? https://github.com/pinterest/PINRemoteImage/blob/master/Pod/Classes/PINRemoteLock.m
I'd also be ok with using a mutex directly.

Can you update the commit description to explain the benefit of this change?

authors: garrettmoon jparise maicki

repo: pinterest/PINCache


text:
New 1.1.3 release for dynamic stemcell dependency

Thanks @emberdeboer !

authors: emberdeboer jncd

repo: pivotal-cf/docs-blue-medora


text:
Create PR for FPS monitor and Toggle Switch

Created PRs:
https://github.com/gskinnerTeam/flutter-stats-fl/pull/5
https://github.com/boringdeveloper/FlutterSwitch/pull/9
They are now merged.

repo: platform-platform/monorepo


text:
Implement Split Extension for IAsyncEnumerable

merged in funcky3

authors: FreeApophis bash

repo: polyadic/funcky


text:
Milestone 0.0.4 alpha.6

Coverage remained the same at 100.0% when pulling 3ce11d88ab17147562af4589679b9f135bc82b40 on milestone-0.0.4-alpha.6 into 6b2444df8bb3e72bf09866c81cd1523f4586cd51 on master.

Coverage remained the same at 100.0% when pulling 3ce11d88ab17147562af4589679b9f135bc82b40 on milestone-0.0.4-alpha.6 into 6b2444df8bb3e72bf09866c81cd1523f4586cd51 on master.

Coverage remained the same at 100.0% when pulling 3ce11d88ab17147562af4589679b9f135bc82b40 on milestone-0.0.4-alpha.6 into 6b2444df8bb3e72bf09866c81cd1523f4586cd51 on master.

authors: GitScrum coveralls

repo: post-org/post-config


text:
Adding file containing pod-utilities version

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: RagniGarg97
To complete the pull request process, please assign mkumatag after the PR has been reviewed.
You can assign the PR to them by writing /assign @mkumatag in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @mkumatag

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mkumatag, RagniGarg97
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [mkumatag]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

authors: RagniGarg97 ltccci mkumatag


text:
Small code refactoring

Keep in mind here you're changing code which isn't ours (which is why the quality of code differs so much).

authors: UselessToucan peppy

repo: ppy/osu-framework


text:
Support Django 1.11

@slurms thanks!

All good :+1:, would it be possible to make a pypi release too?

Will do

authors: phala slurms

repo: praekelt/django-recaptcha


text:
Feature/update tag nav data

👍

repo: praekelt/molo


text:
Close terminal on JVM shutdown

AC @electrum

Failure unrelated: https://github.com/prestosql/presto/issues/6193

@electrum ready to merge, rebased on master

repo: prestosql/presto


text:
Update changelog in preparation for version 0.11.0

bors r+

authors: Tiwalun Yatekii

repo: probe-rs/probe-rs


text:
Sort directories by name in dashboard form

:+1:

repo: prometheus/promdash


text:
Added Get-ScriptTasks as in issue #153

I realized that I screwed with my merge/rebase. I restarted the work in a brand new clean branch.

repo: psake/psake


text:
(RE-10177) Use packaging as a gem

Test FAILed

Test PASSed

authors: austb puppetlabs-jenkins

repo: puppetlabs/puppetdb


text:
Release mergeback 2.0.0

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   89.89%   89.89%
=======================================
  Files           6        6
  Lines         188      188
=======================================
  Hits          169      169
  Misses         19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f0411...66f1b95. Read the comment docs.

authors: codecov-io eimlav


text:
(MODULES-8819) Release merge back 2.0.1

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   89.89%   89.89%
=======================================
  Files           6        6
  Lines         188      188
=======================================
  Hits          169      169
  Misses         19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd5cdde...18dd659. Read the comment docs.


text:
Change wash version => wash --version, add verify-install flag

I'll update the website after this stuff is released so that new users won't be confused.

Updated to address the feedback (unless otherwise noted).

This should probably have an issue associated with it.

authors: MikaelSmith ekinanp

repo: puppetlabs/wash


text:
3.23.52

Fixed it.... Just had to delete my fork and do it again.

I could fix the previous one later but if this one is OK, I'll merge it then :D

repo: pylerSM/YouTubeBackgroundPlayback


text:
一个手机号对应一个账号，现在限制的不全

问题已修复
52d2af832a05b1bed9aed742fa9c867bec75cd43

问题已修复
52d2af832a05b1bed9aed742fa9c867bec75cd43

repo: qingchiapp/qingchi-uni


text:
Subrogram dynamic shapes done

Current coverage is 36.96%

Merging #1688 into master will increase coverage by +10.62% as of fefdf9c

@@            master   #1688   diff @@
======================================
  Files         1846     557    -1289
  Stmts        78109   24710   -53399
  Branches         0       0
  Methods          0       0
======================================
- Hit          20576    9134   -11442
  Partial          0       0
+ Missed       57533   15576   -41957

Review entire Coverage Diff as of fefdf9c

Powered by Codecov. Updated on successful CI builds.

authors: DenisKogutich codecov-io

repo: qreal/qreal


text:
Issues/heat asset list

@grdw can this be merged?

I would say it's ok for now. Otherwise it will be to cluttered with tiny other issues which have no relation to the actual issue.

@grdw Is there an easy way to convert a serialized value from the DB into something else, before it is displayed in the table? I noticed that connection_distribution is stored as a factor (a number between 0 and 1, where 1.0 means 100%), but the front-end labels it as a percentage.

I tried creating a custom reader/writer on InstalledHeatAssetLocation...
class InstalledHeatAssetLocation
  def connection_distribution_percent
    connection_distribution * 100
  end

  def connection_distribution_percent=(amount)
    self.connection_distribution = amount / 100
  end
end

... and then using that in the front-end, but this doesn't work. It looks like the values get saved to the DB without ever hitting the AssetLocation model.

It looks like the values get saved to the DB without ever hitting the AssetLocation model.

Yes that's correct. My idea for now is to to keep it a Float. Eventually when the sliders are implemented (or if you are currently doing that) my idea would be to have a hidden field in the HTML that has the number_of_heat_connections. The slider than specifies a number between 0..100 (or 0..1.0) and updates a hidden number_of_units input in the table. If that input changes so does the JSON.

After thinking some more I guess that at the moment of calculating the business case, the BusinessCaseCalculator class should determine the amount of heat connections. That's passed on to the InitialCosts calculation and than it should be allright I guess?

I agree. I like the idea of storing the percentage in the asset list, rather than the explicit number of units. I'll merge this as-is and we can worry about sliders (or changing the UI to a percentage) once the heat summary chart is done.

authors: ChaelKruip antw grdw

repo: quintel/etmoses


text:
JSONField instead of TextField for students per country

Codecov Report

Merging #61 into develop will decrease coverage by 48.81%.
The diff coverage is 80%.

@@             Coverage Diff              @@
##           develop      #61       +/-   ##
============================================
- Coverage    93.74%   44.92%   -48.82%
============================================
  Files           33       34        +1
  Lines          911      917        +6
============================================
- Hits           854      412      -442
- Misses          57      505      +448

Impacted Files
Coverage Δ

web/olga/analytics/create_test_fixture.py
0% <0%> (ø)
:arrow_up:

web/olga/analytics/models.py
40% <100%> (-60%)
:arrow_down:

...ga/analytics/migrations/0006_auto_20170801_1243.py
100% <100%> (ø)

web/olga/analytics/urls.py
0% <0%> (-100%)
:arrow_down:

web/acceptor/urls.py
0% <0%> (-100%)
:arrow_down:

web/olga/charts/urls.py
0% <0%> (-100%)
:arrow_down:

web/olga/functional_tests/test_map_metrics.py
32.14% <0%> (-67.86%)
:arrow_down:

web/olga/charts/tests/test_views.py
32.95% <0%> (-67.05%)
:arrow_down:

web/olga/analytics/tests/test_views.py
35.36% <0%> (-64.64%)
:arrow_down:

web/olga/analytics/tests/test_models.py
36.84% <0%> (-63.16%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22ae6c3...9c98802. Read the comment docs.

authors: DmytryiStriletskyi codecov-io

repo: raccoongang/acceptor


text:
sqlite already calibrated or not? indicator missing

maybe use system date? or just a flag

Done

authors: mbty radiotrackingeu


text:
Add permission to ReportWidgets

You should create a new permission called view_widgets => 'View dashboard widgets' instead and use that.

Alright. I created a new one: #85

You don't have to create new pull requests, you can just continue to edit on the same branch that you submitted it on and future commits will be pulled into the PR automatically

repo: rainlab/googleanalytics-plugin


text:
update event-subscriber

LGTM

authors: StrongMonkey cjellick

repo: rancher/agent


text:
Clean up hardware/software requirements and fix up to use a reference doc versus shortcode

related to #726 . Closing.

repo: rancher/docs


text:
Run tests on qemu-system-aarch64

Without these patches, the ARM64 CI can not run successfully. hope to merge these to master branch.

@datawolf @ibuildthecloud Please take a look. This should be ready to go.

https://github.com/rancher/os/issues/672

authors: datawolf deniseschannon imikushin

repo: rancher/os


text:
Use juju/errors for tracing error

LGTM

authors: ngaut qiuyesuifeng

repo: reborndb/reborn


text:
Add user activity endpoint, and some other api adds for profiles patch

👓 @nramadas

:fish:

authors: nramadas schwers

repo: reddit/node-api-client


text:
Create a new object from merged properties: ES2015

Thanks :+1:

authors: flashhhh fson

repo: reindexio/youmightnotneedunderscore


text:
Switch to using the standardised resin-lint module for linting.

https://github.com/resin-io-modules/resin-register-device/blob/master/.hound.yml#L2 needs to be  set to enabled: false for the failing tests - but then we don't really need HoundCI integration for this repo at all, do we? Especially considering that HoundCI doesn't support coffeescope

Yeah, let's remove .hound.yml, and I'll turn off this repo on hounci.com.

I've removed .hound.yml

I've also set up jenkins, so that we still get the linting run

Awesome, feel free to merge when you're ready.

authors: Page- jviotti lekkas

repo: resin-io-modules/resin-register-device


text:
Socket

Thanks
Keep up the GREAT WORK

authors: MahmoudFayed abdallah-elsharif

repo: ring-lang/ring


text:
View slides now italics

@rohit-gohri  why was this closed?

@rohit-gohri why was this closed?

Making new demo PRs for Github Actions. Already merged #7 for .gitlab-ci.yml, so this had conflicts.

authors: Rfrixy rohit-gohri

repo: rohit-gohri/hello-ci-frontend


text:
antibiotic_resistance

got it. thanks,

authors: LSicat roycan

repo: roycan/ABM-new


text:
Changes Intridea name to Grape.

Thanks! Missed this one.

authors: dblock towanda

repo: ruby-grape/grape


text:
Show backtraces in lens runnables

bors r+
Thanks!

authors: SomeoneToIgnore matklad

repo: rust-analyzer/rust-analyzer


text:
Allow usage of CARGO_TARGET_DIR env var

bors r+

authors: killercup matklad


text:
Format code using 'cargo fmt'

@Atul9 thanks! would you object to re-running this on the current master, and I can merge? Sorry for not getting back to you!

@nikomatsakis I ran cargo fmt but the code is already formatted. I have add cargo fmt to .travis.yml, please review.

repo: rust-lang-nursery/ena


text:
build: make clippy faster by using checking before that operation

Is the expectation that cargo check is faster than cargo clippy on the dependencies?

Yes, that is.

Thanks.

authors: kinnison lzutao


text:
remove licens and rename project

ii

repo: rustyscreeps/screeps-starter-rust


text:
SAM-3082 fix NPE in getHighestSubmittedAssessmentGrading

LGTM

authors: master-bob ottenhoff

repo: sakaiproject/sakai


text:
#26 Remove channel

Great!

authors: samyakbambole sarawukl

repo: samyakbambole/twitch-live-chat-history


text:
Improve Docs

Hi @anurag-sonkar,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
https://www.lightbend.com/contribute/cla

Actually nanoc is no longer used.

repo: sbt/website


text:
Added a properly test context in the client

Is this still valid? If not can it be closed?

Done

authors: rafaparadela raulraja

repo: scala-exercises/site


text:
fx: Orbit management - config userName + redundancy

Adding tests

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.


text:
FT: Pass request UID to Utapi client

👍

👍


text:
Write tests

I'm back in work now, so i will use a few evenings to get round to writing some tests 👍

I'm back in work now, so i will use a few evenings to get round to writing some tests 👍

Awesome @bencleary! I really appreciate your contributions to this project!

Awesome @bencleary! I really appreciate your contributions to this project!

What about giving the project to jazzband?

It's not really a package that JazzBand would take, it's a super niche feature within Django. I haven't had time for a while but there will be updates soon!

authors: bencleary eracle schlunsen

repo: schlunsen/django-timescaledb


text:
Change all ndarrays to memory views in the Cython code

Not really necessary.  Code currently uses a mix of ndarrays and memoryviews without a problem.

repo: scikit-learn-contrib/py-earth


text:
Add scikit-network in machine learning and AI

Merged, thanks @tbonald!

Great!
Is there a way to be referenced in the scikit list?
http://scikits.appspot.com/scikits
The package is on PyPI:
https://pypi.org/project/scikit-network/
Thanks.

Le 2 mai 2020 à 13:13, Ralf Gommers notifications@github.com a écrit :
Merged, thanks @tbonald https://github.com/tbonald!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/scipy/scipy.org/pull/344#issuecomment-622937216, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGIT435NYESKL6DS5V4EW7LRPP565ANCNFSM4MXTU2VQ.

In principle it should appear there automatically, but it seems the site is broken now. E.g. this shouldn't be a blank page: https://scikits.appspot.com/scikit-data

authors: pv rgommers tbonald