text:
TEST: Add a simple module loader, and test the FIPS module with it

This very simple module loader is only linked with the standard C
library, so cannot and should not provide any other symbol to the
module it tries to load.  It can thereby be used to verify that the
module it tries to load doesn't have any surprising dependencies when
it's supposed to be self contained.
A test recipe is added to verify the FIPS module with this loader.
Fixes #11020

fips.so depends on libc and libpthread locally:
$ readelf -d providers/fips.so

Dynamic section at offset 0x1aadb8 contains 28 entries:
  Tag        Type                         Name/Value
 0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]

Does the load fail if the application only depends on libc (and not on libpthread)?

A quick check indicates that the dlopen(3) succeeds with either LAZY or NOW specified.

A quick check indicates that the dlopen(3) succeeds with either LAZY or NOW specified.

Well yes, because fips.so currently doesn't have any unresolved libcrypto symbols.

Okay things are weird. moduleloadtest providers/fips.so OSSL_provider_init works but moduleloadtest providers/legacy.so OSSL_provider_init fails.
Both of these libraries have dependencies that aren't met by the executable (libpthread for fips.so and libcrypto for legacy.so).

Okay things are weird. moduleloadtest providers/fips.so OSSL_provider_init works but moduleloadtest providers/legacy.so OSSL_provider_init fails.

Not weird at all, you still need to have your LD_LIBRARY_PATH set right for ld.so to be able to load libcrypto.so.  In other words:
$ ./util/wrap.pl test/moduleloadtest providers/legacy.so OSSL_provider_init

Rebased for GH action fixups

Do you know that the failure case actually fails?  For exampel, add a call to CRYPTO_malloc(1) in one of the FIPS sources, build the library, and see if the test fails.

Looking at the comments of #11020, I ask what this PR actually tests.  That someone can load the FIPS provider and call the low-level API's directly?  Is that worth anything?

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Looking at the comments of #11020, I ask what this PR actually tests. That someone can load the FIPS provider and call the low-level API's directly? Is that worth anything?

The FIPS provider must be self-contained in terms of not calling outside the provider except for well defined callback APIs. Otherwise the FIPS module boundary would include libcrypto which is certainly undesirable. This PR should ensure that no libcrypto call is done.

Otherwise the FIPS module boundary would include libcrypto which is certainly undesirable

I believe we have talked about it in terms of "forbidden"

The check for OSSL_provider_init is icing on the cake rather than the central purpose of this PR

This PR should ensure that no libcrypto call is done.

Does this test do that?  Earlier comments say that dependent libraries are automatically loaded anyway. It seems to me that if you want ot make sure libcrypto isn't merged, look at the build.info file and put a comment there.

Merged
9800b1a0da90159a6bd6f5dbf8df6249ee967946 TEST: Break out the local dynamic loading code from shlibloadtest.c
527eb8d2949be19b1bc7b2fa84d0105091bb0928 TEST: Add a simple module loader, and test the FIPS module with it

authors: levitte openssl-machine paulidale richsalz t8m


text:
fixed warning about size_t / int (..\apps\ca.c(2643): warning C4267: …

During the work on another branch I noticed that app_malloc uses int as parameter while malloc uses size_t. This leads to a warning in AppVeyor:
…'function': conversion from 'size_t' to 'int', possible loss of data)
When having tried to make this change in the other branch, it resulted in additional CI errors, so I am trying to submit this fix on it's own.

The code in commit 48c65a6 is identical to commit 044f718 - any ideas why CI returns different results?

There is a known problem with the sanitizer builds which we've not tracked down yet.

I see - I would submit the final state (only fixing the issue in apps.c). If I find solutions for other occurrences, I would make different PRs. Is it possible to submit the PR even if the last CI is red in this case? If not - how shall I continue?

Keep going, we can merge with a red CI.  We just need to manually check if the CI is relevant before doing so.

This looks fine to me so approving (although the PR still seems to be in a "Draft" state?)

It was in Draft because I planned to do more and was unsure because of the red CI.

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

I was not aware I was supposed to take actions - what am I expected to do? I thought this PR just needs a second approve which cannot be done by myself?

I thought this PR just needs a second approve which cannot be done by myself?

This is an automated message to inform committers that this PR has not been looked at for a while..

I thought this PR just needs a second approve which cannot be done by myself?

This is an automated message to inform committers that this PR has not been looked at for a while..

But there is no action required from my side - I understood the message as if I was missing an action. I was aware that this PR was not changed for a long time but since it's not an important one, I didn't care.
As long as I didn't miss anything, I'm fine with it. I just wanted to ensure, the PR is not waiting for me.

Hasnt this just moved the problem to somewhere else? i.e there are calls to this function that pass an int as the sz which could possibly be negative.

At least this was not my intention :)
In the first commit, I changed the relevant parameter from int to size_t, so there should be consequently size_t for one case. I made additional commits but I realized later I accidentally changed public headers, so I reverted the later commits and the final state should be identical to the first commit.
Of course, I might have made a mistake, I can check this later.

@mattcaswell  still OK?

This pull request is ready to merge

Merged to master. Thank you for the contribution!

source: gharchive/pull-request

authors: arminfuerst openssl-machine paulidale slontis t8m

repo: openssl/openssl

license_type: permissive

license_source: github-api


text:
Add explicit HTTP(S) proxy support to ocsp and s_server apps

This adds the -proxy and -no_proxy options to the ocsp and s_server apps,
as well as documentation for them.
Since PR #10667 (commit 29f178bddfdbd11218fbcba0b8060297696968e3), both apps were already implicitly supporting the use of HTTP(S) proxies, triggered via the http_proxy etc. environment variables.
This is strongly related to feature request #6965 and possibly even fixes it.
Checklist

[x] documentation is added or updated
[ ] tests are added or updated

sanitizers CI failure of 90-test_threads.t must be unrelated.

I wonder if this is really needed. Isn't the environment variable support sufficient? The s_server and ocsp apps are just debugging and developer tools anyway.

The sanitizers CI failure of 90-test_threads.t must be unrelated.

Yes #15243

I wonder if this is really needed. Isn't the environment variable support sufficient?
The s_server and ocsp apps are just debugging and developer tools anyway.

Even then it may be useful, and adding explicit support for it is straightforward.
And the OpenSSL apps are generally used also as a model of how to use the API.

Can this be approved now?

This pull request is ready to merge

Merged - thanks @t8m

authors: DDvO openssl-machine t8m


text:
CI windows.yml: Silence 'nmake' builds

In analogy to the Unix-based CI tests, add /S to the Windows-based builds.

Approved if CI passes.

This was quick - it will :smile:

Frankly, I would like to see one build-only verbose job.  It's a pain having to re-run the builds on your own hardware because you can't see all the fine details in the github action runs...

Frankly, I would like to see one build-only verbose job. It's a pain having to re-run the builds on your own hardware because you can't see all the fine details in the github action runs...

Good point.
Since there all compiler invocations are essentially the same, it should be sufficient to see one of them.
How about making therefore the minimal build verbose (again), both for Windows and Linux?

Verbose minimal builds would be okay.

As discussed, made minimal builds verbose for both Unix and Windows.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged.

authors: DDvO levitte openssl-machine paulidale


text:
Fix checking return code of EVP_PKEY_get_int_param at check_curve

According to docs, EVP_PKEY_get_int_param should return 1 on Success, and 0 on Failure. So, fix checking of this return value at check_curve
CLA: trivial

Merged to master, 3.1, and 3.0 branches. Thank you for your contribution.


text:
Rearrange some CI jobs

Those less useful should be in daily or on-push runs.
Those more likely triggering CI failure that do not take too much time should be in main on pull request CI.

This can go into the 3.2 branch as well.

To be clear, on-push runs trigger only on-push to certain branches (master, openssl-3.x, etc), correct?

To be clear, on-push runs trigger only on-push to certain branches (master, openssl-3.x, etc), correct?

They run on push to any branch that contains the workflow yml file. I.e., if you have enabled GH actions on your forked openssl repo, they will run when you push to any branch there. But you can of course disable these workflows individually in your repo GH actions configuration.

Fixup to fix the no-stdio runchecker job was pushed. Still OK?

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged to the master and 3.2 branches. Thank you for the reviews.

authors: nhorman openssl-machine t8m


text:
rsa-doc: fix typo

change "d_i in RFC8017" to "d_i" in RFC8017

Checklist

[ x] documentation is added or updated

Merged to the master, 3.2, 3.1, and 3.0 branches. Thank you.


text:
Nameopt fixes

This pull request unifies -nameopt flag processing in command-line apps and reduces usage of the X509_NAME_online function.

@beldmit look at the travis failures; you need a declaration in apps.h or such.

Fixed now.

Great, just need another reviewer and I'll merge.

I provided support and test for Unicode output in crl -text command. Could you please review it again?

In fact the -nameopt key was documented for the crl utility. It just did not work in case of -text option.

I meant the new API for CRL print

I'm afraid not because the old API seems to be undocumented too...

sigh.  okay.  still approved by me...

@beldmit, thanks for your work to help make openssl more language-neutral! commit b5c4209.

authors: beldmit richsalz


text:
manpages: fix manual section order [1.1.1]

This is a cherry-pick of the pull requests #8338 and #8729 (see https://github.com/openssl/openssl/pull/8729#issuecomment-482598419 and ff.).
Two commits had conflicts which were resolved as follows:

cd32530ea55a08fc936699f157ca629bb0befe3d:  two files did not exist yet in 1.1.1. Their changes were discarded.

0f270269afc1550bc70e757daba64075763543d2 two RAND_DRBG_* pod-files contained modifications in the HISTORY sections being swapped. These changes were discarded, only the sections were swapped.

Editorial note: Since the commits are only cherry-picks with trivially resolved conflicts, I intend to preserve the Reviewed-by: and Merged from markers from the original pull requests and not add any additional reference to this pull request here. In other words, I won't change the commit message anymore when merging.

The last force-push only affected the commit messages from #8729: I had forgotten to cherry-pick with the -x option.

I intend to preserve the Reviewed-by: and Merged from markers from the original pull requests

IMO that is incorrect. The "Reviewed-by" and "Merged from" headers should be for the specific PR used. That will lead people to this PR, which itself is linked to the original PR.

Approved subject to the headers being amended as I note above.

I intend to preserve the Reviewed-by: and Merged from markers from the original pull requests

IMO that is incorrect. The "Reviewed-by" and "Merged from" headers should be for the specific PR used. That will lead people to this PR, which itself is linked to the original PR.

Ok, convinced.

Merged, thanks!
1ced49fbb7 Further harmonisation of manual page HISTORY sections
18bad53564 Update various man pages to place HISTORY section after SEE ALSO
3b01f353b8 Add a check for history section location to find-doc-nits
32a775df9b Make check_example_location() in find-doc-nits generic
a345fa370e Add section order check in util/find-doc-nits
d090fc0019 Place return values after examples in doc

authors: mattcaswell mspncp


text:
Setting SERVICE_HOST breaks etcd v3.2.

Make --listen-client-urls use $HOST_IP
See 3.2 changelog: https://github.com/etcd-io/etcd/blob/master/Documentation/upgrades/upgrade_3_2.md#change-in---listen-peer-urls-and---listen-client-urls

Thank you for contributing to openstack-dev/devstack!
openstack-dev/devstack uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.

authors: colin-campbell openstack-gerrit

repo: openstack-dev/devstack

license_source: bigquery


text:
Toggle nolog to true for architecture deploy

It was set to false for debugging purpose, and never got back to true
As a pull request owner and reviewers, I checked that:

[X] Appropriate testing is done and actually running

/approve
/lgtm

authors: cjeanner pablintino


text:
Left Sidebar shortcut

Despite many tests with the '`' key, I can't open the left sidebar with shortcut. I'm on a azerty (french) mac keyboard. Those keyboards neither have a "²" key.
Is it possible to add a universal key for that very important action ?

@hugobqd Thanks for reporting. What key is to the left of the number row? Is it #?

@quincylvania Precisely that's the @, you must add caps key to get #.
https://store.storeimages.cdn-apple.com/4668/as-images.apple.com/is/mbp13touch-space-select-201807_GEO_EMEA_LANG_FR?wid=1892&hei=1820&&qlt=80&.v=1531167628616

source: gharchive/issue

authors: hugobqd quincylvania

repo: openstreetmap/iD

license: ISC


text:
support unsigned_ref

Some people love adding officially assigned road numbers that are not signposted (or are marked with signs that are invisible to drivers).
We have https://wiki.openstreetmap.org/wiki/Key:unsigned_ref for that.
Sadly, some people add it using ref tag, even to roads already tagged with correct unsigned_ref.
I propose to add it as "Road number without reassurance marker" or "Road number not listed on traffic signs" or "Unsigned road number"
See https://www.openstreetmap.org/note/2390078 https://www.openstreetmap.org/changeset/92378423 for example of case where iD mapper added ref tag that now needs to be removed.

What on earth is a "reassurance marker"?! I've never heard this term used before. Perhaps just use "Road number not shown on signs". Could also use "displayed" instead of "shown".

reassurance marker

I also never heard this term earlier, but meaning was obvious from context.
See https://en.wikipedia.org/wiki/Reassurance_marker

A reassurance marker or confirming marker is a type of traffic sign that confirms the identity of the route being traveled without providing information found on other types of road signs, such as distances traveled as is done by highway location markers, distances to other locations or upcoming intersections.

Note that sometimes unsigned_ref are posted but effectively invisible (in my area there are posted as small markers, with text about 3 cm high - utterly invisible to any driver, even cyclist would be unable to read it)

Some people love adding officially assigned road numbers that are not signposted (or are marked with signs that are invisible to drivers).

This is not a good place for this discussion, but I must say I find the unsigned_ref key very... um, badly designed.
A reference number is a reference number, signposted or not. Nowhere in the ref documentation it is stated that it has to be signposted. (And indeed, low-ranked roads across Europe seldom are). If it is desirable to indicate whether reassurance markers exist, something like ref:signposted=yes could have been used, not inventing a whole different key. Plus, there's always the rendering issue -- I don't see why unmarked roads would be rendered differently from the marked roads.

I would be happy to discuss it elsewhere (tagging mailing list, OSM Telegram channel, US Slack, Polish forum), but main use of this tag is to handle refs that are technically assigned but nooone is actually using them.
For example 1503L from https://www.openstreetmap.org/way/813282360 is utterly pointless and useless and exists only in some hidden documentation. It is fundamentally distinct from say ref=48 on https://www.openstreetmap.org/way/32280482 that is used, recognised and useful.

Tagging quibbles aside, what do you expect from iD in this case? unsigned_ref is IMO not so frequently used to justify its addition into the default highway preset. If one adds it manually, it is correctly recognized and linked to the wiki page:

The only thing that does not work is finding it manually from the "Add field" drop-down, but even then one has to know in advance that it exists and what it means.

what do you expect from iD in this case?

To display it as a field, not just in raw tag list - AFAIK typical iD is designed with expectation that normal user does not need to see raw tag values.

The only thing that does not work is finding it manually from the "Add field" drop-down

What is also not working is displaying this tag if tagged already. This would help to reduce needless adding it also as ref

Maybe adding a checkbox like "Signposted" to the "Road number" field would work best.

authors: DujaOSM RobJN matkoniecz rmikke


text:
fix bug swoole/swoole-src#4676

This PR is backporting of swoole/swoole-src#4682

@smortexa Could you rebase master changes?

authors: doubaokun smortexa

repo: openswoole/swoole-src


text:
FTP data pending for 22.06

As reported by a user in community, the 22.06 data is not yet available in the EBI FTP.
ls /ebi/ftp/pub/databases/opentargets/platform
...
drwxr-sr-x 6 otftpuser opent 4.0K Nov 24  2021 21.11
drwxr-sr-x 7 otftpuser opent 4.0K Mar  2 02:05 22.02
drwxrwsr-x 7 otftpuser opent 4.0K May  4 01:21 22.04
lrwxrwxrwx 1 mbernal   opent    5 May  5 04:59 latest -> 22.04

Data sync has run from the bucket to the internal file system behind the EBI FTP service, and I'm afraid that we have a problem.
Google Cloud reports 1.3TiB of data, while both the internal file system and EBI FTP service only report 910GiB, I need to follow this up with the TSC.

The release data is now available at ftp://ftp.ebi.ac.uk:/pub/databases/opentargets/platform/22.06

repo: opentargets/issues


text:
Creating Manifest file might be interrupted

Describe the bug
If an error happens here in the make_paths_relative(), manifest.json file will be empty.
Expected behaviour
The manifest file should be created correctly in any case even if the program ends with an error.
To Reproduce
Handle the possible errors when calling make_paths_relative() .

Actually I realised it, when this error happened.

We already have os.path, we need to make sure we use that so no pathlib objects are leaked into manifest paths, which are expected to be strings.
I would recommend refactoring the code that uses pathlib to use os.path.join operations instead


text:
Genetics app build failing due to AutocompleteSearch removal

Error:
genetics:dev:   ✘ [ERROR] No matching export in "../../packages/ui/src/index.tsx" for import "AutocompleteSearch"
genetics:dev:
genetics:dev:     src/pages/HomePage/HomePage.tsx:15:17:
genetics:dev:       15 │ import { Footer, AutocompleteSearch } from 'ui';

This is due to #266 removing AutocompleteSearch

Thanks @riyavsinha. Fixed in this PR #270 also Netlify checks/builds working back 🚀

authors: carcruz riyavsinha

repo: opentargets/ot-ui-apps


text:
feat(opa): Adding jq OPA builtin for selection

Add an opa builtin for gojq to query the entity object provided by the idp or the jwt with the subject_external_selector_value query string
references https://github.com/opentdf/platform/issues/470

@elizabethhealy Should we be building a builtin for jq or should it be for subject mappings?

@strantalis the subject mapping evaluation takes place in the rego currently, this is just to retrieve the selected field in the jwt/entity obj per https://github.com/opentdf/platform/issues/470

@elizabethhealy We want the subject mapping logic to also take place behind a builtin function as well. Someone that provides a custom opa bundle with modified rego shouldn't modify the mapping logic imo.

@strantalis ok that makes sense, i just read through the adr https://github.com/opentdf/platform/issues/472, we can open a separate issue when the adr is resolved to encompass that work (it will overwrite some of this work), but in the meantime can we merge this in to unblock downstream users since the other jq spec changes were already made?

@ttschampel @jrschumacher @biscoe916 Can you give this a review.

I'm ok approving this to move forward and start work on #567 and get things aligned with #472

thanks @ttschampel, already getting started on the third bullet under #567

authors: elizabethhealy strantalis ttschampel

repo: opentdf/platform


text:
Pre staging

Added date and math tasks by @bkb2135  in #88
Improved dataset and context structure by @steffencruz  in #109
Enhanced neuron logging by @steffencruz  in #108
Added mock utilities to unit tests by @steffencruz  in #107
Fixed typos in README by @dougsillars  in #105
Implemented decay score by @steffencruz  in #111

Tracked experiment: https://wandb.ai/opentensor-dev/alpha-validators/runs/y78dnu4y/overview?workspace=user-opentensor-steffen
Acceptance criteria:

Each task has the same occurrence rate (25% for all four tasks)
Each task has stable rewards distribution
Rewards for both old and new tasks are consistent with other validators over same time period
Status codes are nominal and consistent with other validators over same time period

repo: opentensor/prompting

license: MIT


text:
Increasing the adjustment interval from 135 to 150

Increase adjustmentInterval to 150
Abstract
This recommends an increase of adjustmentInterval from 135 blocks to 150 blocks.
Motivation
A continuation of #35, the increase in adjustInterval saw a drop in immunity peers. However, within the past two weeks, the number of immune peers have risen once again from 280 -> 306. To compensate for the increase in immune peers, we should preempt issues that we saw before and increase the adjustInterval slightly.
Specification
Param: adjustInterval
Initial Value: 135
Suggested Value: 150
Time of Effect: 12 December 2022 (projected)

Sudo at block: 2,901,519

authors: Eugene-hu unconst

repo: opentensor/subtensor

license: Unlicense


text:
[mlr] fix multicast group re-register after bbr restarting.

After BBR restarting, in order to receive the packets from multicast group, the devices, which have registered multicast group addresses to that BBR, needs to re-register these groups.
In this PR, a member variable mRecordedSequenceNumber is added to record the BBR's sequence number, if the BBR's sequence number has changed,  all registered groups would be re-registered.

I think we have already implemented this feature in MlrManager::Reregister, which can be triggered when BBR sequence number changes.

Reregister

I think we have already implemented this feature in MlrManager::Reregister, which can be triggered when BBR sequence number changes.

Hi @simonlingoogle , In the original logic, when BBR restart, other devices should wait for  MLR Timeout (300s), then re-registered. In this PR,  Once detected BBR changed or restarted, other devices handle re-registeration immediately.

I think we have already implemented this feature in MlrManager::Reregister, which can be triggered when BBR sequence number changes.

Hi @simonlingoogle , In the original logic, when BBR restart, other devices should wait for MLR Timeout (300s), then re-registered. In this PR, Once detected BBR changed or restarted, other devices handle re-registeration immediately.

When the BBR sequence number change, the re-registration delay would be Random::NonCrypto::GetUint16InRange(1, config.mReregistrationDelay), which is inline with the Thread spec.
See https://github.com/openthread/openthread/blob/0a41196540044d074bc8d68c666d3efb6c66e0fc/src/core/thread/mlr_manager.cpp#L651-L656

I think we have already implemented this feature in MlrManager::Reregister, which can be triggered when BBR sequence number changes.

Hi @simonlingoogle , In the original logic, when BBR restart, other devices should wait for MLR Timeout (300s), then re-registered. In this PR, Once detected BBR changed or restarted, other devices handle re-registeration immediately.

When the BBR sequence number change, the re-registration delay would be Random::NonCrypto::GetUint16InRange(1, config.mReregistrationDelay), which is inline with the Thread spec.
See
https://github.com/openthread/openthread/blob/0a41196540044d074bc8d68c666d3efb6c66e0fc/src/core/thread/mlr_manager.cpp#L651-L656

I think the reregDelay in mlr_manager.cpp#L651-L656 is used for maintaining registered groups timing out, which is defined in spec 5.24.2.3.2. For the scenario related in this PR, when BBR restarted, some definitions with BBR sequence number updating is related in 5.21.4.2, the spec just defined Any change of the BBR Sequence Number should trigger Thread Devices to perform reregistration. I think in this scenario, Thread Devices should re-register as soon as possible. If followed the current logic, in the worst case, Thread Devices might wait almost 1 hour to re-register.

For the scenario related in this PR, when BBR restarted, some definitions with BBR sequence number updating is related in 5.21.4.2, the spec just defined Any change of the BBR Sequence Number should trigger Thread Devices to perform reregistration. I think in this scenario, Thread Devices should re-register as soon as possible. If followed the current logic, in the worst case, Thread Devices might delay almost 1 hour to re-register.

I think the Reregistration Delay is for this very purpose (see 5.21.3.2)
Thoughts? @jwhui

Reregistration Delay should be respected.

Okay, I know what you mean, should we decrease the default reregisteration Delay(which default value is 1200, it seems to large)?

Okay, I know what you mean, should we decrease the default reregisteration Delay(which default value is 1200, it seems to large)?

Agree that 1200s is too large for typical networks.
Changing the default value from a Thread Spec's perspective might be difficult, but I think we can make it configurable in OpenThread. Or you can simply set BBR dataset in production code using otBackboneRouterSetConfig.

Okay, I know what you mean, should we decrease the default reregisteration Delay(which default value is 1200, it seems to large)?

Agree that 1200s is too large for typical networks.
Changing the default value from a Thread Spec's perspective might be difficult, but I think we can make it configurable in OpenThread. Or you can simply set BBR dataset in production code using otBackboneRouterSetConfig.

The default 1200s seems not defined by spec. Per spec 5.21.3.3, the Reregistration Delay value is vendor-specific, the range is (1 - 0.5 * MLR_Timeout) in seconds.
How about reducing the default Reregistration Delay valude in openthread to some small value (like 5)? Which should be accepted by most production users.

The default 1200s seems not defined by spec. Per spec 5.21.3.3, the Reregistration Delay value is vendor-specific, the range is (1 - 0.5 * MLR_Timeout) in seconds.

Thanks for the info.

How about reducing the default Reregistration Delay value in openthread to some smaller value (like 5)? Which should be accepted by most production users.

+1 for reducing default reregistration delay.

authors: chshu simonlingoogle zwx1995esp

repo: openthread/openthread


text:
Windows otLwf Tunnel Mode

This updates the NDIS filter driver otLwf to support both miniports that expose simple radio devices and miniports that support full Thread stack devices. In 'Tunnel mode' otLwf uses the Spinel interface to encode/decode the commands to be sent/received to/from the miniport that the miniport then will use to talk to the actual full Thread stack device.
This change also includes a few clean ups that are mostly unrelated.

@darconeous I'd appreciate a close review of iocontrol.c and tunnel.c. Those are the files that actually do the spinel related logic for the most part. Unfortunately, GitHub claims iocontrol.c is too big so you have to look at the changes manually.

Thanks for the heads up, I'll have a look.

Current coverage is 74.60% (diff: 100%)

Merging #984 into master will increase coverage by 0.05%

@@             master       #984   diff @@
==========================================
  Files           123        123
  Lines         17719      17719
  Methods        2483       2483
  Messages          0          0
  Branches       2134       2134
==========================================
+ Hits          13210      13220    +10
+ Misses         3842       3833     -9
+ Partials        667        666     -1

Powered by Codecov. Last update 257e418...0c512ba

Quick heads up: I've got some big deliverables due this week so it might take a few days before I can find the time to fully review both files. That being said, it's on my plate now, so I'll try to get to it as quickly as I can.

Any chance of getting a review for this (and my other PRs) soon? I'd like to get all the changes for OpenThread on Host working on the TI device in the next week or two.

Thanks a lot for the review of those files. I believe I have addressed all your comments.

I'm not sure how my latest commit could have caused so many Travis failures. Could you try restarting that Job and see if they go away?

authors: codecov-io darconeous nibanks


text:
sessionConnected event not passing connection info

If you want a successful video chat experience, you'll likely need to grab your connection id to make sure you don't send signals to yourself etc. Unless you know a better/preferred way of getting your own connection id I would suggest adding this functionality to the 'sessionConnected' function in opentok.js
Something like this works
  TBSession.prototype.sessionConnected = function(event) {
    var sessionConnectedEvent;
    pdebug("sessionConnectedHandler", event);
    this.connection = new TBConnection(event.connection);
    this.connections[event.connection.connectionId] = this.connection;
    sessionConnectedEvent = new TBEvent({
      connection: this.connection
    });
    this.trigger("sessionConnected", sessionConnectedEvent);
    return this;
  };

Currently nothing is returned on the sessionConnected event
Cheers
Lewis

According to the SessionConnectedEvent documentation these values are deprecated in the JS SDK, so it does not seem likely to add this in the plugin:
https://tokbox.com/developer/sdks/js/reference/SessionConnectEvent.html

Deprecated in version 2.2 (and set to an empty array). In version 2.2, listen for the connectionCreated event dispatched by the Session object. In version 2.2, the Session object dispatches a connectionCreated event for each connection (including your own). This includes connections present when you first connect to the session.
I see, I guess using the connectionCreated event will require you to better 'keep track' of your own connection id. I'm sure there is method behind tokbox getting rid of the SessionConnected event, though personally I don't see the point.

authors: ljr-gloversure mark-veenstra

repo: opentok/cordova-plugin-opentok


text:
Skip pattern from web instrumentation could not be instantiatized

I have updated web instrumentation to the latest in #212 and now I am getting the following exception in  instrumentation-starters/zull. The change is likely related to https://github.com/opentracing-contrib/java-spring-web/pull/100
@ask4gilles @geoand could you please have a look at it?
java.lang.IllegalStateException: Failed to load ApplicationContext

	at org.springframework.test.context.cache.DefaultCacheAwareContextLoaderDelegate.loadContext(DefaultCacheAwareContextLoaderDelegate.java:125)
	at org.springframework.test.context.support.DefaultTestContext.getApplicationContext(DefaultTestContext.java:108)
	at org.springframework.test.context.support.DependencyInjectionTestExecutionListener.injectDependencies(DependencyInjectionTestExecutionListener.java:118)
	at org.springframework.test.context.support.DependencyInjectionTestExecutionListener.prepareTestInstance(DependencyInjectionTestExecutionListener.java:83)
	at org.springframework.boot.test.autoconfigure.SpringBootDependencyInjectionTestExecutionListener.prepareTestInstance(SpringBootDependencyInjectionTestExecutionListener.java:44)
	at org.springframework.test.context.TestContextManager.prepareTestInstance(TestContextManager.java:246)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.createTest(SpringJUnit4ClassRunner.java:227)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner$1.runReflectiveCall(SpringJUnit4ClassRunner.java:289)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.methodBlock(SpringJUnit4ClassRunner.java:291)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:246)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:97)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
	at org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:190)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
Caused by: org.springframework.context.ApplicationContextException: Unable to start web server; nested exception is org.springframework.boot.web.server.WebServerException: Unable to start embedded Tomcat
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.onRefresh(ServletWebServerApplicationContext.java:157)
	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:543)
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:142)
	at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:775)
	at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:397)
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:316)
	at org.springframework.boot.test.context.SpringBootContextLoader.loadContext(SpringBootContextLoader.java:127)
	at org.springframework.test.context.cache.DefaultCacheAwareContextLoaderDelegate.loadContextInternal(DefaultCacheAwareContextLoaderDelegate.java:99)
	at org.springframework.test.context.cache.DefaultCacheAwareContextLoaderDelegate.loadContext(DefaultCacheAwareContextLoaderDelegate.java:117)
	... 25 more
Caused by: org.springframework.boot.web.server.WebServerException: Unable to start embedded Tomcat
	at org.springframework.boot.web.embedded.tomcat.TomcatWebServer.initialize(TomcatWebServer.java:125)
	at org.springframework.boot.web.embedded.tomcat.TomcatWebServer.<init>(TomcatWebServer.java:86)
	at org.springframework.boot.web.embedded.tomcat.TomcatServletWebServerFactory.getTomcatWebServer(TomcatServletWebServerFactory.java:427)
	at org.springframework.boot.web.embedded.tomcat.TomcatServletWebServerFactory.getWebServer(TomcatServletWebServerFactory.java:180)
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.createWebServer(ServletWebServerApplicationContext.java:181)
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.onRefresh(ServletWebServerApplicationContext.java:154)
	... 33 more
Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'io.opentracing.contrib.spring.web.starter.ServerTracingAutoConfiguration': Unsatisfied dependency expressed through constructor parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'skipPattern' defined in class path resource [io/opentracing/contrib/spring/web/starter/SkipPatternAutoConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [java.util.regex.Pattern]: Factory method 'skipPattern' threw exception; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.cloud.client.CommonsClientAutoConfiguration$ActuatorConfiguration': Unsatisfied dependency expressed through field 'hasFeatures'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.cloud.netflix.zuul.ZuulProxyAutoConfiguration': Unsatisfied dependency expressed through field 'configurers'; nested exception is org.springframework.beans.factory.BeanCurrentlyInCreationException: Error creating bean with name 'io.opentracing.contrib.spring.web.starter.ServerTracingAutoConfiguration': Requested bean is currently in creation: Is there an unresolvable circular reference?
	at org.springframework.beans.factory.support.ConstructorResolver.createArgumentArray(ConstructorResolver.java:769)
	at org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:218)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.autowireConstructor(AbstractAutowireCapableBeanFactory.java:1341)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1187)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:555)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:515)
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:320)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:318)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:199)
	at org.springframework.beans.factory.support.ConstructorResolver.instantiateUsingFactoryMethod(ConstructorResolver.java:392)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateUsingFactoryMethod(AbstractAutowireCapableBeanFactory.java:1321)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1160)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:555)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:515)
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:320)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:318)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:204)
	at org.springframework.boot.web.servlet.ServletContextInitializerBeans.getOrderedBeansOfType(ServletContextInitializerBeans.java:235)
	at org.springframework.boot.web.servlet.ServletContextInitializerBeans.getOrderedBeansOfType(ServletContextInitializerBeans.java:226)
	at org.springframework.boot.web.servlet.ServletContextInitializerBeans.addServletContextInitializerBeans(ServletContextInitializerBeans.java:101)
	at org.springframework.boot.web.servlet.ServletContextInitializerBeans.<init>(ServletContextInitializerBeans.java:88)
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.getServletContextInitializerBeans(ServletWebServerApplicationContext.java:261)
	at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.selfInitialize(ServletWebServerApplicationContext.java:234)
	at org.springframework.boot.web.embedded.tomcat.TomcatStarter.onStartup(TomcatStarter.java:54)
	at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5139)
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1377)
	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1367)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
	at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:902)
	at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:831)
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1377)
	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1367)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at org.apache.tomcat.util.threads.InlineExecutorService.execute(InlineExecutorService.java:75)
	at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:134)
	at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:902)
	at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:262)
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
	at org.apache.catalina.core.StandardService.startInternal(StandardService.java:423)
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
	at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:928)
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
	at org.apache.catalina.startup.Tomcat.start(Tomcat.java:455)
	at org.springframework.boot.web.embedded.tomcat.TomcatWebServer.initialize(TomcatWebServer.java:106)
	... 38 more
Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'skipPattern' defined in class path resource [io/opentracing/contrib/spring/web/starter/SkipPatternAutoConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [java.util.regex.Pattern]: Factory method 'skipPattern' threw exception; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.cloud.client.CommonsClientAutoConfiguration$ActuatorConfiguration': Unsatisfied dependency expressed through field 'hasFeatures'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.cloud.netflix.zuul.ZuulProxyAutoConfiguration': Unsatisfied dependency expressed through field 'configurers'; nested exception is org.springframework.beans.factory.BeanCurrentlyInCreationException: Error creating bean with name 'io.opentracing.contrib.spring.web.starter.ServerTracingAutoConfiguration': Requested bean is currently in creation: Is there an unresolvable circular reference?
	at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:627)
	at org.springframework.beans.factory.support.ConstructorResolver.instantiateUsingFactoryMethod(ConstructorResolver.java:456)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateUsingFactoryMethod(AbstractAutowireCapableBeanFactory.java:1321)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1160)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:555)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:515)
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:320)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:318)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:199)
	at org.springframework.beans.factory.config.DependencyDescriptor.resolveCandidate(DependencyDescriptor.java:277)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1247)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1167)
	at org.springframework.beans.factory.support.ConstructorResolver.resolveAutowiredArgument(ConstructorResolver.java:857)
	at org.springframework.beans.factory.support.ConstructorResolver.createArgumentArray(ConstructorResolver.java:760)
	... 87 more
Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [java.util.regex.Pattern]: Factory method 'skipPattern' threw exception; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.cloud.client.CommonsClientAutoConfiguration$ActuatorConfiguration': Unsatisfied dependency expressed through field 'hasFeatures'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.cloud.netflix.zuul.ZuulProxyAutoConfiguration': Unsatisfied dependency expressed through field 'configurers'; nested exception is org.springframework.beans.factory.BeanCurrentlyInCreationException: Error creating bean with name 'io.opentracing.contrib.spring.web.starter.ServerTracingAutoConfiguration': Requested bean is currently in creation: Is there an unresolvable circular reference?
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:185)
	at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:622)
	... 101 more
Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.cloud.client.CommonsClientAutoConfiguration$ActuatorConfiguration': Unsatisfied dependency expressed through field 'hasFeatures'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.cloud.netflix.zuul.ZuulProxyAutoConfiguration': Unsatisfied dependency expressed through field 'configurers'; nested exception is org.springframework.beans.factory.BeanCurrentlyInCreationException: Error creating bean with name 'io.opentracing.contrib.spring.web.starter.ServerTracingAutoConfiguration': Requested bean is currently in creation: Is there an unresolvable circular reference?
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:596)
	at org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:90)
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessProperties(AutowiredAnnotationBeanPostProcessor.java:374)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1411)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:592)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:515)
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:320)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:318)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:199)
	at org.springframework.beans.factory.support.ConstructorResolver.instantiateUsingFactoryMethod(ConstructorResolver.java:392)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateUsingFactoryMethod(AbstractAutowireCapableBeanFactory.java:1321)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1160)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:555)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:515)
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:320)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:318)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:199)
	at org.springframework.context.support.AbstractApplicationContext.getBean(AbstractApplicationContext.java:1105)
	at org.springframework.boot.actuate.endpoint.annotation.EndpointDiscoverer.createEndpointBean(EndpointDiscoverer.java:149)
	at org.springframework.boot.actuate.endpoint.annotation.EndpointDiscoverer.createEndpointBeans(EndpointDiscoverer.java:136)
	at org.springframework.boot.actuate.endpoint.annotation.EndpointDiscoverer.discoverEndpoints(EndpointDiscoverer.java:125)
	at org.springframework.boot.actuate.endpoint.annotation.EndpointDiscoverer.getEndpoints(EndpointDiscoverer.java:119)
	at io.opentracing.contrib.spring.web.starter.SkipPatternAutoConfiguration$ActuatorSkipPatternProviderConfig.getEndpointsPatterns(SkipPatternAutoConfiguration.java:92)
	at io.opentracing.contrib.spring.web.starter.SkipPatternAutoConfiguration$ActuatorSkipPatternProviderConfig.lambda$skipPatternForActuatorEndpointsSamePort$1(SkipPatternAutoConfiguration.java:127)
	at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
	at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1382)
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
	at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
	at io.opentracing.contrib.spring.web.starter.SkipPatternAutoConfiguration.skipPattern(SkipPatternAutoConfiguration.java:58)
	at io.opentracing.contrib.spring.web.starter.SkipPatternAutoConfiguration$$EnhancerBySpringCGLIB$$921087b1.CGLIB$skipPattern$0(<generated>)
	at io.opentracing.contrib.spring.web.starter.SkipPatternAutoConfiguration$$EnhancerBySpringCGLIB$$921087b1$$FastClassBySpringCGLIB$$7810c242.invoke(<generated>)
	at org.springframework.cglib.proxy.MethodProxy.invokeSuper(MethodProxy.java:244)
	at org.springframework.context.annotation.ConfigurationClassEnhancer$BeanMethodInterceptor.intercept(ConfigurationClassEnhancer.java:363)
	at io.opentracing.contrib.spring.web.starter.SkipPatternAutoConfiguration$$EnhancerBySpringCGLIB$$921087b1.skipPattern(<generated>)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:154)
	... 102 more
Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.springframework.cloud.netflix.zuul.ZuulProxyAutoConfiguration': Unsatisfied dependency expressed through field 'configurers'; nested exception is org.springframework.beans.factory.BeanCurrentlyInCreationException: Error creating bean with name 'io.opentracing.contrib.spring.web.starter.ServerTracingAutoConfiguration': Requested bean is currently in creation: Is there an unresolvable circular reference?
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:596)
	at org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:90)
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessProperties(AutowiredAnnotationBeanPostProcessor.java:374)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1411)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:592)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:515)
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:320)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:318)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:199)
	at org.springframework.beans.factory.support.ConstructorResolver.instantiateUsingFactoryMethod(ConstructorResolver.java:392)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateUsingFactoryMethod(AbstractAutowireCapableBeanFactory.java:1321)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1160)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:555)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:515)
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:320)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:318)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:199)
	at org.springframework.beans.factory.config.DependencyDescriptor.resolveCandidate(DependencyDescriptor.java:277)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.addCandidateEntry(DefaultListableBeanFactory.java:1463)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.findAutowireCandidates(DefaultListableBeanFactory.java:1427)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveMultipleBeans(DefaultListableBeanFactory.java:1318)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1205)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1167)
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:593)
	... 145 more
Caused by: org.springframework.beans.factory.BeanCurrentlyInCreationException: Error creating bean with name 'io.opentracing.contrib.spring.web.starter.ServerTracingAutoConfiguration': Requested bean is currently in creation: Is there an unresolvable circular reference?
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.beforeSingletonCreation(DefaultSingletonBeanRegistry.java:339)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:215)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:318)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:199)
	at org.springframework.beans.factory.support.ConstructorResolver.instantiateUsingFactoryMethod(ConstructorResolver.java:392)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateUsingFactoryMethod(AbstractAutowireCapableBeanFactory.java:1321)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1160)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:555)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:515)
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:320)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:318)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:199)
	at org.springframework.beans.factory.config.DependencyDescriptor.resolveCandidate(DependencyDescriptor.java:277)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.addCandidateEntry(DefaultListableBeanFactory.java:1463)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.findAutowireCandidates(DefaultListableBeanFactory.java:1427)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveMultipleBeans(DefaultListableBeanFactory.java:1318)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1205)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1167)
	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:593)
	... 170 more

The issue is here
https://github.com/opentracing-contrib/java-spring-web/blob/master/opentracing-spring-web-starter/src/main/java/io/opentracing/contrib/spring/web/starter/SkipPatternAutoConfiguration.java#L92

Error creating bean with name 'org.springframework.cloud.client.CommonsClientAutoConfiguration$ActuatorConfiguration': Unsatisfied dependency expressed through field 'hasFeatures'

@pavolloffay @geoand I'm on it.

Cool, I'm on PTO so I won't be able to check it for a few days.
On Thu, May 2, 2019, 15:55 Gilles Robert notifications@github.com wrote:

@pavolloffay https://github.com/pavolloffay @geoand
https://github.com/geoand I'm on it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/opentracing-contrib/java-spring-cloud/issues/219#issuecomment-488682781,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABBMDPYYYXY2QK4YTGO7NRDPTLXDHANCNFSM4HJ57UKQ
.

@pavolloffay fixed by linked issue in web.

thanks @ask4gilles I have merged and cut 2.1.0

For anyone that is still having this issue, for me to solve it I had to add this to my application config.
opentracing.spring.web.ignoreAutoConfiguredSkipPatterns: true

@robinator8 That didn't solve my problem;
00:57:40.720 [Thread-0] DEBUG org.springframework.boot.devtools.restart.classloader.RestartClassLoader - Created RestartClassLoader org.springframework.boot.devtools.restart.classloader.RestartClassLoader@30a0321c

  .   ____          _            __ _ _
 /\\ / ___'_ __ _ _(_)_ __  __ _ \ \ \ \
( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \
 \\/  ___)| |_)| | | | | || (_| |  ) ) ) )
  '  |____| .__|_| |_|_| |_\__, | / / / /
 =========|_|==============|___/=/_/_/_/
 :: Spring Boot ::                (v2.6.4)

2022-05-03 00:57:42,587 | INFO  n.o.koop.plooi.dcn.PlooiDcnApplication   - Starting PlooiDcnApplication using Java 11.0.11 on DESKTOP-1642TS0 with PID 16976 (C:\00_KOOP\ws\plooi-dcn\dcn-application\target\classes started by divil in C:\00_KOOP\ws\plooi-dcn\dcn-application)
2022-05-03 00:57:42,588 | DEBUG n.o.koop.plooi.dcn.PlooiDcnApplication   - Running with Spring Boot v2.6.4, Spring v5.3.16
2022-05-03 00:57:42,589 | INFO  n.o.koop.plooi.dcn.PlooiDcnApplication   - The following 1 profile is active: "dev"
2022-05-03 00:57:42,695 | INFO  o.s.boot.devtools.restart.ChangeableUrls - The Class-Path manifest attribute in C:\Users\divil\.m2\repository\com\sun\xml\bind\jaxb-core\2.3.0\jaxb-core-2.3.0.jar referenced one or more files that do not exist: file:/C:/Users/divil/.m2/repository/com/sun/xml/bind/jaxb-core/2.3.0/jaxb-api.jar
2022-05-03 00:57:42,695 | INFO  o.s.boot.devtools.restart.ChangeableUrls - The Class-Path manifest attribute in C:\Users\divil\.m2\repository\com\mchange\c3p0\0.9.5.5\c3p0-0.9.5.5.jar referenced one or more files that do not exist: file:/C:/Users/divil/.m2/repository/com/mchange/c3p0/0.9.5.5/mchange-commons-java-0.2.19.jar
2022-05-03 00:57:42,696 | INFO  .e.DevToolsPropertyDefaultsPostProcessor - Devtools property defaults active! Set 'spring.devtools.add-properties' to 'false' to disable
2022-05-03 00:57:42,696 | INFO  .e.DevToolsPropertyDefaultsPostProcessor - For additional web related logging consider setting the 'logging.level.web' property to 'DEBUG'
2022-05-03 00:57:46,798 | INFO  .s.d.r.c.RepositoryConfigurationDelegate - Bootstrapping Spring Data JPA repositories in DEFAULT mode.
2022-05-03 00:57:47,303 | INFO  .s.d.r.c.RepositoryConfigurationDelegate - Finished Spring Data repository scanning in 489 ms. Found 8 JPA repository interfaces.
2022-05-03 00:57:48,445 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'io.opentracing.contrib.spring.cloud.async.DefaultAsyncAutoConfiguration' of type [io.opentracing.contrib.spring.cloud.async.DefaultAsyncAutoConfiguration$$EnhancerBySpringCGLIB$$e77d6a78] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,499 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'io.opentracing.contrib.java.spring.jaeger.starter.JaegerAutoConfiguration' of type [io.opentracing.contrib.java.spring.jaeger.starter.JaegerAutoConfiguration$$EnhancerBySpringCGLIB$$f8447867] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,558 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'org.apache.camel.component.dataset.springboot.DataSetComponentConverter' of type [org.apache.camel.component.dataset.springboot.DataSetComponentConverter] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,565 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'org.apache.camel.component.dataset.springboot.DataSetTestComponentConverter' of type [org.apache.camel.component.dataset.springboot.DataSetTestComponentConverter] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,571 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'org.apache.camel.component.directvm.springboot.DirectVmComponentConverter' of type [org.apache.camel.component.directvm.springboot.DirectVmComponentConverter] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,577 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'org.apache.camel.component.http.springboot.HttpComponentConverter' of type [org.apache.camel.component.http.springboot.HttpComponentConverter] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,582 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'org.apache.camel.component.log.springboot.LogComponentConverter' of type [org.apache.camel.component.log.springboot.LogComponentConverter] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,589 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'org.apache.camel.component.mock.springboot.MockComponentConverter' of type [org.apache.camel.component.mock.springboot.MockComponentConverter] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,594 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'org.apache.camel.component.quartz.springboot.QuartzComponentConverter' of type [org.apache.camel.component.quartz.springboot.QuartzComponentConverter] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,602 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'org.apache.camel.component.seda.springboot.SedaComponentConverter' of type [org.apache.camel.component.seda.springboot.SedaComponentConverter] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,608 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'org.apache.camel.component.stub.springboot.StubComponentConverter' of type [org.apache.camel.component.stub.springboot.StubComponentConverter] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,614 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'org.apache.camel.component.validator.springboot.ValidatorComponentConverter' of type [org.apache.camel.component.validator.springboot.ValidatorComponentConverter] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,621 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'org.apache.camel.component.vm.springboot.VmComponentConverter' of type [org.apache.camel.component.vm.springboot.VmComponentConverter] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,627 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'org.apache.camel.component.xslt.springboot.XsltComponentConverter' of type [org.apache.camel.component.xslt.springboot.XsltComponentConverter] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,632 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'org.springframework.boot.autoconfigure.flyway.FlywayAutoConfiguration' of type [org.springframework.boot.autoconfigure.flyway.FlywayAutoConfiguration] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,643 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'stringOrNumberMigrationVersionConverter' of type [org.springframework.boot.autoconfigure.flyway.FlywayAutoConfiguration$StringOrNumberToMigrationVersionConverter] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,657 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'opentracing.jaeger-io.opentracing.contrib.java.spring.jaeger.starter.JaegerConfigurationProperties' of type [io.opentracing.contrib.java.spring.jaeger.starter.JaegerConfigurationProperties] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,678 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'metricsFactory' of type [io.jaegertracing.internal.metrics.NoopMetricsFactory] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,691 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'metrics' of type [io.jaegertracing.internal.metrics.Metrics] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,700 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'sampler' of type [io.jaegertracing.internal.samplers.ConstSampler] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,765 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'reporter' of type [io.jaegertracing.internal.reporters.CompositeReporter] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,811 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'tracer' of type [io.jaegertracing.internal.JaegerTracer] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,828 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'io.opentracing.contrib.spring.web.starter.WebClientTracingAutoConfiguration$DefaultWebClientSpanDecorators' of type [io.opentracing.contrib.spring.web.starter.WebClientTracingAutoConfiguration$DefaultWebClientSpanDecorators$$EnhancerBySpringCGLIB$$bcad9ec] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:48,842 | INFO  trationDelegate$BeanPostProcessorChecker - Bean 'standardTagsWebClientSpanDecorator' of type [io.opentracing.contrib.spring.web.client.WebClientSpanDecorator$StandardTags] is not eligible for getting processed by all BeanPostProcessors (for example: not eligible for auto-proxying)
2022-05-03 00:57:50,898 | INFO  o.s.b.w.embedded.tomcat.TomcatWebServer  - Tomcat initialized with port(s): 8080 (http)
2022-05-03 00:57:50,920 | INFO  o.apache.coyote.http11.Http11NioProtocol - Initializing ProtocolHandler ["http-nio-8080"]
2022-05-03 00:57:50,921 | INFO  org.apache.catalina.core.StandardService - Starting service [Tomcat]
2022-05-03 00:57:50,921 | INFO  org.apache.catalina.core.StandardEngine  - Starting Servlet engine: [Apache Tomcat/9.0.58]
2022-05-03 00:57:51,205 | INFO  o.a.c.c.C.[Tomcat].[localhost].[/]       - Initializing Spring embedded WebApplicationContext
2022-05-03 00:57:51,205 | INFO  w.s.c.ServletWebServerApplicationContext - Root WebApplicationContext: initialization completed in 8508 ms
2022-05-03 00:57:54,394 | ERROR o.s.b.web.embedded.tomcat.TomcatStarter  - Error starting Tomcat context. Exception: org.springframework.beans.factory.UnsatisfiedDependencyException. Message: Error creating bean with name 'io.opentracing.contrib.spring.web.starter.ServerTracingAutoConfiguration': Unsatisfied dependency expressed through field 'skipPattern'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'skipPattern' defined in class path resource [io/opentracing/contrib/spring/web/starter/SkipPatternAutoConfiguration.class]: Bean instantiation via factory method failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [java.util.regex.Pattern]: Factory method 'skipPattern' threw exception; nested exception is java.lang.NoSuchMethodError: org.springframework.boot.actuate.autoconfigure.web.server.ManagementServerProperties.getServlet()Lorg/springframework/boot/actuate/autoconfigure/web/server/ManagementServerProperties$Servlet;
2022-05-03 00:57:54,459 | INFO  org.apache.catalina.core.StandardService - Stopping service [Tomcat]
2022-05-03 00:57:54,484 | WARN  o.a.c.loader.WebappClassLoaderBase       - The web application [ROOT] appears to have started a thread named [Connection evictor] but has failed to stop it. This is very likely to create a memory leak. Stack trace of thread:
 java.base@11.0.11/java.lang.Thread.sleep(Native Method)
 app//org.apache.http.impl.client.IdleConnectionEvictor$1.run(IdleConnectionEvictor.java:66)
 java.base@11.0.11/java.lang.Thread.run(Thread.java:834)
2022-05-03 00:57:54,486 | WARN  ConfigServletWebServerApplicationContext - Exception encountered during context initialization - cancelling refresh attempt: org.springframework.context.ApplicationContextException: Unable to start web server; nested exception is org.springframework.boot.web.server.WebServerException: Unable to start embedded Tomcat
2022-05-03 00:57:54,517 | INFO  ConditionEvaluationReportLoggingListener -

Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled.
2022-05-03 00:57:54,606 | ERROR o.s.b.d.LoggingFailureAnalysisReporter   -

***************************
APPLICATION FAILED TO START
***************************

Description:

An attempt was made to call a method that does not exist. The attempt was made from the following location:

    io.opentracing.contrib.spring.web.starter.SkipPatternAutoConfiguration$ManagementSkipPatternProviderConfig.getPatternForManagementServerProperties(SkipPatternAutoConfiguration.java:68)

The following method did not exist:

    org.springframework.boot.actuate.autoconfigure.web.server.ManagementServerProperties.getServlet()Lorg/springframework/boot/actuate/autoconfigure/web/server/ManagementServerProperties$Servlet;

The calling method's class, io.opentracing.contrib.spring.web.starter.SkipPatternAutoConfiguration$ManagementSkipPatternProviderConfig, was loaded from the following location:

    jar:file:/C:/Users/divil/.m2/repository/io/opentracing/contrib/opentracing-spring-web-starter/3.0.1/opentracing-spring-web-starter-3.0.1.jar!/io/opentracing/contrib/spring/web/starter/SkipPatternAutoConfiguration$ManagementSkipPatternProviderConfig.class

The called method's class, org.springframework.boot.actuate.autoconfigure.web.server.ManagementServerProperties, is available from the following locations:

    jar:file:/C:/Users/divil/.m2/repository/org/springframework/boot/spring-boot-actuator-autoconfigure/2.6.4/spring-boot-actuator-autoconfigure-2.6.4.jar!/org/springframework/boot/actuate/autoconfigure/web/server/ManagementServerProperties.class

The called method's class hierarchy was loaded from the following locations:

    org.springframework.boot.actuate.autoconfigure.web.server.ManagementServerProperties: file:/C:/Users/divil/.m2/repository/org/springframework/boot/spring-boot-actuator-autoconfigure/2.6.4/spring-boot-actuator-autoconfigure-2.6.4.jar

Action:

Correct the classpath of your application so that it contains compatible versions of the classes io.opentracing.contrib.spring.web.starter.SkipPatternAutoConfiguration$ManagementSkipPatternProviderConfig and org.springframework.boot.actuate.autoconfigure.web.server.ManagementServerProperties

I'm too facing this issue
org.springframework.context.ApplicationContextException: Unable to start web server; nested exception is org.springframework.boot.web.server.WebServerException: Unable to start embedded Tomcat
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.onRefresh(ServletWebServerApplicationContext.java:165)
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:577)
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:147)

repo: opentracing-contrib/java-spring-cloud


text:
[#381] Fixes to FDA_DAP document name extraction

I went through the document names we have in our warehouse DB, looking for
strange names. For each of those, I analyzed the issue, added a breaking test
and fixed it.
The only issue unfixed for now is
http://www.accessdata.fda.gov/drugsatfda_docs/nda/2000/20687_mifepristone.cfm,
which has a very irregular structure.
Fixes opentrials/opentrials#381

👍

authors: nightsh vitorbaptista

repo: opentrials/collectors

license: mit


text:
🛑 [CN] OpenUPM API /packages/extra is down

In b1863bd, [CN] OpenUPM API /packages/extra (https://api.openupm.cn/packages/extra) was down:

HTTP code: 0
Response time: 0 ms

Resolved: [CN] OpenUPM API /packages/extra is back up in e150347 after 95 days, 43 minutes.

repo: openupm/upptime-openupmcn


text:
🛑 [CN] OpenUPM Website Docs is down

In efdb3cf, [CN] OpenUPM Website Docs (https://openupm.cn/docs/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: [CN] OpenUPM Website Docs is back up in 42b79dc after 8 minutes.


text:
🛑 [CN] OpenUPM Website Packages is down

In 8bc719d, [CN] OpenUPM Website Packages (https://openupm.cn/packages/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: [CN] OpenUPM Website Packages is back up in f9475e0 after 9 minutes.


text:
🛑 [CN] OpenUPM Website is down

In 846ca82, [CN] OpenUPM Website (https://openupm.cn) was down:

HTTP code: 0
Response time: 0 ms

Resolved: [CN] OpenUPM Website is back up in 1e3e735.

repo: openupm/upptime


text:
🛑 [Global] OpenUPM Registry Fetch a Tarball is down

In 8de9cad, [Global] OpenUPM Registry Fetch a Tarball (https://package.openupm.com:443/com.littlebigfun.addressable-importer/-/com.littlebigfun.addressable-importer-0.9.3.tgz) was down:

HTTP code: 0
Response time: 0 ms

Resolved: [Global] OpenUPM Registry Fetch a Tarball is back up in 3e2c7f6 after 6 minutes.


text:
🛑 [CN] OpenUPM Registry /-/all is down

In 32da019, [CN] OpenUPM Registry /-/all (https://package.openupm.cn/-/all) was down:

HTTP code: 0
Response time: 0 ms

Resolved: [CN] OpenUPM Registry /-/all is back up in 1e1c637.


text:
🛑 [CN] OpenUPM Registry /package-name is down

In d65a58f, [CN] OpenUPM Registry /package-name (https://package.openupm.cn/com.littlebigfun.addressable-importer) was down:

HTTP code: 500
Response time: 180 ms

Resolved: [CN] OpenUPM Registry /package-name is back up in 1c520b6.


text:
[Bug]: Setting the threshold using ManualThreshold seems to have no effect on the output of predict

Describe the bug
Setting the threshold using ManualThreshold seems to have no effect on the output of predict.
I set the default_value in ManualThreshold to 0.99 and 0.0001, but the images saved by predict are the same.
Dataset
N/A
Model
Reverse Distillation
Steps to reproduce the behavior
`
model = ReverseDistillation()
threshold = ManualThreshold(default_value=0.1)
engine = Engine(
max_epochs=50,
limit_train_batches=100,
threshold=threshold,
check_val_every_n_epoch=2,
logger=True
)
engine.predict(
datamodule=folder_datamodule,
model=model,
ckpt_path="my ckpt path" )
`
OS information
OS information:

OS: Windows 11
Python version: 3.10.11
Anomalib version: 1.2.0.dev0
PyTorch version: 2.3.1+cu121
CUDA/cuDNN version: 121
GPU models and configuration: RTX 4090

Expected behavior
different threshold, different predicted mask
Screenshots
No response
Pip/GitHub
GitHub
What version/branch did you use?
No response
Configuration YAML
None

Logs
None

Code of Conduct

[X] I agree to follow this project's Code of Conduct

What do your predictions look like and what do you expect? Is the code above your full code, because the model training (and validation) phase is missing.

Here is my training code:

`model = ReverseDistillation()
engine = Engine(
max_epochs=200,
check_val_every_n_epoch=5,
logger=True
)
Train the model
engine.fit(datamodule=folder_datamodule, model=model)`

When I finish training the model and call the model using the predict  method, no matter what value I change the default_value in ManualThreshold to, the 'Predicted Heat Map' and 'Predicted Mask' drawn by predict method are exactly the same. I believe that modifying the threshold should output different 'Predicted Mask'. For example, if I set the threshold very low, there should be many defects.

@alexriedel1 Looking forward to your reply, thanks.

'm also having this issue, I want to change the label of the prediction image by modifying the threshold, but ManualThreshold doesn't work.

repo: openvinotoolkit/anomalib


text:
Add NNCF quantization for InstructPix2Pix notebook

Add post-training optimization support by NNCF for UNet model from 231-instruct-pix2pix-image-editing.ipynb

added

View entire conversation on ReviewNB

fixed

View entire conversation on ReviewNB

fixed

View entire conversation on ReviewNB

Aligned with README

View entire conversation on ReviewNB

@nikita-savelyevv , @eaidova please take a look

I use probability to select intermediate inputs in the diffusion process. It is not related to dataset shuffling.

View entire conversation on ReviewNB

deleted

View entire conversation on ReviewNB

done

View entire conversation on ReviewNB

changed

View entire conversation on ReviewNB

fixed in collect_calibration_data

View entire conversation on ReviewNB

@l-bat , have you fixed the problem with SQ that I reported?

Yes

@MaximProshin @l-bat  can I merge this notebook?

authors: eaidova l-bat


text:
Fixes in python IDL & JSONRPC probes

Please see commit comments for details

I broke the first commit into two, one for each bug that it fixes, and pushed all three commits to master, branch-2.4, and branch-2.3.  Thank you!

authors: blp sumgarg

repo: openvswitch/ovs


text:
docker-machine: not found   Persistent couch db

-----host machine-------
$ ./hello
...........
{
    "message": "hello"
}
$  vagrant ssh

------vm environment    intend to setup a persistant couch db------
$ export OW_DB=Cloudant
$ export OW_DB_USERNAME=admin
$ export OW_DB_PASSWORD=password
$ export OW_DB_PROTOCOL=https
$ export OW_DB_HOST=http
$ export OW_DB_PORT=6000
ansible-playbook setup.yml

PLAY [localhost] **************************************************************

TASK [setup] ******************************************************************

Thursday 16 June 2016  10:42:16 +0000 (0:00:00.038)       0:00:00.038 *********

ok: [localhost]

TASK [find the ip of docker-machine] ******************************************

Thursday 16 June 2016  10:42:19 +0000 (0:00:03.213)       0:00:03.251 *********

fatal: [localhost -> localhost]: FAILED! => {"changed": true, "cmd": "\"docker-
achine\" \"ip\" \"whisk\"", "delta": "0:00:00.003987", "end": "2016-06-16 10:42
19.515486", "failed": true, "rc": 127, "start": "2016-06-16 10:42:19.511499", "
tderr": "/bin/sh: 1: docker-machine: not found", "stdout": "", "stdout_lines":
], "warnings": []}
...ignoring

TASK [set_fact] ***************************************************************

Thursday 16 June 2016  10:42:19 +0000 (0:00:00.203)       0:00:03.454 *********

ok: [localhost]

TASK [gen hosts for docker-machine] *******************************************

Thursday 16 June 2016  10:42:19 +0000 (0:00:00.042)       0:00:03.497 *********

skipping: [localhost]

TASK [prepare db_local.ini] ***************************************************

Thursday 16 June 2016  10:42:19 +0000 (0:00:00.032)       0:00:03.529 *********

ok: [localhost -> localhost]

PLAY RECAP ********************************************************************

localhost                  : ok=4    changed=0    unreachable=0    failed=0

Thursday 16 June 2016  10:42:19 +0000 (0:00:00.367)       0:00:03.897 *********

===============================================================================

setup ------------------------------------------------------------------- 3.21s
prepare db_local.ini ---------------------------------------------------- 0.37s
find the ip of docker-machine ------------------------------------------- 0.20s
set_fact ---------------------------------------------------------------- 0.04s
gen hosts for docker-machine -------------------------------------------- 0.03s

the issue can be reproduced on Ephemeral CouchDB case

What exactly is the issue you experience?

fatal: [localhost -> localhost]: FAILED! => {"changed": true, "cmd": ""docker-
achine" "ip" "whisk"", "delta": "0:00:00.003987", "end": "2016-06-16 10:42
19.515486", "failed": true, "rc": 127, "start": "2016-06-16 10:42:19.511499", "
tderr": "/bin/sh: 1: docker-machine: not found", "stdout": "", "stdout_lines":
], "warnings": []}
...ignoring
not sure this means the command failed to execute sth?

@lfzCarlosC
setup.yml is used to covered all environments (local, mac, etc). If you use docker-machine, setup will try to find the ip of the docker-machine and fill it in ansible hosts for you. But if you dont use docker-machine, the step is still executed cause setup.yml is not bind to a specific ansible env. In this case, you have this error (cause you don't have docker-machine in your dev env). Ansible will stop if any non-zero is returned, so in order to tell ansible go forward, we have to skip the "fatal" error.
Hope that I can give you a enough explanation. This error message is still very annoying, i agree with you

btw, i"m not sure if your env variables are correct :)
------vm environment    intend to setup a persistant couch db------
$ export OW_DB=Cloudant
$ export OW_DB_USERNAME=admin
$ export OW_DB_PASSWORD=password
$ export OW_DB_PROTOCOL=https
$ export OW_DB_HOST=http
$ export OW_DB_PORT=6000

I tested and found if I change the port to 5984, it work well

I change it to
$ export OW_DB=couchdb
$ export OW_DB_USERNAME=admin
$ export OW_DB_PASSWORD=password
$ export OW_DB_PROTOCOL=https
$ export OW_DB_HOST=http
$ export OW_DB_PORT=5984
the same issue happens,but then I execute installing DB command(couchdb.sh, initDB.sh...) and couchDB can be created successfully.

Issue being the "fatal error" mentioned above? As @lehoanganh mentioned, this is an expected "error" currently and skipped for a reason. You can ignore it for the moment, if you're not using a docker-machine based setup.

ok,thanks

@lehoanganh given this seems to be a recurring issue -- do we have a github issue to track and eliminate this?

@mbehrendt let's use this issue to track. a pull is opened: https://github.com/openwhisk/openwhisk/pull/686
It also fixes the issue that setup.yml does not work at the 1. run (you have experienced it ;) )

https://github.com/openwhisk/openwhisk/pull/688 is merged. Issue closed.

authors: lehoanganh lfzCarlosC markusthoemmes mbehrendt

repo: openwhisk/openwhisk


text:
Fix the typo of fullActioName

This patch changes the wrong fullActioName into fullQualifiedName.

Merged as https://github.com/openwhisk/openwhisk/commit/63d483a9acf9ee0fe416475a5254cd36672fda7c.

authors: houshengbo rabbah


text:
downgrade docker to version 1.9.1

This PR downgrades docker to version 1.9.1 in the docker.sh script used to provision vagrant boxes. This resolves #536.

Want to downgrade .travis.yml aswell?

sure, will do

Note that for most local developments, 1.11 is likely fine.

I want to reproduce a docker specific error locally, that's why I put it up for discussion whether to downgrade or not - I think it would make sense to keep the local development environment in sync with the rest of the project.

Agreeing to @danielfederschmidt. We should keep the whole pipeline in sync, including dev envs.

I'm not able to assign someone for review, @rabbah could you take a look?

Can you confirm testing the vagrant part?  Otherwise, ready to merge.

yes, I used the /custom/Vagrantfile to set up a box and after running through the setup, docker -v yields Docker version 1.9.1, build a34a1d5.

@danielfederschmidt I know this is not directly related, but why do we install docker-py in ansible.sh instead of docker.sh ?

@csantanapr I'm not entirely sure but I guess that we use features contained in the ansible docker module which requires docker-py to be installed [1]. This follows the same pattern as gradle.sh where the software-properties-common and the python-software-properties package are installed before gradle is installed.
[1] http://docs.ansible.com/ansible/docker_module.html

@danielfederschmidt makes sense, thanks for the response

@domdom82 @lehoanganh can confirm it's ansible related.

@csantanapr  @danielfederschmidt  the docker engine is not ansible related. The docker engine is not installed with ansible.
The docker-py pip package which is used by ansible for deploying docker container is covered in prereq.yml playbook, and of course in ansible.sh as well (which is soon obsolete once ansible is ready, no ant anymore)

rebased/merged

authors: csantanapr danielfederschmidt lehoanganh markusthoemmes perryibm rabbah


text:
[improvement] Add swappable models #122

Closes #122

Coverage decreased (-2.3%) to 94.769% when pulling 6b94aa44f4dec08e32e81acf547c3ae1c4fea1a6 on atb00ker:swapper into 79dfee2fb6a9e9c1058579f7939b35f5cf7ed934 on openwisp:master.

Tentatively applied these changes to openwisp-radius and tested, found some improvements and I think now it's ready for review.

repo: openwisp/openwisp-users


text:
Update property documentation

New-style properties (declared in class body) can have documentation attached to them. This allows for automation of documentation generation for those fields by defining docstrings and setting the __doc__ attribute as appropriate. A few classes have already been updated. In addition there are attributes of the property (like its value_type and inverse_of) which are now accessible for documentation generation after module load: these should be added to the doc string.

The latest documentation is hosted here:

repo: openworm/PyOpenWorm


text:
Forum openwrt website down

sorry maybe this is not where I ask for this but the openwrt forum I can't access

Works for me

repo: openwrt/luci


text:
Could u pls....just tell me how to build a package?

Issue template:

Please make sure that the issue subject starts with <package-name>:
Issues related to end of life (EOL) releases are not supported or maintained and will be closed
Remove lines from top till here and fill in the following questions

Steps to reproduce:
Example: Replace the following lines and remove this

go to: Network → Interfaces → LAN (an interface with a static address) → DHCP server tab → IPv6 RA settings tab
set RA MTU and RA Hop Limit to arbitrary non-default value
Save & Apply
go to: IPv6 RA settings tab again

Actual behavior:
Example: Replace the following lines and remove this

option ra_mtu '1500' is set correctly in /etc/config/dhcp
In LuCI though, RA MTU and RA Hop Limit are still displaying the default values in light gray font color.

Expected behavior:
Example: Replace the following lines and remove this
RA MTU and RA Hop Limit are displaying the correct values found in /etc/config/dhcp in black font color.

Additional Information:
OpenWrt version information from system /etc/openwrt_release
Example: Replace the following lines and remove this
DISTRIB_ID='OpenWrt'
DISTRIB_RELEASE='21.02.0-rc4'
DISTRIB_REVISION='r16256-2d5ee43dc6'
DISTRIB_TARGET='x86/64'
DISTRIB_ARCH='x86_64'
DISTRIB_DESCRIPTION='OpenWrt 21.02.0-rc4 r16256-2d5ee43dc6'
DISTRIB_TAINTS=''

@lampb0y check the wiki on how to setup a buildroot and how to install the external feeds


text:
Bug: v23.05 rc3 DHCP Static IP, can not input fixed IP in android browser app

I am in SamSung M51, with stock Android v12, chrome browser v117, also try some old webkit browser
After Login LUCI (in mobile or desktop view) -> Top Menu: Network -> Sub Menu: DHCP and DNS -> Sub-Top Menu: Static Leases -> Bottom: Add
Try manually input HostName, MAC address and a custom IP v4 address.
After you input above, and try kit the mobile keyboard ENTER key on the custom IP field, the IP is not inputted.
I also try other android on-screen keyboard, same issue.
Model	Xiaomi AX3600
Architecture	ARMv8 Processor rev 4
Target Platform	ipq807x/generic
Firmware Version	OpenWrt 23.05.0-rc2 r23228-cd17d8df2a / LuCI openwrt-23.05 branch git-23.118.79121-6fb185f
Kernel Version	5.15.118

I just upgrade to v23.05 rc3 on the same device.
this issue still not fix.

Cannot reproduce it in the chrome mobile device emulation and can't test on real hardware since I don't own any Android device. Maybe someone else can confirm/debug

@davidngrc can you perform a screen recording demonstrating this?

@davidngrc can you perform a screen recording demonstrating this?

https://file.io/QQyMETgIg42W

I tried the file at both links, and I cannot open it, nor does ffmpeg recognize it:
[mov,mp4,m4a,3gp,3g2,mj2 @ 0x7fd486304100] moov atom not found Screen_Recording_20231115_084126_Chrome.mp4: Invalid data found when processing input
The data appears truncated at around 50.4mb within the file.

OK, I see it happening.
My GUI is only uncooperative when I don't already have a name there. Otherwise it works. Does mobile chrome have a developer pane which shows perhaps what is going on?
I might suggest trying a different keyboard.

I try 3 other keyboard already, this is the samsung stock, just reset, did not install anything else.
so there is an issue here.

Do you still get the problem if you put the cursor into each of the fields at least once? Name, MAC, IP?

@systemcrash  still same issue
Here is new test video on another phone (not reset) with kiwi browser and 3 keyboard.
This browser include developer tool, I also shown it in the video
https://we.tl/t-petIGkR0gc

Unexpected keyboard by Juloo permits to override "next" key with "enter" and the value gets saved with "enter", but default " next " activity does not update input field.

authors: brada4 davidngrc jow- systemcrash


text:
resnet50 torch fails to vectorize and is 20x slower than TF versions

What happened?
wget https://storage.googleapis.com/shark_tank/latest/resnet50_torch/resnet50_torch.mlir
Steps to reproduce your issue
Will add the compile / benchmark commands shortly.
What component(s) does this issue relate to?
No response
Version information
No response
Additional context
No response

We have a temp workaround in SHARK-Runtime under --iree-flow-enable-conv-nchw-to-nhwc-transform

I think this can be considered done. And we can open new issues as required.

repo: openxla/iree