text:
Appstudio update mvp-test-component

Pipelines as Code configuration proposal

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
12 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
15 seconds
clair-scan

✅ Succeeded
12 seconds
sanity-inspect-image

✅ Succeeded
10 seconds
sbom-json-check

✅ Succeeded
9 seconds
deprecated-base-image-check

✅ Succeeded
57 seconds
clamav-scan

✅ Succeeded
15 seconds
sanity-label-check

✅ Succeeded
15 seconds
sanity-optional-label-check

✅ Succeeded
4 seconds
show-summary

repo: redhat-appstudio-qe/hacbs-test-project


text:
Appstudio update rhtap-demo-component-dnve

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: rhtap-demo-component-dnve-on-pull-request-
creating pipelinerun rhtap-demo-component-dnve-on-pull-request- in namespace rhtap-demo-dev-tbhf-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

source: gharchive/pull-request

license_type: permissive

license_source: github-api


text:
bug: fix JVM Build Service tests

This has broken with the change away from using 'bundle'.
Fixes STONEBLD-1495

Linked JVM Build Service PR for testing: https://github.com/redhat-appstudio/jvm-build-service/pull/703

/test redhat-appstudio-e2e


text:
fix: relase clean up code

Description

merge and remove constants and timeouts that are  not necessary as constants.
delete constants pointing to constants

Issue ticket number and link
https://issues.redhat.com/browse/RHTAPREL-660
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

/assigin @redhat-appstudio/release-team

/retest

/lgtm

Can you please update the Description and the name ("Relase") of the PR?

/approve

authors: cuipinghuo jinqi7 johnbieren


text:
fix(STONEINTG-574) fix log message about number of integration tests

Maintainers will complete the following section

[x] Commit messages are descriptive enough (hints)
[ ] Code coverage from testing does not decrease and new code is covered
[ ] Controllers diagrams are updated when PR changes controllers code  (if applicable)

/test integration-service-e2e

/test integration-service-e2e

tested on local cluster, see  results here

repo: redhat-appstudio/integration-service


text:
chore(RHTAPWATCH-514): limit namespace for control plane alerts

The metric currently used for the control plane alerts is also going to be forwarded from the data plane clusters to allow some other alerts.
With this change, we specify the exact namespace for the control plane alerts so they don't trigger on metrics coming from other namespaces.

Are we sure these are the only namespaces we should query? If yes, lgtm

Yes. It seems as all time series in prod have this label set to argocd and in stage they all set to argocd-staging


text:
rename pytest.imi to pytest.ini

pytest configuration was named imi instead of ini
closes #43
Signed-off-by: Jenia Sakirko jenia.sakirko@gmail.com

LGTM

authors: OfirMatasas jeniaSakirko

repo: redhat-beyond/Hotails

license: MIT


text:
Adding CONTRIBUTING file.

Adding CONTRIBUTING file to the project.
Close #10

Please try not to force push during the review process. The reviewers can't see what you changed from the last time.
You can squash the commits after the PR is approved before the merge

@natifridman I updated the CONTRIBUTING file according to the reviewes

@GalOved I think you missed the "Pull Requests Standards" section :)
Please fix the spacing between the lines.

@liornoy l fix the "Pull Requests Standards" section.

Please squash the commits so we'll remain with only one.
(As all of the current 4 commits are changing only 1 file)

@liornoy i squash all the commits together.

@liornoy hi lior I fix the help section, delete that section becase it is not relvent for now.

I think the CONTRIBUTING file looks good.

@ohadrevach @WaseemAbuSobe Please go through the CONTRIBUTING file and review it,
and leave a comment if you agree/disagree with the content.
We must have everyone's consent before merging.

Nice work on changes, I resolved all of my comments, and most of the comments in general. @natifridman there are a couple of comments you left that were addressed, please see if those were resolved.
And in order to finish reviewing this PR we're missing @ohadrevach 's review

authors: GalOved liornoy natifridman svatares

repo: redhat-beyond/tasties


text:
Rename extravars to use yaml extension

Using extravars.yaml or extravars.yml  will allow some editor to identify the file as YAML and provide some support (validation, highlight syntax, etc)

It seems that this is a limitation of ansible-runner.

source: gharchive/issue


text:
feat(kafka topic list): add flags for pagination

add --page and --size flag to kafka topic list command so user can navigate to different pages and adjust capacity of a page.
Addresses #766
Verification Steps

Run the kafka list command with page and size flag.

go run ./cmd/rhoas kafka topic list --page 1 --size 1

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation change
[ ] Other (please specify)

Checklist

[X] Documentation added for the feature
[ ] CI and all relevant tests are passing
[ ] Code Review completed
[ ] Verified independently by reviewer

Good from technical standpoint. Does that works against stage?

Good from technical standpoint. Does that works against stage?

Yes it does, I will fix the build and re-request reviews.

Hi @bhardesty. I am seeing some inconsistencies regarding use of periods in flag descriptions. Some flags end with period and some don't. As suggested by @craicoverflow we shouldn't use periods as the flags provided by cobra (--default and --help) don't use them too. Would you like this to be addressed in another issue, we can finalize a convention and fix the descriptions?

repo: redhat-developer/app-services-cli


text:
Dex service account destroyed by operator

Describe the bug
When configuring Openshift SSO on an ArgoCD instance (with dex), the operator fails to reconcile with the following error (service xxx-argocd-dex-server account not found) :
{"level":"error","ts": xxx,"logger":"controller-runtime.controller","msg":"Reconciler error","controller":"argocd-controller","request":"openshift-gitops/xxx","error":"ServiceAccount \"xxx-argocd-dex-server\" not found", ...

If I create manually the desired service account, it disappears - seems deleted by the operator when "reconciling service accounts"
To Reproduce
Patch the ArgoCD instance with the following file :
spec:
  dex:
    image: quay.io/redhat-cop/dex
    openShiftOAuth: true
    version: v2.22.0-openshift
  rbac:
    defaultPolicy: 'role:readonly'
    policy: |
      g, system:cluster-admins, role:admin
    scopes: '[groups]'

oc patch argocd argocd-cluster -n openshift-gitops --type merge --patch "$(cat argocd-openshift-sso-patch.yaml)"
Additional context
Cluster version : OKD 4.7.0-0.okd-2021-03-07-090821
Operator image : registry.redhat.io/openshift-gitops-1-tech-preview/gitops-rhel8-operator:v1.0.1-9

Hi @pbriet ,
Dex is currently disabled by default in gitops-operator. To enable Dex,  Please set the below env variable in subscription resource as mentioned below.
spec:
  config:
    env:
    - name: DISABLE_DEX
      Value: "false"

A complete guide to setup dex for gitops_operator is available here.
https://docs.google.com/document/d/1147S5yOdj5Golj3IrTBeeci2E1CjAkieGCcl0w90BS8/edit?ts=602bd66f#heading=h.aaosp4vcdtza

Hi @pbriet ,
Dex is currently disabled by default in gitops-operator. To enable Dex, Please set the below env variable in subscription resource as mentioned below.
spec:
  config:
    env:
    - name: DISABLE_DEX
      Value: "false"

A complete guide to setup dex for gitops_operator is available here.
https://docs.google.com/document/d/1147S5yOdj5Golj3IrTBeeci2E1CjAkieGCcl0w90BS8/edit?ts=602bd66f#heading=h.aaosp4vcdtza

That document is not available publicly. I requested access.

Hi @iam-veeramalla, I confirm it works.
On my side, the SSO is working correctly on a OKD 4.7.
As @davidkarlsen said, there is no way to access the doc describing the procedure.
Thanks,

Hi @iam-veeramalla, I confirm it works.
On my side, the SSO is working correctly on a OKD 4.7.
As @davidkarlsen said, there is no way to access the doc describing the procedure.
Thanks,

Yes, This doc is not available public-ally, My bad for sharing this. Sharing the steps below that are mentioned in the docs.
Set DISABLE_DEX env variable to false. Example shown below.
spec:
  config:
    env:
    - name: DISABLE_DEX
      Value: "false"

You can enable RBAC on argo-cd by following the instructions provided in the argo-cd RBAC Configuration. Example RBAC configuration looks like this.
spec:
  dex:
    openShiftOAuth: true
  rbac:
    defaultPolicy: 'role:readonly'
    policy: |
      g, system:cluster-admins, role:admin
    scopes: '[groups]'

The DISABLE_DEX env variable, is that in the argoCD-resource?

The DISABLE_DEX env variable, is that in the argoCD-resource?

No, it's for the operator deployment.

The DISABLE_DEX env variable, is that in the argoCD-resource?

No, it's for the operator deployment.

so in the kind: CatalogSource?

The DISABLE_DEX env variable, is that in the argoCD-resource?

No, it's for the operator deployment.

so in the kind: CatalogSource?

its is in the subscription resource

The DISABLE_DEX env variable, is that in the argoCD-resource?

No, it's for the operator deployment.

so in the kind: CatalogSource?

@fredcb its is in the subscription resource

openshift-operators -> subscriptions -> openshift-gitops-operator "edit subscription"
spec:
...
  config:
    env:
      - name: DISABLE_DEX
        value: 'false'
....

@davidkarlsen Thanks for the very clear answer :-). I been working only with argocd's operator so far, so I wasn't aware you had another resource type in this one.

This works for me on a OSD 4.7 cluster, enables both real TLS (using the cluster route's default wildcard cert) and SSO to openshift
$ oc patch subscription openshift-gitops-operator -n openshift-operators --type=merge -p='{"spec":{"config":{"env":[{"name":"DISABLE_DEX","Value":"false"}]}}}'

$ oc patch argocd openshift-gitops -n openshift-gitops --type=merge -p='{"spec":{"dex":{"openShiftOAuth":true},"rbac":{"defaultPolicy":"role:readonly","policy":"g, system:cluster-admins, role:admin","scopes":"[groups]"}}}'

$ oc patch argocd openshift-gitops -n openshift-gitops --type=merge -p='{"spec":{"server":{"insecure":true,"route":{"enabled":true,"tls":{"insecureEdgeTerminationPolicy":"Redirect","termination":"edge"}}}}}'

^ I feel like these should be defaults, otherwise the first time user experience isn't great.  Until then we should update the docs to clarify that they need to accept a self-signed cert in their browser so they know its to be expected.

Can we add toggles to the argocd CR to allow the users to do the following:

enable dex
sub-option is to enable SSO with openshift

It would be great,if the configuration of the subscription would be documented anywhere. I'm a cluster-admin and was wondering why my Argo CD deployed with the GitOps Operator doesn't work. Perhaps there are other config issues, that will appear, when I try to configure other things in Argo CD??? I'm coming from the Argo CD community operator and woud like to take my configurations to the GitOps Operator....

^ I feel like these should be defaults, otherwise the first time user experience isn't great. Until then we should update the docs to clarify that they need to accept a self-signed cert in their browser so they know its to be expected.

indeed, with those 3 patch commands the first time user experience is a lot better!

As far as I have learned from Redhat the dex server and integration with
OpenShift oauth is no longer supported. They suggest using Keycloak
instead. So far a lot less user friendly experience
On Mon, 19 Jul 2021 at 14:12, Elytscha @.***> wrote:

^ I feel like these should be defaults, otherwise the first time user
experience isn't great. Until then we should update the docs to clarify
that they need to accept a self-signed cert in their browser so they know
its to be expected.
indeed, with those 3 patch commands the first time user experience is a
lot better!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/redhat-developer/gitops-operator/issues/76#issuecomment-882497950,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE5T64W62JSDJEF647ME4FTTYQJC5ANCNFSM4ZAS4CJQ
.

As far as I have learned from Redhat the dex server and integration with OpenShift oauth is no longer supported. They suggest using Keycloak instead. So far a lot less user friendly experience
…
On Mon, 19 Jul 2021 at 14:12, Elytscha @.***> wrote: ^ I feel like these should be defaults, otherwise the first time user experience isn't great. Until then we should update the docs to clarify that they need to accept a self-signed cert in their browser so they know its to be expected. indeed, with those 3 patch commands the first time user experience is a lot better! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#76 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE5T64W62JSDJEF647ME4FTTYQJC5ANCNFSM4ZAS4CJQ .

i know, but sounds to complicated to run a tool (keycloak or redhat sso) which no one at the company knows.
'ain't nobody got time for that'
it sounds not so complicated to use the already existent openshift oauth

for info, redhat "solution"
https://access.redhat.com/solutions/6131481
is indeed to tell you they don't support dex.

From v1.3.0 version of OpenShift-GitOps we support Dex OpenShift Connector. Dex is installed by default and can be configured for "Login With OpenShift" by adding .spec.dex.openShiftOAuth: true to the Argo CD Spec.
Please feel free to reopen the issue, if you still see this after upgrading to v1.3.0.

authors: Elyytscha IlonkaO absynth76 davidkarlsen fredcb hollisc iam-veeramalla paulczar pbriet

repo: redhat-developer/gitops-operator


text:
[#5330] Make odo build-images return an error if no Image component found in Devfile

What type of PR is this:
/kind bug
What does this PR do / why we need it:
See #5330 for more context.
Which issue(s) this PR fixes:
Fixes #5330
PR acceptance criteria:

[ ] Unit test

[x] Integration test

[ ] Documentation

How to test changes / Special notes to the reviewer:
When running odo build-images with a Devfile that has no Image component in it, the command should not succeed and should output an error message on the standard error instead, like so:
asoro in work-laptop in /tmp/no-image-in-devfile on ☁
❯ odo build-images
 ✗  no component with type "Image" found in Devfile

/approve

repo: redhat-developer/odo


text:
Fix delete command

Fix: #536

Codecov Report

Merging #537 (488b711) into master (ea40867) will decrease coverage by 0.05%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master     #537      +/-   ##
==========================================
- Coverage   68.34%   68.28%   -0.06%
==========================================
  Files          96       96
  Lines        5774     5774
  Branches     1002     1002
==========================================
- Hits         3946     3943       -3
- Misses       1828     1831       +3

Impacted Files
Coverage Δ

src/commands/delete.ts
39.80% <14.28%> (-2.92%)
:arrow_down:

src/util/check-ref-resource.ts
95.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea40867...488b711. Read the comment docs.

authors: codecov-io sudhirverma

repo: redhat-developer/vscode-tekton


text:
operator project-quay (3.9.0-nightly.20230722)

Add 3.9.0-nightly.20230722 to community operators

/merge possible

/merge possible

authors: framework-automation quay-devel


text:
[CVP-1614] Disable running operatorhub tests for bundle validate

Make the operatorhub UI tests optional and disabled

LGTM

LGTM

authors: dirgim samvarankashyap


text:
allow role overrides for VMs in standard clusters

adding role=master or role=worker to an hv_vm inventory definition will assign that node to they specified role when the siteconfig is built

I'll have to think about that. I suppose it's worth a conversation to consider how standard clusters are usually deployed with jetlag.

I am of the opinion this is fine, I actually have a similar logic added here for "master/infra" nodes in standard cluster manifests - https://github.com/redhat-performance/jetlag/blob/2dc0476d3fc88d768d40620df7366bb3de2f4dda/ansible/roles/hv-vm-manifests-standard/templates/manifest.yml.j2#L173-L179
While ideally we don't want folks modifying the inventory file, that is directed for jetlag provisioned clusters.  These manifests and siteconfigs are actually used with an existing hub cluster (provisioned by jetlag) but have ACM installed on top of and then you can use the manifests or siteconfig to have acm provision a standard cluster. It's definitely a very custom and edge case area that most folks will not be running into or using. Long term I want to migrate manifest/siteconfig rendering into acm-deploy-load since these manifests are not used directly by jetlag but open to other ideas on organization of this.

authors: akrzos radez

repo: redhat-performance/jetlag


text:
Deleting the s2i build before introducing the pipeline ?

When I started my pipeline for the first time the redeploy phase failed because the was a conflict. I had to delete the build from the s2i build and after that I could run successfully the pipeline

Was that conflict a redeploy already in progress? I'll test it again out thanks!

I ran the workshop this morning again and I could not reproduce this particular issue. So maybe it was something on my side.

Did you run it on a different project or different cluster? This may happen due the triggers not disabled on the DeploymentConfig which would trigger a new deployment when the pipeline pushes the new container image.

I did a test and I reproduced the issue once, it happens randomly apparantely, even if the triggers are disabled. I need to investigate more

authors: blues-man sebastienblanc


text:
Installation Questions

Hi Smart Cache team,
I am attempting to use redis smart cache with Exasol as the backend. I want to first get it working with Tableau Desktop and then be able to repeat that for any client that wants to connect to Exasol.
I'm using macOS
My steps:

Added redis-smart-cache-jdbc-early-access.jar to /Users/myuser/Library/Tableau/Drivers
Opened Tableau Desktop(v2024.1) > Created new datasource >Other Databases (JDBC) > added connection string

jdbc:redis://myredis.upstash.io:6379?smartcache.driver.class-name=com.exasol.jdbc.EXADriver&smartcache.driver.url=jdbc:exa://exasol_ip:8563;user=myuser&password=mypassword&clientname=EXAloader&clientversion=8.26.0
I get the following error:
No backend URL specified
Generic JDBC connection error
No backend URL specified

A few questions:

How do I make the redis-smart-cache jdbc driver aware of Exasols jdbc driver so it can reference it? Do I need to put it in the same directory as the redis-smart-cache jdbc? Should I create a properties for the driver? Do I need to add it to redis instead of on the client side with the redis-smart-cache jdbc?
Is my URL correct? I tried following the lettuce guide but maybe I have mistakes.
in general, is my approach correct?

Thank you so much for the assistance! I'm very eager to see this in action!
Many thanks!

I was able to get things working!
I added both the redis-smart-cache-jdbc.jar and exasol exajdbc.jar to the Tableau Drivers directory.
/Users/my_user/Library
In order to pass parameters, I created a smartcache.properties file and also stored in the same Tableau Drivers directory.
smartcache.driver.url:jdbc:exa:my_exa_ip/NoCertCheck:8563
smartcache.driver.class-name:com.exasol.jdbc.EXADriver

To create the datasource in Tableau I used Other Databases (JDBC)

*username is my backend database username/password
For unknown reasons my upstash redis instance was working so instead spun up a redis-stack via docker.
I was able to add cache rules (any table) using the smart-cache-cli and start getting cached results.
Next phase is to figure out cache invalidation based on last commit timestamp on tables in Exasol.


text:
v8::ObjectTemplate::Set() with non-primitive values is deprecated and will stop working in the next major release.

The latest Node.js version (6.1.0) gives me this:
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

Security context: 0x3cc8bb9c9fa9 <JS Object>#0#
    1: .node [module.js:568] [pc=0x2a93fd7d8be4] (this=0x1a0b00fec501 <an Object with map 0x1fe176b9cf21>#1#,module=0x3c932aafa169 <a Module with map 0x1fe176b18581>#2#,filename=0x3c932aafa141 <String[76]: /Users/kuchumovn/work/webapp/node_modules/hiredis/build/Release/hiredis.node>)
    2: load [module.js:~447] [pc=0x2a93fcfb4076] (this=0x3c932aafa169 <a Module with map 0x1fe176b18581>#2#,filename=0x3c932aafa141 <String[76]: /Users/kuchumovn/work/webapp/node_modules/hiredis/build/Release/hiredis.node>)
    3: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x2a93fcd3a8bd] (this=0x3cc8bb904189 <undefined>,module=0x3c932aafa169 <a Module with map 0x1fe176b18581>#2#,filename=0x3c932aafa141 <String[76]: /Users/kuchumovn/work/webapp/node_modules/hiredis/build/Release/hiredis.node>)
    4: _load [module.js:~381] [pc=0x2a93fd6c2da9] (this=0x1a0b00fec581 <JS Function Module (SharedFunctionInfo 932a007581 <a Module with map 0x1fe176b18581>#24#,filename=0x3c932a0074a9 <String[59]: /Users/kuchumovn/work/webapp/code/common/koa-redis/index.js>)
   56: arguments adaptor frame: 3->2
   57: .js [/Users/kuchumovn/work/webapp/node_modules/babel-register/lib/node.js:136] [pc=0x2a93fcebb32f] (this=0x1a0b00fec501 <an Object with map 0x1fe176b9cf21>#1#,m=0x3c932a007581 <a Module with map 0x1fe176b18581>#24#,filename=0x3c932a0074a9 <String[59]: /Users/kuchumovn/work/webapp/code/common/koa-redis/index.js>)
   58: load [module.js:~447] [pc=0x2a93fcfb4076] (this=0x3c932a007581 <a Module with map 0x1fe176b18581>#24#,filename=0x3c932a0074a9 <String[59]: /Users/kuchumovn/work/webapp/code/common/koa-redis/index.js>)
   59: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x2a93fcd3a8bd] (this=0x3cc8bb904189 <undefined>,module=0x3c932a007581 <a Module with map 0x1fe176b18581>#24#,filename=0x3c932a0074a9 <String[59]: /Users/kuchumovn/work/webapp/code/common/koa-redis/index.js>)
   60: _load [module.js:~381] [pc=0
==== C stack trace ===============================

 1: v8::Template::Set(v8::Local<v8::Name>, v8::Local<v8::Data>, v8::PropertyAttribute)
 2: hiredis::Reader::Initialize(v8::Local<v8::Object>)
 3: node::DLOpen(v8::FunctionCallbackInfo<v8::Value> const&)
 4: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&))
 5: v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::(anonymous namespace)::BuiltinArguments<(v8::internal::BuiltinExtraArguments)1>)
 6: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*)
 7: 0x2a93fcc0961b
 8: 0x2a93fd7d8be4

Already reported and fixed in the correct repository. Release soon. https://github.com/redis/hiredis-node/issues/118

authors: badboy halt-hammerzeit

repo: redis/hiredis

license_source: bigquery


text:
docs: Fix simple typo, termined -> terminated

There is a small typo in sds.c.
Should read terminated rather than termined.

Merged, thanks!


text:
EXECABORT Transaction discarded because of MOVED error in Azure Redis

ioredis version 5.3.2
Problem: We are using bull library which will issuing redis transaction. We have interment issue of getting transaction aborted error due to MOVED error in Azure Redis. Same code works without any issue with AWS Redis.
Sample Error message:
ReplyError: EXECABORT Transaction discarded because of previous errors.
    at parseError (/app/node_modules/redis-parser/lib/parser.js:179:12)
    at parseType (/app/node_modules/redis-parser/lib/parser.js:302:14) {
  previousErrors: [
    ReplyError: MOVED 2405 <IP>:15000
        at parseError (/app/node_modules/redis-parser/lib/parser.js:179:12)
        at parseType (/app/node_modules/redis-parser/lib/parser.js:302:14) {

After dig into the problem by adding more loggings in ioredis library, found that:

For Azure Redis, sometimes the node(connection) will be removed from connectionPool, which causes the transaction goes to wrong node to query the key, below log can be found in Azure Redis. But this situation didn't happen to AWS Redis. It might be related with network issue or Azure Redis close the connection. Checking with Microsoft for the behavior.
2024-07-11T06:59:41.140Z ioredis:redis status[<ip>:15000]: close -> end

In ioredis 5, slotsRefreshInterval is by default disabled. In Redis 4, it's more unlikely to see the problem due to it's enabled by default with 5 second, refreshSlotsCache event will reset nodes in connection pool, which will get back the node in connectionPool

Race condition in reaching the retry limit for MOVED error and the refreshSlotsCache. Before refreshSlotsCache get back the node in connectionPool, if unlucky it reached to the retry limit (16), then it will abort the transaction.

We have workaround to enable slotsRefreshInterval and also set value of retryDelayOnMoved to solve the problem.
But I noticed that, for MOVED that not in transaction, it will call below code to recreate node in connectionPool
 _this.connectionPool.findOrCreate(_this.natMapper(key));
Is it possible to do the same thing for MOVED error in transaction. It's more efficient than wait for refreshSlotsCache to finish.

Hi @chaochao0815, could I ask which values you set for retryDelayOnMoved, slotsRefreshInterval, and slotsRefreshTimeout? Or for any other config values that you have set?
I have been facing some similar issues to this, but am still seeing the MOVED errors after setting all those configs

repo: redis/ioredis


text:
simplify example

Description

Describe your pull request here

top level await is supported in modules, so no need to wrap in iife

Checklist

[ ] Does npm test pass with this change (including linting)?
[ ] Is the new or changed code fully tested?
[x] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@guyroyse @simonprickett WDUT?

authors: leibale mifi

repo: redis/node-redis


text:
fix: refresh AWS shards periodically

Related to #384

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (d2daaaa) 97.57% compared to head (359cdbb) 97.58%.
Report is 3 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #387   +/-   ##
=======================================
  Coverage   97.57%   97.58%
=======================================
  Files          76       76
  Lines       30679    30690   +11
=======================================
+ Hits        29936    29948   +12
  Misses        625      625
+ Partials      118      117    -1

Files
Coverage Δ

cluster.go
99.02% <100.00%> (+0.01%)
:arrow_up:

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Improvements

When connecting to an AWS Elasicache or MemoryDB, get cluster shard information only from its configuration endpoint.
Refresh cluster shard information when there are unexpected disconnections.
Reduce unnecessary goroutines and CLUSTER SHARDS requests when refreshing shard information.
Fix rare inconsistent between shards/slots commands and parsing methods.

authors: codecov-commenter rueian

repo: redis/rueidis


text:
Redisson is not reading the values set by external redis clients

I am creating a set through Medis, a Redis client or FastoRedis. When I try to read the same using redissonClient.getSet(key), I see an exception being thrown saying "Unable to evaluate the expression Method threw 'org.redisson.client.RedisException' exception." while debugging the set in IntelliJ. Why can't redisson is reading the value for the key? I noticed one thing when the redisson sets the value, it has quotes. But when you set a string from external clients, it doesn't have any quotes and redisson can't seems to be recognizing it.

Redisson by default uses JacksonJson as data codec, meaning it will try to use Jackson's ObjectMapper to deserialise the data from Redis. In your case those data were set by Medis client, which is likely not using the same encoding method.
This is the same reason why you see quotes around strings in Redis from Redisson. When Jackson serialise an object to a VALID string type in JSON format, it wraps the content around with " to comply with the format standard.

If you don't like to use JSON as the encoding scheme. Try StringCodec instead.

I did use and I was able to make progress but ran into another issue.  I modified the key/value pair in the 3rd party client and when Redisson is trying to read the same,  it is throwing the following exception.
org.redisson.client.RedisException: ERR Error running script (call to f_41086849b5c119624298370915555b51b921688a): @user_script:1: user_script:1: bad argument #2 to 'unpack' (data string too short) . channel: [id: 0x53f43883, L:/10.214.44.93:53224 - R:/10.160.48.21:6379] command: (EVAL), params: [local value = redis.call('hget', KEYS[1], ARGV[2]); if value == false then return nil; end; local t,..., 5, HeartBeat, redisson__timeout__set:{HeartBeat}, redisson__idle__set:{HeartBeat}, redisson__map_cache__last_access__set:{HeartBeat}, {HeartBeat}:redisson_options, 1512680397149, PooledUnsafeDirectByteBuf(ridx: 0, widx: 16, cap: 256)]

MapCache object is entirely a Redisson's own creation which offers you the ability of individual element eviction and other features that is not available in other clients. If you want to use MapCache related features, you need to use Redisson as the only client. If you want to pass data between different clients, then you need to stay with standard Redis objects such as List, Set, Map, etc.

authors: jackygurui ramchris

repo: redisson/redisson


text:
Strange characters on value when read data in other language

Hey there!
I was wondering if it's possible to perform a simple operation like we do on Redis StackExchange (c#) client:
IDatabase db = redis.GetDatabase();
string value = "abcdefg";
var expires = 1000;
db.StringSet("mykey", value, expires);
...
string value = db.StringGet("mykey");
Console.WriteLine(value); // writes: "abcdefg

Right now I'm using a Map but I would like to make it simple as this example on C#.
    override fun put(collection: String, key: String, value: String, expiresInSeconds: Long) {
        logger.info("Storing key $key into collection $collection")
        val cacheMap = getMapCache(collection)

        cacheMap.put(key, value, 3600, TimeUnit.SECONDS)
    }

    private fun getMapCache(collection: String) = redissonClient.getMapCache<String, String>("any", StringCodec())

When I try to retrieve values fro other clients like C# or Python, I got some strange characters on value like ????????�??????myvalue.
Is there any option to clear/remove those characters on Redisson and store it as plain string?
Is there any option to store it simple as we do in C#?

Here is how you can do the same with Redisson:
RBucket b = redisson.getBucket("mykey", StringCodec.INSTANCE);
b.set("value", 1, TimeUnit.SECONDS);

b.get(); // = "value"

When I try to retrieve values fro other clients like C# or Python, I got some strange characters on value like ????????��??????myvalue.

Because default Redisson codec is MarshallingCodec

Is possible to remove those characters or create a custom codec?

You can use StringCodec instead

Thank you very much!

authors: daviddelucca mrniko


text:
something with skin mixing and creating skins

bro what

authors: rednir xolarinosu

repo: rednir/OsuSkinMixer


text:
🛑 Imagemin API is down

In 4e54257, Imagemin API (https://imagemin.davidrychly.cz/) was down:

HTTP code: 403
Response time: 222 ms

Resolved: Imagemin API is back up in 38dd669.


text:
[CI] CemuStub build task is returning false positive results

Recently, some pull requests made it through CI that broke the CemuStub build.

Project "D:\a\RTCV\RTCV\CemuStub-Vanguard\CemuStub-Vanguard.sln" on node 1 (default targets).

12ValidateSolutionConfiguration:

13 Building solution configuration "Debug|Any CPU".

14ValidateProjects:

15 The project "CemuStub" is not selected for building in solution configuration "Debug|Any CPU".

16Project "D:\a\RTCV\RTCV\CemuStub-Vanguard\CemuStub-Vanguard.sln" (1) is building "D:\a\RTCV\RTCV\RTCV\Source\Frontend\StandaloneRTC\StandaloneRTC.csproj" (2) on node 1 (default targets).

Per the Discord chat, there are two solutions:

Use a different configuration in the RTCV CI (we'll likely want to fix CemuStub-Vanguard's CI too)
Modify CemuStub-Vanguard so that the "Debug|Any CPU" configuration is valid

I'm leaning on #2 as for all our projects, debug should build fine. I'm going to take a look at it just in case CemuStub was set to x64 for some reason (we hook the cemu window but that should still be fine from AnyCpu on a 64 bit system)

Resolved via https://github.com/redscientistlabs/CemuStub-Vanguard/commit/e64b1a59c3cd85d3a5838df3050d3d33753dabe0

authors: NarryG scowalt

repo: redscientistlabs/RTCV


text:
Error: invalid pattern: undefined

Description of the bug/issue
After upgraded from 0.16 to beta.1 I'm now getting an error message and my sagas bomb out and don't run.  Any ideas?
Steps to reproduce the bug/issue

First saga runs via throttle and outputs action
Saga:

function * doStats(){
  if (moment().subtract(statIntervalSec,'seconds').valueOf() > lastTime.valueOf())
  {
    lastTime = moment();
    global.log.info('doing stats');
    yield deviceInfo();
    yield epilogInfo();
  }}

export function * doStatsSagaWithDelay(){
  yield throttle(statIntervalSec*1000,'*',doStats);
}

Action output
{type:"STAT_PHONE"
value:Object
batteryLevel:100
deviceId:"msm8998"
freeDiskStorage:"1677MB"
maxMemory:"263MB"
totalDiskStorage:"-1194MB"
totalMemory:"7904MB"
type:"STAT_PHONE"
usedMemory:"tbd"
Symbol(@@redux-saga/SAGA_ACTION):true

I see this message in console and saga's no longer run

ExceptionsManager.js:71 Error: invalid pattern: undefined
    at matcher (blob:file:///e9088396-ba97-4270-b1c3-e826e1c1584d:90118:13)
    at blob:file:///e9088396-ba97-4270-b1c3-e826e1c1584d:90077:16
    at Array.some (native)
    at Function.<anonymous> (blob:file:///e9088396-ba97-4270-b1c3-e826e1c1584d:90076:23)
    at put (blob:file:///e9088396-ba97-4270-b1c3-e826e1c1584d:89847:34)
    at Object.chan.put (blob:file:///e9088396-ba97-4270-b1c3-e826e1c1584d:89878:9)
    at blob:file:///e9088396-ba97-4270-b1c3-e826e1c1584d:89156:19
    at dispatch (blob:file:///e9088396-ba97-4270-b1c3-e826e1c1584d:71539:20)
    at blob:file:///e9088396-ba97-4270-b1c3-e826e1c1584d:89509:14
    at blob:file:///e9088396-ba97-4270-b1c3-e826e1c1584d:90705:54 ""

15:34:00.950 ExceptionsManager.js:71 The above error occurred in task deviceInfo
    created by rootSaga
Tasks cancelled due to error:
scanRequestHandler
deviceFoundHandler
scanStoppedHandler
disconnectedDeviceHandler
getRSSIforConnectedDevices
connectionSuccessHandler
firmwareLoadedHandler
loadSupportedFwVersion
deviceInfoLoadedHandler
stateRquesthandler
batteryAndImpRequestHandler
deleteRecordingsHandler
requestMissingPageAfterRT
handleMissingPagesAndEventsOnDock
readCharHandler
requestRecordingsHandler
doStatsSaga
doStatsSagaWithDelay
epilogConnectedSaga
crActionsOfInterest
storeCompletedEegPages

package.json
...
  "react": "16.3.1",
    "react-addons-update": "^15.6.2",
    "react-mixin": "^4.0.0",
    "react-native": "0.55.4",
    "react-redux": "^5.0.7",
    "redux": "^3.7.2",
    "redux-saga": "^1.0.0-beta.1",
...

what is deviceInfo ? why you call it as yield deviceInfo()? according to error message that's the error occurred during this call

@restrry   I think deviceInfo is a generator function, and yield deviceInfo() is fine since we allow yielding iterators.  In most situations, yield deviceInfo() has the same effect as yield call(deviceInfo) except for test-ability.
@anwarhamr  the error is thrown inside deviceInfo(), you need to check that function carefully.

I don't see anything that could cause a problem.  In addition the action mentioned in my initial post type:STAT_PHONE is the result of deviceInfo call.
Below is the deviceInfo generator, do you see anything that could be going wrong?  Seems pretty straight forward.  I'll mention again that this all works fine in 0.16.0
export function * deviceInfo(){
  let value = yield   DeviceInfo.getBatteryLevel();

  console.log('DeviceInfo.getTotalDiskCapacity()',DeviceInfo.getTotalDiskCapacity());
  let data = {
    type:c.STAT_PHONE,
    batteryLevel:parseInt(value *100),
    deviceId:DeviceInfo.getDeviceId(),
    totalDiskStorage: convertBytes(DeviceInfo.getTotalDiskCapacity()),
    freeDiskStorage: convertBytes(DeviceInfo.getFreeDiskStorage()),
    maxMemory:convertBytes( DeviceInfo.getMaxMemory()),
    usedMemory:'tbd',//convertBytes( DeviceInfo.getUsedMemory()),
    totalMemory: convertBytes(DeviceInfo.getTotalMemory()),
    //todo
    //storagePageCount
    //pagesPushedToCloudCount
  };
  yield put ({type:c.STAT_PHONE,value:data});

}

Hey @anwarhamr , I can not tell why the error appears. The error invalid pattern: undefined is thrown from src/internal/matcher.js#L21-L23, you could add a breakpoint here and it should become much easier to debug.
You may need to add the breakpoint in the corresponding redux-saga distributions files. Find internal\matcher.js in node_modules/redux-saga/es or in node_modules/redux-saga/lib.

@shinima OK that did it for me.  The problem is mine but I think we can do better here with more information when an error occurs.  Here is my suggestion, I'll make the change if you think it worthy.
matcher.js has an array function that can catch and rethrow the error with the pattern variable or something further up the chain that would point to the correct saga that is causing the error.  In my case it wasn't the deviceInfo saga at all but another saga in another file that had an action constant in the the actionChannel list that was undefined... See saga below.
function * crActionsOfInterest(){

  const chan = yield actionChannel(
    [
      'ERROR',
      c.DEVICE_INFORMATION_LOADED,
      c.DEVICE_DISCONNECTED,
      c.EPILOG_READY,
      c.EPILOG_CLOCK_SET,  <-- this value was undefined.
      c.EPILOG_DELETE_RECORDINGS_COMPLETE,
      c.EPILOG_EVENT_DATA_RECEIVED,
      c.EPILOG_MESSAGE_DATA_RECEIVED,
      c.EPILOG_RA_EEG_DATA_RECEIVED,
      c.EPILOG_RT_EEG_DATA_RECEIVED,
      c.STAT_EPILOG,
      c.STAT_PHONE,
    ]
  );
  let a = null;
  try {
    while (true) {
...}}

Here is my suggested change:
var array = function array(patterns) {
  return function (input) {
    return patterns.some(function (p) {
     try{
      return matcher(p)(input);
     }
      catch(e){
       throw new Error('Pattern match error ' + e.message + ' for value in:'+patterns) // It would be great if it possible to include a saga/function/generator name...
}
    });
  };
};
...
function matcher(pattern) {
  // prettier-ignore
  var matcherCreator = pattern === '*' ? wildcard : _utils.is.string(pattern) ? string : _utils.is.array(pattern) ? array : _utils.is.stringableFunc(pattern) ? string : _utils.is.func(pattern) ? predicate : _utils.is.symbol(pattern) ? symbol : null;

  if (matcherCreator === null) {
    throw new Error("invalid pattern: " + pattern);
  }

  return matcherCreator(pattern);
}

I wouldnt like to be so defensive in the code. I dont fully understand the problem at hand (why wrong saga was reported to be causing the problem) - could u reproduce this on something like codesandbox.io ? It's possible that there is a bug sitting somewhere else and could be fixed.

Here is a reproduction.

the problem is that we don't check if array contains only valid patterns. so when user calls
yield actionChannel([undefined])
we just add a taker with passed array https://github.com/redux-saga/redux-saga/blob/master/packages/core/src/internal/proc.js#L638-L652
but when use call put() channel throws trying to call taker https://github.com/redux-saga/redux-saga/blob/master/packages/core/src/internal/matcher.js#L4
so actually error happens during the put.
we can fix the problem if check that array contains valid patterns like
//@redux-saga/is
export function pattern (candidate) {
  if(candidate){
    if(string(candidate) || symbol(candidate) || func(candidate)) return true
    if(array(candidate) && candidate.every(pattern)) return true
  }
  return false;
}

sure, seems like a good check 👍

authors: Andarist anwarhamr restrry shinima

repo: redux-saga/redux-saga

license: mit


text:
Increased performance of combineReducer result function

name: "Improvements of performance of combineReducer and combineReducer's result"
about: Improvements of performance of combineReducer and combineReducer's result
PR Type
Does this PR add a new feature, or fix a bug?
It's just a refactoring with improvements of performance
Why should this PR be included?
It's not necessary to check errors in a positive case on each call to function combination.
I do not know which kind of issue I should create for this improvement. Because this is not a bug.
Checklist

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Is there an existing issue for this PR?

link issue here

[x] Have the files been linted and formatted?
[x] Have the docs been updated to match the changes in the PR?
[x] Have the tests been updated to match the changes in the PR?
[x] Have you run the tests locally to confirm they pass?

It's not a new feature or bugfix. So I do not know what to write here.

Does this have any measurable performance improvement?

Does this have any measurable performance improvement?

No, I do not did measurements. Is it not clear that
function f() {
  // code
}

is faster than
function f() {
  if (someError) {
    throw someError
  }
 // code as in the example above
}

Also I think that this code is not optimal:
for (let i = 0; i < arr.length; i++) {
  const elem = arr[i]
  if (typeof elem === 'undefined') {
     // something
  }
  if (typeof elem === 'function') {
   // something else
  }
}

It should be slower than:
for (let i = 0; i < arr.length; i++) {
  const elem = arr[i]
  if (typeof elem === 'undefined') {
     // something
    continue
  }
  if (typeof elem === 'function') {
   // something else
  }
}

If arr will contain N undefined elements. We will not execute if (typeof elem === 'function') N times.

combineReducers shouldn't be called that often. If it's your bottleneck, you have other issues. I'm only seeing a 7% difference in my system. It's not really worth changing right now. Thanks anyways!

combineReducers shouldn't be called that often. If it's your bottleneck, you have other issues. I'm only seeing a 7% difference in my system. It's not really worth changing right now. Thanks anyways!

The main improvement was not about improvement of combineReducer performance But about improvement of performance of reducer created by combineReducer (That is called after each action dispatch)
Thank you for your, review.

authors: timdorr whiteand

repo: reduxjs/redux


text:
World::each causes Internal compiler error if class has an implementation file

This header file compiles and works perfectly:
#pragma once

#include "ECS.h"

struct TestComp {
	int x;
	int y;
};

class TestClass {
public:
	TestClass() {}
	virtual ~TestClass() = default;

	void update(ECS::World* world, float dt) {
		using namespace ECS;
		world->each<TestComp>([&](Entity* ent, ComponentHandle<TestComp> testComp) {
			testComp->x += 1;
		});

	}
};

however, as soon as an implementation file is present, for example TestClass.cpp, even if it just contains
#include "TestClass.h"

Visual Studio shows an internal compiler error (C1001) at the last line of the implementation file. This error remains whatever i do, using inline, moving the implementation to the .cpp file and so on.
Im running the latest Visual Studio enterprise 2017, v. 15.5.7

I am unable to reproduce said issue in VS2017. C1001 indicates an internal compiler error, can you post the full error message? It may have to do with what optimization settings you are using. Alternatively, zip the entire project and post it here (or email it to me at sam at xbloom dot io).
An implementation file being present is likely to be a red herring, by the way. Header files are not compiled unless included by an implementation file (unless you change the default settings).

Side-note: Unless you have some requirements I do not know about, I suggest making TestClass a subclass of EntitySystem (see here)- otherwise you will have to manage calling update manually rather than just calling world->tick(deltaTime).

This is an empty project containing just ECS.h and a test class demonstrating the issue, for me this project fails to compile, take a look:
ECSTest.zip
There is nothing more to the error message than just "Internal compiler error". From Stackoverflow, it seems like this error is not "supposed to appear" and should be reported to Microsoft as a bug in the VC++ compiler. It might just be one but i was wondering if you ever encountered this or if it recently popped up.

Side-note: Unless you have some requirements I do not know about, I suggest making TestClass a subclass of EntitySystem (see here)- otherwise you will have to manage calling update manually rather than just calling world->tick(deltaTime).
Usually im using your classes how they're supposed to be used :) Was just trying to make the example as short as possible

I'm still unable to reproduce the issue, even using your project files. It's possible I'm running a different version of the compiler (VS 15.4.1, not sure the exact compiler version) but unfortunately I can't upgrade on this machine.
It sounds like you might have actually hit a bug in the compiler somehow, and I can't seem to find any information relating to it. The best I can find is that there are some newer optimizations that might be breaking something in the compiler. Try rewriting things to be slightly different (but in effect make them do the same thing). Change the type of variables (i.e. use float or uint16_t instead of int) and see what happens, try adding code before/after the call to world->each, etc. Optimizations are fickle and if that is indeed what is causing the compiler bug then changing almost anything should change the result you get.

Huh, then this might have been just introduced in one of the last couple of updates. I have tried changing things quite a bit, this issue originally popped up in a much bigger class, the method looks something like this:
void RenderingCore::render(ECS::World* world)
{
	m_display->clear();
	m_pbrShader->use();
	m_pbrShader->updateCamera(*m_camera);

	using namespace ECS;
	world->each<Transform, Model>([&](Entity* ent, ComponentHandle<Transform> transform, ComponentHandle<Model> model) {
		m_pbrShader->setTransform(transform.get());
		model->draw();
	});

	m_cubemap->render(*m_camera);
	m_display->update();
}

where Transform and Model are both relatively large classes themselves, so there's quite a bit of variation to variable types and code before / after the call to World::each. I've also tried two different optimization levels, once off (/Od) and once on Release default (/O2). I suppose we'll just have to wait for the next VS update which hopefully fixes this issue.

Odd. I'll see if I can update my compiler tomorrow and repro this. At the very least, we might have a bug report for the MSVC team.
On Mar 1, 2018 7:17 PM, Jonathan Kunstwald notifications@github.com wrote:
Huh, then this might have been just introduced in one of the last couple of updates. I have tried changing things quite a bit, this issue originally popped up in a much bigger class, the method looks something like this:
void RenderingCore::render(ECS::World* world)
{
m_display->clear();
m_pbrShader->use();
m_pbrShader->updateCamera(*m_camera);
    using namespace ECS;
    world->each<Transform, Model>([&](Entity* ent, ComponentHandle<Transform> transform, ComponentHandle<Model> model) {
            m_pbrShader->setTransform(transform.get());
            model->draw();
    });

    m_cubemap->render(*m_camera);
    m_display->update();

}
where Transform and Model are both relatively large classes themselves, so there's quite a bit of variation to variable types and code before / after the call to World::each. I've also tried two different optimization levels, once off (/Od) and once on Release default (/O2). I suppose we'll just have to wait for the next VS update which hopefully fixes this issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fredxdev%2FECS%2Fissues%2F5%23issuecomment-369807807&data=02|01||3a67af22ca514791e16308d57fec1759|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636555574334646274&sdata=HloNRI2%2FXJrUtBexXHJT5xlM2Deae82amYpb3DvCVY4%3D&reserved=0, or mute the threadhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAc2MSOM7PuWhC_sGRzIii6NwmbI_c-Dks5taLm3gaJpZM4SZT8b&data=02|01||3a67af22ca514791e16308d57fec1759|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636555574334646274&sdata=hMw9vCpwzXxuN3IHwP0kKH3UFTJD%2F9ksBjqN87K2uAo%3D&reserved=0.

we might have a bug report for the MSVC team

I'll wait for your reproduction first, i find it more likely that my machine / VS install is somehow broken than this actually being a VC++ bug.

That's always possible. You might want to see if a clean install fixes it.
On Mar 1, 2018 7:23 PM, Jonathan Kunstwald notifications@github.com wrote:
we might have a bug report for the MSVC team
I'll wait for your reproduction first, i find it more likely that my machine / VS install is somehow broken than this actually being a VC++ bug.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fredxdev%2FECS%2Fissues%2F5%23issuecomment-369808600&data=02|01||9a2c0803c70a4e5ef3a508d57fece9ac|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636555577864718893&sdata=TzSsYHECA%2BCdDBMjpVkERmD24ukHzCtaGBI7Gn7DhEE%3D&reserved=0, or mute the threadhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAc2Meh1nNka-9IZ6ss1TwzKZId5hDMqks5taLsYgaJpZM4SZT8b&data=02|01||9a2c0803c70a4e5ef3a508d57fece9ac|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636555577864718893&sdata=Ze0LqVXJv3u%2FVz%2Bop6EvisX%2FRLQEGKH1JjBvXwyj9%2Fc%3D&reserved=0.
we might have a bug report for the MSVC team
I'll wait for your reproduction first, i find it more likely that my machine / VS install is somehow broken than this actually being a VC++ bug.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fredxdev%2FECS%2Fissues%2F5%23issuecomment-369808600&data=02|01||9a2c0803c70a4e5ef3a508d57fece9ac|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636555577864718893&sdata=TzSsYHECA%2BCdDBMjpVkERmD24ukHzCtaGBI7Gn7DhEE%3D&reserved=0, or mute the threadhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAc2Meh1nNka-9IZ6ss1TwzKZId5hDMqks5taLsYgaJpZM4SZT8b&data=02|01||9a2c0803c70a4e5ef3a508d57fece9ac|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636555577864718893&sdata=Ze0LqVXJv3u%2FVz%2Bop6EvisX%2FRLQEGKH1JjBvXwyj9%2Fc%3D&reserved=0.

I just tested the demo project on a different machine, also with VS 15.5.7, and i get the same error.

Looks like it isn't just you. VS 15.5.7 gives me the same issue. I guess it's a bug in the compiler introduced in 15.5.

Looks like adding the /P flag lets it compile successfully. Might be good as a temporary workaround.

adding the /P flag lets it compile successfully

This instead gives me a linker error LNK1104 "Can't open main.obj". That is for the test project, in my real project its a seemingly unrelated other .obj. But good to know its not just me. Is it reasonable to submit a bug report to Microsoft?

It might be. Looks like they have a process to do so here: https://docs.microsoft.com/en-us/visualstudio/ide/how-to-report-a-problem-with-visual-studio-2017
adding the /P flag lets it compile successfully
This instead gives me a linker error LNK1104 "Can't open main.obj". That is for the test project, in my real project its a seemingly unrelated other .obj. But good to know its not just me. Is it reasonable to submit a bug report to Microsoft?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fredxdev%2FECS%2Fissues%2F5%23issuecomment-370049073&data=02|01||f6d68cc6874a487f363b08d5807f8fab|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636556207707781250&sdata=O4Q8ukr2rsf7YiQ6%2Bsn0SKvsEE5Jd9JM%2FcE%2FR9bufBA%3D&reserved=0, or mute the threadhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAc2MZBl1eiLqKdy5bG4a81RouMUjbJ6ks5tabEggaJpZM4SZT8b&data=02|01||f6d68cc6874a487f363b08d5807f8fab|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636556207707937510&sdata=EVg8Au7XJSWj5kKs%2BTQguLIn51xmAyRW8BQzm0A6p2c%3D&reserved=0.

Here's the bug report:
https://developercommunity.visualstudio.com/content/problem/206634/internal-compiler-error-in-vs-1557.html

The bug report has been answered, and i can confirm that it works in the 15.6 preview!

Great!

authors: jkunstwald redxdev

repo: redxdev/ECS


text:
Document CloudFront options when using direct uploads?

Hello, just noticed that on production when using S3 + CloudFront, the uploader hits CDN with an OPTIONS request, which is filtered out by default when creating a new CF distribution.
When used with a sample JavaScript code to enable/disable the submit button, that of course resulted in submit button to stay disabled.

@yaroslav Aparently presigned URLs should not go through the CDN. See #301 which I just opened. I'm curious at how you were able to get this to work. Which gem and Ruby versions are you using? Can you share your Refile initializer?
I was not able to get this to work. My URLs are becoming malformed. See #301 for more details.

I'm curious at how you were able to get this to work

I guess I did not! I was playing around to resolve #300, enabling and disabling the JS library as well as direct uploads. Since everything was working locally, I just pushed direct uploads to production once and ran into mentioned issues.

When using presigned uploads, I am seeing the following requests in this order:

A GET request to the presign endpoint through the CDN.
An OPTIONS request to the S3 bucket (not to Cloudfront).
A POST requet to the S3 bucket.

@yaroslav Can you verify that the OPTIONS request is made to the S3 Bucket, not the CDN? If so, this issue can be closed.

In my case, OPTIONS went to CloudFront.

authors: abitdodgy thomasklemm yaroslav

repo: refile/refile


text:
[US] List projects

Estimated story points: 3
Description

As a user I can see all projects on an overview page.
I want to see their name, max hours and optionally an account name.

Acceptance criteria

All projects are listed with all the wanted information.

Closed by #40

time: 2h

repo: reform-org/reform


text:
Update meta.yaml

Set lower bound for r-ravetools to >=0.1.0

Not sure how it is configured, but I also don't have write permissions here. But I can directly edit and push to the specific autotick branch. I've added the min bound on that branch, so go ahead and close this.

authors: dipterix mfansler


text:
Sharing something from a playlist fails

Describe the bug
Sharing something from a playlist fails
To Reproduce

go to any playlist on youtube
start a video
try to share the video

Expected behavior
Video starts with or without the rest of the playlist
Screenshots (if appropriate)

Environment

Cast Kodi version:
Browser version:
Kodi version:
Kodi add-on version (if appropriate):

I tested sending a video from a playlist and it works.
Could you give me more information?
* What do you mean by "fails"?

* Can you give a video with its playlist?

* What are the versions of Cast Kodi, Browser, Kodi and add-on for YouTube?

Youtube 6.8.20+matrix.1
Kodi 19.1
Firefox 107.0.1 on Win11
It fails like this: https://pastebin.com/UKZPCVxF
It seems to only affect my playlists, not some random, public ones.
The moment I remove the playlist parameters it works.

We see in the logs that you send the WL playlist. This is the Watch Later playlist. Cast Kodi sends the playlist, but the Add-on:YouTube (plugin.video.youtube) can't read it. The Watch Later playlist is special because it's unique for each user. I think that plugin.video.youtube doesn't support the Watch Later playlist with STRM URL (plugin://plugin.video.youtube/play/?playlist_id=WL). You would have to open an issue in plugin.video.youtube to add this feature.

authors: regseb widardd

repo: regseb/castkodi


text:
🛑 SmartProtection is down

In aae5c3e, SmartProtection (https://smartprotection.com) was down:

HTTP code: 404
Response time: 242 ms

Resolved: SmartProtection is back up in a3d61ad after 11 minutes.

repo: reinaldoleon/monitoring


text:
🛑 Laboratory Borrowing (labfacility.apps.binus.ac.id) is down

In b7f65af, Laboratory Borrowing (labfacility.apps.binus.ac.id) (https://labfacility.apps.binus.ac.id/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Laboratory Borrowing (labfacility.apps.binus.ac.id) is back up in a72da45.


text:
🛑 BINUSMAYA (Academic Services) is down

In 770738b, BINUSMAYA (Academic Services) (https://acadservices.apps.binus.ac.id/LoginAD.php) was down:

HTTP code: 503
Response time: 818 ms

Resolved: BINUSMAYA (Academic Services) is back up in 3d2a8c5.


text:
🛑 GreatNusa.com is down

In 0bec153, GreatNusa.com (https://greatnusa.com) was down:

HTTP code: 403
Response time: 65 ms

Resolved: GreatNusa.com is back up in 145ef4e.


text:
🛑 BINUS Career is down

In 73f108a, BINUS Career (https://binuscareer.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: BINUS Career is back up in 3b3935e.


text:
Need way to handleRequest inside REST interface

Here is begin of question https://stackoverflow.com/questions/44705196/what-is-the-right-way-to-access-to-instance-of-class-methods-outside-scope
The problem, that I want to implement REST interface, and make on of URL works not as REST but as simple handleRequest . I found that all solutions is pretty hacky.

Hehe use vibe.web.web for working with the request object - REST isn't meant for this.

There are many great examples - this is one of them: https://github.com/rejectedsoftware/vibe.d/blob/master/examples/web/source/app.d

You can also use @before to get access to the request/response objects:
class MyAPIImpl : MyAPI {
    @before!getReq("req") @before!getRes("res")
    void getTest(HTTPServerRequest req, HTTPServerResponse res)
    {
        res.writeBody("Hello!");
    }
}

private HTTPServerRequest getReq(HTTPServerRequest req, HTTPServerResponse res) { return req; }
private HTTPServerResponse getRes(HTTPServerRequest req, HTTPServerResponse res) { return res; }

@before and @after are generally discouraged these days because of their unclean semantics, but for cases like this they are actually a fitting tool.

authors: bubnenkoff s-ludwig wilzbach


text:
Fix ConnectionPool and LocalTaskSemaphore

These were now tested in a postgresql driver.

I think the priority ordering needs some work, a task with the highest priority should be allowed to be in front


text:
Merge template repository changes: remal-gradle-plugins/template - autoclosed

Template repository changes.
If you close this PR, it will be recreated automatically.

Autoclosing the PR, as no files will be changed after merging the changes from template-sync branch into main branch.

repo: remal-gradle-plugins/test-source-sets


text:
Remove Interactive Provider

This is in preparation for "protected mode" for stacks, by allowing the
caller of update_stack on the provider to choose whether or not to force
interactive mode.
This also rolls back a small diff when we were preparing to use the
interactive provider when using the diff command.

I use the interactive provider for most stacks when I'm developing or updating a blueprint. Does it make sense to allow the stack to force, but still make it possible to enable manually in the command line?

@phobologic Yep, 100% my fault for not reading the code before asking. Removing the duplicate code seems like a great idea.

Thanks!

Thanks folks!

authors: danielkza phobologic


text:
replace association details w/ association options

Replaces any mention of details with options in associations_spec so it closely matches the description in association.rb. nothing glamorous :smile_cat:

closing since we have other plans to refactor associations

repo: remiprev/her


text:
🛑 Remix Dashboard is down

In 2f2b2b7, Remix Dashboard (https://remix.fairuse.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Remix Dashboard is back up in 73d055d after 4 hours, 2 minutes.

repo: remix-bot/status


text:
Support React.lazy in react 18

React lazy support can be achieved in Remix but the compiler currently bombs out on dynamic imports:
https://github.com/remix-run/remix/blob/9021fab2aa727ea423ed089550998227796f777c/packages/remix-dev/compiler/assets.ts#L80
Updating the linked "else" above to:
} else if (output.entryPoint.startsWith("browser-route-module:"))

takes care of filtering out dynamically imported modules from the routes in the asset manifest and stops compilation from blowing up, as well as makes React.lazy "just work" with these relevant changes:
entry.client.tsx
import { createRoot } from "react-dom";
import { RemixBrowser } from "remix";

const root = createRoot(document, { hydrate: true });
root.render(<RemixBrowser />);

entry.server.tsx
import { PassThrough } from "stream";
// @ts-ignore
import { pipeToNodeWritable } from "react-dom/server";
import type { EntryContext } from "remix";
import { RemixServer } from "remix";

function renderToStringWithWritable(element: any, timeout = 10000) {
  return new Promise<string>((resolve, reject) => {
    const writable = new PassThrough();
    let res = "";
    writable.on("data", (d) => {
      res += String(d);
    });

    writable.on("end", function () {
      resolve(res);
    });

    const { startWriting, abort } = pipeToNodeWritable(element, writable, {
      onCompleteAll() {
        startWriting();
      },
      onError(err: Error) {
        reject(err);
      },
    });

    setTimeout(abort, timeout);
  });
}

export default async function handleRequest(
  request: Request,
  responseStatusCode: number,
  responseHeaders: Headers,
  remixContext: EntryContext
) {
  let markup = await renderToStringWithWritable(
    <RemixServer context={remixContext} url={request.url} />
  );

  return new Response(markup, {
    status: responseStatusCode,
    headers: {
      ...Object.fromEntries(responseHeaders),
      "Content-Type": "text/html",
    },
  });
}

It seems to me that pipeToNodeWritable is just an alternative API to renderToString that doesn't really replace it.

I believe this is incorrect. From https://github.com/reactwg/react-18/discussions/22

[renderToString] continues to work. It doesn’t support new features so we recommend switching to pipeToNodeWritable.

@jacob-ebey I have React.lazy working with React 18 streaming SSR here: https://github.com/tom-sherman/remix-react-18/commit/4f0dab8383945bea6968e60a4967de21755fbc5e
I think this can be closed maybe?

authors: jacob-ebey tom-sherman

repo: remix-run/remix


text:
Extend and improve documentation on subcommands (#890)

In an order to eventually close #890, I authored this PR, I hope you like it.
Feel free to perform some polishment like you did before.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0003630). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1187   +/-   ##
=========================================
  Coverage          ?   94.32%
  Complexity        ?      455
=========================================
  Files             ?        2
  Lines             ?     6660
  Branches          ?     1791
=========================================
  Hits              ?     6282
  Misses            ?      101
  Partials          ?      277

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/picocli/AutoComplete.java
97.01% <0.00%> (ø)
141.00% <0.00%> (?%)

src/main/java/picocli/CommandLine.java
94.16% <0.00%> (ø)
314.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0003630...3a5c4f4. Read the comment docs.

Thank you for the contribution again!
I plan to merge this soon, I have some other commitments I need to take care of first.

Merged. Thank you for the contribution!
I am also rewriting and rearranging some of the other subsections of the Subcommands section.
About the new Quick Guide example:

The ISOCodeResolver application has two subcommands, language and country, that may be used to either resolve either languages or country codes following the ISO standard.

Can you clarify (ideally with links) which ISO standard(s) this refers to?

Ah sorry, I found that the code example references the exact ISOs. Got it.

authors: codecov-commenter deining remkop

repo: remkop/picocli


text:
Generate valid type declarations for generated enum terms

Fixes #69.
Possible additional steps:

Regenerate the index.d.ts files
Enable checking type declaration files, by deleting "skipLibCheck": true

This should be merged ASAP

authors: DanielRose thelinuxlich

repo: remorses/genql


text:
Concurrency dependency and compatability

This may or may not qualify as an issue for the library as a whole.
The 0.5.0.0 release of NodaMoney on NuGet adds a project dependency upon System.Collections.Concurrent, for the purpose of two ConcurrentDictionaries in the CurrencyRegistry. System.Collections.Concurrent does not appear to be broadly compatible with all PCL profiles, or at least the one that we're dependent upon (78), and so we're unable to use this version. Given the apparently very limited application of System.Collections.Concurrent classes, I wanted to at least float the possibility of removing the dependency in future releases (would locks suffice?).
I know I probably should just utilize a private fork and address this issue on my own, but my organization won't be supporting VS2015/C#6 for a while yet, which means needing to base off months old code before the conversion, and just generally putting up with a whole bunch of maintenance and maintainability headaches. :)
Thanks for reading; great library! I dearly want to make use of it. :)

Thanks for the comment!
You normally would change currencies only on the startup of an application, so the Concurrent Dictionary is probably overkill for the CurrencyRegistry.
The focus is to have as less as possible dependencies, so I will check the compatibility with the profiles and improve this in the next version.

The dependency to System.Collections.Concurrent has been removed (replaced by locks), so you should be able to use the next version again.

authors: remyvd smattox

repo: remyvd/NodaMoney


text:
Code assumes neo4j server is accessable at localhost:7474

In RestService:
def rollbackTransaction(id: TransactionId) {
// we don't wait for a response here
pipeline(HttpRequest(DELETE, s"http://localhost:7474/db/data/transaction/$id"))
}
That won't work in most real-world cases.

Good catch, totally overlooked that one. Thanks for reporting!

authors: cornerman sheldon-white

repo: renesca/renesca


text:
deps: update dependency com.google.api.grpc:grpc-google-cloud-translate-v3 to v1.1.4

This PR contains the following updates:

Package
Update
Change

com.google.api.grpc:grpc-google-cloud-translate-v3
patch
1.1.4-SNAPSHOT -> 1.1.4

Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Codecov Report

:exclamation: No coverage uploaded for pull request base (reproduce@97fbd5c). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             reproduce       #4   +/-   ##
============================================
  Coverage             ?   69.90%
  Complexity           ?      220
============================================
  Files                ?       23
  Lines                ?     1668
  Branches             ?       46
============================================
  Hits                 ?     1166
  Misses               ?      457
  Partials             ?       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97fbd5c...6fa9f66. Read the comment docs.

authors: codecov-io renovate-tests

repo: renovate-tests/java-translate


text:
tensorrt-llm: 0.9 -> 0.10, triton: 2.42.0 -> 2.44.0

Open questions:

[x] Should we keep detokenizing in predict.py instead of postprocessing?
[x] It looks like the required config changed. Notably, enable_trt_overlap disappeared and a whole bunch of cache options got added.
[x] Yorick: do some testing.

enable_trt_overlap is set to false in a lot of places, we will probably need to change that
we should review the new configuration options as well

authors: technillogue yorickvP

repo: replicate/cog-triton


text:
wip / PoC of hostnet flags

$ make kots
$ bin/kots pull kots-dex-2 --license-file ~/Desktop/cs-kots-dex-2.yaml  --admin-console-host-network --rootdir .

Enter a new password to be used for the Admin Console: ••••••••
  • Pulling upstream ✓
  • Creating base ✓
  • Creating midstream ✓

$ cat app-slug/upstream/admin-console/minio-statefulset.yaml | grep -i host
      hostNetwork: true

Yeah we need to consolidate, will plan on doing that :)
__
Dexter Horthy
Forward Deployed Engineering
Replicated
replicated.com ( https://www.replicated.com )
On Sun, Feb 02, 2020 at 1:02 PM, Andrew Lavery < notifications@github.com > wrote:

@laverya commented on this pull request.
In cmd/ kots/ cli/ pull. go (
https://github.com/replicatedhq/kots/pull/299#discussion_r373874775 ) :

CreateAppDir: true, - HelmOptions: v.GetStringSlice("set"), -
RewriteImages: v.GetBool("rewrite-images"), + HelmRepoURI:
v.GetString("repo"), + RootDir: ExpandDir(v.GetString("rootdir")), +
Namespace: v.GetString("namespace"), + Downstreams:
v.GetStringSlice("downstream"), + LocalPath:
ExpandDir(v.GetString("local-path")), + LicenseFile:
ExpandDir(v.GetString("license-file")), + ExcludeKotsKinds:
v.GetBool("exclude-kots-kinds"), + ExcludeAdminConsole:
v.GetBool("exclude-admin-console"), + SharedPassword:
v.GetString("shared-password"), + CreateAppDir: true, + HelmOptions:
v.GetStringSlice("set"), + RewriteImages: v.GetBool("rewrite-images"), +
AdminConsoleHostNetwork: v.GetBool("admin-console-host-network"),

why isn't this also called UseHostNetwork like in kotsadmtypes.DeployOptions
?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (
https://github.com/replicatedhq/kots/pull/299?email_source=notifications&email_token=AA4OZLMCLSNDTUOBILXBMRTRA4YFJA5CNFSM4KOVQDDKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCT5JPIQ#pullrequestreview-351967138
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AA4OZLKMHFOKCOYDLGDXVC3RA4YFJANCNFSM4KOVQDDA
).

Got us to
kotsadm-685547679c-s9qzt           1/1     Running             0          5m43s
kotsadm-api-569b59df-dwpjr         0/1     ContainerCreating   0          5m43s
kotsadm-migrations-1580678167      0/1     Error               6          5m43s
kotsadm-minio-0                    1/1     Running             0          5m43s
kotsadm-operator-fc5bbcd94-7kqd8   1/1     Running             0          5m43s
kotsadm-postgres-0                 1/1     Running             0          5m43s

Migrations crashlooping because there's no DNS names when you use hostnetwork 😞 it can't lookup postgres:
dex@dex-cni-bootstrap-3:~$ kubectl logs -f kotsadm-migrations-1580678167
dial tcp: lookup kotsadm-postgres on 169.254.169.254:53: no such host
Error: dial tcp: lookup kotsadm-postgres on 169.254.169.254:53: no such host
Usage:
  schemahero apply [flags]

API is stuck due to this mount error, and I still haven't resolved the port conflict:
Events:
  Type     Reason           Age                    From                          Message
  ----     ------           ----                   ----                          -------
  Normal   Scheduled        5m16s                  default-scheduler             Successfully assigned default/kotsadm-api-569b59df-dwpjr to dex-cni-bootstrap-3
  Warning  FailedMount      5m15s                  kubelet, dex-cni-bootstrap-3  MountVolume.SetUp failed for volume "kotsadm-api-token-8csd2" : failed to sync secret cache: timed out waiting for the condition
  Warning  NetworkNotReady  15s (x152 over 5m16s)  kubelet, dex-cni-bootstrap-3  network is not ready: runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:docker: network plugin is not ready: cni config uninitialized

Migrations crashlooping because there's no DNS names when you use hostnetwork 😞 it can't lookup postgres:

Sounds like we'll need to have parameterized addresses for minio, postgres, the API pod and the kubectl main pod then - because this won't just be an issue for the migrations pod
Also, we'll need to handle the port forwarding bit somehow - as it is right now, I can't see that working properly. Providing nodeip:hostport as the link and not doing any forwarding at all might be the easiest solution

@laverya @marccampbell gonna close this one for now

authors: dexhorthy laverya

repo: replicatedhq/kots


text:
Dev env - always patch even if up & cache yarn packages

What this PR does / why we need it:

Which issue(s) this PR fixes:

Does this PR require a test?

NONE
Does this PR require a release note?

NONE

Does this PR require documentation?

NONE

Merging as this only affects the dev env.


text:
SqlCipherDatabaseSource is final in 1.6.0

1.6.0 made SqlCipherDatabaseSource final for no reason. Also, onConfigure(ConfigurationBuilder builder) is final for no reason. It was used for setting up things like quoting table and column names.
Could these be made non-final again?

@npurushe onConfigure(builder: ConfigurationBuilder) is still not open in 1.6.1, hence it cannot be overridden for configuring the database.

repo: requery/requery


text:
Viewer spawns new view as tabs when it shouldn't

https://github.com/rerun-io/rerun/assets/2910679/52905840-d3e1-4b75-a5b8-8fcba8288222

The problem is that the detection of user-interaction on the egui_tiles::Tree is not good enough. It compared the whole tree, but that will include detecting changes due to simplification, which we do in of adding a parent tab container to all our view tiles.
This can be fixed by https://github.com/rerun-io/egui_tiles/pull/28 but before I can deploy that I need to wait for a new release of egui_commonmark, because egui_tiles now depend on egui 0.23…

authors: emilk teh-cmc

repo: rerun-io/rerun


text:
The new self-contained widget is slow in google colab

Our new rerun_notebook widget is significantly slower to load in colab than the old iframe approach.
Sample notebook demonstrating the issue:
https://colab.research.google.com/drive/1VjQsSHvhfsnQx8TEClTc7L0vDH6Fub-l#scrollTo=oI__Aa8JTpK9
In general it takes 6-8 seconds to load, even on a 2gig fiber internet connection.
For some reason we spend significant time waiting for the server to send to the bundled js asset:

Also, it seems like the way in which the tunneling happens possibly prevents things from being cached properly.

I'm curious if this will require an approach where we try to load an http-hosted file, and if that fails then we fall back on something fetched from the anywidget module?


text:
Formatting deletes commented (jsx) code if comment makes the parent empty

I just noticed while commenting out some JSX that it would delete the comment when it left the parent element without any elements inside of it.
To recreate:
Comment out all of the contents of an element

//

Format the code and it will remove all of the commented code:

VS Code:
Version: 1.59.0-insider (Universal)
Commit: b805d2e94937976bb17d0439f57fcd3a9d423c31
Date: 2021-07-20T05:12:13.059Z (1 wk ago)
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Darwin x64 20.5.0
(I'm not sure exactly what this extension is using for formatting, so apologies if this is the wrong repo! I'd be happy to report it in the formatting project if that's more appropriate.)

Thanks. Would you report it in the ReScript syntax repository?
There might be an issue there already.

There's an open issue on syntax repo https://github.com/rescript-lang/syntax/issues/403

authors: amiralies cristianoc wfendler

repo: rescript-lang/rescript-vscode


text:
Revert the Platform.os changes?

In #771 and #774, I changed Platform.os from an abstract type to a polymorphic variant.
This allows us to use the more convenient
if Platform.os === #ios {
  ...
}

instead of
if Platform.os === Platform.ios {
  ...
}

which is fine.
It also allows us to do
switch Platform.os {
  | #ios => ...
  | #android => ...
  | _ => ...
}

which is problematic as it compiles to something like
var match = ReactNative.Platform.OS;

if (match === "ios") {
  ...
} else if (match === "android") {
  ...
} else {
  ...
}

which will break Metro bundler's inlining (see a previous discussion in #239 for more details about this).
So I am not sure anymore if we should introduce a breaking change that invites people to use a problematic pattern. What do you think @MoOx?

I guess if we document this that can be enough ?

Documenting it is the alternative, yes. If you prefer that, let's go that way.

Leaving this open as a reminder for the documentation. 🙂

What we could do though is add the existing constants Platform.ios etc. for compatibility (to be deprecated and removed later). What do you think, @MoOx?

Ah, no, that won't work, polymorphic variants cannot have @inline.

authors: MoOx cknitt


text:
Unable to use () in short statement

Software name that are abbreviations are written in a long format in the short statement. For example
The Astrophysical Multipurpose Software Environment (AMUSE) combines existing numerical codes in an easy to use Python framework. With AMUSE you can simulate objects such as star clusters, proto-planetary disks and galaxies.
The () chars are not allowed in https://github.com/research-software-directory/backend/blob/fb586b3bde46f3b067f6bdbb98c54d65cc9b88b3/schemas/software.json#L526.
Should we allow these chars?

same for

'
/
+
?

I think having ( and ) in your shortStatement is testament that your text could be better so I am opposed to include them in the regexp.

authors: jspaaks sverhoeven


text:
feat(font): Include Roboto as a fallback font

Hi,
Gmail web supports Roboto font natively, include that as a fallback option.
Please let know if this looks good.
Thanks,
Mayank

Yahoo, Gmail on iOS and Apple Mail don't seem to support Roboto as a font natively. But thanks for making the PR either way.

repo: resend/react-email


text:
Fix is prop

Currently <Button is='a'>hello world</Button> Will render a <button> markup instead of <a>.

We currently only support this on Link which seems sufficient if there are cases for other components please reopen.

repo: resin-io-modules/resin-components


text:
Needs SD card

What is the best micro SD card? @jviotti recently mentioned being happy with the [SanDisk Ultra] (https://www.sandisk.com/home/memory-cards/microsd-cards/ultra-microsd).

@sonyagreen that is a good option

@curcuz cool?

authors: curcuz sonyagreen

repo: resin-io-projects/boombeastic


text:
Error message on Pi: 7 short blinks

On a Raspberry Pi I receive 7 short blinks from the 'ACT' LED. What does it mean?
Probably someone should add this error to the documentation page! Thanks!
http://docs.resin.io/#/pages/troubleshooting/error.md

realised it's the Pi error blink message:
http://elinux.org/R-Pi_Troubleshooting#Green_LED_blinks_in_a_specific_pattern

I think it's still valid to mention it / put as link in our docs.

This is now mentioned in our FAQ troubleshooting section: https://github.com/resin-io/docs/pull/231/

authors: emirotin filippoferraris shaunmulligan

repo: resin-io/docs


text:
doc: recommend make electron-develop to clean dependency tree

Because of NPM shrinkwrap, we recommend having a clean dependency tree
in CONTRIBUTING.md before upgrading a dependency. We currently
recommend maually wiping out node_modules, but since the
electron-develop make target already does that, is more user friendly
to recommend that instead.
Signed-off-by: Juan Cruz Viotti jviotti@openmailbox.org

Hmm, is this really the best advice?? electron-develop does a lot more than just delete node_modules (it's always quite a slow process for me).
Maybe it'd be better to recommend make distclean ( #971 ) instead?

@lurch The documentation was currently inaccurate (I just detected that), since you actually need to re-install the dependencies before moving to the next step (which make electron-develop) does.

Aha, cool :)

authors: jviotti lurch

repo: resin-io/etcher


text:
dnsmasq nslookup via 127.0.0.2 is slow

nslookup vpn.resin.io tries to query through dnsmasq on 127.0.0.2.
Running nslookup vpn.resin.io is considerably slower than nslookup vpn.resin.io 8.8.8.8
 Front conversations

Next is to find out why the five seconds gap occurs when there is no hosts entry. I will post more information here once I start looking into it.

This looks related to reverse DNS lookup only. When doing a ping resolving is fast. I get fast results when using the trust-dns library as well.

This may or may not be related to occasional getaddrinfo EAI_AGAIN api.resin.io:443 errors we see - those indicate a DNS timeout.

authors: ZubairLK majorz

repo: resin-os/meta-resin


text:
linux-raspberrypi-4.1: Add optional workaround patch for egl apps in containers

This patch is nit applied by default. If needed, activate it by setting:
RPI_FIX_VCHIQ = "1" in your local.conf.
@petrosagg @floion @telphan

This change is

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

SGTM

authors: agherzan petrosagg resin-jenkins

repo: resin-os/resin-raspberrypi


text:
Add missing icon to Weather_List tile

Can the "mdi:weather-snowy-rainy" icon be added to the standard set of icons in the weather_list tile?

Weather tiles don't use mdi icons but this set https://github.com/manifestinteractive/weather-underground-icons
It doesn't have that kind of icon exactly.

repo: resoai/TileBoard


text:
URL encode in get/delete request

so We can use + in request url

In rest-client, it's the caller's responsibility to encode characters that are invalid within a URI using e.g. URI.escape. Doing this automatically turns out to be a source of lots of hard to find bugs.

repo: rest-client/rest-client


text:
[0.9.0] Fatal: --quiet and --verbose cannot be specified at the same time

Output of restic version
restic 0.9.0 compiled with go1.10.2 on linux/amd64
How did you run restic exactly?
            command:
            - "/usr/local/bin/restic"
            args:
            - "backup"
            - "--quiet"
            - "--verbose"
            - "--verbose"
            - "--hostname=foo"
            - "--exclude-caches"
            - "--exclude-if-present=auto.cnf"
            - "--tag=job"
            - "/vol/foo/"

What backend/server/service did you use to store the repository?
B2
Expected behavior
This is a batch run, and so the pre-scan and progress display is a waste of time. However, I want a detailed record of the actions the backup tool in the log. Hence --quiet --verbose --verbose.

I expected --quiet to disable the pre-scan
I expected --verbose --verbose to enable logging files or file-chucks included in the backup

Actual behavior
I got errors: "Fatal: --quiet and --verbose cannot be specified at the same time"
Steps to reproduce the behavior
See 'How did you run restic exactly?' above.
Do you have any idea what may have caused this?
It doesn't seem like the functionality overloaded onto these settings overlaps. A verbose log of actions during the backup doesn't need the pre-scan does it?
Do you have an idea how to solve the issue?

Remove the prohibition over using --quiet and --verbose together. Although it is weird in English to use them at the same time, the functionality gated by them makes sense to use at the same time.

Alternatively, don't overload settings, make --no-prescan or --no-progress its own option, and make --quiet and --verbose a convenient bundle of more fine-grained settings.

Did restic help you or made you happy in any way?
Looking forward to giving 0.9.0 a good test!

Hey, thanks for the report. I think you've read about --quiet in the changelog, that was a bit unfortunate... It was a workaround for the old version of the archiver code, which did not start reading files until the scan was done. So we decided to just skip the scan if --quiet is passed.
With the new archiver code, scanning and the backup process is run in parallel, so restic won't wait until the scanner is done, but directly start reading and saving files.
So, the changelog entry is unfortunate, but in general I don't think this is a bug.
What are your thoughts on it?

I'm confused. This is the change log for 0.9.0, this behavior it is listed as an enhancement specifically for 0.9.0, but you say it doesn't apply to 0.9.0? If the change is no longer in the code or redundant, shouldn't it be removed from the change log? This functionality is not a change from 0.8.3 -> 0.9.0 since it apparently isn't in either version?

Enhancement #1676: Improve backup speed: Skip initial scan phase in quiet mode
We've improved the backup speed when the quiet flag (-q or --quiet) is set by skipping the initial scan which gathers information for displaying the progress bar and the ETA estimation.
#1160 #1676

This is still a bug, as I think I still can't enable the output options you need for batch tasks? I don't want the interactive, multi-line status display and --quiet is apparently the only way to disable that? But I do want the log entries for the files processed, which apparently is only enabled by --verbose or --verbose --verbose? But I can't use both at once, which (in my head) doesn't make much sense 😄
https://github.com/restic/restic/releases/tag/v0.9.0

While we were at it, the status display and notification system was completely rewritten. By default, restic now shows which files are currently read (unless --quiet is specified) in a multi-line status display.
The backup command also gained a new option: --verbose. It can be specified once (which prints a bit more detail what restic is doing) or twice (which prints a line for each file/directory restic encountered, together with some statistics).

The current --quiet option, when used on its own, disables all output unless there is an error - is that right? That is an ideal option for cron jobs where any stderr/stdout output is considered something that needs to be emailed/notified. Good option for crontab 👍
However other batch systems (e.g. Kubernetes Jobs/CronJobs, Octopus Deploy) consider the exit value or the (lack of) stderr output as the indication of success/failure. Output from stdout is considered log content and stored for later review.
How can users disable the interactive multi-line status display, but still enable the logging?

If the change is no longer in the code or redundant, shouldn't it be removed from the change log?

Indeed, I'll remove it. It was present in an intermediate version that did not get released at all because #1494 was merged and replaced the code.
Usually, we're trying to document the user-facing changes in the code directly in the PRs, so they don't get lost (and I don't get to spend time writing a changelog when I'm releasing a new version). We ran into a special case here :)

This is still a bug, as I think I still can't enable the output options you need for batch tasks? I don't want the interactive, multi-line status display and --quiet is apparently the only way to disable that? But I do want the log entries for the files processed, which apparently is only enabled by --verbose or --verbose --verbose? But I can't use both at once, which (in my head) doesn't make much sense ￼

It must be quite confusing for you as a user, I'm sorry about that. The options --quiet and --verbose control how much output is printed in the "log" part of restic's output. The status lines are not controlled with either option, when a terminal is available (only when restic is run interactively), the status lines are shown. In all other cases, the status lines are not shown, so you don't get a huge email when running restic via cron.
Currently, there's no way to explicitly enable/disable the status lines, it feels to me the automatic detection (is a terminal there or not?) works really well. What are your thoughts on this?
Maybe we should document this in the manual somewhere...

The current --quiet option, when used on its own, disables all output unless there is an error - is that right?

Correct.

How can users disable the interactive multi-line status display, but still enable the logging?

Easy: Pass --verbose to restic (or -v -v), the rest is automatic. If you run it interactively, the status lines will be shown, otherwise not.
If you'd like to hide the status lines and still run interactively, you can force stdout to not be a terminal by piping it to cat, e.g. restic -v -v backup [...] | cat.

Thanks @fd0, getting clearer!
Automatic suppression base on lack of terminal is great default behavior. Thanks for letting me know, and yes please add to the manual.
You could still consider a --no-progress or --noninteractive or similar option to force the no-terminal-present behavior. This is a pretty common option on tools that get used in both modes (e.g. apt, composer). And more elegant that piping through another process to fake the non-terminal situation. If people use that option when the automatic detection would have handled it, no harm done I think? Not essential/required of course.
Ok, once more I change the options on these restic jobs! My git log is full of 'add option x', 'remove option x, add y', 'add option x back' 😄

So, I'd like to reopen this issue to track adding some documentation to the manual. I'll think about ading the CLI option.

Looking forward for a --noninteractive option! I'm making backups for several Windows servers. Restic is executed through a centralized task management platform called Rundeck (https://www.rundeck.com/open-source) using the WinRM plugin. It seems that Restic's automatic suppression based on lack of terminal is not working when using Rundeck and therefore we get a huge report file after every execution.

Ok, thanks for the report.

authors: cgonzalez fd0 whereisaaron

repo: restic/restic


text:
Switch to azblob sdk

This is the start to fix #3698 since that requires to take a cred
struct into many of the client New methods

What does this PR change? What problem does it solve?

Was the change previously discussed in an issue or on the forum?

Checklist

[x] I have read the contribution guidelines.
[x] I have enabled maintainer edits.
[ ] I have added tests for all code changes.
[ ] I have added documentation for relevant changes (in the manual).
[ ] There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
[x] I have run gofmt on the code in all commits.
[ ] All commit messages are formatted in the same style as the other commits in the repo.
[ ] I'm done! This pull request is ready for review.

I've fixed the remaining review comments. Apparently the azure SDK requires golang 1.18, which would be major bump in the required golang version...

@MichaelEischer idk what's up here but I get
debug log file test.log
debug enabled
Fatal: create key in repository at azure:test:/ failed: StageBlock: PUT https://xxxblob.core.windows.net/test/keys/5a09ec71a89cf36911982a9de23ce53639436830a4114662fe2c457937917c9c
--------------------------------------------------------------------------------
RESPONSE 400: 400 The MD5 value specified in the request did not match with the MD5 value calculated by the server.
ERROR CODE: Md5Mismatch
--------------------------------------------------------------------------------
<?xml version="1.0" encoding="utf-8"?><Error>Md5Mismatch<Message>The MD5 value specified in the request did not match with the MD5 value calculated by the server.
RequestId:afd69da6-501e-0038-77cf-01c51e000000
Time:2022-11-26T19:43:01.9531956Z</Message><UserSpecifiedMd5>MBrCsbYtOgytzT9iexEK4w==</UserSpecifiedMd5><ServerCalculatedMd5>H1A55QvWaykMVmhNhVDGwg==</ServerCalculatedMd5></Error>

Seems we're calculating or giving a mismach of the MD5?

So now it's working that far but now it hangs on:
snapshot 709fadfc saved

I guess it's due to one of the locks not releasing?

So now it's working that far but now it hangs on:
snapshot 709fadfc saved

I guess it's due to one of the locks not releasing?

Without more context that's usually pretty hard to tell. In case of a hanging golang program it's often helpful to send a SIGQUIT to the program (ctrl+). Then the runtime prints a stacktrace of all goroutines and exits. Here it was probably caused by a leaked token in the Save method.

No but I well def use it before pushing more code! Thanks for the tip

goroutine 43 [chan send]:
github.com/restic/restic/internal/backend/sema.Semaphore.GetToken(...)
/home/ekarlso/projects/evry/dds/infrastructure/docker-images/restic/internal/backend/sema/semaphore.go:27
github.com/restic/restic/internal/backend/azure.(*Backend).List(0xc00011d290, {0xc39138, 0xc00019e140}, 0x1, 0xc0004f4080)
/home/ekarlso/projects/evry/dds/infrastructure/docker-images/restic/internal/backend/azure/azure.go:426 +0x35e

I have no idea which version of the code that is. But it looks like it does not include the last three bugfix commits which I've added to this PR (otherwise the line number doesn't make sense).

@MichaelEischer all tests are green and the branch has been updated. Thanks for your help!

authors: MichaelEischer ekarlso


text:
Empty entries in the collection context menu after installing BBT

First, thanks for this excellent add-on, which makes Bibtex import so much better.
I noticed one issue after installing BBT. Right-clicking on collections or sub-collections in the leftmost pane brings up a context menu. BBT apparently adds some new entries to this menu, but some of the menu titles go missing in action (please see attached images). My BBT version is 1.6.78 (current as of today).
Thanks, Michael
Screenshot without BBT installed

Screenshot with BBT installed

I think you're bitten by #584; I'm readying a release that will address this (a.o.)

Confirming the bug. Zotero Standalone on Windows.

https://github.com/retorquere/zotero-better-bibtex/releases/download/builds/zotero-better-bibtex-1.6.78-circle-3168.xpi ought to fix the issue (this is what is slated for release). Wouldn't mind knowing if it does address the issue for you both.

Yes, with this version the issue is fixed. Thanks!

A release is going out within a few hours, preferably with #590 but it's not a blocker. You'll be upgraded automatically.

great, thank you.
On 25/10/16 09:57 AM, retorquere wrote:

I think you're bitten by #584; I'm readying a release that will address this (a.o.)

--
Michael Palmer
364 Anatolin Place
Waterloo, ON N2L5G8

.79 is out

yes, it does - thanks! M.
On 25/10/16 10:42 AM, retorquere wrote:

https://github.com/retorquere/zotero-better-bibtex/releases/download/builds/zotero-better-bibtex-1.6.78-circle-3168.xpi ought to fix the issue (this is what is slated for release). Wouldn't mind knowing if it does address the issue for you both.

--
Michael Palmer
364 Anatolin Place
Waterloo, ON N2L5G8

authors: dbobak michaelpalmeruw retorquere

repo: retorquere/zotero-better-bibtex


text:
add basic support for pulling metrics from a dropwizard application

Can you please have a quick review before i submit the real PR to the upstream repo?

thanks @rhysbryant, i have made the suggested change. any other suggestions?

just merging into clean branch and squashing commits

repo: retrievercommunications/telegraf