text:
[Device Support Request] Tuya/Aviatto TS0601  _TZE200_rtrmfadk

Problem description
https://de.aliexpress.com/item/1005005883444420.html
https://web.archive.org/web/20231020151002/https://www.aliexpress.us/item/3256805697129668.html
No entities shown in HA
Solution description
have MVP Entities
Get room temperature
Get/Set setpoint temperature
Get/Set global on/off status
Get heating status
Get/Set mode (manual/schedule)

Screenshots/Video
Screenshots/Video

Device signature
Device signature
[Paste the device signature here]

Diagnostic information
Diagnostic information
{
  "home_assistant": {
    "installation_type": "Home Assistant Container",
    "version": "2023.10.1",
    "dev": false,
    "hassio": false,
    "virtualenv": false,
    "python_version": "3.11.5",
    "docker": true,
    "arch": "aarch64",
    "timezone": "Europe/Berlin",
    "os_name": "Linux",
    "os_version": "6.1.21-v8+",
    "run_as_root": true
  },
  "custom_components": {
    "bosch_shc": {
      "version": "0.4.63",
      "requirements": [
        "boschshcpy==0.2.72"
      ]
    },
    "dwains_dashboard": {
      "version": "3.4.3",
      "requirements": []
    },
    "hacs": {
      "version": "1.33.0",
      "requirements": [
        "aiogithubapi>=22.10.1"
      ]
    },
    "bosch": {
      "version": "0.23.4",
      "requirements": [
        "bosch-thermostat-client==0.23.2"
      ]
    },
    "sonoff": {
      "version": "3.5.2",
      "requirements": [
        "pycryptodome>=3.6.6"
      ]
    }
  },
  "integration_manifest": {
    "domain": "zha",
    "name": "Zigbee Home Automation",
    "after_dependencies": [
      "onboarding",
      "usb"
    ],
    "codeowners": [
      "@dmulcahey",
      "@adminiuga",
      "@puddly"
    ],
    "config_flow": true,
    "dependencies": [
      "file_upload"
    ],
    "documentation": "https://www.home-assistant.io/integrations/zha",
    "iot_class": "local_polling",
    "loggers": [
      "aiosqlite",
      "bellows",
      "crccheck",
      "pure_pcapy3",
      "zhaquirks",
      "zigpy",
      "zigpy_deconz",
      "zigpy_xbee",
      "zigpy_zigate",
      "zigpy_znp",
      "universal_silabs_flasher"
    ],
    "requirements": [
      "bellows==0.36.5",
      "pyserial==3.5",
      "pyserial-asyncio==0.6",
      "zha-quirks==0.0.104",
      "zigpy-deconz==0.21.1",
      "zigpy==0.57.2",
      "zigpy-xbee==0.18.3",
      "zigpy-zigate==0.11.0",
      "zigpy-znp==0.11.5",
      "universal-silabs-flasher==0.0.14",
      "pyserial-asyncio-fast==0.11"
    ],
    "usb": [
      {
        "vid": "10C4",
        "pid": "EA60",
        "description": "*2652*",
        "known_devices": [
          "slae.sh cc2652rb stick"
        ]
      },
      {
        "vid": "1A86",
        "pid": "55D4",
        "description": "*sonoff*plus*",
        "known_devices": [
          "sonoff zigbee dongle plus v2"
        ]
      },
      {
        "vid": "10C4",
        "pid": "EA60",
        "description": "*sonoff*plus*",
        "known_devices": [
          "sonoff zigbee dongle plus"
        ]
      },
      {
        "vid": "10C4",
        "pid": "EA60",
        "description": "*tubeszb*",
        "known_devices": [
          "TubesZB Coordinator"
        ]
      },
      {
        "vid": "1A86",
        "pid": "7523",
        "description": "*tubeszb*",
        "known_devices": [
          "TubesZB Coordinator"
        ]
      },
      {
        "vid": "1A86",
        "pid": "7523",
        "description": "*zigstar*",
        "known_devices": [
          "ZigStar Coordinators"
        ]
      },
      {
        "vid": "1CF1",
        "pid": "0030",
        "description": "*conbee*",
        "known_devices": [
          "Conbee II"
        ]
      },
      {
        "vid": "10C4",
        "pid": "8A2A",
        "description": "*zigbee*",
        "known_devices": [
          "Nortek HUSBZB-1"
        ]
      },
      {
        "vid": "0403",
        "pid": "6015",
        "description": "*zigate*",
        "known_devices": [
          "ZiGate+"
        ]
      },
      {
        "vid": "10C4",
        "pid": "EA60",
        "description": "*zigate*",
        "known_devices": [
          "ZiGate"
        ]
      },
      {
        "vid": "10C4",
        "pid": "8B34",
        "description": "*bv 2010/10*",
        "known_devices": [
          "Bitron Video AV2010/10"
        ]
      }
    ],
    "zeroconf": [
      {
        "type": "_esphomelib._tcp.local.",
        "name": "tube*"
      },
      {
        "type": "_zigate-zigbee-gateway._tcp.local.",
        "name": "*zigate*"
      },
      {
        "type": "_zigstar_gw._tcp.local.",
        "name": "*zigstar*"
      },
      {
        "type": "_uzg-01._tcp.local.",
        "name": "uzg-01*"
      },
      {
        "type": "_slzb-06._tcp.local.",
        "name": "slzb-06*"
      }
    ],
    "is_built_in": true
  },
  "data": {
    "ieee": "**REDACTED**",
    "nwk": 60159,
    "manufacturer": "_TZE200_rtrmfadk",
    "model": "TS0601",
    "name": "_TZE200_rtrmfadk TS0601",
    "quirk_applied": false,
    "quirk_class": "zigpy.device.Device",
    "manufacturer_code": 4417,
    "power_source": "Battery or Unknown",
    "lqi": 255,
    "rssi": -29,
    "last_seen": "2023-10-20T16:02:44",
    "available": true,
    "device_type": "EndDevice",
    "signature": {
      "node_descriptor": "NodeDescriptor(logical_type=<LogicalType.EndDevice: 2>, complex_descriptor_available=0, user_descriptor_available=0, reserved=0, aps_flags=0, frequency_band=<FrequencyBand.Freq2400MHz: 8>, mac_capability_flags=<MACCapabilityFlags.AllocateAddress: 128>, manufacturer_code=4417, maximum_buffer_size=66, maximum_incoming_transfer_size=66, server_mask=10752, maximum_outgoing_transfer_size=66, descriptor_capability_field=<DescriptorCapability.NONE: 0>, *allocate_address=True, *is_alternate_pan_coordinator=False, *is_coordinator=False, *is_end_device=True, *is_full_function_device=False, *is_mains_powered=False, *is_receiver_on_when_idle=False, *is_router=False, *is_security_capable=False)",
      "endpoints": {
        "1": {
          "profile_id": "0x0104",
          "device_type": "0x0051",
          "input_clusters": [
            "0x0000",
            "0x0004",
            "0x0005",
            "0xef00"
          ],
          "output_clusters": [
            "0x000a",
            "0x0019"
          ]
        }
      },
      "manufacturer": "_TZE200_rtrmfadk",
      "model": "TS0601"
    },
    "active_coordinator": false,
    "entities": [],
    "neighbors": [],
    "routes": [],
    "endpoint_names": [
      {
        "name": "SMART_PLUG"
      }
    ],
    "user_given_name": "Heating Office",
    "device_reg_id": "ae113f29e712d4a2299ec06f781b38c2",
    "area_id": "office",
    "cluster_details": {
      "1": {
        "device_type": {
          "name": "SMART_PLUG",
          "id": 81
        },
        "profile_id": 260,
        "in_clusters": {
          "0x0004": {
            "endpoint_attribute": "groups",
            "attributes": {},
            "unsupported_attributes": {}
          },
          "0x0005": {
            "endpoint_attribute": "scenes",
            "attributes": {},
            "unsupported_attributes": {}
          },
          "0xef00": {
            "endpoint_attribute": null,
            "attributes": {},
            "unsupported_attributes": {}
          },
          "0x0000": {
            "endpoint_attribute": "basic",
            "attributes": {
              "0x0001": {
                "attribute_name": "app_version",
                "value": 72
              },
              "0x0004": {
                "attribute_name": "manufacturer",
                "value": "_TZE200_rtrmfadk"
              },
              "0x0005": {
                "attribute_name": "model",
                "value": "TS0601"
              }
            },
            "unsupported_attributes": {}
          }
        },
        "out_clusters": {
          "0x0019": {
            "endpoint_attribute": "ota",
            "attributes": {},
            "unsupported_attributes": {}
          },
          "0x000a": {
            "endpoint_attribute": "time",
            "attributes": {},
            "unsupported_attributes": {}
          }
        }
      }
    }
  }
}

Logs
Logs
[Paste the logs here]

Custom quirk
Custom quirk
[Paste your custom quirk here]

Additional information
a previous version seems to have been added to zigbee2mqtt https://github.com/Koenkk/zigbee2mqtt/issues/18892
Which got its infos from this issue https://github.com/Koenkk/zigbee2mqtt/issues/9265
if you need more info or help developing/testing please reach out anytime
thanks for your awesome work

in my case this worked: https://github.com/jacekk015/zha_quirks/blob/main/ts0601_trv_rtitek.py

wow thanks for your fast awnser I'll check it out and report back.

only found this quirk and got over ur request. I have ordered the same valve so we are in the same boat. Could load the quirk and got some infos from the valve. Dont really know if this perfect works but is from now the best result i got!

that totally worked thanks so much for providing me with that link. I spent hours googling and found nothing.

glad it worked. ur welcome. Spent already hours. Have a nice evening.

Thanks a lot.
I was searching days for a solution an now found this and it's just working and so easy.

I have the same _TZE200_rtrmfadk and am using the same "https://github.com/jacekk015/zha_quirks/blob/main/ts0601_trv_rtitek.py".
I see all the attributes and values, but am running into other issues. I was wondering if you ran into the same issues.
If I change the temperature on the device, I see the temp changing in HA, but when I want to change it in HA, nothing happens.
The thermostat is not locked or anything. I have 3 of these thermostats, but none of them work as they should.
I tried if for over 11 days now and only got it to change the temperature twice... I don't know what I am doing wrong...

home-assistant_zha_2024-01-15T17-05-11.626Z.log
I have turned on debugging, restarted HA and I could control the thermostat a few times, but then it stopped working.
I have included the logging file... I really hope someone can help me.

I have applied this quirk to the device TS0601_TZE204_rtrmfadk, just adding a new signature to the code. Everything works OK. Thanks HA team :-)

@lpzubero I got it working with your approach, but it seems that turning the thermostat off does not work correctly. It stop the heating, but the state is then stuck in "Idle". Do you experience the same?

The main problem I have found with this quirk is that in some cases the quirk puts the thermostat in the "schedule" mode (for example, after changing the programed temperature in HA). I think working mode "schedule" is not interesting when the thermostat is conected to HA, because it is supposed that "schedule" is configured in HA and not in the thermostat memory. In this case, the right mode should be is mode "manual".
I am not a good programmer, so what I have done in my HA is to change following lines:
    if attribute == "system_mode":
        if value == self.SystemMode.Off:
            return {RTI_MODE_ATTR: 2}
        else:
            # LPZ 4-12-2024
            #return {RTI_MODE_ATTR: 0}
            return {RTI_MODE_ATTR: 1}

............
    else:
        operation_preset = self.Preset.Manual
        prog_mode = self.ProgrammingOperationMode.Simple
        occupancy = self.Occupancy.Occupied

LPZ 4-12-2024
operation_preset = self.Preset.Schedule
prog_mode = self.ProgrammingOperationMode.Schedule_programming_mode
occupancy = self.Occupancy.Occupied
May be there are better solutions, I would apreciate if someone with a better programing knowledge improve this code

authors: AngeloDellaMorte Tiggx dassiegfried lpzubero phulstaert pr8x

repo: zigpy/zha-device-handlers


text:
Refactor IKEA five button remote quirks

This combines the quirks from fivebtnremotezha.py and fivebtnremote.py, as they are one device with different firmware versions and the device automation triggers all seem to be the same (they were somewhat duplicated previously).
One parameter was changed to 537 in https://github.com/zigpy/zha-device-handlers/pull/1511, but after some discussion, this seems to invalid and we can likely just replace it with the same device automation triggers for the other automations (which is done in this PR).

Note: The automation triggers are all the same now (and not missing): all quirks inherit from IkeaTradfriRemote1.
@MattWestb @stickpin for review
This takes out the refactoring part from:

https://github.com/zigpy/zha-device-handlers/pull/2123
https://github.com/zigpy/zha-device-handlers/pull/2152

When merged, I'll rebase the following PRs:

https://github.com/zigpy/zha-device-handlers/pull/2123 (to only add the two new triggers)
https://github.com/zigpy/zha-device-handlers/pull/2140 (to add the new signature with existing triggers)

(Having separate PRs for the (1) refactoring, (2) added triggers and (3) for the new signature makes it so we don't have one huge commit on the repo that changes a bunch of things)
(I've also done the refactoring here in multiple commits (will be squashed when merging), so it's easier to see the exact steps/changes here).

Pull Request Test Coverage Report for Build 4055069882

12 of 12 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 83.682%

Totals

Change from base Build 4033245481:
-0.02%

Covered Lines:
6877

Relevant Lines:
8218

💛  - Coveralls

source: gharchive/pull-request

authors: TheJulianJES coveralls

license_type: permissive

license_source: github-api


text:
Importing dynamic fields is not supported

Describe the bug:

Steps to reproduce:
1.Exporting data from attu
2.Select Import data from file
3.Prompt column number mismatch
4.If you delete the $mate column, it will work fine.
**Attu version:2.4.0

You don't have to use $meta.  please check here to see the example data format.

You don't have to use $meta. please check here to see the example data format.

After downloading the sample data file, it still cannot be imported。

yeah, looks like csv import is broken. please use json import now, I will fix it soon.  thanks.

source: gharchive/issue

authors: fufenghua shanghaikid

repo: zilliztech/attu


text:
Duplicate lines in init.zsh

Prerequisites

[X] I've checked the existing issues and I'm not duplicating a report.
[X] I've checked the zimfw Changelog and I'm not being affected by documented changes.
[X] I've checked the zimfw 📢 Announcements and I'm not being affected by announced changes.

Bug description
Duplicate autoload, fpath, and source entries in .zim/init.zsh
Steps to reproduce
   zimfw install # or any zimfw action sufficient to update the init.zsh file

Add more steps here ...

Current behavior
Every time zimfw updates init.zsh it seems to duplicate modules, autoload and source lines that already exist:
fpath=(/home/mfaine/.zim/modules/git/functions /home/mfaine/.zim/modules/utility/functions /home/mfaine/.zim/modules/duration-info/functions /home/mfaine/.zim/modules/git-info/functions /home/mfaine/.zim/modules/zsh-completions/src /home/mfaine/.zim/modules/pvenv/functions /home/mfaine/.zim/modules/utility/functions /home/mfaine/.zim/modules/duration-info/functions /home/mfaine/.zim/modules/git-info/functions /home/mfaine/.zim/modules/zsh-completions/src /home/mfaine/.zim/modules/utility/functions /home/mfaine/.zim/modules/duration-info/functions /home/mfaine/.zim/modules/git-info/functions /home/mfaine/.zim/modules/zsh-completions/src /home/mfaine/.zim/modules/prompt-pwd/functions /home/mfaine/.zim/modules/archive/functions /home/mfaine/.zim/modules/asdf/functions /home/mfaine/.zim/modules/k/functions /home/mfaine/.zim/modules/zim-yq/functions /home/mfaine/.zim/modules/zim-gopass/functions ${fpath})

autoload -Uz -- git-alias-lookup git-branch-current git-branch-delete-interactive git-branch-remote-tracking git-dir git-ignore-add git-root git-stash-clear-interactive git-stash-recover git-submodule-move git-submodule-remove mkcd mkpw duration-info-precmd duration-info-preexec coalesce git-action git-info pvenv mkcd mkpw duration-info-precmd duration-info-preexec coalesce git-action git-info mkcd mkpw duration-info-precmd duration-info-preexec coalesce git-action git-info prompt-pwd archive lsarchive unarchive asdf k

source /home/mfaine/.zim/modules/environment/init.zsh
source /home/mfaine/.zim/modules/environment/init.zsh
source /home/mfaine/.zim/modules/environment/init.zsh

I'm not sure what's going on but it doesn't seem to be duplicating everything every time and there doesn't ever seem to be more than three instances of any one item.
Expected behavior
No duplication in init.zsh
zimfw info
zimfw version:        1.13.1 (built at 2024-04-28 19:07:19 UTC, previous commit is c86223f)
LANG:                 C.UTF-8
OSTYPE:               linux-gnu
TERM:                 xterm-256color
TERM_PROGRAM:
TERM_PROGRAM_VERSION:
ZIM_HOME:             /home/mfaine/.zim
ZSH_VERSION:          5.9

Additional context
WSL2 (Ubuntu 24.04) Windows 11 22H2

I don't think zimfw should be too smart here. If users declare something twice in .zimrc, we'll assume they know what they are doing.

authors: ericbn markfaine

repo: zimfw/zimfw

license: MIT


text:
Recipient-region vocabulary changed 99->1 at transaction level

Describe the bug
The recipient-region/@vocabulary code is output as 1 rather than 99 when repeated at the transaction level.
To Reproduce

Open the UNCHR regional file: http://reporting.unhcr.org/sites/default/files/IATI/UNHCR-Activities-2018.xml
Search for recipient-region. Note that only 99 vocabularies are published (with codes like AME, AFR, etc.)<recipient-region code="AFR" vocabulary="99" vocabulary-uri="http://www.unhcr.org/where-we-work.html">
  <narrative>Africa</narrative>
</recipient-region>

There are no recipient-region published at the transaction level.
Open one activity in the datastore, e.g. https://test-datastore.iatistandard.org/api/activities/?iati_identifier=XM-DAC-41121-2018-AFR&fields=all
Note that at the activity level, the vocabulary is correct (though the code is in lowercase, and the narrative has been removed, which is possibly quite important for 99 vocabs?):<recipient-region code="afr" vocabulary="99" vocabulary-uri="http://www.unhcr.org/where-we-work.html"/>

However, at the transaction level, the vocabulary is incorrect:<recipient-region code="afr" vocabulary="1"/>

Expected behavior
Show the correct recipient-region vocabulary (and preferably the code in the correct case plus the narrative).
Relates to #1873

I have looked into this issue and created a different ticket as it is a quite big job.  see #1910

please check: https://iati.cloud/api/activities/?iati_identifier=XM-DAC-41121-2018-AFR&fields=all

authors: luminhan markbrough


text:
How can I handle the connection errors ?

Describe the bug
I'm not sure if this bug or not.
I want to handle the exception when the server is down.
But, I can't catch the connection error.
How can I handle this ?
To Reproduce

Wrap Mutation with try-catch block.
Turn off the server.
Request to the server with Mutation.

try {
  mutation({
    'accessToken': 'my_tokens',
  });
} catch (error) {
  print("Error: Error occurred!!");
}

OR
Mutation(
    options: MutationOptions(
      document: qSocialLogin,
    ),
    builder: (
      RunMutation mutation,
      QueryResult result,
    ) {
      if (!result.loading && result.hasErrors) {
        print("Error: Error occurred!!");
      }
  }
)

Expected behavior
Print "Error: Error occurred!!" in the console.
Screenshots

Desktop (please complete the following information):

OS: macOS
Version 10.14.6

Smartphone (please complete the following information):

Device: iPhone8 Plus(Simulator)
OS: iOS 12.1

Can you try the beta version of the package, I think this may have been resolved a while back

@mainawycliffe Thanks~ 👍
I found the update for exception handling in v2.1.1-beta.3@beta after saw your word.
When is this feature release in a stable version ?

I am not sure, been caught up lately, but I will find some time and update the changelog and see if we can push the next version to stable over the week.

authors: chicrock mainawycliffe

repo: zino-app/graphql-flutter


text:
Double call to server on app reload

I have implemented everything as described here: https://github.com/zino-app/graphql-flutter/blob/master/examples/starwars/lib/episode/hero_query.dart
and added simple console.log('CCC') on my server GraphQL endpoint. After changing query variable value (hardcoded value for testing purposes) i see endpoint is hited 2 times. On refetch all works as expected.

WOOOW - maybe I am doing something wrong but backend is called on every UI repaint!!! I am dragging slider and see backend service is called.
Yes i do have cache enabled - i have tried with optimmistic cache and InMemory cache - same results

This is probably a configuration error. Few things –

Why are there 3 ports listed
Can you provide your client connection code in a gist or something
Your client is maybe being instantiated inside of a re-rendering context
This would probably be easier to troubleshoot in the support channel in discord

3 ports is because of local dev, emulator https dev and mobile https dev  - but i am using only emulators in this example
I am taking everything litterally from link above

when i am calling client directly everything works as expected
var client = GraphQLProvider.of(context).value;
              var data = await client.query....

my code is:
main.dart
String get graphQLEndpoint {
  if (Platform.isAndroid) {
    return 'https://10.0.2.2:3000/graphql';
  } else {
    return 'https://localhost:3000/graphql';
  }
}

class DemoApp extends StatelessWidget {
    return ClientProvider(
        uri: graphQLEndpoint,
        child: MaterialApp(
          title: 'Flutter Demo',
          onGenerateRoute: RouteGenerator.generateRoute,
        ));
  }
}

client_provider.dart
import 'dart:io';
import 'package:http/io_client.dart';
import 'package:flutter/foundation.dart';

import 'package:graphql_flutter/graphql_flutter.dart';
import 'package:flutter/material.dart';

String uuidFromObject(Object object) {
  if (object is Map<String, Object>) {
    final String id = object['_id'].toString();
    if (id != "null" && id != null) {
      return id;
    }
  }
  return null;
}

final OptimisticCache cache = OptimisticCache(
  dataIdFromObject: uuidFromObject,
);

ValueNotifier<GraphQLClient> clientFor({
  @required String uri,
  String subscriptionUri,
}) {
  Link link;

  if (kReleaseMode) {
    link = HttpLink(uri: uri);
  } else {
    HttpClient httpClient = new HttpClient();
    httpClient.badCertificateCallback =
        (X509Certificate cert, String host, int port) => true;
    IOClient ioClient = new IOClient(httpClient);

    link = HttpLink(uri: uri, httpClient: ioClient);
  }

  if (subscriptionUri != null) {
    final WebSocketLink websocketLink = WebSocketLink(
      url: subscriptionUri,
      config: SocketClientConfig(
        autoReconnect: true,
        inactivityTimeout: Duration(seconds: 30),
      ),
    );

    /* final AuthLink authLink = AuthLink(
    getToken: () async => 'Bearer <YOUR_PERSONAL_ACCESS_TOKEN>',
    // OR
    // getToken: () => 'Bearer <YOUR_PERSONAL_ACCESS_TOKEN>',
  ); */

    link = link.concat(websocketLink);
  }

  return ValueNotifier<GraphQLClient>(
    GraphQLClient(
      cache: InMemoryCache(),
      link: link,
    ),
  );
}

/// Wraps the root application with the `graphql_flutter` client.
/// We use the cache for all state management.
class ClientProvider extends StatelessWidget {
  ClientProvider({
    @required this.child,
    @required String uri,
    String subscriptionUri,
  }) : client = clientFor(
          uri: uri,
          subscriptionUri: subscriptionUri,
        );

  final Widget child;
  final ValueNotifier<GraphQLClient> client;

  @override
  Widget build(BuildContext context) {
    return GraphQLProvider(
      client: client,
      child: child,
    );
  }
}

and my widget

class Test extends StatelessWidget {
final testRequestParams request;
const Test (this.request);
@override
Widget build(BuildContext context) {
return Query(
options: QueryOptions(
documentNode: testQuery,
variables: <String, dynamic>{
'var2': this.request.var2,
'var3': this.request.var3,
}),
builder: (
QueryResult result, {
Future Function() refetch,
FetchMore fetchMore,
}) {
print(result.data);
if (result.hasException) {
return Text(result.exception.toString());
}
    if (result.loading) {
      return const Center(
        child: CircularProgressIndicator(),
      );
    }

    return Column(
      children: <Widget>[
        // Text(JsonEncoder.withIndent('  ').convert(result.data)),
        RaisedButton(
          onPressed: refetch,
          child: const Text('REFETCH'),
        ),
      ],
    );
  },
);

}
}

@micimize I could confirm this issue has been fixed, when will it live in stable release?

@nampdn in the next one – I'm a bit swamped with other stuff but beta is stable enough to be merged/released right now

should be fixed in v3.1.0 according to the above

authors: micimize nampdn vytautas-pranskunas-


text:
Update sbt-mdoc to 2.3.1

Updates org.scalameta:sbt-mdoc from 2.2.24 to 2.3.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "sbt-mdoc" } ]

labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #437.

repo: zio/zio-actors


text:
Update scalafmt-core to 3.7.16

About this PR
📦 Updates org.scalameta:scalafmt-core from 2.7.5 to 3.7.16 ⚠
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]

labels: library-update, early-semver-major, semver-spec-major, commit-count:1

Superseded by #269.

repo: zio/zio-crypto


text:
Support for DDB Batch Transactions API

DDB also provides a batch based transactional API [see here] . Amongst many other things it allows you to batch UpdateItem queries which can't be done using the normal BatchWriteItem API. (https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/transaction-apis.html#transaction-apis-txwriteitems).
It would be good to provide support for this through a dedicated DynamoDBQuery type.

closed by https://github.com/zio/zio-dynamodb/commit/a094262a367fb060da9ab9c1bea4ba6eb31f2c4b

repo: zio/zio-dynamodb


text:
Support for InfluxDB/DataDog

It would be great to have integration with the TICK stack (and compatible services such as DataDog).
https://github.com/gphat/censorinus could be used for this

It seems Telegraf already has a Prometheus Input Plugin which means all you need to do is start the Http Exporter and configure the endpoint on the plugin:
# Read metrics from one or many prometheus clients
[[inputs.prometheus]]
  ## An array of urls to scrape metrics from.
  urls = ["http://localhost:9100/metrics"]

Sure but then I need to either run Prometheus infrastructure or change my Telegraf config every time I have a new app instance :)

I may be misunderstanding something, the way I see this, you can use zio-metrics-prometheus to instrument your app and then start the Http Exporter. Then you add the Prometheus plugin to your Telegraf and configure the endpoint from the exporter. This would be only one more input source to your existing Telegraf.
Regardless of the above, is there a Telegraf API that can be invoked directly?

Let's say I have my app running in Kubernetes. At any given time I may have 60 instances, depending on how well the app works, those pods restart at will, each time having a new IP.
The way I understand it, the app becomes the Prometheus client, does it not? So Telegraf would have to have a list of all my pod IPs at all times.
If you use censorinus (linked above), you just send simple UDP packets to Telegraf and it forwards those into an InfluxDB, where you can hook up a UI.
There is no fetching of metrics at all, everything flows in one direction (App -> Telegraf -> InfluxDB -> UI), as opposed to the HTTP server Prometheus needs, which is scraped. (and then leads to a App <- Telegraf -> InfluxDB graph)

Oh, I get it now! Just one question, the setup you described needs the
Telegraf Statsd input plugin, right?
I'll start work on adding this today.
On Fri, 10 Jan 2020, 20:16 Tim Steinbach, notifications@github.com wrote:

Let's say I have my app running in Kubernetes. At any given time I may
have 60 instances, depending on how well the app works, those pods restart
at will, each time having a new IP.
The way I understand it, the app becomes the Prometheus client, does it
not? So Telegraf would have to have a list of all my pod IPs at all times.
If you use censorinus (linked above), you just send simple UDP packets to
Telegraf and it forwards those into an InfluxDB, where you can hook up a UI.
There is no fetching of metrics at all, everything flows in one direction
(App -> Telegraf -> InfluxDB -> UI), as opposed to the HTTP server
Prometheus needs, which is scraped. (and then leads to a App <- Telegraf ->
InfluxDB graph)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/zio/zio-metrics/issues/19?email_source=notifications&email_token=AABID2MOE4FJ6SXBQL6ATULQ5DCQPA5CNFSM4J6MP5M2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIU53WI#issuecomment-573169113,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABID2MH66ZIYTHAIKGCRJLQ5DCQPANCNFSM4J6MP5MQ
.

Yes, it will :+1:

Implemented in v0.1.0

authors: NeQuissimus toxicafunk

repo: zio/zio-metrics


text:
[Bug]: Loop redirect if single IdP return error

Preflight Checklist

[X] I could not find a solution in the documentation, the existing issues or discussions
[ ] I have joined the ZITADEL chat

Environment
Self-hosted
Version
v2.27.1
Describe the problem caused by this bug
I created single Identity Provider for my Zitadel organization and disabled "Username Password allowed" option. Now when I'm trying to log in via IdP and its return error for some reason, instead of login page with error message Zitadel redirect back to IdP, its return same error, and Zitadel redirect to IdP again, and this loop is infinite.
If I have several Identity Providers for one organization, I see login page with error message from IdP without any problem.
To reproduce

Create Identity Provider with incorrect setting
Go to login page
See internal redirect between Zitadel and IdP

Screenshots

Expected behavior
In case of error from IdP Zitadel shows login page with error message.
Operating System
No response
Relevant Configuration
No response
Additional Context
I checked code and saw this strange logic:
https://github.com/zitadel/zitadel/blob/main/internal/api/ui/login/login_handler.go#L98
Looks like Zitadel need to check errID and errMessage before calling handleIDP

Hei @megge-dream
Thanks for reporting the bug. We will have a lookt at it.

FYI - I encountered this problem today with a SAML IDP. The organization had the username and password login disabled while a misconfiguration on the IDP side (JumpCloud) was causing an error after the IDP returned to Zitadel.
Here is a video of the issue:
Screencast from 23-04-2024 14:15:58.webm

authors: hifabienne megge-dream vs-gtadeu

repo: zitadel/zitadel


text:
JSDoc: add document

Thanks @lijiarui

Link back to the track issue: https://github.com/zixia/wechaty-blinder/issues/3

repo: zixia/hot-import


text:
Integrate circom-witness-rs

importing circom-witness-rs
have to implement new operations to make graph.bin gen work with our circuit, c.f. https://github.com/philsippl/circom-witness-rs/issues/8
deleted some dylib functions

This would:

Make witness gen way faster
Avoid the .wasm, .dylib and .framework issues on iOS

Example use can be found here

Closing for now as the polygon witnesscalc is pretty fast so not planning on switching soon

repo: zk-passport/proof-of-passport


text:
issue 85 - implement add_auth method to send authentication credentials ...

Included rdoc and unit test as requested. :)

Thank you for this contribution, and I'm sorry it took so long to merge.
released as part of 1.9.5

repo: zk-ruby/zk

license: mit

license_source: bigquery


text:
Recv rate periodically drops to 0p/s every 43 seconds

Describe the bug
recv rate as printed in ticker periodically drops to 0 or 1 p/s, exactly every 43 seconds.
4:59:33 9% (2d03h left); send: 266915011 14.2 Kp/s (14.8 Kp/s avg); recv: 523631 21 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:34 9% (2d03h left); send: 266929894 14.9 Kp/s (14.8 Kp/s avg); recv: 523659 28 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:35 9% (2d03h left); send: 266944776 14.9 Kp/s (14.8 Kp/s avg); recv: 523687 28 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:36 9% (2d03h left); send: 266959659 14.9 Kp/s (14.8 Kp/s avg); recv: 523717 30 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
*****4:59:37 9% (2d03h left); send: 266974542 14.9 Kp/s (14.8 Kp/s avg); recv: 523717 0 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:38 9% (2d03h left); send: 266989425 14.9 Kp/s (14.8 Kp/s avg); recv: 523743 26 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:39 9% (2d03h left); send: 267004307 14.9 Kp/s (14.8 Kp/s avg); recv: 523779 36 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:40 9% (2d03h left); send: 267019189 14.9 Kp/s (14.8 Kp/s avg); recv: 523810 31 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:41 9% (2d03h left); send: 267034072 14.9 Kp/s (14.8 Kp/s avg); recv: 523842 32 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:42 9% (2d03h left); send: 267048955 14.9 Kp/s (14.8 Kp/s avg); recv: 523866 24 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:43 9% (2d03h left); send: 267063836 14.9 Kp/s (14.8 Kp/s avg); recv: 523899 33 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:44 9% (2d03h left); send: 267078718 14.9 Kp/s (14.8 Kp/s avg); recv: 523930 31 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:45 9% (2d03h left); send: 267093604 14.9 Kp/s (14.8 Kp/s avg); recv: 523972 42 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:46 9% (2d03h left); send: 267108486 14.9 Kp/s (14.8 Kp/s avg); recv: 524000 28 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:47 9% (2d03h left); send: 267123369 14.9 Kp/s (14.8 Kp/s avg); recv: 524024 24 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:48 9% (2d03h left); send: 267138252 14.9 Kp/s (14.8 Kp/s avg); recv: 524053 29 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:49 9% (2d03h left); send: 267153135 14.9 Kp/s (14.8 Kp/s avg); recv: 524083 30 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:50 9% (2d03h left); send: 267168017 14.9 Kp/s (14.8 Kp/s avg); recv: 524125 42 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:51 9% (2d03h left); send: 267182900 14.9 Kp/s (14.8 Kp/s avg); recv: 524156 31 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:52 9% (2d03h left); send: 267197783 14.9 Kp/s (14.8 Kp/s avg); recv: 524187 31 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:53 9% (2d03h left); send: 267212665 14.9 Kp/s (14.8 Kp/s avg); recv: 524218 31 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:54 9% (2d03h left); send: 267227548 14.9 Kp/s (14.8 Kp/s avg); recv: 524254 36 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:55 9% (2d03h left); send: 267242430 14.9 Kp/s (14.8 Kp/s avg); recv: 524281 27 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:56 9% (2d03h left); send: 267257020 14.6 Kp/s (14.8 Kp/s avg); recv: 524308 27 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:57 9% (2d03h left); send: 267271478 14.5 Kp/s (14.8 Kp/s avg); recv: 524334 26 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:58 9% (2d03h left); send: 267286360 14.9 Kp/s (14.8 Kp/s avg); recv: 524371 37 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
4:59:59 9% (2d03h left); send: 267301243 14.9 Kp/s (14.8 Kp/s avg); recv: 524409 38 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:00 9% (2d03h left); send: 267316125 14.9 Kp/s (14.8 Kp/s avg); recv: 524436 27 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:01 9% (2d03h left); send: 267331007 14.9 Kp/s (14.8 Kp/s avg); recv: 524473 37 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:02 9% (2d03h left); send: 267345890 14.9 Kp/s (14.8 Kp/s avg); recv: 524495 22 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:03 9% (2d03h left); send: 267360773 14.9 Kp/s (14.8 Kp/s avg); recv: 524514 19 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:04 9% (2d03h left); send: 267375655 14.9 Kp/s (14.8 Kp/s avg); recv: 524548 34 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:05 9% (2d03h left); send: 267390538 14.9 Kp/s (14.8 Kp/s avg); recv: 524577 29 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:06 9% (2d03h left); send: 267405421 14.9 Kp/s (14.8 Kp/s avg); recv: 524611 34 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:07 9% (2d03h left); send: 267420304 14.9 Kp/s (14.8 Kp/s avg); recv: 524631 20 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:08 9% (2d03h left); send: 267435186 14.9 Kp/s (14.8 Kp/s avg); recv: 524658 27 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:09 9% (2d03h left); send: 267450069 14.9 Kp/s (14.8 Kp/s avg); recv: 524687 29 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:10 9% (2d03h left); send: 267464953 14.9 Kp/s (14.8 Kp/s avg); recv: 524712 25 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:11 9% (2d03h left); send: 267479835 14.9 Kp/s (14.8 Kp/s avg); recv: 524742 30 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:12 9% (2d03h left); send: 267494718 14.9 Kp/s (14.8 Kp/s avg); recv: 524778 36 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:13 9% (2d03h left); send: 267509601 14.9 Kp/s (14.8 Kp/s avg); recv: 524800 22 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:14 9% (2d03h left); send: 267524484 14.9 Kp/s (14.8 Kp/s avg); recv: 524826 26 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:15 9% (2d03h left); send: 267539366 14.9 Kp/s (14.8 Kp/s avg); recv: 524855 29 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:16 9% (2d03h left); send: 267554250 14.9 Kp/s (14.8 Kp/s avg); recv: 524880 25 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:17 9% (2d03h left); send: 267569132 14.9 Kp/s (14.8 Kp/s avg); recv: 524908 28 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:18 9% (2d03h left); send: 267584014 14.9 Kp/s (14.8 Kp/s avg); recv: 524943 35 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:19 9% (2d03h left); send: 267598897 14.9 Kp/s (14.8 Kp/s avg); recv: 524968 25 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
*****5:00:20 9% (2d03h left); send: 267613780 14.9 Kp/s (14.8 Kp/s avg); recv: 524968 0 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:21 9% (2d03h left); send: 267628662 14.9 Kp/s (14.8 Kp/s avg); recv: 525003 35 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:22 9% (2d03h left); send: 267643546 14.9 Kp/s (14.8 Kp/s avg); recv: 525023 20 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%
5:00:23 9% (2d03h left); send: 267658429 14.9 Kp/s (14.8 Kp/s avg); recv: 525051 28 p/s (29 p/s avg); drops: 0 p/s (0 p/s avg); hitrate: 0.20%

Please note the lines marked with ***** where recv is 0p/s. Exactly every 43rd line is like this, and no other lines are.
CLI Arguments
sudo podman run -it --rm --network=host --cap-add=NET_RAW --name "zmap" -v ./:/scandata/ zmap --allowlist /scandata/allowlist.txt -p 5432 --bandwidth=10M -e 1234 -o /scandata/targets.csv -i ens192 --blocklist /scandata/blocklist_${1}.txt
Expected behavior
Not sure if this is expected behavior or not. Is this normal?
Environment:

OS: Debian Bookworm running zmap v3.0.0 docker container via podman
Version: v3.0.0

I am able to reproduce on Ubuntu 23.10 with both ZMap v.3.0.0 and main.
I'll investigate!

Update: I wanted to see if this was an issue where ZMap was somehow consistently dropping/not recording packets received after 43 seconds. I did a comparison of the output from a 60 second ZMap scan and a tcpdump taken at the same time and both captured the same list of IPs.
So this issue isn't with packet capture, it must be with recording in which second the packet came in so we can display per-second output. Going to check that out today.

Found the issue. So we have 2 threads, a monitor and a receive thread. The monitor thread runs every 1.0003 seconds (sleeps for a second + the overhead of reporting on everything) and the receiving thread runs every 1.0238 seconds pretty consistently. So every 1 / (1.0238 - 1.0003) = 42.55 seconds the monitor thread will run twice within 2 receive executions. We can see that here:
 78 Apr 26 19:43:52.787 [WARN] recv: pcap_dispatch returned 194
 79 Apr 26 19:43:52.879 [WARN] monitor: monitor thread running
 80 Apr 26 19:43:53.811 [WARN] recv: pcap_dispatch returned 201
 81 Apr 26 19:43:53.880 [WARN] monitor: monitor thread running
 82 Apr 26 19:43:54.835 [WARN] recv: pcap_dispatch returned 200
 83 Apr 26 19:43:54.880 [WARN] monitor: monitor thread running
 84 Apr 26 19:43:55.860 [WARN] recv: pcap_dispatch returned 186
 85 Apr 26 19:43:55.880 [WARN] monitor: monitor thread running
 86 Apr 26 19:43:56.880 [WARN] monitor: monitor thread running

When this happens, the monitor thread notes that no new packets have been received since the last time it ran, hence seeing recv: XXX 0p/s....

@zakird What do you think? We could reduce PCAP_TIMEOUT to something smaller (10-100 ms) so the receive function runs more frequently. That would amortize/smooth the difference in packets captured within the two different time windows at the cost of increased trips to the kernel. I thought a pthread_cond could help, but whenever I think about that, I can't help but think that'll cause our monitor thread to not run on its precise 1 second schedule (it would instead wait until there's new packets captured by the receive thread), and that seems bad for any program that's expecting a per-second log.

OK, that's actually pretty funny. I have no issue reducing PCAP_TIMEOUT. I think that the CPU usage there is going to be fairly negligible. Let's drop to 100ms and see how that goes?

authors: jcasc phillip-stephens zakird

repo: zmap/zmap


text:
Rolling machine in Alpha 1.1.7

I try to set the rolling machine，but even if it's same to what the holo projector displays，it's still unsuccessful。

What direction is the controller facing?  Is it facing away from the input hatches?
if so, when you right click it, where does the red X appear?

@zmaster587 Oh，the face must be correct……I‘m wrong。
But I think machines should have more correct faces。

What do you mean by more correct faces?

@zmaster587 I mean,now the correct controller facing has only one,or mistake will happen,so I hope the facing of machine shouldn't decide if the setting of machine is right--see Woot by ipsis,the facing of the mob factory must be right,it will trouble players.

Due to the way structures are handled the result could be ambiguous depending on the direction a machine is facing.  EX: Trying to build machine A and B next to each other, both machines have similar configurations, forming machine A may use machine B's blocks preventing machine B from forming.
The holo projector should be indicating the front of the machine, however I see in the screenshot there it is not. I'll see if i can figure out why


text:
Using date-time in a query param does not generate a timestamp

Description
My API takes two timestamps as query parameters.
Steps to reproduce

Create a api.yaml with

openapi: 3.0.1
info:
  title: New Feature
  version: "1"
paths:
  /customer/name:
    get:
      summary: New scenario
      parameters:
      - name: timestamp
        in: query
        schema:
          type: string
          format: date-time
        example: '2023-01-12T12:53:10.16048'
      responses:
        "200":
          description: New scenario
          content:
            text/plain:
              schema:
                type: string

Run this command: specmatic samples api.yaml

Expected behavior
That specmatic creates example requests with timestamps.
Instead it generates this request (where instead of a timestamp, it is the object ID):
{
    "requestTime": "2023-1-13 0:45:23.750",
    "http-request": {
        "path": "/customer/name",
        "method": "GET",
        "query": {
            "timestamp": "in.specmatic.core.pattern.DateTimePattern@5fef2aac"
        },
        "headers": {
            "Accept-Charset": "UTF-8",
            "Accept": "*/*"
        },
        "body": ""
    }
}

System Information:

Specmatic version: 0.59.0

Additional context
It behaves similarly when trying to run it with contract tests. It seems to be some issue with how date-time is serialized.

The same happens when trying to run it with SpecmaticJUnitSupport -  the request becomes:
  Request to http://localhost:8080 at 2023-1-13 1:29:54.175
    GET /customer/name?timestamp=in.specmatic.core.pattern.DateTimePattern@372461a9&tom=in.specmatic.core.pattern.DateTimePattern@372461a9
    Accept-Charset: UTF-8
    Accept: */*

@androa Thanks for reporting this issue. The details shared by you are really helpful and I was able to reproduce the issues. Also I tested the changes in your PR and I have responded with a unit test that for the same.

repo: znsio/specmatic


text:
Fix/boot loading

Description
Refactor initial boot with asyncStorage and redux
On what platform have you tested the change?

[x] Android - Emulator
[ ] Android - Physical device
[x] iOS - Emulator
[ ] iOS - Physical device

Screenshots
Please attach screenshots showing the change if relevant
Checklist

[ ] I have updated mockServer
[ ] I've added analytics as relevent
[ ] I have run npm test
[ ] I have run npm run test:i18n

Out of scope and potential follow-up
Is there any related changes that you plan to do in a follow-up PR or voluntarily excluded from the scope?

Is this ready for review or still a draft @petermason ?

Is this ready for review or still a draft @petermason ?

authors: petermason the-kenneth

repo: zoe/covid-tracker-react-native


text:
issue1

[x] Additional markup is supported, including @mentions, #references, links, emphasis, and HTML tags.
[x] List syntax is required.

You can nest lists below, too!

[x] This item is completed.
[ ] This item is not complete.

[ ] Turn on GitHub Pages

[ ] Outline my portfolio
[ ] Introduce myself to the world

[ ] Turn on GitHub Pages
[ ] Outline my portfolio
[ ] Introduce myself to the world

[ ] yes, we need it
[ ] No, not needed at all
[ ] Maybe, if at a good price

-[X] yes, we need it
-[] No, not needed at all
-[] Maybe, if at a good price

[X] yes, we need it
[ ] No, not needed at all
[ ] Maybe, if at a good price

[ ] Turn on GitHub Pages
[ ] Outline my portfolio
[ ] Introduce myself to the world

repo: zohreh-m/markdown-portfolio


text:
Archive page for whaling.oldweather.org

Just copying here the thread from Slack, so it's easy to retrieve and Zach, Adam, Sarah can discuss as needed.
Laura:
whaling.oldweather.org is officially no longer active, as of last week. They finished the last data set and now volunteers are only working through the spreadsheet effort (via links within oldweather.org).
Kevin’s request was that we move whaling.oldweather.org to x.oldweather.org for a couple months, if possible, while he goes through all the materials and moves over remaining stuff to his archives, etc.
But no active classifying, etc. is happening at whaling.oldweather.org (not sure if that helps you at all).
(Apparently moving to x.oldweather.org is something [Adam?] did for classic.oldweather.org previously, so they could do the same look-through of materials before fully retiring it, but also make sure that no volunteers went to the old URL (e.g. whaling.oldweather.org) and wasted time trying to do anything there.
Adam asked:
What do we want to put up in its place? Just the normal retirement page (similar to https://whale.fm)?
Laura responded:
Yes, thank you for thinking of that. A retirement/archived page along those lines would be good. Would it be helpful if I provide you copy for that?
Adam:
That'd be great, thanks. I was thinking this might be a good thing for @zach to do if he has time since it involves touching a couple of different parts of the infrastructure (DNS and Nginx config)
Zach:
:+1:
Zach:
link me at an issue with the details and I’ll put it on my ops list
Adam:
I'd be happy to pair on it next week too if you'd like
Zach:
Sure, keep in mind that I’ll be in Oxford the week of the 8th too, if it can wait.

This link provides the content for the Archive page:
https://docs.google.com/document/d/1WfWvKjHszC6dcSWZr0lLVw-ksKu1MJfuHvGdcMcAS_0/edit?usp=sharing
And https://drive.google.com/drive/folders/19iDl6RFr6o2rxBX2VOZmFrf2Rdjy_AnG?usp=sharing has the link to the high-res of the image that's in there.

@mcbouslog This is low priority. Might be something to do while Sarah is in Oxford next week or on break the following week. You'll be the one to create the static 'archive' page for whaling, based on the content doc linked above. Once the page exists, then Adam/Zach will plug in the right redirects that are needed.

repo: zooniverse/Panoptes


text:
better mime types and readme updates

Don't rely on s3cmd mime magic instead guess on the file extension. Also updated the readme for getting started / fresh deploys.

LGTM.

authors: camallen simoneduca

repo: zooniverse/old-weather


text:
setup_permissions Documentation / clarification

Can you add more info about setup_permissions on iOS?
What does the setup_permissions do ? Why do we need it ? Is it mandatory ?
I installed "react-native-permissions": "^4.1.0" and didn't configure setup_permissions and did not imported the react-native-permissions/scripts/setup.rb and I could request Camera permissions on iOS with react-native-permissions.
Not sure, but i want to notice the I have installed and other libraries that use camere and can request permissions by themself.

It edits the podspec file to include additional sources. By default, the native code to check / request specific permissions is not included https://github.com/zoontek/react-native-permissions/blob/731692e4e3207832c0b437393a4c7df33abb0f2e/RNPermissions.podspec#L18
Without this step, requests resolve to UNAVAILABLE

authors: sanduluca zoontek

repo: zoontek/react-native-permissions


text:
Protect against infinite recursive fork if python lacks the json module (e.g. older install)

https://github.com/zplug/zplug/issues/388

LGTM

repo: zplug/zplug


text:
关于实验结果

您好，您的工作给我带来了很大的启发。
我按照文章给的超参数与实验设计对模型重新进行了预训练和微调，在missing rate为0.7下进行了实验，实验结果是在CMU-MOSI数据集上F1 score和Acc分别是0.69和0.70；在IEMOCAP数据集上F1 score和Acc分别是0.57和0.58；在CH-SMIS数据集上F1 score和Acc分别是0.82和0.70。
实验结果与文章图4差距较大，请问作者是加了什么其它的小trick吗？

您用了哪些seed的值？感谢您的回复

看着像预训练模型没优化充分，因为prompt参数较少，预训练模型效果也会略微影响。能提供预训练模型在这些数据集上的性能吗。

预训练模型在CMU_MOSEI的F1和Acc分别为，0.79、0.79；
在CMU-MOSI数据集上：0.72、0.70；
在IEMOCAP数据集上：0.54、0.55；
在CH-SMIS数据集上：0.82、0.70；
发现与微调后的性能接近，微调并没有带来明显的性能提升。
可能是预训练过程中超参数的设定问题吗，想请问一下作者您预训练过程中使用的超参数

预训练模型在CMU_MOSEI的F1和Acc分别为，0.79、0.79； 在CMU-MOSI数据集上：0.72、0.70； 在IEMOCAP数据集上：0.54、0.55； 在CH-SMIS数据集上：0.82、0.70； 发现与微调后的性能接近，微调并没有带来明显的性能提升。 可能是预训练过程中超参数的设定问题吗，想请问一下作者您预训练过程中使用的超参数

充分优化的预训练模型应该在0.82-0.84左右，直接迁移到MOSI上也会有0.8以上的准确率。预训练模型在IEMOCAP和SIMS上直接迁移不了，因为特征维度和预测头有略微不同，你测试的准确率是更改了conv层和head在完整模态数据集上的吗。预训练过程的超参数用代码默认的超参数也可以达到0.82以上，可以参考MulT论文中的结果和参数。预训练模型在下游数据集上微调损失下降还是比较明显的，我这里微调MOSI在第一个epoch损失1.4左右，到20-30个epoch可以到1.0左右，大概20个epoch才会慢慢收敛。

authors: ZhaiYanbo zrguo

repo: zrguo/MPLMM


text:
scanmode: 'all' does not identify secrets from historic commits

I'm implementing gitleaks as cred scanner alternative in a DevOps pipeline using YAML.
Trying out scanmode 'all' option on a feature branch with multiple commits, the runs seem to only detect the current state of the branch and not previous commits. What is the expected behavior, is any additional settings that I'm missing?

Hi @meeragirijan, could you provide the command you are attempting to run? Also what version of gitleaks are you using?

@zricethezav  Got this resolved. I had to set the fetchDepth to 0 explicitly on the repo; without it, it was defaulting and checking only the latest commit. It would be good to update the documentation with this for future reference.

Got this resolved. I had to set the fetchDepth to 0 explicitly on the repo; without it, it was defaulting and checking only the latest commit. It would be good to update the documentation with this for future reference.

@meeragirijan are you referring to the gitleaks-action?
As this has been resolved, I'm going to close this issue.

authors: meeragirijan zricethezav

repo: zricethezav/gitleaks


text:
Exclude encrypted cosign private keys

Is your feature request related to a problem? Please describe.
Cosign has a safe way for storing encrypted private keys inside of repositories. They identify these files using the "ENCRYPTED COSIGN PRIVATE KEY" header.
Describe the solution you'd like
These encrypted cosign private keys should not be flagged by the private-key ruleid.
cc @zricethezav

My first thought was to add a negative lookahead but according to this and this, those aren't supported.  I was hoping that we could replace this:
https://github.com/zricethezav/gitleaks/blob/d0733f96f3df2e078da4ee42fee92c9da69962bd/config/gitleaks.toml#L2414
with:
 regex = '''(?i)-----BEGIN(?! ENCRYPTED COSIGN)[ A-Z0-9_-]{0,100}PRIVATE KEY( BLOCK)?-----[\s\S-]*KEY----'''

@JonZeolla can you provide an example false positive?

@zricethezav https://github.com/SeisoLLC/easy_infra/blob/main/cosign.key

authors: JonZeolla zricethezav


text:
Remove archived Asciinema video from README.md

The Asciinema video is broken ATM, and currently it has a misleading "Archival" warning, which at first glance made me think the entire Antigen project was affected. I don't see an archive of it online anywhere so I can't offer a repaired link, so for now I think it'd be best to remove it entirely.

Looks like this was resolved in https://github.com/zsh-users/antigen/commit/76d5e9502d27515bcbab0d130574f2e79777524a. Closing as resolved. Thanks for feedback everyone!

repo: zsh-users/antigen


text:
highlighting commands does not consider environment variables

If you start a command with an environment variable, the command is highlighted as if it is invalid.
$ /bin/sh     # highlighted correctly
$ export BIN=/bin
$ $BIN/sh   # highlighted with the "invalid command" highlighting, even though `$BIN` contains a valid path

The export is unrelated. The issue is that the block handling parameters (et seq) only handles $foo or ${foo}. Looks like a dup of #484.

Duplicate of #484, with virtually the same example, even.

authors: danielshahaf euclio phy1729

repo: zsh-users/zsh-syntax-highlighting


text:
fix bug 2411

for https://github.com/zstackio/issues/issues/2411
该case应该是属于基本功能校验，没有场景

Reviewed by @zstackio/qa

authors: camilesing quarkonics

repo: zstackio/zstack


text:
手机浏览器上没有拦截的网页提示tls错误，不能访问

Verify steps

[X]  我已经在 Issue Tracker 中找过我要提出的问题 I have searched on the issue tracker for a related issue.
[X]  我已经仔细看过 Documentation 并无法自行解决问题 I have read the documentation and was unable to solve the issue.

Version
0.4.1
What OS are you seeing the problem on?
Linux
Rule file
- name: "disneyplus"
  mitm:
    - "*.disneyplus.com"
  actions:
    - modify-request:
       xxxxxxxx.....

log
[2022-12-09T09:49:02Z ERROR good_mitm_core::mitm] Tls accept failed: received fatal alert: CertificateUnknown
[2022-12-09T09:49:03Z ERROR good_mitm_core::mitm] Tls accept failed: tls handshake eof
[2022-12-09T09:49:03Z ERROR good_mitm_core::mitm] Tls accept failed: tls handshake eof
[2022-12-09T09:49:04Z ERROR good_mitm_core::mitm] Tls accept failed: tls handshake eof
[2022-12-09T09:49:04Z ERROR good_mitm_core::mitm] Tls accept failed: tls handshake eof
[2022-12-09T09:49:04Z ERROR good_mitm_core::mitm] Tls accept failed: received corrupt message
[2022-12-09T09:49:05Z ERROR good_mitm_core::mitm] Tls accept failed: received corrupt message
[2022-12-09T09:49:06Z ERROR good_mitm_core::mitm] Tls accept failed: received corrupt message
[2022-12-09T09:49:08Z ERROR good_mitm_core::mitm] Tls accept failed: tls handshake eof
[2022-12-09T09:49:09Z ERROR good_mitm_core::mitm] Tls accept failed: tls handshake eof
[2022-12-09T09:49:09Z ERROR good_mitm_core::mitm] Tls accept failed: tls handshake eof
[2022-12-09T09:49:10Z ERROR good_mitm_core::mitm] Tls accept failed: received corrupt message
[2022-12-09T09:49:10Z ERROR good_mitm_core::mitm] Tls accept failed: received corrupt message

Description
手机开小火箭代理，后端使用官网上面的透明代理
手机没有安装证书
打开disneyplus.com 正常提示证书不受信任
但是使用其他网站（例如google.com）报tls错误，Google浏览器直接说页面错误。
按道理我只拦截disneyplus.com，只是这个网站需要证书，其他网站不需要才对吧？
（上述情况电脑上测试却是正常的，Google搜索正常，disneyplus提示证书不安全，只是手机上谷歌浏览器有问题，其他浏览器没测试）

无法复现


text:
请问有JS的版本 下载的好像是TS的

请问有JS的版本 下载的好像是TS的

你好，这就是js的版本
不需要区分ts、js，因为只需要在根目录增加tsconfig.json，就可以识别ts文件
Duplicate https://github.com/zuiidea/antd-admin/issues/870

repo: zuiidea/antd-admin


text:
notif: Use Zulip's custom notification sound on Android

(Stacked on top of #981)
(Split from #717)
Fixes: #340

Thanks for the review @PIG208! Addressed them in the new revision.

Thanks for the review @gnprice! I've pushed the revision — PTAL.

Thanks for the review @gnprice! Pushed a new revision, PTAL.

repo: zulip/zulip-flutter


text:
Stream subscribe buttons are slow to react

The stream subscribe buttons are sometimes slower than usual.

@harshbisle are you working on this?

@sumukhah yes.!! Please check the other issues

@harshbisle, mention if you are working on the issue so that other developers won't spend time at fixing.

Yes @sumukhah I am working on this issue.
Thank you.

I am assigning this to @harshbisle, for better visibility.

Thanks @jainkuniya

@harshbisle they're slower because a request is being made to the server, and the server has to process the request and reflect those changes. The slowness might be because of the server side slowness or your network bandwidth.
You can refer to issue #3944

@Maskedman99 yeah I agree on that. But as @gnprice says "I touch it and it might flicker over to the new value, come right back to the old value, then a second or two later return to the new one. The exact sequence varies."in the  issue #3944 that thing should happen even though it's related to server I think.

https://github.com/zulip/zulip-mobile/issues/3944#issuecomment-601468373
you can see the difference.

Ah, not just that it's slow to react, but that it's jumpy! Sorry; it's not always easy to tell if a switch is actually jumping, or if the GIF just has a low frame rate.
Merging this into #3944, which is a preexisting bug about the same behavior elsewhere.

authors: Maskedman99 harshbisle jainkuniya ray-kraesig sumukhah

repo: zulip/zulip-mobile


text:
ios build is not loading css/static files correctly.

I am building an ios build of the Zulip app, initially had an issue with all the fonts mentioned in info.plist file
<array>
		<string>zulip-icons.ttf</string>
		<string>Entypo.ttf</string>
		<string>EvilIcons.ttf</string>
		<string>FontAwesome.ttf</string>
		<string>Foundation.ttf</string>
		<string>Ionicons.ttf</string>
		<string>Feather.ttf</string>
		<string>MaterialIcons.ttf</string>
		<string>Octicons.ttf</string>
		<string>Zocial.ttf</string>
		<string>SimpleLineIcons.ttf</string>
		<string>MaterialCommunityIcons.ttf</string>
	</array>

after dowloading all the fonts I got the issue fixed and the character is getting parsed correctly.

but when i switch to message/dm panel the css doesn't seems to be working

here messaged and profile is not formated/styled correctly. Anyhelp with this would be appreciated.

Chat thread: https://chat.zulip.org/#narrow/stream/48-mobile/topic/css.20missing.20.23M5820/near/1733900

Conclusion here: https://chat.zulip.org/#narrow/stream/48-mobile/topic/css.20missing.20.23M5820/near/1740985
It turned out the issue was that CocoaPods hadn't been installed. That's one of the required setup steps for iOS in our setup instructions.
Quoting one of my messages there:

So if we had the information to debug what went wrong for you and why, then I'd want to add the needed code to either take care of it, or give a clear error instead of the half-working result you originally got.
But because this app is now in maintenance mode as we build the new app in Flutter, we won't have time to drive that debugging ourselves. Glad you got the app working, in any case.


text:
group-pm: Improve the text color on group icons

Determine the color of text on group avatar by using foregroundColorFromBackground() this will help users to read the text properly when the background color is light.

Also replace the for loop in colorHashFromString() with a single line equation that will reduce the complexity from O(n) to O(1).
The for loop before resulted in a recursive equation:
hash(N) = hash(N-1) * 31 + name.charCodeAt(1)       , hash(0) = 0
This actually is the sum of the first N terms in a Geometric Progression, for which a mathematical equation is already present.
The for loop ran till names.length, whose value depends on the no.of members in a group. For a certain large value and above, JS wouldn't be able to calculate the value of hash and returns infinity,  this happens in the equation too, hence the value names.length % 100 was used instead of names.length.

The use of foregroundColorFromBackground is a good idea, and will be accepted if resubmitted on its own.
However, colorHashFromString is completely broken, in multiple ways; optimizing a poorly-chosen algorithm only moves it farther away from something useful. Please omit this part. (Thanks for calling our attention to it, though.)

@ray-kraesig I've done the suggested modifications.

Merged (after some minor proofreading in the commit message). Thanks!


text:
Move the chevrons in the stream list farther from the scrollbar

Description
As @timabbott also pointed out, right now the chevrons in the stream list are too close from the scrollbar, which is a bit uncomfortable and doesn't look good aesthetically either.
Moving them some pixels to the left should do it.

By the way, keep in mind that #4436 makes scrollbars wider, so we may need to move the chevrons more than the current (narrower) scrollbar requires.
Feel free to comment this in the Zulip development chat to discuss and clarify this.

@zulipbot claim

Would this be good @YagoGG?

I have moved both the count div and the chevron 5px to the left.

Looks reasonable.  Can you post a screenshot of what it looks like with the scrollbar not visible?  Also, test what happens with a super-long topic -- it's possible we need to tweak some other CSS as well.

Here is the screenshot with scrollbar not visible and a super-long topic.

It gets kind of squeezed in the case of super-long topic. Either we can reduce the number of characters being displayed as the topic name. Or move the .topic-name and .stream-name to the left by the same number of pixels we are moving the chevrons. What do you say @timabbott ?

Yeah, that looks wrong.  Given the space, I think we could afford to move the topic name and chevron a similar distance.  It might also make sense to decrease the movement of the chevron by a few pixels, so that with the scrollbar visible, the chevrom is directly between the scrollbar and number (you have it a bit closer to the number).

@timabbott Done!
Made a pull request: #4359.

This was fixed in #4539.

authors: YagoGG digi0ps timabbott

repo: zulip/zulip


text:
Make compose-box emoji modal's bottom line opaque.

In order to reproduce this, use FF and set the zoom to 90%:

If you open the emoji modal at 90% zoom, and then select one of the emojis, you'll see stuff leaking through the bottom line, as shown in the image above.
Here is the place where it's too transparent:

fun! Really also just what looks like a case of hiding overflow, since it should be a contained modal.

I dont actually see this issue on osx. I could take the approach of setting the popover overflow to hidden but I'm unable to replicate this.

@brockwhittaker maybe produce a quick PR that does that and then @showell can test whether it fixes the problem in his browser?

@brockwhittaker
An important detail for the repro is to do it from the compose box.  But if it doesn't repro on OSX, I would borrow Tim's ubuntu computer for a second.  I'm also happy to just test a speculative fix that you make without the repro, as @timabbott is suggesting.

@brockwhittaker @showell is this issue fixed?

I've confirmed that this was fixed some time ago (just tried to reproduce).

authors: brockwhittaker showell timabbott


text:
zerver/lib/notifications.py: Fix an annotation

I don't know how this got left out during my previous annotation.
Fixing this is necessary to prevent a clash while annotating zerver/lib/email_mirror.py (#940).

Automated message from Dropbox CLA bot
@sharmaeklavya2, it looks like you've already signed the Dropbox CLA. Thanks!

Merged!

authors: sharmaeklavya2 smarx timabbott


text:
#10840 Makes it easier to figure out whether the user has clicked on a reaction in night mode

PR for: https://github.com/zulip/zulip/issues/10840

Also fixes: Earlier on hovering over a reaction in night mode there was no change in its behavior, now they show a white border distinguishing them from the non - hovered ones.

closing to rebase to get rid of the unwanted commit history.


text:
import_realm: Close the memcached connection before forking

This prevents the memcached connection from being shared across multiple processes, and hopefully addresses unexpected behavior from cached functions like get_user_profile_by_id invoked inside the worker processes.
Testing Plan: Not tested yet.

If we're doing this fiddly work in 4 places, it might be good to factor it out somewhere.

Do we have any way of testing this, other than "try it in prod"?  I'd be curious if that reproduces the failure, at least.

I was treating this as a quick fix to address the bug. I think the “right” solution would be to switch from processes to threads, since the PostgreSQL and memcached connection wrappers are already threadsafe.

I think it's reasonable to merge this to master; the thing I'd want to factor out would likely be the whole block as a function accepting just the function and the list:
            connection.close()
            cache._cache.disconnect_all()
            with multiprocessing.Pool(processes) as p:
                for out in p.imap_unordered(process_avatars, records):
                    pass

(I think "try in prod" is a reasonable way to test whether this change is sufficient; it seems clearly correct, at least)

authors: alexmv andersk timabbott


text:
upgrade: Create prod_settings symlink in step 2 if it doesn't exist.

Between releases 1.3.13 and 1.4.0, local_settings.py was renamed to
prod_settings.py. The upgrade scripts were adjusted to reflect this name
change. But because the first part of the upgrade script is run with the
currently installed version's code, the symlink to /etc/zulip/settings.py is
created with the old name. This was causing upgrade-zulip-stage-2 to fail.
Now upgrade-zulip-stage-2 creates the symlink at zproject/prod_settings.py
if it doesn't already exist.
Fixes #1731.

Automated message from Dropbox CLA bot
@rishig, it looks like you've already signed the Dropbox CLA. Thanks!

This fix was merged as part of the 1.4.1 release.

authors: rishig smarx timabbott


text:
Complete custom email notification batching period feature.

Fixes #15280
Screenshots

@sahil839 Could you review this?

Thanks for the review! (and sorry for the slow response 😅) I've updated the PR after addressing the comment above. For the UX:

We can disable the setting if email notifications are disabled.

I tried doing that (after checking out how that's implemented for the "notification sound" dropdown), and found that we have a bug in the similar logic for the "select notification sound" dropdown:
    const notification_sound_dropdown = $("#notification_sound");
    notification_sound_dropdown.val(user_settings.notification_sound);

    $("#enable_sounds, #enable_stream_audible_notifications").on("change", () => {
        if (
            $("#enable_stream_audible_notifications").prop("checked") ||
            $("#enable_sounds").prop("checked")
        ) {
            notification_sound_dropdown.prop("disabled", false);
            notification_sound_dropdown.parent().removeClass("control-label-disabled");
        } else {
            notification_sound_dropdown.prop("disabled", true);
            notification_sound_dropdown.parent().addClass("control-label-disabled");
        }
    });

This code ignores the stream-specific rows, and hence is buggy. If someone enables the audible notifications for a stream while the global settings have been disabled, the dropdown remains disabled.
I'm not sure how to fix this, since that would involve, after every change of checkbox state checking all the other check boxes of the stream specific rows. Any suggestions?

I have not seen the previous discussion of this, but we can have an option of setting custom period, but this should not be a blocker and can be added later also.

I don't remember discussing that aspect before, but it looks like Microsoft teams uses a similar UI for what seems like their version of this feature:

And we could easily add a couple more values to the dropdown to increase the granularity if we wanted to.

Hmm, yes checking stream-specific settings will be a problem. Maybe we can add a class ".email-notifications" to all the email checkboxes (including stream-specific ones) and then check something like $(".email_notifications:checked").length > 0 or $(".email_notifications").is("checked")> 0, not sure about performance aspects of using these though.
And we can wait for some more feedback on adding other/custom option.

We should have a custom option; you can look at the "message edit deadline" dropdowns for an implementation template to crib from.
I think we can leave the "disable dropdown" feature for follow-up work (maybe worth a CZO thread); it's not clear it'd be net helpful even if we can fix the live update issues discussed above.

This lgtm but can you also add /help/ updates covering this feature?  We can do a new brief article but @alya FYI we may want to later merge into a large "Email notification configuration" page.

@timabbott Thanks for the review! This isn't ready for another round yet. I've addressed comments on the first commit, and will do the frontend/docs changes as soon as possible.

I rebased the first commit and merged it as 17b8d5361225c92625ef951dfc263592f11d2f1d.

Since this is getting stale and essentially complete, I went ahead and did enough that I think we can merge the frontend as well.
@alya want to do a final round of review on the frontend for this (wording, etc.), opening issues for what remains to do (you can tag them as release goals) and doing a documentation PR?

Opened https://github.com/zulip/zulip/issues/19713 for one of the follow-ups.

Merged, thanks @abhijeetbodas2001!

Awesome!
User doc PR: #19714

@timabbott @alya Thanks for all your work, and apologies for having needed to do the rebasing and documentation! I got busy with assignments and mid-term exams, so could find time.
I'll try to finish off #19713 this coming weekend.

No worries, we really appreciate your work! Hope the exams went well! :)


text:
fixed browser autocomplete in Recent topics filter

Added the autocomplete = off in the Recent topics filter box
zulip/zulip#21349

Merged after rewriting the commit message, thanks @prashantpaidi!
Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

authors: prashantpaidi timabbott


text:
Button text not visible in modal

Try to send message and have not login yet, this modal window shows up.
But login button and sign-up button is not styled design in browser（safari）.
-1 -------------
This is the issue depends on "appearance" of css.
We cannot superscription some styles of "appearance" by just writing other code.
So I deleted "appearance" from this stylesheet.
-2 -------------
Moreover I found that text is underlined when I hover the button, which may be not planned.
So I added code "text-decoration:none".
【before / 1】

【before / 2】

【after】

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@Taiki-Choda Could you please squash your commits to clean up your commit history and post again to request a review? https://zulip.readthedocs.io/en/latest/contributing/version-control.html
Thanks!

@Taiki-Choda I cannot reproduce this on Windows in the Chrome browser.
You mentioned on CZO that this issue is specific to the Safari browser. I don't have access to a Mac device, so not sure if this is the correct fix.

I was not able to reproduce on the latest version of Safari (v 16.1). @Taiki-Choda can you please mention your Safari version? And you reproduce this issue always?

Hi @amanagr.
Now I'm using Safari(v 16.1) too and the bug doesn't happen.
The cause of this issue may be fixed by the update of Safari browser.

Regardless of the bug, I see both the changes as harmless (potentially beneficial), I would approve this for a merge from my end.

Understood. Thank you!

@Taiki-Choda please read https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages to improve your commit messages!

Merged as a09014f1de54bb9747960d5d2384d05565bce822, after writing a proper commit message explaining the motivation for the change and also why we don't think it's harmful. Thanks for the contribution @Taiki-Choda! And please try to write your commit messages with the level of detail in this example in the future.

authors: Taiki-Choda alya amanagr ganpa3 timabbott


text:
Profile and settings pop over menu #22802

Issue: #22802
I wrote the code to reflect the above design.
Personal Setting popover
The header also needed to be modified to reflect the user-set popover design, so I changed it based on Figma data.
Header nav

Header nav (without login)

Personal Setting popover

User information popover
Other user's profile

My profile

Dark theme view

The view should be center aligned here and notice the white background bug.

Thank you for your feedback @amanagr !
I found that the bug happens when turn off Use full width on wide screens in my personal settings.
If I turn off this, max-width:1400px is added to the main view area and the header.
Do you know what is purpose of this setting option?

Linking CZO feedback / discussion.

@Taiki-Choda do you think you'll have time to push on this one soon? Thanks!

While playing around with the PR, I got the following error:

There also seems to be something wrong with the search typeahead dropdown:

The errors are fixed.

@Taiki-Choda @Ddharmani3 Is this PR still relevant, or should it be closed in favor of more recent work?

@Taiki-Choda @Ddharmani3 Is this PR still relevant, or should it be closed in favor of more recent work?

I think this can be closed as this was split into 3 PRs #24132, @24138, and #24140 out of which 2 are already closed in favor of my recent PRs, 3rd PR is #24138 which is open, I am working on it too by rebasing #24138. I will complete work on it by the end of this week.
So, This Pr can be closed and #24138 can be closed after I open the PR.

authors: Ddharmani3 Taiki-Choda alya amanagr


text:
compose: Update icons for formatting buttons.

Fixes: #27845
Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@alya @karlstolley it looks like this reworks some of the breakpoints due to different icon sizes, so may need some extra QA.

Please pull changes from https://github.com/zulip/zulip/pull/28003

Merged, thanks @N-Shar-ma!

authors: N-Shar-ma terpimost timabbott


text:
Describe WIP PRs in the ways to contribute section

Add text encouraging early PRs and how to use [WIP]. Also fix an unrelated typo.

Automated message from Dropbox CLA bot
@feorlen, it looks like you've already signed the Dropbox CLA. Thanks!

Here's the conversation that started this
https://chat.zulip.org/#narrow/stream/documentation/topic/describing.20the.20Zulip.20PR.20workflow

Merged, thanks @feorlen!

authors: feorlen smarx timabbott


text:
Helloworldbot

Requesting a pull request for a boilerplate "Hello, World!" bot that can be used as a simple example to build more complicated bots.

Automated message from Dropbox CLA bot
@theairportexplorer, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here.

Thanks for working on this! For this PR, I think we just want the first commit (adding helloworld bot), since the others seem to be duplicates of already merged code.

Automated message from Dropbox CLA bot
@theairportexplorer, thanks for signing the CLA!

authors: derAnfaenger smarx theairportexplorer


text:
Display an error for the ZulipDesktop unsupported platform.

This displays an error at the top of the screen on page load that
will inform any user with the userAgent string "ZulipDesktop" that
they should upgrade to our newer electron app
Fixes: #6551.

That's great. Let me know when it's deployed so that I can cross test it using zulip-desktop.

It's deployed; try it out!

I don't see any alerts! I have downloaded 0.5.2 from this page - https://zulip.org/dist/apps/mac/
Added chat.zulip.org, logged in but no alert.

Can you check what navigator.userAgent is in the app's JS console?

authors: akashnimare brockwhittaker timabbott


text:
Include data of stream/private sender details in apns push notifications

To handle the notification press for iOS
(More changes required for the private group messages)

@kunall17 do we handle multiple realms? Are we getting notifications from two servers at the same time? If no, can we do it? If yes, do you make sure that the server is the same as active one? We might want to switch servers in the app if not.

Are we getting notifications from two servers at the same time?

No, we send a request to the server to remove the push token on switching account.

If yes, do you make sure that the server is the same as active one? We might want to switch servers in the app if not.

For sending notifications from multiple realms, we'll have to do these

Send server realm as well
Currently, we sign out of the account on switching, so we'll have to stop doing that. (As on tapping the notification we should switch to the notification realm account)

Yeah, that is what I thought. Let's add realm to the notification now, since we are doing the changes on the backend?
I would say, supporting multiple accounts is a high priority but not highest, so not a thing we will work on in the next month, but surely soon after that.
@timabbott what do you think about that? Supporting multiple servers more seamlessly surely is one of the more requested features?

@timabbott rebased with https://github.com/zulip/zulip/pull/6659 and having it's commit here as they are depending on each other, and will be easier to review!

Yeah, I think we should definitely design the notifications API to work well with multiple accounts, since we will want to build that soon.

@timabbott Updated PR, to send the message & message sender details in the apns payload used to properly narrow to the correct place when the notification is clicked

Oh, one other important bit: take a look at the function modernize_apns_payload. This function runs on the push notification bouncer and processes the payload before we send it up to APNs.
Studying it now, I don't think there's any change to the logic we need to make there. After I merge this PR, I might tweak the comments there, so this is at least a reminder to me to do that.

Looks good, thanks!
One small style bit, which appears a few times: when ending any kind of list of items in Python with the } or ) etc. on the next line, our style is to put a comma after the last item, just like all the other items. This helps keep things simple when adding more items, or reordering items. Would you make that change?

Sure, done :)

Thanks -- merged!

And just a bit ago I deployed master to chat.zulip.org, so this is live there.

Cool, I'll be soon having an iPhone for testing purposes, will check it out! :)

authors: borisyankov gnprice kunall17 timabbott


text:
Template in angularjs

Hello, has anyone used the template in with angularjs?
I am importing the js from the template like this so that the elements are loaded before the js:
`import { Component, OnInit } from '@angular/core';
@Component({
selector: 'app-root',
templateUrl: './app.component.html',
styleUrls: ['./app.component.css']
})
export class AppComponent implements OnInit{
title = 'test-app';
ngOnInit() {
this.loadScript('../assets/js/bootstrap.js');
this.loadScript('../assets/js/app.js');
}
public loadScript(url: string) {
const body =  document.body;
const script = document.createElement('script');
script.innerHTML = '';
script.src = url;
script.async = false;
script.defer = true;
body.appendChild(script);
}
}`
I can switch from light to dark theme correctly but when I reload the website it doesn't load the previously chosen theme.
Has anyone had a similar problem?
Thank you very much for the template, it's great!

You need to use localStorage to save your choosed theme, JavaScript does not save variables on refresh and that is working as intended.

repo: zuramai/mazer


text:
Why i can't use 3 filepond with same class together?

Why i can't use the same class of filepond in 1 page? But when i change the filepond class to another class it can load the filepond.
This is my code :

Logo Perusahaan

<input type="file" class="image-preview-filepond" id="logo_perusahaan" name="logo_perusahaan" accept="image/*" onchange="previewImage()">

Logo PDF Perusahaan

<input type="file" class="image-preview-filepond" id="logo_pdf" name="logo_pdf" accept="image/*" onchange="previewImage()">

Favicon Perusahaan

<input type="file" class="image-preview-filepond" id="favicon" name="favicon" accept="image/*" onchange="previewImage()">

You need to add this line to render the filepond in different class. The given code is just an example.
https://github.com/zuramai/mazer/blob/4e06a68074447736618c9fdde3863bac1ae1e8c1/src/assets/static/js/pages/filepond.js#L13-L20

authors: WhisperGo zuramai


text:
Nested Dropdown menu doesn't work properly in RTL

The first level appears to work fine, but below that does not.  See the test 'test/visual/dropdown-menu/basic-dropdown-menu-rtl.html'

Additionally, there is incorrect top alignment, but this PR fixes it too

@kball @gakimball Could you please review this PR #8249.
I appreciate it!

authors: abdullahsalem kball

repo: zurb/foundation-sites


text:
[ABIDE][Docs] Should include list of available patterns

I belive the abide documentation should provide a list of available patterns that are included with abide.
alpha,
alpha_numeric,
integer,
number,
card,
cvv,
email,
url,
domain,
datetime,
date,
time,
dateISO,
month_day_year,
day_month_yea,
color

Hi.
It's true, even if we can find this information in the foundation.js file :
https://github.com/zurb/foundation-sites/blob/develop/js/foundation.abide.js#L493

I was also missing this a number of times. So I just added [PR #9328] (https://github.com/zurb/foundation-sites/pull/9328).

Fixed by #9328. Thanks @karland!

authors: HediMaiza Yanchek99 karland kball


text:
added JavaScript Reference for Responsive Toggle

In order to use the Responsive Toggle you need to include the file js/foundation.responsiveToggle.js

Are you referring to cases where people use the customizer, but do not include Responsive Toggle?

I use it like so in my gulpfile.js:
gulp.task('js', function() {
    return gulp.src([
        'node_modules/jquery/dist/jquery.js',
        'node_modules/foundation-sites/js/foundation.core.js',
        'node_modules/foundation-sites/js/foundation.util.mediaQuery.js',
        'node_modules/foundation-sites/js/foundation.util.keyboard.js',
        'node_modules/foundation-sites/js/foundation.util.box.js',
        'node_modules/foundation-sites/js/foundation.util.nest.js',
        'node_modules/foundation-sites/js/foundation.util.motion.js',
        'node_modules/foundation-sites/js/foundation.dropdownMenu.js',
        'node_modules/foundation-sites/js/foundation.accordion.js',
        'node_modules/foundation-sites/js/foundation.responsiveToggle.js',
        'node_modules/slick-carousel/slick/slick.js',
        'src/js/main.js',
      ])
      .pipe(plugins.babel())
      .pipe(plugins.concat('script.min.js'))
      .pipe(gulp.dest('js/'));
});

Given this page in the docs also talks about the responsive toggle, it makes sense to link in the jsdoc stuff, so I think this is good to go.

authors: alfredbez kball rafibomb


text:
add boolean var to enable button radius on whole group

As discussed in #9031, and requested by @kball, this PR adds a setting to enable button group radius on the whole group. Now button groups work for both use cases. For backwards compatibility, it defaults to the way button groups are styled in v6.2.

@abdullahsalem Could you please check my work here? 😍

It's a very helpful option. I'll look at the implementation asap. Thanks @andycochran.

Scanning the code: looks good! Testing for merge

Looks solid! Adding an extra note in the variable comment.

Thanks @rafibomb and @andycochran

authors: abdullahsalem andycochran rafibomb


text:
Considered using Parsoid HTML

Have you considered using Parsoid HTML to scrape information out of? It has the advantage of most wikitext properties are there as annotated RDFa, so you get the best of both wikitext and HTML.
Example: https://en.wikipedia.org/api/rest_v1/page/html/Taylor_Swift
Spec docs: https://www.mediawiki.org/wiki/Specs/HTML/2.2.0
API docs: https://www.mediawiki.org/wiki/Parsoid/API

@legoktm Wow, that's a super-useful suggestion, thanks! Definitely will investigate (and most probably use) the possibility :heart:

authors: legoktm zverok


text:
[bug] Cache corruption after power loss

Version
Checklist:

[x] I am not using HomeAssistant. Or: a developer has told me to come here.
[ ] I have checked the troubleshooting section and my problem is not described there.
[ ] I have read the changelog problem was not mentioned there.

Build/Run method

[x] Docker
[ ] PKG
[ ] Snap package
[ ] Manually built (git clone - npm install - npm run build )

zwavejs2mqtt: 3.5.0
zwave-js: 7.2.4
Describe the bug
After power loss all devices are not working properly, including zwave controller on usb, displaying Unknown manufacturer/Unknown product. The controller is showing after delete and pull docker image (it can be the same version) - devices has to be intervieved again (where went option to interview all devices at once, when I have to interviev 20+ devices it can make me crazy?).
To Reproduce
Steps to reproduce the behavior:
Pull the power plug from RPi or Server with zwavejs2mqtt and power it again (like enviroment power loss)
Expected behavior
Devices loaded correctly OR option to automatically interview them when all/part off them become Unknown
nodes_dump_28.04.2021.json.zip
zwavejs2mqtt_28.04.2021.zip
zwavejs_28.04.2021.zip

I can confirm I experienced the same issue.  All devices reverted to "Unknown manufacturer 0xXXXX" after a power loss.  Unfortunately I began the re-interview process before I found this thread so don't have the cache files in the state needed.  A "re-interview all" option would be a huge help in this scenario.

They should be in the same folder as the logfiles. And to avoid any confusion: I need to see the status of the cache files after power loss but before zwave-js is started again.

so I have to disable docker autostart to achieve this... I had enviroment power loss few minutes ago and have the issue again.

Had these issues as well as powering down the house to do some electrical work.

Any chance you could provide the files I requested above?

Any chance you could provide the files I requested above?

Sorry I will prepare this in one, two days.

I have been hit by this same issue. I have 54 devices, so a Re-interview all button would be great.

I have been hit by this same issue. I have 54 devices, so a Re-interview all button would be great.

You could use a driver function
for (const [, node] of driver.controller.nodes) {
      await node.refreshInfo()
}

I have been hit by this same issue

Any chance you can provide the files I requested?

cf48071b.zip

@AlCalzone I hope they don't contain sensitive information.
Unfortunately, I have already tried to re-interview the nodes, however, most of the battery ones have not already replied, so I still have lots of unknown in this.

I have seen corrupt cache files in other software caused by incorrect shutdowns, typically during abrupt power cuts.
Would it be too much to use an ACID-kind of cache storage system for this? I don't know if such systems exist for JavaScript/TypeScript.
Another solution could be to use a distributed network cache, like for example Redis with on-disk persistence, which would be power-cut crash-resistant.

Thanks, I've downloaded and deleted the file to be sure. The main problem here is to figure out which part of the cache breaks and how. I haven't been able to do this yet without seeing the files in their "broken" state.
We currently have two different systems in place, one is a JSON file that gets written as a whole, one is a mostly appendonly JSONL storage (or rather two), which takes quite a few ideas from redis. Both could be the reason, although I hope it is not the JSONL part.

@AlCalzone How does JSONL handels writes on disk?

It keeps a file descriptor open, append linewise to this file immediately (or throttled based on the configuration). Additions or updates are written with a value, deletions without a value (just the key). When certain conditions are met, a compressed copy is written, the original gets closed, the compressed copy gets renamed to the original file (overwriting it) and the new original gets opened. Anything that should have been written in the meantime gets appended thereafter.

It seems like https://github.com/louischatriot/nedb

IMO the bug is in the JSONL, what could happen if the power loss happens while it is compressing the json file?

Another way to ensure writes are complete is to just use the atomic-rename-trick.

Create new temp-file
Write complete new JSONL structure to temp-file
fsync() (if that's available in JavaScript)
rename temp-file to the target filename (atomic operation)

what could happen if the power loss happens while it is compressing the json file?

Then the original file does not get overwritten.

Another way to ensure writes are complete is to just use the atomic-rename-trick.

That's what I do: https://github.com/AlCalzone/jsonl-db/blob/8c330850ab5be88864f69e91da73e4bd3c62fb58/src/lib/db.ts#L571-L576

In that case, I'm not convinced that incomplete file writes are the cause of the issue.

I just verified with someone who has this problem on every restart. The cache files are virtually identical before, after shutdown and after the startup. The problem is the communication with the stick that gets tripped up to the point it does not respond any more.
This seems to be caused by zwavejs2mqtt querying the neighbors for all nodes on startup (that one is on me) to draw the network map.

Submitted a fix for this

authors: AlCalzone beerygaz kayintveen larstobi ldymek robertsLando

repo: zwave-js/node-zwave-js


text:
Add dprint to devcontainer

          I tried this on Arm mac and still needs the prettier arm version. There is a [PR](https://github.com/dprint/dprint-plugin-prettier/pull/75) to add it.

We might want to add dprint install to the devcontainer for use with the vscode extensoin drpint.

Extensions install steps: Install dprint's CLI

I don't think it comes installed. or it's not on the path.
curl -fsSL https://dprint.dev/install.sh | sh
and need to add some lines to the .zshrc file:
export DPRINT_INSTALL="/home/node/.dprint"
export PATH="$DPRINT_INSTALL/bin:$PATH"

Edit: we might be able to add this to vscode settings:
	"dprint.path":"./node_modules/dprint/dprint",
Originally posted by @zackbcom in https://github.com/zwave-js/node-zwave-js/issues/6656#issuecomment-1936918127

@zackbcom can you confirm whether this is fixed now? I just tried the devcontainer and dprint seems to be available immediately.


text:
你好 我是专门研究语音驱动单样本说话人脸视频生成技术的 我对你们的工作有一些建议

你们的工作很有用，很好的避免了大家各自测试的麻烦，我对你们的工作有一点点建议， 你们的测试集中应当补充带有真实参考视频的一些测试视频，该任务很多的评估指标都需要真实的图像作为参考作为评估指标，尽量选择带有一些头部运动的真实视频，选取第一帧作为参考帧来生成整个视频

Thank you for your valuable advice! We will further improve our work to provide greater convenience to researchers in the speech-driven field.


text:
小さな手のひら

小さな手のひら

歌曲信息

专辑：CLANNAD Original SoundTrack
作词：麻枝准
作曲：麻枝准
编曲：户越まごめ
歌手：Riya

谱
小小的手心
( )为低一个八度 [ ]为高一个八度 #升高半音
前奏：214 45 56 41 214 45 564
214 45 56 41 214 454
214 45 56 432 3434

134 145 56#66 545 434
134 145 56#66 545 #664
#6 456 #6 456
542344114 4#66545 13454

间奏： (5)145 542 456[1]56 4145 54254[1]6
(5)145 542 456[1]56 432 3 4 3 4

(6)256 6 5 3 567[2]67 5256 6 5365[2]7
(6)256 6 5 3 567[2]67 5 #4 3 #4 5#45
(6)256 6 5 3 567[2]67 5256 6 5365[2]7
(6)256 6 5 3 567[2]67 5 #4 3 #4 5#45
55 #6 6 5 4 5
55 #6 [1] [2] [2] [1] [#2] [2]
55 #6 6 5 4 5
5 [1] [2] [1] [1] [#2] [2] [1] [1] #6 [1]

(6)256 6 5 3 567[2]67 5256 6 5365[2]7
(6)256 6 5 3 567[2]67 5 #4 3 #4 5#45
(6)256 6 5 3 567[2]67 5256 6 5365[2]7
(6)256 6 5 3 567[2]67 5 #4 3 #4 5#45
尾
(6)256 6 5 3 567[2]67 5256 6 5365[2]7
(6)256 6 5 3 567[2]67 5 #4 3 #4 5#45

记谱：FREEDOM54

CLANNAD


text:
[SC-755] Natspecs added

Codecov Report
Patch and project coverage have no change.

Comparison is base (4d4c0f6) 100.00% compared to head (0532a56) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines           99        99
  Branches        21        21
=========================================
  Hits            99        99

Impacted Files
Coverage Δ

contracts/ERC20Pods.sol
100.00% <ø> (ø)

contracts/Pod.sol
100.00% <ø> (ø)

contracts/libs/ReentrancyGuard.sol
100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

authors: codecov-commenter galekseev


text:
Create Contributing.md file and add proper guidelines.

I want to work on this. Please assign me.

@Pragya2056 , Awesome !!
Go ahead.

#15
The issue is looked in the above PR

You can close the issue now.