text:
Helm chart versioning

We'll need a proper helm chart version going forward to support APIClarity upgrades: https://github.com/openclarity/apiclarity/blob/master/charts/apiclarity/Chart.yaml#L5

@amccormi you do get a proper helm chart version on each release - it is being replaced automatically here
example https://github.com/openclarity/apiclarity/releases/tag/apiclarity-v0.13.0-helm

Ok, but for people who deploy build/deploy from the source code, I still think putting the latest chart version in would be useful

People who deploy from source can change the chart version locally. We prefer the automatically approach so we should not need to change the version manually before tagging the code.

authors: FrimIdan amccormi

repo: openclarity/apiclarity


text:
Demo version

This pull request provides the minimal demo version of this library. Still lots to do
TODO:

[x] CI testing fixes
[x] Fill in basic project metadata i.e. setup.py and README
#7

@all-contributors
please add @dfulu  for code.
please add @AUdaltsova  for code.
please add @Sukh-P   for code.
please add @peterdudfield    for code.

@all-contributors
please add @AUdaltsova for code.

@all-contributors please add @Sukh-P for code.

@all-contributors please add @peterdudfield  for code.

source: gharchive/pull-request

authors: dfulu peterdudfield

repo: openclimatefix/ocf-data-sampler

license: MIT

license_type: permissive

license_source: github-api


text:
GraphQL query to fetch collective's features

Motivations

NavBar: We recently improved the sections displayed for each collective. But the current conditions are not perfect: for example we want to keep showing the Contribute section for collectives without hosts if they have an event or subcollectives. But we don't want to fetch tons of data in all pages that have a CollectiveNavbar to achieve that. How convenient would it be if we could directly fetch these info about which feature to display without having to deal with all this complex logic and additional data in the frontend?

Optional features (Transferwise, PayPal payout...etc): in multiple pages we need a way to easily check if a feature is supported. For example in the create expense flow, we need to know if the host supports Transferwise as a payout option. Having a consistent way to check that could improve clarity.

Best solution for this problem
API
On CollectiveInterface, create a new features field that returns a CollectiveFeatures object.
Each key is a feature name, and the value is an enum with the following values:
enum FEATURE_STATUS {
  /** 'The feature is enabled and is actively used */
  ACTIVE = 'ACTIVE',
  /** The feature is enabled, but there is no data for it */
  AVAILABLE = 'AVAILABLE',
  /** The feature is disabled, but can be enabled by an admin */
  DISABLED = 'DISABLED',
  /** The feature is disabled and cannot be activated for this account */
  UNSUPPORTED = 'UNSUPPORTED',
}

The returned object would look like this:
{
  "collective": {
    "features": {
      "CONTACT": "ENABLED",
      "RECEIVE_EXPENSES": "ENABLED",
      "CONTRIBUTE": "ENABLED",
      "CONTRIBUTE_PAYPAL": "ENABLED",
      "UPDATES": "DISABLED",
      "SHOW_TRANSACTIONS": "DISABLED"
    }
  }
}

In the example above:

UPDATES would be marked as DISABLED if there's no update.
SHOW_TRANSACTIONS would be marked as DISABLED if there's no transactions.

Most of the code should be inspired by what's in navbar today, with the following adjustments:

Still enable Contribute if the collective has an event or a subcollective
Don't enable Transactions for users/orgs with no transaction for non-admins

Also see existing features enum, we should use it as a basis to defined a corresponding GraphQL enum type.
Frontend
Create a reusable CollectiveNavbarFeatures fragment that fetches all the fields from features required to display the collective navbar properly and use it where necessary.

API features endpoint has been merged 🎉👯♂

source: gharchive/issue

authors: Betree sbinlondon

repo: opencollective/opencollective


text:
Can the collective cards in the 'Contributions' section appear as they do in search queries?

As a host admin trying to amplify our groups, on our fiscal host profile page, you can view our hosted collectives under the 'Contributions' section. These collective cards don't provide much detail:

Is is possible to have them appear the same as they do in the Search queries (including tags & budget specifically)

going to put this into #5680 /cc @opencollective/design

related: https://github.com/opencollective/opencollective/issues/5570

authors: BenJam kaylarep


text:
RT_7.8 changes and deviation

Made below changes to the test :

Change AS# for ATE Port 2 , since routes will not be advertised with same AS on both sides to avoid loop.
SetSendCommunity under deviation SkipBgpSendCommunityType
Under deviation BGPConditionsMatchCommunitySetUnsupported for cisco, reconfigured community-set
Added prefix length with the subnet for the communityIndex verification func

Pull Request Functional Test Report for #3575 / 4d1bc8eb22cc47123add342fbc71b1343263ace3
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Cisco 8000E

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Cisco XRd

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Juniper ncPTX

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Nokia SR Linux

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Openconfig Lemming

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Cisco 8808

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Juniper PTX10008

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Nokia 7250 IXR-10e

RT-7.8: BGP Policy Match Standard Community and Add Community Import/Export Policy

Help

Pull Request Test Coverage Report for Build 11788746331
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.268%

Totals

Change from base Build 11788192817:
0.0%

Covered Lines:
1983

Relevant Lines:
3588

💛  - Coveralls

authors: OpenConfigBot arvbaska1 coveralls

repo: openconfig/featureprofiles

license_source: bigquery


text:
Empty OCI_CROSSMOUNT_NAMESPACE may result in false positives

Underlying code, if given an repository name of empty string (""), will use the default namespace on the client (i.e. OCI_NAMESPACE).
Should either a.) crash suite if missing variable, or b.) skip cross-repo mount test if missing variable

This var is also missing from "Configuration" section in the HTML report

repo: opencontainers/distribution-spec


text:
layers: xattr handling is not well-specified

So, while implementing xattr support in umoci (cyphar/umoci#54) I discovered that it's not actually clear how to handle unpacking of attributes. In particular, it's not very clear what we should be doing when an extended attribute is defined for a file that has had its metadata modified.
Imagine you have a file foo which had the user.test xattr set. In the next layer, this xattr is missing but there is some other xattrs set. What should an extractor do:

Should we always ensure that the xattrs of a file match exactly the same xattrs of the layer (meaning that user.test will be removed).

Should we leave existing xattrs alone, so user.test will not be removed?

Should we only remove xattrs that were added explicitly by the extractor from a previous layer (so user.test will be removed but something like security.selinux that is not included in layers will not)?

Each of these solutions has a problem that we need to address:

This will cause issues with stuff like security.selinux which is automatically set on all created files based on your current context, and you cannot remove them.

This will mean that you cannot effectively delete an xattr, because there's no way of specifying an xattr whiteout.

This sounds like the most sane method. The problem is that it's a bit of a burden on implementors to have to keep track of what xattrs they've set on every file in a filesystem. In addition, how do you handle the case where a file already had some xattr set (which you didn't set) and then you're told to modify it. Should you remove it if it disappears in a future layer or not?

/cc @vbatts

Oh, in addition, we need to specify whether or not all xattrs should be included in a layer changeset. IMO we shouldn't be including security.selinux -- but some other xattrs might exist that cause us even more issues. My current solution (cyphar/umoci#54) is to just blacklist security.selinux pending further issues.

On Fri, Dec 16, 2016 at 10:52:04PM -0800, Aleksa Sarai wrote:

Should we always ensure that the xattrs of a file match exactly
the same xattrs of the layer (meaning that user.test will be
removed).

This is what the current spec calls for 1.  Here's GNU tar doing
just that:
$ tar --version
tar (GNU tar) 1.28
…
$ mkdir a
$ echo foo >a/test
$ setfattr -n user.foo -v foo a/test
$ mkdir b
$ echo bar >b/test
$ setfattr -n user.bar -v bar b/test
$ tar -cf test.tar -C b --xattrs .
$ tar -tf test.tar --xattrs -vv
drwxr-xr-x  wking/wking       0 2016-12-17 07:25 ./
-rw-r--r--* wking/wking       4 2016-12-17 07:25 ./test
x: 3 user.bar
$ strace -o /tmp/trace tar -xf test.tar -C a --xattrs
$ grep ./test /tmp/trace
mknodat(4, "./test", 0644)              = -1 EEXIST (File exists)
unlinkat(4, "./test", 0)                = 0
mknodat(4, "./test", 0644)              = 0
setxattr("/proc/self/fd/4/./test", "user.bar", "bar", 3, 0) = 0
openat(4, "./test", O_WRONLY|O_CREAT|O_NOCTTY|O_NONBLOCK|O_CLOEXEC, 0644) = 5
$ getfattr -d a/test
file: a/test
user.bar="bar"
So the layer author has no way to pass through pre-existing xattrs,
but if you know what xattrs you want, you can always add a trailing
layer to restore anything that you don't want clobbered.

This will cause issues with stuff like security.selinux which
is automatically set on all created files based on your current
context, and you cannot remove them.

For what it's worth (probably not much with such a fuzzy connection to
our spec), GNU tar distinguishes between selinux, ACLs, and other
xattrs 2.  And there seem to be plans to eventually split out
security.capability as well 3.

@wking

Should we always ensure that the xattrs of a file match exactly
the same xattrs of the layer (meaning that user.test will be
removed).
This is what the current spec calls for [1].  Here's GNU tar doing
just that:

No it isn't. Because doing an unlink and then adding xattrs will still mean you have a security.selinux xattr set on the file -- that's how SELinux works. But "match exactly" would require removing security.selinux if it's not set in the tar archive.
And it still doesn't help with layer generation -- how do we know if we should include certain xattrs.

For what it's worth (probably not much with such a fuzzy connection to
our spec), GNU tar distinguishes between selinux, ACLs, and other
xattrs [2].  And there seem to be plans to eventually split out
security.capability as well [3].

You're right, it doesn't help to point to the implementation of GNU tar in order to answer a simple question of "what should we do with xattrs".

On Sat, Dec 17, 2016 at 07:52:48AM -0800, Aleksa Sarai wrote:

Should we always ensure that the xattrs of a file match exactly
the same xattrs of the layer (meaning that user.test will be
removed).
This is what the current spec calls for [1].  Here's GNU tar doing
just that:

No it isn't. Because doing an unlink and then adding xattrs will
still mean you have a security.selinux xattr set on the file --
that's how SELinux works. But "match exactly" would require
removing security.selinux if it's not set in the tar archive.

Fair.  The current spec calls for unlinking any pre-existing file,
that's what GNU tar does, and that's what we should do.  If you get
SELinux settings by doing that, you don't have to clear them.  I don't
think we need additional wording to cover the xattrs implications of
the already-specified unlink-and-replace wording.

And it still doesn't help with layer generation -- how do we know if
we should include certain xattrs.

Add a flag to your layer generator (like GNU tar does with --xattrs
and friends)?  I don't think there's a good way to make this call in
general.

For what it's worth (probably not much with such a fuzzy
connection to our spec), GNU tar distinguishes between selinux,
ACLs, and other xattrs [2].  And there seem to be plans to
eventually split out security.capability as well [3].

You're right, it doesn't help to point to the implementation of GNU
tar in order to answer a simple question of "what should we do with
xattrs".

It doesn't help clarify the current spec's stance, but it can inform
future spec changes.  They presumably had reasons for breaking down
xattrs into subcategories, and maybe those reasons apply to us too.

Add a flag to your layer generator (like GNU tar does with --xattrs
and friends)?  I don't think there's a good way to make this call in
general.

The spec should at least provide some guidance. For example:

user.* MUST be included.
security.capability SHOULD be included.
security.selinux SHOULD NOT be included.

Those are the three that come to mind immediately. 2 is because otherwise ping will be broken everywhere except in Ubuntu (where ping is setuid).

This sounds like the most sane method.

agreed

The problem is that it's a bit of a burden on implementors to have to keep track of what xattrs they've set on every file in a filesystem.

I don't understand why they need to track this so specifically - can't they just naively apply the xattrs at every layer? (e.g using the remove/recreate method). Tying into the next point - are there "implicit" sets that would happen on some layers but not on others?

In addition, how do you handle the case where a file already had some xattr set (which you didn't set)

Who else set it? Isn't this a file tree that we (the implementer) are rendering from scratch? Do you have any examples of cases other than the selinux one?

The problem is that it's a bit of a burden on implementors to have to keep track of what xattrs they've set on every file in a filesystem.
I don't understand why they need to track this so specifically - can't they just naively apply the xattrs at every layer? (e.g using the remove/recreate method). Tying into the next point - are there "implicit" sets that would happen on some layers but not on others?

So do the removal and re-creation for every file in an image, even if the content hasn't changed? I mean ... that could work fine (bit inefficient, but what can you do).0 The problem is not extraction but with generation -- how do I know which xattrs should I include in the next layer? Which ones did users set and which ones were implicitly set by the system? The way umoci solves this problem is by generating a manifest of the rootfs after extraction -- and then you can be sure that any changes were made by the user.

Who else set it? Isn't this a file tree that we (the implementer) are rendering from scratch? Do you have any examples of cases other than the selinux one?

Some of the trusted.* extended attributes in principle could be set by some super-root user, and if you run the tooling as root then you might see xattrs that were not part of the image. I'm not really sure.

So do the removal and re-creation for every file in an image, even if the content hasn't changed?

well, isn't the only way to represent an xattr change between layers by having a new copy of the file in the upper layer anyway?

The problem is not extraction but with generation -- how do I know which xattrs should I include in the next layer? Which ones did users set and which ones were implicitly set by the system? The way umoci solves this problem is by generating a manifest of the rootfs after extraction -- and then you can be sure that any changes were made by the user.

Ah, now I get you. Yeah, I don't have a great answer (or at least one better than umoci's).

well, isn't the only way to represent an xattr change between layers by having a new copy of the file in the upper layer anyway?

Sure, but implementations could optimise disk access by storing the checksums and then computing the checksum of tar as they read the data. If the checksum is the same, there's no need to update it. It's a small optimisation, but I'm just wondering if there's a way to define changes without cutting out the possibility for such optimisations.

omg... I think by having this discussion we're already wasting more than this optimisation would ever save :-)

@jonboulle Micro optimisations are where it's at. :smile_cat: In any case, ultimately I think this should up to the runtime since the unpacking document already has the unlink+create wording. So I'll close this.

authors: cyphar jonboulle wking

repo: opencontainers/image-spec


text:
mount and umount

When mounting, the format of mountpoint should be: [hostname:mountpoint], but when using curveadm mount, the format of mountpoint becomes [a string of numbers: /usr/local/curvefs/client/mnt]
Although unmounting with umount is successful, the mount point is unavailable and an error output appears.

Although it shows that umount is successfully uninstalled, the mount point is still inaccessible, and the error output is as follows:

At this time, deleting fs will fail, mds log shows fs_busy, you need to use the tool umount, you can delete successfully at this time.

The bucket name in config file isn't exists on s3, and the docker image isn't published by curve.
So this issue is invalid.

still work

The umount command will execute the below two operations:

stop fuse process
remove the container which fuse occupied

So as you said, there is no exception handling.
On the other hand, i think we should use fusemount to umount filesystem instead of stop fuse process, welcome to submit a PR to solve this problem :)

closing it

authors: Cyber-SiKu Wine93 aspirer

repo: opencurve/curveadm


text:
ImportError in django test (auto annotation)

When i enable openvino (OPENVINO_TOOLKIT: "yes") for auto annotation and run manage.py test in cvat docker shell
fails with error below:
 File "/home/django/cvat/apps/reid/urls.py", line 6, in <module>
    from . import views
  File "/home/django/cvat/apps/reid/views.py", line 10, in <module>
    from cvat.apps.reid.reid import ReID
  File "/home/django/cvat/apps/reid/reid.py", line 7, in <module>
    import cv2
ImportError: No module named 'cv2'

I disable openvino (OPENVINO_TOOLKIT: "no") and It work well.
Thanks in advance

@KiteYeh
Have you installed OpenVINO with OpenCV?

@KiteYeh
Have you installed OpenVINO with OpenCV?
hi bsekachev,
I referenced document to enable openVINO:

Build docker image
# From project root directory
docker-compose -f docker-compose.yml -f components/openvino/docker-compose.openvino.yml build

Run docker container
# From project root directory
docker-compose -f docker-compose.yml -f components/openvino/docker-compose.openvino.yml up -d

I couldn't sure if openVINO and openCV are installed or not after build openVINO image, Did I missed any step for enabling auto annotation?
Thanks in advance

@KiteYeh
Could you please send us the whole sequence of steps you do to reproduce the issue?

@KiteYeh
I built container with OpenVINO support.
Went to its bash, install all dependencies pip3 install -r cvat/requirements/testing.py
And finally I was be able to run testing: python3 manage.py test cvat/apps/engine/ --settings=cvat.settings.testing
Everything is alright.

@bsekachev
thanks for your reply,
The cvat codebase pull from master branch not developer,
It set DJANGO_CONFIGURATION: "production" in docker-compose yml file so that docker only installed production requirement.
the sequence of steps:

enable openVINO and run the docker container:
Went to its bash
run django test: python3 manage.py test

fails with error below:
 File "/home/django/cvat/apps/reid/urls.py", line 6, in <module>
    from . import views
  File "/home/django/cvat/apps/reid/views.py", line 10, in <module>
    from cvat.apps.reid.reid import ReID
  File "/home/django/cvat/apps/reid/reid.py", line 7, in <module>
    import cv2
ImportError: No module named 'cv2'

is there any mistake in test steps?

@KiteYeh
Master branch has been updated a long time ago.
So, first of all I would recommend you to use newer version of CVAT.
In the middle of September we are going to make a release if you don't want to use code from develop branch.
Also short question. When you go to container's bash, do you get a message "[setupvars.sh] OpenVINO environment initialized"?
And another short question. What OpenVINO version do you use?

@bsekachev
Yes, I got a message "[setupvars.sh] OpenVINO environment initialized"
and I use OpenVINO 2019R2.
the auto annotation work well, but python3 manage.py test has failed.
If no any suggestion, I will upgrade too after you release the new version and test again.
Thanks for your reply.

@KiteYeh
I use OpenVINO 2019R1, maybe it's a reason. But I am not sure. Will check it later.

@KiteYeh
I use OpenVINO 2019R1, maybe it's a reason. But I am not sure. Will check it later.

@bsekachev
Has the new version of master branch been released?
Do you try the OpenVINO 2019R1 and is there any feedback on the test result?
thanks for your reply

@KiteYeh
I use OpenVINO 2019R1, maybe it's a reason. But I am not sure. Will check it later.

@bsekachev
It work well on master branch with released 0.5.0 version.
Thanks for your reply

@KiteYeh
Great news.
So, has the issue been resolved?

@KiteYeh
Great news.
So, has the issue been resolved?

Thanks for your reply,
the sequence of steps:

Went to docker bash
run django test: python3 manage.py test

Another fail with error below
===============================================================
ERROR: utils.voc.tests.test_process_cvat_xml (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: utils.voc.tests.test_process_cvat_xml
Traceback (most recent call last):
  File "/usr/lib/python3.5/unittest/loader.py", line 428, in _find_test_path
    module = self._get_module_from_name(name)
  File "/usr/lib/python3.5/unittest/loader.py", line 369, in _get_module_from_name
    __import__(name)
  File "/home/django/utils/voc/tests/test_process_cvat_xml.py", line 5, in <module>
    from utils.voc.converter import process_cvat_xml
  File "/home/django/utils/voc/converter.py", line 16, in <module>
    import glog as log
ImportError: No module named 'glog'
----------------------------------------------------------------------

could you help to check this issue?
Thanks in advance

@bsekachev
Thanks for your reply, the issue could be closed.

authors: KiteYeh bsekachev

repo: opencv/cvat


text:
Bounding box coordinates not from rectangle but from skeleton

Actions before raising this issue

[X] I searched the existing issues and did not find anything similar, I am raising this issue because this one is closed: https://github.com/opencv/cvat/issues/5904
[X] I read/searched the docs

Steps to Reproduce
I tried to use the functionality recently and think that this issue is happening again. I am using the tool present on the web interface https://app.cvat.ai/
Below image contains both the bbox that I selected myself and the one through the skeleton with the keypoints.
(https://github.com/opencv/cvat/assets/91839547/fa201786-81ce-4fc3-90d7-9f1709381d1e)

I am exporting to the COCO Keypoints 1.0 format and as can be seen from the below image, the bbox co-ordinates are clearly not from the rectangle that I selected but from the skeleton.
(https://github.com/opencv/cvat/assets/91839547/13f544d8-8194-4b2d-bcf6-ca00e3c24f61)

The web version shows me the below version.
Server version: 2.10.0 Core version: 14.0.3 Canvas version: 2.19.1 UI version: 1.61.1
Expected Behavior
The x,y coordinates returned by the json file should be for the bbox and not for the skeleton
Possible Solution
No response
Context
No response
Environment
No response

You need to group bounding box and skeleton together if they relate to the same object

authors: bsekachev lillian-miles


text:
README.md error?

Expected behaviour
README.md instructions for building old releases (or other than current) don't seem to work
According to the README.md, to build using an older version of opencv or opencv_contrib one should
perform a git checkout of the older release from within the opencv/opencv_contrib sub directories.  When
I did that, checking out version 4.5.5. I issued a git status and I'm indeed at that release in both subdirectories.
Actual behaviour
When I build the wheel with pip wheel . --verbose as directed in the README.me, it actually builds the 4.8 version instead.
Steps to reproduce
cd opencv
git checkout dad26339a975b49cfb6c7dbe4bd5276c9dcb36e2
git status
HEAD detached at dad26339a9
nothing to commit, working tree clean
cd opencv_contrib
git git rev-list -n 1 4.5.5
fatal: ambiguous argument '4.5.5': unknown revision or path not in the working tree.
git branch --all

4.x
remotes/origin/3.4
remotes/origin/33
remotes/origin/4.x
remotes/origin/5.x
remotes/origin/HEAD -> origin/4.x
remotes/origin/feat/aarch64
remotes/origin/feat/manylinux2014
remotes/origin/feat/python39
remotes/origin/feat/qt5
remotes/origin/feat/sdist
remotes/origin/gs/test-github-actions
remotes/origin/gs/update-3.4
remotes/origin/gs/update-opencv-3.4-license
remotes/origin/master

example code
operating system
architecture (e.g. x86)
opencv-python version

So, I presume opencv_contrib 4.x is sufficient and correct because there doen't appear to be a tag
for 4.5.5
I notice that at the beginning of the build process, a git submobule update --init --recursive <cmake_source_dir>
(the directory I presume is the opencv submodule subdirectory).  It appears that after that command is issued a
"git checkout" results in the following:
Submodule path 'opencv': checked out 'f9a59f2592993d3dcc080e495f4f5e02dd8ec7ef'
indicating that my checkout of 4.5.5 has been overridden with the 4.8 version.
I see no instructions in the README.md indicating that I forgot to do something.  So, either the 4.8 version
is somehow "baked" into the setup/config process somewhere or the git submodule update... command is the culprit
but there needs to be some way of overriding that behavior; otherwise one can't build from an older source.  I have verified
that the git submodule update --init --recursive opencv command will indeed set the opencv HEAD back to version 4.8.
There needs to be either more clarity in the instructions or the process needs to be changed to allow building from older sources.
Issue submission checklist

[ x ] This is not a generic OpenCV usage question (looking for help for coding, other usage questions, homework etc.)

[x ] I have read the README of this repository and understand that this repository provides only an automated build toolchain for OpenCV Python packages (there is no actual OpenCV code here)

[x ] The issue is related to the build scripts in this repository, to the pre-built binaries or is a feature request (such as "please enable this additional dependency")

[x ] I'm using the latest version of opencv-python

Yes, worked the last time I used opencv-python in this way, about a year ago. It looks like this was introduced with commit 615f3dff836d820398105b82b6ada39d0155cbdc. As a workaround, in setup.py, I commented out the whole if os.path.exists(".git"): block and everything worked as expected to build an older OpenCV version.

authors: bjmcculloch johncblacker

repo: opencv/opencv-python


text:
Fix CKAN Adapter data pulling

CKANRestClient.get_datasets() method: some sites  doesn’t have query parameter include_private on /api/action/package_search API endpoint, so we need logic to remove it in case of failure. Also we are getting not all datasets as of rows argument restriction. We are getting only 10, maximum is 1000, so custom pagination implementation is needed.
CKANRestClient.get_resource_fields() method: CKAN API endpoint /api/action/datastore_info is available only via extension. Assumption: in case site does not have the extension we were getting 400 Bad Request and adapter logic parsed it into str object, so is_response_successful() was crushing during resp.get("success") as response was type = str. Logic should be fixed.
Adapter config was built with an assumption that CKAN API would be available after the host name, hence there can be a custom endpoint in between. In this case we have no possibility to pull the data (www.open_website.com/api/action/package_search - handled, www.open_website.com/additional/endpoint/api/action/package_search - not handled). We need additional config parameter for giving a proper endpoint route to CKAN API.
Some resources pulled from CKAN can not have resource.name. So we need some logic for this cases. If it has resource.name - than data entity will have it as a name, if not we construct it like "CKAN_{organization_name}_{resource.id}" for minimal human-readability.
With big data pulling via adapter this error: #20  appeared.

closed with #21

repo: opendatadiscovery/odd-collectors


text:
Allow to configure storage size

Closes #368.
FYI @henrjk I believe you had to make this change manually, right?
Tasks:

[x] Updated design documents in docs/design directory or not applicable
[x] Updated user-facing documentation in docs directory or not applicable
[x] Ran tests (e.g. make test) or not applicable
[x] Updated changelog or not applicable

Test failure should be unrelated. The E2E test is flaky, it sometimes times out :(

Yes indeed I had this done manually while using v0.1.1.
During upgrade to v0.2.0  the helm rollout failed because luckily helm install will not decrease pvc size.
So this should now be better for sure.

authors: henrjk michaelsauter

repo: opendevstack/ods-pipeline


text:
gym_anytrading : could not broadcast input array from shape (62,) into shape (20,3)  Please help!!

source code:
import pandas as pd
df = pd.read_csv('datasets/STOCKS_GOOGL.csv', parse_dates=True, index_col='Date')
from easydict import EasyDict
from dizoo.gym_anytrading.envs import StocksEnv
pq=EasyDict({"env_id": 'stocks-v0', "eps_length": 300, "train_range": None, "test_range": None,
"window_size": 20,"df": df})
env = StocksEnv(pq)
from stable_baselines3 import PPO
model = PPO('MlpPolicy', env, verbose=1)
model.learn(total_timesteps=1000)
Run Error
Traceback (most recent call last):
File "C:\Program Files\JetBrains\PyCharm Community Edition 2024.1\plugins\python-ce\helpers\pydev\pydevd.py", line 1535, in _exec
pydev_imports.execfile(file, globals, locals)  # execute the script
File "C:\Program Files\JetBrains\PyCharm Community Edition 2024.1\plugins\python-ce\helpers\pydev_pydev_imps_pydev_execfile.py", line 18, in execfile
exec(compile(contents+"\n", file, 'exec'), glob, loc)
File "D:\per\AI\chinaA\dingenvtest.py", line 17, in
model.learn(total_timesteps=1000)
File "C:\ProgramData\miniconda3\envs\mypy39\lib\site-packages\stable_baselines3\ppo\ppo.py", line 315, in learn
return super().learn(
File "C:\ProgramData\miniconda3\envs\mypy39\lib\site-packages\stable_baselines3\common\on_policy_algorithm.py", line 287, in learn
total_timesteps, callback = self._setup_learn(
File "C:\ProgramData\miniconda3\envs\mypy39\lib\site-packages\stable_baselines3\common\base_class.py", line 423, in _setup_learn
self._last_obs = self.env.reset()  # type: ignore[assignment]
File "C:\ProgramData\miniconda3\envs\mypy39\lib\site-packages\stable_baselines3\common\vec_env\dummy_vec_env.py", line 78, in reset
self._save_obs(env_idx, obs)
File "C:\ProgramData\miniconda3\envs\mypy39\lib\site-packages\stable_baselines3\common\vec_env\dummy_vec_env.py", line 108, in _save_obs
self.buf_obs[key][env_idx] = obs
ValueError: could not broadcast input array from shape (62,) into shape (20,3)
Off topic suggestions
gym_anytrading, Please add this tutorial!!!

Have you modified the dizoo.gym_anytrading.envs.StocksEnv? The 'pq' needs to pass the parameter 'stocks_data_filename'='STOCKS_GOOGL' instead of "df"
There is a tutorial for gym-anytrading.

Yes, I made the changes to dizoo. gym anytrading. envs The content of the data section obtained by StocksEnv has not been modified in other locations, but even if the original 'stocks_data_file name'='STORKS_GOOGL' is used to pass parameters, this problem still occurs.
And thank you for providing the tutorial link, thank you very much!!

Sorry I can't reproduce your error because I'm not sure about your development environment.
And our repo has not yet tried to adapt gym-anytrading to stable-baseline.

authors: Cloud-Pku zhipentian

repo: opendilab/DI-engine


text:
Update README.md

Add one paper about RLHF with crowd preference distributions.

Please resolve the conflicts and modify the name of the pull request as our previous format, then we will merge this PR.

repo: opendilab/awesome-RLHF


text:
Refactoring : Add generic type to ResourceFlowUnit.

Issue #, if available:
Description of changes:
Add generic type to ResourceFlowUnit and now we can specify the type of summary within each flowunit.
This will help us to remove the instanceof when fetching summary from flowunit.
Tests:
tested on docker
Code coverage percentage for this patch:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

LGTM

authors: aditjind rguo-aws


text:
423 histogram accuracy message

Closes #423

I tested  this with the EyeHeight data, using Trial variable (type integer) and Histogram. It passed validation on the Add Statistics step, but the release returned a 400 error (attached)

authors: ecowan ekraffmiller

repo: opendp/dpcreator


text:
Moto Edge Pro 20 - Long Range capabilities

Hi,

Smartphone Model
Chipset
Android version
BT 5 LR Basic Support (Elimination criteria)
BT 5 LR Receiver Support
Wi-Fi Beacon
Wi-Fi NAN
Proof
Note

Motorola Edge 20 Pro
Snapdragon 870 5G (7 nm)
11
✅ 3/2022
❌ 3/2022

To_Be_added
Long range support is claimed but the signals are never received. Test done using LAUNCHXL-CC1352P-2 from Texas Instrument.

Screen shot with "nRF Connect for Mobile" attached to this issue.

Extremely frustrated, since a premium cell phone like this doesn't support LR.

That is actually a bit strange. Do you have any possibility to test your transmitter with other phones (some that on the list are stated to partly or fully receive the Long Range signals)? Just to ensure the problem is not with the transmitter implementation?
I assume you have tried normal advertising mode on the transmitter and you are able to pick up that on the phone? If not, maybe the discussion in #7 will help you get some simple static legacy advertisement message going, just to prove that data can be sent and transmitted correctly.
Will you make a PR with the update for the list for this phone? Based on the screenshots, it looks like you have mostly done the changes to the md file already?

I actually found it a little bit strange too.
Regarding the transmitter implementation, I've tried to use legacy advertisement and it worked seamlessly, however Long Range implementation I can't assure 100% but the configuration that needs to be done is pretty straight forward: Just changing the type of advertisement from 'Legacy' to 'Extended' and choosing 'PHY CODED S2' and 'PHY CODED S8' as primary and secondary advertisement channels, no code is needed only a config tool is used.
I have no other phone - from the working list - to try, and renting one where I'm located is almost impossible.
We can do the following, I'll try to get a Bluetooth LR phone and try it out, it will take some time (months), but I'll manage it. After this is done, I'll perform the PR and update this issue. Is that fine?

I haven't tried the CC1352 HW and do not have a dev board for that. However, I quickly looked at the simple_broadcaster example code from the Project Wizard (Resource Explorer) and it looked very similar to the simple_broadcaster example code for the CC2640 HW (which I know works).
In the SimpleBroadcaster_processGapMessage() function, it is setting up the advertisement parameters via the GapAdv_create() function. For some reason advParams1 doesn't seem to be defined anywhere in the example code but for the CC2640 examples, this can be set to either GAPADV_PARAMS_LEGACY_SCANN_CONN or GAPADV_PARAMS_AE_LONG_RANGE_CONN from C:\ti\simplelink_cc13x2_26x2_sdk_5_20_00_52\source\ti\ble5stack\inc\gap_advertiser.h.
Please note that only PHY CODED S8 should be used for both the primary and secondary PHY. Don't use S2 for either of them.

Thanks for the info.
I double checked the automated generated code and it is flawlessly. So the only problem that could have happen is whether or my board is faulty or cellphone is faulty - both options are very unlikely -, nonetheless I'll find a way to test it and then get back to you.
Out of curiosity this is a snippet of the code (ti_ble_config.c and simple_peripheral.c).
 GapAdv_params_t advParams1 = {   .eventProps =   GAP_ADV_PROP_CONNECTABLE,   .primIntMin =   160,   .primIntMax =   160,   .primChanMap =  GAP_ADV_CHAN_ALL,   .peerAddrType = PEER_ADDRTYPE_PUBLIC_OR_PUBLIC_ID,   .peerAddr =     { 0xaa, 0xaa, 0xaa, 0xaa, 0xaa, 0xaa },   .filterPolicy = GAP_ADV_WL_POLICY_ANY_REQ,   .txPower =      GAP_ADV_TX_POWER_NO_PREFERENCE,   .primPhy =      GAP_ADV_PRIM_PHY_CODED_S8,   .secPhy =       GAP_ADV_SEC_PHY_CODED_S8,   .sid =          0 };
        // Create Advertisement set #1 and assign handle
       status = GapAdv_create(&SimplePeripheral_advCallback, &advParams1, &advHandleLegacy);         SIMPLEPERIPHERAL_ASSERT(status == SUCCESS);

That looks exactly like what I am using on the CC2640. So the conclusion seems to be that the Motorola edge 20 Pro indeed does not pick up the coded PHY 8 advertisement beacons.
The only other test I can think of is to use the nrfConnect app but I assume you are not able to see the signal in there either, when you are only transmitting on the coded PHY.
Will you prepare a PR to add the information you listed in the beginning to the list of smartphones, or should I put it there?
Thanks for reporting this.

Please, put it there. I'm not familiar with PR and also I didn't clone your project, I was just seeking for info in Nordic forums and found out that this is probably the best place to find compatibility for BLE 5.+ Long Range funcionality in smartphones.
Thanks

authors: anu-branco friissoren

repo: opendroneid/receiver-android


text:
Build EBS compatible metadata service in Mayaserver

Mayaserver should have the HTTP server that can accept EBS API requests w.r.t metadata
Code for the following:
Step 1:

GetMetadata("instance-id")
GetMetadata("placement/availability-zone")

Step 2:

Unit test above

Step 3:

Write functional tests using aws-sdk-go

Step 4:

Link these services with a Service Provider i.e. Nomad APIs.

Step 1 & 2 are committed.
Step 3 will further verify 1 & 2.

We are no more building a EBS compatible API.
The APIs are more compatible with K8s pod specs as on release 0.0.5

repo: openebs/mayaserver


text:
[BD-46] docs: update and fix example app

Description
According to Typescript release in Paragon, example app started crashing. This PR includes fixes. Also there updates to dependencies in the example app.
Merge Checklist

[ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
[ ] Does your change adhere to the documented style conventions?
[ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
[ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
[ ] Were your changes tested in the example app?
[ ] Is there adequate test coverage for your changes?
[ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

[ ] Verify your changes were released to NPM at the expected version.
[ ] If you'd like, share your contribution in #show-and-tell.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

Thanks for the pull request, @monteri!
When this pull request is ready, tag your edX technical lead.

authors: monteri openedx-webhooks

repo: openedx/paragon


text:
Validate file templates.json by jq in CI

File templates.json will be now validated by travis
in the process of CI
Closes https://github.com/openfaas/store/issues/47
Signed-off-by: Bart Smykla bsmykla@vmware.com

Merged 👍

authors: alexellis bartsmykla

repo: openfaas/store


text:
is it possible to use playground with auth?

Is it possible to make playground work with enabled auth?
I'm using preshared keys but playground is not aware of it.
I just get missing token exception on every request

👋 @vavsab at this time we do not support the embedded Playground with authentication.
We do have on our roadmap a plan to add an authentication input field (or something similar) to allow you to provide a bearer token in the Playground UI. That work will likely be part of a larger effort to open-source the OpenFGA Playground source code though. We will keep you updated with these developments as they unfold.

@vavsab we now have support for preshared key authentication in the OpenFGA embedded Playground. If you pull down the main branch it's supported. It will be included in our next most release. I'm closing this now that it's supported. If you find any issues with it, please don't hesitate to reach back out 👍

Thanks a lot 🥰

Any chance playground will be integrated with OIDC any time soon?

authors: jon-whit ldigiuseppe vavsab

repo: openfga/openfga


text:
Move the experimental 'category edition' button into the Edit mode

What

[ ] Move the experimental 'category edition' button currently in the product page into the Edit mode

Mockup

Part of

#1161

Does the category edit mode work ok if we have no category at all ?

Does the category edit mode work ok if we have no category at all ?

No, the button "Edit" is deactivated, since nothing happens when the "Additional Button" is clicked in this case.
If we have no category as all, the button "Add missing product category" is shown, but no action has been applied yet.

@teolemon @cli1005 Actually the current implementation is more or less OK when you want to slightly fix an existing category.
It does not work when you're starting from scratch, the reason being that we don't really have access to root categories:

the "root" categories (https://world.openfoodfacts.org/api/v2/taxonomy?tagtype=categories&include_root_entries=1&include_children=0&lc=en%2Cfr&cc=fr) are full of crap, like 'en:ayrshire-new-potatoes', 'en:batches-withdrawn-from-retail-stores' or 'en:caviar-substitutes'. We cannot do anything with them.
in addition to that there are categories without parents, like 'en:plant-based-foods-and-beverages', so we cannot go up to real root categories like a possible 'en:foods-and-beverages' (https://world.openfoodfacts.org/api/v2/taxonomy?tagtype=categories&tags=en%3Aplant-based-foods-and-beverages&include_children=0&lc=en%2Cfr&cc=fr)

Besides, as a user I'm not sure I would bother to climb the category tree step by step, where on the website I can just type "sardines à l'huile" instead of a painful exploration of Conserves, Produits de la mer, Poissons, Poissons en conserve, Poissons et viandes et oeufs, Sardines, Sardines en conserve, Filets de poissons, Sardines à l'huile, Filets de sardines, Sardines à l'huile d'olive, Sardine à l'huile d'olive appertisée

@teolemon @cli1005 Actually the current implementation is more or less OK when you want to slightly fix an existing category.
It does not work when you're starting from scratch, the reason being that we don't really have access to root categories:

the "root" categories (https://world.openfoodfacts.org/api/v2/taxonomy?tagtype=categories&include_root_entries=1&include_children=0&lc=en%2Cfr&cc=fr) are full of crap, like 'en:ayrshire-new-potatoes', 'en:batches-withdrawn-from-retail-stores' or 'en:caviar-substitutes'. We cannot do anything with them.
in addition to that there are categories without parents, like 'en:plant-based-foods-and-beverages', so we cannot go up to real root categories like a possible 'en:foods-and-beverages' (https://world.openfoodfacts.org/api/v2/taxonomy?tagtype=categories&tags=en%3Aplant-based-foods-and-beverages&include_children=0&lc=en%2Cfr&cc=fr)

Besides, as a user I'm not sure I would bother to climb the category tree step by step, where on the website I can just type "sardines à l'huile" instead of a painful exploration of Conserves, Produits de la mer, Poissons, Poissons en conserve, Poissons et viandes et oeufs, Sardines, Sardines en conserve, Filets de poissons, Sardines à l'huile, Filets de sardines, Sardines à l'huile d'olive, Sardine à l'huile d'olive appertisée

We just add a button in the Product Edition page which works the same way as the "Additional Button", no change has been made to the Category Edition :)

@teolemon Not sure I follow you: are we supposed to show this to an end-user that clicks on the "No category so far: please select one" button?

We just add a button in the Product Edition page which works the same way as the "Additional Button", no change has been made to the Category Edition :)

@cli1005 It's just that in Category Edition there were cases that were not handled (cf. the TODOs).

We just add a button in the Product Edition page which works the same way as the "Additional Button", no change has been made to the Category Edition :)

@cli1005 It's just that in Category Edition there were cases that were not handled (cf. the TODOs).

Yes, we might need or have already another issue concerning TODOs of Category Edition? the objective of this issue is just to move the button, in my opinion

@teolemon Could also be fixed if 'en:plant-based-foods-and-beverages' had parents (probably the root).

So... I create a PR juste for the new button or we wait for all the points to reach?

I've updated my comment with links to the blocking issues. Let's put this one on hold, at least until we clean up server side ?

Started the clean-up server side @cli1005 @monsieurtanuki @stephanegigandet
https://github.com/openfoodfacts/openfoodfacts-server/pull/6765

@teolemon I can start working on the "No category: we start from root" feature, can't I?
Or would we better off (haha) with a "type in/search category" feature?

Two are equally valid and complementary options.
Search might be slightly more useful in the short term given the wealth of categories

@teolemon Have you got some starting point suggestions for the "type in/search category" feature?

We have the autosuggest API in the Dart package already, and then on click, you could load the partial taxo API matching the selected tag (thus no UI change needed for final validation)

@teolemon I know that's not what the mocks said but my brain does not understand the concept of multiple categories on the same tree, UI/UX-wise.
I suggest something similar to the website: the list of the current product categories, and the possibility to add a category with autocomplete.
Something like that:

I'm not sure I understand how I'm supposed to interact with this new mockup.
Here's for reference my last version, along with search:

At this point of complexity, the solution we have in V1 (field with existing categories as chips, plus the ability to add more thanks to autocomplete) looks more intuitive.

@monsieurtanuki I've made variants with Radio buttons

Also, in the case of single category selection, I'm not sure how we're supposed to handle the thousands of products who do have multiple categories.

@teolemon Would you prefer something like this?

According to https://openfoodfacts.github.io/api-documentation/#7Metadata

Important! The categories hierarchy is not a tree but a lattice: each node can have several children, but also several parents.

@teolemon That would tend to plead for "type in keywords/search" rather than "tree search", wouldn't it?

Probably.

authors: cli1005 monsieurtanuki teolemon

repo: openfoodfacts/smooth-app


text:
Deprecate or decide to keep functionality in utils/structure.py

We have several utility functions here, some of which we fixed in the 0.2.0 release, but many of which have lapsed.
Functions to decide on are:

generateSMIRNOFFStructure(oemol)
generateProteinStructure(proteinpdb, protein_forcefield='amber99sbildn.xml', solvent_forcefield='tip3p.xml')
combinePositions(proteinPositions, molPositions)
mergeStructure(proteinStructure, molStructure)
generateTopologyFromOEMol(molecule)  <-- probably delete, we shouldn't need to handle OEMols specially any more
normalize_molecules(molecules) <-- probably delete, we already perform molecule sanitization elsewhere
read_molecules(file_path, verbose=True) <-- probably delete, redundant with Molecule.from_file
setPositionsInOEMol(oemol, positions) <-- probably delete
extractPositionsFromOEMol(oemol) <-- probably delete
read_typelist(file_path) <-- probably delete
positions_from_oemol(mol) <-- probably delete
check_energy_is_finite(system, positions)
get_energy(system, positions)
get_molecule_parameterIDs(molecules, forcefield)
getMolParamIDToAtomIndex(molecule, forcefield)
merge_system(topology0, topology1, system0, system1, positions0, positions1, label0="AMBER system", label1="SMIRNOFF system", verbose=True)
save_system_to_amber(openmm_topology, system, positions, prmtop, inpcrd)
save_system_to_gromacs(openmm_topology, system, positions, top, gro)

I agree with all of the ones that you proposed deleting, and actually I think ALL of them can be deleted (unless used in tests!)except maybe I could still see wanting to use
get_molecule_parameterIDs(molecules, forcefield)
getMolParamIDToAtomIndex(molecule, forcefield)
I don't see any need for most of these and in fact we had already agreed we wanted to remove most of the functionality in utils and focus on exposing the API/getting people to use the API ratehr than wrapper functions provided here.

In #425 I'm going to add deprecation warnings to all of these functions, with instructions to come back to this issue and let me know if folks want us to continue supporting specific functionality.

Haven't seen any complaints (at least publicly, feel free to reach out elsewhere if there are other concerns)
Should we target removal in 0.8.0?

I think all of these methods are now covered by actual designed API methods, so it would be great to ditch them and see if anyone complains!

With the exception of one function that was still used in an example, the module has been removed and will be unavailable in 0.8.0.

Thanks, Matt. This can now be closed!

authors: davidlmobley j-wags jchodera mattwthompson

repo: openforcefield/openforcefield


text:
Unable to load toolkit <openforcefield.utils.toolkits.OpenEyeToolkitWrapper

I installed the new version according to the instructions but did not install the openeye toolkit.
When trying to run the "SMIRNOFF_simulation" example I get this error after:
from openforcefield.utils import get_data_file_path

Unable to load toolkit <openforcefield.utils.toolkits.OpenEyeToolkitWrapper object at 0x2aaad2cf0f28>.

Is this exp[ected? I thought the version does not require OE?
Thanks,
Alberto

It doesn't require OE, so this SHOULD work (and in fact is a tested option). Could you specify a bit more about how you're installing? That is, are you using the package installer, or installing from conda?  What platform?

Yes -- when you first import the toolkit, it will attempt to load OE, but if it doesn't, it will use RDKit. Right now, we don't pull down OpenEye by default. So this is completely expected behavior, and your toolkit installation should be fully functional.

authors: bgobbi davidlmobley j-wags


text:
Add the shell and makemigrations options to make

Purpose
Add the shell and makemigrations options to make
Description...
In the process or doing some dev work, found that these two useful django management tools were not available through the make command.
Proposal
Add both commands

I was not aware of the commit message requirements prior to creating this pull request. I tried to fix my messages to meet the Circle-CI requirements, but have failed. Would welcome any insight.

repo: openfun/marion


text:
Add an option to disabled path for website with single store

Multi-websites applications may have a single store for some websites. For those website's stores we want to have an option to hide the store path in the url.
Add a warning that Magento may can't resolve the correct store if it shares the same base url as an other (shouldn't apply on multiple brands websites with different domains configured in base urls).

https://github.com/alex-79/magento2-hide-default-store-code-from-url

Implemented in #3.0.0


text:
Unable to select an entity on a vector layer with touch events.

I have a vector layer and I want to be able to select the objects. It works with mouseenter events, but with touch I am getting the following webGL warnings.
WebGL: INVALID_ENUM : readPixels: invalid type
[.WebGL-0x13000e34600] GL_INVALID_OPERATION: Missing read attachment.
The pickingObject turns up null. I was able to get it to select the objects by changing the renderEvents.ts file at around line 720, adding "||(this._oneTouchStart)" to the condition and then commenting out the framebuffer code that was causing the warnings in handleTouchEvents() at around line 956.
I'm not familiar with the code yet, so I'm not sure what that code is supposed to be doing. Maybe I'm just doing something wrong, but the problem also happens in the example. Hope this helps.

Seems to work for me . Thanks :D

repo: openglobus/openglobus


text:
Improvements for CanonicalView

This pull request is a follow-up to #361.

Avoids view functions whenever possible.
Reuses original factor functions whenever possible.
Template parameter determines if factors should be cloned as ExplicitFunctions.

Additionally, the branch now includes a unit test (checks that all labelings evaluate to the correct energy).

Seems like Travis' version of g++ dislikes my template metaprogramming. As far as I know, I only used C++98 features. I will investigate this issue.

I fixed the failure by using the slightly uglier typedef Parent::Type Type syntax.
Checks are passing now.

repo: opengm/opengm

license: mit


text:
feat: parse sgid userinfo data

feat: parse sgid userinfo data
This commit adds a new method, parseData, which helps to parse the
sgid userinfo object so that any stringified array or object values
are parsed as objects.

This commit is implemented according to the SDK implementation
requirements as linked here: https://www.notion.so/opengov/SDK-implementation-requirements-1f9b7cbd2bd4406b85d6645fe3e365dd#dcabe67d14034525bfd5e84acc1c59c6

This commit also adds the necessary unit tests for the newly introduced
utility functions that support parseData

Current dependencies on/for this PR:

develop

PR #69   👈

This comment was auto-generated by Graphite.

repo: opengovsg/sgid-client


text:
[TASK] Adopt Smrnmi

Task Description
Current implementation of RNMIs is based on a custom Ibex implementation. When Smrnmi is ratified, move to the standard version.
Description of Done
Compliance to Smrnmi, custom solution removed
Associated PRs
No response

Removing original assignee as they are no longer assigned to this project.

authors: MikeOpenHWGroup christian-herber-nxp


text:
PoR value of mcountinhibit CSR is not documented

Bug Description
By visual inspection of the RTL, the power-on-reset value of mcountinhibit is 'h0.  I believe this to be a valid state of affairs, but this is different that other CORE-V cores and is not documented in the User Manual.  Check out the CV32E40P User Manual's CSR Chapter for an example.

The performance counter reset values are documented here main/doc/03_reference/performance_counters.rst. There is a difference in these reset values between the cv32e40 and cv32e20 cores. It might be good to have consistency for these reset values between the cv32 cores. Also for low power consumption the performance counters are expected to be disabled after reset.

There is also a difference in reset values between cv32e20 and cv32e40 for the mhpmevent csr registers.

authors: MaartenArts MikeOpenHWGroup


text:
会话的latestMsg有问题，

部分机型，在发送消息后，onConversationChanged，latestMsg没更新，接下来收到消息也不更新latestMsg

目前已经更新到3.0版本，参考demo实现，https://github.com/OpenIMSDK/Open-IM-Uniapp-Demo

repo: openimsdk/open-im-sdk-uniapp


text:
[BUG] @openim/node-client-sdk cannot send message with db error

OpenIM Server Version
1.1.0
Operating System and CPU Architecture
macOS (ARM)
Deployment Method
Docker Deployment
Bug Description and Steps to Reproduce
I use node to send message to openim server. The code is as follows
import OpenIMSDK from '@openim/node-client-sdk'
// import { CbEvents, LogLevel } from 'open-im-sdk-wasm';
// import type { WSEvent } from 'open-im-sdk-wasm';
const CbEvents = {
  Login: "Login",
  OnConnectFailed: "OnConnectFailed",
  OnConnectSuccess: "OnConnectSuccess",
  OnConnecting: "OnConnecting",
  OnKickedOffline: "OnKickedOffline",
  OnSelfInfoUpdated: "OnSelfInfoUpdated",
  OnUserTokenExpired: "OnUserTokenExpired",
  OnProgress: "OnProgress",
  OnRecvNewMessage: "OnRecvNewMessage",
  OnRecvNewMessages: "OnRecvNewMessages",
  OnRecvOfflineNewMessage: "onRecvOfflineNewMessage",
  OnRecvOfflineNewMessages: "onRecvOfflineNewMessages",
  OnRecvMessageRevoked: "OnRecvMessageRevoked",
  OnNewRecvMessageRevoked: "OnNewRecvMessageRevoked",
  OnRecvC2CReadReceipt: "OnRecvC2CReadReceipt",
  OnRecvGroupReadReceipt: "OnRecvGroupReadReceipt",
  OnConversationChanged: "OnConversationChanged",
  OnNewConversation: "OnNewConversation",
  OnSyncServerFailed: "OnSyncServerFailed",
  OnSyncServerFinish: "OnSyncServerFinish",
  OnSyncServerStart: "OnSyncServerStart",
  OnTotalUnreadMessageCountChanged: "OnTotalUnreadMessageCountChanged",
  OnBlackAdded: "OnBlackAdded",
  OnBlackDeleted: "OnBlackDeleted",
  OnFriendApplicationAccepted: "OnFriendApplicationAccepted",
  OnFriendApplicationAdded: "OnFriendApplicationAdded",
  OnFriendApplicationDeleted: "OnFriendApplicationDeleted",
  OnFriendApplicationRejected: "OnFriendApplicationRejected",
  OnFriendInfoChanged: "OnFriendInfoChanged",
  OnFriendAdded: "OnFriendAdded",
  OnFriendDeleted: "OnFriendDeleted",
  OnJoinedGroupAdded: "OnJoinedGroupAdded",
  OnJoinedGroupDeleted: "OnJoinedGroupDeleted",
  OnGroupDismissed: "OnGroupDismissed",
  OnGroupMemberAdded: "OnGroupMemberAdded",
  OnGroupMemberDeleted: "OnGroupMemberDeleted",
  OnGroupApplicationAdded: "OnGroupApplicationAdded",
  OnGroupApplicationDeleted: "OnGroupApplicationDeleted",
  OnGroupInfoChanged: "OnGroupInfoChanged",
  OnGroupMemberInfoChanged: "OnGroupMemberInfoChanged",
  OnGroupApplicationAccepted: "OnGroupApplicationAccepted",
  OnGroupApplicationRejected: "OnGroupApplicationRejected",
  UploadComplete: "UploadComplete",
  OnRecvCustomBusinessMessage: "OnRecvCustomBusinessMessage",
  OnUserStatusChanged: "OnUserStatusChanged",
  OnReceiveNewInvitation: "OnReceiveNewInvitation",
  OnInviteeAccepted: "OnInviteeAccepted",
  OnInviteeRejected: "OnInviteeRejected",
  OnInvitationCancelled: "OnInvitationCancelled",
  OnHangUp: "OnHangUp",
  OnInvitationTimeout: "OnInvitationTimeout",
  OnInviteeAcceptedByOtherDevice: "OnInviteeAcceptedByOtherDevice",
  OnInviteeRejectedByOtherDevice: "OnInviteeRejectedByOtherDevice",
  OnStreamChange: "OnStreamChange",
  OnRoomParticipantConnected: "OnRoomParticipantConnected",
  OnRoomParticipantDisconnected: "OnRoomParticipantDisconnected",
  OnReceiveCustomSignal: "OnReceiveCustomSignal",
  UnUsedEvent: "UnUsedEvent"
}

const IMSDK = new OpenIMSDK('./node_modules/@openim/node-client-sdk/assets/mac_arm64/libopenimsdk.dylib');

IMSDK.on(CbEvents.OnConnecting, handleConnecting);
IMSDK.on(CbEvents.OnConnectFailed, handleConnectFailed);
IMSDK.on(CbEvents.OnConnectSuccess, handleConnectSuccess);

await IMSDK.initSDK({
  platformID: 5,
  apiAddr: 'http://localhost:10002',
  wsAddr: 'ws://localhost:10001',
  dataDir: './',
  logFilePath: '',
  logLevel: 5,
  isLogStandardOutput: true,
});

IMSDK.login({
  userID: "5751705728",
  token: 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJVc2VySUQiOiI1NzUxNzA1NzI4IiwiUGxhdGZvcm1JRCI6NSwiZXhwIjoxNzI3MzQ2NDA1LCJuYmYiOjE3MTk1NzAxMDUsImlhdCI6MTcxOTU3MDQwNX0.dkyVEnjCez78mBVjfPcukmEezmOwn_NhHOKdIrx0k_g',
  // apiAddr: 'http://localhost:10002',
  // wsAddr: 'ws://localhost:10001'
  // token: 'aaa'
}).then((res) => {
  console.log(res)
}).catch((...args) => {
  console.error(args)
});

function handleConnecting() {
  // Connecting...
}

function handleConnectFailed({ errCode, errMsg }) {
  // Connection failed ❌
  console.log(errCode, errMsg);
}

function handleConnectSuccess() {
  // Connection successful ✅
}

IMSDK.on(CbEvents.OnRecvNewMessages, handleNewMessages);

const message = (await IMSDK.createTextMessage('hello openim')).data;

IMSDK.sendMessage({
  recvID: '5751705728',
  groupID: '',
  message,
})
  .then(() => {
    // Message sent successfully ✉
    console.log('****Message sent successfully****');
  })
  .catch(err => {
    // Failed to send message ❌
    console.log(err);
  });

function handleNewMessages({ data }) {
  // New message list 📨
  console.log(data);
}

I cannot send message. The terminal erros are as follows.

My node version is v20.1.2. My computer is Mac Pro M2. The os is Sonoma 14.0
Screenshots Link
No response

you can try again with @openim/electron-client-sdk, and refer to thisdemo

authors: Bloomingg Shiuwn

repo: openimsdk/openim-sdk-electron


text:
Android 平台第二次进入页面会引发 libkraken_jsc.so crash

使用首页集成的安卓客户端sdk 第二次打开测试页面会出现动态库so错误

请问是什么错误？

首次加载测试页面正常 回退页面后，再加载测试页面会出现错误 下面是错误信息：

Build fingerprint: 'Xiaomi/polaris/polaris:10/QKQ1.190828.002/20.6.10:user/release-keys'
Revision: '0'
ABI: 'arm64'
Timestamp: 2021-06-30 11:11:52+0800
pid: 13676, tid: 13825, name: 2.ui  >>> com.android.hanweb.flutterdemo <<<
uid: 10858
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x16
Cause: null pointer dereference
x0  000000723afca100  x1  0000000000000000  x2  00000072b1404b68  x3  0000000000000002
x4  0000000000000002  x5  0000000000000000  x6  0000000000800000  x7  0000000000000010
x8  000000000000000e  x9  e55fa49bd2d0dbb2  x10 00000000ffffffff  x11 0000000000000000
x12 000000723afca000  x13 fffffffffc000000  x14 0000000000000020  x15 0000000000010000
x16 00000073347a5890  x17 0000007334797e68  x18 000000723e030000  x19 000000723afc46e0
x20 0000007240ea5b60  x21 00000072a03771b0  x22 0005c5f31585fb03  x23 00000072a037a020
x24 0000007213a48c90  x25 00000072a0377400  x26 00000072a037a020  x27 ffff000000000000
x28 ffff000000000002  x29 00000072a03771a0
sp  00000072a0377150  lr  000000721dc59814  pc  000000721dc59820
backtrace:
#00 pc 0000000000053820  /data/app/com.android.hanweb.flutterdemo-FYEh8GXBsEqFYkXvmYeL9g==/lib/arm64/libkraken_jsc.so (BuildId: 62c524b86eb8ae981e81d9f9a0d463d9206fc210)
#01 pc 000000000001b0c0  /data/app/com.android.hanweb.flutterdemo-FYEh8GXBsEqFYkXvmYeL9g==/lib/arm64/libkraken_jsc.so (BuildId: 62c524b86eb8ae981e81d9f9a0d463d9206fc210)
#02 pc 0000000000143790  /data/app/com.android.hanweb.flutterdemo-FYEh8GXBsEqFYkXvmYeL9g==/lib/arm64/libjsc.so (BuildId: 5144ead17a8b84eafc4d3b53516b954156d85440)
#03 pc 000000000040c018  /data/app/com.android.hanweb.flutterdemo-FYEh8GXBsEqFYkXvmYeL9g==/lib/arm64/libjsc.so (BuildId: 5144ead17a8b84eafc4d3b53516b954156d85440)
#04 pc 00000000003f6158  /data/app/com.android.hanweb.flutterdemo-FYEh8GXBsEqFYkXvmYeL9g==/lib/arm64/libjsc.so (BuildId: 5144ead17a8b84eafc4d3b53516b954156d85440)

backtrace:
#0 pc 0000000000053820 /data/app/com.android.hanweb.flutterdemo-FYEh8GXBsEqFYkXvmYeL9g==/lib/arm64/libkraken_jsc.so (BuildId: 62c524b86eb8ae981e81d9f9a0d463d9206fc210)

通过以下命令进行处理之后：
➜  bin ./aarch64-linux-android-addr2line -f -C -e ~/Desktop/libkraken_jsc.so 0000000000053820
kraken::binding::jsc::JSPerformanceEntry::getPerformanceEntryPropertyNames()
/Users/kraken/workspace/kraken/bridge/bindings/jsc/KOM/performance.h:153

确认为 PerformanceTrack 引发的 crash。这个功能是不应该出现在发布在 pub.dev 的包里面的，不过曾经有个版本混进了这个代码，请问你是用了那个版本？

使用的发布最新的  com.openkraken.kraken.sdk.0.8.0+1.zip

使用的发布最新的 com.openkraken.kraken.sdk.0.8.0+1.zip

这个版本的确有问题，试下刚更新上去的 0.8.0+2

好的 谢谢

authors: MrLiBack andycall

repo: openkraken/kraken


text:
Feature/more scripts

Helpful scripts for ubuntu and more.

Now they are.

repo: openlattice/openlattice


text:
Wrong display of HighRes tiles

Following page uses 512x512 tiles instead of 256x256 and the resulting display is wrong:
https://josm.openstreetmap.de/mapsview?entry=basemap.at
Instead of broken display the scaling should be adapted to the image size.

Forgot: Installed is version 3.5.0.


text:
ol.source.ImageWMS gets stuck loading image for certain extents

The getImage function checks if the source already has an image to respond with.  This includes an extent comparison.
https://github.com/openlayers/ol3/blob/f5cd9a3ebac748d248e04b30688db447435d23ab/src/ol/source/imagewmssource.js#L206
However, this extent comparison incorrectly compares the image.getExtent() with the raw extent requested.  Instead it should compare the image.getExtent() with an "image extent" computed from the raw extent.  "Image extents" are adjusted to allow for integer pixel heights/widths.
For certain extents, the extent comparison will never pass and renderring of the ImageWMS will end up in an infinite loop....repeatedly creating new ol.Image instances that never finish loading.

Should be fixed with #3933. @rattai, can you please verify?

To improve the pull request, you could also cache the image extent, e.g. as imageExtent_ member, instead of calculating it with every getImage call.

authors: ahocevar rattai


text:
[FeatureRequest]: add ol.layer.Vector.setRenderMode('image' || 'vector')

ol.layer.Vector allows to define the renderMode in the constructor.
However, the renderMode cannot be changed (or I overlooked something) after constructing a vector.
For performance reason, I would like to change the renderMode to image as sometimes (depending on the amount of features) the performance might be insufficient while in general vector works.
So, I would like to let the user change the renderMode depending on his needs after loading the features.
Working solutions:
At the moment, the solution be to recreate the vector (including coping all other settings) and replace it in the layergroup.
Desired solution:
Adding ol.layer.Vector.setRenderMode('image' || 'vector')
My workaround: creating new ol.layer.Vector, copying all (relevant) attributes, and set renderMode accordingly.
    var collectionLayers = this.getMap().getLayerGroup().getLayers();

    for(let i = 0; i < collectionLayers.getLength(); i++) {
        let layer = collectionLayers.item(i);

        if (layer instanceof ol.layer.Vector) {
            let layerNew = new ol.layer.Vector({
                source: layer.getSource(),
                style: layer.getStyle(),
                renderMode: this._shouldBeFast ? "image" : "vector" //TODO should use ol.layer.VectorRenderType
            });

            collectionLayers.setAt(i, layerNew);
        }
    }

From my understanding ol.layer.Vector.getRenderMode() is only called by CanvasImageLayerRenderer at https://github.com/openlayers/openlayers/blob/master/src/ol/renderer/canvas/ImageLayer.js#L201
If I got it right, this check is only used when constructing the CanvasImageLayerRenderer
https://github.com/openlayers/openlayers/blob/master/src/ol/renderer/canvas/ImageLayer.js#L56
Therefore, changing the ol.layer.Vector.renderMode will not trigger a recreating the CanvasImageLayerRenderer, right?
@ahocevar
How could I trigger the re-evaluation of the renderMode after CanvasImageLayerRenderer got constructed?

@dennisguse When the vector layer has renderMode: 'image' set, it will use an image renderer. To notify the map renderer of the renderer change, it should be enough to call this.changed() on the layer, i.e. in the setRenderMode function.

@dennisguse can we close this issue?

@fredj Sure. For my use case, I implemented the described workaround.

Thanks @dennisguse !

authors: ahocevar dennisguse fredj

repo: openlayers/openlayers


text:
hotjar popup not shown when using the custom domain name

check hotjar config

I'm not sure what hotjar is actually doing. I don't think it's config'd.

If we're using this for feedback. Maybe we should opt into another user feedback service.

Good call. I'm not sure Hotjar is the best service for collecting 'Anything wrong' feedback.
@chaserx do you have any others you've been happy with in the past?

Hmmm. No good ones. I think maybe UserVoice once-upon-a-time and most of them are paid services.
UserSnap looks interesting. https://usersnap.com/ but $19/mo. Maybe they could donate services. Maybe @ondrae knows of some good options
I think just some form that drops into GitHub Issues with some labels would be ideal.

Ben Balter has some interesting services to get data into a github issue. See: https://github.com/benbalter/comment-card
and
https://github.com/benbalter/problem_child

Look like good options. Another that submits feedback to Google Analytics called ga-feedback. It would be good if stakeholders would prefer that feedback not be immediately made public.

Ben Balter's project require that we host them yeah? Worth weighing that versus the javascript-based ga-feedback.

Although, I'm not sure if the ga-feedback thing would integrate with recaptcha if we need that down the line to keep spammers away.

I'm down to use ga-feedback.

Great. I'll give ga-feedback a try and report back.

Consensus is to move away from hotjar. Closing in favor of #48

authors: chaserx eeeschwartz

repo: openlexington/finda


text:
View Users: Added organisation is not saved.

PATCH /rest/users/66870
accountLocked: false
curatoryGroupIds: [62903]
email: "Ciesielczyk@hebis.uni-frankfurt.de"
enabled: true
id: 66870
organisation: 44375
passwordExpired: false
roleIds: []
username: "HebisJC"
returns a 200 but shows error object in the result
errors: [{$field: {message: "unknown", baddata: "organisation", code: null}}]
0: {$field: {message: "unknown", baddata: "organisation", code: null}}
$field: {message: "unknown", baddata: "organisation", code: null}
baddata: "organisation"
code: null
message: "unknown"
result: "OK"

won't fix until #282 is solved.

authors: VolkerHBZ dirk-ecker

repo: openlibraryenvironment/gokb


text:
[Master] Do not touch the connections in fcp database in get_available_fcp

We should just set the assigner id and not change the connections
in get_available_fcp. The connections are maintained in attach and detach
steps.
Signed-off-by: dyyang dyyang@cn.ibm.com

I can't judge the logic here as that might need deeper understanding, anyway in the team read it already?
the code itself looks good,
/lgtm

authors: dongyanyang jichenjc

repo: openmainframeproject/python-zvm-sdk


text:
Fix platform

A missing platform section lead to failed imports.
See: https://github.com/ansible/galaxy-issues/issues/225

Green. Merging with the hope that this will fix the import situation.

repo: openmicroscopy/ansible-role-basedeps


text:
Bio-Formats 5.5.0

As discussed with @jburel @hflynn and @lunson, this PR updates Bio-Formats pages to match the latest Bio-Formats 5.5.0

https://snoopycrimecop.github.io/www.openmicroscopy.org/products/bio-formats/downloads/ built on staging

What's the plan for previous versions? Add a 'Previous' tab and then link back to http://downloads.openmicroscopy.org/bio-formats/ ?

@hflynn That works for me.

This looks fine on staging, do we want to merge it for now or were you going to add the previous tab yourself @sbesson ?

Assuming we are fine with this as an intermediate step, I'd capture the previous tab as a follow-up on the reference card (alongside OMERO and the other exposed software)

👍

authors: hflynn lunson sbesson


text:
[Bug] Out-of-order messages with +2 generations corrupts sender ratchet until epoch update/reset

Describe the bug

The issue occurs when messages to be processed are out-of-order with a generation gap >= 2, i.e., a sender sends at least three messages (generation gap >= 2), and the receiver processes the latter first.
To Reproduce

Alice creates the group;

Alice invites Bob;

Bob joins the group (new_from_welcome)

Alice processes the added member commit

Alice attemps to send 3 consecutive messages:
let mls_msg_1 = try alice_group.create_message(b"message1")
let mls_msg_2 = try alice_group.create_message(b"message2")
let mls_msg_3 = try alice_group.create_message(b"message3")

(for some reason) bob receives and processes the third message first:
let bob_event = try bob_group.process_messages([mls_msg_3])

the output event will be invalidCiphertext caused by  a decryption error on aead_open in MLSCiphertext.to_plaintext

Expected behavior

Bob was expected to be able to decrypt the out-of-order message since the generation gap is still within OUT_OF_ORDER_TOLERANCE bounds.
Actual behavior

Bob was not able to decrypt the message because he is not correctly deriving the generation secret used to derive the ratchet secret. Concretely, the bug is caused by always using the base generation (self.generation) and not the actual "current" generation in which the ratchet secret is being derived in ratchet_secret() (here).
Platform (please complete the following information):
its a code-based bug, not platform-dependent. However, just for the record:

OS & OS version: android 10 and iOS 14
Architecture: arm64-v8a and arm64
Version: Java and Swift ports from the branch main-a454a5a. However the "bugged" code is the same in the latest commit

Suggested Solutions

here move the loop range into a local variable and increment self.generation inside the loop, after deriving the past_secret, like so:

let gap = generation - self.generation;
for _ in (0..gap) {
    if self.past_secrets.len() == OUT_OF_ORDER_TOLERANCE as usize {
        self.past_secrets.remove(0);
    }
    let new_secret =
        self.ratchet_secret(ciphersuite, self.past_secrets.last().unwrap());
    self.past_secrets.push(new_secret);
    self.generation += 1; // <- bugfix
}

here pass the current generation as argument in the function ratchet_secret() like so:

 // ...
          for gen_gap in 0..(generation - self.generation) { // loop range index (gen_gap) is now required
              if self.past_secrets.len() == OUT_OF_ORDER_TOLERANCE as usize {
                  self.past_secrets.remove(0);
              }
              let new_secret =
                  self.ratchet_secret(ciphersuite, self.past_secrets.last().unwrap(), (self.generation + gen_gap);
              self.past_secrets.push(new_secret);
          }

// ...

fn ratchet_secret(&self, ciphersuite: &Ciphersuite, secret: &Secret, generation: u32) -> Secret {
        derive_tree_secret(
            secret,
            "secret",
            NodeIndex::from(self.index).as_u32(),
            generation, // self.generation replaced by function parameter
            ciphersuite.hash_length(),
        )
    }

This way, the new_secret used to derive the ratchet secrets is derived on the correct generation.
Edits

In solution 1, since it's a ForEach, the loop higher range doesn't need to be set outside of the for declaration since the difference will only be computed once. So the actual bugFix is just one line, the self.generation increment
rolled back Edit 1_ (added the local variable with the generation gap) as suggested by @raphaelrobert

Hi @mefsantos and thanks for the detailed bug report! This is certainly an area of the code that hasn't seen a lot of testing yet and needs some love for other reasons as well (#243, #103 and #18 come to mind, although they're somewhat overlapping). The test vectors we have been working on lately are also primarily testing group evolution and not so much the actual message encryption.
Your first solution seems like the easiest fix for now, so I'd vote for that given that we will probably have to touch a lot of the code here anyway. @franziskuskiefer @raphaelrobert any objections?

Thanks for flagging it @mefsantos! I agree with @kkohbrok that option 1 is probably easiest for now. I would however recommend to first introduce the gap variable you propose – just to be on the safe side: gap = generation - self.generation and use that as the upper bound for the loop. Also, line 63 is then probably redundant.
Lastly, we clearly need tests for all of this stuff.
Do you feel like submitting a PR for that?

I've spoken with my team (since I am not a RUST developer) and we will submit the PR. Is it enough to patch the bug and implement one unit test for this purpose (out-of-order messages) in the PR?

Yes, that's the idea. The PR should address the problem, have test coverage (with at least positive and a negative test) and make the CI happy.

This was fixed in #456.

authors: kkohbrok mefsantos raphaelrobert

repo: openmls/openmls


text:
Have create_commit return a StagedCommit

This PR changes the return type of create_commit such that it returns a staged_commit in addition to the other results. This should make processing more efficient as we don't need to go through verification before merging our own commit.
Notes:

This PR includes a conversion from CreationProposalQueue to StagedProposalQueue, which clones all proposals in the Queue. This is required for now, as the StagedProposalQueue includes the full proposal rather than a reference, which in turn leads to easier reviewability by a consumer if it's passed out for review in the course of commit processing. We might be able to improve the whole structure, but I leave that to #626.
This PR is large mostly due to the change of signature of create_commit. Beside adding a simple test for processing the StagedCommit returned by create_commit, I have not changed any test files beyond fixing them to work with the new function signature.

Fixes #617.

I agree. The idea was to split it up so that we don't have another huge PR. Having create_commit return a StagedCommit as a first step seemed like a decent first step to me.


text:
Implement Workflow for Generating Sample App APKs and Enabling Direct Testing from GitHub

Same as https://github.com/openmobilehub/android-omh-auth/issues/77. Thanks for looking into it.

Friendly ping.

Hi @Nataliagros,
As discussed, credentials should not be a blocker for integrating this into the CI/CD. The team will use environment variables with placeholder dummy values and set up the process to release builds into GH Releases. We will update the environment variables with valid values soon.
Thank you!

Hey @dzuluaga, thanks for bringing this to our attention! This was addressed and should be fixed in https://github.com/openmobilehub/android-omh-maps/pull/110/commits/f40178f3722155381c19374d7d756aa2eacb3470.

authors: andrei-zgirvaci dzuluaga

repo: openmobilehub/android-omh-maps


text:
Fix encryption keys

Not sure, but I think, the problem is a misconfigured .travis.yml file not missing keys. Turns out that the keys are not set in the current script. This might fix it. Hard to test.

Try to merge it and see what happens...

merging, with fingers crossed that this will fix it (no need to worry about tests; this only affects structure of the .travis.yml, and we won't know if it works until it is merged to master anyway)

Excellent! This fixed it. Still have lots of warnings to fix in the docs build, but at least the docs are getting uploaded! (I really needed that, since I want the report I need to finish this week to point to the new docs on TIS analysis -- thanks for figuring out the problem and quickly fixing it!)

No way, really? Wow, that was a long shot... Great...

I needed this to exist: http://openpathsampling.org/latest/topics/tis_analysis.html
Now it does! :-)

authors: dwhswenson jhprinz

repo: openpathsampling/openpathsampling


text:
Use the viash dependencies config value for workflows

Changelog
Use the viash dependencies config value for workflows
~MERGE #644 FIRST!~
Issue ticket number and link
Closes #603
Closes #604
Checklist before requesting a review

[x] I have performed a self-review of my code

[ ] Conforms to the Contributor's guide

Check the correct box. Does this PR contain:

[x] Breaking changes
[x] New functionality
[ ] Major changes
[ ] Minor changes
[ ] Documentation
[ ] Bug fixes

[x] Proposed changes are described in the CHANGELOG.md

[ ] CI tests succeed!

@ddemaeyer Did you want to test these workflows before merging the PR?

authors: DriesSchaumont rcannood

repo: openpipelines-bio/openpipeline


text:
🛑 OpenHolidays API is down

In 242bfea, OpenHolidays API (https://openholidaysapi.org/Countries) was down:

HTTP code: 503
Response time: 625 ms

Resolved: OpenHolidays API is back up in e35d493 after 47 minutes.

repo: openpotato/uptime


text:
Key words for dgfInsider customization

Customized key words for dgfInsider procedure. roles - Provider, Viewer. several service components add into newtend_servise

This change is

got misspells, closed because of that


text:
Add 'name' do publisher in data source metadata

If someone follow the current zavod tutorial, because there is no 'name' on the publisher, nomenklatura will fail to load the data source metadata.
  File "/home/aivuk/zavod/lib/python3.10/site-packages/nomenklatura/dataset/dataset.py", line 44, in __init__
    self.publisher = DataPublisher(pdata) if pdata is not None else None
  File "/home/aivuk/zavod/lib/python3.10/site-packages/nomenklatura/dataset/publisher.py", line 13, in __init__
    name = type_require(registry.string, data.get("name"))
  File "/home/aivuk/zavod/lib/python3.10/site-packages/nomenklatura/dataset/util.py", line 29, in type_require
    raise MetadataException("Invalid %s: %r" % (type_.name, value))
nomenklatura.exceptions.MetadataException: Invalid string: None

Ooops, thanks for fixing it!

authors: aivuk pudo

repo: opensanctions/opensanctions


text:
feat(editors/subtation): allow instationtion of LNode from LNodeTypes

Closes #740
This wizard is straight forward, as are its test.
At the moment the other LNode type wizard is used both as edit and as create wizard. With this PR it will be an edit wizard only. I do think it is logically correct as for a top-down procedure usually engineers will instantiate from LNodeType first, which create the LNode initially, and in the process of creating an instantiated virtual IED will complete the LNode pointing to both the LNodeType and the LN/LN0.
However, I am very open for discussion here :)
UPDATE: After some discussion, the existing LNode type wizard and the new wizard implemented here are combined. The entry point LNode wizard chooses based in the parent tag name which one fits best. In addition to that the user can navigate between the two with using the menu action.

The last commit LGTM. Thanks for your effort :)

repo: openscd/open-scd


text:
dzi on the fly

I am working with MEAN on Ubuntu. I have nearly 1,000,000 images so I can't store the DZI files. What is the best way to create DZI files on the fly?  Create the DZI files only when the image is viewed.

It all depends on Your input file format and size. I'm using https://github.com/ruven/iipsrv

How big are these images? If they are less than 2000 pixels across, you could use the simple image tileSource:
http://openseadragon.github.io/examples/tilesource-image/
Otherwise take a look at:
http://openseadragon.github.io/examples/creating-zooming-images/
There are a couple of server options mentioned (like the one @boskar listed above), or you could set up your own server side component based on one of the other tools.

Thank you.

authors: adv1023 boskar iangilman

repo: openseadragon/openseadragon


text:
Navigator blank when initially hidden

If the navigator element is hidden (display:none) on initial load. When it is displayed later, the image is not there and the display region is very small regardless of zoom level.
http://jsbin.com/romima/4/embed?html,css,js,output
Click the button to toggle navigator visibility. If the navigator element is shown before initial load, it will behave as expected.
Additionally, if I use Angularjs's ng-if directive, the initial load fails because it does not find the navigator for the given id and nothing is displayed even on the main viewer:
http://jsbin.com/lixeti/6/edit?html,js,output
Console output Error:
TypeError: Cannot set property 'id' of null
    at new $.Navigator (openseadragon.js:9835)
    at new $.Viewer (openseadragon.js:7023)
    at window.OpenSeadragon (openseadragon.js:685)

// Error line in $.Navigator
this.element.id         = options.id;

This is another reason to "Turn the navigator into a plugin" (#492)

Indeed.
This is for an external navigator element, not the one nested in the viewer, right? I suppose one fix would be to restructure the navigator so it can be added later, rather than having to be there from the moment the viewer starts. And yes, this would be easier if it was a plugin, I think.

Meanwhile, you might try not having the viewer create the navigator, but creating it yourself (new OpenSeadragon.Navigator(options)) when you need it. You can use this for reference:
https://github.com/openseadragon/openseadragon/blob/master/src/viewer.js#L401

That is what I am doing, but the navigator still does not show an image unless I call viewer.open(viewer.tileSources); on the main viewer.
To stop the main viewer from resetting to home position, I set viewer.preserveViewport = true;. This is not ideal because the main viewer gets redrawn. The alternative involves copying a big chunk of the code in $.Viewer.open

Yet another reason it would be good to refactor the navigator so it's more autonomous. Would you be up for working on that?
Meanwhile, this should work to add the navigator later (not tested):
function addNavigatorTo(viewer) {
    viewer.navigator = new $.Navigator({
        id:                viewer.navigatorId,
        position:          viewer.navigatorPosition,
        sizeRatio:         viewer.navigatorSizeRatio,
        maintainSizeRatio: viewer.navigatorMaintainSizeRatio,
        top:               viewer.navigatorTop,
        left:              viewer.navigatorLeft,
        width:             viewer.navigatorWidth,
        height:            viewer.navigatorHeight,
        autoResize:        viewer.navigatorAutoResize,
        prefixUrl:         viewer.prefixUrl,
        viewer:            viewer,
        navigatorRotate:   viewer.navigatorRotate,
        crossOriginPolicy: viewer.crossOriginPolicy
    });

    var count = viewer.world.getItemCount();
    var i, tiledImage, bounds;
    for (i = 0; i < count; i++) {
        tiledImage = viewer.world.getItemAt(i);
        bounds = tiledImage.getBounds();
        options = {
            tiledImage: tiledImage,
            tileSource: tiledImage.source,
            x: bounds.x,
            y: bounds.y,
            width: bounds.width,
            height: bounds.height,
            clip: tiledImage.getClip(),
            opacity: tiledImage.getOpacity()
        };

        viewer.navigator.addTiledImage(options);
    }
}

That almost works, except for the navigator display region not showing until I interact with either the viewer or the navigator, and some console errors:

specifying both width and height to a tiledImage is not supported
$.TiledImage @ openseadragon.js:17018
event.options @ openseadragon.js:7908
(anonymous function) @ openseadragon.js:8663

Uncaught TypeError: Cannot read property 'getBounds' of undefined
$.extend._matchBounds @ openseadragon.js:10107
$.extend.success @ openseadragon.js:10080
event.options @ openseadragon.js:7963
(anonymous function) @ openseadragon.js:8663

I don't know when I will have time to try refactoring the navigator, so it is better if you don't count on me.

This seems to work (comments explain changes):
function addNavigatorTo(viewer) {
	var options = {
		id:                viewer.navigatorId,
		position:          viewer.navigatorPosition,
		sizeRatio:         viewer.navigatorSizeRatio,
		maintainSizeRatio: viewer.navigatorMaintainSizeRatio,
		top:               viewer.navigatorTop,
		left:              viewer.navigatorLeft,
		width:             viewer.navigatorWidth,
		height:            viewer.navigatorHeight,
		autoResize:        viewer.navigatorAutoResize,
		prefixUrl:         viewer.prefixUrl,
		viewer:            viewer,
		navigatorRotate:   viewer.navigatorRotate,
		crossOriginPolicy: viewer.crossOriginPolicy
	};

	viewer.navigator = new OpenSeadragon.Navigator(options);

	var count = viewer.world.getItemCount();
	var i, tiledImage, bounds;
	for (i = 0; i < count; i++) {
		tiledImage = viewer.world.getItemAt(i);
		bounds = tiledImage.getBounds();

		// Added originalTiledImage property to solve 'getBounds' error
		// Removed x, y, width, height, and clip properties, which solved
		// 'specifying both width and height to a tiledImage is not supported' error
		options = {
			originalTiledImage: tiledImage,
			tileSource: tiledImage.source,
			collectionImmediately: true,
			opacity: tiledImage.getOpacity()
		};

		viewer.navigator.addTiledImage(options);
	}

	// This needs to be in a timeout because viewer.navigator.world.items is
	// an empty array until $.Viewer.getTileSourceImplementation runs its own
	// timeout(..., 1), which in turn adds an item to viewer.navigator.world.
	setTimeout(function() {
		// sets the navigator display region element to display:block
		// only works if world.items is not empty
		viewer.navigator.update(viewer.viewport);
	}, 2);
}

Oh yes, thank you, I forgot originalTiledImage!
It may not be necessary for your use case, but for the general solution, the x, y, and width would be necessary; you just need to leave off the height.
Otherwise looks good. :)

authors: adgoncal iangilman


text:
[Feature Request] Support pre-aggregated data in Star Tree

Is your feature request related to a problem? Please describe
Coming here from this: https://github.com/opensearch-project/OpenSearch/pull/14512#discussion_r1678850554
There are cases where the users would want to ingest already aggregated data by specifying the _doc_count field. This way, during star-tree aggregation, we can account for the number of documents while calculating accurate metrics.
Describe the solution you'd like
Support for pre-aggregated data with Star Tree
Related component
Indexing:Performance
Describe alternatives you've considered
No response
Additional context
https://opensearch.org/docs/2.4/opensearch/bucket-agg/#account-for-pre-aggregated-data

[Indexing Triage Meeting 07/22]
@sarthakaggarwal97 Thanks for filing this. Please tag the issue with the release you're targeting this for.

https://github.com/opensearch-project/OpenSearch/issues/15288 -- with _doc_count support changes, we should solve this as well. so closing this.

repo: opensearch-project/OpenSearch


text:
Gradle clean failing after a failed gradle check, folders created by Docker under 'root' user

Signed-off-by: Andriy Redko andriy.redko@aiven.io
Description
the composeUp needs preProcessFixture to be executed before, otherwise the folders:
distribution/docker/build/logs/1
distribution/docker/build/logs/2

won't exists and will be created by Docker under root user:
drwxrwxr-x 3 user.user user.user 4.0K Nov 29 15:40 classes
drwxrwxr-x 4 user.user user.user 4.0K Nov 30 10:03 docker
drwxrwxr-x 3 user.user user.user 4.0K Nov 29 15:38 forbidden-apis-config
drwxrwxr-x 3 user.user user.user 4.0K Nov 29 15:40 generated
drwxrwxr-x 2 user.user user.user 4.0K Nov 29 15:45 heapdump
drwxr-xr-x 4 root         root         4.0K Dec 14 11:24 logs
drwxrwxr-x 2 user.user user.user 4.0K Nov 29 15:44 markers
drwxrwxrwx 2 user.user user.user 4.0K Dec 13 09:20 repo
drwxrwxr-x 4 user.user user.user 4.0K Nov 29 15:45 reports

Issues Resolved
Closes https://github.com/opensearch-project/OpenSearch/issues/1675
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock @VachaShah this one needs backport to 1.x, just checked it and it has the same issue

@reta this seems like ./gradlew clean should always fail. But folks see this only at random times, I dont quite understand why.

Not necessary, it essentially depends if Gradle needs to execute task preProcessFixture or it is not ("up to date"). So you could easily get into this situation by running a build, then cleaning some projects (gradle :distribution:docker:clean) and than running some tasks right after (gradle :distribution:docker:composeUp) - reproducible for me 100%.  I don't know exactly how @VachaShah run into that but it is not difficult.
But this is only one particular issue for distribution/docker module, there are others (but may be the cause is the same).

thanks for looking @saratvemulapalli

@reta this seems like ./gradlew clean should always fail. But folks see this only at random times, I dont quite understand why.

Not necessary, it essentially depends if Gradle needs to execute task preProcessFixture or it is not ("up to date"). So you could easily get into this situation by running a build, then cleaning some projects (gradle :distribution:docker:clean) and than running some tasks right after (gradle :distribution:docker:composeUp) - reproducible for me 100%. I don't know exactly how @VachaShah run into that but it is not difficult.
PS: Once the folders are created under root, the gradle clean will always fail, but usually folders are pre-created before by preProcessFixture task.
But this is only one particular issue for distribution/docker module, there are others (but may be the cause is the same).

Makes sense, thanks for the explanation.

Thanks @saratvemulapalli , did minor refactor to use configure properly, had weird Gradle behaviour for remote-clusters module, should be all good now

Thanks a lot @dblock , I will create backport to 1.x on Monday

authors: reta saratvemulapalli


text:
Disable WhiteSource check on 1.x PRs

Signed-off-by: Vacha Shah vachshah@amazon.com
Description
Disabling WhiteSource check since it is currently not working correctly on 1.x PRs.
Reference: https://whitesource.atlassian.net/wiki/spaces/WD/pages/697696422/WhiteSource+for+GitHub.com#Check-Run-Settings-(checkRunSettings)
Issues Resolved
Part of https://github.com/opensearch-project/OpenSearch/issues/1593#issuecomment-1058400217
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

start gradle check

@kotwanikunal @VachaShah for failing gradle checks, please do open the log, locate the problem, and either open a new issue or add a link to an existing one for the flakey test - this helps us track the worst offenders

Closing this PR since it still runs whitesource check.

authors: VachaShah dblock kotwanikunal


text:
[Extensions] Create writeable implementations for parser

Signed-off-by: Frank Lou mloufra@amazon.com

Description
Create writeable implementations for parser that implement both Function<String, T> and Writeable interfaces for all existing setting implementations that use parsers.
Issues Resolved
Fixes https://github.com/opensearch-project/opensearch-sdk-java/issues/349
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #6364 (c75da86) into main (c772596) will increase coverage by 0.30%.
The diff coverage is 68.34%.

:exclamation: Current head c75da86 differs from pull request most recent head 722515e. Consider uploading reports for the commit 722515e to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #6364      +/-   ##
============================================
+ Coverage     70.58%   70.89%   +0.30%
- Complexity    58841    59137     +296
============================================
  Files          4799     4799
  Lines        282421   282743     +322
  Branches      40717    40773      +56
============================================
+ Hits         199341   200438    +1097
+ Misses        66584    65885     -699
+ Partials      16496    16420      -76

Impacted Files
Coverage Δ

...g/opensearch/common/settings/WriteableSetting.java
70.43% <54.08%> (-20.23%)
:arrow_down:

...dex/store/remote/file/OnDemandBlockIndexInput.java
79.13% <61.81%> (+6.12%)
:arrow_up:

...n/java/org/opensearch/common/settings/Setting.java
86.08% <75.40%> (-4.17%)
:arrow_down:

...e/remote/file/OnDemandBlockSnapshotIndexInput.java
72.34% <100.00%> (+0.91%)
:arrow_up:

...rch/test/junit/listeners/ReproduceInfoPrinter.java
9.52% <0.00%> (-68.26%)
:arrow_down:

...ava/org/opensearch/action/NoSuchNodeException.java
0.00% <0.00%> (-50.00%)
:arrow_down:

...cluster/coordination/PendingClusterStateStats.java
20.00% <0.00%> (-48.00%)
:arrow_down:

.../org/opensearch/client/indices/AnalyzeRequest.java
27.00% <0.00%> (-47.00%)
:arrow_down:

...ensearch/discovery/InitializeExtensionRequest.java
0.00% <0.00%> (-40.00%)
:arrow_down:

.../admin/cluster/reroute/ClusterRerouteResponse.java
60.00% <0.00%> (-40.00%)
:arrow_down:

... and 514 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

authors: codecov-commenter mloufra