text:
Create Unit test to assert properties observed by Ember.observer()

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

tests/unit/mixins/sl-tooltip-enabled-test.js, line 274 [r1] (raw file):
A blank line needs to be added to the end of this file to pass linting.

Comments from the review on Reviewable.io

@juwara0 github doesnt show the empty line by default, it is present and has passed linting in the build. ready to merge.

@notmessenger: this is ready to merge

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io

authors: erangeles juwara0 notmessenger


text:
[BUG] Account creation docs are not accurate

What happened
Example imports:
from starknet_py.net.signer.stark_curve_signer import KeyPair

The correct import should be:
from starknet_py.net.signer.key_pair import KeyPair

Stack trace
docs issue
Steps to reproduce

SDK Version
0.24.3
Python version
3.9
What operating system are you using?
Linux
Is there an existing issue for this?

[ ] I have searched the existing issues and verified no issue exits for this problem.

Thanks for reporting @amanusk 👍

source: gharchive/issue

authors: amanusk franciszekjob

license: MIT

license_type: permissive

license_source: github-api


text:
Q116 Salary category has extra : at the end

The Other option has an extraneous :

Looks like some other questions also have Other: -- may be intentional?

repo: softwaresaved/international-survey


text:
请求返回值乱码问题

postman一个请求，workflow服务在Response的body添加数据出现乱码，有时乱码，有时正常：
添加之前打印正常，如图：

在postman中显示不正常，如果：

这种情况下你先看看你append的数据内容有没有问题，或者是不是你用nocopy的方式，然后内存被修改或回收了。这种太基础的错误不太可能是框架的bug。

有一次我也怀疑是这个问题，所以把变量定义成全局的了，但是还出现了这个问题，不知道原因是什么，

可以贴一下代码。

我用全局变量+nocopy的方式测试，返回有问题，但是将采用copy的方式，基本上不出现问题了，我先把问题关了，到时候再频繁出现问题，我就把代码粘上去，咱们一块看看

authors: Barenboim HzjFirst

repo: sogou/workflow


text:
Add Menma Coin

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

@Mergifyio refresh

source: gharchive/pull-request

repo: solana-labs/token-list


text:
ADD PMWL token

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

done


text:
Add Solana Ecosystem Index (SOLI) token

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

I can help refer this https://github.com/zakimzf/profile/pull/1
PS: if you don't need my help.. please ignore this!


text:
BonoboCoin token request

Please provide the following information for your token.
Please include change to the src/lib/.json and in the PR
At minimum each entry should have

Token Address: 6wJPSXCjWfRU91JGWVUFMUetwCZsbF4tCm3KY6KUUcFK
Token Name: BonoboCoin
Token Symbol: BONO
Logo: https://gateway.pinata.cloud/ipfs/QmcqF3wdSGy7X3UVzCQQ7mrpT44jcQJ27gwRez48yDxR3c
Link to the official homepage of token: http://bonobo.com/

No website.

authors: BonoboCoin bartosz-lipinski


text:
Add Orcish Dime

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

try again


text:
Test changes for property

consul_key_value currently don't update if there is changes in value because it is set to param instead of property
also protocol has no state within this type, so it shouldn't be property as well

btw i tested on my local environment, and it works. test case run fine on my local machine.
p.s. your acceptence testing doesn't seem to work properly. it seem it hit this issue https://github.com/voxpupuli/puppet-archive/issues/225 so tested the module change directly on real server instead

@solarkennedy @jk2l Is this resolved? If so, can we please merge this as this PR fixes an issue we are hitting.

tbh i am not sure did the author even read it...

I saw that the tests were failing and assumed you would be iterating.
I've rerun the tests and looks like it was something transient. Merging!

authors: jk2l nicholaspearson solarkennedy

repo: solarkennedy/puppet-consul

license_source: bigquery


text:
Add link to repository sidebar

https://docs.solidjs.com/start

Done!

SolidStart isn't in beta yet.. which is what this page says...tiny bit premature there. We need to be careful with messaging.

Ill change that to say its alpha and there are dragons.. maybe add a banner!

authors: boehs nksaraf ryansolid

repo: solidjs/solid-start


text:
createMemo should respect the equals value on its initial execution

A memo accept an initial value and the equals property via the options object to exert finer control over its update logic.  However it does not respect the equals property on its initial execution but it should for consistency.
For the following example,  'some value' should never be assigned to the memo as it is not a valid value.
import { createEffect, createSignal, createMemo } from 'solid-js';

const [preferences, setPreferences] = createSignal({
  lang: 'en', theme: 'some value', fontSize: 'large',
});

const theme = createMemo(() => preferences().theme, 'light', {
  equals: (prev, curr) => {
    if (prev === curr) return true;
    if (prev === 'dark' && curr === 'light') return false;
    if (prev === 'light' && curr === 'dark') return false;
    return true;
  }
});

createEffect(() => console.log(theme()));

But equals by definition compares the last value to the next one. As there is no last value initially, you would have to guard your comparison against it being undefined.
In your case, a filter for invalid values should be done within the derivation, not the equals function.

I know how it works but what is the point of having initial value if you don't utilize it, if you think about it, it is only logical to use the custom comparator function for the initial execution too. It better aligns with the behavior of a signal.

createMemo cannot know if you are intending to use the initial value or not.

createMemo cannot know if you are intending to use the initial value or not.

Please can you elaborate because I am not sure if I understand what do you mean by this sentence?
If current behaviour is OK, then what is the purpose of the initial value? More importantly what difference does it make if createMemo uses the equals value for the initial execution? Memo will be executed any way, equals controls if the returned value should replace the existing one, providing a consistent behavior.

This was merely an answer to your statement that having an initial value was pointless if you're not using it. But that's merely your preference based on a single case.
In Solid, Ryan usually aims for the most helpful, predictable and performant behavior. Since an initial equality comparison without a previous value will be unhelpful except for very few edge cases, totally unexpected and easily provoking errors and provides the worse performance, he chose not to apply it.

authors: atk snnsnn

repo: solidjs/solid


text:
Parallel Solidus branches in CI

A reprise of #33
Summary
Faster builds means faster developer feedback and thus faster development.

Checklist

[ ] I have structured the commits for clarity and conciseness.
[ ] I have added relevant automated tests for this change.
[ ] I have added an entry to the changelog for this change.

Nice stuff!

authors: aldesantis elia


text:
Order Discount Breakdown

Summary
Patches an erroneous order breakdown
More info: https://github.com/solidusio/solidus_paypal_commerce_platform/issues/191

Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:

[ ] I have written a thorough PR description.
[ ] I have kept my commits small and atomic.
[ ] I have used clear, explanatory commit messages.

The following are not always needed:

📖 I have updated the README to account for my changes.
📑 I have documented new code with YARD.
🛣 I have opened a PR to update the guides.
✅ I have added automated tests to cover my changes.
📸 I have attached screenshots to demo visual changes.

Hey @kennyadsl -- Re-opened on a new repo where I could write the tests locally, but I am indeed having trouble.
I followed the steps in the readme and ran bin/rake from the root of the extension directory, this created the dummy-app correctly it appears.
However when run bin/rake again from the root I get 0 tests to run. If I cd into the dummy app and run rspec same issue, I tried something like rspec ../spec from within the dummy app and appears to pick up the tests but doesn't run them.
Apologies but -- how do I run the tests on a Solidus extension I would absolutely love to know so I can be of better help to the project : )

I can run specs with bin/rspec spec from the root. Sorry for the confusion in the README, I'm going to update it.

BTW, bin/rake also works for me from the root. It executes all specs correctly after creating the dummy app. Can you please post the full output of the command? Better if you remove the dummy-app folder before trying again to have the full logs. Thanks!

Hmm -- that's so weird, here are my results:
➜  solidus_paypal_commerce_platform git:(bug/order_discount_breakdown) ✗ bin/rspec spec
Could not find generator 'solidus_paypal_commerce_platform:install'.
Run `bin/rails generate --help` for more options.
No examples found.

Finished in 0.00079 seconds (files took 0.05221 seconds to load)
0 examples, 0 failures

/Users/jacobpenn/jacobpenn/Development/Minimal/solidus_extensions/solidus_paypal_commerce_platform

Here's my bin/rake output:
➜  solidus_paypal_commerce_platform git:(bug/order_discount_breakdown) ✗ bin/rake
To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
bin/rspec
Creating the dummy-app app...
      create
      create  README.md
      create  Rakefile
      create  .ruby-version
      create  config.ru
      create  Gemfile
      create  app
      create  app/assets/config/manifest.js
      create  app/assets/stylesheets/application.css
      create  app/channels/application_cable/channel.rb
      create  app/channels/application_cable/connection.rb
      create  app/controllers/application_controller.rb
      create  app/helpers/application_helper.rb
      create  app/jobs/application_job.rb
      create  app/mailers/application_mailer.rb
      create  app/models/application_record.rb
      create  app/views/layouts/application.html.erb
      create  app/views/layouts/mailer.html.erb
      create  app/views/layouts/mailer.text.erb
      create  app/assets/images
      create  bin
      create  bin/rails
      create  bin/rake
      create  bin/setup
      create  config
      create  config/routes.rb
      create  config/application.rb
      create  config/environment.rb
      create  config/cable.yml
      create  config/puma.rb
      create  config/storage.yml
      create  config/environments
      create  config/environments/development.rb
      create  config/environments/production.rb
      create  config/environments/test.rb
      create  config/initializers
      create  config/initializers/assets.rb
      create  config/initializers/content_security_policy.rb
      create  config/initializers/cors.rb
      create  config/initializers/filter_parameter_logging.rb
      create  config/initializers/inflections.rb
      create  config/initializers/new_framework_defaults_7_0.rb
      create  config/initializers/permissions_policy.rb
      create  config/locales
      create  config/locales/en.yml
      create  config/master.key
      create  config/boot.rb
      create  config/database.yml
      create  db
      create  db/seeds.rb
      create  lib
      create  lib/tasks
      create  lib/assets
      create  log
      create  public
      create  public/404.html
      create  public/422.html
      create  public/500.html
      create  public/apple-touch-icon-precomposed.png
      create  public/apple-touch-icon.png
      create  public/favicon.ico
      create  public/robots.txt
      create  tmp
      create  tmp/pids
      create  tmp/cache
      create  tmp/cache/assets
      create  vendor
      create  storage
      create  tmp/storage
      remove  config/initializers/cors.rb
      remove  config/initializers/new_framework_defaults_7_0.rb
         run  bundle install
Fetching gem metadata from https://rubygems.org/...........
Resolving dependencies....
Using rake 13.0.6
Using concurrent-ruby 1.2.2
Using minitest 5.18.0
Using thor 1.2.1
Using zeitwerk 2.6.7
Using sqlite3 1.6.1 (x86_64-darwin)
Using i18n 1.12.0
Using tzinfo 2.0.6
Using nio4r 2.5.8
Using websocket-extensions 0.1.5
Using marcel 1.0.2
Using mini_mime 1.1.2
Using date 3.3.3
Using timeout 0.3.2
Using bindex 0.8.1
Using net-protocol 0.2.1
Using io-console 0.6.0
Using net-imap 0.3.4
Using reline 0.3.2
Using builder 3.2.4
Using irb 1.6.3
Using crass 1.0.6
Using debug 1.7.1
Using activesupport 7.0.4.3
Using websocket-driver 0.7.5
Using puma 5.6.5
Using bundler 2.2.27
Using net-pop 0.1.2
Using net-smtp 0.3.3
Using method_source 1.0.0
Using mail 2.8.1
Using erubi 1.12.0
Using rack 2.2.6.4
Using globalid 1.1.0
Using rack-test 2.1.0
Using activejob 7.0.4.3
Using sprockets 4.2.0
Using activemodel 7.0.4.3
Using racc 1.6.2
Using activerecord 7.0.4.3
Using nokogiri 1.14.2 (x86_64-darwin)
Using rails-dom-testing 2.0.3
Using loofah 2.19.1
Using rails-html-sanitizer 1.5.0
Using actionview 7.0.4.3
Using actionpack 7.0.4.3
Using jbuilder 2.11.5
Using actioncable 7.0.4.3
Using activestorage 7.0.4.3
Using actionmailer 7.0.4.3
Using actionmailbox 7.0.4.3
Using sprockets-rails 3.4.2
Using actiontext 7.0.4.3
Using railties 7.0.4.3
Using importmap-rails 1.1.5
Using rails 7.0.4.3
Using stimulus-rails 1.2.1
Using turbo-rails 1.4.0
Using web-console 4.2.0
Bundle complete! 11 Gemfile dependencies, 59 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
         run  bundle binstubs bundler
       rails  importmap:install
Add Importmap include tags in application layout
      insert  app/views/layouts/application.html.erb
Create application.js module as entrypoint
      create  app/javascript/application.js
Use vendor/javascript for downloaded pins
      create  vendor/javascript
      create  vendor/javascript/.keep
Ensure JavaScript files are in the Sprocket manifest
      append  app/assets/config/manifest.js
Configure importmap paths in config/importmap.rb
      create  config/importmap.rb
Copying binstub
      create  bin/importmap
       rails  turbo:install stimulus:install
Import Turbo
      append  app/javascript/application.js
Pin Turbo
      append  config/importmap.rb
Enable redis in bundle
        gsub  Gemfile
         run  bundle install
Fetching gem metadata from https://rubygems.org/..........
Resolving dependencies...
Using rake 13.0.6
Using concurrent-ruby 1.2.2
Using minitest 5.18.0
Using builder 3.2.4
Using erubi 1.12.0
Using racc 1.6.2
Using crass 1.0.6
Using rack 2.2.6.4
Using nio4r 2.5.8
Using websocket-extensions 0.1.5
Using marcel 1.0.2
Using mini_mime 1.1.2
Using date 3.3.3
Using timeout 0.3.2
Using bindex 0.8.1
Using bundler 2.2.27
Using io-console 0.6.0
Using method_source 1.0.0
Using reline 0.3.2
Using zeitwerk 2.6.7
Using irb 1.6.3
Using sqlite3 1.6.1 (x86_64-darwin)
Using debug 1.7.1
Using tzinfo 2.0.6
Using nokogiri 1.14.2 (x86_64-darwin)
Using rack-test 2.1.0
Using loofah 2.19.1
Using net-protocol 0.2.1
Using rails-html-sanitizer 1.5.0
Using net-imap 0.3.4
Using sprockets 4.2.0
Using redis 4.8.1
Using i18n 1.12.0
Using websocket-driver 0.7.5
Using activesupport 7.0.4.3
Using net-pop 0.1.2
Using rails-dom-testing 2.0.3
Using thor 1.2.1
Using actionview 7.0.4.3
Using globalid 1.1.0
Using actionpack 7.0.4.3
Using activejob 7.0.4.3
Using actioncable 7.0.4.3
Using railties 7.0.4.3
Using activemodel 7.0.4.3
Using importmap-rails 1.1.5
Using activerecord 7.0.4.3
Using puma 5.6.5
Using activestorage 7.0.4.3
Using stimulus-rails 1.2.1
Using actiontext 7.0.4.3
Using net-smtp 0.3.3
Using web-console 4.2.0
Using mail 2.8.1
Using jbuilder 2.11.5
Using actionmailbox 7.0.4.3
Using sprockets-rails 3.4.2
Using actionmailer 7.0.4.3
Using turbo-rails 1.4.0
Using rails 7.0.4.3
Bundle complete! 12 Gemfile dependencies, 60 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
Switch development cable to use redis
        gsub  config/cable.yml
Create controllers directory
      create  app/javascript/controllers
      create  app/javascript/controllers/index.js
      create  app/javascript/controllers/application.js
      create  app/javascript/controllers/hello_controller.js
Import Stimulus controllers
      append  app/javascript/application.js
Pin Stimulus
Appending: pin "@hotwired/stimulus", to: "stimulus.min.js", preload: true"
      append  config/importmap.rb
Appending: pin "@hotwired/stimulus-loading", to: "stimulus-loading.js", preload: true
      append  config/importmap.rb
Pin all controllers
Appending: pin_all_from "app/javascript/controllers", under: "controllers"
      append  config/importmap.rb
Unknown switches "--github"
Did you mean?  "--git"
Dropped database 'db/development.sqlite3'
Database 'db/test.sqlite3' does not exist
Created database 'db/development.sqlite3'
Created database 'db/test.sqlite3'
Could not find generator 'solidus:install'.
Run `bin/rails generate --help` for more options.
Unknown switches "--path"
Could not find generator 'solidus_paypal_commerce_platform:install'.
Run `bin/rails generate --help` for more options.
Could not find generator 'solidus_paypal_commerce_platform:install'.
Run `bin/rails generate --help` for more options.
No examples found.

Finished in 0.00087 seconds (files took 0.05113 seconds to load)
0 examples, 0 failures

/Users/jacobpenn/jacobpenn/Development/Minimal/solidus_extensions/solidus_paypal_commerce_platform

Still results in:
➜  solidus_paypal_commerce_platform git:(bug/order_discount_breakdown) ✗ bin/rspec spec
Could not find generator 'solidus_paypal_commerce_platform:install'.
Run `bin/rails generate --help` for more options.
No examples found.

Finished in 0.0008 seconds (files took 0.0507 seconds to load)
0 examples, 0 failures

/Users/jacobpenn/jacobpenn/Development/Minimal/solidus_extensions/solidus_paypal_commerce_platform

That's so weird... Just to be sure, is bug/order_discount_breakdown based against the latest code in master?

What is which bin/rspec & which bin/rake return? Maybe you have those aliased to bundle exec ...?

Yeah... I'm still stumped, I rebased this off of master and then deleted and redid the process locally, bin/rake still resulted in 0 tests being run.
➜  solidus_paypal_commerce_platform git:(bug/order_discount_breakdown) which bin/rake
bin/rake

➜  solidus_paypal_commerce_platform git:(bug/order_discount_breakdown) which bin/rspec
bin/rspec

I know I'm a bit slow here but when I get another chance I'm down to put some binds in places and step through to find the issue, I just don't really know much about how rspec boots.

I'd still love to get this merged.. :/

@jakemumu did you try debugging with https://github.com/solidusio/solidus_paypal_commerce_platform/pull/193#issuecomment-1469983907?

@waiting-for-dev thanks yeah I tried it here: https://github.com/solidusio/solidus_paypal_commerce_platform/pull/193#issuecomment-1518886635 - whichever combination with bundle or not wasn't pulling the tests for some reason -- I'll give it another try when I get a chance but this I'm surprised others aren't having this issue -- it's a pretty critical patch for us.

@jakemumu I'm looking to see if I can move this forward.

@jakemumu I rebased this PR against a branch that allows specs to pass (locally only, we are still waiting for selenium/capybara to fix their problem) and added a commit with a test for the fix.
I will rebase and squash everything in a single commit once we have the spec green, then I'll craft a release for this. Thanks for your help!

🥳 🥳 🥳 🥳  -- thanks so much @kennyadsl -- apologies I wasn't able to fully push that one over the finish line, really appreciate you helping get it there!

@jakemumu no problem, I'm here to help!

authors: jakemumu kennyadsl waiting-for-dev


text:
codegen: remove conditional enabling of internal CRDs

Internal CRDs are an implementation detail and must not be exposed to end users to enable/disable.

Will introduce feature specific conditions.


text:
Translate Docker mount path from "C:\xxx" to "/c/xxx" for Docker Toolbox on Windows.

Fix: https://github.com/solo-io/unik/issues/167

thanks for this

authors: hsluoyz ilackarms

repo: solo-io/unik


text:
Bug: [Nav] Mobile nav responsiveness issue.

If nav left open on mobile, it remains 100vh if browser adjusted to desktop.

This is a subtask of #3

Other notes for fixing the ui bugs:

if started at desktop & shrinking to mobile, the duplicated text effects are not hided


text:
🛑 Lower Barriers is down

In 3733569, Lower Barriers (https://lowerbarriers.org) was down:

HTTP code: 504
Response time: 2302 ms

Resolved: Lower Barriers is back up in 67609d1 after 14 minutes.

repo: solve-it-once/upptime


text:
Use implementation configuration instead of compile for Kotlin DSL

Replace old compile configuration with new implementation for Gradle Kotlin DSL

Fixes #72

LGTM +1

authors: SirMaster gildor


text: CS 1.6 3266

repo: sonicsnes/node-gamedig

license: mit


text:
/user/username/overview

https://www.reddit.com/dev/api#GET_user_{username}_overview

80ccf65fec3d4a1b4b465d33999cd3f23d3e036a

repo: sonsongithub/reddift


text:
[Bug]: Incorrect display of buttons on the "Edit view" screen

Preconditions
Check for both styles
Steps to reproduce
Wallet screen -> Edit view
Actual behavior
Incorrect display of buttons on the "Edit view" screen.
The last line is empty with a flag on the edit view screen (wallet backup and Buy XOR are missing) and the same on both styles.

Expected behavior
Add "Wallet backup" and "Buy XOR" buttons to Edit View as in the Android example, and generally set the order correctly.

Environment
{"label"=>"Development"}
OS version
17.7
Additional context
It is not advisable to add backup, unfortunately there are more priority tasks now

Verified on 38.7(2) version.

repo: sora-xor/sora-card-ios


text:
Add remaining signed extensions

fix signed extension and refactor extrinsic tests

Does this new PrevalidateAttests check introduce any new fields? I dont see any in changes

Does this new PrevalidateAttests check introduce any new fields?

Nope. Actually, it wasn't a good idea to support extensions which don't require any input from extrinsic creation point of view. Will refactor later.

authors: ERussel valentunn

repo: soramitsu/fearless-utils-iOS


text:
wip: Add a sig for NilClass#to_i

Motivation

Test plan

See included automated tests.

wip pending testing on stripe's codebase

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_MCzz9XD6nw3303
→ https://go/builds/bui_MD00OLBcSk34nS

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_MD2jYeVn5ZY29l
→ https://go/builds/bui_MD2jgekOoCV4Po

repo: sorbet/sorbet


text:
Configure VSCode extension to default to formatting on save when available

This reconfigures the VSCode to support formatOnSave for Ruby out-of-the-box. This modifies the extension to stub formatting requests if formatting isn't supported by the running LSP and to default the VSCode configuration to formatOnSave to true for the extension.
Motivation

As we roll out format-on-save internally at Stripe, we still need a way for users to opt out if they want to. However, workspace settings will override user settings in many cases. Making the extension pass this as a default allows us to make the setting overridable by users.
Test plan

See included automated tests. I also manually ran the VSCode extension on a small sandbox repo and confirmed that format on save turns off when either the VSCode configuration is overridden or when --enable-experimental-lsp-document-formatting-rubyfmt is not passed to the LSP. I also verified that the default configuration works when nothing is overridden.

The command line flag is almost certainly not what users will use. The option we'd suggest to users would be to add "sorbet.enableDocumentFormatting": false in their user settings instead (which is handled directly in the VSCode plugin). The command line flag would be intended for the initial rollout only, where we'd have it behind a dev feature flag that we could turn off if needed.
I agree that ideally we wouldn't turn off document formatting entirely -- if there's some LSP interaction specific format-on-save, I'd be happy to rework this to only stub that instead of document formatting as a whole, but my reading of how this interaction is handled by VSCode is that it just calls the document formatting provider for the given file. As far as I know (and again, happy to be told otherwise), format-on-save in VSCode isn't really propagated through the LSP, it's just making a formatting request pre-save.
The other alternative is indeed to do it in the VSCode workspace, but workspace settings in VSCode can't be overriden by user settings, so if we set the config in the workspace without an alternative workaround, there's no other way for users to be able to opt-out.

I ended up updating this with the second approach (checking the server capabilities during initialization and stubbing if document formatting isn't enabled). I don't feel particularly strongly about that position, but it involves the least-surprising changes to anyone who may use the LSP outside of VSCode and it means that anyone who runs the LSP over a network connection doesn't incur an extra penalty for saves. Happy to look at alternatives if this change doesn't pan out as we'd expect.


text:
Annual audit of TODO(jez)

Motivation

A lot of these I just don't care about anymore. Some of them are
actually fine.
Test plan

n/a

Current dependencies on/for this PR:

master

PR #6601   👈

This comment was auto-generated by Graphite.


text:
Feature/subscription cancel

This PR includes the work from the subscription find branch as well, but I figured since we're in different time zones it might help you if I submit this PR as well and if all goes well perhaps both features might make it in by the time I wake up tomorrow 😄

Added assertions as you described. Also noticed I'd left off the integration module tag for plans in a previous PR so I've fixed that as well.

repo: sorentwo/braintree-elixir


text:
Fix clipping, additive blending, color order

This pull request address changes to linear_bgr implementation, interface, and tests. This pull request renames linear_bgr to composite_channels.

The tests also now expect the output to be a float32 RGB array with values between 0 and 1.
The tests have been updated for addition instead of averaging when blending channels.
The tests now expect values above the maximum to be clipped at 1 instead of 0.

This fixes #16
- Values above the maximum are now set to one, not zero
This fixes #15
- Our tests document skimage RBG order and depend on skimage for threshholding/normalization
This fixes #14
- All the input ranges and colors are clearly documented as within 0, 1
This fixes #18
- All tests construct typed arrays using np.array(*, dtype=*)
While the input argument channels must be a list, the function composite_channel can be used in a custom implementation of a function such as composite_channels to handle iterators and queues.

When I merged the skimage function calls Jeremy's branch, I didn't include gamma-correction. I wanted to make sure all tests pass without gamma correction. Now, we'll need to write new tests to account for gamma correction.

We should update the version number in setup.cfg because our output interface has changed from linear_bgr returning uint8 to linear_rbg returning float32.

Here are memory/time measurements for combining 4 channels at the current state of this PR:

We're using 168 mib of RAM to process 132 mib of image data.

Unit tests for clipping in clip_image:
tests/blend.py::test_clip_image_range_all PASSED                                                                                [ 10%]
tests/blend.py::test_clip_image_range_high PASSED                                                                                [ 20%]
tests/blend.py::test_clip_image_range_low PASSED                                                                                [ 30%]

Unit tests for color in make_rgb:
tests/blend.py::test_make_rgb_color_red PASSED                                                                                [ 40%]
tests/blend.py::test_make_rgb_color_white PASSED                                                                                [ 50%]
tests/blend.py::test_make_rgb_color_khaki PASSED                                                                                [ 60%]

Integration tests for inputs, clipping, coloring, and gamma in linear_rgb.
tests/blend.py::test_linear_rgb_khaki_low PASSED                                                                                [ 70%]
tests/blend.py::test_linear_rgb_two_channel PASSED                                                                                [ 80%]
tests/blend.py::test_linear_rgb_size_mismatch PASSED                                                                                [ 90%]
tests/blend.py::test_linear_rgb_size_zero PASSED

@thejohnhoffer We'll meet and go over these on Monday and then we should be good to go.

@thejohnhoffer If you can integrate Jeremy's most recent comments then I think we can get this merged.

authors: dpwrussell thejohnhoffer

repo: sorgerlab/minerva-lib-python


text:
Fix for visual glitch when schema name wider than 250px

Hi, appreciate this is something of an edge case, but where I work we break large quantities of public statistical data into different schemas in a single Postgres instance. Some of these schema names are long, as they list the organisation we got the data from and what it is - eg ons_uk_balance_of_trade_payments_quarterly
This unfortunately causes a minor visual glitch in pgweb: the schema name drops onto the next line and obscures the icon, like this:

This change just adds a white-space: nowrap to the schema name, which is the same approach taken in the table names to stop this problem. With the patch applied it loks like this:

Does your change allow to scroll the list horizontally?

It does. Do you want me to disable that?

No, its all good. Just add the missing semicolon in css file and should be
good to go.
On Wed, Dec 4, 2019 at 11:47 AM Jim Smith notifications@github.com wrote:

It does. Do you want me to disable that?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/sosedoff/pgweb/pull/448?email_source=notifications&email_token=AAARLC7KGEN7S3ORKQVL3ULQW7ULLA5CNFSM4JVKCMNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF546IY#issuecomment-561762083,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAARLC6ZJSBNHQYXH2O3ZWLQW7ULLANCNFSM4JVKCMNA
.

--
Dan Sosedoff
dan.sosedoff@gmail.com
312.576.1330

Sure. I’ll get that updated in the next hour

Done

🙇

repo: sosedoff/pgweb


text:
Agent mode and omniscient mode

The current chat mode for humans should be agent mode (we give them limited info and don't allow them to change things)
Let's have another chat mode we allow humans to see everything and all the info is editable.

Do we want the scenario to be editable in free-form? Or we provide some editable fields to ensure the background format is correct

I think for now let's just do the free form thing

Re your point in the slack,
class EpisodeLog(JsonModel):
    # Note that we did not validate the following constraints:
    # 1. The number of turns in messages and rewards should be the same or off by 1
    # 2. The agents in the messages are the same as the agetns

    environment: str = Field(index=True)
    agents: list[str] = Field(index=True)
    tag: str | None = Field(index=True)
    models: list[str] | None = Field(index=True)
    messages: list[list[tuple[str, str, str]]]  # Messages arranged by turn
    reasoning: str
    rewards: list[tuple[float, dict[str, float]] | float]  # Rewards arranged by turn
    rewards_prompt: str

what if we initiate a special pseudo pk for the user-created environment and agent? If we are not planning to store the user-created environment and agent?

That makes sense but what if the user got disconnected? We have to handle it either.
After checking the render_for_human I found no primary key is needed, so that should not be a problem right now

authors: XuhuiZhou bugsz

repo: sotopia-lab/sotopia-demo


text:
WIP: Fetch assessments

Features

AssessmentOverviews are now fetched from the backend
Assessments are now fetched from the backend

Todos

[ ] Fix runtime errors.

Pull Request Test Coverage Report for Build 316

9 of 31 (29.03%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.09%) to 26.112%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sagas/backend.ts
9
31
29.03%

Files with Coverage Reduction
New Missed Lines
%

src/sagas/backend.ts
1
34.78%

Totals

Change from base Build 310:
0.09%

Covered Lines:
720

Relevant Lines:
2343

💛  - Coveralls

@remo5000 Bump

There is a new .env variable defined in the .env.example file, REACT_APP_USE_BACKEND. If it is empty, the mock assessments will be used. Otherwise, the saga will make actual backend calls to the given REACT_APP_BACKEND_URL.

authors: coveralls ningyuansg

repo: source-academy/cadet-frontend


text:
AWS GitHub Actions CI

[ ] Deploy to dev on push
[ ] Manual deploy to prod
[ ] Deploy to prod on merge

We have permission!

repo: sourceallies/hacker-rank-queue


text:
ComboBox Itemsource

When use ComboboxRevealStyle, display member path is not show in comboBox popup.

Thanks for the feedback. I could reproduce it, and fixed it.
It will included in FluentWPF 0.10.0.

authors: farhadala sourcechord

repo: sourcechord/FluentWPF


text:
[Snyk] Upgrade @loopback/core from 6.0.0 to 6.0.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade @loopback/core from 6.0.0 to 6.0.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 21 days ago, on 2024-04-09.

Release notes

Package name: @loopback/core

6.0.1 - 2024-04-09@ loopback/tsdocs@6.0.1

6.0.0 - 2024-03-04

    from @loopback/core GitHub release notes

Commit messages

Package name: @loopback/core

2bdb95f chore: publish release
5839f5e refactor(sequelize): use flag on SequelizeDataSource for JSON parsing
de82454 chore: remove redundant assertion
26b1277 test(sequelize): add test coverage for JSON parsing for mysql
6b0d0fb refactor(sequelize): restrict the JSON parse to mysql dialect
7b8e193 fix(sequelize): parse JSON columns to objects for non-Postgres dialects
d129a5f chore: update dependency @ types/node to ^16.18.95
c818e38 chore: update lint packages to ^7.6.0
d79e95d chore: update dependency loopback-connector-soap to ^8.0.5
c5dc9e3 chore: update dependency loopback-connector-postgresql to ^7.1.0
f259203 chore: update dependency swagger-ui-dist to v5.14.0
b82b1ea chore: update github/codeql-action action to v3.24.10
0f139e1 chore: update dependency loopback-connector-mysql to ^7.0.9
33a1961 chore: update dependency path-to-regexp to ^6.2.2
2c459f7 chore: update dependency eslint-plugin-eslint-plugin to ^5.5.1
24fc8dd chore: update dependency loopback-datasource-juggler to ^5.0.8
b192cf1 chore: update dependency sequelize to ^6.37.2
96c127a chore: update dependency @ types/node to ^16.18.94
71c11a6 chore: update dependency express to ^4.19.2
b226e7d chore: update dependency @ types/serve-static to v1.15.7
cd25c58 chore: update dependency mocha to ^10.4.0
d13aa15 chore: update dependency testcontainers to ^10.8.1
211d601 chore: update dependency webpack to ^5.91.0
14051e4 chore: update dependency glob to ^10.3.12

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Part of https://github.com/sourcefuse/loopback4-helmet/pull/121

authors: karuneshsf yeshamavani


text:
JetBrains: Cody: Implement caching for completions

Completions in the JetBrains plugin still are a bit slow, despite our ongoing efforts.
We could speed them up by implementing (even rudimentary) caching.
It would also help to make them more predictable, as there currently is some RNG to what we get (the idea is for the user to get the same suggestion when going back to the same context).

Closing this as wontfix since headless cody implements caching for us

authors: Gedochao olafurpg

repo: sourcegraph/cody


text:
Cody readily hallucinates Sourcegraph App is available for Windows

Sourcegraph version: VScody 0.1.3

Steps to reproduce:

Ask Cody whether Sourcegraph App is available for Windows.

Expected behavior:
Cody says something apologetic about it not being available with a link to an email list or something.
Maybe we should not promote App when running on Windows.
Actual behavior:
Cody says it is available without any context.

This is now fixed

authors: dominiccooney jdorfman


text:
Agent: handle document URIs with exclamation marks

Previously, the agent threw an error for textDocument/* notificattions when the URI included an exclamation mark. The error was thrown to preserve an important variant that we can always parse and render a URI back into the original string
vscode.Uri.parse(uri).toString() === uri

This variant was getting violated when the JB plugin sent document URIs that included an exclamation mark in them, for example:
file:///Users/com.jetbrains/ideaIC-2022.1-sources.jar!/com/intellij/RequiresBackgroundThread.java

The ! got encoded as %21. This PR "fixes" the problem by mutating the uri: string property to get the Uri.toString() formatted URI. t's not a super satisfying solution, it would be more desirable if we can get vscode.Uri.parse(..).toString() to be a safe roundtrip. However, this change gets the most important job done: we preserve the invariant.
Test plan
See updated tests.

huh, strange... I still see a similar error:
2024-01-31 21:27:04,842 [ 558131]   WARN - #c.s.c.a.CodyAgentClient - Cody by Sourcegraph: █ ProtocolTextDocumentWithUri: correcting invariant violation file:///Users/mkondratek/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIC/2022.1/4aa17d162c81293d88aa56a54f655e784a8ba8ab/ideaIC-2022.1-sources.jar%21/com/intellij/util/concurrency/FutureResult.java (this.uri) !== file:///Users/mkondratek/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIC/2022.1/4aa17d162c81293d88aa56a54f655e784a8ba8ab/ideaIC-2022.1-sources.jar!/com/intellij/util/concurrency/FutureResult.java (this.underlying.uri)

However the context (the selection) is passed properly and the response looks good.

authors: mkondratek olafurpg


text:
Smart Apply: Implement stateful UI

Description
This PR adds stateful UI to the smart apply feature:

Loading state -> "Applying"
Applied state -> "Accept" | "Reject"

It includes this behaviour:

Loading: Display an animated spinner and disable the button
Accept: Accept the edit in the document on click
Reject: Reject the edit in the document on click
Error: Open the error message in the editor on click

UI States
Default

Loading (Applying)

Finished (Applied)

Test plan

Start a smart apply
Expect that the "Applying" state shows
Expect that clicking "Applying" does nothing
Expect that the smart apply applies correctly
Expect that "Apply" "Reject" shows
Expect that the associated button either accepts or rejects the edit

Thanks @abeatrix!

I did notice there is a lag between the "Applying" and the codelenses showing up in the Editor -- is this expected?

Right now yeah, it's because "Applying" starts when we try to find the selection in the file, but the codelens is from the inline edit which only starts once we have that selection. If I have time in a future PR, I might look at adding a codelens in the early stage, although it'd show at the top of the file

When I rejected the change, it would select the wrong section of the code after the change has been reverted

Interesting, nothing here should affect the selection so this is possibly a bug with inline edit. I'll see if I can replicate on main


text:
(promote) release: build v5.4.0

Test plan: automated release PR, CI will perform additional checks

:green_circle: Release has been promoted, see tag: https://github.com/sourcegraph/deploy-sourcegraph-k8s/tree/v5.4.0.
:no_entry: Do not under any circumstance delete the branch holding the tagged commit (i.e. release-v5.4.0).
:arrow_right: You can safely close that PR and delete its a associated branch.

authors: BolajiOlajide sourcegraph-buildkite


text:
feat(tests) - add lang heuristics testing

most of them are blind todos for now

I shouldn't have to put all those files within code changes. So here are the files you need to check:
src/test/kotlin/test/tests/extractors/HeuristicsTest.kt
build.gradle
src/main/kotlin/app/extractors/Heuristics.kt

repo: sourcerer-io/sourcerer-app


text:
Install travis ci

The system has become to complex.
UnitTests are needed to support upcoming refactoring / clean ups.
First let's setup the CI.
Check:

phpunit (all scenarios)
behat (all scenarios)

On:

PHP 5.5
PHP 5.6
PHP 7

YAY!!!

repo: sourcerer-mike/crmp


text:
RFE: Simple install instructions

I was trying to install using install.sh, and it did nothing (see https://github.com/radiasoft/zgoubi/issues/90). @rouson suggested I build off master, which did work, but only after I figured that you can do things much more simply.
There are many different install instructions. INSTALL.md starts off with Developer Build and Install with these instructions:
mkdir opencoarrays-build
cd opencoarrays-build
export FC=/path/to/gfortran
export CC=/path/to/gcc
cmake /path/to/OpenCoarrays/source \
  -DCMAKE_INSTALL_PREFIX=/path/to/desired/installation/location
make
make test # optional; verify build works
make install

However, this is atypical and doesn't work with copy and past, especially for the "impatient" like me. I found that this works:
git clone https://github.com/sourceryinstitute/OpenCoarrays
cd OpenCoarrays
mkdir build
cd build
cmake ..
make
make test # optional; verify build works
sudo make install

You could add more advanced instructions after this, but on a typical distro, cmake will find everything automatically. If the user doesn't have sudo privs, you could have another section explaining how to change the install prefix and so on.

Thanks, @robnagler.  I'll make the suggested edits.

authors: robnagler rouson

repo: sourceryinstitute/OpenCoarrays


text:
Adopt Cookbook

Description
Standardise everything
Signed-off-by: Jason Field jason@avon-lea.co.uk
Issues Resolved
#31
Check List

[ ] All tests pass. See TESTING.md for details.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable.

          1 Warning

:warning:
This is a big Pull Request.

  Generated by :no_entry_sign: Danger

And done

@damacus could you look at that one failing test on the rhel style boxes, it is System Package nfs-utils which works fine on a full fat vm, so it must be a dokken thing, however if I run dokken on my laptop is crashes :(

I can do tomorrow. Knee deep in bridge :)

Please allow chef-12.21 to still run

Plan to issue another PR after this to move around documentation and examples, but want to get something shipped.

v2.3.0 shipped

authors: Xorima damacus kitchen-porter nvwls

repo: sous-chefs/autofs


text:
Remove .rubocop.yml with Dangerfile

:speaking_head: Foreword
Thank for taking the time to fill this bug report fully. Without it we may not be able to fix the bug, and the issue may be closed without resolution.
:ghost: Brief Description
If the only thing in the .rubocop/yml is Dangerfile
Run the latest cookstyle
Remove .rubpopo.yml
Issue sprouted from sous-chefs/meta/issues/108. If not applicable then issue should be closed.

Completed with updates from sous-chefs/repo-management

authors: PowerSchill mbaitelman

repo: sous-chefs/bsdcpio


text:
Add the between filter

Description
Adds the between filter to allow inserting between matches
Issues Resolved
[List any existing issues this PR resolves]
Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

This change is

thanks again.  Two more filters, update and merge the doc and then release it.

repo: sous-chefs/line


text:
Automated PR: Standardising Files

This PR will standardise the files we have with out agreed spec in sous-chefs/repo-management.
This repo has been identified by topic(s) of chef-cookbook

Released as: 2.10.9

repo: sous-chefs/openssh


text:
Specify xcconfig path issue

Hi Sergii,
I having issue running fastlane:
Couldn't find xcconfig file at path '../../Configs/Base.xcconfig'
Is it possible to specify path like this? My "Configs" folder is outside of fastlane directory.
This is my source code:
private_lane :update_app_group_identifier do
    update_xcconfig_value(
      path: '../../Configs/Base.xcconfig',
      name: 'APP_GROUP_ID',
      value: ENV['APP_GROUP_ID']
    )
  end

Thanks,
Roman

+1
path: '../MY_PROJECT_NAME/Supporting\ Files/Config/Config.xcconfig'
it doesn't work for me either

Fastfile is plain ruby script and you're free to use ruby utils there. Try
"#{DIR}/../MY_PROJECT_NAME/Supporting Files/Config/Config.xcconfig"
If you're trying to resolve path relative to the current file's path.

authors: logalize romanbaitaliuk sovcharenko

repo: sovcharenko/fastlane-plugin-xcconfig


text:
Fix/issued creds list of a deleted connection

this pr changes list issued credential tab to use a connection id instead of retrieving the label from a list of connections.
when you delete a connection, the lookup fails, and no connections are listed as a result.
A better solution is needed, but an ugly working UI is better than a broken tool.

this pr has been updated to keep previous functionality. if a connection has been deleted it will be listed with "connection deleted" as the label.

repo: sovrin-foundation/aries-toolbox


text:
Integrate lapin-futures with actix

Hi! I'm trying to integrate lapin-futures with actix-web to simultaneously handle subscription to rabbitmq queue, database connection and REST API to work with database.
I've succeeded only with such approach: start this code in the new thread with thread::spawn. If start this code without thread::spawn It ignores actix-web at all: only lapin-futures starts.
Is it possible to use lapin-futures in scope of actix actors?
My knowlege of actix, rabbitmq and rust in general is very basic therefore it's very possible that I miss something.

@thedodd, thanks for your answer. I've tried tokio::spawn(new_task). It works ok so far.

I think we can close this one then

authors: Keruspe ivan-ochc

repo: sozu-proxy/lapin


text:
SPT (3.6.1) Insured and returned gear after sucessesful extraction has no durability damage

General information:
Project issue is for: SPT 3.6.1
Expected result:Insured gear after successful extraction which were returned should have durability damage
Actual result:Insured gear after successful extraction has no durability damage
How to reproduce:

Drop insured gear which has durability damage in raid
Get insured gear back
Check insured gear durability

Originally written by Armanello

This should've already been implemented in 370. If you'd like to download and test that it's working there, please feel free to do so.

Originally written by PhantomInTime

It looks like the commit was included in 3.6.1, so may not be working correctly?
https://dev.sp-tarkov.com/SPT-AKI/Stable-releases/releases/tag/3.6.1
"Added functionality to persist insured gear durability values after a raid
Items returned to you should have the correct durability"
Commit: https://dev.sp-tarkov.com/SPT-AKI/Server/commit/a962823192f273d2f55a268e38b16918c0ed1f08

Originally written by DrakiaXYZ

It looks like the commit was included in 3.6.1, so may not be working correctly?
https://dev.sp-tarkov.com/SPT-AKI/Stable-releases/releases/tag/3.6.1
"Added functionality to persist insured gear durability values after a raid
Items returned to you should have the correct durability"
Commit: https://dev.sp-tarkov.com/SPT-AKI/Server/commit/a962823192f273d2f55a268e38b16918c0ed1f08

It seems works only when player dies in raid.

Originally written by Armanello

I have just tried this in 370, both where I live and I die and both returned their expected duras.

Originally written by PhantomInTime

Closing as fixed, can be opened if steps to repro in 370 exist.

Originally written by chomp

repo: sp-tarkov/server

license: NCSA


text:
Jetpacks don’t work on station

Description
Jetpacks won’t work while you’re on the station grid, even if gravity generator is off
Reproduction

Join server 2. Equip jetpack 3. Turn off gravity 4. Attempt to use jetpack 5. Still says jetpack won’t work under gravity
Screenshots

Additional context

Intended.

authors: GoodWheatley metalgearsloth


text:
Admin logout shows for all players.

Instead of only showing when an admin logs out.

Can you elaborate on the problem a bit more? You worded it a bit weirdly

Can you elaborate on the problem a bit more? You worded it a bit weirdly

When you're an admin, you get messages saying when other admins log in or out.
Currently, the notification for when other admins log out is broken, as it notifies whenever ANY player, regardless of whether they're admin or not, logs out.


text:
Magic mirror on slime person hair doesn't transfer the alpha value

Description

I tried doing what HumanoidProfileEditor does and
        if (_markings.MustMatchSkin(humanoid.Species, HumanoidVisualLayers.Hair, out var _, _prototype))
            _humanoid.SetMarkingColor(component.Target.Value, category, args.Slot, [humanoid.SkinColor], humanoid);
        else
            _humanoid.SetMarkingColor(component.Target.Value, category, args.Slot, args.Colors, humanoid);

Even though it does properly set the RGB value to match the skin color, it doesn't actually set the alpha to match...
Reproduction

Screenshots

Additional context

and it's even more problematic considering how simple the code is to set the color... it's not like it's ignoring any particular value
        public void SetColor(int colorIndex, Color color) =>
            _markingColors[colorIndex] = color;

        public void SetColor(Color color)
        {
            for (int i = 0; i < _markingColors.Count; i++)
            {
                _markingColors[i] = color;
            }
        }


text:
Ghost roles menu should be collapsible

Description

When there are many of the same type of ghost role present, it can take up a lot of space and prevent people from seeing others further down the list
Since there are already headers for each kind of ghost role, a solution to this would be to have these sections be collapsible, and start collapsed if they contain more than 2 or 3 items. There could also be a button on this header that will enter the player for a random role raffle for any of the duplicates of that type.
Reproduction

Open the ghost roles menu when there are 500 sentient hydroponics trays available
Screenshots

Additional context

These two issues would be resolved by having a collapsible ghost role UI element
https://github.com/space-wizards/space-station-14/issues/20825
https://github.com/space-wizards/space-station-14/issues/31424

I'm on it. In the process of implementing it

authors: MilenVolf flashgnash


text:
allow syringes to set transfer amount

About the PR
So I decided to try out playing as the sole chemist with only using syringes. Making the stuff was a breeze and was more engaging than the current pill meta (where you just scatter a massive amount of pills on the table for the public to use all willy-nilly). I was able to give out precise doses and was happy with the results.
The crew, on the other hand, were not happy. They wanted their pills and they wanted them badly, to the point of breaking into my lab making them themselves. I would ask them why they didn't want to bother with the syringes and the major pain point was the speed in administering the drugs. Crew are limited to only 15u per syringe and could only inject 5u per doafter.
Solution I've come up with is to allow syringes to have their solution transfer amount to be configurable just like any other container. It still defaults to 5u, but can be set to 10 or 15u as necessary. This in my opinion buffs syringes just enough to make them more palatable for crew to use.
Screenshots

Changelog

:cl:

add: Syringe solution transfer amount is now configurable

Looks good. Just so you know, in the future when you finish part of a review you can hit the Resolve conversation button to minimize it and let the reviewer know that you addressed that part of the review.

authors: JustinTrotter ShadowCommander


text:
Nefarious WizOps [April Fools]

About the PR

Adds Magic to the Uplink.
For regular Syndicates, they recieve the ability to purchase the RGB Staff. RGB to the People!
For Nuclear Operatives, they recieve the ability to purchase
Spellbooks (Knock, Forcewall, Blink, Smite, Fireball, Spawn), typically being the most expensive.
Staffs (Healing, Entrance, RGB), residing in the middle, price-wise.
Wands (Fireball, Smite, Entrance, Polymorph, Cluwne-ification), being in the lower-to-middle area of Price.
And Misc Magic Items, (Wizard Hardsuit, Magical Lamp, Rune Scroll, Wand Belt), for varying prices, usually being cheap.
Also contains the tweaks from https://github.com/space-wizards/space-station-14/commit/979bdfcfa69d0c9e1199e3b6a9393a86a43c5417 and https://github.com/space-wizards/space-station-14/commit/311a027797fd6f8c515e029b4e358bf32fdedbe1, since they still need to be added to keep us up-to-date :godo:
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: blankmann, and Whisper

add: The Syndicate and the Space Wizard's Federation have made a temporary pact to supply their Agents and Operatives with cool thingamabobs. "...It would be funny, I think...", says a Wizard's Federation representative.
fix: CentCom has changed clothing suppliers. CentCom clothing will no longer appear in wardrobe restock boxes from cargo.

You're gonna need to rebase this PR off of april-fools-release.


text:
Social a-anxiety/st-st-stuttering t-trait.

About the PR

This pr adds a trait that makes you stutter when you speak, it uses stuttering component with the now ability to play around with its rng. Want more stutter? up the values!
Why / Balance

It c-can provide some g-good r-roleplay int-taractions.
Technical details

Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl: Vasilis

add: Added a s-social anxiety trait that m-makes you st-stutter your w-words when you t-talk.

Also i did check, it does not get removed after you are done being electrocuted/bleeding out/whatever else makes you stutter

Could it maybe get toned down? This is making LOUD MOUTH seem ideal.

It should probably be toned down. The current stutter massively floods the chat box, but it’s not a huge issue because it isn’t 24/7 but I think having this available as a trait would cause headache for players and admins.

admin logs also say the origin message before accents

I'd rather the actual ss13 trait where at times you randomly get mute

I'd rather the actual ss13 trait where at times you randomly get mute

that how that works? thought it just made you stutter the more people and eventually muting you

I'd rather the actual ss13 trait where at times you randomly get mute

that how that works? thought it just made you stutter the more people and eventually muting you

yes

I'd rather the actual ss13 trait where at times you randomly get mute

that how that works? thought it just made you stutter the more people and eventually muting you

yes, also wdym by "muting you"

The one time I played 13 there were enough people around me to "lock me up" and was unable to speak until I left the area

my take is that speaking when nobody is around, including on radio,  it should be fine
then gradually stutter the more people there are that you can see, up to the unreadable stutter currently in a large croud

absolutely unreadable and bloats the text box to nikocado avocado levels.
imagine yelling for help on the radio only to get drowned out by someone who's sentance of text gets turned into a paragraph

That's where the muting would come in handy.
I wonder if that was the original intention.

feels a bit overdone. Making it repeat only once would be better and less a hindrance to read...

Ok jesus christ why does this have 7 dislikes for an issue to be easily fixed my god people relax

Anyway added the ability to play with the rng chances, if you feel like it needs more stutter or less feel free to play with the values

I'll be blunt that I don't like this trait and would rather not run into it at all; it's both aggravating to read and peak cringe (add "uwu" to the end of messages and it's the type of PR you'd expect to see pushed on an ERP server).
But if it really must be pushed, I'd ask that it not apply when the anxious person is whispering (aka whenever they use the radio)

yeah i just really do not like this accent even toned down

I don't see it much worse than lizard accent tbh.
But it should only stutter on 1 of every 5 words tops.
This is enough to have it be apparent but not actually make it harder to read.

this would just bloat text and annoy people

would love to see it.

Looks much better toned down

i have gotten a feel for this trait after having used it for some hours now, and i feel like you stutter way too much, and way too often, it gets unreadable at times and becomes a wall of text, i had a simple "ah" become "ah-h-h-h", sometimes it becomes almost double the text with the stutter in some cases.
i suggest lowering the chance to stutter.

yeah, that's one thing I suck at, balancing numbers. Feel free to pr it yourself. It's easy to modify

authors: DummeHytteOst Eden077 JoeHammad1844 Just-a-Unity-Dev LankLTE NancokPS2 Tunguso4ka VasilisThePikachu Warentan deltanedas forgotmyotheraccount mirrorcult


text:
Mail Unit Fix (whitelist)

Fix - Mail Units currently allow you to drag humanoids into them which is unintended. This fix simply adds a whitelist for itemcomponent. With this change you can still mail mobs which you can pickup such as a mouse. This can be removed with a blacklist mobstate but i think it would be fine to mail small mobs with the mail unit.
fixes #26674

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

mouse mail my beloved


text:
Bots now make sound when they speak

About the PR
Basic silicons like medbots, janibots, honkbots now make sound when speaking.
Why / Balance
fixes #31454
Technical details
Media
Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
Changelog
:cl:

fix: Silicons like medbots, janibots, and honkbots now make sound when speaking.

damn that was quick :+1:

hey! i added this in #29949

hey! i added this in https://github.com/space-wizards/space-station-14/pull/29949

no merge conflict then :trollface:

hey! i added this in #29949

Weird. It appears that between https://github.com/space-wizards/space-station-14/commit/726589bd66fe148c486f0bc8b27d037bba2c6d98 and https://github.com/space-wizards/space-station-14/commit/a3cbbe745e83d43103ed8c5a7ab10dcf3ffa7112 the line somehow disappeared without any apparent commit

Weird. It appears that between 726589b and a3cbbe7 the line somehow disappeared without any apparent commit

my pr isn't merged yet, so actually this pr is a little part of mine that was merged faster
kinda frustrating, but fine

my pr isn't merged yet, so actually this pr is a little part of mine and just was merged faster
kinda frustrating, but fine

Sorry about that, but small bugfixes can be merged without a prior maintainer discussion, different from feature additions like the added emotes in your PR.

Yea I didn't know you were working on that I was just trying to knock out some simple bugs last night


text:
Add syndicate cargo orders

About the PR

Why / Balance

Technical details

Media

Requirements

[ ] I have read and am following the Pull Request and Changelog Guidelines.
[ ] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

Please follow our pull request guidelines for any PRs you make. Thank you.

authors: KeplyDog slarticodefast


text:
Storage Component ECS

About the PR
This is a change to ECS storage component to remove a variety of bloat and change to use a bound interface.
At the moment this doesn't touch some other abstractions of sharedStorageComponent such as the entityStorageComponent, both are working in harmony right now and this change is getting big enough.
Opening this as a draft to start with since I'm trying to clear up anything that's left and wanted to see if anyone had any immediate comments for something missing.
As far as I've tested, all functionality of storage is still retained as long as the entities using the storage component have the storageUIkey added.
edit: actually looks like click pickup storages(trash bags) are not showing their animation or obeying their timer, working on that.
Screenshots

https://user-images.githubusercontent.com/47410468/163074040-fecddad1-2f59-4d9d-acf3-92a1f521dfc7.mp4

Fixed the trash bag functionality
https://user-images.githubusercontent.com/47410468/163244395-e2532503-d7b2-4bd3-8234-7b8af69e81f8.mp4
https://user-images.githubusercontent.com/47410468/163244398-5ffcfdda-5ebb-42a3-9162-09024ffd6988.mp4

Tested everything, should have exact same functionality as before, questionable areas is the clientinteractionsystem since we'd need to grab and check if the UI is open for that user on the frontend and the clientstoragecomponent.
Not sure if there's a better way to go about handling those since they're abstracting from sharedStorageComponent in which other components are still using.

Just came to mind but one last issue is self destroying items are not handled, trying to figure that out now

OK, actually have a working solution for the self deleting items now, thank you shadowcommander.
https://user-images.githubusercontent.com/47410468/165240857-ba1a4443-56a0-40f3-8503-0ced4ab0a249.mp4
I'm doing another run through but I believe this should be good for review now.


text:
Added spacectl docs under the main concepts

Description of the change
I've added the information from the Spacelift GH repository under the Main Concepts in our documentation
Checklist
Please make sure that the proposed change checks all the boxes below before requesting a review:

[x] I have reviewed the guidelines for contributing to this repository.
[x] The preview looks fine.
[x] The tests pass.
[x] The commit history is clean and meaningful.
[x] The pull request is opened against the main branch.
[x] The pull request is no longer marked as a draft.
[x] You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
You have updated the navigation files correctly:

[ ] No new pages have been added, or;
[ ] Only nav.yaml has been updated because the changes only apply to SaaS, or;
[ ] Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
[x] Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.
Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.
Thank you for your contribution! 🙇

Looks good.
The only thing I'd say is if we're going down this route, we need to mega simplify the README in the repo, and have it just link to the docs site for anything docs-related. Otherwise the two sets of docs will get out of sync and it'll be confusing for people.

I completely agree with you on that. I think we can create another task for this. I will also ping @jmfontaine on this topic.

repo: spacelift-io/user-documentation


text:
Run weak coin only for following vote rounds and after votes were received

Motivation
It bubbled up some time ago and also flagged by @countvonzero that there is a mistake in weak coin execution order. It needs to be executed after vote was sent to the network. Otherwise, a byzantine actor can negate the weak coin effect by adjusting its own vote.
Also, votes from the last round were ignored fully.
Changes

run weak coin after receiving votes for the current round
change timeouts accordingly
don't return errors from goroutines spawned in runConsensusPhase, as it will shutdown whole tortoise beacon
lowercases some logs

Test Plan
TODO

[ ] Explain motivation or link existing issue(s)
[ ] Test changes and document test plan
[ ] Update documentation as needed

DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

weird, i thought that the beacon is disabled, but apparently it is not disabled for block builder
https://kibana-tests.spacemesh.io/goto/aaf4659c6bd032345de6002a0295393e

bors try

The test failed because node was expected to produce blocks, but because beacon wasn't found it skipped block production. There are other errors such as atx is not found but those are not the root cause of the failure and doesn't seem to be a new thing in general. Tortoise beacon probably wasn't disabled completely.
There are also a lot of received malformed first voting message, already received a voting message for this pk and round which is strange. This should be only if previously received messages were evicted from duplicates cache. But i don't see how that can be related to this change.

The test failed because node was expected to produce blocks, but because beacon wasn't found it skipped block production. There are other errors such as atx is not found but those are not the root cause of the failure and doesn't seem to be a new thing in general. Tortoise beacon probably wasn't disabled completely.

i wonder whether this is a timing/duration params issue.
this PR didn't seem to delay the time beacon is generated and just shifts the order of operations around inside the time frame.

i wonder whether this is a timing/duration params issue.
this PR didn't seem to delay the time beacon is generated and just shifts the order of operations around inside the time frame.

yes very confusing. if anything it became a bit shorter since the whole tortoise beacon is shorter. previously it was, proposal + first + wc + n-1*(round + wc) and now first wc is gone.

yes very confusing. if anything it became a bit shorter since the whole tortoise beacon is shorter. previously it was, proposal + first + wc + n-1*(round + wc) and now first wc is gone.

hmm.. i think it is
before:
FirstVotingRoundDuration+WeakCoinRoundDuration + (K-1)(VotingRoundDuration+WeakCoinRoundDuration)
after:
FirstVotingRoundDuration + (K-1)(VotingRoundDuration+WeakCoinRoundDuration+timeSpentCalculatingVotes)
unless timeSpentCalculatingVotes is significant, i agree it should be shorter

unless timeSpentCalculatingVotes is significant, i agree it should be shorter

actually i am wrong. the (K-1) multiplier probably did make the beacon generation time longer.

timeSpentCalculatingVotes

it id very low, especially with the amount of nodes in tests. i have inprocess test with 50 nodes, it takes around ~1ms for calcVotes to complete.

bors try

previous test failure has the same root cause as in https://github.com/spacemeshos/go-spacemesh/issues/2764 . definitely doesn't have anything to do with tortoise beacon.
bors try

I guess i will need to address the problem of slow discovery to understand if there is any additional flakiness caused by this PR, previous test failed exactly the same way. One node wasn't able to start sync on time and atx in epoch 1 wasn't published.

bors try

bors try

bors try

bors try

bors try

bors try

bors try

bors try

bors try

bors try

bors try

bors merge

authors: countvonzero dshulyak

repo: spacemeshos/go-spacemesh


text:
Update the release procedures WIKI

Update the release procedures WIKI in this repo to reflect the release process.
Or automate it.  =)

This page has been updated:
https://github.com/spacetelescope/asdf/wiki/Release-Process
Anything missing?

These procedure skips updating the stable branch and instead puts the release tag on the release branch. I guess that's fine but it means a release branch cannot be deleted and there should be a note about this if we choose to go that way. The initial motivation for having a stable branch was to have the option of providing two versions of the documentation on readthedocs - public release and dev.

Oh hmm... I didn't think about that.  There is a (possibly new) readthedocs feature that will build docs for tags as they appear and automatically set them as the default documentation, so we could use that to have docs hosted for both the latest master and latest release version.
If we continue tagging the stable branch, is there an easy way (for example) to release a patch on 2.x when 3.0 is already released and tagged?

Oh hmm... I didn't think about that.  There is a (possibly new) readthedocs feature that will build docs for tags as they appear and automatically set them as the default documentation, so we could use that to have docs hosted for both the latest master and latest release version.
If we continue tagging the stable branch, is there an easy way (for example) to release a patch on 2.x when 3.0 is already released and tagged?

I think as long as you do a merge commit from the release branch to stable, and the tag is still there (i.e. it's the same commit), I think Ed's way is fine.  But he should verify that it works.  It really depends on the history of stable.  If anything was ever cherry-picked onto stable, then that won't work I think.
I guess the nice thing about tagging on the release branch and merging to stable is that it will always work.  One set of instructions.  As long as we are consistent, that's good.
As for maintaining 2.x after 3.0 is released, those tags would also continue to go on the release branches, they just would not get merged to to stable.

I added some additional sections on maintaining the stable branch and running astropy/jwst/etc test suites.

It looks like the astropy folks blow away and rewrite their stable branch for every new release (see step 4 below).
https://docs.astropy.org/en/stable/development/releasing.html#post-release-procedures

... and another section on tagging master for further development

authors: eslavich jdavies-st nden

repo: spacetelescope/asdf


text:
You can still send to invalid topics (regex)

This code tries to stop you from sending to topics that don't match the valid regex provided on FCM.
def send_to_topic(topic, options = {})
  if topic =~ /[a-zA-Z0-9\-_.~%]+/
    send_with_notification_key('/topics/' + topic, options)
  end
end

But the =~ method will still match a string that has invalid characters in it, as long as there are valid characters in it. [see here].(https://ruby-doc.org/core-2.2.0/Regexp.html#method-i-3D~)
So the following can happen:
$ topic = "TopicA$"
$ topic =~ /[a-zA-Z0-9\-_.~%]+/
$ => 0

Can we change this to return false when invalid characters are present in the topic? Something like this maybe?
$ topic = "TopicA$"
$ topic.gsub(/[a-zA-Z0-9\-_.~%]+/, "").length == 0
$ => false

closed in #42

authors: quilligana sabman

repo: spacialdb/fcm


text:
System.err: a.a.a.a.a.ac

Hello,
I am using the cloudsdk and used gradle to import the dependency (io.particle:cloudsdk:0.3.4. What I'm trying to achieve is to login using the Particle cloud sdk, get a list of devices and communicate with them. When it is in debugging mode, everything works fine. In release, I added the oauth credentials inside the strings.xml file. I get the following message when I try to login:
W/System.err: a.a.a.a.a.ac
06-28 01:46:08.516 952-1030/? W/System.err: at a.a.a.a.a.y.a(Unknown Source)
06-28 01:46:08.516 952-1030/? W/System.err: at com.bmertech.activities.k.a(Unknown Source)
06-28 01:46:08.516 952-1030/? W/System.err: at com.bmertech.activities.k.doInBackground(Unknown Source)
06-28 01:46:08.516 952-1030/? W/System.err: at android.os.AsyncTask$2.call(AsyncTask.java:292)
06-28 01:46:08.516 952-1030/? W/System.err: at java.util.concurrent.FutureTask.run(FutureTask.java:237)
06-28 01:46:08.516 952-1030/? W/System.err: at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
06-28 01:46:08.517 952-1030/? W/System.err: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
06-28 01:46:08.517 952-1030/? W/System.err: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
06-28 01:46:08.517 952-1030/? W/System.err: at java.lang.Thread.run(Thread.java:818)
Thank you for your on-going support,
Nirujan

Without a de-obfuscated stack trace, I'm afraid I can't help you.  You'll need to do something like this: http://simplyadvanced.net/blog/android-how-to-decode-proguards-obfuscated-code-from-stack-trace/

W/System.err: a.a.a.a.a.ac
at a.a.a.a.a.y.a(y.java)
06-28 01:46:08.516 952-1030/? W/System.err: at com.bmertech.activities.k.a(k.java)
06-28 01:46:08.516 952-1030/? W/System.err: at com.bmertech.activities.k.doInBackground(k.java)
06-28 01:46:08.516 952-1030/? W/System.err: at android.os.AsyncTask$2.call(AsyncTask.java:292)
06-28 01:46:08.516 952-1030/? W/System.err: at java.util.concurrent.FutureTask.run(FutureTask.java:237)
06-28 01:46:08.516 952-1030/? W/System.err: at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
06-28 01:46:08.517 952-1030/? W/System.err: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
06-28 01:46:08.517 952-1030/? W/System.err: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
06-28 01:46:08.517 952-1030/? W/System.err: at java.lang.Thread.run(Thread.java:818)

Looks like that's the same stack trace as above.  Can you make a release build with proguard disabled and try reproducing this?

Looks like it worked without proguard? Thanks!

Cool, glad to hear it's working without Pro Guard at least.
Try adding rules to keep io.particle.** and let me know how that goes. If that works, I will add that to our documentation!

That worked for me!

Brilliant, thanks for the update!

authors: NirujanSuresh jensck

repo: spark/spark-sdk-android


text:
[Feature] Randomize the order of multiple choice answers

Feature Request
Description
The answers are randomly sorted at build-time, but if you're studying a lot between deploys, the same question will have the same answer, as in "A", "B", or "C", every time you see it. We should randomize the order at runtime to avoid this scenario.
One implementation would be a small client-side script that shuffles the order, but that could cause some issues if the user can tell that they're shifting around. Another possibility would be to use Edge Functions to reshuffle them before the page is even rendered, but that introduces some complexity. My advice would be to try the simple approach first, and if it's not working well, try the more complex one.

Completed in #103


text:
Update index.js

amber -> light-green

You can put all of these in one pull request to be more efficient.

Thanks, will note that in the future.

authors: JavascriptFTW darrylyeo


text:
Disappearing Wallet Address

I had an issue where I transferred from Cash app to my main Sparrow wallet. When I loaded the wallet and let the sync finish, the coins never showed up. I could see the coins on blockchain.io but never hit my wallet. The day after I went in to find the address and it wasn't listed. After several attempts to recover, all of a sudden, the missing address showed up and all of my coins came in. First time experiencing this on Arch Linux as my other laptops running Arch never had this issue.
Also, as a new feature, it would be nice to have watch-address option so I don't have more than one wallet app

The day after I went in to find the address and it wasn't listed.

Are you using a passphrase? Entering an incorrect passphrase is the only way a wallet might display different addresses.

Also, as a new feature, it would be nice to have watch-address option so I don't have more than one wallet app

You can setup a watch only wallet by choosing that option when creating a new wallet. Enter in the xpub and the wallet addresses will be created.

authors: craigraw vitokb

repo: sparrowwallet/sparrow


text:
Add an environ flag to load an alternative PortAudio Windows binary compiled without ASIO

This PR provides a very simple and minimal workaround for loading an alternative PortAudio Windows binary compiled without ASIO, to address issue #496. Since this issue only affects Windows, as far as I know, no changes have been made to the other platforms.
An alternative PortAudio binary will need to be added to the _sounddevice_data repository (e.g. named libportaudio64bit-noasio.dll). It will then be bundled like the other binaries in the built package and can then be used instead of the default using the os.environ["SD_WIN_DISABLE_ASIO"] flag.

Hello @arkrow! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file sounddevice.py:

Line 78:80: E501 line too long (83 > 79 characters)

Thanks for this PR!
I was hoping for a more general solution for choosing the DLL/dylib/so, similar to how it was discussed in #130.
But before even going down the environment variable path, I would like to know how ctypes.util.find_library() would find a user-provided DLL without having to use an env var.
I know that this works on Linux and I assume that it works on macOS as well and it would be good to know how to make this work on Windows as well. Maybe that would already be enough for selecting a custom DLL?

I was hoping for a more general solution for choosing the DLL/dylib/so, similar to how it was discussed in #130.

I think the most promising approach would be building libportaudio as part of the wheel build process, as mentioned in #130, and accepting ASIO as a flag in package extras as I mentioned in #496. If that can work on all systems without additional prerequisites, that would be the ideal solution. If I can get the solution up and running, I'll open a new PR.
Alternatively, as part of the suggested solutions in #130, I've opened a PR (#499) that loads a user-specified PortAudio binary during runtime, which is more general than this PR and has been requested by other users.

But before even going down the environment variable path, I would like to know how ctypes.util.find_library() would find a user-provided DLL without having to use an env var.

That would be difficult to do dynamically (without hard-coding) unless the values is retrieved from somewhere, which is why os.environ is a viable and often used approach. os.environ is also not permanent and its scope extends to the current python process only, avoiding any problematic PATH changes, so it should be safe to use on all platforms.

That would be difficult to do dynamically (without hard-coding)

Do you mean hard-coding the absolute path to the DLL?
What about just hard-coding a file name?
According to https://docs.python.org/3/library/ctypes.html#finding-shared-libraries:

On Windows, find_library() searches along the system search path, and returns the full pathname, but since there is no predefined naming scheme a call like find_library("c") will fail and return None.

So if you put a correctly named DLL somewhere into the system search path (whatever that means exactly), it should be found, right?
Do you know what the system search path is?
In case this hasn't been obvious already: I'm not a Windows user, so you can assume zero knowledge from my side.

See my comment https://github.com/spatialaudio/python-sounddevice/issues/496#issuecomment-1902706025
This doesn't provide an environment variable, but it involves downloading the appropriate DLL, renaming it and moving it into a specific folder.
I think that would still be easy enough for the (few?) people who need ASIO, what do you think?

In #539, I'll switch to DLLs without ASIO by default. This also adds documentation for how to download and use DLLs with ASIO, if needed.
I think this makes this PR obsolete, right?

Since the default behavior is without ASIO, this PR is now obsolete. Though it's inverse can be considered if both binaries are to be shipped together and enabled conditionally; that might be a good middle-ground for developers depending on ASIO support with this library. That said, the PR will be closed for now.

authors: arkrow mgeier pep8speaks

repo: spatialaudio/python-sounddevice


text:
Angular Example Console error

The application has a console error when try to use it the first time, In other words, trying to go from https://spatialillusions.com/milsymbol/examples/index.html to https://spatialillusions.com/milsymbol/examples/example.html#angular you can see a console error  GET https://spatialillusions.com/milsymbol/examples/angular/{{code}} 404 (Not Found).
Using the application in my local machine, I have a similar issue:
Failed to load resource: net::ERR_FILE_NOT_FOUND %7B%7Bcode%7D%7D
Also, I've modified the code not using a directive with a method like this:
JS:
function getImageFromMilsymbolLibrary(sic) {
var symbol = new ms.Symbol(sic, { size: 40 || 20 });
return symbol.toDataURL();
}
$scope.sic = getImageFromMilsymbolLibrary("SFG-UCIZ---B");
HTML:
<...'img width="100px" height="62px" class="symbol-sm" src="{{sic}}'..../>
Unfortunately, I have the same error. The library works fine for me and I can see the symbols but I would like to remove thi anoying error message. I think it's a problem with in milsymbol.js
Any ideas? Thanks in advance

I think the error comes from that the web-browser tries to load the template before the src has been replaced with the output from milsymbol.
(%7B%7Bcode%7D%7D is the same as {{code}} in the src attribute of the img template.)
As far as I can tell this has nothing to do with milsymbol is something caused by angular, and I'm not sure if there is a workaround to solve this.

I think I found a solution. If the template uses ng-src instead of src, things will work as expected. I have updated the master branch with this change.
You can close this issue if this solves you problem as well.

You are absolutely right @spatialillusions . It should be ng-src instead of src.

Awesome, you are very kind, the ng-src solves the issue. Thank you very much for your quick response.

authors: jm4github kjellmf spatialillusions

repo: spatialillusions/milsymbol


text:
(WIP) Schema Bundles - Details Re-Implementation

Description
Re-implementing the details classes inside the CodeGeneration library on top of the schema bundles.
This adds the skeleton required for each of these and adds back in the Formatting static class to format the schema json.
TODO:

[x] Add tests for the Formatting class
[ ] Add tests for each of the details class.

Tests
See TODOs
Documentation
N/A
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

Closing this to rebase later

repo: spatialos/gdk-for-unity


text:
Installation issue on Laravel 5.4 and PHP 7

Hi, am having this problem with composer dependencies while trying to install laravel-activitylog.
Here is the error:
$ composer require spatie/laravel-activitylog
Using version ^1.12 for spatie/laravel-activitylog
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Conclusion: remove laravel/framework v5.4.9
- Conclusion: don't install laravel/framework v5.4.9
- Can only install one of: laravel/framework[v5.4.0, v5.4.9].
- don't install laravel/framework v5.4.9|remove illuminate/database v5.4.0
- don't install illuminate/database v5.4.0|don't install laravel/framework v5.4.9
- don't install illuminate/database v5.4.0|don't install laravel/framework v5.4.9
- Installation request for laravel/framework (locked at v5.4.9, required as 5.4.*) -> satisfiable by laravel/framework[v5.4.9].
- Installation request for illuminate/database (locked at v5.4.0) -> satisfiable by illuminate/database[v5.4.0], laravel/framework[v5.4.0].

Seems to be working fine here. Could you try to install the package in a vanilla Laravel app to see if that works?

help me to solving this
Problem 1
- doctrine/instantiator 1.1.0 requires php ^7.1 -> your PHP version (7.0.22) does not satisfy that requirement.
- doctrine/instantiator 1.1.0 requires php ^7.1 -> your PHP version (7.0.22) does not satisfy that requirement.
- Installation request for doctrine/instantiator 1.1.0 -> satisfiable by doctrine/instantiator[1.1.0].

Install PHP 7.1

authors: andros27 freekmurze iqiuye

repo: spatie/laravel-activitylog