text:
no evaluation prompt for replicate the result?

no ./prompts/eval_prometheus_no_ref.prompt file for eval/evaluation_prometheus.py?
Could you please show what this file looks like? Does it directly use the code from https://github.com/kaistAI/prometheus/tree/main?
e.g.
###Task Description:
An instruction (might include an Input inside it), a response to evaluate, a reference answer that gets a score of 5, and a score rubric representing a evaluation criteria are given.

Write a detailed feedback that assess the quality of the response strictly based on the given score rubric, not evaluating in general.
After writing a feedback, write a score that is an integer between 1 and 5. You should refer to the score rubric.
The output format should look as follows: "Feedback: (write a feedback for criteria) [RESULT] (an integer number between 1 and 5)"
Please do not generate any other opening, closing, and explanations.

###The instruction to evaluate:
{orig_instruction}
###Response to evaluate:
{orig_response}
###Reference Answer (Score 5):
{orig_reference_answer}
###Score Rubrics:
[{orig_criteria}]
Score 1: {orig_score1_description}
Score 2: {orig_score2_description}
Score 3: {orig_score3_description}
Score 4: {orig_score4_description}
Score 5: {orig_score5_description}
###Feedback:

Hi, the prompt file is in eval/eval_prometheus_no_ref.prompt and the rubric file is in eval/eval_rubric_5.json.

Hi, the prompt file is in eval/eval_prometheus_no_ref.prompt and the rubric file is in eval/eval_rubric_5.json.

thanks for updates

authors: Xccanxin shaoyijia

repo: stanford-oval/storm


text:
HFClientVLLM Multithreading not working

I'm using HFClientVLLM and set num_threads=32 but the time it takes evaluate to finish goes up linear with the number of samples. This shouldn't be the case since vllm is using 2x A100 GPUs and I'm just using a few samples, e.g. four samples take roughly 4x longer than evaluating on one sample.

Sorry seeing this only now. I don't see how this issue is possible, threading should work smoothly with VLLM if you have two A100s. But keep in mind parallelism will happen across examples, not within each example.
It's possible that having extremely few examples makes the overhead of parallelism unnecessary (??) but that sounds unlikely. Anyway 32 threads may also be too many depending on which LM it is and how long your prompts are, consider 12 or so.

Okay did a lot bigger tests and you are right, there is no fundamental issue. I suspect that with in creased samples size the chance of having one long completion goes up. With the long completion evaluation takes longer

source: gharchive/issue

authors: okhat tom-doerr

repo: stanfordnlp/dspy

license: MIT

license_type: permissive

license_source: github-api


text:
tregex issue

Hi All
I m trying to use the tregex python interface and I m getting internal server error 500.
Is there a fix for that issue?
Many thanks
valery

import stanfordnlp.server as corenlp
c=corenlp.CoreNLPClient(annotators='tokenize ssplit pos lemma ner depparse'.split(), timeout=60000)
c.tregrex("Here we are.","(NP[$VP]>S)|(NP[$VP]>S\n)|(NP\n[$VP]>S)|(NP\n[$VP]>S\n)")
Traceback (most recent call last):
File "/home/vwe/libs/pyenv/pyenv/versions/3.6.4/lib/python3.6/site-packages/stanfordnlp/server/client.py", line 317, in __regex
r.raise_for_status()
File "/home/vwe/libs/pyenv/pyenv/versions/3.6.4/lib/python3.6/site-packages/requests/models.py", line 935, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: http://localhost:9000/tregex?pattern=(NP[%24VP]>S)|(NP[%24VP]>S\n)|(NP\n[%24VP]>S)|(NP\n[%24VP]>S\n)&filter=False&properties={'annotators'%3A+'tokenize%2Cssplit%2Cpos%2Clemma%2Cner%2Cdepparse'%2C+'inputFormat'%3A+'text'%2C+'outputFormat'%3A+'serialized'%2C+'serializer'%3A+'edu.stanford.nlp.pipeline.ProtobufAnnotationSerializer'}

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "/home/vwe/libs/pyenv/pyenv/versions/3.6.4/lib/python3.6/site-packages/stanfordnlp/server/client.py", line 270, in tregrex
return self.__regex('/tregex', text, pattern, filter, annotators, properties)
File "/home/vwe/libs/pyenv/pyenv/versions/3.6.4/lib/python3.6/site-packages/stanfordnlp/server/client.py", line 323, in __regex
raise AnnotationException(r.text)
stanfordnlp.server.client.AnnotationException: java.lang.NullPointerException: null

I think the problem is that you haven't include "parse" in your list of annotators which provides the required constituency tree annotations. I would recommend either trying that out or using the new stanfordnlp package: https://github.com/stanfordnlp/stanfordnlp

Many thanks
v

authors: arunchaganty valeryweber

repo: stanfordnlp/python-stanford-corenlp


text:
Format all Swift files in project

Run swift-format on all Swift files in repo.

Confirmed with @scruff311 during the standup, there is no logic change in this PR, only automated formatting changes.

source: gharchive/pull-request

repo: starburstlabs/NotificationBanner


text:
[test] fix testing failures relate to 0x0x

relate to #15 #19
现在 cargo xtest 时所有测试在我的机器都能跑过了

我的机器上报错
cargo test -p move-stdlib --test move_unit_test

thread '<unknown>' has overflowed its stack
fatal runtime error: stack overflow
error: test failed, to rerun pass '--test move_unit_test'

你遇到这问题没 @jiangying000

我没遇到，刚跑的日志，cargo test -p move-stdlib --test move_unit_test
ubuntu 18.04
warning: unused import: `ed25519::signature::Signature`
  --> language/move-prover/interpreter/crypto/src/lib.rs:16:5
   |
16 |     ed25519::signature::Signature, PublicKey as Ed25519PublicKey, Signature as Ed25519Signature,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: `bytecode-interpreter-crypto` (lib) generated 1 warning
warning: unused variable: `sub_status`
  --> language/move-binary-format/src/errors.rs:66:28
   |
66 |             (major_status, sub_status, location)
   |                            ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_sub_status`
   |
   = note: `#[warn(unused_variables)]` on by default

warning: `move-binary-format` (lib) generated 1 warning
warning: field is never read: `id`
    --> language/move-vm/runtime/src/loader.rs:1386:5
     |
1386 |     id: ModuleId,
     |     ^^^^^^^^^^^^
     |
     = note: `#[warn(dead_code)]` on by default
note: `Module` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
    --> language/move-vm/runtime/src/loader.rs:1384:10
     |
1384 | #[derive(Debug)]
     |          ^^^^^
     = note: this warning originates in the derive macro `Debug` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: field is never read: `struct_refs`
    --> language/move-vm/runtime/src/loader.rs:1398:5
     |
1398 |     struct_refs: Vec<usize>,
     |     ^^^^^^^^^^^^^^^^^^^^^^^
     |
note: `Module` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
    --> language/move-vm/runtime/src/loader.rs:1384:10
     |
1384 | #[derive(Debug)]
     |          ^^^^^
     = note: this warning originates in the derive macro `Debug` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: field is never read: `owner`
    --> language/move-vm/runtime/src/loader.rs:2040:5
     |
2040 |     owner: usize,
     |     ^^^^^^^^^^^^
     |
note: `FieldInstantiation` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
    --> language/move-vm/runtime/src/loader.rs:2036:10
     |
2036 | #[derive(Debug)]
     |          ^^^^^
     = note: this warning originates in the derive macro `Debug` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: `move-vm-runtime` (lib) generated 3 warnings
warning: use of deprecated associated function `itertools::Itertools::fold1`: Use `Iterator::reduce` instead
   --> language/move-model/src/exp_generator.rs:153:14
    |
153 |         args.fold1(|a, b| self.mk_bool_call(oper.clone(), vec![a, b]))
    |              ^^^^^
    |
    = note: `#[warn(deprecated)]` on by default

warning: field is never read: `type_arg_names`
    --> language/move-model/src/model.rs:2852:5
     |
2852 |     type_arg_names: Vec<Symbol>,
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: `#[warn(dead_code)]` on by default
note: `FunctionData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
    --> language/move-model/src/model.rs:2831:10
     |
2831 | #[derive(Debug)]
     |          ^^^^^
     = note: this warning originates in the derive macro `Debug` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: field is never read: `result_type`
  --> language/move-model/src/builder/exp_translator.rs:41:5
   |
41 |     pub result_type: Option<Type>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: `ExpTranslator` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
  --> language/move-model/src/builder/exp_translator.rs:29:10
   |
29 | #[derive(Debug)]
   |          ^^^^^
   = note: this warning originates in the derive macro `Debug` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: field is never read: `loc`
  --> language/move-model/src/builder/model_builder.rs:67:5
   |
67 |     pub loc: Loc,
   |     ^^^^^^^^^^^^
   |
note: `SpecFunEntry` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
  --> language/move-model/src/builder/model_builder.rs:65:10
   |
65 | #[derive(Debug, Clone)]
   |          ^^^^^  ^^^^^
   = note: this warning originates in the derive macro `Debug` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: field is never read: `var_id`
  --> language/move-model/src/builder/model_builder.rs:79:5
   |
79 |     pub var_id: SpecVarId,
   |     ^^^^^^^^^^^^^^^^^^^^^
   |
note: `SpecVarEntry` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
  --> language/move-model/src/builder/model_builder.rs:75:10
   |
75 | #[derive(Debug, Clone)]
   |          ^^^^^  ^^^^^
   = note: this warning originates in the derive macro `Debug` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: field is never read: `name`
  --> language/move-model/src/builder/model_builder.rs:88:5
   |
88 |     pub name: QualifiedSymbol,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
   |
note: `SpecSchemaEntry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
  --> language/move-model/src/builder/model_builder.rs:85:10
   |
85 | #[derive(Debug)]
   |          ^^^^^
   = note: this warning originates in the derive macro `Debug` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: field is never read: `is_resource`
   --> language/move-model/src/builder/model_builder.rs:107:5
    |
107 |     pub is_resource: bool,
    |     ^^^^^^^^^^^^^^^^^^^^^
    |
note: `StructEntry` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
   --> language/move-model/src/builder/model_builder.rs:102:10
    |
102 | #[derive(Debug, Clone)]
    |          ^^^^^  ^^^^^
    = note: this warning originates in the derive macro `Debug` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: field is never read: `fun_id`
   --> language/move-model/src/builder/model_builder.rs:118:5
    |
118 |     pub fun_id: FunId,
    |     ^^^^^^^^^^^^^^^^^
    |
note: `FunEntry` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
   --> language/move-model/src/builder/model_builder.rs:114:10
    |
114 | #[derive(Debug, Clone)]
    |          ^^^^^  ^^^^^
    = note: this warning originates in the derive macro `Debug` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: field is never read: `module`
  --> language/tools/move-bytecode-viewer/src/source_viewer.rs:23:5
   |
23 |     module: CompiledModule,
   |     ^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default
note: `ModuleViewer` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
  --> language/tools/move-bytecode-viewer/src/source_viewer.rs:18:10
   |
18 | #[derive(Debug, Clone)]
   |          ^^^^^  ^^^^^
   = note: this warning originates in the derive macro `Debug` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: `move-model` (lib) generated 8 warnings
warning: `move-bytecode-viewer` (lib) generated 1 warning
    Finished test [unoptimized + debuginfo] target(s) in 0.39s
     Running tests/move_unit_test.rs (target/debug/deps/move_unit_test-e237a29b4a972627)

running 1 test
BUILDING MoveStdlib
Running Move unit tests
[ PASS    ] 0x1::HashTests::sha2_256_expected_hash
[ PASS    ] 0x1::HashTests::sha3_256_expected_hash
[ PASS    ] 0x1::BCSTests::bcs_address
[ PASS    ] 0x1::FixedPoint32Tests::create_div_zero
[ PASS    ] 0x1::BCSTests::bcs_bool
[ PASS    ] 0x1::FixedPoint32Tests::create_from_rational_max_numerator_denominator
[ PASS    ] 0x1::BCSTests::bcs_u128
[ PASS    ] 0x1::CapabilityTests::test_delegate_failure_after_revoke
[ PASS    ] 0x1::BCSTests::bcs_u64
[ PASS    ] 0x1::OptionTests::borrow_mut_none
[ PASS    ] 0x1::EventTests::test_event_128
[ PASS    ] 0x1::FixedPoint32Tests::create_overflow
[ PASS    ] 0x1::BitVectorTests::empty_bitvector
[ PASS    ] 0x1::ASCIITests::printable_chars_dont_allow_newline
[ PASS    ] 0x1::BCSTests::bcs_u8
[ PASS    ] 0x1::FixedPoint32Tests::create_underflow
[ PASS    ] 0x1::BCSTests::bcs_vec_u8
[ PASS    ] 0x1::CapabilityTests::test_delegate_success
[ PASS    ] 0x1::VectorTests::append_empties_is_empty
[ PASS    ] 0x1::FixedPoint32Tests::create_zero
[ PASS    ] 0x1::BCSTests::encode_128
[ PASS    ] 0x1::OptionTests::borrow_mut_some
[ PASS    ] 0x1::FixedPoint32Tests::divide_by_zero
[ PASS    ] 0x1::BitVectorTests::index_bit_out_of_bounds
[ PASS    ] 0x1::ASCIITests::printable_chars_dont_allow_tab
[ PASS    ] 0x1::CapabilityTests::test_failure
[ PASS    ] 0x1::FixedPoint32Tests::divide_overflow_large_numerator
[ PASS    ] 0x1::EventTests::test_event_256
[ PASS    ] 0x1::FixedPoint32Tests::divide_overflow_small_divisore
[ PASS    ] 0x1::CapabilityTests::test_success
[ PASS    ] 0x1::BCSTests::encode_256
[ PASS    ] 0x1::OptionTests::borrow_with_default
[ PASS    ] 0x1::ErrorsTests::errors_state
[ PASS    ] 0x1::FixedPoint32Tests::exact_divide
[ PASS    ] 0x1::BitVectorTests::longest_sequence_no_set_nonzero_index
[ PASS    ] 0x1::VectorTests::append_respects_order_empty_lhs
[ PASS    ] 0x1::GUIDTests::test_basics
[ PASS    ] 0x1::ASCIITests::test_ascii_chars
[ PASS    ] 0x1::FixedPoint32Tests::exact_multiply
[ PASS    ] 0x1::BCSTests::encode_257
[ PASS    ] 0x1::GUIDTests::test_delegation
[ PASS    ] 0x1::EventTests::test_event_257
[ PASS    ] 0x1::FixedPoint32Tests::multiply_overflow_large_multiplier
[ PASS    ] 0x1::OptionTests::destroy_none
[ PASS    ] 0x1::GUIDTests::test_id
[ PASS    ] 0x1::FixedPoint32Tests::multiply_overflow_small_multiplier
[ PASS    ] 0x1::BitVectorTests::longest_sequence_no_set_zero_index
[ PASS    ] 0x1::FixedPoint32Tests::multiply_truncates
[ PASS    ] 0x1::EventTests::test_guid_wrapper_backward_compatibility
[ PASS    ] 0x1::VectorTests::append_respects_order_empty_rhs
[ PASS    ] 0x1::ASCIITests::test_ascii_push_char_pop_char
[ PASS    ] 0x1::BitVectorTests::longest_sequence_one_set_zero_index
[ PASS    ] 0x1::OptionTests::destroy_none_some
[ PASS    ] 0x1::ASCIITests::test_ascii_push_chars
[ PASS    ] 0x1::VectorTests::append_respects_order_nonempty_rhs_lhs
[ PASS    ] 0x1::BitVectorTests::longest_sequence_two_set_nonzero_index
[ PASS    ] 0x1::OptionTests::destroy_some
[ PASS    ] 0x1::ASCIITests::test_invalid_ascii_characters
[ PASS    ] 0x1::BitVectorTests::longest_sequence_with_break
[ PASS    ] 0x1::VectorTests::borrow_out_of_range
[ PASS    ] 0x1::OptionTests::destroy_some_none
[ PASS    ] 0x1::BitVectorTests::set_bit_out_of_bounds
[ PASS    ] 0x1::ASCIITests::test_nonvisible_chars
[ PASS    ] 0x1::VectorTests::destroy_empty
[ PASS    ] 0x1::OptionTests::destroy_with_default
[ PASS    ] 0x1::ASCIITests::test_printable_chars
[ PASS    ] 0x1::BitVectorTests::shift_left_at_size
[ PASS    ] 0x1::OptionTests::extract_none
[ PASS    ] 0x1::VectorTests::destroy_empty_with_pops
[ PASS    ] 0x1::BitVectorTests::shift_left_more_than_size
[ PASS    ] 0x1::OptionTests::extract_some
[ PASS    ] 0x1::BitVectorTests::single_bit_bitvector
[ PASS    ] 0x1::VectorTests::destroy_non_empty
[ PASS    ] 0x1::OptionTests::fill_none
[ PASS    ] 0x1::BitVectorTests::test_set_bit_and_index_basic
[ PASS    ] 0x1::OptionTests::fill_some
[ PASS    ] 0x1::VectorTests::get_set_work
[ PASS    ] 0x1::OptionTests::get_with_default
[ PASS    ] 0x1::VectorTests::index_of_empty_not_has
[ PASS    ] 0x1::OptionTests::option_borrow_none
[ PASS    ] 0x1::OptionTests::option_borrow_some
[ PASS    ] 0x1::VectorTests::index_of_nonempty_has
[ PASS    ] 0x1::OptionTests::option_contains
[ PASS    ] 0x1::VectorTests::index_of_nonempty_has_multiple_occurences
[ PASS    ] 0x1::OptionTests::option_none_is_none
[ PASS    ] 0x1::OptionTests::option_some_is_some
[ PASS    ] 0x1::VectorTests::index_of_nonempty_not_has
[ PASS    ] 0x1::OptionTests::swap_none
[ PASS    ] 0x1::VectorTests::length
[ PASS    ] 0x1::OptionTests::swap_or_fill_none
[ PASS    ] 0x1::OptionTests::swap_or_fill_some
[ PASS    ] 0x1::VectorTests::pop_out_of_range
[ PASS    ] 0x1::OptionTests::swap_some
[ PASS    ] 0x1::VectorTests::pop_push_back
[ PASS    ] 0x1::VectorTests::push_back_and_borrow
[ PASS    ] 0x1::VectorTests::remove_empty_vector
[ PASS    ] 0x1::VectorTests::remove_nonsingleton_vector
[ PASS    ] 0x1::VectorTests::remove_nonsingleton_vector_last_elem
[ PASS    ] 0x1::VectorTests::remove_out_of_bound_index
[ PASS    ] 0x1::VectorTests::remove_singleton_vector
[ PASS    ] 0x1::VectorTests::reverse_singleton_vector
[ PASS    ] 0x1::VectorTests::reverse_vector_empty
[ PASS    ] 0x1::VectorTests::reverse_vector_nonempty_even_length
[ PASS    ] 0x1::VectorTests::reverse_vector_nonempty_odd_length_non_singleton
[ PASS    ] 0x1::VectorTests::swap_different_indices
[ PASS    ] 0x1::VectorTests::swap_empty
[ PASS    ] 0x1::VectorTests::swap_out_of_range
[ PASS    ] 0x1::VectorTests::swap_remove_empty
[ PASS    ] 0x1::VectorTests::swap_remove_end_of_vector
[ PASS    ] 0x1::VectorTests::swap_remove_inside_vector
[ PASS    ] 0x1::VectorTests::swap_remove_out_of_range
[ PASS    ] 0x1::VectorTests::swap_remove_singleton
[ PASS    ] 0x1::VectorTests::swap_same_index
[ PASS    ] 0x1::VectorTests::test_empty_is_empty
[ PASS    ] 0x1::VectorTests::test_natives_with_different_instantiations
[ PASS    ] 0x1::VectorTests::test_singleton_contains
[ PASS    ] 0x1::VectorTests::test_singleton_len
[ PASS    ] 0x1::VectorTests::vector_contains
[ PASS    ] 0x1::BitVectorTests::test_set_bit_and_index_odd_size
[ PASS    ] 0x1::BitVectorTests::test_shift_left
[ PASS    ] 0x1::BitVectorTests::test_shift_left_specific_amount
[ PASS    ] 0x1::BitVectorTests::test_shift_left_specific_amount_to_unset_bit
[ PASS    ] 0x1::BitVectorTests::unset_bit_out_of_bounds
Test result: OK. Total tests: 123; passed: 123; failed: 0
BUILDING MoveStdlib
BUILDING MoveNursery
Running Move unit tests
[ PASS    ] 0x1::RoleTests::test_assign_failure
[ PASS    ] 0x1::ACLTests::test_add_failure
[ PASS    ] 0x1::RoleTests::test_revoke_failure
[ PASS    ] 0x1::ACLTests::test_remove_failure
[ PASS    ] 0x1::CompareTests::equality_of_simple_types
[ PASS    ] 0x1::RoleTests::test_success
[ PASS    ] 0x1::ACLTests::test_success
[ PASS    ] 0x1::CompareTests::greater_than_with_natural_ordering
[ PASS    ] 0x1::CompareTests::greater_than_without_natural_ordering
[ PASS    ] 0x1::CompareTests::inequality_of_simple_types
[ PASS    ] 0x1::CompareTests::less_than_with_natural_ordering
[ PASS    ] 0x1::CompareTests::less_than_without_natural_ordering
Test result: OK. Total tests: 12; passed: 12; failed: 0
test move_unit_tests ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 9.68s

repo: starcoinorg/move


text:
Fix the problem that some unstake methods in the plugin `stake_to_sbt…

…` do not check the identity of the caller

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

include in #203

authors: jolestar welbon

repo: starcoinorg/starcoin-framework


text:
Embed video has a white flash when toggle active state

Bug Report
When playing or pausing an embedded video there is a white flash when switching between the placeholder and the video. This is particualry annoying when the placeholder is the first frame of the video.
Steps
Create an Embed component and press play
Expected Result
Playing a video should smoothly show the video.
Actual Result
There is a whiteflash before the video starts
Version
0.34.0
Testcase
https://codesandbox.io/s/stardust-ui-example-fm1ow

Please see if PR #1768 resolves this. There is now a background color set. It behaves the same as Semantic UI's Embed.

@jurokapsiar PR #1768 did not resolve this issue

authors: lucivpav stuartlong

repo: stardust-ui/react


text:
Фикс локализации вещмешка экспедиторов

Запрос
Краткое описание запроса:
Исправить неправильный перевод вещмешка экспедиторов

Полное описание запроса:
Сейчас вещмешок имеет название "вешьмешок экспедиторов", что грамматически неправильно.

@MetalSage


text:
Update - LWT transaction failure retries

What this PR does:
Update - LWT transaction failure retries
Which issue(s) this PR fixes:
Fixes #228
Checklist

[x] Changes manually tested
[x] Automated Tests added/updated
[ ] Documentation added/updated
[x] CLA Signed: DataStax CLA

Not sure I can validate actual retry logic, but I think Ivan was offering his suggestions earlier and so that should be good to go.

Added a Test LwtRetryIntegrationTest which will run as @Execution(ExecutionMode.CONCURRENT).
The test method is repeated 3 times (retry limit is 3) and checked for no errors everytime.

repo: stargate/jsonapi


text:
add Bbr plugin

added a plugin so shield is able to backup/restore bbr enabled deployments or bosh directors

Hey Ramon. I had made a change that got merged to master that caused a file conflict with your branch like... a week ago. I just noticed and I fixed your branch.

It looks like vendoring still has an issue though

@thomasmmitchell nto exactly sure what you did
but there is a readme of the bbr plugin that explains how to update the vendor deps

All I did was pull in the the version of main from master because you had added a newline to the old version that was causing a merge conflict.

authors: ramonskie thomasmmitchell

repo: starkandwayne/shield

license: mit

license_source: bigquery


text:
fix(concurrency): allow threads in pyo3 (release the GIL)

This change is

Codecov Report
Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.37%. Comparing base (4505d16) to head (076d771).

Files
Patch %
Lines

crates/native_blockifier/src/py_block_executor.rs
0.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1978      +/-   ##
==========================================
- Coverage   78.38%   78.37%   -0.01%
==========================================
  Files          62       62
  Lines        8855     8856       +1
  Branches     8855     8856       +1
==========================================
  Hits         6941     6941
- Misses       1475     1476       +1
  Partials      439      439

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

crates/native_blockifier/src/py_block_executor.rs line 232 at r1 (raw file):
The problem is that the object txs_with_class_infos is of type &PyAny. See here:

Its lifetime represents the scope of holding the GIL which can be used to create Rust references that are bound to it, such as &PyAny.

Since the method execute_txs gets a reference to a Python object, we have to take the GIL before we can spawn threads.
However, as far as I understand, any access to a &PyAny requires taking the GIL again. @noaov1 are you sure this doesn't mean our threads get blocked by the GIL each time txs is read from?

crates/native_blockifier/src/py_block_executor.rs line 232 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Don't we consume it before calling the executor?

You are right. txs is a purely rust variable. So we just need the with_gil to gain access to the Python token (py) from which we can run the method allow_threads.
Moreover, with_gil would not have been needed at all if the method execute_txs did not have pythonic objects as arguments.

crates/native_blockifier/src/py_block_executor.rs line 232 at r1 (raw file):
Previously, noaov1 (Noa Oved) wrote…
You are right. I'm not sure why allow_threads is needed for running threads in rust. The docs suggest that rayon threads do not need to use allow_threads, maybe the std ones do?

The docs say that "pure rust functions" can use threads without worrying about the GIL, but functions that accept Python objects as arguments need to take the GIL before they can spawn a thread.

I agree. I added the allow_threads code to a function that accepts Python objects but does not spawn any threads. It calls a rust method that spawns threads.
BTW- it does not work using rayon threads as well (got timeout).

crates/native_blockifier/src/py_block_executor.rs line 232 at r1 (raw file):
Previously, avi-starkware wrote…
The docs say that "pure rust functions" can use threads without worrying about the GIL, but functions that accept Python objects as arguments need to take the GIL before they can spawn a thread.

I agree. I added the allow_threads code to a function that accepts Python objects but does not spawn any threads. It calls a rust method that spawns threads.
BTW- it does not work using rayon threads as well (got timeout).
Anyway it works :)

authors: avi-starkware codecov-commenter noaov1

repo: starkware-libs/blockifier


text:
Dori/so for bazel next pr

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.44%. Comparing base (fafed54) to head (1b818b3).

Additional details and impacted files
@@                Coverage Diff                 @@
##           dori/so-for-bazel    #2009   +/-   ##
==================================================
  Coverage              78.44%   78.44%
==================================================
  Files                     63       63
  Lines                   9045     9045
  Branches                9045     9045
==================================================
  Hits                    7095     7095
  Misses                  1503     1503
  Partials                 447      447

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

authors: codecov-commenter dorimedini-starkware


text:
refactor(blockifier): fix gas cost in versioned constants

This change is

crates/blockifier/src/execution/syscalls/syscall_tests/deploy.rs line 80 at r4 (raw file):

}

#[test_case(FeatureContract::TestContract(CairoVersion::Cairo1), 5210;"VM")]

why is this cheaper now?
Code quote:
5210

crates/blockifier/src/execution/syscalls/syscall_tests/deploy.rs line 80 at r4 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
Ok, after some investigation, I saw that the call data that we are checking is the first inner call, which is the constructor
that executes one storage write, so these changes make sense. It looks like this is the intention of this test, but the result is that we do not have a test that checks the consumption of gas for the deploy syscall.

Can you  document that?

crates/blockifier/resources/versioned_constants.json line 36 at r5 (raw file):
Previously, noaov1 (Noa Oved) wrote…
How come call contract got so much more expensive?
@ilyalesokhin-starkware

The original price was probably wrong, but the new price seems expensive.
We need to make sure the os resources test measures it correctly.

crates/blockifier/resources/versioned_constants.json line 103 at r5 (raw file):
Previously, noaov1 (Noa Oved) wrote…
How did we decide to set the gas cost for the builtins? It seems inconsistent. pedersen equals trace cells multiplied by 2, while the range check does not.

We decided to make the rangecheck more expensive then their actual prices.

crates/blockifier/resources/versioned_constants.json line 106 at r5 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Q RE the max(n_steps_resource, syscall_base_gas_cost) methodology. Here we refund the syscall base gas cost from the syscall required gas, hence we will get that the required gas for a syscall can be 0 (if no builtins are used). This is this the desired behaviour, right? If a syscall costs less than 100 gas than there is no need to charge more, right?
@ilyalesokhin-starkware

yes

crates/blockifier/resources/versioned_constants.json line 36 at r5 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
I checked my pr that changed the os_resources. Before the changes, it was 690 steps, and after those changes (cairo1), it was 760.
I don't know where the 10 came from.

"after those changes (cairo1), it was 760."
what changes?

crates/blockifier/resources/versioned_constants.json line 36 at r5 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
changing the os resources contract from cairo0 to cairo1

@Yoni-Starkware
Can you check if it makes sense?

authors: ilyalesokhin-starkware meship-starkware

repo: starkware-libs/sequencer


text:
refactor: share the chain info as a config for the gateway

The ChainInfo is a part of the config that is relevant not only to the stateful validator but also to the conversion RpcTransaction -> ExecutableTransaction. In this PR we move this config to be a part of the GatewayConfig.

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#520  👈
#519
#518
#517
#516
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on  Graphite

crates/gateway/src/stateful_transaction_validator_test.rs line 119 at r3 (raw file):
Previously, Yael-Starkware (YaelD) wrote…
so the fixture didn't work?

It did. stateful_validator was removed.

crates/gateway/src/stateful_transaction_validator_test.rs line 119 at r3 (raw file):
Previously, ArniStarkware (Arnon Hod) wrote…
It did. stateful_validator was removed.

stateful validator is now a fixture of the test.
There is no need for chain_info to be a fixture - as this is the only test where it is used.


text:
feat(transaction): derive  for transaction version wrapper enum types

It's useful to have this kind of wrapper type implement Form
#[derive(Debug, Clone, Eq, PartialEq, Hash, Deserialize, Serialize, PartialOrd, Ord)]
pub enum DeclareTransaction {
    V0(DeclareTransactionV0V1),
    V1(DeclareTransactionV0V1),
    V2(DeclareTransactionV2),
}

Because V0 and V1 are internally the same types, it is not possible to derive From on this enum. Which is a bit weird. Did you consider something like this:
pub enum DeclareTransaction {
    V0V1(DeclareTransactionV0V1),
    V2(DeclareTransactionV2),
}

This change is

@yair-starkware I believe you were the one doing those changes. Can you review this PR?

@giladchase Can we merge?

@giladchase can you rebase and merge it?

repo: starkware-libs/starknet-api


text:
implemented batch inverse in secure field eval

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#520  👈
#519
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ohad-starkware and the rest of your teammates on  Graphite

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.16%. Comparing base (7d70108) to head (b4601e2).

Additional details and impacted files
@@                           Coverage Diff                           @@
##           ohad/batch_inverse/fix_non_pow_2_sizes     #520   +/-   ##
=======================================================================
  Coverage                                   94.16%   94.16%
=======================================================================
  Files                                          60       60
  Lines                                        9238     9242    +4
  Branches                                     9238     9242    +4
=======================================================================
+ Hits                                         8699     8703    +4
  Misses                                        485      485
  Partials                                       54       54

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

authors: codecov-commenter ohad-starkware

repo: starkware-libs/stwo


text:
Prenatal and postnatal transmission

Description
Separates maternal transmission into prenatal and postnatal modules.
This is necessary because transmission probabilities vary. We could alternatively change the network betas, but this way allows us more flexibility to have disease-dependent differences - e.g. maternal transmission of syphilis only occurs during pregnancy, whereas for HIV it can also happen during breastfeeding.
Checklist

[x] Code commented & docstrings added
[x] New tests were needed and have been added
[x] A new version number was needed & changelog has been updated
[ ] A new PyPI version needs to be released

What is the benefit of a separate network layers for prenatal and postnatal if all of the nodes and edges are the same as the current pregnancy network? Instead, wouldn't it be more straightforward for transmission, either via rel_trans of the mother, 'rel_sus' of the baby, or 'beta' for the edge, to vary as a function of the age of the baby? I suspect that transmission likely should vary with age in any case through pre- and post-natal periods.

For the record, @robynstuart, @cliffckerr, and I discussed the following on Slack.
The transmission parameter, beta, associated with each edge applies to all diseases, so cannot be used to differentially transmit one disease and not another. The other two key parameters that control transmissibility are rel_sus and rel_trans, which are individual-level parameters. Therefore, we would not want to modify rel_trans of a mother during the pre-natal period because doing so would alter horizontal transmission. Modifying rel_sus for each baby and for each disease as a function of age would work.
This PR splits the pregnancy network into two: a prenatal network and a postnatal network. This additional resolution can facilitate disease-differential transmission during these periods, but it may still be necessary to modify rel_sus of the baby to e.g. adapt transmission by trimester.

authors: daniel-klein robynstuart

repo: starsimhub/starsim


text:
Add Philips Aura and Philips Hue Iris

Both lights are added in Zigbee2Mqtt, but not in the Domoticz Plugin
Add Philips Aura

{
zigbeeModel: ['LLC014'],
model: '7099860PH',
vendor: 'Philips',
description: 'LivingColors Aura',
extend: hue.light_onoff_brightness_colorxy,
}

and  Add Philips Hue Iris

{
zigbeeModel: ['LLC010'],
model: '7199960PH',
vendor: 'Philips',
description: 'Hue Iris',
extend: hue.light_onoff_brightness_colorxy,
}

I'm not complety familair with the plugin so if you need more information, please ask and I will check! Thank you so much.

Hi @Roeliooo, I added missing Philips devices to plugin. Could you please update it and check.

Thanks mate, everything works! Great Job. Happy holidays.

authors: Roeliooo stas-demydiuk


text:
Add communication entity

Resolve #2

Codecov Report

Merging #44 (91bf80a) into main (fb9f432) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           65        67    +2
  Lines          993      1024   +31
=========================================
+ Hits           993      1024   +31

Impacted Files
Coverage Δ

aioalfacrm/client.py
100.00% <100.00%> (ø)

aioalfacrm/entities/__init__.py
100.00% <100.00%> (ø)

aioalfacrm/entities/communication.py
100.00% <100.00%> (ø)

aioalfacrm/managers/__init__.py
100.00% <100.00%> (ø)

aioalfacrm/managers/communication.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb9f432...91bf80a. Read the comment docs.


text:
Bug: Sending an event to an actor ref in context does not work as described in the docs

Description
As described in the v4 docs on the sendTo action, sendTo can take an actor ref from context, which was created using spawn.
But the example doesn't work: I copied and pasted the example, added just enough code to make it run (see repro), and the spawned machine doesn't receive the PING event.
There is a workaround which does work, directly calling the spawned machine's bound send by accessing it via the ref. Doing this, I do see the response to the FIZZ event.
Expected result
Console log:
received some event
PONG
received some other event
BUZZ

Actual result
Console log:
received some event
received some other event
BUZZ

Reproduction
https://codesandbox.io/s/hardcore-austin-gssq95?file=/src/index.js
Additional context
No response

The sendTo action is not imperative; it is an action creator that returns an action object.
Function actions are fire-and-forget actions; their result is discarded.
The example should be rewritten like this:
// instead of:
// (context) => sendTo(context.someRef, { type: "PING" })
sendTo(context => context.someRef, { type: 'PING' })

See here for a working example: https://codesandbox.io/s/epic-panka-dfsq64

Thanks! That makes a lot of sense.
But as a follow-up question, wouldn't that make the example in the docs wrong?
SOME_EVENT: {
          actions: (context) =>
            sendTo(context.someRef, { type: 'PING' }),
        },

authors: charislam davidkpiano

repo: statelyai/xstate


text:
feat: uds

Description

This is a very crude proof of concept for implementing unix domain socket support. Currently only uds works and the path is hardcoded to /tmp/sws.sock. I wanted to have some feedback first, before fully implementing this. Here are a few points i would like to have feedback on / discuss:

How should the different server types be handled in the configuration? Currently there is a boolean to enable http2, but this wont work with three distinct types. A simple solution would be to replace the http2 boolean with a listen_type (or similar) String.
The start_server method is a bit too long imo, does it make sense to have seperate start functions for each type? On the other hand there is already some duplicate code in there, and splitting that into functions would make it harder to reuse code across listeners.

Related Issue

closes #484
Motivation and Context

See #484
I mainly want this because remembering paths is simpler than remembering ports, and for the performance.
How Has This Been Tested?

Tested functionality with curl, works as expected.
Screenshots (if appropriate):

How should the different server types be handled in the configuration? Currently there is a boolean to enable http2, but this wont work with three distinct types. A simple solution would be to replace the http2 boolean with a listen_type (or similar) String.

It can be the three types, but let me think a bit about it, maybe we do not need to do this. I will come back to this point soon.

The start_server method is a bit too long imo, does it make sense to have seperate start functions for each type? On the other hand there is already some duplicate code in there, and splitting that into functions would make it harder to reuse code across listeners.

Yes, that method is convoluted and we are aware of that. About this, there was an attempt to extract functionality and improve the code, for example, https://github.com/static-web-server/static-web-server/pull/377, but unfortunately got stuck.
It makes total sense to start moving out stuff to proper functions/modules and simplifying the code as well.
The question is, do you want to do it before UDS or after?

Server types

Im sure there doesn't need to be a server_type key. One option would be to create http_listener, http2_listener and socket_listener options which are mutually exclusive for example. Though im not sure how easy doing mutually exclusive options is with the current configuration file impl. I think having an explicit server_type is the easiest to implement and understand from a user perspective. I may have missed something though.

Refactoring start_server

I think it makes sense to do the refactoring together with adding uds support. The uds part isn't that big of a change i think so the changes should still be manageable.
My rough idea is to add the ServerType enum to the Server struct and turn it into a builder of some sorts. I should probably find some time later this week to really start working on this.

Im sure there doesn't need to be a server_type key. One option would be to create http_listener, http2_listener and socket_listener options which are mutually exclusive for example. Though im not sure how easy doing mutually exclusive options is with the current configuration file impl. I think having an explicit server_type is the easiest to implement and understand from a user perspective. I may have missed something though.

Honestly, It sounds fine to me. I also think this should allow us to decouple tls from http2 and deprecate --http2-cert/key in favor of more concise options like --tls, --tls-cert, --tls-key in the future (just an idea).
But keep in mind do not disrupt existing functionality and properly advise users to give them a proper path to migrate if the case.

I think it makes sense to do the refactoring together with adding uds support. The uds part isn't that big of a change i think so the changes should still be manageable.
My rough idea is to add the ServerType enum to the Server struct and turn it into a builder of some sorts. I should probably find some time later this week to really start working on this.

Feel free to go ahead. A prototype of this should be good to see.
Just take into account not to complicate yourself too much in the first phase. Maybe you want to split up the work in recessive PRs before or after UDS.
If you need any help just let me know.

What about an interface like this below that could convert from PathBuf::from(s) or s.parse::<IpAddr>()? (just an idea).
pub enum Interface {
    Address(IpAddr),
    Path(PathBuf),
}

authors: Jeidnx joseluisq

repo: static-web-server/static-web-server


text:
Melhoria prazo

Correção para quando a consulta de prazo tem somente um serviço.
#347

Não é necessario este Pull, vou explicar no issue

repo: stavarengo/php-sigep


text:
Fix for Unicode characters handling

Proposal to fix #114 implemented in Java and C#
For future reference, here I partially adapted the solution from: https://github.com/eclipse-vertx/vertx-uri-template/blob/25c479b7c0a58f2a1222e1ecb1e62f32ba0fd195/src/main/java/io/vertx/uritemplate/impl/UriTemplateImpl.java#L435-L459

I expanded the fix to all of the languages confident that this PR correctly fixes the reported bug.

repo: std-uritemplate/std-uritemplate


text:
feat: add C implementation for @stdlib/stats/base/dists/bernoulli/mode

Resolves #3417.
Description

adds C implementation for @stdlib/stats/base/dists/arcsine/mode along with relevant tests, benchmarks and examples

This pull request:

Progresses: https://github.com/stdlib-js/stdlib/issues/3417

Questions

Any questions for reviewers of this pull request?

No.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.
Checklist

Please ensure the following tasks are completed before submitting this pull request.

[x] Read, understood, and followed the contributing guidelines

@stdlib-js/reviewers

/stdlib update-copyright-years

repo: stdlib-js/stdlib


text:
Remove unstable let-else statements from cw-ownable-derive.

resolves #10
this will let this crate be used in workspaces that use stable rust.

@larry0x if would be great if you wouldn't mind cutting a release with this change (if you'd like to land it), as that'll unblock my cw-nfts PR. though there is absolutely no rush and it can wait for the work week if you're doing weekend things.

I think the let-else syntax has already been stablized in Rust 1.65?
See: https://twitter.com/m_ou_se/status/1588190804782116864

I have this CI task that compiles the who repo into the wasm target using the stable toolchain. If this CI task passes, then crates in this repo should all be usable in CosmWasm + stable Rust.

you're so right. the CI job ib cw-nfts was using the old Rust version. thanks. :)
https://github.com/CosmWasm/cw-nfts/pull/109/commits/7a0c0c3af79a9f6eea4735b8bb515b17066b5468

repo: steak-enjoyers/cw-plus-plus


text:
Siesta cannot be used as a producer

syncSendAndReceive is unexported, though ProduceRequest is defined, there is no method to send them out. So basically Siesta cannot be used as a producer. Is it designed purposely like this?

@hailiang producer is being actively developed here: https://github.com/stealthly/siesta/tree/producer

Thanks. When will the producer code merged to master branch?

Producer is nearly finished, but it will take some time to test it properly, maybe in a couple days.

I checked the code on producer branch, but a "Send" method is still missing in the Connector type.

It's not in repo yet, in active development right now.

authors: hailiang serejja yanzay

repo: stealthly/siesta


text:
去掉对不必要包的直接引用，比如 aliyun-sdk

aliyun-sdk 只有在启用aliyun的时候才 require 和 checkNpm
aws-sdk， qcloud 等 类似
formbuilder 只在前clientcheckNpm

[ ] aliyun-sdk
[ ] aws-sdk
[ ] dropbox
[ ] aliyun-sms-node
[ ] weixin-pay

authors: steedos sunhaolin

repo: steedos/creator


text:
crash's on trying any listing option

raspberry B+
OSMC 2016.01-1
plugin.video.pulsar-0.6.1
22:29:21 275.007202 T:2650199072  NOTICE: [plugin.video.pulsar] pulsard: starting pulsard
22:29:21 275.038574 T:2705323040   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <class 'httplib.BadStatusLine'>
Error Contents: ''
Traceback (most recent call last):
File "/home/osmc/.kodi/addons/plugin.video.pulsar/navigation.py", line 6, in
navigation.run()
File "/home/osmc/.kodi/addons/plugin.video.pulsar/resources/site-packages/pulsar/navigation.py", line 64, in run
data = _json(url)
File "/home/osmc/.kodi/addons/plugin.video.pulsar/resources/site-packages/pulsar/navigation.py", line 43, in _json
with closing(urllib2.urlopen(url)) as response:
File "/usr/lib/python2.7/urllib2.py", line 154, in urlopen
return opener.open(url, data, timeout)
File "/usr/lib/python2.7/urllib2.py", line 431, in open
response = self._open(req, data)
File "/usr/lib/python2.7/urllib2.py", line 449, in _open
'_open', req)
File "/usr/lib/python2.7/urllib2.py", line 409, in _call_chain
result = func(*args)
File "/usr/lib/python2.7/urllib2.py", line 1227, in http_open
return self.do_open(httplib.HTTPConnection, req)
File "/usr/lib/python2.7/urllib2.py", line 1200, in do_open
r = h.getresponse(buffering=True)
File "/usr/lib/python2.7/httplib.py", line 1073, in getresponse
response.begin()
File "/usr/lib/python2.7/httplib.py", line 415, in begin
version, status, reason = self._read_status()
File "/usr/lib/python2.7/httplib.py", line 379, in _read_status
raise BadStatusLine(line)
BadStatusLine: ''
-->End of Python script error report<--
22:29:21 275.054749 T:2650199072  NOTICE: [plugin.video.pulsar] Deleting stale files set([])
22:29:22 275.698181 T:3024859696   ERROR: GetDirectory - Error getting plugin://plugin.video.pulsar/movies/popular
22:29:22 275.718781 T:3024859696   ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.video.pulsar/movies/popular) failed

tried again using version 0.5.0, same crash.

I'm having the same issue in OpenElec. It appears Pulsar is finally dead. I'll be trying out Quasar on my system tonight to see if it's a full replacement.
https://github.com/scakemyer/plugin.video.quasar

got the same issue, version 0.7
log: http://xbmclogs.com/peutwwk96

Interesting, seems like pulsar is going against a specific thetvdb endpoint wich is returning 404s

Oh, didn't see that this is no longer mantained. Sorry.

Any news ? Because the error is still there.. Can't browse movies nor tv shows...

Use quassar, this is  no longer mantained

Thanks I just understood your last comment :)

authors: IVXCVI XayOn esdf mehdicopter rudamaia


text:
SEP-09: Add clabe_number support to anchor platform

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
[TODO: Short statement about what is changing.]
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]

Reference Server Preview is available here:https://anchor-ref-pr373.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr373.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr373.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr373.previews.kube001.services.stellar-ops.com/

authors: erika-sdf stellar-jenkins

repo: stellar/java-stellar-anchor-sdk


text:
Cherry pick the database backoff timer to improve the stability when the database connection is list

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Cherry pick the commit that implements the database backoff timer to improve the stability when the database connection is list
Why
Improve the stability of the stellar payment observer
Known limitations
N/A

Reference Server Preview is available here:https://anchor-ref-pr796.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr796.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check


text:
Allow zero fees

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
ANCHOR-273 Allow zero fees in patch transaction
Why
Currently exception is throw if fee is zero
Known limitations
N/A

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

authors: Ifropc stellar-jenkins


text:
[ANCHOR-351] Add the missing unmock for RequestLoggerFilterTest

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
RequestLoggerFilterTest is missing the mockk unmockAll() and clearAllMocks() which may cause subsequent tests to fail.
Why
Bug fixing.

Reference Server Preview is available here:https://anchor-ref-pr965.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr965.previews.kube001.services.stellar-ops.com/


text:
XDR parse errors aren't handled

The current state:

Converting XDR to JSON in https://lab.stellar.org/

authors: janewang robertDurst

repo: stellar/laboratory


text:
Updates for the benchmark tests

Update current logic that invokes load generation to handle new parameters
Add new functionality that will be used in the load test (see https://github.com/stellar/stellar-core-acceptance/pull/79)

Thanks for reviewing! Updated the code.

FYI, this needs to be rebased

authors: MonsieurNicolas marta-lokhova


text:
trying to check kubernetes yamls

Hi, I'm running:
docker run -v $(pwd):/foobar stelligent/config-lint -rules example-files/rules/kubernetes.yml /foobar/configmap.yaml`

but I get this response:
Failed to load rules: open example-files/rules/kubernetes.yml: no such file or directory

When I run:
docker run -v $(pwd):/foobar stelligent/config-lint -rules

It gives:
flag needs an argument: -rules
Usage of /config-lint:
  -debug
    	Debug logging
  -exclude value
    	Filename pattern

(etc., etc..) So it appears to run ok, but can't find the rules. As I can't look inside the container (it exits straightaway) I'm struggling to debug. I just want to check kubernetes files, nothing else.
Thanks,
Matt

@namloc2001 You will need to put the example Kubernetes rules into your local path and referencing to it accordingly, or you can have your own set of rules that you want to validate against.
For example:
docker run -v $(pwd):/foobar stelligent/config-lint -rules /foobar/path/to/my/rules/kubernetes.yml /foobar/path/to/my/configs/configmap.yaml

If you don't have your own set of custom rules that you want to run against your Kubernetes file then feel free to copy or download the example set that is listed here within the project.
At this time there isn't a default rule set for Kubernetes, but I will go ahead and create a new Issue for this as a new feature request.

Issue #151 has been created to handle this new feature request.

Thanks, I've created a pull request to apply some changes to the README.md as this had me stumped for a while.

repo: stelligent/config-lint


text:
Domains that resolve to localhost do not show up in recommended policy

https://github.com/Automattic/vip-go-mu-plugins/pull/2815#issuecomment-1014226438

@varunsh-coder I am handling this issue

repo: step-security/agent


text:
How to debug "unexpected wire type WireTypeFixed32"

Hi,
I'm trying to read a kafka topic which contains values that have been serialised using protobuf.
I successfully managed to generate rust mods and all... and come out with
let x: &[u8] = m.value; // this comes from kafka-rust api... basically for each message you have m.key and m.value
let parsed = parse_from_bytes::<Thingie>(x).unwrap();

This compiles just fine (and I'm not really handling the Result I know...)
A runtime I get WireError("unexpected wire type WireTypeFixed32")'
How could I check what's going on?

Well, I can help if you attach serialized data and .proto file.
However, rust-protobuf could provide better diagnostic message, in particular, it could tell a position of error and message being parsed.

Ok. For now I can just let you see the complete error message

thread 'main' panicked at 'called Result::unwrap() on an Err value: WireError("unexpected wire type WireTypeFixed32")', ../src/libcore/result.rs:837
note: Run with RUST_BACKTRACE=1 for a backtrace.

Solved! I was using the wrong proto. Sorry about this!

authors: stepancheg whiplash

repo: stepancheg/rust-protobuf


text:
'next' is not recognized as an internal or external command

hi im just try run command  npm run dev to try it , but look what i got . please help

hi im just try run command npm run dev to try it , but look what i got . please help

Have you tried deleting your node_module folder and reinstalling all dependencies?

how to do that ? whats commands ?

Simply, delete node_module directory and reinstall all dependencies by using npm run install

authors: khanfar stephenasuncionDEV

repo: stephenasuncionDEV/nfthost


text:
Add Coding support

Insert or update from an Encodable type
Decode a row into a Decodable type

Closes stephencelis/SQLite.swift#727

/Users/travis/build/stephencelis/SQLite.swift/Tests/SQLiteTests/QueryTests.swift:291: error: -[SQLite_swift_Unit_Tests.QueryTests test_update_encodable_with_nested_encodable] :

XCTAssertEqual failed:

("UPDATE "emails" SET "int" = 1, "string" = '2', "bool" = 1, "float" = 3.0, "double" = 4.0, "sub" = x'7b22626f6f6c223a747275652c22737472696e67223a2232222c22666c6f6174223a332c22696e74223a312c22646f75626c65223a347d'")

is not equal to

("UPDATE "emails" SET "int" = 1, "string" = '2', "bool" = 1, "float" = 3.0, "double" = 4.0, "sub" = x'7b22626f6f6c223a747275652c22666c6f6174223a332c22646f75626c65223a342c22696e74223a312c22737472696e67223a2232227d'")

How do I run this configuration to reproduce the error? (preferably in Xcode)

$ cd Tests/CocoaPods
$ make test VALIDATOR_SUBSPEC="standard"
[...]
> Pod installation complete! There are 2 dependencies from the Podfile and 1 total pod installed.
   Building with xcodebuild.
xcodebuild clean build
-workspace /some/path/SQLite.swift/App.xcworkspace
-scheme App -configuration Release
CODE_SIGN_IDENTITY=- -sdk iphonesimulator
 -destination id=C1943A91-1C60-4111-8918-23D1C0D3186B
[...]
[CTRL+C]
Interrupted. Exiting...

open App.xcworkspace in Xcode, select SQLite.swift-Unit Tests scheme, ⌘U
Runs ok on my machine though.

Ok ya, the problem is that hex string for the encoded JSON. The JSON is sometimes coming out in a different order. I might have to pull the hex string out of the SQL, convert it back into a JSON object, and validate the object. Any thoughts on an easier option?

maybe JSONEncoder.OutputFormatting.sortedKeys ?
Why is the JSON stored in the DB as hex? wouldn't it be easier to just store the data as string?

sortedKeys is only available on High Sierra. I think I am just going generate the desired JSON in the test directly from the object.
I don't have a strong reason for storing it as data except it would be an extra conversion before inserting it (the JSONEncoder exports data). Do you think I should store it as a string? (not sure if there is any space/performance implications)

Ah, is this just the JSON UTF-8 data? I assumed it was base64 or similar. Sqlite has good JSON support so it wouldn't make sense to encode it in another format.

Actually, compatibility is another point I wanted to raise. The deployment target is 8.0 so this code would need to get put behind @availability?

no just the sortedKeys has limited availability. The existing implementation is fully supported on 8.0.
Yes the that is just the UTF-8 data as a hex string. It is the result of using an Expression for the insert. How do I take advantage of the JSON support you are referring to?

FYI, I now have a build that I believe will pass all of the CI. I am just waiting to see if we have a better way to represent any nested objects in the database. I am even happy to explore other options than JSON.

I don't think stock SQLite has it enabled, but when using CocoaPods you can specify the build flags:
pod 'SQLite.swift/standalone'
pod 'sqlite3/json'

Won't that break manual installation? Either way, it looks like the JSON extension still just stores the JSON as regular text:

https://sqlite.org/json1.html
The json1 extension (currently) stores JSON as ordinary text.

So it doesn't seem like it would help in this situation at all because the code does not have to manipulate the JSON at all. However, if someone wants to insert it using Coding but then manipulate it later it seems best to store it as plain text. So unless you don't agree, I will update it to store as a normal string.

yes, it won't help for storage but for querying. It shouldn't make a difference in SQLite if you store the data as UTF-8 hex or string. Hex strings have some overhead in pure transmission size though.

To keep Query.swift more manageable, can you move the new coding/decoding relating code into a separate file? Other than that it needs a changelog entry and maybe a brief mention in Documentation/Index.md.

thanks!

You're welcome, thanks for the great library!

Hello,
I don't quite get this test: https://github.com/stephencelis/SQLite.swift/pull/733/files#diff-7e8883d8ae5007060a25949445db3611R283
func test_update_encodable() throws {
    let emails = Table("emails")
    let value = TestCodable(int: 1, string: "2", bool: true, float: 3, double: 4, optional: nil, sub: nil)
    let update = try emails.update(value)
    AssertSQL(
        "UPDATE \"emails\" SET \"int\" = 1, \"string\" = '2', \"bool\" = 1, \"float\" = 3.0, \"double\" = 4.0",
        update
    )
}

Does it mean that using the update method on an instance of a Codable type updates all table rows?
If this is true, then maybe the documentation should be updated so that users understand that they shouldn't write code like below:
let players = Table("players")

// OK: insert a player
var player = Player(id: 1, name: "arthur", score: 1000)
try db.run(players.insert(player))

// Oops: does not update the expected row
player.score = 2000
try db.run(players.update(player))

@groue your example would indeed update the intended rows because it updates all rows. Of course that ultimately depends on that types implementation of the coding protocols. They could choose to use user info to indicate partial updates.

ORM

That's a quick and easy derivation from Codable, indeed. Maybe even an expectation. After all, when you encode a bunch of codable values in json or plist, every one of them has its own and unique place in the serialized format.
What would be the canonical sample code, then?
On the ORM look-alike path, this could be something along:

Hypothesis 1: don't encode primary key in the Codable type:
// Table has id, name & score columns
let players = Table("players")

// Codable type without identity
struct PlayerAttributes: Codable {
    var name: String
    var score: Int
}

// OK: insert a player
var player = PlayerAttributes(name: "arthur", score: 1000)
let playerId = try db.run(players.insert(player))

// OK: update the expected player
player.score = 2000
try db.run(players.filter(id == playerId).update(player))

Hypothesis 2: encode the primary key in the Codable type
// Table has id, name & score columns
let players = Table("players")

// Codable type with identity
struct Player: Codable {
    var id: Int64?
    var name: String
    var score: Int
}

// OK: insert a player
var player = Player(id: nil, name: "arthur", score: 1000)
player.id = try db.run(players.insert(player))

// OK: update the expected player
player.score = 2000
try db.run(players.filter(id == player.id).update(player))

Even if you want to flush out all similarities with ORM, in order to avoid users building wrong expectations, it would greatly help if the documentation should clarify this topic, I think.

Is there any reason the Int64, Int32 ...  types can't be supported?

authors: drewag groue jberkel newlix


text:
🛑 Ingot is down

In 353c0db, Ingot (https://www.ingot.cloud/css/general.css) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Ingot is back up in de4ddb3 after 54 minutes.

repo: stephenmott/webmonitor


text:
BUG: Show Service ID of Clients for Modification of Connection in Custom Installation

Describe the bug
Show the service ID for the Clients when selecting their connection.
Screenshots

Because of the limited space in the component itself I either propose one of the solutions or a combination of them.
1# changing the displayed text every few seconds
2# Use a tooltip showing the ID when hovering
3#  When hovering visually change (f.e. with a border) the connected client in question

Screenshot plz :)

Screenshot plz :)

100%. Meant is this:

In this example - it could potentially lead to some problems if you have multiple Geth clients & you don't know which Geth is which.
1# The text "Geth" would just change into a shortened ID
2# Whenever you are hovering "GETH" you can see the ID in tooltip
3# When hovering Geth or selecting the client - the connected clients (or all the non connected) change visible.

I have a few suggestions for this. Still thinking what would be the best. Lets talk Monday

Sure.

[ ] Im "Add"
[ ] Im "Modify"

repo: stereum-dev/ethereum-node


text:
attach_mode=global work only with one window

Minimal config:
aerial.setup {
  attach_mode = "global",
  highlight_mode = "last",
  open_automatic = function(bufnr)
    return vim.treesitter.highlighter.active[bufnr] ~= nil
  end,
}

Just split window and select him. Actual result:
Error detected while processing CursorMoved Autocommands for "<buffer=14>":
E5108: Error executing lua ...m/site/pack/packer/opt/aerial.nvim/lua/aerial/window.lua:461: Invalid buffer id: -1
stack traceback:
        [C]: in function 'nvim_buf_line_count'
        ...m/site/pack/packer/opt/aerial.nvim/lua/aerial/window.lua:461: in function 'update_position'
        .../pack/packer/opt/aerial.nvim/lua/aerial/autocommands.lua:125: in function 'on_cursor_move'
        [string ":lua"]:1: in main chunk

Error executing vim.schedule lua callback: ...m/site/pack/packer/opt/aerial.nvim/lua/aerial/window.lua:461: Invalid buffer id: -1
stack traceback:
        [C]: in function 'nvim_buf_line_count'
        ...m/site/pack/packer/opt/aerial.nvim/lua/aerial/window.lua:461: in function 'update_position'
        ...m/site/pack/packer/opt/aerial.nvim/lua/aerial/window.lua:412: in function 'update_all_positions'
        ...pack/packer/opt/aerial.nvim/lua/aerial/backends/init.lua:151: in function 'set_symbols'
        .../opt/aerial.nvim/lua/aerial/backends/treesitter/init.lua:118: in function 'fetch_symbols'
        .../opt/aerial.nvim/lua/aerial/backends/treesitter/init.lua:125: in function 'attach'
        ...pack/packer/opt/aerial.nvim/lua/aerial/backends/init.lua:99: in function 'attach'
        ...pack/packer/opt/aerial.nvim/lua/aerial/backends/init.lua:193: in function 'attach'
        .../packer/opt/aerial.nvim/lua/aerial/backends/lsp/init.lua:109: in function 'on_attach'
        ...vim/site/pack/packer/opt/aerial.nvim/lua/aerial/init.lua:122: in function 'cb'
        /Users/qroc/.config/nvim/lua/core/lsp.lua:14: in function '_on_attach'
        ...ck/packer/start/nvim-lspconfig/lua/lspconfig/configs.lua:292: in function '_setup_buffer'
        ...ck/packer/start/nvim-lspconfig/lua/lspconfig/configs.lua:195: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

Should be fixed!

Wonderful - thank you!

authors: qRoC stevearc vsonicmu


text:
Import libraries from Dependency-Check

Auto-populate Dependency-Track database with library identification from Dependency-Check

Could I know the progress of this? This one is important. We've already have lots of dependencies. It is will be best if you can have those dependencies imported into Dependency Track.

I have not started work on this. When I do, you'll see commit messages as part of the ticket.

Foundation of this provided by 673c7d2 Much more cleanup to do, but feature-wise, the functionality is there.

authors: stevespringett willpowerforever

repo: stevespringett/dependency-track


text:
Add category subtotals

Add category subtotals in their own column at the end of the gradebook with a data- attribute of the category id so that they can be repositioned when we group by column.
When grouped by category, they should appear as the last item and be not movable.

Show percentage for category. If this doesnt already have a service API method to calculate it,  looks like summing up the scores, ignoring blanks and those that arent included in course grade calculation, and displayed as a percentage of total points possible for the sum of all assignments in that category.

This is done, awaiting on https://github.com/sakaiproject/sakai/pull/839 though.
The other thing is that the category calcs are a little slow, so we should wrap this in a
if(settings.isCategoriesEnabled()) block in the UI and also pass that flag to the backend. This will mean it only does the work if the checkbox is checked. However I'm leaving it as is so we can discuss, then I'll make that change :)

A few things left to do:

Add applicable CSS classes and ARIA attributes
Guard calls with the categoriesEnabled flag.
Pass this flag to the matrix builder to save it doing the work

Hey Steve. Kyle and looked at this and we're seeing some issues with scrolling right/left: http://screencast.com/t/GBLT5P7UWUm

Discussed on the call. Category columns will always display so no need to check the settings and pass that through to the backend. Still need classes and aria attributes, will be done separately.

This issue was moved to sakaiproject/sakai#1345

authors: jeffpasch steveswinsburg

repo: steveswinsburg/gradebookNG


text:
Deprecate configuring ember-cli-memory-leak-detector via config/environment.js

Since all the work happens at build time, we can ask the user to define the configuration in ember-cli-build.js instead. This also prevents the configuration from being added to the app's meta tag even when ember-cli-memory-leak-detector is disabled.
Closes #39.

@steveszc Any pointers on getting CI to pass? I could be wrong, but it seems that the test apps are using a published version of ember-cli-memory-leak-detector during CI? If that's the case, then I'm not sure how I can make CI pass here.

@bertdeblock oh nice catch, I think you are probably right. Feel free to push another commit to this branch that uses '*' as the version number for ember-cli-memory-leak-detector dependency in the test packages. I think that is probably the right approach here... we could also update the version number in the test packages, but that could easily get out of date again.

Okay, updated those versions and now (hopefully) CI should pass. I've noticed that running the test suite locally sometimes fails and sometimes it doesn't, even for the main branch. Unclear to me as to why this happens.

@steveszc Mind approving the workflow?

authors: bertdeblock steveszc

repo: steveszc/ember-cli-memory-leak-detector


text:
question

Hello
I need an open source maching engine that can process sales orders that are placed in the database through the app, that is, I can finally create something like a binance.
Please advise that this engine of yours can run alongside my app? For example, the membership and wallet sections should be deposited or withdrawn in the my app, and only the trading section should be run in this maching engine?
aslo please show diagram with english
https://raw.githubusercontent.com/stingbo/image/master/数字货币交易所-基于redis的简单撮单引擎.png

I'm sorry, the English instructions came too late.

authors: stingbo vahidalvandi

repo: stingbo/mengine


text:
Improve compatibility with CM6

Now that CM6 is out and has an NPM package this allows one to install both this mode and CM6:
{
  "dependencies": {
    "codemirror": "6",
    "nim-codemirror-mode": ""
  },
}

ATM it dies with this despite this mode working fine under back-compat with CM6:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: undefined@undefined
npm ERR! Found: codemirror@6.0.0
npm ERR! node_modules/codemirror
npm ERR!   codemirror@"6" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer codemirror@"^5.56.0" from nim-codemirror-mode@0.3.0
npm ERR! node_modules/nim-codemirror-mode
npm ERR!   nim-codemirror-mode@"" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

LGTM! Thanks, I wasn't aware CM6 was out

LGTM! Thanks, I wasn't aware CM6 was out.
PS: I'll update the npm package in the next couple days

Any chance of that npm release? Thanks.

Any chance of that npm release? Thanks.

Done, sorry I forgot about it

Many thanks! :clap:

authors: JRaspass stisa

repo: stisa/nim-codemirror-mode


text:
Call the server only once to refresh all home page data

This adds the data that's needed to the objects returned by the resques#index and cuts out the individual calls for each app.... I don't really know angular, so I'm not 100% sure this is a nice change at that level.
I'm also don't know if my change will make resques#index super slow in prod. Still investigating.

This looks good!

repo: stitchfix/resque-brain


text:
Fixes Unexpectedly Found Nil When Unwrapping Optional in WebAuthenticationPresenter

This pull request fixes the unexpectedly found nil when unwrapping optional by using ASPresentationAnchor() for iOS 13+ and MacOS 10.15+, otherwise defaults to original behavior.

Great! I really appreciate your work on fixing this issue!
This improvement will be available in v2.4.1 shortly :)

authors: kevvdevv stleamist

repo: stleamist/BetterSafariView


text:
Remove compiler warnings: TransformType

lots of these on linux gcc (GCC) 4.4.6
/home/avants/ANTsR/src/ants/Examples/antsRegistration4DDouble.cxx:8:   instantiated from here
/home/avants/ANTsR/src/ants/Examples/itkantsRegistrationHelper.h:818: warning: declaration of ‘TransformType’ shadows a member of 'this'

Right.  I fixed that this morning.  Have you tried to compile since about 11 am your time?

yes - but probably using an older version of ants, i.e. whatever is in
github antsr gittag.
so will close.
brian
On Wed, Mar 25, 2015 at 4:05 PM, Nick Tustison notifications@github.com
wrote:

Right. I fixed that this morning. Have you tried to compile since about 11
am your time?
—
Reply to this email directly or view it on GitHub
https://github.com/stnava/ANTs/issues/176#issuecomment-86198030.

authors: ntustison stnava

repo: stnava/ANTs


text:
add RBAC to list multiclusterengines to fix ACM-4230

Add a cluster role rule to list multiclusterengines to fix https://issues.redhat.com/browse/ACM-4230 and https://github.com/stolostron/backlog/issues/27211

/lgtm

/lgtm

authors: cameronmwall rokej

repo: stolostron/backplane-operator


text:
add service account permissions

Description
Add OCP and Remote permissions to Service Account
Related Issue
ACM-11030
Changes Made
add permissions to allow a Service Account to list OCP apps and remote apps
Checklist

[ ] I have tested the changes locally and they are functioning as expected.
[ ] I have updated the documentation (if necessary) to reflect the changes.
[ ] I have added/updated relevant unit tests (if applicable).
[ ] I have ensured that my code follows the project's coding standards.
[ ] I have checked for any potential security issues and addressed them.
[ ] I have added necessary comments to the code, especially in complex or unclear sections.
[ ] I have rebased my branch on top of the latest main/master branch.

Additional Notes
Add any additional notes, context, or information that might be helpful for reviewers.
Reviewers
Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2
Definition of Done

[ ] Code is reviewed.
[ ] Code is tested.
[ ] Documentation is updated.
[ ] All checks and tests pass.
[ ] Approved by at least one reviewer.
[ ] Merged into the main/master branch.

/lgtm

authors: dislbenn jeswanke


text:
Upgrade go libs

Signed-off-by: xuezhaojun zxue@redhat.com
Related issue: https://github.com/stolostron/backlog/issues/18939

Left 3 repos unupgraded
github.com/openshift/library-go v0.0.0-20210916194400-ae21aab32431 [v0.0.0-20220325115610-a4cbaa780274]
open-cluster-management.io/addon-framework v0.0.0-20211020072210-50d435b65f83 [v0.3.0]
sigs.k8s.io/apiserver-network-proxy v0.0.4 [v0.0.30]

Because of the following issue:
go get sigs.k8s.io/apiserver-network-proxy

get error:
go get: sigs.k8s.io/apiserver-network-proxy/konnectivity-client@v0.0.0: reading sigs.k8s.io/apiserver-network-proxy/konnectivity-client/konnectivity-client/go.mod at revision konnectivity-client/v0.0.0: unknown revision konnectivity-client/v0.0.0

go get github.com/openshift/library-go

get error in build phare:
 github.com/openshift/client-go/config/clientset/versioned/typed/config/v1
vendor/github.com/openshift/client-go/config/clientset/versioned/typed/config/v1/imagecontentpolicy.go:25:53: undefined: v1.ImageContentPolicy

go get open-cluster-management.io/addon-framework@v0.3.0

get error:
go: finding module for package k8s.io/api/settings/v1alpha1
go: finding module for package k8s.io/api/batch/v2alpha1
github.com/stolostron/cluster-proxy-addon/pkg/hub imports
        open-cluster-management.io/addon-framework/pkg/utils imports
        github.com/openshift/library-go/pkg/operator/resource/resourceapply imports
        github.com/openshift/api imports
        k8s.io/api/batch/v2alpha1: module k8s.io/api@latest found (v0.23.5), but does not contain package k8s.io/api/batch/v2alpha1
github.com/stolostron/cluster-proxy-addon/pkg/hub imports
        open-cluster-management.io/addon-framework/pkg/utils imports
        github.com/openshift/library-go/pkg/operator/resource/resourceapply imports
        github.com/openshift/api imports
        k8s.io/api/settings/v1alpha1: module k8s.io/api@latest found (v0.23.5), but does not contain package k8s.io/api/settings/v1alpha1
github.com/stolostron/cluster-proxy-addon/pkg/cmd/hub imports
        github.com/openshift/library-go/pkg/controller/controllercmd: missing go.sum entry for module providing package github.com/openshift/library-go/pkg/controller/controllercmd (imported by github.com/stolostron/cluster-proxy-addon/pkg/cmd/hub); to add:
        go get github.com/stolostron/cluster-proxy-addon/pkg/cmd/hub
github.com/stolostron/cluster-proxy-addon/pkg/hub imports
        open-cluster-management.io/addon-framework/pkg/utils imports
        github.com/openshift/library-go/pkg/operator/events: missing go.sum entry for module providing package github.com/openshift/library-go/pkg/operator/events (imported by open-cluster-management.io/addon-framework/pkg/utils); to add:
        go get open-cluster-management.io/addon-framework/pkg/utils@v0.3.0
github.com/stolostron/cluster-proxy-addon/pkg/hub imports
        open-cluster-management.io/addon-framework/pkg/utils imports
        github.com/openshift/library-go/pkg/operator/resource/resourceapply: missing go.sum entry for module providing package github.com/openshift/library-go/pkg/operator/resource/resourceapply (imported by open-cluster-management.io/addon-framework/pkg/utils); to add:
        go get open-cluster-management.io/addon-framework/pkg/utils@v0.3.0
github.com/stolostron/cluster-proxy-addon/pkg/hub imports
        open-cluster-management.io/addon-framework/pkg/utils imports
        k8s.io/apiserver/pkg/server/healthz imports
        k8s.io/apiserver/pkg/endpoints/metrics imports
        k8s.io/apiserver/pkg/audit imports
        github.com/google/uuid: missing go.sum entry for module providing package github.com/google/uuid (imported by k8s.io/apiserver/pkg/audit); to add:
        go get k8s.io/apiserver/pkg/audit@v0.23.0

A script to get repos wait for upgrading is:
if [ ! -f upgrade.txt ]; then
    # -mod=mod is require for repo has vendor
    go list -mod=mod -m -u all > upgrade.txt # this may take a while
fi

cat go.mod | while read line
do
    # if any of these unwanted words show up, skip
    unwantWords=$(echo $line | grep -e "indirect" -e "module" -e "go 1.17" -e "require" -e ")" | wc -c)
    if [ "$line" != "" ] && [ $unwantWords -eq 0 ]; then
        array=($line)
        image=${array[0]}
        cat upgrade.txt | grep "$image " | while read img
        do
            numberOfSpace=$(echo $img | tr -cd ' ' | wc -c)
            if [ $numberOfSpace == 2 ]; then
                # e.g. the case `k8s.io/apimachinery v0.23.4 [v0.23.5]` has 2 spaces, and the case is what we want
                echo $img
            fi
        done
    fi
done

/assign @skeeey

/lgtm

authors: skeeey xuezhaojun

repo: stolostron/cluster-proxy-addon


text:
[ACM-10560] Added discovered cluster controller for automatic rosa import

Description
Implemented a DiscoveredCluster controller that will automatically import ROSA cluster into the ACM hub cluster. This will allow users to add an annotation to the cluster to trigger the automatic import
Related Issue
https://issues.redhat.com/browse/ACM-10560
Changes Made
Added new controller to import ROSA clusters automatically into ACM hub cluster.
Screenshots (if applicable)
Add screenshots or GIFs that demonstrate the changes visually, if relevant.
Checklist

[x] I have tested the changes locally and they are functioning as expected.
[ ] I have updated the documentation (if necessary) to reflect the changes.
[ ] I have added/updated relevant unit tests (if applicable).
[x] I have ensured that my code follows the project's coding standards.
[x] I have checked for any potential security issues and addressed them.
[x] I have added necessary comments to the code, especially in complex or unclear sections.
[x] I have rebased my branch on top of the latest main/master branch.

Additional Notes
Add any additional notes, context, or information that might be helpful for reviewers.
Reviewers
Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2
Definition of Done

[ ] Code is reviewed.
[ ] Code is tested.
[ ] Documentation is updated.
[ ] All checks and tests pass.
[ ] Approved by at least one reviewer.
[ ] Merged into the main/master branch.

/retest

/cc @cameronmwall @ngraham20 @joeg-pro

/unhold

/override "KinD tests (1.21, latest)"

repo: stolostron/discovery


text:
404 on docs don't show an error

If a doc is not found i.e. returns 404, show a nice looking not found page. We have not found already implemented in Platform so use that if possible.

Can't reproduce anymore!

repo: stoplightio/elements


text:
Anchor links in markdowns don't work in angular

Hi guys.
I'm testing this excellent project using Angular. And I'm having difficulties with the markdowns, the anchor links automatically set in the markdowns (titles: h1, h2 and h3). are pointing to the #link url. they do not respect the relative path on which the markdown is located, that is, the links are only leading to non-existent paths. I would like to know if there is another way to fix this problem, I found that with react it works fine.

The same goes for links in the markdown INSIDE the descriptions of endpoints/operations like
[SchemaName](../schemas/SchemaName)

(Although it's probably better to start supporting something like xref like they do here: https://dotnet.github.io/docfx/spec/docfx_flavored_markdown.html#cross-reference but then with full Scheme References like
#/components/schemas/SchemaName
They should all respect the basePath and current page. Especially since Angular sort of requires the <base href="/"> to be set.

authors: EraYaN danilotaira


text:
Google Scope beign passed with commas

Example &scope=openid,email,profile
causing
Error: invalid_scope
Some requested scopes were invalid. {invalid=[openid,email,profile]}

Hello @merkelct , can you show us how you are passing the scope values down to our library?  I believe it should work like this:
app.use(stormpath.init({
  web: {
    social:{
      google:{
        scope: 'openid email profile'
      }
    }
  }
}));

Thanks,
Robert

I am just following the example here and do not explicitly set the scopes
https://docs.stormpath.com/nodejs/express/latest/social_login.html#google-login
I tried adding what you have above but still get commas on the scopes it works fine fine if manually remove them from the url
  web: {
    social:{
      google:{
        scope: 'openid email profile'
      }
    }
  },
  website: true
}));```

Can you tell me which version of the express-stormpath module you are using?  Thanks.

   "express-stormpath": "^3.1.5",

I've identified the bug and the cause. Not sure if I personally have enough experience with this section of the codebase to do a fix, but I'll let @robertjd know and we'll get this fixed!

Hi @merkelct , this is a bug that we need to fix in our library.  In the meantime I think you can work around the issue by putting this in your server code:
app.on('stormpath.ready',function () {
  app.get('stormpathConfig').web.social.google.scope = 'bar';
});

That should force-overwrite the incorrect settings that we are pulling from our configuration, can you give this a try and let me know if it works for you?

Thanks, I will update this morning and report back if the fix works

FYI just added snippet from above and it worked thanks will keep and eye out for an update

Thanks @merkelct !  We just released the new 3.1.6 version of this library, which should also fi the problem.  Could you try upgrading and let us know if this fixes it too?

Update worked thanks guys.

authors: edjiang merkelct robertjd

repo: stormpath/express-stormpath


text:
13 Pro Max iOS 15.7.2 Misaka 8.0.1/2/3/4/5/6/7/8，TIPS are all gray, unable to enter KFD mode and restart repeatedly

13 Pro Max iOS 15.7.2 Misaka 8.0.1/2/3/4/5/6/7/8，TIPS are all gray, unable to enter KFD mode and restart repeatedly

Yes, I have the same problem. My device is air5 M1 15.7.2 TIPS. If you choose KFD mode in gray, the device will restart, but it cannot be changed to KFD mode.

authors: lxjinfo qinghuaweitian

repo: straight-tamago/misaka


text:
fix: make title optional

What does it do?
Make the title property of the Alert component optional
Why is it needed?
Because on the Strapi codebase is already being used without specifying the title. And during the migration from JS to TS the errors are starting to appear
How to test it?
Use the Alert component and check that no title is required

Can you add a changeset please

repo: strapi/design-system


text:
feat: add new package and shuffle deps to utilise workspaces

What does it do?

Adds a new primitives package for hosting our super low level components (normally known as Raw in the DS storybook)
Moves test suite base into the root of the package & react to both utilise workspaces (avoid dev conflicts) and mirror similar structure to the strapi/strapi repo

Why is it needed?

I'm in the process of rebuilding the combobox and to avoid a complicated component like we have in some spaces I plan to separate the primitive from the DS usage – in theory this will make it easier to integrate Radix's version when they add it
This would reduce complexity at the DS level where we can focus on styling and our additional feature logic, components will then be simpler like seen in #865

How to test it?

Test suite should still all pass

There's a broken test, but wanted to get the idea in front of you all before hand.

Overall I feel like a change of this magnitude should be discussed in a DS Sync first ...

IDM, it's why I got everyone to review it here to avoid waiting. Again, it's going into a feature branch so it can be reverted.
But if we'd prefer to discuss in a sync then sure 😊

Are we expecting or already identified many components that we will have to create primitives for (I just remember discussing combobox)?

I think we'll need to "fork" the Select to enable multiple on the select because it's not implemented so theres another to be added and i'd definitely like to add RawTable bits

Is a separate package a bit overkill if we only need to create a couple primitives that aren't provided by radix?

The amount of packages required to create a new primitive in a composable way (like radix) is very large so imo it's easier to keep it in it's own package so we can clearly see the deps required just for the primitives stuff 👍🏼


text:
Google OAuth Provider Issue

Node.js version:
9.11.1
npm version:
5.4.2
Strapi version:
3.0.0-alpha.11.3
Operating system:
MacOS
Which example is causing problem?
good-old-react-authentication-flow
Do you want to request a feature or report a bug?
report a bug
What is the current behavior?
After enabling Google as an OAuth provider in the Strapi admin, I attempt to use the provider for a login. I click the Google button and in the client receive this message: {"message":"An internal server error occurred","statusCode":500,"error":"Internal Server Error"}. Looking at the server output the only error I'm seeing is simply: error undefined is not a function along with the GET request
If the current behavior is a bug, please provide the steps to reproduce the problem

In the admin, enable Google as an OAuth Provider
Input your client ID and client secret
Leave The redirect URL to your front-end app and The redirect URL to add in your Google application configurations as is
return to the client and go to /auth/login
Attempt a login with Google

An additional note is that after configuring the Provider settings correctly, I was able to reach the Google account selection page. However, I am now only receiving the {"message":"An internal server error occurred","statusCode":500,"error":"Internal Server Error"} error in the client
What is the expected behavior?
Go to Google account selection, be returned to logged in state within the app

@soupette
First, I've found that the issue was simply not having the Google+ API enable. I feel like for the development env, there needs to be much better debug messaging enabled. This was a simple issue to fix, but there was nothing indicating what needed to happen.
Second, I'm now receiving another message in the client. It is happening on the redirect back from Google to the app. The message reads:
{
   "jwt":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MywiaWF0IjoxNTIzNjQwNjYyLCJleHAiOjE1MjYyMzI2NjJ9.Lp0bELpbJaYqSC6YSj1PNIyXHzYWVhvF4GrDxAiItJY",
   "user":{
      "id":3,
      "username":"email@here.com",
      "email":"email@here.com",
      "provider":"google",
      "role":{
         "id":3,
         "name":"Public",
         "description":"Default role given to unauthenticated user.",
         "type":"public"
      },
      "updated_at":null,
      "created_at":null
   }
}

I'm not sure why at this point the client isn't returning to the app in a logged-in state

I think that you'll find answer in this documentation.
Let me know if you're still struggling

@soupette
If I follow the steps in those docs, I'm continually redirected back to Google account selection page (ie https://accounts.google.com/signin/oauth/oauthchooseaccount...)
I'm confused as to why in the docs for the "The redirect URL to your front-end app" section it says to use connect/google, while the default value in the admin is auth/google/callback.
Neither of the values seem to work

If you're using the boilerplate provided in the examples it's  http://locahost:3000/connect/google.
You're right, the url writtent in the admin is wrong but if you click on the field you'll see that it will automatically change to auth/google/callback so you need to edit this field in the admin.

Well the redirect URL of your front-end app can be changed, However the one that manages the authentication between your api and your provider cannot be modified since it's dynamic, so if you change the port of your API the field will also be updated

Hmm alright. So how is it in this documentation you were able to set both http://locahost:3000 and http://localhost:1337?

This is what I'm most confused about.

@JeffWeim facing the same issues here while trying to integrating it with my strapi admin. Any clues as to what values you put as redirect URL in your provider?

you need to make google process firstly from frontend app after that response add to the strapi backend server

authors: JeffWeim nabiltkarim pronvd7 soupette

repo: strapi/strapi-examples