text:
request to support download of RAW (.ts) video.

I have modified/tweaked the convert.py and downloader.py and provide the functions with a variable called method. When method == 'raw'  the convert.py module saves the raw .ts version downloaded from Tapo and skips the ffmpeg conversion to .mp4.
When method == 'ffmpeg' the usual .mp4 will be created.
On Ubuntu and also Windows 10/11 you can simply view the .ts file and hear the audio as well.
On Ubuntu mpv Media Player, SMPlayer, VLC work with the .ts file.
So a conversion is not (always) per se needed.
Thanks when you build it in as a config option.

Hey, I'm new to this codebase but this could be easy to implement because there is a snippet that first loads both video and audio raw files and then combines them with ffmpeg

Hi peterstamps,
Can you share info/link on the image encoding for the raw .ts ?
I would like to get an image without ffmpeg or jpeg compression.

I changed the convert.py and downloader.py (bot attached) a little and
added a variable to the def function(s) called method.
method == "ffmpeg" means that I use the original and get the .mp4 output
method == "raw" means I get the .ts output (see line 24 in convert.py)
Also in Downloader I changed something. Search for "method"  and some
comments with "peter" in it.
That is how it got .ts raw files. Pretty simple at the end.
Op wo 22 mei 2024 om 12:23 schreef Manuel YGUEL @.***>:

Hi peterstamps,
Can you share info/link on the image encoding for the raw .ts ?
I would like to get an image without ffmpeg or jpeg compression.
—
Reply to this email directly, view it on GitHub
https://github.com/JurajNyiri/pytapo/issues/94#issuecomment-2124445020,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAW36FV2ZGYSAJ6TUNDVYR3ZDRW33AVCNFSM6AAAAABAF2ILZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRUGQ2DKMBSGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

@peterstamps feel free to open PR

source: gharchive/issue

authors: JurajNyiri peterstamps yguel zhengliw

repo: JurajNyiri/pytapo

license: MIT

license_type: permissive

license_source: github-api


text:
(feature-help) Multiple Hosts

Hey.
I was wondering if it was possible to make the bot run on multiple pcs to have a nice stability (I run a lot of discord servers where I use this cutsom bot at).
How am I supposed to do it whitout having every instance doing the request?
Thx.

I think what you are really looking for is sharding. Short answer, that most likely won’t happen as the bot was designed with a small amount of servers using it in mind. Long answer, maybe; a rewrite is underway and this could be something integrated at the base of it so I don’t know.

authors: MattBSG RemsWorldMC

repo: Just-Some-Bots/MusicBot


text:
Improve the status (time) print

Currently, it's like this:
Bot 0 is farming appIDs 430080, 552030, 550440, 453100 and has a total of 4 games (10 cards, about 6 hours) left to farm.
This reads very strange, this would make much more sense:
Bot 0 is farming appIDs 430080, 552030, 550440, 453100 and has a total of 4 games (10 cards) left to farm (about 6 hours).
Whereas this is also possible:
Bot 0 is farming appIDs 430080, 552030, 550440, 453100 and has 4 games (10 cards) left to farm (about 6 hours).
However, technically that isn't really correct either as it's already farming said 4 games, so it would be more like this:
Bot 0 is farming 10 cards from appIDs 430080, 552030, 550440, 453100 (~6 hours remaining).
In cases where there are actually games left to farm it can print something like:
Bot 0 is farming 3 cards from xyz, with 4 games (6 cards) left to farm (~6 hours remaining).
Or more specific:
Bot 0 is farming 3 cards from xyz (~1 hour remaining), with 4 games (6 cards) left to farm (~5 hours remaining).

We're farming games, not cards. And when farming multiple of them, we're not even farming them, but farming playtime.
Time prediction is made for entire farming queue, not a single game, because it's also affected by chosen farming algorithm.
ASF prints current status, and total status. Nothing guarantees you that it will be the same, which defeats correctness of your last 3 statements, as it's entirely possible that ASF can be farming 4 games, and have a total of 5, or any other combination.

Bot 0 is farming appIDs: 430080, 552030, 550440, 453100 and has a total of 4 games (10 cards) left to farm (~6 hours remaining).
This makes most sense to me, as it's also the most correct way of saying what ASF is in fact doing.

We're farming games, not cards. And when farming multiple of them, we're not farming cards at all, but farming playtime.

It's farming cards, not games. It's like you write: ASF is a C# application that allows you to farm steam cards. If you would farm games you would get games in inventory, that doesn't make any sense.

Time prediction is made for entire farming queue, not a single game, because it's also affected by chosen farming algorithm. Predicting a single game is not possible, unless you entirely ignored the actual way of farming the queue, but then your prediction is incorrect by definition.

Fair enough.

as it's entirely possible that ASF can be farming 4 games, and have a total of 5, or any other combination

Yes, I'm aware, hence this statement:
Bot 0 is farming 3 cards from xyz, with 4 games (6 cards) left to farm (~6 hours remaining).
This is of course not a total anymore but one you have to deduct yourself (left + right). This could work but with knowledge of the time prediction one can slightly rewrite it to this:
Bot 0 is farming 3 cards from xyz, out of a total of 12 cards from 4 games (~6 hours remaining).
a total of is optional but might make it more clear.
Or in one with multiple appids:
Bot 0 is farming playtime from appids 430080, 552030, 550440, out of a total of 4 games (12 cards and ~6 hours remaining).
farming playtime from might also be called idling.
To make the single game more identical you could also do it like this:
Bot 0 is farming 3 cards from xyz, out of a total of 4 games (12 cards and ~6 hours remaining).
This way you have a consistent print that makes sense for all given scenarios.

Bot 0 is farming 3 cards from(...)
Bot 0 is farming playtime from(...)

Assuming implementation detail in printing status is the worst you can do, as that implementation detail can change at any moment, e.g. when Valve alters the most optimal farming way.

That doesn't make any sense. If Valve changes the optimal way you'd have to change the code anyway.

Exactly, change CardsFarmer implementation detail, and not the way how ASF prints status of the bots.

If you change that you can change the print as well.
Or you can simply ignore the playtime print all together and just put farming 12 cards from appids....
Either way would be an improvement over the current print.

farming 12 cards from appids

We're farming games, not cards. And when farming multiple of them, we're not farming cards at all, but farming playtime.

Sorry but I do not agree with this, your suggestion incorrectly displays what ASF is currently doing.

It's farming cards, not games. It's like you write: ASF is a C# application that allows you to farm steam cards. If you would farm games you would get games in inventory, that doesn't make any sense.

But if you insist on not having cards for multiple appids, idling would be perfect, or farming hours.

Bot 0 is farming appIDs: 430080, 552030, 550440, 453100 and has a total of 5 games (10 cards) left to farm (~6 hours remaining).

Bot 0 is idling appIDs: 430080, 552030, 550440, 453100 and has a total of 5 games (10 cards) left to farm (~6 hours remaining).
To me both statements are the same, but if you don't like farming word that much, idling is fine too.

Please also read this again:
Bot 0 is idling appids 430080, 552030, 550440, out of a total of 4 games (12 cards and ~6 hours remaining).
+
Bot 0 is farming 3 cards from xyz, out of a total of 4 games (12 cards and ~6 hours remaining).
or (if you don't want the specific number of cards):
Bot 0 is farming cards from xyz, out of a total of 4 games (12 cards and ~6 hours remaining).
If you do out of a total of, you include the left part of the sentence in the right part.
The way you have it right now, appids x, y, z AND has a total of 5 games left, it would mean 5 + x + y +z games = 8 games in total. Which it isn't.

¯_(ツ)_/¯

authors: JustArchi Phyxion

repo: JustArchi/ArchiSteamFarm

license_source: bigquery


text:
🛑 Schirmer Plex Server is down

In 406240c, Schirmer Plex Server (jonathanschirmer.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schirmer Plex Server is back up in a424b62.


text:
Run tests on schedule

Currently, tests are only executed on push / merge. In the .github/workflow, tests should be executed on schedule (see https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule) to assure this repository is up to date with changes in ros. Additionally, build-status should be re-added to the readme.

addressed in #69 #70 , to be moved to foxy galactic noetic melodic

addressed in #72 , #73 , noetic and melodic missing


text:
Approve this pull request

Approve this pull request
Left reviews and line comments
Created a file and made a commit
Opened a pull request
Originally posted by @KIIRTHANA in https://github.com/KIIRTHANA/reviewing-a-pull-request/issues/4#issuecomment-1200473638

SAmple desco

repo: KIIRTHANA/reviewing-a-pull-request


text:
🛑 KMHARS Speedtest Server / Marawi Main Fiber is down

In a23b2d4, KMHARS Speedtest Server / Marawi Main Fiber (kmhars.ookla.databyte-network.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: KMHARS Speedtest Server / Marawi Main Fiber is back up in 721092a after 1 hour, 1 minute.

repo: KMHARS/uptime


text:
Push CKAN to get a working dependency

for Chaka Monkey KSP-CKAN/NetKAN#3777

Dependencies all the way down

source: gharchive/pull-request

repo: KSP-CKAN/CKAN-meta


text:
HotRockets.netkan

close #1137

#rebuild because why in the world is this trying to build ModuleRCSFX.netkan?

repo: KSP-CKAN/NetKAN


text:
Fix HGR's Corvus

Fixes errors with original netkan file
Adds some metadata
Adds dependency on HGR props
Closes #1397

DO-NOT-MERGE until #1261 is resolved

You can remove line 5 and line 17 should be "depends" :)

#rebuild

authors: Dazpoet pacbard


text:
Add SM Armory from SpaceDock

This pull request was automatically generated by SpaceDock on behalf of RecoverMod, to add SM Armory to CKAN.
Please direct questions about this pull request to RecoverMod.
Mod details:
name = /mod/2162/SM%20Armory
author = RecoverMod
abstract = Works for KSP 1.4 and upwards
license = GPLv3
Homepage =
description =
Works for KSP 1.4 and upwards

#rebuild

"RecoverMod" appears to not be the author, and the forum thread was locked in March.
Closing due to obvious shenanigans.

authors: HebaruSan Space-Duck


text:
Not equals in table row does not align correctly [pen included]

https://codepen.io/HughGrovesArup/pen/OJLadYp
As can be seen when in a table row the / is misaligned.

The issue doesn't appear on https://katex.org/.  My hunch is that codepen.io's CSS is affect ours somehow.  I wasn't able to figure out what style was responsible though. :(  Once we figure that out we should be able to guard against it.  We should probably add a bunch of reset params to .katex in katex.less to reset all external styles.

The places where I have actually encountered the issue are in a VS code extension that utilises a webview (like an iframe) and inside a vue.js component.
The issue does not appear on katex.org - but is that just because it's not within  tags? If I remove the tr / td from the codepen it renders as expected https://codepen.io/HughGrovesArup/pen/LYPMvxW

@HughGrovesArup: Removing the td and tr means the math block is removed from the table, so that's why it works.
I did some testing.
(1) Removing ALL of codepen's styles gave the following (with the second set of equations being in p tags, not in a table):

So that's not it.
(2) I then tried the code in various versions:
0.9.0 (not quite aligned, but at least looks OK)

0.10.0

0.10.2

This is due to vlist using a table layout and border-collapse which affects it is set to separate in table tags. I've opened a PR. Thank you for reporting!

authors: HughGrovesArup kevinbarabash mbourne ylemkimon

repo: KaTeX/KaTeX


text:
Test for duplicate symbols/macros

We've had a few cases where we accidentally include the same symbol or macro definition in both macros.js and symbols.js.  This new test automatically detects these scenarios during Jest testing.
As a test, I reversed these changes and I got the following errors:
  ● Symbols and macros › macro \llbracket should not shadow a symbol

    expect(received).toBeFalsy()

    Received: {"font": "main", "group": "open", "replace": "⟦"}

       6 |         it(`macro ${macro} should not shadow a symbol`, () => {
       7 |             for (let kind in symbols) {
    >  8 |                 expect(symbols[kind][macro]).toBeFalsy();
         |                                              ^
       9 |             }
      10 |         });
      11 |     }

      at Object.toBeFalsy (test/redundancy-spec.js:8:46)

  ● Symbols and macros › macro \rrbracket should not shadow a symbol

    expect(received).toBeFalsy()

    Received: {"font": "main", "group": "close", "replace": "⟧"}

       6 |         it(`macro ${macro} should not shadow a symbol`, () => {
       7 |             for (let kind in symbols) {
    >  8 |                 expect(symbols[kind][macro]).toBeFalsy();
         |                                              ^
       9 |             }
      10 |         });
      11 |     }

      at Object.toBeFalsy (test/redundancy-spec.js:8:46)

  ● Symbols and macros › macro ⟦ should not shadow a symbol

    expect(received).toBeFalsy()

    Received: {"font": "main", "group": "open", "replace": "⟦"}

       6 |         it(`macro ${macro} should not shadow a symbol`, () => {
       7 |             for (let kind in symbols) {
    >  8 |                 expect(symbols[kind][macro]).toBeFalsy();
         |                                              ^
       9 |             }
      10 |         });
      11 |     }

      at Object.toBeFalsy (test/redundancy-spec.js:8:46)

  ● Symbols and macros › macro ⟧ should not shadow a symbol

    expect(received).toBeFalsy()

    Received: {"font": "main", "group": "close", "replace": "⟧"}

       6 |         it(`macro ${macro} should not shadow a symbol`, () => {
       7 |             for (let kind in symbols) {
    >  8 |                 expect(symbols[kind][macro]).toBeFalsy();
         |                                              ^
       9 |             }
      10 |         });
      11 |     }

      at Object.toBeFalsy (test/redundancy-spec.js:8:46)

Codecov Report

Merging #1955 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1955      +/-   ##
==========================================
- Coverage   94.92%   94.91%   -0.01%
==========================================
  Files          79       79
  Lines        4843     4839       -4
  Branches      845      845
==========================================
- Hits         4597     4593       -4
  Misses        222      222
  Partials       24       24

Flag
Coverage Δ

#screenshotter
89.48% <ø> (-0.01%)
:arrow_down:

#test
86% <ø> (-0.02%)
:arrow_down:

Impacted Files
Coverage Δ

src/macros.js
97.6% <0%> (-0.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb312f...e3460a3. Read the comment docs.

authors: codecov-io edemaine


text:
[WIP] Replace ListView with FlatList

[x] Updated example to latest React Native
[x] Added FlatList with manual inversion (until 0.47.0 is released)

Hello,
RN 0.47 had already released. I'm curious if you still use manual inversion or not. Thanks.

Yep, we use fully customized version https://github.com/ptmt/react-native-gifted-chat-flat, but we haven't yet updated to latest RN, only 0.46

Do you have any plan to use RN 0.47?
I already use RN 0.47 and the UI is weird. I get reverse view, and there's margin on top.

Any clue is very welcome. Thank you.

authors: pewh ptmt

repo: Kabangi/react-native-gifted-chat


text:
Added intrinsic function creators

Adds a creator for most of the intrinsic functions for use in plugins.

Pull Request Test Coverage Report for Build 534

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.886%

Totals

Change from base Build 532:
0.0%

Covered Lines:
684

Relevant Lines:
1759

💛  - Coveralls

authors: coveralls ojkelly

repo: KablamoOSS/kombustion


text:
🛑 Lavalink is down

In fb728e1, Lavalink (https://lidalavalink.kadantte.repl.co/metrics) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Lavalink is back up in fbdc1f4.

repo: Kadantte/candy-up


text:
Where is the kaggle kernel .ipynb stored?

Had a quick question - where in the whole disk is the kaggle kernel (which we edit) is stored? I wanted to use colabcode without always doing the copy-paste or making a dedicated repo

Hi @neel04 - I'm not sure what you mean by "where is it stored".  You can use the Kaggle API to get access to the .ipynb by doing a kaggle kernels pull <username>/<kernel-slug>.  Please respond if that doesn't resolve the issue.

repo: Kaggle/kaggle-api


text:
which version of Detectron2 for detection to use?

hi, thank you for your job.
Could you please provide software version which you used for this job, such as torch, torchvision, detectron2, python, ...
Thanks!

For sure, here they are

Python - 3.7
PyTorch - 1.5.0 with torchvision - 0.6.0
Detectron2 -  Tree - 369a57d333

I have added these to README. Thanks very much.

For sure, here they are

Python - 3.7
PyTorch - 1.5.0 with torchvision - 0.6.0
Detectron2 -  Tree - 369a57d333

I have added these to README. Thanks very much.

repo: KaiyuYue/mgd


text:
[SAGE-440] Foundations link update

Description

[x] Reword the heading for the Links documentation page to more closely align with the Design file
[x] Create a "Default" and "Plain" section on the doc site to align with the designs
[x] Add a "with icon" variation

Screenshots

Before
After

Testing in sage-lib

Verify that the links align with the latest specs:

Rails
React

Related

Closes SAGE-440

There is currently an issue with the icon variations of the link. The underline from the parent link is showing in the child pseudo ::before element. Since the ::before must be able to switch sides, it exposed the fact that we'll need a heavy rework to accomplish this.
With this, the issue would not be present if the icon was a svg element instead of a pseudo ::before. Looking at this, I believe the reason we have a link variant in our buttons was because we need to put the icon on the left.

There is currently an issue with the icon variations of the link. The underline from the parent link is showing in the child pseudo ::before element. Since the ::before must be able to switch sides, it exposed the fact that we'll need a heavy rework to accomplish this.

Short of a full refactor (which I still think may be warranted as a follow-up), and the fact that .sage-link already has position: relative,  I wonder if we could do something like this for now:
[class*="sage-link--icon-left-"] {
  padding-left: calc(#{sage-spacing(sm)} + #{sage-spacing(2xs)}); // icon width + icon margin
}

[class*="sage-link--icon-left-"]::before {
  position: absolute;
  left: 0;
}

… and the same but reversed for sage-link--icon-right-

Should the focus text color be black?

This does match the current Figma comps, presumably to have a consistent focus ring throughout. Though I agree that out of context it's a little jarring.

There is currently an issue with the icon variations of the link. The underline from the parent link is showing in the child pseudo ::before element. Since the ::before must be able to switch sides, it exposed the fact that we'll need a heavy rework to accomplish this.

Short of a full refactor (which I still think may be warranted as a follow-up), and with the knowledge that .sage-link already sets position: relative, I wonder if we could do something like this for now:
[class*="sage-link--icon-left-"] {
  padding-left: sage-spacing(sm) + sage-spacing(2xs); // icon width + icon margin
}

[class*="sage-link--icon-left-"]::before {
  position: absolute;
  left: 0;
  height: 1em;  // fix for `small` link variant
  width: 1em;
}

… and the same but reversed for sage-link--icon-right-
Line breaks may be weird, though. So the SVG approach you'd mentioned would still be favorable in the long run.
EDIT: just noticed that the icons don't inherit the link size when set to small and added an adjustment

Sage Jira ticket to track: SAGE-447

repo: Kajabi/sage-lib


text:
[SAGE-765] - fix(sage-react): input was using an invalid prop 'inputType'

Prop should have been 'type'
Description
It was called out that the React component Input was raising a warning about an invalid prop name inputType.
Also took the liberty to fix a couple of other small hanging fruits.

Hero, propType.sizes
suppressDefaultClass warning should go away
Storybook, fix input not responding to keyboard input

Screenshots

Before
After

Testing in sage-lib

Navigate to Storybook input-email...here
Enter an invalid value and you should be greeted with a tooltip similar to the one below.

Should not see any warnings related to Hero or suppressDefaultClass in the console.

Fix looks good. 🙌
Not a blocker but what do you think about moving the quotation fixes (unrelated to this?) to a different PR?

@philschanely Thanks, the quotations are an artifact of the deprecation changes for the import statement. Based on my eslint and prettier configs is what changed the single to double quotes. <- Knowledge sharing not justifying.
The main change for those were going from '@storybook/addon-docs/blocks' to "@storybook/addon-docs".

@philschanely Took your advice and removed all unrelated changes. I will create a separate PR to remove warning and deprecations.


text:
fix(copy-button): use new clipboard functions

we still have a fallback to use execCommand for legacy browser support
JIRA Ticket: DSS-388
Description
It was discovered that the copy-button was not working in certain browsers (versions). The code implemented here addresses both current versions and legacy version support which falls back to using execCommand('copy').
Testing in sage-lib

Navigate to the Copy Button component on the documentation site.
In each browser, Chrome (v111 and v112), Safari, and Firefox confirm that the functionality behaves as expected.

Testing in kajabi-products

(HIGH) Copy button is broken in Chrome version 112 or higher. Please check with all major browsers

[ ] Navigate here, under Account Details, scroll to API Credentials under and confirm the copy-button
[ ] Navigate here and click "Set up authenticator". Once you enter your password, you should see a copy button under the QR code. Confirm that it functions as expected.

Seems to be working properly in Blink/Chromium browsers, but getting an error message in the toast for Webkit(Safari) and Gecko(FF).
Chrome 111 - Works Chrome Beta 113 - Works Chrome Canary 114 - Works Edge 112 - Works Firefox 112 - Error Message Safari 16.4 - Error Message Safari Tech Preview 168 - Error Message

@pixelflips Can you provide a bit more details about the Safari browser you tested with, please? I tested with my local version of Safari (16.4.1) and it works as expected. See the loom video for reference.
I will download Firefox and see what's going on there.


text:
Help command causes error if used with administrative permissions

The !help command will not display if the user has administrative permissions, as there were too many characters.
Example issue.

Fixed temporarily for next minor release.
Will be completely changed next major update.

repo: Kaluub/Clash-Harmony

license: Unlicense


text:
Sort step extension is not saving anything

Describe the Bug
Sort step extension is not saving anything
in console:
Uncaught TypeError: newStepParameters[paramIndex] is undefined
    updateStepParameters stepsService.ts:490
    updateStepParameters stepsService.ts:488
    saveConfig Visualization.tsx:243
    kaotoApi VisualizationStepViews.tsx:178
    onClick SortStep.tsx:64

Steps to Reproduce the Bug or Issue

Create a Camel route
add a timer
add sort
select sort
in Config tab, fill some values
Clcik apply
--> fields are cleared and nothign is saved in source

Screenshots or Videos
No response
Platform
red.ht/kaoto-snapshot

Fixed by https://github.com/KaotoIO/kaoto-ui/issues/2053

authors: apupier lordrip

repo: KaotoIO/kaoto-ui


text:
Kimai v2 latest

Hi @KatjaGlassConsulting
I fixed more issues and I think that #21 was solved now (but I didn't tested).
Now, I identified a problem when reject a week.
When I click at button "reject", don't do nothing.
But, I was able to approve a work week now with success.
I followed doing all commits separated to be more easy to do the review.

The overtime also has some issues. I am still struggeling with the API. Does these work in your environment? You can to click your profile -> API access and then click the book icon "swagger api doc". When you have defined an api key, on the swagger api you can test it by authorization (use your username and api passoword) and then go to the api endpoint to test.
The swagger API doc does not open for me "{"code":500,"message":"Internal Server Error"}" - when I remove all approval APIs (rename .php to .php_ for example), then the doc is up and running.
Nevertheless, I already merge so that can be used as base.

authors: KatjaGlassConsulting vitormattos

repo: KatjaGlassConsulting/ApprovalBundle


text:
base_url breaks the layout rendering

I noticed if I enter a base_url similar to this in config.toml it breaks the layout in the generated site:
base_url = "https://example.com"

But, this one is fine:
base_url = "https://example.com/"

It took me an hour to figure out cause of the error.
Steps to reproduce on both v0.2.2 and master branch:

git clone git@gitlab.com:Keats/vincent.is.git

Modify config.toml and replace

    base_url = "https://vincent.is/"

with
    base_url = "https://vincent.is"

Run

$ gutenberg serve --interface 0.0.0.0 --port 2000

Browse http://127.0.0.1:2000/

That's because I didn't update my site yet to use https://www.getgutenberg.io/documentation/templates/overview/#get-url so the links in my <head> for CSS and rss are only valid when base_url = "https://vincent.is"
If you use the global function linked above to create URLs, it will handle trailing slash automatically

Updated my site: https://gitlab.com/Keats/vincent.is/commit/3aab7b2a6b75477367dcb04cc3545409280c7ef9
You can try with both base_url now and it should work in both cases

Great! I can confirm it works now.

repo: Keats/gutenberg

license: mit


text:
Museeks slogan

No dev here. The sentence a free, lightweight and cross-platform music player is great to describe shortly Museeks, but has no "personality". I'm thinking to change this to something that would sound a bit more like a slogan. ("the" instead of "a" is a great start).
e.g: Atom is called "The hackable text editor".

I've remove the lightweight keyword as it's missleading: it was about user interface, but technically, the whole app is not "that' lightweight. Replaced it with "A simple, clean and cross-platform music player" ftm.

Just for the record, from Gitter (both by me :smile:):

"You know, for music",
"The shortest path to your music"

"The shortest path to your music"

I like this one !

Came to me this morning: "Nothing but music"

I imagine you've already been through the usual propaganda patterns:

"Music done right"
"Your music's bright future"
"Forget your dream player -- museeks is better"
"Only for the MUSIC!"
"You've got music!" (Read by s/music/mail/ ^^)

Or a bit more high:
"The player that'll have you squ_eek_ of excitement!"

I like the idea of having a hackable music player.
Customise

Themes
Fonts

Packages

key analysis (similar to record box / mixed in key )

should also definitly make a reference to Rick & Morty
"meeseeks box" / "Mr meeseeks" etc
:)

If we decide to do #260, we should add "hackable" or "extensible" to the slogan.

authors: KeitIG Phenitei Suriteka YurySolovyov arnold-almeida dkniffin

repo: KeitIG/museeks


text:
Add YouTubers to the website

Add Youtubers to index.html
You must state their:

Category (eg: Gaming, Tech)
Name (YouTube channel name ONLY)
Birthday
Total Views as of Jan 2023 (Approx)

NOTE - THE FINAL DECISION ON WHETHER THE YOUTUBER IS ADDED OR NOT, IS UP TO ME. I WILL NOT ADD CONTROVERSIAL YOUTUBERS TO A EXTENT, ETC.

Hey,
Can I work on this ?

If a youtuber fits in more than one category, do I need to add the youtuber for each category the youtuber qualifies for, or should I list the youtuber only once?

If a youtuber fits in more than one category, do I need to add the youtuber for each category the youtuber qualifies for, or should I list the youtuber only once?

What is the YouTuber, and what is their catergory?
I mean, for eg: they are a Gamer and a Coder, you can say - Gaming, Coding.. But, if they upload more coding then gaming, then say coding solely.

Hey can I work on this

Not a specific person is going to be assigned to this issue. It's just a generic one. You just need to add the youtubers to index.html and make a Pull Request.

Not a specific person is going to be assigned to this issue. It's just a generic one. You just need to add the youtubers to index.html and make a Pull Request.

Hi @KendallDoesCoding . I have added a youtuber and created a PR for the same. Let me know if there are any issues.
Ps: This is my first Open source contribution.

Shifted to #66

repo: KendallDoesCoding/youtubers-birthdays


text:
Please Add LMFlow

This looks more operation related than current awesome list.
https://github.com/OptimalScale/LMFlow

Thanks, we've updated the README.md with your suggestions.

authors: KennethanCeyer changtimwu

repo: KennethanCeyer/awesome-llmops


text:
Work with gamepads (and some cleanup)

Before this PR, aiming with the gamepad spun the player wildly. That's fixed, you jump with A, movement and look both use circular deadzones.
I also normalized the whitespace across the project (with gdformat), removed a junk file, and fixed a crash when you're shooting while dying.

I've merged this but wasn't happy with all changes, so instead only merged these and/or changes these elements;

Jump using A (gamepad)
Tune up jump to reach platforms
Always have a valid weapon
Use circular movement deadzone
Added gamepad_sensitivity variable
Changed rotation_input to Input.get_vector

authors: KenneyNL idbrii

repo: KenneyNL/Starter-Kit-FPS


text:
Resolving components in Rich Text Fields by RichTextResolver impossible due to missing 'data-item-id' attribute

Brief bug description
After update kentico-cloud-delivery from 5.3.3 to 5.4.0 I've encountered a problem which caused resolving components by RichTextResolver impossible due to missing 'data-item-id' attribute.
Repro steps

Make model with Rich Text Field in Kentico Cloud
Create a Content Item and add a Component to it's Rich Text field (without converting the Component to Content Item)
Fetch created Content Item using kentico-cloud-delivery, version greater or equal 5.4.0
Use resolveHtml() function from received RichTextField
See the error in console: "Error: Parsing HTML failed:Error: HTML node is invalid. Reason: missing 'data-item-id' attribute"

Screenshots

This is related to https://github.com/Kentico/kentico-cloud-js/issues/142
It's been fixed in 6.0.0-beta.1, but you can install the latest version 6.0.0-beta.3
It's still in beta, but should be more stable that all previous releases. There are some breaking changes, but all of them should be fairly simple to fix (e.g. renaming of some methods..). It's still in beta because I'm planning on adding more features and more breaking changes before releasing.

repo: Kentico/kentico-cloud-js


text:
@Url.Kentico().ImageUrl(...), not @Url.KenticoImageUrl(...)

Brief bug description
I suspect a minor code error in Views/Doctors/Detail.cshtml. The following line...

Repro steps

Add repo to project solution
Attempt to build
See error

Expected behavior
I believe the correct code would be...

Test environment

Version - Kentico v12.0

Thank you for submitting the issue! In general you would be correct, but in this case it is intentional because we want to separate Kentico API from MVC project (and other libraries for that matter) as much as we can. For that reason we created an extension method using the KenticoImageUrl signature that you can find here: https://github.com/Kentico/training-kentico-k12/blob/master/MedioClinic/Extensions/UrlExtensions.cs
Basically you wrap Kentico code in your own so that you have more control over it, you don't 'pollute' your views with Kentico code/namespace which then results in better maintainability/extensibility and upgradability.

authors: Enngage jschrab-lc


text:
Move DesignMatrix validation to RegressionCorrector.correct to avoid confusing warning

Fixes #792. (thanks for pointing this out @rebekah9969!)
Super simple PR to move the DesignMatrix validation step to the RegressionCorrector.correct method. This also allows us to simplify the PLDCorrector by removing the warnings.catch_warnings() call.

I'm concerned that making the entire DesignMatrix.validate() step optional isn't quite the right fix, because the DesignMatrix._validate() helper method includes the following tests which shouldn't be optional:
        if self.prior_mu is not None:
            if len(self.prior_mu) != self.shape[1]:
                raise ValueError('`prior_mu` must have shape {}'
                                 ''.format(self.shape[1]))
        if self.prior_sigma is not None:
            if len(self.prior_sigma) != self.shape[1]:
                raise ValueError('`prior_sigma` must have shape {}'
                                 ''.format(self.shape[1]))
            if np.any(np.asarray(self.prior_sigma) <= 0):
                raise ValueError('`prior_sigma` values cannot be smaller than '
                                 'or equal to zero')

I think we may want to leave the call to the validate method as-is, and instead move the low-rank check out of validate and into a new helper method which is only called by correct() as and when necessary?

I considered that, but I don't think this change makes validate optional in practice because these tests are still performed when the design matrix is used by the corrector. It will still check the dimensions of priors and raise appropriate errors if there is a problem, but I like the flexibility of being able to modify the design matrix (including priors) without vocal warnings before calling correct.
In my experience playing around with RegressionCorrector, it makes sense to validate the design matrix if it's being used, as opposed to validating each iteration as you construct the full design matrix. But if you think this will cause issues for users, I'd be happy with an intermediate validation step without the low-rank check.

authors: barentsen nksaunders

repo: KeplerGO/lightkurve


text:
Updated GUI layout so that it creates three panels. One of the panels…

… shows a grid of tiles which represents the game board.

let me in please


text:
Implement a way to add your score to the leaderboard

This should start an event at the end of a match (@ Game over phase) and ask the user their username and added it to the leaderboard.

No leaderboard needed, game should stay simple as it is


text:
Delete Button, Username login, Updated Scrapeer, Security Fixes

I completely deleted my fork and started again, now there are 2 branches of my fork. Branding has changed back to neutral and everything appears to be working good, but if @KevinJDurant wouldn't mind checking the search torrent feature that would be handy. Searching for torrents works fine on the live demo but not on XAMPP (they are the same files) and I'm not sure whats up with that.
Edit:
tested the search feature with @KevinJDurant 's fork on XAMPP and it didnt work so maybe its just XAMPP.
Edit 2:
Repulled my forks and uploaded to live demo; search feature is fine.. Good to pull if you like.
Branches
Master: Neutral branding so you are able to pull at your convenience.
OpenTorrents: Live setup from the demo site @ http://torrents.azukachan.com
Changes
1)Users can delete torrents from my-torrents.php
2)Branding is now neutral
3)Delete torrent message changed.
4)Scraper.php updated
5)Remove < code > from upload form for security reasons.
6)Users now login with username instead of email address.

@AzukaChan I have reviewed the code and suggested some changes. I can't commit my review to your branch, I'll merge once these small issues have been fixed.

My bad for the small issues.
Suggestions have been added.

@AzukaChan I have squashed your changes into 1 commit and merged them into the master branch. Thanks for your contributions!

authors: AzukaChan KevinJDurant

repo: KevinJDurant/OpenTorrentSite


text:
Add support for emoji skin tones

Emoji should provide skin tone information, such as if it has skin tones, the neutral emoji, the skin tone variants etc.

This is implemented in KeyboardKit Pro and will be available in 6.6.

repo: KeyboardKit/KeyboardKit


text:
Ensure KeyboardKit works in Xcode 16 and iOS 18

Make sure that the SDK builds with the latest Xcode betas, and fix any problems that show up before iOS 18 is released.

I have rewritten the gesture button to work better in iOS 18, where no ScrollViewGestureButton is needed.
This component has been extracted to a separate SDK that will be inlined into KeyboardKit:
https://github.com/danielsaidi/GestureButton

This ticket will be open together with #791 until iOS 18 is released.

This can be tested in the v8.8.6 branch.

Hey @danielsaidi, any ideas on how to fix the iOS 18 emoji scrolling in KeyboardKit version 7.8?
unfortunately with all the fast API changes and moving features to the pro version, it is very difficult to upgrade older projects to the latest one

Hi @ardavank
Unfortunately not, it would be very hard to backport this fix to 7.8.
How many custom things do you use? You could perhaps try to redo the KeyboardKit-adjacent things for KeyboardKit 9, as it will simplify a lot of things.

authors: ardavank danielsaidi


text:
MoltenVK as a standalone dependency

First of all, thanks for the great project and apologies for a potentially stupid question, but I have been reading the documentation and issues but still can't wrap my head around how I am supposed to use this library.
Quick context: I am working on a cross platform gui library with a Vulkan backend. I use glad as the Vulkan loader and glfw for window creation. I have also a dependency on glslang to compile to SpirV. This works perfectly on windows and Linux. Everything is managed with regular cmake and I can run the project with GitHub actions to produce different binaries.
Now I would like to expand the supported platforms and add macOS support with MoltenVK. I have read the MoltenVK_Runtime_UserGuide.md up and down and there is only talk about how to drag and drop stuff to configure with XCode, which is a bit awkward since I need to be able to have the binaries be generated by a CI.
So my question is:

What are the necessary steps to compile and run an existing Vulkan project with moltenVK on a Mac. (Do I have to include additional headers even though I already have vulkan.h included through glad? Do I have to further modify the project assuming my Vulkan code does not cut into the Non-compliance area?)

I have read comments that this project, as it lives in the Apple eco system, is only oriented to be built with XCode, which I understand. But I don't understand how to interface to it like it is usually done for regular c/c++ dependencies.

You really only need XCode for building MoltkenVK itself. You can link to the libraries with the toolset of your choice (I’ve been using Qt Creator myself). The normal Vulkan Headers are sufficient as well. Prebuilt binaries for MoltenVK can be obtained from the Vulkan SDK distributed by LunarG here:
https://vulkan.lunarg.com/ https://vulkan.lunarg.com/
You will find a MoltenVK.xcframework folder in the SDK (you can also build this yourself with Xcode and the MoltenVK source), which is directly consumed by Xcode projects… but…
You can also easily extract just the static libraries. For macOS, it is in /macOS-x86_64/libMoltenVK.a
If you link directly to this library you can create a VulkanInstance, and enumerate the GPU’s available, etc.
If you want link dynamically, libMoltenVK.dylib is in /MoltenVK/dylib
Further… you can use the Vulkan Loader and treat MoltenVK as an ICD. This will allow you make use of the Vulkan Validation layers, or even use another Vulkan implementation such as SwiftShader.
The Vulkan Loader is in the SDK in the /macOS/lib folder.
This is brief, and not complete… but you said you’ve been scanning the other documentation, so these little hints may fill in the gaps for you I hope.
Richard

On Nov 26, 2020, at 1:59 PM, Haeri notifications@github.com wrote:
First of all, thanks for the great project and apologies for a potentially stupid question, but I have been reading the documentation and issues but still can't wrap my head around how I am supposed to use this library.
Quick context: I am working on a cross platform gui library with a Vulkan backend. I use glad as the Vulkan loader and glfw for window creation. I have also a dependency on glslang to compile to SpirV. This works perfectly on windows and Linux. Everything is managed with regular cmake and I can run the project with GitHub actions to produce different binaries.
Now I would like to expand the supported platforms and add macOS support with MoltenVK. I have read the MoltenVK_Runtime_UserGuide.md up and down and there is only talk about how to drag and drop stuff to configure with XCode, which is a bit awkward since I need to be able to have the binaries be generated by a CI.
So my question is:
What are the necessary steps to compile and run an existing Vulkan project with moltenVK on a Mac. (Do I have to include additional headers even though I already have vulkan.h included through glad? Do I have to further modify the project assuming my Vulkan code does not cut into the Non-compliance area?)
I have read comments that this project, as it lives in the Apple eco system, is only oriented to be built with XCode, which I understand. But I don't understand how to interface to it like it is usually done for regular c/c++ dependencies.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/KhronosGroup/MoltenVK/issues/1160, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN64HVNBLCTGNV443KPPNFTSR2QQ3ANCNFSM4UECGOQQ.

If your using GitHub actions to compile your project already then use the macos-latest the image will contain multiple versions of Xcode.
You’ll also able to use homebrew within GitHub actions for grabbing things like cmake, there’s also an unofficial tap for installing the VulkanSDK.
As for making changes to your project so it compiles nobody can really answer that without seeing your source.

@richard-lunarg 's answer is your best bet if you want to avoid building from source.
If you do want to build from source (for example if you need a later version of MoltenVK than is included in the Vulkan SDK), follow the instructions for Building from the Command Line in the README.md document. It uses make, so you can include it in larger build scripts.
There are some common prerequisites (Xcode and python3), but you'll need those to build your own app anyway.

Thanks for the answers so far. Maye to clarify, the issue is not compiling the project. I am doing that already by using the provided dependency script and make file. I have also wrapped it up in a vcpkg custom port for my project link. This is completely fine and it gives me:

MoltenVK headers files
MoltenVKShaderConverter header files
A libMoltenVK.a static library
A libMoltenVK.dylibdynamic library
A MoltenVKShaderConverter executable

But the initial question still remains: How do I integrate these resources into my project. Do I have to include the header files? If so, what functionality do I need to use from those headers? Can I still use my glad vulkan loader? (The SDK was mentioned but if possible I would love to avoid that since it is an enormous install. I managed to also get by on windows and linux without them)

How do I integrate these resources into my project.

If you're using the Vulkan SDK, you can start with the Getting Started with the macOS Vulkan SDK document.
If you're using MoltenVK directly, integration instructions are in the Docs/MoltenVK_Runtime_UserGuide.md document. That document is referenced from the README.md document that contains the build instructions.

authors: Gcenx Haeri billhollings richard-lunarg

repo: KhronosGroup/MoltenVK


text:
Fix more 32-bit Wformat warnings

This fixes occurrences where the previous wrong specifier appears to work in a typical 64-bit build, but causes a Wformat warning in 32-bit builds.

Merging as discussed in the December 17th teleconference.

authors: bashbaug svenvh

repo: KhronosGroup/OpenCL-CTS


text:
MSL: Shader input overrides are not applied for block, array, and struct types

I found this during investigation of Vulkan CTS failures related KhronosGroup/MoltenVK#2116. For the following fragment inputs shader input overrides are not applied at all. Setting breakpoints on all usages of inputs_by_location shows that none of those codepaths are taken.
struct _14
{
    vec4 _m0;
    ivec3 _m1;
};

layout(location = 0) in _2
{
    flat _14 _m0[3];
} _19;

This generates the following MSL, regardless whether --msl-shader-input 1 any32 4 (which should widen the first int3 to int4) was specified. Also, the flat specifier is not being propagated properly.
struct main0_in
{
    float4 m_19_m0_0_m0 [[user(locn0)]];
    int3 m_19_m0_0_m1 [[user(locn1)]];
    float4 m_19_m0_1_m0 [[user(locn2)]];
    int3 m_19_m0_1_m1 [[user(locn3)]];
    float4 m_19_m0_2_m0 [[user(locn4)]];
    int3 m_19_m0_2_m1 [[user(locn5)]];
};

Note that this is a more complicated example, as this uses a struct within an array within a block, but as soon as any fragment inputs are within a block the shader inputs are ignored and not applied. Same happens with structs and arrays.
in _2
{
    layout(location = 0) vec2 _m0;
    layout(location = 1) flat uvec2 _m1;
} _15;

Shader outputs for the vertex shader using the same setup but for stage outputs are generated correctly.
I've attached a sample fragment shader that uses the above input setup:
17782185548125675323.spv.zip
This is the simplest example using just a block as shown above which also fails:
215374844162041042.spv.zip
And the tessellation shader with the same setup, where the shader outputs work correctly, if useful for debugging:
15478294089967604931.spv.zip

Got a fix for the Flat propagation.
For the composites with override, there are many bugs. One of them is that OpLoad is too naive and only looks at the raw OpVariable.
		auto &expr_type = expression_type(ptr);

		// If the expression has more vector components than the result type, insert
		// a swizzle. This shouldn't happen normally on valid SPIR-V, but it might
		// happen with e.g. the MSL backend replacing the type of an input variable.
		if (expr_type.vecsize > type.vecsize)
			expr = enclose_expression(expr + vector_swizzle(type.vecsize, 0));

Need to rewrite all this junk ...

authors: HansKristian-Work spnda

repo: KhronosGroup/SPIRV-Cross


text:
Legacy GL or GLES 2.0/3.0 attributes

Vulkan support location index for stage attribute binding, this is not supported under legacy opengl or GLES backends, usually its used the "v" prefix for passing attributes between vertex and fragment shader, how to handle this scenario using SPIRV-Cross? Or it is handled?
Sorry if dump question or if already answered, I tried to dig README.md but not found something related.
Thanks

https://github.com/KhronosGroup/SPIRV-Cross/blob/master/README.md#linking-by-name-for-targets-which-do-not-support-explicit-locations-legacy-glslessl should answer your question.

No reply, so I assume it answered the question, closing.

authors: HansKristian-ARM amerkoleci


text:
spirv-val fails on array of Position in Control shader.

test.spv.txt
error: 243: According to the Vulkan spec BuiltIn Position variable needs to be a 4-component 32-bit float vector. ID <3> (OpVariable) is not a float vector.
Spec is a bit vague here, because some kind of array of Position must be allowed (but perhaps only as part of a block).

With SPIRV-Tools top-of-master I do not get that validation error.  What version of the code are you using?
Both Vulkan 1.0 and 1.1 say:

Any variable decorated with Position must be declared as a four-component vector of 32-bit floating-point values.

That seems clear to me.  It should fail validation in the way you report.

Perhaps the Vulkan spec is wrong / out of date?

For the record:
 OpDecorate %3 BuiltIn Position
...
      %31 = OpTypeFloat 32
      %32 = OpTypeVector %31 4
...
      %34 = OpTypeInt 32 0
      %35 = OpConstant %34 3
...
      %48 = OpTypeArray %32 %35
      %49 = OpTypePointer Input %48

        %3 = OpVariable %49 Input

Wait, I ran the validator incorrectly.  We have to specify --target-env vulkan1.1 to get the error.
So:  Yes, I get the error.  Also, the validator is implementing the Vulkan spec as-is.
I understand there is a Khronos-internal issue related to this rule. https://gitlab.khronos.org/vulkan/vulkan/issues/1067

Generally, these rules intended as "after removing the level implicit arrayness that some interfaces add, the type must....".  Maybe there is a place this needs to be more clear?  But, obviously, in practice, for these interfaces that add a level of arrayness, one cannot give an error because the level of arrayness is present.

The competing statement is:

Tessellation control shader per-vertex output variables and blocks, and tessellation control, tessellation evaluation, and geometry shader per-vertex input variables and blocks are required to be declared as arrays, with each element representing input or output values for a single vertex of a multi-vertex primitive. For the purposes of interface matching, the outermost array dimension of such variables and blocks is ignored.

I'm sympathetic if somehow not everything is hooked up right the spec, and that can be clarified, but I don't think there is any question the spec expects this.

Per-vertex don't include per-patch. The ones in question can only be non-per-patch geometry in, tess-control in/out, and tess-evaluation in.  Original/core Vulkan only has the four Position, PointSize, ClipDistance, and CullDistance, but several extensions expand the list.
PrimitiveId, InvocationId, PatchVertices, Layer, TessCoord, and ViewportIndex are not treated this way.

authors: HansKristian-ARM dneto0 johnkslang

repo: KhronosGroup/SPIRV-Tools


text:
spirv-val: Add missing NonSemantic.Shader.DebugInfo.100

Adds missing coverage for NonSemantic.Shader.DebugInfo.100 where it was different from OpenCL.DebugInfo.100
(Created 2 commits prior to reduce the copy-and-pasting in the tests)

@alan-baker I see it is failing CI in https://btx.cloud.google.com/invocations/36895f7b-5b6d-4dac-8efe-c9225e6f04d6/targets/graphics_shader_compiler%2Fspirv-tools%2Fshaderc-smoketest%2Fpresubmit/log but these errors make no sense, locally it runs fine and all the errors are around not being able to run spirv-as on thing, not sure if you have seen this before

Can you rebase on main? SPIRV-Headers merged a PR to remove aliases as separate grammar entries. The tooling is up-to-date on main.

authors: alan-baker spencer-lunarg


text:
Generate Colliders API not exposed.

Trying to find a way to generate colliders for imported objects through code. Have tried ImportedOptions but its not working.

Hey, you can find in the GltfSceneImporter a "Collider" enum option.
Also on the GltfComponent

Does that answer your question @KaustubhJha-TUL-UpperFunnel ?

You can also find in the GLTFSceneImporter a collider property.
I will close this issue, when there is a bug with importing colliders, please create a new issue with proper description and a sample file. Thanks :)

repo: KhronosGroup/UnityGLTF


text:
Memory leaks in vkCreateInstance with standard validation layer enabled

The following program demonstrates memory leaks in vkCreateInstance when VK_LAYER_LUNARG_standard_validation is enabled.
Tested against official Linux build of VulkanSDK 1.0.49.0 on Debian Stretch. When enabledLayerCount is set to to zero in the sample program, no leaks are detected by either Valgrind or LeakSanitizer.
With Valgrind:
Compile: gcc vkleak.c -lvulkan -g
Run: valgrind ./a.out
With LeakSanitizer:
Compile: gcc vkleak.c -lvulkan -g -fsanitize=address
Run: ./a.out
#include <vulkan/vulkan.h>

int main()
{
	VkInstance instance;
	VkResult result;

	result = vkCreateInstance(
		&(VkInstanceCreateInfo) {
			.sType = VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO,
			.enabledLayerCount = 1,
			.ppEnabledLayerNames = (const char *[]) {
				"VK_LAYER_LUNARG_standard_validation",
			},
		},
		NULL,
		&instance);

	if (result == VK_SUCCESS)
	{
		vkDestroyInstance(instance, NULL);
	}

	return result != VK_SUCCESS;
}

Output from Valgrind:
$ valgrind --leak-check=full ./a.out
==31678== Memcheck, a memory error detector
==31678== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al.
==31678== Using Valgrind-3.12.0.SVN and LibVEX; rerun with -h for copyright info
==31678== Command: ./a.out
==31678==
==31678==
==31678== HEAP SUMMARY:
==31678==     in use at exit: 176,055 bytes in 994 blocks
==31678==   total heap usage: 26,759 allocs, 25,765 frees, 80,452,011 bytes allocated
==31678==
==31678== 456 bytes in 1 blocks are definitely lost in loss record 904 of 918
==31678==    at 0x4C2C21F: operator new(unsigned long) (vg_replace_malloc.c:334)
==31678==    by 0x1113F55B: ???
==31678==    by 0x1112968B: ???
==31678==    by 0x1148049F: ???
==31678==    by 0x117E8172: ???
==31678==    by 0x4E500AE: loader_create_instance_chain (in /home/polarina/VulkanSDK/1.0.49.0/x86_64/lib/libvulkan.so.1.0.49)
==31678==    by 0x4E52A89: vkCreateInstance (in /home/polarina/VulkanSDK/1.0.49.0/x86_64/lib/libvulkan.so.1.0.49)
==31678==    by 0x108831: main (vkleak.c:8)
==31678==
==31678== 552 (544 direct, 8 indirect) bytes in 1 blocks are definitely lost in loss record 905 of 918
==31678==    at 0x4C2C21F: operator new(unsigned long) (vg_replace_malloc.c:334)
==31678==    by 0x1147FF5B: ???
==31678==    by 0x114804CF: ???
==31678==    by 0x117E8172: ???
==31678==    by 0x4E500AE: loader_create_instance_chain (in /home/polarina/VulkanSDK/1.0.49.0/x86_64/lib/libvulkan.so.1.0.49)
==31678==    by 0x4E52A89: vkCreateInstance (in /home/polarina/VulkanSDK/1.0.49.0/x86_64/lib/libvulkan.so.1.0.49)
==31678==    by 0x108831: main (vkleak.c:8)
==31678==
==31678== 688 (592 direct, 96 indirect) bytes in 1 blocks are definitely lost in loss record 906 of 918
==31678==    at 0x4C2C21F: operator new(unsigned long) (vg_replace_malloc.c:334)
==31678==    by 0x10431EAB: ???
==31678==    by 0x10433A0F: ???
==31678==    by 0x10969207: ???
==31678==    by 0x10CEE3D9: ???
==31678==    by 0x11129649: ???
==31678==    by 0x1148049F: ???
==31678==    by 0x117E8172: ???
==31678==    by 0x4E500AE: loader_create_instance_chain (in /home/polarina/VulkanSDK/1.0.49.0/x86_64/lib/libvulkan.so.1.0.49)
==31678==    by 0x4E52A89: vkCreateInstance (in /home/polarina/VulkanSDK/1.0.49.0/x86_64/lib/libvulkan.so.1.0.49)
==31678==    by 0x108831: main (vkleak.c:8)
==31678==
==31678== 848 (664 direct, 184 indirect) bytes in 1 blocks are definitely lost in loss record 907 of 918
==31678==    at 0x4C2C21F: operator new(unsigned long) (vg_replace_malloc.c:334)
==31678==    by 0x10CEE06B: ???
==31678==    by 0x10CEE3FB: ???
==31678==    by 0x11129649: ???
==31678==    by 0x1148049F: ???
==31678==    by 0x117E8172: ???
==31678==    by 0x4E500AE: loader_create_instance_chain (in /home/polarina/VulkanSDK/1.0.49.0/x86_64/lib/libvulkan.so.1.0.49)
==31678==    by 0x4E52A89: vkCreateInstance (in /home/polarina/VulkanSDK/1.0.49.0/x86_64/lib/libvulkan.so.1.0.49)
==31678==    by 0x108831: main (vkleak.c:8)
==31678==
==31678== 904 (368 direct, 536 indirect) bytes in 1 blocks are definitely lost in loss record 908 of 918
==31678==    at 0x4C2C21F: operator new(unsigned long) (vg_replace_malloc.c:334)
==31678==    by 0x10963AD3: ???
==31678==    by 0x1096922A: ???
==31678==    by 0x10CEE3D9: ???
==31678==    by 0x11129649: ???
==31678==    by 0x1148049F: ???
==31678==    by 0x117E8172: ???
==31678==    by 0x4E500AE: loader_create_instance_chain (in /home/polarina/VulkanSDK/1.0.49.0/x86_64/lib/libvulkan.so.1.0.49)
==31678==    by 0x4E52A89: vkCreateInstance (in /home/polarina/VulkanSDK/1.0.49.0/x86_64/lib/libvulkan.so.1.0.49)
==31678==    by 0x108831: main (vkleak.c:8)
==31678==
==31678== 6,824 (1,880 direct, 4,944 indirect) bytes in 1 blocks are definitely lost in loss record 913 of 918
==31678==    at 0x4C2C21F: operator new(unsigned long) (vg_replace_malloc.c:334)
==31678==    by 0x1111528B: ???
==31678==    by 0x1112966B: ???
==31678==    by 0x1148049F: ???
==31678==    by 0x117E8172: ???
==31678==    by 0x4E500AE: loader_create_instance_chain (in /home/polarina/VulkanSDK/1.0.49.0/x86_64/lib/libvulkan.so.1.0.49)
==31678==    by 0x4E52A89: vkCreateInstance (in /home/polarina/VulkanSDK/1.0.49.0/x86_64/lib/libvulkan.so.1.0.49)
==31678==    by 0x108831: main (vkleak.c:8)
==31678==
==31678== 7,768 (4,944 direct, 2,824 indirect) bytes in 1 blocks are definitely lost in loss record 914 of 918
==31678==    at 0x4C2C21F: operator new(unsigned long) (vg_replace_malloc.c:334)
==31678==    by 0x117D266B: ???
==31678==    by 0x117E819B: ???
==31678==    by 0x4E500AE: loader_create_instance_chain (in /home/polarina/VulkanSDK/1.0.49.0/x86_64/lib/libvulkan.so.1.0.49)
==31678==    by 0x4E52A89: vkCreateInstance (in /home/polarina/VulkanSDK/1.0.49.0/x86_64/lib/libvulkan.so.1.0.49)
==31678==    by 0x108831: main (vkleak.c:8)
==31678==
==31678== LEAK SUMMARY:
==31678==    definitely lost: 9,448 bytes in 7 blocks
==31678==    indirectly lost: 8,592 bytes in 85 blocks
==31678==      possibly lost: 0 bytes in 0 blocks
==31678==    still reachable: 158,015 bytes in 902 blocks
==31678==         suppressed: 0 bytes in 0 blocks
==31678== Reachable blocks (those to which a pointer was found) are not shown.
==31678== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==31678==
==31678== For counts of detected and suppressed errors, rerun with: -v
==31678== ERROR SUMMARY: 7 errors from 7 contexts (suppressed: 0 from 0)

I'm reassigning this to @jeremy-lunarg  because it looks like the leak is happening in the layers. I replaced vulkaninfo.c with your code since I didn't feel like compiling a separate program and then ran the program with
LD_PRELOAD="layers/libVkLayer_threading.so:layers/libVkLayer_parameter_validation.so:layers/libVkLayer_object_tracker.so:layers/libVkLayer_core_validation.so:layers/libVkLayer_swapchain.so:layers/libVkLayer_unique_objects.so" valgrind --leak-check=full demos/vulkaninfo

This gives the output:
==22906== HEAP SUMMARY:
==22906==     in use at exit: 84,768 bytes in 22 blocks
==22906==   total heap usage: 46,813 allocs, 46,791 frees, 608,270,911 bytes allocated
==22906==
==22906== 200 (24 direct, 176 indirect) bytes in 1 blocks are definitely lost in loss record 13 of 22
==22906==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==22906==    by 0x9014323: ???
==22906==    by 0x9011FDA: ???
==22906==    by 0x838CB65: ???
==22906==    by 0x8390C69: ???
==22906==    by 0x8384728: ???
==22906==    by 0x8384A74: ???
==22906==    by 0x8384AC3: ???
==22906==    by 0x8372B85: ???
==22906==    by 0x89C380D: ???
==22906==    by 0x89C3B9F: ???
==22906==    by 0x67932C7: terminator_CreateInstance (loader.c:4690)
==22906==
==22906== 440 (416 direct, 24 indirect) bytes in 1 blocks are definitely lost in loss record 14 of 22
==22906==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==22906==    by 0x60B726D: layer_data* GetLayerDataPtr<layer_data>(void*, std::unordered_map<void*, layer_data*, std::hash<void*>, std::equal_to<void*>, std::allocator<std::pair<void* const, layer_data*> > >&) (vk_layer_data.h:36)
==22906==    by 0x60B1CEB: swapchain::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (swapchain.cpp:130)
==22906==    by 0x596F8DC: core_validation::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (core_validation.cpp:3395)
==22906==    by 0x552E95B: object_tracker::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (object_tracker.cpp:3429)
==22906==    by 0x517BB24: parameter_validation::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (parameter_validation.cpp:1319)
==22906==    by 0x4E5D8EA: threading::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (threading.cpp:62)
==22906==    by 0x6792059: loader_create_instance_chain (loader.c:4246)
==22906==    by 0x6797413: vkCreateInstance (trampoline.c:330)
==22906==    by 0x4008D3: main (vulkaninfo.c:9)
==22906==
==22906== 456 bytes in 1 blocks are definitely lost in loss record 15 of 22
==22906==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==22906==    by 0x556545F: initInstanceTable(VkInstance_T*, void (*(*)(VkInstance_T*, char const*))(), std::unordered_map<void*, VkLayerInstanceDispatchTable_*, std::hash<void*>, std::equal_to<void*>, std::allocator<std::pair<void* const, VkLayerInstanceDispatchTable_*> > >&) (vk_layer_table.cpp:147)
==22906==    by 0x552E9B9: object_tracker::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (object_tracker.cpp:3436)
==22906==    by 0x517BB24: parameter_validation::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (parameter_validation.cpp:1319)
==22906==    by 0x4E5D8EA: threading::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (threading.cpp:62)
==22906==    by 0x6792059: loader_create_instance_chain (loader.c:4246)
==22906==    by 0x6797413: vkCreateInstance (trampoline.c:330)
==22906==    by 0x4008D3: main (vulkaninfo.c:9)
==22906==
==22906== 552 (544 direct, 8 indirect) bytes in 1 blocks are definitely lost in loss record 16 of 22
==22906==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==22906==    by 0x51A67C5: parameter_validation::instance_layer_data* GetLayerDataPtr<parameter_validation::instance_layer_data>(void*, std::unordered_map<void*, parameter_validation::instance_layer_data*, std::hash<void*>, std::equal_to<void*>, std::allocator<std::pair<void* const, parameter_validation::instance_layer_data*> > >&) (vk_layer_data.h:36)
==22906==    by 0x517BB58: parameter_validation::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (parameter_validation.cpp:1322)
==22906==    by 0x4E5D8EA: threading::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (threading.cpp:62)
==22906==    by 0x6792059: loader_create_instance_chain (loader.c:4246)
==22906==    by 0x6797413: vkCreateInstance (trampoline.c:330)
==22906==    by 0x4008D3: main (vulkaninfo.c:9)
==22906==
==22906== 608 (600 direct, 8 indirect) bytes in 1 blocks are definitely lost in loss record 17 of 22
==22906==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==22906==    by 0x644BAFA: unique_objects::instance_layer_data* GetLayerDataPtr<unique_objects::instance_layer_data>(void*, std::unordered_map<void*, unique_objects::instance_layer_data*, std::hash<void*>, std::equal_to<void*>, std::allocator<std::pair<void* const, unique_objects::instance_layer_data*> > >&) (vk_layer_data.h:36)
==22906==    by 0x6445B23: unique_objects::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (unique_objects.cpp:128)
==22906==    by 0x60B1CBC: swapchain::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (swapchain.cpp:125)
==22906==    by 0x596F8DC: core_validation::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (core_validation.cpp:3395)
==22906==    by 0x552E95B: object_tracker::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (object_tracker.cpp:3429)
==22906==    by 0x517BB24: parameter_validation::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (parameter_validation.cpp:1319)
==22906==    by 0x4E5D8EA: threading::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (threading.cpp:62)
==22906==    by 0x6792059: loader_create_instance_chain (loader.c:4246)
==22906==    by 0x6797413: vkCreateInstance (trampoline.c:330)
==22906==    by 0x4008D3: main (vulkaninfo.c:9)
==22906==
==22906== 688 (680 direct, 8 indirect) bytes in 1 blocks are definitely lost in loss record 18 of 22
==22906==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==22906==    by 0x59AA8E0: core_validation::instance_layer_data* GetLayerDataPtr<core_validation::instance_layer_data>(void*, std::unordered_map<void*, core_validation::instance_layer_data*, std::hash<void*>, std::equal_to<void*>, std::allocator<std::pair<void* const, core_validation::instance_layer_data*> > >&) (vk_layer_data.h:36)
==22906==    by 0x596F90B: core_validation::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (core_validation.cpp:3398)
==22906==    by 0x552E95B: object_tracker::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (object_tracker.cpp:3429)
==22906==    by 0x517BB24: parameter_validation::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (parameter_validation.cpp:1319)
==22906==    by 0x4E5D8EA: threading::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (threading.cpp:62)
==22906==    by 0x6792059: loader_create_instance_chain (loader.c:4246)
==22906==    by 0x6797413: vkCreateInstance (trampoline.c:330)
==22906==    by 0x4008D3: main (vulkaninfo.c:9)
==22906==
==22906== 3,880 (1,896 direct, 1,984 indirect) bytes in 1 blocks are definitely lost in loss record 20 of 22
==22906==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==22906==    by 0x5552E7F: object_tracker::layer_data* GetLayerDataPtr<object_tracker::layer_data>(void*, std::unordered_map<void*, object_tracker::layer_data*, std::hash<void*>, std::equal_to<void*>, std::allocator<std::pair<void* const, object_tracker::layer_data*> > >&) (vk_layer_data.h:36)
==22906==    by 0x552E98A: object_tracker::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (object_tracker.cpp:3434)
==22906==    by 0x517BB24: parameter_validation::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (parameter_validation.cpp:1319)
==22906==    by 0x4E5D8EA: threading::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (threading.cpp:62)
==22906==    by 0x6792059: loader_create_instance_chain (loader.c:4246)
==22906==    by 0x6797413: vkCreateInstance (trampoline.c:330)
==22906==    by 0x4008D3: main (vulkaninfo.c:9)
==22906==
==22906== 5,208 (5,200 direct, 8 indirect) bytes in 1 blocks are definitely lost in loss record 21 of 22
==22906==    at 0x4C2E0EF: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==22906==    by 0x4E79441: layer_data* GetLayerDataPtr<layer_data>(void*, std::unordered_map<void*, layer_data*, std::hash<void*>, std::equal_to<void*>, std::allocator<std::pair<void* const, layer_data*> > >&) (vk_layer_data.h:36)
==22906==    by 0x4E5D919: threading::CreateInstance(VkInstanceCreateInfo const*, VkAllocationCallbacks const*, VkInstance_T**) (threading.cpp:65)
==22906==    by 0x6792059: loader_create_instance_chain (loader.c:4246)
==22906==    by 0x6797413: vkCreateInstance (trampoline.c:330)
==22906==    by 0x4008D3: main (vulkaninfo.c:9)
==22906==
==22906== LEAK SUMMARY:
==22906==    definitely lost: 9,816 bytes in 8 blocks
==22906==    indirectly lost: 2,216 bytes in 12 blocks
==22906==      possibly lost: 0 bytes in 0 blocks
==22906==    still reachable: 72,736 bytes in 2 blocks
==22906==         suppressed: 0 bytes in 0 blocks
==22906== Reachable blocks (those to which a pointer was found) are not shown.
==22906== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==22906==
==22906== For counts of detected and suppressed errors, rerun with: -v
==22906== Use --track-origins=yes to see where uninitialised values come from
==22906== ERROR SUMMARY: 3829 errors from 16 contexts (suppressed: 0 from 0)

The first leak appears to be a driver issue, which is why I see it and this wasn't reported by @polarina. But the leaks after that are coming from a line in vk_layer_data.h which allocates a new pointer that then gets returned. Either the pointer isn't getting freed or something weird is happening that is throwing off valgrind. @jeremy-lunarg  knows the layers better than me, so he can debug this.

Think this issue should be closed, the leaks reported here were fixed when #1841 got merged. :)

@polarina, Thanks!

authors: lenny-lunarg mark-lunarg polarina


text:
Various non-coherent memory handling fixes

Hopefully for #819 , #820 , and #822 , along with a test case that exposed the crashes on NCM systems.

Gary, if you can, please test these on your setup there.  I hacked up the layers to do some testing but we won't have an actual non-coherent memory system until later this week.

With those couple clean-ups I noted
LGTM :+1:

Ok - I've given this a test now.
#819 looks fixed.
#822 looks fixed.
#820 has a bug:
You have aligned the size of the start of the memory block, but you are returning that plus the size of the front guard band (size/2), which then misaligns what you are returning again. You need to make sure the address returned is aligned, not the start of the guard banded block.
If you add "assert(reinterpret_cast<uintptr_t>(*ppData) & (map_alignment - 1) == 0);" at the end of the function, this would trap any mistakes in the arithmetic.

Yeah, we had seen that yesterday and I added a fix along with the changes for Tobin's review suggestions.  I'll add the assert as well and have something for you to try shortly.

I reworked 822 pretty severely, changing the pad size from half the allocation size to just the granularity size, added the assert as Gary suggested.  Please have another look at this commit if you get a chance.

Almost, but not quite I'm afraid.
If I call vkMapMemory with an offset that is non-zero, I get the start address of the shadow block back. The offset has been ignored.

OK, updated for feedback and hopefully addressed the ignored offsets.  Gary, can you please give this another shot?  Sorry to keep asking, but our Android build guy has been difficult to pin down lately.

This is passing all of my tests here now.
Thanks

Thanks again, and keep the issues coming.  Pushed to Master.
commit 5f06b9eba1bf89d4066ca44120dcb72c4cf44104
Author: Mark Lobodzinski mark@lunarg.com
Date:   Mon Aug 15 14:27:26 2016 -0600
layers: GH820, MapMemory shadow copy alignment

For host-visible non-coherent memory, the validation layers use a
shadow copy of the mapped memory region. Added proper alignment
for the shadow copy, fixed handling of offsets, and implemented
resolve of the shadow data on invalidate calls.

Change-Id: I88815799865d3a30c76e16cf96ace630e1bbcf2d

authors: gary-sweet mark-lunarg tobine


text:
Automated tracking of MD changes to be translated

As mentioned on the last few Samples calls, translation of markdown to languages other than English can be incorrect using translation APIs. A suggested solution is to notify translators when a change has occurred to markdown files and allow them to manually change the translated MD. This means that the format of how translations are saved is a decision by the group and wont be automated
Simplest Solution
Add an item to the checklist to notify translators manually when a change to markdown has occurred
Little Better
Create an action to look for changes in mark down and append comments to PRs which ping translators automatically (Only once per PR)
Even Better (Less blocking off contributions)
Create an action to look for changes in mark down and append comments to an issue for a given PR. This means that PRs are not blocked by translations and they can be translated at a later date where the issue contains a history of the changes needed.
I haven't look into this being possible but GitHub has a full API that can be used with CI tokens to perform lots of different actions on a users behalf. This means there is a high chance that it is achievable.

I think we can completely rethink this with Antora. It has built-in language support.

authors: SaschaWillems TomAtkinsonArm

repo: KhronosGroup/Vulkan-Samples


text:
USER STORY: Log out from the App

EPIC: #3
In order to securely end my session, as a logged-in user, I can log out from the to-do app.
Acceptance Criteria:

Acceptance Criteria 1: User is logged in and viewing the home screen.
Acceptance Criteria 2: User can click the logout button.
Acceptance Criteria 3: After logging out, user is redirected to the login page.

Tasks:

[x] Implement logout button functionality
[x] Backend: Implement API endpoint for user logout
[x] Clear user session and redirect to home page
[x] Ensure user cannot access authenticated routes after logout

Done

repo: KimBergstroem/to-do-app


text:
About fine-tuning one's own time series prediction model

Can there be a tutorial on fine-tuning one's training data? I want to make a prediction of available parking spaces in the parking lot. We already have the dataset

You just need to implement the dataloader corresponding to your dataset. You can refer to the implementation of other datasets provided in the code for inspiration.

repo: KimMeen/Time-LLM


text:
Programs with a lot of dups get stuck

(Func 0 b) = b
(Func a b) = (Func (- a 1) (+ b b))

(Main) = (Func 100000000 2)

Running this code with a very large a, makes it seemingly never end (expected 10s, waited 10m). Other programs that create lots and lots of dups also seem to cause this.

Also it seems this game spends most of the time doing exception handling

Is this for sure related to bugs? I see the program runs normally up to 1m, but performance downgrades quickly after ~4m. I'd guess that's caused by either heap, visit queue or redex bag being overload, so it will be improved only once we have growable memory. That's just a guess though, so I'd appreciate if you could measure the occupancy of each of these structures and report back.

Not for sure related to dups strictly, but it does happen with them.
I'll make these measurements and report back

Looks like the the visit queue is overflowing in this examples. When that happens, it actually continues storing and reading outside, sometimes at indexes 3x larger than the last position of the stack, before finally freezing or crashing.
Setting the heap to a small value to intentionally cause an overflow also results in similar behaviour.
So the problem here is not the dups, but rather that it accumulates a lot of (+ b b) to reduce at once (if I understood correctly what the visit stack is).
The redex bag never gets full. But I found it strange that it always increases its index. What happens if it grows too quickly, will it just overwrite an old unresolved value (and cause incorrect behaviour)?

authors: VictorTaelin developedby

repo: Kindelia/HVM


text:
🛑 FSDH INT is down

In 8984db4, FSDH INT (https://fsdh-portal-app-int.azurewebsites.net/register) was down:

HTTP code: 0
Response time: 0 ms

Resolved: FSDH INT is back up in 1968de7 after 43 minutes.

repo: KingBain/proto-datahub-uptime


text:
[FEATURE] Add Search Functionality

🎇 Description
As mentioned in README.md, we can allow users to search for records through queries and filters.
🖼 Screenshots
No response

I would love to work on this. @KiranAminPanjwani Can you please assign this to me?

Sure, please proceed.😇

I'm no longer working on this. So if anyone wants to take this, please go ahead

authors: KiranAminPanjwani dipanshparmar

repo: KiranAminPanjwani/MedStats


text:
[BUG] Environmental Cherry Doors and Vanilla Cherry Doors mismatched

Minecraft Version: 1.19.2
Mod Loader System: Forge
DramaticDoors Version: 2.3.3
Environmental's Short Cherry Door item texture uses the vanilla Short Cherry Door item texture. Environmental's Tall Cherry Door block texture uses the vanilla Tall Cherry Door block texutre
Steps to reproduce the behavior:

Install Environmental
Make a new world (preferably in creative mode)
Get a Short Cherry Door and a Tall Cherry Door
Look at the Short Cherry Door texture in your inventory and place a Tall Cherry Door in your world

Expected behavior
The observed textures should match the ones from Environmental
Screenshots

Thank you, I will get that fixed shortly!

Now fixed in mod version 2.3.4


text:
CATIA v5 mouse controls

There are likely to be many users coming from CATIA v5 (like me). It would be good to add those controls to the user settings. Here are the mouse controls:
Pan : middle mouse click (hold) drag
Zoom: middle mouse click (hold) + right click (release) drag
Rotate : middle mouse click (hold) + right click (hold) drag
I do prefer KittyCAD controls however. So nice to be able to use the scroll wheel to zoom.

Might be a duplicate of a previous issue

repo: KittyCAD/modeling-app


text:
Overhaul error handling for commands

This means better exceptions and the use of @command.error decorator

Done

repo: Kiyomi-Parents/Kiyomi


text:
WindowsApps (Microsoft Store)

Friendly reminder: Bulk-Crap-Uninstaller does not remove older versions of apps installed from the Microsoft Store App.
Microsoft Store apps Folders;

C:\Program Files\WindowsApps\
C:\Users{user}\AppData\Local\Packages\

# List Microsoft Store apps for all users
Get-AppxPackage -AllUsers | Sort-Object Name | Select-Object PackageFullName, Name, Version

# List Microsoft Store apps for a specific user (replace {user} with your username)
Get-ChildItem -Path "C:\Users\{user}\AppData\Local\Packages\" | ForEach-Object { $PackageName = $_.Name; Get-AppxPackage | Where-Object { $_.PackageFamilyName -like "*$PackageName*" } | Sort-Object Name | Select-Object PackageFullName, Name, Version }

# List Microsoft Store apps for all users
Get-AppxPackage -AllUsers  ...

wow, thanks a lot for commands, some fixes/improvements/styling for my own use:
# List Microsoft Store apps for current users: -AllUsers flag raised Access is denied error, as I ain't admin
Get-AppxPackage | Sort-Object Name | Select-Object PackageFullName, Name, Version

# List Microsoft Store apps for a specific user (replace {user} with your username)
Get-ChildItem -Path $Env:LOCALAPPDATA\Packages\ |
ForEach-Object {
    $PackageName = $_.Name;
    Get-AppxPackage |
    Where-Object { $_.PackageFamilyName -like "*$PackageName*" } |
    Sort-Object Name |
    Select-Object PackageFullName, Name, Version
}

authors: goyalyashpal volkankaban

repo: Klocman/Bulk-Crap-Uninstaller


text:
Fold text object does not work any more

If isolated it's still ok, there must be something which has a side effect on this.

closed since v2.0.1


text:
How do i know which section selected under the cursor?

Is there a way tell me which section selected by mouse?
So I can change material of section by mouse click.
I want this to occur at runtime.

I try to store the transform of section when created, but I can't get the transform.

Hey @ToniFF,
For mobile you'd need to make sure to include the RuntimePhysXCooking module in the build.cs file for it to work on mobile. I'll be closing this issue as it should be working as intended, if you have additional issues, please feel free to open a new issue!

authors: Koderz ToniFF

repo: Koderz/RuntimeMeshComponent


text:
fix usage of iter_entry_points

see #276

Codecov Report

Merging #278 into master will decrease coverage by 2.46%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
- Coverage   92.74%   90.28%   -2.47%
==========================================
  Files          42       42
  Lines        2758     2758
==========================================
- Hits         2558     2490      -68
- Misses        200      268      +68

Impacted Files
Coverage Δ

django_q/conf.py
70.9% <0%> (ø)
:arrow_up:

django_q/brokers/ironmq.py
0% <0%> (-94.74%)
:arrow_down:

django_q/tests/test_brokers.py
70.58% <0%> (-11.77%)
:arrow_down:

django_q/brokers/__init__.py
94.18% <0%> (-2.33%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ec0ae...c646686. Read the comment docs.

Looks like this should resolve the issue. 👍

authors: codecov-io danielwelch jordanmkoncz


text:
Models in hidden (dot) directories not shown in extra networks LyCORIS tab

This falls out of line with the built-in model tabs support there.
It prevents the setting System > Load models/files in hidden directories from being useful for LyCORIS models.

Noticed the same, didn't know if I should put an issue in the extra networks git or in here, but since lycoris isn't supported by the main sd, here seems the best

I will support this these days

authors: KohakuBlueleaf Kuresuto12 boredofnames


text:
Implement requests/limits for all containers

Hi there!
Kong chart have the possibility to define resource quotas for the main pods but don't have an option to inheritance this resource for the migration job and neither for the batch init container kong.wait-for-postgres.
If we have a namespace with resourceQuotas, as example:
---
apiVersion: v1
kind: ResourceQuota
metadata:
  name: kong-rq-test
  namespace: kong
spec:
  hard:
    requests.cpu: '1'
    requests.memory: '2Gi'
    limits.cpu: '2'
    limits.memory: '4Gi'

When we try to install Kong in this environment, Kubernetes will be stuck int the migration-job:
failed quota: kong-rq-test: must specify limits cpu,limits.memory,requests.cpu,requests.memory
If  we inheritance the resources from the main container, this migrations will past but then we'll be stuck in the init continer.
Options:

Define limit range for the namespace, in this way all pod without resources defined will be use this default. Problems, what if the limit range defined is to minimal and the migrations job and batch pod cant run.
Inheritance the resource for migrations and define resources for batch.

Do you think that this issue needs to be resolved by the chart or is an administrator issue?

Thanks @bugbuilder for reporting this.
I think we should go with (2) because a global LimitRange wouldn't work well with multiple helm releases in the same namespace.
Updated the title to match (2).

Thanks @bugbuilder for reporting this.
I think we should go with (2) because a global LimitRange wouldn't work well with multiple helm releases in the same namespace.
Updated the title to match (2).

@bugbuilder if you're willing to contribute a patch, that'd be greatly appreciated!

@bugbuilder if you're willing to contribute a patch, that'd be greatly appreciated!

@mflendrich sure, I'll work on this to day.

@mflendrich sure, I'll work on this to day.

@mflendrich sorry for the delay. I was thinking that a good approach to fix this, will be add a new set of resource limits, only for initcontainers and jobs, something  like this:
resourcesHelpers:
  waitFor:
    limits:
     cpu: 100m
     memory: 256Mi
    requests:
     cpu: 100m
     memory: 256Mi
  migrations:
    limits:
     cpu: 100m
     memory: 256Mi
    requests:
     cpu: 100m
     memory: 256Mi

In this way, we dont have to inheritance the resource from kong directly because they could be to agressive for productons enviroments and could be stuck a new upgrade. What do you think?

@mflendrich sorry for the delay. I was thinking that a good approach to fix this, will be add a new set of resource limits, only for initcontainers and jobs, something  like this:
resourcesHelpers:
  waitFor:
    limits:
     cpu: 100m
     memory: 256Mi
    requests:
     cpu: 100m
     memory: 256Mi
  migrations:
    limits:
     cpu: 100m
     memory: 256Mi
    requests:
     cpu: 100m
     memory: 256Mi

In this way, we dont have to inheritance the resource from kong directly because they could be to agressive for productons enviroments and could be stuck a new upgrade. What do you think?

I need this improvement urgently!!!!.....thanks guys

Hello @mflendrich, I'm finished working at the inheritance resources for migrations and jobs pods, on the other hand also completed @bugbuilder proposal in this comment:

@mflendrich sorry for the delay. I was thinking that a good approach to fix this, will be add a new set of resource limits, only for initcontainers and jobs, something like this:
resourcesHelpers:
  waitFor:
    limits:
     cpu: 100m
     memory: 256Mi
    requests:
     cpu: 100m
     memory: 256Mi
  migrations:
    limits:
     cpu: 100m
     memory: 256Mi
    requests:
     cpu: 100m
     memory: 256Mi

In this way, we dont have to inheritance the resource from kong directly because they could be to agressive for productons enviroments and could be stuck a new upgrade. What do you think?

What do you think? What approach is better to adopt in this case to send the MR?

I'd say add a new resources block under the migrations settings, which you'd use in the three migration Jobs' container specs and the wait-for-postgres helper they use as an initContainer when the Postgres sub-chart is enabled.
The wait-for-db helper should inherit the Kong container settings, e.g. as its done here: https://github.com/Kong/charts/blob/kong-1.14.5/charts/kong/templates/deployment.yaml#L231-L232
The migration Jobs currently lack any resource allocation, and shouldn't inherit the proxy Deployment's Kong container allocation, since they shouldn't require nearly as much allocation (they just connect to the database and send a set of statements).
The init containers, while not particularly heavy workloads, can't be scheduled separately from the Job/Deployment they initialize. As such, while they don't strictly need as much resources as the containers they precede, we don't really gain anything by giving them a separate configuration.

@rainest I have made the changes with your suggestions. I'll be waiting for it

authors: bugbuilder dgonzalezc mflendrich rainest zjheyvc

repo: Kong/charts


text:
[kong] remove database waits

What this PR does / why we need it:
Remove database readiness/migration completeness init containers entirely. Kong Pods will enter CrashLoopBackoff after initial install, but will come online so long as the database comes online and there are no issues (e.g. invalid DB credentials) that block migrations.
Add configurable restart policies and backoff limits.
Which issue this PR fixes
This addresses two concerns:

Kong doesn't provide a good init option for migrations. There's no "simply check database connectivity command", so we use something else (bash or netcat) instead. We don't want this additional dependency.
initContainers don't play nicely with mesh sidecars.

We could make the init behavior more configurable, but after playing around with the options, I don't don't think the potential confusion from the temporary backoff state, primarily during the initial install, warrants the additional config surface, and is sufficiently handled with documentation and better control over the Job lifecycle.
Special notes for your reviewer:
Currently, the chart install sequence is:

The main Kong Deployment, initial migrations Job, and Postgres StatefulSet (if enabled) start simultaneously.
The init migrations Job includes an init container that performs an basic network connectivity test using bash. Once that succeeds, the Job exits the Init phase, enters Running, and creates its main container, which runs kong migrations bootstrap.
The main Kong Deployment includes an init container that runs kong start; kong stop, which won't succeed/exit Init until bootstrap finishes.

Upgrade Jobs also use the init strategy in (2). They use hooks, so the Deployment will not update until the pre-upgrade Job completes.
With this PR, the sequence is:

No change.
The main init migrations Job attempts to run kong migrations bootstrap immediately. If the database isn't available yet, it will crashloop until the database becomes available or until it exceeds the backoff limit.
The main Deployment starts and starts crashing until migrations complete, or crashes indefinitely if they fail to complete.

Upgrade jobs likely shouldn't enter backoff, since the database should already be running when they start.
If the database isn't managed by the chart, lack of a migration init container isn't much concern: database availability is the responsibility of the user, and the migrations job should be able to run immediately. When using the Postgres subchart, database availability is the responsibility of Helm, and there likely will be some delay. In practical testing, it comes online and migrations complete before the hard 6 minute backoff limit or CI wait period kill it.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] PR is based off the current tip of the next branch and targets next, not main
[x] New or modified sections of values.yaml are documented in the README.md
[x] Title of the PR and commit headers start with chart name (e.g. [kong])

Would addition of a DB connection retry mechanism in core solve this problem without regressing into CrashLoopBackOffs?

-1 on removing these waits. Seeing failed/crashlooping containers provides a bad user experience to our users. This is more of an optics problem than a technical one, where users don't like failures for software that they are installing and getting started with.

Kong doesn't provide a good init option for migrations. There's no "simply check database connectivity command", so we use something else (bash or netcat) instead. We don't want this additional dependency.

We have the option to add a patch in Kong to support this. I understand that is more involved but that is indeed the right solution. I don't see the urgency of removing these altogether.

https://github.com/Kong/charts/pull/278#issuecomment-780439477

I see the problem here. Can we offer a knob to remove the wait-for-db init container? Kuma use cases are the minority at the moment and hence the tradeoff we are making here seems wrong.

@svenwal for visibility

Can we offer a knob to remove the wait-for-db init container?

Thought I had linked the alternative but didn't. We can, it's just more template and config complexity than this option: https://github.com/Kong/charts/compare/next...feat/wait-for-revamp
I agree that the optics issue exists, but I think there's a reasonable case to accept it:

While not all users will deploy alongside a mesh proxy, we assume that some will, and they'll be stuck with the backoff loop regardless of whether we make this a toggle. The imperfect optics are at least consistent, and don't require config changes to support mesh proxies.
Installations/initial migrations are ideally infrequent, and we have options to explain odd behavior. Would the bad optics be more acceptable if we announce them more prominently, with a NOTES.txt message?

Another alternative is that we make the current lifecycle a special case for the built-in Postgres subchart only, and declare it incompatible with deployments alongside service meshes. While the subchart is great for quickly spinning up a test or demo environment, I'd recommend separately-managed databases for long-lived Kong deployments regardless.
The worst aspects of the optics go away if we can use a pre-install hook for initial migrations, as the main Kong Deployment won't start until that Job completes, and won't be stuck trying to start before migrations are done. We don't use a hook currently only because the built-in Postgres StatefulSet doesn't spawn until all pre-install hooks complete.
The migration Job init containers aren't as useful since failing entirely if the database isn't available makes sense--arguably moreso than getting stuck in init forever. While the init migrations probably will still restart while spawning alongside a new built-in Postgres, retry restarts are a normal Job feature, and they don't get stuck as long because they start as soon as Postgres comes up, whereas the main Deployment will build up more backoff time because it's waiting on both Postgres and migrations.

Alright, bummer, played around with the pre-install option and I don't think it's viable. I forgot that we rely on stuff we create in the install (RBAC resources) other than Postgres, and I'm pretty sure that there's no way to create those in pre-install phase and keep them a managed part of the release without template duplication, which is :vomiting_face:
Checking with the Helm community to see if there's some novel solution to that, but I don't think there is any. Prior solutions are to use an initContainer instead, which would still have the same issue that prompted this originally.

authors: hbagdi mflendrich nickolaev rainest


text:
Add automated spelling, grammar, style, and readability checking

Like this https://dzone.com/articles/vale-for-spelling-grammar-style-and-readability-li

This is a much larger discussion; we are working on this.

authors: coopr falondarville


text:
docs(oauth2) give more details to header X-Credential-Identifier

Summary
The original docs confuses customers. Upstream header
"X-Credential-Identifier" actually evaluates to client_id.
Reason
Customer reporting issue at FTI-3320.

@outsinre can you please rebase your PR? We've renamed all plugin index.md files to _index.md in a recent change.

authors: lena-larionova outsinre


text:
Generate 2.8.x conf for dev portal updates

Summary
Generated update for the configuration reference to add Dev Portal property descriptions.
For reviewers: please just check that it displays in the preview. Don't make text edits here, as the source of this content is in the kong/kong-ee repo.
Reason
Follow-up PR to: https://github.com/Kong/docs.konghq.com/pull/3751
Testing
TBA

This change is coming from source, which is already updated.


text:
fix(hub): Remove link from Publishers name

Removes link from hub card's publisher attribute

The screenshot looks like "Kong Inc." is still styled blue - can it be plain old black text instead? (I'm working on pulling and running locally, so I don't know for sure that it is blue)

The same blue styling is present on extension details pages:

It is a Kong svg that is blue - if I make the text black the Kong logo will also be black

Card bottoms are now uneven:

authors: coopr leevye


text:
Allow sidebar to show grpc requests

What it says on the tin.

I reused some higher level components, but instead of modifying MethodTag (which is technically for HTTP methods), I created a separate, simple GrpcTag component as it is easier to understand.

Nice QA @DMarby! As I was running through it I was happy to see how much of it we get for free.

Please address the above issues either in this PR, or by creating linear tickets for them so that they don't get lost.

Most of these have linear tickets, and there are some I missed during the initial task creation, which I will now create (namely, removing the items that don't apply to gRPC). They will be fixed in a separate PR, though. This PR makes no changes to the context menu of a request, because there were enough changes required to simply show a gRPC request in the sidebar.

repo: Kong/insomnia


text:
Update "Mock API" in README

its past november

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant cootshk


text:
Allow w3c to be set as the default propagation for opentelemetry plugin

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
3.1.1
Current Behavior
With the current implementation of opentelemetry propagation, we are having issues with non-w3c trace id's being 8 byte once they get to our backend.
The Zipkin plugin allows you to set a default_header_type, though still has the similar issue with not converting 8byte to 16byte -- which we addressed with some changes locally.
Expected Behavior
Implement similar behavior as the Zipkin plugin and allow a default_header_type type to be able to be set with opentelemetry.
This even aligns with what OpenTelemtry states should be the default:
https://opentelemetry.io/docs/concepts/signals/traces/#context-propagation
Of note, even if this is allowed to be set, especially if set to w3c it will also need to ensure that 8byte trace id headers don't get to the backend. This could be accomplished a few ways:

Convert 8byte trace id's to 16byte trace id's
If 8byte found, Kong can convert it to a new 16byte trace id
Throw away the 8byte trace id and don't populate the trace id

Steps To Reproduce

On Kong 3.1.1 set opentelemetry as your tracing plugin
Make a call that has a b3, 8 byte trace id
You'll find the backend doesn't have a w3c supported propagation

Anything else?
No response

FWIW, it does look like part of the issue reported was fixed with this: https://github.com/Kong/kong/pull/10332
However, we still need the w3c headers to get set and passed along to the backend.

@nbialostosky Are you up for a contribution?

@hbagdi I took a shot at implementing this here: https://github.com/Kong/kong/pull/10620

authors: hbagdi nbialostosky

repo: Kong/kong