text:
ng build my-lib --prod puts results in wrong directory

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)
- [ ] new
- [x] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

S:\Programming\git repositories\ng-app-state>node --version
v8.11.3

S:\Programming\git repositories\ng-app-state>npm --version
5.6.0

S:\Programming\git repositories\ng-app-state>ng --version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 6.1.0
Node: 8.11.3
OS: win32 x64
Angular: 6.1.0
... animations, cli, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.6.8
@angular-devkit/build-angular      0.6.8
@angular-devkit/build-ng-packagr   0.6.8
@angular-devkit/build-optimizer    0.6.8
@angular-devkit/core               0.7.0
@angular-devkit/schematics         0.7.0
@ngtools/json-schema               1.1.0
@ngtools/webpack                   6.0.8
@schematics/angular                0.7.0
@schematics/update                 0.7.0
ng-packagr                         3.0.6
rxjs                               6.2.2
typescript                         2.7.2
webpack                            4.8.3

Repro steps

Following the instructions for "Publishing your library", run ng build my-lib --prod
The log given by the failure

S:\Programming\git repositories\ng-app-state>ng build ng-app-state --prod
Building Angular Package
Building entry point 'ng-app-state'
Rendering Stylesheets
Rendering Templates
Compiling TypeScript sources through ngc
Bundling to FESM2015
Bundling to FESM5
Bundling to UMD
Minifying UMD bundle
Dropping unreachable code [0:169,16]
Declarations in unreachable code! [0:169,16]
Dropping duplicated definition of variable fb [0:336,24]
Copying declaration files
Writing package metadata
Removing scripts section in package.json as it's considered a potential security vulnerability.
Built ng-app-state
Built Angular Package!
- from: S:\Programming\git repositories\ng-app-state\projects\ng-app-state
- to:   S:\Programming\git repositories\ng-app-state\dist\lib

Desired functionality

The build should deposit its result in dist\ng-app-state, not dist\lib. This is indicated by the following instructions in "Publishing your library":
ng build my-lib --prod
cd dist/my-lib
npm publish

Mention any other details that might be useful

Running the same command without --prod (i.e. ng build my-lib') does deposit its results in the expected directory. So the destination is different with and without --prod`.
This also means the results of --prod cannot be used for integration tests, because the CLI sets up Webpack to look for the library in the expected directory.
Link to my repo: https://github.com/simontonsoftware/ng-app-state

I found the problem. This was the content of projects/ng-app-state/ng-package.prod.json:
{
  "$schema": "../../node_modules/ng-packagr/ng-package.schema.json",
  "dest": "../../dist/lib",
  "lib": {
    "entryFile": "src/public_api.ts"
  }
}

"dest" should be "../../dist/ng-app-state". After making that change the problem is solved. I made a library like this on another project more recently, and it did not have this problem, so I guess maybe it was a bug with an older version of the CLI? Closing this issue.

Hi, can you reopen this issue? This problem still occurs for this version
Angular CLI: 6.1.2
Node: 8.11.0
OS: win32 x64
Angular: 6.1.1
... animations, common, compiler, compiler-cli, core, forms
... http, platform-browser, platform-browser-dynamic, router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.8.9
@angular-devkit/build-angular      0.8.9
@angular-devkit/build-ng-packagr   0.8.9
@angular-devkit/build-optimizer    0.8.9
@angular-devkit/build-webpack      0.8.9
@angular-devkit/core               0.8.9
@angular-devkit/schematics         0.7.2
@angular/cli                       6.1.2
@ngtools/json-schema               1.1.0
@ngtools/webpack                   6.2.9
@schematics/angular                0.7.2
@schematics/update                 0.7.2
ng-packagr                         4.1.0
rxjs                               6.2.2
typescript                         2.7.2
webpack                            4.16.4

It creates the ng-package.prod.json with that lib name instead of the actual library name.

authors: ersimont jameshmread

repo: angular/angular-cli


text:
Issue with including underscore.js using wiki doc

Hi,
I was trying to include underscore using the doc on wiki: https://github.com/angular/angular-cli/wiki/3rd-party-libs#adding-underscore-library-to-your-project
I got an exception in console:  ReferenceError: _ is not defined. It was trigger at the place where the underscore function is called.
I traced down the problem that it was due to underscore.js was not loaded into the browser automatically.
However, if I use
import * as _ from 'underscore';

instead of
declare var _;

I was able to successfully load underscore.js and use it.
I think import will trigger systemjs auto load library. And when type definition file is available, import should be used. Otherwise, declare can be used but it requires manually load the library itself. Maybe wiki should be updated.

OS?  Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
OSX

Versions. Please run ng --version. If there's nothing outputted, please
angular-cli: 1.0.0-beta.9
node: 5.3.0
os: darwin x64

Repro steps. Was this an app that wasn't created using the CLI? What change did you
do on your code? etc.
Followed the steps on wiki:  https://github.com/angular/angular-cli/wiki/3rd-party-libs#adding-underscore-library-to-your-project

Closed as issue was made obsolete by #1455.

source: gharchive/issue

authors: filipesilva xcompass

license: MIT

license_type: permissive

license_source: github-api


text:
@ngtools/webpack not working with HMR after 8.0.0 and IVY enabled

🐞 Bug report
Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

not using angular cli, but @ngtools/webpack
Is this a regression?
Yes in version 8.0.1 was working, 8.1.0 or higher is not working.
Description
When you change anythying in your template and HMR reloads script you will receive error that any directive or component that is used in that template is not known. When you stop HMR and rebuild application and run it again everything is working fine until you change something. I have another project and i cant move from 8.0.1 because this is only working version with Angular IVY, @ngtools/webpack and HMR.
🔬 Minimal Reproduction
download this https://github.com/kukjevov/ngtools-error

git clone https://github.com/kukjevov/ngtools-error
cd ngtools-error
npm install
npm start
open in browser http://localhost:8888 add superinto eitherapp.component.htmlornavigation.component.html`
look for error in browser console

🔥 Exception or Error
if you change app.component.html you will get

Error: "Export of name 'outlet' not found!"

if you change navigation.component.html you will get

Error: "Template error: Can't bind to 'routerLinkActiveOptions' since it isn't a known property of 'div'."

🌍 Your Environment

angular and ngtools: 8.2.0
node: 10.16.0
npm: 6.9.0

Heya, I'm closing because https://github.com/angular/angular/issues/31916#issuecomment-517482988 indicates this is an bug on the Framework repository and there is a fix on the way.

authors: filipesilva kukjevov


text:
[Angular 13] Build not updating on referenced SCSS file changes when cache enabled

🐞 Bug report
Command (mark with an x)

[ ] new
[x] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
I think so, but not 100% sure. I didn't experience this issue using the NG_PERSISTENT_BUILD_CACHE=1 build cache in Angular 12.
Description
Given SCSS errors in files that are inside the workspace, but outside the angular project folder, re-running the build with caching enabled gives me old SCSS errors (they have been fixed since the prior build). If I manually delete the .angular folder the error goes away, as expected.
🔬 Minimal Reproduction
I don't have a simple repro right now - I will work on creating one if this is not an obvious bug, and is not eg a webpack or non-angular issue.
🌍 Your Environment

Angular CLI: 13.1.1
Node: 16.12.0
Package Manager: yarn 1.22.15
OS: win32 x64

Angular: 13.1.0
... animations, cdk, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1301.1
@angular-devkit/build-angular   13.1.1
@angular-devkit/core            13.1.1
@angular-devkit/schematics      12.2.14
@angular/cli                    13.1.1
@schematics/angular             13.1.1
ng-packagr                      13.1.1
rxjs                            7.4.0
typescript                      4.4.4
webpack                         5.65.0

@johncrim, a reproduction would definitely be helpful here since this might be related to
Folder structure.
A good way to make a minimal repro is to create a new app via ng new repro-app and adding the minimum possible code to show the problem. Then you can push this repository to github and link it here.

Will do, working on it right now.

I spent some time trying to create a repro case for this, and wasn't able to. The SCSS files that weren't rebuilding were transitive dependencies of the global styles.scss file (not transitive dependencies of component SCSS files as far as I could tell), referenced via @use. Creating a similar but simpler case for that has not worked for reproducing the issue.
After spending some time on the repro case, I now find that I'm not able to trigger this bug at all. So, closing the issue.

I'm seeing this too. If there's an error in my scss the cached, invalid, code will keep getting re-evaluated. All updates to the scss are ignored until the cache is deleted manually.

@michaelurban, please file a new issue with a reproduction. Thank you.

authors: alan-agius4 johncrim michaelurban


text:
Angular CLI Installation Error

I am using npm version 3.10.10, when I try to install angular-cli (npm install -g @angular/cli) it will only creating "npm-debug" file in folder.
npm-debug.log

I am getting same issue

Heya, I went through the log you posted and the error seems to be this:
92427 verbose stack Error: uglifyjs-webpack-plugin@0.4.6 postinstall: `node lib/post_install.js`
92427 verbose stack spawn C:\Windows\system32\cmd.exe;C:\Program Files\MongoDB\Server\3.4\bin ENOENT
92427 verbose stack     at exports._errnoException (util.js:1020:11)
92427 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:197:32)
92427 verbose stack     at onErrorNT (internal/child_process.js:376:16)
92427 verbose stack     at _combinedTickCallback (internal/process/next_tick.js:80:11)
92427 verbose stack     at process._tickCallback (internal/process/next_tick.js:104:9)
92428 verbose pkgid uglifyjs-webpack-plugin@0.4.6
92429 verbose cwd C:\Users\admin\Desktop\centralogic\angular-clone
92430 error Windows_NT 6.1.7601
92431 error argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install" "-g" "@angular/cli"
92432 error node v6.11.3
92433 error npm  v3.10.10
92434 error file C:\Windows\system32\cmd.exe;C:\Program Files\MongoDB\Server\3.4\bin
92435 error path C:\Windows\system32\cmd.exe;C:\Program Files\MongoDB\Server\3.4\bin
92436 error code ELIFECYCLE
92437 error errno ENOENT
92438 error syscall spawn C:\Windows\system32\cmd.exe;C:\Program Files\MongoDB\Server\3.4\bin
92439 error uglifyjs-webpack-plugin@0.4.6 postinstall: `node lib/post_install.js`
92439 error spawn C:\Windows\system32\cmd.exe;C:\Program Files\MongoDB\Server\3.4\bin ENOENT
92440 error Failed at the uglifyjs-webpack-plugin@0.4.6 postinstall script 'node lib/post_install.js'.
92440 error Make sure you have the latest version of node.js and npm installed.
92440 error If you do, this is most likely a problem with the uglifyjs-webpack-plugin package,
92440 error not with npm itself.
92440 error Tell the author that this fails on your system:
92440 error     node lib/post_install.js
92440 error You can get information on how to open an issue for this project with:
92440 error     npm bugs uglifyjs-webpack-plugin
92440 error Or if that isn't available, you can get their info via:
92440 error     npm owner ls uglifyjs-webpack-plugin
92440 error There is likely additional logging output above.
92441 verbose exit [ 1, true ]

It seems to be something with your MongoDB install and the uglifyjs-webpack-plugin@0.4.6 package. Perhpas node from there is causing problems?
You should open an issue at their repository: https://github.com/webpack-contrib/uglifyjs-webpack-plugin

authors: filipesilva kiplphp78 prashSutar


text:
Typescript 2.5 version mismatch

Versions
Angular CLI: 1.6.0
Node: 8.9.1
OS: darwin x64
Angular: 5.1.0
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cdk: 5.0.0
@angular/cli: 1.6.0
@angular/flex-layout: 2.0.0-beta.10-4905443
@angular/material: 5.0.0
@angular/service-worker: 1.0.0-beta.16
@angular-devkit/build-optimizer: 0.0.35
@angular-devkit/core: 0.0.22
@angular-devkit/schematics: 0.0.41
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.9.0
@schematics/angular: 0.1.10
@schematics/schematics: 0.0.10
typescript: 2.5.3
webpack: 3.10.0

Repro steps

ng new repo && cd repro
npm i typescript@2.5.3
ng serve

Observed behavior
This warning is emitted:
@angular/compiler-cli@5.1.0 requires typescript@'>=2.4.2 <2.5.0' but 2.5.3 was found instead.
Using this version can result in undefined behaviour and difficult to debug problems.

Please run the following command to install a compatible version of TypeScript.

    npm install typescript@'>=2.4.2 <2.5.0'

To disable this warning run "ng set warnings.typescriptMismatch=false".

Desired behavior
No warning should be emiteed since angular@5.1 is compatible with TS 2.5
Mention any other details that might be useful (optional)

Duplicate of #8768

Whoops, didn't found that one sorry!

authors: mehrad-rafigh sinedied


text:
The future of this project (Angular 1.X )

we are starting a large project and currently thinking about using Angular 1.X but there are concerns about the future of this project
Angular 2.0  development is quickly going forward and will release an stable version soon , but what will happen to Angular 1.X ?
how long do you intend to keep maintaining Angular 1.X ? Do you have any estimation of angular 1.x lifetime ? 2 years ? 4 years ?

@MahdiZareie - can I ask why you would not start this new large project with Angular 2 instead? What is the timescale for completing the new project and putting it into production? If you expect more than 6 months of development then I would definitely consider Angular 2.
Angular 1 will continue to be developed for the next few years but as the interest moves over to Angular 2, the resources put into maintaining it will be reduced.

Hope that @petebacondarwin answered your question. One way or another, I think this is not the right place to discuss this and one of the existing forums should be used.

authors: MahdiZareie lgalfaso petebacondarwin


text:
feat(http): Add 'useLegacyHttpMethods' to $httpProvider

For now it defaults to true. This will open up a path to remove the short hand methods in the long run.

I like the idea behind this. success() and error() have always worried me...

A few things

The documentation for it needs to be beefed up
a deprecation notice needs to go in the commit message
if the legacy methods have been turned off then they should be changed to throw a helpful error rather than simply missing.

I'll get to the documentation. Just wanted to get some feedback first ;)
Is there a special format for deprecation notices?

Perhaps something like this would work: https://github.com/angular/angular.js/commit/38fbe3ee8370fc449b82d80df07b5c2ed2cd5fbe

This would close #10508

Sorry, it took me way too long to get back to this.
I've changed the documentation to to mainly cover then and added a deprecation notice to both the commit and the documentation. I've also added the error messaged.
Small aside: Once this is merged, it would be great if this could be uplifted to 1.4, as this would allow switching the default to off in 1.5.

@realityking - thanks for improving this. Just a couple of issues with the minerr stuff and then we are good to go.

If we default to false then this is a breaking change and needs to go into 1.5

I've fixed minErr and added the tests. Is there a script to generate the scaffolding for the error docs or is that all by hand?
As for 1.5, my I idea was to ship this with default true in 1.4.x and change the default to false in 1.5. That would allow people to fix their libraries and apps ahead of the release. Also, we'd get rid of the legacy methods being front and center in the docs.

That is better.
For the error doc, you just make a copy of a file like https://github.com/angular/angular.js/blob/master/docs/content/error/%24http/badreq.ngdoc and doctor it to your needs. The rest is magic.
One last comment about the provider method, I feel that useLegacyMethods is a bit vague. Perhaps useLegacyPromiseExtensions or something?

I think I've addressed everything.

I will land this week.

source: gharchive/pull-request

authors: petebacondarwin realityking


text:
Breaks my app

When installed it breaks my app with
Error: [$parse:ueoe] Unexpected end of expression: audience.active?audience
http://errors.angularjs.org/1.4.3/$parse/ueoe?p0=audience.active%3Faudience
    at REGEX_STRING_REGEXP (http://localhost:3000/ui/assets/app.js:3179:12)
    at Object.AST.consume (http://localhost:3000/ui/assets/app.js:15999:13)
    at Object.AST.ternary (http://localhost:3000/ui/assets/app.js:15810:16)
    at Object.AST.assignment (http://localhost:3000/ui/assets/app.js:15797:23)
    at Object.AST.expression (http://localhost:3000/ui/assets/app.js:15793:17)
    at Object.AST.filterChain (http://localhost:3000/ui/assets/app.js:15784:21)
    at Object.AST.expressionStatement (http://localhost:3000/ui/assets/app.js:15780:62)
    at Object.AST.program (http://localhost:3000/ui/assets/app.js:15772:24)
    at Object.AST.ast (http://localhost:3000/ui/assets/app.js:15759:22)
    at Object.ASTCompiler.compile (http://localhost:3000/ui/assets/app.js:16211:31) <a ng-class="audience.active ? 'label-success' : ''" ng-bind="audience.active ? 'Active' : 'Inactive'" ng-click="audience.active ? audience.deactivate() : audience.activate()" ng-attr-title="Click to {{audience.active ? 'Pause' : 'Unpause'}}" class="label label-default ng-binding">

All works fine if I uninstall the extension.  Also it seems particularly related to the ng-click clause in the above code, because when I remove that the error disappears too.

(specifically, this snippet?  ng-click="audience.active ? audience.deactivate() : audience.activate()")
Dealing with this is tricky, as Batarang currently assumes you won't have any logic in your click events.  Angular's parser allows for that, but you may want to add a audience.toggle() instead of a ternary in ng-click.
@erwinmombay has been fixing bugs in that area.

I confirm Batarang has difficulties handling ternary operator in the ng-click directive.
To replicate the issue, use ng-table's demo page with Batarang on:
http://ng-table.com/#/demo/5-8
Couldn't you use the same expression parser as Angular itself?

@jirkahronik The purpose of our parser is to find undefined expressions, where Angular's parser swallows errors (and can make debugging tricky).

ill look into this.

fix landed in hint https://github.com/angular/angular-hint/commit/73a31957aa72f4d5f1d391c0528e5e01e8751ce5

authors: SomeKittens dolzenko erwinmombay jirkahronik

repo: angular/batarang

license: mit

license_source: bigquery


text:
feat(Horizontal Expansion Panel): Add Horizontal option to the Expansion Panel

Feature Description
Currently the Angular Material Expansion Panel expands vertically, but not horizonally:
https://material.angular.io/components/expansion/overview
Use Case
I have a use case where a card needs to be able to be expanded horizontally.
This person has the same use case:
https://stackoverflow.com/questions/46360604/opening-angular-material-expansion-panel-vertically

As far as I can tell, this isn't in the Material Design spec so we likely won't support it.

authors: RonanCodes crisbeto

repo: angular/components


text:
[Menu] Truncated nested menus in FireFox

Bug, feature request, or proposal:
Bug
What is the expected behavior?
The menus width to show the whole name like it does in Chrome and the menu to show all items (non-offscreen) when a long list is given.
What is the current behavior?
In Firefox the menu names are being truncated and in FF and Chrome the menu is off the screen when a long list is used.
What are the steps to reproduce?
https://stackblitz.com/edit/angular-material2-issue-c2wnl5
What is the use-case or motivation for changing an existing behavior?
I have a place in my app where there is multiple nested menus that all have (at times) a long list of items. When that is the case in FF the menu truncates the item names and in both FF and Chrome does not show the full menu.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 5.1.0, Material 5.0.0-rc.2, Ubuntu, Typescript 2.4.2

I tried this real quick with the latest Angular Material and the latest Firefox and it doesn't seem to be an issue any longer. Free free to open a new issue if a problem persists.


text:
fix(input): Fix floating label width

Fix floating label to resize the width to use all available space.
Fixes #688

You should keep in mind that this will cause an overflow on IE and Edge. They don't consider the scale when determining whether to overflow the parent.

@crisbeto: I think in those case we'll see the same behaviour as before this change, which is fine by me (for now).

We had a similar issue on Material 1, even though the label is scaled down to 75%, IE/Edge still consider it as if it was 100%. Then when you set it to 133% it overflows. See https://github.com/angular/material/pull/8116

@hansl are you able to see if this is an issue in IE / Edge?

Re IE/Edge I haven't had a chance to get my Windows Machine up last week. Will check it out tomorrow on a local VM.

I'm installing a VM to test this on IE 11. Will come back when done.

This seems to be working fine on IE11. Syncing up with Robert for more info.
Proof:

@crisbeto: ^ seems to work correctly. If you have something to add before we merge this in :)
Please note our DOM is largely different than Material 1, and much simpler/less reliant on hacks due to Shadow DOM and compartmentalization.

As soon as we clarify the situation with IE11/Edge I'll merge this in. :)

I'll try cloning it to check as well.

Alright, it works as it is now, but it starts overflowing if the any of the parents get overflow: auto. I'm not if it's an issue in this case, but here's what it looks like:

Interesting. By putting overflow: hidden on the md-input itself we mitigate setting it to anything above, which would be okay I guess. The worst case would be if a customer sets overflow: auto to the md-input itself, which we can say "don't do that" since there's no real reason to do it. And it would be fine if he sets it on the element above (and beyond). @crisbeto: What do you think?
@jean-merelis: Can you add overflow: hidden to the :host?

Yeah I'd say that setting a default overflow would be fine, since it's up to the end user to determine whether to override it in that case.

Thanks Kristiyan. Sorry if this was such a mess, but better be right the first time :)
After discussion with @robertmesserle seems like this is the right solution. I'll merge it as soon as Travis finishes.

authors: crisbeto hansl jean-merelis jelbourn


text:
docs(prerequisites,release): fixed dead pre-requisites link & added link to release.md

The link to the developer pre-requisites was dead, so I fixed it. I also noticed release.md could've used a link, so I added one.

@googlebot I signed it!

repo: angular/protractor


text:
Directive sample example

I had trouble running the quickstart because of, can contribute to this situation #198

Closed with reason in https://github.com/angular/quickstart/issues/198#issuecomment-243564772

authors: filipesilva ivanhoinacki

repo: angular/quickstart


text:
fix(register-element): add check for descriptor being defined

Using other component libraries, like Polymer, alongside Angular2+zones would
cause errors because the descriptor was undefined when the patched registerElement
was being called.

I need to add test, and to determine the proper fix for this.

I updated the implementation to check hasOwnProperty instead of just checking that callback name is present on prototype. Though this will prevent an error, but it would prevent the callback from being properly patched.
@vicb would the right approach here be to just set the zone-bound callback to prototype[callback] if !hasOwnProperty?

@jeffbcross might be... I'll take a look sometimes next week after I tackle some other issues here.

@vicb k, thanks. I added a commit (the squash commit) that handles this.
I also added a fix for when options argument isn't provided.

@jeffbcross

Could you please fix the comments when they are applicable ?
Please also add fixes #52 in the first commit comment.

Question: as a custom element can extend and other custom element, should we add some kind of marker to the bound callbacks to avoid patching them multiple time ?
/cc @IgorMinar

#52 & #31 both report an issue with Polymer, should we add some integration tests ?

Comments addressed and merged at https://github.com/angular/zone.js/commit/8bce00ee44cd869f3f61d6d7a9cdf5928cfdd1bc

authors: jeffbcross vicb


text:
Added Tailwind Toolbox links

Hi,
Hope i've done this right, it's the first time i've tried this! :)

Hey @tailwindtoolbox Thanks for your submission. To keep it simple can you just link to your main site on one category as to not set a precedence that people can submit various parts of their site to different categories.

Hi @joshmanders, I've made the changes! Have a good one!

authors: joshmanders tailwindtoolbox

repo: aniftyco/awesome-tailwindcss


text:
add(tools): @ngneat/tailwind

Name
Link

@ngneat/tailwind
https://github.com/ngneat/tailwind

Angular schematics that will integrate Tailwind CSS into Angular application.

[x] My item is in the right category
[x] My item is logically grouped below similar items
[x] My item's name and description respects the conventions of the list
[x] My item is awesome
[x] I have read and followed the contribution guidelines

Thank you!

Thank you!

authors: innocenzi vltansky


text:
Modal on Scrollreveal demo - where is it from?

The link for the demo is here: http://anijs.github.io/examples/scrollreveal/
I am using a Jquery based responsive full screen modal for my site, but it has some issues.
I really like how fluid and fast the modal on the scroll reveal demo was.
I looked at the page source and couldn't figure out how to locate the CSS for the modal. It doesn't look like a Bootstrap modal, so I wanted to know where I can get it. Thanks.

@rafic20 that page is using the 'Bootstrap Freelancer' template, available here:
https://startbootstrap.com/theme/freelancer
@darielnoel perhaps this issue can be closed?

repo: anijs/anijs


text:
Add tests.

Unit tests
Acceptance tests

Closing this issue as we have acceptance tests now.

repo: anilmaurya/ember-inplace-edit


text:
Cannot install via homewbrew

siera λ brew install animo/siera/siera                                                                                [main]
Error: animo/siera/siera: /opt/homebrew/Library/Taps/animo/homebrew-siera/Formula/siera.rb:1: syntax error, unexpected ':', expecting end-of-input
404: Not Found
^
@morrieinmaas can you take a look when you have the time?

fixed

repo: animo/siera


text:
Cataz

Source name
Cataz
Source link
https://cataz.net/
Language
English
Other details
+18/NSFW = no
For movies and series.
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a title with source name.
[X] I have checked that the extension does not already exist on the website extensions list or the app.
[X] I have checked that the extension does not already exist by searching the GitHub repository and verified it does not appear in the code base.
[X] I will fill out all of the requested information in this form.

Closed as it's a clone of sflix.to, which already exists as an extension.

authors: Secozzi edmxn

repo: aniyomiorg/aniyomi-extensions


text:
Character Profile

Describe your suggested feature
Add a Character profile section where we can add in info on a character and make it fully customizable just like in anilist
Other details
I'd like it to be linked with the Manga like when viewing Manga chapters of anime episode we get a section where characters can be added and edited in that Manga or Anime
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version 0.12.3.10.
[X] I will fill out all of the requested information in this form.

Use a different app or site for that feature

repo: aniyomiorg/aniyomi


text:
componentWillReceiveProps has been renamed

Move data fetching code or side effects to componentDidUpdate.
If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: InfiniteScroll
I get this warning in my console constantly. Am I using InfiniteScroll incorrectly or this legit something that needs to be addressed?

To overcome this issue browse
{your_project}\node_modules\react-infinite-scroll-component\lib\index.js
and change:
key: "componentWillReceiveProps", 	    value: function componentWillReceiveProps(props) { 	     ...
into:
key: "componentDidUpdate", 	    value: function componentDidUpdate(props) {...
Keep in mind you edit the build version, so for good measure you could also edit pre-build file
({your_project}\node_modules\react-infinite-scroll-component\app\index.js) and change function names there as well.

Im still seeing this warning when using the official npm install package.
am i doing something wrong?

To overcome this issue browse
{your_project}\node_modules\react-infinite-scroll-component\lib\index.js
and change:
key: "componentWillReceiveProps", value: function componentWillReceiveProps(props) { ...
into:
key: "componentDidUpdate", value: function componentDidUpdate(props) {...
Keep in mind you edit the build version, so for good measure you could also edit pre-build file
({your_project}\node_modules\react-infinite-scroll-component\app\index.js) and change function names there as well.

Hey @ankeetmaini  I am also getting the same warning message.So I tried doing this fix but I couldn't find a  lib folder in my node_modules.So how to fix this error ? By the way I also used the official npm package.

Using this in strict mode is resulting in a warning message.
Warning: Using UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs in your code.

Why close ? This issue is still present in strict mode... How to fix it ?

It has trouble. It didn't fix. What should I do?

I agree! The problem is not solved!


text:
Add support for autofill labels

Add placeholders in keeping with the autofill standards described by
Google.
References #2.

Send PR at contribution branch


text:
Before and After slots are replacing the animation.

I'm trying to add some text above the spinner using the before slot. The text is showing but the spinner has disappeared!
<loading :active="loading"
                 :can-cancel="false"
                 :is-full-page="true"
                 color="#ffd04b">
            <before>Loading...</before>
        </loading>

Solved this. I was using slots wrong. The following works:
<loading :active="loading"
                 :can-cancel="false"
                 :is-full-page="true"
                 color="#ffd04b">
            <template v-slot:before>
            Loading...
            </template>
        </loading>


text:
Website is down

It seems like the website is down.

Fixed the issue, the website will be up in sometime.

authors: ankurrsinghal tinkerbaj

repo: ankurrsinghal/svelte-legos


text:
fix message cleanup

nrm_msg_t needs to destruction functions, depending on whether we created the whole object or it was created by protobuf. Properly fix the codebase to deal with that.

Fixed by #54

repo: anlsys/libnrm


text:
Change to fork version togglv8 gem.

TogglのAPIのURLが変更されたため使用するGemをURLを差し替えたフォーク版のgemに変更したものです。

Gemfile.lock に更新があると思うのでそれも上げておいてください 🙏

@ofnhwx 更新したGemfile.lockをコミットしました。

authors: BigWestGang ofnhwx


text:
🛑 Pedproject is down

In daf236c, Pedproject (https://педпроект.рф) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Pedproject is back up in b061c0c after 12 minutes.

repo: ano-pedproject/repo


text:
eth_bridge::everything e2e test is flaky

For example, in https://ci.heliax.dev/anoma/anoma/4249/3/7 which was for commit https://github.com/anoma/anoma/pull/1096/commits/f8d92f70c873b51e5d95406529442cbf9ca4c90e in https://github.com/anoma/anoma/pull/1096 , the test failed with an error like
The application panicked (crashed).
Message:  called `Result::unwrap()` on an `Err` value:
   0: Reached a timeout for expect type of command
       Needle: Transaction accepted

Location:
   tests/src/e2e/setup.rs:471

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
   1: __libc_start_main<unknown>
      at <unknown source file>:<unknown line>

Run with COLORBT_SHOW_HIDDEN=1 environment variable to disable frame filtering.
Run with RUST_BACKTRACE=full to include source snippets.
Location: tests/src/e2e/eth_bridge_tests.rs:80

Running the test locally passes. This needs investigation.

Another flake with rexpect - https://ci.heliax.dev/anoma/anoma/4309/2/7

repo: anoma/anoma


text:
Add IBC functions for transaction

To handle IBC modules in a transaction, we add functions to do them, e.g. create_client().
They are implemented in vm_env and a transaction can call them.
┆Issue is synchronized with this Asana task by Unito

The next release version v0.12.0 of ibc-rs will support no-std.
I could build IBC wasm transaction with the master branch of ibc-rs.
Updating to v0.12.0 requires some fixes for Anoma IBC-related code.


text:
refactor PoS VP

depends and based on anoma/anoma#1090
closes anoma/namada#18

moved to https://github.com/anoma/namada/pull/318


text:
Update net_address shishaonthespot.toml

Description
Previous PR: https://github.com/anoma/namada-testnets/pull/1268
Update shishaonthespot.toml for tesntet-15: https://github.com/anoma/namada-testnets/pull/2174
All previous genesis validators should name their PRs "Update {validator_alias}.toml for tesntet-15" and provide links to previous PRs merged.
If this is an UPDATE for a previous genesis validator
Checks are made against your net_address. If this has changed since the previous testnet, make sure you provide links of previous prs merged from your previous git username.
Thanks in advance!
Checklist before merging

[ ] Only one toml is added in this PR
[ ] The file being added is indeed a .toml file
[ ] The toml being added is to the correct folder, and only to the correct folder
[ ] The eth_hot_key and eth_cold_key are present
[ ] The email, discord, elements telegram, and twitter fields are present and valid

Hi @bengtlofgren . anything i can to to have this MR merged instead of closed?

repo: anoma/namada-testnets


text:
Caveat for angular projects

We are using this library as a polyfill for IE11 which appears to not have TextEncoder defined.
We are using Angular 8.
I previously had version 1.0.8 installed, and in my polyfills.ts I had import 'fastestsmallesttextencoderdecoder'; and all was well in Chrome and Firefox, but IE11 had a problem with that, with TextEncoder being undefined.
After updating to 1.0.14 and making no other changes, I was getting errors from the library that f.decode is undefined. I think it had to do with the version of the library that was being loaded in the browser, it appeared to either be incompatible with Chrome/Firefox or the build process was using the wrong file (perhaps it was using the node file in the browser?).
After changing my import to specifically target the browser version, i.e. import 'fastestsmallesttextencoderdecoder/EncoderDecoderTogether.min'; in my polyfills.ts, all is well AND IE11 is now working just fine.

I apologize for taking so long to respond to you. As I myself do not use AngularJS, I researched the topic of incorporating AngularJS support into this library. However, I found no solution which did not add many files to the top level directory, so all the solutions I found would severely cluttered this project. If you can direct me to an appropriate guide which would not junk up the the top level directory, I would be happy to invest as much more time as is needed to incorporate AngularJS. Otherwise, I would suggest using the dropbox script from the Quick Start section. I hope this helps.
~ Happy Coding!

I am also angular user, using angular 9. I used version 1.0.14, and imported it by inserting import 'fastestsmallesttextencoderdecoder'; in `polyfills.ts.
It works in IE 11,  with es5 version  which is specified by main property of package.json.
But it failed in Chrome, reporting error :
Uncaught TypeError: F.decode is not a constructor
    at Module../node_modules/fastestsmallesttextencoderdecoder/NodeJS/EncoderAndDecoderNodeJS.min.module.js (EncoderAndDecoderNodeJS.min.module.js:5)
    at __webpack_require__ (bootstrap:84)
    at Module../src/polyfills.ts (polyfills.ts:1)
    at __webpack_require__ (bootstrap:84)
    at Object.1 (polyfills.ts:103)
    at __webpack_require__ (bootstrap:84)
    at checkDeferredModules (bootstrap:45)
    at Array.webpackJsonpCallback [as push] (bootstrap:32)
    at polyfills.js:1

I tracked it down, and found that it ran with es2015 version (aka, the module version) in Chrome.
And I did some test, the EncoderAndDecoderNodeJS.src.module.js source code can not directly run in Chrome.
It seems there are some errors in line 112 of  file FastestSmallestTextEncoderDecoder/NodeJS/EncoderAndDecoderNodeJS.src.module.js
When window_global["TextDecoder"] exists,  new FinalTextDecoder["decode"]  failed in Chrome since decode is not a constructor.  And I tried  **new FinalTextDecoder()["decode"] **, it works.
Expecting new release to fix this, thank you~

I have updated the instructions for AngularJS: https://github.com/anonyco/FastestSmallestTextEncoderDecoder/blob/master/README.md#angularjs. As AngularJs is still foreign to me, please check my terminology and sentence structure. Did I do a correct job at explaining what needs to be done for AngularJS and/or what should I change? Many thanks and happy coding.

I am going to close this issue for now. If you feel it needs to be reopened, please feel free to do so. Again, many thanks.

authors: anonyco biltongza rhlin


text:
Contenu - Analyse - Figer certains codes dans les éléments d'en-tête ?

##Problème rencontré
Plusieurs éléments d'en-tête reprennent les spécifications du Volet de structuration minimale. L'auteur du document, le legalAuthenticator,... seront a priori toujours les logiciels DUI. Il pourrait donc être intéressant d'épurer les spécifications pour figer certaines valeurs
          Le code assignedAuthor.code issu du [JDV_J01-XdsAuthorSpecialty-CISIS](https://mos.esante.gouv.fr/NOS/JDV_J01-XdsAuthorSpecialty-CISIS/JDV_J01-XdsAuthorSpecialty-CISIS.pdf) doit-il être fixé à LOGICIEL_DUI ?

Originally posted by @mlr-kereval in https://github.com/ansforge/IG-fhir-medicosocial-transfert-donnees-dui/issues/110#issuecomment-2176460589

Rôle de l’auteur du document (ici c'est le rôle du système ayant générer le document) dans JDV_J01-XdsAuthorSpecialty-CISIS
1.2.250.1.213.1.1.4.6;LOGICIEL_DUI;Logiciel de Dossier Usager Informatisé
Pour identifier le type de document dans JDV_J07-XdsAuthorSpeciality-CISIS  issu TRE_A05-TypeDocComplementaire
1.2.250.1.213.1.1.4.12;EXPORT_DUI;Export du Dossier Usager Informatisé

Pas de questionnement sur le type de document qui est unique par document. En revanche, l'auteur, le legalAutheniticator, et probablement d'autres encore n'imposent que le JDV, pas la valeur à prendre dans le JDV

@mlr-kereval , @cmercier-kereval,  propositions à soumettre à @SEBELIN  pour validation et simplification des spécifications

Bonjour, Je valide ces valeurs

Bonjour @SEBELIN,
Pouvons-nous restreindre l'élément author à la cardinalité 1..1 ?

Oui, le dossier de l'usager est produit par l'établissement qui en est le responsable pour sa diffusion.

Top, tout est ok, je clôture l'issue

authors: SEBELIN jguihot mlr-kereval


text:
Collections deprecate & upload rbac

Follow-up to https://github.com/ansible/ansible-hub-ui/pull/1766 (AAH-1025)
Namespace detail: not changed in #1766, just adding a FIXME to check the individual permissions eventually
Collection header (collection detail screens): we already have the rbac info inside collection, through the magic of include_related=my_permissions, use that
Collection list: same as above, except we first need to add the param .. and make it work API-side: https://github.com/ansible/galaxy_ng/pull/1304
(I'm not 100% sure about change_namespace for deprecation, but it seems the closest one, and the previous namespace detail impl only checked that my-namespaces doesn't 404 on that one ... EDIT: David confirmed it's the right one)
(draft because waiting for API PR to be merged first, and probably rebase after https://github.com/ansible/ansible-hub-ui/pull/2159)

(originally tested with
diff --git a/galaxy_ng/app/api/ui/viewsets/collection.py b/galaxy_ng/app/api/ui/viewsets/collection.py
index cbc5603..45abb3a 100644
--- a/galaxy_ng/app/api/ui/viewsets/collection.py
+++ b/galaxy_ng/app/api/ui/viewsets/collection.py
@@ -33,6 +33,7 @@ class CollectionByCollectionVersionFilter(pulp_ansible_viewsets.CollectionVersio
     keywords = filters.CharFilter(field_name="keywords", method="filter_by_q")
     deprecated = filters.BooleanFilter()
     sign_state = filters.CharFilter(method="filter_by_sign_state")
+    include_related = filters.BooleanFilter() # fake filter for my_permissions

     def filter_by_sign_state(self, qs, name, value):
         """Filter queryset qs by list of sign_state."""

but David has a better version, pr coming soon)

TODO rewrite on top of actions & src/permissions from the page branch

Closing, that code has changed too much, and will get more API change for namespaces

repo: ansible/ansible-hub-ui


text:
Deleting a deployment does not delete replicaset

I'm trying to delete deployment using state = absent, but it does not delete replicaset.
Deployment example:
- name: Deploy {{ name }}
  k8s_extensions_v1beta1_deployment:
    name: '{{ name }}'
    namespace: '{{ namespace | default("default")}}'
    state: '{{ state }}'
    #    dry_run: yes
    debug: yes
    spec_template_metadata_name: '{{ name }}'
    labels:
      app: '{{ name }}'
    spec_selector_match_labels:
      app: '{{ name }}'
    spec_template_metadata_labels:
      app: '{{ name }}'
    selector_match_labels:
      app: '{{ name }}'
    selector_match_expressions:
     - { key: "app", operator: In, values: ["{{ name }}"]}
    containers:
      - name: '{{ name }}'
        image: '{{ image }}'
        ports:
        - container_port: '{{ port }}'
          protocol: TCP
          name: '{{ name }}'
    replicas: 1
  register: create_deployment

These modules use Openshift Python REST Client, which in turn calls DeleteObject with empty V1DeleteOptions unconditionally.
As result, Deployment is deleted with orphan propagation policy.
Not sure how to fix this properly. I've cloned https://github.com/openshift/openshift-restclient-python to https://github.com/echupriyanov/openshift-restclient-python

This is correct. We've actually included this change in the main openshift-restclient-python for a quick fix [1], we're not sure yet what the best way to handle this correctly would look like. It should be fixed with the latest openshift-restclient-python though.

https://github.com/openshift/openshift-restclient-python/commit/31581bdc9cad334a31e921f52ae72ee53b7db831#diff-93163b9d3a7911b26d817c4c84079df1

authors: echupriyanov fabianvf rahulinux

repo: ansible/ansible-kubernetes-modules


text:
To handle all available error response code from VS code extension side for wisdom

PR to handle all available error response code from VS code extension side for wisdom
ref: https://issues.redhat.com/browse/AAP-8752

@robinbobbitt @TamiTakamiya Please review this PR

authors: ganeshrn justjais

repo: ansible/vscode-ansible


text:
Timestamp improvements

I think that if you deploy to several hosts in parallel, all should have the same release timestamp, so the task that registers the timestamp shoud be delegated to the local host.
But if we do this, when the deployment is launched from hosts in different timezones the generated timestamps can be confusing, so I think the release timestamp should be generated with the UTC timezone.
What do you think about?

It can also happen that the hosts have a wrong timestamp for instance, but there is not much we can do about it. Try to alter time settings in just some servers inside a Cassandra cluster... you can have lots of fun!
Generally speaking, agreed to generate the timestamp just once (locally or in the first server Ansible connects to) using UTC

This is a bug, it should be a run_once and local action.
Carlos Buenosvinos
@buenosvinos

On 13 May 2015, at 20:29, Ricard Clau notifications@github.com wrote:
It can also happen that the hosts have a wrong timestamp for instance, but there is not much we can do about it. Try to alter time settings in just some servers inside a Cassandra cluster... you can have lots of fun!
Generally speaking, agreed to generate the timestamp just once (locally or in the first server Ansible connects to) using UTC
—
Reply to this email directly or view it on GitHub.

And what is your opinion about using UTC?

I discovered a small problem with this while doing some testing locally. If you use serial each group of boxes executes the run_once actions independently so you end up having a timestamp for each group
The only way I have seen to overcome this is to pass a variable to the playbook from the command line, so I suggest we document that option in the README and if the variable is not passed, we should use the run_once that @carlosbuenosvinos suggested.
Thinking more about it... I am not sure about the UTC thing being better than using the date format... I think maybe we should use whatever timezone the box running the playbook is using (so basically the same instruction but executed locally)
Thoughts?

I'm currently using my own role (inspired by ansistrano) and it works like you have described.
There is an optional var ajgarlag_deploy_version. If it is not defined, the timestamp is computed locally with the command date -u  +%Y%m%d%H%M%SZ. In the following task, if the ajgarlag_deploy_version is not defined, the set_fact module defines it with the STDOUT value of the previous command.
I append the Z letter to the timestamp, to avoid any confusion with the timezone interpretation of the releases directories.

Then feel free to open a PR with these changes :)

Yep! We want that PR :)

Timestamp is important because of the sorting in order to rollback or clean. I'm worried about leaving to the user 100% control of generating the version numbers. I also understand that there's no better approach for now (i'm investigating custom modules or custom lookups, but no luck for now). What do you think @ricardclau, @theUniC? Should we go for this approach while no better options?

I am :+1: for this as there don't seem to be any better options. But I think we should clearly document it and state the rollback problem in the situation @carlosbuenosvinos is describing.
At the end of the day you only need that if you use serial and actually care about all servers having the exact same release number not just the order

The rollback command is using ls -1t, to list the releases directories so they are being sorted by the modification time, not by the release directory name.

You are right, I am totally :+1: on this

Ok, so, let's merge.

Closed after merging #32

nice!

authors: ajgarlag carlosbuenosvinos ricardclau

repo: ansistrano/deploy


text:
Error message and automatically prepended attribute name

Thank you very much for this useful library. I'm currently working on my first JavaScript/React project, and the language and framework independence of validate.js is important.
Because of that pursuit for independence, I'm somewhat surprised that attribute names get prepended to error messages automatically. It seems to make assumptions about the way error messages are handled by the application. For instance, if I want to show the error message directly under the offending input field, having the attribute name as part of the message is kind of redundant. Is there a way around this?

I'm glad you find the library useful :)
Here something that might help you:
var constraints = {
  username: {
    presence: true
  }
};

var errors = validate({}, constraints, {fullMessages: false});
console.log(errors);
// {username: ["can't be blank"]}

// Makes all the errors for the "username" field capitalized
console.log(errors.username.map(validate.capitalize));
// ["Can't be blank"];

// You can also use the ^ operator on custom messages
console.log(validate({}, {username: {presence: {message: "^Is required"}}}));
// {username: ["Is required"]}

Thanx for the swift reply. And yes, it did help. It also shows I must read all available documentation more carefully. This is the second time in one day that I asked a question on github to which the answer could be found in the docs. I sincerely apologize.

That's no problem at all, I'm happy to help :)
Let me know if there are any other issues.

authors: ansman pjdevries


text:
maint: Upload PDF documentation

Closes #67

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.70%. Comparing base (c5c5ca4) to head (bbc54d5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   59.70%   59.70%
=======================================
  Files          21       21
  Lines         675      675
=======================================
  Hits          403      403
  Misses        272      272

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@SMoraisAnsys is this the proper way to upload the PDF in the docs? I'm a bit confused, the PDF is in the appropiate folder when I download the generated HTML documentation, but I still get a 404 when I click the PDF button. Do you mind taking a look?

@SMoraisAnsys is this the proper way to upload the PDF in the docs? I'm a bit confused, the PDF is in the appropiate folder when I download the generated HTML documentation, but I still get a 404 when I click the PDF button. Do you mind taking a look?

Nevermind, it was redirecting me to the actual deployed docs, I think these changes should work. Can you take a look anyway just in case there is any better way to do this?

@SMoraisAnsys is this the proper way to upload the PDF in the docs? I'm a bit confused, the PDF is in the appropiate folder when I download the generated HTML documentation, but I still get a 404 when I click the PDF button. Do you mind taking a look?

Nevermind, it was redirecting me to the actual deployed docs, I think these changes should work. Can you take a look anyway just in case there is any better way to do this?

I think you can limit your changes to the workflow input add-pdf-html-docs-as-assets: true. The action takes care of  zipping / copying / pasting files to the expected directory doc/_build/html/_static/assets/download. If you don't want all PDF files to be copied in the assets directory, you might want to be sure that your project variable in conf.py is ansys-tools-visualization-interface. Otherwise every PDF file will get uploaded.

Thanks for the feedback 🙂


text:
Use trusted publisher

Closes #279
Use trusted publisher approach for release

Can we have a slightly more descriptive PR header? Otherwise looks as I would expect

repo: ansys/grantami-recordlists


text:
Menu customization 🧐[问题]

🧐 问题描述 [详细地描述问题，让大家都能理解]
Is it possible to customize side bar menu similar to below screenshot?
(Menu group icon on left and menu items for that group on right)
💻 示例代码 [如果有必要，展示代码，线上示例，或仓库]
🚑 其他信息 [如截图等其他信息可以贴在这里]

you can look here

repo: ant-design/ant-design-pro-layout


text:
feat: sync type with ConfigProvider

feat: props
feat: sync theme with ConfigProvider
docs: update demo

Codecov Report

Merging #17 (c699ab0) into master (7703a90) will decrease coverage by 0.40%.
The diff coverage is 35.29%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   69.90%   69.50%   -0.41%
==========================================
  Files          67       67
  Lines         442      446       +4
  Branches       67       69       +2
==========================================
+ Hits          309      310       +1
- Misses        133      136       +3

Impacted Files
Coverage Δ

src/ThemeSelect.tsx
100.00% <ø> (ø)

src/component-panel/index.tsx
77.77% <0.00%> (ø)

src/token-panel/token-card/index.tsx
100.00% <ø> (ø)

src/token-panel/token-item/index.tsx
8.69% <0.00%> (-0.61%)
:arrow_down:

src/previewer.tsx
57.14% <66.66%> (ø)

src/token-panel/index.tsx
51.72% <75.00%> (+1.72%)
:arrow_up:

src/utils/classifyToken.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7703a90...c699ab0. Read the comment docs.

authors: MadCcc codecov-commenter

repo: ant-design/antd-token-previewer


text:
Tab scrollbars are narrow and hard to use

I frequently find I have more tabs open for a given DB connection than will fit horizontally across the screen.  There is a horizontal scrollbar below the tabs for moving right and left but it is only about 2 pixels tall and very difficult to grab with the pointer.  I consistently end up grabbing a tab itself by mistake and dragging that tab to the right or left, and it's difficult to drop one back in the same order as before.
If the scrollbar were a few pixels taller, or popped up a "thumb" when rolled over, this would make grabbing the scrollbar easier.
The ctrl-PageUp and ctrl-PageDown shortcuts are helpful, but sometimes I would like to be able to see what's on the current tab while looking for another related tab.  I create tab "labels" by putting a SQL comment in the first line of each query editor, so I can quickly scan for variations of a query etc.
Related, the numbers displayed on the tabs (<>...#1, <>...#3, etc.) are not related to the shortcuts for jumping to a tab; that is, given the two tabs #1 and #3 typing ctrl+2 jumps to the tab labeled #3.  I understand the reason for this and am not asking for it to be changed, but it makes it difficult to use those shortcuts when the number of tabs scrolled off to the left is not known.  This is another reason I'd prefer to be able to grab the scrollbar.
Thanks for considering a solution to this.

Hi @bart-schaefer,
i don't know if you've noticed but you can scroll through the tabs either with gestures on the trackpad (usually two fingers to the right or left) or with the mouse wheel (scrolling up or down is equivalent to left or right).
Let me know if for some reason in your case you are unable or uncomfortable to use this solution.

Hi @Fabio286, thanks for the tip RE mouse wheel, my only issue with it is that I first have to click on a tab to move focus, which means losing my insert position in the editor.

What operating system are you using Antares on?
Because normally you don't have to click on the tabs to give them the focus.

Also, the scroll wheel doesn't always work.  Seems to fail if I have multiple different connections open?  But I'm not sure exactly when it goes wrong.

I will investigare 🕵

repo: antares-sql/antares


text:
fix: Using vue@^2.6.14 in example/cli will cause a error.

such like:
<script setup lang="ts">
const count = ref(0)
</script>
<template>
  <span>{{ count }}</span>
</template>

console will throw error:
 The setup binding property "count" is already declared.

and this will appears to dom:
{ "value": 0 }

Do you mean it conflicts with 2.7?

Do you mean it conflicts with 2.7?

Yes, Exactly.

authors: Meglody antfu


text:
Issue with latest version (0.11.12)

I have the following error when trying to start Vite dev server with the latest version (0.11.12):
failed to load config from C:\Users\Maicol\Documents\Projects\Web\openstamanager\osm_rewrite\vite.config.ts
error when starting dev server:
TypeError: Cannot read property 'disable' of undefinedents\Projects\Web\openstamanager\osm_rewrite
    at Object.get disabled [as disabled] (C:\Users\Maicol\Documents\Projects\Web\openstamanager\osm_rewrite\node_modules\.pnpm\vite-plugin-pwa@0.11.12\node_modules\vite-plugin-pwa\dist\index.js:617:27)
    at C:\Users\Maicol\Documents\Projects\Web\openstamanager\osm_rewrite\node_modules\.pnpm\deepmerge@4.2.2\node_modules\deepmerge\dist\cjs.js:94:59
    at Array.forEach (<anonymous>)
    at mergeObject (C:\Users\Maicol\Documents\Projects\Web\openstamanager\osm_rewrite\node_modules\.pnpm\deepmerge@4.2.2\node_modules\deepmerge\dist\cjs.js:86:18)
    at deepmerge (C:\Users\Maicol\Documents\Projects\Web\openstamanager\osm_rewrite\node_modules\.pnpm\deepmerge@4.2.2\node_modules\deepmerge\dist\cjs.js:117:10)
    at cloneUnlessOtherwiseSpecified (C:\Users\Maicol\Documents\Projects\Web\openstamanager\osm_rewrite\node_modules\.pnpm\deepmerge@4.2.2\node_modules\deepmerge\dist\cjs.js:34:5)
    at C:\Users\Maicol\Documents\Projects\Web\openstamanager\osm_rewrite\node_modules\.pnpm\deepmerge@4.2.2\node_modules\deepmerge\dist\cjs.js:94:23
    at Array.forEach (<anonymous>)
    at mergeObject (C:\Users\Maicol\Documents\Projects\Web\openstamanager\osm_rewrite\node_modules\.pnpm\deepmerge@4.2.2\node_modules\deepmerge\dist\cjs.js:86:18)
    at deepmerge (C:\Users\Maicol\Documents\Projects\Web\openstamanager\osm_rewrite\node_modules\.pnpm\deepmerge@4.2.2\node_modules\deepmerge\dist\cjs.js:117:10)
 ELIFECYCLE  Command failed with exit code 1.

Previous version (0.11.11) works fine

@maicol07 can you provide a minimal repro?

@userquin this the repo I'm working on: https://github.com/devcode-it/openstamanager/tree/3.x-dev (branch 3.x-dev)
Currently, I've pinned Vite PWA to 0.11.11. You should be able to see the error by changing that to 0.11.12

@maicol07 here is no 3.x-dev, do you mean 3.x?

@maicol07 here is no 3.x-dev, do you mean 3.x?

Yes, sorry. I'm used to composer and npm branch names 😅

@maicol07 it seems there is some merge with pwa plugin options not yet resolved and so the error: the problem is that osmConfig will do a deep merge of the pwa plugin and we cannot do that since the options are resolved via Vite lifecyle.
If I just use export default defineConfig().withPlugin(VitePWA({...})) I have this another error on the client:
LoginPage.tsx:28 Uncaught ReferenceError: React is not defined
    at LoginPage.view (LoginPage.tsx:28:5)
    at Function.callHook (render.js:30:16)
    at initComponent (render.js:155:45)
    at createComponent (render.js:160:3)
    at createNode (render.js:66:8)
    at createComponent (render.js:162:4)
    at createNode (render.js:66:8)
    at createNodes (render.js:50:5)
    at updateNodes (render.js:277:45)
    at render.js:964:4
view @ LoginPage.tsx:28
callHook @ render.js:30
initComponent @ render.js:155
createComponent @ render.js:160
createNode @ render.js:66
createComponent @ render.js:162
createNode @ render.js:66
createNodes @ render.js:50
updateNodes @ render.js:277
(anonymous) @ render.js:964
mount @ mount-redraw.js:45
setup @ app.ts:49
(anonymous) @ createInertiaApp.ts:34

@maicol07 previous error with pwa plugin 0.11.12 and just works, but opening the index page we get previous client error.

Oh yeah, the trick was to use withPlugin() instead of the plugins array.
Thank you!

repo: antfu/vite-plugin-pwa


text:
Have to add "web app capable" tags manually

I've just tried setting up a plain project:
$ npm --version
8.12.2
$ npm create vite@latest
(choose vanilla-ts, name "test")
cd test
npm i
npm i vite-plugin-pwa -D

after which I followed the steps described here and here
Now if I start the app locally, serve it over the network, open it on my phone in Chrome, add it to my homescreen and then open the app I added to the home screen, it just opens the page in chrome (meaning e. g. that the address bar is visible). It doesn't treat it like a pwa where the address bar is not visible when you open it from your home screen.
It is only after I add
<meta name="apple-mobile-web-app-capable" content="yes">
<meta name="mobile-web-app-capable" content="yes">

to the app's index.html that it properly works like a pwa and I don't see the address bar.
Is this intended?

@tobiasfeil are you serving your app on local using https? can you check if the docs of this repo is showing the install button on the address bar (without the entries you added to the entry point)?
The install button is the first on the right side in the address bar:

on Android

@tobiasfeil if only works adding those entries, I can add them to the docs to support macos/ios.

@userquin thank you so much for the quick answer. I've tried all your suggestions, dug through the examples and done much trial and error for about 3 hours now and I've found the answer: It doesn't work when I run it with npm run dev, only if I build first and then serve e. g. with the serve command. I think it would be helpful to include this somewhere in the docs since it cost me quite some time.
For further information, the scripts section in my package.json looks like this:
"scripts": {
    "build": "vite build",
    "dev": "vite",
    "preview": "vite preview",
    "start": "npm run build && npm run serve",
    "serve": "serve dist"
  }

With npm run dev, it doesn't get served like a proper pwa (can't install on desktop and still shows the address bar on mobile), while it works with npm run start.

@tobiasfeil you shouldn't use that meta tags, check the warning here: https://web.dev/learn/pwa/web-app-manifest/#designing-your-pwa-experience
You can use the devOptions with the latest version 0.12.0, a minimal version installing the pwa on dev (only the entry point will be registered in the sw precache manifest), but the manifest will not be generated, we've a PR ready for next patch release. The devOptions is for debugging the custom sw using injectManifest on complex scenarios and so the pwa capabilities can be tested.
On development it makes no sense to add a sw that will cache everything...

Alright, thank you very much!

authors: tobiasfeil userquin


text:
Type error when using traditional defineProps

<template>

</template>

What's props.any here console.log(props.any)?

Emmm, typo
<template>

</template>

What happens if you try to separate the type instead
type ValueType = Record<string, boolean>

const props = defineProps({
  value: {
    type: Object as PropType<ValueType>,
  },
});

I have tried many way to workaround it, but it seems like the global types injection from @vue/runtime-dom can not be override by another module.
A current workaround:

Remember to use import type to remain it on type level without leaking to runtime

authors: antfu sxzz wobsoriano


text:
Update README.md

Fix typos in  README.md

Thank you for fixing this! Out of interest, how did you discover this project?

It's like in this song Anthony... ;)
(Every move you make)
(Every bond you break)
(Every step you take) I'll be watching you…

I'm a big fan, by the way. I can't wait to see this toolkit mature and potentially serve as a pre-commit hook in the future.

repo: anthony-c-martin/bicep-toolkit


text:
Lexer #69

Here's another lexer for you :)

Beautiful!

yeah big fan of how clean the implementation is

authors: HavenSelph NeeravaNraj anthonysSlab

repo: anthonysSlab/shard


text:
SDS version 2 compilation error with visual c++ compiler.

I see there is a fix for version 1 for c++ compiler. Is there anything similar for version 2?
Facing compilation issues, like below:

Am I missing something?

Old issue but if you're still wondering the problem is MSVC doesn't support that attribute syntax. You can look at the changes I made in my fork (https://github.com/LynnKirby/sds), in particular starting here.

I encountered this problem. @LynnKirby what license does your fork use? Would you consider pull requesting your fixes back to this repo?
I feel this issue should be taken seriously...

@mcclure It's the same license as the original (BSD 2-clause). I haven't bothered to pull request the changes since all the other pull requests are dead in the water.

authors: LynnKirby amod0017 mcclure

repo: antirez/sds


text:
Add initializers to ResultProtocol

Hi! I'd like to propose adding back the initializers to ResultProtocol. This will allow creation of ResultProtocol 'instances'  in contexts where it is used as a type constraint. More specifically, I would need it to be able to upgrade BrightFutures to use Result master. For example usage see, https://github.com/Thomvis/BrightFutures/blob/master/Sources/BrightFutures/MutableAsyncType+ResultType.swift#L17.
I understand these were removed in #235, as part of an effort to reduce ResultProtocol's responsibilities. I don't think I understand the reasoning behind that PR, so I apologise if I'm missing something obvious.
Thanks!

ResultProtocol has always been a workaround for Swift's incomplete generics system. It's not intended to be a protocol that types conform to—it's only meant to allow you to constrain items where Swift doesn't currently allow constraining to Result itself. Once these limitations are removed, we'll remove ResultProtocol entirely.
Having said that, I think we do need to add these back so that you constrain to a generic Result today. Thanks for the pull request!

authors: Thomvis mdiep

repo: antitypical/Result


text:
Boost

improves the execution time for certain functions

for 2000 step:
previously ---> 25 mins
this version ---> 6 mins

repo: antolonappan/marcia


text:
#93 resolution incorrect

I'm hitting this issue today and can't validate the solution in #93. I am attempting to pass multiple arguments. When I set an additional arg, it ignores the previous.
I've used the following syntax:
    - id: terraform_tflint
      args:
        - 'args=--disable-rule=terraform_deprecated_interpolation'
        - 'args=--disable-rule=aws_elasticache_cluster_previous_type'

as well as this one:
    - id: terraform_tflint
      args: ['args=--disable-rule=terraform_deprecated_interpolation', 'args=--disable-rule=aws_elasticache_cluster_previous_type']

This appears to be true based on the case statement here:
https://github.com/antonbabenko/pre-commit-terraform/blob/master/terraform_tflint.sh#L13
It overloads the args variable each loop rather than appending.
However, the solution below will work as the string is the complete list of arguments to pass. The output also matches the expected output from tflint --disable-rule=terraform_deprecated_interpolation --disable-rule=aws_elasticache_cluster_previous_type
    - id: terraform_tflint
      args: [--args=--disable-rule=terraform_deprecated_interpolation --disable-rule=aws_elasticache_cluster_previous_type]

Solution preference? Should the case statement handle that like a string (update documentation to reflect this syntax) or like an array (PR to terraform_tflint.sh)?
TIA!

I had the same issue and it took me a while to figure out what was going on.
I wanted to enable all the new rules and ended up doing this:
    - id: terraform_tflint
      args:
        - >
            --args=--enable-rule=terraform_unused_declarations
            --enable-rule=terraform_comment_syntax
            --enable-rule=terraform_documented_outputs
            --enable-rule=terraform_documented_variables
            --enable-rule=terraform_typed_variables
            --enable-rule=terraform_required_version
            --enable-rule=terraform_required_providers
            --enable-rule=terraform_naming_convention

That syntax feels a bit weird so it'd probably be better to patch the script to work as per the documentation?

It appears the originally observed behavior reverted in v1.33.0 as it now appends to the ARGS list rather than overwriting it.
Expected format is as follows:
    - id: terraform_tflint
      args:
        - 'args=--disable-rule=terraform_deprecated_interpolation'
        - 'args=--disable-rule=aws_elasticache_cluster_previous_type'

authors: ctodd-cb ouranos

repo: antonbabenko/pre-commit-terraform


text:
Add ext prefix for non-default entries of external modules

Spied on: https://github.com/sindresorhus/eslint-plugin-unicorn/issues/1194
import foo from 'module/path/to/file.js';

:tada: This issue has been resolved in version 1.1.2 :tada:
The release is available on:

v1.1.2
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 2.1.0 :tada:
The release is available on:

v2.1.0
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


text:
Error on config read on standard readme execution

Hello there, i was playing around trying the "template" and got two different problems in Debian.
First, with current trunk state following standard readme instructions i got:
'/bin/sh -c go mod download' returned a non-zero code: 1. during docker build  .  -t api-rest
Secondly, i bypassed previous 'dependecy' problem updating to latest alpine image version
on Dockerfile:  golang:1.15.3-alpine3.12
after that, all goes smoothly until you get execution error
can't read cofig file './cmd/api/config.yml'
May you have a look?

I just fixed the error in the last commit. Check that it works well for you.

Antonio sé que es bastante tarde (porque se me olvidó responder) pero gracias por mirarlo
en su momento! Me sirvió!
Ahora ando retomando un poco Go (suelo trabajar con Java y Python) y estaba mirando
mis cosas y por eso volví a ver ésto jaja
Un saludo y gracias!


text:
allow @ character in lexer

fixes https://github.com/argoproj/argo-workflows/issues/8734

Foo[“bar@“]

@antonmedv "workflow.parameters.message.@fromstr.Records.0.s3.object.key" does not work, the @ is needed for gjson lib

Don’t know what it means.

case r == '@':
	l.backup()
	return identifier

I think adding that in https://github.com/antonmedv/expr/blob/baae791a9321e8570785ea18814d0697057b2a00/parser/lexer/state.go#L47 will fix it

I don’t see a problem. Why expr should support it?

repo: antonmedv/expr


text:
Payday 2 Access Violation crash, script stack involves GSI and BeardLib.

So, I was just playing Payday 2, and in the middle of the heist, the game crashed. Now, Payday 2 crashing is not unusual for me as of late, but I thought it would be worth mentioning that the Game State Integration mod that is required seems to have had a role in the crash.
Application has crashed: access violation

-------------------------------

Callstack:

         payday2_win32_release  (???)     ???
         payday2_win32_release  (???)     ???
         payday2_win32_release  (???)     ???
         payday2_win32_release  (???)     ???
         payday2_win32_release  (???)     ???
         payday2_win32_release  (???)     ???
         payday2_win32_release  (???)     ???
         payday2_win32_release  (???)     ???
         payday2_win32_release  (???)     ???
         payday2_win32_release  (???)     ???
         payday2_win32_release  (???)     ???

-------------------------------

Current thread: Main
Script stack:
               custom_encode()  @mods/BeardLib/Classes/json_utils.lua:79
               custom_encode()  @mods/BeardLib/Classes/json_utils.lua:79
               custom_encode()  @mods/BeardLib/Classes/json_utils.lua:79
                 SendMessage()  @mods/GSI/Classes/GSICommunicator.lua:62
                      update()  @mods/GSI/Classes/GSICommunicator.lua:45
                        func()  @mods/GSI/GSICore.lua:131
                        Call()  @mods/base/req/hooks.lua:107
                      update()  @mods/base/lua/GameSetup.lua:6
                      update()  lib/setups/networkgamesetup.lua:21
                                core/lib/setups/coresetup.lua:529
                            ()  =(tail
                      call):-1
-------------------------------

System information:
    Application version : 1.55.17
    CPU : Intel(R) Core(TM) i7-4810MQ CPU @ 2.80GHz (2 cores); SSE; SSE2; SSE3; SSSE3; SSE4.1; SSE4.2
    DirectX : 12.0
    GPU : NVIDIA GeForce GTX 870M / nvd3dum.dll[21.21.13.7290]
    Language : @ID94cca2fdaccfc2cd@
    Memory :     12206MB 716KB
    OS : 6.2.9200 () 0x300-0x1 (64 bits)
    Physics : threaded
    Renderer : DX9 threaded
    Sound : Corsair (Headset Earphone (2- Corsair VOID RGB Wireless Gaming Headset))

Seeing as the GSI mod is required for Aurora's Payday 2 functionality, I thought it would be worth taking a look at.

This issue is not directly related to Aurora. The Payday 2 GSI mod is required for Aurora's lighting to work for PD2, but an issue with the GSI mod or BeardLib should be posted on the GSI repo or the BeardLib repo.

repo: antonpup/Aurora


text:
Unit test no coverage when no ci flag

Remove unused old env model file
Test

Faster re-run tests
Also fix bad sourcemap when debugging (the inline-source-map seems to only work for coverage alone), now use inline-source-map for CI, and source-map for non-CI

Toggle CI flag by:
# Will produce coverage
npm t -- --ci

# Will not produce coverage, but is faster on re-run
npm t

Coverage remained the same at 100.0% when pulling c7f6611518e88f2f44f4357b7d489a9c62799b0c on refactor into 28ffd6924d432f16521f513724f874045a39cbeb on master.

Coverage remained the same at 100.0% when pulling a7b2ac3b1ce9abc170c5af341d09048ce85a0b94 on refactor into 28ffd6924d432f16521f513724f874045a39cbeb on master.

authors: antonybudianto coveralls

repo: antonybudianto/angular-webpack-starter


text:
Update CNI binaries version to v1.4.1

CVE scanners are currently flagging CVE-2023-45288 (HIGH) in the antrea-agent image, because of the CNI plugin binaries. We bump up the version to v1.4.1 to avoid the warnings from CVE scanners.

No need to backport, as the CVE does not impact Antrea. We ship the following CNI plugins: bandwidth, host-local, loopback, portmap. None of these run an HTTP server.
Another note of interest: the original binaries for 1.4.1 were build with go1.21.7 and were "affected" by the CVE. However, the binaries were rebuilt recently with a more recent go version (go1.22.3) and are no longer "affected". See https://github.com/containernetworking/plugins/issues/1038. This is not ideal because release artifacts should be immutable, but using the new binaries should not negatively impact us.

Depends on https://github.com/antrea-io/antrea/pull/6337

/test-all

repo: antrea-io/antrea


text:
交互

WIP

交互已经根据按照 4.0 以及山大的交互语法实现了一版，但目前还存在一些问题，这里对交互语法进行修改，目的是解决这些问题。
存在问题

声明交互的方式和传统声明交互的方式差别太大。
Action 的拆分没有在易用性和复用性找到合适的平衡。

开始
这里用高亮交互举例子。
const options = {
  interactions: [{ type: 'highlight', stroke: 'red' }],
}

有以下实现方式：
// 交互语法
// API 形式
chart.observe('plot:pointermove')
  .pipe({ type: 'selectElements' })
  .subscribe({ type: 'highlightSelectedElements' })

// Spec 形式
const options = {
  observe: [
    {
      event: 'plot:pointermove',
      pipe: [{ type: 'selectElements' }],
      subscribe: [{ type: 'highlightSelectedElements' }],
    },
  ],
};

设计
API 形式的设计参考了 RXJS，一种声明形式处理事件的方式。

Think of RxJS as Lodash for events.

let count = 0;
const rate = 1000;
let lastClick = Date.now() - rate;
document.addEventListener('click', (event) => {
  if (Date.now() - lastClick >= rate) {
    count += event.clientX;
    console.log(count);
    lastClick = Date.now();
  }
});

import { fromEvent, throttleTime, map, scan } from 'rxjs';

fromEvent(document, 'click')
  .pipe(
    throttleTime(1000),
    map((event) => event.clientX),
    scan((count, clientX) => count + clientX, 0)
  )
  .subscribe((count) => console.log(count));

我大概描述下之前结合山大交互语法的大概想法

交互发生触发反馈有两种路径：

路径1（蓝色）

反馈1：根据事件获取交互要操作的一些对象，存储在 context 的共享变量中
反馈2：拿到context 共享变量的信息操作这些交互对象

路径2（绿色）

无需获取交互操作对象，事件本身就决定了要直接去执行一些变更(包括操作对象)，如：filter、rerender 等

Action 反馈，本质上也是函数，有明确的通途、输入、输出（只不过输入从 context 获取、输出是操作 context）

Q: 如果就是想用函数的写法，怎么做?
A: 支持函数方式写 action 反馈，而不是一定要类似 4.0 继承 Action 类去写一个自定义反馈.
Q: 如果想要复用 Action 怎么办?
A: 方式1: 自己抽取为通用 util, 跨文件复用. 方式2: 将自定义的 Action 注册一个名字, 然后和之前一样复用.

弊端: Action 拆分没有标准，有的时候过于细化了
内置 ElementActive
// 伪代码

// GetElements action: 出参是 shared.elements
const GetElements = (options: { elements }) => {
  return (context) => {
    // 这里可以通过任何方式去获取
    context.shared.elements = elements || [...]
  }
}

// ActiveElement action: 入参是 shared.elements
const ActiveElement = (options: { fill }) => {
  return (context) => {
    const elements = context.shared.elements;
    elements.forEach(ele => ele.style.fill = fill)
  }
}
// 注册为 library, 可以通过指定 action type 获取.
const ElementActive = () => {
  start: [
    { trigger: 'mouseenter', action: [{ type: 'getElements' }, { type: 'activeElement' }] },
  ],
  end: [
    //
    { trigger: 'mouseleave', action: [{ type: 'getElements', elements: [] }, { type: 'activeElement' }] },
  ]
}

复写 ElementActive
const CustomGetElements = () => {
  return (context) => {
    // 监听外部 div 块的激活情况, 获取 id
    context.shared.elements = plot.querySelectorAll(`.element#${id}`);
  }
}
const CustomElementActive = () => {
  start: [
    { trigger: 'mouseenter', action: [{ type: CustomGetElements }, { type: 'activeElement' }] },
  ],
  end: [
    //
    { trigger: 'mouseleave', action: [{ type: CustomGetElements }, { type: 'activeElement' }] },
  ]
}

转入到 discussion 吧~

好

转到 Discussions：https://github.com/antvis/G2/discussions/4388

authors: hustcc pearmini visiky


text:
请问下，怎么在节点里显示类似于echarts中的折线图这种的图表呢？

G6 Version:
Platform:
Mini Showcase(like screenshots):
CodePen Link:

是否可以考虑增加在节点上显示类似于echarts或者g2这种的图表的示例？如折线图，柱状图。官方示例中有提供图表的，但是和需求差异较大？是否需要使用自定义的dom节点来实现，具体怎么实现？

目前只能使用官网示例的方式，自定义节点，根据数据添加各种图形来绘制一个统计图表。

使用dom节点的方式，可以在初始化节点的时候显示出来echarts图表，节点也有设置 draggable: true，但是拖动节点时，会将自定义的dom节点里的echarts图表删掉，查看element元素，echarts的canvas元素整个都被删除了，这是因为g6的设计实现里，有对canvas的特殊处理么？

目前没有提供这个功能，年底可能会做和 AntV G2 的打通，到时候应该能够支持用 G2 的图表作为节点。
现在建议类似 demo：https://g6.antv.vision/zh/examples/item/customNode#barChart 这样用 canvas 模式下自定义节点添加图形自己画一个图表。
当然，我们非常欢迎社区 PR 🤩

目前没有提供这个功能，年底可能会做和 AntV G2 的打通，到时候应该能够支持用 G2 的图表作为节点。
现在建议类似 demo：https://g6.antv.vision/zh/examples/item/customNode#barChart 这样用 canvas 模式下自定义节点添加图形自己画一个图表。
当然，我们非常欢迎社区 PR 🤩

好的，我在研究下看看

目前没有提供这个功能，年底可能会做和 AntV G2 的打通，到时候应该能够支持用 G2 的图表作为节点。
现在建议类似 demo：https://g6.antv.vision/zh/examples/item/customNode#barChart 这样用 canvas 模式下自定义节点添加图形自己画一个图表。
当然，我们非常欢迎社区 PR 🤩

好的，我在研究下看看

不好意思，忘记问一个事情，目前节点的anchorPoints，支持在节点内部么？我看现在的节点上的anchor都在节点的边上。

anchorPoints 可以任意位置 https://g6.antv.vision/zh/docs/manual/middle/elements/anchorpoint
linkPoints 默认是在边缘上，自定义节点可以画小圆形到任意位置


text:
changeData更新视图后监听的时机事件

问题描述
图没有使用布局layout，完全自定义，如果用changeData去更新视图的话，想在画布元素渲染完成后执行方法，应该监听哪个时机事件呢，因为没有使用布局，afterlayout无法使用，afterrender只会触发一次，求指导
重现链接
无
重现步骤
无
预期行为
能够监听changeData更新视图后渲染完成的事件
平台

操作系统: [macOS, Windows, Linux, React Native ...]
网页浏览器: [Google Chrome, Safari, Firefox]
G6 版本: [4.5.1 ... ]

屏幕截图或视频（可选）
No response
补充说明（可选）
No response

有一个 afterchangedata 事件，文档上好像漏了，我补充一下


text:
🙏tooltip不延迟，默认的hoverFocus，出现的toolTip为800ms，有一定延迟，希望有配置不延迟的能力

🖋 Description
tooltip不延迟，默认的hoverFocus，出现的toolTip为800ms，有一定延迟，希望有配置不延迟的能力
🏞 What problem does this feature solve
tooltip延迟出现，有顿感
🧐 Suggest the API

name
type
default
description

tooltipDelay
number
800
toolTip出现的延迟时间(ms)

hoverFocus 是设计师专门设计的效果，我理解你是想要 鼠标 hover 数值单元格的时候出现 tooltip，hoverFocus 不是干这个事情的, 建议通过自定义交互来实现 https://s2.antv.vision/zh/examples/interaction/custom#row-col-hover-tooltip

:tada: This issue has been resolved in version @antv/s2-v1.15.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version @antv/s2-react-v1.14.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


text:
如果要 删除节点，除了用“button-remove” 的节点工具，还有其他方法可以调用吗？

如上，看文档看了很久也没有发现有实际的介绍

emmmm，最后我用了画布的removeCells方法


text:
期望提供隐藏节点的能力

功能描述
希望能提供隐藏节点或边的能力，而不是删除
期望解决方案
希望能提供隐藏节点或边的能力，而不是删除

可以先这样实现，2.0 版本会提供这个能力。
const view = graph.findViewByCell(node)
view.container.style.display = 'none'

可以通过cell.hide();这个方法来隐藏节点/边，不知道这是不是你想要的效果。

@Trojanpa 这里的隐藏会将节点从画布删除。

authors: NewByVector Trojanpa lhbvita


text:
折线图只有单个点的时候，tooltip不出来

G2 Version:  3.0.1
Platform:  mac chrome
Mini Showcase(like screenshots):

祯老板，你的数据是怎么样的？我试了一下貌似是可以出来的，我的数据是：
  const data = [
    { month: 'Jan' , Tokyo: null , London: null } ,
    { month: 'Feb' , Tokyo: null , London: null } ,
    { month: 'Mar' , Tokyo: null , London: null } ,
    { month: 'Apr' , Tokyo: null , London: null } ,
    { month: 'May' , Tokyo: null , London: null } ,
    { month: 'Jun' , Tokyo: null , London: null } ,
    { month: 'Jul' , Tokyo: null , London: null } ,
    { month: 'Aug' , Tokyo: null , London: null } ,
    { month: 'Sep' , Tokyo: null , London: null } ,
    { month: 'Oct' , Tokyo: null , London: null } ,
    { month: 'Nov' , Tokyo: null , London: null } ,
    { month: 'Dec' , Tokyo: 9.6  , London: 4.8  }
  ];

authors: ajsdhf leungwensen


text:
微信小程序 tooltip 无法更改显示个数

F2 Version:  @antv/f2-canvas": "^1.0.5"
Platform:  微信小程序依赖库 2.5
Mini Showcase(like screenshots):
CodePen Link:

问题：  chart.tooltip 点击一直显示3个数据

代码如下
`let chart = null
function initChart(canvas, width, height, F2) {
const data = [{
"date": '2018-11',
"price": 2688
}, {
"date": '2018-12',
"price": 2550
}, {
"date": '2019-01',
"price": 2230
}, {
"date": '2019-02',
"price": 2100
}, {
"date": '2019-03',
"price": 3500
}]
chart = new F2.Chart({
el: canvas,
width,
height
});
chart.source(data)
chart.axis('date', {
line: {
lineWidth: 1,
stroke: '#8CEAB4',
top: false
},
tickLine: null
});
chart.axis('price', false)
// tooltip 与图例结合
chart.tooltip({
    // custom: true, // 自定义 tooltip 内容框
    showItemMarker: false,
    background: {
        radius: 2,
        fill: '#02ad63',
        padding: [3, 5]
    },
    tooltipMarkerStyle: {
        fill: '#1890FF',
        fillOpacity: 0.1
    },
    onShow(ev) {
        console.log(ev, "ev")
        const { items } = ev;
        items[0].name = null;
        items[0].name = items[0].title;
        items[0].value = '¥ ' + items[0].value;
       console.log(items[0].value, " items[0].value")
    }
})
chart.line()
    .position('date*price')
    .color('l(0) 0:#4dd060 0.5:#98e278 1:#EEF693')
    .shape('smooth')
    .style({
        lineWidth: 4
    })
chart.area()
    .position('date*price')
    .color('l(270) 0:#FFFFFF 1:#52D261')
    .shape('smooth');

chart.point().position('date*price')
    .color('rgba(47,224,156,1)')
    .size(5)
    .style({
        stroke: '#fff',
        lineWidth: 2
    })
chart.render()
return chart

}`

加这一段代码就行
chart.tooltip({
    onShow: function onShow(ev) {
      return (ev.items = ev.items.slice(0,-1));
    },
  });

你好，请问这个问题解决了嘛？我也遇到了，如解决了，麻烦说一下解决办法，谢谢 @XiaoLiz

authors: Dreamwht XiaoLiz lxx2013


text:
An Unknown Exception occurred. Please contact developer.

I'm getting this error. Idk how to proceed.

Please add the line  print(e) after line number 50 in core.py and share the printed message.

I got this:
Expecting value: line 1 column 1 (char 0)

Please share your updated code.

authors: anuragrana tobeyond

repo: anuragrana/py-instagram-dl


text:
Make community chat page responsive

Make community chat page responsive.

assigned 👍

#2321

authors: RitiChandak Taniishaaa huamanraj


text:
genre for comedy

Related Issue
Fixes:  #2434
Description
New genre for comedy added
Type of PR

[ ] Bug fix
[ ] Feature enhancement
[X] Documentation update
[ ] Other (specify): _______________

Checklist:

[X] I have made this change from my own.
[X] I have taken help from some online resources.
[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] I have made corresponding changes to the documentation.
[X] My changes generate no new warnings.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers and screenshots after making the changes.

Conflicting files
assets/html/index.html


text:
fix: type-check to disallow call to unsafe_get_pauli() with non-Pauli gates

Closes #243

This is ready to merge once CI/CD passes.

authors: fSosaRey plerouxanyon


text:
CMA-ES save algorithm with pickle

Description
pickle can not save algorithm.es because it is a <generator object my_fmin at ...>
So if the CMAES algorithm is loaded again, es is missing and continuing the optimization with this algorithm is not possible.
Error: AttributeError: 'CMAES' object has no attribute 'es'
Example Code
import pickle
import numpy as np
from pymoo.algorithms.soo.nonconvex.cmaes import CMAES
from pymoo.problems import get_problem
from pymoo.optimize import minimize
from pymoo.termination import get_termination

algorithm = CMAES()
res = minimize(get_problem("sphere"), algorithm, ('n_gen', 3), verbose=True)
# save algorithm object
with open('pymoo_alg.pkl', 'wb') as f:
    pickle.dump(res.algorithm, f)
with open('pymoo_alg.pkl', 'rb') as f:
    alg = pickle.load(f)

# continue optimization run
# alg = res.algorithm  # uncomment to use original algorithm
print("new termination")
alg.termination = get_termination('n_gen', 40)
while alg.has_next():
    alg.next()

same error occurs, when making a copy of the algorithm
algorithm = CMAES()
alg = copy.deepcopy(algorithm)
alg.es → Error: 'CMAES' object has no attribute 'es'

CMAES can not be pickled because it uses a generator. This is how the original implementation has been incorporated into pymoo. I have not found an easy solution for this issue. Let me know if you now one or have even found one by now.

repo: anyoptimization/pymoo


text:
Linter for sysl files

Sysl should have its own linter and our sysl ci should fail while trying to checkin sysl files that don’t match its rules.
Rules should at least cover the following cases:

mixed tabs and spaces
inconsistent indent
duplicate attributes in single line
extra spaces at eol

Should we just disallow tabs at the parser level? No one actually uses them.
I was thinking of even requiring 4-space indents. I'm not as confident of this one, but it's worth discussing.

duplicate attributes in single line
What about duplicate attributes, period?

extra spaces at eol

This is another candidate for outright banning at the parser.

authors: anzdaddy sahejsingh

repo: anz-bank/sysl


text:
fix: setTimeout

fixes setTimeout not triggering
rewrites timeout class
removes pulse (was broken, can reimplement if asked to (even though its pretty useless))
resolves #590

Should be kept if it still a method even if useless or not it should be there.


text:
Add Yoneda and CoYoneda types

CoYoneda can be used to avoid the need to create a functor instance for types used with Free.

Released in 2.0.0-FINAL

repo: aol/cyclops-react


text:
How can i feedback the sonarqube report to gitlab and refer to the relative issue ?

i use drone to implement my ci process. but this plugin seems a little weak. Can it do this function ?

What you are referring to is known as PR decoration/Branch Decoration you need to get Sonarqube developer+. Or Community Decoration. This only works with git hosts that are supported by Sonarqube i.e Gitlab, Github ... etc.

repo: aosapps/drone-sonar-plugin


text:
Fixing lint in local or Github Action?

The #25 changes add an Action (https://github.com/apa-developer/apa-ui/pull/25/commits/baab16622d5f2afdd2a16c8f13069c1ba508d872) that will fix lint error(s) on pull request by the Action worker. However the #36 changes added scripts about lint that will run in local commit process. It seems redundant. What you guys preferred?

The reason i have both local linting (via Husky) and GitHub Actions linting is to ensure a robust workflow:

Local linting: Gives quick feedback during the commit process and helps reduce back-and-forth on pull requests by catching errors early.
GitHub Actions linting: Acts as a safety net and ensures consistency across all pull requests, especially useful for contributors who might bypass or misconfigure local linting.

However, if you or anyone in the community have concerns or suggestions, i'm open to discussing and improving the workflow

I acknowledge that automatic lint:fix and commit in Actions might feel redundant. I suggest to adjusting Actions to validate linting without modifying the code.

dear @kimmyxpow,
lah
best regards, zain🍕

authors: kimmyxpow sensasi-delight

repo: apa-developer/apa-ui


text:
restore exception handling #949 #1005

This change restores the exception handling in TabletServerLogger to the way it was before the changes in #1005.  This changes makes TabletServerGivesUpIT pass.

@keith-turner Is this intended to block 1.9.3 or should that be labeled 1.9.4? (In other words, are you voting -1 on the 1.9.3 RC1 for this issue?)

@ctubbsii I voted -1 on 1.9.3 RC1 because of this issue.

authors: ctubbsii keith-turner

repo: apache/accumulo


text:
ARTEMIS-1343 Update Configuring Transports Documentation

Updated to reflect deprecated properties.
Add a new section to cover native transport support (epoll and kqueue) added over the past few releases.

@clebertsuconic this is to support the original epoll work, we forgot to document, and obviously the new kqueue bits.

repo: apache/activemq-artemis


text:
AMBARI-24132. Manage Config groups option is missing in add service w…

…izard
What changes were proposed in this pull request?
Manage Config groups option is missing in add service wizard
How was this patch tested?
Manually
Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2756/
Test FAILed.
Test FAILured.

authors: asfgit hiveww

repo: apache/ambari


text:
[AMBARI-24351] Using Predicate based evaluation when determining if SSO is enabled for a service

What changes were proposed in this pull request?
Instead of using a single boolean flag to decide if SSO is enabled or not we use a predicate based approach (see detailed explanation in the JIRA).
How was this patch tested?
In addition to uni testing I executed several manual tests in a local cluster using various types of predicates: and, or, equals, contains

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3321/
Test FAILed.
Test FAILured.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3338/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3339/
Test FAILed.
Test FAILured.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3341/
Test FAILed.
Test FAILured.

retest this please


text:
AMBARI-24297. Show full JDBC URL's for Hive

What changes were proposed in this pull request?
Show full JDBC URL's for Hive
How was this patch tested?
manually
Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3425/
Test PASSed.


text:
AMBARI-23289. Add SSO integration support information to service information via Ambari's REST API (amagyar)

What changes were proposed in this pull request?
SSO related information (enabled, supported, desired) was added to the REST output of stack services and installed services.
Fields are calculated as follows:

supported comes from service metainfo (<sso><supported>true</supported>)
desired comes from ambari configuration called ambari.sso.enabled_services
enabled comes from service config where the config-type/property-name comes from service metainfo.

How was this patch tested?
Manually updated metainfo.xml of an existing service
    <service>
      <name>ZOOKEEPER</name>
      <version>3.4.6</version>
        <sso>
             <supported>true</supported>
             <enabledConfiguration>zoo.cfg/my-sso</enabledConfiguration>
        </sso>
    </service>

used the following curl command to update ambari.sso.enabled_services.
$ curl -i -v -uadmin:admin -H "X-Requested-By: ambari" -X POST --data @sso-conf.json  http://c7401:8080/api/v1/services/AMBARI/components/AMBARI_SERVER/configurations

$ sso-conf.json

{
  "Configuration": {
    "category" : "sso-configuration",
    "properties": {
        "ambari.sso.enabled_services": "ZOOKEEPER"
     }
  }
}

Checked the outout of REST API calls like:

/api/v1/stacks/HDP/versions/2.6/services/ZOOKEEPER
/api/v1/clusters/cluster18/services/ZOOKEEPER

cc: @smolnar82

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1274/
Test FAILed.
Test FAILured.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1303/
Test FAILed.
Test FAILured.

1416589 [ERROR] Tests run: 9, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 54.295 s <<< FAILURE! - in org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProviderTest
1416589 [ERROR] org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProviderTest  Time elapsed: 2.121 s  <<< ERROR!
java.io.FileNotFoundException: /tmp/server-work-AmbariLdapAuthenticationProviderTest/log/revision (No such file or directory)

retest this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1349/
Test FAILed.
Test FAILured.

test failures is not related to this change

authors: asfgit smolnar82 zeroflag


text:
[Improvement] Remove aws bundle dependencies from ams bin

Why are the changes needed?

Exclude aws bundles from hadoop-aws, we have declared the dependencies of AWS separately.
Brief change log

Exclude aws bundles from hadoop-aws

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

I ran the quickstart with minio and it worked fine.

Thanks for the review. @zhouxinyu @XBaith

repo: apache/amoro


text:
docs: fix server-secret.yaml link in mtls.md (v1.5.0)

Type of change:

[ ] Bugfix
[ ] New feature provided
[ ] Improve performance
[ ] Backport patches

What this PR does / why we need it:

Fix server-secret.yaml link in mtls.md. Fixing part of #1430. (v1.5.0 branch)
Pre-submission checklist:

[x] Did you explain what problem does this PR solve? Or what new features have been added?
[ ] Have you added corresponding test cases?
[x] Have you modified the corresponding document?
[x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

The CI failure is irrelevant

authors: SkyeYoung lingsamuel

repo: apache/apisix-ingress-controller


text:
blog: add Apache APISIX 3.4.0 release notes

feat: release APISIX 3.4.0: https://github.com/apache/apisix/pull/9730
est. release on June 30, 2023
https://github.com/apache/apisix/blob/master/CHANGELOG.md

LGTM, please fix lint.

repo: apache/apisix-website


text:
Build Python wheels for Mac ARM architecture (e.g. M1)

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We only build Python wheels for Mac with x86_64 architecture, so we cannot support newer macs with M1 chip or later
Describe the solution you'd like
Build wheels for Mac arm architecture
Describe alternatives you've considered
None
Additional context
None

An example for building these types of wheels on GHA: https://github.com/pola-rs/polars/blob/a1afbc4b78f5850314351f7e85ded95fd68b6453/.github/workflows/create-python-release.yaml#L37-L61

authors: andygrove isidentical

repo: apache/arrow-datafusion-python