text:
port bug: ogre error

-- Package x86-windows-rel
CMake Error at E:/tools/vcpkg/scripts/cmake/vcpkg_execute_required_process.cmake:43 (message):
    Command failed: C:/Program Files/CMake/bin/cmake.exe;--build;.;--config;Release;--target;install;--;/p:VCPkgLocalAppDataDisabled=true;/p:UseIntelMKL=No;/m
    Working Directory: E:/tools/vcpkg/buildtrees/ogre/x86-windows-rel
    See logs for more information:
      E:\tools\vcpkg\buildtrees\ogre\package-x86-windows-rel-out.log
      E:\tools\vcpkg\buildtrees\ogre\package-x86-windows-rel-err.log

Call Stack (most recent call first):
  E:/tools/vcpkg/scripts/cmake/vcpkg_install_cmake.cmake:49 (vcpkg_execute_required_process)
  E:/tools/vcpkg/ports/ogre/portfile.cmake:42 (vcpkg_install_cmake)
  E:/tools/vcpkg/scripts/ports.cmake:73 (include)

[DEBUG] _wspawnlpe() returned 1
Error: Building package ogre:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: ogre:x86-windows
  Vcpkg version: 0.0.81-548ff8d3db47e83ebecc5b57dcbd63723cee7546-external

Additionally, attach any relevant sections from the log files above.
[DEBUG] ..\src\commands_install.cpp(399)

file empty - E:\tools\vcpkg\buildtrees\ogre\package-x86-windows-rel-err.log
file E:\tools\vcpkg\buildtrees\ogre\package-x86-windows-rel-out.log
-- Found DirectX11: C:/Program Files (x86)/Windows Kits/10/Lib/10.0.15063.0/um/x86/d3d11.lib
-- Looking for Cg...
-- Cg_PREFIX_PATH changed.
-- Could NOT find PkgConfig (missing:  PKG_CONFIG_EXECUTABLE)
-- Could not locate Cg

# Try to find nVidia's Cg compiler, runtime libraries, and include path.
# Once done this will define
#
# CG_FOUND        - system has NVidia Cg and it can be used.
# CG_INCLUDE_PATH = directory where cg.h resides
# CG_LIBRARY = full path to libCg.so (Cg.DLL on win32)
# CG_GL_LIBRARY = full path to libCgGL.so (CgGL.dll on win32)
# CG_COMPILER = full path to cgc (cgc.exe on win32)

the dependence of
https://developer.nvidia.com/cg-toolkit-download

ok, install Cg compiler
???
-- Could NOT find PkgConfig (missing:  PKG_CONFIG_EXECUTABLE)
-- Could NOT find TinyXML (missing:  TINYXML_INCLUDE_DIR TINYXML_LIBRARIES)
и т.д.
-- The C compiler identification is MSVC 19.11.25303.0
-- The CXX compiler identification is MSVC 19.11.25303.0
-- Configuring OGRE 1.9.0
-- Check size of void*
-- Check size of void* - done
-- Search path: E:/tools/vcpkg/buildtrees/ogre/x86-windows-rel/Dependencies;E:/tools/vcpkg/buildtrees/ogre/src/sinbad-ogre-dd30349ea667/Dependencies;E:/tools/vcpkg/buildtrees/ogre/x86-windows-rel/../Dependencies;E:/tools/vcpkg/buildtrees/ogre/src/sinbad-ogre-dd30349ea667/../Dependencies
-- Looking for ZLIB...
-- Could NOT find PkgConfig (missing:  PKG_CONFIG_EXECUTABLE)
-- Found ZLIB: optimized;E:/tools/vcpkg/installed/x86-windows/lib/zlib.lib;debug;E:/tools/vcpkg/installed/x86-windows/lib/zlib.lib
-- Looking for ZZip...
-- Could NOT find PkgConfig (missing:  PKG_CONFIG_EXECUTABLE)
-- Found ZZip: optimized;E:/tools/vcpkg/installed/x86-windows/lib/zziplib.lib;debug;E:/tools/vcpkg/installed/x86-windows/lib/zziplib.lib
-- Looking for FreeImage...
-- Could NOT find PkgConfig (missing:  PKG_CONFIG_EXECUTABLE)
-- Found FreeImage: optimized;E:/tools/vcpkg/installed/x86-windows/lib/FreeImage.lib;debug;E:/tools/vcpkg/installed/x86-windows/lib/FreeImage.lib
-- Looking for FREETYPE...
-- Could NOT find PkgConfig (missing:  PKG_CONFIG_EXECUTABLE)
-- CMAKE_PREFIX_PATH: E:/tools/vcpkg/buildtrees/ogre/x86-windows-rel/Dependencies;E:/tools/vcpkg/buildtrees/ogre/src/sinbad-ogre-dd30349ea667/Dependencies;E:/tools/vcpkg/buildtrees/ogre/x86-windows-rel/../Dependencies;E:/tools/vcpkg/buildtrees/ogre/src/sinbad-ogre-dd30349ea667/../Dependencies;E:/tools/vcpkg/installed/x86-windows
-- CMAKE_PREFIX_PATH: E:/tools/vcpkg/buildtrees/ogre/x86-windows-rel/Dependencies;E:/tools/vcpkg/buildtrees/ogre/src/sinbad-ogre-dd30349ea667/Dependencies;E:/tools/vcpkg/buildtrees/ogre/x86-windows-rel/../Dependencies;E:/tools/vcpkg/buildtrees/ogre/src/sinbad-ogre-dd30349ea667/../Dependencies;E:/tools/vcpkg/installed/x86-windows
-- Found FREETYPE: optimized;E:/tools/vcpkg/installed/x86-windows/lib/freetype.lib;debug;E:/tools/vcpkg/installed/x86-windows/lib/freetype.lib
-- Found OpenGL: opengl32
-- Looking for DirectX9...
-- DirectX9_PREFIX_PATH changed.
-- Found DirectX9: C:/Program Files (x86)/Windows Kits/10/Lib/10.0.15063.0/um/x86/d3d9.lib
-- Looking for DirectX11...
-- DirectX11_PREFIX_PATH changed.
-- Found DirectX11: C:/Program Files (x86)/Windows Kits/10/Lib/10.0.15063.0/um/x86/d3d11.lib
-- Looking for Cg...
-- Cg_PREFIX_PATH changed.
-- Could NOT find PkgConfig (missing:  PKG_CONFIG_EXECUTABLE)
-- Could not locate Cg
-- Looking for POCO...
-- Could NOT find PkgConfig (missing:  PKG_CONFIG_EXECUTABLE)
-- Could not locate POCO
-- Looking for TBB...
-- Found TBB: optimized;E:/tools/vcpkg/installed/x86-windows/lib/tbb.lib;debug;E:/tools/vcpkg/installed/x86-windows/lib/tbb.lib
-- Looking for TBB_MALLOC...
-- Found TBB_MALLOC: optimized;E:/tools/vcpkg/installed/x86-windows/lib/tbbmalloc.lib;debug;E:/tools/vcpkg/installed/x86-windows/lib/tbbmalloc.lib
-- Looking for TBB_MALLOC_PROXY...
-- Found TBB_MALLOC_PROXY: optimized;E:/tools/vcpkg/installed/x86-windows/lib/tbbmalloc_proxy.lib;debug;E:/tools/vcpkg/installed/x86-windows/lib/tbbmalloc_proxy.lib
-- Looking for GLSL_Optimizer...
-- GLSL_Optimizer_PREFIX_PATH changed.
-- Could NOT find PkgConfig (missing:  PKG_CONFIG_EXECUTABLE)
-- Could not locate GLSL_Optimizer
-- Looking for HLSL2GLSL...
-- HLSL2GLSL_PREFIX_PATH changed.
-- Could NOT find PkgConfig (missing:  PKG_CONFIG_EXECUTABLE)
-- Could not locate HLSL2GLSL
-- Looking for OIS...
-- OIS_PREFIX_PATH changed.
-- Could NOT find PkgConfig (missing:  PKG_CONFIG_EXECUTABLE)
-- Could not locate OIS
-- Found Doxygen: E:/tools/doxygen/bin/doxygen.exe
-- Looking for Softimage...
-- Softimage_PREFIX_PATH changed.
-- Could not locate Softimage
-- Could NOT find TinyXML (missing:  TINYXML_INCLUDE_DIR TINYXML_LIBRARIES)
-- Looking for CppUnit...
-- Could NOT find PkgConfig (missing:  PKG_CONFIG_EXECUTABLE)
-- Could not locate CppUnit
--
-----------------------------------------------------------------------------
-- The following external packages were located on your system.
-- This installation will have the extra features provided by these packages.
+ zlib
+ zziplib
+ freeimage
+ freetype
+ OpenGL
+ OpenGL 3+
+ OpenGL ES 1.x
+ OpenGL ES 2.x
+ OpenGL ES 3.x
+ DirectX9
+ DirectX11
+ boost
+ boost-thread
+ boost-date_time
+ boost-system
+ boost-chrono
+ boost-atomic
+ tbb
+ Doxygen
-----------------------------------------------------------------------------
-- The following OPTIONAL packages could NOT be located on your system.
-- Consider installing them to enable more features from this software.
+ cg: C for graphics shader language <http://developer.nvidia.com/object/cg_toolkit.html>
+ POCO: POCO framework <http://pocoproject.org/>
+ GLSL Optimizer: GLSL Optimizer <http://github.com/aras-p/glsl-optimizer/>
+ HLSL2GLSL: HLSL2GLSL <http://hlsl2glslfork.googlecode.com/>
+ OIS: Input library needed for the samples <http://sourceforge.net/projects/wgois>
+ Softimage: Softimage SDK needed for building XSIExporter <FALSE>
+ TinyXML: TinyXML needed for building OgreXMLConverter <FALSE>
+ CppUnit: Library for performing unit tests <http://cppunit.sourceforge.net>
-----------------------------------------------------------------------------

-- Could not find dependency: OIS
-- Skipping samples build
--
----------------------------------------------------------------------------
  FEATURE SUMMARY
----------------------------------------------------------------------------

Building components:
  + Paging
  + Property
  + Terrain
  + RTShader System
  + RTShader System Core Shaders
  + RTShader System Extensions Shaders
  + Volume
  + Overlay
Building plugins:
  + BSP scene manager
  + Octree scene manager
  + Portal connected zone scene manager
  + Particle FX
Building rendersystems:
  + Direct3D 11
  + OpenGL
Building executables:
  + Samples
Building core features:
  + DDS image codec
  + FreeImage codec
  + ZIP archives

Build type:                      dynamic
Threading support:               background (boost)
Use double precision:            disabled
Assert mode:                     standard
Allocator type:                  nedmalloc (pooling)
STL containers use allocator:    enabled
Strings use allocator:           disabled
Memory tracker (debug):          disabled
Memory tracker (release):        disabled
Use Boost:                       disabled

----------------------------------------------------------------------------

-- Configuring done
-- Generating done
-- Build files have been written to: E:/tools/vcpkg/buildtrees/ogre/x86-windows-rel

http://www.ogre3d.org/forums/viewtopic.php?t=69274

Dependencies
Dependencies-vc140-x86-12.03.2016.7z
Size: 25.94M

Dependencies-vc140-x64-12.03.2016.7z
Size: 28.94M

set PKG_CONFIG_EXECUTABLE=E:\tools\Bin\pkg-config.exe does not work
copy E:\tools\Bin\pkg-config.exe > E:\tools\vcpkg\installed\x86-windows\bin work
-- Found PkgConfig: E:/tools/vcpkg/installed/x86-windows/bin/pkg-config.exe (found version "0.28")

вроде скомпилировалось, насколько рабочее состояние, время покажет

repo: Microsoft/vcpkg


text:
Adding new or existing items to folders in the Solution Explorer is broken

1. Adding new files above/below within a folder does not work correctly.
Repro steps

Select a file that is within a folder node in the Solution Explorer
Right-click, Add Above|Before > New Item

Expected behavior
File is created in the folder.
Actual behavior
File is added to the end of the project. If you look in the project file, the  element is added to the correct place, but as the file is created at the project root, doesn't work.
For example, if I were to select Foo.fs and add a new file below called Qux.fs, the project file would look like:
<Compile Include="Folder\Foo.fs">
<Compile Include="Qux.fs">
<Compile Include="Folder\Bar.fs">

2. Adding an existing item to a folder does not work correctly.
Repro steps

Select the project node in the Solution Explorer
Right-click, Add > New/Existing Item
Add a file in a folder

Expected behavior
File is created in/added from the folder.
Actual behavior
File is added to the end of the project, but does not include the folder.
Known workarounds
Create the file outside of VS and manually update the project file :(
Related information
Affects VS 2015 and VS 2017 RC and master (not sure about pre 2015).

Added another case where adding new/existing files to a folder is completely broken. @KevinRansom can we add a milestone and area labels to this please?

source: gharchive/issue

repo: Microsoft/visualfsharp

license: MIT

license_type: permissive

license_source: github-api


text:
add .NET versions 4.6.2/4.7/4.7.1/4.7.2

This adds support for detecting .NET Versions  4.6.2/4.7/4.7.1/4.7.2, for example when building and for the default behaviour of fsc code.fs and F# Interactive.

File | New project detects reference assembly folders and adds them as appropriate.
Not sure where that website is, but it's misleading. net462 and above are optional components, so you need to actually install them first before they become available.

@KevinRansom @brettfo I don't know how to complete this, because ti seems like the MSBuild we are using is not up-to-date. The TargetDotNetFrameworkVersion enum is missing values for Version47, Version471, Version472.
Can we use an updated MSBuild?
C:\GitHub\dsyme\visualfsharp\src\fsharp\MSBuildReferenceResolver.fs(113,58): error FS0039: The field, constructor or me
mber 'Version47' is not defined. [C:\GitHub\dsyme\visualfsharp\src\fsharp\FSharp.Compiler.Private\FSharp.Compiler.Priva
te.fsproj]

C:\GitHub\dsyme\visualfsharp\src\fsharp\MSBuildReferenceResolver.fs(114,59): error FS0039: The field, constructor or me
mber 'Version471' is not defined. [C:\GitHub\dsyme\visualfsharp\src\fsharp\FSharp.Compiler.Private\FSharp.Compiler.Priv
ate.fsproj]

C:\GitHub\dsyme\visualfsharp\src\fsharp\MSBuildReferenceResolver.fs(115,59): error FS0039: The field, constructor or me
mber 'Version472' is not defined. [C:\GitHub\dsyme\visualfsharp\src\fsharp\FSharp.Compiler.Private\FSharp.Compiler.Priv
ate.fsproj]

@cartermp Just to mention that there is some risk in this change
Specifically, it would change F# scripts running with F# Interactive to use .NET 4.7.2 by default if it is installed.  Normally I’d say “go for it” but there is at least one case where we know this is a breaking change: the addition of some Span<T> overloads for File.GetFullPath and File.GetFileName means this code no longer resolves and needs a type annotation:
let getFullPath a = Path.GetFullPath a
let getFilename a = Path.GetFileName a

We’ve always done this – just bump the .NET version to make the latest the default – but in those cases we were normally shipping a new version of Visual Studio so users expected some transition. Perhaps we should now only do it at next VS given the above.  That will mean users of F# Interactive won't be able to access Span<T> or any .NET 4.6.2/4.7/4.7.1/4.7.2 built-ins until then though.
Separately, this again motivates having either #r "framework: net472"  to be able to pin down the default referenced framework.

@dsyme, if the only issues we foresee would be the added overloads which need annotations, I'd recommend we bump the version regardless, it is better for users to fix their scripts to make them forward compatible while not excluding usage of latest apis available from FSI.

@dsyme Yep, we can't change the default in dev15. We can reconsider this in dev16.

@dsyme just as a note about span - since they won't be available in .NET Framework as per the current plan, the disambiguation may not be needed if scripts executing against .NET Framework. They will be needed for those executing against .NET Core, so that will have to factor into the design that @KevinRansom has put together and the RFC updates we'll make. At least I think it will...

Also we don't know what the base version of .NET Framework for VS 2019 will be. We're currently working on negotiating a high enough version such that .NET Standard 2.0 components are "natively" understood, but if they are not, it is likely that FSI will be tied to that base version just so that the lowest-targetable projects (without further configuration) will work out of the box.

I don't think this will be needed, but I could be wrong. For dev16, we'll have net471 as a base dependency, which means it will "natively" understand .NET Standard components. That's made a lot of us happy around here.

@cartermp,
I think this is may still be important, the scenario is when you are running FSC and building a project targeting one of these extra frameworks.
However, I made some changes when I fixed the msbuild dependency, and so this may not be necessary from that point of view.  I'm pretty sure I removed the use of the registry for example.  Anyway, I will dig into this a bit, when I get a moment.

Handling this with this PR: #6005

source: gharchive/pull-request

authors: KevinRansom cartermp dsyme smoothdeveloper


text:
Use Microsoft/VisualStudio-SharedProject as submodule

why do that? ref #496 ( fix folders, new interactive windows, show all files, drop and drop working, etc )
the Microsoft/VisualStudio-SharedProject repo contains the common code of Python Tools for Visual Studio and Node.js Tools for Visual Studio, .
Is the same codebase as visualfsharp, derived from MPF - Managed Package Framework for Projects, but a later version with a really solid implementation of the project system (for example folders are supported)
this is not the new CPS - Visual Studio Project System, i dont know how difficult is going to be convert to the new CPS, but i think is good to have the same codebase and roadmap when PTVS and nodejs move to CPS.
It's also possibile to support old vsprj system and new CPS in parallel (like c#, see CPS docs ) to make easier the migration.
I added the sharedproj as a submodule inside external/VisualStudio-SharedProject .
Why submodule:

easier merge for the others repo (fsharp, FCS) because need only to delete the .gitmodules file
few changes in the history

The idea is to replace the current code inside vsintegration/src/vs/FsPkgs/FSharp.Project/Common.Source.CSharp/Project with the code inside the submodule external\VisualStudio-SharedProject\Product\SharedProject (modulo bugfix of visualfsharp, who can be sent as pr to the shared repo)
A possible roadmap:

cleanup the current code to minimized diff (comments,blanks,style,unused code,unused using)

easy to review, compile check (it's csharp, indentation is not a problem)

replace namespace of current files with the one of sharedproj (and fix .fs files)

compiler check

replace files

incrementally, starting from the one with less code/dependencies

we can also use a temporary fork of the sharedrepo, to make the migration easier and incremental
Continue to fix bugs already fixed in another similar codebase waste lot of time ( see #732 for example, or lots of vs extensions bugs ) and there is little contribution, with mixed results ( it's 2015, folders or showallfiles doesn't works ). Now the priority is coreclr, but the vs area need some love too.

Hey @mousetraps, look at this, we're getting your project system :-)
@enricosada Thanks for taking care of this mate.
Kevin

please don't submodule things.

@forki why? Alternative ideas?

Gitsubmodules sound awesome in the beginning, but in practice they are really really hard to handle.   In our teams we found that even experienced git users run into big trouble from time to time. Newbies were completely lost. It requires really deep knowledge into the tooling. To make things more fun we had the issue that two submodules changed their url, so that we basically broke our complete history and had to git rewrite it.
We ended up removing all the submodules.
I guess these issues can be addressed with git subtree, but I didn't use it in practice.
Tbh I'd prefer to inline the code here and merge manually back and forth. This doesn't sound half the fun, but it's a process everyone understands.

Really thx for feedback @forki
Going to work, i'll answer later.
Inviato da Outlook
On Thu, Nov 19, 2015 at 11:39 PM -0800, "Steffen Forkmann" notifications@github.com wrote:
Gitsubmodules sound awesome in the beginning, but in practice they are really really hard to handle.   In our teams we found that even experienced git users run into big trouble from time to time. Newbies were completely lost. It requires really deep knowledge into the tooling. To make things more fun we had the issue that two submodules changed their url, so that we basically broke our complete history and had to git rewrite it.
We ended up removing all the submodules.
I guess these issues can be addressed with git subtree, but I didn't use it in practice.
Tbh I'd prefer to inline the code here and merge manually back and forth. This doesn't sound half the fun, but it's a process everyone understands.

Reply to this email directly or view it on GitHub:
https://github.com/Microsoft/visualfsharp/pull/733#issuecomment-158312698

yes, submodules need some special care and are not transparent to contributors (who need to understand how submodule works).
I think submodules are great (when not used as replacement for a package manager) because make easier to contribute back to external repo and are clean.
But as @forki said, submodule need special care, require learning, there are some traps and maybe are not worth the effort here.
i'll push force an update with subtree instead of submodule

working on it, but i get the crlr issue ( .gitattributes ).

send pr Microsoft/VisualStudio-SharedProject#21 i'd like to add subtree after the line ending normalization if possible

ok, @mousetraps merged normalization of encoding, i'll update this pr next week.
i really think that's going to speedup fixes for the vs extensions

@enricosada I don't quite get this PR and suspect it's not the right way to start things w.r.t.the project system.  In particular it doesn't feel right to incorporate code we are not yet using as a submodule.
I can see potential for bringing the updates and fixes across bit by bit, though we would best determine a common baseline which could be hard.  Maybe we could even completely reconciling the two project system implementations. But such work seems long term and is worthy of a full feature branch or PR?  Until we're sure it will work out I'm not sure using the submodule is right.

Btw an alternative to sub modules is subtrees, which only places the additional process burden on contributing back to SharedProject, not on external contributors. This is what we use in both NTVS and PTVS. I'm on my phone now but I can share some of the original reasoning behind this decision when I have the chance to dig through emails.

@enricosada

The idea is to replace the current code inside  vsintegration/src/vs/FsPkgs/FSharp.Project/Common.Source.CSharp/Project  with the code inside the submodule  external\VisualStudio-SharedProject\Product\SharedProject...

To be clearer, this seems like a valuable goal, or at least a good thing to investigate. The Visual Studio team may decide to pursue CPS or some other project system - it's not clear what the right evolution is - but experimenting with the above seems valuable input.
It's just that a whole PR that does the job would be needed. Equally closing this one may discourage, which is not at all intended.

@mousetraps yes, we are doing it with subtree instead of submodule, other people like @forki said it's easier. Thx for feedback btw, and for the shared proj code!! great initiative

@dsyme the vs ide extensions is the component with the least improvements, and no roadmap.
It impact vs user a lot ( lots of bugs compared to other vs extensions ), and is a complex codebase ( no need to repeat why )
i tried to ask, discuss about future, possibile roadmap in #496 (someone else in #730), no answer in github from no one.
[RANT ON] That's happen often with discussion in this repo about roadmap/future, no answer or no actionable content, if the issue is not the current top priority. That really limit contribution from community. Show a roadmap, community can help with pr[RANT OFF]
I got some answer from @KevinRansom in the standup.

I can see potential for bringing the updates and fixes across bit by bit, though we would best determine a common baseline which could be hard. Maybe we could even completely reconciling the two project

Port every single bugfix one at time it's really complex, and no big gains. And we are in the same situation next bug. I tried with "open directory", complex and not really usefull.
That's one of the causes of little contribution in vs (complexity is another)
Also big fix ( like drag/drop, add files, show all files ) require more code.
I really think the real long term solution is converge to sharedproj source code, because the code is really similar ( visualfsharp it's the same codebase, but older ) but better quality (bugfix, features, style)
My possible workflow it's explained in https://github.com/Microsoft/visualfsharp/issues/496#issuecomment-173144489

@enricosada Just to close this out - I'm totally fine with code alignment with Microsoft/VisualStudio-SharedProject.  But please not via git subtree...   There's no intrinsic reason why we need to use subtree to do this is there?

@dsyme a subtree is not a submodule.
I can commit as source files only, it's pretty much the same as subtree.
subtree add the source commit id to the commit message (so subtree command can know what the original commit was ), but after that, we can change the files etc.
The pro is: easier to merge new changes from sharedprj, and contribute back to sharedproj.
For developers cloning the project it's the same, they doesnt know it's a subtree, no special command needed
some info: http://blogs.atlassian.com/2013/05/alternatives-to-git-submodule-git-subtree/
Let me show it, i'll push it to this branch, so you can review. If not ok, i'll commit files only without

added [WIP] untils it's ready

ok, @dsyme it's pretty much the same as copy the source inside external/VisualStudio-SharedProject, it's a normal commit, but with subtree i can do:
git subtree pull --prefix external/VisualStudio-SharedProject https://github.com/Microsoft/VisualStudio-SharedProject.git master --squash

to pull new version from VisualStudio-SharedProject (or to send pr back to sharedproj, see the short example https://gist.github.com/kvnsmth/4688345 ). Obv we import lot of files, but are inside an isolated directory and text files, so not an issue
the diff:

vsintegration/src/vs/FsPkgs/FSharp.Project/Common.Source.CSharp/Project
external/VisualStudio-SharedProject/Product/SharedProject

another good is in external\VisualStudio-SharedProject\Product\ReplWindow the same repl as c#/python and node.
or external/VisualStudio-SharedProject/Product/SharedProject/AllFilesProjectElement.cs etc
maybe it's not a solution, obv need work, but i think if we can import this codebase, lots of bugs can be fixed. We can start to minimize diff with style pr only, after that, we can discuss how to proceed in multiple iterations
it's ready for me this pr

@enricosada I'm not sure I understand.  We can't commit 649 files into the tree without them actually being actively used and part of the product.  Why would we add files that aren't part of what's built?   You don't need to have the files in the master branch just to compare the source code, or work on rebuilding the project system on SPS.
For example, if the feature work is never completed then we would be left with 649 legacy files which need to be deleted.
I'm OK with PRs that textually align the source code of FSharp.LanguageService.Base and FSharp.ProjectSystem.Base so that we can see what's what.  But we would only checkin a subtree or a copy of SPS as part of the completed, tested feature.

@dsyme i want a shared branch to do this work because i'd like to have some help.
i'll try to make example commits how to do it, so if someone want to help, it's easier to do it together.
We can do that in another branch, but i'd like to have in master because:

i want to integrate the sharedproj code in multiple interation, not a big bang when ready.
no need to sync with master branch changes, the risk is to waste the work or do more merge than work.
it's easier for contributors because there is only one branch for developmente, master, no need to switch
i cannot do it alone, it take lot of work and time to make slowly and safe, and long living branch are a risk of become useless

But as you wish, if for you @dsyme and @KevinRansom it's ok we can do that in another branch in this repo (more visible for contributors).
When are are ready (not complete but something useful) maybe we can merge the shared branch

@enricosada Thanks, I do think all those points above are valid, though they are in many ways in the nature of the beast.

When are are ready (not complete but something useful) maybe we can merge the shared branch

If it helps, the Microsoft model is that "main" is always intended to be in a ship-ready state, at least up to an intended alpha/beta/release-candidate quality.  Work-in-progress doesn't get integrated into "main".  I think it's always been clear that commits to "master" in this repo have to be feature-complete and as bug-free as possible.
If we have 5 major features going on we can't all do that in master, or even in this repo.  And many of the same risks apply if the work is done in master too, e.g. all feature work runs the risk of dying, and integration is still necessary every time you pull from master,

But as you wish, if for you @dsyme and @KevinRansom it's ok we can do that in another branch in this repo (more visible for contributors).

Right now we're effectively giving feature work visibility via WIP PRs and feature branches.  That's OK up to a certain level (but is admittedly badly affected by GitHub's size restrictions on showing diffs).  Perhaps you could use that approach?
The natural thing would be to do this as a branch in your own repo or as a surrogate repo.  Then you can pull PRs and recruit people to commit to that..  You could then submit a WIP PR showing the status of the work and to give it visibility - the PR could advertise how to commit to the feature.  (I'd actually appreciate it if there were an active WIP PR for the coreclr branch so we could see the overall diff and status).
Thanks
Don

@dsyme diff of coreclr changes? you can diff branches (or commits) in github.
https://github.com/Microsoft/visualfsharp/compare/master...coreclr
coreclr as wip pull request can be ok (a pr is a branch, so not much different) because codebase doesnt change a lot, but i cannot do it, with a diff with 500file added, it's useless.
I need a base somewhere (with sharedprj) and additional work as diff.
I dont want to use a personal branch and develop there with pr, because no one it's gonna review it. That mean i am going to send a too big pull request and a big review (no thx, it's useless).
So i think is ok to diff locally the sharedprj and visualfsharp (so no need for this pr or import sharedproj codebase now) and send multiple pr to refactor.
We can integrate sharedproj when and if there is a big enough feature/improvement.
I'll close this pr, and start send small refactor pr.
Thx don for discussion, i know i tried to push a lot :smile:

authors: KevinRansom dsyme enricosada forki mousetraps


text:
Gitignore generated FSharp.Core.dll

/cc @enricosada

:+1:

Pulling as it's a micro change
Strange failures in Jenkins:

java.io.IOException: remote file operation failed: d:\j\workspace\Microsoft_visualfsharp\release_windows_nt_prtest at hudson.remoting.Channel@71926a5c:Azure0128023039: java.nio.file.FileSystemException: d:\j\workspace\Microsoft_visualfsharp\release_windows_nt_prtest\tests\24,30FSharp_Failures.env: The process cannot access the file because it is being used by another process.
05:27:19

authors: dsyme enricosada forki


text:
Allow runtime in createNewProject api

Currently the IoT trigger is only available for C#Script and runtime "~1", so our partner team needs to pass in the runtime. Ideally it was available for C# and runtime "beta" that works on all OS's, but in any case we should let consumers of the api pass in the runtime they want.
Fixes #249

ping @StephenWeatherford @nturinski I want to get this in ASAP so the partner team can test the API tonight

Yeah it's for a specific partner team that wants to call this api

repo: Microsoft/vscode-azurefunctions


text:
Cannot find module 'eslint-config-myconfig' Referenced from: /my/project/dir/.eslintrc

http://eslint.org/docs/user-guide/configuring#using-a-shareable-configuration-package
In accordance with the docs linked above, I can't seem to get our shared config working with this VSCode plugin. It works fine in other editors that support eslint (Sublime, for instance).
I have the following (as an example) in my projects config:
  "extends": [
    "myconfig"
  ],

I have "myconfig" installed locally eslint-config-myconfig and also have eslint installed globally and locally as well.
I'm running:
Version 1.3.1
Commit e6b4afa53e9c0f54edef1673de9001e9f0f547ae
Date 2016-07-12T13:28:46.761Z
Shell 0.37.6
Renderer 49.0.2623.75
Node 5.10.0

Hi, I have the same issue as of the recent 1.5 release (did not have this plugin installed before that).

I can't reproduce this using the latest eslint plugin. See attached screen short. I have both eslint and eslint-config-myconfig installed locally.
Does this work for you if you execute eslint from a terminal ?

@dbaeumer Thanks for that sanity check - it is actually broken from terminal too.  It must be either a problem with the custom config or eslint itself, I'll dig deeper.

@dbaeumer @yomed I can't reproduce this any longer. I'm using Code 1.5.2 and 0.10.18 of the ESLint extension. Changing the inherited config's rules have an immediate affect in the editor.

I have the same issue.
Code 1.5.3, ESLint extension 1.0.7
.eslintrc:
{
	"extends": "myconfig",
}

Error: Cannot find module 'eslint-config-myconfig'
I have the 'eslint-config-myconfig' installed locally. The same config is working for other editors.

@joacle does it work from the terminal. eslint and eslint plugins must either all installed locally or all globally.

@dbaeumer I have all the references installed locally. My package.json:
{
...
"eslint": "^3.2.2",
"eslint-config-airbnb": "^10.0.0",
"eslint-plugin-import": "^1.12.0",
"eslint-plugin-jsx-a11y": "^2.0.1",
"eslint-plugin-react": "^6.0.0",
...
}

@joacle executing your setup in a terminal produces the same error as in VS Code. The output is
P:\mseng\VSCode\Playgrounds\bugs\eslint-101>node_modules\.bin\eslint.cmd test.js
Cannot find module 'eslint-config-myconfig'
Referenced from: P:\mseng\VSCode\Playgrounds\bugs\eslint-101\.eslintrc.json
Error: Cannot find module 'eslint-config-myconfig'
Referenced from: P:\mseng\VSCode\Playgrounds\bugs\eslint-101\.eslintrc.json
    at Object.resolve (P:\mseng\VSCode\Playgrounds\bugs\eslint-101\node_modules\eslint\lib\util\module-resolver.js:74:19)
    at resolve (P:\mseng\VSCode\Playgrounds\bugs\eslint-101\node_modules\eslint\lib\config\config-file.js:478:33)
    at load (P:\mseng\VSCode\Playgrounds\bugs\eslint-101\node_modules\eslint\lib\config\config-file.js:495:26)
    at P:\mseng\VSCode\Playgrounds\bugs\eslint-101\node_modules\eslint\lib\config\config-file.js:391:36
    at Array.reduceRight (native)
    at applyExtends (P:\mseng\VSCode\Playgrounds\bugs\eslint-101\node_modules\eslint\lib\config\config-file.js:362:28)
    at Object.load (P:\mseng\VSCode\Playgrounds\bugs\eslint-101\node_modules\eslint\lib\config\config-file.js:529:22)
    at loadConfig (P:\mseng\VSCode\Playgrounds\bugs\eslint-101\node_modules\eslint\lib\config.js:63:33)
    at getLocalConfig (P:\mseng\VSCode\Playgrounds\bugs\eslint-101\node_modules\eslint\lib\config.js:130:29)
    at Config.getConfig (P:\mseng\VSCode\Playgrounds\bugs\eslint-101\node_modules\eslint\lib\config.js:256:22)

@joacle add "eslint-config-myconfig": "^0.2.0"to the dependencies fixes it. Any objection to close?

Thanks! It works, no objection :)

Closing then.

authors: caiges dbaeumer joacle yomed

repo: Microsoft/vscode-eslint


text:
Debugging Python code does not work

Original Issue by @Joukahainen82 created at vscode repo:
Issue Type
Bug
Description
Just after downloading and installing the latest  update to VS Code I cannot debug my Python code. Everytime I get the message:
Error
Debug adapter process has terminated unexpectedly
Before that last update debugging the same code ran fine.
VS Code Info
VS Code version: Code 1.20.1 (f88bbf9137d24d36d968ea6b2911786bfe103002, 2018-02-13T15:34:36.336Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2592)

Memory (System)
7.80GB (1.88GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (16)

Extension
Author (truncated)
Version

django-html
bib
1.2.0

django-snippets
bib
1.1.0

jupyter
don
1.1.4

python-extension-pack
don
1.0.1

file-icons
fil
1.0.7

code-runner
for
0.8.7

vscode-csharp-snippets
jor
0.2.0

docomment
k--
0.0.17

MagicPython
mag
1.0.12

python
ms-
2018.1.0

csharp
ms-
1.14.0

vs-keybindings
ms-
0.1.7

vscode-icons
rob
7.20.0

python
tht
0.2.3

python-extended-snippets
tus
0.0.1

jinja
who
0.0.8

Reproduces only with extensions
User @Tiancityrua has the same issue:

This problem still occur for me in the latest version.I can't run any python code now!

Please could you uninstall the extension and re-install this
Please try debugging a simple python file such as the following (let us know how that goes):

print("Hello World")

Please could you go into the launch.json file and add a setting as follows:

    "logToFile": true

1. Next start debugging
2. Once it fails, open the extensions folder using the command `Extensions: Open Extensions Folder`,
3. Go into the python extension folder and locate the file `debug.log`
4. Upload the file here

Have the same issue. Did everything as you wrote, but "debug.log" file didn't appear.

@zztalker
Please try un-installing the extension and installing it again. If that does not work go into the extensions folder (select the command Extensions: Open Extensions Folder from the command palette) and locate the Python extension directory and delete it manually).
Let me know how this goes.
If it still fails, please provide the following info:

Python version
Extension version
OS Version
Ensure you are trying to debug a file with a simple `print("Hello World")

@DonJayamanne
It's work! The problem was in the access right's on the folder - to delete it manually I have to delete everything inside the folder and then ms-python folder at all. After I manually clean folder and reinstall extension debug started and debug.log appeared in the extension folder.
Thank you for help!

@DonJayamanne
It's really work!Maybe after this time,I can manually clean folder and reinstall extension to solve similar problems.Thank you for a lot!

@DonJayamanne
Yes, it really works! I delete any folder related to python and reinstall python and anaconda extensions. Having done that, I find my vscode works again! Thanks for your advice! Best wishes to you!

@Joukahainen82
Please confirm this works after uninstalling and reinstalling the extension.

I have the same issue, deleting and reinstalling the extension didn't work.

@Tinuxx

I have the same issue, deleting and reinstalling the extension didn't work.

Please could you create a separate issue. Everyone else seems to have this issue due to a faulty installation of the extension.

Hello!
I did not reinstall anything. Everything just started to work by itself after a week or two. Maybe it was another update that fixed the problem.
Generally everything works by itself 😊
Pete
Od: Don Jayamanne
Wysłano: poniedziałek, 9 kwietnia 2018 16:55
Do: Microsoft/vscode-python
DW: Joukahainen82; Mention
Temat: Re: [Microsoft/vscode-python] Debugging Python code does not work(#1125)
@Joukahainen82
Please confirm this works after uninstalling and reinstalling the extension.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

authors: DonJayamanne Joukahainen82 Tiancityrua Tinuxx lywyz tsalinger zztalker

repo: Microsoft/vscode-python


text:
SyntaxError: (unicode error) 'unicodeescape' codec can't decode bytes in position 183-184: truncated \UXXXXXXXX escape

Environment data

VS Code version: 1.24.0
OS and version: Windows 10 Home
Python version (& distribution if applicable, e.g. Anaconda): 3.6.4

Actual behavior
File "c:\Users...........\python code.vscode\test.py", line 439
'''
^
SyntaxError: (unicode error) 'unicodeescape' codec can't decode bytes in position 183-184: truncated \UXXXXXXXX escape
Expected  behavior
Nothing, as all the above codes are commented out using '''......'''
Secondly, the error shown is on line 439, which only contains (''') comment closing tag.

Please could you provide the following info:

What are you doing to get this error? Debugging?
Please provide contents of the above file.
Please provide a screen shot of the error.

I'm going to close this for now as we don't handle file encoding/decoding for Python source, but if you can still provide the info requested we can see if I'm wrong. 😉

Hi DonJayamanne,
I wrote this code to open a file. The file, I am trying to open and write is a notepad text file.
I used below code:
test = open(r"c:\Users...........\python code.vscode\test.py",  mode = 'w')

@shaharpit191 Don still needs to know how you were trying to execute the file. But my guess is your file is not encoded for UTF-8 or it is but you accidentally pasted in a character not encoded for UTF-8 (if you look in the lower-right corner of VS Code it will list the encoding and if it isn't UTF-8 then you will need to change it).

authors: DonJayamanne brettcannon shaharpit191


text:
Raw string highlighting

Environment data
VS Code version:  1.18.1
Python Extension version:  0.80.0
Python Version:   CPython 3.5.4 32b
OS and version:    Windows 7 Pro SP1 x64
Actual behavior
I have the following line
fops.save_txt(environ['SystemRoot'] + r'\explorer.exe '
                      + bdexp.EXPORTS_DIR,
                      bpl.PROGS_TO_LAUNCH_PN)

and the r and \e shows in blue with the first ' and xplorer.exe ' shows in brown(?).
My point is that it isn't recognizing it as a string (raw in this case) like it does with the previous 'SystemRoot' which shows all brown(?) and the Intellisense recognizes as a string.
Expected  behavior
It should show r'\explorer.exe ' all brown(?) and recognize it as a string.
Thanks,
JM

We actually don't control the syntax highlighting for Python; we just rely on highlighting that VS Code provides. And VS Code relies on https://github.com/MagicStack/MagicPython for its syntax file, so reporting the issue there would be best.

authors: brettcannon jcrmatos


text:
Provide full signature help with highlighted parameter

Fix #70
Ignore Russian translation from pending PR

@MikhailArkhipov looks good. will approve after the release.

On Python 3.6 VSC gets different signature description which actually does not have signature in it. Need to look into completion.py

@DonJayamanne could you please look one more time. I removed requirement for param name to be a word in completions.py so we support ... in signature (ex print) and added separate tests for Py3 and Py2 since behavior is different in some functions (notably, pow and some others)

authors: DonJayamanne MikhailArkhipov


text:
bugfix deploy command macintosh

if tested linux and windows instead of linux and macintosh and prevented else (windows) statement to be reached.

@CatchRetry - Thanks..

authors: CatchRetry raunakpandya


text:
Refresh the vscode

Hi,
I am facing the problem with the vscode for the refreshing the page.Just tell me how to refresh the page.

VSCode Version: Code 1.4.0 (6276dcb0ae497766056b4c09ea75be1d76a8b679, 2016-08-04T16:45:31.680Z)
OS Version: Windows_NT ia32 6.1.7600

Steps to Reproduce:

F1 -> Reload Window ?

@glen-84 thanks. Closing since he answered it.

authors: dbaeumer glen-84 smartDataSDN

repo: Microsoft/vscode


text:
ctrl+_ isn't functional on mac os x

Mapping a function to the keyboard shortcut "ctrl+_" doesn't get called on mac os x with 0.10.3 (783ecf841)

@clarkeaa how is it going in 0.10.5?

@clarkeaa Please see https://code.visualstudio.com/docs/customization/keybindings#_accepted-keys and https://code.visualstudio.com/docs/customization/keybindings#_keyboard-layouts

OK, thanks.  I think ctrl+_ previously worked since I've checked out code that uses it.  So, for posterity, you have to use "ctrl+shift+-" instead of "ctrl+_".

authors: alexandrudima bpasero clarkeaa


text:
Opening a file always opens two windows

We've been like this for as long as I can remember, but I just realised how annoying it is.
In Windows, have Code closed and:

Double click a file

or

Run code-insiders file

You always get two windows open: one empty and one with the file. We should only get one.

@joaomoreno no, we never behaved like that. looks like a regression (could be hot exit)?

Oh snap, I was remembering wrong! 😮

@Tyriar please note my fix, somehow the backup service was returning its actual data structure that was changed while opening windows, basically what happens is:

code opens on a single file
we store the empty window as backup workspace
we wrongly open the empty window in https://github.com/Microsoft/vscode/blob/master/src/vs/code/electron-main/windows.ts#L437 because meanwhile that window was added into emptyToRestore

Nice find, this may have been the cause for the mysterious extra empty workspace window I was seeing sometimes while adding empty workspace support :smile:

authors: Tyriar bpasero joaomoreno


text:
Builtin official python support

Hi
I just want to ask if there is any plan for the official support for python intellisense? If so is there any expected timeline for it ?
Thanks

I think there are no plans for an official support. But you can download an Python extension where the Python Language is supported with Intellisense, Linting, Debugging .... and so on.

I think there are no plans for an official support. But you can download an Python extension where the Python Language is supported with Intellisense, Linting, Debugging .... and so on.

We recommend the Python extension that @Daylien mentioned and have invested in it. We don't have plans to bundle it though.

We recommend the Python extension that @Daylien mentioned and have invested in it. We don't have plans to bundle it though.

authors: Daylien Tyriar tejinderss


text:
c# anonymous type breaks syntax highlight

VSCode Version: Code - Insiders 1.11.0-insider

I guess this might be an OmniSharp issue

Yes, I was unable to reproduce this using our builtin c# grammar.
Please try disabling all extensions by running code with --disable-extensions. This should help identify if OmniSharp is the the root cause here. If you still see the syntax highlighting issue with extension disabled, please post the source of the file up and I can take a look
Thanks

thanks.
this simple theme + c# causes it
not theme alone, theme + c#
it says in the theme inspector that the ending parenthesis has no theme selector
idk
https://marketplace.visualstudio.com/items?itemName=henrysoftware.theme-rage
{ 	"name": "Rage", 	"settings": [ 		{ 			"settings": { 				"guide": "#333333", 				"selection": "#3f7fbf7f", 				"inactiveSelection": "#003f7f3f", 				"lineHighlight": "#003f7f3f", 				"findRangeHighlight": "#003f7f3f", 				"rangeHighlight": "#003f7f3f", 				"findMatchHighlight": "#3fbf3f3f", 				"currentFindMatchHighlight": "#3fbf3f3f", 				"selectionHighlight": "#3fbf3f3f", 				"referenceHighlight": "#3fbf3f3f", 				"wordHighlight": "#3fbf3f3f", 				"wordHighlightStrong": "#bf3f3f3f" 			} 		}, 		{ 			"scope": "invalid", 			"settings": { "foreground": "#bf7f7f" } 		}, 		{ 			"scope": "invalid.deprecated", 			"settings": { "foreground": "#bf7fbf" } 		}, 		{ 			"scope": "comment, punctuation.definition.comment", 			"settings": { "foreground": "#3fbf3f7f" } 		}, 		{ 			"scope": "punctuation", 			"settings": { "foreground": "#7f7f7f" } 		}, 		{ 			"scope": "constant", 			"settings": { "foreground": "#bfbf7f" } 		}, 		{ 			"scope": "string", 			"settings": { "foreground": "#bf7f7f" } 		}, 		{ 			"scope": "keyword", 			"settings": { "foreground": "#7f7fbf" } 		}, 		{ 			"scope": "storage", 			"settings": { "foreground": "#3fbfbf" } 		}, 		{ 			"scope": "variable, support.variable, entity.name, meta", 			"settings": { "foreground": "#569cd6" } 		}, 		{ 			"scope": "entity.name.function, support.function", 			"settings": { "foreground": "#bf7fbf" } 		} 	] }

without c# it is punctuation.curlybrace.close.cs
with c# it is nothing?

authors: mjbvz rakkarage


text:
Zooming Causes Markdown Previews to be Reloaded

Steps to Reproduce:

Open the markdown preview
Zoom in or out

Bug
The preview page is reloaded.
The cause is this line in htmlPreviewPart:
	    this._modelChangeSubscription = this.model.onDidChangeContent(() => {
					if (this.model) {
						this.webview.contents = this.model.getLinesContent();
					}
				});

I don't know why onDidChangeContent is fired while zooming. We may be able to workaround the issue but it does seem odd that onDidChangeContent is being fired here

Root cause is in the markdown preview. It updates on vscode.workspace.onDidChangeConfiguration


text:
Switch between recent files Immediately

When you press CMD+P it shows the active file at first place and it's highlighted. So it makes me press down_arrow+enter to switch to the last opened file. It would be better if the last opened file is highlighted first instead of highlighting the active file when you press CMD+P.

@ravinila welcome to Ctrl+Q, it works even better by opening that file when you release the keys, and when you keep pressing Q you can navigate to the next.

authors: bpasero ravinila


text:
Must type the same letter twice when one letter is selected

VSCode Version: Code - Insiders 1.12.0-insider (0834f15e86ef8359da9fbcf95d49083001af65c3, 2017-05-03T15:02:36.792Z)
OS Version: Linux x64 4.4.0-75-generic
Extensions: none

Steps to Reproduce:

select a letter
type the selected letter (nothing happens)
type the selected letter again (the letter will finally be typed)

Real example - rename i to idx

select all three i variables
type idx (only dx will appear)
type iidx (first i won't appear)

for (var i = 0; i < length; i++) {
}

This works for me on Ubuntu.

@acls some questions:

What's in your settings.json?
What's your OS locale set to?
What Linux distro are you on?
What keyboard layout are you using?

What's in your settings.json?

{
    "window.zoomLevel": 1
}

What's your OS locale set to?

en_US

What Linux distro are you on?

Ubuntu 16.04

What keyboard layout are you using?

English (US)

I just booted up an old windows box and installed vscode. Issue still happens there.

It's happening on another Windows machine as well? Are you sharing the physical keyboard by chance?
Moving to editor owners.

Yeah, the windows box was just an old laptop, so different keyboards.

Duplicate of #16520 .
The fix should come out starting with today's or yesterday's insiders (i.e. anything that has 242cb936f0b703a92547c8884dc0c5609eab01e9 ). This might explain the difficulty in reproducing.

Talk about bad timing. The fix was made less than a day before I posted, so the latest insider's build didn't have it.
And sorry about the duplicate posting. I hadn't run into the issue until after I got the latest build an hour earlier. I had searched for doops, but not 6 months back.

authors: Tyriar acls alexandrudima kieferrm


text:
Intent Guide

1/ Intent guides not highlight when I focus in selection scope.
=> Please change color of intent guide when focus some where.
Ex: Change color instant of "IF statement" when I focus beside of IF.
2/ When I open big html file, when I try to collapse or uncollapse each tag element, VS Code will be "lag", crashed or Not response I can't do anything next :(

The first issue is dup of https://github.com/Microsoft/vscode/issues/9069
About the second one, we already create tasks for that https://github.com/Microsoft/vscode/issues/3725


text:
Touchpad not sensitive to sliding

VSCode Version: Code 1.13.1 (379d2efb5539b09112c793d3d9a413017d736f89, 2017-06-14T18:21:47.485Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author
Version

html-snippets
abusaidm
0.1.0

one-monokai
azemoh
0.3.1

path-intellisense
christian-kohler
1.4.2

jquerysnippets
donjayamanne
0.0.1

vscode-html-css
ecmel
0.1.7

tortoise-svn
fantasytyx
0.1.1

auto-rename-tag
formulahendry
0.0.14

beautify
HookyQR
1.1.1

view-in-browser
qinjia
0.0.5

vscode-icons
robertohuertasm
7.9.0

Steps to Reproduce:
1.XPS15 9550
2.When I use the touchpad to move up and down the editor, there will be a obviously delay

I think this is a dup of #13612 related to Precision Touchpads. I've extracted most of the discussion in that issue to https://github.com/Microsoft/vscode/wiki/Known-issues for conveniency.

authors: alexandrudima wenchaoss


text:
Environment service: sync read access to 2 files from ctor

I am seeing 2 sync read file access in environment service right from the constructor and we use this thing both in each window that opens and the main side. So everyone pays the price of resolving these properties over and over.
I think these properties are special and only used for certain corner cases but not important on the critical startup path. Can we
a) put them into the process environment from the main side to pay this cost only once
or
b) resolve them only when actually needed and/or make the resolution async

https://github.com/Microsoft/vscode/issues/17108#issuecomment-324868249

I've changed the getCommonHttpHeaders thing to simply use a UUID which we store after generating it. Getmac won't be called anymore. Unfortunately this is still happening on startup in a sync fashion. The reason for this is that we don't have an atomic storage mechanism across all processes. If we don't generate it sync on startup, we might have 2 processes generating 2 different UUIDs. The mitigation for this is to use a single machineid file for this in user data. This will make reading and writing to this file extremely fast.

Option (a) doesn't work because then the waterfall happens #17108.
Option (b) doesn't work because there is no atomic storage across processes...
😢

Moved the installSource lookup into the resolveCommonProperties.

authors: bpasero joaomoreno


text:
Ignore problems on commented out line

Issue Type
Bug
Description
Hello!  In this powershell script, I've created an if block which is commented out, and has no statement block following it.  It is correctly detected as a comment line in the syntax, but the problem section reports it as an active problem, though it is not active in the script due to the # comment block.
# if ((Get-ChildItem -Path "$LogDir\$TempDir" -File -Recurse -Exclude '*.zip' | Measure-Object | ForEach-Object {$_.Count}) -ne 0)
if ((Test-Path -Path "$LogDir\$TempDir" -PathType Container) -And ((Get-ChildItem "$LogDir\$TempDir" -File -Recurse | Measure-Object | ForEach-Object{$_.Count}) -gt 1))
{
    $FileCount =  (Get-ChildItem -Path "$LogDir\$TempDir" -File -Recurse | Measure-Object | ForEach-Object{$_.Count})
}

Problems: [Powershell] Missing statement block after if (condition).
Secondly, if I create a second if line afterwards, and reverse the comment block, problems says there are no problems!
if ((Get-ChildItem -Path "$LogDir\$TempDir" -File -Recurse -Exclude '*.zip' | Measure-Object | ForEach-Object {$_.Count}) -ne 0)
# if ((Test-Path -Path "$LogDir\$TempDir" -PathType Container) -And ((Get-ChildItem "$LogDir\$TempDir" -File -Recurse | Measure-Object | ForEach-Object{$_.Count}) -gt 1))
{
    $FileCount =  (Get-ChildItem -Path "$LogDir\$TempDir" -File -Recurse | Measure-Object | ForEach-Object{$_.Count})
}

Problems: No problems have been detected in the workspace so far.
If I revert to the original condition, and remove the active if line, problems reports an unexpected else, which is correct, but not illustrated in this example..
VS Code Info
VS Code version: Code 1.20.1 (f88bbf9137d24d36d968ea6b2911786bfe103002, 2018-02-13T15:34:36.336Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)

Memory (System)
15.79GB (10.88GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
57%

Extensions (1)

Extension
Author (truncated)
Version

PowerShell
ms-
1.6.0

Reproduces without extensions

This issue was moved to PowerShell/vscode-powershell#1253

authors: ixixit roblourens


text:
In workspace with many repos branch indicator is not working properly

VSCode Version: 1.21.1
OS Version: macOS 10.13.3

Steps to Reproduce:
I have directories structure:
my_project/
   my_project.code-workspace
   client/ (git repo)
   server/ (git repo)

➜  mkdir my_project
➜  cd my_project
➜  my_project cat > my_project.code-workspace << EOF
heredoc> {
heredoc>     "folders": [
heredoc>         {
heredoc>             "path": "server"
heredoc>         },
heredoc>         {
heredoc>             "path": "client"
heredoc>         }
heredoc>     ]
heredoc> }
heredoc> EOF

➜  my_project mkdir server
➜  my_project mkdir client

➜  my_project git init server
Initialized empty Git repository in /Users/aliev/my_project/server/.git/
➜  my_project git init client
Initialized empty Git repository in /Users/aliev/my_project/client/.git/

➜  my_project cd server
➜  server git:(master) git checkout -b server-branch
Switched to a new branch 'server-branch'
➜  my_project touch server/server.py

➜  server git:(server-branch) cd ../
➜  my_project cd client
➜  client git:(master) git checkout -b client-branch
Switched to a new branch 'client-branch'
➜  my_project touch client/client.js
➜  client git:(client-branch) cd ../

➜  my_project open my_project.code-workspace

Branch indicator in "statusbar" always shows the current branch of the first repository ("server-branch") and no matter from which repository I opened the file.

Does this issue occur when all extensions are disabled?: Yes/No
Yes

/findDuplicates

#35037

authors: aliev joaomoreno


text:
Markdown Preview Error on Vertical Screen

As the screenshot shows, while editing markdown file and click default preview button, Code displayed incorrectly.

I can't repo this problem in insiders. The screenshot also seems cutoff or partially corrupted. Please upload it again to github

authors: cmsax mjbvz


text:
Info icon about keyboard layout in keybindings shown erroneously?

VSCode Version: 1.24.0
OS Version: Windows 10

Steps to Reproduce:
Don't know exactly how to reproduce this on different machines/environments...
Does this issue occur when all extensions are disabled?: Yes
Keybindings shows info about different keys on my layout even though the correct one is already set:

How can I get rid of those info icons? The shown bindings are working as expected...

@CombeeMike What keyboard layout are you using ?

@alexandrudima I'm using Deutsch (Österreich):

authors: CombeeMike alexandrudima


text:
Rust auto-indent doesn't always work

VSCode Version: 1.24.0 and 1.25.0-insider
OS Version: KDE Neon (based on Ubuntu 16.04 Xenial)

Steps to Reproduce:

Make a new file with the following contents:

fn main() {
    println!("Hello world!");

    println!("Goodbye!");
}

Press ctrl+shift+enter on the Goodbye! line

The added line has no indentation, and in a deeper indentation context, pressing tab doesn't insert multiple indents. However, pressing enter after the opening curly bracket or ctrl+shift+enter on the Hello World! line both indent properly.
I've tested this behavior on JavaScript/TypeScript and it works as expected, and I've tested the language-rust package in Atom which works properly too.

Does this issue occur when all extensions are disabled?: Yes

This happens in bash scripts too.

Hi @dqsully, thanks for reporting this. VSCode ships with auto-indentation for JS, TS, CSS, HTML, and JSON, but for other languages, a language extension is responsible for adding it. Please file feature requests or bugs on the Rust and bash extensions you're using

So I did some more testing yesterday and I found that TS, JS, Python, HTML, LESS, and CSS all indent properly, but it doesn't work properly for Bash, JSON, Rust, Dockerfile, or CoffeeScript. Also, this issue happens for me with/without the Rust/RLS extension, and I don't have any extensions for any of the languages that don't indent properly - they came with VS Code.

I'm totally new to this codebase, but it seems like the rust language configuration at language-configuration.json is just missing the increaseIndentPattern and decreaseIndentPattern properties from the source Atom package's settings at rust.cson. Python has it in some source code at pythonMain.ts, and Ruby has it right in the language-configuration.json, but Bash/Dockerfile etc. don't.
I'd be happy to work a pull request this weekend with all of the missing indentation patterns.

@dqsully Sorry for my incorrect response earlier, I thought this feature fell into the category of something that was extension contributed, not a basic language configuration. A pull request for this would be very welcome!

authors: RMacfarlane dqsully


text:
Extensions view: extensions list state not being read out

Environment Details:
VSCode Version : 1.24.1
OS Version : Win10
Additional Details:
ScreenReader Version: NVDA2018.2
Repro Steps:

Launch VS Code while NVDA is ON.
Navigate to View(Alt+V) menu option and select "Extensions" from dropdown.
Type some text in Search Extensions text and check screenreader is reading about it or not.

Actual:
NVDA does not announce any information about the data changing dynamically in treeview and also when we click on Clear extensions input button, texts in the textbox gets deleted so this information is also not being read by the screenreader.
Expected:
When user types something in the textbox, NVDA should announce some information that how many data been found in the treeview matching those characters. And when user clicks on Delete button, then also screenreader should throw a notification or should announce that data has got deleted.
Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx
User Impact:
User will not be able to know about the data which are found matching those characters.
Attachment for Reference:
A11y VSCode Extensions NVDA clear and insert data.pptx
Does this issue occur when all extensions are disabled?: Yes

This feels like low hanging fruit. Upon clear, there should be an alert, and after each query is done there shuold be an alert with some general information (example "104 extensions found mathcing your query"). Assigning to July

@ramya-rao-a as the other one, would be great if we tackle this in september

Yes, this is for September


text:
Published extension fails to register where local debugging succeeds

VSCode Version:
Version: 1.25.1
Commit: 1dfc5e557209371715f655691b1235b6b26a06be
Date: 2018-07-11T15:43:53.668Z
Electron: 1.7.12
Chrome: 58.0.3029.110
Node.js: 7.9.0
V8: 5.8.283.38
Architecture: x64
OS Version: Windows 10

Steps to Reproduce:
Part 1 - Published version fails

Install Sortier extension
Open a typescript file and run the Sortier: Run action
Expect error message command 'sortier.run' not found

Part 2 - Local version works

Pull the Sortier-vscode extension from GitHub - https://github.com/snowcoders/sortier-vscode
Run npm install
Open repo in vscode
Run the extension
Open a typescript file and run the Sortier: Run action
Expect: Same error message as in published package
Actual: Extension runs perfectly fine

My main goal of this issue is to determine what my next steps are to determine why this is failing only from the marketplace. I've tried the following

Debugging locally (see part 2 instructions)
Publishing the package to a vsix file and then installing that locally (still succeeds)

So is there another option that is closer to the actual marketplace or a way to debug the activation of an extension installed from marketplace locally?

Does this issue occur when all extensions are disabled?: No

@k2snowman69 Does the extension published in the market place and that one you run from sources are of same version?

The published extension is the same as the sources. I've also attempted republishing just in case something went wrong in the process. Both are now currently sitting at 1.0.3

I also just enabled renovate.js and all dependencies are now up to date.

Do you see the issue even after updating?

Yep, still occurs; published 1.0.4 after updating last night.

@k2snowman69 It works for me when I install from Marketplace.
Can you please set the log level to trace and try again and check your window logs?

Log level in Visual Studio Code? My extension (which doesn't have logging currently)? And when you say "window logs", did you mean VS code's logs or Window's logs (e.g. event viewer)?
I guess what I am requesting are reproducible instructions so that I can be sure I'm providing the information you are requesting.

@k2snowman69 I mean current window logs in VS Code. You can see it in the output panel. Looks like your extension is not getting activated. After triggering the command, open Developer: Running Extensions and see if the extension is running or not.

It does seem that the extension is not running for me as it's not listed in the Developer: Show running extensions window. I also just installed a clean version of VS Code on a separate machine and installed Sortier from the marketplace, still repros.

@k2snowman69 After the extension is activated in the fresh install.. do you see the extension is shown in Running extensions view?

Nope, it does not show up

You have the activation event registered for your command in package.json like below:
"activationEvents": [
    "onCommand:commandId"
  ]

Right now it just activates on everything
"activationEvents": [
        "*"
    ],

@jrieken Everything looks correct with the extension user using. Still the command invocation says command not found.
Any more insights?

Try not using * activation, but the onCommand:myCommandId - when running the command, we wait for the command-specific activation event but we don't wait for the * activation to be finished. /cc @alexandrudima to check if this is intentional or not.

@k2snowman69 There is nothing immediately wrong about your extension.
I was able to write one just like yours where the command is ok.
Do you perhaps throw an error from the activate function or from code loading? That would lead to the system considering your extension to be not activated.
Otherwise, the following works fine for me:

your package.json

const vscode = require('vscode');

exports.activate = function() {
    vscode.commands.registerCommand('sortier.run', function() {
        console.log(`command running!`);
    });
}

The command runs correctly. Can you please create a minimal reproducible extension?

Okay so this is actually pretty weird (at least by my understanding) and it came down to typescript being in dev-dependencies.
sortier-vscode depends on sortier which depends on cosmiconfig and typescript because it's a file formatter. sortier-vscode only depends on cosmiconfig but to build it needs typescript so I had it in the dev-dependencies.
For some reason when the extension is being packaged it was losing the typescript dependency for sortier which means when sortier was imported it would throw an exception because typescript could not be found.
Moving typescript from devDependences to dependencies in sortier-vscode did fix the problem however again, this isn't sortier-vscode's dependency, it's sortier's dependency which means this should never have been needed in the first place.
Looking at the extension contents of 1.0.7 (before I added typescript as a direct dependency of sortier-vscode)
.vscode\extensions\snowcoders.sortier-vscode-1.0.7\node_modules

@snowcoders

sortier

node_modules

cosmiconfig
typescript

So the typescript library is there but for some reason it's not actually looking inside of the sortier library to grab it.
Also for a sanity check, I searched typescript in the out folder of sortier-vscode just to make sure the extension isn't using it directly and I got 0 results.
So yea, there is some sort of bug here but I'm not sure what exactly.

I would summarise the problem: the extension, if downloaded from the marketplace, fails to load code because the typescript node module is missing.
I suspect this might be a problem with vsce which looks at which node modules to package when creating the zip and it is possible you are hitting some edge case by having typescript be both a top level dev dependency and an inner level dependency.

Of all the output generated, this is the only line worth mentioning:
D:\Projects\sortier-vscode\node_modules\@snowcoders\sortier\node_modules\typescript

Which is correct, sortier depends on typescript directly but sortier-vscode only needs it for the build

I've cloned your repository, ran npm install and then:
➜  sortier-vscode git:(master) ✗ npm list --production --parseable --depth=9999 | grep typescript
/home/joao/Desktop/sortier-vscode/node_modules/@snowcoders/sortier/node_modules/typescript
/home/joao/Desktop/sortier-vscode/node_modules/typescript-eslint-parser
/home/joao/Desktop/sortier-vscode/node_modules/typescript-eslint-parser/node_modules/semver
/home/joao/Desktop/sortier-vscode/node_modules/typescript

I get many more references to typescript, especially that top level one. Are you sure you ran npm install?

The checked in code has a workaround (mentioned in https://github.com/Microsoft/vscode/issues/54332#issuecomment-408793970) which moved typescript from a dev-dependency to a dependency to get the code working. The reproduction steps you are looking for are:

Pull down the repository
Move typescript from dependencies to dev-dependencies
npm install

Got it.

So yea, there is some sort of bug here but I'm not sure what exactly, maybe something specifically to typescript being a sub-dependency but also listed as a dev-dependency? But that wouldn't explain why when loading the sortier library it wouldn't look in it's own node-modules folder.

You are on to something here.
When I move typescript to devDependencies, I still see it properly included in the VSIX in node_modules/@snowcoders/sortier/node_modules/typescript... Don't you see that?

I'm confused by your comment:

For some reason when the extension is being packaged it was losing the typescript dependency for sortier which means when sortier was imported it would throw an exception because typescript could not be found.

On one hand it sounds like you see that the typescript folder is missing. On the other, it sounds like you are intrigued about why sortier can't find the typescript module... So... When you run vsce ls | grep typescript, does the node_modules/@snowcoders/sortier/node_modules/typescript folder appear in the output?
Finally, I'm pretty sure some code is doing require('typescript') from a place where it shouldn't. What is the actual exception which occurs?

I also see it properly included in the VSIX in node_modules/@snowcoders/sortier/node_modules/typescript, sorry for any confusion.
There are no require('typescript') code pieces in my src directory but there are some in my dist output files. Maybe it has to do with my tsconfig.json? The fields that would affect this would be
        "module": "commonjs",
        "target": "es2015",
        "moduleResolution": "node",

But node module resolution is what you would want in this situation... And there is no webpack in this build, just pure tsc.
As for getting the actual error, is there a way to install a previous version of an Extension. Now that I've published 1.0.8 with the work around, the only way to reproduce the issue is to install 1.0.7 and run VS Code.

OK found the issue: the extension depends on typescript-eslint-parser, which has a peerDependency to typescript. So yeah, typescript needs to be a runtime dependency of your module, it can't just be a devtime dependency.

typescript-eslint-parser is imported by sortier which also has typescript in it's dependencies list (see sortier's package.json) so that peer-dependency should be resolved in sortier itself.

typescript-eslint-parser [...] also has typescript in it's dependencies list

This is incorrect, it only depends on it as a dev and peer dependency. Because of the peer dependency, your extension needs to depend on typescript as a regular dependency.

I just copied this from Sortier's package.json
 "dependencies": {
    "cosmiconfig": "^5.0.5",
    "flow-parser": "^0.78.0",
    "fs": "0.0.2",
    "globby": "^8.0.1",
    "rimraf": "^2.6.2",
    "typescript": "^3.0.0",
    "typescript-eslint-parser": "^18.0.0"
  }

I'm fairly sure this means it's a dependency of sortier, not a dev-dependency.
Do you mean adding Typescript as a dev-dependency of sortier-vscode overrides sortier?

10 days ago you did this:

Moving typescript from devDependences to dependencies in sortier-vscode did fix the problem however again, this isn't sortier-vscode's dependency, it's sortier's dependency which means this should never have been needed in the first place.

This is the right fix. Because sortier-vscode depends on typescript-eslint-parser and typescript-eslint-parser has a peer dependency to typescript, then sortier-vscode needs to depend on typescript.

Sorry, I'm not saying that this isn't the right fix, I'm just trying to understand why it is the right fix. So if I understand your explanation: sortier has both typescript and typescript-eslint-parser as dependencies as seen in it's package.json. But since typescript-eslint-parser claims typescript as a peer-dependency, it's not sortier who has to resolve this peer dependency but the leaf consumer which in this case is sortier-vscode.
I again want to reiterate sortier-vscode does not depend on typescript-eslint-parser directly (see package.json). sortier-vscode depends on sortier which depends on both typescript-eslint-parser and typescript.
If my summary is true, then the issue is actually with npm as performing an npm install of sortier itself should result in a peer-dependency warning due to typescript-eslint-parser not being resolved. Right now it does not:
C:\Temporary>mkdir whee && cd whee
C:\Temporary\whee>npm init
C:\Temporary\whee>npm install @snowcoders/sortier
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN whee@1.0.0 No description
npm WARN whee@1.0.0 No repository field.

+ @snowcoders/sortier@2.1.8
added 159 packages from 126 contributors in 13.544s
[+] no known vulnerabilities found [968 packages audited]

C:\Temporary\whee>

If this is your understanding as well I can open an issue with the npm project instead stating that this process should have presented a peer-dependency warning.

I again want to reiterate sortier-vscode does not depend on typescript-eslint-parser directly (see package.json). sortier-vscode depends on sortier which depends on both typescript-eslint-parser and typescript.

Oh, I failed to understand that vscode-sortier !== sortier. Sorry!

Yeah this sounds like an NPM issue. I moved typescript back to sortier-vscode's dev dependencies and deleted package-lock.json. After npm install, this is the outcome:
...
sortier-vscode/node_modules/@snowcoders/sortier/node_modules/typescript
sortier-vscode/node_modules/typescript-eslint-parser
...

And no top level typescript module. So, typescript-eslint-parser can't use typescript.
I would file it as an issue to NPM.


text:
macos: can't open dot files

From @jeffallen on November 24, 2015 18:17
Maybe I just don't know how to use the file chooser in MacOS, but I thought I'd use my nifty new vscode install to edit my .bash_profile and add the code alias proposed in the install docs. But then I couldn't get it to let me open .bash_profile no matter what I tried. Sadly, I went to Emacs and did it there. VSCode fail. :(
I get it. You're doing the right thing by using the Mac file dialog. And Apple is doing the right thing by hiding dotfiles. Except, I'm a programmer, and I know what I'm doing (except when I don't, but then I search stack overflow...)
Copied from original issue: Microsoft/vscode-go#83

Quite by accident, while trying to solve another problem, I found that hitting "/" in the file open dialog brings up a little popup where I could give it a dotfile. Sorry for the noise. And thanks for accidentally teaching me this One Simple Trick.

Feel free to file a bug against Electron and ask them to provide an option in the file picker to show hidden files.

Just hit Cmd+Shift+. in the file dialog to see hidden files!

authors: bpasero jeffallen lukehoban


text:
debug - no truncation?

#4952

test plan says truncation happens at strings longer 10000 characters
have code like this

        let longString = new Array(10001).join('oooooo');
        longString += '<TOO LARGE>';
        console.log(longString);

⚡ console doesn't truncate the string, shows <TOO LARGE>

maybe related to #5802

@jrieken assigning back to you to retest this scenario with a newer Alpha build that includes our node-debug fix to actually enable debug injection for Electron.

works with latest chances

authors: bpasero jrieken


text:
Insiders(1.30.0) displays Windows 10 buttons on Linux

VSCode Version: 1.30.0-insider, commit: c72cb129f2a0b8117c9b01f3767026041d7d1d31
OS Version: Ubuntu 16.04.5 LTS

Steps to Reproduce:

Install VSCode Insiders 1.30.0 on Linux

Does this issue occur when all extensions are disabled?: Yes
Screenshot:
1.30.0 Insiders:

Previous versions:

Apparently if you go to settings and change the titleBarStyle back to "native", you will get back the original title bar. However, the forground color will be the same as the background color, making the menu texts invisible

@G-Ray thanks for recalling this issue. I've updated its label to reflect that it is on Linux and help re-surface it.
@lilianmoraru This is the current default we are trying in insiders. Follow @minghuaw 's instructions to revert to the native menu or even better, open new issues regarding your feedback on the new custom menus :)

Try use:
"window.titleBarStyle": "native"

authors: kasru lilianmoraru minghuaw sbatten


text:
Tree: support highlight

Refs: #64799
New tree should support highlight, when a file is being renamed or a new file is added the rest of the tree blurs out.
If the tree does not want to support this I am open to an alternative solution that would produce the same result.

Closing as per discussion

authors: isidorn joaomoreno


text:
Unable to call Select Default Shell

Issue Type: Bug
I have moved from fish to zsh, but vscode still has $SHELL cached as /usr/local/bin/fish. I'd like to not need to keep "terminal.integrated.shell.osx": "/bin/zsh" in my settings.json, but the Select Default Shell command referenced in https://code.visualstudio.com/docs/editor/integrated-terminal#_configuration seems to be missing for me
VS Code version: Code 1.30.1 (dea8705087adb1b5e5ae1d9123278e178656186a, 2018-12-18T18:05:00.654Z)
OS version: Darwin x64 18.2.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2600)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (1.54GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (17)

Extension
Author (truncated)
Version

ng-template
Ang
0.1.11

gitlens
eam
9.2.2

EditorConfig
Edi
0.12.5

tslint
eg2
1.0.42

vscode-npm-script
eg2
0.3.5

insert-incrementing-numbers
jac
0.0.1

Angular-BeastCode
Mik
7.0.20

python
ms-
2018.12.1

cpptools
ms-
0.20.1

vsliveshare
ms-
0.3.1071

debugger-for-chrome
msj
4.11.1

vetur
oct
0.14.3

subtle-brackets
raf
3.0.0

vscode-multiclip
sle
0.1.5

code-spell-checker
str
1.6.10

pdf
tom
0.4.3

vscode-todo-highlight
way
1.0.4

@Tyriar

@JacksonKearl 👋
Select Default Shell is only exposed on Windows as it's a lot more complicated than on Linux/macOS. You'll want to update your shell launch scripts to set SHELL to zsh instead of fish, that will then be pulled in as the default value for terminal.integrated.shell.osx.

authors: JacksonKearl Tyriar


text:
go live

Issue Type
Bug
Description
go live 那去了 下面怎么不显示了 。还有左边这4个 插件下载 和文件管理 资源管理器等5个那去了，  这个软件编译代码可以。功能 太垃圾太不清晰。
垃圾一个
VS Code Info
VS Code version: Code 1.20.1 (f88bbf9137d24d36d968ea6b2911786bfe103002, 2018-02-13T15:34:36.336Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz (4 x 2712)

Memory (System)
7.85GB (2.74GB free)

Process Argv
D:\新建文件夹\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (11)

Extension
Author (truncated)
Version

google-search-ext
ade
0.2.1

vscode-svgviewer
css
1.4.7

vscode-faker
dee
1.3.0

fuzzysearch
gay
0.2.1

search-node-modules
jas
1.3.0

easy-less
mrc
1.4.5

vetur
oct
0.14.3

LiveServer
rit
5.3.1

open-in-browser
tec
2.0.0

quokka-vscode
Wal
1.0.174

ReactSnippets
xab
2.2.1

Reproduces only with extensions

丢人现眼 @qq6878

破白菜，垃圾。
本身这个编辑器的功能说明就不如其他。JS编写的会有多高级

@qq6878 I am sorry, the development language of the project is English. Can you please create a new issue in English and please remember to follow the template (i.e. if you have a bug, please be sure to include reproducible steps).

authors: alexandrudima gaoyia qq6878


text:
non obvious sorting in Open Editors view

#6536

see attach gif
from a folder I have two files pinned
from the folder I know preview each file and I don't understand why determines their sort order

@jrieken actually @joaomoreno was also confused by this but I am trying to mimic what a tab folder would do: the fact that an editor is in preview mode means that when you open another preview editor, we close the one you have first and then open the other one +1 to the right of the currently one (that is all "tabs" would open to the right of the currently active one).
In this case it looks weird because one preview editor closes from the end and the other opens to the side.
@stevencl @bgashler1 interested to hear your feedback here if you would expect the preview editor to move or stay at the position.

It is not as much moving it as it is placing it.
I wouldn't find it so weird if any new editor would always open at the end of its group.

I wouldn't find it so weird if any new editor would always open at the end of its group.

that

@joaomoreno @jrieken maybe you could comment on https://github.com/Microsoft/vscode/issues/6812
I am wondering if we should remove the whole idea of showing the preview entry under "opened editors". I think it would fix some issues.

See my comment at https://github.com/Microsoft/vscode/issues/6812#issuecomment-221348884

@stevencl @bgashler1 I wonder if the user has tabs disabled if we should always just open tabs at the end of the list, similar to working files. Because if tabs are not enabled, the only spatial order that you have is the one in opened editors and there it might make more sense to always open at the end.

I would keep away from separate behaviours when certain things are enabled or not. Remember that it has repercussions on others features such as Ctrl Tab.

@joaomoreno actually Ctrl+Tab moves in MRU order, so the spatial order does not make any impact here.

UX meeting outcome: we think we should provide a setting that allows a user to decide where new editors open. We need this already for tabs (to the right of active editor, to the left of active editor) and we could just let this be an enum with more values (to the beginning of all editors, at the end). Setting this to "at the end" would restore pretty much how working files used to behave.

Discussion on settings names continues in https://github.com/Microsoft/vscode/issues/7643

authors: bgashler1 bpasero joaomoreno jrieken


text:
Regression: arrow expanders in Explorer require double-click

Issue Type: Bug
Prior to 1.31.0, if you had workbench.list.openMode set to "doubleClick", you could still single-click the arrows in Explorer to expand/collapse folders. Now you need to double-click them, which seems wrong.
VS Code version: Code 1.31.0 (7c66f58312b48ed8ca4e387ebd9ffe9605332caa, 2019-02-05T22:32:14.164Z)
OS version: Darwin x64 18.2.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3615QM CPU @ 2.30GHz (8 x 2300)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: unavailable_offsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
16, 12, 6

Memory (System)
16.00GB (0.90GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (22)

Extension
Author (truncated)
Version

project-manager
ale
10.3.2

vscode-intelephense-client
bme
0.8.8

npm-intellisense
chr
1.3.0

mustache
daw
1.1.1

vscode-eslint
dba
1.8.0

gitlens
eam
9.5.0

vscode-npm-script
eg2
0.3.5

vscode-powertools
ego
0.19.3

php-debug
fel
1.12.6

svn-scm
joh
1.47.0

vscode-apache
mrm
1.2.0

python
ms-
2019.1.0

csharp
ms-
1.17.1

debugger-for-chrome
msj
4.11.1

java
red
0.38.0

vscode-java-debug
vsc
0.16.0

vscode-java-dependency
vsc
0.3.0

vscode-java-pack
vsc
0.5.0

vscode-java-test
vsc
0.14.0

vscode-maven
vsc
0.14.1

sync-rsync
vsc
0.34.4

jinja
who
0.0.8

/duplicate #68050

authors: jacobweber joaomoreno


text:
Change Stop search button color

This is a suggestion. I just noticed the Stop search button in VSCode during Find in files activity.

VSCode Version: 1.31.1
OS Version: Windows 10 (10.0.17134)

My suggestion is to set the color of the stop button to Red. I use VSCode every minute every day, but never noticed this !
Related issue : #54727

I think the red is too "in your face". As you can see in that issue you found, there was a bunch of back and forth on this already.

authors: kvprasoon roblourens


text:
Restore opened editors broken when the path or directory name changed

Restore opened editors broken when the path or directory name changed.
I have asked this question in many places for more than a year. (in gitter, stackoverflow etc..). But so far, no workaround yet.
I have no ideas why vscode can't save opened editors session inside the project directory, something like <path>/projectDir/.session. I constantly re-structure/move/rename my project directory name. The default restore opened editors behavior just don't work at all.
Thank you very much for your help if you can provide a workaround. I even searched extensions, but no luck so far.
I am sorry that if this is not really a bug report. I really did try to fix this by myself for more than a year before asking here.

@sgon00 you can use a workspace file for that purpose. Doing so will associate the state with that file regardless of the directories within: https://code.visualstudio.com/docs/editor/multi-root-workspaces

@bpasero thanks a lot for your reply. But I still don't figure out how to do it. I have read the link you provided and actually I use workspace for some years now. I have no ideas how to use workspace file to achieve this purpose. I have asked this question for more than a year and no one can answer it online. Can you please teach me what the proper steps are? For example, I tried the following steps which don't work:

Launch vscode with code myProjectDir\
Open some files in vscode (opened editors)
In vscode, File -> Save Workspace As... -> save the file as myProjectDir\myproject.code-workspace
Quit vscode
Change the directory name mv myProjectDir\ myProjectDirNew\
Start a new vscode
In vscode, File -> Open Workspace... -> choose the workspace file myProjectDirNew\myproject.code-workspace
All my previous opened editors session is lost now. Because the directory name is changed and the workspace file actually has no information regarding opened editors.


text:
Debugger variables UI should highlight changed variable values

In Visual Studio, variables shown in the Locals window are marked with a red foreground color when they change between two debugger stop events:

It would be great to also have this functionality in VS Code.  Even better if the debug adapter could send some kind of isChanged field back on individual variables when they are requested.
cc @rkeithhill

+1 for this feature.

If the adapter could send it to VSCode it would be pretty trivial for me to implement this.
Though I have the model on the vscode side so I could also check for the variable change - might not be so trivial since I get all new variables on each stop event and I am not aware what variables existed in the previous step.
@weinand what do you think? On which side should this logic live? Adapter or VSCode

@isidorn I do not have the old state and I do not want to introduce a new model for preserving the old state. Since the UI has the old state by definition (it's visible in the UI), it makes more sense to implement this feature there. In addition we can offload repeated implementations of this feature from debug-adaptor authors.

Makes sense. I can look into this over holidays :santa:

authors: daviwil isidorn rkeithhill weinand


text:
fixes #43687

removes a visual glitch when renaming a file in the explorer
The glitch appears when calling tree.clearHighlight() and disappears when container.removeChild(label.element) is called.

Thanks for the PR. However with your changes I still see the visual glitch on my machine. I actually can not notice the difference with or without your changes. Do they actually help on your machine?
Also did you make sure that your changes do not break https://github.com/Microsoft/vscode/issues/20269
Since I see @joaomoreno has referenced that issue in the code which you are slightly changing?

Ugh, you are right, I'm sorry!
To save you some time on the next version of this PR it will contain animated gifs for:

before and after my fix
before joaos fix, after joao's fix and after my fix

@tsalinger no problem. And no need for the gifs, I'll just try it out on my machine. Thanks a lot

authors: isidorn tsalinger


text:
added uri and sasToken as optional outputs

when files are copied, it's likely other tasks in the work flow need to know where they were copied to and have secure access to them.  Using outputs of the container and sasToken will enable this.  The outputs are only available if the target a blob (not vm) and the vars are provided.

Hi @bmoore-msft, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Brian Moore (AZURE TOOLS)). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Can you do gulp and include the task.loc file as part of your commit.
Can you also update the Readme.md file to reflect the output variable section.

@kmkumaran - updated tasks.loc & readme.md
@pavanadepu2 - yes that cmdlet works with AzureRM storage (storage team didn't rename all the cmdlets like most did)

Looks fine.

This was merged as part of different PR. Closing this PR.

authors: bmoore-msft kmkumaran msftclas

repo: Microsoft/vso-agent-tasks

license: mit

license_source: bigquery


text:
Inject entry point only for project targeting netcoreapp

Issue: https://github.com/Microsoft/vstest/issues/608
Fix: Inject entry point only for project targeting netcoreapp

@Faizan2304,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

repo: Microsoft/vstest


text:
App Service Deploy task fails due to incorrect isMSDeployPackage implementation

The vsts task "Azure App Service deploy" fails when a correct web deploy package has been provided. The error "Error: Source (Manifest) and destination (ContentPath) are not compatible for the given operation" will show up due to the following (generated) msdeploy command:
msdeploy -verb:sync -source:package=package.zip -dest:ContentPath=”azure-site...”
The function below checks whether or not the provided web deployment package is valid:
https://github.com/Microsoft/vsts-tasks/blob/81285d649ed7ed744ef107af55175b9e128a0c04/Tasks/Common/webdeployment-common/utility.ts#L151
It fails when there is no parameters.xml or systeminfo.xml. Due to its implementation, this check is case sensitive: when there is a SystemInfo.xml instead of systeminfo.xml, the function returns false and the command as shown above will bug out.
The proposed solution is to at least include "SystemInfo.xml", but preferably make this check case-insensitive.
a temporary workaround is to create a new msdeploy package. In my case, this leads to extra work, as this package has been provided by a 3rd party.

@arjgupta you added this logic with this PR https://github.com/Microsoft/vsts-tasks/pull/3549/files#diff-a2b5b3ac78f6bfd42fd129f5a0d20787
Any reason why you went with only 2 case-sensitive cases?
Can I make this case insensitive?

I will raise a PR with case insensitive check next week.

The issue is resolved and the fix will be available in upcoming deployment.

authors: BasLijten KrishnaAdityaB vincentdass

repo: Microsoft/vsts-tasks


text:
Implement TokenCache in KurveIdentity

Implement TokenCache class in KurveIdentity.
Export TokenStorage interface in order to support external token storage provided through IdentitySettings.

A new pull request will be created from the southworks:token-cache.

repo: MicrosoftDX/kurvejs


text:
Integration Test - Release - 2021/09/29 16:44:00

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#pri3'

#pri2

#pri3

#assign PRMergerTest1

#assign NonAllowedUser

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

#reassign NonAllowedUser

#reassign PRMergerTest2

#please-close

The following users don't have valid GitHub IDs, or are not collaborators on this repo: nonalloweduser

GitHub user PRMergerTest2 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

repo: MicrosoftDocs/CSIDev-Public


text:
Integration Test - Release - 2019/02/13 12:20:23

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

#assign PRMergerTest1

PRMergerTest1 is not a valid GitHub ID, or is not a collaborator on this repo.


text:
Integration Test - Release - 2021/11/11 17:51:36

Auto create for integration test. IssueCommandFlow

Docs Build status updates of commit f824799:
:warning: Validation status: warnings

File
Status
Preview URL
Details

csidevdocs-public/IntegrationTest/BuildIntegrationTestFiles/ChangeSentToAuthor.md
:warning:Warning

Details

csidevdocs-public/IntegrationTest/BuildIntegrationTestFiles/ChangeSentToAuthor.md

Line 4, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.
Line 4, Column 8: [Warning: duplicate-titles - See documentation] Title 'VS Code Authoring Extension' is duplicated in: 'Demo/demo.md(4,8), Demo/v-caxian/AuthorNotification.md(4,8), Demo/v-caxian/auto-merge.md(4,8), Demo/v-caxian/auto-merger.md(4,8), IntegrationTest/BuildIntegrationTestFiles/ChangeSentToAuthor.md(4,8)'. Titles must be unique within a docset.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


text:
Added missing link to another topic

Added missing link to https://docs.microsoft.com/en-us/intune-user-help/using-your-windows-device-with-intune in the intro paragraph.

@CelesteDG,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

I made this change directly in the live files -- you should see it as early as this afternoon.  Thank you!

authors: CelesteDG msftclas msmbaldwin

repo: MicrosoftDocs/EMDocs


text:
Update unittest-e2etest.md

Fix grammar and syntax errors.

Docs Build status updates of commit 0284e03:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Odata-docs/webapi/unittest-e2etest.md
:warning:Warning
View
Details

Odata-docs/odatalib/v7/fluent-writer-api.md
:warning:Warning
View
Details

Odata-docs/webapi/unittest-e2etest.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.

Odata-docs/odatalib/v7/fluent-writer-api.md

Line 22: [Warning] Link 'https://msdn.microsoft.com/en-us/library/system.action(v=vs.110).aspx' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

repo: MicrosoftDocs/OData-docs


text:
Update set-up-multi-factor-authentication.md

Added Tip about GA access to MFA

@dianef77 @cmcatee-MSFT - Can you please assist to check, approve and merge the content of this PR based on issue #489?
Thank you.

@msbemba Please rewrite as: "Only global admins can enable or disable MFA." Also, there are 2 instances that need to be updated in the topic. Thanks.

@msbemba Please rewrite as: "Only global admins can enable or disable MFA." Also, there are 2 instances that need to be updated in the topic. Thanks.

Thank you, I created another PR https://github.com/MicrosoftDocs/OfficeDocs-O365ITPro/pull/498 adding "Only global admins can enable or disable MFA." on both instances.

authors: cmcatee-MSFT msbemba mypil


text:
Windows Server 2019 Support

is the "Office Online Server last updated November 2018" supporting Windows Server 2019 (current /LTSC)?
I could not find it mentioned in the Articels (only Windows2012R2 and Windows 2016).
It seems to run without resonable issues, but i need a info if or which reelase of WAC will be supported on win2019.
Thank you!

no plans for Windows Server 2019 support

We just installed OOS November 2018 on Windows Server 2019 and it appears to run fine.

won't be supported by Microsoft

I've been setting this up, Windows Server 2019, Sharepoint 2019 and over OOS 2019 on Windows Server 2019 (without the ink and hand writing feature) and didn't work... on the installation process it looks good, but on the SharePoint 2019 portal didn't open any online document... any advise?

authors: Bravecold JasonH-Msft PMSchneider berendengelbrecht


text:
Update project-for-the-web-limits-and-boundaries.md

We had the wrong date range listed for task dates. It does not start at 1/1/1984. It starts at 1/1/2000.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@JohanFreelancer9 do I need to do anything else to get this change published? I'm not familiar with the process. Thanks!

@hocull - Thank you. nothing more is required from your side. @scanum - This PR is ready for final review.

@efrene PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

authors: JohanFreelancer9 hocull scanum

repo: MicrosoftDocs/OfficeDocs-ProjectServer