text:
Update fi.coffee

Coverage remained the same at 56.909% when pulling 90a75095e02d8bc3aa6bcb97b5f0621d7e15680e on VilkkuV:patch-2 into 0c90f63713a146989db01ed57f38b6ce08947478 on codecombat:master.

Hello. Thank you for the translation. Merged.

authors: Bryukh VilkkuV coveralls

repo: codecombat/codecombat


text:
remove new line in the message

As you suggested the code for subscribe back, it is not working , it is not sending a subscription request.

source: gharchive/pull-request

repo: codejamninja/xmpp-ts

license_type: permissive

license_source: github-api


text:
fix error message typo

@chocolateboy thanks!

authors: chocolateboy phpnode

repo: codemix/flow-runtime

license: MIT


text:
On selection ending not over the selection source (start) item the caret goes to the end of the editor into the new default block

duplicates #456

source: gharchive/issue

license_source: bigquery


text:
Concourse devel

not going to use concourse.  be gone!


text:
WU YU‘s Final Homework

老师您好，我是吴钰，以下是我的期末大作业，请查收。（以前的三次平时作业均在前面分别提交）
吴钰 161099142 规定题目（游戏预测）.zip
吴钰 161099142 自选项目.zip


text:
Use CONDA_PREFIX

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Unfortunately, this doesn't work.

authors: basnijholt conda-forge-linter

repo: conda-forge/kwant-feedstock


text:
Update appveyor.yml

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

authors: conda-forge-linter jschueller


text:
Added BMEX Token details in erc20 and images folder

@wenyanwang Hi 上次没过，这次修正，麻烦看看可以了吗？

@wenyanwang 麻烦帮忙看下 👍 💯

@makoshan @wenyanwang LOGO我们现在已经可以在IMToken 1.0看到了，但是代币名称还是BMT12，请问这个Symbol还需要怎么改呢？

repo: consenlabs/token-profile


text:
增加详细信息Hantu

Please provide more info about the token.

authors: JefferShell makoshan


text:
vSwitch restart scenario

fixed

authors: andrejmacak rastislavszabo

repo: contiv/vpp


text:
Add i18n support for using multiple languages.

many better issues created already :)

repo: coppolaemilio/dialogic


text:
Select if nil

Codecov Report

Merging #857 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #857   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          45     45
  Lines        1440   1443    +3
=====================================
+ Hits         1440   1443    +3

Impacted Files
Coverage Δ

app/controllers/projects_controller.rb
100% <100%> (ø)
:arrow_up:

app/models/translations.rb
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c10e9e3...2ac022a. Read the comment docs.

Bah, beat me to it.  I was just about to submit an almost identical PR.  Please change this PR to be forked from master rather than #856, after that, it is good to go.

Also make sure to add "Fixes #854" to your commit message so the issue is automatically close.

I have to fork off #856 on my system, or rake fails.  If I accept #856 first, as I intend, then there will be no problem.

Okay, sounds good, ignore the earlier comment then.

authors: codecov-io david-a-wheeler jdossett

repo: coreinfrastructure/best-practices-badge

license: mit


text:
raft/doc: fix misuse of `for' loop in docs

LGTM

repo: coreos/etcd


text:
Add post about Nashorn require support.

Great post! I like a little post explaining our open source projects.

authors: malaporte wfortin


text:
Move logout into a dropdown under username along with "My profile"

Moved, and moved to right.
The username and profile menu entries are bolded if you're on the profile page.

authors: mattl robmyers

repo: creativecommons/mp


text:
Update hugo 5

Related issue: #2

repo: cristianrcv/personal-website


text:
Round timestamp to upper multiple of 1 000 in points table

@natbraun fixed that :)

authors: iksaif natbraun

repo: criteo/biggraphite


text:
Fix documentation formatting in various classes

@Zavydiel Thanks! This is just the output of running crystal tool format, right?

Yes

Thanks!

authors: Zavydiel asterite

repo: crystal-lang/crystal


text:
可以贴一个完整的配置文件吗？

这是wen.lu的配置, 请参考
server {
  listen 80;
  server_name wen.lu

  resolver 8.8.8.8;
  location / {
    google on;
    google_scholar on;
  }
}

authors: cuber eallion


text:
fix nota retur

Coverage increased (+0.003%) to 78.404% when pulling c5bf88b497fa3cc451272cbf5178425a987ac44f on achensetyawati:master into 2fb795916640639e7d65ecdc041020b1f67d1615 on danliris:master.

authors: achensetyawati coveralls

repo: danliris/dl-module


text:
JAVA-1739 Add host_id and schema_version to node metadata

👍
I amended the commit to use schemaVersion everywhere (was schemaId in a few places) and moved the integration test to a dedicated class (it does not relate directly to schema metadata).

repo: datastax/java-driver


text:
Add support for asynchronous trading

This may not be possible.  This is because the csrf token is single use across all trades.  As soon as the trade stock/option page refreshes, it invalidates the csrf token.
A synchronous task queue that implements threading would probably work best.

Will implement a synchronous trade queue with concurrency using this:
https://gist.github.com/dchrostowski/aea07510fe5e76104eda25d740788a0f


text:
Update _config.yml

Das ist nur eine Übung.

Noch mal...das ist nur eine Übung.

wweew

closes #2

repo: delafuentej/github-pages-with-jekyll


text:
Use Java concurrency ExecutorService for Responder multi-threading

The multi threading is accomplished by initializing the appropriate ThreadPoolExecutor via:
  private void intializeThreadPool() {
    // RejectedExecutionHandler implementation
    RejectedExecutionHandler rejectionHandler = new RejectedExecutionHandlerImpl();
    // Get the ThreadFactory implementation to use
    ThreadFactory threadFactory = Executors.defaultThreadFactory();
    // creating the ThreadPoolExecutor

    _executorPool = new ThreadPoolExecutor(_config
        .getThreadPoolSize(), _config.getThreadPoolSize() + 2, 4, TimeUnit.SECONDS, new ArrayBlockingQueue<Runnable>(_config.getThreadPoolSize() * 2), threadFactory, rejectionHandler);

    // start the monitoring thread
    if (_config.isRunMonitor()) {
      _monitor = new ResponderMonitorThread(this, _executorPool, _config.getMonitorInterval());
      Thread monitorThread = new Thread(_monitor);
      monitorThread.start();
    }

  }

The actual process thread is launched via the following code:
  /**
   * This is where the rubber meets the road. The transport module has
   */
  public void processProbe(ProbeWrapper probe) {
    _executorPool.execute(new ProbeHandlerThread(this, probe, _config.isNoBrowser()));
  }


text:
fix auth captcha

а Travis зачем тут? Тестов-то у нас почти нет

залил изменения

проверяй

проверяй


text:
WIP - Ike fix

Ike Plugins (test-keeper)
Thank you @dipak-pawar for this contribution!
Thank you!!!

/run all

/ok-without-tests

/ok-without-tests

/run test-keeper work-in-progress

/run all

authors: dipak-pawar dipak-pwr

repo: dipak-pawar/ike-prow-plugin-test


text:
add caffe plugin with cmake

Is this compiling caffe together?

@piiswrong Do you mean to want dynamic links?

authors: piiswrong yajiedesign

repo: dmlc/mxnet


text:
Remove ciphers that do not support perfect forward secrecy

LGTM

repo: docker/distribution


text:
[PT-BR] Adds pt-BR protocols lesson - #956

Awesome!  Thank you @pragmaticivan! 👍

authors: doomspork pragmaticivan

repo: doomspork/elixir-school


text:
[WIP] split up dotnet-try

192 files ... I will have to redo the all repo to get back as top contributor after this is merged ....

apparently my approval is just an FYI.  One day I will be permissioned :-)

authors: KevinRansom colombod jonsequitur

repo: dotnet/try


text:
Upgrade to Jersey 2.22

Thanks!

authors: joschi tjcutajar

repo: dropwizard/dropwizard


text:
New installation instructions for CRUX

Thanks!

authors: dylanaraps tudurom

repo: dylanaraps/neofetch


text:
Implement GCP FastCheck upon container start

@r-orzechowski you probably should rebase your changes on master, because of the merge you've made it looks like your PR has 17 commits, which already are in master.

authors: pgutkowski r-orzechowski

repo: dynatrace-oss/dynatrace-gcp-function


text:
Multi-submit example using local[*] instead of env variable master

Note to self, this needs unit testing

repo: ecurtin/spark-bench


text:
Not to be merged till perf tested

This PR fixes the problem reported.

There is no performance drop in "get" latency caused by this PR

test this please

authors: AbfrmBlr kcleereman


text:
A sound should play whenever a bullet connects with a baddie.

I'm leaving this one to you since I don't know how you designed the previous sound effects and they sound good. :)
When you make an impact sound for the baddies could you add it to the impact sound for when a baddie bullet hits the player? Right now it's the pickup "pprring!" which is too happy for a bad thing like losing health.

Also, should the baddies make a sound when they fire? I had them playing the hero's shooting sound originally, but that got annoying since there were so many of them shooting nonstop bullets.

http://github.grumdrig.com/jsfxr/

authors: DavidMcPherson ehgoodenough


text:
Upgrade Undertow version to 2.0.21

Jenkins test this please

Jenkins test this please

Codecov Report

Merging #671 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #671   +/-   ##
=========================================
  Coverage     62.17%   62.17%
  Complexity       68       68
=========================================
  Files           199      199
  Lines          7726     7726
  Branches        948      948
=========================================
  Hits           4804     4804
  Misses         2625     2625
  Partials        297      297

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 590124e...50d5183. Read the comment docs.

authors: codecov-io eyalkoren

repo: elastic/apm-agent-java


text:
Tidy tests

oh damn, that 2.10.6 thing...

meh, I'll merge and that can be a follow up

repo: ensime/ensime-plugin-implicits


text:
1.6.0 deprecation cleanups

Tracking in other issues.

repo: envoyproxy/envoy


text:
stage files

/deploy-monitor

repo: eosho/azure-paas-security


text:
fix: remove unneeded redux dep

:tada: This PR is included in version 1.0.14 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

repo: etclabscore/jade-explorer


text:
v19.0.7 clean validator

[Current coverage][cc-pull] is 100%

Merging [#478][cc-pull] into [master][cc-base-branch] will not change coverage

File ...RequestValidator.php was modified. more

Misses 0
Partials 0
Hits +12

@@           master   #478   diff @@
====================================
  Files          27     27
  Lines         413    432    +19
  Methods       101    110     +9
  Messages        0      0
  Branches        0      0
====================================
+ Hits          413    432    +19
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last updated by [1b51925...ab0cae5][cc-compare]
[cc-base-branch]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/compare/1b51925aeb7b58f6f0ed8ee6fa37953ad258d99c...ab0cae568c638acad90947478834852f21ad8bb7
[cc-pull]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/pull/478?src=pr

authors: codecov-io eugene-matvejev

repo: eugene-matvejev/battleship-game-api


text:
#185 追加修正2

masterへのpull requestはNG

authors: HibikiNanri ta-matsuo

repo: exastro-suite/it-automation


text:
DateInput supports picker only mode, Fixes: #1220

There is a corresponding branch in toolbox for demo purpose, but not intended for merge

This looks good -- glad it was so straightforward.  Sorry I wasn't clearer about the name -- I think I was just trying to bang that ticket in quickly, and was not thinking that would be the name

Let's go for symmetry with the existing  'enablePicker' and call it 'enableTextInput'?
Obviously a bit weird if both were set false, but think that is going to be the most straightforward.

I went ahead and changed the name.
Testing out the formatting, I realized that it didn't look quite right.  It really should not be rendered as disabled.  That implies its fixed -- Its not!  It just should not be editable with the keyboard, thus encouraging/forcing the user to use the button.

10-4 will look at the styling vs disabled edit friday

Looking much better, but still not right.  Right now, if enableTextInput is false, you cannot tab into the control.  Realize this is extremely tricky and sheds light on the fact that our implementation might be seriously wrong for this case.  When enableTextInput is false, I think we just need an independent calendarButton  that is adjacent to a read only Text display, not an embedded icon.
When they are both enabled, might use this new layout as well, or leave the current setup -- its really a matter of which will be easiest to implement and give a consistent look-and-feel.

authors: febbraiod lbwexler

repo: exhi/hoist-react


text:
Don't show the coverage message if the targets are empty

Messages

:book:
Executed 16 tests, with 0 failures (0 unexpected) in 0.440 (0.450) seconds

:book:
Project coverage: 58.89%

DangerSwiftCoverage.framework: Coverage: 74.65

File
Coverage

XcodeBuildCoverageParser.swift
25.0%
⚠

  Generated by :no_entry_sign: Danger Swift against c88647da494bf3ab3ba34f27a571638eaffefd06

Messages

:book:
Project coverage: 58.89%

DangerSwiftCoverage.framework: Coverage: 74.65

File
Coverage

XcodeBuildCoverageParser.swift
25.0%
⚠

  Generated by :no_entry_sign: Danger Swift against c88647da494bf3ab3ba34f27a571638eaffefd06

File
Coverage

Sources/DangerSwiftCoverage/XcodeBuild/XcodeBuildCoverageParser.swift
25.0%
⚠

Tests/DangerSwiftCoverageTests/XcodeBuildCoverageParserTests.swift
100.0%
✅

  Generated by :no_entry_sign: Danger Swift against c88647da494bf3ab3ba34f27a571638eaffefd06

authors: DangerXCodeSummaryBot f-meloni

repo: f-meloni/danger-swift-coverage


text:
Delete README.md

Hello @Clyde369
Thanks for checking out the project!
It seems you're trying to tweak the project for your own use, which doesn't require you to submit changes in the main repo here. You can make whatever change you wish and host it in your own repo.
I'm am going to close the PR, but please feel free to comment if you need any help with anything.
Thanks!

Hello @Clyde369
Thanks for checking out the project!
It seems you're trying to tweak the project for your own use, which doesn't require you to submit changes in the main repo here. You can make whatever change you wish and host it in your own repo.
I'm am going to close the PR, but please feel free to comment if you need any help with anything.
Thanks!

repo: faahim/happy-birthday


text:
Add bitbucket support

For example I would like to run
howfairis https://bitbucket.org/bitbucketpipelines/bitbucket-pipes-toolkit
Checking compliance with fair-software.eu...
url: https://bitbucket.org/bitbucketpipelines/bitbucket-pipes-toolkit
AssertionError: Repository should be on github.com or on gitlab.com

without getting an error.

For example I would like to run
howfairis https://bitbucket.org/bitbucketpipelines/bitbucket-pipes-toolkit
Checking compliance with fair-software.eu...
url: https://bitbucket.org/bitbucketpipelines/bitbucket-pipes-toolkit
AssertionError: Repository should be on github.com or on gitlab.com

without getting an error.

authors: jspaaks sverhoeven

repo: fair-software/howfairis


text:
Is their a vue component of this project ?

Let me check it out 👍  🥇

repo: fangpenlin/avataaars-geneator


text:
Supply version bump

:gem: :sparkles:

authors: asfalcone mfurtak

repo: fastlane/fastlane


text:
US28-CreatePrescriptionRecommendations

Coverage increased (+0.003%) to 93.529% when pulling 58389567e82f2da695764be73cc228be5399abf4 on devel into eed34fab7bf4f1aeeb8fa2dddd23b1c67f3fab02 on master.

authors: coveralls joaopaulonsoares


text:
Uc10 dgo

Coverage decreased (-0.6%) to 5.323% when pulling 9dcf08e5694842ad96d5d2a62568a3ddd239f595 on uc10-dgo into 9108eb6adf2ef54c85296a0ca16c0fe6473b12e9 on master.


text:
Embed NfcAdapter handling into TagDispatcher

@miguelcardo I realized we can simplify the integration a lot more by hiding the NfcAdapter handling in the tag dispatcher. Ready for review!

@petter-fidesmo :+1: Nice lesson on how to simplify life for library users!

authors: miguelcardo petter-fidesmo

repo: fidesmo/nordpol


text:
Add support for the SteelSeries Rival 700

Hello, released in rivalcfg 3.10.0, thank you :)

authors: flozz nixtux

repo: flozz/rivalcfg

license: WTFPL


text:
[WIP] Webview test ci failure

seems a flake unstream, closing the PR

repo: flutter/plugins


text:
App Crashes when scrolling through speakers list

#82

repo: fossasia/open-event-android


text:
Bool column should return empty string when null is given on input

@fsi-open

@fsi-open

repo: fsi-open/datagrid


text:
Store version number in init.py

Manually merged

authors: jdemeyer markuspf

repo: gap-packages/jupyter-gap


text:
fix #1627, refine on custom serialization doc.

+1.

authors: clockfly whjiang

repo: gearpump/gearpump


text:
Add a non panicing version of CoordTransform::transform_coord

Also could we use the OGRError for this and/or get more information from GDAL similar, to the methods in src/utils.rs?

I did not found any function to gain more informations from gdal why the transformation is not possible.

I will look a bit further into this. It should be possible to use utils::_last_cpl_error to get more information from GDAL. But i'm not sure if this is always the case.
This code:
    let wgs84 = SpatialRef::from_epsg(4326).unwrap();
    let webmercator = SpatialRef::from_epsg(3857).unwrap();

    let mut x = [1000000.0];
    let mut y = [1000000.0];
    let mut z = [0.0, 0.0];

    let trafo = CoordTransform::new(&wgs84, &webmercator).unwrap();
    let r = trafo.transform_coord(&mut x, &mut y, &mut z);
    println!("{:?}", r);
    let err = _last_cpl_err(CPLErr::CE_Failure);
    println!("{}", err);

creates:
CPL error class: 'CE_Failure', error number: '1', error msg: 'latitude or longitude exceeded limits'

However, your example creates no CPL errors :(

Any news on this?

Let's merge this and adapt it if needed :)

authors: jdroenner weiznich

repo: georust/rust-gdal


text:
Scheduler: Potential issue with run_at and plugins injecting their scheduling

Not a Grav bug, was a problem in rsync plugin

repo: getgrav/grav


text:
Handles a user-defined error that was not inherited from Error.prototype (#316)

Hi. Only the commit 3df90fccbc69e8434cd4bb10aea6cd3bae1ecd6c needs to be merged. As I need the fix, I will be using my fork until this commit has some feedback.

Unfortunately this is not correct Error implementation, as it completely loses stack property of an error. This change will break desired behaviour when someone throws an object literal (which sometimes happen), by stringifying it before passing to an Error constructor (line 328).
If we'd need a feature like this, we'd need to make sure that every error has a specific interface (code, message, stack) and follows specific convention. More on this here: https://gist.github.com/slavafomin/b164e3e710a6fc9352c934b9073e7216
Closing for now, but please feel free to reopen if you'd want to continue the discussion.

authors: gnumoksha kamilogorek

repo: getsentry/raven-node


text:
Fix typo

Thanks!

authors: cblp vaibhavsagar

repo: gibiansky/IHaskell


text:
Gidztrill patch 1

Created a file

repo: gidztrill/github-slideshow


text:
Add images links

[ ]  add name placeholder to portfolio
[ ]  Add placeholders for images and links
[ ]  Add location placeholder for tags
[ ]  Add comment placeholder for feedback

[ ]  add name placeholder to portfolio
[ ]  Add placeholders for images and links
[ ]  Add location placeholder for tags
[ ]  Add comment placeholder for feedback

Good

Good

repo: gitgaZa/markdown-portfolio


text:
Catch up upstream and migrate to v1 module

Sorry, wrong target :)

repo: go-playground/form


text:
Spatial, Transform and Transform2D documentation tweaks

@akien-mga pushed changes.

repo: godotengine/godot


text:
Remove $LOAD_PATH.unshift(*) and $LOAD_PATH.uniq! from spec/spec_helper.rb because they do nothing

I signed it!

I think you also need to update .travis.yml to change the test command to 'bundler rake spec:all'. It was removed a long time ago due to some other issues running through bundler on travis, but it's likely a non issue these days (and we're now forcing a bundler update each time too.)

sqrrrl
thanks for the advice :)

authors: sqrrrl ysksn

repo: google/google-api-ruby-client


text:
Add participant details

@googlebot I signed it!

repo: google/season-of-docs


text:
NodeJS: Copy .proto files on gapic generation

Where is the artifacts section of the circleci report?

I am confused how circleci artifacts work, as I don't see consistent report in my experience.
Since your change is simple, the error report is good enough, and you only need to add one line into library_example.golden.
"

  assert expected == set(actual), \

        "Check the actual output at %s" % actual_output_file

E       AssertionError: Check the actual output at /usr/src/artman/test/golden/actual_library_example.golden
E       assert {'/csharp/goo...Grpc.cs', ...} == {'/csharp/goog...Grpc.cs', ...}
E         Extra items in the right set:
E         '/js/library_example-v1/proto/google/example/library/v1/library.proto'
E         Use -v to get the full diff
"

@ethanbao Where is the artifacts section of the circleci report?

authors: eoogbe ethanbao lukesneeringer

repo: googleapis/artman


text:
Help - How to convert instrumented code to coverage object?

Sorry... I was running tests in node-webkit. The coverage object was created in the window.coverage. But I was looking in global.coverage
Closing this issue.
Thanks

repo: gotwarlost/istanbul


text:
Added JCenter to samples

@jbaruch Thanks for making our documentation more complete. I don't have to tell you how important it is for the users to know about jcenter. :smile:
Thanks again,
Pepper

Cheers!

authors: eljobe jbaruch

repo: gradle/gradle


text:
Address two performance issues with relational schema

Addressed review comments and rebased to latest master

repo: graphprotocol/graph-node


text:
Blanket suppress protobuf from ubsan runs

ping

repo: grpc/grpc


text:
Suggestion: Search Input boxes also

One would need to add handling for the value attribute in <input> elements in https://github.com/gsingh93/regex-search/blob/master/src/content/content.ts#L107

authors: ComFreek googolydox


text:
Submitting Italian translations

:heart: 🇮🇹
Thanks, this looks good to me. Bonus points for even finding this repo.

Whoops, just noticed this didn't get merged. I'll get this into the next version. Sorry about that.

hehehe no problem,
thanks, all the best
Giovanni Di Maggio
www.giodimaggio.com http://www.giodimaggio.com/
it.linkedin.com/in/giovannidimaggio1/
http://it.linkedin.com/in/giovannidimaggio1/
2016-07-29 22:19 GMT+02:00 Cameron McEfee notifications@github.com:

Whoops, just noticed this didn't get merged. I'll get this into the next
version. Sorry about that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/guideguide/messages/pull/20#issuecomment-236283251,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWdTvhV-S2cpU1TGgIql8hzoXdUd25Mks5qamBKgaJpZM4INlyU
.

authors: cameronmcefee zovanni

repo: guideguide/messages


text:
Add PHP versions to version guidance in README.md

Thank you for your contribution. Can you please take a look at my comment above? After that I am happy to merge it.

@sagikazarmark Fixed!

Awesome, thank you very much.

authors: sagikazarmark swordbeta

repo: guzzle/guzzle


text:
Develop

Hello @gwenchee! Thanks for submitting the PR.

In the file d3ploy/supply_driven_deployment_inst.py, following are the PEP8 issues :

Line 57:80: E501 line too long (84 > 79 characters)
Line 138:80: E501 line too long (86 > 79 characters)
Line 145:80: E501 line too long (94 > 79 characters)
Line 149:80: E501 line too long (85 > 79 characters)
Line 158:80: E501 line too long (83 > 79 characters)
Line 159:80: E501 line too long (80 > 79 characters)
Line 164:80: E501 line too long (83 > 79 characters)
Line 165:80: E501 line too long (80 > 79 characters)
Line 186:80: E501 line too long (108 > 79 characters)
Line 187:80: E501 line too long (86 > 79 characters)
Line 198:80: E501 line too long (83 > 79 characters)
Line 214:80: E501 line too long (90 > 79 characters)
Line 240:80: E501 line too long (86 > 79 characters)
Line 242:80: E501 line too long (84 > 79 characters)
Line 243:80: E501 line too long (81 > 79 characters)
Line 244:80: E501 line too long (82 > 79 characters)
Line 245:80: E501 line too long (86 > 79 characters)
Line 246:80: E501 line too long (81 > 79 characters)
Line 249:80: E501 line too long (86 > 79 characters)
Line 258:80: E501 line too long (82 > 79 characters)
Line 260:80: E501 line too long (82 > 79 characters)
Line 262:80: E501 line too long (82 > 79 characters)
Line 263:80: E501 line too long (82 > 79 characters)
Line 267:80: E501 line too long (82 > 79 characters)

In the file d3ploy/tester.py, following are the PEP8 issues :

Line 32:51: W291 trailing whitespace
Line 33:52: W291 trailing whitespace
Line 34:58: W291 trailing whitespace
Line 35:23: W291 trailing whitespace
Line 37:28: W291 trailing whitespace
Line 41:32: W291 trailing whitespace
Line 42:41: W291 trailing whitespace
Line 43:34: W291 trailing whitespace
Line 82:20: W291 trailing whitespace
Line 86:51: W291 trailing whitespace
Line 87:52: W291 trailing whitespace
Line 88:45: W291 trailing whitespace
Line 90:32: W291 trailing whitespace
Line 94:32: W291 trailing whitespace
Line 95:34: W291 trailing whitespace
Line 96:69: W291 trailing whitespace
Line 97:45: W291 trailing whitespace
Line 109:22: W291 trailing whitespace
Line 111:10: W291 trailing whitespace
Line 149:1: E303 too many blank lines (3)
Line 150:45: W291 trailing whitespace
Line 159:59: W291 trailing whitespace
Line 160:42: W291 trailing whitespace
Line 192:45: W291 trailing whitespace
Line 201:59: W291 trailing whitespace
Line 202:42: W291 trailing whitespace
Line 221:54: W291 trailing whitespace
Line 222:17: W291 trailing whitespace
Line 231:57: W291 trailing whitespace
Line 232:17: W291 trailing whitespace
Line 250:10: W291 trailing whitespace
Line 252:24: W291 trailing whitespace
Line 256:54: W291 trailing whitespace
Line 257:17: W291 trailing whitespace
Line 261:58: W291 trailing whitespace
Line 263:58: W291 trailing whitespace
Line 264:33: W291 trailing whitespace
Line 268:57: W291 trailing whitespace
Line 269:47: W291 trailing whitespace
Line 281:21: E231 missing whitespace after ','
Line 281:33: E231 missing whitespace after ','
Line 281:45: E231 missing whitespace after ','
Line 281:52: E231 missing whitespace after ','
Line 283:48: E231 missing whitespace after ','
Line 284:19: W291 trailing whitespace
Line 291:80: E501 line too long (98 > 79 characters)
Line 295:1: E302 expected 2 blank lines, found 1
Line 302:80: E501 line too long (109 > 79 characters)
Line 302:93: E225 missing whitespace around operator
Line 306:80: E501 line too long (104 > 79 characters)
Line 307:63: E225 missing whitespace around operator
Line 309:9: E722 do not use bare 'except'
Line 311:80: E501 line too long (83 > 79 characters)
Line 314:1: E302 expected 2 blank lines, found 1
Line 325:1: W391 blank line at end of file

In the file d3ploy/timeseries_inst.py, following are the PEP8 issues :

Line 42:80: E501 line too long (85 > 79 characters)
Line 48:80: E501 line too long (86 > 79 characters)
Line 49:80: E501 line too long (82 > 79 characters)
Line 56:80: E501 line too long (91 > 79 characters)
Line 57:80: E501 line too long (89 > 79 characters)
Line 59:80: E501 line too long (84 > 79 characters)
Line 80:80: E501 line too long (80 > 79 characters)
Line 147:80: E501 line too long (86 > 79 characters)
Line 153:80: E501 line too long (87 > 79 characters)
Line 157:80: E501 line too long (85 > 79 characters)
Line 166:80: E501 line too long (83 > 79 characters)
Line 167:80: E501 line too long (80 > 79 characters)
Line 172:80: E501 line too long (83 > 79 characters)
Line 173:80: E501 line too long (80 > 79 characters)
Line 198:80: E501 line too long (108 > 79 characters)
Line 199:80: E501 line too long (84 > 79 characters)
Line 210:80: E501 line too long (83 > 79 characters)
Line 226:80: E501 line too long (88 > 79 characters)
Line 252:80: E501 line too long (82 > 79 characters)
Line 254:80: E501 line too long (80 > 79 characters)
Line 256:80: E501 line too long (82 > 79 characters)
Line 257:80: E501 line too long (82 > 79 characters)
Line 261:80: E501 line too long (82 > 79 characters)
Line 274:80: E501 line too long (86 > 79 characters)
Line 276:80: E501 line too long (84 > 79 characters)
Line 277:80: E501 line too long (83 > 79 characters)
Line 278:80: E501 line too long (86 > 79 characters)
Line 279:80: E501 line too long (86 > 79 characters)
Line 280:80: E501 line too long (83 > 79 characters)
Line 283:80: E501 line too long (86 > 79 characters)


text:
Fix README.md typos

Closed.

authors: FrankHossfeld jnehlmeier

repo: gwtproject/gwt-dom-style-definitions


text:
华为8.1,dialog沉浸状态栏会有灰底  不是透明

具体手机型号是多少？

华为 mate10 pro  emui8.1

demo测试了，没发现灰低呀，看图

现在有个新问题  状态栏颜色变不了  始终是白色  dialog中

authors: GeneralZMX gyf-dev

repo: gyf-dev/ImmersionBar


text:
Poprawa diagramów przypadków użycia. Równoległe pisanie scenariuszy.

Podsystem uwierzytelniania:

[ ]  UC-PU-01 - Zarejestruj się - @gzacharski
[ ]  UC-PU-02 - Zaloguj się - @bartoszkordek @gzacharski
[ ]  UC-PU-03 - Aktywuj konto - @bartoszkordek
[ ]  UC-PU-04 - Resetuj hasło - @bartoszkordek
[ ]  UC-PU-05 - Wyloguj się - @bartoszkordek

Podsystem zarządzania zajęciami:

[ ]  UC-PZZ-01 - Obejrzyj grafik
[ ]  UC-PZZ-02.1 - Rezerwuj zajęcia grupowe
[ ]  UC-PZZ-02.2 - Rezerwuj zajęcia indywidualne
[ ]  UC-PZZ-03 - Dołącz do listy rezerwowej
[ ]  UC-PZZ-04 - Anuluj rezerwację
[ ]  UC-PZZ-05 - Oceń zajęcia.
[ ]  UC-PZZ-06 - Zarządzaj zajęciami
[ ]  UC-PZZ-07 - Odpowiedz na zajęcia indywidualne
[ ]  UC-PZZ-08 - Obsługa grafiku
[ ]  UC-PZZ-09 - Odwołaj zajęcia

Podsystem organizacji placówki:

[ ]  UC-POP-01 - Przyjmij zadanie
[ ]  UC-POP-02 - Zleć zadanie
[ ]  UC-POP-03 - Wyświetl zlecone zadania
[ ]  UC-POP-04 - Modyfikuj zadanie
[ ]  UC-POP-05 - Raportuj wykonanie
[ ]  UC-POP-06 - Weryfikuj raport

Podsystem zarządzania karnetami
[] UC-PZK-01 - Modyfikuj ofertę karnetów
[] UC-PZK-02 - Pokaż statystyki
[] UC-PZK-03 - Twórz statystyki
[] UC-PZK-04 - Zakup karnet
[] UC-PZK-05 - Sprawdź ważność karnetu
[] UC-PZK-06 - Pokaż historię karnetów
[] UC-PZK-07 - Zawieś karnet

Podsystem zarządzania sprzętem:

[ ]  UC-PZS-01 - Pokaż sprzęt
[ ]  UC-PZS-02 - Wystaw ocenę
[ ]  UC-PZS-03 - Obsługa rezerwacji sprzętu
[ ]  UC-PZS-04 - Pokaż grafik rezerwacji
[ ]  UC-PZS-05 - Obsługa rejestru sprzętu
[ ]  UC-PZS-06 - Modyfikuj grafik rezerwacji

Podsystem zarządzania kontem:

[ ] UC-PZKo-01 - Ustaw awatar
[ ] UC-PZKo-02 - Zmień hasło
[ ] UC-PZKo-03 - Modyfikuj dane osobowe
[ ] UC-PZKo-04 - Usuń konto
[ ] UC-PZKo-05 - Pokaż statystyki i dziennik aktywności
[ ] UC-PZKo-06 - Modyfikuj ustawienia i prywatność konta
[ ] UC-PZKo-07 - Obsługa konta

Podsystem komunikacji:

[ ] UC-PK-01 - Przeglądaj historię wiadomości
[ ] UC-PK-02 - Wyślij i odbierz wiadomość
[ ] UC-PK-03 - Wyświetl powiadomienia

Podsystem administratora

[ ] UC-PA-01 - Pokaż logi
[ ] UC-PA-02 - Pokaż statystyki
[ ] UC-PA-03 - Utwórz kopię zapasową
[ ] UC-PA-04 - Archiwizuj dane
[ ] UC-PA-05 - Konfiguruj serwisy
[ ] UC-PA-06 - Zarządzanie rejestrem kont

authors: bartoszkordek gzacharski

repo: gzacharski/AGH-praca-inzynierska


text:
Update README

thx

authors: KevinZonda raptazure


text:
Add Kamereon client

@Quentame it was planned for future use (when the ResponseData shemas are expanded)
I think it's ok to remove for now, and add again later.

Or then 👌

authors: Quentame epenet

repo: hacf-fr/renault-api


text:
Add Makefile

lgtm

authors: nancywong sandlerben


text:
How to modify event target element in Hammer.JS?

Closing for lack of details for the problem and because modifying the element targeted by an event should not be done.

authors: farhoudz runspired


text:
Add config generator

Looks good, I'll go ahead and merge this and close #4

authors: MuriloucoLouco hannesfant

repo: hannesfant/sharex-uploader


text:
Issue/53 node search

@ganeshx please do me a favor and resolve the conflicts as well. I accepted your PRs in order but there are still conflicts and I cannot resolve easily with the code in it's current state. Thank you.

I mentioned in a previous PR that I would no longer accept wildly uncommented PRs.

I did not know about this. I had to go back and look at closed PRs one by one to see where you mentioned this.
Looks like you added review comments in PR #72 and then closed the PR immediately after that. I had no Ideas you had commented because I don't look at closed PRs unless there is a reason.

Please address the requested changes and use the change request as a pattern for future PRs. It's hard to apply exact rules for this, but here are some good guidelines for when you need a comment:
if you define a function. Maybe single line, well named functions don't need a comment but you should be commenting almost all your functions.

Not needed for the most part unless we are developing a library (which is not the case here) as long as function name is self explanatory.

if you have a non human-readable if statement, please comment it
comment any regex to explain the pattern to a human
comment any complex state changes. If you reset a global variable, please explain what you're doing.
Lastly, I will never accept a PR without a description. Please ensure your PRs include:
description of the PR purpose (what feature are you adding or bug are you fixing)
list of high level changes
a link to the github issue you're addressing
add any notes about any special circumstances or new issues you've found.
Thank you for your hard work to add this code and I look forward to accepting it after you've made the requested changes.

authors: ganeshx randypitcherii

repo: hashmapinc/snowflake-inspector


text:
Show how to update the plugin

Coverage remained the same at 80.244% when pulling 0ffca41a8f67ef1a7901d8341574cc643f7c9e85 on ravage84:patch-1 into fb6724d5ee81c96bebd2255175d8c364ac9301e3 on hirak:master.

composer require should always work, though one might want to use it with caution as SemVer allows breaking changes in minor versions below 1.0.0.

repo: hirak/prestissimo


text:
Adding vega_datasets to environment.yml

Add vega_datasets to environment.yml


text:
Cleanup runv start

LGTM

authors: gao-feng laijs

repo: hyperhq/runv


text:
report count of cache entries

lgtm

repo: i-love-flamingo/httpcache


text:
Flip the product ordering (newest first/last)

Closing since this is a frontend issue, the backend behaves as expected.

repo: illright/innopoints-backend


text:
Can't add a look on the config with python

PyOpenColorIO.Config.addLook() which is passed a Look object:
Look
class PyOpenColorIO.Look
The Look is an ‘artistic’ image modification, in a specified image state.
The processSpace defines the ColorSpace the image is required to be in, for the math to apply correctly.
Methods:
createEditableCopy
getName
getProcessSpace
getTransform
isEditable
setName
setProcessSpace
setTransform

The config object for getLook returns strings, not look objects. Looks don't seem to have any way to be constructed or obtained as object.

getLooks() returns a list of strings for the current looks, getLook(str) returns a Look object.

Please document

These are documented on the website here: http://opencolorio.org/developers/bindings/PythonAPI.html
As such:
getLook
getLook(str)
Returns the information of a specified look in PyOpenColorIO.Config.
Parameters: str (string) – look
Returns: specified look
Return type: look object
getLooks
getLooks()
Returns a list of all the looks defined in PyOpenColorIO.Config.
Returns: looks
Return type: tuple of look objects

authors: pyalot scoopxyz

repo: imageworks/OpenColorIO


text:
Feature first steps

Coverage increased (+100.0%) to 100.0% when pulling 657da95bc7a61657f78c644e8336a716bff99442 on jimdelois:feature-first-steps into 4068ad6e2b9dc611427ffe9b87393c32bb1e73b2 on improvframework:master.

Coverage increased (+100.0%) to 100.0% when pulling de8998af7a4d6abdc986abaf837b30a8d0faef06 on jimdelois:feature-first-steps into 4068ad6e2b9dc611427ffe9b87393c32bb1e73b2 on improvframework:master.

authors: coveralls jimdelois

repo: improvframework/configuration


text:
Node.js: Add node 8 and npm 5 support

Thanks the update! Can you explain why you exclude npm from the build image in ca0417b1c77a8aebe05e95cf40bf55ea01114a1b?
This causes a QA error during package as the node_modules files as /usr/lib/node_modules is not included FILES.
What's more, let me just give my two cents. On a freshly installed ubuntu 16.04.3 (no GUI), I had to install a few packages for do_compile to succeed:
dpkg --add-architecture i386 && apt-get update
apt-get install lib32z1-dev libssl-dev:i386 gcc-multilib g++-multilib

I don't understand myself why I needed i386 headers, but I would get a linker error without them.

ca0417b was for personal interest. I did not realize it would append to the pull request. I'll revert that commit.

Can we finalize this pull request?

I second that^

all good?

Could we please merge this?  The lts version of node has changed.

@imyller  We need you man!

FYI: os.popen is deprecated (used in npm-base.bbclass) in python 2.6 and subprocess module should be used instead. Also, npm_get_version in npm-base.bbclass leaves file open which will produce warning during build.
I fixed this as below patch suggests:
diff --git a/classes/npm-base.bbclass b/classes/npm-base.bbclass
index b545225..b40f241 100644
--- a/classes/npm-base.bbclass
+++ b/classes/npm-base.bbclass
@@ -19,10 +19,6 @@ NPM_FLAGS ?= ""

 NPM_FLAGS_append_class-nativesdk = " --unsafe-perm"

-def npm_get_version():
-    import os
-    return os.popen("npm --v").read().split('.')
-
 # Target npm

 oe_runnpm() {
@@ -66,7 +62,8 @@ oe_runnpm() {

        export HOME="${NPM_HOME_DIR}"

-       if [ "${@npm_get_version()[0]}" = "5" ]; then
+
+       if [ "$(echo ${NPM_VERSION} | cut -d. -f1)" = "5" ]; then
                NPM_CACHE_CMD="verify"
        fi

@@ -128,7 +125,7 @@ oe_runnpm_native() {

        export HOME="${NPM_HOME_DIR_NATIVE}"

-       if [ "${@npm_get_version()[0]}" = "5" ]; then
+       if [ "$(echo ${NPM_VERSION} | cut -d. -f1)" = "5" ]; then
                NPM_CACHE_CMD="verify"
        fi

Is this repository still actively maintained or should people be using some replacement?

Doesn't seem to be very active apart from thirdparty contributors.

Which is okay. I'm just wondering whether this is still the official nodejs layer repo, given that this PR is pending since 8 month.

I maintain a fairly up to date PR and fork of this repo. Other than that the author of this repo has gone quiet for some time.

+1

@zonque there is no 'official' nodejs layer. This is the one though. Perhaps the author can authorization some other participants for maintaining this repository.

There is some support for nodejs in openembedded-core. npm class seems to be quite much the same as in here. Also, devtool is supporting npm packages at least for some extent. I am investigating currently if i could start using devtool and openembedded-core npm class.

Guys, should we contact Node.js Foundation in order to create an oficial layer?

@mitorn Did your investigations have any success?

@mitorn The npm.bbclass in core use the bitbake fetcher to fetch all dependency. To use it devtool is pretty much a must as otherwise the dependency management is way to much work.
The classes in this layer are much simpler and they rely on npm to fetch everything. They do not use the bitbake fetcher mechanism and thus you can't cache/archive the downloads the way you normally do with bitbake. An "advantage" is that you do not need to specify all the dependency at the bitbake level. This might be easier in some cases especially when used with a local npm mirror.
@deinok Is there a need for a seperate layer. The latest LTS (8.x) version is also available in meta-openembedded. If somebody would be willing to maintain it I think it would also be possible to have the Latest (10.x) available as a recipe too.

@keeslinp we haven't had time lately to test devtool based npm fetcher. It would be quite feasible for us since it does bitbake license management instead of creating your own. There was open questions at least about locking commits (can we trust package-lock-.json for example).
@bachp we would like to use npm.bbclass because of the license handling which i think this layer does not provide.

authors: aaronovz1 bachp deinok keeslinp malikolivier mbbauer mitorn ninox92 zonque

repo: imyller/meta-nodejs


text:
Refactor

looks good to me!

authors: bmoberly jhoerr

repo: indiana-university/itpro-app


text:
show unclaimed vita in claim button

Can you please add more details? How to check the unclaimed vita?

	{
		"constant": true,
		"inputs": [
			{
				"name": "owner",
				"type": "address"
			}
		],
		"name": "claimableAmount",
		"outputs": [
			{
				"name": "",
				"type": "uint256"
			}
		],
		"payable": false,
		"stateMutability": "view",
		"type": "function"
	},

in https://github.com/iotexproject/IoTeXVitaTokenContract/blob/master/abi.json

@guo  could you please add more description?

@gyanpgupta you need to implement the claimableAmount in vita.ts method like https://github.com/iotexproject/iotex-explorer/blob/effb9807ea9ea6ae9476fc7eccc3a705d8a85ed7/src/erc20/vita.ts#L73
That method response a big Number for the unclaimed amount. Check if that response greater than 0 and show that as badge for the claim button.

authors: guo gyanpgupta nmhung1210 raullenchai

repo: iotexproject/iotex-explorer


text:
No need to setup local test env

@sebastienvas: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
9bb253a743679b6cf65b75fa884b55310175a22a
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai I am not sure yet. This did not improve much.
@costinm I think I agree with you, we are still mounting the kubeconfig so I did not know if this was a mistake or not.

closing this in favor of https://github.com/istio/test-infra/pull/834

authors: istio-testing sebastienvas

repo: istio/istio


text:
Istio quickstart

Want A/B as quickstart


text:
Fix typo

Thanks.

authors: itsjamie njuettner

repo: itsjamie/gin-cors


text:
complete Type.intersection/2

completed here https://github.com/ityonemo/mavis/commit/ee809881faab345efe4e10171890e1b7dbf15fff

repo: ityonemo/mavis


text:
Inheritancefree

build will fail until plungin PRs are merged:

https://github.com/iwillfailyou/java-plugin-gradle/pull/13
https://github.com/iwillfailyou/java-plugin-maven/pull/10

repo: iwillfailyou/service


text:
Implementar na API o CRUD de User com DjangoRest

Como vai funcionar o cadastro de usuários? Forneceremos um código de verificação para que apenas pessoas selecionadas possam realizar o cadastro ou iremos fazer de outra forma?

Eu pensei em inserir um adm em cada cidade, fazendo isso como superuser do sistema. E aí o cadastro de usuários pode ser feito pelos admin das cidades. Para acessar as

Eu sei que o djangorest fornece rotas para autenticar, mas nunca utilizei, deve ser simples. Se quiser pegar a issue, assina ela pra você e dá uma olhada nisso


text:
Add ability to switch color back to normal

Oh, is this issue about the same problem that I reported in https://github.com/jam1garner/owo-colors/issues/6?

Oh, is this issue about the same problem that I have reported in https://github.com/jam1garner/owo-colors/issues/6?

Ah yep! Will close this as a duplicate


text:
Use Dagger 2 for Rest services

I rewrote the REST services to be injected through Dagger 2.
I added NetworkModule.java, (interface)Repository.java , GiphyService.java and removed ServiceUtil.java
Repository is injected so now

//MainFragment, Field Injection
@Inject Repository mRepository
...
...
...

void loadTrendingImages(){
loadImages(mRepository.getTrendingResults())
}

GiphyService implements repository and the lower abstraction methods are now private

//Constructor injection
@Inject
public GiphyService(String accessToken, GiphyApiService service){...}
@Override
public Observable getTrendingResults(){
return getTrendingResults(mAccessToken);
// and lower abstractions such as limits, searches etc.
}

However I did not rewrite the GiphyServiceTest since I'm not yet totally sure how to do it with Dagger, but I'm working on learning it. If you know how to do it feel free to fix it
In the meantime you can check my fork [here] (https://github.com/egenvall/android-glide-giphy-example) if you want

Ok cool. I will check it out!

authors: egenvall jaredsburrows


text:
implemented solving primitive types in signature of Javassist methods

This one should be straight forward, so I don't think that it'll need a review. Merging now.

repo: javaparser/javasymbolsolver


text:
Don't stop the rest of sign out requests if one fails

@stsewd looks good to me. Could you please rebase on current master to force a new travis check?

authors: manelclos stsewd

repo: jbittel/django-mama-cas


text:
Fix Travis errors

@mxxcon Done, done and done

@jamcat22 done and done.
Btw, does anyone know a good text editor for Debian?

Sublime is pretty good and pleasant to use. It has decent yaml syntax highlighting.

Reviewed 1 of 7 files at r1, 3 of 3 files at r2, 1 of 1 files at r3, 2 of 2 files at r5.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

Comments from the review on Reviewable.io

Terminal: I use vim. Graphical: I use Sublime 3, but I've heard good things about Atom.

Reviewed 2 of 2 files at r5.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

Comments from the review on Reviewable.io

Great! Using Sublime 3 now. :smiley:

looks-good to me!

repo: jdavis/twofactorauth


text:
Context

Codecov Report

Merging #18 into master will decrease coverage by 0.61%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   78.71%   78.09%   -0.62%
==========================================
  Files          12       12
  Lines         653      525     -128
==========================================
- Hits          514      410     -104
+ Misses        100       82      -18
+ Partials       39       33       -6

Impacted Files
Coverage Δ

main.go
93.54% <ø> (ø)
:arrow_up:

event.go
100% <100%> (+8.57%)
:arrow_up:

group.go
73.39% <77.27%> (-1.94%)
:arrow_down:

middleware/main.go
82.6% <80%> (+6.6%)
:arrow_up:

command.go
78.18% <86.2%> (-0.17%)
:arrow_down:

writer.go
69.84% <0%> (+2.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec4628...0fc38f5. Read the comment docs.

authors: codecov-io jeroenrinzema

repo: jeroenrinzema/commander


text:
No menu functionality yet

Some menu functionality is working - our main application uses a toolbar masquarading as a menu, so this seems to be causing issues

authors: markhumphreysjhc mmarquee

repo: jhc-systems/DelphiUIAutomation


text:
Update Headers for 2021

Deprecated project but it can be merged

Deprecated project but it can be merged

authors: DanielFran pascalgrimaud

repo: jhipster/ng-jhipster


text:
no-op change to trigger Travis

got what I needed.

repo: jlaska/pytest-github


text:
add jinja2-time to environment for template generation

Coverage increased (+0.007%) to 92.577% when pulling 84cc918720ec05fb4cdaa560484f500045b854e2 on enhacement/jinja2_time into 547166ef335d892d2f8097bb4d78d8f3009e8011 on master.

authors: coveralls jlmadurga

repo: jlmadurga/permabots


text:
Fix mikes mess up with READMEs

checked through readme's and fixed them.


text:
Update README.md

Merged

repo: johnsonjh/jleveldb


text:
--system-info about the atp

Closed 376608a3edf9713058e8d9b632d41fafe7c16fac

repo: jonaprieto/online-atps


text:
Add isEmpty property to check if there is anything or not

Thanks! Looks great.

authors: jonasman letko-dmitry

repo: jonasman/MulticastDelegate


text:
ptvim as pip package

I justed released this on pypi. It's public now! :)

:tada:

authors: jonathanslenders juanpabloaj

repo: jonathanslenders/pyvim


text: drop zone not working if there is no metamask installed in the browser!

repo: jparicka/blockchain-notary


text:
Adding path info to the request object

Coverage increased (+0.03%) to 97.546% when pulling a61154076a6185933351bf13b3daf37097184855 on lyncodev:master into e413da4c59b5e9c7488492ade30631ac5aefa553 on jtwig:master.

authors: coveralls lyncodev

repo: jtwig/jtwig-web


text:
[DNMY] Add support for Elaticache

Thanks for this. Would you be able to add an end-end test in Watchman.Tests please (similar to other services)?

Yea sure think @tomhaigh .

authors: mtwarowski tomhaigh

repo: justeat/AwsWatchman


text:
Merge 2.0

@doncullen As far as I know there is no issue with this code. I just haven't had time to test it enough to make sure that it works well.
With that said I do use it in production on a relatively big deployment without any problems.
If you can give it a try, please let me know how it works for you.

You could release it safely via npm as a prerelease (e.g. beta) - if the version is set to something like 2.0.0-beta.0 - https://docs.npmjs.com/misc/semver

Hello,
This all completely does not work in IE11.
It says: undefined call resolve().
I assume, Promise object is not defined.

authors: adamkiss jwagner skynixukraine


text:
CI for Node

Starts the game with a random player

Starts the game with a random player


text:
LPC17xx: UART configuration structure

am on it

Resolved by PR #458.


text:
added more to README, including coveralls badge. holla

Coverage remained the same at 93.557% when pulling bd65dfee2ac35789843c7d88dbe8fc2e5c848531 on kaylyn-issue-106 into f23f1cefc8f0b995fddcce3907271263f44de6b0 on staging-branch.

authors: coveralls kaylynyuh


text:
Chore setup frontend test react 158580405

Pull Request Test Coverage Report for Build 85

57 of 82 (69.51%)  changed or added relevant lines in 11 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+3.7%) to 83.708%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

server/route/user.js
15
16
93.75%

server/controller/menu.js
0
5
0.0%

server/controller/user.js
4
12
33.33%

server/controller/mailer.js
7
18
38.89%

Totals

Change from base Build 51:
3.7%

Covered Lines:
230

Relevant Lines:
261

💛  - Coveralls

authors: coveralls kenware

repo: kenware/Book-A-Meal


text:
why  chat head closes after some seconds ?

no crash logs bubble disappears after some time


text:
Kill old builds on updates to PRs

Avoided with more automated global build killer.

repo: kframework/evm-semantics


text:
Physical Flow Detail: remove view attestations link

@kamransaleem

repo: khartec/waltz


text:
Update index.md

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

Q4demo/index.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


text:
Add Windows support for JIT memory allocations.

I don't want to support windows. Sorry.

authors: exjam kinnay

repo: kinnay/Wii-U-Firmware-Emulator


text:
HCloud CSI driver v1.1.5

There are some other changes that we need to test out before merge: https://github.com/hetznercloud/csi-driver/pull/43

Seems to work. I'll open a separate issue about manifest update.

authors: jakolehm nevalla

repo: kontena/pharos-cluster


text:
Add puppetmodules to downloads section

Thanks!

authors: kr nesQuick

repo: kr/beanstalkd


text:
first pass of spot feed integration

@mdaniel resolved most comments, with one minor exception:

Be aware there are quite a few places where an err is captured, and even logged, but then execution continues which is unlikely to lead to a good outcome

I believe I now stop the execution within the function but allow the caller to simply log and continue, since spot pricing is optional.

I believe I now stop the execution within the function but allow the caller to simply log and continue, since spot pricing is optional. Let me know if you feel strongly here.

Sure, but I didn't mean just the spot pricing flow: like this, this, this, and this whole stanza which appears to be squatting on the wrong err

authors: AjayTripathy mdaniel

repo: kubecost/cost-model


text:
Support --watch for cli

We see a future where special CLi is not needed for KubeDB. kubectl can do it all. So, we are not implementing this.

repo: kubedb/project


text:
Extend the documentation for lightweight Python components

I'm going to close this one as obsolete.
/close

repo: kubeflow/website


text:
Do not update machine on changes like linking the node

This change is

repo: kubernetes/kube-deploy


text:
Language fix

Didn't know if I should go with username or mention, so I went with username for now

repo: kyranet/Skyra


text:
[5.5] Add Request::keys method

Use case?

@decadence off the top of my head I can think of a use case with GET parameters and filtering.

authors: AndreasElia decadence ntzm

repo: laravel/framework


text:
Fix magnetometer unit

Wow, this was fast, thanks!


text:
Bug fix

Coverage remained the same at 62.305% when pulling be72d03160e437ec93d6b85e6731cbe92392a78c on develop into fe314daf9806d3e1e3cc53dcb7a4b100daf89193 on master.

miss


text:
Make sure to rebalance helix cluster after updating ideal state in Vcr Update Tool

Codecov Report

Merging #1540 into master will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #1540      +/-   ##
============================================
+ Coverage     73.62%   73.65%   +0.02%
- Complexity     8124     8130       +6
============================================
  Files           572      572
  Lines         44611    44614       +3
  Branches       5634     5634
============================================
+ Hits          32845    32859      +14
+ Misses        10110    10102       -8
+ Partials       1656     1653       -3

Impacted Files
Coverage Δ
Complexity Δ

.../github/ambry/clustermap/HelixVcrPopulateTool.java
43.22% <75.00%> (+1.12%)
11.00 <0.00> (ø)

...java/com/github/ambry/store/CompactionManager.java
89.28% <0.00%> (-2.98%)
25.00% <0.00%> (ø%)

...c/main/java/com/github/ambry/network/Selector.java
78.21% <0.00%> (-0.79%)
77.00% <0.00%> (-1.00%)

...a/com/github/ambry/clustermap/ClusterMapUtils.java
92.57% <0.00%> (-0.50%)
48.00% <0.00%> (ø%)

...n/java/com/github/ambry/store/PersistentIndex.java
91.12% <0.00%> (+0.10%)
255.00% <0.00%> (+1.00%)

...in/java/com/github/ambry/store/BlobStoreStats.java
70.45% <0.00%> (+0.41%)
104.00% <0.00%> (+1.00%)

...ain/java/com/github/ambry/router/PutOperation.java
93.12% <0.00%> (+0.65%)
125.00% <0.00%> (+2.00%)

.../github/ambry/clustermap/StaticClusterManager.java
70.20% <0.00%> (+1.63%)
83.00% <0.00%> (+1.00%)

...b/ambry/network/BlockingChannelConnectionPool.java
75.78% <0.00%> (+2.10%)
12.00% <0.00%> (+1.00%)

...github/ambry/rest/AsyncRequestResponseHandler.java
90.23% <0.00%> (+2.35%)
21.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad0b16...702dd76. Read the comment docs.

@jsjtzyy The second run (with --dest only) only needs to happen when we change the configuration like rebalancer, IdealState properties.  Not when adding new partitions.

I added the DelayedAutoRebalancer on recommendation from Helix team to solve the crazy bouncing we were observing.  We are applying it for the first time now.
I also thought we should add rebalanceDelayTime in config and asked Helix team for recommendation, they seemed to say it wasn't needed.  I agree it seems like a good idea.  What value, 1 minute?

repo: linkedin/ambry


text:
Integrate Spring Boot example

SonarQube analysis reported 3 issues

 2 major
 1 minor

Watch the comments in this conversation to review them.

SonarQube analysis reported 1 issue

 1 major

Watch the comments in this conversation to review them.

repo: liquigraph/liquigraph


text:
Add Webhooks endpoint

@andrej-griniuk Hey again.
We have time at the moment to finish this feature. Hope you didn't start to work on these adjustments.
We plan to release it today.

Thanks for this!

repo: lokalise/php-lokalise-api


text:
为啥没有退款的文档

同问，此包支不支持退款的？

authors: dingxiangjun solody

repo: lokielse/omnipay-alipay


text:
enable dev

What is being enabled?

@jhoblitt I accidentally left dev in disable

authors: hreinking jhoblitt

repo: lsst-it/lsst-itconf


text:
Update example app

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #17   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           3      3
  Lines         177    177
=====================================
  Hits          177    177

Impacted Files
Coverage Δ

FlexLayoutTests/MarginSpec.swift
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc84659...cbfa3d9. Read the comment docs.

authors: codecov-io lucdion

repo: lucdion/FlexLayout


text:
change feature test root path

#20

repo: lucidarch/lucid


text:
Release 2.0.6

Current coverage is 100% (diff: 100%)

Merging #559 into master will not change coverage

@@           master   #559   diff @@
====================================
  Files           3      3
  Lines          65     65
  Methods         0      0
  Messages        0      0
  Branches        6      6
====================================
  Hits           65     65
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update 72754d4...8b94973

authors: codecov-io marcgibbons

repo: marcgibbons/django-rest-swagger


text:
Swift 3 support!

Hello @mdabrarniyazi, thanks for your request. The recent version of the library has already been updated to Swift 3.0 syntax. Do you have any difficulties with it in Xcode 8?

@evgenyneu Hi, Sorry I didn't notice.
Is there any way I can change the shape of badge, like square or triangle!

It is alright. Good question about the shape. No, unfortunately the badges are rectangular with rounded corners at the moment.

@evgenyneu Thank you. Please provide this in future if you could.
Also when I am using it in my project, badge quality is decreasing. Border looks like broken or somewhat blurred.

Thank you for reporting this bug. Could you provide the settings you use (sizes, colours, paddings, border widths) so I can reproduce it? A screenshot would also be very helpful. Thank you.

@evgenyneu If you notice it look like low quality. This 160160. I want size from 5050 to 160*160 and border 2 to 5.

Thanks for the info, @mdabrarniyazi. I have used your parameters to make the badge and I could not reproduce your issue. The badge edge looks smooth both on iOS 10 device and emulator. There is clearly something else that I am missing. What could it be?
Please find the screenshot and the demo project attached.

UsingBadgeSwift.zip

Hi @mdabrarniyazi, just an update. One can now specify the corner radius for the badge. You asked if the badge can be a square. Yes, now one can make it square by setting the corner radius to zero. All the best.

Closing the issue, feel free to reopen if it still exists.

authors: evgenyneu mdabrarniyazi

repo: marketplacer/swift-badge


text:
Correct the definition of addFullRequestInterceptor

@simohammedhttp: can you rebase please? :)

Rebased and Replaced by https://github.com/marmelab/ng-admin/pull/1269

authors: Phocea jpetitcolas simohammedhttp

repo: marmelab/ng-admin


text:
Database integration for authors and users

 Intégration de la base de données pour les users/authors

repo: masterdcups/iot-tweet-search-engine


text:
added gitignore

This is done with #29 so we can close this

repo: mattkol/Chromely


text:
gtk: add binding for gtk_accelerator_parse

Thank you

authors: andreastt mattn

repo: mattn/go-gtk


text:
added examples with grouping and controller

@angelov Thanks so much for this contribution!

authors: angelov mattstauffer

repo: mattstauffer/IlluminateNonLaravel


text:
switch from List::AllUtils+List::MoreUtils to List::Util (in core)

This package is used by a pure Perl module. Requiring a recent List::Util adds an XS dependency for all but the most recent Perls.

ah doh, right, List::Util 1.33 wasn't in core until 5.19.5.
I should see about getting List::Util::PP to happen :)

Closing this for now, but feel free to re-open if List::Util::PP happens. :-)

authors: karenetheridge oschwald

repo: maxmind/MaxMind-DB-Common-perl


text:
Send CORS headers in simple mode

Rebased against current master.

Rebased against current master again.

Thanks!


text:
Fix: get tech-conferences of current year dynamically

Thanks @MouadZIANI 👍

authors: MouadZIANI medyo


text:
Meirim 287

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant nadavsofi

repo: meirim-org/meirim


text:
Hybrid app 1.7.0 / 1.3.2 RN

@KevinVlaanderen Where is this IPHONEX.md available? Can it be linked here?

authors: Adam-Dupaski KevinVlaanderen

repo: mendix/docs


text:
考不考虑前端开源呢

同问~~

authors: axzhcode lgphone

repo: meolu/walle-web


text:
Fix typo which causes memory leak.

Thank you!

authors: ksullivan mervick

repo: mervick/emojionearea


text:
Confluent Components 4.1.1 Release

Tested by Michael B and Richard Shaw to work with Conf-Kafka 4.1.1

repo: mesosphere/universe


text:
list pr's that need squashed

\o/

authors: mhaskel tphoney


text:
Is building python from source a paranoia or a waste of efforts?

Perhaps building a virtualenv on top of the user's python 2.7 would be easier?

possible goal: Enable virutalenv on the Mac (or any Linux that use 2.7 for system python)

a3657393dcea7520aeff956909fc38344df0d254 is ready, you just need to do this:
make PYVE=<noneEmptyString> python to have virtuelenv running.

next step: turn on PYVE if your system python is 2.7

mjs-macbook-pro:pitchfork mhsieh$ bin/chkSysPython
mjs-macbook-pro:pitchfork mhsieh$ echo $?
0

authors: mhsieh mpkocher

repo: mhsieh/pitchfork


text:
Runtime Events (Deploy after build completes)

Let's close this for now in favour of pushing an event to the web UI after the build is complete and allowing it to progress the user flow. We will leave the CLI as is. John indicated that the micro run command will execute and once the image is updated it will eventually run so this not really an issue. for MVP we just want to provde feedback in the UI when creating a new service. Separately we just need a way of doing micro update service so that the same deployment is kicked or is perhaps updated based on the runtime scheduler seeing new builds.

authors: asim ben-toogood

repo: micro/go-micro


text:
Fix misc. source and user facing typos

@microelly2 please merge


text:
Changes to handle logo file name collision at root (assets) and in images directory

What was the issue here? If there's already a file named "logo.jpg" in the assets?

We were skipping to add this file to the _resourceJson.Resources

In reply to: 880927302

We were skipping to add this file to the _resourceJson.Resources
In reply to: 880927302

Right, the logo file is stored in PublishInfo.json for some reason. ☹

authors: MikeStall lesaltzm suskumar-MSFT

repo: microsoft/PowerApps-Language-Tooling


text:
Add support for scikit-learn GaussianMixture

Is anyone working on this?

Nope. I can assign it to you if you want to give it a try.

I see.
We're internally considering optimizing the classification model (such as GaussianMixture) by using Hummingbird but haven't decided which model to use.
I'll put a comment before we start to work on adding GaussianMixture support to Hummingbird.

authors: interesaaat mshr-h

repo: microsoft/hummingbird


text:
add sklearn.impute.SimpleImputer

Codecov Report

Merging #267 into master will decrease coverage by 0.00%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
- Coverage   92.71%   92.70%   -0.01%
==========================================
  Files          41       42       +1
  Lines        2293     2318      +25
  Branches      424      427       +3
==========================================
+ Hits         2126     2149      +23
- Misses         87       88       +1
- Partials       80       81       +1

Flag
Coverage Δ

#unittests
92.70% <92.85%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...d/ml/operator_converters/sklearn/simple_imputer.py
92.30% <92.30%> (ø)

hummingbird/ml/operator_converters/__init__.py
100.00% <100.00%> (ø)

hummingbird/ml/supported.py
89.85% <100.00%> (+0.14%)
:arrow_up:

hummingbird/ml/_container.py
93.43% <0.00%> (-0.07%)
:arrow_down:

...rd/ml/operator_converters/_tree_implementations.py
98.15% <0.00%> (-0.01%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eff1214...872c21e. Read the comment docs.

LGTM but since MissingIndicator and SimpleImputer are using to impute missing values, I think we can just have a single file (e.g., impute.py) containing both of them. WDYT?

authors: codecov-commenter interesaaat ksaur


text:
不支持4.0以下的控件吗

只兼容到api14

原理上是支持的，你可以下载源码，尝试修改gradle配置，重新打包arr

authors: ekeyfundLubiao miomin

repo: miomin/SHSwipeRefreshLayout


text:
Create mip-iask-business.js

@hejieye 麻烦下次将多个pr合并成一个，不用多次提交pr

authors: hejieye wupengFEX

repo: mipengine/mip-extensions


text:
add an option to download .fastq.gz from http (useful for data hosted on ArrayExpress)

solved

repo: mirnylab/distiller-nf


text:
Updates README.md with svg badges

Codecov Report

Merging #1051 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1051   +/-   ##
======================================
  Coverage    63.4%   63.4%
======================================
  Files         105     105
  Lines        5818    5818
  Branches      721     721
======================================
  Hits         3689    3689
  Misses       1991    1991
  Partials      138     138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bdde82...7c7eb2a. Read the comment docs.

authors: codecov-io sobolevn

repo: mirumee/saleor


text:
Review the current feature extractor code & add tests

I think #70 takes care of this, yeah?

Yes, I've edited the title so that this one will automatically close when that one's merged.

Wow, go GitHub, that's handy!

authors: acrellin stefanv

repo: mltsp/mltsp


text: when i start debugger app is not working ...

authors: NanoLook jaydeepakbari


text:
fixes for new mne-bids

Thanks @agramfort!!

authors: agramfort hoechenberger

repo: mne-tools/mne-study-template


text:
Add note on how to debug render() reactions

Thanks!

authors: mweststrate natew

repo: mobxjs/mobx-react


text:
Fixed capitalisation of weekdays and ordinal

@jalex79 lowercase?

Also, the wrong file has been modified here. You need to modify the /src/locale file

Closing due to inaction. Feel free to re-open if you fix this pull.

authors: Matoplays maggiepint

repo: moment/moment


text:
Add 'preserve_includer_indent' argument to 'include' directive

Added in v2.5.0

Added in v2.5.0

Nice, I was about to open a PR for this and then I saw you'd already done it. I do wonder if it should be on by default, too.

I do wonder if it should be on by default, too.

Seems reasonable, I'm not sure why I've setted the default value in true from the beggining. Let me a few minutes, I upload the commit and launch it in v2.8.0.

Done in v2.8.0

Cool! Nice one @mondeja 👍

authors: joerick mondeja

repo: mondeja/mkdocs-include-markdown-plugin


text:
all: rename project to sanctionsearch

Codecov Report

Merging #175 into master will decrease coverage by 2.34%.
The diff coverage is 75.3%.

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   67.39%   65.05%   -2.35%
==========================================
  Files          23       25       +2
  Lines        2598     2495     -103
==========================================
- Hits         1751     1623     -128
- Misses        670      703      +33
+ Partials      177      169       -8

See https://github.com/moov-io/ofac/pull/178 instead

authors: adamdecaf codecov-io

repo: moov-io/ofac


text:
Tutorial updates

@dongyoungy This pull request does not add any new code, so immediate merge will be OK.

repo: mozafari/verdictdb


text:
for #211: fix deb package dependency on libasound2

Hi,
Thanks for this PR, I will merge it.
Best Regards,
Michel.

authors: mpromonet villytiger

license: unlicense


text:
Bean entity attached to ship

Not needed.

repo: msecret/space-gun


text:
is there any way to rotate image 90 degree?

Any updates on this one? Would consider developing this feature

repo: muukii/Pixel


text:
Update README.md

Thanks!

authors: CFCIfe mykeels


text:
fix(jx): unique preview name to get unique urls

/retest

/retest

/retest

/retest

repo: mylittlecorp/qs-node-mlc


text:
Do not merge - Integration test branch sentinel commit

Current Voting Result
Vote on this comment with 👍 or 👎.
Vote Summary:
0 👍
0 👎
Acceptance Criteria:

75% of weighted votes needs to be to approve
1 minimum # of unique voters required
at least 5 minutes of voting

repo: myyk/git-democracy


text:
Added test for config.json

duplicate - pull request #8

authors: ernscht noelboss

repo: namics/terrific-micro


text:
chore: code review for [EP-2188]

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

authors: ancashoria dan-qc

repo: natgeosociety/marapp-frontend


text:
React architecture - functional vs class decision

I am preferring Functional architecture. It's easy to split up components and code feels more compact

functional

For an app of this scale, functional component is more suitable

I am preferring Functional architecture. It's easy to split up components and code feels more compact

advantage of performance improvement too

I also feel like functional is more apt

Cool. let's build with functional.

repo: neoito-hub/neo-chat


text:
MAINT: conda recipe

Coverage remained the same at 78.947% when pulling bb6e9c41d9de4b5b8d4ad0c6a6d768b3925ab9bb on thermokarst:conda into 4b864fafaf5a1f22181127e10267632e605ffd7e on nervous-laughter:master.

Coverage remained the same at 78.947% when pulling 0a19af63639668910d8190add6c10093626cdd67 on thermokarst:conda into 4b864fafaf5a1f22181127e10267632e605ffd7e on nervous-laughter:master.

authors: coveralls thermokarst


text:
update the JwtVerifierHandler to make sure the module registry works

 update the JwtVerifierHandler to make sure the module registry works light-rest-4j master


text:
Tag version v1.0

Coverage remained the same at 80.46% when pulling 3441b1b75bed904090dcf0f3d3970a5c22a6b66c on v1.0 into 9e5041ca7ff065454086ea6e0e52b2ba4c05f98e on master.

authors: coveralls mathieuboudreau

repo: neuropoly/axondeepseg


text:
Setup Travis for CI tests

We should be testing only on Linux for now

See https://github.com/nexB/vulnerablecode/blob/develop/.travis.yml

authors: pombredanne tdruez

repo: nexB/vulnerablecode


text:
Geowave vagrant

I will merge once travis finishes.  It kind of sucks that the diff for the parent pom shows the files as being completely different...  I added one plugin and ran the formatter.  I'm not complaining about the additional lines of code though...

repo: ngageoint/geowave


text:
fixed an issue with winutils.exe being copied twice for ITs on windows

this is really basic, the code block that was deleted already exists in MiniAccumuloClusterFactory.newAccumuloCluster and is redundant so this is simply cleaning up


text:
fixed package name in raster format and jai dependency

Changes Unknown when pulling 228827449f719550f96fb63f942a9bcb1d538247 on GEOWAVE-74 into ** on master**.

authors: coveralls rfecher


text:
added time-table demo

empty

repo: ngrebenshikov/jive


text:
enable flannel cross env support

Sorry, my mistake!

repo: nmiculinic/kubespray


text:
Rename combyne folder to templates

I think the only reason I named it that was because theres a 'templates' folder underneath. Go for it.

authors: maxkorp tbranyen

repo: nodegit/nodegit


text:
docs: remove minishift references from docs

Pull Request Test Coverage Report for Build 914596563

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 17.647%

Totals

Change from base Build 914581299:
0.0%

Covered Lines:
9

Relevant Lines:
41

💛  - Coveralls

authors: coveralls helio-frota

repo: nodeshift/rhoaster


text:
adding deployment documentation

Coverage remained the same at 73.837% when pulling 0b630d54ba5e8e929d97102c5a73a0229f3eb9a5 on deployment-docs into afe32bfb8a605dbdff4bb5bb637c080757ee95de on master.

authors: coveralls frankgreco

repo: northwesternmutual/kanali


text:
TripleDH AKE should include specifying of optional parameters idU and idS

Done

repo: novifinancial/opaque-ke


text:
When creating a repository, should we add it to the MCRepositoryGroup registry?

no :)

authors: estebanlm npasserini

repo: npasserini/iceberg


text:
[T3A3][T13-A2]William Sean Hawken

Be careful when using access modifiers. Especially, when using "public" for variables, since then it is visible to all outside classes. In practice, domain classes should be encapsulated.

authors: KulaniT Torasian


text:
[T5A3][F10-B2]Joel Foo

Screenshot:

@jaeoheeail : Good attempt! Accepting this PR without a review.

authors: KulaniT jaeoheeail


text:
fix #430

lgtm

authors: cjdcordeiro mebster

repo: nuvla/ui


text:
World Editing

I don't use git that often so idk if I did it right.

Looks like you did :)

authors: drakeerv obiwac

repo: obiwac/python-minecraft-clone


text:
Форма списка задач

Убираем старые задачи

repo: oknosoft/flowcon


text:
Fixes #72 (setEnabled(false) makes pins invisible when using permanent pins

@oli107 can you take a look at this?


text:
use billiard.Pool to increase stability in celery tasks

merged in PR #76

authors: miraculixx omegaml

repo: omegaml/omegaml


text:
Create test.json

Congrats! The repository doesn't have any security vulnerability issues.

authors: alesiaviktorchyk oneflow-build

repo: oneflow/security-monitor-action


text:
test framework should run on 2.7, 3.4, 3.5, & 3.6

Coverage remained the same at 95.987% when pulling 783fc6716a5453dbcbcbd57f5198004139113f51 on fuhrysteve:master into 1a11858935ab0063f773e3f0cee3531ed4a2900f on onelogin:master.

authors: coveralls fuhrysteve


text:
Added missing dependencies

Merged, thank you.
The dependency on xz was supposed to go away completely at some point. But as long as it's still used, better keep it.

authors: Manouchehri onitake

repo: onitake/uninno


text:
WIP: docs: add codelabs

@daKmoR I added codelabs as a package, I thought that would be easier to find/manage for people. do you think that's ok? or should it be a folder on the top level?

we do not plan on publishing a codelabs package - as in a tool that can generate codelabs any time soon right?
I would suggest to not have a package but have it as an internal tool for now... once we have a certain amount of codelabs which work fine we can think about publishing the tool 🤗
about findability, I think that is mostly about how we present it on the website. (maybe have a codelabs on howto add a codelab to open-wc? 😬 )
so a root codelabs folder sounds good to me 👍

@daKmoR what I mean is to put the codelab source code in it's own package, with it's own build scripts etc. this way it's easier to have an overview and we don't clutter the root with extra folders.

authors: LarsDenBakker daKmoR

repo: open-wc/open-wc


text:
remove 1k separator for AI scraper

resolves #1780


text:
Bring test_chemicalenvironments back online

Update -- @andrrizzi, @bannanc, and myself spoke about this last week. We realized that environments.py is essentially duplicated from Chemper, and the only functionality from it that we use is SMIRKS validation. We're going to keep that validation code around, but deprecate the rest of the functionality.

I wanted to make sure the history on this was correct because this file doesn't come FROM chemper. It was created for the smarty/smirky algorithm back when everything was in the smarty github repo including the openforcefield toolkit. So it has ALWAYS been a part of the openforcefield tools.
ChemPer has always supported both OE and RDK and I didn't want to make openforcefield a dependency in ChemPer until it also supported OE and RDK so I temporarily copied the file over there. Now that openforcefield supports both toolkits I should be able to remove the chemper copy of environment.pyand just makeopenforcefield` a dependency.

@j-wags I wanted to make sure you saw ^

Recap of discussion between @bannanc and myself today:
environment.py is only used for validating SMIRKS currently. It is largely a duplicate of a core functionality in chemper. Do we actually need to maintain a duplicate copy of this in the Open Force Field toolkit?
Validating SMIRKS consists of three major steps:

Ensure that the SMIRKS is valid (that is, not gibberish)
Ensure that the SMIRKS contains the right number of tagged atoms for the parameter being described (eg. bond = 2 atoms, angle = 3 atoms...)
Ensure that the atoms in the SMIRKS are connected in the predicted way.

We both agree that 1) and 2) are essential to avoid scientific errors. 3) might actually not be necessary -- People may want to define weird non-explicit-valence parameters (perhaps a bond between things like water model H's, or an improper around a metal coordination site?)
Anyway, it's actually not too difficult to replace all of these with minimal calls For each point above:

Code to check for gibberish in both OE and RDK can be found here
We can check this after each match, by counting the number of tagged atoms that were found
This may not be necessary, but we can check this after each match with a series of TopologyAtom.is_bonded() calls

Thus, I think we can plan to remove environment.py in a future milestone. This isn't critical (and will be a good opportunity to implement several tests), but we should get to it eventually to clean up the API and keep from confusing users.

Since we are moving away from validating SMIRKS while loading force fields (#1472  #1509) and there has been no movement on this in almost four years, I do not think we are likely to do this.
Note of course that removing the code from a future release does not remove it from history or prevent it from being added back in the future.

authors: bannanc j-wags mattwthompson

repo: openforcefield/openforcefield


text:
removed social from login and register #6969

Coverage remained the same at 68.82% when pulling 2cf19df832dcd2a27e24fe2050e52cd6fcdf332a on gautampanday:remove-social into a243e7786597f934eab0e1264571d7e0f513d696 on openlabs:develop.

@tarunbhardwaj please review

authors: coveralls gautampanday prakashpp

repo: openlabs/nereid-webshop


text:
Fix assert documentation typo

Good catch. Thanks @gberaudo.

authors: ahocevar gberaudo


text:
Fix parameter spec

/lgtm

authors: csheremeta mmazur

repo: openshift/managed-notifications


text:
Re-add 5/15 min Heartbeat alerts and set to disabled

@mmazur 👍🏻 on #4356

repo: openshift/openshift-tools


text:
SCT signature verification, encode/decode and accessor functions

@robstradling @ekasper Hello, what's the status of this PR? I was looking into adding support for the signed_ceritificate_timestamp TLS extension as well (used by all Google services), but it would probably merge conflict with this work.

So, I just tried to rebase @robstradling's branch on master, but it seems some work will be needed to properly merge all the changes.

@ghedo In Sept 2014, Steve Henson, Emilia and I made some fairly extensive changes to the code in this PR.  It's all in one of Steve's private git branches.  Initially we were aiming to get the code into 1.0.2, but it became clear that that was just too ambitious.
Since we missed 1.0.2, and since RFC6962-bis is in the works, we decided to wait for RFC6962-bis to settle down a bit more before finalizing the OpenSSL SCT API.
So hopefully this will be picked up again within the next few months.

Steve H says he will dust this off. The work was done prior to the reformatting so the patch will need reformatting too.

@mattcaswell Thanks!

Given #396 and the other work from @aeijdenberg I think this can be closed now.

Closing in favour of #396 as per @ghedo's comment

Thanks.

authors: ghedo mattcaswell robstradling

repo: openssl/openssl


text:
Add a link of a implementation for Koa

thanks @cnwangjie

authors: cnwangjie pavolloffay

repo: opentracing-contrib/meta


text:
bump version

LGTM-embers in the chatroom.

repo: openvanilla/McBopomofo


text:
[WIP] Pvc capacity report

/(pony)

/retest

/retest

/retest

/test e2e-aws-metering

/override ci/prow/e2e-aws-metering
/override ci/prow/integration-aws-metering
/lgtm
/approve

repo: operator-framework/operator-metering


text:
Reporting_Health_Resolution_Description_-_Units_Singular

In most cases the output isn't singular, I don't think we should change this.

authors: AdSchellevis NOYB

repo: opnsense/core


text:
updated dependencies

/azp run

repo: osisoft/sample-ocs-assets-python


text:
Spell checkign Hugo docs

Looks great, thanks.

authors: gj plotnick

repo: osohq/oso


text:
Fix recently added link in CONTRIBUTING.md

* [packit-service-tests ](https://softwarefactory-project.io/zuul/t/local/build/dfee82f0468c4ea98e4fadc0139527d8) : RETRY_LIMIT in 6m 38s

Failed to download metadata for repo 'updates-modular'

Nice, at first I was really thinking we would need to change packit's code for sake of p-s' ServiceConfig, well done!

authors: TomasTomecek jpopelka

repo: packit-service/packit-service


text:
Dockerfile: FROM docker.io/usercont/base -> quay.io/packit/base

recheck

repo: packit/sandcastle


text:
updated docs

Looks good, merging. Apologies for the delay.

authors: DuaneOBrien samsel

repo: paypal/Gander


text:
Fix indentation in a function. Fix a reST table fix.

Good stuff :) :+1:

authors: mahmoud ramiro

repo: paypal/support


text:
[BACKLOG-13199] - Mavenize pentaho-kettle/plugins/kettle5-log4j-plugin

@pentaho/2-1b

repo: pentaho/pentaho-kettle


text:
Update README.md

@pltr @yanisperco -- can you one of you approve and then merge?

repo: percolate/pratt-parser


text:
Allow building with base-4.13./GHC 8.8.

Merged as part of #13

authors: RyanGlScott phadej

repo: phadej/functor-classes-compat


text:
heartbeat: send an empty command to active streams periodically

LGTM

PTAL @overvenus @nolouch

/run-all-tests

/run-integration-compatibility-test tidb=release-1.1 tikv=release-1.1 pd=release-1.1

/run-integration-compatibility-test

/run-integration-common-test

authors: disksing iamxy siddontang

repo: pingcap/pd


text:
[DNM] Test supporting spark 2.4.0

/run-all-tests

/run-all-tests

close this PR because it is resolved by #665

authors: birdstorm zhexuany

repo: pingcap/tispark


text:
Websockets

I've merged the websockets functionality with #306, the rest is the related to the collaborative editing which is experimental at this stage, will close PR till we have time to work on this.

authors: bloodbare robgietema

repo: plone/volto


text:
Update LICENSE

Year should be 2018-2019


text:
add a minimal python based example

fixed by #47

repo: popperized/popper-examples


text:
add link to github and link to example data file to webpage

link to example datafiles won't work until this is merged to master

repo: popphylotools/mvMapper


text:
Publish packaged artifacts on GitHub and npm

@kamalaknn
Packaged Apps: https://buildkite.com/postman/app-package-and-deploy/builds/1563
E2E tests: https://bitbucket.org/postmanlabs/postman-app/addon/pipelines/home#!/results/14427

repo: postmanlabs/electron


text:
Add escape character in like predicate for SHOW CATALOGS

Please update the docs for this

@martint Thanks for your insights. Have applied the comments

repo: prestosql/presto


text:
Update docker images version to 25

CI failed -- https://github.com/prestosql/presto/issues/1641


text:
SB-7808 - UI fixes for content credit popup

@harishgilimi , Hi can you pls merge this?

@lakhanmandloi  update labels and titles with resource bundles for multilingual , Raghavendra already added resource bundles you can refer them

@harishgilimi - Hi, I have updated text with resources bundle. Can you pls review it now? Thanks!

@lakhanmandloi  travis build is failing please check

@harishgilimi Hi, All checks are passing now.

authors: harishgilimi lakhanmandloi

repo: project-sunbird/sunbird-portal


text:
Stop implying that Calico for OpenStack is only for <= Mitaka

I have ubuntu 16.04 Xenial system and installed openstack ocata by following the procedure given in the openstack documents. When i tried installing the etcd , i was not able to find the etcd.conf file in my system . I think there should be a update in calico documentation for systemctl based config.

@srikrishna68 Please open a new issue to track that request.  Commenting on an open PR isn't the right place.

I'd probably drop mention of Icehouse now that we no longer test it routinely. but otherwise LGTM.

authors: fasaxc neiljerram srikrishna68

repo: projectcalico/calico


text:
Document hashmod

Can we note somewhere that regex is still mandatory for other actions?

@fabxc Done

authors: brian-brazil fabxc

repo: prometheus/docs


text:
Update Documentation

Something very strange is happening, the value of "branch" is being set differently across my enterprise account and my open source account.

This is working again now.

repo: promiseofcake/circleci-trigger-action


text:
update event sourcing for new interface

Ok no problem. Will update those 100 repos tomorrow :-)
Am 08.11.2016 01:24 schrieb "Alexander Miertsch" notifications@github.com:

@codeliner requested changes on this pull request.
In src/Aggregate/AggregateRepository.php
https://github.com/prooph/event-sourcing/pull/34#pullrequestreview-7462550
:

           $snapshot->lastVersion() + 1

       );

   } else {

       $metadataMatcher = new MetadataMatcher();

       $metadataMatcher = $metadataMatcher->withMetadataMatch(

           '_aggregate_type',

           Operator::EQUALS(),

           $this->aggregateType->toString()

       );

       $metadataMatcher = $metadataMatcher->withMetadataMatch(

           '_aggregate_id',

           Operator::EQUALS(),

           $aggregateId

       );

       $metadataMatcher = $metadataMatcher->withMetadataMatch(

           '_version',

I know it requires more work, but it would be nice if we rename _version
to _aggregate_version to make the concept and difference between domain
event version and event no in the streams explicit. What do you think
@prolic https://github.com/prolic ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/prooph/event-sourcing/pull/34#pullrequestreview-7462550,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYEvE1xwPfb11pqL1J5oC2-r4z0PusAks5q717UgaJpZM4KrSKk
.

repo: prooph/event-sourcing


text:
Add query interface for course reserves

I've merged voyager_helpers/add_course_reserve_methods - do we want to make a release and update this to use that?

:+1: if @tpendragon doesn't have anything else to add.

@escowles Updated to released version.

authors: escowles jpstroop tpendragon


text:
Add a basic IIIF viewer.

:+1: Definitely a fan of data attributes. @jpstroop this seems a good interim solution until we get a chance to engage with the Universal Viewer more and see if it will place nice with the rails asset pipeline.

:+1:

authors: jpstroop kevinreiss terrellt

repo: pulibrary/plum


text:
(maint) Merge 3.13.x -> master

Travis is passing but the reporter is not updating the status 😒
https://travis-ci.com/puppetlabs/facter/builds/121363604

CLA signed by all contributors.

authors: gimmyxd puppetcla

repo: puppetlabs/facter


text:
Make tasklog ids in agent view links

Coverage remained the same at 66.15% when pulling 08e2f416aa01ea5f197fb8e7e6e84dc5a8c28447 on guidow:link_tasklogs_in_agent into 2470d45e570ae7f4bbfe5ef0fb155a6d93cc2bab on pyfarm:master.

Coverage decreased (-0.01%) to 66.14% when pulling 7410f549243cd6a276e3b6b1fd4de067e5ab0fcd on guidow:link_tasklogs_in_agent into 2470d45e570ae7f4bbfe5ef0fb155a6d93cc2bab on pyfarm:master.

Looks good, merging.

authors: coveralls guidow opalmer

repo: pyfarm/pyfarm-master


text:
Update ITIS dump

what's this about? please update the description

authors: cthoyt ddomingof

repo: pyobo/pyobo


text:
Fixed video uploading issue for iOS

@vdelendik please, don't merge. I still need to resolve some questions.

repo: qaprosoft/carina


text:
Add get transformers

Hey @Oddant1, I just updated the base branch from master to import_wizard. Also, @ebolyen and I had a chance to discuss this SDK method today, the plan is to punt it for now, you won't need it from the Import Wizard (although it'll be really helpful in the work immediately to follow the wizard project).

Hey @Oddant1 is this still current, or should we close it out?

Yeah, @lizgehret I'm pretty sure this can go. Even the branch it was being merged into is outdated at this point. If we ever take another crack at this idea we're gonna need to start over.

authors: Oddant1 lizgehret thermokarst


text:
Fix insights Cron job var subst. issue.

@ashwathishiva Have a look on the Changes done in this PR, it will help u with ur work in precedents


text:
Reincarnation of GUI tests

[Current coverage][cc-pull] is 26.89%

Merging [#1734][cc-pull] into [master][cc-base-branch] will increase coverage by <.01%

@@             master      #1734   diff @@
==========================================
  Files          1892       1893     +1
  Lines         79293      79320    +27
  Methods       13381      13391    +10
  Messages          0          0
  Branches       1182       1182
==========================================
+ Hits          21327      21337    +10
- Misses        57868      57885    +17
  Partials         98         98

Powered by Codecov. Last updated by [e8da66d...434c1ed][cc-compare]
[cc-base-branch]: https://codecov.io/gh/qreal/qreal/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/qreal/qreal/compare/e8da66d66411c3ae7e8851cfe0d43e6ced97cec5...434c1ed947aff951804ee5a0ad96c06028009145?src=pr
[cc-pull]: https://codecov.io/gh/qreal/qreal/pull/1734?src=pr

authors: codecov-io dvvrd

repo: qreal/qreal


text:
Moved Travis to sudoless environment and added python 3.5 to the build

Thanks but I cannot merge at this stage.
Several tests are still failing in python 3.5.
I've updated to sudoless travis.

authors: lsbardel thedrow

repo: quantmind/pulsar


text:
Fix DE fish reges + static fish data

Sorry, but when you have two separate changes (one's a bugfix, the other's a content addition), could you put them in two separate pull requests? That way if the bugfix is wrong, I can just revert that whole commit on its own.

authors: Akurosia quisquous

repo: quisquous/cactbot


text:
prevent act from overwriting local git config

apparently, act will currently overwrite the local git config user.name.

obsolete or done in the new yml-based GitHub actions.

repo: r-lib/ghactions


text:
fix realloc and usable size with aligned pointers, remove guards feature

Fixes #64

repo: rampantpixels/rpmalloc


text:
Lock failed messages for delegate requests are seen under load

This is too long ago for me to even remember what the issue was.  Note to self: Add description to issues.

repo: rancher/rancher


text:
Fix Makefile missing X11 lib when building as a shared library on Linux

@JuDelCo thanks for the fix! 😄

license: Zlib


text:
Added Tim Dorr to authors

Um, thanks, but Jimmy should really be included before me. He's done more of the work this year

authors: anaibol timdorr

repo: reactjs/react-router


text:
Use redis-2.8.21 for reborn server

LGTM

authors: qiuyesuifeng siddontang

repo: reborndb/reborn


text:
Add more CI / Test Documentation

what kind fo documentation?

authors: cdrage kadel

repo: redhat-developer/odo


text:
Fix typo

Thank you!

authors: jonstodle rhiever


text:
0.7，bug太多

请给个截图，或者代码

这是第一种情况

push后，点击back按钮返回到主页面，底部的tabbar按钮的问题，会进行闪动下，和原来的位置有偏移，从上又回到原始位置，很明显

另外设置，navi.useSystemBackBarButtonItem = YES;后，在主页面进入到第二级页面，返回按钮还是系统的<back，只有从第二级页面进入到第三级界面的时候，才会出现返回按钮为，<首页这种样式的

同样的问题，怎么解决。好像只在iOS 12.1 iPhone X出现。

@VillageMud  这个有可能跟我遇到问题一样是iOS 12.1的问题
参考：
https://github.com/QMUI/QMUI_iOS/issues/410

对的，这个只有在iOS12.1才会出现，使用系统原生的，我这边却没有这个问题

0.7.0 版目前问题比较多，最近也没空解决。建议还是先撤回 0.6.x

已经退回，0.6.7.到时候进行通知下

@VillageMud  在情况一下，只有一个导航器，第一个 VC 其实是 TabBarController，它没有标题，所以默认为 Back，于是出现二级 push 到三级才有正确的返回标题，一级到二级都是 Back。
情况二下，目前不清楚原因，一个可行的方案是设置 TabBar 为不透明：
tabController.tabBar.translucent = NO;

如果你只有一级页面有 TabBar ，建设改为情况一的集成方式

hotfix/0.7.0 分支可以测试一下 @VillageMud

@rickytan 我看了下，网易云音乐，4.3.5版本的，他们这个是没有出现这个问题的，tabBar.translucent = yes，目前咱们这个解决方案个人认为这是暂时情况的，不知道，大大和网易云音乐那边的同学可以做下交流部，😝，个人意见

嗯，我现在就在，跟自己交流就好:joy:。云音乐现在已经到 5.7.0 版了，你的 4.x.x 也太老了吧。另外，那个  tabBar 按钮是假的，因为要实现换肤功能

authors: VillageMud rickytan smalldu

repo: rickytan/RTRootNavigationController


text:
added Keras code

Hi Mohammad,
thanks a lot for adding tf/keras code!
I am not knowledgable about tf/keras but it looks like your implementation of deep4 is missing the batch norm layers.
Is this correct?

Hi,
I know, you are right.
I have added batch norm layers.

Thanks a lot for your efforts. I am a bit hesitant to put it into the main braindecode as I am not sure we will have resources to support two different implementations, this will anyways only have trialwise, not cropped decoding, right? Is there a way to add cosine annealing to your example?

authors: Mahelita MohammadJavadD robintibor

repo: robintibor/braindecode


text:
Command line support for kubernetes policies.

Done.

authors: jbrendel pritesh

repo: romana/core


text:
(docs): fixed small error

Thanks!

repo: rq/rq-scheduler


text:
typo fix

@Smartik89
Thanks for the pull request.  Actually the typo was corrected coincidently by @dineshjain2911.  So could not merge this pull request as its overriding.

repo: rtCamp/easyengine


text:
Solve line length linter issues.

Cool. Usually I just run rubocop --auto-gen-config and call it a day.

authors: dblock drn


text:
Failing test case catch-all route - #1081

This looks like a succeeding test :)

Ok... that's odd. It failed for me locally.

% rspec spec/grape/api_spec.rb:483
Run options: include {:locations=>{"./spec/grape/api_spec.rb"=>[483]}}

Grape::API
  .route
    allows for catch-all in a namespace (FAILED - 1)

Failures:

  1) Grape::API.route allows for catch-all in a namespace
     Failure/Error: expect(last_response.body).to eql 'catch-all'

       expected: "catch-all"
            got: ""

       (compared using eql?)
     # ./spec/grape/api_spec.rb:508:in `block (3 levels) in <top (required)>'

Finished in 0.0718 seconds (files took 0.56025 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/grape/api_spec.rb:483 # Grape::API.route allows for catch-all in a namespace

Oh it doesn't look like anything ran?!

@dblock I just rebased on master to get a new push. I'm still not seeing anything running. Is your integration busted?

That would make sense, since we moved repo owners! Fixing.

Now tests fail :)

Success! :+1: :)

I believe this is fixed with the new router, @wagenet can you rerun these against HEAD please?

@dblock I've rebased. Test is still failing.

Thanks @wagenet, @namusyaka if you have a moment I couldn't figure out what's wrong here.

authors: dblock wagenet

repo: ruby-grape/grape


text:
Bump some dependencies

bors r+

Ah, I didn't get the notification for the r+. The latest commit upgrades some npm packages and eslint complains a little about the TypeScript version. Do we care about that?

Actually, I think it was complaining even before my changes (we were already on 3.9).

r? @kjeremy

Rebased.

bors d+

bors r+
...I guess

Oof...
@matklad r=matklad

Build succeeded:

Rust (macos-latest)
Rust (ubuntu-latest)
Rust (windows-latest)
TypeScript

authors: lnicola matklad

repo: rust-analyzer/rust-analyzer