text:
features on workspace

Today, I encountered a problem with the overall compilation of the workspace and the inconsistent compilation of each crate.
We have a public logger crate, the default is output to a file, open console features will be output to the terminal.
Some crates in the workspace have this feature turned on, while others do not need to be turned on.
Cargo bulid --all will cause the entire workspace's crates to be output to the terminal.
Compile each crate separately, it will normal to open different logger modes.
This behavior makes me very confused.
relate: #4463

@driftluo yep, this is a duplicate of #4463, so closing the issue in favor of that one.
Note, however, that Cargo features are intended to be additive. That is, from Cargo's point of view, it's never a semantic error to activate more features than actually necessary. So in that sense, using a cargo feature to determine if the logging should go to file or to the console might not be the best approach.

source: gharchive/issue

authors: driftluo matklad

repo: rust-lang/cargo

license_type: permissive

license_source: github-api


text:
Fix some duplicate artifact problems.

The recent cargo update failed because of duplicate artifacts with rls.
tar should mirror what the main manifest contains.
Partially revert #7374 by adding serde back to url.  Unfortunately the lsp-types crate (used by rls) needs this feature.  Unless anyone has a good idea on how to handle that, I don't think it can be removed.
Unblocks cargo update, which I'd like to get done before the beta branch.

r? @nrc
(rust_highfive has picked a reviewer for you, use r? to override)

I think this is probably best fixed in rust-lang/rust itself with https://github.com/rust-lang/rust/tree/master/src/tools/rustc-workspace-hack, although disabling features of tar seems reasonable to land here!

Oh...I knew that. 😛

@bors: r+

:pushpin: Commit 079b3fbad85819cfb2f9e79249968a8ea08b45e8 has been approved by alexcrichton

:hourglass: Testing commit 079b3fbad85819cfb2f9e79249968a8ea08b45e8 with merge 3596cb86b2e87dd9b9c1bb90d4a9d73ec2c1512f...

:sunny: Test successful - checks-azure
Approved by: alexcrichton
Pushing 3596cb86b2e87dd9b9c1bb90d4a9d73ec2c1512f to master...

source: gharchive/pull-request

authors: alexcrichton bors ehuss rust-highfive


text:
Display embedded man pages for built-in commands.

This changes cargo help COMMAND to display the man page for the given command.  cargo COMMAND --help continues to show the basic clap output.
The man pages are embedded in the executable in a compressed format. There's also a copy of the man pages in text format for platforms that do not have the man executable (like Windows).
It is unfortunate to check in more pre-generated files. I hope in the future that the usage of asciidoc can be replaced with something else (possibly a custom markdown-based solution).
cc #6104

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

I've been messing with checking on CI, and came to the realization that man (and sometimes asciidoctor itself) produces different output on different systems.
I think that emphasizes that it will be increasingly difficult for people to contribute to the documentation (if they don't have the exact same setup).  I've been concerned about it in the past, but I feel like this is a tipping point.
Would you be opposed to a custom solution using Rust and markdown (to replace the asciidoctor stuff)?  I don't know exactly what that would look like, or how much code it would be. Comparing to the html renderer and asciidoctor's manpage converter, I would hope it is roughly the same magnitude (under 1,000 lines).
I would probably still lean towards pre-generated files (instead of embedding pulldown-cmark into cargo itself, and rendering at runtime).  I would probably just add a utility crate that can generate the rendered files.

Gah bummer!
I don't think it's the end of the world to have a custom solution here, but it's sort of a bummer that we have to make something just for Cargo. Ideally it'd be shared by other CLI tooling elsewhere or such. (Cargo doesn't seem particularly unique in this regard).
As you mentioned though it's probably not a huge feature or implementation, so I think vendoring our own should be ok.

It seems reasonable at least to perhaps have it out-of-repo (or make that an explicit "goal") -- I imagine at the very least, we'll probably want similar-ish tooling perhaps for rust{doc,c} --help eventually.

:umbrella: The latest upstream changes (presumably #8577) made this pull request unmergeable. Please resolve the merge conflicts.

OK, I have rebased after #8577, and I think this should be ready to go.  I haven't done much testing on less-common platforms and terminals (just mac/windows/linux/freebsd with a variety of common terminals). I'm kinda hoping if people run into problems, they can file an issue.

@bors: r+
Looks great to me 👍

:pushpin: Commit 0d6881c5bce252df34d4a4263878e78b8f56efab has been approved by alexcrichton

:hourglass: Testing commit 0d6881c5bce252df34d4a4263878e78b8f56efab with merge 2732539e8548fd0db65ad51ceb049f23d2f3b931...

:sunny: Test successful - checks-actions
Approved by: alexcrichton
Pushing 2732539e8548fd0db65ad51ceb049f23d2f3b931 to master...

authors: Mark-Simulacrum alexcrichton bors ehuss rust-highfive


text:
Drop support for Visual Studio 12 (2013)

Visual Studio 2013 went out of support on Apr 9, 2024: https://learn.microsoft.com/en-us/lifecycle/products/visual-studio-2013
Additionally, the Rust Compiler has required Visual Studio 2017 since 1.66: https://github.com/rust-lang/rust/pull/102577/commits/9b3db34072551680c12da4192ad528a01579ce61

It seems reasonable to drop vs 12, but I will wait for others' review in case they are against this change.

As per zulip discussion, we decided to wait until msrv is bumped to 1.66
since the current msrv of cc still supports vs 12, merging it now might break some users.
Once msrv is bumped to 1.66, we will merge this.

Discussion is in t-libs/crates, request review for cc-rs

authors: NobodyXu dpaoliello

repo: rust-lang/cc-rs


text:
Footer links not clickable

Steps to reproduce:

Visit any recently built docs.rs page, e.g. https://docs.rs/rushterm/0.5.2/rushterm/.
Scroll to the bottom of the page.
Click "About docs.rs", "Privacy policy", or "Build queue".

Expected result: navigate somewhere else.
Actual result: no navigation.
Chrome 97.0.4692.71 (Official Build) (64-bit) on Linux.

@GuillaumeGomez could this be related to #1579 ? Or something else?

The footer is before the main div and on new docs the main div padding extends down over it. Looks like either moving the footer down below the main div, or adding a high z-index to it, fixes it for both old and new docs. (Or maybe there's a way to not have the padding extend down over it on the new docs too, the old docs appear to have it stop significantly above the footer somehow).

I think changing the z-index is the right fix here (other fixes might be much more complicated).

authors: GuillaumeGomez Nemo157 jsha syphar

license: MIT


text:
azure_mgmt_web 8 GB

Crate name
azure_mgmt_web
Build failure link
https://docs.rs/crate/azure_mgmt_web/0.1.0/builds/499635
Requested RAM limit
8 GB
Requested timeout
No response
Requested number of targets
No response
Why your crate needs the resource increases
Ran out of memory at 3 GB. https://github.com/Azure/azure-sdk-for-rust/issues/634

@cataggar
I saw you were requesting higher memory limits for a bunch of crates. In that amount this can be a problem for our build-system and I'm asking you to try to reduce memory usage in the build first. If the build itself cannot be optimized you might find a solution by optimizing just the build for docs.rs (see the docs.rs build and the metadata). You might also find help on the discord servers or in zulip.
As a last option, some packages resort to building and hosting the docs themself.

authors: cataggar syphar


text:
MinGW: also copy libmingwex.a from C toolchain

Fixes recent CI error:
note: C:\Program Files (x86)\Rust\lib\rustlib\i686-pc-windows-gnu\lib/libmsvcrt.a(dyims01169.o):(.text+0x0): multiple definition of `longjmp'
          C:\Program Files (x86)\Rust\lib\rustlib\i686-pc-windows-gnu\lib/libmingwex.a(lib32_libmingwex_a-mingw_getsp.o):mingw_getsp.S:(.text+0x5): first defined here

Successful build: https://ci.appveyor.com/project/mati865/libc/builds/26425673
It also should be added to Azure in https://github.com/rust-lang/libc/pull/1376

r? @gnzlbg
(rust_highfive has picked a reviewer for you, use r? to override)

@bors: r+

:pushpin: Commit 63fd0f58d5131f7b7b34acc780664b79396008d9 has been approved by gnzlbg

:hourglass: Testing commit 63fd0f58d5131f7b7b34acc780664b79396008d9 with merge 1372eb25ee9ffdbf54c94cd2f45cea9518745240...

All green.
I think @pietroalbini redeployed RCS and bors died.

@bors: retry

:hourglass: Testing commit 63fd0f58d5131f7b7b34acc780664b79396008d9 with merge 04d7ccc2339aa927d2cd35950f2f411b0193e70a...

:boom: Test timed out

@bors: r+

:bulb: This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: #1440

:pushpin: Commit 63fd0f58d5131f7b7b34acc780664b79396008d9 has been approved by gnzlbg

If https://github.com/rust-lang/libc/pull/1376#issuecomment-517905681 is close to being merged you can close this one.

I'm closing this in favor of that one, but bors is timing out all over the place all the time.

authors: bors gnzlbg mati865 rust-highfive

repo: rust-lang/libc


text:
musl fixes and musl+riscv32 fixes

Thanks for considering submitting a PR!
Here's a checklist for things that will be checked during review or continuous integration.

[x] Edit corresponding file(s) under libc-test/semver when you add/remove item(s)
[x] rustc ci/style.rs && ./style src
[ ] cd libc-test && cargo test (This might fail on your env due to environment difference between your env and CI. Ignore failures if you are not sure.)
[x] Your PR that bumps up the crate version doesn't contain any other changes

Delete this line and everything above before opening your PR.

cd libc-test && cargo test fails on my archlinux without my changes as well
OPT_LEVEL = Some("0")
  HOST = Some("x86_64-unknown-linux-gnu")
  cargo:rerun-if-env-changed=CC_x86_64-unknown-linux-gnu
  CC_x86_64-unknown-linux-gnu = None
  cargo:rerun-if-env-changed=CC_x86_64_unknown_linux_gnu
  CC_x86_64_unknown_linux_gnu = None
  cargo:rerun-if-env-changed=HOST_CC
  HOST_CC = None
  cargo:rerun-if-env-changed=CC
  CC = None
  cargo:rerun-if-env-changed=CFLAGS_x86_64-unknown-linux-gnu
  CFLAGS_x86_64-unknown-linux-gnu = None
  cargo:rerun-if-env-changed=CFLAGS_x86_64_unknown_linux_gnu
  CFLAGS_x86_64_unknown_linux_gnu = None
  cargo:rerun-if-env-changed=HOST_CFLAGS
  HOST_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = None
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
  running: "cc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-gdwarf-4" "-fno-omit-frame-pointer" "-m64" "-Wall" "-Wextra" "-Wall" "-Wextra" "-Werror" "-Wno-unused-parameter" "-Wno-type-limits" "-Wno-address-of-packed-member" "-Wno-unknown-warning-option" "-Wno-deprecated-declarations" "-D_GNU_SOURCE" "-D__GLIBC_USE_DEPRECATED_SCANF" "-o" "/home/kraj/work/libc/target/debug/build/libc-test-04f83ede874c351b/out/627d083e0321a21f-main.o" "-c" "/home/kraj/work/libc/target/debug/build/libc-test-04f83ede874c351b/out/main.c"
  cargo:warning=/home/kraj/work/libc/target/debug/build/libc-test-04f83ede874c351b/out/main.c: In function ‘__test_roundtrip_inotify_event’:
  cargo:warning=/home/kraj/work/libc/target/debug/build/libc-test-04f83ede874c351b/out/main.c:23146:13: note: the ABI of passing struct with a flexible array member has changed in GCC 4.4
  cargo:warning=23146 |             ) {
  cargo:warning=      |             ^
  cargo:warning=/home/kraj/work/libc/target/debug/build/libc-test-04f83ede874c351b/out/main.c: In function ‘__test_fsize_af_alg_iv_iv’:
  cargo:warning=/home/kraj/work/libc/target/debug/build/libc-test-04f83ede874c351b/out/main.c:25568:34: error: invalid application of ‘sizeof’ to incomplete type ‘__u8[]’ {aka ‘unsigned char[]’}
  cargo:warning=25568 |                     return sizeof(foo->iv);
  cargo:warning=      |                                  ^
  cargo:warning=/home/kraj/work/libc/target/debug/build/libc-test-04f83ede874c351b/out/main.c:25569:17: error: control reaches end of non-void function [-Werror=return-type]
  cargo:warning=25569 |                 }
  cargo:warning=      |                 ^
  cargo:warning=At top level:
  cargo:warning=cc1: note: unrecognized command-line option ‘-Wno-unknown-warning-option’ may have been intended to silence earlier diagnostics
  cargo:warning=cc1: all warnings being treated as errors
  exit status: 1

  --- stderr
  rust version: 1.68.2

  error occurred: Command "cc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-gdwarf-4" "-fno-omit-frame-pointer" "-m64" "-Wall" "-Wextra" "-Wall" "-Wextra" "-Werror" "-Wno-unused-parameter" "-Wno-type-limits" "-Wno-address-of-packed-member" "-Wno-unknown-warning-option" "-Wno-deprecated-declarations" "-D_GNU_SOURCE" "-D__GLIBC_USE_DEPRECATED_SCANF" "-o" "/home/kraj/work/libc/target/debug/build/libc-test-04f83ede874c351b/out/627d083e0321a21f-main.o" "-c" "/home/kraj/work/libc/target/debug/build/libc-test-04f83ede874c351b/out/main.c" with args "cc" did not execute successfully (status code exit status: 1).

nightly x86_64-unknown-freebsd-13 failure is build host related as well.

Thanks! @bors r+

:pushpin: Commit be7fd2820f65521ba2f089ceacb44aff0c296cb9 has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit be7fd2820f65521ba2f089ceacb44aff0c296cb9 with merge 9beae5d37930ddd0ed2ab392034e1570d3dd5b97...

Seems some consts are declared twice, @rustbot author

https://github.com/rust-lang/libc/pull/3302

authors: JohnTitor akiernan bors kraj


text:
Allow as in match statements

As in
let ptr = match mmap(...) {
    -1 as *mut c_void => panic!(),
    p => p,
}

This is very useful for FFI and #![no_std], I don't think it takes anything away, and it shouldn't be too difficult to add.
Possibilities right now include
let ptr = match mmap(...) as usize {
    -1 => panic!(),
    p => p as *mut c_void,
}

or
let ptr = match mmap(...) {
    p if p == -1 => panic!(),
    p => p,
}

Another possible idea, one that I doubt many people would like, is to allow *const and *mut pointers to be integrals. Then you could just do the C thing of
let ptr = match mmap(...) {
    -1 => panic!(), // -1 is a *mut c_void in this situation
    p => p,
}

Perhaps type ascription is a better choice here? That RFC actually says

An earlier version of this RFC covered type ascription in patterns too, that has been postponed

So there may already be existing discussion about this.

@kballard Type ascription asserts that the expression has the provided type, but it doesn't apply in this case: -1 is an integer, not a raw pointer. The casting is required.
That said, I think it is better to allow int ↔ raw pointer casting in CTFE to allow:
const INVALID_MMAP: *mut c_void = (-1usize) as *mut c_void;
match mmap(...) {
    INVALID_MMAP => ...
    p => ...
}

Oh you're right, for some reason I was thinking that integral literals could be used where pointers are expected, but no, you need the explicit as there.

That said, I think it is better to allow int ↔ raw pointer casting in CTFE

Huh, that seems a bit surprising that it doesn't work. Is there an issue that tracks this? If not, one should be filed.

I think that with  this is now doable as

authors: kballard kennytm scottmcm strega-nil

repo: rust-lang/rfcs


text:
"bitbake cargo" does a git checkout of my recipes!

I'm trying to build again poky "master" for what it's worth.
My project is a git repo that uses git submodules for each of my layers, ie:
/superproject
├── build
├── meta-browser
├── meta-clang
├── meta-freescale
├── meta-freescale-3rdparty
├── meta-nrl
├── meta-openembedded
├── meta-python2
├── meta-qt5
├── meta-rust
└── poky
(some layers omitted)
Most of my layers are currently checked out to the "master" branch which is a tracking branch for origin/master for each of the layers.
After running "bitbake cargo" (which currently fails), many of my layers have been checked out to the version which is committed to the super-project. What the heck, since when does a bitbake recipe do anything at all to the git projects of the metadata??!!
By this, I mean that after "bitbake cargo" fails, meta-freescale is checked out to revision "4af1824f3daa13bd2bceafe8de7f371b35e0dfce" in a "detached head" state, where before I ran the command it was checked out to "master". (4af18 is the version of meta-freescale that is currently recorded in my superproject, please note that the only command I have run though is "bitbake cargo". I haven't run a single git command which should affect the checked out version of meta-freescale)
"git reflog" in the affected layers shows that a checkout was executed: "4af1824f (HEAD) HEAD@{0}: checkout: moving from master to 4af1824f3daa13bd2bceafe8de7f371b35e0dfce"
I haven't tracked down what is doing this, but would love a suggestion or help.
--Aaron

This issue is in the wrong github project, sorry about that!


text:
rust packages get desynched

Although the rustc packages appear to keep their revisions in sync now, the combined rust packages do not. Probably I picked the wrong unique id to synchronize on that wasn't actually unique.

Looks like this is still happening for OS X.
➜  ~  sudo rustup
Password:
rustup: CFG_CURL             := /usr/bin/curl (curl 7.37.1 (x86_64-apple-darwin14.0) libcurl/7.37.1 SecureTransport zlib/1.2.5)
rustup:
rustup: processing /Users/hoverbear/bin//rustup args
rustup:
rustup: CFG_PREFIX           :=
rustup:
rustup: validating /Users/hoverbear/bin//rustup args
rustup:
rustup: host triple: x86_64-apple-darwin
rustup: downloading rust installer
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  117M  100  117M    0     0  5430k      0  0:00:22  0:00:22 --:--:-- 6010k
rustup: downloading cargo installer
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 2341k  100 2341k    0     0  2673k      0 --:--:-- --:--:-- --:--:-- 2673k
<--- Removed Rust things --->
install: looking for install programs
install:
install: found mkdir
install: found printf
install: found cut
install: found grep
install: found uname
install: found tr
install: found sed
install: found chmod
install:
install: processing ./rustup-tmp-install/cargo-nightly-x86_64-apple-darwin/install.sh args
install:
install: CFG_DESTDIR          :=
install: CFG_PREFIX           := /usr/local
install: CFG_LIBDIR           := /usr/local/lib
install: CFG_MANDIR           := /usr/local/share/man
install:
install: validating ./rustup-tmp-install/cargo-nightly-x86_64-apple-darwin/install.sh args
install:
install: verifying platform can run binaries
install: verifying destination is writable
install: verifying destination is not the same as source
install: removing file /usr/local/bin/cargo
install: removing file /usr/local/etc/bash_completion.d/cargo
install: removing file /usr/local/share/doc/cargo/LICENSE-APACHE
install: removing file /usr/local/share/doc/cargo/LICENSE-MIT
install: removing file /usr/local/share/doc/cargo/LICENSE-THIRD-PARTY
install: removing file /usr/local/share/doc/cargo/README.md
install: removing file /usr/local/share/man/man1/cargo.1
install: removing file /usr/local/share/zsh/site-functions/_cargo
install: removing component manifest /usr/local/lib/rustlib/manifest-cargo
install: copying file /usr/local/bin/cargo
install: copying file /usr/local/etc/bash_completion.d/cargo
install: copying file /usr/local/share/doc/cargo/LICENSE-APACHE
install: copying file /usr/local/share/doc/cargo/LICENSE-MIT
install: copying file /usr/local/share/doc/cargo/LICENSE-THIRD-PARTY
install: copying file /usr/local/share/doc/cargo/README.md
install: copying file /usr/local/share/man/man1/cargo.1
install: copying file /usr/local/share/zsh/site-functions/_cargo
dyld: Symbol not found: __cg_jpeg_resync_to_restart
  Referenced from: /System/Library/Frameworks/ImageIO.framework/Versions/A/ImageIO
  Expected in: /usr/local/lib/libJPEG.dylib
 in /System/Library/Frameworks/ImageIO.framework/Versions/A/ImageIO
./rustup-tmp-install/cargo-nightly-x86_64-apple-darwin/install.sh: line 737: 35210 Trace/BPT trap: 5       "${CFG_PREFIX}/bin/${TEMPLATE_VERIFY_BIN}" --version > /dev/null
install: error: can't execute installed binaries. installation may be broken. if this is expected then rerun install.sh with `--disable-verify` or `make install` with `--disable-verify-install`
rustup: error: failed to install Cargo

That's a very strange error. I don't know that it's related to this issue though, which is about the version of rustc being inconsistent. Your error seems to be a bug in Cargo? cc @alexcrichton

That... is quite odd! I don't know how Cargo got connected with ImageIO or libJPEG at all. Do you have some environment variables which are affecting the dynamic loader somehow?

@alexcrichton I don't think so. Is there anything I can give you to help with debugging?
➜  ~  where rustc
/usr/local/bin/rustc
➜  ~  where cargo
/usr/local/bin/cargo
➜  ~  rustc --version
rustc 1.0.0-nightly (ba2f13ef0 2015-02-04 20:03:55 +0000)
➜  ~  cargo --version
cargo 0.0.1-pre-nightly (0557065 2015-02-04 23:00:30 +0000)
➜  ~  echo $LD_LIBRARY_PATH

➜  ~  echo $PATH
/Users/hoverbear/bin/:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/texbin:

@Hoverbear OSX uses DYLD_LIBRARY_PATH, not LD_LIBRARY_PATH.

@sfackler That's empty too.
➜ echo $DYLD_LIBRARY_PATH

It's a bit odd... I ran Rustup again and got the same error, but it appears Cargo is now reporting it's up to date.
➜ cargo --version
cargo 0.0.1-pre-nightly (dfd4868 2015-02-06 22:55:29 +0000)

The reason the combined packages are desynced is because buildbot is using an empty commit ID for synchronization: http://buildbot.rust-lang.org/builders/nightly-dist-packaging-win-64/builds/48/steps/checking for synced dist builds/logs/log

Fixed.

@brson You rock!

authors: Hoverbear alexcrichton brson sfackler

repo: rust-lang/rust-buildbot

license_source: bigquery


text:
Update quickcheck to 1.0

Closes #148
Closes #157

r? @JohnTitor

r? @JohnTitor

Done, although I think dependabot is smart enough to close pending PRs for deps that are not required anymore

Done, although I think dependabot is smart enough to close pending PRs for deps that are not required anymore

Ah, I forgot the bot can detect it.
@bors r+

Ah, I forgot the bot can detect it.
@bors r+

:pushpin: Commit 438623d36196e8cb24107d9fc8122c5b25c80efc has been approved by JohnTitor

:pushpin: Commit 438623d36196e8cb24107d9fc8122c5b25c80efc has been approved by JohnTitor

:hourglass: Testing commit 438623d36196e8cb24107d9fc8122c5b25c80efc with merge a223bf31011546df735b9eff9b3b3379a1a0c368...

:hourglass: Testing commit 438623d36196e8cb24107d9fc8122c5b25c80efc with merge a223bf31011546df735b9eff9b3b3379a1a0c368...

:sunny: Test successful - checks-actions
Approved by: JohnTitor
Pushing a223bf31011546df735b9eff9b3b3379a1a0c368 to master...

:sunny: Test successful - checks-actions
Approved by: JohnTitor
Pushing a223bf31011546df735b9eff9b3b3379a1a0c368 to master...

authors: JohnTitor Xanewok bors

repo: rust-lang/rust-semverver


text:
Improve decoding of hex escapes

Sometimes it is necessary to decode big sequence of Unicode hex escapes, like:
"\uF975\uf9bc\uF9A0\uF9C4\uF975\uf9bc\uF9A0\uF9C4..."

Texts with non-Latin characters usually look like this. This PR accelerates the decoding of such strings by 25%.
Before: test json::tests::bench_decode_hex_escape ... bench:      4295 ns/iter (+/- 176)
 After: test json::tests::bench_decode_hex_escape ... bench:      3200 ns/iter (+/- 148)

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see CONTRIBUTING.md for more information.

Nice win!

authors: alexcrichton defuz rust-highfive

repo: rust-lang/rustc-serialize


text:
Sync from rust 028c6f1454787c068ff5117e9000a1de4fd98374

This pulls in the merge commit from syncing to the rust repo. This ensures that git subtree doesn't report a conflict next sync.
(gentle reminder: make sure to not squash merge it this time)

Thanks!
Which option should I use?
"Create a merge commit" or "Rebase and merge"?

Thanks!
Which option should I use?
"Create a merge commit" or "Rebase and merge"?

The "create a merge commit" option.

The "create a merge commit" option.


text:
std use below mod+use not moved to std group

This may very well be me misunderstanding the semantics of these declarations again, but...
Input
use std::fs::File;
use std::io::stdin;

mod output;
use output::Config as OutputConfig;
use output::Output;
use std::error::Error;

Output
use std::fs::File;
use std::io::stdin;

mod output;
use std::error::Error;

use output::Config as OutputConfig;
use output::Output;

Expected output
use std::error::Error;
use std::fs::File;
use std::io::stdin;

mod output;
use output::Config as OutputConfig;
use output::Output;

Meta

rustfmt version: 1.4.36-nightly (7de6968e 2021-02-07)
From where did you install rustfmt?: cargo nightly

.rustfmt.toml:
imports_granularity = "Item"
group_imports = "StdExternalCrate"

I think this is displaying expected behaviour. The relevant implementation states (emphasis mine):

If the next item is a use [...] extract it and any subsequent items that have the same item kind to be reordered [...]

So in other words, it'll apply the StdExternalCrate formatting, but only to use statements that are consecutive. Your example shows this nicely: in your original example, mod output; acts as a delimiter. Considering the two sets of use statements separately, both are regrouped to StdExternalCrate layout as expected.
However, I agree this is ambiguous from reading the option documentation, so I'll see if I can clarify that with a PR and a test case.
https://github.com/rust-lang/rustfmt/blob/272fb42f06479afb62a9503f181540101f67982a/src/reorder.rs#L314-L316

authors: JakeWharton tommilligan

repo: rust-lang/rustfmt


text:
add issue template

fixes https://github.com/rust-lang/security-team/issues/6

r? @alexcrichton

repo: rust-lang/security-team


text:
Extend comments to include new line

Extending the comment to include the new line character as per sublime's other syntaxes (https://github.com/sublimehq/Packages/blob/master/C%23/C%23.sublime-syntax#L66) fixes https://github.com/rust-lang/sublime-rust/issues/195

I'd find this really useful!

authors: dten mistydemeo

repo: rust-lang/sublime-rust

license: mit


text:
Use the procfs crate in minidump for parsing linux memory maps.

There are a handful of tests (and thus functionality) regarding malformed input that we'd have to give up to merge this. This gives up support for parsing files with messed up whitespace and memory map lines that only have partial information (e.g. only the mapped addresses).
I don't think these two cases are important to support, however if we do want to support them I can make some changes to procfs.
I also ran into an odd case in the backwards_range test. As far as I can tell, the code in that test only incidentally failed because the old memory map parser was extremely permissive. The minidump used in that test has an empty or invalid MinidumpLinuxMaps stream (I think?), and the MinidumpStream::read call gets the entire minidump content as the stream bytes, which seems very weird. That definitely should produce an error as far as I'm concerned, so I'm unsure what the original intent of that test was.

https://github.com/eminence/procfs/issues/255

It might be better to just move the parsing code into a new crate, rather than #ifdef'ing out all the Linux-specific code. You could have a crate which just has an API which accepts a &[u8] or a &str or a Read. I'm aware of three other implementations of procmap parsing: 1 2 3

I agree, and hope the procfs maintainer does too. One reason to try to use procfs over other crates is that we want to potentially read other procfs info in the future.

Waiting on a new (initial) version of procfs-core to be published before pulling this out of draft.

@gabrielesvelto procfs-core was finally published in October, so this can be merged.

authors: afranchuk mstange

repo: rust-minidump/rust-minidump


text:
Overflow in division

The following program
use num_rational::Rational64;

fn main() {
    let a = Rational64::new(1, 3000000000);
    let b = Rational64::from_integer(3080000000);
    println!("{}", a / b);
}

panics with
thread 'main' panicked at 'attempt to multiply with overflow', /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/ops/arith.rs:352:1
stack backtrace:
   0: rust_begin_unwind
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/std/src/panicking.rs:578:5
   1: core::panicking::panic_fmt
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:67:14
   2: core::panicking::panic
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/panicking.rs:117:5
   3: <i64 as core::ops::arith::Mul>::mul
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/ops/arith.rs:345:45
   4: <num_rational::Ratio<T> as core::ops::arith::Div>::div
             at /home/shark/.cargo/registry/src/index.crates.io-6f17d22bba15001f/num-rational-0.4.1/src/lib.rs:738:13
   5: t::main
             at ./src/main.rs:6:20
   6: core::ops::function::FnOnce::call_once
             at /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/ops/function.rs:250:5

in this line:
https://github.com/rust-num/num-rational/blob/d89ce12bf9692a83bbe99141f179c8e1f035bbea/src/lib.rs#L737
Both large integers are far from i64::MAX — but their product overflows the 64-bit boundary. Is the panic expected in this case?
This looks similar to #6 because it also happens in division, but I think it's a separate issue.

Both large integers are far from i64::MAX — but their product overflows the 64-bit boundary. Is the panic expected in this case?

Yes, this is expected. The correct fully-reduced result would be "1 / 9223372036854775808", and that denominator is too large for i64. You can use CheckedDiv to guard against the panic though.

Thank you for the explanation. I didn't think about using .checked_div — that works perfectly!

authors: cuviper sharkdp

repo: rust-num/num-rational


text:
Update Float forwarding for MSRV 1.31

Core floats got more methods since these were originally written.

bors r+

repo: rust-num/num-traits


text:
vsock: cargo-audit reports that yaml-rust is unmaintained

In vhost-device-vsock we use the config crate which now has a dependency that is unmaintained as cargo audit is reporting.
I reported to them here: https://github.com/mehcode/config-rs/issues/553
For now we don't have a new version available, so we can wait a bit or find an alternative.

An alternative would be to switch to toml, WDYT?

An alternative would be to switch to toml, WDYT?

yeah, I think we can wait a bit to understand their plan, if they will not fix it, we can switch to toml.
Not great as a change, but we are not stable at all, so it could be okay to change our config format.

They just switched to yaml-rust2 which seems maintained, so we just need to wait for a new config release. I asked about that.

authors: epilys stefano-garzarella

repo: rust-vmm/vhost-device


text:
web-sys: Strange naming scheme for overloaded methods where some params have a different position

Using CanvasRenderingContext2D.drawImage() as example:
The overloads all have dx and dy but overload 3 has them in a different position with sx and sy in their original place. The generated methods however contain dx and dy but never mention sx and sy. Wouldn't a more correct name be draw_image_with_html_image_element_and_sx_and_sy_and_sw_and_sh_and_dw_and_dh?

All of the method names are procedurally generated right now, we're not hand-generating methods like that. Improvements are always welcome though!

authors: alexcrichton martin-t

repo: rustwasm/wasm-bindgen


text:
CI Tests no longer succeeding since recent commit

🐛 Bug description
The recently merged commit https://github.com/rustwasm/wasm-pack/commit/af8eb338425daeffaeea3543e0d2c9c8eec06468 broke the test build::build_different_profiles() in master. As a result all Merge Request pipelines triggered after this merge fail as well even if their changes pass the tests locally.
🤔 Expected Behavior
The tests should succeed as they did on the commit before https://github.com/rustwasm/wasm-pack/commit/af8eb338425daeffaeea3543e0d2c9c8eec06468.
👟 Steps to reproduce
Check out https://github.com/rustwasm/wasm-pack/commit/af8eb338425daeffaeea3543e0d2c9c8eec06468 or any commit after that and run the tests. Alternatively make a new Merge Request against master, tests will also fail.
🌍 Your environment
The environment is the project's own GitHub Actions CI.

Root cause seems to be write_package_json() which does not work nicely with a package.json being processed twice by wasm-pack.

Continueing discussion in https://github.com/rustwasm/wasm-pack/pull/1110

repo: rustwasm/wasm-pack


text:
New project from wasm-pack new fails to build with wgpu, needs edition or resolve change in Cargo.toml

🐛 Bug description
If I create a new project with wasm-pack new, and add wgpu as a dependency it fails to build.   Adding resolver = "2", or "edition = "2021" (which implies the resolver = "2") to Cargo.toml fixes it.  I'm not sure if this is a wasm-pack issue or a wgpu issue.
🤔 Expected Behavior
It should build without errors.
👟 Steps to reproduce
$ wasm-pack new test-wgpu
$ cd test-wgpu
$ cargo add --features webgl wgpu
    Updating crates.io index
      Adding wgpu v0.15.1 to dependencies.
...
$ wasm-pack build
... fails..

Full build output
🌍 Your environment
nment.
wasm-pack version: wasm-pack 0.11.0
rustc version: rustc 1.68.2 (9eb3afe9e 2023-03-27)

Looks like this is documented in the wgpu tutorial, but it would be less surprising if the generated project included the newer edition.


text:
Missing non-linearities: intended ?

❓ Questions & Help
Hi,
For instance, in the gat_conv implementation, there is this line which deals with the update when concatenating the different attention mechanisms:
if self.concat is True:
   aggr_out = aggr_out.view(-1, self.heads * self.out_channels)

It seems to me that there should be some non-linearity here ? Something like:
if self.concat is True:
   aggr_out = F.relu(aggr_out.view(-1, self.heads * self.out_channels))

But actually it is the same for gcn_conv and others. Is this intended ? One could obviously apply non-linearity after a layer, e.g.:
conv1 = GCNConv(16, 32)
conv2 = GCNConv(32, 32)
[...]
h1 = F.relu(conv1(x, edge_index))
h2 = F.relu(conv2(h1, edge_index))
[...]

But this should maybe be specified somewhere ? Because until I checked the code, I would not have guessed, and it does not seem strictly consistent with the message passing general formulation.
Thanks in advance,
Thibault

All operators in PyG do not come with non-linearities. This aligns with PyTorch operators such as conv2d and allows to implement all kind of architectures. We integrate non-linearities after each conv call in all the examples. However, I see a lot of implementations where you need to pass the non-linearity as an argument to the operators, so I get what you are trying to say. IMHO, the way we do it in PyG is much much cleaner. I will add a remark to the documenation.

thanks for the answer @rusty1s ! That makes sense indeed; I did not make the link to other PyTorch operators like conv2d and I think I was trying to stick exactly to the general message passing formulation.
Yes it is mentioned I must have read this too quickly, my bad !
Thibault

thanks for the answer @rusty1s ! That makes sense indeed; I did not make the link to other PyTorch operators like conv2d and I think I was trying to stick exactly to the general message passing formulation.
Yes it is mentioned I must have read this too quickly, my bad !
Thibault


text:
Feature/multi cloud

all cloud parameters toggle between legacy and multicloud mode
Had issue to handle mandatory cloud parameter (that is not mandatory in non legacy mode)

Rebase your commits to squash them into one or two meaningful commits.

Did all the changes requested, if you happy feel free to merge it


text:
Update RUYI doc and fix sidebar

修复边栏
将 RUYI 包管理的内容合并到 ruyi 目录
对 gnu-plct-xthead 工具链增加 revyos 相关提示
对 llvm-upstream 工具链增加 clang-cl 相关提示
编译环境内容增加已经测试的 toolchain 与 profile 组合列表

/lgtm

repo: ruyisdk/docs


text:
Add function and object template factories

This popped up while working on #243.
Ready for review.

What about the 4-arg FunctionTemplate with the final length argument?

Right... I probably was looking at an old v8 header and must have missed it. Will add it later today...

If it wasn't always available we can't really add it. Lowest common denominator and all. I just assumed it was.
On January 19, 2015 11:17:51 AM EET, David Siegel notifications@github.com wrote:

Right... I probably was looking at an old v8 header and must have
missed it. Will add it later today...

Reply to this email directly or view it on GitHub:
https://github.com/rvagg/nan/pull/248#issuecomment-70464467

Hm, I thought about that when implementing Factory<Function>. (Direct construction of Function is only available in newer v8.) I think just offering the LCD is not going to cut it in the long run. A project might target node >=0.10 or io.js. It still wants NaNs future proofing even (or specially) for features that are not part of the LCD (yet). I think a good approach is to wrap new features early and if possible provide graceful degradation on older versions. We already do that for (bound) scripts. If we can't reasonably emulate a feature so be it. It just needs to be documented.
Just my opinion, though.

Yes, where there is not too much work, backporting and emulating is all very good. Just want the external interface to be identical.
I think that something correctly written in proper NAN should work on every supported version. It should not be that parts only work on certain versions.
For that we should have new major versions of NAN that drop support for older nodes and break the API.
i.e. NAN 1 is for 0.8+, NAN 2 for 0.10+, NAN 3 for 0.12+. But nothing is of course set in stone and I don't know how v8 will evolve in the future, this needs to be adapted to reality. io.js claims to update v8 more often, so maybe we have to follow that. Who knows...
See e.g. #208
On January 19, 2015 12:58:53 PM EET, David Siegel notifications@github.com wrote:

Hm, I thought about that when implementing Factory<Function>. (Direct
construction of Function is only available in newer v8.) I think just
offering the LCD is not going to cut it in the long run. A project
might target node >=0.10 or io.js. It still wants NaNs future proofing
even (or specially) for features that are not part of the LCD (yet). I
think a good approach is to wrap new features early and if possible
provide graceful degradation on older versions. We already do that for
(bound) scripts. If we can't reasonably emulate a feature so be it. It
just needs to be documented.
Just my opinion, though.

Reply to this email directly or view it on GitHub:
https://github.com/rvagg/nan/pull/248#issuecomment-70476376

Can't write a test for NanNew<Function> without doing it conditionally on version. Perhaps a conditional define would be the solution? Build with -DNAN_BACKWARDS_COMPATIBLE 1337 or something to get it enabled.

On Jan 19, 2015, at 15:51, Benjamin Byholm notifications@github.com wrote:
Can't write a test for NanNew without doing it conditionally on version.

Just backport the constructor. It just creates a function template and returns the resulting function. I already checked. I can do it tonight...
The length argument requires more doing, though.

Perhaps a conditional define would be the solution? Build with -DNAN_BACKWARDS_COMPATIBLE 1337 or something to get it enabled.

Opt-in seems like the right thing to do (in general). Either with defines or by including additional/different headers.

—
Reply to this email directly or view it on GitHub.

If backporting works, that would be great. From what I have seen, it is usually impossible, as anything that uses v8 "internal" stuff needs to be in the correct classes, and they are all non-extendable. But, if it just does a FunctionTemplate and returns the function, acting like a convenience method, that should indeed work!
Length argument might be impossible for above mentioned reasons. I'll take a quick glance at the code and see.
I like opt-in too. As explicit as possible, that should guard against spurious bug reports for "broken" functionality. Still requires good documentation (better organized than what we currently have).

Length can be done. It just ultimately just does obj->set_length(length);, which can be done externally through FunctionTemplate::SetLength. So, just construct a function template and so SetLength on it before returning.

Unfortunately FunctionTemplate::SetLength() is a new v8 feature, too. Guess, we have to skip the length argument for now... :-/

Crap. Maybe it's possible to use
Object::ForceSet(NanNew("length"), NanNew(length), v8::ReadOnly);
or similar?
@bnoordhuis: Any suggestions?
On Monday 19 January 2015 17:32:17 David Siegel wrote:

Unfortunately FunctionTemplate::SetLength() is a new v8 feature, too.
Guess, we have to skip the length argument for now... :-/

Reply to this email directly or view it on GitHub:
https://github.com/rvagg/nan/pull/248#issuecomment-70590586

I guess it is new because it is part of the ES6 standard.
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-functioninitialize
Let status be DefinePropertyOrThrow(F, "length", PropertyDescriptor{[[Value]]:
len, [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: true}).
On Monday 19 January 2015 17:32:17 David Siegel wrote:

Unfortunately FunctionTemplate::SetLength() is a new v8 feature, too.
Guess, we have to skip the length argument for now... :-/

Reply to this email directly or view it on GitHub:
https://github.com/rvagg/nan/pull/248#issuecomment-70590586

The actual v8 implementation seems to define the property through an accessor pair operating on an internal field of sorts at kLengthOffset.

I want to get this merged so I can push the new versions.
Waiting for backport of Function::New.
Unsure about whether FunctionTemplate::New with length argument is doable, can hold off until later.

Ack. Will finish it tonight.

I found no (good) way to back port Function.length. #define NAN_ENABLE_FUNCTION_LENGTH enables the additional argument. Not sure I like it, though. Maybe we should keep it under the wraps for a bit and think about it some more.
Ready for review.

I think the extra length argument is quite messy, but I can't see a better way of doing it either. I agree with keeping it under the wraps until some future point, preferrably not having it clutter up the code for now. If absolutely necessary at some future point, we can add it in -- provided that no fully compatible solution shows up.

I removed the length argument for now. I'll add another PR to discuss our options.

Excellent. I'll merge this, do some testing and push out the new releases then.

Nope. Fixed.

authors: agnat kkoopa

repo: rvagg/nan


text:
Reference man page from systemd unit files

This silences a Debian packaging lint warning.

FYI, this was merged into https://github.com/keyd-project/keyd-fork as https://github.com/keyd-project/keyd-fork/commit/ca855968097943d2d35805c6414ebc7630b36db2

repo: rvaiya/keyd


text:
Two columns with Foreign key relation with same table

In our project, for some tables, we need to create two columns LoginUserId and ActingUserId in single table. These two columns has foreign key relation with with User table. While creating model class inverse property relations are not creating.

@diptip09 Please share the model information(Primary and Foreign Key Model) where inverse property relations are not generated.

Hello Sir,
The model class is attached here in text format. Note: All CompanyId, DepartmentId, UserId Columns refer to UserId Column of User Table. There is a MemberType Column in User Table which can have values C,D,U  for Company, Department, User resp.
Job.txt

@diptip09 Then mentioned properties are not exits in the provided job.txt file.

I tried to described them in brief. Sorry for incomplete information.
The Attribute list is as below:
BuyerCompanyId, VendorCompanyId, BuyerDepartmentId, VendorDepartmentId, OriginatingDepartmentId, BuyerUserId, VendorUserId

Thanks @diptip09 for the quick response. The issue has been resolved in the new release, please update the project package.

repo: rxweb/RxWebCore


text:
wayland(hyprland): The environment variable is not passed into the nushell's session.

missing SSH_AUTH_SOCK: ssh-add will report an error.
missing EDITOR: default to vi, which is not installed.

Related to: https://github.com/nix-community/home-manager/issues/3100
The problem can be resolved by temporarily switching to bash.

Fixed by #27
Details: https://github.com/ryan4yin/nix-config/issues/26


text:
Unable to install package in Filament 3.X

I am unable to install this package in latest Filament 3.X. Error says it needs Filament 2.X version .

Install v1.0.0-beta5. That has v3 support.

Install v1.0.0-beta5. That has v3 support.

hi Ryan.. thanks it installed fine. But I dint find Navigation menu displaying in my admin panel. I dint even find Navigation resource. i checked the package. Model and migration is fine. Do i need to manually create Navigation resource in Admin panel selecting your model.

You need to make sure you register the Plugin in your PanelProvider class.

You need to make sure you register the Plugin in your PanelProvider class.

It is already registered in my Admin panel.  But I don't see any NavigationResource anywhere.    Do I need to run any publish command further. I rerun publish asset.

Hi Ryan, I got it working. I reinstalled it. I realized that i should  have installed the plugin, then register immediately in panel provider. And then migrate and asset publish.  In previous attempts, I was doing registration after migration. Thanks.

authors: pritborteam ryangjchandler

repo: ryangjchandler/filament-navigation


text:
support ctrlp.vim?

support ctrlp.vim - add icons to mru and various lists ?

http://poll.gitrun.com/ryanoasis/vim-webdevicons/issues/56

+1

+1

+1

This is gonna take some work to do properly and I hope it isn't too bad. So far all I have been able to do is modify ctrlp code directly:

I want to eventually be able to obviously do it a proper way and also to avoid a PR

+1

+1

+1

I have this working with a somewhat ugly/hacky overwrite for the official/original kien/ctrlp.vim and I am going to submit a PR for a simpler implementation for the active fork ctrlpvim

authors: SageEx adambiggs cnicolov muellan nicholasc ryanoasis vitaminless

repo: ryanoasis/vim-webdevicons


text:
No reactivity with solid + electron-webpack

Followup to my previous issue.  I was able to modify the electron-webpack config to run tsx files through babel with babel-preset-solid active, but unfortunately I'm getting no reactivity in my application.
I've created two minimal working examples:

The first does not use Electron, and works as expected.  When the page loads, there is a counter that should increment by one every second.
The second is based on the project above, but I've put the code into the renderer process of a simple Electron app, initialized with electron-webpack-quick-start.

Even though I'm running the same code and nearly the same webpack config (merged with the electron-webpack defaults), the Electron version has no reactivity (the counter remains at zero).  There are no errors in the console.  However, calling createState and createEffect manually still works as expected.
The following files are most important:

src/webpack.base.js is where the webpack config is defined to use babel-loader for .tsx files, along with babel-preset-solid
src/renderer/render.tsx defines the state / JSX needed for a basic counter

I'm new to solid, webpack, and Electron, so it's been quite difficult to pinpoint the issue. My best guess is that I have a problem with my webpack configuration, or that there is an extra transpilation happening which transpiles the JSX before babel-preset-solid has a chance to do its thing.
I will update here as I learn more on my own, but any additional help resolving the issue would be appreciated!  Thanks!

Thanks for the advice!  I verified that there is only one copy of solid-js in my node_modules folder, so that doesn't seem to be the issue.
To pinpoint the issue, I made a new branch in the Electron MWE that uses plain JS/JSX rather than TypeScript.  Unfortunately the issue still persists, so I took a look at the compiled code.  (it should appear in dist/renderer/renderer.js after running npm run compile).
Here's the original JSX:
jsx:
const [count, setCount] = createSignal(0),
timer = setInterval(() => setCount(count() + 1), 1000);
onCleanup(() => clearInterval(timer));
// ...
const AppContent = () => {
	return (
Counter: {count()}
);
}

Compiled versions are shown below, with and without electron.  As you can see, they are compiled in slightly different ways, but as far as I can tell, the electron version should still work, as it's calling createEffect as part of the insert() function.
I'll keep investigating, but since it seems that babel-preset-solid is running as expected, I'm more or less out of ideas.  Thanks in advance for any help you can provide!
compiled (from jsx, no electron):
/* harmony import */ var solid_js_dom__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(/*! solid-js/dom */ "./node_modules/solid-js/dist/dom/index.js");
//...
const [count, setCount] = Object(solid_js__WEBPACK_IMPORTED_MODULE_1__["createSignal"])(0),
      timer = setInterval(() => setCount(count() + 1), 1000);
Object(solid_js__WEBPACK_IMPORTED_MODULE_1__["onCleanup"])(() => clearInterval(timer)); // components
//...
const AppContent = () => {
  return (() => {
    const _el$2 = _tmpl$2.cloneNode(true),
          _el$3 = _el$2.firstChild;

    Object(solid_js_dom__WEBPACK_IMPORTED_MODULE_0__["insert"])(_el$2, () => count(), null);

    return _el$2;
  })();
};

compiled (from jsx, with electron-webpack): (view full source)
Object(external_solid_js_["createEffect"])(() => console.log("\n\nfilePath:", state.filePath, "\n\n\n"));
const [count, setCount] = Object(external_solid_js_["createSignal"])(0),
      timer = setInterval(() => setCount(count() + 1), 1000);
Object(external_solid_js_["onCleanup"])(() => clearInterval(timer)); // components
//...
const AppContent = () => {
  return (() => {
    const _el$2 = _tmpl$2.cloneNode(true),
          _el$3 = _el$2.firstChild;

    insert(_el$2, () => count(), null);

    return _el$2;
  })();
};
// where `insert` is defined as...
function insert(parent, accessor, marker, initial) {
  if (marker !== undefined && !initial) initial = [];
  if (typeof accessor !== "function") return insertExpression(parent, accessor, initial, marker);
  createEffect(current => insertExpression(parent, accessor(), current, marker), initial);
}

Thanks I see the problem but I'm trying to figure out how to fix it. It looks like solid-js is marked as external which is what is being used in by your user code, but a version is also being bundled in your build probably coming in from solid-js/dom. So you have the 2 copies of Solid problem. I'm gathering the intention is not to bundle solid-js/dom. So it should be added to externals in the same way solid-js is. I just didn't see that in your custom config.

Thanks for the tip about externals!  I am not manually defining any externals, but when I print the config.externals defined by electron-webpack, solid-js does indeed appear in the list:
externals : ["solid-js", "source-map-support", "electron", "webpack", "electron-devtools-installer"]

So, this is definitely unexpected behavior arising from either electron-webpack or webpack itself.  After some digging, I found an option for whitelisting modules in electron-webpack:

Since webpack is set to target the electron environment, all modules are treated as externals. Unfortunately, there can be a few situations where this behavior may not be expected by some modules. For the case of some Vue UI libraries that provide raw *.vue components, they will needed to be white-listed. This ensures that vue-loader is able to compile them as the UI library originally expected.

Adding the following to my package.json did the trick:
"electronWebpack": {
  "whiteListedModules": ["solid-js"]
}

Some relevant links about the electron-renderer webpack target for future visitors:

plugins loaded by electron-renderer target and docs
webpack externals
webpack-externals-plugin

Thanks very much for all your help, this issue has been quite the headache!  I appreciate the quick response time, on a Saturday no less!  I'll push my solution to the mwe repo for any future visitors.

That's great. Although I suspect if the default is to external that the preferred solution might be add solid-js/dom to the externals rather than whitelist solid-js. I wonder if they construct the list from package.json. In either case I'm glad it works.

authors: benrbray ryansolid

repo: ryansolid/solid


text:
🛑 Linked Events is down

In 9289c08, Linked Events (https://linkedevents.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Linked Events is back up in b615872 after 14 minutes.

repo: rybesh/status


text:
Add option "Copy HTTP URL to this file"

Would be very useful if we can have an option to copy a configurable HTTP path to the file.
We already have the option to copy the full path. eg:
L:\repository\project-trunk3\admin_page\manager\script\test_access.php

But to test manually the code I need to input this in browser:
http://1.2.3.4/myproject/admin_page/manager/script/test_access.php

Of course, it's necessary to exist an option somewhere we can define the new prefix (based on full path) "L:\repository\project-trunk3" replaced by "http://1.2.3.4/myproject/" (and remaining backslashes replaced by slashes).

Thank you for a suggestion!
I recognized the useful situation you mentioned, but I disagree to introduce the functionality.
There are two reasons I thought that:

The situation is rare in recent development using modern web application frameworks.
In most of modern web application frameworks, end points are separated from file paths by a router.
I think config.cson should not contain settings of mapping paths to URLs because config.cson should be as portable as possible.
The mapping is project specific settings, so the best way will be that it is put in the project root like .gitignore, package.json, .eslintrc etc.,
but I'm not planing to make an original configuration file like them.

Ok, I understand your point. I will try to implement myself, thanks.

authors: llagerlof s-shin

repo: s-shin/atom-copy-path


text:
[Test] new controlnet (animatediff_controlnet))

https://github.com/s9roll7/animatediff-cli-prompt-travel/assets/118420657/aa3622ae-693b-4d83-96b2-5dd27b840057
original / animatediff_controlnet + controlnet_openpose(0.5)  / animatediff_controlnet + controlnet_openpose(0.5)
1024x1280
animatediff stylize create-config PATH_TO_MOVIE_FILE -gh
animatediff stylize create-region PATH_TO_STYLIZE_DIR
animatediff stylize generate PATH_TO_STYLIZE_DIR

Hey @s9roll7, tried your exact commands but it seems like the background is not generated properly and looks green a bit. Here is my
prompt.json. What could be wrong?

Original
Generated

Hey @s9roll7, tried your exact commands but it seems like the background is not generated properly and looks green a bit. Here is my prompt.json. What could be wrong?
Also it seems like animatediff_controlnet did not ran and it requires some conditioning images. What preprocess images have you supplied for openpose?
Original	Generated
input_.mp4
output_.mp4

The json file looks fine.
I'm guessing 00_controlnet_image\animatediff_controlnet is empty?
If there's nothing in the directory, nothing will happen.
You need to copy all the images in controlnet_openpose to animatediff_controlnet.

https://github.com/s9roll7/animatediff-cli-prompt-travel/assets/118420657/e65e0dcc-1ce3-4389-9361-51690df1176d
original / animatediff_controlnet + controlnet_openpose
896x768
generation time 196sec (4090)
vram 10.3 GB
animatediff stylize create-config PATH_TO_MOVIE_FILE -gh
animatediff stylize generate PATH_TO_STYLIZE_DIR

use the animatediff_controlnet , 4090,speed too slow, share DDR4 RAM 6gb.not in 4090 24GB VRAM

    "controlnet_map": {
        "input_image_dir": "..\\stylize\\2023-12-06T13-02-02-sample-mistoonanime_v20\\00_controlnet_image",
        "max_samples_on_vram": 200,           # <-----------
        "max_models_on_vram": 3,                # <---------
        "save_detectmap": true,

use the animatediff_controlnet , 4090,speed too slow, share DDR4 RAM 6gb.not in 4090 24GB VRAM

    "controlnet_map": {
        "input_image_dir": "..\\stylize\\2023-12-06T13-02-02-sample-mistoonanime_v20\\00_controlnet_image",
        "max_samples_on_vram": 200,           # <-----------
        "max_models_on_vram": 3,                # <---------
        "save_detectmap": true,

thank you！

Hello, I used the img2img function in Stable Diffusion 1.5, which only added prompt words. The effect is quite different from that of Animatediff cli prompt travel. How can I maintain better consistency with SD? Thank you

Hello, I used the img2img function in Stable Diffusion 1.5, which only added prompt words. The effect is quite different from that of Animatediff cli prompt travel. How can I maintain better consistency with SD? Thank you

Hello, I used the img2img function in Stable Diffusion 1.5, which only added prompt words. The effect is quite different from that of Animatediff cli prompt travel. How can I maintain better consistency with SD? Thank you

hi, can you share your json?

authors: AivoGenX KaustubhPatange aycaecemgul dancemanUK s9roll7 yanchaochi


text:
bug: v3 Navbar and Footer are not displayed correctly using Sveltekit

What version of daisyUI are you using?
v3.0.1
Describe your issue
After upgrading to v3 the navbar and the footer components stopped working correctly. Here's a screenshot of the Navbar with menu and submenu which I copied from the docs in my project.

Or here the footer with the logo section from the documentation:
.
Other components I checked so far are working just fine.
To check if some of my custom CSS doesn't interfere with DaisyUI, I deleted all of it the custom CSS temporarily but without success. The Navbar and Footer were looking the same. It doesn't make a difference if I use dev mode or the preview of the build. I tried to compare my configs with the sveltekit stackblitz one but this projects is not yet upgrade to v3. Any other ideas?
What browsers are you seeing the problem on?
No response
Reproduction URL (optional)
No response

It's probably a problem with your tailwind.config.js
Make sure the path to all your template files (any file that you have class names inside it) is addressed in content
https://tailwindcss.com/docs/content-configuration
Also make sure you're using the class names as a whole string (not half-variable):
https://tailwindcss.com/docs/content-configuration#dynamic-class-names
Let me know if these didn't fix the issue.

we were absolutely right 👍

authors: jaads saadeghi

repo: saadeghi/daisyui


text:
Routing error: Class does not exists

I am using annotations in my project and this my controller code:-
`<?php
namespace SaadTazi\GChartBundle\Controller;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpFoundation\Request;
use SaadTazi\GChartBundle\DataTable;
use SaadTazi\GChartBundle\Chart\PieChart;
class MychartController extends Controller
{
public function showAction() {

    $dataTable2 = new DataTable\DataTable();
    $dataTable2->addColumn('id1', 'label 1', 'string');
    $dataTable2->addColumnObject(new DataTable\DataColumn('id2', 'label 2', 'number'));
    $dataTable2->addColumnObject(new DataTable\DataColumn('id3', 'label 3', 'number'));

    //test cells as array
    $dataTable2->addRow(array(
        array('v' => 'row 1'),
        array('v' => 2, 'f' => '2 trucks'),
        array('v' => 4, 'f' => '4 bikes')
    ));
    //simple cell (not an array)
    $dataTable2->addRow(array('row 2', 5, 1));
    //mixed
    $dataTable2->addRow(array('row 3', array('v' => 5), 10));
    $dataTable2->addRow(array('row 4', array('v' => 2), 0));
    $dataTable2->addRow(array('row 5', array('v' => 0), 10));
    $dataTable2->addRow(array('row 5', 10, 0));
    $dataTable2->addRow(array('row 5', 4, 5));

    return $this->render(
                'SaadTaziGChartBundle:Demo:demo.html.twig',
                array('dataTable2' => $dataTable2->toArray());
}

}`
Now if I visit any page of the site it throws error

Class SaadTazi\GChartBundle\Controller\MychartController does not exist in D:\xampp\htdocs\pmatsoftware\src\AppBundle/Controller/ (which is being imported from "D:\xampp\htdocs\pmatsoftware\app/config/routing.yml").

Can you explain how to manage/import routing for this bundle

Hi @prakashsinghgaur,
Did you register Saadtazi in app/autoload.php as stated in the README?
Disclaimer: It's been a long time I didn't use Symfony, so I am not sure if what I am suggesting is still "the way to do it".

inactive issue... closing .

authors: prakashsinghgaur saadtazi

repo: saadtazi/SaadTaziGChartBundle


text:
Namespace declarations should end in \\

Please note namespace declarations should end in \\ to make sure the autoloader responds exactly.

https://getcomposer.org/doc/04-schema.md#psr-0

Thanks a lot!

You're welcome.

authors: sabberworm szepeviktor

repo: sabberworm/PHP-CSS-Parser


text:
Suggestion: Give top module the same name as package name

Currently, the library is called aja but the main module is called just A.
As per Elixir's library guidelines, this is a bit of an antipattern.
My suggestion would be to name the main module also Aja.
If people really want to use the shorter name, they can always alias the module in their local code.
What do you think? :slightly_smiling_face:

This is a very good point, thanks for opening this issue :heart:
I thought this was a bit of a grey area, but I didn't realize it was in violation of the official guidelines.
Luckily Aja is already quite short, so it will only add two letters :slightly_smiling_face:

authors: Qqwy sabiwara

repo: sabiwara/aja


text:
Update the game over message

Update the game over message so people know how to play again!

.


text:
fix: Change gnosis-safe.io links to safe.global

As discussed in Slack
What it solves

Updates gnosis-safe.io links to safe.global
Updates the README

How to test

Open the landing page
Observe no links that go to gnosis-safe.io except on the terms page (this will be updated at a later time)

This link takes to the releases of safe react (so gnosis-safe.io). I think we should change it to web-core releases

authors: francovenica usame-algan

repo: safe-global/safe-landing-page


text:
load_dataset issue

code lines from readme.md :
train_df = load_dataset('sagteam/cedr', name='enriched', split='train')
test_df = load_dataset('sagteam/cedr', name='enriched', split='test')
crash with FileNotFoundError.
This works fine:
train_df = load_dataset('cedr', name='enriched', split='train')
test_df = load_dataset('cedr', name='enriched', split='test')

You are right! This is a legacy from the local test version.
Thanks a lot!

authors: SaranaAbidueva naumov-al


text:
[BUG] Direct install from repository gives Atari errors on import

To Reproduce
Installed via
python -m pip install 'envpool @ git+https://github.com/sail-sg/envpool'

It seems to work, but importing gives
>>> import envpool
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/jbuckman/.local/lib/python3.9/site-packages/envpool/__init__.py", line 16, in <module>
    import envpool.entry  # noqa: F401
  File "/home/jbuckman/.local/lib/python3.9/site-packages/envpool/entry.py", line 16, in <module>
    import envpool.atari.registration  # noqa: F401
  File "/home/jbuckman/.local/lib/python3.9/site-packages/envpool/atari/__init__.py", line 19, in <module>
    from .atari_envpool import _AtariEnvPool, _AtariEnvSpec
ModuleNotFoundError: No module named 'envpool.atari.atari_envpool'```

## System info

```python
>>> import numpy, sys
>>> print(numpy.__version__, sys.version, sys.platform)
1.23.0 3.9.6 (default, Jul 12 2021, 18:23:59)
[GCC 9.3.0] linux

Checklist

[ x] I have checked that there is no similar issue in the repo (required)
[ x] I have read the documentation (required)
[ x] I have provided a minimal working example to reproduce the bug (required)

You cannot use this method to install, instead, use bazel via make bazel-release. Otherwise the binary won’t be compiled.

repo: sail-sg/envpool


text:
true positive or false positive and data set

can u please add (true positive and false positive rate) so we can find the accuracy of this model?
it's very urgent b

#9


text:
feat: adds additional commit types

Adds additional Angular commit types from https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type and makes the cli.js executable

This may need additional linting after #1  is merged.

@saintedlama  This may be where you can enable my user to run the workflows without me being a collaborator.

I really like what you built with this package. Its simple and I can wrap my head around it! I'm pulling it into all of my projects slowly!

Got it!  I'll pull that part out. Work has been crazy, so I'll probably do
it this weekend.
--
Beau Raines
@.***
425.654.4663 (voice and sms)
beau.raines (skype)
LinkedIn www.linkedin.com/in/beauraines/
On Sun, Mar 12, 2023, 11:02 PM Christoph Walcher @.***>
wrote:

@.**** commented on this pull request.
In cli.js
https://github.com/saintedlama/should-release/pull/2#discussion_r1133471596
:

   shouldRelease = true;

   minor++;

} else if (commit.type === "fix") {

} else if (commit.type === "build" ||  "chore" || "ci" || "docs" || "fix" || "style" || "refactor" || "test") {

the idea in this minimal module is to prevent releases for build, chore,
ci, docs, style, refactoring, and test changes. Meaning those changes do
not require a new version to be published. I think it does not make sense
to publish a package for build, chore, ci, docs, style, test or refactor,
... changes
In cli.js
https://github.com/saintedlama/should-release/pull/2#discussion_r1133471715
:

@@ -35,10 +35,10 @@ function whatBump(commits) {
if (commit.notes.length > 0) {
shouldRelease = true;
major++;

} else if (commit.type === "feat") {

} else if (commit.type === "feat" || "perf") {

👍
—
Reply to this email directly, view it on GitHub
https://github.com/saintedlama/should-release/pull/2#pullrequestreview-1336288342,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQV3MP3KDK2RFWDEWSYSVLW32Z57ANCNFSM6AAAAAAVP4NJZU
.
You are receiving this because you authored the thread.Message ID:
@.***>

repo: saintedlama/should-release


text:
Send Email Authentication Email send issues or  unclear about this.

Here i see  you use this routes
router.post('/send-verification-email', auth(), authController.sendVerificationEmail);
but I have some question. this is used where the    didn't active their account and token   validate date expires then need to send token again  .
But you use auth(). how it work? i think passport use token and check the user is authenticate or not. but here I see you use.  how the user get token without login or  validate their account?

The /send-verification-email route is used when a user wants to verify their email. The user has to be logged in for their email to be retrieved; that's why there is an auth() middleware. The access token is just used to confirm the user is logged in. The user will then get an email with a verify-email token which will verify their email once clicked.

i see you sent a verify-email and sent a token using params.
how it works and how I can get this token. I am not clear about this process.
first, when the user completes registration he gets a verifying email for email verification,  then he clicks the link and token add /verify-email?token=token, when he clicks this link he verifies this email. but how work /send-verification-email?

Please go through the code and you will get the answers to your questions. The 'Issues' section is not for getting explanation of how the code works; it's for reporting a problem with the code.
That said, you get the token from the email as I said in my previous comment.


text:
Progress update for 5th Feb 2022 (Day 14)

Learnt about functions in Go.

/lgtm @anubha-v-ardhan Keep learning.


text:
Contact Form Static

Hey, while on your site I noticed that only your contact form is static, can I make it dynamic by integrating it with EmailJS

go ahead

okay thanks

authors: Sajid-tech sajidhussaindev


text:
Yasirub first action

adds new demo action

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant yasirub

repo: saleor/react-storefront


text:
Pretrained model for prediction

Can you kindly elaborate on how we can use the fine-tuned checkpoints for the prediction of new data in concode task?
Say this is my prediction data:
{"code": "public integer sum(Integer arg0,Integer arg1) {return result;}", "nl": "Add two integers. concode_field_sep int sum concode_field_sep int result"}
If I understand correctly then concode is supposed to complete these functions. However, I am not sure how to generate prediction on this sample data.
I tried replacing the test file containing original test data with this sample test data and then ran this command
python run_exp.py --model_tag codet5_small --task concode --sub_task none
This command starts with training, then evaluating and finally testing. However, I am interested in only prediction. Isn't there any way to directly generate predictions from fine-tuned model on concode ?
Kindly let me know if I am doing something wrong.

Hi, if you only want to use the pretrained models for testing, you can simply remove the --do_train --do_eval in here and pass the pretrained model path via adding --load_model_path your/pretrained/model/path.

Thanks a lot for your reply. Can you also provide a link to your pretrained concode model. Is it the same as that of fine-tuned model checkpoints that you have provided in your repo?

We have released all fine-tuned CodeT5-base checkpoints at here:)

authors: surtantheta yuewang-cuhk


text:
Support new models

Hi,
Is it possible to have the library dynamically support other models such as GraphCodeBERT, and PLBART?
Thanks.

What about Code Llama?

authors: FahadEbrahim cmosguy

repo: salesforce/CodeTF


text:
Is there a way to create a store dynamically?

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[x] Support request
[ ] Other... Please describe:

Is there a way to create a store dynamically using Akita? I get models from the backend and I want to create an entity store for these models in runtime. Something like createStore from redux. Thx :)

Before getting hands with Akita, I checked the issues on the repo, and saw this one.
I didn't have in mind a real case scenario or a reason of why I would need this, although this sounded interesting to have it into consideration when choosing between angular-ngrx-data, ngxs or just ngrx entities.
Now today I got into a design dilemma that just takes this into consideration...
Let's say we have a Comparing-App that has 2 views/components that show/list the same kind of items, for example, cars.
But those items may come from different source and may have different additional internal details/data on each item, but each of the 2 view/components would render common properties of each item.
So in this case, we can have 2 options:

We can either create code for 2 store classes with different store names, or
Handle by hand 2 lists of ids in the store as additions of the base CarStore's EntityState.

The 2nd option would leave useless some of the included functionality offered oriented to handling entities, as the store focuses on having 2 collections of the same entity. In this case we may even consider just handling by hand a simple Store instead of a EntityStore for this needs.
Instead, I would prefer having the option to dynamically instantiate another CarStore with a different name, so I could easily handle cars for each component individually.
Hope this case may serve as an example.

I'm not sure what you mean. If you have one Entity, for example, a Car, why do you need two stores? I need a concrete example, please.

may have different additional internal details/data on each item

If each entity is still a Car, it should be in a CarsStore.

for example, I have several dozen entities and one dynamically generated view. the number of entities is not known in advance. the backend sends the entity description. I need to create an entity store dynamically at runtime using this description.
In redux i can do it using createStore function.

I made change changes to make it possible to set different names to store instances at creation time (on the constructor). This is optional, and would default to the name on the @StoreConfig() name.
It also supports passing a function, so the name can be set based on the  @StoreConfig() name.
I didn't ended using it by the moment, but the tests and my POC using it worked correctly.
Somehow it feels kind of an antipattern, as the Stores classes are intended to be used as singletons.
Nevertheless it may serve anyone that requires a sister Store or a clone Store, so I think it would be useful to support this.
Documentation update on the GitHub pages is what it would be missing in case this get considered for merging.

@edmundo096 that's nice, but I can't see where it can be useful.

Somehow it feels kind of an anti-pattern, as the Stores classes are intended to be used as singletons.

Agree.
If will see that for some good reason, others need this functionality, we'll add it. Thanks.

@zvnt

I need to create an entity store dynamically at runtime using this description.

Can you send an example of this description?

I think this can be used for sub-collection. ex) Firebase's Firestore. Sub-collection can only be obtained by knowing the parent's collection name and id. And each parent id must be stored separately.
Or, if there is a way to effectively save a sub-collection in Firestore through Akita, please let me know
.
Thank you for making a good library.

@dminine thanks, but I still need a concrete example of a JSON structure to understand the use case.

Closed due to inactivity.

I am wondering did u find your solution? I have the same question

https://netbasal.gitbook.io/akita/general/dynamic-stores

The above link is dead

https://datorama.github.io/akita/docs/angular/local-state/#dynamic-stores

second one is also dead)

https://datorama.github.io/akita/docs/angular/local-state/#dynamic-stores

authors: NetanelBasal ambeur dminine edmundo096 elhamabbasi mayankkalbhor studentx183 zvnt

repo: salesforce/akita


text:
Picklist accessibility: focus on Escape; communicate selected state.

From accessibility review of Lightning Dashboards:

inline Picklist doesn't close on Escape. When a Picklist is embedded into a Popover, Escape causes the Popover to close. When Escape is pressed to close the Picklist, user focus should be placed on the trigger button.
Picklist doesn’t communicate selected state (using VoiceOver)

Demo code for issue 1 (based on https://react.lightningdesignsystem.com/components/popovers/)
import React from 'react';
import Popover from 'design-system-react/components/popover';
import Button from 'design-system-react/components/button';
import Icon from '../../components/icon';

const panelContent = (
  <Picklist
     isInline={true}
     label="Show Me"
     options={[
       { label: 'All Products', value: 'all-products' },
       { label: 'All Wackamoles', value: 'all-Wackamoles' }
    ]}
    placeholder="Select record type"
  />
);

const Example = React.createClass({
	displayName: 'PopoverExample',

	render () {
		return (
			<div>
				<Popover
					ariaLabelledby="ALTERNATIVE-HEADING"
					body={panelContent}
				>
					<Button label="Trigger Popover" />
				</Popover>
			</div>
		);
	}
});

ReactDOM.render(<Example />, mountNode);

Demo for issue 2: https://react.lightningdesignsystem.com/components/picklist-menus/
@SiTaggart

Closing. Feel free to re-open for Combobox.

authors: interactivellama minevskiy

repo: salesforce/design-system-react


text:
Resolve broken URL in citation

Hello!
This PR should speak for itself.
I'm looking forward to experimenting more with this model soon, well done on it.

Tom Aarsen

Hmm, I went through the CLA signing process, got an error that the CLA could not be signed and that I should contact someone at Salesforce. When retrying, I get this instead:

This looks to have been resolved in 1ef75f463e7af7e3ae8a6a2752c32469a2652edb. I'll close this now :)

repo: salesforce/xgen


text:
Issue 140 solved

📝 Description
The homepage had a blank space on landing, when viewed on a small screen.
🔧 Fixes #(issue)

Added a 'media' rule
Changed some of the attributes of the wrapper class

📷 Provide related Screenshot/Gifs if any.

[x] I have performed a self-review of my own code.
[x] I'm a contributor in Hacktoberfest'21.

can you please give some clarity regarding the image you provided, I am not able to figure out what is this, is it the top section of the home page on a smaller screen or what? @procastihooman

Yes, it's the top section of the homepage on a smaller screen. Initially, it was just a blank space.


text:
URLPath origin/base can be lost

unsafeUnwrap(fromStringO("//x")) = new URL("https://x")

The only bug I can see this causing is that isURLPath would fail its check.
A generalised path parser for URL which URLPath could use here in fromString may be helpful.

https://github.com/samhh/fp-ts-std/commit/49f3ccb3459e11a87e4bcea5d6a26e95c7de3799

repo: samhh/fp-ts-std