text:
Terminal crashes when running git log

Windows Terminal version (or Windows build number)
Windows Build: 10.0.19042.964, Windows Terminal commit c3ca94cecaef5a9b22e94a7c34983b19cf77e252 built using Visual Studio 2019 16.9.3
Other Software
PowerShell 7.1.3
oh-my-posh 3.133.1
posh-git 1.0.0
git 2.31.1.windows.1
Steps to reproduce

Start any shell with access to git (powershell, git bash, cmd)
git clone the windows terminal repo
git checkout master
git log
press space enough times to see this screen, one more space will kill it depending on the number of lines in the terminal

Expected Behavior
git log shouldn't cause wtd to crash.
Actual Behavior

Press space after this screen and it wtd will crash leaving the following windows event log entry.
Fault bucket 1724119567131471671, type 5
Event Name: MoAppCrash
Response: Not available
Cab Id: 0
Problem signature:
P1: WindowsTerminalDev_0.0.1.0_x64__8wekyb3d8bbwe
P2: praid:App
P3: 0.0.0.0
P4: 6091d600
P5: DWrite.dll
P6: 10.0.19041.804
P7: 2f618cb5
P8: c0000005
P9: 00000000000cf34e
P10:
Attached files:
\?\WERD4E7.tmp.mdmp
\?\WERD630.tmp.WERInternalMetadata.xml
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERD641.tmp.xml
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERD64F.tmp.csv
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WERD67E.tmp.txt
These files may be available here:
\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_WindowsTerminalD_14915a2eb4f1c128f427ee9d7511ba25d013a0ff_a3463a88_f44a4158-0e6d-4109-867f-3e07b7600941
Analysis symbol:
Rechecking for solution: 0
Report Id: b377ecbe-9dab-4a05-beea-55614e8d7bb0
Report Status: 268435456
Hashed bucket: c432aee12ffbe1ec97ed4d9c8d2bef37
Cab Guid: 0
CrashDetails.zip
settings.zip

Since it looks like you built this yourself, can you get us a stack trace from Visual Studio?

Wow, this trivially reproduces on another build as well. What on earth?

If you move line by line, it looks like it crashes displaying...
* [x] Tests added/passed 🎉🎉🎉

@skyline75489 I am betting this is in text simplicity detection 😉
00 (Inline Function) --------`--------     Microsoft_Terminal_Control!std::accumulate+0xa [C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.28.29910\include\numeric @ 35]
01 (Inline Function) --------`--------     Microsoft_Terminal_Control!std::accumulate+0xa [C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.28.29910\include\numeric @ 44]
02 00000063`1eafeec0 00007ff8`54a5cd7b     Microsoft_Terminal_Control!Microsoft::Console::Render::CustomTextLayout::_CorrectGlyphRun+0x220 [E:\BA\89\s\src\renderer\dx\CustomTextLayout.cpp @ 771]
03 00000063`1eafefd0 00007ff8`54a5b65b     Microsoft_Terminal_Control!Microsoft::Console::Render::CustomTextLayout::_CorrectGlyphRuns+0x3b [E:\BA\89\s\src\renderer\dx\CustomTextLayout.cpp @ 493]
04 00000063`1eaff000 00007ff8`54a4db2c     Microsoft_Terminal_Control!Microsoft::Console::Render::CustomTextLayout::Draw+0x1ab [E:\BA\89\s\src\renderer\dx\CustomTextLayout.cpp @ 140]
05 00000063`1eaff060 00007ff8`54a46538     Microsoft_Terminal_Control!Microsoft::Console::Render::DxEngine::PaintBufferLine+0xfc [E:\BA\89\s\src\renderer\dx\DxRenderer.cpp @ 1649]
06 00000063`1eaff110 00007ff8`54a45ab8     Microsoft_Terminal_Control!Microsoft::Console::Render::Renderer::_PaintBufferOutputHelper+0x978 [E:\BA\89\s\src\renderer\base\renderer.cpp @ 837]
07 00000063`1eaff4e0 00007ff8`54a43c8d     Microsoft_Terminal_Control!Microsoft::Console::Render::Renderer::_PaintBufferOutput+0x4f8 [E:\BA\89\s\src\renderer\base\renderer.cpp @ 679]
08 00000063`1eaff6c0 00007ff8`54a43785     Microsoft_Terminal_Control!Microsoft::Console::Render::Renderer::_PaintFrameForEngine+0x46d [E:\BA\89\s\src\renderer\base\renderer.cpp @ 162]
09 00000063`1eaff7c0 00007ff8`54a486b1     Microsoft_Terminal_Control!Microsoft::Console::Render::Renderer::PaintFrame+0x85 [E:\BA\89\s\src\renderer\base\renderer.cpp @ 81]
0a

I can’t repro this locally. Perhaps I’m not seeing exactly what you guys are seeing?
I can’t see the emojis. Instead I see a bunch of Unicode encoding like this:
Tests added/passed <9F><8E>

I finally got the repro (thanks to WSL) and the fix. Thanks @dougheeren for catching this!

I can’t see the emojis. Instead I see a bunch of Unicode encoding like this:
Tests added/passed <9F><8E>

i thought one of the recent git for windows update fixed this, it has to do with less that assumes $LANG="c" if there is no %LANG% in the environment block

@skyline75489 @DHowett  You're welcome! I'm sorry I logged last night after reporting this. And I see I said master when it should have been main...DOH. Here is the stack trace, though it seems you've already found the issue. Hopefully, it confirms your findings.

Microsoft.Terminal.Control.dll!std::_Vector_const_iterator<std::_Vector_val<std::_Simple_types>>::_Verify_offset(const __int64 _Off) Line 113
at C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.28.29910\include\vector(113)
Microsoft.Terminal.Control.dll!std::_Vector_const_iterator<std::_Vector_val<std::_Simple_types>>::operator+=(const __int64 _Off) Line 120
at C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.28.29910\include\vector(120)
Microsoft.Terminal.Control.dll!std::_Vector_const_iterator<std::_Vector_val<std::_Simple_types>>::operator+(const __int64 _Off) Line 126
at C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.28.29910\include\vector(126)
Microsoft.Terminal.Control.dll!Microsoft::Console::Render::CustomTextLayout::_CorrectGlyphRun(const unsigned int runIndex) Line 771
at C:\Users\dough\source\repos\terminal\src\renderer\dx\CustomTextLayout.cpp(771)
Microsoft.Terminal.Control.dll!Microsoft::Console::Render::CustomTextLayout::_CorrectGlyphRuns() Line 493
at C:\Users\dough\source\repos\terminal\src\renderer\dx\CustomTextLayout.cpp(493)
Microsoft.Terminal.Control.dll!Microsoft::Console::Render::CustomTextLayout::Draw(void * clientDrawingContext, IDWriteTextRenderer * renderer, float originX, float originY) Line 140
at C:\Users\dough\source\repos\terminal\src\renderer\dx\CustomTextLayout.cpp(140)
Microsoft.Terminal.Control.dll!Microsoft::Console::Render::DxEngine::PaintBufferLine(const gsl::span<Microsoft::Console::Render::Cluster const ,-1> clusters, const _COORD coord, const bool __formal, const bool __formal) Line 1649
at C:\Users\dough\source\repos\terminal\src\renderer\dx\DxRenderer.cpp(1649)
Microsoft.Terminal.Control.dll!Microsoft::Console::Render::Renderer::_PaintBufferOutputHelper(Microsoft::Console::Render::IRenderEngine * const pEngine, TextBufferCellIterator it, const _COORD target, const bool lineWrapped) Line 837
at C:\Users\dough\source\repos\terminal\src\renderer\base\renderer.cpp(837)
Microsoft.Terminal.Control.dll!Microsoft::Console::Render::Renderer::_PaintBufferOutput(Microsoft::Console::Render::IRenderEngine * const pEngine) Line 711
at C:\Users\dough\source\repos\terminal\src\renderer\base\renderer.cpp(711)
Microsoft.Terminal.Control.dll!Microsoft::Console::Render::Renderer::_PaintFrameForEngine(Microsoft::Console::Render::IRenderEngine * const pEngine) Line 162
at C:\Users\dough\source\repos\terminal\src\renderer\base\renderer.cpp(162)
Microsoft.Terminal.Control.dll!Microsoft::Console::Render::Renderer::PaintFrame() Line 80
at C:\Users\dough\source\repos\terminal\src\renderer\base\renderer.cpp(80)
Microsoft.Terminal.Control.dll!Microsoft::Console::Render::RenderThread::_ThreadProc() Line 206
at C:\Users\dough\source\repos\terminal\src\renderer\base\thread.cpp(206)
Microsoft.Terminal.Control.dll!Microsoft::Console::Render::RenderThread::s_ThreadProc(void * lpParameter) Line 152
at C:\Users\dough\source\repos\terminal\src\renderer\base\thread.cpp(152)
[External Code]
I enjoy using Windows Terminal and I'm glad I can contribute to it.

authors: DHowett LuanVSO dougheeren skyline75489

repo: microsoft/terminal


text:
Add Toolbar for WSL OS instances

Please add a left toolbar (for example like Opera browsers' toolbar) to open WSL OS in single click.

I've triaged this and kept the backlog tag. We're not very likely to do it, but somebody could once we have extensions!

source: gharchive/issue

authors: DHowett-MSFT derkan

license: MIT

license_type: permissive

license_source: github-api


text:
Additional password to launch a profile session

Description of the new feature/enhancement

An option to add an additional password to a specific session when opening a new profile.
I already use ssh keys, however anyone with access to my system can launch a session easily.
Adding a password would make profile more secure.
Proposed technical implementation details (optional)
Simple password checker on specific/global profile launch

Enable local password security per profile.

I'm sorry. Windows Terminal has no intention of becoming a security product, and I do not want to offer our users something that would ultimately be less safe for them then ensuring that they have secure user accounts.

authors: AliMickey DHowett


text:
Update the titlebar visibility when we gain/lose focus too

We forgot to updateTheme again when we change the titlebar color. That would result in us setting the titlebar visibility only when the settings were reloaded, but if the unfocused BG was opaque, and the focused was transparent, we'd use the current unfocused color to set the titlebar visibility.
Also, this fixes a bug with tabRow.BG: terminalBackground
from teams for brevity

tabRow.BG = terminalBackground might not work, and here's why
the termcontrol's BG brush might be (r,g,b, 255), with an Opacity of 0
so my "use mica when the brush's A is <1.0" doesn't work

closes #14563

@msftbot merge this in 6 minutes

source: gharchive/pull-request

authors: DHowett zadjii-msft


text:
conpty: automatically fall back to conhost if OpenConsole is missing

This pull request is in support of WTU.
I initially added support for a new flag, PSEUDOCONSOLE_UNDOCKED_PREFER_INBOX_CONHOST, which I liked because it was more explicit. You can see that approach in commit cae3289cf.
Consider this an open discussion. Should we automatically fall back? Or should we allow a developer to opt for fallback?
Automatic fallback
Pros

It's easier on the consumer
We can eventually expand it to support $ARCH/openconsole.exe

Cons

Packaging the project wrong will result in a working-but-somewhat-broken experience (old conhost)
Implicit behavior may be bad

Manual selection
Pros

Consumer gets explicit control

Cons

Consumer must explicitly opt in. In the case of WTU, that means pushing a configuration down into TerminalConnection all the way from TerminalApp to say "use the inbox one, dummy"

Oh. Well. When you originally told me about that flag in Teams, I thought you meant it was an #ifdef flag, not a bit flag to be passed the whole way down the stack.
I'd much rather not pipe that the entire way through the stack if we can help it...
However, I'm getting more scared of the implicit thing using the "somewhat broken" conhost and it being hard to tell which one it is connected to when a customer reports an error. Also, I'm not looking forward to a potential cycle when default app is put in, but that's likely to happen either way, I think.

I think the cycle with defaultapp will be broken by the fact that the second OpenConsole will not spawn a new conpty using this API, but instead stand up pipes and put them into a terminal.
This change is only to support the case where we do not package OpenConsole with WTU right now.
One way to ameliorate the concern about picking up a 'broken' conhost is to add a step to the msixbundle check script that validates the presence of OpenConsole.exe. That will stop our WT builds from failing weirdly, but it may not help the eventual conpty nuget/framework package.

I think the cycle with defaultapp will be broken by the fact that the second OpenConsole will not spawn a new conpty using this API, but instead stand up pipes and put them into a terminal.
This change is only to support the case where we do not package OpenConsole with WTU right now.
One way to ameliorate the concern about picking up a 'broken' conhost is to add a step to the msixbundle check script that validates the presence of OpenConsole.exe. That will stop our WT builds from failing weirdly, but it may not help the eventual conpty nuget/framework package.

I like the idea of a check in the bundle. And when we get to a nuget/framework package, we're gonna have this problem no matter what and need to have some sort of logging or exposure through the UI of what versions it is to diagnose issues. So I'm OK with that can being kicked down the road.

Added validation in 90fb29082

authors: DHowett miniksa


text:
Data driven tests are incompatible with Azure Test Plans after moving to MSTest.TestAdapter 2.2.4+

Description
MSTest.TestAdapter 2.2.4 (and above) break the Visual Studio Test task integration when it comes to data driven tests
Steps to reproduce

Open or create a Azure DevOps project
Create a test case work item

Create a new MSTest based test project, make sure you are referencing MSTest.TestAdapter version 2.2.3
Create a data driven test

Associate the the data driven test with a test case

Create a test plan and add the test case

Create a pipeline to build and run the test
Add  the Visual Studio Testing Task to the pipeline.  Use the testPlan testSelector link up the test plan, test suite, end test configuration from step 6.
Run the pipeline and note that the tests results appear in your build and test plan

Go back into your test code and upgrade MSTest.TestAdapter to 2.2.8, check in the change and try rerunning the tests
Note* The tests look like they run correctly, but on the first iteration of the data driven test is executed

Got back into your test code and add "[assembly: TestDataSourceDiscovery(TestDataSourceDiscoveryOption.DuringExecution)]" just below the using statements in your test class file.

Note* The build now shows the data driven test as other and Azure Test plans show the tests as In Progress.

Expected behavior
Data driven tests would work with Azure Test Plans
Actual behavior
If you don't use [assembly: TestDataSourceDiscovery(TestDataSourceDiscoveryOption.DuringExecution)] the data driven tests are not run.
If you use [assembly: TestDataSourceDiscovery(TestDataSourceDiscoveryOption.DuringExecution)] only the first iteration of the data driven tests is run.
Environment
Azure DevOps
MSTest.TestAdapter 2.2.4 and above
Sample project and code: https://dev.azure.com/MagenicOpen/

@nohwnd  - Any idea if this is something that will get fixed?

@Haplois - do you know if this is issue is on the teams radar?

@AbhitejJohn
@jayaranigarg

Any idea if this is something that will get fixed?

Hi @TroyWalshProf. I will move forward by closing this issue as it overlaps with #1026 and there are more discussions on the other ticket. Please comment on the other ticket.

authors: Evangelink TroyWalshProf

repo: microsoft/testfx


text:
Update inheritdoc.md

I had to go digging to figure this out, so wanted to save others the trouble

Should probably also update https://tsdoc.org/pages/spec/tag_kinds/ here, the code sample with inheritDoc there is invalid according to the playground.

@Gerrit0 Thanks for fixing this!  I addressed the tag_kinds.md issue that you pointed out.


text:
adopt versioning cadl ranch specs

Adopt the versioning tests from cadl ranch in our emitter.
https://github.com/Azure/cadl-ranch/tree/main/packages/cadl-ranch-specs/http/versioning

This needs design work to implement the various Typespec versioning decorators.

authors: JoshLove-msft m-nash

repo: microsoft/typespec


text:
Is there an easy to output top k sentences for each source sent when decoding?

Hi there,
Thanks for the repo and help! I was wondering if there is a way to output more than one (e.g. k) output sentence of each input sentence when decoding?
Thanks much in advance!

The argument --need_score_traces can be added for python decode_seq2seq.py, which dumps a *.trace.pickle file for the intermediate results of beam search. Then s2s-ft/gen_seq_from_trace.py can re-load the dumped beam search results. In https://github.com/microsoft/unilm/blob/master/s2s-ft/gen_seq_from_trace.py#L63 , we used  if s > max_score: to save the best beam search result. Instead, we can maintain a sorted list to save the top-K results (L67: frame_id and pos_in_frame). Then L69-L76 can recover them to tokens.

Thank you very much for the tip! Will have a try!

Hi @donglixp,
I used these hyper-parameters but got an empty file as output (i.e. I have generated the score trace file):
python s2s-ft/gen_seq_from_trace.py \
--bert_model bert-base-cased --length_penalty 0 \
--tokenizer_name unilm1.2-base-uncased \
--is_roberta \
--do_lower_case \
--input ${OUTPUT_FILE}

After a little bit debugging, I found that this for-loop was all skipped by this if judgement. However, I'm not quite sure how it is the case.
 if fid <= last_frame_id and scores[fid][i] >= 0:
    # skip paddings
    print("skip paddings")
    continue

Thanks for reporting the issue. @addf400 is investigating it.

Hi @donglixp,
I used these hyper-parameters but got an empty file as output (I have generated the score trace file):
python s2s-ft/gen_seq_from_trace.py \
--bert_model bert-base-cased --length_penalty 0 \
--tokenizer_name unilm1.2-base-uncased \
--is_roberta \
--do_lower_case \
--input ${OUTPUT_FILE}

After a little bit debugging, I found that this for-loop was all skipped by this if judgment. However, I'm not quite sure how it is the case.
 if fid <= last_frame_id and scores[fid][i] >= 0:
    # skip paddings
    print("skip paddings")
    continue

I have created a PR for this (https://github.com/microsoft/unilm/pull/94)
You need to change the running command as:
python gen_seq_from_trace.py \
--model_type unilm --length_penalty 0 \
--tokenizer_name unilm1.2-base-uncased \
--input ${OUTPUT_FILE}

Thanks! @addf400 and @donglixp  It works now!  I also tried to save top k sentences by the following modifications.
def get_best_sequence(.....):
    max_score = -math.inf
    frame_id = -1
    pos_in_frame = -1
    searched_results = []
    frame_set = set()

    for fid in range(last_frame_id + 1):
        for i, wid in enumerate(wids_list[fid]):
             .....
                if s > max_score:
                    # if (frame_id != -1) and min_len and (fid+1 < min_len):
                    #     continue
                    max_score = s
                    frame_id = fid
                    pos_in_frame = i
                # To ignore duplicate generations.
                if (frame_id, pos_in_frame) not in frame_set:
                    frame_set.add((frame_id, pos_in_frame))
                    searched_results.append((s, frame_id, pos_in_frame))

    searched_results.sort(key=lambda x:x[0], reverse=True)
    searched_results = searched_results[:top_k]

    seqs = []

    for s, frame_id, pos_in_frame in searched_results:
        if frame_id == -1:
            seq = []
        else:
            seq = [wids_list[frame_id][pos_in_frame]]
            for fid in range(frame_id, 0, -1):
                pos_in_frame = ptrs[fid][pos_in_frame]
                seq.append(wids_list[fid - 1][pos_in_frame])
            seq.reverse()
        seqs.append(seq)
    return seqs

And
    for s in samples:
        word_ids_list = get_best_sequence(s, eos_id, pad_id, alpha=args.alpha,
                                     length_penalty=args.length_penalty, expect=args.expect,
                                     min_len=args.min_len, top_k=args.top_k)

        for word_ids in word_ids_list:
            ......
            results.append(output_text)
        results.append("----")

In the end, I found that most of the examples have only a single unique generation from the trace.pickle.
Only a few of them can have more than one different generations.  Is that expected, or maybe I am making some mistakes.

authors: addf400 donglixp yuchenlin

repo: microsoft/unilm


text:
switch to host triplet as the default.

https://twitter.com/augustin_popa/status/1549127848140480512 ....
(ready to be merged in september 2023 ;) )

As I said back in https://github.com/microsoft/vcpkg-tool/pull/614 (and elsewhere), this is a change we can't make lightly because it breaks existing scripts (and our 'no changes means no changes' mantra).
We have discussed doing this before back when VS2022 changed the default for new projects, and said that in order to do it we need:

A period of time (~6 months) before we make the change where we warn that we are going to make the change and how to fix it. (Add --triplet or qualify all references with :triplet)
A period of time (~6 months) after we make the change where we warn that the behavior changed.

Don't you have telemetry how many people actually still build x86 outside manifest mode?
Most people probably already have VCPKG_DEFAULT_TRIPLET set because of the default vcpkg has and will never observe the change any way ;)
Furthermore it is more surprising that the default host triplet is x64-windows while the target is x86-windows.
Just make a big blog post with the release that the default triplet switched and add an extra message to bootstrap that the triplet has switched.... I really don't see a reason to give any grace period at all. New users have the problem to adapt. Old users probably don't care that much and know what they need to do.

I think you can close this now because of https://github.com/microsoft/vcpkg-tool/pull/881

I think you can close this now because of https://github.com/microsoft/vcpkg-tool/pull/881

Just prints the warning does not do the change. But according to the warning something more sophisticated will be implemented? I'll keep this open until that more sophisticated stuff is actually implemented ;)

Just prints the warning does not do the change. But according to the warning something more sophisticated will be implemented? I'll keep this open until that more sophisticated stuff is actually implemented ;)

It isn't any more sophisticated; it's just that the clock is now running on giving people reasonable warning that the change is happening.

It isn't any more sophisticated;

Ok the message gives the impression that at least the correct host default would be used, e.g. on arm64 it should be arm64-windows and not x64-windows. Maybe this can be changed to simply call the function for the default host-triplet instead?
E.g. removing the #ifdef and call default_host_triplet(args) instead of system_triplet()

Ah, maybe. I kinda forget arm64-windows exists 😅

Don't know what to do about:
  D:\a\vcpkg-tool\vcpkg-tool\out\build\windows-ci\vcpkg.ps1 --x-buildtrees-root=D:\a\vcpkg-tool\vcpkg-tool\out\build\windows-ci\work\testing\buildtrees --x-install-root=D:\a\vcpkg-tool\vcpkg-tool\out\build\windows-ci\work\testing\installed --x-packages-root=D:\a\vcpkg-tool\vcpkg-tool\out\build\windows-ci\work\testing\packages --overlay-ports=D:\a\vcpkg-tool\vcpkg-tool\azure-pipelines/e2e-ports/overlays --overlay-triplets=D:\a\vcpkg-tool\vcpkg-tool\azure-pipelines/e2e-ports/triplets depend-info vcpkg-hello-world-1
  vcpkg-cmake:
  vcpkg-cmake-config:
  vcpkg-hello-world-1: vcpkg-cmake, vcpkg-cmake-config

  Exception: D:\a\vcpkg-tool\vcpkg-tool\azure-pipelines\end-to-end-tests-dir\cli.ps1:24
  Line |
    24 |          throw 'depend-info with unqualified spec should emit the trip …
       |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       | depend-info with unqualified spec should emit the triplet warning

@BillyONeal: I tested with an official release and it also doesn't print the triplet with depend_info.
See:
neumann@heineken MINGW64 /e/vcpkg_folders/master_clean (update_zlib)
$ ./bootstrap-vcpkg.sh
Downloading https://github.com/microsoft/vcpkg-tool/releases/download/2023-08-09/vcpkg.exe -> E:\vcpkg_folders\master_clean\vcpkg.exe... done.
Validating signature... done.

vcpkg package management program version 2023-08-09-9990a4c9026811a312cb2af78bf77f3d9d288416

See LICENSE.txt for license information.

neumann@heineken MINGW64 /e/vcpkg_folders/master_clean (update_zlib)
$ ./vcpkg.exe depend-info zlib
vcpkg-cmake:
zlib: vcpkg-cmake

Ok figured out why. I had VCPKG_DEFAULT(_HOST)?_TRIPLET set in the environment.
But this:
E:\vcpkg_folders\master_clean>vcpkg.exe depend-info zlib
warning: Starting with the September 2023 release, the default triplet for vcpkg libraries will change from x86-windows to the detected host triplet (x64-windows). To resolve this message, add --triplet x86-windows to keep the same behavior.
vcpkg-cmake:
zlib: vcpkg-cmake

is probably not what the test wanted to have or is it?

Ah okay i misread I thought the idea was to emit the triplet for host deps or something in depend-info but actually the tests tells me that it is about warning itself.

authors: BillyONeal Neumann-A autoantwort

repo: microsoft/vcpkg-tool


text:
[New Port Request] OpenNN

I can't find OpenNN library, so if you can add it please do it

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.

repo: microsoft/vcpkg


text:
[New Port Request] libldap

Library name: OpenLDAP libldap and its dependency liblber
Library description: Lightweight Directory Access Protocol API
Source repository URL:
https://git.openldap.org/openldap/openldap/-/tree/master/libraries/libldap
https://git.openldap.org/openldap/openldap/-/tree/master/libraries/liblber
Project homepage (if different from the source repository):
https://www.openldap.org
Anything else that is useful to know when adding (such as optional features the library may have that should be included):
https://man7.org/linux/man-pages/man3/ldap.3.html
OpenLDAP libldap supports replication as specified in RFC 4533 (syncrepl).

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.

authors: PhoebeHui dimdin


text:
[capnproto] update to 1.0.1

Library name
capnproto
New version number
1.0.1
Other information that may be useful (release notes, etc...)
The current version of Cap’n Proto isn't compatible with Visual Studio 2022 >17.6 when building as C++20
Issue has been fixed here: https://github.com/capnproto/capnproto/issues/1752 and is available in Cap’n Proto 1.0.1.
I've made the following change locally. The issue was resolved.

I added a draft PR to update the port to v1.0.1, but then I got the following error:
...include\kj\async-inl.h(2296): error C2143: syntax error: missing ';' before 'function-style cast'
...include\kj\async-inl.h(2320): note: see reference to class template instantiation 'kj::_::Coroutine<T>::Awaiter<U>' being compiled
...include\kj\async-inl.h(2296): error C2059: syntax error: ''
...include\kj\async-inl.h(2296): error C2334: unexpected token(s) preceding '{'; skipping apparent function body

The above problem has been fixed in https://github.com/capnproto/capnproto/commit/25caef2418d7b7b89fee220b98c1605faf668873, but it's not in v1.0.1. I added a patch to disable that KJ_HAS_COROUTINE section entirely.

Awesome, thank you for sorting this so quick.

authors: advisoft hornang


text:
[libsodium] build failure, wrong hash since url points to dynamic tag

Operating system
windows - github ci
Compiler
MSVC
Steps to reproduce the behavior
vcpkg install libsodium:x64-windows-static

Failure logs
Installing 7/9 libsodium:x64-windows-static@1.0.19#2...
Building libsodium:x64-windows-static@1.0.19#2...
-- Downloading https://github.com/jedisct1/libsodium/archive/1.0.19.tar.gz -> jedisct1-libsodium-1.0.19.tar.gz...
[DEBUG] To include the environment variables in debug output, pass --debug-env
[DEBUG] Trying to load bundleconfig from C:\vcpkg\vcpkg-bundle.json
[DEBUG] Failed to open: C:\vcpkg\vcpkg-bundle.json
[DEBUG] Bundle config: readonly=false, usegitregistry=false, embeddedsha=nullopt, deployment=Git, vsversion=nullopt
[DEBUG] Metrics enabled.
[DEBUG] Feature flag 'binarycaching' unset
[DEBUG] Feature flag 'compilertracking' unset
[DEBUG] Feature flag 'registries' unset
[DEBUG] Feature flag 'versions' unset
[DEBUG] Feature flag 'dependencygraph' unset
Downloading https://github.com/jedisct1/libsodium/archive/1.0.19.tar.gz
[DEBUG] Trying to hash C:\vcpkg\downloads\jedisct1-libsodium-1.0.19.tar.gz.2992.part
[DEBUG] C:\vcpkg\downloads\jedisct1-libsodium-1.0.19.tar.gz.2992.part has hash efeb4c0dc352993fc128974abb27e4be60521e85ce191c8c38a84168d4e7d7b1d2c26843250077dd21dadb13678bf56712375e74754eb02100b8cc418ebffb94
error: Failed to download from mirror set
error: File does not have the expected hash:
url: https://github.com/jedisct1/libsodium/archive/1.0.19.tar.gz
File: C:\vcpkg\downloads\jedisct1-libsodium-1.0.19.tar.gz.2992.part
Expected hash: 6094d7bf191ea3be85f2ddab76b71f1b9c69c786493db5b84d3c5d5a0237003377ddf6a8687a962ea651fe4a9369cf5ee1676ba0bae82690f5f7ef31a698efa9
Actual hash: efeb4c0dc352993fc128974abb27e4be60521e85ce191c8c38a84168d4e7d7b1d2c26843250077dd21dadb13678bf56712375e74754eb02100b8cc418ebffb94
[DEBUG] D:\a\_work\1\s\src\vcpkg\base\downloads.cpp(997):
[DEBUG] Time in subprocesses: 0us
[DEBUG] Time in parsing JSON: 8us
[DEBUG] Time in JSON reader: 0us
[DEBUG] Time in filesystem: 741us
[DEBUG] Time in loading ports: 0us
[DEBUG] Exiting after 749 ms (742872us)

CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:32 (message):

      Failed to download file with error: 1
      If you are using a proxy, please check your proxy setting. Possible causes are:

      1. You are actually using an HTTP proxy, but setting HTTPS_PROXY variable
         to `https://address:port`. This is not correct, because `https://` prefix
         claims the proxy is an HTTPS proxy, while your proxy (v2ray, shadowsocksr
         , etc..) is an HTTP proxy. Try setting `http://address:port` to both
         HTTP_PROXY and HTTPS_PROXY instead.

      2. If you are using Windows, vcpkg will automatically use your Windows IE Proxy Settings
         set by your proxy software. See https://github.com/microsoft/vcpkg-tool/pull/77
         The value set by your proxy might be wrong, or have same `https://` prefix issue.

      3. Your proxy's remote server is out of service.

      If you've tried directly download the link, and believe this is not a temporary
      download server failure, please submit an issue at https://github.com/Microsoft/vcpkg/issues
      to report this upstream download server failure.

Call Stack (most recent call first):
  scripts/cmake/vcpkg_download_distfile.cmake:270 (z_vcpkg_download_distfile_show_proxy_and_fail)
  scripts/cmake/vcpkg_from_github.cmake:106 (vcpkg_download_distfile)
  ports/libsodium/portfile.cmake:1 (vcpkg_from_github)
  scripts/ports.cmake:175 (include)

error: building libsodium:x64-windows-static failed with: BUILD_FAILED
Elapsed time to handle libsodium:x64-windows-static: 807 ms

Additional context
The cited url https://github.com/jedisct1/libsodium/archive/1.0.19.tar.gz does not point to the actual release, but to a tag that is used like a branch.
Use 1.0.19-RELEASE tag OR better, the signed release tarballs instead https://github.com/jedisct1/libsodium/releases/download/1.0.19-RELEASE/libsodium-1.0.19.tar.gz
Also, 1.0.20 released yesterday, probably triggering this issue.

The cited url https://github.com/jedisct1/libsodium/archive/1.0.19.tar.gz does not point to the actual release, but to a tag that is used like a branch.

Can you please explain this, or point to a document which explains this?
(Why does one need to use tags like a branch?)

Can you please explain this, or point to a document which explains this? (Why does one need to use tags like a branch?)

I just took a look at their repo and compared https://github.com/jedisct1/libsodium/commits/1.0.19/ with https://github.com/jedisct1/libsodium/commits/1.0.19-RELEASE/ .
Both are tags, but only one points to the actual commit form back when it was released.
The non-RELEASE tag points to a commit done just a few days ago.
I still think the release tarball should be used instead https://github.com/jedisct1/libsodium/releases/download/1.0.19-RELEASE/libsodium-1.0.19.tar.gz .
And, while you are at it, update to the fresh 1.0.20 :)

It would be good to know if they changed the tag by accident, and to have some official reference to add to a comment.
And vcpkg generally prefers the on-the-fly tarballs from git(hub).

The related upstream issue: https://github.com/jedisct1/libsodium/issues/1373

authors: Green-Sky LilyWangLL dg0yt


text:
[DO NOT MERGE][azure-template-cpp] publish version 1.0.0-beta.26

VALIDATION ONLY -- Update port for azure-template-cpp

This PR validates release automation... 2 checks have failed, all other checks have passed. Failure info:

OSX appears to be using a cached version of the .tar.gz (this is happening in part because I've been publishing the packages under the same release/tag)
The x86 windows build appears to be failing for unrelated reasons. I cannot re-queue a build.


text:
[DO NOT MERGE] Initial test of nightly Azure SDK Validation

This PR should not be merged. It is a draft PR whose branch will be updated periodically to validate the Azure SDK for C++ against the vcpkg CI.

This is superseded by the PR generated by coming pipeline automation.


text:
[proj, proj4] Update to PROJ 9.0.0 & make proj the regular port

What does your PR fix?
Updates to PROJ 9.0.0 (WIP, only RC at the moment).
Makes proj the regular port instead of proj4.
Moves cmake config to lower-case folders, and data into a subfolder.

Which triplets are supported/not supported? Have you updated the CI baseline?
all, no

Does your PR follow the maintainer guide?
yes

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?
yes

Also please resolve this PR's conflicts.
Thanks.

I will resolve the conflicts with the official release which we can expect today.
Independent of that, you may validate the switch of regular and stub port which comes with this PR.

There are some most likely unrelated 7zip errors on x64_uwp and arm64 builds now?

Entirely unrelated: #23284

Can you please resolve the file conflicts?
Thanks.

Can this be merged soon? New releases for libgeotiff and gdal are coming, and I'm tired of merge conflicts from versioning meta data.

Ping @vicroms @BillyONeal for merge this quickly.


text:
[vcpkg script] build_nmake use z_vcpkg_get_cmake_vars

closes #25840

pdcurses:
LINK : fatal error LNK1104: cannot open file 'link.exe'

detours:
detours.cpp(1035): error C3861: 'VirtualProtect': identifier not found
detours.cpp(1049): error C3861: 'VirtualProtect': identifier not found
detours.cpp(1105): error C3861: 'VirtualAlloc': identifier not found
detours.cpp(1152): error C3861: 'VirtualAlloc': identifier not found
detours.cpp(1422): error C3861: 'VirtualProtect': identifier not found
detours.cpp(1679): error C3861: 'SetThreadContext': identifier not found
detours.cpp(1695): error C3861: 'SetThreadContext': identifier not found
detours.cpp(1708): error C3861: 'VirtualProtect': identifier not found
detours.cpp(2116): error C3861: 'VirtualProtect': identifier not found
detours.cpp(2274): error C3861: 'VirtualProtect': identifier not found
detours.cpp(2359): error C3861: 'VirtualQueryEx': identifier not found

librttopo:
cl : Command line error D8048 : cannot compile C file 'src\box2d.c' with the /ZW option

@JackBoosY: For detours and librttopo this probably means they don't support UWP? pdcurses uses LINK as an (env) variable which now gets sets and screws up the build (could use _LINK_ however).

librttopo:
cl : Command line error D8048 : cannot compile C file 'src\box2d.c' with the /ZW option

Reading the documentation of /ZW, I wonder why the /ZW should be used at all, for a C file that doesn't want "to support Microsoft C++ component extensions C++/CX"?

Reading the documentation of /ZW, I wonder why the /ZW should be used at all, for a C file that doesn't want "to support Microsoft C++ component extensions C++/CX"?

VS passes /ZW in the normal UWP App template. CMake also adds /ZW:nostdlib for store apps.

Any news?

this was green in https://github.com/microsoft/vcpkg/pull/25862/commits/b28cb4c753a99c54876116f5e0ca39ecb6b5e977 so just fix the merge conflicts. I am reluctant to do it. The PR has been green for 1 month and the other detours PR was a lot younger. (like opened only two days ago)

Thanks!

librttopo:
cl : Command line error D8048 : cannot compile C file 'src\box2d.c' with the /ZW option

Reading the documentation of /ZW, I wonder why the /ZW should be used at all, for a C file that doesn't want "to support Microsoft C++ component extensions C++/CX"?

VS passes /ZW in the normal UWP App template. CMake also adds /ZW:nostdlib for store apps.

I think I hit the right spot: /ZW:nostdlib comes from pushing CXX flags into _CL_ , so it breaks any C project for uwp:
librttopo (this PR)
readosm (#26455)
openssl (#27150)
Cf. cmake-get-vars-x64-uwp-dbg.cmake.log:
set(VCPKG_COMBINED_CXX_FLAGS_DEBUG "-DWIN32 -D_WINDOWS -D_UNICODE -DUNICODE -DWINAPI_FAMILY=WINAPI_FAMILY_APP -D__WRL_NO_DEFAULT_LIB__ -nologo -Z7 -MP -GS -Gd -Gm- -W3 -WX- -Zc:wchar_t -Zc:inline -Zc:forScope -fp:precise -Oy- -EHsc  -utf-8  -D_DEBUG -Od -RTC1 -MDd   -ZW:nostdlib")
set(VCPKG_COMBINED_C_FLAGS_DEBUG   "-DWIN32 -D_WINDOWS -D_UNICODE -DUNICODE -DWINAPI_FAMILY=WINAPI_FAMILY_APP -D__WRL_NO_DEFAULT_LIB__ -nologo -Z7 -MP -GS -Gd -Gm- -W3 -WX- -Zc:wchar_t -Zc:inline -Zc:forScope -fp:precise -Oy- -EHsc  -utf-8  -D_DEBUG -Od -RTC1 -MDd  ")

So we need a LANGUAGE argument for vcpkg_configure_nmake and switch the flag accordingly?

The language argument is the primary solution. I only wonder if we want to do more work in the global script, or if it should go to a helper port.

I only wonder if we want to do more work in the global script, or if it should go to a helper port.

What additional steps are you thinking of?

Option to use jom (and maybe filter out /MP then).
Option to not set _CPP_ at all (and use OPTIONS_DEBUG/RELEASE instead).
Pass multiple targets.
Pass the name of the project's install dir variable.

I completely misunderstood. I thought you meant new helper ports with different functionality. But you only meant to move the stuff here to a helper port called vcpkg-nmake.

authors: JackBoosY JavierMatosD Neumann-A dg0yt


text:
[libhv] update to 1.2.6

Describe the pull request

What does your PR fix?
Fixes #25930, update libhv to 1.2.6.
Feature test pass on x64-windows.

Thanks for the update :)

authors: BillyONeal LilyWangLL


text:
[vulkan-memory-allocator]Updating vulkan memory allocator port

[ X] Changes comply with the maintainer guide
[ X] SHA512s are updated for each updated download
[ X] The "supports" clause reflects platforms that may be fixed by this new version
[ X] Any fixed CI baseline entries are removed from that file.
[ X] Any patches that are no longer applied are deleted from the port's directory.
[ X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[ X] Only one version is added to each modified port's versions file.

This version includes a fix for a build issue I've personally encountered: https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/issues/269

Thanks for the update!

authors: BillyONeal Honeybunch


text:
[curl] Update version to 8.1.2

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

@dg0yt, Thanks for your PR, when I tested the feature by command ./vcpkg install curl[*] --allow-unsupported, I got this error:
[1/2] "C:/Program Files/CMake/bin/cmake.exe" -E chdir "../../x86-windows-dbg" "C:/Program Files/CMake/bin/cmake.exe" "F:/Feature-test/curl/vcpkg/buildtrees/curl/src/curl-8_1_2-48a3152245.clean" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=F:/Feature-test/curl/vcpkg/packages/curl_x86-windows/debug" "-DFETCHCONTENT_FULLY_DISCONNECTED=ON" "-DCMAKE_PROJECT_INCLUDE=F:/Feature-test/curl/vcpkg/ports/curl/cmake-project-include.cmake" "-DUSE_NGHTTP2=ON" "-DCURL_USE_WOLFSSL=ON" "-DCURL_USE_OPENSSL=ON" "-DCURL_USE_MBEDTLS=ON" "-DCURL_USE_LIBSSH2=ON" "-DBUILD_CURL_EXE=ON" "-DENABLE_ARES=ON" "-DCURL_WINDOWS_SSPI=ON" "-DCURL_BROTLI=ON" "-DCURL_USE_SCHANNEL=ON" "-DCURL_USE_SECTRANSP=ON" "-DUSE_LIBIDN2=ON" "-DUSE_WIN32_IDN=ON" "-DUSE_WIN32_LDAP=ON" "-DENABLE_WEBSOCKETS=ON" "-DHTTP_ONLY=OFF" "-DCURL_DISABLE_LDAP=OFF" "-DPKG_CONFIG_EXECUTABLE=F:/Feature-test/curl/vcpkg/downloads/tools/msys2/5b9374e6ec2c4e17/mingw32/bin/pkg-config.exe" "-DCURL_CA_PATH=none" "-DCURL_CA_BUNDLE=none" "-DENABLE_UNICODE=ON" "-DBUILD_TESTING=OFF" "-DENABLE_MANUAL=OFF" "-DCURL_CA_FALLBACK=ON" "-DCURL_USE_LIBPSL=OFF" "-DCMAKE_DISABLE_FIND_PACKAGE_Perl=ON" "-DCMAKE_MAKE_PROGRAM=C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=F:/Feature-test/curl/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x86-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v143" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=F:/Feature-test/curl/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x86" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=F:/Feature-test/curl/vcpkg" "-D_VCPKG_INSTALLED_DIR=F:/Feature-test/curl/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DENABLE_DEBUG=ON"
FAILED: ../../x86-windows-dbg/CMakeCache.txt
"C:/Program Files/CMake/bin/cmake.exe" -E chdir "../../x86-windows-dbg" "C:/Program Files/CMake/bin/cmake.exe" "F:/Feature-test/curl/vcpkg/buildtrees/curl/src/curl-8_1_2-48a3152245.clean" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=F:/Feature-test/curl/vcpkg/packages/curl_x86-windows/debug" "-DFETCHCONTENT_FULLY_DISCONNECTED=ON" "-DCMAKE_PROJECT_INCLUDE=F:/Feature-test/curl/vcpkg/ports/curl/cmake-project-include.cmake" "-DUSE_NGHTTP2=ON" "-DCURL_USE_WOLFSSL=ON" "-DCURL_USE_OPENSSL=ON" "-DCURL_USE_MBEDTLS=ON" "-DCURL_USE_LIBSSH2=ON" "-DBUILD_CURL_EXE=ON" "-DENABLE_ARES=ON" "-DCURL_WINDOWS_SSPI=ON" "-DCURL_BROTLI=ON" "-DCURL_USE_SCHANNEL=ON" "-DCURL_USE_SECTRANSP=ON" "-DUSE_LIBIDN2=ON" "-DUSE_WIN32_IDN=ON" "-DUSE_WIN32_LDAP=ON" "-DENABLE_WEBSOCKETS=ON" "-DHTTP_ONLY=OFF" "-DCURL_DISABLE_LDAP=OFF" "-DPKG_CONFIG_EXECUTABLE=F:/Feature-test/curl/vcpkg/downloads/tools/msys2/5b9374e6ec2c4e17/mingw32/bin/pkg-config.exe" "-DCURL_CA_PATH=none" "-DCURL_CA_BUNDLE=none" "-DENABLE_UNICODE=ON" "-DBUILD_TESTING=OFF" "-DENABLE_MANUAL=OFF" "-DCURL_CA_FALLBACK=ON" "-DCURL_USE_LIBPSL=OFF" "-DCMAKE_DISABLE_FIND_PACKAGE_Perl=ON" "-DCMAKE_MAKE_PROGRAM=C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=F:/Feature-test/curl/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x86-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v143" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=F:/Feature-test/curl/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_LINKER_FLAGS_RELEASE=" "-DVCPKG_LINKER_FLAGS_DEBUG=" "-DVCPKG_TARGET_ARCHITECTURE=x86" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-D_VCPKG_ROOT_DIR=F:/Feature-test/curl/vcpkg" "-D_VCPKG_INSTALLED_DIR=F:/Feature-test/curl/vcpkg/installed" "-DVCPKG_MANIFEST_INSTALL=OFF" "-DENABLE_DEBUG=ON"
-- The C compiler identification is MSVC 19.36.32532.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x86/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Found PkgConfig: F:/Feature-test/curl/vcpkg/downloads/tools/msys2/5b9374e6ec2c4e17/mingw32/bin/pkg-config.exe (found version "0.29.2")
-- Checking for module 'libidn2'
--   Found libidn2, version 2.3.4
-- curl version=[8.1.2-DEV]
-- Looking for getch in ws2_32;c-ares::cares
-- Looking for getch in ws2_32;c-ares::cares - found
-- Looking for getch in winmm;ws2_32;c-ares::cares
-- Looking for getch in winmm;ws2_32;c-ares::cares - found
CMake Error at CMakeLists.txt:421 (message):
  CoreFoundation framework not found

-- Configuring incomplete, errors occurred!

could you please take a look?

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@JonLiu1993 Please review without --allow-unsupported. Unsupported means unsupported.

when I tested the feature by command ./vcpkg install curl[brotli,c-ares,http2,idn,idn2,mbedtls,non-http,openssl,schannel,ssh,sspi,tool,websockets,winidn,winldap,winssl,wolfssl]:x86-windows, I got this error:
FAILED: lib/CMakeFiles/libcurl.dir/vtls/wolfssl.c.obj
C:\PROGRA~1\MIB055~1\2022\COMMUN~1\VC\Tools\MSVC\1436~1.325\bin\Hostx64\x86\cl.exe   -DBUILDING_LIBCURL -DCURLDEBUG -DCURL_HIDDEN_SYMBOLS -DDEBUGBUILD -DHAVE_CONFIG_H -DLIBSSH2_WIN32 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_SECURE_NO_DEPRECATE -D_UNICODE -D_WINDLL -Dlibcurl_EXPORTS -IF:\Feature-test\curl\vcpkg\buildtrees\curl\src\curl-8_1_2-48a3152245.clean\include -IF:\Feature-test\curl\vcpkg\buildtrees\curl\x86-windows-dbg\lib\..\include -IF:\Feature-test\curl\vcpkg\buildtrees\curl\src\curl-8_1_2-48a3152245.clean\lib\.. -IF:\Feature-test\curl\vcpkg\buildtrees\curl\src\curl-8_1_2-48a3152245.clean\lib\..\include -IF:\Feature-test\curl\vcpkg\buildtrees\curl\x86-windows-dbg\lib\.. -IF:\Feature-test\curl\vcpkg\buildtrees\curl\src\curl-8_1_2-48a3152245.clean\lib -IF:\Feature-test\curl\vcpkg\buildtrees\curl\x86-windows-dbg\lib -external:IF:\Feature-test\curl\vcpkg\installed\x86-windows\include -external:W0 /nologo /DWIN32 /D_WINDOWS /W4 /utf-8 /MP  /MP /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  -MDd /showIncludes /Folib\CMakeFiles\libcurl.dir\vtls\wolfssl.c.obj /Fdlib\CMakeFiles\libcurl.dir\ /FS -c F:\Feature-test\curl\vcpkg\buildtrees\curl\src\curl-8_1_2-48a3152245.clean\lib\vtls\wolfssl.c
F:\Feature-test\curl\vcpkg\installed\x86-windows\include\wolfssl/openssl/compat_types.h(54): error C2371: 'EVP_MD': redefinition; different basic types
F:\Feature-test\curl\vcpkg\installed\x86-windows\include\openssl/types.h(106): note: see declaration of 'EVP_MD'
F:\Feature-test\curl\vcpkg\installed\x86-windows\include\wolfssl/openssl/compat_types.h(55): error C2371: 'EVP_MD_CTX': redefinition; different basic types
F:\Feature-test\curl\vcpkg\installed\x86-windows\include\openssl/types.h(107): note: see declaration of 'EVP_MD_CTX'
F:\Feature-test\curl\vcpkg\installed\x86-windows\include\wolfssl/openssl/compat_types.h(56): error C2371: 'EVP_CIPHER': redefinition; different basic types
F:\Feature-test\curl\vcpkg\installed\x86-windows\include\openssl/types.h(104): note: see declaration of 'EVP_CIPHER'
F:\Feature-test\curl\vcpkg\installed\x86-windows\include\wolfssl/openssl/compat_types.h(57): error C2371: 'EVP_CIPHER_CTX': redefinition; different basic types
F:\Feature-test\curl\vcpkg\installed\x86-windows\include\openssl/types.h(105): note: see declaration of 'EVP_CIPHER_CTX'
F:\Feature-test\curl\vcpkg\installed\x86-windows\include\wolfssl/openssl/compat_types.h(58): error C2371: 'ASN1_PCTX': redefinition; different basic types
F:\Feature-test\curl\vcpkg\installed\x86-windows\include\openssl/types.h(82): note: see declaration of 'ASN1_PCTX'

Check if it is a regression. Port curl traditionally supports various ssl backends via features. But I'm not surprised if you can't combine openssl (version 3 in vcpkg) and wolfssl with its openssl compatibility layer (unknown version of openssl).

Feature brotli,c-ares,http2,idn,idn2,mbedtls,non-http,schannel,sspi,tool,websockets,winidn,winldap,winssl,wolfssl tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static


text:
[gmsh] update to 4.11.1

Fixes #33156
Update port gmsh to the latest version.

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[ ] The "supports" clause reflects platforms that may be fixed by this new version
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Tested feature graphics,occ,zipper successfully in the following triplet:

x64-windows
x64-windows-static

Sorry this might be a stupid question. When I get gmsh installed with vcpkg, no hints was given for how can I include and link the gmsh library in my CmakeList. And I tried to do this with regular commands like
find_package (GMSH CONFIG REQUIRED)
target_link_libraries(my_project GMSH::GMSH)

Cmake just complains the configuration for gmsh could not be found with the following errors
[cmake]   Could not find a package configuration file provided by "GMSH" with any of
[cmake]   the following names:
[cmake]
[cmake]     GMSHConfig.cmake
[cmake]     gmsh-config.cmake

Could you please tell me how can I do this correctly?

@Yanksi, gmsh did not generate the *.cmkae file, so find_package (GMSH CONFIG REQUIRED) cannot be used, and I did not find Findgmsh.cmake in F:\vcpkg\downloads\tools\cmake-3.27.1-windows\cmake-3.27.1-windows-i386\share\cmake-3.27\Modules  directory, so Module mode cannot be used. You can submit an issue and we will fix this problem.

You can use find_path and find_library.
You can submit an issue upstream, asking for exported CMake config.


text:
[daw-json-link] update to 3.20.1

Fixes https://github.com/microsoft/vcpkg/issues/33612

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[ ] The "supports" clause reflects platforms that may be fixed by this new version
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

Thanks for the update!


text:
[blake3] update to 1.5.0

[X] Changes comply with the maintainer guide
[X] SHA512s are updated for each updated download
[ ] ~The "supports" clause reflects platforms that may be fixed by this new version~
[ ] ~Any fixed CI baseline entries are removed from that file.~
[ ] ~Any patches that are no longer applied are deleted from the port's directory.~
[X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[X] Only one version is added to each modified port's versions file.

@jiayuehua, Thanks for your PR, this is ci test error.
Please take a look:
Change Dir: 'D:/buildtrees/blake3/arm64-uwp-dbg'

Run Build Command(s): "C:/Program Files/Microsoft Visual Studio/2022/Enterprise/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/ninja.exe" -v -v -j33 install
[1/6] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1437~1.328\bin\Hostx64\arm64\cl.exe   -DBLAKE3_DLL -DBLAKE3_DLL_EXPORTS -Dblake3_EXPORTS  /DWIN32 /D_WINDOWS /D_UNICODE /DUNICODE /DWINAPI_FAMILY=WINAPI_FAMILY_APP /D__WRL_NO_DEFAULT_LIB__ /nologo /Z7 /MP /GS /Gd /Gm- /W3 /WX- /Zc:wchar_t /Zc:inline /Zc:forScope /fp:precise /Oy- /EHsc  /utf-8  /D_DEBUG /MDd /Od /RTC1 /showIncludes /FoCMakeFiles\blake3.dir\blake3_portable.c.obj /FdCMakeFiles\blake3.dir\ /FS -c D:\buildtrees\blake3\src\1.5.0-0211606dec.clean\c\blake3_portable.c
[2/6] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1437~1.328\bin\Hostx64\arm64\cl.exe   -DBLAKE3_DLL -DBLAKE3_DLL_EXPORTS -Dblake3_EXPORTS  /DWIN32 /D_WINDOWS /D_UNICODE /DUNICODE /DWINAPI_FAMILY=WINAPI_FAMILY_APP /D__WRL_NO_DEFAULT_LIB__ /nologo /Z7 /MP /GS /Gd /Gm- /W3 /WX- /Zc:wchar_t /Zc:inline /Zc:forScope /fp:precise /Oy- /EHsc  /utf-8  /D_DEBUG /MDd /Od /RTC1 /showIncludes /FoCMakeFiles\blake3.dir\blake3.c.obj /FdCMakeFiles\blake3.dir\ /FS -c D:\buildtrees\blake3\src\1.5.0-0211606dec.clean\c\blake3.c
[3/6] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1437~1.328\bin\Hostx64\arm64\cl.exe   -DBLAKE3_DLL -DBLAKE3_DLL_EXPORTS -Dblake3_EXPORTS -DBLAKE3_USE_NEON=1  /DWIN32 /D_WINDOWS /D_UNICODE /DUNICODE /DWINAPI_FAMILY=WINAPI_FAMILY_APP /D__WRL_NO_DEFAULT_LIB__ /nologo /Z7 /MP /GS /Gd /Gm- /W3 /WX- /Zc:wchar_t /Zc:inline /Zc:forScope /fp:precise /Oy- /EHsc  /utf-8  /D_DEBUG /MDd /Od /RTC1 /showIncludes /FoCMakeFiles\blake3.dir\blake3_dispatch.c.obj /FdCMakeFiles\blake3.dir\ /FS -c D:\buildtrees\blake3\src\1.5.0-0211606dec.clean\c\blake3_dispatch.c
FAILED: CMakeFiles/blake3.dir/blake3_dispatch.c.obj
C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1437~1.328\bin\Hostx64\arm64\cl.exe   -DBLAKE3_DLL -DBLAKE3_DLL_EXPORTS -Dblake3_EXPORTS -DBLAKE3_USE_NEON=1  /DWIN32 /D_WINDOWS /D_UNICODE /DUNICODE /DWINAPI_FAMILY=WINAPI_FAMILY_APP /D__WRL_NO_DEFAULT_LIB__ /nologo /Z7 /MP /GS /Gd /Gm- /W3 /WX- /Zc:wchar_t /Zc:inline /Zc:forScope /fp:precise /Oy- /EHsc  /utf-8  /D_DEBUG /MDd /Od /RTC1 /showIncludes /FoCMakeFiles\blake3.dir\blake3_dispatch.c.obj /FdCMakeFiles\blake3.dir\ /FS -c D:\buildtrees\blake3\src\1.5.0-0211606dec.clean\c\blake3_dispatch.c
D:\buildtrees\blake3\src\1.5.0-0211606dec.clean\c\blake3_dispatch.c(106): error C2061: syntax error: identifier 'g_cpu_features'
D:\buildtrees\blake3\src\1.5.0-0211606dec.clean\c\blake3_dispatch.c(106): error C2059: syntax error: ';'
D:\buildtrees\blake3\src\1.5.0-0211606dec.clean\c\blake3_dispatch.c(106): error C2513: ' ': no variable declared before '='
D:\buildtrees\blake3\src\1.5.0-0211606dec.clean\c\blake3_dispatch.c(115): warning C4013: 'InterlockedOr' undefined; assuming extern returning int
D:\buildtrees\blake3\src\1.5.0-0211606dec.clean\c\blake3_dispatch.c(115): error C2065: 'g_cpu_features': undeclared identifier
[4/6] C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1437~1.328\bin\Hostx64\arm64\cl.exe   -DBLAKE3_DLL -DBLAKE3_DLL_EXPORTS -Dblake3_EXPORTS  /DWIN32 /D_WINDOWS /D_UNICODE /DUNICODE /DWINAPI_FAMILY=WINAPI_FAMILY_APP /D__WRL_NO_DEFAULT_LIB__ /nologo /Z7 /MP /GS /Gd /Gm- /W3 /WX- /Zc:wchar_t /Zc:inline /Zc:forScope /fp:precise /Oy- /EHsc  /utf-8  /D_DEBUG /MDd /Od /RTC1 /showIncludes /FoCMakeFiles\blake3.dir\blake3_neon.c.obj /FdCMakeFiles\blake3.dir\ /FS -c D:\buildtrees\blake3\src\1.5.0-0211606dec.clean\c\blake3_neon.c
ninja: build stopped: subcommand failed.


text:
Vmaware port

[x] Changes comply with the maintainer guide.
[x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
[x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
[x] The versioning scheme in vcpkg.json matches what upstream says.
[x] The license declaration in vcpkg.json matches what upstream says.
[x] The installed as the "copyright" file matches what upstream says.
[x] The source code of the component installed comes from an authoritative source.
[ ] The generated "usage text" is accurate. See adding-usage for context.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is in the new port's versions file.
[x] Only one version is added to each modified port's versions file.

There's a note about 'usage' file. This library is header only and doesn't contain any 'usage' which can be easily generated. What should I do to add proper usage?

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

Ping @T3RR7 for response.


text:
[Suggestion] It would be better if the notification message is "The log-streaming service for 'web app name' is already disconnected"

OS: Win 10
Build Version: 20201127.1
Repro Steps:

Right click on a web app and select "Start Streaming Logs" -> Execute "Start Streaming Logs" action again.
Check the notification message.
Right click on the web app and select "Stop Streaming Logs" -> Execute "Stop Streaming Logs" action again.
Check the notification message.

Actual:
The notification message is "The log-streaming service is already disconnected" after executing "Stop Streaming Logs" action again.

Suggestion:
It would be better if the notification message is "The log-streaming service for 'web app name' is already disconnected", same as below.

This issue has become stale and is at risk of being closed. The community has 60 days to upvote the issue. If it receives 5 upvotes we will keep it open and take another look. If not, we will close it. To learn more about how we handle issues, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this issue has received less than 5 community upvotes and we closed it. Still a big Thank You to you for taking the time to create it! To learn more about how we handle issues, please see our documentation.
Happy Coding!

authors: AzCode-Bot v-mengwe

repo: microsoft/vscode-azureappservice


text:
I have been facing this issue when try to make JSON template in Visual Studio Code. I have ARM extension installed. Any help will be highly appreciated. Thanks

Does this occur consistently?
Repro steps:

Open Visual Studio Code, click on select language mode and then choose JSON as language.
After choosing the JSON to make an ARM template for deploying Azure resources I have been facing this issue.

The screenshot is for reference.

Action: startArmLanguageServer
Error type: Error
Error Message: This extension requires .NET Core for full functionality, but we were unable to download and install a local copy for the extension. If this error persists, please see https://aka.ms/vscode-armtools-dotnet for troubleshooting tips.
Details: dotnet.acquire returned undefined
Version: 0.12.0
OS: win32
OS Release: 10.0.18363
Product: Visual Studio Code
Product Version: 1.49.0
Language: en

Call Stack
Object.wrapError extension.bundle.js:395:93998
Object.<anonymous> extension.bundle.js:486:771149
fulfilled extension.bundle.js:486:770045

@CloudsAnatomy Did you try the troubleshooting steps from the link in the help message?  Thanks.

@StephenWeatherford not yet, but thank you for suggesting. I'm going to use the provided links to further look into this issue. In case of failure, I'll post here on this same thread. Thanks.
Regards
CloudsAnatomy
cloudsanatomy@gmail.com

@CloudsAnatomy Any luck?  Thanks.

FYI I've improved the troubleshooting instructions at https://github.com/microsoft/vscode-azurearmtools/wiki/Troubleshooting-DotNet-Acquisition.

authors: CloudsAnatomy StephenWeatherford

repo: microsoft/vscode-azurearmtools


text:
Improve description for uniqueString

After reading the existing description, I had to look it up to understand how to use.

I'm thinking of adding more info like this (probably not as much for most) for others as well.

@mumian - should be able to help...

@bmoore-msft This comes straight from the docs, so the text doesn't really need reviewing, just more whether you like the longer format.

ping

Thanks!

authors: StephenWeatherford bmoore-msft


text:
There is no web page opening when clicking "Learn more" button

OS: Ubuntu 22.04
Build Version: 20220819.8
VS Code Version-insiders: 1.71.0-insider
Repro Steps:

Create and open a function project.
Debug this project.
Click the "Learn more" button in the prompt dialog.

Check whether there is a web page opening.

Expect:
There is a web page opening.
Actual:
There is no web page opening.
More Info:
Executing "Azure Functions: Install or Update Azure Functions Core Tools" command, click "these instructions" link, there is a web page opening.

I can repro this with the alpha Functions extension on VS Code Insiders 1.71, but not on VS Code 1.70 (Released) or VS Code 1.69 (Released). Perhaps an issue with the Insiders release?

I can repro this with the alpha Functions extension on VS Code Insiders 1.71, but not on VS Code 1.70 (Released) or VS Code 1.69 (Released). Perhaps an issue with the Insiders release?

@philliphoff were you also testing on Ubuntu 22.04?

Yes, 22.04.

Also, I see the same behavior with the latest released version of the extension, so it's not related to any changes in the alpha version.

@v-ruizh Could you please verify that this is still producing on current VS Code Stable & VS Code Insiders after updating? This definitely seems like something is wrong with their openUrl command for Ubuntu 22.04.

Verified this issue on current VS Code Stable 1.71.2 and VS Code Insiders 1.72.0 with the latest Function extension 20220922.1 installed, this issue has fixed, close it.

authors: alexweininger nturinski philliphoff v-ruizh

repo: microsoft/vscode-azurefunctions


text:
Authentication provider doesn't always load before extension activation

This should be fixed soon because getSession is going to be an activation event, but there are instances where the provider isn't ready by the time the extension activates.  Using this issue to track this error.

Removed getSession from extension activation, so this shouldn't be an issue for us anymore.

repo: microsoft/vscode-azurestaticwebapps


text:
ENOENT: no such file or directory - commandEmbeddings.json

VS Code Version: 1.79.0-insider
OS Version: win 11
Logs:

Steps to Reproduce:

Same here

Same thing here. I see people saying they made the file. However, if you clean install you will notice that the file is never actually missing. It's always there. I'm guessing it's an issue with parsing the path and in some instances finding the correct path, because when I see everyone else's error messages, it seems that they are unconventional paths or Windows. This is not the only extension that has issues parsing Windows paths I fixed an issue with copilot-cli by using double backslash syntax for windows paths.

Yea it seems that you can clean install but the chat history is not stored locally. so it appears like its not uninstalling fully

@jamespacileo Yea it seems that you can clean install but the chat history is not stored locally. so it appears like its not uninstalling fully

Same problem here. These two also seem related #59 and #51

Same here on macOS, though the message for me starts with "Unable to delete nonexistent file 'vscode-userdata:"

I managed to work around this error by doing the following, on macOS:

Run the following commands to create the missing files:

touch ~/Library/Application\ Support/Code\ -\ Insiders/User/globalStorage/github.copilot-chat/commandEmbeddings.json
touch ~/Library/Application\ Support/Code\ -\ Insiders/User/globalStorage/github.copilot-chat/settingEmbeddings.json

Reload VS Code Insiders
/vscode ... should now work

This fixed works. Thanks @adriencaccia

Thanks @adriencaccia , it works on Windows 10 too, just need to create two files commandEmbeddings.json and settingEmbeddings.json under C:\Users\user\AppData\Roaming\Code - Insiders\User\globalStorage\github.copilot-chat

I have the same problem. The issues #51 and #59 seem to be the same problem just with slightly different error messages because of differences between platforms. Can you please mark them as duplicates?
All seem to be caused by missing files commandEmbeddings.json or settingEmbeddings.json inside a directory Code - Insiders/User/globalStorage/github.copilot-chat inside an user's application data directory.
In my case (VS Code on Windows 10, GitHub remote repository) the message after asking "/vscode anything" is:

Unable to delete nonexistent file 'vscode-userdata:/c:/Users/vaclav.brozik/AppData/Roaming/Code - Insiders/User/globalStorage/github.copilot-chat/commandEmbeddings.json'

Is the first part of the "path" vscode-userdata:/ something that should work in VS Code or is this a bug? Also is c: in a Unix-style path (slashes, not backslashes) correct too?
Version: 1.79.0-insider (user setup)
Commit: f6be5461f8bc69013a605f5baea834651c6589fb
Date: 2023-05-20T01:18:53.811Z
Electron: 22.5.2
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Windows_NT x64 10.0.19044

Name: GitHub Copilot Nightly
Id: GitHub.copilot-nightly
Description: Your AI pair programmer
Version: 1.86.114
Publisher: GitHub
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=GitHub.copilot-nightly

Name: GitHub Copilot Chat
Id: GitHub.copilot-chat
Description: AI chat features powered by Copilot
Version: 0.1.2023052205
Publisher: GitHub
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=GitHub.copilot-chat

+1 Same issue

I managed to work around this error by doing the following, on macOS:

Run the following commands to create the missing files:

touch ~/Library/Application\ Support/Code\ -\ Insiders/User/globalStorage/github.copilot-chat/commandEmbeddings.json
touch ~/Library/Application\ Support/Code\ -\ Insiders/User/globalStorage/github.copilot-chat/settingEmbeddings.json

Reload VS Code Insiders
/vscode ... should now work

That is greate work.My Vscode will not have this error anymore.
But a new problem arises:

I'm stuck on Indexing, this should only happen once... and it never goes away even after half an hour.

Dupe of #59 and fixed.

authors: AlainDevs BaoziCDR JustScriptin adriencaccia ahosker ansh-les digitarald jpenalbae sergeyk vbrozik wojtodzio

repo: microsoft/vscode-copilot-release


text:
cant use fix bug feature in copilot chat

VS Code Version:  Latest
OS Version: window 11
Logs:  unrecognize language blade

Steps to Reproduce:

Open .blade page using vs code
right click and choose fix bug
it will show unrecognize language blade

all php and blade page cant use github copilot chat.

Hi yes thank you for posting this issue, this is a duplicate of the issue: https://github.com/microsoft/vscode-copilot-release/issues/469. This issue will be closed, you may comment on the other one.

authors: aiday-mar noramirulnordin


text:
prototype debug share

Very rough WIP that connects devtools to the active VSCode jsdebug target using CDP share

replaced by https://github.com/microsoft/vscode-edge-devtools/pull/391

repo: microsoft/vscode-edge-devtools


text:
No icons for back and forward

The Touch Bar has icons for back and forward but those icons are not in this repository. They are needed by any extension that wants to add back or forward buttons to the tool bar.

They are needed by any extension that wants to add back or forward buttons to the tool bar
I don't understand why an extension would need to provide icons for what already exists on the toolbar. Can you please elaborate?

And these are just using the same chevrons as chevron-left and chevron-right.

Ah, the chevrons are the ones! I will close this issue.
But a question: I cannot find a way to add back and forward buttons to the VS toolbar without an extension. Is there a way to do it?
I am using the Back and Forth extension for this purpose. I asked the developer to change the icons to the chevrons, as they are currently using the arrows.
Thanks for your time.

@phatmann we don't offer this natively so it would need to be added via an extension, besides using the command palette as well.

authors: misolori phatmann

repo: microsoft/vscode-icons


text:
Cannot select any directory when adding Referenced Libraries, and cannot add it again after deleting

Configuration:
Vscode: 1.42.1
JDK:1.8.0_241
OS: Linux
Build: 0.8.0
Repro steps:
1.Open Folder
2.Add a jar file or a folder to project classpath
3. Delete the added content
4. Repeat step 2
Result:
1.The user cannot select the desired folder and the directory cannot go forward or backward.

2.After deleting the added a jar file or a folder, it cannot be added again

@jdneo could you take a look?

Need some time to investigate this issue. While a workaround is to manually edit the workspace setting: java.project.referencedLibraries in settings.json

authors: Elvira-sxr jdneo testforstephen

repo: microsoft/vscode-java-dependency


text:
Can't list all remote kernels

I can't list all kernels at remote host. I clicked install python extension, and it kept installing...
Environment data

VS Code version: 1.81.0
Jupyter Extension version (available under the Extensions sidebar): v2023.6.1101941928
Python Extension version (available under the Extensions sidebar): v2023.14.0
OS (Windows | Mac | Linux distro) and version: Ubuntu 20.04.4 LTS
Python and/or Anaconda version: Python 3.10.6
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
Jupyter server running:  Remote

Sorry you are running into this.
Please can you try installing both the Jupyter and python extensions.
Next please can you share the logs from vscode console window (use the command 'Toggle Develiper Tools' to open the console window)

Hello @DonJayamanne , I reinstalled python and Jupyter extensions and it fixed 👍

authors: DonJayamanne jacktang

repo: microsoft/vscode-jupyter


text:
Custom hooks for remote kernels

[ ] Hide kernelspecs
[ ] Pre-selecting kernels even before server has been started
[ ] Custom startup logic
[ ] Custom Jupyter session start URL
[ ] Ability to set custom headers when starting a session
[ ] Custom WebSocket URL
[ ] Custom WebSocket Auth

Requested for Synapse @realDuang

Closing in favour of the new proposed API
Marking as verified, as the code was tested.


text:
Native Notebooks - "Getting Started" Kernel Behavior

When a user is working with a new empty notebook (any number of cells but all empty) and changes the kernel to a different language, have language picker for empty cell match that of the kernel.

@DonJayamanne Looks like there is a bug here when validating.
Two empty python cells, kernel set to python:

Change kernel to java kernel:

I'd expect two empty java cells. Instead I have two empty java cells and one empty python cell.

Does any extra work need to be done to enable the .NET team's experience to work here? Their .NET interactive kernel supports multiple languages, and comes with a default language. In their user's case they would need to have the cell language change to the default language of the kernel.

enable the .NET team's experience to work here

I don't think so, of things don't work i would expect then to file an issue

Upstream issue https://github.com/microsoft/vscode/issues/111534

Validated with Bash kernel:

authors: DonJayamanne IanMatthewHuff claudiaregio joyceerhl


text:
TensorBoard failed to launch due to local and virtual environment problems

Issue Type: Bug

Behaviour
Expected vs. Actual
Expected
When the interpreter is Python in conda environment, the extension can launch TensorBoard in conda environment.
Actual
Cannot launch TensorBoard: session: Error: Timed out after 60 seconds waiting for TensorBoard to launch.
Steps to reproduce:

Start VS Code from Windows Start Menu or Shell without conda activate. In the default environment of my system or Powershell, there is no TensorBoard package installed.

PS D:\workspace_tmp> pip list
Package           Version
----------------- ---------
astroid           2.2.5
certifi           2020.6.20
chardet           3.0.4
colorama          0.4.1
idna              2.10
isort             4.3.21
lazy-object-proxy 1.4.2
mccabe            0.6.1
pip               19.0.3
pylint            2.3.1
requests          2.24.0
setuptools        40.8.0
six               1.12.0
typed-ast         1.4.0
urllib3           1.25.10
walkdir           0.4.1
wrapt             1.11.2
You are using pip version 19.0.3, however version 22.0.4 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.
PS D:\workspace_tmp> code .

In VS Code, selected interpreter 'base':conda.
The Python extension automatically activates this conda environment in the VS Code built-in shell, where TensorBoard is installed.

PS D:\workspace_tmp> conda activate base
(base) PS D:\workspace_tmp> pip list | Select-String tensorboard

tensorboard                        2.8.0
tensorboard-data-server            0.6.0
tensorboard-plugin-wit             1.6.0

(base) PS D:\workspace_tmp> conda list | Select-String tensorboard

tensorboard               2.8.0              pyhd8ed1ab_1    conda-forge
tensorboard-data-server   0.6.0            py39haa95532_0    defaults
tensorboard-plugin-wit    1.6.0                      py_0    defaults

Run command Python: Launch TensorBoard, it prompts that the launch fails after 60 seconds.

Log: starting new TensorBoard session
[INFO 2022-3-13 19:49:10.831]: Starting new TensorBoard session...
[INFO 2022-3-13 19:49:10.831]: Ensuring TensorBoard package is installed into active interpreter
[INFO 2022-3-13 19:49:10.832]: [
  `getActivatedEnvironmentVariables, Class name = I, completed in 0ms, has a truthy return value, Arg 1: undefined, Arg 2: {"id":"D:\\\\FOLDERS\\\\USERS\\\\ZHANG\\\\ANACONDA3\\\\PYTHON.EXE","sysPrefix":"D:\\\\Folders\\\\Users\\\\zhang\\\\anaconda3","envType":"Conda","envName":"base","envPath":"D:\\\\Folders\\\\Users\\\\zhang\\\\anaconda3","path":"D:\\\\Folders\\\\Users\\\\zhang\\\\anaconda3\\\\python.exe","architecture":3,"sysVersion":"3.9.12 (main, Apr  4 2022, 05:22:27) [MSC v.1916 64 bit (AMD64)]","version":{"raw":"3.9.12","major":3,"minor":9,"patch":12,"build":[],"prerelease":["final","0"]},"companyDisplayName":"ContinuumAnalytics","displayName":"Python 3.9.12 ('base')","detailedDisplayName":"Python 3.9.12 ('base': conda)"}, Arg 3: true`
]
[INFO 2022-3-13 19:49:10.833]: [
  `getActivatedEnvironmentVariables, Class name = I, completed in 1ms, has a truthy return value, Arg 1: undefined, Arg 2: {"id":"D:\\\\FOLDERS\\\\USERS\\\\ZHANG\\\\ANACONDA3\\\\PYTHON.EXE","sysPrefix":"D:\\\\Folders\\\\Users\\\\zhang\\\\anaconda3","envType":"Conda","envName":"base","envPath":"D:\\\\Folders\\\\Users\\\\zhang\\\\anaconda3","path":"D:\\\\Folders\\\\Users\\\\zhang\\\\anaconda3\\\\python.exe","architecture":3,"sysVersion":"3.9.12 (main, Apr  4 2022, 05:22:27) [MSC v.1916 64 bit (AMD64)]","version":{"raw":"3.9.12","major":3,"minor":9,"patch":12,"build":[],"prerelease":["final","0"]},"companyDisplayName":"ContinuumAnalytics","displayName":"Python 3.9.12 ('base')","detailedDisplayName":"Python 3.9.12 ('base': conda)"}, Arg 3: true`
]
[DEBUG 2022-3-13 19:49:10.833]: Cached data exists KeyPrefix=Cache_Method_Output__.ensureEnvironmentContainsPython-Args="D:\\Folders\\Users\\zhang\\anaconda3\\python.exe"
[DEBUG 2022-3-13 19:49:10.834]: Cached data exists KeyPrefix=Cache_Method_Output__.getCondaVersion-Args=
[DEBUG 2022-3-13 19:49:10.834]: Cached data exists KeyPrefix=Cache_Method_Output__.getCondaVersion-Args=
> D:\Folders\Users\zhang\anaconda3\Scripts\conda.exe run -n base --no-capture-output --live-stream python ~\.vscode\extensions\ms-python.python-2022.4.1\pythonFiles\get_output_via_markers.py -c "import tensorboard; print(tensorboard.__version__)"
> D:\Folders\Users\zhang\anaconda3\Scripts\conda.exe run -n base --no-capture-output --live-stream python ~\.vscode\extensions\ms-python.python-2022.4.1\pythonFiles\get_output_via_markers.py -c "import torch_tb_profiler; print(torch_tb_profiler.__version__)"
[INFO 2022-3-13 19:49:12.25]: Using log directory specified by python.tensorBoard.logDirectory setting: D:\workspace_tmp\runs
[DEBUG 2022-3-13 19:49:12.25]: Cached data exists getEnvironmentVariables, <No Resource>
> D:\Folders\Users\zhang\anaconda3\python.exe ~\.vscode\extensions\ms-python.python-2022.4.1\pythonFiles\tensorboard_launcher.py .\runs
[INFO 2022-3-13 19:49:12.38]: Starting TensorBoard with log directory D:\workspace_tmp\runs...
[INFO 2022-3-13 19:49:12.147]: Starting TensorBoard with logdir D:\workspace_tmp\runs
[ERROR 2022-3-13 19:49:13.44]: Traceback (most recent call last):
  File "c:\Users\zhang\.vscode\extensions\ms-python.python-2022.4.1\pythonFiles\tensorboard_launcher.py", line 36, in <module>

[ERROR 2022-3-13 19:49:13.45]:     main(logdir)
  File "c:\Users\zhang\.vscode\extensions\ms-python.python-2022.4.1\pythonFiles\tensorboard_launcher.py", line 17, in main
    tb = program.TensorBoard()
  File "D:\Folders\Users\zhang\anaconda3\lib\site-packages\tensorboard\lazy.py", line 65, in __getattr__

[ERROR 2022-3-13 19:49:13.45]:     return getattr(load_once(self), attr_name)
  File "D:\Folders\Users\zhang\anaconda3\lib\site-packages\tensorboard\lazy.py", line 97, in wrapper

[ERROR 2022-3-13 19:49:13.45]:     cache[arg] = f(arg)
  File "D:\Folders\Users\zhang\anaconda3\lib\site-packages\tensorboard\lazy.py", line 50, in load_once

[ERROR 2022-3-13 19:49:13.45]:     module = load_fn()
  File "D:\Folders\Users\zhang\anaconda3\lib\site-packages\tensorboard\__init__.py", line 99, in program

[ERROR 2022-3-13 19:49:13.45]:     return importlib.import_module("tensorboard.program")

[ERROR 2022-3-13 19:49:13.45]:   File "D:\Folders\Users\zhang\anaconda3\lib\importlib\__init__.py", line 127, in import_module

[ERROR 2022-3-13 19:49:13.45]:     return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import

[ERROR 2022-3-13 19:49:13.46]:   File "<frozen importlib._bootstrap>", line 1007, in _find_and_load

[ERROR 2022-3-13 19:49:13.47]:   File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked

[ERROR 2022-3-13 19:49:13.48]:   File "<frozen importlib._bootstrap>", line 680, in _load_unlocked

[ERROR 2022-3-13 19:49:13.49]:   File "<frozen importlib._bootstrap_external>", line 850, in exec_module

[ERROR 2022-3-13 19:49:13.50]:   File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed

[ERROR 2022-3-13 19:49:13.51]:   File "D:\Folders\Users\zhang\anaconda3\lib\site-packages\tensorboard\program.py", line 52, in <module>

[ERROR 2022-3-13 19:49:13.51]:     from tensorboard.backend import application
  File "D:\Folders\Users\zhang\anaconda3\lib\site-packages\tensorboard\backend\application.py", line 44, in <module>

[ERROR 2022-3-13 19:49:13.51]:     from tensorboard.plugins.core import core_plugin
  File "D:\Folders\Users\zhang\anaconda3\lib\site-packages\tensorboard\plugins\core\core_plugin.py", line 32, in <module>

[ERROR 2022-3-13 19:49:13.51]:     from tensorboard.util import grpc_util
  File "D:\Folders\Users\zhang\anaconda3\lib\site-packages\tensorboard\util\grpc_util.py", line 24, in <module>

[ERROR 2022-3-13 19:49:13.51]:     import grpc
  File "D:\Folders\Users\zhang\anaconda3\lib\site-packages\grpc\__init__.py", line 22, in <module>

[ERROR 2022-3-13 19:49:13.51]:     from grpc import _compression
  File "D:\Folders\Users\zhang\anaconda3\lib\site-packages\grpc\_compression.py", line 15, in <module>

[ERROR 2022-3-13 19:49:13.52]:     from grpc._cython import cygrpc
ImportError: DLL load failed while importing cygrpc: 找不到指定的模块。

[DEBUG 2022-3-13 19:49:17.887]: Cached data exists KeyPrefix=Cache_Method_Output__.ensureEnvironmentContainsPython-Args="D:\\Folders\\Users\\zhang\\anaconda3\\python.exe"
[ERROR 2022-3-13 19:50:12.47]: Encountered error while starting new TensorBoard session: Error: Timed out after 60 seconds waiting for TensorBoard to launch.

But when I execute tensorboard --logdir=./runs in the built-in shell (conda activated), it works fine.
I think the reason is that the extension found the correct interpreter D:\Folders\Users\zhang\anaconda3\python.exe, also Ensuring TensorBoard package is installed into active interpreter, but it did not execute pythonFiles\tensorboard_launcher.py in the conda environment.
I know that one solution is to let VS Code start in the shell that activates conda (like conda run -n base code), but that is not convenient.
I hope that extension can directly launch TensorBoard in conda environment.

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): 3.9.12
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Conda
Value of the python.languageServer setting: Default

User Settings

defaultLS: {"defaultLSType":"Pylance"}

downloadLanguageServer: true

envFile: "<placeholder>"

venvPath: "<placeholder>"

venvFolders: "<placeholder>"

condaPath: "<placeholder>"

pipenvPath: "<placeholder>"

poetryPath: "<placeholder>"

languageServer: "Pylance"

linting
• enabled: true
• cwd: "<placeholder>"
• Flake8Args: "<placeholder>"
• flake8Enabled: false
• flake8Path: "<placeholder>"
• lintOnSave: true
• banditArgs: "<placeholder>"
• banditEnabled: false
• banditPath: "<placeholder>"
• mypyArgs: "<placeholder>"
• mypyEnabled: false
• mypyPath: "<placeholder>"
• pycodestyleArgs: "<placeholder>"
• pycodestyleEnabled: false
• pycodestylePath: "<placeholder>"
• prospectorArgs: "<placeholder>"
• prospectorEnabled: false
• prospectorPath: "<placeholder>"
• pydocstyleArgs: "<placeholder>"
• pydocstyleEnabled: false
• pydocstylePath: "<placeholder>"
• pylamaArgs: "<placeholder>"
• pylamaEnabled: false
• pylamaPath: "<placeholder>"
• pylintArgs: "<placeholder>"
• pylintPath: "<placeholder>"

sortImports
• args: "<placeholder>"
• path: "<placeholder>"

formatting
• autopep8Args: "<placeholder>"
• autopep8Path: "<placeholder>"
• provider: "autopep8"
• blackArgs: "<placeholder>"
• blackPath: "<placeholder>"
• yapfArgs: "<placeholder>"
• yapfPath: "<placeholder>"

testing
• cwd: "<placeholder>"
• debugPort: 3000
• nosetestArgs: "<placeholder>"
• nosetestsEnabled: undefined
• nosetestPath: "<placeholder>"
• promptToConfigure: true
• pytestArgs: "<placeholder>"
• pytestEnabled: false
• pytestPath: "<placeholder>"
• unittestArgs: "<placeholder>"
• unittestEnabled: false
• autoTestDiscoverOnSaveEnabled: true

terminal
• activateEnvironment: true
• executeInFileDir: "<placeholder>"
• launchArgs: "<placeholder>"

experiments
• enabled: true
• optInto: []
• optOutFrom: []

tensorBoard
• logDirectory: "<placeholder>"

Extension version: 2022.4.1
VS Code version: Code 1.66.2 (dfd34e8260c270da74b5c2d86d61aee4b6d56977, 2022-04-11T07:46:01.075Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (8 x 1992)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.88GB (7.99GB free)

Process Argv
. --crash-reporter-id 6aa90eab-fda9-4eac-ba80-539d500062c9

Screen Reader
no

VM
67%

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30443607
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
pythonvsnew555:30457759
vscscmwlcmt:30465135
pynewfile477:30463512

This should be an easy enough fix, basically we're not activating the python environment when lauching tensorboard.
Surprised this has worked so long. Would never work for conda environments.

Wonder if we have any telemetry on the usage of this feature. Conserned that we've added this and its never worked for conda for so long. I.e. is this a feature thats rarely used.

@DonJayamanne, is this something we'd want to mention in our wiki?

something we'd want to mention in our wiki?

i think we should just fix the bug in the python extension. i don't think updating the wiki is necessary.

Pulling back to triage as it looks like more customers are hitting this.

Same bug with conda on my end

authors: DonJayamanne IanMatthewHuff PillarsZhang YoniChechik greazer


text:
onLinkedEditingRange should not define never as error type

https://github.com/microsoft/vscode-languageserver-node/blob/53d122831050088171296dc02b57257f5178f0b6/server/src/common/linkedEditingRange.ts#L21
All other messages define void, e.g.
https://github.com/microsoft/vscode-languageserver-node/blob/53d122831050088171296dc02b57257f5178f0b6/server/src/common/server.ts#L1249

Good catch. Will fix.

authors: aeschli dbaeumer

repo: microsoft/vscode-languageserver-node

license: mit

license_source: bigquery


text:
Feature: Auto Populate Labels

Implements request: #5258

Demo

repo: microsoft/vscode-pull-request-github


text:
LaTeX code snippet in Markdown cell

I'm trying to include a LaTeX code snippet in a Markdown cell in a notebook, using a fenced code block:
While editing, it looks like this:

Rendered it looks like this:

As you can see, the code is rendered as code, but also there are $$s inserted before and after the document environment.
I believe this is due to MathJax, which detects a possible math environment and marks it explicitly as such.
The same happens if I use an indented code block, or an explicit HTML <code> tag.
I propose that MathJax in the extension is configured to ignore code snippets, probably using the skipHtmlTags configuration option

@allefeld Thanks for filing. I just checked it out and I confirm the same repro that you do. Looks like our math handling code is getting in the way there.

similiar problem in  torch module

authors: CatNofishing IanMatthewHuff allefeld

repo: microsoft/vscode-python


text:
Allow uninstall of Jupyter Extension

I don't use Jupiter and don't want it.  But you won't let me disable or uninstall it.

Duplicate of #16102 (which is being addressed in the release that should be going out today).

authors: brettcannon markburgessstl


text:
Automatically add the "community feedback" boilerplate comment when "needs community feedback" label is added

Makes it so we have a single copy of that comment. Should be doable entirely as a Github Action.

https://github.com/microsoft/vscode-python/actions/runs/4694820958/jobs/8323337524

authors: brettcannon karthiknadig


text:
Smoke test to ensure Extension loads in other localizations

We cannot repeat #5437 (extension was not usable for a large number of users).

@rchiodo had a good suggestion for changing the VS Code locale

Change locale
Ensure extension loads

Download Chinese (or other locale) specific extension (`vsix)
Install the vsix
Reload VS Code
Now VS Code is using chinese locale
Open python file
Confirm status bar appears on bottom left

Spike completed. Closing in favor of #6855.

authors: DonJayamanne karrtikr


text:
Update npm webpack-bundle-analyzer project

Upgrade to version 3.3.2 or later.

Updated

authors: DonJayamanne brettcannon


text:
atexit registered functions that print to stdout break test discovery

When exit handlers that print to standard out are registered using the atexit module, pytest test discovery fails.
Environment data

VS Code version: 1.36.1
Extension version (available under the Extensions sidebar): 2019.6.24221
OS and version: Ubuntu Linux 18.04.2
Python version (& distribution if applicable, e.g. Anaconda): Python 3.7.4
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv
Relevant/affected Python packages and their versions: pytest
Jedi or Language Server? (i.e. what is "python.jediEnabled" set to; more info #3977): Language Server

Expected behaviour
I would expect the relevant tests to be discovered.
Actual behaviour
Test discovery fails because extra text is appended to whatever output is used to store the JSON description of the discovered tests, which subsequently causes a SyntaxError when parsing.
Steps to reproduce:
Allow test discovery to run on the minimal demonstration repository here: https://github.com/joel-wright/pytest-discovery-atexit
Logs
Output for Python Test Log:
python /home/jjw/.vscode/extensions/ms-python.python-2019.6.24221/pythonFiles/testing_tools/run_adapter.py discover pytest -- -s --cache-clear
Test Discovery failed:
SyntaxError: Unexpected token I in JSON at position 436

That is definitely a function of how our test discovery tooling works.  We capture stdout while pytest discovery runs (and only show it on failure) and then write the discovery results to stdout.  The best we could do for now is to clear all atexit handlers before the discovery tool finishes.  However, doing so would require a bit of a hack (monkey-patching atexit.register()), so it might not be worth it.
FWIW, we are looking into an alternative approach that would not break with your atexit handler, but that would not be happening any time soon.

I love the sound of the alternative approach (I discovered this in a relatively large project where test discovery takes multiple minutes).

Closing in favour of https://github.com/microsoft/vscode-python/issues/6594.

authors: ericsnowcurrently joel-wright luabud


text:
Also pin Node version for coverage reports upload job

Fix one last insiders workflow failure in https://github.com/microsoft/vscode-python/actions/runs/348786875

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

Codecov Report

Merging #14647 into main will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14647      +/-   ##
==========================================
- Coverage   65.02%   65.01%   -0.01%
==========================================
  Files         543      543
  Lines       25425    25425
  Branches     3593     3593
==========================================
- Hits        16532    16531       -1
- Misses       8216     8217       +1
  Partials      677      677

Impacted Files
Coverage Δ

src/client/common/utils/platform.ts
68.00% <0.00%> (-4.00%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d801a8...f0f5e6b. Read the comment docs.

authors: codecov-io joyceerhl


text:
Open Repository Quick Pick should show current Github user's repos at the top of the list on first launch

Currently, on adding a remote github repo for the first time, the list includes repositories who's ordering appears random

Subsequent remote repository additions appear to show a filtered list:

Duplicate of https://github.com/microsoft/vscode/issues/163603

authors: bhavyaus joyceerhl


text:
gitProtocol setting (ssh) is ignored (regr?)

Hi again,
like in #294 , i have "remoteHub.gitProtocol": "ssh"+"github.gitProtocol": "ssh", but the setting is ignored when i run the command "remote repositories: continue working in new local clone".
As of today (Remote Repositories v0.35.2023052901 Pre-Release + vscode Version: 1.78.2/vscode Version: 1.79.0-insider), using that command opens a new window, the window opens a URL like

vscode://vscode.git/clone?url%3Dhttps%253A%252F%252Fgithub.com%252Fshaka-project%252Fshaka-player%26ref%3Dmain

then it errors out because on my system HTTPS has been disabled while SSH is enabled:
2023-05-30 11:09:03.738 [info] Log level: Info
2023-05-30 11:09:03.738 [info] Validating found git in: "C:\Program Files\Git\cmd\git.exe"
2023-05-30 11:09:03.867 [info] Using git "2.40.1.windows.1" from "C:\Program Files\Git\cmd\git.exe"
2023-05-30 11:09:04.161 [info] GitProtocolHandler.handleUri(vscode://vscode.git/clone?url%3Dhttps%253A%252F%252Fgithub.com%252Fshaka-project%252Fshaka-player%26ref%3Dmain)
2023-05-30 11:09:05.790 [info] Executing git.clone for https://github.com/shaka-project/shaka-player
2023-05-30 11:09:11.464 [info] > git clone https://github.com/shaka-project/shaka-player c:\_projects\~rnd\shaka-player --progress --branch main [124ms]
2023-05-30 11:09:11.464 [info] Cloning into 'c:\_projects\~rnd\shaka-player'...
fatal: transport 'https' not allowed

i think it could be a regression.

have a nice day

@joyceerhl how do I trigger remote repositories: continue working in new local clone?

Verifying ssh protocol was used after changing the setting.

can confirm fixed in Github Repositories v0.57.2023060101

authors: aetonsi bhavyaus meganrogge


text:
refresh Port list

Type: Feature Request
I wish the extension would provide a button to refresh the serial port.
current issue：

Reference implementation:
https://github.com/imlinhanchao/vsc-serialport-helper/blob/master/src/SerialPort.js
class SerialPortProvider {
	constructor(context) {
		this._onDidChangeTreeData = new vscode.EventEmitter();
		this.refreshPort();
		this.ports = [];
		this.context = context;
	}

	get onDidChangeTreeData() {
		return this._onDidChangeTreeData.event
	}

	async refreshPort() {
		let ports = await SerialPort.search();
		let paths = this.ports.map(p => p.path);
		let portNew = ports.filter(p => paths.indexOf(p.path) < 0);
		paths = ports.map(p => p.path);
		this.ports = this.ports.filter(p => paths.indexOf(p.path) >= 0);
		this.ports = this.ports.concat(portNew.map(p => new SerialPortItem(p, this.context,
			vscode.TreeItemCollapsibleState.Collapsed, () => {
			this._onDidChangeTreeData.fire();
		})))
	}

	refresh() {
		this.refreshPort();
		this._onDidChangeTreeData.fire();
	}

	getTreeItem(element) {
		return element;
	}

	async getChildren(element) {
		if (!element) {
			return await this.getSerialPortList();
		} else {
			console.dir(element);
			return ['baudRate', 'dataBits', 'stopBits', 'parity', 'view_mode'].map(a => new SerialPortAttr(element, a,
				vscode.TreeItemCollapsibleState.None, () => {
				this._onDidChangeTreeData.fire();
			}))
		}

	}

	async getSerialPortList() {
		return this.ports;
	}
}

@hongshui3000 Have you tried unplugging the device, waiting a second, and then plugging it back in?
I tried to reproduce your issue and wasn't able to, I was able to re-populate the list by doing this.

Even if I replug it, the extension cannot be recognized, but I can recognize it when I open another monitor. This problem can only appear on certain brands of usb serial ports, and it seems to be related to the usb driver. I think if there is a function that can refresh the list, it should solve all issues. This is how I solved the issue when I used another extension of (refresh list)

Sometimes I can still find duplicate serial ports and I can't refresh

@hongshui3000
A manual refresh button has been added in the most recent pre-release version! Please feel free to try it out and let us know if this fixes your issue.

@hongshui3000 A manual refresh button has been added in the most recent pre-release version! Please feel free to try it out and let us know if this fixes your issue.

yes ，it works well. thanks

This is now available in the official release channel with version 0.8.0, closing the issue.

repo: microsoft/vscode-serial-monitor


text:
Make the RMB Python popup menu more compact vertically.   Repetitive Stress Hazard!

Right now, the rmb Python popup menu takes up a LOT of vertical space on the screen. I have found that reaching up or down a significant distance on the screen to use it repeatedly while editing Python code makes my right wrist start to ache. Please make it vertically more compact!
...Bob

\extPython

authors: JacksonKearl rbtyod

repo: microsoft/vscode


text:
Ctrl + Click doesn't opens the clicked file

VSCode Version: 1.47.2
OS Version: Ubuntu 18 LTS

Steps to Reproduce:

Create two files as shown in the screenshot.
Try Ctrl + Click on a new file. It will open the same file in half split while it should open the clicked file.

Does this issue occur when all extensions are disabled?: Yes

Works fine for me.

Yes, I can reproduce it in 1.48.0-insider.

Can you clarify your steps, from the gif it is not exactly clear.
So minimal exact steps would be great. Thanks

open two files side by side.
single click on any file.
Now, ctrl+click on any other file, it will open the wrong file.

Works for me. Let's leave this open to see if other users also hit this.
Thanks

Can we keep this open?

Sure, we can keep it open for a bit more time and we see if more users hit this.

authors: gurrrung isidorn


text:
VS code hangs While using it

Hi
I am using VS code version 1.47.3 on my PC
PC Specification :
Company  :HP
Processor : Intel i5 8250U
OS : Windows 10 ( build 2004 ) home single Language ( Preinstalled with the PC)
When Problem occur :
1 ) When I open more files in the editor
2 ) When I click some test and jumps to other file
3 ) When i type too fast.
This happens with VS code only . With other editor its working fine

Can you check if the issue happens with our exploration builds https://az764295.vo.msecnd.net/exploration/f0e1fbf4cb8c4c27d6290f0310f5a4d63597cd21/VSCodeUserSetup-x64-1.48.0-exploration.exe

No more issue ocured so closing the issue