text:
ocamlPackages.camomile: 1.0.2 → 2.0.0

Package name: ocamlPackages.camomile
Latest released version: 2.0.0

Current version on the unstable channel: 1.0.2
Current version on the stable/release channel: 1.0.2

[x] Checked the nixpkgs pull requests

Notify maintainers
@vbgl

Note for maintainers:
I was looking to do the 4.5.0 Soupault upgrade, but I ran into Camomile 2.x dependency issue.
It looks like Camomile switched maintainers: https://github.com/savonet/Camomile
And the upgrade had some notable breaking changes: https://discuss.ocaml.org/t/ann-camomile-2-0-0-is-out/11751/
My experience in this ecosystem is too low to know what needs to be done. Does it need a 2_0_0.nix file while the dust settles on other project upgrading? Are the configurePhase and postInstall hooks still relevant? Is cppo needed? Does it get moved to a more modern (e.g. 5.x) version of the packages?
Please feel free to tag me to review and test build it if @vbgl could use the extra eyes and/or testing.

So I attempted this last week and the issue is that Camomile 2.0 is quite different from previous versions. The only reason therefore we would add camomile 2 is if anybody is actually using it. I am not currently aware of any packages that require it.
The discussions do also mention that other users have been frustrated by this. Therefore I think it is best if we think of Camomile 2 as a new library, therefore we currently have no reason to add it.
What we really need are compatability patches for Camomile 1.0 so that we can use it with OCaml 5.

authors: Alizter toastal


text:
Package request: lfortran

LFORTRAN

Metadata

homepage URL:  https://lfortran.org/
source URL:  https://github.com/lfortran/lfortran
license: BSD 3
platforms: unix, linux, darwin

Add a :+1: reaction to issues you find important.

LFortran is a modern open-source (BSD licensed) interactive Fortran compiler built on top of LLVM. It can execute user’s code interactively to allow exploratory work (much like Python, MATLAB or Julia) as well as compile to binaries with the goal to run user’s code on modern architectures such as multi-core CPUs and GPUs.

Full Fortran 2018 parser
LFortran can parse any Fortran 2018 syntax to AST (Abstract Syntax Tree) and format it back as Fortran source code (lfortran fmt).

Interactive, Jupyter support
LFortran can be used as a Jupyter kernel, allowing Python/Julia-style rapid prototyping and an exploratory workflow (conda install jupyter lfortran). It can also be used from the command-line with an interactive prompt (REPL).

Create executables
It can create executables just like other Fortran compilers.

Runs on Linux, Mac, Windows and WebAssembly
All four platforms are regularly tested by our CI.

UNDER DEVELOPMENT

Full Fortran 2018 support
The parser can now parse all of Fortran 2018 syntax to AST. A smaller subset can be transformed into ASR and even smaller subset compiled via LLVM to machine code. We are now working on extending the subset that LFortran can fully compile until we reach full Fortran 2018 support.

source: gharchive/issue

repo: NixOS/nixpkgs

license: MIT

license_type: permissive

license_source: github-api


text:
dolibarr: php version too high

Describe the bug
Trying to activate the dolibarr service, in the installation phase, dolibarr complains that the PHP version (8.2.13) is too high, requests version 8.1.0 or lower...
I guess we could add a phpPackage option to change the version of php used ?
Steps To Reproduce
on nixos 23.11 for a minimal installation add
services.dolibarr = {
  enable = true;
  nginx = {
    rejectSSL = true;
    forceSSL = false;
    enableACME = false;
  };
};

to your config, go to http://localhost/install/check.php and see the error message about the php version.
Notify maintainers
@RaitoBezarius
Metadata
[user@system:~]# nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.64, NixOS, 23.11 (Tapir), 23.11.1209.933d7dc15509`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(smyds): `""`
 - channels(root): `"nixos-23.11"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

I'm not maintainer anymore of Dolibarr (this was not updated on NixOS stable yet).

@smyds are you able to make a PR with the fix?

authors: RaitoBezarius aanderse smyds


text:
Package request: OpenAudible

Project description
OpenAudible is a cross-platform audiobook manager designed for Audible users allowing to manage/download all audiobooks with one desktop application.
Metadata

homepage URL:https://openaudible.org/
source URL:https://github.com/openaudible/openaudible
license: Apache v2.0
platforms: linux

The most straightforward way to package this would probably be their AppImage. It already runs just fine with appimage-run.
Add a :+1: reaction to issues you find important.

Ah, I just noticed that this software is not actually free and open source. The github repository in particular is out of date. Libation is the free and open source alternative to this. Feel free to close this, I won't be needing it.


text:
LLVM 8 (currently on -rc3)

Issue description
It would be good to get started on this so as to provide feedback upstream and so we're ready when the release is made.
I'm not sure if this release will build in the same way as the previous versions, or if it's time to use runtimes and similar directories as upstream increasingly prefers (and possibly single unified tree).
Unfortunately I don't think I'll have time to tackle this in the near-ish future, so flagging it in case someone else wants to take on this task :).
As usual LLVM and NixOS releases are close but not quite close enough to easily include the LLVM release in 19.03 (but new versions can be backported so not a big deal perhaps).

This looks to have been already tackled as part of https://github.com/NixOS/nixpkgs/pull/56555 -- modulo bumping to rc3 but that's generally easy once the new version is otherwise working :).

There's a separate PR, so let's move discussion in there.

authors: dtzWill vcunat


text:
Vulnerability roundup 76: go-1.11.13: 1 advisory

search, files

[ ] CVE-2018-17075 (nixos-19.03)

Scanned versions: nixos-19.03: 2c61951df92. May contain false positives.

This appears to be a CVE for an external package that is not being used by any of Go programs that is being included in nixpkgs.

I agree. This does not look applicable.

authors: ckauhaus d-goldin xfix


text:
Make maintainer documentation more direct

Additionally fixes the "list of names and emails" to be a list of maintainer expressions.
A follow-up from the discussion in https://github.com/NixOS/nixpkgs/pull/96666

OMG thank u.

Haha, I didn't realize the change was that dramatic 😄

Haha, I didn't realize the change was that dramatic smile

Editing docbook sources is always dramatic :rofl:

source: gharchive/pull-request

authors: kevincox worldofpeace


text:
nextcloud: 20.0.5 -> 20.0.6

Motivation for this change
Bump nextcloud server
sha from https://download.nextcloud.com/server/releases/nextcloud-20.0.6.tar.bz2.sha256
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date (no changes needed)
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 111477 run on x86_64-linux 1

1 package blacklisted:

tests.nixos-functions.nixos-test

1 package built:

nextcloud20

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 111477 run on x86_64-linux 1

1 package blacklisted:

tests.nixos-functions.nixos-test

1 package built:

nextcloud20

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 111477 run on x86_64-darwin 1

1 package built:

nextcloud20

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 111477 run on x86_64-darwin 1

1 package built:

nextcloud20

Result of nixpkgs-review pr 111477 at f179c0f0 run on x86_64-linux 1

1 package blacklisted:

tests.nixos-functions.nixos-test

1 package built:

nextcloud20

1 warning produced:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/servers/nextcloud/default.nix:18:5:
   |
18 |     installPhase = ''
   |     ^

Result of nixpkgs-review pr 111477 at f179c0f0 run on x86_64-linux 1

1 package blacklisted:

tests.nixos-functions.nixos-test

1 package built:

nextcloud20

1 warning produced:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/servers/nextcloud/default.nix:18:5:
   |
18 |     installPhase = ''
   |     ^

Currently deploying this to a machine. After that I can merge :)

Thanks! Ported to stable as f5543edb87dd52cf057bbe8a29a182b5042d2c73.


text:
gxkb: init at 0.9.0

Motivation for this change
I want to use this lightweight layout switcher on daily basis
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Please squash the commits.

done.

Result of nixpkgs-review pr 115323 at 1e08c477 run on aarch64-linux 1

1 package built:

gxkb

1 suggestion:

warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/misc/gxkb/default.nix:25:5:
   |
25 |     license = licenses.gpl2;
   |     ^

authors: omgbebebe r-rmcgibbo siraben


text:
fwupd: 1.5.5 → 1.5.7

Motivation for this change
Announcement:

https://blogs.gnome.org/hughsie/2021/02/16/fwupd-1-5-6/

Changelogs:

https://github.com/fwupd/fwupd/releases/tag/1.5.6
https://github.com/fwupd/fwupd/releases/tag/1.5.7

Main changes:

Adds UEFI  SBAT support:
https://github.com/fwupd/fwupd/blob/1.5.7/plugins/uefi-capsule/README.md#uefi-sbat-support
https://github.com/rhboot/shim/blob/39b96c01bfd4547f38c9e573ff5d551057ea272c/SBAT.md

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 116435 at ae44266b run on x86_64-linux 1

2 packages marked as broken and skipped:

libsForQt512.discover
libsForQt514.discover

4 packages built successfully:

fwupd
gnome-firmware-updater
gnome3.gnome-software
libsForQt5.discover (libsForQt515.discover ,plasma5Packages.discover)

authors: jtojnar r-rmcgibbo


text:
telepresence2: init at 2.1.4

Motivation for this change
There's already a telepresence package but that's version 0.x .
It has since been rewritten in Go and called version 2.x
More importantly, this is a separate package because the interface for telepresence is completely different i.e. it's pretty much an entirely different program (with the same purpose of course).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@ofborg eval

Result of nixpkgs-review pr 119063 at 21057329 run on aarch64-linux 1

1 package failed to build:

telepresence2

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

authors: SuperSandro2000 mausch r-rmcgibbo


text:
python3Packages.pyfronius: 0.6.0 -> 0.6.2

Motivation for this change
Update to latest upstream release 0.6.2
Change log: https://github.com/nielstron/pyfronius/releases/tag/release-0.6.2
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 135019 run on x86_64-linux 1

2 packages built:

python38Packages.pyfronius
python39Packages.pyfronius


text:
zfsUnstable: correct sha256

Motivation for this change
The hash was not updated as part of #138168.
Also document the discussion from #136340 for the maintainers.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 138427 run on x86_64-linux 1

2 packages marked as broken and skipped:

linuxKernel.packages.linux_latest_libre.zfsUnstable
linuxKernel.packages.linux_libre.zfsUnstable

18 packages built:

linuxKernel.packages.linux_4_14.zfsUnstable
linuxKernel.packages.linux_4_14_hardened.zfsUnstable
linuxKernel.packages.linux_4_19.zfsUnstable
linuxKernel.packages.linux_4_19_hardened.zfsUnstable
linuxKernel.packages.linux_4_4.zfsUnstable
linuxKernel.packages.linux_4_9.zfsUnstable
linuxKernel.packages.linux_5_10.zfsUnstable
linuxKernel.packages.linux_hardened.zfsUnstable (linuxKernel.packages.linux_5_10_hardened.zfsUnstable)
linuxKernel.packages.linux_5_13.zfsUnstable
linuxKernel.packages.linux_5_13_hardened.zfsUnstable
linuxKernel.packages.linux_5_14.zfsUnstable
linuxKernel.packages.linux_5_4.zfsUnstable
linuxKernel.packages.linux_5_4_hardened.zfsUnstable
linuxKernel.packages.linux_lqx.zfsUnstable
linuxKernel.packages.linux_testing_bcachefs.zfsUnstable
linuxKernel.packages.linux_xanmod.zfsUnstable
linuxKernel.packages.linux_zen.zfsUnstable
zfsUnstable

Oops, ofborg fails with No space left on device

Works for me.


text:
libvmaf: 2.2.0 -> 2.2.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/netflix/vmaf/releases.
meta.description for libvmaf is: "Perceptual video quality assessment based on multi-method fusion (VMAF)"
meta.homepage for libvmaf is: "https://github.com/Netflix/vmaf"
meta.changelog for libvmaf is: "https://github.com/Netflix/vmaf/blob/v2.2.1/CHANGELOG.md"
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/p9sza9li9920lv4a1v79b40hhdjj6bbk-libvmaf-2.2.1/bin/vmaf passed the binary check.

1 of 1 passed binary check by having a zero exit code.

1 of 1 passed binary check by having the new version present in output.

found 2.2.1 with grep in /nix/store/p9sza9li9920lv4a1v79b40hhdjj6bbk-libvmaf-2.2.1

found 2.2.1 in filename of file in /nix/store/p9sza9li9920lv4a1v79b40hhdjj6bbk-libvmaf-2.2.1

directory tree listing: https://gist.github.com/868d9175de788ffb5d8da7d4e2a30a89

du listing: https://gist.github.com/b967768220c5cb1b37fadeff234bf1f7

Rebuild report (if merged into master) (click to expand)

83 total rebuild path(s)

39 package rebuild(s)

39 x86_64-linux rebuild(s)
27 i686-linux rebuild(s)
16 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
MIDIVisualizer
arcan.all-wrapped
arcan.arcan
arcan.arcan-wrapped
arcan.durden-wrapped
arcan.ffmpeg
arcan.pipeworld-wrapped
arcan.prio-wrapped
arcan.xarcan
corrscope
ffmpeg-full
handbrake
imagination
libsForQt5.kdenlive
libsForQt5.soundkonverter
libsForQt512.kdenlive
libsForQt512.soundkonverter
libsForQt514.kdenlive
libsForQt514.soundkonverter
libsForQt515.kdenlive
libsForQt515.soundkonverter
libvmaf
liquidsoap
manim
olive-editor
plasma5Packages.kdenlive
plasma5Packages.soundkonverter
printrun
python38Packages.moderngl-window
python38Packages.pydub
python38Packages.pyglet
python38Packages.pytmx
python39Packages.moderngl-window
python39Packages.pydub
python39Packages.pyglet
python39Packages.pytmx
restream
soundkonverter
webcamoid

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/p9sza9li9920lv4a1v79b40hhdjj6bbk-libvmaf-2.2.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libvmaf https://github.com/r-ryantm/nixpkgs/archive/7376977b9e4fd64a60d5017cc1ca603a78cafd22.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/p9sza9li9920lv4a1v79b40hhdjj6bbk-libvmaf-2.2.1
ls -la /nix/store/p9sza9li9920lv4a1v79b40hhdjj6bbk-libvmaf-2.2.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages marked as broken and skipped:

libsForQt512.kdenlive
libsForQt512.soundkonverter
libsForQt514.kdenlive
libsForQt514.soundkonverter

29 packages built:

MIDIVisualizer
arcan.all-wrapped
arcan.arcan
arcan.arcan-wrapped
arcan.durden-wrapped
arcan.ffmpeg
arcan.pipeworld-wrapped
arcan.prio-wrapped
arcan.xarcan
corrscope
handbrake
imagination
libsForQt5.kdenlive
libsForQt5.soundkonverter
libvmaf
liquidsoap
manim
olive-editor
printrun
python38Packages.moderngl-window
python38Packages.pydub
python38Packages.pyglet
python38Packages.pytmx
python39Packages.moderngl-window
python39Packages.pydub
python39Packages.pyglet
python39Packages.pytmx
restream
webcamoid

Maintainer pings
cc @cfsmp3 @marsam for testing.

LGTM

@ofborg eval


text:
python38Packages.browser-cookie3: 0.12.1 -> 0.13.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.browser-cookie3 is: "Loads cookies from your browser into a cookiejar object"
meta.homepage for python38Packages.browser-cookie3 is: "https://github.com/borisbabic/browser_cookie3"
meta.changelog for python38Packages.browser-cookie3 is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.13.0 with grep in /nix/store/k92x9in2f0jlmsgmj4b9hym5zcnxp3ph-python3.8-browser-cookie3-0.13.0

found 0.13.0 in filename of file in /nix/store/k92x9in2f0jlmsgmj4b9hym5zcnxp3ph-python3.8-browser-cookie3-0.13.0

directory tree listing: https://gist.github.com/1d2a373ceb2bb5352805c322403e5f05

du listing: https://gist.github.com/08ef4e4e409b0cfa30d2d6ed5f27ff1c

Rebuild report (if merged into master) (click to expand)

12 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python38Packages.browser-cookie3
python39Packages.browser-cookie3
wapiti

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/k92x9in2f0jlmsgmj4b9hym5zcnxp3ph-python3.8-browser-cookie3-0.13.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.browser-cookie3 https://github.com/r-ryantm/nixpkgs/archive/ee165d92222b96a4a989abc6c37ac9f3f4a90d18.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/k92x9in2f0jlmsgmj4b9hym5zcnxp3ph-python3.8-browser-cookie3-0.13.0
ls -la /nix/store/k92x9in2f0jlmsgmj4b9hym5zcnxp3ph-python3.8-browser-cookie3-0.13.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

python38Packages.browser-cookie3
python39Packages.browser-cookie3
wapiti

Maintainer pings
cc @borisbabic for testing.

Result of nixpkgs-review pr 140934 run on x86_64-linux 1

3 packages built:

python38Packages.browser-cookie3
python39Packages.browser-cookie3
wapiti

authors: fabaff r-ryantm


text:
citra: add build options

Motivation for this change
Why not?
Things done

I'm not sure if all of these options should be true by default. Should I respect Citra's CMakeLists.txt defaults or the more stuff is true the better?
That assert maybe is overkill, if one simply has both options true the only effect is that FDK won't be enabled.
I changed one option name. It's technically a breaking change, but I doubt that anyone overrode that option.
I didn't put any option for ENABLE_QT_TRANSLATION.
-DCITRA_USE_BUNDLED_FFMPEG=OFF has been removed because it's already off if you are not building on Windows.
alsa-lib was doing nothing here.
Is libusb being devendored if it's just being put in buildInputs?

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Done.
What about the remaining questions? (The overkill assert, whether libusb is devendored, and the breaking change)

Apologies about answering the questions a bit later than code review, I got busy the other day.

I'm not sure if all of these options should be true by default. Should I respect Citra's CMakeLists.txt defaults or the more stuff is true the better?

I'd say the more stuff the better. Closure size isn't massively effected, so having CI build this with support for as much stuff as possible makes sense to me.

I changed one option name. It's technically a breaking change, but I doubt that anyone overrode that option.

I think that should be fine, as you said it probably won't affect anyone.

That assert maybe is overkill, if one simply has both options true the only effect is that FDK won't be enabled.

IMO can't hurt to have it, it can potentially save a fair bit of debugging.

I didn't put any option for ENABLE_QT_TRANSLATION.

Why not?

Is libusb being devendored if it's just being put in buildInputs?

Yes! See https://github.com/citra-emu/citra/blob/324e88d6e08ab8bc95671e6ba8011fc8812ac2c9/CMakeLists.txt#L205.

I didn't put ENABLE_QT_TRANSLATION because I didn't know what dependency it needed.
I should have just taken a look at Yuzu.

I found out that if I build without Qt, Citra won't find the GPU drivers:
libGL error: MESA-LOADER: failed to open radeonsi: /nix/store/kgzhnlza09sw2kzzvmp3jp0bypsglqkp-libdrm-2.4.108/lib/libdrm_nouveau.so.2: undefined symbol: drmCloseBufferHandle (search paths /run/opengl-driver/lib/dri, suffix _dri)
libGL error: failed to load driver: radeonsi
libGL error: MESA-LOADER: failed to open swrast: /nix/store/kgzhnlza09sw2kzzvmp3jp0bypsglqkp-libdrm-2.4.108/lib/libdrm_nouveau.so.2: undefined symbol: drmCloseBufferHandle (search paths /run/opengl-driver/lib/dri, suffix _dri)
libGL error: failed to load driver: swrast
X Error of failed request:  BadValue (integer parameter out of range for operation)
  Major opcode of failed request:  149 (GLX)
  Minor opcode of failed request:  3 (X_GLXCreateContext)
  Value in failed request:  0x0
  Serial number of failed request:  100
  Current serial number in output stream:  101

I should have tested for this...
Why is it looking for radeonsi and not amdgpu though?

I rebased, and the issue is gone.
No idea why.

authors: IvarWithoutBones SuperSamus


text:
vivaldi: Clean up

Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] OS X
[ ] Linux

[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

@joachifm I believe this is what you have been talking about, right?

Looks much cleaner now :+1:

I like this, learned something today, thx :+1:

Cool

authors: NeQuissimus joachifm


text:
godns: 2.5.3 -> 2.6

Motivation for this change
Update to upstream version 2.6. Release notes: https://github.com/TimothyYe/godns/releases/tag/v2.6.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 156465 run on x86_64-darwin 1

1 package built:

godns

authors: NotGordias linyinfeng


text:
vscode-extensions.daohong-emilio.yash: init at 0.2.8

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

$ nix-build --option system aarch64-linux -A vscode-extensions.daohong-emilio.yash
/nix/store/wak1w38n47lw7v4zxkjfvl95h2p2b6ki-vscode-extension-daohong-emilio-yash-0.2.8
$ nix-build --option system x86_64-linux -A vscode-extensions.daohong-emilio.yash
/nix/store/s1hlg7nx2vga5mfcgrfdihda7bw9qr7l-vscode-extension-daohong-emilio-yash-0.2.8


text:
pythonPackages.lektor: init at 2.3

Motivation for this change
Lektor was missing, first time packaging a python package, hope I did it properly.
Things done

[ ] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

hi @ollieh
Please try to follow the alphabetic 'order' that we try to maintain. It's a bit chaotic but you'll roughly find where the packages are supposed to be.
Furthermore, meta-data is missing.
Finally, have you tested whether the packages all build, and work for all interpreter versions?

Woops, my pypi mirror urls were 404ing, I guess because of the hash and because I'd already prefetched it, it must have just got the already downloaded one? Bit confusing that you have to put the first letter in a separate part of the URL. Fixed those, put it in alphabetical order, and added the metadata. Works on Python 2.7, 3.3, 3.5. Build seems to be failing on travis because of disk space.

Pushed 52bc8d203f846c0ac71af2080495a361ec84f1af.
In the future, please make sure that when tests are included, the tests actually run. If no tests are included disable them. Furthermore, each package should go in a commit of its own, which unfortunately I forgot to check before I pushed this.

authors: FRidh ollieh


text:
python310Packages.ipympl: 0.9.0 -> 0.9.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.ipympl is: "Matplotlib Jupyter Extension"
meta.homepage for python310Packages.ipympl is: "https://github.com/matplotlib/jupyter-matplotlib"
meta.changelog for python310Packages.ipympl is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 0.9.1 with grep in /nix/store/wpgnl92fbc90hbqifdamjnnb8gb5cc4h-python3.10-ipympl-0.9.1
found 0.9.1 in filename of file in /nix/store/wpgnl92fbc90hbqifdamjnnb8gb5cc4h-python3.10-ipympl-0.9.1

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
python310Packages.ipympl
python39Packages.ipympl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/wpgnl92fbc90hbqifdamjnnb8gb5cc4h-python3.10-ipympl-0.9.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.ipympl https://github.com/r-ryantm/nixpkgs/archive/a433cc0312fbb47edda411f9fbc6fd740911e3a0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/wpgnl92fbc90hbqifdamjnnb8gb5cc4h-python3.10-ipympl-0.9.1
ls -la /nix/store/wpgnl92fbc90hbqifdamjnnb8gb5cc4h-python3.10-ipympl-0.9.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python310Packages.ipympl
python39Packages.ipympl

Maintainer pings
cc @jluttine @FabianGD for testing.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/870

authors: nixos-discourse r-ryantm


text:
Move geospatial servers into its own folder

Description of changes
Geospatial servers:

mapcache
mapserver
martin
mbtileserver
pg_featureserv
pg_tileserv
t-rex
tegola
tile38
... what else?

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/887

authors: nixos-discourse sikmir


text:
python3.pkgs.scipy: 1.8.0 -> 1.9.0rc2

Description of changes
Scipy 1.9 comes with meson as build backend.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Done in 44ae9b6090fa093d169d96294498fb2558cf896f.


text:
goreman: 0.3.11 -> 0.3.13

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 182954 run on x86_64-linux 1

1 package built:

goreman

Result of nixpkgs-review pr 182954 run on aarch64-linux 1

1 package built:

goreman

authors: aaronjheng superherointj


text:
python310Packages.google-nest-sdm: 2.0.0 -> 2.1.0

Description of changes
https://github.com/allenporter/python-google-nest-sdm/releases/tag/2.1.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 201207 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.nest
python310Packages.google-nest-sdm
python39Packages.google-nest-sdm


text:
python310Packages.pyperf: 2.4.1 -> 2.5.0

Description of changes
https://github.com/psf/pyperf/releases/tag/2.5.0
This release formally adds support for Python 3.11. I also clean up Python 2 dependencies that are no longer needed.
Related to  https://github.com/NixOS/nixpkgs/pull/154264 and https://github.com/NixOS/nixpkgs/pull/154650.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Please update to 2.6.0 and try checks again

Though I committed everything needed to release a 2.6.0 version upstream, it hasn't yet been released. In the meantime, I've pulled in the patch and enabled the tests.

I thought after the prepare release message that we already have the release.


text:
nixos/powerdns: add secretFile option

Description of changes
This PR adds a secretFile option to the powerdns module. This allows to store secrets like gmysql-password in an environment file, which is then inserted into the correct config using envsubst and so the secrets won't be world-readable in the nix store.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

@ofborg test powerdns


text:
python310Packages.google-cloud-appengine-logging: 1.2.0 -> 1.3.0

Changelog: https://github.com/googleapis/python-appengine-logging/blob/v1.3.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 210384 run on x86_64-linux 1

6 packages built:

python310Packages.google-cloud-appengine-logging
python310Packages.google-cloud-error-reporting
python310Packages.google-cloud-logging
python39Packages.google-cloud-appengine-logging
python39Packages.google-cloud-error-reporting
python39Packages.google-cloud-logging


text:
python310Packages.aiofile: don't depend on asynctest

This fixes the build on Python 3.11.
Description of changes
Apply https://github.com/mosquito/aiofile/commit/9253ca42022f17f630ccfb6811f67876910f8b13 as path.
I didn't update to 3.8.1 because of https://github.com/mosquito/aiofile/issues/78 and the fact that there are no tests in the sdist.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build python311Packages.aiofile

Result of nixpkgs-review pr 214696 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.bmw_connected_drive
python310Packages.aiofile
python310Packages.bimmer-connected
python311Packages.aiofile
python311Packages.bimmer-connected

authors: dotlambda fabaff wegank


text:
Coq: minor refactoring

Motivation for this change
Remove some duplication and ease future maintenance.
Things done

[x] Fits CONTRIBUTING.md.

nox-review says: “Nothing changed”.
If someone has a better way to compute coq-version, please share it!

It wouldn't be possible for @vbgl to review @vbgl commits, would it?

@vbgl  nix-shell -p nox --run "nox-review wip" should be used before git commit.

nox-review says: “Nothing changed”.

While this is not in checkbox format, I think this implies nox-review has been run.

@jpierre03 this PR does not change any derivation, it changes how said derivations are defined. There is thus no build to check.

authors: jpierre03 rht vbgl


text:
lutris: remove wine dependency

Description of changes
One of the points of Lutris is using its own versions of Wine, the ability to use system Wine is optional. There aren't many reasons why Wine (which is a pretty big dependency) should be here.
If one wants to use system Wine, they could just install it with environment.systemPackages.
It's also absent on both Bottles and Heroic.
(And on Arch it's an optional dependency.)

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I was actually planning on doing that too.

authors: Kranzes SuperSamus


text:
nixos/smokeping: fix smokeping symbolic links

Description of changes
When we reloading the smokeping systemd service, we receive the error message "ln: failed to create symbolic link '/var/lib/smokeping/css/css': Read-only file system", because the preStart section can't recreate symbolic links"
We remove the symbolic links before recreate them

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Hey, thank you for your contribution; can you format your commits according to the CONTRIBUTING guide?

This pull request fix the #228207 issue

Thank you, please format your commits according to the CONTRIBUTING guide: nixos/smokeping: ....

I'm also seeing this breakage after the 23.05 upgrade. ln -sf is dereferencing the target (/css is a directory) and attempting to add a new symlink inside. Changing to ln -snf (adding --no-deference) should be the minimal fix.

 [nixos/smokeping: Fix smokeping preStart systemd script](/NixOS/nixpkgs/pull/227203/commits/99c9a7b15c2dcafd0f40dca062c726f4f7abc643)

Thanks @miangraham , it works like a charm :)

authors: RaitoBezarius badele miangraham


text:
Update mov-cli version to mov-cli: unstable-2022-06-30 -> 1.3.8

Description of changes
Update mov-cli version
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

@Selmer443 please take a look at the contributing guidelines. Your Git commit messages are not correctly formatted.

Result of nixpkgs-review pr 229837 run on x86_64-linux 1

2 packages built:

mov-cli
mov-cli.dist

Does this look good now? Apologies for the delay and improper formatting.

Closing due to no response from OP.

https://github.com/NixOS/nixpkgs/pull/260066


text:
bcompare: 4.4.4.27058 -> 4.4.6.27348 https://www.scootersoftware.com/download/v4changelog

version bump for bcompare

Hi @kpe , thank you for the PR! I've tried to build it now and it works only with version = "4.4.6.27483";

greetings @kpe, thank you for your PR
few things to resolve

please apply suggested changes
squash commits, this is done to aid git bisect
adjust commit message to follow guidelines, this is to allow automatic running of checks for pull requests

otherwise, welcome to the journey !

I tried building with these changes on my local machine and the hash changed again.

bcompare is at 4.4.6.27483 on master, closing.

authors: ckt114 kirillrdy kpe ktor wegank


text:
util-linux: 2.38.1 -> 2.39, add darwin support

Description of changes
The util-linux on darwin is an alias for unixtools.util-linux which
contains Apple's variants of the tools. However, the tools are not
compatible with util-linux; for example the command line options differ
and tools such as sfdisk are not available.
This PR makes util-linux buildable on darwin and removes the alias so
util-linux is util-linux everywhere. To access the Apple tools, use unixtools
(e.g unixtools.util-linux).
The upgrade to 2.39 is required to make building on darwin complete
successfully.
Motivation
I want to build bootable disk images for raspberry pi everywhere, darwin
included. It's a pain to deal with tools (fdisk, sfdisk) that differ according
to build platform.
Also, it seems surprising to get anything else than util-linux when asking
for it.
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This change probably belongs in the release notes, but the notes for 23.11 doesn't exist yet.

Looks like it fails to build on x86_64-darwin. Probably this can be fixed with memstreamHook?

Looks like it fails to build on x86_64-darwin:
$ nix-build -A util-linux --argstr system x86_64-darwin
...
Undefined symbols for architecture x86_64:
  "_open_memstream", referenced from:
      _main in wall-wall.o
ld: symbol(s) not found for architecture x86_64
...

Probably this can be fixed with memstreamHook or darwin.apple_sdk_11_0.callPackage?

Thank you. memstreamHook seemed to do the trick.

I'm running a nixpkgs-review rev HEAD on this PR rebased to master. Thanks for spotting the broken packages and filing PRs for them.

Result of nixpkgs-review run on aarch64-darwin 1

92 packages failed to build:

OVMF
OVMF.fd
bitcoin-abc
bitcoin-unlimited
bitcoind-abc
dogecoin
easyocr (python310Packages.easyocr)
easyocr.dist (python310Packages.easyocr.dist)
edk2
edk2-uefi-shell
eject
halfempty
khoj
khoj.dist
litecoin
nvimpager
ocamlPackages.torch
openai-full
openai-full.dist
pivx
pivxd
python310Packages.arviz
python310Packages.arviz.dist
python310Packages.bambi
python310Packages.bambi.dist
python310Packages.dalle-mini
python310Packages.dalle-mini.dist
python310Packages.elegy
python310Packages.elegy.dist
python310Packages.fastai
python310Packages.fastai.dist
python310Packages.ffcv
python310Packages.ffcv.dist
python310Packages.flammkuchen
python310Packages.flammkuchen.dist
python310Packages.git-annex-adapter
python310Packages.git-annex-adapter.dist
python310Packages.grad-cam
python310Packages.grad-cam.dist
python310Packages.k-diffusion
python310Packages.k-diffusion.dist
python310Packages.langchain
python310Packages.langchain.dist
python310Packages.manifest-ml
python310Packages.manifest-ml.dist
python310Packages.pymanopt
python310Packages.pymanopt.dist
python310Packages.pymc
python310Packages.pymc.dist
python310Packages.pytorch-lightning
python310Packages.pytorch-lightning.dist
python310Packages.pytorch-pfn-extras
python310Packages.pytorch-pfn-extras.dist
python310Packages.pywick
python310Packages.pywick.dist
python310Packages.qiskit
python310Packages.qiskit-machine-learning
python310Packages.qiskit-machine-learning.dist
python310Packages.qiskit.dist
python310Packages.sfepy
python310Packages.sfepy.dist
python310Packages.skorch
python310Packages.skorch.dist
python310Packages.skrl
python310Packages.skrl.dist
python310Packages.slicer
python310Packages.slicer.dist
python310Packages.spacy
python310Packages.spacy-loggers
python310Packages.spacy-loggers.dist
python310Packages.spacy-transformers
python310Packages.spacy-transformers.dist
python310Packages.spacy.dist
python310Packages.stytra
python310Packages.stytra.dist
python310Packages.tensorboardx
python310Packages.tensorboardx.dist
python310Packages.test-tube
python310Packages.test-tube.dist
python310Packages.textacy
python310Packages.textacy.dist
python310Packages.textnets
python310Packages.textnets.dist
python310Packages.treex
python310Packages.treex.dist
python310Packages.wandb
python310Packages.wandb.dist
python311Packages.git-annex-adapter
python311Packages.git-annex-adapter.dist
rmlint
rpi-imager
zcash

132 packages built:

bat-extras.batman
bitcoind-unlimited
calc
cloud-utils
cloud-utils.guest
comical
dogecoind
elasticsearch
elasticsearchPlugins.analysis-icu
elasticsearchPlugins.analysis-kuromoji
elasticsearchPlugins.analysis-phonetic
elasticsearchPlugins.discovery-ec2
elasticsearchPlugins.ingest-attachment
elasticsearchPlugins.repository-gcs
elasticsearchPlugins.repository-s3
elasticsearchPlugins.search-guard
fzf-git-sh
git-quick-stats
git-recent
litecoind
logger
openai-whisper (python310Packages.openai-whisper)
openai-whisper.dist (python310Packages.openai-whisper.dist)
opensearch
openvpn_learnaddress
pianotrans
pianotrans.dist
python310Packages.accelerate
python310Packages.accelerate.dist
python310Packages.apptools
python310Packages.apptools.dist
python310Packages.ax
python310Packages.ax.dist
python310Packages.blosc2
python310Packages.blosc2.dist
python310Packages.botorch
python310Packages.botorch.dist
python310Packages.clean-fid
python310Packages.clean-fid.dist
python310Packages.clip
python310Packages.clip-anytorch
python310Packages.clip-anytorch.dist
python310Packages.clip.dist
python310Packages.deepdish
python310Packages.deepdish.dist
python310Packages.envisage
python310Packages.envisage.dist
python310Packages.ezyrb
python310Packages.ezyrb.dist
python310Packages.gpytorch
python310Packages.gpytorch.dist
python310Packages.ignite
python310Packages.ignite.dist
python310Packages.kornia
python310Packages.kornia.dist
python310Packages.linear_operator
python310Packages.linear_operator.dist
python310Packages.lion-pytorch
python310Packages.lion-pytorch.dist
python310Packages.mayavi
python310Packages.mayavi.dist
python310Packages.monai
python310Packages.monai.dist
python310Packages.nianet
python310Packages.nianet.dist
python310Packages.pandas-stubs
python310Packages.pandas-stubs.dist
python310Packages.peft
python310Packages.peft.dist
python310Packages.piano-transcription-inference
python310Packages.piano-transcription-inference.dist
python310Packages.pydmd
python310Packages.pydmd.dist
python310Packages.pyro-ppl
python310Packages.pyro-ppl.dist
python310Packages.pytorch-metric-learning
python310Packages.pytorch-metric-learning.dist
python310Packages.resize-right
python310Packages.resize-right.dist
python310Packages.rising
python310Packages.rising.dist
python310Packages.safetensors
python310Packages.safetensors.dist
python310Packages.sentence-transformers
python310Packages.sentence-transformers.dist
python310Packages.stanza
python310Packages.stanza.dist
python310Packages.tables
python310Packages.tables.dist
python310Packages.timm
python310Packages.timm.dist
python310Packages.torch (python310Packages.torchWithoutCuda ,python310Packages.torchWithoutRocm)
python310Packages.torch-tb-profiler
python310Packages.torch-tb-profiler.dist
python310Packages.torch.dev (python310Packages.torchWithoutCuda.dev ,python310Packages.torchWithoutRocm.dev)
python310Packages.torch.dist (python310Packages.torchWithoutCuda.dist ,python310Packages.torchWithoutRocm.dist)
python310Packages.torch.lib (python310Packages.torchWithoutCuda.lib ,python310Packages.torchWithoutRocm.lib)
python310Packages.torchaudio
python310Packages.torchaudio.dist
python310Packages.torchdiffeq
python310Packages.torchdiffeq.dist
python310Packages.torchgpipe
python310Packages.torchgpipe.dist
python310Packages.torchinfo
python310Packages.torchinfo.dist
python310Packages.torchlibrosa
python310Packages.torchlibrosa.dist
python310Packages.torchmetrics
python310Packages.torchmetrics.dist
python310Packages.torchsde
python310Packages.torchsde.dist
python310Packages.torchvision
python310Packages.torchvision.dist
python310Packages.ttach
python310Packages.ttach.dist
solanum
stylish
testssl
transcrypt
unixtools.wall
unnethack
util-linux
util-linux.bin
util-linux.dev
util-linux.lib
util-linux.man
util-linuxMinimal
util-linuxMinimal.bin
util-linuxMinimal.dev
util-linuxMinimal.lib
util-linuxMinimal.man
vifm

From a quick review of the build log, I found no packages failing because of util-linux.

Nice. nixpkgs-review 2.9.1 actually has a bug that report false negatives, which has been fixed in https://github.com/Mic92/nixpkgs-review/commit/1e67afb01e3a16bba617c3bb14752797c730a450, so the number of failures isn't surprising.

Result of nixpkgs-review run on aarch64-darwin 1
17 packages marked as broken and skipped:
7 packages failed to build:
37 packages built:

This is the result of nixpkgs-review build from source to include https://github.com/Mic92/nixpkgs-review/commit/1e67afb01e3a16bba617c3bb14752797c730a450,
nixpkgs-review rev --remote https://github.com/eliasnaur/nixpkgs HEAD

where eliasnaur/nixpkgs has its master updated to contain your #233463, the removal of util-linux from pytorch.

Yeah, the Darwin side is good. Someone just needs to take care of the Linux side.

I tried to run nixpkgs-review in a Linux VM, but a nix-env subcommand kept being killed by signal 9. I assume it runs out of memory.

@eliasnaur I have a weekly ~canary test job for resholve that runs on macOS and Ubuntu and intentionally uses util-linux to get at both variants of the script command.
It failed this week because the command's missing now. In my case, using script from unixtools is the right fix for my CI job, but I wanted to go ahead and document how the commands available in the outputs differ in case it helps anyone else or highlights anything that's inadvertently missing.
+--------------+-----------------+-------------------+------------------+
|     cmds     | faux_util_linux | darwin_util_linux | linux_util_linux |
+--------------+-----------------+-------------------+------------------+
| addpart      |                 |                   | addpart          |
| agetty       |                 |                   | agetty           |
| blkdiscard   |                 |                   | blkdiscard       |
| blkid        |                 | blkid             | blkid            |
| blkpr        |                 |                   | blkpr            |
| blkzone      |                 |                   | blkzone          |
| blockdev     |                 |                   | blockdev         |
| cal          |                 | cal               | cal              |
| cfdisk       |                 |                   | cfdisk           |
| chcpu        |                 |                   | chcpu            |
| chfn         |                 |                   | chfn             |
| chmem        |                 |                   | chmem            |
| choom        |                 |                   | choom            |
| chrt         |                 |                   | chrt             |
| chsh         |                 |                   | chsh             |
| col          | col             | col               | col              |
| colcrt       |                 | colcrt            | colcrt           |
| colrm        |                 | colrm             | colrm            |
| column       | column          | column            | column           |
| ctrlaltdel   |                 |                   | ctrlaltdel       |
| delpart      |                 |                   | delpart          |
| dmesg        |                 |                   | dmesg            |
| eject        |                 |                   | eject            |
| fadvise      |                 |                   | fadvise          |
| fallocate    |                 |                   | fallocate        |
| fdisk        | fdisk           | fdisk             | fdisk            |
| fincore      |                 |                   | fincore          |
| findfs       |                 | findfs            | findfs           |
| findmnt      |                 |                   | findmnt          |
| flock        |                 | flock             | flock            |
| fsck         | fsck            |                   | fsck             |
| fsck.cramfs  |                 | fsck.cramfs       | fsck.cramfs      |
| fsck.minix   |                 | fsck.minix        | fsck.minix       |
| fsfreeze     |                 |                   | fsfreeze         |
| fstrim       |                 |                   | fstrim           |
| getopt       | getopt          | getopt            | getopt           |
| hardlink     |                 | hardlink          | hardlink         |
| hexdump      | hexdump         | hexdump           | hexdump          |
| hwclock      |                 |                   | hwclock          |
| i386         |                 |                   | i386             |
| ionice       |                 |                   | ionice           |
| ipcmk        |                 |                   | ipcmk            |
| ipcrm        |                 |                   | ipcrm            |
| ipcs         |                 |                   | ipcs             |
| irqtop       |                 |                   | irqtop           |
| isosize      |                 | isosize           | isosize          |
| kill         |                 |                   | kill             |
| last         |                 |                   | last             |
| lastb        |                 |                   | lastb            |
| ldattach     |                 |                   | ldattach         |
| linux32      |                 |                   | linux32          |
| linux64      |                 |                   | linux64          |
| logger       |                 | logger            | logger           |
| login        |                 |                   | login            |
| look         |                 | look              | look             |
| losetup      |                 |                   | losetup          |
| lsblk        |                 |                   | lsblk            |
| lscpu        |                 |                   | lscpu            |
| lsfd         |                 |                   | lsfd             |
| lsipc        |                 |                   | lsipc            |
| lsirq        |                 |                   | lsirq            |
| lslocks      |                 |                   | lslocks          |
| lslogins     |                 |                   | lslogins         |
| lsmem        |                 |                   | lsmem            |
| lsns         |                 |                   | lsns             |
| mcookie      |                 | mcookie           | mcookie          |
| mesg         |                 | mesg              | mesg             |
| mkfs         |                 | mkfs              | mkfs             |
| mkfs.bfs     |                 | mkfs.bfs          | mkfs.bfs         |
| mkfs.cramfs  |                 | mkfs.cramfs       | mkfs.cramfs      |
| mkfs.minix   |                 | mkfs.minix        | mkfs.minix       |
| mkswap       |                 | mkswap            | mkswap           |
| more         |                 |                   | more             |
| mount        | mount           |                   | mount            |
| mountpoint   |                 |                   | mountpoint       |
| namei        |                 | namei             | namei            |
| nologin      |                 | nologin           | nologin          |
| nsenter      |                 |                   | nsenter          |
| partx        |                 |                   | partx            |
| pipesz       |                 |                   | pipesz           |
| pivot_root   |                 |                   | pivot_root       |
| prlimit      |                 |                   | prlimit          |
| readprofile  |                 |                   | readprofile      |
| rename       |                 | rename            | rename           |
| renice       |                 | renice            | renice           |
| resizepart   |                 |                   | resizepart       |
| rev          |                 | rev               | rev              |
| rfkill       |                 |                   | rfkill           |
| rtcwake      |                 |                   | rtcwake          |
| runuser      |                 |                   | runuser          |
| script       | script          |                   | script           |
| scriptlive   |                 |                   | scriptlive       |
| scriptreplay |                 | scriptreplay      | scriptreplay     |
| setarch      |                 |                   | setarch          |
| setpriv      |                 |                   | setpriv          |
| setsid       |                 | setsid            | setsid           |
| setterm      |                 |                   | setterm          |
| sfdisk       |                 | sfdisk            | sfdisk           |
| sulogin      |                 |                   | sulogin          |
| swaplabel    |                 | swaplabel         | swaplabel        |
| swapoff      |                 |                   | swapoff          |
| swapon       |                 |                   | swapon           |
| switch_root  |                 |                   | switch_root      |
| taskset      |                 |                   | taskset          |
| uclampset    |                 |                   | uclampset        |
| ul           |                 | ul                | ul               |
| umount       | umount          |                   | umount           |
| uname26      |                 |                   | uname26          |
| unshare      |                 |                   | unshare          |
| utmpdump     |                 |                   | utmpdump         |
| uuidd        |                 |                   | uuidd            |
| uuidgen      |                 | uuidgen           | uuidgen          |
| uuidparse    |                 | uuidparse         | uuidparse        |
| waitpid      |                 |                   | waitpid          |
| wall         |                 | wall              | wall             |
| wdctl        |                 |                   | wdctl            |
| whereis      | whereis         | whereis           | whereis          |
| wipefs       |                 | wipefs            | wipefs           |
| write        | write           |                   | write            |
| x86_64       |                 |                   | x86_64           |
| zramctl      |                 |                   | zramctl          |
+--------------+-----------------+-------------------+------------------+

The first "cmds" column is a distinct union of each /bin dir just to prove to myself that the old macOS alias didn't have any commands that weren't present in util-linux on linux.
The commands that were present on macOS using the alias but not present in true util-linux on macOS are: fsck, mount, script, umount, and write

authors: abathur eliasnaur wegank


text:
haskellPackages: dontCheck implicit due to flaky tests

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This is likely due to QuickCheck-2.14.3…

authors: sorki sternenseemann


text:
jetbrains: fix application icon

My Desktop doesn't recognize the icon in ~/.local/share/pixmaps which is how the icon would have to be found when doing a user profile install. For me, it's hard to find information on this, but it seems like share/pixmaps is something old and the share/icons location should be used instead:

https://www.reddit.com/r/linuxquestions/comments/htg6c/comment/c1yfi0a/
https://github.com/spyder-ide/spyder/issues/6188
https://github.com/FreeSpacenav/spnavcfg/issues/9

In this PR we add the icons location so that both are available for compatibility. From what I could find, all other packages in here, add their icons to the hicolor theme and it's working just fine :shrug:
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 239416 run on x86_64-linux 1

14 packages built:

jetbrains.clion
jetbrains.datagrip
jetbrains.dataspell
jetbrains.gateway
jetbrains.goland
jetbrains.idea-community
jetbrains.idea-ultimate
jetbrains.mps
jetbrains.phpstorm
jetbrains.pycharm-community
jetbrains.pycharm-professional
jetbrains.rider
jetbrains.ruby-mine
jetbrains.webstorm


text:
iana-etc: 2.30 -> 20170317

Motivation for this change
builds on #23621
Uses new upstream repo to get iana protocols as the previous one is unmaintained.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Fits CONTRIBUTING.md.

https://github.com/NixOS/nixpkgs/pull/23621 There is a newer PR now

no, my one is newer and does things different.

Oh ok just seen version
Sent from my iphone
On Mar 19, 2017, 2:52 PM -0500, Jörg Thalheim notifications@github.com, wrote:

no, my one is newer and does things different.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub (https://github.com/NixOS/nixpkgs/pull/24053#issuecomment-287642441), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL79I0-CteCpcGL31pIietn5WoK7hnks5rnYdogaJpZM4Mhtj5).

This is a bloated answer to a simple problem.

a 200LOC Python script running on TravisCI is fancy but pointless to a task that boils down to parsing a flat file.
maybe there is no need to ship both XML and processed files in your releases since the XML won't be installed in the store
your processed files contains duplicated entries :

subntbcst-tftp   247/tcp    # SUBNTBCST_TFTP
subntbcst_tftp   247/tcp    # SUBNTBCST_TFTP
subntbcst-tftp   247/udp    # SUBNTBCST_TFTP
subntbcst_tftp   247/udp    # SUBNTBCST_TFTP
[...]
redstorm-join    2346/tcp   # Game Connection Port
redstorm_join    2346/tcp   # Game Connection Port
redstorm-join    2346/udp   # Game Connection Port
redstorm_join    2346/udp   # Game Connection Port
redstorm-find    2347/tcp   # Game Announcement and Location
redstorm_find    2347/tcp   # Game Announcement and Location
redstorm-find    2347/udp   # Game Announcement and Location
redstorm_find    2347/udp   # Game Announcement and Location
redstorm-info    2348/tcp   # Information to query for game status
redstorm_info    2348/tcp   # Information to query for game status
redstorm-info    2348/udp   # Information to query for game status
redstorm_info    2348/udp   # Information to query for game status
redstorm-diag    2349/tcp   # Diagnostics Port
redstorm_diag    2349/tcp   # Diagnostics Port
redstorm-diag    2349/udp   # Diagnostics Port
redstorm_diag    2349/udp   # Diagnostics Port
[...]
mapper-nodemgr   3984/tcp   # MAPPER network node manager
mapper-nodemgr   3984/udp   # MAPPER network node manager
mapper-mapethd   3985/tcp   # MAPPER TCP/IP server
mapper-mapethd   3985/udp   # MAPPER TCP/IP server
mapper-ws-ethd   3986/tcp   # MAPPER workstation server
mapper-ws_ethd   3986/tcp   # MAPPER workstation server
mapper-ws-ethd   3986/udp   # MAPPER workstation server
mapper-ws_ethd   3986/udp   # MAPPER workstation server

It does not install xml into the nix store.
Duplicate entries are fixed.
This pull request does not contain python code, just data.

This looks good to me. It seems preferable over #23621, which adds a 120 Kloc source file (https://github.com/NixOS/nixpkgs/pull/23621/files#diff-07b8b5731748622cee5bb9a2f6a73bd3) to the repository.

@edolstra No the original proposition of #23621 is to fetch content directly from IANA website and not rely on a third-party to provide a system file.
It has been re-updated just now in that sense. Also now it will always fetch the most up-to-date content from IANA, which means it would continuously make reliable etc files without the need to regularly update a hash in the Nix definition of iana-etc

@c0bw3b That's impure though. In Nix, you cannot have packages that fetch the latest version from upstream. Otherwise you could have two systems built from identical Nixpkgs, where one fails because it has an outdated version of /etc/services and the other succeeds. That violates the reproducibility goals.

:+1: for getting one of these two PR's merged!
Turns out, after lots of debugging, our outdated /etc/protocols is behind the problems I'm experiencing with mono as part of #24093 (!!).  I wouldn't be surprised if other things were similarly broken in confounding ways-- it turns out that with our current /etc/protocols, looking up "ip" protocol yields '4' (ipip/ipencaps) instead of '0'.  If it's not problematic this might be worth getting into 17.03 O:).

FWIW locally I just grabbed the files from debian's "netbase": https://packages.debian.org/sid/netbase (git source repo: https://anonscm.debian.org/cgit/users/md/netbase.git/tree/) which might be a reasonable source for the data.

@dtzWill Debians' netbase is not complete enough. They handpick and add only what they think is useful.
FreeBSD files are more complete but a little messy.
Arch package is both complete and up-to-date.
At least this PR provides updated content now.
But relying on one external source to provide some system files is what has been done with the previous package. And it has proven unreliable over time.


text:
nixos/kanidm: add package option

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Incomplete copy of #219700.

authors: Kranzes mweinelt


text:
CuboCore.corerenamer: 4.4.0 -> 4.5.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/corerenamer/versions.
meta.description for CuboCore.corerenamer is: A batch file renamer from the C Suite
meta.homepage for CuboCore.corerenamer is: https://gitlab.com/cubocore/coreapps/corerenamer
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.5.0 with grep in /nix/store/jajsgwsc6m8398iw66lwhgbayjmd9sq3-corerenamer-4.5.0
found 4.5.0 in filename of file in /nix/store/jajsgwsc6m8398iw66lwhgbayjmd9sq3-corerenamer-4.5.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
CuboCore.corerenamer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jajsgwsc6m8398iw66lwhgbayjmd9sq3-corerenamer-4.5.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A CuboCore.corerenamer https://github.com/r-ryantm/nixpkgs/archive/76ba15ed45e4694155beb12dec915b41ca26d317.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jajsgwsc6m8398iw66lwhgbayjmd9sq3-corerenamer-4.5.0
ls -la /nix/store/jajsgwsc6m8398iw66lwhgbayjmd9sq3-corerenamer-4.5.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

CuboCore.corerenamer

Maintainer pings
cc @dan4ik605743 for testing.

Superseded by #256719.

authors: r-ryantm wegank


text:
trufflehog: 3.56.0 -> 3.56.1

Diff: https://github.com/trufflesecurity/trufflehog/compare/refs/tags/v3.56.0...v3.56.1
Changelog: https://github.com/trufflesecurity/trufflehog/releases/tag/v3.56.1
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 255428 run on x86_64-linux 1

1 package built:

trufflehog


text:
sic-image-cli: 0.22.3 -> 0.22.4

Diff: https://github.com/foresterre/sic/compare/v0.22.3...v0.22.4
Changelog: https://github.com/foresterre/sic/blob/v0.22.4/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 255559 run on x86_64-linux 1

1 package built:

sic-image-cli

authors: fabianhjr figsoda


text:
todoman: apply upstream patch

Description of changes
urwid had some breaking changes and this
disables one test in todoman to make it work
with urwid again.
See https://github.com/pimutils/todoman/issues/537
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Why did you choose to fetch the upstream patch instead of disabling the test via nix? Adding "test_ctrl_c_clears" to disabledTests would have basically the same outcome, wouldn't it? That seems like a easier option.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 262760 run on x86_64-linux 1

2 packages built:

todoman
todoman.dist

Why did you choose to fetch the upstream patch instead of disabling the test via nix? Adding "test_ctrl_c_clears" to disabledTests would have basically the same outcome, wouldn't it? That seems like a easier option.

This would also be a viable option. I guess both can work.
Using fetchpatch indicates upstream is aware of the issue and the test is "officially" deactivated for now by upstream.

authors: antonmosich gador


text:
doc: show how to use manual linux kernel configs

Description of changes
The documentation on the linux kernel focused on using and extending kernels that were already packaged, but never mentioned that it's possible to also build a kernel almost "from scratch".
This PR gives a starting point on how to do these specialised kernel builds.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Partly mentioned here, near the end of that chapter. Possibly cross linking  between the article could be a good idea, so that it's easier to find, but on my opinion the explaination (which is also not super clear covered in the other part of the doc) fits more on how to configure, than how the builder should be documented.

Thanks for the review! I hadn't even seen that section on the NixOS documentation, partly because I'm not doing this for a NixOS system, but rather for a micro VM. This is what led me to creating this PR: most of the documentation on the kernel builder seems very NixOS-specific, but there are other valid reasons to build a kernel.
Given what I said above, I believe this documentation fits Nixpkg's documentation way more than NixOS's. The kernels built manually are very likely not intended to be used in NixOS, so I don't see why this should be seen as how to configure the kernel. The manual config kernel builder is almost an entirely different builder given how much pkgs.buildLinux adds on top of pkgs.linuxManualConfig.
What do you think, @Shawn8901 ? I'm leaning towards merging the information from NixOS's docs in this PR to consolidate details on the manual kernel build, and add a link on NixOS's docs to Nixpkg's section on manual kernel builds.

Just went through a lot of issues on the repo looking for more data on use cases, and found:

#234084 with a similar use case to mine (kernel used without NixOS)
#178476 using the custom kernel in NixOS
#216529 also using the custom kernel in NixOS

I still stand by the opinion that the pkgs.linuxManualConfig docs should be in Nixpkgs, but perhaps there should be a bit more to document on the NixOS side regarding kernel features and kernel packages specifically with pkgs.linuxManualConfig.

I am totally fine with moving either and have no preference, which fits more, but possibly that question can be answered by someone of the documentation team (I am just a random person from the internet 🙂 ). I was just mentioning the other place, as i was kind of involved in one of them (the history of the second issue that you have linked, and their other linked issues, is the source of that), but would personally prefer to have one good doc for that, than have it split and to maintain basically the same content in multiple places, as the usecase overall is already kind of more rarely used, so we don't have many eyes on it, that use it regularly.

@fricklerhandwerk , sorry for the ping, bit from discourse I read often your name in relation to docs. :)
I am asking myself if the mentioned problem (or at least my problem) will go away, with all the work of nix.dev? Or are there any opinions about the docs of How to custom compilate kernels?
For me the argument, that it's not a NixOS-only use case totally make sense, so that people may not peek into the nixos docs.

@Shawn8901 thanks for the ping. I don't subscribe to Nixpkgs activities notifications as that gets out of hand quickly. For feedback on documentation, feel free to ping the @NixOS/documentation-team as these are multiple people, who'll be aware of the issue and then be able to quickly discuss it in place or in one of our meetings that happen twice a week.
I agree with you and @DanielSidhion that all the build-related docs should go into Nixpkgs, so merging them here is good. Thanks a lot for helping out! (Or as we tend to say in the docs team: taking a shovel)
Ping me again if you would like to receive and have the time to process a review pass on style and wording. I think it's not required here because the existing docs are okay, and just merging them is already a strong improvement. If you're motivated you can always do a follow-up to improve the text, following the Nix manual documentation style guide (the details on docBook, syntax, and the @docroot@ thing are specific to Nix and don't apply to Nixpkgs).

Thank you for all the discussion folks! @fricklerhandwerk I'm going ahead and requesting a review from you since I decided to change the structure of the text a bit. The how-to on adding a new kernel version feels a bit out of place, let me know if you think a specific section for that would be more appropriate.


text:
nixos/borgbackup: add listOf str types to extraArgs

Description of changes

This PR adds type a coerced listOf str type to all of borgbackups extraArgs, so that it more closely matches the types of many other extraArgs options. It should be completely backwards compatible. The nixos test seems to work fine.

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@bjornfor Maybe this is ready for merge?