text:
telemetry config and runtime directory mode bugfixes

Description
Without this change the telemetry configuration appears to have been affected by a copy and paste error and receives the seal configuration instead.
Without this change the runtime directory (/var/run/vault) is set by chef with mode 0740, then set by systemd to the default RuntimeDirectoryMode of 0755 when Vault is started.
Issues Resolved
No github issues exist for these bugs.
Check List

[ ] All tests pass. See TESTING.md for details.

Not sure how to run the test suite, but this doesn't touch anything that's currently covered by the test suite so it shouldn't break tests.

[ ] New functionality includes testing.

Does not provide new functionality, just fixes minor bugs.

[ ] New functionality has been documented in the README if applicable.

Not applicable.

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

  Generated by :no_entry_sign: Danger

Can you pop in a changelog please @mmickan and then we can get this merged and released?

authors: Xorima kitchen-porter mmickan

repo: sous-chefs/vault


text:
[HTTP 500] SNAT Port Exhaustion issue for JS Application services

Description
We've been experiencing some issues related to SNAT port exhaustion within the application services when running functional tests for the different Botframework SDK tools . These tests are the SkillFunctionalTests from the Botframework-FunctionalTests repository which run every night on our pipelines.
Specifically for JS tests, it seems that the SNAT port usage is exceeding the limit, so this "port exhaustion" problem comes up.
We received an email with a detail of the specific resources causing this kind of issues and some guidance on a few options to solve them:

Here you can also see the current SNAT connections status for the JS Application Services:

Possible solution
After making some research, we found a suggestion from Azure within the same view where the SNAT connections are, that proposed adding a Regional Virtual Network with service or private endpoints for routing all of the outbound traffic into a Virtual Network.
For us, creating this resource and connecting it to our application services worked successfully, considerably reducing the use of the SNAT ports.
The creation of a VNET worked because we had source and destination within Azure. If you route the traffic outside of Azure, SNAT comes into play and provides you with 128 ports for HTTP communication. These ports can be auto-provisioned by Azure (in batches of 128 additional ports), but this auto-provisioning is not instantaneous and some connections might be lost.
When routing the traffic inside Azure with VNET you gain access to all ports available in the running OS (65.000+) which gave us a boost in network resources efficiency decreasing port usage peaks from 240 to les than 30 and a median of just 7 ports against 50 that we where having.
Virtual network resources

Here you can also see how these fixes resulted to us, reducing the the SNAT port connections to an average of 10.

Maybe we should add a little context at the beginning, adding a link to the functional tests repo, and explaining the kind of tests we are doing there.
Also, I think we should say that implementing VNET solved the issue for us.

Maybe we should add a little context at the beginning, adding a link to the functional tests repo, and explaining the kind of tests we are doing there.
Also, I think we should say that implementing VNET solved the issue for us.

+1

I would add more details here on how we created it (pictures of resources required in Azure). How we added these new resources to our currently existing pipelines and the results of said changes. Going from peaks of 240 ports required with an average of 50 to peaks of 20 (I think) and averages of 7.

I'd also add an explanation of the issue we were having, the symptoms and how it turned out after the fix. Something like:
The creation of a VNET worked for us because we had source and destination within Azure. If you route the traffic outside of Azure, SNAT comes into play and provides you with 128 ports for HTTP communication. These ports can be auto-provisioned by Azure (in batches of 128 additional ports), but this auto-provisioning is not instantaneous and some connections might be lost.
When routing the traffic inside Azure with VNET you gain access to all ports available in the running OS (65.000+) which gave us a boost in network resources efficiency decreasing port usage peaks from 240 to les than 30 and a median of just 7 ports against 50 that we where having.

Should we add some text saying why are we creating the issue? Something like ``We are creating the issue to track this behavior in case anyone faces a similar situation`.
If not, it may sound that we are expecting a solution.

Promoted to MS in # 3777

source: gharchive/issue

authors: GiulianoDolceTalianoSantoro MartinLuccanera ceciliaavila santgr11 sw-joelmut

repo: southworks/botbuilder-js

license: MIT

license_type: permissive

license_source: github-api


text:
[MVC] Move 'BookingDetails' to 'Models' folder in Sample #13 - Basic Bot

Proposed Changes

Create a folder named Models to contain the model classes

Note: We created this PR against samples-work-in-progress because here is where we reviewed the sample. On the other hand, we noticed these changes are also merged in 4.3/js/core branch.
Let us know if we should rebase this PR.
Testing
This modification does not change the code logic

@GasparAcevedoZainSouthworks The branch has been rebased and the PR was modified to be against samples-work-in-progress. Please review again.

Promoted to MS # 1332

source: gharchive/pull-request

repo: southworkscom/BotBuilder-Samples


text:
[bug] library crashing for cpp code block

a cpp code block:

Error:

Tested the stuff locally. Everything looks fine:

Even the generated markdown is being rendered properly as you can see in the image. The problem is not with notion-to-md it's maybe an issue related to the markdown parser you are using. (MDX in this case I believe)

Closing the issue, cannot recreate the issues.

authors: GorvGoyl souvikinator

repo: souvikinator/notion-to-md


text:
🛑 Media Control is down

In 5c62335, Media Control ($SITE_6) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Media Control is back up in 4b705fc.

repo: soxfor/upptime


text:
[Maps] Astra Update

:cl: Resoid

tweak: Включены гирлянды на Astra

изменения карт в кл не пишем

изменения карт в кл не пишем

привет, пашол нахуй


text:
Adds Netstandard2.1 support.

Adds Netstandard2.1 support.
Allows a wider range of usage such as Unity 2018 and Xamarin projects.
If possible it would be neat to update the Nuget like previously.

I am not sure this is worth the hassle. NS2.1 is already getting dated, and there are some useful future features (e.g. SNI support) that this would make impossible. I'm also not fond of the amount of extra code this adds to maintain.


text:
Change wall layers.

Right now walls are drawn above mobs because...???
Should be fixed so they're below mobs like airlocks are.

Pushed a fix on RobustToolbox for this issue.

Fixed in the past.

authors: Acruid PJB3005 tentekal


text:
Zookeeper needs own access

Description
Zookeeper should get zookeeper access to make their zoos more secure and unable to be loosed by the chef or janitor, the janitor shouldn't be able to waltz into botany and fuck up their setup (as they can on Cluster station), and so on
Reproduction

be zookeeper on oasis
your average service worker walks in
looses all animals cause they're curious

Screenshots

Additional context
I know that currently zookeeper isnt an available in main maps but it still was annoying when Oasis was set up on mander the other night

if @Emisse approve, ill fo it

Zookeeper is a station-specific role so that needs a way to hide the access when not using that role, the issue with Cluster is a mapping issue.

Moving the Cluster issue to https://github.com/space-wizards/space-station-14/issues/26396

I agree it needs its own access, with service access, the most restrictive one the zookeeper currently gets, too many people can accidentally (or intentionally) release the animals ruining zookeeper fun.

any word on if this can be completed?


text:
MAP_MARATHON: Materials room is locked behind captain door

Core has it so anyone can access the material room

Certain maps have it accessed by anyone other have it accessed by command, I don't think there's any convention as to which it actually should be.

A convention should be made then

I agree I just meant this isn't an issue specific to Marathon

this is because its a drone room, drone rooms just need converting into materials rooms

this issue is fixed

authors: BackeTako Brandon-Huu Emisse JustCone14


text:
do_after user / target thresholds should be nullable floats instead of bools

Title.

Also related is https://github.com/space-wizards/space-station-14/pull/16670 do_after movement cancelling is significantly more overcomplicated than it should be.


text:
revive saltern

About the PR
bring best map up to scratch:

research assistant exists (no spawn yet TODO)
add arrivals shuttle support (i hope)
add 2 escape pods
add an anomaly room
convert toxins to xenoarch and actually have gases in it (how was it meant to be toxins???)
add spare id card in cap office
faxes!!!
mail!!!
clean up the sanctuary thing, add floppa and zookeeper as pets
soup sensor server in cmo room
telecomms outside the conference room
remove ninja shoes
skub
atmosian plushie!!!
TBD

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
:cl:

add: Added fun!

holy shit saltern based???? (I am not biased)

saltern 3

who made saltern i wonder

We need to revive knightship next tbh

so slight issue there is z fighting with the overlapping conveyors, i want to retain the functionality of being able to use either recycler or reclaimer but is there a way to have one conveyor always draw over the other? it looks horrible when moving

i still need to do robotics and i dunno if there are unmainted lowpop maps that need replacing

on review, found a few things that should probably be fixed

missing disposal turn for mail into science

disposals going through walls is a bit iffy but that might be a relic of the old map
observatory still doesn't have power, might want to wire it up if you're going to have a job spawn there
you can't mail stuff from bridge to anywhere else except for hop due to how disposals works
mailing router for bridge/hop isn't tagged

also you'd probably need emisse's input on what map gets derotated, moose is currently unmaintained atm i think
aside from all of that, looks good to me

emisse said moose or omega and moose is being actively tweaked
ill fix the issues you found, thanks

added r&d console to robor room:

brigmed saving poor urist with defib (also at med and other places):

floppa room now powered:

bridge and hop mail are now part of the main loop:

also fixed the sci mail bend, added some more maint goodies and removed unneeded maint lights


text:
Remove handheld crew monitor

It's supposed to be a CMO computer.
It's getting powercrept and added everywhere.

I don't care much about the syndie but it baits people into shoving it into NT again.
Also I just found out there's massive copy-paste in head lockers so woopy.
(Discussed on discord).
:cl:

remove: Remove handheld crew monitors in lieu of computers.

Would it not be better to remove from tech instead and mark as objective? If its tech it makes sense paramedics every now and then get it, especially when medical can print them, albeit they cost a good chunk of materials.

Would it not be better to remove from tech instead and mark as objective? If its tech it makes sense paramedics every now and then get it, especially when medical can print them, albeit they cost a good chunk of materials.

Actually yeah, it could be tried as an objective, like the QM's digiboard, for instance.

Restricting + stealing a CM board is better as an objective than any number of pre-mapped handheld CMs.

So, crew monitor will be only in CMO office now? I do not envy paramedics unless its going to be special kind of monitor even if functionally same to the ones you can get from cargo for 2k.

I dont believe Origin has a crew monitor computer, though there is a board that spawns in maints.

Why not leave it as a researchable thing? It would make science more useful...why do we ever remove anything instead of adding something new?

I guess we need a disscussion label, i mean this notable change need to be discussion before implemeting, because it will hit a lot of stones in a water:

Rotting round remove, a lot of crew died in maints due of spacing, a lot of bodies,  under the shadow, paramed without monitor will not see the others bodies around.

People are evil, will just put clothes on dead monkeys to troll parameds to save someone, but instead they spending time to see this trolling.

Body could just be moved by shitters from a to b, that also spend paramedic time.

In conclusion parameds will just use crew monitor console as "portable" one, now this would be a bit out of character situation, yikes.

It seems to me a dubious decision. Anyone who is afraid of being found simply turns off the sensors. If it gets in the way, just remove the prescription from the technology, as before it will be the only one for the entire station, at the CMO or at the paramedic.

I think this change is too damaging to parameds, their job is already hard enough with most people not having coords on and them not having a mobile crew monitor will make it even harder. If you really want to remove it make it researchable by science or unmap it and put it into parameds locker/bag. Or maybe make a new item that isn't as strong? like maybe a special hud made for parameds which highlights crit people (with coords) with an arrow pointing to them or something.

billions must rot :trollface:

Also, my next sentence will be offtopic, but in another way it will be related on topic.
Powergaming and powegamers are not valid argument to these kind prs. I know that no one can teach people to not doing that stuff, but turning game into a "pillow room" because people are doing people stuff out of control, is not a variable answer. Deleting stuff that people over-using it, will not make anything good.
There is no variable option to fix powergaming, only co-exist with it. Cause powergaming is somehow but a dna of the space station.
I said my word about it.
But to stay in topic, so what about to add crew monitor as app in paramed and cmo pdas, hope there will be not a pesky powegamers, whom will beat to death crewmates to get it :trollface:

If you want something handheld pr a significantly nerfed version instead of free portable roundstart maphacks for all non-antags.

i understand why would you remove the roundstart monitor, but why remove it from the syndicate observation kit, making it pretty much useless, and from biochem tech? biochem is already research-starved and i don't think this is a good decision

biochem is already research-starved and i don't think this is a good decision

We don't add content for the sake of content as that's just unnecessary tech debt.

but why remove it from the syndicate observation kit

I'm going to remove the kit.

Now these will bring another type of question:
Why you anyway waited it for 6 hours, if you could just self-merge it from start?
Why you imade it in first place, if you ignored people?
These is kinda rude behavior imho, cause people brought thoughts and ideas to not just straight deleting it... it feels like that getting betrayed.

Why you anyway waited it for 6 hours, if you could just self-merge it from start?
Why you imade it in first place, if you ignored people?

I talked about it on discord with other maintainers. Once talking was done it got merged but more talking can also happen later as that's how development goes.

This is a sad day for all paramedics and rotting people. Can't wait to die in maints, wait 15 minutes and never be found.

This is a sad day for all paramedics and rotting people. Can't wait to die in maints, wait 15 minutes and never be found.

me when the medical team have absolute zero social skill and can't keep watch on the stupid monitor and guide me to the soon rotting captain

This change will most definitely be a positive change for parameds, right?

We don't add content for the sake of content as that's just unnecessary tech debt.

Highly disagree. The one thing space station needs the most is more random events and more content


text:
Adding a simple Wooden Closet

About the PR

Basically just added wooden cabinet without lock on it
Why / Balance

It will really look cool as a part of interior and even cooler without those locks on it
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

add: Wooden closet without lock

can you make it a wardrobe instead?

can you make it a wardrobe instead?

Maybe.

The lock looks like it was poorly erased, tg has regular wardrobe sprites

The lock looks like it was poorly erased, tg has regular wardrobe sprites

Because there's no sprite change, it just reuses the texture of the lockable one.

authors: Agoichi Hrosts UbaserB potato1234x


text:
fix(shiva): Shiva can no longer pry open bolted doors

About the PR

Removed the ability for shiva to pry open bolted doors.
Why / Balance

Fixes #27087

Technical details

Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

Closed until I finish my PHD. Thesis


text:
fix the bigest news admin notification typo in the game

typo

Real

best admintooling PR I have seen in a good while 👏


text:
Bartending Content & Bug Fixes

Adding Bartending Content and bug fixes
Partially Fixes  #818
I've added several new reagents, drinks, recipes, and items for bartending
Added said items to the right place, such as booze-o-mat in the case of bottles and cartons
Attempted to alphabetize YML files and clean them up
Fixed empty bottles in the spawn menu as well as the booze-o-mat
Fixed the size of some drink container objects to be on par with most ss13 forks
Changed Thirteen Loko and its sprite to a more fitting Fourteen Loko
Screenshots

Changelog
:cl: Daemon

tweak: Changed Thirteen Loko to Fourteen Loko
fix: Fixed some bottles in booze-o-mat and admin spawn panel being empty
add: Added various new reagents for bartending and added them to dispensers and vending machines
add: Added many new craft-able mixed drinks, experiment to find out!

Alright I'm good to go for another check on this

Typos are the bane of my existence

you can run yaml linter locally

I figured I could, but was unable to figure out how

dotnet cli - dotnet run Content.YAMLLinter
rider/vs - right click on the project and click run

authors: ZeroDayDaemon mirrorcult


text:
feat: expose Grumpkin commitment computation (PROOF-882)

Rationale for this change
The blitzar-sys crate has the ability to compute commitments with grumpkin elements. This work exposes that capability from the blitzar crate.
What changes are included in this PR?

Added compute_grumpkin_uncompressed_commitments_with_generators and tests.
Added documentation to support grumpkin commitment computation.
Fix documentation error in bn254 commitment computation doc.
Updated the commands to run examples in the examples document.
Documentation is updated to show we now support grumpkin commitment computation.

Are these changes tested?
Yes

:tada: This PR is included in version 4.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

authors: SxT-Release jacobtrombetta

repo: spaceandtimelabs/blitzar-rs


text:
investigate partition test failure

Description
this failure https://github.com/spacemeshos/go-spacemesh/actions/runs/4300663720/jobs/7497080392
is from this PR https://github.com/spacemeshos/go-spacemesh/pull/4105
namespace test-havd
the PR should not impact tortoise. same partition-50-50 test was run in systemtest nodepool 5 times in a row and passed.
tortoise from two sides disagreed on layer 16. i checked boot-0-0 and boot-1-0, they received the same amount of ballots (869 of them)

so far i don't see any bug in the tortoise. maybe it will be worth talking about beacon<>self-healing interaction, it doesn't seem to be nice.
block was generated at layer 16 on one side of the partition (boot-1-0 side):

that side voted for it and confirmed it early

based on the beacon value partition lasted starting at from layer 20 till layer 30. logs are a bit verbose, but here they are ballot has different beacon logs
we delay counting ballots with different beacons to prevent concentration of the weight, therefore nodes on the side of the boot-0-0 are voting against the block, during the time while partition lasts.
later when there is no difference in beacon partition on the side of boot-0-0 seems to terminate the same way as boot-1-0 side.

so i don't see anything bug-like, but the protocol behavior doesn't seem to be good in this case. will have to ask Tal probably

beacons

@countvonzero would it make sense to tune the duration of the partition? based on the logs it lasted for 3 epochs, maybe with 1-2 recovery will be faster

this kind of failures are close to undebugable for me. it is possible to make some guesses but they still don't make complete sense. i think i will need some tracing capabilities to replay events as they are received

it seems stable after reducing ballot delay value? i will close the issue for now

authors: countvonzero dshulyak

repo: spacemeshos/go-spacemesh


text:
Combine logic of two GHA workflows

Motivation
Closes #2344
Changes
Combines logic of two workflows: short-circuits all tests when only markdown files are modified
Test Plan
N/A
TODO

[x] Explain motivation or link existing issue(s)
[ ] Update documentation as needed

DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

See #2361 for a (successful) test of the markdown-only logic: https://github.com/spacemeshos/go-spacemesh/pull/2361/checks?check_run_id=2250040019

bors merge


text:
fix malfeasance proof metrics and add logging

Motivation

part of #4067

Changes

malfeasance proof: only update metrics when save is successful
add more logging to malfeasance proof upon generation and reception
make atx handler uses just 1 mutex, not 2
rename all miner_id, atx_node_id, sender_Id logging field to just smesher
fix benchmark tests in atx handler

bors try

bors try

bors merge

bors merge


text:
Proving opts metrics

Motivation
Add public metrics with smeshing proving opts - nonces and threads.

bors merge


text:
doc: improve systest dir readme

Motivation
Some info is missing from the readme. Adding it for posterity.

Description
...

Test Plan

TODO

[ ] Explain motivation or link existing issue(s)
[ ] Test changes and document test plan
[ ] Update documentation as needed
[ ] Update changelog as needed

bors merge

bors merge


text:
Compatibility with Smapp wallets

Repro: Restore a smapp wallet using 12 words secret phrase by creating a new wallet in providing mnemonic input.
Result: first account has different address than Smapp's first account.
Expected: same first account address to be created.

@DaveAppleton - it will be great if you can have a look at his.

repo: spacemeshos/smrepl


text:
Consider using importlib.resources for schema files

This is new in Python 3.7, but has been backported. See here for details.

After considering this for a while, I think it would be needlessly complicated and would change something that doesn't need fixing. It would also make writing extensions more difficult.
A better use case for this is test data files, as seen in #517.
I'm willing to reopen this if someone convinces me that this approach would actually provide value.

repo: spacetelescope/asdf


text:
Need a new asdf release

Hello! astropy is doing a campaign to clean up test warnings for v4.0 (see astropy/astropy#7928 and related PRs). Unfortunately, a number of them are caused by asdf due to astropy.io.misc.asdf tests. It seems like the tests need a YAML file that is not in your released version (2.4.2) but is in dev. Can you please make a new release soon? We are grabbing asdf from PyPI.
cc @astrofrog

I see the warnings here:
https://travis-ci.org/astropy/astropy/jobs/609284637#L1821

As discussed offline the best way to handle these atthe moment is to xskip them conditionally on the version of asdf. It's generally a chicken and egg problem where new schemas go in asdf and the corresponding tags go in astropy. There's no straightforward way to resolve it.

authors: jdavies-st nden pllim


text:
Fix bug that caused serialized FITS tables to be duplicated

This fixes #404. The bug occurred specifically in the case where the ASDF file was embedded inside an HDU in a FITS file.

Coverage increased (+0.002%) to 95.162% when pulling 1fc1294abab0852f2a59edcfe99bc5aa270b1964 on drdavella:fix-fits-table into e8e57d2faa45b186ec13126a1d4d94c97d7357ce on spacetelescope:master.

The change to fits_embed.py fixes the binary table duplication problem in my test case.

authors: bernie-simon coveralls drdavella


text:
Add upsert operation to SQL databases

The problem faced currently?
There is no upsert functionality for sql databases.
How can we solve it?
Let's add an upsert operation similar to mongo.

If you want this feature to be implemented, give it a thumbs up reaction, so that we can determine which features are important to you.
👍

Resolved in v0.11.0

repo: spaceuptech/space-cloud


text:
Logger

This PR adds a Logger class to the utils namespace.
The structure of the log messages is the following:
[TIME] [LEVEL] [SOURCE] MESSAGE

TIME is a date and time string. Note that this uses the locale so could differ from system to system.
LEVEL can be INFO or WARNING. Other levels can be easily added later if need be. Note that ERROR is not implemented as those should be exceptions instead. DEBUG is also not implemented as ideally that would be turned on/off in compile time; this could be implemented later as a separate function.
SOURCE will typically be the demangled class name however developers can customize it if needed.
Here is an example:
[10/21/22 00:10:51] [WARNING] [sparsebase::format::CSR<unsigned int, unsigned int, unsigned int>] CSR column array must be sorted. Sorting...

Developers can use the Logger as shown here:
utils::Logger logger(typeid(this));
logger.Log("COO arrays must be sorted. Sorting...", utils::LOG_LVL_WARNING);

Instead of typeid(this) the developer can also pass an arbitrary string. This is used to show the source field in the log message.

Users can adjust various aspects of the logging. Here is an example:
// Doesn't log INFO level events
utils::Logger::set_level(utils::LOG_LVL_WARNING);

// Write to file as well as print
utils::Logger::set_file("test.log");

// Use stderr instead of stdout
utils::Logger::set_stdout(false);
utils::Logger::set_stderr(true);

Have you considered using the observer pattern? This way we could add more output channels. This might be too looking ahead but this would allow us to log into a socket for example.

I dug around and found the following, Design Patterns for logging, I believe for milestone 3 current logging ability is okay. We may need to advance it in future releases.

I dug around and found the following, Design Patterns for logging, I believe for milestone 3 current logging ability is okay. We may need to advance it in future releases.

I did use chain of responsibility before for logging in another project. But here it felt overly complex. However, we can implement that later if we need to.

authors: AmroAlJundi Atahanak ardasener

repo: sparcityeu/sparsebase


text:
Add simple Delete folder btn

resolves https://github.com/spark-notebook/spark-notebook/issues/928
as this does a recursive delete, it would be nice to add more permissions here so people could delete only what belongs to them...

cc @antonkulaga

ready to 🚢 .
P.S. deleting folders is rather dangerous, maybe we need a config option for it...

@vidma did you seen the failed checks ?

<console>:16: error: value toS is not a member of snippet.AnExample

test.toS

     ^

<console>:16: error: value toS is not a member of snippet.AnExample

test.toS

     ^

[info] - should return the correct completions

<console>:16: error: value testMeth is not a member of snippet.AnExample

test.testMeth

     ^

[info] - should lists all overrided method versions, indicating optional parameters if any

<console>:17: error: identifier expected but '}' found.

}

^

Set("==(x$1: Any)", "+(other: String)", "testMethod(a: String, b: String)", "finalize", "notify", "equals(x$1: Any)", "<init>(aField: Int, [notAField: Boolean])", "!=(x$1: Any)", "implicitMethod(a: Int)", "clone", "ensuring(cond: snippet.AnExample => Boolean)", "hashCode", "asInstanceOf", "testVar", "wait(x$1: Long, x$2: Int)", "aField", "##", "formatted(fmtstr: String)", "->(y: B)", "cls", "toSchwarz", "→(y: B)", "<init>(cls: snippet.AnExample)", "ensuring(cond: Boolean)", "wait", "testMethod(a: Int, [optionalB: String])", "ne(x$1: AnyRef)", "ensuring(cond: snippet.AnExample => Boolean, msg: => Any)", "synchronized(x$1: T0)", "getClass", "notAField", "eq(x$1: AnyRef)", "testMethod(a: String)", "toString", "ensuring(cond: Boolean, msg: => Any)", "isInstanceOf", "wait(x$1: Long)", "notifyAll")

authors: frbayart vidma

repo: spark-notebook/spark-notebook

license_source: bigquery


text:
nokogiri x64-mingw32 - link dlls dynamically

judging by the size of the .so files, the 4 dlls are linked in for each ruby version. it would save space if the dlls were linked dynamically and included only once (see mysql2 gem - vendor dir https://rubygems.org/downloads/mysql2-0.3.18-x64-mingw32.gem)
nokogiri.so around 3Mb per ruby version

Cool! Yep - see https://github.com/brianmario/mysql2/blob/master/ext/mysql2/extconf.rb#L97-145
In particular, it took a ton of work to figure out how to use dlltool generate the libmysql.a interface library that does get linked into mysql2.so so that it would link to libmysql.dll on Win x64.

Great idea? Anybody want to try putting together a PR demonstrating how to do this?

run gendef and dlltool just in case the provided lib format is not compatible with ld (see imagemagick binaries compiled with ms visual studio and linked with gnu ld gemhome/rmagick#175)
does the trick for me ...
gendef mylib.dll
dlltool --dllname mylib.dll --def mylib.def --output-lib mylib.lib

Hi,
I'm totally excited about making Nokogiri better on windows; but nobody on the core team is familiar with the toolchain, which is why I'm again asking if anyone would like to try to put together a PR demonstrating how to do this.
Unless someone can teach Team Nokogiri, this feature request is unfortunately not going to get much attention.

The windows binary gems are still smaller than the source gem, insofar this is not worth the effort IMHO. Using libxml2, libxslt, libz and libiconv as DLLs can also lead to new issues when these dependent DLLs can not be found or are (already) loaded in different versions.
As long as static linkage is supported by the upstream projects and the size of the resulting binary gems doesn't grow too much, I think it's better to keep it as is.

authors: ABaumgaertner flavorjones larskanis sodabrew

repo: sparklemotion/nokogiri


text:
Numbers should not be shown as errors

Currently the digits 0 through 9 do not show as errors, but anything 10 or higher does. Either number highlighting as errors should show according to the rules for writing numbers ( http://www.grammarbook.com/numbers/numbers.asp ), or they shouldn't be highlighted at all.

It'd be nice to see this solved... though the odds of it seem low now

It's fixed in PR #34.  A fork with this and other changes is available on Github and NPM.

authors: edemaine laritakr mxgl

repo: sparksuite/codemirror-spell-checker


text:
Documentation incorrect on Remote Setup:

The documentation page on remote setup: sparrowwallet.com/docs/connect-node.html does not mention anything on the prerequisite of having to enable the 'RPC Server' in the preferences -> Options - Main tab. This feature is disabled by default.
I've wasted an hour trying to figure out why I could not connect to the wallet on another local machine and this relatively small addition seems like an easy fix.
I've also tried looking for a way to submit a pull-request to suggest somthing instead of creating an issue, but that is not possible according to the README in the docs directory.

does not mention anything on the prerequisite of having to enable the 'RPC Server' in the preferences -> Options - Main tab

This is the same as setting server=1 in bitcoin.conf, which is the first instruction in the documentation you linked to. I don't believe the UI option you mention is available on older Bitcoin Core installations.

authors: DerekVonk craigraw

repo: sparrowwallet/sparrow


text:
WIP: Add ITK_GAUSSIAN generation option

Adds Gaussian blurring procedure for multiscale pyramid generation roughly following the steps outlined in itk::MultiResolutionPyramidImageFilter:

Run Gaussian blurring on input image
Resample result for given scale factors

Currently only testing on 2D input. @thewtex Could you please weigh in on the following issues that I am seeing?

Baseline comparison fails because there is a difference in output coordinates. I assume this means that there is an issue in resampling. Do you have thoughts on what correction is needed here? Maybe the origin needs to be shifted slightly based on scale factors?

E           AssertionError: Left and right Dataset objects are not equal
E
E           Differing coordinates:
E           L * y        (y) float64 0.5 2.5 4.5 6.5 8.5 ... 246.5 248.5 250.5 252.5 254.5
E           R * y        (y) float64 0.0 2.0 4.0 6.0 8.0 ... 246.0 248.0 250.0 252.0 254.0
E           L * x        (x) float64 0.5 2.5 4.5 6.5 8.5 ... 246.5 248.5 250.5 252.5 254.5
E           R * x        (x) float64 0.0 2.0 4.0 6.0 8.0 ... 246.0 248.0 250.0 252.0 254.0
E           Differing data variables:
E           L   cthead1  (y, x) uint8 0 0 0 0 0 0 0 0 0 0 0 0 0 ... 0 0 0 0 0 0 0 0 0 0 0 0
E           R   cthead1  (y, x) uint8 dask.array<chunksize=(128, 128), meta=np.ndarray>

test\test_spatial_image_multiscale.py:50: AssertionError

Note that itk.ResampleImageFilter expects us to request output metadata, so I have calculated output size/spacing/origin explicitly rather than using filter.UpdateOutputInformation as done in the Methods.ITK_BIN_SHRINK procedure.

I am unclear on how to write out a single scale image result to disk in a way that can be visualized with 3D Slicer or a similar application. Could you please clarify or provide a code snippet detailing how to write out output results for visual evaluation?

This is a first stab at introducing gaussian blurring and does not currently make use of FFTs or VkFFT acceleration. These can be added in an incremental update, possibly using VkDiscreteGaussianImageFilter.

@tbirdso looking great!

I assume this means that there is an issue in resampling

For resampling, we could use this strategy:

Filter with discrete gaussian
Use BinShrink UpdateOutputInformation to determine the sampling grid
Use the results of 1. and 2. as the input image and the definition for the sampling grid in a resample image filter

I am unclear on how to write out a single scale image result to disk in a way that can be visualized with 3D Slicer or a similar application. Could you please clarify or provide a code snippet detailing how to write out output results for visual evaluation?

image_da = multiscale['scale1'].ds.cthead1
itk_image = itk.image_from_xarray(image_da)
itk.imwrite(itk_image, 'itk_image.nrrd')

@thewtex Thanks for the help, interesting that we are getting different output metadata from BinShrinkImageFilter as opposed to output following the MultiResolutionPyramidImageFilter procedure. I may need to dig into BinShrinkImageFilter a bit more to understand what is happening.
I've updated with the suggestions above, while I am getting output for each level I am seeing tenuous results. I am trying to pin down where exactly my logic is going wrong, I have added an optional 2D isotropic image printout from testing for visual comparison of outputs. I have a few questions about previous output baselines and the draft procedure

I am a bit confused on how we are defining "scale factors" here. For both existing procedures the baseline image has a spacing of 1.0mm, an isotropic scale of 2 has a spacing of 2.0mm, but then an isotropic scale of 4 has a spacing of 6.0mm. The image extent is kept roughly the same at each level with sizes of 256, 128, and then 42. I would expect that spacing scales with the scale factor (i.e. 1mm, 2mm, 4mm) and the image size follows suit (256, 128, 32). Am I misunderstanding the procedure at hand?
Under the proposed Gaussian+downsampling implementation, for 2D image input with isotropic scale factors of [2,4], the first scale image appears roughly correct with a slight translation, but the second scale image is greatly downsized and occupies only the top left corner of the 32x32 image. Both describe the same image extent, so it doesn't look like ResampleImageFilter is simply being given the wrong output. Do you have any thoughts as to where the issue may lie?

Scale1 (2.0mm spacing):

Scale2 (4.0mm spacing):

Aha, I've identified two issues due to applying ITK filters to chunks that are passed in in an absence of metadata:

The origin for resampling must be shifted by the kernel radius to compensate for padding
Output spacing must be set as a ratio of input to output spacing per shrink factors rather than passing in the actual output spacing, because chunks are assumed to have isotropic spacing of 1 when converted from xarray

Will prepare a patch. @thewtex Do you have advice on how to add new baseline image data via IPFS?

@tbirdso fantastic!
Please take a look at testing data docs here: https://github.com/spatial-image/multiscale-spatial-image/pull/36

256, 128, and then 42

Yes, this should be 256, 128, 64, with spacing / scale set accordingly!

Code is largely functional, two lingering issues:

itk-vkfft packages are building for Linux 3.10, required for kernel radius computation and FFT GPU speedup
Output result is as expected, but uncertain that Dask processing is executing over chunks, printouts seem to show that entire image is passed to map_overlap. May require further investigation and testing with larger image.

Looks like something strange is going on in the ITKVkFFTBackend Windows modules. I was able to reproduce the issue in https://github.com/InsightSoftwareConsortium/ITKVkFFTBackend/runs/6357790869?check_suite_focus=true:
Loading ITKFiniteDifference... done
Loading ITKDisplacementField... done
Loading ITKRegistrationCommon... done
Loading VkFFTBackend... Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "C:\hostedtoolcache\windows\Python\3.10.4\x64\lib\site-packages\itk\support\lazy.py", line 138, in __getattribute__
    base.itk_load_swig_module(module, namespace)
  File "C:\hostedtoolcache\windows\Python\3.10.4\x64\lib\site-packages\itk\support\base.py", line 96, in itk_load_swig_module
    itk_load_swig_module(dep, namespace)
  File "C:\hostedtoolcache\windows\Python\3.10.4\x64\lib\site-packages\itk\support\base.py", line 96, in itk_load_swig_module
    itk_load_swig_module(dep, namespace)
  File "C:\hostedtoolcache\windows\Python\3.10.4\x64\lib\site-packages\itk\support\base.py", line 241, in itk_load_swig_module
    load_module_needed_factories(name)
  File "C:\hostedtoolcache\windows\Python\3.10.4\x64\lib\site-packages\itk\support\base.py", line 385, in load_module_needed_factories
    load_factories(needed_factories[name])
  File "C:\hostedtoolcache\windows\Python\3.10.4\x64\lib\site-packages\itk\support\base.py", line 365, in load_factories
    itk_load_swig_module(module_name,namespace)
  File "C:\hostedtoolcache\windows\Python\3.10.4\x64\lib\site-packages\itk\support\base.py", line 132, in itk_load_swig_module
    l_module = loader.load(swig_module_name)
  File "C:\hostedtoolcache\windows\Python\3.10.4\x64\lib\site-packages\itk\support\base.py", line 291, in load
    l_spec.loader.exec_module(l_module)  # pytype: disable=attribute-error
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "C:\hostedtoolcache\windows\Python\3.10.4\x64\lib\site-packages\itk\support\..\VkFFTBackendPython.py", line 13, in <module>
    from . import _VkFFTBackendPython
ImportError: DLL load failed while importing _VkFFTBackendPython: The specified module could not be found.
Error: Process completed with exit code 1.

The issue only occurs for windows-2019 runners, Ubuntu and macOS observed to pass all pytests without failure. I am not able to reproduce the issue with a clean Python 3.8 or 3.10 environment on my local Windows machine. Tmate remote debugging appears to be bogged down today and is not able to get a connection for me to investigate the failure. Will continue to investigate to the best of my ability using available resources.

Looks like something strange is going on in the ITKVkFFTBackend Windows modules.

Can we use the CPU version by default (see review comments), then the GPU version if available?
I do not think the Windows GitHub Actions runners have a GPU or OpenCL support.
We could add a separate GitHub Actions test configuration for GPU testing as done with the ITKVtkFFTBackend module.

@thewtex

Can we use the CPU version by default (see review comments), then the GPU version if available?

Yes, this is feasible though has a few extra steps to adjust the current implementation beyond selecting between filters. I will update accordingly.

I do not think the Windows GitHub Actions runners have a GPU or OpenCL support.

I agree that Windows runners have no GPU support but disagree that they have no OpenCL support. If that were the case then our ITKVkFFTBackend Windows CI would always fail (see https://github.com/InsightSoftwareConsortium/ITKVkFFTBackend/runs/6353049662?check_suite_focus=true).
Either way we *should* be packaging the OpenCL-ICD-Loader with itk-vkfft such that build/load will succeed and then actually running will fail if OpenCL is not available on the underlying platform. It's possible that the failure is a result of the OpenCL-ICD-Loader not being properly packaged and distributed with Windows wheels.

We could add a separate GitHub Actions test configuration for GPU testing as done with the ITKVtkFFTBackend module.

I agree that this is a good idea for down the road.

@thewtex Seeing poor performance fetching IPFS data for tests (30+ minutes to pin). Do you have suggestions on how to alleviate/improve slowdowns?

@thewtex Seeing poor performance fetching IPFS data for tests (30+ minutes to pin). Do you have suggestions on how to alleviate/improve slowdowns?

We can also pin on pinata, then connect to these peers.

authors: tbirdso thewtex

repo: spatial-image/spatial-image-multiscale


text:
Class and test for croatian (hr) holidays

Holidays source is from site https://neradni-dani.com/kalendar-2024.php

Thanks, but closing this one, as a Croatia PR has already been merged.

authors: Nielsvanpach erikroznbeker

repo: spatie/holidays


text:
Support for /page-1 (dash/hyphen separator)?

First, thanks for this package. Could you consider adding support for this sort of pagination:
http://example.com/posts/page-1
http://example.com/posts/page-2

Thanks.

Hi,
This package is already too complicated for what it does imo, we're not planning to expand functionality any time soon.

authors: bridgeport sebastiandedeyne

repo: spatie/laravel-paginateroute

license: mit


text:
Create an SPDX file for online tools

Request from @kestewart on the 4 August tech call to add an SPDX file for the online tools as part of our deployment efforts.

@ekongobie Is your python plugin ready to try on the online tools?

@tsteenbe offered to run ORT - suggest we do this once we have the image we plan to deploy.

repo: spdx/spdx-online-tools


text:
Batch padding

Hi.
I'm using the pretrained ecapa-tdnn model as follows
classifier = EncoderClassifier.from_hparams(source="speechbrain/spkrec-ecapa-voxceleb", savedir="pretrained_models/spkrec-ecapa-voxceleb")
and trying to inference with some batches. Everything works fine, but samples which was padded is had little bit different embeddings. Is there any possible methods to avoid this?

Hi @Spectra456 ok, please provide an example to clarify what was the expected result and what happened instead.
(so we can better narrow down the problem)

This is related to the batch independent PR. It's in progress. A batch size of 1 will solve this issue, or simple use segments of equivalent lengths to avoid too much padding.

authors: Spectra456 TParcollet anautsch

repo: speechbrain/speechbrain


text:
Aishell1Mix

This branch adds a new task named Aishell1Mix to the recipes which is similar to the LibriMix but applied to the mandarin AISHELL-1 dataset. Hope to receive your reply. Much thanks.

Thanks for the PR @huangzj421 . I will write a detailed review.

Thanks for the PR @huangzj421 . I will write a detailed review.

It's my pleasure.

Hi @huangzj421 , Something we were wondering was that, it seems there are a lot of overlaps with the existing recipes. Especially train.py looks very similar. Do you think when possible, could you either import some of the classes from existing recipes, or use symbolic links?  Also, I think you could use the existing prepare_data.py for csv creation, and dynamic_mixing.py from other recipes.
In general we think that it would be better to use existing code as much as possible. Otherwise when we want to make new changes, we would need to update a lot of files.

Hi @huangzj421 , Something we were wondering was that, it seems there are a lot of overlaps with the existing recipes. Especially train.py looks very similar. Do you think when possible, could you either import some of the classes from existing recipes, or use symbolic links? Also, I think you could use the existing prepare_data.py for csv creation, and dynamic_mixing.py from other recipes.
In general we think that it would be better to use existing code as much as possible. Otherwise when we want to make new changes, we would need to update a lot of files.

I see. The reason I created this script begins that I saw LibriMix and WSJmix recipes are very similar, just applied to different datasets. But the Mandarin dataset in speech separation is missing, so I created Aishellmix dataset according to the process of Librimix, which means the two scripts are also similar. As for the recipes, I just simply commented out the pre-training model and few more so that it could be trained on the dataset I created.
As for what you said, I was a little confused. Did you mean that this aishellmix should be a subclass to other recipes like Librimix?

Hi @huangzj421 , Something we were wondering was that, it seems there are a lot of overlaps with the existing recipes. Especially train.py looks very similar. Do you think when possible, could you either import some of the classes from existing recipes, or use symbolic links? Also, I think you could use the existing prepare_data.py for csv creation, and dynamic_mixing.py from other recipes.
In general we think that it would be better to use existing code as much as possible. Otherwise when we want to make new changes, we would need to update a lot of files.

Hi @subakan. The reason I created this script begins that I saw LibriMix and WSJmix recipes are very similar, just applied to different datasets. But the Mandarin dataset in speech separation is missing, so I created Aishellmix dataset according to the process of Librimix, which means the two scripts are also similar. As for the recipes, I just simply commented out the pre-training model and few more so that it could be trained on the dataset I created. As for what you said, I was a little confused. Did you mean that this aishellmix should be a subclass to other recipes like Librimix?

I think one way to go about it is to use the existing code for Librimix as much as possible. We can either do this by importing from Librimix, or by symbolic links if we want to use the exact same file. One other option would be to simply add AIshell options to LibriMix, but we think that having a separate recipe for AIshell would increase the visibility.

ix, or by symbolic links if we want to use the exact same file. One other option would be to sim

Okay, I got it. I will figure out how to handle it and commit. Thanks for your patience.

Hi @huangzj421 , Something we were wondering was that, it seems there are a lot of overlaps with the existing recipes. Especially train.py looks very similar. Do you think when possible, could you either import some of the classes from existing recipes, or use symbolic links? Also, I think you could use the existing prepare_data.py for csv creation, and dynamic_mixing.py from other recipes.
In general we think that it would be better to use existing code as much as possible. Otherwise when we want to make new changes, we would need to update a lot of files.

Hi @subakan. The reason I created this script begins that I saw LibriMix and WSJmix recipes are very similar, just applied to different datasets. But the Mandarin dataset in speech separation is missing, so I created Aishellmix dataset according to the process of Librimix, which means the two scripts are also similar. As for the recipes, I just simply commented out the pre-training model and few more so that it could be trained on the dataset I created. As for what you said, I was a little confused. Did you mean that this aishellmix should be a subclass to other recipes like Librimix?

I think one way to go about it is to use the existing code for Librimix as much as possible. We can either do this by importing from Librimix, or by symbolic links if we want to use the exact same file. One other option would be to simply add AIshell options to LibriMix, but we think that having a separate recipe for AIshell would increase the visibility.

Hi @ycemsubakan, I have commited a new version. Is it okay?

Hi @huangzj421 , thanks for the updates. From what I understand, the train.py script does not have support automatic dataset preparation. I think it would be much more easier for the users if we could automatically download the aishell dataset, and prepare it when a user executes train.py. Do you think this would be doable?

Hi @huangzj421 , thanks for the updates. From what I understand, the train.py script does not have support automatic dataset preparation. I think it would be much more easier for the users if we could automatically download the aishell dataset, and prepare it when a user executes train.py (if the dataset does not already exist). Do you think this would be doable?

Hi @ycemsubakan, yeah of course it is doable. But I hope Aishell1mix dataset could be applied separately and widely spread. Thus I suggest if it be generated in prepare_data.py or another new recipe and included in train.py?

@huangzj421 , In prepare_aishell1mix function you are currently just creating the csv file right? I was wondering if you could integrate what this script   does inside train.py ?

@huangzj421 , In prepare_aishell1mix function you are currently just creating the csv file right? I was wondering if you could integrate what this script does inside train.py ?

Okay, I will add it into the prepare_aishell1mix fuction to make it generate automatically in train.py. Thank you.

@huangzj421 , In prepare_aishell1mix function you are currently just creating the csv file right? I was wondering if you could integrate what this script does inside train.py ?

Okay, I will add it into the prepare_aishell1mix fuction to make it generate automatically in train.py. Thank you.

Thanks. Also note that we should check if the dataset already exists or not, in order to save time if the dataset already exists in the specified --data_folder.

@huangzj421 , In prepare_aishell1mix function you are currently just creating the csv file right? I was wondering if you could integrate what this script does inside train.py ?

Okay, I will add it into the prepare_aishell1mix fuction to make it generate automatically in train.py. Thank you.

Thanks. Also note that we should check if the dataset already exists or not, in order to save time if the dataset already exists in the specified --data_folder.

Hi @ycemsubakan , I have integrated it into prepare_data and modified some other files. Thanks.

Thank you @huangzj421. I will take a look tomorrow.

Thanks for the updates @huangzj421 . Here are few comments about data downloading:

It's great to have an automatic data preparation option. I however don't think at the current version we are creating the folder for --data_folder the specified folder does not exist. Like, what is the behavior if the path specified in --data_folder does not exist? Do we create the folder?
For me train.py just hangs at the message Download Aishell1 into --data_folder, and because I do not receive any feedback I don't know what's going on as a user. So I think during the download of aishell data I think you can give feedback to the user, so that we see an estimated finish time for the download. For this, you can use the fetch function here: https://github.com/speechbrain/speechbrain/blob/9df49e17c018c9617dfd3161a7db50a75086603e/speechbrain/pretrained/fetching.py#L26

speechbrain/recipes/REAL-M/sisnr-estimation/train.py

For the first one, the system will exit if the specified folder does not exist because the folder needs large space.
For the second one, there is no feedback with the fetch function so I use a simple callback in urllib.urlretrieve fuction to download with percent feedback. Thanks.

speechbrain/recipes/REAL-M/sisnr-estimation/train.py

For the first one, the system will exit if the specified folder does not exist because the folder needs large space and I prefer users to specify. For the second one, there is no feedback with the fetch function so I use a simple callback in urllib.urlretrieve fuction to download with percent feedback. Thanks.

I am trying to run the script, but for some reason the download is very slow from the provided links (I am seeing 200 kb/s speeds, and I tested both at home and on the server). Do you think you might be able to put these files on a dropbox link (or an alternative) so that the download is faster?

speechbrain/recipes/REAL-M/sisnr-estimation/train.py

For the first one, the system will exit if the specified folder does not exist because the folder needs large space and I prefer users to specify. For the second one, there is no feedback with the fetch function so I use a simple callback in urllib.urlretrieve fuction to download with percent feedback. Thanks.

I am trying to run the script, but for some reason the download is very slow from the provided links (I am seeing 200 kb/s speeds, and I tested both at home and on the server). Do you think you might be able to put these files on a dropbox link (or an alternative) so that the download is faster?

I am sorry that we don't use dropbox here and I don't have a plus or pro account. Aishell1 provides many download links and the used one is a mirror of CN. Could you please try other mirrors to download please?

speechbrain/recipes/REAL-M/sisnr-estimation/train.py

For the first one, the system will exit if the specified folder does not exist because the folder needs large space and I prefer users to specify. For the second one, there is no feedback with the fetch function so I use a simple callback in urllib.urlretrieve fuction to download with percent feedback. Thanks.

I am trying to run the script, but for some reason the download is very slow from the provided links (I am seeing 200 kb/s speeds, and I tested both at home and on the server). Do you think you might be able to put these files on a dropbox link (or an alternative) so that the download is faster?

Aishell1 provides many download links and I have updated a us mirror link. I have no plus or pro account of dropbox to store such a large file and wish you could download faster with this link.

speechbrain/recipes/REAL-M/sisnr-estimation/train.py

For the first one, the system will exit if the specified folder does not exist because the folder needs large space and I prefer users to specify. For the second one, there is no feedback with the fetch function so I use a simple callback in urllib.urlretrieve fuction to download with percent feedback. Thanks.

I am trying to run the script, but for some reason the download is very slow from the provided links (I am seeing 200 kb/s speeds, and I tested both at home and on the server). Do you think you might be able to put these files on a dropbox link (or an alternative) so that the download is faster?

Aishell1 provides many download links and I have updated a us mirror link. I have no plus or pro account of dropbox to store such a large file so wish you could download faster with this link.

The new links seem to be working much faster. I will let you know how it goes with the rest.

Hi @huangzj421 , The dataset download now works better. But after the download the code crashes with the message:
from scripts.create_aishell1_metadata import create_aishell1_metadata
ModuleNotFoundError: No module named 'scripts'

Do you run into this error? I have pulled your latest commit. It seems this is due to the fact that scripts is not on the same folder level as train.py.

Hi @huangzj421 , The dataset download now works better. But after the download the code crashes with the message:
from scripts.create_aishell1_metadata import create_aishell1_metadata
ModuleNotFoundError: No module named 'scripts'

Do you run into this error? I have pulled your latest commit. It seems this is due to the fact that scripts is not on the same folder level as train.py.

My mistake, sorry.

Hi @ycemsubakan , I am sorry that I don't understand what's going on with the test error.

Hi @ycemsubakan , I am sorry that I don't understand what's going on with the test error.

I am not sure either, it seems to be not related to this PR.

I pushed a small change to make it so that we create the --data_folder, if that particular folder does not exist.

I pushed a small change to make it so that we create the --data_folder, if that particular folder does not exist.

Got it, thanks.

For some reason, after the download finishes, the code crashes for me. I am getting a file not found error for the dataset. Are you able to make train.py work on a completely new datapath? I would like to make it sure that someone new who is trying this would be able to run this without running into any errors.

For some reason, after the download finishes, the code crashes for me. I am getting a file not found error for the dataset. Are you able to make train.py work on a completely new datapath? I would like to make it sure that someone new who is trying this would be able to run this without running into any errors.

I already check it that it was resulted from an small boolean error modified by pre-commit reformatted. It's my mistake that I did not run it again after pre-commit hooks, sorry.

For some reason, after the download finishes, the code crashes for me. I am getting a file not found error for the dataset. Are you able to make train.py work on a completely new datapath? I would like to make it sure that someone new who is trying this would be able to run this without running into any errors.

I already check it that it was resulted from an small boolean error modified by pre-commit reformatted. It's my mistake that I did not run it again after pre-commit hooks, sorry.

Thanks for the update. I ran into one error during the wham noise creation part. Because the machine I landed on the cluster did not have sox, the code broke down. I think we can add in the README that we need the sox installed.

One other behavior I am not sure of, is what happens if for some reason the data generation is interrupted. At least, can we detect that the dataset is not completely created, and perhaps delete the existing files and restart from scratch?

Thanks for the updates @huangzj421 .
Now I am able to create the dataset, and the experiment runs when I tried without dynamic mixing. I however have few more questions.

It seems we do not to specify the base folder for dynamic mixing specified with --base_folder_dm, as it is hard coded in the yaml file as base_folder_dm: <data_folder>/data_aishell/wav/train. If we always follow the same folder structure for this, it would be better to write a comment inside the yaml files to say that it shouldn't be changed. The other option would be to hard code it inside train.py. What do you think?

I created the data without the --dynamic_mixing True option, simply by calling python train.py hparams/sepformer-aishell1mix2.yaml --data_folder mypath'. The data was created and the training started without error. However, I later on tried to run the same experiment with python train.py hparams/sepformer-aishell1mix2.yaml --data_folder mypath --dynamic_mixing True`, and I have got the following error:

Please, specify a valid base_folder_dm folder when using dynamic mixing

I have noticed that for sepformer-aishell1mix2-wham.yaml, and sepformer-aishell1mix3-wham.yaml. use_wham_noise variables are set to False. This is a mistake right?

Hi @huangzj421 , thanks for the quick update. The error message above does not appear now, but during the conversion of sampling rate (for the base_folder_dm), I ran into this error:

Do you see the same error as well?

Thanks @huangzj421 for all the updates.
I have test all four .yaml files that you have provided and everything seems to work. If all is okay with @mravanelli as well, we can go ahead and merge the PR I think.

changed the experiment names for hparams with wham noise

Okay, much thanks!

Hi @ycemsubakan @mravanelli , may I ask what's going on now?

Hey @huangzj421 , we need to make one more internal review and then we should be good to merge this.

Hey @huangzj421 , we need to make one more internal review and then we should be good to merge this.

Okay, thanks.

Hi @huangzj421 , Sorry for the long wait.
I have restarted testing the PR, but I noticed that it takes very long for data creation. Please see the screenshot below:

Do you see the same behaviour as well?

Hi @huangzj421 , Sorry for the long wait.
I have restarted testing the PR, but I noticed that it takes very long for data creation. Please see the screenshot below:
Do you see the same behaviour as well?

No, it's impossible to run so slow. Maybe it's related to the memory space of your servers?

I am not sure what's happening here, I tried to generate the datasets on a desktop machine and it took 3 days. Another thing is, would it be possible to selectively generate the datasets. Like, can we specify ['8kmin', '16min'] if we want 8k min version and 16k min version only?

I am not sure what's happening here, I tried to generate the datasets on a desktop machine and it took 3 days. Another thing is, would it be possible to selectively generate the datasets. Like, can we specify ['8kmin', '16min'] if we want 8k min version and 16k min version only?

Hi, now you can specify the generation type in hparams files. Thanks.

I fixed the paths in the yaml files so that the folder names for the datasets are correct. I will merge once the tests pass.


text:
Gradscaler flags

What does this PR do?

This PR add GradScaler flags to ease the customisation of fp16 flags. Furthermore, it adds back the check_loss_isfinite so that the training can be automatically interrupted when the model is locked in NaN/infs losses.

Before submitting

[ ] Did you read the contributor guideline?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified
[ ] Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
[ ] Review the self-review checklist to ensure the code is ready for review

Hey @asumagic, could you please have a look at this PR? Do you feel it helps to customise more the fp16 training ?

Personally, I'm not against adding this hparams. @Adel-Moumen what is the typical use case for that?

I agree it might be a bit weird to have those flags exposed directly as a CLI parameter in the core especially since it is not obvious that those relate to the gradient scaler from their name alone.
Maybe it could be specified as an optional brain parameter of some sort? Not sure how feasible that is and how ergonomic it would be to use in the CLI.

They are all starting with gradscaler as the root of their name suggest that they are related to gradscaler :p

Whoops, I didn't double check the code this morning. It wasn't the case when I checked yesterday :P

I think @Adel-Moumen is raising a good point here. Even if we think that most of the users won't change these options, what users are supposed to do if they want to change them? Changing core.py directly?

I think @Adel-Moumen is raising a good point here. Even if we think that most of the users won't change these options, what users are supposed to do if they want to change them? Changing core.py directly?

You can hijack the Brain constructor in your training script to override the grad scaler defined by the core, but it's not very pretty...

As discussed privately, we remove all the gradscaler options but we keep the checks on the loss. Thank you @Adel-Moumen

authors: Adel-Moumen asumagic mravanelli


text:
:bug: example of scoring change/mistake

What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)

[X] PR title follows the guidelines defined in our pull request documentation

What is the current behavior?
What is the new behavior (if this is a feature change)?**

[ ] Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

/scdiff generate

/scdiff generate

/scdiff generate

repo: spencerschrock/scorecard


text:
Add EnumColumn

This is a column type for working with enums.

I think attributes and dictionary-encoded columns serve this better.

repo: spenczar/quivr


text:
Page.Menus is empty when accessed from a shortcode.

I tried to write a shortcode to display the children pages...
code in my shortcode  :
{{ printf "%#v" (index .Page.Menus "main").Children }}

it displays hugolib.Menu(nil)
But if i use the "same" code in a template like {{ printf "%#v" (index .Menus "main").Children }}
it displays hugolib.Menu{(*hugolib.MenuEntry)(0xc2084afb90), (*hugolib.MenuEntry)(0xc2084af290), (*hugolib.MenuEntry)(0xc208486510), ....

This is a little like the story about the chicken and the egg. Your use case may be solvable, but once we fix that there will be questions about my shortcode on the page doesn't show up in the shortcode which will travel fast into some cyclic object graphs.
And what you try to do doesn't sound like what shortcodes were written for.
I may figure a way to print an ERROR when calling .Page.Content and .Page.Menus, to improve the usability, but that will not fix your problem.

Thanks @bep !

Is there a way to pass a variable or a context to a shortcode ?
I really need to get access to .Site or CurrentNode/Page with Menus to iterate over it.
I trying to code a {{%children-page%}} shortcode which will print all "sub pages" as a list...

i would like to create some shortcode to display children-pages or sibling-pages as i did here : http://vjeantet.github.io/hugo-menu-show/emails/serversetup/mail-server-testing/imap/

Shortcode arguments are value types only.

One thought:
If MenuEntry for page menus had a reference to the page it belongs to, would that solve your problem?

If i can access Menus from a shortcode, Yes

That is a no. But I do not understand why it need to be a SC.

some times, i need to display the children pages at the bottom of the page, and some times, in the middle of the page.
Today i coded the children-page into the template itself, so there is not flexibility to position the list of page where i want in the content.
And when i change the theme, i have to change it.
This kind of usecase is close to want we can find in the atlassian'wiki (confluence) thanks to their macro you place in the page content.

OK, then you need a fix for the issue in the topic title.

Not sure to understand ... (my english is not that good)
You want me to create a new issue as a "feature request" ?

No, this is the issue that needs fixing. By someone.

authors: bep vjeantet


text:
all: Add TOML support for language files

Fixes #2577
Fixes #3200

I will try to figure out tomorrow, why tests are broken.

Now it works

It looks good, but I suspect you got it to go green by replacing a YAML test variant with the new TOML -- which doesn't really work; we have to support both, even if TOML is better.
This is the error I get when I build my site:
Started building sites ...
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x15a8e24]

goroutine 1 [running]:
github.com/spf13/hugo/hugolib.(*Page).shouldBuild(0xc422586a00, 0x17a4470)
	/Users/bep/go/src/github.com/spf13/hugo/hugolib/page.go:781 +0x34
github.com/spf13/hugo/hugolib.(*Site).convertSource(0xc4200deb40, 0x178368c)
	/Users/bep/go/src/github.com/spf13/hugo/hugolib/site.go:1237 +0x21a
github.com/spf13/hugo/hugolib.(*Site).createPages(0xc4200deb40, 0x17767e0, 0x9)
	/Users/bep/go/src/github.com/spf13/hugo/hugolib/site.go:1258 +0xc1
github.com/spf13/hugo/hugolib.(*Site).process(0xc4200deb40, 0x101, 0xc420015db8, 0x9a10379202818a0, 0xed072ce2f)

It's very strange because it perfectly works with examples/multilingual. Something wrong with p.s.Cfg.GetBool() in this case. p.s.Cfg is not nil, but when you call fmt.Println(p.s.Cfg) you can see en and error on this line.

Is #3260 somehow related to this error?

Doubt it. But I will fix that now and then I can check again.

The problem is what we can't see the errors, which go-i18n returns.
To reproduce you should write invalid translation file and you'll become the same error.

I reverted that bad merge, and tested this PR with the new master applied, and still get an error.
Are you saying we are "swallowing" errors from go-i18n somewhere?

Yes

I figured out, where it is:
site.go:66 : applyDepsIfNeeded returns an error, but we doesn't use it:
...
  applyDepsIfNeeded(cfg, sites...)

  h.Deps = sites[0].Deps

  return h, nil
}

func applyDepsIfNeeded(cfg deps.DepsCfg, sites ...*Site) error {
...

OK, thanks, I will check.

I've already fixed it. I will push it in 5 minutes

But even if I now get better error message, it still is breaking from this PR:
Error: Error building site: Failed to load translations in file "en.yaml": failed to unmarshal en.yaml: yaml: unmarshal errors:
  line 2: cannot unmarshal !!seq into map[string]map[string]interface {}

If I use go-i18n from master, all works fine.

Failing YAML:
https://github.com/bep/bepsays.com/blob/master/i18n/en.yaml

It's because you have blank line at the beginning of your file.  If you delete it, everything will operate normally.
It's a bug of go-i18n, I will make a PR to fix it.

https://github.com/nicksnyder/go-i18n/pull/67

Now everything is fixed.

Yes, now it works correctly on my site, too.
This is just great, you showed some real persistence landing this. This is a way more important feature than most people will appreciate -- until they start to use it in real projects of some size!
/cc @spf13 @rdwatters @budparr

Thank you, @bep 😌
But actually it can't be compared to all the work you do. Thank you for supporting this exciting project. I will contribute further to hugo and other side projects to make it better

Very glad i am embrassing hugo. I have no idea what was going on but i knew i am in good company.

authors: Mawulijo bep bogem


text:
Running export command with 'json' option outputs help information

Command taken from the readme: node lib/run.js export --projectKey <project_key> --clientId <client_id> --clientSecret <client_secret> -j out.json
Running this results in command usage output being shown, from --help.
The culprit seems to be the json option.

Hello @VasumathiJayakumar - I suppose that this tool - https://github.com/sphereio/sphere-node-cli should handle product export/import in JSON format' once it is finished.
It looks also that the JSON export was never finished so it is a question if we should implement it here or remove this option from csv-sync and wait for its implementation in sphere-node-cli module.

Hello @hisabimbola @Siilwyn .. any idea what should we do with this issue?

I would say let's remove it for now, we have plenty of technical debt across most tools & adding new features only builds that up.

authors: Siilwyn VasumathiJayakumar junajan

repo: sphereio/sphere-node-product-csv-sync


text:
chore: Drop support for Node < 8

Drop Support for node less than version 8

Updated Node JS version on package.json
Updated Test cases node JS version

Closes #76

Coverage remained the same at 90.076% when pulling 08e4e7d8e1e67269c59a9e44462461197af51f58 on drop-support-for-node into 456981417958f340b3099dec9b4cb233ddab35ba on master.

authors: VineetKumarKushwaha coveralls


text:
add containerD prerequisite if on k3s

When testing Spinkube on a k3s cluster the additional installation  of the containerd service was necessairy for the Spins to start.

Hi, @cyrillc, thanks for your contribution!
As a question for me that isn't blocking this PR, as the information is excellent to point out in the docs — isn't containerd installed by default on k3s installations?
Thanks!

Hi @radu-matei the Service is not installed by default by k3s. the default installation uses containerd-shim but does not install it on the host. I believe it was the kwasm-operator that needs the containerd.service to be installed on the host machine.

repo: spinkube/documentation


text:
Simplified getting started, fix page structure

@duftler @rbuskens resubmitting

@tomas PTAL

LGTM after addressing the comment.

Changes look good aside from comments

Let's revisit min specs on instance types in a different PR.

authors: duftler skim1420 tomaslin


text:
Source Specific Custom Metadata

<
What would you like to be added:
Some of the applications in our environment are writing logs to file on persistent volume and information related to  Kubernetes environment is lost such namespace, pod name etc. For all these logs file, I would like to add metadata which includes this missing information which is known such as namespace or pod name etc.
This inclusion of metadata shall be specific to files only.
Why is this needed:
Logs read from the files can be filtered in Splunk base on the namespace, pod name etc.

@wrahmann I guess you need an addon with props.conf to add some field extractions for namespace & pod, and install this addon on Splunk forwarder or indexer for log file monitoring? If so, I'm afraid it's out of our scope. Anyways I can help to create a ticket and hopefully our PM can put some comments. Thank you.

@wrahmann I guess you need an addon with props.conf to add some field extractions for namespace & pod, and install this addon on Splunk forwarder or indexer for log file monitoring? If so, I'm afraid it's out of our scope. Anyways I can help to create a ticket and hopefully our PM can put some comments. Thank you.

@cheneysplunk
Thank you so much for your feedback. My understanding was all this data is being passed from fluentd.  If that is correct then it is better to add at the source?
Do create a ticket and we can follow from there.

@wrahmann , created following ticket and assigned to our PM. Feel free to add more comments there.
https://jira.splunk.com/browse/ADDON-30794
BTW, fluentd input will be available on UF soon. Maybe we can have a try as well.
To be clear, file monitoring, fluentd input & k8s connector are 3 different GDI solutions. We need to enable fields for search separately.  Saying that this feature request will not be a part of this github repo, but another product in SplunkBase.

@wrahmann
To enrich with k8s metadata info, the record need to have docker.container_id, kubernetes.namespace_name, kubernetes.pod_name, kubernetes.container_name, to query k8s api server.
https://github.com/fabric8io/fluent-plugin-kubernetes_metadata_filter

@cheneysplunk please keep in mind that non-Splunk employees do not have access to the internal Splunk jira so therefore cannot add comments!

@wrahmann , created following ticket and assigned to our PM. Feel free to add more comments there.
https://jira.splunk.com/browse/ADDON-30794
BTW, fluentd input will be available on UF soon. Maybe we can have a try as well.
To be clear, file monitoring, fluentd input & k8s connector are 3 different GDI solutions. We need to enable fields for search separately. Saying that this feature request will not be a part of this github repo, but another product in SplunkBase.

@cheneysplunk ,
We tried to add our comments but had no access. Please update us if there is feedback available on this JIRA ticket at your end.

authors: cheneysplunk gjanders rockb1017 wrahmann

repo: splunk/splunk-connect-for-kubernetes


text:
Include priorityClassName for splunk-kubernetes-objects

Proposed changes
This change Defines priorityClassName to assign a priority class to splunk-kubernetes-objects  pods.
we are planning to implement pod priority to monitoring and logging deployments and daemonsets. the current version does not support that for splunk-kubernetes-objects  deployment.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING doc
[x] I have read the CLA
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

Looks good. any reason you are adding this to objects pod only?

Looks good. any reason you are adding this to objects pod only?

Metrics and logging are already working fine. objects was missing with this functionality for some reason.

@ciwa09
Thank you!


text:
Spring Boot 2 - splunk HEC

I have the following configuration
  <SplunkHttp name="http-inputs"
          url="https://host:443/services/collector/event"
          token=xxxx"
          host=""
          index="xx"
          sourcetype="json_no_timestamp"
         disableCertificateValidation="true">
        <PatternLayout pattern="%m"/>
    </SplunkHttp>

		  <AppenderRef ref="http-inputs"/>
	</Root>
</Loggers>

I am using version 1.7.1 . I dont see any errors when spring boot loads the app. But i dont see the logs in splunk cloud also. When i try to do curl to the Splunk HEC it is working though. Am i missing any configuration. Do i need to import any specific library in the app for logging. I am not logging anything specific to the business logic as this is a plain spring boot data rest api.
How do i debug if the library is properly posting the message or if there is any issue like permission denied.
Am i missing something here.

Opened another issue with correct details

repo: splunk/splunk-library-javalogging


text:
ResultsReader iterator error

Using Splunk 6.2.1 and splunk-sdk-python 1.31
the following code throws an exception on the for loop:
	resultSet = job.events(**{"offset" : offset, "count" : total})
	events = results.ResultsReader(resultSet)
	for event in events:
		print event["_raw"]

+++++++++++++++++++++++++++++++++++++
Throws exception:
Traceback (most recent call last):
File "monitor.py", line 35, in
for event in events:
File "/opt/home/bob/splunk-sdk-python/splunklib/results.py", line 205, in next
return self._gen.next()
File "/opt/home/bob/splunk-sdk-python/splunklib/results.py", line 249, in _parse_results
text = "".join(elem.itertext())
AttributeError: itertext
++++++++++++++++++++++++++++++++++++++
this is code from a classroom example that has been unchanged for at least a year. not sure if the upgrade of 6.2.0 to 6.2.1 or the new version of the sdk is the problem. the resultSet is verified--ie, the search results from the events() method is valid, contains normal data, etc.
this same error also happens if we let the job finish and then access results from the results() method.

@bobwalden does this still work with the latest 6.2.0?
Also, what version of Python are you using?

I've talked to @bobwalden offline. This is bug we introduced a while back for Python 2.6.x, we've already fixed it with 867dd46486fa2283a9f6a4c7b750808685dba49f on the develop branch.

confirmed--i was on 2.6.9, updating python to 2.7.9 fixes the problem. should not have let the p-version get so far behind. sorry for the false alarm and thanks Shakeel for the fast support!

Hi @bobwalden  we've just released v1.4.0 that addresses this, if you want to revert to Python 2.6.x

authors: bobwalden itay shakeelmohamed

repo: splunk/splunk-sdk-python


text:
Update Horizen (ZEN)

Currency name: Horizen
Symbol: ZEN
Website: https://www.horizen.global/
Theme color: #0e9de5
Logo (SVG): Horizen_logos_SVG.zip

What's to update? We already updated it last year: https://github.com/atomiclabs/cryptocurrency-icons/issues/237

// @bagintz

Hello @ldevalliere I'm in charge of this repo now and looking at this—is this issue still relevant? If not please provide me with the current SVG file and color. Thank you.

Yes, still relevant.
Issue: https://github.com/spothq/cryptocurrency-icons/blob/master/svg/color/zen.svg is not in color.
Solution: "Horizen_logomark.svg" inside of the zip file in top comment provided above is in color.

Done.

authors: ldevalliere sindresorhus tommdn

repo: spothq/cryptocurrency-icons


text:
Demo app: Add a “sticky header” component + feature and use it for UI tests

This change adds a header component that applies a parallax-like effect to its background image. It’s showcased in a new “Sticky header” feature.
This is done partly for demonstration purposes, but mostly to be able to perform UI tests against a header component, to assert that the framework behaves the correct way when one is used.
To avoid further code duplication in UI tests, a UITestCase base class is created that performs the “boilerplate” operations involved in setting up a UI test.

@spotify/objc-dev

Current coverage is 92.99% (diff: 100%)

Merging #169 into master will not change coverage

@@             master       #169   diff @@
==========================================
  Files            63         63
  Lines          4528       4528
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           4211       4211
  Misses          317        317
  Partials          0          0

Powered by Codecov. Last update 31983b9...73cd13e

@krris Added another test, and fixed a bug affecting the content inset calcuation when a header component is used. Wanna take a 2nd look? 😄

authors: JohnSundell codecov-io

repo: spotify/HubFramework


text:
Set the correct page title in /create

This commit will fix the page title error in /create
Fixes #996
Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ ] All tests are passing yarn test
[ ] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[ ] Prettier run on changed files
[ ] Tests added for new functionality
[ ] Regression tests added for bug fixes

Changes look like this

repo: spotify/backstage


text:
all tests passing

ignore, testing against travis

Codecov Report

Merging #747 into master will increase coverage by 0.49%.
The diff coverage is 77.55%.

@@             Coverage Diff              @@
##             master     #747      +/-   ##
============================================
+ Coverage     65.62%   66.11%   +0.49%
- Complexity      656      670      +14
============================================
  Files           153      158       +5
  Lines          2883     2925      +42
  Branches        335      336       +1
============================================
+ Hits           1892     1934      +42
+ Misses          844      843       -1
- Partials        147      148       +1

authors: codecov-io mavenraven

repo: spotify/docker-client


text:
Added --dont-remove-tmp-dir parameter to SGEJobTask.

Description
Added parameter to retain the temporary directory created to run the Task on the cluster.
Motivation and Context
This change is helpful for debugging.  Without the change, the temporary directory is always removed, even when, say, it fails it can be helpful to examine the directory to see what was copied, the log files, etc.
Have you tested this? If so, how?
I've been using this change without issue for several months.

will merge if you rebase :)

Rebase done.

authors: brcopeland erikbern

repo: spotify/luigi


text:
[Enhancement] Add Tri-linear logos at the top of the landing page.

Currently, the logo on the landing page looks like this -

Now the requirement is to add two more SVG, one for webpack and one for redux-saga at the left and the right of the react logo. Thus the name is Webpack-React-Saga. It should look similar to the below mockup (ignore the grey border around the mockup)-

Points to remember -

Size of other SVGs should match to the one already present. Check the CSS class 'logo'.
run npm test and all the test cases should pass.

Assing me ;)

Thank you for offering your valuable time. I have assigned it to you.

PR has been merged. Thanks once again. Looking forward to working with you again. If you enjoyed your time here, a ⭐ to the repo would be highly appreciated.


text:
I am trying to redirect the request to the downstream service with https in spring cloud gateway?

I found that in the spring gateway ssl only support trustedX509Certificates. But I have to use the TrustStore , KeyStore,  KeyStorePassword & TrustStorePassword .
I tried to create a  HttpComponentsClientHttpRequestFactory and replace the default http client factory for RestTemplate. But it does not work at all.
Here is a route in my gateway. And I built my gateway based on Spring cloud Greenwich.RELEASE.
  cloud:
    gateway:
      routes:
      - id: topo
        uri: lb://topo
        predicates:
        - Path=/atps/**
        filters:
        - StripPrefix=1
        - Hystrix=atps

I also tried to add ssl properties with ribbon, It also does not work at all.
        props.put("ribbon.IsSecure", true);
        props.put("ribbon.IsHostnameValidationRequired", false);
        props.put("ribbon.IsClientAuthRequired", true);

        props.put("ribbon.KeyStore", Constants.KEY_STORE_PATH);

        props.put("ribbon.KeyStorePassword", storePass);
        props.put("ribbon.TrustStore", Constants.TRUST_STORE_PATH);

        props.put("ribbon.TrustStorePassword", trustStorePass);

Could anyone teach me how to do that? thank a lot in previous

gateway doesn't use ribbon properties. See spring cloud configuration properties and search for spring.cloud.gateway.httpclient.ssl. properties. Also #852 was fixed yesterday for keystore support.

I found that you added it in 2.2.0.M2.  But I want to use it now in my project.  I tried to create a RestTemplate Bean with ssl http client in my Application Context,  But is also does not work at all.
Do you have any more suggestion for that? @spencergibb

This project has nothing to do with rest template.

What can I do to achieve ?
Here is the ssl configuration for my team
       props.put("spring.cloud.gateway.httpclient.ssl.key-store",  Constants.KEY_STORE_PATH);
       props.put("spring.cloud.gateway.httpclient.ssl.key-password", keypass);
        props.put("spring.cloud.gateway.httpclient.ssl.key-store-password", storePass);
        props.put("spring.cloud.gateway.httpclient.ssl.key-store-type", storeType);

        props.put("spring.cloud.gateway.httpclient.ssl.trust-store",  Constants.TRUST_STORE_PATH);
        props.put("spring.cloud.gateway.httpclient.ssl.trust-store-password", trustStorePass);
        props.put("spring.cloud.gateway.httpclient.ssl.trust-store-type", trustStoreType);

@spencergibb  Could you give me more suggestion for this? thanks in advance.

@spencergibb  I copied the HttpClient code from https://github.com/spring-cloud/spring-cloud-gateway/blob/master/spring-cloud-gateway-core/src/main/java/org/springframework/cloud/gateway/config/GatewayAutoConfiguration.java#L568.
And set the KeyManagerFactory as following.
 public  KeyManagerFactory keyManagerFactory () throws IOException, CipherException, KeyStoreException, CertificateException, NoSuchAlgorithmException, UnrecoverableKeyException {

        KeyStore keyStore = KeyStore.getInstance("PKCS12");
        File keyStoreFile = new File(SecurityUtils.cleanPath(Constants.KEY_STORE_PATH));
        InputStream is = new FileInputStream(keyStoreFile);
        Throwable var5 = null;

        try {
            keyStore.load(is, “password”.toCharArray());
        } catch (Throwable ex) {
            throw ex;
        } finally {
            if (is != null) {
                if (var5 != null) {
                    try {
                        is.close();
                    } catch (Throwable var29) {
                        var5.addSuppressed(var29);
                    }
                } else {
                    is.close();
                }
            }

        }

        KeyManagerFactory kmf = KeyManagerFactory.getInstance(KeyManagerFactory.getDefaultAlgorithm());
        kmf.init(keyStore, keyStorePass.toCharArray());

        return kmf;
    }

But it does not work at all.  Could you give me a hand ? thanks

authors: spencergibb xiaoshao

repo: spring-cloud/spring-cloud-gateway