text:
Unstable and unexpected Ingress-SDS behaviour after 1.3.4 upgrade

Bug description
After fix on SDS done on version 1.3.4 for updating certs(#17409), I have been testing with letsencrypt and I'm getting a nil pointer exception.
Expected behavior
Creating a placeholder secret with temporary values, and updating them should result in an update in SDS and the ability to access my services. Letsencrypt certs updates are propagated as expected.
Steps to reproduce the bug

Install Istio version with Helm
Setup a cert issuer LetsEncrypt
Install a certificate
Install bookinfo demo with a reference to the credentials of the certificate

Version
client version: 1.3.4
citadel version: 1.3.4
galley version:1.3.4
ingressgateway version: 1.3.4
pilot version: 1.3.4
policy version: 1.3.4
sidecar-injector version: 1.3.4
telemetry version:1.3.4
How was Istio installed?
Helm Charts
Environment where bug was observed (cloud vendor, OS, etc)
AWS
Extra items:
Logs from ingress-sds:
`kubectl -n istio-system logs istio-ingressgateway-c46947c85-rbc84 -c ingress-sds -f
2019-11-04T08:01:48.736917Z info ControlZ available at 127.0.0.1:9876
2019-11-04T08:01:48.748358Z warn secretFetcherLog failed load server cert/key pair from secret cloudflare-secret: server cert or private key is empty
2019-11-04T08:01:48.748407Z warn secretFetcherLog failed load server cert/key pair from secret letsencrypt: server cert or private key is empty
2019-11-04T08:01:48.748448Z warn secretFetcherLog failed load server cert/key pair from secret letsencrypt-staging: server cert or private key is empty
2019-11-04T08:01:48.838016Z info sdsServiceLog SDS gRPC server for ingress gateway controller starts, listening on "/var/run/ingress_gateway/sds"
2019-11-04T08:01:48.838111Z info citadel agent monitor has started.
2019-11-04T08:01:48.838117Z info sdsServiceLog Start SDS grpc server for ingress gateway proxy
2019-11-04T08:01:48.838249Z info monitor Monitor server started.
2019-11-04T08:01:51.021211Z warn secretFetcherLog failed load server cert/key pair from secret letsencrypt-prod: server cert or private key is empty
2019-11-04T08:03:11.091987Z info secretFetcherLog scrtUpdated is called on kubernetes secret wildcard.edyga.com
2019-11-04T08:08:36.458156Z warn secretFetcherLog failed load server cert/key pair from secret grafana-mesh: server cert or private key is empty
2019-11-04T08:12:46.815097Z info secretFetcherLog scrtUpdated is called on kubernetes secret cloudflare-secret
2019-11-04T08:12:46.815156Z warn secretFetcherLog failed load server cert/key pair from secret cloudflare-secret: server cert or private key is empty
2019-11-04T08:12:46.815161Z warn secretFetcherLog failed load server cert/key pair from secret cloudflare-secret: server cert or private key is empty
2019-11-04T08:12:46.815288Z error Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
/workspace/go/src/istio.io/istio/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:76
/workspace/go/src/istio.io/istio/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:65
/workspace/go/src/istio.io/istio/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:51
/usr/local/go/src/runtime/panic.go:522
/usr/local/go/src/runtime/panic.go:82
/usr/local/go/src/runtime/signal_unix.go:390
/workspace/go/src/istio.io/istio/security/pkg/nodeagent/secretfetcher/secretfetcher.go:466
/workspace/go/src/istio.io/istio/security/pkg/nodeagent/secretfetcher/secretfetcher.go:423
/workspace/go/src/istio.io/istio/vendor/k8s.io/client-go/tools/cache/controller.go:202
/workspace/go/src/istio.io/istio/vendor/k8s.io/client-go/tools/cache/controller.go:309
/workspace/go/src/istio.io/istio/vendor/k8s.io/client-go/tools/cache/delta_fifo.go:436
/workspace/go/src/istio.io/istio/vendor/k8s.io/client-go/tools/cache/controller.go:150
/workspace/go/src/istio.io/istio/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:133
/workspace/go/src/istio.io/istio/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:134
/workspace/go/src/istio.io/istio/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88
/workspace/go/src/istio.io/istio/vendor/k8s.io/client-go/tools/cache/controller.go:124
/usr/local/go/src/runtime/asm_amd64.s:1337`
lets encrypt cert:
kubectl -n istio-system get secret wildcard.edyga.com -o yaml  apiVersion: v1  data: ca.crt: ""  tls.crt: [encoded data, 4784 characters]  tls.key: LS0tLS1CRUdJTiBSU0EgUFJJVkFURSBLRVktLS0tLQpNSUlFcFFJQkFBS0NBUUVBcnh5N21HSVV5UlJ0a1JkTmlMVkpHZlV1Y05Bb0pQcElSK3pURExFL1JLdjhyYTNkClRzVFVvQW5xdVJnYVVNNDdacDJveVFzOUJWTlN1bTRaZmMxa0RFWldmOHlqUEpFRHVGM2hZMG5CbVZxbWtBSXcKcDRTOFBUNThkczlQRVMwY3FBSUJudGw2V2VWQXhzZ2ppaUttRm5QaU03S0dPeUx4VnA1VmhXOGhLT2Z6QUovNAo1UVc2S09wNzcybGFIN1FXemd6dFlvTFRoVG5GMFQvcjByVmNvSDFoWGpqdlBYN3N6amxDZXJjSGdlb2I3bVZ6ClJnbmRLM0RjUER6bVZTekJSZWZKSWRQNGxBaklBUjM0Vk82YlQ4U0tOekl1dVpNd2tSNTFhMlozS0hkVjlJOXMKdm9yVjlSc2dJOFNJQUtFSHNFNlJBbzhHK0VHZGZtcE9Ld2t0d3dJREFRQUJBb0lCQVFDQVRnbzUvZXVDNWQvZQpCbmY5NmU2VkFXdTBweUF5Nzl1VUw3YjN2c3Mvc3RDaUpSbFpoS2pTVmxIUXF4TmxENmJBYWxab2NENldyMVdYCldlSjlwY2Rmb3czdjkrM0hDKzN3NFlDcWNqbFM5dlBCNG9qcHhUenpsdHcxWlhKbWdHcFZ3NXFTWElEa2F6Q0sKTmN5c2d2UzAwTlgxMFNHL0pMdzJIaTlGWklha1pBK3ZFRWEvemx1K3ZHVUZLbXFVZmxCR2lLNDljM3lZcUo5YQpPbmlOWm9NTHVJOElJUzB6bnpRYm1nNXU0dVpYbkJ4alBNV3ozSzZGcjNncTFHUEdHbFFDZVJFMXlNcnhFdVRICkJRRDZpZnl1V2pod1VXQlZMUXU4LzMyL0ZvKzl2aDAzcHluYVhEREZ1UTlxYU5ITlppZXRHRG9Yam1SR3Y4MjQKSmxySEJ5REpBb0dCQU1EaGJhSWoxNDN0aExBNjdxaXFIbmMvWXdVa2NoQ0RMTmhKOHpwVkdQNmxNNGtMWWNUeApkdHZ0T2RKajRqVU42aWU0ekZydkRnVC93RTcvaHVCV1ViMlgzTnc1eFdkMjVXUDVBOWdXT2pRQXZYZlUxOG1SClVYaG5DWlJveEFiVll2b2hnTU1rMTFib2s4eEFGSnBxc205YnJlNTJDa0hFb24wOEJGZlRSL1ZuQW9HQkFPaHEKd3ZoN2JuQVBpQlpqR2VWQ0NaVjh4eFlRU0VxZzB1VzlpbGJrZmc2R0dDTlVpai81amluamdnZ0RheWZ4SUdUNgpsMWpGQWV1Q3FHN2J0amVyVTB2OUFNVm9nZU5UeTNsdWdBRnhqZGpUR3BjdFAvR0gzc1JiVGJOUzdvZy8yeHk3CkRIcTFvWmFITWhTb21acm9iQmpTaDdpZHNYazRaZDhiVTBydnhROUZBb0dCQUxZZUpCNU1LV05oT1VBTTVQdHMKWllmQzJnUW8vV3FKOFBYb0hUaWUwUkxmZVdHVTFhUFhPcHM5eXJMVWpPbjdVWFJnRU5Scms1azB3cWZVcmMxMApzNG1Jc29sZUl2NG1UVUd3QmVrcVU1cDJlRytGRUpyS0UxclVMejlxREcxSFhrVS9EUTAwNC82emE1b1hoMXltCkVnVURVNThzNVZKa0QraWZtcG95YkdkUkFvR0JBT2ZEdHVOazZzOHluY2w5VDVCdmx2RUwrZGZGcXVGSW1LWmkKcVhaVzZtRi9WTWkrZ0JLbHdCK0RjT0tlemhlSmUzMVc2dCtwclcxMTRKS1Q1SlNFODA1K1lHdDYrTE9CbHhGagpvS0JQNVZ5SHZ5ZHNCeXpMQ2RrVEYxdXdZbzlaNWgwelpaRmtXRnVzTzhPZ0VYVUpPdXBSM3VlNTBRV0p1UVNQCjBqS1RBUlpsQW9HQWF4ayt5TjdXZ1hucUhETFZsSTlwNVlvSkZyWjBHQXZZeS9OMDdMWkQyamZUaGVUdERIZEgKRGdLRUxRc1VIQXI0RitoMG4xdmFWbk40V3ZaKzAzQW1pOWdDQkptaEZhWDJpejhEcUVFK0Q4cDZNaTRmYzJaQwpxT3RzYnBwNDRjclkrV2UvdTNZcCtDbFlvaGhERXRRclQrWkJhdUtGVXVmWW56Ti9UTlZPMlNNPQotLS0tLUVORCBSU0EgUFJJVkFURSBLRVktLS0tLQo= kind: Secret metadata: annotations: certmanager.k8s.io/alt-names: '*.edyga.com,1572853627.mesh.edyga.com' certmanager.k8s.io/common-name: '*.edyga.com' certmanager.k8s.io/ip-sans: "" certmanager.k8s.io/issuer-kind: ClusterIssuer  certmanager.k8s.io/issuer-name: letsencrypt-prod  creationTimestamp: "2019-11-04T08:01:52Z"  labels: certmanager.k8s.io/certificate-name: wildcard.edyga.com  name: wildcard.edyga.com  namespace: istio-system resourceVersion: "5332"  selfLink: /api/v1/namespaces/istio-system/secrets/wildcard.edyga.com uid: 5c5df31f-fed9-11e9-9505-0a573c7a1950 type: kubernetes.io/tls

@JimmyCYJ @myidpt

Thanks for reporting this bug!
There are some secrets which are not for ingress SDS, and they do not contain the key/cert fields with matched name. In that case, the extractK8sSecretIntoSecretItem() returns nil, and nil pointers are passed into shouldUpdateSecret().
Citadel panic because in shouldUpdateSecret() it dumps a log message and tries to print the secret name, but the secret is a nil pointer. We don't need this log message as the caller to shouldUpdateSecret() checks the returned value and logs secret name there https://github.com/istio/istio/blob/31f271fc4b210626ad4a5469d48f68e86b4bc75d/security/pkg/nodeagent/secretfetcher/secretfetcher.go#L425. I have created a PR to remove this log.

The PR is merged. Closing this issue now.

authors: JimmyCYJ dcedyga howardjohn


text:
istio 1.5.0 Mixer Report failed with: UNAVAILABLE:Cluster not available

What does the error message in the logs of a k8s service istio-proxy container indicate?
[Envoy (Epoch 0)] [2020-03-10 08:55:29.313][29][warning][filter] [src/istio/mixerclient/report_batch.cc:110] Mixer Report failed with: UNAVAILABLE:Cluster not available

The corresponding k8s service is also no longer accessible, neither from within the cluster nor from outside. It returns 503.
HTTP/2 503
content-length: 33
content-type: text/plain
server: istio-envoy

UNAVAILABLE:Cluster not available

This starts to occur with istio 1.5.0, with istio 1.4.5 everything worked nicely.
The istio-system pod logs don't show any errors.

I'm having the same issue did you find a fix

source: gharchive/issue

repo: istio/istio

license_type: permissive

license_source: github-api


text:
wasm: no feedback on module errors

A module with an infinite loop hangs the request for awhile, subsequent requests pass through.
A module with a panic hangs on first request, but then subsequent requests pass through. Passing through after panic is bad, since this could be exploited by breaking authz extensions.

@kyessenov Is this the correct repo for this issue?

authors: esnible kyessenov


text:
Ingress can not work in 0.5.0

istio: 0.5.0
minikube: 0.25.0 k8s 1.9
installed with mTLS disabled
istio-ingress std out:
2018-02-07T08:14:52.491200Z	info	Epoch 0: set retry delay to 1m42.4s, budget to 0
2018-02-07T08:15:06.102212Z	info	Received 404 status from pilot when retrieving availability zone: AvailabilityZone couldn't find the given cluster node
2018-02-07T08:15:36.103530Z	info	Received 404 status from pilot when retrieving availability zone: AvailabilityZone couldn't find the given cluster node
2018-02-07T08:16:06.105148Z	info	Received 404 status from pilot when retrieving availability zone: AvailabilityZone couldn't find the given cluster node
2018-02-07T08:16:34.891616Z	info	Reconciling configuration (budget 0)
2018-02-07T08:16:34.891711Z	info	Epoch 0 starting
2018-02-07T08:16:34.891756Z	info	writing configuration to /etc/istio/proxy/envoy-rev0.json
2018-02-07T08:16:34.892216Z	info	Envoy command: [-c /etc/istio/proxy/envoy-rev0.json --restart-epoch 0 --drain-time-s 45 --parent-shutdown-time-s 60 --service-cluster istio-ingress --service-node ingress~~istio-ingress-d8d5fdc86-th4vt.istio-system~istio-system.svc.cluster.local --max-obj-name-len 189 -l off]
}{
  "listeners": [],
  "lds": {
    "cluster": "lds",
    "refresh_delay_ms": 1000
  },
  "admin": {
    "access_log_path": "/dev/stdout",
    "address": "tcp://127.0.0.1:15000"
  },
  "cluster_manager": {
    "clusters": [
      {
        "name": "rds",
        "connect_timeout_ms": 10000,
        "type": "strict_dns",
        "lb_type": "round_robin",
        "hosts": [
          {
            "url": "tcp://istio-pilot:15003"
          }
        ]
      },
      {
        "name": "lds",
        "connect_timeout_ms": 10000,
        "type": "strict_dns",
        "lb_type": "round_robin",
        "hosts": [
          {
            "url": "tcp://istio-pilot:15003"
          }
        ]
      },
      "refresh_delay_ms": 1000
    },
    "cds": {
      "cluster": {
        "name": "cds",
        "connect_timeout_ms": 10000,
        "type": "strict_dns",
        "lb_type": "round_robin",
        "hosts": [
          {
            "url": "tcp://istio-pilot:15003"
          }
        ]
      },
      "refresh_delay_ms": 1000
    }
  },
  "statsd_udp_ip_address": "10.96.174.10:9125",
  "tracing": {
    "http": {
      "driver": {
        "type": "zipkin",
        "config": {
          "collector_cluster": "zipkin",
          "collector_endpoint": "/api/v1/spans"
        }
      }
    }
  }
2018-02-07T08:16:35.428718Z warn  Epoch 0 terminated with an error: signal: segmentation fault (core dumped)
2018-02-07T08:16:35.428761Z warn  Aborted all epochs
2018-02-07T08:16:35.428820Z error Permanent error: budget exhausted trying to fulfill the desired configuration
2018-02-07T08:16:35.428850Z error cannot start the proxy with the desired configuration
}

Any clue? Thanks!

Also happens in minikube: 0.24.1 k8s 1.8.x

This is affecting us as well.

Can you post your configuration for ingress?
Yep there's been some critical issues with ingress (and with 0.5.0 in general) which should be sorted with the 0.5.1 release.
https://github.com/istio/istio/pull/3218
Not sure if this is one of those. You can see what is proposed for 0.5.1 here:
https://github.com/istio/istio/issues/3179

What the targeted release date for 0.5.1?

Supposedly targeted next week, but could change.
On Fri, Feb 9, 2018 at 12:11 PM, Ross Guarino notifications@github.com
wrote:

What the targeted release date for 0.5.1?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/3265#issuecomment-364530519, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADP0RbeQzKDOz8b0pWJLtGcuOMSol6vks5tTJhfgaJpZM4R8T9J
.

--
Christian Posta
twitter: @christianposta
http://blog.christianposta.com http://www.christianposta.com/blog

@christian-posta Hi Christian, could you pls advise which is the stable version of Istio I could try? I am currently only looking at Distributed tracing feature.

@christian-posta  Thanks for reply.
I use the default configuration from istio 0.5.0 package, and no user ingress spec defined in my cluster.

I had a similar problem with both 0.5.0 and 0.5.1 on minikube v0.25.0 this week.
In my case, it turned out that kube-dns was unhappy before I ever got to istio.
I applied the RBAC workaround described in https://github.com/kubernetes/minikube/issues/1734 and https://github.com/jetstack/navigator/issues/107 and then was able to install istio 0.5.1 and run the bookinfo demo without a problem.

I am using:

minikube v0.25.0
kubernetes v1.9.0
istio v0.5.1

Istio ingress stdout:
2018-02-26T13:31:26.437002Z     info    Version root@2e4a18076b04-docker.io/istio-0.5.1-30acfe6528107ea333543309095659b93364b30d-Clean
2018-02-26T13:31:26.437041Z     info    Proxy role: model.Node{Type:"ingress", IPAddress:"", ID:"servicemesh-ingress-6d4ff8c47b-tvrtz.istio-system", Domain:"istio-system.svc.cluster.local"}
2018-02-26T13:31:26.437045Z     info    Attempting to lookup address: servicemesh-mixer.istio-system
2018-02-26T13:31:26.438975Z     info    Addr resolved to: 10.105.210.13:9125
2018-02-26T13:31:26.438995Z     info    Finished lookup of address: servicemesh-mixer.istio-system
2018-02-26T13:31:26.439260Z     info    Effective config: binaryPath: /usr/local/bin/envoy
configPath: /etc/istio/proxy
connectTimeout: 10.000s
discoveryAddress: servicemesh-pilot:15003
discoveryRefreshDelay: 1.000s
drainDuration: 45.000s
parentShutdownDuration: 60.000s
proxyAdminPort: 15000
serviceCluster: servicemesh-ingress
statsdUdpAddress: 10.105.210.13:9125
zipkinAddress: zipkin.fleet:9411

2018-02-26T13:31:26.439286Z     info    Monitored certs: []envoy.CertSource{envoy.CertSource{Directory:"/etc/istio/ingress-certs/", Files:[]string{"tls.crt", "tls.key"}}}
2018-02-26T13:31:26.439693Z     info    Starting proxy agent
2018-02-26T13:31:26.440057Z     info    Received new config, resetting budget
2018-02-26T13:31:26.440077Z     info    Reconciling configuration (budget 10)
2018-02-26T13:31:26.440085Z     info    Epoch 0 starting
2018-02-26T13:31:26.440174Z     info    writing configuration to /etc/istio/proxy/envoy-rev0.json
2018-02-26T13:31:26.440183Z     info    Availability zone not set, proxy will default to not using zone aware routing. To manually override use the --availabilityZone flag.
2018-02-26T13:31:26.440274Z     warn    watching /etc/istio/ingress-certs/ encounters an error no such file or directory
{
  "listeners": [],
  "lds": {
    "cluster": "lds",
    "refresh_delay_ms": 1000
  },
  "admin": {
    "access_log_path": "/dev/stdout",
    "address": "tcp://127.0.0.1:15000"
  },
  "cluster_manager": {
    "clusters": [
      {
        "name": "rds",
        "connect_timeout_ms": 10000,
        "type": "strict_dns",
        "lb_type": "round_robin",
        "hosts": [
          {
            "url": "tcp://servicemesh-pilot:15003"
          }
        ]
      },
      {
        "name": "lds",
        "connect_timeout_ms": 10000,
        "type": "strict_dns",
        "lb_type": "round_robin",
        "hosts": [
          {
            "url": "tcp://servicemesh-pilot:15003"
          }
        ]
      },
      {
        "name": "zipkin",
        "connect_timeout_ms": 10000,
        "type": "strict_dns",
        "lb_type": "round_robin",
        "hosts": [
          {
            "url": "tcp://zipkin.fleet:9411"
          }
        ]
      }
    ],
    "sds": {
      "cluster": {
        "name": "sds",
        "connect_timeout_ms": 10000,
        "type": "strict_dns",
        "lb_type": "round_robin",
        "hosts": [
          {
            "url": "tcp://servicemesh-pilot:15003"
          }
        ]
      },
      "refresh_delay_ms": 1000
    },
    "cds": {
      "cluster": {
        "name": "cds",
        "connect_timeout_ms": 10000,
        "type": "strict_dns",
        "lb_type": "round_robin",
        "hosts": [
          {
            "url": "tcp://servicemesh-pilot:15003"
          }
        ]
      },
      "refresh_delay_ms": 1000
    }
  },
  "statsd_udp_ip_address": "10.105.210.13:9125",
  "tracing": {
    "http": {
      "driver": {
        "type": "zipkin",
        "config": {
          "collector_cluster": "zipkin",
          "collector_endpoint": "/api/v1/spans"
        }
      }
    }
  }
2018-02-26T13:31:26.441015Z     info    Envoy command: [-c /etc/istio/proxy/envoy-rev0.json --restart-epoch 0 --drain-time-s 45 --parent-shutdown-time-s 60 --service-cluster servicemesh-ingress --service-node ingress~~servicemesh-ingress-6d4ff8c47b-tvrtz.istio-system~istio-system.svc.cluster.local --max-obj-name-len 189 -l off]
2018-02-26T13:31:56.492244Z     info    Received 404 status from pilot when retrieving availability zone: AvailabilityZone couldn't find the given cluster node
2018-02-26T13:32:26.500984Z     info    Received 404 status from pilot when retrieving availability zone: AvailabilityZone couldn't find the given cluster node
2018-02-26T13:32:56.503425Z     info    Received 404 status from pilot when retrieving availability zone: AvailabilityZone couldn't find the given cluster node
2018-02-26T13:33:26.507448Z     info    Received 404 status from pilot when retrieving availability zone: AvailabilityZone couldn't find the given cluster node
2018-02-26T13:33:56.509650Z     info    Received 404 status from pilot when retrieving availability zone: AvailabilityZone couldn't find the given cluster node
2018-02-26T13:34:26.511146Z     info    Received 404 status from pilot when retrieving availability zone: AvailabilityZone couldn't find the given cluster node
2018-02-26T13:34:56.512696Z     info    Received 404 status from pilot when retrieving availability zone: AvailabilityZone couldn't find the given cluster node
2018-02-26T13:35:26.513824Z     info    Received 404 status from pilot when retrieving availability zone: AvailabilityZone couldn't find the given cluster node
2018-02-26T13:35:56.515680Z     info    Received 404 status from pilot when retrieving availability zone: AvailabilityZone couldn't find the given cluster node
2018-02-26T13:36:26.517300Z     info    Received 404 status from pilot when retrieving availability zone: AvailabilityZone couldn't find the given cluster node
2018-02-26T13:36:56.518833Z     info    Received 404 status from pilot when retrieving availability zone: AvailabilityZone couldn't find the given cluster node

Should work with 0.8.

authors: andraxylia brandon-bethke-neudesic chinajuanbob christian-posta jjm3 rlguarino secat vivek-jain


text:
install/updateVersion.sh should generate files in $OUT

This will avoid keeping make clean and .gitignore updated. See #3492
cc @costinm

careful that changing that means also changing the release making scripts @mattdelco

Actually the release build already runs updateVersion.sh in $OUT (it uses the "istio-archive" target in the top-level Makefile, which in part runs updateVersion.sh with -d "${ISTIO_OUT}/archive").  I had previously considered changing the other targets to use ${ISTIO_OUT} but it'd be tough to track down all uses that might break (e.g., tests and devs), and I wasn't sure if there was much point in the effort if the helm-related work might make the script obsolete.

cc @sdake

Obsolete. install/updateVersion.sh is not supposed to be called directly anymore.

authors: hklai jeffmendoza ldemailly mattdelco sdake


text:
Automator: update istio/api@master dependency in istio/istio@master

Generated by Automator - 2020-03-07T00:47:42+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
a92d03e886e73a91f35bd53e125f0a97658b40a5
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
875b848612a1e1593865088468d5693b107c88a9
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
f0adfdd3fe54bc64a6cd4375dd903b74f184c451
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
7b6eb6ae37e46f39546f9d433bdb56ef46105ec2
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

source: gharchive/pull-request


text:
Remove dependency on google.golang.org/api

This dep is ~22mb, bloats the binary. See https://github.com/istio/istio/issues/26232

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
58c68b95a5ba82a3e96ae6186726425da8f8d630
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
58c68b95a5ba82a3e96ae6186726425da8f8d630
link
/test release-notes_istio

gencheck_istio
58c68b95a5ba82a3e96ae6186726425da8f8d630
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
58c68b95a5ba82a3e96ae6186726425da8f8d630
link
/test release-notes_istio

gencheck_istio
58c68b95a5ba82a3e96ae6186726425da8f8d630
link
/test gencheck_istio

lint_istio
58c68b95a5ba82a3e96ae6186726425da8f8d630
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

authors: howardjohn istio-testing


text:
[release-1.8] Add a release note for external istiod

This is an automated cherry-pick of #28656

@linsun can you reply to the google-cla bot comment

@googlebot i consent

authors: GregHanson istio-testing linsun


text:
istioctl verify-install: fix empty revision

To fix https://github.com/istio/istio/issues/30612
Before:
[istio-1.9.0-rc.0]$ istioctl verify-install
1 Istio control planes detected, checking --revision "" only
✔ ClusterRole: istiod-istio-system.istio-system checked successfully
✔ ClusterRole: istio-reader-istio-system.istio-system checked successfully

After:
[istio-master]$ ./out/linux_amd64/istioctl verify-install
1 Istio control planes detected, checking --revision "default" only
✔ HorizontalPodAutoscaler: istio-ingressgateway.istio-system checked successfully
✔ Deployment: istio-ingressgateway.istio-system checked successfully

[istio-master]$ istioctl verify-install -r 1-10-0

[istio-master]$ ./out/linux_amd64/istioctl verify-install
1 Istio control planes detected, checking --revision "1-10-0" only
✔ ClusterRole: istiod-istio-system.istio-system checked successfully
✔ ClusterRole: istio-reader-istio-system.istio-system checked successfully

@shamsher31: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
14048af7c589cbfaa1f3738ea588761e751aa027
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-mc-k8s-tests_istio

In response to a cherrypick label: new pull request created: #30801


text:
addons: bump versions

Please provide a description of this PR:

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
bfcfd984e45d6911dfa60be9c3825bd238f72e15
link
unknown
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


text:
Improve security/registry coverage

https://github.com/istio/istio/issues/3957

/retest

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
8e04b0e27ea019e06a08b8604ebc2f65febbebb0
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
8e04b0e27ea019e06a08b8604ebc2f65febbebb0
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
8e04b0e27ea019e06a08b8604ebc2f65febbebb0
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
8e04b0e27ea019e06a08b8604ebc2f65febbebb0
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
8e04b0e27ea019e06a08b8604ebc2f65febbebb0
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
8e04b0e27ea019e06a08b8604ebc2f65febbebb0
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

please update the title of the pr to be informative like from "Fixit" now to "Improve security coverage"
the codecov numbers seems out of whack (-22%...), @sebastienvas any idea?

Does anyone know why ci/circleci: test fail? I don't think this PR cause that.

I don't know why these tests fail... Can you rebase to trigger the circleci again?

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests.sh
8e04b0e27ea019e06a08b8604ebc2f65febbebb0
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
8e04b0e27ea019e06a08b8604ebc2f65febbebb0
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
afa7cec14f1c12093375890490a67e3c0a02e022
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
8e04b0e27ea019e06a08b8604ebc2f65febbebb0
link
/test istio-pilot-e2e

prow/e2e-simpleTests.sh
afa7cec14f1c12093375890490a67e3c0a02e022
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
afa7cec14f1c12093375890490a67e3c0a02e022
link
/test e2e-bookInfo

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
afa7cec14f1c12093375890490a67e3c0a02e022
link
/test e2e-simple

prow/e2e-bookInfoTests.sh
afa7cec14f1c12093375890490a67e3c0a02e022
link
/test e2e-bookInfo

prow/istio-pilot-e2e.sh
afa7cec14f1c12093375890490a67e3c0a02e022
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I ignored the codeCov change since it can't be decreasing.

authors: diemtvu istio-testing ldemailly myidpt


text:
Custom labels added for istio-cni deployment and pods in helm chart

This PR adds the capability in helm chart for adding custom labels to istio-cni deployments ands pods and aims at this Issue - https://github.com/istio/istio/issues/50372

Hi @nischay30. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I was about to open a PR - can you add the "app: istio-cni" label as well ?
It is very annoying that all other charts have this label - but this one uses k8s-app instead ( and I don't know what "-node" suffix means - all other charts use the "app: chart_name")

The k8s-app label is present in spec.selector.matchLabels, which is immutable field. By replacing, it will become a breaking change, where first it needs to be uninstalled.

And it may be useful to provide an example of 'when you need them' - by the criteria that you may need something we would replicate the entire Pod spec in values.yaml...
I know there is a pattern of redundant docs in most of the helm charts, but at least for new stuff it may be nice to have at least an example use case.

Do you have any example? any format? where we can add? because custom labels isn't a big thing

Not change - add. There is no harm in adding an extra label.
On Mon, Apr 29, 2024, 03:45 Nischay Goyal @.***> wrote:

I was about to open a PR - can you add the "app: istio-cni" label as well ?
It is very annoying that all other charts have this label - but this one
uses k8s-app instead ( and I don't know what "-node" suffix means - all
other charts use the "app: chart_name")
The k8s-app label is present in spec.selector.matchLabels, which is
immutable field. By replacing, it will become a breaking change, where
first it needs to be uninstalled.
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/50694#issuecomment-2082401496, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUR2XRRTNNQ7TX6YIOYJLY7YQDDAVCNFSM6AAAAABG2QGFCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBSGQYDCNBZGY
.
You are receiving this because your review was requested.Message ID:
@.***>

Don't worry about 'app', I can open a separate PR.
For comments - just some example like what label you are planning to use, I
assume this PR is based on some use case you have.
On Mon, Apr 29, 2024, 15:50 Costin Manolache @.***> wrote:

Not change - add. There is no harm in adding an extra label.
On Mon, Apr 29, 2024, 03:45 Nischay Goyal @.***>
wrote:

I was about to open a PR - can you add the "app: istio-cni" label as well
?
It is very annoying that all other charts have this label - but this one
uses k8s-app instead ( and I don't know what "-node" suffix means - all
other charts use the "app: chart_name")
The k8s-app label is present in spec.selector.matchLabels, which is
immutable field. By replacing, it will become a breaking change, where
first it needs to be uninstalled.
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/50694#issuecomment-2082401496, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUR2XRRTNNQ7TX6YIOYJLY7YQDDAVCNFSM6AAAAABG2QGFCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBSGQYDCNBZGY
.
You are receiving this because your review was requested.Message ID:
@.***>

Can you add a release note file?
Also explain why use daemonset vs pod level label for istio-cni?
cc @bleggett

It's good practice to have both, like we already do in the ztunnel daemonset chart.
My biggest beef with the istio-cni chart is the use of the cni prefix for all the values, which is an artifact of istioctl and very non-helm.

On Thu, May 2, 2024 at 9:02 AM Ben Leggett @.***> wrote:

Can you add a release note file?
Also explain why use daemonset vs pod level label for istio-cni?
cc @bleggett https://github.com/bleggett
It's good practice to have both, like we already do in the ztunnel
daemonset chart.
My biggest beef with the istio-cni chart is the use of the cni prefix for
all the values, which is an artifact of istioctl and very non-helm

+1
There is an opportunity to cleanup a bit - add new things at top level, add
"public / stable" things to top level, etc.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Can you add a release note file?
Also explain why use daemonset vs pod level label for istio-cni?
cc @bleggett

I have changed to labels as discussed above. Also, how to add release-notes file?

Can you add a release note file?
Also explain why use daemonset vs pod level label for istio-cni?
cc @bleggett

I have changed to labels as discussed above. Also, how to add release-notes file?

Check istio/releasenotes/README.md

Custom labels on Daemonset level, for eg - FinOps/teams labels

labels: {}

 # team-owner: finops

Custom labels on Pod level, for eg - FinOps/teams labels

podLabels: {}

 # team-owner: finops

Minor nit - don't need specific examples.

I asked for examples and use cases - but I agree 'team-owner' is not the
right example for CNI or ztunnel, it's not a regular pod.
I still don't understand the use case, but since all other helm charts we
have contain similar customisation I don't mind this, was just hoping to
understand.

Custom labels on Daemonset level, for eg - FinOps/teams labels + labels: {} + # team-owner: finops + + # Custom labels on Pod level, for eg - FinOps/teams labels + podLabels: {} + # team-owner: finops + Minor nit - don't need specific examples.

I asked for examples and use cases - but I agree 'team-owner' is not the right example for CNI or ztunnel, it's not a regular pod. I still don't understand the use case, but since all other helm charts we have contain similar customisation I don't mind this, was just hoping to understand.

I'll leave it to you then, I missed you had asked for it, it just looks weird since we don't do that in other spots and people might not know what finops is.

What is blocking to get this merged?

Not sure.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nischay30: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
b16c562d46125989e1f6bbc69477d50069ec9427
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nischay30: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
b16c562d46125989e1f6bbc69477d50069ec9427
link
true
/test unit-tests-arm64

gencheck_istio
b16c562d46125989e1f6bbc69477d50069ec9427
link
true
/test gencheck

unit-tests_istio
b16c562d46125989e1f6bbc69477d50069ec9427
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nischay30 can you make CI happy?

can this be reopened? another use case would be adding necessary labels to specify the kyverno pod security policy.

@yyardeng you're welcome to reopen it or open another PR. https://github.com/istio/istio/issues/50372 is still open and I think we're OK to do this.

authors: bleggett costinm istio-testing nischay30 yyardeng zirain


text:
Allow specifying the sidecar tls termination protocol as h2

Please provide a description of this PR:

Currently, the Sidecar validation web hook rejects configurations that specify a non-TLS protocol for an inbound listener if a server TLS configuration is provided.
This restricts the inbound protocol post-decryption from being a protocol other than HTTP1 + TLS or raw TCP + TLS.
This PR introduces the protocol h2 to allow specifying that the downgraded protocol is HTTP2
Related to #37611

Hi @wtzhang23. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

/ok-to-test

@wtzhang23: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
e1ebb0571f1d98eb233c80513adac9b7eea6e5ab
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

I initially chose this approach modelling after the obscure HTTP_PROXY instance, but I agree it is easy to confuse H2 and HTTPS.

Haven't gotten around to making the changes, but think a new field in the sidecar port downgradedProtocol is the approach I'd like to take.

authors: istio-testing wtzhang23 zirain


text:
pull istio/istio from release-0.2 for e2e

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

none

@yutongz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
751404c2c0562b6d34f992c2115a0062adad5022
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

/retest

authors: ayj istio-testing yutongz

repo: istio/pilot


text:
[P002] Info su "tipoDettaglioP002"

Buongiorno,
abbiamo svolto delle prove in ambiente di test, simulando diverse richieste dal portale del cittadino (di test).
In tutte le casistiche la risposta del servizio P002 ha sempre i tag "soggettoInteressato" e "famigliaConvivenza" mancanti.
In quale situazione compaiono?
Grazie

Salve,
si saranno sempre assenti. E' possibile trascurarli nell'implementazione attuale, non saranno mai restituiti.
I tag "soggettoInteressato" e "famigliaConvivenza" fanno parte di una prima idea di realizzazione delle funzionalità di Rettifica e Cambio Residenza in cui si apriva una richiesta per conto di un soggetto terzo, diverso dal "richiedente" (l'Interessato) o per conto della propria famiglia anpr (la famigliaConvivenza).

authors: SAlberto apaolacci

repo: italia/anpr


text:
Rilascio Web Service P000 per introduzione nuovo tipo pratica 4 - Dichiarazione di trasferimento in Italia per i Cittadini UE

Buonasera,
in riferimento alla issue https://github.com/italia/anpr/issues/4253, si comunica che essendo stato pubblicato in Gazzetta Ufficiale il Decreto del Ministero dell’interno recante “Adeguamento dell’ordinamento nazionale alle previsioni di cui all’articolo 6 del Regolamento (UE) 2018/1724 del Parlamento europeo e del Consiglio del 2 ottobre 2018 per garantire, mediante l’ANPR, l’accesso nonché l’espletamento in linea delle procedure di cui all’allegato II al medesimo regolamento e relative alla richiesta di una prova della registrazione di nascita, alla registrazione del cambio di indirizzo ed alla richiesta di una prova di residenza”, lunedì 5 febbraio sarà effettuato il rilascio in produzione dei servizi P000 aggiornati.

Buonasera
E' stata trasmessa la scorsa settimana alle software house una  email informativa per l'esecuzione dei test. Chi non l'avesse ricevuta può comunicarlo cortesemente in questa issue. Grazie

comunico di non avere ricevuto la mail. grazie

Può indicare per favore a chi indirizzarla?

Non l'ho scritto perché ho pensato lo vedesse dal @.***
Questa e-mail ed i suoi allegati sono ad uso esclusivo di coloro ai quali è indirizzata e potrebbe contenere informazioni riservate, la cui diffusione, copia e/o distribuzione è proibita. Qualora riceveste questo messaggio per errore, scusandoci per l'accaduto, Vi preghiamo di avvertirci immediatamente, distruggendo quanto ricevuto.

Buongiorno chiedo di inviare la mail anche a monia.pedrazzoli@apkappa.it
Grazie

authors: AMonopoliADS MoniaPedrazzoli ncapozzi


text:
L'operazione da annullare non è l'ultima per il soggetto/i o per le famiglie movimentate dall'operazione stessa;

comune di Scandicci (FI)  ambiente di produzione
cercando di annullare una operazione di mutazione residenza apr (idanpr 29823285) di un soggetto omonimo - errore materiale dell'operatore, si ha il problema in oggetto ,
ho provato ad annullare l'operazione successiva sulla famiglia (idanpr 29826081) che è corretta ma che dovrebbe essere la pratica che blocca l'altra, ma ho lo stesso messaggio,
potete controllare quale operaizone blocca il ripristino e come posso correggere la situazione?
grazie dell'attenzione

la seconda operazione, idanpr=29826081, movimenta un'altra famiglia, su cui successivamente alla mutazione di residenza, è stata effettuata una mutazione famiglia convivenza (tipo mutazione 2 composizione scheda);
nell'ordine, le operazioni da annullare sono:
31549091
29826081
29823285

come dicevo è una mutazione famiglia convivenza tipo mutazione 2, composizione scheda, effettuata dal comune di Firenze;
mi scriva i suoi riferimenti in privato per favore
frmariani@sogei.it

authors: ale-magna frmariani


text:
[SC]: Errore attribuzione numero unico ANPR a sposo non presente in ANPR

Ambiente
pre-produzione
Servizio
R009 - Servizi cooperativi validazione evento
idOperazione
assente
idEvento o idAnsc
3517437
Provenienza segnalazione
Software House
Comune di riferimento e operatore
Novi Ligure
Data del test (yyyy-mm-dd)
2024-10-22
Descrivi il problema
Inserendo un matrimonio religioso, abbiamo comunicato i dati degli sposi di cui uno già presente in ANPR con ID unico nazionale XF98298HU e la sposa non presente in ANPR. Dopo aver inserito il matrimonio ci siamo accorti che alla sposa è stato attribuito il medesimo numero unico nazionale dello sposo, quindi facendo un'interrogazione per ID ANPR XF98298HU vengono restituiti due soggetti diversi.
Come riprodurre il problema
No response
Payload (json)
No response

Salve @LucaBonini64
Potrebbe indicarci l'idOperazione come richiesto e quale servizio d'interrogazione ha richiesto?
Cordiali Saluti.
Supporto ANSC.

Mi sono accorto della duplicazione perché nel fare una ricerca dell'intestatario, servizio R005, con il payLoad:
{"criteriRicercaSoggetto":{"idAnprUnico":"XF98298HU"},
"testataRichiesta":{"idComune":6498,"idOperazioneComune":"1531","dataOraRichiesta":"2024-10-22T16:22:36.9205294+02:00","nomeApplicativo":"hyperSIC.StatoCivile","versioneApplicativo":"9.23.21.00.1L03","fornitoreApplicativo":"APKAPPA S.r.l."}}
ho ricevuto una risposta multipla, vedi id operazione 2657277.
Ovviamente non sarà l'operazione di consultazione che ha duplicato il numero unico nazionale ma presumo l'operazione di validazione dell'evento fatto oggi per inserire l'evento 3517437, purtroppo non ho più il payload inviato per la validazione.

repo: italia/ansc


text:
[Feat] OIDC Provider staff panel for testing a RP

if a user gets logged in and he is a staff (user.is_staff == True) we MUST redirect the user to the testing page instead of the consent one.
In the testing page the user (staff) can select one of the several test we'll have to check the compliances of a RP to SPID and/or CIE id.
the user can also be able to change the attributes, remove or add, to be released to the RPs.

We have this here

@dezhizhang1985 please add a concrete navbar with history page of user accesses
The application where to develop this feature is relying_party_test.
Then we need a django global settings dictionary, fullfilled of packages-as-string (dynamically importables), each package has a function with a common name and a common set of kwargs. Each function returns the issued tokens and also the authz code, all in.
When a staff user comes in the test page here we have to get OR create all the available tests (take from that setting dict) FROM/TO here.
If a test is already done, we'll represent the status. If not we create it without a status.
All the tests are now represented to the staff user. He can checks the status of these and run these again, using the current session (using your browser) or via batch. The only way to have tests via batch is if the RP support a public url where to trigger the authz request to a provider.
Va batch the code would be similar to this, using an embedded chrome browser that can take screenshots
import asyncio
from pyppeteer import launch

async def main():
    browser = await launch()
    page = await browser.newPage()
    await page.goto('https://example.com')
    await page.screenshot({'path': 'example.png'})
    await browser.close()

asyncio.get_event_loop().run_until_complete(main())

pointing and clicking via web we also need a bunch of js lines of code that inspect the values of these DOM input fields
id_redirect_uri
id_attributes
id_authz_url

and also the id of the pressed button (that has the id of the test), via POST.
the view that receives this POST is protected with request.user.is_authenticated (if the user is testing with its browser) or with a StaffAuthzToken (for batch needs or for a js that call this resource under the hood).
If batch the view will execute the embedded browser starting from the authz url of the RP, collects http status code and takes a screeshot.
If browser the operator will check by hands and will mark the test as failed.

SPID/CIE QaD tests
Once the submission passes the initial checks the request is saved and a batch will start the
Automatic checks on the latter new registered entity. These check covers

entity configuration:

reachability
signature validation
best practices checks following AgID and IPZS OIDC Fed guidelines.

RP authz check following AgID and IPZS OIDC Fed guidelines.

trust marks forgery (if present for recurrent sample checks)

The tests produces a json report.
this report would be also available in HTML format.
Considerations

it would be necessary to "regulate" how the entities must expose a trigger url of the authn request.
This would allow us to batch automate testing and obtain asynchronous reports and request states.
Automatically a warning email would be sent to users.

It would be useful to standardize a "quota" to avoid that "the usual primers"
can make too many stupid requests all at once, that is, max N batch testing can be performed per day for a single applicant.

This feature will be developed by AgID so this issue is on hold untill we don't get a clear plan

repo: italia/spid-cie-oidc-django


text:
Aggiornamento metadata per Regione Emilia Romagna

Buongiorno,
comunico l'attivazione di un nuovo servizio:
Nome: Consultazione Cedolini - Regione Emilia-Romagna
Attributi:email,familyName,fiscalNumber,name,spidCode
Livello SPID:2
Grazie
saluti
Chiara Caniggia
Lepida ScpA

Il Metadata è stato inoltrato verso gli IdP e da essi caricato.

authors: AntonioGiovanniSchiavone chiaracaniggia

repo: italia/spid


text:
Skip device update if payload is empty

When renaming a device zigbee2mqtt sends a message with an empty payload to the old device topic (see https://github.com/Koenkk/zigbee2mqtt/blob/6484feecb7c4727c0623a8a6264bac8b3403bbb3/lib/extension/bridge.js#L390) and this breaks the JSON parsing resulting in an error in the logs.
This PR checks that the payload is not empty before trying to parse it as JSON. It also adds the raw payload to the logs if the JSON parsing fails to any other reason so that it's easier to debug this issue in the future.

BTW thanks for this great library! Just started using it and it's so useful.

Thanks for your contribution. Added a minor comment.  Not sure why the build is failing though, I'll try to have a look later tonight.

@itavero I can't see your comment for some reason?

@jkimbo  Apparently I had to click an additional button to actually publish the comment ;)
I haven't been able to look into why the build is failing. It appears that for your PR somehow the token for SonarCloud isn't available. Probably a rights issue in GitHub that I should fix somehow.

I tried to rebase your branch up on the master branch but somehow the GitHub Desktop app messed up.

@jkimbo Merged your changes. They will be included in the next release. Thanks again for your contribution! 👍

Thanks!

Now available in v1.1.2

authors: itavero jkimbo


text:
Backend problem: GCS occasionally closes connection immediately?

While processing a build:
Get (snipped): EOF
git.itch.ovh/itchio/wharfd/vendor/github.com/itchio/wharf/pools/cachepool.(*CachePool).Preload
	/home/amos/goprod/src/git.itch.ovh/itchio/wharfd/vendor/github.com/itchio/wharf/pools/cachepool/cachepool.go:73
git.itch.ovh/itchio/wharfd/jobs.DoApplyTask.func2
	/home/amos/goprod/src/git.itch.ovh/itchio/wharfd/jobs/task_apply.go:197
runtime.goexit
	/usr/local/go/src/runtime/asm_amd64.s:2361
Could not preload file 796 (res/music/FM1_nodrums.wav)

The thing is that EOF is a normal/expected error in some cases, just not when opening a file? I'd have to investigate more.

little update on this, it appears the default http client gives us a connection reset by peer error:
func main() {
	url := "http://api.localhost.com:8080/games/28/uploads"

	_, err := http.Get(url)
	log.Printf("err = %+v", err)

	c := timeout.NewDefaultClient()
	req, err := http.NewRequest("GET", url, nil)
	must(err)

	_, err = c.Do(req)
	log.Printf("err = %+v", err)
}

Output:
☁  dialtest  go run main.go
2018/11/30 19:49:33 err = Get http://api.localhost.com:8080/games/28/uploads: read tcp 192.168.1.29:39228->192.168.1.28:8080: read: connection reset by peer
2018/11/30 19:49:33 err = Get http://api.localhost.com:8080/games/28/uploads: EOF

Ok it appears it's not idletiming's fault:
☁  dialtest  go get && dialtest
======================
default:
Get http://localhost.com:8080: read tcp 192.168.1.29:49146->192.168.1.28:8080: read: connection reset by peer
Get http://localhost.com:8080: read tcp 192.168.1.29:49148->192.168.1.28:8080: read: connection reset by peer
Get http://localhost.com:8080: EOF
Get http://localhost.com:8080: read tcp 192.168.1.29:49152->192.168.1.28:8080: read: connection reset by peer
Get http://localhost.com:8080: read tcp 192.168.1.29:49154->192.168.1.28:8080: read: connection reset by peer
Get http://localhost.com:8080: read tcp 192.168.1.29:49156->192.168.1.28:8080: read: connection reset by peer
Get http://localhost.com:8080: EOF
Get http://localhost.com:8080: EOF
Get http://localhost.com:8080: EOF
Get http://localhost.com:8080: EOF
======================
timeout:
Get http://localhost.com:8080: read tcp 192.168.1.29:49166->192.168.1.28:8080: read: connection reset by peer
Get http://localhost.com:8080: read tcp 192.168.1.29:49168->192.168.1.28:8080: read: connection reset by peer
Get http://localhost.com:8080: EOF
Get http://localhost.com:8080: read tcp 192.168.1.29:49172->192.168.1.28:8080: read: connection reset by peer
Get http://localhost.com:8080: read tcp 192.168.1.29:49174->192.168.1.28:8080: read: connection reset by peer
Get http://localhost.com:8080: EOF
Get http://localhost.com:8080: read tcp 192.168.1.29:49178->192.168.1.28:8080: read: connection reset by peer
Get http://localhost.com:8080: read tcp 192.168.1.29:49180->192.168.1.28:8080: read: connection reset by peer
Get http://localhost.com:8080: read tcp 192.168.1.29:49182->192.168.1.28:8080: read: connection reset by peer
Get http://localhost.com:8080: read tcp 192.168.1.29:49184->192.168.1.28:8080: read: connection reset by peer

Running butler cp on that url a couple times is interesting, connection reset is definitely detected as a network error, but EOF isn't, so it either fails immediately or retries:

repo: itchio/butler

license: mit

license_source: bigquery


text:
Showing Full Length of file

Is there a way for me to show the current line as well as the total number of lines in the current buffer? I would love for it to say 023/106 if I was on line 23 and the file was 106 lines long.
Thanks!

Use line('.') . '/' . line('$').

Would I have to add that manually somewhere? Is there no way to add it directly within the lightline config? As such:
'left': [ [ 'mode', ], [ 'fugitive', 'readonly', 'filename' ] ],
'right': [ [ 'syntastic', 'lineinfo', "line('.') . '/' . line('$')" ], [ 'filetype' ] ]

I'm fairly new to editing my vimrc files, so I'm a bit confused where I should be adding this. Any help would be much appreciated.

Please read README or doc. The following examples should work for you. Choose the one you like.
let g:lightline = {
      \ 'component': {
      \   'lineinfo': "%{line('.') . '/' . line('$')}",
      \ },
      \ }

let g:lightline = {
      \ 'component': {
      \   'lineinfo': "%{printf('%03d/%03d', line('.'),  line('$'))}",
      \ },
      \ }

let g:lightline = {
      \ 'component_function': {
      \   'lineinfo': "MyLineinfo",
      \ },
      \ }
function! MyLineinfo() abort
  return line('.') . '/' . line('$')
endfunction

let g:lightline = {
      \ 'component_function': {
      \   'lineinfo': "MyLineinfo",
      \ },
      \ }
function! MyLineinfo() abort
  return printf('%03d/%03d', line('.'),  line('$'))
endfunction

let g:lightline = {
      \ 'active': {
      \   'right': [ [ 'syntastic', 'mylineinfo' ], [ 'filetype' ] ],
      \ },
      \ 'component_function': {
      \   'mylineinfo': "MyLineinfo",
      \ },
      \ }
function! MyLineinfo() abort
  return line('.') . '/' . line('$')
endfunction

I did, in fact, read the whole README. Sometimes its just difficult to not only know where to write what you want, but how to format it, correct syntax, etc. Especially if you're a beginner. Thank you for your help though, I really appreciate it.

authors: indiesquidge itchyny


text:
Replace chashmap with dashmap

The chashmap dependency has lead to dependabot alerting1 about a vulnerability in a transitive dependency. Looking at chashmap's repository it looks to me like it's not very well maintained.
On the other hand, dashmap looks great and should be a good replacement for chashmap and chashmap-async. Even though dashmap does not yet support async locks2, the maintainer states that synchronous locks "are also fine to use in async as per tokio docs"3.

Fixes https://github.com/itchysats/itchysats/security/dependabot/35.

bors r+

repo: itchysats/itchysats

license: MIT


text:
Move Quote and CfdOrder projections inside projection actor

This task is a major one, so I'm submitting in stages to make it easier for both reviewers and myself (hopefully less rebase conflicts)
Still need to be done:

connected takers (will be replaced by "counterparties")
Cfds (will incorporate all logic of CfdWithAuxData)

bors r+

bors retry


text:
Modify controller's Helm chart to create a metrics' ConfigMap consistent with the new metrics definition

Our Helm chart and pre-compiled yaml installation files create the ConfigMap iter8config-metrics with our metrics definition.

@sushmarchandran Where is iter8-KUI picking up the configmap from? Are you working with your own private configmap?

@sriumcp iter8-KUI gets the configmap from the user's current kube config using kubectl get configmaps -n iter8 iter8config-metrics -o yaml

Ok... but how is the user's configmap populated in the cluster? Is it something iter8 installation already takes care of? Or do you manually create and populate the configmap?

This is already fixed in https://github.com/iter8-tools/iter8/blob/master/install/helm/iter8-controller/templates/metrics/iter8_metrics.yaml

@sriumcp Installing iter8-controller should install the basic configmap from the helm chart. We do not manually create the configmap. After that, the user can edit it in KUI or directly using kubectl edit

authors: fabolive kalantar sriumcp sushmarchandran


text:
index: checkout/fetch: fix cloud versioning

Related https://github.com/iterative/dvc/issues/9584

Codecov Report
Patch coverage: 50.00% and project coverage change: +0.10 :tada:

Comparison is base (c162110) 61.42% compared to head (8a867bd) 61.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   61.42%   61.53%   +0.10%
==========================================
  Files          54       54
  Lines        3767     3751      -16
  Branches      676      673       -3
==========================================
- Hits         2314     2308       -6
+ Misses       1313     1304       -9
+ Partials      140      139       -1

Impacted Files
Coverage Δ

src/dvc_data/index/checkout.py
41.12% <0.00%> (ø)

src/dvc_data/index/index.py
66.27% <ø> (+0.82%)
:arrow_up:

src/dvc_data/index/fetch.py
69.23% <100.00%> (+1.14%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

authors: codecov-commenter efiop

repo: iterative/dvc-data


text:
Stale secret deletion

It looks like the following GitHub Actions secrets aren't being used in any of your workflows, at least on the default branch:

GS_CREDS

Please ping @iterative/security before 2023-09-22 if you'd like to preserve them.

--assume-yes

repo: iterative/dvc-gs


text:
link check: CI verision does not work properly

Example
https://dvc.org/uploads/images/2020-02-10/image.png
was detected here:
https://app.circleci.com/pipelines/github/iterative/dvc.org/2946/workflows/f15ce218-150d-4504-a5a3-647e8e721f43/jobs/2994

@casperdcl
I think a few things are wrong with these scripts:

changed="$differ --name-only :^redirects-list.json"

should it be
changed=$("$differ --name-only :^redirects-list.json" )

Here:

$(dirname "$0")/link-check.sh <($differ -U0 -- "$file" | grep '^\+')

This a nice stuff, but I think it creates a temp fd that you can read only once - means that only the first link from the diff is detected.
Not sure if there are any other problems ...

Also,
sed -nE 's/.*href=["'"'"'](\/[^"'"'"']+?)["'"'"'].*/\1/p' "$@" | xargs -n1 -II echo ${base_url}I

sed on Mac does not like +? - what was your intention here?

changed="$differ --name-only :^redirects-list.json"

should it be
changed=$("$differ --name-only :^redirects-list.json" )

Absolutely not. No idea what this is. Definitely not a valid command. Accidental garbage committed in 847d4ad84b7870c104573bec ? @pavelgrinchenko did you mean to do this? The original line was simply: changed="$($differ --name-only)"
Were you trying to exclude the redirects-list.json file? (In that case you should use the same method used to exclude the exclude-links.txt file.)

$(dirname "$0")/link-check.sh <($differ -U0 -- "$file" | grep '^\+')

This a nice stuff, but I think it creates a temp fd that you can read only once - means that only the first link from the diff is detected.

Yes, I was very aware of this and opted for lazy programming since it's only ever an issue with running on git-diffs (a bit of extra pain for devs to fix one link at a time if there are multiple broken links in a single diff). Can definitely fix this.

Absolutely not. No idea what this is. Definitely not a valid command.

gotcha

Were you trying to exclude the redirects-list.json file?

yes, it looks like so

In that case you should use the same method used to exclude the exclude-links.txt

for redirects probably it's better to make an exception and exclude it in the script?

Yes, I was very aware of this and opted for lazy programming since it's only ever an issue with running on git-diffs

got it, as well ... if it is too much effort - let's keep it as is

sed on Mac does not like +? - what was your intention here?

Similar to https://github.com/iterative/dvc.org/issues/1123#issuecomment-614900920, this was never intended to be run locally, and certainly not on a mac.
Could probably replace +? with *?. The intention is to convert these two cases:

href="/relative-url" => https://dvc.org/relative-url
href='/relative-url' => https://dvc.org/relative-url

Using *? would mean

href="" => https://dvc.org/

rather than (previously)

href="" => `` (i.e. not tested)

I don't have particularly strong opinions on this.

for redirects probably it's better to make an exception and exclude it in the script?

Yes I think we're both talking about the same thing. To be clear:

exclude-links.txt defines links to skip checking
the whole exclude-links.txt file itself is never checked
I'm suggesting also having the whole redirects-list.json file itself never checked

I'm suggesting also having the whole redirects-list.json file itself never checked

yep, that would be great

I don't have particularly strong opinions on this.

yep, same. But it looks it is the only thing (if pcre is installed and it's quite easy) that prevents this script from running on Mac (granted you didn't have intention to support it locally, but even for devs to debug the script itself you have to run it at least somehow ).
Also, forgive me my  lack of regex knowledge, but why can't we just use + there (without making it lazy)?

Btw, I think it would be great for exclude-list to support path to a file to exclude. Again, if it's not that much effort. It's not nice to hard code some file within the script itself.

Were you trying to exclude the redirects-list.json file?

Yes. Why it works: https://stackoverflow.com/questions/5685007/making-git-log-ignore-changes-for-certain-paths/21079437#21079437
But you definitely can handle it in another way if you think it would be better

yes, it's missing a crucial -- and also probably we should have a file-exclusion list as well as a link-exclusion list. Will fix.

Also, forgive me my lack of regex knowledge, but why can't we just use + there (without making it lazy)?

from the original #958, it's called recursive/balancing groups regex. Techically only .NET has full balancing groups support though some things including pcre support recursion. There's been recent work on https://pypi.org/project/regex/ which means pip install regex may potentially work, but this would still 1. require python and 2. potentially not work (the last time I tried the regex lib it didn't have the features required).

@casperdcl
echo 'href="/"'| sed -nE 's/.*href=["'"'"'](\/[^"'"'"']+)["'"'"'].*/\1/p'
outputs nothing (not tested)
echo 'href="/relative-url"'| sed -nE 's/.*href=["'"'"'](\/[^"'"'"']+)["'"'"'].*/\1/p'
outputs:
/relative-url
If that was the intention, what is the case we need the +? for? That's what I'm still missing probably.

oh I thought you were talking about +? => *?.
If you mean dropping the ?, that's fine. I think you would still need to replace * => + for macs, though.

+? -> + works for me on Mac

curious, ok. I've seen reports in the past where mac users needed * => +. Anyway will fix.

authors: casperdcl pavelgrinchenko shcheklein


text:
metrics: document behavior of accepting any parsable file

After iterative/dvc#4446 dvc metrics commands accept any viable target, metric file does not have to be specified in dvc.yaml.
plots has this functionality already documented it #1800.
Related to #1809, iterative/dvc#4761

Is this still relevant @pared @dberenbaum ? Thanks

@jorgeorpinel yes, it is
in https://dvc.org/doc/command-reference/metrics#description we imply that one needs to mark the output as metric in order to use dvc metrics command on it. This is not a requirement. I don't think that's super important to mention that it works on files not specified as metrics, though it would be good to mention it. It shouldn't be a big change, sorry for leaving it to hang for so long.

Looks like this is already mostly done per https://github.com/iterative/dvc.org/pull/3387#pullrequestreview-924066307 but thanks for #3387 as well! Lmk if you need help finishing that one up. Closing this.

authors: jorgeorpinel pared


text:
app: sort es6 imports

Currently there's not much order in js file imports. Some files group them with comments or spaces in between e.g.
https://github.com/iterative/dvc.org/blob/9c8cc540cfbd004db9ac3747bd56b6ddc328ed24/pages/doc.js#L3-L24
or
https://github.com/iterative/dvc.org/blob/9c8cc540cfbd004db9ac3747bd56b6ddc328ed24/src/Documentation/SidebarMenu/SidebarMenu.js#L1-L14
I suggest we remove all these comments, which don't really add any value, and apply this ESLint rule: https://eslint.org/docs/rules/sort-imports

@jorgeorpinel 👍 let's try.

Alright, I added the rule and ran eslint --fix pages src in 327d5837 but this only fixes some of the problems found by it. (Prettier/Restyled can't fix this either.)
Most issues have to be solved manually and are still outstanding, so I left the rule with "warn" level (not "error"), so it doesn't make the CI checks fail. This means unfortunately no one will ever notice these warnings (they're not even displayed by lint-staged when it runs ESLint, since warnings don't cause it to exit with a non-zero code and the output is hidden).
Should it be mandatory instead? This way it's really only useful if you manually run yarn lint-check and fix manually.

Also, VSCode has a sort-imports extension that fixes the problems eslint --fix can't. We could add it as a recommendation in the docs contrib guide instead, or on top of making the ESLint rule mandatory.

Note that it also applies this and this styles.

@jorgeorpinel @shcheklein hi guys, missed the discussion. I agree that the old sorting system was not ideal, but current version in master is even more chaotic and hard to work with.
For example docs.js:
import React, { useCallback, useEffect, useState } from 'react'
import { getItemByPath, structure } from '../src/utils/sidebar'

import Error from 'next/error'
import Hamburger from '../src/Hamburger'
import { HeadInjector } from '../src/Documentation/HeadInjector'
import Markdown from '../src/Documentation/Markdown/Markdown'
import Page from '../src/Page'
import PropTypes from 'prop-types'
import RightPanel from '../src/Documentation/RightPanel/RightPanel'
import Router from 'next/router'
import SearchForm from '../src/SearchForm'
import SidebarMenu from '../src/Documentation/SidebarMenu/SidebarMenu'
import fetch from 'isomorphic-fetch'
import kebabCase from 'lodash.kebabcase'
import { media } from '../src/styles'
import styled from 'styled-components'

Libraries are sorted in the middle of our local files. Utils are sorted in between components, styles are in some random place. Also sorting algorithm is pretty strange: Right now it is using only "filename" for sorting, and ignores everything else. As a result ../src/Documentation/RightPanel/RightPanel and ../src/Documentation/SidebarMenu/SidebarMenu are separated by next/router and ../src/SearchForm. We really should either change sorting algorithm or revert this change.
I think at least we want to have all npm libraries grouped before our own files and if we want to sort our own files we want to use the full path and not only filename.

P. S. Also I don't understand how it sorted isomorphic-fetch and lodash.kebabcase to their current position at all.

current version in master is even more chaotic... For example docs.js... Libraries are sorted in the middle of our local files... Utils are sorted in between components, styles are in some random place... (etc.)

May not be obvious what the ordering is based on but we're just using default https://eslint.org/docs/rules/sort-imports now.

Right now it is using only "filename" for sorting, and ignores everything else

Not exactly. Here's the rule's description:

This rule checks all import declarations and verifies that all imports are first sorted by the used member syntax and then alphabetically by the first member or alias name...
There are four different styles and the default member syntax sort order is:

none - import module without exported bindings.
all - import all members provided by exported bindings.
multiple - import multiple members.
single - import single member.

There's more linked documentation explaining the criteria, it also has to do with which imports have side-effects from what I remember, and other considerations.

and hard to work with

Why harder though? You just add the import and ESLint keeps it sorted for you.

We really should either change sorting algorithm or revert this change.

Maybe just changing the rules's config will yield a nicer result? Open to improvements and suggestions of course. But the change is part of a huge PR (#882) unfortunately, so not feasible to just revert at this point.

@jorgeorpinel so, not sure how is it different. It looks like it's indeed an alphabetical sort - which looks like random to be honest.
We should have disabled ignoreDeclarationSort most likely.

I've reopened it to keep discussion going.

It's different in that there is a criteria now, and that it gets enforced automatically.
We can definitely try to improve the configuration so the automatic sorting criteria is more obvious and the result looks nicer.

@jorgeorpinel having a single standard is great, but not every criteria can be considered reasonable. I agree with @iAdramelk that sorting by name == random and it makes it hard to work with (read and understand code), hard to maintain it manually, etc.

We should have disabled ignoreDeclarationSort most likely.

I think you mean set it to true (It's false by default). Yes, that should prevent the alphabetical sorting.

having a single standard is great, but not every criteria can be considered reasonable... sorting by name == random and it makes it hard to work with (read and understand code)

So the main complaint is about alphabetical sort, right? { "memberSyntaxSortOrder": ["none", "all", "multiple", "single"] } seems fine to you? (See https://eslint.org/docs/rules/sort-imports#membersyntaxsortorder)
In any case, since reverting automatically isn't really an option at this point, we'd have to manually re-sort all the imports. I'm happy to work on it but I need to know what the criteria should be because you guys have clearly stated what's wrong with the default ESLint one, (and maybe its obvious to you) but I don't know what the criteria should be.

p.s. actually I checked and fortunately, the commits that changed this in that big PR are consecutive: https://github.com/iterative/dvc.org/compare/43303c0...b633778 so it may be possible to revert with git revert? Not sure. But it would bring back al the unnecessary comments between import statements.

I think you mean set it to true (It's false by default)

Yes

but I don't know what the criteria should be.

I would expect them to be split into block - third party libraries as a separate block and always comes first or last (?), internal imports spilt into components and everything else at least (utils, constants). Not sure if we need to split anything further. @iAdramelk should have a better idea.
Multiple members from the same component - probably one import.

But it would bring back al the unnecessary comments between import statements.

it should be easy to just remove those comments

@jorgeorpinel @shcheklein
About my problems. I will add here an example of how I usually sort dependencies in my projects (it's slightly different from dvc.org) and describe why I prefer it.
Just resorting example above.
Current:
import React, { useCallback, useEffect, useState } from 'react'
import { getItemByPath, structure } from '../src/utils/sidebar'

import Error from 'next/error'
import Hamburger from '../src/Hamburger'
import { HeadInjector } from '../src/Documentation/HeadInjector'
import Markdown from '../src/Documentation/Markdown/Markdown'
import Page from '../src/Page'
import PropTypes from 'prop-types'
import RightPanel from '../src/Documentation/RightPanel/RightPanel'
import Router from 'next/router'
import SearchForm from '../src/SearchForm'
import SidebarMenu from '../src/Documentation/SidebarMenu/SidebarMenu'
import fetch from 'isomorphic-fetch'
import kebabCase from 'lodash.kebabcase'
import { media } from '../src/styles'
import styled from 'styled-components'

Preferred by me:
import fetch from 'isomorphic-fetch'
import kebabCase from 'lodash.kebabcase'
import Error from 'next/error'
import Router from 'next/router'
import PropTypes from 'prop-types'
import React, { useCallback, useEffect, useState } from 'react'
import styled from 'styled-components'

import { HeadInjector } from '../src/Documentation/HeadInjector'
import Markdown from '../src/Documentation/Markdown/Markdown'
import RightPanel from '../src/Documentation/RightPanel/RightPanel'
import SidebarMenu from '../src/Documentation/SidebarMenu/SidebarMenu'
import Hamburger from '../src/Hamburger'
import Page from '../src/Page'
import SearchForm from '../src/SearchForm'

import { getItemByPath, structure } from '../src/utils/sidebar'

import { media } from '../src/styles'

There are a few separate groups. Components inside the group are sorted by full import path and not the file name.
When I open such file I can understand a few things from the start:

By looking at the global dependencies, I can see:

That this is a React component with styles and with props.
The number of external dependencies (if there is a lot of them it is a good flag for refactoring, for example, I'd like to remove lodash in the future to reduce our bundle size).
That it uses some external Next stuff that I'm refactoring in other PR right now.

By looking at the component list, I can understand what this component consists of.
A lot of imported components in the folder /Documents/ tells me that there is a lot of intersection between this file and that folder and that this is probably a right place for the refactor (probably make one component at the root of /Document/ folder and import it once it instead of importing them all one by one)
Looking for the block with stuff like ./style.js or ./image.png (not in this example) I can understand which parts this component has.

Then I edit this file I:

Easily understand if the library or component is already imported, or I need to add it.
Know where to find import that I need to remove. (Ok, the linter will show this one, but still)
Know there to add new import (I tried to resort file in a new way manually with my branch and gave up after five tries or so).

With a new structure I can't do any of this stuff. Also, this is my first time seeing it in the real project, and none of the popular eslint presets (like airbnb or standard) are using it, so I'm not sure if we can call it industry standard or best practice.

@jorgeorpinel what have we decided on this?

I vote for disabling that auto sort asap, reverting if possible some changes (does it make sense, will you be able to merge @iAdramelk ?), and keep rule in mind that Alex described while preserving reasonable sorting manually. As second-order task - check if there are better tools that can understand semantics and maintain a reasonable order.

authors: iAdramelk jorgeorpinel shcheklein


text:
how: new (sub)section (How To's)

It seems from several open issues that we may need a section or subsection somewhere in the docs to provide certain "how to" guides. For example, these are the issues with "how to" in their titles atm:

UPDATE: See https://documentation.divio.com/how-to-guides/#how-to

[x] Organize existing how-to material into the new section (some may be under guides now).
[x] explain how to "undo" 'dvc add' + other "how to undo mistakes" recipes #625
[x] commit: add example on how to add missing dependency to existing pipeline #612
[ ] how to update tracked directories (part of #3297)
[ ] https://github.com/iterative/dvc.org/issues/1079 ?

Other ideas:

search old "how to" questions in dvc repo e.g. https://github.com/iterative/dvc/issues/599, forum, etc.
cmd ref: improve run and commit / how to add output without re-running stage? #460
"How to remove data" — what other ways to remove data (other than un-doing add) are there?
"How to host a public DVC project" (private-write, public-read)
"How to uninstall dvc" for both binary and pip packages #65
This https://github.com/iterative/dvc.org/pull/732#pullrequestreview-306762834 discussion:

we'll have to introduce a how to section soon... May be we can move things like "Running on Windows" into this section

Also, this https://github.com/iterative/dvc.org/pull/868#pullrequestreview-338379858 comment:

Parallel stage execution  from the dvc repro cmd ref can be probably moved to a How to section, with a link to it from the cmd ref

How tos on dvc init --no-scm usage? See https://github.com/iterative/dvc.org/issues/100#issuecomment-657783092

Let's analyze this list, look for any others, and see whether it makes sense to have a dedicated how-to section, or whether an existing section of the docs e.g. use-cases or specific command references or user guides can cover all of these.

💡 If we do need this new section, perhaps it could live near the new Troubleshooting section (in User Guide).

Can we expand the troubleshooting section by researching and discovering known errors and beginner mistakes while using DVC to make a list, and then analyze the formed list to make a dedicated how-to page with information pulled from the docs for better access?
I'd like to participate in the first project for this year's edition of GSoD and DVC is something that I have used and had some experience with.

Hey @PseudoNerd!
This epic issue is more about a proposed How to section (to contain several pages, each one a how-to) and less about the troubleshooting guide which is a single page where we plan to add more known problems. Both things need some work indeed and/or maybe they could be merged. Perhaps a good topic for a GSoD proposal.
For now I would encourage you to investigate smaller docs issues to get more familiar with DVC and our process 🙂
I'll email you a longer reply about GSoD.

Hey,
My name is Manthan Admane and I am in my senior year of Computer Engineering undergrad.
I would like to work on "How To section" project idea under GSoD2020 and contribute to the community.
As suggested:

For now I would encourage you to investigate smaller docs issues to get more familiar with DVC and our process

I'll start with getting familiar with fixing and exploring smaller issues on DVC issues.
Looking forward to it.

Hi @MisterAwesome23 OK. Please email your GSoD intro again to info@dvc.org so we have it on record. I'll send you an email with guidance over there. Best

While going through the docs and going through the issues that could make up the contents of this section, I realized that the stack overflow page for dvc can add to this list of potential how-tos. I made this search to find a handful of questions that could be helpful in making a how-to guide. More than 20 different questions were found out of which some are mentioned here.

Let's analyze this list, look for any others, and see whether it makes sense to have a dedicated how-to section, or whether an existing section of the docs e.g. use-cases or specific command references or user guides can cover all of these.

If there is to be a dedicated how-to section in the docs then it should reflect the order of the levels present in the existing sections and have them internally linked to the specific how-to. Furthermore, a single how-to question(guide) will often refer to a set of dvc commands and use cases, so having them linked internally is a more comprehensive way of going through the documentation which has already been laid out.
This is why it seems fitting to have a dedicated section for the how-to guide after the command reference section of the docs.
This section could have a link to it in the troubleshooting page as well.
The pages in the tutorials and use-cases section can be absorbed into multiple how-tos by extracting relevant information.
For a much simpler example,
Q. How to track files and directories in dvc?
Ans. You can use the dvc add command to start tracking files while using dvc. Here is an example of how to track a file and here is how you can track a directory in dvc by using the add command.
I went through various youtube links on seminars by Dmitry Petrov on youtube to understand the core of DVC so that I could understand dvc better. I'm relatively new to dvc and I feel that to be able to build a more comprehensive how-to section, communication with the developers and the community will be very helpful.

I made this search (https://stackoverflow.com/questions/tagged/dvc) to find a handful of questions that could be helpful in making a how-to guide.

Good idea. We can also review recent Monthly Gems blog posts e.g. https://dvc.org/blog/may-20-community-gems. But these small/specific questions are not enough for how-tos. We would need to find patterns among them and extrapolate larger how-to guides that cover most of these.

a dedicated how-to section in the docs then it should reflect the order of the levels...

I don't know if I understood this explanation. Maybe something more graphical proposal or even a draft PR to showcase your suggestion would be better.

For a much simpler example,
Q. How to track files and directories in dvc?
Ans...

This looks more like a F.A.Q. Again, I think we need more complex scenarios for how-to versions, each one with a page. Many proposals are already listed in the description of this issue.
However @PseudoNerd, this epic is still too big right now, as mentioned in https://github.com/iterative/dvc.org/issues/899#issuecomment-628324853. It would be great to have a bit more experiences working with you on smaller issues and circle back on this a bit later during the GSoD proposal stage.

communication with the developers and the community will be very helpful

You can always ask questions and get help on Discord. You should have all the info. you need in your email but please ping me otherwise.

a dedicated how-to section in the docs then it should reflect the order of the levels...

I don't know if I understood this explanation. Maybe something more graphical proposal or even a draft PR to showcase your suggestion would be better.

For a much simpler example,
Q. How to track files and directories in dvc?
Ans...

This looks more like a F.A.Q. Again, I think we need more complex scenarios for how-to versions, each one with a page. Many proposals are already listed in the description of this issue.
However @PseudoNerd, this epic is still too big right now, as mentioned in https://github.com/iterative/dvc.org/issues/899#issuecomment-628324853. It would be great to have a bit more experiences working with you on smaller issues and circle back on this a bit later during the GSoD proposal stage.

communication with the developers and the community will be very helpful

You can always ask questions and get help on Discord. You should have all the info. you need in your email but please ping me otherwise.

Hi, I am interested in doing this for Google Season of Docs 2020. I have contributed to Public Lab in some freelancing contracts, Google Code In administrative services, Google Summer of Code 2018 Internship and Google Summer of Code 2019 mentorship in Ruby on Rails, HTML, CSS and Javascript. I have also done internship at Google, Hyderabad in android. I have knowledge of C++ & Java too. I have published one research paper in the field on NLP and other research paper is under review. I was department rank 1 in my branch in my college DTU, India.
I will start with pushing some minor documentation patches soon. Thanks

There's issues for the couple check boxes left. Many of the other ideas are great but this should be done as we update existing docs (consider extracting how-to parts of guides/refs/etc into how-to section).

authors: MisterAwesome23 PseudoNerd SidharthBansal jorgeorpinel


text:
Workflow: Missing guidance for splitting datasets

In many practical machine learning workflows, splitting a dataset into subsets is a common operation.
For example, in the data-centric ai competition 2 different splits (train, validation) are expected to be submitted.
Different strategies for generating those splits might be tried and I would expect LDB to support these iterations.
I didn't find any guidance on how to perform these splitting iterations as part of the LDB workflow. Does the recommended workflow depend on https://github.com/iterative/ldb/issues/88 ?

The way I currently implemented is by using --pipe and a python "constant" as source of truth:

ldb_base_filter.py
import re
import json

VALIDATION_PATTERN = "|".join([
    ".+ac13baee-ce5d-11eb-b317-38f9d35ea60f",
    ".+ab45c99a-ce5d-11eb-b317-38f9d35ea60f",
    ...
    ".+af6ca11a-ce5d-11eb-b317-38f9d35ea60f"
])

def include_matches(input_str, include_pattern):
    for data_object_hash, data_object_path, _ in json.loads(input_str):
        if re.match(include_pattern, data_object_path):
            print(data_object_hash, flush=True)

def exclude_matches(input_str, include_pattern):
    for data_object_hash, data_object_path, _ in json.loads(input_str):
        if not re.match(include_pattern, data_object_path):
            print(data_object_hash, flush=True)

ldb_train_filter.py
#!/usr/bin/env python
import sys
from ldb_base_filter import exclude_matches, VALIDATION_PATTERN

if __name__ == "__main__":
    exclude_matches(sys.stdin.read(), VALIDATION_PATTERN)

ldb_val_filter.py
#!/usr/bin/env python
import sys
from ldb_base_filter import include_matches, VALIDATION_PATTERN

if __name__ == "__main__":
    include_matches(sys.stdin.read(), VALIDATION_PATTERN)

Using as follows:
$ ldb stage ds:numerals-train
$ ldb add ds:numerals--pipe ../ldb_train_filter.py
$ ldb commit

$ ldb stage ds:numerals-val
$ ldb add ds:numerals--pipe ../ldb_val_filter.py
$ ldb commit

The current split workflow involves the use of queries (to separate by JSON field, --limit (by count), or --tag (by tags).
We might want to give explicit examples. Also one idea is to address multi-stage splits by recipes.

authors: daavoo volkfox

repo: iterative/ldb-resources


text:
API_URL is added to UI_URL if no schema provided

When I run install.sh without https/https part in API_URL variable, then API_URL is added to BACKEND_URL during authorization.
Environment:

Ubuntu 18.04.
docker-compose 1.28.2.
GitHub OAuth app.

How to reproduce:

Register your OAuth application on github according to instructions.
Login to private Iterative repository.
Run install script with command (IP address depends on your network configuration): UI_URL=192.168.1.33:3000 API_URL=192.168.1.33:8000/api GITHUB_CLIENT_ID=<client-id> GITHUB_SECRET_KEY=<secret-key> ./install.sh
Open http://192.168.1.33:3000 in you browser.
Click log in button.

Result:
You will get 404 error and for a moment there will be the following address in address bar of your browser: 192.168.1.33:3000/192.168.1.33:8000/api/login/github
Expected behavior:
Not sure, probably one of two options:

Do not allow UI_URL, API_URL without http/https part.
Somehow mention in the docs that if no http/https part provided, then API_URL is added to UI_URL.

This is abstracted away in our new supported installation method, using the studio helm chart (requires k8s). See: https://github.com/iterative/helm-charts
In the values structure, we take care of constructing the api/ui urls from given global.host to avoid host/url confusion
The docker-compose installation method is being phased out (still supported for existing customers until we reach out with a migration path).

repo: iterative/studio-selfhosted


text:
Proper parsing of invoice lines

The current parser does not take into account that invoice lines can contain newline characters. Instead of using a custom parser for this the inbuilt .NET CSV parser is used.

I have had good luck using CsvHelper in the past, have you considered using that? Good for if you want it to have a strong model. http://www.nuget.org/packages/CsvHelper/ and https://github.com/JoshClose/CsvHelper

I am thinking that adding a third party library would be unnecessary when there is a inbuilt library that handles it pretty well.

@DanielDestino I definitely appreciate the concern over adding an external dependency. I would say it would be unnecessary today, but TextFieldParser is not portable and is not included in the .NET Core foundational libraries, meaning this code would prevent compilation targeting .NET Core. At some point in the future this will need to be rewritten to use an external portable CSV library like CsvHelper, unless TextFieldParser is added to CoreFX (not likely at this point for RTM).

I don't have a problem merging this in, but there are some conflicts you need to resolve first.
We can upgrade to another library later if it becomes necessary.

Conflicts fixed, please merge :)

This merge solves a problem when parsing an invoice with no itemlines (CsvLineItems == null), which throws an NullPointerException in Invoice.cs line 235

authors: DanielDestino chris2402 ithielnor paulirwin


text:
TryResolveConnect  problem

Hi Ben,
I'm trying the TryResolveConnect but I'm facing a problem.
I'm using Luxembourg country and car vehicle with classifications profile.
If you try with the following set of coordinates TryResolveConnect failed (could not resolve ....) with the first one, but if you try to calculate the route is ok.
lat1 = 49.903820 lng1 = 6.119916
lat2 = 49.573916 lng2 = 5.937065
Note: if you use the fastest  profile everyrhing is ok.

Hmm ok, that could be due to the default parameters in TryResolveConnected and TryCheckConnectivity. The default there is distance. I would advise for now to use another profile to check connectivity and then use classifications to calculate the route. When the other profiles are connected, classifications profile is too, always.
For reference the problem is here:
https://github.com/itinero/routing/blob/d4b42bee831d9c17652dc5cc05952132e02116bc/src/Itinero/Router.cs#L151
This is a very subtle bug, thanks for catching this! 👍

There are few options to fix this:

Allow a custom radius, not just radiusInMeter, but this would be difficult to understand for users.
Allow only shortest profiles that use distance as a metric for a resolver.
Expand the profiles so it can be used with radiusInMeter.

Option 3 would change the profiles too much, option 2 is the easiest but violates the idea that you should always route and resolve using the same profile, so option1 is the best option for now.
This does not even require a change in this, we only need to rename the radius parameter.
Also related to #69

option 2 is what I've done as workaround and it would be ok. Anyway option 1 is better.
Thanks,

repo: itinero/routing


text:
Dockerize app

Dockerize App
Dockerize API

Ready!


text:
[ENHANCEMENT FUNCTION] : Implement Email Sending Functionality in Backend API

Description
Currently when a user clicks on get in touch, the message is sent to the db. It would be beneficial if the message is received directly into the admin inbox
Actual Behavior
Please describe what actually happened.
Expected Behavior
Please describe what you expected to happen.
Steps to Reproduce (if applicable)

Step 1
Step 2
Step 3

Screenshots (if applicable)
Actual:
(screenshot)
Expected (highlight the part that requires changes):
(screenshot)

hey @itsmohit097 can you add the gssoc badge here, its not added in this issue


text:
14.8.1-ipsw script

I still can't figure it out, aa - what is this command in the script? Thanks
sudo aa extract -i ../payloadv2/fixup.manifest || true
sudo aa extract -i ../payloadv2/data_payload

It's a tool for manipulating Apple Archives, it was previously named yaa, so you might have to modify the script if you run an older version of MacOS.

Is that available for linux devices?

Download prebuilt IPSW

authors: DrissiReda TushckanchickBly asdfugil varette


text:
Change text font

Is there a way to change the view text font?

@KhalidElSayed how about get the textview and then set the typeface?

add a selector color for textColor

get getLargeLabelAt getSmallLabelAt

authors: KhalidElSayed ittianyu luongvo

repo: ittianyu/BottomNavigationViewEx


text:
Splitting the database to a new droplet

This should be done to keep the database persistent. We need to first extract the data already inserted into the database

We did this and at a later point reverted to use the same droplet when using docker swarm


text:
Fix config example

Was previously missing quotes and a comma around the port, causing an error when building.

wait oops no i broke it more hang on

okay i think it's good now sorry

Missed my eye, thanks for catching this! ❤

authors: itz-sarah suburbGira

repo: itz-sarah/discord-relay