text:
struct_pack 不支持自定义序列化函数吗

struct_pack 不支持自定义序列化函数吗

https://github.com/alibaba/yalantinglibs/issues/472

你看看这个是不是你想要的

你看看这个是不是你想要的

#include
#include
#include
#include "zpp_bits.h"
using namespace std;
struct Props
{
int x{};
int y{};
unsigned char* p;

constexpr static auto serialize(auto& archive, auto& self)
{
	using archive_type = std::remove_cvref_t<decltype(archive)>;
	if constexpr (archive_type::kind() == zpp::bits::kind::in) {
		std::vector<unsigned char> vec;
		auto result = archive(self.x, self.y, vec);
		unsigned char* ptr = vec.data();;
		self.p = new unsigned char[vec.size()];
		std::copy(vec.begin(), vec.end(), self.p);
		return result;
	}
	else if constexpr (archive_type::kind() == zpp::bits::kind::out) {
		std::vector<unsigned char> vec(self.p, self.p + self.x * self.y);
		auto result = archive(self.x, self.y, vec);
		return result;
	}
	else {
		return std::make_error_code(std::errc::invalid_argument);
	}
}

};
struct Person
{
std::string name;
int age{};
Props props{10, 10};

};
int main()
{
auto [data, in, out] = zpp::bits::data_in_out();
Person p1{ "Person1", 25 };
Person p2{ "Person2", 35 };

p1.props.p = new unsigned char[100]();
p2.props.p = new unsigned char[100]();

p1.props.p[2] = 'H';
p2.props.p[3] = 'W';

p1.props.p[98] = 'X';
p2.props.p[97] = 'Y';

auto result = out(p1, p2);
if (failure(result))
{
	std::cout << "Failed to write data to file! " << std::endl;
}

Person p3, p4;

result = in(p3, p4);
if (failure(result)) {
	std::cout << "Failed to read data from file! " << std::endl;
}
else {
	std::cout << std::format("Read data from file: {},{},{},{}", p3.name, p3.age, static_cast<char>(p3.props.p[2]), static_cast<char>(p3.props.p[98])) << std::endl;
	std::cout << std::format("Read data from file: {},{},{},{}", p4.name, p4.age, static_cast<char>(p4.props.p[3]), static_cast<char>(p4.props.p[97])) << std::endl;
}

cout << "Hello CMake." << endl;
return 0;

}
似乎不是，类似于这种方式的方法有吗

是不是自定义实现如下方法就行了
template<struct_pack::writer_t writer_t>
void serialize_to(writer_t writer, const ZZ&zz);
template<struct_pack::reader_t reader_t>
void deserialize_to(ZZ&zz, reader_t reader);

是不是自定义实现如下方法就行了
template<struct_pack::writer_t writer_t> void serialize_to(writer_t writer, const ZZ&zz); template<struct_pack::reader_t reader_t> void deserialize_to(ZZ&zz, reader_t reader);

设计是这样的，不过目前我在忙另外一个feature，这个我尽快支持一下吧。

是不是自定义实现如下方法就行了

template<struct_pack::writer_t writer_t> void serialize_to(writer_t writer, const ZZ&zz); template<struct_pack::reader_t reader_t> void deserialize_to(ZZ&zz, reader_t reader);

设计是这样的，不过目前我在忙另外一个feature，这个我尽快支持一下吧。

辛苦了

`#include <ylt/struct_pack.hpp>
struct PropsPack
{
int x{};
int y{};
unsigned char* p{ nullptr };

};
namespace struct_pack {
template <uint64_t conf = sp_config::DEFAULT, typename Writer>
STRUCT_PACK_INLINE void serialize_to(Writer& writer, const PropsPack& self)
{
std::vector vec(self.p, self.p + self.x * self.y);
auto data_offset = writer.size();
auto info = detail::get_serialize_runtime_info(self.x, self.y, vec);
auto total = data_offset + info.size();
detail::resize(writer, total);
auto real_writer = struct_pack::detail::memory_writer{ (char*)writer.data() + data_offset };
struct_pack::detail::serialize_to(real_writer, info, self.x, self.y, vec);
}
template <uint64_t conf = sp_config::DEFAULT, typename... Args, detail::deserialize_view View>
[[nodiscard]] STRUCT_PACK_INLINE struct_pack::errc deserialize_to(PropsPack& self, const View& v, Args &...args) {
	detail::memory_reader reader{ (const char*)v.data(), (const char*)v.data() + v.size() };
	detail::unpacker<detail::memory_reader, conf> in(reader);

	std::vector<unsigned char> vec;
	auto result = in.deserialize(self.x, self.y, vec, args...);
	unsigned char* ptr = vec.data();;
	self.p = new unsigned char[vec.size()];
	std::copy(vec.begin(), vec.end(), self.p);
	return result;
}

}
int main()
{
PropsPack z{ 10, 10 };
z.p = new unsigned charz.x * z.y;
z.p[2] = 'H';
z.p[9] = 'W';

std::vector<char> result_pack;
struct_pack::serialize_to(result_pack, z);

PropsPack zz;
auto result = struct_pack::deserialize_to(zz, result_pack);

std::cout << std::format("{},{}", static_cast<char>(zz.p[2]), static_cast<char>(zz.p[9])) << std::endl;

return 0;

}`
目前这样是可以的

#pragma once

#include <vector>

#include <ylt/struct_pack.hpp>

struct PropsPack
{
	int x{};
	int y{};

	unsigned char* p{ nullptr };
};

namespace struct_pack {
	template <uint64_t conf = sp_config::DEFAULT, typename Writer>
	STRUCT_PACK_INLINE void serialize_to(Writer& writer, const PropsPack& self)
	{
		std::vector<unsigned char> vec(self.p, self.p + self.x * self.y);
		auto data_offset = writer.size();
		auto info = detail::get_serialize_runtime_info<conf>(self.x, self.y, vec);
		auto total = data_offset + info.size();
		detail::resize(writer, total);
		auto real_writer = struct_pack::detail::memory_writer{ (char*)writer.data() + data_offset };
		struct_pack::detail::serialize_to<conf>(real_writer, info, self.x, self.y, vec);
	}

	template <uint64_t conf = sp_config::DEFAULT, typename... Args, detail::deserialize_view View>
	[[nodiscard]] STRUCT_PACK_INLINE struct_pack::errc deserialize_to(PropsPack& self, const View& v, Args &...args) {
		detail::memory_reader reader{ (const char*)v.data(), (const char*)v.data() + v.size() };
		detail::unpacker<detail::memory_reader, conf> in(reader);

		std::vector<unsigned char> vec;
		auto result = in.deserialize(self.x, self.y, vec, args...);
		unsigned char* ptr = vec.data();;
		self.p = new unsigned char[vec.size()];
		std::copy(vec.begin(), vec.end(), self.p);
		return result;
	}
}

#include "CMakeProject1.h"

#include <iostream>
#include <fstream>
#include <format>
#include <string>

using namespace std;

int main()
{
	PropsPack z{ 10, 10 };
	z.p = new unsigned char[z.x * z.y]();

	z.p[2] = 'H';
	z.p[9] = 'W';

	std::vector<char> result_pack;
	struct_pack::serialize_to(result_pack, z);

	PropsPack zz;
	auto result = struct_pack::deserialize_to(zz, result_pack);

	std::cout << std::format("{},{}", static_cast<char>(zz.p[2]), static_cast<char>(zz.p[9])) << std::endl;

	return 0;
}

目前这样可以正常序列化和反序列化

template<struct_pack::writer_t writer_t>
void serialize_to(writer_t writer, const ZZ&zz);
template<struct_pack::reader_t reader_t>
void deserialize_to(ZZ&zz, reader_t reader);
这个不能出现自定义类型的嵌套吗，如何才能支持自定义类型的嵌套呢

template<struct_pack::writer_t writer_t> void serialize_to(writer_t writer, const ZZ&zz); template<struct_pack::reader_t reader_t> void deserialize_to(ZZ&zz, reader_t reader);
这个不能出现自定义类型的嵌套吗，如何才能支持自定义类型的嵌套呢

你这个类型有两个维度，因此不属于https://alibaba.github.io/yalantinglibs/zh/struct_pack/struct_pack_type_system.html里面的任何一种已有的类型。
对于非类型系统的用户自定义类型支持，需要等 #472 。

template<struct_pack::writer_t writer_t> void serialize_to(writer_t writer, const ZZ&zz); template<struct_pack::reader_t reader_t> void deserialize_to(ZZ&zz, reader_t reader);
这个不能出现自定义类型的嵌套吗，如何才能支持自定义类型的嵌套呢

你这个类型有两个维度，因此不属于 https://alibaba.github.io/yalantinglibs/zh/struct_pack/struct_pack_type_system.html 里面的任何一种已有的类型，目前struct_pack允许自定义的类型必须属于类型系统中已经存在的某一种类型。
对于不属于类型系统中的用户自定义类型支持，需要等 #472 。

那目前来说有什么好的解决方法吗

template<struct_pack::writer_t writer_t> void serialize_to(writer_t writer, const ZZ&zz); template<struct_pack::reader_t reader_t> void deserialize_to(ZZ&zz, reader_t reader);
这个不能出现自定义类型的嵌套吗，如何才能支持自定义类型的嵌套呢

你这个类型有两个维度，因此不属于 https://alibaba.github.io/yalantinglibs/zh/struct_pack/struct_pack_type_system.html 里面的任何一种已有的类型，目前struct_pack允许自定义的类型必须属于类型系统中已经存在的某一种类型。
对于不属于类型系统中的用户自定义类型支持，需要等 #472 。

那目前来说有什么好的解决方法吗

我这两天初步支持一下吧。

template<struct_pack::writer_t writer_t> void serialize_to(writer_t writer, const ZZ&zz); template<struct_pack::reader_t reader_t> void deserialize_to(ZZ&zz, reader_t reader);
这个不能出现自定义类型的嵌套吗，如何才能支持自定义类型的嵌套呢

你这个类型有两个维度，因此不属于 https://alibaba.github.io/yalantinglibs/zh/struct_pack/struct_pack_type_system.html 里面的任何一种已有的类型，目前struct_pack允许自定义的类型必须属于类型系统中已经存在的某一种类型。
对于不属于类型系统中的用户自定义类型支持，需要等 #472 。

那目前来说有什么好的解决方法吗

我这两天初步支持一下吧。

好吧，非常感谢你的帮助

任意类型的自定义序列化已实现，见 #514

repo: alibaba/yalantinglibs


text:
Feature/fix polar db endpoint

Feature/fix polar db endpoint.

测试：

source: gharchive/pull-request

license: MIT

license_type: permissive

license_source: github-api


text:
Rename from matherhorn to mathegral

[ ] Renames in code
[ ] Rename repository
[ ] Reconfigure Cloudflare project  (Setup new Cloudlflare project w/ proper name w/ #24)
[ ] Redesign favicon

@MathAdmin Here some design proposals for the logo/favicon. Anything you like?

New logo version

Sehr cool!
Von meinem Xperia™ von Sony-Smartphone gesendet
---- xandrun schrieb ----

New logo version

--
Reply to this email directly or view it on GitHub:
https://github.com/alimfeld/matherhorn/issues/23#issuecomment-1027903823
You are receiving this because you were mentioned.
Message ID: @.***>

Version with old blue: #3272B7

source: gharchive/issue

authors: MathAdmin alimfeld xandrun

repo: alimfeld/matherhorn


text:
原理的jarslink重定向到这里？但是代码怎么完全不一致了？

原理的jarslink重定向到这里？但是代码怎么完全不一致了？
是下线了么？

@cholf  之前的是1.0版本，现在主干的分支代码是基于 SOFAArk 做的。你可以参考文档：

http://www.sofastack.tech/sofa-boot/docs/sofa-ark-readme
http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-readme

@cholf 之前的是1.0版本，现在主干的分支代码是基于 SOFAArk 做的。你可以参考文档：

http://www.sofastack.tech/sofa-boot/docs/sofa-ark-readme
http://www.sofastack.tech/sofa-boot/docs/sofa-jarslink-jarslink-readme

你好我使用的是1.0的相关版本，遇到了子jar包配置扫描范围太大的话，会导致主项目service重复扫描，然后导致找不到关联bean；
比如：项目A下面挂着两个jar文件(C,D)，A的包路径是com.sofa.service, C jar包的包路径是com.sofa.insuerance,如果我在C的xml配置<context:component-scan base-package=“com.sofa”/>,这样会导致重新加载A项目的所有注解，如果A项目的XXXService依赖一个dubbo的bean(OrderDetailService)的话，就会报NoSuchBeanDefinitionException: No qualifying bean of type [com.xxx.api.OrderDetailService] found
我的理解是两个context,所以Cjar是无法获取到已经加载到A项目context的bean的，或者说这个隔离感觉不对，不知道你们那里可以提这个问题，或者你们有遇到么，非常感谢

@cholf 非常抱歉，1.0 版本已经不维护了，我之前也没参与1.0 的维护，目前主要发展2.0 版本。

authors: QilongZhang cholf

repo: alipay/sofa-jarslink


text:
as server, we make server not be daemon

Motivation:
change
"server.daemon": true,

to
 "server.daemon": false,

Modification:
Describe the idea and modifications you've done.
Result:
Fixes https://github.com/alipay/sofa-rpc/issues/364
If there is no issue then describe the changes introduced by this PR.

+1

authors: NeGnail leizhiyuan

repo: alipay/sofa-rpc


text:
请问还会更新吗？

非常感谢提供了一个可用的库，但需要完善的地方还很多，请问还有更新打算吗？

这个模块已经快两年没有更新了，而且buggy。阿里网站上有关于OSS和RN的文章，都是用这个模块。

有很多不好用的地方，竟然不更新了，很阿里。

有什么其他的仍然在更新的第三方支持吗？用得太难受了！

authors: CloudCityxx bigshans emclab fujianjin6471

repo: aliyun/aliyun-oss-react-native


text:
Triton Engine did not auto update to new model after retraining

I saw this line in the readme:
"Notice: If we re-run our keras training example and publish a new model in the repository, the engine will automatically update to the new model."
I have a created a serving service. However, when i retrain my model with same project and task name, and publish the model once training is done, the model version deployed in triton is not updated.
May I know if this is a bug or did I misunderstand some steps?

Apologies, my mistake. My serving service was not handled by an agent.

repo: allegroai/clearml-serving


text:
Feature/implement user-set camera transform

Problem
The viewer doesn't do anything yet with the new cameraDefault data (camera position and orientation) in v2 trajectory files.
Resolves: implement set initial camera transform from data
Solution
Enable the viewer to use the cameraDefault data to set the initial camera orientation and position per user's specifications
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires updated or new tests

Key files / Change summary:

src/simularium/types.ts - Add cameraDefault to the TrajectoryFileInfoV2 interface
src/simularium/versionHandlers.ts - Add a cameraDefault block with default values to all v1 trajectories when converting to v2
src/simularium/VisGeometry.ts

Created a cameraDefault property to hold the default camera transform values initially and to hold custom values if they are received
Created a positionCamera() method which does three.js operations to position and orient the camera
Invoke positionCamera() from resetCamera() so that any time a new file is loaded or when the user clicks the Reset Camera button, the camera's position and orientation is reset to what's in this.cameraDefault in addition to the camera's OrbitControls being reset
Minor refactoring

Removed resetCameraOnNewScene property because it should just always be true (per @toloudis 's suggestion)
Renamed handleTrajectoryData() method as handleTrajectoryFileInfo() to make it more accurate and less confusing

Steps to Verify:

Download this test file. This file contains the following info in trajectoryFileInfo:

"cameraDefault":{
    "position":{
        "x":120,
        "y":0,
        "z":120
    },
    "lookAtPosition":{
        "x":0,
        "y":0,
        "z":0
    },
    "upVector":{
        "x":1,
        "y":2,
        "z":0
    },
    "fovDegrees": 90
}

Load it into our staging web site, notice you're looking at the bounding box straight-on (the camera params above don't have an effect)
Pull this branch, npm start and load it into the example viewer. Notice the bounding box is now farther away, rotated, and seen from a horizontally offset position

Note

The default fov angle specified in simulariumio  is 50 degrees. I talked with @blairlyons about this and it should be 75 degrees instead to match what's been the hard-coded default in the viewer. So I used 75 as the default. Blair will change it in simulariumio as well.
If default values were used because the file was converted from v1 to v2 or because none were specified, then simularium-viewer emits a console warning about it. I don't think this will be visible to users on the simularium-website end though -- do we need it to be?

will a streaming file from the backend use the default values until Eric adds camera data to those?

will a streaming file from the backend use the default values until Eric adds camera data to those?

Yup! Any file that doesn't have cameraDefault info will use the default values, and I checked that it was happening with streamed files

authors: blairlyons schoinh

repo: allen-cell-animated/simularium-viewer


text:
Tasks 1719-1726

Reviews: https://github.com/swarooprm/CSE576HW/pull/124

LGTM

repo: allenai/natural-instructions-expansion


text:
Seemingly unrelated instances in tasks 1669 and 1670.

The instances in tasks 1669 contain a lot of examples that don't seem related, or rather noisy. I'm not sure.
The task is to "change male-gendered words and pronouns to female-gendered ones, or add words that are female-gendered" or the other way around (in the other task). But here are some examples from instances that are not doing that:
		{
			"input": "Hello Ardin, I am Tierny. Did you get his message?",
			"output": [
				"Hello Ardin, I am Tierny"
			]
		},
		{
			"input": "The place for apprenticeship was taken by Jerome Lamy",
			"output": [
				"The apprenticeship took place in Jerome Lamy"
			]
		},
		{
			"input": "i'm doing as well as a boy can. have you heard of the guy named sylvester denton?",
			"output": [
				"I'm doing as well as a boy can. Have you heard of Sylvia Denton?"
			]
		},
		{
			"input": "As men, I bet you wish we knew how she started her career in that field.",
			"output": [
				"as a man, I wish I knew how she started her career in that field."
			]
		}

(for completeness, these were introduced in PR https://github.com/swarooprm/CSE576HW/pull/51)
Maybe for these sentences that don't have any gendered pronouns, there is nothing that needs to be done?
@narnix17 wondering if you can share your thoughts on these.

authors: Palipoor danyaljj

repo: allenai/natural-instructions


text:
Navigation for symbol search

Add symbol navigation that makes it easier for readers to go forward in back between instances of a symbol.
This issue requires:

[x] a counter for how many symbols were matched and which one was selected (e.g., "6 of 16")
[x] "next" button
[x] "back" button
[ ] hotkeys for each action

The navigation and search counter should probably be added to the PDF reader's toolbar, though this is up for discussion.

I can start working on this issue :)

@zkirby I've been ruminating on our conversation from earlier. It occurs to me that we have at least these for implementing the "next / back" search widget. I'm pretty committed to getting our next / back button to use the same search interface as pdf.js's Ctrl+F search for consistency's sake (and because I think it will be hella confusing to users if they are allowed to conduct two parallel searches, one over text and one over symbols).
In my mind, the alternatives include at least:

Hook up to the pdf.js search widget. Clear the search widget of the prior text search whenever symbol search starts. Figure out a way to insert our count of matches into the search widget.

Disable the pdf.js widget, implement our own search widget, and intercept signals from the pdf.js event bus that control our search widget when a user is doing a Ctrl+F search.

I'm secretly hoping that there's a 3rd option out there that's more elegant than either of these XD

I'm going to be logging some notes about how pdf.js "find" functionality works. First, it looks like there are two events on the event bus that are relevant: 'find' and 'updatefindmatchescount'
https://github.com/mozilla/pdf.js/blob/master/web/app.js#L1685-L1687

Second, it looks like the pdf.js viewer at some point provided support for providing your own find widget. Check out this pull request: https://github.com/mozilla/pdf.js/pull/2197
Based on a first look, it looks like one can define a unique 'ExternalServices' class for the app, which can be used to turn off the default Ctrl+F widget and substitute it with another. Here's the default external services class), and I hypothesize that we may be able to connect it to a custom "Find" widget by overriding supportsIntegratedFind, updateFindControlState, and updateFindMatchesCount

Meanwhile, the pdf_find_controller.js file looks pretty complex. It's a good indication that, especially for text search, if we don't have to rewrite the text-finding logic we will save ourselves a ton of time.

I've managed to hook into pdf.js find functionality from outside of pdf.js. The fix was, first, updating genericcom.js as described above to add external find handlers: https://github.com/andrewhead/pdf.js/commit/bd9255f81c75d75acd83943778cbf8149b48f59d
This can be tested out by cloning andrewhead/pdf.js, and then:

npm install
gulp server
Open localhost:8888/web/viewer.html in the browser
Open the web console
Execute the command: window.dispatchEvent(new CustomEvent("find", { detail: { query: "language" }}))

This last command simulates one of the many find commands that can be submitted to the pdf.js-internal find controller (see a more complete listing in that genericcom.js file)
It seems to me that the right next steps for this issue is to:

Make minimal changes to the pdf.js genericcom.js code to act as a gateway for find events
Add a React find widget that emits events in a way that genericcom.js can detect and forward to the pdf.js find controller; then update that React find widget to update its presentation with updates from the pdf.js find controller

And then, after these two steps are finished, updating the React widget to also control going back and forward over symbols in papers.

Awesome, thank you for the detailed starting point! :).
Just to make sure I understand what the desired behavior is, we expect when the users presses CTRL+F one of two things happens:

If there is no symbol selected - they are presented with the default find functionality currently present in pdf.js
If there is a symbol selected, or if they select a symbol with search open, a count appears instead of the string search and they can next/back through the existing symbol list

Or it might be helpful if you break down exactly what the interaction would be hahaha, I think I'm still a little confused how exactly a user initiates symbol search.

This is pretty close! The idea is there's 1 search widget, supporting 2 search interactions:
Interaction 1: Text Search: User types Ctrl+F. This opens up the search widget. The user can then click "next" and "back" buttons to go to the next and previous matches.
Interaction 2: Symbol Search: User clicks a symbol. This opens up the search widget. The user can then click "next" and "back" buttons to go to the next and previous matches. The typical input field for the search widget is replaced with a set of filters that can be used to fine-tune what parts of the symbol will be searched for (which should be implemented in #93).
In both cases, the search widget shows the count of matches, and the index of the currently selected match. Ctrl+F will only initiate text search.
Does that make sense? Can you think of other compelling ways to implement the interaction?

@zkirby I just added a starting point for a new find-bar that we can use for this PR. Let's do both of our development on the find-bar branch which contains the new find bar (the branch is https://github.com/allenai/scholar-reader/tree/find-bar). The find bar looks like this:

We can style it up once we have the right behavior implemented!

@zkirby I updated the find bar to plug into pdf.js's find functionality, see GIF right below:

The updated code for the find bar is in the find-bar branch.
So this means all you should need to think about is extending the FindBar component to also support symbol search. It should use the same state variables (e.g., currentMatch and matchCount). Though you may need to move those variables into ScholarReaderContext to get the job done. Lmk if you want to discuss any implementation ideas!

Awesome, I'll take a look :)

Hey quick follow up, what is the difference between an annotation and an entity?

Okay so I've spent a few hours writing some initial code and laying everything out and I think it should be very very doable to have the behavior as you've described. However, I have a few followup question that should help me finish off this PR :).

What is the difference between an entity and an annotation? Why is there a difference, and when should an entity id be used versus an annotation id? (I understand we will need to map between these in order for the finder to actually be able to fully work but I want to make sure I fully understand them)
Should one take priority, string search or symbol search? I.e., if I am in the middle of a symbol search, if I press ctrl+f should it unselect the selected symbol, keep the symbol selected but switch to string search, or do nothing until the symbol is deselected?

Thanks!

Good questions!

What is the difference between an entity and an annotation?

Entities are a type of object that was found in the paper. Symbols, citations, and sentences are all entities.  Each one corresponds to a single row in one of the database's entity tables (e.g., the symbol, citation, or sentence table). The only way to show the position of an entity, currently, is by creating an annotation for it.
Annotations are highlights that show the locations of entities, and make information about entities available when the annotation is clicked. Usually there will be one annotation for each entity. The PageOverlay loops through lists of entities, creating an annotation for each entity.

Should one take priority, string search or symbol search?

My gut instinct is that both searches should interrupt each other. That means:

I Ctrl+F in the middle of a symbol search, that symbol should be deselected and text search should begin.
If I click on a symbol during text search, the text search box should be emptied and symbol search should begin.

That said, I'm open to other ideas! That's just my first guess about what might might feel good to a user.

Interesting, what is the use case for having both annotation ids and symbol ids?

While I believe I had a good reason at some point in the past, I don't have one right now ^)^

One reason I separated it out into two IDs is that, previously, components could only figure out what entity was selected by parsing the ID for the selected annotation, which felt brittle. That led me to instead add explicit properties to the scholar reader state for what type of entity was selected, so we wouldn't need to duplicate the code for parsing annotation IDs to get entity IDs everywhere.

A future version of this tool will order symbols not by their position in the paper, but by the order they appear in the PDF markup or the LaTeX (i.e., in prose order, so that the search results don't dart back and forth between parallel columns). Here are some snippets that should be useful for doing this.
  const areSymbolsAlignedToSentences = symbols.all.some((sId) => {
    symbols.byId[sId].sentence !== null;
  });

  let symbolsToSort;
  if (areSymbolsAlignedToSentences) {
    symbolsToSort = symbols.all.filter((sId) => {
      symbols.byId[sId].sentence !== null;
    });
  } else {
    symbolsToSort = [...symbols.all];
  }

  ...

  // I don't know if the signs returned are correct yet.
  const sorted = [...symbolIds];
  sorted.sort((sId1, sId2) => {
    const sentenceId1 = symbols.byId[sId1].sentence;
    const sentenceId2 = symbols.byId[sId2].sentence;
    if (sentenceId1 === null || sentenceId2 === null) {
      return 0;
    }
    const sentence1 = sentences.byId[sentenceId1];
    const sentence2 = sentences.byId[sentenceId2];
    return sentence1.index - sentence2.index;
  });

authors: andrewhead zkirby

repo: allenai/scholar-reader


text:
Enhancement: Live Mode

First of all goaccess is a really nice tool. Thanks for that!
A feature which is currently missing and would be helpful for me is a live mode. Means an option which lets goaccess just read the new log entries and build upon this data all the metrics.
This is would be great e.g. for troubleshooting current peaks to check the requested resources and the ip(s) causing the traffic.

Thanks for the suggestion. Are you looking to filter the logs you already parsed? or simply display stats as they're appended to the access log, as in the live demo?

Filtering is another nice feature but I saw it was already requested by different people.
I am just looking for simply displaying the stats as they are appended to the log file to get the stats based on the time goaccess is running on the command line (I am using goaccess only from the command line). Goaccess should just skip parsing the old, already existing content of the log.
This is e.g. the default behavior of ngxtop.

Got it, I think this is part of issue #428.

I've pushed a commit that enables the ability to output live stats from a stream or an unclosed STDIN, i.e., tail -f. This allows to do:
tail -f access.log | goaccess --log-format=COMBINED -

or even
tail -f access.log | goaccess --log-format=COMBINED -o report.html --real-time-html -

It also opens the possibility for live data filtering from the pipe such as:
tail -f access.log | grep -i 'firefox' | goaccess --log-format=COMBINED -

One thing to note is that  tail -f will keep the pipe opened even when goaccess already has exited. For instance, tail -f syslog | grep -q 'cron' tail will exit on SIGPIPE, however it will only get SIGPIPE until an extra byte is written to the tail'd file. SIGTERM, SIGINT should close tail fine though.
Feel free to build from master to test this out, otherwise it will be pushed out in the upcoming release. Thanks.

authors: allinurl staelche

repo: allinurl/goaccess

license: mit

license_source: bigquery


text:
后台管理模板表格显示问题

后台模板中的表格页错乱，帮助页中的1、2描述重复。

产生环境

设备：（手机、平板等移动设备时填写此项）
操作系统及版本：win7旗舰32位
浏览器及版本：猎豹浏览器v5.1.77.9318
演示地址：

复现步奏

...
UA:
Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.137 Safari/537.36 LBBROWSER

你是说这块的问题？你截图白色的那块是渲染出来就那样还是你抹掉了？

确实有红圈所示问题，Chrome 上也存在，@haungzhipeng 下周抽空看一下。

am-hide-sm-only的继承问题，如下改过之后好了
@media (min-width: 1025px){
.am-hide-sm-only, .am-show-sm-up, .am-hide-sm,
.am-hide-sm-down, .am-hide-md-only, .am-show-md-up,
.am-hide-md, .am-hide-md-down, .am-show-lg-only,
.am-show-lg-up, .am-show-lg, .am-show-lg-down{
display:table-cell!important;
}
}
@media (min-width: 641px){
.am-hide-sm-only, .am-show-sm-up, .am-hide-sm, .am-hide-sm-down, .am-show-md-only, .am-show-md-up, .am-show-md, .am-show-md-down, .am-hide-lg-only, .am-hide-lg-up, .am-hide-lg, .am-show-lg-down {
display: table-cell!important;
}
}

@2282666 好的，谢谢，看来这对表格的样式也要加上。

repo: allmobilize/amazeui


text:
Improve tx request builder

          while we're touching this code, we should decompose this into a set of functions `fn will_build_legacy() -> bool` that capture our criteria for building each style of transaction. then this becomes a fallthrough if

I also think our criteria here are not most-friendly to users.

if a sidecar is set, we should ALWAYS build 4844, regardless of if legacy gas is indicated
if max_fee_per_blob_gas is set, but no sidecar/blob is set, that should be a build error
if access_list is set, we should ALWAYS build 2930, regardless of if legacy gas is indicated
if sidecar and access_list are both set throw a build error
1559 should be our default tx type in the fallthrough case. legacy should be chosen only if gas_price is set.

function should look something as follows:
if self.will_build_4844() { self.build_4844() }
else if self.will_build_2930() { self.build_2930() }
else if self.will_build_legacy() { self.build_legacy() }
else { self.build_1559() }

Originally posted by @prestwich in https://github.com/alloy-rs/alloy/pull/383#discussion_r1544689297

1559 should be our default tx type in the fallthrough case. legacy should be chosen only if gas_price is set.

agree

I can work on this.

authors: leruaa mattsse prestwich

repo: alloy-rs/alloy


text:
Badge issue

Hi,
The badge is not correct the space on the top is less than the bottom.
I have made a test using on Boostrap and there is a difference.
Green one is the adminLTe one located in the sidebar menu, the grey one is Bootstrap one.
This is maybe related to the font I don't know.

Hi
Have you found a solution to this ?

Not yet ...
It's maybe relate to the Bootstrap version...
I'm using v3.2.0
Do you have this issue too?

Yes i have a similar issue just that mine is a little bit different but it is related to the badge closed to the message box.
When i load it through ajax call like

 4

where the nombre_nouveaux_messages is updated by ajax with

 8

The badge does not appear correctly and is not lifted but appear by the side of the icon like in the image below

I dont really know why it is not lifted like normally when my ajax function loads it. Do you have a fix for that ?

ok you have a different issue.

I also have this issue with the label :(

I think that will be a great idea. I am usin Bootstrap 3.3.1 and i have updated most things to their latest version. Even jquery i am using jquery 2 if the browser is not IE 8 and below and jquery 1. If the browser is IE 8 and below. So yes updating to the latest code i think will be a great idea. I wonder Y @almasaeed2010 has not done that yet in the demo and the file to download

I have the issue with 3.3.1 too

Do you have a link where we can see your result?
Pretty hard to guess with just an image

Ok I just realized that it's ok when the letter is not capslock n and occurred when it is capslock N

Oh ok.

authors: TiagoGoddard kressly lenamtl


text:
Re-orgnized work item page object model page - to make it easier to r…

…ead and maintain.

Can one of the admins verify this patch?

authors: centos-ci ldimaggi

repo: almighty/almighty-ui


text:
Teach find_button() to find tags of type

This is in addition to the other buttons it already knows how to find:
<input type="submit">
<input type="reset">
   	<input type="image">
    <button>

Thanks for your contribution. Indeed, <button> and <input type=button> should both be able to be found.
However, could you please add tests for the new functionality and ensure the build passes?
Also, please don't include unrelated changes such as frame switch step and slow input in the same pull request. I'd be happy to review them separately.

Yes. I will add tests. (And sorry about the unrelated changes---they weren't originally part of this pull request, but then I ended up adding them to the underlying branch not actually intending them to be a part of this pull request.)

This pull request now includes tests, (and the other three features are each in their own pull requests now, and they also have tests).

authors: cworth-gh koterpillar


text:
dusk on crates.io

Hi aloucks,
Apologies in advance, as I know this is not an appropriate place to ask a question like this. I couldn't find any other contact info for you, or I would have used it.
You seem to be the owner of the "dusk" crate on crates.io, which has no content and hasn't been updated in two years. I have a programming language called Dusk that I recently started distributing on crates.io under the name "dusklang". This is not ideal, since users who install Dusk using Cargo have to type "dusklang" to run the compiler on the command line instead of the desired "dusk." Admittedly, crates.io is highly unlikely to be the main distribution method for Dusk in the long term, but at least in the short term I would love to be able to use "dusk" if it were up for grabs. Would you be willing to transfer ownership of the crate to me?
Thanks, and sorry again for creating an issue on an unrelated project.
P.S. If you'd prefer to respond privately, my email is zachrwolfe@me.com.

This is not ideal, since users who install Dusk using Cargo have to type "dusklang" to run the compiler on the command line instead of the desired "dusk."

You don't have to name the binary after the crate name. For example, ripgrep installs as a binary called rg.
I reserved the name for a project that I am working on. I'm not sure if or when it will be published on crates.io, but all of the other names that I had considered were already taken.
Considering that your project is at the very early stages, and there is a work-around for your immediate issue (the binary name), and that you likely won't use crates.io as a long-term distribution method (which I don't believe it should be), I'm inclined to keep the project name reserved for if/when I'm ready to use it (at least for now).

You don't have to name the binary after the crate name. For example, ripgrep installs as a binary called rg.

Oops, I had no idea this was a thing. That does appear to solve my immediate issue. Thanks!

authors: aloucks zachwolfe

repo: aloucks/vki


text:
Add internal notes backend

Initial creation of the internal notes feature. Currently you can only create a internal note from the console which then displays in the document history section of the document page.
Trello:
https://trello.com/c/jilfIus0/547-mvp-of-reading-internal-notes
Example:

Looks good - nice one @1pretz1 :-).

repo: alphagov/content-publisher


text:
Ensure existing functionality for users when adding a new brief and brief response statuses

We are adding a new

'awarded' status for briefs
'pending-awarded' and 'awarded' status for brief responses.

I have crawled through this repository looking for knock on effects when we shortly add a new
'award' status for briefs. I only found one location that we needed to change to ensure existing behaviour.
Note, I also found places using the helper method supplier_has_a_brief_response:
def supplier_has_a_brief_response(data_api_client, supplier_id, brief_id):
    brief_responses = data_api_client.find_brief_responses(brief_id=brief_id, supplier_id=supplier_id)['briefResponses']
    return len(brief_responses) != 0

This would need changes to ensure the original intended behaviour to request brief responses remains i.e. that we request 'submitted', 'pending-awarded', and 'awarded' brief responses. However, it instead makes sense to change this in the API instead so we include all of these by default - https://github.com/alphagov/digitalmarketplace-api/blob/master/app/main/views/brief_responses.py#L208.
The reviewer of this should ensure this has been actioned.

Coverage remained the same at 92.604% when pulling c19fbe072a6706909ed4229da94b8b84f7e44863 on awards into 830faaa144eef4dbc3f11d3e217b02868df21176 on master.

authors: coveralls idavidmcdonald


text:
Pull in 5.2.0 of frameworks

5.2.0 contains content changes to maximum number of suppliers content
For this story on Pivotal: https://www.pivotaltracker.com/story/show/134434563
This test won't go green until pull request on the frameworks is merged: https://github.com/alphagov/digitalmarketplace-frameworks/pull/337

Who are you, Briefscontent? I definitely don't want to know what the content of your briefs is.

authors: Briefscontent TheDoubleK


text:
Add versioning to content repo

This commit:

versions the content at 0.0.1, storing the version number in ./VERSION.txt
copies the script from the frontend toolkit that tags the repo, based on the contents of the VERSION.txt (intended to be run from Jenkins or similar)

:+1:

authors: quis robyoung

repo: alphagov/digitalmarketplace-frameworks


text:
Disable end-to-end tests as a required status check

Temporarily removing end-to-end tests for finder-frontend until the tests are fixed.

Given this is more of a GitHub configuration thing (at least the branch protections), it might be easier to change that here [1].
1: https://github.com/alphagov/govuk-saas-config/blob/master/github/lib/configure_repo.rb#L97

Good point.  I'll raise a PR on govuk-saas-config.

authors: brucebolt cbaines

repo: alphagov/finder-frontend


text:
Add RAILS_LOG_TO_STDOUT Back In

It was wrongly thought the condition around logging to standard out
only when RAILS_LOG_TO_STDOUT was set could be removed because we
always want to log to standard out. This isn't correct because during
testing we do not want to see the application logs.
This was originally removed as part of commit
8ac5fac683d8025e323da6f8f91d6cf6a46fe244
What problem does this pull request solve?
Link to original commit removing this condition: https://github.com/alphagov/forms-product-page/pull/139/commits/8ac5fac683d8025e323da6f8f91d6cf6a46fe244
The logs are no longer shown when running bundle exec rspec
Latest CI run: https://github.com/alphagov/forms-product-page/actions/runs/7261377445/job/19782436615?pr=168#step:7:1

Does it work when run on your machine?
Is it clear what the code is doing?
Do the commit messages explain why the changes were made?
Are there all the unit tests needed?
Has all relevant documentation been updated?

Oh, is this superseded by #169 @danworth?

Yep that's the one @DavidBiddle I'll close this.

authors: DavidBiddle danworth

repo: alphagov/forms-product-page


text:
Send location_form action and method data to GA4

Trello local_transaction
Trello special_route
Trello place
Trello license
Sends "action" and "method" data to GA4.
The location_form partial is used by the following formats:

place
local_tranaction
license_transaction
special_route

The tests for these formats have been updated to reflect the additional values.
I tested this manually for local transactions using the 'How to test it' instructions in this PR description.

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

I've had a quick look at this and the action is looking good! We might need to check re method - I may be wrong here but we've been treating method as which mouse button was pressed (i.e. left/right/middle click) when we've implemented GA4 tracking elsewhere so I'm not sure if method is referring to the form's submit method (i.e. POST) in this instance.
It can get a bit confusing so I hope I've made sense here - give me a shout if I can explain better!

Yeah thinking about this some more I think a conversation with the analysts is needed on method - because for forms it's always going to be post so there's a question over how useful that would be - it'd be like recording "click" as a method on links.

We spoke with a PA offline and we agreed to remove sending through the 'method' for the reason Andy mentioned above.

authors: JamesCGDS Rosa-Fox andysellick

repo: alphagov/frontend


text:
AWS SNS Topic and Lambda Function

We have a necessity to create an AWS SNS Topic that can be used to
communicate SNS notifications from the govuk-{environment}-artefact
buckets.

We also need a Lambda function to synchronize buckets between
environments.

The two points mentioned above has been covered via this commit.
Solo: @suthagarht

Test

repo: alphagov/govuk-aws


text:
Tweak example datetime format...

We're using this example to generate the contract
tests in gds-api-adapters. By default, Rails formats
JSON with a particular datetime format. This didn't
match the one in the example.
Both of these formats are valid with the same RFC:
http://tools.ietf.org/html/rfc3339
This is a simple fix that resolves the problem.

I'm not sure I understand why this is necessary. As it stands, it matches what the publishing apps generate because they call Time.now.iso8601 - https://github.com/alphagov/gds-api-adapters/blob/master/lib/gds_api/publishing_api/special_route_publisher.rb#L29
It would be good to keep the examples matching what's actually produced by the publishing apps.

@alxt does it matter if they are identical provided that the time formats conform to schema (which specifies date-time?

We've discussed this and we're going to take a different approach.
Thanks

authors: alext heathd tuzz

repo: alphagov/govuk-content-schemas


text:
Document display override classes

Closes #1273

You can preview this change here:
Built with commit 11c540a525eed440b3d3b397017990318df1979e
https://deploy-preview-1297--govuk-design-system-preview.netlify.app

authors: govuk-design-system-ci timpaul

repo: alphagov/govuk-design-system


text:
Add new focus style to buttons

Before:

After:

Browser testing:

[x] Chrome 73 & 74
[x] Firefox 65 & 66
[x] OS Safari 10, 11, 12
[x] Android Samsung Galaxy (Chrome)
[x] iOS XS / 8 (Safari)
[x] Edge 17 & 18
[x] IE 8 - 11

Others tests:

[x] Zoomed at 400%
[x] Legacy mode - focus is darker colour. If a button doesn't use govuk-button class then the focus style is not updated to the new style. For example https://govuk-frontend-review-pr-1315.herokuapp.com/full-page-examples/renew-driving-licence

Issues:

Start button icon is still a two toned white png.

👉 Before: https://govuk-frontend-review.herokuapp.com/components/button
👉 After: https://govuk-frontend-review-pr-1315.herokuapp.com/components/button
Closes #1305

Looking good so far, added some comments to make it more consistent with the rest of the codebase. 👍

Looking good so far
The secondary :focus state that is applied at the same time as :active is causing the button to get smaller. I believe I may have added some padding on the prototype, ideally the button will remain the same size in every state.
It also appears to have lost the margin-top that is applied in this state to give the button it's "pushed down" feel

I don't think this is working correctly for secondary or warning buttons at the minute. They're not getting the yellow highlight, and in the case of the warning buttons the text colour is changing to black (on red)

@36degrees Ah yes I see that, I think thats because I removed the important and that was forcing everything to work. I'll take a look at it as @nickcolley suggested perhaps moving the focus/hover state to the bottom

It looks like we can make the highlight border thicker to be consistent with Dave's original design:

Original:

Buttons with modifiers have inconsistent focus state compared with the original.
Let me know if you wanna go over any of this feedback together.

It was decided that the final version of the buttons would not have a double thick border like links and the most noticeable changes would be the background colour changing to yellow and the bottom border colour changing to black

repo: alphagov/govuk-frontend


text:
Consider adding rubocop-rspec

When upgrading govuk-lint to v3.1.0 in asset-manager I ran into an issue where the Metrics/BlockLength rule now defaults to a maximum of 25 lines. While I think this is OK in general terms, it's a bit problematic in DSL-style code, like RSpec specs.
I've seen this recommendation to to use rubocop-rspec and so I think it might be sensible to add this gem as a dependency of govuk-lint.
What do people think?

This was addressed in #83. Closing.

repo: alphagov/govuk-lint


text:
Add test for upgrading from previous release

It would be nice to have our tests check for us how a change is going to affect upgrading from a previous release.
This PR adds a test that creates a prototype from the previous release code, then runs the update script to check whether the update succeeds or not.
At the moment we don't do any other particular checks, but I guess we could add some as we think of them.

the "testFailingIf" function in "utils.test.js" is passing in the CI and is therefore either unnecessary or there is an unexpected bug?

the "testFailingIf" function in "utils.test.js" is passing in the CI and is therefore either unnecessary or there is an unexpected bug?

Forgot I'd put those there. Removed now, tests should pass everywhere.

I've got it working on macOS and Linux, but it's still getting stuck on Windows, and I don't know why 😞

I've decided to skip the hanging test for now (on Windows only), so we can move forwards. I'll create a tech debt ticket to address the issues after this has been approved and merged.

authors: BenSurgisonGDS lfdebrux

repo: alphagov/govuk-prototype-kit


text:
Add script maps

See Using GOV.UK Frontend 4.5.0, opening dev tools causes an error in the terminal
This change will prevent the failure within the browser to load any script mapping file such as govuk-frontend/govuk/all.js.map
To achieve this, the plugin config scripts are parsed to dynamically update the plugin config assets with the location of any matching script map files if they exist.

As this functionality is available with the existing plug-in functionality I've spoken with the Design System Team and raise this PR for them https://github.com/alphagov/govuk-frontend/pull/3255

authors: BenSurgisonGDS nataliecarey


text:
Fix permissions on mirror_root for crawler_work

The permissions for the mirror_root (/mnt/crawler_worker) on the mirrorer
machines can sometimes change through normal work and break the mirror
synchronisation cronjob.
This occurs because linux users are non-determiniscally provisioned via
puppet, meaning that UserA on one machine might have an uid and gid of
1025:1025, whereas another machine UserA might be 1040:1040.  As the
mirror_root (/mnt/crawler_worker) is actually mounted from a seperate
persistent EBS volume, the file permissions from the original machine
which created the files and directories, will not work on other machines
which subsequently use the EBS volume.
To solve this problem the ownership of the mirror_root directory, with
all child directories and files, need to be reset after the mirror
machine is respun.  This could be either done manually after a respin,
or managed by puppet - which this PR does.
By recursively changing the ownership on the mirror_root it will fix
the problem.  The time taken to apply this change is ~30sec when all
directories and files need changing after a respin, and only <1sec on
subsequent runs.

Abandoning because based of wrong branch, replacement PR is here: https://github.com/alphagov/govuk-puppet/pull/11199

repo: alphagov/govuk-puppet


text:
Update docker-ce to last supported Trusty release 💀

This version of docker-ce is the last one that supports Trusty on a
3.x Linux Kernel 1.
I'm upgrading as we seem to be experiencing an issue with aufs (see
below) on one of our machines. My investigation indicates that this may
potentially be a bug in docker-ce that was fixed in 17.12.1 and 18.03 2.
So I expect updating to 18.06.1 will resolve it - if not at least we're
on a more recent version.
17:45:53  driver "aufs" failed to remove root filesystem for 1689bc31da539840e42f29043cd62bd7ebab3da05d0d5094aafcaebb90ea1958: could not remove diff path for id 0be2d29298c44335f47beb6a20151f1fa1b9516a551f7a6beea00b62aa880faf: error preparing atomic delete: rename /var/lib/docker/aufs/diff/0be2d29298c44335f47beb6a20151f1fa1b9516a551f7a6beea00b62aa880faf /var/lib/docker/aufs/diff/0be2d29298c44335f47beb6a20151f1fa1b9516a551f7a6beea00b62aa880faf-removing: device or resource busy

I've been running this on integration for around an hour and it seems to have resolved the problem, as well as not introducing any new ones.

Nice. Will we be able to go for a newer version if we upgrade to a 4.x kernel I wonder?
We might do that in this card: https://trello.com/c/t9PmUATo/2878-workaround-or-fix-the-arp-caching-bug

It sounds like we can still go up a couple of patch releases to 18.06.2 as per their changelog of "Ubuntu 14.04 customers using a 3.13 kernel will need to upgrade to a supported Ubuntu 4.x kernel" for 18.06.2.
But the bad news is that Trusty is an unsupported platform and I think they stopped pushing releases since 18.09 - could be that we could package it ourselves 😬


text:
Resolve 'dead area' between radio/checkbox and label that has hand cursor but is not clickable

What problem does the pull request solve?
On the new radio buttons / checkboxes, there is a 12px gap between the input control and the label which has a hand cursor (inherited from the .multiple-choice parent div) but is not clickable. Since it has the hand cursor, I feel it should be clickable.
The alternative would be to not show the hand cursor in this 12px dead area but that doesn't feel right to me?
How has this been tested?
Checked in Chrome (Ubuntu), IE8, IE9, IE10, IE11, Edge 14, iOS9 Safari, Android 6 Chrome.
Can test more if necessary, if this change is approved. Just let me know...
Screenshots (if appropriate):

What type of change is it?

Bug fix (non-breaking change which fixes an issue)

Has the documentation been updated?

I have read the CONTRIBUTING document.

Nice spot thanks for the PR!
I've attached some screenshots where the pink is anywhere cursor: pointer is enabled, and where the current clickable area is before and after your proposal.

Current
Proposed

Good point, I'll have a peep

@nickcolley If I just remove the cursor: pointer from the parent div, the label and input inside it already have a pointer on them, so you end up with what you highlighted in red.
Only thing I wonder is whether to add the tiniest amount of top and bottom padding onto the label to give it some height. What do you reckon?

Nice catch!
It's important that radios and checkboxes have large hit areas. In the examples above ideally the entire pink area would be clickable - as the hand suggests.

@edwardhorsford Ah I see sorry, I interpreted the pictures wrong. You reckon actually the entire of the light pink area should be clickable, in both those examples? What about this example:
!(https://cloud.githubusercontent.com/assets/2445413/24362846/ec2e663c-1305-11e7-9b61-7d4dc6120de3.png)
Should it be clickable all the way to the far right hand side there?

Happy to do that - I just wondered whether the right hand edge there was quite a long way away from the end of the word Ireland. Is it strange for it to be clickable that far away, or should it be more like this:

Willing to be vetoed but I'd vote for it being all the way on smaller screens.
Thinking about where people's thumbs will be placed if they miss on the right side of the screen we'll catch their input if it's full width.
This will be much more evident in small labels also like the examples above these 'Yes', 'No'

This is a bit more complicated now we don't have the grey box round them, to give that visual indication that there's a thing there. That's my only concern - that a large blank area of the screen as a clickable thing might be more "surprising" than it is useful.

is there a downside to wrapping the whole thing in label like we used to? That means you have a nice big hit area

@joelanman the label is being used with pseudo elements for the fake input, if we wrapped the label we'd most likely need another element alongside the input that is nested.
@robinwhittleton was worried that extra elements will play worse with screenreaders

Don't think we need to change the markup. We should be able to do either of the hit area options with what we've got. Just need to decide on what the "right" hit area is
On 27 Mar 2017 5:02 p.m., Joe Lanman notifications@github.com wrote:
is there a downside to wrapping the whole thing in label like we used to? That means you have a nice big hit area
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/alphagov/govuk_elements/pull/435#issuecomment-289498750, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAIN8hREY-cL1qXRL9ZKHqPlxqHmzu7Tks5rp9y5gaJpZM4MqXNg.

What do people think about the attached screenshots, with the clickable areas being fatter, but not extending full width? (See the dotted red borders around checkboxes and radios)
The alternative suggested above is that on the mobile option, the clickable area extends full width.

I think unless someone else has strong objections it may be better to keep the full width behaviour as is but with your fixes to touch areas and then raise an issue to look into this again later?

:+1: Cool, will sort that out

Ok that will leave us with the following click areas (dotted in red). I'll tidy up let you know when it's ready for review

Looking good!

Cool, cheers @edwardhorsford. I think this is ready for review in that case.

Will give it another look over thanks so much @andymantell this is great.

Tested this on a Galaxy S7, iPhone 6, IE 6, IE 8, IE 9 and Chrome.
LGTM 👍
Will leave open for a little bit since these are important components for others to comment then merge.

Left open for a day with no extra comments, and @nickcolley’s testing looks good so let’s merge.

Thanks a lot @andymantell 💯  🚀

Good stuff! Thanks! 👏

No probs, thanks for everyones help

authors: 36degrees andymantell edwardhorsford joelanman nickcolley robinwhittleton


text:
Updated message statuses

What problem does the pull request solve?
Updated message statuses to align with the "Using Notify" page and the Support doc
Checklist

[x] I’ve used the pull request template
[ ] I’ve written unit tests for these changes
[x] I’ve updated the documentation (in DOCUMENTATION.md and CHANGELOG.md)
[ ] I’ve bumped the version number (in src/Notify/Notify.csproj)

👍

authors: CrystalPea jonathanglassman

repo: alphagov/notifications-net-client


text:
[Support] Re-add uaac to Gemfile

What
This is needed to interact with UAA as documented here:
https://government-paas-team-manual.readthedocs.io/en/latest/guides/CF_UAA_user_management/
This also removes a spurious bundle install from the .travis.yml
How to review

Verify that Travis tests pass.
Verify that you can interact with UAA as documented here (without cding into scripts - PR incoming to update the docs).

Who can review
Not me.

I got this warning when targetting and fetching a token from a new endpoint:
 dcarley@air  ~/p/p/paas-cf   re-add-uaac  b uaac target https://login.cloud.service.gov.uk
Unknown key: Max-Age = 86400

Target: https://login.cloud.service.gov.uk

 dcarley@air  ~/p/p/paas-cf   re-add-uaac  b uaac token sso get cf -s ""
Unknown key: Max-Age = 86400
Passcode (from https://login.cloud.service.gov.uk/passcode):

Seems to be a bug in nahi/httpclient#376 and possibly a regression of nahi/httpclient#242. It goes away after the initial target/token though, so I don't think it's worth persuing.
Works and team manual changes were merged in alphagov/paas-team-manual#191 👍

authors: alext dcarley

repo: alphagov/paas-cf


text:
bau: Hide / show SAML form in pure JS

This works around an issue where the user's web server sets a
Content-Security-Policy header which has allows inline JS, but
not inline CSS.
Prior to this commit the form would not be hidden as the JS attempts to
add an inline style, which is disabled by the CSP. By setting the
display property directly in JS we don't need to depend on CSS being
enabled.
I've tested this locally by yarn linking this into
passport-verify-stub-relying-party and it still works. Once we've
published a new version to npm we'll need to bump the version in PVSRP.

Any when this pull request might get merged in to master?

It's been approved, so I guess we should merge it :shipit:
Would be good to get #42 sorted as well before we release the next version (which should probably be 1.0.0 since this library is supported for use in production now).

authors: malcolmhire richardTowers

repo: alphagov/passport-verify


text:
Use FeatureFlag model rather than using ENV vars

We want to be able to change feature flags without having the need to
update the puppet or deployment repos. The current approach of using ENV
variables would require this.
Created a feature flag module which can take a name and a boolean value
and a rake task to update those feature flags.
If you want to update one you can call:
bundle exec rake feature_flag:set[new-key,true]

:+1: except tests failing

authors: edds elliotcm

repo: alphagov/policy-publisher


text:
Remove redundant Special Education Needs policy

There are two copies of this policy. This removes one of them as per
this Zendesk ticket.

cc @elliotcm @tijmenb

This is not a url that is visible on gov.uk and it is also not in Rummager. @tijmenb is there somewhere else that we should also be looking just in case?

I don't know. I do have the feeling it would be better if policy-publisher sent a redirect / gone or something. Doing these kind of things should be possible with the public API instead of doing complex data migrations. If we do this here we'll end up with a million data migrations in publishing-api. @danielroseman thoughts?

I see now that https://github.com/alphagov/publishing-api/pull/260 is the precedent for this, so apparently this is fine.

@tijmenb I wasn't intending to set a precedent for this being the right solution to this, I was expecting us to fix the underlying issue, though I can't remember whether I reported it as a bug.

@elliotcm do we know how the policies got into this state? I thought about issuing a redirect as well but as far as I can tell there is no route set up for this base path?
@tijmenb I think I agree; it seems like it would be useful to have a general way to withdraw content from the publishing api for migrated apps, even if its not part of the normal publishing workflow for users, since this kind of thing will inevitably happen again. Do we have a rake task that does anything like this?
Also, not really relevant to the topic at hand, but it would be nice to have proper functionality for merging "linkables" in collections publisher as well at some point, so users can do this themselves.

@MatMoore Not sure, I didn't get a chance to do a proper investigation.
As for the withdrawing, we have an endpoint incoming shortly which could be used.

@elliotcm Since this particular policy has no public facing base path it would seem reasonable in this instance to use the db migration to remove it?
Can we add this to a team's backlog to investigate the reason it happened in the first place?

@brenetic Fine by me.  @tijmenb are you OK with that, and as your team owns policy publisher would that be you making a ticket?

I've made a PR to do this in policy-publisher with the new unpublish endpoint: https://github.com/alphagov/policy-publisher/pull/133

@brenetic closing this in favour of https://github.com/alphagov/policy-publisher/pull/133. I'll take it from here. Thanks!

authors: MatMoore brenetic elliotcm tijmenb

repo: alphagov/publishing-api


text:
Publish calendars routes

We need the routes to be able to access them via www.dev.gov.uk in Mainstream Publisher. This was missed in #288.

This matches what's in https://github.com/alphagov/calendars/blob/master/lib/tasks/publishing_api.rake

authors: sihugh thomasleese


text:
Remove taggy things from manuals

This PR is basically a revert of https://github.com/alphagov/specialist-publisher/pull/532. That PR changed the publishing flow so that this app would fetch the topics/specialist sectors from the content-api before publishing to rummager.
This was needed at the time, because otherwise the payload sent to rummager wouldn't contain the tags set in panopticon, and the manual wouldn't be displayed on a /topic page.
Since then, we've started indexing the links from the publishing-api in rummager. As part of this we stopped sending specialist sectors to rummager (https://github.com/alphagov/specialist-publisher/pull/723).
At the time of that PR we didn't realise that the only reason for the fetching of tags from content-api was now gone. This PR removes the last (now basically unused) code, which means that we are no longer dependent on content-api.
✌

👏  👍

authors: mobaig tijmenb

repo: alphagov/specialist-publisher


text:
Redirect invalid email signups to root

The motivation is to avoid the ActionController::ParameterMissing exceptions being caught in Sentry.
This means that requesting https://www.gov.uk/government/email-signup/new will result in a redirect to www.gov.uk, instead of the current 400 Bad Request response. This mirrors the redirect we send in response to requests for https://www.gov.uk/government/email-signup (although that's handled in routes.rb).
I'm not sure how best to avoid these exceptions. It would seem reasonable to display some kind of useful information if someone were to request /government/email-signup/new but that's more work than I have time for. Another option is to ignore these ActionController::ParameterMissing exceptions in Sentry (there's precedent for this as they're ignored by default by HoneyBadger) but it feels like that might have other consequences I'm not aware of.

ActionController::ParameterMissing errors should probably not be reported to Sentry. We did an RFC on errors a while back and I think the error we're dealing here with here is "Bad request error":
https://github.com/alphagov/govuk-rfcs/blob/master/rfc-087-dealing-with-errors.md#bad-request-errors
The desired behaviour is "user gets feedback, error is not reported to Sentry". I think it would make sense to add it to Sentry's excluded_exceptions.

Thanks @tijmenb! I'll take a look at adding ActionController::ParameterMissing to the list of excluded exceptions.

I've added a PR in govuk_app_config for this.

authors: chrisroos thomasleese tijmenb

repo: alphagov/whitehall


text:
[DO NOT MERGE] Make data-ga4-attachment-link appear on all attachment links

Do not merge as we are deploying/changing the attachment tracking in a stepped process, so that we don't affect the existing file_download tracking .
Previously we were tracking HTML attachments as 'attachment' and all other attachment links as file_download using JS. This change makes it so that every attachment link will get the type 'attachment' set on it in our ga4-link-tracker.js in publishing components.
https://trello.com/c/MHFXw6H2/552-change-filedownloads-on-attachment-pages-to-have-attachment-instead-of-generic-download-type
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
Follow these steps if you are doing a Rails upgrade.

I'm closing this pull request as Whitehall no longer renders attachments itself following #7932.

authors: AshGDS ollietreend


text:
Upgrade

This does the following:

includes PR #91
includes PR #93
updates dependencies
upgrades to ember, ember-cli 3.3
fixes eslint errors
upgrades tests to new style
removes sendAction to avoid deprecation warnings

Released with v0.5.0. Thanks for taking the time to put this PR together @Gaurav0 😄!

repo: alphasights/ember-scrollable


text:
Custom Page Order in NavBar

In the navigation bar, the order of the pages is defined by sorting alphabetically: {%- assign sorted_pages = site.pages -%}.
Is there an easy way to specify a different order?

checkout my workaround in following commit:
https://github.com/babaknasr/babaknasr.github.io/commit/d900a98c3861fe6819932e2213405d98b8213a09
I added a new tag "sort_menu" for each page using numbers and then sorted based on "sort_menu":
{% assign sorted_pages = site.pages | sort: "sort_menu" %}
by changing the value of the tag, manually you can manipulate the order of menu items.

Isn't there an importance tag for each page already?

@bchao1 Do you have an example for that?

Not sure which version you're using, In my case, line 39 in _includes/header.html specifies that the tabs in the navbar is sorted using the order attribute:
{%- assign sorted_pages = site.pages | sort: "order" -%}

So, you can simply add the order attribute in each markdown file in _pages to change the ordering. Example:
---
layout: page
permalink: /publications/
title: publications
order: 2
description: Brian Chao's publications.
years: [2022, 2021, 2020]
nav: true
---

authors: babaknasr bchao1 emalgorithm

repo: alshedivat/al-folio


text:
Eisenhower Matrix Box

Add Eisenhower Matrix, a powerful decision-making tool

Urgent
Not Urgent
Important
Not important

Added

repo: alsiam/iTasks


text:
change pull to rebase

I suggest recommending rebase (rather than pull i.e. merge) for updating a local fork.
Some discussions of the pros and cons of each:
https://www.atlassian.com/git/tutorials/merging-vs-rebasing
https://blog.sourcetreeapp.com/2012/08/21/merge-or-rebase/

I thought it was assumed that master is never changed from upstream.  In this case bringing up rebase of master is kind of confusing.  I would rebase my topical branch, but for master basically pull --ff-only and start worrying if it's not a fast forward.

Fair point...if people follow the rules of never committing to their local master, I guess it wouldn't make any difference.

Some big open source projects seem to recommend rebase:
https://docs.scipy.org/doc/numpy/dev/gitwash/following_latest.html#updating-the-code
While others recommend merge:
https://pandas.pydata.org/pandas-docs/stable/contributing.html#delete-your-merged-branch-optional

@rabernat, did you mean to link to this page?
https://docs.scipy.org/doc/numpy/dev/gitwash/development_workflow.html#development-workflow
My main concern with rebase, is that many members of the developer community for MITgcm are unfamiliar with git, and it only takes a small accident with rebase to really screw things up. Merge commits can at least be reverted if something went wrong.
Essentially, I was trying to make the workflow as robust as possible to stop people getting frustrated with git before they'v had a chance to get familiar with it.

Sure, agreed.

authors: edoddridge jahn rabernat


text:
Bug: Application error: Failed to read large IndexedDB value DataError: Failed to read large ...

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Error message: Failed to read large IndexedDB value
DataError: Failed to read large IndexedDB value
Error stack:
DataError: Failed to read large IndexedDB value
 DataError: Failed to read large IndexedDB value
    at vn.rejectionMapper (altair://-/main.js:3:369206)
    at Xk (altair://-/main.js:3:303628)
    at IDBRequest.<anonymous> (altair://-/main.js:3:330469)
    at IDBRequest.__zone_symbol__ON_PROPERTYerror (altair://-/main.js:3:305416)
    at IDBRequest.Qt (altair://-/polyfills.js:3:29957)
    at t.invokeTask (altair://-/polyfills.js:3:25686)
    at Object.onInvokeTask (altair://-/main.js:3:80112)
    at t.invokeTask (altair://-/polyfills.js:3:25607)

Expected Behavior
No errors should occur
Steps To Reproduce
This will happen when you reopen it after installation
Environment
- OS:
- Browser:
- Platform:
- Version: 7.3.3

Additional context
No response

Looks like an issue in chromium https://issues.chromium.org/issues/342779913?pli=1

Other related: https://github.com/johannesjo/super-productivity/issues/607

repo: altair-graphql/altair


text:
🛑 roothouse-2 is down

In 15c0544, roothouse-2 (https://rhstatus-proxy.alterine0101.id/?deviceId=roothouse-2) was down:

HTTP code: 404
Response time: 262 ms

Resolved: roothouse-2 is back up in ef71acf.


text:
Woodwork initialization can fail if datetime format is inferred incorrectly

During initialization Woodwork infers the format string for any columns identified as Datetime columns and then converts these columns to datetime64[ns] dtypes using this format string. If the most common format string does not work for all of the data in the series, initialization will fail with:
TypeConversionError: Error converting datatype for dates from type object to type datetime64[ns]. Please confirm the underlying data is consistent with logical type Datetime.

Code Sample, a copy-pastable example to reproduce your bug.
import pandas as pd
import woodwork as ww

dates = pd.Series(["01/01/2017"]*4 + ["13/12/2017"])
df = pd.DataFrame({
    'id': range(5),
    'dates': dates
})

df.ww.init()

The inference and conversion process should be updated so that it does not fail. There are at least two circumstances that could cause this failure:

The sample of data used to infer the format is not large enough to capture the correct format
The most commonly inferred format is not the correct format (as in the example above)

We might need to update the process to be something like this:

Try initialize using the format inferred on a sample of data as we are doing today
If this fails, use all of the data instead of a sample to infer the format strings
If the most common format fails, try all other identified format strings until finding one that works
If no valid format strings are found, raise the error above

Note, for performance reasons we want to try to infer on a sample first, and only fallback to using more data if the sample approach fails.

Another possibility here would be to try the conversion with the inferred format in Datetime.transform, and if that fails raise a Warning and do the conversion without the specifying the format string, which should succeed because at this point we have already identified that this column contains valid datetime data. If we took this approach we would not have knowledge of the format string that was used to convert the data, but the initialization would no longer fail.

perhaps, there are two separate things going on here

did we infer the correct format? or did the user supply the correct datetime
what should we do if we try to parse a series using a particular format and some rows fail

i think this issue is mainly about 2. in that case, i think the expected behavior would be that the rows that cannot be parsed get converted to nan or NaT.
could we accomplish this by using pd.to_datetime(...,errors="coerce"). looking at docs here

@kmax12 The issue here is that we attempt to parse a series using a particular format inferred by Woodwork and some rows fail.
I think using coerce could be good if the user specified the format and some data is not compatible with that format, using NaT for those rows makes sense.
I'm not as sure we should coerce n the case where Woodwork infers a format that is incompatible with all of the data. My reasoning - if we have a series such as the dates series in the example code above that has a "true" datetime format of day/month/year, but Woodwork infers the format month/day/year and we use the inferred format to coerce the data, then we will convert some rows incorrectly and replace others with NaT, when the "right" approach would be to convert all rows correctly using day/month/year.
I guess if we do use coerce with a Woodwork inferred format that causes NaT to be added, we should at least warn the user that this happened so they can review and fix if needed by manually specifying the correct format on initialization.

that is why im trying to separate 1. did we infer or did the user provide the format correctly?  from 2. what happens if the inference is wrong?
the situation you describe seems to me like we need to improve the inference algorithm, but that coerce would be fine. we could also expose the coerce parameter if we wanted the user to have flexibility on this behavior

repo: alteryx/woodwork


text:
Something wrong in dataset.py

wrong with Line74 in dataset.py: seq = [x for x in range(4-tt,5+tt) if x!=4]
if nFrames=11 and tt=int(nFrames/2)=5, seq will start from -1, however, there isn't im"-1".png .

The F11 model was used for NTIRE2019.
It was not trained and tested on vimeo90k, but on NTIRE2019 dataset for video SR challenge.
But you can use this model for Vid4 or SPMCS dataset.

authors: ABadCandy alterzero

repo: alterzero/RBPN-PyTorch


text:
Can't export .eps/.pdf

Hi,
I have a problem with export_fig, when trying to exporting to eps.
I'm running matlab R2014b, Ghostscript 9.15 (home brew install) on a mac running OS 10.10.3 (Yosemite).
Here is the error output of matlab:
Warning: File '/private/tmp/tpa4f3d359_b178_4e50_a55f_4b37049e1546.eps' not found.
> In export_fig at 621
  In insert_plotmenu_1d>export_to_pdf at 120
export_fig error. Please ensure:
  that you are using the latest version of export_fig
  and that you have Ghostscript installed
  and that you do not have multiple versions of export_fig installed by mistake
  and that you did not made a mistake in the expected input arguments

If the problem persists, then please report a new issue.

Error using checkArgsForHandleToPrint>LocalCheckHandles (line 88)
MATLAB Graphics handle must be a figure.

Error in checkArgsForHandleToPrint (line 30)

Error in print>LocalCreatePrintJob (line 336)
    handles = checkArgsForHandleToPrint(0, varargin{:});

Error in print (line 153)
    [pj, inputargs] = LocalCreatePrintJob(varargin{:});

Error in print2eps (line 160)
print(fig, options{:}, name);

Error in export_fig (line 597)
                print2eps(tmp_nam, fig, [options.bb_padding, options.crop], p2eArgs{:});

I have checked that that only have one export_fig install using "which export_fig -all", it returns only one item on the correct path.
Breaking the code at line 160 in print2eps and asking to the type of 'fig' returns:
get(fig, 'type')
ans = figure

Asking to the options gives the following return:
options
options =

    '-depsc2'    [1x2 double]    '-painters'    '-r864'

The double contains [0,1].
Any ideas to what is wrong? The error seems to originate from the function checkArgsForHandleToPrint, but it is a "hidden" function, so I have no idea what it does.

You are using a very old version of export_fig. Read the error message - the VERY FIRST ITEM says specifically: "ensure that you are using the latest version of export_fig" !

I just downloaded the newest version from Github! The master branch from this side should be the newest version right?

yes

Then I don't see how I can be using an old version of export_fig??

the fact that line 160 of print2eps is the call to print() tells me that it's an old version. It should be on line 211 in the latest version.

I had an old print2eps that wasn't deleted! I should have checked that. Thanks for the help:)

@altmany I received a similar error myself, with a clone of export_fig from 50 minutes ago:
export_fig error. Please ensure:
  that you are using the latest version of export_fig
  and that you have Ghostscript installed
  and that you have pdftops installed
  and that you do not have multiple versions of export_fig installed by mistake
  and that you did not made a mistake in the expected input arguments

If the problem persists, then please report a new issue.

Error using printopt
Too many input arguments.

Error in matlab.graphics.internal.mlprintjob

Error in printjob (line 22)
       pj = matlab.graphics.internal.mlprintjob;

Error in print>LocalCreatePrintJob (line 101)
pj = printjob([handles{:}]);

Error in print (line 38)
[pj, inputargs] = LocalCreatePrintJob(varargin{:});

Error in print2eps (line 301)
    print(fig, options{:}, name);

Error in export_fig (line 700)
                print2eps(tmp_nam, fig, options, p2eArgs{:});

Error in make_commentplots (line 232)
export_fig([out_dir,datestr(now,'yymmdd'),'_Fig',fignum],'-eps')

The information passed to export_fig is:
export_fig('/Volumes/durack1ml/sync/Shared/180902_PaperPlots_OOPCOceanObs/180919_Fig1','-eps')

The information passed to print2eps is:
    % Print to eps file
    print(fig, options{:}, name);

fig =

  Figure (1) with properties:

      Number: 1
        Name: ''
       Color: [1 1 1]
    Position: [1 1 453.5433 226.7717]
       Units: 'pixels'

  Show all properties

K>> options

options =

  1×4 cell array

    {'-loose'}    {'-painters'}    {'-r864'}    {'-depsc2'}

K>> name

name =

    '/private/var/folders/7d/rkhc67xs5w70chjmlrr6pv440017ch/T/tp28e9e10f_e223_4532_8239_73bfc267636d.eps'

Peeling this back a little further:
K>> LocalCreatePrintJob(varargin{:})
Error using printopt
Too many input arguments.

Error in matlab.graphics.internal.mlprintjob

Error in printjob (line 22)
       pj = matlab.graphics.internal.mlprintjob;

Error in print>LocalCreatePrintJob (line 101)
pj = printjob([handles{:}]);

K>> varargin

varargin =

  1×5 cell array

    {1×1 Figure}    {'-opengl'}    {'-r72'}    {'-dtiff'}    {'/private/var/folders/7d/rkhc67xs5w70…'}

@durack1 - indeed, the error is internal to Matlab's builtin print and saveas functions.
You can try to see whether different input parameters to print (in print2eps line 301) will resolve the problem. If you find out some workaround, please report it here (in this Github issue] and I will incorporate it into export_fig.

Thanks @altmany, the issue was related to a duplicate printopts.m in my path, so after running which -all printopts and ascertaining the old, incorrect version, removing that from my path got me running again both for the builtin saveas and export_fig


text:
Finalize about text on start page

The text in "Why?" is perhaps the most important in the whole project. We should make sure that it reads as easily as possible and clearly communicates our goals. Maybe a bit of backstory including that the project started as a page just about OCD too?

It is good enough for now.

repo: alvarlagerlof/neurodiversity


text:
🛑 img.itove.com is down

In 42d55b7, img.itove.com (https://img.itove.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: img.itove.com is back up in 63a5b56.

repo: alzee/up


text:
The name in package.json should be all lowercase

In package.json the name should be lower-case (e.g. "mongopop" not "Mongopop").
See also https://docs.npmjs.com/getting-started/using-a-package.json which says that the name must be "all lowercase".

Fixed - thanks

authors: am-MongoDB cwellsx

repo: am-MongoDB/MongoDB-Mongopop


text:
A label attribute should be added to the p6-tab component

In the p6-tabs component, we use the title attribute present on the p6-tab components to define the titles of the tabs.
It should be replaced by a label attribute to avoid displaying the tooltip.

/!\ the label of the tab is not correctly updated


text:
Consider underground pipelines that have subtance=water

I came across a drainage tunnel someone had tagged as an underground pipeline (layer=-1, location=underground, man_made=pipeline). It connects two exposed drains on either end, just functioning as an underground tunnel in between them. The tags seem to be appropriate per https://wiki.openstreetmap.org/wiki/Key:tunnel, which indicates that "When the waterway=* runs underground for a considerable distance, you can use ... man_made=pipeline for sections built with tube assemblies". With this in mind, I wonder if WWM should account for pipelines that have substance=water in them.
One example is here https://www.openstreetmap.org/edit?editor=id#map=19/29.46003/-98.54983 -- currently WWM does not see this as a connection between the drains on either end.

I would say the example is mistagged since it's just underground drainage (it's not even clear if it's in a pipe). I would only use underground man_made=pipeline for things like pumped or pressurized flows, mainly found at industrial sites, waterworks, dams, etc.

authors: kaleidoscopica quincylvania


text:
[Wiki] Documentations

This issue will track all things that we need to list/document out in GitHub wiki page regarding Atom.

[x] Coding Guidelines
[x] Setup Build Environment?
[x] Building Kernel
[ ] C# Compiler Assumptions/Conventions
[x] Attributes
[x] Assembly
[ ] Kernel Documentation

Can a proper installation guide be provided in the Wiki or README.

You can check this

Add nasm also to required packages in "Building Toolchain".

Add nasm also to required packages in "Building Toolchain".

Already there

Dear Sr I try Compile de project but not work the erro is the same

authors: amaneureka dreamersoftware mananpal1997 rahul-kumi

repo: amaneureka/AtomOS


text:
Streaming issue on 2.4ghz band

Facing issue in streaming only when I use 2.4ghz band for streaming on T.V. It works perfectly without any buffer/lag on 5ghz band. I tried to search through other sources first for any solution. But, got nothing informative. So, my last option was asking in here directly.

AnimeTV not have any relation with 2.5ghz / 5ghz wifi networking, and it's so unrelated with an app.

authors: amarullz atharvbambal

repo: amarullz/AnimeTV


text:
How to handle multiple paginations in same page with AJAX?

For example, I use data remote for the pagination like this :
<%= paginate @products, :remote => true %>

It works. But the problem is I have multiple lists to paginate in one page. So, I need a way to send the call to a separate files so I can render the appropriate content. How can I do this?

I guess you can use param_name option.
Please don't ask questions about how to use kaminari. We only accept bug reports and pull requests on GitHub and you should ask questions on StackOverflow or somewhere else. I actually saw your question on StackOverflow, so don't duplicate questions here.

Ah sorry

repo: amatsuda/kaminari


text:
Half black screen in Android 8.0 phones

I used this map works fine in ios and android but in android 8.0 devices show this issue

I'm using Android 8.0 Phone (Xperia).
But I can't reproduce it.
Could you try another Android 8.0 phone?

I Used Huawei y9 and Huawei Honor and the same problem

Please try our sample apps - https://github.com/amay077/Xamarin.Forms.GoogleMaps/tree/da636133501368fa65c8346474d779c106305543/XFGoogleMapSample
Or https://install.mobile.azure.com/users/okuokuoku/apps/xfgooglemapsample/distribution_groups/trial

I used your sample works fine but when i put the same xaml in grid and set map to take half of screen look like the same which i post , any help ?

<ContentView Grid.Row="1" HorizontalOptions="Fill" VerticalOptions="Fill">
                    <map:Map InitialCameraUpdate="24.131345,44.58172,4,0,90" Padding="0" x:Name="AndroidMap" MapType="Street"
         HasZoomEnabled="True"/>
        </ContentView>

and looks fine when i minmize and maxmize application :/ how to slove this issue ?


text:
multiple instances in one account, can share one voice mail service?

In an environment in which there are two or more call centers implemented in a single account, how to set this up so both  call centers can use the same voice mail infrastructure.  The formation template asks for instance ARN, is there a way to accomplish this or do you have to built the vm solution twice?

Hi DrVoIP, the solution is designed to work per instance of Amazon Connect only. You need to deploy per instance.
We will update our changelog if it is supported in the future. You can subscribe to GitHub repo notification emails for updates.


text:
Streamlines ISL model using version maker traits

Issue #187
Description of changes:
This PR works on streamlining the ISL model using version maker traits.
List of changes:

adds version marker traits which will be used to construct schema,
types and constraints for a particular ISL version
adds logic constraints implementations
adds type reference, type and import implementations based on version
marker trait
adds example usage of this new change for the ISL model

Note for reviewers:

This PR creates a new module version_based_isl which will eventually be placed as the current isl module. This is because the change is too big and involves changing mostly entire ISL model. In order to divide the change into pieces created version_based_isl.
All the structs/enums for ISL model are same as previous ISL model except they now accept a generic V(version marker trait).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Overall versioned ISL model gives an ease of use, maintainability and gives compile time checks for ISL version on types, constraints and schema.

Eventually, we really need to address the fact that some constraints have their own structs, and others are just an enum variant that's a tuple. If you're rewriting the model, this seems like an ideal time to fix it.

Previous ISL model had tuples for enum variants for all the constraints. I have created a struct for each constraint so that we have the same pattern throughout for all constraints be it a constraint thats same for both ISL versions or its different for different ISL versions. It gives us a nice distinction between how 2 different versions would work for a particular constraint. Also eventually if we decide to have single model that will be used for representation as well as validation then it makes sense to create different structs for all the constraints as each one will have its own validation.

I'd recommend something like this to eliminate some of the boilerplate for constraints. https://gist.github.com/popematt/11b1e632ed487d11ba50eda1bb43a78a (Note that this will not work exactly because it doesn't have the version it it.) As a bonus, a macro like this will mean that we also get a proper struct for each constraint.

Adding a macro to create the structs for constraints does sound like good idea. I could create an issue for it.

What other solutions did you consider? (Have you considered creating versioned builders for a versionless model?)
What made you choose a versioned model over those other solutions? (I'd like to understand any tradeoffs, etc.)

I have chosen to go with versioned model using the version maker trait because that gives a better API to construct ISL model constraints/types and schema. This allows us to have compile time errors for when a user tries to mix two different versions of schema. I think this provides an ease of use for customers as well as ensures the different version constraints aren't mixed.

repo: amazon-ion/ion-schema-rust


text:
Memory usage out of control when dragging the window?

I'm on Windows 10.
When starting the game, the RAM usage is at about 25MB. But as soon as I start dragging the window across the screen, the RAM usage increases at a rapid pace without stopping, to the point of reaching 2GB+ after a few seconds.
I was able to reproduce this with the chapter 2 tutorial code

I can replicate this as well. In just a couple seconds I went from 12mb to over 7 Gigs.

This should have been alleviated in the recent #239 and #241 patches. It now only calls on_resize when tick time comes around, reducing the overhead quite a lot. It looks decent on my Mac and Windows machines. Could you give it a go, please?

Just to make sure, is this the right config for cargo.toml?
[dependencies.bracket-lib]
branch = "scaling"
features = ["serde"]
git = "https://github.com/amethyst/bracket-lib"

I tried on my own project: the memory usage rises way more slowly, up until ~50-60MB. Then it explodes like before, hitting 2GB+ in a few seconds. You really have to drag and resize the window for at least 30 seconds to trigger the exponential ram usage, so definitely not something that could happen in a normal use.
Also, maybe related to those changes, the framerate seems to capped at 30fps (with or without vsync)

You can switch to the master branch - the feature has been merged now. Good to see it improved, even if it isn't fixed - I'll see if I can torture test it a bit more.
The FPS cap at 30 is the new default. You can add a with_fps_cap(x) to your initialization to change it. Most users are implementing slow-moving roguelikes, so that's a fair default for them - and keeps CPU usage way down.

I tried it again today, and it looks fixed 👍
Thank you

authors: BiosElement scambier thebracket

repo: amethyst/bracket-lib


text:
Include template files

This PR adds the build script functionality back and changes deploy to use the included files.
Note that the build script doesn't account for different templates, only main templates.  Thus, deploy doesn't change its behavior based on the template parameter. I'll open an issue to add functionality to determine more templates if and when this PR is merged.
Closes #71

This is the first time I've written Rust. I'm open to suggestions and feedback, even if it's simply idiomatic changes.

https://travis-ci.org/amethyst/tools/jobs/545270691#L635 - liquid doesn't build anymore.

also see https://github.com/rust-lang/rust/issues/60958#issuecomment-498084664

Is this blocking the PR? I can look into liquid's repo and see if this is an issue in the current version, and I can open an issue to do a general upgrade for this project, moving to Rust 2018 and upgrading the other packages. I can encompass the liquid build issue along with any other packages that might break the build.

It's failing CI, but I guess I can merge like this.

authors: BradLugo torkleyy

repo: amethyst/tools


text:
Success page

Simple page to show that the order was placed and is in process. Page exists, but is currently blank.

done

repo: amiedawn/taco-shop


text:
no output, tests pass

Trying this for the first time, installed via pip for python3. Does not seem to work, without giving any errors.
Running example from the docs:
0 $ echo '{"a": {"b": 1}}' | python3 -m flatten_json
0 $

The 0 is the exit status.
Running the test suite also passes:
0 $ python3 /home/zuzuzu/.local/lib/python3.6/site-packages/test_flatten.py
............
----------------------------------------------------------------------
Ran 12 tests in 0.001s

OK
0 $

Any ideas?

Works for me with flatten-json 0.1.7
bash-3.2$ echo '{"a": {"b": 1}}' | python3 -m flatten_json
{"a_b": 1}

Please double check again, updating the package. If still nothing, it could be a bash problem.

Yes, has been fixed since.

authors: lynxlynxlynx manycoding

repo: amirziai/flatten


text:
怎么提供离线版本的？

怎么离线使用，有cdn太慢了，希望能在不联网的条件下使用有什么办法？

这样离线，其中 amis.html 从源代码里面拷贝，static 中的文件逐个下载即刻。
from starlette.requests import Request
from fastapi.responses import HTMLResponse, JSONResponse, Response
from fastapi_amis_admin.amis.components import Page
from fastapi_amis_admin.admin.site import AdminSite as _AdminSite
from fastapi_amis_admin.amis.types import BaseAmisApiOut
from fastapi_amis_admin.utils.translation import i18n as _
from fastapi_amis_admin.amis.components import App
from pydantic.utils import deep_update
import os

class OfflineAdminSite(_AdminSite):
    """ 支持离线跑 fastapi-amis-admin"""

    template_path = os.path.join(os.path.dirname(os.path.realpath(__file__)), 'amis.html')

    async def get_page(self, request: Request) -> App:
        app: App = await super().get_page(request)
        # 去掉版权信息
        app.header = None
        app.footer = None
        return app

    async def page_parser(self, request: Request, page: Page) -> Response:
        """ 离线化处理 """
        if request.method == "GET":
            result = page.amis_html(
                template_path=self.template_path,
                locale=_.get_language(),
                cdn=self.site.settings.amis_cdn,
                pkg=self.site.settings.amis_pkg,
                theme=self.site.settings.amis_theme,
                site_title=self.site.settings.site_title,
                site_icon=self.site.settings.site_icon,
            )
            result = HTMLResponse(result)
        else:
            data = page.amis_dict()
            if await request.body():
                data = deep_update(data, (await request.json()).get("_update", {}))
            result = BaseAmisApiOut(data=data)
            result = JSONResponse(result.dict())
        return result

没那么复杂，只需要把settings里的amis_cdn改成相对路径，比如/static，准备一个目录，把amis，history，vue（虽然不知道有什么用）这三个npm库对应版本文件按对应目录命名好放到里面，可以看本项目的模板app.html，也可以实际看chrome请求了哪些静态文件。到 http://npmmirror.com 下载。
然后在FastApi里面mount对应的目录到/static
https://fastapi.tiangolo.com/zh/tutorial/static-files/
或者如果外层有Nginx，加一条 location ^~ /static/ 指向这个目录也行。

authors: EchoShoot oubeichen

repo: amisadmin/fastapi-amis-admin


text:
Fix Bug ignore private repo logic

In line 48 if expression had a bug: private repos would be skipped if ignorePrivate is false.

@arborknot-ci thanks for the fix! Would you be able to add a test please? I have been trying to improve the code quality, and if we take these chances to at least add tests to start with, that would be progress.

@amitsaha Hi, I'm sorry but I didn't quite understand the logic behind the tests you wrote nor I have the time to write one right now.
If you could insert the PR for now, It would be much appreciated.

No worries, thanks - the new release has been created, binaries should be available shortly at https://github.com/amitsaha/gitbackup/releases/tag/v0.8.2

authors: amitsaha arborknot-ci shovalg

repo: amitsaha/gitbackup


text:
Warnings in generated scanner.rb in some situations

In some situations (TBD), while running unit tests for https://github.com/rapid7/recog/, we get warnings like:
/home/jhart/.rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/regexp_parser-0.3.0/lib/regexp_parser/scanner.rb:2463: warning: mismatched indentations at 'end' with 'begin' at 1713
... dozens of these ...
/home/jhart/.rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/regexp_parser-0.3.0/lib/regexp_parser/scanner.rb:2753: warning: statement not reached
/home/jhart/.rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/regexp_parser-0.3.0/lib/regexp_parser/scanner.rb:1648: warning: assigned but unused variable - testEof
/home/jhart/.rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/regexp_parser-0.3.0/lib/regexp_parser/scanner.rb:2236: warning: duplicated when clause is ignored
/home/jhart/.rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/regexp_parser-0.3.0/lib/regexp_parser/lexer.rb:118: warning: assigned but unused variable - replace
/home/jhart/.rbenv/versions/2.2.1/lib/ruby/gems/2.2.0/gems/regexp_parser-0.3.0/lib/regexp_parser/scanner.rb:4200: warning: instance variable @literal not initialized

I also got these with 0.2.1.
You can reproduce most of these with ruby -we 'require "regexp_parser"; Regexp::Scanner.scan(/(foo)/) do |token_parts| puts "capture" if token_parts.first == :group  && ![:close, :passive].include?(token_parts[1]); end'

Thanks for the report.
Only one of these warning is caused by non-generated code (the one in lexer.rb:118). A fix for that one was just pushed to the dev branch. A new release will be made tomorrow.
For the rest, I couldn't find options that could fix the generated output, and I'm hesitant to add a post-processing step to do it. This is clearly an issue with ragel.
I will investigate a little more to see if others had to deal with this before.

So I took a look at whitequark/parser's ragel compilation and they just disable indentation warnings in their generated source code using the warn-indent magic comment. I think regexp_parser should use this too

Fixed with the release of 0.3.6

authors: ammar backus jhart-r7


text:
[WIP] Ignorable Coordinates for Can-pb Updater

See DR#523 for details.
Merging the production branch into gk-g0-app to avoid having to merge the prototyping branch into main then into gk-g0-app.
WIP Status:

Need to resolve using conf vs phase basis for kernel selection with @JunoRavin.
Issue with 2x3v p2 ser (seen in the toroidal test case moments). Besides this, everything else works. I've written another 2x3v test for cylindrical coordinates that works fine.

Checks of additions:

Verified all old/new can-pb regression tests, can-pb unit tests, and Valgrind clean for sample regression tests.

Unrelated to my changes:

regression/rt_multib_step_sol_2x2v_p1.c and regression/rt_vlasov_lbo_cross_1x1v_p2.c both fail to build with only MPI.

Issue with 2x3v p1/p2 toroidal rt not agrreing was due to insufficient spatial resolution in theta, it's been fixed:

repo: ammarhakim/gkylzero


text:
Support for shell variables? and for a set -xv mode?

Hi,
first i have to say, your tool is fantastic. i really love writing stuff with sh instead of bash. i have a few  proposals for enhancements:

support for a set -xv mode so i can see which actual shell commands are run? that would be helpful
is there a possibility to support shell variables? for example in bash "a=b c=d command" will have a and c as variables available (and modify commands behaviour), this is not the same as environment variables apparently (was new to me, too).

at least for the last one, i will try to make a patch, but my python is very hacky...
Yours,
Dennis

Hi Dennis, thanks for your thoughts.

This is accomplished through Python's logging:

import logging
import sh
logging.basicConfig(level=logging.INFO)
sh.ls()

Output:
INFO:sh.command:<Command '/bin/ls'>: starting process
INFO:sh.command:<Command '/bin/ls', pid 32394>: process started
INFO:sh.command:<Command '/bin/ls', pid 32394>: process completed

It won't be supported.

Okay, cool, thanks. Could you reference the first one in the documentation? it was not clear to me and i would bet i could forget it. And i suppose other people would appreciate it as well

Good idea 25862f8c454c4e1b9caf52fa861735ca3e874e3e

<3

authors: amoffat dkmbw

repo: amoffat/sh


text:
Initialize Github Wiki

Acceptance criteria

Created Wiki with basic structure

Definition of done (DoD)

Added only after week 5
The same for all features
Here goes the project specific part

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

Done by somebody else.

authors: Corgam op-hub


text:
Test issue

issue edited

issue comment created

issue comment created

repo: amp-rcebulko-test-org/amp-github-apps


text:
Better error message for missing Server::expose

A missing Server::expose() currently results in the following error message:
PHP Fatal error:  Uncaught Error: At least one interface must be specified (see Aerys\Internal\Host::expose()), an empty interfaces array is not allowed
The error message shouldn't refer to an internal API, but instead refer to Server::expose().

Sockets are now passed as constructor argument to Server, but I think there's still no check for an empty array.

repo: amphp/http-server