text:
python312Packages.htmldate: 1.8.0 -> 1.8.1

Changelog: https://github.com/adbar/htmldate/blob/v1.8.1/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 303557 run on x86_64-linux 1

8 packages built:

python311Packages.htmldate
python311Packages.htmldate.dist
python311Packages.trafilatura
python311Packages.trafilatura.dist
python312Packages.htmldate
python312Packages.htmldate.dist
python312Packages.trafilatura
python312Packages.trafilatura.dist


text:
[23.11] gitea: backport CSP patch in markdown renderer

See https://github.com/NixOS/nixpkgs/pull/304494#issuecomment-2059284122
Note: please await a review from @techknowlogick
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Looks right to me & passthru.tests pass, nixos x86_64

ping @techknowlogick

A review from the upstream devs would've been cool, but given that it got double-checked, I'll merge now.

@Ma27 ack, apologies for missing the ping. thanks for merging :)

source: gharchive/pull-request

authors: Ma27 risicle techknowlogick

repo: NixOS/nixpkgs

license: MIT

license_type: permissive

license_source: github-api


text:
unciv: 4.11.12 -> 4.11.13

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/yairm210/Unciv/releases.
meta.description for unciv is: An open-source Android/Desktop remake of Civ V
meta.homepage for unciv is: https://github.com/yairm210/Unciv
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.11.13 in filename of file in /nix/store/03wn8frny00kyb858jpkbmaz314qxc7s-unciv-4.11.13

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

unciv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/03wn8frny00kyb858jpkbmaz314qxc7s-unciv-4.11.13 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A unciv https://github.com/r-ryantm/nixpkgs/archive/a78af08f5e9806eef5cd135ff9ccc8685ea7ffdb.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/a78af08f5e9806eef5cd135ff9ccc8685ea7ffdb#unciv

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/03wn8frny00kyb858jpkbmaz314qxc7s-unciv-4.11.13
ls -la /nix/store/03wn8frny00kyb858jpkbmaz314qxc7s-unciv-4.11.13/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

unciv

Maintainer pings
cc @tex for testing.

@ofborg eval

authors: cole-h r-ryantm


text:
fastfetch: 2.13.0 -> 2.13.1

Description of changes
Updated fastfetch

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 313444 run on x86_64-linux 1

2 packages built:

fastfetch
fastfetch.man

Next update (or this one) I can be removed from maintainers, as I don't actively use Fastfetch and there seems to be more than enough people with eyes on it

Result of nixpkgs-review pr 313444 run on aarch64-darwin 1

2 packages built:

fastfetch
fastfetch.man

Result of nixpkgs-review pr 313444 run on aarch64-darwin 1

2 packages built:

fastfetch
fastfetch.man

authors: Gerg-L HeitorAugustoLN khaneliman wegank


text:
trealla: 2.52.6 -> 2.52.9

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/trealla-prolog/trealla/releases.
meta.description for trealla is: A compact, efficient Prolog interpreter written in ANSI C
meta.homepage for trealla is: https://trealla-prolog.github.io/trealla/
meta.changelog for trealla is: https://github.com/trealla-prolog/trealla/releases/tag/v2.52.9
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.52.9 with grep in /nix/store/clpq4gdfdqy3mjy3cx4v2mk9df1mdqn9-trealla-2.52.9
found 2.52.9 in filename of file in /nix/store/clpq4gdfdqy3mjy3cx4v2mk9df1mdqn9-trealla-2.52.9

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

trealla

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/clpq4gdfdqy3mjy3cx4v2mk9df1mdqn9-trealla-2.52.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A trealla https://github.com/r-ryantm/nixpkgs/archive/74487e0879ac96bd2a46184d5eb0d832d6818ead.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/74487e0879ac96bd2a46184d5eb0d832d6818ead#trealla

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/clpq4gdfdqy3mjy3cx4v2mk9df1mdqn9-trealla-2.52.9
ls -la /nix/store/clpq4gdfdqy3mjy3cx4v2mk9df1mdqn9-trealla-2.52.9/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

trealla

Maintainer pings
cc @siraben @AndersonTorres for testing.

@NixOS/nixpkgs-merge-bot merge

authors: AndersonTorres r-ryantm


text:
roslyn-ls: 4.10.0-2.24124.2 -> 4.12.0-1.24359.11

Description of changes
Updating the package.
Added dotnet sdk 9 and removed all other sdks - whether they're present or not, the app compiles and works the same, and the generated deps.nix are also the same.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

cannot fetch-deps, possible cause? https://github.com/NixOS/nixpkgs/issues/315574

eh, current status: linux - works, darwin - build error

Because the fix for darwin build in the upstream repo is nowhere in sight, could we try a different approach here?
I have a working example in my personal repo where I install roslyn-ls from the Nuget packages published to this feed - those are official Microsoft builds.
This is the same approach that VSCode's C# Dev Kit extension uses to install this server based on: https://github.com/dotnet/roslyn/issues/71474#issuecomment-2177303207
@SuperSandro2000 could we have something like that in nixpkgs? It would simplify this package quite a bit, but the downside is that we would rely on binary blobs published to nuget. On the other hand, we already rely on them when downloading nuget dependencies for any dotnet project.

Sounds fine to me

I seem to be able to work around the stack overflow error by doing this:
diff --git a/pkgs/by-name/ro/roslyn-ls/deps.nix b/pkgs/by-name/ro/roslyn-ls/deps.nix
index 2bbb08488396..7eb95212be3a 100644
--- a/pkgs/by-name/ro/roslyn-ls/deps.nix
+++ b/pkgs/by-name/ro/roslyn-ls/deps.nix
@@ -63,7 +63,6 @@
   (fetchNuGet { pname = "Microsoft.Extensions.Options.ConfigurationExtensions"; version = "8.0.0"; hash = "sha256-A5Bbzw1kiNkgirk5x8kyxwg9lLTcSngojeD+ocpG1RI="; url = "https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/microsoft.extensions.options.configurationextensions/8.0.0/microsoft.extensions.options.configurationextensions.8.0.0.nupkg"; })
   (fetchNuGet { pname = "Microsoft.Extensions.Primitives"; version = "8.0.0"; hash = "sha256-FU8qj3DR8bDdc1c+WeGZx/PCZeqqndweZM9epcpXjSo="; url = "https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/microsoft.extensions.primitives/8.0.0/microsoft.extensions.primitives.8.0.0.nupkg"; })
   (fetchNuGet { pname = "Microsoft.IO.Redist"; version = "6.0.0"; hash = "sha256-pa3MT+QWrWeehQwUWtTS/Rwto8IIDgAt+zLqaUAQoJ0="; url = "https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/microsoft.io.redist/6.0.0/microsoft.io.redist.6.0.0.nupkg"; })
-  (fetchNuGet { pname = "Microsoft.Net.Compilers.Toolset"; version = "4.11.0-2.24270.4"; hash = "sha256-R4+eMGnUz3Jt4kc0WZdaixaqxO2osKa9RJeMMAMaFAw="; url = "https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/d1622942-d16f-48e5-bc83-96f4539e7601/nuget/v3/flat2/microsoft.net.compilers.toolset/4.11.0-2.24270.4/microsoft.net.compilers.toolset.4.11.0-2.24270.4.nupkg"; })
   (fetchNuGet { pname = "Microsoft.NET.StringTools"; version = "17.10.4"; hash = "sha256-nXY7YaIx6sXn7aMqpF4bW4d2J5U1KNb9sXqRSd8MpOc="; url = "https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/microsoft.net.stringtools/17.10.4/microsoft.net.stringtools.17.10.4.nupkg"; })
   (fetchNuGet { pname = "Microsoft.NET.StringTools"; version = "17.3.4"; hash = "sha256-xLPrrL8iS3gNMIa/C/Wv0fBfHIehUHeQ4Y+F+gbqkhk="; url = "https://pkgs.dev.azure.com/azure-public/3ccf6661-f8ce-4e8a-bb2e-eff943ddd3c7/_packaging/491596af-6d2d-439e-80bb-1ebb3b54f9a8/nuget/v3/flat2/microsoft.net.stringtools/17.3.4/microsoft.net.stringtools.17.3.4.nupkg"; })
   (fetchNuGet { pname = "Microsoft.NET.StringTools"; version = "17.4.0"; hash = "sha256-+9uBaUDZ3roUJwyYJUL30Mz+3C6LE16FzfQKgS0Yveo="; url = "https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/microsoft.net.stringtools/17.4.0/microsoft.net.stringtools.17.4.0.nupkg"; })
diff --git a/pkgs/by-name/ro/roslyn-ls/package.nix b/pkgs/by-name/ro/roslyn-ls/package.nix
index 56a86295efdb..42274eb9206f 100644
--- a/pkgs/by-name/ro/roslyn-ls/package.nix
+++ b/pkgs/by-name/ro/roslyn-ls/package.nix
@@ -43,6 +43,7 @@ buildDotnetModule rec {
   dotnetFlags = [
     # this removes the Microsoft.WindowsDesktop.App.Ref dependency
     "-p:EnableWindowsTargeting=false"
+    "-p:UsingToolMicrosoftNetCompilers=false"
   ];

   # two problems solved here:

However, I haven't tested the resulting binary (other than roslyn-ls.tests).
I was able to track down the stack overflow to a specific csc invocation, and wasn't able to reproduce it using the compiler from the 9.0 preview 6 sdk.  I believe the change above will cause it to use the SDK compiler.

Result of nixpkgs-review pr 318497 run on x86_64-linux 1

1 package built:

roslyn-ls

I also built this on darwin, but I had to disable the sandbox due to https://github.com/NixOS/nix/issues/4119.

Thank you @corngood for the help and fix! I'm building and testing on darwin right now.
I also think we can remove sdk_6_0 from here. I'll follow up.

ok, I removed all sdks except for 9_0 - it does not influence deps.nix anymore and the app still builds and works fine.

Result of nixpkgs-review pr 318497 run on x86_64-linux 1

1 package built:

roslyn-ls

Thanks! Looks good to me. Are you happy if I merge it now?

Have you tested with a project that isn't using SDK 9?  I assume so, but I just want to double check that the SDK change doesn't reduce compatibility.

Result of nixpkgs-review pr 318497 run on x86_64-darwin 1

1 package built:

roslyn-ls

@corngood now I am to merge, as darwin just built 😄
I've tested it with a project that uses dotnet 8 and works fine.

authors: SuperSandro2000 corngood konradmalik


text:
realm-studio: init at 15.2.1

Description of changes
Added Realm Studio, a database viewer/editor for Realm databases.
https://www.mongodb.com/docs/atlas/device-sdks/studio/
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 325967 run on aarch64-darwin 1

1 package built:

realm-studio

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1810


text:
yle-dl: 20240130 -> 20240706

Changelog: https://github.com/aajanki/yle-dl/blob/20240706/ChangeLog
Description of changes

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Could this also get upstreamed to nixos-24.05 as the packages there is old.

nixpkgs-review pr 327198
2 packages built:
yle-dl yle-dl.dist

Builds successfully with nixpkgs-review
Ran command nixpkgs-review pr 327198 with the output:
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/327198/head:refs/nixpkgs-review/1
remote: Enumerating objects: 7, done.
remote: Counting objects: 100% (7/7), done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 7 (delta 2), reused 5 (delta 2), pack-reused 0
Unpacking objects: 100% (7/7), 30.07 KiB | 832.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
 * [new branch]                master                -> refs/nixpkgs-review/0
 * [new ref]                   refs/pull/327198/head -> refs/nixpkgs-review/1
$ git worktree add /home/username/.cache/nixpkgs-review/pr-327198-1/nixpkgs 476b450df82e06afd7de6d9eee622ebe435f1421
Preparing worktree (detached HEAD 476b450df82e)
Updating files: 100% (42280/42280), done.
HEAD is now at 476b450df82e Merge pull request #272380 from chayleaf/gradle2
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/username/.cache/nixpkgs-review/pr-327198-1/nixpkgs nixpkgs-overlays=/tmp/tmptzyfnxvn -qaP --xml --out-path --show-trace --no-allow-import-from-derivation
$ git merge --no-commit --no-ff 1ef35e5a732e80dda7836b27ae8b6d447b4a08bc
Automatic merge went well; stopped before committing as requested
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/username/.cache/nixpkgs-review/pr-327198-1/nixpkgs nixpkgs-overlays=/tmp/tmptzyfnxvn -qaP --xml --out-path --show-trace --no-allow-import-from-derivation --meta
1 package updated:
yle-dl (20240130 → 20240706)

$ nix build --file /nix/store/25z8rbql1lcchxkvcz7bi77fq0ah4xqd-nixpkgs-review-2.10.4/lib/python3.11/site-packages/nixpkgs_review/nix/review-shell.nix --nix-path nixpkgs=/home/username/.cache/nixpkgs-review/pr-327198-1/nixpkgs nixpkgs-overlays=/tmp/tmptzyfnxvn --extra-experimental-features nix-command no-url-literals --no-link --keep-going --no-allow-import-from-derivation --option build-use-sandbox relaxed --argstr system x86_64-linux --argstr nixpkgs-path /home/username/.cache/nixpkgs-review/pr-327198-1/nixpkgs --argstr nixpkgs-config-path /tmp/tmpq8d1r3bw.nix --argstr attrs-path /home/username/.cache/nixpkgs-review/pr-327198-1/attrs.nix

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/327198

2 packages built:
yle-dl yle-dl.dist

$ /nix/store/iss03l7rssrjy43ghfhr06x4pdfii1bh-nix-2.18.4/bin/nix-shell --argstr system x86_64-linux --argstr nixpkgs-path /home/username/.cache/nixpkgs-review/pr-327198-1/nixpkgs --argstr nixpkgs-config-path /tmp/tmpq8d1r3bw.nix --argstr attrs-path /home/username/.cache/nixpkgs-review/pr-327198-1/attrs.nix --nix-path nixpkgs=/home/username/.cache/nixpkgs-review/pr-327198-1/nixpkgs nixpkgs-overlays=/tmp/tmptzyfnxvn /nix/store/25z8rbql1lcchxkvcz7bi77fq0ah4xqd-nixpkgs-review-2.10.4/lib/python3.11/site-packages/nixpkgs_review/nix/review-shell.nix

[nix-shell:~/.cache/nixpkgs-review/pr-327198-1]$ yle-dl version
yle-dl 20240706: Download media files from Yle Areena and Elävä Arkisto
Copyright (C) 2009-2024 Antti Ajanki <antti.ajanki@iki.fi>, license: GPLv3

ERROR: Unsupported URL version.
ERROR: If you think yle-dl should support this page, open a bug report at https://github.com/aajanki/yle-dl/issues

Bottom error is typical for the software since it expects URL and not version check.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4272

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1835

authors: ShadowTux ThatLurker nixos-discourse


text:
gcc14: 14.1.0 -> 14.2.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 331603 run on x86_64-linux 1

14 packages built:

fastStdenv
gcc14
gcc14.info
gcc14.man
gcc14Stdenv
gccgo14
gccgo14.info
gccgo14.man
gfortran14
gfortran14.info
gfortran14.man
gnat14
gnat14.info
gnat14.man

I reproduced the aarch64-darwin build issue on the nix-commuity darwin builder, the fault is in https://github.com/trofi/nixpkgs/blob/9b6543bd8082f76c75873fe5f5f2284d0eef1efb/pkgs/development/compilers/gcc/patches/default.nix#L149

No 14.2.0 patches yet at https://github.com/Homebrew/formula-patches/tree/master/gcc. Can try at https://github.com/iains/gcc-14-branch

No 14.2.0 patches yet at https://github.com/Homebrew/formula-patches/tree/master/gcc. Can try at https://github.com/iains/gcc-14-branch

Updated the patch.

I reproduced the aarch64-darwin build issue on the nix-commuity darwin builder, the fault is in https://github.com/trofi/nixpkgs/blob/9b6543bd8082f76c75873fe5f5f2284d0eef1efb/pkgs/development/compilers/gcc/patches/default.nix#L149

Please try the updated branch. The patch at least applies on x86_64-linux.

the patch applies :+1:

authors: pbsds trofi


text:
Rework install shell files

Description of changes
The nawk part was taken before https://github.com/NixOS/nixpkgs/pull/332084, but it is here for demonstration purposes.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@afh I have taken your bump to make a test here. Can you review it?

Hum, does it cause mass-rebuild?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4382

Two extra ideas:

rename this to installArtifacts,  since it is a more general name than installShellFiles

green alias

include other artifact installers like installDoc

@philiptaron you commented about using testEqualContent. However, from what I have seen, it does test singular files, not directory trees. So I prefer to keep it as is.
@infinisil i want to ask your opinion about a specific decision.
As I have written in https://github.com/NixOS/nixpkgs/pull/332612/commits/f72e74d7aef142ea16d0841fa4322fc1310bb913:

Rationale: Since RFCs 140 and 146, the old category-based hierarchy is
deprecated and obsolete, and a new approach took place: packages should be as
self-contained as possible.
This paradigm is reflected in many new strict checks that prohibit a package to
refer to files outside its directory tree.
Following this spirit, this commit essentially moves nixpkgs
pkgs/test/default.nix to ./tests/default.nix.

What do you think? Is this a good approach?

What do you think? Is this a good approach?

That looks great to me, nice work!


text:
open-webui: Add environmentFile option

Description of changes

This option allows passing secrets to Open WebUI without directly exposing them in nix configuration.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Oh but tests are failing now.

Oh but tests are failing now.

Oh! That was hard to tell from the GitHub Action CI. Turns out the tests were not passing!
I've fixed up the syntax errors, fingers crossed they pass. (I'd run the tests locally, but am on a train with very limited WiFi currently.)

I was not able to get it running locally either.

I wish I could merge this, do you mind having a look at the broken test you're trying to introduce?

Apologies for the delay, I've had some time to fix the test and have tested it works locally. Should pass in CI now!

Note that the CI failures on *-darwin appear unrelated to this PR's changes.

@drupol are you able to have another look? 🙂


text:
makePythonWriter: add doCheck toggle

Description of changes
Add support for doCheck, to toggle flake8 validation in makePythonWriter.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Tested with
  passthru.tests = {
    cube = writers.writePython3 "cube" {
      libraries = [ pyopengltk ];
      doCheck = false;
    } (builtins.readFile "${src}/examples/cube.py");
  };

from #336360

@Lassulus Do you think I should have mention it in the 24.11 release note?


text:
python312Packages.sentence-transformers: 3.1.1 -> 3.2.0

Things done
Changelog: https://github.com/UKPLab/sentence-transformers/releases/tag/3.2.0

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 347861

x86_64-linux

:fast_forward: 4 packages marked as broken and skipped:

khoj
khoj.dist
python311Packages.private-gpt
python311Packages.private-gpt.dist

:white_check_mark: 19 packages built:

aider-chat
aider-chat.dist
open-webui
open-webui.dist
python311Packages.langchain-huggingface
python311Packages.langchain-huggingface.dist
python311Packages.llama-index-embeddings-huggingface
python311Packages.llama-index-embeddings-huggingface.dist
python311Packages.manifest-ml
python311Packages.manifest-ml.dist
python311Packages.sentence-transformers
python311Packages.sentence-transformers.dist
python312Packages.langchain-huggingface
python312Packages.langchain-huggingface.dist
python312Packages.manifest-ml
python312Packages.manifest-ml.dist
python312Packages.sentence-transformers
python312Packages.sentence-transformers.dist
vimPlugins.aider-nvim

aarch64-linux

:fast_forward: 6 packages marked as broken and skipped:

khoj
khoj.dist
open-webui
open-webui.dist
python311Packages.private-gpt
python311Packages.private-gpt.dist

:white_check_mark: 17 packages built:

aider-chat
aider-chat.dist
python311Packages.langchain-huggingface
python311Packages.langchain-huggingface.dist
python311Packages.llama-index-embeddings-huggingface
python311Packages.llama-index-embeddings-huggingface.dist
python311Packages.manifest-ml
python311Packages.manifest-ml.dist
python311Packages.sentence-transformers
python311Packages.sentence-transformers.dist
python312Packages.langchain-huggingface
python312Packages.langchain-huggingface.dist
python312Packages.manifest-ml
python312Packages.manifest-ml.dist
python312Packages.sentence-transformers
python312Packages.sentence-transformers.dist
vimPlugins.aider-nvim

x86_64-darwin

:fast_forward: 20 packages marked as broken and skipped:

khoj
khoj.dist
open-webui
open-webui.dist
python311Packages.langchain-huggingface
python311Packages.langchain-huggingface.dist
python311Packages.llama-index-embeddings-huggingface
python311Packages.llama-index-embeddings-huggingface.dist
python311Packages.manifest-ml
python311Packages.manifest-ml.dist
python311Packages.private-gpt
python311Packages.private-gpt.dist
python311Packages.sentence-transformers
python311Packages.sentence-transformers.dist
python312Packages.langchain-huggingface
python312Packages.langchain-huggingface.dist
python312Packages.manifest-ml
python312Packages.manifest-ml.dist
python312Packages.sentence-transformers
python312Packages.sentence-transformers.dist

aarch64-darwin

:fast_forward: 6 packages marked as broken and skipped:

khoj
khoj.dist
python311Packages.llama-index-embeddings-huggingface
python311Packages.llama-index-embeddings-huggingface.dist
python311Packages.private-gpt
python311Packages.private-gpt.dist

:white_check_mark: 14 packages built:

open-webui
open-webui.dist
python311Packages.langchain-huggingface
python311Packages.langchain-huggingface.dist
python311Packages.manifest-ml
python311Packages.manifest-ml.dist
python311Packages.sentence-transformers
python311Packages.sentence-transformers.dist
python312Packages.langchain-huggingface
python312Packages.langchain-huggingface.dist
python312Packages.manifest-ml
python312Packages.manifest-ml.dist
python312Packages.sentence-transformers
python312Packages.sentence-transformers.dist


text:
python3Packages.lcov-cobertura: fix missing distutils at runtime

Fixes #349331

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Now I get:
[jkolb@nixos:~/nixpkgs]$ nix run .#legacyPackages.x86_64-linux.python3Packages.lcov-cobertura
warning: Git tree '/home/jkolb/nixpkgs' is dirty

    Converts LCOV coverage data to Cobertura-compatible XML for reporting.

    Usage:
        lcov_cobertura.py lcov-file.dat
        lcov_cobertura.py lcov-file.dat -b src/dir -e test.lib -o path/out.xml

    By default, XML output will be written to ./coverage.xml

@mweinelt  for some reason your suggestion caused the file to be unparseable so I did it manually and force pushed. I don't actually need to depend on distutils though. Just having depencencies = [ setuptools ]; seemed to work. I don't know python well enough to know the difference.

Because you didn't import distutils at the time.

authors: kjeremy mweinelt


text:
sway-unwrapped: 1.9 -> 1.10

https://github.com/swaywm/sway/releases/tag/1.10
While the build option for XWayland was dropped xcbutilwm is still required.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 351752 run on x86_64-linux 1

8 packages built:

nwg-panel
nwg-panel.dist
sway
sway-contrib.grimshot
sway-contrib.grimshot.man
sway-unwrapped
waybar
wlprop

I have removed swayidle and swaylock, as those are not used in the default config, but only mentioned as options. I can add them back if someone thinks it might break someone's config

grim is still missing in extraPackages.

I have removed swayidle and swaylock, as those are not used in the default config, but only mentioned as options. I can add them back if someone thinks it might break someone's config

I wouldn't remove those, please revert that change.

Currently running this branch on my system and everything seems to work!

authors: MithicSpirit Scrumplex teutat3s


text:
git-lfs: fix cross compilation

Hides the installShellCompletion behind a stdenv.buildPlatform.canExecute stdenv.hostPlatform guard. This PR is a no-op for non-cross compilations. See https://github.com/NixOS/nixpkgs/issues/308283

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin
[x] riscv64-linux (cross from x86_64)

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofBorg build pkgsCross.aarch64-multiplatform.git-lfs

authors: Atemu skeuchel


text:
xorg.xtrans: 1.5.1 -> 1.5.2

Changes: https://lists.x.org/archives/xorg-announce/2024-November/003554.html

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4939

authors: nixos-discourse trofi


text:
flood-for-transmission: 2024-05-18T08-04-58 → 2024-11-16T12-26-17

Changelog: https://github.com/johman10/flood-for-transmission/compare/2024-05-18T08-04-58...2024-11-16T12-26-17
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/2162

Thank you!


text:
vimPlugins.snacks-nvim: 2024-11-26 -> 2024-12-01

Things done

New profiler snack and lots of updates
https://github.com/folke/snacks.nvim/releases/tag/v2.6.0

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Folke is pretty active today, so bumped with latest changes.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 360824

x86_64-linux

:white_check_mark: 2 packages built:

vimPlugins.snacks-nvim
vimPluginsUpdater

aarch64-linux

:white_check_mark: 2 packages built:

vimPlugins.snacks-nvim
vimPluginsUpdater

x86_64-darwin

:white_check_mark: 2 packages built:

vimPlugins.snacks-nvim
vimPluginsUpdater

aarch64-darwin

:white_check_mark: 2 packages built:

vimPlugins.snacks-nvim
vimPluginsUpdater


text:
cmake: 3.30.5 -> 3.31.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for cmake is: Cross-platform, open-source build system generator
meta.homepage for cmake is: https://cmake.org/
meta.changelog for cmake is: https://cmake.org/cmake/help/v3.31/release/3.31.html
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.31.2 with grep in /nix/store/hd4lsl5i5z6wamcs1spni9n13zik1nrq-cmake-3.31.2
found 3.31.2 in filename of file in /nix/store/hd4lsl5i5z6wamcs1spni9n13zik1nrq-cmake-3.31.2

Rebuild report (if merged into master) (click to expand)

57490 total rebuild path(s)

57489 package rebuild(s)

First fifty rebuilds by attrpath

ArchiSteamFarm
CuboCore.coreaction
CuboCore.corearchiver
CuboCore.corefm
CuboCore.coregarage
CuboCore.corehunt
CuboCore.coreimage
CuboCore.coreinfo
CuboCore.corekeyboard
CuboCore.corepad
CuboCore.corepaint
CuboCore.corepdf
CuboCore.corepins
CuboCore.corerenamer
CuboCore.coreshot
CuboCore.corestats
CuboCore.corestuff
CuboCore.coreterminal
CuboCore.coretime
CuboCore.coretoppings
CuboCore.coreuniverse
CuboCore.libcprime
CuboCore.libcsys
DisnixWebService
Fabric
LAStools
LPCNet
MMA
OVMF
OVMF-cloud-hypervisor
OVMFFull
QuadProgpp
R
SDL
SDL1
SDL2
SDL2_Pango
SDL2_gfx
SDL2_image
SDL2_image_2_0
SDL2_image_2_6
SDL2_mixer
SDL2_mixer_2_0
SDL2_net
SDL2_sound
SDL2_ttf
SDL_Pango
SDL_audiolib
SDL_compat

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/hd4lsl5i5z6wamcs1spni9n13zik1nrq-cmake-3.31.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cmake https://github.com/r-ryantm/nixpkgs/archive/316cbbd0bc9e0714d75993238e22f1010d67a548.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/316cbbd0bc9e0714d75993238e22f1010d67a548#cmake

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/hd4lsl5i5z6wamcs1spni9n13zik1nrq-cmake-3.31.2
ls -la /nix/store/hd4lsl5i5z6wamcs1spni9n13zik1nrq-cmake-3.31.2/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @ttuegel @LnL7 for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for cmake is: Cross-platform, open-source build system generator
meta.homepage for cmake is: https://cmake.org/
meta.changelog for cmake is: https://cmake.org/cmake/help/v3.31/release/3.31.html
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.31.3 with grep in /nix/store/viphrrivan80ly6gw36y9zbra6fwxn4k-cmake-3.31.3
found 3.31.3 in filename of file in /nix/store/viphrrivan80ly6gw36y9zbra6fwxn4k-cmake-3.31.3

Rebuild report (if merged into master) (click to expand)

57643 total rebuild path(s)

57642 package rebuild(s)

First fifty rebuilds by attrpath

ArchiSteamFarm
CuboCore.coreaction
CuboCore.corearchiver
CuboCore.corefm
CuboCore.coregarage
CuboCore.corehunt
CuboCore.coreimage
CuboCore.coreinfo
CuboCore.corekeyboard
CuboCore.corepad
CuboCore.corepaint
CuboCore.corepdf
CuboCore.corepins
CuboCore.corerenamer
CuboCore.coreshot
CuboCore.corestats
CuboCore.corestuff
CuboCore.coreterminal
CuboCore.coretime
CuboCore.coretoppings
CuboCore.coreuniverse
CuboCore.libcprime
CuboCore.libcsys
DisnixWebService
Fabric
LAStools
LPCNet
MMA
OVMF
OVMF-cloud-hypervisor
OVMFFull
QuadProgpp
R
SDL
SDL1
SDL2
SDL2_Pango
SDL2_gfx
SDL2_image
SDL2_image_2_0
SDL2_image_2_6
SDL2_mixer
SDL2_mixer_2_0
SDL2_net
SDL2_sound
SDL2_ttf
SDL_Pango
SDL_audiolib
SDL_compat

Instructions to test this update (click to expand)

Either download from the cache:
nix-store -r /nix/store/viphrrivan80ly6gw36y9zbra6fwxn4k-cmake-3.31.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cmake https://github.com/r-ryantm/nixpkgs/archive/152d7e78818519b2c775dd4fc39747a96eb42520.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/152d7e78818519b2c775dd4fc39747a96eb42520#cmake

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/viphrrivan80ly6gw36y9zbra6fwxn4k-cmake-3.31.3
ls -la /nix/store/viphrrivan80ly6gw36y9zbra6fwxn4k-cmake-3.31.3/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @ttuegel @LnL7 for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.


text:
replaceVarsWith: fix checkPhase with dir set

The newly introduced replaceVarsWith didn't run the checkPhase properly when dir was set. Extended the test-suite to cover those cases, too.
Also move all the remaining cases of "substituteAll + isExecutable" to replaceVarsWith.
Working towards #237216.
CC @philiptaron
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I'm going to do a build of stdenv and run the tests then I intend to merge.

authors: philiptaron wolfgangwalther


text:
lxqt.lxqt-qtplugin: 0.12.0 -> 0.13.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/lxqt-qtplugin/versions.
Version release notes (from GitHub):
These checks were done:

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

directory tree listing: https://gist.github.com/c6381d7911d526753a3a9f2ef17dc34e

du listing: https://gist.github.com/bc019cd05de1faa42bc8d394d3390267

meta.description for lxqt.lxqt-qtplugin is: '"LXQt Qt platform integration plugin"'.
cc @romildo for testing.
This build is cached with Cachix. To use the cache follow these instructions:
One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout 5cf6e3aa6a366f5f1d47ee3ab68d458ea08204cc && nix-shell --pure -I nixpkgs=. -p lxqt.lxqt-qtplugin

Success on x86_64-linux (full log)
Attempted: lxqt.lxqt-qtplugin
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rdhk3pfn2f2fj1sha4v5l459cg8gb6ip-lxqt-qtplugin-0.13.0
shrinking /nix/store/rdhk3pfn2f2fj1sha4v5l459cg8gb6ip-lxqt-qtplugin-0.13.0/lib/qt-5.11/plugins/platformthemes/libqtlxqt.so
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rdhk3pfn2f2fj1sha4v5l459cg8gb6ip-lxqt-qtplugin-0.13.0/lib
patching script interpreter paths in /nix/store/rdhk3pfn2f2fj1sha4v5l459cg8gb6ip-lxqt-qtplugin-0.13.0
checking for references to /build in /nix/store/rdhk3pfn2f2fj1sha4v5l459cg8gb6ip-lxqt-qtplugin-0.13.0...
postPatchMkspecs
postPatchMkspecs
/nix/store/rdhk3pfn2f2fj1sha4v5l459cg8gb6ip-lxqt-qtplugin-0.13.0

Success on aarch64-linux (full log)
Attempted: lxqt.lxqt-qtplugin
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l35zmmcn2dac8cg7c217fj48jr5w2l78-lxqt-qtplugin-0.13.0
shrinking /nix/store/l35zmmcn2dac8cg7c217fj48jr5w2l78-lxqt-qtplugin-0.13.0/lib/qt-5.11/plugins/platformthemes/libqtlxqt.so
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l35zmmcn2dac8cg7c217fj48jr5w2l78-lxqt-qtplugin-0.13.0/lib
patching script interpreter paths in /nix/store/l35zmmcn2dac8cg7c217fj48jr5w2l78-lxqt-qtplugin-0.13.0
checking for references to /build in /nix/store/l35zmmcn2dac8cg7c217fj48jr5w2l78-lxqt-qtplugin-0.13.0...
postPatchMkspecs
postPatchMkspecs
/nix/store/l35zmmcn2dac8cg7c217fj48jr5w2l78-lxqt-qtplugin-0.13.0

Failure on x86_64-darwin (full log)
Attempted: lxqt.lxqt-qtplugin
Partial log (click to expand)

trying https://github.com/lxde/lxqt-qtplugin/archive/0.13.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   125    0   125    0     0    224      0 --:--:-- --:--:-- --:--:--   224
100   126    0   126    0     0    168      0 --:--:-- --:--:-- --:--:--   168
100 26280  100 26280    0     0  20091      0  0:00:01  0:00:01 --:--:-- 11.2M
unpacking source archive /private/tmp/nix-build-source.drv-0/0.13.0.tar.gz
cannot build derivation '/nix/store/8a5j683azbadaw5bn96n2257pnxysyaf-lxqt-qtplugin-0.13.0.drv': 3 dependencies couldn't be built
error: build of '/nix/store/8a5j683azbadaw5bn96n2257pnxysyaf-lxqt-qtplugin-0.13.0.drv' failed

authors: GrahamcOfBorg r-ryantm


text:
dtkwidget: init at 2.0.9.3

Motivation for this change

Add dtkwidget (Deepin graphical user interface library).
dtkcore: only define QT_HOST_DATA if it is empty, enable parallel building.

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Attempted: deepin.dtkcore, deepin.dtkwidget
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/n65qc9nd8nrpyiqs1pfg5gidmca2wpqz-dtkwidget-2.0.9.3
shrinking /nix/store/n65qc9nd8nrpyiqs1pfg5gidmca2wpqz-dtkwidget-2.0.9.3/lib/dtk2/dtk-svgc
shrinking /nix/store/n65qc9nd8nrpyiqs1pfg5gidmca2wpqz-dtkwidget-2.0.9.3/lib/libdtkwidget.so.2.0.6
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n65qc9nd8nrpyiqs1pfg5gidmca2wpqz-dtkwidget-2.0.9.3/lib
patching script interpreter paths in /nix/store/n65qc9nd8nrpyiqs1pfg5gidmca2wpqz-dtkwidget-2.0.9.3
checking for references to /build in /nix/store/n65qc9nd8nrpyiqs1pfg5gidmca2wpqz-dtkwidget-2.0.9.3...
postPatchMkspecs
postPatchMkspecs

Success on aarch64-linux (full log)
Attempted: deepin.dtkcore, deepin.dtkwidget
Partial log (click to expand)
shrinking /nix/store/snlyh8a7hssz64gmdk0ca8iw8gnd21cm-dtkwidget-2.0.9.3/lib/dtk2/dtk-svgc
shrinking /nix/store/snlyh8a7hssz64gmdk0ca8iw8gnd21cm-dtkwidget-2.0.9.3/lib/libdtkwidget.so.2.0.6
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/snlyh8a7hssz64gmdk0ca8iw8gnd21cm-dtkwidget-2.0.9.3/lib
patching script interpreter paths in /nix/store/snlyh8a7hssz64gmdk0ca8iw8gnd21cm-dtkwidget-2.0.9.3
checking for references to /build in /nix/store/snlyh8a7hssz64gmdk0ca8iw8gnd21cm-dtkwidget-2.0.9.3...
postPatchMkspecs
postPatchMkspecs
/nix/store/2b6yigc7nzlkhd21jx0lrq7lm6nqqbrq-dtkcore-2.0.9
/nix/store/snlyh8a7hssz64gmdk0ca8iw8gnd21cm-dtkwidget-2.0.9.3

authors: GrahamcOfBorg romildo


text:
ponyc: 0.24.4 -> 0.25.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ponyc/versions.
meta.description for ponyc is: '"Pony is an Object-oriented, actor-model, capabilities-secure, high performance programming language"'.
Release on GitHub
Compare changes on GitHub

Checks done (click to expand)

built on NixOS
/nix/store/7qikwaj0xrzis8af3mlz5hw4x0mzbrir-ponyc-0.25.0/bin/.ponyc-wrapped passed the binary check.
/nix/store/7qikwaj0xrzis8af3mlz5hw4x0mzbrir-ponyc-0.25.0/bin/ponyc passed the binary check.
2 of 2 passed binary check by having a zero exit code.
0 of 2 passed binary check by having the new version present in output.
found 0.25.0 with grep in /nix/store/7qikwaj0xrzis8af3mlz5hw4x0mzbrir-ponyc-0.25.0
directory tree listing: https://gist.github.com/c4aeb454e221e27f31a4b783c0695717
du listing: https://gist.github.com/3345878541adce1e68627c055b4b3b91

Outpath report (click to expand)

Outpath difference report
6 total rebuild paths
2 package rebuilds
2 x86_64-linux rebuilds
1 i686-linux rebuilds
2 x86_64-darwin rebuilds
1 aarch64-linux rebuilds
First ten rebuilds by attrpath
pony-stable
ponyc

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7qikwaj0xrzis8af3mlz5hw4x0mzbrir-ponyc-0.25.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A ponyc https://github.com/r-ryantm/nixpkgs/archive/7a711b5f544a919173725acf34c5cbe9db4db8c0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7qikwaj0xrzis8af3mlz5hw4x0mzbrir-ponyc-0.25.0
ls -la /nix/store/7qikwaj0xrzis8af3mlz5hw4x0mzbrir-ponyc-0.25.0/bin

cc @doublec @kamilchm @patternspandemic for testing.

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: ponyc
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-darwin (full log)
Attempted: ponyc
Partial log (click to expand)
 Data types
 Function prototypes
 Functions
 Descriptors
Writing examples/yield/yield.o
Linking examples/yield/yield
installing
post-installation fixup
patching script interpreter paths in /nix/store/0590kr83cs6qh8ynszzpdavihhlxqara-ponyc-0.25.0
/nix/store/0590kr83cs6qh8ynszzpdavihhlxqara-ponyc-0.25.0


text:
terraform-providers: Bump all releases

Does what it says on the tin. Auto-generated.
Motivation for this change
I needed a newer version of terraform-provider-digitalocean
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

thanks!

authors: arianvp zimbatm


text:
nixos: add XDG sounds module

Motivation for this change
As suggested in https://github.com/NixOS/nixpkgs/issues/47173.
Implementation is trivial: AFAICT there's not much to do other than link the directory.
@jtojnar @worldofpeace (I think you wanted this for the elementary PR)
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I'm testing to see If this resolves things.

Couldn't we just auto-enable this when hardware.sound.enable = true;?

authors: Infinisil michaelpj worldofpeace


text:
openspades: Fix Darwin build

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build openspades


text:
gpgme: 1.12.0 -> 1.13.0

Motivation for this change
https://lists.gnupg.org/pipermail/gnupg-announce/2019q1/000437.html
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

(borg failure is darwin eval re:hfsevents, see #58216, unrelated)


text:
python3Packages.pyfxa: fix tests

Motivation for this change
noticed it was failing while reviewing: #74799
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @
[4 built, 3 copied (0.2 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/74848
3 package were built:
python27Packages.pyfxa python37Packages.pyfxa python38Packages.pyfxa

@GrahamcOfBorg build python27Packages.pyfxa python37Packages.pyfxa python38Packages.pyfxa


text:
nixos/home-assistant: fix bug causing config file not to be written (including http.server_port)

Motivation for this change
This fixes  #82076 by ensuring that the configuration.yaml file is always (over)written. I think this approach simplifies things a bit, and to me aligns more with what I would assume "default config" means. I'm not sure it's the right way though, since it changes the behaviour of  applyDefaultConfig.
It would be great to get some feedback on a few points in particular:

Would is be better to set defaultConfig to a subset of the contents of the default configuration.yaml file plus the port and timezone? For now I just have frontend in there. This might be less of a breaking change but it would mean keeping up to date when home-assistant changes that file. For reference, this is what that file looks like:# Configure a default setup of Home Assistant (frontend, api, etc)
default_config:

# Uncomment this if you are using SSL/TLS, running in Docker container, etc.
# http:
#   base_url: example.duckdns.org:8123

# Text to speech
tts:
  - platform: google_translate

# These files all start off empty
group: !include groups.yaml
automation: !include automations.yaml
script: !include scripts.yaml
scene: !include scenes.yaml

Tests: I've never written nixos tests before, so I don't know if this is the right approach, or whether this kind of test is necessary. Either way, it was useful to debug the problem.

NOTE: some of the home-assistant tests seem to be failing currently, but this appears to be caused by #82441
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@colemickens or @dotlambda does this change make sense to either of you?

I'm not sure I'm familiar enough, or having enough time, to review this well. cc: @mic92 even though I think they've seen it.

ping @colemickens @dotlambda @Mic92 @peterhoeg
I'm sure @matt-snider would appreciate a review very much so. Is anyone able to sacrifice some time and help out with this? :heart:

Thank you @Mic92!

@matt-snider what do you need to push this through to the finish line?

@aanderse Thanks for following up! I think the main suggestion from @Mic92 was to remove the tests. Otherwise, from his comment "So the actual bug fix is this line?", I interpret that a more minimal change would be preferable. That's understandable, since it probably would have allowed this to be more easily approved.
Perhaps we should just close this PR, since it's over a year old, and I haven't run it with newer versions of home assistant. It doesn't seem to affect many people, judging by activity on this PR and the original issue.

Sorry things didn't go super smooth.

@aanderse Not at all. I should have been more proactive with this one.
Thank you for all the work you and many others do on Nix. It really is an incredible project! I'd like to help out more but you know... time management :-/

authors: aanderse colemickens matt-snider


text:
afl: fix afl-clang-fast++ by making it a copy of afl-clang-fast, not a symlink

Motivation for this change
wrapProgram seems to perform some sort of realpath check and ends up wrapping the symlink's target directly, skipping afl-clang-fast++ entirely. Unfortunately, nix's cc wrapper relies on inspecting argv[0] as part of its cpp-mode detection, and will switch back to c mode if it can't find a ++.
Ultimately it would be nice to have the option to disable this realpath check of wrapProgram, but for now the penalty is just a small addition to the on-disk size of the package.
cc @thoughtpolice
Anyone interested in this package might also consider approving #76645 which I've just updated similarly. aflplusplus is better and more maintainable (has tests!).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build afl


text:
pulseeffects: 4.7.2 -> 4.7.3

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/pulseeffects/versions.
meta.description for pulseeffects is: "Limiter, compressor, reverberation, equalizer and auto volume effects for Pulseaudio applications"
meta.homepage for pulseeffects is: "https://github.com/wwmm/pulseeffects"
meta.changelog for pulseeffects is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 4.7.3 with grep in /nix/store/lbmh01mka32308ckpdi81wzlw45163l9-pulseeffects-4.7.3

directory tree listing: https://gist.github.com/ac9f1b4df0983ebe18d2acd352bf01b0

du listing: https://gist.github.com/c6527a3b279167c794edb25eca38f73f

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
pulseeffects

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lbmh01mka32308ckpdi81wzlw45163l9-pulseeffects-4.7.3 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A pulseeffects https://github.com/r-ryantm/nixpkgs/archive/0d340238ae55e517b8ce7d5aee19bbbf6af79356.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lbmh01mka32308ckpdi81wzlw45163l9-pulseeffects-4.7.3
ls -la /nix/store/lbmh01mka32308ckpdi81wzlw45163l9-pulseeffects-4.7.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:
- pulseeffects

Maintainer pings
cc @jtojnar for testing.

Seems to work.

authors: jtojnar r-ryantm


text:
libreoffice-still: use icu64

Motivation for this change
The libreoffice build is currently failing on master. Bisecting revealed #93482 as the cause.
hydra nixpkgs:trunk
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 94712 1

4 packages built:
- libreoffice (libreoffice-still)
- libreoffice-unwrapped (libreoffice-still-unwrapped)
- odpdown
- unoconv

Built locally. Thanks!


text:
Errors I get when trying using cubic interpolation in NHITS

What happened + What you expected to happen
I tried fitting NHITS with cubic interpolation in my Kaggle notebook, but I got this error message:

OutOfMemoryError: CUDA out of memory. Tried to allocate 18.18 GiB. GPU 1 has a total capacty of 14.75 GiB of which 14.22 GiB is free. Process 15638 has 538.00 MiB memory in use. Of the allocated memory 274.06 MiB is allocated by PyTorch, and 45.94 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF

At first, I tried setting the max_split_size_mb and PYTORCH_CUDA_ALLOC_CONF, but it didn't work. Then I guessed that I need to do distributed training since there is 18GB memory that is being tried to be allocated. But I still got the same error message after specifying the strategy (ddp_notebook). I didn't set the max_split_size_mb and PYTORCH_CUDA_ALLOC_CONF anymore when I did distributed training. When the interpolation is linear and nearest, everything goes well; I don't need to specify any strategy and total devices.
Since I'm working with a time series with quite clear seasonality, I really hope I can fit the model using cubic interpolation to significantly improve my forecast.
Versions / Dependencies
I'm using Kaggle Notebook with GPU T4 x2, each has 15GB memory. Here are the libraries I'm using:

numpy version 1.26.4
pandas version 2.2.2
matplotlib version 3.7.5
pytorch_lightning version 2.2.2
neuralforecast version 1.7.2

Reproduction script
trainer_kwargs = dict(accelerator='gpu', devices=-1, strategy='ddp_notebook')
model = NHITS(h=OUR_HORIZON, input_size=OUR_HORIZON*2, start_padding_enabled=True, interpolation_mode='cubic', **trainer_kwargs)
fcst = NeuralForecast(models=[model], freq='h')
fcst.fit(pd.DataFrame({'unique_id': df_train.unique_id, 'ds': df_train.DateTime, 'y': df_train.Renewable}),          val_size=OUR_HORIZON)
Issue Severity
Medium: It is a significant difficulty but I can work around it.

I somehow solved this by changing the unique_id, so I'll close this issue.

source: gharchive/issue

repo: Nixtla/neuralforecast


text:
🛑 ProxiTok proxitok.lunar.icu is down

In 101bc44, ProxiTok proxitok.lunar.icu (https://proxitok.lunar.icu) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ProxiTok proxitok.lunar.icu is back up in 3bedb2e after 15 minutes.

repo: NoPlagiarism/services-personal-upptime


text:
🛑 AnonymousOverflow overflow.lunar.icu is down

In 2102281, AnonymousOverflow overflow.lunar.icu (https://overflow.lunar.icu) was down:

HTTP code: 0
Response time: 0 ms

Resolved: AnonymousOverflow overflow.lunar.icu is back up in 1375b29 after 27 minutes.


text:
🛑 libreddit libreddit.spike.codes is down

In 5125d31, libreddit libreddit.spike.codes (https://libreddit.spike.codes) was down:

HTTP code: 502
Response time: 21805 ms

Resolved: libreddit libreddit.spike.codes is back up in c3b712f.


text:
🛑 libreddit libreddit.domain.glass is down

In 6e886fb, libreddit libreddit.domain.glass (https://libreddit.domain.glass) was down:

HTTP code: 503
Response time: 271 ms

Resolved: libreddit libreddit.domain.glass is back up in d3e6318 after 20 minutes.


text:
🛑 AnonymousOverflow overflow.r4fo.com is down

In 9767f17, AnonymousOverflow overflow.r4fo.com (https://overflow.r4fo.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: AnonymousOverflow overflow.r4fo.com is back up in a27cfff after 20 minutes.


text:
as_string报错没有构造函数

非常不错的轮子，但是我在使用中遇到如下问题
using namespace std;
using namespace configor;
json j;
j["123"] = "12345";
string s = j["123"];
vs2017会报错: configor::detail::json_serializer<configor::basic_configconfigor::json_args,configor::basic<_Args>::default_encoding,cofigor::basic_config<_Args>::default_encoding>类没有构造函数

打错啦，是string s = j["123"].as_string()

v0.9.11版本没有问题，v0.9.12版本开始出现这个问题

@sannmizu 感谢反馈，v0.9.15已修复

authors: Nomango sannmizu

repo: Nomango/configor


text:
Grid link button

Has someway to create in the grid buttons with some template?
With row clicked event i can only redirect to edit or delete event.

with row clicked event i can only redirect to edit or delete event

You can any any html to your row column using .Add or .RenderedAs methods, you could also pass any templates that you have in String or IHtmlContent format. Here are some examples.

Thanks a lot !!!

authors: Muchiachio salgadonline

license: mit

license_source: bigquery


text:
Support RTL

Hi there,
First, Very thanks for MVC6.Grid.
Is there any support for RTL? if No, Please support RTL!

You should be a able to add few css rules to make it rtl?
Or there are some structural changes needed in the grid?

@Muchiachio I will test it.

Or there are some structural changes needed in the grid?
I think the problem is with the class text-left you need to remove it from the cells if the aligment is not specified
ex :
 columns.AddProperty(model => model.Id).Titled("id");
will produce
id

and it should be
id

It's because you are using template's .AddProperty instead of a raw grid's .Add @tareq2.

Just this thing which i have noticed in the RTL and everything else is working as expected.

authors: KiarashS Muchiachio tareq2


text:
203 Could not obtain peripheral instance

Currently, we are starting the DFU process as follows,
       let dfuInitiator = DFUServiceInitiator(queue: DispatchQueue(label: "DFUQueue"))
       dfuInitiator.delegate = self
       dfuInitiator.progressDelegate = self
       dfuInitiator.logger = self
       if #available(iOS 11.0, *) {
           dfuInitiator.packetReceiptNotificationParameter = 0
       }
       dfuController = dfuInitiator.with(firmware: firmware).start(target: dfuPeripheral)

And we get the error 203 which is trigged by following code from the library
delegate?.dfuError(.bluetoothDisabled, didOccurWithMessage: "Could not obtain peripheral instance")
Once the peripherals found in DFUTarg, we  connect to the device and keep a strong reference to it in singleton class. The dfuPeripheral that is being passed is taken from the singleton class and is not nil. Then we start the DFU process, however we get 203 error for some users. Any help regarding which may cause this issue is highly appreciated. This issue was noted in iPhone 8, iOS 11.4.1 .

How often does it happen? Is it easy for you to reproduce?
The only possible reason that I can see is that the CBCentralManager instance created in init(queue) is not ready yet. Could you wait a bit before calling start? When the state changes to .on, will this work? (I know you don;t want to know exactly when it will change to .on, but you may add some delay). If it's required, I'll implement waiting for state change in the lib.

Yes, so usually it works. When there is an issue with the phone (?) or someone plays with Bluetooth by turning it off and on (?) things may be unpredictable.
If the issue is not reproducible on your side, I would recommend just handling the exception in your code. It may be a temporary issue with the phone, perhaps restarting Bluetooth in settings would help? I don't think anything else can be done if the Bluetooth adapter is not stable.
Waiting 1 sec for all users seems to have no sense, also it may not help in this situation. I only meant testing if the issue was reproducible.
By modifying the lib I had in mind waiting for .on state before retrieving the device, not only before connecting to it. Currently the lib waits here: https://github.com/NordicSemiconductor/IOS-Pods-DFU-Library/blob/master/iOSDFULibrary/Classes/Implementation/GenericDFU/DFUPeripheral.swift#L106 and resumes here: https://github.com/NordicSemiconductor/IOS-Pods-DFU-Library/blob/master/iOSDFULibrary/Classes/Implementation/GenericDFU/DFUPeripheral.swift#L189 when state is .poweredOn.

I was able to reproduce this issue using an iPhone X with iOS 13, they way I fix it is just adding a 5 seconds delay before to call initiator.start()
`let queueStartDFU = DispatchQueue(label: "DFUController")
queueStartDFU.asyncAfter(deadline: .now() + gDFUDelayStart) {
        self.dfuController = dfuInitiator.with(firmware: firmware).start(target: selectedPeripheral)
    }`

I was able to reproduce this issue using an iPhone X with iOS 13, they way I fix it is just adding a 5 seconds delay before to call initiator.start()
let queueStartDFU = DispatchQueue(label: "DFUController")
        queueStartDFU.asyncAfter(deadline: .now() + gDFUDelayStart) {
self.dfuController = dfuInitiator.with(firmware: firmware).start(target: selectedPeripheral)
        }

iOS 13 iPhone XR me too.

I'll look into it when I start testing with iOS 13. I understand that this is important and should start doing this soon. For now try the workaround suggested above.

This should be working now with version 4.5.1.

Why do I still have 4.4 after pod search iOSDFULibrary?

You need to update Cocoa Pods on your Mac.

thank you

authors: Hellogz osawhoop padishahG philips77 rajtharan-g


text:
Time-Set functions, defaults in setEpoch()

Adds documentation for time-setting functions, after updating the documentation to reflect bugfix by PR #66.
Please note that this updated documentation attempts to preserve the readability revisions previously contributed by Andy Wickert. However, it would be well if someone checked.
This PR also updates DS3231.cpp to modify DS3231::setEpoch() by defining defaults for the two parameters as follows:
Change to:
void DS3231::setEpoch(time_t epoch = 0, bool flag_localtime = false)
From:
void DS3231::setEpoch(time_t epoch, bool flag_localtime)
Justification: to ensure known initial values of the parameters. As I understand it, C++ does not guarantee default values for variables that are declared locally, a category which includes function parameters.

@awickert Please take a look at PR #67. The discussion of setEpoch() is updated to reflect the recent bugfix. Did I retain the readability edits you kindly made to a previous draft of the documentation? Thanks!  David

Removed the definitions of parameter defaults in the implementation of setEpoch(). Reason: the defaults are declared in the header prototype, and it is an error to re-declare them in the implementation. Learn something every day,  even at my advanced age...

license: unlicense


text:
[Marker.io] Mobile: icon is missing for headings in the gift your way section

Steps to reproduce:
1)go to gift your way section
2)notice headings
Actual result: icon is missing
Expected result: icon should be there

Reported by: Vinod (vinod@na.studio) - Contact via Marker.io
Source URL: https://wf-b.stg.prezzee.com/en-us/corporate-gifting-solutions/business-portal?marker=true
Issue details: Open in Marker.io
Device typemobileBrowserSafari 18.0.1Screen Size375 x 812OSiOS 18.0.1Viewport Size375 x 710Pixel Ratio@3x

🤖 Marker.io bot - This issue was marked as ✅ Resolved in Marker.io


text:
Re-add modules from CoraBot v3 such as chatbot and auto-moderation.

Re-add modules from CoraBot v3

[x] Auto-Moderator
[x] Chat Bot
[x] Guild Notifier
[x] Music/Radio?
[x] Bot Logger
[x] Mod Logger
[x] Support Tickets
[x] Suggestions

Considerations

Means of storing support ticket information. (Use database?)
Create support tickets using channel or threads?

Known Issues

Message content required for auto moderation, chat bot and logger modules. Will require intent from April 2022 onwards.

Marking as complete.
Features includes mostly from v4.0.0 beta 3
Remaining features added in v4.0.0 beta 4

license: ISC


text:
Can't upload xBehave package due to "title similar to ID of existing package"

ref: https://twitter.com/adamralph/status/725372223586992129

The title of this package has always been "xBehave.net". See the history at https://www.nuget.org/packages/Xbehave/
I guess some change has been put into the gallery which now bans me from uploading the package with this title. I can understand the motivation, but this shouldn't apply to packages which have always had this title!
In order to release the package, I hacked the nupkg locally to make the title "xBehave" but this really isn't acceptable. Note that this happened after I had already uploaded 2.1 of https://www.nuget.org/packages/Xbehave.Core so I had to take what ever measure necessary to upload 2.1 of https://www.nuget.org/packages/Xbehave/ which, unfortunately, meant changing the title. The gallery web UI also won't let me change the package title back to what it should be, giving a similar error message.
Note also, that in this case, the refusal is due to this incorrectly uploaded package (by me) which I immediately de-listed when I realised it has the wrong ID - https://www.nuget.org/packages/Xbehave.net - I would have deleted the package immediately, but the gallery won't let me do that.

@rrelyea says

We enforce a strict policy on this...in which the title of a package cannot match the ID of another package.
You may either change it locally, or on the server for packages that already exist.
This change was made to address major security concerns of users about being confused between 2 packages...so we hope you understand why we won't allow a back door to do this.

The first problem with this is that this wasn't always the rule. By introducing it now, you've enforced the rule in retrospect for existing packages (like https://www.nuget.org/packages/Xbehave/) which can no longer upload new versions without changing their title.
However, the biggest problem is with this is that for any package which does not have the title as it's ID, and where that title is a valid string to use an ID, that package is at risk of someone uploading a new package with that title as it's ID which, again, will block the original package from ever being uploaded again without changing its title.
I'll give another example: https://www.nuget.org/packages/xunit/ - this package has always had "xUnit.net" as its title. All I have to do is upload a new package today with the ID "xUnit.net" and boom! The next deployment of https://www.nuget.org/packages/xunit/ will fail! /cc @bradwilson

@adamralph yes, we have considered these issues, but we believe that this rule is right in most cases, and the overall behavior is correct. The previous behavior was sad and confusing to the community. I suggest changing back the title to be exactly like the ID in your case.
FYI we are considering another option to completely remove titles from the site and visual studio.

FYI we are considering another option to completely remove titles from the site and visual studio.

:+1: Ultimately, this is the correct solution.
IMHO the current banning of titles similar to other ID's is an awkward half-way house. The sooner we get the correct solution, the better.

authors: adamralph yishaigalatzer

repo: NuGet/NuGetGallery


text:
Support AAD authentication on NuGet.org

Based on current Microsoft ID recommendations:

It is highly recommended that all new services from Microsoft integrated with both Azure AD (work/school accounts) and MSA (personal accounts).

Right now, AAD only is used when admins log in.

Sounds the same as the planned 2FA work.
@shishirx34 , can we close as duplicate?

Yes duplicate of 2FA work.

What the duplicate issue?

https://github.com/NuGet/NuGetGallery/issues/3252


text:
nice job , still there i s room for improvement.

Could you please provide more example for the "Restore packages for the solution in the current folder, specifying package sources".
specifically when I need to restore a specific version of a specific NuGet package from a private feed.

obviously  I got enough example for first 3 options, so I just ask for the fourth.
thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d63170c3-1894-8ead-b557-9937dae88172
Version Independent ID: 67968c11-0aa0-f835-357d-8690911eb011
Content: NuGet CLI restore command
Content Source: docs/tools/cli-ref-restore.md
Service: unspecified
GitHub Login: @kraigb
Microsoft Alias: kraigb

The current set of examples seem sufficient. You can use the -PackagesDirectory option, as specified in one of the examples, for restoring packages for a solution too. Let us know if that doesn't work for you. Closing this issue for now.

authors: Farzad-Jalali anangaur


text:
Fix up version entries

Fixes #2522.

Docs Build status updates of commit aa13702:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/msbuild-targets.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@nkolev92 please review.

@nkolev92 I don't see to have permission to merge this. #sign-off


text:
Add issue management bots

Fixes https://github.com/NuGet/Client.Engineering/issues/1754
This adds various tasks:

[Manage 'WaitingFor' labels] Replace tag 'WaitingForCustomer' with 'WaitingForNuGetTeam' when the author comments on an issue. Also remove Status:No recent activity if it's been set.

[Manage 'WaitingFor' labels] Remove any 'WaitingFor' label when the issue is closed

[Manage 'WaitingFor' labels] Replace tag 'WaitingForNuGetTeam' with 'WaitingForCustomer' when NuGet team comments on an issue.

[Manage stale WaitingForCustomer issues] Search for WaitingForCustomer issues with no activity over 14 days and warn.

[Close stale WaitingForCustomer issues] Search for stale WaitingForCustomer issues with no activity over 14 days and warn.

Docs Build status updates of commit a4a0563:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/fabricbot.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 4899769:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.github/fabricbot.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


text:
Patch version demand not being respected?

🐛 Bug Report
I'm using the parameter --change Patch but it seems that in certain cases minor version updates are being chosen.
Expected behavior
When I specify --change Patch, I expect only patch updates of packages to be applied in all cases.
Reproduction steps

Use the following command nukeeper repo <url> <token> --change Patch

Configuration
Version: 0.26.0
Platform if applicable:

[ ] :hammer_and_wrench: NuKeeper CLI
[ ] :sparkles: GitHub
[X] :robot: AzureDevops (TFS 2017)
[ ] :checkered_flag: Bitbucket
[ ] :earth_americas: Gitlab
[ ] :tv: Gitea
[ ] :whale: Docker

Extra information

Pull request description

  NuKeeper has generated a minor update of NLog to 4.5.11
  2 versions of NLog were found in use: 4.3.2, 4.3.1
  NLog 4.5.11 was published at 2018-11-06T17:31:25Z, 1 year and 1 month ago
  There is also a higher version, NLog 4.6.8 published at 2019-11-04T21:35:02Z, 1 month ago, but this was not applied as only Patch version changes are allowed.

Logfile: nukeeper-log-2019-12-13.txt

An excerpt:
EntityFramework from 6.1.3 to 6.2.0 in ************.SPC.WebApi.Tests\packages.config

EntityFramework.SqlServerCompact.Legacy from 6.1.3 to 6.2.0 in ************.SPC.WebApi.Tests\packages.config

I don't like creating useless bump posts, but I guess stale bot leaves me no choice.

Bump.

Hi, I'm also facing this issue and due to our project setup, we cannot use Nukeeper until this bug is fixed. Could someone please review this PR (Thanks @CrispyDrone!)

Thank you for promptly merging the PR. When can we expect the next version of Nukeeper (with this bug fix included) to be available?

@CrispyDrone Is this finished now that the code has been merged?

@CrispyDrone Is this finished now that the code has been merged?

@phatcher I haven't experienced any issues regarding this any more, so I would say yes.
I'll close the issue.

@phatcher I haven't experienced any issues regarding this any more, so I would say yes.
I'll close the issue.

authors: CrispyDrone furlongmt phatcher

repo: NuKeeperDotNet/NuKeeper