text:
Add base for documentation for Zot

What this PR does / why we need it
Documentation on some generic in-cluster registry mirroring and the GS approach for it with Zot, extended with some Zot use cases and configurations for certain scenarios.

I would vote for adding to new Tutorials folder :)
I plan to do the menu switch soonish (once other pending PRs are approved)

This is the designed tree for Tutorials

source
I am not completely sure where we can add it, any suggestion? do we need a new section?

@pipo02mix Moved under tutorials. Decided to create a new section. Is it correct this way?

Thanks a lot @pipo02mix! ❤

repo: giantswarm/docs

license_type: permissive

license_source: github-api


text:
push to openstack-app-collection

Checklist

[ ] Update changelog in CHANGELOG.md.
[ ] Make sure values.yaml and values.schema.json are valid.

:smiley_cat:

source: gharchive/pull-request

authors: ericgraf stone-z

repo: giantswarm/falco-app


text:
Add VPA resource

Checklist

[x] Update changelog in CHANGELOG.md.
[ ] Make sure values.yaml and values.schema.json are valid.

Tested on ginger using config branch enabling VPA

repo: giantswarm/kyverno-app


text:
AWS Release v13.1.0

Kubernetes v1.18.x
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-XXX.md
PR: https://github.com/giantswarm/roadmap/issues/261
Provide a new release with the kubernetes version

[ ] Check with the teams about wip changes within k8scloudconfig and the provider-specific operators. Decide with version folder to use.
[ ] Retag new image in retagger
[ ] Check upstream changelogs.

[ ] Check urgent upgrade notices.
[ ] Check deprecation notices.
[ ] Check component upgrades.

[ ] Calico
[ ] ETCD
[ ] Container Linux

[ ] Create a PR in k8scloudconfig with the new kubernetes version

[ ] Update k8s version in the different template files
[ ] Use k8s version for k8s-addons (e.g. https://github.com/giantswarm/k8scloudconfig/blob/4695b7d6eb35eae234d0ce0c0c09f4b412525a68/v_4_7_0/files/conf/k8s-addons#L5)

[ ] Update cluster-autoscaler
[ ] Vendor k8scloudconfig in the provider-specific operators
[ ] Create a wip release (major version change if it is a minor kubernetes upgrade)
[ ] Do this for each provider
[ ] Check Prometheus rules for deprecated metrics and fix them if necessary

Check migration recommendations
Check migration recommendations from kubernetes and decide what we need to document for the customer and what we should migrate automatically for them

[ ] Do we need to change our own resources within the tenant clusters?
[ ] What do we need to communicate to our customers?
[ ] Anything else that would be better automated for the upgrade?

Run e2e and conformance tests

[ ] Start a new cluster and run conformance tests against it
[ ] Start a new cluster and run e2e tests against it
[ ] Do this for each provider

Check Core Components

[ ] Check core components for updates and include them in cluster-operator

[ ] Cert-exporter
[ ] Chart-operator
[ ] Cluster-autoscaler
[ ] CoreDNS
[ ] Kube-state-metrics
[ ] Net-exporter
[ ] Nginx ingress controller
[ ] Node-exporter

[ ] All helm releases in the giantswarm namespace should be in status deployed
[ ] Core components are runnning without errors

[ ] Cert-exporter
[ ] Chart-operator
[ ] Cluster-autoscaler
[ ] CoreDNS
[ ] Kube-state-metrics
[ ] Net-exporter
[ ] Nginx ingress controller
[ ] Node-exporter

[ ] Cluster-operator is running without errors
[ ] Cluster-operator is able to create chart-configs in the tenant

Test migration (both cluster functionality itself and workloads)

[ ] Start a cluster with an older version and upgrade the cluster to the new release
[ ] Upgrade a cluster that is not critical but has some more real workloads (eg giantswarm website, dev cluster of customer)
[ ] Do this for each provider

Write summary for the release and update docs

[ ] Write some release notes
[ ] Check if our docs need to be updated
[ ] Announce the release internally (SEs are important here)
[ ] Announce the release to the customers

The release is available to all of our customers.

source: gharchive/issue

authors: alex-dabija paurosello

repo: giantswarm/roadmap


text:
🛑 get users api.minghe.me/graphql is down

In da68b70, get users api.minghe.me/graphql (https://api.minghe.me/graphql) was down:

HTTP code: 0
Response time: 0 ms

Resolved: get users api.minghe.me/graphql is back up in aa587de.

repo: gikiapp/status

license: MIT


text:
change wildcard regex to allow for dots in filename

Implementing a fix for #317 - error when md file name contains dot.
I'm not sure if there was a reason dots were excluded from paths to match the wildcard - I was unable to perform a directory traversal but maybe there was another reason? If so let me know and I'll abandon this!
But with some local testing it seems to be behaving fine and files with a dot in the name now load

Yep, good points.
I'll double-check with some testing this weekend.
Small changes can have big effects!

(Spongebob meme... "One year later...")
Ok, so some interesting findings.
Background
I'm going into detail for others that find this issue and want to weigh in.
My concern was around security, specifically directory traversal.
By allowing dots in the name, that can open up to attacks with "double dot" which means parent directory.
Effectively by providing "../../not-accessible.csv" as the page might allow that file to be accessible.
Read more at this link
When attempting to exploit the issue in the PR you submitted, it was not successful.
My guess is something in the express stack, due to its popularity, has some protections against paths with ".." in the filename.
I couldnt find it exactly, but it likely has to do with the pathToRegexp function in the main express repo (can be searched) which is based on this module https://github.com/pillarjs/path-to-regexp
So your solution works.
However we should not solely rely on Express or other projects for protection.
Instead, preferring a layered approach and protecting whenever we can.
One Option
In hopes of finding a compromise to allow dots in the file name (one dot? many dots?), here's one potential solution:
Changing RegExp to: ^([^.]+)\.?(md|html)?$
This would allow for blocking the dot elsewhere (with the [^.] part that was there originally) but allow for one optional dot (\.?) and the "md", "html", or other allowed extensions.
Try it out
RegEx101 Tester
Note: Had to enable the "g" and "m" (global and multiline) option flags for debugging to the right... next to the copy button.
RegExp: ^([^.]+)\.?(md|html)?$
Data set tested
/normal-operation
/whatever-with-a-dot.md
/more/things/and-stuff.md
/more/things/and-stuff.html
/../../../i/am/../hacked.md

All pass except for the last line

I had forgotten about this PR!
You make a very good point in not relying solely on the Express stack as a line of defense.
The solution definitely needs more thought than I gave my initial naive attempt.
I like the more restrictive regex though when testing it doesn't match the file given in the initial issue (content/monitoring/healtcheck.io.md). Though I'm sure we can come up with a regex that permits files like this but not with 2 consecutive dots.
There are wider issues I hadn't previously considered such as where the path is canonicalised to a standard form. If it is done before the regex check then the regex solution would be okay. But if it isn't then an exploit may be possible with URL encoding for example path names with %2e%2e decodes to .. but would slip through the regex. I would assume Express does the URL decoding but we'd want to test that to be sure.
In the meantime, for the interest of security shall I close this PR?

Hey,
Sorry I forgot I left this PR open. Unfortunately I can not work on this issue at this time so will close the PR for now.
Cheers

authors: jj-style ryanlelek

repo: gilbitron/Raneto

license: mit

license_source: bigquery


text:
Plan to support wintun for backend?

On windows, wintun (WireGuard/wintun) needn't install. Only work with a dll file.

v3 has changed tun from water to wireguard.

repo: ginuerzh/gost


text:
Page recherche: sélection par défaut du filtre de lieu d'accueil « En présentiel »

Problème : les utilisateurs ont tendance à ne pas être intéressé par les services à distance en général
Solution : on présélectionne le filtre de lieu d'accueil « En présentiel »
Effet de bord non voulu : si un utilisateur désélectionne le filtre de lieu d'accueil « En présentiel » (et qu'aucun autre filtre n'est sélectionné), et recharge la page ou transmet l'URL à une autre personne, le filtre de lieu d'accueil « En présentiel » sera resélectionné.

nitpick: je ne suis pas fan des commentaires de code (surtout quand ils servent simplement à paraphraser du code simplse juste en-dessous). Je propose de ne pas en mettre dans des cas comme celui-ci.

Je suis d'accord avec toi sur le principe. Ici, dans ce fichier, il y a beaucoup de code complexe pour la gestion des filtres, donc je préfère le commenter au maximum. Effectivement, ici on dirait que chaque ligne est paraphrasée. L'idée est de comprendre rapidement le pourquoi du code dans onMount : présélectionner le filtre « En présentiel ». Je pourrais à la place faire un seul commentaire plus simple au-dessus, ou alors l'extraire dans une fonction avec un nom explicite du type preselectEnPresentielFilter(). Qu'en penses-tu ?

repo: gip-inclusion/dora-front


text:
[Enhancement] Filters configurable selecting all that match search input or providing a regex

Summary
The incident table filters for service (and perhaps teams) filter based on text input but selecting multiple items requires entering the search text, selecting one item then re-entering the search text again, until all items are selected.
A multi-select/select-all matching option might help where many specific services need to be filtered. However, it might be preferable to automatically select all based on the search text - either with text matching as currently implemented or by supporting regex.

This may be redundant with the addition of #263 as this would give users the ability to select services that are grouped by escalation policy.

A potential implementation of a "Select All" is outlined under https://stackoverflow.com/a/61250357
Need to consider the other cases for Regex if it is appropriate.

authors: giranm gsreynolds

repo: giranm/pd-live-react


text:
Form alignment

It might have something to do with the JVsf module, but on my display, some of the controls that use partial space are artificially half as big as they should be:

Note the column, axis, and align properties.  They seem to have nested col-6 classes which end up functionally reducing them to 1/4 of the space rather than 1/2.

Resolved by #176

authors: annehaley manthey

repo: girder/shapeworks-cloud


text:
[Backend-Dev-Python]: Create a simple endpoint and a view in django

Description
Explain how to create a new route (endpoint) in django.
Hints:
Create a URL in urls.py and attach it to a function in views.py
Explain steps, best practices.
Domain
Backend Dev (Python)
Type of Contribution
Video, Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

repo: girlscript/winter-of-contributing


text:
Update DOC.md

Description 📜
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes #1551

Type of change 📝

[x] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] Golang

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

@amino19 merge it

@amino19 review it


text:
Max Circular Subarray Sum

Added C++ code to find Maximum sum in a Circular Subarray

Description 📜
Added code to find maximum sum in a circular array.
Link
Fixes #5442

Type of change 📝

[ ] Au#dio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
[ ] Vi#deo (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
[x] Documentation (Content Creation in the form of codes or tutorials)
[ ] Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

[ ] Android Dev #(Flutter)
[ ] Android Dev #(Java)
[ ] Android Dev #(Kotlin)
[ ] Backend Dev #(Java)
[ ] Backend Dev #(.NET)
[ ] Backend Dev #(PHP)
[ ] Backend Dev #(Python)
[ ] C/#CPP
[x] Competitive Programming
[ ] Cyber #Security
[ ] DS#A
[ ] Data#base
[ ] Datascience with #Python
[ ] Datascience with #R
[ ] Frontend Dev #HTML/CSS/JS
[ ] Frontend Dev #React/Angular/Vue
[ ] Go#lang
[ ] Interview #Prep
[ ] Java_#Domain
[ ] JavaScript_#Domain
[ ] ME#RN
[ ] Machine #Learning
[ ] Open #Source
[ ] Python_#Domain
[ ] Ru#st
[ ] Statis#tics
[ ] UI/#UX

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Please add my pull request.


text:
Python: Flask

Description 📜
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes #2250

Type of change 📝

[x] Audio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)

Domain of Contribution 📊

[x] Python_Domain

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

Please format this part correctly like the example of Flask usage in Apps should be on the last and the last 2 lines should be after the first one.
And please don't forget to add space after the full stop :)

Ok sure I will do it

@hritikksingh .Kindly review it

Looks good and the Audio file is also good.
@adityabisoi this can be merged.

@hritikksingh  plz check #6650

Check #6650 @hritikksingh

authors: hritikksingh nayakaj shaurya24sri


text:
Obtain CPU information using Prometheus

DESCRIPTION
The objective of this issue is to use Prometheus and Prometheus node-exporter to obtain CPU consumption and other information from the hosts, this will be done with the aim of creating a mixed YANG model between Prometheus obtained parameters and Netflow.
The final output will be having two models, one for Netflow data and another for Prometheus data, and be able to mix them with a Apache Flink Aggregator App.
It exist a cryptomining scenario that uses Ansible to run some cryptominers, this hosts have installed a softflowd, taking advantaged of this, it will be easier to install Prometheus node-exporters in all of them to combine Netflow with Prometheus information. The hosts are accessible via OpenStack in the Spider Project with image name spider-crypto

[x] Create a template for Prometheus and deploy in kubernetes
[x] Install a Node-Exporter in a spider-crypto instance
[x] Test that Node-Exporter and Prometheus are communicating correctly
[ ] Create a flink application that scrape prometheus and write results in a kafka topic (HW_crypto)
[ ] Flink application publish received Netflow from the same machines in another kafka topic (Netflow_crypto)
[ ] A Flink aggregation app is created to read from HW_info and Netflow_crypto and merge and aggregate the data

Abandoned

authors: ghost idomingu

repo: giros-dit/semantic-data-aggregator


text:
rnaseq: column switch in desc files

Debarka 29 Dec 2016: "In _RSEM.genes.results.desc files, the last two col names should be swapped"
Justin: "Yes in both fluidigm and star-rsem pipelines! My Apologies some how the last two column header was mistakenly swapped (gene_type - gene_name)."

Order in the snakemake is correct and the issue arisen for rn5 genome only. fields swapped in the annotation file of rn5 "gene_type and gene_name"

repo: gis-rpd/pipelines


text:
Proof / Screenshots of application pages

Add some images showing the flow of the application and actually show that it works.

GIF added!

repo: git-ankit/MovieRecommender


text:
Prevent failure while cloning if a user no longer exists in Active Direc...

This is a fix for issue #738 (related to #735).
Apparently if an Active Directory user has been deleted then The TFS API ReadIdentity throws a SoapException. This fix simply wraps the call to GetIdentity in a try/catch to prevent the cloning from terminating.

Thanks!
Can you tell me what is the content of changesetToLog.Committer when the method throw an exception and if something is extractable of this content to create a dummy identity. Or if there is nothing interesting and that we should use "Unknown TFS user" / "unknown@tfs.local" like done later in the method...

Note: Just for information, it's a better practice to create a feature branch before doing a pull request...

changesetToLog.Committer contains the string {domain}{username} (e.g. MYDOMAIN\deleteduser)
Without an authors file it looks like it just works and creates a log entry with name=username & email={username}@{domain}.tfs.local

I'm new to pull requests, but I'll do a feature branch in the future. thx

No problem! That's how we all learn ;-)

LGTM.

authors: jgcollings pmiossec spraints

repo: git-tfs/git-tfs


text:
Select data range

Do we have something like range which tells how many rows to plot on chart
for eg:

let opts = {
range: 1-2,
}
let charts =[{
			name  : 'Region 2',
			labels: ['April', 'May', 'June', 'July', 'August'],
			values: [0, 30, 53, 10, 25]
		}, {
			name  : 'Region 3',
			labels: ['April', 'May', 'June', 'July', 'August'],
			values: [17, 26, 53, 100, 75]
		}, {
			name  : 'Region 4',
			labels: ['April', 'May', 'June', 'July', 'August'],
			values: [55, 43, 70, 90, 80]
		}, {
			name  : 'Region 5',
			labels: ['April', 'May', 'June', 'July', 'August'],
			values: [55, 43, 70, 90, 80]
		}];

slide.addChart(pptx.charts.bar,charts,opts)

Now, I want that datatable contains all the data but the chart uses only 1st and 2nd row to plot series

@gitbrent Hey man, thanks for your awesome piece of work. Can you get this confirmed? And if it is not there, it will be a really cool feature. (Syncfusion provides this feature, would love if this becomes pptxgenjs part)

[Closing due to age]

repo: gitbrent/PptxGenJS


text:
The 'change' event will be triggered when the page loaded

Hi,
I found that the 'change' event of toggle will be triggered every time the page gets loaded.
Is there a way to stop that?
Thanks!

I updated to the latest version then double checked my code. All good now.

Good to hear!

Sorry probably I should've described it more clearly:
On my page, I set up initial status for the toggle, using
$('#toggle-demo').bootstrapToggle('on')
or
$('#toggle-demo').bootstrapToggle('off')
But that would trigger the 'change' event, which was not what I expected.
Cheers
Karl

Yes, I see what you mean. In this case the code was behaving as intended.

authors: KarlWang gitbrent


text:
issues with files option from cook.yaml

Hello there,
firstly, thanks a lot for the tool, i am exploring and it is really good.
However, i am facing an issue with the option of 'files'
in the cook.yaml, if i change the path of files i.e the password file from my local filesystem, then i am getting error.
example command - cook -admin admin,root,superuser,su,sa,moderator -s "." -sep / https://mysite.com:sep:admin:robot_1000
i am changing the location referred in the cook.yaml file to my local filesystem. When i run the above command, then i get the error `E:\tools\wordlists\SecLists\Discovery\Web-Content\RobotsDisallowed-Top1000.txt
panic: open E:\tools\wordlists\SecLists\Discovery\Web-Content\RobotsDisallowed-Top1000.txt: no such file or directory
goroutine 1 [running]:
main.fileValues(0x84c0280, 0x4e, 0xbffa46d2, 0xa, 0x84f011c)
/home/kali/go/src/github.com/giteshnxtlvl/cook/main.go:157 +0x172
main.main()
/home/kali/go/src/github.com/giteshnxtlvl/cook/main.go:226 +0x53b
`
i even tried changing the path in the main.go file as shown in the above error but it throws out the same error.
Can you help me on where i am messing up?? or is it an issue.
Thanks in advance.

Sorry, just made some error.
followed the documentation on cook -config and setup custom config file.
Now works like a charm.
Thanks

Glad it work for you and you liked it :)

repo: giteshnxtlvl/cook


text:
🛑 invidious.privacydev.net is down

In 0764ce7, invidious.privacydev.net (https://invidious.privacydev.net/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: invidious.privacydev.net is back up in 13b8023 after 12 minutes.

repo: gitetsu/invidious-instances-upptime


text:
🛑 invidious.lidarshield.cloud is down

In 48137e2, invidious.lidarshield.cloud (https://invidious.lidarshield.cloud/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: invidious.lidarshield.cloud is back up in 7b24906 after 33 minutes.


text:
🛑 invidious.lidarshield.cloud is down

In 12ff414, invidious.lidarshield.cloud (https://invidious.lidarshield.cloud/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: invidious.lidarshield.cloud is back up in 939baba after 12 minutes.


text:
Warn if email in CC list is unreachable

In https://github.com/gitgitgadget/git/pull/691 I added Philip Oakley to the CC list, with his email taken from the CC list in this message.
Apparently this email account does not work anymore, but I was not made aware of that by Gitgitgadget, I realized it when I received a "Mail Delivery Failure" email when I replied-all from my email client to a comment on my series.
I think it could be nice if GGG could add a comment on the PR if one of the emails in the CC list is unreacheable. I guess that would mean monitoring the emails sent to the GGG Gmail address, which may or may not be feasible. I'm just throwing the idea out there.
[Meta question]: apart from manually checking the most recent commit for each person in the CC list with git log -1 --author '<some person>' upstream/master, is there a builtin way in Git to check the "currently in-use" email address of someone ?

I think it could be nice if GGG could add a comment on the PR if one of the emails in the CC list is unreacheable. I guess that would mean monitoring the emails sent to the GGG Gmail address, which may or may not be feasible. I'm just throwing the idea out there.

This is an interesting idea. We could use IMAP to find new MAILER-DAEMON mails that have not yet been handled, and maintain a list of email addresses known to bounce.
An interesting idea, but to be sure, not a trivial one to implement, given that there is no standardized way to indicate that an email address bounced (as opposed to replying with a "full mailbox" or a "you are graylisted and need to send this again").
@phil-blain do feel free to play with this idea, it would be great to have it!

[Meta question]: apart from manually checking the most recent commit for each person in the CC list with git log -1 --author '<some person>' upstream/master, is there a builtin way in Git to check the "currently in-use" email address of someone ?

This is indeed the most natural way to check for that, although there are always contributors who go out of their way to complicate things.
Having said that, in general it is possible, and I am using this alias (courtesy of @peff):
[alias]
	who = !sh -c 'git --no-pager -c mailmap.blob=origin/master:.mailmap log -1 --format=\"%aN <%aE>\" --author=\"$1\" -i origin/master' -

Thanks for the alias, here is my variant in case it can be useful for lurkers:
git config --global alias.who '!f () { git --no-pager -c mailmap.blob=upstream/master:.mailmap log -1 --format="%aN <%aE>" --author="$1" -i upstream/master;  }; f'

@phil-blain do feel free to play with this idea, it would be great to have it!

Did you get a chance yet?

Oh, this is too far from what I know to be able to come up with something useful in any reasonable time frame, I would say.

Shall we close, then?

authors: dscho phil-blain

repo: gitgitgadget/gitgitgadget

license: ISC


text:
[GHSA-qwrq-vxvw-537r] git-shallow-clone OS Command Injection vulnerability

Updates

Affected products
CVSS v3
CVSS v4
CWEs
Description
Severity
Summary

Comments
Note that the module does not pass user input to the shell. That means that there is no command injection and the current CWE is wrong. While there exists a way to control some part of the arguments, it does not create a scenario that can be exploited by a remote attacker. The correct category would be Improper Neutralization of Argument Delimiters in a Command ('Argument Injection') (CWE-88).

Hi @DSimsek000, thank you for your contribution.  We used CWE-78 because Snyk included CWE-78 in the CVE record they published.  To get the issue resolved for everyone, you need to email Snyk at report@snyk.io.
That being said, you seem to be saying the vulnerability is caused by git-shallos-clone allowing dangerous git options such as upload-pack in the clone path, similar to GHSA-8jmw-wjr8-2x66.  Is that correct?

Hi, thanks for pointing that out, I will email them.
Yes, the vulnerability is similar to https://github.com/advisories/GHSA-8jmw-wjr8-2x66, with the constraint being that one can only specify 2 arguments into git clone (which prevents arbitrary code execution afaik).

repo: github/advisory-database


text:
"Analysis processing failed"

When we see "Analysis processing failed", where should we look to investigate what failed?

The ouput of the CodeQL action is saying
Processing sarif files: ["reports/test.sarif"]
Uploading results
Successfully uploaded results

Normally, there should be a failing code scanning workflow run in the Actions tab of your repository. The fact that the latest scan has a duration of 1s, implies to me that the workflow didn't really run at all (or at least it was aborted shortly after starting).
Can you locate which run this was? And add the logs?
If this repo is public, can you share the link?

Hi
This is the workflow:
https://github.com/h3xstream/sarif-samples/actions/workflows/upload-me.yml

Thanks for the information. I've forwarded this on to the code scanning team and someone should follow up.

:wave: @h3xstream We have few additional expectations from the SARIF file that are stricter than what the standard requires. These are meant to provide a reasonable UI experience. One of those is that each result should have a message. The file you uploaded does not include these values.
You can see the full explanation at: https://docs.github.com/en/code-security/secure-coding/integrating-with-code-scanning/sarif-support-for-code-scanning#result-object
To further debug this type of problems, you can use the Code Scanning API endpoint to list analyses. These errors are reported under the error property: https://docs.github.com/en/rest/reference/code-scanning#list-code-scanning-analyses-for-a-repository
Hope this helps!

So, I'm looking at

https://github.com/jsoref/examples-testing/actions/runs/3454140264
https://github.com/jsoref/examples-testing/security/code-scanning?query=is:open+pr:25 -- has an "Analysis processing failed".
https://github.com/jsoref/examples-testing/actions -- There is nothing in the /actions list directly relating to analysis processing...

Thoughts:

If at all possible, the Analysis processing failed should be a link to something. Preferably to a report showing the specific complaint(s). Alternatively, to a page explaining how to debug a failure.
I was hoping there'd be some way for me to do what I'm trying to do here, but, so far, I haven't found one...
It isn't obvious why the error message appears to be doubled.
If the errors thing should be an array, perhaps it should be reformulated as such?
if you're going to merge items into a human readable message in errors, please include whitespace between entries.
If an error can be sufficiently ambiguous, why not include the actual value you dislike instead of just the parsed portion?
I guess that results_count and rules_count aren't populated unless the sarif parser is entirely happy, ...
To make my life easier (and to enable one to pull the sarif file into other tools, e.g. VSCode), the action generates a sarif artifact, so people can retrieve it and review manually.

code-scanning/analyses/51044536
gh api /repos/jsoref/examples-testing/code-scanning/analyses/51044536:
{
  "analysis_key": ".github/workflows/spelling.yml:spelling",
  "category": "check-spelling",
  "commit_sha": "1903e85d65371f1fb587e60e92fddf822e81a55c",
  "created_at": "2022-11-13T06:26:40Z",
  "deletable": false,
  "environment": "{}",
  "error": "SARIF URI scheme \"https\" did not match the checkout URI scheme \"file\",SARIF URI scheme \"https\" did not match the checkout URI scheme \"file\",",
  "id": 51044536,
  "ref": "refs/pull/25/merge",
  "results_count": 0,
  "rules_count": 0,
  "sarif_id": "21e893e4-631c-11ed-88e3-9a1618496759",
  "tool": {
    "guid": null,
    "name": "check-spelling",
    "version": "0.0.20"
  },
  "url": "https://api.github.com/repos/jsoref/examples-testing/code-scanning/analyses/51044536",
  "warning": ""
}

The relevant sarif items
...  appear to be:
[
...
        {
          "ruleId": "unrecognized-spelling",
          "ruleIndex": 0,
          "message": {
            "text": "[haddd](#security-tab) is not a recognized word. \\(unrecognized-spelling\\)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "https://github.com/jsoref/examples-testing/pull/25#",
                  "uriBaseId": "%SRCROOT%"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 6,
                  "endColumn": 11
                }
              }
            }
          ]
        },
...
        {
          "ruleId": "unrecognized-spelling",
          "ruleIndex": 0,
          "message": {
            "text": "[fleeze](#security-tab) is not a recognized word. \\(unrecognized-spelling\\)"
          },
          "locations": [
            {
              "physicalLocation": {
                "artifactLocation": {
                  "uri": "https://github.com/jsoref/examples-testing/pull/25#",
                  "uriBaseId": "%SRCROOT%"
                },
                "region": {
                  "startLine": 1,
                  "startColumn": 5,
                  "endColumn": 11
                }
              }
            }
          ]
        },
...
]

authors: aeisenberg h3xstream jsoref marcogario

repo: github/codeql-action


text:
Update readme sample in creating-a-javascript-action.md

What's being changed (if available, include any code snippets, screenshots, or gifs):
On doc page https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#creating-a-readme there is a markdown sample with a ready to copy button.

If you copy/paste that sample as a new file, the output is the following:

This PR slightly improves that sample with the following two changes:

The input and output are now h3 instead of h2, to differentiate from the input/output headers.
The yaml sample is now inside triple-backtick for yaml code.

If you copy/paste this modification, the output is as follows:

Side-by-side screenshots

Check off the following:

[x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

@TrianguloY Thanks so much for opening a PR! I'll get this triaged for review :zap:

repo: github/docs


text:
Revert "Repo sync"

Why:
Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[ ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[ ] For content changes, I have completed the self-review checklist.

Why:
Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[ ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[ ] For content changes, I have completed the self-review checklist.


text:
Topics: Add Vala language

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Vala is used by hundreds of open source apps developed for GNOME, elementary OS, and other Linux-based operating systems. The added context of what "Vala" is would be useful when browsing repositories tagged with the topic.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Thanks for the contribution!

authors: BlakeWilliams cassidyjames

repo: github/explore


text:
Update README.md

Improve README file

Thanks for the PR, but I'm not sure I want markdown link references for links that are only used once. Are you reading this from the command line? If link refs help you lot, I think I'd rather see them below the paragraphs that use them.

authors: nirgeier technoweenie

repo: github/git-lfs


text:
[TeX] Add .spl and .soc

Reasons for making this change:
.soc and .spl were missing for TeX

.soc - package changes
.spl - documentclass elsarticle (Elsevier journals)

Links to documentation supporting these rule changes:
http://tex.stackexchange.com/a/256803/9075

@koppor thanks!

authors: koppor shiftkey

repo: github/gitignore


text:
[Feature Request] Command to create comments on pull requests

Not sure if this is possible, but it would be helpful to be able to add/create new comments to existing pull requests.  This would work hand in hand w/ Jenkins pull request builder plugin which uses PR comments as trigger phrases for merge/build.

Just checking here, are there still no plans to add this feature?
I would love to have a command like
hub comment <issue-no/PR-no> -m "comment content"
for a few use cases.
I primarily want this in order to add a reminder comment with a task list at the bottom of a PR with a lot of commits. For example to remind the user to review the code and docs before merging a huge release branch with the past 4 weeks of commits into master. If this reminder is only in the PR description at the top, it is likely to be missed.
Another use for it could be for an automated build/test system to add some details about the build into a comment.
If I remember the Github v3 API correctly, issues and PRs are the "same thing", which means this command could be used to comment issues and PRs alike.

There is a PR open to add a hub comment command #1465
I still haven't had time to properly review it and reach a decision about whether I like its API or do I imagine it to be different.

+1 on this, I installed this planning to do just this and was bummed when I found out it's not a feature

authors: mislav nchen-lv sebszocinski stensson

repo: github/hub


text:
Check if GitHub repo exists before every hub clone

If it doesn't exist, print a more helpful error message about it so the user knows which "owner/repo" pair was tested. This aims to reduce confusion when cloning own repos such as hub clone dotfiles.
The downside is now there is an extra HTTP request on every hub clone because the repository existence is checked every time.
Fixes #868

The extra network request is a bummer. I work on a lot of high-latency networks and this would likely reduce efficiency and effectiveness of this tool for me. Perhaps, if the 'git clone' operation fails, hub can print a message containing the relevant information?
"fatal: failed to clone mislav/dotfiles from GitHub.com"

Then we would have to execute git clone internally, inspect its exit code and message, and replace the message with our own. Doable, but we would have to change more significantly how clone works. It's not a bad idea.
It's just that the API request will likely take the negligible amount of time compared to the clone operation.

Optimizing for the successful case would seem preferable to me. Assume it's going to clone, clone it, and if it fails, print a message. I'm not suggesting you remove the git clone output, just add a line at the bottom of the output with the details about your clone attempt.
How expensive is a failed git clone operation?
What if GitHub's API is down but clone operations are fine? Do I have to wait 30 seconds for it to time out for every clone? If the API is up, this might only add a second to the total real time for the user in the mean case. Is that second, multiplied over thousands of users who don't get 404's, worth it?
Just trying to save some network time here, because latency is horrifying for me. The intent is to print owner and host name information, right? I'm interested in providing that without any added overhead so it doesn't degrade the successful case (where the repo exists).

I don't go to Asia much anymore so I'm feeling less defensive about the extra network request, haha.
This would certainly be a great addition for the next release of hub!

authors: mislav parkr


text:
Multiline Haskell string with empty last line not terminated

The below captured snippet compiles perfectly well by GHC but fails to properly syntax highlight.
The syntax highlighter fails to terminate the multiline string literal at \", even though it's perfectly valid in Haskell to end a multiline string with \" as the only thing on the last line.

I discovered the bug while reporting the same bug in Emacs's haskell-mode; I then reported a bug for github/markup and was then redirected to github/linguist; see https://github.com/github/markup/issues/467.

Same as in github/markup#467, you should report this at textmate/haskell.tmbundle.

you should report this at textmate/haskell.tmbundle (Sorry if I wasn't clear before).

Yeah please report this on https://github.com/textmate/haskell.tmbundle

authors: arfon eallik pchaigno

repo: github/linguist


text:
Add information about file extension order to the contribution guidelines

I was trying to add a new file extension to an existing language and ran into an issue where the TravisCI build failed because the file extensions in languages.yaml file need to be alphabetically sorted (see build logs). However, this is not mentioned in the contributing guidelines.
This information should be included in the contributing guidelines.

@arfon Is this requirement still needed? (now that Gist interface has changed)

authors: jaredpetersen pchaigno


text:
Update Swift color to match the official Swift logo

Description
Update color for Swift programming language to match the orange from the official Swift logo (from swift.org)

Before: #ffac45
After: #F05138
Checklist:

[x] I am changing the color associated with a language

[x] I have obtained agreement from the wider language community on this color change. (working on it)

Swift Forums Topic
Swift Logo Resources
Swift Logo Guidelines (download link)
Swift Logo Guidelines.pdf

🤔  this didn't appear to be getting much community support

Hi @lildude, unfortunately, not many hearts or thumbs up, agreed. But I haven't heard of anyone rejecting the change either.
I'll see if I can promote the change a bit more on Twitter and the forums, thank you.

14 hearts isn't a tiny amount of hearts. Review for structured concurrency proposal received 19 hearts, and it's arguably the most exciting change to swift ever.
The lack of comments is there because there's not much to say other than "+1" which is explicitly discouraged

@lildude seems like there is enough support now?

If you're confident about it and happy to field any complaints for the change, if there are any, I'm happy for it to be merged.

Gonna merge this now. If there are any objections with the colour choice, please discuss this on the forum topic referenced in the OP.

authors: Trzyipolkostkicukru eneko lildude


text:
allow markdown on index page, markdown=1 for article description

Generalization of #241 by @wooorm

Much better than my solution!

The test failure (edit link for the renamed file) is necessary, FWIW. It would go away if merged.

Closing this because @benbalter's suggestion is simpler.

authors: mlinksva wooorm

repo: github/open-source-guide


text:
Cluster alias flapping between clusters

Disregarding any settings that can be used to mitigate this issue, the cluster alias can flap between clusters, which is an undesirable situation as it will create confusion when viewing the topology.
$ c=0; while [[ $c -lt 20 ]]; do printf "%s - %s\n" "$(date --rfc-3339=seconds)" "$(orchestrator-client -c clusters-alias | tr \\n ' ')"; let c="c+1"; sleep 2; done
2018-05-23 16:08:11+00:00 - 192.168.121.186:18101,db2 192.168.121.186:18201,192.168.121.186:18201
2018-05-23 16:08:13+00:00 - 192.168.121.186:18101,db2 192.168.121.186:18201,192.168.121.186:18201
2018-05-23 16:08:15+00:00 - 192.168.121.186:18101,192.168.121.186:18101 192.168.121.186:18201,db2
2018-05-23 16:08:17+00:00 - 192.168.121.186:18101,192.168.121.186:18101 192.168.121.186:18201,db2
2018-05-23 16:08:19+00:00 - 192.168.121.186:18101,db2 192.168.121.186:18201,192.168.121.186:18201
2018-05-23 16:08:22+00:00 - 192.168.121.186:18101,db2 192.168.121.186:18201,192.168.121.186:18201
2018-05-23 16:08:24+00:00 - 192.168.121.186:18101,192.168.121.186:18101 192.168.121.186:18201,db2
2018-05-23 16:08:26+00:00 - 192.168.121.186:18101,192.168.121.186:18101 192.168.121.186:18201,db2
2018-05-23 16:08:28+00:00 - 192.168.121.186:18101,192.168.121.186:18101 192.168.121.186:18201,db2
2018-05-23 16:08:30+00:00 - 192.168.121.186:18101,192.168.121.186:18101 192.168.121.186:18201,db2
2018-05-23 16:08:32+00:00 - 192.168.121.186:18101,192.168.121.186:18101 192.168.121.186:18201,db2
2018-05-23 16:08:34+00:00 - 192.168.121.186:18101,192.168.121.186:18101 192.168.121.186:18201,db2
2018-05-23 16:08:36+00:00 - 192.168.121.186:18101,192.168.121.186:18101 192.168.121.186:18201,db2
2018-05-23 16:08:38+00:00 - 192.168.121.186:18101,192.168.121.186:18101 192.168.121.186:18201,db2
2018-05-23 16:08:40+00:00 - 192.168.121.186:18101,192.168.121.186:18101 192.168.121.186:18201,db2
2018-05-23 16:08:42+00:00 - 192.168.121.186:18101,192.168.121.186:18101 192.168.121.186:18201,db2
2018-05-23 16:08:44+00:00 - 192.168.121.186:18101,db2 192.168.121.186:18201,192.168.121.186:18201
2018-05-23 16:08:46+00:00 - 192.168.121.186:18101,db2 192.168.121.186:18201,192.168.121.186:18201
2018-05-23 16:08:48+00:00 - 192.168.121.186:18101,db2 192.168.121.186:18201,192.168.121.186:18201
2018-05-23 16:08:50+00:00 - 192.168.121.186:18101,db2 192.168.121.186:18201,192.168.121.186:18201

Would it be better to make the cluster-alias a fixed value once assigned, with the ability to clear it?

Would it be better to make the cluster-alias a fixed value once assigned, with the ability to clear it?

The alias gets reassigned upon failover. And orchestrator can;t be the sole owner of changes -- these can happen outside its control. But I'd like to better understand your setup? orchestrator-client -c clusters-alias -- no cluster specified, do you have exactly one cluster?

The alias isn't getting reassigned here, it is moving from one cluster to another:
$ orchestrator-client -c topology -alias db2
192.168.121.186:18101   [0s,ok,5.7.21-21-log,rw,ROW,>>,P-GTID]
+ 192.168.121.186:18102 [0s,ok,5.7.21-21-log,rw,ROW,>>,P-GTID]

$ orchestrator-client -c topology -alias db2
192.168.121.186:18201   [0s,ok,5.7.21-21-log,rw,ROW,>>,GTID,P-GTID]
+ 192.168.121.186:18202 [0s,ok,5.7.21-21-log,rw,ROW,>>,GTID,P-GTID]

The above were executed with literally a few seconds gap in between.
Now, admittedly this is a somewhat unusual scenario as there are a pair of 2-node clusters on the same host, but it seems to imply that something is not quite right.

The alias gets reassigned upon failover.

This is what I would expect, but I also expected that the alias would not be able to change cluster (i.e. statically assigned to the cluster), yet it seems to be evaluated on a high-frequency basis.

@cezmunsta I'm pasting your config here:
{
  "Debug": true,
  "EnableSyslog": false,
  "AutoPseudoGTID": true,
  "UseSuperReadOnly": true,
  "ListenAddress": ":3000",
  "MySQLTopologyUser": "xxx",
  "MySQLTopologyPassword": "xxx",
  "MySQLTopologyCredentialsConfigFile": "",
  "MySQLTopologySSLPrivateKeyFile": "",
  "MySQLTopologySSLCertFile": "",
  "MySQLTopologySSLCAFile": "",
  "MySQLTopologySSLSkipVerify": true,
  "MySQLTopologyUseMutualTLS": false,
  "BackendDB": "sqlite",
  "SQLite3DataFile": "/usr/local/orchestrator/orchestrator.sqlite3",
  "DefaultInstancePort": 3306,
  "DiscoverByShowSlaveHosts": false,
  "InstancePollSeconds": 5,
  "UnseenInstanceForgetHours": 1,
  "SnapshotTopologiesIntervalHours": 0,
  "InstanceBulkOperationsWaitTimeoutSeconds": 10,
  "HostnameResolveMethod": "none",
  "MySQLHostnameResolveMethod": "",
  "SkipBinlogServerUnresolveCheck": true,
  "ExpiryHostnameResolvesMinutes": 60,
  "RejectHostnameResolvePattern": "",
  "ReasonableReplicationLagSeconds": 10,
  "ProblemIgnoreHostnameFilters": [],
  "VerifyReplicationFilters": false,
  "ReasonableMaintenanceReplicationLagSeconds": 20,
  "CandidateInstanceExpireMinutes": 60,
  "AuditLogFile": "",
  "AuditToSyslog": false,
  "RemoveTextFromHostnameDisplay": ".mydomain.com:3306",
  "ReadOnly": false,
  "AuthenticationMethod": "",
  "HTTPAuthUser": "",
  "HTTPAuthPassword": "",
  "AuthUserHeader": "",
  "PowerAuthUsers": [
    "*"
  ],
  "ClusterNameToAlias": {
    "127.0.0.1": "test suite"
  },
  "SlaveLagQuery": "",
  "DetectClusterAliasQuery": "SELECT SUBSTRING_INDEX(@@hostname, '.', 1)",
  "DetectClusterDomainQuery": "",
  "DetectInstanceAliasQuery": "",
  "DetectPromotionRuleQuery": "",
  "DataCenterPattern": "[.]([^.]+)[.][^.]+[.]mydomain[.]com",
  "PhysicalEnvironmentPattern": "[.]([^.]+[.][^.]+)[.]mydomain[.]com",
  "PromotionIgnoreHostnameFilters": [],
  "DetectSemiSyncEnforcedQuery": "",
  "ServeAgentsHttp": false,
  "AgentsServerPort": ":3001",
  "AgentsUseSSL": false,
  "AgentsUseMutualTLS": false,
  "AgentSSLSkipVerify": false,
  "AgentSSLPrivateKeyFile": "",
  "AgentSSLCertFile": "",
  "AgentSSLCAFile": "",
  "AgentSSLValidOUs": [],
  "UseSSL": false,
  "UseMutualTLS": false,
  "SSLSkipVerify": false,
  "SSLPrivateKeyFile": "",
  "SSLCertFile": "",
  "SSLCAFile": "",
  "SSLValidOUs": [],
  "URLPrefix": "",
  "StatusEndpoint": "/api/status",
  "StatusSimpleHealth": true,
  "StatusOUVerify": false,
  "AgentPollMinutes": 60,
  "UnseenAgentForgetHours": 6,
  "StaleSeedFailMinutes": 60,
  "SeedAcceptableBytesDiff": 8192,
  "PseudoGTIDPattern": "",
  "PseudoGTIDPatternIsFixedSubstring": false,
  "PseudoGTIDMonotonicHint": "asc:",
  "DetectPseudoGTIDQuery": "",
  "BinlogEventsChunkSize": 10000,
  "SkipBinlogEventsContaining": [],
  "ReduceReplicationAnalysisCount": true,
  "FailureDetectionPeriodBlockMinutes": 60,
  "RecoveryPeriodBlockSeconds": 3600,
  "RecoveryIgnoreHostnameFilters": [],
  "RecoverMasterClusterFilters": [
    "_master_pattern_"
  ],
  "RecoverIntermediateMasterClusterFilters": [
    "_intermediate_master_pattern_"
  ],
  "OnFailureDetectionProcesses": [
    "echo 'Detected {failureType} on {failureCluster}. Affected replicas: {countSlaves}' >> /tmp/recovery.log"
  ],
  "PreFailoverProcesses": [
    "echo 'Will recover from {failureType} on {failureCluster}' >> /tmp/recovery.log"
  ],
  "PostFailoverProcesses": [
    "echo '(for all types) Recovered from {failureType} on {failureCluster}. Failed: {failedHost}:{failedPort}; Successor: {successorHost}:{successorPort}' >> /tmp/recovery.log"
  ],
  "PostUnsuccessfulFailoverProcesses": [],
  "PostMasterFailoverProcesses": [
    "echo 'Recovered from {failureType} on {failureCluster}. Failed: {failedHost}:{failedPort}; Promoted: {successorHost}:{successorPort}' >> /tmp/recovery.log"
  ],
  "PostIntermediateMasterFailoverProcesses": [
    "echo 'Recovered from {failureType} on {failureCluster}. Failed: {failedHost}:{failedPort}; Successor: {successorHost}:{successorPort}' >> /tmp/recovery.log"
  ],
  "CoMasterRecoveryMustPromoteOtherCoMaster": true,
  "DetachLostSlavesAfterMasterFailover": true,
  "ApplyMySQLPromotionAfterMasterFailover": false,
  "MasterFailoverDetachSlaveMasterHost": false,
  "MasterFailoverLostInstancesDowntimeMinutes": 0,
  "PostponeSlaveRecoveryOnLagMinutes": 0,
  "OSCIgnoreHostnameFilters": [],
  "GraphiteAddr": "",
  "GraphitePath": "",
  "GraphiteConvertHostnameDotsToUnderscores": true
}```

@cezmunsta your config file (assuming it is correct) doesn't play well with sandbox deployments.
Compare:

https://speakerdeck.com/shlominoach/orchestrator-high-availability-tutorial#15, and
https://speakerdeck.com/shlominoach/orchestrator-high-availability-tutorial#16

on local (dbddeployer/mysqlsandbox) deployments you want DiscoverByShowSlaveHosts: true. Reason: show proceslist on the master will tell orchestrator the replica is on same host, but it does not know on what port. It then assumes the same port. It then gets really confused.
Production looks very different, and unfortunately there is no single configuration that matches both. I recommend going with https://speakerdeck.com/shlominoach/orchestrator-high-availability-tutorial#15:

"DiscoverByShowSlaveHosts": true,

“HostnameResolveMethod": "default",

"MySQLHostnameResolveMethod": "@@report_host",

@shlomi-noach OK, I'll accept that this is caused by running multiple instances on the same host, via dbdeployer or any other method, in which case the configuration options are forced. Although, the same could presumably occur with a shared local part to the hostname, e.g. db1.abc.lan and db1.xyz.lan, without anything set to intervene?

authors: cezmunsta shlomi-noach

repo: github/orchestrator


text:
[RR Request]: Enioka Scan 2.0.0

Open Source Project name
Enioka Scan
What is your project?
Enioka Scan is an open source Android library that makes the integration of barcode scanners in your Android applications easy while avoiding vendor lock-in.
The library provides a service that automatically scans for scanners compatible with one of the many included drivers, which wrap or adapt the often proprietary or poorly documented vendor SDK, providing a simple API to access the core features of all supported devices. This allows you to build and maintain a single application without worrying about changing scanner vendor down the line.
Version
2.0.0
Date
May 9, 2022
Description of breaking changes
The exposed APIs were reworked in-depth, making it easier to communicate with the scanner service and individual scanners, with better handling of scanner search options. The scanner service API now only serves as a holder managing scanner lifecycles, meaning many methods were removed and others were introduced. The scanner API was redesigned to make it clearer what features are compatible with a device. Finally, interfaces were streamlined and those with limited use were removed or combined with each other. More details in the release changelog.
GitHub Repo
https://github.com/enioka/enioka_scan
Website
https://github.com/enioka/enioka_scan
Link to changelog
https://github.com/enioka/enioka_scan/releases/tag/2.0.0
Social media
N/A
Anything else to add?
No response

Congrats on being featured in the May Release Radar 🥳

Read the blog here
Check out our GitHub Tweet

authors: DaSpood mishmanners

repo: github/release-radar


text:
platform name error "xiaomi-purifier-3"

Homebridge config request the PLATFORM name, without it I cant save config.
What are my options?
[9/25/2020, 6:17:11 PM] Error loading platform requested in your config.json at position 2
[9/25/2020, 6:17:11 PM] Error: The requested platform 'xiaomi-purifier-3' was not registered by any plugin.
at PluginManager.getPluginForPlatform (/usr/local/lib/node_modules/homebridge/src/pluginManager.ts:224:15)
at /usr/local/lib/node_modules/homebridge/src/server.ts:385:37
at Array.forEach ()
at Server.loadPlatforms (/usr/local/lib/node_modules/homebridge/src/server.ts:372:27)
at Server.start (/usr/local/lib/node_modules/homebridge/src/server.ts:151:29)
at cli (/usr/local/lib/node_modules/homebridge/src/cli.ts:80:10)
at Object. (/usr/local/lib/node_modules/homebridge/bin/homebridge:17:22)
at Module._compile (internal/modules/cjs/loader.js:1137:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
at Module.load (internal/modules/cjs/loader.js:985:32)
at Function.Module._load (internal/modules/cjs/loader.js:878:14)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
at internal/main/run_main_module.js:17:47
[9/25/2020, 6:17:11 PM] Got SIGTERM, shutting down Homebridge...

I tried also with platform 'homebridge-xiaomi-purifier-3' but it is the same!

Silly me! I've copied to
Accessories: [
]
Works!
Thank you, Mitcho


text:
InnerSource Repository Setup fails to insert Issues

Bug Report
Current behavior
Setup of the InnerSource fundamentals seems to be broken.
Reproduction
Steps to reproduce the behavior in the course:

Go to https://lab.github.com/githubtraining/innersource-fundamentals
Click on Install
Create new public repository.
Click on the "Start Next Step" action button.
Navigates to https://github.com/JenasysDesign/innersource/issues/1 which doesn't exist in the repository created.

Expected behavior
https://github.com/JenasysDesign/innersource/issues should be populated. OR
Innersource repository should include instructions on how to address the missing issues.
Possible solution
Attempted to run https://lab.github.com/install?owner=githubtraining&course=innersource-fundamentals to see if that resolved the issue, but it failed.

Hey @JenasysDesign, thank you for opening this issue. I ran through the course and was able to get the course installed and the issue created as expected. I checked the timestamp on when you installed the course and it aligns with some delays and inconsistent experiences that were being addressed at that time.
I'm not sure if those issues had something to do with your situation but without digging too much into it I'm thinking it may have been related. Could you un-register and try joining the course again to see if the issue persists? If you are still experiencing the same issue I'm happy to look more into it. Thanks!

👋 @JenasysDesign I'm assuming the problem you ran into had to do with the GitHub downtime suggested by @a-a-ron above ☝, so I'll go ahead and close this issue. Feel free to reopen if that's not the case and it's still causing trouble.

It's a little unclear how to remove a gitlab course from your profile.
Is it a case of deleting the course repo at my end?

authors: JenasysDesign a-a-ron hectorsector

repo: githubtraining/innersource


text:
Organisation key email never received

Describe the bug
The Free Organization License Key is never received via email after completing the sign up google form.
I have tried this on Gmail and a work email.
To Reproduce
Go to https://gitleaks.io/ and complete the form after clicking sign up under Free Organization License Key
Expected behavior
The email to be sent
Screenshots
N/A
Basic Info (please complete the following information):

OS: N/A
Gitleaks Verion: N/A

Additional context
N/A
cc @zricethezav

Is there an alternative way to get the Free Organization License Key while the form is being repaired?

authors: ImanSM anthonyseager

repo: gitleaks/gitleaks


text:
🛑 MSP-103 is down

In dd078a0, MSP-103 (https://msp-portal.gw103.oneitfarm.com/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: MSP-103 is back up in 307d650.

repo: gitsrc/upptime


text:
Topic syncing

The topics of the IRC channels are currently empty. It would be nice if the topic would show up and change according to the current topic in the Gitter channel, and the ability to change it with a /topic command.

They seem to be in sync for me. At least for fish-shell/fish-shell, the one hitter room I'm in. If this is fixed it should be closed - otherwise determine what is making some work and others not work.

I also see the topic when using weechat but not if the command /topic is issued.
If clients rely on this functionality they may not be able to set the channel topic correctly.

authors: ThePsionic Unode floam

repo: gitterHQ/irc-bridge


text:
detect links only w/o profiles

Hi! I'm wondering if it's possible to detect social links only, not profiles. For example:
const detectSocialLink = (url: string) =>
  networks.reduce<[network: typeof networks[number] | 'url', url: string]>(
    (prev, network) => {
      try {
        if (socialLinks.isValid(network, url)) {
          return [network, socialLinks.sanitize(network, url)];
        }
      } catch (err) {
        return prev;
      }

      return prev;
    },
    ['url', url],
  );

expect(detectSocialLink('https://instagram.com/vinspee')).toBe(['instagram', 'https://instagram.com/vinspee'])
expect(detectSocialLink('vinspee').toBe(['url', 'vinspee'])

i'd like to take user input and determine which network was detected. When "profile" names match, essentially everything becomes a match until it looks like a URL.

Good point.
I added detectProfile in v1.7.0
I can also automatically detect profile in following functions when profileName is omitted.
getProfileId
getLink
isValid
sanitize
What do you think about this @VinSpee ?

I think that nails it. Looks good! Thanks.

authors: VinSpee gkucmierz

repo: gkucmierz/social-links


text:
Make a schematic of our software stack

@jesscxu, can you get @mgalemmo to accept her invitation to work on this repo?
@mgalemmo has a picture of the whiteboard. Here's another version:

It's more useful to have a prototype than a complete / perfect visualization. Also, I've been using circles as "processing nodes" and squares as "data nodes." Likewise, control is initiated at the base of arrows. Feel free to be creative with how you lay things out though. Maybe have a key or something?

Hi! here is the progress I have so far http://mgalemmo.github.io/graph.html -- where do you want me to put this? of the glass bead website? @davclark

Here is one flow chart example that I found online and used:
http://jsfiddle.net/jesscxu/Ln85jotb/

Cool! You got the arrows to work! @jesscxu

Just to answer @mgalemmo's question - yes, I'd like to put this on bead.glass. I think a combination of what you both have done would be ideal (i.e., larger SVG elements with labels, with arrows in between). For now, you are welcome to simply create a separate page.
I'm also not sure the current approach with the force directed graphs is working well. It seems a bit confusing to me. Consider the clarity of the diagram I've posted above to the current D3 graphs! But iteration is my favorite way to do design! And I'm sure you'll soon surpass the communicative value of the static image.

authors: davclark jesscxu mgalemmo

repo: glass-bead-labs/data-reflector

license: isc


text:
Add zenodo integration

Related to #175, add zenodo integration which allows one to attribute a DOI to the code itself (like a paper) https://docs.github.com/en/repositories/archiving-a-github-repository/referencing-and-citing-content#issuing-a-persistent-identifier-for-your-repository-with-zenodo

I am aware of Zenodo, and it is great for code. In this case, I would rather have people cite the GLASS paper, and not potentially only the DOI for the code or even version that they use.

Okay. However, if you ever want to submit to JOSS or pyOpenSci then you'll need it. Possibly for other journals which require archived code.

authors: ntessore paddyroddy

repo: glass-dev/glass


text:
🛑 Schoelcher is down

In 7288c5b, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 78d0625.

repo: glefait/martinique-public-websites


text:
🛑 cesecem is down

In ec1f517, cesecem (http://www.cesecem.mq) was down:

HTTP code: 526
Response time: 1869 ms

Resolved: cesecem is back up in 9bf80d2 after 5 days, 8 hours, 36 minutes.


text:
🛑 Schoelcher is down

In 523c81e, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in c36a74f.


text:
🛑 Schoelcher is down

In 01fc7e5, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in d5a9294.


text:
Code action from multiple LSPs breaks popup

Description
When code action is received from multiple LSPs, Saga shows actions from only one LSP at first and then breaks when q is pressed to exit out of the first popup that appears.
Expected Behavior
Actions from different LSPs should appear in a single popup to avoid UI issues and to make it easy to select a code action in one go. There is a relevant PR in Telescope for the same.
Actual Behavior

Neovim's built in Behavior

Details

Reproduce
Minimal LSP Saga config:
local saga = require 'lspsaga'

saga.init_lsp_saga {
  code_action_icon = '💡',
  hint_sign = '🌿',
  dianostic_header_icon = "👀 "
}

You'll need to install tsserver and ESLint to provide code actions which can be done using LSP installer plugin. Alternatively, try to emulate code-actions coming from two different LSPs on the same piece of code.

Clone this repository
cd into it and run npm install.
Go to this line

Environment

nvim --version output: NVIM v0.5.0-dev+1221-g9b2d4ff62 \ Build type: RelWithDebInfo
Operating system: Ubuntu 20.04.2 LTS on Windows 10 x86_64
lspsaga commit: 27c7a4796869e155ecec48eb3f8e66694c1708e2

We can get all actions from multiple servers into one window. what do you think?

which client do you used? efm with tsserver?

No, EFM does not provides code action. As I've mentioned in reproduce section of the first comment in this issue, an external plugin is used to install and setup ESLint. This internally uses VS Code's ESLint language server to give code actions.

ah I found it is eslintls

@lrvpxl  I can't get eslintls work... how do you config lspinstaller?  I had run LspInstall eslintls

Have you initialised it?
local installed_servers = require'nvim-lsp-installer'.get_installed_servers()
for _, server in pairs(installed_servers) do
	opts = {}

	if server.name == "eslintls" then
		opts.settings = {
			codeAction = {
				disableRuleComment = {
					location = "separateLine"
				},
				showDocumentation = {
					enable = false
				}
			}
		}
	end

	server:setup(opts)
end

2

Yes, this looks great!
Just one question, when I first used Saga's code action popup I expected that I need to press a number to apply an action but then I found out that I manually need to navigate to that action and press enter. Were there any dicussions happened to not to opt for a numeric keypress?  Did it happened because there is no way to hide the cursor?

authors: glepnir lrvpxl


text:
GLFW_OPENGL_CORE_PROFILE prevents app from creating window

Whenever I use CORE_PROFILE as a window hint, the program cannot create the window. It is however possible to get over this using ANY_PROFILE. The following code will exit with an error because it is impossible to create the window.
#include <GLFW/glfw3.h>
#include <iostream>
int main(){
	glfwInit();
	glfwWindowHint(GLFW_VERSION_MAJOR, 3);
	glfwWindowHint(GLFW_VERSION_MINOR, 3);
	glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_CORE_PROFILE); // line 1
        // glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_ANY_PROFILE); // line 2
	auto window = glfwCreateWindow(800,600,"Test", NULL, NULL);
	if(!window) {
		std::cout << "Unable to create window" << std::endl;
		return 1;
	}
	return 0;
}

However if I comment line 1 and uncomment line 2, the program runs just fine.
Some info about my system:
OS: Artix Linux
CPU: 7th gen Core i5
GPU: Nvidia 1050 4gb
Build system: Cmake

You are mistakenly using GLFW_VERSION_MAJOR and GLFW_VERSION_MINOR instead of GLFW_CONTEXT_VERSION_MAJOR and GLFW_CONTEXT_VERSION_MINOR.

authors: lfg-oliveira tombsar

repo: glfw/glfw

license: Zlib


text:
🛑 INTG-APP is down

In ef95c0c, INTG-APP ($SITE_6) was down:

HTTP code: 403
Response time: 53 ms

Resolved: INTG-APP is back up in b168777 after 7 hours, 48 minutes.

repo: glo-markoaular/status-navigate


text:
🛑 INTG-APP is down

In 05c37ba, INTG-APP ($SITE_6) was down:

HTTP code: 0
Response time: 0 ms

Resolved: INTG-APP is back up in 5b09e80.


text:
CI: Few small improvements. Vetting, vet err fixes, Go 1.10.

This PR fixes two small format specifier string errors in asn1/format_test.go. To prevent these kinds of bugs from slipping in again in the future this PR updates the .travis.yml for CI to run go vet during the script phase of the build. Lastly, this PR adds Go version 1.10 to the .travis.yml.

FYI: It might be worth configuring the project's master branch to be protected based on a Travis CI check. It doesn't look like that's enabled presently and so my PR could be merged by a user with write access even if CI failed.

Fixed the initial build error with f98d1bc. YAML is always a hoot! - 1.10 was being read as 1.1 and using a version of go so old it didn't have the correct command line arguments.

repo: globalsign/certlint


text:
Add prefer_[cpus|gpus]_multiple_of and logic

Description
Add additional keys to warn users when their job is of an unexpected size. Update Frontier default configuration to use the new keys.
Motivation and context
On clusters with no shared partition, some jobs need to request more resources than strictly required in order for the allocation to be granted. Adding a warning configuration option will give users feedback on underutilized jobs without preventing these partial jobs from running.
Note that warnings are returned after the job submission is confirmed.
How has this been tested?
Existing tests have been updated to use the new keys. Due to the nature of the warnings, it is nontrivial to add new tests. This can be addressed in a later PR.
Checklist:

[x] I have reviewed the Contributor Guidelines.
[x] I agree with the terms of the Row Contributor Agreement.
[x] My name is on the list of contributors (doc/src/contributors.md) in the pull request source branch.
[x] I have added a change log entry to doc/src/release-notes.md.

If it would be beneficial to add new tests, please let me know! I cannot seem to build Row on Frontier so the current code is untested in practice.

I've looked into moving up where the warning is issued. This is difficult because we cannot warn until we know the partition. If we rewrote the code to call find_partition before submit, then we would either end up calling find_partition twice (and seeing the warning twice), or making some big refactors to the code that require a persistent scheduler object. For example, we could implement a prepare method that must be called on all actions/directories before submit. This isn't a very clean API.
Either case would cause a large change in behavior. Currently submit will submit the first N-1 jobs successfully when the N'th cannot find a partition. If we check all the partitions first, then submit would submit 0 jobs in this case.
How much of a problem is it that the warning comes after the confirmation?

I think it is probably OK - while less than optimal, I think the downsides of addressing the issue outweigh the minor upside. Most clusters have a shared partition, and users on Frontier/Andes (those who would see this warning) are likely to have significant experience anyway.

repo: glotzerlab/row


text:
Update all notebooks and projects, add CI testing

This is a large PR that overhauls the entire signac-examples repo to bring it a little more up to date with signac's current structure. I sought out to enable CI testing for the notebooks and projects in this repo. However, the notebook syntax and project files were very out of date and inconsistent with modern Python / signac usage. For example, there were numerous references to the glotzerlab conda channel and a ton of Jupyter notebook "magic" syntax that is no longer valid, as well as example projects that still used operations.py and had an old-style project.py -- most of the code was not runnable and failed the flow-test script.
There is a still a lot of cleanup to do, specifically removing examples for features that we plan to deprecate and remove in signac 2.0, and modernizing specific projects (e.g. HOOMD, GROMACS, Quantum Espresso). Regardless, I think this is a good start.
I don't think it's worth the signac team's time to review the code changes in this PR in the form of a diff -- in spirit, the code is all the same. I am tagging @glotzerlab/signac-committers for awareness but not requesting reviewers. The diffs are massive because I applied some reformatting (the code style was super inconsistent) and all sorts of other miscellaneous improvements as well as adding the new CI scripts. I would be happy to give a short overview of this effort in a future dev meeting but I plan to merge this PR in its current state after a few days (to allow discussion), and perform all further changes incrementally.
I will also help rebase #14 and #15 over this set of changes. This PR supersedes #9 -- thanks again to @CryoZEUS for his initial efforts on getting this started!

@bdice Thank you for the effort. From my side it's fine to merge this without review, I trust your judgement.

authors: bdice csadorf

repo: glotzerlab/signac-examples


text:
Update Cargo.toml files to inherit workspace level configs,

Shares edition, description, license, repository and documentation fields

Pull Request Test Coverage Report for Build 4133701839

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.624%

Totals

Change from base Build 4133523165:
0.0%

Covered Lines:
39273

Relevant Lines:
39821

💛  - Coveralls

authors: coveralls panarch

repo: gluesql/gluesql


text:
Bring GLEN 2.x base up-to-date with upstream staging/1.1.0.

Changes relevant to issues specific to 1.x have been merged upstream for the pending 1.1.0 release. There are no corresponding issues for this in 2.x, as the base release for 2.x is 1.1.0 and thus implicitly includes these changes.

The relevant GLEN 1.x changes mentioned above are #395 and #396.

repo: glyptodon/guacamole-client


text:
在php xcat createAdmin时提示aws错误

PHP Parse error:  syntax error, unexpected '$value' (T_VARIABLE) in /home/wwwroot/feuler.cn/vendor/aws/aws-sdk-php/src/functions.php on line 36
我好像没碰过这个文件额,.config.php里面的aws id和key都填上了

以后提问请带上站点地址。
PHP版本问题。

我也发现了,升级php就好了.站点在文件夹路径里有的哈.感谢大神的项目:)

php 5.4  行不行？

@lithromantic 5.6+

authors: FeulerLoup glzjin lithromantic


text:
Optional dmget kwarg to transfer data to disk before opening it

I find my workflow is much more streamlines if I just (optionally) include a dmget before loading any data. I often find myself forgetting to dmget some of the files or trying to load them while they are still migrating, and therefore being stuck at the data-loading step for a long time.
This PR includes an optional dmget kwarg (defaulting to False) to open_frompp that, if true, uses the issue_dmget function to run the dmget command and then a new query_all_ondisk function that calls query_ondisk to check that all of the requested data file paths are on disk. It only moves on the the xr.open_mfdataset command after the query confirms that all of the necessary data files are available on disk.

There is still a bug that occurs when the local directory (e.g. ocean_daily) exists but has no files in it.


text:
How to concatenate content?

I'm running remarkjs from within hugo. The markdown file is processed through the sourceUrl parameter as follows:
 var slideshow = remark.create({
          highlightStyle: 'monokai',
          highlightLanguage: 'remark',
          highlightLines: true,
          sourceUrl: "/slides/{{ .Params.slidesfile }}"
        }) ;

where .Params.slidefile is the name of the file. What I need to do is concatenate content to the file prior to processing, something, say like a.md+b.md. Is there a way?

I use followin skeleton to concatenate markdown. Remember that you need to use some simple server then
<!DOCTYPE html>
<meta charset="utf-8">
<title>Laboratory meeting</title>
<link rel="stylesheet" href="css/base.css">
<link rel="stylesheet" href="css/slide.css">
<textarea id="source"></textarea>
<script src="js/remark.min.js"></script>
<script src="js/jquery-2.1.4.min.js"></script>
<script>
var slideshow;
$(function() {
  $.when(
    $.get('slides/00-begin.md'),
    $.get('slides/01-introduction.md'),
    $.get('slides/99-end.md')
  ).done(function() {
    var args = Array.prototype.slice.call(arguments);
    var contents = args.reduce(function(previousValue, currentValue) {
      return previousValue + currentValue[0] + "\n---\n";
    }, '');
    $('#source').html(contents);
    slideshow = remark.create({
      ratio: '16:9'
    });
  });
});
</script>

You could do as @lambdalisue suggests, or perhaps Hugo is capable of concatenating the content into a single Markdown file that can be handed over to remark. I am not familiar with Hugo, though, so unless you go with the suggested answer you'll have to do some more research on the capabilities of Hugo.

authors: gnab lambdalisue yitzhakbg

repo: gnab/remark


text:
🛑 Seasia is down

In 4900111, Seasia (https://seasia.co) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Seasia is back up in 22787bd.

repo: gnfi/status


text:
Fix #4

Should fix issue #4 (probably there is a more elegant way of doing it...).

I agree. Would something like the following (untested) be better?
list(APPEND GPU_ARCHS 35 50 60 70)
if (NOT ("${CUDA_VERSION}" VERSION_LESS "10.0"))
    list(APPEND GPU_ARCHS 75)
endif()

foreach(arch ${GPU_ARCHS})
    set(CMAKE_CUDA_FLAGS "${CMAKE_CUDA_FLAGS} -gencode arch=compute_${arch},code=sm_${arch}")
endforeach()

set(CMAKE_CUDA_FLAGS "${CMAKE_CUDA_FLAGS} -Werror cross-execution-space-call,deprecated-declarations")

That would work, but I already pushed a different code structure.

authors: RMeli dkoes

repo: gnina/libmolgrid


text:
Add GH check to avoid backward incompatible schema changes

We have already made some incompatible changes. This check is to avoid them and make users trust that the API won't change in an incompatible way unless a method is deprecated.

Closing as the GH action used is not able to use more than one schema file for validation.

repo: gnolang/tx-indexer


text:
Feature/connect auction last price

Connect AuctionPriceBar to state and updated:

api/dutchx
containers/AuctionPriceBar
reducers/ratioPairs
actions/blockchain
package-lock

@Velenir take a look at this fresh in the morning with me and let me know if you're still ok with a merge

repo: gnosis/dutch-exchange


text:
Make bad token detector more generic over amm pool sources

Currently we use AmmPairProvider which is only implemented for Sushiswap
and UniswapV2. We introduce a trait to be more generic and can in the
future be implemented for more sources.
The plan is to use this to consider BalancerV2 pools as well.
Test Plan
mainnet node test still works.

I wonder if we should eventually just simulate the baseline solution in the API to check if tokens are tradable?

I guess this suggestion would be to do this instead of token detecting, because otherwise working with just baseline would encounter the same problems we are seeing today (i.e. that it would work on paraswap or 1inch, but not with Baseline). Once we have integrated all the existing onchain liquidity sources, however, this may actually work. I suppose this is what you were hinting at.

The more logic we have to implement for the bad token detection, the more I wonder if we should eventually just simulate the baseline solution in the API to check if tokens are tradable?

Good point. Not sure about the details. Will create issue to remember this.


text:
Added config entries for request timeouts agains the core services

Closes #340
This PR will be addressed in #341

Introduced request time outs for requests against the core services
Added specific values for certain endpoints (see #340 )

These changes will be addressed by #341

repo: gnosis/safe-client-gateway


text:
Add unit tests for the ReviewConfirm modal

Description
A follow up to #2706.
We need tow write a unit test that sends a wrong param in the value field of a proposed transaction. Specifically, a 0 and undefined.

Specifically, a 0 and undefined.

I thought we decided we don't handle undefined? It will crash the interface and it's expected because we test the app before adding it.

As I understood from your comment in that PR, undefined is supposed to be caught by isValid function.

nit: this will be more than a unit test 🙂

authors: katspaugh mikheevm

repo: gnosis/safe-react


text:
Ledger Support

What is this about?
As a user that owns a Ledger device, I want to use my ledger device as a Safe owner without having to import the account in Metamask.
Why do we need this?
Especially users that manage a lot of funds typically have a Ledger wallet and the corresponding seed phrase securely backed up. We want to be able to allow these users to use their ledger wallet as a signer for a Safe Multisig. Currently this is already possible by importing the ledger device account into Metamask, but this is not as secure and convinient as a native ledger integration.
Acceptance criteria

Compatible with Ledger Nano S / Ledger Nano X
All actions (create Safe, change settings, initiate transaction, confirm transaction) should be possible
Could be included as a custom provider in Web3Connect
Maybe even contribute to the Web3Connect open-source repo

Update: onboard.js released a first experimental version with hardware wallet support. Let‘s create a first internal test-version.

Having issues with the ledger in the desktop app (windows version)
It will throw me this error no matter what

I've tried in staging with the browser version and it works fine there, so it seems to be an incompatibility issue with the desktop version

Closing this as the reported issue should be addressed in #665

authors: francovenica lukasschor


text:
(Bugfix) - #1246 Addressbook entries removed when reloading page

Closes #1246
Description

Add types, removes duplicated code
Simplifies the addressBook state, previously was like: {addressBook:{addressBook:[]}}, now it just: {addressBook: []}
The error was caused basically because we were saving an empty addressBook even if the addressBook was empty

Travis automatic deployment:
https://pr1300--safereact.review.gnosisdev.com/app

Simplifies the addressBook state, previously was like: {addressBook:{addressBook:[]}}, now it just: {addressBook: []}

What happens to the users who have old structure in their storage?

Simplifies the addressBook state, previously was like: {addressBook:{addressBook:[]}}, now it just: {addressBook: []}

What happens to users who have old structure in their storage?

That's not a problem, I updated how we are managing the state on redux, not how we are storing it on localStorage, you can do the test using this preview branch and another one if you like

The address book starts empty (normal behavior), and I started to add names to it and they were saved correctly.
But after refreshing the page a couple of times the list suddenly filled itself with all the owner of that safe, but without their name, probably because they are called all "Owner#N" and there is a condition to hide those names and the "UNKNOWN" ones as well
Chances are that this are 2 different issues, one is the address book being filled on its own and the other is not showing the name for being a name by default

Steps:
Enter in the address book. If a safe was never load in the PR the address book will be empty
Create an entry in the address book
Go to send funds and use the recipient field to search for the entry created.
Close the form and go back to the address book
If you refresh the page, it loads all the owners of the safe as shown in the snapshot
https://pr1300--safereact.review.gnosisdev.com/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/address-book

As fas as I investigated, most of this issues are related to a race condition between the load of the safe and the load of the address book, we are currently syncing the owners of each of the safes and there are times in which the safe is loaded before the addressBook. I think that the best solution should be the implementation of this refactor  in order to have an unique source of truth and avoid this sync of owners between safes. What do you think? @lukasschor

Travis automatic deployment:
https://pr1300--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1300--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1300--safereact.review.gnosisdev.com/app

I'm not sure if the current behavior.

I opened this locally, with already stored addresses in the AddressBook, nothing was listed. So I assume this is a destructive change?

After cleaning the storage, no address was preloaded. As I loaded the Safe using the URL (not the Load Storage form), owners weren't loaded either.

This last item makes the thing a bit hard to handle.
I'm not being told what should I do to have the owners loaded.

I added a migration function together with tests to avoid the destruction of the old addressBook, please check it out

Travis automatic deployment:
https://pr1300--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1300--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1300--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1300--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1300--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1300--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1300--safereact.review.gnosisdev.com/app

The issues reported in #1246 and #558 were solved
There is an inconsistency how address book is working regarding the unknown names, and addresses being added automatically sometimes. This is going to be discussion on when and how implement it.
But since the 2 main issues are solved here I'll approve the PR

Travis automatic deployment:
https://pr1300--safereact.review.gnosisdev.com/app

authors: Agupane francovenica gnosis-info mikheevm


text:
🛑 Explorer is down

In ee9d3e4, Explorer (https://blockscout.chiadochain.net/) was down:

HTTP code: 503
Response time: 409 ms

Resolved: Explorer is back up in 8f24184.

repo: gnosischain/chiado-uptime


text:
feat: implement probes and health checks

zpages
k8s probes

Done.

repo: go-faster/oteldb


text:
Git hooks are not being executed on Windows when running as a service

Similar to https://github.com/go-gitea/gitea/pull/736
When hooks call Gitea executable, it immediately stop because it conflicts with minwinsvc. If it's not running as service, it works normally.
Set env SKIP_MINWINSVC=1 should work.

Should this be put to v1.1? Maybe we can move this to 1.2? @andreynering

This was working before, I think we should really fix for v1.1
I'll try to fix later today, I think it's trivial.
Where are Git hooks located on source code and how can we update it on a migration?

See this PR https://github.com/go-gitea/gitea/pull/1006. We will wait for this issue to release 1.1 .

authors: andreynering lunny

repo: go-gitea/gitea


text:
Display Labels descriptions in tooltips on issues

Description
Hi!
Issue
Currently (as of 1.22.0), labels descriptions are displayed in the label dropdown menu of the side bar of an issue:

Proposition
However as you can see the description overflows the menu area. Gitea already have tooltips to display the description on hover:

Do you think it would be a good idea to hide the descriptions under labels and only display them on hover?
Side note
On 1.23.0+dev-322-g0bb4c1cde2, descriptions doesn't overflow but the dropdown menu instead have horizontal scrolls:

I tried to use ellipsis:

And wrap texts:

To have a glance of how it would be looking, but I prefers tooltips (as it is already implemented).
Best.
Gitea Version
1.22.0
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
Docker using lastest from Dockerhub.
Database
SQLite

I guess ellipsis with tooltip will be fine. GitHub has similar style, but no tooltip (which is bad):

Also, we should add like 2px vertical gap between label and text.

I guess ellipsis with tooltip will be fine.

Is not that too much? I like the slim and clean version where description are visible only when you are looking for them (imo). The inconvenient of elipsis is the risk of not understanding a description because there is nowhere you can easily fully read it.

authors: SimonPistache silverwind


text:
Gogs webhook form missing ContentType field

Gitea version (or commit ref): 1.11.0+dev-496-g3e166bd05
Git version:
Operating system: Linux (docker) docker.io/gitea/gitea@sha256:19fd040118804252e4d991b8279d84be965c12ab1fa02cbb51119e5475b69bb0
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[X] SQLite

Can you reproduce the bug at https://try.gitea.io:

[X] Yes (provide example URL)
[ ] No
[ ] Not relevant

Log gist:

Description
There seems to be a field for content type missing from the page, when i submit the form to add a Gogs webhook, then i get a validation error, if i look in the gitea webhook add page there is an extra field.
Screenshots

after a bit more investigation, it looks like the field is hidden, so you can edit the page with the inspector to work around this for the time being

			POST Content Type

				<input type="hidden" id="content_type" name="content_type" value="application/json">

application/json

application/x-www-form-urlencoded

Thanks @russell. By setting value="1", taking from a working webhook, I was able to get the form to work.

Any one could you send a PR?

Fixed by #10456

authors: guillep2k jvstein lunny russell


text:
Possibility to delete source Branch

Description
Like in Gitlab (i'm not realy sure about Github) there should be an option to delete the source branch whenver an pull request is merged.

Mhh...surprisingly i found this https://github.com/gogits/gogs/issues/3201 which indicates that was integrated into gogs but i could not find the matching commit...

Do you mean something like #441?

Maybe, reads like it is such an feature but i can not see such an button if i generate an pull request (using gitea v1.0.1).  Maybe i look at the wrong place as the code means repo/issue.go was changed???

This feature got added to the latest master branch not to v1.0.1. We'll release v1.1.0 @ 24 feb

Ok, thanks...i see it was merged one day after release of 1.0... :smile:
Close

authors: Bwko MorphBonehunter


text:
Correctly escape within tribute.js (#20831)

Backport #20831
When writing html in tribute.js ensure that strings are properly escaped.
Signed-off-by: Andrew Thornton art27@cantab.net

That was fast…

merged without waiting for CI as it is a pure JS change that is not in the test cases.

authors: delvh zeripath


text:
fix orgnization webhooks

fix missing discord webhook wrong route and missing template on orgnization webhooks and fix bug on deliver webhook.

LGTM

What was the bug that led to the changes to the HookTask.deliver() method?

@ethantkoenig that should be a bug of GetWebhookByRepoID when the webhook is an orgnization webhook. Then the latest status will not be updated. And I added UpdateWebhookLastStatus for only update the last_statu but not all the columns.

LGTM

authors: ethantkoenig lafriks lunny


text:
Fix show more for image on diff page

Right now when clicking on loadmore on files change page, if the loaded content is image, it will be always in load status:
https://github.com/go-gitea/gitea/assets/17645053/39e449b6-067a-474c-9443-9dd98d5bbfe2
This PR fixes this by adding initImageDiff  to onShowMoreFiles
After:
https://github.com/go-gitea/gitea/assets/17645053/87bbb13e-0064-4a6e-a7ad-0f0060eb8bff

I'm not sure, but doesn't this PR introduce a regression when there are already images present and pressing show more?
After all, the existing images will be reloaded as well as far as I can see.

I do not think this fix is right. The duplicate call to initImageDiff causes duplicate event handler / initialization and would cause strange behaviors / bugs.

ps: It seems all people like merging as soon as possible after lgtm/done, so, nobody should complain any more, just keep fixing bugs as soon as possible at the same time.

Sorry, it looked pretty straightfoward, need to give more time next time.

@HesterG I don't think we need to revert, what about #25675 instead?

@HesterG I don't think we need to revert, what about #25675 instead?

That looks good, thanks.

authors: HesterG delvh silverwind wxiaoguang


text:
Update locales

cherry-pick from gogits@d3b2ff1 and resolved #434

It got conflicts.

authors: lunny tboerger


text:
Fix repo_admin_change_team_access always checked in org settings

Fix bug from #8045.
Signed-off-by: David Svantesson davidsvantesson@gmail.com

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5774260). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #8319   +/-   ##
=========================================
  Coverage          ?   41.53%
=========================================
  Files             ?      494
  Lines             ?    65385
  Branches          ?        0
=========================================
  Hits              ?    27157
  Misses            ?    34731
  Partials          ?     3497

Impacted Files
Coverage Δ

routers/org/setting.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5774260...bbfb121. Read the comment docs.

Make LG-TM work

authors: codecov-io davidsvantesson lafriks


text:
Add missed close in ServeBlobLFS (#8527)

Backport of #8527 on to 1.10

make lg-tm work


text:
SQLite foreign key not created on self-reference

I have this example
type Category struct {
	gorm.Model

	Name        string  `json:"name" gorm:"type: not null; unique"`
	Description string  `json:"desciption"`
	Stocks      []Stock `gorm:"constraint:OnUpdate:CASCADE,OnDelete:CASCADE"`

	ParentID *uint
	Parent   *Category `gorm:"foreignkey:parent_id;constraint:OnUpdate:CASCADE,OnDelete:CASCADE;"`
}

I want category to have self-reference on parent_id,
The screenshot below shows that the foreingkey between category and parent_id doesn't exist:

i did a solution
// just to add a self-relation in category! (bug https://github.com/go-gorm/gorm/issues/5584)

SQL := `
PRAGMA foreign_keys = 0;

CREATE TABLE sqlitestudio_temp_table AS SELECT *
                                          FROM categories;

DROP TABLE categories;

CREATE TABLE categories (
    id          INTEGER,
    created_at  DATETIME,
    updated_at  DATETIME,
    deleted_at  DATETIME,
    name                 NOT NULL
                         UNIQUE,
    description TEXT,
    parent_id   INTEGER  CONSTRAINT fk_categories_categories REFERENCES categories (id) ON DELETE CASCADE
                                                                                ON UPDATE CASCADE,
    PRIMARY KEY (
        id
    )
);

INSERT INTO categories (
                           id,
                           created_at,
                           updated_at,
                           deleted_at,
                           name,
                           description,
                           parent_id
                       )
                       SELECT id,
                              created_at,
                              updated_at,
                              deleted_at,
                              name,
                              description,
                              parent_id
                         FROM sqlitestudio_temp_table;

DROP TABLE sqlitestudio_temp_table;

CREATE INDEX idx_categories_deleted_at ON categories (
    deleted_at
);

PRAGMA foreign_keys = 1;
`

database.Exec(SQL)

It's works!
But it doesn't work with gorm-sqlite-cipher driver

repo: go-gorm/gorm


text:
FLAC 緩存/下載 Deadlock

Check for existing issues
检查是否已存在相同issue

[X] Completed/已检查

Describe the bug and provide steps to reproduce it
描述遇到的bug并提供相应的复现方法
復現: 下載任一 FLAC file
如果歌曲是 FLAC，在SetSongTag會 Deadlock，花了點時間排查。
https://github.com/go-musicfox/go-musicfox/blob/59663906f8b24a7162624a9ca9b3de7d592b4cf3/utils/utils.go#L338
原因是這個 SaveFile，原檔名不能和目標檔名相同。
func (flac *FLAC) SaveFile(path string) error {
	file, err := os.Create(path)
	if err != nil {
		return err
	}
	defer file.Close()

	return flac.Save(file)
}

他會開一個同名的 File，然後就 Deadlock了。
解決辦法: tmp file
_  = metadata.SaveFile(file.Name() + "-tmp")
os.Rename(file.Name() + "-tmp", file.Name())

Environment / 运行环境
musicfox: master branch
OS: macOS 10.15.7
If applicable, list the error messages you see
如果有错误输出请一并填入
No response
If applicable, attach your ${MUSICFOX_ROOT}/musicfox.log file to this issue.
如果${MUSICFOX_ROOT}/musicfox.log里有错误日志，请一并上传
No response

我的问题，没考虑看tag的源码
要不你自己提个pr吧，我现在不方便开电脑

repo: go-musicfox/go-musicfox


text:
Cannot install package

I cannot install the package.
root@9f916739e663:/go/src/prt# go get -u github.com/go-redis/redis/v7
package github.com/go-redis/redis/v7: cannot find package "github.com/go-redis/redis/v7" in any of:
        /usr/local/go/src/github.com/go-redis/redis/v7 (from $GOROOT)
        /go/src/github.com/go-redis/redis/v7 (from $GOPATH)

Initialize Go module
go mod init github.com/my/repo
go get github.com/go-redis/redis/v7

authors: Serhioromano vmihailenco

repo: go-redis/redis