text:
bug(mat-slide-toggle): Incorrect accent dark theme color

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
The accent colors for mat-slide-toggle were overriden by random colors:

Reproduction
Steps to reproduce:

Use @include mat.all-component-colors($dark-theme); to set component colors for dark theme.
Add mat-slide-toggle to a template:
`

Expected Behavior
Accent colors of dark theme are used for mat-slide-toggle's.

Actual Behavior
Random colors are used for mat-slide-toggle's in dark theme.

Environment

Angular: 16.1.6
CDK/Material: 16.1.6
Browser(s): Chrome, Version 114.0.5735.133 (Official Build) (64-bit)
Operating System (e.g. Windows, macOS, Ubuntu): Ubuntu

The default behavior is that Angular Material sets the colors which you defined in your theme. In light theme apparently you are overriding this colors with your own CSS variables. In dark theme you don't do it. By using the mat.all-component-colors mixin, the colors from the theme are set, scoped to the .dark-theme selector and without your own CSS variables. Due to higher specifity they win over your variables. I think everything is working as intended.
To fix it you either need to do whatever you do for light theme again for dark theme, however you would end up having the same CSS variables twice. What you could also try is to stop using the mat.all-component-colors mixin for dark mode and load the colors of each component separately with the corresponding mixin, omitting the one for the slide toggle. However this could have the side effect that colors like the text colors end up missing.

+1 to everything @json-derulo said. As far as I can tell, this is working as intended

authors: json-derulo lukasma wagnermaciel


text:
Updates to conform to new ng doc example home

Fixes #25

LGTM, but of course an engineer (@thso, I hope) should check the code.

Nice change and simplifications!

source: gharchive/pull-request

authors: chalin kwalrath thso

repo: angular/dart-doc-syncer

license: MIT

license_type: permissive

license_source: github-api


text:
Can't import overlay.scss

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Be able to import @angular2-material/core/overlay/overlay
What is the current behavior?
Module build failed:
@import 'variables';
^
      File to import not found or unreadable: variables
Parent style sheet: /home/fabio/playground/angular2-scaffolding/node_modules/@angular2-material/core/overlay/overlay.scss
      in /home/fabio/playground/angular2-scaffolding/node_modules/@angular2-material/core/overlay/overlay.scss (line 3, column 1)

What are the steps to reproduce?
Just import overlay into your scss file:
@import '~@angular2-material/core/style/core';
@import '~@angular2-material/core/overlay/overlay';

Which versions of Angular, Material, OS, browsers are affected?
2.0.0-alpha.7-4

I think that core and overlay styles should not be imported into your components, but rather linked to in your index.html
<link rel="stylesheet" href="path/to/core.css">
<link rel="stylesheet" href="path/to/overlay.css">

See: https://github.com/angular/material2/issues/972#issuecomment-240760777

@RoxKilly I'm importing those to my index.scss, not my components and I fact you can import those css files, into your root component if you disable the ViewEncapsulation. The issue here is that the scss file is not valid, it's trying to import the variables file, when there's no file to import

@FabioAntunes  don't load the overlay.scss file, load the overlay.css file.....

Also, forget about importing the file.
Just include the two css rules in your own styles

Same here, Icannot imnport it nowhere, index.html or styleurls. I'm getting 404 even that the file is there

Obsolete by theming update.

source: gharchive/issue

authors: FabioAntunes RoxKilly jelbourn spock123 vapits


text:
md-input tabindex

Bug, feature request, or proposal:
providing tabindex value results in md-input element receiving focus, in addition to actual input element
What is the expected behavior?
tabbing results in the input element receiving focus without md-input receiving focus
What is the current behavior?
What are the steps to reproduce?
apply a tabindex attribute to  and attempt to tab to it
Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: http://plnkr.co/edit/o077B6uEiiIgkC0S06dd
What is the use-case or motivation for changing an existing behavior?
specifying a non-default tab order
Which versions of Angular, Material, OS, browsers are affected?
Is there anything else we should know?
seems like this could be remedied by removing/not applying tabindex attribute to the root level element (md-input).

Will be resolved as part of md-input refactoring

md-input-container is now available which gives the user control of the underlying input element. you should be able to place the tabindex on the native input now

authors: bpearce6942 jelbourn mmalerba


text:
German Date format is not correct.

Bug, feature request, or proposal:
German Date format is not correct.
What is the expected behavior?
I am trying to use German Date picker format in my project and the format currently supported is 1.1.2017. which is false. FYI .I have upgraded my project to material beta 12.
What is the current behavior?
It should ideally be for e.g. 01.01.2017.
What are the steps to reproduce?
http://plnkr.co/edit/t1yMm5DhUa2soxB82dWh?p=preview
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
material beta 12
Is there anything else we should know?
no

See https://material.angular.io/components/datepicker/overview#internationalization


text:
webDriverProxy strips grid hub port number

When I specify a web driver proxy, the requests to the hub are made without the hub port number.
You can reproduce the issue by following the example test here and using the following config:
exports.config = {
  seleniumAddress: 'http://{selenium-hub-host}:4444/wd/hub',
  webDriverProxy: 'http://127.0.0.1:8888',
  capabilities: {
    browserName: 'chrome'
  },
  specs: ['*.spec.js']
};

Fire up fiddler (it runs on 127.0.0.1:8888 by default), run the test, and the test times out obtaining a session from the hub because the initial request is made to the hub on the wrong port (notice port 4444 is not specified):
POST http://{selenium-hub-host}/wd/hub/session HTTP/1.1
Accept: application/json; charset=utf-8
Content-Length: 58
Content-Type: application/json;charset=UTF-8
Host: {selenium-hub-host}
Connection: close

{"desiredCapabilities":{"browserName":"chrome","count":1}}

Node Version: 5.3.0
Protractor Version: 3.2.1
Operating System and Version Windows 10

I'm also seeing this issue with the latest version of Protractor. Probably an issue with selenium-webdriver being used incorrectly, but I need to investigate more.

This was an issue with selenium-webdriver 2.53 and is fixed in 3.0, which is used in our beta branch.

authors: gregjhogan juliemr

repo: angular/protractor


text:
Unable to select first checkbox out of multiple checkbox available.

I have a web application which has multiple checkboxes with certain text associated with it. HTML code looks like below.
<label ng-repeat="(key, value) in tables">
	<input type="checkbox" />
	<span> Text1 </span>
</label>
<label ng-repeat="(key, value) in tables">
	<input type="checkbox" />
	<span> Text2 </span>
</label>
<label ng-repeat="(key, value) in tables">
	<input type="checkbox" />
	<span> Text3 </span>
</label>
<label ng-repeat="(key, value) in tables">
	<input type="checkbox" />
	<span> Text4 </span>
</label>
<label ng-repeat="(key, value) in tables">
	<input type="checkbox" />
	<span> Text5 </span>
</label>

Now, I want change the status of checkbox based on the input provided by user. for that I have written a generic function, which looks like below.
select_filters: function (filter_list) {
		element(by.repeater('(key, value) in tables')).isPresent().then( function (status) {
			if (status) {
				element.all(by.repeater('(key, value) in tables')).then( function (labels) {
					for (var idx=0 ; idx<labels.length ; idx++){
						var label = labels[idx];
						var span_ele = label.element(by.tagName('span'));
						span_ele.getText().then(function (txt) {
							var check_ele = label.element(by.tagName('input'));
							check_ele.isPresent().then( function (status) {
								if (status) {
									if (filter_list.indexOf(txt) > -1){
										browser.logger.info('select_filters: Filter "' + txt + '" was passed to select. Checking the checkbox.');
										check_ele.isSelected().then(function (selected) {
											if (selected) {
												browser.logger.info('select_filters: Filter "' + txt + '" is already Checked.');
											} else {
												browser.logger.info('select_filters: Filter "' + txt + '" is Un-Checked. Changing status to Checked for the same.');
												check_ele.isSelected().click();
												browser.logger.info('select_filters: Filter "' + txt + '" is Checked.');
											}
										});
									} else {
										browser.logger.info('select_filters: Filter "' + txt + '" was not passed to select. Un-Checking the checkbox.');
										check_ele.isSelected().then(function (selected) {
											if (selected) {
												browser.logger.info('select_filters: Filter "' + txt + '" is checked. Changing status to Un-Checked for the same.');
												check_ele.isSelected().click();
												browser.logger.info('select_filters: Filter "' + txt + '" is Un-Checked.');
											} else {
												browser.logger.info('select_filters: Filter "' + txt + '" is already Un-Checked.');
											}
										});
									}
								}
							});
						});
					}
				});
			}
		});
},

But instead of selecting checkbox within first or other label tag, it always select the last checkbox. whereas span element returns proper text which is there in the label.

Hi! This looks like a support question. Please ask your support questions on StackOverflow, Google Group discussion list, or Gitter. For more information please reference https://github.com/angular/protractor/blob/master/CONTRIBUTING.md#questions
Thank you!

Problem got resolved using the forEach loop instead of normal for loop.
element.all(by.repeater('(key, value) in tables')).then( function (labels) {
labels.forEach(function (label) {
//Code here.
});
});

authors: cnishina raghvendra-chourasia


text:
Protractor : Unexpected error launching Internet Explorer. Pro tected Mode settings are not the same for all zones

Hi All,
I am facing issue while launching protractor code.
Below are the code that i am using:
conf.js with below code
// An example configuration file.
exports.config = {
    // The address of a running selenium server.
    seleniumAddress: 'http://localhost:4444/wd/hub',

    // Capabilities to be passed to the webdriver instance.
    capabilities: {
       // 'browserName': 'chrome'
        'browserName': 'internet explorer'
    },

    // Spec patterns are relative to the current working directly when
    // protractor is called.
    specs: ['example_spec.js'],

    // Options to be passed to Jasmine-node.
      allScriptsTimeout: 500000,
    jasmineNodeOpts: {
        onComplete: null,
        isVerbose: true,
        showColors: true,
        includeStackTrace: true,
        defaultTimeoutInterval: 1000000
    }
};

sample_class.js file with below code:
describe('angularjs homepage title check', function () {
    it('should have a title', function () {
        console.log('Step 1');
        browser.get('http://google.com');
        expect(browser.getTitle()).toEqual('My Todolist Page');
    });
});

And there are the command i used to launch

Installed protractor and node js
webdriver-manager update --ie
webdriver-manager start

Please find the error i am getting below
13:24:20.675 WARN - Exception: Unexpected error launching Internet Explorer. Pro
tected Mode settings are not the same for all zones. Enable Protected Mode must
be set to the same value (enabled or disabled) for all zones. (WARNING: The serv
er did not provide any stacktrace information)
Command duration or timeout: 41 milliseconds
Build info: version: 'unknown', revision: 'unknown', time: 'unknown'
System info: host: 'US1INF020D70194', ip: '10.16.198.27', os.name: 'Windows 7',
os.arch: 'amd64', os.version: '6.1', java.version: '1.8.0_121'
Driver info: driver.version: InternetExplorerDriver

I cant change my IE settings because it is disabled in my machine.  Please recommend anything we can do in code.

Hi there!
First of all you need to set those settings in IE, otherwise you can't automate it.
Secondly, since it involves usage and debugging (and you haven't used the issue template to indicate otherwise), your question is better suited for StackOverflow or Gitter. Please ask a question there with the 'protractor' tag or post in the Gitter Channel to get help.
From the getting help section of the README.

Please ask usage and debugging questions on StackOverflow (use the "protractor" tag) or in the Angular discussion group. (Please do not ask support questions here on Github.)

Thanks!

authors: ManojMN wswebcreation


text:
[Feature Request] Different browsers support in one test run.

Feature Request

Reasons for adopting new feature

Cannot create 2 different browser instances (i.e. chrome and ff for web-rtc app testing).
currently browser.forkNewDriverInstance() returns the same browser as configured in protractor.config.js
would be great to have something like:
browser. forkNewDriverInstance().usingCapabilities({   'browserName': 'firefox',   'moz:firefoxOptions': {     'args': ['--safe-mode']   })

Is this a breaking change?

I'm not sure.
Theoretically it will just extend existing functionality

Cannot check right now, but you should be able to fork new browser instance, then set capabilities to new instance, then after reload it should start with new caps, including different browser.

@tymfear hi.
To be true I have no idea how to do it.
If you will share some code it would be realy great.
Anyway it's kinda walkaround but not an implemented functionality.

@CAPie something like the following:
const ffBrowser = await browser.forkNewDriverInstance().ready;
(await ffBrowser.getProcessedConfig()).capabilities = {} // new caps goes here;
await ffBrowser.restart();

I wrote it blindly, so some issues might arise. But I use this approach to install extension to new another instance of browser. So it should work.

@tymfear I've got it, tnx it works for me =)
but in this way I'm receiving a lot exceptions:
Failed: This driver instance does not have a valid session ID (did you call WebDriver.quit()?) and may no longer be used.
(due to my code architecture)

@CAPie , I'm Egypt now, and internet sucks here. I will return on this week and will try to make some basic example. I'm not sure if your architecture cause any troubles. Just one thing you need to be aware of is that your page objects must accept browser instance in constructor and use it for element locations and interactions. If you manage before I make an example, please ping me. Good luck!

@tymfear I've done some refactoring so it works for me now.
tnx for solution.
anyway would be great to have it implemented from the box.
for me it looks quite weird that default framework cannot manage driver sessions.

@CAPie can you please share how you implemented this? I am trying to do a similar thing. Creating 2 instances one in chrome and another in firefox. 2 different logins using a chat feature in real-time.

based on @tymfear's answer the refactoring that needs to be done is
ffBrowser = await browser.forkNewDriverInstance().ready; (await ffBrowser.getProcessedConfig()).capabilities = {} // new caps goes here; ffbrowser = await ffBrowser.restart();

Hi guys, i have been trying the above solution for a case where i want to start a new browser with different browser proxy configuration. I can see that the instance starts with the mentioned proxy in capabilities but it doesn't use the given proxy. Any help is appreciated

authors: CAPie azimmalik mighty98 smokkapa tymfear


text:
TypeError: "protractor_1.$ is not a function" when using imports in protractor.conf.ts

Node Version: 10.13.0
Protractor Version: 5.4.1
Operating System: Windows 10 Enterprise v1803
Protractor configuration file:
import { Config, browser } from 'protractor';
import Steps from './utils/steps';

const conf: Config = {
  onPrepare: async function () {
    await browser.driver.manage().window().maximize();
    await Steps.login();
  },

  // ...
  // (skipped some props here)
  // ...

  params: {
    defaultUser: {login : 'my login', password: 'my password'}
  },
  SELENIUM_PROMISE_MANAGER: false,
  framework: 'jasmine',
  capabilities: {
    browserName: 'chrome'
  }
};

exports.config = conf;

After compiling with
  "compilerOptions": {
    "target": "es2017",
    "module": "commonjs",
    "moduleResolution": "node",
  }

and running causes this error:
[12:59:44] E/configParser - Error code: 105
[12:59:44] E/configParser - Error message: failed loading configuration file ./build/protractor.conf.js
[12:59:44] E/configParser - TypeError: protractor_1.$ is not a function

with stacktrace leading to this compiled code
const protractor_1 = require("protractor");
class MyPageObject {
    constructor() {
        this.rootElement = protractor_1.$('.my-selector');
    }
}

(here is original ts code:)
import { $, by, ElementFinder } from 'protractor';

class MyPageObject {
  private rootElement = $('.my-selector');
}

(MyPageObject  is imported in Steps module this way:)
import MyPageObject from '../page-objects/header.po';

If I remove import Steps from './utils/steps'; and place const Steps = require('./utils/steps').default; in onPrepare all works nice. But I spent much time trying to understand this confusing behavior - it definitely should be fixed.

Quick answer...  you should use require since these are global objects and are not built at the time you import.
import Steps from './utils/steps';

export const config: Config = {
  onPrepare: async function () {
    const browser = require('protractor').browser;
    await browser.driver.manage().window().maximize();
    await Steps.login();
    // if steps also relies on element, expected conditions, or browser,
    // you should pass it to the login method. So maybe something like:
    //   const element = require('protractor').element
    //   Steps.login(browser, element);
  },

  // ...
  // (skipped some props here)
  // ...

  params: {
    defaultUser: {login : 'my login', password: 'my password'}
  },
  SELENIUM_PROMISE_MANAGER: false,
  framework: 'jasmine',
  capabilities: {
    browserName: 'chrome'
  }
};

Try this out and let me know how that works out.

As I said earlier, if I change importing step module with require all works nice.
Importing browser itself in config is working for me with import (and thats strange).
Because of such inconsistancy it's look more like a bug then like a feature.

Previously discussed above that this is exactly how this works. The global objects are not created when your config is loaded in the protractor CLI. This does not appear to be a bug but rather how Protractor does things. We have a potential roadmap to fix some of these issues.
So I am closing this issue. Thanks!


text:
feat(typescript): move typescript variable instances from protractor/…

…globals to protractor
Breaking change for TypeScript:
Instead of importing globals like browser from protractor/globals, import from protractor.
Before:
import {browser, element} from 'protractor/globals';
import {ElementFinder} from 'protractor';

describe('my app', () => {
  myElement: ElementFinder;

  beforeEach(() => {
    browser.get('example.com');
    myElement = element(by.css('foo'));
  });
});

After
import {browser, element, ElementFinder} from 'protractor';

describe('my app', () => {
  myElement: ElementFinder;

  beforeEach(() => {
    browser.get('example.com');
    myElement = element(by.css('foo'));
  });
});

Closes #3564

Done! New github review, exciting.

this was a breaking change - why wasn't the major version bumped?
or maybe protractor is not following semver? That's fine of course, but it would be good to know so that I can specify exact version in my devDependencies

Hi @ccrowhurstram. Protractor TypeScript support is still experimental. The breaking change was listed in the changelog.

Thanks for getting back to me.
So @cnishina, aside from the typescript declarations, Protractor is following semver?

Yes. We do follow semver.

OK, thanks

authors: ccrowhurstram cnishina juliemr


text:
Transformer vs CNN based architectures

Hi,
Thanks for uploading the codes for this wonderful project. It can really help us understand and debug the feature space of CLIP.
The model seem to work very well with CNN based CLIP but not as good with ViT architecture?
Is this normal?
Here are my outputs for RN50x16 and ViT-B/32 for the example image in this repo
I'm running both with
topk=300  and  cam_version='gscorecam' and input_text="Heart"

RN50x16
ViT-B/32

Should ViT models work as well? Do they need other settings?

Thank you for your interest. Since the method relies on the channels in CNN, the approach we applied to ViT is not optimal. Here are two ways may get better results on ViT:

Adjust the k. i.e., in ViT-B/32 there are only 768 channels, but in RNx16, there are 3072 channels. So a smaller number k=100 will result in a less noisy output for ViT-B/32.
Use a larger model of ViT variance. e.g., ViT-B/16.

Thanks for the help.
I tried ViT-B/32 with k=100 and didn't get good results. should it be different with ViT-B/16
Also Is there a significant difference between the different ResNet backbones ? I'm using mostly RN50x16

For ViT-B/16, you should have slightly different results but I will expect there are similar.
For the difference in the backbone, in terms of interpretability, RNx4 and RNx16 are similar. But the RNx16 backbone has better performance in terms of prediction.

authors: ArielReplicate Chanfeechen


text:
Timer issue

Per @anilkumarbp :
Line number 100 within my index.js where I am trying to re-call the async method to Active-call API but I get a timer._repeat error.

Below is the error message being provided during operation. The issue doesn't appear to be with the timer, but the fact that call is not defined.
timers.js:270
timer._repeat.call(this);
^
TypeError: Cannot read property 'call' of undefined
at wrapper [as _onTimeout] (timers.js:270:18)
at Timer.listOnTimeout (timers.js:89:15)

My previous thought of "call" being undefined was both correct and incorrect. The real problem is the fact that you're passing in the result of activeCalls() instead of the reference to the activeCalls function. This is because you are including the parenthesis erroneously.
Once you remove the parenthesis it no longer errors. I will submit the PR now.

Fixed.

authors: anilkumarbp bdeanindy

repo: anilkumarbp/Message-Dispatcher

license: mit

license_source: bigquery


text:
[kuduraft] lower verbosity of some log messages

Summary:
High rate rates can cause these log messages to flood. Reducing
verbosity (since we have the ability to increase it dynamically)
Test Plan: CI
Reviewers: arahut
Subscribers:
Tasks:
Tags:

i don't see the StartFollowerTransaction message being reduced.

I thought you handled it by having something like 'expected_rotation_delay' earlier and whatever is remaining is useful. I am not sure if that is the one your are mentioning here. I have gone ahead and removed some similar messages in the latest commit. Let me know if that is the one you are referring to.
I was mainly trying to deal with T86541340 and the one in log index that you mentioned earlier

authors: anirbanr-fb bhatvinay

repo: anirbanr-fb/kuduraft


text:
Add support for generics

This is a breaking change in interface of Porcupine.
This set of commits does:

move state to a generic interface, that must implement Clone, String and Equals
make use of the above methods over the model defined function pointers
use clone before calling step to avoid issues like in #11
use dedicated input/output types for the step function

Note that I'm still looking into refactoring the internal entry's and node'value structure to a union type, this proves to be a little more difficult than anticipated - not sure this is currently even possible with two other generic types in Go.

This is interesting, thanks for taking time to make the changes and submit a PR.
Btw, I don't think we can do much better for the entry and node types. Go's type system doesn't support tagged unions, so we're basically manually implementing tagged unions (e.g., the kind field of the entry is the type tag) there without compile-time checking from the type system.
I see several pros and cons of switching over to using generics.
Pros:

Avoiding any all over the place is nice
Does help people from missing that Step() needs to be purely functional
Less casting required in user code
Performance: runtime benefit of avoiding wrapping in interface values in many places

Cons:

Breaking change to API
Requires Go 1.18 for generics
I don't think the types are really necessary here to provide a usable and safe API
Looks a little messy to have a lot of the functions parameterized by [S, I, O]
Performance: this clones the state everywhere, including for read-only operations, and the user can't opt out of the cloning. Step() is on a hot code path.

I was curious about the performance impacts of the change. Looks like there's no statistically significant difference in performance.
Machine stats:
goos: linux
goarch: amd64
pkg: github.com/anishathalye/porcupine
cpu: Intel(R) Core(TM) i7-5930K CPU @ 3.50GHz

Benchmark results (old = dbc9a3e, new = 4ba1f58).
name              old time/op  new time/op  delta
EtcdJepsen000-12   424µs ± 0%   448µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen001-12   505µs ± 0%   507µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen002-12   223ms ± 0%   223ms ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen003-12   274µs ± 0%   274µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen004-12   155µs ± 0%   149µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen005-12   352µs ± 0%   364µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen006-12   294µs ± 0%   290µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen007-12   185ms ± 0%   182ms ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen008-12   159µs ± 0%   164µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen009-12   231µs ± 0%   231µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen010-12   158µs ± 0%   157µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen011-12   340µs ± 0%   314µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen012-12   158µs ± 0%   154µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen013-12   140µs ± 0%   137µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen014-12   131µs ± 0%   139µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen015-12   249µs ± 0%   254µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen016-12   127µs ± 0%   131µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen017-12   154µs ± 0%   158µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen018-12   850µs ± 0%   842µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen019-12   488µs ± 0%   495µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen020-12   243µs ± 0%   241µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen021-12   150µs ± 0%   148µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen022-12   146µs ± 0%   145µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen023-12   251µs ± 0%   251µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen024-12   228µs ± 0%   217µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen025-12   213µs ± 0%   218µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen026-12   183µs ± 0%   184µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen027-12   193µs ± 0%   192µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen028-12   223µs ± 0%   216µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen029-12   296µs ± 0%   304µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen030-12   153µs ± 0%   151µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen031-12   159µs ± 0%   162µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen032-12   167µs ± 0%   176µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen033-12   201µs ± 0%   200µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen034-12   170µs ± 0%   177µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen035-12   129µs ± 0%   132µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen036-12   157µs ± 0%   155µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen037-12   329µs ± 0%   327µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen038-12   196µs ± 0%   198µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen039-12   192µs ± 0%   193µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen040-12  21.6ms ± 0%  22.8ms ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen041-12   133µs ± 0%   134µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen042-12   212µs ± 0%   199µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen043-12   133µs ± 0%   133µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen044-12   480µs ± 0%   462µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen045-12   160µs ± 0%   157µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen046-12   138µs ± 0%   127µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen047-12   253µs ± 0%   234µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen048-12   245µs ± 0%   235µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen049-12   183µs ± 0%   181µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen050-12   120µs ± 0%   119µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen051-12   309µs ± 0%   325µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen052-12   183µs ± 0%   182µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen053-12  4.15ms ± 0%  4.27ms ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen054-12   156µs ± 0%   165µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen055-12   126µs ± 0%   129µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen056-12   453µs ± 0%   440µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen057-12  93.9ms ± 0%  94.3ms ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen058-12   160µs ± 0%   158µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen059-12   171µs ± 0%   166µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen060-12   244µs ± 0%   237µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen061-12   572µs ± 0%   529µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen062-12   115µs ± 0%   121µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen063-12   245µs ± 0%   251µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen064-12   138µs ± 0%   135µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen065-12   134µs ± 0%   126µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen066-12   199µs ± 0%   190µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen067-12   203µs ± 0%   200µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen068-12   168µs ± 0%   161µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen069-12   128µs ± 0%   123µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen070-12   133µs ± 0%   130µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen071-12   318µs ± 0%   310µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen072-12   143µs ± 0%   144µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen073-12   843µs ± 0%   859µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen074-12   126µs ± 0%   130µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen075-12  40.1ms ± 0%  39.0ms ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen076-12   309µs ± 0%   300µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen077-12   140µs ± 0%   141µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen078-12   161µs ± 0%   154µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen079-12   266µs ± 0%   269µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen080-12  14.5ms ± 0%  15.2ms ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen081-12   146µs ± 0%   142µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen082-12   223µs ± 0%   219µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen083-12   145µs ± 0%   142µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen084-12   213µs ± 0%   212µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen085-12  4.56ms ± 0%  4.71ms ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen086-12   150µs ± 0%   147µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen087-12   326µs ± 0%   323µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen088-12   166µs ± 0%   167µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen089-12   491µs ± 0%   494µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen090-12   129µs ± 0%   131µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen091-12   128µs ± 0%   127µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen092-12   180µs ± 0%   183µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen093-12   179µs ± 0%   177µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen094-12   140µs ± 0%   137µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen096-12   226µs ± 0%   227µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen097-12  4.62ms ± 0%  4.81ms ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen098-12  1.68ms ± 0%  1.65ms ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen099-12  87.6ms ± 0%  89.7ms ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen100-12   201µs ± 0%   201µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen101-12   150µs ± 0%   150µs ± 0%   ~     (p=1.000 n=1+1)
EtcdJepsen102-12   188µs ± 0%   185µs ± 0%   ~     (p=1.000 n=1+1)

Out of curiosity, I added some new tests and benchmarks based on the key/value store data, and using a model with/without partitioning (ee9b49a57b6e3bc7185369ac814506812db43322, 89abd11ef0922e7b7916741b3a19c6016802b762). Still, no difference between baseline and generics:
name                          old time/op  new time/op   delta
Kv1ClientOk-12                 214µs ± 0%    216µs ± 0%   ~     (p=1.000 n=1+1)
Kv1ClientBad-12                106µs ± 0%    107µs ± 0%   ~     (p=1.000 n=1+1)
Kv10ClientsOk-12              1.28ms ± 0%   1.20ms ± 0%   ~     (p=1.000 n=1+1)
Kv10ClientsBad-12              798µs ± 0%    805µs ± 0%   ~     (p=1.000 n=1+1)
Kv50ClientsOk-12               2.73s ± 0%    1.95s ± 0%   ~     (p=1.000 n=1+1)
Kv50ClientsBad-12             13.0ms ± 0%   10.3ms ± 0%   ~     (p=1.000 n=1+1)
KvNoPartition1ClientOk-12      173µs ± 0%    198µs ± 0%   ~     (p=1.000 n=1+1)
KvNoPartition1ClientBad-12    89.2µs ± 0%  102.7µs ± 0%   ~     (p=1.000 n=1+1)
KvNoPartition10ClientsOk-12    90.5s ± 0%    90.8s ± 0%   ~     (p=1.000 n=1+1)
KvNoPartition10ClientsBad-12   63.6s ± 0%    63.9s ± 0%   ~     (p=1.000 n=1+1)

Codecov Report
Base: 88.91% // Head: 88.91% // No change to project coverage :thumbsup:

Coverage data is based on head (89abd11) compared to base (dbc9a3e).
Patch has no changes to coverable lines.

:exclamation: Current head 89abd11 differs from pull request most recent head 4ba1f58. Consider uploading reports for the commit 4ba1f58 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   88.91%   88.91%
=======================================
  Files           5        5
  Lines         397      397
=======================================
  Hits          353      353
  Misses         35       35
  Partials        9        9

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Performance: this clones the state everywhere, including for read-only operations, and the user can't opt out of the cloning. Step() is on a hot code path.
I was curious about the performance impacts of the change.

Yep, that's I think the biggest hit to performance. Did you get a good benchmark result already? I'll run it later when rebasing.

with generics + cloning I get this result during benchmark:
[tjungblu ~/git/porcupine]$ go test -bench=.
goos: linux
goarch: amd64
pkg: github.com/anishathalye/porcupine
cpu: Intel(R) Core(TM) i7-10850H CPU @ 2.70GHz
BenchmarkEtcdJepsen000-12                	    7611	    154228 ns/op
BenchmarkEtcdJepsen001-12                	    6471	    179430 ns/op
BenchmarkEtcdJepsen002-12                	       8	 138026510 ns/op
BenchmarkEtcdJepsen003-12                	   12496	     95324 ns/op
BenchmarkEtcdJepsen004-12                	   22680	     52215 ns/op
BenchmarkEtcdJepsen005-12                	    9228	    126306 ns/op
BenchmarkEtcdJepsen006-12                	   10000	    107107 ns/op
BenchmarkEtcdJepsen007-12                	      10	 104118826 ns/op
BenchmarkEtcdJepsen008-12                	   21064	     55416 ns/op
BenchmarkEtcdJepsen009-12                	   15046	     79194 ns/op
BenchmarkEtcdJepsen010-12                	   21103	     55694 ns/op
BenchmarkEtcdJepsen011-12                	    9590	    117515 ns/op
BenchmarkEtcdJepsen012-12                	   21891	     54962 ns/op
BenchmarkEtcdJepsen013-12                	   25000	     47924 ns/op
BenchmarkEtcdJepsen014-12                	   25164	     47868 ns/op
BenchmarkEtcdJepsen015-12                	   13712	     87286 ns/op
BenchmarkEtcdJepsen016-12                	   26582	     45275 ns/op
BenchmarkEtcdJepsen017-12                	   21217	     54850 ns/op
BenchmarkEtcdJepsen018-12                	    3639	    322313 ns/op
BenchmarkEtcdJepsen019-12                	    6415	    182234 ns/op
BenchmarkEtcdJepsen020-12                	   14518	     82989 ns/op
BenchmarkEtcdJepsen021-12                	   22771	     52402 ns/op
BenchmarkEtcdJepsen022-12                	   23563	     50714 ns/op
BenchmarkEtcdJepsen023-12                	   13212	     89566 ns/op
BenchmarkEtcdJepsen024-12                	   14892	     80045 ns/op
BenchmarkEtcdJepsen025-12                	   16310	     73551 ns/op
BenchmarkEtcdJepsen026-12                	   18100	     66189 ns/op
BenchmarkEtcdJepsen027-12                	   18091	     66473 ns/op
BenchmarkEtcdJepsen028-12                	   15512	     77294 ns/op
BenchmarkEtcdJepsen029-12                	   10000	    106780 ns/op
BenchmarkEtcdJepsen030-12                	   22758	     52540 ns/op
BenchmarkEtcdJepsen031-12                	   21336	     55081 ns/op
BenchmarkEtcdJepsen032-12                	   20001	     59654 ns/op
BenchmarkEtcdJepsen033-12                	   16902	     70416 ns/op
BenchmarkEtcdJepsen034-12                	   19320	     61030 ns/op
BenchmarkEtcdJepsen035-12                	   25983	     44849 ns/op
BenchmarkEtcdJepsen036-12                	   22165	     53874 ns/op
BenchmarkEtcdJepsen037-12                	    9517	    115315 ns/op
BenchmarkEtcdJepsen038-12                	   17614	     68006 ns/op
BenchmarkEtcdJepsen039-12                	   17308	     68641 ns/op
BenchmarkEtcdJepsen040-12                	     100	  11235089 ns/op
BenchmarkEtcdJepsen041-12                	   25473	     47495 ns/op
BenchmarkEtcdJepsen042-12                	   16749	     71554 ns/op
BenchmarkEtcdJepsen043-12                	   24715	     47437 ns/op
BenchmarkEtcdJepsen044-12                	    6534	    176419 ns/op
BenchmarkEtcdJepsen045-12                	   21561	     54368 ns/op
BenchmarkEtcdJepsen046-12                	   25580	     47000 ns/op
BenchmarkEtcdJepsen047-12                	   13279	     88036 ns/op
BenchmarkEtcdJepsen048-12                	   14026	     83879 ns/op
BenchmarkEtcdJepsen049-12                	   18512	     61101 ns/op
BenchmarkEtcdJepsen050-12                	   27260	     42176 ns/op
BenchmarkEtcdJepsen051-12                	   10000	    108956 ns/op
BenchmarkEtcdJepsen052-12                	   18516	     64884 ns/op
BenchmarkEtcdJepsen053-12                	     656	   1835090 ns/op
BenchmarkEtcdJepsen054-12                	   20872	     57475 ns/op
BenchmarkEtcdJepsen055-12                	   25448	     47953 ns/op
BenchmarkEtcdJepsen056-12                	    7468	    158692 ns/op
BenchmarkEtcdJepsen057-12                	      25	  47338622 ns/op
BenchmarkEtcdJepsen058-12                	   20349	     57993 ns/op
BenchmarkEtcdJepsen059-12                	   19863	     58988 ns/op
BenchmarkEtcdJepsen060-12                	   13550	     86544 ns/op
BenchmarkEtcdJepsen061-12                	    5623	    205958 ns/op
BenchmarkEtcdJepsen062-12                	   27967	     41413 ns/op
BenchmarkEtcdJepsen063-12                	   13471	     87956 ns/op
BenchmarkEtcdJepsen064-12                	   24298	     48822 ns/op
BenchmarkEtcdJepsen065-12                	   25599	     45512 ns/op
BenchmarkEtcdJepsen066-12                	   16582	     70682 ns/op
BenchmarkEtcdJepsen067-12                	   16506	     71487 ns/op
BenchmarkEtcdJepsen068-12                	   20253	     58336 ns/op
BenchmarkEtcdJepsen069-12                	   27112	     44054 ns/op
BenchmarkEtcdJepsen070-12                	   24738	     46500 ns/op
BenchmarkEtcdJepsen071-12                	    9884	    119218 ns/op
BenchmarkEtcdJepsen072-12                	   22594	     50805 ns/op
BenchmarkEtcdJepsen073-12                	    3573	    327610 ns/op
BenchmarkEtcdJepsen074-12                	   25024	     45408 ns/op
BenchmarkEtcdJepsen075-12                	      84	  18373545 ns/op
BenchmarkEtcdJepsen076-12                	    9526	    110632 ns/op
BenchmarkEtcdJepsen077-12                	   23404	     49780 ns/op
BenchmarkEtcdJepsen078-12                	   21534	     55234 ns/op
BenchmarkEtcdJepsen079-12                	   12343	     96121 ns/op
BenchmarkEtcdJepsen080-12                	     120	   8516945 ns/op
BenchmarkEtcdJepsen081-12                	   23493	     49993 ns/op
BenchmarkEtcdJepsen082-12                	   15022	     79342 ns/op
BenchmarkEtcdJepsen083-12                	   22051	     51185 ns/op
BenchmarkEtcdJepsen084-12                	   14858	     77912 ns/op
BenchmarkEtcdJepsen085-12                	     536	   2311770 ns/op
BenchmarkEtcdJepsen086-12                	   20421	     53140 ns/op
BenchmarkEtcdJepsen087-12                	    9985	    116445 ns/op
BenchmarkEtcdJepsen088-12                	   20083	     59546 ns/op
BenchmarkEtcdJepsen089-12                	    6096	    184166 ns/op
BenchmarkEtcdJepsen090-12                	   24470	     46214 ns/op
BenchmarkEtcdJepsen091-12                	   25959	     45591 ns/op
BenchmarkEtcdJepsen092-12                	   17664	     64189 ns/op
BenchmarkEtcdJepsen093-12                	   18384	     63832 ns/op
BenchmarkEtcdJepsen094-12                	   24430	     49212 ns/op
BenchmarkEtcdJepsen096-12                	   14526	     80741 ns/op
BenchmarkEtcdJepsen097-12                	     505	   3390716 ns/op
BenchmarkEtcdJepsen098-12                	    1258	    910393 ns/op
BenchmarkEtcdJepsen099-12                	      24	  45894619 ns/op
BenchmarkEtcdJepsen100-12                	   16342	     72108 ns/op
BenchmarkEtcdJepsen101-12                	   21724	     54353 ns/op
BenchmarkEtcdJepsen102-12                	   18318	     64637 ns/op
BenchmarkKv1ClientOk-12                  	   15024	     80223 ns/op
BenchmarkKv1ClientBad-12                 	   28113	     41833 ns/op
BenchmarkKv10ClientsOk-12                	    2353	    488401 ns/op
BenchmarkKv10ClientsBad-12               	    3513	    306512 ns/op
BenchmarkKv50ClientsOk-12                	       1	1962944648 ns/op
BenchmarkKv50ClientsBad-12               	     132	   9128606 ns/op
BenchmarkKvNoPartition1ClientOk-12       	   15723	     72423 ns/op
BenchmarkKvNoPartition1ClientBad-12      	   32005	     35866 ns/op
BenchmarkKvNoPartition10ClientsOk-12     	       1	79796681374 ns/op
BenchmarkKvNoPartition10ClientsBad-12    	       1	58994525165 ns/op
PASS
ok  	github.com/anishathalye/porcupine	465.842s

running without generics+clone against HEAD:
[tjungblu ~/git/porcupine]$ git checkout master
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
[tjungblu ~/git/porcupine]$ go test -bench=.
goos: linux
goarch: amd64
pkg: github.com/anishathalye/porcupine
cpu: Intel(R) Core(TM) i7-10850H CPU @ 2.70GHz
BenchmarkEtcdJepsen000-12                	    6806	    174720 ns/op
BenchmarkEtcdJepsen001-12                	    5600	    200467 ns/op
BenchmarkEtcdJepsen002-12                	       7	 159233892 ns/op
BenchmarkEtcdJepsen003-12                	   11523	    102624 ns/op
BenchmarkEtcdJepsen004-12                	   22036	     53777 ns/op
BenchmarkEtcdJepsen005-12                	    8048	    137161 ns/op
BenchmarkEtcdJepsen006-12                	    9565	    119189 ns/op
BenchmarkEtcdJepsen007-12                	       9	 126387594 ns/op
BenchmarkEtcdJepsen008-12                	   20235	     58051 ns/op
BenchmarkEtcdJepsen009-12                	   13992	     85593 ns/op
BenchmarkEtcdJepsen010-12                	   20340	     59601 ns/op
BenchmarkEtcdJepsen011-12                	    8718	    128595 ns/op
BenchmarkEtcdJepsen012-12                	   20226	     58211 ns/op
BenchmarkEtcdJepsen013-12                	   23277	     49586 ns/op
BenchmarkEtcdJepsen014-12                	   24174	     49759 ns/op
BenchmarkEtcdJepsen015-12                	   12494	     96040 ns/op
BenchmarkEtcdJepsen016-12                	   24603	     48148 ns/op
BenchmarkEtcdJepsen017-12                	   20335	     57908 ns/op
BenchmarkEtcdJepsen018-12                	    3069	    372889 ns/op
BenchmarkEtcdJepsen019-12                	    5556	    206739 ns/op
BenchmarkEtcdJepsen020-12                	   13591	     88263 ns/op
BenchmarkEtcdJepsen021-12                	   21672	     54756 ns/op
BenchmarkEtcdJepsen022-12                	   22356	     52863 ns/op
BenchmarkEtcdJepsen023-12                	   12242	     97194 ns/op
BenchmarkEtcdJepsen024-12                	   14071	     85636 ns/op
BenchmarkEtcdJepsen025-12                	   15223	     77863 ns/op
BenchmarkEtcdJepsen026-12                	   17055	     70798 ns/op
BenchmarkEtcdJepsen027-12                	   16816	     70421 ns/op
BenchmarkEtcdJepsen028-12                	   14240	     81510 ns/op
BenchmarkEtcdJepsen029-12                	   10000	    119620 ns/op
BenchmarkEtcdJepsen030-12                	   21470	     53987 ns/op
BenchmarkEtcdJepsen031-12                	   19810	     57778 ns/op
BenchmarkEtcdJepsen032-12                	   19274	     63554 ns/op
BenchmarkEtcdJepsen033-12                	   15351	     75059 ns/op
BenchmarkEtcdJepsen034-12                	   18454	     64449 ns/op
BenchmarkEtcdJepsen035-12                	   25704	     46329 ns/op
BenchmarkEtcdJepsen036-12                	   20842	     56437 ns/op
BenchmarkEtcdJepsen037-12                	    8422	    126022 ns/op
BenchmarkEtcdJepsen038-12                	   16405	     70970 ns/op
BenchmarkEtcdJepsen039-12                	   16014	     73496 ns/op
BenchmarkEtcdJepsen040-12                	     100	  16844876 ns/op
BenchmarkEtcdJepsen041-12                	   24350	     49907 ns/op
BenchmarkEtcdJepsen042-12                	   15394	     76643 ns/op
BenchmarkEtcdJepsen043-12                	   24499	     48435 ns/op
BenchmarkEtcdJepsen044-12                	    5841	    195299 ns/op
BenchmarkEtcdJepsen045-12                	   20090	     57753 ns/op
BenchmarkEtcdJepsen046-12                	   23960	     48724 ns/op
BenchmarkEtcdJepsen047-12                	   12384	     94894 ns/op
BenchmarkEtcdJepsen048-12                	   13066	     90959 ns/op
BenchmarkEtcdJepsen049-12                	   18261	     62960 ns/op
BenchmarkEtcdJepsen050-12                	   27040	     44512 ns/op
BenchmarkEtcdJepsen051-12                	    9528	    121177 ns/op
BenchmarkEtcdJepsen052-12                	   17684	     67249 ns/op
BenchmarkEtcdJepsen053-12                	     460	   3926419 ns/op
BenchmarkEtcdJepsen054-12                	   19845	     59952 ns/op
BenchmarkEtcdJepsen055-12                	   23581	     47844 ns/op
BenchmarkEtcdJepsen056-12                	    6376	    177133 ns/op
BenchmarkEtcdJepsen057-12                	      21	  54128171 ns/op
BenchmarkEtcdJepsen058-12                	   19548	     58339 ns/op
BenchmarkEtcdJepsen059-12                	   18544	     63552 ns/op
BenchmarkEtcdJepsen060-12                	   12715	     93762 ns/op
BenchmarkEtcdJepsen061-12                	    4947	    232477 ns/op
BenchmarkEtcdJepsen062-12                	   27030	     42662 ns/op
BenchmarkEtcdJepsen063-12                	   12447	     94945 ns/op
BenchmarkEtcdJepsen064-12                	   23318	     49001 ns/op
BenchmarkEtcdJepsen065-12                	   25611	     47431 ns/op
BenchmarkEtcdJepsen066-12                	   15720	     74140 ns/op
BenchmarkEtcdJepsen067-12                	   16033	     73386 ns/op
BenchmarkEtcdJepsen068-12                	   19342	     60291 ns/op
BenchmarkEtcdJepsen069-12                	   25551	     44603 ns/op
BenchmarkEtcdJepsen070-12                	   24691	     48171 ns/op
BenchmarkEtcdJepsen071-12                	    9055	    127755 ns/op
BenchmarkEtcdJepsen072-12                	   22124	     51510 ns/op
BenchmarkEtcdJepsen073-12                	    3112	    394564 ns/op
BenchmarkEtcdJepsen074-12                	   24673	     47502 ns/op
BenchmarkEtcdJepsen075-12                	      72	  23112169 ns/op
BenchmarkEtcdJepsen076-12                	    9828	    118231 ns/op
BenchmarkEtcdJepsen077-12                	   22405	     50657 ns/op
BenchmarkEtcdJepsen078-12                	   20158	     59589 ns/op
BenchmarkEtcdJepsen079-12                	    9596	    105392 ns/op
BenchmarkEtcdJepsen080-12                	     127	   9475676 ns/op
BenchmarkEtcdJepsen081-12                	   22240	     51778 ns/op
BenchmarkEtcdJepsen082-12                	   14163	     84455 ns/op
BenchmarkEtcdJepsen083-12                	   21595	     52745 ns/op
BenchmarkEtcdJepsen084-12                	   14113	     82065 ns/op
BenchmarkEtcdJepsen085-12                	     421	   2686796 ns/op
BenchmarkEtcdJepsen086-12                	   21433	     54841 ns/op
BenchmarkEtcdJepsen087-12                	    8659	    125963 ns/op
BenchmarkEtcdJepsen088-12                	   18688	     61663 ns/op
BenchmarkEtcdJepsen089-12                	    5787	    203212 ns/op
BenchmarkEtcdJepsen090-12                	   24625	     46056 ns/op
BenchmarkEtcdJepsen091-12                	   25699	     46685 ns/op
BenchmarkEtcdJepsen092-12                	   17310	     66841 ns/op
BenchmarkEtcdJepsen093-12                	   17740	     66898 ns/op
BenchmarkEtcdJepsen094-12                	   22806	     51073 ns/op
BenchmarkEtcdJepsen096-12                	   13752	     85785 ns/op
BenchmarkEtcdJepsen097-12                	     547	   2655552 ns/op
BenchmarkEtcdJepsen098-12                	    1506	    884517 ns/op
BenchmarkEtcdJepsen099-12                	      22	  50767022 ns/op
BenchmarkEtcdJepsen100-12                	   15799	     75863 ns/op
BenchmarkEtcdJepsen101-12                	   20796	     55467 ns/op
BenchmarkEtcdJepsen102-12                	   17764	     66800 ns/op
BenchmarkKv1ClientOk-12                  	   14942	     80575 ns/op
BenchmarkKv1ClientBad-12                 	   28414	     38036 ns/op
BenchmarkKv10ClientsOk-12                	    2504	    489597 ns/op
BenchmarkKv10ClientsBad-12               	    3240	    310970 ns/op
BenchmarkKv50ClientsOk-12                	       1	2895008532 ns/op
BenchmarkKv50ClientsBad-12               	     100	  11290136 ns/op
BenchmarkKvNoPartition1ClientOk-12       	   18163	     63732 ns/op
BenchmarkKvNoPartition1ClientBad-12      	   36255	     33009 ns/op
BenchmarkKvNoPartition10ClientsOk-12     	       1	77089491571 ns/op
BenchmarkKvNoPartition10ClientsBad-12    	       1	56238356959 ns/op
PASS
ok  	github.com/anishathalye/porcupine	458.314s

also running 1.19.3:
[tjungblu ~/git/porcupine]$ go version
go version go1.19.3 linux/amd64

On the no partition KV tests it's slightly slower:

The partitioned ones are faster for the most part:

On Jepsen it's consistently faster:

sorry, I had to split the charts up as the many benchmarks became unwieldy.

running the generics without the cloning on the kv benchmarks

Test
generics ns/op
master ns/op
generics w/o clone ns/op

BenchmarkKvNoPartition1ClientBad-12
35866
33009
29800

BenchmarkKv1ClientBad-12
41833
38036
41479

BenchmarkKvNoPartition1ClientOk-12
72423
63732
58706

BenchmarkKv1ClientOk-12
80223
80575
79227

BenchmarkKv10ClientsBad-12
306512
310970
302989

BenchmarkKv10ClientsOk-12
488401
489597
483574

BenchmarkKv50ClientsBad-12
9128606
11290136
8914428

BenchmarkKv50ClientsOk-12
1962944648
2895008532
1968358789

BenchmarkKvNoPartition10ClientsBad-12
58994525165
56238356959
56662378632

BenchmarkKvNoPartition10ClientsOk-12
79796681374
77089491571
77982079434

Running 20x each, here are the benchstat results:
name                          old time/op  new time/op  delta
EtcdJepsen000-12               441µs ± 4%   396µs ± 4%  -10.29%  (p=0.000 n=18+19)
EtcdJepsen001-12               500µs ± 6%   447µs ± 6%  -10.71%  (p=0.000 n=20+19)
EtcdJepsen002-12               225ms ± 3%   202ms ± 3%  -10.30%  (p=0.000 n=20+19)
EtcdJepsen003-12               270µs ± 4%   248µs ± 4%   -8.15%  (p=0.000 n=20+20)
EtcdJepsen004-12               150µs ± 5%   147µs ± 3%   -2.20%  (p=0.001 n=20+18)
EtcdJepsen005-12               357µs ± 6%   338µs ± 6%   -5.36%  (p=0.000 n=20+20)
EtcdJepsen006-12               303µs ± 6%   283µs ± 4%   -6.60%  (p=0.000 n=20+20)
EtcdJepsen007-12               180ms ± 3%   166ms ± 4%   -7.58%  (p=0.000 n=20+20)
EtcdJepsen008-12               161µs ± 3%   154µs ± 3%   -4.67%  (p=0.000 n=20+20)
EtcdJepsen009-12               227µs ± 5%   219µs ± 5%   -3.57%  (p=0.000 n=20+20)
EtcdJepsen010-12               162µs ± 4%   158µs ± 4%   -2.53%  (p=0.000 n=20+20)
EtcdJepsen011-12               340µs ± 5%   311µs ± 5%   -8.66%  (p=0.000 n=20+20)
EtcdJepsen012-12               162µs ± 5%   154µs ± 4%   -4.94%  (p=0.000 n=20+19)
EtcdJepsen013-12               139µs ± 3%   133µs ± 4%   -4.63%  (p=0.000 n=18+20)
EtcdJepsen014-12               139µs ± 4%   135µs ± 4%   -2.98%  (p=0.000 n=20+20)
EtcdJepsen015-12               253µs ± 3%   234µs ± 4%   -7.22%  (p=0.000 n=19+19)
EtcdJepsen016-12               133µs ± 3%   131µs ± 4%   -1.73%  (p=0.002 n=19+20)
EtcdJepsen017-12               159µs ± 4%   153µs ± 4%   -3.70%  (p=0.000 n=20+20)
EtcdJepsen018-12               871µs ± 4%   780µs ± 9%  -10.49%  (p=0.000 n=20+20)
EtcdJepsen019-12               498µs ± 6%   458µs ± 4%   -8.05%  (p=0.000 n=20+18)
EtcdJepsen020-12               235µs ± 6%   224µs ± 5%   -4.50%  (p=0.000 n=20+20)
EtcdJepsen021-12               155µs ± 6%   151µs ± 4%   -2.18%  (p=0.010 n=20+20)
EtcdJepsen022-12               146µs ± 5%   142µs ± 4%   -2.97%  (p=0.000 n=18+20)
EtcdJepsen023-12               255µs ± 4%   237µs ± 4%   -6.91%  (p=0.000 n=18+20)
EtcdJepsen024-12               226µs ± 4%   217µs ± 3%   -3.70%  (p=0.000 n=19+19)
EtcdJepsen025-12               217µs ± 2%   201µs ± 4%   -7.43%  (p=0.000 n=19+20)
EtcdJepsen026-12               191µs ± 6%   179µs ± 4%   -6.37%  (p=0.000 n=20+20)
EtcdJepsen027-12               194µs ± 4%   185µs ± 3%   -4.30%  (p=0.000 n=20+20)
EtcdJepsen028-12               220µs ± 4%   211µs ± 4%   -4.08%  (p=0.000 n=20+20)
EtcdJepsen029-12               312µs ± 5%   290µs ± 5%   -7.00%  (p=0.000 n=20+20)
EtcdJepsen030-12               153µs ± 4%   148µs ± 4%   -3.30%  (p=0.000 n=20+20)
EtcdJepsen031-12               164µs ± 3%   153µs ± 4%   -6.39%  (p=0.000 n=19+20)
EtcdJepsen032-12               174µs ± 2%   164µs ± 4%   -5.87%  (p=0.000 n=20+20)
EtcdJepsen033-12               207µs ± 2%   195µs ± 3%   -5.75%  (p=0.000 n=18+20)
EtcdJepsen034-12               175µs ± 5%   167µs ± 3%   -4.61%  (p=0.000 n=19+20)
EtcdJepsen035-12               131µs ± 4%   130µs ± 3%     ~     (p=0.072 n=20+20)
EtcdJepsen036-12               158µs ± 3%   151µs ± 3%   -4.21%  (p=0.000 n=19+20)
EtcdJepsen037-12               330µs ± 5%   303µs ± 4%   -8.26%  (p=0.000 n=20+20)
EtcdJepsen038-12               199µs ± 3%   190µs ± 4%   -4.27%  (p=0.000 n=19+20)
EtcdJepsen039-12               196µs ± 3%   188µs ± 4%   -4.14%  (p=0.000 n=20+19)
EtcdJepsen040-12              23.6ms ± 7%  19.8ms ± 4%  -16.13%  (p=0.000 n=20+20)
EtcdJepsen041-12               139µs ± 4%   134µs ± 4%   -3.15%  (p=0.000 n=19+20)
EtcdJepsen042-12               207µs ± 4%   193µs ± 4%   -6.60%  (p=0.000 n=20+20)
EtcdJepsen043-12               136µs ± 4%   133µs ± 3%   -2.37%  (p=0.000 n=20+18)
EtcdJepsen044-12               472µs ± 6%   436µs ± 7%   -7.63%  (p=0.000 n=19+20)
EtcdJepsen045-12               160µs ± 4%   153µs ± 5%   -4.52%  (p=0.000 n=20+20)
EtcdJepsen046-12               137µs ± 3%   133µs ± 4%   -2.48%  (p=0.000 n=19+20)
EtcdJepsen047-12               247µs ± 4%   233µs ± 4%   -5.79%  (p=0.000 n=20+19)
EtcdJepsen048-12               246µs ± 4%   226µs ± 4%   -7.95%  (p=0.000 n=20+19)
EtcdJepsen049-12               181µs ± 5%   172µs ± 2%   -4.74%  (p=0.000 n=20+17)
EtcdJepsen050-12               126µs ± 6%   124µs ± 3%   -1.23%  (p=0.030 n=20+19)
EtcdJepsen051-12               316µs ± 5%   292µs ± 4%   -7.43%  (p=0.000 n=20+20)
EtcdJepsen052-12               186µs ± 4%   172µs ± 3%   -7.31%  (p=0.000 n=20+19)
EtcdJepsen053-12              4.20ms ± 4%  3.46ms ± 6%  -17.69%  (p=0.000 n=20+19)
EtcdJepsen054-12               170µs ± 3%   161µs ± 4%   -4.83%  (p=0.000 n=19+20)
EtcdJepsen055-12               138µs ± 3%   132µs ± 3%   -3.93%  (p=0.000 n=20+20)
EtcdJepsen056-12               441µs ± 7%   403µs ± 4%   -8.68%  (p=0.000 n=20+19)
EtcdJepsen057-12              96.1ms ± 4%  87.1ms ± 1%   -9.35%  (p=0.000 n=18+16)
EtcdJepsen058-12               166µs ± 5%   159µs ± 5%   -4.28%  (p=0.000 n=20+20)
EtcdJepsen059-12               171µs ± 4%   164µs ± 4%   -3.76%  (p=0.000 n=20+20)
EtcdJepsen060-12               251µs ± 4%   232µs ± 4%   -7.66%  (p=0.000 n=20+20)
EtcdJepsen061-12               555µs ± 4%   500µs ± 5%  -10.00%  (p=0.000 n=20+20)
EtcdJepsen062-12               123µs ± 3%   119µs ± 2%   -3.26%  (p=0.000 n=20+19)
EtcdJepsen063-12               252µs ± 4%   236µs ± 5%   -6.48%  (p=0.000 n=20+20)
EtcdJepsen064-12               142µs ± 3%   137µs ± 4%   -3.49%  (p=0.000 n=19+19)
EtcdJepsen065-12               135µs ± 4%   131µs ± 3%   -2.82%  (p=0.000 n=20+18)
EtcdJepsen066-12               200µs ± 4%   188µs ± 4%   -6.12%  (p=0.000 n=20+19)
EtcdJepsen067-12               206µs ± 3%   193µs ± 4%   -6.25%  (p=0.000 n=20+20)
EtcdJepsen068-12               171µs ± 4%   160µs ± 2%   -6.45%  (p=0.000 n=20+18)
EtcdJepsen069-12               131µs ± 3%   126µs ± 3%   -3.49%  (p=0.000 n=20+20)
EtcdJepsen070-12               137µs ± 3%   133µs ± 5%   -2.87%  (p=0.000 n=20+20)
EtcdJepsen071-12               324µs ± 4%   296µs ± 7%   -8.66%  (p=0.000 n=20+20)
EtcdJepsen072-12               150µs ± 3%   142µs ± 3%   -5.18%  (p=0.000 n=19+20)
EtcdJepsen073-12               876µs ± 4%   772µs ± 5%  -11.92%  (p=0.000 n=20+20)
EtcdJepsen074-12               134µs ± 4%   130µs ± 3%   -2.55%  (p=0.000 n=20+20)
EtcdJepsen075-12              41.3ms ± 3%  35.7ms ± 3%  -13.69%  (p=0.000 n=20+20)
EtcdJepsen076-12               318µs ± 4%   290µs ± 4%   -9.04%  (p=0.000 n=20+20)
EtcdJepsen077-12               145µs ± 3%   138µs ± 4%   -4.76%  (p=0.000 n=19+20)
EtcdJepsen078-12               164µs ± 4%   156µs ± 4%   -5.17%  (p=0.000 n=20+20)
EtcdJepsen079-12               272µs ± 5%   250µs ± 4%   -8.38%  (p=0.000 n=20+20)
EtcdJepsen080-12              15.5ms ± 4%  14.2ms ± 5%   -8.72%  (p=0.000 n=20+20)
EtcdJepsen081-12               148µs ± 3%   141µs ± 3%   -4.70%  (p=0.000 n=20+18)
EtcdJepsen082-12               229µs ± 4%   215µs ± 4%   -6.00%  (p=0.000 n=20+20)
EtcdJepsen083-12               152µs ± 2%   144µs ± 4%   -5.64%  (p=0.000 n=19+20)
EtcdJepsen084-12               223µs ± 5%   211µs ± 4%   -5.33%  (p=0.000 n=20+20)
EtcdJepsen085-12              4.91ms ± 4%  4.33ms ± 5%  -11.95%  (p=0.000 n=20+19)
EtcdJepsen086-12               159µs ± 4%   150µs ± 4%   -5.23%  (p=0.000 n=20+20)
EtcdJepsen087-12               330µs ± 4%   305µs ± 3%   -7.46%  (p=0.000 n=20+20)
EtcdJepsen088-12               171µs ± 4%   161µs ± 4%   -5.55%  (p=0.000 n=20+20)
EtcdJepsen089-12               511µs ± 5%   460µs ± 3%   -9.98%  (p=0.000 n=20+19)
EtcdJepsen090-12               135µs ± 3%   132µs ± 3%   -2.91%  (p=0.000 n=20+20)
EtcdJepsen091-12               132µs ± 4%   129µs ± 5%   -2.55%  (p=0.000 n=20+20)
EtcdJepsen092-12               191µs ± 4%   181µs ± 4%   -4.92%  (p=0.000 n=19+20)
EtcdJepsen093-12               184µs ± 4%   173µs ± 4%   -6.03%  (p=0.000 n=20+20)
EtcdJepsen094-12               143µs ± 3%   138µs ± 4%   -3.38%  (p=0.000 n=19+18)
EtcdJepsen096-12               233µs ± 3%   218µs ± 2%   -6.55%  (p=0.000 n=20+19)
EtcdJepsen097-12              4.75ms ± 6%  4.39ms ± 5%   -7.46%  (p=0.000 n=20+20)
EtcdJepsen098-12              1.73ms ± 4%  1.56ms ± 4%   -9.40%  (p=0.000 n=20+20)
EtcdJepsen099-12              89.1ms ± 4%  83.1ms ± 4%   -6.76%  (p=0.000 n=20+20)
EtcdJepsen100-12               206µs ± 5%   196µs ± 4%   -5.17%  (p=0.000 n=20+19)
EtcdJepsen101-12               157µs ± 4%   149µs ± 3%   -5.12%  (p=0.000 n=20+20)
EtcdJepsen102-12               194µs ± 3%   181µs ± 4%   -6.99%  (p=0.000 n=20+20)
Kv1ClientOk-12                 220µs ± 1%   220µs ± 3%     ~     (p=0.904 n=20+20)
Kv1ClientBad-12                107µs ± 2%   108µs ± 2%     ~     (p=0.060 n=20+20)
Kv10ClientsOk-12              1.25ms ± 2%  1.21ms ± 1%   -2.69%  (p=0.000 n=20+20)
Kv10ClientsBad-12              809µs ± 2%   812µs ± 1%     ~     (p=0.496 n=20+18)
Kv50ClientsOk-12               2.68s ± 2%   1.94s ± 3%  -27.55%  (p=0.000 n=20+19)
Kv50ClientsBad-12             13.3ms ± 2%  10.7ms ± 2%  -19.21%  (p=0.000 n=19+20)
KvNoPartition1ClientOk-12      171µs ± 3%   202µs ± 4%  +18.00%  (p=0.000 n=20+20)
KvNoPartition1ClientBad-12    89.1µs ± 4%  99.7µs ± 2%  +11.89%  (p=0.000 n=20+19)
KvNoPartition10ClientsOk-12    89.9s ± 1%   90.5s ± 1%   +0.66%  (p=0.000 n=20+19)
KvNoPartition10ClientsBad-12   63.2s ± 1%   64.1s ± 0%   +1.34%  (p=0.000 n=20+20)

At a high level, it's not an easy decision just based on benchmarks; what are your thoughts on the other pros/cons?

Let's keep things as-is for now; might revisit this in the future. Thank you for taking the time to submit the PR and discuss!

No worries, I'll maintain the generic changes for the time being in:
https://github.com/tjungblu/porcupine/
just in case somebody else wants to use it.

authors: anishathalye codecov-commenter tjungblu

repo: anishathalye/porcupine


text:
Animevietsub sour e request

Source name
Animevietsub
Source link
https://animevietsub.fun/
Source language
Vietnamese
Other details
18+/nsfw = false
Website fanpage: https://www.facebook.com/animevsub?mibextid=ZbWKwL
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a title with source name.
[X] I have checked that the extension does not already exist on the website extensions list or the app.
[X] I have checked that the extension does not already exist by searching the GitHub repository and verified it does not appear in the code base.
[X] I will fill out all of the requested information in this form.

@Secozzi why do you close this (this web don't have dmca notice) 🥲

We're not adding any new extension, unless they're for self hosted stuff

authors: Karutovn Secozzi

repo: aniyomiorg/aniyomi-extensions


text:
Auto update open-data

Addresses https://github.com/ankaboot-source/leadminer/issues/941 (Issue wasn't transferred to this repo).
The new fetch will happen every day at 8 am.
There are no changes being added to the public-email-providers.json and the associated text file. Just the free, disposable and ISP.
If there are changes that need to be introduced to the that file. I request further clarifications. Thanks.

@baderdean just to be sure. Public and Free emails are not the same right ? if they are, then I should be adding the free emails to that public file (after the filtering is done).

I want it daily please :)

I don't know what is public emails... There is Free Email Provider AND there is Disposable Emails Providers. What do you mean by public emails?

Public are non-free email providers like protonmail

You added an ISP file, don't forget to add them to free emails AND to the README

authors: baderdean medanisjbara

repo: ankaboot-source/open-data


text:
JSON Policy Issue for Encryption

When we try to apply the JSON IAM policy for s3tk, two s3 permissions come back as unrecognized actions: GetEncryptionConfiguration & PutEncryptionConfiguration.
They show as valid on this web page, so not sure why they are not recognized.  http://docs.aws.amazon.com/AmazonS3/latest/dev/using-with-s3-actions.html#using-with-s3-actions-related-to-bucket-subresources

Hey @burgerjeffrey, thanks for reporting 👍  Both permissions work with my account fwiw. Maybe there is an issue somewhere else in the policy.

Cleaning up stale issues (no response)

authors: ankane burgerjeffrey


text:
🛑 Grafana is down

In 06b6e1e, Grafana (https://grafana.mikrotik24.duckdns.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Grafana is back up in b9c3a50 after 42 minutes.


text:
add external-dns for managing public DNS records

https://github.com/k8s-at-home/template-cluster-k3s/pull/288
https://github.com/k8s-at-home/template-cluster-k3s/commit/82d769dffb83dee122861d179db8a7114e7e2571
https://github.com/k8s-at-home/template-cluster-k3s/commit/840450363fe609c597831a95497c18e64104c8fa

done

repo: ankushg/home-cluster


text:
Update Stardust.toml

Description
previous PRs merged:
#1525
#2026
If this is an UPDATE for a previous genesis validator
Checks are made against your net_address. If this has changed since the previous testnet, make sure you provide links of previous prs merged from your previous git username.
Thanks in advance!
Checklist before merging

[x] Only one toml is added in this PR
[x] The file being added is indeed a .toml file
[x] The toml being added is to the correct folder, and only to the correct folder
[x] The eth_hot_key and eth_cold_key are present
[x] The email, discord, elements telegram, and twitter fields are present and valid

Whitespace found in filename. Found filename namada-public-testnet-15/Update Stardust.toml

authors: AngelBlock bengtlofgren

repo: anoma/namada-testnets


text:
Explore if it possible to have the OTC client generate prettier function names

Readability counts, and while we understand that there are limitations when it comes to code generation, we should explore if there are ways to configure the server API so the client side generates more readable names.
OTC client already uses names spaces which breaks things down, however the method names could read better

It is possible to override the names of the generated functions by providing an operation_id flag to the router endpoints. For the sake of readability this is highly encouraged.
Read FastAPI params to see how this configured.
We should provide guidelines in this lab around how to name operations specially with the knowledge that OTC is able to use namespaces which are grouped by tags, which highlights the need for using tags in a more systematic manner.

Review this section of the FastAPI docs to help autogenerate these names
https://fastapi.tiangolo.com/es/advanced/generate-clients/#custom-generate-unique-id-function
at the moment we are doing it by manually providing an operation_id

repo: anomaly/lab-web-client


text:
A problem in Vue project

I putleaderline into my Vue project as per documentation, but its not working

There was a mistake

So how to solve it
thx

Hi @whatthezzzz, thank you for the comment.
LeaderLine doesn't have setLine method.
Document: https://anseki.github.io/leader-line/
You mistook a repository to ask the question, maybe.

No reply came, then this abandoned issue is closed.

authors: anseki whatthezzzz

repo: anseki/leader-line


text:
How to center the leaderline but behind the draggable div?

Hey @anseki First of all I'd like to say that this is one of the most amazing things I've ever used. You've really nailed on this feature and it's working extremely well for me.
However due to the designs which were requested I need to have the line sort of behind the draggable divs raher than on the same level or above. Also it needs to be starting and ending in hte center of draggable div which I've solved.
Any additional input into how lines would have lower Z-index than the draggable divs would be greatly appreciated.
I've tried manually setting z-indexes through inspector but that seems to break everything rather than just show it behind
Thanks again!

Here's a screenshot to perhaps give you a better understanding of what I'm trying to solve. Basically when the white line overlaps yellow circle I just want it to be below it rather than above

Hi @vukic-makro, thank you for the comment.
Was the issue already solved?

authors: anseki vukic-makro

repo: anseki/plain-draggable


text:
bender fails on fedora 31: "failed to resolve remote temporary directory from..."

TASK [Gathering Facts] *********************************************************
fatal: [registry-example-com-ab-test-srxxarcxdask-oldest-20191103-105909811412-cont]: FAILED! => {"msg": "failed to resolve remote temporary directory from ansible-tmp-1572778755.5702844-49702278115452: `( umask 77 && mkdir -p \"` echo /tmp/ansible-tmp-1572778755.5702844-49702278115452 `\" && echo ansible-tmp-1572778755.5702844-49702278115452=\"` echo /tmp/ansible-tmp-1572778755.5702844-49702278115452 `\" )` returned empty string"}
PLAY RECAP *********************************************************************
registry-example-com-ab-test-srxxarcxdask-oldest-20191103-105909811412-cont : ok=0 changed=0 unreachable=0 failed=1 skipped=0 rescued=0 ignored=0

No idea what it means. We probably need ansible-playbook -vvvvvv output to understand the problem better.
(12/20): buildah-1.11.3-2.fc31.x86_64.rpm 8.7 MB/s | 8.3 MB 00:00
(13/20): ansible-2.8.5-1.fc31.noarch.rpm 9.5 MB/s | 13 MB 00:01

I can't reproduce this on Fedora 31, with:
ansible-2.9.2-1.fc31.noarch
ansible-bender-0.7.0-2.fc31.noarch
buildah-1.11.4-2.fc31.x86_64

Bender seems to work just fine with the following playbook:
---
- hosts: all
  vars:
    ansible_bender:
      base_image: registry.fedoraproject.org/fedora:31

      target_image:
        name: myimage
        labels:
          built-by: '{{ ansible_user }}'
        environment:
          FOO: bar
  tasks:
  - dnf:
      name: mc
      state: latest

thanks for letting me know, looking into it right now - hopefully it was just a CI flake

Weird, I can reproduce this issue after all, however only under very specific circumstances. The problem appears when ansible-bender is ran from CI agent (Atlassian Bamboo). If ran directly on the command line, on the same machine, using the same user account, the build succeeds without problems.
The difference is not obvious:
build	08-Apr-2020 18:49:27	TASK [Gathering Facts] *********************************************************
build	08-Apr-2020 18:49:27	task path: /opt/bamboo-agent-home/xml-data/build-dir/LBC-LFPM-JOB1/.container-image-20200408-164925639956-zmlwybkgvm.yaml:1
build	08-Apr-2020 18:49:27	<linker-container-php7-2-fpm-20200408-164915864452-cont> RUN [b'buildah', b'mount', b'--', b'linker-container-php7-2-fpm-20200408-164915864452-cont']
build	08-Apr-2020 18:49:27	<linker-container-php7-2-fpm-20200408-164915864452-cont> RUN [b'buildah', b'run', b'--', b'linker-container-php7-2-fpm-20200408-164915864452-cont', b'/bin/sh', b'-c', b'( umask 77 && mkdir -p "` echo /tmp/ansible-tmp-1586364567.515142-9130494979587 `" && echo ansible-tmp-1586364567.515142-9130494979587="` echo /tmp/ansible-tmp-1586364567.515142-9130494979587 `" ) && sleep 0']
build	08-Apr-2020 18:49:28	<linker-container-php7-2-fpm-20200408-164915864452-cont> RUN [b'buildah', b'umount', b'--', b'linker-container-php7-2-fpm-20200408-164915864452-cont']
build	08-Apr-2020 18:49:28	fatal: [linker-container-php7-2-fpm-20200408-164915864452-cont]: FAILED! => {
build	08-Apr-2020 18:49:28	    "msg": "failed to resolve remote temporary directory from ansible-tmp-1586364567.515142-9130494979587: `( umask 77 && mkdir -p \"` echo /tmp/ansible-tmp-1586364567.515142-9130494979587 `\" && echo ansible-tmp-1586364567.515142-9130494979587=\"` echo /tmp/ansible-tmp-1586364567.515142-9130494979587 `\" )` returned empty string"
build	08-Apr-2020 18:49:28	}
build	08-Apr-2020 18:49:28
build	08-Apr-2020 18:49:28	PLAY RECAP *********************************************************************
build	08-Apr-2020 18:49:28	linker-container-php7-2-fpm-20200408-164915864452-cont : ok=0    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0

vs. the same build from CLI:
TASK [Gathering Facts] *******************************************************************************************************************************************************************
task path: /home/bamboo/linker-container-php-fpm/.container-image-20200408-164826432000-lrjpwordpj.yaml:1
<linker-container-php7-2-fpm-20200408-164815780263-cont> RUN [b'buildah', b'mount', b'--', b'linker-container-php7-2-fpm-20200408-164815780263-cont']
<linker-container-php7-2-fpm-20200408-164815780263-cont> RUN [b'buildah', b'run', b'--', b'linker-container-php7-2-fpm-20200408-164815780263-cont', b'/bin/sh', b'-c', b'( umask 77 && mkdir -p "` echo /tmp/ansible-tmp-1586364508.347285-229114855221218 `" && echo ansible-tmp-1586364508.347285-229114855221218="` echo /tmp/ansible-tmp-1586364508.347285-229114855221218 `" ) && sleep 0']
Using module file /usr/lib/python3.7/site-packages/ansible/modules/system/setup.py
<linker-container-php7-2-fpm-20200408-164815780263-cont> PUT /home/bamboo/.ansible/tmp/ansible-local-15749fv5bggg2/tmp30grah92 TO /tmp/ansible-tmp-1586364508.347285-229114855221218/AnsiballZ_setup.py
(continues building properly)

Any hints on how to debug this further?

I have worked this problem around by running ansible-bender in user's session via systemd-run.

Seems like an issue with user namespaces. You could troubleshoot by playing with buildah (pull, from, mount, run) to check if you get a more meaningful error message.

authors: TomasTomecek rkujawa

repo: ansible-community/ansible-bender


text:
Docker: Add support for platform parameter

Pass platform value from platforms.item to docker_container. Example usage:
driver:
  name: docker
platforms:
  - name: test-01
    image: ...
    pre_build_image: true
    platform: linux/amd64

As suggested in the docker_container documentation, ignore the platform parameter when comparing state.
Addresses issue #94.

@dankow I am no reviewer but I would like to see your feature merged. I recognized, that some checks failed. Please fix following things, to hopefully get your PR merged:

Prepend feature to the title of your PR. Like feature(Docker): Add support for plattform parameter.
It looks like the pipeline enforces Conventional Commits: https://www.conventionalcommits.org/en/v1.0.0/

@ThomasSteinbach Thanks for the hint, I've changed the PR title

@ssbarnea would it be possible to review/merge that PR.
Without that change Molecule actually didn't work on M1 Macs.
Thanks in advance.

This needs fixing, failed even linting.

@ssbarnea - Correct me if I'm wrong, but aren't the linting failures and other failures in completely unrelated parts of the code?

@ssbarnea I have to agree to @dankow , none of the current pull requests passes the checks.
The output of those checks seems to me quite unreleated to the changes in this PR, e.g. linting:
yaml[indentation]: Wrong indentation: expected at least 3
test/gce/scenarios/windows/verify.yml:8

... or in pytests ...
STDERR: ERROR! couldn't resolve module/action 'containers.podman.podman_image'

I don't know if rebasing to main would help. Does it @ssbarnea ?

@ssbarnea I have to agree to @dankow , none of the current pull requests passes the checks. The output of those checks seems to me quite unreleated to the changes in this PR, e.g. linting:
yaml[indentation]: Wrong indentation: expected at least 3
test/gce/scenarios/windows/verify.yml:8

... or in pytests ...
STDERR: ERROR! couldn't resolve module/action 'containers.podman.podman_image'

I don't know if rebasing to main would help. Does it @ssbarnea ?

I can't talk for @ssbarnea who is the maintainer of this project but what I can say:

there are lint errors with main branch: https://github.com/ansible-community/molecule-plugins/pull/101
there are ansible-galaxy timeouts leading to CI failures : https://github.com/ansible-community/community-topics/issues/206

So, imho, the timeouts has to be fixed first, then PR101 tests can be restarted and hopefully this PR merged. Once done, main branch should have CI in green. Then, pending pull requests will have to be rebased and hopefully may be merged if review is fine. Blindly merging PR without CI "because CI is broken" seems really bad practice to me...

@dankow Hi. thanks to some other devs, the CI seems to be on happy side these days. Can you please rebase and check new CI status ?

@ssbarnea - now that the checks all pass, are there any barriers to merging this PR?

authors: ThomasSteinbach apatard dankow ssbarnea

repo: ansible-community/molecule-plugins


text:
Fixed rule 3.5.1.4.

Sometimes the firewalld service won't start because it's masked and causes an
error. This little fix ensures firewalld is unmasked before starting/enabling it.

Thank you for taking the time to raise this PR and providing a solution. Apologies for missing this on the latest release into devel. We will be addressing this in the near future.
As you may have noted we have permissions issues we are currently addressing with the pr workflow. we are hoping this will become more seamless to do this going forward.
uk-bolly

Hello,
This was addressed with the latest release
George

authors: Frzk georgenalen uk-bolly


text:
[POC] pr-checks: add CHANGES or No Issue on check_commit failure

When the check_commit check fails, this reads the PR description and comments to find any AAH references,
when found, creates CHANGES/$number.misc, containing the PR title
when not found, commits an empty commit with the no issue comment
(testing if this works from a pull_requrest action, may need pull_request_target for the push)

Randomly commenting AAH-1106 to try that path.
If that works, only the push is a problem.

repo: ansible/ansible-hub-ui


text:
Plans / timeline to upgrade from using tower-cli to replacement awx?

Thank you for developing this tool.
It would appear that tower-cli has become deprecated in preference for using awx.
Is there plans to update this project, to leverage awx in place of the pre-existing tower-cli dependencies / calls?
If yes, what is the projected timeline?

Hi @inversecow, thank you for your interest in the project.
My team has been winding down the usage of Nagios, and for that reason the upgrade development has slowed down. I do however have a personal interest in this, so I will take a look at what needs to be done, and assess the next steps. Please bare with me a little bit.
Thank you.

So, I took an initial stab at it. The new not-sufficiently-tested code has been pushed to the dev branch. Would you please test and see how it works for you?
The biggest difference is that you need to set up various environment variables to pass the authentication information.
TOWER_HOST=https://tower.example.com
TOWER_USERNAME=admin
TOWER_PASSWORD=password

I will find some time to test it more during the week.

authors: badnetmask inversecow

repo: ansible/tower-nagios-integration


text:
Updata pydata-sphinx-theme.

Update pydata-sphinx-theme to latest version. It should solve https://github.com/pyansys/pymapdl/pull/1167
I do not have write-access to this repo so I had to fork.

CI is failing since link_logo is named now logo, see pydata theme commit. Could you @germa89 update this variable name in the theme.conf file?

@jorgepiloto  I did replace link_logo by logo.link.

Need to investigate the PR labeling issues.

@jorgepiloto do you think you can cut a release in the coming days?

repo: ansys/ansys-sphinx-theme