text:
fetchFromBitbucket: url split in two when there is a space in rev

Issue description
I'm currently writing a derivation for QMapShack:
stdenv.mkDerivation rec {
  name = "QMapShack-${version}";
  version = "1.9.1";

  src = fetchFromBitbucket {
    owner = "maproom";
    repo = "qmapshack";
    rev = "V ${version}";
    sha256 = "1yswdq1s9jjhwb3wfiy3kkiiaqzagw28vjqvl13jxcnmq7y763sr";
  };
}

The important part is that rev = "V 1.9.1" (with a space).
When I try to build this package, two urls are downloaded:
trying https://bitbucket.org/maproom/qmapshack/get/V
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404

trying 1.9.1.tar.gz

I tried to find an error in fetchFromBitbucket, fetchzip and fetchurl but I really have no idea where the url is split in two.

I think urls should be quoted at https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/fetchurl/builder.sh#L85

Then it should also be quoted at line 126.
But I'm not sure if that works fine if there are really multiple urls.
Also, this leads to another error:
trying  https://bitbucket.org/maproom/qmapshack/get/V 1.9.1.tar.gz
curl: (1) Protocol " https" not supported or disabled in libcurl

Because of the line urls2="$urls2 $url" the url now seems to contain a space at the front.
PS: I've been able to circumvent the problem by using rev = "V%20${version}";.

(triage) this is still happening as of now, though the precise example from the first post appears to somehow be cached and one needs to change the hash to see the download attempts.

trivially fixed by replacing pkgs/build-support/fetchbitbucket/default.nix:8 with   url = "https://bitbucket.org/${owner}/${repo}/get/${lib.strings.escapeURL rev}.tar.gz";
however, the original repo seems to no longer exist, so i'm not sure how much merit this has

source: gharchive/issue

authors: Ekleog FRidh dotlambda lolbinarycat

repo: NixOS/nixpkgs

license: MIT

license_type: permissive

license_source: github-api


text:
Build failure: linuxPackages.nvidia_x11

Installation of the NVIDIA-Linux-x86_64-470.239.06 driver through the nixGL is broken.
Steps to reproduce the behavior:
 nix-env -iA nixgl.auto.nixGLNvidia
Build log
error: builder for '/nix/store/skwg6inwprh9wmkvx5vi2rb9y014p8y3-nvidia-x11-470.239.06-nixGL.drv' failed with exit code 127;
       last 11 log lines:
       > Running phase: unpackPhase
       > tail: error writing 'standard output': Broken pipe
       > Creating directory NVIDIA-Linux-x86_64-470.239.06
       > Verifying archive integrity... OK
       > Uncompressing NVIDIA Accelerated Graphics Driver for Linux-x86_64 470.239.06/nix/store/vmm1c1bwzn9s5m8dgcwlviym7n1lkhwm-NVIDIA-Linux-x86_64-470.239.06.run: line 728: /build/makeself.XjK0VJG0/xz: cannot execute: required file not found
       > tail: error writing 'standard output': Broken pipe
       > /nix/store/vmm1c1bwzn9s5m8dgcwlviym7n1lkhwm-NVIDIA-Linux-x86_64-470.239.06.run: line 719: /dev/tty: No such device or address
       >
       > Terminated
       > /nix/store/pxvl01q3az1543jx1vzzj3ap2jkpkhx5-builder.sh: line 6: bsdtar: command not found
       > tail: error writing 'standard output': Broken pipe
       For full logs, run 'nix log /nix/store/skwg6inwprh9wmkvx5vi2rb9y014p8y3-nvidia-x11-470.239.06-nixGL.drv'.
error: 1 dependencies of derivation '/nix/store/rhwjvy67xap07260yh5p0p6qrwbpa3yg-nixGLNvidia-470.239.06.drv' failed to build
error: 1 dependencies of derivation '/nix/store/vgg6m9py1ydn8ddypxbjjbd95ac6fp9p-nixGL.drv' failed to build
error: 1 dependencies of derivation '/nix/store/0ngc4rbxsdkm7r9mkm8sdqz18xvi3qs6-home-manager-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/pyc8vmfvdrjhrvjs07sbwd42sly9gbri-home-manager-generation.drv' failed to build

Additional context
This behavior was probably introduced with 91f99f14ff83b3c reverting this commit fix the issue.
Notify maintainers
@Kiskae
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.5.0-26-generic, Ubuntu, 23.10 (Mantic Minotaur), nobuild`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.19.3`
 - nixpkgs: `/nix/store/vsmj7776ik51zzkyy22ydl00ib2w1rpp-source`

Add a :+1: reaction to issues you find important.

This appears to be a bug in NixGL.
In the following line it overrides using the wrong original parameter: https://github.com/nix-community/nixGL/blob/d709a8abcde5b01db76ca794280745a43c8662be/nixGL.nix#L84

Yes, I forgot, this is the other thing that needed to be fixed, but there is a pending PL for that. But still, it is needed to revert the upper-mentioned commit to installing nixGLNvidia successfully, as it complains that bsdtar is not available.

That commit is required to support drivers that are compressed with zstd, which all the new ones are.
The problem is that NixGL throws away the dependency that provides bsdtar, which causes the issue you're seeing.

nixGL isn't part of this repo, the issue should be opened in the nixGL repo if it's nixGL specific.

@Kiskae thanks for the explanation, I will try to bother them :)

authors: Kiskae eclairevoyant jankrejci


text:
Firefox leaks data

Issue description
By default " Allow Firefox to install and run studies"  is enabled. This should be disabled.

system: "x86_64-linux"
host os: Linux 4.9.61, NixOS, 17.09.2182.7f6f0c49f0 (Hummingbird)
multi-user?: yes
sandbox: no
version: nix-env (Nix) 1.11.15
channels(root): "nixos-17.09.2182.7f6f0c49f0"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs

Nixpkgs follows upstream for this.  Each user can easily set the preference, though not on nix level ATM.  Until there's a consensus against this, I wouldn't touch it.

You are a Dutch entity The NixOS Foundation is a registered non-profit organisation at the Chamber of commerce (Kamer van Koophandel) in Utrecht, The Netherlands. The KvK number is 63520583.  as such you might want to follow upstream, but it would just be against the law.
The Mozilla Corporation is an American entity and doesn't need to abide by those rules.

First, I'm no lawyer.  The relation to the foundation is rather loose, I believe, but the infrastructure will be mostly in the EU anyway (and nixpkgs did e.g. turn a blind eye on some software patents).  @williammpratt: can you provide some (trustworthy) reference claiming that the Firefox default is against EU law?

@vcunat See https://www.whitecase.com/publications/article/chapter-8-consent-unlocking-eu-general-data-protection-regulation

Firefox asks the user to consent to contribute statistics, this is not a silent default.

FWIW, the NixOS Foundation has nothing to do with this since it doesn't hold the copyright to NixOS/Nixpkgs and doesn't distribute it.

@orivej They already put the checkmark in by default. That's against the law, even if you then press "OK".
@edolstra Please forward this to the legal entity controlling cache.nixos.org then.

Since "Allow Nightly to send technical and interaction data to Mozilla" is unchecked and disabled in our Firefox builds, it is not clear that the enabled "Allow Firefox to install and run studies" will send Mozilla any data (that will not be sent when it is disabled), at least without your permission. Here is the description of this feature:

Shield Studies allow us to give newly graduated features from Test Pilot to small representative populations of the Firefox Release audience. These users will get a chance to use these features for a period of time and then be asked to provide feedback on the experience.

Your unsubstantiated claim that "Firefox leaks data" due to this feature seems groundless.

@orivej
Shield Studies can only collect Type 1 and 2 data. This is the same type of basic interaction data we collect by default as stated in our privacy policy.
Read their privacy policy and you will see what I mean. GDPR regulations are much stricter than you probably imagine.

Indeed, but GDPR "shall apply from 25 May 2018", and Mozilla will release a compliant Firefox by that time. (If it is not compliant now: I can't judge yet.) Here they say:

Any business that markets goods or services to users in the EU will be subject to compliance, regardless of whether their business is located in the EU.
We will continue to track the implications of the GDPR over the next 24 months as it comes into force, and will stay engaged with any opportunities to work out the final details.

Seems sufficient to me, thank you @orivej.

authors: edolstra grahamc orivej vcunat williammpratt


text:
Wallpaper previously working via "services.xserver.desktopManager.wallpaper.mode" quit working after update.

Describe the bug
Though the associated feh command works fine in the terminal, this option has stopped working despite no changed to the wallpaper was made. If I manually set it, the wallpaper requires manual setting again upon reboot.
I have talked to other users who can no longer get this option to work either. This issue persists on all three machines that I manage.
https://github.com/NixOS/nixpkgs/commits/nixos-24.05/nixos/modules/services/x11/desktop-managers/default.nix
Steps To Reproduce
Steps to reproduce the behavior:

... Reboot
...
...

Expected behavior
Wallpaper to display as it did previously.
Notify maintainers
@jtojnar

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
- system: `"x86_64-linux"`
- host os: `Linux 6.6.36, NixOS, 24.11 (Vicuna), 24.11.20240629.2741b4b`
- multi-user?: `yes`
- sandbox: `yes`
- version: `nix-env (Nix) 2.18.4`
- channels(root): `"nixos"`
- nixpkgs: `/nix/store/g83ji892byw4wd81rmb14v69yrhq408s-source`

Add a :+1: reaction to issues you find important.

What desktop environment do you use?
Personally, I would just remove the option as I think it is a hack that does not compose well with different DEs, resulting in issues like this.

Thank you for your reply.
I use Qtile. This option was working great on all three computers for my whole time on NixOS until a recent update. I can fix it in a variety of ways, of course, but wanted to do it "the Nix-way."
I think we should either make the option reliable or depreciate the option. Or, at a minimum, make a note in the documentation to its limited-use cases and maybe link to another method.
Thanks again. I hope to learn enough that someday I can understand the inner workings sufficiently that I could efficiently diagnose what the cause it and assess what it would take to fix it.

I vaguely recall someone saying years ago that feh works by drawing in the X server root window. So if anything does that for whatever reason too, the background will be overwritten.
I would recommend preferring DE/WM-native way of setting wallpaper when available since if the above is true, feh is inherently unreliable.
I found this for Qtile: https://old.reddit.com/r/Ubuntu/comments/jv0v3d/comment/hj719oc/

I would recommend preferring DE/WM-native way of setting wallpaper when available since if the above is true, feh is inherently unreliable.

I went with your recommendation and integrated the wallpaper with Qtile directly.
Thank you.
I still think a note or depreciation of the option could be in order.
Thanks again.

I still think a note or depreciation of the option could be in order.

That would be nice but we would probably want to plan a removal and I am not aware of anyone maintaining the xserver module. Plasma already stopped using it and I am hoping to do the same for GNOME as soon as I can.


text:
gnome missing 'gnome-backgrounds' attribute, won't rebuild

i recently tried switching to gnome, but every time i try rebuilding it gives me this error. i'm using nixos 24.05
error:
       … while calling the 'head' builtin
         at /nix/store/65xpqkz92d9j7k5ric4z8lzhiigxsfbg-source/lib/attrsets.nix:1575:11:
         1574|         || pred here (elemAt values 1) (head values) then
         1575|           head values
             |           ^
         1576|         else

       … while evaluating the attribute 'value'
         at /nix/store/65xpqkz92d9j7k5ric4z8lzhiigxsfbg-source/lib/modules.nix:809:9:
          808|     in warnDeprecation opt //
          809|       { value = builtins.addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          810|         inherit (res.defsFinal') highestPrio;

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: attribute 'gnome-backgrounds' missing
       at /nix/store/7p57v4aafms3zb90xrsblcaiww307kv2-modules/gnome/nixos.nix:22:43:
           21|     # which will then download the pack regardless of its exclusion below.
           22|     environment.gnome.excludePackages = [ pkgs.gnome-backgrounds ];

If you're on 24.05, gnome-backgrounds is still under the gnome package set.

As mentioned above, on 24.05 you need
environment.gnome.excludePackages = [ pkgs.gnome.gnome-backgrounds ];

on 24.11 or later it was moved:
environment.gnome.excludePackages = [ pkgs.gnome-backgrounds ];

authors: jtojnar pancaek zjw1d6gv2


text:
ibus no longer works in firefox or chromium with gnome 3.28

Issue description
It looks like ibus just needs to be built with a newer GLib version:
❯ chromium
'g_io_module_load': /nix/store/d4hnvv8n1ywpa0n8wlcxh8sxsg74waw2-glib-networking-2.56.0/lib/gio/modules/libgiognomeproxy.so: undefined symbol: g_io_module_load
Failed to load module: /nix/store/d4hnvv8n1ywpa0n8wlcxh8sxsg74waw2-glib-networking-2.56.0/lib/gio/modules/libgiognomeproxy.so
'g_io_module_load': /nix/store/d4hnvv8n1ywpa0n8wlcxh8sxsg74waw2-glib-networking-2.56.0/lib/gio/modules/libgiognutls.so: undefined symbol: g_io_module_load
Failed to load module: /nix/store/d4hnvv8n1ywpa0n8wlcxh8sxsg74waw2-glib-networking-2.56.0/lib/gio/modules/libgiognutls.so
'g_io_module_load': /nix/store/d4hnvv8n1ywpa0n8wlcxh8sxsg74waw2-glib-networking-2.56.0/lib/gio/modules/libgiolibproxy.so: undefined symbol: g_io_module_load
Failed to load module: /nix/store/d4hnvv8n1ywpa0n8wlcxh8sxsg74waw2-glib-networking-2.56.0/lib/gio/modules/libgiolibproxy.so
[2526:2598:0326/211404.408130:ERROR:nss_util.cc(724)] After loading Root Certs, loaded==false: NSS error code: -8018

(chromium:2526): Gtk-WARNING **: GModule (/nix/store/7ivgy5mpqy7ds81ca5bdd4nfh6fbnrgx-ibus-with-plugins-1.5.17/lib/gtk-3.0/3.0.0/immodules/im-ibus.so) initialization check failed: GLib version too old (micro mismatch)

(chromium:2526): Gtk-WARNING **: Loading IM context type 'ibus' failed

❯ firefox --no-remote -P
'g_io_module_load': /nix/store/d4hnvv8n1ywpa0n8wlcxh8sxsg74waw2-glib-networking-2.56.0/lib/gio/modules/libgiognomeproxy.so: undefined symbol: g_io_module_load
Failed to load module: /nix/store/d4hnvv8n1ywpa0n8wlcxh8sxsg74waw2-glib-networking-2.56.0/lib/gio/modules/libgiognomeproxy.so
'g_io_module_load': /nix/store/d4hnvv8n1ywpa0n8wlcxh8sxsg74waw2-glib-networking-2.56.0/lib/gio/modules/libgiognutls.so: undefined symbol: g_io_module_load
Failed to load module: /nix/store/d4hnvv8n1ywpa0n8wlcxh8sxsg74waw2-glib-networking-2.56.0/lib/gio/modules/libgiognutls.so
'g_io_module_load': /nix/store/d4hnvv8n1ywpa0n8wlcxh8sxsg74waw2-glib-networking-2.56.0/lib/gio/modules/libgiolibproxy.so: undefined symbol: g_io_module_load
Failed to load module: /nix/store/d4hnvv8n1ywpa0n8wlcxh8sxsg74waw2-glib-networking-2.56.0/lib/gio/modules/libgiolibproxy.so

(firefox:1735): Gtk-WARNING **: GModule (/nix/store/7ivgy5mpqy7ds81ca5bdd4nfh6fbnrgx-ibus-with-plugins-1.5.17/lib/gtk-3.0/3.0.0/immodules/im-ibus.so) initialization check failed: GLib version too old (micro mismatch)

(firefox:1735): Gtk-WARNING **: Loading IM context type 'ibus' failed

(firefox:1735): Gtk-WARNING **: GModule (/nix/store/7ivgy5mpqy7ds81ca5bdd4nfh6fbnrgx-ibus-with-plugins-1.5.17/lib/gtk-3.0/3.0.0/immodules/im-ibus.so) initialization check failed: GLib version too old (micro mismatch)

(firefox:1735): Gtk-WARNING **: Loading IM context type 'ibus' failed

(firefox:1735): Gtk-WARNING **: GModule (/nix/store/7ivgy5mpqy7ds81ca5bdd4nfh6fbnrgx-ibus-with-plugins-1.5.17/lib/gtk-3.0/3.0.0/immodules/im-ibus.so) initialization check failed: GLib version too old (micro mismatch)

(firefox:1735): Gtk-WARNING **: Loading IM context type 'ibus' failed

(firefox:1735): Gtk-WARNING **: GModule (/nix/store/7ivgy5mpqy7ds81ca5bdd4nfh6fbnrgx-ibus-with-plugins-1.5.17/lib/gtk-3.0/3.0.0/immodules/im-ibus.so) initialization check failed: GLib version too old (micro mismatch)

(firefox:1735): Gtk-WARNING **: Loading IM context type 'ibus' failed
JavaScript error: jar:file:///nix/store/s0ziqb204b9xzd18cwngiajybqw4lsns-firefox-unwrapped-58.0.2/lib/firefox-58.0.2/omni.ja!/components/XULStore.js, line 70: Error: Can't find profile directory.

Steps to reproduce
Run Gnome 3.28, try to use mozc in Firefox or Chromium (notice that it works in other GTK apps).
Relevant bits:
i18n.inputMethod = {
  enabled = "ibus";
  ibus.engines = with pkgs.ibus-engines; [ mozc uniemoji ];
};

Technical details

system: "x86_64-linux"
host os: Linux 4.14.29, NixOS, 18.09.git.56fb68dcef4 (Jellyfish)
multi-user?: yes
sandbox: no
version: nix-env (Nix) 2.0
channels(root): ""
nixpkgs: /etc/nixos/lib/nixpkgs

Do you have firefox and chromium installed in your user environment (nix-env)? If so, try updating with nix-env -u. I've had this same problem (with ibus-anthy) after rebuilding my system recently, until I updated my user environment as well.

Is this an instance of #11558?

@ciil I won't be able to check this out for about a fortnight, but I will be sure to try it as soon as I can

@eqyiel

gnome 3.28

I thought in master that's still at 3.26?

Not much to do about environment mismatches.

authors: ciil eqyiel jtojnar laMudri tycho01


text:
nixos-rebuild: detect when nixpkgs needs newer Nix

See: https://twitter.com/theuni/status/557705827994566658
It would be nice if nixos-rebuild would detect that newer Nix is needed and would upgrade automatically.

Can we make nixpkgs depend on nix in a sensible way? :smile: some sort of meta-layer that handles the various nix install scripts stored in a canonical location on nixos.org?

Perhaps a very simple "primop" for referring to a nix package, much like nix-install-package. I was stuck on an old version yesterday, which was a little painful (following https://nixos.org/wiki/How_to_update_when_nix_is_too_old_to_evaluate_nixpkgs#Installing_via_Command_Line).
Then nixpkgs would have a default.nix that says something like:
let
  nix = builtins.fetchNixPackage {
    url         = "http://nixos.org/some/canonical/path/to/1.8/";
    sha256 = "blablablablabalbalbalbabobloblaw";
  };
  # Could also have a builtins.hostNix, if you want a handle to the parent nix
  # for the purposes of testing a prerelease version, etc.
in builtins.evaluateWithNix nix ./pkgs/top-level/all-packages.nix

Then everything is fully self-describing. If you want to run/test a prerelease version, you have a flag that
Is this too weird? Flawed somehow?

nixos-rebuild already installs the latest Nix (and has done so for a long time).

nixos-rebuild evaluate & realize the expression to install the latest Nix, but if it fails to evaluate then we are stuck do have some manual procedure.  Hopefully it is quite simple, but I think it would be nice to have a fallback if an expression cannot be evaluated with the current version of Nix.
I guess we don't have to make a generic solution at the moment, and can have a <nixpkgs/pkgs/top-level/latestNix.drv> which is used by nixos-rebuild.
The problem might be, how to distinguish between a failure caused by a typo, and an updated syntax.  I guess we could use nix-build --version.

@nbp There are several fallbacks, see https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/installer/tools/nixos-rebuild.sh#L155.

Aha fallback needs to be updates, this is now documented as part of release process

authors: copumpkin domenkozar edolstra nbp


text:
nixos services.restya-board: restya-board-init.service failure

Issue description
restya-board-init.service fails when installing service.restya-board using a custom database.name option; this is the service status:
[root@SWboard:~]# sudo systemctl status restya-board-init.service
● restya-board-init.service - Restya board initialization
   Loaded: loaded (/nix/store/bn4ljg4bn631ly2ii5vni3qckl7zwg0r-unit-restya-board-init.service/restya-board-init.service; enabled; vendor preset: enabled)
   Active: failed (Result: exit-code) since Mon 2019-04-15 20:17:01 UTC; 6s ago
  Process: 3561 ExecStart=/nix/store/yzid87chgwsswjlc5q4rvwmmvk9qhlnh-unit-script-restya-board-init-start (code=exited, status=2)
 Main PID: 3561 (code=exited, status=2)

Apr 15 20:16:54 SWboard sudo[3591]:     root : TTY=unknown ; PWD=/ ; USER=postgres ; COMMAND=/nix/store/igsfm3nkiqf0wgrhvi49mgmfc7n1290x-postgresql-9.6.12/bin/psql -U postgres -c CREATE DATABAS>
Apr 15 20:16:54 SWboard sudo[3591]: pam_unix(sudo:session): session opened for user postgres by (uid=0)
Apr 15 20:17:01 SWboard yzid87chgwsswjlc5q4rvwmmvk9qhlnh-unit-script-restya-board-init-start[3561]: CREATE DATABASE
Apr 15 20:17:01 SWboard sudo[3594]:     root : TTY=unknown ; PWD=/ ; USER=restya-board ; COMMAND=/nix/store/igsfm3nkiqf0wgrhvi49mgmfc7n1290x-postgresql-9.6.12/bin/psql -U restya_board -d restya>
Apr 15 20:17:01 SWboard sudo[3594]: pam_unix(sudo:session): session opened for user restya-board by (uid=0)
Apr 15 20:17:01 SWboard yzid87chgwsswjlc5q4rvwmmvk9qhlnh-unit-script-restya-board-init-start[3561]: psql: FATAL:  Peer authentication failed for user "restya_board"
Apr 15 20:17:01 SWboard sudo[3594]: pam_unix(sudo:session): session closed for user restya-board
Apr 15 20:17:01 SWboard systemd[1]: restya-board-init.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Apr 15 20:17:01 SWboard systemd[1]: restya-board-init.service: Failed with result 'exit-code'.
Apr 15 20:17:01 SWboard systemd[1]: Failed to start Restya board initialization.

The issue is caused by the hardcoded database name in postgres.authentication definition: the database name should be  ${cfg.database.name}.
I have not tested it directly but looking at the module source code I'm almost sure this also applies to  database.user and user options.
Steps to reproduce
Use this service declaration:
  services.restya-board = {
       enable = true;
       virtualHost.listenHost = "192.168.200.13";
       virtualHost.serverName = "xtboard.MASKED.TLD";
       database.name = "restya_xtboard";
       timezone = "CET";
  };

Technical details
$ nix-shell -p nix-info --run "nix-info -m"
these paths will be fetched (0.05 MiB download, 0.28 MiB unpacked):
  /nix/store/9z1b1ldrhxh7brsi6fxnyjm7gk8kiynv-bash-interactive-4.4-p23-dev
copying path '/nix/store/9z1b1ldrhxh7brsi6fxnyjm7gk8kiynv-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
 - system: `"x86_64-linux"`
 - host os: `Linux 4.14.104, NixOS, 19.03.172138.5c52b25283a (Koi)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.2`
 - channels(root): `"nixos-19.03.172138.5c52b25283a"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

@gbiscuolo thanks for reporting this. I've never used this service, but I would be willing to take a look and fix this if you were willing to test it for me. Sound good?

Hello Aaron,
Aaron Andersen notifications@github.com writes:

@gbiscuolo thanks for reporting this. I've never used this service,
but I would be willing to take a look and fix this if you were willing
to test it for me. Sound good?

yes! thank you for your offer
In the next couple of weeks I'll be pretty busy, but I should be able to
test later on
I'd also like to learn how to test local defined (i.e. in a git branch)
changes to the packages/services: do you have a pointer to the relevant
documentation please, just a pointer: I'll do my homework :-)
Thanks! Gio'
[...]
--
Giovanni Biscuolo
Xelera IT Infrastructures

@gbiscuolo I've found a few issues. The restya-board package in nixpkgs hasn't been updated in over 2 years. It also looks like the module author has likely moved on, so the module hasn't seen any support or maintenance in the last 2 years either.
Generally at this point if no one is willing to take over maintenance of at least the package we would want to remove this from nixpkgs because this is a web application and we shouldn't have users thinking they are using something up to date and secure when it is actually lagging 7 releases (2 years) behind upstream.
That being said I really don't enjoy removing software from nixpkgs that people are using, or want to use... If you're really keen on using this software on NixOS I suggest we look for a new package/module maintainer. Please let me know if you want to pursue this.

authors: aanderse gbiscuolo


text:
nixos test driver doesn't work with multiple emptyDiskImages

Describe a NixOS VM test that uses emptyDiskImages on more than one VM, and run it via nixosTests.testName.
Observe it works with the perl test driver, but fails with the python test driver.
The python test code shows something like this:
qemu-system-x86_64: -drive file=/build /empty0.qcow2,id=drive2,if=none,index=2,werror=report: Failed to get "write" lock

This seems to be caused due to some differences in passing around environment to the startVM script created in qemu-vm.nix, which causes it to not create the empty$idx.qcow2 images in a per-vm tmpdir, but all in the same location (and by that, trying to use empty0.qcow2 from two different VMs at once.
cc @tfc @Mic92 @worldofpeace

This was fixed in https://github.com/NixOS/nixpkgs/pull/73190/commits/67e20428612e1376d8d62df4c98d34b6af012d10 already.


text:
Composer needs more ram

Describe the bug
Composer needs more ram. With projects with 180 packages it out of ram
Fatal error: Allowed memory size of 1610612736 bytes exhausted (tried to allocate 4096 bytes) in phar:///nix/store/6my0l3i8q6bddp7fky4cpv8wrdkxv6fd-php-composer-1.9.0/libexec/composer/composer.phar/src/Composer/Repository/ComposerRepository.php on line 340
To Reproduce
Have a project with much dependencies
Expected behavior
It works
Screenshots
Additional context
Add any other context about the problem here.
Metadata

system: "x86_64-linux"
host os: Linux 5.3.11, NixOS, 20.03pre201791.c1966522d7d (Markhor)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.1
channels(root): "nixos-20.03pre201791.c1966522d7d"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module: composer

It seems this is unrelated to NixOS and the solution is to buy more RAM

the wrapped php is running with 128m memory_limit

@shyim the solution is to adjust the php.ini file your version of php uses. There are a number of ways to do this. @Ma27 has provided a nice solution for this here, which you can get some more context for here.
Another option which is pretty quick an easy is to place a php.ini file under /etc/php.d, though this will impact all versions of php (include php-fpm and mod_php) which probably is not what you want to do for more than a quick change and revert.

@shyim are we good to close this issue? Any further questions on the topic?

It does not really make sense to me. Why not adding -dmemory_limit=512M or other value here? https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/php-packages.nix#L91
This problem will have also other users when using composer.

Generally we ship upstream defaults instead of imposing our own arbitrary (even if sensible) standards. I use composer on NixOS a fair bit and haven't run into this issue yet.
Maybe @etu, our resident php expert, can share his opinion with us.

I have the same problem here with Drupal. I tried 2 G and 4 G memorylimit, but still the problem. What can I do about it?
composer create-project drupal-composer/drupal-project:8.x-dev aygika
Installing drupal-composer/drupal-project (8.x-dev 04a3fe08d35bfdbdcb9718556fbe8181cd111ff0)

Installing drupal-composer/drupal-project (8.x-dev 04a3fe0): Cloning 04a3fe08d3 from cache
Created project in aygika

DrupalProject\composer\ScriptHandler::checkComposerVersion
Loading composer repositories with package information
Updating dependencies (including require-dev)

Fatal error: Allowed memory size of 1610612736 bytes exhausted (tried to allocate 67108864 bytes) in phar:///nix/store/62y7dpr89kl0lv2znybm0kinip968n7n-php-composer-1.9.0/libexec/composer/composer.phar/src/Composer/DependencyResolver/Solver.php on line 223
Check https://getcomposer.org/doc/articles/troubleshooting.md#memory-limit-errors for more info on how to handle out of memory errors.

Would you mind taking a look at #79377? With this change it would be relatively easy to provide php-packages with different settings (like more allowed RAM).
A quickfix would be to run COMPOSER_MEMORY_LIMIT=-1 composer install.

Thanks a lot, works for me.
Greetz

Since https://github.com/NixOS/nixpkgs/pull/79377 was merged is this considered resolved? I believe it is...

Since #79377 was merged is this considered resolved? I believe it is...

Quite old, sorry, but how does this help? php -i outputs the configured memory limit (2G in my case), but composer still errors with the default limit.

authors: Ma27 aanderse bavramor binarious prusnak shyim


text:
Boot problems for channel 14.12

Hello community,
I ran into some serious ptoblems today that took my many hours to trace and fix.
I changed from the unstable channel to channel 14.12, because I ran into some trouble with some applications (redmine for example). Well after changing it on my server it worked like a charm. So I tried on my laptop. During build my machine freezed. After that It did not boot into Grub. It only showed the Lenovo logo. So I booted into a USB with NixOS 15.06. I changed the channels again from unstable to 14.12, tried a new config and rebooted. No change. After a while I gave up and formated the disk. I repeated, no change. Lastly I did not change to 14.12 and did nix-install.... and its boots again.
So maybe downgrading like this is not intended (even if it worked on my fresh server) or this is some other problem.
I have a Lenovo Y510p, 500g ssd, 1tb hdd, 16g ram.

So maybe downgrading like this is not intended

I did switch back and forth between 14.12 and unstable on a machine without any problems. I would expect that switching is not the problem itself, only some versions may not work on some HW due to driver issues (different kernel version) or other bugs.

You might want to try 14.12 with a newer kernel branch, e.g. 3.18.

Hello vcunat, I already have this kernel branch:
Linux y510p 3.18.20 #1-NixOS SMP Thu Jan 1 00:00:01 UTC 1970 x86_64 GNU/Linux
I am running NixOS 15.08pre67291.42ea0d3 (Dingo) again.

authors: MarkusWotringer vcunat


text:
syncthing can't start because it can't find its binary

Something must have changed upstream because I get this now in my log files:
Failed at step EXEC spawning /nix/store/5s3k9550cai96ixxarbf57yr16xgyzzv-go1.5-syncthing-0.11.22/bin/syncthing: No such file or directory

Building syncthing from master then shows a directory structure as follows (shortened):
result
`-- share
    `-- go
        |-- pkg
        |   `-- linux_amd64
        |       `-- github.com
        |           `-- syncthing
        |               `-- syncthing
        |                   `-- lib
        `-- src
            `-- github.com
                `-- syncthing
                    `-- syncthing
                        |-- [ ... ]
                        [ ... ]

It looks like there's a good chunk of stuff missing. :-/
/cc @ctheune @matejc

Syncthing isn't supposed to build with go 1.5 at this point AFAICT. I didn't do the update to .22 but when I tried to prepare .23 today I noticed that the default changed and started using 1.4 explicitly.
Unfortunately there's other stuff (psutils) broken at the moment for me on OS X so I wasn't able to wrap this up today.

@ctheune No problem, thanks for looking into this!

It's split into two derivations now, you want the bin one. Sorry I didn't
track down all of these cases, anything that uses buildGoPackage is now
autosplit.
On Tue, Sep 1, 2015, 11:12 devhell notifications@github.com wrote:

@ctheune https://github.com/ctheune No problem, thanks for looking into
this!
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/9596#issuecomment-136815617.

@wkennington Sorry, I'm not sure I understand.

pkgs.syncthing.bin contains the syncthing binary, not pkgs.syncthing which
is actually now pkgs.syncthing.dev and contains source and object files.
On Tue, Sep 1, 2015, 11:21 devhell notifications@github.com wrote:

@wkennington https://github.com/wkennington Sorry, I'm not sure I
understand.
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/9596#issuecomment-136818708.

@wkennington Thanks! So then only the module should be updated to reflect this, yes?

You can just change top-level/all-packages to look like vault or consul or
any other of the canonical go examples I've added. They make sure the bin
derivation is the default and only the bin output is accessible to
environment functions.
On Tue, Sep 1, 2015, 11:31 devhell notifications@github.com wrote:

@wkennington https://github.com/wkennington Thanks! So then only the
module should be updated to reflect this, yes?
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/9596#issuecomment-136821366.

@wkennington I might be an idiot, but syncthing isn't in goPackages.

Yeah just exchange that part with a callPackage. I'll fix this when I land.
On Tue, Sep 1, 2015, 11:39 devhell notifications@github.com wrote:

@wkennington https://github.com/wkennington I might be an idiot, but
syncthing isn't in goPackages.
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/issues/9596#issuecomment-136823375.

@wkennington Thanks!

Should be fixed by 4fecf15b4b09c627f7dfb2792fe202f49b73f90f

@wkennington Thank you, much appreciated. ;-)

authors: ctheune devhell wkennington


text:
shellhub-agent: Add service and package expressions

Motivation for this change
We aim to ease the use of ShellHub and NixOS is one of the distros we'd like to support. It is working very well on our machines.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@SuperSandro2000 I succeed in clean it. Please do another review on this when you have time. Thanks for all the comments.

Is there anything else pending for this PR?

Result of nixpkgs-review pr 104419 run on x86_64-darwin 1

Result of nixpkgs-review pr 104419 run on x86_64-linux 1

1 package blacklisted:

tests.nixos-functions.nixos-test

1 package built:

shellhub-agent

Hello all, I rebased this on top of master to resolve the conflict. Could someone take a look at this?

source: gharchive/pull-request


text:
broot: 1.0.5 -> 1.0.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/broot/versions.
meta.description for broot is: "An interactive tree view, a fuzzy search, a balanced BFS descent and customizable commands"
meta.homepage for broot is: "https://dystroy.org/broot/"
meta.changelog for broot is: ""
Updates performed

Rust version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.0.6 with grep in /nix/store/clv8fy4z4q0i95s2mvh5rqhrw6ksin1h-broot-1.0.6

directory tree listing: https://gist.github.com/76f6d3fa492a009db099eb07ca61a77d

du listing: https://gist.github.com/cce1c24dfc5b71bf38c9c5bf07550ab8

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
broot

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/clv8fy4z4q0i95s2mvh5rqhrw6ksin1h-broot-1.0.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A broot https://github.com/r-ryantm/nixpkgs/archive/0d6bc2f7c25214ecd83806b38f781c8d3599ce85.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/clv8fy4z4q0i95s2mvh5rqhrw6ksin1h-broot-1.0.6
ls -la /nix/store/clv8fy4z4q0i95s2mvh5rqhrw6ksin1h-broot-1.0.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

broot

Maintainer pings
cc @danieldk for testing.

Result of nixpkgs-review pr 105145 run on x86_64-darwin 1

1 package built:

broot


text:
telegraf: 1.16.2 -> 1.16.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/influxdata/telegraf/releases.
meta.description for telegraf is: "The plugin-driven server agent for collecting & reporting metrics"
meta.homepage for telegraf is: "https://www.influxdata.com/time-series-platform/telegraf/"
meta.changelog for telegraf is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.16.3 with grep in /nix/store/c5ycqhzf41c82gz4rgn4zmjhq6a4n5n6-telegraf-1.16.3

directory tree listing: https://gist.github.com/400f074d2386c1afba35615cbf3b2e09

du listing: https://gist.github.com/95fe872a09cdab9950ceb8f7c933ead9

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
telegraf

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/c5ycqhzf41c82gz4rgn4zmjhq6a4n5n6-telegraf-1.16.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A telegraf https://github.com/r-ryantm/nixpkgs/archive/a8e6be01c09c6431f94fe6b7d320f3bccd3927d6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/c5ycqhzf41c82gz4rgn4zmjhq6a4n5n6-telegraf-1.16.3
ls -la /nix/store/c5ycqhzf41c82gz4rgn4zmjhq6a4n5n6-telegraf-1.16.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

telegraf

Maintainer pings
cc @mic92 @roblabla @foxit64 @kalbasit for testing.

Result of nixpkgs-review pr 105940 run on x86_64-darwin 1

1 package built:

telegraf


text:
[20.09] glibc: 2.31 -> 2.31-74 (CVE-2019-25013)

Motivation for this change
https://sourceware.org/glibc/wiki/Release
https://sourceware.org/git/?p=glibc.git;a=log;h=refs/heads/release/2.31/master
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS

[x] Fits CONTRIBUTING.md.

https://github.com/NixOS/nixpkgs/pull/109089

https://github.com/NixOS/nixpkgs/pull/109089

@GrahamcOfBorg build python3Packages.requests

@GrahamcOfBorg build python3Packages.requests

This is the backport of https://github.com/NixOS/nixpkgs/pull/108571.

This is the backport of https://github.com/NixOS/nixpkgs/pull/108571.

Not really. It is switching to the Glibc release branch which carries many other significant fixes as well.

Not really. It is switching to the Glibc release branch which carries many other significant fixes as well.

@TredwellGit Alright, I reworded my comment. Just mentioned the issue so its needs: port to stable label can be removed when this is merged.

@TredwellGit Alright, I reworded my comment. Just mentioned the issue so its needs: port to stable label can be removed when this is merged.

@GrahamcOfBorg build python3Packages.requests

@GrahamcOfBorg build python3Packages.requests

@GrahamcOfBorg build python3Packages.requests

@GrahamcOfBorg build python3Packages.requests

What needs to be done to get this merged?

What needs to be done to get this merged?

@FRidh @NeQuissimus @jonringer ping

@FRidh @NeQuissimus @jonringer ping

I think this should go along with #111020.
@roberth @jonringer @mweinelt ?

I think this should go along with #111020.
@roberth @jonringer @mweinelt ?

I think this should go along with #111020.

The staging build has completed, so I'd prefer to merge #111020 and add this to the next batch. staging-20.09 should cycle quickly because it is not as "experimental" as master's staging.
If we can't merge #111020, we can't deliver this PR either. Next cycle will be short afaic.

I think this should go along with #111020.

The staging build has completed, so I'd prefer to merge #111020 and add this to the next batch. staging-20.09 should cycle quickly because it is not as "experimental" as master's staging.
If we can't merge #111020, we can't deliver this PR either. Next cycle will be short afaic.

I just finished building and deploying all my systems with this PR. Next glibc upgrade won't be reviewed so thoroughly by me^^.
Waiting with merge for #111020.

Hmm, if I had hydra powers, I would make a staging-next-20.09 and change the hydra jobset, but I don't :(
For the 21.05 release, I think will change the creation steps to point to a staging-next-YY-MM,

Does this also fix CVE-2020-29562? See https://github.com/NixOS/nixpkgs/issues/109170.

Yes. https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=1e40391de25da093946dc95273c7f77e6cabee3a;hp=568c86274a00a2f5dcd126893b076f419909a2b5

authors: NeQuissimus TredwellGit dotlambda erictapen jonringer roberth


text:
doc: improve documentation for specialised fetchers

Motivation for this change
"The arguments expected are very similar to fetchFromGitHub above."
was not very good documentation, especially since every function that
said this differed from fetchFromGitHub in important ways that weren't
documented at all.
It makes a lot more sense to have seperate parameter listings for each
function, since the set of parameters each function takes is
completely different.  Additionally, proper lists of parameters are
much easier to read at a glance than a single long paragraph
describing each one in turn, as fetchFromGitHub used to have.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@alyssais You might want to document how fetchFromGitlab works for repository slugs like groupA/projectB/repoC etc.

Another point that disappeared is that other hashing schemes are supported. But perhaps it is not worth documenting since sha256 is recommended anyway.

Yeah, that was on purpose.  I think it was just noise.

On Mon, Feb 08, 2021 at 10:57:47AM -0800, nicoo wrote:

@alyssais You might want to document how fetchFromGitlab works for
repository slugs like groupA/projectB/repoC etc.

@nbraud how's it looking now?

ping @cole-h @jtojnar

ping @alyssais

authors: SuperSandro2000 alyssais nbraud


text:
coqPackages.mathcomp: etc

Motivation for this change
The option withDoc was broken.
This PR fixes it and provide a correct generation of the doc for mathcomp.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build coqPackages_8_5.mathcomp coqPackages_8_6.mathcomp coqPackages_8_7.mathcomp coqPackages_8_8.mathcomp coqPackages_8_9.mathcomp coqPackages_8_10.mathcomp coqPackages_8_11.mathcomp coqPackages_8_12.mathcomp coqPackages_8_13.mathcomp

@GrahamcOfBorg build coqPackages_8_5.mathcomp coqPackages_8_6.mathcomp coqPackages_8_7.mathcomp coqPackages_8_8.mathcomp coqPackages_8_9.mathcomp coqPackages_8_10.mathcomp coqPackages_8_11.mathcomp coqPackages_8_12.mathcomp coqPackages_8_13.mathcomp

@GrahamcOfBorg build coqPackages_8_5.mathcomp coqPackages_8_6.mathcomp coqPackages_8_7.mathcomp coqPackages_8_8.mathcomp coqPackages_8_9.mathcomp coqPackages_8_10.mathcomp coqPackages_8_11.mathcomp coqPackages_8_12.mathcomp coqPackages_8_13.mathcomp

@SuperSandro2000 is everything all right now?

@vbgl if you happen to come by


text:
git: 2.31.1 -> 2.32.0

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg build git gitMinimal gitFull


text:
powertop: fix hard coded path to xset

Added xorg.xset dependency for the powertop -c
command

Added substituteInPlace to correct
the path to xset in src/calibrate/calibrate.cpp

Referenced in :
https://github.com/NixOS/nixpkgs/issues/12662

Closing as I am waiting on patches from @garbas and/or @peti.
Will submit a revised merge once patching and testing has completed.

I know I am opening an old one - but is this fixed? After all those years I am running now PowerTOP 2.16 and with --calibrate option I still get the same error... ;)

authors: galandilias heydojo


text:
dovecot: 2.3.14 -> 2.3.15

Motivation for this change
 * CVE-2021-29157: Dovecot does not correctly escape kid and azp fields in
   JWT tokens. This may be used to supply attacker controlled keys to
   validate tokens, if attacker has local access.
 * CVE-2021-33515: On-path attacker could have injected plaintext commands
   before STARTTLS negotiation that would be executed after STARTTLS
   finished with the client.
 * CVE-2020-28200: Sieve interpreter is not protected against abusive
   scripts that claim excessive resource usage. Fixed by limiting the
   user CPU time per single script execution and cumulatively over
   several script runs within a configurable timeout period. Sufficiently
   large CPU time usage is summed in the Sieve script binary and execution
   is blocked when the sum exceeds the limit within that time. The block
   is lifted when the script is updated after the resource usage times out.

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Looks good and does not break my setup. :+1:


text:
python3Packages.dbutils: 2.0.1 -> 2.0.2

Motivation for this change
Update to latest upstream release 2.0.2
Change log: https://github.com/WebwareForPython/DBUtils/blob/main/docs/changelog.rst#202
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 133384 run on x86_64-linux 1

2 packages built:

python38Packages.dbutils
python39Packages.dbutils


text:
macchina: 1.0.0 -> 1.1.3

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/nix/store/jmqw7xxsjp7c9jykkyps6i42v4zb2jwf-macchina-1.1.3/bin/macchina passed the binary check.
1 of 1 passed binary check by having a zero exit code.
1 of 1 passed binary check by having the new version present in output.
found 1.1.3 with grep in /nix/store/jmqw7xxsjp7c9jykkyps6i42v4zb2jwf-macchina-1.1.3
found 1.1.3 in filename of file in /nix/store/jmqw7xxsjp7c9jykkyps6i42v4zb2jwf-macchina-1.1.3

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

0 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
macchina

Instructions to test this update (click to expand)

Build yourself:
nix-build -A macchina https://github.com/414owen/nixpkgs/archive/e7feba356e81ea8a9ea1efa388e2957cceb8cd78.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jmqw7xxsjp7c9jykkyps6i42v4zb2jwf-macchina-1.1.3
ls -la /nix/store/jmqw7xxsjp7c9jykkyps6i42v4zb2jwf-macchina-1.1.3/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @414owen for testing.
Semi-automatic update generated by nixpkgs-update tools.
meta.description for macchina is: "A fast, minimal and customizable system information fetcher"
meta.homepage for macchina is: "https://github.com/Macchina-CLI/macchina"
meta.changelog for macchina is: "https://github.com/Macchina-CLI/macchina/releases/tag/v1.1.3"
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/nix/store/jmqw7xxsjp7c9jykkyps6i42v4zb2jwf-macchina-1.1.3/bin/macchina passed the binary check.
1 of 1 passed binary check by having a zero exit code.
1 of 1 passed binary check by having the new version present in output.
found 1.1.3 with grep in /nix/store/jmqw7xxsjp7c9jykkyps6i42v4zb2jwf-macchina-1.1.3
found 1.1.3 in filename of file in /nix/store/jmqw7xxsjp7c9jykkyps6i42v4zb2jwf-macchina-1.1.3

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

0 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
macchina

Instructions to test this update (click to expand)

Build yourself:
nix-build -A macchina https://github.com/414owen/nixpkgs/archive/e7feba356e81ea8a9ea1efa388e2957cceb8cd78.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jmqw7xxsjp7c9jykkyps6i42v4zb2jwf-macchina-1.1.3
ls -la /nix/store/jmqw7xxsjp7c9jykkyps6i42v4zb2jwf-macchina-1.1.3/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @414owen for testing.
Success updating

Build result works:
./result/bin/macchina

        a8888b.         ╭ Hydrogen ──────────────────────────────────────────────────╮
       d888888b.        │ Host        -  owen@symdesk                                │
       8P"YP"Y88        │ Machine     -  System manufacturer Product Name Version    │
       8|o||o|88        │ Kernel      -  Linux 5.13.13-arch1-1                       │
       8'    .88        │ Distro      -  Arch Linux                                  │
...

This update fixed a critical bug: https://github.com/Macchina-CLI/macchina/issues/131

Result of nixpkgs-review pr 136886 run on x86_64-linux 1

1 package built:

macchina


text:
dictdDBs.wiktionary: 20210901 -> 20210920

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for dictdDBs.wiktionary is: "DICT version of English Wiktionary"
meta.homepage for dictdDBs.wiktionary is: "https://en.wiktionary.org/"
meta.changelog for dictdDBs.wiktionary is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 20210920 in filename of file in /nix/store/45zykhh3mxilhdy025xsssinrp51ffiv-dict-db-wiktionary-20210920

directory tree listing: https://gist.github.com/7b69604216cde260850c1cefb50825ac

du listing: https://gist.github.com/43e288175e7d78070d21bad53bf831a4

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
dictdDBs.wiktionary

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/45zykhh3mxilhdy025xsssinrp51ffiv-dict-db-wiktionary-20210920 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dictdDBs.wiktionary https://github.com/r-ryantm/nixpkgs/archive/435b3894c495ca7ebccee4b212f1f9259c7f42dd.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/45zykhh3mxilhdy025xsssinrp51ffiv-dict-db-wiktionary-20210920
ls -la /nix/store/45zykhh3mxilhdy025xsssinrp51ffiv-dict-db-wiktionary-20210920/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

dictdDBs.wiktionary

Maintainer pings
cc @alyssais for testing.

Result of nixpkgs-review pr 139094 at 435b3894 run on aarch64-linux 1

1 package built successfully:

dictdDBs.wiktionary

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/servers/dict/wiktionary/default.nix:17:3:
   |
17 |   installPhase = ''
   |   ^

authors: r-rmcgibbo r-ryantm


text:
sasquatch: drop blanket -Werror (fix gcc-11 build)

Noticed build failure on gcc-11:
$ nix-build -E 'with import ./.{}; sasquatch.override { stdenv = gcc11Stdenv; }'
unsquashfs.c:1908:5:
  error: this 'if' clause does not guard... [-Werror=misleading-indentation]
 1908 |     if(swap)
      |     ^~

Let's defer warning squashing and code fixes to upstream.
Cc @Pamplemousse

Result of nixpkgs-review pr 139350 at 0322f7b6 run on x86_64-linux 1

6 packages built successfully:

binwalk (python39Packages.binwalk)
diffoscope
python38Packages.binwalk
python38Packages.binwalk-full
python39Packages.binwalk-full
sasquatch

authors: r-rmcgibbo trofi


text:
python3Packages.somecomfort: 0.5.2 -> 0.6.0

Motivation for this change
Update to latest upstream release 0.6.0
Change log: https://github.com/kk7ds/somecomfort/releases/tag/0.6.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 140011 run on x86_64-linux 1

3 packages built:

home-assistant
python38Packages.somecomfort
python39Packages.somecomfort


text:
nextcloud: misc changes

Motivation for this change

Use php8 where possible
Run tests against all major versions

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Please note that the mysql test will be fixed in #140089.


text:
jackett: 0.18.925 -> 0.19.138, use buildDotnetModule

Motivation for this change
Now compiled from source :)
As far as I can tell, there don't seem to be any regressions.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer


text:
python38Packages.cpyparsing: 2.4.7.1.0.0 -> 2.4.7.1.1.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.cpyparsing is: "Cython PyParsing implementation"
meta.homepage for python38Packages.cpyparsing is: "https://github.com/evhub/cpyparsing"
meta.changelog for python38Packages.cpyparsing is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.4.7.1.1.0 with grep in /nix/store/mldgl0szvccpgdkza9vdph3mgwfr9rf5-python3.8-cpyparsing-2.4.7.1.1.0

found 2.4.7.1.1.0 in filename of file in /nix/store/mldgl0szvccpgdkza9vdph3mgwfr9rf5-python3.8-cpyparsing-2.4.7.1.1.0

Rebuild report (if merged into master) (click to expand)

12 total rebuild path(s)

6 package rebuild(s)

6 x86_64-linux rebuild(s)
6 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
coconut
docbookrx
python38Packages.coconut
python38Packages.cpyparsing
python39Packages.coconut
python39Packages.cpyparsing

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/mldgl0szvccpgdkza9vdph3mgwfr9rf5-python3.8-cpyparsing-2.4.7.1.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.cpyparsing https://github.com/r-ryantm/nixpkgs/archive/0cca0a3afaee47b64e553ec3a807e0c9aa249c87.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/mldgl0szvccpgdkza9vdph3mgwfr9rf5-python3.8-cpyparsing-2.4.7.1.1.0
ls -la /nix/store/mldgl0szvccpgdkza9vdph3mgwfr9rf5-python3.8-cpyparsing-2.4.7.1.1.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

coconut (python39Packages.coconut)
python38Packages.coconut
python38Packages.cpyparsing
python39Packages.cpyparsing

Maintainer pings
cc @fabianhjr for testing.

Testing coconut

@fabianhjr looks like that comment is wrong now.

Ah, yes, that is the first tagged version. Thankfully I won't need to hunt commits now.
Shall I do a manual PR removing that comment?

@fabianhjr that would be great. Ping me for a merge!

authors: fabianhjr r-ryantm ryantm


text:
pantheon.elementary-dock: unstable-2021-11-08 -> unstable-2021-12-08

Motivation for this change
Part of Pantheon 6.1 Jólnir updates (previous one at #150627).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

The following content is machine generated and may contain invalid information.

pantheon.elementary-dock: unstable-2021-11-08 -> unstable-2021-12-08

Compare changes on GitHub

Comment
To inspect upstream changes

[ ] Meson: bump minimum version to 0.50
[ ] DockRenderer: use theme accent color in indicators (#137)

@ofborg test pantheon

Result of nixpkgs-review pr 150792 run on x86_64-linux 1

9 packages built:

pantheon-tweaks
pantheon.elementary-dock
pantheon.elementary-files
pantheon.elementary-greeter
pantheon.elementary-gsettings-schemas
pantheon.switchboard-plug-pantheon-shell
pantheon.switchboard-with-plugs
pantheon.wingpanel-applications-menu
pantheon.wingpanel-with-indicators


text:
python3Packages.pyupgrade: 2.29.1 -> 2.30.0

Motivation for this change
Update to latest upstream release 2.30.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 152515 run on x86_64-linux 1

2 packages built:

python38Packages.pyupgrade
pyupgrade (python39Packages.pyupgrade)


text:
volatility3: 1.0.1 -> 2.0.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for volatility3 is: "Volatile memory extraction frameworks"
meta.homepage for volatility3 is: "https://www.volatilityfoundation.org/"
meta.changelog for volatility3 is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/nix/store/pm3psdspqgiahgs2qw1jbj30m2baxbzp-volatility3-2.0.0/bin/volshell passed the binary check.
/nix/store/pm3psdspqgiahgs2qw1jbj30m2baxbzp-volatility3-2.0.0/bin/vol passed the binary check.
/nix/store/pm3psdspqgiahgs2qw1jbj30m2baxbzp-volatility3-2.0.0/bin/.vol-wrapped passed the binary check.
/nix/store/pm3psdspqgiahgs2qw1jbj30m2baxbzp-volatility3-2.0.0/bin/.volshell-wrapped passed the binary check.
0 of 4 passed binary check by having a zero exit code.
4 of 4 passed binary check by having the new version present in output.
found 2.0.0 with grep in /nix/store/pm3psdspqgiahgs2qw1jbj30m2baxbzp-volatility3-2.0.0
found 2.0.0 in filename of file in /nix/store/pm3psdspqgiahgs2qw1jbj30m2baxbzp-volatility3-2.0.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
volatility3

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/pm3psdspqgiahgs2qw1jbj30m2baxbzp-volatility3-2.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A volatility3 https://github.com/r-ryantm/nixpkgs/archive/4b08c14b4ba9e3270a3b740fedbff9761eb1e875.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/pm3psdspqgiahgs2qw1jbj30m2baxbzp-volatility3-2.0.0
ls -la /nix/store/pm3psdspqgiahgs2qw1jbj30m2baxbzp-volatility3-2.0.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

volatility3

Maintainer pings
cc @fabaff for testing.

Result of nixpkgs-review pr 156002 run on x86_64-linux 1

1 package built:

volatility3

@ofborg build volatility3

authors: fabaff r-ryantm


text:
oil: 0.9.6 -> 0.9.7

Motivation for this change
upstream update, no announcement for this release
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[X] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@abathur you might be interested by this (although there isn't much to review really).


text:
python3Packages.dataclass-csv: init at 1.4.0

Motivation for this change
Add https://github.com/dfurtado/dataclass-csv
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I am closing this PR as it is stale. I am happy to reopen it if needed.


text:
wxWidgets: move wxGTK-* to one wxWidgets folder

Motivation for this change
wxGTK had a lot of code duplication. This merges wxGTK* and wxmac into one "wxWidgets/default.nix" file.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

removes wxmac
removes wxGTK28, wxGTK29, wxGTK30
adds "compat28" and "compat30" flags
add aliases for wxmac, wxGTK28, wxGTK29, wxGTK30
resolves #16066

This is causing a mass rebuild which I think is what is breaking travis.

cc @vcunat Could you stage this at some point? I'm not seeing any issues but lots depends on it.

Skimming all this quickly, it looks OK. I dislike a little that libgd should use some "random" master commit; maybe using that PR would be better as that would reportedly add only two commits to the release.

Or we might directly apply https://github.com/libgd/libgd/commit/502e4cd873c3b37b307b9f450ef827d40916c3d6 to the release, perhaps even on darwin only (to avoid depending on the tools elsewhere).

Ok, I updated libgd to 2.2.2 and also applied the patch that should fix the issue with building.

Now we should go for gd-2.2.2 at least, due to security: f48d21551.

Okay, commit c5ed30f8afb86831066c3cec265873cffd746b4a should be good to go. Everything else should also be good but less urgent.

@vcunat I just rebased onto master. This should be ready for another look.

This seems to brea pythonPackages.wxPython.
In file included from /nix/store/a9whppkflv4f6dq40hdw0lqxvs2srbl8-wxwidgets-3.1.0/include/wx/defs.h:20:0,
                 from /nix/store/a9whppkflv4f6dq40hdw0lqxvs2srbl8-wxwidgets-3.1.0/include/wx/wx.h:14,
                 from include/wx/wxPython/wxPython_int.h:35,
                 from src/helpers.cpp:17:
/nix/store/a9whppkflv4f6dq40hdw0lqxvs2srbl8-wxwidgets-3.1.0/include/wx/platform.h:136:22: fatal error: wx/setup.h: No such file or directory
compilation terminated.
error: command 'gcc' failed with exit status 1
builder for ‘/nix/store/53qfpc47b787wnfm2q0l4qgx44gnad1c-python2.7-wxPython-3.0.2.0.drv’ failed with exit code 1
error: build of ‘/nix/store/53qfpc47b787wnfm2q0l4qgx44gnad1c-python2.7-wxPython-3.0.2.0.drv’ failed

authors: FRidh matthewbauer vcunat


text:
nodePackages.typescript: add mainProgram

Description of changes
Add overlay to edit meta attributes to include mainProgram.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

~/C/nixpkgs on typescript-mainProgram
❯ nix run .#nodePackages.typescript -- --version
Version 4.6.3


text:
drone-runner-docker: 1.8.0 -> 1.8.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/drone-runners/drone-runner-docker/releases.
meta.description for drone-runner-docker is: "Drone pipeline runner that executes builds inside Docker containers"
meta.homepage for drone-runner-docker is: "https://github.com/drone-runners/drone-runner-docker"
meta.changelog for drone-runner-docker is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.8.1 with grep in /nix/store/35mi9g1s8yqqbd62dw9z7ldiss5iibrv-drone-runner-docker-1.8.1
found 1.8.1 in filename of file in /nix/store/35mi9g1s8yqqbd62dw9z7ldiss5iibrv-drone-runner-docker-1.8.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
drone-runner-docker

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/35mi9g1s8yqqbd62dw9z7ldiss5iibrv-drone-runner-docker-1.8.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A drone-runner-docker https://github.com/r-ryantm/nixpkgs/archive/fed2a91f4102c5d162b0c37e2621cb77092a2cd0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/35mi9g1s8yqqbd62dw9z7ldiss5iibrv-drone-runner-docker-1.8.1
ls -la /nix/store/35mi9g1s8yqqbd62dw9z7ldiss5iibrv-drone-runner-docker-1.8.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

drone-runner-docker

Maintainer pings
cc @endocrimes @kalbasit for testing.

https://github.com/drone-runners/drone-runner-docker/releases/tag/v1.8.1
1.8.2. is also already out.
Merging since it doesn't seem like this will get any attention soon and changes seem quite safe.

authors: Mindavi r-ryantm


text:
[22.05] Unbreak conan (upgrade pyjwt, conan)

Description of changes
Conan doesn't build anymore on nixos-22.05 due to broken dependencies. This change backports fixes from nixpkgs-unstable to unbreak it.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I ran nixpkgs-review and from what I can tell this PR fixes conan and breaks no new packages.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/install-conan-from-nixos-22-05-fails/19980/2

As far as i can tell, the pyjwt update should be pretty harmless: https://github.com/jpadilla/pyjwt/releases
I think I would rather see the conan bump in release-22.05 to unbreak it, and then the pyjwt commits can target staging-22.05

@jonringer: thanks!

The pyjwt update isn't liked by homeassistant.  There might be more, though all hopefully trivial to resolve.  /cc e.g. @mweinelt I guess and /cc PR #180752

... and it also caused a few python packages to miss module six, though I have no idea why.

Backported three commits where we propagated six on master.

These shown here are certainly regressions incoming now to 22.05.

The way six is propagated on release-22.05 is

flickrapi → requests-oauthlib → pyjwt → ecdsa → six
homeconnect → requests-oauthlib → pyjwt → ecdsa → six
globus-sdk → pyjwt → ecdsa → six

And sure enough … ecdsa still propagates six on staging-next-22.05, but it was removed from pyjwt, so that broke that chain.

Interesting, not sure why I was able to build so many downstream packages. I just killed the last build because the test suite was going on an hour+.

authors: bjornfor jonringer mweinelt nixos-discourse vcunat


text:
cudatoolkit_11_7: init at 11.7.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 179912 run on x86_64-linux 1

2 packages marked as broken and skipped:

cudaPackages.nvidia_driver
truecrack-cuda

5 packages failed to build:

cudaPackages.cuda-samples
ethminer (ethminer-cuda)
mathematica-cuda
python310Packages.cupy
python39Packages.cupy

63 packages built:

colmapWithCuda
cudaPackages.cuda_cccl
cudaPackages.cuda_cudart
cudaPackages.cuda_cuobjdump
cudaPackages.cuda_cupti
cudaPackages.cuda_cuxxfilt
cudaPackages.cuda_demo_suite
cudaPackages.cuda_documentation
cudaPackages.cuda_gdb
cudaPackages.cuda_memcheck
cudaPackages.cuda_nsight
cudaPackages.cuda_nvcc
cudaPackages.cuda_nvdisasm
cudaPackages.cuda_nvml_dev
cudaPackages.cuda_nvprof
cudaPackages.cuda_nvprune
cudaPackages.cuda_nvrtc
cudaPackages.cuda_nvtx
cudaPackages.cuda_nvvp
cudaPackages.cuda_sanitizer_api
cudatoolkit (cudaPackages.cudatoolkit ,cudatoolkit_11)
cudaPackages.cudnn (cudaPackages.cudnn_8_4_0)
cudaPackages.cudnn_8_3_2
cudaPackages.cutensor
cudaPackages.fabricmanager
cudaPackages.libcublas
cudaPackages.libcufft
cudaPackages.libcufile
cudaPackages.libcurand
cudaPackages.libcusolver
cudaPackages.libcusparse
cudaPackages.libnpp
cudaPackages.libnvidia_nscq
cudaPackages.libnvjpeg
cudaPackages.nccl
cudaPackages.nsight_compute
cudaPackages.nsight_systems
cudaPackages.nvidia_fs
forge
gpu-burn
gromacsCudaMpi
gwe
katagoWithCuda
librealsenseWithCuda
magma
nvtop
nvtop-nvidia
python310Packages.TheanoWithCuda
python310Packages.numbaWithCuda
python310Packages.pycuda
python310Packages.pynvml
python310Packages.pyrealsense2WithCuda
python310Packages.pytorchWithCuda
python310Packages.tensorflowWithCuda
python39Packages.TheanoWithCuda
python39Packages.numbaWithCuda
python39Packages.pycuda
python39Packages.pynvml
python39Packages.pyrealsense2WithCuda
python39Packages.pytorchWithCuda
python39Packages.tensorflowWithCuda
xgboostWithCuda
xpraWithNvenc

cudaPackages.cuda-samples is known broken based on the comment in this PR
mathematica-cuda is an existing failure due to missing the installer download

That leaves ethminer-cuda and cupy, which appear to be broken by this 11.7 upgrade. @dguibert could you add the appropriate overrides to keep these two packages on 11.6 (or whatever the appropriate versions are)?

AFAICT cupy error looks like
cupy_backends/cuda/libs/cutensor.cpp: In function ‘uint64_t __pyx_f_13cupy_backends_4cuda_4libs_8cutensor_contractionGetWorkspaceSize(__pyx_obj_13cupy_backends_4cuda_4libs_8cutensor_Handle*, __pyx_obj_13cupy_backen
ds_4cuda_4libs_8cutensor_ContractionDescriptor*, __pyx_obj_13cupy_backends_4cuda_4libs_8cutensor_ContractionFind*, int, int)’:
cupy_backends/cuda/libs/cutensor.cpp:5717:17: error: ‘CUTENSOR_VERSION’ was not declared in this scope; did you mean ‘CUTENSOR_OP_SIN’?
 5717 |   __pyx_t_1 = ((CUTENSOR_VERSION < 0x2904) != 0);
      |                 ^~~~~~~~~~~~~~~~
      |                 CUTENSOR_OP_SIN
cupy_backends/cuda/libs/cutensor.cpp: In function ‘uint64_t __pyx_f_13cupy_backends_4cuda_4libs_8cutensor_reductionGetWorkspaceSize(__pyx_obj_13cupy_backends_4cuda_4libs_8cutensor_Handle*, intptr_t, __pyx_obj_13cup
y_backends_4cuda_4libs_8cutensor_TensorDescriptor*, intptr_t, intptr_t, __pyx_obj_13cupy_backends_4cuda_4libs_8cutensor_TensorDescriptor*, intptr_t, intptr_t, __pyx_obj_13cupy_backends_4cuda_4libs_8cutensor_TensorD
escriptor*, intptr_t, int, int, int)’:
cupy_backends/cuda/libs/cutensor.cpp:6584:17: error: ‘CUTENSOR_VERSION’ was not declared in this scope; did you mean ‘CUTENSOR_OP_SIN’?
 6584 |   __pyx_t_1 = ((CUTENSOR_VERSION < 0x2904) != 0);
      |                 ^~~~~~~~~~~~~~~~
      |                 CUTENSOR_OP_SIN

cupy has been broken on master for a while

ah gotcha, looks like the same is true for ethminer... in that case I guess we're good to merge

https://gist.github.com/GrahamcOfBorg/45ac7f5bc9e02a74cb1e4264f365417f
Seems this PR broke eval on master.

11.7.0 would need to be added here, assuming it's compatible. (cc @aidalgol)

@zowoq uh oh, sorry about that! I'll revert. Looks like we'll need to rebase onto latest master and try again
thanks for the heads up!

11.7.0 would need to be added here, assuming it's compatible. (cc @aidalgol)

That version is not.  The list of supported versions in that file is exactly as listed on the nvidia download page.  There is a newer version of TensorRT that supports CUDA 11.7, but it requires cuDNN 8.4, which is not yet in nixpkgs.

Hmm interesting... so we should be marking TensorRT as broken in that case? at least we can't break evaluation haha
long term solution of course is to package cuDNN 8.4...

Hmm interesting... so we should be marking TensorRT as broken in that case? at least we can't break evaluation haha

That is already done automatically in the TensorRT derivations (see here).

Mm, I see what you mean. It appears that merging this did break eval however. I haven't dug into all the details just yet, but the logs suggest it has something to do with TensorRT...

It appears that the case where the CUDA version is not in tensorRTDefaultVersion is not handled, which is why adding CUDA 11.7 broke eval.  I'm not sure how best to handle this case.  Perhaps define a default version for CUDA 11.7, and let the logic in generic.nix mark it as broken, because 11.7 is not in the list of supported CUDA versions, but it will at least evaluate.

@zowoq What was the exact command that was failing? I just want to make sure that I'm testing correctly

See OfBorg's README for the command it runs.

long term solution of course is to package cuDNN 8.4...

introduced by https://github.com/NixOS/nixpkgs/pull/179912/commits/a43d296d12cc3b9e77cd1798df22cc4596373541 within this PR.

Mm, I see what you mean. It appears that merging this did break eval however. I haven't dug into all the details just yet, but the logs suggest it has something to do with TensorRT...

Adding a line: "11.7" = "8.4.0"; to tensorRTDefaultVersion should be enough.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/how-to-install-a-specific-version-of-cuda-and-cudnn/21725/4

authors: SomeoneSerge aidalgol dguibert nixos-discourse samuela winterqt zowoq