text:
check privileges for out of a server operations

LGTM

It would be nice to some rationale behind the changes, though.

authors: a-beloglazov ivanyu willyborankin

repo: aiven/aiven-elasticsearch-repositories


text:
fitted_params should overloaded to return the Flux chain in each model

So, fitted_params(::Regressor, fitresult)  = (chain=fitresult[1], ) and so forth

And the readme docs should explain that fitted_params can be used to access the Flux chain.

source: gharchive/issue

license: MIT

license_type: permissive

license_source: github-api


text:
Can i scrap javascript based website by this package?

You need a custom user agent. Check this documentation section.
If you are scraping single page application (SPA), by default, it's not possible to "wait" for the JavaScript to generate the entire page.
However, by "pretending" to be one of the known web crawlers (such as Google or Yahoo) you might be able to fetch pre-rendered HTML. Note that this depends entirely on the website you want to scrape - some offer pre-rendered HTML to crawlers, some don't.

repo: aleksa-sukovic/scrapy


text:
Upload test coverage report to codecov

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@5e9e807). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #7   +/-   ##
=======================================
  Coverage        ?   87.50%
=======================================
  Files           ?        4
  Lines           ?      248
  Branches        ?       53
=======================================
  Hits            ?      217
  Misses          ?       31
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9e807...2d6fb5f. Read the comment docs.

source: gharchive/pull-request

authors: alesgenova codecov-io

repo: alesgenova/post-me


text:
Add some ignore rules APIs

Thanks!


text:
Added use_date parameter

Sweet ! Please update the README with the new option as well !

Done ;)

I'm going to hell for this, but can you bump the version number in package.json ?

authors: PaulMougel alexjab

repo: alexjab/consolation

license: mit

license_source: bigquery


text:
Add Python code to Monte Carlo Integration

I totally forgot this, but we currently have multiple Python Monte Carlo pull requests. I can't guarantee that your code will actually be used because other people were faster than you. I'll ask @jiegillet about the situation as soon as he's back since he's handling the situation as far as I know.

Hi @hybrideagle, thanks for you contribution. #184 is ahead of you. Feel free to look at my review of that code and change your code accordingly if you wish, but I will only accept your code if that other PR goes dead. That has happened 2 or 3 times before for monte carlo in Python, somehow this combination is cursed.

This is the weirdest algorithm to have this kind of churn.
Should I close this PR for now?

I think you can close it. We are close to resolution with the other PR.

authors: Butt4cak3 hybrideagle jiegillet

repo: algorithm-archivists/algorithm-archive


text:
Feature/fix

Codecov Report

Merging #120 into develop will decrease coverage by 0.84%.
The diff coverage is 40%.

@@             Coverage Diff             @@
##           develop     #120      +/-   ##
===========================================
- Coverage    62.52%   61.68%   -0.85%
===========================================
  Files          204      204
  Lines        10845    10849       +4
===========================================
- Hits          6781     6692      -89
- Misses        4064     4157      +93

Impacted Files
Coverage Δ

mediaPlayer/SuperMediaPlayer.cpp
67.7% <0%> (+0.72%)
:arrow_up:

framework/demuxer/play_list/HlsParser.cpp
77.85% <80%> (ø)
:arrow_up:

framework/tests/dataSource/ipList.h
0% <0%> (-100%)
:arrow_down:

framework/tests/decoder/decoderUnitTest.cpp
0% <0%> (-93.48%)
:arrow_down:

framework/tests/dataSource/dataSourceUnitTest.cpp
0% <0%> (-93.34%)
:arrow_down:

framework/data_source/ffmpeg_data_source.cpp
9.37% <0%> (-65.63%)
:arrow_down:

framework/data_source/curl/CURLShareInstance.cpp
69.44% <0%> (-27.78%)
:arrow_down:

framework/data_source/ffmpeg_data_source.h
80% <0%> (-10%)
:arrow_down:

framework/data_source/curl/CURLConnection.cpp
56.84% <0%> (-8.64%)
:arrow_down:

mediaPlayer/media_packet_queue.cpp
50.4% <0%> (-4%)
:arrow_down:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2f74d5...f42e992. Read the comment docs.

authors: codecov-io pingkai

repo: alibaba/CicadaPlayer


text:
typo

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

repo: alibaba/PolarDB-for-PostgreSQL


text:
verdicted: implement the verifier in verdictd to communicate with Intel PCCS

For intel PCCS, need to implement a C warpper that wraps DCAP APIs because it's inconvenient for RUST to call C++ lib directly.

repo: alibaba/inclavare-containers


text:
Add task

Commit the new changes.


authors: AmplabJenkins gpang uronce-cc

repo: amplab/tachyon


text:
Update to use github link for downloading the Tachyon binary.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/2587/
Test PASSed.

authors: AmplabJenkins calvinjia


text:
Make email validation support any tld up to 6 characters

Why stop at 6? There are already longer TLDs.

authors: TristanCacqueray copumpkin

repo: andrewcmyers/civs


text:
add plot_ci function from confidence intervals lab

https://github.com/andrewpbray/oilabs/pull/16

repo: andrewpbray/oilabs


text:
Bugfix #210 model not saved after inserting images

I know the tests are a bit out of date, and I have a task to clean them up and add more, but it would be nice if you could add tests for this as part of the PR.
Once the changes are made we can get this merged in. Thanks for reporting and posting a PR.

Very well, I should do it this week. Thanks

@deeg , sorry I missed to update the code for a while, but it's done.
You can merge it now.

Please see my comment on #210 about explaining why SetContent is needed.

@rbecheras, going to close this PR. Lets finish the discussion over at #210, and we can get another PR opened pending the results.

authors: deeg rbecheras

repo: angular-ui/ui-tinymce


text:
docs(@angular/cli): change default test watch flag

hi @alan-agius4, sorry for the mistake, I hope it is better like that.

Hi, you need to squash your commits into a single one, as like this the original commit is still present.

repo: angular/angular-cli


text:
chore(release): update versions for alpha.8

Wouldn't the need of forRoot() on some components be worth mentioning?
https://github.com/angular/material2/blob/9ff619669ae4e16409772b96e9f8d98f8477a3e0/src/lib/all/all.ts#L73

@fxck Modules IDs are stripped during the release build process.  We need to keep them in the repo for internal syncing reasons, but they're not part of the NPM package.

LGTM aside from those two minor comments

With webpack alpha.8 (https://www.npmjs.com/~angular2-material) fails to this:

WARNING in ./~/@angular2-material/button-toggle/button-toggle.js
15:24 Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

WARNING in ./~/@angular2-material/button/button.js
17:24 Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

WARNING in ./~/@angular2-material/checkbox/checkbox.js
12:24 Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

... and for all the others MD2 components

@codespicelabs  see https://github.com/angular/material2/pull/1168

authors: codespicelabs fxck jelbourn kara


text:
[WIP] Display traceback with user_exception, use better-exceptions

Moved to https://github.com/pdbpp/pdbpp/pull/3.

Also useful for exc?? I guess.

repo: antocuni/pdb


text:
CAMEL-10837 - Migration of EIP documentation

Thanks for the PR it has been merged. Do you mind closing this?

authors: davsclaus ouapdouap

repo: apache/camel


text:
fediz-idp: adopt to Spring Security 4.x

@amarkevich Have you checked that this part is still working properly? "roleName.substring(5)"
https://github.com/apache/cxf-fediz/blob/fcb562dd498526ffe96c63846ceec385b9484b3c/services/idp-core/src/main/java/org/apache/cxf/fediz/service/idp/service/security/GrantedAuthorityEntitlements.java#L74

@coheigea Behavior is the same:
added debug output at pointed line
System.out.println(roleName + " -> " + roleName.substring(5));
and build for example systests/idp found expected

ROLE_IDP_LOGIN -> IDP_LOGIN
but also some
CLAIM_LIST -> _LIST
IDP_READ -> EAD

@amarkevich Maybe we need to check to see if the role starts with "ROLE_"?

The role prefix should be configurable in Spring Security, it could be missing entirely

authors: amarkevich andrei-ivanov coheigea

repo: apache/cxf-fediz


text:
HBASE-25875 RegionServer failed to start due to IllegalThreadStateException in AuthenticationTokenSecretManager.start

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 26s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 10s
master passed

+1 :green_heart:
compile
3m 25s
master passed

+1 :green_heart:
checkstyle
1m  9s
master passed

+1 :green_heart:
spotbugs
2m 12s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 27s
the patch passed

+1 :green_heart:
compile
3m 44s
the patch passed

+1 :green_heart:
javac
3m 44s
the patch passed

+1 :green_heart:
checkstyle
1m 16s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
22m 16s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 22s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

54m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3250

Optional Tests
dupname asflicense spotbugs xml javac hadoopcheck hbaseanti checkstyle compile

uname
Linux cc7a22304dd6 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b65733c093

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/4/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 37s
master passed

+1 :green_heart:
compile
1m  0s
master passed

+1 :green_heart:
shadedjars
8m 13s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 38s
the patch passed

+1 :green_heart:
compile
1m  2s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

+1 :green_heart:
shadedjars
8m 16s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
the patch passed

_ Other Tests _

-1 :x:
unit
164m 57s
hbase-server in the patch failed.

194m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3250

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f6518db9caa8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b65733c093

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/4/testReport/

Max. process+thread count
4817 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m  2s
master passed

+1 :green_heart:
compile
1m 19s
master passed

+1 :green_heart:
shadedjars
9m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 43s
the patch passed

+1 :green_heart:
compile
1m 18s
the patch passed

+1 :green_heart:
javac
1m 18s
the patch passed

+1 :green_heart:
shadedjars
8m 56s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
208m 53s
hbase-server in the patch passed.

243m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3250

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux bc21bce5147e 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b65733c093

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/4/testReport/

Max. process+thread count
3298 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Test case failures are not relevant, passing locally.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 18s
master passed

+1 :green_heart:
compile
3m 24s
master passed

+1 :green_heart:
checkstyle
1m  9s
master passed

+1 :green_heart:
spotbugs
2m 10s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  1s
the patch passed

+1 :green_heart:
compile
3m 18s
the patch passed

+1 :green_heart:
javac
3m 18s
the patch passed

+1 :green_heart:
checkstyle
1m  8s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
20m  0s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 19s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

51m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3250

Optional Tests
dupname asflicense spotbugs xml javac hadoopcheck hbaseanti checkstyle compile

uname
Linux 62ada55fb19a 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b65733c093

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/6/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 27s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 11s
master passed

+1 :green_heart:
compile
1m 12s
master passed

+1 :green_heart:
shadedjars
8m 16s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 17s
the patch passed

+1 :green_heart:
compile
1m 14s
the patch passed

+1 :green_heart:
javac
1m 14s
the patch passed

+1 :green_heart:
shadedjars
8m 14s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
141m 43s
hbase-server in the patch passed.

173m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3250

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux eab627e87104 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b65733c093

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/6/testReport/

Max. process+thread count
4071 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 57s
master passed

+1 :green_heart:
compile
0m 59s
master passed

+1 :green_heart:
shadedjars
9m 47s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  9s
the patch passed

+1 :green_heart:
compile
1m 19s
the patch passed

+1 :green_heart:
javac
1m 19s
the patch passed

+1 :green_heart:
shadedjars
11m 25s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 48s
the patch passed

_ Other Tests _

-1 :x:
unit
162m 31s
hbase-server in the patch failed.

199m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3250

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0238d4a94cbe 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / b65733c093

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/6/testReport/

Max. process+thread count
3885 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3250/6/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Test case failures are not relevant, passing locally.

repo: apache/hbase


text:
Translate the document of hardware-environment.md

very good

authors: cafechen dailidong


text:
remove unused tests &  change IntegarateTest => IT for convention.

Pull Request Test Coverage Report for Build 8318

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 60.045%

Totals

Change from base Build 8317:
0.2%

Covered Lines:
8183

Relevant Lines:
13628

💛  - Coveralls

authors: cherrylzhao coveralls

repo: apache/incubator-shardingsphere


text:
[TC-429] - removes map due to license incompatibility

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/161/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/122/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-whatchanged/31/

removing code is always a good thing.

authors: DylanVolz asfgit mitchell852

repo: apache/incubator-trafficcontrol


text:
KARAF-6721 - Update Spring versions due to CVE-2020-5398

retest this please

retest this please

authors: coheigea jbonofre

repo: apache/karaf


text:
LOG4J2-3109 - Use Standard Charset object (StandardCharsets)

Should these also be back-ported to release-2.x? This should have a Jira issue.

Hi @rgoers
Jira created
LOG4J2-3109
TY

We have shared with @arturobernalg in the dev mailing list that we are understaffed to deal with the cosmetic changes he has proposed so far, hence closing the ticket.

authors: arturobernalg vy


text:
ORC-366: [C++] Improve TZDIR setup for WIN32

reason for this is change failed buid

repo: apache/orc


text:
TAJO-1403: Improve 'Simple Query' with only partition columns and constant values

I'll review this weekend.

Finally! Thank you, @jihoonson . I'm working this weekend also, Please ask anything if you need.

@dongjoon-hyun, thanks for your nice work.
In overall, the patch looks good, but I want to check my understanding.
If the WHERE clause involves only a subset of partition columns, it seems that every partition directory which are not specified in the where clause will be read.
Please correct me if I misunderstand something.

You're right, but when I can construct prefix from the subset of partition column, this patch handle that as a simple query.
/table_name/year=x/day=y/hour=z  (full path is simple query)
/table_name/year=x/day=y               (prefix path is constructed, so simple query)
/table_name/          /day=y/hour=z  (year is unknown, this is not simple query. It will be handled in an old fashion)
/table_name/year=x/         /hour=z  (day is unknown, this is not simple query, too.)

Thanks. It's clear to me.
I left only trivial comments. When you reflect all of them, I'll give +1.
Anyway, I'm not pushing you, but do you have any plans to support the last two cases?

For the last two cases, I thought it will need to eval on each tuple, so I'm not sure it's compatible with Tajo philosophy. Do you have some idea in mind?

I changed the code according your comment. (Indentation and TODO documentation with issues)

I think that it is possible to prune unnecessary partitions for the last two cases without hurting our philosophy as follows.
When visiting a partition directory,

if the current directory is leaf, read all files.
otherwise,
if some conditions are given for the current partition, visit only qualified sub-directory.
otherwise, visit all sub-directory.

Anyway, here is my +1. I'll commit it.
However, I missed one more comment. EvalTreeUtil is the more proper class for checkIfPartitionSelection() and getPartitionValue() functions rather than PlannerUtil because every function related to EvalNode is located in that class.
If you don't mind, I'll move those functions to EvalTreeUtil before commit.

Sure, please do that. I will learn from that. And when improving this further, I will start from there.
Thank you for your kind leading, @jihoonson

authors: dongjoon-hyun jihoonson

repo: apache/tajo


text:
UpdateEngine

staled by #3

repo: apipluspower/pi-gen


text:
SILOwnershipVerifier: fix a compiler error in the no-assert build.

@swift-ci smoke test and merge

repo: apple/swift


text:
Various cleanups in adaptive tile renderer

I'm sorry I had forgot so many things..

No worries at all, code is never perfect, improving it is a never-ending process...

repo: appleseedhq/appleseed


text:
List style change event

added styleChange event

Added titleChange event

repo: arboshiki/lobilist


text:
导出数据中太长的数字变科学计数法了，怎么解决？

function executeColumns
中将setValue改为
setValueExplicit($value,'s')


text:
chore(README): remove code sponsor

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   78.04%   78.04%
=======================================
  Files           1        1
  Lines          41       41
  Branches       17       17
=======================================
  Hits           32       32
  Misses          2        2
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72933da...8a95d5f. Read the comment docs.

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: codecov-io danez

repo: ariporad/pirates


text:
fixes for windows 10: device name and missing midi open command

Hi, I notice you changed the DEVICE_NAME_RE to no longer check the manufacturer's name. Can you tell me what the full Launchpad name string is on Windows, e.g., with UniMIDI::Output.all.find {|dev| p dev.naw}?

Hi. Yes, I am trying to connect my launchpad with the paint program. It works beautifully on Mac but on windows I keep getting an error that on line 66 there is an undefined method 'reset' for nil:NilClass.
Where do I get the full Launchpad string from? I am currently learning Ruby.
Mimi A. Shimkovska
Stetson University, Class of 2018
Computer Science Major

From: Kimmo Kulovesi notifications@github.com
Sent: Sunday, August 12, 2018 2:25:04 AM
To: arkku/launchpad-ruby
Cc: Maria Shimkovska; Author
Subject: Re: [arkku/launchpad-ruby] fixes for windows 10: device name and missing midi open command (#1)
Hi, I notice you changed the DEVICE_NAME_RE to no longer check the manufacturer's name. Can you tell me what the full Launchpad name string is on Windows, e.g., with UniMIDI::Output.all.find {|dev| p dev.naw}?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/arkku/launchpad-ruby/pull/1#issuecomment-412330055, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVWFn0X0XIBwN2Sw-Sm5DI9wwrfyPVjJks5uP_RwgaJpZM4V5SWG.

Hi,
You can print the names of all connected MIDI devices in irb with the following:
require 'rubygems'; require 'unimidi'
UniMIDI::Output.all.find {|dev| p dev.name }

Just look for the Launchpad in the list and copypaste the entire line here, I'm just interested to know why and how it's different on Windows. =)

repo: arkku/launchpad-ruby


text:
Storybook docs

:tada: This PR is included in version 3.0.0-beta.19 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


text:
Updates A&A definition and triggered pages.

:+1:

authors: birdage oceanzus

repo: asascience-open/ooi-ui


text:
update README

Pull Request Test Coverage Report for Build 129

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 78.36%

Totals

Change from base Build 127:
0.0%

Covered Lines:
927

Relevant Lines:
1183

💛  - Coveralls

authors: asheuh coveralls

repo: asheuh/flaskie


text:
Use RazorCompiledItemMetadataAttribute to calculate route

Merged in 927af3125ee1d7e69330fa745206d5071ed097fc

repo: aspnet/Mvc


text:
Incluído Recipients para permitir o uso de Marketplace e também suporte ao Maven

Description please

Alterações para permitir que se possa trabalhar com marketplace na Pagar.me com a biblioteca Java

muito bom jeffprestes.

authors: aspotato jeffprestes ojunge

repo: aspotato/pagarme-java


text:
Add contributors to copyright and update year

Thanks.

repo: assaf/vanity


text:
translations   zh-CN    doc

Thanks!

authors: wujingke zcbenz

repo: atom/electron


text:
Reveal.js 4.1.1 is released

It is using from v 1.2.0

repo: attakei/sphinx-revealjs


text:
new tools for non-i pipeline

Merged


text:
segmentation fault with amazon kinesis

Ok i got the solution to the above problem we have to make the above changes in
/amazon-kinesis-video-streams-producer-sdk-cpp/kinesis-video-gst-demo/kinesis_video_gstreamer_sample_app.cpp


text:
how to use cloud search sdk in android application

Hi @Pd51, Currently our SDK doesn't support CloudSearch. We will take it as a feature request.

Can you suggest me how can i implement search feature in dynamo db for my android application

You may query the DynamoDB table based on your primary key and sort key.
If you wish to "search" on any arbitrary field, then you will need to scan the table (This is expensive and should only be used if absolutely necessary).

authors: Pd51 kvasukib minbi

repo: awslabs/aws-sdk-android-samples


text:
Enable Black in the Jenkins pipelines

It's now part of the tests.

authors: aalexandrov jaheba

repo: awslabs/gluon-ts


text:
Feature/goforwalk

+1

authors: CloudNiner flibbertigibbet

repo: azavea/nih-wayfinding


text:
Update Seaside Dependencies

Coverage remained the same at 99.669% when pulling e3412736f750d4592f9d5e7e46f4bb2fa247377a on update-seaside-3.2.4 into 956aa58ced96839a9072f4ecefd9dcaaa2b94e38 on master.

authors: coveralls gcotelli

repo: ba-st/Willow


text:
Revise one word in ISSUE_TEMPLATE.md

Coverage decreased (-0.1%) to 62.314% when pulling 326d4ec73c5b721d457907b2d5c49eb3f48526ae on gangliao-patch-2 into e05f4ff26700dd34aa6d3c6da7061c62c5fa39c9 on develop.

authors: coveralls gangliao

repo: baidu/Paddle


text:
Add fallible methods for building Requests.

bors merge

repo: bailion/puck


text:
Configure dev & prod mode

We currently have a solution which is a bit hacky, but goes further than using dev in order to have the possibility to switch between more than two states (e.g. TestFlight System). Would you be interested in seeing a PR?

I have a issue for introducing a dev vs prod environment see #9.  We could use that.
Before going down the bunny hole w/ "a bit hackey" approach, could you explain what the approach is?
I know I read somewhere that GitHub has a solution for storing project sensitive files for dev/prod, but I can't find it in the Help right now.  Before doing much w/ this topic, we need to research that option too.
If I understand correctly, TestFlight is a Apple App distribution solution.  It would be great if you could address the Bitrise.io Fastlane build to send the app there.  I don't have a specific issue for that right now.
It you have experience w/ building the native iOS app wrt certs, app ids, versioning, profiles and such, I could use help there too, see #24.
Thanks for the offer of help! -barton

Well, this is #9, so I commented here ;)
The original approach was to use babel's plugin for inlining enviroment variables to replace every occurence of process.env.NODE_ENV with the word 'production', 'staging' or 'development'. This broke with the update to 0.16, as the packagers call to babel let the core of RN recompile where something like 'production' = __DEV__ was the result. (for more details see this issue)
Nevertheless I think RN will soon fix their babel setup with the upgrade to babel 6 and this solution may be possible again. So far, our a bit hacky solition is that we use a shell script to string replace process.env.NODE_ENV with 'production', 'staging' or 'development' for just one file, which is then used to determine in which context the app is running and it works perfectly. No drawbacks, but as it is a workaround for a nicer solution I called id hacky.
I will look into issue #24 and give my opinion on that topic, could you please write an issue for the TestFlight stuff you mentioned, I don't really know what you mean by that paragraph.
Have a nice day!

Ok - i understand the concept of the script, makes sense.   I believe RN release 0.16 now has Babel 6: https://github.com/facebook/react-native/releases/tag/v0.16.0.
It would be great to first upgrade snowflake to RN 0.16 and then use the Babel feature you mentioned, see #21 - I spent a little time on #21  and ran into issues getting iOS running in the simulator and dealing with the .bablerc / plugins / transformers etc.

Okay, if you did so, please inform me, I would like to add the env feature to the application ;)

I am not working on the upgrade to RN 0.16 - I think I'll wait for the dust to settle a few more days.

Ah okay, well maybe I try it in a few days if I happen to have the time.

Not going to address this.

authors: DanielMSchmidt bartonhammond

repo: bartonhammond/snowflake


text:
Document my (n)vim setup

nerdtree  vim-better-whitespace  vim-commentary  vim-fugitive  vim-markdown  vim-sensible

Documented in https://github.com/bast/config.

repo: bast/til


text:
Correlation spectrum example

Coverage remained the same at 88.884% when pulling 07153125082e11131aee6b2575d00102d19897c7 on david-pl:spectrum-example into 9e40c61e9eb961bb2c7218bed333d22b0cc9b4e7 on bastikr:master.

authors: coveralls david-pl


text:
Add build flags

Add build flags #6

repo: bayard-search/lindera-cli


text:
Compute principal axes & Inertias

Replaced by min/max bounds

repo: bbercovici/SBGAT


text:
add status column to ref_client

For the FTA old client problem, we need a column to store status, so we can filter for actives after the fact.    This issue is for the work to backup the table, alter the table, etc.

alter table ref_client add column forest_file_client_type_code text;

done in  dev

done in test

done in prod

repo: bcgov/range-api


text:
IconSvg release

Coverage decreased (-0.09%) to 92.782% when pulling dc5d712837eda26e991e041cc58c037d4b5fb517 on Be-Smart:icon-svg into 5adb881a9a021fc4d7dcfa7c960d72a2b16bf295 on bcrumbs:master.

Coverage increased (+0.01%) to 92.883% when pulling 0a6cf338091a4d1c87ef95c827d13797fa96e58d on Be-Smart:icon-svg into 5adb881a9a021fc4d7dcfa7c960d72a2b16bf295 on bcrumbs:master.

Coverage increased (+0.01%) to 92.883% when pulling 8b374eb1a82f9e8483045093d9f45dc4e70409f2 on Be-Smart:icon-svg into 5adb881a9a021fc4d7dcfa7c960d72a2b16bf295 on bcrumbs:master.

Coverage increased (+0.03%) to 92.904% when pulling 3184bc4d4bd80d8bcb3ac00a3d0efefca621f995 on Be-Smart:icon-svg into 5adb881a9a021fc4d7dcfa7c960d72a2b16bf295 on bcrumbs:master.

Coverage increased (+0.05%) to 92.917% when pulling 60f2b1edfc47076abe8ec898a31bcbc8f6ce71a6 on Be-Smart:icon-svg into 5adb881a9a021fc4d7dcfa7c960d72a2b16bf295 on bcrumbs:master.

Coverage increased (+0.05%) to 92.917% when pulling 90fda21f95a13f08f3a038e23d2d68e9cc1e7e25 on Be-Smart:icon-svg into 5adb881a9a021fc4d7dcfa7c960d72a2b16bf295 on bcrumbs:master.

Coverage increased (+0.1%) to 92.98% when pulling 17a13da47ea636bb578f63031f30ab303780c832 on Be-Smart:icon-svg into 5adb881a9a021fc4d7dcfa7c960d72a2b16bf295 on bcrumbs:master.

authors: Be-Smart coveralls

repo: bcrumbs/reactackle


text:
Feature/upgrades

LGTM

Coverage remained the same at 47.368% when pulling d6e3cdc184d6dcd0d6bad30713e7d51a831ded8b on feature/upgrades into 082b6f177ff6e8d9a919f67bb2e4e2aac456f76e on master.

Coverage remained the same at 47.368% when pulling 43b66ca46f283caa1ecc48f97067cad938484a2f on feature/upgrades into 082b6f177ff6e8d9a919f67bb2e4e2aac456f76e on master.

Coverage remained the same at 47.368% when pulling fc7be99b277543da2f08eb1cc17a0198fd2b25c9 on feature/upgrades into 082b6f177ff6e8d9a919f67bb2e4e2aac456f76e on master.

Coverage remained the same at 47.368% when pulling 17e7dd4b56a8df1cb6fa8f853610dca5a7ef3b61 on feature/upgrades into 082b6f177ff6e8d9a919f67bb2e4e2aac456f76e on master.

There were the following issues with your Pull Request

Commit: e271d093a4eca6820dac90a762ac87148aa19881
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/benlangfeld/QueueFlex/blob/master/CONTRIBUTING.md#pull-requests

This message was auto-generated by https://gitcop.com

Coverage remained the same at 47.368% when pulling 54a3b20c211c851d2743755e5ff01ce8a1f2594d on feature/upgrades into 082b6f177ff6e8d9a919f67bb2e4e2aac456f76e on master.

authors: GitCop benlangfeld coveralls

repo: benlangfeld/QueueFlex


text:
updated README.md

@yuchengdong checks passed, and you said you will add more :dancers:

authors: cxmo yuchengdong


text:
PHPCS-28: Add sniffer to warn if generic array type hints are used

Die PHPDocs im Projekt selber müssen noch angepasst werden. Hier ist aber unklar, wie wir mit fällen umgehen, wo kein expliziter Typ definiert werden kann.
Beispiel:
    /**
     * Get data array
     *
     * @param string $key
     *
     * @return array
     */
    public function getData(string $key)
    {
        return [
            'key' => 'foobar',
            'value' => 12.4,
            'formatted' => '12,40 EUR',
            'object' => new Price(12.4)
        ];
    }

Warten auf Feedback.

No thought through ;)


text:
Update Python version to 3.6 for dockerfiles

Codecov Report

Merging #279 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #279   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           9      9
  Lines         220    220
=====================================
  Hits          220    220

authors: codecov-io sbellem

repo: bigchaindb/bigchaindb-driver


text:
Spark Errors" References Deprecated SPARK_CLASSPATH

Accidental duplicate of https://github.com/bigdatagenomics/adam/issues/767

repo: bigdatagenomics/adam


text:
Add eslint and fix lint errors

@golopot I can merge as soon as the conflicts are resolved :v:
Good stuff.

Do you have a preference on resolving merge conflict? Do you prefer it be done with a rebase and force push, or a new merge commit?

you can commit multiple times, I can squash when merging.

authors: bithavoc golopot

repo: bithavoc/express-winston


text:
Filtering fixes

Good :+1:

authors: RuslanHamidullin jaleszek

repo: bitzesty/qae


text:
Migration angular 7 to Angular 9

can you merge it plz ?

repo: bknds/ng-pi-admin


text:
dev: build failure does not stop tests from executing

This bug has existed since, it appears, v0.3.1. I am going to put it in v0.4.0 because it is pretty serious and is preventing lark from working as designed.

repo: bmatsuo/lark


text:
Instructions for prezto?

Bump. :)

Sorry, I have never used prezto so I'm not sure. If it's compatible with omz, then you should be able to use this repo as is. If not, maybe someone with some prezto experience can jump in?

Thanks for replying!
Prezto started as a fork and then became a rewrite of OMZ so I am not sure how much they differ at this point...

Just started looking into this. These completions are included in prezto as part of the 'completion' module (which pulls in https://github.com/zsh-users/zsh-completions as a submodule which includes these completions). But at least within my setup, the completions only work with git-flow, not git flow.

Thanks for the reply! That helps a lot. :)
Well, I could alias git-flow to gfl and keep using the completions. Cool!

authors: Cottser bobthecow fatuhoku iodic

repo: bobthecow/git-flow-completion


text:
AND-9120: Crash during collaborator role display

Verified that @nyjalusc has signed the CLA. Thanks for the pull request!

authors: boxcla nyjalusc

repo: box/box-android-share-sdk


authors: bpicolo lierica

repo: bpicolo/Bulletin


text:
Flex Line does not display legend

@ssunkara1 , can you provide details of this issue or close it?

2010-12-17 verified issue still present.

authors: acelere ibdafna ssunkara1

repo: bqplot/bqplot


text:
#82 edit profile features

Checks are passing. Look at this: https://github.com/brewmap/brewmap/pull/211/checks?check_run_id=1698574175
Without it we are not going to start any code review.

Checks are passing. Look at this: https://github.com/brewmap/brewmap/pull/211/checks?check_run_id=1698574175
Without it we are not going to start any code review.

okey, I will fix it.

okey, I will fix it.

repo: brewmap/brewmap


text:
Add R group to integration tests that use R.

:+1:

authors: akiezun tomwhite

repo: broadinstitute/hellbender


text:
removed the generated transport interfaces and classes

fyi @dwsupplee

repo: bshaffer/gax-php


text:
FIX-after release

@bugout-dev check

[ ] Merge spire https://github.com/bugout-dev/spire/pull/182

repo: bugout-dev/bugout-vscode


text:
Burczyk/master

Thanks! Pushed to CocoaPods.

Thanks.... I tried and (of course) I didn't have permissions. Also, it had a BUG which I fixed (it got introduced when I did the un-merge from my other branch). Can you push again 1.2.3?

Did you try the feature???

Yes, I tried it and pushed 1.2.3 to CocoaPods. Can you give me your email so that I can add you to CocoaPods trunk?

felipe DOT baytelman AT gmail

Done. You can remove your email if you want.

authors: baytelman burczyk

repo: burczyk/KBContactsSelection


text:
SOLID-396 Add Card Class to the Solid Docs Template

love it

btw i do notice that there is a minor minor style change border-wise from the left col to the card, but it doesn't bother me tbh.

Hey! This LGTM!
Re: the minor style change between left col and card - I think it's alright as well, we're just missing the the slight box-shadow on the nav, right? Think it's ok.
This can be solved in a follow up (as it's unrelated) ... but this generous spacing underneath the mobile nav is starting to feel egregious to me
https://www.dropbox.com/s/0rzdkm8afu3o63k/Screenshot 2016-11-07 09.24.55.png?dl=0
It's nitpicky, but I think we can remove unless there is some reason it's there I'm not aware of.
This is what it would look like w/ even margin around the mobile card
https://www.dropbox.com/s/29by1rdrwhoqtlo/Screenshot 2016-11-07 09.25.16.png?dl=0

fixed the padding on mweb!

authors: allisonchefec emilybrick lindseymaratta

repo: buzzfeed/solid


text:
Fixed some errors now it works with bs4

Thank you for your input. :)


text:
Fix gradle build

Thanks!

repo: callstack-io/react-native-fbads


text:
Refactor UnLink functions

A lot of refactoring, but resource management on link/unlink is correct now


text:
Add include_url default to pass through url into event

Nice @bobbysteel! We may want to wait until @knu's #1743 get's merged, since I think it solves this problem for you without a new custom key.  Do you agree?

Doh, I hadn't seen that commit. You're right, that solves it too I believe.

authors: bobbysteel cantino

repo: cantino/huginn


text:
Fix the PORT for issue #895

Looks good to me :+1:

Go ahead and merge @ianblenke :)

I'll have to login as @icblenke, as @ianblenke doesn't have commit access. We should definitely switch commit access over to @ianblenke going forward.

@icblenke @ianblenke Sorry about that, I'm switching it to @ianblenke now.

authors: cantino dsander ianblenke


text:
Upgrade Arduino.app to 1.6.5

Thank you for the contribution. It was merged directly as aa2fa3c6a8e413db1b4c84bd0441993b1578b844 to keep commit history cleaner. Your contribution is still credited to you.

authors: coreyjewett vitorgalvao

repo: caskroom/homebrew-cask


text:
Upgrade vimr to v0.7.3-31

Oops, already pulled this.


text:
Add Sling app for Sling TV

Could you please point me to the download page so I can verify the links (standard procedure for a maintainer to verify them when the download host is not the same as the homepage).

No problem. The download page can be reached from the FAQ (
http://help.sling.com/FAQs ). About halfway down is the link for the Mac
download.
On Tue, Feb 3, 2015 at 9:52 PM, Vítor Galvão notifications@github.com
wrote:

Could you please point me to the download page so I can verify the links
(standard procedure for a maintainer to verify them when the download host
is not the same as the homepage).
—
Reply to this email directly or view it on GitHub
https://github.com/caskroom/homebrew-cask/pull/9416#issuecomment-72781280
.

Thank you. Two things needs changing, then. Seeing as url doesn’t point to a specific version, this cask should use version :latest and sha256 :no_check. See an example.
In addition, please add a # movetv.com is the official download host per the vendor homepage comment above url.

Okay. I made the changes and added the comment. Let me know if it needs any additional changes.

Looks great, thanks @zerrot !

authors: rolandwalker vitorgalvao zerrot


text:
Add a photo Carrousel to Life at the Ridge section

https://www.w3schools.com/bootstrap/bootstrap_carousel.asp

repo: cbkrol/PoC-Ridge-Website


text:
Use Map and Set instead of {}

Warning for small number of elements it's possible that {} is better

repo: cedricpinson/osgjs


text:
test/s3select_test: substr & nested string function

@galsalomon66 Please review this.


text:
Add unit test.

Added basic chai test.

repo: cgerull/express-app


text:
Skipping Files that Already have Desired Require Statement

Not sure how to approach the tests. It seems we have a single input/output file per codemod. These changes would require 2 different inputs (1 with the desired require statement and one without it)

@gordillo99 see https://github.com/facebook/jscodeshift/blob/master/README.md#definetest.  It supports multiple test fixtures.

repo: change/javascript


text:
Need centralize Logging for the A2HA

Acceptance Criteria

Logs aggregation should works for both cloud and non cloud solution.
In Case customer don't want centralize, they can still use the current approach.

Definition of Done

Need to ship the log from a2ha cluster to the centralised place.
We need to keep logs separated automate, chef-server, PG and ES logs
We need to do Logs rotation at the centralised place (to make sure that disk goes out of space).

Testing Steps

repo: chef/automate


text:
bump to 0.12.0 and adding changelog

:+1:

:+1:

authors: jkeiser mwrock smurawski

repo: chef/chef-dk


text:
Possible fix for issue #20

This works for me, but I can't say I'm an experienced coder, and it might conflict with something you've written (even if it's just one line).

repo: chengyin/WhatFont-Bookmarklet

license: NCSA


text:
try out coroutines 1.5.0-RC

main uses 1.5 now

repo: christophsturm/failfast


text:
bad path to wdi ontology

Thanks.

np -- realized later it's also fixed in another bigger PR that isn't merged
yet -- so sorry for the extra work!
On Thu, May 3, 2018 at 11:54 PM, Keith Alcock notifications@github.com
wrote:

Merged #304 https://github.com/clulab/eidos/pull/304.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/304#event-1609203914, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AFIniWjLRAktcwQBcgg9O6pI58Goe3wTks5tu_srgaJpZM4TyLEp
.

authors: bsharpataz kwalcock

repo: clulab/eidos


text:
fix label tag

thanks Guto!

authors: cmdalbem gutobenn

repo: cmdalbem/bikedeboa


text:
Training: Add LFW validation for testing.

I have some code with LFW testing. But it does not work with "donkeys". Main issue is that with data I have to send the paths to images, which are strings. And sending tensor only works with Long or Float Tensors.
My code do following stuff:

Read images from disk do DataLoader.
Extract features from images, in serial manner.
Based on patches to images and file "pairs.txt", computer distance between images.
Search best threshold for all images at once (no split to folds)

What do you think about it?

Hi @melgor - I was planning on:

Freeing the training GPU memory.
Calling batch-represent on LFW data with the latest model,
using all GPU memory with only batched forward passes.
Calling the Python LFW experiment to output results in the work dir.

The advantage I see of this is that we can leverage a lot of existing code
and won't have to maintain or debug inconsistencies between
two separate LFW implementations.
The disadvantage is that externally calling programs seems hacky.

Hi @melgor - I just added my implementation of this to the commit attached to the issue.

Note: It doesn't correctly plot the ROC curve, but accuracy is good enough for me now

authors: bamos melgor

repo: cmusatyalab/openface


text:
Bind TextureData and ContourData

Tested with user project on Mac


text:
Update es-ES.coffee

Hi, @javatlacati! Thanks for your translations :+1:

repo: codecombat/codecombat


text:
Show viewer count on the receiver page

me and rich got this

@pociust I almost have an implementation of this finished using updateExtraData on the connection, let me know if you find a better way for receiverconnection to get viewer count

Fixed in #118

authors: codysherman mjneff2 pociust samtheprogram


text:
WIP add windows support

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@basnijholt that rerender removed all the windows stuff!

It claims the windows build succeeded, but if you look at the Appveyor logs you'll see that it didn't actually do anything!

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [29]

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Ok it builds but there are 3 tests failing. The logs are all mangled (looks like appveyor might be running several things in parallel and interleaving the output) so it's difficult to tell what's going on, but it seems that what is failing is:

test_rcond_from_lu: there is a comment above the failing test that seems to imply that the test should not be too strict. I do not know enough about this specific issue to tell whether we should just disable the test
test_symm_algorithm_equivalence: Seems our check triggers some internal assertions withing numpy? A serious WTF going on in here.
test_finalization: the check that all the sites in the system are also in the builder fails. WTF

To add insult to injury, appveyor for some reason decides that the build succeeds despite the failing tests: https://ci.appveyor.com/project/conda-forge/kwant-feedstock/build/1.0.29

Action plan
test_rcond_from_lu: we just have to decide whether this test is important. My vote would be just to disable it on windows
test_symm_algorithm_equivalence: the apparent exchange of the degrees of freedom could be due to assumptions we make about the way eigenvalues are ordered, maybe in some very degenerate case? We would need to look at the relevant code in Kwant to see where the problem could be, and investigate in isolation on our own machines (because modifying Kwant and getting conda forge to rebuild is far too slow).
test_finalization: could be due to the fact that we are comparing tinyarrays with tuples. On linux assert tinyarray.array([1, 2]) in  {(1, 2)} works, but maybe (for some crazy reason) this is not the case on windows

@basnijholt you have a windows machine: we should block a few hours to debug this.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

For recipe:

Using toolchain directly in this manner is deprecated.  Consider using the compilers outlined here.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you, but it looks like there was nothing to do.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you, but it looks like there was nothing to do.

Hi! This is the friendly automated conda-forge-linting service.
I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@basnijholt merge time :tada: :tada:

authors: basnijholt conda-forge-linter jbweston

repo: conda-forge/kwant-feedstock


text:
Added info about loading console with "googfc"

Thanks! :smile:


text:
Fix link to the Changelog file

:+1:  Thanks for catching that!

authors: jlbooker rbu


text:
Add metals and bloop artefacts to .gitignore

Thanks @engelsdamien!

authors: alexarchambault engelsdamien

repo: coursier/coursier


text:
fix typo

Codecov Report

Merging #191 into master will not change coverage by %.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   86.18%   86.18%
=======================================
  Files          19       19
  Lines         550      550
  Branches       89       89
=======================================
  Hits          474      474
  Misses         45       45
  Partials       31       31

Impacted Files
Coverage Δ

src/client/analytics.ts
87.12% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cee5a41...7f4fd5e. Read the comment docs.

authors: cnguyen-coveo codecov-io


text:
Add next and previous bus stop links on bus stops API

Merged, thanks!

repo: craftsmanship-toledo/katangapp-backend


text:
second

annoying

repo: creekstone/github-slideshow


text:
Fix #6

Please squash and merge.


text:
Add LineFeed support to SourceLink.Fake

Make the LineFeed support from SourceLink.exe, available to SourceLink.Fake too.
SourceLink.exe support:
https://github.com/ctaggart/SourceLink/pull/82

I plan to release 1.1.0 tomorrow at my talk in SF. This looks easy, but will need to slip to the next release.

ping

hello, has there been any progress with this?

I'm working on v2 which will support the actual /sourcelink option from the F# & C# compilers. I will be providing an option to autofix the line ending which will be on by default. That will be tracked in #119. Initially v2 is just going to be dotnet +msbuild nuget packages as describe in #130. Adding a FAKE wrapper #114 can be reopened after 2.0.0. I'm curious how FAKE is going to wrap the dotnet executable and its extensions.

authors: ctaggart ovatsus sideeffffect

repo: ctaggart/SourceLink


text:
ALTER TABLE support for renaming tables

I saw that @diegomestre2 self-assigned this issue. Can I give it a try?

Yes, go ahead! Remember that for ALTER TABLE normal transactional semantics should apply, i.e. the following should work:
BEGIN TRANSACTION;
-- perform the rename
ALTER TABLE tbl RENAME TO tbl2;
-- this should work, tbl is renamed
SELECT * FROM tbl2;
-- rollback the rename
ROLLBACK;
-- this should work again, rename is reverted
SELECT * FROM tbl;
-- now rerun and commit
BEGIN TRANSACTION;
ALTER TABLE tbl RENAME TO tbl2;
COMMIT;
-- now the change should be committed
SELECT * FROM tbl2;

The case with multiple clients should also be tested, i.e. if there are two parallel transactions running changes made by the other transaction should not be visible. For example:
C1: BEGIN TRANSACTION;
C2: BEGIN TRANSACTION;
-- renamed in C1
C1: ALTER TABLE tbl RENAME TO tbl2;
-- C2 still has the old table name
C2: SELECT * FROM tbl;
-- this should not work
C2: SELECT * FROM tbl2; -- FAIL
-- but C1 should be able to query the old table
C1: SELECT * FROM tbl;
-- after both commit, the table has been renamed in both connections
C1: COMMIT
C2: COMMIT
-- i.e. the following should work again
C1: SELECT * FROM tbl2;
C2: SELECT * FROM tbl2;

This has been added now

authors: Mytherin tiagokepe

repo: cwida/duckdb


text:
Possible to hide all checkboxes but maintain row select ability?

I suppose you could hide the checkboxes with CSS.
.md-checkbox-column,
.md-checkbox-cell {
  display: none;
}

Also work with ng-click on your <tr>:
   <tr md-row ng-click="doAction" ng-dbclick="doDbAction()">...</tr>

It can be used for cells as well, like <td ng-click>

CSS did the trick. Thanks.

authors: daniel-nagy jbdivups leocaseiro

repo: daniel-nagy/md-data-table


text:
purchasing to UAT

Coverage decreased (-0.06%) to 31.092% when pulling 5c97e800911690d6a8af1a0260f72af1653f9ffe on dev into a4399c24dc012bf7c4a427583ac5021e6530e1ca on uat.

authors: coveralls edo-moonlay

repo: danliris/bateeq-module


text:
Android custom keyboard has out-of-date dependent library versions and instructions

Wrong GitHub account, sorry.

repo: dasher-project/redash


text:
Fixed prepublish that deprecated in npm@5

Coverage remained the same at 99.855% when pulling cbce3425012e3f83a220b293c2627b50e0bcac94 on gnought:patch-2 into 144bba912edad3708aa3004ab01374c949ac4684 on dashersw:master.

authors: coveralls gnought

repo: dashersw/cote


text:
Add Julian Schiavo's Blog

Thanks!

😃

authors: daveverwer justJS

repo: daveverwer/iOSDevDirectory


text:
Dependent attributes empty in materialization after insert of new order

Done.

repo: debezium/microservices-lab


text:
Add workshop and talk links -- Chandu Tennety

@tennety Can you resolve conflicts and submit again? Thanks!

@jdegoes this better? Thanks again!

authors: jdegoes tennety


text:
Made connection settings configurable

LGTM

authors: emulbreh mouadino

repo: deliveryhero/lymph


text:
Master

v1.0.2

repo: denhaphp/framework


text:
chore: update deps

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant lucacasonato


text:
Fix random web-framework test failures for the Firefox browser.

@agozhiy please review the PR.

+1.


text:
Results overview screen

Init:

Repeat: count isnt reset

Result screens:

Repeat button isn't showing up

authors: DaveOuds ayashanaa

repo: digitalfabrik/lunes-app


text:
Fixed #25567 -- Removed obsolete MEDIA_URL fallback in Media.absolute_path

Note that FormsMediaTestCase and StaticFormsMediaTestCase were almost identical except of the different STATIC_URL setting (and the test_html_safe test which I kept).

repo: django/django


text:
Add Windows Service and Setup

测试

OK
| |
milomiros
邮箱：milomiros@163.com
|
Signature is customized by Netease Mail Master
On 03/25/2019 21:26, Justin Clift wrote:
Hmmm, seems like that MS team version is now outdated too. 😦
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

ok

authors: gyhappy hztion milomiros rgl

repo: dmajkic/redis


text:
unit tests

Closing for now


text:
Add option to periodically check for Drupal core and module updates and send notifications to e-mail

Closing this as this project is unfortunately not active anymore.


text:
Add separator on __toString function of Expr/Composite.

Can you add a test to tests/Doctrine/Tests/ORM/QueryBuilderTest.php to show why this is necessary change?

Hum.. It's more easy to do a pull-request than create a new test :p
I'll do that when I can.

you can just push a new commit to the patch-4 branch and it will automatically be added here.

I have posted this pull-request without testing, It seems to be ok with all requests.

authors: armetiz beberlei


text:
Merge to master for 3.0 release

Coverage increased (+0.03%) to 97.541% when pulling 78b2fc427d5436b22d2df53d5129fdaa30e6eb56 on major into 1822e56f4b3f7d6cc09b395e3299b867f0a87577 on master.

authors: coveralls matthewp

repo: donejs/generator-donejs


text:
Fix the URL to the list

Thank you @CraigCottingham, good catch 👍

authors: CraigCottingham doomspork

repo: doomspork/elixir-companies


text:
add all the iface options

Thank you for your pull request.
But your changes seem unnecessary

post-up is an alias for up
and pre-down is an alias for down.

I think it could help to migrate existing configurations to Ansible. This way existing configurations do not have to be changed when using the aliases.

@berendt good point. If config allows it, we may as well.

Can someone please resolve the pull request?

authors: SoundGoof arBmind berendt


text:
RHBPMS-160 - Fix missing i18n strings

+1 to merge. Thanks @cristianonicolai

authors: cristianonicolai manstis

repo: droolsjbpm/guvnor


text:
BZ1283711: Console: unsupported locales results in mixed languages in BC

+1 thanks @nmirasch

Merged into 6.4..x

authors: cristianonicolai nmirasch psiroky

repo: droolsjbpm/jbpm-console-ng


text:
Implement test coverage using the examples folder

Solved via #10.

repo: drunomics/nuxt-module-drupal-ce


text:
updated css for query from

galat baat @shekharAggarwal merging ka kam mera hai

authors: shekharAggarwal soyo-kaze


text:
Added pankod/next-boilerplate

Merged. Thanks @puskuruk !

authors: dzharii puskuruk

repo: dzharii/awesome-typescript

license: unlicense


text:
Removed redundant mongo import and creation

@nathanathan Here is where I removed the redundant mongodb steps

👍

authors: frosario nathanathan

repo: ecohealthalliance/bsve-integration


text:
修复IE11下, svg图无法显示的bug

修复IE11下, svg图无法显示的bug

Close due to out-of-date.

repo: ecomfe/zrender


text:
Update header.hbs

I'm closing this PR because those changes are only relevant to you and because you're modifying the templates directly.
If you want to add translations please do it in the corresponding locale file.
It would be great if you can create a PR and add these translations in the files /locales/pt.json and /locales/pt-br.json, that way the templates remain as they are and more people would benefit from your changes.

authors: eddiesigner orufasspt

repo: eddiesigner/liebling


text:
Replace Spectrum badge with GitHub discussions

Something went wrong with this one, sorry

repo: edgedb/edgedb


text:
Remove stylesheets and font-loader from webpack

Coverage remained the same at 100.0% when pulling 9d880d5522e506172c6bf45163c36a37d13131da on cleanup-webpack into 6a1b8246935530c7447078dd58cf12f72f0757bb on master.

authors: coveralls elbracht

repo: elbracht/portfolio


text:
dummy space. trigger CI

Oops, thanks for the reminder. Travis changed some stuff couple weeks ago and I haven't updated our scripts yet. I think I have the fix.

sorry, the PR was suposted to be  on my fork...
Anyway, its most likely related to that issue:
https://forums.mysql.com/read.php?11,677237,677268#msg-677268

authors: ludwikbukowski wojtekmach

repo: elixir-ecto/myxql


text:
Deferred sending: Send events over Web-Worker

discarded. This should be a tracker's responsibility and internal implementation.

repo: ember-insights/ember-insights


text:
Modernize embulk-filter-rename with v0.11-ready API/SPI

Thanks!

repo: embulk/embulk


text:
get playlist is not working .. it always showing this error UnhandledPromiseRejectionWarning: Error: invalid playlist id.

Could you give the script you used ?

repo: emresenyuva/youtube-music-api


text:
fix(readme): improving README example

:tada: This PR is included in version 1.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: galbash ranrib

repo: epsagon/epsagon-node


text:
Fix links on page; change gotten to received.

because my nostrils are quite sensitive.

This is a helpful and relevant comment and not at all just a test for the slack integration. Promise.

authors: antihax lukasni

repo: esi/esi-docs


text:
v22.8.42 update composer dependencies

Codecov Report

Merging #718 into master will not impact coverage.

@@           Coverage Diff            @@
##             master   #718    +/-   ##
========================================
  Coverage       100%   100%
- Complexity        0    187   +187
========================================
  Files            29     29
  Lines           439    439
========================================
  Hits            439    439

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ea09d...ba017e3. Read the comment docs.

authors: codecov-io eugene-matvejev

repo: eugene-matvejev/battleship-game-api


text:
Upgrade to swift-4.1    and    fix iOS-11 save to library crash

Did you fix drawing problem?
Let me thanks

hi,
it seems that there some more issues with swift 4  (xcode 4.9.1) or I missing somthing?
thanks

authors: lillogoal mhmdrmdn94 yedidel

repo: eventtus/photo-editor


text:
Word count

Wrong base branch…

repo: exercism/erlang


text:
added two resources and minor changes

It's alright. I'll tidy up the changes.

It's alright. I'll tidy up the changes.

authors: kristoff-it massivelivefun

repo: exercism/zig


text:
Use task instance ID to identify remote task uniquely

Explain what problem this addresses in the commit message

You can squash the first two commits into a "Remove unused method and field"

I think the last commit would be simpler if you required the task instance id to always be present.

@dain Updated

Looks good

authors: dain martint nileema

repo: facebook/presto


text:
Add accuracy, nukes, creation date, and last played class, change js region to New York, fix leaderboards

Thanks for PR.


text:
Update .cirrus.yml

Codecov Report

Merging #1 into fedor/configure-cirrus-ci will increase coverage by 0.02%.
The diff coverage is n/a.

@@                      Coverage Diff                      @@
##           fedor/configure-cirrus-ci       #1      +/-   ##
=============================================================
+ Coverage                      71.48%   71.51%   +0.02%
=============================================================
  Files                            151      151
  Lines                           3616     3616
  Branches                         208      208
=============================================================
+ Hits                            2585     2586       +1
+ Misses                          1031     1030       -1

Impacted Files
Coverage Δ

.../main/scala/com/twitter/summingbird/Producer.scala
81.91% <0%> (+1.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0024d65...fa79f39. Read the comment docs.

authors: codecov-io fkorotkov

repo: fkorotkov/summingbird


text:
Added Key num_0

thank you!

authors: YannickStein florianholzapfel

repo: florianholzapfel/panasonic-viera


text:
Create GIF-Maker

Thank you for your contribution. I have a few requests:

please follow the template used in other ideas (use checkboxes, layout it nicer, etc)
add it on the main README.md page in the corresponding table

I've closed it for now. Please make a PR and put both the file and update the table in README.md


text:
feat: include shortcodes

不好意思，我忘记为什么PR

repo: flysnow-org/maupassant-hugo


text:
Add logo

Thanks!

authors: igoradamenko savonarola

repo: funbox/smppex


text:
鳥取中部地震対応のクライシスマッピング作業

建物のみクライシスマッピングタスクはこれです。
http://tasks.hotosm.org/project/2246

平成28年鳥取県中部の地震 正射画像（2016年10月22日撮影）
タイルURL：http://cyberjapandata.gsi.go.jp/xyz/20161021tottori_1022dol/{z}/{x}/{y}.png
source:
http://maps.gsi.go.jp/development/ichiran.html#20161021tottori_1022dol

投稿例：
JOINしました！

JOINしました！

JOINしました！

JOINしました！

JOINしました！

JOINしました！

JOINしました！

JOINしました！

JOINしました！

JOINしました！

JOINしました！

JOINしました！

JOINしました！

JOINしました！

JOINしました！

url

)

JOINしました！

repo: furuhashilab/mapping

license: Unlicense


text:
RADseq reference tuto improvement

thanks @yvanlebras!

authors: shiltemann yvanlebras

repo: galaxyproject/training-material


text:
Was grabbing wrong G+ ids

Thank you for PR, but can you squash commits? 4 commits to change one word - to much noise

authors: bastosmichael gazay


text:
Create script for applying jackson shading to a jar

Merged into develop

#Migration Steps
Before added the iterator jars to accumulo you should run jar-shader against all the jars. This will shade the jackson version and force Accumulo/Gaffer to use the correct version. Without this you may come across issues on clusters using CDH. This is linked to issue gchq/Gaffer#749 and gchq/Gaffer#722.

repo: gchq/gaffer-tools


text:
linux如何从dock启动app？每次都要从终端启动吗

你可以自己创建一个快捷方式。参见#166。
如果你是要使用最新版本，你可以把
Exec=electron /path/to/github/electronic-wechat/src
Icon=/path/to/any-icon/your-want/wechat.png
详细参见#166

authors: Jonham threezj

repo: geeeeeeeeek/electronic-wechat


text:
add HGVS expression to gene adv search

Backend support exists for this. Parameter name is hgvs_expressions and it supports all the standard string operations (like we use for name, description, etc)

authors: acoffman jmcmichael

repo: genome/civic-client


text:
Include star ratings explanation on static help page

It looks like this content was added in the CIViC Google spreadsheet.  Just need to add a first version on the static help page now.

authors: acoffman malachig


text:
另外，要是上传后，希望能够显示markdown图片格式

markdown图片格式是指？自动生成  ?

@Seifon 建议使用 dev-wiki推荐的chrome扩展 :)

authors: Seifon git-patrickliu

repo: git-patrickliu/QINIU-save-online-images


text:
List all branch is WIP

Thanks for the PR, but please have a look at contributing.md and make the changes are per it.

@hemanth Updated

authors: NamPNQ hemanth

repo: git-tips/tips


text:
Learn open gl

No worries and welcome to GitHub!

authors: elmindreda tvinhkhai

repo: glfw/glfw

license: Zlib


text:
"gvalid  length" compatible with only one parameter

Codecov Report

Merging #1268 (b2d3c7d) into master (5100e0e) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
- Coverage   69.12%   69.03%   -0.09%
==========================================
  Files         373      373
  Lines       26513    26514       +1
==========================================
- Hits        18328    18305      -23
- Misses       6649     6666      +17
- Partials     1536     1543       +7

Impacted Files
Coverage Δ

util/gvalid/gvalid_validator_rule_length.go
100.00% <100.00%> (ø)

os/gspath/gspath_cache.go
67.56% <0.00%> (-24.33%)
:arrow_down:

net/gtcp/gtcp_pool.go
34.84% <0.00%> (-4.55%)
:arrow_down:

os/gmutex/gmutex.go
94.59% <0.00%> (-2.71%)
:arrow_down:

net/gtcp/gtcp_conn.go
30.53% <0.00%> (-1.53%)
:arrow_down:

os/glog/glog_logger_rotate.go
71.85% <0.00%> (-1.49%)
:arrow_down:

container/gtree/gtree_avltree.go
92.49% <0.00%> (-1.08%)
:arrow_down:

container/gtree/gtree_redblacktree.go
87.47% <0.00%> (-0.42%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5100e0e...b2d3c7d. Read the comment docs.

repo: gogf/gf


text:
stat/distmv: rename NewNormalChol and add Sigma as an input argument

I'm not sure this is the best name, but I can't think of anything better.

Fixes #47

Do you have any ideas for the name?

No unfortunately - I would have suggested one if I did.

What exactly is the reason for retaining this now since #47 says it's signficant raison d'être of saving allocation no longer exists?

It saves the cost of computing Sigma, which is an O(n^3). Thinking though, it may be better to export particular functions (like LogProb), where the Cholesky is already known. This saves all of the overhead (allocation, computation of sigma, etc.)

We've done more of the latter. If there's a compelling use case, we can reconsider.

authors: btracey kortschak

repo: gonum/gonum


text:
Solidify CSS/JS Class Name Prefix

+1, it would be nice to use custom prefixes to prevent css conflicts when someone can redefine the standard prefix (for example, is actual for browser extensions).

authors: monolithed traviskaufman

repo: google/material-design-lite


text:
Add .meta files for Sample projects

This is a redo of #77 with a few changes:

only adding .meta files for Sample projects per suggestion from @jamcohen
copy the .meta files for the SphereBlast project from our Unity Asset Store entry so assets will be wired up correctly
created new .meta files for the TestApp project, but copied the guid for TestApp.cs.meta from the TestApp.unity file

It seemed simpler to create a new PR since there were so many differences from before.

repo: google/play-instant-unity-plugin


text:
Do not serialize _non_exhaustive field

Good catch; thanks!

repo: google/tarpc


text:
Add panel -video to design system

Ticket added to keep track of new design system components - unnecessary for dashboard, not part of initial set up to start using design system external to dashboard.

Work was done outside of this ticket by prometheus, closing as duplicate.

repo: google/web-stories-wp


text:
Remove TODO for resolved resources/ folder issue

LGTM

Current coverage is 78.63% (diff: 100%)

Merging #562 into master will not change coverage

@@             master       #562   diff @@
==========================================
  Files           248        248
  Lines          9206       9206
  Methods           0          0
  Messages          0          0
  Branches       1212       1212
==========================================
  Hits           7239       7239
  Misses         1656       1656
  Partials        311        311

Powered by Codecov. Last update 94327e4...f0f066a

repo: googleapis/toolkit


text:
Sa

A

repo: googlearchive/OpenInChrome


text:
Made DevApp project build with GoogleMaps 2.x

LGTM

authors: domesticmouse mountainvat

repo: googlemaps/google-maps-ios-utils


text:
Remove @Ignore from fixed transform action test

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

authors: bamboo bot-gradle

repo: gradle/gradle


text:
Update to latest nightly

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test and merge

OK, I've already triggered a build for you.

authors: big-guy bot-gradle rieske


text:
fix minor typo in layout

Thanks!

authors: gragland twhitbeck

repo: gragland/usehooks


text:
Changing karma test path to src/test/javascript

@craigburke I was in there already and just made this change. Great suggestion!

@Schlogen cool! :+1:

authors: Schlogen craigburke

repo: grails/grails-profile-repository


text:
Prettier pre commit hook

Please squash

I'm approving this to make merging this PR easier

Hi there! Should this actually update the commit, or warn the committer? I just met an issue when opening #568 that I understand may have to do with this, explained here.
Commenting here to keep track of the related issue. Thanks for your help and work :)

@astorije: I'll reply on #568.

authors: AGS- asiandrummer astorije wincent

repo: graphql/graphiql


text:
Add lang="en" to the html start tag.

What if the user is browsing Gratipay using another language https://github.com/gratipay/gratipay.com/tree/master/i18n/core

Thanks for the informative response. Does anyone have any suggestions as to how the lang attribute could be implemented?

@EdOverflow https://github.com/liberapay/liberapay.com/blob/147/templates/base.html#L2

Ah, nice! Thank you @Changaco.

authors: Changaco EdOverflow clone1018


text:
[Feature Request] Ability to add custom classes

Closing this as we do not use this option anymore. :)

Is there a way to do this now?

Hello @ndelvalle, the library now comes with two themes (light and dark).
There are no options to add custom classes.

authors: LeCoupa Nisthar ndelvalle

repo: growthbunker/vuedarkmode


text:
Feature/#50 統計量をまとめて計算するメソッドを追加

Codecov Report

Merging #51 (8dbb9c1) into develop (8c6efbf) will decrease coverage by 4.74%.
The diff coverage is 21.79%.

@@             Coverage Diff             @@
##           develop      #51      +/-   ##
===========================================
- Coverage    85.38%   80.64%   -4.75%
===========================================
  Files           28       29       +1
  Lines          951     1028      +77
===========================================
+ Hits           812      829      +17
- Misses         139      199      +60

Impacted Files
Coverage Δ

kabutobashi/method/adx.py
79.48% <0.00%> (ø)

kabutobashi/utilities.py
31.32% <10.00%> (-19.84%)
:arrow_down:

kabutobashi/method/fitting.py
31.42% <31.42%> (ø)

kabutobashi/__init__.py
100.00% <100.00%> (ø)

kabutobashi/method/__init__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c6efbf...8dbb9c1. Read the comment docs.


text:
gtk: add SelectionModel subclassing support

Thanks, @sdroege

@kavanmevada Why did you close this PR? Seems like not much is missing here to get it merged :)

@kavanmevada Why did you close this PR? Seems like not much is missing here to get it merged :)

Sorry I can't keep doing things like this not good for me.
I truly appreciate your all reviews and your valuable time in project like
this, and thanks again for reviewing all my commits so fast, thanks a lot ❤
There are some people who can finish all my half done work.
On Mon, 4 Jan, 2021, 9:55 pm Sebastian Dröge, notifications@github.com
wrote:

@kavanmevada https://github.com/kavanmevada Why did you close this PR?
Seems like not much is missing here to get it merged :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gtk-rs/gtk4-rs/pull/132#issuecomment-754073802, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AE2RBUXCCIKOCDMRXAUOWO3SYHTZJANCNFSM4VCULMZQ
.

Sorry I can't keep doing things like this not good for me.
I truly appreciate your all reviews and your valuable time in project like
this, and thanks again for reviewing all my commits so fast, thanks a lot ❤
There are some people who can finish all my half done work.
On Mon, 4 Jan, 2021, 9:55 pm Sebastian Dröge, notifications@github.com
wrote:

@kavanmevada https://github.com/kavanmevada Why did you close this PR?
Seems like not much is missing here to get it merged :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gtk-rs/gtk4-rs/pull/132#issuecomment-754073802, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AE2RBUXCCIKOCDMRXAUOWO3SYHTZJANCNFSM4VCULMZQ
.

@kavanmevada Thanks for all your work and sorry to hear that you won't continue being involved here. Good luck with whatever else you're going to spend your time on :)
Let's re-open this then. @bilelmoussaoui, do you want to finish it?

@kavanmevada Thanks for all your work and sorry to hear that you won't continue being involved here. Good luck with whatever else you're going to spend your time on :)
Let's re-open this then. @bilelmoussaoui, do you want to finish it?

Sure thing

Sure thing

authors: bilelmoussaoui kavanmevada sdroege


text:
enable Dependabot v2

Thanks! Could you add the right license header via mvn license:format?

Thanks! Could you add the right license header via mvn license:format?

done

Applied, thx!

authors: gunnarmorling sullis

repo: gunnarmorling/jfrunit


text:
Start of belle

•	Threatens to cut someone's limbs off
•	Cuts someone's arm(s) off
•	Cuts someone's leg(s) off
•	Suggests the team does a murder
•	Makes a dexterity check

authors: allena-x halkeye

repo: halkeye/critshow-bingo


text:
Fix #254 Improve description when byte value is mismatched

Looks good, thanks @jamesmudd

authors: jamesmudd tumbarumba

repo: hamcrest/JavaHamcrest


text:
use PointerEvent instead of MSPointerEvent if supported.

Please don't edit the concatenated output files, but the source files.

going to close this since it has not been updated as requested

authors: arschmitz jtangelder miguelmota


text:
When will vscode v1.52.1 be supported

You can downgrade the extension to version 2.20.1, which still works in VSCode 1.52.1:
Go to the extensions sidebar and click the gear button at the right of this extension's entry, choose "Install Another Version..." and then "2.20.1".

I have VSCode 1.55 version and doesnt show the extension icon on sidebar ☹

authors: JoeEmp alambertt hbenl

repo: hbenl/vscode-test-explorer


text:
Add StorageOS charts repo

The Artifact Hub, a CNCF sandbox project, is another place you can list your repos. To do that, you login (or create an account), create an organization, and list your repository. You can link it to a user or organization.

authors: darkowlzz mattfarina

repo: helm/hub


text:
Merge heroku's base build pack into our custom version

BTW: You can have the mainline buildpack install vendored main packages (like goose).

@freeformz Thanks for the heads up! I am exited to be able to get back to using the standard buildpack instead of our one-off.

authors: egravert freeformz

repo: heroku/heroku-buildpack-go


text:
Collapse epsilons

Coverage increased (+0.3%) to 83.905% when pulling 3eaab1b45b6e62392ca8218502f6470d9dfa9927 on collapse-epsilons into fa835953dfda4b3b4cbae0e36d2288ffd88c5ac6 on master.

authors: coveralls vidyaap

repo: hicsail/constellation-js


text:
Timezone sign must be positive for timezones like +05:00

Currently the timezone for +05:00 would be -300. Correct would have been 300.
Planned for 2.3.x as this is not backwards compatible.

This is correct now.

Thanks for fixing this! Would this also explain why I am getting positive values (e.g. 420) for negative timezones (e.g. -07:00)?

If you mean pre-2.3.0 then yes, this was the problem. With 2.3.0 and up this should no longer be the case. If you keep getting different-signed values, please report an issue.

authors: highsource shawnExplore

repo: highsource/jsonix


text:
AssertionError: Error: the input policy for the DDPG model must be an instance of DDPGPolicy.

I also get this message using the example at:
https://stable-baselines.readthedocs.io/en/master/modules/ddpg.html
model = DDPG(MlpPolicy, env, verbose=1, param_noise=param_noise, action_noise=action_noise)

Traceback (most recent call last):
File "/home/pawu/devel/rl-autopilot/lunar_lander/baselines/main.py", line 45, in
File "/home/pawu/devel/rl-autopilot/lunar_lander/baselines/main.py", line 27, in main
File "/home/pawu/devel/rl-autopilot/lunar_lander/baselines/main.py", line 18, in get_models
DDPG(MlpPolicy, env, actor_lr=LEARNING_RATE, critic_lr=LEARNING_RATE, gamma=GAMMA, verbose=1),
File "/usr/lib/python3.5/site-packages/stable_baselines/ddpg/ddpg.py", line 270, in init
self.setup_model()
File "/usr/lib/python3.5/site-packages/stable_baselines/ddpg/ddpg.py", line 277, in setup_model
assert issubclass(self.policy, DDPGPolicy), "Error: the input policy for the DDPG model must be "
AssertionError: Error: the input policy for the DDPG model must be an instance of DDPGPolicy.

@Pawull try replacing MlpPolicy (class) by "MlpPolicy" (string), if this works, you are not importing the right MlpPolicy (please double check the example in the doc).

@araffin My bad, I indeed used the wrong policy while trying to use multiple different MlpPolicy implementations. Thanks.

authors: HareshMiriyala Pawull araffin

repo: hill-a/stable-baselines


text:
no rete algorithm?

Hello, if there is a need to find the following rule set, we will find the value of two library.name are eq go-ruler, in order to increase the efficiency of the query, rete algorithm should be used, the combination library.name this condition, thank you
{
    [
      { "Comparator": "eq", "path": "library.name", "value": "go-ruler"},
      { "Comparator": "gt", "path": "library.age", "value": 0.5}
   ],
   [
     { "Comparator": "eq", "path": "library.name", "value": "go-ruler"},
     { "Comparator": "gt", "path": "library.age", "value": 0.8}
   ]
}}

repo: hopkinsth/go-ruler


text:
CI for Node

Initializes with two players

repo: horiuchi-ng/github-actions-for-ci


text:
Update SOCKS5 proxy example

Codecov Report

Merging #132 (59560b7) into master (b78b8e5) will decrease coverage by 0.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   95.61%   95.20%   -0.42%
==========================================
  Files          10       10
  Lines         662      647      -15
==========================================
- Hits          633      616      -17
- Misses         29       31       +2

Impacted Files
Coverage Δ

ruia/spider.py
93.92% <0.00%> (-0.84%)
:arrow_down:

ruia/response.py
96.25% <0.00%> (-0.46%)
:arrow_down:

ruia/request.py
98.07% <0.00%> (-0.02%)
:arrow_down:

ruia/middleware.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b78b8e5...59560b7. Read the comment docs.


text:
希望可以增加修改码率的方法

可以在源码里面改, 目前我是这样做的.....他源码写死了128kbps, 详见AudioRecorder#DEFAULT_LAME_MP3_BIT_RATE


text:
Add /count/ method

Add both /count and /<index_without_prefix>/count methods that use the same logic as the corresponding /search methods to decide which index to call, but calls the ES _count method instead of _search.

Add both /count and /<index_without_prefix>/count methods that use the same logic as the corresponding /search methods to decide which index to call, but calls the ES _count method instead of _search.

repo: hubmapconsortium/search-api


text:
apollo publish destination配置错误

重新fork代码吧。。这里混着其他的 commit

重新fork代码吧。。这里混着其他的 commit

好

Pr我先close了，你重新提一个pr，感谢

authors: limingxinleo qingpizi

repo: hyperf/hyperf


text:
feature: phar build add --no-dev

如果说 ci 暂时还过不了，就先把 软连接的问题处理下吧，重新提个 pr

好的晚点处理下

authors: cq-z limingxinleo


text:
Docs » Tutorials » Chaincode for Operators

finished

repo: hyperledger-labs/fabric-docs-cn


text:
Handle errors from server

Coverage increased (+0.6%) to 27.652% when pulling 114815308eb36661d6444533a4428327d1c76fdb on handleErrorsFromServer into 7ae3c6f2e35043077ba7922e70213795f5673aa3 on development.

authors: coveralls odedBetzalel


text:
最新版本响应式失效

参考 #608

authors: geekrainy moistrot

repo: iissnan/hexo-theme-next


text:
Add #ifdef for changes in c8e38df to allow building on LLVM > 3.5 again.

LGTM, thanks for the fix. I will test on my end and merge if there are no problems.

Fixes #702

Hold off on this for a minute.
I might have been a bit hasty...and this won't fix the leak in 3.5...

From what I gather reading though 3.5, c8e38df did introduce a leak.
Unless there is an objection I'm going to update this to fix the leak as well as compilation errors for 3.6+.

Yes,  please.
On February 6, 2017 12:34:59 PM PST, marsupial notifications@github.com wrote:

From what I gather reading though 3.5, c8e38df did introduce a leak.
Unless there is an objection I'm going to update this to fix the leak
as well as compilation errors for 3.6+.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/imageworks/OpenShadingLanguage/pull/703#issuecomment-277805036

--
Larry Gritz
lg@larrygritz.com

Ok, updated. I'd certainly build and test against 3.5 as I haven't.
There was a possible leak, though the chances of it were probably small.

To make it still work for LLVM 3.4 / C++03, you need to change
#if OSL_LLVM_VERSION < 40
    typedef std::error_code LLVMErr;
#else
    typedef llvm::Error LLVMErr;
#endif

to
#if OSL_LLVM_VERSION >= 35
#if OSL_LLVM_VERSION < 40
    typedef std::error_code LLVMErr;
#else
    typedef llvm::Error LLVMErr;
#endif
#endif

because std::error_code is not present prior to C++11.
AFTER we branch RB-1.8, then we can be totally free with the C++11 idioms.

Yes llvm::Error, llvm::error_code, and std::error_code was horrifically annoying me last week.
I'm not sure how that relates to these changes though, or you want me to add something on top?

As far as I can tell, those error codes are only used for LLVM 3.5 and beyond (which are C++11), so I just enclosed that section in one more layer of
#if OSL_LLVM_VERSION >= 35

It would be handy if you did it on your end, but I can apply it on my end if you want. (I did so and was ready to merge, before you added another change; each time you push an update I have to re-apply it.)

I'll apply it on my end again, for the sake of expediently getting this merged.

Let's just keep this as is confined to the leak and failure to build > 3.6 from the previous commit?
Here's how I wound up solving the problem in unrelated code. The problem was that
LLVM 3.4 no std::error_code, llvm::error_code
LLVM 3.5+ std::error_code
LLVM 3.9/4.0 both use std::error_code but 4.0 changes the usage of llvm::Error for some calls
#if OSL_LLVM_VERSION <= 34
typedef llvm::error_code LLVMErr;
typedef llvm::error_code std_error_code;
#else
typedef std::error_code std_error_code;
# if OSL_LLVM_VERSION >= 40
typedef llvm::Error LLVMErr;
inline bool error_string (llvm::Error err, std::string *str) {
    if (err) {
        if (str) {
            llvm::handleAllErrors(std::move(err),
                      [str](llvm::ErrorInfoBase &E) { *str += E.message(); });
        }
        return true;
    }
    return false;
}
# else
typedef std::error_code LLVMErr;
# endif /* OSL_LLVM_VERSION >= 40 */
#endif /* OSL_LLVM_VERSION <= 34 */

inline bool error_string (const std_error_code &err, std::string *str) {
    if (err) {
        if (str) *str = err.message();
        return true;
    }
    return false;
}

So, would you like me to merge this one now, and then tackle the LLVM 3.4 fix separately? Is that what you mean?
I just want the smallest possible fix for LLVM 3.4, because as soon as we branch, master is going to have the LLVM 3.4 support taken away.

Exactly which LLVM versions are you able to test against on your end?

With your latest patch here, I'm still getting build errors for LLVM 3.5 (but works for 3.4 and 3.9).

llvm_util.cpp:534:41: error: no viable conversion from 'llvm::MemoryBuffer *' to 'std::unique_ptr<llvm::MemoryBuffer>'
    std::unique_ptr<llvm::MemoryBuffer> buf =
                                        ^

Ugh! Think if I move that to a construction rather than assignment it should work.

yes, it does!
I'll just do that on my end

OK, with that change, I'm getting clean builds on OSX with llvm 3.4, 3.5, 3.9, and on Linux with 3.4, 3.5, 3.9, and 4.0.
Merging as soon as I see non-disastrous results from the TravisCI builds!

Updated here as well. I've noticed Travis not passing for any PR, but master seems to go fine.
It's a weird issue with building ImageIO on Linux, failing for -ldl.
For what it's worth I write/compile against 3.9 (against a 3.9 debug build tree).
Compile and run the tests against 4.0 release install.
Every now and then I run the changes against a 3.4 release install.
So before I submit a PR it's passing all tests on OS X for 3.4, 4.0; and definitely compiles against 3.9.

Don't worry about the Travis, I have a set of changes to address that.

Oh, are they available somewhere? I just started copying/pasting some Travis stuff I have so I can stop running the tests locally.

Not yet. Working on it. The code base keeps shifting around underneath me!

Your current #703/this patch (with my minor fixes on top of them) pass all the Linux flavors on Travis now.
The OSX Travis builds are messed up for an entirely different reason.
Merging...

MERGED!
No more code changes will be merged until I branch, working on that now.

authors: lgritz marsupial

repo: imageworks/OpenShadingLanguage


text:
Do not drape map on reality models that are not geolocated

@Mergifyio backport release/2.15.x

@wgoehrig are you or someone else looking into why GitHub and ADO appear not to be communicating?

authors: RBBentley pmconne

repo: imodeljs/imodeljs


text:
Closing calcThroughput ticker

@yosiat Thanks

authors: nathanielc yosiat

repo: influxdata/kapacitor


text:
add time referencial

Codecov Report

Merging #613 into master will increase coverage by 0.1%.
The diff coverage is 65.9%.

@@            Coverage Diff            @@
##           master     #613     +/-   ##
=========================================
+ Coverage   45.88%   45.98%   +0.1%
=========================================
  Files         189      191      +2
  Lines       17017    17105     +88
=========================================
+ Hits         7808     7866     +58
- Misses       9209     9239     +30

Impacted Files
Coverage Δ

chain-time/src/timeframe.rs
63.51% <63.51%> (ø)

chain-time/src/timeline.rs
78.57% <78.57%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a011d0d...6399cad. Read the comment docs.

authors: codecov-io vincenthz

repo: input-output-hk/rust-cardano


text:
Switch between HD and SD streams

The video is an HLS stream and there's no API to switch between different resolutions with AVKit.

authors: KMamedoff insidegui

repo: insidegui/AppleEvents


text:
in README/Duck Accessors, the acessor for actions is named 'creators' and not 'actions', right?

Right! Thank you for the heads up!

repo: investtools/extensible-duck


text:
Please update sources-dist-stable.json for milight-smart-light adapter to version 1.1.1

I found another bug. Please do not take over yet.

I found another bug. Please do not take over yet.


text:
CClient: update README.

fixed in #1373

repo: iotaledger/entangled


text:
Convert to Swift 3, using Any instead AnyObject

Thanks Dany!

Dany, if you want the commits of this PR to be linked to your GH account, you should link your danysousa AT protonmail.com email address to your github profile.
best,

Thanks for the tip :)

authors: danysousa iscriptology

repo: iscriptology/swamp


text:
How to call Reset button when data is change through ajax call?

During initialization, the directive saves a copy of your original input-model.
What the "Reset" button do is actually, copying back that data into the input-model.
So to replicate that.. you simply do it from the controller. Create a copy of the original input-model, and copy it back when you need it.

Well i use multiple select in a form. When i submit the form the multiple selected data is clear for next form submition

Thanks Now its working 👍

Glad that you found a solution. I'll close the issue now.

authors: ShivPandey isteven shivpandey

repo: isteven/angular-multi-select


text:
Merge e2e to master

Jenkins job istio/presubmit passed

I need to submit this as people depend on this. Feel free to add issues to me for fixes.

authors: istio-testing sebastienvas

repo: istio/istio