text:
ipfs-cluster: 1.0.1 -> 1.0.2

Description of changes
https://github.com/ipfs/ipfs-cluster/releases/tag/v1.0.2
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

[nix-shell:~/.cache/nixpkgs-review/pr-181382]$ 2022-07-19T17:18:03.624Z	INFO	service	ipfs-cluster-service/daemon.go:49	Initializing. For verbose output run with "-l debug". Please wait...
2022-07-19T17:18:03.626Z	INFO	badger	badger@v1.6.2/logger.go:46	All 0 tables opened in 0s

2022-07-19T17:18:03.760Z	INFO	badger	badger@v1.6.2/logger.go:46	Replaying file id: 0 at offset: 0

2022-07-19T17:18:03.760Z	INFO	badger	badger@v1.6.2/logger.go:46	Replay took: 1.416µs

2022-07-19T17:18:03.760Z	INFO	service	ipfs-cluster-service/daemon.go:267	Datastore backend: badger
2022-07-19T17:18:03.767Z	INFO	cluster	ipfs-cluster/cluster.go:137	IPFS Cluster v1.0.2 listening on:
        /ip4/192.168.1.3/tcp/9096/p2p/12D3KooWR9MhpEbn3GyzS1tS5cujgH4hqyDvsD5PPt6WATdJWKRy
        /ip4/127.0.0.1/tcp/9096/p2p/12D3KooWR9MhpEbn3GyzS1tS5cujgH4hqyDvsD5PPt6WATdJWKRy

2022-07-19T17:18:03.769Z	INFO	pinsvcapi	common/api.go:460	PINSVCAPI (HTTP): /ip4/127.0.0.1/tcp/9097
2022-07-19T17:18:03.769Z	INFO	restapi	common/api.go:460	RESTAPI (HTTP): /ip4/127.0.0.1/tcp/9094
2022-07-19T17:18:03.769Z	INFO	ipfsproxy	ipfsproxy/ipfsproxy.go:323	IPFS Proxy: /ip4/127.0.0.1/tcp/9095 -> /ip4/127.0.0.1/tcp/5001
2022-07-19T17:18:03.770Z	INFO	crdt	go-ds-crdt@v0.3.6/set.go:122	Tombstones have bloomed: 0 tombs. Took: 63.254µs
2022-07-19T17:18:03.770Z	INFO	crdt	go-ds-crdt@v0.3.6/crdt.go:296	crdt Datastore created. Number of heads: 0. Current max-height: 0. Dirty: false
2022-07-19T17:18:03.770Z	INFO	crdt	crdt/consensus.go:318	'trust all' mode enabled. Any peer in the cluster can modify the pinset.
2022-07-19T17:18:03.770Z	INFO	crdt	go-ds-crdt@v0.3.6/crdt.go:505	store is marked clean. No need to repair
2022-07-19T17:18:03.770Z	INFO	cluster	ipfs-cluster/cluster.go:733	Cluster Peers (without including ourselves):
2022-07-19T17:18:03.770Z	INFO	cluster	ipfs-cluster/cluster.go:735	    - No other peers
2022-07-19T17:18:03.770Z	INFO	cluster	ipfs-cluster/cluster.go:748	** IPFS Cluster is READY **
2022-07-19T17:18:03.771Z	ERROR	ipfshttp	ipfshttp/ipfshttp.go:640	error posting to IPFS:Post "http://127.0.0.1:5001/api/v0/id": dial tcp 127.0.0.1:5001: connect: connection refused
2022-07-19T17:18:03.771Z	ERROR	ipfshttp	ipfshttp/ipfshttp.go:640	error posting to IPFS:Post "http://127.0.0.1:5001/api/v0/repo/stat?size-only=true": dial tcp 127.0.0.1:5001: connect: connection refused
2022-07-19T17:18:03.771Z	ERROR	ipfshttp	ipfshttp/ipfshttp.go:817	Post "http://127.0.0.1:5001/api/v0/repo/stat?size-only=true": dial tcp 127.0.0.1:5001: connect: connection refused
2022-07-19T17:18:03.771Z	ERROR	diskinfo	disk/disk.go:124	Post "http://127.0.0.1:5001/api/v0/repo/stat?size-only=true": dial tcp 127.0.0.1:5001: connect: connection refused
2022-07-19T17:18:03.771Z	ERROR	ipfshttp	ipfshttp/ipfshttp.go:640	error posting to IPFS:Post "http://127.0.0.1:5001/api/v0/pin/ls?stream=true&type=recursive": dial tcp 127.0.0.1:5001: connect: connection refused
2022-07-19T17:18:03.771Z	ERROR	ipfshttp	ipfshttp/ipfshttp.go:550	error querying pinset: %sPost "http://127.0.0.1:5001/api/v0/pin/ls?stream=true&type=recursive": dial tcp 127.0.0.1:5001: connect: connection refused
2022-07-19T17:18:03.771Z	ERROR	pintracker	stateless/stateless.go:667	Post "http://127.0.0.1:5001/api/v0/pin/ls?stream=true&type=recursive": dial tcp 127.0.0.1:5001: connect: connection refused

[nix-shell:~/.cache/nixpkgs-review/pr-181382]$ ./results/ipfs-cluster/bin/ipfs-cluster-ctl id
2022-07-19T17:18:16.324Z	ERROR	ipfshttp	ipfshttp/ipfshttp.go:640	error posting to IPFS:Post "http://127.0.0.1:5001/api/v0/id": dial tcp 127.0.0.1:5001: connect: connection refused
2022-07-19T17:18:16.324Z	INFO	restapilog	common/api.go:117	127.0.0.1 - - [19/Jul/2022:17:18:16 +0000] "GET /id HTTP/1.1" 200 591

12D3KooWR9MhpEbn3GyzS1tS5cujgH4hqyDvsD5PPt6WATdJWKRy | applePrincess | Sees 0 other peers
  > Addresses:
    - /ip4/127.0.0.1/tcp/9096/p2p/12D3KooWR9MhpEbn3GyzS1tS5cujgH4hqyDvsD5PPt6WATdJWKRy
    - /ip4/192.168.1.3/tcp/9096/p2p/12D3KooWR9MhpEbn3GyzS1tS5cujgH4hqyDvsD5PPt6WATdJWKRy
  > IPFS ERROR: Post "http://127.0.0.1:5001/api/v0/id": dial tcp 127.0.0.1:5001: connect: connection refused

[nix-shell:~/.cache/nixpkgs-review/pr-181382]$ 2022-07-19T17:18:18.770Z	ERROR	ipfshttp	ipfshttp/ipfshttp.go:640	error posting to IPFS:Post "http://127.0.0.1:5001/api/v0/id": dial tcp 127.0.0.1:5001: connect: connection refused
2022-07-19T17:18:18.772Z	ERROR	ipfshttp	ipfshttp/ipfshttp.go:640	error posting to IPFS:Post "http://127.0.0.1:5001/api/v0/repo/stat?size-only=true": dial tcp 127.0.0.1:5001: connect: connection refused
2022-07-19T17:18:18.772Z	ERROR	ipfshttp	ipfshttp/ipfshttp.go:817	Post "http://127.0.0.1:5001/api/v0/repo/stat?size-only=true": dial tcp 127.0.0.1:5001: connect: connection refused
2022-07-19T17:18:18.772Z	ERROR	diskinfo	disk/disk.go:124	Post "http://127.0.0.1:5001/api/v0/repo/stat?size-only=true": dial tcp 127.0.0.1:5001: connect: connection refused
fg
./results/ipfs-cluster/bin/ipfs-cluster-service daemon
^C2022-07-19T17:18:23.550Z	INFO	cluster	ipfs-cluster/cluster.go:779	shutting down Cluster
2022-07-19T17:18:23.550Z	INFO	restapi	common/api.go:501	stopping Cluster API
2022-07-19T17:18:23.550Z	INFO	pinsvcapi	common/api.go:501	stopping Cluster API
2022-07-19T17:18:23.550Z	INFO	ipfsproxy	ipfsproxy/ipfsproxy.go:289	stopping IPFS Proxy
2022-07-19T17:18:23.550Z	INFO	crdt	crdt/consensus.go:348	stopping Consensus component
2022-07-19T17:18:23.550Z	INFO	monitor	pubsubmon/pubsubmon.go:192	stopping Monitor
2022-07-19T17:18:23.550Z	INFO	ipfshttp	ipfshttp/ipfshttp.go:252	stopping IPFS Connector
2022-07-19T17:18:23.550Z	INFO	pintracker	stateless/stateless.go:270	stopping StatelessPinTracker

[nix-shell:~/.cache/nixpkgs-review/pr-181382]$ ./results/ipfs-cluster/bin/ipfs-cluster-ctl --help
NAME:
   ipfs-cluster-ctl - CLI for IPFS Cluster

USAGE:
   ipfs-cluster-ctl [global options] command [command options] [arguments...]

VERSION:
   1.0.2

DESCRIPTION:

ipfs-cluster-ctl is a tool to manage IPFS Cluster nodes.

Use "ipfs-cluster-ctl help" to list all available commands and
"ipfs-cluster-ctl help <command>" to get usage information for a
specific one.

ipfs-cluster-ctl uses the IPFS Cluster API to perform requests and
display responses in a user-readable format. The location of the IPFS
Cluster server is assumed to be /ip4/127.0.0.1/tcp/9094, but can be configured
with the --host option. If several multiaddresses are specified
(comma-separated), requests will be sent to the first one and fail-over
over to the others. This also works for dns-based addresses which resolve
to multiple values.

To use the secure libp2p-http API endpoint, use "--host" with
the full cluster libp2p listener address, including the "/p2p/<peerID>"
part, or a /dnsaddr that resolves to it. Provide the cluster secret with
--secret as needed.

For feedback, bug reports or any additional information, visit
https://github.com/ipfs-cluster/ipfs-cluster.

COMMANDS:
   id       Retrieve peer information
   peers    List and manage IPFS Cluster peers
   add      Add a file or directory to ipfs and pin it in the cluster
   pin      Pin and unpin and list items in IPFS Cluster
   status   Retrieve the status of tracked items
   recover  Recover tracked items in error state
   version  Retrieve cluster version
   health   Cluster monitoring information
   ipfs     Manage IPFS daemon
   help, h  Shows a list of commands or help for one command

GLOBAL OPTIONS:
   --host value, -l value         API endpoint multiaddresses (comma-separated) (default: "/ip4/127.0.0.1/tcp/9094")
   --secret value                 cluster secret (32 byte pnet-key) as needed. Only when using the LibP2P endpoint
   --https, -s                    use https to connect to the API
   --no-check-certificate         do not verify server TLS certificate. only valid with --https flag
   --encoding value, --enc value  output format encoding [text, json] (default: "text")
   --timeout value, -t value      number of seconds to wait before timing out a request (default: 0)
   --debug, -d                    set debug log level
   --basic-auth value             <username>[:<password>] specify BasicAuth credentials for server that
requires authorization. implies --https, which you can disable with --force-http [$CLUSTER_CREDENTIALS]
   --force-http, -f  force HTTP. only valid when using BasicAuth
   --help, -h        show help
   --version, -v     print the version

change looks good to me.

Result of nixpkgs-review pr 181382 run on x86_64-linux 1

1 package built:

ipfs-cluster

Looks good for x86_64-linux , however tests failed on x86_64-darwin ran by ofborg. Could you re-check ?

Weird, I just checked out this branch, executed nix-build -A ipfs-cluster and the tests ran perfectly fine on my x86_64-darwin machine.
Perhaps the test is flakey? What else could cause this?

I don't have darwin so I cannot help here.
Check by running nixpkgs-review pr 181382 because that is effectively what is doing by ofborg. So you can inspect further.

During the tests, the macOS firewall asks three times if I wish to allow incoming connections. If I click the button to allow it or I just ignore the dialog box and do nothing, then the tests pass but if I click the button to deny incoming connections, the test fails with the same error message as OfBorg.

Here is my translation of the text in the dialog box:

Do you want the program "common.test" to accept incoming network connections?
Clicking on "Do not allow" may limit the behaviour of the program. This setting can be changed in the system preferences "Security" under "Firewall".

If I deactivate the macOS firewall, the tests also pass.
There is also an option to block all incoming connections, which also causes the test to pass for some reason.
So in summary, I suspect that this may have something to do with the macOS firewall but I'm not sure what the difference between my machine and OfBorg is.

Yeah... really weired. Looking hydra job log for ipfs-cluster 1.0.1 this looks awfully similar to what is failing here. except the hydra one passes the test.

I think those errors in the log are expected. Compare it to the project's official CI run: https://github.com/ipfs-cluster/ipfs-cluster/runs/7218915278?check_suite_focus=true.
I think the error in this PR is something different. Should I just rebase the commit so the test runs again? Maybe it's just a flaky test. If so, I can report it upstream.

I don't want to compare upstream test result because they only run on ubuntu that will likely differ from what we see here on darwin.
And that is why I was comparing with older version of hydra job which ran on darwin.
Yeah agree to rebase this, if tests failing on ofborg but you can make sure that test still passes on your local machine then I can accept this.

@ofborg build ipfs-cluster ipfs-cluster.passthru.tests

authors: Luflosi applePrincess bobby285271


text:
sfml: install pkg-config files

Motivation for this change
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Looking good! I've merged this in 684ec57cb5df64f926f2d319763446f5e0319d7d. Many thanks!

source: gharchive/pull-request

authors: juliendehos rycee

repo: NixOS/nixpkgs

license: MIT

license_type: permissive

license_source: github-api


text:
chromium: add commandLineArgs after wayland flags

Description of changes
Change flag order to work around a bug in chromium causing some flags to be ignored. See #189199 for more detail.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

cc @wmertens

Ok cool - there's apparently also vivaldi but that's not even using the ozone flags and I never heard of it and it's unfree so I'm ok with ignoring it :) Thanks!

authors: stefanradziuk wmertens


text:
python3Packages.deal: 4.23.3 -> 4.23.4

Description of changes
Update of deal
Changelog
Now includes integration tests for flake8
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build python310Packages.deal


text:
openiscsi: 2.1.7 -> 2.1.8

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/open-iscsi/open-iscsi/releases.
meta.description for openiscsi is: "A high performance, transport independent, multi-platform implementation of RFC3720"
meta.homepage for openiscsi is: "https://www.open-iscsi.com"
meta.changelog for openiscsi is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 2.1.8 with grep in /nix/store/lk14g9rvwk3n6b8bxk71nyrwjgf93a9l-open-iscsi-2.1.8
found 2.1.8 in filename of file in /nix/store/lk14g9rvwk3n6b8bxk71nyrwjgf93a9l-open-iscsi-2.1.8

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
openiscsi

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lk14g9rvwk3n6b8bxk71nyrwjgf93a9l-open-iscsi-2.1.8 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A openiscsi https://github.com/r-ryantm/nixpkgs/archive/456d64c87b6b82062d7a384313e19c54cdad49d1.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lk14g9rvwk3n6b8bxk71nyrwjgf93a9l-open-iscsi-2.1.8
ls -la /nix/store/lk14g9rvwk3n6b8bxk71nyrwjgf93a9l-open-iscsi-2.1.8/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

openiscsi

Maintainer pings
cc @cleverca22 @zaninime for testing.

Result of nixpkgs-review pr 193104 run on x86_64-linux 1

1 package built:

openiscsi

Result of nixpkgs-review pr 193104 run on x86_64-linux 1

1 test built:

nixosTests.iscsi-root

authors: onny r-ryantm


text:
nodejs: 18.9.1 -> 18.10.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for nodejs is: "Event-driven I/O framework for the V8 JavaScript engine"
meta.homepage for nodejs is: "https://nodejs.org"
meta.changelog for nodejs is: "https://github.com/nodejs/node/releases/tag/v18.10.0"
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 18.10.0 with grep in /nix/store/l410llh5vjf7j28g3r9ddpz692djcjjj-nodejs-18.10.0
found 18.10.0 in filename of file in /nix/store/l410llh5vjf7j28g3r9ddpz692djcjjj-nodejs-18.10.0

Rebuild report (if merged into master) (click to expand)

942 total rebuild path(s)

942 package rebuild(s)

First fifty rebuilds by attrpath
CuboCore.corepdf
PageEdit
adl
adoptopenjdk-icedtea-web
airfield
amarok
amarok-kf5
anime-downloader
anki
ankisyncd
antennas
antora
apache-airflow
balanceofsatoshis
bat-extras.prettybat
binaryen
bitwarden-cli
breitbandmessung
bs-platform
calamares
calamares-nixos
calibre
calligra
castnow
chromium
cinnamon.xreader
cjdns
cjdns-tools
clipgrab
code-server
commitlint
concurrently
create-cycle-app
csound-qt
csslint
cudaPackages.nsight_compute
cutemarked-ng
cutter
cwltool
cz-cli
deltachat-desktop
dgraph
digikam
discourse
discourseAllPlugins
dmlive
eagle
element-desktop
element-desktop-wayland
element-web

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/l410llh5vjf7j28g3r9ddpz692djcjjj-nodejs-18.10.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A nodejs https://github.com/r-ryantm/nixpkgs/archive/fe182838de0c424a3e1a846d42db12c7f135f64d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/l410llh5vjf7j28g3r9ddpz692djcjjj-nodejs-18.10.0
ls -la /nix/store/l410llh5vjf7j28g3r9ddpz692djcjjj-nodejs-18.10.0/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @cillianderoiste @gilligan @cko @marsam for testing.

This seems to be redundant with #193496.

authors: ivan r-ryantm


text:
uwimap: fix build on darwin

Description of changes
Required for #193925
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Thanks again @stephank !

authors: drupol stephank


text:
python311Packages.pytest-subtests: patch failing tests

Python3.11 broke the tests and there has been a fix upstream, but it hasnt been released yet
Description of changes
Found upstream fix, fetch the relevant patch (filtered by the file because otherwise the patch doesn't apply cleanly)
@fabaff pinging you as maintainer
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

0.9.0 just released, it's probably better to just upgrade

I assume the labels ofborg created say that this thriggers an armadillion rebuilds, so I switched it to target staging

Does this need anything before it can be merged?


text:
alice-tools: init at 0.12.1

Description of changes
Packages alice-tools, a collection of tools for viewing and converting file formats used in AliceSoft games.

I have checked CLI/Qt5/Qt6 variants on x86_64-linux & aarch64-linux, and CLI/Qt5 variants on x86_64-darwin. My macOS version is seemingly too old for Qt6 so trying to use those binaries just errors on my end. I have checked the builds by opening the graphics-containing archive from one of my games, browsing through its contents and extracting some of the assets into png & webp formats.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build alice-tools libsForQt5.alice-tools qt6Packages.alice-tools

Hmm looks like the default stdenv's compiler on both Darwin platforms is also too old for Qt6, throws the same "Qt requires a C++17 compiler" error on Ofborg…

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/822


text:
dcmtk: enable tests

Description of changes
Enable tests, which run quickly relative to overall build time.
~Currently draft because dcmtk is broken pending #206265.~
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 210261 run on x86_64-linux 1

1 package built:

dcmtk

authors: StillerHarpo bcdarwin


text:
python310Packages.pikepdf: 6.2.9 -> 7.0.0

Description of changes
Diff: https://github.com/pikepdf/pikepdf/compare/v6.2.9...v7.0.0
Changelog: https://github.com/pikepdf/pikepdf/blob/v7.0.0/docs/releasenotes/version7.rst

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 214672 run on x86_64-linux 1

1 package failed to build:

python311Packages.graphite-web

26 packages built:

glaxnimate
img2pdf (python310Packages.img2pdf)
manga-cli
mirage-im
ocrmypdf (python310Packages.ocrmypdf)
paperless-ngx
pdfarranger
python310Packages.Nikola
python310Packages.cairocffi
python310Packages.cairosvg
python310Packages.graphite-web
python310Packages.pikepdf
python310Packages.pygal
python310Packages.wavedrom
python311Packages.Nikola
python311Packages.cairocffi
python311Packages.cairosvg
python311Packages.img2pdf
python311Packages.ocrmypdf
python311Packages.pikepdf
python311Packages.pygal
python311Packages.wavedrom
qtile
skytemple
streamdeck-ui
xsser

Result of nixpkgs-review pr 214672 run on aarch64-linux 1

25 packages failed to build:

img2pdf (python310Packages.img2pdf)
mirage-im
ocrmypdf (python310Packages.ocrmypdf)
paperless-ngx
pdfarranger
python310Packages.Nikola
python310Packages.cairocffi
python310Packages.cairosvg
python310Packages.graphite-web
python310Packages.pikepdf
python310Packages.pygal
python310Packages.wavedrom
python311Packages.Nikola
python311Packages.cairocffi
python311Packages.cairosvg
python311Packages.graphite-web
python311Packages.img2pdf
python311Packages.ocrmypdf
python311Packages.pikepdf
python311Packages.pygal
python311Packages.wavedrom
qtile
skytemple
streamdeck-ui
xsser

Result of nixpkgs-review pr 214672 run on aarch64-darwin 1

6 packages marked as broken and skipped:

mirage-im
paperless-ngx
python310Packages.Nikola
python311Packages.Nikola
skytemple
streamdeck-ui

11 packages failed to build:

python310Packages.cairocffi
python310Packages.cairosvg
python310Packages.graphite-web
python310Packages.pygal
python310Packages.wavedrom
python311Packages.cairocffi
python311Packages.cairosvg
python311Packages.graphite-web
python311Packages.pygal
python311Packages.wavedrom
xsser

6 packages built:

img2pdf (python310Packages.img2pdf)
ocrmypdf (python310Packages.ocrmypdf)
python310Packages.pikepdf
python311Packages.img2pdf
python311Packages.ocrmypdf
python311Packages.pikepdf


text:
python310Packages.iminuit: 2.19.0 -> 2.20.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.iminuit is: Python interface for the Minuit2 C++ library
meta.homepage for python310Packages.iminuit is: https://github.com/scikit-hep/iminuit
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.20.0 with grep in /nix/store/93lvv1qrk51m2mwzh99pb4kv642dlpbi-python3.10-iminuit-2.20.0
found 2.20.0 in filename of file in /nix/store/93lvv1qrk51m2mwzh99pb4kv642dlpbi-python3.10-iminuit-2.20.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
professor
python310Packages.iminuit
python311Packages.iminuit

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/93lvv1qrk51m2mwzh99pb4kv642dlpbi-python3.10-iminuit-2.20.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.iminuit https://github.com/r-ryantm/nixpkgs/archive/6a9fdab47e59a759b2c07d897572964cef201c2d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/93lvv1qrk51m2mwzh99pb4kv642dlpbi-python3.10-iminuit-2.20.0
ls -la /nix/store/93lvv1qrk51m2mwzh99pb4kv642dlpbi-python3.10-iminuit-2.20.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

professor
python310Packages.iminuit
python311Packages.iminuit

Maintainer pings
cc @veprbl for testing.

Result of nixpkgs-review pr 216912 run on aarch64-darwin 1

3 packages built:

professor
python310Packages.iminuit
python311Packages.iminuit

Result of nixpkgs-review pr 216912 run on aarch64-darwin 1

3 packages built:

professor
python310Packages.iminuit
python311Packages.iminuit

authors: r-ryantm wegank


text:
nixos-render-docs: add support for examples

Description of changes
add support for real examples with toc entries (≍ docbook <example>). the module chapter conversion removed a few examples that can new be restored, and the remaining manual chapters have their examples adjusted to include proper titles for toc purposes. this will also be needed if the nixpkgs manual ever decides to use nrd, its lib section is full of examples that make sense to mark up properly.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/2023-04-11-documentation-team-meeting-notes-40/27261/1

authors: nixos-discourse pennae


text:
treewide: remove libSystem hack

Description of changes
Follow-up of #225409.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build far2l far2l.passthru.tests monit monit.passthru.tests wxGTK31 wxGTK31.passthru.tests wxGTK32 wxGTK32.passthru.tests

@ofborg build codeblocksFull


text:
consul-template: 0.30.0 -> 0.31.0

Description of changes
changelog: https://github.com/hashicorp/consul-template/blob/02d863a94d85e7a55f69ac3c889d3867577fa00d/CHANGELOG.md#v0310-apr-06-2023
diff: https://github.com/hashicorp/consul-template/compare/v0.30.0...v0.31.0
@ryantm: @r-ryantm failed to raise this PR due to cachix push nix-community failing :eyes:
See https://r.ryantm.com/log/consul-template/2023-04-15.log
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2108

authors: IndeedNotJames nixos-discourse


text:
texlive.combine: move repstopdf test to tests.texlive

Description of changes
Mere simplification of texlive.combine: move the repstopdf test to an actual test.
(Extracted from #225503 which is too big as it is.)
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build tests.texlive


text:
baboossh: init at 1.2.0

Description of changes
Tool to do SSH spreading
https://github.com/cybiere/baboossh
Related to https://github.com/NixOS/nixpkgs/issues/81418

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 233088 run on x86_64-linux 1

6 packages built:

baboossh
baboossh.dist
python310Packages.python-libnmap
python310Packages.python-libnmap.dist
python311Packages.python-libnmap
python311Packages.python-libnmap.dist


text:
nixos/vaultwarden: harden systemd units, add tests

Description of changes

Harden both normal and backup systemd unit
Fix backup script, which tried copying nonexistent files
Add nixos test for running the backup script.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

I've run all vaultwarden tests and made sure they pass.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2571

Superseded by #292485

Continuing the new test in #292857


text:
texsudio: add qtwayland as dependency

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

why is this needed?

why is this needed?

Oh sorry for not explaining.
When setting
home.sessionVariables = {
      QT_QPA_PLATFORM = "wayland";
};

to get native wayland support it otherwise crashes with
qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
Available platform plugins are: offscreen, minimalegl, vkkhrdisplay, linuxfb, vnc, minimal, eglfs, xcb.
Aborted (core dumped)

I also verified using xeyes that the env variable is needed to get native wayland support. There also seems to be a bit of previous art in nixpkgs https://github.com/search?q=repo%3ANixOS%2Fnixpkgs qtwayland&type=code

Does that mean that every qt app that doesn't explicitly add qtwayland as a dependency runs through xwayland?

Does that mean that every qt app that doesn't explicitly add qtwayland as a dependency runs through xwayland?

From https://wiki.archlinux.org/title/wayland#Qt and https://wiki.qt.io/QtWayland I would conclude that. I assume you want to say we should add it to qt5 itself.

From @ajs124:

Does that mean that every qt app that doesn't explicitly add qtwayland as a dependency runs through xwayland?

Yes, for QT6 programs. They will not run on Wayland, unless qtwayland is explicitly added as buildInput.  See https://github.com/NixOS/nixpkgs/issues/219724#issuecomment-1455518086. QT5 programs in Nix have qtwayland bundled due to historical reasons.
Based on this PR, I opened a similar PR at #267427 for adding wayland support to TeXworks.

QT5 programs in Nix have qtwayland bundled due to historical reasons.

oh. but why not do the same for qt6? where/why was that decision made? so programs without wayland support don't have it unnecessarily?
sounds like someone should go through the qt6 apps in nixpkgs and check if they're actually running with wayland natively then.

I'm an outsider therefore may be misinformed, but it seems that this is
done for QT6 in an attempt to reduce closure size.  (But then the
maintainers have to add them back in package definitions... I'm confused)
ajs124 @.***> writes:

QT5 programs in Nix have qtwayland bundled due to historical reasons.
oh. but why not do the same for qt6? where/why was that decision made? so programs without wayland support don't have it
unnecessarily?
sounds like someone should go through the qt6 apps in nixpkgs and check if they're actually running with wayland natively then.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.

There's a typo in the commit message and PR title. texsudio vs texstudio.

There's a typo in the commit message and PR title. texsudio vs texstudio.

Fixed.


text:
swiftshader: 2020-11-06 -> 2023-09-11

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Thanks :)
On Fri, Sep 15, 2023 at 3:49 PM Artturi @.***> wrote:

Merged #254661 into master.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID:
@.***>


text:
Implement check to disallow pkgs/by-name package definitions in all-packages.nix with an empty argument

Description of changes
This PR extends the nixpkgs-check-by-name tool to allow checking that packages in pkgs/by-name cannot also have a definition in all-package.nix with an empty attribute set.
In order to allow a smooth CI change, the check is not enabled by default for now. It has to be enabled with --version v1. I will update CI to use this in a future PR. This PR here only updates the tool to support this new check. This way we sidestep the problem of https://github.com/NixOS/nixpkgs/issues/256788 for now.
Example
If pkgs/by-name/fo/foo exists, this would be disallowed in all-packages.nix:
  foo = callPackage ../by-name/fo/foo/package.nix { };

because the second callPackage argument is an empty attribute set.
RFC relation
This notably is a minor violation of what RFC 140 specifies:

Optionally there may also be an overriding definition of pkgs.${name} in pkgs/top-level/all-packages.nix equivalent to
pkgs.callPackage pkgs/by-name/${shard}/${name}/package.nix args

with an arbitrary args.

However I don't think there's a good reason this shouldn't be done.
By disallowing empty arguments, we can be sure that new packages that don't need any arguments aren't unnecessarily added to all-packages.nix.
Furthermore, we can ensure that if packages are refactored to not need custom arguments anymore, they get removed from all-packages.nix, and don't linger around unnecessarily.
I asked whether anybody had any problems with this on Matrix and in the last NAT meeting, but there were none.
Things done

[x] Wrote a test
[x] Ensure that CI can handle old and new Nixpkgs regarding the new _internalCallByNamePackageFile that is necessary to perform this check

This turns out to not be a problem, because we'll always run older versions of the tool on potentially newer versions of Nixpkgs

While there's no current violations of this (I thought there was one, but turns out it was a fake), this is a good exercise for future increases in CI strictness.


text:
guile-semver: init at 0.1.1

Description of changes
Add guile-semver as part of packaging Guix dependencies.
cc @cafkafk  (I apologize for having too many mentions, I should've made this into a single PR if I did know I would be making this much progress in a day to make it easier to review 😅)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

(I apologize for having too many mentions, I should've made this into a single PR if I did know I would be making this much progress in a day to make it easier to review 😅)

nw! Cool to see this much progress! did you see I wrote to you on matrix btw, I had some questions about guile on nix, I thought you'd be the best to ask.

authors: cafkafk foo-dogsquared


text:
firefox: default to speech synthesis enabled

Description of changes
Closes: #259497
ping @nyabinary

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 259534 run on x86_64-linux 1

20 packages built:

betterbird
dropbox
dropbox-cli
dropbox-cli.nautilusExtension
firefox
firefox-beta
firefox-beta-bin
firefox-bin
firefox-devedition
firefox-devedition-bin
firefox-esr
firefox-mobile
librewolf
mate.caja-dropbox
midori
sitespeed-io
slimerjs
thunderbird
thunderbird-bin
vimb

nix-build -A nixosTests.firefox worked

Thanks for this PR. However, could we have a closure size delta? Is this PR indeed increasing the closure size by ~0.7G as @vcunat suggested?
A quick nix path-info -rsS nixpkgs#speechd | sort -n -k2 points to ~644M for mbrola-voices:
/nix/store/qvq40jin7j7j6fpravnq04f4gj4vqmib-mbrola-voices-3.3            	  675956120	  675956120

It's a trade-off, really. The interesting question is what Mozilla does to control the closure size.

Yes, precisely, that's why I'm asking, knowing the closure size delta would have been helpful to make an informed trade-off. Maybe, like for ffmpeg, we should have more wrapFirefox derivations in all-packages.nix to let end-users make their own trade-offs.

We shouldn't turn this off by default because it quite literally an accessibility, that my thought process at least.

And I am happy to have speechd enabled by default, as a matter of fact I landed here because firefox told me "You cannot use speech synthesis because the Speech Dispatcher library is missing", which displeased me.
Yet, the closure size delta no longer being a requirement of the PR template, and reading a message warning about it, it would have been good to confirm it.
This could have given both a reason and a start for another PR to make -full and/or -small variants to select the closure size (which, security-wise, is also impacting the attack surface), to follow a pattern found elsewhere in Nixpkgs. Because there is reason to wager that recompiling firefox is not pratical for most users, hence the default is the only pratical choice.

This setting does not cause any recompilation.

Oh, great, then everything is fine to me, sorry for the noise.

It's a trade-off, really.

A really bad one which costs us 0.7 GB of extra storage.
without:
 ➜ nix path-info -hS $(which firefox)
/nix/store/n5vdac59hffc8bvsy0yjbg4h61rp3349-firefox-bin-118.0.1    2.1G

with:
 ➜ nix path-info -hS $(which firefox)
/nix/store/36gd5ak5kzj99fla99mbnsw1bwja2820-firefox-bin-118.0.1    2.8G

Which is mostly caused by mbrola-voices as analyzed already. We are installing all voices available. For example Arch Linux by default doesn't use mbrola for speech-dispatcher and then if you want to us mbrola you need to install the voices you are interested in manually.
We should really split up mbrola-voices at least into one package per language and then make it configurable. Maybe depended on the configured locale.
The current trade off is not acceptable, 25% of the closure size is used by an optional feature which not a majority of the users are using.

The interesting question is what Mozilla does to control the closure size.

They made this an optional feature people can opt in. Other distros are doing similar things by marking speech-dispatcher as optional and the message in firefox tells you, if you want to use that feature, install speech-dispatcher.

We shouldn't turn this off by default because it quite literally an accessibility, that my thought process at least.

All accessibility features I can think of right now are turned off by default. Be it the narrator on Windows, bigger text, high contrast, etc because if you are not depended on them they are distracting.

Created a revert in #261058 because IMO this is not justifiable.

A partial/independent improvement: https://github.com/NixOS/nixpkgs/pull/261619

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/how-does-one-disable-the-speechd-firefox-dependency/56415/2

authors: Nyabinary SuperSandro2000 cafkafk ju1m mweinelt nixos-discourse vcunat


text:
lutris-humble-cookies: init

Description of changes
This is a small helper script to transfer a session cookie for Humble Bundle from Firefox to Lutris.
While it is easy to directly download the script from GitHub and running it with Python, the script would have to be reviewed before each execution to ensure it has not been altered in a malicious way. Packaging adds the benefit of recording a hash of the script.
Usage: nix run nixpkgs#lutris-humble-cookies > ~/.cache/lutris/.humblebundle.auth
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

$ results/lutris-humble-cookies/bin/extract_cookies.py foobar
Traceback (most recent call last):
  File "/dev/shm/nixpkgs-review/pr-259599/results/lutris-humble-cookies/bin/extract_cookies.py", line 98, in <module>
    main()
  File "/nix/store/i8676bx7y122swbjjbkns2l4nfc8ipsz-python3-3.11.9-env/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/i8676bx7y122swbjjbkns2l4nfc8ipsz-python3-3.11.9-env/lib/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/nix/store/i8676bx7y122swbjjbkns2l4nfc8ipsz-python3-3.11.9-env/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/i8676bx7y122swbjjbkns2l4nfc8ipsz-python3-3.11.9-env/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/dev/shm/nixpkgs-review/pr-259599/results/lutris-humble-cookies/bin/extract_cookies.py", line 93, in main
    shutil.copy(dbpath, temp.name)
  File "/nix/store/glfr70gi7hfaj50mwj2431p8bg60fhqw-python3-3.11.9/lib/python3.11/shutil.py", line 431, in copy
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/nix/store/glfr70gi7hfaj50mwj2431p8bg60fhqw-python3-3.11.9/lib/python3.11/shutil.py", line 235, in copyfile
    if _samefile(src, dst):
       ^^^^^^^^^^^^^^^^^^^
  File "/nix/store/glfr70gi7hfaj50mwj2431p8bg60fhqw-python3-3.11.9/lib/python3.11/shutil.py", line 212, in _samefile
    return os.path.samefile(src, dst)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen genericpath>", line 100, in samefile
TypeError: stat: path should be string, bytes, os.PathLike or integer, not tuple

authors: pbsds wamserma


text:
python311Packages.griffe: 0.38.0 -> 0.38.1

Diff: https://github.com/mkdocstrings/griffe/compare/refs/tags/0.38.0...0.38.1
Changelog: https://github.com/mkdocstrings/griffe/blob/0.38.1/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 272741 run on x86_64-linux 1

9 packages built:

griffe (python311Packages.griffe)
griffe.dist (python311Packages.griffe.dist)
netbox (netbox_3_6)
python310Packages.griffe
python310Packages.griffe.dist
python310Packages.mkdocstrings-python
python310Packages.mkdocstrings-python.dist
python311Packages.mkdocstrings-python
python311Packages.mkdocstrings-python.dist


text:
Bluez: 5.70 -> 5.71

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3173

authors: AndersonTorres nixos-discourse


text:
haskell.packages.ghc865Binary: drop unevaluatable packages

haskell.packages.ghc865Binary has a few packages that fails to evaluate by referring non-existent attributes. This turns evaluation attempts into unrecoverable errors.
Before the change an attempt to instantiate all ghc810 packages failed as:
$ nix-instantiate --strict --eval --expr 'with import ./. {}; lib.mapAttrs (n: v: builtins.tryEval (lib.isDerivation v)) haskell.packages.ghc865Binary'
error:
   … while evaluating the attribute 'llvmPackages'

     at lib/attrsets.nix:1180:11:

     1179|     attrs:
     1180|     attrs // { recurseForDerivations = false; };
         |           ^
     1181|

   error: value is null while a set was expected

The change follows definition of pkgs/top-level/haskell-packages.nix and also sets llvmPackages to null. While at it dropped other references to deleted packages like exceptions pin.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thx

authors: maralorn trofi


text:
pip-audit: 2.6.2 -> 2.6.3

Diff: https://github.com/trailofbits/pip-audit/compare/refs/tags/v2.6.2...v2.6.3
Changelog: https://github.com/pypa/pip-audit/releases/tag/v2.6.3
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 279686 run on x86_64-linux 1

2 packages built:

pip-audit
pip-audit.dist

Result of nixpkgs-review pr 279686 run on aarch64-darwin 1

2 packages built:

pip-audit
pip-audit.dist

Result of nixpkgs-review pr 279686 run on aarch64-linux 1

2 packages built:

pip-audit
pip-audit.dist


text:
python311Packages.pyosohotwaterapi: init at 1.1.4

Description of changes
Module for using the OSO Hotwater API
https://github.com/osohotwateriot/apyosohotwaterapi

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 281790 run on x86_64-linux 1

2 packages built:

python311Packages.pyosohotwaterapi
python311Packages.pyosohotwaterapi.dist

Result of nixpkgs-review pr 281790 run on aarch64-darwin 1

2 packages built:

python311Packages.pyosohotwaterapi
python311Packages.pyosohotwaterapi.dist


text:
mupdf: fix library linking

Motivation for this change
A recent change 47f099777cadb1110abde73279e0ebf148c05308 broke a package I maintain (k2pdfopt), which would complain about missing openssl symbols. While a quick fix would just be to link in openssl manually for my package, I believe this is the proper fix to make libmupdf behave more like a normal shared library.
Specifically, libmupdf.so does not have DT_NEEDED references to its
dependencies. Packages which link against libmupdf.so would have to also
manually link against its dependencies as well. This adds unnecessary complexity to packages which depend on it. (See also llpp, jfbview, and zathura-pdf-mupdf)
The first commit includes a patch which ensures that libmupdf.so is built with references to its own dependencies.
An additional commit fixes k2pdfopt, which uses a patched version of mupdf and requires another patch for an older version.
Output of readelf -d libmupdf.so before change:

...
0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]
0x000000000000001d (RUNPATH)            Library runpath: [/nix/store/zpg78y1mf0di6127q6r51kgx2q8cxsvv-glibc-2.25-49/lib]
...

After change:

...
0x0000000000000001 (NEEDED)             Shared library: [libmupdfthird.so]
0x0000000000000001 (NEEDED)             Shared library: [libmuthreads.so]
0x0000000000000001 (NEEDED)             Shared library: [libm.so.6]
0x0000000000000001 (NEEDED)             Shared library: [libfreetype.so.6]
0x0000000000000001 (NEEDED)             Shared library: [libharfbuzz.so.0]
0x0000000000000001 (NEEDED)             Shared library: [libjbig2dec.so.0]
0x0000000000000001 (NEEDED)             Shared library: [libjpeg.so.62]
0x0000000000000001 (NEEDED)             Shared library: [libopenjp2.so.7]
0x0000000000000001 (NEEDED)             Shared library: [libz.so.1]
0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]
0x000000000000000e (SONAME)             Library soname: [libmupdf.so]
0x000000000000001d (RUNPATH)            Library runpath: [/nix/store/05j0i5jhbp1j0mv36mj08rvn7pk7a3s4-mupdf-1.11/lib:/nix/store/7rda899md2d4q26lxb43yg3cmrgcdr1r-freetype-2.7.1/lib:/nix/store/riicxh9dp1bx90fjcf2yr7gw3wj0x7fm-harfbuzz-1.5.1/lib:/nix/store/gdnvg9j2hr4fh43arflqbzx5a86f7gpc-openjpeg-2.1.2/lib:/nix/store/i8wz3m067dzbs5x2glhxvcg7lvds1942-zlib-1.2.11/lib:/nix/store/bsqid2phn9ad8fyw2d63anzrrxp7a9x4-libjpeg-turbo-1.5.2/lib:/nix/store/0yqg15g97va4xrdzkgjd74nfxgw1c3ij-jbig2dec-0.13/lib:/nix/store/zpg78y1mf0di6127q6r51kgx2q8cxsvv-glibc-2.25-49/lib]
...

I believe llpp, jfbview, and zathura-pdf-mupdf could also be cleaned to not have to refer to mupdf's dependencies. Those packages build anyway, so it's not strictly necessary. Finally, I'm not an expert on compilers or linking so let me know if I'm misunderstanding anything.
CC @abbradar
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

cc mupdf maintainers: @viric @vrthra @fpletz

@orivej I've changed the url to a mirror which works on ipv6.
Just a note that there are some other derivations which use a linuxfromscratch.org url: id3lib, cyrus-sasl, pycairo, and even chromium.

Thank you! Maybe I have not downloaded from them, or maybe they were already cached by nixos cache servers, or maybe linuxfromscratch IPv6 is only temporarily down.

authors: danielfullmer orivej vyp


text:
libftdi1: Fix doc parallelism

Description of changes
Spotted a random build failure while reviewing something unrelated.
[  8%] Generating ../doc/xml/ftdi_8c.xml
[...]
[ 12%] Generating ../doc/xml/ftdi_8c.xml
[...]
[ 14%] Generating ftdi1_doc.i
[...]
Traceback (most recent call last):
  File "/build/libftdi/python/doxy2swig.py", line 457, in <module>
    main()
  File "/build/libftdi/python/doxy2swig.py", line 453, in main
    convert(args[0], args[1], not options.func_def, options.quiet)
  File "/build/libftdi/python/doxy2swig.py", line 430, in convert
    p = Doxy2SWIG(input, include_function_definition, quiet)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/build/libftdi/python/doxy2swig.py", line 74, in __init__
    self.xmldoc = minidom.parse(f).documentElement
                  ^^^^^^^^^^^^^^^^
  File "/nix/store/gd3shnza1i50zn8zs04fa729ribr88m9-python3-3.11.8/lib/python3.11/xml/dom/minidom.py", line 1990, in parse
    return expatbuilder.parse(file)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/gd3shnza1i50zn8zs04fa729ribr88m9-python3-3.11.8/lib/python3.11/xml/dom/expatbuilder.py", line 913, in parse
    result = builder.parseFile(file)
             ^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/gd3shnza1i50zn8zs04fa729ribr88m9-python3-3.11.8/lib/python3.11/xml/dom/expatbuilder.py", line 211, in parseFile
    parser.Parse(b"", True)
xml.parsers.expat.ExpatError: no element found: line 1, column 0
make[2]: *** [python/CMakeFiles/doc_i.dir/build.make:73: python/ftdi1_doc.i] Error 1

add_custom_command OUTPUT generation requires a separate add_custom_target to ensure parallelism-safety, and DEPENDS should use those targets instead of the OUTPUTted files. Otherwise, multiple tasks will each invoke the add_custom_command for their own DEPENDS and overwrite each other's results, leading to issues like this.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Have you tried submitting the patch upstream?

I don't see any obvious spot for doing so. I guess by subscribing to the libftdi@developer.intra2net.com maillist and throwing the patch contents on there?

I don't see any obvious spot for doing so. I guess by subscribing to the libftdi@developer.intra2net.com maillist and throwing the patch contents on there?

Seems so. From https://www.intra2net.com/en/developer/libftdi/index.php:

If you have questions or want to talk to other developers, join the mailing list.


text:
devcontainer: init at 0.58.0

Description of changes

Devcontainer (https://containers.dev/) is an opensource MIT implementation of the devcontainer specs.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3742

I had to move from mkYarnPackage -> stdenv.mkDerivation, it simplifies the derivation and doesn't make ofborg checks fail.

Result of nixpkgs-review pr 301313 run on x86_64-linux 1

1 package failed to build:

devcontainer

Result of nixpkgs-review pr 301313 run on x86_64-linux 1
1 package failed to build:
last 25 log lines:
       > source root is source
       > Running phase: patchPhase
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > no configure script, doing nothing
       > Running phase: buildPhase
       > yarn config v1.22.22
       > success Set "yarn-offline-mirror" to "/nix/store/ylsg2883c01hh9j1c8myb2law2i5cwgq-offline".
       > Done in 0.04s.
       > yarn install v1.22.22
       > [1/5] Validating package.json...
       > [2/5] Resolving packages...
       > [3/5] Fetching packages...
       > [] 0/554[] 11/554[] 19/554[] 30/554[] 48/554[] 63/554[] 83/554[] 97/554[] 103/554[] 110/554[] 126/554[] 143/554[] 150/554[] 160/554[] 175/554[] 188/554[] 190/554[] 195/554[] 196/554[] 197/554[] 202/554[] 203/554[] 206/554[] 212/554[] 218/554[] 232/554[] 253/554[] 278/554[] 296/554[] 318/554[] 337/554[] 355/554[] 373/554[] 389/554[] 410/554[] 428/554[] 443/554[] 467/554[] 481/554[] 502/554[] 513/554[] 529/554[] 548/554[] 550/554[] 551/554[] 552/554[] 553/554[4/5] Linking dependencies...
       > [] 554/554[] 0/589[] 0/16489[] 1021/16489[] 2155/16489[] 3290/16489[] 4432/16489[] 5693/16489[] 6960/16489[] 7938/16489[] 9203/16489[] 10098/16489[] 11445/16489[] 12960/16489[] 14471/16489[] 15738/16489[] 0/1017[5/5] Building fresh packages...
       >
       > [] 1017/1017error /build/source/node_modules/esbuild: Command failed.
       > Exit code: 127
       > Command: node install.js
       > Arguments:
       > Directory: /build/source/node_modules/esbuild
       > Output:
       > /bin/sh: node: not found
       > info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
       >
       For full logs, run 'nix log /nix/store/hvmnhqj0s7a0n2aicfgdjp5khzx5lnww-devcontainer-0.58.0.drv'.
error: 1 dependencies of derivation '/nix/store/mmp4x0x6jx43p60gwb4cyx7ncnvsvfxv-review-shell.drv' failed to build

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/301313

1 package failed to build:
devcontainer

Wow! That was unexpected! Surprisingly I had no problems to build it..

Result of nixpkgs-review pr 301313 run on x86_64-linux 1
1 package failed to build:
last 25 log lines:
       > source root is source
       > Running phase: patchPhase
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > no configure script, doing nothing
       > Running phase: buildPhase
       > yarn config v1.22.22
       > success Set "yarn-offline-mirror" to "/nix/store/ylsg2883c01hh9j1c8myb2law2i5cwgq-offline".
       > Done in 0.04s.
       > yarn install v1.22.22
       > [1/5] Validating package.json...
       > [2/5] Resolving packages...
       > [3/5] Fetching packages...
       > [] 0/554[] 11/554[] 19/554[] 30/554[] 48/554[] 63/554[] 83/554[] 97/554[] 103/554[] 110/554[] 126/554[] 143/554[] 150/554[] 160/554[] 175/554[] 188/554[] 190/554[] 195/554[] 196/554[] 197/554[] 202/554[] 203/554[] 206/554[] 212/554[] 218/554[] 232/554[] 253/554[] 278/554[] 296/554[] 318/554[] 337/554[] 355/554[] 373/554[] 389/554[] 410/554[] 428/554[] 443/554[] 467/554[] 481/554[] 502/554[] 513/554[] 529/554[] 548/554[] 550/554[] 551/554[] 552/554[] 553/554[4/5] Linking dependencies...
       > [] 554/554[] 0/589[] 0/16489[] 1021/16489[] 2155/16489[] 3290/16489[] 4432/16489[] 5693/16489[] 6960/16489[] 7938/16489[] 9203/16489[] 10098/16489[] 11445/16489[] 12960/16489[] 14471/16489[] 15738/16489[] 0/1017[5/5] Building fresh packages...
       >
       > [] 1017/1017error /build/source/node_modules/esbuild: Command failed.
       > Exit code: 127
       > Command: node install.js
       > Arguments:
       > Directory: /build/source/node_modules/esbuild
       > Output:
       > /bin/sh: node: not found
       > info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
       >
       For full logs, run 'nix log /nix/store/hvmnhqj0s7a0n2aicfgdjp5khzx5lnww-devcontainer-0.58.0.drv'.
error: 1 dependencies of derivation '/nix/store/mmp4x0x6jx43p60gwb4cyx7ncnvsvfxv-review-shell.drv' failed to build

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/301313

1 package failed to build:
devcontainer

This is totally unexpected since I can build the derivation myself, will try the nixpkgs review.
Thanks a lot for the review!

Result of nixpkgs-review pr 301313 run on x86_64-linux 1
1 package built:

devcontainer

@WolfangAukang It seems that it is working fine for me... should I add nodejs to the nativeBuildInputs list or not?

should I add nodejs to the nativeBuildInputs list or not?

After seeing some examples on Nixpkgs, it doesn't look like it is necessary

@WolfangAukang could you approve the PR if it is ok for you?

Result of nixpkgs-review pr 301313 run on x86_64-linux 1

1 package built:

devcontainer

@Rucadi are you able to use devcontainer with https://github.com/microsoft/vscode-remote-try-rust ? I also tried with the Go one.
❯ git clone https://github.com/microsoft/vscode-remote-try-rust
❯ /home/bbigras/.cache/nixpkgs-review/pr-301313/results/devcontainer/bin/devcontainer up --workspace-folder ./vscode-remote-try-rust
[1 ms] @devcontainers/cli 0.58.0. Node.js v20.11.1. linux 6.8.4 x64.
Error: ENOENT: no such file or directory, open '/nix/store/vbpyr6xdfrzsirsj2745d0z21yyva2kl-devcontainer-0.58.0/libexec/scripts/updateUID.Dockerfile'
{"outcome":"error","message":"ENOENT: no such file or directory, open '/nix/store/vbpyr6xdfrzsirsj2745d0z21yyva2kl-devcontainer-0.58.0/libexec/scripts/updateUID.Dockerfile'","description":"An error occurred setting up the container."}

Let me take a look, We are using this derivation at work successfully.

@bbigras can you try this version.
This is an older version that I did that for some reason didn't pass all the checks, and the errors seemed unrelated to my code and I decided to refactor it.
If this works, maybe you can help me fix the checks issues.

❯ LANG=c nix run github:Mic92/nixpkgs-review -- pr 301313 --post-result
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/301313/head:refs/nixpkgs-review/1
$ git worktree add /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs f173d0881eff3b21ebb29a2ef8bedbc106c86ea5
Preparing worktree (detached HEAD f173d0881eff)
Updating files: 100% (40890/40890), done.
HEAD is now at f173d0881eff Merge pull request #303351 from asymmetric/mnt-pkgs
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs nixpkgs-overlays=/tmp/tmpmm7e2izr -qaP --xml --out-path --show-trace --no-allow-import-from-derivation
$ git merge --no-commit --no-ff 115c17de80d18c081b9699b36fe941173f3857e7
Automatic merge went well; stopped before committing as requested
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs nixpkgs-overlays=/tmp/tmpmm7e2izr -qaP --xml --out-path --show-trace --no-allow-import-from-derivation --meta
error:
       … while evaluating the 'name' attribute of a derivation

         at «none»:0: (source not available)

       … from call site

         at /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:349:9:

          348|         in
          349|         lib.strings.sanitizeDerivationName (
             |         ^
          350|           if attrs ? name

       … while calling anonymous lambda

         at /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs/lib/strings.nix:1192:3:

         1191|   in
         1192|   string:
             |   ^
         1193|   # First detect the common case of already valid strings, to speed those up

       … from call site

         at /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs/pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:273:18:

          272|       version = attrs.version or package.version;
          273|       baseName = unlessNull name "${safeName}-${version}";
             |                  ^
          274|

       … while calling 'unlessNull'

         at /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs/pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:28:22:

           27|
           28|   unlessNull = item: alt:
             |                      ^
           29|     if item == null then alt else item;

       … from call site

         at /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs/pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:271:18:

          270|       pname = attrs.pname or package.name;
          271|       safeName = reformatPackageName package.name;
             |                  ^
          272|       version = attrs.version or package.version;

       … while calling 'reformatPackageName'

         at /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs/pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:31:25:

           30|
           31|   reformatPackageName = pname:
             |                         ^
           32|     let

       … from call site

         at /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs/pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:269:17:

          268|     let
          269|       package = lib.importJSON packageJSON;
             |                 ^
          270|       pname = attrs.pname or package.name;

       … while calling 'importJSON'

         at /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs/lib/trivial.nix:639:16:

          638|   */
          639|   importJSON = path:
             |                ^
          640|     builtins.fromJSON (builtins.readFile path);

       error: cannot build '/nix/store/6xrj98a0bbdij8j206zn2hy4lp3hvy96-source.drv^out' during evaluation because the option 'allow-import-from-derivation' is disabled
https://github.com/NixOS/nixpkgs/pull/301313 failed to build: Failed to list packages: nix-env failed with exit code 1
$ git worktree remove -f /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs

❯ LANG=c nix run github:Mic92/nixpkgs-review -- pr 301313 --post-result
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/301313/head:refs/nixpkgs-review/1
$ git worktree add /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs f173d0881eff3b21ebb29a2ef8bedbc106c86ea5
Preparing worktree (detached HEAD f173d0881eff)
Updating files: 100% (40890/40890), done.
HEAD is now at f173d0881eff Merge pull request #303351 from asymmetric/mnt-pkgs
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs nixpkgs-overlays=/tmp/tmpmm7e2izr -qaP --xml --out-path --show-trace --no-allow-import-from-derivation
$ git merge --no-commit --no-ff 115c17de80d18c081b9699b36fe941173f3857e7
Automatic merge went well; stopped before committing as requested
$ nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f <nixpkgs> --nix-path nixpkgs=/home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs nixpkgs-overlays=/tmp/tmpmm7e2izr -qaP --xml --out-path --show-trace --no-allow-import-from-derivation --meta
error:
       … while evaluating the 'name' attribute of a derivation

         at «none»:0: (source not available)

       … from call site

         at /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:349:9:

          348|         in
          349|         lib.strings.sanitizeDerivationName (
             |         ^
          350|           if attrs ? name

       … while calling anonymous lambda

         at /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs/lib/strings.nix:1192:3:

         1191|   in
         1192|   string:
             |   ^
         1193|   # First detect the common case of already valid strings, to speed those up

       … from call site

         at /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs/pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:273:18:

          272|       version = attrs.version or package.version;
          273|       baseName = unlessNull name "${safeName}-${version}";
             |                  ^
          274|

       … while calling 'unlessNull'

         at /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs/pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:28:22:

           27|
           28|   unlessNull = item: alt:
             |                      ^
           29|     if item == null then alt else item;

       … from call site

         at /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs/pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:271:18:

          270|       pname = attrs.pname or package.name;
          271|       safeName = reformatPackageName package.name;
             |                  ^
          272|       version = attrs.version or package.version;

       … while calling 'reformatPackageName'

         at /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs/pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:31:25:

           30|
           31|   reformatPackageName = pname:
             |                         ^
           32|     let

       … from call site

         at /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs/pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:269:17:

          268|     let
          269|       package = lib.importJSON packageJSON;
             |                 ^
          270|       pname = attrs.pname or package.name;

       … while calling 'importJSON'

         at /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs/lib/trivial.nix:639:16:

          638|   */
          639|   importJSON = path:
             |                ^
          640|     builtins.fromJSON (builtins.readFile path);

       error: cannot build '/nix/store/6xrj98a0bbdij8j206zn2hy4lp3hvy96-source.drv^out' during evaluation because the option 'allow-import-from-derivation' is disabled
https://github.com/NixOS/nixpkgs/pull/301313 failed to build: Failed to list packages: nix-env failed with exit code 1
$ git worktree remove -f /home/bbigras/.cache/nixpkgs-review/pr-301313-5/nixpkgs

That's the issue I don't really know how to solve with this version because this seems to come from yarn2nix :\
Another thing we could try is to put the package as a nodePackage here? pkgs/development/node-packages
I have not tested it.

@bbigras  Copying the scripts folder to libexec worked, got go container running, can you test it?
rucadi@Rucadi:~/vscode-remote-try-go$ ./result/bin/devcontainer up  --workspace-folder .
[1 ms] @devcontainers/cli 0.58.0. Node.js v20.11.1. linux 5.15.146.1-microsoft-standard-WSL2 x64.
[60684 ms] Start: Run: docker run --sig-proxy=false -a STDOUT -a STDERR --mount type=bind,source=/home/rucadi/vscode-remote-try-go,target=/workspaces/vscode-remote-try-go -l devcontainer.local_folder=/home/rucadi/vscode-remote-try-go -l devcontainer.config_file=/home/rucadi/vscode-remote-try-go/.devcontainer/devcontainer.json --init --cap-add SYS_PTRACE --security-opt seccomp=unconfined --entrypoint /bin/sh -l devcontainer.metadata=[{"id":"ghcr.io/devcontainers/features/common-utils:2"},{"id":"ghcr.io/devcontainers/features/git:1"},{"id":"ghcr.io/devcontainers/features/go:1","init":true,"capAdd":["SYS_PTRACE"],"securityOpt":["seccomp=unconfined"],"customizations":{"vscode":{"extensions":["golang.Go"]}}},{"id":"ghcr.io/devcontainers/features/node:1","customizations":{"vscode":{"extensions":["dbaeumer.vscode-eslint"]}}},{"customizations":{"vscode":{"settings":{"go.toolsManagement.checkForUpdates":"local","go.useLanguageServer":true,"go.gopath":"/go"},"extensions":["golang.Go"]}},"remoteUser":"vscode"},{"customizations":{"vscode":{"settings":{},"extensions":["streetsidesoftware.code-spell-checker"]}},"portsAttributes":{"9000":{"label":"Hello Remote World","onAutoForward":"notify"}}}] vsc-vscode-remote-try-go-1e8f635eb937962d232785b5335359d3eaea1fb45269cf7c4ae24bbfb145c935-uid -c echo Container started
Container started
{"outcome":"success","containerId":"f9f5c39363028ec688bc3f48c085650ee2a7c7419c2cdaaea7e9c2fe5b5a5f46","remoteUser":"vscode","remoteWorkspaceFolder":"/workspaces/vscode-remote-try-go"}
rucadi@Rucadi:~/vscode-remote-try-go$

❯ /home/bbigras/.cache/nixpkgs-review/pr-301313-7/results/devcontainer/bin/devcontainer up --workspace-folder .
[1 ms] @devcontainers/cli 0.58.0. Node.js v20.11.1. linux 6.8.4 x64.
[339 ms] Start: Run: docker start 03afc9bc34e32e6e05840bf1910f46695e141633fc54c3c961033c0c29752b81
[475 ms] 03afc9bc34e32e6e05840bf1910f46695e141633fc54c3c961033c0c29752b81
{"outcome":"success","containerId":"03afc9bc34e32e6e05840bf1910f46695e141633fc54c3c961033c0c29752b81","remoteUser":"vscode","remoteWorkspaceFolder":"/workspaces/vscode-remote-try-rust"}

:+1:

Result of nixpkgs-review pr 301313 run on x86_64-darwin 1

1 package built:

devcontainer

authors: Rucadi WolfangAukang bbigras nixos-discourse sikmir


text:
python312Packages.aiolifx: 1.0.1 -> 1.0.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.aiolifx is: Module for local communication with LIFX devices over a LAN
meta.homepage for python312Packages.aiolifx is: https://github.com/frawau/aiolifx
meta.changelog for python312Packages.aiolifx is: https://github.com/frawau/aiolifx/releases/tag/1.0.2
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.0.2 with grep in /nix/store/m8vfq364rsaqhh9gj6vjc76i5nw7d9hc-python3.12-aiolifx-1.0.2
found 1.0.2 in filename of file in /nix/store/m8vfq364rsaqhh9gj6vjc76i5nw7d9hc-python3.12-aiolifx-1.0.2

Rebuild report (if merged into master) (click to expand)

9 total rebuild path(s)

9 package rebuild(s)

First fifty rebuilds by attrpath
home-assistant-component-tests.lifx
python311Packages.aiolifx
python311Packages.aiolifx-connection
python311Packages.aiolifx-effects
python311Packages.aiolifx-themes
python312Packages.aiolifx
python312Packages.aiolifx-connection
python312Packages.aiolifx-effects
python312Packages.aiolifx-themes

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/m8vfq364rsaqhh9gj6vjc76i5nw7d9hc-python3.12-aiolifx-1.0.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.aiolifx https://github.com/r-ryantm/nixpkgs/archive/ececef9cce0975c2303f8b511a4eecad64c9a90e.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/ececef9cce0975c2303f8b511a4eecad64c9a90e#python312Packages.aiolifx

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/m8vfq364rsaqhh9gj6vjc76i5nw7d9hc-python3.12-aiolifx-1.0.2
ls -la /nix/store/m8vfq364rsaqhh9gj6vjc76i5nw7d9hc-python3.12-aiolifx-1.0.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

17 packages built:

home-assistant-component-tests.lifx
python311Packages.aiolifx
python311Packages.aiolifx-connection
python311Packages.aiolifx-connection.dist
python311Packages.aiolifx-effects
python311Packages.aiolifx-effects.dist
python311Packages.aiolifx-themes
python311Packages.aiolifx-themes.dist
python311Packages.aiolifx.dist
python312Packages.aiolifx
python312Packages.aiolifx-connection
python312Packages.aiolifx-connection.dist
python312Packages.aiolifx-effects
python312Packages.aiolifx-effects.dist
python312Packages.aiolifx-themes
python312Packages.aiolifx-themes.dist
python312Packages.aiolifx.dist

Maintainer pings
cc @netixx for testing.

Result of nixpkgs-review pr 302119 run on x86_64-linux 1

17 packages built:

home-assistant-component-tests.lifx
python311Packages.aiolifx
python311Packages.aiolifx-connection
python311Packages.aiolifx-connection.dist
python311Packages.aiolifx-effects
python311Packages.aiolifx-effects.dist
python311Packages.aiolifx-themes
python311Packages.aiolifx-themes.dist
python311Packages.aiolifx.dist
python312Packages.aiolifx
python312Packages.aiolifx-connection
python312Packages.aiolifx-connection.dist
python312Packages.aiolifx-effects
python312Packages.aiolifx-effects.dist
python312Packages.aiolifx-themes
python312Packages.aiolifx-themes.dist
python312Packages.aiolifx.dist

authors: fabaff r-ryantm