text:
feat: bump react-compiler version

Details
Use latest version of react-compiler.
Fixed Issues

$ N/A
PROPOSAL: N/A
Tests

test app as usual and be sure everything works as before

Offline tests
N/A
QA Steps

test app as usual and be sure everything works as before

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.18-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.18-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

authors: OSBotify kirillzyusko roryabraham


text:
Fix IOU amount input flicking on native platforms

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/53286
PROPOSAL: https://github.com/Expensify/App/issues/53286#issuecomment-2513758940
Tests

Launch the app.
Tap FAB > Create expense > Manual.
Enter the number 3.
Enter a decimal point. Verify that 3 is fully visible during the process.
Delete the number and input a large number (at least 8 digits).
Tap Next, then select a recipient.
On the confirmation page, tap the amount to edit it. Verify that the number pad and Next button are center-aligned.
Switch to a different currency. Verify that the number pad and Next button are still center-aligned.

[ ] Verify that no errors appear in the JS console

Offline tests

Launch the app.
Tap FAB > Create expense > Manual.
Enter the number 3.
Enter a decimal point. Verify that 3 is fully visible during the process.
Delete the number and input a large number (at least 8 digits).
Tap Next, then select a recipient.
On the confirmation page, tap the amount to edit it. Verify that the number pad and Next button are center-aligned.
Switch to a different currency. Verify that the number pad and Next button are still center-aligned.

QA Steps

Launch the app.
Tap FAB > Create expense > Manual.
Enter the number 3.
Enter a decimal point. Verify that 3 is fully visible during the process.
Delete the number and input a large number (at least 8 digits).
Tap Next, then select a recipient.
On the confirmation page, tap the amount to edit it. Verify that the number pad and Next button are center-aligned.
Switch to a different currency. Verify that the number pad and Next button are still center-aligned.

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
Error: Uncaught (in promise) TypeError: Failed to execute add' on Cache': Request scheme 'app' is unsupported
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
Unit tests are not added as this fixes a styling issue.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/f332e6a7-ccce-47a9-a413-b4381f2a4100

Android: mWeb Chrome
https://github.com/user-attachments/assets/a95cde2a-3e2b-486a-9a39-a75c6409784b

iOS: Native
https://github.com/user-attachments/assets/fb8f50b6-3609-4425-81b6-7e6664cf5db2

iOS: mWeb Safari
https://github.com/user-attachments/assets/d7efdebc-3964-4590-8a72-d93578647a1f

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/79926b56-6307-4ad0-a99d-7b8411ea5d43

MacOS: Desktop
https://github.com/user-attachments/assets/e48b2854-4458-4bad-898c-f9406d5a7624

Found this console error on the desktop app.

It's also found in 9.0.75-6.

@Expensify/design Could you please review this? Thanks!

Looks better to me from a visual perspective 👍

@brunovjk The following two lines happen to be in the same files as the changes in this PR and make the linter unhappy. If I'm responsible to do the migration, I can open a separate PR, as it's better not to include unrelated things here. What do you think?
https://github.com/Expensify/App/blob/1721cf48574b1093556a36405d9f4774df375b29/src/pages/iou/MoneyRequestAmountForm.tsx#L315
https://github.com/Expensify/App/blob/1721cf48574b1093556a36405d9f4774df375b29/src/styles/utils/index.ts#L293

@QichenZhu I believe we can try to migrate them here. The change in MoneyRequestAmountForm.tsx seems straightforward, following the guide. As for the change in styles/utils/index.ts Im not sure. Can we solve it in this PR? If you think it would be better to do it in another PR, that's fine, just tell and we'll pass it on to an internal member, and we'll go from there. What do you think?

@brunovjk Thanks for the suggestion! I’d be happy to handle it here if it’s straightforward.
Do these changes make sense to you?
https://github.com/Expensify/App/blob/2f4ae8224f6c28149730449ff664e599768989f1/src/pages/iou/MoneyRequestAmountForm.tsx#L317
policyID={policyID}

https://github.com/Expensify/App/blob/2f4ae8224f6c28149730449ff664e599768989f1/src/styles/utils/index.ts#L293
const transactionID = transaction?.parentTransactionID || transaction?.transactionID;

if (!transactionID) {
    return CONST.ERECEIPT_COLORS.YELLOW;
}

I’m just wondering if it’s sufficient because, even though we remove nullish coalescing from policyId passed to SettlementButton, the prop defined in SettlementButton itself still has a default value.
https://github.com/Expensify/App/blob/1466c022e3bb0ab2ffaaab12f78822a2aca827c8/src/components/SettlementButton/index.tsx#L49
If we migrate SettlementButton as well, more files might be affected, and we’d need to migrate even more files.

Great! Thanks @QichenZhu.
@VickyStash  could you take a look at this comment? I'm all for update the MoneyRequestAmountForm.tsx file, but not so much in changing App/src/styles/utils/index.ts here. What do you think?

@VickyStash could you take a look at this https://github.com/Expensify/App/pull/54189#issuecomment-2551159066? I'm all for update the MoneyRequestAmountForm.tsx file, but not so much in changing App/src/styles/utils/index.ts here. What do you think?

What are your concerns regarding App/src/styles/utils/index.ts changes?
As for SettlementButton - don't touch it in this PR I think. This file wasn't changed here, right?

What are your concerns regarding App/src/styles/utils/index.ts changes?

My main concern here is that this change might introduce unexpected behavior since it modifies a utility function used in multiple places. But, let's try, I will make sure to test it well! @QichenZhu can you can make these updates in MoneyRequestAmountForm.tsx and App/src/styles/utils/index.ts , about SettlementButton  I believe there would be no problem in leaving it as it is, later we should update it anyway. What do you think?

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@neil-marcellini do you think we should update the docs in FORMS.md here? Thanks.

@QichenZhu would you mind resolving the conflicts? Thanks.

Conflicts resolved.

Great, thank you. Retesting.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/bae3ee08-a5f8-40d7-b9b2-1dc84181c043

Android: mWeb Chrome

https://github.com/user-attachments/assets/0cc435d2-a38c-4a8c-ab46-22a211650db1

iOS: Native

https://github.com/user-attachments/assets/506843d1-d15e-4329-9c55-e53b78a48878

iOS: mWeb Safari

https://github.com/user-attachments/assets/0af9d481-036d-44cd-83a0-fbe0d5695fdb

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/9ed8c2c3-08fc-4575-ac02-426345c52401

MacOS: Desktop

https://github.com/user-attachments/assets/e1b0a63d-85f2-45f1-b05f-d316a6e36b3c

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

source: gharchive/pull-request

authors: OSBotify QichenZhu VickyStash brunovjk dubielzyk-expensify

repo: Expensify/App

license: MIT

license_type: permissive

license_source: github-api


text:
Fix /r/undefined issue

Details
When navigating to the site root in Expensify.cash we are redirecting to /r/undefined which looks pretty goofy. This PR adds a default parameter to the report route so the URL will never show undefined.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/157273
Tests
Web/Desktop

Navigate to e.cash and sign out if you are signed in to create a fresh session
Sign in
Verify you are brought to /r instead of /r/undefined and that a report is visible in the main content area

mWeb

Navigate to e.cash and sign out if you are signed in to create a fresh session
Sign in
Verify you see the LHN and not the most recent chat and that the url in the browser just says /r for now

iOS/Android

Navigate to e.cash and sign out if you are signed in to create a fresh session
Sign in
Verify we are not navigated to any chats
Swipe right and verify a chat exists

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Updated


text:
请问有没有oc版本的

Check List
Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

[ ] I have read the README.md, but there is no information I need.
[ ] I have searched in existing issues, but did find a same one.

Issue Description
Description
[Tell us about the issue]
Reproduce
[The steps to reproduce this issue. What are the parameters, where did you put your code, etc.]
Other Comment
[Add anything else here]

参考 issues #23。

source: gharchive/issue

repo: EyreFree/EFQRCode

license: mit

license_source: bigquery


text:
ContinuousProperty::setValuesOfFloatHdf5ArrayOfValues resets the property's minimum and maximum values

What are the steps to reproduce this issue?
I use a combination of one call to pushBackFloatHdf5ArrayOfValues and many calls to setValuesOfFloatHdf5ArrayOfValues to iteratively fill a continuous property.
What does happen?
The minimum and maximum values of the property get set to the minimum and maximum values of the last slab that was added (last call to setValuesOfFloatHdf5ArrayOfValues).
What were you expecting to happen?
I would expect the minimum and maximum values to be set to the minimum and maximum values of the full set of slabs that were set rather than those of the last added one.
Any logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
I actually know the minimum and maximum values before starting to fill the property but could not find a way to assign them to the property.
What versions of fesapi are you using?
0.16.0

The PR is actually pretty big! It will probably be hard to cherry pick in 0.16.
I can provide a quick fix for 0.16.0 if needed as a diff file or as a 0.16.1 release.
Feel very free to ask if needed. You can reopen this ticket for that.

authors: philippeVerney psaglio


text:
Changing the pool member state to "offline" generates an issue

Environment

Application Services Version: 3.47, 3.48 and 3.49
BIG-IP Version: v15.1

Summary
Changing a pool member "adminState": "enable" to "adminState": "offline" generates an issue.
On deployment, we don't observe this issue. Only on modification.
Steps To Reproduce
Steps to reproduce the behavior:

Submit the following declaration (the first member was enable, now offline):

"members": [
                    {
                        "adminState": "offline",
                        "shareNodes": true,
                        "serverAddresses": [
                            "10.241.154.5"
                        ],
                        "servicePort": 80,
                        "priorityGroup": 10
                    },
                    {
                        "adminState": "enable",
                        "shareNodes": true,
                        "serverAddresses": [
                            "10.241.154.6"
                        ],
                        "servicePort": 80,
                        "priorityGroup": 10
                    },
                    {
                        "adminState": "enable",
                        "shareNodes": true,
                        "serverAddresses": [
                            "10.241.154.7"
                        ],
                        "servicePort": 80,
                        "priorityGroup": 10
                    }
                ]

Observe the following error response:

"results": [
        {
            "code": 200,
            "message": "success",
            "lineCount": 18,
            "host": "localhost",
            "tenant": "Common",
            "runTime": 4988
        },
        {
            "code": 422,
            "message": "declaration failed",
            "response": "01020036:3: The requested Pool Member (/AP00080xPS2D/AP00080xPS2D_fastl4_310124__http_tcp_443/P_fastl4_310124_1_svc_sg_paas_echonet__http_443 /Common/consul-60EB62A9-1D5B-2168-9AED-05AF9F146F82-private 80) was not found.",
            "host": "localhost",
            "tenant": "AP00080xPS2D",
            "runTime": 2163
        },
        {
            "code": 200,
            "message": "success",
            "lineCount": 230,
            "host": "localhost",
            "tenant": "Common",
            "runTime": 5958
        }
    ],

Expected Behavior
AS3 should be able to change the state of a pool member, to offline, as before.
Actual Behavior
Worked with previous versions of AS3 .

Created Jira for this item AUTOTOOL-4237

Hi @jrooty, this has been fixed and will be released in AS3 3.50. If you need an easly build, please reach out to us at automation_toolchain_pm@f5.com

authors: jrooty mdditt2000 sunitharonan


text:
Autolog output directory is driving the suite name in trtl results

Description
When tox is run in nightly, the --autolog-outputdir provided to the tox command causes the suite name to be rooted (and thus named) from the / directory on the worker. We need to provide a .pytest.rootdir file near the tests, so suite name is made relative to the location of the tests, and thus is not filled with redundancies.

This fix is referenced in two PRs, so the issue failed to close, even though it was merged to master. Closing now.


text:
Make systests work with internal Jenkins CI system.

@pjbreaux, @mattgreene
What issues does this address?
Fixes #565
What's this change do?
Adds a Jenkinsfile to facilitate our move to Jenkins for internal systest CI.
Where should the reviewer start?
n/a
Any background context?
no

Holding off on the merge until we clear the next nightly run.

authors: larkinkevin mattgreene


text:
いいところ診断の結果に優しさを追加したい

以下の結果を追加したい
'{userName}のいいところは優しさです。あなたの優しい雰囲気や立ち振る舞いに多くの人が癒されています。'

これから対応します。

対応されました

repo: FH-git/assessment


text:
Updates gitignore.

Updates github/visual_studio, adds github/cmake
Includes current commit id, so changes can be tracked if necessary in future.
Closes #99

As of f3147b under linux, building in an alternative directory to build (i.e. build2) does not result in any un-ignored files.
This should also be tested and adjusted under windows (@Robadob) and then this will be ready to merge.

authors: Robadob ptheywood


text:
how do i move character, is there any script/event to do that?

help me if ya'll know

move in what way? like you want just to adjust its position in the stage in the whole song or after a specific time in the song its position changes?

help me if ya'll know

If you mean simply setting the character position, you can try and change the specific character's x or y variable like a variable.

(closing this since no answers for a while, feel free to reopen if you need

authors: Fawaazmh1 NexIsDumb PetscopF

repo: FNF-CNE-Devs/CodenameEngine


text:
Remove the "API" tab from staff members

Closes https://github.com/FOSSBilling/FOSSBilling/issues/320
I think we agreed that security wise it doesn't make sense to show the API key for other staff members, and the function never worked anyways since it would reset the API key for the current user, so let's just remove it entirely. Staff members can change their API key in their profile.

👍🏼

Can we also remove the related API endpoint? Other staff members shouldn’t be able to access others’ credentials.

Makes sense if the endpoint are still accessible it might be still able to be used

Can we also remove the related API endpoint? Other staff members shouldn’t be able to access others’ credentials.

The endpoint will only ever return the API key for the currently logged in staff member.
It get's the current identity when used and doesn't accept an input to get a different one

authors: BelleNottelling evrifaessa jaapmarcus

repo: FOSSBilling/FOSSBilling


text:
Optitype mapping error?

Hi,
I'm running optitype in rna mode for fastq.gz files. I get a large cryptic error that I'm not really able to figure out. Can someone help me translate this? See the command and error below:
Thanks,
-todd
OptiType-master/OptiTypePipeline.py --rna --verbose --config /Biomarker/ngs/software/OptiType/OptiType-master/config.ini -i /ts19/ngs/studies/ngs_000230/fastq/TB2-EM11595_R1.fastq.gz /ts19/ngs/studies/ngs_000230/fastq/TB2-EM11595_R2.fastq.gz -o /ts19/ngs/studies/ngs_000230/neoantigen_analysis/optitype
0:00:03.82 Mapping TB2-EM11595_R1.fastq.gz to NUC reference...
/home/mi/esiragusa/seqan/include/seqan/basic/basic_exception.h:368 FAILED!  (Uncaught exception of type seqan::UnexpectedEnd: Unexpected end of input.)
stack trace:
0          [0xa9d3f7]  /Biomarker/ngs/software/razers3/razers3-3.4.0-Linux-x86_64/bin/razers3()
1          [0xab37a6]  __cxxabiv1::terminate(void (*)()) + 0x6
2          [0xab37d3]  /Biomarker/ngs/software/razers3/razers3-3.4.0-Linux-x86_64/bin/razers3()
3          [0xab491e]  /Biomarker/ngs/software/razers3/razers3-3.4.0-Linux-x86_64/bin/razers3()
4          [0x76b253]  /Biomarker/ngs/software/razers3/razers3-3.4.0-Linux-x86_64/bin/razers3()
5          [0x7ce297]  void seqan::readRecord<seqan::String<char, seqan::Alloc >, seqan::String<seqan::SimpleType<unsigned char, seqan::Dna5Q>, seqan::Alloc >, seqan::String<char, seqan::Alloc >, seqan::Iter<seqan::VirtualStream<char, seqan::Tagseqan::Input_, std::char_traits >, seqan::StreamIterator<seqan::Tagseqan::Input_ > > >(seqan::String<char, seqan::Alloc >&, seqan::String<seqan::SimpleType<unsigned char, seqan::Dna5Q>, seqan::Alloc >&, seqan::String<char, seqan::Alloc >&, seqan::Iter<seqan::VirtualStream<char, seqan::Tagseqan::Input_, std::char_traits >, seqan::StreamIterator<seqan::Tagseqan::Input_ > >&, seqan::Tagseqan::TagFastq_) + 0x77
6          [0x81924c]  bool seqan::loadReads<MyFragStoreConfig, seqan::FragmentStoreConfig, seqan::RazerSOptions<seqan::RazerSSpec<false, false> > >(seqan::FragmentStore<MyFragStoreConfig, seqan::FragmentStoreConfig >&, seqan::FormattedFile<seqan::Tagseqan::TagFastq_, seqan::Tagseqan::Input_, void>&, seqan::RazerSOptions<seqan::RazerSSpec<false, false> >&) + 0x4ec
7          [0xa9c205]  int mapReads<seqan::RazerSSpec<false, false> >(seqan::StringSet<seqan::String<char, seqan::Alloc >, seqan::Owner<seqan::Tagseqan::Default_ > >&, seqan::StringSet<seqan::String<char, seqan::Alloc >, seqan::Owner<seqan::Tagseqan::Default_ > >&, seqan::RazerSOptions<seqan::RazerSSpec<false, false> >&) + 0x4c5
8          [0x76287f]  main + 0x22f
9      [0x31e101ed1d]  __libc_start_main + 0xfd
10          [0x763039]  /Biomarker/ngs/software/razers3/razers3-3.4.0-Linux-x86_64/bin/razers3()
0:00:03.99 Mapping TB2-EM11595_R2.fastq.gz to NUC reference...
/home/mi/esiragusa/seqan/include/seqan/basic/basic_exception.h:368 FAILED!  (Uncaught exception of type seqan::UnexpectedEnd: Unexpected end of input.)
stack trace:
0          [0xa9d3f7]  /Biomarker/ngs/software/razers3/razers3-3.4.0-Linux-x86_64/bin/razers3()
1          [0xab37a6]  __cxxabiv1::terminate(void (*)()) + 0x6
2          [0xab37d3]  /Biomarker/ngs/software/razers3/razers3-3.4.0-Linux-x86_64/bin/razers3()
3          [0xab491e]  /Biomarker/ngs/software/razers3/razers3-3.4.0-Linux-x86_64/bin/razers3()
4          [0x76b253]  /Biomarker/ngs/software/razers3/razers3-3.4.0-Linux-x86_64/bin/razers3()
5          [0x7ce297]  void seqan::readRecord<seqan::String<char, seqan::Alloc >, seqan::String<seqan::SimpleType<unsigned char, seqan::Dna5Q>, seqan::Alloc >, seqan::String<char, seqan::Alloc >, seqan::Iter<seqan::VirtualStream<char, seqan::Tagseqan::Input_, std::char_traits >, seqan::StreamIterator<seqan::Tagseqan::Input_ > > >(seqan::String<char, seqan::Alloc >&, seqan::String<seqan::SimpleType<unsigned char, seqan::Dna5Q>, seqan::Alloc >&, seqan::String<char, seqan::Alloc >&, seqan::Iter<seqan::VirtualStream<char, seqan::Tagseqan::Input_, std::char_traits >, seqan::StreamIterator<seqan::Tagseqan::Input_ > >&, seqan::Tagseqan::TagFastq_) + 0x77
6          [0x81924c]  bool seqan::loadReads<MyFragStoreConfig, seqan::FragmentStoreConfig, seqan::RazerSOptions<seqan::RazerSSpec<false, false> > >(seqan::FragmentStore<MyFragStoreConfig, seqan::FragmentStoreConfig >&, seqan::FormattedFile<seqan::Tagseqan::TagFastq_, seqan::Tagseqan::Input_, void>&, seqan::RazerSOptions<seqan::RazerSSpec<false, false> >&) + 0x4ec
7          [0xa9c205]  int mapReads<seqan::RazerSSpec<false, false> >(seqan::StringSet<seqan::String<char, seqan::Alloc >, seqan::Owner<seqan::Tagseqan::Default_ > >&, seqan::StringSet<seqan::String<char, seqan::Alloc >, seqan::Owner<seqan::Tagseqan::Default_ > >&, seqan::RazerSOptions<seqan::RazerSSpec<false, false> >&) + 0x4c5
8          [0x76287f]  main + 0x22f
9      [0x31e101ed1d]  __libc_start_main + 0xfd
10          [0x763039]  /Biomarker/ngs/software/razers3/razers3-3.4.0-Linux-x86_64/bin/razers3()
0:00:04.85 Generating binary hit matrix.
Traceback (most recent call last):
File "/Biomarker/ngs/software/OptiType/OptiType-master/OptiTypePipeline.py", line 275, in
pos, read_details = ht.pysam_to_hdf(bam_paths[0])
File "/Biomarker/ngs/software/OptiType/OptiType-master/hlatyper.py", line 177, in pysam_to_hdf
sam = pysam.AlignmentFile(samfile, sam_or_bam)
File "pysam/calignmentfile.pyx", line 311, in pysam.calignmentfile.AlignmentFile.cinit (pysam/calignmentfile.c:4929)
File "pysam/calignmentfile.pyx", line 480, in pysam.calignmentfile.AlignmentFile._open (pysam/calignmentfile.c:6905)
IOError: file /ts19/ngs/studies/ngs_000230/neoantigen_analysis/optitype/TB2-EM11595/2018_03_02_10_16_01_1.bam not found

That's strange, because OptiType (or rather the mapper RazerS) can take fastq.gz input, and I've never seen it fail with them. Was the gzipped file surely not corrupted? Did it happen to other gzipped files too?

I tried it on several sets of fastq.gz files and got the above error every time. Once I gunzipped them, everything proceeded normally. That's really the best information I got for you.


text:
Tune PID

Found some really good discussion about tuning PIDF for velocity closed loops:
https://www.chiefdelphi.com/forums/showthread.php?t=152106
In particular, responses # 7 and # 22 seem to be what we'd want to work with to get this running right.

Also found another team that got very similar values to us for the Talons:  https://github.com/RVRProgramming/Diablo2018/blob/master/subsystems/driveBase.py


text:
Idea/Feature request: finer-grained progress indication

It would be great if F* was able to report per-assert/per-VC progress while verifying a chunk of code — I think it'd help a lot with interactivity and identifying which bits of a proof are slow.
I don't have a clear picture of what the UI would be like yet, but I could imagine a few possibilities:

Adding a count after the F* icon in the modeline — something like F⍟[Verifying: 3/5].
Adding a summary of the actual VC after the F* icon in the modeline — something like F⍟[Verifying (3/5): x < 0 /\ …].
Highlighting the VC(s) being verified using overlays directly in the buffer
Logging to the messages buffer, or a side buffer

This feature exists in Emacs' dafny-mode, and I find it quite convenient.  If I understand correctly, the main obstacle here is that F* make put multiple VCs/asserts into a single SMT query. Is there a way to achieve something like the above despite this encoding detail?
Another issue is ranges — F* has pretty good ranges, but there are issues sometimes.  Assuming people take the time to report range problems, though, these should be pretty quickly ironed out.
Are there other issues that I'm not thinking about? (I has something like this in mind as I worked on the JSON protocol, so I don't expect roadblocks on that side)

This would be a nice feature. Of the various possibilities you mention all but one make good sense, since our VCs are simply to big to display in the modline.

Neat, thanks! I wasn't thinking of the encoded VCs; rather (a prefix of) the corresponding F* code, but I agree that that option sounds tricky.

This might be easier for tactics; cc @mtzguido

authors: catalin-hritcu cpitclaudel

repo: FStarLang/FStar


text:
refactor: use attributes

supercedes https://github.com/FZJ-INM1-BDA/siibra-python/pull/553

attn @AhmetNSimsek
per our discussion, here is the WIP
left to do:
refactor todo list

[ ] update siibra/attr/meta/doi -> siibra/attr/meta/url

[ ] update schema
[ ] update key url -> value

[ ] update siibra/attr/data/voi -> siibra/attr/data/image

[ ] update schema

[ ] update regionspec

[ ] fix property key name -> value

[ ] reimplement autocomplete all modalities
[ ] reimplement matching between attributes

[ ] regionspec match

[ ] move cache to root level module
[ ] add more attr comparison
[ ] add test for attr comparison
[ ] reimplement volume providers?
[ ] consider using standard json-ld schema, context etc

region.find is not deterministic and rather slow. I am noting down to investigate later.

@xgui3783, I think we should remove the dataclass decorators from classes that inherit other a class that has a dataclass decorator. Because it creates unexpected behaviors such as some methods are overridden and very difficult to debug as it is an unexpected behavior.
Regarding being explicit: if a class A inherits a class B with dataclass decorators, the developer would know that A is also a dataclass. So, by repeating the 2 lines required to decorate class A as a dataclass, we break DRY, we face unexpected behavior, and we don't gain anything besides being explicit which is not really necessary in this context.

To profile and improve:

[ ] get_map is very slow. It does not speed up after first use.
[ ]

Known bugs:

[ ]

Other issues:(

[ ] get_parcellation does not return the newest parcellation

@xgui3783 Please edit and add/update more as we move forward to keep track of finer details


text:
Makefiles: add OUTPUT_NAME and THIS_TASK, minor updates

Modify all hands-on Makefiles to include current task and dynamic output file name so that
any output generated by tasks can be distinguished (and not all files have the same name).

All existing .master/Makefile renamed to Makefile.in
Add @@TASKSOL@@ replacement pattern to Makefile.in
Running copy.mk preprocesses replacement pattern depending on destination (task/sol)
Use OUTPUT_NAME with exercise and timestamp, e.g. jacobi.08H-NCCL-sol__20241114-1951.0.nsys-rep

Minor:

Fix 06-H Readme

Looks good to me!

authors: AndiH mhrywniak

repo: FZJ-JSC/tutorial-multi-gpu


text:
get real sql from statement

Hello,
is there a way to get the real sql from the statement.
For example:

$selectStm = $slimPdo
->select()
->from('users')
->where('id','=',$id);
        $stm = $selectStm->execute();
        $data = $stm->fetchAll();

$mySql = $selectStm->getSql();

Your sincerly
Stephan

You can try $stm->debugDumpParams();
(documentation)

With version 2.x, you can simply call __toString() on any of the query objects to get their SQL representation.   For example:
$selectStm = $slimPdo
    ->select()
    ->from('users')
    ->where('id','=',$id);

$selectStm->__toString();

Please note that you cannot get the rendered SQL with the parameters escaped in the query.  This takes a lot of work to render and there is no out of the box solution from Zend.

authors: StephanKrauss belavina kwhat

repo: FaaPz/Slim-PDO


text:
Attribute ending in backslash fails formatting

An attribute like:
<absPath url="D:\Users\kgunders\Documents\MR\Projects\HyperLinkSheets"
Will cause the following error:
XML formatting failed: at line 2, column 694: namespace prefix must be followed by a tag name.
Here is more context from the problematic XML:
	<Choice Requires="x15">
		<absPath url="D:\Users\kgunders\Documents\MR\Projects\HyperLinkSheets\" xmlns:x15ac="http://schemas.microsoft.com/office/spreadsheetml/2010/11/ac" />
	</Choice>

A work around is to temporarily add a character after the backslash, format, and remove the extra character.

@KarlGunderson Thank you for this hint. I'm looking into it right now 👍

This problem is now fixed in the XML library. There'll be an update for the extension soon 😃

authors: FabianLauer KarlGunderson

repo: FabianLauer/vs-code-xml-format