text:
forge script reverts likely due to incorrect data construction

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.0.2 (532ef5e 2024-04-22T00:22:39.180249000Z)
What command(s) is the bug in?
forge script
Operating System
macOS (Apple Silicon)
Describe the bug
forge script is likely constructing the incorrect data leading to the following error:
Sending transactions [0 - 0].
The application panicked (crashed).
Message:  called `Result::unwrap()` on an `Err` value: JsonRpcClientError(JsonRpcError(JsonRpcError { code: 3, message: "execution reverted", data: Some(String("0x")) }))
Location: crates/forge/bin/cmd/script/broadcast.rs:669

Check out the warp block: https://app.warp.dev/block/F0yTm0BDEqyyYdN327UZuF
Repo: https://github.com/sablier-labs/v2-core/

+1 Same issues faced by me

@smol-ninja thanks for posting the issue, it should not panic here so we will be investigating.

@andreivladbrg can you link the HH implementation. Will be quicker to debug. I am able to debug this now.
When you say "...uses an unknown opcode" - can you elaborate. Are you using an unknown opcode?

nvm found the hh branch. Will investigate.

Are you using an unknown opcode?

No, we are not using any special opcode. We saw this bug when we tried to deploy contracts with Foundry. But we thought it may be a bug with Foundry itself. So Andrei ported the code to HH and saw the same error again. That's why we are guessing if it's related to one of the libraries that we import.

@smol-ninja @andreivladbrg still need to investigate Foundry but the HH implementation worked fine for me with minor changes. See below details:

Fork with changes: https://github.com/sablier-labs/v2-core/commit/1509209475fc95ea6e3f71a89053adb279fbfcdd

Successful HH deployment / verification output:
bun run hardhat deploy-zksync --script deploy.ts --network zkSyncTestnet
┌─────────────────┬──────────────────────────────────────────────────────────────────────────────────────────────────┐
│     (index)     │                                              Values                                              │
├─────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────┤
│    contract     │ 'SablierV2Comptroller & SablierV2NFTDescriptor & SablierV2LockupDynamic & SablierV2LockupLinear' │
│     chainId     │                                               300                                                │
│     network     │                                         'zkSyncTestnet'                                          │
│ deployerAddress │                           '0x7182fA7dF76406ffFc0289f36239aC1bE134f305'                           │
└─────────────────┴──────────────────────────────────────────────────────────────────────────────────────────────────┘
SablierV2Comptroller deployed to: 0x07CC4deb26e09EfEf5eFF579b9Cb2cC4616cc8D1

Verifying contract...
Your verification ID is: 11531
Contract successfully verified on zkSync block explorer!
SablierV2NFTDescriptor deployed to: 0xD479fd546cb4fCe8509Ee4B48D29B4b0C5324287

Verifying contract...
Your verification ID is: 11532
Contract successfully verified on zkSync block explorer!
SablierV2LockupDynamic deployed to: 0xE40C678FdC1211156FA531251E758650F2BAcD43

Verifying contract...
Your verification ID is: 11533

Your verification request has been sent, but our servers are currently overloaded and we could not confirm that the verification was successful.
Please try one of the following options:
  1. Use the your verification request ID (11533) to check the status of the pending verification process by typing the command 'yarn hardhat verify-status --verification-id 11533'
  2. Manually check the contract's code on the zksync block explorer: https://explorer.zksync.io/
  3. Run the verification process again

Contract successfully verified on zkSync block explorer!
SablierV2LockupLinear deployed to: 0xB959FE756Be7Df5118f089571e3b156a0C4e4af2

Verifying contract...
Your verification ID is: 11534

Your verification request has been sent, but our servers are currently overloaded and we could not confirm that the verification was successful.
Please try one of the following options:
  1. Use the your verification request ID (11534) to check the status of the pending verification process by typing the command 'yarn hardhat verify-status --verification-id 11534'
  2. Manually check the contract's code on the zksync block explorer: https://explorer.zksync.io/
  3. Run the verification process again

Contract successfully verified on zkSync block explorer!

Indeed, it works for the testnet. But when trying to deploy on the mainnet, it doesn't: https://app.warp.dev/block/R8pSjMJQWIljGSczzTNmTy
It also works with Foundry for the testnet.

ahhh interesting....

I was able to reproduce, and its certainly a weird issue as it works locally, testnet, forked mainnet but not on mainnet. Investigating the contract further as it seems thats where the issue may be. Will provide an update if I find anything.

@smol-ninja interesting, for me SablierV2Comptroller gets deployed, and verified fine. But then I hit the error during SablierV2NFTDescriptor deployment with:
Error: execution reverted (no data present; likely require(false) occurred ...

I never get to SablierV2LockupDynamic or SablierV2LockupLinear  deployment...

Oh. For me, with foundry-zksync, I was able to deploy SablierV2NFTDescriptor as well. But hit that  Some(String("0x")) error with LockupLinear and LockupDynamic. I now think Some(String("0x")) is foundry version of HH's no data present.
Could it be related to RPC nodes? (I am coming from the point that sometimes SablierV2NFTDescriptor gets deployed and sometimes it doesn't so could be related to RPCs)

I got it working !!!

Had to deploy the SVG libraries first, typically we should have seen the compiler complain about these during compilation. Why it did not, I will have to investigate.
But mainnet output:
┌─────────────────┬──────────────────────────────────────────────────────────────────────────────────────────────────┐
│     (index)     │                                              Values                                              │
├─────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────┤
│    contract     │ 'SablierV2Comptroller & SablierV2NFTDescriptor & SablierV2LockupDynamic & SablierV2LockupLinear' │
│     chainId     │                                               324                                                │
│     network     │                                         'zkSyncMainnet'                                          │
│ deployerAddress │                           '0xFac041BCF2c4b43319c2C0a39ABA53F4CbE44Fe5'                           │
└─────────────────┴──────────────────────────────────────────────────────────────────────────────────────────────────┘
NFTSVG deployed to: 0x232f9F448590308acB4A2d08360Ca377e8d87fAb
SVGElements deployed to: 0x064fF5DDc4d6746fa09aB42A4f671e34aeCee4eE
SablierV2Comptroller deployed to: 0xD302AF3c16DC00Cb7b6E7976eA7BeAdba3A466B5

Verifying contract...
Your verification ID is: 61426
Contract successfully verified on zkSync block explorer!
SablierV2NFTDescriptor deployed to: 0xA53121afA76d665FEF26B62dC6AC23FE45dF1116

Verifying contract...
Your verification ID is: 61427
Contract successfully verified on zkSync block explorer!

SablierV2LockupDynamic deployed to: 0x3e076cFDA872A906F549dB819e7edC048963AfB0

Verifying contract...
Your verification ID is: 61428

Your verification request has been sent, but our servers are currently overloaded and we could not confirm that the verification was successful.
Please try one of the following options:
  1. Use the your verification request ID (61428) to check the status of the pending verification process by typing the command 'yarn hardhat verify-status --verification-id 61428'
  2. Manually check the contract's code on the zksync block explorer: https://explorer.zksync.io/
  3. Run the verification process again

Contract successfully verified on zkSync block explorer!
SablierV2LockupLinear deployed to: 0xbf16A3472b6659360f1A589C99A18a32d7e27825

Verifying contract...
Your verification ID is: 61429
Contract successfully verified on zkSync block explorer!

Deploy script:
import { Addressable } from "ethers";
import hre from "hardhat";
import { Deployer } from "@matterlabs/hardhat-zksync";
import { Wallet, Provider } from "zksync-ethers";

export default async function () {
  const network = await hre.network.config;
  const networkName = await hre.network.name;
  const chainId = Number(network.chainId);

  const provider = new Provider(hre.network.config.url);
  const deployerAddressPV = new Wallet(process.env.PV_KEY as string).connect(provider);
  const deployerAddress = deployerAddressPV.address;

  if (!deployerAddress) {
    console.error("Please set the PV_KEY in your .env file");
    return;
  }

  console.table({
    contract: "SablierV2Comptroller & SablierV2NFTDescriptor & SablierV2LockupDynamic & SablierV2LockupLinear",
    chainId: chainId,
    network: networkName,
    deployerAddress: deployerAddress,
  });

  const deployer = new Deployer(hre, deployerAddressPV);

  const artifactSVG = await deployer.loadArtifact("NFTSVG");
  const artifactSVGElements = await deployer.loadArtifact("SVGElements");
  const artifactComptroller = await deployer.loadArtifact("SablierV2Comptroller");
  const artifactNFTDescriptor = await deployer.loadArtifact("SablierV2NFTDescriptor");
  const artifactLockupDynamic = await deployer.loadArtifact("SablierV2LockupDynamic");
  const artifactLockupLinear = await deployer.loadArtifact("SablierV2LockupLinear");

  const safeMultisig = "0xaFeA787Ef04E280ad5Bb907363f214E4BAB9e288";

  const svg = await deployer.deploy(artifactSVG, []);
  console.log("NFTSVG deployed to:", svg.target);
  const svg_element = await deployer.deploy(artifactSVGElements, []);
  console.log("SVGElements deployed to:", svg_element.target);

  // Deploy the SablierV2Comptroller contract
  const comptroller = await deployer.deploy(artifactComptroller, [safeMultisig]);

  const comptrollerAddress =
    typeof comptroller.target === "string" ? comptroller.target : comptroller.target.toString();
  console.log("SablierV2Comptroller deployed to:", comptrollerAddress);
  await verifyContract(comptrollerAddress, [safeMultisig]);

  const nftDescriptor = await deployer.deploy(artifactNFTDescriptor, []);
  const nftDescriptorAddress =
    typeof nftDescriptor.target === "string" ? nftDescriptor.target : nftDescriptor.target.toString();
  console.log("SablierV2NFTDescriptor deployed to:", nftDescriptorAddress);
  await verifyContract(nftDescriptorAddress, []);

  // Deploy the SablierV2LockupDynamic contract
  const dynamic = await deployer.deploy(artifactLockupDynamic, [
    safeMultisig,
    comptrollerAddress,
    nftDescriptorAddress,
    "324",
  ]);
  const dynamicAddress = typeof dynamic.target === "string" ? dynamic.target : dynamic.target.toString();
  console.log("SablierV2LockupDynamic deployed to:", dynamicAddress);
  await verifyContract(dynamicAddress, [safeMultisig, comptrollerAddress, nftDescriptorAddress, "324"]);

  // Deploy the SablierV2LockupLinear contract
  const linear = await deployer.deploy(artifactLockupLinear, [safeMultisig, comptrollerAddress, nftDescriptorAddress]);
  const linearAddress = linear.target;
  console.log("SablierV2LockupLinear deployed to:", linearAddress);
  await verifyContract(linearAddress, [safeMultisig, comptrollerAddress, nftDescriptorAddress]);
}

const verifyContract = async (contractAddress: string | Addressable, verifyArgs: string[]): Promise<boolean> => {
  console.log("\nVerifying contract...");
  await new Promise((r) => setTimeout(r, 20000));
  try {
    await hre.run("verify:verify", {
      address: contractAddress.toString(),
      constructorArguments: verifyArgs,
      noCompile: true,
    });
  } catch (e) {
    console.log(e);
  }
  return true;
};

Yes I got it except I didn't understand why did you have to deploy the libraries separately? They are a part of SablierV2NFTDescriptor and ain't required to be deployed separately.

Still investigating the reasoning and asked our platform team to review, as it does not really fit into the requirements for non-inlinable libraries described here.

Yes. We will follow your lead and make the deployment. So I guess we cannot deploy it with foundry because foundry does not allow deploying libraries separately if they do not contain public or external functions, which is true in our case.
In your method, you deployed them separately using hardhat which is weird but great it worked. And during the deployments of SablierV2NFTDescriptor, the libraries still got embedded in the bytecode of SablierV2NFTDescriptor so SablierV2NFTDescriptor is not going to make delegate call to the deployed libraries. Hmm..
Anyways since it worked thank you so much for the help for your help 💚.

@smol-ninja not a problem! We will be investigating it further so will provide an update when I can.

@dutterbutter thank you for the help and effort 🙏🏻
Looking forward to hearing from you. I'm super curious about this library situation - it just seems weird to me for now.

Just wanted to say that I also tried to deploy them again using your approach (deploying the libraries) and had no succes for SablierV2LockupDynamic and SablierV2LockupLinear but for SablierV2NFTDescriptor it worked.
I also tried to deploy Helpers lib which is used in both lockup contracts.

Adding a point here: I was able to deploy SablierV2NFTDescriptor without deploying libraries separately. It worked for me in the foundry setup too.
Also SablierV2LockupDynamic and SablierV2LockupLinear do not depend on those SVG libraries at all. So may be thats why this is not working for us. @dutterbutter are you able to deploy the contracts again? May be it was one time (just guessing).

Merged your changes into our repo: https://github.com/sablier-labs/v2-core/pull/910
But no succes: https://app.warp.dev/block/TGKda5YweBv53alWCZzrfw

I am noticing a difference in the import path in the contract deployed on mainnet.
Referring to this line:
https://github.com/sablier-labs/v2-core/blob/c167d50189ca11b67156cf8eabe371c2de638abf/contracts/SablierV2LockupLinear.sol#L7
Onchain, it appears like this:

Could it be related to remappings, and it can't figure out where that contract is?

YESS! This was the reason why it reverted (Foundry remappings vs Hardhat remappings)...
I removed the @prb/math remapping and it worked: https://app.warp.dev/block/a84UReQJG24ncPo23ZSVvk

Yes, it looks like it was from remappings:
@prb/math/=node_modules/@prb/math/
Although I had not made any changes to the contracts. Perhaps something hardhat-foundry plugin produced?

YESS! This was the reason why it reverted (Foundry remappings vs Hardhat remappings)...
I removed the @prb/math remapping and it worked: https://app.warp.dev/block/a84UReQJG24ncPo23ZSVvk

Amazing 🎉  👍  Glad it worked!!

Though, why did the testnet deployment work without removing the remapping, but it didn’t work for the mainnet? @dutterbutter

@dutterbutter do the fork tests in foundry-zksync follow zksync op codes for gas estimation?

authors: andreivladbrg dutterbutter smol-ninja

repo: matter-labs/foundry-zksync


text:
#248

Fixed below.

EventFiltering does not work, if the count of "parameterFilters" is 1.
Also does not work, if events have jumping indexed parameters.

This fix #248

Thanks! Please, apply yourself to https://gitcoin.co/issue/matter-labs/web3swift/248/4132
cc @BaldyAsh could you please review this fix?

@hakumai-iida thanks!

@skywinder
@BaldyAsh
Thank you very much for the merging.
I have deleted my temporary fork.
It was good to be helpful.
Best regards.

source: gharchive/pull-request

authors: BaldyAsh hakumai-iida skywinder

license_type: permissive

license_source: github-api


text:
Added Note for User Discovery on Same Server

Summary
This PR adds a note as specified in the issue #6590 to keep the Admins informed about the User Discovery on the same server.
Ticket Link
Fixes #6590

Hello @Rutam21,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@cwarnermm Please review and suggest changes, if any. Thanks.

repo: mattermost/docs


text:
Upload file feature: File is downloaded entirely before uploading to Google Drive

Original discussion https://community.mattermost.com/core/pl/3cdyjphkjpgcmfuk5bhsu6byec
At the moment, the Drive app downloads the entire file contents from Mattermost before uploading the file to Drive. This could pose an issue if we're dealing with large files, as the lambda functions have a limited amount of RAM available.
A short term solution would be to limit the file size of files that can be uploaded with this feature. The limit our team has proposed is 50MB.

From AWS docs https://docs.aws.amazon.com/lambda/latest/operatorguide/computing-power.html:

The Lambda console defaults new functions to the smallest setting and many developers also choose 128 MB for their functions.

https://github.com/mattermost/mattermost-app-google-drive/blob/3992a1a52b224283292bba76752f811efbdd2aad/src/forms/upload-google.ts#L96-L111

@mickmister Is this issue still valid given the changes in https://github.com/mattermost/mattermost-app-google-drive/pull/2?

source: gharchive/issue

authors: hanzei mickmister

repo: mattermost/mattermost-app-google-drive


text:
Blog posts: a deep dive into a Go compiler bug fix

Summary
This PR adds three blog posts (which were originally conceived as a single one) on how I investigated and fixed my first bug in the Go compiler. You can preview the three parts here:

Part 1
Part 2
Part 3

The intended audience for the posts are developers that do not have any experience contributing to compilers.
This is a long long read, so feel free to review each post separately. Also, feel free to decline the review if you do not have time, no problem at all! And, finally, this is not high priority at all, so no rush with the review, I already took my time to write it, so we can take more time to review it.
@justinegeffen and @cwarnermm: I did not know who to ping here, so I pinged both of you, just so you can decide who has the bad luck of reviewing this.
Ticket Link
https://mattermost.atlassian.net/browse/MM-32531

I'll review this, thanks @agarciamontoro!

Thank you for the awesome review, @justinegeffen! I added all of your suggestions, except for the two changing the dashes, where I left a comment.

Thank you for the huge review, Justine, I really appreciate it!

This is on review by the marketing team in a separate Google Doc. I'll close this PR when the post is published :)

This is already in the hands of the Marketing team and they'll finish reviewing it. So first reviewers of these posts: no worries, you don't need to review it again.
The changes here are structural. I converted the three posts into two stories: a study on SSA and rewrite rules, and a two-part investigation of the specific issue to fix. As the SSA post was a bit dull, I added a deeper explanation on one specific rewrite rule, which I had removed in a first draft because it made everything too long. With the restructure, it made sense to bring it back, and now I think both stories are more self-consistent. That's the only change in content, the other changes are just moving stuff around to adapt to this structure of two stories.
@BenLloydPearson, feel free to take the contents of this and move it to the Google Docs for your team to make the final review.

Only the first post will be published. Closing this since it is already in the content team's hands. Thank you everyone who reviewed the whole thing, I will publish the whole original thing in my personal blog :)

authors: agarciamontoro justinegeffen


text:
iOS Share Extension crashes

Summary
If AppGroupId was not set correct, iOS share extension crashes.
mattermost-mobile/share_extension/ios/extension.js
mattermostBucket.readFromFile('entities', props.appGroupId).then((value) => {
            this.entities = value || initialState;
            this.setState({init: true});
});

this.entities = value || initialState;
must be
this.entities = value || initialState.entities;

Environment Information

Device Name: all iOS device
OS Version: Test on iOS 12
Mattermost App Version: 1.12.0

Hey @powhu great catch, two questions

are you building the app yourself? we do have a fastlane script that should set the correct appGroupId
will you be willing to submit a PR to fix it?

#2242

PR submitted

authors: enahum powhu

repo: mattermost/mattermost-mobile


text:
[MM-11145] Fix embedded long URL in message attachment

Summary
Fix embedded long URL in message attachment.
It happened when attachment.text is partially forwarded to Markdown component. So instead of slicing the attachment.text when it's greater than the cap multilines or text' length, such text is fully rendered on Markdown component and just hide/show when it has overflow (depends on height). Implementation is similar to long post feature.
Ticket Link
Jira ticket: MM-11145
Checklist

[x] Has UI changes

Device Information
This PR was tested on: [iOS simulator and Android emulator]
Screenshots
Broken (before fix):

iOS (fixed):

https://youtu.be/ktJkQwBYBNQ

Android (fixed):

Rebase to latest and fixed merge conflicts.


text:
MM-11728: Reload channel on archived channel errors (on edit and archive channel)

Summary
Reload channel on archived channel errors (on edit and archive channel).
When you are seing an archived channel and don't have the connection
active, you can miss the websocket event for mark the channel as
deleted. So you will see the channel in normal state. This will reload
the channel when the server returns the fail on edition or when you try
to archive the channel.
Ticket Link
MM-11728
Device Information
This PR was tested on: [One Plus 5, Android 8.1]

@enahum good question, I know that the channel is deleted, but I don't know when was deleted, so I can set the deleteAt field to "now" but would be inconsistent with the server deleteAt date.

@jespino, is that consistency relevant? Do we do anything with that date at the client level? If not then I see no harm on doing it

@enahum I'm not sure if now we are doing anything in the RN application, but I would expect to see the "Archive date" in the channel info in the future. Leave that inconsistency there is error prone for future usage of the "archive date" and hard to detect.

Ok I see you point, lets have this as is and we can look at other options if needed

authors: enahum jespino


text:
Update README.md

Updated minimum required iOS version to 13.4.

/cherry-pick release-2.18

Cherry pick is scheduled.

authors: amyblais mattermost-build


text:
Add mocks and unit tests to http and msgraph packages

Added a mocks package that mocks out the functionality of some the
interfaces needed by the oauth handlers. This allows testing of each
error check within the oauth handler functions. I also added
github.com/jarcoal/httpmock as a dependecy to test both the oauth code
to token exchange and each of the calls that will be made out to the
microsoft graph API.
The tests cover how all errors are encountered for the oauth connection.
They also ensure that access token refreshing happens when the token is
expired. This tests to make sure the golang oauth client works out of
the box for this plugin.

Thanks @cpurta for the pull request!
Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

Also @cpurta please sign the CLA in the link above.

@cpurta dev has been merged, so you can re-base/re-point to master now.

Signed the CLA yesterday and now seeing the bot recognize that. Also just merge the master into my branch and everything is looking up to date.

@cpurta Also, as soon as you want to let us know the PR is ready for another review, hit the refresh symbol next to our names in the top right -- that will ping us through the Mattermost Github plugin that it's time to take another look. :)

@levb Final pass?

authors: cpoile cpurta levb mattermod

repo: mattermost/mattermost-plugin-msoffice


text:
MM-42489_Revamp: Login screen webapp

Summary
Fix navigation issue for external login
Ticket Link
https://mattermost.atlassian.net/browse/MM-42489
Related Pull Requests
https://github.com/mattermost/mattermost-webapp/pull/10281
Screenshots

Release Note
NONE

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/194359

authors: julmondragon mattermod

repo: mattermost/mattermost-webapp


text:
Automated cherry pick of #11749

Cherry pick of #11749 on release-7.6.
/cc  @cyrilzhang-mm
NONE

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: fff813efb85671feefc5f5204d373c1581cdd5b7

authors: mattermod mattermost-build


text:
translations PR 20180514

Ideally this PR should be review by community members for each language.
Note: In the event that you see an english translation instead of the desired language is because this PR was submitted before the translation was made on the Mattermost Translation Server and probably will be submitted for the next PR.

A translations PR for 4.10 was already submitted before. Closing. A new one for master will be submitted on May 21st.

authors: enahum jasonblais


text:
[MM-50955]: Fix for "Download our apps" link in final onboarding step

Summary
When an admin clicks on the "Download our apps" link in final onboarding step it only goes to the page but not the anchored section part-way down the page as it should.
This PR fixes that link.
Ticket Link
MM-50955
Screenshots

/e2e-test

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

authors: mattermost-build stevemudie


text:
[MM-12984] remove 'with' from strings

Summary
remove text "with SAML" and keep only "SAML"
Ticket Link
Jira: https://mattermost.atlassian.net/browse/MM-12984
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Includes text changes and localization file (.../i18n/en.json) updates

Server PR: https://github.com/mattermost/mattermost-server/pull/9827

merging


text:
translations PR 20171204

Ideally this PR should be review by community members for each language.
Note: In the event that you see an english translation instead of the desired language is because this PR was submitted before the translation was made on the Mattermost Translation Server and probably will be submitted for the next PR.

ja LGTM

authors: enahum kaakaa


text:
MM-19964 Properly handle whitespace before code block language

Our fork of marked incorrectly didn't trim the whitespace before the language tag in a code block, which the PR below fixes
Ticket Link
https://mattermost.atlassian.net/browse/MM-19964
Related Pull Requests
Marked PR: https://github.com/mattermost/marked/pull/16

@hmhealey Please help merge this PR before the end of your day today.

@hmhealey
Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Fetching origin
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-#4186-upstream-release-5.17-1573661879
Branch 'automated-cherry-pick-of-#4186-upstream-release-5.17-1573661879' set up to track remote branch 'release-5.17' from 'upstream'.
+++ Downloading patch to /tmp/4186.patch (in case you need to do this again)

+++ About to attempt cherry pick of PR. To reattempt:
  $ git am -3 /tmp/4186.patch

Applying: MM-19964 Properly handle whitespace before code block language
Using index info to reconstruct a base tree...
M	package-lock.json
M	package.json
Falling back to patching base and 3-way merge...
Auto-merging package.json
CONFLICT (content): Merge conflict in package.json
Auto-merging package-lock.json
CONFLICT (content): Merge conflict in package-lock.json
Patch failed at 0001 MM-19964 Properly handle whitespace before code block language
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

+++ Conflicts detected:

UU package-lock.json
UU package.json

+++ Aborting in-progress git am.

+++ Returning you to the master branch and cleaning up.

authors: amyblais hmhealey mattermod


text:
MM-25000: In-Product Discovery

Summary
Adds admin console menu items linking to HTML views advertising the enterprise features.
Ticket Link
https://mattermost.atlassian.net/browse/MM-25000
Screenshots

@thefactremains Could you please use the screenshots to review the copy. Also, I require the primary and secondary call-to-action URLs (with any desired tracking information).
@michaelgamble Could you please use the test server to review the pixel-perfectness, hovers, responsiveness, etc.?

it may be just a matter of adjusting the text line-height sometimes setting it to the same as the font-size and then increasing the parent objects padding in order to keep the overall height 48px

it may be just a matter of adjusting the text line-height sometimes setting it to the same as the font-size and then increasing the parent objects padding in order to keep the overall height 48px

@michaelgamble Can you please confirm that the change you're requesting applies to the invitation flow too?

it may be just a matter of adjusting the text line-height sometimes setting it to the same as the font-size and then increasing the parent objects padding in order to keep the overall height 48px

@michaelgamble Can you please confirm that the change you're requesting applies to the invitation flow too?

Yep, not sure when that happened, but the issue exists their too

it may be just a matter of adjusting the text line-height sometimes setting it to the same as the font-size and then increasing the parent objects padding in order to keep the overall height 48px

@michaelgamble Can you please confirm that the change you're requesting applies to the invitation flow too?

Yep, not sure when that happened, but the issue exists their too

Requested changes are in.

authors: michaelgamble mkraft


text:
[MM-20482] Migrate 'components/post_view/channel_intro_message' module …

…and associated tests to TypeScript
Summary
Migrate 'components/post_view/channel_intro_message' module and associated tests to TypeScript.
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/15459

Hello @cinlloc,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Removing myself as I am not the right person to review this.

/update-branch

@cinlloc let us know if we can help you somehow.

/update-branch

Error trying to update the PR.
Please do it manually.

@cinlloc Please resolve conflicts

Conflicts solved.

Thanks for the great PR @cinlloc :man_dancing:

authors: agarciamontoro agnivade cinlloc hanzei josephbaylon mattermod


text:
[MM-38469] - fixed several console errors regarding propTypes

Summary
this PR fixes several console errors that came up due to a false setting of props within the Menu.ItemToggleModalRedux component
Ticket Link
MM-38469
Release Note
NONE

/cherry-pick release-6.0

Cherry pick is scheduled.

Cherry pick is scheduled.

/cherry-pick cloud

authors: amyblais mattermod michelengelen


text:
[REQUEST] Endpoint for "just the text" of a short URL

Requested in slack by Darrell Wright.
Is there a way to query the text of CE short url.  Say I wanted to #include <https://gcc.godbolt.org/z/SOMEID>

Ideally we'd give an endpoint like the existing RESTful one that "just" yields the editor text. Not sure what it should do if there's more than one editor, pick lowest ID? Error?

Maybe make it explicit via an extra parameter? so like /api/shortlinkinfocode/abc123/1

Great idea, thanks @partouf

If you will allow me to run to the bikeshed real quick, /z/:id/code/:editor? is a much nicer route for this given the original use case of being able to #include someone else's link code.
Just slap /code onto the link and it will spit back the plaintext for the first editor.
If there are multiple editors you should still get the first if you don't specify any editor explicitly.

Is nicer maybe yes, but not in api.js which annoys me :/
But worth considering

authors: apmorton mattgodbolt partouf

repo: mattgodbolt/compiler-explorer

license_source: bigquery


text:
ambiguous decoder for type UInt64

Hi,
First of all, thanks for sharing this amazing library.
I'm using some structs with UInt64 and that caused a compilation error indicating references to ambiguous decode functions.
My workaround was to extend JSONDecoder but this does not work too. Compilation works fine but it throws error while decoding.
private struct StorePromotionItem {
    let banner: String
    let icon: String
    var saleOptionId: UInt64?
    var productOfferId: UInt64?
}

extension StorePromotionItem: JSONDecodable {
    init(object: JSONObject) throws {
        let decoder = JSONDecoder(object: object)
        banner = try decoder.decode("banner")
        icon = try decoder.decode("icon")
        saleOptionId = try decoder.decode("sale_option_id")
        productOfferId = try decoder.decode("product_offer_id")
    }
}

extension JSONDecoder {
    public func decode(key: String) throws -> UInt64 {
        let JSONTransformerStringToUInt64 = JSONTransformer<String, UInt64>(
            decoding: {
                UInt64($0)
            },
            encoding: {
                String($0)
        })

        return try decode(key, transformer: JSONTransformerStringToUInt64)
    }
}

Thanks,

Hi there, for UInt64 you can use a transformer and you should not need to extend JSONDecoder with another decoding case.
extension StorePromotionItem: JSONDecodable {
    init(object: JSONObject) throws {
        let decoder = JSONDecoder(object: object)
        banner = try decoder.decode("banner")
        icon = try decoder.decode("icon")
        saleOptionId = try decoder.decode("sale_option_id", transformer: IntToInt64)
        productOfferId = try decoder.decode("product_offer_id", transformer: IntToInt64)
    }
}

let IntToInt64 = JSONTransformer<Int, UInt64>(
    decoding: { UInt64($0)},
    encoding: {Int($0)})

Using a transform in this way worked fine in my tests, converting the value properly.

Although,... I can image this solution may have some precision loss going from Int -> UInt64. if you are expecting values from the server that could larger than the signed 64-bit integer value.  If that is your issue then unfortunately I do not have a good answer for you right now...

That's true I cannot cast from Int -> UInt64.
Extending the decoder is not an option ?

Actually building a transformer from NSNumber -> UInt64 seems to work alright
let toUInt64 = JSONTransformer<NSNumber, UInt64>(
    decoding: { UInt64($0.unsignedLongLongValue)},
    encoding: {NSNumber(unsignedLongLong:$0)})

Let me know if you have any trouble with the NSNumber -> UInt64  transformer solution, otherwise for now I am closing this issue. Thanks!

authors: Nadohs vitorhugomagalhaes

repo: matthewcheok/JSONCodable

license: mit


text:
Browser request for fallback img even when not needed.

Right now it appears that the browser will make two requests one for the .svg and another for the .png if the svg is able to load the browser should not also request the png.

Hey, which version are you using? I just tried with 0.5.0 and it didn't load the fallback png.

I'm using the latest version, how ever I am using this on an Isomorphic app.

authors: gilbarbara jamesslock

repo: matthewwithanm/react-inlinesvg


text:
compact mode with action in custom mode

Checklist:

[x] I updated to the latest version available
[x] I cleared the cache of my browser

Release with the issue:
08 Jul 2021  v1.10.3
Last working release (if known):
08 Jul 2021  v1.10.3
Browser and Operating System:
Chrome 97.0.4692.71

Description of problem:
...
compact: true
action_button:
  mode: custom
...

icon is in the second row below the name of entity

Javascript errors shown in the web inspector (if applicable):

Additional information:

add show: true as a sub of action_button
compact: true action_button:   mode: custom   show: true
If you use the Visual Editor when adding the card all the default settings will be set and you will not have this issue. Use my solution above otherwise.

add show: true as a sub of action_button compact: true action_button: mode: custom show: true If you use the Visual Editor when adding the card all the default settings will be set and you will not have this issue. Use my solution above otherwise.

It works!
Thank you

authors: jscongdon maximatchev

repo: mattieha/slider-button-card

license: MIT


text:
New namespace "Axiom" doesn't work on 2.1

Hi there and first thx for your work !
I directly installed 2.1 without older version before.
"use Axiom... " doesn't work
Namespace hasn't updated and I have to use the old one "Alphametric..."

I was using php 7.3
I upgraded to 7.4
Everything work ok now

repo: mattkingshott/axiom


text:
moving computed values completely into redux store

it'd be nice to store computed values in something like getState().cashay.computed.teamSubs.
This is something that reselect doesn't do, but since cashay is used for bigger apps, it starts to make sense.
The problem is deciding what to do for the memoization triggers. If they're primitives, it's easy. If they're objects, it's still pretty easy since we just do a reference check. But if it's a function, it gets ugly because we can't store functions in the redux store (if we want to stringify it).
So, we can either disallow support for functions, or we can store the inputs outside the redux store & just save the result.

closed with v0.20.0

repo: mattkrick/cashay


text:
reshape() is not exception-safe

#include "plf_hive.h"
#include <cassert>

int should_throw = 0;
struct S {
    S() = default;
    S(const S&) { if (--should_throw == 0) throw 42; }
};

int main()
{
    plf::hive<S> h;
    h.reshape({10, 10});
    assert(h.block_capacity_hard_limits().min == 3);
    assert(h.block_capacity_hard_limits().max == 255);
    assert(h.block_capacity_limits().min == 10);
    assert(h.block_capacity_limits().max == 10);
    h.insert(S{});
    assert(h.size() == 1);
    assert(h.capacity() == 10);
    try {
        should_throw = 1;
        h.reshape({100, 100});
        assert(false);
    } catch (int) {}
    assert(h.size() == 1);
    assert(h.block_capacity_limits().min == 100);
    assert(h.block_capacity_limits().max == 100);
    assert(h.capacity() == 10);  // !!!
}

Whenever h.block_capacity_limits().min == h.block_capacity_limits().max, we should have a mathematical invariant that h.capacity() % h.block_capacity_limits().min == 0 (because all the blocks should be of that one capacity). In fact, reshape makes it possible to "half-reshape" a hive such that it thinks its current-limits are X, but the block list itself respects some other limits Y.

Thanks, fixed now - exception should roll min/max back to what they were, so above code will still fail on last few asserts. Updated paper accordingly

authors: Quuxplusone mattreecebentley

license: Zlib


text:
fix(sample): update references to generateBls12381G2KeyPair

Signed-off-by: Peter Somogyvari peter.metz@unarin.com

Description

[x] Tests for the changes have been added (for bug fixes / features)
[x] The commit message(s) follow conventional commits
[ ] Documentation has been added / updated (for bug fixes / features)
[x] Changes follow the contributing document.

Motivation and Context

The browse sample is not working at the moment because of the earlier breaking change in the API.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Which merge strategy will you use?

[ ] Squash
[x] Rebase (REVIEW COMMITS)

@petermetz thanks for the PR appreciate the contribution

authors: petermetz tplooker

repo: mattrglobal/bbs-signatures


text:
Having array of sub schemas fail

....
"payout_methods": {
"type": "object",
"oneOf": [
{ "$ref": "#/definitions/bitcoin.json" },
{ "$ref": "#/definitions/sepa.json" },
{ "$ref": "#/definitions/uk_bank.json" }
]
}
....
Error message:
/usr/local/lib/node_modules/jade/lib/runtime.js:231
throw err;
^
TypeError: templates/mixins/itterate.jade:22
20|             mixin itterate(item, item.title, obj)
21|           else

22|             - var schema = key.match(/^(properties)|(patternProperties)|(items)$/) ? obj : val
23|             mixin itterate(item, name, schema)
24|   else
25|     dt

Cannot call method 'match' of undefined
at Object.eval (eval at  (/usr/local/lib/node_modules/jade/lib/index.js:216:8), :292:18)
at Object.jade_mixins.itterate (eval at  (/usr/local/lib/node_modules/jade/lib/index.js:216:8), :304:4)
at Object.eval (eval at  (/usr/local/lib/node_modules/jade/lib/index.js:216:8), :254:24)
at Object.jade_mixins.itterate (eval at  (/usr/local/lib/node_modules/jade/lib/index.js:216:8), :304:4)
at Object.eval (eval at  (/usr/local/lib/node_modules/jade/lib/index.js:216:8), :295:24)
at Object.jade_mixins.itterate (eval at  (/usr/local/lib/node_modules/jade/lib/index.js:216:8), :304:4)
at Object.eval (eval at  (/usr/local/lib/node_modules/jade/lib/index.js:216:8), :295:24)
at Object.jade_mixins.itterate (eval at  (/usr/local/lib/node_modules/jade/lib/index.js:216:8), :304:4)
at jade_debug.unshift.lineno (eval at  (/usr/local/lib/node_modules/jade/lib/index.js:216:8), :486:24)
at eval (eval at  (/usr/local/lib/node_modules/jade/lib/index.js:216:8), :495:4)

The template you are using this one I assume is expecting to find a either a properties, patternProperties or items attribute at the root of your schema.
You could either add one as in the example or adapt your template accordingly.

authors: mattyod vmatekole

repo: mattyod/matic


text:
Updating Graph ResourceId in web.config

The ResourceId was set to graph.windows.net while correct graph resource is graph.microsoft.com as defined in https://graph.microsoft.io/en-us/docs/authorization/app_authorization. With graph.windows.net calls to graph api return 401 unauthorized.

They are both valid. It only depends on which one you configure your application in AAD for. Not everybody has Office 365 and therefore not everybody will have graph.microsoft.com so I'd rather just leave it with the option that is more likely going to work for most people

A few asks:
1-Let's not publish aad or bot secrets on GitHub. Please remove those
2-Let's not change the aad grah resource id into Microsoft graph. That demo is supposed to work even for folks who don't use Office 365.
Thanks

authors: matvelloso tiagonmas

repo: matvelloso/AuthBot


text:
False Object detection when running on autoware ROSbags

Used wget https://autoware-ai.s3.us-east-2.amazonaws.com/sample_moriyama_150324.tar.gz ROSbag file,
but many times false objects were detected.
Could you please share a sample data-set to validate the ROS inference node?

Hi @arjunskumar
I have no ideas on it. Can you please contact to @AhmedARadwan for the ROS implementation?

@AhmedARadwan Could you share the ROS bag file?

authors: arjunskumar maudzung


text:
resizing  width height NaN

@resizing="onResize"
宽高拿不到

调用组件的代码怎么写的

Maybe it is due to the naming of your resizeStop listener.

Maybe it is due to the naming of your resizeStop listener.

Maybe not. This breakpoint is not be entered if it is a listener naming issue.
It seems like some internal calculation issues for width and height.
Quite similar to #397

authors: HLN177 HarryWuuuu zhangbowy

repo: mauricius/vue-draggable-resizable


text:
Add option to use self-signed SSL certificate.

The needed steps are:
SSH (self-signed):
openssl req -newkey rsa:4096 -x509 -sha256 -days 365 -nodes -out tljh.crt -keyout tljh.key

hit enters (need to figure out how to automate this).  Then
sudo mv tljh.key tljh.crt /opt/tljh/state

sudo tljh-config set https.enabled true

sudo tljh-config set https.tls.key /opt/tljh/state/tljh.key
sudo tljh-config set https.tls.cert  /opt/tljh/state/tljh.crt
sudo tljh-config reload proxy

Fixed in 0ebe88a563a66d6684


text:
navigationBar dissapears

Hi,
I'm using dataSource methods for setup. I'm keeping three viewControllers in controllersArray and I'm using viewControllerForPageAt method to show pager. Because some of this viewController has tableView and I want to make user move other viewController too. If I use viewForPageAtIndex viewControllers are not clickable so that's not suitable for me.
I have ProfileVC which is extend from MXSegmentedPagerController. ProfileVC has storyboard with root of some navigationController. The tricky part is navigationBar. When ProfileVC first showed up navigationBar is still there but If I select pager or make push to another viewController is going to disappear
Do you know what might be the problem is? How I can keep navigationBar, give me some advice please?
//MARK: - SegmentedPager
override func numberOfPages(in segmentedPager: MXSegmentedPager) -> Int {
    return 3
}

override func segmentedPager(_ segmentedPager: MXSegmentedPager, titleForSectionAt index: Int) -> String {
    return ["A", "B", "C"][index];
}

override func segmentedPager(_ segmentedPager: MXSegmentedPager, viewControllerForPageAt index: Int) -> UIViewController {

    return controllersArray[index] as! UIViewController
}

+1

authors: danialmoghaddam goktugaral

repo: maxep/MXSegmentedPager


text:
Add routable project categories

i.e. /projects/category/web should show all the projects that are web projects.

No longer needed / now a frontend app concern

repo: maxfierke/resumis


text:
Custom sortArrowIcon and sortArrowAnimationDuration

I'm still working on this pull request but wanted to check something with you on the widget testing. I've added a file called "sort_arrow_test.dart" to the test folder to show a problem I'm facing but don't know how to solve.
When I run an app using DataTable2 with these new custom icon parameters, it seems to work. I can use whatever icon I choose and the durations look to execute properly. The icon also rotates 180 degrees each time I click the column header to sort. The problem I have during testing is that when I use tester.tap(), the test will arrive at onSort and execute the code there but the "ascending" parameter does not toggle. I can see in the normal app's debugging that this parameter will toggle each time it is called because of sort = !sort and then the table is rebuilt with the updated sort. However, the test does not rebuild DataTable2 after onSort is called.
I have also tried with a stateful widget in the test so that I could try setState() with sort = !sort but that apparently isn't the issue. I don't know why the test doesn't rebuild DataTable2() so that ascending will toggle the icon. Since it doesn't toggle, I can't yet test for the rotation of the icon. Can you see anything I'm doing wrong in this test?

@hootyjeremy, please check my last commit, now you can get arrow updates in the tests:

The problem you had is related to the fact that data table is stateless and needs to be rebuilt in the onSort event, that's why you have to wrap in into a stateful widget, I used StreamBuilder for that. Now you can proceed with finilizing the tests.
Few notes on code organisation and refactoring. This single test doesn't deserve a separate file sort_arrow_test.dart, please move the test to custom_features_test.dart under group('DataTable2', () {}). Beside please reuse the existing buildTable()method from test_utils.dart by adding those 2 new params as optional ones - no need to duplicate code and introduce another version of buildTable(), let's keep it cleaner.

Thanks for the info on the StreamBuilder for the tests. I have added these to the tests which show that the custom icon can be applied and it's rotation will be correct not before the custom duration, but after.
From my previous pull request, you had requested that I update example/lib/screens/data_table2.dart with the custom arrow. I made an attempt but I'm not sure if this is what you had in mind. Please let me know if it isn't.

I am not sure what happened here. Let me scrap this one and start fresh with a good working folder. I am getting the tests passing here now. Still very new to GitHub and and collaborating versions.

authors: hootyjeremy maxim-saplin


text:
Create Main Feed Component

The main feed is the left side of the main area, and contains the recommendations feed, new post interface, etc.

Needs to actually feed on page load.

Need to extend with information about plants, and Favorite/Save Plant button

We have the recommendation feed with plant information and Save/Favorite button.
I'm going to close this as complete and create a new issue for the feed to auto-load on page load.

repo: maxlemieux/quokka


text:
A non-serializable value was detected in the state, in the path: auth.user

Challenge
When we integrate the redux-oidc state into our project, we get the following error on all store calls:
A non-serializable value was detected in the state, in the path: `auth.user`. Value:
t
expires_in: (...)
expired: (...)
scopes: (...)
id_token: "1234.1234"
session_state: undefined
access_token: "ey"
refresh_token: undefined
token_type: "bearer"
scope: "openid"
profile: {sub: "123456-123456", email_verified: true, jtt: "id_token", lee: Array(1), acr: "https://example.com", …}
expires_at: 1585328012
state: undefined

The problem seems to be that the user object is a class
Our fix
We could fix that, by rewriting the following method inside src/OidcProvider.js:
  onUserLoaded = (user) => {
    this.props.store.dispatch(userFound(JSON.parse(user.toStorageString())));
  };

Parts of our code
This is how we make use of the reducer:
import { combineReducers } from '@reduxjs/toolkit';
import { connectRouter } from 'connected-react-router';

import { reducer as oidcReducer } from 'redux-oidc';

import myProfileReducer from 'components/my-profile/MyProfileSlice';

import { createBrowserHistory } from 'history';

export const history = createBrowserHistory();

const rootReducer = combineReducers({
    auth: oidcReducer,
    router: connectRouter(history),
    myProfile: myProfileReducer,
});

export type RootState = ReturnType<typeof rootReducer>;

export default rootReducer;

And this is the callback component
import React from 'react';
import { CallbackComponent as CallbackComponentOidc } from 'redux-oidc';
import userManager from '../userManager';
import { useHistory } from 'react-router-dom';

export const CallbackComponent: React.FC<{}> = () => {
    const history = useHistory();
    console.log('callback component is called');
    return (
        <>

Callback Componengt

            <CallbackComponentOidc
                userManager={userManager}
                successCallback={() => {
                    console.log('Success');
                    history.push('/dashboard');
                }}
                errorCallback={error => {
                    history.push('/');
                    console.error(error);
                }}
            >

Redirecting...

            </CallbackComponentOidc>
        </>
    );
};

also we needed to change this on all other places where you make user of the user:

oidcMiddleware.js

 nextMiddleware(userFound(JSON.parse(user.toStorageString())));

OidcProvider.js

  onUserLoaded = (user) => {
    this.props.store.dispatch(userFound(JSON.parse(user.toStorageString())));
  };

src/helpers/loadUsers.js

export function getUserCallback(user) {
  if (user && !user.expired) {
    reduxStore.dispatch(userFound(JSON.parse(user.toStorageString())));
  } else if (!user || (user && user.expired)) {
    reduxStore.dispatch(userExpired());
  }
  return user;
}

I have created a fork here:
https://github.com/bastiW/redux-oidc

I'd also like to get rid of non-serializable warning. We're using Redux Toolkit which includes serializable checks for state as a default dev-only middleware (https://redux-toolkit.js.org/api/other-exports#createserializablestateinvariantmiddleware) and I'll be happier without warnings which I should always ignore.

Any updates on this? I am also using the redux toolkit and the console is getting quite cluttered over here. I did manage to temporarily disable the serializable check, but this is not a valid fix for anything. This just gives me back my console.
import { configureStore, getDefaultMiddleware } from '@reduxjs/toolkit'
...
const store = configureStore(
    {
        reducer: YOUR_REDUCER(S)_HERE,
        middleware: [
            ...getDefaultMiddleware({
                serializableCheck: false
            }),
            ...otherMiddlewares
        ],
        devTools: process.env.NODE_ENV !== 'production' ? { CONFIG_GOES_HERE } : false
    }
);

This disables the check for serializable data in you store, so i wont recommend this as a fix to the problem.

Adding onto @japalo solution, you can disable the serializationCheck specifically just for the oidc reducer by providing the options below:
import { configureStore, getDefaultMiddleware } from '@reduxjs/toolkit'
...
const store = configureStore(
    {
        reducer: YOUR_REDUCER(S)_HERE,
        middleware: [
            ...getDefaultMiddleware({
                serializableCheck: {
                    ignoredActions: ['redux-oidc/USER_FOUND'],
                    ignoredPaths: ['oidc.user']
                }
            }),
            ...otherMiddlewares
        ],
        devTools: process.env.NODE_ENV !== 'production' ? { CONFIG_GOES_HERE } : false
    }
);

Documentation on these options for redux-toolkit can be found on the redux-toolkit docs.

Any updates on this? I am also using the redux toolkit and the console is getting quite cluttered over here. I did manage to temporarily disable the serializable check, but this is not a valid fix for anything. This just gives me back my console.
import { configureStore, getDefaultMiddleware } from '@reduxjs/toolkit'
...
const store = configureStore(
    {
        reducer: YOUR_REDUCER(S)_HERE,
        middleware: [
            ...getDefaultMiddleware({
                serializableCheck: false
            }),
            ...otherMiddlewares
        ],
        devTools: process.env.NODE_ENV !== 'production' ? { CONFIG_GOES_HERE } : false
    }
);

This disables the check for serializable data in you store, so i wont recommend this as a fix to the problem.

in 2023 we have to write getDefaultMiddleware like this
import { configureStore } from '@reduxjs/toolkit'
...
const store = configureStore(
    {
        reducer: YOUR_REDUCER(S)_HERE,
        middleware: getDefaultMiddleware =>
            getDefaultMiddleware({
                serializableCheck: false,
            }).concat(OTHER_MIDLEWER),
        devTools: process.env.NODE_ENV !== 'production' ? { CONFIG_GOES_HERE } : false
    }
);

authors: bastiW hamed4000 japalo mitoihs zach-rodriguez

repo: maxmantz/redux-oidc


text:
Website background animation

To split off some work, we could work on a background animation effect kind of inspired by S2VX, maybe even just use our s2ry format as a base and translate those to browser elements
Square-ish themed

Closing this in favor of https://github.com/maxrchung/S2VX/issues/560 since this is probably going to be too complicated/time consuming.


text:
No export default of Component in index.js

I noticed that index.js is using module.exports = SpinKit rather than export default SpinKit. Is there a reason for this? Or can we switch it to using the ES modules syntax? My linter can't resolve the default import because there's not default export. Small issue, but don't see why we can't do it since SpinKit is already written using import rather than require

This is the lint rule that fails for me: https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/default.md

authors: derrickbeining jpaas


text:
Having trouble gettting it to work

Having trouble gettting it to work, ive followed the detailed tut on https://derflounder.wordpress.com/2015/11/19/downloading-installer-packages-from-the-mac-app-store-with-appstoreextract/ with no success, need some help to get it to work please

Hi @skarzzzz
Thanks for your interest in my script, I'm happy to try to bring you up and running with it:
The write-up from Rich is a bit old and will only work partly on newer OS versions. To make it run (with less problems) starting on Catalina, you need another CLI tool, called "mas": https://github.com/mas-cli/mas, If you attempt to download the packages manually from the AppStore itself it will fail, as Apple has changed some background processes.
Easiest is to install it through home brew (https://brew.sh), then do these steps (tested under macOS Big Sur 11.2.1):

prepare the MacAppStore-Extractor-Script and start in in a Terminal Window:
---> /PATH/TO/MacAppStoreExtract.sh -m (use the -m for Munki compatibility)

---> Importan, let it run while you with to another window and run the mas-cli:
run mas-cli to install the desired package (for example the Safe Exam Browser from ETH Zurich):
---> /opt/homebrew/bin/mas install 411684841
When it has finished, go back to the MacAppStore Extractor script and press any key, then Y(es) to finish up the DMG.
You should now find it in "/Users/Shared/AppStore_Packages".
Hope that works for you, if now, please find me on the Mac Admins and send me a PM.

Try using v3.1
https://github.com/blakeusblade/MacAdminHelpers/tree/master/AppStoreExtract

authors: blakeusblade maxschlapfer skarzzzz

repo: maxschlapfer/MacAdminHelpers


text:
Empty line

There is an extra empty line in the beginning.

Thanks for flagging -- fixed in commit https://github.com/mayakyler/link-shorteners/commit/4f4eda3e6724ba804f96ebb246fea5d58f2bfc79

repo: mayakyler/link-shorteners


text:
Exposed api key

You have an exposed api key and other important config in this index.html. It's easily viewable when you check the website source, It's a potential risk for your website.

Thanks for the heads up. Working on that : )

You should avoid making such important configurations public, it's really a security risk.

authors: ikuamike mayeedwin

repo: mayeedwin/devfest


text:
Update to use an escript and rebar3 + others

I went ahead and added in other commits which seemed useful.  I believe it includes the other open pull requests, so those can be closed if this is merged.  I got rid of the shell script and replaced it with an escript generated by rebar3.  This is super convenient as you can just copy it to your path and use it (similar to rebar3 and relx).  I made it version 0.3.0 so if you merge, please tag so I can include it.  I've successfully included this version (along with cecho 0.5.1) in a release so that part all works now.  @mazenharake if you have a chance please take a look.

Thank you putting everything together. I'll take a look at everything this weekend!

Thanks, not sure why entop is conflicted and it's not an auto merge, I remove the entop script?  Dunno, thanks for taking a look.

@mazenharake did you have a chance to check these changes out yet?

Hi,
I played around with it this evening. I looked through the code which seems fine. Thanks for that. However when trying the ./rebar3 escriptize command it seems to go through but running:
(19.3)mazen@Green ~/Dev/entop $ ./_build/default/bin/entop foo@Green HQREOBANGMCTSVQSDGAZ
Gives me this error:
=INFO REPORT==== 25-Jun-2017::23:48:50 ===     application: cecho     exited: {{driver_error,"cannot open shared object file: Not a directory"},              {cecho,start,[normal,[]]}}     type: temporary
Seems cecho didn't compile properly. I tried compiling it again using ./rebar compile in the _build/default/lib/cecho directory and that went better... (at least the helloworld program ran properly). Cecho does produce warnings though so I'll check out what they are tomorrow.
Have any idea on what that could be? I assume you tried this and that it went well on your system?

I've not seen that, everything works on my system.  Was there a compile line for cecho?  Here's what my session looked like.
molinaro@centos65:7> ./rebar3 escriptize
===> Verifying dependencies...
===> Fetching cecho ({git,"https://github.com/mazenharake/cecho.git",
                                 {ref,"7a0042b930ba64a1d3e496bd29a27ff0b356435f"}})
===> Compiling cecho
make: Entering directory `/mnt/molinaro/projects/thirdparty/entop/_build/default/lib/cecho/c_src'
cc -g -O3 -funroll-loops -I/opt/include -I/usr/local/include -fPIC -I /usr/lib64/erlang/erts-7.3/include/ -I /usr/lib64/erlang/lib/erl_interface-3.8.2/include -I/opt/include -I/usr/local/include -c -o /mnt/molinaro/projects/thirdparty/entop/_build/default/lib/cecho/c_src/cecho.o /mnt/molinaro/projects/thirdparty/entop/_build/default/lib/cecho/c_src/cecho.c
cc /mnt/molinaro/projects/thirdparty/entop/_build/default/lib/cecho/c_src/cecho.o -L/usr/local/lib -L/opt/lib -shared -L /usr/lib64/erlang/lib/erl_interface-3.8.2/lib -lerl_interface -lei -lncurses -o /mnt/molinaro/projects/thirdparty/entop/_build/default/lib/cecho/c_src/../priv/cecho.so
make: Leaving directory `/mnt/molinaro/projects/thirdparty/entop/_build/default/lib/cecho/c_src'
===> Compiling entop
===> Building escript...

I see... But did you try to run the actual entop script that was generated?

It turns out that the path to where the cecho driver is (the priv dir) gets messed up when running ./rebar3 escriptize.
I'll have another look tomorrow to see how to fix that, otherwise I'll reinstate the script until we have a solution.
I also realized today that the changes we are trying to pull in were in a different license. I'm not sure how that is treated when taking them in under a new license... I'll have to check it out.

Sorry, yes I did and it works fine for me.

Oh, I figured out that I also had cecho installed in my erlang system library path, so I was picking up that version and not the version in the escript.  I'll see if I can't figure out what's happening.  It does work when I include it inside a release and invoke it via a shell script so that still works at least.

Hmm, this may not work, I found
http://lists.basho.com/pipermail/rebar_lists.basho.com/2012-September/001707.html
which seems to suggest you can't use a .so in an archive, so this may not work as an escript :(

@mazenharake I put back a slightly modified version of the bash script.  It should run from within the project, and can be copied out and run as well (assuming you've also installed cecho and entop libs into your erl libs directory).
I simplified the calling, you are no longer required to give a name (the library will choose a random name), nor do you need to specify the -setcookie part.
I tested by just running
% erl -name foo -setcookie bar
in one shell, then ran
% ./entop foo@long.name bar
Or by running
% erl -sname foo -setcookie bar
in one shell and
% ./entop foo@short bar
(long.name and short are your long and short hostnames).
I also linked cecho and entop into my erlang libs dir, copied the entop bash script into my path and did the same tests.
Let me know if it works for you.

I'm currently on vacation. I'll let you know as soon as I'm back and have
tested it.
On Jul 11, 2017 3:43 AM, "Anthony Molinaro" notifications@github.com
wrote:

@mazenharake https://github.com/mazenharake I put back a slightly
modified version of the bash script. It should run from within the project,
and can be copied out and run as well (assuming you've also installed cecho
and entop libs into your erl libs directory).
I simplified the calling, you are no longer required to give a name (the
library will choose a random name), nor do you need to specify the
-setcookie part.
I tested by just running
% erl -name foo -setcookie bar
in one shell, then ran
% ./entop foo@long.name bar
Or by running
% erl -sname foo -setcookie bar
in one shell and
% ./entop foo@short bar
(long.name and short are your long and short hostnames).
I also linked cecho and entop into my erlang libs dir, copied the entop
bash script into my path and did the same tests.
Let me know if it works for you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mazenharake/entop/pull/20#issuecomment-314289859, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAIlOEUSGoPt3yoiMQlmEJv2mLEyIUgzks5sMsUigaJpZM4N7lci
.

Just a ping @mazenharake in case you are back from vacation.

@djnym I'm back! Sorry for the delay. I'll get to it asap :+1:

@djnym Merged and tagged. Let me know if this works out for you.

authors: djnym mazenharake

repo: mazenharake/entop


text:
User group is not suggested in completion of username.

Like @engineer

https://api.slack.com/methods/usergroups.list

repo: mazun/SlackStream


text:
file/directory tests / coverage

-Added cntdir() tests
-Added mkdir() tests
-Added rename() tests
-Added throw test for f_read (100% coverage)
-Added throw test for f_write (100% coverage)
-Added dirnotfound test for fnd1st() (100% coverage)
-Added invalidguid test for fndnxt() (100% coverage)
-Added invalid filestream test for fscanf() (100% coverage)
-Added invalid cursur test for curusr() (100% coverage)
-Added IDisposable to IMemoryCore and added Dispose() to MemoryCore which calls Clear()

Thanks for improving coverage!

repo: mbbsemu/MBBSEmu


text:
Exception during multiprocess concurrent access to LiteDB

During develop we got such exception:

Exception Information
Message: Timeout. Database is locked for more than 00:01:00
Source: LiteDB
TargetSite: Void TryExec(System.Action)
HelpLink:
Type: LiteDB.LiteException
Place: 1
Stack:
at LiteDB.FileDiskService.TryExec(Action action)
at LiteDB.FileDiskService.DeleteJournal()
at LiteDB.TransactionService.Complete(LiteTransaction trans)
at LiteDB.LiteTransaction.Commit()
at LiteDB.DbEngine.WriteTransaction[T](String colName, Boolean addIfNotExists, Func2 action)    at LiteDB.DbEngine.Update(String colName, IEnumerable1 docs)
at LiteDB.LiteCollection`1.Update(BsonValue id, T document)

Single litedb file is used across 10 processes.
I've read that you completely updated concurrency, is this problem still possible in v3?
If such kind of concurrency isn't task of litedb we probably could use mutex, not concurrent access to db for many processes.
One more question: when stable version of v3 would be available?
Thanks for litedb, it's really simple and fast!

Hi @podkolzzzin, take a look on this thread: #332
v3 is almost done, just finishing some tests and upgrade database. More few weeks ;)

Hello @mbdavid i have just updated to v3 beta 3 looking forward to this fix, but immediately received exception in multiprocess context.

Exception Information
Message: Timeout. Database is locked for more than 00:00:00.
Source: LiteDB
TargetSite: Void TryExec(System.Action, System.TimeSpan)
HelpLink:
Type: LiteDB.LiteException
Place: 1
Stack:
at LiteDB.FileHelper.TryExec(Action action, TimeSpan timeout)
at LiteDB.StreamExtensions.TryLock(FileStream stream, Int64 position, Int64 length, TimeSpan timeout)
at LiteDB.FileDiskService.d__24.MoveNext()
at LiteDB.TransactionService.Recovery()
at LiteDB.LiteEngine..ctor(IDiskService disk, String password, Nullable1 timeout, Int32 cacheSize, Logger log)    at LiteDB.LiteDatabase.<>c__DisplayClass10_0.<.ctor>b__0()    at LiteDB.LazyLoad1.get_Value()
at LiteDB.LiteCollection1.<Find>d__17.MoveNext()    at System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable1 source)
at LiteDB.LiteCollection`1.FindById(BsonValue id)

Hi @podkolzzzin, can you test with current master branch? I found an bug in Find operation and fix in master but not release yet. If problem persist, please, re-open this issue.

Hi @mbdavid I tried with current master branch, it looks like you fixed it. My congratulations.
As I understood now LiteDB is ready to work in multiprocess environment. It's really cool, my congratulations!
When could we expect v3 stable? It's really important for us, because we are going to have a release this month, and if we do it on v2, we'll have to do something than to update users' database files.

Hi @podkolzzzin, thanks! My plans is release v3 next weekend in nuget. I need just review some code, do more unit tests and publish, After this, I will update all wiki documentation and site.

I tried one code-sample on your code from 11/01/17
And received the same exception.
Launch this code and wait a couple of minutes.
using LiteDB;
using System;
using System.Threading;

namespace LiteDbTest
{
    public class Test
    {
        public string Test1 { get; set; }
    }

    class Program
    {
        static void Main(string[] args)
        {
            for (int i = 0; i < 100; i++)
            {
                Thread t = new Thread(Proc);
                t.Start();
            }
        }

        public static void Proc()
        {
            try
            {
                using (LiteDatabase db = new LiteDatabase("file1.db"))
                {
                    using (var t = db.BeginTrans())
                    {
                        db.GetCollection<Test>("Test").Insert(new Test()
                        {
                            Test1 = "Test"
                        });
                        Thread.Sleep(10000);
                        t.Commit();
                    }
                }
            }
            catch (Exception ex)
            {
                Console.ForegroundColor = ConsoleColor.Red;
                Console.WriteLine("Faild");
                throw;
            }
        }
    }
}

It was time and we had to publish new release very soon.
So, we had to fix this ASAP. So I implemented multiprocess ReadWriteLock. I used Mutex, Semaphore and EventWaitHandle inside. If it is acceptable for you I can share my solution.

Hi @podkolzzzin, I implemented using FileStream.Lock command. Thanks

I downloaded LiteDB source code until commit 1afb0b1b99a53afe6b5785c28cf2666650712853 (latest now)
And launched the code I had posted before.
There is still an exception
Unhandled Exception:Unhandled Exception:Unhandled Exception: LiteDB.LiteException: Timeout. Database is locked for more than 00:01:00.
   at LiteDB.FileHelper.TryExec(Action action, TimeSpan timeout) in C:\Users\AndreyPod\Saved Games\Downloads\LiteDB-master\LiteDB\Utils\FileHelper.cs:line 72
   at LiteDB.StreamExtensions.TryLock(FileStream stream, Int64 position, Int64 length, TimeSpan timeout) in C:\Users\AndreyPod\Saved Games\Downloads\LiteDB-master\LiteDB\Utils\Extensions\StreamExtensions.cs:line 56
   at LiteDB.FileDiskService.Lock(LockState state, TimeSpan timeout) in C:\Users\AndreyPod\Saved Games\Downloads\LiteDB-master\LiteDB\Engine\Disks\FileDiskService.cs:line 321
   at LiteDB.LockService.LockReserved() in C:\Users\AndreyPod\Saved Games\Downloads\LiteDB-master\LiteDB\Engine\Services\LockService.cs:line 129
   at LiteDB.LockService.Reserved() in C:\Users\AndreyPod\Saved Games\Downloads\LiteDB-master\LiteDB\Engine\Services\LockService.cs:line 66
   at LiteDB.LiteEngine.BeginTrans() in C:\Users\AndreyPod\Saved Games\Downloads\LiteDB-master\LiteDB\Engine\Engine\Transaction.cs:line 19
   at LiteDB.LiteDatabase.BeginTrans() in C:\Users\AndreyPod\Saved Games\Downloads\LiteDB-master\LiteDB\Database\LiteDatabase.cs:line 113
   at LiteDbTest.Program.Proc() in C:\Users\AndreyPod\Documents\Visual Studio 2015\Projects\LiteDBtests\LiteDBtests\Program.cs:line 33
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()

I can confirm that this is still a legitimate issue. When the LiteDB database is used by multiple processes, you have to disable the journal feature, in order for it, not to timeout. Herewith the code that saved my bacon.
    var databaseName = Server.MapPath("~/App_Data/database.db");
    var connectionString = String.Format("filename={0};journal=false", databaseName);
    using (var db = new LiteDatabase(connectionString))
    {
        var col = db.GetCollection<MyCollection>("dbCollectionName");
        var user = new User
                    {
                        Firstname = "john"
                        Surname = "doe"
                    };

                    // Insert new user
                    col.Insert(user);
                }
    }

Hello, I am using version 3.1.0 and I have having the same issue.  I have tried @chesney suggestion of disabling the journal feature but the problem is that if I have one or more processes simply trying to Find records, the database is locked for Write.  I have also tried setting the connection string variable "Mode" to "ReadOnly" for the instances that are performing the Find and "Shared" for the single instance trying to Write.  I have also tried with and without Transactions calls for the write.
No matter what I try the write operation eventually times out.

Is there any update regarding a fix for this issue?

authors: chesney mbdavid podkolzzzin vbguyny

repo: mbdavid/LiteDB


text:
runs without evaluation measures

There are runs without any evaluation measure, for example https://www.openml.org/r/8688231
I'm currently counting how many runs are affected.

OK funny story, if I load the reduced databases, I don't find any runs in the database that are missing the accuracy.
When we last checked, did you load the latest reduced_task3.sql.gz file?

There are 6 runs, which don't have scimark evaluated.
+---------+
| rid     |
+---------+
| 7949115 |
| 8297503 |
| 8297504 |
| 8418794 |
| 8529033 |
| 8529303 |
+---------+
6 rows in set (0.28 sec)

We can safely ignore these I assume. All other runs have every measure set.

+---------+
| rid     |
+---------+
| 2414382 |
| 7949115 |
| 8297503 |
| 8297504 |
| 8418794 |
| 8529033 |
| 8529303 |
+---------+

There is only one more run with scimark missing in the full database. We should just ignore scimark on these runs.

There are runs without any evaluation measure

I guess this can happen if you upload a configuration but the exection result is not uploaded.

authors: jakob-r mboecker

repo: mboecker/lookup-server


text:
Removing many ranger runs

(Progress: 137 / 468 - 29%) Importing Task 3950 (23 / 78) + Algorithm classif.ranger (5 / 6):	Removing 100.0% (22462/22462) of runs.
(Progress: 125 / 468 - 27%) Importing Task 3917 (21 / 78) + Algorithm classif.ranger (5 / 6):	Removing 83.0% (37681/45405) of runs.
We should investigate what's happening here.

They seem to be deleted, because min.node.size is missing...

Why did you close? For Task 3950 all min.nide.sizes where missing? This can not be good?

Also Task 146082
(Progress: 455 / 468 - 97%) Importing Task 146082 (76 / 78) + Algorithm classif.ranger (5 / 6): Removing 100.0% (1968/1968) of runs.

+----------+----------+------------+------------+---------+
| MIN(rid) | MAX(rid) | MIN(setup) | MAX(setup) | task_id |
+----------+----------+------------+------------+---------+
|    27394 |  9203029 |        592 |    7132827 |    3917 |
|   538412 |  8858440 |       2360 |    6833220 |    3950 |
|  2177937 |  5845025 |      31047 |    3879775 |  146082 |
+----------+----------+------------+------------+---------+

These are the run ids and setup ids for these tasks. My guess would be that all of them were run, before we started setting min.node.size in the bot. It's weird though that they were not run with the updated bot.

Ok maybe @PhilippPro knows an answer?

SELECT input.name, run.setup, run.rid FROM run
JOIN input_setting ON input_setting.setup = run.setup
JOIN input ON input.id = input_setting.input_id WHERE task_id = 3950 AND name = 'min.node.size' LIMIT 10;

gives an empty set

After the latest preparation run we still have the following anomalies (excerpt of all >50% removals):
(Progress: 11 / 468 - 2%) Importing Task 31 (2 / 78) + Algorithm classif.ranger (5 / 6):        Removing 70.6% (78707/111497) of runs.
(Progress: 29 / 468 - 6%) Importing Task 49 (5 / 78) + Algorithm classif.ranger (5 / 6):        Removing 80.1% (42148/52632) of runs.
(Progress: 65 / 468 - 14%) Importing Task 3492 (11 / 78) + Algorithm classif.ranger (5 / 6):    Removing 61.4% (15688/25542) of runs.
(Progress: 71 / 468 - 15%) Importing Task 3493 (12 / 78) + Algorithm classif.ranger (5 / 6):    Removing 55.1% (10480/19019) of runs.
(Progress: 95 / 468 - 20%) Importing Task 3896 (16 / 78) + Algorithm classif.ranger (5 / 6):    Removing 51.2% (13718/26795) of runs.
(Progress: 101 / 468 - 22%) Importing Task 3899 (17 / 78) + Algorithm classif.ranger (5 / 6):   Removing 63.1% (15773/24982) of runs.
(Progress: 107 / 468 - 23%) Importing Task 3902 (18 / 78) + Algorithm classif.ranger (5 / 6):   Removing 56.3% (24457/43473) of runs.
(Progress: 119 / 468 - 25%) Importing Task 3913 (20 / 78) + Algorithm classif.ranger (5 / 6):   Removing 78.6% (30802/39205) of runs.
(Progress: 125 / 468 - 27%) Importing Task 3917 (21 / 78) + Algorithm classif.ranger (5 / 6):   Removing 83.0% (37681/45405) of runs.
(Progress: 131 / 468 - 28%) Importing Task 3918 (22 / 78) + Algorithm classif.ranger (5 / 6):   Removing 80.9% (36461/45076) of runs.
(Progress: 137 / 468 - 29%) Importing Task 3950 (23 / 78) + Algorithm classif.ranger (5 / 6):   Removing 100.0% (22462/22462) of runs.
(Progress: 179 / 468 - 38%) Importing Task 9914 (30 / 78) + Algorithm classif.ranger (5 / 6):   Removing 86.2% (70710/82029) of runs.
(Progress: 191 / 468 - 41%) Importing Task 9952 (32 / 78) + Algorithm classif.ranger (5 / 6):   Removing 63.2% (14122/22328) of runs.
(Progress: 197 / 468 - 42%) Importing Task 9957 (33 / 78) + Algorithm classif.ranger (5 / 6):   Removing 82.0% (39678/48391) of runs.
(Progress: 203 / 468 - 43%) Importing Task 9967 (34 / 78) + Algorithm classif.ranger (5 / 6):   Removing 65.1% (21521/33036) of runs.
(Progress: 209 / 468 - 45%) Importing Task 9970 (35 / 78) + Algorithm classif.ranger (5 / 6):   Removing 49.9% (12736/25515) of runs.
(Progress: 215 / 468 - 46%) Importing Task 9971 (36 / 78) + Algorithm classif.ranger (5 / 6):   Removing 71.6% (25840/36108) of runs.
(Progress: 233 / 468 - 50%) Importing Task 9978 (39 / 78) + Algorithm classif.ranger (5 / 6):   Removing 65.7% (19968/30382) of runs.
(Progress: 245 / 468 - 52%) Importing Task 9983 (41 / 78) + Algorithm classif.ranger (5 / 6):   Removing 69.4% (12329/17756) of runs.
(Progress: 251 / 468 - 54%) Importing Task 10093 (42 / 78) + Algorithm classif.ranger (5 / 6):  Removing 59.6% (10992/18429) of runs.
(Progress: 257 / 468 - 55%) Importing Task 10101 (43 / 78) + Algorithm classif.ranger (5 / 6):  Removing 84.0% (66424/79041) of runs.
(Progress: 311 / 468 - 66%) Importing Task 125923 (52 / 78) + Algorithm classif.ranger (5 / 6): Removing 76.8% (33337/43410) of runs.
(Progress: 323 / 468 - 69%) Importing Task 145804 (54 / 78) + Algorithm classif.ranger (5 / 6): Removing 71.2% (43946/61744) of runs.
(Progress: 341 / 468 - 73%) Importing Task 145836 (57 / 78) + Algorithm classif.ranger (5 / 6): Removing 63.0% (19513/30962) of runs.
(Progress: 347 / 468 - 74%) Importing Task 145839 (58 / 78) + Algorithm classif.ranger (5 / 6): Removing 55.5% (10474/18866) of runs.
(Progress: 377 / 468 - 81%) Importing Task 145855 (63 / 78) + Algorithm classif.ranger (5 / 6): Removing 70.7% (35426/50115) of runs.
(Progress: 383 / 468 - 82%) Importing Task 145857 (64 / 78) + Algorithm classif.ranger (5 / 6): Removing 55.8% (9771/17526) of runs.
(Progress: 389 / 468 - 83%) Importing Task 145862 (65 / 78) + Algorithm classif.ranger (5 / 6): Removing 57.7% (27638/47915) of runs.
(Progress: 401 / 468 - 86%) Importing Task 145878 (67 / 78) + Algorithm classif.ranger (5 / 6): Removing 50.0% (10945/21886) of runs.
(Progress: 419 / 468 - 90%) Importing Task 145976 (70 / 78) + Algorithm classif.ranger (5 / 6): Removing 58.4% (13219/22622) of runs.
(Progress: 437 / 468 - 93%) Importing Task 146064 (73 / 78) + Algorithm classif.ranger (5 / 6): Removing 82.6% (42945/52012) of runs.
(Progress: 443 / 468 - 95%) Importing Task 146065 (74 / 78) + Algorithm classif.ranger (5 / 6): Removing 90.5% (62903/69544) of runs.
(Progress: 455 / 468 - 97%) Importing Task 146082 (76 / 78) + Algorithm classif.ranger (5 / 6): Removing 100.0% (1968/1968) of runs.

@mboecker These numbers used to be not so high, or?

The last commit contains debug information on the amount of rows that were removed due to missing min.node.size. These values should be equal

Removing 29.8% (19999/67017) of runs.
Ranger: Ratio of 'min.node.size is NA' / all runs: 29.8%

I'm pretty sure we can close this now. The problem doesn't seem to be at our end, the OpenML DB simply doesnt contain complete values for these runs.


text:
Arcs vs. Coordinates

I had a problem with D3 choking on "arcs" in topojson file but works with "coordinates" in geojson file. Has anyone had that issue?

You need to convert TopoJSON to GeoJSON using the TopoJSON client library before you can render with D3; D3 doesn’t render TopoJSON directly.

Ah, and I see that I can do the translation client side with the topojson library. Thank you sir!

authors: mbostock mishawagon

repo: mbostock/topojson


text:
Stop messages are not being sent to webhook

    I believe this is still not functional running v2, the started messages still come through, nothing for stopped.

Originally posted by @jbarnes in https://github.com/mbround18/valheim-docker/discussions/633#discussioncomment-5226432

@jbarnes how are you stopping your server? if i use ctrl+c on window it doesnt trigger stop notification but if i stop using kubernetes it does.

Running on ubuntu 20.04 LTS
I am running docker compose up, docker-compose down to start/stop gracefully
Start message comes through no problems, nothing for stop when using the latter
Additionally even with a full server shutdown (Container is running on an EC2 instance) no change in behaviour

I would have anticipated this shutdown behaviour likely would induce a failure to send a stop message, but alas, even the graceful docker-compose down is not producing the message.

@jbarnes can you try upping your stop grace period?
stop_grace_period: 3m

I can confirm, upping that limit on a server on windows with a xxl world will let it stop

Can confirm this has resolved the issue.
Thanks @mbround18, may be worth a documentation update to save you from more whingers like me.
Thanks again.


text:
having repository absolute root path as an env variable on build

Hi,
It's good to have access the mono repo absolute root path in build/custom-command runtime as an environment variable (e.g. MBT_REPO_PATH or MBT_ROOT_PATH) just like MBT_MODULE_NAME and MBT_MODULE_VERSION
Also we can have MBT_MODULE_PATH to get the current module path (relative to root path) as well.

Thanks to @bashiransari, this landed on master today https://github.com/mbtproject/mbt/commit/2af94072dfe27cbd2514aa4c805769334cd99c07
@bashiransari  Should we include MBT_MODULE_PATH as well to complete the issue?

authors: bashiransari buddyspike

repo: mbtproject/mbt


text:
🛑 ChatGenie Client API is down

In bab2a6e, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in b445316.


text:
🛑 ChatGenie Client API is down

In ab6f985, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in a34eed2.


text:
🛑 ChatGenie Client API is down

In 2edb7dd, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in c099009.


text:
🛑 ChatGenie Client API is down

In cd4e5fd, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in 76ed32e.


text:
🛑 ChatGenie Client API is down

In acf9174, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in 077301b.


text:
🛑 ChatGenie Client API is down

In bf560d8, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in 0810b51.


text:
🛑 ChatGenie Client API is down

In b337127, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in d73ccdc after 9 minutes.


text:
🛑 ChatGenie Client API is down

In 03be126, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in e95b6c4 after 27 minutes.


text:
🛑 ChatGenie Client API is down

In c168674, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in 1ea3f26.


text:
🛑 ChatGenie Client API is down

In f1ccadc, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in d76911b.


text:
🛑 ChatGenie Client API is down

In 49878a3, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in 5ed01b6.


text:
🛑 ChatGenie Client API is down

In d771f36, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in 138662b.


text:
🛑 GitHub Mirror is down

In e4b9985, GitHub Mirror (https://gh.chapro.xyz) was down:

HTTP code: 500
Response time: 48 ms

Resolved: GitHub Mirror is back up in fdb800f after 12 minutes.

repo: mchaNetwork/status


text:
🛑 GitHub Mirror is down

In ff0b800, GitHub Mirror (https://gh.chapro.xyz) was down:

HTTP code: 500
Response time: 188 ms

Resolved: GitHub Mirror is back up in 8af7391 after 13 minutes.


text:
Response type-in color not contrasted enough

From users i discussed with : Ima, Oldsongs, Rousseur
Behaviour
Response box not contrasted enough, and people don't see very well what they type in.

Same thing in the categories requested for response, maybe a bit more contrast would be good to see what is expected

Expected
For the type in response, maybe something white and bold for the response typing text? Maybe just the same as when nothng is typed in and says "Any idea" would be ok (and i guess easy?)

For the requested categories, maybe the same as the artists/Titles?

T'es trop chaud aujourd'hui sérieux :)
Merci bcp!!!!

repo: mchev/blinest


text:
Suggestion for Multi Account Update

Since the scans are now down to 10-15 seconds, it's best if we start using multi accounts.
Was wondering if you could add a button on the login page that says "Account 1, Account 2 etc" that we can click and have it auto populate our saved account credentials.
Right now once I open one map and login, it saves those credentials. Then when I want to open my second map, I have to remove the first username and password, and enter in my second account, and so one. Just gets tedious having to type in each account every time and would be easier if we could just click on "Account 2" button and have it populate those fields.
Just an idea.
Thanks for everything you do.

I've been wanting to do the same for a while and I am looking for a way to make it work. Currently, people are saying that it is possible to modify the config file to include multiple accounts but I'm just starting to try this myself.

You can search in more accounts? Just launched second account and app doesnt't scan that one :(

I would love to see this feature. I tried using the other repository that this is app is derived from and started it via command line specifying multi accounts which would work on the other maps (the one that has been shut down) I'm getting an error when trying to use multiple threads though unfortunately so I don't know if it needs to be patched or if I'm doing something wrong. Unfortunately I have a very limited knowledge of python.

Hello, I wanted to ask I cannot get another pokemon catcher account because it says they are "busy". How can I search 2 different locations if I only have one account ? thank you

@zaqrwe What login method are you using? Is it a throw away account? If so, have you logged into it on an old phone/tablet to complete the tutorial? Reports say that the API calls are dropped if the account hasn't completed the tutorial.
@cykou You cannot search 2 locations with 1 account. You must have 1 account for each location you want to search.

Well I tried getting another PTC account but  the Pokemon site won't let me
. Is there a workaround for this ? thank you for help.
On Sun, Aug 7, 2016, 7:24 PM mg6101 notifications@github.com wrote:

@zaqrwe https://github.com/zaqrwe What login method are you using? Is
it a throw away account? If so, have you logged into it on an old
phone/tablet to complete the tutorial? Reports say that the API calls are
dropped if the account hasn't completed the tutorial.
@cykou https://github.com/cykou You cannot search 2 locations with 1
account. You must have 1 account for each location you want to search.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mchristopher/PokemonGo-DesktopMap/issues/720#issuecomment-238122780,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT3BZWswB4csdzNpoEEApQIfpAMOXti-ks5qdoVlgaJpZM4JelbP
.

@cykou There is not a work around. You will have to wait for the site to come back online. Usually takes a few hours.

dang , the site seems permanently screwed for account creation. Before Niantic did the API mess up  you could use the same account to get different scans does anyone know why?

It's only temporary. Niantic released the game in 15 new countries over the weekend so the site is getting hit pretty bad. As for why you can't use 1 account, niantic made some very significant changes in the way it validates API calls. Everything from your location, orientation, and even magnetic field of the earth, among others, all get calculated to encrypt your request for map data. In addition, requests from the same account, in 2 different locations is an immediate red flag. Your map will display no Pokémon at all and could result in a ban of the account. There haven't been massive ban waves yet but they have said they are coming once the server issues are all settled. Be careful. Don't use your real account for maps and definitely don't use services or apps to spoof your gps data.

Because of the API changes you can only make 1 API call every 10 seconds for scanning purpose anyways. This is due to the rate limiting. The way to get around this is multiple accounts ~10 ish throw away accounts on multiple threads to update an SQLite or MySQL backend. I'm working on something similar and will submit a pull request to merge the change into the master branch when done.

When I startup "Pokemon GO Live Map.exe" a second time with a different PTC account, I seem to have two working instances but there is only one valid marker. If I target another area on the second instance, the marker on the first instance moves as well. How should I do this?

authors: Barabicus cykou davidluong ejd59005 mg6101 tkrause torantal zaqrwe

repo: mchristopher/PokemonGo-DesktopMap


text:
How do I specify a Fine Tuned model in OpenAI

Thanks for the great system!
How do I specify a Fine Tuned model in OpenAI ?
Please teach me.
Thank you.

You could likely use the custom model feature in a hacky way, but we don't support this directly yet

repo: mckaywrigley/chatbot-ui


text:
issue creted from python

Default Description

Automated comment - Fri Jan 20 12:19:18 2023

repo: mcmpdemoeng/jpetstore-kubernetes


text:
How to evaluate mAP with no instances detected?

Hi, we have a network that has been trained in a particular way, and sometimes it hasn't a great accuracy. We noticed that, for the mAP calculation in instance segmentation, the script requires at least one prediction per frame. However, there are frames where we fail to detect any instance. How can we run an evaulation on those? Thanks in advance.

Hi, did you try to create an empty .txt file for those frames where you have no prediction?

What is the error message/stacktrace?

authors: fabvio mcordts

repo: mcordts/cityscapesScripts


text:
Fix error/successfull messages

First of all we have to review all messages and fix language issues. Also we should move messages to one shared place.

All messages (from cs and js files) are stored in Resource project now. Generally we have to store there all multilanguage titles/messages.

repo: mczachurski/community-web


text:
License

Can you include a LICENSE file?

Thanks, I've added an MIT license file: dc5343188e9603546b7d01243e8fe1d552bfcb3d

authors: jaredsohn mdamien

repo: mdamien/chrome-extensions-archive


text:
Feat: Add some Hover effect on the Our team page[cards]

Describe the feature
Add some Hover effect on the Our team page[cards]
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@mdazfar2 I can efficiently add hover effect on cards in contributor page as I have made the cards. So, Please Assign this to me.


text:
definition of favorites, listens and interest in track features

My team are conducting an academic research project using your dataset, and we were wondering if you can help us clarify what each of the three columns means

track_favorites
track_listens
track_interest

Specifically, we are looking to understand how these columns are generated and if they can be a good measure of popularity, or if any other columns should be used instead.
Thank you!

All this data comes from the Free Music Archive API. The documentation is unfortunately rather scarce... (I am preparing a table to explain each field in greater details.)

track_favorites is the number of users who starred the track. If you look at the screenshot below, a logged in user can star a track by clicking on the star icon.
track_listens is the number of users who listened to the track. Anybody can increase the count by listening to the sound online by clicking on the play icon.
I don't know exactly what track_interest is. I guess it's a measure of how popular a track is that they use for recommendation. I asked the administrators but did unfortunately not get any answer. Let me know if you can figure it out!

I'd say the first two are solid measures of popularity. The third might be, but we should be sure what it is. You might also consider:

track_comments, the number of comments users wrote about a song.
favorites, listens and comments at the album and artist levels. A user may e.g. star a whole album instead of every individual tracks. If you look at the histograms here, you'll see that users listen much more to whole albums than individual tracks for example.
The number of downloads, as seen on the screenshot below. I did however not collect this because it's not available through the API. But it can be scraped from the website.
Another measure might be how often tracks appear in public mixes. These are playlists created by registered users. I did not collect this either, but it can again be scraped from the website.

Please let us know if you collect additional data and I will mention it here. :)

Todo: add an appendix in the paper which describes where each piece of information comes from, similar to the above.

authors: mdeff yiyichen

repo: mdeff/fma


text:
Use Ember.copy and assign instead of jQuery extend.

jQuery is not available in fastboot, we can achieve the same result using Ember helpers.

Thanks @abuiles!

authors: abuiles mdehoog

repo: mdehoog/ember-data-has-many-query