text:
"Extract CSS File" seems misleading

First of all, thank you so much for your work in compiling this table! It's an awesome reference.
Now, my question: How do you determine whether a library supports CSS file extraction (under the "Extract CSS File" column)? As an example, aphrodite has a checkmark under that column, but this issue suggests that this is explicitly not a feature of the library. Other libraries that have that checkmark in the table, such as glamorous, don't suggest any way of accomplishing this.
Either I'm misunderstanding what that column means, in which case it might be a good idea to describe it in the readme, or some of these values are incorrect. If it's the latter, I would be more than happy to go through them and compile a list of which of these libraries actually advertise this as a feature.
Thanks!

A few minutes after writing this, I discovered that you have an example of CSS file generation in each of the example directories. My bad for not seeing that sooner. :grin: However, I think using the word "extract" here is misleading, because (at least to me) it implies something that statically extracts all the generated CSS into a file at build time (a la extract-text-webpack-plugin), whereas your examples generate a CSS file dynamically based on what was rendered by React. Maybe this is just my own personal bias showing (I've always used extract-text-webpack-plugin with LESS/CSS modules to generate static CSS files at build time), but the wording in the table seems misleading, because this method doesn't actually allow you to extract a full, reusable CSS file that you could use for the whole app, since it depends on what was rendered. An example of a CSS-in-JS library that does support the kind of file extraction I'm talking about is emotion (though admittedly, it's very limited in how you are allowed to use it).
Do you have any thoughts on how to make this more explicit?

Mostly performance reasons for server-side rendering. I'm working on a small project that has to support clients with JS disabled, so the app is "universal" (or isomorphic or whatever term you prefer :wink:). Generating a static CSS file is a requirement because then it gets cached in the browser forever, rather than having to serve different CSS with every page load (which is what I would have to resort to with most CSS-in-JS libraries). I otherwise prefer the CSS-in-JS approach from a developer experience standpoint, so I was curious as to whether any libraries gave you the best of both worlds, and stumbled upon this repo in my search.
I understand my use case is probably not very common, so feel free to ignore me. :grin: I have just always seen the word "extract" used in the context of things like extract-text-webpack-plugin that extract the CSS statically at build time, so this threw me off a little bit.

so the app is "universal" (or isomorphic or whatever term you prefer 😉)

the word you are looking for is graceful degradation e.g. with SSR and extracted CSS browser will able to render page even if JS is disabled
Extracting CSS and prerendering HTML (with SSR) improves First Paint significantly.

understand my use case is probably not very common

It is pretty common - I mean requirement to generate CSS as text upfront would it be separate file or inlined in HTML in header.

I was asking because I am currently working on nano-css and there all raw CSS is available as a string in nano.raw property. I think the general approach (especially for single page apps) is to inline that string into server rendered HTML, which should be faster than doing one extra request for .css, for example, Google AMP requires you to inline CSS.
You could actually serve that string on a server as a separate file, too.
A bit more problematic would be to extract all styles at build time. I am thinking, one could simply at build time require all .js component files, that would build static CSS in nano.raw and that can be saved to disk. Do you see any problems with that globbing for all files in /components folder and simply requiring them?

@stereobooster To clarify, when I said it's not common, I meant it's likely not common for people using CSS-in-JS solutions (at least, that seems to be my experience). This works just fine if you use plain CSS or a preprocessor like LESS or Sass, but I think most people who go the CSS-in-JS route are aware of the drawbacks and don't care about having all the CSS up front. In fact, you could argue that is one of the advantages of doing CSS-in-JS: it only renders the minimal CSS necessary in most cases.
@streamich I think simply requiring the components and pulling out nano.raw in a script would be pretty finicky, because if your JS relies on any preprocessing steps like babel, then that script would have to go through your build process before it gets run, which is one of those awkward meta things that's hard to deal with. A more general approach would be to write a babel plugin (or similar), as then the build system (e.g. webpack) can then extract that data as the files get parsed/compiled, instead of in a separate step. (This is how emotion does it.) However, this means all your style generation code has to be parseable statically, at compile-time, which limits what you can do with it (i.e. you can't have dynamically-generated styles that depend on runtime values). From a brief look at your library, I don't think this would be possible, at least not generally.

There is linaria - CSS is extracted at build time, no runtime is included

@stereobooster Awesome, that's exactly what I was looking for! Eventually I would have gone through the whole list, but that saves me a lot of time. :) Thank you!

To go back to the topic of this issue for a second, I just checked out your feature definitions here, and "zero runtime dependency" fits what I was looking for, I just hadn't thought of it that way. So if that page is representative of how the features of these libraries will ultimately be described, I think that solves this issue.

So if that page is representative of how the features of these libraries will ultimately be described, I think that solves this issue.

that was the idea, but we are not quite there yet

Just wanted to add here, that one of the main reasons to use CSS-in-JS is to be able to use component or render method variables in your CSS, like props. In that case I don't see how CSS can be extracted, or are there libraries that do that?

@streamich Agreed, I think that's the main reason people use these solutions, so it makes sense that static file extraction isn't a top priority for (or even supported by) a majority of CSS-in-JS libraries. Having said that, stereobooster pointed out that linaria is one library that does everything at build time, so there is at least one example.

is to be able to use component or render method variables in your CSS, like props

Yes, but most of the time this is not random value, but rather limited set of values which represent all possible states of application, like in Redux. So you can compile CSS-in-JS down to static CSS with limited number of classes which corresponds to all states

@stereobooster

So you can compile CSS-in-JS down to static CSS with limited number of classes which corresponds to all states

Has anyone done that? Or, at least, maybe just the default value could be extracted as a CSS class.

@stereobooster But to do that you would have to somehow know every possible state of your application, which isn't possible (at least not generally—you could just render the app and grab the generated CSS, but that would only work assuming none of the variables ever change). Even Redux doesn't magically know all the possible states of the store, it just helps you be more explicit about state changes. That's why you're limited in what you can do if you want support for static CSS extraction.
@streamich I would be interested in a solution that combines the static and dynamic approaches, where it would statically compile as much CSS as it can, and dynamically load the rest. But I'm not aware of a library that does this, and it seems like that would take a lot of work to implement.

@russiancow I thought about it a bit and I think it is kinda doable.
rule() and sheet() interfaces — rule() is basically the one Linaria provides — should be straight-forward: there would be a script maybe as part of Babel or Webpack that at build time either detects are component modules or uses a glob pattern to find them. Then it simply evaluates those modules, I believe this is what Linaria does (for example, because it requires no side-effects). Once executed all CSS would be simply available in nano.raw as a string.
For jsx() interface it extract the initial CSS automatically, as it internally uses rule(). However, we would not be able to extract the dynamic styles of the jsx() interface, they would need to be accumulated as a string in injected into HTML on an actual page request.
Then style() interface actually uses jsx() internally, but — because its dynamic CSS is a function of props — one could for example run that function with no props or with default props, that way extract the *"default" dynamic CSS.

@streamich This is what Linaria does (the 3rd generation part at least), so I think you're right, that will work. However, I personally don't think evaluating modules to get their style info is a good strategy because it means your code cannot depend on any preprocessing other than babel (such as webpack loaders, as noted in the issue here). Myself, I make heavy use of file-loader, so this is a deal-breaker for me, but I can see this issue arising with other build setups as well.
Is there no reason you couldn't just extract all of that info with a babel plugin, without needing to evaluate the file? What do you gain by doing that?
PS: I like that separation of libraries by generation; it's very helpful.

Actually, I just realized why Linaria does it that way. The key is in this comment and the one after it:

Correct me if I’m wrong, but Linaria needs to import the dependencies of the current file in order to run the code that's interpolated in the CSS, right? At that point, the current file’s dependencies have not yet been processed by Webpack, as the references have just been encountered. If my assumptions are correct, it seems pretty clear why it doesn’t work. In fact, I don’t see how it can work. Short of rewriting it as a Webpack plugin.

So evaluating the modules is necessary in order to properly parse styles that use references from other files, like this:
import colors from './colors'
const style = css`
  color: ${colors.blue};
`

Then the solution I want wouldn't be possible with babel alone; you'd need a plugin for the bundler (e.g. webpack) to then follow and process all of the references after the bundle has been built. So, it's possible, but definitely not easy, and the solution would be tied to webpack or whatever bundler(s) you choose to write a plugin for.

@russiancow

Is there no reason you couldn't just extract all of that info with a babel plugin, without needing to evaluate the file?

One big reason for using CSS-in-JS is the power JavaScript gives you. Like variables
const className = rule({
  color: require('../my-theme').mainColor
});

Mixins:
const baseButtonStyles = {
  border: 0,
  background: 'grey',
};

const styles = sheet({
  button: baseButtonStyles,
  primary: {
    ...baseButtonStyles,
    background: 'blue'
  }
});

Environment vars:
const className = rule({
  outline: process.env.DEBUG ? '1px solid red' : '0'
});

And anything else you can imaging...

...and the solution would be tied to webpack or whatever bundler(s) you choose to write a plugin for.

Yes, but everyone uses Webpack :) Also, this problem arises only if you use Webpack loaders (but then again, everyone uses those :( ) Yeah, I guess it would have to be Webpack plugin.

@streamich Right, I was asking about whether you had to actually evaluate the file in order to compile that info. Looks like you do unless you write a webpack plugin that follows all the references after the fact. So yeah, it would have to be either a babel plugin, and just not support loaders or any other kind of preprocessors, or a webpack plugin, which sounds harder to implement (I don't know) and would only work with webpack, but would work with no limitations on your code or build process.
I guess you could write the plugin such that it would try to compile whatever styling it can statically, and if there is anything dynamic that it depends on (for instance the return value of a function call), it would leave that to be "compiled" at runtime.

@russiancow
I've create an extract addon, that does something like discussed above. It is not a complete solution, but just the lowest level, on top of which Webpack plugin or Babel one can be built.
Here I created a demo:

https://github.com/streamich/nano-css-extract-demo

there is also https://github.com/4Catalyzer/css-literal-loader

authors: russiancow stereobooster streamich

repo: MicheleBertoli/css-in-js


text:
Group Loan Accounts

Done Dividing loan and interest for the group members equally after approving the loan, generating receipts for the each member when they pay amount with principle and interest charged for every month and adding balance amount in the further month. changing loan issued date for the loan account when the payment is created. filtering loan accounts for the client in the group only when the loan is under approved state only.

Coverage increased (+0.1%) to 87.322% when pulling 2b70683463e1effbed930617e7dbeb14230ab7e7 on swethanaretla:loan_issues into 16622382d3ec67a102058131d78d1f4b5043754c on MicroPyramid:master.

source: gharchive/pull-request

authors: coveralls swethanaretla

repo: MicroPyramid/micro-finance

license: mit

license_type: permissive

license_source: bigquery


text:
[Event Request] Report 7315 - OnBeforeInsertAdjmtBinQuantityBuffer

In report 7315 Calculate Whse. Adjustment, trigger Integer - OnAfterGetRecord, please add the following event:
[…]
              "Qty. Outstanding (Base)" := WhseEntry."Qty. (Base)";
              // >> NEW
              OnBeforeInsertAdjmtBinQuantityBuffer(VAR AdjmtBinQuantityBuffer,WhseEntry);
              // << NEW
              INSERT;
            END;
          END;
        UNTIL WhseEntry.NEXT = 0;
[…]

Note: added as OnBeforeAdjmtBinQuantityBufferInsert

source: gharchive/issue

repo: Microsoft/ALAppExtensions

license: MIT

license_source: github-api


text:
[TS] ActionSet element type to render actions anywhere

DELETED

Closing, accidently created

repo: Microsoft/AdaptiveCards


text:
Ubuntu 16.04 is slow in bash but ubuntu 14.04 was faster

Please use the following bug reporting template to help produce actionable and reproducible issues. Please try to ensure that the reproduction is minimal so that the team can go through more bugs!

A brief description

When I do things like sudo apt-get update and sudo apt-get upgrade those commands are slow
I think other commands are also slow

Expected results

I expect them to be faster like they were in Ubuntu 14.04

Actual results (with terminal output if applicable)

It is slow take a few seconds before the commands start.

Your Windows build number

14915

Steps / commands required to reproduce the error
sudo apt-get update

sudo apt-get upgrade

Strace of the failing command
None
Required packages and commands to install
None
See our contributing instructions for assistance.

@paladox I'm trying the 16.04 and it seems that the speed is identical to the previous one, both in terminal mode and using Xfce and graphic software

Could you please retry in Creators Update and see if you are experiencing the same slowness?

authors: benhillis iz0eyj paladox

repo: Microsoft/BashOnWindows


text:
Bot Framework Emulator error while I opened it!

Hi
I wanna test my test-bot but while opening the emulator, it gives me the following error logs.
[00:03:39] Emulator listening on http://[::]:48555  [00:03:39] [err-server] spawn UNKNOWN "Error: spawn UNKNOWN\n at exports._errnoException (util.js:1026:11)\n at ChildProcess.spawn (internal/child_process.js:313:11)\n at exports.spawn (child_process.js:392:9)\n at runNgrok (C:\\Users\\Halwest\\AppData\\Local\\botframework\\app-3.5.25\\resources\\app\\app\\server\\ngrok.js:109:13)\n at run (C:\\Users\\Halwest\\AppData\\Local\\botframework\\app-3.5.25\\resources\\app\\app\\server\\ngrok.js:67:13)\n at C:\\Users\\Halwest\\AppData\\Local\\botframework\\app-3.5.25\\resources\\app\\app\\server\\ngrok.js:77:13\n at lock (C:\\Users\\Halwest\\AppData\\Local\\botframework\\app-3.5.25\\resources\\app\\node_modules\\lock\\index.js:72:7)\n at Object.connect (C:\\Users\\Halwest\\AppData\\Local\\botframework\\app-3.5.25\\resources\\app\\app\\server\\ngrok.js:61:5)\n at startNgrok (C:\\Users\\Halwest\\AppData\\Local\\botframework\\app-3.5.25\\resources\\app\\app\\server\\botFrameworkService.js:95:23)\n at ngrok.kill (C:\\Users\\Halwest\\AppData\\Local\\botframework\\app-3.5.25\\resources\\app\\app\\server\\botFrameworkService.js:129:17)"  [00:03:39] Checking for new version...  [00:03:42] Application is up to date.
note: I don't know run which port of ngrok.
thanks.

@eanders-MS could you help me!

It looks like the emulator is failing to launch ngrok. Could you please check your installed version of ngrok to ensure it is version 2.1.18 or later? Earlier versions have been known to be incompatible. Check the version by running ngrok -v from a command prompt.
Note: You only need ngrok when connected to a bot running remotely. You don't need ngrok to connect the emulator to a bot running on localhost.

thanks for your replay @eanders-MS, ngrok version 2.1.18 .

Is your ngrok path correctly configured in the Emulator's app settings?

@HalwestRasul Hello, did the answer from @eanders-MS work for you? I'll close this for now, but feel free to reach out again.

@eanders-MS  yes, ngrok path is true, but I wanna test it in localhost !

I wonder if the ngrok client is working at all. Are you able to run ngrok from the command line? What do you see when you run this command:
ngrok http -host-header=rewrite 3978

@eanders-MS  I'm sorry before I said that the ngrok path was true but its wrong now its true because I moved the ngrok.exe  :)
Thanks for you now the Emulator was work fine ;)

authors: HalwestRasul carlosscastro eanders-MS

repo: Microsoft/BotBuilder


text:
Skype: How to get full certified/full trust to bot?

Bot Info

SDK Platform:  .NET Framework
SDK Version: 3.16
Active Channels: Skype
Deployment Environment: Azure Bot Service (via Azure App Service?. I'm deploying to app. but managing channels in bot)

Issue Description
I know at least two bots with full access to all group messages: Skype Translator and Sameroom
But when I'm trying to add my bot I got message from skype that bot will receive only direct messages (with nick)
Code Example
Standard bot project draft from Azure Bot Services: SimpleEcho
Reproduction Steps

Save skype bot channel
Add to any group
Type any words

Expected Behavior
Bot does not receive messages
Actual Results
Bot must receive any message
I need to know how could I receive all messages?
As I see other bots (even NOT from Microsoft) could be able to work as expected so there must be some way to enable that. I does not found anything in docs or google.

This is not a feature generally available.  I think Sameroom has partnered with Skype, and is using an undocumented API.  I don't know what it is, or how to enable this for your bot.  I do know this is not a feature generally available, and there are no plans in place to enable it for all bots.  Closing this issue, since there isn't anything for anyone to do here.

authors: EricDahlvang Sopholos


text:
[Question] CLI/ Programmatic use

Hi - can you point me towards examples/tests that show how I can use the emulator programmatically? I want to be able to run functional tests against localhost without needing to set up directline and ngrok; the emulator seems to be the answer to that so long as I can manipulate it without a GUI.
Thanks!

Hi @rposbo, the emulator does not support "headless" operation. I wish I had a better answer for you!

authors: eanders-MS rposbo

repo: Microsoft/BotFramework-Emulator


text:
Is it possible to pause and resume script execution in JSRT?

Hi,
I’m trying to use the built in JSRT engine to build a simple non-visual browser for crawling and data scraping solution. I’m following HTML5 WHATWG specifications.
One point that I don’t know whether it is possible in  JSRT or not is the ability to pause the execution of a script, execute another one and then resume the paused script.  This is one of the requirements defined in HTML5 specs as described here https://html.spec.whatwg.org/multipage/scripting.html#script-processing-model

In some situations, HTML5 requires to ”Immediately execute the script block, even if other scripts are already executing.” This is defined as “an operation that is to run immediately must interrupt the currently running task, run itself, and then resume the previously running task”
This point is important especially when handling dynamically created and inserted scripts into the DOM. Otherwise, the script engine may block the HTML parser.
I’m aware about JsDisableRuntimeExecution API but this as I know will cancel the execution on the whole runtime, and there is no way to resume the execution again. Also, this is not suitable as I may have multiple execution contexts (for example when dealing with Iframes and other types of nested browsing contexts).
Any idea how to achieve pause and resume behavior in JSRT. Or any workarounds?
Regards,
Atef

Others may answer this better. I will try to approach to this problem generally.
Lets consider a JavaScript loop logic below;
for(var i=0; i<100; i++) {
  // do something
}

This will keep the thread busy until the loop ends. In order to pause this at any given time, we may have to pause the execution from another thread.
AFAIK, There is no magical solution to this.
1 - Decide on order prior to running any script. I know, there are cases make this really hard.
2 - You could inject a function call as given below and decide whether you want to pause or not.
void myPauseFunction (....)
{
    if (shouldPause) {
       // call pthread - Windows thread wait / sync etc. to keep this thread on hold
    }
}

for(var i=0; i<100; i++) {
  myPauseFunction();
  // do something
}

3 - One another option is to suspend / resume the thread using C/C++ etc. features..
On Windows you could use SuspendThread and ResumeThread on JS engine's thread. However, this may lead to an unknown behavior due to GC thread / locks, reaching JSRT from another thread etc.. You might have to keep runtime from using background threads. (JsRuntimeAttributeDisableBackgroundWork)
See also pthread_suspend for non Windows.
FYI; regardless from the implementation, suspending the thread is not instant or guaranteed.
P.S. This is not a good option in case you want to run another script while the JS thread is suspended unexpectedly.
4 ) Listen to memory allocation callback -> [JsMemoryAllocationCallback] (https://github.com/Microsoft/ChakraCore/wiki/JsMemoryAllocationCallback) This is similar to (2) and you can keep the execution on pause. However, loading another script here is a bit more tricky (if it is doable properly at all)

AFAIK there's no direct way to pause & resume in JSRT. Pausing in the middle of an execution actually leaves the engine in a weird intermediate state and in most cases we don't allow script re-entrancy as it could mess up our internal state.

Looks like this question is answered. Closing.

authors: atefshehata dilijev liminzhu obastemur

repo: Microsoft/ChakraCore


text:
Cmake Automatic Configuration

This is a rework for the ChakraCore automatic configuration. This is two patches that will allow many developers to quickly start developing using ChakraCore. I will be pushing a rework of the patches to the ChakraCore examples later, however the general process for this is as follows:
An example of how to use this is as follows...
# include Auto-Configure macro.
include("${CMAKE_SOURCE_DIR}/ChakraCore/ChakraAutoConfigure.cmake")
# Configure ChakraCore:
CHAKRACORE_AUTOCONFIGURE()
add_subdirectory(ChakraCore)
add_custom_target(CopyChakraHeaders ALL
	COMMAND ${CMAKE_COMMAND} -E make_directory "${CMAKE_BINARY_DIR}/include"
	COMMAND ${CMAKE_COMMAND} -E copy_if_different
		"${CMAKE_SOURCE_DIR}/ChakraCore/lib/Jsrt/ChakraCore.h"
		"${CMAKE_BINARY_DIR}/include"
	COMMAND ${CMAKE_COMMAND} -E copy_if_different
		"${CMAKE_SOURCE_DIR}/ChakraCore/lib/Jsrt/ChakraCommon.h"
		"${CMAKE_BINARY_DIR}/include"
	COMMAND ${CMAKE_COMMAND} -E copy_if_different
		"${CMAKE_SOURCE_DIR}/ChakraCore/lib/Jsrt/ChakraCommonWindows.h"
		"${CMAKE_BINARY_DIR}/include"
	COMMAND ${CMAKE_COMMAND} -E copy_if_different
		"${CMAKE_SOURCE_DIR}/ChakraCore/lib/Jsrt/ChakraDebug.h"
		"${CMAKE_BINARY_DIR}/include"
)
# enable C++11
add_executable(ChakraSample sample.cpp)
set_target_properties(ChakraSample PROPERTIES COMPILE_FLAGS "-std=c++11")
# link to ChakraCore.
target_link_libraries(ChakraSample ChakraCore)
# Make sure Chakra Core Headers are in a location that is easy to use.
add_dependencies(ChakraSample CopyChakraHeaders)
# Actually include the headers.
target_include_directories(ChakraSample PUBLIC "${CMAKE_BINARY_DIR}/include")

Hi @kphillisjr, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

/cc @obastemur

@dilijev and @obastemur, This does not include the major commit that resolves direct linking only to the ChakraCore shared library. The next commit provides a usable solution to issue #1811, but it breaks the ch utility in the process. This change is the following patch ( https://github.com/kphillisjr/ChakraCore/commit/75182f3e50280ac154d9397ba381bd4272ecaee9 ), and to test this change on top of this pull request, run the following commands...
#Download and get the right ChakraCore Source Tree.
git clone https://github.com/kphillisjr/ChakraCore.git
cd ChakraCore
git checkout fix_issue_1811
cd ..

# Download and get the correct Chakra Samples tree.
git clone https://github.com/kphillisjr/Chakra-Samples.git
cd Chakra-Samples
git checkout samples_cmake_v3
ln -s ../ChakraCore .
# Use the build script... It's a copy of what is in ChakraCore anyways.
./build.sh
# This BuildLinux/Debug will contain ChakraHelloWorld  and ChakraOpenGLEngine
# that link directly  to libChakraCore. Also both of these examples are
# functioning correctly.

/cc @liminzhu - This pull request will definitely effect the ChakraCore samples.

https://github.com/Microsoft/ChakraCore/issues/2575#issuecomment-283128713

authors: dilijev kphillisjr msftclas obastemur


text:
StackTrace Not Working

Stack trace is not working .
I am using the following code to fetch stack trace:
string trace = engine.GetStackTrace();
It always returns blank  value.
Any help would be higly apppreciated.
Regards

Hi @jaskaran0001,
If you're using JScript or VBScript, GetStackTrace always returns an empty string unless you pass WindowsScriptEngineFlags.EnableDebugging to the engine constructor. This is a limitation of Windows script engines.
Good luck!

i am using the following code to create vbscript engine.
 engine = new VBScriptEngine(WindowsScriptEngineFlags.EnableDebugging);
It is still returning empty string for GetStackTrace. Is there anything else that i need to be careful about ?

Hi @jaskaran0001,
A stack trace only exists when the engine is executing script code, so calling this method only makes sense in a host method invoked by script code.
Here's a complete sample program that demonstrates GetStackTrace usage:
using System;
using Microsoft.ClearScript;
using Microsoft.ClearScript.Windows;
namespace Test {
    public class Host {
        public ScriptEngine Engine;
        public void DoSomething() {
            Console.WriteLine(Engine.GetStackTrace());
        }
    }
    internal static class Program {
        public static void Main() {
            using (var engine = new VBScriptEngine(WindowsScriptEngineFlags.EnableDebugging)) {
                engine.Script.host = new Host { Engine = engine };
                engine.Execute("host.DoSomething");
            }
        }
    }
}

Are you calling GetStackTrace in some other scenario?

repo: Microsoft/ClearScript


text:
AppServiceConnection with winform client

Hello
When i call AppService on UWP app, the AppServiceConnectionStatus returns Success.
But, when i call AppService on winform or wpf client, the AppServiceConnectionStatus still return AppServiceUnavailable.
How can I solve this issue?
My sample project https://setup.aserweb.com/AppServiceSample.zip
Thanks a lot.

Hi!
AppServiceUnavailable means that the app with the specified package family name is installed and available, but the app does not declare support for the specified app service. Check that the name of the app service and the version of the app are correct.
If you still have the issue please share your project again as currently it is unreachable.
Thanks!
Vlad

Please let me know if you have any further issues.
I am closing this issues.
Thanks,
Vlad

authors: vladimp yxylpj

repo: Microsoft/DesktopBridgeToUWP-Samples


text:
Prevent DevicePassword from being overwritten

BuildDeployPrefs.FullReinstall was overwriting the BuildDeployPrefs.DevicePassword field every time it gets set, making it impossible to enter a password.

Hi @teddytrowbridge, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Hey Teddy! This fix is also in #130 which I'm planning to merge in tonight. I'll compare this against that once it's in.

Cool, thanks Josh!

Looks like you found another one!

authors: jwittner msftclas teddytrowbridge

repo: Microsoft/HoloToolkit-Unity


text:
Add feature contribution computing

Add feature contribution computing
Add document and example for feature contribution computing

@yanyachen,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

authors: msftclas yanyachen

repo: Microsoft/LightGBM


text:
timeline visual loses filter after a few clicks

The timeline slicer has a different behaviour than the default slicers included with Power BI. When using the timeline visual, the visual tend to reset after a few clicks around other visuals.
Say that I use the timeline slicer to show filter data in a page to show only entries from Q1/2015. After that, I go about clicking on other charts (e.g. a slice of a pie chart, or a column in a column chart). The selection I did on the timeline will eventually reset, which makes the timeline visual unusable.

@pmdci Thanks, we'll investigate this problem.
Added to our backlog.

authors: ignatvilesov pmdci

repo: Microsoft/PowerBI-visuals


text:
Improve yaml files

Description

Looking at conda_bare.yaml and at the resulting environment there are some improvements and better practices we could follow.
In which platform does it happen?

I checked conda_bare.yaml but we should also check the gpu and spark versions.
Expected behavior (i.e. solution)

As @msalvaris noted, it is good practice to have the packages in alphabetic order, unless the installation order makes a difference.
We should move some libraries from pip to conda i.e. pandas, scipy etc.
In the resulting yaml file there are two versions of tensorflow, so we should probably remove it from conda (since TF is out of date on Anaconda) :
tensorflow                1.12.0                    <pip>
tensorflow                1.5.0                    py36_0    conda-forge

PR #512 addresses these.

repo: Microsoft/Recommenders


text:
--init should default on strictNullChecks

I think strictNullChecking should be true by default whenever generating a ts project with --init?
Right now, the options is not generated:
$ tsc --version
Version 2.1.0-dev.20160908

$ tsc --init
message TS6071: Successfully created a tsconfig.json file.

{
    "compilerOptions": {
        "module": "commonjs",
        "target": "es5",
        "noImplicitAny": false,
        "sourceMap": false
    }
}

Oops didn't check #9642

repo: Microsoft/TypeScript


text:
Odd behavior with --noImplicitAny false --strictNullChecks true

Given this code:
const x = [];
x.push(1);
const y: string = x[0];

With various settings of --noImplicitAny and strictNullChecks, we get the following types for x on line 3:

--noImplicitAny false
--noImplicitAny true

--strictNullChecks false
any[]
number[]

--strictNullChecks true
never[]
number[]

I would expect the lower-left corner to also be any[], not never[].
(Ref: https://github.com/Microsoft/TypeScript/issues/16218#issuecomment-305971027)

With --noImplicitAny true --strictNullChecks false, I would expect an un-annotated [] to fail -- and it does, but only inside another array, as in [[]].
const a = []; // OK?
const b = [[]]; // Error
const c = [].map(() => []); // OK?

I would expect the lower-left corner to also be any[], not never[].

Thank you.
With the --strict true and --noImplicitAny false compiler options, the compiler forces us to sprinkle the code with unpleasant statements:
const arr: any[] = []

authors: andy-ms paleo


text:
Infer static member references

In the following code:
export default class SettingsParser {
	private static _settings: Settings;

	/** Parse commandline, check settings, and init logging to appropriate loglevel */
	public static parse(settings: Settings) {
		_settings = settings;
	}
}

The _settings reference is flagged as an error with the message "[ts] Cannot find name '_settings'. Did you mean the static member 'SettingsParser._settings'?"  Yes, I did.  C# just infers this.  Why can't TypeScript?  Having to write SettingsParser. each time is very verbose.

TypeScript just type-checks JavaScript code -- it doesn't alter it. Since your example won't work when run as JavaScript, TypeScript will issue an error.

It alters it a bunch, like making import statements into require statements if necessary.  Why not add the class name when it is useful?  It doesn't work run as JS but that's not a design goal of TS - the design goal is "valid JavaScript is valid TypeScript", not the other way around.

See https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

It alters it a bunch, like making import statements into require statements if necessary.

That is transforming one form of valid TypeScript to another form.  Transpiling.

That's somewhat splitting hairs.  It's changing variable names.  Fundamentally it is changing the input code.  Why does it matter if it isn't valid JavaScript going in?

@DanielRosenwasser So if it's a "bad idea" to emit this different code, what would one suggest as a good alternative?  Do we really have to write out the whole class name every time?

You could just use a let in the scope of the class.
let settings: Settings;
export default class SettingsParser {
	public static parse(settings: Settings) {
		_settings = settings;
	}
}

@andy-ms You mean let _settings: Settings;?  Is that logically the same as a static member, though?

It's not the same as a static member since it's not a property on the class -- it can only be accessed in its scope. But since you wanted the property to be private anyway, that's probably what you want.

If you need that, there's
let _settings = {};
export default class SettingsParser {
    get settings() {
        return _settings;
    }
}

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

authors: DanielRosenwasser andy-ms jez9999 kitsonk mhegazy


text:
JSDoc hovertip incorrectly displays @typedef descriptions on next declaration

From @mavc on October 27, 2017 20:47

VSCode Version: Code 1.17.2 (b813d12980308015bcd2b3a2f6efa5c810c33ba5, 2017-10-16T13:59:46.104Z)
OS Version: Windows_NT x64 6.1.7601
Extensions: Extensions are disabled

Steps to Reproduce:

Create file foo.js with JSDoc example http://usejsdoc.org/tags-typedef.html:

/**
 * A number, or a string containing a number.
 * @typedef {(number|string)} NumberLike
 */

/**
 * Set the magic number.
 * @param {NumberLike} x - The magic number.
 */
function setMagicNumber(x) {
}

Hover over setMagicNumber

Expected:
Tooltip should display "Set the magic number."
Actual:
Tooltip displays "A number, or a string containing a number. Set the magic number."

Reproduces without extensions: Yes
Copied from original issue: Microsoft/vscode#37059

This is a duplicate of #15106
Could we perhaps disable this behavior for @typedef comments?

as i said before, it is not going to be a simple change.

authors: mhegazy mjbvz


text:
Enum lookip

TypeScript Version:  2.5.3
It could be I stumbled on something I simply don't understand, but it seems like it this should work:
Code
enum Color {
  RED = "RED",
  BLUE = "BLUE",
  GREEN = "GREEN"
}

type ColorMap = {
  [P in Color]: number;
}

declare const color: Color;
map[color] // Error: Element implicitly has an 'any' type because type 'ColorMap' has no index signature.

All of the following work:
declare const map: ColorMap;
map[Color.RED] // OK

const red: Color = Color.RED;
map[red] // OK

declare const color: keyof typeof Color;
map[color] // OK -- I don't know why this works

Expected behavior:
map[color] to work and give return type of number
Actual behavior:
map[color] // Error: Element implicitly has an 'any' type because type 'ColorMap' has no index

More stuff I don't understand:
declare const color: Color.RED | Color.BLUE | Color.GREEN;
map[color] // Error: Element implicitly has an 'any' type because type 'ColorMap' has no index signature.

declare const color: Color.RED | Color.BLUE | "GREEN";
map[color] // OK

I think my confusion lies with how the compiler actually "sees" the enum type... I thought that string enum was equivalent to the old string literal type + namespace workaround:
type Color = "RED" | "BLUE" | "GREEN"
namespace Color { export const RED = "RED"; export const BLUE = "BLUE"; export const GREEN = "GREEN"; }

type ColorMap = {
  [P in Color]: number;
}

declare const map: ColorMap;
map[Color.RED] // OK

const red: Color = Color.RED;
map[red] // OK

declare const color: Color;
map[color] // Ok

I've also found this very counterintuitive. The workaround was more verbose but was expressive and allowed for very convenient consumption.

Duplicate of  #16760. Should be fixed by https://github.com/Microsoft/TypeScript/pull/18029

authors: aaronbeall aluanhaddad mhegazy


text:
Extending class 'extends' to work with expressions

Example
class B extends class C {
    constructor() {
        this.y = 4;
    }
} {
    constructor() {
        this.x = 3;
    }
}

Codegen
Should be able to unpack the class expressions and codegen as we do now.  We can pass the resulting expression as the parameter to the codegen’d constructor function as we do already.
Typecheck
The type of the expression follows the same rules we have for class declarations now. The expressions create constructor functions as before.
In the extends position, e.g. "class A extends B", the extends clause must be an expression, or a Generic NamedTypeReference. If it is an expression, the extends clause uses the type of the expression. This type must have a constructor signature.
This would allow it to be compatible with the current system and be more flexible with arbitrary expressions, as we would treat class name TypeReferences as constructor functions we will get the type of.
Questions

If C is visible outside of the scope, then we need to lift out and make visible.  Else, we can just translate the expression and put it into the call to creating B’s constructor function

Traceur says it’s not in scope outside of B’s expression.  Looks like we may be able to translate the expressions in-place as a call to the constructor function

If we base the typecheck on constructor signature, what about overloaded constructor signatures?

We require all overloads to return the same type

What about generic constructor signatures?

interface I { new<T>() T; }

We would disallow generic constructor signatures.  These can’t arise as the type of a  signature of a class’s constructor, so we’d follow a similar restriction.

What are the scoping rules of class B extends class C { /* can use T here? */ } {  ... }

Needs answer

There is an ambiguity for parsing these as expressions (less than B, greater than, etc etc)

We would need to tweaking the parsing precedence to ensure the correct parse is checked first.

what's the difference with #511 ? Does this issue is only for  class expression ?

Yeah gonna dupe this against #511 since that's the ES6 related work that must be done for this.

authors: RyanCavanaugh danquirk fdecampredon


text:
New Website Logo: CardsApp

Name: CardsApp
Homepage url: http://cardsapp.com
Brand Guidelines/Licensing: Free to use.
Logo: http://cardsapp.com/Images/CardsApp-Free-Logo.png

Added.

authors: jonathandturner mnns


text:
[Master]  Port fix15469

Fix #15469 to master branch (port from #15548)

@yuit Thank you for the fix.
Do you know when the fix is going to be released?

authors: vslinko yuit


text:
Fix 17060 : incorrect emit for dynamic import inside elements of  export class declaration

Fix #17060

Any chance this will be submitted soon?

Ping @rbuckton

authors: jason-krypton yuit


text:
Fix harness getDirectores implementation to not include directory as prefix

Fixes https://github.com/Microsoft/TypeScript/pull/21100#issuecomment-362913096
We already had fourslash tests for getting directories in path completions. But, the harness implementation of getDirectories differed from the original one, as it returned directories with the prefix present.
Now directory completions with paths should for real in addition to in fourslash tests. (See the linked comment for repro instructions.)

I am completely replacing the implementation of getDirectories in https://github.com/Microsoft/TypeScript/pull/20763, so we'll need to coordinate this change.

I went with standardizing returning "foo" instead of "/directory/path/foo" because all getDirectories implementations but the one in harnessLanguageService seemed to be doing that already. So long as your PR also keeps that behavior in all getDirectories implementations I don't think there will be any conflict.

authors: andy-ms rbuckton


text:
change type definition for Object.create

Fixes #8872

thanks. one comment about comment text. otherwise LGTM.

thanks!

Hello @mhegazy - I'm not seeing this definition change in my local version of Visual Studio Code.  Is there a specific way to pull the TypeScript update for this type definition?

If you are using latest VSCode, you should see the definition from TS 2.2: https://github.com/Microsoft/TypeScript/blob/release-2.2/lib/lib.d.ts#L163-L170

That's what I am seeing in my IntelliSense.
Did the create(o: T): T; not make the cut then?

It was changes to avoid breaking changes introduced.

Good day, I tried to find out why generic overload from #8872:
create<T>(o: T): T;

was omitted in PR, but couldn't find any clue. Was it for a reason? Because it will nice to be able to cast a type in such manner and it will not introduce any breaking changes. Quick suggestion:
create<T>(o: T): T;
create<T>(o: T, properties: PropertyDescriptorMap & ThisType<T>): T; // not sure about ThisType though

authors: Oikio benjaminmillhouse mhegazy plantain-00


text:
bugs - root username / cannot reinstall

Debian for Windows at the first run after installation asks for username. It allows enter root username, then after entering password errors will appear. Next run console appears just fine, simple commands like ps or w works, but even apt-get update do not work and shows errors. After Debian uninstall, Windows restart and install Debian again I tried another username, and this appeared:

I suspect that uninstall is not full and some settings/files have not been deleted. So, what should I do, to make a clean install?

Try to uninstall with wslconfig /u debian.

repo: Microsoft/WSL


text:
Update sql-database-import.md

In Azure Portal Destination credentials must be used, not Source.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@tosue : Thanks for your contribution to the Azure documentation! The author, @CarlRabeler, has been notified to review your proposed change.

#sign-off

@tosue thank you

@CarlRabeler you're welcome

authors: CarlRabeler PRmerger msftclas portizencamina tosue

repo: Microsoft/azure-docs


text:
Remove 'Daemons/server-side apps' limitation

This doesn't appear to be a limitation anymore: https://docs.microsoft.com/en-us/azure/active-directory-b2c/active-directory-b2c-devquickstarts-graph-dotnet#register-a-service-application-in-your-tenant.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@dstrockis Please review these proposed changes. Thanks.

@burma-shave thanks for the contribution. You're correct, that article does build a daemon app that calls AAD Graph.  But there are some pieces missing to fully support the OAuth client credentials grant in AAD B2C, so I'd like to leave the limitation on the doc for now.

@jomolnar I think you can close this one out

#please-close

authors: burma-shave dstrockis jomolnar msftclas


text:
Correct Output and Image been Put

@cephalin Request you to review the proposed change.
Thanks!!

@AftabAnsari10662,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@AftabAnsari10662 thank you for contributing. However, we'd like to keep the current images. #please-close

authors: AftabAnsari10662 cephalin msftclas


text:
docs

`` @

Hi @chainoy, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

authors: chainoy msftclas


text:
deployment will not be conducted in the current, active, default subscription using Cloud Shell

Plugin name and version
Maven Plugin for Azure Web Apps 1.5.4
Plugin configuration in your pom.xml

com.microsoft.azure
azure-webapp-maven-plugin
1.5.4

v2

${RESOURCEGROUP_NAME}
${WEBAPP_NAME}
${REGION}
        <!-- Java Runtime Stack for App on Linux-->
        <runtime>
            <os>linux</os>
            <javaVersion>jre8</javaVersion>
            <webContainer>tomcat 8.5</webContainer>
        </runtime>
        <deployment>
            <resources>
                <resource>
                    <directory>${project.basedir}/target</directory>
                    <includes>
                        <include>*.war</include>
                    </includes>
                </resource>
            </resources>
        </deployment>
    </configuration>
</plugin>

Expected behavior
Deploy web app in the current subscription that is set up in az account show.
Actual behavior
Tying to deploy in the subscription at the top of az account list.
Steps to reproduce the problem
follow the Quickstart at:
https://docs.microsoft.com/en-us/azure/app-service/containers/quickstart-java
deployment will not be conducted in the right subscription using Cloud Shell if you have multiple subscriptions.
Workaround
in plugin configuration, add:
<subscriptionId>${SUBSCRIPTIONID}</subscriptionId>

#289

Fixed om #665

repo: Microsoft/azure-maven-plugins


text:
Update BotState to allow it to be used on its own as well as middleware

The full background to this discussion and it's intention can be found in #341.
This PR is intended to make a small amend to how BotState works within the C# SDK to bring it in line with the JS SDK and allow it to be used independently, as well as from within middleware.  This is likely to eventually be superseded by more significant changes to state management, but this change will unblock the ability for middleware to maintain it's own state if required.
This change maintains the existing model for ConversationState and UserState.
Example use....
Middleware constructor
_state = new BotState<MiddlewareState>(new MemoryStorage(),
                $"ConversationState:{typeof(ConversationState<MiddlewareState>).Namespace}.{typeof(ConversationState<MiddlewareState>).Name}",
                (context) => $"conversation/{context.Activity.ChannelId}/{context.Activity.Conversation.Id}/{typeof(ConversationState<MiddlewareState>).Namespace}.{typeof(ConversationState<MiddlewareState>).Name}");

Middleware process request
var currentState = await _state.Read(context);
// do something with your state
await _state.Write(context, currentState);

cc'ing @billba @drub0y due to discussion in existing issue.

I would like to see the keySelector issue we discussed in #341 for ConversationState/UserState<T> fixed in this PR too.
I think using BotState<T> directly is an even more advanced scenario as you're in charge of the entire namespace at that point and saving. What I would expect is that most people want will multiple Ts of ConversationState/UserState<T> maintained for them and don't want to have to figure out how to tie it to those particular scopes themselves or get in the middle of saving (yet).

@drub0y That's a separate feature. Obviously using BotState directly is a lower level thing, but let's make it work, and then we can add more power to [C|U]State.

Ok, I just see those as a bug vs this is literally opening up the API to new uses. If we just want two separate PRs that's fine and I can follow on with that one if you want.

I see this as "align current C# with current JS" and then we can go to "add new feature to both C# and JS".

@billba @drub0y I agree with both of you 👍 @drub0y I am already on with a PR to bring key selector functionality on the back of this change to achieve what you have laid out but also to abstract the complexity when using bot state on its own.
Hopefully we can get this small change in to get alignment and then I'll submit the PR over the weekend as a first attempt and we can amend / tweak / debate the final implementation 😊 sound good?

@billba @drub0y btw. The way I am implementing key selection may be way off but as I was here I thought I'd have a go. No worries if people don't like it and we scrap for something else.

It's only "off" in the sense that your example uses ConversationState<MiddlewareState> when it really should be using a scheme unique to itself to avoid stepping on or being stepped on by ConversationState<T> at any point.

@drub0y agreed. Ill update the example shortly to show this. Also I have a plan for handling this nicely in the follow up PR around keys

@cleemullins any chance we can get this PR merged? At least bringing us in line with the JS Sdk until we have landed on a more permanent solution which is being discussed in parallel. If would unblock me on a couple of bits, especially ahead of next week's back. Cheers.

@cleemullins @drub0y @billba I am going to close this PR so that we can focus on the wider one that @drub0y has raised. It aligns nicely with this one and addresses the concerns I have with the current implementation.

In lieu of the State Management DCR PR (#376) being accepted, I believe this is a P0 to fix. There is no way to have multiple, disparate pieces of conversation state without this fix. Specifically the scenario that is completely broken is that middleware cannot have it's own state object separate from the bot. The API allows you to configure/use multiple instances of ConversationState<T>, but the last instance to write to the store will always "win".

@garypretty Thanks Gary!

authors: billba cleemullins drub0y garypretty

repo: Microsoft/botbuilder-dotnet


text:
New samples

SimplePrompt-bot -> Prompting with Primitives
CardActions-bot -> Postback with buttons
HelpAndCancel-bot -> Bot Framework Cancel/Help at any level sample

@ryanvolum, @cmayomsft @vishwacsena Please take a look and make sure these meet your needs.
Once you confirm, I'll merge them in.

Looks good to me! Thanks!

authors: cleemullins enzocanoo vishwacsena


text:
Automated push from build 41927

Fixes #
https://github.com/Microsoft/botbuilder-tools/issues/673
https://github.com/Microsoft/botbuilder-tools/issues/648
https://github.com/Microsoft/botbuilder-tools/issues/672
https://github.com/Microsoft/botbuilder-tools/issues/676
Proposed Changes

Testing

Pull Request Test Coverage Report for Build 1683

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.113%

Totals

Change from base Build 1661:
0.0%

Covered Lines:
3961

Relevant Lines:
5628

💛  - Coveralls

authors: coveralls tsuwandy

repo: Microsoft/botbuilder-tools


text:
Troll deterrent

Just a Friendly reminder to the green skin vandals. :thinking:

I am not a troll and this is the first thing I read in the source. How can I revert?

:do_not_litter:  :put_litter_in_its_place:  :recycle:

authors: JAremko oliversalzburg

repo: Microsoft/calculator


text:
Add configuration source

Adding a configuration source that allows ASPNet Core to add configuration through a configuration builder.

@JJVertical There appears to be a test failure in your Tests

authors: JJVertical conniey

repo: Microsoft/dotnet-apiport


text:
.NET 4.6.2 with Windows 8

¿Is there a reason why Windows 8 has been discarded from the Supported Operating System list of .NET 4.6.2? I have installed the update successfully in a Windows 8 Enterprise 64bits.

https://support.microsoft.com/en-us/lifecycle?C2=16796
Because Windows 8 lifecycle has ended, and you are supposed to upgrade to Windows 8.1 or 10.

What about Windows Server 2008?

@fujiy unfortunately, Microsoft decided not to support Windows Server 2008 with .NET Framework 4.6.2, and you have to use Windows Server 2008 R2 and above, as pages like below indicate,
https://www.microsoft.com/en-us/download/details.aspx?id=53344

This is all correct. The support matrix is considered with each new .NET release.

authors: fujiy igarciaolaizola lextm richlander

repo: Microsoft/dotnet


text:
IntelliSense value completion tweaks.

IntelliSense now omits the trailing space when completing values, unless you complete with ' '.
IntelliSense doesn't show if there's only one option and you've fully typed it already.

Reviewed in person with Jeff King.

repo: Microsoft/elfie-arriba


text:
Maybe consider making shorter names for tests

I installed an Ubuntu 16.04 with an encrypted disk and I get the following:
ubuntu@test:~/openenclave/build$ cmake ..
-- The C compiler identification is Clang 7.0.1
-- The CXX compiler identification is Clang 7.0.1
-- The ASM compiler identification is Clang
-- Found assembler: /usr/bin/clang-7
-- Check for working C compiler: /usr/bin/clang-7
-- Check for working C compiler: /usr/bin/clang-7 -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/clang++-7
-- Check for working CXX compiler: /usr/bin/clang++-7 -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Not using CCache
-- Performing Test SPECTRE_MITIGATION_C_FLAGS_SUPPORTED
-- Performing Test SPECTRE_MITIGATION_C_FLAGS_SUPPORTED - Success
-- Performing Test SPECTRE_MITIGATION_CXX_FLAGS_SUPPORTED
-- Performing Test SPECTRE_MITIGATION_CXX_FLAGS_SUPPORTED - Success
-- Spectre 1 mitigations supported
-- Valgrind not found
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
ENABLE_FULL_LIBCXX_TESTS not set - building some libcxx tests
USE_DEBUG_MALLOC is set, building oecore with memory leak detection.
-- Found Doxygen: /usr/bin/doxygen (found version "1.8.11") found components:  doxygen dot
-- Configuring done
CMake Error: Cannot open file for write: /home/ubuntu/openenclave/build/tests/libcxx/enc/CMakeFiles/libcxxtest-std_thread_thread.mutex_thread.mutex.requirements_thread.sharedtimedmutex.requirements_thread.sharedtimedmutex.class_lock_shared.pass_enc.dir/build.make.tmp
CMake Error: : System Error: File name too long
CMake Error: Cannot open file for write: /home/ubuntu/openenclave/build/tests/libcxx/enc/CMakeFiles/libcxxtest-std_thread_thread.mutex_thread.mutex.requirements_thread.sharedtimedmutex.requirements_thread.sharedtimedmutex.class_lock_shared.pass_enc.dir/depend.make.tmp
CMake Error: : System Error: File name too long
CMake Error: Cannot open file for write: /home/ubuntu/openenclave/build/tests/libcxx/enc/CMakeFiles/libcxxtest-std_thread_thread.mutex_thread.mutex.requirements_thread.sharedtimedmutex.requirements_thread.sharedtimedmutex.class_lock_shared.pass_enc.dir/flags.make.tmp
CMake Error: : System Error: File name too long
CMake Error: Cannot open file for write: /home/ubuntu/openenclave/build/tests/libcxx/enc/CMakeFiles/libcxxtest-std_thread_thread.mutex_thread.mutex.requirements_thread.sharedtimedmutex.requirements_thread.sharedtimedmutex.class_lock_shared.pass_enc.dir/link.txt.tmp
CMake Error: : System Error: File name too long
CMake Error: Could not create /home/ubuntu/openenclave/build/tests/libcxx/enc/CMakeFiles/libcxxtest-std_thread_thread.mutex_thread.mutex.requirements_thread.sharedtimedmutex.requirements_thread.sharedtimedmutex.class_lock_shared.pass_enc.dir/cmake_clean.cmake
CMake Error: Cannot open file for write: /home/ubuntu/openenclave/build/tests/libcxx/enc/CMakeFiles/libcxxtest-std_thread_thread.mutex_thread.mutex.requirements_thread.sharedtimedmutex.requirements_thread.sharedtimedmutex.class_lock_shared.pass_enc.dir/DependInfo.cmake.tmp
CMake Error: : System Error: File name too long
-- Generating done
CMake Error: Cannot open file for write: /home/ubuntu/openenclave/build/tests/libcxx/enc/CMakeFiles/libcxxtest-std_thread_thread.mutex_thread.mutex.requirements_thread.sharedtimedmutex.requirements_thread.sharedtimedmutex.class_lock_shared.pass_enc.dir/progress.make.tmp
CMake Error: : System Error: File name too long
-- Build files have been written to: /home/ubuntu/openenclave/build
ubuntu@test:~/openenclave/build$ getconf PATH_MAX .
4096
ubuntu@test:~/openenclave/build$ getconf NAME_MAX .
143
ubuntu@test:~/openenclave/build$ uname -a
Linux test 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
ubuntu@test:~/openenclave/build$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.6 LTS
Release:        16.04
Codename:       xenial
ubuntu@test:~/openenclave/build$

I'm not sure if we should mark this one as a bug or not, but maybe we want to shorten those filenames in the future.
CC: @andschwa , @johnkord

@anakrish Yeah libcxxtest-std_thread_thread.mutex_thread.mutex.requirements_thread.sharedtimedmutex.requirements_thread.sharedtimedmutex.class_lock_shared.pass_enc.dir is 152 characters, greater than the 143 of NAME_MAX with encryption.

The long name is because it has the directory path to the file in it. If the name is shortened, it may be difficult to find the test itself for debug or other purposes. If there are only a few tests longer than 143, that could be removed for the encryption testing (don't have the background on why this is being done).

I ran into the same issue too on Ubuntu18.04 with home folder encrypted using ecryptfs.

authors: anakrish andschwa anitagov aserdean

repo: Microsoft/openenclave


text:
Catreorg

Reorg packages

@pelikhan,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

authors: msftclas pelikhan

repo: Microsoft/pxt-common-packages


text:
Serial Write Buffer throws simulator error

It appears that the serial write buffer block/function doesn't have a dummy shim function to prevent error messages, so the simulator throws an error when you use it in a program, for example:

The actual function works beautifully. I'm building a library of blocks that build on top of write buffer to communicate from the micro:bit via serial with a daughterboard, and so I'm concerned about people thinking there's something wrong with their program when this error message pops up.
This is similar to an issue with one of the Bluetooth functions described  here:((https://github.com/Microsoft/pxt/issues/2493))

For our reference microbit-support:2982

@abchatra @pelikhan Just a nudge to triage this issue.

Nudging this for an update

Nudging this for an update. https://github.com/Microsoft/pxt/issues/3193 was fixed in a couple of days, is this a similar fix?

There is no shadow block for write buffer. You will need to drop something which produces buffer first in the blocks to fill the gap.

This block is rarely used and the fix is not straight forward. It is low priority for us.

I am not actually using the block in my extension, but the underlying javascript function, for example:
cmdBuff = pins.createBuffer(1)
cmdBuff.setNumber(NumberFormat.UInt8LE, 0, 88) // Ascii value of 'X'
serial.writeBuffer(cmdBuff)
I get the same error when writing it in JS as when using the block. That said, I understand if it is a low priority issue - I'm sure not many users are using writeBuffer. Is there a way for a blocks developer to cause the simulator to be inactivated or hidden when loading a blocks package? I am fine if the simulator is non-functional, I just want to have it not throw worrisome errors at the user.

The simulator shim is missing. It was added in master.

@birdbraintech Thanks for explaining the issue. Your program is a valid program. A valid program should always work in the simulator as it works on the board. We will port the fix to V0.
Sorry, I was confused looking at the snapshot, which is an invalid program. Ideally we should never allow that to happen in the blocks but we have various issues in that front.

Have opened in pxt-microbit

authors: abchatra birdbraintech microbit-mark pelikhan

repo: Microsoft/pxt


text:
Remove check for indexes in parser tests

Tests that check errors reported by parser were expecting specific index numbers.
Index numbers differ by OS (based on usage of CRLF/LF, etc) so I removed the check fixing the tests for other platforms. Notice that index numbers remain there unused.
This prepares us for a different commit which would delete ErrorInfo and all those numbers from our tests.
I also added tokenizer tests for different newlines.

I'm not sure if this closes #248 or you had something different in mind when you filed that issue @jakebailey .

No, not particularly. That has more to do with the roundtrips being the same when the code is reprinted with different newline styles.

authors: brianbok jakebailey

repo: Microsoft/python-language-server


text:
GetServiceTypeInfoByName fails to parse response

The following code returns null
var client = ServiceFabricClientFactory.Create(clusterUri, settings);
return await client.ServiceTypes.GetServiceTypeInfoByNameAsync("MyApplication", "1.0.0.0", "MyServiceType");

ServiceTypeDescriptionConverter.GetFromJsonProperties throws JsonReader exception with the following message:

'Incorrect discriminator property name IsStateful, Expected discriminator property name is Kind.'

The JSON returned in the response is the following:
{
  "ServiceTypeDescription": {
    "IsStateful": true,
    "ServiceTypeName": "MyServiceType",
    "PlacementConstraints": "",
    "HasPersistedState": true,
    "Kind": "Stateful",
    "Extensions": [],
    "LoadMetrics": [],
    "ServicePlacementPolicies": []
  },
  "ServiceManifestVersion": "1.0.0.0",
  "ServiceManifestName": "MyServiceTypePkg",
  "IsServiceGroup": false
}

@val-janeiko This is a known issue with Service Fabric REST gateway, the fix will be available in the next versions of the Service Fabric runtime release.

authors: amanbha val-janeiko

repo: Microsoft/service-fabric-client-dotnet


text:
Version v0.4.10 is not ready for galleryProperties.markdownItParser

Trying to set markdownitParser for my extension.
Using tfx-cli to create new package, and I hit an error. Removing markdownItParser it is OK.
tfx extension create --rev-version --manifest-globs
TFS Cross Platform Command Line Interface v0.4.10
Copyright Microsoft Corporation
error: Error parsing the JSON in C:\dev\vss-extension.js
on:
error: SyntaxError: Unexpected token   in JSON at position 369
In vss-extension I added:
"galleryProperties": [
{
"markdownItParser": "true"
}
],
Documentation said v0.4.10 would support it:
"Update your extension VSIX using TFX CLI or from the manageÂ page. For TFX CLI, request you to update to the latest version 0.4.10."

Hi @joalmeid - are you still hitting this error? I cannot reproduce it. If so, can you share your full vss-extension.json file to trgau@microsoft.com? Thanks.

authors: joalmeid trevorsg

repo: Microsoft/tfs-cli


text:
fix boost-lockfree missing dependency

spsc_queue.hpp is including next_prior.hpp, which is contained in boost-iterator
package. however, boost-iterator is not listed as a dependency of boost-lockfree

Thanks for the PR!

repo: Microsoft/vcpkg


text:
vcpkg_build_cmake

Add -j with core count to make the build parallel

Isn't ninja compiling in parallel by default?

Isn't ninja compiling in parallel by default?

good question
I didnt get any clear answer regarding it, so...

I definitely know it does so by default, but I've never verified that it is actually happening during a vcpkg library installation.

I definitely know it does so by default, but I've never verified that it is actually happening during a vcpkg library installation.

If you are sure I guess this PR should be rejected.

From the Ninja manual:

Builds are always run in parallel, based by default on the number of CPUs your system has.

authors: MikeGitb kreuzerkrieg vicroms


text:
Allow attach for all Cosmos Account types

I basically made the 'Attach mongo server' command generic. I also added 'Copy Connection String' to the non-mongo accounts.
I kept this feature in mind when I refactored for the shared tree provider, so it wasn't a ton of extra work.
Fixes #227

Related to #188

ping @StephenWeatherford and @PrashanthCorp now that 0.2.2 is behind us

ping @StephenWeatherford

repo: Microsoft/vscode-cosmosdb


text:
Drop support for Python 3.4

Python drops officially supporting Python 3.4 in March 2019. Remove Python 3.4 scripts from our CI and any reference to that version in our docs/code, if there are any.
See build/ci/vscode-python-nightly-ci.yaml and any templates it calls into to be certain it is removed.

FYI, Python 3.4 is EOL now, so we should definitely work on dropping support. :)

CI no longer builds 3.4 at all, as of today (March 19th). Leaving this open in case there is anything specific to the extension that relies on 3.4 (requirements.txt files, etc...)

Files to update:

README.md
build/test-requirements.txt
src\test\unittests\unittest\unittest.test.ts

authors: brettcannon d3r3kk ericsnowcurrently

repo: Microsoft/vscode-python


text:
Do not merge - Improvements to webpack and tracking of datascience ui dependencies

For #3122

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[x] Has a news entry file (remember to thank yourself!)
[no] Unit tests & system/integration tests are added/updated
[no] Test plan is updated as appropriate
[x] package-lock.json has been regenerated by running npm install (if dependencies have changed)

Will fix CI (should be minor, cuz it works on Travis)

Looks good to me 👍 Thanks.

authors: DonJayamanne rchiodo


text:
comment with ctrl + / in HTML

VSCode Version: 1.4.0
OS Version: Windows 10

when i press ctrl+/ in html syntax, it show comment symbol like this // not this
what i'm saying is when i press ctrl+/ in html syntax it should write this  because it's the proper comment for html syntax
Thanks, and i apologize for my bad english :)

I just tried Ctrl+/ in an HTML file, and I got proper <!-- --> comments. (VS Code 1.4.0 on Linux). Which language mode is your editor in when you edit the HTML file? (It shows up on the far right-hand edge of the status bar, just next to the "smiley face" icon). If it doesn't say HTML, try clicking on it and selecting a different language mode -- maybe you've gotten .html files configured to open in a different language mode, like PHP or something.

oh i'm sorry my mistake... i mean HTML syntax in .php file

duplicate of #11081

authors: aeschli baadillahnabil rmunn

repo: Microsoft/vscode


text:
Stylesheet color preview display issue

VSCode Version: 1.5.0-insider
OS Version: Win 10 build 1607

Color preview used to be in line with code but now it shows up like this

@aeschli starting with you and setting to August since it looks like a regression.

duplicate of #11296

authors: aeschli dbaeumer itsakt


text:
Allow multiple build tasks depending on file type

I'm working with a lot of projects that have different build tasks for different file types, for example I javac for Java, pdflatex for Latex, others may have lessc for their styles and babel for their JS.
Currently, you can only define one build task to be run when Ctrl+Shift+B is pressed. tasks.json allows us to nicely define tasks to run with the currently opened file, but (eg compile the currently open java / Latex / Less / ES6 file), but you can only assign one of these tasks the shortcut that comes with isBuildCommand.
It would be nice if instead of just "isBuildCommand": true we could also define "isBuildCommand": "java" and for another task "isBuildCommand": "latex" so VS Code automatically runs the desired task when pressing Ctrl+Shift+B depending on what type of file is currently open.
This should also work with "isTestCommand"

I also have tasks like build-admin, build-main, build-server. It would be nice if Ctrl+Shift+F5 would trigger the right build task based on a glob that is matched on the currently opened file (could set the folder in there).

Couple of things have improved here with task 2.0.0:

you can have dependsOn to trigger n tasks
you can bind a key binding to any task

I will close this issue. Please open a new one if the provided features doesn't satisfies your needs.

authors: dbaeumer felixfbecker


text:
Breakpoint madness in wrapped line

Had to revert the fix due to #20688
I checked the editor API and my use case is not supported - namely to have a decoration that spans the whole line (which can be wrapped in multiple lines) but that the glyph margin is only decorated on the first line.
@rebornix @alexandrudima would it be possible to add an option in the decoration API to only show the glyph margin on the first view line even if the line spans multiple view lines?

This is Sparta?

Friendly ping @alexandrudima would it be possible to add an option in the decoration API to only show the glyph margin on the first view line even if the line spans multiple view lines?

Similar: https://github.com/Microsoft/vscode/issues/37249

@isidorn I've seen breakpoints are created on the whole line today (from column 1 to infinity).
I wonder if breakpoints don't belong "on the first non-whitespace character of a line" as a closer approximation to the concept of a statement than the entire line.

@joaomoreno I thought you never write code that goes over 80 chars, how could you have hit this :)

I never hit it, cause all my code lines are under 80 characters! 🥇

@alexandrudima thanks for the suggestoin, after some refactoring this actually seems to be working fine.
As you suggested I changed that the breakpoint is set on the first non whitespace character of the line. I do not treat specially the case when the line gets deleted, but I just update the decoration range as the editor tells me. Luckily I already have a de-duping mechanism in my model that takes care of the case when the whole file gets deleted and all the breakpoints get set to the first line and column

@alexandrudima You either crafter the most powerful GitHub issue search query to find that one or you were saving it for REVENGE.

authors: alexandrudima isidorn joaomoreno


text:
[Feature] Multiple Editor Window Support

VSCode Version: 1.9.1
OS Version: 10.0.15031.0

I would love to see the ability to have multiple editor windows open to support workstations with multiple monitors. I see this working similar to Visual Studio or Chrome, where pulling a tab out of the main window and to the desktop creates a new (editor-only) window, which can then itself have multiple tabs and be redocked in the main window by dragging it back.

#2686

authors: DWSR joaomoreno


text:
Allow arguments for status bar item commands

It should be possible to execute complex commands with the StatusBarItem. At the moment it is not possible to provide arguments for the command. Please adjust the interface like the recent change in v1.10 in the task key bindings:
{
    "key": "ctrl+h",
    "command": "workbench.action.tasks.runTask",
    "args": "tsc"
}

Thanks

@AnWeber it's actually already possible, not obviously easy how to do it though. My Commands extension has this capability.
Btw I think also context menus entries and pretty much everything that is currently able to trigger a command should define an arguments property for easily implementing this.

I agree. It would be a lot easier if it were like a TreeItem which takes a Command (an identifier and array of arguments) instead of a simple string.

Loosly inspired by @fabiospampinato this is my workaround:
import { commands, Disposable } from "vscode";

let curId = 0;
const commandId = (id: number) => `anonymous-command.${id}`;

export function getAnonymousCommand(
	func: () => void
): { command: string; disposable: Disposable } {
	const id = curId++;
	const parametrizedCommand = commandId(id);
	const d = commands.registerCommand(parametrizedCommand, () => {
		func();
	});

	return {
		command: parametrizedCommand,
		disposable: d,
	};
}

export function getParametrizedCommand(
	command: string,
	args: unknown[]
): { command: string; disposable: Disposable } {
	return getAnonymousCommand(() => {
		commands.executeCommand(command, ...args);
	});
}

authors: AnWeber fabiospampinato hediet mattacosta


text:
[JavaScript] Functions calls should be scoped

A lot of themes want to color function calls in JavaScript. Here are some examples:
console.log(); // log should be highlighted
foo();         // foo should be highlighted
foo.bar();     // bar should be highlighted

Not sure the best scope for these, perhaps entity.function.name?
Created from https://github.com/Microsoft/vscode/issues/2684

This issue was moved to Microsoft/TypeScript-TmLanguage#72

authors: Tyriar aeschli


text:
VSCode hangs with 100% CPU in Code Helper process when viewing specific file

VSCode Version: Code 1.13.1 (379d2efb5539b09112c793d3d9a413017d736f89, 2017-06-14T18:13:05.928Z)
OS Version: Darwin x64 16.6.0
Extensions:

Extension
Author
Version

vscode-markdownlint
DavidAnson
0.9.1

vscode-docker
PeterJausovec
0.0.16

sort-lines
Tyriar
1.3.0

githistory
donjayamanne
0.2.0

python
donjayamanne
0.6.5

cpptools
ms-vscode
0.11.4

csharp
ms-vscode
1.10.0

mono-debug
ms-vscode
0.15.6

Ruby
rebornix
0.12.1

Steps to Reproduce:

mkdir vscodehang && cd vscodehang
wget https://raw.githubusercontent.com/mono/mono/c7b19b52fd671233cf2daab451f09c7591c859b1/mcs/class/Mono.Security/Mono.Xml/MiniParser.cs
code .
Open MiniParser.cs
VSCode gets unresponsive and offers to reopen window

Can reproduce this in latest insider, even when only pasting the file contents from https://raw.githubusercontent.com/mono/mono/c7b19b52fd671233cf2daab451f09c7591c859b1/mcs/class/Mono.Security/Mono.Xml/MiniParser.cs

I can also repro, vscode crashes, might be a text mate grammer going inffinite

Reproduced with
private static readonly ushort[] tbl = {
		(ushort)(((ushort)CharKind.LEFT_BR << 12) | ((ushort)ActionCode.STATE_CHANGE << 8) | 1),

and adding additional
(ushort)(((ushort)CharKind.LEFT_BR << 12) | ((ushort)ActionCode.STATE_CHANGE << 8) | 1),

array items brings TextMate to a standstill.

This issue was moved to dotnet/csharp-tmLanguage#76

authors: aeschli akoeplinger isidorn jens1o


text:
Use ignore files option combined with files to include set seems to be broken in 1.14 (works fine in 1.13.1)

VSCode Version:
1.14.0 final and
Code - Insiders 1.15.0-insider (74f5073c54f1139d2fb0eccb251cae5ed6e8215b, 2017-07-12T05:07:15.561Z)
OS Version: Darwin x64 16.6.0

Steps to Reproduce:

Open project with some .gitignored files
Search with Use ignore files option enabled and files to include set to some subfolder (like ./back that belongs to the project root).
1.13.1 does not include ignored files within ./back, 1.14.0 final and 1.15.0-insiders do include
If files to include is empty - everything work as expected.

Reproduces without extensions: Yes

This will be fixed as part of https://github.com/Microsoft/vscode/issues/27226#issuecomment-313827054

authors: kompot roblourens


text:
FileSystemProvide API should declare enums starting with 1

The type in question is:
	export enum FileType {
		File = 0,
		Dir = 1,
		Symlink = 2
	}

Having 0 as a value only causes problems with default interpretation and the absence of properties. I only use 0 if this is equal to the property no being there.

Yeah, makes sense

It also needs documentation :) -- I wasn't sure whether it was describing bit flags or discrete options until vscode gave me errors for describing a file as a Symlink but not allowing readdir.

Started on this... @siegebell Do you have a preference? I have some changes in joh/fs-next that allow for a bit mask but maybe discrete options are better, e.g
export enum FileType {
  File = 1,
  Dir = 2,
  Symlink = 64
}
export interface FileStat {
  mtime: number;
  size: number;
  type: FileType;
}

or
  File = 1,
  Dir = 2,
}
export interface FileStat {
  mtime: number;
  size: number;
  type: FileType;
  isSymlink: boolean;
}

authors: dbaeumer jrieken siegebell


text:
QuickOpen / Go To File keyboard shortcut behavior changed with 1.17

I just upgraded to 1.17 (an then 1.17.1 shortly after) on Windows 7. The first odd thing I noticed is my CTRL+P shortcut for quickly opening a file doesn't work anymore.
Instead at the bottom in the status bar I see:
(Ctrl + P) was pressed. Waiting for a second key or chord...
Okay, that's strange. I didn't change anything. I just restarted VSCode after the upgrades and now it's doing this.
Next I looked in the "Go" menu and see:

Okay so that is normal. Next looking in shortcuts:

Okay so is QuickOpen the same thing as Go To File in the menu? Because CTRL+P is definitely not doing that anymore even though the setting appears correct. CTRL+E does work though as QuickOpen. I don't remember ever setting CTRL+E to be QuickOpen. I'm not sure if that was always there as a default option or not.
I upgraded to 1.17 on my MacBook and this bug did not present itself. Everything seemed normal there.

Just search in your keybinding for Ctrl + P
There is probably some extension which is stealing your keybinding.
Try disabling all your extensions and you will not be able to reproduce. You can also try with vscode inisders https://code.visualstudio.com/insiders/

The only thing I see in my keybindings.json for ctrl+p is workbench.action.quickOpen and -workbench.action.quickOpen. I see the same thing for ctrl+e.
I went ahead and just removed the ctrl+e entries and everything appeared to go back to normal. Not sure what happened exactly but I guess you can close this unless you want me to investigate more.

authors: Jakobud isidorn


text:
Program stopped after 3seconds launcher

VSCode Version: Code 1.17.1 (1e9d36539b0ae51ac09b9d4673ebea4e447e5353, 2017-10-10T14:21:18.489Z)
OS Version: Linux x64 4.9.0-4-amd64
Extensions:

Extension
Author (truncated)
Version

latex-workshop
Jam
3.5.5

html-css-class-completion
Zig
1.10.2

html-snippets
abu
0.1.0

markdown-latex-renderer
agu
0.0.2

latex-preview
ajs
0.5.1

vscode-twig-pack
baj
1.0.0

npm-intellisense
chr
1.3.0

path-intellisense
chr
1.4.2

vscode-eslint
dba
1.3.2

githistory
don
0.2.3

vscode-babel-coloring
dza
0.0.4

vscode-html-css
ecm
0.1.8

tslint
eg2
1.0.11

vue-snippets-js-html-pug-razor
heb
0.0.3

vscode-auto-open-markdown-preview
hnw
0.0.4

vue-snippets
hol
0.1.5

webpack
jer
2.0.2

latexcompile
mat
0.7.1

vetur
oct
0.9.11

laravel-blade
one
1.9.0

vscode-icons
rob
7.15.0

sass-indented
rob
1.4.4

code-spell-checker
str
1.4.10

bootstrap4-vscode
the
2.4.0

latex-support
tor
1.0.1

bootstrap-3-snippets
wcw
0.1.0

JavaScriptSnippets
xab
1.5.0

Steps to Reproduce:

Reproduces without extensions: Yes/No

@jeffitoro can you reproduce this when you disable all extensions by starting code as follows  ``code --disable-extensions`

@jeffitoro you have the https://marketplace.visualstudio.com/items?itemName=Zignd.html-css-class-completion installed and it had some scalability issue. This has been addressed in 1.11 of the extension. Can you still reproduce the issue when you use this version of the extension?

Please reopen the issue if this problem has not been addressed by the extension improvement.

authors: egamma jeffitoro


text:
[jade] Syntax highlighting in attribute values not correct

VS Code version:
0.10.8
Code:
block content
  div(style='width:30vw')
    h1= title
    p= location
    p This is a paragraph
    img(src= image)

Description:
The image-variable isn't highlighted corrctly.In fact all attribute-value-variables inside a html element, not only for the img-Tag are not highlighted correctly. This happens with all Themes and also with disabled extensions.
image should be white instead of grey.
Image:

For comparison the same Syntax highlighted in another Editor (Sublime):

It's being styled with the default styles:
.monaco-editor.vs-dark .token.meta.tag {
    color: gray;
}

This is a good example of the need for https://github.com/Microsoft/vscode/issues/2564, closing in favor of that.


text:
Opened text document events are indistinguishable in their emitter

I'm building an extension that relies heavily on onDidOpenTextDocument events. In it, I'm listening for file resources, but I'm unable to distinguish whether the document was opened by user for viewing/editing or by vscode on symbol hover.
Myself, I cannot classify the behaviour as buggy, but I'd like to steer the conversation in two directions. One being a possible API proposal, and the other how should one go about it now under current implementation.
Environment:

Extension: https://github.com/felicio/vscode-fold/blob/1f2d0f02f558b241e8f8797c06b6c168c9913d49/extension.js#L47
VSCode Version: Code 1.18.0 (dcee2202709a4f223185514b9275aa4229841aa7, 2017-11-08T12:32:39.870Z)
OS Version: Darwin x64 17.2.0

We actually don't know that. Why do you need to know?

FOA, thank you for swift answer. What the extension here does is it folds opened document to a default fold.level. Unfortunately, it does that even when user just tries to use Go to Symbol feature (on ⌘+Mouse hover).
I inspected the behaviour depicted in issue's description here. In it I cannot count on window.activeTextEditor.document being equal to just opened document since the value still results to a previous document, if any.
Interestingly enough, that's not the case for a workspace folder under source control. Since the onDidOpenTextDocument event is called twice for the same resource. Once with file and then git scheme. What more, in later case window.activeTextEditor.document is already set and the extension can make the decision to fold the document. That's why what's published in Marketplace kind of works.

What the extension here does is it folds opened document to a default fold.level.

Folding is a UI thing, opening a text document not in all cases because you can open a text document (in the fs.open-sense) without showing it to the user. I believe you should use onDidChangeVisibleTextEditors and/or onDidChangeActiveTextEditor

What a clear explanation! Please, give me some time today so I can test all the edge cases.

Thanks to your insight I was able to get it all under control and operate on the right level. The onDidChangeVisibleTextEditors event is what I ended up listening to.
If I may have a follow up question, do you know about any limitations in current architecture that'd totally prevent first display of document with blocks pre-folded from realizing in the (near) future?

totally prevent first display of document with blocks pre-folded from realizing in the (near) future?

@aeschli would know that
Closing this issue as question

authors: felicio jrieken


text:
Search in Workspace

VSCode Version: 1.18.1
OS Version: Windows 10

can i search in workspace? like visual Studio 2017
i just want press one key and search to file.
like - > https://i.hizliresim.com/Qp0z4r.gif
(sorry my bad english)

With Command + P on the Mac you can start typing a filename and open when found, so it's probably CTRL+P on Windows.

I think the gif shows typing to search in a tree view, I've missed that as well.

authors: mcuneyda roblourens tverboon


text:
every upgrade destroys my settings

VSCode Version: Code 1.18.1 (929bacba01ef658b873545e26034d1a8067445e9, 2017-11-16T18:32:36.026Z)
OS Version: Windows_NT ia32 10.0.16299
Extensions:

Extension
Author (truncated)
Version

Ionide-fsharp
Ion
3.14.2

MagicPython
mag
1.0.12

vscode-azurefunctions
ms-
0.2.0

python
ms-
0.8.0

vscode-ai
ms-
0.1.4

azure-account
ms-
0.2.2

csharp
ms-
1.13.1

azure-hdinsight
msh
0.0.9

vscode-docker
Pet
0.0.22

python
tht
0.2.3

usql-vscode-ext
usq
0.2.7

Steps to Reproduce:
1.add configuration setting for CNTK to settings.json and launch.json for a python project. work cleanly
2.do any upgrade to VS code  lose all settings that worked for CNTK and have to redefine it each and every time. it is driving me insane

Reproduces without extensions: Yes/No

@jimwill3 Couple of questions

What are CNTK settings?
Do you loose all settings or just settings from an extension?


text:
Dropdown: Missing click events between elements

Testing #40589
Seen on Linux.
There's an area between items where no click is registered:

@joaomoreno
@bpasero
back online, just capturing these assignments.
Shall I address this within the scrollbar myself?

@cleidigh Yeah, I wanted to only mention that I observed it in Linux.
I've extracted the scrollable element bug into https://github.com/Microsoft/vscode/issues/42801, I'll take that one.
I also changed the title to only address the clicking between elements.

@cleidigh, if no one is working on this I'd like to take a try at it.
I am not able to reproduce on the latest version of code February 2018, 1.21 on Windows, will test on Linux tonight and report if this is resolved or not.
Mouse was positioned right at the edge of the selected item, where a scrollbar would be.

Sorry for the delay, can confirm once 1.21 was updated on Fedora 27 that I was unable to reproduce this issue. Can we close this if it's no longer a bug? @cleidigh any other verification required?

@raygervais
apologies for my delay !  I cannot directly test Linux especially with the mouse issues so we have to verify with @joaomoreno  ... do you still see this?

@cleidigh Yeah I can still reproduce it.

@raygervais
I'm in the middle of a couple other bugs with the drop-down so if you want to start a must that be great.
From @joaomoreno note above:  This started as two issues, the problem with the scrollbar area or just the right of it has been addressed.  The remaining issue is the problem between elements.  Also the problem has to be reproduced on Windows or OS X to understand if it is or is not platform specific.

I'll look into this today @cleidigh , @joaomoreno. I must have missed the issue itself while testing. Will be sure not to do so going forward. Will work on Windows and Linux while testing. Thanks for the direction! 👨💻

@raygervais
GoodThatYouCanReproduceItOnWindows.
I agree that there's probably a border or outline or padding that must somehow not be clickable.  My confusion on this is that most parts are fully managed by the list component.
there's only so many things that we can do with the CSS that I think would be related, just not sure.

authors: cleidigh joaomoreno raygervais


text:
VS Code 1.20.0 wont launch on macOS Sierra 10.12.6

VSCode Version: 1.20.0
OS Version: macOS Sierra 10.12.6

Steps to Reproduce:

Download the .app file
Double click it

VS Code wont launch. The icon appears in the dock, but vanishes shortly after.

Can you follow this guide and post the crash log?
https://github.com/Microsoft/vscode/wiki/Native-Crash-Issues#macos

Also, try running code --disable-gpu.

I don't see a crash log entry for code following that guide. Running code --disable-gpu is also not working, what is not surprising since i'm using a Mac mini (Late 2012) with no dedicated gpu.
Running Visual\ Studio\ Code.app/Contents/Resources/app/bin/code --verbose I get:
[main 10:48:52] Error: listen ENOTSUP /Network/Servers/intranet.company/Volumes/Macintosh HD2/NetUsers/jhony1104/Library/Application Support/Code/1.20.0-main.sock
    at Object.exports._errnoException (util.js:1050:11)
    at exports._exceptionWithHostPort (util.js:1073:20)
    at Server.setupListenHandle [as _listen2] (net.js:1247:19)
    at listenInCluster (net.js:1304:12)
    at Server.listen (net.js:1413:5)
    at /Network/Servers/intranet.company/Volumes/Macintosh HD2/NetUsers/jhony1104/Downloads/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:154:456
    at new n.Class.derive._oncancel (/Network/Servers/intranet.company/Volumes/Macintosh HD2/NetUsers/jhony1104/Downloads/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:81:234)
    at Object.t.serve (/Network/Servers/intranet.company/Volumes/Macintosh HD2/NetUsers/jhony1104/Downloads/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:154:386)
    at n (/Network/Servers/intranet.company/Volumes/Macintosh HD2/NetUsers/jhony1104/Downloads/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:443:882)
    at J (/Network/Servers/intranet.company/Volumes/Macintosh HD2/NetUsers/jhony1104/Downloads/Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js:446:235)

Moving to @joaomoreno since this seems to ail setting up a socket.

You seem to be running off a network share /Network/Servers...
Try using --user-data-dir LOCAL_PATH.

With --user-data-dir LOCAL_PATH code works.
Is there any way to use this solution when starting from the dock?

There isn't unfortunately. You're going to have to write a shortcut in order to do that.

authors: bpasero jhony1104 joaomoreno octref


text:
Scroll @ explorer panel

Issue Type
Performance Issue
Description
Scrolling lags drastically(no smooth scroll) except  when scroll bar is used to move from top and bottom vice versa.
VS Code Info
VS Code version: Code 1.20.1 (f88bbf9137d24d36d968ea6b2911786bfe103002, 2018-02-13T15:34:36.336Z)
OS version: Windows_NT x64 10.0.10240

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz (4 x 2904)

Memory (System)
7.87GB (4.12GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

debugger-for-chrome
msj
4.1.0

Reproduces only with extensions

/duplicate #13612

authors: bpasero kkbs


text:
FileSystemProvider: FileOptions is a bit weird to support/understand

Refs: https://github.com/Microsoft/vscode/issues/48421
Today vscode.FileOptions is this:
export interface FileOptions {

	/**
	 * Create a file when it doesn't exists
	 */
	create?: boolean;

	/**
	 * In combination with [`create`](FileOptions.create) but
	 * the operation should fail when a file already exists.
	 */
	exclusive?: boolean;

	/**
	 * Open a file for reading.
	 */
	read?: boolean;

	/**
	 * Open a file for writing.
	 */
	write?: boolean;
}

And it is being used in:

readFile
writeFile
rename
copy

create vs exclusive
not clear what the relation between create and exclusive is, can it be both or either one? maybe this should be reflected in some enum so it is clear it can only be one value?
read vs write
what is the use case for this option? should I handle the case in writeFile if options.write is not configured? today in my implementation I totally ignore this.

Yeah, it's a bit of a kitchen sink...

what is the use case for this option? should I handle the case in writeFile if options.write is not configured? today in my implementation I totally ignore this.

It leaks a little the plan of having fopen/fclose but technically you can combine things, e.g. create a file when trying to read it, like the w+-flag
Similar exclusive is the x flag which causes failure when combined with + and when the file already exists.

@jrieken ah ok I was not directly making the connection to the fs file modes, maybe an example in the docs would have helped or different names.

authors: bpasero jrieken