text:
chore: upgraded flutter_map to 6.0.1

What

Upgraded flutter_map to 6.0.1
Domino effect regarding other packages needing to be upgraded too.

Part of

#4755

Impacted files

add_new_product_page.dart: matomo upgrade
analytics_helper.dart: matomo upgrade
camera_scan_page.dart: matomo upgrade
forgot_password_page.dart: matomo upgrade
knowledge_panel_page.dart: matomo upgrade
knowledge_panel_world_map_card.dart: flutter_map upgrade
login_page.dart: matomo upgrade
main.dart: matomo upgrade
new_product_page.dart: matomo upgrade
personalized_ranking_page.dart: matomo upgrade
product_list_page.dart: matomo upgrade
product_query_page.dart: matomo upgrade
pubspec.lock: wtf
pubspec.yaml: upgraded flutter_map to 6.0.1 (+ domino effect)
question_page.dart: matomo upgrade
sign_up_page.dart: matomo upgrade
user_preferences_page.dart: matomo upgrade

Codecov Report

Merging #4757 (8d4cdc0) into develop (b3f73c0) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #4757      +/-   ##
==========================================
- Coverage     9.83%   9.82%   -0.02%
==========================================
  Files          313     313
  Lines        15905   15895      -10
==========================================
- Hits          1565    1561       -4
+ Misses       14340   14334       -6

Files
Coverage Δ

...e_panel/knowledge_panels/knowledge_panel_page.dart
0.00% <ø> (ø)

...ooth_app/lib/pages/hunger_games/question_page.dart
2.29% <ø> (+0.01%)
:arrow_up:

...mooth_app/lib/pages/personalized_ranking_page.dart
0.00% <ø> (ø)

...p/lib/pages/preferences/user_preferences_page.dart
95.71% <ø> (-0.07%)
:arrow_down:

...th_app/lib/pages/product/add_new_product_page.dart
0.00% <ø> (ø)

...pp/lib/pages/product/common/product_list_page.dart
0.00% <ø> (ø)

...p/lib/pages/product/common/product_query_page.dart
0.00% <ø> (ø)

...smooth_app/lib/pages/product/new_product_page.dart
0.00% <ø> (ø)

...ib/pages/user_management/forgot_password_page.dart
61.72% <ø> (-0.47%)
:arrow_down:

...ooth_app/lib/pages/user_management/login_page.dart
48.52% <ø> (-0.31%)
:arrow_down:

... and 5 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

The previous migration for Matamo was a disaster, as there were no event sent.
Have you checked they are still sent?

The previous migration for Matamo was a disaster, as there were no event sent. Have you checked they are still sent?

No I haven't, and I wouldn't even know how to do it.
The thing is that the flutter_map upgrade needs a new version of http, which impacts other packages, including matomo. So, either matomo behaves this time, or we're stuck forever with old versions for many packages. While still receiving bump emails.

Ok, let me run your PR.
I will check that for you.

Thank you very much @g123k for your review and your tests!

authors: codecov-commenter g123k monsieurtanuki


text:
[Up for Adoption]  [WIP] Fastlane automatic releases

This PR aims at automating the internal release of Smoothie to the PlayStore and the App Store. It is building on work by Philippe

At the moment, it's a copy paste of both our pipelines for iOS and Android. It's not adapted to Flutter, but we did the work of putting the secrets in safe places.
The flutter team explains how to do it for Flutter at https://flutter.dev/docs/deployment/cd

TODO (incomplete list)

[ ] Finish morphing the 2 series of pipelines to a single pipeline
[ ] Change the Android key (there's a specific key for smoothie)
[ ] Generate the appropriate iOS files

@teolemon I wanted to deal with this in the next few days, could you explain to me where you put and how encrypted the secrets, such as the Android keystore and the service account key.
I saw api-[...].json.gpg and .enc are there any differences between them or can I just use the gpg one?

@teolemon I wanted to deal with this in the next few days, could you explain to me where you put and how encrypted the secrets, such as the Android keystore and the service account key.
I saw api-[...].json.gpg and .enc are there any differences between them or can I just use the gpg one?

I did some copy pasting from Android and iOS without fully knowing what I was doing.

[ ] Checking that the package name is the right one
[ ] Committing the key for smoothie to the repo, just like we did for Android: https://github.com/openfoodfacts/openfoodfacts-androidapp/tree/develop/fastlane/envfiles
[ ] Adding all the variables we need as secrets to decypher the keystore

@philippeauriach did the automation for Android, so he might have some more insight

I did some copy pasting from Android and iOS without fully knowing what I was doing.

[ ] Checking that the package name is the right one
[ ] Committing the key for smoothie to the repo, just like we did for Android: https://github.com/openfoodfacts/openfoodfacts-androidapp/tree/develop/fastlane/envfiles
[ ] Adding all the variables we need as secrets to decypher the keystore

@philippeauriach did the automation for Android, so he might have some more insight

Taken over by #96

Taken over by #96

source: gharchive/pull-request

repo: openfoodfacts/smooth-app

license_type: permissive

license_source: github-api


text:
Positions of MonovalentLonePair virtual sites is incorrect (does not affect simulations)

Description
In the Virtual Sites vignette, I noticed that the positions Interchange produces for monovalent lone pair virtual sites is incorrect. It looks like the angle is correctly defined, but distances are calculated from the wrong atom, though I haven't investigated this carefully.
Reproduction
vsites-bug-mwe.zip
Output

Software versions

Which operating system and version are you using? Arch Linux, all packages up to date
How did you install Interchange? Micromamba environment
What is the output of running conda list?

conda list
List of packages in environment: "/home/joshmitchell/Documents/openff/2024_workshops/.soap/test"
Name                           Version          Build                        Channel
────────────────────────────────────────────────────────────────────────────────────────────
_libgcc_mutex                  0.1              conda_forge                  conda-forge
_openmp_mutex                  4.5              2_gnu                        conda-forge
absl-py                        2.1.0            pyhd8ed1ab_0                 conda-forge
aiohttp                        3.9.3            py310h2372a71_0              conda-forge
aiosignal                      1.3.1            pyhd8ed1ab_0                 conda-forge
ambertools                     22.0             py310h206695f_3              conda-forge
annotated-types                0.6.0            pyhd8ed1ab_0                 conda-forge
anyio                          4.3.0            pyhd8ed1ab_0                 conda-forge
argcomplete                    3.2.3            pyhd8ed1ab_0                 conda-forge
argon2-cffi                    23.1.0           pyhd8ed1ab_0                 conda-forge
argon2-cffi-bindings           21.2.0           py310h2372a71_4              conda-forge
arpack                         3.7.0            hdefa2d7_2                   conda-forge
arrow                          1.3.0            pyhd8ed1ab_0                 conda-forge
arrow-cpp                      11.0.0           ha770c72_5_cpu               conda-forge
ase                            3.22.1           pyhd8ed1ab_1                 conda-forge
asttokens                      2.4.1            pyhd8ed1ab_0                 conda-forge
astunparse                     1.6.3            pyhd8ed1ab_0                 conda-forge
async-lru                      2.0.4            pyhd8ed1ab_0                 conda-forge
async-timeout                  4.0.3            pyhd8ed1ab_0                 conda-forge
attrs                          23.2.0           pyh71513ae_0                 conda-forge
aws-c-auth                     0.6.24           h84a1944_5                   conda-forge
aws-c-cal                      0.5.20           hc60faf5_6                   conda-forge
aws-c-common                   0.8.11           h0b41bf4_0                   conda-forge
aws-c-compression              0.2.16           h034cb4b_3                   conda-forge
aws-c-event-stream             0.2.18           h75388cd_6                   conda-forge
aws-c-http                     0.7.4            hf084cc8_2                   conda-forge
aws-c-io                       0.13.17          h10df833_2                   conda-forge
aws-c-mqtt                     0.8.6            hc41645a_6                   conda-forge
aws-c-s3                       0.2.4            h1b8f470_3                   conda-forge
aws-c-sdkutils                 0.1.7            h034cb4b_3                   conda-forge
aws-checksums                  0.1.14           h034cb4b_3                   conda-forge
aws-crt-cpp                    0.19.7           h0073717_7                   conda-forge
aws-sdk-cpp                    1.10.57          h4707e7a_4                   conda-forge
babel                          2.14.0           pyhd8ed1ab_0                 conda-forge
basis_set_exchange             0.9.1            pyhd8ed1ab_0                 conda-forge
beautifulsoup4                 4.12.3           pyha770c72_0                 conda-forge
binutils_impl_linux-64         2.40             hf600244_0                   conda-forge
binutils_linux-64              2.40             hbdbef99_2                   conda-forge
biopython                      1.83             py310h2372a71_0              conda-forge
black                          24.2.0           py310hff52083_0              conda-forge
bleach                         6.1.0            pyhd8ed1ab_0                 conda-forge
blinker                        1.7.0            pyhd8ed1ab_0                 conda-forge
blosc                          1.21.5           h0f2a231_0                   conda-forge
boost                          1.74.0           py310h7c3ba0c_5              conda-forge
boost-cpp                      1.74.0           h75c5d50_8                   conda-forge
brotli                         1.0.9            h166bdaf_9                   conda-forge
brotli-bin                     1.0.9            h166bdaf_9                   conda-forge
brotli-python                  1.0.9            py310hd8f1fbe_9              conda-forge
bson                           0.5.9            py_0                         conda-forge
bzip2                          1.0.8            hd590300_5                   conda-forge
c-ares                         1.27.0           hd590300_0                   conda-forge
ca-certificates                2024.2.2         hbcca054_0                   conda-forge
cached-property                1.5.2            hd8ed1ab_1                   conda-forge
cached_property                1.5.2            pyha770c72_1                 conda-forge
cachetools                     5.3.3            pyhd8ed1ab_0                 conda-forge
cairo                          1.16.0           ha61ee94_1014                conda-forge
cattrs                         23.2.3           pyhd8ed1ab_0                 conda-forge
certifi                        2024.2.2         pyhd8ed1ab_0                 conda-forge
cffi                           1.16.0           py310h2fee648_0              conda-forge
cftime                         1.6.3            py310h1f7b6fc_0              conda-forge
chardet                        5.2.0            py310hff52083_1              conda-forge
charset-normalizer             3.3.2            pyhd8ed1ab_0                 conda-forge
chemper                        1.0.1            pyhd8ed1ab_0                 conda-forge
click                          8.1.7            unix_pyh707e725_0            conda-forge
click-option-group             0.5.6            pyhd8ed1ab_0                 conda-forge
cloudpickle                    3.0.0            pyhd8ed1ab_0                 conda-forge
cmake                          3.28.3           hcfe8598_0                   conda-forge
colorama                       0.4.6            pyhd8ed1ab_0                 conda-forge
comm                           0.2.1            pyhd8ed1ab_0                 conda-forge
contourpy                      1.2.0            py310hd41b1e2_0              conda-forge
cryptography                   42.0.5           py310h75e40e8_0              conda-forge
cudatoolkit                    11.8.0           h4ba93d1_13                  conda-forge
curl                           8.5.0            hca28451_0                   conda-forge
cycler                         0.12.1           pyhd8ed1ab_0                 conda-forge
cython                         3.0.9            py310hc6cd4ac_0              conda-forge
cytoolz                        0.12.3           py310h2372a71_0              conda-forge
dask-core                      2024.2.1         pyhd8ed1ab_0                 conda-forge
dask-jobqueue                  0.8.5            pyhd8ed1ab_0                 conda-forge
debugpy                        1.8.1            py310hc6cd4ac_0              conda-forge
decorator                      5.1.1            pyhd8ed1ab_0                 conda-forge
defusedxml                     0.7.1            pyhd8ed1ab_0                 conda-forge
dgl                            1.1.2            py310hbc80768_2              conda-forge
distributed                    2024.2.1         pyhd8ed1ab_0                 conda-forge
dockstring                     0.3.2            pyhd8ed1ab_0                 conda-forge
docstring-to-markdown          0.15             pyhd8ed1ab_0                 conda-forge
entrypoints                    0.4              pyhd8ed1ab_0                 conda-forge
exceptiongroup                 1.2.0            pyhd8ed1ab_2                 conda-forge
executing                      2.0.1            pyhd8ed1ab_0                 conda-forge
expat                          2.6.1            h59595ed_0                   conda-forge
f90wrap                        0.2.13           py310h03ae0af_2              conda-forge
fasteners                      0.17.3           pyhd8ed1ab_0                 conda-forge
fftw                           3.3.10           nompi_hc118613_108           conda-forge
filelock                       3.13.1           pyhd8ed1ab_0                 conda-forge
flask                          3.0.2            pyhd8ed1ab_0                 conda-forge
flatbuffers                    22.12.06         hcb278e6_2                   conda-forge
font-ttf-dejavu-sans-mono      2.37             hab24e00_0                   conda-forge
font-ttf-inconsolata           3.000            h77eed37_0                   conda-forge
font-ttf-source-code-pro       2.038            h77eed37_0                   conda-forge
font-ttf-ubuntu                0.83             h77eed37_1                   conda-forge
fontconfig                     2.14.2           h14ed4e7_0                   conda-forge
fonts-conda-ecosystem          1                0                            conda-forge
fonts-conda-forge              1                0                            conda-forge
fonttools                      4.49.0           py310h2372a71_0              conda-forge
fqdn                           1.5.1            pyhd8ed1ab_0                 conda-forge
freetype                       2.12.1           h267a509_2                   conda-forge
freetype-py                    2.3.0            pyhd8ed1ab_0                 conda-forge
frozenlist                     1.4.1            py310h2372a71_0              conda-forge
fsspec                         2024.2.0         pyhca7485f_0                 conda-forge
gast                           0.4.0            pyh9f0ad1d_0                 conda-forge
gawk                           5.3.0            ha916aea_0                   conda-forge
gcc_impl_linux-64              11.4.0           h7aa1c59_5                   conda-forge
gcc_linux-64                   11.4.0           hfd045f2_2                   conda-forge
gettext                        0.21.1           h27087fc_0                   conda-forge
gflags                         2.2.2            he1b5a44_1004                conda-forge
gfortran_impl_linux-64         11.4.0           h86428dc_5                   conda-forge
gfortran_linux-64              11.4.0           h3047280_2                   conda-forge
giflib                         5.2.1            h0b41bf4_3                   conda-forge
gitdb                          4.0.11           pyhd8ed1ab_0                 conda-forge
gitpython                      3.1.42           pyhd8ed1ab_0                 conda-forge
glog                           0.6.0            h6f12383_0                   conda-forge
gmp                            6.3.0            h59595ed_0                   conda-forge
gmpy2                          2.1.2            py310h3ec546c_1              conda-forge
google-auth                    2.28.2           pyhca7485f_0                 conda-forge
google-auth-oauthlib           0.4.6            pyhd8ed1ab_0                 conda-forge
google-pasta                   0.2.0            pyh8c360ce_0                 conda-forge
greenlet                       3.0.3            py310hc6cd4ac_0              conda-forge
griddataformats                1.0.2            pyhd8ed1ab_0                 conda-forge
gromacs                        2023.1           nompi_h76c6bb2_102           conda-forge
grpcio                         1.51.1           py310h4a5735c_1              conda-forge
gsd                            3.2.1            py310h1f7b6fc_0              conda-forge
gsl                            2.7              he838d99_0                   conda-forge
gxx_impl_linux-64              11.4.0           h7aa1c59_5                   conda-forge
gxx_linux-64                   11.4.0           hfc1ae95_2                   conda-forge
h11                            0.14.0           pyhd8ed1ab_0                 conda-forge
h2                             4.1.0            pyhd8ed1ab_0                 conda-forge
h5py                           3.8.0            nompi_py310h0311031_100      conda-forge
hdf4                           4.2.15           h9772cbc_5                   conda-forge
hdf5                           1.12.2           nompi_h4df4325_101           conda-forge
hpack                          4.0.0            pyh9f0ad1d_0                 conda-forge
httpcore                       1.0.4            pyhd8ed1ab_0                 conda-forge
httpx                          0.27.0           pyhd8ed1ab_0                 conda-forge
hyperframe                     6.0.1            pyhd8ed1ab_0                 conda-forge
icu                            70.1             h27087fc_0                   conda-forge
idna                           3.6              pyhd8ed1ab_0                 conda-forge
importlib-metadata             7.0.2            pyha770c72_0                 conda-forge
importlib_metadata             7.0.2            hd8ed1ab_0                   conda-forge
importlib_resources            6.1.3            pyhd8ed1ab_0                 conda-forge
ipykernel                      6.29.3           pyhd33586a_0                 conda-forge
ipython                        8.22.2           pyh707e725_0                 conda-forge
ipywidgets                     8.1.2            pyhd8ed1ab_0                 conda-forge
isoduration                    20.11.0          pyhd8ed1ab_0                 conda-forge
isort                          5.13.2           pyhd8ed1ab_0                 conda-forge
itsdangerous                   2.1.2            pyhd8ed1ab_0                 conda-forge
jax                            0.4.4            pyhd8ed1ab_0                 conda-forge
jaxlib                         0.4.3            cpu_py310hdc47304_1          conda-forge
jedi                           0.19.1           pyhd8ed1ab_0                 conda-forge
jedi-language-server           0.41.3           pyhd8ed1ab_0                 conda-forge
jinja2                         3.1.3            pyhd8ed1ab_0                 conda-forge
joblib                         1.3.2            pyhd8ed1ab_0                 conda-forge
jpeg                           9e               h0b41bf4_3                   conda-forge
json5                          0.9.22           pyhd8ed1ab_0                 conda-forge
jsonpointer                    2.4              py310hff52083_3              conda-forge
jsonschema                     4.21.1           pyhd8ed1ab_0                 conda-forge
jsonschema-specifications      2023.12.1        pyhd8ed1ab_0                 conda-forge
jsonschema-with-format-nongpl  4.21.1           pyhd8ed1ab_0                 conda-forge
jupyter-lsp                    2.2.4            pyhd8ed1ab_0                 conda-forge
jupyter_client                 8.6.0            pyhd8ed1ab_0                 conda-forge
jupyter_core                   5.7.1            py310hff52083_0              conda-forge
jupyter_events                 0.9.0            pyhd8ed1ab_0                 conda-forge
jupyter_server                 2.13.0           pyhd8ed1ab_0                 conda-forge
jupyter_server_terminals       0.5.2            pyhd8ed1ab_0                 conda-forge
jupyterlab                     4.1.4            pyhd8ed1ab_0                 conda-forge
jupyterlab-lsp                 5.1.0            pyhd8ed1ab_1                 conda-forge
jupyterlab_code_formatter      2.2.1            pyhd8ed1ab_0                 conda-forge
jupyterlab_execute_time        3.1.2            pyhd8ed1ab_0                 conda-forge
jupyterlab_pygments            0.3.0            pyhd8ed1ab_1                 conda-forge
jupyterlab_server              2.25.3           pyhd8ed1ab_0                 conda-forge
jupyterlab_widgets             3.0.10           pyhd8ed1ab_0                 conda-forge
keras                          2.11.0           pyhd8ed1ab_0                 conda-forge
keras-preprocessing            1.1.2            pyhd8ed1ab_0                 conda-forge
kernel-headers_linux-64        2.6.32           he073ed8_17                  conda-forge
keyutils                       1.6.1            h166bdaf_0                   conda-forge
kim-api                        2.3.0            h097297d_1                   conda-forge
kiwisolver                     1.4.5            py310hd41b1e2_1              conda-forge
krb5                           1.21.2           h659d440_0                   conda-forge
lammps                         2022.06.23       py310hedc66b7_mpich_5        conda-forge
lcms2                          2.15             hfd0df8a_0                   conda-forge
ld_impl_linux-64               2.40             h41732ed_0                   conda-forge
lerc                           4.0.0            h27087fc_0                   conda-forge
libabseil                      20220623.0       cxx17_h05df665_6             conda-forge
libaec                         1.1.2            h59595ed_1                   conda-forge
libarrow                       11.0.0           h2ebd325_5_cpu               conda-forge
libblas                        3.9.0            21_linux64_openblas          conda-forge
libbrotlicommon                1.0.9            h166bdaf_9                   conda-forge
libbrotlidec                   1.0.9            h166bdaf_9                   conda-forge
libbrotlienc                   1.0.9            h166bdaf_9                   conda-forge
libcblas                       3.9.0            21_linux64_openblas          conda-forge
libcrc32c                      1.1.2            h9c3ff4c_0                   conda-forge
libcurl                        8.5.0            hca28451_0                   conda-forge
libdeflate                     1.17             h0b41bf4_0                   conda-forge
libedit                        3.1.20191231     he28a2e2_2                   conda-forge
libev                          4.33             hd590300_2                   conda-forge
libevent                       2.1.10           h28343ad_4                   conda-forge
libexpat                       2.6.1            h59595ed_0                   conda-forge
libffi                         3.4.2            h7f98852_5                   conda-forge
libgcc-devel_linux-64          11.4.0           h922705a_105                 conda-forge
libgcc-ng                      13.2.0           h807b86a_5                   conda-forge
libgfortran-ng                 13.2.0           h69a702a_5                   conda-forge
libgfortran5                   13.2.0           ha4646dd_5                   conda-forge
libglib                        2.78.4           hf2295e7_4                   conda-forge
libgomp                        13.2.0           h807b86a_5                   conda-forge
libgoogle-cloud                2.7.0            h21dfe5b_1                   conda-forge
libgrpc                        1.51.1           h4fad500_1                   conda-forge
libhwloc                       2.9.1            hd6dc26d_0                   conda-forge
libiconv                       1.17             hd590300_2                   conda-forge
libidn2                        2.3.7            hd590300_0                   conda-forge
liblapack                      3.9.0            21_linux64_openblas          conda-forge
liblapacke                     3.9.0            21_linux64_openblas          conda-forge
libllvm14                      14.0.6           hcd5def8_4                   conda-forge
libnetcdf                      4.8.1            nompi_h261ec11_106           conda-forge
libnghttp2                     1.58.0           h47da74e_1                   conda-forge
libnsl                         2.0.1            hd590300_0                   conda-forge
libopenblas                    0.3.26           pthreads_h413a1c8_0          conda-forge
libpng                         1.6.43           h2797004_0                   conda-forge
libprotobuf                    3.21.12          hfc55251_2                   conda-forge
libsanitizer                   11.4.0           h4dcbe23_5                   conda-forge
libsodium                      1.0.18           h36c2ea0_1                   conda-forge
libsqlite                      3.45.1           h2797004_0                   conda-forge
libssh2                        1.11.0           h0841786_0                   conda-forge
libstdcxx-devel_linux-64       11.4.0           h922705a_105                 conda-forge
libstdcxx-ng                   13.2.0           h7e041cc_5                   conda-forge
libthrift                      0.18.0           h5e4af38_0                   conda-forge
libtiff                        4.5.0            h6adf6a1_2                   conda-forge
libunistring                   0.9.10           h7f98852_0                   conda-forge
libutf8proc                    2.8.0            h166bdaf_0                   conda-forge
libuuid                        2.38.1           h0b41bf4_0                   conda-forge
libuv                          1.48.0           hd590300_0                   conda-forge
libwebp-base                   1.3.2            hd590300_0                   conda-forge
libxcb                         1.13             h7f98852_1004                conda-forge
libxcrypt                      4.4.36           hd590300_1                   conda-forge
libxml2                        2.10.3           hca2bb57_4                   conda-forge
libxslt                        1.1.37           h873f0b0_0                   conda-forge
libzip                         1.10.1           h2629f0a_3                   conda-forge
libzlib                        1.2.13           hd590300_5                   conda-forge
lightning-utilities            0.10.1           pyhd8ed1ab_0                 conda-forge
llvmlite                       0.42.0           py310h1b8f574_1              conda-forge
locket                         1.0.0            pyhd8ed1ab_0                 conda-forge
lsprotocol                     2023.0.1         pyhd8ed1ab_0                 conda-forge
lxml                           4.9.2            py310hbdc0903_0              conda-forge
lz4-c                          1.9.4            hcb278e6_0                   conda-forge
lzo                            2.10             h516909a_1000                conda-forge
make                           4.3              hd18ef5c_1                   conda-forge
markdown                       3.5.2            pyhd8ed1ab_0                 conda-forge
markdown-it-py                 3.0.0            pyhd8ed1ab_0                 conda-forge
markupsafe                     2.1.5            py310h2372a71_0              conda-forge
matplotlib-base                3.8.3            py310h62c0568_0              conda-forge
matplotlib-inline              0.1.6            pyhd8ed1ab_0                 conda-forge
mctc-lib                       0.3.1            h74f4db8_0                   conda-forge
mda-xdrlib                     0.2.0            pyhd8ed1ab_0                 conda-forge
mdanalysis                     2.7.0            py310hcc13569_1              conda-forge
mdtraj                         1.9.9            py310h523e8d7_1              conda-forge
mdurl                          0.1.2            pyhd8ed1ab_0                 conda-forge
metis                          5.1.1            h59595ed_2                   conda-forge
mistune                        3.0.2            pyhd8ed1ab_0                 conda-forge
mlip                           1.0              hd0d41c4_3                   conda-forge
mmcif_pdbx                     2.0.1            pyhd8ed1ab_0                 conda-forge
mmtf-python                    1.1.3            pyhd8ed1ab_0                 conda-forge
mpc                            1.3.1            hfe3b2da_0                   conda-forge
mpfr                           4.2.1            h9458935_0                   conda-forge
mpi                            1.0              mpich                        conda-forge
mpich                          4.2.0            h846660c_100                 conda-forge
mpiplus                        v0.0.2           pyhd8ed1ab_0                 conda-forge
mpmath                         1.3.0            pyhd8ed1ab_0                 conda-forge
mrcfile                        1.5.0            pyhd8ed1ab_0                 conda-forge
msgpack-python                 1.0.7            py310hd41b1e2_0              conda-forge
multidict                      6.0.5            py310h2372a71_0              conda-forge
munkres                        1.1.4            pyh9f0ad1d_0                 conda-forge
mypy_extensions                1.0.0            pyha770c72_0                 conda-forge
n2p2                           2.1.4            py310hbd49d13_2              conda-forge
nbclient                       0.8.0            pyhd8ed1ab_0                 conda-forge
nbconvert                      7.16.2           pyhd8ed1ab_0                 conda-forge
nbconvert-core                 7.16.2           pyhd8ed1ab_0                 conda-forge
nbconvert-pandoc               7.16.2           pyhd8ed1ab_0                 conda-forge
nbformat                       5.9.2            pyhd8ed1ab_0                 conda-forge
ncurses                        6.4              h59595ed_2                   conda-forge
nest-asyncio                   1.6.0            pyhd8ed1ab_0                 conda-forge
netcdf-fortran                 4.6.0            nompi_he1eeb6f_102           conda-forge
netcdf4                        1.6.2            nompi_py310h55e1e36_100      conda-forge
networkx                       3.2.1            pyhd8ed1ab_0                 conda-forge
nglview                        3.1.2            pyh15ce09e_0                 conda-forge
nomkl                          1.0              h5ca1d4c_0                   conda-forge
nose                           1.3.7            py_1006                      conda-forge
notebook                       7.1.1            pyhd8ed1ab_0                 conda-forge
notebook-shim                  0.2.4            pyhd8ed1ab_0                 conda-forge
numba                          0.59.0           py310h7dc5dd1_1              conda-forge
numexpr                        2.9.0            py310hc2d3c2e_100            conda-forge
numpy                          1.26.4           py310hb13e2d6_0              conda-forge
oauthlib                       3.2.2            pyhd8ed1ab_0                 conda-forge
ocl-icd                        2.3.2            hd590300_0                   conda-forge
ocl-icd-system                 1.0.0            1                            conda-forge
openbabel                      3.1.1            py310heaf86c6_5              conda-forge
openff-amber-ff-ports          0.0.4            pyhca7485f_0                 conda-forge
openff-forcefields             2024.03.0        pyhca7485f_0                 conda-forge
openff-interchange             0.3.23           pyhd8ed1ab_0                 conda-forge
openff-interchange-base        0.3.23           pyhd8ed1ab_0                 conda-forge
openff-models                  0.1.2            pyhca7485f_0                 conda-forge
openff-nagl                    0.3.4            pyhd8ed1ab_0                 conda-forge
openff-nagl-base               0.3.4            pyhd8ed1ab_0                 conda-forge
openff-nagl-models             0.1.2            pyhd8ed1ab_0                 conda-forge
openff-qcsubmit                0.50.2           pyhd8ed1ab_0                 conda-forge
openff-recharge                0.5.2            pyhd8ed1ab_0                 conda-forge
openff-toolkit                 0.15.2           pyhd8ed1ab_0                 conda-forge
openff-toolkit-base            0.15.2           pyhd8ed1ab_0                 conda-forge
openff-toolkit-examples        0.15.2           hd8ed1ab_0                   conda-forge
openff-units                   0.2.1            pyh1a96a4e_0                 conda-forge
openff-utilities               0.1.12           pyhd8ed1ab_0                 conda-forge
openjpeg                       2.5.0            hfec8fc6_2                   conda-forge
openmm                         8.1.1            py310h43b6314_1              conda-forge
openmmforcefields              0.12.0           pyhd8ed1ab_0                 conda-forge
openmmtools                    0.23.1           pyhd8ed1ab_0                 conda-forge
openssl                        3.2.1            hd590300_0                   conda-forge
opt_einsum                     3.3.0            pyhc1e730c_2                 conda-forge
orc                            1.8.2            hfdbbad2_2                   conda-forge
overrides                      7.7.0            pyhd8ed1ab_0                 conda-forge
packaging                      23.2             pyhd8ed1ab_0                 conda-forge
packmol                        20.010           h86c2bf4_0                   conda-forge
pandas                         2.2.1            py310hcc13569_0              conda-forge
pandoc                         3.1.12.2         ha770c72_0                   conda-forge
pandocfilters                  1.5.0            pyhd8ed1ab_0                 conda-forge
panedr                         0.8.0            pyhd8ed1ab_0                 conda-forge
parmed                         3.4.4            py310heca2aa9_0              conda-forge
parquet-cpp                    1.5.1            2                            conda-forge
parso                          0.8.3            pyhd8ed1ab_0                 conda-forge
partd                          1.4.1            pyhd8ed1ab_0                 conda-forge
pathspec                       0.12.1           pyhd8ed1ab_0                 conda-forge
patsy                          0.5.6            pyhd8ed1ab_0                 conda-forge
pcre2                          10.43            hcad00b1_0                   conda-forge
pdb2pqr                        3.6.1            pyhd8ed1ab_0                 conda-forge
pdbfixer                       1.9              pyh1a96a4e_0                 conda-forge
perl                           5.32.1           7_hd590300_perl5             conda-forge
pexpect                        4.9.0            pyhd8ed1ab_0                 conda-forge
pickleshare                    0.7.5            py_1003                      conda-forge
pillow                         9.4.0            py310h023d228_1              conda-forge
pint                           0.21             pyhd8ed1ab_0                 conda-forge
pip                            24.0             pyhd8ed1ab_0                 conda-forge
pixman                         0.43.2           h59595ed_0                   conda-forge
pkg-config                     0.29.2           h36c2ea0_1008                conda-forge
pkgutil-resolve-name           1.3.10           pyhd8ed1ab_1                 conda-forge
platformdirs                   4.2.0            pyhd8ed1ab_0                 conda-forge
plotly                         5.19.0           pyhd8ed1ab_0                 conda-forge
plumed                         2.9.0            nompi_h752ec8b_100           conda-forge
prometheus_client              0.20.0           pyhd8ed1ab_0                 conda-forge
prompt-toolkit                 3.0.42           pyha770c72_0                 conda-forge
propka                         3.5.1            pyhc1e730c_1                 conda-forge
protobuf                       4.21.12          py310heca2aa9_0              conda-forge
psutil                         5.9.8            py310h2372a71_0              conda-forge
pthread-stubs                  0.4              h36c2ea0_1001                conda-forge
ptyprocess                     0.7.0            pyhd3deb0d_0                 conda-forge
pure_eval                      0.2.2            pyhd8ed1ab_0                 conda-forge
py-cpuinfo                     9.0.0            pyhd8ed1ab_0                 conda-forge
pyarrow                        11.0.0           py310h633f555_5_cpu          conda-forge
pyasn1                         0.5.1            pyhd8ed1ab_0                 conda-forge
pyasn1-modules                 0.3.0            pyhd8ed1ab_0                 conda-forge
pycairo                        1.25.0           py310hda9f760_1              conda-forge
pycparser                      2.21             pyhd8ed1ab_0                 conda-forge
pydantic                       2.6.3            pyhd8ed1ab_0                 conda-forge
pydantic-core                  2.16.3           py310hcb5633a_0              conda-forge
pyedr                          0.8.0            pyhd8ed1ab_0                 conda-forge
pygls                          1.3.0            pyhd8ed1ab_0                 conda-forge
pygments                       2.17.2           pyhd8ed1ab_0                 conda-forge
pyjwt                          2.8.0            pyhd8ed1ab_1                 conda-forge
pymbar                         4.0.2            hff52083_0                   conda-forge
pymbar-core                    4.0.2            py310h278f3c1_0              conda-forge
pyopenssl                      24.0.0           pyhd8ed1ab_0                 conda-forge
pyparsing                      3.1.2            pyhd8ed1ab_0                 conda-forge
pysocks                        1.7.1            pyha2e5f31_6                 conda-forge
pytables                       3.7.0            py310hb60b9b2_3              conda-forge
python                         3.10.13          hd12c33a_1_cpython           conda-forge
python-constraint              1.4.0            py_0                         conda-forge
python-dateutil                2.9.0            pyhd8ed1ab_0                 conda-forge
python-fastjsonschema          2.19.1           pyhd8ed1ab_0                 conda-forge
python-flatbuffers             24.3.6           pyh59ac667_0                 conda-forge
python-json-logger             2.0.7            pyhd8ed1ab_0                 conda-forge
python-tzdata                  2024.1           pyhd8ed1ab_0                 conda-forge
python_abi                     3.10             4_cp310                      conda-forge
pytng                          0.3.1            py310h7d11597_1              conda-forge
pytorch                        2.0.0            cpu_generic_py310h7ffd2bf_1  conda-forge
pytorch-lightning              2.2.1            pyhd8ed1ab_0                 conda-forge
pytz                           2024.1           pyhd8ed1ab_0                 conda-forge
pyu2f                          0.1.5            pyhd8ed1ab_0                 conda-forge
pyyaml                         6.0.1            py310h2372a71_1              conda-forge
pyzmq                          25.1.2           py310h795f18f_0              conda-forge
qcelemental                    0.27.1           pyhd8ed1ab_0                 conda-forge
qcengine                       0.29.0           pyhd8ed1ab_0                 conda-forge
qcportal                       0.53             pyhd8ed1ab_0                 conda-forge
quippy                         0.0.1            py310hd2eb85d_4              conda-forge
rdkit                          2022.03.5        py310h1c297d8_0              conda-forge
re2                            2023.02.01       hcb278e6_0                   conda-forge
readline                       8.2              h8228510_1                   conda-forge
referencing                    0.33.0           pyhd8ed1ab_0                 conda-forge
regex                          2023.12.25       py310h2372a71_0              conda-forge
reportlab                      4.1.0            py310h2372a71_0              conda-forge
requests                       2.31.0           pyhd8ed1ab_0                 conda-forge
requests-oauthlib              1.3.1            pyhd8ed1ab_0                 conda-forge
rfc3339-validator              0.1.4            pyhd8ed1ab_0                 conda-forge
rfc3986-validator              0.1.1            pyh9f0ad1d_0                 conda-forge
rhash                          1.4.4            hd590300_0                   conda-forge
rich                           13.7.1           pyhd8ed1ab_0                 conda-forge
rlpycairo                      0.2.0            pyhd8ed1ab_0                 conda-forge
rpds-py                        0.18.0           py310hcb5633a_0              conda-forge
rsa                            4.9              pyhd8ed1ab_0                 conda-forge
s2n                            1.3.37           h3358134_0                   conda-forge
scikit-learn                   1.4.1.post1      py310h1fdf081_0              conda-forge
scipy                          1.12.0           py310hb13e2d6_2              conda-forge
seaborn                        0.13.2           hd8ed1ab_0                   conda-forge
seaborn-base                   0.13.2           pyhd8ed1ab_0                 conda-forge
send2trash                     1.8.2            pyh41d4057_0                 conda-forge
setuptools                     69.1.1           pyhd8ed1ab_0                 conda-forge
six                            1.16.0           pyh6c4a22f_0                 conda-forge
sleef                          3.5.1            h9b69904_2                   conda-forge
smirnoff99frosst               1.1.0            pyh44b312d_0                 conda-forge
smmap                          5.0.0            pyhd8ed1ab_0                 conda-forge
snappy                         1.1.10           h9fff704_0                   conda-forge
sniffio                        1.3.1            pyhd8ed1ab_0                 conda-forge
sortedcontainers               2.4.0            pyhd8ed1ab_0                 conda-forge
soupsieve                      2.5              pyhd8ed1ab_1                 conda-forge
sqlalchemy                     2.0.28           py310h2372a71_0              conda-forge
sqlite                         3.45.1           h2c6b66d_0                   conda-forge
stack_data                     0.6.2            pyhd8ed1ab_0                 conda-forge
statsmodels                    0.14.1           py310h1f7b6fc_0              conda-forge
sympy                          1.12             pypyh9d50eac_103             conda-forge
sysroot_linux-64               2.12             he073ed8_17                  conda-forge
tabulate                       0.9.0            pyhd8ed1ab_1                 conda-forge
tblib                          3.0.0            pyhd8ed1ab_0                 conda-forge
tenacity                       8.2.3            pyhd8ed1ab_0                 conda-forge
tensorboard                    2.11.2           pyhd8ed1ab_0                 conda-forge
tensorboard-data-server        0.6.1            py310h600f1e7_4              conda-forge
tensorboard-plugin-wit         1.8.1            pyhd8ed1ab_0                 conda-forge
tensorflow                     2.11.0           cpu_py310hd1aba9c_0          conda-forge
tensorflow-base                2.11.0           cpu_py310hc9b7e7f_0          conda-forge
tensorflow-estimator           2.11.0           cpu_py310hfed9998_0          conda-forge
termcolor                      2.4.0            pyhd8ed1ab_0                 conda-forge
terminado                      0.18.0           pyh0d859eb_0                 conda-forge
threadpoolctl                  3.3.0            pyhc1e730c_0                 conda-forge
tidynamics                     1.1.2            pyhd8ed1ab_0                 conda-forge
tinycss2                       1.2.1            pyhd8ed1ab_0                 conda-forge
tinydb                         4.8.0            pyhd8ed1ab_0                 conda-forge
tk                             8.6.13           noxft_h4845f30_101           conda-forge
tomli                          2.0.1            pyhd8ed1ab_0                 conda-forge
toolz                          0.12.1           pyhd8ed1ab_0                 conda-forge
torchmetrics                   1.3.1            pyhd8ed1ab_0                 conda-forge
tornado                        6.4              py310h2372a71_0              conda-forge
tqdm                           4.66.2           pyhd8ed1ab_0                 conda-forge
traitlets                      5.14.1           pyhd8ed1ab_0                 conda-forge
types-python-dateutil          2.8.19.20240106  pyhd8ed1ab_0                 conda-forge
typing-extensions              4.10.0           hd8ed1ab_0                   conda-forge
typing_extensions              4.10.0           pyha770c72_0                 conda-forge
typing_utils                   0.1.0            pyhd8ed1ab_0                 conda-forge
tzdata                         2024a            h0c530f3_0                   conda-forge
unicodedata2                   15.1.0           py310h2372a71_0              conda-forge
unidecode                      1.3.8            pyhd8ed1ab_0                 conda-forge
uri-template                   1.3.0            pyhd8ed1ab_0                 conda-forge
urllib3                        2.2.1            pyhd8ed1ab_0                 conda-forge
validators                     0.22.0           pyhd8ed1ab_0                 conda-forge
voro                           0.4.6            h00ab1b0_0                   conda-forge
wcwidth                        0.2.13           pyhd8ed1ab_0                 conda-forge
webcolors                      1.13             pyhd8ed1ab_0                 conda-forge
webencodings                   0.5.1            pyhd8ed1ab_2                 conda-forge
websocket-client               1.7.0            pyhd8ed1ab_0                 conda-forge
werkzeug                       3.0.1            pyhd8ed1ab_0                 conda-forge
wget                           1.20.3           ha35d2d1_1                   conda-forge
wheel                          0.42.0           pyhd8ed1ab_0                 conda-forge
widgetsnbextension             4.0.10           pyhd8ed1ab_0                 conda-forge
wrapt                          1.16.0           py310h2372a71_0              conda-forge
xmltodict                      0.13.0           pyhd8ed1ab_0                 conda-forge
xorg-kbproto                   1.0.7            h7f98852_1002                conda-forge
xorg-libice                    1.0.10           h7f98852_0                   conda-forge
xorg-libsm                     1.2.3            hd9c2040_1000                conda-forge
xorg-libx11                    1.8.4            h0b41bf4_0                   conda-forge
xorg-libxau                    1.0.11           hd590300_0                   conda-forge
xorg-libxdmcp                  1.1.3            h7f98852_0                   conda-forge
xorg-libxext                   1.3.4            h0b41bf4_2                   conda-forge
xorg-libxrender                0.9.10           h7f98852_1003                conda-forge
xorg-libxt                     1.3.0            hd590300_0                   conda-forge
xorg-renderproto               0.11.1           h7f98852_1002                conda-forge
xorg-xextproto                 7.3.0            h0b41bf4_1003                conda-forge
xorg-xproto                    7.0.31           h7f98852_1007                conda-forge
xtb                            6.5.1            h03160e7_1                   conda-forge
xtb-python                     22.1             py310h1fa729e_0              conda-forge
xz                             5.2.6            h166bdaf_0                   conda-forge
yaml                           0.2.5            h7f98852_2                   conda-forge
yarl                           1.9.4            py310h2372a71_0              conda-forge
zeromq                         4.3.5            h59595ed_1                   conda-forge
zict                           3.0.0            pyhd8ed1ab_0                 conda-forge
zipp                           3.17.0           pyhd8ed1ab_0                 conda-forge
zlib                           1.2.13           hd590300_5                   conda-forge
zstandard                      0.22.0           py310h1275a96_0              conda-forge
zstd                           1.5.5            hfc55251_0                   conda-forge

This is one of my louder xfails: https://github.com/openforcefield/openff-interchange/blob/732079ea666000ff2240e148c5fcd8c76bb711cb/openff/interchange/_tests/unit_tests/interop/test_virtual_sites.py#L129
The context, including links to the implementation it's copied from, is here: https://github.com/openforcefield/openff-interchange/issues/832#issuecomment-1778150317
The other types of virtual sites seem to be fine, so those failures were super confusing.

source: gharchive/issue

authors: Yoshanuikabundi mattwthompson

repo: openforcefield/openff-interchange

license: MIT


text:
fix/MD/XL-9781 functional test case files generated when generating an unit test

Task XL-9781

Codecov Report
Attention: Patch coverage is 2.24719% with 87 lines in your changes missing coverage. Please review.

Project coverage is 4.46%. Comparing base (4123d2a) to head (88ae144).

Files with missing lines
Patch %
Lines

src/Generator/Traits/HasTestTrait.php
0.00%
32 Missing :warning:

...erator/Commands/TestCases/ApiTestCaseGenerator.php
0.00%
6 Missing :warning:

...erator/Commands/TestCases/CliTestCaseGenerator.php
0.00%
6 Missing :warning:

...Commands/TestCases/FunctionalTestCaseGenerator.php
0.00%
6 Missing :warning:

...rator/Commands/TestCases/UnitTestCaseGenerator.php
0.00%
6 Missing :warning:

...erator/Commands/TestCases/WebTestCaseGenerator.php
0.00%
6 Missing :warning:

src/Generator/Commands/ActionGenerator.php
0.00%
2 Missing :warning:

src/Generator/Commands/ConfigurationGenerator.php
0.00%
2 Missing :warning:

src/Generator/Commands/ControllerGenerator.php
0.00%
2 Missing :warning:

src/Generator/Commands/CriteriaGenerator.php
0.00%
2 Missing :warning:

... and 9 more

Additional details and impacted files
@@                                       Coverage Diff                                        @@
##             fix/MD/XL-9780-migration-test-generator-wrong-function-case     #34      +/-   ##
================================================================================================
- Coverage                                                           4.48%   4.46%   -0.03%
- Complexity                                                           869     893      +24
================================================================================================
  Files                                                                 98      99       +1
  Lines                                                               3097    3182      +85
================================================================================================
+ Hits                                                                 139     142       +3
- Misses                                                              2958    3040      +82

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

authors: codecov-commenter mderis

repo: openforests-git/apiato-core


text:
Refactoring models to allow simple enrollments

Purpose
We want to be able to enroll users without going through the ordering process.
Ordering should only be a way to add a toll step to the otherwise free enrollment and certification workflows.
Proposal
I pulled the string and got embarked in a major refactoring to decorellate enrollments from product/orders.

[x] Add a foreign key from the course run to the course as this is a defining link
[x] Modify products to point to target courses, not course runs. The course run is chosen in a separate call to the API after ordering. Ordering is just paying for a product. Thisi will allow single or multiple course runs for a given course and manual or automatic, immediate or delayed selection of a specific course run.

As it is, I have trouble to understand the ProductCourseRelation model and the coexistence oftarget_courses and target_course_runs fields in Product model.

For the record, the target_courses field if where we specifiy the courses that are being sold under this product. Once the product is bought, an order is created for the buying user. The target_courses are copied to the order so that we keep a copy of what courses were in the product at the moment it was bought.
After the order is paid, it is possible to enroll the user on a course run for each of the target courses. If a course has 3 course runs, the user who has bought a product containing this course, can enroll on any of the 3 course runs. Unless the target_course_runs field is filled on the product, and contains a selection of course runs for this course, and in this case, the user can only enroll on these course runs.

Add a entry to the changelog ? (Refactor models to allow enrollment without order?)

There is an error on Enrollment admin view when the enrollment has no order linked.

Guilty :
    def __str__(self):
        return f"[{self.state}] {self.course_run} for {self.order.owner}"

This is now fixed.

authors: jbpenrath sampaccoud

repo: openfun/joanie


text:
✨ Add a mechanism to connect external devices to a video live

Purpose
We want to allow pairing external devices to Marsha live. External devices are cameras or set-top boxes that can act as video and sound sources for a live in Marsha.
This PR should be merged after #1213

[x] Update frontend actionOne to permit

usage of any request method
usage of empty body request

[x] Add a frontend query to request /api/video/<id>/pairing-secret/
[x] Add a frontend component which:

request a secret
displays the secret
displays a countdown timer initially set to 1 minutes

#1196

@kernicPanel pair-secret`

@kernicPanel I'm not sure the endpoint /pair-secret and /pair-challenge are good paths. Maybe /pairing-secret and /pairing-challenge are more explicit (because pair makes you think of a pair of things, not about the pairing mechanism).

@kernicPanel I'm not sure the endpoint /pair-secret and /pair-challenge are good paths. Maybe /pairing-secret and /pairing-challenge are more explicit (because pair makes you think of a pair of things, not about the pairing mechanism).

Yes, I'll change that

Once the secret expired the button looks like this. We can maybe use a toast to inform the user that the button has expired ? Here I think there is too much information in the same button.

Yes, I totally agree with you @lunika.
But I'm not sure we should use a toast here, as all visual feedback are located in the button.
Maybe we can display Pairing secret expired for few seconds in the button, and Pair an external device after ?
WDYT ?

Once the secret expired the button looks like this. We can maybe use a toast to inform the user that the button has expired ? Here I think there is too much information in the same button.

Yes, I totally agree with you @lunika. But I'm not sure we should use a toast here, as all visual feedback are located in the button. Maybe we can display Pairing secret expired for few seconds in the button, and Pair an external device after ? WDYT ?

Or we can also move all feedbacks in a toast. I'll try this, if you agree @lunika

PR OK for another review @lunika @carofun @sampaccoud

authors: kernicPanel sampaccoud

repo: openfun/marsha


text:
tree structure vs features api

I may have missed this aspect in the preparations of oapi's...
Oapi-cov uses a tree structure of /collection/coverages/... where oapi-ft uses a structure of /collection/items (which are the features).
At the pyGeoApi group we were discussing how a software product can support both oapi-cov as well as oapi-ft.  It should either have to identify the relevant service-type by a unique string, or allow a mixture of features and coverages in a single collection.
Some questions that came to my mind...

Shouldn't a coverage be considered as a collection of grid-rows (like features in a ft collection)?
Is a coverage-series (collection) a very common use case in the coverage domain? I guess so, because satellites produce many observation on a single flight.
Do you envision an api supporting both features as well as coverages in a single collection?

I may have missed this aspect in the preparations of oapi's...

your thoughts are more than welcome! :)

Oapi-cov uses a tree structure of /collection/coverages/... where oapi-ft uses a structure of /collection/items (which are the features).

no problem, an "item" in feature world corresponds to a coverage in coverage world :) it is just that vectors and rasters have some intrinsic differences, so the operations will be different (like scaling = reducing resolution of a coverage, which does not have a direct counterpart in feature world).
However, I am not sure whether I should have a headache since I seem to have heard that WFS now is starting to define coverages.

At the pyGeoApi group we were discussing how a software product can support both oapi-cov as well as oapi-ft. It should either have to identify the relevant service-type by a unique string, or allow a mixture of features and coverages in a single collection.

hm, oapi-cov and oapi-ft already distinguish, don't they?
For this first cut IMHO mixed collections are too far reaching, we have to finish some homeworks first. For example, features and collections have different ways of expressing subsetting, it's as basic as that currently.

Some questions that came to my mind...
* Shouldn't a coverage be considered as a collection of grid-rows (like features in a ft collection)?

no. In a multi-dimensional grid there is no preference, all axes are at the same level. No row collection, column collection, etc. - would make life terribly complicated and misrepresent reality.

* Is a coverage-series (collection) a very common use case in the coverage domain? I guess so, because satellites produce many observation on a single flight.

yes, that is not uncommon. In the extreme case: stereo image = a pair of images of same resolution etc.
Of course one could also think of (user-defined) nested collections, but we are just about to establish the very first cut, so concentrating on the basics.

* Do you envision an api supporting both features as well as coverages in a single collection?

definitely of interest, use case: GMLJP2, GeoPackage, etc which all like to combine vector, raster, meta data. Already 2+ years ago I presented the idea of an overarching query language to OGC, but OAB did not enjoy the idea.

(it's been awhile since the this issue was opened, so some things may have changed over time as the OGC API efforts become more clear/aligned)
As I understand it, /collections/{collectionId} can provide data in a variety of approaches.

/collections/{collectionId}/items: features
/collections/{collectionId}/coverage: coverages/CIS
/collections/{collectionId}/tiles: tiles

In addition, the EDR API also provides Query Types which follow this design pattern.
So a given software implementation can provide a collection accordingly (depending on the native data type and mechanism of representing same).

There's also /collections/{collectionId}/map for requesting map layers.  And in Testbed 15 we were experimenting (rather successfully IMO) with a /collections/{collectionId}/images set of endpoints for managing the set of source images of a coverage.

20200902: Coverages SWG call: We believe this has been overcome by events e.g. https://github.com/opengeospatial/oapi_common/issues/140 Please reopen if you think this is still relevant.

authors: Schpidi pebau pomakis pvgenuchten tomkralidis


text:
Test get_data and running inversions separately

Now that there is a get_data function, we can test get_data vs. a fixed merged data file, and then use fixed merged data for the inversions tests.
The basis function wrapper could also be tested separately, and possible the post processing code.

Getting an error when trying to run an inversion with the example ini file. The get_data function can't seem to find obs data (TAC, ch4) which is preventing the combined_scenario from being created. The error message is:
UnboundLocalError: local variable 'scenario_combined' referenced before assignment
@brendan-m-murphy

The error @pearson01 found should now be fixed in the update get obs branch

I'm guessing the fix was the part that throws an error if all of the sites are dropped?
I'll make sure to add some test cases where some/all data can't be found.

Exactly! I just added an if statement to exit the process if no site data are found before it gets to the line with scenario_combined.mf.units, which was what was raising this error

This was closed by PR #73

authors: EricSaboya brendan-m-murphy pearson01


text:
Add debug execution to the created archetypes

This PR is based on @jperedadnr comments at StackOverflow modified for running debugger from IDE.
It might be better to have two debug executions. One as originally show, and call it "debug" and the one in this PR changing it's name to "ide-debug"
@neilcsmith-net has advocated, in another issue, for a general solution where archetype/pom can specify common IDE actions. He suggests representatives of maven,IDEs,JavaFX and others work something out.

I am not very keen to add the debug options by default. My preferred way to handle this would be to add a property add-debug-configuration to archetype with accepted values as "Y/N" (default value being "N"). If user wants the default configurations, they can input "Y" while the archetypes are created.

add a property ... If user wants debug configurations

OK. In my queue.

@abhinayagarwal @jperedadnr Updated PR with required property add-debug-configuration. If property "Y" add two debug configurations, one for manual attach, one for IDE attach.

While exploring the use of jlink, I noticed <javafx.mainClass> property. Is there any reason the archetypes do not set or use this?
Would the addition of this property, and it's use, be a welcome update to this PR?

I merged and pushed the branch with latest changes to fix the conflicts.

authors: abhinayagarwal errael

repo: openjfx/javafx-maven-archetypes


text:
Archive/Invalidate old Drafts which have a Proposal

Expected behavior
When requesting draft types from the new draft endpoints, if a proposal exists for the draft, it should not be returned. This is because it is no longer technically a Draft from the perspective of the API consumer. How do we do this in a clear and reliable way?
Idea
We can leverage the upcoming Snapshot API's new unique hash field (this will be used for the "linked" Moloch bytes32 proposalId - we need to make GH issue for this) for the draft and proposal types. On POST /message of a proposal type we could use this same hash to check if it includes a Draft's unique hash as part of the JSON.
If it does include the hash, and a Draft is found in the database, we can somehow mark the Draft as archived. Now when the Draft(s) are fetched on GET /:space/drafts/... we can use Postgres to filter-out the archived ones.
Actual behavior
Today all Drafts will be fetched on the erc712 branch, regardless if a proposal exists for the Draft, or not.
Steps to reproduce the behavior
N/A

@adridadou

@jtrein this is ready.
if you generate a Draft you receive back a uniqueId, then you can use the uniqueId to query the API and retrieve the Draft details.
Then when you sponsor a Draft, you build a new Proposal message using all the data retrieved using the Draft uniqueId. There is one trick though, you need to use the timestamp from the draft in the proposal message, otherwise the ERC712 hashes will not match.
I have released a fix for snapshot-js-erc712 lib in which you can provide the timestamp as parameter: https://github.com/openlawteam/snapshot-js-erc712/blob/master/utils/snapshotHub.ts#L215
With that we ensure the hashes will always match if the other attributes are identical. Otherwise it would always generate a new timestamp for each new proposal, and we don't want that when we are sponsoring a draft.

@jtrein this is ready.
if you generate a Draft you receive back a uniqueId, then you can use the uniqueId to query the API and retrieve the Draft details.
Then when you sponsor a Draft, you build a new Proposal message using all the data retrieved using the Draft uniqueId. There is one trick though, you need to use the timestamp from the draft in the proposal message, otherwise the ERC712 hashes will not match.
I have released a fix for snapshot-js-erc712 lib in which you can provide the timestamp as parameter: https://github.com/openlawteam/snapshot-js-erc712/blob/master/utils/snapshotHub.ts#L215
With that we ensure the hashes will always match if the other attributes are identical. Otherwise it would always generate a new timestamp for each new proposal, and we don't want that when we are sponsoring a draft.

authors: fforbeck jtrein

repo: openlawteam/snapshot-hub


text:
Projection option in TileDebug not working

Describe the bug
TileDebug seems to ignore the specified projection  and always display a tile grid in the view projection (noticed when looking at #12361 as using a flipped projection should have simulated a TMS grid).
To Reproduce
See https://codesandbox.io/s/canvas-tiles-forked-z7bij
Expected behavior
EPSG:3857 canvas tiles should be reprojected to correspond with the OSM tiles as happens if they are produced using an XYZ source https://codesandbox.io/s/simple-forked-ji7qx

Fixed by #12373

repo: openlayers/openlayers


text:
ol5: render changes features positions

Hi,
We changed openlayers version from 4.6.5 to 5.1.3.
We noticed that when first time map is rendered (with 5.1.3 version) the view looks exactly same than with old version (4.6.5) of openlayers. But when map is rendered again some features moves little bit on the screen. I made some debugging and look source code and I found the reason:
In PluggableMap.renderFrame function in version 4.6.5 there is:
    viewState = view.getState();
    var center = viewState.center;
    var pixelResolution = viewState.resolution / this.pixelRatio_;
    center[0] = Math.round(center[0] / pixelResolution) * pixelResolution;
    center[1] = Math.round(center[1] / pixelResolution) * pixelResolution;

and in 5.1.3
      viewState = view.getState();
      let focus = this.focus_;
      if (!focus) {
        focus = viewState.center;
        const pixelResolution = viewState.resolution / this.pixelRatio_;
        focus[0] = Math.round(focus[0] / pixelResolution) * pixelResolution;
        focus[1] = Math.round(focus[1] / pixelResolution) * pixelResolution;
      }

So in 4.6.5 version, rounding of 'center' is done always but in 5.1.3 version only on first time.

Thanks for reporting this. #7871 indeed introduced a regression here.

authors: ahocevar jkopponen


text:
[refactor] build on top of golang.org/x/tools/go/analysis

So far we've implemented our lint rules manually - and a frontend to match.
The analysis package implements numerous checkers that serve as great examples - and ways to run them (and custom ones) via the analysis/multichecker and analysis/singlechecker packages.
Instead of rolling our own, we should attempt to use this interface.

Working on this in chrsm/go-analysis

It looks like we'll need to write a tiny frontend similar to analysis/multichecker to support our yaml-based config format. This shouldn't be too challenging, as all cmd/openlynt does is parse the yaml and run ast.Inspect.

after the refactor we can follow the example at https://github.com/golangci/golangci-lint/blob/master/pkg/golinters/govet.go if we ever want to submit a PR for integration with golangci-lint

:+1: it'd be pretty awesome to get ours in there!

authors: chrsm toejough

repo: openlyinc/openlynt


text:
LmDeploy 部署

请问 Pulse 可以使用 LmDeploy进行部署吗？

请问 Pulse 可以使用 LmDeploy进行部署吗？

20B的模型可以的。

repo: openmedlab/PULSE


text:
Fix link to Homebrew installation script (rebased onto dev_5_0)

This is the same as gh-1091 but rebased onto dev_5_0.

With the migration of the script to the omero-install repository, the
link on the documentation page needs to be updated

--rebased-from #1091

See https://github.com/ome/omero-install/pull/11

This also looks fine.  Please merge.

Actually, the docs merge build has broken link for me: https://github.com/snoopycrimecop/openmicroscopy/blob/merge/dev_5_0/latest/https://github.com/ome/omero-install/tree/master/homebrew  (in http://www.openmicroscopy.org/site/support/omero5-staging/sysadmins/unix/server-install-homebrew.html)

My bad. Pushed a fix.

Thanks, that's much better.

Looks good to merge.
Note that this page is quite outdated and could do some work for 5.1:

OSX/Xcode section describes the old CI setup which was replaced a while back
"Java..comes as standard on OS X" has not been true since 10.6 and could be removed.
System vs. homebrew python.  Rather than detailing all the various combinations which are possible, maybe just recommend use of homebrew python and leave it at that?

Most of this is duplication what's already on the main unix installation page, which also covers installing the prerequisites with homebrew.  Could this page be cut down to just how to do the install and delegate the rest of the detail to the main page?

Great suggestion @rleigh-dundee - I'll stick a card on the Docs board for that, if you or Seb want to volunteer, please go ahead :)

authors: hflynn rleigh-dundee sbesson

repo: openmicroscopy/ome-documentation


text:
Closing 'Statement' window (open from click on output window) pauses execution

Closing 'Statement' window (opened from click on output window statement) pauses execution but does not reflect this in the main window UI.

This issue is gone, concept windows can be closed without having the system paused.

repo: opennars/opennars

license: mit

license_source: bigquery


text:
Style cleanup

Mostly cleaning up extraneous spaces and little PEP8 mistakes.
Merge at will. This is just intended to make review of future PRs easier by separating the cleanup from the real code. There's plenty more style cleanup to do, but this improves a few files that I plan to work on the in the near future.

thanks. Will merge.

authors: dwhswenson jhprinz

repo: openpathsampling/openpathsampling


text:
Error: undeclared identifier: 'TK_UNKNOWN'

import tables
import toktok
import lexbase

tokens:
    Plus      > '+'
    Minus     > '-'
    Multi     > '*'
    Div       > '/'
    Assign    > '='
    Comment   > '#' .. EOL      # anything from `#` to end of line
    CommentAlt > "/*" .. "*/"   # anything starting with `/*` to `*/`
    Var       > "var"
    Let       > "let"
    Const     > "const"
    BTrue     > @["TRUE", "True", "true", "YES", "Yes", "yes", "y"]
    BFalse    > @["FALSE", "False", "false", "NO", "No", "no", "n"]

when isMainModule:
    var lex = Lexer.init(fileContents = readFile("sample.txt"))
    if lex.hasError:
        echo lex.getError
    else:
        while true:
            var curr = lex.getToken()           # tuple[kind: TokenKind, value: string, wsno, col, line: int]
            echo curr

I get these errors when just running the default sample code

Looking inside the code, it shows that it has something to do with this code:

There also seems to be an error with adding values.
I added "LColon" and "RColon" into the token list:
tokens:
    Plus      > '+'
    Minus     > '-'
    Multi     > '*'
    Div       > '/'
    LCol      > '('
    RCol      > ')'

However, when it outputs values: it doesn't recognize it.
(kind: TK_LCOL, value: "", wsno: 0, line: 1, col: 0, pos: 0)
(kind: TK_STRING, value: "test", wsno: 0, line: 1, col: 1, pos: 1)
(kind: TK_RCOL, value: "", wsno: 0, line: 1, col: 7, pos: 7)

The file contents are:
("test")

Seems fine to me, you have TK_LCOL (pos 0) and TK_RCOL (pos 7).
If you're talking about the empty value field, well, there is no need to store (, ) characters

Ah I didn't notice the "pos" / .col syntax. In that case, it works perfectly!

No. Whitespaces are counted and stored in wsno field

Not added in docs, but here is how you can handle 2 or more characters for multiple use cases
So for example > which can be >=
tokens:
    GT           > '>':
        GTE      ? '='

    LT           > '<':
        LTE      ? '='

     # string based tokens TK_AT, TK_INCLUDE and TK_MIXIN
    At           > '@':
        Include  ? "include"
        Mixin    ? "mixin"

Not added in docs, but here is how you can handle 2 or more characters for multiple use cases
So for example > which can be >=
tokens:
    GT           > '>':
        GTE      ? '='

    LT           > '<':
        LTE      ? '='

     # string based tokens TK_AT, TK_INCLUDE and TK_MIXIN
    At           > '@':
        Include  ? "include"
        Mixin    ? "mixin"

I mean if I had:
echo "Test"

echo "Test2"

How do you seperate multi-line when it doesn't even tokenize NEWLINE ("\n")

There is no need for tokenizing new lines or whitespaces. Imagine how many useless tokens would be.
That's why you have wsno and line field for each TokenTuple returned by getToken proc.
So based on your example will be
(kind: TK_ECHO, value: "echo", wsno: 0, line: 1, col: 0, pos: 0)
(kind: TK_STRING, value: "Test", wsno: 1, line: 1, col: 5, pos: 5)
(kind: TK_ECHO, value: "echo", wsno: 0, line: 2, col: 0, pos: 0)
(kind: TK_STRING, value: "Test", wsno: 1, line: 2, col: 5, pos: 5)

Anything else should be implemented at Parser level and AST

There is no need for tokenizing new lines or whitespaces. Imagine how many useless tokens would be. That's why you have wsno and line field for each TokenTuple returned by getToken proc.
So based on your example will be
(kind: TK_ECHO, value: "echo", wsno: 0, line: 1, col: 0, pos: 0)
(kind: TK_STRING, value: "Test", wsno: 1, line: 1, col: 5, pos: 5)
(kind: TK_ECHO, value: "echo", wsno: 0, line: 2, col: 0, pos: 0)
(kind: TK_STRING, value: "Test", wsno: 1, line: 2, col: 5, pos: 5)

That is smart but there is the challenge of telling the code that "This is a new line."
I could make it so it check each line number and when there is a new line then it would execute the code and continue. 🤔

Haha. Glad you like this! There are still many things to do.
And this would be a minimal parser for your toktok
type
    Parser* = object
        lex: Lexer
        prev, current, next: TokenTuple
        error: string

proc setError(p: var Parser, msg: string) =
    ## Set parser error
    p.error = "Error ($2:$3): $1" % [msg, $p.current.line, $p.current.pos]

proc walk(p: var Parser, offset = 1) =
    var i = 0
    while offset != i:
        p.prev = p.current
        p.current = p.next
        p.next = p.lex.getToken()
        inc i

var p = Parser(lex: Lexer.init(fileContents = readFile("sample.txt")))
p.current = p.lex.getToken()
while p.current.kind != TK_EOF and p.error.len == 0:
    case p.current.kind:
    of TK_LET, TK_VAR, TK_CONST:
        let this = p.current
        if p.next.kind == TK_IDENTIFIER:
            discard # handle var declaration
        else:
            p.setError("Invalid variable declaration expect identifier")
            break
    of TK_PLUS, TK_MINUS, TK_MULTI, TK_DIV:
        discard # handle math
    else: discard # and so on
    walk(p) # walk to next token

if p.error.len != 0:
    echo p.error

There also seems to be an error with the comment.
When I put:
*This is a test*

/* This is a test*/

I get:
TK_MULTI
TK_IDENTIFIER
TK_IDENTIFIER
TK_IDENTIFIER
TK_IDENTIFIER
TK_MULTI
TK_DIV
TK_MULTI
TK_IDENTIFIER
TK_IDENTIFIER
TK_IDENTIFIER
TK_IDENTIFIER
TK_MULTI
TK_DIV
TK_EOF

Yep. That does not work right now. I hope will be fixed soon

Ok, now this should work. Reinstall your toktok package.
tokens:
        Div       > '/':
            BlockComment ? '*' .. "*/"            # everything starting from /* to */ (tail should be a string)
            InlineComment ? '/' .. EOL            # everything starting from // to EOL (end of line)

This is work in progress (markdown use case)
tokens:
        H1   > '#' .. EOL:
            H2 ? '#' .. EOL
            H3 ? '#' .. EOL

The reason why I was asking was because I am having trouble on trying to design a truly functioning if statement / white statement.
Making one work is easy but trying to make it work INSIDE another is difficult.

This is a generic lexer, that's why you should write this kind of logic at parser level.
By the way, instead of tables, I recommend you implement AST nodes using Nim objects.
I made a functional Parser + AST nodes, based on current toktok Lexer that does what you need. You can start from this.
https://github.com/openpeep/toktok/blob/main/examples/program.nim

This is a generic lexer, that's why you should write this kind of logic at parser level.
By the way, instead of tables, I recommend you implement AST nodes using Nim objects.
I made a functional Parser + AST nodes, based on current toktok Lexer that does what you need. You can start from this. https://github.com/openpeep/toktok/blob/main/examples/program.nim

Oh damn that's beautiful.
I, myself, am not that big in the field of computer science however I do love programming and data science.
I started working on a side-project programming lang called "Barcelona" that was suppose to make database/statistics/requests data much easier and straight to the point.
It is an experimental project that has a mixture of Rust's memory safety tools, Python's simple syntax and Nim's Performance. In addition has built in translators to convert code to Python or Rust or make Python files execute Barcelona's code to make request process quicker.
I am going to be having a 6-week college break so I plan to severally work on Barcelona but I am new to understanding how a program. language works.
Any advice would be appreciated.

Nim is a good start. Also thanks for trying toktok. Hobby projects are awesome.
Maybe you don't have to write a micro language, you have Nim macros!

Nim is a good start. Also thanks for trying toktok. Hobby projects are awesome.
Maybe you don't have to write a micro language, you have Nim macros! https://nim-lang.org/docs/macros.html
Also, check Computer Programming with the Nim Programming Language

Nim is an interesting language, I started learning a few days ago and it looks pretty good. I love how it's a mixture of Python's Simplicity, C's Performance and Lisp's flexibility. In addition to the fact that you can compile code to C, C++, Obj C is really cool. (also JS)
The only problem I am having is trying to make a function CERTAIN elements in a list.
Ex. in python's list, you can do List[3:-1] where it would get the 3rd value to 2nd-last value. Nim doesn't seem to have that ability (or I can't find it).
Also Windows Defender seems to find it as a virus after version 1.4.0 (idk why). Cool and unique language to learn.

Regarding Windows Defender, that's a false positive. https://github.com/nim-lang/Nim/issues/17820. Report as a false positive, if is possible.
You mean something like this?
var a = @["bread", "cake", "tomorrow"]
echo a[1 .. ^1]     # output @["cake", "tomorrow"]
echo a[2 .. ^1]     # output @["tomorrow"]

Bookmark this String Functions: Nim vs Python. Most of these examples works with seq and array / openarray

Regarding Windows Defender, that's a false positive. https://github.com/nim-lang/Nim/issues/17820. Report as a false positive, if is possible.

Ah that would make a lot of sense tbh. I recall there was a time where you can trigger people's windows defenders via discord just by sending pictures / videos.

You mean something like this?

Something like that! Thank you!

I tried to make a seperate nim file to run onto the main nim file and it seems to give out an interesting error.

Update it appears the error is being created because I am importing std/strutils from the 2nd file (not the main file)

Also

Do you think you can add the token for float numbers?
The token for:
2.0 4 4.0
Would be:
(kind: TK_INTEGER, value: "2", wsno: 0, line: 1, col: 0, pos: 0) (kind: TK_PERIOD, value: "", wsno: 0, line: 1, col: 1, pos: 1) (kind: TK_INTEGER, value: "44", wsno: 0, line: 1, col: 2, pos: 2) (kind: TK_PERIOD, value: "", wsno: 0, line: 1, col: 5, pos: 5) (kind: TK_INTEGER, value: "0", wsno: 0, line: 1, col: 6, pos: 6) (kind: TK_EOF, value: "", wsno: 0, line: 1, col: 7, pos: 7)

Thanks for that! Update your local toktok

Another suggestion I would offer is the idea of multi-threading. Do you think it would be possible for it to be implemented?

Not sure why but it gives off this "duplicate" import warning from tiktok.

try use toktok in a separate file, let's say "tokens.nim", there you will define your tokens. Then import tokens.nim in your parser.
tokens.nim
import toktok

tokens:
  # here

parser.nim
import ./tokens

authors: JewishLewish georgelemon

repo: openpeep/toktok


text:
feat: Gzip webpack bundle

Add gzip middleware to server
Upgrade webpack, webpack-cli to v4.17

see: #289

repo: openpitrix/dashboard


text:
执行quantize_torch_model.py后，pytorch模型export出的onnx模型并不是QNN模型

执行quantize_torch_model.py后，pytorch模型export出的onnx模型并不是QNN模型，虽然export导出了一份json文件和onnx模型，但是有没有办法获得一个QNN量化后的int8模型（体积比原fp32模型小的）？

你platform那边选QNN平台，然后直接用SNPE_convert_dlc那个工具可以读取你的json和onnx模型转成dlc，QNN 可以用

感谢回答！但是获得一个dcl文件，可能不是我想要的QNN模型。
目前
export_ppq_graph(graph=quantized, platform=PLATFORM,
graph_save_to='Output/QDQ.onnx',
config_save_to='Output/QDQ.json')
如果 PLATFORM = TargetPlatform.QNN_DSP_INT8， quantize_torch_model.py会export出一个 .json 和 .onnx(看起来和fp32原模型一样)；如果PLATFORM = TargetPlatform.ONNXRUNTIME，会生成一个.json 和 .onnx(体积比原模型小了，且是一个QDQ模型)，如图

但想问一下，如何生成一个QNN模型，比如intel的neural-compressor量化工具可以生成的那种QNN模型，如图：

对了，还想问个问题：
其实在使用Aimet工具量化，然后导出onnx时，也是导出一份encodings + fp32模型。用咱们ppl的工具也会导出一份json + fp32模型。这个我不是很理解，导出的内容有什么意义或者有什么用途。因为之前我用的intel量化工具，输入fp32模型，导出int8 QNN模型，体积变小，也可以直接推理和部署。Aimet和ppl导出的两份文件是否可以再次转成QNN模型，或者有别的用法？

你那个量化工具导出的不是int8模型，而且float32，那个encoding的file记录的是你的模型的量化参数，你需要用SNPE-convert-dlc那个工具，读取这两个文件这才能生成一个int8的模型。Aimet和PPL是一样的

根据我目前的了解Aimet这个东西不能直接生成一个int8模型，而是需要读取那个json文件（记录的是你的模型的量化参数）+你输出的量化模型，然后用SNPE-convert-dlc那个工具，读取这两个文件这才能生成一个int8的模型。PPL选QNN_DSP_INT8和Aimet是一样的

十分感谢大佬解答了我一直带有的疑惑！
我研究一下SNPE_convert_dlc如何生成int8模型吧，十分感谢！

您好，尝试了用SNPE-convert-dlc的工具，这个目前能转化出dlc文件，但想要一个QNN的int8 ONNX模型，好像还不行，是我使用的方式不对吗？

是这个工具吗
https://docs.qualcomm.com/bundle/publicresource/topics/80-63442-50/converters.html

这个model.cpp QNN可以用我记得

authors: Donaldkidd JiliangNi

repo: openppl-public/ppq


text:
Devel add competitive dialogue

Залежить від PR https://github.com/openprocurement/openprocurement.tender.competitivedialogue/pull/3

This change is

Заберіть коміт bf0c075: remove dependency. Він виправляє те, що було додано в попередньому.
Варто злити його в попередній.

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

op_robot_tests/tests_files/base_keywords.robot, line 19 [r1] (raw file):

  ...      lot_meat=${${lot_meat}}
  ...      item_meat=${${item_meat}}
  ...      dialogue_type=${dialogue_type}

Мені здається, що коли не буде глобальної змінної ${dialogue_type}, то цей рядок викине помилку.
Можна пофіксити, дописавши щось типу
Run keyword if  ${dialogue_type} != ${None}  Set to dictionary  ${tender_parameters}  dialogue_type=${dialogue_type}

op_robot_tests/tests_files/initial_data.py, line 401 [r1] (raw file):

    data['procurementMethodType'] = 'competitiveDialogue.aboveThreshold' + params.get('dialogue_type', 'EU')
    if data['procurementMethodType'].endswith('EU'):
        data['title_en'] = "[TESTING]"

Це хардкод. Так не має бути. Використовуйте faker-а для уникнення таких ситуацій.

op_robot_tests/tests_files/initial_data.py, line 405 [r1] (raw file):

        'accelerator={}'.format(accelerator)
    for item_number, item in enumerate(data['items']):
        item['description_en'] = "Test item #{}".format(item_number)

Це теж хардкод.

op_robot_tests/tests_files/initial_data.py, line 409 [r1] (raw file):

    data['procuringEntity']['contactPoint']['name_en'] = fake_en.name()
    data['procuringEntity']['contactPoint']['availableLanguage'] = "en"
    data['procuringEntity']['identifier']['legalName_en'] = "Institution \"Vinnytsia City Council primary and secondary general school № 10\""

Хардкод.

op_robot_tests/tests_files/resource.robot, line 6 [r1] (raw file):

${broker}         Quinta
${role}           viewer
${dialogue_type}  EU

Підозрюю, що це має бути не тут,  а в секції Variables файлу openProcedure.robot

op_robot_tests/tests_files/service_keywords.py, line 43 [r1] (raw file):

    test_tender_data_openeu,
    test_tender_data_openua,
    test_tender_data_competitive_dialogue,

Пересуньте вверх, щоб список був у правильному алфавітному порядку.

Comments from Reviewable

Підчас виправлення зауважень до PR було пошкоджено цілісность історії комітів.
Тому цей закриваю, і прикріплю силку до нового https://github.com/openprocurement/robot_tests/pull/237

1)Цілісність історії комітів можна було відновити, видаливши мій коміт 4ea281f : Fix name of test cases in limited proc.. Або зробивши rebase без помилок.
2)Закривати пул-реквест і відкривати новий - поганий вихід з ситуації. Більше так не робіть.
3)Коміти варто робити меншими. В одному коміті один логічний шматок коду.
4)В коміт меседжі описується, що було зроблено (кожну зміну варто згадати). В поясненні описується, чому було зроблено ці зміни.

authors: Krokop mykhaly


text:
allocation_mode

When allocation_mode is set as manual, how to set the following values?
allocation.parallel.pipeline_parallel_size=1
allocation.parallel.model_parallel_size=2
allocation.parallel.data_parallel_size=4
If I respectively have 2 GPUs, 4 GPUs, 8 GPUs, how to set them?
In addition, how many A100 GPUs are approximately required for a 7b LLM in sft, rm and ppo?

Please refer to ppo_manual.sh for a detailed example of allocating resources in a PPO experiment. In manual allocation, you should specify device mesh and parallel strategy for each model function call, and make sure the product of parallel degrees in parallel strategy matches the number of GPU devices in your device mesh. There are also detailed naming conventions of device mesh in the example script.
As for number of GPUs used for 7B experiments, we suggest at least 2x 80GB A100 GPUs for SFT and RM and 8x 80GB A100 GPUs for PPO. To train on less GPUs, you can try to:

Set higher model_parallel_size and pipeline_parallel_size and lower data_parallel_size.
Reduce training batch size and max sequence length.

In the future patches, we will support micro batches and gradient accumulation to allow training on less GPUs without reducing batch size.

As a closing remark, ReaL now supports mini-batched execution. The user can change the n_mbs attribute in each MFCConfig. Increasing the number of mini-batches (aka n_mbs) can also reduce GPU memory usage and use less GPUs to perform training. Check this script for a concrete example.
Besides, ReaL will support arbitrary identical parallelization strategies by passing a regex-matched string to allocation_mode. For example, allocation_mode=d4m1p2 will set DP=2, TP=1, PP=2 for all model function calls. See this PR.

authors: AIRobotZhang garrett4wade nuzant

repo: openpsi-project/ReaLHF


text:
ADD: Add data for tobac

Add required data for tobac, and update the Py-ART gridding notebook to generate the TOBAC input

@kelcyno - I went ahead and updated the tobac notebook using the new data paths generated from the Py-ART section. The Py-ART gridding follows the snippet you shared.


text:
[VMWARE/VRO] Update attachvolume interface based on new HostAPI

/kind feature

What happened:
New HOST API has been added in hotpot, which has impact with volume attachement API.
all nbp code needs to be update according to new API.
What you expected to happen:
update volume attachemnt call in NGC to comply with new API.

enhanced ngc interface to incorporate new host API

repo: opensds/nbp


text:
Change the fullscreen icon according to the state

How could I change the fullscreen icon in accord with the current window state? I've tried to assign new values to viewer.navImages.fullpage in full-screen event but this isn't enough to update the image on screen.
Thanks.

Looks like we don't currently have the ability to change the button icons dynamically. That would be the first step: some sort of method on OpenSeadragon.Button that would allow you to change its icon. Once you had that, you could call that method when the full screen event happened.
For that matter, having our full screen icon change in accordance with the window state by default seems like a nice enhancement.
If you're interested in making a patch for some or all of this I'm happy to help point you in the right direction.

Let's see... Let me finish #1630 first.

authors: Riclim iangilman

repo: openseadragon/openseadragon


text:
Add freeupCanvasMemory method on Viewer.destroy method.

Add freeupCanvasMemory method to avoid "Total canvas memory use exceeds the maximum limit" warning and then "null is not an object (evaluating 'smallContext.drawImage')" error.
I also add memorycheck-with-simple-image demo to reproduce them.
(To get them, disable freeupCanvasMemory method, then click Create button 12 times on "iPad Air (3rd generation) -- 13.3" Simulator on Mac with Web Inspector by Safari.)

@iangilman Thank you for your review! I totally agree with your changes request. I responded to your request, so please review again.

OK, I responded. Please review again...

@iangilman I know we all are getting confused in some way in this situation, so no need to say sorry for the delay ;) And I also know the U.S. is in a super difficult situation, so please take care of yourself and your family.
Well, I didn't know TileSource has its own destroy method, which is executed when Viewer.destroy called, but now I agree with your suggestion.
I responded, and please review it again. But please take your time.


text:
[Feature Request] Build Sort Search Processor and Split Search Processor

Is your feature request related to a problem? Please describe
The Machine Learning Inference Processor is designed to improve the ease of using machine learning models for processing ingest/search requests. It utilizes a machine learning model to read from the data and add the prediction outcome to the data being ingested through the ingest pipeline, or return the prediction outcomes along with the search response through the search pipeline. Each ml-commons remote inference includes a pre-process function and a post-process function. The process function, written with a painless script, defines the pre-process and post-process data transformations needed for the ml-commons remote inference use case.
Given that we are on a path to reduce Painless script usage due to its complexity for customers, we introduced a JSONPath dependency to replace the Painless script process functions. However, JSONPath has some functional limitations that cannot fulfill the ml-commons inference processor data transformation requirements. Therefore, we propose introducing two response processors: the sorting response processor and the split response processor, to address the functional limitations of JSONPath.
Describe the solution you'd like
Similar as Sort Ingest Processor and Split Ingest Processor, we would like to build a Sort Search Processor and Split Search Processor
Related component
Search
Describe alternatives you've considered
No response
Additional context
No response

@jackiehanyang are these Response processors? Or do we need both Request and Response processors?

authors: dbwiddis jackiehanyang

repo: opensearch-project/OpenSearch


text:
Add TLSv1.3 in jdk.tls.client.protocols systemProp in gradle.properties

Description
This system property was introduced in https://github.com/opensearch-project/OpenSearch/commit/34ccd3f0dcab434302a68ef04d3a1f92fb80e31b to resolve an issue connecting to services at build time that did not support TLSv1.3.
I'm opening this PR to add TLSv1.3 to this systemProp.
Check List

[ ] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks @cwperks !

authors: cwperks reta


text:
[Backport 2.x] Do not evaluate shard_size and shard_min_doc_count at segment slice level

Description
Backport for #8860
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta @sohami here is the backport PR for https://github.com/opensearch-project/OpenSearch/issues/8860.
Most recent gradle check failed with known flakey tests.


text:
Enable cross-cluster monitor cluster setting

Issue #, if available:
Description of changes:
Enable cross-cluster monitor cluster setting
CheckList:

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Approving assuming CI passes.

Backporting back to v2.14 as the feature received GA launch approval after 2.13 open source release.

The failing test is org.opensearch.alerting.transport.GetRemoteIndexesActionIT > test with remote monitoring disabled.
https://github.com/opensearch-project/alerting/actions/runs/9999216318/job/27639794066?pr=1612#step:5:334
That test suite has a helper function which should be toggling the feature on/off; but it looks like it's failing to disable to feature before the start of that test. Troubleshooting that test.

The failing test is org.opensearch.alerting.transport.GetRemoteIndexesActionIT > test with remote monitoring disabled. https://github.com/opensearch-project/alerting/actions/runs/9999216318/job/27639794066?pr=1612#step:5:334
That test suite has a helper function which should be toggling the feature on/off; but it looks like it's failing to disable to feature before the start of that test. Troubleshooting that test.

Fixed in commit https://github.com/opensearch-project/alerting/pull/1612/commits/478eb4680dfe842f113e91e9c5844d0fbeb9fa0d

authors: AWSHurneyt goyamegh

repo: opensearch-project/alerting


text:
Add a function in the DataPrepper Expressions to check if a string contains another string

Is your feature request related to a problem? Please describe.
Add a function in the DataPrepper Expressions to check if a string contains another string. This is useful to check if a field in the event has a particular prefix/suffix/substring in it.
Describe the solution you'd like
Proposal is to add containsSubstring function to DataPrepper expressions which can take string literal or a json pointer to check if a string contains another string as it's substring.
The function signature is as follows
boolean containsSubstring(String string1, String string2)

It returns true if the string in the string2 is a substring of string1, Otherwise it returns false.
It can be used in the following 4 ways
containsSubstring(/jsonPointer, "stringLiteral")
containsSubstring("stringLiteral", /jsonPointer)
containsSubstring("stringLiteral1", "stringLiteral2")
containsSubstring(/jsonPointer1, /jsonPointer2)

Describe alternatives you've considered (Optional)
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I think we should make a decision on how'd we want our expressions to look long term now. Do we want common methods or specific type methods. For example: Do we want to support a single function called contains which can support only strings and jsonPointers referencing strings in this first iteration.  But then can be extended to support other data types like sets, maps, etc. in future revisions. Or do we want to have separate functions for  different data types? I see the benefits and draw backs of both. Have we decided on how we will approach this?

repo: opensearch-project/data-prepper