text:
inconsistent CLI interface for help

If you have a bug report please let us know the following:

Operating system: 10.11
Apex Version: 0.10.2

apex does no support apex -h nor apex --help, but the aws-cli style apex help (aws help). Except when it comes to commands: apex build --help.
Decide on -h and --help, or just help

apex --help and apex -h work just fine for me? All three work just fine

closing as can't reproduce, but feel free to re-open if there's something else weird going on there

authors: andreineculau tj

repo: apex/apex


text:
Auto scale Y axis on zoom of x axis (Line graphs)

Hi firstly this library is awesome!
I was wondering if it would be possible to add an option, so to auto scale the y axis of a time series(line graph) on zoom of only the x axis.
Describe the solution you'd like
If I have an outlier it can ruin the y axis for all other points. I would be prefect if the y axis would auto scale to the y axis values within the zoomed selection, when using only the X axis zoom.
Describe alternatives you've considered
Alternatively, would it be possible to implement a possitiveOnly option for the zoom options.chart.zoom.type: 'xy'. Which would prevent the user selecting an area on the negative side of the Y/X axis.
Additional context
Codepen detailing the outlier issue described above - https://codepen.io/T-Pullen/pen/wZpJJg
Thank you for taking the time!

Hi @tomtelegraph,
Thanks for the kind comment!
Regarding your suggestion of autoScaleYAxis, there was an attempt in the past to make it work, but unfortunately, it didn't work out great in multi-axis charts.
The option is chart.zoom.autoScaleYaxis located here and is not production ready.
I will revisit that part and fix the multi-axis issue within it to make it production ready.
Thanks!

Closing as duplicate of #246

source: gharchive/issue

authors: junedchhipa tomtelegraph

license: MIT

license_type: permissive

license_source: github-api


text:
Consistent output of admin CLI

Currently some of the commands use ad-hoc format, e.g.
console.log(`Requester admin: ${requesterAdmin}`);

and some output the whole JSON:
console.log(toJSON(parameters));

The output of the commands should be consistent and I'd say it's better to avoid ad-hoc format and just display the data. Reasons:

It's easier to test - no need to strip the ad-hoc prefix
Easier to process if someone uses the CLI in some pipeline - for the same reason as 1)
The output of the command has enough context for user to know what is returned - it should be clear even from the command name, but there is also description
We can wrap the response from blockchain as JSON in the SDK - e.g. return {"requesterIndex": "2"} from the CLI.

We could also introduce something like --pretty flag to pretty print json, but I think it's not necessary as users can just format it in code editor or online tool.

I know it's not really a bug-fix, but it's closer to that than an enhancement.

Tracked by https://api3dao.atlassian.net/browse/AN-151

authors: Siegrift bbenligiray


text:
Update deps

The ethers library must be explicetely pinned down such that npm dependency resolution won't load multiple different versions of (ethers) library. That caused problems with TypeChain code generation, because some part of the generated code was using one version and the other part of code a different one.

I closed the dependabot PRs and instead updated manually.

source: gharchive/pull-request


text:
Keeping the fork up to date

eg.  fix(request_uri) use uri host for ssl-server-name

PR is welcome!

I have submit a pr @spacewander

authors: huangnauh nanamikon spacewander


text:
Move out the remaining materials from legacy Gitlab

For example, a development page still links materials hosted at Gitlab. We should move these to docs or academy and update links.

@mtrunkat what's the status with this?

I am closing this.

authors: fnesveda mtrunkat

repo: apify/apify-docs


text:
feat: overwrite WebRTC APIs with a recursive ES6 proxy

While this solution is a bit crude, it seems to work in 100% of all cases.
From what I found, it doesn't even trigger scripts inspecting properties of Web API objects (but it also might be that WebRTC API is a bit too obscure for those scripts to even check).
fixes #124

Note to self: this breaks WebRTC altogether (for actual proper usage too), so it should be opt-out? Perhaps {"webrtc": "off"} somewhere in FingerprintGenerationOptions, so all the settings are together?

Any news on this being merged / included in a next release?

authors: barjin hakunin

repo: apify/fingerprint-suite


text:
ad-hoc clean-up

Misc. changes made while performing initial review. Bundled as a circumstantial exception to the rule about PR granularity.

This seems to have grabbed the spurious build failure on the previous one.  Perhaps because the title is the same?  I'll try one more time.

@w4bremer The 5.2 build failed because the docker registry hit a rate limit. I created a new PR but it's picking up on the build failure from the previous one because the commit hash is still the same.  Is there a way to force it to re-run?

@w4bremer The 5.2 build failed because the docker registry hit a rate limit. I created a new PR but it's picking up on the build failure from the previous one because the commit hash is still the same. Is there a way to force it to re-run?

@EpicMaxKanensley no, currently I don't have a simple way to re-run it, if the CI itself fails for other reason. Should not be complicated to add. Right now, we can only reset the internal state. This will then re-run all tests for all open PRs.

Manually re-run the missing Linux build tests and tested against 4.27, 5.5 on Windows. All successful.

repo: apigear-io/template-unreal


text:
Issue with downloadLatest script

Looks like https://github.com/apigee/apigeecli/pull/399 does not properly work with GitHub ubuntu-latest runner.
Evidence:
Run curl -L https://raw.githubusercontent.com/apigee/apigeecli/main/downloadLatest.sh | sh -
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  4307  100  4307    0     0  27631      0 --:--:-- --:--:-- --:--:-- 27608
100  4307  100  4307    0     0  27590      0 --:--:-- --:--:-- --:--:-- 27608
Unable to get latest apigeecli version. Set APIGEECLI_VERSION env var and re-run. For example: export APIGEECLI_VERSION=v1.104
For some reason new grep expression is not executed properly on ubuntu-latest. It worked fine on my local zsh and bash.

Fixed as part #402

authors: EKoczur ssvaidyanathan

repo: apigee/apigeecli

license_source: bigquery


text:
Feature/swagger doc select

Add Swagger documentation select menu to View Documentation page.

@mauriciovieira or @elnzv Could either of you review this code? Please comment here if you take the responsibility.

@mauriciovieira @elnzv PR still work in progress, don't review yet.

@brylie, what is the status, is it ready to be reviewed and merged?

Looks good, great job, @brylie!

authors: bajiat brylie elnzv

repo: apinf/api-umbrella-dashboard

license: mit


text:
🛑 OSC is down

In 6c748ad, OSC (https://openstorage.xyz) was down:

HTTP code: 521
Response time: 339 ms

Resolved: OSC is back up in f0c99fb.

repo: apinter/OSC-mon


text:
Improve schema building

allow define same controller by all loaders (e.g. define in annotations and modify something in neon)
ArrayLoader
modify error messages to make sense for all loaders (currently are annotations-specific)
some tests
own loaders?
extend schema modifying options - middlewares and decorators should be able to describe what they do in openapi schema

Continues in #125 and #126

repo: apitte/core


text:
fix: compatible with snakeyaml-2.x

What's the purpose of this PR
since snakeyaml-2.x has removed empty args constructor, we need use the constructor with options
Which issue(s) this PR fixes:
Fixes #
https://github.com/apolloconfig/apollo/issues/4960
Brief changelog
-    return new Yaml(new SafeConstructor(), new Representer(), new DumperOptions(), loadingConfig);
+   DumperOptions dumperOptions = new DumperOptions();
+   return new Yaml(new SafeConstructor(loadingConfig),
            new Representer(dumperOptions), dumperOptions, loadingConfig);

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Read the Contributing Guide before making this pull request.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit tests to verify the code.
[x] Run mvn clean test to make sure this pull request doesn't break anything.
[x] Update the CHANGES log.

I have read the CLA Document and I hereby sign the CLA

@richieyan 你的合并好像没有成功

Thanks for the PR, friend! Could you please update the CHANGES.md too?
By the way, did you test the new version with the yaml namespace cases?

Thanks for the PR, friend! Could you please update the CHANGES.md too? By the way, did you test the new version with the yaml namespace cases?
OK.
I have tested with snakeyaml 2.0, since the constructor with params already exists in 1.x, so this modification will be compatible with snakeyaml 1.x and snakeyaml 2.x

So now snakeyaml 1.x and snakeyaml 2.x. Has the bug been fixed yet? @richieyan

So now snakeyaml 1.x and snakeyaml 2.x. Has the bug been fixed yet? @richieyan

Yes, you can use snakeyaml 2.x when this PR merged.

Can you tell me how I can bring the repaired code into the project using the jar package @richieyan

Could you please check the repair code as soon as possible and merge PR? Recently, our project needs this repair version very much. Thank you! @nobodyiam

authors: nobodyiam pengronghui richieyan

repo: apolloconfig/apollo-java


text:
Fixed #213 and add prefer local ip address option.

如果运行的机器存在多个出口ip的时候, 可能导致上报到Apollo/实例列表中的ip出现不一致的情况. 通过添加PreferLocalAdress 来控制上报要使用的ip.
PreferLocalAdress 支持使用多个cidr表达式来选择ip. 格式: 172.0.0.1/8,192.0.0.1/8
例如部署的container 有2个ip: 172.16.2.1, 169.254.1.1, 如果要上报172的ip 可以配置PreferLocalAdress = "172.0.0.1/8"

改成PreferSubnet


text:
Source generation fails on scalars with descriptions

Summary
When trying to generate the service sources, Apollo fails to parse any scalar that has a description
Version
2.5.2
Description
Here is an example:
"""
The `AWSURL` scalar type provided by AWS AppSync, represents a valid URL string (Ex: <https://www.amazon.com/>). The URL may use any scheme and may also be a local URL (Ex: <http://localhost/>).  URLs without schemes like "**amazon.com**" or "**www.amazon.com**" are considered invalid. URLs which contain double slashes (two consecutive forward slashes) in their path are also considered invalid.
"""
scalar AWSURL

Trying to compile this fails saying:
Execution failed for task 'generateMainServiceApolloSources'.
>
  Failed to parse GraphQL file /path/to/schema.graphql (1:0)
  Unsupported token `""`
  ----------------------------------------------------
  [3]:
  [4]:"""
  [5]:The `AWSURL` scalar type provided by AWS AppSync, represents a valid URL string (Ex: <https://www.amazon.com/>). The URL may use any scheme and may also be a local URL (Ex: <http://localhost/>).  URLs without schemes like "**amazon.com**" or "**www.amazon.com**" are considered invalid. URLs which contain double slashes (two consecutive forward slashes) in their path are also considered invalid.
  ----------------------------------------------------

The same is true for directive statements it seems

The same is true for directive statements it seems

Apparently this happened because of the "auto discovery" of files in the source set. Once I manually configured the source set the error went away

Apparently this happened because of the "auto discovery" of files in the source set. Once I manually configured the source set the error went away

repo: apollographql/apollo-android


text:
⏱ Benchmark Cache CPU

Cache CPU benchmarking work that will happen after the cache control changes are in place (https://github.com/apollographql/apollo-kotlin/issues/3566).

Closed with https://github.com/apollographql/apollo-kotlin/pull/4284

authors: hwillson martinbonnin

repo: apollographql/apollo-kotlin


text:
fix(parser): add a fix for StringValue node when we start with a backslash

close #227

with this implementation, it will accept strings with a \ and non escaped chars, right? like "aaa \a bbb"

authors: Geal bnjjj

repo: apollographql/apollo-rs


text:
Stitching: Multiple delegations per type overwrite fragments

I'm trying unsuccessfully to stitch more than one (sub)type onto a type.
Below is the definition for my resolvers. typeA and typeB are defined elsewhere. MyRemoteType has fields typeAId and typeBId.
export const MyRemoteType = {
  typeA: {
    fragment: `... on MyRemoteType { typeAId }`,
    resolve (obj, args, context, info) =>
      info.mergeInfo.delegateToSchema({
        schema: typeASchema,
        operation: 'query',
        fieldName: 'typeAbyId',
        args: { id: obj.typeAid },
        context,
        info
      })
  },
  typeB: {
    fragment: `... on MyRemoteType { typeBId }`,
    resolve (obj, args, context, info) =>
      info.mergeInfo.delegateToSchema({
        schema: typeBSchema,
        operation: 'query',
        fieldName: 'typeBbyId',
        args: { id: obj.typeBid },
        context,
        info
      })
  }
}

What I expect
If I run the following query against the server which has stitched everything together
myRemoteTypeById(id: "foo") {
  typeA { id }
  typeB { id }
}

I would expect to see the following query sent downstream
myRemoteTypeById(id: $_v0_id) {
  ... on MyRemoteType {
    typeAId
  }
  ... on MyRemoteType {
    typeBId
  }
}

or possibly
myRemoteTypeById(id: $_v0_id) {
  ... on MyRemoteType {
    typeAId
    typeBId
  }
}

What I see instead
myRemoteTypeById(id: $_v0_id) {
  ... on MyRemoteType {
    ... on MyRemoteType {
      typeBId
    }
  }
}

As you can see, the downstream service is never asked for typeAId, which leads to problems when I need to actually resolve the typeA field.
Am wrong to assume that it should work this way? I can't find any examples where more than one link is defined.
Workarounds

Add typeAId and typeBId to the outermost query (I'm not ok with this...)
Define the fragments like this:

  typeA: {
    fragment: `... on MyRemoteType { typeAId, typeBId }`,
...
typeB: {
    fragment: `... on MyRemoteType { typeAId, typeBId }`,
...

Looks like this is the issue:
https://github.com/apollographql/graphql-tools/blob/master/src/transforms/ReplaceFieldWithFragment.ts#L32

Ah, I see this was fixed in this commit. Seems like it hasn't hit a release yet though.

repo: apollographql/graphql-tools


text:
Emit event on submission completed

Closes #117

Actually apos.emit does not exist in lean frontend mode, which this module is meant to be compatible with. But I have a separate ticket open to confirm with @abea  that all that jquery and apos.emit stuff in content.js isn't actually in use.

I'll wait then :smiley:

Awaiting clarification from #119

OK I was looking at a very old branch, never mind re: jQuery!
However my other issue still stands: there is no apostrophe event bus in lean mode.
So I'm not sure what the best approach is. A custom DOM event could be emitted, perhaps.

This will need some changes because apos.emit doesn't exist in lean mode and this module is lean mode compatible. However, a PR in apostrophe to provide an alternative for lean mode is close to release will appear soon.

💁 apos.utils.emit is now available in apostrophe 2.105 for this update.

Namespacing is good, but I think for 2.x event names should follow the
existing pattern for the events we are already emitting.
On Fri, Mar 27, 2020 at 1:56 PM Alex Bea notifications@github.com wrote:

@abea https://github.com/abea requested your review on: #118
https://github.com/apostrophecms/apostrophe-forms/pull/118 Emit event
on submission completed.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/apostrophecms/apostrophe-forms/pull/118#event-3173460060,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAH27PKWCNWS7DCHVO3YMLRJTSEPANCNFSM4LORTPMA
.

--
THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER
APOSTROPHECMS | apostrophecms.com | he/him/his

Sorry, I didn't see this update. Do you have a suggestion for the names?

You know what, apostrophe-forms:whatever is a good pattern; I'm happy
with it.
On Mon, Apr 6, 2020 at 8:13 AM Ricky Rodríguez Álvarez <
notifications@github.com> wrote:

Sorry, I didn't see this update. Do you have a suggestion for the names?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/apostrophecms/apostrophe-forms/pull/118#issuecomment-609756617,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAH27MEWDHVLUJJ4UCIG3TRLHBPHANCNFSM4LORTPMA
.

--
THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER
APOSTROPHECMS | apostrophecms.com | he/him/his

authors: abea boutell rjrodriguezalvarez97

repo: apostrophecms/apostrophe-forms


text:
has_one with NOT NULL column fails on save

So I have two tables, User and UserProfile.
UserProfile has a user_id with null: fase
When creating my user, it fails because user_id is NULL.
This is my code for create in my user controller
...
def create
    user = User.new
    user.build_profile
    @form = UserForm.new(user)

    if @form.validate(params[:user])
      @form.save # ERROR
...

I think the profile is saved before the user so it still has no id.
I have changed the code to this as a workaround (or maybe this is the right way)
...
def create
    user = User.new
    user.build_profile
    @form = UserForm.new(user)

    if @form.validate(params[:user])
      @form.save do |nested|
        user.profile.assign_attributes(nested[:profile])

        user.save!
      end
...

Is this a bug?

Not a bug, but not really Reform's issue since Reform is a form object and not a AR abstraction. This kind of fine-tuning will go into disposable.
Why don't you just do
@form.sync # writes attributes to models
@form.model.user.save
@form.model.save # or whatever order you need.

BTW, your controller looks like you want to give Trailblazer a go!

authors: apotonick philipnery

repo: apotonick/reform


text:
Fix loopback result

Fixes #141.

pluings -> plugins in https://github.com/steveeJ/cni/commit/539b04fd3e538da9bc4d78f628676be0983a54bd commit message

Thanks @jonboulle :-) Fixed and testcase added.

@steveeJ - this is great!
Could we actually add a test case for del though? I could totally help with this as needed.

@zachgersh sure! I added the testcase.

@steveeJ Awesome! LGTM - once the tests pass ;)

authors: jonboulle steveeJ zachgersh

repo: appc/cni


text:
CLI settings

Currently the AMP CLI requires option -s at each call, and defaults to cloud.atomiq.io.

The Docker CLI uses the -H option to specify the remote server
The Docker CLI checks a few environment variables:

DOCKER_CONFIG The location of your client configuration files.
DOCKER_CERT_PATH The location of your authentication keys.
DOCKER_HOST Daemon socket to connect to.
DOCKER_TLS_VERIFY When set Docker uses TLS and verifies the remote.
HTTP_PROXY
HTTPS_PROXY
NO_PROXY

AMP could behave similarly:

by default AMP tries to connect to a local cluster (127.0.0.1:50101)
AMP checks these environment variables:

AMP_CONFIG The location of your client configuration files.
AMP_CERT_PATH The location of your authentication keys.
AMP_HOST amplifier grpc endpoint to connect to.
AMP_TLS_VERIFY When set Docker uses TLS and verifies the remote.
HTTP_PROXY
HTTPS_PROXY
NO_PROXY

Put as a comment in #1083

authors: bquenin ndegory

repo: appcelerator/amp


text:
larger icon

Better icon for #9
@cheekiatng can you merge?

APPROVED.

authors: FokkeZB cheekiatng

repo: appcelerator/movies


text:
🛑 Hosting server is down

In d7c946d, Hosting server (https://dagobert.jeroenvd.nl) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Hosting server is back up in 95fe360 after 4 hours, 49 minutes.


text:
Replay is not precise

This can be reproduced as follows:

Open Google Maps
Set some kind of reference on the map
Record yourself swipe/move around the map and then going back to the reference
Go back to the reference
Replay the actions

What you'll find is that the position at the end of the replay is not always the same. In other words, replaying doesn't always yield the same results.

I wonder if this is just an extension of this issue: http://stackoverflow.com/a/42632915/493122

Thanks for the report and the stackoverflow thread. I'll try a complicated gesture on Gmap and compare screenshots from multiple replays.

Is your program using low level events with abd shell getevent and adb shell sendevent by any chance? Because I was about to try that to see if it was precise enough.

The input side uses adb shell getevent and the output pipes to https://github.com/openstf/minitouch. In most devices, two input events have an interval between 10ms~20ms. And I measure the time taking to process an event is roughly microsecond level (not accounting for the socket over adb cost). Also in some rate cases, I observe app lags just a bit, causing different replay outcomes.
Anyhow, I will repeat replaying for a couple times and compare the screenshots first.

BTW, sendevent is not precise, cuz every time you send a point you need to create a sendevent process on the device side, which is way too costly. Minitouch has a native executable listening on a socket for incoming input events and directly injects whatever received to the system.

I see.

Hi, I have coded up a script to measure the "visual difference" of different replays, inspired by your methodology. The gist is here. I would refine it and add it to this repo.
Basically it opens a painter app and draws a picture. The visual difference is captured with ImageMagick, in red.
I discover two issues on our side:

it seems that the last operation would miss an UP command, which is a known and closed issue. I've reopened the issue track this. AFAIK, it is a buffering problem. (aimed for 1.0.5 release for now)
I also observe visual difference for the thing I draw on the canvas. This could be caused by the <x,y> imprecision or timing, or both. I will follow up to create a canvas app to compare the MotionEvent it receives with the ones send by our toolkit. If the problem is with <x,y>, it would be just an easy bug to deal with. The timing is more of a limitation, also related to your question on the stackoverflow. See below. (aimed for 1.0.5 release for now)
For timing, we've tried several backends, such as sendevent, MonkeyDevice/Chimp. As I mentioned, sendevent would create a process per point, which totally kills the timing.MonkeyDevice agent on the device is just not as reliable as it should be and we have some initial attempts but later abandoned. Check this if you are interested. The current acceptable backend is openstf/minitouch, which is with current toolkit. After calibrating and some tuning, I believe the toolkit would get better (aimed for 1.0.5 release for now)
I doubt that one can achieve actual "deterministic replays" with whatever those input recording and replaying tools. From our experiences,  even if we can enforce perfect determinism for input events (x,y and timing), the app would still have other non-determinism, notably lags, network activities and Canvas view responsiveness. I suspect the problem you encountered is an add-up of the imprecision of the MonkeyDevice and the Canvas View's problem. Thus for your higher level design, treat these tools, as well as our toolkit, as a "input automation tool" and have some tolerance of the error.

I also post part of this answer to stackoverflow in case other users there are interested.

authors: Jefffrey mingyuan-xia

repo: appetizerio/appetizer-toolkit


text:
Exported OfferDiscountType Enum Values

Today I used patch-package to patch @apple/app-store-server-library@1.1.0 for the project I'm working on.
Description: Exported OfferDiscountType enum, so that they can be referenced in a project.
Here is the diff that solved my problem:
diff --git a/node_modules/@apple/app-store-server-library/dist/index.d.ts b/node_modules/@apple/app-store-server-library/dist/index.d.ts
index 9e38534..1698782 100644
--- a/node_modules/@apple/app-store-server-library/dist/index.d.ts
+++ b/node_modules/@apple/app-store-server-library/dist/index.d.ts
@@ -47,6 +47,7 @@ export { NotificationHistoryResponse } from './models/NotificationHistoryRespons
 export { NotificationHistoryResponseItem } from './models/NotificationHistoryResponseItem';
 export { NotificationTypeV2 } from './models/NotificationTypeV2';
 export { OfferType } from './models/OfferType';
+export { OfferDiscountType } from './models/OfferDiscountType';
 export { OrderLookupResponse } from './models/OrderLookupResponse';
 export { OrderLookupStatus } from './models/OrderLookupStatus';
 export { Platform } from './models/Platform';

This issue body was partially generated by patch-package.

PR 159

repo: apple/app-store-server-library-node


text:
Fix property parsing bug in the cli

This fixes a bug where a property set as -p foo= would be parsed as "true" instead of "".

Why is that a bug? 🤔
I wouldn't expect to have set a property to true if only prop= is set.
Maybe it should report an error instead of using a blank string? 🤔

Why is that a bug?

Because before this fix you couldn't set a property to empty string.

Maybe it should report an error instead of using a blank string?

Why would this be an error? Empty string is a valid property value.

God it. I misunderstood the implementation 😂
This is fine 👌

authors: StefMa stackoverflow

repo: apple/pkl


text:
Accessing a swift struct  from C++ in ping pong

I added a struct in the swift file but on the C++ side I get the error message "no type named ....." .   I use the latest version of cmake.   It would be great if you provided an example for that.

I realise what happens.   When I add something in the swift file and run ninja this does not trigger the generation of the bridge code.   When I call ninja clean; ninja   it works.   So this probably needs a fix in one of the CMakeLists.txt

repo: apple/swift-cmake-examples


text:
Ship release 1.0.5

We'll need to ship the current changes on the release/1.0 branch to avoid warnings when building with recent versions of the Swift Standard Library.
https://github.com/apple/swift-collections/compare/1.0.4...release/1.0
The changes are small enough that it may be okay to only do a limited prerelease testing phase -- going through the full test matrix would be quite time consuming, given the sheer number of Swift releases 1.0 is supporting.

I'm aiming for a quick patch release today, with the bare minimum testing. (Or less, tbh.)
#314 and #315 resolve a couple of outstanding compatibility issues with 5.9. The release/1.0 branch otherwise looks ready to go.

#314 and #315 passed Linux CI testing, but the macOS queue size is currently sitting at 24; given how little CI is actually contributing, it wouldn't have been worth waiting for it, so I merged these small PRs early.
The full test script is running as well as can be expected on Swift 5.7 and 5.9. This will have to do for this patch release. Preparing to tag.

https://github.com/apple/swift-collections/releases/tag/1.0.5

repo: apple/swift-collections


text:
[6.0] Disable test_connectTimeout

Cherry picked from https://github.com/apple/swift-corelibs-foundation/pull/5046
Explanation: Disable flaky test on Linux while we investigate a more robust way to test connection timeout
Scope: Disables one TestURLSession test case
Risk: Minimal
Testing: swift-ci and local package testing on Ubuntu 22.04 and Amazon Linux 2
Reviewer: @parkera

@swift-ci please test

repo: apple/swift-corelibs-foundation


text:
Handle -continue-building-after-errors and add mechanism for stopping build on failure

Fixes Driver/continue-building-after-errors.swift
Long term we probably want to add more to llbuildSwift, so that we can cancel the build there instead of going through all the jobs. We could suspend the jobQueue so it doesn't start anymore. It also feels like llbuild should have a mechanism for throttling parallel builds, so maybe with that the queue could be replaced.

@cltnschlosser What do you think? I like the workload integration in my PR, but I like the way your code stops the build better in your PR. What are your thoughts?

Closing this in favor of #387

authors: cltnschlosser davidungar

repo: apple/swift-driver


text:
Comparison predicate cannot refer to ComparisonResult enum

Given the following predicate:
struct Dummy {
    let stringValue: String
}

let predicate = #Predicate<Dummy> {
    $0.stringValue.caseInsensitiveCompare("a") == .orderedSame
}

Compiler complains that: Member access without an explicit base is not allowed in this predicate.
So let's change it to an explicit base:
let predicate = #Predicate<Dummy> {
    $0.stringValue.caseInsensitiveCompare("a") == ComparisonResult.orderedSame
}

Compiler then complains that Key path cannot refer to enum case 'orderedSame'.
Macro expansion shows that it's now trying to build a key path expression instead of using the enum value:
Foundation.Predicate<Dummy>({
    PredicateExpressions.build_Equal(
        lhs: PredicateExpressions.build_caseInsensitiveCompare(
            PredicateExpressions.build_KeyPath(
                root: PredicateExpressions.build_Arg($0),
                keyPath: \.stringValue
            ),
            PredicateExpressions.build_Arg("a")
        ),
        rhs: PredicateExpressions.build_KeyPath(
            root: PredicateExpressions.build_Arg(ComparisonResult),
            keyPath: \.orderedSame
        )
    )
})

A workaround is to put the enum in a variable:
let orderedSame = ComparisonResult.orderedSame
let predicate = #Predicate<Dummy> {
    $0.stringValue.caseInsensitiveCompare("a") == orderedSame
}

Using Swift from Xcode 15.0 (15A240d).

Thanks for bringing this up! This is a limitation of Predicates currently. Predicate uses KeyPaths to reference properties, but as it stands today Swift does not support KeyPaths for static properties or enum cases. Unfortunately this means that static properties and enum cases cannot be referenced directly in a predicate and the workaround is to do as you have done - create a variable that references the static property or enum case outside of the predicate and then capture it within the closure.
We've also thought about whether we could strictly allow trivial enum cases as a special case within the predicate since their value can't change between predicate evaluations unlike a static property. However, since macros only have syntactic information and not type information, there's unfortunately no way for us to differentiate between a trivial enum case and a static property. So in order to avoid unexpected behavior of static properties (for example, something like Date.now which can change value between predicate invocations) we chose to disallow this set of capabilities within predicates.
Lastly we also looked at whether we can improve the diagnostic here and/or even make a fix it to do this capturing for you. However, again since the macro doesn't have type information, given something like ComparisonResult.orderedSame the macro cannot determine if ComparisonResult is a type with a static property/enum case, or a valid variable named ComparisonResult with an instance member. So for that reason, we're also left with the existing error message you mentioned.
If you have any suggestions, I'm definitely open to ideas if you think of anything clever we can do here! But in the meantime, I think improving this scenario requires changes to the language to provide type information to macros and/or allow keypaths to static properties/enum cases.

Yeah, I think I'd agree with you that adding is...Equal() functions for all of the possible combinations we support might be a bit drastic given StringProtocol is pretty highly used/fundamental. Technically, we could have the macro special-case each of the ComparisonResult cases to allow them, but I also don't quite like that idea because I think it'd be a bit too jarring when that only works for that enum but doesn't work for any other trivial enum cases, especially user-defined ones

authors: axelandersson jmschonfeld

repo: apple/swift-foundation


text:
Description of sending in Flow-Sensitive Isolation Analysis needs more elaboration

https://www.swift.org/migration/documentation/swift-6-concurrency-migration-guide/dataracesafety#Flow-Sensitive-Isolation-Analysis
The text on it is as follows:

Region-based isolation works without any code changes. But a function’s parameters and return values can also explicitly state that they support crossing domains using this mechanism.

func populate(island: Island, with chicken: sending Chicken) async {
    await island.adopt(chicken)
}

The compiler can now provide the guarantee that at all call sites, the chicken parameter will never be subject to unsafe access. This is a relaxing of an otherwise significant constraint. Without sending, this function would only be possible to implement by requiring that Chicken first conform to Sendable.

Based on this, I don't feel like I understand how to reason about using sending. Is the compiler still going to guarantee safety, or is this a foot gun? If it still guarantees safety, how is it any different than omitting sending? Another sentence or two, or a reference to a more detailed explanation, would be helpful.

Yes, I agree. There is no unsafety here. But, this example in isolation doesn't make it clear enough that without sending, this code will not compile because the compile cannot guarantee that chicken can be transferred across domains.

repo: apple/swift-migration-guide


text:
Force slow path header comparison to not inline.

Motivation:
We have a slow path in compareCaseInsensitiveASCIIBytes. On the server
this path will never be hit as to hit it requires having a
non-contiguous String, so we really really want the compiler to use all
its inlining smarts on the fast path instead. Currently it does, but as
Sequence.elementsEqual is inlinable we need to be sure that doesn't
change.
Modifications:
Force the slow path not to be inlined.
Result:
Guarantees about good inlining.

@swift-nio-bot test this please


text:
Remove unsafe assert on Linux

Motivation:
b8055f74672622f5f06abc13f37b630ff9ccb312 added some code to guard against the case when a fd is deregistered while processing ready events. On Linux it also added an assert which tried to verify that the fd in question is not registered anymore via epoll. The problem here is that it may also be closed which will have epoll_ctl fail with EBADF
Modifications:
Remove assert and add test-case which would have triggered the assert.
Result:
No more assertion error on linux.

Thanks to @vlm for reporting...
Also the price for doing something stupid because of a smart-ass idea goes to @normanmaurer 🤦♂ .

repo: apple/swift-nio


text:
[Traits] Replace isDefault with default trait

Motivation
The current spelling uses isDefault per trait to declare the default traits. This makes it hard to see which traits are actually the default traits.
Modification
Instead of using an explicit isDefault per trait this PR now uses a .defaults(enabledTraits:) overload which just uses the "default" trait under the hood. This simplifies the logic tremendously to handle default traits.
Result
Nicer spelling for default traits and easier implementation.

@swift-ci please test

@swift-ci please test

@swift-ci test windows

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci test windows

@swift-ci test windows

repo: apple/swift-package-manager


text:
Accept prerelase and build identifier in tools version

This will make tools version accept prerelease and build identifier i.e.
tools version can be formed using a valid semver 2.0 string. However we
will ignore these extra information right now, and only consider the
major, minor and patch part of the versions. For e.g.:

Input
Interpreted Version

3.0.0
3.0.0

3.1.0-dev
3.1.0

3.1-dev+sha.123
3.1.0

https://bugs.swift.org/browse/SR-4129

WIP

@swift-ci please smoke test

@swift-ci please smoke test


text:
Don't declare attribute names as keywords

They were declared as Keyword only for TokenSpecs (DeclarationAttributeWithSpecialSyntax and TypeAttribute), the attribute names are always parsed as TypeSyntax so those keywords weren't even appear in the parsed syntax tree.
Instead, make those TokenSpecSet to accept .identifier lexemes with specific token text.

@swift-ci Please test

The last commit implements TokenSpec for a fixed text.

@swift-ci Please test

repo: apple/swift-syntax


text:
[SwiftPM][Diagnostics] Missing or misplaced \u{1b}[2K sequence in build output

Describe the bug
I am changing Swift-Colab to use pexpect instead of subprocess.Popen to launch swift build in Swift-Colab. It now handles output lines differently, paying attention to ANSI escape sequences like \u{1b}[2K that clear a line and replace it with something new. This decreases the size of build logs from SwiftPM, but there may be a glitch with how the compiler places these escape sequences. This causes stray colons and periods to appear in output. I replicated this bug using the inline Bash functionality of Colab in Python mode, so it's not a fault of Swift-Colab itself. I have not been able to reproduce this on macOS.
Before (Swift-Colab 1.0 and 2.0)
Installing packages:
	.package(url: "https://github.com/KarthikRIyer/swiftplot", .branch("master"))
		SwiftPlot
		AGGRenderer
With SwiftPM flags: [-Xcc, -isystem/usr/include/freetype2, -Xswiftc, -lfreetype]
Working in: /tmp/tmpboleba0t/swift-install
Fetching https://github.com/KarthikRIyer/swiftplot
Fetched https://github.com/KarthikRIyer/swiftplot (1.38s)
Creating working copy for https://github.com/KarthikRIyer/swiftplot
Working copy of https://github.com/KarthikRIyer/swiftplot resolved at master
[1/77] Compiling lodepng lodepng.cpp
[2/77] Compiling CPPAGGRenderer CPPAGGRenderer.cpp
While building module 'CPPAGGRenderer' imported from /tmp/tmpboleba0t/swift-install/package/.build/checkouts/swiftplot/Sources/AGGRenderer/CAGGRenderer/CAGGRenderer.cpp:2:
In file included from <module-includes>:1:
/tmp/tmpboleba0t/swift-install/package/.build/checkouts/swiftplot/Sources/AGGRenderer/CPPAGGRenderer/include/CPPAGGRenderer.h:38:1: warning: umbrella header for module 'CPPAGGRenderer' does not include header 'savebmp.h' [-Wincomplete-umbrella]
/tmp/tmpboleba0t/swift-install/package/.build/checkouts/swiftplot/Sources/AGGRenderer/CPPAGGRenderer/include/CPPAGGRenderer.h:38:1: warning: umbrella header for module 'CPPAGGRenderer' does not include header 'pixel_formats.h' [-Wincomplete-umbrella]
2 warnings generated.
[3/77] Compiling CAGGRenderer CAGGRenderer.cpp
[4/77] Compiling AGG gpc.c
[5/77] Compiling agg_spline_ctrl.cpp
[6/77] Compiling agg_slider_ctrl.cpp
[7/77] Compiling agg_scale_ctrl.cpp
[8/77] Compiling agg_rbox_ctrl.cpp
...

After (Swift-Colab 2.1):
Installing package:
    .package(url: "https://github.com/KarthikRIyer/swiftplot", .branch("master"))
        SwiftPlot
        AGGRenderer
With SwiftPM flags: ["-Xcc", "-isystem/usr/include/freetype2", "-Xswiftc", "-lfreetype"]
Working in: /opt/swift/packages
Fetching https://github.com/KarthikRIyer/swiftplot
[6688/6688] Fetching objects
Fetched https://github.com/KarthikRIyer/swiftplot (2.08s)
Creating working copy for https://github.com/KarthikRIyer/swiftplot
Working copy of https://github.com/KarthikRIyer/swiftplot resolved at master
Building for debugging...
:
:
umbrella header for module 'CPPAGGRenderer' does not include header 'savebmp.h' [-Wincomplete-umbrella]
umbrella header for module 'CPPAGGRenderer' does not include header 'pixel_formats.h' [-Wincomplete-umbrella]
.
/opt/swift/packages/2/.build/checkouts/swiftplot/Sources/SwiftPlot/Histogram.swift:283:21: warning: initialization of immutable value 'series' was never used; consider replacing with assignment to '_' or removing it
                let series = allSeries[seriesIdx]
                ~~~~^~~~~~
                _

How to reproduce
Here are instructions for how to reproduce the bug via Python mode. For Swift mode (the easier way), just run the SwiftPlot test notebook in Swift-Colab's README.

Make a Colab notebook and only install SwiftPlot as a dependency. To do this, make the following cell and run it once. SwiftPlot will build without errors.

%install-swiftpm-flags $clear
// %install-swiftpm-flags -Xcc -isystem/usr/include/freetype2 -Xswiftc -lfreetype
%install '.package(url: "https://github.com/KarthikRIyer/swiftplot", .branch("master"))' SwiftPlot AGGRenderer

Then make another cell, which will allow you to switch from Swift to Python mode. Run it.

%system echo "python" > "/opt/swift/runtime"

In the GUI, go to the "Runtime" tab at the top. Click "Restart runtime".
Make another cell. You're now in Python mode. This uses Bash commands to repeat the build process, but modifies it by adding the flags -c release -Xswiftc -Onone.

!cd /opt/swift/packages/1 && /opt/swift/toolchain/usr/bin/swift-build -c release -Xswiftc -Onone -Xcc -isystem/usr/include/freetype2 -Xswiftc -lfreetype

Explanation
My guess is it's misplacing or missing a clear escape sequence at the end of the lines. Regarding the 5 lines that look off (:, :, umbrella..., umbrella..., .), they are mirrored by 5 lines in the output in Swift-Colab 2.0 (While..., In..., /tmp..., /tmp..., 2...). They usually constitute the last component of a line after a number or colon. I got the raw binary output of the Stdout, and turned it into an array of UInt8. I ran it through the Swift REPL to convert it back into characters, and found something interesting.
Output for four lines: :, :, umbrella..., umbrella...

Here
["\u{1B}", "[", "2", "K", "\r", "W", "h", "i", "l", "e", " ", "b", "u", "i", "l", "d", "i", "n", "g", " ", "m", "o", "d", "u", "l", "e", " ", "\'", "\u{1B}", "[", "2", "K", "\r", "C", "P", "P", "A", "G", "G", "R", "e", "n", "d", "e", "r", "e", "r", "\u{1B}", "[", "2", "K", "\r", "\'", " ", "i", "m", "p", "o", "r", "t", "e", "d", " ", "f", "r", "o", "m", " ", "\u{1B}", "[", "2", "K", "\r", "/", "o", "p", "t", "/", "s", "w", "i", "f", "t", "/", "p", "a", "c", "k", "a", "g", "e", "s", "/", "2", "/", ".", "b", "u", "i", "l", "d", "/", "c", "h", "e", "c", "k", "o", "u", "t", "s", "/", "s", "w", "i", "f", "t", "p", "l", "o", "t", "/", "S", "o", "u", "r", "c", "e", "s", "/", "A", "G", "G", "R", "e", "n", "d", "e", "r", "e", "r", "/", "C", "A", "G", "G", "R", "e", "n", "d", "e", "r", "e", "r", "/", "C", "A", "G", "G", "R", "e", "n", "d", "e", "r", "e", "r", ".", "c", "p", "p", "\u{1B}", "[", "2", "K", "\r", ":", "\u{1B}", "[", "2", "K", "\r", "2", "\u{1B}", "[", "2", "K", "\r", ":", "\r", "\n", "\u{1B}", "[", "2", "K", "\r", "I", "n", " ", "f", "i", "l", "e", " ", "i", "n", "c", "l", "u", "d", "e", "d", " ", "f", "r", "o", "m", " ", "\u{1B}", "[", "2", "K", "\r", "<", "m", "o", "d", "u", "l", "e", "-", "i", "n", "c", "l", "u", "d", "e", "s", ">", "\u{1B}", "[", "2", "K", "\r", ":", "\u{1B}", "[", "2", "K", "\r", "1", "\u{1B}", "[", "2", "K", "\r", ":", "\r", "\n", "\u{1B}", "[", "2", "K", "\r", "/", "o", "p", "t", "/", "s", "w", "i", "f", "t", "/", "p", "a", "c", "k", "a", "g", "e", "s", "/", "2", "/", ".", "b", "u", "i", "l", "d", "/", "c", "h", "e", "c", "k", "o", "u", "t", "s", "/", "s", "w", "i", "f", "t", "p", "l", "o", "t", "/", "S", "o", "u", "r", "c", "e", "s", "/", "A", "G", "G", "R", "e", "n", "d", "e", "r", "e", "r", "/", "C", "P", "P", "A", "G", "G", "R", "e", "n", "d", "e", "r", "e", "r", "/", "i", "n", "c", "l", "u", "d", "e", "/", "C", "P", "P", "A", "G", "G", "R", "e", "n", "d", "e", "r", "e", "r", ".", "h", "\u{1B}", "[", "2", "K", "\r", ":", "\u{1B}", "[", "2", "K", "\r", "3", "8", "\u{1B}", "[", "2", "K", "\r", ":", "\u{1B}", "[", "2", "K", "\r", "1", "\u{1B}", "[", "2", "K", "\r", ":", "\u{1B}", "[", "2", "K", "\r", " ", "\u{1B}", "[", "2", "K", "\r", "w", "a", "r", "n", "i", "n", "g", ":", " ", "\u{1B}", "[", "2", "K", "\r", "u", "m", "b", "r", "e", "l", "l", "a", " ", "h", "e", "a", "d", "e", "r", " ", "f", "o", "r", " ", "m", "o", "d", "u", "l", "e", " ", "\'", "C", "P", "P", "A", "G", "G", "R", "e", "n", "d", "e", "r", "e", "r", "\'", " ", "d", "o", "e", "s", " ", "n", "o", "t", " ", "i", "n", "c", "l", "u", "d", "e", " ", "h", "e", "a", "d", "e", "r", " ", "\'", "s", "a", "v", "e", "b", "m", "p", ".", "h", "\'", " ", "[", "-", "W", "i", "n", "c", "o", "m", "p", "l", "e", "t", "e", "-", "u", "m", "b", "r", "e", "l", "l", "a", "]", "\u{1B}", "[", "2", "K", "\r", "\r", "\n", "\u{1B}", "[", "2", "K", "\r", "/", "o", "p", "t", "/", "s", "w", "i", "f", "t", "/", "p", "a", "c", "k", "a", "g", "e", "s", "/", "2", "/", ".", "b", "u", "i", "l", "d", "/", "c", "h", "e", "c", "k", "o", "u", "t", "s", "/", "s", "w", "i", "f", "t", "p", "l", "o", "t", "/", "S", "o", "u", "r", "c", "e", "s", "/", "A", "G", "G", "R", "e", "n", "d", "e", "r", "e", "r", "/", "C", "P", "P", "A", "G", "G", "R", "e", "n", "d", "e", "r", "e", "r", "/", "i", "n", "c", "l", "u", "d", "e", "/", "C", "P", "P", "A", "G", "G", "R", "e", "n", "d", "e", "r", "e", "r", ".", "h", "\u{1B}", "[", "2", "K", "\r", ":", "\u{1B}", "[", "2", "K", "\r", "3", "8", "\u{1B}", "[", "2", "K", "\r", ":", "\u{1B}", "[", "2", "K", "\r", "1", "\u{1B}", "[", "2", "K", "\r", ":", "\u{1B}", "[", "2", "K", "\r", " ", "\u{1B}", "[", "2", "K", "\r", "w", "a", "r", "n", "i", "n", "g", ":", " ", "\u{1B}", "[", "2", "K", "\r", "u", "m", "b", "r", "e", "l", "l", "a", " ", "h", "e", "a", "d", "e", "r", " ", "f", "o", "r", " ", "m", "o", "d", "u", "l", "e", " ", "\'", "C", "P", "P", "A", "G", "G", "R", "e", "n", "d", "e", "r", "e", "r", "\'", " ", "d", "o", "e", "s", " ", "n", "o", "t", " ", "i", "n", "c", "l", "u", "d", "e", " ", "h", "e", "a", "d", "e", "r", " ", "\'", "p", "i", "x", "e", "l", "_", "f", "o", "r", "m", "a", "t", "s", ".", "h", "\'", " ", "[", "-", "W", "i", "n", "c", "o", "m", "p", "l", "e", "t", "e", "-", "u", "m", "b", "r", "e", "l", "l", "a", "]", "\u{1B}", "[", "2", "K", "\r", "\r", "\n"]

Pay attention to the very end of the first line (a : line) and the very beginning of the next line (also a line that becomes just : in Swift-Colab 2.1). I extracted it from the raw output. As a string, it is this:
:2:
In

As bytes, it is this:
":", "\u{1B}", "[", "2", "K", "\r", "2", "\u{1B}", "[", "2", "K", "\r", ":", "\r", "\n", "\u{1B}", "[", "2", "K", "\r", "I", "n"

Notice that there is no \u{1B}[2K between the last colon and the \r\n after it. I hypothesize that there should be, and that's what's causing the bug.
Other remarks
I found this in Swift-Colab, but it should be possible to reproduce anywhere. Perhaps it's specific to the Linux that runs on Google Colaboratory (Ubuntu 18.04), or it happens on Linux somewhere else. The Python Bash functionality is not something I made; it's part of the IPython repo and like a terminal app. Thus, if someone else compiled SwiftPlot on Linux via command-line, they would get the same problem. This should happen when compiling any Clang module with that umbrella header error. Thus, it is not specific to SwiftPlot either.

CC: @KarthikRIyer

This also creates some nice text colorization. How does this problem not occur in the macOS Terminal app?

This seems strangely fixed when I built SwiftPlot on the May 11, 2022 toolchain. I need to investigate further.

Problem (5) in https://github.com/philipturner/swift-colab/issues/14 was the source of this bug report. Problem (1) originated from the same bug and disappeared in recent toolchains.

The fix also went into the Swift 5.6.2 release toolchain. It seems like a bug fix was cherry-picked from apple:main between 5.6.1 and 5.6.2.

It looks like the bug is not fixed on the Swift 5.6.2 release toolchain:
Installing package:
    .package(url: "https://github.com/KarthikRIyer/swiftplot", .branch("master"))
        SwiftPlot
        AGGRenderer
With SwiftPM flags: []
Working in: /opt/swift/packages
Fetching https://github.com/KarthikRIyer/swiftplot
[6703/6703] Fetching objects
Fetched https://github.com/KarthikRIyer/swiftplot (2.40s)
Creating working copy for https://github.com/KarthikRIyer/swiftplot
Working copy of https://github.com/KarthikRIyer/swiftplot resolved at master
Building for debugging...
:
:
umbrella header for module 'CPPAGGRenderer' does not include header 'savebmp.h' [-Wincomplete-umbrella]
umbrella header for module 'CPPAGGRenderer' does not include header 'pixel_formats.h' [-Wincomplete-umbrella]
2 warnings generated.

But it is fixed on the 2022-08-09 snapshot:
Installing package:
    .package(url: "https://github.com/KarthikRIyer/swiftplot", .branch("master"))
        SwiftPlot
        AGGRenderer
With SwiftPM flags: []
Working in: /opt/swift/packages
Fetching https://github.com/KarthikRIyer/swiftplot
Fetched https://github.com/KarthikRIyer/swiftplot (2.12s)
Creating working copy for https://github.com/KarthikRIyer/swiftplot
Working copy of https://github.com/KarthikRIyer/swiftplot resolved at master
Building for debugging...
While building module 'CPPAGGRenderer' imported from /opt/swift/packages/1/.build/checkouts/swiftplot/Sources/AGGRenderer/CAGGRenderer/CAGGRenderer.cpp:2:
In file included from <module-includes>:1:
/opt/swift/packages/1/.build/checkouts/swiftplot/Sources/AGGRenderer/CPPAGGRenderer/include/CPPAGGRenderer.h:38:1: warning: umbrella header for module 'CPPAGGRenderer' does not include header 'savebmp.h' [-Wincomplete-umbrella]
/opt/swift/packages/1/.build/checkouts/swiftplot/Sources/AGGRenderer/CPPAGGRenderer/include/CPPAGGRenderer.h:38:1: warning: umbrella header for module 'CPPAGGRenderer' does not include header 'pixel_formats.h' [-Wincomplete-umbrella]
2 warnings generated.
[88/88] Linking libjupyterInstalledPackages1.so
Build complete! (32.61s)
=== ------------------------------------------------------------------------ ===
=== The following Clang modules cannot be imported in your source code until ===
=== you restart the runtime. If you do not intend to explicitly import       ===
=== modules listed here, ignore this warning.                                ===
=== ["lodepng", "CFreeType", "CPPAGGRenderer", "AGG", "CAGGRenderer"]
=== ------------------------------------------------------------------------ ===

Both are using the latest release of Swift-Colab. Therefore, I will mark this issue as resolved.

repo: apple/swift


text:
[WIP] libSyntax: Use Parser to generate integer literal syntax.

This patch tries to teach parser to generate libSytnax tree along with our existing ASTs. Adopting a bottom-up fashion, we generate syntax entity for integer literal expression as the start point.

@nkcsgexi Excited to see the infrastructure for this!

@harlanhaskins still several pending things before review : )

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@DougGregor @harlanhaskins Could you please take a look at this patch? does the infrastructure of parsing libSyntax entities make sense to you?

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 3e5e161449ab5f9a056d55ef2056f95b69238d1f

Build failed
Swift Test Linux Platform
Git Sha - 3e5e161449ab5f9a056d55ef2056f95b69238d1f

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - c2bc4d5a79b1d70741682fb973fb59d48f1ff38c

Build failed
Swift Test OS X Platform
Git Sha - c2bc4d5a79b1d70741682fb973fb59d48f1ff38c

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

I think this is causing build failures of the form "'swift/Syntax/SyntaxNodes.h' file not found". I'm going to revert it unless you have an immediate fix.
https://ci.swift.org/job/oss-swift_tools-RA_stdlib-DA_test-simulator/77/

@gparker42 I can fix this by forward-declaring syntax::SourceFileSyntax in Module.h which will remove the implicit dependency.

@gparker42 Ah, never mind, I can't forward declare this. The fix for this is more complex. Go ahead and revert and I'll find a good way to fix this.

The issue here is that the inclusion of SyntaxNodes.h in Module.h means that the downstream targets that include Module.h need to depend on swift-syntax-generated-headers. Unfortunately, tons of downstream targets include Module.h.

So either we add that dependency to everyone that includes Module.h, or we...sigh...just commit the generated Syntax node files...

@gparker42 Thank you for reverting it! I'll take a look later.

authors: gparker42 harlanhaskins nkcsgexi swift-ci


text:
SIL Optimizer: Re-run predictable memory optimizations in performance pipeline

Should recover the performance degradation observed in https://github.com/apple/swift/pull/15894.

Build comment file:
Summary for master smoketest
Unexpected test results, excluded stats for ReactiveCocoa
No regressions above thresholds

Debug

debug brief
debug detailed

Release

release brief
release detailed

Debug

debug brief

Regressed (0)

name
old
new
delta
delta_pct

Improved (0)

name
old
new
delta
delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (2)

name
old
new
delta
delta_pct

LLVM.NumLLVMBytesOutput
40,889,658
40,893,346
3,688
0.01%

time.swift-driver.wall
74.7s
74.3s
-410.2ms
-0.55%

debug detailed

Regressed (0)

name
old
new
delta
delta_pct

Improved (0)

name
old
new
delta
delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (23)

name
old
new
delta
delta_pct

AST.NumImportedExternalDefinitions
91,038
91,038
0
0.0%

AST.NumLoadedModules
12,956
12,956
0
0.0%

AST.NumTotalClangImportedEntities
270,127
270,127
0
0.0%

AST.NumUsedConformances
8,719
8,719
0
0.0%

IRModule.NumIRBasicBlocks
125,877
125,877
0
0.0%

IRModule.NumIRFunctions
74,251
74,251
0
0.0%

IRModule.NumIRGlobals
68,657
68,657
0
0.0%

IRModule.NumIRInsts
1,398,771
1,398,771
0
0.0%

IRModule.NumIRValueSymbols
127,734
127,734
0
0.0%

LLVM.NumLLVMBytesOutput
40,889,658
40,893,346
3,688
0.01%

SILModule.NumSILGenFunctions
43,294
43,294
0
0.0%

SILModule.NumSILOptFunctions
73,914
73,914
0
0.0%

Sema.NumConformancesDeserialized
446,355
446,355
0
0.0%

Sema.NumConstraintScopes
913,260
913,260
0
0.0%

Sema.NumDeclsDeserialized
2,666,636
2,666,636
0
0.0%

Sema.NumDeclsValidated
158,807
158,807
0
0.0%

Sema.NumFunctionsTypechecked
52,252
52,252
0
0.0%

Sema.NumGenericSignatureBuilders
64,089
64,089
0
0.0%

Sema.NumLazyGenericEnvironments
512,987
512,987
0
0.0%

Sema.NumLazyGenericEnvironmentsLoaded
42,573
42,573
0
0.0%

Sema.NumLazyIterableDeclContexts
370,108
370,108
0
0.0%

Sema.NumTypesDeserialized
2,837,770
2,837,767
-3
-0.0%

Sema.NumTypesValidated
219,848
219,848
0
0.0%

Release

release brief

Regressed (0)

name
old
new
delta
delta_pct

Improved (0)

name
old
new
delta
delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (2)

name
old
new
delta
delta_pct

LLVM.NumLLVMBytesOutput
30,500,020
30,438,820
-61,200
-0.2%

time.swift-driver.wall
161.4s
162.3s
876.6ms
0.54%

release detailed

Regressed (0)

name
old
new
delta
delta_pct

Improved (0)

name
old
new
delta
delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (23)

name
old
new
delta
delta_pct

AST.NumImportedExternalDefinitions
8,764
8,764
0
0.0%

AST.NumLoadedModules
406
406
0
0.0%

AST.NumTotalClangImportedEntities
25,382
25,382
0
0.0%

AST.NumUsedConformances
8,724
8,724
0
0.0%

IRModule.NumIRBasicBlocks
174,150
174,047
-103
-0.06%

IRModule.NumIRFunctions
57,692
57,546
-146
-0.25%

IRModule.NumIRGlobals
54,736
54,751
15
0.03%

IRModule.NumIRInsts
1,397,399
1,394,062
-3,337
-0.24%

IRModule.NumIRValueSymbols
101,722
101,584
-138
-0.14%

LLVM.NumLLVMBytesOutput
30,500,020
30,438,820
-61,200
-0.2%

SILModule.NumSILGenFunctions
21,962
21,962
0
0.0%

SILModule.NumSILOptFunctions
38,615
38,570
-45
-0.12%

Sema.NumConformancesDeserialized
139,868
139,868
0
0.0%

Sema.NumConstraintScopes
800,931
800,931
0
0.0%

Sema.NumDeclsDeserialized
225,625
225,600
-25
-0.01%

Sema.NumDeclsValidated
28,507
28,507
0
0.0%

Sema.NumFunctionsTypechecked
10,626
10,626
0
0.0%

Sema.NumGenericSignatureBuilders
6,458
6,458
0
0.0%

Sema.NumLazyGenericEnvironments
33,283
33,278
-5
-0.02%

Sema.NumLazyGenericEnvironmentsLoaded
4,519
4,519
0
0.0%

Sema.NumLazyIterableDeclContexts
21,283
21,283
0
0.0%

Sema.NumTypesDeserialized
277,227
277,180
-47
-0.02%

Sema.NumTypesValidated
40,456
40,456
0
0.0%

This is a fairly brute force way to make sure we don't lose any performance. Hopefully we can win back the extra compile time later.

authors: atrick slavapestov swift-ci


text:
[Import as member] First draft of renaming CG APIs

What's in this pull request?

[Import as member] First draft of renaming CG APIs

This includes several large manual renaming of CG APIs where we want
different results than what the inference system produces.

Several CG APIs are meant to be imported as nonswift, so mark them so
in our API notes.

Resolved bug number: (SR-)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

@swift-ci please test

@swift-ci please test

@swift-ci please test

Reverted in #2110 because this broke the build.

That build failure might be another "delete the module cache" problem like this one earlier today:
https://github.com/apple/swift/commit/65ae6896d664fd17fcdc9a28a266510740b8e4d4#commitcomment-17034192

authors: gparker42 milseman tkremenek


text:
[SE-0258] Rename init(initialValue:) --> init(wrappedValue:).

Addresses core team decision on acceptance of property wrappers.
Fixes rdar://problem/48871069.

@swift-ci please smoke test and merge


text:
[AutoDiff upstream] Update @differentiable syntax.

Clean up unused syntax components and fix description strings.
Friend PR: https://github.com/apple/swift-syntax/pull/179
Resolves comments: https://github.com/apple/swift/pull/27506#pullrequestreview-315663528

Must be tested with https://github.com/apple/swift-syntax/pull/179 so that --swiftsyntax-verify-generated-files passes.

https://github.com/apple/swift-syntax/pull/179
@swift-ci smoke test

@akyrtzi: could you please help merge this PR and https://github.com/apple/swift-syntax/pull/179?

authors: akyrtzi dan-zheng


text:
XFAIL a test that fails due to a new GSB assert

I added this test case in https://github.com/apple/swift/pull/36402;
the change in https://github.com/apple/swift/pull/36411 correctly
flags some bogus same-type requirements in a minimized signature
and asserts.

@swift-ci Please smoke test


text:
[5.6] Bump SwiftArgumentParser checkout to 1.0.3

This changes the checked-out version of swift-argument-parser from 1.0.1 to 1.0.3 in update-checkout-config.json. This pulls in a bug fix needed by SwiftPM (rdar://88097258).
Resolves rdar://88097258.
(cherry picked from commit 182e194b7eebc0dfd3929f68718ab86aea59af0f)

@swift-ci test


text:
Start removing ArchetypeType::getSelfProtocol()

This was supposed to be part of my previous PR, but I ran into some lldb troubles (hopefully resolved now).

@swift-ci Please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 97945b26dedcb55aa63348c1cb42cce3726c580c
Test requested by - @slavapestov

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 97945b26dedcb55aa63348c1cb42cce3726c580c
Test requested by - @slavapestov

@swift-ci Please test

@swift-ci Please test

authors: slavapestov swift-ci


text:
[interop][SwiftToCxx] add support for members in class types

Also add docs for class inheritance and update status page for classes.

@swift-ci please test

@swift-ci please test source compatibility

@swift-ci please test source compatibility

@swift-ci please test source compatibility


text:
Witness thunk does not need to hop when the witness decl is accessible from anywhere

Fixes rdar://96906314.

@swift-ci please test


text:
Get the compiler building again on 32-bit architectures

I've had to use this since earlier in the year when cross-compiling the toolchain for Android armv7, along with a version of apple/llvm-project#5883.
@CodaFi, since this is a small modification to your #41743, please review whenever you get back from winter break.

Pinging @CodaFi, small pull.

@swift-ci smoke test

Windows CI failure when building libdispatch is unrelated.

Omw I love u pete
On Thu, Jan 5, 2023, 10:30 AM Robert Widmann @.***>
wrote:

Merged #62780 https://github.com/apple/swift/pull/62780 into main.
—
Reply to this email directly, view it on GitHub
https://github.com/apple/swift/pull/62780#event-8162369784, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AU4K6KE5JMLKNBET2WQPDHTWQ4ALPANCNFSM6AAAAAATJZO3VI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

authors: CodaFi Mztea928 buttaface


text:
AST: Fill in ASTContext::getSwift59Availability() [5.9]

Description: Fill in stub implementation of ASTContext::getSwift59Availability().

Scope of the issue: Provides a more meaningful error message when you attempt to declare a variadic nominal type on an older deployment target.

Risk: None, hopefully!

Reviewed by: @lorentey

@swift-ci Please test


text:
Move regex literal parsing logic from SwiftCompilerSources to ASTGen

ASTGen always builds with the host Swift compiler, without requiring bootstrapping, and is enabled in more places. Move the regex literal parsing logic there so it is enabled in more host environments, and makes use of CMake's Swift support. Enable all of the regex literal tests when ASTGen is built, to ensure everything is working.
Remove the "AST" and "Parse" Swift modules from SwiftCompilerSources, because they are no longer needed.

@swift-ci please smoke test

@swift-ci please clean smoke test Linux

@swift-ci please clean smoke test macOS

@swift-ci please smoke test

Seems like maybe we should move lib/ASTGen to something like swiftlib. Or maybe this all just becomes SwiftCompilerSources once we've moved that across as well.

I don't know if we want a swiftlib kind of thing, or a bunch of different libraries in various lib subdirectories. They're going to end up being intertwined with the C++ libraries.

Seems like maybe we should move lib/ASTGen to something like swiftlib. Or maybe this all just becomes SwiftCompilerSources once we've moved that across as well.

I don't know if we want a swiftlib kind of thing, or a bunch of different libraries in various lib subdirectories. They're going to end up being intertwined with the C++ libraries.

That's fine too, lib/ASTGen is just an odd mix now. SwiftCompilerSources and lib/ASTGen are also open-able as packages, we could do that in just lib as well but right now that would involve excluding all the other directories.

Thanks for doing this: I just applied this pull to the Sep. 2 trunk source snapshot and was able to build a Swift compiler natively on Android that supports regex literals again and Macros for the first time. Any plans to backport this patch to 5.9?

Thanks for doing this: I just applied this pull to the Sep. 2 trunk source snapshot and was able to build a Swift compiler natively on Android that supports regex literals again and Macros for the first time. Any plans to backport this patch to 5.9?

Fantastic! Yes, I'm going to address review comments and back port this patch to 5.9.

@swift-ci please smoke test

I went ahead and backported this pull to 5.9, slapped it up as a gist so you don't have to repeat that work. Haven't tried compiling it with the 5.9 branch yet, will do that next.

@swift-ci please test

@finagolfin we've got Windows CI updated and macros support landed there (https://github.com/apple/swift/pull/68334), so now it's time to get this tested and merged

@swift-ci please build toolchain Windows

@DougGregor, sounds good, I'm currently cross-compiling my 5.9 version of this pull for Android. It appears that portions of #66044 will also need to be backported to 5.9, or the 5.9 version of this pull will have to be adapted for that bridging pull not being in 5.9.

Linux CI failed when testing lldb:
Error output:
error: error while processing module import: error: <EXPR>:7:2: error: expected a macro identifier for a pound literal expression
#/Order from <(.*)>, type: (.*), count in dozen: ([0-9]+)/#

@swift-ci please test Linux

@swift-ci please test

This will need to be updated for #68408.

Dusting this off now and resolving the conflicts.

https://github.com/apple/llvm-project/pull/7550
@swift-ci please test

https://github.com/apple/llvm-project/pull/7550
@swift-ci please test

https://github.com/apple/llvm-project/pull/7550
@swift-ci please test

https://github.com/apple/llvm-project/pull/7550
@swift-ci please smoke test macOS

The macOS test never actually got started properly. Trying again...

https://github.com/apple/llvm-project/pull/7550
@swift-ci please test macOS

Please test with following PRs:
apple/llvm-project#7550
https://github.com/apple/swift-installer-scripts/pull/210
@swift-ci please build toolchain Windows platform

Please test with following PRs:
https://github.com/apple/llvm-project/pull/7550
https://github.com/apple/swift-installer-scripts/pull/210
@swift-ci please build toolchain Windows platform

https://github.com/apple/llvm-project/pull/7550
@swift-ci please test

I have backported this pull to Swift 5.9 and am happy to report a working Swift 5.9 package with regex literals again on Android in the Termux app. I also backported #66033 and #66044 there, as this pull relies on those changes that aren't in the 5.9 branch.
I've also backported #68408 and apple/swift-syntax#2173 and applied some changes so Swift Syntax can be cross-compiled (which I'll upstream next), so that Macros work natively on Android.

This was already done

authors: DougGregor bnbarham compnerd finagolfin


text:
[cxx-interop] Do not crash when synthesizing a base method call

rdar://114823867

any way to test it?

Hmm, I'm not really sure when the base method would be nullptr (perhaps when it is unsafe?), let me think

Let's merge this for now, I'll try to come up with a test case in another related patch I'm working on

authors: egorzhdan hyp


text:
AsyncSequence conformance fixes

Fix two issues that make AsyncSequence and AsyncIteratorProtocol conformances harder than necessary:

When providing only a next() that uses typed throws, infer the Failure type from the thrown error type of next(). (rdar://125446918)
Add a default implementation of next() in terms of next(isolation:), so conforming types can implement only the latter. (rdar://125447861)

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test Linux


text:
chore: Added README.md

To quickly configure and use linter in VS Code Editor.

Oh, one thing I forgot -- I'm not sure if it needs to be in this document, but might be good to mention that Vale is also usable as a CLI tool, in case anyone doesn't use VSCode.

@spark-c / @sharat87 - Could you do a final review? I guess it's good to go.

authors: jnikhila spark-c

repo: appsmithorg/appsmith-docs


text:
[Task]: Survey of plugins - testability

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks
When I create a datasource, I can see the "Test" button. For some plugins, this test actually establishes a connection to the datasource, and for some, the test merely checks whether mandatory configurations a provided.
The scope of this task is to list down such datasources that support a "full test" and those that only support a "partial test" today.

@ajinkyakulkarni this needs estimation

repo: appsmithorg/appsmith


text:
[Task]: POC automatic detection of break points in UI on small screen sizes

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks

Assign minimum viable dimensions to basic widgets.
Using the absolute positioning and required dimensions, determine which children are overlapping in an app.

Not relevant

authors: KelvinOm prsidhu


text:
Fix restriction error in Single Domain - CMS Hubspot

They suggest in “Single Domain” method even without adding data into mandatory field the user is displayed with Results.

Note: I will investigate why Domain ID is not being requested.

Update: Now Domain ID is only ID
I found that the problem is because GET
/cms/v3/domains/ is the Api of Current Domain so when you do not put the ID is not a problem for the system because recognize like a Current Domain. I make the decision of change the ID to not required this means in both cases they have to work.


text:
[Task]: Remove explorer/widgets tab view from the explorer

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks
No response

This is no longer required ✅


text:
[Bug]: Quick dismiss does not work in one particular scenario

Is there an existing issue for this?

[X] I have searched the existing issues

Description
If for a widget we configure the onBlur property such that when focus is shifted to a different tab/session, the Modal does not get dismissed after returning back to the application and clicking anywhere outside it (even when the Quick Dismiss property is enabled for the Modal).
Steps To Reproduce

D&D an input widget.
Set Show Modal option for the onBlur property and make sure that Quick Dismiss property for the Modal is enabled.
Focus on the input widget.
Now shift the focus by clicking on some other tab.
Go back to the application.
You'll see the Modal opened as expected.
Click anywhere outside the Modal.

Expected: The Modal should get dismissed.
Actual: The Modal does not get dismissed.
Public Sample App
No response
Environment
Production
Issue video log
https://www.loom.com/share/efe0d633529c432b95eb6d4a90c555cc
Version
Cloud

@shadabbuchh the video you shared shows clearly why this is happening

when you focus focus on the input the cursor appears.
when you change the tab the oBlur event is executed.
When you switch back the tab, the modal shows up because of the prev onBlur event, but if you observe the input is still focused (cursor still blinking)
Because of the above point, once you click outside the modal, the dismiss does happen but the input also fires the onBlur event.

cc @dilippitchika what do you think should happen here?

authors: shadabbuchh somangshu


text:
[Epic] Widget and Canvas APIs

Multiple entries for the same widget in widgets pane with different props
Theme-ing for the application
Theme-ing for the widgets
Grouped widgets to become a re-usable template
Grouped widgets + API become a re-usable template

Closing this in light of #3369 #5229

authors: Nikhil-Nandagopal riodeuno


text:
[Enhancement] Login on incorrect credentials, email field should retain the entered email.

Summary
On the login screen, if an incorrect email or password is entered, both the email and password fields are reset.
Ideally, the entered email should be retained and the password can be cleared off.

Can you assign me? would love to contribute.

@pawan43563 For sure! Please go ahead

Hello @mohanarpit ,could you please confirm that if this issue is still open or not ?

hi @areyabhishek @Nikhil-Nandagopal @areyabhishek @ganganimaulik
I noticed there's an open issue 7803 in this repository, and I'm interested in working on it. Could you please confirm if the issue is still open and whether it's available for assignment? If so, I'd appreciate it if it could be assigned to me.
Thank you!

@Praval791 go for it. We already have a PR open for it but it was never merged. You can work off that

Hello @Nikhil-Nandagopal, I'm facing issues with setting up this app on my local system. Could you please direct me to a community or support forum where I can seek assistance with this?

@Praval791 you can join our discord


text:
[Bug]  [Low]APIs should work without specifying https / http

When we integrate a REST API in an Appsmith application, we should be able to hit the endpoint even if there's no http/https appended by the user to the URL.
By default the Appsmith proxy should initiate requests over http for such API invocations.

Hey @Nikhil-Nandagopal  you can assign me this.

@spielers It's all yours! 🎉
Please don't forget to read the Contribution Guidelines. Would appreciate if you can open a PR within the next 2 days.
Also, check out the Appsmith Challenge where you can win some cool swag by inviting your friends to contribute to this project as well.

For this issue, you'll have to make modifications to the RestApiPlugin in the appsmith-plugins maven module. Tag me in a comment incase you are stuck or need any clarifications.

Is this bug being actively worked upon?

@spielers Any updates?

Yeah work in progress shortly I'll make a PR
Thanks
On Mon, 19 Oct, 2020, 8:14 am satbir121, notifications@github.com wrote:

@spielers https://github.com/spielers Any updates?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/appsmithorg/appsmith/issues/944#issuecomment-711478967,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALO3RDVQFXFBWUSGE75GENLSLORXFANCNFSM4SEX2IQA
.

I am sorry @spielers, finished working on it right when you commented.
@mohanarpit only mentioned RestApiPlugin, but RapidApiPlugin had similar code, so I believe it might also be necessary there.
Are the changes in #1266 acceptable?

Verified the issue and works as expected

authors: jrcamelo karmanya007 mohanarpit prapullac satbir121 spielers


text:
feat: Add feature for widgets to have non-serialisable properties

Description
Adds feature for widgets to have non-serialisable widget configuration
This allows us to have these properties, while also not having to send it to the workers

[ ] Add WidgetConfiguration property canvasHeightOffset
[ ] Add a non-serialisable widget config registry (enum)
[ ] Skip adding this to the redux store when registering a widget
[ ] Store in memory, these properties as a part of the WidgetFactory

Fixes #18118
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Internal change: Needs existing tests to pass

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
- [NA] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
- [NA] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
- [NA] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organised project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reviewing all Cypress test

/ok-to-test sha=2f10177

/ok-to-test sha=1558ae3

authors: ankurrsinghal riodeuno


text:
update dsl and separate test specs

Pull Request Template
Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Split Listv2_event_bindings test into two files.
Update DSLs to add the missing dynamic height and positioning properties

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Cypress

/ok-to-test sha=8d4c85e

/ok-to-test sha=1155637


text:
Use correct function name in documentation for meta properties

Pull Request Template
Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change
Links to Notion, Figma or any other documents that might be relevant to the PR

Add a TL;DR when description is extra long (helps content team)

Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

Manual
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

@rajatagrawal Thanks for the PR.
A few details to note:

The Semantic PR checks for a valid PR name format. So we need to add a chore|fix|feat prefix in the PR name. chore: update function name in documentation
The PR template needs to be detailed. In this PR's case, most of it can be ignored or mentioned as Not applicable.
Finally, all PRs need to have an associated issue id connected. This would be the Fixes #<issue_id> in the PR description.

/ok-to-test sha=0a81b7c

authors: rajatagrawal riodeuno


text:
chore: cleanup Pr for multiple-environment

Description

TL;DR: clean-up PR for multiple environments, cleans up most of the transitory code.

Fixes #https://github.com/appsmithorg/appsmith-ee/issues/1507
Type of change

Chore (housekeeping or task changes that don't impact user perception)

Testing
How Has This Been Tested?

[ ] Manual

Test Plan
Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test


text:
[Hotfix] Update link to fetch tutorial doc

Fixes: #6172
Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix-doc-link

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
51.84 (0.01)
33.7 (0.01)
29.74 (0)
52.47 (0)

:green_circle:
app/client/src/utils/autocomplete/TernServer.ts
50.83 (0.24)
40.25 (0.84)
36.21 (0)
55.04 (0.27)

@rishabhsaxena LGTM

authors: RakshaKShetty rishabhsaxena


text:
Migration job fails to trigger on local deploy

Describe the bug
When running pnpm saas deploy, the migration job fails to trigger as it can't resolve localstack.
This happens when AWS_ENDPOINT_URL=http://localstack:4566 is present in packages/backend/.env, which is not needed anymore as that flag is being passes by docker-compose.local.yml now.
Therefore, it should be remove from packages/backend/.env.shared
Steps to reproduce

Create a .env for backend based on .env.shared
pnpm saas build
pnpm saas deploy

System Info
Any local deploy (not from CI) should face the same issue.

Logs
No response
Validations

[X] Follow our Code of Conduct.
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

Thank you for the contribution!:)

authors: gabrii mkleszcz

repo: apptension/saas-boilerplate


text:
Project Idea Selection

Hackathon Submission: <PROJECT_NAME>
Name of Team Lead
Enter your full name

GitHub handles of Team Members
Enter the GitHub handles of all your team members (including yourself) as separate bullet points

Are all of your team members registered on our Hackathon Signup page?
This is a mandatory step for all participants to be considered eligible for judging

[ ] Yes
[ ] No

Rules and Code of Conduct
By submitting this PR, you agree to follow our Rules and Code of Conduct.

[x] Yes

Anything Else?
Any other feedback, queries or information you would like to share with us?

@Vedant817 the codebase of the project must be added to a separate repo of its own and not the submissions repo. Please do so and fill your submission with the appropriate information. You can resubmit a PR after that.


text:
Unify test helpers in addon

Deletes test helpers that are provided by the addon as of https://github.com/aptible/ember-cli-aptible-shared/pull/13.
cc @sandersonet @mixonic

Please leave feedback but do not merge. I will update the PR to use the updated addon version after pr 13 has been merged and released.

This is ready to merge — it has been updated to use 0.0.12 of the addon.

:-D :-D :-D :-D <3 thanks @bantic

authors: bantic mixonic


text:
🛑 Field Service is down

In 0ee10ed, Field Service (https://api.field-services.prd.goaptive.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Field Service is back up in 76a6544 after 4 minutes.

repo: aptive-env/status


text:
ModuleNotFoundError: No module named 'tfltransfer'

I would like to use these libraries
but could not find information on how to install it.
from tfltransfer import bases
from tfltransfer import heads
from tfltransfer import optimizers
from tfltransfer.tflite_transfer_converter import TFLiteTransferConverter
Thank you.

The tfltransfer library is included in the repository, you do not need to install it separately.


text:
Support compdb for windows

Support to get OUTPUT_BASE for windows.
Format compile_commands.json.
Add filter_flags to filter the flags in the compilation command that clang does not support.

Support compdb for cuda.

Add cuda_enable to choose whether to enable compdb for cuda.


text:
Add support for github.com/magodo/tfadd

It's a popular tool in the Terraform ecosystem.

https://github.com/magodo/tfadd

Thank you.

https://github.com/aquaproj/aqua-registry/pull/16040

v4.58.0 is out 🎉
https://github.com/aquaproj/aqua-registry/releases/tag/v4.58.0

authors: nikolay suzuki-shunsuke

repo: aquaproj/aqua-registry


text:
Add support for github.com/busser/tftree

https://github.com/busser/tftree

Thank you.

https://github.com/aquaproj/aqua-registry/pull/16084

v4.59.0 is out 🎉
https://github.com/aquaproj/aqua-registry/releases/tag/v4.59.0


text:
feat: Add .gitattributes

Mark registry.yaml as generated file
Include pkgs/**/*.yaml for GitHub statistics

To create .gitattributes, I have two reasons:

registry.yaml is always generated from other files, so it is noisy a bit in reviewing pull requests or commit logs. GitHub has a way to make such generated files like package-lock.json, yarn.lock or Cargo.lock hidden from page.
The repository is standard registry of aqua, so I think GitHub's language statistics ( we usually see it on bottom left of webpage ) should include YAML files of pkgs/.

Thank you for your explanation!
https://github.com/github/linguist/blob/master/docs/overrides.md

https://github.com/github/linguist/blob/6cf57c870ec7a7c56835a3532a1df6149c3c8d93/lib/linguist/languages.yml#L7367-L7394

By default only languages of type programming or markup in languages.yml are included in the language statistics.

The type of YAML is data.

linguist-detectable: Included in stats, even if language's type is data or prose
linguist-generated: Excluded from stats, hidden in diffs


text:
The auto-detection of assests on a rust release seems to have a few issues with assets

Reproduce

Run aqua-registry scaffold dbrgn/tealdeer

Note: I'm submitting a fixed registry entry to the registry, so this is just informational on the auto setup of a package.

See the pointy fingers for the issues I specifically noticed on the defaults: 😄
packages:
  - type: github_release
    repo_owner: dbrgn
    repo_name: tealdeer
    asset: tealdeer-{{.OS}}-{{.Arch}}-musl
    format: raw
    description: A very fast implementation of tldr in Rust
    replacements:
      amd64: x86_64
      darwin: macos
    overrides:
      - goos: darwin
        asset: tealdeer-{{.OS}}-{{.Arch}}
      - goos: windows
        asset: tealdeer-{{.OS}}-{{.Arch}}-msvc
    supported_envs: # 👈🏻👈🏻👈🏻👈🏻👈🏻  This is a bit confusing. All darwin architecture, else only x86 on everything else, is that what this means? As a newer contributor that's a little confusing.
      - darwin
      - amd64
    rosetta2: true
    checksum:
      type: github_release
      asset: tealdeer-windows-x86_64-msvc.exe.sha256 # 👈🏻👈🏻👈🏻👈🏻👈🏻
      file_format: regexp
      algorithm: sha256
      pattern:
        checksum: "^(\\b[A-Fa-f0-9]{64}\\b)"
        file: "^\\b[A-Fa-f0-9]{64}\\b\\s+(\\S+)$"

I'm sorry but I couldn't find this issue because the notification setting isn't good.

I changed to All activetity.

    supported_envs: # 👈🏻👈🏻👈🏻👈🏻👈🏻  This is a bit confusing. All darwin architecture, else only x86 on everything else, is that what this means? As a newer contributor that's a little confusing.
      - darwin
      - amd64

Hmm. The document of supported_envs is not good...
I'll fix it.
aqua supports the following OS and CPU architecture. https://github.com/aquaproj/aqua-registry/blob/main/CONTRIBUTING.md#supported-os-and-cpu-architecture
If supported_envs isn't set, aqua always tries to install a package.
But if supported_envs is set, aqua tries to install the package only if the current OS and CPU architecture match with supported_envs.
supported_envs is OR condition, which means ["darwin", "amd64"] matches "darwin" or "amd64".

darwin

darwin/amd64
darwin/arm64

amd64

darwin/amd64
linux/amd64
windows/amd64

--

darwin/amd64
darwin/arm64
linux/amd64
windows/amd64

      asset: tealdeer-windows-x86_64-msvc.exe.sha256 # 👈🏻👈🏻👈🏻👈🏻👈🏻

asset means GitHub Releases' asset name of a checksum file.
e.g. tealdeer-windows-x86_64-msvc.exe.sha256
aqua-registry scaffold command isn't perfect, so sometimes this command generates wrong configuration.
Please fix code yourself. 🙏

I close this issue.
There are some related issues.

https://github.com/aquaproj/aqua/issues/1667
https://github.com/aquaproj/aqua/issues/1711
https://github.com/aquaproj/aqua/issues/1668

https://github.com/aquaproj/aqua/issues/1668 would be released in v1.36.0 and I think this is useful to develop aqua Registry.

authors: sheldonhull suzuki-shunsuke

repo: aquaproj/registry-tool


text:
Correct issue introduced in commit ee6a4f5 (related to #343)

Remove the " typo.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@simar7

This repo's standards need to be increased. This PR  should have failed via an automated test.
Tons of action's users just wasted time on this mistake.

@nicolargo I think you need to sign the CLA

@nicolargo I think you need to sign the CLA

I do...

authors: AkselAllas CLAassistant StemadsenCardlay nicolargo

repo: aquasecurity/trivy-action


text:
Links href outputted additionally in parentheses

Hello,
I face the following issue and don't know how to solve it:
Href values of links on pages are directly outputted in pdf next to the link value (no matter if text or image). Is there a way to turn that feature off?
You can see how it looks on attachment:

Hi @anebi,
It is not a feature on the side of Athena. It is triggered by the media type being set to print rather than screen. That is, you will need to change your print-specific styles.
If you are using Athena v3, you can set the media type to screen using: -M="screen".
This is not available in master or v2 at the moment.
Let me know if that answers your question.

Hello,
Thank you very much for your fast reply and detailed explanation. I do run docker version arachnysdocker/athenapdf-service. I am not sure which version is installed on this docker image. athenapdf -V returns empty result.
I will looks for a solution to change the media type.
Thanks again! :)

I can see that it is 2.9.2 actually. Is there a v3 docker image?

Yes, have a look at: https://github.com/arachnys/athenapdf/issues/123#issuecomment-318345714.
There's been a lot of changes (undocumented for now). But, if you are using the service, there is currently no way of setting custom runtime flags.
Alternatively (and maybe simpler), you can just modify your CSS to remove the print-specific styles.
If you use Bootstrap, this is normally shipped with it by default. You might want to generate a version of it that does not contain print styles.

Thanks. For now this info is enough. I will take care from that point :)
Best regards,
Ali Nebi

authors: MrSaints anebi

repo: arachnys/athenapdf


text:
feature request: include metric name in metric check alerts

We have a number of instances of our app reporting metrics to graphite and they all follow the same naming scheme.
We have configured a check for a metric named something like:
instances.*.lag
And we do get alerts when the lag of any instance goes up, but we'd like to know which one it was.
Is there a way to do this or could you please add it?
Thank you

I believe this is the current behaviour. I used aliasByName so that the metric is aliased to the instance name, and that does pop up in HipChat:
Service MyService reporting ERROR status: https://cabot.example.com/service/1/. Checks failing:  cluster load  (wrk01: 0.13 > 0.0, wrk02: 0.16 > 0.0, wrk03: 0.12 > 0.0) @jeanfred

repo: arachnys/cabot


text:
[Question] Why is ortho_init=False during hyperparameter searches?

It's my understanding that orthogonal initialization is basically universally slightly helpful and that this result has been verified in the literature, so it seems odd to disable it for hyperparameter tuning.

Hello,

basically universally slightly helpful

in practice, it mostly depends on the other hyperparameters (in my own experience, when doing hyperparameter optimization with ortho_init as an hyperparam, it was not an important one).
There are also other reasons:

ortho_init does not only do orthogonal initialization, there is also some scaling for the value function last layer, setting it to False removes one trick (the less tricks the better, especially if it does not affect performance), see https://github.com/DLR-RM/stable-baselines3/blob/master/stable_baselines3/common/policies.py#L514
ortho_init scaling is fixed (and I suspect that this likely not work well for wider/smaller architectures compared to the defaults)
setting to ortho_init=False reduces the search space

Thanks a ton

authors: araffin justinkterry

repo: araffin/rl-baselines-zoo


text:
error while trying to access java program

so while trying to use ttop I get a error strange thing is that jps detects it...
thanks
RF
rferreira@graylog1-cab2:~$ sudo java -jar sjk-plus-0.4.2.jar jps
25987   sjk-plus-0.4.2.jar jps
23691   /usr/share/graylog-server/graylog.jar server -f /etc/graylog/server/server.conf -np
rferreira@graylog1-cab2:~$ sudo java -jar sjk-plus-0.4.2.jar ttop -p 23691 -n 20 -o CPU
Failed to access MBean server: 23691

Hi,
-X option can be used to enable detailed stack traces.
Do JDK tools such as jstack or jmap can access that process process?

heya
rferreira@graylog1-cab2:~$ sudo jstat -gccause 30295 2000
  S0     S1     E      O      M     CCS    YGC     YGCT    FGC    FGCT     GCT    LGCC                 GCC
 43.56  46.08 100.00  17.42  97.70  95.81     53   10.782     2    0.606   11.388 Allocation Failure   Allocation Failure
  0.00  35.54  18.89  17.74  97.71  95.81     55   11.330     2    0.606   11.936 Allocation Failure   No GC
^Crferreira@graylog1-cab2:~sudo java -jar sjk-plus-0.4.2.jar ttop -p 30295 --verbose
Failed to access MBean server: 30295

Have you tries -X option of SJK ?
jstat is using mmapped file to get stats, so it would work event if JVM is defunt
jmap in your example is also using non-colaborative way to access JVM data (via platform debugger)
Does jstack work for this process?

Heya yeah I tried the option X in the SJK same output, regarding jstack:
rferreira@graylog1-cab2:~$ sudo jstack 30295
30295: Unable to open socket file: target process not responding or HotSpot VM not loaded
The -F option can be used when the target process is not responding

but when passing the -F flag I can access it..

jstack -F using non-colaborative approach. jstack (without -F) using same interface as sjk - JVM attach attach protocol.
Does problem remain after graylog restart?
What is working directory for target JVM? Does target JVM run under root?

heya,
the problem persists even after graylog restart.
the jvm runs under the user graylog
rferreira@graylog1-cab2:~$ ps -ef |grep java

graylog  30295     1 99 18:55 ?        10:43:30 /usr/bin/java -Xms30g -Xmx30g -XX:NewRatio=2 -server -XX:+ResizeTLAB -XX:+UseConcMarkSweepGC -XX:+UseParNewGC -XX:+DisableExplicitGC -XX:+UseCMSInitiatingOccupancyOnly -XX:+CMSClassUnloadingEnabled -XX:+CMSScavengeBeforeRemark -XX:CMSInitiatingOccupancyFraction=33 -XX:-OmitStackTraceInFastThrow -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=5 -XX:GCLogFileSize=1m -Xloggc:/tmp/memoryGC.log -XX:+PrintGCDetails -XX:+PrintGCDateStamps -XX:+PrintGCTimeStamps -XX:+PrintHeapAtGC -XX:+PrintTenuringDistribution -jar -Dlog4j.configurationFile=file:///etc/graylog/server/log4j2.xml -Djava.library.path=/usr/share/graylog-server/lib/sigar -Dgraylog2.installation_source=deb /usr/share/graylog-server/graylog.jar server -f /etc/graylog/server/server.conf -np

You should run sjk under same user as target process.
Could you try sudo -u graylog jstack PID ? If it would work it should work for sjk too.

sudo -u graylog java -jar sjk-plus-0.4.2.jar ttop -p 30295
Monitoring threads ...

great sucess thanks!

authors: aragozin rsff

repo: aragozin/jvm-tools


text:
debian 9 - why forcing versions to 0.9.6 and 0.13.6 only?

Asking because stumbled upon port 6980 issue with rtorrent 0.9.6 already discussed in other issue. Will something break if I override and install say 0.9.4 version on debian 9?

Yes this is the only version of rtorrent/libtorrent that works with Debian 9.
Unfortunately there is nothing I can do about the port issue.


text:
feat: show nodes from tenant_name

What this PR does:
show nodes from tenant_name

Which issue(s) this PR fixes:

Fixes #615
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report
Patch coverage: 12.50% and project coverage change: -0.11 :warning:

Comparison is base (dfc7401) 37.04% compared to head (6f6b7d4) 36.93%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
- Coverage   37.04%   36.93%   -0.11%
==========================================
  Files         202      202
  Lines       22233    22294      +61
==========================================
- Hits         8236     8235       -1
- Misses      13080    13142      +62
  Partials      917      917

Impacted Files
Coverage Δ

pkg/executor/redirect.go
3.81% <ø> (-0.06%)
:arrow_down:

pkg/runtime/ast/proto.go
53.33% <ø> (ø)

pkg/runtime/ast/show.go
29.20% <ø> (ø)

pkg/runtime/runtime.go
3.44% <0.00%> (ø)

pkg/runtime/ast/ast.go
70.79% <100.00%> (ø)

... and 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

pls resolve the conflict.

pls resolve the conflict.

pls resolve the conflict.

Done

authors: Mulavar PangXing codecov-commenter

repo: arana-db/arana