text:
[ROCKETMQ-44] Duplicated Codes in DefaultMessageStore.getEarliestMessageTime. https://issues.apache.org/jira/browse/ROCKETMQ-44 || [ROCKETMQ-209] Duplicated code in MQClientApiImpl :- https://issues.apache.org/jira/browse/ROCKETMQ-209

This commit is in reference to Story number 44 from the Kanban Board, which refers to removing duplicated logic from DefaultMessageStore.getEarliestMessageTime(). Please let me know if you need any improvements.

@vongosling Please have a look and let me know if you need any further improvements about the same. Thanks.

Coverage decreased (-0.5%) to 38.673% when pulling 44e132ba77b284e520b5a538f0cffa78f1aa5ec3 on Ritabrata-TW:master into d4149207e27ed3516f1f06407b55986790b806ae on apache:master.

Hi @vsair . Thanks for the suggestions. I have incorporated the same. Please have a look. Thanks

Coverage decreased (-0.3%) to 38.793% when pulling 35194b0136cb178a4e3549dfa39c6c6c0479fbbf on Ritabrata-TW:master into d4149207e27ed3516f1f06407b55986790b806ae on apache:master.

Coverage decreased (-0.3%) to 38.793% when pulling 35194b0136cb178a4e3549dfa39c6c6c0479fbbf on Ritabrata-TW:master into d4149207e27ed3516f1f06407b55986790b806ae on apache:master.

Coverage decreased (-0.3%) to 38.793% when pulling 35194b0136cb178a4e3549dfa39c6c6c0479fbbf on Ritabrata-TW:master into d4149207e27ed3516f1f06407b55986790b806ae on apache:master.

@shroman Can you take a look? Thanks

@Ritabrata-TW Could you modify PR subject conforming to our norm :-)

@Ritabrata-TW I am not understand your refer "Story number 44 from the Kanban Board", could you detail it ?

@Ritabrata-TW In other words, your pull request description has to be in this format
[ROCKETMQ-xxx] Message describing the issue.

Link to ROCKETMQ-xxx, which is the JIRA issue.

Coverage decreased (-0.3%) to 38.79% when pulling 28e14be3ea8fbe24814bcdebd61b36d94dd5b3b2 on Ritabrata-TW:master into d4149207e27ed3516f1f06407b55986790b806ae on apache:master.

Coverage decreased (-0.3%) to 38.79% when pulling 28e14be3ea8fbe24814bcdebd61b36d94dd5b3b2 on Ritabrata-TW:master into d4149207e27ed3516f1f06407b55986790b806ae on apache:master.

Coverage decreased (-0.3%) to 38.79% when pulling 28e14be3ea8fbe24814bcdebd61b36d94dd5b3b2 on Ritabrata-TW:master into d4149207e27ed3516f1f06407b55986790b806ae on apache:master.

@Ritabrata-TW Looking forward to your following for this PR :-)

@vongosling Sorry for the late response. I have changed the PR description according to the format suggested. I agree to what you said about splitting the big refactor into multiple parts and will keep this in mind for future issues. This PR has commits from 2 issues and it would be a little tedious to pull out these commits into multiple PRs now. I will attach both the issues in the PR description. Please have a look and let me know if this is okay.

Coverage decreased (-0.3%) to 38.78% when pulling dc2ce20af7715e454bd20f3dae039c2d13bc41cf on Ritabrata-TW:master into d4149207e27ed3516f1f06407b55986790b806ae on apache:master.

Coverage decreased (-0.3%) to 38.78% when pulling dc2ce20af7715e454bd20f3dae039c2d13bc41cf on Ritabrata-TW:master into d4149207e27ed3516f1f06407b55986790b806ae on apache:master.

Coverage decreased (-0.3%) to 38.78% when pulling dc2ce20af7715e454bd20f3dae039c2d13bc41cf on Ritabrata-TW:master into d4149207e27ed3516f1f06407b55986790b806ae on apache:master.

@Ritabrata-TW thanks, I will take a close look it later :-)

Is there something wrong with your code style ?

@Ritabrata-TW Hi, thanks for your contribution, and could you please set your merge target to develop branch which is our daily development branch?

@vsair The Travis build seems to have passed. Did you notice something wrong with the code style ?

@zhouxinyu My pleasure. I have set the merge target to develop. Thanks.

@vongosling @zhouxinyu Anything else that I need to do on this? Otherwise, can you please have a look and merge it?

@Ritabrata-TW I found so many code format in your PR, could you import our code style file as instruction, http://rocketmq.incubator.apache.org/docs/code-guidelines/

Thanks @Ritabrata-TW , we will merge this PR soon, but please don't forget to add related unit tests and follow our code style next time.
You are welcome to continue keeping your attention on RocketMQ community.

@zhouxinyu Thanks. I will keep the suggested things in mind next time. Please let me know if you need anything to close the PR.
I would also like to get more involved with the RocketMQ community and would be dropping a mentoring request in the mailing list. Thanks.

@Ritabrata-TW this PR has been merged into develop branch and will be released in next version, you can close it now safely.

@zhouxinyu Thanks a lot. Will look forward to working with you again.

@Ritabrata-TW Thanks for your attention for rocketmq community, whats' your scenario when using apache rocketmq in your company :-)

@vongosling We do not need a messaging queue in our Project as of yet. Will be advocating for RocketMQ if the scenario arises.

authors: Ritabrata-TW coveralls shroman vongosling vsair zhouxinyu

repo: apache/incubator-rocketmq


text:
Support RLIKE

Fixes #2208.

Pull Request Test Coverage Report for Build 7620

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 54.976%

Totals

Change from base Build 7619:
0.0%

Covered Lines:
8689

Relevant Lines:
15805

💛  - Coveralls

source: gharchive/pull-request

authors: coveralls tristaZero

repo: apache/incubator-shardingsphere

license_type: permissive

license_source: bigquery


text:
Delete getActualDataSourceName()

Pull Request Test Coverage Report for Build 8220

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 60.658%

Totals

Change from base Build 8218:
0.04%

Covered Lines:
8090

Relevant Lines:
13337

💛  - Coveralls


text:
Modify leaf segment key generator related functions.

Changes proposed in this pull request:

modify the name of some static final attribute
modify the constructor.
add "final" to the related test class.
modify methods: generateKey(),initLeafSegmentKeyGenerator(final String leafKey)
,increaseIdWhenLeafKeyStoredInCenter(final String leafKey).

Pull Request Test Coverage Report for Build 8589

10 of 11 (90.91%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 60.634%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/keygen/LeafSegmentKeyGenerator.java
10
11
90.91%

Totals

Change from base Build 8587:
0.0%

Covered Lines:
8410

Relevant Lines:
13870

💛  - Coveralls


text:
UI service error

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[x] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?
why?

Bug

Which version of SkyWalking, OS and JRE?
5.0beta
Which company or project?
madecare
What happen?

If possible, provide a way for reproducing the error. e.g. demo application, component version.
Browse requests and returns
request.txt
response.txt

Requirement or improvement

Please describe about your requirements or improvement suggestions.

@hanahmily Please check the data, whether include some invalid data.

Duplicate of https://github.com/apache/incubator-skywalking-ui/issues/141

Haha, too many duplicate issue.

source: gharchive/issue

authors: hanahmily wu-sheng xyydcoo

repo: apache/incubator-skywalking

license_source: github-api


text:
[hotfix] Fixes broken links

Purpose

Approach

Samples

Remarks

Fixes:

Thanks @vesense!

authors: dominikriemer vesense

repo: apache/incubator-streampipes


text:
how to clustering superset

Make sure these boxes are checked before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if any
[ ] I have reproduced the issue with at least the latest released version of superset
[ ] I have checked the issue tracker for the same issue and I haven't found one similar

There are two server redhat os I want to try a distributed processing by clustering the superset.
Is there a way to configure it?
Superset version
superset 0.18.5
python 2.7
Expected results
Actual results
Steps to reproduce

Use a Presto cluster
Em 04/07/2017 23:51, "kym498" notifications@github.com escreveu:

Make sure these boxes are checked before submitting your issue - thank you!

I have checked the superset logs for python stacktraces and included
it here as text if any
I have reproduced the issue with at least the latest released
version of superset
I have checked the issue tracker for the same issue and I haven't
found one similar

There are two server redhat os I want to try a distributed processing by
clustering the superset.
Is there a way to configure it?
Superset version
superset 0.18.5
python 2.7
Expected results Actual results Steps to reproduce
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ApacheInfra/superset/issues/3080, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHlGMMNvR2I6r8z8lSaqpXEaVFDIMTsqks5sKvo_gaJpZM4ONzgE
.

What do you want to cluster?

I resolve issues sharing setting config.py  (Configuration behind a load balancer)
Thanks

authors: desavera kym498 xrmx

repo: apache/incubator-superset


text:
How to add theme custom color to chart

Make sure these boxes are checked before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[ ] I have checked the issue tracker for the same issue and I haven't found one similar.

Superset version
0.29.0rc7
Expected results
How to add custom   color scheme in this dropdown
Actual results
Steps to reproduce

You can use superset-ui/color  or  write custom color map  like  categoricalSchemeRegistry  color_scheme: {     type: 'ColorSchemeControl',     label: t('Color Scheme'),     default: 'bnbColors',     renderTrigger: true,     choices: () => categoricalSchemeRegistry.keys().map(s => ([s, s])),     description: t('The color scheme for rendering chart'),     schemes: () => categoricalSchemeRegistry.getMap(),   },

You can use superset-ui/color or write custom color map like categoricalSchemeRegistry color_scheme: { type: 'ColorSchemeControl', label: t('Color Scheme'), default: 'bnbColors', renderTrigger: true, choices: () => categoricalSchemeRegistry.keys().map(s => ([s, s])), description: t('The color scheme for rendering chart'), schemes: () => categoricalSchemeRegistry.getMap(), },

i am new superset , is not clear to me , can you some brief explanation

authors: XuanmoFeng subbiaht


text:
Fix rst grammar problems

Fixed lots of rst grammar problems. PTAL. @mistercrunch

@mistercrunch Thx a lot.


text:
[cypress] add integration tests for dashboard

Added a few integration tests for dashboard:

load world_health dashboard
top level controls:

force refresh
favorite dashboard

apply filter on dashboard
edit mode

remove a chart
drag-n-drop chart from list and add it to dashboard

@michellethomas @kristw

I updated dashboard tests structure as #6019 suggested.


text:
Tagging frontend

CATEGORY
Choose one

[ ] Bug Fix
[X] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY

This PR introduces the frontend for tags, behind a feature flag:
DEFAULT_FEATURE_FLAGS = {                                                                                │
    'TAGGING_SYSTEM': True,                                                                                │
}

When the feature is enabled, owners can tag charts:

And dashboards:

Note that tags can be autocompleted.
A user who's not an owner will see non-editable tags:

When clicking on a tag, the user is taken to a page with content that has that tag:

TEST PLAN

Tested locally. We've also been using this at Lyft for months.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
@mistercrunch @williaster @khtruong

Codecov Report

Merging #7418 into master will decrease coverage by 0.15%.
The diff coverage is 27.21%.

@@            Coverage Diff             @@
##           master    #7418      +/-   ##
==========================================
- Coverage   65.08%   64.92%   -0.16%
==========================================
  Files         429      434       +5
  Lines       21002    21261     +259
  Branches     2338     2365      +27
==========================================
+ Hits        13669    13804     +135
- Misses       7217     7334     +117
- Partials      116      123       +7

Impacted Files
Coverage Δ

superset/assets/src/welcome/App.jsx
0% <0%> (ø)
:arrow_up:

superset/assets/src/components/ObjectTags.jsx
10.52% <10.52%> (ø)

superset/assets/src/utils/tags.js
100% <100%> (ø)

superset/assets/src/featureFlags.ts
88.88% <100%> (+1.38%)
:arrow_up:

superset/assets/src/tags.js
11.76% <11.76%> (ø)

superset/assets/src/welcome/TagsTable.jsx
15.38% <15.38%> (ø)

superset/assets/src/welcome/Welcome.jsx
52.63% <41.93%> (-27.37%)
:arrow_down:

...uperset/assets/src/dashboard/components/Header.jsx
44.34% <83.33%> (+2.14%)
:arrow_up:

...sets/src/explore/components/ExploreChartHeader.jsx
56.81% <87.5%> (+6.81%)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46579b1...ae40ee6. Read the comment docs.

@betodealmeida ,
Any plans on getting this merged?

@1AB9502 sorry for the delay with this. I need to add some integration tests. Let me put this up for review in the meantime.

cc: @khtruong

@betodealmeida
No worries! We are just really looking forward to getting this feature!

@etr2460

Is there a reason why you choose to create individual API functions instead of a set of redux actions to fetch and update tags? It makes sense to pull the tagging actions into its own file because it would be shared between both Explore and Dashboard views, but I think that maintaining the state of tags in its own redux store would be more typical and follow the patterns i've seen throughout superset already.

Great question. Yeah, we've been running this code at Lyft for maybe a year now, so it's definitely outdated and would be written differently from scratch today.
IIRC we went with API functions since the state lives outside the applications (explore, dashboards, SQL Lab). Maybe @mistercrunch remembers better?

I would recommend creating a new directory in assets/src/tags to keep the component files, the main tags page, the redux actions and the reducers and then wire up the required state to both explore and dashboard components. It would make tagging consistent with the rest of the app, clearer, and easier to maintain.

+1

Looks like this PR has gone stale, any idea on what version we can expect this feature?

Echoing @senduren's comment above, it has been about half a year since the last commit in this PR. Based on @betodealmeida's last comment, does it look like a full rewrite will be necessary? Is it this feature still on the roadmap for future versions of Superset?
Thanks a lot!

Chiming in as well. Our users love this feature.  During the latest upgrade we had to add everything back manually. Would love to see this feature merged!

Hi All,
First thanks for the nce feature implementation.
I have synced the source files for this PR with the latest master branch on incubator-superset and sent a PR to lyft/incubator-superset fork (https://github.com/lyft/incubator-superset/pull/98). If it is accepted we can continue with that.
Or, I can also send another PR to incubator-superset if it is requested.
We think the functionality is really nice to have.
All the best,

in this PR, and the one send to lyft/incubator-superset fork (lyft#98), it is being saved to db.

authors: 1AB9502 betodealmeida codecov-io mfyuce mrshu senduren


text:
Fix tf reshape

Move symbolic related logic after infer value is failed.

Thanks @kevinthesun @jwfromm @yongwww

authors: kevinthesun yzhliu

repo: apache/incubator-tvm


text:
[VTA] VTA hardware/software codebase re-org

The proposed changes in this PR is to separate out the hardware, and low-level software sources (e.g. driver) from the higher-level software sources (e.g. TOPI, IR passes for TVM, graph-level support, and python-level VTA support, VTA runtime and device api).
All of the hardware and low-level software files are placed under vta/vta-hw.
Edit
Summary of proposed changes

vta/apps is moved to vta/vta-hw/apps
vta/config is moved to vta/vta-hw/config
vta/hardware is moved to vta/vta-hw/hardware
vta/include is moved to vta/vta-hw/include except:

vta/include/runtime.h is moved to vta/runtime/runtime.h

vta/src is moved to vta/vta-hw/src except:

vta/src/device_api.cc is moved to vta/runtime/device_api.cc
vta/src/runtime.cc is moved to vta/runtime/runtime.cc

vta/tests/hardware is moved to vta/vta-hw/tests/hardware

Files that are unaffected by the re-org (mostly Python files)

vta/python
vta/scripts
vta/tests/python
vta/tutorials

Other enhancements/changes in the PR:

Updated SBT and chisel-iotesters version per https://github.com/apache/incubator-tvm/issues/4999
Adding apps TSIM examples in the TSIM CI tests to avoid bitrot

List of things to check before getting the PR merged

[x] CI unit-tests for FSIM
[x] CI unit-tests for TSIM
[x] CI unit-test for TSIM apps
[x] Tutorial building/execution success for FSIM

Thanks @tmoreau89 this is now merged


text:
[PY][FFI] Refactor runtime.String to subclass str

To make runtime.String to work as naturally as possible in the python side,
we make it sub-class the python's str object. Note that however, we cannot
sub-class Object at the same time due to python's type layout constraint(
cannot subclass from multiple classes with slots).
We introduce a PyNativeObject class to handle this kind of object sub-classing.

cc @zhiics @icemelon9 @jroesch
This is a PR that helps to prepare the std::string->String migration.

Thanks @tqchen @zhiics

If on python side we pass a runtime::String to packed function, whose signature uses std::string instead, is this case un-supported in this PR?

No, we don't support auto convert from String to std::string, we do want to convert most user facing  packed api to use String though so no conversion is needed


text:
Use auto-tuner to improve conv2d_gemm performance

High level description of this contribution
The following tuning entities have been introduced:

Unrolling and vectorizing input matrix transform
Reordering gemm to exploit parallel threads
Unrolling gemm_quantized intrinsic
Interleaving gemm_quantized intrinsic

Main files touched:

topi/python/topi/arm_cpu/tensor_intrin.py
topi/python/topi/arm_cpu/conv2_gemm.py

RFC
The RFC for this submission is available here
Change-Id: Icd3ab005663f78a80672e71ef368f6d0efa4a401

cc @FrozenGene @anijain2305 @u99127
Please note that since I will be off from Friday (for 15 days), I might turn this into a draft and pick it up when I come back (since it is self-contained it should not be an issue)

Hi @anijain2305 , I just got back from holidays and ready for reviewing this !

Hi @FrozenGene , @anijain2305 ,
Any update on this?
Thanks a lot,
Giuseppe

i can not spare time in reviewing this. Will do it tomorrow.

Hi @FrozenGene ,
Any update on this?
Thanks again,
Giuseppe

Thanks @giuseros @anijain2305 It is merged now.

authors: FrozenGene giuseros


text:
fix tvm.relay.build() docs

Looks like some line breaks are corrupting the tvm.relay.build docs:
Parameters

mod (IRModule) – The IR module to build. Using relay.Function is deprecated.
target (str, tvm.target.Target, or dict of str(i.e. device/context) –
to str/tvm.target.Target (name)) – For heterogeneous compilation, it is a dictionary indicating context to target mapping. For homogeneous compilation, it is a build target.
optional – For heterogeneous compilation, it is a dictionary indicating context to target mapping. For homogeneous compilation, it is a build target.
target_host (str or tvm.target.Target, optional) – Host compilation target, if target is device. When TVM compiles device specific program such as CUDA, we also need host(CPU) side code to interact with the driver setup the dimensions and parameters correctly. target_host is used to specify the host side codegen target. By default, llvm is used if it is enabled, otherwise a stackvm intepreter is used.
params (dict of str to NDArray) – Input parameters to the graph that do not change during inference time. Used for constant folding.
mod_name (Optional[str]) – The module name we will build

@tqchen

Can we use black to format it?

Hi @zhiics ,
I don't think Black can format comments, but I might be wrong

@zhiics @giuseros I had tested this with git-black.sh and didn't see any changes, but added both black fmt: off and pylint pylint: disable=line-too-long comments around this docstring. we may want to consider some stricter validation of docstrings in the future.

authors: areusch giuseros zhiics


text:
[MINOR] chore(asf): stop forwarding GitHub issues to dev mail list

What changes were proposed in this pull request?
Stop forwarding GitHub issues to dev mail list,
instead, forwarding them to issues mail list.
Why are the changes needed?
Many contributors are not subscribed to the dev mail list,
probably because it's noisy (~200 emails per month).
Let's leave dev mail list for the most important (or general) messages,
such as: votes, announcements, general discussions, user feedbacks.
Does this PR introduce any user-facing change?
Users still wishing to receive all GitHub issues updates through email
should subscribe to issues@uniffle.apache.org, or alternatively,
watch the GitHub repository.
How was this patch tested?
No need.

Codecov Report

Merging #1032 (5f1e3cd) into master (ecfed5e) will increase coverage by 1.16%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1032      +/-   ##
============================================
+ Coverage     54.10%   55.26%   +1.16%
  Complexity     2547     2547
============================================
  Files           382      362      -20
  Lines         21728    19368    -2360
  Branches       1802     1802
============================================
- Hits          11755    10704    -1051
+ Misses         9269     8033    -1236
+ Partials        704      631      -73

see 23 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged to master. thanks all.

authors: codecov-commenter jerqi kaijchen

repo: apache/incubator-uniffle


text:
chore(build): Disable lombok by default and only enable them in web directories

What changes were proposed in this pull request?

disable most of the lombok features in the project
enable specific lombok features in coordinator and shufffle server's web directories

Why are the changes needed?
For better code practice
Fix: # (issue)
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No need.

Per discussion: #2022 (comment), I think we should restrict the usage of lombok. Please take a look at this @jerqi @LuciferYang @xianjingfeng
Also cc @yl09099 as well.

Ok for me.

authors: advancedxy jerqi


text:
Jdbc and Postgres do not support JoinOperators yet

The Postgres Platform only supports simple select-project queries for now.
Introducing Joins would expand the possibilities of using Postgres with Wayang.
I will open a pull request and propose a solution to this.

At the moment only simple projections and filters can be pushed down. Supporting join push downs is welcomed.

+1

authors: juripetersen kbeedkar zkaoudi

repo: apache/incubator-wayang


text:
[Android]点击事件0.26.0

我用的0.26.0版本点击事件有时候会突然不能点击整个页面卡死，退出APP，在进去又可以了

我用的0.26.0版本点击事件有时候会突然不能点击整个页面卡死，退出APP，在进去又可以了

master分支已经解决这个bug了，你可以拉取master分支的代码自己打包sdk。

官网的这个源码下下来重新生成SDK就可以了吗

我用的0.26.0版本点击事件有时候会突然不能点击整个页面卡死，退出APP，在进去又可以了

master分支已经解决这个bug了，你可以拉取master分支的代码自己打包sdk。

https://user-images.githubusercontent.com/52556048/64673535-01691d80-d4a1-11e9-916e-cf6aff5cae54.png这个官网的下下来打包就可以了吗

官网的这个源码下下来重新生成SDK就可以了吗

不是0.26的源代码，是master分支的代码。

官网的这个源码下下来重新生成SDK就可以了吗

不是0.26的源代码，是master分支的代码。

有没有打包好的分享一下啊

同问，有没有打好的包，我们自己打包so总算有不同机子的兼容问题导致页面白屏，create instance failed,errcode=-1001

同问，有没有打好的包，我们自己打包so总是有不同机子的兼容问题导致页面白屏，create instance failed,errcode=-1001

Try Weex 0.28, it just released a week ago.

authors: LwLuna YorkShen fengmingye shenhuniurou

repo: apache/incubator-weex


text:
[INLONG-9541][ASF] Remove branch protection strategy for the master branch

Prepare a Pull Request
(Change the title refer to the following example)

Title Example: [INLONG-XYZ][Component] Title of the pull request

(The following XYZ should be replaced by the actual GitHub Issue number)

Fixes #9541

Motivation
To fix some wrong commits.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)

[ ] This change is a trivial rework/code cleanup without any test coverage.

[ ] This change is already covered by existing tests, such as:
(please describe tests)

[ ] This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

The protection of the master branch is important, and should not be removed.

repo: apache/inlong


text:
[Bug] Windows Server 2016启动失败

Search before asking

[X] I searched in the issues and found nothing similar.

Version
iotdb 1.2.1
Windows Server 2016
Describe the bug and provide the minimal reproduce step

Active code page: 65001
'````````````````````````
Starting IoTDB DataNode
'````````````````````````
"setting local JMX..."
Maximum memory allocation pool = 16384M, initial memory allocation pool = 100M
If you want to change this configuration, please check conf\datanode-env.bat.
Check whether the ports are occupied....
--add-opens=java.base/java.util.concurrent=ALL-UNNAMED     --add-opens=java.base/java.lang=ALL-UNNAMED     --add-opens=java.base/java.util=ALL-UNNAMED     --add-opens=java.base/java.nio=ALL-UNNAMED     --add-opens=java.base/java.io=ALL-UNNAMED     --add-opens=java.base/java.net=ALL-UNNAMED -ea -Dlogback.configurationFile="D:\iotdb\\conf\logback-datanode.xml" -DIOTDB_HOME="D:\iotdb\" -DTSFILE_HOME="D:\iotdb\" -DTSFILE_CONF="D:\iotdb\\conf" -DIOTDB_CONF="D:\iotdb\\conf" -Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8 -Xmx16384M -Xms100M -XX:MaxDirectMemorySize=16384M -Djdk.nio.maxCachedBufferSize=16384*1024*1024/16/1024 -cp "D:\iotdb\\lib\*";iotdb.DataNode  -Diotdb.jmx.local="true" org.apache.iotdb.db.service.DataNode -s
2023-10-19 13:37:40,085 [main] INFO  o.a.i.d.c.IoTDBDescriptor:161 - Start to read config file file:D:/iotdb//conf/iotdb-common.properties
2023-10-19 13:37:40,095 [main] INFO  o.a.i.d.c.IoTDBDescriptor:178 - Start to read config file file:D:/iotdb//conf/iotdb-datanode.properties
2023-10-19 13:37:40,104 [main] INFO  o.a.i.d.c.IoTDBDescriptor:1623 - initial allocateMemoryForRead = 5153960755
2023-10-19 13:37:40,104 [main] INFO  o.a.i.d.c.IoTDBDescriptor:1624 - initial allocateMemoryForWrite = 5153960755
2023-10-19 13:37:40,105 [main] INFO  o.a.i.d.c.IoTDBDescriptor:1625 - initial allocateMemoryForSchema = 1717986918
2023-10-19 13:37:40,105 [main] INFO  o.a.i.d.c.IoTDBDescriptor:1626 - initial allocateMemoryForConsensus = 1717986918
2023-10-19 13:37:40,105 [main] INFO  o.a.i.d.c.IoTDBDescriptor:1791 - allocateMemoryForSchemaRegion = 858993459
2023-10-19 13:37:40,106 [main] INFO  o.a.i.d.c.IoTDBDescriptor:1795 - allocateMemoryForSchemaCache = 687194767
2023-10-19 13:37:40,106 [main] INFO  o.a.i.d.c.IoTDBDescriptor:1799 - allocateMemoryForPartitionCache = 171798691
2023-10-19 13:37:40,113 [main] INFO  o.a.i.t.c.c.TSFileDescriptor:126 - try loading iotdb-common.properties from D:\iotdb\conf\iotdb-common.properties
2023-10-19 13:37:40,129 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateDataDirs(IoTDBConfig.java:1232)
        at org.apache.iotdb.db.conf.IoTDBConfig.setTierDataDirs(IoTDBConfig.java:1328)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProperties(IoTDBDescriptor.java:363)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:182)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,132 [main] INFO  o.a.i.d.c.IoTDBDescriptor:403 - IoTDB enable memory control: true
2023-10-19 13:37:40,154 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1197)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,155 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1198)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,161 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1199)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,163 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1200)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,164 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1201)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,165 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1202)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,167 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1203)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,168 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1204)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,169 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1205)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,169 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1206)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,169 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1207)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,177 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1208)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,179 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1209)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,180 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1210)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,182 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1211)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,186 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1212)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,188 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1213)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,190 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1214)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,191 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1215)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,192 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1216)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,194 [main] ERROR o.a.i.db.conf.IoTDBConfig:1277 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.db.conf.IoTDBConfig.addDataHomeDir(IoTDBConfig.java:1275)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateDataDirs(IoTDBConfig.java:1232)
        at org.apache.iotdb.db.conf.IoTDBConfig.formulateFolders(IoTDBConfig.java:1217)
        at org.apache.iotdb.db.conf.IoTDBConfig.updatePath(IoTDBConfig.java:1191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:191)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,201 [main] ERROR o.a.i.c.conf.CommonConfig:208 - Fail to get canonical path of D:\iotdb" -DTSFILE_HOME=D:\iotdb"
java.io.IOException: 文件名、目录名或卷标语法不正确。
        at java.base/java.io.WinNTFileSystem.canonicalize0(Native Method)
        at java.base/java.io.WinNTFileSystem.canonicalize(WinNTFileSystem.java:438)
        at java.base/java.io.File.getCanonicalPath(File.java:618)
        at org.apache.iotdb.commons.conf.CommonConfig.updatePath(CommonConfig.java:206)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.loadProps(IoTDBDescriptor.java:192)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.<init>(IoTDBDescriptor.java:85)
        at org.apache.iotdb.db.conf.IoTDBDescriptor$IoTDBDescriptorHolder.<clinit>(IoTDBDescriptor.java:2085)
        at org.apache.iotdb.db.conf.IoTDBDescriptor.getInstance(IoTDBDescriptor.java:101)
        at org.apache.iotdb.db.service.DataNode.<clinit>(DataNode.java:107)
2023-10-19 13:37:40,252 [main] INFO  o.a.i.db.service.DataNode:149 - IoTDB-DataNode environment variables:
        IOTDB_HOME=D:\iotdb" -DTSFILE_HOME=D:\iotdb";
        IOTDB_CONF=D:\iotdb\\conf;
        IOTDB_DATA_HOME=null;
2023-10-19 13:37:40,253 [main] INFO  o.a.i.db.service.DataNode:150 - IoTDB-DataNode default charset is: UTF-8
2023-10-19 13:37:40,293 [main] INFO  o.a.i.c.c.IoTDBThreadPoolFactory:203 - new single scheduled thread pool: Stateful-Trigger-Information-Updater
2023-10-19 13:37:40,300 [main] INFO  o.a.i.d.s.DataNodeServerCommandLine:77 - Running mode -s
2023-10-19 13:37:40,304 [main] INFO  o.a.i.d.c.IoTDBStartCheck:128 - Starting IoTDB 1.2.1 (Build: aa24cb6)
2023-10-19 13:37:40,304 [main] ERROR o.a.i.d.c.IoTDBStartCheck:134 - Can not create schema dir: D:\iotdb" -DTSFILE_HOME=D:\iotdb"\data\datanode\system\schema
Press any key to continue . . .

What did you expect to see?
从报错信息看到，路径后边有个",路径是拼接的，进而导致报错，我把整个iotdb的lib、conf、bin目录都重新更换还是出现，data目录清除也是这样。
这个问题出现之前，请参照我提的另外一个issue，https://github.com/apache/iotdb/issues/11313
在此之前MQTT消息内部有非法字符，问题不知道怎么消失的，最新状况就是datanode无法启动，整个过程不知道怎么产生
生产环境突然出现这种情况，没有思路入手
另外，我在另外一台windows server 2022上面运转正常，也是mqtt方式插入数据
What did you see instead?
查找问题，解决问题，fix bug
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

手动修改start-datanode.bat后正常，在头部添加如下内容
set IOTDB_HOME=D:\iotdb
echo %IOTDB_HOME%
显示IOTDB_HOME=D:\iotdb，未指定或者从系统注册表读取的地址尾部自动会添加一个,显示内容为
IOTDB_HOME=D:\iotdb\
可能微软对于路径的写法不同操作系统之间表现不一致

repo: apache/iotdb


text:
[IOTDB-3636] Fix delete non existing sg error msg

Description
To stick with 0.13. While trying to delete non existing storage group, in other words the input path patterns doesn't match any existing storage group, message like "path not exists" should be returned.
Result

Hi, does new standalone have the same problem?

Hi, does new standalone have the same problem?

I've fixed the same problem in new standalone version. PTAL.

authors: HTHou MarcosZyk


text:
OAK-9145: Swap order of default filters

WordDelimiterFilter is invoked with the GENERATE_WORD_PARTS flag, which splits camelCase/PascalCase into multiple terms.  But since the LowerCaseFilter is applied first, the mixed-case is lost and the terms can't be split by WordDelimiterFilter.  Reversing filters so that behaviour occurs as expected.
I would have liked to add unit tests, but there didn't seem to be any around this class.  I may come back to add some.

I have made several attempts to add unit tests for this, but I'm really struggling to figure out how to add a fulltext test which uses an index with OakAnalyzer.  It would be awesome if somebody else in the community helped out with the unit tests.

JIRA issue was resolved WONTFIX.

repo: apache/jackrabbit-oak


text:
JAMES-4090 Forced disconnection

As an admin I want to force user deconection.
Eg in case of compromission: close all active channels (IMAP, SMTP)

11:00:25,925 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.3.0:check (check-style) on project james-server-protocols-library: You have 1 Checkstyle violation. -> [Help 1]

Still, on an other module:
08:08:56,673 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.3.0:check (check-style) on project james-server-webadmin-protocols: You have 1 Checkstyle violation. -> [Help 1]

authors: Arsnael chibenwa

repo: apache/james-project


text:
KAFKA-15443 Upgrade RocksDB to 9.7.3

Upgrades RocksDB to version 9.7.3 to address Jira KAFKA-15443
This PR addresses the following compatibility issues introduced by the RocksDB upgrade:

Removal of AccessHint: The AccessHint class was completely removed in RocksDB 9.7.3. This required removing all import statements, variable declarations, method parameters, method return types, and static method calls related to AccessHint in RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java Unused methods are removed in RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java

Removal of NO_FILE_CLOSES: The NO_FILE_CLOSES metric was also removed in RocksDB 9.7.3. The calculation for numberOfOpenFiles in RocksDBMetricsRecorder.java has been adjusted to now track the total number of file opens since the last reset. The previous calculation, which subtracted NO_FILE_CLOSES from NO_FILE_OPENS, is no longer possible.
The reason RocksDB team removed NO_FILE_CLOSES it seems to me they detected not properly working: https://github.com/search?q=repo%3Afacebook%2Frocksdb+NO_FILE_CLOSES&type=issues

Any feedback or any proposed changes you would like me to do are welcome let me know.
@cadonna @mjsax
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@cadonna I have added methods and also made changes in Test class and also documents. Unit Tests keep failing. Though I ran unit tests for given two Test file and ran passed. Can you take a look what went wrong and feedback? Thanks @mjsax

repo: apache/kafka


text:
KAFKA-3623: KStreamTestDriver extends ExternalResource

In the streams project, there are a number of unit tests that has duplicate
code with respect to the tearDown() method, in which it tries to close the
KStreamTestDriver connection. The goal of this changeset is to eliminate
this duplication by converting the KStreamTestDriver class to an ExternalResource
class which is the base class of JUnit Rule.
In every unit tests that calls KStreamTestDriver, we annotate the KStreamTestDriver
using @Rule annotation. In the KStreamTestDriver class, we override the after()
method. This after() method in turn calls the close() method which was previously
called in the tearDown() method in the unit tests. By annotating the KStreamTestDriver
as a @Rule, the after() method will be called automatically after every testcase.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6394/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6379/
Test PASSed (JDK 8 and Scala 2.12).

@mjsax @guozhangwang  Would like to make a request for review of change set for KAFKA-3623 when you have some time. Thank you.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6395/
Test PASSed (JDK 8 and Scala 2.12).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.11/6472/
Test PASSed (JDK 7 and Scala 2.11).

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/6457/
Test PASSed (JDK 8 and Scala 2.12).

@guozhangwang @mjsax rebased and made changes per recommendations. Thechanges are ready for review. Thank you.

LGTM. Merged to trunk.

authors: asfgit guozhangwang johnma14


text:
Considering all features in a feature including the features defined …

…inside conditionals
Continuation of https://github.com/apache/karaf/pull/880, but this time aiming to merge into master

Your change is not fully correct as the conditional feature might not have a version, and the resolution will fail.

@jbonofre I don't see how this can happens. In our validation example, we don't indicate any feature version - https://paste.ofcode.org/UjVKQENQCYDFrKFTwgARgX and it resolves the feature.
Can you please indicate a scenario where this can happen? So we can validated that. Ty

@jbonofre , can you please answer my question on latest comment? Ty

@jbonofre any update on this PR? Is missing something from my side?

@ricardosilva88 oops sorry I forgot your PR. Let me resume the review on it, but when I tested it breaks the resolution. Let me resume the review.

retest this please

Noticed that are some examples failing due to this change, I will be working to fix and probably adding some tests

@jbonofre just pushed my fix's for the tests that were failing

retest this please

retest this please

retest this please

@jbonofre I already rebase against master and on my local machine it does work. I don't see any valid reason or log on your Jenkins for this failure.

retest this please

"ERROR: Maven Home /home/jenkins/tools/maven/apache-maven-3.6.0 doesnt exist"

@ricardosilva88 yes, I'm fixing that. It's related to a change we did on Jenkins executors.

Jenkins configuration has been updated.

retest this please

retest this please

retest this please

retest this please

repo: apache/karaf


text:
Update error message and add the ERR error code

We now have some error messages that do not return
an ERR error code:
127.0.0.1:6666> cluster nodes
Cluster mode is not enabled

As far as i know this doesn't affect the client libs,
and doesn't affect the users. But I think it's right
to add the error code.
Note that Redis will actually count error messages and
standardize the error codes, like:
127.0.0.1:6379> info Errorstats
 # Errorstats
errorstat_ERR:count=2
errorstat_EXECABORT:count=1
errorstat_WRONGTYPE:count=1

We mixed using the status message and error output in
some places, this PR checks all redis::Error calls and
use error status to replace it. (Only the ERR case is
handled, others are not handled yet.)

It's not a direct objective of this PR, but I'd like to have the "ERR" + some_error_message construction only in one place as an implementation detail of the Redis protocol. Maybe, inside redis::Error or so.

It's not a direct objective of this PR, but I'd like to have the "ERR" + some_error_message construction only in one place as an implementation detail of the Redis protocol. Maybe, inside redis::Error or so.

@torwig thanks for the review. agree, that is a good suggestion.
we still have some places that mixed using the status message and error output. (e.g. NOSCRIPT)
i think we can leave it for a future PR as a cleanup. (pull out the error code and error message)

authors: enjoy-binbin torwig

repo: apache/kvrocks


text:
Bump jakarta.activation:jakarta.activation-api from 1.2.1 to 1.2.2

Why are the changes needed?

Release note:

https://github.com/jakartaee/jaf-api/releases/tag/1.2.2
https://jakarta.ee/specifications/activation/1.2/

There are no functional changes from the previous release (1.2.1).
The main reason for this bumping is alignment to an official release in maven central, as 1.2.1 is located to the old group id in com.sun.activation:jakarta.activation 1.2.1(https://github.com/jakartaee/jaf-api/releases/tag/1.2.1) in 2018, and 1.2.2 is the first release with new group id in jakarta.activation:jakarta.activation-api 1.2.2 in 2020.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Thanks, merged to master

repo: apache/kyuubi


text:
Improvements on "extending Log4J" docs.

added some links to JavaDoc
enhance some examples
fix some references

Thanks so much @janmaterne! Merged.

Just a reminder that these were only merged to master so will not affect the active web site.

authors: janmaterne rgoers vy


text:
Automatically preload index files that are both tiny and very hot.

The default codec has a number of small and hot files, that actually used to be fully loaded in memory before we moved them off-heap. In the general case, these files are expected to fully fit into the page cache for things to work well. Should we give control over preloading to codecs? This is what this commit does for the following files:

Terms index (tip)
Points index (kdi)
Stored fields index (fdx)
Terms vector index (tvx)

This only has an effect on MMapDirectory.

I think preload is different from mlock, mlock needs way more discussion and personally I'm against it. mlock would be an operational hassle because of default resource limits on linux as well.

I think preload is different from mlock, mlock needs way more discussion and personally I'm against it. mlock would be an operational hassle because of default resource limits on linux as well.

This would of course be optional (it must be optional as it also requires extra JVM command line params). I think we should give users the option to do it.
Personally I also tend to be against "load".

@uschindler I think I understand Robert's concerns against mlock, but less yours against loading. Do you think that it would be useless to preload if these files can then get paged out? My thinking was that most users would rather like Lucene to take a bit longer to open indices if it helps provide better performance on initial queries, noting that it wouldn't make opening much slower given how tiny these files tend to be compared to the overall dataset (~0.17% of the total index size for the index generated by nightly benchmarks). In general these files would stay in the page cache all the time, but if they don't because of unusual access patterns or competing processes and the page cache decides to page out some data, it wouldn't be much worse than today. I do think some users will see appeal in the mlock option and getting stronger guarantees that this data wouldn't get paged out, but this feels like something that should be an opt-in rather than the default?

I think the predicate would also simplify the current Elasticserach code which instantiates 2 MMapDirectory instances with the same underlying dir and uses FileSwitchDir in front. A predicate is much better to handle this ("which files to preload").

Agreed, this would be a welcome simplification.

we can keep and deprecate the old boolean setter that delegates to 2 predefined "alaways on", "always off" predicates.

@uschindler Something like that?

Looks fine. I would add 3 predefined constants:
public static final BiPredicate<String,Context> ALL_FILES = (file, context) -> true;
public static final BiPredicate<String,Context> NO_FILES = (file, context) -> false;
public static final BiPredicate<String,Context> USE_LOAD_CONTEXT = (file, context) -> context.load;

Then you could also keep the deprecated getter by compaing with ALL_FILES; The Default would be the new one.
What's missing is a little bit of better documentation in setPreload() and possibly the class javadocs. It is unknown what the first param "String" of the predicate is, it should document that it is the filename.

Unrelated problem with Github CI:

org.apache.lucene.index.TestIndexFileDeleter.testExcInDecRef

this test failed for me yesterday in the same way. Seems to be a bug.

looks great. I don't like the PRELOAD_ prefix on the constants, because I plan to use the same for mlock2. I was already thinking about this, but came to no good names. So my proposal was the above.

OK. I wanted to use names that give a sense of when these general BiPredicate objects are useful without looking up javadocs, but your point about reusing for mlock makes sense.

Looks good to me, i think maybe say for the constant that it uses LOAD context.

...namining is hard...

I will open an issue in Solr to adapt their code.

@uschindler I think I understand Robert's concerns against mlock, but less yours against loading. Do you think that it would be useless to preload if these files can then get paged out? My thinking was that most users would rather like Lucene to take a bit longer to open indices if it helps provide better performance on initial queries, noting that it wouldn't make opening much slower given how tiny these files tend to be compared to the overall dataset (~0.17% of the total index size for the index generated by nightly benchmarks). In general these files would stay in the page cache all the time, but if they don't because of unusual access patterns or competing processes and the page cache decides to page out some data, it wouldn't be much worse than today. I do think some users will see appeal in the mlock option and getting stronger guarantees that this data wouldn't get paged out, but this feels like something that should be an opt-in rather than the default?

I'm not against preloading i just don't think it does anything here. It just madvises the kernel for read-ahead and then touches every page.
Seems something went badly wrong here: if these files need to be hot, then just load the structures into the heap? all this talk about preloading and locking pages is not good. why were these "small hot files" removed from the heap?

I reverted the bits that would load some files in physical memory by default. These files don't have to be in memory and I actually like that these files are not in the heap because it makes lots of things easier, e.g. you don't have to size our heap depending on how much data you're dealing with - 0.17% is still 1.75GB of memory if you have 1TB worth of index data.

And 1.75GB is the same amount if you want to mlock the pages. Which no operating system is gonna let you do by default, on linux it will require modifying system soft/hard limits.
If a user has 1TB worth of index data, is it more intuitive that they should run with e.g. at least a 4GB heap? Or that they should go mucking around in /etc/security?

also wanna note my concern around any use of mlock, that, users may not know how to do the right thing and be lazy and just run as root. this is sadly the stuff that users do, i'd hate to encourage it.
so to me it seems like the heap is more user-friendly way to get the performance that you want.

BTW, sorry that I mentioned mlock2... oh man oh man.

Maybe we should start again here:

sorry for mentioning mlock2, I will think of a way in the future to hook into the MemorySegment and configure it in native ways (e.g. set madvise) on MMapDirectory. I won't implement a methodhandle to mlock2 without haveing the fun of fighting with @rmuir ;-]
Maybe split the PR into two parts: (1) adding the improved preload BiPredicate (this would allow Elasticsearch to do whatever they want) and (2) add the IOContext support for those files and also add the example as proposed here.

I would not change the default. That's up to the end-user of Lucene (e.g. Elasticsearch, Solr, Opensearch).

Well it was good to mention mlock as that "makes more sense" than just "preload" (which has a confusing name IMO). "preload" just faults it in but if there is memory pressure it can then just be paged out, so that's why i don't think it "does anything".

I think to get a "real sticky preload to heap", we would need to add a NRTCachingDirectory-like wrapper on top of any Directory that copies the file into ByteBuffersIndexInput.

Agreed with your suggestion to reset and split into two PRs @uschindler. I'll close this one and open two new ones.

This got split into #11929 and #11930.

this test failed for me yesterday in the same way. Seems to be a bug.

This test has been failing for some time -- we have #10878 open for it.  I'll try to make some time to figure out what's happening.

authors: jpountz mikemccand rmuir uschindler

repo: apache/lucene


text:
METRON-1798: Add mpack support for parser aggregation

Contributor Comments
This pull request allows users to submit an aggregated parser topology.
Testing Steps

Spin up full-dev.
Stop the "Metron Parsers" service so that existing parser topologies are killed/stopped.
Go to Ambari -> Metron -> Configs -> Parsers
Change the "Metron Parsers" value as: "bro,snort", "yaf (For example)
Save changes and restart the Metron Parsers service.
Go to Storm UI, and verify that the aggregated topologies viz. "bro__snort" and "yaf" are started.

Testing Done
1. Full Dev

Set the Metron Parsers value as "bro,snort.yaf" and restarted the service.

A single aggregated topology is seen to be started:

Verified stop 'Metron Parsers' service to check that the aggregated topology is stopped properly

Verified restart 'Metron Parsers' service to check that the aggregated topology is restarted properly

2. Multi-node setup

Set the Metron Parsers value as: "bro,snort,yaf","bro,yaf","snort,yaf",yaf,snort
The appropriate aggregated and single topologies are started:

Changed the parser list as: bro,snort,yaf
Restarted the parsers service to validate that the three parser topologies are started individually.

Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[x] Have you included steps or a guide to how the change may be verified and tested manually?

[ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

[ ] Have you written or updated unit tests and or integration tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

[x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

Please note: I did not find the Parser Aggregation functionality documented under the Parser Chaining README, save a mention under the parser chaining use case. Please let me know if it makes sense to add this to the main parser chaining README, and I will add it.

@anandsubbu This looks great.  I am going to run it up now.
One thing I notice right off is that we did not add any documentation for the parsers fields in Ambari.  Would it make sense to add a brief description to the pop-up text describing how a user can define parsers?

When switching parser topologies, some of the original parser topologies can fail to be shut down properly.
Steps to Replicate:

Start with default parsers; [bro,snort]
Change Metron Parsers setting to use aggregation; ["bro","snort,yaf"]
The original "snort" topology is never shutdown.  I would expect this to be shutdown.
Parsers Running: bro, snort__yaf, snort
Parsers Expected: bro, snort__yaf

It seems that the code needs to take into account the original field setting when shutting down the parsers, but then use the new setting when starting the parsers.

@nickwallen: When switching parser topologies, some of the original parser topologies can fail to be shut down properly.

@anandsubbu I have found that the same issue occurs in master.  Since that is the case, we could choose to tackle this as a separate ticket.  It is your choice.

Hi @nickwallen , thank you for the review.

@nickwallen One thing I notice right off is that we did not add any documentation for the parsers fields in Ambari. Would it make sense to add a brief description to the pop-up text describing how a user can define parsers?

Sure, makes sense. I have also added a section to the Parser Chaining README as well with examples. Please have a look.

@nickwallen: When switching parser topologies, some of the original parser topologies can fail to be shut down properly.
I have found that the same issue occurs in master. Since that is the case, we could choose to tackle this as a separate ticket. It is your choice.

I created METRON-1802 so this can be fixed outside of this PR.

Re-run travis

authors: anandsubbu nickwallen

repo: apache/metron


text:
Nimble supports AutoPTS based on PTS 8.2.1

test plan update
workspace update
GAP
GATT
SM
L2CAP
Mesh

ICS were updated here: https://github.com/intel/auto-pts/pull/719 and still are valid
Workspace update: https://github.com/intel/auto-pts/pull/738

@sjanc GAP/SEC/AUT/BV-21-C theoretically passes, but let's not rely on PTS bugs and send event to inform Upper Tester about bond loss https://github.com/apache/mynewt-nimble/pull/1091 :)

authors: KKopyscinski sjanc

repo: apache/mynewt-nimble


text:
NIFI-5280: Preventing duplicate bulletins

NIFI-5280:

Preventing duplicate bulletins that are registered under different contexts (e.g. Controller and Component).

@mcgilman thanks, was able to verify that the logic makes sense, all looks good. +1 merged to master.

repo: apache/nifi


text:
NIFI-7192 - nifi.sh install not working on systemd servers

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
After invoking nifi.sh install, systemd manager configuration is reloaded. In this way, wrapper from init.d to systemd service is generated and the service will work smoothly. Fixes bug NIFI-7192.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on both JDK 8 and JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@pvillard31 / @alopresto can you please take a look on this?

@rmarturano For due diligence, what distributions has this been tested against? I have two worries with this: (1) that the commands might not always be on the path and (2) that using pidof might not be reliable.
I think it might be worthwhile to add some additional checks (e.g., what's mentioned by https://www.freedesktop.org/software/systemd/man/sd_booted.html).

@jfrazee @exceptionfactory first of all thanks for your inputs.
I applied suggested changes and rebased.

@jfrazee Shall we merge it?

@jfrazee why did you hold off on merge after approving? Was more work required?

authors: MikeThomsen jfrazee rmarturano


text:
NIFI-7467 Refactored S2S peer selection logic

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR

Removed list structure for peer selection as it was unnecessary and often wasteful (most clusters are 3 - 7 nodes, the list was always 128 elements).
Changed integer percentages to double to allow for better normalization.
Removed 80% cap on remote peers as it was due to legacy requirements.
Added unit tests for non-deterministic distribution calculations.
Added unit tests for edge cases due to rounding errors, single valid remotes, unbalanced clusters, and peer queue consecutive selection tracking.
Migrated all legacy PeerSelector unit tests to new API.
Removed unused System time manipulation as tests no longer need it.
Added class-level Javadoc to PeerSelector.
Removed S2S details request replication, as the responses were not being merged, which led to incorrect ports being returned and breaking S2S peer retrieval.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on both JDK 8 and JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

@thenatog I believe this PR resolves the error you and I both got during testing of PR 4263 where if a secure cluster had multiple nodes running on the same physical/virtual server using different ports, Site-to-site would fail to retrieve the peers because the certificate SAN did not match. What was happening was the request for S2S details was being replicated to all nodes, and whichever answered first used its ports, but often did not match the specific node which was queried.

Very cool, will review soon

I ran the GitHub Actions checks twice. The problem is with downloading a dependency for another module from a remote repository. Running the build on my local machine completes successfully.
[ERROR] Exception calling reference $projectsSortedByOrganization at META-INF/DEPENDENCIES.vm[line 34, column 33]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) on project nifi-hive_1_1-processors: Execution process-resource-bundles of goal org.apache.maven.plugins:maven-remote-resources-plugin:1.7.0:process failed: Error resolving project artifact: Failure to transfer eigenbase:eigenbase-properties:pom:1.1.4 from https://repository.apache.org/content/repositories/releases was cached in the local repository, resolution will not be reattempted until the update interval of apache-repo has elapsed or updates are forced. Original error: Could not transfer artifact eigenbase:eigenbase-properties:pom:1.1.4 from/to apache-repo (https://repository.apache.org/content/repositories/releases): Transfer failed for https://repository.apache.org/content/repositories/releases/eigenbase/eigenbase-properties/1.1.4/eigenbase-properties-1.1.4.pom 503 Service Unavailable for project eigenbase:eigenbase-properties:jar:1.1.4 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :nifi-hive_1_1-processors
##[error]Process completed with exit code 1.

Thanks Mark. I replied to the comments and integrated most of what you had suggested (the exception being the complete removal of the marker interface).

authors: alopresto thenatog


text:
NIFI-8034: Fixed PropertyValue.isExpressionLanguagePresent always ret…

…urns true for non-null values
Expression Language is NOT present if the 'expressions' list is empty or it contains a single StringLiteralExpression.
Otherwise EL is considered to be present.
https://issues.apache.org/jira/browse/NIFI-8034
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[x] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Thanks @turcsanyip! All looks good to me. +1 merged to main.

Thanks @turcsanyip! All looks good to me. +1 merged to main.


text:
Update Ruby gem and Github Actions packages

Summary
This slims down and updates the Ruby gems that we are using.  Removing the github-pages gem which was unused with they way that we upload the site meant we could move off a bunch of EOL gems and also on to the latest version on Jekell.
I did also have to update sass files, this was automated with sass-migrator https://sass-lang.com/documentation/cli/migrator
We are also running old versions of github actions which would spit out a warning about still using node 12. https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
Impact
Living in the future.
Testing
Passing CI should be sufficient.  Local testing also passed

@cederom  this may also make it easier for you to build locally long as you have ruby >= 2.5
Note my instructions with the updated readme.

@btashton: @cederom this may also make it easier for you to build locally long as you have ruby >= 2.5
Note my instructions with the updated readme.

Cool! Thank you @btashton! :-) Yes we have ruby 3.0, 3.1, 3.2 on FBSD :-) I will verify and report back.. just need to take some sleep its 0530AM here :-P

authors: btashton cederom

repo: apache/nuttx-website


text:
spi_slave: change length to nwords

Summary
spi_slave: keep consistent with the parameter of the spi_slave_receive function declaration
CODE size_t   (*receive)(FAR struct spi_slave_dev_s *sdev, FAR const void *data, size_t nwords);
Impact
spi slave
Testing

@FelipeMdeO please take a look

repo: apache/nuttx


text:
HDDS-9036. Create separate acceptance split for cert rotation

What changes were proposed in this pull request?
Test execution of ozonesecure-ha/test-root-ca-rotation.sh failed 23 times recently (on master, not counting PRs).  Also, acceptance (HA-secure) now takes ~1.5 hours.  Both problems could be less severe if we executed cert. rotation in its own split.
https://issues.apache.org/jira/browse/HDDS-9036
How was this patch tested?
CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/5589130892

Thanks @fapifta for the review.

Shouldn't we separate these into different compose directories as well?

Previously we had different directories, duplicating the cluster definition/configs, with very minor differences.  One reason to have multiple test scripts per directory is to avoid that.
Test scripts that can be generalised to different clusters can be placed in separate directories (e.g. common).  Currently only hadoop-ozone/dist/src/main/compose/common/hadoop-test.sh is such a test.  For example if we can implement test-certificate-rotation.sh in a way to be applicable to both HA and non-HA case, we can move it to another dir.

repo: apache/ozone