text:
Remove duplicate flickity

Looks like reaction is duping flickity w/ force's version.
https://github.com/artsy/force/pull/3963

Warnings

:warning:
The staging version of Metaphysics has breaking changes, this might not affect your build, but could mean your queries don't work the way you expect. See below for breaking changes:

:warning: Type 'AnalyticsSamplingFrequencyEnum' was removed
:warning: Argument 'samplingFrequency: AnalyticsSamplingFrequencyEnum' was removed from field 'AnalyticsArtworksPublishedStats.timeSeries'
:warning: Field 'samplingFrequency' was removed from object type 'AnalyticsArtworksPublishedTimeSeriesStats'
:warning: Field 'time' was removed from object type 'AnalyticsArtworksPublishedTimeSeriesStats'
:warning: Field 'samplingFrequency' was removed from object type 'AnalyticsPartnerTimeSeriesStats'
:warning: Field 'time' was removed from object type 'AnalyticsPartnerTimeSeriesStats'
:warning: Field 'filterDescription' was removed from object type 'AnalyticsPricingContext'

  Generated by :no_entry_sign: dangerJS against b71bbc11b6b129c13bfb86741f88f181b7c3f6c9

Duplicate Sources / Packages - Duplicates found! ⚠
Duplicates: Found 36 similar files across 46 code sources (both identical + similar)
accounting for 575167 bundled bytes.
Packages: Found 12 packages with 23 resolved, 26 installed, and 73 depended versions.
Roughly 80 lines removed.  This is probably an improvement over master.

Diff of duplicates in this branch vs master
 Duplicate Sources / Packages - Duplicates found! ⚠

-* Duplicates: Found 62 similar files across 74 code sources (both identical + similar)
+* Duplicates: Found 36 similar files across 46 code sources (both identical + similar)

-  accounting for 746080 bundled bytes.
+  accounting for 575167 bundled bytes.

-* Packages: Found 15 packages with 29 resolved, 34 installed, and 81 depended versions.
+* Packages: Found 12 packages with 23 resolved, 26 installed, and 73 depended versions.

 ## auctions.js
 acorn (Found 2 resolved, 3 installed, 3 depended. Latest 2.7.0.)
   1.2.2
     ~/with/~/acorn
       * Dependency graph
         force@1.0.0 -> jade@^1.11.0 -> with@~4.0.0 -> acorn@^1.0.1
       * Duplicated files in auctions.js
         acorn/dist/acorn.js (S, 131402)
         acorn/dist/walk.js (S, 11791)

   2.7.0
     ~/jade/~/acorn
       * Dependency graph
         force@1.0.0 -> jade@^1.11.0 -> constantinople@~3.0.1 -> acorn@^2.1.0
       * Duplicated files in auctions.js
         acorn/dist/acorn.js (I, 119975)
         acorn/dist/walk.js (I, 13326)

     ~/with/~/acorn-globals/~/acorn
       * Dependency graph
         force@1.0.0 -> jade@^1.11.0 -> with@~4.0.0 -> acorn-globals@^1.0.3 -> acorn@^2.1.0
       * Duplicated files in auctions.js
         acorn/dist/acorn.js (I, 119975)
         acorn/dist/walk.js (I, 13326)

 ## common.js
 assignment (Found 2 resolved, 2 installed, 4 depended. Latest 2.2.0.)
   2.0.0
     ~/insane/~/assignment
       * Dependency graph
         force@1.0.0 -> @artsy/palette@4.11.0 -> trunc-html@^1.1.2 -> insane@2.6.1 -> assignment@2.0.0
         force@1.0.0 -> @artsy/reaction@16.6.0 -> trunc-html@^1.1.2 -> insane@2.6.1 -> assignment@2.0.0
       * Duplicated files in common.js
         assignment/assignment.js (S, 508)

   2.2.0
     ~/assignment
       * Dependency graph
         force@1.0.0 -> @artsy/palette@4.11.0 -> trunc-html@^1.1.2 -> assignment@2.2.0
         force@1.0.0 -> @artsy/reaction@16.6.0 -> trunc-html@^1.1.2 -> assignment@2.2.0
       * Duplicated files in common.js
         assignment/assignment.js (S, 696)

 bluebird-q (Found 2 resolved, 2 installed, 2 depended. Latest 2.1.1.)
   1.0.3
     ~/artsy-backbone-mixins/~/bluebird-q
       * Dependency graph
         force@1.0.0 -> artsy-backbone-mixins@artsy/artsy-backbone-mixins -> bluebird-q@^1.0.3
       * Duplicated files in common.js
         bluebird-q/index.js (S, 14411)

   2.1.1
     ~/bluebird-q
       * Dependency graph
         force@1.0.0 -> bluebird-q@^2.1.1
       * Duplicated files in common.js
         bluebird-q/index.js (S, 16795)

 domelementtype (Found 2 resolved, 2 installed, 18 depended. Latest 1.3.0.)
   1.1.3
     ~/dom-serializer/~/domelementtype
       * Dependency graph
         force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> css-select@~1.2.0 -> domutils@1.5.1 -> dom-serializer@0 -> domelementtype@~1.1.1
         force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> dom-serializer@~0.1.0 -> domelementtype@~1.1.1
         force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domutils@^1.5.1 -> dom-serializer@0 -> domelementtype@~1.1.1
         force@1.0.0 -> @artsy/reaction@16.6.0 -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domutils@^1.5.1 -> dom-serializer@0 -> domelementtype@~1.1.1
         force@1.0.0 -> cheerio@^0.22.0 -> css-select@~1.2.0 -> domutils@1.5.1 -> dom-serializer@0 -> domelementtype@~1.1.1
         force@1.0.0 -> cheerio@^0.22.0 -> dom-serializer@~0.1.0 -> domelementtype@~1.1.1
         force@1.0.0 -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domutils@^1.5.1 -> dom-serializer@0 -> domelementtype@~1.1.1
       * Duplicated files in common.js
         domelementtype/index.js (S, 389)

   1.3.0
     ~/domelementtype
       * Dependency graph
         force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> css-select@~1.2.0 -> domutils@1.5.1 -> domelementtype@1
         force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domelementtype@^1.3.0
         force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domhandler@^2.3.0 -> domelementtype@1
         force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domutils@^1.5.1 -> domelementtype@1
         force@1.0.0 -> @artsy/reaction@16.6.0 -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domelementtype@^1.3.0
         force@1.0.0 -> @artsy/reaction@16.6.0 -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domhandler@^2.3.0 -> domelementtype@1
         force@1.0.0 -> @artsy/reaction@16.6.0 -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domutils@^1.5.1 -> domelementtype@1
         force@1.0.0 -> cheerio@^0.22.0 -> css-select@~1.2.0 -> domutils@1.5.1 -> domelementtype@1
         force@1.0.0 -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domelementtype@^1.3.0
         force@1.0.0 -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domhandler@^2.3.0 -> domelementtype@1
         force@1.0.0 -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domutils@^1.5.1 -> domelementtype@1
       * Duplicated files in common.js
         domelementtype/index.js (S, 411)

 domutils (Found 2 resolved, 2 installed, 5 depended. Latest 1.7.0.)
   1.5.1
     ~/domutils
       * Dependency graph
         force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> css-select@~1.2.0 -> domutils@1.5.1
         force@1.0.0 -> cheerio@^0.22.0 -> css-select@~1.2.0 -> domutils@1.5.1
       * Duplicated files in common.js
         domutils/index.js (I, 322)
         domutils/lib/helpers.js (I, 3930)
         domutils/lib/legacy.js (I, 2489)
         domutils/lib/manipulation.js (I, 1530)
         domutils/lib/querying.js (S, 1867)
         domutils/lib/stringify.js (S, 607)
         domutils/lib/traversal.js (I, 547)

   1.7.0
     ~/htmlparser2/~/domutils
       * Dependency graph
         force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domutils@^1.5.1
         force@1.0.0 -> @artsy/reaction@16.6.0 -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domutils@^1.5.1
         force@1.0.0 -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domutils@^1.5.1
       * Duplicated files in common.js
         domutils/index.js (I, 322)
         domutils/lib/helpers.js (I, 3930)
         domutils/lib/legacy.js (I, 2489)
         domutils/lib/manipulation.js (I, 1530)
         domutils/lib/querying.js (S, 1893)
         domutils/lib/stringify.js (S, 668)
         domutils/lib/traversal.js (I, 547)

-ev-emitter (Found 2 resolved, 4 installed, 8 depended. Latest 1.1.1.)
+ev-emitter (Found 2 resolved, 2 installed, 8 depended. Latest 1.1.1.)

   1.0.3
     ~/ev-emitter
       * Dependency graph

-        force@1.0.0 -> flickity@^2.0.5 -> ev-emitter@^1.0.2
-        force@1.0.0 -> flickity@^2.0.5 -> tap-listener@^2.0.0 -> unipointer@^2.1.0 -> ev-emitter@^1.0.1
-        force@1.0.0 -> flickity@^2.0.5 -> unidragger@^2.1.0 -> unipointer@^2.2.0 -> ev-emitter@^1.0.1
-        force@1.0.0 -> imagesloaded@^4.1.1 -> ev-emitter@~1.0.0
-      * Duplicated files in common.js
-        ev-emitter/ev-emitter.js (I, 2596)
-
-    ~/react-flickity-component/~/flickity/~/ev-emitter
-      * Dependency graph
-
         force@1.0.0 -> @artsy/reaction@16.6.0 -> react-flickity-component@^3.2.0 -> flickity@^2.1.2 -> ev-emitter@^1.0.2

-      * Duplicated files in common.js
+        force@1.0.0 -> @artsy/reaction@16.6.0 -> react-flickity-component@^3.2.0 -> flickity@^2.1.2 -> unidragger@^2.3.0 -> unipointer@^2.3.0 -> ev-emitter@^1.0.1

-        ev-emitter/ev-emitter.js (I, 2596)
+        force@1.0.0 -> @artsy/reaction@16.6.0 -> react-flickity-component@^3.2.0 -> flickity@^2.1.2 -> unipointer@^2.3.0 -> ev-emitter@^1.0.1

+        force@1.0.0 -> flickity@^2.2.0 -> ev-emitter@^1.0.2

-    ~/react-flickity-component/~/unipointer/~/ev-emitter
+        force@1.0.0 -> flickity@^2.2.0 -> unidragger@^2.3.0 -> unipointer@^2.3.0 -> ev-emitter@^1.0.1

-      * Dependency graph
+        force@1.0.0 -> flickity@^2.2.0 -> unipointer@^2.3.0 -> ev-emitter@^1.0.1

-        force@1.0.0 -> @artsy/reaction@16.6.0 -> react-flickity-component@^3.2.0 -> flickity@^2.1.2 -> unidragger@^2.3.0 -> unipointer@^2.3.0 -> ev-emitter@^1.0.1
+        force@1.0.0 -> imagesloaded@^4.1.1 -> ev-emitter@~1.0.0

-        force@1.0.0 -> @artsy/reaction@16.6.0 -> react-flickity-component@^3.2.0 -> flickity@^2.1.2 -> unipointer@^2.3.0 -> ev-emitter@^1.0.1
-
       * Duplicated files in common.js

-        ev-emitter/ev-emitter.js (I, 2596)
+        ev-emitter/ev-emitter.js (S, 2596)

   1.1.1
     ~/react-flickity-component/~/ev-emitter
       * Dependency graph
         force@1.0.0 -> @artsy/reaction@16.6.0 -> react-flickity-component@^3.2.0 -> imagesloaded@^4.1.3 -> ev-emitter@^1.0.0
       * Duplicated files in common.js
         ev-emitter/ev-emitter.js (S, 2704)

-flickity (Found 2 resolved, 2 installed, 2 depended. Latest 2.2.0.)
-  2.0.6
-    ~/flickity
-      * Dependency graph
-        force@1.0.0 -> flickity@^2.0.5
-      * Duplicated files in common.js
-        flickity/js/add-remove-cell.js (S, 4905)
-        flickity/js/animate.js (S, 5865)
-        flickity/js/cell.js (S, 2045)
-        flickity/js/drag.js (S, 11389)
-        flickity/js/flickity.js (S, 22657)
-        flickity/js/index.js (S, 991)
-        flickity/js/lazyload.js (S, 3105)
-        flickity/js/page-dots.js (S, 4307)
-        flickity/js/player.js (S, 5137)
-        flickity/js/prev-next-button.js (S, 5998)
-        flickity/js/slide.js (S, 1935)
-
-  2.2.0
-    ~/react-flickity-component/~/flickity
-      * Dependency graph
-        force@1.0.0 -> @artsy/reaction@16.6.0 -> react-flickity-component@^3.2.0 -> flickity@^2.1.2
-      * Duplicated files in common.js
-        flickity/js/add-remove-cell.js (S, 4115)
-        flickity/js/animate.js (S, 5373)
-        flickity/js/cell.js (S, 2378)
-        flickity/js/drag.js (S, 11596)
-        flickity/js/flickity.js (S, 24706)
-        flickity/js/index.js (S, 997)
-        flickity/js/lazyload.js (S, 3807)
-        flickity/js/page-dots.js (S, 4793)
-        flickity/js/player.js (S, 4511)
-        flickity/js/prev-next-button.js (S, 5789)
-        flickity/js/slide.js (S, 1843)
-
-
 hoist-non-react-statics (Found 1 resolved, 2 installed, 3 depended. Latest 3.1.0.)
   3.1.0
     ~/react-redux/~/hoist-non-react-statics
       * Dependency graph
         force@1.0.0 -> @artsy/reaction@16.6.0 -> found@^0.3.14 -> react-redux@^5.0.7 -> hoist-non-react-statics@^3.1.0
         force@1.0.0 -> react-redux@^5.0.2 -> hoist-non-react-statics@^3.1.0
       * Duplicated files in common.js
         hoist-non-react-statics/dist/hoist-non-react-statics.cjs.js (I, 2553)

     ~/react-tracking/~/hoist-non-react-statics
       * Dependency graph
         force@1.0.0 -> @artsy/reaction@16.6.0 -> react-tracking@^5.6.0 -> hoist-non-react-statics@^3.0.1
       * Duplicated files in common.js
         hoist-non-react-statics/dist/hoist-non-react-statics.cjs.js (I, 2553)

 imagesloaded (Found 2 resolved, 2 installed, 2 depended. Latest 4.1.4.)
   4.1.2
     ~/imagesloaded
       * Dependency graph
         force@1.0.0 -> imagesloaded@^4.1.1
       * Duplicated files in common.js
         imagesloaded/imagesloaded.js (S, 9658)

   4.1.4
     ~/react-flickity-component/~/imagesloaded
       * Dependency graph
         force@1.0.0 -> @artsy/reaction@16.6.0 -> react-flickity-component@^3.2.0 -> imagesloaded@^4.1.3
       * Duplicated files in common.js
         imagesloaded/imagesloaded.js (S, 9965)

 inherits (Found 2 resolved, 2 installed, 13 depended. Latest 2.0.3.)
   2.0.1
     ~/util/~/inherits
       * Dependency graph
         force@1.0.0 -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> util@^0.10.3 -> inherits@2.0.1
       * Duplicated files in common.js
         inherits/inherits_browser.js (I, 672)

   2.0.3
     ~/inherits
       * Dependency graph
         force@1.0.0 -> @artsy/passport@1.1.1 -> superagent@^1.2.0 -> readable-stream@^2.3.5 -> inherits@~2.0.3
         force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> inherits@^2.0.1
         force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> readable-stream@^3.0.6 -> inherits@^2.0.3
         force@1.0.0 -> @artsy/reaction@16.6.0 -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> inherits@^2.0.1
         force@1.0.0 -> @artsy/reaction@16.6.0 -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> readable-stream@^3.0.6 -> inherits@^2.0.3
         force@1.0.0 -> @artsy/reaction@16.6.0 -> superagent@^3.6.3 -> readable-stream@^2.3.5 -> inherits@~2.0.3
         force@1.0.0 -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> inherits@^2.0.1
         force@1.0.0 -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> readable-stream@^3.0.6 -> inherits@^2.0.3
         force@1.0.0 -> superagent@^3.8.3 -> readable-stream@^2.3.5 -> inherits@~2.0.3
         force@1.0.0 -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> readable-stream@^2.3.3 -> inherits@~2.0.3
         force@1.0.0 -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> stream-browserify@^2.0.1 -> inherits@~2.0.1
         force@1.0.0 -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> stream-browserify@^2.0.1 -> readable-stream@^2.0.2 -> inherits@~2.0.3
       * Duplicated files in common.js
         inherits/inherits_browser.js (I, 672)

 isarray (Found 2 resolved, 2 installed, 4 depended. Latest 1.0.0.)
   0.0.1
     ~/isarray
       * Dependency graph
         force@1.0.0 -> @artsy/reaction@16.6.0 -> found@^0.3.14 -> path-to-regexp@^1.7.0 -> isarray@0.0.1
         force@1.0.0 -> @artsy/reaction@16.6.0 -> react-router@^4.2.0 -> path-to-regexp@^1.7.0 -> isarray@0.0.1
         force@1.0.0 -> react-router@^4.2.0 -> path-to-regexp@^1.7.0 -> isarray@0.0.1
       * Duplicated files in common.js
         isarray/index.js (S, 120)

   1.0.0
     ~/buffer/~/isarray
       * Dependency graph
         force@1.0.0 -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> buffer@^4.3.0 -> isarray@^1.0.0
       * Duplicated files in common.js
         isarray/index.js (S, 132)

 qs (Found 2 resolved, 2 installed, 6 depended. Latest 6.5.2.)
   5.2.0
     ~/artsy-backbone-mixins/~/qs
       * Dependency graph
         force@1.0.0 -> artsy-backbone-mixins@artsy/artsy-backbone-mixins -> qs@5.2.0
       * Duplicated files in common.js
         qs/lib/index.js (S, 200)
         qs/lib/parse.js (S, 5363)
         qs/lib/stringify.js (S, 3906)
         qs/lib/utils.js (S, 4319)

   6.5.2
     ~/qs
       * Dependency graph
         force@1.0.0 -> qs@^6.3.0
         force@1.0.0 -> @artsy/passport@1.1.1 -> superagent@^1.2.0 -> qs@^6.5.1
         force@1.0.0 -> @artsy/reaction@16.6.0 -> qs@^6.5.0
         force@1.0.0 -> @artsy/reaction@16.6.0 -> superagent@^3.6.3 -> qs@^6.5.1
         force@1.0.0 -> superagent@^3.8.3 -> qs@^6.5.1
       * Duplicated files in common.js
         qs/lib/index.js (S, 211)
         qs/lib/parse.js (S, 5817)
         qs/lib/stringify.js (S, 6288)
         qs/lib/utils.js (S, 5554)

 redux (Found 2 resolved, 3 installed, 5 depended. Latest 4.0.1.)
   3.6.0
     ~/redux
       * Dependency graph
         force@1.0.0 -> redux@^3.6.0
       * Duplicated files in common.js

   4.0.1
     ~/farce/~/redux
       * Dependency graph
         force@1.0.0 -> @artsy/reaction@16.6.0 -> farce@^0.2.6 -> redux@^4.0.0
         force@1.0.0 -> @artsy/reaction@16.6.0 -> found-scroll@^0.1.5 -> farce@^0.2.1 -> redux@^4.0.0
         force@1.0.0 -> @artsy/reaction@16.6.0 -> found@^0.3.14 -> farce@^0.2.6 -> redux@^4.0.0
       * Duplicated files in common.js
         redux/es/redux.js (I, 23104)

     ~/found/~/redux
       * Dependency graph
         force@1.0.0 -> @artsy/reaction@16.6.0 -> found@^0.3.14 -> redux@^4.0.0
       * Duplicated files in common.js
         redux/es/redux.js (I, 23104)

-unidragger (Found 2 resolved, 2 installed, 2 depended. Latest 2.3.0.)
-  2.2.0
-    ~/unidragger
-      * Dependency graph
-        force@1.0.0 -> flickity@^2.0.5 -> unidragger@^2.1.0
-      * Duplicated files in common.js
-        unidragger/unidragger.js (S, 6873)
-
-  2.3.0
-    ~/react-flickity-component/~/unidragger
-      * Dependency graph
-        force@1.0.0 -> @artsy/reaction@16.6.0 -> react-flickity-component@^3.2.0 -> flickity@^2.1.2 -> unidragger@^2.3.0
-      * Duplicated files in common.js
-        unidragger/unidragger.js (S, 6786)
-
-unipointer (Found 2 resolved, 2 installed, 4 depended. Latest 2.3.0.)
-  2.2.0
-    ~/unipointer
-      * Dependency graph
-        force@1.0.0 -> flickity@^2.0.5 -> tap-listener@^2.0.0 -> unipointer@^2.1.0
-        force@1.0.0 -> flickity@^2.0.5 -> unidragger@^2.1.0 -> unipointer@^2.2.0
-      * Duplicated files in common.js
-        unipointer/unipointer.js (S, 6874)
-
-  2.3.0
-    ~/react-flickity-component/~/unipointer
-      * Dependency graph
-        force@1.0.0 -> @artsy/reaction@16.6.0 -> react-flickity-component@^3.2.0 -> flickity@^2.1.2 -> unipointer@^2.3.0
-        force@1.0.0 -> @artsy/reaction@16.6.0 -> react-flickity-component@^3.2.0 -> flickity@^2.1.2 -> unidragger@^2.3.0 -> unipointer@^2.3.0
-      * Duplicated files in common.js
-        unipointer/unipointer.js (S, 6946)
-
-
 * Understanding the report: Need help with the details? See:
   https://github.com/FormidableLabs/inspectpack/#diagnosing-duplicates
 * Fixing bundle duplicates: An introductory guide:
   https://github.com/FormidableLabs/inspectpack/#fixing-bundle-duplicates

Fixing bundle duplicates | An introductory guide
@zephraph

auctions.js

acorn (Found 2 resolved, 3 installed, 3 depended. Latest 2.7.0.)

1.2.2
  ~/with/~/acorn
    * Dependency graph
      force@1.0.0 -> jade@^1.11.0 -> with@~4.0.0 -> acorn@^1.0.1
    * Duplicated files in auctions.js
      acorn/dist/acorn.js (S, 131402)
      acorn/dist/walk.js (S, 11791)
2.7.0
  ~/jade/~/acorn
    * Dependency graph
      force@1.0.0 -> jade@^1.11.0 -> constantinople@~3.0.1 -> acorn@^2.1.0
    * Duplicated files in auctions.js
      acorn/dist/acorn.js (I, 119975)
      acorn/dist/walk.js (I, 13326)
  ~/with/~/acorn-globals/~/acorn
    * Dependency graph
      force@1.0.0 -> jade@^1.11.0 -> with@~4.0.0 -> acorn-globals@^1.0.3 -> acorn@^2.1.0
    * Duplicated files in auctions.js
      acorn/dist/acorn.js (I, 119975)
      acorn/dist/walk.js (I, 13326)

common.js

assignment (Found 2 resolved, 2 installed, 4 depended. Latest 2.2.0.)

2.0.0
  ~/insane/~/assignment
    * Dependency graph
      force@1.0.0 -> @artsy/palette@4.11.0 -> trunc-html@^1.1.2 -> insane@2.6.1 -> assignment@2.0.0
      force@1.0.0 -> @artsy/reaction@16.6.0 -> trunc-html@^1.1.2 -> insane@2.6.1 -> assignment@2.0.0
    * Duplicated files in common.js
      assignment/assignment.js (S, 508)
2.2.0
  ~/assignment
    * Dependency graph
      force@1.0.0 -> @artsy/palette@4.11.0 -> trunc-html@^1.1.2 -> assignment@2.2.0
      force@1.0.0 -> @artsy/reaction@16.6.0 -> trunc-html@^1.1.2 -> assignment@2.2.0
    * Duplicated files in common.js
      assignment/assignment.js (S, 696)

bluebird-q (Found 2 resolved, 2 installed, 2 depended. Latest 2.1.1.)

1.0.3
  ~/artsy-backbone-mixins/~/bluebird-q
    * Dependency graph
      force@1.0.0 -> artsy-backbone-mixins@artsy/artsy-backbone-mixins -> bluebird-q@^1.0.3
    * Duplicated files in common.js
      bluebird-q/index.js (S, 14411)
2.1.1
  ~/bluebird-q
    * Dependency graph
      force@1.0.0 -> bluebird-q@^2.1.1
    * Duplicated files in common.js
      bluebird-q/index.js (S, 16795)

domelementtype (Found 2 resolved, 2 installed, 18 depended. Latest 1.3.0.)

1.1.3
  ~/dom-serializer/~/domelementtype
    * Dependency graph
      force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> css-select@~1.2.0 -> domutils@1.5.1 -> dom-serializer@0 -> domelementtype@~1.1.1
      force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> dom-serializer@~0.1.0 -> domelementtype@~1.1.1
      force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domutils@^1.5.1 -> dom-serializer@0 -> domelementtype@~1.1.1
      force@1.0.0 -> @artsy/reaction@16.6.0 -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domutils@^1.5.1 -> dom-serializer@0 -> domelementtype@~1.1.1
      force@1.0.0 -> cheerio@^0.22.0 -> css-select@~1.2.0 -> domutils@1.5.1 -> dom-serializer@0 -> domelementtype@~1.1.1
      force@1.0.0 -> cheerio@^0.22.0 -> dom-serializer@~0.1.0 -> domelementtype@~1.1.1
      force@1.0.0 -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domutils@^1.5.1 -> dom-serializer@0 -> domelementtype@~1.1.1
    * Duplicated files in common.js
      domelementtype/index.js (S, 389)
1.3.0
  ~/domelementtype
    * Dependency graph
      force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> css-select@~1.2.0 -> domutils@1.5.1 -> domelementtype@1
      force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domelementtype@^1.3.0
      force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domhandler@^2.3.0 -> domelementtype@1
      force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domutils@^1.5.1 -> domelementtype@1
      force@1.0.0 -> @artsy/reaction@16.6.0 -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domelementtype@^1.3.0
      force@1.0.0 -> @artsy/reaction@16.6.0 -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domhandler@^2.3.0 -> domelementtype@1
      force@1.0.0 -> @artsy/reaction@16.6.0 -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domutils@^1.5.1 -> domelementtype@1
      force@1.0.0 -> cheerio@^0.22.0 -> css-select@~1.2.0 -> domutils@1.5.1 -> domelementtype@1
      force@1.0.0 -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domelementtype@^1.3.0
      force@1.0.0 -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domhandler@^2.3.0 -> domelementtype@1
      force@1.0.0 -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domutils@^1.5.1 -> domelementtype@1
    * Duplicated files in common.js
      domelementtype/index.js (S, 411)

domutils (Found 2 resolved, 2 installed, 5 depended. Latest 1.7.0.)

1.5.1
  ~/domutils
    * Dependency graph
      force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> css-select@~1.2.0 -> domutils@1.5.1
      force@1.0.0 -> cheerio@^0.22.0 -> css-select@~1.2.0 -> domutils@1.5.1
    * Duplicated files in common.js
      domutils/index.js (I, 322)
      domutils/lib/helpers.js (I, 3930)
      domutils/lib/legacy.js (I, 2489)
      domutils/lib/manipulation.js (I, 1530)
      domutils/lib/querying.js (S, 1867)
      domutils/lib/stringify.js (S, 607)
      domutils/lib/traversal.js (I, 547)
1.7.0
  ~/htmlparser2/~/domutils
    * Dependency graph
      force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> domutils@^1.5.1
      force@1.0.0 -> @artsy/reaction@16.6.0 -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> domutils@^1.5.1
      force@1.0.0 -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> domutils@^1.5.1
    * Duplicated files in common.js
      domutils/index.js (I, 322)
      domutils/lib/helpers.js (I, 3930)
      domutils/lib/legacy.js (I, 2489)
      domutils/lib/manipulation.js (I, 1530)
      domutils/lib/querying.js (S, 1893)
      domutils/lib/stringify.js (S, 668)
      domutils/lib/traversal.js (I, 547)

ev-emitter (Found 2 resolved, 2 installed, 8 depended. Latest 1.1.1.)

1.0.3
  ~/ev-emitter
    * Dependency graph
      force@1.0.0 -> @artsy/reaction@16.6.0 -> react-flickity-component@^3.2.0 -> flickity@^2.1.2 -> ev-emitter@^1.0.2
      force@1.0.0 -> @artsy/reaction@16.6.0 -> react-flickity-component@^3.2.0 -> flickity@^2.1.2 -> unidragger@^2.3.0 -> unipointer@^2.3.0 -> ev-emitter@^1.0.1
      force@1.0.0 -> @artsy/reaction@16.6.0 -> react-flickity-component@^3.2.0 -> flickity@^2.1.2 -> unipointer@^2.3.0 -> ev-emitter@^1.0.1
      force@1.0.0 -> flickity@^2.2.0 -> ev-emitter@^1.0.2
      force@1.0.0 -> flickity@^2.2.0 -> unidragger@^2.3.0 -> unipointer@^2.3.0 -> ev-emitter@^1.0.1
      force@1.0.0 -> flickity@^2.2.0 -> unipointer@^2.3.0 -> ev-emitter@^1.0.1
      force@1.0.0 -> imagesloaded@^4.1.1 -> ev-emitter@~1.0.0
    * Duplicated files in common.js
      ev-emitter/ev-emitter.js (S, 2596)
1.1.1
  ~/react-flickity-component/~/ev-emitter
    * Dependency graph
      force@1.0.0 -> @artsy/reaction@16.6.0 -> react-flickity-component@^3.2.0 -> imagesloaded@^4.1.3 -> ev-emitter@^1.0.0
    * Duplicated files in common.js
      ev-emitter/ev-emitter.js (S, 2704)

hoist-non-react-statics (Found 1 resolved, 2 installed, 3 depended. Latest 3.1.0.)

3.1.0
  ~/react-redux/~/hoist-non-react-statics
    * Dependency graph
      force@1.0.0 -> @artsy/reaction@16.6.0 -> found@^0.3.14 -> react-redux@^5.0.7 -> hoist-non-react-statics@^3.1.0
      force@1.0.0 -> react-redux@^5.0.2 -> hoist-non-react-statics@^3.1.0
    * Duplicated files in common.js
      hoist-non-react-statics/dist/hoist-non-react-statics.cjs.js (I, 2553)
  ~/react-tracking/~/hoist-non-react-statics
    * Dependency graph
      force@1.0.0 -> @artsy/reaction@16.6.0 -> react-tracking@^5.6.0 -> hoist-non-react-statics@^3.0.1
    * Duplicated files in common.js
      hoist-non-react-statics/dist/hoist-non-react-statics.cjs.js (I, 2553)

imagesloaded (Found 2 resolved, 2 installed, 2 depended. Latest 4.1.4.)

4.1.2
  ~/imagesloaded
    * Dependency graph
      force@1.0.0 -> imagesloaded@^4.1.1
    * Duplicated files in common.js
      imagesloaded/imagesloaded.js (S, 9658)
4.1.4
  ~/react-flickity-component/~/imagesloaded
    * Dependency graph
      force@1.0.0 -> @artsy/reaction@16.6.0 -> react-flickity-component@^3.2.0 -> imagesloaded@^4.1.3
    * Duplicated files in common.js
      imagesloaded/imagesloaded.js (S, 9965)

inherits (Found 2 resolved, 2 installed, 13 depended. Latest 2.0.3.)

2.0.1
  ~/util/~/inherits
    * Dependency graph
      force@1.0.0 -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> util@^0.10.3 -> inherits@2.0.1
    * Duplicated files in common.js
      inherits/inherits_browser.js (I, 672)
2.0.3
  ~/inherits
    * Dependency graph
      force@1.0.0 -> @artsy/passport@1.1.1 -> superagent@^1.2.0 -> readable-stream@^2.3.5 -> inherits@~2.0.3
      force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> inherits@^2.0.1
      force@1.0.0 -> @artsy/reaction@16.6.0 -> cheerio@^1.0.0-rc.2 -> htmlparser2@^3.9.1 -> readable-stream@^3.0.6 -> inherits@^2.0.3
      force@1.0.0 -> @artsy/reaction@16.6.0 -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> inherits@^2.0.1
      force@1.0.0 -> @artsy/reaction@16.6.0 -> react-html-parser@^2.0.2 -> htmlparser2@^3.9.0 -> readable-stream@^3.0.6 -> inherits@^2.0.3
      force@1.0.0 -> @artsy/reaction@16.6.0 -> superagent@^3.6.3 -> readable-stream@^2.3.5 -> inherits@~2.0.3
      force@1.0.0 -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> inherits@^2.0.1
      force@1.0.0 -> cheerio@^0.22.0 -> htmlparser2@^3.9.1 -> readable-stream@^3.0.6 -> inherits@^2.0.3
      force@1.0.0 -> superagent@^3.8.3 -> readable-stream@^2.3.5 -> inherits@~2.0.3
      force@1.0.0 -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> readable-stream@^2.3.3 -> inherits@~2.0.3
      force@1.0.0 -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> stream-browserify@^2.0.1 -> inherits@~2.0.1
      force@1.0.0 -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> stream-browserify@^2.0.1 -> readable-stream@^2.0.2 -> inherits@~2.0.3
    * Duplicated files in common.js
      inherits/inherits_browser.js (I, 672)

isarray (Found 2 resolved, 2 installed, 4 depended. Latest 1.0.0.)

0.0.1
  ~/isarray
    * Dependency graph
      force@1.0.0 -> @artsy/reaction@16.6.0 -> found@^0.3.14 -> path-to-regexp@^1.7.0 -> isarray@0.0.1
      force@1.0.0 -> @artsy/reaction@16.6.0 -> react-router@^4.2.0 -> path-to-regexp@^1.7.0 -> isarray@0.0.1
      force@1.0.0 -> react-router@^4.2.0 -> path-to-regexp@^1.7.0 -> isarray@0.0.1
    * Duplicated files in common.js
      isarray/index.js (S, 120)
1.0.0
  ~/buffer/~/isarray
    * Dependency graph
      force@1.0.0 -> webpack@^4.29.0 -> node-libs-browser@^2.0.0 -> buffer@^4.3.0 -> isarray@^1.0.0
    * Duplicated files in common.js
      isarray/index.js (S, 132)

qs (Found 2 resolved, 2 installed, 6 depended. Latest 6.5.2.)

5.2.0
  ~/artsy-backbone-mixins/~/qs
    * Dependency graph
      force@1.0.0 -> artsy-backbone-mixins@artsy/artsy-backbone-mixins -> qs@5.2.0
    * Duplicated files in common.js
      qs/lib/index.js (S, 200)
      qs/lib/parse.js (S, 5363)
      qs/lib/stringify.js (S, 3906)
      qs/lib/utils.js (S, 4319)
6.5.2
  ~/qs
    * Dependency graph
      force@1.0.0 -> qs@^6.3.0
      force@1.0.0 -> @artsy/passport@1.1.1 -> superagent@^1.2.0 -> qs@^6.5.1
      force@1.0.0 -> @artsy/reaction@16.6.0 -> qs@^6.5.0
      force@1.0.0 -> @artsy/reaction@16.6.0 -> superagent@^3.6.3 -> qs@^6.5.1
      force@1.0.0 -> superagent@^3.8.3 -> qs@^6.5.1
    * Duplicated files in common.js
      qs/lib/index.js (S, 211)
      qs/lib/parse.js (S, 5817)
      qs/lib/stringify.js (S, 6288)
      qs/lib/utils.js (S, 5554)

redux (Found 2 resolved, 3 installed, 5 depended. Latest 4.0.1.)

3.6.0
  ~/redux
    * Dependency graph
      force@1.0.0 -> redux@^3.6.0
    * Duplicated files in common.js

4.0.1
  ~/farce/~/redux
    * Dependency graph
      force@1.0.0 -> @artsy/reaction@16.6.0 -> farce@^0.2.6 -> redux@^4.0.0
      force@1.0.0 -> @artsy/reaction@16.6.0 -> found-scroll@^0.1.5 -> farce@^0.2.1 -> redux@^4.0.0
      force@1.0.0 -> @artsy/reaction@16.6.0 -> found@^0.3.14 -> farce@^0.2.6 -> redux@^4.0.0
    * Duplicated files in common.js
      redux/es/redux.js (I, 23104)
  ~/found/~/redux
    * Dependency graph
      force@1.0.0 -> @artsy/reaction@16.6.0 -> found@^0.3.14 -> redux@^4.0.0
    * Duplicated files in common.js
      redux/es/redux.js (I, 23104)

authors: ArtsyOpenSource artsyit zephraph


text:
@mzikherman Fair attendance checkbox in purchase form

closes https://github.com/artsy/force/issues/464
will also fix https://github.com/artsy/force/issues/532

Looks great! But some real ❌

source: gharchive/pull-request

repo: artsy/force

license: MIT

license_type: permissive

license_source: github-api


text:
feature: stub out offer detail app

This PR stubs out a new page -- an offer detail page for consignors to review an offer and submit a response.
What it looks like right now

It will live at the URL /consign/offer/3456.
Coming in followup work

Build the UI out
Tests
Remove gravityPartnerID from the offer query once it's unneeded in metaphysics

Background
Currently, there is no way for consignors to formally respond to offers. After receiving an offer via email, they can indicate their intent through a Google form, which Artsy admins must then copy over into convection's admin UI.
This PR is associated with convection#844 and convection#846.

Niiice! Looks good to me. 😄 Feel free to merge when ready.


text:
@mzikherman - Update colors to match the ones on Elan

Re: https://github.com/artsy/artsy-ezel-components/pull/13
New purple is the biggest difference...

Cool.

authors: broskoski mzikherman


text:
Image should be tappable on fair microsite

Currently, just the text is tappable. This is for the "current"  tab on the microsite

This is done in #47.

source: gharchive/issue

authors: alloy kanaabe

repo: artsy/microgravity

license: mit

license_source: bigquery


text:
Specify both prefix and suffix wildcard for ForbiddenImport pattern

Context
Is there a way to specify both prefix and suffix wildcard for ForbiddenImport pattern? We want to forbid importing R.string, R.dimen, etc classes.
Expected Behavior
The following test should pass:
val code = """
    import com.example.R.string
    import net.example.R.dimen
"""

it("should report both com.example.R.string and net.example.R.dimen") {
	val findings = ForbiddenImport(TestConfig(mapOf(ForbiddenImport.IMPORTS to "*.R.*"))).lint(code)
	assertThat(findings).hasSize(2)
}

Current Behavior
The prefix wildcard is not treated as a wildcard.
Notes
This change seems to make the test pass:
class SplitPattern(text: String,
				   delimiters: Regex = regex) {

	private val excludes = text
			.split(delimiters)
			.map { it.trim() }
			.filter { it.isNotBlank() }
+			.map { it.removePrefix("*") }
			.map { it.removeSuffix("*") }

Interesting use case. Would you mind submitting a PR with your fix? Thank you!

Off-topic - wrote a lint rule for exactly that too - https://github.com/vanniktech/lint-rules/blob/master/lint-rules-android-lint/src/main/java/com/vanniktech/lintrules/android/InvalidImportDetector.kt

authors: egor-n schalkms vanniktech

repo: arturbosch/detekt


text:
Show code snippet erros in html reports

This PR is realted with #2134
If an exception is found in the code snippet rendering instead to be too smart, or crash, or hide the error this code shows the error to the user like this:

The link opens the github issue form with some pre-filled information:

And github render that information like this:

Problems in this PR:

[ ] I don't know how to get the detekt version to autofill it. Any idea?
[ ] What if the issue is related with a plugin and not with detekt itself? We are saying to the users to report it here. Should we care about this? If we see a spam of issues related with plugins we can remove the link. What do you think?

Codecov Report

Merging #2209 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master    #2209     +/-   ##
===========================================
+ Coverage     81.19%   81.29%   +0.1%
  Complexity     2064     2064
===========================================
  Files           340      340
  Lines          5907     5930     +23
  Branches       1076     1075      -1
===========================================
+ Hits           4796     4821     +25
+ Misses          535      534      -1
+ Partials        576      575      -1

Impacted Files
Coverage Δ
Complexity Δ

...n/io/gitlab/arturbosch/detekt/cli/out/HtmlUtils.kt
100% <100%> (+7.14%)
0 <0> (ø)
:arrow_down:

...tlab/arturbosch/detekt/cli/out/HtmlOutputReport.kt
91.93% <100%> (ø)
17 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a16022b...2a4ce16. Read the comment docs.

whichDetekt() was exactly what I needed. Done, ready to review :).

authors: BraisGabin codecov-io


text:
Support default values

IMHO it might be useful to support default values for environment variables that should be in environment but it would take too much effort to specify all of them everytime you create an environment.
As an example, imagine that we have TOKEN_EXPIRATION constant that is being used in my code. I don't usually need to have different values for different environments but I'd still prefer to have it not baked in the code but rather have it as an env variable in case I wanted to actually test the feature of token expiring correctly (and not waiting an hour for token to expire).
What do you think?

OK. The concept makes perfect sense to me, but I'd prefer a different API. I think the biggest problem of this PR is that if you provide default value, you can't also specify a conversion function for that field.
I think we could simply have functions like numberWithDefault(123) which acts like number but if nothing is provided it will set the field to 123. That could be done for every conversion function.
Does that make sense?

@arturmuller, so I'm closing this since I noticed you already had managed to incorporate the default values 👍

authors: arturmuller saamo

repo: arturmuller/dotenv-utils


text:
Support new-style "serve" routes

Related: https://github.com/arturo-lang/arturo/pull/413
To be merged when & if the PR above is merged ❗

Ready to merge! 🚀

repo: arturo-lang/grafito


text:
请问如何调用这个插件，完全没有任何反应，错误也没报个

cordova.plugins.baidumap_location.getCurrentPosition((result) => {
alert('普通提示');
alert(JSON.stringify(result));
},  (error) =>{
alert(JSON.stringify(error));
});

正常来说，如果没找到这个插件 那么cordova.plugins.baidumap_location 就应该报错了，如果找到插件了，定位有问题，也会有相应的错误。
你是用的这个插件哪个版本？4.0.1么？

是的，没指定版本号，直接用的最新版

我只有在ionic项目中的使用经验。 通常来说在ionic3x项目里，要等this.platform.ready().then();,在ionic1x项目里，要等 $ionicPlatform.ready(function () {})

好像是版本问题,
请问这个插件,最低支持的cordova-android 版本是多少,
或者哪个版本能够支持 cordova-android@6.2.3

之前用android@6.3.0发现这个问题
刚刚用android@7.0.0  没发现问题

authors: Gongzhiyuan aruis iooc

repo: aruis/cordova-plugin-baidumaplocation


text:
Implement support for attachments

Refer Epic
https://github.com/arunmr1980/greenchalk-admin-dev/issues/4325

This is completed and serverless email application is deployed to UAT.


text:
Unhidden commits shouldn't be garbage collected

Description of the bug
I have several commits that have been hanging around for a month or two. I looked at my smartlog today and found they're now listed as <garbage collected>.
Expected behavior
I expected them to stay around until I hid them and not be garbage collected.
Actual behavior
git garbage collection took them and their metadata away and now I don't have record of what was in them.
Version of rustc
rustc 1.61.0 (fe5b13d68 2022-05-18)
Automated bug report
No response
Version of git-branchless
git-branchless 0.3.12
Version of git
git version 2.36.1

Hi @AaronLieberman, sorry to hear that this happened to you ☹. In principle, git-branchless generates references to keep commits around, so I'm not sure exactly what happened. Do you know if one of the following applied in your situation?

You didn't run git branchless init in your repository. In https://github.com/arxanas/git-branchless/pull/185, I suppressed the generation of GC references in a repository which hasn't been inited, to address https://github.com/arxanas/git-branchless/issues/183. But it looks like the underlying problem, which is that tig shows the GC references, seems to have been fixed, so we could revert that change.
One of these commits was created before git branchless init, and you later deleted the branch pointing to that commit. I suppose the GC ref might not have been created in that case.
You hid the commit, then git branchless gc ran at some point, and then you unhid it, but the GC ref wasn't recreated.

Would running git branchless init multiple times be a problem? I've used that to upgrade to new versions of branchless.
I'm trying to remember the sequence of events that led to this but it's been a while since I created those commits. I'm 100% sure they've been created or modified (e.g. moved) long after I branchless init'd the repo. I first created the repo probably in November, started using Branchless around December, and these commits were between 2 and 4 months old.
As for your hide/gc/unhide theory, I think it's unlikely as you described but it's possible that they were affected by some sequence of git move then git undo or git move and git unhide. This is because I sometimes move old commits forward, try to address merge conflicts, then decide it's not worth it right now so abort. However, it seems strange that all 4 of my old commits disappeared at the same time. I guess if I managed to remove all the gc references through various actions and then a gc pass cleaned them up.
Is there a way to get rid of them from this repo so they're not showing in the smartlog? They fail to hide because they can't be found.

@AaronLieberman the simplest way to get rid of them is to attach branches to any commits you care about, then delete the event log database at .git/branchless/db.sqlite3. The principled solution is probably to add some git branchless repair command which will reconcile any mismatched commits/branches.

authors: AaronLieberman arxanas

repo: arxanas/git-branchless


text:
ci: provide Nix overlay

Currently Nix is only used for CI. With this contribution using the development version of git-branchless will become very ergonomic for Nix users.
For example, Nix users with experimental-features = nix-command flakes enabled can now use
nix shell github:arxanas/git-branchless

to be dropped into a shell where the latest git-branchless is available.
Users who like to be on the bleeding edge can add git-branchless to their flake inputs and use the included overlay to add git-branchless to their profile.
{
  inputs.git-branchless.url = "github:arxanas/git-branchless";

  outputs = { self, nixpkgs, git-branchless, ... }:
    let
      system = "x86_64-linux";
      pkgs = import nixpkgs {
        inherit system;
        overlays = [ git-branchless.overlay ];
      };
    in {
      # flake outputs ...
      # pkgs.git-branchless refers to the GitHub version
    };
}

Neat! If this isn't obvious for Nix users, would you mind adding a subpage of Installation in the Wiki with instructions for Nix users?

Done: https://github.com/arxanas/git-branchless/wiki/Nix-flake

@hmenke thanks, looks great!

authors: arxanas hmenke


text:
Move DETR partitioner to use transformers.pipeline

Simplifies the inference code slightly and adds batch support.
note: I haven't changed the model server response parsing yet, need to verify the API there.

We might end up changing some of this to better handle large pdfs. I am okay if you want to get this in, just with the understanding that it might change again.
Can you remove the empty file "gpu_pdf.py"?

@bsowell I didn't to send this out, I'm closing this PR since the pipelines out of the box has quality issues.

repo: aryn-ai/sycamore


text:
Required depth of 10 for rules to run

I tried refactoring by creating a loop and doing it dynamically but tests would fail, so I followed your example.

Coverage increased (+0.02%) to 99.318% when pulling 67af3adfe645d7fd5a025380b17d70d9f52b4257 on Points:master into 36e9e834c10582cc5da8b3acf61a4af344e62d10 on asafschers:master.

authors: coveralls pts-owentran

repo: asafschers/scoruby


text:
AsciidocFX v1.3.8 Windows .exe installer does not install on Windows 8 64bits

Hello
I have

Java 8 u 60
Windows 8 64 bits

With the following installer:

AsciidocFX_Windows.exe (v1.3.8)

In command (even without command):
D:\>AsciidocFX_Windows.exe

D:\>

Always shows this image (Even if I execute in C)

I don´t get some kind of error stack trace.
I only can install using the .zip file version. I can´t use the .exe installer.
What is wrong?

@manueljordan  Did you try to execute in Admin mode ?

No, I just have open the command window, and execute the .exe file.
But I confirm it is due the lack of permissions just after to enter to the C:\Windows\Temp
when the OS show a warning window about it requires admin permission, after to say Yes. All works fine now.

Thank you @manueljordan It may be about install4j settings, I will review its options.

No problem @rahmanusta . The error image was not clear.
Therefore, for this case an error about lack of writing permissions would be better.

authors: manueljordan rahmanusta

repo: asciidocfx/AsciidocFX


text:
VCS (Git) integration?

Have you considered integrating some form of VCS into this program (specifically, Git via JGit)? I think it would add a very helpful feature for writing books.

Yes, @JordanMartinez , My thoughts exactly. If you have a JavaFX background I would happy if you contribute this feature.

Let me share my programming history. I first learned how to program in Java via Stanford's "Introduction to Programming" MOOC, and soon after that learned Groovy via the "Groovy in Action" book. With JavaFX, I've read through the tutorials, watched a couple of videos, written a program up to v1.0 and have been recently contributing to some of Tomas Mikula's projects: RichTextFX (refactoring or adding some smaller features. I haven't been implementing any new major designs/features), ReactFX (small features and mainly documentation), and Flowless (refactoring).
So, I'm not sure how much of my code would adhere to best practices or design patterns (though I've studied those to some extent as well). I'd like to do this as a way to learn how to better program, but I'm not sure how soon I will get to it since there are still a few things to do on the RichTextFX project and my own program.
As for the work itself, I'd like to propose my idea for what the final outcome would be when this feature gets implemented. After that, I want to know what your idea is.
Since I use IntelliJ's Idea IDE, my idea is heavily influenced by their VCS integration. I've found it easy to use and simple to understand, virtually taking away the need for me to use the Command Line (though that options still exists obviously).
I'm assuming that Git would be integrated first due to its popularity before other VCS would. So, based on that and my IDE's integration, a lot of front-end stuff would need to be built:

A side-bar "Git" menu (probably on the bottom) that displays:

the branches visually, their commit messages, and hash
buttons that do typical git commands
a file-tree viewer that displays the changes made in each commit

Additionally, there would need to be a context menu when one right-clicks on one of the branches or other parts of the menu's components.
When comparing two views or merging branches together, an additional dialog would display both versions of the text and highlight their differences.

For the back-end, JGit would be used. I'm not familiar with JGit, but I know that the tutorials and examples out there, along with some experimentation, would bring me up to speed.

Another thing I thought of recently... When comparing two views, one should be able to switch back and forth from the plain-text asciidoc and the result of parsing that asciidoc (the browser view). So, they don't just see what the textual differences are but the final output differences.

@JordanMartinez, thanks for raising a very import issue but does  Git support have to be provided by AsciidocFX? I've been using SmartGit for version control and AsciidocFX to edit my Asciidoc files. This approach has worked very well for me as documented in the following article:
http://wfouche.github.io/Blog/2015-12-Asciidoc/
In this way I think we might get the best of both worlds: Git support being provided by Git experts, and  thus allowing the  AsciidocFX development effort  to focus exclusively on adding only Asciidoc editing and display features to the AsciidocFX editor.
What do you think of the alternative proposal?

In this way I think we might get the best of both worlds: Git support being provided by Git experts, and thus allowing the AsciidocFX development effort to focus exclusively on adding only Asciidoc editing and display features to the AsciidocFX editor.

I still think implementing Git support directly into AsciidocFX would be the most user-friendly way. (It's already there as opposed to needing to open a new application.) Additionally, I think one disadvantage to the SmartGit approach is that it wouldn't be able to show the outputted differences as well as AsciidocFX could. Yes, it can show the plain-text differences but can't show the final look differences.
Even so, you make a very good point about limiting the scope. The author of these JGit cook book examples even admits

The JGit framework is rich and diverse, it has two layers, a low-level api and a higher-level set of porcelain commands. This can be a bit intimidating at first as there are lots of classes, some of which are not relevant for most tasks (emphasis mine).

I don't know if SmartGit allows plugins. If they do, you might argue the following argument.

What if AsciidocFX wrote a plug-in for SmartGit that would display the final parsed results of two asciidoc files when they are being compared? This would remove the disadvantage you mentioned above.

I will admit that this might be a good intermediate step (letting the experts stay in their fields), but since it still requires opening up two separate applications, it's still less user-friendly than the direct support.
So, some questions I have...

Being unfamiliar with JGit, does it include any undesirable license restrictions if it is used?
How hard would it be to add Git support via JGit? How easy is it to screw up the implementation?
If implemented, what extra maintenance would it entail?
What if the one who implements this feature leaves or stops contributing? How likely will a need arise where someone else will need to later update his/her code and how hard would that be?

A Third Approach
I think a better approach than both our suggestions above would be to start a new open-sourced project called JGitFX. This project would focus only on implementing JGit with a JavaFX GUI. Projects that depend upon it could then write their own code on top of it for handling any additional requirements (such as displaying the final look of the parsed asciidoc).
With this third approach, we'd have a better solution for everyone:

Experts stay in their fields
Direct Git support via a dependency
Allows final look comparison
Open-sourced project means other people can more easily implement JGit into their JavaFX project.

What are your thoughts?

Hi @JordanMartinez and @wfouche . Thanks for your valuable thoughts.

Just FYI, I looked through GitHub to see what else was "out there" and came across the Apache License v2 GitFx that seems to be the equivalent of my JGitFX idea.
However, they've mentioned this in their wiki page, "Designs":

After some iterations it is well established that a better Design Pattern is desired for GitFx. The controller is the place for a lot of code smell and its mandatory to have a design in place which can easily manifest separation of concern. In favour of the above we would be evaluating Afterburner from Adam Bien. The framework is based on MVP framework and leverages Convention over Configuration and dependency Injection. We need that the most for GitFx to avoid classes from picking up dependency on every utility making the software more convoluted. One other objective is to have all the pieces designed in such a way (loosely coupled) that they can be reused in a Android application by making minimal or no change. JavaFX applications can be packaged as a Android Application. The intent is not to have all functionalities of the desktop application but expose a few on the android application e.g: Reviewing commit history, accepting pull requests, statistics of the repository, provide review comments etc.

Due to the above statement, it seems like they'll be doing some major refactoring before things settle down a bit more. Thus, I don't know how soon we could use their code in this project.

Having looked at GitFx a bit more, turns out it's a Git Client made in JavaFX. So, I think we would need to fork it and use it as a base to start from rather than add it directly in this project.

@rahmanusta I like the simple "push/pull/merge" for the first step, but what ultimately do we want to support? Could we first define what the final goal of all this would be and then define what distinguishable steps to take to get there?
My idea of JGitFX would be to provide the necessary GUI components over JGit that one could customize for their specific code. For example, it would have things like:

customizable menu items that can be inserted into a project's MenuBar
buttons for specific purposes that can be placed anywhere throughout the SceneGraph: commit, push, pull, revert, rebase, cherry-pick, etc.
a commit history view that displays
the various branches and their commit messages, authors, and dates
a more detailed description of the selected commit
a file tree view that displays what files were changed in the selected commit
ContextMenus that appears when one right-clicks on some component
a customizable Comparer (this would be where developers could further customize the code to account for differences that don't appear in plain text. In our case, it would be where the parsed Asciidoc's output of both commits could be compared)

With the GUI components set up, developers that depend on it would be responsible for integrating it into their code:

including the provided menu item into their project's menu bar (optional)
including some trigger that will display the described commit history view above
other plumbing necessities (saving/loading the file(s) from the repository)
customizing the Comparer

In answering my own questions:

Being unfamiliar with JGit, does it include any undesirable license restrictions if it is used?

No. JGit is licensed under the Eclipse Distributed License (essentially the BSD-Clause 3 License).

How hard would it be to add Git support via JGit? How easy is it to screw up the implementation?
What if the one who implements this feature leaves or stops contributing? How likely will a need arise where someone else will need to later update his/her code and how hard would that be?

If the JGitFX project was created, then...

Experts could stay in their respective fields: the AsciidocFX developers who perhaps don't have experience working with JGit wouldn't need to work on it. It would be easier to integrate JGitFX rather than write the entire thing themselves. Hopefully, JGitFX would attract developers with such experience or those who are willing to learn it. In this way, it it would be harder to screw up the implementation because of the greater chance of the project being developed by "experts."
There is some danger to this, especially if the project starts with enthusiasm and then dies off quickly. However, since it'd be open-sourced, another could fork it and continue it in a different direction.

If implemented, what extra maintenance would it entail?

Once implemented, GUI-related things wouldn't need to be refined unless some refactoring was done on AsciidocFX's GUI itself. If the described Comparer code uses some of AsciidocFX's own parsing code, not much maintenance will need to be done there either.
This all sounds rather optimistic so feel free to hit my ideas with some realism.

@JordanMartinez I'm aware of JGitFX project, but I don't remember how much is it good. If there is a working Git panel implemented in JavaFX, it is enough for us. Integrating to AsciidocFX is easy part.

I did another search and found another git client written in JavaFX called CodeBridge (technically written in Scala, not Java). It's licensed under GPLv3.

Seems great, but doesn't fit for us

Aye.... Looks like we'll have to go with my original idea of creating a separate project for this.
Just to be clear, GitFX is the git client we've mentioned above, but JGitFX is the easy git-integration project I've proposed. I've started JGitFX as a project to address this issue and provide a sample Git panel and other related things.

I agreed with you @JordanMartinez :+1:

Thanks :smile: I just had to exhaust all other options first.

I want to give an update on JGitFX. Using JGit isn't particularly hard, especially when using the high porcelain commands via the Git object. So, I don't think my library will have issue with that.
Currently, I'm trying to figure out how to best design a DirectoryWatcher that will update a TreeView when files change. Additionally, I want it to update each listed file's text's color in accordance with its state: Added, Modified, Ignored, etc. I've been looking into Tomas Mikula's LiveDirsFX as a way to do this. However, I'm not sure if it would be easy to build on top of it (e.g., if implemented into AsciidocFX, it would need to customize my base code to work with their already-working code).
On top of that, I'm still deciding whether that same library would be worth using in dialogs (such as commit dialogs, revert dialogs, etc.).

Hi @JordanMartinez . Great work!
We are using watchservice in AsciidocFX and it is integrated with TreeView. But, I'm planning to improve it by supporting multiple child dir watching.

I would love to be able to give my non-technical colleagues the ability to directly operate on adoc files in github via AsciidocFX without them needing to know anything about git.

Use their ssh or username / password credentials to connect to our organization's github account
Browse the repos
Open a repo like a directory view (but not require a git clone if possible)

Select or create a branch but mostly work on master

Directly open any adoc files and edit them
Save their changes back directly to github repo as a commit

Allow them to add a commit message

It would be nice but not required to do things like git diff, but that can be done with another tool

@rberger It seems to me that your idea, although convenient for non-technical persons, might be problematic due to the presumptions behind it. Essentially, it appears to me that you're trying to force an "Open-Edit-Save" mentality that is common with most computer programs onto a "Open/Clone/Fork-Checkout/Revert/Stash-Edit-Commit/Stash/Merge/Rebase mentality. In other words, it seems to me that you're trying to force a large rectangle to fit inside of a small triangle.
Having no knowledge of your constraints, the "non-techy-ness" of your non-technical colleagues, or your project's goals, I just wonder if you would be creating more problems for yourself if this was implemented than if those non-technical people just learned how to use Git.

Just an update...
I'm getting busier with a new job and am not sure how much that will impact the amount of time I'll have to spend on JGitFX. Additionally, RichTextFX has a new snapshot release. I started JGitFX as a way to kill time while I waited for an issue there to get resolved, so that also affects the amount of time I'll spend on it.
With that being said, the recent work on JGitFX has largely been figuring out how to best design JGitFX so that others besides AsciidocFX can easily integrate JGit into their application. As such, I haven't made more progress in covering all the Git commands as much as I have been refactoring the code I currently have.
Also, I've realized that the best way to learn how to write JGit code correctly is to view the project's tests. Granted, not every use-case is covered there (as far as I can tell), but it demonstrates things not found in jgit-cookbook, which only goes so far before it doesn't cover what I need.

@rahmanusta I wanted to give you another update. I won't be able to continue working on JGitFX due to getting another job and starting school in the Fall. With my remaining time, I'll be working on my own project.
So, as desirable as this feature might be to have, I can't say when I'd be able to write a version of JGitFX that could be easily incorporated into this project. At the same time, I wonder if the main JGit developers might be able to design JavaFX GUIs within their own project. (I think they have such items for Swing, but I'm not sure.) No doubt, the JGit aspect of that code wouldn't be a problem for them, just the JavaFX aspect.

Still would be a great asset!

authors: JordanMartinez poidi rahmanusta rberger wfouche


text:
When generating PDF, how can I have a level title generated from a new page?

As you can see, the title starts on a new page

Please ask questions in the project chat at https://chat.asciidoctor.org as the issue template requested. The issue tracker is not a support portal.

repo: asciidoctor/asciidoctor-pdf


text:
Allow text decoration for headings

Is there some way to enable text decoration (specifically underline) for headings?
If not could support be added in the future? Underlined headings are a very typical things in many types of documents. It kind of limits my ability to design the document after our corporate style.

Would it be enough to be able to set a border, or does it need to be an underline?
The reason I ask is because I'm trying as much as possible to map to the constructs of CSS. So I'm just thinking about what we'd use in CSS to accomplish this styling.
Aside from that detail, I support the idea. We definitely want to allow you to match your branding requirements. That's the main idea of the theme system.

https://www.w3schools.com/cssref/css3_pr_text-decoration-color.asp
No idea which version of CSS the prawn toolchain supports at the moment.

Cool! I didn't realize the extended styles for text-decoration got accepted. That's great news.

No idea which version of CSS the prawn toolchain supports at the moment.

Prawn doesn't support CSS at all. We're just designing a theming system (which is entirely an Asciidoctor PDF construct) to encompass the spirit / terminology of CSS so it feels familiar to designers and web developers. The only thing that CSS provides us is the terminology.

Thanks for the clarification about your needs for border vs text decoration. It's clear to me that we'll need to provide both options, so I'll keep this as a discrete issue.

I actually just realized that I misread your initial question. I read "border" as basically a horizontal rule. Not what I meant at all. Whatever is easier to implement I would be happy with a border. The difference to me is that a border is somewhat detached from the text whereas the underline with some glyphs runs "through" the text and therefore is more easily identified as an underline and not a style of the block the text sits in. It probably won't make a difference to must users. I would prefer underline.
Having the other options available would be cool too. Having borders around certain elements defined in the theme.yaml would be amazing. I could add borders around filenames or paths.
Then I start thinking about all the ::before use cases ;)

The other big difference of a border vs an underline is that the border extends to the width of the content area whereas the underline only extends to the end of the text.
Drawing borders around arbitrary elements is hard at the moment, but I'm working on finding a way to make it possible. With Prawn, we literally have to draw everything you see...so it's a lot of work to do what we're used to getting from CSS "for free".

Sounds like a good argument for underline to me ^^

I realized that text decoration and border are two separate concerns. We can add support for text decoration and then address the border separately. It looks like the framework is already in place, so this shouldn't be terribly difficult to add.


text:
table font_size is not applied for a| cells

Theme file snippet:
base:
  font_size: 12

table:
  border_color: a0a0a0
  border_width: $base_border_width
  font_size: 8.5

Asciidoctor snippet:
...
| `ORIGIN`
| `VARCHAR(100)`
| Source system code. `ice#dp_contact_official#denied_entity`

| `SOURCE_ID`
| `VARCHAR(200)`
| Identifier of the denied entity in the list of given type.

| `TYPE`
| `INT`
a|
Type of the entity:

- `1` -- Individual Person
- `2` -- Legal entity
- `3` -- Other
...

How it looks like:

I believe that font size specified for table should be applied to all cells.

Got it. Let us hope we will resolve it sometime in the future.

@mojavelinux: just replied to your remark in #852: making this a scale (%) in the yaml (for both adoc and non-adoc table content) would be great.

It took me a bit to figure out that this was the cause of my inability to format a table cells.
Is there a workaround? I'm trying to figure out if there's a way to add some specificity to the cells so that I can apply a small font_size to the a cells.

@mojavelinux Can you point me to the relevant code where the sub-document rendering is triggered? I'd like to try my hand at adding this feature.

Hi @DaneWeber,
Did you have the opportunity to look at this yet?
Maybe we can come up with a 'simple solution' (affecting only text-size...). Would be wonderful. Not Ruby-savvy here, but if I can help, I'd love to.

Are there any news or solutions for this issue?
I understand the difficulties that could arise when using sections, etc. inside the cell so maybe inheriting the font size could be optional via a separate setting in the theme. This would make it work at least when just simple formatting like lists or images are used.
Also the proposed scale factor would be fine.
It somehow works when using the docbook/FOP toolchain but I don't know to which extend.

If we ignore the style overrides from elements in the cell, this is rather easy to implement. I have submitted a proposal that merely inherits the font properties from the table (like other cells). See https://github.com/asciidoctor/asciidoctor-pdf/pull/1678

It somehow works when using the docbook/FOP toolchain but I don't know to which extend.

This is not a helpful statement since that's a completely different technology. You're comparing apples to oranges.

Thx, will test it as soon as it lands into master.

I think I can implement a very crude font scaling for elements that define their own font size. They would be scaled by the ratio of the table font size to the base font size. It may miss some cases, but we can deal with those.
Since this change is rather significant, I think we may need to consider a global setting to disable this behavior.

They would be scaled by the ratio of the table font size to the base font size. It may miss some cases, but we can deal with those.

Sounds good!

I think I can implement a very crude font scaling for elements that define their own font size. They would be scaled by the ratio of the table font size to the base font size. It may miss some cases, but we can deal with those.

This sounds good, thank you!

It somehow works when using the docbook/FOP toolchain but I don't know to which extend.

This is not a helpful statement since that's a completely different technology. You're comparing apples to oranges.

Yes, but maybe they should produce a rather similar output when using similar style/template settings and using the same asciidoc source. There are other features which work well with Asciidoctor-PDF but do not seem to work with docbook/FOP (e.g. column headers).

I'm glad you like the idea.

maybe they should produce a rather similar output when using similar style/template settings and using the same asciidoc source.

Aside from the AsciiDoc source, there's nothing similar about these technologies. They have completely different ways of working and of styling. You could say that you're able to do something with FOP and you'd like to be able to do it with Asciidoctor PDF. And that's useful. But just because it works in FOP doesn't mean it does or can work here in this converter.

Let's say that by default the font properties inherit from table (which also means the font of nested blocks will be scaled). To disable this behavior, you can set table_asciidoc_cell_style: initial in the theme. In this case, initial means to reset the styling back to what it would be initially, ignoring the table cell styles. In other words, initial means "don't inherit".

I think this PR is ready to go.

Thx, looks good for me
The only "issue" is that literal cells are not affected:

I will just stop using literal cells and for me issue is closed, thank you again!

You're right that literal cells are something entirely different. They take on the size of the code block, not the table cell (though it might be reasonable to consider scaling that font size too).

Thank you!

You're welcome!
If you'd like to file that follow-up issue for literal table cells, go ahead.

authors: 7SW DaneWeber habamax logicsalad mojavelinux


text:
24-bit color support

It would be really excellent if asciinema understood the 24-bit color extension, which is supported by XTerm and a number of other terminal emulators like iTerm2.
The 24-bit color uses these extensions to the SGR command:
To set foreground: CSI 38 ; 2 ;  ;  ;  m
To set background: CSI 48 ; 2 ;  ;  ;  m
In the above,   and  are 8-bit values for red green and blue channels, printed e.g. via %d.
For example, here are corresponding Go strings for this, as I use them in Tcell - these are terminfo strings that can be displayed via tparam() using r, g, b values as the 3 parameters:
"\x1b[38;2;%p1%d;%p2%d;%p3%dm"
"\x1b[48;2;%p1%d;%p2%d;%p3%dm"
While terminfo doesn't have capabilities for this, I do have support for them in my tcell terminal handling package (see https://github.com/gdamore/tcell ), which allows users/programmers to get the actual intended colors instead of whatever theme overrides may be present.  This is mostly useful for displaying images, or in terminal based games (see https://github.com/gdamore/proxima5 for what I am talking about.)

Thanks for suggestion. I started work on this in #30.

Cool !  Thanks!
Sent from my iPhone

On May 20, 2016, at 12:06 PM, Marcin Kulik notifications@github.com wrote:
Thanks for suggestion. I started work on this in #30.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@gdamore https://asciinema.org/a/46488
Could you try recording some true color demos (tcell, proxima5 etc) ?

Yeah sure.  Give me a few. :-)
On Wed, May 25, 2016 at 10:02 AM, Marcin Kulik notifications@github.com
wrote:

Closed #29 https://github.com/asciinema/asciinema-player/issues/29.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/asciinema/asciinema-player/issues/29#event-672060226

https://asciinema.org/a/eahnoti2srkdnk2uobps4101y
On Wed, May 25, 2016 at 11:13 AM, Garrett D'Amore garrett@damore.org
wrote:

Yeah sure.  Give me a few. :-)
On Wed, May 25, 2016 at 10:02 AM, Marcin Kulik notifications@github.com
wrote:

Closed #29 https://github.com/asciinema/asciinema-player/issues/29.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/asciinema/asciinema-player/issues/29#event-672060226

Awesome! I just made it a "featured recording" ;)

authors: gdamore sickill

repo: asciinema/asciinema-player


text:
Model-based text pages

Pages such as the homepage and the larp landing page could use a model to store their contents. That way they can be updated without requiring a code push, which saves time and increases accessibility to non-technical staff.

Closed by e876417

repo: ashbc/tgrsite

license: isc


text:
add option to output yaml

This is useful when trying to write machine configs:
https://github.com/openshift/machine-config-operator/tree/e9033544f42191376529efdb7a67deb5427efd1d#applying-configuration-changes-to-the-cluster

rebased on top of latest master. Marking as "Ready for review"

New version pushed to address comments.

repo: ashcrow/filetranspiler


text:
RFE: accept sysroot overrides/prefixes for etc and usr

Two usecases I have stepped onto in the past, which would be nice to cover here:

non-canonical /usr mountpoint (torcx case): during an A/B /usr partition upgrade, there is a point where software needs to inspect the next /usr (which is mounted under a tmpdir). In this case, os-release path looks like /tmp/xxx123/lib/os-release
chroots/containers (ignition case): at initramfs time, /usr and /etc belong to the initramfs image, while the actual root is being prepared somewhere else (e.g. /sysroot). In this case, os-release path looks like /sysroot/usr/lib/os-release

Work split into:

https://github.com/ashcrow/osrelease/issues/2
https://github.com/ashcrow/osrelease/issues/3

Keeping this as the RFE which should close when the two issues have been implemented.

authors: ashcrow lucab

repo: ashcrow/osrelease


text:
🛑 Website (ashhhleyyy.dev) is down

In 897fcec, Website (ashhhleyyy.dev) (https://ashhhleyyy.dev/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Website (ashhhleyyy.dev) is back up in 83fd173.

repo: ashhhleyyy/status-page


text:
🛑 Gitea is down

In 4a3ee1a, Gitea (https://git.ashhhleyyy.dev/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Gitea is back up in b8f9b72.


text:
Error: Kraken API returned error: Service:Unavailable

Hi,
I’m often having some issue while requesting the Kraken API.
I didn’t found a similar issue so here is the debug log to give you some hint.
2017-08-07 23:31:40 (DEBUG):	Processing 15 new trades. From 2017-08-07 21:31:37 UTC to 2017-08-07 21:31:44 UTC. (a few seconds)
2017-08-07 23:32:00 (DEBUG):	Requested XBT/EUR trade data from Kraken ...
2017-08-07 23:32:01 (DEBUG):	Processing 8 new trades. From 2017-08-07 21:31:55 UTC to 2017-08-07 21:32:06 UTC. (a few seconds)
2017-08-07 23:32:20 (DEBUG):	Requested XBT/EUR trade data from Kraken ...
2017-08-07 23:32:20 (DEBUG):	Processing 7 new trades. From 2017-08-07 21:32:17 UTC to 2017-08-07 21:32:32 UTC. (a few seconds)
2017-08-07 23:32:40 (DEBUG):	Requested XBT/EUR trade data from Kraken ...
2017-08-07 23:32:40 (DEBUG):	kraken returned an error, retrying.. Error: Kraken API returned error: Service:Unavailable
    at Request._callback (/home/tr4sk/gekko/node_modules/kraken-api/kraken.js:155:34)
    at Request.self.callback (/home/tr4sk/gekko/node_modules/request/request.js:188:22)
    at emitTwo (events.js:125:13)
    at Request.emit (events.js:213:7)
    at Request.<anonymous> (/home/tr4sk/gekko/node_modules/request/request.js:1171:10)
    at emitOne (events.js:115:13)
    at Request.emit (events.js:210:7)
    at IncomingMessage.<anonymous> (/home/tr4sk/gekko/node_modules/request/request.js:1091:12)
    at Object.onceWrapper (events.js:314:30)
    at emitNone (events.js:110:20)
    at IncomingMessage.emit (events.js:207:7)
    at endReadableNT (_stream_readable.js:1045:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)
2017-08-07 23:32:51 (DEBUG):	Processing 6 new trades. From 2017-08-07 21:32:42 UTC to 2017-08-07 21:33:04 UTC. (a few seconds)
2017-08-07 23:33:00 (DEBUG):	Requested XBT/EUR trade data from Kraken ...
2017-08-07 23:33:00 (DEBUG):	Processing 3 new trades. From 2017-08-07 21:33:10 UTC to 2017-08-07 21:33:15 UTC. (a few seconds)
2017-08-07 23:33:20 (DEBUG):	Requested XBT/EUR trade data from Kraken ...
2017-08-07 23:33:20 (DEBUG):	Processing 11 new trades. From 2017-08-07 21:33:20 UTC to 2017-08-07 21:33:32 UTC. (a few seconds)

This should not be a big problem: Gekko merely logs the error will tries again :)

repo: askmike/gekko


text:
Fix GDAX fee for ETH and LTC

Fees for ETH and LTC should be 0.3% instead of 0.25% according to https://www.gdax.com/fees

Should probably merge #927 first

awesome, thanks! They are both merged now.

authors: askmike damianleung


text:
missing swift file

UIFontExtensionFile.swift is missing

@uma130012 did you fully pulled from git?

repo: aslanyanhaik/Quick-Chat


text:
🛑 Blog is down

In 6523c49, Blog (https://blog.asm0dey.ru) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Blog is back up in 821620e.


text:
🛑 Root is down

In f55a99e, Root (https://asm0dey.ru) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Root is back up in 77dfaea.


text:
🛑 ort-club is down

In 0b9a154, ort-club (https://ort-club.ru) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ort-club is back up in c1f686f.


text:
Merge from quota-management latest changes

Signed-off-by: dmatch01 darroyo@us.ibm.com

Reviewed with @dmatch01 , thanks merging.


text:
[Bug]: 3.7.4-2 release doesn't support --options=zstd:threads=0

What happened?
There was a recent issue in libarchive to add support for zstd:threads=0, see https://github.com/libarchive/libarchive/pull/2083 . The relevant commit was included in the 3.7.4 release of libarchive. Yet running the linux-x86_64 binary from this release
 doesn't seem to contain the fix.
Maybe there was an issue with compilation? Is it possible that #if defined(HAVE_SYSCONF) && defined(_SC_NPROCESSORS_ONLN) is somehow false?
See the steps to reproduce below, running with zstd:threads=256 is considerably faster than zstd:threads=0, when they should be equivalent.
Version
Development (host) and target OS/architectures:
https://github.com/aspect-build/bsdtar-prebuilt/releases/tag/v3.7.4-2
Ubuntu-22.04, Kernel 6.5.0-35-generic, x86_64
How to reproduce
% time ./tar_linux_amd64 --zstd -cf  embed.tar.zst tree_dock_3/
./tar_linux_amd64 --zstd -cf embed.tar.zst tree_dock_3/  7.79s user 4.04s system 124% cpu 9.543 total
% time ./tar_linux_amd64 --zstd --options=zstd:threads=0 -cf  embed.tar.zst tree_dock_3/
./tar_linux_amd64 --zstd --options=zstd:threads=0 -cf embed.tar.zst   7.99s user 3.11s system 136% cpu 8.166 total
% time ./tar_linux_amd64 --zstd --options=zstd:threads=256 -cf  embed.tar.zst tree_dock_3/
./tar_linux_amd64 --zstd --options=zstd:threads=256 -cf embed.tar.zst   9.88s user 3.28s system 512% cpu 2.570 total
% time ./tar_linux_amd64 --zstd --options=zstd:compression-level=19,zstd:threads=256 -cf  embed.tar.zst tree_dock_3/
./tar_linux_amd64 --zstd --options=zstd:compression-level=19,zstd:threads=256  767.75s user 7.28s system 3113% cpu 24.896 total
% du -hs tree_dock_3
1.5G	tree_dock_3
% md5sum tar_linux_amd64
a55dcc31c8d1787f2d1ff9966fb876f4  tar_linux_amd64
% nproc
256

Any other information?
No response

I suspect that https://github.com/bazelbuild/bazel-central-registry/pull/2457 fixes this. Previously we didn't have zstd static-linked into the binary. Please re-open this if you can reproduce on 3.7.4-3

authors: alexeagle froody

repo: aspect-build/bsdtar-prebuilt


text:
Add more detail on caching of secrets

> Secrets are cached until IConfigurationRoot.Reload() is called.
Let's expand upon the caching aspect. Is this manual call the ONLY way? Can a caching policy be created and observed by the configuration provider?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2cc0b77a-df21-7007-5cec-4399d98c6dc6
Version Independent ID: efe5ae5e-ff64-f1c7-6920-4512fc8f36d1
Content: Azure Key Vault Configuration Provider in ASP.NET Core
Content Source: aspnetcore/security/key-vault-configuration.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @guardrex
Microsoft Alias: riande

FYI there is a way with v3.0.0+ to automatically refresh key vault configuration using AzureKeyVaultConfigurationOptions.ReloadInterval

authors: dandenton scottaddie


text:
Create a web API without Entity Framework

Hi, is there a tutorial on how to create an API without using EF?
Regards.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 583ae3e7-5915-f22b-e54c-6c100cf2a7da
Version Independent ID: 95f2549e-29f9-e31a-b4d0-432b971643ff
Content: Tutorial: Create a web API with ASP.NET Core
Content Source: aspnetcore/tutorials/first-web-api.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Just skip the EF part.

authors: Rick-Anderson joregc


text:
Remove extra line

/cc @JamesNK

@pranavkm  you can't have embedded moniker ranges.  You're adding that to the 2.1/2.2 section, so it's not required.

Register the authorization handlers is the code that needs to be updated.
Can we close this and I'll fix the auth filter replacement?
public void ConfigureServices(IServiceCollection services)
{

    services.AddDbContext<ApplicationDbContext>(options =>
        options.UseSqlServer(
            Configuration.GetConnectionString("DefaultConnection")));
    services.AddDefaultIdentity<IdentityUser>(
        options => options.SignIn.RequireConfirmedAccount = true)
        .AddRoles<IdentityRole>()
        .AddEntityFrameworkStores<ApplicationDbContext>();

    services.AddRazorPages();

    services.AddControllers(config =>
    {
        // using Microsoft.AspNetCore.Mvc.Authorization;
        // using Microsoft.AspNetCore.Authorization;
        var policy = new AuthorizationPolicyBuilder()
                         .RequireAuthenticatedUser()
                         .Build();
        config.Filters.Add(new AuthorizeFilter(policy));
    });
    // Authorization handlers.
    services.AddScoped<IAuthorizationHandler,
                          ContactIsOwnerAuthorizationHandler>();

    services.AddSingleton<IAuthorizationHandler,
                          ContactAdministratorsAuthorizationHandler>();

    services.AddSingleton<IAuthorizationHandler,
                          ContactManagerAuthorizationHandler>();
}

I hadn't looked at the auth handlers. Here's the section I was trying to update: https://docs.microsoft.com/en-us/aspnet/core/security/authorization/secure-data?view=aspnetcore-3.0#require-authenticated-users

@pranavkm  yes, that's what I have in my previous comment. I'll close this PR - see #16101

@pranavkm  this is the problem - right
    services.AddControllers(config =>
    {
        // using Microsoft.AspNetCore.Mvc.Authorization;
        // using Microsoft.AspNetCore.Authorization;
        var policy = new AuthorizationPolicyBuilder()
                         .RequireAuthenticatedUser()
                         .Build();
        config.Filters.Add(new AuthorizeFilter(policy));
    });

authors: Rick-Anderson pranavkm


text:
Authorization failed in Blazor server-side app

SDK: dotnet-sdk-3.0.100-preview8-013656-win-x64
IDE: Visual Studio 2019 16.3 Preview 2.0
OS: Windows 10 1903 (18362.1.amd64fre.19h1_release.190318-1202)
Using Windows Authentication, authorization in Blazor server-side app always results in NotAuthorized when using debug launch command 'Project' instead of 'IISExpress'.
Steps to reproduce using a new app:

Create a new Blazor App in Visual Studio (Server-side, Windows Authentication)
Debug the app using launch command 'IISExpress' -> The LoginDisplay component displays the Windows Username
Debug the app using launch command 'Project' -> The LoginDisplay component displays nothing. The log contains this message: [Microsoft.AspNetCore.Authorization.DefaultAuthorizationService] Authorization failed.

Before updating to .NET Core 3.0 preview8 I was using preview7 where this was not an issue.
I have an existing app which I migrated from preview7 to preview8. The MVC part of the app and the authorization works while the Blazor server-side part always results in NotAuthorized if I don't use IISExpress to debug.

Thanks for contacting us, @romandres.
@SteveSandersonMS don't we have a CTI scenario validating this daily?

@mkArtakMSFT No, we only have a CTI scenario covering the Identity auth case (not Windows auth).
In any case, as far as I'm aware, Windows Authentication is not expected to work by default when hosting directly on Kestrel, since Kestrel doesn't support it. I checked, and the default MVC site template with Windows authentication also doesn't work if you run it directly on Kestrel instead of IISExpress.
The fact that Kestrel doesn't support Windows Authentication directly is mentioned here, though I'm unsure where this fact is covered in official documentation.
It is possible to host ASP.NET Core on HTTP.sys directly and then enable Windows authentication via HTTP.sys, which should work the same with server-side Blazor. But setting it up is nontrivial as per docs.
@HaoK Do you agree with this diagnosis? Is there anything I've missed?

Closing this as by design.

authors: SteveSandersonMS mkArtakMSFT pranavkm romandres

repo: aspnet/AspNetCore


text:
Test failure: CustomErrorCodeWorks

This issue was made automatically. If there is a problem contact ryanbrandenburg.
This test failed with the following error:
Assert.Equal() Failure
Expected: OK
Actual:   InternalServerError
   at Microsoft.AspNetCore.Server.IISIntegration.FunctionalTests.ResponseHeaders.CustomErrorCodeWorks(Int32 code, String reason, String expectedReason, String body) in /_/test/Common.FunctionalTests/Inprocess/ResponseHeaderTests.cs:line 72
--- End of stack trace from previous location where exception was thrown ---

Other tests within that build may have failed with a similar message, but they are not listed here. Check the link above for more info.
This test failed on master.
CC muratg

This comment was made automatically. If there is a problem contact ryanbrandenburg.
Please use this workflow to address this flaky test issue, including checking applicable checkboxes and filling in the applicable "TODO" entries:

Is this actually a flaky test?

No, this is a regular test failure, fix the test/product (TODO: Link to commit/PR)
Yes, proceed below...

Is this test failure caused by product code flakiness? (Either this product, or another product this test depends on.)

[ ] File a bug against the product (TODO: Link to other bug)
Is it possible to change the test to avoid the flakiness?

Yes? Go to the "Change the test!" section.
No?

[ ] Disable the test (TODO: Link to PR/commit)
[ ] Wait for other bug to be resolved
[ ] Wait for us to get build that has the fix
[ ] Re-enable our test (TODO: Link to PR/commit)
[ ] Close this bug

Is it that the test itself is flaky? This includes external transient problems (e.g. remote server problems, file system race condition, etc.)

Is there is a way to change our test to avoid this flakiness?

Yes? Change the test!

[ ] Change the test to avoid the flakiness, for example by using a different test strategy, or by adding retries w/ timeouts (TODO: Link to PR/commit)
[ ] Run the test 100 times locally as a sanity check.
[ ] Close this bug

No?

Is there any logging or extra information that we could add to make this more diagnosable when it happens again?

Yes?

[ ] Add the logging (TODO: Link to PR/commit)

No?

[ ] Delete the test because flaky tests are not useful (TODO: Link to PR/commit)


text:
Health Check - Provide support for OpenAPI

The built-in support for health checks are great, but when you are using OpenAPI specifications this will not surface.
Are there plans to provide this capability/integration for 3rd party libraries?
This is currently holding me off of using it.
Additional context
OpenAPI are a great way to describe your APIs, bot internally as externally. Health checks are a great example of an internal endpoint that you want to expose for tools/teams inside the company.
When you are exposing your APIs via an API Gateway (ie. Azure API Management/Kong) you will want to use OpenAPI specs to decorate your APIs and surface that information for your users.

Hi @tomkerkhove - I don't think we have any easy path to provide this through the health checks middleware.
However, that shouldn't stop you from being able to use health checks with OpenAPI. You can write an MVC controller endpoint that calls into HealthChecksService (available from DI). This will enable you to do all of the things that MVC usually does for OpenAPI/Swagger support.

But then I would need to duplicate it given I need to create a health endpoint for OpenAPI anyway or am I missing something?

The middleware is a really small piece of code. I runs the health checks service and then figures out how to respond.  https://github.com/aspnet/AspNetCore/blob/master/src/Middleware/HealthChecks/src/HealthCheckMiddleware.cs#L51
I suspect that if you care about having an OpenAPI description for health checks, then you'll probably want to customize the output
Another alternative would be a use extensibility provided by your OpenAPI library to add support for it. How Swashbuckle and NSwag work today is through deep integration with MVC. For a bare piece of middleware, there isn't really any contract that describes the metadata your OpenAPI library is using. So I guess, which it would be theoretically possible for us to do this in the future, the health checks middleware doesn't have a realistic path to doing this automatically.

authors: rynowak tomkerkhove


text:
ASP.NET Core 3 Preview 3 React template does not handle token expiry

Describe the bug
If you log into an app based on the "SPA with authentication" (React) template in ASP.NET Core 3.0 Preview 3 and let the token expire (which takes an hour) the client-side app does not handle this well - it displays "Loading..." forever.
To Reproduce

Follow the steps in #8405 including fixing the populateWeatherData() code.
Run the app, create an account and log in.
Stop the app for over an hour.
Run the app again and click on Fetch data.

The page shows "Loading..." forever and the developer console displays the same 2 errors as in #8405. However, this time the response headers are different:
WWW-Authenticate: Bearer error="invalid_token", error_description="The token is expired"
(I've also seen: WWW-Authenticate: Bearer error="invalid_token", error_description="The signature is invalid" but haven't been able to repro that one.)
Expected behavior

When the request fails for any reason an error is displayed on the page instead of "Loading..."
The request does not fail due to the token expiring - either it's refreshed automatically or the user is prompted to log in.

Screenshots
Same as in #8405

Interestingly, I can still view my user profile and download personal data from /Identity/Account/Manage/PersonalData - this doesn't seem to send a Bearer authentication token. I guess it relies on the cookie instead.

Thanks for contacting us, @loop-evgeny.
@javiercn, can you please look into this? Thanks!

(I've also seen: WWW-Authenticate: Bearer error="invalid_token", error_description="The signature is invalid" but haven't been able to repro that one.)

This is probably because you cleaned up your repo. We store the development key by default in the obj folder so that it doesn't get checked-in by accident so if you clean the repo you need to reauthenticate.
In general, on every call-site where you use the token you need to handle possible 401s as in real scenarios keys rotate, tokens get repudiated, etc. We don't include code in the template to specifically handle this scenario, but we would gladly accept a PR for it.
The flow is as follows:

Send the request including the token.
If the response comes back 401.
2.1 Save any current state on the page you want to preserve.
2.2 Redirect to the login component window.location.href = `${ApplicationPaths.Login}?${QueryParameterNames.ReturnUrl}=${encodeURI(window.location.href)}`;
When you come back from the login flow you should have a new valid token.
3.1 Reissue the request and it should succeed

authors: javiercn loop-evgeny mkArtakMSFT


text:
Rename @aspnet/signalr to @microsoft/signalr

Replacing all instances of @aspnet with @microsoft. Are there any other tricks here?
Follow up items are to update docs and publish preview 7 un the @aspnet/signalr name with a deprecated message

Don't see any blazor-related changes, I presume they weren't using the ID anywhere, just the files?
Also, speaking of docs, we should sync up on the JS API docs. They'll probably need to be updated.

Looks right to me, as long as the build passes and things are working,

Just need to do the needful for the Code check and everything should be green

@anurse  This needs an announcement?

Yep, it will have one!

https://github.com/aspnet/Announcements/issues/372

Thanks @anurse!

authors: anurse benaadams mikaelm12


text:
Resolve continually flaky test in 2.1 by making it possible to mock the folder used for key storage

Create an internal abstraction for finding the default directories for key storage. This allows us to run tests without squashing on keys on the developer machine. It also allows us to isolate test runs from reach other.
Fixes aspnet/Home#3034

I can't fix the test without making a change to allow mocking a static method, so what do you propose we do?

I just posted a comment to the issue thread: can we disable parallelization of these tests?

The flakiness is not an issue with parallelization. It is a problem with bad machine state.

If we disable parallelization can we have cleanup code that runs before/after each affected test so that they're guaranteed not to clobber over each other?

It's not about parallelization. The global machine folder may be there for a number of reasons which disabling parallelization does not solve. when the global machine folder exists, the test attempts to avoid clobbering it by moving it temporarily. But moving it is what is causing problems. The location of the global machine folder is uninteresting in this test, which is why the fix for the flakiness is to use a different folder.

What risk is there in disabling these tests for the patch?

What risk is there in disabling these tests for the patch?

We lose regression coverage. If you'd rather risk that, then let's just get rid of the test.

I think if we don't have a reasonable way of de-flakifying the test without product changes then we should disable the test.

authors: Eilon natemcmaster

repo: aspnet/DataProtection


text:
Update unit testing to point to http://dotnet.github.io/docs/core-concepts/testing/unit-testing-with-dotnet-test.html

I was following the unit test scenario. In  "Configuring the Test project.json" section, the same code appeared twice but the second should be something to do with test runner as described. The second code used to be the command section in RC1 so it should be referred to as test runner accordingly.
In addition, dotnet watch doesn't work. Tooling might be missing. The screen shot should be replaced  with RC2 dotnet, not dnx.

This article hasn't been updated for RC2 yet - it's still RC1. Leaving this issue open to track the need to update the article.

The article seemed to be updated on Update ASP.NET UnitTest section for RC2 changes #1289. There seemed to be a merging issue though, e.g, the second code in "Configuring the Test project.json" section should be one line code according to the changes on #1289.
That is one thing, screen shots and dotnet watch are still issues.

Update to point to http://dotnet.github.io/docs/core-concepts/testing/unit-testing-with-dotnet-test.html

@rachelappel  can you fix this today?

fixed

authors: JakeRyu Rick-Anderson ardalis

repo: aspnet/Docs


text:
maquina de coser singer

General
We use issues to drive the discussion for changes to
existing topics and the creation of new topics.
This template offers some suggestions to consider
when creating an issue.
Issues with Existing Topics
If the issue is a simple typo or similar correction, just submit a PR.
Otherwise, let us know what's wrong or what we should improve. Include a
link to the topic.
Requests for new Topics

Write a short paragraph describing what the topic will cover.

Write an outline of the proposed topic contents.

Where would you put the topic in the Table of Contents.

If you know who should review the issue, notify them by including @githubID in the issue description.

I need to pay

maquinade coser singer


text:
Where is the fix for the "No type was specified for the decimal column" migration error?

Ignore the following warning message, you fix that in the next tutorial:
Microsoft.EntityFrameworkCore.Model.Validation[30000]
No type was specified for the decimal column 'Price' on entity type 'Movie'. This will cause values to be silently truncated if they do not fit in the default precision and scale. Explicitly specify the SQL server column type that can accommodate all the values using 'ForHasColumnType()'.

Source: https://docs.microsoft.com/en-us/aspnet/core/tutorials/razor-pages/model?view=aspnetcore-2.1
The article mentions that the fix is in the next tutorial, but I cannot find it anywhere. Can anyone point to the location of the solution?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6719f08e-3bd7-dc1a-71df-f2ef9fbca9d8
Version Independent ID: 7096fdb3-612e-9e00-bd0b-8ea4886a09ce
Content: Add a model to a Razor Pages app in ASP.NET Core
Content Source: aspnetcore/tutorials/razor-pages/model.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@danielcongrove I should read "in a later tutorial". It's just a warning. I fixed the wording.

But where's the later tutorial? This doesn't fix the basic question.

https://docs.microsoft.com/en-us/aspnet/core/tutorials/razor-pages/new-field
public class Movie
{
    public int ID { get; set; }
    public string Title { get; set; }

    [Display(Name = "Release Date")]
    [DataType(DataType.Date)]
    public DateTime ReleaseDate { get; set; }
    public string Genre { get; set; }

    [Column(TypeName = "decimal(18, 2)")]
    public decimal Price { get; set; }
    public string Rating { get; set; }
}

Looks like no fix to now.

authors: AlbertLi255 Rick-Anderson danielcongrove leniency


text:
Update hosting bundle link for core module doc

Update hosting bundle link for 1.0.1 release.

Thanks

authors: GuardRex Rick-Anderson


text:
Partially addresses Issue 2147

Update some of the ![image] issues #2147, add alt tags to images in the conversion where they are not specified.

@tdykstra and @Rick-Anderson - search source for ![image] to find, most are easy fixes.


text:
Update index.md

Corrected spelling mistake

Thanks @hershi9!