text:
*: update client-c to fix request pd leader timeout after any pd disconnected (release-8.1)

What problem does this PR solve?
Issue Number: close #9243
Problem Summary:
check https://github.com/tikv/client-c/pull/187 for more details
What is changed and how it works?
update client-c to fix request pd leader timeout after any pd disconnected

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/run-integration-test

repo: pingcap/tiflash


text:
[WIP]loader(dm): remove loader and ColumnMapping and dump TLS certs

What problem does this PR solve?

Issue Number: ref #3510
What is changed and how it works?
loader is replaced by embedded lightning, column mapping is replaced by extract-table/database/source, and lightning can use cert bytes so no need to dump the content.
Check List
Tests

pass old tests

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.

/run-dm-integration-test

waiting https://github.com/pingcap/tidb-tools/issues/690

/run-dm-integration-test

/run-dm-integration-test

/run-dm-integration-test

/run-dm-integration-test

/run-dm-integration-test

/run-dm-integration-test

/cc @buchuitoudegou @GMHDBJD @lichunzhu

/merge

source: gharchive/pull-request

repo: pingcap/tiflow

license_type: permissive

license_source: github-api


text:
[tests] add tests for gc on raft storage

@zhangjinpeng1987 @disksing PTAL

PTAL @hhkbp2

Rest LGTM

LGTM

@siddontang please give me a LGTM

LGTM

authors: AndreMouche disksing hhkbp2 siddontang

repo: pingcap/tikv


text:
[DNM] snap: use hard link and move file when applying

[ ] test performance
@zhangjinpeng1987 @siddontang PTAL

Signed-off-by: Cholerae Hu huyingqian@pingcap.com

When ingest sst, RocksDB will modify sst file(set global sequence number), so we can not use move.


text:
coprocessor: support stream aggregation

coprocessor: support stream aggregation
Relate to pingcap/tidb#5725

PTAL @AndreMouche

Using 3 TiKV, 1 PD, 1 TiDB, the 3 TiKV are on different servers.
The table schema as follows:
Create Table: CREATE TABLE `lineitem` (
  `L_ORDERKEY` int(11) NOT NULL,
  `L_PARTKEY` int(11) NOT NULL,
  `L_SUPPKEY` int(11) NOT NULL,
  `L_LINENUMBER` int(11) NOT NULL,
  `L_QUANTITY` decimal(15,2) NOT NULL,
  `L_EXTENDEDPRICE` decimal(15,2) NOT NULL,
  `L_DISCOUNT` decimal(15,2) NOT NULL,
  `L_TAX` decimal(15,2) NOT NULL,
  `L_RETURNFLAG` char(1) NOT NULL,
  `L_LINESTATUS` char(1) NOT NULL,
  `L_SHIPDATE` date NOT NULL,
  `L_COMMITDATE` date NOT NULL,
  `L_RECEIPTDATE` date NOT NULL,
  `L_SHIPINSTRUCT` char(25) NOT NULL,
  `L_SHIPMODE` char(10) NOT NULL,
  `L_COMMENT` varchar(44) NOT NULL,
  PRIMARY KEY (`L_ORDERKEY`,`L_LINENUMBER`),
  CONSTRAINT `LINEITEM_FK1` FOREIGN KEY (`L_ORDERKEY`) REFERENCES `orders` (`O_ORDERKEY`),
  CONSTRAINT `LINEITEM_FK2` FOREIGN KEY (`L_PARTKEY`,`L_SUPPKEY`) REFERENCES `partsupp` (`PS_PARTKEY`,`PS_SUPPKEY`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_bin

rows:6001215 && groups:1.5m && current PR
rows:6001215 && groups:1.5m && before
percentage decrease
rows:59986052 && groups:15m && current PR
rows:59986052 && groups:15m && before
percentage decrease

select count(L_ORDERKEY), sum(L_LINENUMBER) from lineitem group by L_ORDERKEY;
6.43 sec
7.27 sec
11.6%
31.05s
69.76s
55.5%

6.53 sec
7.36 sec
11.3%

---
---
---
---
---
---
---

select count(L_ORDERKEY) from lineitem group by L_ORDERKEY;
4.12 sec
4.84 sec
14.9%
19.78
49.03
59.7%

4.22 sec
4.61 sec
8.5%

---
---
---
---
---
---
---

select sum(L_ORDERKEY) from lineitem group by L_ORDERKEY;
5.00 sec
5.51 sec
9.3%
26.76
52.55

5.15 sec
5.72 sec

---
---
---
---
---
---
---

select avg(L_LINENUMBER) from lineitem group by L_ORDERKEY;
6.04 sec
6.21 sec
2.8%
32.26
61.08
49.1%

6.15 sec
6.39 sec
3.8%

---
---
---
---
---
---
---

select avg(L_ORDERKEY) from lineitem group by L_ORDERKEY;
5.97 sec
6.03 sec
1.0%
35.20
60.59
41.9%

6.20 sec
6.30 sec
1.6%

---
---
---
---
---
---
---

PTAL @winoros @AndreMouche @BusyJay

PTAL @AndreMouche @BusyJay

PTAL @AndreMouche

/run-integration-common-test tidb-test=pr/453 tidb=pr/5725 tidb-private-test=pr/453

PTAL @AndreMouche

rest LGTM.

/run-integration-common-test tidb-test=pr/453 tidb=pr/5725 tidb-private-test=pr/453

/run-integration-common-test tidb-test=pr/453 tidb=pr/5725 tidb-private-test=pr/453

authors: hicqu zimulala


text:
*: Use slog

After speaking with @siddontang we think this is a better option than https://github.com/pingcap/tikv/pull/2997.
Motivation
We noted with some users that logging was taking a considerable amount of time during system operation. This is due to the fact that the log crate operates syncronously. We noted when exploring #2997 that moving to asyncronous logging was measurably faster.
During our discussion it was decided that slog was a good alternative that offered built in asyncronous logging capabilities. It offers other benefits as well, such as structured logging and fancy terminal output.
Implementation
This PR moves us to using slog via the slog_stdlog crate which essentially adapts the log based macros to use slog. In the future we can place work into migrating to the slog based logging macros which offer the option for structure data.
With this PR it was possible to completely remove the StdErrLogger and use the provided slog_term terminal logger. The RotatingFileLogger was altered so it simply implements Write and can be called from the slog decorators. Additionally the distinction between the Logger and the LoggerCore was removed, as well as the mutex which was involved.
A future PR will implement file rotation by size.
Benchmarks
On master:
Begin to run: raftstore
benching Set on raft cluster (channel), nodes: 1, value len:    8       ...     29,214 ns/iter (+/- 5,149)
benching Set on raft cluster (channel), nodes: 1, value len:  128       ...     41,056 ns/iter (+/- 7,479)
benching Set on raft cluster (channel), nodes: 1, value len: 1024       ...     45,485 ns/iter (+/- 12,575)
benching Set on raft cluster (channel), nodes: 1, value len: 4096       ...     63,040 ns/iter (+/- 35,221)
benching Get on raft cluster (channel), nodes: 1        ...     16,488 ns/iter (+/- 872)
benching Delete on raft cluster (channel),      nodes: 1        ...     38,510 ns/iter (+/- 9,025)
benching Set on raft cluster (channel), nodes: 3, value len:    8       ...     87,967 ns/iter (+/- 12,569)
benching Set on raft cluster (channel), nodes: 3, value len:  128       ...     88,835 ns/iter (+/- 12,777)
benching Set on raft cluster (channel), nodes: 3, value len: 1024       ...    100,263 ns/iter (+/- 14,892)
benching Set on raft cluster (channel), nodes: 3, value len: 4096       ...    121,325 ns/iter (+/- 51,883)
benching Get on raft cluster (channel), nodes: 3        ...     15,778 ns/iter (+/- 1,064)
benching Delete on raft cluster (channel),      nodes: 3        ...     89,725 ns/iter (+/- 12,090)
benching Set on raft cluster (channel), nodes: 5, value len:    8       ...    110,969 ns/iter (+/- 8,464)
benching Set on raft cluster (channel), nodes: 5, value len:  128       ...    113,681 ns/iter (+/- 9,638)
benching Set on raft cluster (channel), nodes: 5, value len: 1024       ...    123,668 ns/iter (+/- 12,713)
benching Set on raft cluster (channel), nodes: 5, value len: 4096       ...    149,208 ns/iter (+/- 76,215)
benching Get on raft cluster (channel), nodes: 5        ...     16,907 ns/iter (+/- 1,410)
benching Delete on raft cluster (channel),      nodes: 5        ...    110,360 ns/iter (+/- 11,433)
benching Set on raft cluster (tcp),     nodes: 1, value len:    8       ...     37,840 ns/iter (+/- 8,776)
benching Set on raft cluster (tcp),     nodes: 1, value len:  128       ...     39,376 ns/iter (+/- 12,806)
benching Set on raft cluster (tcp),     nodes: 1, value len: 1024       ...     45,441 ns/iter (+/- 11,976)
benching Set on raft cluster (tcp),     nodes: 1, value len: 4096       ...     68,510 ns/iter (+/- 15,056)
benching Get on raft cluster (tcp),     nodes: 1        ...     16,730 ns/iter (+/- 1,119)
benching Delete on raft cluster (tcp),  nodes: 1        ...     36,457 ns/iter (+/- 12,851)
benching Set on raft cluster (tcp),     nodes: 3, value len:    8       ...    214,640 ns/iter (+/- 18,331)
benching Set on raft cluster (tcp),     nodes: 3, value len:  128       ...    216,273 ns/iter (+/- 23,011)
benching Set on raft cluster (tcp),     nodes: 3, value len: 1024       ...    226,920 ns/iter (+/- 32,660)
benching Set on raft cluster (tcp),     nodes: 3, value len: 4096       ...    167,235 ns/iter (+/- 17,127)
benching Get on raft cluster (tcp),     nodes: 3        ...     17,650 ns/iter (+/- 1,727)
benching Delete on raft cluster (tcp),  nodes: 3        ...    221,035 ns/iter (+/- 25,323)
benching Set on raft cluster (tcp),     nodes: 5, value len:    8       ...    329,054 ns/iter (+/- 12,363)
benching Set on raft cluster (tcp),     nodes: 5, value len:  128       ...    331,151 ns/iter (+/- 25,594)
benching Set on raft cluster (tcp),     nodes: 5, value len: 1024       ...    343,870 ns/iter (+/- 24,609)
benching Set on raft cluster (tcp),     nodes: 5, value len: 4096       ...    375,979 ns/iter (+/- 28,572)
benching Get on raft cluster (tcp),     nodes: 5        ...     17,735 ns/iter (+/- 1,447)
benching Delete on raft cluster (tcp),  nodes: 5        ...    329,308 ns/iter (+/- 23,500)

With this PR:
Begin to run: raftstore
benching Set on raft cluster (channel), nodes: 1, value len:    8       ...     30,221 ns/iter (+/- 7,197)
benching Set on raft cluster (channel), nodes: 1, value len:  128       ...     30,800 ns/iter (+/- 7,490)
benching Set on raft cluster (channel), nodes: 1, value len: 1024       ...     41,309 ns/iter (+/- 6,337)
benching Set on raft cluster (channel), nodes: 1, value len: 4096       ...     58,102 ns/iter (+/- 35,968)
benching Get on raft cluster (channel), nodes: 1        ...     15,947 ns/iter (+/- 969)
benching Delete on raft cluster (channel),      nodes: 1        ...     32,619 ns/iter (+/- 7,035)
benching Set on raft cluster (channel), nodes: 3, value len:    8       ...     80,111 ns/iter (+/- 13,715)
benching Set on raft cluster (channel), nodes: 3, value len:  128       ...     80,830 ns/iter (+/- 13,125)
benching Set on raft cluster (channel), nodes: 3, value len: 1024       ...     87,357 ns/iter (+/- 11,750)
benching Set on raft cluster (channel), nodes: 3, value len: 4096       ...    113,161 ns/iter (+/- 66,971)
benching Get on raft cluster (channel), nodes: 3        ...     15,388 ns/iter (+/- 1,103)
benching Delete on raft cluster (channel),      nodes: 3        ...     81,159 ns/iter (+/- 13,002)
benching Set on raft cluster (channel), nodes: 5, value len:    8       ...     91,051 ns/iter (+/- 13,179)
benching Set on raft cluster (channel), nodes: 5, value len:  128       ...     92,492 ns/iter (+/- 15,413)
benching Set on raft cluster (channel), nodes: 5, value len: 1024       ...    102,103 ns/iter (+/- 10,981)
benching Set on raft cluster (channel), nodes: 5, value len: 4096       ...    135,170 ns/iter (+/- 62,198)
benching Get on raft cluster (channel), nodes: 5        ...     16,462 ns/iter (+/- 621)
benching Delete on raft cluster (channel),      nodes: 5        ...     94,448 ns/iter (+/- 16,299)
benching Set on raft cluster (tcp),     nodes: 1, value len:    8       ...     32,616 ns/iter (+/- 9,700)
benching Set on raft cluster (tcp),     nodes: 1, value len:  128       ...     35,519 ns/iter (+/- 7,489)
benching Set on raft cluster (tcp),     nodes: 1, value len: 1024       ...     42,009 ns/iter (+/- 10,693)
benching Set on raft cluster (tcp),     nodes: 1, value len: 4096       ...     58,263 ns/iter (+/- 31,890)
benching Get on raft cluster (tcp),     nodes: 1        ...     16,245 ns/iter (+/- 1,830)
benching Delete on raft cluster (tcp),  nodes: 1        ...     32,963 ns/iter (+/- 18,811)
benching Set on raft cluster (tcp),     nodes: 3, value len:    8       ...    207,939 ns/iter (+/- 19,772)
benching Set on raft cluster (tcp),     nodes: 3, value len:  128       ...    214,757 ns/iter (+/- 29,875)
benching Set on raft cluster (tcp),     nodes: 3, value len: 1024       ...    218,234 ns/iter (+/- 32,567)
benching Set on raft cluster (tcp),     nodes: 3, value len: 4096       ...    247,335 ns/iter (+/- 54,398)
benching Get on raft cluster (tcp),     nodes: 3        ...     16,917 ns/iter (+/- 1,437)
benching Delete on raft cluster (tcp),  nodes: 3        ...    208,355 ns/iter (+/- 23,317)
benching Set on raft cluster (tcp),     nodes: 5, value len:    8       ...    315,500 ns/iter (+/- 25,545)
benching Set on raft cluster (tcp),     nodes: 5, value len:  128       ...    313,588 ns/iter (+/- 32,911)
benching Set on raft cluster (tcp),     nodes: 5, value len: 1024       ...    328,193 ns/iter (+/- 23,980)
benching Set on raft cluster (tcp),     nodes: 5, value len: 4096       ...    363,133 ns/iter (+/- 46,415)
benching Get on raft cluster (tcp),     nodes: 5        ...     17,430 ns/iter (+/- 956)
benching Delete on raft cluster (tcp),  nodes: 5        ...    318,073 ns/iter (+/- 22,214)

Samples
Sample of terminal output:

Sample of a log file:
May 03 16:30:01.968 INFO starting working thread: storage-scheduler
May 03 16:30:01.968 INFO starting working thread: end-point-worker
May 03 16:30:01.969 INFO starting working thread: snap-handler
May 03 16:30:01.975 INFO TiKV is ready to serve
May 03 16:30:04.326 INFO heartbeat receiver is refreshed.
May 03 16:30:04.326 INFO heartbeat sender is refreshed.
May 03 16:30:44.693 INFO receive signal 2, stopping server...
May 03 16:30:44.693 INFO stoping end-point-worker
May 03 16:30:44.693 INFO stoping snap-handler
May 03 16:30:44.693 INFO stoping storage-scheduler
May 03 16:30:44.694 INFO scheduler stopped
May 03 16:30:44.694 INFO scheduler stopped
May 03 16:30:44.721 INFO storage RaftKv closed.
May 03 16:30:44.734 INFO stop raft store 1 thread
May 03 16:30:44.734 INFO [store 1] receive quit message
May 03 16:30:44.734 INFO start to stop raftstore.
May 03 16:30:44.734 INFO stoping split check worker
May 03 16:30:44.734 INFO stoping snapshot worker
May 03 16:30:44.734 INFO stoping raft gc worker
May 03 16:30:44.734 INFO stoping compact worker
May 03 16:30:44.734 INFO stoping pd worker
May 03 16:30:44.734 INFO stoping consistency check worker
May 03 16:30:44.735 INFO stoping cleanup sst worker
May 03 16:30:44.735 INFO stoping apply worker
May 03 16:30:44.735 INFO stop raftstore finished.
May 03 16:30:44.735 INFO stoping store address resolve worker

Master
Begin to run: raftstore
benching Set on raft cluster (channel), nodes: 1, value len:    8       ...     29,214 ns/iter (+/- 5,149)
benching Set on raft cluster (channel), nodes: 1, value len:  128       ...     41,056 ns/iter (+/- 7,479)
benching Set on raft cluster (channel), nodes: 1, value len: 1024       ...     45,485 ns/iter (+/- 12,575)
benching Set on raft cluster (channel), nodes: 1, value len: 4096       ...     63,040 ns/iter (+/- 35,221)
benching Get on raft cluster (channel), nodes: 1        ...     16,488 ns/iter (+/- 872)
benching Delete on raft cluster (channel),      nodes: 1        ...     38,510 ns/iter (+/- 9,025)
benching Set on raft cluster (channel), nodes: 3, value len:    8       ...     87,967 ns/iter (+/- 12,569)
benching Set on raft cluster (channel), nodes: 3, value len:  128       ...     88,835 ns/iter (+/- 12,777)
benching Set on raft cluster (channel), nodes: 3, value len: 1024       ...    100,263 ns/iter (+/- 14,892)
benching Set on raft cluster (channel), nodes: 3, value len: 4096       ...    121,325 ns/iter (+/- 51,883)
benching Get on raft cluster (channel), nodes: 3        ...     15,778 ns/iter (+/- 1,064)
benching Delete on raft cluster (channel),      nodes: 3        ...     89,725 ns/iter (+/- 12,090)
benching Set on raft cluster (channel), nodes: 5, value len:    8       ...    110,969 ns/iter (+/- 8,464)
benching Set on raft cluster (channel), nodes: 5, value len:  128       ...    113,681 ns/iter (+/- 9,638)
benching Set on raft cluster (channel), nodes: 5, value len: 1024       ...    123,668 ns/iter (+/- 12,713)
benching Set on raft cluster (channel), nodes: 5, value len: 4096       ...    149,208 ns/iter (+/- 76,215)
benching Get on raft cluster (channel), nodes: 5        ...     16,907 ns/iter (+/- 1,410)
benching Delete on raft cluster (channel),      nodes: 5        ...    110,360 ns/iter (+/- 11,433)
benching Set on raft cluster (tcp),     nodes: 1, value len:    8       ...     37,840 ns/iter (+/- 8,776)
benching Set on raft cluster (tcp),     nodes: 1, value len:  128       ...     39,376 ns/iter (+/- 12,806)
benching Set on raft cluster (tcp),     nodes: 1, value len: 1024       ...     45,441 ns/iter (+/- 11,976)
benching Set on raft cluster (tcp),     nodes: 1, value len: 4096       ...     68,510 ns/iter (+/- 15,056)
benching Get on raft cluster (tcp),     nodes: 1        ...     16,730 ns/iter (+/- 1,119)
benching Delete on raft cluster (tcp),  nodes: 1        ...     36,457 ns/iter (+/- 12,851)
benching Set on raft cluster (tcp),     nodes: 3, value len:    8       ...    214,640 ns/iter (+/- 18,331)
benching Set on raft cluster (tcp),     nodes: 3, value len:  128       ...    216,273 ns/iter (+/- 23,011)
benching Set on raft cluster (tcp),     nodes: 3, value len: 1024       ...

    226,920 ns/iter (+/- 32,660)
benching Set on raft cluster (tcp),     nodes: 3, value len: 4096       ...    167,235 ns/iter (+/- 17,127)
benching Get on raft cluster (tcp),     nodes: 3        ...     17,650 ns/iter (+/- 1,727)
benching Delete on raft cluster (tcp),  nodes: 3        ...    221,035 ns/iter (+/- 25,323)
benching Set on raft cluster (tcp),     nodes: 5, value len:    8       ...    329,054 ns/iter (+/- 12,363)
benching Set on raft cluster (tcp),     nodes: 5, value len:  128       ...    331,151 ns/iter (+/- 25,594)
benching Set on raft cluster (tcp),     nodes: 5, value len: 1024       ...    343,870 ns/iter (+/- 24,609)
benching Set on raft cluster (tcp),     nodes: 5, value len: 4096       ...    375,979 ns/iter (+/- 28,572)
benching Get on raft cluster (tcp),     nodes: 5        ...     17,735 ns/iter (+/- 1,447)
benching Delete on raft cluster (tcp),  nodes: 5        ...    329,308 ns/iter (+/- 23,500)

Slog
Begin to run: raftstore
benching Set on raft cluster (channel), nodes: 1, value len:    8       ...     27,620 ns/iter (+/- 5,909)
benching Set on raft cluster (channel), nodes: 1, value len:  128       ...     31,542 ns/iter (+/- 6,576)
benching Set on raft cluster (channel), nodes: 1, value len: 1024       ...     41,123 ns/iter (+/- 18,117)
benching Set on raft cluster (channel), nodes: 1, value len: 4096       ...     60,776 ns/iter (+/- 33,754)
benching Get on raft cluster (channel), nodes: 1        ...     15,545 ns/iter (+/- 590)
benching Delete on raft cluster (channel),      nodes: 1        ...     37,357 ns/iter (+/- 9,771)
benching Set on raft cluster (channel), nodes: 3, value len:    8       ...     82,141 ns/iter (+/- 10,217)
benching Set on raft cluster (channel), nodes: 3, value len:  128       ...     83,668 ns/iter (+/- 10,382)
benching Set on raft cluster (channel), nodes: 3, value len: 1024       ...     88,525 ns/iter (+/- 12,974)
benching Set on raft cluster (channel), nodes: 3, value len: 4096       ...    114,150 ns/iter (+/- 64,581)
benching Get on raft cluster (channel), nodes: 3        ...     15,377 ns/iter (+/- 815)
benching Delete on raft cluster (channel),      nodes: 3        ...     79,721 ns/iter (+/- 12,953)
benching Set on raft cluster (channel), nodes: 5, value len:    8       ...    100,614 ns/iter (+/- 12,502)
benching Set on raft cluster (channel), nodes: 5, value len:  128       ...    102,038 ns/iter (+/- 12,096)
benching Set on raft cluster (channel), nodes: 5, value len: 1024       ...    111,674 ns/iter (+/- 11,205)
benching Set on raft cluster (channel), nodes: 5, value len: 4096       ...    136,551 ns/iter (+/- 73,951)
benching Get on raft cluster (channel), nodes: 5        ...     16,454 ns/iter (+/- 1,092)
benching Delete on raft cluster (channel),      nodes: 5        ...     98,990 ns/iter (+/- 20,988)
benching Set on raft cluster (tcp),     nodes: 1, value len:    8       ...     36,116 ns/iter (+/- 7,073)
benching Set on raft cluster (tcp),     nodes: 1, value len:  128       ...     37,198 ns/iter (+/- 7,977)
benching Set on raft cluster (tcp),     nodes: 1, value len: 1024       ...     41,546 ns/iter (+/- 12,018)
benching Set on raft cluster (tcp),     nodes: 1, value len: 4096       ...     63,697 ns/iter (+/- 11,580)
benching Get on raft cluster (tcp),     nodes: 1        ...     16,154 ns/iter (+/- 633)
benching Delete on raft cluster (tcp),  nodes: 1        ...     34,627 ns/iter (+/- 9,471)
benching Set on raft cluster (tcp),     nodes: 3, value len:    8       ...    201,408 ns/iter (+/- 19,797)
benching Set on raft cluster (tcp),     nodes: 3, value len:  128       ...    200,321 ns/iter (+/- 23,637)
benching Set on raft cluster (tcp),     nodes: 3, value len: 1024       ...    207,016 ns/iter (+/- 13,701)
benching Set on raft cluster (tcp),     nodes: 3, value len: 4096       ...    176,733 ns/iter (+/- 20,523)
benching Get on raft cluster (tcp),     nodes: 3        ...     16,383 ns/iter (+/- 1,648)
benching Delete on raft cluster (tcp),  nodes: 3        ...    203,317 ns/iter (+/- 24,561)
benching Set on raft cluster (tcp),     nodes: 5, value len:    8       ...    287,374 ns/iter (+/- 10,220)
benching Set on raft cluster (tcp),     nodes: 5, value len:  128       ...    287,728 ns/iter (+/- 10,232)
benching Set on raft cluster (tcp),     nodes: 5, value len: 1024       ...    301,337 ns/iter (+/- 12,750)
benching Set on raft cluster (tcp),     nodes: 5, value len: 4096       ...    334,074 ns/iter (+/- 18,025)
benching Get on raft cluster (tcp),     nodes: 5        ...     17,021 ns/iter (+/- 1,251)
benching Delete on raft cluster (tcp),  nodes: 5        ...    290,758 ns/iter (+/- 14,993)

Seems to be measurably faster.

Using root_typed to create loggers instead of root allows for static dispatch, resulting in slightly better performance.
Begin to run: raftstore
benching Set on raft cluster (channel), nodes: 1, value len:    8       ...     27,903 ns/ite
benching Set on raft cluster (channel), nodes: 1, value len:  128       ...     29,409 ns/ite
benching Set on raft cluster (channel), nodes: 1, value len: 1024       ...     38,013 ns/ite
benching Set on raft cluster (channel), nodes: 1, value len: 4096       ...     52,222 ns/ite
benching Get on raft cluster (channel), nodes: 1        ...     14,292 ns/iter (+/- 606)
benching Delete on raft cluster (channel),      nodes: 1        ...     37,094 ns/iter (+/- 6
benching Set on raft cluster (channel), nodes: 3, value len:    8       ...     82,538 ns/ite
benching Set on raft cluster (channel), nodes: 3, value len:  128       ...     83,726 ns/ite
benching Set on raft cluster (channel), nodes: 3, value len: 1024       ...     89,531 ns/ite
benching Set on raft cluster (channel), nodes: 3, value len: 4096       ...    117,176 ns/ite
benching Get on raft cluster (channel), nodes: 3        ...     15,463 ns/iter (+/- 267)
benching Delete on raft cluster (channel),      nodes: 3        ...     79,670 ns/iter (+/- 1
benching Set on raft cluster (channel), nodes: 5, value len:    8       ...    100,858 ns/ite
benching Set on raft cluster (channel), nodes: 5, value len:  128       ...    102,090 ns/ite
benching Set on raft cluster (channel), nodes: 5, value len: 1024       ...    112,210 ns/ite
benching Set on raft cluster (channel), nodes: 5, value len: 4096       ...    139,906 ns/ite
benching Get on raft cluster (channel), nodes: 5        ...     16,570 ns/iter (+/- 987)
benching Delete on raft cluster (channel),      nodes: 5        ...    101,935 ns/iter (+/- 1
benching Set on raft cluster (tcp),     nodes: 1, value len:    8       ...     34,674 ns/ite
benching Set on raft cluster (tcp),     nodes: 1, value len:  128       ...     36,785 ns/ite
benching Set on raft cluster (tcp),     nodes: 1, value len: 1024       ...     41,612 ns/ite
benching Set on raft cluster (tcp),     nodes: 1, value len: 4096       ...     60,229 ns/ite
benching Get on raft cluster (tcp),     nodes: 1        ...     16,646 ns/iter (+/- 1,061)
benching Delete on raft cluster (tcp),  nodes: 1        ...     36,733 ns/iter (+/- 6,562)
benching Set on raft cluster (tcp),     nodes: 3, value len:    8       ...    202,911 ns/ite
benching Set on raft cluster (tcp),     nodes: 3, value len:  128       ...    201,478 ns/ite
benching Set on raft cluster (tcp),     nodes: 3, value len: 1024       ...    208,972 ns/ite
benching Set on raft cluster (tcp),     nodes: 3, value len: 4096       ...    239,455 ns/ite
benching Get on raft cluster (tcp),     nodes: 3        ...     16,782 ns/iter (+/- 861)
benching Delete on raft cluster (tcp),  nodes: 3        ...    202,863 ns/iter (+/- 22,222)
benching Set on raft cluster (tcp),     nodes: 5, value len:    8       ...    300,921 ns/ite
benching Set on raft cluster (tcp),     nodes: 5, value len:  128       ...    301,656 ns/ite
benching Set on raft cluster (tcp),     nodes: 5, value len: 1024       ...    314,641 ns/ite
benching Set on raft cluster (tcp),     nodes: 5, value len: 4096       ...    349,159 ns/ite
benching Get on raft cluster (tcp),     nodes: 5        ...     17,086 ns/iter (+/- 791)
benching Delete on raft cluster (tcp),  nodes: 5        ...    302,832 ns/iter (+/- 12,650)

I was able to use the PlainDecorator instead of a custom format command to have a consistent style with the terminal logging and avoid any weird () output.

PTAL @BusyJay @overvenus

Rest LGTM
PTAL @BusyJay

@siddontang The failure looks unrelated. Can you do another build?

@Hoverbear
Maybe you still need to update the comment here https://github.com/pingcap/tikv/blob/master/etc/config-template.toml#L8

Oh, we are using the macros from std log, then it should not be an issue anymore.

But it also means that all params of log macros will be evaluated eagerly no matter whether it's going to be filtered. :(

@BusyJay Yeah. :(

/run-all-tests

While working on #3035 I may have found a bug with log rotation, please DNM while I investigate.

Disregard, this is related to #3035 .

so @Hoverbear
can we merge this now?

@siddontang Yes, no known bugs which I know of currently in this PR.

LGTM

/run-all-tests

authors: BusyJay Hoverbear siddontang


text:
Fix partition parser bug

Zero_Decimal is not considered. When it tries to parse "id < 0", it throws an exception.

lgtm

/run-all-tests

/run-all-tests

/run-all-tests

authors: birdstorm zhexuany

repo: pingcap/tispark


text:
build error

I use rocksdb rocksdb-6.0.2, when build titan, it gives me an error:
/proj/titan/src/util.cc:16:15: error: ‘const class rocksdb::CompressionContext’ has no member named ‘type’
*type = ctx.type();
So, I want to know which rocksdb version does titan use?

Currently Titan only works with pingcap's internal fork of rocksdb (https://github.com/pingcap/rocksdb), we will fix these compatibility issues later.

I see, thank you for your answer.

source: gharchive/issue

authors: dongdaoguang tabokie

repo: pingcap/titan


text:
Reusable modules

Modules are really cool and I like the idea of being able to "pull" in modules and then use them. But how can we properly extend them? Ideally we wouldn't want to change code in the module, but expose some way to plug in to a module ( some plugin architecture)
So how would we create truly reusable modules?

I think I asked for a way to 'extend' modules a long time ago, but it never got implemented. :smile: That would make extending modules pretty easy to do.

Did you come up with any examples @nWidart?

What do you mean ? I said it never go implemented, so no actual real life code.

authors: johndevsvensson nWidart

repo: pingpong-labs/modules

license_source: bigquery


text:
flush-interval setting added

closes #57

30000 as a default option, same as in the client.
fi is the new flag for the CLI.

What do you suggest?

-t perhaps? (As time)

could we add a test for this?

authors: Arnovsky delvedor mcollina

repo: pinojs/pino-elasticsearch

license: MIT


text:
Fix teletraan displays incorrect AMI

Teletraan UI shows latest AMI selected, however, new instances will launch on an older AMI. When the AMI is older, the UI shows the first (latest) AMI selected, when in reality the cluster does not have this configuration. This confused users. Fix by including the current ami in the selection dropdown.

Tested locally with an existing cluster from integ.
Base image info.

AMI dropdown

repo: pinterest/teletraan


text:
Open all DataChannels before accepting remote

A race existed with Negotiated DataChannels before this. Before
the remote could sends us a DataChannel message before the
datachannel was negotiated locally. We would then discard the
message and print an error.
This PR moves the processing of remote datachannel messages after
we have registered all local ones. It also informs
datachannel.Accept of existing datachannels in order to prevent
any initialization logic from proceeding incorrectly.

Depends on https://github.com/pion/datachannel/pull/124

repo: pion/webrtc

license: mit


text:
ORTC: Add RTCQuicTransport

One we finish the RTCIceTransport in #273 it should be fairly straightforward to add experimental support for webrtc-quic. I think this would be a worthwhile experiment. We can use quic-go for the networking itself. It uses the similar interfaces as our own networking code. TBD if we keep it in a separate branch.

Moved to pions/ortc#2.

Reopened due to implementing ORTC in tree for now.

repo: pions/webrtc


text:
Passing variadic arguments in place of options or configs

Hey guys, I wanted to explain a situation here and wanted to get some input with a proposed deviation from the general API/JS spec. This way we are going to make the library more golang like while actually solving a tiny but really annoying problem. I would greatly appreciate your input on the proposal.
Problem
Since the WebRTC spec was written for JS with has first class object, which are basically just maps like structures. A lot of the functions were defined with an "options" like optional parameter. In js this is totally fine because we can declare defaults for function arguments and so if only a part of the object is being set we can just access the default. Unfortunately in golang defaults are not a possibility. In addition this leads to an ugly interface where we sort of HAVE to pass something in place of the options argument. Here are a few examples:
_, err = pc.CreateDataChannel("data", RTCDataChannelInit{})
	assert.Nil(t, err)

_, err := New(RTCConfiguration{})
	assert.Nil(t, err)

We could semi solve this problem by setting those arguments to a pointer passing but this still will require our users to pass a nil in the argument. Which is still pretty ugly and stupid.
_, err = pc.CreateDataChannel("data", nil)
	assert.Nil(t, err)

_, err := New(nil)
	assert.Nil(t, err)

More so, these solutions do not address the default values within the actual options objects that need to be passed. For example this is really problematic with RTCDataChannelInit.Ordered which needs to default to the opposite of the zero value (true). This means if I am calling:
_, err = pc.CreateDataChannel("data", RTCDataChannelInit{})
	assert.Nil(t, err)

How can one know if RTCDataChannelInit.Ordered was set to its golang zero value (false) or actually just not set at all? The proposed solutions from above make the code start looking super ugly as we try to add random checks and conversions. Blah... Golang is great at some stuff and is annoying as hell for others.
Solution
Although this solution is not 100% according with the spec,  it does at least will resemble the use of the specs but will be purely a golang solution.
The idea we could be declare those objects as varidic options functions and pass arguments with WithXYZ() functions. Thus for example the CreateDataChannel definition could look something like:
func (pc *RTCPeerConnection) CreateDataChannel(label string, options ... func(opt ... func() error) error) (*RTCDataChannel, error) {...}

So that when the users are using the functions all of the below use cases would be valid:
_, err = pc.CreateDataChannel("data")

_, err = pc.CreateDataChannel("data", WithRTCDataChannelInit())

_, err = pc.CreateDataChannel("data", WithRTCDataChannelInit(
	WithOrdered(),
	WithMaxPacketLifeTime(),
))

The one problem I see with this is there is not compile time checking which sucks but I guess we cannot win EVERY battle.

One proposal came from @backkem is to get rid of wrapper options function like WithRTCDataChannelInit and just pass the arguments in the outer function so that the use case will look more like:
_, err = pc.CreateDataChannel("data",
	WithOrdered(),
	WithMaxPacketLifeTime(),
)

Another solution (and my favorite) is the one you did with the SDP code, use pointers to show default values.
That is a pain because you can't do &true but you could do something like &webrtc.NullBool{true} which means things can be a one liner.
I think we need to do something that involves passing a struct, otherwise the API is going to look foreign if you compare a JS WebRTC tutorial to pion-WebRTC (and it would be nice if we don't have to rewrite everything because of divergence)

@Sean-Der Hahaha... It is almost like we go back and forth between wanting to be like JS API and not. I started implementing the other approach already but I am happy to change it. Keep in mind that the divergence we are talking about is only going to be related to the argument intake of the different functions that have options/configs allowed. Generally speaking I want to stay as close to the JS API as possible but in this case golang really sucks and therefore I am arguing that it is okay. At the end of the day worst case the only public part that changes are the arguments and as long as I will document it really well, it will be fine. On the positive side, specifically for you @Sean-Der , the API will finally get a unique golang style that is unique to golang and not to the JS API. And as long as we stick to it, this will be a signature mark.
Anyway, all in all I am not opposed to it because it seems like the least of all evils but I am sure I am not thinking through some challenges that WILL come up from this design. So... I am going to leave this decision to you. Ultimately it needs to be aligned with your goals because at some point when the library is mature enough I am going to transition out to my own stuff and you will be the one running around promoting it and teaching people how to use it. Fair?! :stuck_out_tongue_winking_eye:
Q. This means we are going to have these webrtc.NilBool{} types for every primitive. a. are you happy with that? b. If so, can we agree to have it as a separate package so we could use them in all the other pkgs as well. Like the sdp.

I have been messing around with this for quiet a while and no matter how I do it, if we make it using nil the way I did in sdp it will require the user to either use wrapper functions which is ugly or write extra code code the way I did with sdp which is hard because not all users will know that trick. Either way I am kinda leaning more and more towards my proposal as I mess around with this.

https://stackoverflow.com/questions/30716354/how-do-i-do-a-literal-int64-in-go
Found this and wanted to put it here for reference. Gosh I find like golang is missing some seriously basic functionality.

@Sean-Der @kc5nra after a short convo with some of the people in the golang community I am going to do what @Sean-Der wanted. I am going to implement our own special structs that default nil based primitives.

For record keeping, this is what I am going to re-implement and imitate. Credits go to whoever implemented this library. https://golang.org/pkg/database/sql/#NullInt64

authors: Sean-Der trivigy


text:
wakaru removes unused imports

Describe the bug
wakaru removes unused imports
but these imports can have side effects which are required
see also Import a module for its side effects only
Input code
import "./x.js"; // FIXME this import is removed
import y from "./y.js"; // FIXME this import is removed
import z from "./z.js";
console.log(z);

Reproduction
No response
Steps to reproduce
No response
Expected behavior
keep all imports
Actual behavior
No response

Fixed. You can verify it on the playground. These will be released this weekend.

authors: milahu pionxzh

repo: pionxzh/wakaru


text:
Store reported piped stats to redis

What this PR does / why we need it:
Implement piped ReportStat handler in piped_api
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

Nice.
/lgtm

Way to get 🥇
/approve

authors: khanhtc1202 nakabonne nghialv

repo: pipe-cd/pipe


text:
Add collection to datastore interface

What this PR does / why we need it:
This PR adds a way to extend the logic of "what should we handle storing data object" without specific its kind by using an interface called Collection instead of primitive string Kind.
The Datastore interface will be
type DataStore interface {
	Find(ctx context.Context, col Collection, opts ListOptions) (Iterator, error)
	Get(ctx context.Context, col Collection, id string, entity interface{}) error
	Create(ctx context.Context, col Collection, id string, entity interface{}) error
	Put(ctx context.Context, col Collection, id string, entity interface{}) error
	Update(ctx context.Context, col Collection, id string, updater Updater) error
	Close() error
}

And the Collection interface will be
type Collection interface {
	Kind() string
	Factory() Factory
}

Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

Nice. This makes the datastore package more flexible.
/lgtm

Love it. That brings us to be latitude, btw hopefully we can generate mock programmatically 😓
/approve

repo: pipe-cd/pipecd


text:
Rename the grpc api for the RBAC

What this PR does / why we need it:

Fix to rename the grpc API for the RBAC into XXXProjectUserGroup.
Add the role field in DeleteProjectUserGroupRequest.

In the current spec of the RBAC, we can store the same team for each built-in team like below ①.
Hence, we can't specify the user group just only by the name of the sso group when somebody tries to delete one from ②.

①

②

message DeleteProjectUserGroupRequest {
    string sso_group = 1 [(validate.rules).string.min_len = 1];
    string role = 2 [(validate.rules).string.min_len = 1];
}

Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

@knanao Thank you.

Add the role field in DeleteProjectUserGroupRequest.

I still don't get why we need that field.
Firstly, please let me confirm the UI, will the UI ① be deleted as soon as the UI ② is added, right?
And the built-in role is not deletable but the old user group (configured via old RBAC) is deletable, right?

@nghialv

Firstly, please let me confirm the UI, will the UI ① be deleted as soon as the UI ② is added, right?

Nope.
I think we should provide some release stages not to confuse the user.
First of all, we're going to provide the view of the UserGroup tab and RBAC Role sections like this.
This means the user can just only see the group and role which have already been added.

Second, we're gotta provide the Add function and Delete function to edit old user groups like this.
Besides, we're gotta remove the edit button for the old RBAC config.

Third, we're gotta provide the Add function to add a new RBAC role.

And Last one, we'll remove the view of the old RBAC config like this.

And the built-in role is not deletable but the old user group (configured via old RBAC) is deletable, right?

Exactly, but the user who is using the old RBAC won't be able to delete the old user group via the view of the one from the second release.

We talked about this directly, this was decided like this consequently.
First, we're gonna provide the User Group tab, the new RBAC role section, and remove the old RBAC role section.

Finally, we're gotta provide the Add and Edit function to add a new RBAC role.

@nghialv @khanhtc1202
I fixed to just only rename the grpc API and defined the release stage.
That's why PTAL when you guys have enough time.

authors: knanao nghialv


text:
Fix pipectl install docs sidebar

What this PR does / why we need it:
Fix the sidebar index showing unexpected templates, like this

Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

How are users affected by this change:
Is this breaking change:
How to migrate (if breaking change):

thanks Since v0.49.0 will be released soon, we don't need to fix v0.48.x

Sorry, I want to update docs v0.48.x as well, please re-approve


text:
Update quickstart manifests to v0.49.1

What this PR does / why we need it:
Manually run what this job does (ref: https://github.com/pipe-cd/pipecd/blob/master/.github/workflows/publish_image_chart.yaml#L150).
Next time, we can wait for the GH to create it by bot 🤖
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

How are users affected by this change:
Is this breaking change:
How to migrate (if breaking change):

@t-kikuc Updated the PR description


text:
Handle JS block comments the same as SQL block comments

YAML frontmatter should be handled the same way in Javascript as it is handled in SQL since the block comments are the same. Previously ABSQL attempted to parse the entire file as yaml and hit errors on backticks.

@chriscardillo good call. Added a a test that renders a simple JS file to make sure I didn't break that, and another test that renders a JS file with backticks. Happy to add more if that's helpful!

repo: pipeline-tools/ABSQL


text:
Drag model or folder as an administrator

Hello!
I can't drag model and texture files or folder on the viewpoint when I'm run the viewer as an administrator (Windows7 x64).
Good luck!

What's the behaviour when you dragging these models and textures into the editor?

Just nothing happens :(

repo: pissang/clay-viewer


text:
Is it possible to use RGB image as input, without hair color map?

Hello!
Is it possible to use RGB image as input, without hair color map?
Thanks!

It support such behavior after the latest commit.
When you place 256x256 images into predict_from, output with a random hair color.
Thanks.

Thanks for quick answer!
Would you please clearify:
3-channel full-colour image (not a semantic map, but just an anime-type image) used as input, already contains hair colour, as well as face colour and etc.
vanilla pix 2 pix/spade will understand this and generate output image resembling the input colours
why then output of your work will be with totally random hair color?
Yes I understand that if it would be trained on semantic map, the colour is undefined and would be random; but when we train on full-colour - we already "telling" the net how we expect colours to be preserved?
What I am looking for is the modern-age clever paired image to image GAN, and I can't understand why everything nowdays is "semantic map to image" instead.

Oh, I'm sorry. You want to use the RGB image of the anime-type as the style. Semantic labels are also RGB, so I was mistaken.
I don't follow state-of-the-art GANs, so I don't know much about recent pix2pix. However, the pix2pix with SPADE in this repository does not use the style control by KL divergence shown in the original paper. Ideally, as you say, full-color anime images should be used by encoders to compute noise and learn latent representation. However, since I do not have enough computational resources, I could not generate a synthetic anime image using both a semantic map and a style image as the target with encoders.
Therefore, in this repository, instead of learning styles, only hair is learned in a small network, so no anime-type images are used as input for the generator as a target style.
I think the recent trend of generating images from semantic maps is probably to reproduce the pen that generates hair, eyes, etc. in drawing software. It seems to me that this is probably a more interesting application than regenerating the same images.
I'm sorry if I'm missing the point as I don't fully understand your question.

Sorry for the late reply.
I have often heard of things like AnimeGAN2 which converts images to anime style.
SPADE is a method to restrict the loss of semantic information when generating images from Semantic maps. So I am not sure if the same effect can be theoretically performed for an image obtained from a camera. Even if the accuracy is improved, the fact may be due to an increase in the number of parameters.
Thanks for all the discussion. If you have any other questions, please let me know.
The answer to this question of whether my model will produce the desired results with the input image from the camera is NO.
Thanks.

authors: Kitty-sunray pit-ray


text:
FEATURE REQUEST: modify the product-download to allow a user to choose light or full stemcell.

During product-downloads, we need to specify the full stemcell vs the light stemcell. Currently we do the product-download only to follow it with a download of a full stemcell.  It would be beneficial if we could influence the download to get the product and full stemcell in one operation.

Thanks for the issue.
Pivnet only has one or the other per IAAS. For example, xenial AWS and GCP are just the light ones. Pivnet does not have the full for AWS and GCP. If Pivnet does not have it, download-product cannot get it.
This isn't functionality we can add to om. A discussion with team/product manager of the bosh team will need to happen.
I'm going to pass this along to the bosh team. And see if they have feedback.

hello @Houlistonm,
What is the requirement you have for obtaining both light and heavy stemcells? Is there a particular problem you're having where having both solves it?
The light stemcell is a pointer to an image already residing within the IaaS, which means the light stemcell is essentially the same as the heavy but is faster to upload for the operator due to the cloud already holding most of the bits. The heavy stemcell contains everything so the burden of upload falls on the operator. Bosh strives to provide the minimum and most effective artifacts to increase performance of uploads/deploys.
Rebecca, BOSH

The problem is I'm working in a private/on-premise (air gap) IAAS, and the light-stemcells don't work for us because we don't have the AMI's referenced in the light stemcells.
We're trying to use platform automation to download products/stemcells from Pivnet but we have to followup each download with a second download of the full stemcell.
I was looking for some platform-automation way (via OM) to download the product and full stemcell.

I see, that makes sense. + @mgadiya who is PM on bosh systems team looking after stemcell publishing.

@Houlistonm thanks for sharing the use case.
What are the additional problems with getting the stemcell in two operations other than needing the logic to to wait for product download and then run the stemcell download?

I'd prefer to use the Pivotal Platform Automation with out having to modify it to account for the full stem cells.  This is going to be an ongoing issue for us and other customers with a private IAAS.

@mgadiya do the CPIs provide a consistent abstraction for downloading the stemcell in two operations as you describe? The problem with getting the stemcell in two operations that I see is that light stemcells are slightly IaaS specific, so if om implemented "follow the URL" logic it would hard code the number of IaaSes om supports in kind of a weird way.

Just for my own clarity, This issue has been closed and we're still discussing it.  Will some action be taken to account for the download of full stem cells to support private/air-gaped IAAS?

@Houlistonm I believe @jtarchie closed this believing that, unless the Bosh team makes the other type of stemcell available on Pivnet, this feature would be impossible. The Bosh team seems to be suggesting that OM could instead get the full stemcells from the AWS bucket they are stored in, which I am attempting to clarify.
I'm continuing to discuss this to ensure some action is taken, there is not clarity on what it should be yet.

@evanfarrar has there been any follow up on this?

Closing due to inactivity, if this is still an issue please re-open.

This request is still valid, please re-open.

authors: Houlistonm evanfarrar h4xnoodle jtarchie kcboyle mgadiya nbconklin

repo: pivotal-cf/om


text:
🛑 Edge Platform is down

In c479b6b, Edge Platform (https://edge.pixify.co.uk/) was down:

HTTP code: 403
Response time: 87 ms

Resolved: Edge Platform is back up in fba82f5.

repo: pixifydigitalagency/monitors


text:
Problem with outline and drop-shadow filter interaction

When I try to add outline and drop-shadow filters to Text class using
txt.filters = [new OutlineFilter(2, 0xFF0000), new DropShadowFilter(90, 5, 1, 0x00FF00, 1)];
all works fine, but when I use different order of filters
txt.filters = [new DropShadowFilter(90, 5, 1, 0x00FF00, 1), new OutlineFilter(2, 0xFF0000)];
drop-shadow filter doesn't work

Post a fiddle, save our time :) Or dont, and wait when I wont be that lazy like now (sunday evening)

Also, just as an aside, Text already supports both dropshadow and stroke styling: http://pixijs.io/pixi-text-style/. Is there a ready why you want to use filters here?

Text it is only for example. In Text, beter to use it's own filters.

Please provide a jsfiddle which demonstrates the bug.

This seems to work fine. Closing this issue.
https://jsfiddle.net/bigtimebuddy/vamq5kLb/

authors: bigtimebuddy ivanpopelyshev meerfolk

repo: pixijs/pixi-filters


text:
Named exports

Description of change

Converted functions and classes to be named exports.
buildLine.js now has  buildNonNativeLine() to allow for buildLine to be the named export.
GroupD8 and CanvasTinter are now namespaces in the docs

This PR is dependent on an update to the es6 plugin for JSDocs template.
That PR can be found here: #19
Pre-Merge Checklist

[x] Documentation is changed or added
[x] Lint process passed (npm run lint)
[x] Tests passed (npm run test)

Codecov Report

Merging #6051 into dev will increase coverage by 0.05%.
The diff coverage is 98.82%.

@@            Coverage Diff             @@
##              dev    #6051      +/-   ##
==========================================
+ Coverage   71.06%   71.11%   +0.05%
==========================================
  Files         208      208
  Lines       10564    10583      +19
==========================================
+ Hits         7507     7526      +19
  Misses       3057     3057

Impacted Files
Coverage Δ

packages/core/src/shader/utils/defaultValue.js
19.04% <ø> (ø)
:arrow_up:

packages/mesh/src/MeshBatchUvs.js
11.76% <ø> (ø)
:arrow_up:

packages/core/src/textures/GLTexture.js
100% <ø> (ø)
:arrow_up:

packages/prepare/src/CountLimiter.js
100% <ø> (ø)
:arrow_up:

packages/text/src/TextStyle.js
96.87% <ø> (+0.01%)
:arrow_up:

...kages/settings/src/utils/maxRecommendedTextures.js
18.75% <ø> (ø)
:arrow_up:

packages/core/src/shader/Shader.js
51.85% <ø> (ø)
:arrow_up:

packages/core/src/shader/utils/mapSize.js
100% <ø> (ø)
:arrow_up:

packages/core/src/geometry/ViewableBuffer.js
23.8% <ø> (+1.85%)
:arrow_up:

packages/display/src/Bounds.js
91.08% <ø> (ø)
:arrow_up:

... and 165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f10fcb4...6d9def4. Read the comment docs.

@Zyie one last thing, then we should be good to merge: could you bump the dependency to the latest version of @pixi/jsdoc-template should be 2.4.3 (just published) that contains your fix.

@Zyie one last thing, then we should be good to merge: could you bump the dependency to the latest version of @pixi/jsdoc-template should be 2.4.3 (just published) that contains your fix.

@bigtimebuddy done

Awesome first code PR @Zyie! :tada: Thank you

authors: Zyie bigtimebuddy codecov-io


text:
[BUG] Can't exit fullscreen when launching Roblox with Bloxstrap

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
I can't exit fullscreen when launching Roblox with Bloxstrap, I could exit fullscreen it if i launch Roblox without Bloxstrap, btw i'm using nvidia drivers

nvm its just cuz im using vulkan

repo: pizzaboxer/bloxstrap


text:
[BUG] Miscellaneous section missing

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
I tried to launch multiple instances of roblox, but  I couldn't since I was getting warnings from bloxstrap that it would close the other one, so I checked bloxstrap, but when I scrolled down there was no miscellaneous section.

i just downloaded an older version of it

authors: Rayohgamer fvfawesome


text:
Megathread - Roblox crashes, shows an error, or refuses to open

Because of how common this issue is, I think it would be best to have this thread which people can comment on, instead of having to open a new individual issue each time, which eventually get closed.
This is primarily made in hopes that we can gather together more solutions here to add to the informational Wiki page.
By the way, if you haven't read it yet, read it. Now.
As that page says - If your problem is only happening with Bloxstrap, then please open an issue.
Otherwise, feel free to drop in here.
Related: Some sort of fix for the SensApi.dll (#540)

this happens to me rn

Not completely sure if this is exclusive to Bloxstrap or some sort of incompatibility with my setup, but every now and then when I launch Roblox I get an error message which says "Failed to load library: sensapi.dll" and it gives me an option to create a .tmp file which I have no idea how to decompile, but I can provide it on request
It doesn't show up every time, but I notice when I use something like Medal (clipping software) Roblox refuses to launch at all and repeatedly comes up with the same error, so I have a feeling it might somehow be related to Byfron
I haven't found any permanent solutions since the error does stop showing after a few attempts; best clues I have on this is the above, and that it seems to happen more commonly just after booting up my PC. sorry if this seems vague

Hm, I'll try out Medal. If I find that to be consistent, then I'll add it.

but I can provide it on request

That's for Roblox, I won't be able to do anything with it.

seems to happen more often in the first few minutes the pc is turned on, might be something like file indexing idk

Does clearing cached thumbnails fix this?

The issue seems to have fixed itself - I haven't been able to reproduce it anymore, not even with Medal, and I haven't tried clearing thumbnails yet, so I can't test this. If the issues does come back and start happening consistently, I'll give it a try

The game does crash after a few minutes, it starts by a short freeze, then closes the game without sending any error or crash report, I use windows 11 on a computer that ran windows 10 before the update but I don't think that's the origin of the crash.. I have installed the 2.5.2 version of bloxstrap also, it haven't fixed the problem yet...

The game does crash after a few minutes, it starts by a short freeze, then closes the game without sending any error or crash report, I use windows 11 on a computer that ran windows 10 before the update but I don't think that's the origin of the crash.. I have installed the 2.5.2 version of bloxstrap also, it haven't fixed the problem yet...

I discovered that the crashing problem of mine was caused by the game I am playing a lot, 'Plane Crazy' and is not due to the bloxstrap client I am using, my apologies for the incovenience.
Plane Crazy is a game I use to play a lot, and due to it's hardcoding, a roblox update might have made this game unstable, I have been testing bloxstrap on other games and the crashing problem nether occured on theses other games.

By the way, if you guys haven't seen:
https://devforum.roblox.com/t/crash-reports-from-specific-trusted-players-in-specific-games/2571456
https://devforum.roblox.com/t/specific-game-keeps-crashing-nbever-happened-before/2577584

https://www.wikihow.com/Why-Does-Roblox-Keep-Crashing#:~:text=Try clearing the Roblox cache,fails%2C uninstall and reinstall Roblox
do everything on this site and close ur pc for like 12 hours then try again

When I use Bloxstrap or the standard Roblox launcher, it shows the loading screen and then refuses to open.
It is probably because of Hyperion detecting some process, however I don't use RTSS/Afterburner or other tuner applications.
Is there a way to see which process triggered Hyperion? I also found some suspicious processes (such as OMEN Optimizer) and killed them, however Roblox still refuses to load.
I think the problem was fixed for those who killed their respective triggering processes, but I fear that Hyperion may have banned/flagged my windows user and that I have to create a new one to play again.

Is there a way to see which process triggered Hyperion? I also found some suspicious processes (such as OMEN Optimizer) and killed them, however Roblox still refuses to load.

For this type of crash, I don't think so, no.

yeah well the game only gets into the home page then crashes seconds later when relaunching the game frozes and gives not responding state, ms store runs perfectly fine but its bad since it doesn't have voice chat feature, seems like the issue here is byfron

A fix which helped me a few months ago when roblox kept saying it encountered an unrecoverable error and crashed is disabling virtualization from BIOS, apparently Virtualization technology f*cks up with the Roblox client, crashing it immediately, so if you are a person who uses emulators and also plays roblox, sorry for your loss.

The problem I have is the one where it just opens for a few seconds and crashes. This only started when i got Bloxstrap and effected the normal roblox client as well.
Like LolloDev said, I think Hyperion hardware banned me from roblox, since the same problem effects the windows store client and mobile client (emulated from bluestacks)
The only option I haven't tried is reseting it, tried reinstalling windows, booting into safe mode, uninstalling updates, etc
Hopefully this can be fixed soon so I don't have to resort to stretching my thin steam library dry.

whenever i try to launch roblox with bloxstrap it doesnt work, but if i delete blox strap works perfectly fine

whenever i try to launch roblox with bloxstrap it doesnt work, but if i delete blox strap works perfectly fine

mine too

Yeo! Fellas how do i fix this?

When using Voxel lightning, game seems to crash after some time.

When using Voxel lightning, game seems to crash after some time. (I have only played Cursed Tank Simulator recently, and don't know if this is also occurring on other games)

Please do test on other games before claiming it crashes "after some time", it seems like you're having the same issue as the majority of people are currently experiencing, note that this isn't isolated to Bloxstrap but to even UWP and normal vanilla clients.
See this thread: https://github.com/pizzaboxer/bloxstrap/issues/828

I found a fix for roblox refusing to open or roblox not launching. All i did is i install avast antivirus and then i launch roblox it works

I found a fix for roblox refusing to open or roblox not launching. All i did is i install avast antivirus and then i launch roblox it works

This definitely did not fix it, most likely a one off or that you might have had malware present on your machine.

has it been fixed i still cant play

has it been fixed i still cant play

We are unsure, it seems to be currently on and off.

any fixes yet?

the windows version

I keep getting this error

Here's a couple log files
0.603.0.6030563_20231116T143006Z_Player_25441_last.log
0.603.0.6030563_20231116T143024Z_Player_E2646_last.log
0.603.0.6030563_20231116T143045Z_Player_66994_last.log
0.603.0.6030563_20231116T143819Z_Player_5453A_last.log

No one is reporting an issue with the official roblox client this seems to be a bloxstrap issue

You can't say that unless you actually try it without Bloxstrap first. https://github.com/pizzaboxer/bloxstrap/wiki/Switching-between-Roblox-and-Bloxstrap
How long has this been happening?

No one is reporting an issue with the official roblox client this seems to be a bloxstrap issue

You can't say that unless you actually try it without Bloxstrap first. https://github.com/pizzaboxer/bloxstrap/wiki/Switching-between-Roblox-and-Bloxstrap
How long has this been happening?

Roblox works fine, When i do bloxstrap i get those errors i posted my logs

I deleted them because you publicly posted your log files. Feel free to send them to me again privately over Discord.

oh got it just sent a friend request

It just started happening now with the normal roblox client after fully uninstalling bloxstrap and roblox, then just reinstalling roblox. Roblox servers still aren't down as of now so im confused on why this is happening?
I ran sfc /scannow, and the flushdns commands but still nothings wroking.

Seems like Roblox isn't properly authenticating you for some reason. If you delete the folder at %localappdata%\Roblox\LocalStorage first, then try launching Roblox, you should be able to re-login, and everything should work.

Seems like Roblox isn't properly authenticating you for some reason. If you delete the folder at %localappdata%\Roblox\LocalStorage first, then try launching Roblox, you should be able to re-login, and everything should work.

i deleted it and relogged in and still got the same Http error 529. Should i just delete all roblox related files and redownload it?

Nope what the fuck i deleted every single roblox file in my main drive, reinstalled bloxstrap and its till the exact same errors like the website roblox.com works perfectly fine why is the app being stupid?

I also posted it in RobloxHelp on reddit a lot of people without a modded roblox client are also experiencing this issue
https://www.reddit.com/r/RobloxHelp/comments/17womgr/roblox_strange_errors_servers_not_down/

Http error 529

Oh, that explains so much. Open C:\Windows\System32\drivers\etc\hosts with notepad and show me what's inside of there.

Http error 529

Oh, I didn't even see this at first. That explains it. Open C:\Windows\System32\drivers\etc\hosts with notepad and show me what's inside of there.

Looks like nothing relevant or important

...Is that everything?

fitgirl enjoyer

...Is that everything?

Yes LMAOOO

fitgirl enjoyer

Apprently so ig i pirate a lot

Yo im losing my flipping mind out here

Yes LMAOOO

Somehow I doubt that. Copy and paste the entire contents of the file here.

Yes LMAOOO

Somehow I doubt that. Copy and paste the entire contents of the file here.
Also, open a Command Prompt window, type in the following: ping gamejoin.roblox.com Show the output of it here.

Wanna bet?
Copyright (c) 1993-2009 Microsoft Corp.

This is a sample HOSTS file used by Microsoft TCP/IP for Windows.

This file contains the mappings of IP addresses to host names. Each
entry should be kept on an individual line. The IP address should
be placed in the first column followed by the corresponding host name.
The IP address and the host name should be separated by at least one
space.

Additionally, comments (such as these) may be inserted on individual
lines or following the machine name denoted by a '#' symbol.

For example:

102.54.94.97     rhino.acme.com          # source server
38.25.63.10     x.acme.com              # x client host
localhost name resolution is handled within DNS itself.
127.0.0.1       localhost
::1             localhost
109.94.209.70      fitgirlrepacks.in               # Fake FitGirl site
109.94.209.70      www.fitgirlrepacks.in           # Fake FitGirl site
109.94.209.70      fitgirlrepacks.co               # Fake FitGirl site
109.94.209.70      fitgirl-repacks.cc              # Fake FitGirl site
109.94.209.70      fitgirl-repacks.to              # Fake FitGirl site
109.94.209.70      fitgirl-repack.com              # Fake FitGirl site
109.94.209.70      fitgirl-repacks.website         # Fake FitGirl site
109.94.209.70      www.fitgirlrepacks.co           # Fake FitGirl site
109.94.209.70      www.fitgirl-repacks.cc          # Fake FitGirl site
109.94.209.70      www.fitgirl-repacks.to          # Fake FitGirl site
109.94.209.70      www.fitgirl-repack.com          # Fake FitGirl site
109.94.209.70      www.fitgirl-repacks.website     # Fake FitGirl site
109.94.209.70      ww9.fitgirl-repacks.xyz         # Fake FitGirl site
109.94.209.70      *.fitgirl-repacks.xyz           # Fake FitGirl site
109.94.209.70      fitgirl-repacks.xyz             # Fake FitGirl site
109.94.209.70      fitgirl-repack.net              # Fake FitGirl site
109.94.209.70      www.fitgirl-repack.net          # Fake FitGirl site
109.94.209.70      fitgirlpack.site                # Fake FitGirl site
109.94.209.70      www.fitgirlpack.site            # Fake FitGirl site
109.94.209.70      fitgirl-repack.org              # Fake FitGirl site
109.94.209.70      www.fitgirl-repack.org          # Fake FitGirl site
109.94.209.70      fitgirlrepacks.pro              # Fake FitGirl site
109.94.209.70      www.fitgirlrepacks.pro          # Fake FitGirl site
109.94.209.70      fitgirlrepack.games             # Fake FitGirl site
109.94.209.70      www.fitgirlrepack.games         # Fake FitGirl site
109.94.209.70      fitgirl-repacks-site.org        # Fake FitGirl site
109.94.209.70      www.fitgirl-repacks-site.org    # Fake FitGirl site
109.94.209.70      fitgirls-repacks.com            # Fake FitGirl site
109.94.209.70      fitgirlrepack.cc                # Fake FitGirl site
109.94.209.70      fitgirlrepacks.org              # Fake FitGirl site
109.94.209.70      www.fitgirls-repacks.com        # Fake FitGirl site
109.94.209.70      www.fitgirlrepack.cc            # Fake FitGirl site
109.94.209.70      www.fitgirlrepacks.org          # Fake FitGirl site

So it can ping the servers fine, but cant connect to the servers in the client even after deleting every single roblox related file then reinstalling roblox (and separately bloxstrap)

wait what
i opened roblox and re ran it then got this

Why is it now unreachable when i open roblox?

Problem solved ig

nvm

Problem solved ig

clearly not dude lol

rip

I know I sound like a bot saying this but if you have a VPN turn it off or try using a vpn

Or try another account

wont be vpn related issue roblox runs fine on my phone when its connected to the same wifi

(i dont use vpns either)

maybe try different WiFi on your pc like a hotspot it might be your pc unhappy with your internet

Or maybe try resetting your pc but keeping files

its technically the same but i have two diffrent bands the 2.4 and 5ghz as expected even on my 2.4ghz band it dont work

Or maybe try resetting your pc but keeping files

last thing im doing is factory resetting my computer over roblox

Hmm

True maybe try another account

i highly doubt thats the problem but imma try it anyway
or not because roblox said fuck you
And this one is the rarer pop up this comes up like once every 15 times i open roblox and of course pressing retry does nothing

At this point hopin anything works lol

Anything here i gotta change?

Don't think so

idk what that is exactly

i have admin privileges to my router so i can check everything

did u try another account?

oh yea forgot lmao imma try

kk

oh yeah log out button doesnt wanna be pressed that makes sense roblox

classic roblox

oh nevermind it was just so delayed
by like 50000 ping

Try logging into another account on the web browser then launching a game from the browser that changes account

classic

bruh

Send fflag list rq

see what i dont get is why the fuck the log out button takes years to actually respond

yup typical

this is why i play genshin

anyways send fflag list rq

flag list request?

or wym lol

flag list real quick

got it got it what the flip is the flag list

Open bloxstrap menu

i have no custom ones

Click fast flag editor

oh i press show present flags

Looks completely fine to me. Okay, I am completely stumped on why this is happening.
@Findyourlimit Stop providing useless advice. We've already established this is a problem with Roblox itself.

srry

Looks completely fine to me. Okay, I am completely stumped on why this is happening.
@Findyourlimit Stop providing useless advice. We've already established this is a problem with Roblox itself.

check the later screenshots i ran the command when i opened roblox and suddenly it just couldnt ping the server

and suddenly it just couldnt ping the server

I noticed those, but those also don't exactly correlate with a HTTP 529 error. I don't know if I'll be able to spot anything different this time, but can you please send me Roblox's latest log file again from %localappdata%\Roblox\logs?

Can i just send them here would be faster

Do NOT send them here. I ask you to send them privately for a reason.

yes sir

Am waiting for u to accept it

user is matthewboi520

Join the Discord server and send me it.

Where in the server do i send it?

Nvm i sent it

in pms

Resolved in DMs (caused by some shitty mcafee web filter that's integrated into verizon routers for some reason)

Yeah it's fucking stupid if you got Verizon fios download their app and make sure that it's disabled

pizzaboxer can i dm you in discord?

my roblox is not opening when i press play only windows version works
bloxstrap is open but only as a hidden icon

A few days after i first installed bloxstrap i would crash on games like minus elevation and etc etc, I uninstalled both bloxstrap and roblox and reinstalled roblox to see if it would get fixed, and it still continues to crash on every game i play, i've done everything i could think of, (clearing cache, launching roblox as a administrator, disable fullscreen optimization and more) however it still continues to freeze for a second or two out of nowhere, then bam, application closed. this has been happening since late september i think? i have been using my own ClientSettings folder prior where it would just have DFIntTaskSchedulerTargetFps as the only code on it, and it's never crashed during that period until i installed bloxstrap, so i'm not sure for the cause of these crashes anymore, i have plenty of ram and cpu available for usage so its not a hardware issue, any help would be appreciated

i think the problem for some is an app called fiddler

delete it

I don't have a app like that downloaded

my roblox is not opening when i press play only windows version works bloxstrap is open but only as a hidden icon

Restart your computer or reinstall roblox if you haven't already

Just came in to say that, if your issue is still not resolved, your best bet is joining the Bloxstrap Discord server and going into the support-and-bugs forum

Invite: https://discord.gg/bloxstrap

I've been dealing with an issue where my Roblox tab will randomly close itself out of the blue. I can be using the site actively and it randomly closes on me, but I've also had it happen when I leave the game on overnight. Are there any well-known potential causes to check?

I've been dealing with an issue where my Roblox tab will randomly close itself out of the blue. I can be using the site actively and it randomly closes on me, but I've also had it happen when I leave the game on overnight. Are there any well-known potential causes to check?

My settings are already set that way. Is it just automatically updating when it closes?

I just checked if my FPS settings was doing anything, and it didn't change anything. I ran the default launcher just fine when i swapped back to it, but bloxstrap still occasionally crashes when i use it instead.
I have no fastflags set, and no custom fonts enabled. The only thing I really have active is the disable desktop app function and the FPS settings. Should I try a fresh reinstall or is there something else I can do to try and get this fixed?

Should I try a fresh reinstall or is there something else I can do to try and get this fixed?

Settings.json
State.json
ClientAppSettings.json
Here are my configurations.

All looks good, you might want to try disabling the disable desktop app option here. If that doesn't work, then disable all of your integrations, and see if that works too.

All looks good, you might want to try disabling the disable desktop app option here.

When I had the desktop app enabled, Roblox has ran just fine, and didn't crash. The issue might be either with Hyperion disliking the setting or the activation trigger for desktop app disable being run prematurely. It could easily be something else, I haven't read the source code so I wouldn't know for sure, and it has only really been a day or two since the settings change, but that setting is a good idea to look into if you decide to hunt the source of the issue.

When I had the desktop app enabled, Roblox has ran just fine, and didn't crash.

Yeah, that sounds about right to me. The way we disable the desktop app currently does some weird stuff, and we're planning on changing how it works to be a lot less terrible. I'll add a disclaimer for this in the crash diagnostics Wiki page.

Yeah, that sounds about right to me. The way we disable the desktop app currently does some weird stuff, and we're planning on changing how it works to be a lot less terrible. I'll add a disclaimer for this in the crash diagnostics Wiki page.

Sounds good to me. In the meantime, I'll keep that setting disabled and see how things go. I'll update here if another crash happens and i find any other settings to be causing similar issues.

Does anyone know why I'm experiencing crashes? I have tried using both Bloxstrap and the native Roblox launcher from the web variant. Specifically, it crashes when I click on certain things. For example, when I click on 'More...' on the left side of the home menu and go to Inventory, Messages, Blog, among others, it crashes. The same happens when I click on servers in Roblox games.
Video
https://github.com/pizzaboxer/bloxstrap/assets/149345849/632574f7-fec7-405d-8687-5509f5c0a5f8

Seems like something is wrong with the WebView2 runtime. Can you try and reinstall it please?
Uninstall it from Windows Settings, should show up like this:

Then, launch Roblox, and it should reinstall it automatically.

I fixed it, but differently from what you suggested. I uninstalled it, then launched Roblox, but it didn't reinstall for me. Then, I attempted to install the Evergreen Bootstrapper from Microsoft, but it gave me an error, saying that my system doesn't meet the minimum hardware requirements. So, I then installed the Evergreen Standalone x64, and that seemed to work.

Alright, good to hear.

Not sure if this is the place to say this but I am also getting the same Sensapi dll error, though I don't have the bloxstrap roblox installer installed. I'm on the latest version of windows 10 and I've uninstalled and installed roblox multiple times and still not getting roblox to work. At the end of my rope with this one:

Also getting a "memory dump" pop up. I have no idea what this means:

hey I need help with roblox crashing, I looked through the thread but was unable to uninstall the microsoft edge webview2

hey I need help with roblox crashing, I looked through the thread but was unable to uninstall the microsoft edge webview2

Are you sure it's related to WebView? If so, you should be able to uninstall it by opening your Start menu and searching for "Add or remove", open it and keep searching for Webview and then remove it.

I don't know, it just wouldn't let me uninstall it when I found it on the apps

I don't know, it just wouldn't let me uninstall it when I found it on the apps

Having the same exact problem. It won't let me uninstall the webview2. I'm starting to wonder if this is just a bad windows update since I updated it about a week and a half ago

What does it do when you try to uninstall it?

What does it do when you try to uninstall it?

Nothing, because I can't even press the uninstall button. It's greyed out for me:

What about if you click modify?

Tried that already, and it doesn't do anything either. Apparently it's supposed to reinstall webview but still, launching roblox gives me the same error

If you just download and run the installer as-is, it should give you the option to uninstall/reinstall anyway. Use one of the Evergreen downloads. https://developer.microsoft.com/en-gb/microsoft-edge/webview2/?form=MA13LH

Did what you said, and still no results:

See if you can uninstall it via winget, by opening a Command Prompt window and running this command:
winget uninstall --id Microsoft.EdgeWebView2Runtime

Still nothing. I wonder if I just have a bad windows version

At this point, I don't really have any other suggestions than to just try and uninstall Microsoft Edge along with it too.
Steps to do so can be found here: https://gist.github.com/ave9858/c3451d9f452389ac7607c99d45edecc6
Afterwards, see if it lets you reinstall the runtime. You can also reinstall Edge too if you wish.

Alright that's no prob, when I have time I'll try it out. Thanks so much for your help though, I appreciate it

I'm having this exact issue, and it does seem to be pretty consistent for the entirety of today and was not an issue before today. It unfortunately is pretty unpredictable in the reason as to why from what I'm noticing. However the way it crashes the same way, I'll be in the middle of playing, usually within the first 30 minutes the screen will freeze and I will receive a notification that it has crashed and Windows 11 is cleaning the program. It's been no matter the game, and only when I have more than 1 tab of Roblox open. Once I get a photo of it happening I'll be putting that in this thread. I hope it helps rule out what's going on

and only when I have more than 1 tab of Roblox open.

Are you using Bloxstrap to play with multiple instances?

Are you using Bloxstrap to play with multiple instances?

I am, I'm using it to have 3 instances of it open

I am, I'm using it to have 3 instances of it open

How's your memory usage?

Keeps happening, disabled my FastFlags to make sure they weren't interfering but when I try to use Multiple instances it just gives me an Auth Error ("There was a problem authenticating" or something similar) or the normal Roblox Crash message. Messed with my settings to see what might interfere, could just be a Bloxstrap issue.

I have a feeling that the recent update just screwed bloxstrap so hard

Yup, same issue here. Keeps freezing for no reason after some time.

For now it seems like Bloxstrap is just broken entirely, fresh installations work for the first boot of a game but then it refuses to boot again after tweaking or adding fastflags like
{"FFlagDebugGraphicsPreferOpenGL":"true" which I utilize to get a stable framerate. It's a shame.

but then it refuses to boot again after tweaking or adding fastflags like

Yeah, I think that's to be expected. You've read the warning at the top of https://github.com/pizzaboxer/bloxstrap/wiki/A-guide-to-FastFlags, right?

I did, and was looking to other's guides for Fastflags. Vulkan boots fine, might be an issue with OpenGL itself is as much as I can assume.

Don't use OpenGL, although it might work, it's deprecated and has absent shaders.
Really you should just stick to what Roblox decides to use, though I don't see how this issue ties into your original issue which is the fact that Bloxstrap is not working with multiple instances, make a separate GitHub issue or create a thread in the Discord server as I don't see how this is related to Roblox crashes.

Apologies for that! I was not sure where to go and didn't intend to get off track with the shader Fastflags, I'll do that as soon as I can, thank you!

You have probably already been aware, but as a quick update, multi-instancing is being removed in the next release of Bloxstrap.

I can't start Roblox anymore, everytime I press the play button the RobloxPlayerBeta never starts up, and after a very long time gives me an error message like "Clean Install Windows" or just that the client has crashed, I have uninstalled bloxstrap, but before I did or when I reinstall it, it'll start Bloxstrap and load, and then it'll close.

I can't start Roblox anymore, everytime I press the play button the RobloxPlayerBeta never starts up, and after a very long time gives me an error message like "Clean Install Windows" or just that the client has crashed

You seem to be facing a issue regarding Hyperion, I'm guessing this also happens on the normal client? If so, reach out to Roblox support.

I have made a ticket, I think it is a bloxstrap issue still, because I can swear the Roblox install is what the Progress looks like with Bloxstrap, I have uninstalled every file I can find of Bloxstrap though

I have uninstalled every file I can find of Bloxstrap though

I hope you mean you've uninstalled it, via the Add or remove programs settings, please don't just randomly delete files as no files should be left over from correctly uninstalling Bloxstrap.

I have fully uninstalled using that also

Could not connect to https://clientsettingscdn.roblox.com/v2/client-version/WindowsPlayer/channel/zlive because it returned HTTP 401 (Unauthorized)

Move off of the zlive deployment channel, it is locked by Roblox, better to stay on the LIVE channel always.

I am getting HTTP 403 Forbidden when i launch bloxstrap
[DFLog::HttpTraceError] HttpResponse time:461.0ms (net:460.9ms callback:0.0ms timeInRetryQueue:0.0ms)status:403 Forbidden bodySize:113 url:{ "https://auth.roblox.com/v1/authentication-ticket/redeem" } ip:128.116.44.4 external:0 numberOfTimesRetried:0 [FLog::Warning] WebLogin http error: {"errors":[{"code":4,"message":"Authentication ticket was invalid.","userFacingMessage":"Something went wrong"}]}, statusCode: 403 [FLog::Warning] WebLogin authentication is failed and App is quitting

There is a serious problem Bloxstrap is not working well!!
https://github.com/pizzaboxer/bloxstrap/issues/1912

My Roblox works fine but I get Roblox Crash: "An unexpected error occured and Roblox needs to quit. We're Sorry". But I can still run my roblox if I ignore the error message, however if the game requires switching servers via teleport it'll crash like it's supposed to, anyone else have that issue?

try removing the fastflag DFFlagVideoCaptureServiceEnabled

It has come to my attention that this issue may also be caused by Windowblinds.
Reverting back to Windows' default theme via the menu was the solution for me that stopped Roblox from running as a background process.
If you have Windowblinds, or another similar theming program (Not Open Shell, thankfully), I suggest doing the same.

Yes, it is being caused by WindowBlinds. I forgot to add that info to the Wiki, sorry about that.

My Roblox works fine but I get Roblox Crash: "An unexpected error occured and Roblox needs to quit. We're Sorry". But I can still run my roblox if I ignore the error message, however if the game requires switching servers via teleport it'll crash like it's supposed to, anyone else have that issue?

try removing the fastflag DFFlagVideoCaptureServiceEnabled

Hey thanks for the potential solution, I gave this a try but it still does the same thing.

I need help please. Bloxstrap for me keeps crashing every 30-40mins continuously and now the time gaps are just getting shorter every time. I have tested if the same is with regular Roblox and it is not the case.

Omdddd it is still happening xd. Can someone actually help me

nvm im good

the game appears in the task manager as open, but never actually opens.
I don't know if it's a bloxstrap problem, I don't know if it's a Roblox problem, or if it's my PC asking to quit

Edited

I'm having the same issue. has it not been fixed yet?

Edited

I'm having the same issue. has it not been fixed yet?

probably

the game appears in the task manager as open, but never actually opens. I don't know if it's a bloxstrap problem, I don't know if it's a Roblox problem, or if it's my PC asking to quit

Note: this problem has been around for a few days, but it has never happened. no error message or anything appears

I don't think it's a problem with my fastflags, since I already used them and they worked correctly
(I never created/imported one, I only use the default ones, enabling everything that can positively impact my fps)

Ik what ur issue is

It is due to the fact you have Riva Tuna Statistics running. Turn this off and then run bloxstrap. If it still doesnt work, lmk ill give you another solution

I keep getting System.IO.DirectoryNotFoundException
Bloxstrap_20241016T185035Z.log

@SatinFoil What's the path of your user profile folder? Open %localappdata% in Explorer and report the full path, censoring your username if needed.

i dont know why this happens and how it occurs but when i press play on a game and it shows me the loading screen it eventually gives me an error saying roblox couldnt be started and that it will show me a page on my browser when i close the message, when i closed the message nothing happened
after restarting my computer it still persisted and i got the error, but i didnt bother closing the message this time, and for some reason roblox just loads with all bloxstrap modifications working normally??

i also have the log if it helps
Bloxstrap_20241112T125736Z.log

Strange errors here, Roblox refuses to open if it was installed by Bloxstrap. Has normal behavior if installed using the regular Roblox installer. No logs, using the regular bootstrapper throws the same error (likely a download/roblox installation folders issue), and deleting all files and reinstalling fails. There's a chance it has something to do with Hyperion detecting something odd.
Happening since v2.8.1, if you're wondering.

Nvm I'm just going to open an issue

This error prevents to run Bloxstrap on Windows Server 2025
Bloxstrap-export-20241228T034059Z.zip

This error prevents to run Bloxstrap on Windows Server 2025 Bloxstrap-export-20241228T034059Z.zip

I'm pretty confident that the issue lies with you trying to run Roblox on Windows Server edition, is there any reason for you to use server edition over consumer versions of Windows?

I'm pretty confident that the issue lies with you trying to run Roblox on Windows Server edition, is there any reason for you to use server edition over consumer versions of Windows?

Previously Windows Server 2022 playing fine without errors

Previously Windows Server 2022 playing fine without errors

Yes but that was on 2022 edition, not the current edition you're attempting to run Roblox on. Do keep in mind that the error you have posted is related to Hyperion so depending on when you ran Roblox on the 2022 edition something may have changed.

Yes but that was on 2022 edition, not the current edition you're attempting to run Roblox on. Do keep in mind that the error you have posted is related to Hyperion so depending on when you ran Roblox on the 2022 edition something may have changed.

https://devforum.roblox.com/t/roblox-player-refuses-to-run-on-windows-server-2025/3254383

the game appears in the task manager as open, but never actually opens. I don't know if it's a bloxstrap problem, I don't know if it's a Roblox problem, or if it's my PC asking to quit

Note: this problem has been around for a few days, but it has never happened. no error message or anything appears

Caused by Riva Tuna stuff, i can tell by the fps ui in the top left. Uninstall it, Roblox should launch.

my thing wont open and its saying to clean boot on the task manager thing

blox strap keeps crashing, i legit cannot play wiithout bloxstrap

authors: 21Legendz AMD-Edits CitizenFoffie Cosinu-s DragonKillerz Faf4a Findyourlimit Gamerboi520 GoingCrazyDude IncompetentMoron KUNINSYT Kyomi1 LolMakesStuff LolloDev5123 Myooral Nacandcheese Nazannex Pantherartin Random57g SatinFoil SkaarChill T0x1cL TheLonelyGuy1234 Vad1mCSO2 WaviestBalloon bery-real cellat1 curllz danekxd derpzisonthehub dodecaspheeb drissyog ihatewoodenspoons jaynardd moyaimoment pabloisnotmad pizzaboxer randomstuff69 simpleDeveloper11 sleepdude tigra323 whipslayer


text:
Add a default folder for when there is no note open

I recently discovered the full power of this plugin for navigating with the keyboard. It's quickly moved to my most used and loved Obsidian plugin. Thank you!
Here is a suggestion to make it even better: add the ability to configure additional hotkeys that open directly to specific folders.
As an example I have an inbox folder where all new notes go, including externally added clippings. Every so often I process those notes (GTD style) making additional notes and moving thing to the approriate place. When I move a note it's usually into a deeply nested folder structure, and I want go right to the next note in the inbox. Right now I have to open the root folder (CMD+U in my setup) then navigate via the arrow keys. It would be terrific if I could just hit CMD+U and have it already at the fist note in the inbox instead of in the root.

Hm.  How about I add a URL action to open a specific folder?  Then you can use the URI Commands plugin to set up as many specific-folder commands as you like.

That's an interesting idea. I think it would work for me personally, though I can't imagine many other situations where a URL action would be helpful for this plugin, (that doesn't mean they don't exist).
My only other thought is that passing a hotkey to a URL action might feel a little slow compared to a direct call. I haven't done any plugin creation personally, or used the URI Actions plugin, so that's only my uneducated opinion.

You might find it a better workflow to do something like:

Set up a processing-specific workspace using the built-in workspaces plugin
In that workspace, either set the search to path:My/Inbox/Folder or pin a note in one pane that has an embed of that search (or a similar dataview)

Now, when you want to process, just open that workspace and there's your files to be processed, and clicking on any item will open it in the first unpinned pane.  When you move the item out of your folder, the search or dataview will update, with that item gone from it.
When you're done processing, flip back to your standard workspace, et voila.
To be fair, this process does require you to mouse-select your next file to work on, since search and dataview don't support keyboard selection.  However, if you pin a note that's in the folder you want, you can keyboard back to that pane and then open quick explorer and you're in business.  So three or so keystrokes rather than 1, but still 100% keyboard.

My current keyboard driven strategy is already totally tolerable. This would only make it that much faster. I like the idea of using a workspace though.

Well, since the URI thing isn't something you're interested, I'm going to go ahead and close this.  My only other suggestion besides that and the workspace thing is that you make a QuickAdd or Templater macro/userscript to jump to the next available file in your inbox, then bind that to a hotkey.  Or make an index file in your inbox, star it with the stars plugin, then use the hotkeys-for-stars plugin to define a hotkey to jump to that file.  Or...  well, there are lots of ways to handle it, but I don't think the idea of a default folder makes any sense -- the default folder is just the vault root.

I am interested in the URI option. It would be far more flexible than what I was originally thinking of.
I've been testing the waters with both QuickAdd and Templater recently so I'll look into options for using them as well.
I wasn't aware of the hotkeys-for-stars plugin. It turns out the creator also made Hotkeys for specific files which doesn't quite solve my problem but is a good start and super useful in other contexts.

Hm.  How about I add a URL action to open a specific folder?  Then you can use the URI Commands plugin to set up as many specific-folder commands as you like.

Hello @pjeby and @montemartin !
Forgive @pjeby for step into this conversation.
I just wanna say that an URI action to open folder in QE is an amazing feature. It's the of feature that fits perfectly with QE !

URI Commands to specific folders (as @pjeby said)
QuickAdd Multi Choice to create collections of URI for specific purposes/workflows;

If you don't mind, I just wanna add 2 suggestions to this feature:
01. Parameter for bottom
Would be amazing to have a parameter in the URI to define the focus of the selector when opening the folder.

classic example would be the Daily Notes folder, where the most recent notes are in the bottom

I'm assuming that the default position is top
02. Variable for the Active Folder {{folder_-1}} {{folder_-2}} ...
I will try to explain with my poor English.
Imagine this folder structure for the note Guggenheim.md
Continent\North America\Country\USA\State\NY\City\New York\Museums\Guggenheim.md
Guggenheim.md is my ACTIVE NOTE
I want to "travel" between the folders of my active note
To go to the Museums folder I just hit QE: Browse to Current Folder
BUT With a {{variable}} we can create URI to quickly go to other folders related to the active note

folder -1 is New York;
folder -2 is NY;
folder -3 is State ... and so on

Would be great to have a dynamic URI applied to the active note :)
Sorry for the long text !
Have a great day!

It would probably simpler to just allow relative paths, i.e. . for current folder, .. for folder above, and so on.
As far as the bottom thing is concerned, I'm not really sure.  The command I had in mind is effectively "explore this item", which means if you target a folder, the selected item would be the folder, in its parent folder, not a random position in the target folder.  I'd need to add something like folder/ to mean "show the contents of the folder", in which case nothing would be selected and you could go either up or down or type something.
Also, I have noticed, since beginning to use the URI Commands plugin, that running commands is slow because they shell out to the OS and then send a message back to the current process.  (There is a way to speed that up significantly but it requires using a currently-undocumented API in Obsidian.)

It would probably simpler to just allow relative paths, i.e. . for current folder, .. for folder above, and so on.

100% agree much easier to understand :)

As far as the bottom thing is concerned, I'm not really sure.  The command I had in mind is effectively "explore this item", which means if you target a folder, the selected item would be the folder, in its parent folder, not a random position in the target folder.  I'd need to add something like folder/ to mean "show the contents of the folder", in which case nothing would be selected and you could go either up or down or type something.

Would be amazing to have URI without bottom/top @pjeby !!!!

My idea was to show the variety of subset of features that we could have from the main feature which is URI for QE!

Whatever you decide to approach, I know that will be the best for the users and for QE :)

Also, I have noticed, since beginning to use the URI Commands plugin, that running commands is slow because they shell out to the OS and then send a message back to the current process.  (There is a way to speed that up significantly but it requires using a currently-undocumented API in Obsidian.)

Good to know @pjeby !
In my specific case I use the plugin Shell Commands to run my URI (created using Advanced URI plugin) instead of URI Commands.

https://github.com/Taitava/obsidian-shellcommands

From my experience SC is fast and flawless :)

I would use Shell Commands plugin for the QE URIs

Thanks for your replying and for considering URI for QE !
Have a great day!

Actually, it turns out I was incorrect about the performance issue: I was projecting due to the earlier comment by @montemartin, as I only just set up a URI command this weekend and then thought it was kind of slow to respond.  But it turns out that it's actually the Obsidian hotkey settings page that's slow to load for some reason, as every other URI I've set up since then appears to run instantly.

Thanks for the info @pjeby !
When something behaves different from what we expect in Obsidian, we have so many variables to investigate to try to find a solution.
I'm glad to know that URI Command is working great!

authors: FelipeRearden montemartin pjeby

repo: pjeby/quick-explorer

license: ISC


text:
🛑 🗂Pan is down

In 93cbec0, 🗂Pan (https://pan.wayok.cn) was down:

HTTP code: 0
Response time: 0 ms

Resolved: 🗂Pan is back up in b444a65 after 19 minutes.


text:
Send cookies in websocket.

Hello, I have an issue, my server has a HAProxy loadbalancer and I need to send the cookies in the headers and in the connect.
When I add the cookies I can see that the cookies are sent in the request but in socketRocket did connect upgrade, I can see that the cookies in the parameter requestcookies can't be found.
I'm using
    pod 'socket.IO', '0.5.2'
    pod 'SocketRocket', '0.4.2'

My setup is:
    socketIO.cookies = NSHTTPCookieStorage.sharedHTTPCookieStorage().cookiesForURL(NSURL(string: Constants.apiHost)!)
    socketIO.connectToHost(host, onPort: 0, withParams: nil, withNamespace: "NS")

Do you have any idea if I have a bad config or if I should make a PR and add the cookies in the WS request?
My regards.
Francisco.

Bump, any news on this?


text:
adding Github actions

Could someone add github actions integration with this repo so it can test if PRs build or not?

Billy was looking into setting up Github actions with Purpur but decided against it once he saw that artifacts are only stored for 90 days.

I mean for when people submit PRs and new commits are pushed, not really for storing artifacts.

PR builds would be considered dev builds and should be reserved for devs (or at least people smart enough to know how to compile the project). Yes, this is a form of gatekeeping because I dont need normies downloading PR jars ;)

authors: BillyGalbreath Titaniumtown granny


text:
add merchandise store link to sponsor option and homepage

For those that want to sponsor through merchandise.

Closed with https://github.com/plabayo/rama/commit/a447838ef522dacb2db43055f7e91a062109afc9.

repo: plabayo/rama