text:
Load过程中recover失败会delete dbtable，触发shutdown，有时候死锁，有时候core

shutdown1过程中，拿不到某个锁，DBTable或是DBImpl，导致夯住。
另一种情况core
0  0x0000000000956232 in leveldb::VersionSet::LastSequence (this=0x2bf7a420105ff) at ./db/version_set.h:214
1  0x00000000009a4c11 in leveldb::DBImpl::GetLastVerSequence (this=0x7f8faabdf600) at db/db_impl.cc:1678
2  0x0000000000942de5 in leveldb::DBTable::GarbageClean (this=0x7f8e87bcff50) at db/db_table.cc:1112
3  0x000000000093c65a in leveldb::DBTable::Shutdown1 (this=0x7f8e87bcff50) at db/db_table.cc:135
#4  0x000000000093d1dd in ~DBTable (this=0x7f8e87bcff50) at db/db_table.cc:183
5  0x0000000000939c9d in leveldb::DB::Open (options=@0x7f8ebcc38ec0, dbname=@0x7f8ebcc38e88, dbptr=0x7f8ebcc38fd8) at db/db.cc:56
6  0x00000000007f78c8 in tera::io::TabletIO::Load (this=0x7f8ebcc38e30, schema=@0x7f8fba285a30, key_start=@0x7f8f571474c0, key_en

fix

repo: baidu/tera


text:
誤差最小化の最適化手法について

論文：RMSProp
Open AI: Adam
どっちを選択するか．

とりあえず，パラメータ設定楽なのでAdamに

考察項目にまわします。

source: gharchive/issue

repo: bakanaouji/DeepQNetwork

license: MIT

license_type: permissive

license_source: github-api


text:
Can dough works on 1.12.2?

As the title, there are still lots of servers running on old versions such as 1.12.2. Is dought compatiable with 1.12.2?

Some modules of it might be but its likely some things will break. For example, anything using Spigot's persistence API will be broken on 1.14+ (or was in 1.13).
Dough does not aim to support such an ancient version though.

repo: baked-libs/dough


text:
How to configure sails lift to use iojs instead of node?

I'm using jsdom library which requires iojs. I can do iojs app.js which works just fine but I want to do sails lift instead but it throws jsdom error that says I need iojs.

You need to alias node to iojs. Version managers such as https://github.com/tj/n will do this for you.
Another option is to use a 3.x version of jsdom before they decided to break compatibility with node.

authors: miguelmota tjwebb

repo: balderdashy/sails


text:
eslint

Bring in eslint and take care of a few of the most heinous bugs that it surfaced.  This doesn't take care of EVERYTHING though- so the tests will still fail as of the time I'm making this PR.  Once we've taken care of the rest of the warnings (there are rare exceptions where it's appropriate to ignore a rule inline will post an example as a comment momentarily (see below)), this PR will be ready to merge.
Here's an initial list of warnings, for convenience:

To have eslint ignore a line:
var fooBar_baz; // eslint-disable-line camelcase

See https://github.com/node-machine/machine/commit/d0640b58c4d0d9e92d4fbfd811713c2319c28ebb#diff-1522e5213fd7703795b0337442b53911R457 for an example of where the underscores are stylistic and thus this would be convenient/appropriate.  When the underscores are completely needless and aren't stylistic or a property name in some options dictionary we're passing in to an external API, the best thing to do is just use camel case instead

:+1:

@mikermcneil Added a PR to this PR https://github.com/balderdashy/sails/pull/4041

source: gharchive/pull-request

authors: luislobo mikermcneil


text:
Add type checking to OpenGL driver

Would it be possible for RenderDoc to validate the type of the buffer object being passed to OpenGL API functions? e.g. validate that a vertex array object is being passed to glBindVertexArray, as opposed to a uniform buffer object or element array object. It's been the #1 problem that I've encountered in these porting projects, in part because the effects can be subtle and non-obvious, like in the case I just fixed where a VBO was being passed to glBindVertexArray. Having a validation layer perform type checking would have saved me hours of debugging. Perhaps the thunking layer can assign non-overlapping ranges to the different object types - e.g. 0 - 999999 for textures, 1000000 - 1999999 for VBOs, etc - when a special 'type validation mode' is enabled? I suspect that monkeying with the object id values might break the spec, so this is best limited to a special validation mode, but it would trap an entire category of sometimes very non-obvious bugs.

This should be feasible for distinct types, like buffers vs. VAOs vs textures, but it would mean adding an optional remapping call for every case where I pass along a GLuint to the API, which is fairly intrusive.
Validating buffer types (like element array vs UBO vs vertex array) should happen to some extent I think, although it could maybe be improved. It's a bit harder to validate though as it's perfectly legal to change a buffer's type at any time just by calling glBindBuffer - so it'd be impossible to tell if that re-type was intentional or not.

Perhaps RenderDoc could manage a table mapping object IDs to types, updated when glBindBuffer is called? That might introduce a prohibitive time and space overhead, but there are times when I'd be willing to pay that price - assuming that the price was optional, of course. Such a table could provide a history for each object, which would be useful for several different debugging tasks.

Ah that's not quite what I meant - RenderDoc does already track the current binding type of a buffer. But bind-to-edit is still by far the most common usage of GL, and that means before anyone uses a buffer for an 'invalid' type - they do glBindBuffer for it. How do I know if that was an unintentional or intentional type change? For DSA you could validate of course.
To be honest I think the chances are that most people don't ever deliberately re-type buffers (from array to element array or to uniform), so adding an option to warn whenever that happens would then be useful. Together with validation of DSA (which is easier, although not a tiny task) would get you majority of the benefit for minimal cost.

I'm closing this now, validation is a non-goal for RenderDoc in general as it's duplicated work over existing validation and is a huge amount of work in its own right. Small checks here and there can be done, or checks that are in a grey area, but this kind of task is complex and definitely validation related. Lack of typechecking on GL is a clear failing of the API but there's no point leaving this issue open indefinitely when it's never planned to be resolved.

authors: baldurk jshofmann

repo: baldurk/renderdoc


text:
Support latest d3d12 functions and interfaces

Would be great if RenderDoc supports the most recent d3d12 interfaces (e.g ID3D12Device3).
RenderDoc seems to fail hooking up the the corresponding wrappers in case of usage of such interfaces on the latest master.

That support should exist now, although I didn't have much in the way of sample code to test against so it may have bugs. Let me know if you find any problems.

authors: baldurk msiglreith


text:
Application: add rename method

add rename method on application model
See: https://www.flowdock.com/app/rulemotion/resin-frontend/threads/LbX1uMGn7Xex0p5B2wkrbmKHzSE
Change-type: minor
Signed-off-by: Andrea Rosci andrear@balena.io

Contributor checklist

[ ] Includes tests
[ ] Includes typings
[ ] Includes updated documentation
[ ] Includes updated build output

@balena-ci retest

@balena-ci rebase

@balena-ci retest

@balena-ci republish

authors: JSReds thgreasi

repo: balena-io/balena-sdk


text:
application.get: Add support for retrieving applications by uuid

Originally draft just b/c I still haven't added tests.
Resolves: #1016
Change-type: minor
Signed-off-by: Thodoris Greasidis thodoris@balena.io

Contributor checklist

[ ] Includes tests
[ ] Includes typings
[ ] Includes updated documentation
[ ] Includes updated build output

@balena-ci I self-certify!


text:
Update Flowzone to kyle/wait-for-checks

Auto-generated by https://github.com/product-os/flowzone/pull/466
Will be closed automatically once the PR is merged.

Auto-closing pull request

repo: balena-io/docs


text:
Xavier AGX: Use bpmp-fw-dtb from the image instead of the default one

The image might contain a custom bpmp-fw-dtb
that changes parent clocks in can related nodes,
let's use this one instead of the default dtb
provided by the BSP.
Change-type: patch
Signed-off-by: Alexandru Costache alexandru@balena.io

@balena-ci I self-certify!

repo: balena-os/jetson-flash


text:
Problem on configuring CORS in ballerina

Description:
When I try to do a POST request to a ballerina service I get the error No 'Access-Control-Allow-Origin' header is present on the requested resource. on my web browser.
Note Everything works fine when I send a POST request without sending the preflight
Steps to reproduce:
Start a ballerina service and do an AJAX POST request to it
Ballerina Service:
@http:ServiceConfig {
    basePath: "/feedback",
    cors: {
        allowOrigins: ["*"],
        allowHeaders: ["*"]
    }}

service FeedbackCollection on httpListener {
    @http:ResourceConfig {
        methods: ["POST"],
        path: "/pushData"
    }
    resource function updateFeedback(http:Caller caller, http:Request req) {

        var reqPayload = req.getJsonPayload();
        //...
    }
}

Ajax Request:
let axiosConfig = {
        headers: {
            'Content-Type': 'application/json;charset=UTF-8'
        }
        };
        axios.post('http://localhost:9090/feedback/pushData', {data: formdata}, axiosConfig)
            .then(response => {
              // ...
            })
            .catch(error => {});

Affected Versions:
Ballerina 0.990.3
OS, DB, other environment details and versions:
Ubuntu 18.04 LTS
Related Issues (optional):
Suggested Labels (optional):
Component/HTTP
Suggested Assignees (optional):

@SanojPunchihewa Have you hosted your front end server(which does the ajax call)? If you do the operation locally, browser fails to identify the Origin  and set it before calling the ballerina server. That will lead to aforementioned error as Ballerina service does not treat any of the request as cors unless it includes Origin header.
Could you please give us an update on this?

@chamil321 No, I haven't hosted the front end, I just tried it locally. I'll host it and let you know whether it solves the problem

@SanojPunchihewa Did you get any chance to test?

@chamil321 Sorry for taking a long time. When I hosted the front end it is working without any problem.

Closing this issue, as per above comment

Also, this issue is resolved when the ajax call happens via network IP.
Use 192.x.x.x:9000/call instead of localhost:9000/call

repo: ballerina-platform/ballerina-lang


text:
Parenthesis do not get highlighted properly

Description:
The related parenthesis do not get highlighted properly.  In VS code when we click at open parenthesis it highlights closing one related.
Steps to reproduce:
Please see screenshot below.

Affected Versions:
Plugin version: 0.991.2
Ballerina version: 0.991.0

Seems it is not working for block level statements. It works fine on functions.

hmm, seems for worker declarations too, it works fine. Only for if, while - it is broken.

@roonyh, I could get it working by only providing the language configuration to vscode and skipping the textmate grammar file. (Simply commenting out grammar section from package.json contributions).
Hence I suspect this has something to do with tokenizer.

Accidentally closed.

Found the root cause,
https://github.com/ballerina-platform/ballerina-grammar/blob/master/syntaxes/ballerina.YAML-tmLanguage#L247
Removing above rule from grammar fixed it

Seems this is related https://github.com/Microsoft/vscode/issues/45890

Fixed with https://github.com/ballerina-platform/ballerina-grammar/pull/46

authors: abeykoon kaviththiranga


text:
Compiler plugin resources addition not working as expected

Description:
We are using compile-time code generators in WebSub module to add an additional resource to the generated executable programmatically.  But even though we are using this code-generator inside WebSub compiler-plugin, the resource is included into a different resource path rather than resources/ballerina/websub/<major-version>/<additional-resource> inside the executable..
This is regarding the  ballerina-lang change #33987

Closing this issue since the original use-case can be done using code modifiers.
Also, resources will be deprecated due to the suboptimal design.


text:
Getter Setter CodeActions provides code actions when getter and setter are already defined

Description:
Getter Setter CodeActions provides code actions when getter and setter already defined
Steps to reproduce:
consider following ocde example
class Person {
    private int age = 5;

    public function getAge() returns int {
        return self.age;
    }

    public function setAge(int  age) {
        self.age = age;
    }
}

Follow below steps

edit field private int age = 5 to private int age
perform getter setter codeaction again

Here the issue is .text() is missing in the getter setter code action implementation. Need to add .text() as follows in code actions.
String fieldName = String.valueOf(objectFieldNode.fieldName().text());


text:
Syntax errors are not meaningful

Description:
Consider the following source.

The error should be that the statement is not allowed. But the shown error is,
"mismatched input '['. expecting Identifier at Line:9:15"
Steps to reproduce:
Open the below bal file.
import ballerina.net.http;

@http:configuration {
    basePath:"/product"
}
service<http> productService {

    map productMap = loadProducts();
    productMap["001"] = {name:"Pencil",price:20};

}

Affected Versions: 0.95.6
OS, DB, other environment details and versions: N/A

Duplicate of https://github.com/ballerina-platform/ballerina-lang/issues/3673

authors: SupunS maheeka


text:
[Debugger] Add variable evaluation feature

Purpose
This PR resembles PR https://github.com/ballerina-platform/ballerina-lang/pull/10091 with all the modifications suggested during the code review. This resolves https://github.com/ballerina-platform/ballerina-lang/issues/10090.
Added features/Modifications:

Adds variable evaluation feature to the Ballerina debugger
Prevents showing null values for global variables that are non-nullable
Allows users to evaluate variables from different packages as well (By specifying packagePath:VariableName)
New testcases to cover the above-mentioned scenarios

Addressed review comments:

Return array instead of List in 'getPackageVariables' method
Global variables of different packages need to be handled
When placing debug points in the global variable declaration lines, avoid showing null values for the global variables when evaluating them
Response message needs to include a status indicating whether the variable is found or not
Avoid passing null to the debug points in many places by overloading the 'createDebugPoint' method

Known limitations with the current version of this feature,

Issue https://github.com/ballerina-platform/ballerina-lang/issues/10433
Issue https://github.com/ballerina-platform/ballerina-lang/issues/10434

Following are the expected formats of request/response from/to client,
Expected request json format:

{ "command": "EVALUATE_EXPRESSION", "expression": <exp>, "threadId": <threadId> }

Response json format:

Successful scenario:
{ "code": "EXPRESSION_RESULTS", "message": { "status": "success", "results": <value> } }

Unsuccessful scenario:
{ "code": "EXPRESSION_RESULTS", "message": { "status": "failure", "results": "cannot find variable '<varName>'" } }

Internal error scenario (When json generation fails):
{ "code": "EXPRESSION_RESULTS", "message": { "status": "failure", "results": "internal error" } }


text:
Enable Language Server Test Cases

Purpose

Enable language server test cases

Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

:exclamation: No coverage uploaded for pull request base (jballerina@7cb25a5). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             jballerina   #15910   +/-   ##
=============================================
  Coverage              ?   15.46%
  Complexity            ?     4875
=============================================
  Files                 ?     1972
  Lines                 ?    91471
  Branches              ?    12743
=============================================
  Hits                  ?    14142
  Misses                ?    74988
  Partials              ?     2341

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb25a5...d2ceb42. Read the comment docs.

authors: codecov-io nadeeshaan


text:
Fix breakpoints being skipped during the ballerina debug process

Purpose
Fixes #19981.
Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[x] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #20087 into ballerina-1.0.x will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.0.x   #20087   +/-   ##
================================================
  Coverage            20.51%   20.51%
================================================
  Files                   52       52
  Lines                 1394     1394
  Branches               216      216
================================================
  Hits                   286      286
  Misses                1095     1095
  Partials                13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b671c7f...695aaf2. Read the comment docs.

Can we write a test for debugging stuff so it will not break next time?

@NipunaRanasinghe @kaviththiranga we might have to repeat changes done to RunCommand, TestCommand as well.

@pahans yeah you are right.. will incorporate the required changes.

@pahans test command implementation has not been changed and it still used the class-loading approach instead of running an executable jar. I tried for test command and it works fine :)

authors: NipunaRanasinghe codecov-io pahans warunalakshitha


text:
Enable Signature Help Feature

Purpose

Enable Signature Help Feature

Fixes #19728 #18910 #19727
Related PRs
https://github.com/ballerina-platform/ballerina-lang/pull/20522
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #20524 into ballerina-1.1.x will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.1.x   #20524   +/-   ##
================================================
  Coverage            15.21%   15.21%
================================================
  Files                   50       50
  Lines                 1341     1341
  Branches               208      208
================================================
  Hits                   204      204
  Misses                1121     1121
  Partials                16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 580f6ac...89a10b4. Read the comment docs.

authors: codecov-io rasika


text:
Add unit tests for FHIR r4 utils package.

Purpose

This PR includes the unit tests for r4 utils package

Approach

Unit Test cases are added for FHIRPath Processor and Patient Matching utils packages.

Added Via Spererate PRs.
Patient Matching : https://github.com/ballerina-platform/module-ballerinax-health.fhir.r4/pull/132
FhirPath: https://github.com/ballerina-platform/module-ballerinax-health.fhir.r4/pull/128


text:
Null reference error when RHS json is evaluated to null

Sample code
json j = {"a":""}; var x, err = j.b;
In above, a null reference error shoudln't occur, rather the expression should be evaulted as a type cast error.

Fixed in v0.93.1

authors: SupunS erandidesilva

repo: ballerinalang/ballerina


text:
Some HTTP response status messages are not returned to the user

When 405 status code is returned, Method Not Allowed error is displayed to the user as shown below.

But, these are not shown for every status code. For example, 415 Unsupported Media Type

"Unsupported media type" is something that will have to come with MIME support right?


text:
HTTP & WebSocket Constant Grouping

This PR creates constants groups from possible constants for readability and easy maintenance.

Closed this PR. Please resend if this is still valid

authors: irunika sameera-jayasoma


text:
Parse create table statement error

Got an error while parsing a create statement:
CREATE TABLE T (
    id int(4)
);

Parsing sql 'CREATE TABLE T (
        id int(4)
    );'...
Error: sql parser error: Expected ',' or ')' after column definition, found: (

But the sql can be successfully executed on MySQL.

Thanks for creating the issue. The parser doesn't support the int(4) part yet.

authors: Dandandan Thearas

repo: ballista-compute/sqlparser-rs


text:
[bal-button] Implement correct touchstates for all buttons

Default State
Pressed State
Selected State
https://user-images.githubusercontent.com/62377419/189100818-fef74088-4d1f-4176-a28d-aab3dd4d3aaa.mp4
https://user-images.githubusercontent.com/62377419/189157972-3dd01d31-26de-428e-bf7c-4d5da94e77bb.mp4
Focus state appears before pressed state

@clastzoo will create a ticket for radios and checkboxes. Rest will be tackled after Go-Live.

moved to https://github.com/baloise/design-system/issues/720

repo: baloise-incubator/design-system


text:
docs: remove pipes module from instructions where it has not been ins…

The Pipes Module has not been installed at this point.
It has a separate section in the docs, so no need to import it here I think.

:rocket: Welcome to Baloise ChatOps based GitOps Bot :tada:
- If you want to enable preview environments for this PullRequest, comment with `/preview`.
- If you want to disable the preview environment for this PR, comment with `/undeploy`.
- If you need help or want to see the docs, comment with `/help`.

Make sure to refresh this page after submitting a command.
Preview environments can be redeployed automatically if you enable the webhook for updates to the source branch. :new:

Have fun building awesome apps! :hammer:  :whale2:  :truck:  :ship:

authors: incubator-tekton yannickholzenkamp

repo: baloise/design-system


text:
Crash when using Koin 3.5.0

When using Koin 3.5.0, the app crashes when starts
It can be recreated on the Demo app adding implementation("io.insert-koin:koin-android:3.5.0") to the build.gradle file
FATAL EXCEPTION: main
Process: com.bambuser.liveshopping.player, PID: 5965
java.lang.RuntimeException: Unable to get provider androidx.startup.InitializationProvider: androidx.startup.StartupException: java.lang.NoSuchMethodError: No static method koinApplication(Lkotlin/jvm/functions/Function1;)Lorg/koin/core/KoinApplication; in class Lorg/koin/dsl/KoinApplicationKt; or its super classes (declaration of 'org.koin.dsl.KoinApplicationKt' appears in /data/app/~~-SNoHTZqxKMy1y68F84T-Q==/com.bambuser.liveshopping.player-RpAaaBuIR4QUNwtjAprVwA==/base.apk!classes7.dex)
	at android.app.ActivityThread.installProvider(ActivityThread.java:7427)
	at android.app.ActivityThread.installContentProviders(ActivityThread.java:6939)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6710)
	at android.app.ActivityThread.access$1500(ActivityThread.java:247)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2053)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7839)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
Caused by: androidx.startup.StartupException: java.lang.NoSuchMethodError: No static method koinApplication(Lkotlin/jvm/functions/Function1;)Lorg/koin/core/KoinApplication; in class Lorg/koin/dsl/KoinApplicationKt; or its super classes (declaration of 'org.koin.dsl.KoinApplicationKt' appears in /data/app/~~-SNoHTZqxKMy1y68F84T-Q==/com.bambuser.liveshopping.player-RpAaaBuIR4QUNwtjAprVwA==/base.apk!classes7.dex)
	at androidx.startup.AppInitializer.doInitialize(AppInitializer.java:187)
	at androidx.startup.AppInitializer.discoverAndInitialize(AppInitializer.java:238)
	at androidx.startup.AppInitializer.discoverAndInitialize(AppInitializer.java:206)
	at androidx.startup.InitializationProvider.onCreate(InitializationProvider.java:45)
	at android.content.ContentProvider.attachInfo(ContentProvider.java:2404)
	at android.content.ContentProvider.attachInfo(ContentProvider.java:2374)
	at android.app.ActivityThread.installProvider(ActivityThread.java:7422)
	at android.app.ActivityThread.installContentProviders(ActivityThread.java:6939)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6710)
	at android.app.ActivityThread.access$1500(ActivityThread.java:247)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2053)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7839)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
Caused by: java.lang.NoSuchMethodError: No static method koinApplication(Lkotlin/jvm/functions/Function1;)Lorg/koin/core/KoinApplication; in class Lorg/koin/dsl/KoinApplicationKt; or its super classes (declaration of 'org.koin.dsl.KoinApplicationKt' appears in /data/app/~~-SNoHTZqxKMy1y68F84T-Q==/com.bambuser.liveshopping.player-RpAaaBuIR4QUNwtjAprVwA==/base.apk!classes7.dex)
	at com.bambuser.player.LVSPlayerActivityInitializer.create(SourceFile:25)
	at androidx.startup.AppInitializer.doInitialize(AppInitializer.java:180)
	at androidx.startup.AppInitializer.discoverAndInitialize(AppInitializer.java:238)
	at androidx.startup.AppInitializer.discoverAndInitialize(AppInitializer.java:206)
	at androidx.startup.InitializationProvider.onCreate(InitializationProvider.java:45)
	at android.content.ContentProvider.attachInfo(ContentProvider.java:2404)
	at android.content.ContentProvider.attachInfo(ContentProvider.java:2374)
	at android.app.ActivityThread.installProvider(ActivityThread.java:7422)
	at android.app.ActivityThread.installContentProviders(ActivityThread.java:6939)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6710)
	at android.app.ActivityThread.access$1500(ActivityThread.java:247)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2053)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7839)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

The SDK is currently using an older version of Koin which is causing this issue, we will bump the version in an upcoming release.
If you need an urgent fix for this you could temporarily lower your version, implementation("io.insert-koin:koin-android:3.4.3") works in the demo app.

authors: JennyBambuser SergioPoq

repo: bambuser/BambuserPlayerSDK-Android


text:
エアコンの温度変更で困ったことがあります。

Homebridge MQTT-Thingを通じてAppleHomekit上で温度のみ変更する際はログの通り[ECHONETLite] prop changedとなり正常に反映されるのですが
Homebridge Log
[16:14:53] [エアコン] Publishing MQTT: echonetlite2mqtt/elapi/v2/devices/fe00000/properties/targetTemperature/set = 20
[16:14:54] [エアコン] Received MQTT: echonetlite2mqtt/elapi/v2/devices/fe00000/properties/targetTemperature = 20
[16:14:54] [エアコン] Received MQTT: echonetlite2mqtt/elapi/v2/devices/fe00000/properties/targetTemperature = 20
Echonetlite2mqtt Log
16:14:54 | [ECHONETLite] prop changed: エアコン targetTemperature 20
16:14:53 | [MQTT] prop changed: エアコン targetTemperature 20
Homekitのオートメーションで温度を変更する際にはoperationStatus  operationMode targetTemperatureの3つがpublishされる仕様のようで、targetTemperatureがReceiveされず温度変更が反映されません。Homebridge MQTT-Thingの設定をいろいろといじっては見たもののこれと言って挙動が変化するものはありませんでした。何か対策があればよろしくお願いいたします。
Homebridge Log
[16:13:28] [エアコン] Publishing MQTT: echonetlite2mqtt/elapi/v2/devices/fe00000/properties/operationStatus/set = true
[16:13:28] [エアコン] Publishing MQTT: echonetlite2mqtt/elapi/v2/devices/fe00000/properties/operationMode/set = heating
[16:13:28] [エアコン] Publishing MQTT: echonetlite2mqtt/elapi/v2/devices/fe00000/properties/targetTemperature/set = 20
[16:13:30] [エアコン] Received MQTT: echonetlite2mqtt/elapi/v2/devices/fe00000/properties/operationMode = heating
Echonetlite2mqtt Log
16:13:28 | [MQTT] prop changed: エアコン targetTemperature 20
16:13:28 | [MQTT] prop changed: エアコン operationMode heating
16:13:28 | [MQTT] prop changed: エアコン operationStatus true
環境はPanasonic CF-TC7B + CF-TA9です。なお、アダプターのないダイキンエアコンでも同様でした。少し違いところがあるとすればダイキンのほうはたまにRecieveされる点でです。よろしくお願いいたします。

@grandevice さん
報告ありがとうございます。
Homebridge は使ってないので、この挙動は初めて知りました。
おそらくですが、3つのプロパティがほぼ同時に更新されることが要因のようですね。
考えられる可能性は、以下あたりでしょうか。

(1) ECHONETLite2MQTTからコマンドをエアコンに一度に送っているため、エアコンがコマンドを受信できていない
(2) エアコンはコマンドを受信できているが、ECHONETLite2MQTTがそのコマンドの結果を受信できていない (コマンドの結果の受信と次の命令の送信が同時期になってしまっている)
(3) ECHONETLite2MQTTのコマンド送信に問題があって、連続してコマンドを送れていない (未調査なんですが、送信時のTransaction Idが正しくないという情報をどこかで見かけました)

残念ながら、どれも現状では対応できていません。
Homebridge は無いのですが、ダイキンのエアコンはあるので、連続してコマンドを送った場合の挙動を調べてみます。
少なくとも(1)と(2)に関しては、コマンド送信後に次のコマンド送信まで待つような仕組みを導入すれば、実現できると考えています。

@banban525さん
コメントありがとうございます。
いろいろいじりすぎて何が効いてるのかわからなくなっていますが、Homebridge MQTT-Thingの
RetainとOptimise Publishingを、enableにしても期待した動作が得られていませんでしたがLogを見るとKeepaliveがdefaultで0かと思っていたら10secとなっていました。（設定で0と表示されていたので気づきませんでした。
）0に設定すると上記2つが動作しているのかoperationStatus:trueとoperation Mode:heatingが通知されなくなり変更されたtargetTemperature:のみ通知されるようになりました。提示していただいた根本的問題は解決されていないとは思いますが回避はできたように感じます。たまたまtargetTemperatureを最初に受け取ってるだけかもしれませんが、最後の人が外出したらエアコンの温度を下げる、帰宅したら上げるという動作は完了するようになりました。今のところメディアコンバータ、アダプタ経由のエオリアとwifiアダプタ内蔵のダイキンエアコンともに動作しています。なおmosquittoのconfigもこの間に多少の書き換えを行ったので時間のある時に設定を詰めてみる予定です。

@grandevice さん
現状、回避できたとのことで、よかったです。
ただ、プロパティを同時に変更すると危なそうなのは確かなので、
その挙動だけは確認して、可能なら対策を入れておこうと思います。
なお、もしかすると再現しないかもしれませんが、その場合は対処無しで本件はCloseさせていただきます。

@banban525さん
帰宅時も無事に動作しているようです。Panasonic CF-TC7B + CF-TA9 + Eoliaの時にReceivedが2回出るのがよくわかりませんが以下の通り　Eoliaは20→22℃　Daikinは18→20℃へ変更されました。以前はHomikit 上で変更できている様に表示されますが実際には変更されていませんでした。なお、EoliaとDaikinの動作に5秒の遅延を入れています。
Echonetlite2MQTT
[18:54:41] [Eolia] Publishing MQTT: echonetlite2mqtt/elapi/v2/devices/fe00000/properties/targetTemperature/set = 22
[18:54:42] [Eolia] Received MQTT: echonetlite2mqtt/elapi/v2/devices/fe00000/properties/targetTemperature = 22
[18:54:43] [Eolia] Received MQTT: echonetlite2mqtt/elapi/v2/devices/fe00000/properties/targetTemperature = 22
[18:54:46] [Daikin] Publishing MQTT: echonetlite2mqtt/elapi/v2/devices/fe00000/properties/targetTemperature/set = 20
[18:54:46] [Daikin] Received MQTT: echonetlite2mqtt/elapi/v2/devices/fe00000/properties/targetTemperature = 20
Homebridge
18:54:46 | [ECHONETLite] prop changed: Daikin targetTemperature 20
18:54:46 | [MQTT] prop changed: Daikin targetTemperature 20
18:54:42 | [ECHONETLite] prop changed: Eolia targetTemperature 22
18:54:41 | [MQTT] prop changed: Eolia targetTemperature 22
mosquitto.confで変更したのは以下の通りです。
max_topic_alias 65535
max_inflight_messages 0
max_queued_messages 0
queue_qos0_messages true

@grandevice さん
連続して変更コマンドを送った場合に、正常に反映されない問題が再現できました。
ダイキンのエアコン AN-22YRS-W で確認しています。
2つまでなら反映されるようですが、3つになると最後のプロパティ変更が反映されません。
(なお10回1回くらいは3つとも反映されます)
以前挙げた仮設の中では(1)に該当すると思います。

(1) ECHONETLite2MQTTからコマンドをエアコンに一度に送っているため、エアコンがコマンドを受信できていない

なお、連続していくつまで受信できるかは、受信側のデバイスの実装次第またはタイミング次第と思われます。
想像ですが、ダイキンのエアコンは受信バッファが2つなのかもしれません。
いずれにしても、ECHONETLite2MQTTが連続してコマンドを送っていることが問題で、
コマンドを送った後はデバイス側の受信を確認して次のコマンドを送るようにしないといけないようです。
ただ、修正は割と大変そうなので、修正には少々お時間をいただくと思います。

反応が遅くて申し訳ありません。
その通りのレスポンスでした。
operationStatus,operationMode, targetTemperatureの順で受け取った場合
ダイキンはtagetTemperatureが受け取れませんでした。パナソニック+メディアコンバータはoperationMode, targetTemperatureご受け取れませんでした。
なのでoperationStatus,operationMode, targetTemperatureをあらかじめpublishしておきMqttThingのoptimize publishingにて変更したいtargetTemperatureのみ受け取るといったことで対処しています。
全く急いでおりませんのでお手隙の時にでも修正をお願いできたらと思います。
本当に風呂沸かしと玄関ドアのコントロールができているだけで大満足です。

@grandevice
ずいぶん前の課題ですが、対応しましたので連絡します。
本当は、コマンド送信廻りを根本的に見直すつもりでしたが、 v2.2.0 でコマンドの同時送信が必要になったので
間に合わせの対応を行いました。
この問題も、解決しているようでした。
Dockerを使っているなら、 v2.2.0以降のタグか、latestタグ、materタグを使ってください。
node.jsで実行しているなら、最新のmasterブランチをcloneしてください。
このIssueはCloseさせてもらいます。


text:
横屏预览图片时错位

提bug前必看
请先回答下列三个问题，否则不允处理，谢谢配合。
1、我最新的Demo是否有这个bug？【如果Demo没问题，请升级新版】
答：有
2、你用的是什么版本？升级到最新版后是否正常？
答：最新版本
3、是否有改动过我库内部的代码？【如有，请告诉我你改了什么】
答：没有
bug内容描述
横屏时预览图片出现错位，底部黑色间隔
我如何复现这个bug？
截图

其它说明
有没有其它要补充的？比如你的初始化TZImagePickerController的代码

你是故意滑到这个位置的？

authors: Mayinwei banchichen

repo: banchichen/TZImagePickerController


text:
语言国际化

我的项目已经做了语言国际化了，选择头像调整到相册是中文，但是使用你的这个工具栏跳转到相册却是英文的，要怎么设置切花，谢谢。

你好，请看这个issue https://github.com/banchichen/TZImagePickerController/issues/226#issuecomment-249209039


text:
Decomission stale View layer properties

There are several properties on ViewReserve on ViewRelay which would be good if we can decomission.
ViewReserve
Can we remove balance and reserveWeight
Using tokenBalance getter in favour
ViewRelay
name

Also removed can be the following Components: @ashachaf please confirm that they are indeed decomissioned and not planning a comeback.

[ ] AddProtectionDouble
[ ] WithdrawProtectionDouble

@ashachaf can discuss this one in a meeting either tonight or tomorrow.

we do not have plans on bringing back the option to:

[ ] AddProtectionDouble - where a user can stake pool tokens into protection
[ ] WithdrawProtectionDouble - where a user can withdraw 2 separate protected positions together.
you can remove.

authors: Velua ashachaf pingustar

repo: bancorprotocol/webapp


text:
Adding submodule for SAMBA

I have linked SAMBA to my fork of this repo using the guidelines from Dan. Everyone should be able to use this to get to my repo once this is merged; SAMBA is now public.

I do not understand why github is putting all of those other commits here as well, when I only requested the submodule from a fork that is not related to any of the other things there, so please make sure this is right because I don't want to overwrite other files with this request.

repo: bandframework/bandframework


text:
need to mark 2.0.0 github release

👋 looks like the github release did not get completed, raised this issue for some awareness. Thanks!
relates to https://github.com/Homebrew/homebrew-core/pull/176033

Ah thanks, didn’t realize this tool had made it to homebrew. I published it without setting it to latest because I wanted to test it first. Is anything breaking imminently on homebrew side or can it wait a few more days?

@banga thanks for pushing to a new release, but it would be also good to mark 2.0.1 release as latest release :)

anyway, we have shipped 2.0.1 on the homebrew side, 💯

repo: banga/git-split-diffs


text:
新前后端的第一方登录功能
前端会使用 hCaptcha 作为验证码

有一说一, 我觉得hCaptcha这种东西比直接打个验证码更浪费时间, 使用户厌恶

有一说一, 我觉得hCaptcha这种东西比直接打个验证码更浪费时间, 使用户厌恶

hCaptcha 确实不好用....
可以用 reCAPTCHA + 可以 fallback 到普通验证码的方案，不过工作量会大一点（

session 失效条件会宽松一点

主要原因是hcaptcha用起来太方便了，后端拿到前端输入之后发个HTTP请求就行了。我懒得弄个验证码服务了。

最近看到 Cloudflare 推出了 Turnstile，看了一眼 example，验证方法应该差不多，但体验要好太多了（hcaptcha 要选的东西已经开始疯魔了），或许可以试试？

repo: bangumi/dev-docs


text:
Add documentation for custom template functions

Signed-off-by: patoarvizu patoarvizu@gmail.com

Q
A

Bug fix?
no

New feature?
yes

API breaks?
no

Deprecations?
no

Related tickets
Documentation for https://github.com/banzaicloud/bank-vaults/pull/953

License
Apache 2.0

What's in this PR?
Documentation for the templating functionalities of Vault configuration, plus the custom functions added here.
Why?
The availability of Sprig functions wasn't well documented, so I'm adding it here plus the new custom functions that were added
Checklist

[x] User guide and development docs updated (if needed)

@bonifaido Here's the promised documentation. The markdown looks right, but is there a way to preview the website layout?

repo: banzaicloud/bank-vaults-docs


text:
Minor: Duplicate additional_data method

https://github.com/baoagency/polaris-view-components/blob/40df8cbaa278574a33730bf5b827c9b171948c2c/app/components/application_component.rb#L22
Method is repeated twice in ApplicationComponent 😉
This repo is 🔥🔥🔥 Well done!

Thanks Björn 😊
There's an additional_data and additional_aria. I think you may have misread them 🤓
Hoping to do some more additions to this over the weekend. If you are interested in using but feeling like you can't because of some missing components then give me a shout!

I’m an idiot, even double checked! 🤷♂ We’ve got our own internal repo going which is similar but I love how you’ve gone all in on doing things 1-1 vs Shopify. Should have just waited a few months and used yours 😅

Ha!
My goal is to effectively replicate Polaris. I doubt I'll be able to do it 100% but will definitely get all of the main components and most of everything else. I Will likely just miss the very low-used ones.
Things like Dropzone and Popover are really hard to replicate serverside but I'm happy with how the Dropzone turned out!

authors: dan-gamble forsbergplustwo

repo: baoagency/polaris-view-components


text:
nrows and chunking

Hi guys,
This PR should be merged after the circle-ci one. The purpose of this PR is to be able to handle files that pandas cannot read into memory all at once, because they are too big. Issue #24 is logged to track the work.
Summary of updates:

added nrows option to command line. If you just want see the first 100 rows try: scroll --nrows=100 titanic.csv

added chunksize to command line. If you want to chunk a big file and see 100 rows at a time try: scroll --chunksize=100 titanic.csv. To see the next chunk, just press "n"

These are of course trivial examples. To test with a big file, try downloading http://sdm.lbl.gov/fastbit/data/star2002-full.csv.gz.
Limitations:

Have not added "goto next chunk" to the help screen. Might need @johncmerfeld to assist with that

When the last chunk is reached, we just stay there. Wondering if you guys think we should go back to the top?

From a coding POV, I added a reader attribute to the DFWindow class and an optional reader argument to the key_press_and_print_df function. Have a look and let me know what you think!

Haven't checked out the full chunking capability yet, but added its key command to the help box. Also removed the constant values from scroller.py so now, whenever we modify the help_screen.py file, the box will size itself according to how many items there are on the help menu.

@johncmerfeld good commit but shouldn't next chunk be listed before exit scroller?

@johncmerfeld @baogorek this one is ready for approval

authors: johncmerfeld kjmerf

repo: baogorek/datascroller


text:
代码生成器优化意见

当前使用版本(必须填写清楚，否则不予处理)
mybatis plus: 3.1.1
该问题是怎么引起的？(最新版上已修复的会直接close掉)
目前代码生成器的生成策略只有两种，一种是直接覆盖原文件，一种是什么文件都不生成，建议代码生成器在FileOverride配置为false的情况下，也生成相关的文件，并以特定的后缀结尾，以便在扩展字段时，对源文件进行修改，类似mybatis的代码生成器逻辑。
同时请问一下，在不修改mybatis plus generator源代码的情况下，如何扩展实现上述功能，翻了所有的API没有找到可以扩展的地方。
重现步骤
报错信息

这个是个性需求无法给予支持，不过你可以利用自定义 FileOutConfig 重写默认模板输出方式 https://mp.baomidou.com/guide/generator.html

authors: qmdx wanghongshuang

repo: baomidou/mybatis-plus

license_source: bigquery


text:
集成Oracle，sql不符合oracle规范

当前使用版本(必填,否则不予处理)
3.3.1
该问题是如何引起的？(确定最新版也有问题再提!!!)
希望集成oracle，mybatis-plus自动生成的sql不符合oracle规范，报错
重现步骤(如果有就写完整)
将mysql-connector-java替换为ojdbc8
报错信息
org.springframework.jdbc.BadSqlGrammarException:
Error querying database.  Cause: java.sql.SQLSyntaxErrorException: ORA-00911: 无效字符
The error may exist in com/masa/system/mapper/SysRouteConfMapper.java (best guess)
The error may involve defaultParameterMap
The error occurred while setting parameters
SQL: SELECT id, route_id, route_name, predicates, filters, uri, order, create_time, update_time, del_flag FROM sys_route_conf WHERE del_flag = '0'
Cause: java.sql.SQLSyntaxErrorException: ORA-00911: 无效字符
; bad SQL grammar []; nested exception is java.sql.SQLSyntaxErrorException: ORA-00911: 无效字符
at org.springframework.jdbc.support.SQLExceptionSubclassTranslator.doTranslate(SQLExceptionSubclassTranslator.java:93)
at org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate(AbstractFallbackSQLExceptionTranslator.java:72)
at org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate(AbstractFallbackSQLExceptionTranslator.java:81)
at org.mybatis.spring.MyBatisExceptionTranslator.translateExceptionIfPossible(MyBatisExceptionTranslator.java:88)

全局配置 GlobalConfig 自己看

GlobalConfig的dbType被干掉了，我不知道现在应当配置什么属性
public class GlobalConfig implements Serializable {

    /**
     * 是否开启 LOGO
     */
    private boolean banner = true;
    /**
     * 机器 ID 部分
     *
     * @see #setIdentifierGenerator(IdentifierGenerator)
     * @deprecated 3.3.0
     */
    @Deprecated
    private Long workerId;
    /**
     * 数据标识 ID 部分
     *
     * @see #setIdentifierGenerator(IdentifierGenerator)
     * @deprecated 3.3.0
     */
    @Deprecated
    private Long datacenterId;
    /**
     * 是否初始化 SqlRunner
     */
    private boolean enableSqlRunner = false;
    /**
     * 数据库相关配置
     */
    private DbConfig dbConfig;
    /**
     * SQL注入器
     */
    private ISqlInjector sqlInjector = new DefaultSqlInjector();
    /**
     * Mapper父类
     */
    private Class<?> superMapperClass = Mapper.class;
    /**
     * SqlSessionFactory
     */
    private SqlSessionFactory sqlSessionFactory;
    /**
     * 缓存已注入CRUD的Mapper信息
     */
    private Set<String> mapperRegistryCache = new ConcurrentSkipListSet<>();
    /**
     * 元对象字段填充控制器
     */
    private MetaObjectHandler metaObjectHandler;
    /**
     * 主键生成器
     */
    private IdentifierGenerator identifierGenerator;

    @Data
    public static class DbConfig {
        /**
         * 主键类型
         */
        private IdType idType = IdType.ASSIGN_ID;
        /**
         * 表名前缀
         */
        private String tablePrefix;
        /**
         * schema
         *
         * @since 3.1.1
         */
        private String schema;
        /**
         * db字段 format
         * <li> 例: `%s` </li>
         * <p> 对主键无效 </p>
         *
         * @since 3.1.1
         */
        private String columnFormat;
        /**
         * entity字段 format,
         * 只有在 column as property 这种情况下生效
         * <li> 例: `%s` </li>
         * <p> 对主键无效 </p>
         *
         * @since 3.3.0
         */
        private String propertyFormat;
        /**
         * 表名、是否使用下划线命名（默认 true:默认数据库表下划线命名）
         */
        private boolean tableUnderline = true;
        /**
         * 大写命名
         */
        private boolean capitalMode = false;
        /**
         * 表主键生成器
         */
        private IKeyGenerator keyGenerator;
        /**
         * 逻辑删除全局字段 (默认无 设置会自动扫描实体字段)
         */
        private String logicDeleteField;
        /**
         * 逻辑删除全局值（默认 1、表示已删除）
         */
        private String logicDeleteValue = "1";
        /**
         * 逻辑未删除全局值（默认 0、表示未删除）
         */
        private String logicNotDeleteValue = "0";
        /**
         * 字段验证策略之 insert
         *
         * @since 3.1.2
         */
        private FieldStrategy insertStrategy = FieldStrategy.NOT_NULL;
        /**
         * 字段验证策略之 update
         *
         * @since 3.1.2
         */
        private FieldStrategy updateStrategy = FieldStrategy.NOT_NULL;
        /**
         * 字段验证策略之 select
         *
         * @since 3.1.2
         */
        private FieldStrategy selectStrategy = FieldStrategy.NOT_NULL;
    }
}

capitalMode=true

解决了，多谢

还有个问题，配置mybatis-plus.global-config.db-config.capitalMode=true，导致@TableField不生效，这个有解决办法吗

    @TableField(value ="ROUTE_ORDER")
private Integer order;

实际打印出来变成
ROUTE_ORDER AS order

你这种不符合映射规则只能 as, 不想 as就

order 改成 routOrder
在 3.3.3.4-SNAPSHOT 版本下自己写resultmap用或者@TableName注解.autoResultMap = true

autoResultMap = true
这个配置暂时解决了我的问题

authors: blessing-gao miemieYaho


text:
saveOrupdate 保存 主键空 报错

当前使用版本(必填,否则不予处理)
3.3.1
该问题是如何引起的？(确定最新版也有问题再提!!!)
saveorupdate 问题
查询之后，再insert没有把原先的主键带过去。。。导致主键空报错，update没试过。我的主键没有设置填充类型
重现步骤(如果有就写完整)
查询之后，再保存没有把原先的主键带过去。。。导致主键空报错。我的主键没有设置填充类型

主键没有设置填充类型就不会自动填充，没有主键就插入很明显会报错。

主键没有设置填充类型就不会自动填充，没有主键就插入很明显会报错。

嗯嗯，这个逻辑理解，这个是最简单的保存时候的逻辑，但是saveOrUpdate就不一样了。
我觉得可以优化一下，既然查询那一步的是有主键的，那我填充进去的也就是要保存进去的主键。可以在save和update的时候填充自查询那边的主键

我这边的修改方案是在id上面设置 input。但是如果本来id需要数据库自增的时候就崩了。还是建议作者可以优化一下


text:
开启租户插件，框架提供的增删查改，想要在里面忽略租户拼接，怎么做

当前使用版本(必填,否则不予处理)
该问题是如何引起的？(确定最新版也有问题再提!!!)
重现步骤(如果有就写完整)
报错信息

文档见：https://baomidou.com/pages/aef2f2/#tenantlineinnerinterceptor
可以在Mapper上加@InterceptorIgnore去忽略
ignoreTable方法也是每次都会执行判断，可基于这一点实现更灵活的方案

authors: VampireAchao lzy-git


text:
[Pending Popularity] Fork GitHub linguist to add RPGLE

After prettying up the grammars a bit, fork the GitHub linguist and include RPG+RPGLE grammars.
Usage:

https://github.com/search?q=extension%3Arpgle+extension%3Asqlrpgle+extension%3Arpg+extension%3Asqlrpg+extension%3Arpgle+extension%3Asqlrpgle+extension%3Arpg+extension%3Asqlrpg+extension%3ARPGLE+extension%3ASQLRPGLE+extension%3ARPG+extension%3ASQLRPG&type=Code&ref=advsearch&l=&l=

Decided to only do RPGLE since RPG understandably does not have enough presence. PR for GitHub linguist at https://github.com/github/linguist/pull/5240

Update:
I attempted to build a cron job to gather all unique repos, but the GitHub API v4 (GraphQL) does not have code searching and the GitHub API v3 (REST) would not allow this behavior.
The problem being that when searching for code the only sortable field is "code index date". Specifically "Only repositories that have had activity or have been returned in search results in the last year are searchable." from https://docs.github.com/en/github/searching-for-information-on-github/searching-code
So only files with a certain extension active in the last year would be able to be found...This is the same issue that also rules out making a web scraper with Python + BeautifulSoup. Probably just have to wait this one out

Officially merged - https://github.com/github/linguist/commit/bbfc3434ec5c7db838e42bc01e07624f8737e202

repo: barrettotte/vscode-ibmi-languages


text:
Cant install using composer

Versions:

ide-helper Version: ^2.9
Laravel Version:  8.20.1
PHP Version: 7.4

Description:
I encountered an error when trying to install.
$ composer require barryvdh/laravel-ide-helper --dev
    1/1:        http://repo.packagist.org/p/provider-latest$461ec9d15c3f83b5283a8af4681986c7582bb5f70a242c7ea4e059c6c0dc3d6b.json
    Finished: success: 1, skipped: 0, failure: 0, total: 1
Using version ^2.9 for barryvdh/laravel-ide-helper
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 16 installs, 0 updates, 0 removals
  - Installing composer/package-versions-deprecated (1.11.99.1): Loading from cache
Plugin installation failed (include(/home/vagrant/Code/_play/volopts.lan/vendor/composer/package-versions-deprecated/src/PackageVersions/Installer.php): failed to open stream: No such file or directory), rolling back
  - Removing composer/package-versions-deprecated (1.11.99.1)

Installation failed, reverting ./composer.json to its original content.

  [RuntimeException]
  Could not delete /home/vagrant/Code/_play/volopts.lan/vendor/composer/package-versions-deprecated/src/PackageVersions:

@TerrePorter this seems quite a local issue at first sight. Can you reproduce the bug? Given the error mentions a path including Vagrant it might help to check the vagrant box and file permissions.

@TerrePorter this seems quite a local issue at first sight. Can you reproduce the bug? Given the error mentions a path including Vagrant it might help to check the vagrant box and file permissions.

@DannyvdSluijs I guess it was something with the composer cache, because i was able to get it to install in a roundabout way.
I got the same error when trying to install the composer package directly.
$ composer require composer/package-versions-deprecated --dev
    1/1:        http://repo.packagist.org/p/provider-latest$ee91fdc5d78ccdee56e6da3b20491108d448e5ac53c778d37273e3bb43286a99.json
    Finished: success: 1, skipped: 0, failure: 0, total: 1
Using version 1.11.99.1 for composer/package-versions-deprecated
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 16 installs, 0 updates, 0 removals
  - Installing composer/package-versions-deprecated (1.11.99.1): Loading from cache
Plugin installation failed (include(/home/vagrant/Code/_play/volopts.lan/vendor/composer/package-versions-deprecated/src/PackageVersions/Installer.php): failed to open stream: No such file or directory), rolling back
  - Removing composer/package-versions-deprecated (1.11.99.1)

Installation failed, reverting ./composer.json to its original content.

  [ErrorException]
  include(/home/vagrant/Code/_play/volopts.lan/vendor/composer/package-versions-deprecated/src/PackageVersions/Installer.php): failed to open stream: No such file or directory

But i got it to work when i added --prefer-source and it installed the ide-helper package too.
$ composer require composer/package-versions-deprecated --dev --prefer-source
Using version 1.11.99.1 for composer/package-versions-deprecated
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 16 installs, 0 updates, 0 removals
  - Installing composer/package-versions-deprecated (1.11.99.1): Cloning 7413f0b55a from cache
  - Installing doctrine/event-manager (1.1.1): Cloning 41370af6a3 from cache
  - Installing doctrine/cache (1.10.2): Cloning 13e3381b25 from cache
  - Installing doctrine/dbal (3.0.0): Cloning ee6d1260d5 from cache
  - Installing react/promise (v2.8.0): Cloning f3cff96a19 from cache
  - Installing symfony/filesystem (v5.2.1): Cloning fa8f8cab6b from cache
  - Installing seld/phar-utils (1.1.1): Cloning 8674b1d84f from cache
  - Installing seld/jsonlint (1.8.3): Cloning 9ad6ce79c3 from cache
  - Installing justinrainbow/json-schema (5.2.10): Cloning 2ba9c8c862 from cache
  - Installing composer/xdebug-handler (1.4.5): Cloning f28d44c286 from cache
  - Installing composer/spdx-licenses (1.5.5): Cloning de30328a7a from cache
  - Installing composer/semver (3.2.4): Cloning a02fdf930a from cache
  - Installing composer/ca-bundle (1.2.8): Cloning 8a7ecad675 from cache
  - Installing composer/composer (2.0.8): Cloning 62139b2806 from cache
  - Installing barryvdh/reflection-docblock (v2.0.6): Cloning 6b69015d83 from cache
  - Installing barryvdh/laravel-ide-helper (v2.9.0): Cloning 64a6b90258 from cache
doctrine/cache suggests installing alcaeus/mongo-php-adapter (Required to use legacy MongoDB driver)
barryvdh/reflection-docblock suggests installing dflydev/markdown (~1.0)
barryvdh/reflection-docblock suggests installing erusev/parsedown (~1.0)
Writing lock file
Generating optimized autoload files
composer/package-versions-deprecated: Generating version class...
composer/package-versions-deprecated: ...done generating version class
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi
Discovered Package: barryvdh/laravel-ide-helper
Discovered Package: facade/ignition
Discovered Package: fideloper/proxy
Discovered Package: fruitcake/laravel-cors
Discovered Package: jeroennoten/laravel-adminlte
Discovered Package: laravel/sail
Discovered Package: laravel/tinker
Discovered Package: laravel/ui
Discovered Package: nesbot/carbon
Discovered Package: nunomaduro/collision
Discovered Package: spatie/laravel-permission
Package manifest generated successfully.
86 packages you are using are looking for funding.
Use the `composer fund` command to find out more!

@DannyvdSluijs I guess it was something with the composer cache, because i was able to get it to install in a roundabout way.
I got the same error when trying to install the composer package directly.
$ composer require composer/package-versions-deprecated --dev
    1/1:        http://repo.packagist.org/p/provider-latest$ee91fdc5d78ccdee56e6da3b20491108d448e5ac53c778d37273e3bb43286a99.json
    Finished: success: 1, skipped: 0, failure: 0, total: 1
Using version 1.11.99.1 for composer/package-versions-deprecated
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 16 installs, 0 updates, 0 removals
  - Installing composer/package-versions-deprecated (1.11.99.1): Loading from cache
Plugin installation failed (include(/home/vagrant/Code/_play/volopts.lan/vendor/composer/package-versions-deprecated/src/PackageVersions/Installer.php): failed to open stream: No such file or directory), rolling back
  - Removing composer/package-versions-deprecated (1.11.99.1)

Installation failed, reverting ./composer.json to its original content.

  [ErrorException]
  include(/home/vagrant/Code/_play/volopts.lan/vendor/composer/package-versions-deprecated/src/PackageVersions/Installer.php): failed to open stream: No such file or directory

But i got it to work when i added --prefer-source and it installed the ide-helper package too.
$ composer require composer/package-versions-deprecated --dev --prefer-source
Using version 1.11.99.1 for composer/package-versions-deprecated
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 16 installs, 0 updates, 0 removals
  - Installing composer/package-versions-deprecated (1.11.99.1): Cloning 7413f0b55a from cache
  - Installing doctrine/event-manager (1.1.1): Cloning 41370af6a3 from cache
  - Installing doctrine/cache (1.10.2): Cloning 13e3381b25 from cache
  - Installing doctrine/dbal (3.0.0): Cloning ee6d1260d5 from cache
  - Installing react/promise (v2.8.0): Cloning f3cff96a19 from cache
  - Installing symfony/filesystem (v5.2.1): Cloning fa8f8cab6b from cache
  - Installing seld/phar-utils (1.1.1): Cloning 8674b1d84f from cache
  - Installing seld/jsonlint (1.8.3): Cloning 9ad6ce79c3 from cache
  - Installing justinrainbow/json-schema (5.2.10): Cloning 2ba9c8c862 from cache
  - Installing composer/xdebug-handler (1.4.5): Cloning f28d44c286 from cache
  - Installing composer/spdx-licenses (1.5.5): Cloning de30328a7a from cache
  - Installing composer/semver (3.2.4): Cloning a02fdf930a from cache
  - Installing composer/ca-bundle (1.2.8): Cloning 8a7ecad675 from cache
  - Installing composer/composer (2.0.8): Cloning 62139b2806 from cache
  - Installing barryvdh/reflection-docblock (v2.0.6): Cloning 6b69015d83 from cache
  - Installing barryvdh/laravel-ide-helper (v2.9.0): Cloning 64a6b90258 from cache
doctrine/cache suggests installing alcaeus/mongo-php-adapter (Required to use legacy MongoDB driver)
barryvdh/reflection-docblock suggests installing dflydev/markdown (~1.0)
barryvdh/reflection-docblock suggests installing erusev/parsedown (~1.0)
Writing lock file
Generating optimized autoload files
composer/package-versions-deprecated: Generating version class...
composer/package-versions-deprecated: ...done generating version class
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi
Discovered Package: barryvdh/laravel-ide-helper
Discovered Package: facade/ignition
Discovered Package: fideloper/proxy
Discovered Package: fruitcake/laravel-cors
Discovered Package: jeroennoten/laravel-adminlte
Discovered Package: laravel/sail
Discovered Package: laravel/tinker
Discovered Package: laravel/ui
Discovered Package: nesbot/carbon
Discovered Package: nunomaduro/collision
Discovered Package: spatie/laravel-permission
Package manifest generated successfully.
86 packages you are using are looking for funding.
Use the `composer fund` command to find out more!

with composer install --no-plugins dont work

authors: DannyvdSluijs TerrePorter koriss

repo: barryvdh/laravel-ide-helper


text:
Multi auth guards and multi auth providers compatibility

As I had complex web apps where website (session auth driver) and API (token auth driver) live together, and also could have users which could login in more than one table (so more than one model), I felt the need for this commit. I hope you like it.
This commit is a consequence of my comment:
#43 (comment)
It could be improved making it more flexible, auto generating the interfaces and managing methods match conflicts somehow with reflection classes or functions as 'class_implements' and 'get_class_methods', so as ''Illuminate\Contracts\Auth\StatefulGuard' interface is an extension of 'Illuminate\Contracts\Auth\Guard' interface, then the method should be the origin, so 'Illuminate\Contracts\Auth\Guard'. But I don't think it worth it, as the supported auth drivers are just 'session' or 'token'.

@barryvdh , did you reviewed this PR?

@gonzalom do you still need this PR?

Hi @mfn,
Thanks for your reply.
No, I don't need it anymore. It could be good to have for others though, I made it very standard, but I let you evaluate the benefits.
Regards.

The reason I asked is that the implementation is hard to read, requires time to properly test and has zero tests (granted: back then there were almost no tests), so since OP suggested he doesn't need it I would err to drop this PR @barryvdh ; anyone can pick this up and make a new one anyway!

Yeah, you are right, my bad about the tests, and it is hard to read indeed.
And on top of it, it was designed for a Larave\Lumen version that it's outdated already.
I am working in another company now, and our app needs are different, so I am not familiar with the latest Laravel auth particularities anymore.
I guess that you can close this, and if someone needs something similar to be implemented in the future, who knows, it may be useful as a reference/inspiration.
Thanks though for your follow up, really appreciated :)
Either way, let me know if you want some help in any particular development or update, I would be happy to help.

Closing as per last comment, thank you!

authors: gonzalom mfn


text:
Traceye added to the ecosystem page

What changed? Why?
Added Traceye, in infra category and indexer subcategory to the ecosystem page.
Notes to reviewers
Kindly merge this pull request to showcase Traceye on Base's page.
How has it been tested?

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/2

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
1

Sum
2

@traceye-io
Hi there! Thanks for building on Base! Please update the landing page so that it points to a page specifically for Base users that would be coming from base.org.

authors: cb-heimdall traceye-io wbnns

repo: base-org/web


text:
Handoff key filtering (repair or ring resize handoff) does not send periodic sync messages to keep TCP connection alive

Confirmed in the lab: while doing repair handoff, the filtering done appears to prevent sending batches of handoff data to the receiver.  The receiver's default timeout is 5 minutes, but it's see-it-with-my-own-eyes possible to fold over Bitcask data at over 150MBytes per second and not have enough data to send to trigger the receiver's 5 minute idle timeout.
After the reciever has timed out, the #ho_acc record looks like this (from a stack trace from riak-admin cluster-info:
y(0)     {ho_acc,6,ok,#Fun<riak_core_repair.0.61411323>,riak_kv_vnode,<0.588.0>,#Port<0.8040>,{593735040165679310520246963290989976735222595584,616571003248974668617179538802181898917346541568},{ho_stats,{1395,157067,590863},undefined,125,128161535},gen_tcp,286632,158788528786,[<<803113 bytes>>],1,803113,25,repair,undefined,undefined}

Note that element 2, the ack number, is 6.  And it remains at 6 for minutes at a time, confirming the hypothesis that the batch isn't big enough to send yet to the remote side.
When the batch finally becomes big enough, we see that the ack number only reaches 7: only one send is required to change the element 3 from ok to either {error,closed} or {error,enotconn}, depending on the timing.
{ho_acc,7,{error,closed},#Fun<riak_core_repair.0.61411323>,riak_kv_vnode,<0.588.0>,#Port<0.8040>,{593735040165679310520246963290989976735222595584,616571003248974668617179538802181898917346541568},{ho_stats,[....]

Packet capture by tcpdump confirms that there is 5 minutes of inactivity before the receiver closes/sends FIN.

https://github.com/basho/riak_core/pull/995

authors: martinsumner slfritchie


text:
Fixed riak_test so doesn't fail on starting inets.

A couple of tests each tried to start inets, and matched on 'ok'. The second
test that started it would instead get '{error, {already_started, inets}}'
instead. Wrapping the inets starts in a function to check for the not-
really-an-error error condition resolves it.

+1 fec8b87
Fails as described before fix, passes after. Changes look fine to me for search.

authors: aberghage lordnull


text:
Question about the attention feature aggregation equation 6

Dear authors,
Thanks a lot for releasing the dataset and code, amazing work!
I had a specific question regarding the feature aggregation for a given query point. In main paper equation 6, the feature vector is refined by its nearest neighbors. When I check the implementation, I found the nearest neighbors are defined in 3D space only, no temporal information is used, code here.  I am wondering wouldn't it lead to aggregation of features from different irrelevant objects?
For example, space $p$ at time $t$ is occupied by object $i$, but at some moment $t_q$ this space might be occupied by another object $j$. When querying prediction for a point near $p$, we will obtain features from both objects $i$ and $j$, is this desired behavior?
In the screenshot below, the green ball seems to be fully coupled with the red cylinder, which might be the reason why the prediction is not good at this moment?

Or do you have other comments regarding this?
Thanks a lot!
Best,
Xianghui

Hi Xianghui,
Thanks for your comments and the great question!
Essentially the best answer is that, despite how the referenced attention equation works, all point clouds are really 4D rather than 3D. This is because they don't merely contain (x, y, z) coordinates but also time indices, which is (x, y, z, t). Because it is already hard enough to visualize 3D representations, let alone four dimensions, we typically visualize only one frame (t = constant) at a time. However, one array or tensor can still contain data from multiple different points in time. In particular, the pcl_key is the encoded version of a spatiotemporal input point cloud, i.e. a collection of point cloud frames that have been stacked together after attaching appropriate values of the time t. This featurized point cloud therefore contains contextual information along the 3 spatial dimensions as well as the temporal axis. Even pcl_query could in principle contain 4D coordinates, but in practice we pick one fixed frame index at a time when querying the implicit representation.
You are correct in pointing out that the feature interpolation (and the relative positional encoding for the attention mechanism) works with respect to spatial difference vectors only, which is 3D, and seems to ignore the temporal dimension. However, when you think about the nearest neighbors step (due to us not having infinite memory), this is intentional -- specifically, I want to ensure that all the available temporal context will be attended to as long as it is within a certain spatial neighborhood in terms of Euclidean distance. If I were to include the time index in this distance calculation, then temporally far-away points would be less frequently included in the featurization during downsampling and/or attention steps. But despite all this, the time indices of both the query and key points are always included with all points and therefore part of the representation, since they constitute the 4D coordinates of those respective embeddings, even if only 3 out of those 4 coordinates are actually used for the purposes of spatial kNN / positional embedding calculations.
This is quite a mouthful so I hope it makes sense. The most important takeaway is that attention works across time, so the query points for the teal sphere themselves have the chance to cross-attend to points corresponding to the same identical sphere earlier in time (when it was still visible in the input video). This contextualization mechanism exists regardless of whether the nearest neighbor calculation happens with spatial positions only or all spatiotemporal coordinates.
I'll be closing this issue, but feel free to continue replying in this thread if you would like any clarification!


text:
Crate interop (styled component libs)

I might have missed it in the docs, but could this crate (perhaps /nightly) solve the "encapsulated components" problem that a lot of CSS in Rust crates are challenged with? Currently it's quite the hassle to provide truly portable components with pure Rust crates across projects and this seems to come quite close!

It's like a part of dependency inspection/crate introspection is still missing in the ecosystem for this. Distributing separately CSS might be a necessary evil then, because that's definitely harder to keep consistent and up to date across multiple crates. Still, I believe this crate does the namespacing/hashing quite alright when I look at it.
Might have to investigate something like git-submodules and local path dependencies for CSS compilation to work consistently. Could that work with a single CLI call with all crates in the folders = [...] of [package.metadata.stylance]?

repo: basro/stylance-rs


text:
'responsive-margin' addon needs a version bump on NPM

Hi @jxnblk,
Creating an issue here because the 'basscss-addons' repo is archived.
I noticed you merged this PR to fix negative margins for the 'responsive-margin': https://github.com/basscss/addons/pull/33
However there is no version bump on NPM, so the package doesn't update when running npm update.
Is there something I'm doing wrong here to get this update?
Thanks, Cam

I think the issue here is that version bumps have not been published to NPM. If clone the 'basscss-addons' repo and look at package.json I can see that the latest version is actually 1.1.0, whereas the latest version according to NPM is 1.0.0.
Cloning the 'basscss-addons' repo manually also pulls the latest code for 'responsive-margins' including the 'Fix negative margins' PR I mentioned above.

repo: basscss/basscss

license: mit


text:
Add two more insert at point commands

Inserting journal style headlines easily can be useful in non-journal buffers
too. Especially when using any 'org-notifications' package (e.g.
org-wild-notifier). This PR
adds two more insert-at-point variants for the org-journal-new-entry and the
org-journal-new-scheduled-entry commands.

Should 412328e05d2c19339774db3b9e292d7f57db2c93 be part of this PR? It seems that the rest of the PR would work without it.

I remember that I wrote somewhere that I kept the three commits separate, to make it more clear what happened in each commit as each commit adds a different feature (however I can not find back where I wrote that, so maybe I deleted that accidentally). But indeed each 'later' commit includes the changes in the earlier commits. So you could squash the commits, but I think the commits deserve to be separate.

Are you sure you are using the latest version?

I might not be. Good call.

Sorry for the delay. Frankly, I feel unqualified for signing off this PR, as I don't understand it (haven't had time to dive deeply enough into it, and haven't been maintaining org-journal for a while).
Is this super important to you, or are you fine with waiting for @cslux to comment? I can probably take some time next week if it's important.

No problem at all! I can also comment right at the chunks in the commits to help you figuring to save your time, but to make those commits relevant it would be nice if you could shortly hint on which aspect is not clear (the motivation or the implementation, or maybe it is a more specific thing. You could also add comments/questions right in the commits). Also, are you familiar with edebug? If not, it is really easy to start using it and can be really helpful for making sense what code is doing (just a recommendation). Finally, I wrote short motivations for each commit in their respective commit messages.
Also, if it needs more time to get merged it is no problem at all (just please indicate soon or not so soon :). I can simply make Spacemacs use my fork for the time being. Anyway, thanks for looking after it.

I've had a talk with @cslux, and he said he'd be back in a couple of weeks. I'll defer this PR until then.

No problem! Thanks for the update... in the meantime I will just point Spacemacs to my fork.

authors: bastibe dalanicolai

repo: bastibe/org-journal


text:
problem with making it required

hi guys
what should we do if we want to make this control to appear as required on form
i tried adding the attribute of 'required' to it but did not
<ng-select [options]="tenants" [(ngModel)]="model.matchTenantId" [ngModelOptions]="{standalone: true}" required>
regards

You can use angular's required validator (Validators.required) in a reactive form.
See the third example in this section.

In case of using not reactive forms we should have required option to pass to select component

This component implement the ControlValueAccessor interface, so that it can be used as FormControl in a FormGroup. That's why you can use the required validator.
There is now way for this component to implement the required option 'by itself', because it is not aware of any form (parent) component.

authors: BehnamAbdy basvandenberg neilhem

license: isc


text:
Update rules_kotlin version

Checklist

[ ] I have filed an issue about this change and discussed potential changes with the maintainers.
[ ] I have received the approval from the maintainers to make this change.
[ ] This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: <please reference the issue number or url here>
Description of this change
The current version of rules_kotlin contains a bug that causes it to break in Bazel 6.0. It's been fixed in https://github.com/bazelbuild/rules_kotlin/pull/777 and the latest release includes this fix.

@mai93 Do I need to make a copy of this PR for the google branch too?

yes, we need to have this fix in the google branch as well.

repo: bazelbuild/intellij


text:
Breaking Windows compatibility

Hi,
I just updated yii2-async,
Now you are using the function pcntl_signal in AsyncWorkerCommand and this function is not compatible with Windows system.
Until now it's compatible, if it's possible to continue with the compatibility.
I temporarily disabled the call yo the pcntl_signal function, and seems it's working again.

Try to update again.
https://github.com/bazilio91/yii2-async/releases/tag/0.1.2

Great, it's working again.
You can close the issue.
Thanks a lot.


text:
🛑 Website is down

In 0b484c7, Website (https://www.bazzile.ch) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Website is back up in 7d9405c after 12 minutes.

repo: bazziletech/monitoring


text:
advanced globs for regex matching?

Is it possible to match clusters to a site by multiple globs?
For example, here is a list of clusters:

Team 1 ABC Cluster 1
Team 1 ABC Cluster 2
Team 2 ABC Cluster 1
Team 1 XYZ Cluster 1
Team 2 XYZ Cluster 1
Team 2  XYZ Cluster 2

To the following sites:

ABC Site
XYZ Site

So, trying to use the following in settings.ini:
cluster_site_relation = *ABC* = ABC Site , *XYZ* = XYZ Site

Thanks

Hi,
you could try this one:
cluster_site_relation = .*ABC.* = ABC Site , .*XYZ.* = XYZ Site

... that was it... thank you so much!

authors: bb-Ricardo pisaniej

repo: bb-Ricardo/netbox-sync


text:
AllCops/DisplayStyleGuide as a .rubocop.yml config option for --display-style-guide

Following on from discussion here I would love to see an AllCops/DisplayStyleGuide option in .rubocop.yml config that gave us the effect of --display-style-guide on the command line.
I think this would be really valuable for integration with hound CI where we can't specify command line options.  I believe myself and many on my team and other developers want to look up the details of particular cops as they encounter them, and with the urls included one can very conveniently click through to the relevant part of the documentation

looks like this feature was added already - apologies that I didn't see it!

repo: bbatsov/rubocop


text:
Fix flaky tests in LogMessageTest

Change Assert condition to check on both map orders in a flaky test in LogMessageTest to make it non-flaky.
Flaky test
cn.hippo4j.common.toolkit.logtracing.LogMessageTest.testKvShouldPutAllKeyAndValuePairs

https://github.com/bbelide2/hippo4j/blob/26212e47cf26c3aee5b9282c4460c903e2adaf37/infra/common/src/test/java/cn/hippo4j/common/toolkit/logtracing/LogMessageTest.java#L73
Problem
Test testKvShouldPutAllKeyAndValuePairs in LogMessageTest is detected as flaky with the NonDex tool. The test failed with the following error:
Error:
Failed tests:   testKvShouldPutAllKeyAndValuePairs(cn.hippo4j.common.toolkit.logtracing.LogMessageTest): expected: <key1=value1||key2=value2> but was: <key2=value2||key1=value1>

Root cause
In this test, 2 key-value pairs are set to the kvs field (ConcurrentHashMap) of logMessage object. Then, logMessage.toString() is called and the response is compared with hard-coded strings. logMessage.toString() converts the given map to string form along with some other processing. But, ConcurrentHashMap/HashMap may not maintain the order of elements. Therefore, when NonDex tests are run, the order of elements are shuffled and the output is reversed and incorrect thus making the test flaky.
Key-values are inserted this way:
https://github.com/bbelide2/hippo4j/blob/cf854b3cb3c47fd339421e5a46a3ae3229c53829/infra/common/src/test/java/cn/hippo4j/common/toolkit/logtracing/LogMessageTest.java#L74-L75
Output is compared this way:
https://github.com/bbelide2/hippo4j/blob/cf854b3cb3c47fd339421e5a46a3ae3229c53829/infra/common/src/test/java/cn/hippo4j/common/toolkit/logtracing/LogMessageTest.java#L76
Fix
Usually, switching from HashMap to LinkedHashMap will make tests non-flaky because LinkedHashMap will preserve order of elements. But, we cannot change a ConcurrentHashMap to LinkedHashMap because LinkedHashMap is not thread-safe like ConcurrentHashMap. Therefore, I updated the assert statement to check the output for both the possible orders of elements.
How this has been tested?
Java: openjdk version "11.0.20.1"
Maven: Apache Maven 3.6.3

Module build - Successful
Command used -

mvn install -pl infra/common -am -DskipTests

Regular test  - Successful
Command used -

mvn -pl infra/common test -Dtest=cn.hippo4j.common.toolkit.logtracing.LogMessageTest#testKvShouldPutAllKeyAndValuePairs

NonDex test  - Failed
Command used -

mvn -pl infra/common edu.illinois:nondex-maven-plugin:2.1.1:nondex -DnondexRuns=10 -Dtest=cn.hippo4j.common.toolkit.logtracing.LogMessageTest#testKvShouldPutAllKeyAndValuePairs

NonDex tests passed after the fix.

Your fix is reasonable, it looks good to me. It is a typical flaky test that we talked about in class, and it was mentioned that it is ok to check for both situations like output.equals("key1=value1||key2=value2") || output.equals("key2=value2||key1=value1") because the sequences of the map object are not guaranteed.

It is actually a simple bug caused by ConcurrentHashMap/HashMap's not assuring the order of outcomes. What impresses me in your fix is your consideration of changing ConcurrentHashMap/HashMap to LinkedHashMap, the aspect of thread-safe is indeed brilliant, in this way the original work flow of the repo won't be affected and thus can be accepted by the developer much easier. Nice fix!

authors: Doom-Prophet Einsteinnnnn bbelide2


text:
WebMock shouldn't raise exception when specifying headers as symbols

As of Ruby v2.3.0 it's acceptable to specify Net::HTTP headers as symbols (https://github.com/ruby/ruby/commit/1a98f56ae14724611fc8f7c220e470d27f6b57e4), but webmock currently raises ArgumentError.new("Net:HTTP does not accept headers as symbols") if you do.
This was introduced in #515, I'd propose wrapping that behavior with a check of RUBY_VERSION.

@akestner good idea. do you fancy a pull request?

Had started on one, but couldn't get a couple of the dependencies to install (eventmachine and unf_ext).

authors: akestner bblimke

repo: bblimke/webmock


text:
how to turn off the contamination check using gdc-viral?

We have the implementation for the contamination check outside of bcbio and thus don't need this step within bcbio.  Could you kindly let me know how to turn off this option in the yaml file?
Thanks,
Segun

Hi Segun,
There wasn't a way to do this, I just added it for you all. If you add tools_off: [viral] to your configuration it should skip the viral check.

Thank you Rory. To make that work, I guess you updated some lines in the bcbio wrapper. Could you let me know which scripts has to be updated? I want to avoid the bcbio update only for this.

oh.. never mind. found it. thank you a ton!

Awesome, thanks for the suggestion!

repo: bcbio/bcbio-nextgen


text:
Arianrhod Korean dicebot

アリアンロッド(Arianrhod RPG)の日本語ファイルを韓国語に翻訳しました。
これが無礼でなければ、韓国語のダイスボットを追加したいです。
Githubのルールが少し苦手な点があるので、いつも失礼しています。

テストの失敗は、エラーの内訳を見ると、まだ韓国語版ファイルがないからだと思います。 合っていますか？

repo: bcdice/BCDice


text:
Update PgpKeyRingGenerator and PGPSecretKey key use of SHA256 Digest

Currently it supports only the use of SHA1. The latest changes in RFC 4880 in section 13.6  for DSA http://tools.ietf.org/html/rfc4880#section-13.6 if a value for DSA higher than 1024 us used SHA1 is no longer valid this will also affect RFC 6637  where it would be SHA 256. Here is an example of a key with DSA 20148 with SHA1 used in pgpdump:
Old: Public Key Packet(tag 6)(814 bytes)
        Ver 4 - new
        Public key creation time - Sat Jun  7 00:44:19 UTC 2014
        Pub alg - DSA Digital Signature Algorithm(pub 17)
        DSA p(2048 bits) - ...
        DSA q(256 bits) - ...
        DSA g(2047 bits) - ...
        DSA y(2048 bits) - ...
Old: User ID Packet(tag 13)(32 bytes)
        User ID - Carlos Perez <test@dsa2test.com>
Old: Signature Packet(tag 2)(113 bytes)
        Ver 4 - new
        Sig type - Generic certification of a User ID and Public Key packet(0x10).
        Pub alg - DSA Digital Signature Algorithm(pub 17)
        Hash alg - SHA1(hash 2)
        Hashed Sub: signature creation time(sub 2)(4 bytes)
                Time - Sat Jun  7 00:44:19 UTC 2014
        Hashed Sub: preferred symmetric algorithms(sub 11)(6 bytes)
                Sym alg - AES with 256-bit key(sym 9)
                Sym alg - AES with 192-bit key(sym 8)
                Sym alg - AES with 128-bit key(sym 7)
                Sym alg - Twofish with 256-bit key(sym 10)
                Sym alg - CAST5(sym 3)
                Sym alg - Triple-DES(sym 2)
        Hashed Sub: preferred hash algorithms(sub 21)(4 bytes)
                Hash alg - SHA256(hash 8)
                Hash alg - SHA384(hash 9)
                Hash alg - SHA512(hash 10)
                Hash alg - RIPEMD160(hash 3)
        Hashed Sub: preferred compression algorithms(sub 22)(3 bytes)
                Comp alg - ZLIB <RFC1950>(comp 2)
                Comp alg - ZIP <RFC1951>(comp 1)
                Comp alg - BZip2(comp 3)
        Sub: issuer key ID(sub 16)(8 bytes)
                Key ID - 0x9379B62B9FF38C62
        Hash left 2 bytes - 44 ec
        DSA r(256 bits) - ...
        DSA s(254 bits) - ...
                -> hash(DSA q bits)
Old: Public Subkey Packet(tag 14)(525 bytes)
        Ver 4 - new
        Public key creation time - Sat Jun  7 00:44:19 UTC 2014
        Pub alg - ElGamal Encrypt-Only(pub 16)
        ElGamal p(2048 bits) - ...
        ElGamal g(2 bits) - ...
        ElGamal y(2048 bits) - ...
Old: Signature Packet(tag 2)(113 bytes)
        Ver 4 - new
        Sig type - Subkey Binding Signature(0x18).
        Pub alg - DSA Digital Signature Algorithm(pub 17)
        Hash alg - SHA1(hash 2)
        Hashed Sub: signature creation time(sub 2)(4 bytes)
                Time - Sat Jun  7 00:44:19 UTC 2014
        Hashed Sub: preferred symmetric algorithms(sub 11)(6 bytes)
                Sym alg - AES with 256-bit key(sym 9)
                Sym alg - AES with 192-bit key(sym 8)
                Sym alg - AES with 128-bit key(sym 7)
                Sym alg - Twofish with 256-bit key(sym 10)
                Sym alg - CAST5(sym 3)
                Sym alg - Triple-DES(sym 2)
        Hashed Sub: preferred hash algorithms(sub 21)(4 bytes)
                Hash alg - SHA256(hash 8)
                Hash alg - SHA384(hash 9)
                Hash alg - SHA512(hash 10)
                Hash alg - RIPEMD160(hash 3)
        Hashed Sub: preferred compression algorithms(sub 22)(3 bytes)
                Comp alg - ZLIB <RFC1950>(comp 2)
                Comp alg - ZIP <RFC1951>(comp 1)
                Comp alg - BZip2(comp 3)
        Sub: issuer key ID(sub 16)(8 bytes)
                Key ID - 0x9379B62B9FF38C62
        Hash left 2 bytes - e1 de
        DSA r(255 bits) - ...
        DSA s(256 bits) - ...
                -> hash(DSA q bits)

when we try to import it we can see that GPG will complain
gpg2 --import -v ~/Desktop/9379B62B9FF38C62_pub.asc
Version: BCPG C# v1.7.5056.37991
gpg: armor header:
gpg: pub  2048D/9FF38C62 2014-06-07  Carlos Perez <test@dsa2test.com>
gpg: DSA key 9FF38C62 requires a 256 bit or larger hash
gpg: DSA key 9FF38C62 requires a 256 bit or larger hash
gpg: key 9FF38C62: invalid self-signature on user ID "Carlos Perez <test@dsa2test.com>"
gpg: DSA key 9FF38C62 requires a 256 bit or larger hash
gpg: DSA key 9FF38C62 requires a 256 bit or larger hash
gpg: key 9FF38C62: invalid subkey binding
gpg: key 9FF38C62: skipped user ID "Carlos Perez <test@dsa2test.com>"
gpg: key 9FF38C62: skipped subkey
gpg: key 9FF38C62: no valid user IDs
gpg: this may be caused by a missing self-signature
gpg: Total number processed: 1
gpg:           w/o user IDs: 1

I used the following code to generate the DSA key
public AsymmetricCipherKeyPair DSA2KeyGen(int KeySize)
        {
            // Check that we got a proper key size
            int[] allowedKeySizes = {1024, 2048, 3072};
            if (!(allowedKeySizes.Contains(KeySize)))
            {
                throw new ArgumentException("KeySize provided is not 1024, 2048 or 3072.", "KeySize");
            }

            // Set the proper N parameter depending on the bit key size.
            int DSA2NParam;
            if (KeySize == 1024)
            {
                DSA2NParam = 160;
            }
            else
            {
                DSA2NParam = 256;
            }

            var secRand = new SecureRandom();
            var dsa2Genertor = GeneratorUtilities.GetKeyPairGenerator("DSA");

            // Generate the proper parameters for the DSA2 Key.
            var digest = new Sha256Digest();
            var paramGen = new DsaParametersGenerator(digest);
            var dsaParamsList = new DsaParameterGenerationParameters(KeySize, DSA2NParam, 80, secRand);
            paramGen.Init(dsaParamsList);

            // This will take a while since it has to find a valid random prime number for use.
            var dsaParams = paramGen.GenerateParameters();

            var dsaOptions = new DsaKeyGenerationParameters(secRand,dsaParams);
            AsymmetricCipherKeyPair keyPair = dsa2Genertor.GenerateKeyPair();

            return keyPair;
        }

Resolved by merge of #15 .

authors: darkoperator peterdettman

repo: bcgit/bc-csharp


text:
Migration from non-FIPS to FIPS BC jar

We have an application which has data already encrypted using non-FIPS Bouncy castle jar which is “bcprov-jdk15on-1.67.jar” with algorithm as “AES/CBC/ PKCS7Padding”, now we want to make this application FIPS complaint , we would be continuing to use the same algorithm without loosing the data which is already encrypted using non-FIPS BC .
I tested this with a sample data and it seems to be working, looking for any official article/documentation from Bouncy castle confirming no data loss during this migration.

non official answer: There are condition when it works (if you use the same algorithm and mode it should work, however some modes might not be supported by Fips or some might be more strict about maximum size or key reuse. I think this can be derived from the FIPS manual in most cases but there cant be a central list of issues as its a complex topic.

Yes we plan to use the algorithm and mode that was used while encrypting the data at the time of decryption as well.
As I mentioned we are using "AES/CBC/PKCS7Padding" with key sizes as 128, 256 and I see this algorithms are FIPS complaint. So decryption should work without any issues in this case.

Yes we plan to use the algorithm and mode that was used while encrypting
the data at the time of decryption as well.
As I mentioned we are using "AES/CBC/PKCS7Padding" with key sizes as 128,
256 and I see this algorithms are FIPS complaint. So decryption should work
without any issues in this case.
On Thu, Nov 23, 2023 at 5:34 PM Bernd @.***> wrote:

non official answer: There are condition when it works (if you use the
same algorithm and mode it should work, however some modes might not be
supported by Fips or some might be more strict about maximum size or key
reuse. I think this can be derived from the FIPS manual in most cases but
there cant be a central list of issues as its a complex topic.
—
Reply to this email directly, view it on GitHub
https://github.com/bcgit/bc-java/issues/1534#issuecomment-1824316988,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADHKCIUDO3JT3YDZEA6QWM3YF43UXAVCNFSM6AAAAAA7SUVPGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRUGMYTMOJYHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

It should but you never know, for example (i.e. without looking at the specific cipher, something I guess Keyfactor support contract would cover) the padding might be stricter in failing for truncated or excessive bytes. But your testing should reveal that.

authors: SushmaReddyLoka ecki

repo: bcgit/bc-java


text:
UserNotice incorrect parsing

Hi, we are trying to add an issuer statement to a certificate.  When we use a null org.bouncycastle.asn1.x509.NoticeReference in org.bouncycastle.asn1.x509.UserNotice constructor UserNotice(NoticeReference,DisplayText) the CertificatePolicy extension is correctly parsed and displayed but when we try to use a not null NoticeReference with Organization and NoticeNumber the extension is not parsed correctly. Any ideas why?

What error are you seeing?

Hi, I should be able to see something like this:
[image: Inline image 1]
but instead I'm getting
[image: Inline image 2]
Thanks.
On Tue, Feb 27, 2018 at 6:15 PM, bcgit notifications@github.com wrote:

What error are you seeing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bcgit/bc-java/issues/305#issuecomment-369061809, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AjMNsKBjPcDjuok73_uh-rNu-JFmlMvHks5tZIyQgaJpZM4SVlON
.

I'm sorry, but the screen dumps did not come through.

Hi, attached you will find two png's with the screenshots.
Thanks.
On Tue, Feb 27, 2018 at 10:28 PM, bcgit notifications@github.com wrote:

I'm sorry, but the screen dumps did not come through.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bcgit/bc-java/issues/305#issuecomment-369109619, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AjMNsCgjuC89tBzPL4RFdyQ45OpxnFCAks5tZMfpgaJpZM4SVlON
.

Try emailing them to feedback-crypto@bouncycastle.org

Hi, I just did it.
Thanks.
On Wed, Feb 28, 2018 at 7:41 AM, Diego Garzón pinguidj@gmail.com wrote:

Hi, attached you will find two png's with the screenshots.
Thanks.
On Tue, Feb 27, 2018 at 10:28 PM, bcgit notifications@github.com wrote:

I'm sorry, but the screen dumps did not come through.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bcgit/bc-java/issues/305#issuecomment-369109619, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AjMNsCgjuC89tBzPL4RFdyQ45OpxnFCAks5tZMfpgaJpZM4SVlON
.

The screendumps didn't actually show anything related to Bouncy Castle. NoticeReference (as defined in the ASN.1 library) appears to correct though. It may be related to the tool being used for displaying the certificate.

authors: bcgit pinguidj


text:
fixed logo for retina screen

Fixed logo resolution for retina screen

awesome!

authors: blakeworsley sikemausa


text:
chore: connect via pgbouncer

Implements # 888

Need to grant access to pgbouncer role before merging this in.

repo: bcgov/CONN-CCBC-portal


text:
Issues Tab - Issue History

As a team member
I want to see old Issues on my Work
so that I can see into the past
Acceptance Criteria
Scenario 1:
GIVEN I am on the Issue Tab
WHEN there are at least 2 old Issues AND there is an Approval Needed Issue
THEN I see the following under Issue History:

the most recent approved Issue is on top (un-truncated)
the older Issues are below the edit button
there is a line connecting the dot icons for the Issues
the previous Issues are in ghost text
the previous Issues are truncated
there is a Read More button for each Issue that has been truncated

Scenario 2:
GIVEN I am on the Issue Tab
WHEN there are at least 2 old Issues AND there is an Approved Issue
THEN I see the following under Issues History:

the most recent approved Issue is on top
there is a line connecting the dot icons for the Issues
the line and dot icons are grey
the previous Issues are in ghost text
the previous Issues are truncated
there is a Read More button for each Issue that has been truncated

Scenario 3:
GIVEN there are old Issues I want to read
WHEN I click on the show more button
THEN I see the old Issue expand to full length
Scenario 4:
GIVEN an old Issue is expanded
WHEN I click on the show less button
THEN I see the Issue history return to default view
Validation Rules?
(If yes, list here)
Screenshot
(Link above will always be the most up-to-date version.)

link to prototype
https://www.figma.com/file/yZk63tFMjpuCbYLCBpo7OT/Development-(Issues%2FStatus)?type=design&node-id=4771-14414&mode=design

Hey team! Please add your planning poker estimate with Zenhub @TomChapmanGov @jadmsaadaot @saravanpa-aot


text:
Invalid QR code scan error has poor colour contrast

When scanning an invalid QR code, the error message appearing does not match the design. The text should be white to ensure proper colour constrast.

@knguyenBC , can you please provide a screenshot?

@amanji The error message is still black text on iOS. Android looks fine. I tested build 125 for iOS. Oddly enough, the most updated version I have for android is build 117.

authors: cvarjao knguyenBC

repo: bcgov/bc-wallet-mobile


text:
set bands_per_frame on kmeans result

done

up arrow to move through frames on kmeans result

repo: bcgov/bcws-psu-research


text:
Check Point GAIA firewall manager upgrades and log shipping - connect with Check Point

Describe the Issue
Pervious conversations were had with Check Point on this issue but no resolution was provided.  Including individuals that implemented in ASEA would be helpful.  This is to re-start that conversation.
Additional Context
Previously, Check Point advised NOT to install agents to ship logs from the firewalls or manager.
Current connectivity restricts to tcp, but need udp for syslog endpoint.
Include SecOps Cloud Security Architect in coversation.
Is via Market Place a must
Acceptance Criteria

[ ] Setup meeting w/ Check Point
[ ] Understand how logs can be shipped to immutable source
[ ] Understand upgrade path (non-manual)

According to the checkmate thread TCP to transport syslog is possible.

According to the checkmate thread TCP to transport syslog is possible.

There is checkmate thread detailed how to forward log to AWS cloud watch

Is it BYOL (Bring your own license)  or PAYG (Pay as you go) ?

Chris B. offered biweekly Meeting with checkpoint.

Nick C., Chris L C., and Bruce had attended Checkpoint Cloud security training (pre CCSA prep) and learnt valuable   knowledge how to use cloudformation stack to deploy single fw, clustering fw, fw in auto scaling group  in AWS.

Daniel M. "Upgrades in the ASG are done when scaling out. This will update to the latest version (Unless it was hardcoded in the accelerator)"

authors: NickCorcoran bruce-wh-li

repo: bcgov/cloud-pathfinder


text:
Provision Bahaa with Airtable

Describe the issue
In order to do surveys, we will have a variety of tools available (MS Forms, Airtable).
Which Sprint Goal is this issue related to?

Note: 'Milestone' is a ZenHub term that we use synonymously with 'Sprint'.

The 'Milestone' description (created in ZenHub) should clearly list Sprint Goals. This section should indicate which 'goal' this issue is related to.
Additional context
Add any other context, attachments or screenshots
Definition of done

Sid to connect with Meara to use p-card for Airtable (check with Gen first)
Enable the use of Airtable for Bahaa and other team members as needed (Julian, Shea, Emily)

Closing this as access is provided.

authors: ActionAnalytics sid-gov


text:
Advanced Search - overdue lists on hold requests

Describe the bug in current situation
Advanced Search - search overdue requests and it lists "On Hold" requests
Link bug to the User Story
#1213
Impact of this bug
Describe the impact, i.e. what the impact is, and number of users impacted.
All users
Chance of Occurring (high/medium/low/very low)
High
Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?
all env
Steps to Reproduce
Steps to reproduce the behavior:
Go to Advanced Search
Select "Overdue" under "Request Status"
Click Apply search
Actual/ observed behaviour/ results
Result contains "On Hold" requests
Expected behaviour
The list should not includes "On Hold" requests
Screenshots/ Visual Reference/ Source
Search criteria

Actual Result

Expected behavior now works as it should - Thank for fixing! @richard-aot

authors: KaraBeach richard-aot

repo: bcgov/foi-flow


text:
.csv reports not all working on recorded activity page

[x] survey csv shows up blank for full data set
[x] chemical treatment csv shows up blank for full data set
[x] mechanical treatment csv shows up blank for full data set
[x] chemical monitoring csv shows up blank for full data set

The other csv reports work, and the ones above will work with smaller data sets only.   Email chain with mike, brennan, rob and crystal from July 19th has error codes shown in console when a blank csv is provided.
Rob reviewed and said:
It looks to me like this is not a deployment issue but an actual problem with the code, possibly caused by a dependency upgrade. I see log messages about problems encountered while processing dates and these messages are causing the export to fail. Generally I think the CSV-generating code needs a bit of an overhaul to increase robustness (dumping per-row error messages when failures are encountered, streaming responses, etc.). I will discuss it with the team tomorrow.

@plasticviking nice work on this!  Tested and confirmed they all work.  Thanks!

repo: bcgov/invasivesbc


text:
Add support for exporting metabase groups

Overview
This PR includes the following proposed change(s):

Adds an admin API (default port 8005) providing read-only access to user group membership information to be imported to metabase. This port should be exposed to local services only and not reachable via any routes.
Associated database queries and migration to provide mapping between InvasivesBC role and Metabase groups

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Refactoring / Documentation
[ ] Version change

if your change is a breaking change, please add breaking change label to this PR
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Screenshots
Please add any relevant UI screenshots if applicable.
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] New and existing unit tests pass locally with my changes

/rebase

authors: micheal-w-wells plasticviking