text:
Partial reading for objects

With this PR also JsonReader.Object supports partial, resumable reading. The implementation is like JsonReader.Array and relies on a state machine to track the current progress of the object reading. The state machine works slightly different to the array version: after a property name is read, it is left to the caller to read the property value fully, as this helps avoiding unnecessary lookaheads within the state machine.

Codecov Report
Base: 87.88% // Head: 88.17% // Increases project coverage by +0.28% :tada:

Coverage data is based on head (6a39e7c) compared to base (711d032).
Patch coverage: 95.74% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   87.88%   88.17%   +0.28%
==========================================
  Files           5        6       +1
  Lines         850      930      +80
==========================================
+ Hits          747      820      +73
- Misses        103      110       +7

Impacted Files
Coverage Δ

src/JsonReader.cs
95.29% <94.63%> (-1.00%)
:arrow_down:

src/ObjectReadStateMachine.cs
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Thanks! This is a fantastic addition. I've left some comments from my review.
By the way, the following limitation can also be removed from README.md:
diff --git a/README.md b/README.md
index cf1a4f3..77c7e43 100644
--- a/README.md
+++ b/README.md
@@ -238,7 +238,6 @@ of the JSON source text to resume reading.

 Presently, the following readers do not support partial reading:

-- `JsonReader.Object`
 - `JsonReader.Either`
 - `JsonReader.Tuple`

I would also be inclined to add a method like the following (name debatable) on JsonReader:
public static IAsyncEnumerator<KeyValuePair<string, T>>
    GetObjectAsyncEnumerator<T>(IJsonReader<T> reader,
                                Stream stream, int initialBufferSize,
                                CancellationToken cancellationToken)

that would be a second use case for the state machine and help to iron out any design kinks. A test could be used to reading airports.json in a streaming fashion.

Thanks for the review! Agree with both observations, I would argue that we adapt the README.md as soon as we support partial reading for all JsonReader.Object overloads (to be done with future PRs). Streamed property reading sounds interesting, let's consider this for a future PR.

authors: bastbu codecov-commenter

repo: atifaziz/Jacob


text:
Add storeChallenge to example

It says in the auth plugin docs it is “highly recommended” to use the storeChallenge approach for security best practices to prevent replay attacks. It should probably be included in the example?
https://github.com/atinux/nuxt-auth-utils?tab=readme-ov-file#webauthn-passkey

I believe this should be quite easy to do by leveraging NuxtHub KV, if you want to try feel free to open a PR?

Checkout #3 to see how I implemented it!

Thanks for adding the example.
It looks though like there is an issue with the auth. Even on the demo site for this repo, when you create an account it's fine, but when trying to sign in it says Challenge not found or expired on every attempt, preventing any login.
https://todo-passkeys.nuxt.dev/

Thanks for adding the example.
It looks though like there is an issue with the auth. Even on the demo site for this repo, when you create an account it creates fine, but when trying to sign in it says Challenge not found or expired on every attempt, preventing any login.
https://todo-passkeys.nuxt.dev/

If someone is coming across this issue with the same problem, the fix is to apply the example linked to in the PR https://github.com/atinux/nuxt-todo-passkeys/pull/3 as mentioned above, but also to apply the fix added in this commit: https://github.com/atinux/nuxt-todo-passkeys/commit/08d12706405825a291ca6dd4793f8f681bb24849

source: gharchive/issue

repo: atinux/nuxt-todo-passkeys

license: MIT

license_type: permissive

license_source: github-api


text:
Research

Research

Skeleton loader
Сейчас используется либа react-content-loader
Проблема в том, что на каждую карточку приходится вручную создавать скелетон (и шейп скелетона никак не зависит от нее, так что в случае смены верстки у карточки придется вручную править скелетон)

Вынос Carousel в uikit. Требования:

drag&swipe
Цикличность
Возможность крутить карусель с помощью кнопок (стрелок вправо/влево)

Вынос компонента Layer (ранее Modal) в uikit. Пример актуальной реализации
Реализация с порталом и onOutsideClick'ом довольно жирная, поэтому нужно вынести этот компонент в uikit. Используется для создания модалок и поповеров
Работа с хедерами в @atls/next-app-with-apollo. Сейчас в параметрах при инициализации провайдера есть поле headers, тип any[]. Когда хедеры попадают в провайдер с ними происходит это. Если так и должно быть - в таком случае не ясен принцип, какого вида функция должна быть на входе чтобы добавить заголовок

4
https://github.com/atls/nextjs/blob/3138f27f231c8f28f6dd4a5412b5b787f88ded12/packages/next-app-with-apollo/src/with-apollo.provider.tsx#L45
экстрактор, прикидывает контекст, а на выходе получает объект ключ значения хедеров
(ctx: NextCtx) => { [key: string]: string ]

1
Варианты
В рантайме
Компонент-обертка - компоненту закладывается какая-то схема, и он клонирует дочерний элемент и подставляет данные на основе этой схемы
Генерация
Скрипт-генератор - берет на вход схему c компонентом и генерит компонент skeleton
Типы или пропсы
Генерация на основе - типов или пропсов компонентов, имеем формат входных данных, пытаемся предугадать (что-то типа faker для конкретного поля) и строим схему, на основе которой генерим skeleton

@TorinAsakura

В рантайме

Наиболее удобный и понятный, пока фаворит

Генерация

В моем представлении эта реализация тащит за собой определенное количество оверхеда (по сравнению с первым вариантом):

Нужно будет самостоятельно описывать логику отображения скелетона используя Condition (верстка будет чуть более жирной и чуть менее читабельной)
Нужно будет дополнительно где-то хранить разметку скелетона
Нужно будет придумать как указывать скрипту таргеты для генерации скелетона, чтобы они вызывались автоматом на postinstall, например, как билд иконок

Типы или пропсы

Здесь концепт не совсем понятен

Какой сущностью будет сам скелетон? (самостоятельный компонент, враппер поверх верстки, интерсептор (какой-нибудь HOC) и т.п.)
Как будут выглядеть входные данные для генерации скелетона?
Возможно ли будет более детально регулировать размеры стабов внутри скелетона? (например ширину плейсхолдера для строки, расстояние между ними и т.п.)

3
непонятно как layer и modal связаны вместе, если брать layer - то последнее время использую https://github.com/everweij/react-laag
если брать modal - то там ничего особо нет, те не усложняю, можно в каждом проекте писать отдельно, либо минималка как в архивном modal

repo: atls/uikit


text:
Compile an end-to-end tutorial to deploy to EC2

There should be a tutorial on building a hello world program and deploying it to EC2.

I suppose Capstan can be used (at least as a reference).

This is a recently announced tool for automating the process, though I had some difficulty getting the dependencies working: https://github.com/GaloisInc/ec2-unikernel
Mirage also provides a script for this: https://github.com/mirage/mirage/blob/master/scripts/ec2.sh

authors: bernerdschaefer errordeveloper

repo: atmanos/atmanos

license_source: bigquery


text:
Set suggestion list width to width of item with longest description

Otherwise the suggestion list will resize when arrowing through the suggestions. Frustrating!

:+1: . We really have to fix those specs that are flaky on Travis and Appveyor. I just have no idea how to fix them. I have observed that if you open the inspector while the tests run they consistently fail.

I have observed that if you open the inspector while the tests run they consistently fail.

Scratch that, I can no longer repro. I've definitely seen it, but only if I triggered the inspector at some point during the spec run.

Yeah, it's flaky. Just need to check that it is offset another way.

source: gharchive/pull-request

authors: benogle joefitzgerald

repo: atom-community/autocomplete-plus

license: mit


text:
Failed to activate the linter package

[Enter steps to reproduce below:]

...
...

Atom Version: 1.1.0
System: Mac OS X 10.10.5
Thrown From: linter package, v1.10.0
Stack Trace
Failed to activate the linter package
At Cannot find module 'grim'

Error: Cannot find module 'grim'
  at Module._resolveFilename (module.js:334:15)
  at Function.Module._resolveFilename (/Applications/Atom.app/Contents/Resources/app.asar/src/module-cache.js:383:52)
  at Function.Module._load (module.js:284:25)
  at Module.require (module.js:363:17)
  at require (module.js:382:17)
  at Object.module.exports.activate (/Users/elinnet/.atom/packages/linter/lib/main.coffee:76:5)
  at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:232:19)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:212:32
  at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:153:15)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:205:26
  at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:201:34)
  at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:474:21)
  at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/settings-view/lib/package-manager.js:385:60
  at exit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/settings-view/lib/package-manager.js:73:16)
  at triggerExitCallback (/Applications/Atom.app/Contents/Resources/app.asar/src/buffered-process.js:213:47)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/buffered-process.js:227:18
  at Socket.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/buffered-process.js:98:18)
  at emitOne (events.js:82:20)
  at Socket.emit (events.js:169:7)
  at Pipe._onclose (net.js:467:12)

Commands
  3x -1:03.8.0 editor:newline (atom-text-editor.editor.is-focused)
  2x -1:03.1.0 core:move-up (atom-text-editor.editor.is-focused)
     -0:59.2.0 editor:newline (atom-text-editor.editor.is-focused)
  7x -0:57.3.0 core:backspace (atom-text-editor.editor.is-focused)
  2x -0:32.3.0 settings-view:check-for-package-updates (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-one-dark-syntax.theme-one-dark-ui)
  3x -0:05.2.0 core:move-right (atom-text-editor.editor.is-focused)
     -0:04.3.0 core:move-left (atom-text-editor.editor.is-focused)
     -0:03.6.0 editor:newline (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "disabledPackages": [
      "linter-eslint",
      "autoclose-html"
    ],
    "destroyEmptyPanes": false
  },
  "linter": {
    "showErrorPanel": false
  }
}

Installed Packages
# User
color-picker, v2.0.13
indent-guide-improved, v1.4.3
linter, v1.10.0

# Dev
No dev packages

Please restart Atom and see if you are still seeing this issue.

Problem went away for me after an update.

This is an issue with the old version of Electron that Atom v1.1.0 (and older) ships with, it should be fixed in v1.2.0 and above.

Same on win10

Yep, just had this issue on Ubuntu 14.04. Maybe this suggests I should upgrade more frequently.

We've seen reports from all OS's for a while now, like I said this won't be fixed until v.1.2.0 gets released. Luckily a simple restart fixes this issue, there is a related issue with non-ASCII profile paths that make most plugins break for anyone not using v1.2.0.

Duplicated of https://github.com/atom-community/linter/issues/942 and https://github.com/atom-community/linter/issues/882

authors: Arcanemagus CaptainBland andreykko elinnet jnials steelbrain

repo: atom-community/linter


text:
keep icon colors in tabs

I use "file-icons" to display colored icons in atom tabs. After switching to atom-material-ui, and setting tainted tab bar color. I lost the icons colors. This is important to locate the files easily.
Can I hack this icon colors in material-ui ?

I overrode the color when using tinted tabs for the simple reason that if you have a green icon with a green background you wouldn't see it. I doubt that this can be reverted by using your user stylesheets, but it doesn't hurt to try.

It seems the icon colors are lost on 2.0, even without Tinted tab bar.

@silvestreh This line here overrides tab icon colors regardless of tinted tab use.

This bugs me a lot too. @doryphores link is broken, here is the code in master that overrides the color.
Making this color override optional would be much appreciated.

I've added this to my stylesheet in the meantime...
.amu-tinted-tab-bar atom-pane .tab-bar .tab .title[data-path]::before {
    color: inherit !important;
}

atom-pane .tab-bar .tab .title[data-path]::before {
    color: inherit !important;
}

I hope this is getting a fix soon, I don't like that atom-material-ui try to dictate how other packages should behave. My custom theme color has enough contrast with the yellow and green using by VCS coloring option in atom tab and file-icons.

Hey guys, maintainer of file-icons here. I've submitted a pull-request to address this. However, it's dependent on a change I had to make to the package, so it therefore won't take hold until the next release. I'll endeavour to get one cut shortly after the PR's made it upstream.

@Alhadis Did you mead #439 PR? 😅

Ugh... 😥 Yeah, I did. #349, #439... mistyped the first two digits. Updated my response.

authors: Alhadis doryphores eminos gluons ilmam mrleblanc101 sbywater-rp silvestreh

repo: atom-material/atom-material-ui


text:
Uncaught TypeError: Cannot read property 'id' of null

[Enter steps to reproduce:]

Click anywhere within a file

Atom: 1.19.0-beta3 x64
Electron: 1.6.9
OS: Microsoft Windows 10 Pro
Thrown From: Atom Core
Stack Trace
Uncaught TypeError: Cannot read property 'id' of null
At C:\Users\jzinger1\AppData\Local\atom\app-1.19.0-beta3\resources\app\src\text-editor-component.js:2145

TypeError: Cannot read property 'id' of null
    at horizontalPositionsToMeasure.forEach (~/AppData/Local/atom/app-1.19.0-beta3/resources/app/src/text-editor-component.js:2145:73)
    at Map.forEach (native)
    at TextEditorComponent.measureHorizontalPositions (~/AppData/Local/atom/app-1.19.0-beta3/resources/app/src/text-editor-component.js:2141:45)
    at TextEditorComponent.measureContentDuringUpdateSync (~/AppData/Local/atom/app-1.19.0-beta3/resources/app/src/text-editor-component.js:382:16)
    at scheduler.readDocument (~/AppData/Local/atom/app-1.19.0-beta3/resources/app/src/text-editor-component.js:266:20)
    at ViewRegistry.module.exports.ViewRegistry.performDocumentUpdate (~/AppData/Local/atom/app-1.19.0-beta3/resources/app/src/view-registry.js:191:15)
    at ~/AppData/Local/atom/app-1.19.0-beta3/resources/app/src/view-registry.js:3:65

Commands
     -3:53.9.0 core:save (input.hidden-input)
  2x -3:48.3.0 intentions:highlight (input.hidden-input)
     -3:47.8.0 core:copy (input.hidden-input)
     -3:34.7.0 intentions:highlight (atom-text-editor.editor)
     -3:34.5.0 core:paste (atom-text-editor.editor)
     -3:32.7.0 intentions:highlight (atom-text-editor.editor)
     -3:32.6.0 core:undo (atom-text-editor.editor)
  3x -3:16.4.0 core:backspace (input.hidden-input)
undefined -3:14.1.0 core:delete (input.hidden-input)
     -3:06.8.0 intentions:highlight (input.hidden-input)
     -3:06.6.0 core:paste (input.hidden-input)
     -3:01.6.0 intentions:highlight (input.hidden-input)
  4x -3:01.4.0 core:save (input.hidden-input)
  7x -2:56.3.0 intentions:highlight (input.hidden-input)
  3x -2:55.6.0 core:save (input.hidden-input)
  2x -1:35 intentions:highlight (input.hidden-input)

Non-Core Packages
atom-beautify 0.30.3
atom-material-syntax 1.0.6
atom-material-ui 2.0.4
atom-react-native-css 1.1.3
auto-detect-indentation 1.3.0
autoclose-html 0.23.0
autocomplete-modules 1.6.10
busy-signal 1.4.3
color-picker 2.2.5
css-comb 2.5.0
css-snippets 1.1.0
emmet 2.4.3
file-icons 2.1.8
intentions 1.1.2
javascript-snippets 1.2.1
language-babel 2.66.1
linter 2.2.0
linter-eslint 8.2.1
linter-ui-default 1.6.2
minimap 4.28.3
monokai-seti 0.9.0
pigments 0.39.1
seti-ui 1.9.0
todo-show 1.11.0

Thanks for the report!
We noticed that this looks like a duplicate of https://github.com/atom/atom/issues/14794. You may want to subscribe there for updates and if you can let us know in that issue if you can reproduce the error in safe mode with your steps to reproduce, that would be helpful to know.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.

authors: rsese zingerj

repo: atom/atom


text:
Horizontal scrolling

Tilting mouse wheel momentary scrolling to horizontal end (shift+scroll working fine),
anyone know how to fix it ? (in window's mouse settings horizontal scrolling set to 1 character,
setting vertical scroll on tilting the wheel and using it do not changing the vertical scrolling behaviour)

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests so if you can open a new issue with the template filled out, that would be helpful for us. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way :grinning:


text:
Squirrel (windows updater) issues

It does not remove old version after update. And I need periodically clean c:\Users\<user>\AppData\Local\atom\. Release about of half GB... Perceptibly to have of 500 MB trash (for EACH old release) on SSD.
(not so critical) It always download full package because Program: Failed to apply updates, falling back to full updates: System.IO.PathTooLongException
Filename must be less 260 chars and dirname must be less 248 chars
Something like this
Downloaded packages MUST be deleted after success install I think... Or at least old downloads

Thanks for the reaching out!

It does not remove old version after update. And I need periodically clean c:\Users<user>\AppData\Local\atom. Release about of half GB... Perceptibly to have of 500 MB trash (for EACH old release) on SSD.

Atom should keep I think 1 old version in addition to the current version and this is expected behavior e.g. /cc https://github.com/Squirrel/Squirrel.Windows/issues/1024.  You don't mention how many versions you have however - there was a bug 1.19 I think where old versions weren't getting removed but that's been fixed (though you'll need to manually remove these).

(not so critical) It always download full package because Program: Failed to apply updates, falling back to full updates: System.IO.PathTooLongException
Filename must be less 260 chars and dirname must be less 248 chars
Something like this

This has been reported in https://github.com/atom/atom/issues/15664 if you want to subscribe.

Downloaded packages MUST be deleted after success install I think... Or at least old downloads

Not sure what you mean here can you clarify?
Lastly, it would be super helpful for us if you can use the issue template when opening issues and additionally, report 1 issue per issue.  If multiple issues are reported in a single issue, it's harder to keep track of things and you can't close the issue until all the issues in it are closed.

We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way :grinning:

Yes of cause. Windows updates in the #%$#%@#$@#$@

I HATE your MAC. Hate you moronic WHITE background for terminal.
I HATE it coz atom-ui is MAC i think.
White terminal IS ugliness

authors: rsese zorn-v


text:
Atom UI is blurry when moving mouse.

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
When I clicked Atom editor tab and move mouse randomly or scroll at other window Atom UI was blurry. i've tried different solutions (e.g., "--disable-gpu" or "--safe" or changing nvidial control panel antialiasing options) but It still happened.

Steps to Reproduce

Open editor tab on Atom.
Open other window(e.g., firefox, emacs, hyper, etc.)
move mouse at any window including Atom window or scroll at other window.

Versions
Atom : 1.38.0
Electron : 2.0.18
Chrome : 61.0.3163.100
Node : 8.9.3
Windows 10 x64
Ryzen 3 1200
GTX 1060
DDR4 ram 8GB

Thanks for the report - just to confirm, if you've used previous versions of Atom is this behavior new for you as of 1.38.0 or you've seen it in previous versions of Atom?

Thanks for the report - just to confirm, if you've used previous versions of Atom is this behavior new for you as of 1.38.0 or you've seen it in previous versions of Atom?

When I saw your reply, I tried to reproduce that symptom but It is strange that that doesn't occured.
I'm trying to reproduce now and I will come back if I find out exact reproducing process.

Oh interesting, thanks for the update :+1:  I'll go ahead and tag this as more-information-needed again so it will close over time if you end up not seeing this again and we don't hear back from you.

Here is a relevant issue:
electron/electron#13646

authors: ReolSt nnnyan rsese


text:
I cannot quit Atom

I've tried to quit Atom but it hasn't been working.
I'm pretty sure that I've tried everything:
Command + Q
and selecting quit from the dropdown menu.
I'm using a Mac.
If anyone has any solutions, or this problem has been fixed, please tell me.

Have you tried :q!? 🤣
Just kidding. It seems like it might be frozen. Are you able to kill it from the task manager?

same here on osx 10.13.6
have to kill it always whit the task manager!

looks like a duplicate of #17672

If anyone has any solutions, or this problem has been fixed, please tell me.

You can use the "Force Quit` entry in the Apple Menu as a workaround.
Like @UziTech said, dupe of #17672

I am having the same problem. I believe this issue is caused by a package you have installed. Luckily for me I only have about a half a dozen different packages installed, so it was easy to find what package(s) was the culprit. You can view your installed packages under the Settings View, found under the menu Packages > Settings View > Open. Once opened, click Packages from the left panel to see the list of package you have installed. From the Settings View, you can disable a package, kill the app, re-open Atom, then try quitting. You have to do it one by one until you found the offending package. I recommend starting with any recently installed packages first. Luckily for me it was the most recent package I installed, so it didn't take long for me to find. In my case, it was the "pigments" package. I don't really need that package anyway, so uninstalled it. Good luck!

Still having this issue.
@dquessenberry No matter what, there is no kind of package that should be able to prevent Atom from quitting.
Atom should be updated such that no matter what packages the user has installed, the Quit function always works!!!!

@dquessenberry No matter what, there is no kind of package that should be able to prevent Atom from quitting.
Atom should be updated such that no matter what packages the user has installed, the Quit function always works!!!!

I agree with you. Just thought I would share what helped me, at least for a short term fix.

I am having the same issue since some weeks... I haven't installed any packaged recently though. Anyway, I do force quit.

+1 on this issue. I always have to force quit.

I'm having the same issue as well :/

same issue! no solutions?

Same here, I have to force quit every time, really annoying.

Same here :(
Can't figure it out

Anyone not even able to force quit?
There are no atom processes in the activity monitor, which is weird. It does show up in the Force Quit Applications window, but force quit attempts don't do anything. In the dock, there is no white circle indicating the app isn't running, but right-clicking on the app icon has the message "application not responding". Finally, attempts to restart fail, with the OS saying it can't restart because Atom can't be closed. I have to physically shut down via the power button.
Atom v1.50.0
MacOS Mojave 10.14.6

I can reproduce this issue on my Mac running 10.14.6. The first version of Atom that has this issue for me is 1.47. Maybe the upgrade to Electron 5.0.12 is relevant?

Same issue here with Atom 1.50.0 under Mac 10.15.6.

I'm also having this issue. Didn't happen prior to a week ago. No new packages installed, upgraded to Atom 1.50.0, but that didn't fix it.
Force quit works, but when I open it next time, it always opens to the same project, but not the one I was using previously.

I was also having this issue. Didn't happen prior to a week ago. No new packages installed, upgraded to Atom 1.50.0, but that didn't fix it. Also just figured out how to get around it, and what it takes to reproduce the issue.
Whenever I opened Atom, it would open to the same project. Let's called that Project A. If I close that window, leaving no Atom windows open, and then open a different project(Project B), then I can't quit. When I force quit, then reopen atom, it opens with Project A again.
Now, if I open Project B while Project A is still open, and then close Project A, suddenly I can quit normally without issue.
Can anyone else confirm if this works for them too?

@HCLarsen Can confirm. Open one project (A), can still quit. However, if I close all windows for Project A and open another project (B), I can no longer quit. Have to use Activity Monitor.
If I still have Project A open when I open Project B, I am still able to quit, even if I close all Project A windows first.

Was still experiencing this issue even with all packages disabled. I got so sick of it that I deleted my ~/Library/Application Support/Atom folder entirely, which seems to have at least temporarily fixed the issue, at the cost of loosing my "Reopen Project" history. I checked, and my Themes, Packages, Config etc seem to be intact, which is consistent with my understanding they're stored in ~/.atom
Not advising this as a fix necessarily, but seems to be working for me at least.

@HCLarsen Can confirm. Tested on Atom 1.51.0, macOS 10.13.6 High Sierra

Confirmed, Atom 1.51.0, macOS 10.14.6 (18G6032) Mojave

I solved the issue by changing the core setting "Restore Previous Windows on Start" to "No".

I have this problem too

@HCLarsen Yes, seems to be the case for me too

Jup, also got this issue on my macbook

This should be a reliable workaround
in your init.coffee add
atom.commands.add '*', 'application:delayed-self-murder', (options) ->
    # first try normal quitting
    atom.commands.selectorBasedListenersByCommandName["application:quit"][0].didDispatch()
    waitTime = 500 #half a second
    # after a certain amount of time, murder atom
    setTimeout ->
        process = require("process")
        childProcess =  require("child_process")
        childProcess.exec("kill -9 #{process.ppid}")
    , waitTime

in your keymap.cson add
'*':
    'cmd-q': 'application:delayed-self-murder'

Reload the window (or restart Atom) and now cmd+q should always work (note: unsaved work/undo buffer probably not guaranteed)
If you don't care about unsaved work, you can change the waitTime = 500 to waitTime = 0

MacOS 10.15.7
Atom 1.52.0
same issue
Atom works well but can killed only by a "Force Quit" from activity monitor.

Same for me
MacOS 10.15.7
Atom 1.52.0 x64
I need to force quit to exit

I have the same issue on MacOS 10.15.7 and Atom 1.53.0 and can confirm @HCLarsen except that it doesn't seem to matter if it's the same project. I usually use Atom from the command line, but I can certainly reproduce the issue by doing the following:

Click on Atom in the dock -> last project opens
Click on the "x" so that Atom remains open w/o any open windows - can still quit by command + q
Go to "File" -> "Reopen last project"
command + q closes the window but the app remains open and can only be force-quit

Same for me
MacOS  10.15.6
Atom 1.53.0 64

Same for me
MacOS 10.15.6
Atom x64 1.53.0

Same for me
MacOS 11.0.1
Atom 1.53.0 x64

Same

I have only core packages installed. The inability to quit has come up randomly over about the past year. I don't remember experiencing it before then. Concurrently, it has started being random about weather it quits when all windows have been closed.

Same problem here, I'm using Atom 1.53.0 x64 on macOS HighSierra 10.13.6. I often need to force quit the application.

Also, when it fails to quit, it can actually prevent shutdown and you can't Force Quit it either.  I have had to physically power off my Mac laptop.  This is not ok.

Also, when it fails to quit, it can actually prevent shutdown and you can't Force Quit it either.  I have had to physically power off my Mac laptop.  This is not ok.

Same problem here. 1.53.0 x64 MacOS, Catalina 10.15.7.
I have to force quit all the time.

Same

I made a PR that fixes this issue.
https://github.com/atom/atom/pull/21843
Anyone having this issue can go to this link and request the core maintainers to merge the PR. This would facilitate their review process.

I made a PR that fixes this issue.
https://github.com/atom/atom/pull/21843
Anyone having this issue can go to this link and request the core maintainers to merge the PR. This would facilitate their review process.

for my case, whenever i "Reopen Project" a project from project history, atom won't quit normally. have to force quit.
if i use "Open" and select a project from file dialog, atom quits normally.
there is a clear project history selection in "Reopen Project". try clearing that does not help. in fact, the project history is not clearing. that seems to show a problem.
read on the internet to start "atom --clear-window-state"
after that, clearing project history works. all previous project entries are gone.
now, when opening projects, the projects are added back to project history.
with the new project history list, using Reopen Project to open a project does not lead to atom won't quit anymore.
no need to force quit atom anymore

for my case, whenever i "Reopen Project" a project from project history, atom won't quit normally. have to force quit.
if i use "Open" and select a project from file dialog, atom quits normally.
there is a clear project history selection in "Reopen Project". try clearing that does not help. in fact, the project history is not clearing. that seems to show a problem.
read on the internet to start "atom --clear-window-state"
after that, clearing project history works. all previous project entries are gone.
now, when opening projects, the projects are added back to project history.
with the new project history list, using Reopen Project to open a project does not lead to atom won't quit anymore.
no need to force quit atom anymore

I'm still having this issue on Big Sur when Atom is open and I do a Restart or Shutdown without first shutting down Atom.

Me too. This is so annoying. No document open in atom. Quit does not work so I always have to force shut down atom. So annoying.

Hi folks. The fix for this is included in Atom Nightly (as of Atom Nightly 1.56.0-nightly1, released on the 8th of January), and should be in Atom Beta (1.56) soon. Then Atom stable 1.56.0 some time after that.
(Usually there is about a month or so between new minor releases on each channel).
You can get Atom Nightly here with the fix: https://atom.io/nightly although it's not as stable as Beta or stable releases, and it's possible it might not work so well for a day or two if you leave automatic updates turned on.
Originally posted by @DeeDeeG in https://github.com/atom/atom/issues/17672#issuecomment-774806049

Sorry to say this but I'm on 1.58 MacOS Catalina up to date, and I have this problem as well.

its fixed in atom nightly

Sorry I meant
Atom    : 1.58.0
Electron: 9.4.4
Chrome  : 83.0.4103.122
Node    : 12.14.1

Atom version : 1.60.0
Mac OS : Monterey 12.2.1
Still could not quit Atom with Cmd+Q

This issue still exists in the latest version when run in the latest version of MacOS. This issue should be reopened.

Because of this problem I switch to VS Code. I never looked back. I don’t know why the dev team is ignoring it this tedious bug in Atom while the VS Code team does not have this problem.

Experiencing this too.

authors: 1oo7 Cam ChenTaHung HCLarsen Ronnie-J TheWeirdDodo UziTech ag-coder aminya btangmu captainsham cgeyma dlsoltero dquessenberry drinkdecaf egarpor epam-ocherniavskaia fatihandyildiz fsimonjetz halukakin iamkeir jeff-hykin jeffkimbrel joomlabeat lacostenycoder lra marcocasadio mciarlo mgw-sbex micdonato misterbastean mk347 mncmncmnc mpieropan mtoensing paulbhartzog paulbhartzog-tti phoebe-leong rjalexa sakadalim smdjeff startryst swinggraphics tbuehl therealsaumil


text:
Uncaught Error: spawn /usr/share/atom/atom (deleted) ENOENT

[Enter steps to reproduce below:]

...
...

Atom Version: 0.165.0
System: linux 3.13.0-40-generic
Thrown From: Atom Core
Stack Trace
Uncaught Error: spawn /usr/share/atom/atom (deleted) ENOENT
At events.js:85

Error: spawn /usr/share/atom/atom (deleted) ENOENT
  at exports._errnoException (util.js:742:11)
  at Process.ChildProcess._handle.onexit (child_process.js:1051:32)
  at child_process.js:1142:20
  at process._tickCallback (node.js:378:11)

Commands

Config
{
  "core": {},
  "editor": {}
}

Installed Packages
# User
No installed packages

# Dev
No dev packages

This looks like a duplicate of https://github.com/atom/atom/issues/4505 (so I'm closing this in favor of that issue). Can you try the suggestion from https://github.com/atom/atom/issues/4505#issuecomment-66795073?

authors: gopiariv izuzak


text:
Build error : cannot find module 'walkdir' whole buildings.

Hello , i haven't update Atom.io for long, today i did git pull to  updated from 143 to latest master.
When i tried to ./script/build i get this error.
Loading "index.js" tasks...ERROR

Error: Cannot find module 'walkdir'

Then continue to download-atom-shell task but , it stops after , nothing is printed out.

Can you try running script/clean and then re-running script/build?

having connection problem today so it will take long , but i did that anyways. Waiting for results.

This can typically occur when an npm install is interrupted and only partially completes.
Cleaning and then re-bootstrapping should always fix it, closing this out.


text:
Character positioning/cursor movement breaks with certain emoji characters

Atom 0.190.0, OS X 10.10
Enter some random emoji, such as :ocean::eyes::relieved:, then add :m: to the end, the preceding characters move and overlap and the cursor position gets weird.

Seems to only happen with :m:, but I haven't tried everything.
I think it's something to do with variation selectors. When you enter :m: using the OS X emoji palette, it encodes as e2 93 82 ef b8 8f, or CIRCLED LATIN CAPITAL LETTER M followed by VARIATION SELECTOR 16. If you copy and paste just CIRCLED LATIN CAPITAL LETTER M it works fine.

@postcasio: I have tried to reproduce it outside Atom through this HTML file.
Ⓜ👊🌊🇮🇹

It turns out that emojis are displayed nicely on Safari, whereas they get messed up on Chrome 41.

Safari
Chrome

Our character measurement/positioning system contributes to make things worse, but that's not the cause and, although we need to address it soon anyway, I think this is something that must be fixed at a lower layer (https://code.google.com/p/chromium/issues/detail?id=473703).
Maybe we should move this issue elsewhere? :thought_balloon:
/cc: @kevinsawicki @nathansobo

This is fixed on master via #8811

authors: as-cii benogle postcasio


text:
Old tabs startup

When I start Atom it doesn't remember my most recent open windows but instead shows me 3 tabs from a now very old session.
This also happens when running atom --dev
Mac 10.10.4 Atom 1.0.2

How exactly are you starting Atom? Do you see the problem when you start Atom in safe mode?

@izuzak From Spotlight, from Finder, atom --dev, atom --safe

@larsenwork If you start Atom like that, then it will restore the previous session. If you start Atom like this, then it will use the current directory for the new session: atom .
Can you try that and see if the behavior changes?

No difference. If you read my initial comment you'd see that the issue isn't a previous session being opened but a very old session

If you read my initial comment you'd see that the issue isn't a previous session being opened but a very old session

Your initial comment doesn't really say how you're running Atom, which is relevant, as I explained. Having all the relevant details is helpful for debugging, as I'm sure you'd agree. So let's continue investigating. Did I understand correctly that the same tabs are opened regardless of which folder you run atom . in? Have you tried doing that from several different folders/projects?

Running atom from ~/ (plus launching from Finder + Spotlight): very old (and outdated - i.e. not previous) session
Running atom from a folder: untitled doc + empty tree

Thanks for clarifying, @larsenwork.
I'm having trouble reproducing that behavior. @maxbrunsfeld what am I missing here?

I'm not sure but I think the problem appeared after the computer shut down improperly (empty battery) if that helps.
Anything I can do now to "reset" previous states?

So Atom is reopening the correct folder when you run it from spotlight, but the editor is in an old state? What happens when you just reload Atom (Window: Reload command). Atom attempts to save this state when you exit. How are you quitting Atom?

Hehe...well now it works.
I've had this issue for the last month without being able to fix it (launched it in many different ways, incl. atom --dev, atom --safe View -> Reload and from Finder and using Spotlight).
I normally quit atom using cmd+q but as written above I think this problem started after my computer turned off due to battery 0%.
I've done nothing that can explain why it suddenly works again (no updates, removing packages etc). I simply quit and reopened to be able to answer the folder question by @maxbrunsfeld
Feel free to close it. I'll reopen if it reappears.
Thanks

Ok, if you're interested in diagnosing this if it appears again, you should look at the files in ~/.atom/storage. There's two main things in there: application.json which stores which folders are open, and editor-<some-hash>, which stores the state for a given editor. The name of the editor- file for a given window can be obtained by running this code in the javascript console:
atom.constructor.getStateKey(atom.project.getPaths(), "editor")

These editor-specific files should be updated when quitting Atom.

Ok, then something caused them not to be updated ¯_(ツ)_/¯
I'll look at those files should the problem reappear

authors: izuzak larsenwork maxbrunsfeld


text:
Losslessly optimize all images with imgult.

https://imgult.github.io
Signed-off-by: Ryan P.C. McQuen ryanpcmcquen@member.fsf.org
Description of the Change
All images were losslessly optimized with imgult.
Compare the original size:
355 KB => https://github.com/atom/atom/blob/master/resources/app-icons/beta/png/1024.png

To the imgulted size:
131 KB => https://github.com/ryanpcmcquen/atom/blob/master/resources/app-icons/beta/png/1024.png

Why Should This Be In Core?
It's part of the core.
Benefits
Less disk space used for images that look identical!
Possible Drawbacks
None are obvious.

The contrast/gamma looked off to me - looks a lot flatter - so I ran it through a comparison too at https://huddle.github.io/Resemble.js/

These images are already compressed by Google's zopflipng in #12916

@MaximSokolov yet they were still able to be reduced to less than half of their current size using other tools (including, but not limited to optipng & pngquant). Also, the gif's were not optimized at all ... as far as I can tell.

@damieng is that subtle difference worth the significant difference in file size?

If this were a web image perhaps not but it's part of a 100MB application. 100KB won't make any difference.

@damieng I would argue that the difference between the images here is even more significant:
https://github.com/atom/atom/pull/12916/files
Yet that request was merged.

Not sure why you think the images are different there - they all look the same to me. I ran the same comparison on the green 1024;

The greens are vastly different. Just use any color grabbing tool to see the difference between the greens. The lower bottom portion has two very different greens:
Original:
#189660
Optimized:
#14A674

Also, the lower shadow is more pronounced on the original (to my eyes).

Then I think if anything we should consider reverting that original compression PR rather than letting the icons get more and more faded with each attempt at further compression.

Atom does have some intention of being a web app at some point? Considering the future, perhaps we should consider optimizing the images as much as possible?
That's my take at least, but it is not my call.

For posterity, I imgulted the original images, the savings is the same without using zopflipng:
imgult:

Original:

Zopflipng:

Maybe @simurai could weigh in?

Hmm.. it seems imgult uses dithering for compression, similar to a gif?

Original
zopflipng
imgult

It's probably fine on a website where smaller image sizes have high priority. But yeah, for Atom it's more like a bonus and not that crucial.
@ryanpcmcquen What browser and OS did you use to make a that screenshot? I can't reproduce the "washed out" look in Chrome on macOS for the previous PR:

Maybe it's because zopflipng stripped the color profile?

Actually, these icons in PNG format only get used on Linux. So would be a good idea to test it there if it has any effect.

@simurai, thanks for the response. I'm on GNU/Linux (FreeSlack 14.2) but can also reproduce on Mac using the 'Generic RGB Profile'.

If I switch to "Generic RGB Profile" I can see the whole monitor change, but not the right icon.
ok, I would say we don't merge this one and consider reverting #12916 if more people can confirm the ☝  above issue. Otherwise keep the happy medium.
@ryanpcmcquen Thanks for the PR nonetheless. ❤

@simurai I would not call it a happy medium, the zopflipng version looks the worst of the 3 on my monitors.

Made a new issue https://github.com/atom/atom/issues/13672 to ask for confirmation.

I feel like using a flat solid color would look and optimize better, I know beaty is a matter of taste, but minimal icons also scale much better. color #34b17b seems to preserve the visual identity and look great. what do you guys think?

For reference, here is what those look like imgulted:

Each of them are about ~53 KB!

Yeah, a more flat icon would compress much better, but as already said, for Atom's use case, it's not the highest priority.
We'll definitely redesign the icon with the next major version of Atom, although there aren't currently any plans when that will happen.

authors: HUN73R13 MaximSokolov damieng ryanpcmcquen simurai


text:
Fix rowRangeForParagraphAtBufferRow using \S -- Round two

This is a version of #6050 that handles all cases and passes the specs. cc @seansay
Closes #6050
Closes #5963

:clap:

authors: benogle seansay


text:
electron-installer not atom-shell-installer

<3

Thanks!

authors: geelen zcbenz

repo: atom/electron


text:
use alt, not option

Option is only on OS X.

For reference: https://github.com/atom/electron/issues/402

👍

authors: zcbenz zeke


text:
Support old-style MacOS CR line terminators

Yes, it's horrible, but there are modern, badly behaved OS X programs that output things with CR line terminators, like LiveCode. This package behaves abysmally when it runs into one of these files, and cannot convert to either CRLF or LF.

I believe this was fixed by https://github.com/atom/line-ending-selector/pull/11.

authors: alexchandel maxbrunsfeld

repo: atom/line-ending-selector


text:
Slash commands in document editor

User presses /, show the slash followed by a popout with a bunch of searchable commands
These should ideally be pluggable
On pressing enter, select the command

Questions:

Should we allow / commands only at the start of an element, or do we allow it inside elements? If we allow inside, we could use turn into commands, like silver bullet. However, it might make things more complex.

Some ideas for commands:

Header levels. Turns current line into header, or creates new line with header
Upload file(s). Opens native file picker.
Link to (new) resource. Searches resources.
Create table, sese #267
Create ChatBox / ChatRoom
Embed youtube / spotify link (or other pluggable embed things)
Create task

@Polleps do you have some extra ideas on this?

repo: atomicdata-dev/atomic-data-browser


text:
Narrow content and children types

I believe #18 was merged too hastily. React.ReactNode isn't the correct type to use here because it disagrees with how propTypes are defined. Using React.ReactNode allows for invalid code such as this:
<>
  <Tippy content={null}>
    <div />
  </Tippy>
  <Tippy content="foo">
    {null}
  </Tippy>
</>

The second Tippy element here will fail at runtime.

Thanks! Relying on the the community for this one because I'm not experienced with TypeScript to understand this myself

To clarify, the ReactNode type definition is a union type which has null and why null would be allowed in TypeScript if it was typed as ReactNode. If the propTypes were PropTypes.node instead of PropTypes.element then they would be equivalent but that's not the case here.

authors: atomiks martensm


text:
Add GenServer Elixir module

A limited number of function of this module should be chosen and implemented.
An issue for each group of related functions should be opened.

A gist for GenServer.ex is here https://gist.github.com/petermm/1c5eda55bbd024c4f1f331e23222b360 pending https://github.com/atomvm/AtomVM/pull/1176
copy/pasted from Elixir source and adapted. will document steps better, out-commented code left in there intentionally..

:gen module is not available, so calling :gen_server instead
no distributed erlang

more than likely something missing and or completely wrong at the moment.. will look into getting a test suite running.

authors: bettio petermm

repo: atomvm/AtomVM


text:
Make dialyzer optional

Do not require dialyzer, skip PLT build in case dialyzer has not been found.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

Friendly amendment:
Please add a .gitignore to AtomVM/src/platforms/esp32/test with the following contents:
build/*

authors: bettio fadushin


text:
getting this error during installation

manage_auto_update:24: no such file or directory: /Users/shammah/.axiom/interact/includes/.auto_update
Auto-update has been enabled.
Configuring your cloud account...
/dev/fd/11:626: no such file or directory: /Users/shammah/.axiom/interact/axiom-account-setup
ls: /Users/shammah/.axiom/axiom.json: No such file or directory
Adding axiom_rsa key to Packer builder
/dev/fd/11:634: no such file or directory:
mv: rename /Users/shammah/.axiom/tmp.json to : No such file or directory
/dev/fd/11:635: no such file or directory: /Users/shammah/.axiom/configs/authorized_keys
Beginning first packer build...
/dev/fd/11:683: no such file or directory: /Users/shammah/.axiom/interact/axiom-build
You may need to restart your shell: /bin/zsh

Hey @zealsham, how did you install? Can you rm $HOME/.axiom and try again using the easy install oneliner?
https://ax-framework.gitbook.io/wiki/overview/installation-guide

ive done that severally and no avail

Your Packer provosioner must be located in /Users/shammah/.axiom/images/pkr.hcl/provisioners/. Make sure to move it
meanwhile the docs says
Custom Provisioners: All Provisioners need to be stored in ~/.axiom/images/provisioners/ and should end with.json

@zealsham

ive done that severally and no avail

What OS are you using (Mac? What version?) and how are you installing? Your original post showed errors that indicate to me that ax wasn’t installed correctly. All the missing files etc. You’ll have to make sure ax configure runs without issue before building will succeed.
If all else fails, try installing in a docker container with the docker install one liner we have in the readme or spin up a fresh Ubuntu 24.04 on any cloud provider and install the controller on that.

Your Packer provosioner must be located in /Users/shammah/.axiom/images/pkr.hcl/provisioners/. Make sure to move it
meanwhile the docs says
Custom Provisioners: All Provisioners need to be stored in ~/.axiom/images/provisioners/ and should end with.json

yes I’ll fix this in the documentation. Now that we support both JSON and HCL Provisioners, your provisioner will either have to be in $HOME/.axiom/images/pkr.hcl/provisioners/ for pkr.hcl or $HOME/.axiom/images/json/provisioners/for JSON. I’ll make sure to change that in the wiki. Thanks! But before you get this far, you have to make sure ax configure worked without issue and your cloud account properly configured. Feel free to join our discord as well.

Closing this issue. If you are still experiencing problems, lmk.

repo: attacksurge/ax


text:
Create First Pages

Background
We will need to create the pages which will support our application. These can grow or change over time, but this should give us runway to work and offer a solid MVP of the site.
Detail
So far, the list of pages we know we want are:

Home page
Course detail page

We want these as components which are exported and routable.
Requirements
R1: The home page component is created
R2: The course detail page is created

@Brobb954 I think we can move this one to done with the work you've now merged into dev, what do you think?

Makes sense to me

repo: auburnonlinecs/reviews-fe


text:
Changed iOS recorder sliders to AKproperty sliders.

Also a couple small changes on some playgrounds

You really don't want to include the binary framework in your commits here...

Sadly I can't accept this pull  request because it includes a ton of files you accidentally added to your github repo.  You'll probably have to re-clone AudioKit, but I will try find the changes you made and pull those in so they are not lost.

I made your playground changes, but it is going to be a little hard to get your example project changes in there.  I'll clone your repo and see if I can copy the important files.

authors: aure esimonian megastep

repo: audiokit/AudioKit


text:
Width of demo content is not correct

In the auto complete sample (customizing templates for example), the width of the autocomplete control is not equal to the width the autocomplete has in the telerik sample. Not sure why
ours

Telerik's

@adriatic can you check this out?

It has to be the consequence of our a bit inconsistent use of KendoUI "classes" (css files)

Can't find the cause though, as the divs are correct

authors: JeroenVinke adriatic


text:
withDefault headers Content-Type problem

Hi,
I get some problem for put in the headers a content-type.
This example work fine :
var myHeaders = new Headers();
myHeaders.append('Content-Type', 'application/json;charset=UTF-8');
this.http.configure(config => {
    config.withBaseUrl(url)
  }).fetch('/method', {
      method: "post",
      headers: myHeaders,
      body: data
    });

But when i try to use the withDefaults method the content-type is ignored :
this.http.configure(config => {
              config.withBaseUrl(url)
                    .withDefaults({method: 'POST', headers: {'Content-Type': 'application/json;charset=UTF-8'}, body: data})
        }).fetch('/method');

And like you see with method withDefaults we can't use Headers object because :
Uncaught Error: Default headers must be a plain object. in aurelia-fetch-client.js:96

Thanks
Cali03

Hi @Cali03. In your example what is the data object you're passing for the request body?

Hi,
Data is Json Object Stringyfied.

repo: aurelia/fetch-client


text:
feat(project): lint unit specs also

linting unit specs makes it easier to find bugs your specs

@bas080 Thank you for contributing this pull request! We're truly excited and honored to have you as a member of our community. We look forward to working together with you to further build the Aurelia platform.
We noticed that you haven't yet signed our CLA. We would appreciate it if you would consider doing that for us. Before signing, please take a few minutes to read our contributing guidelines. These guidelines will help get you up to speed on how our community likes to operate and how the pull request process works. Once you have read that, assuming you are in agreement, simply sign our online CLA.
After you've signed, please ping this issue to let us know and we'll get your improvements merged in.
Thank you again!
The Aurelia Team

@bas080 A note for the future: linting is not a "feature" per se, so the commit should read something like: style(build): lint unit specs according to the conventional commit messages.

Closing this since we don't have a CLA signature after over a month.

authors: EisenbergEffect bas080 niieani

repo: aurelia/skeleton-plugin


text:
Sample app does not run after following instructions

The sample app does not run after following the instructions.  There is no gulp start - I used gulp serve . The version of font-awesome referenced in index.html is wrong.  Fixed that, but the app cannot find dist/main.js - it does not appear to be getting built anywhere.  Maybe it does work, but then the instructions need to be clearer.

http://localhost:3001/dist/main.js Failed to load resource: the server responded with a status of 404 (Not Found)
Error: Error: XHR error (404 Not Found) loading http://localhost:3001/dist/main.js
Error loading http://localhost:3001/dist/main.js

Ah - there is a gulp build-sample - ran that, built the dist/main.js - app still fails to start, can't find aurelia-validation@0.7.0.js

Failed to load resource: the server responded with a status of 404 (Not Found)
undefined:1 Uncaught (in promise) Error: Error: XHR error (404 Not Found) loading http://localhost:3001/jspm_packages/npm/aurelia-validation@0.7.0.js(…)
http://localhost:3001/jspm_packages/npm/aurelia-validation@0.7.0.js Failed to load resource: the server responded with a status of 404 (Not Found)

Getting closer...

Duplicate of #20

https://github.com/aurelia/validatejs/commit/c77f3693587a607393e73a90f01f5c39f53084f6

I'll keep that other issue open until it is fixed my bust

authors: PWKad stevies

repo: aurelia/validatejs


text:
NullReferenceException in iOS on client.LoginAsync();

I define my client as follows:
Auth0Client client = new Auth0Client(
new Auth0ClientOptions
{
Domain = ConstantsData.Auth0Domain,
ClientId = ConstantsData.Auth0ClientId
}
);
var loginResults = await client.LoginAsync();
The System.NullReferenceException happens here. If I mouse over client, it clearly was defined and has data. Below is my Stack Trace as requested but I don't see how that well help you one bit.
[External Code]

0x76 in CoachingApp.iOS.HomeViewController.InitLogin at C:\Users\joshua.tanton\Documents\Projects\CoachingMobileApp\Coaching.iOS\HomeViewController.cs:316,17	C#
0x372 in CoachingApp.iOS.HomeViewController.ViewDidLoad at C:\Users\joshua.tanton\Documents\Projects\CoachingMobileApp\Coaching.iOS\HomeViewController.cs:486,5	C#
0x8 in CoachingApp.iOS.Application.Main at C:\Users\joshua.tanton\Documents\Projects\CoachingMobileApp\Coaching.iOS\Main.cs:12,6	C#

The crash is clearly happening on external code (Auth0 code). This was working fine until two days ago. I downgraded to 1.0 and it still gave me this issue, I'm back on 2.1 now.

This was working fine until two days ago.

Can you think of anything in your environment that has changed? I am not trying to shift blame, but I need to somehow try and track down the root cause. You are right, that stack trace will not help much :(
Any info you can give will be helpful.
Are you running this on a device or an emulator? Which device / emulator? Which iOS version? etc.....?

I've just looked into client->non-public members->_options and found the following values set to null
Browser
ClientSecret
RedirectUri
But according to the documentation you don't need to set these. I definitely have the correct ID and Domain set

iPhone 7

Device or emulator? Please be specific. What about the iOS version?

Sorry, Device. 11.4

OK, I will give attention to this next week. It is 11 PM on a Friday over here.
Thanks for the info so far.

OK, I'll let you know if I solve the issue.

Looks like I figured it out. I went back through my git and saw after my colleague had merged with my code I had to change some iOS properties to get it to build (specifically supported Architectures). Looks like I had also changed Linker Behaviour to Link All. I was working on Droid after merging with him so it was back a few commits. Switched back to iOS and this bug was happening. So I switched the linker behaviour back to Link Framework SDKs Only. It now does not have this problem.
Thanks for the help.

This is great information and detective work, thank you @joshuatantonflynn
I will work with this information and see whether I can reproduce, and if so, I will update the docs accordingly to make users aware of this. Or perhaps see whether I can avoid the Linker removing the relevant code.

authors: jerriep joshuatantonflynn


text:
Getting Unknown Error with Login and Error processing password resets

Hello, having an issue where it returns "Unknown Error" in the lock.  I am not able to authenticate and login to my site.
Some background:

I am saving user information in a sql server database
In autho I have setup the database with the sql azure database scripts.
I am certain the database connection is correct as I can create users from my app.
I have setup the script debugging and access wt-cli from my devbox
my callback is set in both the config file and the auth0 portal to http://localhost:5000/account/profile (I have profile under the account controller and 5000 is my port)

HOWEVER:

I cannot login - it gives me an "unknown error".  It runs the debug script output but it does not seem to be giving any helpful info.  Any guidance is appreciated
I cannot reset password from the app (I can do it from the portal "try" button)  When I try to reset a password from the app it says "There was an error processing the password reset" and does not seem to be trying to go back to auth0.  The debug script has no activity.

Any help/insights is greatly appreciated.

Hi @drewid, this seems to be an issue related to your custom database script or to your callback URL configuration. I suggest you send a mail to support@auth0.com or reach out on chat.auth0.com

authors: drewid sandrinodimattia


text:
Improve header UI

[ ] Reduce the size of the Gravatar.
[ ] Update background blur so it looks more like the original design.

Just making the Gravatar smaller won't do, other dimensions need to be updated. We'll need help from someone from design.


text:
WP-Auth0 V4

Lets create small PRs (one for each change) for this release in a new branch (4.x.x-dev).
This version will focus in P2 and no legacy features will be supported.

Priority

[ ] We should support HS and RS signed tokens. For RS we should be able to fetch the public key from the jwks.json endpoint.
[ ] We should support both, hosted login page and embed lock (configurable in the settings page).
[ ] For embed lock, it should use the oidcConformant flag and use the flow that posts the id_token to the backend (implicit flow)
[ ] For hosted login page, we should support both, response type code and form_post
[ ] We should support the following parameters as first class settings: audience, scope (configurable in the basic tab)

[ ] Configuration wizard: it should use the new pipeline (without the /i path if available with auth0.auth0.com)
[ ] The scopes requested during the configuration wizard should be enough to create a non interactive client and grant access to the required scopes for the management api RS.
[ ] For offline flow it should request the client_id and secret and explain how to manually create it instead of asking for a token.
[ ] We should change when it does api calls to fetch the api token through client credentials grant. It should store the token and the expires in attribute in order to know when it should fetch a new token (it should never decode the access token)

[ ] We should start cleaning up some flows. WIth this changes we can start working on rewrite the LoginManager and the configuration wizard.

A couple of suggestions:

it might be nice to start building an e2e test suite.  Something that uses selenium to walk through the flows.   It would have to run against vagrantpress so might not be able to build it into CI, but it would help :).

I could create an extension for offline setup that would create the management API client with the right scopes.  I did that for the deploy CLI.  It is pretty simple.  Then the instructions would just show them how to install that extension.

yes but not sure if really usefull. Also to run it in the CI, we need to use saucelabs and vagrantpress wont work for this. We need some hosted site (pantheon is an option, where we can push code via git). Anyway, starting with some unit tests might be more valuable (testing how we build lock options, testing the login handler, etc

good idea. At some point I started thinking about using an extension for the entire thing. It can ask you for the site url, it will ping it to get some info (name, etc) and set up everything in auth0. This way we get rid of the issues with custom routes and the web server url rewrites. It can end up exporting a json file that needs to be imported in the plugin (already has that feature).

Unit tests first is a good idea. The main idea with the e2e tests is that
it will give us a way to test with new versions of Wordpress and
woocommerce so we ensure we didn't get broken by them... I agree it would
be a pain to get it into CI. So let's start with unit and go from there.
For extensions that could work too, and this first version could lay the
groundwork. My only concern would be with versioning. The nice thing about
most of the logic in the plugin is that it's been tested against that
version of the plugin.
On Thu, Feb 2, 2017 at 08:03 Germán Lena notifications@github.com wrote:

yes but not sure if really usefull. Also to run it in the CI, we need
to use saucelabs and vagrantpress wont work for this. We need some hosted
site (pantheon is an option, where we can push code via git). Anyway,
starting with some unit tests might be more valuable (testing how we build
lock options, testing the login handler, etc
2.
good idea. At some point I started thinking about using an extension
for the entire thing. It can ask you for the site url, it will ping it to
get some info (name, etc) and set up everything in auth0. This way we get
rid of the issues with custom routes and the web server url rewrites. It
can end up exporting a json file that needs to be imported in the plugin
(already has that feature).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/auth0/wp-auth0/issues/282#issuecomment-276965030, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACheriU2TCjnjue4Cbm2Octcz22DslyZks5rYeHxgaJpZM4L1DOp
.

--
Carlos Mostek
Customer Success Solution Architect
cell: +1 612-247-6537
email: carlos.mostek@auth0.com
https://www.auth0.com

Any updates?

Configuration changes moved to #408.
Universal login page support is coming soon, will be released right after 3.6.0 so SSO users.
"We should support the following parameters as first class settings: audience, scope (configurable in the basic tab)" - Not sure if these should be settings or filters. Scope filter coming in 3.6.0 at least.
Initial configuration change, profile management, and general cleanup will be the focus of 4.0.0. Roadmap looks like:

3.6.0 - almost feature complete, currently being tested
3.6.1 - minor code quality and any 3.6.0 clean-up
3.7.0 - Universal login page for SSO
4.0.0 - Profile management and improved setup

authors: gjsman glena joshcanhelp mostekcm


text:
Fix wrong response_type parsed when missing response_mode

What does this PR do?
The original code incorrectly read configured default respone_mode value into a variable holding response_type value. This causes OAuth2 requests without response_mode passed via URL query parameter to fail, because response_type value will then be filled with illegal value.
Which issue(s) does this PR fix?
There's no issue at this point. I was testing integration with Memos and found this coding typo. Their SSO implementation does not pass response_mode, thus resulting in error.
If this PR affects any API reference documentation, please share the updated endpoint references
There's no API change.

@lakhansamani Please kindly review this PR and release a new version soon, thanks.

Thanks @JokerQyou for the contribution

@JokerQyou released as part of 1.1.52 (https://github.com/authorizerdev/authorizer/releases/tag/1.1.52)

authors: JokerQyou lakhansamani

repo: authorizerdev/authorizer


text:
set fill value to max of full dataset + 1

Hello, I'm somewhat new to this repo 👋 .
It looks like if the global max is in not in the current cross_validation split,  using X[train_indices] would lead to different fill values in different CV splits. My impression is that this is undesired, but correct me if I am wrong.
Similarly, all_nan_columns should be the same across all CV splits, I think?

Hi there,
I believe the idea was that if NaNs occur for a feature in the validation set but not the train set, we can still train on the train set with that feature (in particular for .refit). However, this might through errors when trying to validate so I also think this is cleaner.

authors: LMZimmer jonathanburns

repo: automl/Auto-PyTorch


text:
Configuration for duplicate class detection

The output for buildHealth is spammed with warnings for duplicate classes. This is output for each module:
  Warnings
  Some of your classpaths have duplicate classes, which means the compile and runtime behavior can be sensitive to the classpath order.

  Source set: devDebug
  \--- compile classpath
       \--- org/jetbrains/annotations/NotNull is provided by multiple dependencies: [com.android.tools.layoutlib:layoutlib:14.0.11, org.jetbrains:annotations:23.0.0]
  \--- runtime classpath
       \--- org/jetbrains/annotations/NotNull is provided by multiple dependencies: [com.android.tools.layoutlib:layoutlib:14.0.11, org.jetbrains:annotations:23.0.0]

  Source set: devRelease
  \--- compile classpath
       \--- org/jetbrains/annotations/NotNull is provided by multiple dependencies: [com.android.tools.layoutlib:layoutlib:14.0.11, org.jetbrains:annotations:23.0.0]
  \--- runtime classpath
       \--- org/jetbrains/annotations/NotNull is provided by multiple dependencies: [com.android.tools.layoutlib:layoutlib:14.0.11, org.jetbrains:annotations:23.0.0]

which makes it really hard to find other errors. In the example above I filed issues with the relevant parties, and now I don't want to see the warnings while I wait for it to get resolved.

Thanks for the issue! I am aware this is a gap in the issues handler configuration. This gap will be closed soon.

authors: autonomousapps eygraber


text:
about your trained model.

about the trained model you provided, "model_seed1_39.pth",  "model_seed2_39.pth",  "model_seed3_37.pth"
what's mean the seed?
when I try to test loca_evaluation, must be used all three model files?

We trained each model 3 times with different random seeds to build an ensemble.
The seed in the name of the file is just an index for the training run (e.g. seed 1 is the model from training run 1, etc.).
The 39 / 37 denote the epoch used.
If you want to reproduce the numbers in the main table you should use all 3 models, yes.
You just need to place them in the same folder and the code will automatically load all three models and average their predictions.

Thx for your reply.
I have one more question.
What is the train set used to make the model you offered?
is that "left ll lr right rl rr s1 s3 s4 s7 s8 s9 s10" total 13 zip files that I can download?

repo: autonomousvision/transfuser


text:
Update Duo Desktop.munki.recipe

Hi, @keeleysam
Sorry accidentally closed https://github.com/autopkg/keeleysam-recipes/pull/167
The current preinstall script will fail if the directory /Library/Application Support/Duo/Duo Device Health isn't there.
touch: /Library/Application Support/Duo/Duo Device Health/DisableMacOS11CertManagement: No such file or directory
This PR updates it so that it creates the path if it's not already present.

I've also taken the opportunity to enhance the Installs Array creation by using MunkiInstallsItemsCreator to build it from the App bundle with support for derive_minimum_os_version
Output from a successful verbose run
autopkg run -v Duo\ Desktop.munki.recipe
Looking for com.keeleysam.recipes.download.DuoDesktop...
Did not find com.keeleysam.recipes.download.DuoDesktop in recipe map
Rebuilding recipe map with current working directories...
Looking for com.keeleysam.recipes.download.DuoDesktop...
Found com.keeleysam.recipes.download.DuoDesktop in recipe map
**load_recipe time: 0.0039040000001477893
Processing Duo Desktop.munki.recipe...
WARNING: Duo Desktop.munki.recipe is missing trust info and FAIL_RECIPES_WITHOUT_TRUST_INFO is not set. Proceeding...
URLTextSearcher
URLTextSearcher: Found matching text (version): 6.0.0.0
URLDownloader
URLDownloader: Storing new Last-Modified header: Tue, 31 Oct 2023 13:09:34 GMT
URLDownloader: Storing new ETag header: "e3281bd428336b6017b7c4cc23b97c3e"
URLDownloader: Downloaded /Users/paul.cossey/Library/AutoPkg/Cache/com.keeleysam.recipes.munki.DuoDesktop/downloads/DuoDesktop-6.0.0.0.pkg
EndOfCheckPhase
CodeSignatureVerifier
CodeSignatureVerifier: Verifying installer package signature...
CodeSignatureVerifier: Package "DuoDesktop-6.0.0.0.pkg":
CodeSignatureVerifier:    Status: signed by a developer certificate issued by Apple for distribution
CodeSignatureVerifier:    Notarization: trusted by the Apple notary service
CodeSignatureVerifier:    Signed with a trusted timestamp on: 2023-10-30 16:30:57 +0000
CodeSignatureVerifier:    Certificate Chain:
CodeSignatureVerifier:     1. Developer ID Installer: Duo Security LLC (FNN8Z5JMFP)
CodeSignatureVerifier:        Expires: 2027-02-12 17:19:45 +0000
CodeSignatureVerifier:        SHA256 Fingerprint:
CodeSignatureVerifier:            C6 C7 63 E5 7A 64 92 6E 47 63 68 4E 16 36 F2 EB EF F9 92 63 BF 58
CodeSignatureVerifier:            03 B3 9F E7 72 BB 86 97 61 08
CodeSignatureVerifier:        ------------------------------------------------------------------------
CodeSignatureVerifier:     2. Developer ID Certification Authority
CodeSignatureVerifier:        Expires: 2031-09-17 00:00:00 +0000
CodeSignatureVerifier:        SHA256 Fingerprint:
CodeSignatureVerifier:            F1 6C D3 C5 4C 7F 83 CE A4 BF 1A 3E 6A 08 19 C8 AA A8 E4 A1 52 8F
CodeSignatureVerifier:            D1 44 71 5F 35 06 43 D2 DF 3A
CodeSignatureVerifier:        ------------------------------------------------------------------------
CodeSignatureVerifier:     3. Apple Root CA
CodeSignatureVerifier:        Expires: 2035-02-09 21:40:36 +0000
CodeSignatureVerifier:        SHA256 Fingerprint:
CodeSignatureVerifier:            B0 B1 73 0E CB C7 FF 45 05 14 2C 49 F1 29 5E 6E DA 6B CA ED 7E 2C
CodeSignatureVerifier:            68 C5 BE 91 B5 A1 10 01 F0 24
CodeSignatureVerifier:
CodeSignatureVerifier: Signature is valid
FlatPkgUnpacker
FlatPkgUnpacker: Unpacked /Users/paul.cossey/Library/AutoPkg/Cache/com.keeleysam.recipes.munki.DuoDesktop/downloads/DuoDesktop-6.0.0.0.pkg to /Users/paul.cossey/Library/AutoPkg/Cache/com.keeleysam.recipes.munki.DuoDesktop/unpacked
PkgPayloadUnpacker
PkgPayloadUnpacker: Unpacked /Users/paul.cossey/Library/AutoPkg/Cache/com.keeleysam.recipes.munki.DuoDesktop/unpacked/DuoDesktop.pkg/Payload to /Users/paul.cossey/Library/AutoPkg/Cache/com.keeleysam.recipes.munki.DuoDesktop/Applications
MunkiInstallsItemsCreator
MunkiInstallsItemsCreator: Created installs item for /Applications/Duo Desktop.app
MunkiInstallsItemsCreator: Derived minimum os version as: 10.15
MunkiPkginfoMerger
MunkiPkginfoMerger: Merged {'installs': [{'CFBundleIdentifier': 'com.duosecurity.duo-device-health', 'CFBundleName': 'Duo Desktop', 'CFBundleShortVersionString': '6.0.0.0', 'CFBundleVersion': '6.0.0.0', 'minosversion': '10.15', 'path': '/Applications/Duo Desktop.app', 'type': 'application', 'version_comparison_key': 'CFBundleShortVersionString'}], 'minimum_os_version': '10.15'} into pkginfo
MunkiImporter
MunkiImporter: Using repo lib: AutoPkgLib
MunkiImporter:         plugin: FileRepo
MunkiImporter:           repo: /Users/Shared/munki_repo
MunkiImporter: Copied pkginfo to: /Users/Shared/munki_repo/pkgsinfo/apps/Duo Desktop/Duo Desktop-6.0.0.0.plist
MunkiImporter:            pkg to: /Users/Shared/munki_repo/pkgs/apps/Duo Desktop/DuoDesktop-6.0.0.0.pkg
PathDeleter
PathDeleter: Deleted /Users/paul.cossey/Library/AutoPkg/Cache/com.keeleysam.recipes.munki.DuoDesktop/unpacked
PathDeleter: Deleted /Users/paul.cossey/Library/AutoPkg/Cache/com.keeleysam.recipes.munki.DuoDesktop/Applications
Receipt written to /Users/paul.cossey/Library/AutoPkg/Cache/com.keeleysam.recipes.munki.DuoDesktop/receipts/Duo Desktop.munki-receipt-20231108-100807.plist

The following new items were downloaded:
    Download Path
    -------------
    /Users/paul.cossey/Library/AutoPkg/Cache/com.keeleysam.recipes.munki.DuoDesktop/downloads/DuoDesktop-6.0.0.0.pkg

The following new items were imported into Munki:
    Name         Version  Catalogs    Pkginfo Path                                Pkg Repo Path                            Icon Repo Path
    ----         -------  --------    ------------                                -------------                            --------------
    Duo Desktop  6.0.0.0  production  apps/Duo Desktop/Duo Desktop-6.0.0.0.plist  apps/Duo Desktop/DuoDesktop-6.0.0.0.pkg

Hi, @keeleysam
Anything I can do to help get this merged? We've been running the changes in this PR as temp recipe for a while now with no issues.
Thanks!

repo: autopkg/keeleysam-recipes


text:
build(perception_online_evaluator): add lanelet_extension dependency

Description

This PR adds a dependency to lanelet2_extension to fix a missing include.
Tests performed

Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kosuke55 no problem, thanks for the quick review :slightly_smiling_face:


text:
feat(tier4_autoware_api_launch)!: remove deprecated api

Description
Related links

https://github.com/autowarefoundation/autoware/pull/5011
https://github.com/tier4/tier4_ad_api_adaptor/pull/123

How was this PR tested?
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

Instead of removing the entire repository, just remove the API related to autoware_auto messages.
https://github.com/tier4/tier4_ad_api_adaptor/pull/124


text:
trajectory planning module

Thanks for making this project open source. I have learned a lot from the code.
Now I am studying the lattice trajectory generating code, is there any published paper from the code? or is this approach based on some other's work? Can I have the paper title?
Thanks :)

got answered, thanks!

I am studying Lattice based trajectory generation as well. Could you please let me know the reference paper used for implementation in Autoware. @yyuuliang Would appreciate your help here.

I am studying Lattice based trajectory generation as well.  When I read the "lattice_planner" algorithm, I am not very clear about the origin of some formulas involved in "libtraj_gen.cpp". According notes, for example: Thomas howard's discrimination Page 38, these equations can be found in McNaughton, page 76 and compute next command from Howard page 39,......I think these formulas may come from a book or material. Could you please let me know the reference paper used for implementation in Autoware. @yyuuliang Would appreciate your help here

repo: autowarefoundation/autoware


text:
Changed nord.js to fit the Nord theme palette

I changed a few colors to fit the exact Nord theme palette.
I changed the code block theme to Monokai.
I was unable to create a screenshot of the main and update it but if you intend to accept this PR, I will find a way

I don't get why the test failed :thinking: It seems to be related to the test's configuration and not the changes I made

Hello! Sooo sorry about how late i'm getting back to you on this 🙏
The repo had been left unmaintained for a long while but i'm trying to update the versions and tests to have things working properly again, as for the screenshot, we could have your PR merged first and I will make a separate PR to add an updated screenshot with the new colors you added :)


text:
Atom.Object.defineProperty.get is deprecated.

atom.workspaceView is no longer available.
In most cases you will not need the view. See the Workspace docs for
alternatives: https://atom.io/docs/api/latest/Workspace.
If you do need the view, please use atom.views.getView(atom.workspace),
which returns an HTMLElement.
Atom.Object.defineProperty.get (/usr/local/share/atom/resources/app/src/atom.js:54:11)
Object.activate (/home/aramis/.setup/atom/packages/atomic-emacs/lib/atomic-emacs.coffee:30:9)

This should now go away with the latest version.

authors: aramiscd avendael

repo: avendael/atomic-emacs


text:
Created Network troubleshooter as per issue #457

Description
Created a CLI based Network troubleshooter as per issue #457
Fixes #457
Replace issue_no with the issue number which is fixed in this PR
Have you read the Contributing Guidelines on Pull Requests?

[x] Yes
[ ] No

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] Documentation Update

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[ ] My documentation follows Template for README.md
[ ] My changes generate no new warnings
[ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

@santushtisharma10 @tamanna-verma @antrikshmisri

authors: geekymeeky kaustubhgupta

repo: avinashkranjan/Amazing-Python-Scripts


text:
Add Audio-Converter directory into the project. (Updated)

Description

I've added a new directory to the folder named "Audio-Converter", added content to the README file and added a demo folder that contains a demo video and its equivalent audio file.
Modules used are:

moviepy
sys

Fixes #321
Closes #321
Have you read the Contributing Guidelines on Pull Requests?

[x] Yes
[ ] No

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] My documentation follows Template for README.md
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

Hey! @kaustubhgupta @avinashkranjan !
I've pushed an update to the directory. The script now accepts any kind of video format as input and generates it's equivalent audio file.
Please have a look and let me know if it needs any further fixes.

Hey @kaustubhgupta @avinashkranjan !
I've pushed an update to the directory. The script now accepts any kind of video format as input and generates it's equivalent audio file.
Please have a look and let me know if it needs any further fixes.

Updated Your Issue Kindly Make the asked changes

@kshittijagrawal if you don't update this PR before 3 pm today, this issue will be assigned to the next person, and this PR closed

@kaustubhgupta apologies for the delay.. was a bit occupied issue #56
will it be fine if I make a PR by tomorrow?

@kaustubhgupta apologies for the delay.. was a bit occupied with issue #56
will it be fine if I update the PR by tomorrow?

Okay, no worries, just try to make it by tomorrow max

Please have a look @kaustubhgupta

@kshittijagrawal updates on this?

@kshittijagrawal PR closed due to no response from your side.