text:
Exclude lombok generated code from jacoco coverage report

Description
Exclude lombok generated code from jacoco coverage report for more accurate result
Issues Resolved
N/A
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #268 (d86c0cd) into main (49565b2) will decrease coverage by 0.15%.
The diff coverage is n/a.

:exclamation: Current head d86c0cd differs from pull request most recent head ef7937c. Consider uploading reports for the commit ef7937c to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main     #268      +/-   ##
============================================
- Coverage     85.14%   85.00%   -0.15%
+ Complexity      379      355      -24
============================================
  Files            52       52
  Lines          1185     1160      -25
  Branches         98       98
============================================
- Hits           1009      986      -23
  Misses          135      135
+ Partials         41       39       -2

see 12 files with indirect coverage changes

Is it required for 2.x?

Better to have it in 2.x as well.

repo: opensearch-project/geospatial


text:
Prevents future UT build issues addresses #2967

Description
Depending on the GitHub CI workflow executes it will invoke ./gradlew build which will run tests on random parameters every time, there are local-code's that will break a build one of them being az-Cyrl. The solution here was preventing (by explicitly writing the local to be set to en-US) Github actions building on these random parameters that will interrupt a build and lose time. Manual testing was done to prove that using this flag breaks a build, you can check the issue #2967 or you can run (locally) ./gradlew build -Dtests.local=az-Cyrl to see it breaks
TLDR:

This one line change prevents future build fails by manually changing the local code to avoid UT build failures on  -Dtests.locale=az-Cyrl if you get unlucky with that randomized build parameter

Related Issues
Resolves #2967
Check List

[X] New functionality includes testing.
[X] Commits are signed per the DCO using --signoff.
[X] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Update: this is the specific bug location, but as noted above you should fix all of them.
https://github.com/opensearch-project/ml-commons/blob/6a6cac13ee1a009ea43a3bad147059578d2adc38/common/src/main/java/org/opensearch/ml/common/connector/ConnectorAction.java#L211

This seems like the wrong fix for the issue.
There's clearly a locale-based bug somewhere but instead of fixing it you're ignoring it for the entire build, even for tests unaffected by the issue. This would miss issues such as #1734
All of the failing tests in the linked issue are in the RestMLPredictionActionTests class, so if those tests require en-US locale that should be scoped only to those tests.
However, locale based bugs are very frequently using upper- or lower-case string transformations. This line has a toUpperCase() transformation without a locale and is very likely the bug that needs fixing by adding Locale.ROOT. (There may be others.)
https://github.com/opensearch-project/ml-commons/blob/6a6cac13ee1a009ea43a3bad147059578d2adc38/plugin/src/main/java/org/opensearch/ml/rest/RestMLPredictionAction.java#L132
A brief search of the entire repo shows several similar potential locale issues, you should probably fix them all!

https://github.com/search?q=repo%3Aopensearch-project%2Fml-commons touppercase()&type=code
https://github.com/search?q=repo%3Aopensearch-project%2Fml-commons+tolowercase()&type=code

If you want to go a step further, converting a string by upper/lower casing just for a comparison is inefficient as it creates a whole new string object which is immediately discarded. If done frequently this adds to the heap/GC load. Use .equalsIgnoreCase() when you can to avoid this extra object creation.

Hey Dan! Thanks for the insight, I agree with you I did feel skeptical making the change Ill get to work with updating the string methods to use Local.ROOT

Thanks for making the changes.

LGTM Someone should probably do an org-wide search for these. :)
(Edit: just did 172 of them! Holy cow!)

Thanks Dan, can you create issues in the impacted repos ?

LGTM Someone should probably do an org-wide search for these. :)
(Edit: just did 172 of them! Holy cow!)

Thanks Dan, can you create issues for the impacted repos ?

Yep, sometime next week.   Filtering to just Java files it's only 66.

source: gharchive/pull-request

authors: brianf-aws dbwiddis dhrubo-os ylwu-amzn

repo: opensearch-project/ml-commons

license_type: permissive

license_source: github-api


text:
The Pagination links for 'Table View' not working.

What is the bug?
The Pagination links for 'Table View' on visualization page is not working.
How can one reproduce the bug?
Steps to reproduce the behavior:

Go to 'Observability->Event Analytics->Explorer
Enter the PPL Query, Click on Refresh Button
Navigate to 'visualization' page
Click on 'Table View' Toggle button
At the end on Table, click on the pagination link and observe the Issue

What is the expected behavior?
The Pagination number links should work properly
Do you have any additional context?
NOTE: The Pagination arrow links are working properly.

@mengweieric @anirudha
Please look at the Issue.
Thanks and Regards,
Nidhi Singhai

Hi @ruchika-narang,
We cannot use eui with versions newer than 34 as those are licensed with elastic license other than apache license. Check this
In this case we need to find other ways to implement the data view table.

AG-Grid table does not have this issue

source: gharchive/issue

authors: mengweieric nidhisinghai

repo: opensearch-project/observability


text:
Added tools/linter along with jest tests.

Description
Added a Linter to validate all yaml files in the /spec folder
Issues Resolved
https://github.com/opensearch-project/opensearch-api-specification/issues/205
(Not closing as we still need to turn this into a workflow with a follow-up PR)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
2. How much of the linter is OpenSearch-specific? Longer term, I wonder if it should be built as its own project in its own repo.
Half of the validator rules are OpenSearch specific:

Rules regarding x-operation-group
Rules regarding parameter naming conventions

The other rules enforce the multi-file structure we created for OpenSearch (diving paths into namespaces in schemas into categories). The merger tool assumes that there are no infractions in these rules to ensure that the result single-file is a valid OpenAPI file. Projects that want to reuse this structure will benefit from these (Though the namespace is actually a part of x-operation-group so we will have to untangle that first.)


text:
Fix broken manifest workflow

Description
Fix broken manifest workflow: https://build.ci.opensearch.org/job/manifest-update/49/console
and modify the code to update the osd-increment-plugin-versions.yml workflow with new branch entry.
Issues Resolved
https://github.com/opensearch-project/opensearch-build/issues/3610
Test on local
Updated the workflow files

Adding 2.9 to /usr/share/opensearch/git/opensearch-build/.github/workflows/os-increment-plugin-versions.yml
2023-06-08 21:48:16 INFO     Added new version to the version increment workflow
Adding 2.9 to /usr/share/opensearch/git/opensearch-build/.github/workflows/osd-increment-plugin-versions.yml
2023-06-08 21:48:16 INFO     Added new version to the version increment workflow

git status: Added new manifests

# On branch main
# Changes not staged for commit:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#	modified:   .github/workflows/os-increment-plugin-versions.yml
#	modified:   .github/workflows/osd-increment-plugin-versions.yml
#	modified:   jenkins/check-for-build.jenkinsfile
#
# Untracked files:
#   (use "git add <file>..." to include in what will be committed)
#
#	manifests/2.8.1/
#	manifests/2.9.0/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Please replace print with logging if required.

repo: opensearch-project/opensearch-build


text:
Ensure compatibility check readiness

Coming from https://github.com/opensearch-project/opensearch-devops/issues/114#issuecomment-1548868449
Overview
In order to detect the breaking changes between OpenSearch (core/min) and plugins, we recently onboarded a compatibility check gradle task with OpenSearch. See the pull request.
The task is dependent on publishToMavenLocal task (that publishes the core engine artifacts to maven local). It then clones the plugins' repository in temporary directory and runs ./gradlew assemble.
Action Items
In order to avoid false positives and false negatives, we need to make sure the tasks in below checklist are complete:

[ ] The build.gradle file in this repository uses mavenLocal() as the first entry in repositories() section. This will ensure that when core/min dependencies are published to maven local, gradle looks at maven local first and gets the required core/min dependencies rather than fetching from snapshots or maven central resulting in false checks.
[ ] ./gradlew assemble task passes for the plugin build. If the task itself is broken, checking compatitibility is irrelevant as it will always fail.

Please close this issue once the above checklist is complete.
Thanks!

@khushbr @praveensameneni can you please provide an update?

Confirmed both the condition, LGTM!

authors: bbarani gaiksaya khushbr

repo: opensearch-project/performance-analyzer


text:
Fixed failing detector_spec cypress test.

Description
Fixed failing detector_spec cypress test.
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The changes to the failing cypress test fix the issue for version 2.5. As the main branch is currently using the 2.4 artifacts, I included the changes in this PR in the 2.5 bump PR https://github.com/opensearch-project/security-analytics-dashboards-plugin/pull/297


text:
Make Git ignore .idea/ folder

Signed-off-by: Chang Liu cgliu@amazon.com
Description
Make Git ignore .idea/ folder
Category
Maintenance
Testing
MT
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #944 (4b2c9a9) into main (285608b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #944   +/-   ##
=======================================
  Coverage   72.14%   72.14%
=======================================
  Files          87       87
  Lines        1906     1906
  Branches      242      242
=======================================
  Hits         1375     1375
  Misses        477      477
  Partials       54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 285608b...4b2c9a9. Read the comment docs.


text:
Add testing and documentation for PKCS#1

Is your feature request related to a problem?
@cwperks recently corrected an issue were PKCS#1 format was no longer being properly handled: https://github.com/opensearch-project/security/pull/3289#pullrequestreview-1611738568.
While his change corrected the behavior the fact that the issue happened in the first place demonstrates that we have insufficient testing in place to cover support of PKCS#1.
We also lack documentation detailing our support even though people use it and we go out of our way to fix issues related to it.
What solution would you like?
I would like to see additional tests which exercise PKCS#1 support so we can be confident that we offer support. We should also update the documentation to reflect our support.
What alternatives have you considered?
Leaving things how they are does not seem like a good alternative.

[Triage] Going to mark help wanted.

repo: opensearch-project/security


text:
Add support for custom header parameters for broker endpoints

We have a service manager that can provision/deprovision services on our cloud platform. We are extending our service manager operations to CloudFoundry with an Open Service broker.
When our service broker is registered with CF platform to make our services and plans available to end users, CF calls our broker endpoint
GET /v2/catalog
Our service broker running on our service manager expects an header parameter for authentication along with basic auth parameter. Without the extra header parameter, our endpoints are not accessible and return 401.
We are looking for a solution on how to pass custom header parameters to broker endpoints during registration, so that platform sends it to every endpoint in subsequent requests to broker.
PUT /v2/service_instances/:instance_id
PUT /v2/service_instances/:instance_id/service_bindings/:binding_id

Followed up on cf-release - closing here.

authors: jakkahub mattmcneeney

repo: openservicebrokerapi/servicebroker

license_source: bigquery


text:
NO-ISSUE: Add SkipDisks signature

This signature detects whether the use chose to skip formatting some disks, and if
they did, it tells which host and which disks.
Skipping disks could lead to boot order issues, so triagers should be
made aware of it.
Example:
https://issues.redhat.com/browse/AITRIAGE-4393?jql=text ~ "489a0a33-5448-9531-d7fa-cd900095a2aa"

/cc @mkowalski


text:
specs: deployments: d10: update apiVersion to apps/v1

This PR was created to mitigate the Deployment error shown below when used with minikube
error: unable to recognize "https://raw.githubusercontent.com/openshift-evangelists/kbe/master/specs/deployments/d10.yaml": no matches for kind "Deployment" in version "apps/v1beta1"

Versions
Minikube
--------
minikube version: v1.6.2
commit: 54f28ac5d3a815d1196cd5d57d707439ee4bb392

Kubernetes and kubectl
------------------------
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.0", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"clean", BuildDate:"2019-12-13T11:52:32Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2", GitCommit:"c97fe5036ef3df2967d086711e6c0c405941e14b", GitTreeState:"clean", BuildDate:"2019-10-15T19:09:08Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}

Correct but superseded by #42

authors: ShivakumarSwamy joshix

repo: openshift-evangelists/kbe


text:
[release-v1.9] Bump to Go 1.19

As per title

The build image update will only be reflected once merged so we might need to force merge

repo: openshift-knative/eventing


text:
[RELEASE-v1.8] Revert "upgrade k8s autoscaling to v2

https://github.com/openshift/knative-serving/pull/1314

/lgtm

repo: openshift-knative/serving


text:
MGMT-17364: Allow providing subnet for IBI installation

MGMT-17364: Allow providing subnet for IBI installation
Adding new api field MachineNetwork it will be used to set nodeip hint that will point nodeip-configuration to the right ip

/approve

/lgtm

AWS CI issue
/retest

/retest

/retest

/override ci/prow/integration

/remove-label cluster-config-api-changed
backward compatible

repo: openshift-kni/lifecycle-agent


text:
CNF-15491: Handle ProvisioningRequest deletion

Updates included:

Add new provisioningState deleting, set when ProvisioningRequest is marked for deletion.
Add the finializer back to handle dependents deletion, ensuring dependents are removed before removing finalizer from ProvisioningRequest to complete the deletion.
Watch for deletion of cluster namespace so reconcilation can be triggered when ns is deleted.

/lgtm

/approve

/lgtm

authors: Missxiaoguo bartwensley browsell edcdavid


text:
PLNSRVCE-1090 Run AppStudio e2e tests subset on Pipeline Service PR

This PR is to run subset of AppStudio e2e tests on Pipeline Service PR, which depends on PR #1378

Added CI job named .tekton/stonesoupe-e2e-test.yaml
Extend AWS EC2 instance to m5.2xlarge because Infra-deployment deploying to OCP cluster consume more resources
Build a Docker image named e2e-test-runner for deploying StoneSoup and triggering e2e tests

Signed-off-by: Xin Jiang @xinredhat

CI job named .tekton/stonesoupe-e2e-test.yaml

Shouldn't pipeline name Pipelines as Code CI / stonesoup-e2e-test

As discussed:

Make sure that stonesoup-e2e-test is :heavy_check_mark: .
Then change the pipeline definition so it's run only on merges.

/retest

/test  stonesoup-e2e-test

/test  pipeline-service-upgrade-test

/retest

repo: openshift-pipelines/pipeline-service


text:
WIP: Prove using main or not

seeing if I understand the https://issues.redhat.com/browse/PLNSRVCE-1276 situation correctly

yep after upgrade the image sha is still 7dcfa61702b9e978dcdafab4d63521f6e5193ce0


text:
Make preview url of docs on Pull Request

On each pull request if there is changes in docs/content/ then generate a preview url on OpenShift.....
How to do that is an exercise to the reader :-p

done and dusted!

https://blog.chmouel.com/posts/generating-preview-environment-with-tekton/

repo: openshift-pipelines/pipelines-as-code


text:
Add reconciler to watch pr

Closes #606

Submitter Checklist

[ ] ♽  Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
[ ] 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
[ ] 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
[ ] 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
[ ] 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

Tested with GitHub Webhook
TODO:

[ ] Fix for GH App
[ ] Rest of the provider webhook

working on tests but can be reviewed!
@chmouel

Codecov Report

Merging #684 (6dfb021) into main (79e6111) will decrease coverage by 4.33%.
The diff coverage is 31.14%.

@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
- Coverage   69.45%   65.12%   -4.34%
==========================================
  Files          62       61       -1
  Lines        3821     3782      -39
==========================================
- Hits         2654     2463     -191
- Misses        906     1087     +181
+ Partials      261      232      -29

Impacted Files
Coverage Δ

pkg/pipelineascode/match.go
4.34% <0.00%> (-64.35%)
:arrow_down:

pkg/pipelineascode/pipelineascode.go
3.57% <0.00%> (-63.52%)
:arrow_down:

pkg/provider/github/github.go
71.11% <ø> (-0.16%)
:arrow_down:

pkg/provider/gitlab/gitlab.go
88.78% <ø> (ø)

pkg/kubeinteraction/labels.go
74.07% <12.50%> (-25.93%)
:arrow_down:

pkg/provider/github/status.go
53.62% <25.71%> (-30.55%)
:arrow_down:

pkg/pipelineascode/secret.go
70.00% <50.00%> (-14.00%)
:arrow_down:

pkg/adapter/adapter.go
61.05% <100.00%> (ø)

pkg/cmd/tknpac/resolve/resolve.go
67.39% <100.00%> (ø)

pkg/provider/bitbucketcloud/bitbucket.go
75.15% <100.00%> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e6111...6dfb021. Read the comment docs.

e2e was fixed with new token btw, the other error sounds like another error....

TODO:

[ ] fix GH unit
[ ] Test with bitbucket server

e2e should pass 🤞🏽 ... works fine with Bitbucket cloud, gitlab

whats up with the e2e btw?

whats up with the e2e btw?

it passed on the last 3rd commit but failed on latest
and next 2 commit were not code related 🤷🏽

/retest

finally the e2e passed 🥳

the coverage took quite a dive down 🙃

the coverage took quite a dive down upside_down_face

yeah the reconciler is not all covered... willl do some followup

authors: chmouel codecov-commenter sm43


text:
Add support to install jobs to read cluster status

Install jobs takes into account cluster status in addition to the
build trigger status to decide whether to run the OCP install or not.
The installs get triggered in cases where there's a new build or if
cluster doesn't exist even if there isn't a new build.

Depends on https://github.com/openshift-scale/scale-ci-deploy/pull/111.

if possible can you update the properties files with CLUSTER_HOST=<jump_host>

@mohit-sheth addressed the comments. PTAL.

authors: chaitanyaenr mohit-sheth

repo: openshift-scale/scale-ci-pipeline


text:
Provide an option to associate fork AMIs with Bugzilla issues

Requested in https://github.com/openshift/aos-cd-jobs/pull/220#discussion_r117508183

I don't think we are moving forward with enhancing AMIs anymore.

repo: openshift/aos-cd-jobs


text:
build/ocp4: unblock building 4.y with openshift package and new versioning

This is basically temporary (a good stopping point while I go about dismantling most of this and turning it into usually-incremental builds) with fixes to allow us to build at all, pretty similarly to before. Even that much turns out to be kind of involved, but keep in mind a lot of it probably goes away or transforms in the end.
Temporary home at https://buildvm.openshift.eng.bos.redhat.com:8443/job/hack/job/lmeyer-aos-cd-builds/job/build%252Focp4/ until merged.
Can also hack around at https://buildvm.openshift.eng.bos.redhat.com:8443/job/hack/job/lmeyer-2/job/build%252Focp4/ while real builds are happening at the other.

@adammhaile @tbielawa PTAL
@smunilla not sure how interested you'll be in the job changes but heads up that ocp4 will be producing things that look different.
I suggest reviewing a commit at a time, ignoring whitespace changes (there was quite a lot of moving around and re-indenting).

Basically, I discovered ocp4 does more than just build things, and I wanted to make sure that kept working while determining what we don't need any more and working on the full transition to incremental.
As I put above, this is not the final solution. It's a stopgap.

It was actually pretty easy to stop doing anything with the ose repo and just let doozer build it. So this is way simpler now.

/lgtm /approve

authors: adammhaile sosiouxme


text:
OCPBUGS-16488: rebase to latest upstream master

Upstream bumped to 1.27.4 Kubernetes, which will resolve some security issues with vendor packages.

/close
in favor of https://github.com/openshift/apiserver-network-proxy/pull/35

authors: mfojtik sjenning

repo: openshift/apiserver-network-proxy


text:
ubi-minimal++

OSD-18595

/lgtm

Codecov Report

Merging #218 (ed7ec25) into main (ec779fa) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   40.59%   40.59%
=======================================
  Files          25       25
  Lines        1855     1855
=======================================
  Hits          753      753
  Misses       1010     1010
  Partials       92       92

authors: codecov-commenter mjlshen yithian

repo: openshift/aws-vpce-operator


text:
[WIP] MGMT-15939: Reconcile AgentMachine if there is a Node failure

https://issues.redhat.com/browse/MGMT-15939
Previously, the reconcile loop for AgentMachine only checked if the status of the AgentMachine was ready, but this allowed situations where the Node fails and the AgentMachine never gets reconciled again leaving the cluster in a bad state.

/cc @filanov @avishayt
WDYT?

/assign @carbonin

Closing since this is not the solution. Thanks for the feedback and reviews!

authors: CrystalChun filanov

repo: openshift/cluster-api-provider-agent


text:
Move to libraries to openshift/api

This PR allows us to move our libraries to openshift/api from cluster-api-provider-alibaba. This depends on github.com/openshift/api/pull/1045.
Summary

Remove API and generated files
Plumb partially existing fields
Update vendor

Tested this change. Everything looked healthy.
NAME                                 STATUS   ROLES    AGE     VERSION
test-kdlxs-master-0                  Ready    master   19m     v1.22.1+bac83a5
test-kdlxs-master-1                  Ready    master   20m     v1.22.1+bac83a5
test-kdlxs-master-2                  Ready    master   25s     v1.22.1+bac83a5
test-kdlxs-worker-us-east-1a-dqr7r   Ready    worker   7m38s   v1.22.1+bac83a5
test-kdlxs-worker-us-east-1b-rdkhq   Ready    worker   8m32s   v1.22.1+bac83a5
test-kdlxs-worker-us-east-1b-ttqsr   Ready    worker   8m10s   v1.22.1+bac83a5
NAME                                 PHASE     TYPE            REGION	   ZONE         AGE
test-kdlxs-master-0                  Running   ecs.g6.xlarge   us-east-1   us-east-1b   21m
test-kdlxs-master-1                  Running   ecs.g6.xlarge   us-east-1   us-east-1a   21m
test-kdlxs-master-2                  Running   ecs.g6.xlarge   us-east-1   us-east-1b   21m
test-kdlxs-worker-us-east-1a-dqr7r   Running   ecs.g6.large    us-east-1   us-east-1a   14m
test-kdlxs-worker-us-east-1b-rdkhq   Running   ecs.g6.large    us-east-1   us-east-1b   14m

Cleaned up openshift/api/pull/1045 and tested:
NAME                                 STATUS   ROLES    AGE     VERSION
test-q92hx-master-0                  Ready    master   18m     v1.22.1+bac83a5
test-q92hx-master-1                  Ready    master   17m     v1.22.1+bac83a5
test-q92hx-master-2                  Ready    master   19m     v1.22.1+bac83a5
test-q92hx-worker-us-east-1a-wwznl   Ready    worker   5m3s    v1.22.1+bac83a5
test-q92hx-worker-us-east-1b-lmtvq   Ready    worker   3m39s   v1.22.1+bac83a5
test-q92hx-worker-us-east-1b-z5kb7   Ready    worker   5m54s   v1.22.1+bac83a5
NAME                                 PHASE     TYPE            REGION      ZONE         AGE
test-q92hx-master-0                  Running   ecs.g6.xlarge   us-east-1   us-east-1b   20m
test-q92hx-master-1                  Running   ecs.g6.xlarge   us-east-1   us-east-1a   20m
test-q92hx-master-2                  Running   ecs.g6.xlarge   us-east-1   us-east-1b   20m
test-q92hx-worker-us-east-1a-wwznl   Running   ecs.g6.large    us-east-1   us-east-1a   12m
test-q92hx-worker-us-east-1b-lmtvq   Running   ecs.g6.large    us-east-1   us-east-1b   12m
test-q92hx-worker-us-east-1b-z5kb7   Running   ecs.g6.large    us-east-1   us-east-1b   12m

Working out a few issues from pulling down latest openshift/api. Going to move to go1.17 in #21 and then rebase this PR on top of that one.

/test vet

CI is running as 1.16 for this repo still, will need to update that for vet to pass

/test vet

Latest version installs:
NAME                                 STATUS   ROLES    AGE     VERSION
test-4627z-master-0                  Ready    master   13m     v1.22.1+6859754
test-4627z-master-1                  Ready    master   14m     v1.22.1+6859754
test-4627z-master-2                  Ready	master   14m     v1.22.1+6859754
test-4627z-worker-us-east-1a-74fvh   Ready    worker   2m10s   v1.22.1+6859754
test-4627z-worker-us-east-1b-rt76n   Ready    worker   2m2s    v1.22.1+6859754
test-4627z-worker-us-east-1b-wwxs8   Ready    worker   2m8s    v1.22.1+6859754
NAME                                 PHASE     TYPE            REGION      ZONE         AGE
test-4627z-master-0                  Running   ecs.g6.xlarge   us-east-1   us-east-1b   16m
test-4627z-master-1                  Running   ecs.g6.xlarge   us-east-1   us-east-1a   16m
test-4627z-master-2                  Running   ecs.g6.xlarge   us-east-1   us-east-1b   16m
test-4627z-worker-us-east-1a-74fvh   Running   ecs.g6.large    us-east-1   us-east-1a   10m
test-4627z-worker-us-east-1b-rt76n   Running   ecs.g6.large    us-east-1   us-east-1b   10m
test-4627z-worker-us-east-1b-wwxs8   Running   ecs.g6.large    us-east-1   us-east-1b   10m

@elmiko @JoelSpeed I think this is ready to go. PTAL

/approve

@elmiko @JoelSpeed Is there any reason we run aws tests on this repository?

/retest

Is there any reason we run aws tests on this repository?

the aws test is like a "sanity check" for us, it allows us to ensure that we aren't breaking the primary payload with our changes. (that said, i know we see flakes there sometimes, but we need to have at least 1 e2e on a known GA platform)

authors: JoelSpeed elmiko kwoodson

repo: openshift/cluster-api-provider-alibaba


text:
Bug 1857246: Retrying in case of conflict during Config update

We have multiple controllers concurrently writting the status of the
config, this commit introduces retries in case of any of them updated
the config resource before us. This is clearly a workaround, as the
main controller may create storage if we fail to update the
configuration here it may ended up creating storage again on the next
cycle, hence the need to make sure we succeed.

/assign @dmage

/retest

@ricardomaraschini can you create an e2e test that checks that after the bootstrap storage is created only once?

/retest

@ricardomaraschini can you create an e2e test that checks that after the bootstrap storage is created only once?

As to have tests for every platform would be overkill I changed the error message and implemented a test to make sure it is not happening. PTAL.

/lgtm

/hold
it doesn't work

/retest

/lgtm

/hold cancel

/cherrypick release-4.5

authors: dmage ricardomaraschini


text:
TRT-1420: revert #1586 #1596

This reverts commits from #1586 and #1596

/hold

/hold cancel

/override ci/prow/e2e-aws-operator-disruptive-single-node
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-serial
/override ci/prow/e2e-aws-ovn-single-node
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-operator
/override ci/prow/k8s-e2e-gcp-serial
/approve
/lgtm
Going back to suspected good state.

authors: dgoodwin soltysh


text:
Move component to an appropriate upgrade order (generic)

Now that CVO only applies ordering on update, we are reorganizing
the order components are applied to better align with correct
upgrades. The order is:
0000_10_: config-operator
0000_20_: kube-apiserver
0000_25_: kube scheduler and controller manager
0000_30_: other apiservers: openshift and machine
0000_40_: reserved
0000_50_: all non-order specific components
0000_60_: reserved
0000_70_: disruptive node-level components: dns, sdn, multus
0000_80_: machine operators
0000_90_: reserved for any post-machine updates
Operators in 0000_50_* should have no prefix (like 0000_70_
before). No other rules of ordering have changed.
@deads2k

/lgtm


text:
PODAUTO-204: Upstream rebase to 2.14.0

Run rebasebot:

rebasebot --source https://github.com/kedacore/keda-olm-operator:main \
--dest openshift/custom-metrics-autoscaler-operator:main \
 --rebase jkyros/custom-metrics-autoscaler-operator:rebase-2.14 --tag-policy=strict \
--update-go-modules --dry-run  --github-user-token ~/githubtoken

Squash CSV commits together
Add CSV commits for both 2.14.0 and 2.14.1
Bump controller-gen in Dockerfile.ci to release-0.15 because the release-0.11 version panics on 1.22 code
Update container base images to use registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.22-openshift-4.17(we had to use 1.22 becuase unlike the operand, the upstream operator is using 1.22)

This will have to wait for https://github.com/openshift/kedacore-keda/pull/32, we need the proper test image

/jira refresh


text:
Dockerfile: bump golang 1.12

[1 of 2]
This change is 1 of 2 to bump etcd to golang 1.12 which is required for etcd 3.3.15 which we will ship in 4.3

/restest

/retest

unable to build the rhel dockerfile, authentication error, assuming you have :)
/lgtm

Failures don't seem related to the change etcd is running.
/retest

/retest

repo: openshift/etcd


text:
make test-e2e fails with error

➜  external-dns-operator git:(main) make test-e2e
go test \
-ldflags "-X github.com/openshift/external-dns-operator/pkg/version.SHORTCOMMIT=ea98598 -X github.com/openshift/external-dns-operator/pkg/version.COMMIT=ea9859875676474644424ecf3ec7c0ce52836577" \
-timeout 1h \
-count 1 \
-v \
-tags e2e \
-run "" \
./test/e2e
I0421 10:46:33.230220  653910 request.go:665] Waited for 1.049125091s due to client-side throttling, not priority and fairness, request: GET:https://api.ci-ln-gis99cb-76ef8.origin-ci-int-aws.dev.rhcloud.com:6443/apis/batch/v1?timeout=32s
panic: environment variable DNS_PROVIDER must be set

goroutine 1 [running]:
github.com/openshift/external-dns-operator/test/e2e.mustGetEnv({0x196e768, 0xc})
	/home/dhritishikhar/go/src/github.com/openshift/external-dns-operator/test/e2e/util.go:120 +0x8e
github.com/openshift/external-dns-operator/test/e2e.TestMain(0x442691?)
	/home/dhritishikhar/go/src/github.com/openshift/external-dns-operator/test/e2e/operator_test.go:133 +0x174
main.main()
	_testmain.go:55 +0x1d3
FAIL	github.com/openshift/external-dns-operator/test/e2e	3.859s
FAIL
make: *** [Makefile:115: test-e2e] Error 1
➜  external-dns-operator git:(main)

Closing this. README has the information -> https://github.com/openshift/external-dns-operator#running-end-to-end-tests-manually

repo: openshift/external-dns-operator


text:
release 1.1: add stable-v1.1 and stable-v1 channels

This PR adds the new channels:

stable-v1.1 for the upcoming release
stable-v1 for the users ready to streamline the minor version upgrades

stable-v1 channel would allow the engineering to reduce the configuration burden too as the channel needs to be mentioned in all the docs and the Prow CI configuration.

/label qe-approved

/label docs-approved

/retest
GCP installation failed: e2e-infoblox-operator-ipi-install-times-collection failed

/lgtm

/label px-approved
As per Chris Fields' statement for this release of ExtDNS Operator - the docs are enough.

authors: Miciah alebedev87 lihongan xenolinux


text:
Add secrets list and delete action

Fixes

https://issues.redhat.com/browse/HAC-4557
https://issues.redhat.com/browse/HAC-4559
Description

This PR adds Secret list page and delete action on the list.
Additional details:

Learn more button will be added once docs team provides the required id.
Add Secret button will be added in separate PR while we implement Add secret feature.

Type of change

[x] Feature

Screen shots / Gifs for design review

Access Denied Page:

Secret List page:

Row with labels:

Delete Secret action:
https://github.com/openshift/hac-dev/assets/9964343/73faff0d-5650-4073-9871-8f673eaaa421
Browser conformance:

[x] Chrome
[x] Firefox
[x] Safari
[ ] Edge

cc: @pankajshivpuje @Misjohns

@pankajshivpuje  I will add Add secret button later in separate PR once add secret form is ready and learn more link will be added when docs team provides the id.
Could you please provide the microcopy for the secrets empty state?

/retest

/lgtm

authors: karthikjeeyar rottencandy

repo: openshift/hac-dev


text:
WIP: Server side apply use in resource applier.

This needs to be modified to only take this path if the cluster is
OpenShift 4.5+ which has Kube 1.18, and thus server side apply. It also
needs testing to ensure we're getting the apply results we expect.

This is still a beta feature and doesn't work at all for OpenShift types yet. Closing for now, we may want to look at this again later.
/close

repo: openshift/hive


text:
OSD-9064 add install log handlers for proxy install failures

This PR adds two new installation log handlers, ProxyTimeout, and  ProxyInvalidCABundle, to cover cases where a cluster installation using a cluster-wide proxy is impacted due to the proxy either being unavailable or serving untrusted certificates.
Refs OSD-9064 / SDE-1471

seems good to me

authors: gregsheremeta mrbarge


text:
Fix condition initialization for other controllers

Just like 2c00f88d9 / #1761, but for the other controllers similarly
affected.
HIVE-1873

/assign @suhanime

/test e2e

/lgtm


text:
Unstructured OpenstackProviderSpec

Another attempt to address the move of OpenstackProviderSpec from cluster-api-provider-openstack to openstack/api/machine. See #2117 for background. In that PR, we simply replaced our imports. The result is that we could only decode the new thing. The problem is that we may still get the old thing if we're talking to an old cluster.
We only need the decoding to steal the osImage from the master machines so we can use that value for new workers. Rather than importing both schemata, trying to figure out which version we're talking to, and decoding against the correct one, this commit unmarshals the providerSpec as raw JSON into an Unstructured object and explicitly paths into it map-wise.
On the creation side, we're told that the spoke cluster itself will understand the new thing even if it's an old version (MAPI also unmarshals the JSON raw). So it should be fine to continue using recent vendored installer code to generate MachineSets (which will contain new-apiVersion OpenstackProviderSpec).
HIVE-2308
(cherry picked from commit 28dac77cfc2d836956972ea9f2254de962ce63af) (cherry picked from commit 567cdd3ab38a0cc0d5d1cb3ede4ee3b4d31ce723)

/assign @lleshchi

/lgtm


text:
Set region label on Clusterdeployment CR

This PR mimics the logic behind setting the platformLabel in the
Clusterdeployment CR. Previously present strings were also moved to
const's in the same package.

We should look to have getClusterPlatform and getClusterRegion return errors in future instead of "unknown" strings.

These changes look mostly fine. Can you give some more context for why this label is needed?

This is to enable per region deployments for SelectorSyncSets. For example, if we do not wish to deploy splunk-forwarder-operator in AWS China regions (cn-north-1 || cn-northwest-1)

These changes look mostly fine. Can you give some more context for why this label is needed?

This is to enable per region deployments for SelectorSyncSets. For example, if we do not wish to deploy splunk-forwarder-operator in AWS China regions (cn-north-1 || cn-northwest-1)

We litigated this for the platform label and agreed.that the platform label is generally useful enough to have Hive apply it. I am not entirely convinced here. It seems like what you want is a label that indicates whether the cluster is deployed in AWS China or not. Is the region useful outside of the peculiarities of AWS China?

These changes look mostly fine. Can you give some more context for why this label is needed?

This is to enable per region deployments for SelectorSyncSets. For example, if we do not wish to deploy splunk-forwarder-operator in AWS China regions (cn-north-1 || cn-northwest-1)

We litigated this for the platform label and agreed.that the platform label is generally useful enough to have Hive apply it. I am not entirely convinced here. It seems like what you want is a label that indicates whether the cluster is deployed in AWS China or not. Is the region useful outside of the peculiarities of AWS China?

You are correct that the driver behind this was to enable the determination of AWS China regions. But this also enables deployment configurations to be platform & region selective which may be used for canary deployments and management of deployments that rely on X services in X region. Some regions may not have the same services available as others per cloud provider. The choice of region is more cloud agnostic vs label of "aws-china"

/retest

/retest

/lgtm

authors: dgoodwin dofinn staebler


text:
Fast foward release-4.12 to main

What this PR does / why we need it:
Fast forwards release-4.12 to main

/lgtm

/retest-required

/close

/reopen

/close

authors: csrwng sjenning

repo: openshift/hypershift


text:
Fix infrastructure.status.apiServerInternalURI for PublicAndPrivate

Currently in a PublicAndPrivate setup behind a proxy, nodes remain unready because ovn-node pods fail to talk to the control plane osdb and api endpoints. This is because the connection to .hypershift.local tries to go through the proxy. This PR set's the right value in the infra status that will result in hypershift.local being added to the NO_PROXY list of the ovn-pods via
https://github.com/openshift/cluster-network-operator/blob/8db9a00429dd4a5e4123b1217da93419557645eb/pkg/util/proxyconfig/no_proxy.go#L76
and
https://github.com/openshift/hypershift/blob/117c87f271ad7dc7cab875afb17769795fb7d117/control-plane-operator/controllers/hostedcontrolplane/cno/clusternetworkoperator.go#L248
Additionally we also want to let the CNO set .hypershift.local in NO_PROXY unconditionally as this is a design invariant https://github.com/openshift/cluster-network-operator/pull/1692

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/lgtm

authors: csrwng enxebre


text:
NO-JIRA: sizing: add logging for what we're doing

The logical flows in the request serving node component scheduler and sizer are complex; we need a little more insight into what decisions we're taking, when, and why.
/assign @csrwng

/approve

/lgtm

authors: bryan-cox csrwng stevekuznetsov


text:
Add integration test for WebDAV ImageServer and ImageInspector.Inspect() method

This PR adds Integration tests will attempt to pull and scan an image without throwing an error. In order to accomplish this with our CI (travis), travis now runs tests inside a docker container (as travis does not support centos-based builds).
The PR also adds a set of integration tests for the WebDAV server (ensures http endpoints behave as expected).
the success of docker build will now also be tested by travis.
Additional changes:

changes to some constant names
ImageServer interface now implements GetHandler which returns an http.Handler rather than ServeImage, allowing the image server to be tested, as well as for middleware to be more easily added to the http Handler chain.

The additional tests are implemented with the Ginkgo Test Framework. Ginkgo tests are compatible with go test

requesting review from @pweil- @mfojtik

@enoodle help with review? I think it's important we merge this to help prevent regressions & provide confidence when making changes

@enoodle done :) although i think the test should be renamed from "e2e" since they are more like unit tests for the CLI

@ilackarms if you can split out refactoring (e.g. variable names, mux.HandleFunc, etc.) I think it will be easier to review/merge.

I can split this PR into two; the original intent was to a bit of code cleanup. I'll keep this PR focused on testing, and move the refactoring to another branch

@simon3z i'd like to rebase this branch off of #64 instead of completely removing the refactor changes; they're necessary for webdav_test.go
is that alright?

closing this PR; see #64 (refactoring) and #65 (testing)

repo: openshift/image-inspector


text:
Export getFeaturesFromTheSpec

Export the getFeaturesFromTheSpec function, renaming it
GetEnabledAndDisabledFeatures and adding appropriate godoc. This will
let library-go users determine the list of enabled and disabled features
independently of the ObserveFeatureFlags function.

/assign @mfojtik
/cc @deads2k @gabemontero

Potential usage in cluster-storage-operator: https://github.com/openshift/cluster-storage-operator/pull/216

@sttts I've updated this PR to move the utility functions to the new pkg/config/featuregate package. PTAL.

repo: openshift/library-go


text:
fix: CVE-2023-44487

Provides a fix for CVE-2023-44487

/lgtm
/approve

/test lvm-operator-e2e-aws-sno

/jira refresh

@jakobmoellerdev this will need to be backported to all release (4.12-4.14)

/cherry-pick release-4.14

repo: openshift/lvm-operator


text:
Bug 2025767: Prevent Machine from being considered provisioned until it exists in AWS

We are seeing instances where AWS is not returning the instance we just created within a second or two of the initial creation time, returning a 400 error saying that the instance does not exist.
This makes the machine go into failed right now, and, in conjunction with an MHC, can lead to leaked machines as the instances are deleted before AWS acknowledges the existence of the Machine.
This PR is an attempt to improve this experience.
It does:

Do not set the addresses after create - this prevents the machine controller from saying the instance is provisioned, if exists does not return the instance, it will call create again
Before we create, we attempt exists again by looking for existing instances - if this succeeds, requeue and the next reconcile should work and call Update which corrects the status and provider ID
If the exists fails a second time at the beginning of the create, but an instance ID has been set on the status, requeue, we can't create another instance, that would cause a leak

The only flaw in this that I can currently think of is that if an instance is terminated before Exists ever succeeds, then we will requeue forever as Exists currently just silently ignores these kinds of errors. To improve this, Exists could return a "Instance was terminated" error which we can unwrap and handle specifically, though this would need to be handled in the core Machine controller, so needs further work.

It seems in some cases since we do a patch to 'provisioning' it's possible we'll race and reconcile an object with nothing set. We handle this in vsphere here:
https://github.com/openshift/machine-api-operator/blob/master/pkg/controller/vsphere/actuator.go#L81

This is an interesting workaround, and definitely something we could look into adding here to protect against tight reconciles, though I think my patch should also resolve that. Better to be safe though.

Overall, this patch seems larger than necessary. I think we should just adjust the logic here to check for at least 120 seconds passed since we created the instance: https://github.com/openshift/cluster-api-provider-aws/blob/master/pkg/actuators/machine/reconciler.go#L259

I had originally thought this was the solution that we should go with, but after conversation with @lobziik came to the conclusion that this would be a "better" solution. With the time based solution, we are assuming there is no clock skew, which is not great. We are also relying on checking the conditions on the machine (which we have set) and so, if we have a bug in the time handling there, that could cause issues. Denis' suggestion was to make sure that we don't move to provisioned until we have had a positive ack, yes this exists, from the cloud provider side. We do this in both vSphere and Azure. This PR is an attempt to align with that "don't move to provisioned until we know it exists" idea

/bugzilla refresh

/retest

/approve

/bugzilla cc-qa

/cherry-pick release-4.9

looks like we'll need to manually backport this to the 4.9 release

authors: JoelSpeed elmiko lobziik sunzhaohua2

repo: openshift/machine-api-provider-aws


text:
OSD-7691 - Apply service log command to multiple clusters

Added basic pre-defined filters. Removed 'notify-group' script.
Obsoletes: https://github.com/openshift/managed-notifications/pull/62
Relates to https://github.com/openshift/osdctl/pull/132

/lgtm

/lgtm

authors: cattias dustman9000 tnierman

repo: openshift/managed-notifications


text:
OADP-2767: Upgrade: Remove unbreaking references to VSM/Volsync DataMover

Remove unbreaking references to old (VSM/Volsync) DataMover (allowing users to still automatically upgrade to OADP 1.3) and add instructions on how to use new DataMover when upgrading from OADP 1.2.
What is left of references to old (VSM/Volsync) DataMover, will be deleted in OADP 1.4 (https://github.com/openshift/oadp-operator/issues/1192).
Todos

[ ] Run backups/restores in test day
[x] Delete leftovers from upgrade

What was done to achieve the goal
To find occurrences
grep -Iinr 'volsync' . --exclude-dir=tests
grep -Iinr 'vsm' . --exclude-dir=tests
grep -Iinr 'datamover' . --exclude-dir=tests
grep -Iinr 'mover' . --exclude-dir=tests
grep -Iinr 'dummy' . --exclude-dir=tests

(excluding tests folder, because this should be https://github.com/openshift/oadp-operator/pull/1170 responsibility)
To apply changes
make generate
make bundle

How to test
To test an upgrade from 1.2 to 1.3, from this PR branch run
make catalog-test-upgrade

This will create oadp-operator-catalog-test-upgrade catalog in your cluster (OperatorHub in the UI).

Select the new catalog in the UI and install selecting stable 1.2 update channel. This will install version 1.2.2 of OADP operator (from oadp-1.2 branch, not 1.2.2 from marketplace).

Create a DPA with DataMover using the newly installed operator.
Finally, change channel of the installed operator to stable (version 99.0.0) in Subscription tab.

I think I touched every file that had reference to DataMover. Please review if my changes in documentation files make sense

/hold
address PR comments

infra failed to install
/test 4.12-operator-e2e-azure

INFO[2023-10-05T15:15:04Z] Step operator-e2e-azure-e2e succeeded after 54m44s.

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_oadp-operator/1171/pull-ci-openshift-oadp-operator-master-4.11-operator-e2e-azure/1709919661857968128#1:build-log.txt%3A79
flake after e2e
/override ci/prow/4.11-operator-e2e-azure

/retest

/retest

/unhold

/retest

/retest

ci/prow/4.12-operator-e2e-azure may be suspect flaking

/retest

/retest

authors: kaovilai mateusoliveira43 weshayutin

repo: openshift/oadp-operator


text:
[OSD-10624] add the doc for metrics

What type of PR is this?
(documentation)
What this PR does / why we need it?
Adding the description for each of the metric
Which Jira/Github issue(s) this PR fixes?
Fixes #OSD-10624
Special notes for your reviewer:
Pre-checks (if applicable):

[ ] Tested latest changes against a cluster
[ ] Ran make generate command locally to validate code changes
[ ] Included documentation changes with PR

Codecov Report

Merging #39 (0f9333f) into master (ff0cea6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   38.88%   38.88%
=======================================
  Files          13       13
  Lines         684      684
=======================================
  Hits          266      266
  Misses        405      405
  Partials       13       13

Updated to match with the description in the metrics.go. Thanks.

/lgtm

authors: T0MASD bmeng codecov-commenter

repo: openshift/ocm-agent


text:
fix(npm): bump to latest

this warning build time, and by doing this it updates it manually to the latest version

this is what was merged together with #105

Is there a benefit to bumping npm outside of the rpm install, other than disabling a warning?

I would say that the installation will always lag behind.
Using this we install dependant tools using the latest version of the builder

authors: clcollins georgettica

repo: openshift/ocm-container


text:
Extend the OWNERS file to unblock a merging impasse

Currently, only one reviewer/approver is available and we need to
progress. We will figure out a more appropriate OWNERS file soon.

/ok-to-test
/lgtm

/assign @kshlm

/verify-owners

/verify-owners

authors: kshlm obnoxxx

repo: openshift/ocs-operator


text:
[release-4.7] Release 4.7 newly enabled features

This is a backport PR, to update the newly enabled features to release-4.7

/ok-to-test

/ok-to-test

authors: aruniiird umangachapagain


text:
update odo watch to remove [component name] arg which is not needed or used

What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind cleanup
What does does this PR do / why we need it:
odo watch commands allows a [component name] as 1st arg which is not being used.
Which issue(s) this PR fixes:
Fixes https://github.com/openshift/odo/issues/3440
How to test changes / Special notes to the reviewer:
odo watch -h now shouldn't show the [component name]

@dgolovin please take a look at this change. This removes the <component name> from odo watch

@girishramnani PTAL- https://github.com/openshift/odo/issues/3440#issuecomment-652846425

Already addressed @amitkrout

I don’t see anywhere that the component name was actually used in experimental mode as well @amitkrout

/retest

/approve

/lgtm

authors: amitkrout dharmit girishramnani

repo: openshift/odo


text:
[WIP][4.7] add dhclient support for NM

Have NM use dhclient instead of NM internal dhcp client.  This may reduce or eliminate the dhcp issues that have been reported.

/ok-to-test
/test e2e-gcp
/test e2e-vsphere

Urgh I'm not a fan of adding those.
However, if there's no other way to fix this right now, please add a link to the NM BZ and clarify in the commit message that these packages should only be added temporarily until the NM issue is resolved.

/test e2e-vsphere

/test e2e-aws
Flakes

/retest

/approve
/lgtm
/hold
until tests pass

/cherry-pick master

/cherry-pick release-4.6

/test e2e-vsphere

/test e2e-gcp

/lgtm cancel
This doesn't seem to fully fix the problem

This doesn't work.  On to the next...

authors: LorbusChris fortinj66 vrutkovs

repo: openshift/okd-machine-os


text:
adding fixes for older vendored lib_openshifts, so ruamel is not a pr…

…oblem anymore

Approved by @joelddiaz in #2818

repo: openshift/openshift-tools


text:
Safari: SVG icons too small in catalog

The look fine in Chrome, but the icons are much smaller in Safari.

Chrome, IE, and Firefox are fine. It only seems to be a problem in Safari.

My testing indicates they are small in IE11, too.

My testing indicates they are small in IE11, too.

I'm probably wrong then. They're showing up at least :)

authors: rhamilto spadgett

repo: openshift/origin-web-catalog


text:
Use 'Sync' instead of 'sync' for resourceApplyMode

https://issues.redhat.com/browse/OSD-3163

/lgtm

/retest

repo: openshift/rbac-permissions-operator


text:
Release v1.0.7

Allow setting 0 replicas to autoscaling machine pool (Not default)
Updated the details link
Added custom IAM Roles
Remove default region
describe: Display description during Pending state

lgtm

authors: pvasant vkareh

repo: openshift/rosa


text:
Update tutorial-1.rst

Just a small correction

@RadW2020 Thanks! :blush:
If you have any comments/suggestions on the tutorial/documentation (i.e.: missing, incomplete or confusing parts) I would appreciate any feedback. Feel free to open an issue if that is the case. :wink:

repo: opensistemas-hub/osbrain


text:
Show total awarded on account detail page as beneficiary

For example, on encointer's page, we have several lists which show related proposals. We should show the total awarded value both in fiat value and token, so the community can how much fund has been awarded to one beneficiary.

Refer to the statistics of the project expense, when we select the Beneficiary role in user detail page, show the Total Rewards value in the info panel, which including the DOT and KSM rewards, and show the fiat value.
Figma link
Preview

authors: Popoulosss wliyongfeng

repo: opensquare-network/dotreasury


text:
[rt.openssl.org #4005] enhancement request: improve performance of pbkdf2

Migrated from rt.openssl.org#4005 (status was 'new')
Requestors:

bitsocoin@hush.com

From bitsocoin@hush.com on 2015-08-13 20:53:49:
Please consider borrowing performance improvements from this library:
https://github.com/ctz/fastpbkdf2

_______________________________________________
openssl-bugs-mod mailing list
openssl-bugs-mod@openssl.org
https://mta.openssl.org/mailman/listinfo/openssl-bugs-mod

See also #1708

A comment on reddit linked here so I wanted to point out that fastpbkdf2 is still 2x faster even after #1708.

2x faster means 1 bit of security added. Not so much impressive looking from this angle.

authors: FdaSilvaYY richsalz t8m y

repo: openssl/openssl


text:
openssl version -p -f is insane in MSVC builds

master:
platform: -wd4090
compiler: cl -W3
1.1.0:
platform:
compiler: cl " "VC-WIN64A

Ah, yeah, I see what's happening.  PR xoming up!

authors: dot-asm levitte


text:
Compilation of openssl failing showing error “no rule to make target 'jnix/jniglue.c'”

I am trying to compile openssl using ndk-build on an linux machine and earlier compilation failed saying that "aes.h" file was missing for resolving that I installed libssl-dev package and that worked and installation moved for some more steps and failed on this.

make: *** No rule to make target 'jnix/jniglue.c', needed by 'obj/local/armeabi-v7a/objs/opvpnutil/jniglue.o'. Stop.

In this there is so such path exists and I doubt I have to install some package again to fix this issue.

That's not part of OpenSSL...

authors: Sammy-iiitb levitte


text:
X509_REQ_sign() error with EVP_SM3

When using X509_REQ_sign() with EVP_SM3, reported error: "elloptic curve routines:pkey_ec_ctrl:invalid digest type"

The SM* support is largely limited to access via the EVP layer at the moment. Integration into X509 is not there yet, e.g. see #6837, #6579.

Thanks a lot

authors: MasterMeng mattcaswell


text:
Remove locking from OPENSSL_init_crypto()

Fixes #12869

Replying to @jwalch's from https://github.com/openssl/openssl/issues/12869#issuecomment-719783697:

Looking at OPENSSL_init_crypto(), it's ALMOST as if the locking isn't even necessary... It's really just a kludge around trying to effectively pass an argument to something squirreled away in a RUN_ONCE.

I agree that the lock seems to protect the static variable conf_settings which is used to pass an argument to a run-once function which can't take take any parameters.
https://github.com/openssl/openssl/blob/908cf7cefbb2a4c2a8ea1dd4798d1e689db6e3ed/crypto/init.c#L540-L549
But turning the static variable into a thread-local variable only fixes an artificial problem which actually does not exist: you are only allowed to pass a nonzero settings value to the function during early initialization in single-threaded mode, because otherwise you risk a race condition between threads calling OPENSSL_init_crypto() with different settings pointers, which yields undefined behaviour.
This is officially documented in OPENSSL_init_crypto(3)
   Numerous internal OpenSSL functions call OPENSSL_init_crypto().  Therefore, in order to perform non-default initialisation,
   OPENSSL_init_crypto() MUST be called by application code prior to any other OpenSSL function calls.

and @mattcaswell also added a very clear comment
https://github.com/openssl/openssl/blob/908cf7cefbb2a4c2a8ea1dd4798d1e689db6e3ed/crypto/init.c#L452-L457
about this in commit

b184e3ef73 (Provide framework for auto initialise/deinitialise of the library, 2016-02-09)

In view of his comment it is very surprising that @mattcaswell added the lock on the same day in commit

bf24111bb2 (Avoid a race condition in loading config settings, 2016-02-09)

I suspect that his fix was triggered by a a thread sanitizer report, and I believe that it is a false positive caused by unnecessary updates of conf_settings with null values. My proposed solution is rather simple: avoid unnecessary writes to conf_settings:
    if (opts & OPENSSL_INIT_LOAD_CONFIG) {
        if (settings != NULL)
            conf_settings = settings;

        if (!RUN_ONCE(&config, ossl_init_config))
            return 0;
    }

For more details, see pull request #13288.

I did actually consider doing essentially what your PR does. I did not research how well-documented the thread-safety assumptions of the function are as you did; my choice to go through the trouble of "passing the parameter" as thread-specific data was driven by wanting to have the sanest possible behavior under the assumption that an application might not follow the rules.
Specifically, my concern relates to how atomic the memory operations involved in setting an OPENSSL_INIT_SETTINGS* are on the various platforms OpenSSL supports. My understanding is that theoretically the writes can interleave (at least in some architectures), so "conf_settings" could end up holding some value that isn't equal to what either of the two racing threads actually passed in via "settings" and thus ossl_init_config would read from some random memory location (most likely resulting in a crash, but not necessarily).
Now of course one argument (which is not entirely without merit) is that if the application "broke the rules" and passed different settings from two different threads then whatever happens to them is on their heads.
The school of thought I was ascribing to was to at least try to guarantee that OpenSSL's internal state was consistent in the event of problematic application behavior. There's nothing I can do about controlling which thread "wins" but at least I can make it so one actually does.

Closing in deference to https://github.com/openssl/openssl/pull/13321

authors: jwalch mspncp


text:
Fixes in DH derivation related to DH support in CMS

Pass correct maximum output length to provider derive operation
and improve error checking in EVP_PKEY_derive* calls.
Fixes related to broken DH support in CMS

DH support should work with both DH and DHX keys
UKM parameter is optional so it can have length 0

Fixes #13810

Hmm, the failures in the sanitizers build are interesting.

Hmm, the failures in the sanitizers build are interesting.

I am still getting the error :thinking:
In the reproducer, it's important that the entire cert script is 111 (not master), then try openssl cms -aes128 -encrypt .. on master. (Otherwise, it will go fine -- i.e. master works with its own certs, but not from 111.)

I am still getting the error :thinking:
In the reproducer, it's important that the entire cert script is 111 (not master), then try openssl cms -aes128 -encrypt .. on master. (Otherwise, it will go fine -- i.e. master works with its own certs, but not from 111.)

Interesting. At least for me the master did not work with its own certs either. But yeah I got different failures (namely a segfault) than you.

Interesting. At least for me the master did not work with its own certs either. But yeah I got different failures (namely a segfault) than you.

@bbbrumley the latest fixup fixes also the 1.1.1 cert for me
I need to look why the certs differ between 1.1.1 and master and see if it is a problem or not.

@bbbrumley the latest fixup fixes also the 1.1.1 cert for me
I need to look why the certs differ between 1.1.1 and master and see if it is a problem or not.

Anyway, I think the CMS issue is fixed now. I've created new issue for the parameters generation (#13871).

Anyway, I think the CMS issue is fixed now. I've created new issue for the parameters generation (#13871).

This appears to fix the encryption error issue -- great job @t8m !
Thanks for opening #13871. Looking at the certs, there is indeed a diff. I'll report there.

This appears to fix the encryption error issue -- great job @t8m !
Thanks for opening #13871. Looking at the certs, there is indeed a diff. I'll report there.

Going through the PR, I am surprised such a small diff solved the issue!
My only comment: this PR is missing regression tests.

Going through the PR, I am surprised such a small diff solved the issue!
My only comment: this PR is missing regression tests.

We actually have a test case, it was just commented out.

We actually have a test case, it was just commented out.

We actually have a test case, it was just commented out.

And the test case shows that we have also problems in the decryption routine, not just the encryption.

We actually have a test case, it was just commented out.

And the test case shows that we have also problems in the decryption routine, not just the encryption.

Aargh, now the latest failure is really weird, because I cannot reproduce it when I run the failing command manually neither with the default provider nor with the fips-and-base.cnf. But it shows up locally in make tests. @levitte any possible hints?

Aargh, now the latest failure is really weird, because I cannot reproduce it when I run the failing command manually neither with the default provider nor with the fips-and-base.cnf. But it shows up locally in make tests. @levitte any possible hints?

After some fiddling around with environment variables, I was able to recreate it like this:
$ cd test-runs/test_cms
$ OPENSSL_TEST_LIBCTX=1 OPENSSL_CONF_INCLUDE=../../providers OPENSSL_CONF=../../apps/openssl.cnf OPENSSL_MODULES=../../providers/ ../../util/shlib_wrap.sh ../../apps/openssl cms -provider-path ../../providers -config ../../test/fips-and-base.cnf -provider fips -encrypt -in ../../test/smcont.txt -stream -out cms2cms-mod-13.cms -recip ../../test/smime-certs/smdh.pem -aes128
Using configuration from ../../test/fips-and-base.cnf
$ OPENSSL_TEST_LIBCTX=1 OPENSSL_CONF_INCLUDE=../../providers OPENSSL_CONF=../../apps/openssl.cnf OPENSSL_MODULES=../../providers ../../util/shlib_wrap.sh ../../apps/openssl cms -decrypt -recip ../../test/smime-certs/smdh.pem -in cms2cms-mod-13.cms -out cms2cms-mod-13.txt
Error decrypting CMS using private key
80F2DC43BA7F0000:error:1700006C:CMS routines:cms_get0_signed:content type not signed data:crypto/cms/cms_sd.c:30:
80F2DC43BA7F0000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:crypto/evp/evp_fetch.c:331:Global default library context, Algorithm (id-aes128-wrap : 27), Properties ()
80F2DC43BA7F0000:error:170000BD:CMS routines:dh_cms_decrypt:shared info error:crypto/cms/cms_dh.c:171:

After some fiddling around with environment variables, I was able to recreate it like this:
$ cd test-runs/test_cms
$ OPENSSL_TEST_LIBCTX=1 OPENSSL_CONF_INCLUDE=../../providers OPENSSL_CONF=../../apps/openssl.cnf OPENSSL_MODULES=../../providers/ ../../util/shlib_wrap.sh ../../apps/openssl cms -provider-path ../../providers -config ../../test/fips-and-base.cnf -provider fips -encrypt -in ../../test/smcont.txt -stream -out cms2cms-mod-13.cms -recip ../../test/smime-certs/smdh.pem -aes128
Using configuration from ../../test/fips-and-base.cnf
$ OPENSSL_TEST_LIBCTX=1 OPENSSL_CONF_INCLUDE=../../providers OPENSSL_CONF=../../apps/openssl.cnf OPENSSL_MODULES=../../providers ../../util/shlib_wrap.sh ../../apps/openssl cms -decrypt -recip ../../test/smime-certs/smdh.pem -in cms2cms-mod-13.cms -out cms2cms-mod-13.txt
Error decrypting CMS using private key
80F2DC43BA7F0000:error:1700006C:CMS routines:cms_get0_signed:content type not signed data:crypto/cms/cms_sd.c:30:
80F2DC43BA7F0000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:crypto/evp/evp_fetch.c:331:Global default library context, Algorithm (id-aes128-wrap : 27), Properties ()
80F2DC43BA7F0000:error:170000BD:CMS routines:dh_cms_decrypt:shared info error:crypto/cms/cms_dh.c:171:

The Global default library context in the error message looks suspicious given that the OPENSSL_TEST_LIBCTX environment variable loads the "null" provider into the default libctx.

The Global default library context in the error message looks suspicious given that the OPENSSL_TEST_LIBCTX environment variable loads the "null" provider into the default libctx.

Ah ok, that starts to make some sense now.

Ah ok, that starts to make some sense now.

Thanks for the hint, I should be able to proceed now.

Thanks for the hint, I should be able to proceed now.

Tests finally passed

Tests finally passed

Rebased and squashed, ping for a final review.

Rebased and squashed, ping for a final review.

Ping?

Ping?

My vote does not count. Anyway, I tested the reproducer from the original issue, and also both encrypt and decrypt commands. They seem to work just fine now with this PR.
Also on the unit test side, I checked the keys and certs -- looks sane. The output of asn1parse looks consistent to me about the types -- just upgrading the key size. (I guess this is to have a single test covering both FIPS/non.)

My vote does not count. Anyway, I tested the reproducer from the original issue, and also both encrypt and decrypt commands. They seem to work just fine now with this PR.
Also on the unit test side, I checked the keys and certs -- looks sane. The output of asn1parse looks consistent to me about the types -- just upgrading the key size. (I guess this is to have a single test covering both FIPS/non.)

Thanks

Thanks

User above has been blocked.

User above has been blocked.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged to master. Thank you for the reviews.

Merged to master. Thank you for the reviews.

authors: baghetalnssry bbbrumley mattcaswell openssl-machine t8m


text:
Fix compilation when using MASM on x86

The generated asm code from x86cpuid.pl contains CMOVE instructions
which are only available on i686 and later CPUs.
Without this patch, ml.exe fails when compiling that file.

@dot-asm ?

+1

commit 1bb7310 merged.  thanks!

authors: dot-asm ngg richsalz


text:
Fix typo in aesccm.c

CLA: trivial

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests.  Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

Merged to master, thanks for the correction.

authors: NanXiao openssl-machine paulidale


text:
EVP_DigestSignFinal: *siglen should not be read if sigret == NULL

This fixes small regression from #16962.
As reported by @jwalch in https://github.com/openssl/openssl/commit/182cc644b3a3690bddfecba925486fefa421d6ec#commitcomment-63342825

This pull request is ready to merge

Merged to 3.0 and master branches. Thank you for the reviews.


text:
TLSv1.3: Use TLSv1.3 style nonce construction (new approach)

Checklist

[x] tests are added or updated
[x] CLA is signed

Description of change

This is an alternative approach to that in #1940. Here we use the existing AEAD interface to libcrypto, rather than modifying the existing <=TLS1.2 cipher implementation in libcrypto. This goes slightly further than #1940 in that it actually starts to use the new nonce construction in the encryption of records. Due to the differing approach I have had to implement a new test for this as well.

New commit added to this to fix a Travis failure.

New commits pushed. Fixed another Travis failure, and a double free in tls13encryptiontest.

I rebased this on the latest master. All commits in this PR are now for review.

I rebased again to pick up the latest master travis fixes.

Rebased again. Ping?

I pushed a new commit to address the feedback so far and rebased to pick up the encrypt-then-mac test fix from master. I've not yet addressed the 509 char limit thing, or the index vs pointer thing. They need a bit more thought.

the 509 char and the index/pointer are my only remaining concerns.

(comment hidden because the commit got superceeded).  A point is better; see http://doc.cat-v.org/bell_labs/pikestyle on "the use of pointers"

A point is better; see http://doc.cat-v.org/bell_labs/pikestyle on "the use of pointers"

That's a good essay. I don't agree with all of it, but there are some useful rules in there. I particularly like rule 6 in the "Complexity" section. :-)

New commits pushed. The first one deals with the 509 character limit problem, and converts it to pass a pointer around not an index. The second commit marks refdata as static to avoid a clang issue.

+1

Pushed. Thanks.

authors: mattcaswell richsalz


text:
crypto/conf: gcc build warning fix

Fix the gcc build warning from conf_sap.c:
variable flags set but not used [-Wunused-but-set-variable] variable appname set but not used [-Wunused-but-set-variable] variable filename set but not used [-Wunused-but-set-variable]

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

I'm okay calling this trivial.

@chengangc can you update the commit message to include "CLA: trivial" as a line on its own as was done for #19153?

@mattcaswell @paulidale , thanks for your review. I update the description and to add "CLA: trivial". Could you please help to check the latest patchset? Thanks.

Merged, thanks for the contribution.

authors: chengangc mattcaswell paulidale


text:
Added CERTIFICATE_VERIFY_MAX_LENGTH constant

Set CERTIFICATE_VERIFY_MAX_LENGTH to 65538 = 2^16+2
Changed SSL3_RT_MAX_PLAIN_LENGTH to CERTIFICATE_VERIFY_MAX_LENGTH  in case TLS_ST_CR_CERT_VRFY in the function ossl_statem_client_max_message_size of statem_clnt.c and in the function ossl_statem_server_max_message_size of statem_srvr.c
Addresses #20478

Sorry for the late answer. Thanks @baentsch for the review. Yes, I submitted a CLA on Friday. I will look into your testing proposal and update the PR this week.

We don't accept merge commits. Can you remove the last merge commit? Thanks!

Aside from that - this PR looks good to me.

It looks like the author on the commits is not the same as on your submitted CLA.  Could you change the author via git commit --amend --author="" please.

Squashed the commits and merged to master branch. Thank you for your contribution.

authors: VeronikaNguyen mattcaswell paulidale t8m


text:
Fix memleak in EVP_DigestSignFinal/VerifyFinal.

This fixes the following memory leak:
Direct leak of 96 byte(s) in 2 object(s) allocated from:
    #0 0x7fc17f62f850 in __interceptor_malloc ../../../../gcc-8-20170611/libsanitizer/asan/asan_malloc_linux.cc:62
    #1 0x21dda91 in CRYPTO_malloc crypto/mem.c:76
    #2 0x21dda91 in CRYPTO_zalloc crypto/mem.c:100
    #3 0x21c2f1f in EVP_DigestSignFinal crypto/evp/m_sigver.c:111
    #4 0x21daecb in tls1_prf_P_hash crypto/kdf/tls1_prf.c:194
    #5 0x21db345 in tls1_prf_alg crypto/kdf/tls1_prf.c:261
    #6 0x21db345 in pkey_tls1_prf_derive crypto/kdf/tls1_prf.c:129
    #7 0x211242e in tls1_PRF ssl/t1_enc.c:82
    #8 0x211242e in tls1_final_finish_mac ssl/t1_enc.c:455
    #9 0x20c704d in ssl3_take_mac ssl/statem/statem_lib.c:121
    #10 0x20c704d in tls_get_message_body ssl/statem/statem_lib.c:474
    #11 0x20ab43c in read_state_machine ssl/statem/statem.c:578
    #12 0x20ab43c in state_machine ssl/statem/statem.c:387
    #13 0x2070c16 in ssl3_read_bytes ssl/record/rec_layer_s3.c:1031
    #14 0x2081667 in ssl3_read_internal ssl/s3_lib.c:3833
    #15 0x2081667 in ssl3_read ssl/s3_lib.c:3857
    #16 0x208f02f in SSL_read ssl/ssl_lib.c:1552
    #17 0x1d456a5 in OpcUa_P_SocketService_SslRead platforms/linux/opcua_p_socket_ssl.c:248
    #18 0x1db5373 in OpcUa_HttpsStream_Receive transport/https/opcua_httpsstream.c:2118
    #19 0x1db5373 in OpcUa_HttpsStream_DataReady transport/https/opcua_httpsstream.c:2664
    #20 0x1da6723 in OpcUa_HttpsListener_ReadEventHandler transport/https/opcua_httpslistener.c:1251
    #21 0x1da0bd5 in OpcUa_HttpsListener_EventCallback transport/https/opcua_httpslistener.c:1664
    #22 0x1d45bc3 in OpcUa_SslSocket_DoStateMachine platforms/linux/opcua_p_socket_ssl.c:171
    #23 0x1d46432 in OpcUa_SslSocket_InternalRead platforms/linux/opcua_p_socket_ssl.c:782
    #24 0x1d46432 in OpcUa_RawSocket_EventCallback platforms/linux/opcua_p_socket_ssl.c:839
    #25 0x1d3d313 in OpcUa_Socket_HandleEvent platforms/linux/opcua_p_socket_internal.c:898
    #26 0x1d3f644 in OpcUa_P_Socket_HandleFdSet platforms/linux/opcua_p_socket_internal.c:1336
    #27 0x1d420ba in OpcUa_P_SocketManager_ServeLoopInternal platforms/linux/opcua_p_socket_internal.c:1123
    #28 0x1d420ba in OpcUa_SocketManager_AcceptHandlerThread platforms/linux/opcua_p_socket_internal.c:723
    #29 0x1d4910d in pthread_start platforms/linux/opcua_p_thread.c:46
    #30 0x7fc17f340e99 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x7e99)

... I started to test the OPC/UA Stack with OpenSSL 1.1.0.

merged to master, thanks!

please also for 1.1.0

Approved for backport to 1.1.0

Commit f05cece in 1.1.0; thanks again!

authors: bernd-edlinger mattcaswell richsalz


text:
New GOST identificators

This pull request provides OIDs and NIDs necessary for new GOST-related standards.

Oh...actually, it looks like a "make update" is required for this PR

yes. fuzz/oids  okay to do 'make update' as part  of the commit?

Sure

thanks.  done and merged.

authors: beldmit mattcaswell richsalz


text:
CSV: Set operator-type: non-standalone

This should hide the placement package/bundle in the OpenShift console as we only want the main OpenStack operator to show up there.

/test placement-operator-build-deploy
Test executor was unable to claim a test cluster

authors: dprince gibizer


text:
[WIP] Tweak language in second section of billy-to-pupa docs

(This'll fail the Travis build, since it's missing some placeholder file that's present in the master branch; don't worry about it)

Remember when project leads respected [WIP] tags? Pepperidge Farm remembers.

ha oops
On Mar 17, 2017 12:45, "Miles Watkins" notifications@github.com wrote:

Remember when project leads respected [WIP] tags? Pepperidge Farm
remembers.
https://camo.githubusercontent.com/be1d92aa7c4c546ce683171305508385ff1ae50b/68747470733a2f2f692e7974696d672e636f6d2f76692f723251566a70344b456a552f687164656661756c742e6a7067
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/openstates/documentation/pull/16#issuecomment-287407984,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAfYv6WT0e4LjO2DhEoLeXWjmJpMehiks5rmri2gaJpZM4MgJ-s
.

npnpnp, these are all standalone :P

authors: jamesturk mileswwatkins

repo: openstates/documentation


text:
[Question] 会和stackblitz一样吗？特别是web container方面

描述你的问题（Describe you question here）
https://stackblitz.com，非常棒的体验！特别是web container技术。
可以说wasm，让真正的web ide变成可能。

这次开源的是无需容器在浏览器的运行的 IDE 框架，类似于 stackblitz 提供的 IDE 产品一样，通过 codeblitz 可能做出类似于 stackblitz 一样的 IDE 产品，但是 stackblitz 除了 IDE 还有一块就是你说的 web container 的技术，这块本次没有开源，内部还在验证中，如果你有需要也可以直接使用 stackblitz 提供的 https://webcontainers.io/guides/quickstart 或者用 codesandbox 提供的 https://github.com/codesandbox/nodebox-runtime 来和 codeblitz 集成~

repo: opensumi/codeblitz

license: MIT


text:
feat: add chat agent extension api in sumi

Types

[x] 🎉 New Features

Background or solution
add chat agent extension api

copilot:walkthrough

Changelog

copilot:summary

/next

/next

/next

/next

/next

/next

authors: Ricbet winjo

repo: opensumi/core


text:
feat: add notebook extension api

Types

[x] 🎉 New Features
[ ] 🐛 Bug Fixes
[ ] 📚 Documentation Changes
[ ] 💄 Code Style Changes
[ ] 💄 Style Changes
[ ] 🪚 Refactors
[ ] 🚀 Performance Improvements
[ ] 🏗 Build System
[ ] ⏱ Tests
[ ] 🧹 Chores
[ ] Other Changes

Background or solution
Changelog

Summary by CodeRabbit

新功能

增加了对笔记本文档的管理功能，包括创建、打开和保存笔记本的能力。
引入了新的接口和类，以支持笔记本单元的管理和交互。
实现了事件驱动的笔记本文档生命周期管理，包括打开、关闭和修改事件。
增加了 MIME 类型归一化和识别的增强功能。

修复

修复了有关 MIME 类型归一化和识别的功能，增强了模块的健壮性。

文档

更新了相关接口和类型的文档，清晰描述了笔记本管理的功能和用法。

/next

/next

/next

/next

/next

/next

/next

/next

/next

/next


text:
Fixed GPU registration bug

The block was indented one tab too far.

Thanks for the PR. I added a test and opened #883

authors: MythicFrost camfairchild

repo: opentensor/bittensor


text:
Add feature to determine if multicast packets should be looped back to the local sockets.

Is your feature request related to a problem? Please describe.
I'm implementing website topology graph of OpenThread on OpenWRT, and I need to get the information of the whole network. But I found that multicast packets won't be looped back to the local sockets.
Describe the solution you'd like
We can set or read a boolean integer argument that determines whether sent multicast packets should be looped back to the local sockets. like the IP_MULTICAST_LOOP (since Linux 1.2)

From https://www.tldp.org/HOWTO/Multicast-HOWTO-6.html, it seems this behavior is per socket based. I think we should extend the UdpSocket to include some flags.

Another issue needs to consider is multicast datagrams can be processed by multiple sockets of a single host. #3398 doesn't take into multicast into account. After we introduced UDP flags, we may consider enhance the multicast situation as well.

Thoughts? @jwhui

@librasungirl

Closing stale issue.

authors: bukepo huamenggg jwhui

repo: openthread/openthread


text:
[flags] add options for less file output

This PR adds two flags:

-no-pcap: not generate Pcap file
-no-replay: not generate Replay file

Got this idea when my stress test pcap filled up my whole disk.

@wgtdkp any comment for this simple PR ?

Codecov Report

Merging #83 into master will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   39.92%   39.79%   -0.14%
==========================================
  Files          16       16
  Lines        2447     2450       +3
==========================================
- Hits          977      975       -2
- Misses       1450     1455       +5
  Partials       20       20

Impacted Files
Coverage Δ

dispatcher/dispatcher.go
0.00% <0.00%> (ø)

web/web.go
42.02% <0.00%> (-2.90%)
:arrow_down:

Just curious, How long does it take to exhaust your disk?

It depends on the volume of the Thread traffic.

authors: codecov-commenter simonlingoogle

repo: openthread/ot-ns


text:
Bump dependencies and add test workflow

Bumps all the dependencies to the latest version and adds a basic test workflow

@austinlparker can we merge it?

repo: opentracing-contrib/go-grpc


text:
Add abort_with_status implementation

The abort_with_status method was added to the abstract class
grpc.ServicerContext in grpc 1.18.0, from which the _OpenTracingServicerContext
inherits.
(See https://github.com/grpc/grpc/pull/17481)
If no implementation for the new abstract method is provided, the _OpenTracingServicerContext class cannot be instantiated.

Thanks a lot for this PR! I will now re-enable support for grpc >= 1.18.0 ;)

Thanks for merging this @carlosalberto!

authors: carlosalberto psiemens vpquant

repo: opentracing-contrib/python-grpc


text:
[WIP] [#353] Adds a simple approach to normalize study_phase values

We opted to implement a solution based on a CSV file representing a two-way table(variation and its normalization). This file is accessed in order to match a phase variation
with its normalized forms.
Since a Trial may be in one or more Phases simutaneously and, as it was suggested,we decided that the return of the method should be an array of phases.
However, 'knex' does not support said type so we decided to alter the type of the 'study_phase' column to 'jsonb'.
With this solution, whenever a new variation arrives the CSV file needs to be updated.
Furthermore, a new schema file was generated, updating tests/dbs.
With these modifications, changes were needed on the Api repository. In which the migration and seeds were updated, generating another PR.

About using jsonb instead of text[], have you tried using table.specificType('study_phase', 'text[]')? If so, did you have any problems with it?

Yes, we did and it works fine.
Acctually, we have already made the changes and we're going to commit them soon.

@arthurSena thanks for the PR and congratulations on your first code merged :beers:
Looking forward for the next ones :smile:

authors: arthurSena vitorbaptista

repo: opentrials/processors

license: mit


text:
🛑 [CN] OpenUPM Website Packages is down

In fd9f116, [CN] OpenUPM Website Packages (https://openupm.cn/packages/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: [CN] OpenUPM Website Packages is back up in 72e9661.

repo: openupm/upptime


text:
Fix autoloader, which depends on $_SERVER existing

The autoloader relies on this:
if (file_exists($_SERVER['DOCUMENT_ROOT'] . 'includes/class.' . $name . '.php') === TRUE)

$_SERVER doesn't exist with the CLI interface. Come up with a solution here that doesn't break functions.inc.php on richmondsunlight.com—don't fork the libraries.

Er, no — that commit shouldn't have referred to this issue.

repo: openva/rs-machine


text:
Training a model with only normal data, gettting "RuntimeError: Found 0 abnormal images"

Describe the bug
When training a model with only normal images, getting "RuntimeError: Found 0 abnormal images "

The problem can be fixed by removing the abnormal dir in make_dataset in the folder module:
dirs = {"normal": normal_dir}
instead of
dirs = {"normal": normal_dir, "abnormal": abnormal_dir}
If I do this, training finishes successfully and I get a good model.
Should the abnormal_dir be made Optional, and the abnormal_dir left out of dirs when it is not specified? Or can this be due to issues in config/setup?
To Reproduce
Train a PatchCore model without any abnormal images.
Expected behavior
A successful training run.
Hardware and Software Configuration

OS: Ubuntu
anomalib: 0.3.7

Duplicate of #277.
@toon-vc, this is something we are currently working on. It will be available here once we merge this feature branch to main.

authors: samet-akcay toon-vc

repo: openvinotoolkit/anomalib


text:
Docs for ReID are obsolete

My actions before raising this issue

[x] Read/searched the docs
[x] Discussed this in gitter with developer

Current Behaviour
There is an outdated link in docs when searching for information about ReID
https://github.com/openvinotoolkit/cvat/blob/develop/cvat/apps/documentation/cvat/apps/reid/README.md
Also screenshots and description are not relevant.
Expected Behaviour
Updated docs connected with ReID merge here:
https://github.com/openvinotoolkit/cvat/blob/develop/cvat/apps/documentation/user_guide.md#top-panel

@TOsmanov , @aschernov , could you please help us to fix documentation?

@nmanovic we are planning to make changes to the user guide with this plan #2216

@TOsmanov Can this issue be closed?

@azhavoro yes

authors: PMazarovich TOsmanov azhavoro nmanovic

repo: openvinotoolkit/cvat


text:
Tasks filter does not work correctly after incorrect filter was applied

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

Expected Behaviour
Applying correct filter after incorrect should work fine
Current Behaviour
status: "completed" shows all the tasks when there are only two completed tasks actually
Possible Solution

Steps to Reproduce (for bugs)

Your Environment

Git hash commit (git log -1):  3d496ef
Docker version docker version (e.g. Docker 17.0.05): N/A
Are you using Docker Swarm or Kubernetes? N/A
Operating System and version (e.g. Linux, Windows, MacOS): N/A

@bsekachev , I will recommend to reimplement the filter. I like the filter of Kanboard. Probably we can add something similar.

Not relevant after #4409

authors: bsekachev nmanovic


text:
Tokenizer for facebook/musicgen-small

Hello, I am trying to convert a tokenizer for use with facebook/musicgen-small. This is the model used in this notebook:
https://github.com/openvinotoolkit/openvino_notebooks/blob/main/notebooks/250-music-generation/250-music-generation.ipynb
But it is failing with the following:
> convert_tokenizer facebook/musicgen-small --with-detokenizer -o musicgen-small-tokenizer
None of PyTorch, TensorFlow >= 2.0, or Flax have been found. Models won't be available and only tokenizers, configuration and file/data utilities can be used.
Loading Huggingface Tokenizer...
Converting Huggingface Tokenizer to OpenVINO...
sentence_piece.cpp(88) [_status.ok()] Internal: C:\Jenkins\workspace\private-ci\ie\build-windows-vs2019@2\b\tmp\tmpwymvb8fg\build\_deps\sentencepiece-src\src\sentencepiece_processor.cc(1055) [!IsUnknown(PieceToId(absl::string_view(model_->bos_piece().data())))] id for `<s>` is not defined.
Program terminated with an unrecoverable error.

Any ideas?
Thanks!

Hi Ryan,
Yes, there is a bug that causes this issue. I created a PR with a fix. It will be added to the next version - 2024.0.0.0.
If you want to access the fix now, there are a couple of options:

Install openvino-tokenizers from the fork branch of the git repository (or from the master after PR will be merged). It requires OpenVINO Archive distribution to build tokenizers binaries.
Add changes to the python code in the installed openvino-tokenizers library.

The second option is easier. To locate the file you can use this code:
from openvino_tokenizers import hf_parser
print(hf_parser.__file__)

After getting the tokenizer model with the modified library, it will work with any openvino-tokenizers version, since the bug is in the conversion stage.

So, I added this (which I guess is the only dll that would make sense here):
core.add_extension("core_tokenizers.dll");

Yes, I can see how it can be misleading. The dll you need is user_ov_extension.dll, which is already renamed to openvino_tokenizers.dll on master branch. Basically:

user_ov_extension.dll for 2023.0.0.0 version
openvino_tokenizers.dll for any future (or builded locally) versions

Hi @apaniukov,
Ah, got it -- thank you! I didn't even notice that user_ov_extensions.dll was one of the DLL's included. Yes that seems to work.
By the way, will these eventually get included into OpenVINO itself in a future release (like 2024.X)?

Hello @RyanMetcalfeInt8,
At least for all upcoming 24.x releases the plan is to have all tokenizers in the separate package and maybe later on if it would be required they would become a part of the OpenVINO opset.
Best regards,
Andrei

Hi @andrei-kochin -- makes sense. Thanks!


text:
remove unnecessary go-routines around policy watches

With the addition of federated watch handlers, there are unnecessary go routines in the policy flow.
All we do with spinning a new go-routine for watching local peer pods for policy is 'add' the handlers and then wait for network policy to be removed so that we can 'remove' the handlers. We don't need go-routines for that.
This will be immensely helpful when we have 20k namespaces isolated from each other by at least as many NetworkPolicy objects.
Signed-off-by: Rajat Chopra rchopra@redhat.com

@dcbw @shettyg
This is a quick attempt and I have not reviewed/tested it myself. But please take a look nevertheless if its in the right direction. Thanks.

/test integration

@rajatchopra this approach looks good to me; haven't done in-depth review but I think you're on the right track

Closing in favour of #413. Thanks Jacob.

authors: dcbw rajatchopra

repo: openvswitch/ovn-kubernetes


text:
Add multiplatform BLE stack for ISO/IEC 18013-5:2021 proximity.

This adds new multiplatform API to the identity-mdoc library for ISO/IEC 18013-5:2021 proximity presentations. It works on both Android and iOS and both operating systems share a lot of common code.
Also add support two new pages - "ISO mdoc Proximity Sharing" and "ISO mdoc Proximity Reading" - to the multi-platform test app. This only includes QR engagement, NFC engagement will be added in a future change. These two pages represent feature complete mDL and mDL reader functionality and are designed to work with other implementations as well as with itself.
Also introduce rememberBluetoothPermissionState composable function and BluetoothPermissionState object which can be used to obtain the required permissions on BLE on both Android and iOS.
Also devise a new multi-testing framework for automatically testing a number of mDL presentations between two devices. This is available in a new "ISO mdc Multi-Device Testing" page in the test app and the way it works is that the 1st device offers a QR code that the 2nd device scans. This sets up a TCP/IP control plane used for initiating tests, including sharing DeviceEngagement. This helps ensure the code is robust and well-tested both for happy paths and with all the various termination options available in the standard.
Also modify existing L2CAP support so it follows the latest draft of the upcoming second edition of ISO 18013-5:2021. In particular, this means framing the SessionData / SessionEstablishment packets sent over the L2CAP socket.
Modify ScanQrCodeDialog and ShowQrCodeDialog so they are easy to extend.
Include portrait ans signature images in sample data in identity-doctypes.
Test: Manually tested against wallet app and well-known readers.

Thanks for the review! Replaced all occurrences of 0x01 and 0x02 with BleTransportConstants.STATE_CHARACTERISTIC_END and _START.


text:
Add the removal script to uninstall the deprecated actions and package

Patially-Closes-Bug: #163

PG?

@csantanapr The uninstallDeprecation.sh is not called automatically anywhere. It is called manually so far. PG won't test it.

@houshengbo you changes this file installCatalog.sh and this is a file being use today.
How do validate that the changes to installCatalog.sh are correct and doesn't cause other problems. Also it will test the new validateParameters.sh

@csantanapr The PG seems to be down. I launched several, but they failed and did not even reach the part of installing the catalog.
Anyway, the travis of openwhisk-catalog has passed. It has already tested the installation of the catalog.

We have got the PG passed for this PR.

authors: csantanapr houshengbo

repo: openwhisk/openwhisk-catalog


text:
Implement a base serializer class for API views

Django-rest-framework, which has been used to create API views, does not call the full_clean method under models, this means that custom model validations would not run on API views while creating or updating records. We need to create a base serializer class which can be extended to other apps.

Could be something like:
class ValidatedModelSerializer(serializers.ModelSerializer):
    def validate(self, data):
        instance = self.instance or self.Meta.model(**data)
        instance.full_clean()
        return data

authors: anurag-ks nemesisdesign

repo: openwisp/openwisp-utils


text:
luci documentation

where is the new documentation for luci ?
http://luci.subsignal.org/trac/wiki/Documentation is can not open !

still broken...

seems to be working again.

The website mentioned above is currently up and works.

Seems broken again?

authors: hnyman roecker shuhaowu sky20054122 stephanstricker

repo: openwrt/luci