text:
add htaccess redirects

Hi @maulikkanani - thanks for submitting this! Sorry for my delay in checking it until now.
Could you please rebase this on latest master and drop the error_log lines? They can be WsLog::l() instead if needed to be logged.
I'll need some more time to understand the actual implementation. Please feel free to add more info here about what it does.
Cheers,
Leon

Hi @maulikkanani - you may get some ideas from this recently merged PR: https://github.com/WP2Static/wp2static-addon-s3/pull/29

it seems like Master repo has been updated so I guess I need to resolve conflict then need to commit it again.
Here is detail for what I have developed.
I have created "Create page redirects found in .htaccess" checkbox for .htacces RewriteRule redirect on the S3 bucket.
If the checkbox is selected then it will reader .htaccess and find 301 redirects in it and set same redirection on s3bucket as well.
Would you please refer:
For Checkbox: https://www.screenpresso.com/=bAutg
For .htacces RewriteRule : https://www.screenpresso.com/=QsUwc
For S3 Bucket: https://www.screenpresso.com/=1Vlrb
Let me know if you need further details.

#29 handles deploying redirects from the wp2static_list_redirects filter. That's all that the S3 addon needs to do. The detection of redirects from other sources is out of scope for this addon.
It could go into WP2Static core, but Leon wants to keep the options there to a minimum, so it probably won't make it in. I think there is a plan for an Advanced Crawling Options Addon or something like that, so that would probably be the place for this.

Thanks for updating @maulikkanani.
I agree with @john-shaffer that the .htaccess doesn't need to be within this S3 repo. But also not in the core plugin, If still needed for your use case now that the wp2static_list_redirects filter is available, then I'd prefer it to be in it's own Add-on, which users can then use with any deployment option. This can be your own add-on, which I'm happy to promote with any 3rd party add-ons.
I know of some users who have very complex htaccess setups and would like to translate more than just rewrite rules to the deployed site host, I can imagine that would get tricky and it's unlikely I'm going to prioritize that as an official add-on to work on. By using WP_CLI commands or other hooks/filters available, those users should have enough flexibility to craft custom workflows to achieve that.
Checking your PR again, it looks to just handle 301's, to the wp2static_list_redirects implementation should solve your problem. This will report 301s just as your WordPress site encounters them, so as long as the URL is within your site and WordPress responds to it as expected, you shouldn't need to do anything else.
I'll close this PR for now and please let me know if the recent redirects handling doesn't solve the issue in your use case.

authors: john-shaffer leonstafford maulikkanani


text:
票据

票据合约说明

建议修改的点：
BillStorage需要加上权限控制，不然存在安全隐患。比如，用户可以区块浏览器查询BillController对应的存储槽位，从而拿到BilStorage的地址，然后就可以随便调用了

存储合约权限控制

source: gharchive/pull-request

authors: hongfish masonhunk

repo: WeBankBlockchain/SmartDev-Contract

license_type: permissive

license_source: github-api


text:
testes adicionados

Olá samarasss, obrigado pela contribuição!
Mas não acho que seja necessário um PR para este repositório, já que são projetos antigos meus e que não costumo utilizar para mais nada, apenas deixo aqui como lembrança dos tempos que eu era novato e estava aprendendo a programar.
De qualquer forma, fique à vontade para olhar os outros projetos e fazer um fork com suas modificações se achar algo interessante!
Abraços!

Boa noite!
Mesmo sendo um projeto básico foi bastante útil, precisava de um projeto
nesse estilo para testar e ensinar aos colegas uma ferramenta de geração de
testes.
Seu projeto foi encontrado facilmente no Google e como me ajudou tenho a
certeza que ajuda a outros estudantes também.
Obrigada
Em ter, 6 de nov de 2018 21:30, Wolfgang Almeida <notifications@github.com
escreveu:

Olá samarasss, obrigado pela contribuição!
Mas não acho que seja necessário um PR para este repositório, já que são
projetos antigos meus e que não costumo utilizar para mais nada, apenas
deixo aqui como lembrança dos tempos que eu era novato e estava aprendendo
a programar.
De qualquer forma, fique à vontade para olhar os outros projetos e fazer
um fork com suas modificações se achar algo interessante!
Abraços!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Wolfterro/Projetos-em-Java/pull/2#issuecomment-436447849,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT4BZsIEfFwZCLzjBdfcrPDORrNy6pkpks5ushuXgaJpZM4X9do1
.

authors: Wolfterro samarasss

repo: Wolfterro/Projetos-em-Java

license: mit

license_source: bigquery


text:
not able to compile

not able to compile

source: gharchive/issue

authors: ZetrixWeb-iOS virussmca

repo: YK-Unit/AppRTCDemo


text:
Add synapse collector to collect the number of haproxy frontends/backends

🚢

authors: ddelnano matthewbentley

repo: Yelp/fullerite


text:
density plot and preview dataset functions

bors r+


text:
[v2.x] CHANGELOG for 2.5.2

#301 merged, merging this too.

authors: cben moolitayer

repo: abonas/kubeclient


text:
Bump README version to latest

Thank!

license: MIT


text:
Did not you think that using action.type in handler callback is redundant?

Actions may also have a meta property attached to them which needs to be available in the reducer. If we want to make this kind of change, the reducers will need to be passed the meta value as an optional third argument. It makes sense to me, but @acdlite will need to weigh in. I would also ask that with code change PRs you please make sure the related unit tests pass, it looks like there are 6 failing tests with this change. Thanks!

authors: coderany lukewestby

repo: acdlite/redux-actions


text:
Upgrade requirements

Codecov Report

Merging #158 (708fb25) into master (ef7ef7f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #158   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           66        66
  Branches        15        15
=========================================
  Hits            66        66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef7ef7f...708fb25. Read the comment docs.

Codecov Report

Merging #158 (708fb25) into master (ef7ef7f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #158   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           66        66
  Branches        15        15
=========================================
  Hits            66        66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef7ef7f...708fb25. Read the comment docs.

authors: adamchainz codecov-io

repo: adamchainz/django-feature-policy


text:
Fix dn/ds package description at PyPI

Fixed by 21772832c36923a57d58d99975092a09cda5a84e

repo: adelq/dnds


text:
Add German (Germany) translation (de-DE).

This is great. Thanks for your contribution!

authors: creighton sanduhrs

repo: adlnet/xAPIVerbs


text:
update log location for 2015 version of PS

@mcilroyc can you take a look at this?

cc @iwehrman @jaredadobe We'll need to make sure this gets in for the next release. Also, we should make a release branch for core as we approach feature complete. I'll add that to my list of reminders, and coordinate with you at that time.

Solid work, Joel.

authors: joelrbrandt mcilroyc

repo: adobe-photoshop/generator-core


text:
Feat/zeus/2020.4

There was one failing test in OTF, I have checked it manually.
When installing updates on a Primary that has a Secondary it now takes a lot more time.
Previously it took OTF maximum of 2.5 minutes (normally it took about 1 minute) to get update complete, now it took 4 minutes.
Do you want to improve this or should I adjust waiting times in OTF?

When installing updates on a Primary that has a Secondary it now takes a lot more time.
Previously it took OTF maximum of 2.5 minutes (normally it took about 1 minute) to get update complete, now it took 4 minutes.
Do you want to improve this or should I adjust waiting times in OTF?

Sorry, that's really annoying. I'm confused, though, for the last release/backport, we tried to change the connection logic specifically to improve the likelihood that OTF would pass. I'm not quite sure what changed between then and now to make it worse in a different way. @mike-sul do you have insight here?
At some point, though, I'm going to say we have to give up on bandaids for this problem and we should just try to solve it the "right" way as we've been discussing, meaning a proper connection manager.

Sorry, that's really annoying. I'm confused, though, for the last release/backport, we tried to change the connection logic specifically to improve the likelihood that OTF would pass. I'm not quite sure what changed between then and now to make it worse in a different way. @mike-sul do you have insight here?

Last time the problem was provisioning time, now it is installing the update time. It seems to me that it takes longer for the device to come back up after rebooting.

It seems to me that it takes longer for the device to come back up after rebooting.

Interesting, actually the timing should be improved in case of Primary update since Laurent added this if (proviisioned) statement which means that Primary won't try to connect to Secondaries after reboot if a device is provisioned. @Raigi Is/Are Secondary(ties) rebooted too in your case?

It seems to me that it takes longer for the device to come back up after rebooting.

Interesting, actually the timing should be improved in case of Primary update since Laurent added this if (proviisioned) statement which means that Primary won't try to connect to Secondaries after reboot if a device is provisioned. @Raigi Is/Are Secondary(ties) rebooted too in your case?

No, only primary got rebooted.
If I run journalctl -fu aktualizr on primary, it takes a bit time, before I get any logs. Sometimes it is much longer even.
-- Logs begin at Thu 2020-03-26 10:02:36 UTC. -- Mar 26 10:02:55 qemux86-64 aktualizr[229]: Connecting to and getting info about IP Secondary: 10.0.3.2:9050...

It seems to me that it takes longer for the device to come back up after rebooting.

Interesting, actually the timing should be improved in case of Primary update since Laurent added this if (proviisioned) statement which means that Primary won't try to connect to Secondaries after reboot if a device is provisioned. @Raigi Is/Are Secondary(ties) rebooted too in your case?

No, only primary got rebooted.
If I run journalctl -fu aktualizr on primary after reboot, it takes a bit time, before I get any logs. Sometimes it is much longer even.
-- Logs begin at Thu 2020-03-26 10:02:36 UTC. -- Mar 26 10:02:55 qemux86-64 aktualizr[229]: Connecting to and getting info about IP Secondary: 10.0.3.2:9050...

Now I understand, this delay is caused by this change https://github.com/advancedtelematic/meta-updater/commit/de993c695f58924fe8ee2b10a5b30af38afc42d3. But, IMHO, this is correct change as it makes aktualizr service not to start until all network interfaces are up and acquired IP addresses. Without this change, the Primary and Secondary discovery will fail in many cases because if this discovery process starts before a network interface acquires an IP address it will just simply fail because a connect timeout is not applied in this case and socket.connect() call just returns immediately with an error.

It seems to me that it takes longer for the device to come back up after rebooting.

Interesting, actually the timing should be improved in case of Primary update since Laurent added this if (proviisioned) statement which means that Primary won't try to connect to Secondaries after reboot if a device is provisioned. @Raigi Is/Are Secondary(ties) rebooted too in your case?

No, only primary got rebooted.
If I run journalctl -fu aktualizr on primary after reboot, it takes a bit time, before I get any logs. Sometimes it is much longer even.
-- Logs begin at Thu 2020-03-26 10:02:36 UTC. -- Mar 26 10:02:55 qemux86-64 aktualizr[229]: Connecting to and getting info about IP Secondary: 10.0.3.2:9050...

Now I understand, this delay is caused by this change de993c6. But, IMHO, this is correct change as it makes aktualizr service not to start until all network interfaces are up and acquired IP addresses. Without this change, the Primary and Secondary discovery will fail in many cases because if this discovery process starts before a network interface acquires an IP address it will just simply fail because a connect timeout is not applied in this case and socket.connect() call just returns immediately with an error.

OK, I see. So if this is expected, is it fine that I update tests to wait for update to finish for maximum of 5 minutes?

So if this is expected, is it fine that I update tests to wait for update to finish for maximum of 5 minutes?

I suppose so. It's annoying that it takes so long, but if Mike is correct, then that's simply how long it takes for the network interface to come up, so that's how long we have to wait.

So if this is expected, is it fine that I update tests to wait for update to finish for maximum of 5 minutes?

I suppose so. It's annoying that it takes so long, but if Mike is correct, then that's simply how long it takes for the network interface to come up, so that's how long we have to wait.

That's correct, it would be slightly faster if aktualizr depends just on an IP address assignment to the network interface used for communication between Primary and Secondary instead of waiting for such assignment to each network interface, but eventually we want aktualizr to communicate to the backend anyway...

authors: Raigi mike-sul mikesul-vd patrickvacek

repo: advancedtelematic/meta-updater


text:
Issue/display chain names

reference #104

authors: stanislav-slavov thepiwo

repo: aeternity/aepp-raendom

license: ISC


text:
CI for Node

Initializes with two players
Starts the game with a random player
Sets the current player to be whoever it is not

repo: agusk/github-actions-for-ci


text:
Dynamically generate CSS allowed properties

Fixing this by not whitelisting CSS attributes

repo: akerl/svgplot


text:
run go mod tidy to remove unused packages

@aksgithub


text:
corrected doc for 'multicast_loop_v4' function

Thanks!

authors: alexcrichton andykilroy


text:
Updating README systemd example to properly override ExecStart.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for pointing this out Joe

authors: CLAassistant PSjoe winder

repo: algorand/indexer


text:
Support rate limit

Fixed by #313

authors: ldxdl nejisama

repo: alipay/sofa-mosn


text:
updated readme

@aniketsharma00411 pls add hackotberfest accepted label


text:
the format commands "n" and "na" do not work for Function formatting

fixed by changing "na" spec to "N" to avoid conflict with "a" for arguments

repo: anywhichway/stringformatter


text:
Fix ITs broken by #1480

Awesome, thanks @keith-turner

authors: keith-turner milleruntime

repo: apache/accumulo


text:
ARROW-8369: [CI] Fix crossbow R group

@github-actions crossbow submit -g r

@github-actions crossbow submit -g r

@github-actions crossbow submit -g nightly

@kszucs @wesm A few things I've noticed:

Apparently you can't start a glob with *. Maybe that's a yaml thing? Maybe not. Didn't try to debug.
If you have a group that has a glob pattern and then something else, only the first glob is used. In the R task list above, there are two entries in the group definition, and the second one (macos-r-autobrew) was not included.
The nightly group fails (see here), my guess is that the greedy pattern matching is pulling in jobs that we weren't including previously and that don't actually work.
Y'all should do an audit of what's included and what isn't. I fixed a handful of discrepancies between what was run before and what is being run now (assuming of course that they run), but there may be more. And as (3) suggests, there may be stale, broken tasks in the yaml that should be cleaned out.

Maybe this is a good opportunity to bootstrap a small unit test suite

@kszucs @wesm A few things I've noticed:

Apparently you can't start a glob with *. Maybe that's a yaml thing? Maybe not. Didn't try to debug.
Yes, that is reserved for YAML anchors. If use enclose it with quotes then yaml will treat it as string so it will work.
If you have a group that has a glob pattern and then something else, only the first glob is used. In the R task list above, there are two entries in the group definition, and the second one (macos-r-autobrew) was not included.
That's because I renamed macos-r-autobrew  to homebrew-r-autobrew ala the existsing homebrew-cpp-autobrew - so macos-r-autobrew doesn't exists anymore.
The nightly group fails (see here), my guess is that the greedy pattern matching is pulling in jobs that we weren't including previously and that don't actually work.
I'm investigating this.
Y'all should do an audit of what's included and what isn't. I fixed a handful of discrepancies between what was run before and what is being run now (assuming of course that they run), but there may be more. And as (3) suggests, there may be stale, broken tasks in the yaml that should be cleaned out.
I'm trying to add a subcommand to validate the configuration.

Re: validation, I agree with @wesm that this sounds like something that belongs in a test suite. Make sure that all groups refer to tasks that exist, and make sure that all tasks render their templates without error.

I've added logic to test the configuration in #6875 I'll implement proper unittests for crossbow once I port it to archery.

@github-actions crossbow submit --dry-run -g r

authors: kszucs nealrichardson wesm

repo: apache/arrow


text:
BIGTOP-2775. Make open jdk 8 available on bigtop/puppet:debian-8

+1

repo: apache/bigtop


text:
Adds SshCommandEffectorYamlTest

Thanks @aledsage, @duncangrant, merging.

authors: aledsage neykov

repo: apache/brooklyn-server


text:
removes @ from anchor, to fix heading

Thanks

authors: danhaywood oscerd

repo: apache/camel


text:
GEODE-5693: Use clang-tidy in travis build.

See output from travis build. Sadly it takes about 2h to run. I was able to get travis.ci to increase our build timeout to accommodate. Hopefully as we improve includes that build time will improve.

repo: apache/geode-native


text:
HBASE-24740 Enable journal logging for HBase snapshot operation

Sample Journal entry:
Table snapshot journal :
Running FLUSH table snapshot test_snapshot C_M_SNAPSHOT_TABLE on table test at 1594859523584
Consolidate snapshot: test_snapshot at 1594859523691 (+107 ms)
Loading Region manifests for test_snapshot at 1594859523692 (+1 ms)
Writing data manifest for test_snapshot at 1594859523693 (+1 ms)
Verifying snapshot: test_snapshot at 1594859523706 (+13 ms)
Snapshot test_snapshot of table test completed at 1594859523710 (+4 ms)

@apurtell @bharathv @virajjasani  Can you please review ?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
0m  7s
Docker failed to build yetus/hbase:7cf97016b9.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/2076

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 49s
branch-1 passed

+1 :green_heart:
compile
0m 40s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK v1.7.0_262

+1 :green_heart:
checkstyle
1m 41s
branch-1 passed

+1 :green_heart:
shadedjars
3m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 41s
branch-1 passed with JDK v1.7.0_262

+0 :ok:
spotbugs
3m  3s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  0s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 56s
the patch passed

+1 :green_heart:
compile
0m 42s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javac
0m 42s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
javac
0m 44s
the patch passed

+1 :green_heart:
checkstyle
1m 28s
hbase-server: The patch generated 0 new + 20 unchanged - 10 fixed = 20 total (was 30)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 46s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 45s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 44s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
findbugs
2m 54s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
133m 40s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 38s
The patch does not generate ASF License warnings.

175m 40s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2076

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 34822685206c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2076/out/precommit/personality/provided.sh

git revision
branch-1 / 71aec0f

Default Java
1.7.0_262

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/2/testReport/

Max. process+thread count
4488 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/2/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Looks good overall, few minor nits. We are planning PR for master branch also?

Yes @virajjasani  , we can commit this PR for master branch as well

LGTM

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 43s
branch-1 passed

+1 :green_heart:
compile
0m 41s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
compile
0m 44s
branch-1 passed with JDK v1.7.0_262

+1 :green_heart:
checkstyle
1m 40s
branch-1 passed

+1 :green_heart:
shadedjars
3m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 47s
branch-1 passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK v1.7.0_262

+0 :ok:
spotbugs
2m 58s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 55s
branch-1 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 54s
the patch passed

+1 :green_heart:
compile
0m 43s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javac
0m 43s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
javac
0m 44s
the patch passed

+1 :green_heart:
checkstyle
1m 29s
hbase-server: The patch generated 0 new + 20 unchanged - 10 fixed = 20 total (was 30)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 47s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 34s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK v1.8.0_252

+1 :green_heart:
javadoc
0m 43s
the patch passed with JDK v1.7.0_262

+1 :green_heart:
findbugs
2m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
132m  0s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 37s
The patch does not generate ASF License warnings.

173m 20s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2076

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 76406a1354d4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2076/out/precommit/personality/provided.sh

git revision
branch-1 / 37903b0

Default Java
1.7.0_262

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_252 /usr/lib/jvm/zulu-7-amd64:1.7.0_262

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/3/testReport/

Max. process+thread count
4280 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2076/3/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

authors: Apache-HBase liuml07 sguggilam

repo: apache/hbase


text:
HIVE-24433 - AutoCompaction is not getting triggered for CamelCase Partition Values

Hi @nareshpr  thanks for picking this up. Could you add a test case to TestInitiator that covers this use case.
cc @klcopp  @deniskuzZ

Thanks for looking into this @pvargacl. I added testcase in TestInitiator, please review

authors: nareshpr pvargacl

repo: apache/hive


text:
Add ab run for TEST_SSL jobs.

Seems to confirm that pools get corrupted somehow with memcache being used.

authors: notroj rpluem

repo: apache/httpd


text:
set max number of open files in start-node.sh

This should better be put into env.sh instead of start-node.sh, so it may affect both stand-alone and cluter verison.

By the way, we did not add this because we thought that it was improper for an application to modify OS configuration without a proper request to the user.

By the way, we did not add this because we thought that it was improper for an application to modify OS configuration without a proper request to the user.

I think we could do this for user. The user may not be familiar with the system, but if they have used it in production system, it's too late to modify the limit when system get error.
How do you think? @jixuan1989

Maybe we can ask the user like this:
./start-node.sh
Warning: System maximum open file number is too small, IoTDB wishes to set it to 65535.[y/n]

Maybe we can ask the user like this:
./start-node.sh
Warning: System maximum open file number is too small, so IoTDB wishes to set it to 65535.[y/n]

Good idea.

authors: jt2594838 mychaow yanhongwangg

repo: apache/iotdb


text:
KAFKA-5932: Avoid call to fetchPrevious in FlushListeners

ping @dguy @mjsax @guozhangwang

Updated for comments.

PR seems reasonable to me. But don't know this part of the code very well.

updated this

looks like one of my comments got swallowed in the update https://github.com/apache/kafka/pull/3978#discussion_r141688116

@xvrl responded above

retest this please

merged to trunk

To benchmark the changes I modified the count test in SimpleBenchmark to this
input.groupByKey() .windowedBy(TimeWindows.of(500))
            .count(Materialized.<Integer, Long, WindowStore<Bytes, byte[]>>as("tmpStoreName")
            .withValueSerde(Serdes.Long()).withCachingEnabled())
            .toStream().foreach(new CountDownAction(latch));

Bottom line, skipping fetchPrevious helps performance by roughly 30%.
Here is the results spreadsheet

@bbejeck thanks for the benchmark numbers. I'm assuming you ran those with default caching settings? If so that's a pretty big improvement given that we probably aren't flushing the cache very often, but it's hard to interpret without knowing how often we flush. I'd be curious to see the "raw" improvements would be if we set the cache size to zero.

@xvrl no problem.
Yes, I ran those benchmarks using default cache settings.  I can re-run the benchmarks and set the cache size to zero and update the results.

@xvrl here's an updated benchmark using the same code, but with caching set to zero
https://docs.google.com/spreadsheets/d/1SJtqGsWwFzxX8uVl2JP7zp8m_7CLMK8HTq8UkAVRYoo/edit#gid=0

authors: bbejeck dguy mjsax xvrl

repo: apache/kafka


text:
KYLIN-4246 Fix for null value and non-exist value in json parser.

Can one of the admins verify this patch?

Codecov Report

Merging #944 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #944      +/-   ##
============================================
- Coverage     25.58%   25.56%   -0.02%
+ Complexity     6140     6138       -2
============================================
  Files          1412     1412
  Lines         85072    85072
  Branches      11928    11928
============================================
- Hits          21762    21750      -12
- Misses        61205    61213       +8
- Partials       2105     2109       +4

Impacted Files
Coverage Δ
Complexity Δ

...lin/stream/source/kafka/TimedJsonStreamParser.java
71.76% <0%> (ø)
12 <0> (ø)
:arrow_down:

...he/kylin/dict/lookup/cache/RocksDBLookupTable.java
72.97% <0%> (-5.41%)
6% <0%> (-1%)

...org/apache/kylin/rest/util/QueryRequestLimits.java
35.71% <0%> (-4.77%)
5% <0%> (-1%)

...he/kylin/job/impl/threadpool/DefaultScheduler.java
74.41% <0%> (-2.33%)
12% <0%> (ø)

.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java
63.84% <0%> (-2.31%)
0% <0%> (ø)

...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java
69.3% <0%> (-0.92%)
7% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de98cf...9c7bffc. Read the comment docs.

Pull Request Test Coverage Report for Build 5228

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
8 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.006%) to 28.049%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

stream-source-kafka/src/main/java/org/apache/kylin/stream/source/kafka/TimedJsonStreamParser.java
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java
1
81.08%

core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
2
80.23%

core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java
5
77.81%

Totals

Change from base Build 5214:
-0.006%

Covered Lines:
23862

Relevant Lines:
85072

💛  - Coveralls

Here is my test

Prepare following sample as input of kafka producer

### Complete message without null value
{"required_dimension_1" : 1, "optional_dimension_1": "a", "measure_1" : 100, "ts":1573866250450}
{"required_dimension_1" : 2, "optional_dimension_1": "a", "measure_1" : 100, "ts":1573866250450}
{"required_dimension_1" : 3, "optional_dimension_1": "a", "measure_1" : 100, "ts":1573866250450}
{"required_dimension_1" : 4, "optional_dimension_1": "a", "measure_1" : 100, "ts":1573866250450}
{"required_dimension_1" : 5, "optional_dimension_1": "a", "measure_1" : 100, "ts":1573866250450}

### Complete message with some null value
{"required_dimension_1" : 1, "optional_dimension_1": "", "measure_1" : 100, "ts":1573866250450}
{"required_dimension_1" : 2, "optional_dimension_1": "NULL", "measure_1" : 100, "ts":1573866250450}
{"required_dimension_1" : 3, "optional_dimension_1": "null", "measure_1" : 100, "ts":1573866250450}
{"required_dimension_1" : 4, "optional_dimension_1": null, "measure_1" : 100, "ts":1573866250450}
{"required_dimension_1" : 5, "optional_dimension_1": null, "measure_1" : 100, "ts":1573866250450}

### Miss optional_dimension_1 field in message
{"required_dimension_1" : 1, "measure_1" : 100, "ts":1573866250450}
{"required_dimension_1" : 2, "measure_1" : 100, "ts":1573866250450}
{"required_dimension_1" : 3, "measure_1" : 100, "ts":1573866250450}
{"required_dimension_1" : 4, "measure_1" : 100, "ts":1573866250450}
{"required_dimension_1" : 5, "measure_1" : 100, "ts":1573866250450}

### Wrong data type in message
{"required_dimension_1" : 1, "optional_dimension_1": "d", "measure_1" : 100, "ts":1573866250450}
{"required_dimension_1" : 2, "optional_dimension_1": "d", "measure_1" : 100, "ts":1573866250450}
{"required_dimension_1" : 3, "optional_dimension_1": "d", "measure_1" : 100, "ts":1573866250450}
{"required_dimension_1" : 4, "optional_dimension_1": ["dd", "ddd", "dddd"], "measure_1" : 100, "ts":1573866250450}
{"required_dimension_1" : 5, "optional_dimension_1": {"d": 100, "dd": 100}, "measure_1" : 100, "ts":1573866250450}

create model and cube in Kylin
Send them via sh bin/kafka-console-producer.sh --broker-list cdh-master:9092,cdh-worker-1:9092,cdh-worker-2:9092 --topic 4246.
Test my query.

Model and Cube and SQL
{
  "uuid": "11e2bbd5-f0f5-ac36-7877-61bfe1edafcc",
  "last_modified": 1573865791073,
  "version": "3.0.0.20500",
  "name": "TestNullRT",
  "owner": "ADMIN",
  "is_draft": false,
  "description": "",
  "fact_table": "DEFAULT.TESTNULL",
  "lookups": [],
  "dimensions": [
    {
      "table": "TESTNULL",
      "columns": [
        "REQUIRED_DIMENSION_1",
        "OPTIONAL_DIMENSION_1",
        "HOUR_START",
        "MINUTE_START"
      ],
      "id": 1
    }
  ],
  "metrics": [
    "TESTNULL.MEASURE_1"
  ],
  "filter_condition": "",
  "partition_desc": {
    "partition_date_column": null,
    "partition_time_column": null,
    "partition_date_start": 0,
    "partition_date_format": "yyyy-MM-dd",
    "partition_time_format": "HH:mm:ss",
    "partition_type": "APPEND",
    "partition_condition_builder": "org.apache.kylin.metadata.model.PartitionDesc$DefaultPartitionConditionBuilder"
  },
  "capacity": "MEDIUM"
}

{
  "uuid": "f58ad99b-b325-f2ca-6acb-c9abd8bcd595",
  "last_modified": 1573866225347,
  "version": "3.0.0.20500",
  "name": "TestNullCube",
  "is_draft": false,
  "model_name": "TestNullRT",
  "description": "",
  "null_string": null,
  "dimensions": [
    {
      "name": "REQUIRED_DIMENSION_1",
      "table": "TESTNULL",
      "column": "REQUIRED_DIMENSION_1",
      "derived": null
    },
    {
      "name": "OPTIONAL_DIMENSION_1",
      "table": "TESTNULL",
      "column": "OPTIONAL_DIMENSION_1",
      "derived": null
    },
    {
      "name": "HOUR_START",
      "table": "TESTNULL",
      "column": "HOUR_START",
      "derived": null
    },
    {
      "name": "MINUTE_START",
      "table": "TESTNULL",
      "column": "MINUTE_START",
      "derived": null
    }
  ],
  "measures": [
    {
      "name": "_COUNT_",
      "function": {
        "expression": "COUNT",
        "parameter": {
          "type": "constant",
          "value": "1"
        },
        "returntype": "bigint"
      }
    },
    {
      "name": "SUM_MEASURE_1",
      "function": {
        "expression": "SUM",
        "parameter": {
          "type": "column",
          "value": "TESTNULL.MEASURE_1"
        },
        "returntype": "bigint"
      }
    }
  ],
  "dictionaries": [],
  "rowkey": {
    "rowkey_columns": [
      {
        "column": "TESTNULL.REQUIRED_DIMENSION_1",
        "encoding": "dict",
        "encoding_version": 1,
        "isShardBy": false
      },
      {
        "column": "TESTNULL.OPTIONAL_DIMENSION_1",
        "encoding": "dict",
        "encoding_version": 1,
        "isShardBy": false
      },
      {
        "column": "TESTNULL.HOUR_START",
        "encoding": "time",
        "encoding_version": 1,
        "isShardBy": false
      },
      {
        "column": "TESTNULL.MINUTE_START",
        "encoding": "time",
        "encoding_version": 1,
        "isShardBy": false
      }
    ]
  },
  "hbase_mapping": {
    "column_family": [
      {
        "name": "F1",
        "columns": [
          {
            "qualifier": "M",
            "measure_refs": [
              "_COUNT_",
              "SUM_MEASURE_1"
            ]
          }
        ]
      }
    ]
  },
  "aggregation_groups": [
    {
      "includes": [
        "TESTNULL.REQUIRED_DIMENSION_1",
        "TESTNULL.OPTIONAL_DIMENSION_1",
        "TESTNULL.HOUR_START",
        "TESTNULL.MINUTE_START"
      ],
      "select_rule": {
        "hierarchy_dims": [],
        "mandatory_dims": [],
        "joint_dims": []
      }
    }
  ],
  "signature": "yxjdGQqJwieSRlxHdhDwww==",
  "notify_list": [],
  "status_need_notify": [
    "ERROR",
    "DISCARDED",
    "SUCCEED"
  ],
  "partition_date_start": 0,
  "partition_date_end": 3153600000000,
  "auto_merge_time_ranges": [
    604800000,
    2419200000
  ],
  "volatile_range": 0,
  "retention_range": 0,
  "engine_type": 2,
  "storage_type": 3,
  "override_kylin_properties": {
    "kylin.stream.cube.window": "600",
    "kylin.stream.cube.duration": "300",
    "kylin.stream.index.checkpoint.intervals": "300",
    "kylin.cube.algorithm": "INMEM",
    "kylin.stream.segment.retention.policy": "fullBuild"
  },
  "cuboid_black_list": [],
  "parent_forward": 3,
  "mandatory_dimension_set_list": [],
  "snapshot_table_desc_list": []
}

select count(*) as total_row from NULLTEST

select REQUIRED_DIMENSION_1, OPTIONAL_DIMENSION_1 ,count(*) as row_count, sum(measure_1) as sum_1
from NULLTEST
where OPTIONAL_DIMENSION_1 is not null
group by REQUIRED_DIMENSION_1, OPTIONAL_DIMENSION_1
order by REQUIRED_DIMENSION_1, OPTIONAL_DIMENSION_1

select REQUIRED_DIMENSION_1, OPTIONAL_DIMENSION_1 ,count(*) as row_count, sum(measure_1) as sum_1
from NULLTEST
where OPTIONAL_DIMENSION_1 is null
group by REQUIRED_DIMENSION_1, OPTIONAL_DIMENSION_1
order by REQUIRED_DIMENSION_1, OPTIONAL_DIMENSION_1

select REQUIRED_DIMENSION_1, OPTIONAL_DIMENSION_1 ,count(*) as row_count, sum(measure_1) as sum_1
from NULLTEST
group by REQUIRED_DIMENSION_1, OPTIONAL_DIMENSION_1
order by REQUIRED_DIMENSION_1, OPTIONAL_DIMENSION_1

Q1

Q2

Q3

authors: asf-ci codecov-io coveralls hit-lacus

repo: apache/kylin


text:
Apply the suggestion in rfc7233

Thanks. I have applied 2 of the 3 changes to 9.0.x (range units and etag) with some additional refactoring / clean-up as well as additional comments.
I thin the remaining change needs to be made optional as many clients have implemented partial PUT even if the intention of the RFC 2616 authors was not to allow it. This is next on my TODO list followed by back-porting all the Rnage improvements inspired by your PRs.

For a put request, usually it won't have a header 'Range', The header specified in rfc 2616 is 'Content-Range'.
What will happen to a put request if header 'Range' is specified?
Put the content in specified URI and then return partial content of the entity. We can see existed source in tomcat, either 201 or 204 is returned, both have no response body content.
IMO, this change can also be applied too.

Thanks for the the review. I had mis-remembered how partial PUTs were implemented. I'll take another pass at the patch.

I think everything is complete now. Feel free to re-open if you spot something I missed.

Good job, there is no issue with the range request now.

authors: markt-asf zhanhb

repo: apache/tomcat


text:
Added a basic CODEOWNERS

[approve ci autest]

[approve ci autest]

authors: randall zwoop

repo: apache/trafficserver


text:
Configure Renovate to group Google APIs together

Renovate config validation came up good. Merging.

repo: apereo/openEQUELLA


text:
added client certificate support

@seantdg - with this change merged, how do you run tests locally, e.g. gulp test?

depending on your settings - you may need to run with the mock with sudo?

On your local, if you start the tests with gulp test (like we all do), your test will fail.

authors: seantdg seymen

repo: apickli/apickli


text:
Updated: far 3.0.5454.1124

Newer version of far (3.0.5503.1263) is now available in master. e6b9eae4db64098a404e77c61e3124d8eedcb89e


text:
[concurrency] SIL: handle hop_to_executor instruction in MemAccessUtils

@swift-ci smoke test and merge

repo: apple/swift


text:
fix minor readme typo

Codecov Report

Merging #75 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   79.51%   79.51%
=======================================
  Files           2        2
  Lines         288      288
=======================================
  Hits          229      229
  Misses         57       57
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdab57c...67f243e. Read the comment docs.

authors: bobwei codecov-io

repo: appleboy/drone-line


text:
fix: typo

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   10.16%   10.16%
=======================================
  Files           3        3
  Lines         177      177
=======================================
  Hits           18       18
  Misses        159      159

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af9d10...0273242. Read the comment docs.

authors: appleboy codecov-io

repo: appleboy/drone-sftp-cache


text:
Update the Shell Storm url

Thanks

authors: apsdehal everping

repo: apsdehal/awesome-ctf


text:
Configure zipkin endpoint, use Zipkin.ServiceName

Thank You

authors: ardan-bkennedy dmitriyminer

repo: ardanlabs/service


text:
fix: spelling of cif property symmetry_space_group_name_H-M

thanks!

authors: arose ppillot

repo: arose/ngl


text:
Fix cURL link to latexonline util

Thanks!

authors: aslushnikov lologhi

repo: aslushnikov/latex-online


text:
Add autoenv, bash-funk, direnv, testssl.sh

+1 for direnv, use it all the time.

Closing this PR - it is based off of changes to readme.md - which has since been renamed to README.md in the intervening years. Anyone feel free to open a new PR to add any of any of these bash utilities / applications / tools.

authors: hyperupcall kigster sebthom

repo: awesome-lists/awesome-bash


text:
Small improvements and code formatting for interpreters.

Coverage increased (+4.0e-05%) to 99.976% when pulling 16b74cd6e4911c7e9abee5dd7e73af246780705b on interpreter-improvements into fcdc80ceba43f6a10136d069a4ef40144eb63209 on release-candidate.

authors: coveralls mtabacman

repo: ba-st/Willow


text:
Add zh_cn dosc for client_auth example. Resolve #125.

Codecov Report

Merging #167 into develop will increase coverage by 0.02%.
The diff coverage is 44.44%.

@@             Coverage Diff             @@
##           develop     #167      +/-   ##
===========================================
+ Coverage    52.82%   52.85%   +0.02%
===========================================
  Files          217      217
  Lines        21579    21588       +9
===========================================
+ Hits         11400    11410      +10
+ Misses        8886     8885       -1
  Partials      1293     1293

Impacted Files
Coverage Δ

bfe_config/bfe_conf/conf_https_basic.go
47.22% <44.44%> (-2.28%)
:arrow_down:

bfe_util/fixed_pool.go
83.33% <0%> (-16.67%)
:arrow_down:

bfe_http2/server.go
71.83% <0%> (+0.32%)
:arrow_up:

bfe_spdy/server_write_sched.go
80% <0%> (+1.53%)
:arrow_up:

bfe_websocket/server_conn.go
75.75% <0%> (+3.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0423f8...f2d67cf. Read the comment docs.

repo: baidu/bfe


text:
Introduce array length expression.

This is fixed with the following PR.
https://github.com/ballerinalang/ballerina/pull/2372

authors: djkevincr sameera-jayasoma

repo: ballerinalang/ballerina


text:
doc: add dev section

:tada: This PR is included in version 4.7.0 :tada:
The release is available on:

v4.7.0
GitHub release

Your semantic-release bot :package::rocket:

repo: baloise/gitopscli


text:
Minor fixes

Codecov Report

Merging #16 into master will decrease coverage by 0.11%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   75.51%   75.39%   -0.12%
==========================================
  Files          14       14
  Lines        1074     1077       +3
==========================================
+ Hits          811      812       +1
- Misses        263      265       +2

Impacted Files
Coverage Δ

src/metafuncs.jl
89.47% <ø> (ø)

src/model.jl
69.58% <50.00%> (-0.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d49b21...c4970fb. Read the comment docs.

authors: bbejanov codecov-commenter


text:
Somebody please rewrite tests for BSTree to BSTree<K,V>

Fixed by @hmil in #90

repo: basarat/typescript-collections


text:
Merge 2.1.4 release to 2.1 branch

👍

authors: JeetKunDoug tburghart

repo: basho/riak


text:
怎么下载图片（短视频）呢？

目前不支持这个功能，下载图片建议用 https://github.com/rs/SDWebImage

谢谢

repo: bawn/LCNetwork


text:
Minor bugfix when using Cmder

Thanks!
I won't make a release before tomorrow, though

authors: Lucas-C berdario

repo: berdario/pew


text:
fix for spark version switching

Coverage decreased (-0.5%) to 70.256% when pulling 46f074d35fa5ca46566eeff7d2b93ff40f6031f7 on akmorrow13:master into cbdf747a0149e08534eabfaa09835e3365033464 on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/mango-prb/357/
Test PASSed.

Coverage decreased (-0.5%) to 70.256% when pulling 1e9250bc4d433adf0b1451d1e4860125b5272d1d on akmorrow13:master into cbdf747a0149e08534eabfaa09835e3365033464 on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/mango-prb/358/
Test PASSed.

authors: AmplabJenkins akmorrow13 coveralls

repo: bigdatagenomics/mango


text:
setTime always be 0

Codecov Report

Merging #43 into master will decrease coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   78.57%   78.31%   -0.27%
==========================================
  Files          11       11
  Lines        1148     1148
==========================================
- Hits          902      899       -3
- Misses        180      183       +3
  Partials       66       66

Impacted Files
Coverage Δ

naming/client.go
71.9% <0%> (-0.78%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f112a9e...429adf4. Read the comment docs.

authors: codecov-io waterandair

repo: bilibili/discovery


text:
Qingwei/docs

Coverage remained the same at 57.391% when pulling 035f5ffeaf5cfce05fd6ebd74ab1c65d0898f0a6 on qingweibinary:qingwei/docs into 3ca42fe80938a35c15b655dc9078673ac5fe288a on binary-com:master.

Coverage remained the same at 57.391% when pulling 4fd71d723bab7b98021835866d5c047be718bf8d on qingweibinary:qingwei/docs into 3ca42fe80938a35c15b655dc9078673ac5fe288a on binary-com:master.

authors: coveralls qingweibinary

repo: binary-com/binary-charts


text:
Add GitHub Actions config for running typescript compiler and unit tests

This will be somewhat complicated, as this module directly depends on Companion core being in a parent directory.

repo: bitfocus/companion-module-youtube-live


text:
Move bit-confirm logic into client lib so it can be tested

Recreated in bitcore-wallet-client & bitcore-wallet

repo: bitpay/bitcore-wallet-service


text:
Release 1.0.0 beta.5

Current coverage is 100% (diff: 100%)

Merging #55 into master will not change coverage

@@           master   #55   diff @@
===================================
  Files          21    21
  Lines         475   475
  Methods        55    55
  Messages        0     0
  Branches       54    54
===================================
  Hits          475   475
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 8e9eb71...18ada3d

authors: Blackbaud-BobbyEarl codecov-io

repo: blackbaud/skyux-builder


text:
chore: minor simplification

:tada: This PR is included in version 1.12.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: MrsFlux simlu

repo: blackflux/node-tdd


text:
Add rados.py and rbd.py to glance and cinder venvs

This needs to be rebased, and I think we need a set of tasks to do this for package based installs too, which is a different path so maybe need a second set of tasks.

repo: blueboxgroup/ursula


text:
Fix heat sla-metrics conf file name

This is already done in https://github.com/blueboxgroup/ursula/pull/1369/files#diff-0e23e74542e84f9be6087e8d9a0b7fb4L20   #1369


text:
Update .travis.yml

Travis tests has failed
Powered by: Travis Buddy

Travis tests has failed
Powered by: Travis Buddy

repo: bluzi/name-db


text:
Refactoring codebase for Bolt 3.0

The JS is failing:
Uncaught SyntaxError: Unexpected token <
view/js/src/cheatsheet.js:1

Are you sure you've pulled the latest?  :-)
The source uses a different file:
<script src="view/js/cheatsheet.js"></script>

And the file you mention does not have a single < in it.

Fresh clone, and that was a copy/pasta response that I added in to try and load the un-minimised version… original assertion still valid.

I'm probably being dumb here, but it doesn't make a lot of sense that you'd get that notice.

It's JavaScript… so all bets are off as to the "Dumb Factor" and who is responsible :grin:

@GawainLynch I PSR4-ified it, but I have no idea where your Javascript issues are coming from, though.. Typical 'Works for me'™ thing. You can show me tomorrow. :-)

Whatever you did… it works for me now!

authors: GawainLynch bobdenotter

repo: bolt/cheatsheet


text:
Add library http-status

@misak113 thanks mate!

repo: borisyankov/DefinitelyTyped


text:
allow full base64 jws parts during decode/verify/isValid. fixes #22

So, the tricky bit.
As is, taking the s4, ecured input will be full padded base64. node-jwa will happily accept that; however, it is against spec. We could transform them to be url-safe before passing it to jwa, but at that point the signature likely wouldn't be valid, as the signing implementation probably signed the full base64.
Despite my comments in #25, seems like it might be better/easier to not play nice with non-compliant implementations.

A few thoughts on the conversation about #25 and your concerns:
The spec is clear that base64url encoding should be used. There are a [bunch of MUSTs]
(https://tools.ietf.org/html/rfc7515#page-20) that define how the values of a JWS object's members should be encoded, and they all say something like this:

The "payload" member MUST be present and contain the value BASE64URL(JWS Payload).

Also, I'm not sure what you meant here? I don't see how the reference for decoding base64url strings is lenient. It takes a base64url string, replaces - with + and _ with / and then adds the appropriate number of = so the string can be decoded with standard base64Decode implementations.
So, :+1: to your comment that it's better/easier comply with the spec. Implementing base64 is not a good idea and could lead to confusion when folks use this package.

Yeah, if the spec's using MUST I say we stay compliant. Closing this for now!

Sounds good to me
On 7 Aug 2015 12:28, "Brian J Brennan" notifications@github.com wrote:

Yeah, if the spec's using MUST I say we stay compliant. Closing this for
now!
—
Reply to this email directly or view it on GitHub
https://github.com/brianloveswords/node-jws/pull/30#issuecomment-128756842
.

authors: brianloveswords omsmith taravancil

repo: brianloveswords/node-jws


text:
Added upgrading docs

This should maybe include multiple upgrading subheadings, though for now it would just be one for 2.x -> 3.x.

Or just name the file UPGRADING-3.0?

We could, though having more than one or two would be cluttered. What about something similar to the changelog format, like:
# Upgrading

## v2 to v3
…

Something like this then: https://github.com/thephpleague/factory-muffin/blob/2.1/UPGRADING.md?

Yep! That looks good.

We can include a link to our v3 docs when they're ready. We can write some examples and stuff there.

authors: GrahamCampbell kattrali

repo: bugsnag/bugsnag-php


text:
Parameterize jenkins user uid/gid in docker build

@caffe2bot retest this please


text:
Work on protobuf static and hidden

We are close! :)

Looks like there's a protobuf compatibility error that starts with ONNX. Not sure why this is an issue in conda specifically, but I'll talk with @pjh5 tomorrow.

Conda one seems to be just inclusion path error - I think it's probably some flags that we need to pass.

On conda, the "/Applications/Xcode9.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: ../../../lib/libprotobuf.a(atomicops_internals_x86_msvc.cc.o) has no symbols" errors on Mac seem to be https://stackoverflow.com/questions/23603355/ranlib-ar-in-mac-os-gives-me-has-no-symbols-warning , where Windows specific protobuf files are empty on Mac and the static linker doesn't like that

Thanks to @pjh5 for the suggested changes above. We'll see how the tests go and then we'll need to decide when we'll turn this static linking on. For binary installs, but maybe not for default source builds and installs?

I want to land these changes, so I'm going to (a) roll back the conda changes and (b) disable static linking for now. We can look at enabling it again in some cases next week, but hopefully we can get this code into master.

authors: Yangqing orionr pjh5


text:
Implement blockly changes into build.py file

Hi Carlos,
I tried fixing this myself, but got tied up in knots with the build.py. Presumably it's something to do with making sure the static-typing file is included in the build process...

Yeah, been looking into this during the past couple of days, still no luck. Static Typing seems to be included correctly, however I'm getting issues with the blocks file.

It all was caused by small mistakes made by not really knowing how the closure library works when I started developing Ardublockly. Made a few changes to get it working in 154d9f123aa26a92b2bc5d5e052ba6c3cefeafc2, still a few improvements coming to refine a few things.

authors: carlosperate syriley

repo: carlosperate/ardublockly


text:
Mappings initial

Going to hold off on this until we figure out how we are going to restructure the github repos.

authors: casework sbarnum

repo: casework/case


text:
Remove -SNAPSHOT from 4.1

LGTM

repo: caskdata/cdap-apps


text:
Fix url,homepage in cpumeter.app Cask

Thank you for the contribution. It was merged directly as 4099bccc6a1950880f523d2448c649176a9f2754 to keep commit history cleaner. Your contribution is still credited to you.

authors: vitorgalvao yusukeshibata

repo: caskroom/homebrew-cask


text:
Upgrade BackupLoupe.app to v2.9

Merged as d7634b088bd8107d6c4f7796d02aad49cccc6184.


text:
adding US data/reports

@moiradillon2 There's a conflict with the pull. I'll resolve and merge. Please, hold any other pulls for now. Thanks!

@moiradillon2 You're good to go!

repo: cdcepi/zika


text:
Git Assignment 1a

Try again

authors: cengique jeremiabryan

license: Unlicense


text:
Add tests for REST API

@sonufrienko Hey! I may be signing myself up some punishment here with testing, but I would like to claim this issue and create a test suite for the API, if you're accepting PR's?
Is there currently any testing going on in the code base? (Hadn't seen any from my brief check...) Is there a specific testing framework you would prefer to be used? I would probably go for some combination of Mocha/Jest.

authors: sonufrienko titchimoto

repo: cezerin/cezerin


text:
Add rsa_cert_credentials field to sample tile

Please reopen if this is still an issue

authors: keshto mboldt

repo: cf-platform-eng/tile-generator


text:
add example fast-rnaseq template

Thanks for this, let me know if the fast RNA-seq part can be improved, not many folks are using it so feedback is helpful.

Well, since you asked... 😄
I think it'd be nice to be able to turn on things like FastQC or kraken... essentially to make it more modular, rather than all (RNA-seq) or next to nothing (fastrna-seq). Related to that, it seems the qualimap step in the regular RNA-seq pipeline is not multithreaded, and takes forever. Like, hours. Longer than anything else. An example of something I'd like to turn off on some occasions if it can't be multithreaded.
Another point of confusion for me, why sailfish in the RNA-seq pipeline but salmon in the fast pipeline? Why not salmon for both, or the ability to choose?
Finally, I don't think it's a big time sink, but it looks like it's rebuilding the sailfish or salmon index every time. Would it not make more sense to save the indexes in genomes?

Could you add yourself as a contributor in the README? Thanks!
We're definitely swapping to Salmon, the kmer shredding algorithm in Sailfish destroys information which is retained by the MEM style quasialignments that Salmon does, and Salmon can spit out BAM files of the quasi alignments so we can theoretically do QC. I just haven't had the chance to vet some of the bias correction options yet so I don't want to swap what's there out from under folks since while I think Salmon is better, Sailfish does a great job.

Thanks, Qualimap can be super slow; there are steps in there that are multithreaded but I think some of the tools aren't. @lpantano do you know where the bottleneck might be? Maybe we can do something to speed it up a bit.
The Salmon index is kept as a per-project thing because it isn't too much overhead to recreate the index and it lets folks run whatever versions of the transcripts they want to quantitate against; we update the pre-created tarballs pretty infrequently since we need all the downstream stuff like snpEff and VEP and whatnot to match up, so we're unfortunately usually a couple Ensembl annotation releases behind.

Hi,
Right now, I dont have a simple solution for that. Some times is fast, sometime is slow.  And I didn't find the culprit of that.
There is an option that is not documented right now, because I guess is not fully tested, but if you add qc under algorithm section and give, for instance: [fastqc, samtools] it would do only those steps during QC.
Right now, duplicates and rRNA are inside qualimap function, maybe we can add qualimap to things to turn off and separate rRNA and duplicates metrics from qualimap. what do you think @roryk ?

Sure, it would be nice to know what step is going slow as well. Do the qualimap logs give some feedback about where the stuck steps might be?

I believe the dexseq counting takes a while too. Would be nice to be able
to turn this off as well. Haven't used DEXSeq in years.
On Thu, Dec 8, 2016 at 3:39 PM, Rory Kirchner notifications@github.com
wrote:

Sure, it would be nice to know what step is going slow as well. Do the
qualimap logs give some feedback about where the stuck steps might be?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/chapmanb/bcbio-nextgen/pull/1678#issuecomment-265849035,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAcFLPGxlebIg4KZjeHQ4m56xG8Eu5amks5rGGsegaJpZM4LHLix
.

authors: lpantano roryk stephenturner

repo: chapmanb/bcbio-nextgen


text:
update README with rspec info

:+1:

authors: metadave randomcamel

repo: chef/chef-provisioning-aws


text:
Override where dialyzer looks for code

:+1:

authors: joedevivo tylercloke

repo: chef/concrete


text:
Identify regions where Yan et al. (2010) fails to converge

Also curious if this is a local minimum. Hm.

You might want to try using an odd number of annotators, just in case you have tie breaking issues.

No dice.

One additional note is that LBFGS seems to require accurately scaled gradients — the gradients in my implementation might be out by a factor of T as this isn't given explicitly in the paper.

Good observation. Making sure that you are taking the gradient of the average and not the total over the size of the crowd would be very important. This is why I ask you to write down your full derivation in LaTeX, so that we can check such things.

My gradient comes out as a total since the optimisation target is a total (for α and β at any rate). Then again, my newly-derived gradient equations are also different from the paper, so I need to try and find where my mistake is. Wolfram|Alpha agrees with me so the problem must be earlier on somehow...
Pushed most of it in 84d42e8, just missing the last two gradients.

I just read the experimental section of Yan 2010. In the experiments for Part I, they simulated annotators by clustering the data. Each annotator is an expert on one cluster (returns ground truth label), and returns a noisy label for all other clusters. It would be weird if your label noise needs to behave like that for EM to work, but this seems to be worth implementing anyway, because it allows you to reproduce a prior experiment for demonstrating that this model works.
This is to rule out that your method for generating annotators is somehow violating some assumption (I cannot see what this could be).

Sounds good to me. I'll do that soon.

A little bit of algebra-bashing today has lead me to think that this probably should be converging — though I don't think I know enough information theory to prove it. I also consistently get different gradients to the paper, so I'll try implementing my gradients and see how it goes.

I've gone ahead and implemented my gradients and I get identical behaviour (despite the gradients being different?). This is really strange.

(Sorry for the inundation of email notifications!)
Here's a plot of the different values of the optimisation objective for different values of α_1 and α_2 and other parameters 0.

The other variables are pretty similar. Given this, I'm pretty confused as to how the values could diverge. I suspect the gradients are wrong, though I can't see where implementation differs from the paper.
Fixing γ = 1, w = 0 for all annotators (I believe this is equivalent to trusting that they have low noise), only searching for α and β, approximating the gradient, and initialising α and β normally at random consistently gives good results.

Again fixing γ and w and searching only for α and β, but using the analytic gradients, gives mixed results. Usually similar to the above, but sometimes everything is classified as the same class.
The same experiment with my own gradients for α and β also gives similarly mixed results.
The same experiment but unfixing γ (initialising to 1) slightly decreases quality of results; γ seems to go up (implying an increase in confidence — even for labellers who are totally wrong). I can't seem to get it to drop the value of γ below the initial value.
The same experiment but using my own gradient for γ does pretty well! It manages to discount the labels from people who are always wrong, outputting γ:
γ = [ 0.1615422   1.88785567  1.84692105  1.08089441]
Annotator 1 always labels class 0, and annotator 4 is wrong 30% of the time. Annotator 2 is slightly better than annotator 3.
I also note that it's possible for the system to get stuck into a loop where it convinces itself that all the labels should be zero, and then proceeds to discount everyone who isn't annotator 1:
γ = [ 17.1624761    0.08013397   1.04591933  -0.57535758]
All this considered, I decided to plot the gradients of γ for different values of γ with random values for all other parameters and values. I get these curves, with Yan gradients in blue and my gradients in green:

Mine are larger by a factor of 100(!) so I've scaled them back a bit. The interesting thing is that (conditionally — not sure what causes this) the Yan gradients are always positive or always negative, while mine are -sgn(γ) (at least for the random data). Noting that the scale was also off, I divided my gradients by 100 and ran the test again. This gave pretty good results. I'm not sure why the scale was so different.

γ = [ 0.2266155   4.92412781  0.67983324  0.59036428]
I then went all in with my gradients and optimised over all parameters. This quite consistently gives good results (or decides that annotator 1 is always right).

Perhaps you are testing with something that is too hard. Annotator 1 seems to be always predicting one class only (which is hard for a learner who expects balanced class proportions).
I suggest something easy, where all annotators agree on most of the examples (90-95%) and only a few examples have one annotator getting it wrong. If that's fiddly to implement, just have a very very low noise level.

Good idea. Switching annotator 1 to behave like annotator 3 over a different domain gives good results.

This is still with the initial assumption that the annotators are not bad — that seems to be the main factor that has improved the results. I think this is because if you start out with normally distributed (or zero) γ, you start out assuming that half of the annotators should be ignored and this can easily bias your labels when there aren't many annotators.

Each annotator is an expert on one cluster (returns ground truth label), and returns a noisy label for all other clusters. It would be weird if your label noise needs to behave like that for EM to work, but this seems to be worth implementing anyway, because it allows you to reproduce a prior experiment for demonstrating that this model works.

Working on this now.

Simplified the data a bit by increasing separation and making everything linearly separable. Good results usually:

Sometimes the results are bad though:

I also added a small constant to η_t — Yan et al. did this for σ_t but there's no mention of adding a small constant for η_t. This seems to have improved stability a lot. I'm pretty happy with this now though I do I wish it were more reliable.

Each annotator is an expert on one cluster (returns ground truth label), and returns a noisy label for all other clusters. It would be weird if your label noise needs to behave like that for EM to work, but this seems to be worth implementing anyway, because it allows you to reproduce a prior experiment for demonstrating that this model works.

Forgot to follow up on this. Implemented + tested, no obvious differences.

authors: MatthewJA chengsoonong

repo: chengsoonong/crowdastro


text:
大佬我又来了

就是微博推送没有问题
口袋推送还是不行 这个是什么原因啊


text:
Log Kafka responses

test-me-please

repo: cilium/cilium


text:
CFY-2053 Create an db interface

So i think before we are starting to add code, maybe we should setup this porject as a proper python project. i.e adding a setup.py file with the dependencies, and placing files into the appropriate packages.
("byon-service" is not a valid python package name, because of the hyphen)

authors: iliapolo szpotona

repo: cloudify-cosmo/cloudify-byon-service


text:
updating the build, so the server is closed by ourselves, close #825

Deploy preview for landscape ready!
Built with commit c52d8391d110785feea707f3c226b20a868ee991
https://deploy-preview-879--landscape.netlify.com

authors: CNCF-Bot ZeusTheTrueGod

repo: cncf/landscape


text:
fix Docker link

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/92ead6fb1f392b07b27581327a94274b7286d2cc/
Edited pages:

releases/v20.1.3.md

authors: cockroach-teamcity taroface

repo: cockroachdb/docs


text:
Traduction en cours

Hello, @LikeMyGeek! Thank you for contributing. Could you sign our CLA so that I can merge your pull request?

Off course :p
It's ok

Thanks.

repo: codecombat/codecombat


text:
Update lt.coffee

Thank you, @snarkota


text:
Vi translation

Awesome, @duybkict :+1:


text:
#3138 #3488 refactor CampaignView - rebased

Is there any issue with Travis, I got this error The command "./node_modules/karma/bin/karma start --browsers Firefox --single-run --reporters dots" exited with 1.

Reran the tests, worked this time.
Needs to handle this weird loading issue

@duybkict are you available to wrap this PR up?

Closing due to inactivity

authors: duybkict sderickson


text:
Fixes issue where number of dependents was not limited when household number was not specified.

Currently limits dependents to 0 when household size is not specified.

Fixes #65

repo: codeforboston/cliff-effects


text:
114 action buttons more prominent

fixes #114

thing that needs to be fixed:

add exit button disabled style
exit button turning white in some places??

Plan for changing colors of buttons:

Exit button in black - white/gray on hover
Restart button in black - white/gray on hover (same as above)
Back button in red - darker red on hover
Answer buttons in white - gray on hover

authors: Sweta-Alla berit niharikasingh


text:
Articles backend

Не сохраняются данные при переходе к полной версии редактора.
Ошибка при публикации статьи

authors: khaydarov neSpecc


text:
Publish core to public repository

Now publishing to github releases - good enough

repo: codingchili/chili-core


text:
Fix log out feature

@chrisjwelly this is done now and in the master branch.

@sreycodes Noted. Thanks!

authors: chrisjwelly sreycodes

repo: commit-tech/nussu-logistics


text:
rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

authors: conda-forge-linter ocefpaf

repo: conda-forge/uwsgi-feedstock


text:
Fix duplicate license_family entry

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

authors: conda-forge-linter jschueller

repo: conda-forge/warctools-feedstock


text:
add cryptoveno

你好，提交的信息有误，请检查，谢谢。

authors: CRYPTOVENO wenyanwang

repo: consenlabs/token-profile


text:
docs: ultra high performance

Pull Request Test Coverage Report for Build 128

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 126:
0.0%

Covered Lines:
194

Relevant Lines:
194

💛  - Coveralls

repo: contentacms/contentajs


text:
com.contentful.java.cma.model.CMASpace.getDefaultLocale() is always null

This is true.
We did not want to introduce a backwards incompatible change. The API does not return the default locale on a CMA space anymore. If you want find out which locale is the default one, please take a look at the documentation on how to fetch locles and filter the responses by its isDefault property.
I hope I understood your question the right way, and hope I could additionally answer it.
Greetings,
Mario

Thanks for explaining - perhaps the method could be annotated with @Deprecated, along with a comment pointing to the separate locales api?
Also, I would suggest throwing an UnsupportedOperationException, rather than just returning null, would be preferable.

Hey,
thanks for your feedback we will be iterating on it.
For now I will be closing this issue. Please feel free to reach out to us anytime.
Greetings,
Mario

authors: adrian-baker mariobodemann


text:
Update README.md

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks!

authors: CLAassistant NEFARI0US Shchvova

repo: coronalabs/corona


text:
Use Null Coalesce Operator

Thank you!

authors: TomasVotruba carusogabriel

repo: cpliakas/git-wrapper


text:
small doc fixes

Codecov Report

Merging #417 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   38.41%   38.41%
=======================================
  Files          20       20
  Lines        1658     1658
=======================================
  Hits          637      637
  Misses       1021     1021

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f7679...7939d07. Read the comment docs.

authors: codecov-io nslater

repo: crate/crate-admin


text:
fsync interval and filter.max_size settings added

otherwise ack if travis failures are unrelated

authors: pustovit seut

repo: crate/crate


text:
add support for generated columns (Feature T175)

ack

authors: dobe seut


text:
Exposed mapping.total_fields.limit as table setting

Codecov Report

Merging #5976 into 2.0 will increase coverage by 0.14%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##                2.0    #5976      +/-   ##
============================================
+ Coverage     82.94%   83.08%   +0.14%
- Complexity    11774    11806      +32
============================================
  Files          1391     1391
  Lines         45445    45484      +39
  Branches       5626     5626
============================================
+ Hits          37693    37792      +99
+ Misses         5134     5089      -45
+ Partials       2618     2603      -15

Impacted Files
Coverage Δ
Complexity Δ

...ence/partitioned/PartitionsSettingsExpression.java
100% <100%> (ø)
2 <0> (ø)
:arrow_down:

...io/crate/metadata/settings/CrateTableSettings.java
96.29% <100%> (+0.14%)
1 <0> (ø)
:arrow_down:

...eference/information/TablesSettingsExpression.java
100% <100%> (ø)
2 <0> (ø)
:arrow_down:

...main/java/io/crate/analyze/TableParameterInfo.java
100% <100%> (ø)
6 <0> (ø)
:arrow_down:

...ta/information/InformationPartitionsTableInfo.java
97.7% <100%> (+0.17%)
3 <0> (ø)
:arrow_down:

...o/crate/analyze/PartitionedTableParameterInfo.java
100% <100%> (ø)
4 <0> (ø)
:arrow_down:

...java/io/crate/analyze/TablePropertiesAnalyzer.java
92.26% <100%> (+0.08%)
21 <0> (ø)
:arrow_down:

...ate/metadata/information/InformationTableInfo.java
98.86% <100%> (+0.08%)
4 <0> (ø)
:arrow_down:

...tadata/information/InformationTablesTableInfo.java
99.02% <100%> (+0.06%)
3 <0> (ø)
:arrow_down:

...er/src/main/java/io/crate/sql/tree/AstVisitor.java
31.2% <0%> (-1.6%)
39% <0%> (-2%)

... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af3e245...f027428. Read the comment docs.

authors: codecov-io turbo-ele


text:
好用，，希望能加多选功能

图片多选建议去搜一下ImagePicker有很多的轮子可以用

repo: crazycodeboy/TakePhoto


text:
Fix typo

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

thank you @laruiss, at least it wasn't "venison"

authors: CLAassistant bahmutov laruiss

repo: cypress-io/cypress-docker-images


text:
Replace the enclosing circle algorithm with the MSW algorithm

Lovely! This was a pleasure.

authors: mbostock robinhouston

license: isc


text:
Hacking updates

Codecov Report

Merging #345 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   99.65%   99.65%
=======================================
  Files          13       13
  Lines        2049     2049
=======================================
  Hits         2042     2042
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 691d39f...2646686. Read the comment docs.

authors: bersace codecov-commenter

license: PostgreSQL


text:
[Enhance] Create Multiple SPP

Coverage increased (+0.02%) to 77.426% when pulling 32e4116131fcc7f37d5d7215a7b2536842a33e51 on jackyruslymoonlay:dev into acca956694cae025dc941df9e7944a49f859e518 on danliris:dev.

authors: coveralls jackyruslymoonlay

repo: danliris/dl-module


text:
(WIP) Red Hat 7

@mesosphere-mergebot bump-ee

repo: dcos/dcos


text:
#81 Changes to identity map to allow for removal of identity

This is all bit poor on the implementation front - more so for the in-memory persistence. I think It makes sense to leave this issue open to address just how poor the implementation is.
The likelihood of it actually working under load is zero.

repo: dddlib/dddlib


text:
Load vendor files

Created a PR to add to_csdm functionality to nmrglue

repo: deepanshs/mrsimulator


text:
Add GoofspielObserver.

Is there a good reason for the change to ObservationString? Can you make it backwards-compatible?

Now it's almost completely compatible, except for Win sequence / Win Sequence

authors: elkhrt michalsustr


text:
Submitting niching slides

Hi! Thanks for submitting your slides here. It looks like you might have forgotten to commit the slides themselves though -- I'm just seeing the change in the readme.

authors: deniederhut timcrose


text:
Add screen flash helper

Not needed.


text:
SSO > Test all login services

Add beta label on LDAP and OpenShift.

Added beta label. UI: https://zpl.io/bAeZlze

repo: devtron-labs/devtron


text:
rewrite tea ceremony for 3 iterations in transcript

rewritten; excess stories moved to Naomi's Rune Book at the end.

repo: dhakajack/trfv


text:
Adding django 1.8 support

+1

+1

+1

+1

+1

Yup, if no one beats me to it i'll look at it this weekend

while changes between 1.6 and 1.7 were not trivial, changes between 1.7 and 1.8 should not be that difficult to support togather.

Well one of the issues is that not all our dependencies support 1.8 yet. And we also need to decide if we integrate this in Oscar 1.1.0 (which will include Bootstrap 3) or release it as a 1.0.4 (thus make it an easier upgrade path). I'll leave this decision to @maikhoepfel and @codeinthehole

Hi all, I'm happy to announce I just merged #1711. Django 1.8 is now supported on the master branch. A client of mine is using Oscar and wants to move to Django 1.8 pretty soon, so I'm hopeful I'll get time to package Oscar 1.1 soon.

We do have some work left to do: https://github.com/django-oscar/django-oscar/issues/1728

authors: auvipy bartlomiejborzucki blager karol-gruszczyk krzysztofp maikhoepfel mvantellingen tpro

repo: django-oscar/django-oscar


text:
[WIP] URL dispatcher API.

Closing due to inactivity.

authors: knbk timgraham

repo: django/django


text:
create moviestartswith.js

Need to force scan


text:
fix appveyor typo

Coverage remained the same at 84.906% when pulling ed53d929ef6754d19b94380963598b4cb17857c2 on tkelman:patch-1 into f63b21fc0cc79e7aee002c6d2f7d5d025d7d67e5 on dmbates:master.

Coverage remained the same at 84.906% when pulling ed53d929ef6754d19b94380963598b4cb17857c2 on tkelman:patch-1 into f63b21fc0cc79e7aee002c6d2f7d5d025d7d67e5 on dmbates:master.

Coverage remained the same at 84.906% when pulling ed53d929ef6754d19b94380963598b4cb17857c2 on tkelman:patch-1 into f63b21fc0cc79e7aee002c6d2f7d5d025d7d67e5 on dmbates:master.

Coverage remained the same at 84.906% when pulling ed53d929ef6754d19b94380963598b4cb17857c2 on tkelman:patch-1 into f63b21fc0cc79e7aee002c6d2f7d5d025d7d67e5 on dmbates:master.

authors: coveralls tkelman


text:
[PASS] Support buffer reuse for different types

@tqchen please review

has updated as your comments, @tqchen please review again

@tqchen any other comments?

repo: dmlc/tvm


text:
Quirks for Smartthings MotionV4

It actually looks like this matches the signatures for the CentraLite 3325-S and 3326-L. Being a different manufacturer im not sure if this will conflict like #19

repo: dmulcahey/zha-device-handlers


text:
fix a typo (--create -> create)

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "fix-typo" git@github.com:znz/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "fix-typo" git@github.com:znz/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

LGTM

authors: GordonTheTurtle dgageot znz

repo: docker/machine


text:
Add setters to generated struct streams

Codecov Report

Merging #62 into master will decrease coverage by 0.03%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   86.75%   86.72%   -0.04%
==========================================
  Files          30       30
  Lines         906      919      +13
==========================================
+ Hits          786      797      +11
- Misses        120      122       +2

Impacted Files
Coverage Δ

types/stream.js
97.14% <100%> (+0.59%)
:arrow_up:

types/struct.js
90.1% <80%> (-1.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d456d...83da344. Read the comment docs.

authors: codecov-io rameshvk

repo: dotchain/dotjs


text:
Allow users to re-register when changing session

Fixes #89

repo: dotkom/super-duper-fiesta


text:
JBPM-4847 - Fix overwritten change to use PopoverTextCell

+1

master: b25029b989778973e1dd94542ee62a00dad5f78b

authors: cristianonicolai csadilek

repo: droolsjbpm/jbpm-console-ng


text:
adding parse int64

This is a reasonable approach for some use cases, but not something we want to merge into master for the reasons here: https://github.com/dropbox/json11/blob/master/json11.hpp#L16-L27


text:
Removed an extra whitespace character

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant joeykrim

repo: duo-labs/cloudmapper


text:
支持 app.start() 时不传入元素情况下的 HMR

这个能否实现以下？

恩，计划是本周内实现。

感觉应该有更好的方案，时间有限，先给出私有变量的方案但不作为官方推荐，后面做 render 和 start 分离时再思考更好的方案。
import ReactDOM from 'react-dom';
import dva from 'dva';
import './index.css';

// 创建实例
const app = dva();

// 注册路由
app.router(require('./router'));

// 由于 render 自行控制，所以必须定义 render 方法并传给 onHmr 插件
function render(router) {
  const App = router ? app._getProvider(router) : app.start();
  ReactDOM.render(<App />, document.getElementById('root'));
}

// 绑定 onHmr 插件到 app
app._plugin.apply('onHmr')(render);

// 正常 render
render();

repo: dvajs/dva


text:
Help me how to use it with ''taken_at'' format.

An example is provided in https://github.com/dvingerh/PyInstaStories#examples
There is no customization available

repo: dvingerh/PyInstaStories


text:
PenaltyModel should check the energy ranges when a model is added.

Addressed by #28

repo: dwavesystems/penaltymodel


text:
process.env.NODE_PATH will be considered first for global node_modules

Please consider this because it is not working in my windows under nvm.

I have modified a bit. Please check.

what do you think about the new update? @LinusU

Just one small thing 👍

@LinusU done.

Hello.I am wondering whe the pr will be merged and when the next version will be released.

So sorry for the wait!
@dylang any objections? I'll give you a few days to comment, otherwise I'll merge and publish :)

shall we also add a doc for this in Readme?

Yeah, that would be great 👍

@LinusU README updated.

Wondering when the new package will be released.

Sorry for the delay 😳

repo: dylang/npm-check


text:
use  for element in report of nest-rule

Coverage remained the same at 98.514% when pulling e7e3dbabfd3abe885a84724eddea67ca010dce77 on nighca:update-report-style into ab883c96379241f7e101c61e1d6aef43b02ebc92 on ecomfe:master.

authors: coveralls nighca

repo: ecomfe/htmlcs


text:
Added test account to user list

test example

repo: eddiejaoude/hacktoberfest-practice


text:
Typos

Thx!

authors: edsu hugovk

repo: edsu/twarc


text:
#871: add missing header

Not properly rebased

authors: ljacomet lorban


text:
Latest

Close since already fixed


text:
Create gnidan.org.md

Good job finding this so early. Just a disclaimer: this is still an experiment. We may not end up using it, or may end up modifying the process substantially, requiring you to submit again.

Shucks, way to get my hopes up! 😄

authors: Arachnid gnidan

repo: ensdomains/name-reservations


text:
Ability to stipulate different ports for the WordPress serving instance

nice. Thanks Dominique !

salut @domq,
Les variables dans le Makefile ne sont pas surchargées par les variables d'environnement ni pas la ligne de commande, à moins d'utiliser la syntaxe suivante :
WP_PORT_HTTP ?= 80
WP_PORT_HTTPS ?= 443

au lieu de
WP_PORT_HTTP := 80
WP_PORT_HTTPS := 443

#chezmoiçamarche @ebreton ☺
“If a variable has been set with a command argument (see Overriding Variables), then ordinary assignments in the makefile are ignored.”

(J'envoie tout soudain une pull request pour que make vars montre aussi les nouvelles variables)

authors: domq ebreton


text:
Add Stack build.

Sorry, this was a misclick.

repo: epost/datalog


text:
Added PVT supporting PVDO and PVTG.

Wrong repository 😉

authors: asnyv rubenthoms

repo: equinor/webviz-config


text:
Ruby Added

Thanks 👍🏼

authors: aniliyidogan ergenekonyigit


text:
Added main datagrid columns visibility customization

пример реализации настроек колонок. можно также навешать менюшку на кнопку гдето в тулбаре по которой будет откриваться меню с колонками

Нормально выглядит, мне нравится.

authors: heinrichI tshcherban


text:
DGC test data from Belgium

@ortwin45 Can you please check your date values. The are not correctly formatted. "validationClockInstant" is as well not properly formatted.

Datetime formatting has been fixed. Can you verify again?
Thanks!


text:
Providing Chinese readme.

https://github.com/eva-engine/eva.js/commit/cf9afb19ffb6a73930b17b0b89f1688733f815ff


text:
Support for Xcode 10 and Swift 4.2

It looks like your xcode10 branch branches off an older version of master. When I install your branch, CocoaPods says its using version 10.0 when 11.0 is the current one.

authors: CraigSiemens beny

repo: evgenyneu/keychain-swift


text:
dibs on luhn exercice

Great thanks!

authors: Pierre-Vdsp petemcfarlane

repo: exercism/xphp


text:
Code refactoring , remove redundant code

fixes in https://github.com/fabric8-analytics/vscode-osio-auth/pull/2


text:
does it complete ? can you upload a demo?

I'm not sure what you're asking.

repo: facebook/create-react-app


text:
Fix notebook json issues

buddy, why our pr cannot pass azure devops check? i have met the same pr failure...

authors: Light-- oneraghavan


text:
[RAINCATCH-135] Add slack notifications and sonarqube test

👍

authors: nialldonnellyfh paolobueno


text: Add action for inspecting the compiled method object

repo: feenkcom/gtoolkit


text:
Wrap generated impl function name in a define

:+1: cool

authors: felixangell raoulvdberge

repo: felixangell/alloy


text:
add cross compile

Cheers, one last request: can you remove the syntax from the config files since those were removed on the master

Oh sorry just checked. Think this github app im using is a bit out of date with the pr for some reason
LGTM going to merge, thanks for the contribution 🤗

authors: Chyroc felixangell

repo: felixangell/phi-editor


text:
Make recursion depth 1 as default

Can you give a bit more context about this request? Rationale etc. I don't think recursion should be enabled by default personally, but I'm up for discussion.

I mean when we enable recursion flag
it hits all endpoints
for e.g
if manager redirect manager/
it adds a job for fuzzing manager/ endpoint
and while fuzzing manager/admin redirects to manager/admin/
new job is added to fuzz manager/admin/ endpoint and the loop continues
by default it should only fuzz upto manager/ and not manager/admin
it that make sense to you or we would have to fuzz a site together. that will be more fun

i hope it will not add this, we go away from dirb/dirbuster for this kinds of bad feature. Add it optional yeah but not by default please. and if you want enable it by default make an alias ffuf = "ffuf --recursive 1" for example in your bashrc file

Closing the issue in order to keep the issues backlog readable, and I do consider the issue either resolved or there's no communication. If you have something to add to the issue, please comment and we'll consider reopening it.

repo: ffuf/ffuf


text:
Fix wrong function call, caught by assert on Windows.

Wow, the OSX GL implementation totally doesn't catch that in glGetError(). On the other hand... not really surprising ;) Thanks!

authors: code-disaster floooh

repo: floooh/sokol

license: Zlib


text:
added attribute to set bubble arrow position by percent in BubbleView

thx I publish it


text:
Updated examples to es6

Coverage remained the same at 96.316% when pulling 94d7a8167d2590c1f96b2553ab75115288a7b6b1 on amilajack:patch-1 into 158443da3b2ce221f0a06ccb3b8ab8c56b68b034 on form-data:master.

I do not mind the examples being in es6 in fact i ❤  it! I often convert much code to es6/7

Ok, I'll close this PR and please create new one with new file with ES6 examples (and we'll link to it from the readme).
Thank you.

authors: alexindigo amilajack coveralls jimmywarting review-ninja

repo: form-data/form-data


text:
Fixed Dirs change error in GenericScraper

Can this be merged please?

Good job!

Thanks!
Btw, should we create a separate Repo for André's Generic Scraper? (Last developed)

@PolBaladas Not sure, cause it is a very small thing. Maybe first add some info about the generic scraper into the Readme.md. Also would be great to get some sample outcome in the repo.

authors: PolBaladas mariobehling

repo: fossasia/parliament-scaper


text: Add png file to README.

repo: frudens/fmoauth


text:
Kernel Logistic Regression L2 Regularization 實作

Done~

repo: fukuball/fuku-ml


text:
Pushing new mobile prefixes in philippines

Thanks

repo: fzaninotto/Faker


text:
Add processing of query failed status error metric (#32)

Reviewed successfully.

authors: gabrieleiannetti lramosrocha

repo: gabrieleiannetti/infiniband-exporter


text:
Gh 1892 add getdataframeofelements support back in to parquetstore

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@fc9a587). Click here to learn what that means.
The diff coverage is 83.72%.

@@            Coverage Diff             @@
##             develop    #2059   +/-   ##
==========================================
  Coverage           ?   66.07%
  Complexity         ?     2233
==========================================
  Files              ?      894
  Lines              ?    29254
  Branches           ?     3645
==========================================
  Hits               ?    19329
  Misses             ?     8433
  Partials           ?     1492

Impacted Files
Coverage Δ
Complexity Δ

...uetstore/operation/handler/AddElementsHandler.java
89.39% <100%> (ø)
0 <0> (?)

...ration/handler/utilities/CalculatePartitioner.java
93.54% <100%> (ø)
0 <0> (?)

...re/operation/handler/spark/AddElementsFromRDD.java
84.02% <75%> (ø)
0 <0> (?)

.../uk/gov/gchq/gaffer/parquetstore/ParquetStore.java
85.71% <77.77%> (ø)
0 <0> (?)

...n/handler/spark/GetDataFrameOfElementsHandler.java
86.66% <86.66%> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc9a587...587075d. Read the comment docs.

repo: gchq/Gaffer


text:
Corrected DataReader responsibility

Don't worry about Jenkins failing - this PR didn't change any source code.

repo: gchq/Palisade-readers


text:
Issue 18814

Need the taxon constraints to be regenerated for this to pass.

repo: geneontology/go-ontology


text:
gatk_haplotypecaller.cwl to new definitions/tools, with docker requirement

@johnegarza Good catch! I fixed the spelling mistake

repo: genome/analysis-workflows


text:
add additional help text to Variant Type fields, as well as more extensive Help docs

The more extensive docs have been added in a whole new tab by Amber this summer. Current help text in the edit Variant form is: " Add one or more variant types from the Sequence Ontology ". Not sure what else to add there.

Added a link to SO and some examples.

Included in https://github.com/genome/civic-client/pull/618

authors: jmcmichael kkrysiak malachig

repo: genome/civic-client


text:
add 'in the range' to sources adv. search

Specifically for publication year.

authors: jmcmichael malachig


text:
Add !suggest command to auto-generate an issue

Added in 726aedf858398b09517f7f8fa122660c2fd40897

repo: gideontong/Amy


text:
Adds git merge commands

Coverage remained the same at 100.0% when pulling 811ab1db42e3fc45c93e4690c98cd6a5966bb8df on command/git-merge into 4e8fa8af711ac1741cac3bf0350d3dfa032f8fc1 on master.

authors: coveralls juliendufresne

repo: git-pull-request/php-git


text:
Android test example h64 h80

Hi Marc, please review and provide feedback are always welcome!!! <Thank you very much in advance~>


text:
small typo in examples.

@chasenyc thanks!

authors: chasenyc markbates

repo: gobuffalo/gobuffalo


text:
sitemap templates: remove unneeded space

Merged, but for the future, it would be good if you could start your commit messge title with a capital letter ("Remove ...")

authors: XhmikosR bep

repo: gohugoio/hugo


text:
Update .gitignore to ignore IntelliJ files.

closing this since it's part of the bazel PR anyway.

repo: google/MOE


text:
Specify libpng dependency and build instructions

I signed it!

Thanks. :)

👍

authors: robryk sbussard

repo: google/butteraugli


text:
guetzli benchmark 970, with seeds and dictionary

Does it actually need 3 seeds to find the bug?

authors: dnoursi eugenis

repo: google/fuzzer-test-suite


text:
Add support for child keys and activate credential flow

Any plans on getting this rebased and merged? This would be very useful for me.  I have forked go-tpm-tools to at least include the activation patch https://github.com/arianvp/go-tpm-tools

Any plans on getting this rebased and merged? This would be very useful for me. I have forked go-tpm-tools to at least include the activation patch https://github.com/arianvp/go-tpm-tools

Sorry this feel off my radar. I will try and pick this up sometime in the next few weeks. Do you only need ActivateCredential or would you also like child key support?

At this point I only need activation; but I guess having hcild keys is also useful

authors: alexmwu arianvp

repo: google/go-tpm-tools


text:
Disable autoload for py3 plugins

Thanks for fixing!

authors: cmyr raphlinus

repo: google/xi-editor


text:
Bump version to 0.1.2 for release

Codecov Report

Merging #210 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #210   +/-   ##
=========================================
  Coverage     69.93%   69.93%
  Complexity      475      475
=========================================
  Files            66       66
  Lines          2478     2478
  Branches        262      262
=========================================
  Hits           1733     1733
  Misses          648      648
  Partials         97       97

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a3fb11...5c56fa8. Read the comment docs.

authors: codecov-io shinfan

repo: googleapis/gax-java