text:
unable to open browser

Type: Bug
when i click on .html i wanted to see on browser i am not seeing it
VS Code version: Code 1.78.2 (b3e4e68a0bc097f0ae7907b217c1119af9e03435, 2023-05-10T14:39:26.248Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: Yes

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-10210U CPU @ 1.60GHz (8 x 2112)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
7.84GB (1.54GB free)

Process Argv
--crash-reporter-id 5edbba2e-66b5-4b28-b459-1d1ff4d539cc

Screen Reader
no

VM
0%

Extensions (2)

Extension
Author (truncated)
Version

chrome-extension-developer-tools
aar
2.0.4

open-in-browser
tec
2.0.0

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
282f8724:30602487
pyind779:30671433
f6dab269:30613381
pythonsymbol12:30671437
a9j8j154:30646983
showlangstatbar:30737416
vsctsb:30748421
pythonms35:30701012
03d35959:30757346
pythonfmttext:30731395
pythoncmv:30756943
fixhidewlkth:30730051
pythongtdpathcf:30739705
pythonnosm12tcf:30757130

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


text:
Using the keybind ( ctrl + k, ctrl + o ) to open a folder will cause the new window to not be focused [Linux]

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.78.2 1.79.0
OS Version: Linux Mint 21.1 Cinnamon 5.6.8 (5.15.0-72-generic kernel)

Steps to Reproduce:

Use the chord ctrl + k ctrl + o to open a folder
Prompt an Open Folder dialogue, or open a second Window of VSCode
The Open Folder dialogue will open, but will be behind the VSCode window and unfocused

This does not happen when selecting open folder from the File menu.

Updated to 1.79.0. Did not fix the issue. I have noticed that it will work in a freshly opened window, but if you have already opened a "Open Folder" dialogue, or if you have multiple windows of VSCode open it will not work as expected.

Merging to https://github.com/microsoft/vscode/issues/146422

source: gharchive/issue

repo: microsoft/vscode

license: MIT

license_type: permissive

license_source: github-api


text:
Missing Calculate Grade button

My "Calculate Grade" button is missing. The companion says it should be beside "Run Code" but it's missing. I have tried both Microsoft Edge and Google Chrome browsers.

Version: 1.85.2
Commit: 8b3775030ed1a69b13e4f4c628c612102e30a681
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36
Embedder: codespaces

/question please raise the issue with the course support channel.

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!

authors: VSCodeTriageBot gjsjohnmurray rdn274


text:
Themes: default theme and default colors are no longer in sync

The colors we define in code should match our default theme, otherwise there is potential for ugly flickering as seen below:

At one point I think we made "Modern Dark" our default, we I think we did not make a pass over our colors to align them with the colors defined in the theme.
We need to ensure that the colors in code match the colors in our default themes, I would argue even for light and HC theme.

I think this should be fixed in May, it looks really bad for first startups.

Is there a reason to do it this way? I think I would have assumed the default dark theme JSON file to be empty (because it does not overwrite any colors) and our colors in code to be matching the default dark theme colors?


text:
Project suggestion

/needsMoreInfo

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

authors: 012nisha VSCodeTriageBot justschen


text:
WebSocket close with status code 1006

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.94.2
OS Version: Windows_NT x64 10.0.22631

At the beggining of this week, i was working perfectly with vscode, but with no cause, the VSCode stopped to coonect with my WSL server. Others tools like VSCodium works, just VSCode dont connect and throw the error WebSocket close with status code 1006. Anyone is passing through this?
Steps to reproduce:

open wsl
type code .

Logs:
INFO Invoking resolveAuthority(wsl)...
INFO [LocalProcess0][resolveAuthority(wsl,1)][0ms] obtaining proxy...   workbench.desktop.main.js:624
INFO [LocalProcess0][resolveAuthority(wsl,1)][0ms] invoking...   workbench.desktop.main.js:624
INFO [LocalProcess0][resolveAuthority(wsl,1)][1003ms] waiting...   workbench.desktop.main.js:624
INFO [LocalProcess0][resolveAuthority(wsl,1)][2038ms] waiting...  workbench.desktop.main.js:624
INFO [LocalProcess0][resolveAuthority(wsl,1)][2299ms] returned WebSocket(127.0.0.1:54159)   workbench.desktop.main.js:624
INFO resolveAuthority(wsl) returned 'WebSocket(127.0.0.1:54159)' after 2300 workbench.desktop.main.js:624
INFO Creating a socket (renderer-Management-0ba9a81c-52aa-4933-a1b0-ea4865902390)... workbench.desktop.main.js:624
INFO Creating a socket (renderer-ExtensionHost-25c9d341-d7fd-4a71-9df8-f5129556ac9f)... workbench.desktop.main.js:656
WebSocket connection to 'ws://127.0.0.1:54159/stable-695af097c7bd098fbf017ce3ac85e09bbc5dda06?reconnectionToken=0ba9a81c-52aa-4933-a1b0-ea4865902390&reconnection=false&skipWebSocketFrames=false' failed: b @ workbench.desktop.main.js:656
INFO Creating a socket (renderer-Management-0ba9a81c-52aa-4933-a1b0-ea4865902390) returned an error after 420 ms.
workbench.desktop.main.js:624
ERR CodeExpectedError: WebSocket close with status code 1006  at WebSocket.<anonymous> (workbench.desktop.main.js:656:3111)

Can you add the WSL log as well? Command WSL: Show Log...

Closing due to lack of additional information

authors: GustavoRochaSantos aeschli


text:
Make the vs code fluent

hi developers i just wanted to request you guys to add fluent design for the vs code exactly like in this video because it's awesome in this video that i wish if vs code is like this for real
https://youtu.be/HrlNTIbo9o4?si=q6lWKgahUhRq9iwm

VS Code team doesnt want to enable smooth scrolling by default. And you talk about new design 😆

Duplicate of #133372 and many other that were marked as duplicate of #115641

damn i didn't see that there is a duplicated requests like mine XD
i am just sad because they made the extension fluent vscode disabled and now we can't enable it so i am asking them to make it fluent by defualt

authors: IllusionMH Marco5dev psnet


text:
Incorrect link syntax in file vscode.d.ts

VSCode Version: 1.41.1
OS Version: irrelevant

Steps to Reproduce:

file: vscode.d.ts
JSDoc type Declaration: line 2316
[location links][#LocationLink] -> (#LocationLink)

Does this issue occur when all extensions are disabled?: Yes

Please remove it immediately and make it your top priority. To me this is almost equally offensive as a swastika.

He think it's funny to imitate this.

authors: brlebtag mrconter1 rwnkl


text:
把速览定义放在右键的二级目录下真是个变态的设计

Issue Type: Bug
把速览定义放在右键的二级目录下真是个变态的设计
VS Code version: Code 1.40.1 (8795a9889db74563ddd43eb0a897a2384129a619, 2019-11-13T16:49:30.162Z)
OS version: Linux x64 4.15.0-72-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (8 x 4096)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: unavailable_offviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
0, 0, 0

Memory (System)
15.59GB (3.22GB free)

Process Argv
--no-sandbox --unity-launch

Screen Reader
no

VM
0%

Extensions (19)

Extension
Author (truncated)
Version

msg
ajs
0.1.1

code-gnu-global
aus
0.2.2

bracket-pair-colorizer
Coe
1.0.61

prototxt
dmi
0.0.6

githistory
don
0.4.12

translation
dus
0.0.4

gitlens
eam
10.2.0

comment-translate
int
1.4.2

advpl-vscode
Kil
0.13.0

vscode-clang
mit
0.2.3

vscode-language-pack-zh-hans
MS-
1.41.2

vscode-ros
ms-
0.6.2

python
ms-
2019.11.50794

cmake-tools
ms-
1.2.3

cpptools
ms-
0.26.3-insiders2

cmake
twx
0.0.17

vscode-zh-hans-custom
wan
1.1.0

clang-format
xav
1.9.0

vscode-proto3
zxh
0.4.0

Translation
I hate the design that putting Peek Definition under a cascading context menu.

@lgl608 might be experiencing the situation same as #87628 and #86316, or even worse.
According to #85218, the Peek submenu is by design. However, IMO, the Peek commands are frequently used, and it's much more convenient to access them by context menu than by keyboard.
@jrieken , please reconsider it. What about putting Peek commands into the main menu and folding Goto commands? Thanks.


text:
VScode update kills my custom theme

This was already reported in https://github.com/Microsoft/vscode/issues/66499, but the issue was closed. It has happened to me twice now, so I'm sure this is due to the update itself and not some manipulation error.

VSCode Version: Version: 1.42.1 (user setup)
Commit: c47d83b293181d9be64f27ff093689e8e7aed054
Date: 2020-02-11T14:45:59.656Z
OS: Windows_NT x64 10.0.18363
OS Version: Windows 10 Enterprise 1909

Steps to Reproduce:

in the extensions folder, copy-paste one of the themes delivered with VScode
edit new theme to give it a new name, then edit some settings. Note: I gave it a name close to the old one (specifically, monokay_fvila), might that have something to do with it?
select new theme in VScode, enjoy
wait for the next update to delete your work

All the folders in my extension folder are dated 2020-02-14. My theme was last modified on  2020-02-13.

I don't think direct manipulation of theme files that way is supported, in which case you must take your own precautions to have your changes survive an update.
See https://code.visualstudio.com/docs/getstarted/themes#_customizing-a-color-theme for a supported way of customising a theme (or all themes). The same page also tells you how to create a complete theme of your own.

All of the VSCode source code will be rewritten on update. @gjsjohnmurray linked to the supported way for customizing themes.

authors: FrancisVila JacksonKearl gjsjohnmurray


text:
Welcome -> Interface Overview Screen - Title Text for the first two features (Search & File explorer) Needs to change/swap

Interface Overview Screen - Title Text for the first two features (Search & File explorer) Needs to change/swap

VSCode Version: Visual Studio Code - Version: 1.41.1
OS Version: Mac OS

Steps to Reproduce:

Initial Welcome screen (Help Menu -> Welcome)
Click on Interface Overview from Right Side Learn Section

Does this issue occur when all extensions are disabled?: Yes/No: Its common issue comes every time

The (interface overview) overlay seems to be static, while the buttons on the left can be changed around.
The overlay should follow the icon arrangement, and not be static.


text:
Add a cache busting parameter to vscode.workspace.getConfiguration()

When I gather the workspace configuration from the API vscode.workspace.getConfiguration() I would like it to get those values from whatever is in the workspace file. See the code below for an example.
However, this code seems to be retrieving the values form a cache.
Scenario:

the user change the order in which the entries of the workspace settings appear in the file
the user then runs a command in my extension that changes one of those workspace settings
my extension then reads the existing values and updates one of those values

The result is that the sequence in which te settings appear is reverted to an earlier state, prior to when the user changed the sequence.
Th expectation is that it leaves them in the same sequence.
Why is this important? Because users sometimes re-order workspace settings and want the order to stay the same.
Proposal:
If this API caches values (which appears to be happening), can an optional argument be passed to bust the cache and make it read from disk again?

Add a cache busting parameter to vscode.workspace.getConfiguration() or the inspect method.

export function getColorCustomizationConfigFromWorkspace() {
  const inspect = vscode.workspace.getConfiguration().inspect(Sections.peacockColorCustomizationSection);

  if (!inspect || typeof inspect.workspaceValue !== 'object') {
    return {};
  }

  const colorCustomizations: ISettingsIndexer = inspect.workspaceValue as ISettingsIndexer;
  return colorCustomizations;
}

I found a workaround ... I need to cache bust in this scenario. So I run this code:
async function bustTheCache() {
  /**
   * Workaround: The following code forces VS Code to read the
   * workspace configuration fresh from the disk.
   * We change a value in the workspace (peacock.cacheBust),
   * which forces VS Code to read it again next time.
   *
   * If VS Code either stops caching or implements a way to
   * bust the cache so we can read the workspace configuration
   * fresh from the disk, then we can remove this code
   */
  const config = vscode.workspace.getConfiguration();
  const section = `${extensionShortName}.${StandardSettings.CacheBust}`;
  const cachebuster = Math.floor(Math.random() * Math.floor(1000000)).toString();
  await config.update(section, cachebuster, ConfigurationTarget.Workspace);
}

This is a hack ... I am adding a property to the workspace and changing tis value. I dont care about the value and do not use it
Problems with this:

It feels dirty
I had to add a property to my extension's API for cacheBust
users will see the property in Settings UI (tho I gave it a description telling them to ignore it)

I much prefer a way to bust the cache in the existing API.

@johnpapa

Scenario:
the user change the order in which the entries of the workspace settings appear in the file
the user then runs a command in my extension that changes one of those workspace settings
my extension then reads the existing values and updates one of those values
The result is that the sequence in which te settings appear is reverted to an earlier state, prior to when the user changed the sequence.
Th expectation is that it leaves them in the same sequence.

Can you please provide a concrete example to understand what you mean?

Sure. Here is the code I added, then removed, to make cache busting work: https://github.com/johnpapa/vscode-peacock/commit/97e36ec17736366d674aa29b1f96ed0e90f47f39
With Peacock, people may change the order of the color customizations in the workspace file. The steps are

you open the file and move the settings (change their order)
then you change a color in Peacock.
Peacock reads the existing file (using the inspect API)
Peacock takes that list and sets the colors to the new colors
Peacock then tries to write the settings back to the file

The problem is that when peacock reads the file, it is not getting the new order that the user made. If you try this in peacock, you can see it happening.

you open the file and move the settings (change their order)

Can you please let me know which settings you mean? It would be great if we can break it down to a simple example that can be reproducible.

The workbench color customizations settings on the workspace settings

So if I understand correctly - the request is to trigger a change event even if the settings order is changed? But I think this should be scoped to values of the settings but not the order of top level settings./


text:
vscode.workspace.workspaceFolders is always undefined

VSCode Version:1.43.0
OS Version:Fedora 31

Steps to Reproduce:
1.Use the Yeoman Code Extension Generator
2. make a new project
3. Open the folder with  code <folder name>
4. Try and Print the console.log(vscode.workspace.workspaceFolders), and then hit F5 to compile and run
Congratulations, your extension "edge-developer-tools" is now active!
workspaceFolder:  undefined

The Resulting output is always undefined.
To check that the workspace var was being correctly set I make a task as follows
{
			"label": "echo",
			"type": "shell",
			"command":
			  "echo workspaceFolder: ${workspaceFolder} \n workspaceRoot: ${workspaceRoot}"
}

After running the task It returns the expected output
workspaceFolder: /home/astoycos/vs-code-plugin/edge-developer-tools
So the API is not reading the correct variables from the editor and I cannot access the root directory path in my extension's code
Thanks for the help!

Does this issue occur when all extensions are disabled?: Yes/No
Yes

When you launch the new window to debug the extension by pressing F5, have you opened a folder in that window? vscode.window.workspaceFolders will return the folders that are currently open in vscode itself. If you're trying to get the path to the extension code, you can use the extensionPath on the context the extension activates with: https://github.com/microsoft/vscode/blob/d91ca067cab6a9a52ba07feb50c9c800d0891552/src/vs/vscode.d.ts#L5407-L5410

@astoycos Please let me know if that doesn't solve your problem.

Hey @RMacfarlane,
Thanks for getting back to me sorry for the late reply! So when I press F5 I have to go and open a folder in the new window in order for the vscode.workspace.rootPath to work I understand that.  However when I try to mimic the following functionality (https://github.com/microsoft/vscode-extension-samples/blob/master/tree-view-sample/src/extension.ts#L14) in my extension's code I get an error even before pressing F5

So even in the Extension's source code window the variable vscode.workspace.workspaceFolders is not set.

@astoycos This is a warning from typescript, since vscode.workspace.workspaceFolders could be undefined in the case where no folder is open, its type is:
		/**
		 * List of workspace folders or `undefined` when no folder is open.
		 * *Note* that the first entry corresponds to the value of `rootPath`.
		 */
		export const workspaceFolders: ReadonlyArray<WorkspaceFolder> | undefined;

Likely you have --strictNullChecks enabled in TypeScript, which treats this as an error: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-0.html
To fix, you can check that vscode.workspace.workspaceFolders is not undefined before getting the first element

Ok, Thanks!

authors: RMacfarlane astoycos


text:
Suddenly unable to open files, settings or anything else

Issue Type: Bug
I don't have a lot steps to reproduce. It just seemed to happen out of nowhere. I have been working on a project every day using VS Code. This morning I'm working and suddenly when I try to switch tabs to another open file, I'm unable to do so and receive this message in the bottom right corner of the screen. Unable to open 'colors.js': Cannot read property 'other' of null. I disable all extensions and tried again. Still doesn't open anything. I quit the program and restarted. Didn't help either. When I tried to open a file after restarting, I received the same error message as before as well as a new but similar one. Unable to open 'colors.js': Assertion Failed: argument is undefined or null. I am able open the sidebar and and see the contents of folders. But that's all I can do. Any file I try to open, new or old I get these errors. Let me know if you need any more information.
VS Code version: Code 1.44.2 (ff915844119ce9485abfe8aa9076ec76b5300ddd, 2020-04-16T17:07:18.473Z)
OS version: Darwin x64 15.6.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-3330S CPU @ 2.70GHz (4 x 2700)

GPU Status
2d_canvas: unavailable_softwareflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: unavailable_offprotected_video_decode: unavailable_offrasterization: unavailable_offskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 1

Memory (System)
8.00GB (0.34GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

@ghostrib can you run Developer: Toggle Developer Tools and share any errors in the console?

This probably is https://github.com/microsoft/vscode/issues/94931

@ghostrib let us know if you believe it is something different.

authors: bpasero ghostrib sbatten


text:
Editor: Turn off cursor position showing on a slider

Editor has a feature that shows current cursor position. It is located on a slider on the right side of the screen. I personally don't like how it looks so I would like to have an option to disable this function.

I am sorry if this feature already exists, but I didn't find it. If it does please provide me with information how to turn it off.
Thank you.

Cursor position (horizontal line) can be hidden with "editor.hideCursorInOverviewRuler": true.
Is it what you were looking for?
Just in case vertical bar is from "editor.selectionHighlight": true - highlights text similar to selection across editor and shows them in overview ruler. If turned off - no vertical bars in ruler, but also no selections in editor.

See comment above.

authors: IllusionMH kieferrm younyokel


text:
Allow to create scratchpads (scratchpad = do not save this file)

Issue Type: Feature Request
problem statement:
ever so often i am dealing with JSON, i open a new untitled file in vs code and select language mode as JSON and paste it in the file to see a well-formatted JSON. As I go along I keep pressing save all files and every time i click save all i get the popup to save my untitled JSON file. It is useful if I want to save the untitled file but in this case its just a scratchpad. I would very much love to have some way to mark files as a scratchpad and select language mode for them.
in my case it is JSON however the language mode for scratchpad can be anything that is supported by vs code.
Please see if this is worth a feature.
thanks
Note: i realized scratchpad means something different. Here scratchpad means this will be a file and it will not be saved when its marked scratchpad. do-not-save-this-file, not sure what else to call this (one of the suggestions: Rough page/work).
VS Code version: Code - Insiders 1.46.0-insider (1bfa086adb9271ff56be11821da686e4cfffb672, 2020-06-02T06:55:33.079Z)
OS version: Windows_NT x64 10.0.18363

I use VScode to reformat text very often, whether it be from a file open in VScode or a spreadsheet. The Multiline editing is way better than anything else ive found.
I would be great to have a shortcut for pulling up a new "scratchpad".
Other possibly useful settings.json config options:

always open scratchpad in new split panel (right, left, up, down)
scratchpad closes when it loses focus
scratchpad persists through reload
optional historic scratchpad list in explorer sidebar

Thanks for all the Great Work VScode people! 👍

I would be interested in attempting to create this feature.

authors: Awbmilne mohtamba sanket-bhalerao


text:
Sluggish

Issue Type: Performance Issue
Unable to load extensions, everything freezes
VS Code version: Code 1.41.0 (9579eda04fdb3a9bba2750f15193e5fafe16b959, 2019-12-11T18:37:42.077Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2592)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.85GB (1.21GB free)

Process Argv

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    1	    95	 10940	code main
    0	    70	  3656	   shared-process
    0	    14	  8264	   electron-crash-reporter
    0	   195	  8528	   window (index.html - TEEAARBEE - Visual Studio Code)
    0	    13	  3596	     watcherService
    0	    11	  9788	       console-window-host (Windows internal process)
    0	    35	  5940	     searchService
    8	   226	 17104	     extensionHost
    0	    88	  2240	       "C:\Users\G Rohit\AppData\Local\Programs\Microsoft VS Code\Code.exe" "c:\Users\G Rohit\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\html-language-features\server\dist\htmlServerMain" --node-ipc --clientProcessId=17104
    0	    36	  3972	       electron_node eslintServer.js
    0	   162	 12616	   gpu-process
    0	    66	 13732	   window (Issue Reporter)

Workspace Info
|  Window (index.html - TEEAARBEE - Visual Studio Code)
|    Folder (TEEAARBEE): 336 files
|      File types: js(86) json(34) scss(25) svg(20) jpg(18) html(13) png(13)
|                  css(9) mdx(5) eot(4)
|      Conf files: package.json(1);

Extensions (29)

Extension
Author (truncated)
Version

html-snippets
abu
0.2.1

vscode-css-formatter
aes
1.0.1

vscode-json
and
1.5.0

minify-selection
box
0.0.2

htmltagwrap
bra
0.0.7

bracket-pair-colorizer
Coe
1.0.61

vscode-eslint
dba
2.1.1

css-minify
Die
0.1.12

prettier-vscode
esb
5.0.0

auto-close-tag
for
0.5.7

auto-rename-tag
for
0.1.1

beautify
Hoo
1.5.0

minify
Hoo
0.4.3

uikit-3-snippets
Ken
1.4.2

wrapSelection
kon
0.8.0

es6-css-minify
olb
3.3.2

open-html-in-browser
pea
2.1.3

emoji
Per
0.0.3

material-icon-theme
PKi
4.1.0

html-to-jsx
ria
0.0.1

live-sass
rit
3.0.0

LiveServer
rit
5.6.1

markdown-preview-enhanced
shd
0.5.12

indenticator
Sir
0.6.0

sass-indented
syl
1.8.5

bootstrap4-vscode
the
6.1.0

vscode-import-cost
wix
2.12.0

JavaScriptSnippets
xab
1.8.0

html-css-class-completion
Zig
1.19.0

(2 theme extensions excluded)

Please follow our Performance wiki - https://github.com/microsoft/vscode/wiki/Performance-Issues and provide necessary information.


text:
Extension management does not work when on Ubuntu installed from snap

Issue Type: Bug

sudo snap install code --classic
code
Open extension management. Observe:
3.1. "recommended" list is empty
3.2. marketplace search does not work (the blue line above the search just keeps running forever)
3.3. there's a "clock" mark on the "extensions" icon in the left bar
3.4. no updates for extensions are pulled
3.5. extensions can be deleted, but they do not disappear from the extension list, the only indication is that the "cog" icon for them stops to work
3.6. Even "Install from VSIX..." functionality fails to work (no error is displayed).

Workaround:

Uninstall the snap, dowlnoad a .deb from the VS Code website, install the .deb
Everything works - existing extensions can be updated, installing new extensions from the marketplace works.

I have seen no network requests or relevant console errors in Developer Tools; no messages from code --verbose output seemed relevant.
My hunch is it has to do something with snap permissions, possibly garbled by upgrading Ubuntu from the previous version.
VS Code version: Code 1.46.0 (a5d1cc28bb5da32ec67e86cc50f84c67cc690321, 2020-06-10T08:59:04.923Z)
OS version: Linux x64 5.5.0-050500-lowlatency snap

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (8 x 1666)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: disabled_off_okvideo_decode: unavailable_offviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
15.52GB (1.06GB free)

Process Argv
. --no-sandbox

Screen Reader
no

VM
0%

DESKTOP_SESSION
xubuntu

XDG_CURRENT_DESKTOP
XFCE

XDG_SESSION_DESKTOP
xubuntu

XDG_SESSION_TYPE
x11

Extensions (17)

Extension
Author (truncated)
Version

vscode-css-formatter
aes
1.0.1

vscode-hie-server
ala
0.0.40

vscode-bazel
Baz
0.3.0

better-toml
bun
0.3.2

bazel-code
Dev
0.1.9

vscode-wasm
dts
1.3.1

gitlens
eam
10.2.2

lex-flex-yacc-bison
fau
0.0.3

Go
gol
0.14.4

language-haskell
jus
3.2.1

restructuredtext
lex
128.0.0

rust-analyzer
mat
0.2.199

vscode-docker
ms-
1.2.1

python
ms-
2020.5.86806

cpptools
ms-
0.28.3

slim
sia
0.1.2

change-case
wma
1.0.0

(1 theme extensions excluded)

Please share the logs from the following locations
- Help -> Toggle Developer Tools -> Console
- View -> Command Pallette... -> Toggle Shared Process -> Console
- View -> Open View… -> Log (Shared)
- View -> Open View… -> Log (Window)

It's the same for me, but installing extension from the command line code --install-extension xyz.xyz is working.

@sandy081

Please share the logs from the following locations

Help -> Toggle Developer Tools -> Console

/snap/code/34/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:264 [Extension Host] activating extension
/snap/code/34/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:264 [Extension Host] starting language server
/snap/code/34/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:264 [Extension Host] updateCustomBrowseConfiguration
/snap/code/34/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:264 [Extension Host] (node:19626) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
t.log @ /snap/code/34/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:264
/snap/code/34/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:264 [Extension Host] (node:19626) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
t.log @ /snap/code/34/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:264

View -> Command Pallette... -> Toggle Shared Process -> Console

empty

View -> Open View… -> Log (Shared)

doesn't exist

View -> Open View… -> Log (Window)

doesn't exist
However a Log(Extension Host) exist which shows
[2020-06-17 15:57:38.390] [exthost] [info] extension host started
[2020-06-17 15:57:38.418] [exthost] [info] ExtensionService#_doActivateExtension vscode.configuration-editing {"startup":false,"extensionId":{"value":"vscode.configuration-editing","_lower":"vscode.configuration-editing"},"activationEvent":"onLanguage:jsonc"}
[2020-06-17 15:57:38.418] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/configuration-editing/dist/extension
[2020-06-17 15:57:38.421] [exthost] [info] ExtensionService#_doActivateExtension vscode.json-language-features {"startup":false,"extensionId":{"value":"vscode.json-language-features","_lower":"vscode.json-language-features"},"activationEvent":"onLanguage:jsonc"}
[2020-06-17 15:57:38.421] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/json-language-features/client/dist/jsonMain
[2020-06-17 15:57:38.434] [exthost] [info] ExtensionService#_doActivateExtension vscode.typescript-language-features {"startup":false,"extensionId":{"value":"vscode.typescript-language-features","_lower":"vscode.typescript-language-features"},"activationEvent":"onLanguage:jsonc"}
[2020-06-17 15:57:38.434] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/typescript-language-features/dist/extension
[2020-06-17 15:57:38.443] [exthost] [info] ExtensionService#_doActivateExtension vscode.debug-auto-launch {"startup":true,"extensionId":{"value":"vscode.debug-auto-launch","_lower":"vscode.debug-auto-launch"},"activationEvent":"*"}
[2020-06-17 15:57:38.443] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/debug-auto-launch/dist/extension
[2020-06-17 15:57:38.444] [exthost] [info] ExtensionService#_doActivateExtension vscode.emmet {"startup":true,"extensionId":{"value":"vscode.emmet","_lower":"vscode.emmet"},"activationEvent":"*"}
[2020-06-17 15:57:38.444] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/emmet/dist/extension
[2020-06-17 15:57:38.454] [exthost] [info] ExtensionService#_doActivateExtension vscode.git {"startup":true,"extensionId":{"value":"vscode.github","_lower":"vscode.github"},"activationEvent":"*"}
[2020-06-17 15:57:38.454] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/git/dist/main
[2020-06-17 15:57:38.466] [exthost] [info] ExtensionService#_doActivateExtension vscode.github-authentication {"startup":true,"extensionId":{"value":"vscode.github-authentication","_lower":"vscode.github-authentication"},"activationEvent":"*"}
[2020-06-17 15:57:38.466] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/github-authentication/dist/extension.js
[2020-06-17 15:57:38.471] [exthost] [info] ExtensionService#_doActivateExtension vscode.merge-conflict {"startup":true,"extensionId":{"value":"vscode.merge-conflict","_lower":"vscode.merge-conflict"},"activationEvent":"*"}
[2020-06-17 15:57:38.471] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/merge-conflict/dist/extension
[2020-06-17 15:57:38.472] [exthost] [info] ExtensionService#_doActivateExtension vscode.microsoft-authentication {"startup":true,"extensionId":{"value":"vscode.microsoft-authentication","_lower":"vscode.microsoft-authentication"},"activationEvent":"*"}
[2020-06-17 15:57:38.472] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/microsoft-authentication/dist/extension.js
[2020-06-17 15:57:38.479] [exthost] [info] ExtensionService#_doActivateExtension vscode.search-result {"startup":true,"extensionId":{"value":"vscode.search-result","_lower":"vscode.search-result"},"activationEvent":"*"}
[2020-06-17 15:57:38.480] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/search-result/dist/extension.js
[2020-06-17 15:57:38.480] [exthost] [info] ExtensionService#_doActivateExtension eamodio.gitlens {"startup":true,"extensionId":{"value":"eamodio.gitlens","_lower":"eamodio.gitlens"},"activationEvent":"*"}
[2020-06-17 15:57:38.480] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/mat/.vscode/extensions/eamodio.gitlens-10.2.1/dist/extension
[2020-06-17 15:57:38.495] [exthost] [info] ExtensionService#_doActivateExtension Gruntfuggly.todo-tree {"startup":true,"extensionId":{"value":"Gruntfuggly.todo-tree","_lower":"gruntfuggly.todo-tree"},"activationEvent":"*"}
[2020-06-17 15:57:38.495] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/mat/.vscode/extensions/gruntfuggly.todo-tree-0.0.169/extension
[2020-06-17 15:57:38.615] [exthost] [info] ExtensionService#_doActivateExtension hbenl.vscode-test-explorer {"startup":true,"extensionId":{"value":"hbenl.vscode-test-explorer","_lower":"hbenl.vscode-test-explorer"},"activationEvent":"*"}
[2020-06-17 15:57:38.615] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/mat/.vscode/extensions/hbenl.vscode-test-explorer-2.17.0/out/main.js
[2020-06-17 15:57:38.623] [exthost] [info] ExtensionService#_doActivateExtension mhutchie.git-graph {"startup":true,"extensionId":{"value":"mhutchie.git-graph","_lower":"mhutchie.git-graph"},"activationEvent":"*"}
[2020-06-17 15:57:38.623] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/mat/.vscode/extensions/mhutchie.git-graph-1.21.0/out/extension.js
[2020-06-17 15:57:38.632] [exthost] [info] ExtensionService#_doActivateExtension SirTori.indenticator {"startup":true,"extensionId":{"value":"SirTori.indenticator","_lower":"sirtori.indenticator"},"activationEvent":"*"}
[2020-06-17 15:57:38.632] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/mat/.vscode/extensions/sirtori.indenticator-0.6.0/out/src/extension
[2020-06-17 15:57:38.634] [exthost] [info] ExtensionService#_doActivateExtension vscode.npm {"startup":true,"extensionId":{"value":"vscode.npm","_lower":"vscode.npm"},"activationEvent":"workspaceContains:package.json"}
[2020-06-17 15:57:38.634] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/npm/dist/main
[2020-06-17 15:57:38.638] [exthost] [info] ExtensionService#_doActivateExtension ms-vscode.cpptools {"startup":true,"extensionId":{"value":"maddouri.cmake-tools-helper","_lower":"maddouri.cmake-tools-helper"},"activationEvent":"workspaceContains:CMakeLists.txt"}
[2020-06-17 15:57:38.638] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/mat/.vscode/extensions/ms-vscode.cpptools-0.26.3/dist/main
[2020-06-17 15:57:38.697] [exthost] [info] ExtensionService#_doActivateExtension twxs.cmake {"startup":true,"extensionId":{"value":"maddouri.cmake-tools-helper","_lower":"maddouri.cmake-tools-helper"},"activationEvent":"workspaceContains:CMakeLists.txt"}
[2020-06-17 15:57:38.697] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/mat/.vscode/extensions/twxs.cmake-0.0.17/out/extension
[2020-06-17 15:57:39.203] [exthost] [info] ExtensionService#_doActivateExtension vscode.github {"startup":true,"extensionId":{"value":"vscode.github","_lower":"vscode.github"},"activationEvent":"*"}
[2020-06-17 15:57:39.203] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/github/dist/extension.js
[2020-06-17 15:57:39.454] [exthost] [info] eager extensions activated

Please share the logs from the following locations

Help -> Toggle Developer Tools -> Console

/snap/code/34/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:5063 Overwriting grammar scope name to file mapping for scope source.regexp.python.
Old grammar file: file:///snap/code/34/usr/share/code/resources/app/extensions/python/syntaxes/MagicRegExp.tmLanguage.json.
New grammar file: file:///home/rainman/.vscode/extensions/devondcarew.bazel-code-0.1.9/syntax/MagicRegExp.tmLanguage.json
register @ /snap/code/34/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:5063
/snap/code/34/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:5063 Overwriting grammar scope name to file mapping for scope source.rust.
Old grammar file: file:///snap/code/34/usr/share/code/resources/app/extensions/rust/syntaxes/rust.tmLanguage.json.
New grammar file: file:///home/rainman/.vscode/extensions/matklad.rust-analyzer-0.2.199/rust.tmGrammar.json
register @ /snap/code/34/usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:5063

and no new messages when opening the extensions screen

View -> Command Pallette... -> Toggle Shared Process -> Console

empty

View -> Open View… -> Log (Shared)

[2020-06-17 17:19:00.716] [sharedprocess] [info] main {"machineId":"80c5520241e401c5cecd7b45986b0f1b331f6ac97f807c13fd15e69ff6492839","windowId":2}
[2020-06-17 17:19:40.728] [sharedprocess] [info] Starting to clean up unused language packs.

View -> Open View… -> Log (Window)

doesn't exist, but there's Log(Main):
[2020-06-17 17:18:57.048] [main] [info] update#setState idle
[2020-06-17 17:19:27.058] [main] [info] update#setState checking for updates
[2020-06-17 17:19:27.062] [main] [info] update#setState idle

Also there is  Log(Extension Host):
[2020-06-17 17:18:58.919] [exthost] [info] extension host started
[2020-06-17 17:18:58.941] [exthost] [info] ExtensionService#_doActivateExtension vscode.debug-auto-launch {"startup":true,"extensionId":{"value":"vscode.debug-auto-launch","_lower":"vscode.debug-auto-launch"},"activationEvent":"*"}
[2020-06-17 17:18:58.941] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/debug-auto-launch/dist/extension
[2020-06-17 17:18:58.944] [exthost] [info] ExtensionService#_doActivateExtension vscode.emmet {"startup":true,"extensionId":{"value":"vscode.emmet","_lower":"vscode.emmet"},"activationEvent":"*"}
[2020-06-17 17:18:58.944] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/emmet/dist/extension
[2020-06-17 17:18:58.955] [exthost] [info] ExtensionService#_doActivateExtension vscode.git {"startup":true,"extensionId":{"value":"vscode.github","_lower":"vscode.github"},"activationEvent":"*"}
[2020-06-17 17:18:58.955] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/git/dist/main
[2020-06-17 17:18:58.991] [exthost] [info] ExtensionService#_doActivateExtension vscode.github-authentication {"startup":true,"extensionId":{"value":"vscode.github-authentication","_lower":"vscode.github-authentication"},"activationEvent":"*"}
[2020-06-17 17:18:58.991] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/github-authentication/dist/extension.js
[2020-06-17 17:18:58.994] [exthost] [info] ExtensionService#_doActivateExtension vscode.merge-conflict {"startup":true,"extensionId":{"value":"vscode.merge-conflict","_lower":"vscode.merge-conflict"},"activationEvent":"*"}
[2020-06-17 17:18:58.994] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/merge-conflict/dist/extension
[2020-06-17 17:18:58.995] [exthost] [info] ExtensionService#_doActivateExtension vscode.microsoft-authentication {"startup":true,"extensionId":{"value":"vscode.microsoft-authentication","_lower":"vscode.microsoft-authentication"},"activationEvent":"*"}
[2020-06-17 17:18:58.995] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/microsoft-authentication/dist/extension.js
[2020-06-17 17:18:59.004] [exthost] [info] ExtensionService#_doActivateExtension vscode.search-result {"startup":true,"extensionId":{"value":"vscode.search-result","_lower":"vscode.search-result"},"activationEvent":"*"}
[2020-06-17 17:18:59.004] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/search-result/dist/extension.js
[2020-06-17 17:18:59.005] [exthost] [info] ExtensionService#_doActivateExtension eamodio.gitlens {"startup":true,"extensionId":{"value":"eamodio.gitlens","_lower":"eamodio.gitlens"},"activationEvent":"*"}
[2020-06-17 17:18:59.005] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/rainman/.vscode/extensions/eamodio.gitlens-10.2.2/dist/extension
[2020-06-17 17:18:59.052] [exthost] [info] ExtensionService#_doActivateExtension vscode.npm {"startup":true,"extensionId":{"value":"vscode.npm","_lower":"vscode.npm"},"activationEvent":"workspaceContains:package.json"}
[2020-06-17 17:18:59.052] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/npm/dist/main
[2020-06-17 17:18:59.146] [exthost] [info] ExtensionService#_doActivateExtension vscode.github {"startup":true,"extensionId":{"value":"vscode.github","_lower":"vscode.github"},"activationEvent":"*"}
[2020-06-17 17:18:59.146] [exthost] [info] ExtensionService#loadCommonJSModule file:///snap/code/34/usr/share/code/resources/app/extensions/github/dist/extension.js
[2020-06-17 17:18:59.259] [exthost] [info] ExtensionService#_doActivateExtension golang.Go {"startup":true,"extensionId":{"value":"golang.Go","_lower":"golang.go"},"activationEvent":"workspaceContains:**/*.go"}
[2020-06-17 17:18:59.259] [exthost] [info] ExtensionService#loadCommonJSModule file:///home/rainman/.vscode/extensions/golang.go-0.14.4/out/src/goMain
[2020-06-17 17:18:59.472] [exthost] [info] eager extensions activated

I am really no clue what's happening here
@joaomoreno seems it works with deb package but not with snap. Any clue?

Similar to https://github.com/microsoft/vscode/issues/86583. @kyegupov Do you mind going through that issue and seeing if you find anything relevant to you?

@joaomoreno I have looked a #86583, but it doesn't apply to me directly: I don't use imwheel and the shared-process seems to be running (I can see it in the process explorer).

authors: deimi joaomoreno kyegupov sandy081


text:
New user feedback survey

As we are working to improve first-time setup experience of VS Code, we need to make it easier for new users to tell us about what's working and what is not working for them.
Preliminary heuristics:

Wait at least 1hr after VS Code's initial startup before showing the survey, but only show it within the first 24hrs of usage.
Wait for at least 5min after startup to show the survey.
When a user asks to remind later, wait for at least 4hrs. This ensures that we still focus on the first-time experience.
Drop Never show again button in favor of disabling the survey when the user closes the prompt.
Probability/eligibility is controlled via sampling in experimentation.

The timings above are a starting point and will evolve as we learn.

I think this is modeled after our existing NPS survey code which I think @joaomoreno added so he can maybe also review.
Overall I feel the TODO should be addressed and maybe the setTimeout put into a RunOnceScheduler that gets disposed when the workbench contribution gets disposed.

I see. The RunOnceScheduler might actually be limiting you in functionality. What you wanna use is the ThrottledDelayer: it provides debouncing and awaits for the async function to complete. I've pushed a commit on top which refactors the code to use it, which also improves readability. Give it a test.

@joaomoreno did take a shot based on your commit (and cleaned up some of the naming).

Pushed another smaller change: there was a bad typing on that optional service import, it could potentially be undefined since it's @optional.

We talked offline, the risk seems small from what I gather as this will be off by default on stable.

source: gharchive/pull-request

authors: TylerLeonhardt bpasero digitarald joaomoreno


text:
RPM packaging: Use standard macros

This PR, which builds on #142907 (and stems from the discussion in https://github.com/microsoft/vscode/pull/142907#discussion_r901851077), updates the RPM spec file to use standard RPM macros where appropriate in the package definition.

Once the placeholder @@NAME@@ is replaced into the specfile definition of Name:, its value can be referenced using the %{name} macro, requiring less substitution on the template specfile.
The standard macros %{_bindir} and %(_datadir} are preferred, when specifying paths for installed files (either in the %{builddir} tree, during %install, or in the %files list).

Also:

The directory creations in the %install section are now sorted to match the other references to those paths throughout  the file
Broke %install up into coarse sections, each labeled with a preceding comment

Sorry, I forgot to merge the PR 🤦♂
New target for merging is next debt week (week of August 8)


text:
Command Center With Help

Fixes #158638
Now when you launch the command center you get:

Additionally, if you go into a provider (say >) and then backspace out of it, thus returning to Go to file... you still get the Help.
To be clear, this only shows when you click on the command center. Cmd+P is not impacted at all.
we can improve on this later with pills and whatnot, but this gives the command center a bit more utility than just launching Cmd+P.
cc @daviddossett
gonna cc @bpasero for a late review when you're back from being OOF

👏 , lets sync today on this change for some feedback I have.

authors: TylerLeonhardt bpasero


text:
Remove unused import in extensions/git/src/api/git.d.ts

Fix #200800
By the way, please for the love of every gods this planet, make #198592 happen, it's impossible to use the API without documentation NOR source files the API uses

@Malix-off, thank you very much for your contribution. I will go ahead and close this as there is very little value add here.
If you'd like to help out, check out our Contribution Guide:

Issues labeled help wanted are good issues to submit a PR for. Issues labeled good first issue are great candidates to pick up if you are in the code for the first time.

Waht.
Okay it's little value added but it still value added, I do not care having my name tied to the commit, you can take credit idc I just want the clutter removed

authors: Malix-off lszomoru


text:
Avoid printf in bash SI script, disable prompt reporting on Windows

Fixes #212090

Is it possible to get this change into recovery build, because now all new reports are coming from 1.90?

@Tyriar the performance issue was not due to printf being slow. It was caused by shelling out to printf twice in a huge loop (so potentially hundreds of forked processes or more!). Note printf is a bash builtin, so it should be very fast.
I create a gist that demonstrates this theory by comparing the performance of 4 separate bash functions.

escape_with_printf_slow - this is the original method (using printf in subshells)
escape_with_printf_fast - this is the original method modifed to use printf without subshells
escape_with_loop - this is the method used in this PR (using if-else statements)
escape_with_case - this is a slightly modified method that uses a single case statement

The performance differences are massive (see output below)! For example, the original printf function is over 500x slower than the modified printf function (without subshells). Even the function from this PR is 5x slower than either of the other two, so there is still room for improvement.
escape_with_printf_slow:

real    0m19.979s
user    0m2.149s
sys     0m17.200s

escape_with_printf_fast:

real    0m0.038s
user    0m0.046s
sys     0m0.000s

escape_with_loop:

real    0m0.203s
user    0m0.188s
sys     0m0.000s

escape_with_case:

real    0m0.047s
user    0m0.062s
sys     0m0.000s

@billyzkid this is great thanks! I'll adapt it to not shell out and use printf instead 👍

authors: IllusionMH Tyriar billyzkid


text:
Add ReturnResponse for PackageInUseByApplication to Validator Enum

https://github.com/microsoft/winget-cli/pull/2492#issuecomment-1235807256
I think this is all that needs to be done? But, if it isn't, please let me know

Thanks @Trenly Can you also update the spec at documentation/WinGet-1.4.0.yaml as well?

Thanks @Trenly Can you also update the spec at documentation/WinGet-1.4.0.yaml as well?

Done

/azp run

authors: Trenly yao-msft

repo: microsoft/winget-cli-restsource


text:
Pipeline fails PR validation when a manifest gets deleted

When renaming a manifest's name (and thus the folder it resides in) the validation will fail, apparently because it counts the deletion and addition as two manifests.
Expected behavior is that it doesn't count the deletion and only attempts to validate the addition.
Excerpt from the pipeline:
Starting: Validate Pull Request
==============================================================================
Task         : Command line
Description  : Run a command line script using Bash on Linux and macOS and cmd.exe on Windows
Version      : 2.164.1
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/command-line
==============================================================================
Generating script.
Script contents:
WinGetSvcWrapper.exe process-pr --operationId %BUILD_BUILDNUMBER%
========================== Starting Command Output ===========================
"C:\windows\system32\cmd.exe" /D /E:ON /V:OFF /S /C "CALL "d:\a\_temp\26ffc85a-7662-4705-aa66-f57c37d97630.cmd""
Logger path is: d:\a\1\a\Logs\WinGetSvc-Validation-17-1446-20200601-1_process-pr_Logs.txt

****************************************************************************************
Pull Request Validation
****************************************************************************************
Status: Started
Added the following files:
File: manifests/Vercel/Hyper/3.0.2.1510.yaml
Deleted the following files:
File: manifests/Zeit/Hyper/3.0.2.1510.yaml
Status: Completed
##[error] Result: Failed
##[error] The pull request contains more than one manifest file.
##[error]Pull Request Validation Failed

****************************************************************************************
Pull Request Validation
****************************************************************************************
Status: Completed
##[error] Result: Failed
##[error] One or more errors occurred. (The pull request contains more than one manifest file.) The pull request contains more than one manifest file.
Finishing: Validate Pull Request

This is blocking the following pull requests:

#1446
#1283

Tried circumventing this issue using git mv in both #1506 and #1507, still couldn't get around it. This is driving me nuts!

This issue should now be resolved.

This issue should now be resolved.

authors: MarNicGit denelon

repo: microsoft/winget-pkgs


text:
[Modify Feature]: Have pipelines accept non-zero exit codes below 1000(?) as passing instead of failing.

Description of the new feature/enhancement
During validation, the pipelines run every executable added to the filesystem during the install process, then close each and record the exit code. If none give a zero exit code, I believe, then the PR gets the Validation-Executable-Error label. Then a moderator is supposed to install the package into a sandbox or VM and verify.
It's something of a known issue with our pipelines that they always error with normal CLI application design. This is because the pipeline runs the CLI application without any arguments, and expects a zero exit code. But most CLI applications are designed to return a non-zero exit code when run without arguments. Frequently, this number is single-digit, so 10 could be a better value than 1000. But I've seen applications with exit codes as high as 127 that ran without issue in a VM.
Proposed technical implementation details (optional)
If a lower value than 1000 would be better, that would be great. I might not have thought through all edge cases, and I'm not an expert on exit codes, so please be gentle.
I've generally been approving PRs with exit codes below 1000 without verifying, and haven't heard of any issues from users. So I would like to have this added into the pipelines, to facilitate better CLI application acceptance into the repo.
This might interoperate well with the suggestion for an ApplicationType of GUI, CLI, etc, where these policies could be applied solely to the CLI applications.

I wonder if there is a need to extend ExpectedReturnCodes here into the portable application space. When the ExpectedReturnCodes are used with an installer, it indicates why the installer may have failed. However, since WinGet is the installer for portable applications, it may make sense for the ExpectedReturnCodes for a portable package to be what the application may return. This would enable the pipelines to check BaseInstallerType == Portable && returnCode in ExpectedReturnCodes to see if the application ran successfully. This would allow manifest authors to specify something like:
InstallerType: portable
ExpectedReturnCodes:
  - InstallerReturnCode: 1
    ReturnResponse: invalidParameter

Since parameters like --help,  --version (or similarly top level commands cli.exe help, cli.exe version) are very common in CLI design and expected to return a zero return code, what if the pipelines behavior is extended to check against these params/commands too by default. If invoking the CLI gives a non-zero return code, the pipelines can then test by passing in these params/commands and see if they return a success code
I think this can cover a lot of portable apps in the repo. I don't have the data to back my claim but in my experience reviewing portable PRs, this is something that I've noticed as a pattern

authors: Trenly mdanish-kh stephengillie


text:
New version: Xmarmalade.AlistHelper version v0.1.2

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?
[X] This PR only modifies one (1) manifest
[X] Have you validated your manifest locally with winget validate --manifest <path>?
[X] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.4 schema?

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/111730&drop=dogfoodAlpha

@wingetbot waivers Add Validation-Executable-Error

@wingetbot run

authors: ItzLevvie SpecterShell stephengillie


text:
New version: eza-community.eza version 0.13.0

Pull request has been created with WinGet Releaser v2 :rocket:
Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree


text:
New version: StandardNotes.StandardNotes version 3.185.3

Pull request has been created with Komac v1.11.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping @Exorcism0666, I'll get a notification.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！


text:
New version: appmakes.Typora version 1.8.6

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?
[X] This PR only modifies one (1) manifest
[X] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.5 schema?

Microsoft Reviewers: Open in CodeFlow

/AzurePipelines run

/AzurePipelines run

authors: SpecterShell stephengillie


text:
New version: Ruben2776.PicView version 2.2.1

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[x] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @Ruben2776,

This PR's version number 2.2.1 has 3 parameters (sets of numbers between dots - major, minor, etc), which is greater than the current manifest's version 2.2, which has 2 parameters.

Is this intentional?
(Automated response - build 672)

Hi @Ruben2776,

This PR's version number 2.2.1 has 3 parameters (sets of numbers between dots - major, minor, etc), which is greater than the current manifest's version 2.2, which has 2 parameters.

Is this intentional?
(Automated response - build 672)

Yes, the new version is 2.2.1


text:
New version: Fly-io.flyctl version 0.2.10

Pull request has been created with komac v2.1.1 :rocket:

For moderators
This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping Exorcism0666.

[!warning]
With the new version of Komac, numerous Pull Requests may contain bugs or unwanted elements. If such issues arise, please tag russellbanks so that these bugs can be addressed in future updates.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！


text:
Remove Ant Commander Pro version 4.8

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Removed Ant Commander Pro version 4.8 as latest version is 4.10
Microsoft Reviewers: Open in CodeFlow

URL: https://www.antcommander.com/versions/AntCommanderPro-4.8.exe
OK
(Automated message - build 882)

authors: japplis stephengillie


text:
New version: HandBrake.HandBrake version 1.8.0

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Close with reason: Duplicate of #154356;

authors: PckgrBot stephengillie


text:
Remove version: LiErHeXun.Quicker version 1.36.22.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

For moderators or/and anyone else

[!Caution]
As a result of several personal problems I've had over the last few months + my final exams coming up very soon, I'm currently unable to look at my GitHub notifications every day and maintain my executions correctly.
If you detect a certain problem on a certain pul request:

Either you can close the pull request directly without mentioning me.
Or you can send me a message on X (Twitter): @Exorcism0666

Thank you for your understanding, and I'm sorry if some pull requests can't be approved due to the situation I'm in.

This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping Exorcism0666.

[!warning]
With the new version of Komac, numerous Pull Requests may contain bugs or unwanted elements. If such issues arise, please tag russellbanks so that these bugs can be addressed in future updates.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

Close with reason: URL works for me;


text:
Remove version: Jackett.Jackett version 0.20.2617

404 - release deleted
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Jackett/Jackett/releases/download/v0.20.2617/Jackett.Installer.Windows.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 918)

authors: russellbanks stephengillie


text:
New version: Oracle.VirtualBox version 7.1.0

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[x] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

cough Virtualbox 7.1.2 is out... https://download.virtualbox.org/virtualbox/7.1.2/

authors: EarldridgeJazzedPineda R-Adrian


text:
Remove version: Google.Chrome.Canary version 133.0.6842.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://dl.google.com/release2/chrome/kgz6ql5edf7awvhltvmzkb2rnq_133.0.6842.0/133.0.6842.0_chrome_installer.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 923)


text:
FSN.TyperspeedSepia version 3.0.5

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[x] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

If I can run the installer and execute the installed software just fine, how has the installer validation failed?

/azp run

@fireseed66 it's the age old problem of "works on my machine". The validation is running in an isolated environment with minimal dependencies and very specific scope (user vs. machine) and architecture (x64, x86, etc.). There are many different reasons it might not pass validation, but run just fine on a different machine. I often get caught by dependencies on my local machine that aren't present in the testing environment to validate just those specific kinds of conditions. Of course there could always be a "bug" too.

Is there a way I can simply remove the manifest from here so it's no longer available on Winget, then start the whole manifest creation and submission process again?

Any users who want the package would loose access to it if there is no manifest. Are you wanting to manually create the manifest or use a tool? You could create it on a different branch and then attempt to merge it in.

I'll use the Winget Create tool. There's no option in this tool to remove the manifest, though. I'm not all that familiar with git, so...

authors: ChuckFerring denelon fireseed66


text:
New version: Azul.Zulu.7.JDK version 7.52.0.11

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?
[X] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.1 schema?

Microsoft Reviewers: Open in CodeFlow

/azp run

@wingetbot run

authors: Trenly russellbanks ryfu-msft


text:
Delete manifests/o/Opera/OperaGX/76.0.4017.208 directory

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

@jedieaston We keep the latest version for Brave, Edge and Chrome browsers since they auto-update themselves to newer versions. Hence, doing the same for Opera.

@wingetbot run

.


text:
Ferdium.Ferdium.Nightly version 6.2.1-beta.1

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Since Ferdium.Ferdium.Beta already exists as a package identifier, I believe it makes most sense for the beta versions to be there

Yes, sorry for that. It appears that my script interpreted the last release as a Nightly instead of a Beta, which made the wingetcreate update base itself on the wrong manifest template. I have pushed changes that hopefully fix the manifests now.


text:
Java Snippet Generation - OpenAPI

Refactor Java Snippet Generation To Use Code SnippetCodeGraph Class

Same argument holds for Java:
https://github.com/microsoftgraph/microsoft-graph-devx-api/issues/1025#issuecomment-1159322299

Hello @rkodev, do we have updates on this issue?

authors: isvargasmsft rkodev zengin

repo: microsoftgraph/microsoft-graph-devx-api


text:
Guid interaction

In an original Graph Explorer build, in the response that came back. It was super easy to click on the GUIDs and get some options:
Copy ID
Being able to just copy the GUID. Many times in code I want to grab GUIDs quickly. Selecting them in the response is hard in Chrome/Edge. This would be much smoother an experience.
Run query
Imagine the scenario where you run /me/events and then click on the event-id in the json response. This immediately changes the graph explorer address bar to /me/events/{event-id} and returns that response. It makes the graph more "graphy" navigating around.
We would want some obvious way that either on hover or clicking on GUID has an interaction.
AB#7504

@RabebOthmani  looks like a feature parity issue compared to previous version of GE

@adhiambovivian As a partial solution, could you ask one of the devs to look into the Monaco editor configuration options so that when we double click on a GUID it highlights the entire GUID and does not stop at the nearest hyphen?  Thanks.

Can I get some screenshots of what the experience is like now, and the expected outcome of the fix? Thank you :)

authors: Onokaev adhiambovivian darrelmiller jthake-msft


text:
replaces content-type header by accept to match HTTP and avoid CORS preflight

Overview
The auto-complete feature is currently using the Content-Type request header.
Not only this is the wrong header to specify which format you want in return from the server, it also forces a CORS preflight which double the load per auto-complete "run" on the service, degrading the end user experience.
This pull request corrects the header usage.
Demo

Wrong:
Invoke-WebRequest -Uri "https://graphexplorerapi.azurewebsites.net/openapi?url=/&style=geautocomplete&graphVersion=v1.0" `
-Headers @{
"method"="GET"
  "authority"="graphexplorerapi.azurewebsites.net"
  "scheme"="https"
  "path"="/openapi?url=/&style=geautocomplete&graphVersion=v1.0"
  "user-agent"="Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.88 Safari/537.36"
  "accept"="*/*"
  "origin"="https://developer.microsoft.com"
  "sec-fetch-site"="cross-site"
  "sec-fetch-mode"="cors"
  "sec-fetch-dest"="empty"
  "referer"="https://developer.microsoft.com/"
  "accept-encoding"="gzip, deflate, br"
  "accept-language"="en-US,en;q=0.9,fr;q=0.8"
} `
-ContentType "application/json"

Right:
Invoke-WebRequest -Uri "https://graphexplorerapi.azurewebsites.net/openapi?url=/&style=geautocomplete&graphVersion=v1.0" `
-Headers @{
"method"="GET"
  "authority"="graphexplorerapi.azurewebsites.net"
  "scheme"="https"
  "path"="/openapi?url=/&style=geautocomplete&graphVersion=v1.0"
  "user-agent"="Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.88 Safari/537.36"
  "accept"="application/json"
  "origin"="https://developer.microsoft.com"
  "sec-fetch-site"="cross-site"
  "sec-fetch-mode"="cors"
  "sec-fetch-dest"="empty"
  "referer"="https://developer.microsoft.com/"
  "accept-encoding"="gzip, deflate, br"
  "accept-language"="en-US,en;q=0.9,fr;q=0.8"
} `

Notes
https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#Simple_requests
Testing Instructions
Run GE, try the auto-complete feature.

CC @finsharp @bettirosengugi

CC @thewahome


text:
[Docs] Provide complete example of authProvider creation.

This documentation ( link from )  https://github.com/microsoftgraph/msgraph-sdk-typescript/blob/6c55abb9b6593687899111f92c5f914eb8fd3fe8/README.md?plain=1#L32
Shows incomplete an example and delegates the creation of authProvider to another page showing authProvider from the old SDK, the link should be removed and documentation updated with a complete example showing the initialization of authProvider from this SDK.
It may also be useful to mention that they are not compatible.
more context: #479

Note; the changes will need to be replicated to core and beta as well.

authored #628

repo: microsoftgraph/msgraph-sdk-typescript


text:
Desperate for Graph 5.12 DriveItem directory list files example

Hello Jason,
I appreciate all your snippets!
Would you be able to provide one where you show how to use the GraphServiceClient to get a list of files in a specific directory (on OneDrive for example) like "Documents/Shipping/Invoices".
I've been struggling with QueryParameters.Select but not sure that's the correct way.
If you do it will be the only example on the entire internet at this time :)
Thank you,
Ronnie

@ScotchDroid sorry about not responding sooner - the notifications on this repo were getting lost in the void! This should be the code you need:
var childItems = await graphClient.Drives["driveId"]
    .Root
    .ItemWithPath("Documents/Shipping/Invoices")
    .Children
    .GetAsync();

Note that childItems will be files and subfolders.

authors: ScotchDroid jasonjoh

repo: microsoftgraph/msgraph-snippets-dotnet


text:
Testing

Some tests that can be used to verify between iterations if everything is working as expected.

Setup github action to run the client for a few seconds using the test script.


text:
Business model proposal about MW

Now, MW offer hosting, module/theme market service. But We know MW have shop feature.  then, i think MW team can build a center website "MW Hub". every website's owner can choose  to list or not list their products on MW Hub from MW adminpanel.  List on MW Hub is free. but every order from MW Hub, the website's owner must pay for about 2%(for example) to MW team.
when 10000 or even more website list their products on MW Hub, then MW Hub will be a big e-commerce website.
this prosocal is good,when MW's shop feature is very stable and scalable,

hi, yes we have this in the plan from few months, and now its just as a idea. probably we will start working on it in v 1.0.5

authors: jojouser peter-mw

repo: microweber/microweber


text:
V1.0.1

Capture instance is now much more configurable
Added setUrl and setUserAgent methods
Bin, jobs and output locations can now be changed

great stuff!! i love it!!

authors: MASNathan peter-mw

repo: microweber/screen

license: mit

license_source: bigquery


text:
Replace sassc with sass-embedded

The sassc gem (libsass) has been deprecated in Oct 2020. sass-embedded is a new ruby api implementation that uses the official dart-sass compiler internally.
This PR replaces sassc with new sass-embedded, so that users can use up to date dart-sass based implementation with latest features such as @use.

Because this PR is targeting 5.x, I decided to make some breaking change in terms of how config works. Now it is just a top level hash config[:sass], which user can set any config key that sass-embedded supports. For example:
# @see https://rubydoc.info/gems/sass-embedded/Sass#compile_string-class_method
set :sass {
  load_paths: [
    File.join(root, 'assets', 'stylesheets'),
    File.join(root, 'my-vendor', 'stylesheets')
  ],
  source_map: true,
  source_map_include_sources: true
}

config[:sass][:quiet_deps] = true

👍
Once this is merged to 5.x, I hope this is backported to 4.x.

@tdreyno This PR is ready for review. Please let me know if you have any feedbacks or questions.

Not sure what's the issue with failed macos ruby 3.1 CI test. The issue does not seem to be related to this change. Also, all tests worked fine for me on linux ruby 3.1 locally.

5.x is probably abandoned. Commented on not breaking config api compat. Might be best to re-target at 4.x/main

Note, this PR relies on sass-embedded ~> 1.70, which requires ruby >= 3.1.

@ntkme Do you think we can use a version which supports current CI matrix (Ruby 2.5+)? The idea is to keep compatibility for all those versions, so if that is not possible, we'll probably need to keep both code branches under some check.

In general, I'm in favor of dropping support of end-of-life ruby versions, as they become burden of adopt new features.
The compatibility policy of sass-embedded gem is that, at minimum it would target all MRI releases in "normal maintenance" status (see https://www.ruby-lang.org/en/downloads/branches/), plus the latest JRuby stable branch. When sass-embedded=1.70.0 was released, all MRI versions < 3.0 were end of life, 3.0 was in security maintenance and would be end of life in 2 months, and JRuby was at 9.4, which is MRI 3.1 compatible. Therefore, that release was targeting MRI 3.1.
Ruby 2.5 was never supported in any stable versions of sass-embedded. The very last version supporting ruby 2.6 was 1.58.3, which is missing lots of features and bug fixes. Specifically, there are also a few features added recently to make this middleman PR smaller.

An alternative is to still install sassc by default, and create a new option that allows user to opt-in with using sass-embedded. For reference, for Jekyll we went with this approach for jekyll-sass-converter 2.2.0, and then later dropped sassc completely in jekyll-sass-converter 3.0.0. jekyll 4.3 is locked to "jekyll-sass-converter", ">= 2.0", "< 4.0", so that user can still choose their preferred implementation by choosing between jekyll-sass-converter 2.x or 3.x in Gemfile.
I'm not recommending this option, because it's a lot of extra work supporting end-of-life software.

I would recommend having two renderers. They get enabled if the gem they depend on is present (there's other examples of this in the code where adding a templating engine not in the default gem spec will enable support).
https://github.com/middleman/middleman/blob/main/middleman-core/lib/middleman-core/core_extensions/rendering.rb#L9-L13
If the require throws (missing gem), the renderer will not enable.
The concept of "end of life" doesn't make a lot of sense for pieces of tooling like Middleman. Folks have 15 year old blogs running just fine and they shouldn't need to worry about upgrading ruby. Old code should continue to just work.
We can update the new project template to include sass-embedded for new projects and users who want to and can switch can add it to their gem file. We can also bump the minor version as a way to treat this as a new feature and encourage upgrades

authors: markets ntkme tdreyno tnir

repo: middleman/middleman


text:
refactor: remove ParseZone and parseZone

This removes ParseZone() and parseZone() as pointed by @miekg in #1059

Codecov Report

Merging #1099 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1099      +/-   ##
==========================================
- Coverage   55.61%   55.55%   -0.06%
==========================================
  Files          41       41
  Lines       10082    10067      -15
==========================================
- Hits         5607     5593      -14
+ Misses       3445     3444       -1
  Partials     1030     1030

Impacted Files
Coverage Δ

scan.go
82.46% <ø> (-0.38%)
:arrow_down:

server.go
70.71% <0.00%> (+0.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6737387...91a83c4. Read the comment docs.

authors: codecov-io taciomcosta

repo: miekg/dns


text:
Add support for the Proposed DNS XPF RR

As described in this RFC draft (IETF Draft), the DNS XPF RR implementation adds meta information about the original destination and source to the DNS request. Something that I made a decision on was the Record Type, I went with the option code that Wireshark is currently mapping the record to (65422). This would need updating if/when the RFC goes through.
Another reference implementation that was used as inspiration was from the PowerDNS dnsdist feature that was added.
Adding this here as I'd like to get this feature supported in CoreDNS eventually.
Feedback appreciated!

Codecov Report

Merging #964 into master will decrease coverage by 0.52%.
The diff coverage is 9.56%.

@@            Coverage Diff             @@
##           master     #964      +/-   ##
==========================================
- Coverage   55.21%   54.69%   -0.53%
==========================================
  Files          42       43       +1
  Lines        9970    10084     +114
==========================================
+ Hits         5505     5515      +10
- Misses       3442     3539      +97
- Partials     1023     1030       +7

Impacted Files
Coverage Δ

types.go
73.45% <ø> (ø)
:arrow_up:

scan_rr.go
66.33% <0%> (ø)
:arrow_up:

zmsg.go
39.65% <25%> (-0.1%)
:arrow_down:

msg_helpers.go
50.31% <5%> (-6.49%)
:arrow_down:

ztypes.go
45.9% <50%> (+0.02%)
:arrow_up:

xpf.go
7.89% <7.89%> (ø)

server.go
65.82% <0%> (-0.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b8e6b...98935c0. Read the comment docs.

The only thing weird in this record are the address fields, this can potentially just be split into two members, depending on the value of family:
IPVersion uint8
Protocol uint8
SrcA net.ip `dns:"a"`
SrcAAAA net.ip `dns:"aaaa"`
DstA net.ip `dns:"a"`
DstAAAA net.ip `dns:"aaaa"`
SrcPort uint16
DstPort uint16

This also means the addresses can be assigned similar to A and AAAA records

Alright, given the situation of this type not having an official RRType Code, my option for integrating this into any external code for the time being is via the PrivateRR type, until such a time that the draft is accepted, or another proposal with a similar feature set is introduced.
Just some context on what I am hoping to achieve with this... I'm mostly looking to get this functionality added to the Coredns via either the Forward plugin (since I can control dropping the record) or a custom plugin. I've got a use case that requires information about the client request being passed to the upstream DNS server.
If you have any other suggestion in regards to direction with this that'd be great, otherwise, I'll close this PR for now.

Ok sgtm
adding a new record should not require any code changes unless you need a) presentation format b) extra member fields in an easy way
CoreDNS will just work because it will treat it as a RFC3597  - unknown RR, which will deliver the payload as base64 encoded bytes

authors: codecov-io miekg tomsanbear


text:
Please add React 17 as a peer dependency

Can you please add React 17 as an option for your peer dependencies?
Something like this maybe
"react": "^16.0.0 || ^17.0.0",

or
"react": "16 - 17",

https://semver.npmjs.com/

thanks. i added support for 17 now

authors: Tobbe mifi

repo: mifi/react-lottie-player


text:
Mouse events seem to "jump"

Hard to describe, but things seem to jump, even if the event does not seem to indicate this.

That was for a different project :-)

repo: migueldeicaza/SwiftGodot


text:
Implement codegen for methods using withArgPointers

This change set refactors methodGen() to generate calls to gi.object_method_bind_ptrcall that avoids deeply nested uses of withUnsafePointer(to:) in favor of a generated helper function that looks like this:
        func withArgPointers(
            _ p0: UnsafeRawPointer?, _ p1: UnsafeRawPointer?, _ p2: UnsafeRawPointer?, _ p3: UnsafeRawPointer?, _ p4: UnsafeRawPointer?
        ) {
            var _args: [UnsafeRawPointer?] = [
                p0, p1, p2, p3, p4
            ]
            gi.object_method_bind_ptrcall (Input.method_get_vector, UnsafeMutableRawPointer (mutating: shared.handle), &_args, &_result)
        }

or this variadic version:
        func withArgPointers(_ args: UnsafeRawPointer?...) {
            var _args = args
            gi.object_method_bind_ptrcall (Input.method_get_vector, UnsafeMutableRawPointer (mutating: shared.handle), &_args, &_result)
        }

Both versions are slightly faster than the original codegen; the variadic version appears to be slightly faster.
The new codegen appears to build faster in release mode too.
Consider this a work-in-progress. It passes all tests, but needs more cleanup. Inlining attributes may also help too.

Thank you for this incredible contribution!
Per our discussion, of wanting to keep the #if for a little longer, I merged the patch with the command line to skip the last patch - I believe I got it right, and that there was no functionality lost.   Let me know if I missed something.

It's easy enough to restore via cherry pick, when you're ready.

authors: migueldeicaza pcbeard


text:
Mouse in X10 mode is sending wrong coordinates

That one or the other one, I can not remember, but one is failing.

Fixed, the state was not properly reset.

repo: migueldeicaza/SwiftTerm


text:
Check pieces before sending to other peers in swarm

The issue here is that whenever acceptSignedPost is changed to become stricter the old posts (which have been previously accepted into torrents) may fail to pass in the new test. This causes peers to become massively banned by other peers because they try to send invalid pieces.

@Erkan-Yilmaz not related. in fact you noticed a limitation: you cannot RT a promoted post ;-)

the same issue for the favorite posts?
I saw this error also on trying to retwist some posts on the profile review.

repo: miguelfreitas/twister-core


text:
Suggestion for Deploying Application Updates section

I successfully deployed microblog on my Raspberry Pi in chapter 17. It worked on the first try. Thanks for the great instructions.
After I finished chapter 23 I followed the instructions in the Deploying Application Updates section. At flask db upgrade I encountered an error because all the dependencies weren't installed. It was easy enough to fix, but you might want to add pip install -r requirements.txt in the instructions before flask db upgrade.

Closing as this does not apply to the new edition of this tutorial.

authors: SSteve miguelgrinberg

repo: miguelgrinberg/microblog


text:
Last read timestamp

Describe your suggested feature
Show the last time a manga was read in it's menu. This is usefull when picking up manga that you've stopped reading. This data should already be available as sorting by last read is possible.
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.16.5.
[X] I will fill out all of the requested information in this form.

I actually thought something similar but slightly different: A button in the entry's overflow menu to toggle the displayed date on chapters between release (current) and last read

That would lead to confusion, unread chapters would show no date.
Same way as the scanlator field may or may not be displayed depending on its presence on the chapter

Being able to see last read date of each chapter would be good and should be possible somewhere within the app anyway, but I'm not sure if it being in the chapters view, and implemented as a toggle between last read/release date is the best way to do this.

People might want to use relative times (...)

They are objectively wrong 😛

People might want to see both dates when available

Screen real-estate. Might work on a high DPI tablet, but most use tall phones where that wouldn't fly.

People might want to see no dates at all

Not an option currently, but could be with this implementation. Instead of the overflow menu make it a radio button under the entry's Filter Menu > Display

The original feature request is about showing the last read date of the series in Library tab or while doing actions on a Library/Search entry, so talking about full history feature in Chapters view here seems pointless
I made a separate issue about full history view #1139

The original feature request is about showing the last read date of the series in Library tab or while doing actions on a Library/Search entry, so talking about full history feature in Chapters view here seems pointless
I made a separate issue about full history view #1139

This issue is actually about showing it in the chapter view, this is what I implied with the "menu of the manga" as I wasn't aware of the terminology.

My suggestion is that the 4 states mentioned by @mm12 should be implemented and the last read time should be on the lower right corner of the chapter bar while the release time should be kept in the lower left corner for consistency.

You know what, I was gonna make a case against it saying there's not enough space, but after checking a few entries on my phone it might not be that bad.
Other than the fact that it's a single line, there's no right alignment, adding a third element for the date should fit if the scanlator value isn't obscenely large, so it'd probably be better as the second element instead,
Things like scanlator collabs already cause the field to trim on their own, with the single date

authors: Archimedes9500 BrutuZ TimoNotThy

repo: mihonapp/mihon


text:
Navigation (Usage Question)

Hi,
How do you navigate back to the high-level "Project View" from within a single diagram? I do this by re-opening the project JSON file.
(I apologize, this doesn't seem like the right forum. Where is the best place to make questions about Threat Dragon usage?)
Best,
Michael

Hello @statueofmike - sorry for the slow response, on holiday in Devon with intermittent network.
Within the diagram you can return to the project view page by closing the diagram (the second button of the seven diagram buttons, marked with a cross). I agree it is not intuitive, and this is a question that has come up a couple of times now, so I will add a FAQ to :
https://owasp.org/www-project-threat-dragon/#div-faqs
Cheers,
Jon

authors: jgadsden statueofmike

repo: mike-goodwin/owasp-threat-dragon


text:
Need any help?

I have Nucleo F207 board.
The crate is written mostly for F205 so perhaps I could help testing, verifying the examples (not all of them I can build) for F207.
I was not able to build anything on previous machine (cargo cache issue?), but today almost all went good.

I have an F207 Nucleo as well. I do not get the crate or examples to build at the moment though. @mike7b4 what is the status of the crate?

I wonder why the crate stm32f2-0.14.0 itself builds fine for booth 215 and 217,
eg cargo b --features=stm32f217, but when I'm trying to build stm32f2xx-hal with
cargo b --features=stm32f207,rt,usb_fs,sdio I see

error: Package stm32f2xx-hal v0.10.0 (/.../stm32f2xx-hal) does not have the feature stm32f207

It builds only for 205 for the moment despite the fact that src/lib.rs imports all 4 variants.

I have added rudimentary support for stm32f207 feature, but I don't want to PR yet. This crate was forked from the stm32f4xx-hal crate, and a lot of its modules and features don't really make sense yet for F2 series. A little bit of "housekeeping" is needed to remove any vestiges of F4 related stuff and implement proper abstractions relevant to the F2 series.
I think I'd also try to add a feature for f205 and f207 in the stm32f2 crate. Aliases for the f215 and f217 features are fine as well, I just found it confusing at first to figure out that I need the f217 feature for my f207; the crate does have support for it.


text:
Can't post binary to multipart requests

request tries to concatenate text to the body part of a multipart request, which stringifies the buffer object. Instead, it should write the buffer to the socket as is.

Would love to deploy this pretty soon. What's in the way to getting this merged?

this looks great but i'd really like a test for it.
if you don't write one in the next few days then i probably will.

i'm going to merge it, hopefully someone will write a test or tell me if it's broken, but it's better than not having it.

agreed.

also, i won't push a new release to npm until someone verifies that this works and doesn't break the old API.

authors: joemccann kkaefer mikeal

repo: mikeal/request


text:
added check to see if curr is still valid.

Emacs temp files can cause curr to be null during the check. This just adds an extra check before assuming it exists.

I just published 0.14.0.

authors: finnp ripter

repo: mikeal/watch


text:
Base Path ignored in some Locations

Hi,
at some positions the base path is not considered.
I've set the basePath: '/umami' in next.config.js.
The umami dashboard is served and works for 90% of the functionality when I go to example.com/umami/.
I'm no javascript developer, so I don't know how to fix most of the problems, but I'll point out the positions, where I think the error lies, if I was able to find it.
The following functionalities do not work:

Tracking code omits the base path, i.e. only shows: <script async defer data-website-id="omitted" src="https://example.com/umami.js"></script>. Code which probably has to be adapted. When I fixed the tracking code manually, it worked fine.
Sharing code also misses base path. Code position. Also unrelated, but in the same file, why is TrackingCodeForm exported and not ShareUrlForm? (Sorry for my confusion, I have really no idea how javascript works).
When fixing the share URL manually and directing my browser to it, the site stays blank. My browser displays a CORS error. I think this is also due to a missing base path, since it tries to load https://www.example.com/api/share/omitted/ (instead of https://www.example.com/umami/api/share/omitted/), which fails because of the CORS error. But I can't point you to the wrong code, since I don't really understand how the routing system works.
Favicon. Maybe here?

For completeness, I serve umami from a docker container and use nginx as proxy by including
server {
    server_name example.com www.example.com
    ...
    location /umami/ {
        proxy_pass http://127.0.0.1:3210/;
    }
    ...
}

This is not a really high priority issue, since tracking already works, when fixing the URL manually.
Thanks for this project.

Thanks for the detail report. I think we should be able to fix these issues,

Fixed in https://github.com/mikecao/umami/pull/431

Fixed in https://github.com/mikecao/umami/pull/431

authors: Lucas-Steinmann mikecao

repo: mikecao/umami