text:
Fixed macos version used in test workflow for py36/37

No review needed.

coverage: 37.115%. remained the same
when pulling 4daef53d22f4f2e934d3744e279de25c0ec219fd on andy/fix-macos-py3637
into 4e804331b71a9080aaef2d802f0e9a5dd0c91b18 on master.


text:
Bugs encountered in Preview 1.0

What happened?
Items:

Potions occasionally do not heal past a certain amount of health. The potion will be consumed but you can't heal over for example 25% of Max HP. You'll gain nothing. Healing spells work.

Sometimes the animation for drinking a potion plays without something in your hand. No potion will be consumed but you don't heal either.

Controller:

Cannot charge soul stones in Inventory, this can be fixed by editing the controlmap.txt in Tsukiro\mods\The Ultimate Control Scheme\Interface\Controls\PC. Changing '!0,Shout' to '0x0200' for ChargeItem fixes it. It should look like this:
// Inventory ChargeItem    !0,Wait    !0,Wait    0x0200        0    0    0    0x8

Sprinting doesn't work. Changing the key bind from R1/RB to anything else doesn't solve this either.

Gameplay:

Sekiro Deathblow stays on the enemy for multiple hits, is that intended?

Fast Travel sometimes bugs out on sign posts. You cannot fast travel anymore.

Reading a book or letters sometimes flicks around the camera.

While they do no damage, walking on bones accelerates you with the force of physics.

Misc:

Katana, when nude, still wears underwear. Was that intended?

My Specs:
DxDiag.txt
Modlist version
Preview 1.0

Cannot reproduce any of this, signs are fixed, bones are just bethesda physics, camera is fixed, Katana should now be nude

source: gharchive/issue

authors: Miss-Corruption zhongjiedong

repo: zhongjiedong/Tsukiro

license: MIT

license_type: permissive

license_source: github-api


text:
遇到后台返回的data为null时怎么解决啊？

后台返回数据有时没有数据的时候为null，但是rxjava2不逊于onNext为null，直接就到onError报NullPointException了，这时候该怎么解决呢？

我在你的HandleFuc里面返回下面这样:
return tApiResult.getData()== null ? Optional.ofNullable(tApiResult.getData()).orElse(null) : tApiResult.getData();
这么修改之后还是一样的会报空指针。麻烦请问应该怎么返回null值呢？

处理这个比较麻烦你可以重写callback或者订阅，当出现空指针也让他走成功。

authors: eternallyjie zhou-you

repo: zhou-you/RxEasyHttp

license_source: bigquery


text:
预测结果一直过拟合

请问一下有遇到预测结果一直过拟合的情况吗，是怎么处理的，可以请教一下吗，谢谢

具体是哪个预测结果呢？

我也是一直过拟合，WTH和ETTh1预测效果并不好呀，求作者解答

有具体的实验结果吗

authors: MountVoom Youuung jhzmike zhouhaoyi


text:
Office快捷方式问题

我的office的快捷方式的目标路径是"C:\Program Files\Microsoft Office\root\Office16\WINWORD.EXE"，但在RX中是C:\Program Files (x86)\Microsoft Office\root\Office16\WINWORD.EXE，这个路径是错的，希望修复。

就像这样

此问题由Windows自作聪明导致，X86应用运行于X64系统上时，若访问Program Files，则会自动重定向至Program Files(x86)，快捷方式也是如此，因此它被强制重定向且无法更改。针对此问题，我已取消“首选32位应用程序”来尽可能确保在X64系统上以X64模式运行来解决此问题

6.0.1版本已发布


text:
Accessing web interface using Weaved on Raspberry Pi

Thanks for developing this awesome web interface.
I am using it on raspberry pi 2.
It works fine locally but if i try to access it remotely from weaved it would not connect to the aria2 port (it would show the web interface but is unable to connect to aria2, popping out an error in red bubble).
Has someone tried connecting it via weaved successfully?

hmm ... @Ritiek so it works when you directly connect to Rasberry pi (without weaved)? Maybe the aria2 RPC port is being blocked.

@ziahamza Yes, it works fine if i connect directly to pi but not when connecting with weaved. It pops out the red message 'unable to connect aria2 rpc port' when i open the web interface using weaved..
why is it unable to connect to aria2 rpc port when using weaved?

it could be that weaved is blocking the connection to aria2 RPC from the webui. The Aria2 RPC runs on port 6800 and webui connects to that url. check if: http://url_for_weaved:6800 returns a response

I can connect webui with hamachi + apache2. First install apache then clone aria-webui inside /var/www/. Find /etc/apache2/sites-available/000.default.conf, then i changed the root directory from /var/www/html to /var/www

Thanks for trying to help but it was something different in my case..
If connecting via weaved gives an https page so we have to change it back to http manually (if you get https page an alternate will be to select 'this app uses a web browser' when setting up weaved to no).
Also, we have to manually enter the local address (not just localhost but local ip that can be known by running ifconfig in terminal) and port of aria2 server in Settings > Connection Settings in webui (in my case, local ip is 192.168.82.103 and port is 6800).
Then it connects successfully.
So is it possible to change the default ip address and port of aria2 server in webui (instead of localhost and 6800) so we do not have to do it ourselves everytime we open webui using weaved?

EDIT:
Something is really weird idk. Tried running the web interface using weaved from outside my house (with settings i posted above) and it didn't worked and gave an error 'could not connect to aria2 server. trying again in 10s' and then later when i tried connecting it again using weaved inside my home network it works fine (with same settings posted above)..
I think its because when i feed the ip of my pi in connection settings in webui it works because that ip actually exists on my local network and works fine but not when i connect it from some other network.
BTW, i do not think this related but i use lighttpd and have files for for webui in /etc/www/html/aria/index.html and can open it on my local network using my pi's ip 192.168.82.103/aria/index.html.
Error when running weaved from outside home network:

Any ideas?

@Ritiek are you using apache? I don't know how weaved works, it seems tunneled because had a port to connect. Maybe if tunneled it needs http(s)secure connection. Thats maybe why your connection dropped. You must setting your router,
http://readwrite.com/2014/06/27/raspberry-pi-web-server-website-hosting/
Hamachi is something different, hamachi had virtual physical connection called ham0 so it's just like local connection. Better than weaved if we have 5 clients. I still using weaved for Android ssh.
Sorry for my bad english.

note: My local address is 192.168.5.xxx

@vanbwodonk i use lighttpd for web servers. i do not think the problem is about tunneled connection (unless we want to use https/ssl) or lighttpd.
I am now able to connect to aria2 server from webui by assigning port 6800 on weaved and entering the generated url and port by weaved in the connection settings here http://ziahamza.github.io/webui-aria2/ , then it works ok.
I was hoping for a direct url generated by weaved which would work for web browsers and automatically connect to aria2 server on my pi and would let me do stuff.. anyways, this is not a bad idea too :)
Thanks for all the support everyone :D

authors: Ritiek vanbwodonk ziahamza

license: mit


text:
Add clang-tidy run on zig sources, minor CMake improvements

Upgrade to >= CMake 3.1 (needed for Threads library and other modern CMake features).
Use CMAKE_CURRENT_(SOURCE|BINARY)_DIR instead of CMAKE_(SOURCE|BINARY)_DIR.
Run clang-tidy on Zig C++ sources. (Technically a CMake 3.6 feature but not upgrading minimum CMake just for this.) Can be enabled/disabled with ENABLE_CLANG_TIDY option. Added .clang-tidy file as config for this analysis.

Thanks for the PR. Did you find anything worth fixing with clang-tidy?

There were a lot of warnings so I was going to go through them for another PR.

Actually took a look now and see a lot of potential memory leaks in the analyze.cpp file.

Is there a reason the struct in the compiler don't have destructors (i.e. ZigList).

valgrind confirms this:
$ valgrind --track-origins=yes --leak-check=full ./zig build --build-file ../build.zig --prefix $PWD/stage2 install
==7156== Memcheck, a memory error detector
==7156== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==7156== Using Valgrind-3.13.0 and LibVEX; rerun with -h for copyright info
==7156== Command: ./zig build --build-file ../build.zig --prefix /home/ihier/proj/zig/zig/build/stage2 install
==7156==
==7156== Invalid read of size 1
==7156==    at 0xFE4DD5: os_path_join(Buf*, Buf*, Buf*) (os.cpp:229)
==7156==    by 0xFE097F: test_zig_install_prefix(Buf*, Buf*) (main.cpp:160)
==7156==    by 0xFE0AD3: find_zig_lib_dir(Buf*) (main.cpp:193)
==7156==    by 0xFE0B0D: resolve_zig_lib_dir() (main.cpp:207)
==7156==    by 0xFE1324: main (main.cpp:360)
==7156==  Address 0xa670f8f is 1 bytes before a block of size 8 alloc'd
==7156==    at 0x6421ABF: malloc (vg_replace_malloc.c:298)
==7156==    by 0x6423E04: realloc (vg_replace_malloc.c:785)
==7156==    by 0xF5532B: char* reallocate_nonzero<char>(char*, unsigned long, unsigned long) (util.hpp:107)
==7156==    by 0xF56CC8: ZigList<char>::ensure_capacity(unsigned long) (list.hpp:75)
==7156==    by 0xF55A38: ZigList<char>::resize(unsigned long) (list.hpp:58)
==7156==    by 0xFE434F: buf_init_from_mem(Buf*, char const*, unsigned long) (buffer.hpp:61)
==7156==    by 0xFE440D: buf_init_from_buf(Buf*, Buf*) (buffer.hpp:71)
==7156==    by 0xFE4DB2: os_path_join(Buf*, Buf*, Buf*) (os.cpp:228)
==7156==    by 0xFE097F: test_zig_install_prefix(Buf*, Buf*) (main.cpp:160)
==7156==    by 0xFE0AD3: find_zig_lib_dir(Buf*) (main.cpp:193)
==7156==    by 0xFE0B0D: resolve_zig_lib_dir() (main.cpp:207)
==7156==    by 0xFE1324: main (main.cpp:360)
==7156==
Unable to find zig lib directory
==7156==
==7156== HEAP SUMMARY:
==7156==     in use at exit: 96,712 bytes in 1,440 blocks
==7156==   total heap usage: 1,762 allocs, 322 frees, 311,658 bytes allocated
==7156==
==7156== 64 bytes in 8 blocks are definitely lost in loss record 1,206 of 1,370
==7156==    at 0x6421ABF: malloc (vg_replace_malloc.c:298)
==7156==    by 0x6423E04: realloc (vg_replace_malloc.c:785)
==7156==    by 0xF5532B: char* reallocate_nonzero<char>(char*, unsigned long, unsigned long) (util.hpp:107)
==7156==    by 0xF56CC8: ZigList<char>::ensure_capacity(unsigned long) (list.hpp:75)
==7156==    by 0xF55A38: ZigList<char>::resize(unsigned long) (list.hpp:58)
==7156==    by 0xFE046D: buf_init_from_mem(Buf*, char const*, unsigned long) (buffer.hpp:61)
==7156==    by 0xFE04E7: buf_init_from_str(Buf*, char const*) (buffer.hpp:67)
==7156==    by 0xFE085D: test_zig_install_prefix(Buf*, Buf*) (main.cpp:144)
==7156==    by 0xFE0AD3: find_zig_lib_dir(Buf*) (main.cpp:193)
==7156==    by 0xFE0B0D: resolve_zig_lib_dir() (main.cpp:207)
==7156==    by 0xFE1324: main (main.cpp:360)
==7156==
==7156== 64 bytes in 8 blocks are definitely lost in loss record 1,207 of 1,370
==7156==    at 0x6421ABF: malloc (vg_replace_malloc.c:298)
==7156==    by 0x6423E04: realloc (vg_replace_malloc.c:785)
==7156==    by 0xF5532B: char* reallocate_nonzero<char>(char*, unsigned long, unsigned long) (util.hpp:107)
==7156==    by 0xF56CC8: ZigList<char>::ensure_capacity(unsigned long) (list.hpp:75)
==7156==    by 0xF55A38: ZigList<char>::resize(unsigned long) (list.hpp:58)
==7156==    by 0xFE046D: buf_init_from_mem(Buf*, char const*, unsigned long) (buffer.hpp:61)
==7156==    by 0xFE04E7: buf_init_from_str(Buf*, char const*) (buffer.hpp:67)
==7156==    by 0xFE0888: test_zig_install_prefix(Buf*, Buf*) (main.cpp:147)
==7156==    by 0xFE0AD3: find_zig_lib_dir(Buf*) (main.cpp:193)
==7156==    by 0xFE0B0D: resolve_zig_lib_dir() (main.cpp:207)
==7156==    by 0xFE1324: main (main.cpp:360)
==7156==
==7156== 64 bytes in 8 blocks are definitely lost in loss record 1,208 of 1,370
==7156==    at 0x6421ABF: malloc (vg_replace_malloc.c:298)
==7156==    by 0x6423E04: realloc (vg_replace_malloc.c:785)
==7156==    by 0xF5532B: char* reallocate_nonzero<char>(char*, unsigned long, unsigned long) (util.hpp:107)
==7156==    by 0xF56CC8: ZigList<char>::ensure_capacity(unsigned long) (list.hpp:75)
==7156==    by 0xF55A38: ZigList<char>::resize(unsigned long) (list.hpp:58)
==7156==    by 0xFE046D: buf_init_from_mem(Buf*, char const*, unsigned long) (buffer.hpp:61)
==7156==    by 0xFE04E7: buf_init_from_str(Buf*, char const*) (buffer.hpp:67)
==7156==    by 0xFE08B3: test_zig_install_prefix(Buf*, Buf*) (main.cpp:150)
==7156==    by 0xFE0AD3: find_zig_lib_dir(Buf*) (main.cpp:193)
==7156==    by 0xFE0B0D: resolve_zig_lib_dir() (main.cpp:207)
==7156==    by 0xFE1324: main (main.cpp:360)
==7156==
==7156== 78 bytes in 1 blocks are definitely lost in loss record 1,216 of 1,370
==7156==    at 0x6423DAF: realloc (vg_replace_malloc.c:785)
==7156==    by 0xF5532B: char* reallocate_nonzero<char>(char*, unsigned long, unsigned long) (util.hpp:107)
==7156==    by 0xF56CC8: ZigList<char>::ensure_capacity(unsigned long) (list.hpp:75)
==7156==    by 0xF55A38: ZigList<char>::resize(unsigned long) (list.hpp:58)
==7156==    by 0xFE4279: buf_resize(Buf*, unsigned long) (buffer.hpp:41)
==7156==    by 0xFE46B4: buf_append_mem(Buf*, char const*, unsigned long) (buffer.hpp:106)
==7156==    by 0xFE4771: buf_append_buf(Buf*, Buf*) (buffer.hpp:118)
==7156==    by 0xFE4E10: os_path_join(Buf*, Buf*, Buf*) (os.cpp:232)
==7156==    by 0xFE09B9: test_zig_install_prefix(Buf*, Buf*) (main.cpp:162)
==7156==    by 0xFE0AD3: find_zig_lib_dir(Buf*) (main.cpp:193)
==7156==    by 0xFE0B0D: resolve_zig_lib_dir() (main.cpp:207)
==7156==    by 0xFE1324: main (main.cpp:360)
==7156==
==7156== 78 bytes in 1 blocks are definitely lost in loss record 1,217 of 1,370
==7156==    at 0x6423DAF: realloc (vg_replace_malloc.c:785)
==7156==    by 0xF5532B: char* reallocate_nonzero<char>(char*, unsigned long, unsigned long) (util.hpp:107)
==7156==    by 0xF56CC8: ZigList<char>::ensure_capacity(unsigned long) (list.hpp:75)
==7156==    by 0xF55A38: ZigList<char>::resize(unsigned long) (list.hpp:58)
==7156==    by 0xFE4279: buf_resize(Buf*, unsigned long) (buffer.hpp:41)
==7156==    by 0xFE46B4: buf_append_mem(Buf*, char const*, unsigned long) (buffer.hpp:106)
==7156==    by 0xFE4771: buf_append_buf(Buf*, Buf*) (buffer.hpp:118)
==7156==    by 0xFE4E10: os_path_join(Buf*, Buf*, Buf*) (os.cpp:232)
==7156==    by 0xFE09D6: test_zig_install_prefix(Buf*, Buf*) (main.cpp:163)
==7156==    by 0xFE0AD3: find_zig_lib_dir(Buf*) (main.cpp:193)
==7156==    by 0xFE0B0D: resolve_zig_lib_dir() (main.cpp:207)
==7156==    by 0xFE1324: main (main.cpp:360)
==7156==
==7156== 106 bytes in 2 blocks are definitely lost in loss record 1,349 of 1,370
==7156==    at 0x6423DAF: realloc (vg_replace_malloc.c:785)
==7156==    by 0xF5532B: char* reallocate_nonzero<char>(char*, unsigned long, unsigned long) (util.hpp:107)
==7156==    by 0xF56CC8: ZigList<char>::ensure_capacity(unsigned long) (list.hpp:75)
==7156==    by 0xF55A38: ZigList<char>::resize(unsigned long) (list.hpp:58)
==7156==    by 0xFE4279: buf_resize(Buf*, unsigned long) (buffer.hpp:41)
==7156==    by 0xFE46B4: buf_append_mem(Buf*, char const*, unsigned long) (buffer.hpp:106)
==7156==    by 0xFE4771: buf_append_buf(Buf*, Buf*) (buffer.hpp:118)
==7156==    by 0xFE4E10: os_path_join(Buf*, Buf*, Buf*) (os.cpp:232)
==7156==    by 0xFE097F: test_zig_install_prefix(Buf*, Buf*) (main.cpp:160)
==7156==    by 0xFE0AD3: find_zig_lib_dir(Buf*) (main.cpp:193)
==7156==    by 0xFE0B0D: resolve_zig_lib_dir() (main.cpp:207)
==7156==    by 0xFE1324: main (main.cpp:360)
==7156==
==7156== 134 bytes in 3 blocks are definitely lost in loss record 1,353 of 1,370
==7156==    at 0x6423DAF: realloc (vg_replace_malloc.c:785)
==7156==    by 0xF5532B: char* reallocate_nonzero<char>(char*, unsigned long, unsigned long) (util.hpp:107)
==7156==    by 0xF56CC8: ZigList<char>::ensure_capacity(unsigned long) (list.hpp:75)
==7156==    by 0xF55A38: ZigList<char>::resize(unsigned long) (list.hpp:58)
==7156==    by 0xFE4279: buf_resize(Buf*, unsigned long) (buffer.hpp:41)
==7156==    by 0xFE46B4: buf_append_mem(Buf*, char const*, unsigned long) (buffer.hpp:106)
==7156==    by 0xFE4771: buf_append_buf(Buf*, Buf*) (buffer.hpp:118)
==7156==    by 0xFE4E10: os_path_join(Buf*, Buf*, Buf*) (os.cpp:232)
==7156==    by 0xFE099C: test_zig_install_prefix(Buf*, Buf*) (main.cpp:161)
==7156==    by 0xFE0AD3: find_zig_lib_dir(Buf*) (main.cpp:193)
==7156==    by 0xFE0B0D: resolve_zig_lib_dir() (main.cpp:207)
==7156==    by 0xFE1324: main (main.cpp:360)
==7156==
==7156== 178 bytes in 6 blocks are definitely lost in loss record 1,354 of 1,370
==7156==    at 0x6421ABF: malloc (vg_replace_malloc.c:298)
==7156==    by 0x6423E04: realloc (vg_replace_malloc.c:785)
==7156==    by 0xF5532B: char* reallocate_nonzero<char>(char*, unsigned long, unsigned long) (util.hpp:107)
==7156==    by 0xF56CC8: ZigList<char>::ensure_capacity(unsigned long) (list.hpp:75)
==7156==    by 0xF55A38: ZigList<char>::resize(unsigned long) (list.hpp:58)
==7156==    by 0xFE434F: buf_init_from_mem(Buf*, char const*, unsigned long) (buffer.hpp:61)
==7156==    by 0xFE440D: buf_init_from_buf(Buf*, Buf*) (buffer.hpp:71)
==7156==    by 0xFE4DB2: os_path_join(Buf*, Buf*, Buf*) (os.cpp:228)
==7156==    by 0xFE097F: test_zig_install_prefix(Buf*, Buf*) (main.cpp:160)
==7156==    by 0xFE0AD3: find_zig_lib_dir(Buf*) (main.cpp:193)
==7156==    by 0xFE0B0D: resolve_zig_lib_dir() (main.cpp:207)
==7156==    by 0xFE1324: main (main.cpp:360)
==7156==
==7156== 224 bytes in 8 blocks are definitely lost in loss record 1,359 of 1,370
==7156==    at 0x6421ABF: malloc (vg_replace_malloc.c:298)
==7156==    by 0x6423E04: realloc (vg_replace_malloc.c:785)
==7156==    by 0xF5532B: char* reallocate_nonzero<char>(char*, unsigned long, unsigned long) (util.hpp:107)
==7156==    by 0xF56CC8: ZigList<char>::ensure_capacity(unsigned long) (list.hpp:75)
==7156==    by 0xF55A38: ZigList<char>::resize(unsigned long) (list.hpp:58)
==7156==    by 0xFE046D: buf_init_from_mem(Buf*, char const*, unsigned long) (buffer.hpp:61)
==7156==    by 0xFE04E7: buf_init_from_str(Buf*, char const*) (buffer.hpp:67)
==7156==    by 0xFE08DE: test_zig_install_prefix(Buf*, Buf*) (main.cpp:153)
==7156==    by 0xFE0AD3: find_zig_lib_dir(Buf*) (main.cpp:193)
==7156==    by 0xFE0B0D: resolve_zig_lib_dir() (main.cpp:207)
==7156==    by 0xFE1324: main (main.cpp:360)
==7156==
==7156== 240 bytes in 5 blocks are definitely lost in loss record 1,360 of 1,370
==7156==    at 0x6421ABF: malloc (vg_replace_malloc.c:298)
==7156==    by 0x6423E04: realloc (vg_replace_malloc.c:785)
==7156==    by 0xF5532B: char* reallocate_nonzero<char>(char*, unsigned long, unsigned long) (util.hpp:107)
==7156==    by 0xF56CC8: ZigList<char>::ensure_capacity(unsigned long) (list.hpp:75)
==7156==    by 0xF55A38: ZigList<char>::resize(unsigned long) (list.hpp:58)
==7156==    by 0xFE434F: buf_init_from_mem(Buf*, char const*, unsigned long) (buffer.hpp:61)
==7156==    by 0xFE440D: buf_init_from_buf(Buf*, Buf*) (buffer.hpp:71)
==7156==    by 0xFE4DB2: os_path_join(Buf*, Buf*, Buf*) (os.cpp:228)
==7156==    by 0xFE099C: test_zig_install_prefix(Buf*, Buf*) (main.cpp:161)
==7156==    by 0xFE0AD3: find_zig_lib_dir(Buf*) (main.cpp:193)
==7156==    by 0xFE0B0D: resolve_zig_lib_dir() (main.cpp:207)
==7156==    by 0xFE1324: main (main.cpp:360)
==7156==
==7156== 346 bytes in 7 blocks are definitely lost in loss record 1,362 of 1,370
==7156==    at 0x6421ABF: malloc (vg_replace_malloc.c:298)
==7156==    by 0x6423E04: realloc (vg_replace_malloc.c:785)
==7156==    by 0xF5532B: char* reallocate_nonzero<char>(char*, unsigned long, unsigned long) (util.hpp:107)
==7156==    by 0xF56CC8: ZigList<char>::ensure_capacity(unsigned long) (list.hpp:75)
==7156==    by 0xF55A38: ZigList<char>::resize(unsigned long) (list.hpp:58)
==7156==    by 0xFE434F: buf_init_from_mem(Buf*, char const*, unsigned long) (buffer.hpp:61)
==7156==    by 0xFE440D: buf_init_from_buf(Buf*, Buf*) (buffer.hpp:71)
==7156==    by 0xFE4DB2: os_path_join(Buf*, Buf*, Buf*) (os.cpp:228)
==7156==    by 0xFE09B9: test_zig_install_prefix(Buf*, Buf*) (main.cpp:162)
==7156==    by 0xFE0AD3: find_zig_lib_dir(Buf*) (main.cpp:193)
==7156==    by 0xFE0B0D: resolve_zig_lib_dir() (main.cpp:207)
==7156==    by 0xFE1324: main (main.cpp:360)
==7156==
==7156== 396 bytes in 7 blocks are definitely lost in loss record 1,363 of 1,370
==7156==    at 0x6421ABF: malloc (vg_replace_malloc.c:298)
==7156==    by 0x6423E04: realloc (vg_replace_malloc.c:785)
==7156==    by 0xF5532B: char* reallocate_nonzero<char>(char*, unsigned long, unsigned long) (util.hpp:107)
==7156==    by 0xF56CC8: ZigList<char>::ensure_capacity(unsigned long) (list.hpp:75)
==7156==    by 0xF55A38: ZigList<char>::resize(unsigned long) (list.hpp:58)
==7156==    by 0xFE434F: buf_init_from_mem(Buf*, char const*, unsigned long) (buffer.hpp:61)
==7156==    by 0xFE440D: buf_init_from_buf(Buf*, Buf*) (buffer.hpp:71)
==7156==    by 0xFE4DB2: os_path_join(Buf*, Buf*, Buf*) (os.cpp:228)
==7156==    by 0xFE09D6: test_zig_install_prefix(Buf*, Buf*) (main.cpp:163)
==7156==    by 0xFE0AD3: find_zig_lib_dir(Buf*) (main.cpp:193)
==7156==    by 0xFE0B0D: resolve_zig_lib_dir() (main.cpp:207)
==7156==    by 0xFE1324: main (main.cpp:360)
==7156==
==7156== 438 (216 direct, 222 indirect) bytes in 9 blocks are definitely lost in loss record 1,364 of 1,370
==7156==    at 0x6423BA5: calloc (vg_replace_malloc.c:711)
==7156==    by 0xFE3E34: Buf* allocate<Buf>(unsigned long) (util.hpp:76)
==7156==    by 0xFE03EE: buf_alloc_fixed(unsigned long) (buffer.hpp:46)
==7156==    by 0xFE0419: buf_alloc() (buffer.hpp:52)
==7156==    by 0xFE0A92: find_zig_lib_dir(Buf*) (main.cpp:186)
==7156==    by 0xFE0B0D: resolve_zig_lib_dir() (main.cpp:207)
==7156==    by 0xFE1324: main (main.cpp:360)
==7156==
==7156== 515 bytes in 1 blocks are definitely lost in loss record 1,365 of 1,370
==7156==    at 0x6423DAF: realloc (vg_replace_malloc.c:785)
==7156==    by 0xF5532B: char* reallocate_nonzero<char>(char*, unsigned long, unsigned long) (util.hpp:107)
==7156==    by 0xF56CC8: ZigList<char>::ensure_capacity(unsigned long) (list.hpp:75)
==7156==    by 0xF55A38: ZigList<char>::resize(unsigned long) (list.hpp:58)
==7156==    by 0xFE4279: buf_resize(Buf*, unsigned long) (buffer.hpp:41)
==7156==    by 0xFE5E01: os_self_exe_path(Buf*) (os.cpp:1000)
==7156==    by 0xFE0A77: find_zig_lib_dir(Buf*) (main.cpp:182)
==7156==    by 0xFE0B0D: resolve_zig_lib_dir() (main.cpp:207)
==7156==    by 0xFE1324: main (main.cpp:360)
==7156==
==7156== LEAK SUMMARY:
==7156==    definitely lost: 2,703 bytes in 74 blocks
==7156==    indirectly lost: 222 bytes in 9 blocks
==7156==      possibly lost: 0 bytes in 0 blocks
==7156==    still reachable: 93,787 bytes in 1,357 blocks
==7156==         suppressed: 0 bytes in 0 blocks
==7156== Reachable blocks (those to which a pointer was found) are not shown.
==7156== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==7156==

The c++ compiler treats memory as one big ArenaAllocator. It all gets freed when the compiler exits and finishes the job. We don't bother freeing memory before this.
The self-hosted compiler has different requirements - it will be used as a long running process that will perform multiple services, for example compilation every time a file on disk changes, or implementing Language Server Protocol.

I see. OK let me see if I can change that analysis pass then.

I think this is largely a distraction.

The C++ codebase only has to build the self hosted compiler
See my specific comments on how clang-tidy is complaining about things that are actually quite intentional and helpful.
The marginal benefits of this static analysis is not worth the code review efforts to make sure these changes are helpful.
It's leading towards little changes that address possible symptoms and not resulting in actual bug fixes.

I appreciate your efforts @isaachier. I encourage you to redirect your energy toward more rewarding things. There are a lot of cool things to work on - feel free to hop on IRC if you want to discuss some ideas.

I definitely understand. It has been interesting exploring this code, but I agree this is more trouble than its worth.

source: gharchive/pull-request

authors: andrewrk isaachier

repo: zig-lang/zig


text:
Set cursor surface

Context
In other DE, the cursor's appearance is changed when move cursor on view such as resize cursor. But zen can't.
Summary
Listening wlr_seat's request_set_cursor event.
How to check behavior

start zen with -s option (weston-dnd is recommended)
move the cursor to corners of view or object in view
cursor's appearance will be changed

I'll look into it now.
First, I want to ask you some current behavior.

Will you correct cursor hotspot later? If so, it's ok.
The cursor will not change in xwayland app, is this what you exepcted? I guess we should implement both in the same PR.

fix hotspot issue (#100) is already fixed, but it will be other PR.
I forgot to fix

I forgot to fix

ok, let me know when fixed. I'll look into this then.

Regarding this, please leave issue, and link to this PR.

Do you forget this?

I fixed, but forgot to push…

repo: zigen-project/zen


text:
Framebuffer support

Thanks for creating this library, I really like the simplicity of it.
I added functionality I needed for creating framebuffers. Seems to work. What do you think?

Thanks!

repo: ziglibs/zgl


text:
Remove alignment specifier on namedBufferData.

The requirement of items being 1 byte aligned in namedBufferData prevents usage of types that have higher alignment. Lets remove that requirement since its not one enforced by OpenGL. https://registry.khronos.org/OpenGL-Refpages/gl4/html/glBufferData.xhtml

There are no types with a smaller alignment than 1 that can be passed.
Where does this requirement come from?

My use case is for an element buffer, where I want to store a list of u32 indicies. A u32 does not have 1 byte alignment, it has a 4 byte alignment.
quad_indicies = try std.ArrayList(u32).initCapacity(allocator, quad_count * 6);
...
element_buffer = gl.genBuffer();
element_buffer.bind(.element_array_buffer);
element_buffer.data(u32, self.quad_indicies.items, .static_draw);

Or maybe I got it backwards, its the slice that has the 1 byte alignment requirement, which I dont understand. A pointer would be 8 byte aligned on your typical x86 64 cpu.

My use case is for an element buffer, where I want to store a list of u32 indicies. A u32 does not have 1 byte alignment, it has a 4 byte alignment.

Yes, and a 4-byte alignment is also a valid value for a 1-byte alignment. As 4 is always aligned to 1 (as every other value is). align(1) is basically "i don't care about alignment"

align(1) is basically "i don't care about alignment"
But if you don't care about alignment, let compiler handle it?

I tried to repro my issue where the zig compiler complained about it. I could not. Not sure what I did before but must have been unrelated to the alignment.

But if you don't care about alignment, let compiler handle it?

Compiler cares, alignof(u32) is 4, not 1. So if i don't make it align(1), you could not pass a [*]align(2) u32 in the function. It's correct as-is and i will not change it unless you find a reproducible problem.

you could not pass a [*]align(2) u32 in the function.

But that's a good thing? Feels like a proper foot gun to allow that?
By the way, thanks for the library, opengl becomes nicer this way. (Although the zls tooling get fooled by it.)

But that's a good thing? Feels like a proper foot gun to allow that?

OpenGL allows it, so i allow it. There is no footgun included.


text:
Extension causes high cpu load

Issue Type: Performance
Extension Name: html-css-class-completion
Extension Version: 1.18.0
OS Version: Windows_NT x64 10.0.17134
VSCode version: 1.32.0

:warning: Make sure to attach this file from your home-directory: C:\Users\T2C DEVELOPER\Zignd.html-css-class-completion-unresponsive.cpuprofile.txt :warning:
Find more details here: https://github.com/Microsoft/vscode/wiki/Explain:-extension-causes-high-cpu-load

Duplicate of #155. Also, it's missing the cpuprofile.txt.

repo: zignd/HTML-CSS-Class-Completion


text:
Add Philips sml001 motion sensor quirk

Adds the sml001 motion sensor quirk, which exposes motion sensor sensitivity settings. Basically a copy of sml002 but with the correct endpoints for this device. SML001 is the indoor motion sensor.
{
  "node_descriptor": "NodeDescriptor(byte1=2, byte2=64, mac_capability_flags=128, manufacturer_code=4107, maximum_buffer_size=89, maximum_incoming_transfer_size=63, server_mask=0, maximum_outgoing_transfer_size=63, descriptor_capability_field=0)",
  "endpoints": {
    "1": {
      "profile_id": 49246,
      "device_type": "0x0850",
      "in_clusters": [
        "0x0000"
      ],
      "out_clusters": [
        "0x0000",
        "0x0003",
        "0x0004",
        "0x0005",
        "0x0006",
        "0x0008",
        "0x0300"
      ]
    },
    "2": {
      "profile_id": 260,
      "device_type": "0x0107",
      "in_clusters": [
        "0x0000",
        "0x0001",
        "0x0003",
        "0x0400",
        "0x0402",
        "0x0406"
      ],
      "out_clusters": [
        "0x0019"
      ]
    }
  },
  "manufacturer": "Philips",
  "model": "SML001",
  "class": "zhaquirks.philips.sml001.PhilipsSML001"
}

Pull Request Test Coverage Report for Build 359895884

13 of 13 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 79.142%

Totals

Change from base Build 358165274:
0.08%

Covered Lines:
2637

Relevant Lines:
3332

💛  - Coveralls

repo: zigpy/zha-device-handlers


text:
Updating to new (breaking) Wasmtime API

Wasmtime is getting new API rolled out: https://github.com/bytecodealliance/wasmtime/pull/2897 It might be a good idea to refocus the efforts at migrating to it since it's breaking and the old one will not be supported any longer.
cc @Luukdegram

This is happening: https://github.com/bytecodealliance/rfcs/pull/11

Subscribed myself to the tickets, hoping to update wasmtime-zig to reflect the API changes swiftly.

Seems it was just merged 🎉  will check soon what needs to be done on our side.

fyi: I started giving this a try, targeting wasmtime 0.37.0.
My time to work on this is limited, so don't expect results tomorrow :) Will open a WIP PR as soon as I have some first results.

authors: Luukdegram jedisct1 kubkon voigt

repo: zigwasm/wasmtime-zig


text:
Tiny cosmetic fixes

Thanks a lot for this project! I've just started using it and decided to contribute some tiny fixes:

Fix minor spelling typos
Format Markdown docs and HTML example pages

Hey thanks for this! I value your contribution! Sorry for not reacting earlier, I was completely maxed out with work. I'll try to find out if your patches apply cleanly....

Reopening, as this seems valuable

Oh no, it's gone. SORRY!!!!

authors: renerocksai tensorush

repo: zigzap/zap


text:
HyperparameterOptimization is None

df_conc.head(5)
index | raw
2021-07-07 09:00:01 | 0.48
2021-07-07 09:30:06 | 0.46
2021-07-07 10:00:01 | 1.39
2021-07-07 10:30:06 | 0.84
2021-07-07 11:00:02 | 1.01

index    datetime64[ns]
raw             float64
dtype: object
```

FOr this data when i try to run

```
from luminaire.optimization.hyperparameter_optimization import HyperparameterOptimization
hopt_obj = HyperparameterOptimization(freq='H', detection_type='OutlierDetection')
print(type(hopt_obj))
opt_config = hopt_obj.run(data=df_conc)
print(opt_config)

```

<class 'luminaire.optimization.hyperparameter_optimization.HyperparameterOptimization'>
None

my frequency is actually every 30 mins.. but every freq= gives me same None .

Any help is appreciated.

@webbug2005 Currently, Luminaire batch models only supports certain pandas offsets (link) and 30 mins is currently not supported. That being said, you can still use the WindowDensityModel which supports any arbitrary time frequency. The difference with the batch model is window based model mostly focus identifying anomalies over time windows instead of individual outlying time points.

my end goal is the use streaming data, that comes every 30 mins.. so will skip to directly testing WindowDensity.
But this means i cannot use optimization for streaming data , as it doesnt support 30 mins ? (if i keep a window of 3 months)

Optimization is only for the batch models in Luminaire. WindowDensityModel has an embedded optimization precess to pick the right parameters, so, you don't need to use the optimization module separately.

@webbug2005, would you be able to share any reproducible code with a dummy data in colab? It will be easier for me to debug that way!

repo: zillow/luminaire


text:
Error when using $api->authPre()

Issue
Encountered an error when using authPre():
$account = new AccountSelector(AccountBy::NAME(), $mail);
$api = MailFactory::instance('https://HOSTNAME/service/soap');
$api->authPre($account, ZIMBRA_PREAUTH_KEY);

That is what I get:
Fatal error: Uncaught exception 'GuzzleHttp\Exception\ServerException' with message 'Server error response [url] https://HOSTNAME/service/soap [status code] 500 [reason phrase] Server Error' in    /PROJECT_PATH/vendor/guzzlehttp/guzzle/src/Exception/RequestException.php:89 Stack trace:

#0 /PROJECT_PATH/vendor/guzzlehttp/guzzle/src/Subscriber/HttpError.php(33): GuzzleHttp\Exception\RequestException::create(Object(GuzzleHttp\Message\Request), Object(GuzzleHttp\Message\Response))

#1 /PROJECT_PATH/vendor/guzzlehttp/guzzle/src/Event/Emitter.php(108): GuzzleHttp\Subscriber\HttpError->onComplete(Object(GuzzleHttp\Event\CompleteEvent), 'complete')

#2 /PROJECT_PATH/vendor/guzzlehttp/guzzle/src/RequestFsm.php(91): GuzzleHttp\Event\Emitter->emit('complete', Object(GuzzleHttp\Event\CompleteEvent))

#3 /PROJECT_PATH/vendor/guzzlehtt in /PROJECT_PATH/vendor/guzzlehttp/guzzle/src/Exception/RequestException.php on line 89

Possible solution
After some investigation around authPre(), I saw that the expires parameter is not set at all when using the authPre() method. You end up having a concatened string looking like hisjohn.doe@domain.com|name||1135280708088.
Creating my own PreAuth object specifying the expires parameter, and using auth(), solved my issue and allowed me the authenticate successfully.
$preAuth = new PreAuth(time() * 1000, null, 0);
$preAuth->computeValue($account, ZIMBRA_PREAUTH_KEY);
$api = MailFactory::instance('https://HOSTNAME/service/soap');
$api->auth($account, null, $preAuth);

I am still not sure if this is the right way to solve the problem, but it works and I am able to retrieve unread messages like I wanted.
Should the expires value be set to 0 by default?

Hi @Qayou,
I'm new with this library and I found nowhere some documentations or example to use it.
I'm trying to use the method "createAppointment" but for me the params are chinesee for me.
Did you try something with this method ?
Thank you.

Hi @anardil,
I did not try anything with this method I am sorry. But look at the Mail/Request/CreateAppointment class, you can see it is empty. I think this method is not implmented in this API for now.
You should ask @nguyennv or open an issue/suggestion.
Cheers!

Hello @Qayou,
Thanks for your reply.
In fact this method is here => zimbra-api/src/Zimbra/Mail/Base.php. line 558
I have already opened an issue for that.
This API is very large and complex, it's a shame to have no documentation :(.

@anardil if you check the method, you will see it uses the Mail/Request/CreateAppointment class. And this class is empty so I would not expect it to work without some work.

@Qayou
For me this class is ok. "CreateAppointment" extends the class "CalItemRequestBase".
It's empty because this class doesn't need to have more properties or redefine methods in parent class.
I hope @nguyennv will reply me :)

Hello @Qayou,
nguyennv has given me the solution, you can find it here -> https://github.com/zimbra-api/zimbra-api/issues/11#issuecomment-245861141
Now I'm interested by the preAuth method.
In your solution you used the constant "ZIMBRA_PREAUTH_KEY", how did you get this key?
Thank you.

Hi @anardil,
The Zimbra documentation is well done for that. See PreAuth.
To sum it up, on your Zimbra server you can generate a preAuth key using
zmprov generateDomainPreAuthKey YOUR_DOMAIN

or see a key that is already generated using
zmprov gd YOUR_DOMAIN zimbraPreAuthKey

I hope it helps!

Thank you, I'm going to try.

It works like a charm.
Thank you.

Hi anardil,
Can you please share the working Preauth code.

authors: Qayou anardil paraskumarmali

repo: zimbra-api/zimbra-api


text:
Thanks zin-Fu!

😍😍😍🎆🎆🎆

Wow！

authors: Djctionary zin-Fu


text:
Error: Read-only file system

E/flutter (12991): [ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: FileSystemException: Creation failed, path = 'my' (OS Error: Read-only file system, errno = 30)
E/flutter (12991): #0      _Directory.create. (dart:io/directory_impl.dart:117:11)
E/flutter (12991): #1      _rootRunUnary (dart:async/zone.dart:1436:47)
E/flutter (12991): #2      _CustomZone.runUnary (dart:async/zone.dart:1335:19)
E/flutter (12991):
E/flutter (12991): #3      BackendManager.open (package:hive/src/backend/vm/backend_manager.dart:21:7)
E/flutter (12991):
E/flutter (12991): #4      HiveImpl._openBox (package:hive/src/hive_impl.dart:100:15)
E/flutter (12991):
E/flutter (12991): #5      HiveImpl.openBox (package:hive/src/hive_impl.dart:139:12)
E/flutter (12991):
E/flutter (12991): #6      HiveStore.open (package:graphql/src/cache/hive_store.dart:26:17)
E/flutter (12991):
E/flutter (12991): #7      _SignUpScreenState.getClient (package:jungle_x/src/view/screens/auth/signup.dart:34:19)
E/flutter (12991):
E/flutter (12991):
E/flutter (12991): [ERROR:flutter/lib/ui/ui_dart_state.cc(209)] Unhandled Exception: FileSystemException: Creation failed, path = 'my' (OS Error: Read-only file system, errno = 30)
E/flutter (12991): #0      _Directory.create. (dart:io/directory_impl.dart:117:11)
E/flutter (12991): #1      _rootRunUnary (dart:async/zone.dart:1436:47)
E/flutter (12991): #2      _CustomZone.runUnary (dart:async/zone.dart:1335:19)
E/flutter (12991):
E/flutter (12991): #3      BackendManager.open (package:hive/src/backend/vm/backend_manager.dart:21:7)
E/flutter (12991):
E/flutter (12991): #4      HiveImpl._openBox (package:hive/src/hive_impl.dart:100:15)
E/flutter (12991):
E/flutter (12991): #5      HiveImpl.openBox (package:hive/src/hive_impl.dart:139:12)
E/flutter (12991):
E/flutter (12991): #6      HiveStore.open (package:graphql/src/cache/hive_store.dart:26:17)
E/flutter (12991):
E/flutter (12991): #7      _SignUpScreenState.getClient (package:jungle_x/src/view/screens/auth/signup.dart:34:19)
E/flutter (12991):
E/flutter (12991):

Looking at your stacktrace it looks to be because you're using hive. Please consider using another cache, e.g. in memory.

repo: zino-hofmann/graphql-flutter


text:
Dependency Issue with latest flutter SDK and Connectivity Plus

I tried to install the package but it is throwing error with recent flutter SDK version and Connectivity_plus package.
I get Following error in console:
`The current Dart SDK version is 3.4.1.
Because graphql >=5.2.0-beta.2 <5.2.0-beta.3 requires SDK version >=2.15.0 <=3.0.0 and graphql >=5.2.0-beta.3 depends on
  gql_exec ^1.0.0, graphql >=5.2.0-beta.2 requires gql_exec ^1.0.0.
And because graphql_flutter >=5.0.0-nullsafety.5 <5.0.1-beta.2 depends on gql_exec ^0.3.0 and graphql_flutter
  >=5.0.0-nullsafety.5 <5.0.0 depends on graphql ^5.0.0-nullsafety.5, graphql_flutter >=5.0.0-nullsafety.5 <5.0.0 requires
  graphql >=5.0.0-nullsafety.5 <5.2.0-beta.2.
And because graphql_flutter >=5.1.1-beta.5 <5.2.0-beta.2 depends on connectivity_plus ^3.0.0 and graphql_flutter
  >=5.0.1-beta.1 <5.1.1-beta.5 depends on connectivity_plus ^2.0.3, graphql_flutter >=5.0.0-nullsafety.5 <5.0.0 or
  >=5.0.1-beta.1 <5.2.0-beta.2 requires graphql >=5.0.0-nullsafety.5 <5.2.0-beta.2 or connectivity_plus ^2.0.3 or ^3.0.0.
And because graphql_flutter >=5.0.0 <5.0.1-beta.1 depends on connectivity_plus ^1.0.1 and graphql_flutter >=0.8.0
  <5.0.0-beta.1 doesn't support null safety, graphql_flutter >=0.8.0 <5.0.0-beta.1 or >=5.0.0-nullsafety.5 <5.2.0-beta.2
  requires graphql >=5.0.0-nullsafety.5 <5.2.0-beta.2 or connectivity_plus ^1.0.1 or ^2.0.3 or ^3.0.0.
And because graphql_flutter >=0.4.0 <0.8.0 depends on http ^0.11.0 and graphql_flutter <0.4.0 doesn't support null safety,
  graphql_flutter <5.0.0-beta.1 or >=5.0.0-nullsafety.5 <5.2.0-beta.2 requires graphql >=5.0.0-nullsafety.5 <5.2.0-beta.2 or
  connectivity_plus ^1.0.1 or ^2.0.3 or ^3.0.0 or http ^0.11.0.
And because graphql_flutter >=5.2.0-beta.6 depends on connectivity_plus ^5.0.0 and graphql_flutter >=5.2.0-beta.4
  <5.2.0-beta.6 depends on connectivity_plus ^4.0.0, graphql_flutter <5.0.0-beta.1 or >=5.0.0-nullsafety.5 <5.2.0-beta.2 or
  >=5.2.0-beta.4 requires graphql >=5.0.0-nullsafety.5 <5.2.0-beta.2 or connectivity_plus ^1.0.1 or ^2.0.3 or ^3.0.0 or ^4.0.0
  or ^5.0.0 or http ^0.11.0.

(1) So, because graphql_flutter >=5.2.0-beta.3 <5.2.0-beta.4 depends on connectivity_plus ^3.0.0 and graphql_flutter
>=5.2.0-beta.2 <5.2.0-beta.3 requires SDK version >=2.12.0 <=3.0.0, graphql_flutter <5.0.0-beta.1 or >=5.0.0-nullsafety.5
requires graphql >=5.0.0-nullsafety.5 <5.2.0-beta.2 or connectivity_plus ^1.0.1 or ^2.0.3 or >=3.0.0 <4.0.0 or ^4.0.0 or
^5.0.0 or http ^0.11.0.
Because graphql >=5.2.0-beta.2 <5.2.0-beta.3 requires SDK version >=2.15.0 <=3.0.0 and graphql >=5.2.0-beta.3 depends on
  gql_exec ^1.0.0, graphql >=5.2.0-beta.2 requires gql_exec ^1.0.0.
And because graphql_flutter >=5.0.0-beta.1 <5.0.0-nullsafety.1 depends on gql_exec ^0.3.0, graphql >=5.2.0-beta.2 is
  incompatible with graphql_flutter >=5.0.0-beta.1 <5.0.0-nullsafety.1.
Because graphql_flutter >=5.0.0-beta.1 <5.0.0-beta.2 depends on graphql ^5.0.0-beta.1 and graphql_flutter >=5.0.0-beta.2
  <5.0.0-nullsafety.1 depends on graphql ^5.0.0-beta.2, graphql_flutter >=5.0.0-beta.1 <5.0.0-nullsafety.1 requires graphql
  ^5.0.0-beta.1.
Thus, graphql_flutter >=5.0.0-beta.1 <5.0.0-nullsafety.1 requires graphql >=5.0.0-beta.1 <5.2.0-beta.2.

(2) So, because graphql_flutter >=5.0.0-nullsafety.1 <5.0.0-nullsafety.2 depends on graphql 5.0.0-nullsafety.1,
graphql_flutter >=5.0.0-beta.1 <5.0.0-nullsafety.2 requires graphql >=5.0.0-beta.1 <5.2.0-beta.2.
Because graphql >=5.2.0-beta.2 <5.2.0-beta.3 requires SDK version >=2.15.0 <=3.0.0 and graphql >=5.2.0-beta.3 depends on
  gql_exec ^1.0.0, graphql >=5.2.0-beta.2 requires gql_exec ^1.0.0.
And because graphql_flutter >=5.0.0-nullsafety.1 <5.0.0-nullsafety.5 depends on gql_exec ^0.3.0-nullsafety.1 and
  graphql_flutter >=5.0.0-nullsafety.2 <5.0.0-nullsafety.5 depends on graphql ^5.0.0-nullsafety.3, graphql_flutter
  >=5.0.0-nullsafety.2 <5.0.0-nullsafety.5 requires graphql >=5.0.0-nullsafety.3 <5.2.0-beta.2.
And because graphql_flutter >=5.0.0-beta.1 <5.0.0-nullsafety.2 requires graphql >=5.0.0-beta.1 <5.2.0-beta.2 (2),
  graphql_flutter >=5.0.0-beta.1 <5.0.0-nullsafety.5 requires graphql >=5.0.0-beta.1 <5.2.0-beta.2.
And because graphql_flutter <5.0.0-beta.1 or >=5.0.0-nullsafety.5 requires graphql >=5.0.0-nullsafety.5 <5.2.0-beta.2 or
  connectivity_plus ^1.0.1 or ^2.0.3 or >=3.0.0 <4.0.0 or ^4.0.0 or ^5.0.0 or http ^0.11.0 (1), every version of graphql_flutter
  requires graphql >=5.0.0-beta.1 <5.2.0-beta.2 or connectivity_plus ^1.0.1 or ^2.0.3 or >=3.0.0 <4.0.0 or ^4.0.0 or ^5.0.0 or
  http ^0.11.0.
And because graphql >=5.0.0-beta.1 <5.2.0-beta.2 depends on http ^0.13.0 and neskart depends on http ^1.2.1, every version
  of graphql_flutter requires connectivity_plus ^1.0.1 or ^2.0.3 or >=3.0.0 <4.0.0 or ^4.0.0 or ^5.0.0.
So, because neskart depends on both connectivity_plus ^6.0.3 and graphql_flutter any, version solving failed.

The lower bound of "sdk: '>=1.19.0 <2.0.0'" must be 2.12.0 or higher to enable null safety.
For details, see https://dart.dev/null-safety
The lower bound of "sdk: '>=2.0.0-dev.52.0 <3.0.0'" must be 2.12.0 or higher to enable null safety.
For details, see https://dart.dev/null-safety
You can try the following suggestion to make the pubspec resolve:

Consider downgrading your constraint on connectivity_plus: flutter pub add connectivity_plus:^5.0.2

we may release a new version to fix this problem?
I think this patch https://github.com/zino-hofmann/graphql-flutter/pull/1428 fix your problem

@vincenzopalazzo  How can we install the graphql_flutter package to our project? The stable version is not being installed because of an error and with this commit how to install the package?

Idk I should google it. But I can make a new beta release also for fixing your problem

@gaurav-webbytroops
Just like so:
graphql_flutter:
    git:
      url: https://github.com/zino-hofmann/graphql-flutter.git
      ref: c0621ccad047d3ec94565f92406ebeda394dbd4c
      path: packages/graphql_flutter```

But I can make a new beta release also for fixing your problem

@vincenzopalazzo That would be awesome!

@johnmartel it is coming!

authors: ThomasAunvik gaurav-webbytroops johnmartel vincenzopalazzo


text:
Update dynamodb to 2.20.121

About this PR
📦 Updates software.amazon.awssdk:dynamodb from 2.17.295 to 2.20.121
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk", artifactId = "dynamodb" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "software.amazon.awssdk", artifactId = "dynamodb" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #258.

repo: zio/zio-dynamodb


text:
Update scalafmt-core to 3.7.16

About this PR
📦 Updates org.scalameta:scalafmt-core from 3.7.15 to 3.7.16
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #200.

repo: zio/zio-parser


text:
Add MongoDB BSON codec

Add a codec for MongoDB BSON. It should be self-contained and not add new dependencies. Added as a top-level project, similar to avro support.

/bounty $500

Zero new dependencies is quite hard since org.bson is quite java-style.
But we have zio-bson library in one of ziverge projects and we should be able to publish it. There is magnolia-based derivation and I've implemented zio-schema derivation already. I'm waiting for confirmation from @runtologist to publish it.

@senia-psm  Let's do this!

authors: jdegoes runtologist senia-psm

repo: zio/zio-schema


text:
Create UPDATE query examples

We need a few examples of UPDATE queries under different schemas, both to validate the design and flesh out edge cases, as well as to show people how to use the data type to model UPDATE queries.

I'm not sure if this one still needs to be done or we can close it as mentioned here?

That one was closed and split into new issues (with this being one of them)

@marcinkrykowski I think we've only got one example with one schema so we still need some more. Feel free to try and break the DSL and raise new issues - this is how we can make it better.

authors: jdegoes marcinkrykowski robmwalsh

repo: zio/zio-sql


text:
Add 'min_scale' function to PostgresModule

Add support for function min_scale described in the PostgreSQL docs.

Add function to PostgresFunctionDef in PostgresModule
Add test in FunctionDefSpec

Hi, I would like to tackle this one 🙂


text:
Does this support Orleans 2.0?

Hello,
Does this provider compatible with Orleans 2.0? If yes, Could you please post provider configuration.
Thanks

Hi,
it took some time but it does now.
Best,
Martin

authors: srinathgnath zitmen


text:
Sync with zk-ruby/zookeeper @ 1.5.5

Hello all,
Can we have a new release to update the internal zookeeper lib version to 1.5.5?
We @talkdesk are currently blocked in the upgrade to Ruby 3.X due to this.
Thanks in advance 🙏🏼

Nvm, just found that gemspec is permissive enough to update to this version.

repo: zk-ruby/zk


text:
Count recoveredFundsReceiver for isRecoveryEnabled

Consider to improve the logic in isRecoveryEnabled
https://github.com/zkBob/zkbob-contracts/blob/944bcf5adad326283d369943559c3b76c6f6331f/src/token/Recovery.sol#L89-L91
The recovery is enabled if recoveredFundsReceiver is set and totalRecovery does not exceed the limit.

Addressed in f2a398fddee8f8903907bc739f0781c34b31232e, closing the issue

repo: zkBob/zkbob-contracts


text:
Update clang static analyzer to version 12

It looks like clang-tools-11 has disappeared from the llvm repo

Thanks 👍

repo: zlib-ng/zlib-ng

license: Zlib


text:
Players spawning at y=1k during space station creation and not falling

Version of Advanced Rocketry
AdvancedRocketry-1.12.2-1.5.0-128-universal
Have you verified this is an issue in the latest unstable build
Yes
Version of LibVulpes
LibVulpes-1.12.2-0.4.0-51-universal
Version of Minecraft
1.12.2
Crash report or log (if applicable)
http://pastebin.com is a good place to put them
crash reports that are put in the issue itself are
hard to read
no crash report
some relevant stuff from the latest.log
`
[16:50:10] [Server thread/INFO] [FML]: [Server thread] Server side modded connection established
[16:50:10] [Server thread/INFO] [gamestages]: Loaded 7 stages for IRSmoh_.
[16:50:10] [Server thread/INFO] [net.minecraft.server.management.PlayerList]: IRSmoh_[/208.66.149.183:14408] logged in with entity id 9264937 at (-1520.0, 1000.0, 2560.0)
[16:50:10] [Server thread/INFO] [net.minecraft.server.dedicated.DedicatedServer]: IRSmoh_ joined the game
[16:50:10] [Server thread/INFO] [gamestages]: Syncing 7 stages for IRSmoh_.
[16:50:10] [Server thread/INFO] [buildinggadgets]: Sending SyncedConfig to freshly logged in player IRSmoh_.
[16:50:10] [Server thread/INFO] [EnderCore]: Sending server configs to client for com.enderio.core.common.config.ConfigHandler
[16:50:10] [Server thread/INFO] [wizardry]: Sending module list to IRSmoh_
[16:50:10] [Server thread/INFO] [Actually Additions]: Sending Player Data to player IRSmoh_ with UUID c46c2413-b741-4de5-8df9-e27e33237287.
[16:50:10] [Server thread/INFO] [Mekanism]: Sent config to 'IRSmoh_.'
[16:50:25] [Server thread/INFO] [gamestages]: Saved 7 stages for tommypoints.
[16:50:25] [Server thread/INFO] [gamestages]: Saved 5 stages for Wired_4fun.
[16:50:25] [Server thread/INFO] [gamestages]: Saved 13 stages for TheonlyTazz.
[16:50:25] [Server thread/INFO] [gamestages]: Saved 7 stages for IRSmoh_.
[16:50:25] [Server thread/INFO] [net.minecraft.network.NetHandlerPlayServer]: Wired_4fun lost connection: Disconnected
[16:50:25] [Server thread/INFO] [net.minecraft.server.dedicated.DedicatedServer]: Wired_4fun left the game
[16:50:32] [Server thread/INFO] [net.minecraft.server.dedicated.DedicatedServer]: <IRSmoh_> k
[16:50:37] [Server thread/INFO] [net.minecraft.server.dedicated.DedicatedServer]: <IRSmoh_> I'm out of oxygen somehow
[16:50:40] [JDA MainWS-ReadThread/INFO] [DiscordIntegration]: [3.0.4] [DearDeathDay]  Same happened when I wanted to send the rocket back, I kind of sadly fell off and watched the rocket launch without me. Luckily it got home okay
[16:50:40] [Netty Epoll Server IO #7/INFO] [CodeChickenLib-ConfigSync]: Skipping config sync, No mods have registered a syncable config.
[16:50:43] [Server thread/INFO] [net.minecraft.server.dedicated.DedicatedServer]: <IRSmoh_> maybe I fall to the area first before I run out of xp
[16:50:49] [Server thread/INFO] [FML]: [Server thread] Server side modded connection established
[16:50:49] [Server thread/INFO] [gamestages]: Loaded 5 stages for Wired_4fun.
[16:50:49] [Server thread/INFO] [net.minecraft.server.management.PlayerList]: Wired_4fun[/23.233.43.227:52780] logged in with entity id 9277774 at (-1520.0, 1000.0, 2560.0)
[16:50:49] [Server thread/INFO] [net.minecraft.server.dedicated.DedicatedServer]: Wired_4fun joined the game
[16:50:49] [Server thread/INFO] [gamestages]: Syncing 5 stages for Wired_4fun.
[16:50:49] [Server thread/INFO] [buildinggadgets]: Sending SyncedConfig to freshly logged in player Wired_4fun.
[16:50:49] [Server thread/WARN] [buildinggadgets]: Could not use type of Field blockBlacklist! Found type com.direwolf20.buildinggadgets.common.config.PatternList!
[16:50:49] [Server thread/INFO] [EnderCore]: Sending server configs to client for com.enderio.core.common.config.ConfigHandler
[16:50:49] [Server thread/INFO] [wizardry]: Sending module list to Wired_4fun
[16:50:49] [Server thread/INFO] [Actually Additions]: Sending Player Data to player Wired_4fun with UUID be0bc979-6779-4d1d-9f22-6881d683eb0f.
[16:50:49] [Server thread/INFO] [Mekanism]: Sent config to 'Wired_4fun.'
[16:50:49] [Server thread/INFO] [Astral Sorcery]: [Astral Sorcery] Waiting for server synchronization on login for Wired_4fun...
[16:51:09] [Server thread/INFO] [net.minecraft.server.dedicated.DedicatedServer]: <Wired_4fun> Im at y1000
[16:51:10] [Server thread/INFO] [gamestages]: Saved 7 stages for IRSmoh_.
[16:51:10] [Server thread/INFO] [gamestages]: Saved 5 stages for Wired_4fun.
[16:51:10] [Server thread/INFO] [net.minecraft.server.dedicated.DedicatedServer]: <IRSmoh_> yeah dead
[16:51:11] [Server thread/INFO] [net.minecraft.server.dedicated.DedicatedServer]: You have been depressurized
[16:51:11] [Server thread/INFO] [enderio]: Galacticraft inventory inaccessable. Most likely because it is not installed.
[16:51:11] [Server thread/INFO] [tombmanygraves]: [TombManyGraves]: IRSmoh_ died in dimension -2 at BlockPos{x=-1533, y=528, z=2558}. Their grave may be near!
[16:51:13] [Server thread/INFO] [net.minecraft.server.dedicated.DedicatedServer]: <Wired_4fun> y10000
[16:51:15] [Server thread/INFO] [advancedrocketry]: JED Found, compat loaded
`
Description of the problem
This has happened to 3 different people on our server so far, yes can reproduce.
The first time someone creates a space station they spawn in at y1000 and dont begin falling to the space station. Inevitably these people log out and when logging back in they are out of oxygen and die and then when they die at that high y Level no grave gets spawned with tomb many graves mod. so basically initially setting up the space station is a death sentence with all your items lost right now.

I got a little more info, in the log above, the guy Wired_4fun did the actual launch, IRSmoh_ went up with him. Wired did not have the issue with his suit not having oxygen and after reconnecting Wired did fall normally and ultimately land on his space station. IRSmoh did not.

Had a single tank of oxy in chest (4k) and as stated upon relog the oxygen failed to be detected, taking off the suit and putting it back on had no affect.

our shitty rocket
 which has 2 seats ~4 blocks below the highest point, will get stuck trying to go back to earth, the rocket coasts normally up to y1k until the upper most block would probably force the dim switch trigger, but due to us sitting below it, never triggers.

I cannot reproduce this, even if I am multiple blocks below the top of the rocket. Can you test in the newest version and report back?

authors: IRSmoh Saereth Silfryi


text:
🛑 Ops is down

In 9723c40, Ops ($OPS_URL) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Ops is back up in ba4ffa2 after 9 hours, 12 minutes.

repo: zoobean/status


text:
Location permission return denied when select Approximate option on android 12

Bug summary
On android 12, when the popup location request showing, then I select the Approximate -> When using the app (or Only this time) and the response returned is denied.
I've add both ACCESS_FINE_LOCATION & ACCESS_COARSE_LOCATION to the AndroidManifest.

Library version
3.1.0
Environment info
System:
    OS: macOS 12.0.1
    CPU: (8) x64 Apple M1
    Memory: 25.07 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.15.0 - ~/.nvm/versions/node/v14.15.0/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.15.0/bin/yarn
    npm: 6.14.8 - ~/.nvm/versions/node/v14.15.0/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: 1.11.2 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.0.1, iOS 15.0, macOS 12.0, tvOS 15.0, watchOS 8.0
    Android SDK: Not Found
  IDEs:
    Android Studio: 2020.3 AI-203.7717.56.2031.7583922
    Xcode: 13.1/13A1030d - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.10 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1
    react-native: 0.64.2 => 0.64.2
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce

Call Permissions.request(PERMISSIONS.ANDROID.ACCESS_FINE_LOCATION) on android 12 devices.
When the popup location showing, select Approximate then choose When using the app or Only this time
Get denied in the result log

Reproducible sample code
import { request, PERMISSIONS } from "react-native-permissions";

request(PERMISSIONS.ANDROID.ACCESS_FINE_LOCATION).then(result => {
  console.log("result: ", result); // return denied when select Approximate -> When using the app
})

This seems normal. You request fine location, the new permission system allow user to only allow coarse location.
When you receive denied, use check for coarse location.
A similar flow exists on iOS: https://github.com/zoontek/react-native-permissions#about-ios-location_always-permission

So how can I check that when the user chooses Approximate so that when I get denied I will call the ACCESS_COARSE_LOCATION .
or just check in denied case, don't care about what user chooses?

With the check function from this package + COARSE_LOCATION permission.

oh, i'l try that and feedback later.
Thank you so much :))

Something like this:
import { check, request, PERMISSIONS, RESULTS } from "react-native-permissions";

request(PERMISSIONS.ANDROID.ACCESS_FINE_LOCATION)
  .then(async status =>
    status === RESULTS.GRANTED
      ? { status, precise: true }
      : { status: await check(PERMISSIONS.ANDROID.ACCESS_FINE_LOCATION), precise: false },
  )
  .then(({ status, precise }) => console.log("location status: ", status));

repo: zoontek/react-native-permissions


text:
style(inputrange): add v4 styles to InputRange

Desktop: https://marvelapp.com/e14bhc4/screen/67764982
Mobile: https://marvelapp.com/111gi4h4/screen/67793234
You can see it live here: https://priceless-poincare-18a246.netlify.app/#/Components/Atoms/InputRange

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: dfvalero poteirard

repo: zopaUK/react-components


text:
Docker command line options

Got docker running like described in the README.md. First the command like ask for Username and Password:. Then Search: and ID:. Everything works like intended.
But how can you use the command line options with docker run, like changing the format or download a specific playlist URL?

To specify, I run the docker container with
docker run --rm -v "$PWD/Zotify Music:/root/Music/Zotify Music" -v "$PWD/Zotify Podcasts:/root/Music/Zotify Podcasts" -it zotify
How to use the non-predefined command lines?

The way the Dockerfile is written, I believe you would actually need to "bake-in" the additional arguments to the Dockerfile and then rebuild. Rather than muck with that, the approach I take is to simply open an interactive shell in the docker container like so:
docker run --rm -v "$PWD/Zotify Music:/root/Music/Zotify Music" -v "$PWD/Zotify Podcasts:/root/Music/Zotify Podcasts" -it zotify /bin/sh

At this point, you are running in the container and can invoke Zotify like you had installed it with Python:
python3 -m zotify --help

Yeah, just launching the container shell and running zotify with python, makes sense now. Anyway, thank you for the answer, made my day👍

authors: MasterSmurf jacobslusser

repo: zotify-dev/zotify


text:
feat: Added support to ZPA GOV US Cloud

feat: Added support to ZPA GOV US Cloud

This PR has been developed to support customer request via the ZPA Terraform Provider issue #333

repo: zscaler/zscaler-sdk-go


text:
How can I autocomplete one part of autosuggested path at a time? ("forward dir/")

I know that I can use forward-char with ZSH_AUTOSUGGEST_PARTIAL_ACCEPT_WIDGETS to be able to autocomplete one character at a time. Also, I know that forward-word can be used to autocomplete one word (anything without spaces) at a time.
I need to autocomplete one directory at a time (forward-dir), that is, until and including next / in "word" in autosuggestion:
*I typed 4 chars and autosuggestion shows up*
vi dir1/dir2/dir3/file
   ^

*hitting forward-word*
vi dir1/dir2/dir3/file
                      ^

*hitting forward-char (partial)*
vi dir1/dir2/dir3/file
    ^

*what I need*
vi dir1/dir2/dir3/file
       ^

*after that I can do something like this (with ZSH_AUTOSUGGEST_STRATEGY=(history completion) set)*
vi dir1/otherdir/file
        ^

vi dir1/otherdir/file
                ^

vi dir1/otherdir/a.txt
                 ^

vi dir1/otherdir/a.txt
                      ^

 (init)
 (forward-word)
 (forward-char)
 ("forward dir/")
 (start typing different dir)
 ("forward dir/")

I noticed that the desirable behavior is shown by hitting Tab key, but only for the first directory in autosuggestion: if I keep on pressing Tab, it will just start changing autocompleted directory (and show the list of all dirs) in next level and not appending directories from the first autosuggestion. Or I can type 1st char of dir of each level and then press Tab — then it will be like I want but with extra keystrokes. (I don't want to type 1st char of each dir in autosuggested path, only the very 1st char to show the autosuggested path).

Does this help? https://unix.stackexchange.com/a/48589

Yes, it does! Thank you.

repo: zsh-users/zsh-autosuggestions


text:
Don't overwrite config with default values

otherwise users are obliged to set the config values after sourcing the plugin. They're not able to do it before. Also, re-sourcing the plugin will reset the values to the defaults again.
See zimfw/zimfw#301

@ericfreese, good points. I'm working on that. The : ${VAR:=default} construct does not work for array values though. For example, the following creates a scalar value of (history) (instead of an array value containing just the element history):
: ${ZSH_AUTOSUGGEST_STRATEGY:=(history)}

Which construct do you prefer for these cases?

Thanks for your work on this @ericbn. I'm closing this PR in favor of #390. Please let me know what you think of that implementation.

authors: ericbn ericfreese


text:
Question - Do we need to call the free function in OCaml?

I am using OCaml to write a wrapper for my Futhark program. OCaml is a garbage collected language, so if I dynamically allocate an array, I don't have to think about deallocating it, the garbage collector does it for me.
Now, say I create a new Futhark context, then allocate an array in OCaml.
let ctx = Context.v
            ~debug:false ~log:false ~profile:false ~auto_sync:true ()
let pt_cloud= read_pt_cloud file (* pt_cloud_array is a 2D Bigarray.Genarray *)
let z = Array_f64_2d.v ctx pt_cloud
let m = my_futhark_fn ctx z

I assume this Array_f64_2d.v merely "registers" the array pt_cloud with the Futhark context and creates some small overhead data structure with pointers to it.
Now I call a Futhark function, get my result.
I am now confused about what to do with the Futhark 2D array z I constructed on top of my OCaml array. I was thinking that I should call the Futhark function Array_f64_2d.free z  but it's not clear to me how that interacts with OCaml's garbage collection system. When I run the code without calling any free functions, it seems to work, but I'm unclear on whether I'm creating a memory leak by not deallocating the resources. Conversely when I run the code and use the free functions, I hit a bunch of segfaults in my OCaml code and I'm not sure how to get around them. It's occurring to me that these segfaults might be caused by the garbage collector trying to collect memory which has already been deallocated by Futhark.
Do you have any advice on how to proceed here?
Thank you very much!

I don't think it is necessary to call free, it should be called automatically when the value gets garbage collected: https://github.com/zshipko/futhark-bindgen/blob/b9ae50a0feecc78dfc349911424cc3066ee63c13/src/generate/templates/ocaml/array.ml#L19
It does seem like the segfaults you mentioned are because free is being called twice - I will take a look a fixing that.

Just opened https://github.com/zshipko/futhark-bindgen/pull/4 - let me know if that fixes the segfaults

@zshipko Yes, thank you! It does seem work, my program runs fine. I think that the segfault only occurs when the garbage collector actually runs so I think you have to allocate a decent amount of new memory after freeing to trigger the garbage collector and thus trigger the bug. I am able to produce it (on master) with the following code:
open Bigarray

let ctx = my_futhark_program.Context.v
            ~debug:false ~log:false ~profile:false ~auto_sync:true ()

let () =
  let open my_futhark_program in
  for i = 0 to 1000 do
    let a = Genarray.init Float64 c_layout [| 100; 100 |] (fun _ -> Float.of_int i) in
    let p = Array_f64_2d.v ctx a in
    Array_f64_2d.free p
  done

if you want to add something like this to the tests. But yeah, the fix appears to work, I don't get the segfaults anymore.  👍

Thanks! I added your example to the tests and just published a new release.

authors: patrick-nicodemus zshipko

repo: zshipko/futhark-bindgen

license: ISC


text:
Multi-value inserts get formatted awkwardly

This SQL fragment
INSERT INTO bla VALUES (1, 2), (3, 4), (5, 6);

gets formatted into this
INSERT INTO bla
VALUES (1,
        2), (3,
             4), (5,
                  6);

Instead I would expect something like:
INSERT INTO bla
VALUES
    (1, 2),
    (3, 4),
    (5, 6)
;

I want to +1 this.

Same issue, +1

authors: immorlee jvngd ulope

repo: zsong/SqlBeautifier


text:
Compatibility issue between seg_model.index and Keras 3

Hi, I have a compatibility issue when trying to use seg_model.index with Keras 3. Apparently, this version of Keras can only accept extensions such as .keras or .h5 and not .index. This is the error than I get: "Keras 3 only supports V3 .keras files and legacy H5 format files (.h5 extension). Note that the legacy SavedModel format is not supported by load_model() in Keras 3".

'segmenteverygrain' does not work with Keras 3, at least not for now. The best way to run it is to create Python environment using the environment.yml file. I think this will install keras 2.13.1.

authors: louisejuliedelhaye zsylvester

repo: zsylvester/segmenteverygrain


text:
用modify_content.sh修改lamp-util-pro和lamp-cloud-pro-datasource-column无法正确修改

版本信息：
JDK 版本(必填) : 1.8.0
源码版本(必填)：4.11.0 lamp-cloud-pro-datasource-column
MySQL(必填)： 8.0.30
Nacos(必填)：2.0.3
问题描述：
用modify_content.sh修改lamp-util-pro和lamp-cloud-pro-datasource-column无法正确修改
1、用modify_content.sh修改lamp-util-pro的内容如下：
#!/bin/bash
该脚本用于修改文本文件中的字符串，如：将 ${OLD_PACKAGE_STR} 替换成 ${NEW_PACKAGE_STR}
TODO 请修改 NEW_PACKAGE_STR 和  NEW_STR
将包名中  top.tangyh.basic 改成 com.公司.basic , 不支持增加4级或者5级包！！！
将包名中 top.tangyh.lamp 改成 com.公司.项目 , 不支持增加4级或者5级包！！！
会将源码中 package 和 import 关键字后面的 ${OLD_PACKAGE_STR} 替换成 NEW_PACKAGE_STR
OLD_PACKAGE_STR="top.tangyh.basic"
NEW_PACKAGE_STR="com.zak.basic"
OLD_PACKAGE_STR="top.tangyh.lamp"
NEW_PACKAGE_STR="com.cloud.zak"
公司名、 项目名要和 modify_file_name.sh 中的公司名、 项目名保持一致
这里会将注释、配置文件、默认的密码等改成 NEW_PARAM_PREFIX
OLD_PARAM_PREFIX="lamp-"
NEW_PARAM_PREFIX="zak-"
TODO 这里修改成你要替换等项目路径
#PROJECT_PATH=/Users/tangyh/Downloads/lamp-cloud-pro
PROJECT_PATH=/e/zak/script/zak-util-pro
PROJECT_PATH=/e/zak/script/zak-cloud
#PROJECT_PATH=/Users/tangyh/Downloads/test/lamp-boot-plus
#PROJECT_PATH=/Users/tangyh/Downloads/test/lamp-web
#PROJECT_PATH=/Users/tangyh/Downloads/test/lamp-util
###############下面的请勿改动#################
这段命令用于清理项目中无用等文件
rm -rf $PROJECT_PATH/.git
rm -rf $PROJECT_PATH/third-party
find $PROJECT_PATH/ -name "*.iml"  | xargs rm -rf
find $PROJECT_PATH/ -name "target"  | xargs rm -rf
find $PROJECT_PATH/ -name ".DS_Store"  | xargs rm -rf
find $PROJECT_PATH/ -name ".idea"  | xargs rm -rf
mac 使用这段命令实现替换字符串   （mac和centos的区别在于 -i 后面有没有 ""）
grep -rl  "${OLD_PACKAGE_STR}" $PROJECT_PATH | xargs sed -i "" "s/${OLD_PACKAGE_STR}/${NEW_PACKAGE_STR}/g"
#grep -rl  "${OLD_PARAM_PREFIX}" $PROJECT_PATH | xargs sed -i "" "s/${OLD_PARAM_PREFIX}/${NEW_PARAM_PREFIX}/g"
centos  和 windows git bash 使用下面的命令
#grep -rl  "${OLD_PACKAGE_STR}" $PROJECT_PATH | xargs sed -i "s/${OLD_PACKAGE_STR}/${NEW_PACKAGE_STR}/g"
#grep -rl  "${OLD_PARAM_PREFIX}" $PROJECT_PATH | xargs sed -i "s/${OLD_PARAM_PREFIX}/${NEW_PARAM_PREFIX}/g"
2、用modify_content.sh修改lamp-cloud-pro-datasource-column的内容如下：
#!/bin/bash
该脚本用于修改文本文件中的字符串，如：将 ${OLD_PACKAGE_STR} 替换成 ${NEW_PACKAGE_STR}
TODO 请修改 NEW_PACKAGE_STR 和  NEW_STR
将包名中  top.tangyh.basic 改成 com.公司.basic , 不支持增加4级或者5级包！！！
将包名中 top.tangyh.lamp 改成 com.公司.项目 , 不支持增加4级或者5级包！！！
会将源码中 package 和 import 关键字后面的 ${OLD_PACKAGE_STR} 替换成 NEW_PACKAGE_STR
OLD_PACKAGE_STR="top.tangyh.basic"
NEW_PACKAGE_STR="com.zak.basic"
OLD_PACKAGE_STR="top.tangyh.lamp"
NEW_PACKAGE_STR="com.cloud.zak"
公司名、 项目名要和 modify_file_name.sh 中的公司名、 项目名保持一致
这里会将注释、配置文件、默认的密码等改成 NEW_PARAM_PREFIX
OLD_PARAM_PREFIX="lamp-"
NEW_PARAM_PREFIX="zak-"
TODO 这里修改成你要替换等项目路径
#PROJECT_PATH=/Users/tangyh/Downloads/lamp-cloud-pro
PROJECT_PATH=/e/zak/script/zak-util-pro
PROJECT_PATH=/e/zak/script/zak-cloud
#PROJECT_PATH=/Users/tangyh/Downloads/test/lamp-boot-plus
#PROJECT_PATH=/Users/tangyh/Downloads/test/lamp-web
#PROJECT_PATH=/Users/tangyh/Downloads/test/lamp-util
###############下面的请勿改动#################
这段命令用于清理项目中无用等文件
rm -rf $PROJECT_PATH/.git
rm -rf $PROJECT_PATH/third-party
find $PROJECT_PATH/ -name "*.iml"  | xargs rm -rf
find $PROJECT_PATH/ -name "target"  | xargs rm -rf
find $PROJECT_PATH/ -name ".DS_Store"  | xargs rm -rf
find $PROJECT_PATH/ -name ".idea"  | xargs rm -rf
mac 使用这段命令实现替换字符串   （mac和centos的区别在于 -i 后面有没有 ""）
grep -rl  "${OLD_PACKAGE_STR}" $PROJECT_PATH | xargs sed -i "" "s/${OLD_PACKAGE_STR}/${NEW_PACKAGE_STR}/g"
#grep -rl  "${OLD_PARAM_PREFIX}" $PROJECT_PATH | xargs sed -i "" "s/${OLD_PARAM_PREFIX}/${NEW_PARAM_PREFIX}/g"
centos  和 windows git bash 使用下面的命令
#grep -rl  "${OLD_PACKAGE_STR}" $PROJECT_PATH | xargs sed -i "s/${OLD_PACKAGE_STR}/${NEW_PACKAGE_STR}/g"
#grep -rl  "${OLD_PARAM_PREFIX}" $PROJECT_PATH | xargs sed -i "s/${OLD_PARAM_PREFIX}/${NEW_PARAM_PREFIX}/g"
报错截图
1、用modify_content.sh修改lamp-util-pro的报错如下：
$ ./modify_content.sh
sed: can't read s/top.tangyh.basic/com.zak.basic/g: No such file or directory
sed: can't read s/top.tangyh.basic/com.zak.basic/g: No such file or directory
2、用modify_content.sh修改lamp-cloud-pro-datasource-column的报错如下：
shawn@LAPTOP-I9SUOFIB MINGW64 /e/zak/script
$ ./modify_content.sh
sed: can't read s/top.tangyh.lamp/com.cloud.zak/g: No such file or directory
sed: can't read s/top.tangyh.lamp/com.cloud.zak/g: No such file or directory
sed: can't read s/top.tangyh.lamp/com.cloud.zak/g: No such file or directory
sed: can't read s/top.tangyh.lamp/com.cloud.zak/g: No such file or directory
sed: can't read s/top.tangyh.lamp/com.cloud.zak/g: No such file or directory
重现步骤

访问了什么接口？
传递什么参数？
后端控制台报了什么错？
前端控制台报了什么错？

支持一下
如果该issue帮助了你, 麻烦给项目点个star, 并给当前issue回复一下 “👍” 或者 “已解决”.

报错信息已经说得很清楚了，文件或目录不正确， 这个脚本需要在centos 执行。
有网友反馈可以在window下安装上 windows git bash ,也能执行。

多理解脚本中的注释，如确实需要帮助，可以购买精简项目服务，直接按你要求给你改好
https://tangyh.top/pages/vip/#增值服务-均不含票

repo: zuihou/lamp-cloud


text:
docs: Improve development guide.

Minifies the current development guide by
a significant amount. Also, removes system requirements
as no credible source for them. Removes dependency
specific instructions and adds links to instructions
to install them.
Preview here.
You have tested this PR on:

[x] Windows
[x] Linux/Ubuntu
[ ] macOS

@kanishk98 is there anything else needed for in the Windows Dev?

@vsvipul let's finish this.

@akashnimare closing this, will open a new PR.

authors: abhigyank akashnimare vsvipul

repo: zulip/zulip-electron


text:
iOS Public Release

[ ] New messages arriving don't show in narrows #584
[ ] When keyboard pops up, anchor message list bottom #592
[ ] Switching narrows should anchor message list to first unread message #583
[ ] Unread Messages flashes for a bit for self sent messages #588
[x] Sometimes numbers in emoji reactions are not aligned correctly #589
[x] Sometimes the emoji reactions don't work/do anything when clicked on. #590
[x] App Store Requirements #591

The linked issues are all closed, and the app has been out in public for some time. Closing; we have plenty of specific threads for specific issues in the iOS app.

authors: borisyankov gnprice

repo: zulip/zulip-mobile


text:
webView,css:Fix scroll got disturbed when viewport height changes.

Before img height was in vh. So when viewport height changes,
img height also gets changed. Thus scroll position gets affected.
Now provide img height in px, so that it doesn't change on
viewport height change.
Note: on unread notice/keyboard show/hide, webView viewport height
changes.
References: https://developer.mozilla.org/en-US/docs/Web/CSS/length
Fix: #3264

    Before `img` height was in `vh`. So when viewport height changes,
    `img` height also gets changed. Thus scroll position gets affected.

Good catch, thanks! This seems like something we definitely need to fix, regardless of what other fixes are necessary.

How did you choose the number 200px?

Also, I'm tempted to say the height should still depend on the size of the screen -- we just need to turn that into a px value from outside the WebView. (Using Dimensions, I think, like we do in Lightbox.js.)

    webView, img, css: Crop image and fit in the component.

    Almost all chat apps like twitter, whatsapp renders the cropped image
    in the message list. It looks good, having all images same height and
    width.

As Boris says, this is trickier. And it's unrelated to the scrolling issue, right?
I do think we can likely improve on our current choice, but more design work will be needed.
Also, I feel like we discussed this somewhere recently (possibly following this PR), with some details that took effort to produce. Would you please track down that conversation and link to it from here? That way we can avoid repeating ourselves.

    webview, js: Scroll `smoothly` on window resize.

    Message list scrolls to adjust the position when keyboard pops in/out.

Hmm interesting. I'm not sure I like this effect -- it feels pretty heavy. It also doesn't look like other messaging apps do this, on a quick and partial survey.

    android,webView: Fix scroll position on resize if at near bottom.

Hmm, this looks rather subtle. More effort will be needed to explain it, I think. :slightly_smiling_face:

It looks like nearBottom can more simply be written as belowContentHeight < 300. Is that right, or what am I missing?
On the other hand, in handleScrollEvent one of the two is set in a setTimeout while the other is set immediately. What's the motivation behind that? It seems pretty complicated to reason about -- I challenge you to write a clear explanation of what nearBottom and belowContentHeight mean, that's actually accurate for this code. :wink:

+  if (
+    difference > 0
...
+  } else if (belowContentHeight > 0) {
+    const realdiff = -1 * Math.min(-1 * difference, belowContentHeight);

There seem to be a lot of possible combinations here of different conditions for what's greater than what. (Having recently filed my US tax return, it reminds me unhappily of forms like this one.) I think some of them may be impossible, which simplifies things -- but I don't want to have to do the careful math to find out. How about unpacking this into a more explicit set of conditions?

Also please no commented-out code. That's what version control is for. :stuck_out_tongue:

Also, I'm tempted to say the height should still depend on the size of the screen -- we just need to turn that into a px value from outside the WebView. (Using Dimensions, I think, like we do in Lightbox.js.)

Hmm, is Dimensions for Screen size or viewport size. We definitely want the first. If it is the latter we would be replicating the vh behavior.

Also, I'm tempted to say the height should still depend on the size of the screen -- we just need to turn that into a px value from outside the WebView. (Using Dimensions, I think, like we do in Lightbox.js.)

Hmm, is Dimensions for Screen size or viewport size. We definitely want the first. If it is the latter we would be replicating the vh behavior.

Take a look at the Lightbox example I mentioned, or at the docs:
https://facebook.github.io/react-native/docs/dimensions.html
It doesn't even know anything about a WebView -- so it won't care whether e.g. UnreadNotice is crowding the message list.
Now, there is an important question of whether it's affected by the keyboard. We'd certainly want to pin that down before using it.
But an absolute size in px would also be perfectly reasonable. If we can't easily get a screen-size measurement that doesn't depend on the keyboard, then that's probably what we'll want instead.

To shorten my review, after rereading:

First commit just needs explanation -- why 200px?

Having thought about this again (and after the discussion with @borisyankov just above): Let's go ahead with a fixed number of px, either 200px or some other value. That's simpler than trying to adapt to screen size, and I'm not sure that the latter would be better even if we found a way to do it reliably.

Let's drop the second and third commits.
Last commit needs to be clearer in the actual code... and one thing I think might help you do that is to attempt to write a good explanation of what those two new globals mean. That'll be hard. Then make changes so that they mean something that's easier to clearly explain.

Hmm -- in my emulated Nexus 5, this actually makes images quite a bit taller:

Compare from master (well, the base of this branch):

That's even though the commit message explains it was supposed to make them smaller, by a ratio of 2/3.
Make it as 200px, because usually whole screen is around ~1000px and
200px is 20%.

I think you have overestimated how big a phone screen is. :wink: For one thing, remember these are "logical" pixels.
Please take a look at this background doc:
https://github.com/zulip/zulip-mobile/blob/master/docs/background/layout.md

Also remember the old 30vh is 30% of the viewport's height -- that's the original point of this branch, after all! And the viewport is shorter by at a minimum the status bar, the app bar, the compose box, and (on Android) the system buttons.

Merged -- thanks again @jainkuniya !
A couple of things that I had to adjust in the commit message first:

The message said 180px, though the code said 160px.

The message said

Tested on Android Pixel 3 emulator, One plus six physical device,
and iOS X simulator, 180px is resulting in same size of image as old 30vh.

but surely it wasn't actually the same size, right? For one thing it's unlikely it was quite the same size across those three. (Also I kept reading "iOS X simulator" as "iOS simulator", which is meaningless here as different models will surely have different results. Now I realize you possibly meant to write "iPhone X simulator"... but surely that would be much taller, no?)
So instead I wrote what the actual size came to in the emulator I was using, and said how that roughly generalized.

authors: borisyankov gnprice jainkuniya


text:
compose: Allow multiple image selection; don't send immediately

Thanks @AkashDhiman for your PR #5125 and your prep work for this in #4590; those were quite helpful and informative. 🙂
Marked as a draft/blocked for a reason I'll explain, but that reason doesn't affect the first three commits—
ComposeMenu [nfc]: Use our own new type definition for attachments
ComposeMenu [nfc]: Fix name of insertAttachment prop to be plural
ComposeMenu [nfc]: Convert to a function component
—and indeed those three would be good to land as prep for removing the blocker.
The blocker is that we have basically the behavior of #5291, except with the insertion of image links instead of Jitsi links. On iOS, you take or select a photo to upload, and sometimes the message text input is unchanged when you expect it to get an inserted [Uploading …]() link.
Fixes: #2366
Fixes: #4540
Replaces: #5125

Chat thread about the resulting UI on Android:
https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Android.20select.20multiple.20photos/near/1423109

Thanks for the review! Revision pushed.

@gnprice, I've just rebased this atop #5635, so it's ready for another code review. I'm working on spinning up the simulator to make a screen recording now. 🙂

Just pushed a revision fixing a rebase error in the new type Attachment's definition (r-n-document-picker changed an optional string property to required with string | null).
Here's a video of the feature working on my iPhone:
https://user-images.githubusercontent.com/22248748/211920752-a6325fb5-5c08-4c13-b113-8b778ef2ebd0.mp4

Thanks for the review! Revision pushed.

Thanks! Looks good; merging.

authors: chrisbobbe gnprice


text:
Focus compose text after selecting reply.

Fix:#680

I didn't review this PR earlier because I wasn't liking the approach to getting the input focued.
Haven't figured out a great way to do it myself, but I think it should be less reactive in this case, and more direct.

@vishwesh3 Hey, any update and a tip on how to implement this simpler.
We should be using reactive programming wherever possible (just as you did here) but in some places imperative (as do this now) is way simpler and preferable.
In this case, we should skip the redux store altogether, and not issue any actions too.
It works like this: find a common parent of the Input and the ActionSheet, then the ActionSheet calls a callback to the parent, which itself focuses the compose input.
It will be similar to the this.listRef.scrollToEnd(); that we use on the MessageList.
The final solution will probably be 10-20 lines of code ;)

We can close this as #1089 got merged.


text:
Document zulip-cloud-current branch

Now that we have an automatically maintained zulip-cloud-current branch, we should document it on the pages about how to do data exports from Zulip Cloud, and possibly other places like the "release lifecycle" page.

@alexmv Are you up for taking this one?

authors: alya timabbott

repo: zulip/zulip


text:
nginx: Enable TLS 1.3 if supported

Testing Plan: Production tested on stretch (TLS 1.2), buster (TLS 1.2+1.3), and bionic (TLS 1.2+1.3).

Great, merged, thanks @andersk!

authors: andersk timabbott


text:
Added name of status emoji in tooltip

Closes #19821

Testing plan:
GIFs or screenshots:

Ready for review.

@axaysagathiya thanks for working on this!  I posted a couple comments; you should also write a proper commit message for your changes.
Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

I have stored common properties in a separate object as you suggested.
Please have a look and let me if any changes are required.

@timabbott
I have extracted a function to calculate placement as @amanagr  suggested.
Please have a look and let me know if any changes are required.

Overall looks great. You need to work on the commit messages. You need 2 commits here. One is extracting common properties from emoji tooltip function and the second one is adding the tooltip to the emoji.

Hm, playing around with this PR, I'm not sure this is user experience we want.

I don't think it looks great to have two tooltips at the same time. It would probably be better to hide the user tooltip when showing the emoji tooltip.
It feels unexpected to me that hovering over the status emoji shows the emoji name rather than the status text. I think the tooltip should show the status text, which after all is what the other user is trying to convey with the status emoji. If there is no status text, I guess we just wouldn't show a tooltip.

@gnprice since you filed the original issue, does that sound reasonable?

2. I think the tooltip should show the status text, which after all is what the other user is trying to convey with the status emoji. If there is no status text, I guess we just wouldn't show a tooltip.

Hmm. I think this doesn't help with the reason I wanted this:

When you encounter an emoji in a Zulip message or reaction, there's a tooltip on hover that tells you the name of the emoji.
This is valuable because it makes it discoverable how to enter the same emoji yourself. It can also help you interpret what an emoji means, when the glyph isn't clear.

I don't think it's necessarily true that the status text is what the user was trying to convey with the status emoji. Looking around on CZO, a number of people have status emoji set. Most of them have no status text at all. Of those that do, a couple of them have the text apparently meant to say the same thing as the emoji (like a cat emoji, and "meow"); others have the text and the emoji conveying different information (like a "terminal window" emoji, for the maintainer of zulip-terminal, and the text "Working remotely".)
(There are also a smattering of people who have a status text that contains an emoji, like ":house: Working remotely". Those correspond to some status texts offered by the mobile app as suggestions. When we support status emoji, coming soon, I think those suggestions will change to put the emoji there and leave the status text as plain text.)
So:

If the status emoji is a terminal window, it doesn't seem helpful at all to show a tooltip of "Working remotely" when I hover over it.
If the status emoji is an octopus or a terminal window or whatever else, I'd like to be able to see the emoji's name so it's discoverable how I can use the same emoji myself. And if the status text is blank or is about something else, I'd like to be able to see the emoji's name to help me understand what the person means by it, too.

Looking at the screenshot, I think perhaps one thing that makes it look a little odd is that it's not using the same style of tooltip that we use when you hover over an emoji in a message. Here's a sample of the latter:

The screenshot doesn't show my pointer, but it's pointing right at that emoji; and the tooltip starts immediately at the bottom-right corner of the pointer.
That style feels a bit lighter-weight than the one with the speech-balloon-like wedge, good for a one-word little nugget of information; it also is visually attached directly to the user's cursor.

Mm, yeah, the lighter-weight tooltip does seem better if we go with the emoji name.
I dunno, I think my expectations are set in part by using Slack at work, where (a) people tended to use statuses more seriously than whimsically, and (b) hovering over the emoji does tell you what the status text is.
Sounds like it may be worth continuing the #design conversation that kicked this off...

Since this is still being discussed in terms of what the UX design should be I am closing this PR.

authors: alya amanagr axaysagathiya gnprice timabbott


text:
message_list_view: Don't select message if the list is not current.

Not having this check caused Mark as unread from here to not work for message which was selected when the list was rendered since we marked it as read again via this.list.select_id after marking it as unread.
Steps for reproducer:

Narrow to a topic / PM with plenty of messages.
Mark some messages as unread in that narrow.
Reload the page.
Now the message which was selected will remain "read" even upon marking it as unread.

discussion: https://chat.zulip.org/#narrow/stream/6-frontend/topic/unable.20to.20mark.20message.20as.20read

This is great, thanks for tracking this down and helping make sure it gets fixed; the "mark as read" performance improvement is actually quite significant when doing large bulk operations. Marked to merge after the readability revisions noted above, thanks @amanagr!

Thanks!

authors: amanagr timabbott


text:
help: Document updated UI for subscribing/unsubscribing from streams.

Updates description of buttons for subscribing/unsubscribing to streams via Stream settings.
Fixes #27753.
Screenshots and screen captures:

https://zulip.com/help/browse-and-subscribe-to-streams

https://zulip.com/help/unsubscribe-from-a-stream

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability

Communicate decisions, questions, and potential concerns.

[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@alya This PR is ready for review.
@zulipbot add "help center review"

Let's drop the color descriptions; they were only necessary because the colors were important in the UI.

Can we add the icons in as usual?

Can we add the icons in as usual?

Done! Updated PR + screenshots.

The screenshots look good to me, thanks!

Merged, thanks @drrosa!

authors: alya drrosa timabbott


text:
log-search: Match against path without query parameters.

The nginx logs have query parameters; display them, but do not use them for URL matching.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @alexmv!

authors: alexmv timabbott


text:
Bot settings: Adding copy buttons for bot email and API key

This pull request adds two copy buttons in the Bot settings, beside the bot email and API key, which copies there content.
Fixes:  #19884

Screenshots and screen captures:
https://github.com/zulip/zulip/assets/96657269/4b4e117a-5d8c-47ac-a2e9-282f0a69abeb

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Thanks! The issue was out of date -- we should use the icon from #28700.

I added some notes to the issue.

@alya I think the issue #28700 should be resolved to do further changes here because the new icon is not available in the code yet. I see someone is working on the issue #28700, after their PR is merged can you give me a heads-up so I can change the icon here?

I won't be able to give you a heads up, but you can subscribe to follow the other issue yourself, so that you get notified.

Is this issue still open?

@zulipbot @Anand-ReddyK  hello!! is this issue still up for grabs?

@alya Is the issue still open so i could work on it?

Closing this PR as we've decided to deprecate this bots panel. Thanks for the work here, @Jay-Lokhande !


text:
integration: Split 'opened_or_update_pull_request' event type into multiple event type.

GSoC`2024 participant.

Modified the 'get_zulip_event_name' function to
differentiate between 'opened' and 'updated' actions for pull requests within the 'pull_request' event type. Created separate event types for 'opened_pull_request' and 'updated_pull_request'. Updated the 'EVENT_FUNCTION_MAPPER' dictionary to include handlers for these new event types. Adjusted the'get_opened_or_update_pull_request_body' function to handle both 'opened' and 'updated' actions appropriately.
Fixes #29594.
Docs:

Event filtering option:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@timabbott this PR is waiting for a review if you have time kindly review :)

Updates to the integration events look good to me and did some manual testing in the dev environment filtering for these events. Marking for integration review.
Also, not sure why the codecov check in CI has been running for 20+ hours at this point.

This is great, merged, thanks @sujalshah-bit!

authors: laurynmm sujalshah-bit timabbott


text:
exports: Add a separate bucket for realm exports.

This PR extracts the first 6 commits of #21725
While rebasing, I made few changes which were impacted by these commits:

https://github.com/zulip/zulip/commit/214bd4ed88f6fb245dfa018fc00cbee5258e8169
https://github.com/zulip/zulip/commit/3aea67a8ede6b8493f1faaa361556e376e94e203

I have highlighted the changes I made as comments below.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Updates in the recent push:

Addressed the review comments -- see respective comments.
Added two new tests -- test_tarball_upload_avatar_bucket_download_export_bucket & test_tarball_upload_export_bucket_download_avatar_bucket -- See last commit (test_upload_s3)

Looks good to me aside from the question above.

Merged, thanks @prakhar1144 and @alexmv!


text:
requirements cleanup: remove redundant lib list

The line -r common.txt can be found in dev.txt and prod.txt
This should speed up the build process by 2-3s, in addition to the speed
up from not having to prepare a python2 venv.

Automated message from Dropbox CLA bot
@rht, it looks like you've already signed the Dropbox CLA. Thanks!

Still within the scope of requirements, I have a question: why does the entire file https://github.com/zulip/zulip/blob/master/requirements/ipython.txt exist but not just a line ipython==5.3.0? Or rather, why is ipython required for both dev and prod? It is not used anywhere in the code but as an analysis tool. Removing the ipython dependency entire should reduce the number of libs to be downloaded.

Merged, thanks @rht!
Re: ipython, it's because we're pinning the versions of all dependencies and installing with --no-deps, so that every time one installs a particular commit of Zulip, you run the same code.  Those other things in ipython.txt are its recursive dependencies.
ipython is required in prod for making manage.py shell work well (basically the interface for manually inspecting and modifying the Zulip database).

authors: rht smarx timabbott


text:
queue processors: Add coverage for SlowQueryWorker.

The first commit replaces #7284.
I manually tested both queues with print statements in my dev server. The log looked like
Starting development server at http://127.0.0.1:9992/
Quit the server with CONTROL-C.
consuming
consuming missedmessages
consuming
consuming
consuming missedmessages
consuming
consuming
consuming missedmessages
consuming
consuming
consuming missedmessages
consuming
consuming
consuming missedmessages
consuming
consuming
consuming missedmessages
consuming
consuming
consuming missedmessages
consuming
consuming
consuming missedmessages
consuming
consuming
consuming missedmessages
consuming
consuming
consuming missedmessages
consuming
consuming
consuming missedmessages
consuming
consuming
consuming missedmessages
consuming
consuming
consuming missedmessages
consuming
consuming
consuming missedmessages
consuming
consuming missedmessages

(consuming = slowqueryworker)

Tests are failing, looks like some sort of minor text-escaping issue?

Yeah, the regex I used seems to only work locally.

Updated, should work now.

Merged, thanks @derAnfaenger!  queue_processors.py is now at 89% coverage, which is awesome!

authors: derAnfaenger timabbott


text:
Scripts: Add script for resetting postgres sequences for imports.

This is in reference to the discussion https://chat.zulip.org/#narrow/stream/issues/topic/stream.20creation.20after.20realm.20import

Merged!  Thanks @rheaparekh!

authors: rheaparekh showell


text:
Disposable email followup

Followup of #8549

Merged, thanks @hackerkid!

authors: hackerkid timabbott