text:
[Android Crash] at dart::Dart::Init, on gaming phones

There is an online crash in our application caused by flutter. We think it may be accidental, or maybe it only reproduces under certain situations. We use FlutterFragment in our Application. Now it crashes when the application is opened.
There are only the following types of mobile phones that have problems. All of them are gaming phones.

ASUS-I005DA
ASUS-I005DB
ZTERED MAGIC 5G
Lenovo L79031
NX669J
M2007J1SC

Logs
This is my flutter sdk info:
Flutter 2.5.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 18116933e7 (6 weeks ago) • 2021-10-15 10:46:35 -0700
Engine • revision d3ea636dc5
Tools • Dart 2.14.4

This is the crash log:
signal 11 code 1 at address 0x4
 backtrace:
 #0 pc 0x43e85a /data/app/**/lib/arm/libflutter.so
 #1 pc 0x51d84a /data/app/**/lib/arm/libflutter.so
 #2 pc 0x19316a /data/app/**/lib/arm/libflutter.so
 #3 pc 0x19938e /data/app/**/lib/arm/libflutter.so
 #4 pc 0x159830 /data/app/**/lib/arm/libflutter.so
 basic:
 ABI: arm pid: 7407  tid: 7407

This is what I parsed:
#0 pc 0x43e85a dart::Dart::Init(unsigned char const*, unsigned char const*, _Dart_Isolate* (*)(char const*, char const*, char const*, char const*, Dart_IsolateFlags*, void*, char**), bool (*)(void**, char**), void (*)(void*, void*), void (*)(void*, void*), void (*)(void*), void (*)(), void* (*)(char const*, bool), void (*)(unsigned char**, int*, void*), void (*)(void const*, int, void*), void (*)(void*), bool (*)(unsigned char*, int), _Dart_Handle* (*)(), bool, Dart_CodeObserver*)
/b/s/w/ir/cache/builder/src/out/android_release/../../third_party/dart/runtime/vm/object.cc:2608
#1 pc 0x51d84a Dart_Initialize
/b/s/w/ir/cache/builder/src/out/android_release/../../third_party/dart/runtime/vm/dart_api_impl.cc:1212
#2 pc 0x19316a DartVMInitializer::Initialize(Dart_InitializeParams*)
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/runtime/dart_vm_initializer.cc:21
#3 pc 0x19938e flutter::Shell::Create(flutter::PlatformData const&, flutter::TaskRunners, flutter::Settings, std::__1::function<std::__1::unique_ptr<flutter::PlatformView, std::__1::default_delete<flutter::PlatformView> > (flutter::Shell&)> const&, std::__1::function<std::__1::unique_ptr<flutter::Rasterizer, std::__1::default_delete<flutter::Rasterizer> > (flutter::Shell&)> const&, bool)
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/shell/common/shell.cc:142
#4 pc 0x159830 std::__1::unique_ptr<flutter::Shell, std::__1::default_delete<flutter::Shell> >::release()
/b/s/w/ir/cache/builder/src/out/android_release/../../third_party/libcxx/include/memory:2583

Other Info
There is some device info and java logcat data:
pre_d_device_info.txt
pre_p_status.txt
pre_d_logcat_log.txt
pre_d_logcat_log.txt
pre_p_status.txt

Hi @lengzds, thanks for filing the issue.
Can you reproduce this crash locally?
If so kindly provide a complete minimal reproducible code sample so that we can better address this issue.
Thank you

If so kindly provide a complete minimal reproducible code sample so that we can better address this issue.

I found a nx659 phone and tried many times, but I can't reproduce this crash locally.

Hi @lengzds, please provide the full output of flutter doctor -v.

We use FlutterFragment in our Application

Can you provide the sample code that uses FlutterFragment?
If you could also provide any configuration files such as build.gradle, AndroidManifest.xml that has any special configuration you might be using, that may be helpful.
Please provide you pubspec.yaml as well.
Thank you

flutter doctor -v
[✓] Flutter (Channel stable, 2.5.3, on macOS 12.0.1 21A559 darwin-x64, locale zh-Hans-CN)
    • Flutter version 2.5.3 at /Users/zhangdaishuai/fvm/versions/2.5.3
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18116933e7 (7 weeks ago), 2021-10-15 10:46:35 -0700
    • Engine revision d3ea636dc5
    • Dart version 2.14.4
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/zhangdaishuai/Library/Android/sdk
    • Platform android-31, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 13.1, Build version 13A1030d
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] IntelliJ IDEA Community Edition (version 2018.1.6)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 31.3.1
    • Dart plugin version 181.5656

[✓] VS Code (version 1.62.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.28.0

[✓] Connected device (2 available)
    • TAS AN00 (mobile) • XPL5T19A26011401 • android-arm64  • Android 10 (API 29)
    • Chrome (web)      • chrome           • web-javascript • Google Chrome 96.0.4664.55

How we use Fragment?
We will add FlutterFragment into our FragmentPagerAdapter at MainActivity.onCreate.

AndroidManifest like this, we add many intent-filter to our MainActivity, but I think It has nothing to do with this.

This is the settings related to flutter in the AndroidManifest:
        <meta-data
            android:name="flutterEmbedding"
            android:value="2" />

This is my pubspec.yaml:
name: app_all
description: A new flutter module project.

version: 1.0.0+1

environment:
  sdk: ">=2.1.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter
  flutter_localizations:
    sdk: flutter

  flutter_rating_bar: ^3.0.0
  percent_indicator: 2.1.6
  expandable: 5.0.1
  cupertino_icons: ^0.1.2
... ...

At last, I must emphasize that only a few fixed mobile phones will have problems. They will crash at the app launch, caused by Dart::Init.

Hi @lengzds, it is always better to copy/paste the code sample than to send screenshots of code samples.
Since we know that the app crashes at launch, can you please provide a complete sample in a repo that crashes at launch?
Please provide the versions of android the affected devices are running on as well.
Thank you

source: gharchive/issue

authors: danagbemava-nc lengzds

repo: flutter/flutter

license_type: permissive

license_source: github-api


text:
When will the fix for #75675 roll into Flutter?

It looks like the PR was made over half a year ago. I don't really want to use the workaround if the fix will be rolled into FLutter in short time.

HI @b3b0, Please drop a link to PR and the ISSUE You are referring to, Also it would be great if you can describe what the actual issue is along with the steps to reproduce the issue.
Thanks


text:
[shared engine, platform_view, Hybrid Composition] PlatformView flashes white screen

Screen recording
Open page
Go back

As shown in the video, there are two PlatformView pages, A and B. when opening B from A, or going back to A from B, the transition animation will flash white screen.

Steps to Reproduce

Get demo as below:

git clone -b task/boost3.0_for_2.8.x https://github.com/0xZOne/flutter_boost.git

Enter the example directory and execute flutter run.

Follow the video steps.

flutter doctor -v
[✓] Flutter (Channel master, 2.9.0-1.0.pre.491, on macOS 12.0.1 21A559 darwin-x64, locale zh-Hans-CN)
    • Flutter version 2.9.0-1.0.pre.491 at /Users/zero/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7ec334827a (8 hours ago), 2022-01-24 19:50:10 -0800
    • Engine revision 83cfdcc8f1
    • Dart version 2.17.0 (build 2.17.0-51.0.dev)
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0-rc1)
    • Android SDK at /Users/zero/Library/Android/sdk
    • Platform android-32, build-tools 32.0.0-rc1
    • ANDROID_HOME = /Users/zero/Library/Android/sdk
    • ANDROID_SDK_ROOT = /Users/zero/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS (Xcode 12.5.1)
    • Xcode at /Applications/Xcode12.5.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2020.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)

[✓] VS Code (version 1.63.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (2 available)
    • NOH AN00 (mobile) • PQY5T20A14002065 • android-arm64  • Android 10 (API 29)
    • Chrome (web)      • chrome           • web-javascript • Google Chrome 97.0.4692.99

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Hi @0xZOne, Thanks for filing the issue. This issue seems similar to https://github.com/flutter/flutter/issues/95343 which was fixed a few days ago could you please verify this issue on the latest master channel. If the issue persists please share a minimal and complete reproducible code sample.
Thank you.

Hi @0xZOne, Thanks for filing the issue. This issue seems similar to #95343 which was fixed a few days ago could you please verify this issue on the latest master channel. If the issue persists please share a minimal and complete reproducible code sample.
Thank you.

This issue persists on the latest master channel.

@0xZOne  could you please check the example repo the build seems to be failing
Launching lib/main.dart on Redmi K20 Pro in debug mode...
Warning: Mapping new ns http://schemas.android.com/repository/android/common/02 to old ns http://schemas.android.com/repository/android/common/01
Warning: Mapping new ns http://schemas.android.com/repository/android/generic/02 to old ns http://schemas.android.com/repository/android/generic/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/02 to old ns http://schemas.android.com/sdk/android/repo/addon2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/02 to old ns http://schemas.android.com/sdk/android/repo/repository2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/02 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01
Warning: Mapping new ns http://schemas.android.com/repository/android/common/02 to old ns http://schemas.android.com/repository/android/common/01
Warning: Mapping new ns http://schemas.android.com/repository/android/generic/02 to old ns http://schemas.android.com/repository/android/generic/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/02 to old ns http://schemas.android.com/sdk/android/repo/addon2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/02 to old ns http://schemas.android.com/sdk/android/repo/repository2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/02 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01
/Users/mahesh/Desktop/flutter_boost/android/src/main/java/com/idlefish/flutterboost/containers/FlutterTextureHooker.java:62: error: method startRenderingToSurface in class FlutterRenderer cannot be applied to given types;
                            flutterRenderer.startRenderingToSurface(surface, false);
                                           ^
  required: Surface
  found: Surface,boolean
  reason: actual and formal argument lists differ in length
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error

FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':flutter_boost:compileDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org
BUILD FAILED in 49s
Exception: Gradle task assembleDebug failed with exit code 1
Exited (sigterm)

Comment out the error line, do not affect the test.

Thanks for the update @0xZOne, I am seeing similar output on stable and the master channel.  There seems to be some fade effect when a new platform view is pushed onto the stack.
https://user-images.githubusercontent.com/31410839/151115000-2fcfd94e-3b6b-4b0f-9e9a-5cac8e576341.mov

flutter doctor -v
[✓] Flutter (Channel stable, 2.8.1, on macOS 12.1 21C52 darwin-arm, locale en-GB)
    • Flutter version 2.8.1 at /Users/mahesh/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 77d935af4d (3 weeks ago), 2021-12-16 08:37:33 -0800
    • Engine revision 890a5fca2e
    • Dart version 2.15.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 60.1.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.63.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.32.0

[✓] Connected device (4 available)
    • Redmi K20 Pro (mobile) • 192.168.1.3:5555                     • android-arm64  • Android 11 (API 30)
    • iPhone 13 Pro (mobile) • 0FA2FB93-2A89-4FDB-8293-DF66188F1E54 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-15-0
      (simulator)
    • macOS (desktop)        • macos                                • darwin-arm64   • macOS 12.1 21C52 darwin-arm
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 96.0.4664.110

• No issues found!

[✓] Flutter (Channel master, 2.9.0-1.0.pre.466, on macOS 12.1 21C52 darwin-arm, locale en-GB)
    • Flutter version 2.9.0-1.0.pre.466 at /Users/mahesh/Documents/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5e2542f609 (2 days ago), 2022-01-24 06:15:18 -0500
    • Engine revision e920762d70
    • Dart version 2.17.0 (build 2.17.0-50.0.dev)
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-31, build-tools 31.0.0
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.10.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Community Edition (version 2021.2.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 60.1.4
    • Dart plugin version 212.5080.8

[✓] VS Code (version 1.63.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.32.0

[✓] Connected device (3 available)
    • Redmi K20 Pro (mobile) • 192.168.1.3:5555 • android-arm64  • Android 11 (API 30)
    • macOS (desktop)        • macos            • darwin-arm64   • macOS 12.1 21C52 darwin-arm
    • Chrome (web)           • chrome           • web-javascript • Google Chrome 97.0.4692.99

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

@maheshmnj
Unlike #95343, the reason here is that PlatformViewsController does not well support the scenario where multiple FlutterActivity share the same engine.

Is this problem solved?

Is this problem solved?

authors: 0xZOne fnfunfunc maheshmnj xtuck


text:
[tool_crash] DartDevelopmentServiceException

Command
flutter run

Steps to Reproduce

...
...
...

Logs
DartDevelopmentServiceException
#0      DartDevelopmentServiceImpl.startService (package:dds/src/dds_impl.dart:130:7)
<asynchronous suspension>
#1      DartDevelopmentService.startDartDevelopmentService (package:dds/dds.dart:88:5)
<asynchronous suspension>
#2      DebugService.startDartDevelopmentService (package:dwds/src/services/debug_service.dart:152:12)
<asynchronous suspension>
#3      DevHandler._createAppDebugServices (package:dwds/src/handlers/dev_handler.dart:442:7)
<asynchronous suspension>
#4      DevHandler.loadAppServices (package:dwds/src/handlers/dev_handler.dart:229:25)
<asynchronous suspension>
#5      Dwds.debugConnection (package:dwds/dwds.dart:91:9)
<asynchronous suspension>
#6      WebDevFS.connect.<anonymous closure> (package:flutter_tools/src/isolated/devfs_web.dart:686:15)
<asynchronous suspension>

[✓] Flutter (Channel stable, 2.10.3, on Ubuntu 21.04 5.11.0-49-generic, locale fr_FR.UTF-8)
    • Flutter version 2.10.3 at /home/nery/snap/flutter/common/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7e9793dee1 (il y a 4 jours), 2022-03-02 11:23:12 -0600
    • Engine revision bd539267b4
    • Dart version 2.16.1
    • DevTools version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /home/nery/Android/Sdk
    • Platform android-31, build-tools 31.0.0
    • Java binary at: /opt/android-studio-2020.3.1/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
    • cmake version 3.10.2
    • ninja version 1.8.2
    • pkg-config version 0.29.1

[✓] Android Studio (version 2020.3)
    • Android Studio at /opt/android-studio-2020.3.1/android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓] Android Studio
    • Android Studio at /opt/android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)

[✓]

Duplicate of #97604


text:
Fix api examples not running on android

fixes: #100139
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

/cc @blasten

@googlebot I signed the cla

@googlebot I signed it!

source: gharchive/pull-request

authors: danagbemava danagbemava-nc


text:
[macOS] Use arm64 snapshot in arm64 App.framework

Previously, https://github.com/flutter/flutter/pull/100271 enabled
building universal macOS binaries by default. When building macOS (and
iOS) apps, Flutter builds them in three components:

The Runner application: built by Xcode
The bundled App.framework: built from assembly code generated by
gen_snapshot from the application's Dart sources.
The bundled FlutterMacOS.framework: built as part of the engine build
and packaged by copying the distributed binary framework from our
artifacts cache.

Building App.framework consists of the following steps:

For each architecture, invoke gen_snapshot to generate
architecture-specific assembly code, which is then built to object
code and linked into an architecture-specific App.framework.
Use the lipo tool to generate a universal binary that includes both
x86_64 and arm64 architectures.

Previously, we were building architecture specific App.framework
binaries. However, for all architectures we were (mistakenly) invoking
the general gen_snapshot tool (which emitted x64 instructions, and
which is now deprecated) instead of the architecture-specific
gen_snapshot_x86 and gen_snapshot_arm64 builds which emit
instructions for the correct architecture.
This change introduces a small refactoring, which is to split the
getNameForDarwinArch function into two functions:

getDartNameForDarwinArch: the name for the specified architecture as
used in the Dart SDK, for example as the suffix of gen_snapshot.
getNameForDarwinArch: the name for the specified architecture
as used in Apple tools, for example as an argument to lipo. For
consistency, and to match developer expectations on Darwin platforms,
this is also the name used in Flutter's build outputs.

Issue: https://github.com/flutter/flutter/issues/100348
Pre-launch Checklist

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I signed the CLA.
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making, or this PR is test-exempt.
[X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Gold has detected about 1 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/100504

Gold has detected about 1 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/100504

This change LGTM. Recommend an integration test to validate the macOS test runs in release mode. Suggest a macOS version of https://github.com/flutter/flutter/blob/master/dev/devicelab/bin/tasks/run_release_test.dart See https://github.com/flutter/flutter/blob/master/dev/devicelab/bin/tasks/hot_mode_dev_cycle_macos_target__benchmark.dart for example of macOS test.

+1

Sounds good; I'm going to land this to get master unbroken on M1 machines. Sending a followup patch that adds the devicelab test momentarily.

Integration test added in https://github.com/flutter/flutter/pull/100526.

authors: cbracken skia-gold zanderso


text:
Roll Flutter Engine from 1328c4bc6299 to 3bfd5985bfb1 (1 revision)

https://github.com/flutter/engine/compare/1328c4bc6299...3bfd5985bfb1
2023-02-15 skia-flutter-autoroll@skia.org Roll Skia from df42581d2765 to 40bb09c44a51 (1 revision) (flutter/engine#39647)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


text:
Update integration tests and benchmarks in /dev to newest Gradle, AGP, and Kotlin

This PR resolves #123636
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

This change effectively removes testing on older AGP versions. Not sure if that's what #123636 was about.
I think it'd be nice if we had some policy for supporting Gradle and AGP (e.g: the current release and the last one). I can imagine some large projects are slow to migrate.
At the same time, Gradle and AGP should be an implementation detail for most Flutter devs, one they shouldn't care about.

I don't have time to fix the failing tests :( hopefully someone else picks this up in the future


text:
Update DWDS to 20.0.1 in flutter_tools

Updates DWDS from 19.0.2 to 20.0.1
Makes the required changes for the breaking changes to the AssetReader class

auto label is removed for flutter/flutter/132350, due to - The status or check suite Mac tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

I re-ran this, it was a network flake.

authors: christopherfujino elliette


text:
[a11y] Fix date picker cannot focus on the edit field

fixes: https://github.com/flutter/flutter/issues/143116
fixes: https://github.com/flutter/flutter/issues/141992
https://b.corp.google.com/issues/322173632
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Reason for revert: made the tree red.

e.g. https://ci.chromium.org/ui/p/flutter/builders/prod/Mac framework_tests_libraries/15753/overview

authors: dnfield hangyujin


text:
Set the default clip to Clip.none again.

This reverts commit 8de0e15e4fdd3a1be8878394a7f8c8bda948e59b as https://github.com/flutter/flutter/pull/20751 and https://github.com/flutter/flutter/pull/20836 has landed.
Everything in flutter_gallery looks good to me.

@jonahwilliams Everything looks good to me in flutter gallery. Can you please take a look at this PR?


text:
Roll engine 20d3861ac8e1..9ab6550b45cd (29 commits)

https://github.com/flutter/engine/compare/20d3861ac8e1...9ab6550b45cd
git log 20d3861ac8e1f8f38c8659b16b699d0e63db01b1..9ab6550b45cd4608f24e76a5d4e812d68a167491 --no-merges --oneline
9ab6550b4 Introduce read only text field semantics (flutter/engine#9281)
a263abfba Roll src/third_party/skia dc57783169c3..e0a001ccf8d5 (1 commits) (flutter/engine#9372)
f75e7228f Roll src/third_party/skia c65edca18491..dc57783169c3 (3 commits) (flutter/engine#9371)
3f7a9f09f Roll src/third_party/skia 48fec763d45d..c65edca18491 (1 commits) (flutter/engine#9369)
c764a7628 Do not remove the DartServiceIsolate status callback during FlutterMain destruction (flutter/engine#9368)
4c9fa4940 request FlutterView focus when setting a platform view text client (flutter/engine#9366)
4a3e69d5d Roll src/third_party/skia 7694b90eb000..48fec763d45d (11 commits) (flutter/engine#9367)
2f36285bc Surrogate binary messenger (flutter/engine#9347)
0ca0a4161 [glfw]  Implement clipboard support from GLFW api (flutter/engine#9361)
66db3d58e Add APIs for querying FlutterView for a FlutterEngine and listening for attachment/detachment (#29114). (flutter/engine#9356)
f2e76a892 Android Embedding Refactor PR32: Clean up logs in new embedding (#33544, #33102). (flutter/engine#9351)
36f18b0ae Android Embedding Refactor PR33: Clean up FlutterJNI (#25533). (flutter/engine#9354)
63591bcd9 Roll src/third_party/skia c6438c0b7f32..7694b90eb000 (12 commits) (flutter/engine#9364)
92cb11d07 Fix test name typo (flutter/engine#9362)
340d958ff Roll src/third_party/skia 07edcfd4dc19..c6438c0b7f32 (9 commits) (flutter/engine#9359)
280fa4551 Roll src/third_party/skia c6628127dc30..07edcfd4dc19 (9 commits) (flutter/engine#9358)
aa4bc1be6 Roll src/third_party/skia e7f8c34384ed..c6628127dc30 (1 commits) (flutter/engine#9357)
48974cac0 Roll src/third_party/skia 9c71e7be1097..e7f8c34384ed (3 commits) (flutter/engine#9355)
04d44a39d Roll src/third_party/skia 4b203ad7ac02..9c71e7be1097 (4 commits) (flutter/engine#9353)
05c034e5b Update component manifests for ambient replace-as-executable (flutter/engine#9350)
66022ce25 Roll src/third_party/skia 55091020435c..4b203ad7ac02 (6 commits) (flutter/engine#9352)
fcff2d619 Use the DartServiceIsolate status callback to publish the observatory URI to the Android embedder (flutter/engine#9337)
ea7ca9804 Send the isolate service ID from the engine to the embedder (flutter/engine#9324)
675033fc0 Check for invalid indexes when performing InputAdpator backspace. (flutter/engine#9322)
e5918d18f Roll src/third_party/skia 92b81e14d9c2..55091020435c (6 commits) (flutter/engine#9348)
e00ac47f4 Reorganize darwin for shared ios/macOS (flutter/engine#9255)
9da409c0e Fix crash on Huawei device with AndroidView (flutter/engine#9192)
a0f85546f Removed an unused class definition for iOS code. (flutter/engine#9346)
96a1a843c Replace lock_guard with scoped_lock and use class template argument deduction. (flutter/engine#9338)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5980870922469376

Commit queue failed; closing this roll.


text:
Re add large sample

Re-add the large sample app, and fix the dev/dartdoc.dart script so that it can be run by the chromium bots.
@abarth

authors: abarth devoncarew


text:
snackBar should paint above the bottomSheet

As title.
If the bottomsheet takes all horizontal space (most do), the snackbar is invisible to the user.

Fixes #63254
Close #19547
Test coming soon.

@Piinks Hi,
Do you have any suggestions about the test case? Can I only use the Goden test for this issue?

@Piinks Hi,
Do you have any suggestions about the test case? Can I only use the Goden test for this issue?

@Piinks Hi,
Do you have any suggestions about the test case? Can I only use the Goden test for this issue?

A golden file test SGTM!

@Piinks Hi,
Do you have any suggestions about the test case? Can I only use the Goden test for this issue?

A golden file test SGTM!

Gold has detected about 1 untriaged digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/73558

Gold has detected about 1 untriaged digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/73558

authors: Piinks skia-gold xu-baolin


text:
Make profile_startup.dart print instructions.

@chinmaygarde

lgtm

authors: chinmaygarde eseidelGoogle


text:
Migrate channel to null safety

I have migrated dev/integration_test/channels to null safety
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Hello @jmagman
can you please review this PR?
Thanks

Hello @jmagman
abhishek@abhisheks-mbp devicelab % dart bin/run.dart -t channels_integration_test_ios

════════════╡ ••• Running task "channels_integration_test_ios" ••• ╞════════════

Executing: /Users/abhishek/Desktop/open_source/flutter/bin/cache/dart-sdk/bin/dart --disable-dart-dev --enable-vm-service=0 --no-pause-isolates-on-exit bin/tasks/channels_integration_test_ios.dart in /Users/abhishek/Desktop/open_source/flutter/dev/devicelab with environment {}
Unhandled exception:
ProcessException: Failed to find "/Users/abhishek/Desktop/open_source/flutter/bin/cache/dart-sdk/bin/dart" in the search path.
  Command: /Users/abhishek/Desktop/open_source/flutter/bin/cache/dart-sdk/bin/dart
#0      LocalProcessManager.start (package:process/src/interface/local_process_manager.dart:58:7)
#1      startProcess (package:flutter_devicelab/framework/utils.dart:286:49)
#2      runTask (package:flutter_devicelab/framework/runner.dart:87:32)
#3      runTasks (package:flutter_devicelab/framework/runner.dart:31:37)
#4      main (file:///Users/abhishek/Desktop/open_source/flutter/dev/devicelab/bin/run.dart:106:11)
#5      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:281:32)
#6      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

I am getting this error logs...

ProcessException: Failed to find "/Users/abhishek/Desktop/open_source/flutter/bin/cache/dart-sdk/bin/dart" in the search path.

Try adding it to your PATH then?
export PATH=/Users/abhishek/Desktop/open_source/flutter/bin/cache/dart-sdk/bin/:$PATH && dart bin/run.dart -t channels_integration_test_ios

Which dart is on your path now (it should be the one specified in the error message)?
which dart

Hello @jmagman
I am able to run the app in the simulator.
so what is the problem here?
can you please guide me solve that problem?
Thanks

Hello @jmagman
I am able to run the app in the simulator after migrating to null safety.
so what is the problem here?
can you please guide me solve that problem?
Thanks

The channels_integration_test_ios test is passing on master, and failing on your PR.  So part of getting this PR merged is debugging that test failure.  😄

Ok let me try to run the test locally
Flutter test will work in this case ?

No, flutter test will not work.

You can test locally by running:
cd dev/devicelab
dart bin/run.dart -t channels_integration_test_ios

Hello @jmagman
I am not able to understand that what is exact here?
can you please guide me?

I am not able to understand that what is exact here
can you please guide me?

Troubleshooting why tests are failing is the responsibility of a PR author, and out of the scope for reviewers. There's some documentation on running devicelab tests https://github.com/flutter/flutter/blob/master/dev/devicelab/README.md, and if you still need help, I would recommend following up in the discord #hackers-tests channel. Thanks.

@Abhishek01039 If you're not sure how to debug the test failure you should probably just close this PR.  The reviewers (me) aren't likely to prioritize debugging this any time soon.  Feel free to re-open with test edits if you figure out why channels_integration_test_ios is failing on this PR.

authors: Abhishek01039 christopherfujino jmagman


text:
Update all packages

Update all packages to bring in new vm_service and dwds packages.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

/cc @zanderso @christopherfujino this is needed to unblock the coverage speedup work.

looks like the failing tests are the reason of the currently broken tree and are not related to this change.


text:
Roll Engine from 3364409b917f to f0a8d4eda2e8 (37 revisions)

Roll Engine from 3364409b917f to f0a8d4eda2e8 (37 revisions)
https://github.com/flutter/engine/compare/3364409b917f...f0a8d4eda2e8
2021-11-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 5ccf755b37a4 to f6a43e5eb71d (1 revision) (flutter/engine#29571)
2021-11-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 6BYh8qaYo... to W9UXc2Fwx... (flutter/engine#29570)
2021-11-06 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kHXT3xnTG... to uP2kJIngK... (flutter/engine#29569)
2021-11-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 996ef242a2c9 to 5ccf755b37a4 (1 revision) (flutter/engine#29568)
2021-11-06 skia-flutter-autoroll@skia.org Roll Skia from 37bef2d300e4 to 2417872a9993 (1 revision) (flutter/engine#29567)
2021-11-06 dworsham@google.com fuchsia: Enable integration tests (flutter/engine#29565)
2021-11-05 skia-flutter-autoroll@skia.org Roll Dart SDK from d464cd3f2dc8 to 996ef242a2c9 (1 revision) (flutter/engine#29564)
2021-11-05 egarciad@google.com Fix race condition introduced by background platform channels (flutter/engine#29377)
2021-11-05 skia-flutter-autoroll@skia.org Roll Skia from deb9386be146 to 37bef2d300e4 (6 revisions) (flutter/engine#29563)
2021-11-05 ychris@google.com ios test script checks for ios_test_flutter artifacts (flutter/engine#29554)
2021-11-05 dnfield@google.com Trace calls to Canvas::saveLayer (flutter/engine#29444)
2021-11-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 38e7078fa2b7 to d464cd3f2dc8 (5 revisions) (flutter/engine#29561)
2021-11-05 dkwingsmt@users.noreply.github.com [Linux keyboard] Fix logical keys of up events are not regularized (flutter/engine#29550)
2021-11-05 skia-flutter-autoroll@skia.org Roll Skia from 725705f6630b to deb9386be146 (3 revisions) (flutter/engine#29559)
2021-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from emi7COLIo... to 6BYh8qaYo... (flutter/engine#29558)
2021-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Ci-Vji1rx... to kHXT3xnTG... (flutter/engine#29557)
2021-11-05 skia-flutter-autoroll@skia.org Roll Dart SDK from 05febe0a7860 to 38e7078fa2b7 (5 revisions) (flutter/engine#29556)
2021-11-05 skia-flutter-autoroll@skia.org Roll Skia from 1800d410df16 to 725705f6630b (1 revision) (flutter/engine#29555)
2021-11-05 skia-flutter-autoroll@skia.org Roll Skia from 4322c7fec7e4 to 1800d410df16 (1 revision) (flutter/engine#29553)
2021-11-05 skia-flutter-autoroll@skia.org Roll Dart SDK from f38618d5d0c0 to 05febe0a7860 (5 revisions) (flutter/engine#29539)
2021-11-05 hanneswinkler2000@web.de don't build flutter SDK artifacts for armv7 (flutter/engine#28016)
2021-11-05 skia-flutter-autoroll@skia.org Roll Skia from 17616469ddf8 to 4322c7fec7e4 (3 revisions) (flutter/engine#29552)
2021-11-05 skia-flutter-autoroll@skia.org Roll Skia from ae67f07a58a2 to 17616469ddf8 (1 revision) (flutter/engine#29551)
2021-11-05 skia-flutter-autoroll@skia.org Roll Skia from cf8daf79e710 to ae67f07a58a2 (1 revision) (flutter/engine#29549)
2021-11-05 zhongwuzw@qq.com [iOS] Fixes press key message leaks (flutter/engine#29354)
2021-11-05 skia-flutter-autoroll@skia.org Roll Skia from 37da672b14b7 to cf8daf79e710 (9 revisions) (flutter/engine#29548)
2021-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from nkHhPcy3q... to emi7COLIo... (flutter/engine#29547)
2021-11-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from m90mMA37b... to Ci-Vji1rx... (flutter/engine#29546)
2021-11-05 chriscraws@gmail.com FragmentProgram constructed asynchronously (flutter/engine#29513)
2021-11-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 3b11f88c96a5 to f38618d5d0c0 (7 revisions) (flutter/engine#29537)
2021-11-04 skia-flutter-autoroll@skia.org Roll Clang Linux from 5N9a1nYj5... to UtjvZhwws... (flutter/engine#29535)
2021-11-04 flar@google.com use SkMatrix.invert() instead of MatrixDecomposition to validate cache matrices (flutter/engine#29530)
2021-11-04 skia-flutter-autoroll@skia.org Roll Skia from a05d3029ac65 to 37da672b14b7 (1 revision) (flutter/engine#29534)
2021-11-04 dnfield@google.com Re-enable A11yTreeIsConsistent with higher timeout (flutter/engine#29367)
2021-11-04 iska.kaushik@gmail.com [raster_cache] Increment access_count on Touch (flutter/engine#29529)
2021-11-04 gw280@google.com Remove D3D9 fallback path (flutter/engine#29533)
2021-11-04 akbiggs@users.noreply.github.com [fuchsia] Add more logging for error cases. (flutter/engine#29397)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from m90mMA37b7TM to uP2kJIngKfmw
fuchsia/sdk/core/mac-amd64 from nkHhPcy3qP2e to W9UXc2FwxAxV
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com on the revert to ensure that a human
...

Commit queue failed; closing this roll.


text:
[file_selector] initial implementation

Description
Add the API for the file_selector plugin.
Related Issues
https://github.com/flutter/flutter/issues/65403
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

@jasonpanelli @ditman PTAL

Also cc @stuartmorgan: the plugin is coming!

Some very high level comments based on an initial skim.
In addition to the comments below: why isn't there a driver/integration test as part of this?

Those tests should and will be added as part as each platform implementation.

Some very high level comments based on an initial skim.
In addition to the comments below: why isn't there a driver/integration test as part of this?

Those tests should and will be added as part as each platform implementation.

Every plugin I've implemented for desktop here has integration tests at both layers. Why would we do less testing in this plugin?

Oh, right. I wasn't thinking about the fact that this is UI based; sorry about that. Yes, that does probably mean integration tests can't live at this layer.
(We should still unit test the app-facing API though, using a mock platform interface implementaiton, per my other comments.)

We should still unit test the app-facing API though, using a mock platform interface implementaiton, per my other comments.

@stuartmorgan yes, those should be easy to add; it's just verify that the mock platform methods are being called (if done with Mockito and a Mock platform implementation) or by doing the method logging technique.

Note to all: package: cross_file is now a thing:
https://pub.dev/packages/cross_file

Note to all: package: cross_file is now a thing:
https://pub.dev/packages/cross_file

https://github.com/flutter/flutter/issues/70950 to track the integration. Thanks for the heads up :)!

Let's go with this one! Thanks all for the hard work!

While doing manual testing on Windows with the example I noticed that none of the example calls handle the user pressing cancel (in which case the returned path will be null). Right now canceling any dialog in the example will throw an exception.

@stuartmorgan that's an interesting "edge" case for the web; in web you never get called back if the user cancels the selection (no events, null path... nothing!)

authors: ditman stuartmorgan tugorez

repo: flutter/plugins


text:
[image_picker_platform_interface] use XFile instead of PickedFile

Description
In this PR,  i have migrated the image_picker_platform_interface to use XFile instead of PickedFile. In further PRs i will migrate the image_picker and image_picker_web to use XFile also. This will allow users to get the length of the file(https://github.com/flutter/flutter/issues/58764) and name of the file(https://github.com/flutter/plugins/pull/2802#issuecomment-642360958) .
Related Issues
flutter/flutter#58764 flutter/flutter#70886
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[X] All existing and new tests are passing.
[X] I updated/added relevant documentation (doc comments with ///).
[X] The analyzer (flutter analyze) does not report any problems on my PR.
[X] I read and followed the Flutter Style Guide.
[X] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[X] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[X] I updated CHANGELOG.md to add a description of the change.
[X] I signed the CLA.
[X] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[X] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[ ] No, this is not a breaking change.

@ditman  Can you please review this

@ditman  Can you please review this

@ditman  can you review this again .

@ditman  can you review this again .

@balvinderz this looks good, but I think the team prefers a backwards-compatible version (keeping the old features, and adding new methods for the new features) instead of a major version bump. I'll verify this tomorrow, and if so, I'll do the necessary changes in this PR. Thank you very much for the contribution!

@balvinderz this looks good, but I think the team prefers a backwards-compatible version (keeping the old features, and adding new methods for the new features) instead of a major version bump. I'll verify this tomorrow, and if so, I'll do the necessary changes in this PR. Thank you very much for the contribution!

@balvinderz migrating the platform_interface package to null-safety (in a backwards-compatible way) has taken a higher priority than landing this feature, so the team has decided to work on that first.
Thank you very much for your effort with this PR, but we can't work on merging this PR right now. I'll close this PR, and once the null safety migration is complete, we can revisit this, or maybe re-do it in the new null-safe code. Otherwise, the PR will take too much work to keep rebased.

@balvinderz migrating the platform_interface package to null-safety (in a backwards-compatible way) has taken a higher priority than landing this feature, so the team has decided to work on that first.
Thank you very much for your effort with this PR, but we can't work on merging this PR right now. I'll close this PR, and once the null safety migration is complete, we can revisit this, or maybe re-do it in the new null-safe code. Otherwise, the PR will take too much work to keep rebased.

authors: balvinderz ditman


text:
[google_sign_in_web] Add plugin_name to init call.

This change ensures that a plugin_name attribute with a known value is passed to the init call of the current Web implementation of Google Sign In JS SDK.
This allows "new applications to continue using the plugin after April 30th, 2022".
Mitigates: https://github.com/flutter/flutter/issues/88084
See also: https://github.com/flutter/flutter/issues/101004
//FYI @brdaugherty @kevmoo
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

How does this work? Is this a special value that's whitelisted on the server side?

How does this work? Is this a special value that's whitelisted on the server side?

The presence of the key with (any unique) value is an escape hatch to let the backend know that we need more time to do the actual migration to the new API.
If not present, new apps created from April 20th won't be allowed to use the old SDK.
((Apologies for the internal link, but) please do check cl/439406676 for the documentation CL, it'll be published soon)

(Is it normal for us to be editing files in src/generated, or is this a special case?)

@stuartmorgan they used to be generated when the plugin got started, but the generator hasn't kept up with the changes we needed to do. They probably should be moved out of generated since they've been manually maintained for the last couple of years.

authors: ditman stuartmorgan


text:
登录过程中如何增加loading效果？

Platforms
Android
Description
登录是一个异步的过程，我想再一键登录过程中,有一个加载中(loading)的效果，当登录请求完成时，进行下一步动作.
Why
No response

请问，你是怎么解决的

license: MIT


text:
[Bug]: ERR_FILE_NOT_FOUND: package_info_plus not working on Flutter web deployed as chrome extension

Platform
Web (chrome & Edge)
Plugin
package_info_plus
Version
3.0.2 (latest)
Flutter SDK
3.3.10
Steps to reproduce
Run the sample code on flutter web deployed as chrome extension
Deploying as chrome extension:

Run flutter build web --release --web-renderer html --csp
In Chrome/Edge go to the extensions page (chrome://extensions or edge://extensions).
Enable Developer Mode.
Load the build/web directory to your browser.
Open new tab and check the text.
Instead of printing the version on screen, there's an error: FILE_NOT_FOUND in the console and it never shows the version.

If the same thing is done with a normal run of the project with flutter run web then it works perfectly. It just doesn't work on web builds deployed as browser extension.
According to the error in. the console, it seems like the base uri for version.json file is incorrect in this case.
Code Sample
### main.dart

import 'package:flutter/material.dart';
import 'package:package_info_plus/package_info_plus.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: Center(
          child: MyWidget(),
        ),
      ),
    );
  }
}

class MyWidget extends StatefulWidget {
  const MyWidget({super.key});

  @override
  State<MyWidget> createState() => _MyWidgetState();
}

class _MyWidgetState extends State<MyWidget> {
  String? version;

  @override
  void initState() {
    super.initState();
    fetchVersion();
  }

  @override
  Widget build(BuildContext context) {
    return Text(
      version ?? 'Loading...',
      style: Theme.of(context).textTheme.headline4,
    );
  }

  Future<void> fetchVersion() async {
    final PackageInfo info = await PackageInfo.fromPlatform();
    setState(() => version = info.version);
  }
}

### web/manifest.json

```json
{
  "name": "Test Project",
  "description": "A is a description.",
  "version": "0.1.1",
  "manifest_version": 3,
  "short_name": "test",
  "content_security_policy": {
    "content_security_policy": {
      "extension_pages": "script-src 'self' ; object-src 'self'"
    }
  },
  "chrome_url_overrides": {
    "newtab": "index.html"
  },
  "icons": {
    "128": "icon128.png"
  }
}

### Logs

```shell
GET chrome-extension://nfdiokdbeccelflpphpogdaendmlkfoi/index.html/version.json?cachebuster=1671427592603 net::ERR_FILE_NOT_FOUND

Flutter Doctor
[✓] Flutter (Channel stable, 3.3.10, on macOS 13.1 22C65 darwin-arm, locale en-IN)
    • Flutter version 3.3.10 on channel stable at /Users/birjuvachhani/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 135454af32 (4 days ago), 2022-12-15 07:36:55 -0800
    • Engine revision 3316dd8728
    • Dart version 2.18.6
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc1)
    • Android SDK at /Users/birjuvachhani/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc1
    • Java binary at: /Users/birjuvachhani/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/birjuvachhani/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9014738/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] Android Studio (version 2021.3)
    • Android Studio at /Users/birjuvachhani/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/213.7172.25.2113.9123335/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] IntelliJ IDEA Community Edition (version 2022.2.3)
    • IntelliJ at /Users/birjuvachhani/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/222.4345.14/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Community Edition (version 2022.3)
    • IntelliJ at /Users/birjuvachhani/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/223.7571.182/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.74.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.1 22C65 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 108.0.5359.124

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Checklist before submitting a bug

[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I'm using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

Commenting to keep it active!

I'm facing the same issue when I deploy a flutter app as a CDN resource, i.e. just a <script> element pointing to an external http url. It turns out the culprit is a window.document.baseUri in method getAll of PackageInfoPlusWebPlugin. Obviously it won't work unless both <script> and ` elements point to the same source, which in my case it's not the point.
It would be nice to have a way to parameterize that baseUri, but I can't think of how it can fit in the platform agnostic interface. If I find a workaround I'll post it here.

Commenting to keep this from becoming stale!

Commenting AGAIN to keep this from becoming stale!

It would be nice to have a way to parameterize that baseUri, but I can't think of how it can fit in the platform agnostic interface. If I find a workaround I'll post it here.

Would be providing an optional parameter in static Future<PackageInfo> fromPlatform() with the custom version.json url enough to bypass this issue?
(same as I asked here: https://github.com/fluttercommunity/plus_plugins/issues/2732#issuecomment-2006489027)

Hi, in this PR https://github.com/fluttercommunity/plus_plugins/pull/2733 there is a potential fix for this issue. It has been merged to main, so before we do a release, I'd like to know if it solves your issue. Could you try the package using a git-reference? https://dart.dev/tools/pub/dependencies#git-packages

Seems to be working! Thanks!

I checked with the latest version of packge_info_plus and it is working for me with the example code I gave above. I checked with your branch but I am not able to compile and run.
Dependency
dependencies:
  package_info_plus:
    git:
      url: https://github.com/AriasBros/plus_plugins.git
      path: packages/package_info_plus/package_info_plus
      ref: fix/issue-2732

Error
Target dart2js failed: ProcessException: Process exited abnormally with exit code 1:
../../../.pub-cache/git/plus_plugins-26bea2216715fdeed0d3f852573acd7d5c6219fd/packages/package_info_plus/package_info_plus/lib/package_info_plus.dart:81:7:
Error: No named parameter with the name 'baseUrl'.
      baseUrl: baseUrl,
      ^^^^^^^
Error: Compilation failed.
  Command: /Users/birjuvachhani/flutter/bin/cache/dart-sdk/bin/dart --disable-dart-dev
  /Users/birjuvachhani/flutter/bin/cache/dart-sdk/bin/snapshots/dart2js.dart.snapshot
  --platform-binaries=/Users/birjuvachhani/flutter/bin/cache/flutter_web_sdk/kernel --invoker=flutter_tool -Ddart.vm.product=true
  -DFLUTTER_WEB_AUTO_DETECT=false -DFLUTTER_WEB_USE_SKIA=false
  -DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/a5c24f538d05aaf66f7972fb23959d8cafb9f95a/ --native-null-assertions --no-source-maps -o
  /Users/birjuvachhani/Documents/Projects/untitled3/.dart_tool/flutter_build/d5f3922e26da14c3f02eea3a334d2b37/app.dill --packages=.dart_tool/package_config.json
  --cfe-only /Users/birjuvachhani/Documents/Projects/untitled3/.dart_tool/flutter_build/d5f3922e26da14c3f02eea3a334d2b37/main.dart

You'll have to do the same with the package_info_plus_platform_interface included in the same repo, becauas the platform call method signature changed.

Ah! I see. That makes sense! I tried that and it seems to be working just fine!

Thanks a lot for checking @BirjuVachhani !
Can I ask, did you use the baseUrl param? What value did you pass in the chrome extension? If you can show that, I want to understand better how this can be used for a chrome extension project.

authors: BirjuVachhani jglatre miquelbeltran

license_source: bigquery


text:
[Bug]: Not Capturing Internet Status properly sometimes

Platform
Android 14
Plugin
connectivity_plus
Version
3.0.2
Flutter SDK
3.22.1
Steps to reproduce
I am using dio package for making http requests & Before sending any requests - I am checking whether App is connected with Internet with connectivity_plus package by condition, if it is not connected - it wont allow to send the request by throwing any exception.
But Sometimes, it is failing to capture the network connectivity issue - allowing the app to send request & getting the dio exception from server.

Code Sample
try {
      if (await _internetStatus.isConnected()) {
        "send any request"
        }
      } else {
        return Left(Failure.noInternet()); //Failure.noInternet()
      }
    } catch (error) {
      logger.i('error: ${error.toString()}');
      return Left(_errorHandler.handleError(error));
    }

In my _errorHandler.handleError(error)) method, I am handling & returning all kinds of request errors - connectTimeout, sendTimeout, receiveTimeout, response, cancel, other. Only if it other => it throws the unknows error message which is receiving exception message from Server

Logs
SocketException: Connection failed(OS Error: Network is unreachable, errno = 101), address = ..., port...)

Flutter Doctor
flutter doctor -v
[√] Flutter (Channel stable, 3.22.1, on Microsoft Windows [Version 10.0.22631.3810], locale en-IN)
    • Flutter version 3.22.1 on channel stable at C:\Users\Chandrasekar\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision a14f74ff3a (7 weeks ago), 2024-05-22 11:08:21 -0500
    • Engine revision 55eae6864b
    • Dart version 3.4.1
    • DevTools version 2.34.3

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\Chandrasekar\AppData\Local\Android\Sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = C:\Users\Chandrasekar\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio3\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0--11609105)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.8.3)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.8.34330.188
    • Windows 10 SDK version 10.0.22621.0

[√] Android Studio (version 2024.1)
    • Android Studio at C:\Program Files\Android\Android Studio3
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0--11609105)

[√] IntelliJ IDEA Community Edition (version 2023.2)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2023.2.2
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart

[√] VS Code (version 1.91.0)
    • VS Code at C:\Users\Chandrasekar\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.92.0

[√] Connected device (4 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 13 (API 33) (emulator)
    • Windows (desktop)            • windows       • windows-x64    • Microsoft Windows [Version 10.0.22631.3810]
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 126.0.6478.127
    • Edge (web)                   • edge          • web-javascript • Microsoft Edge 126.0.2592.87

[√] Network resources
    • All expected network resources are available.

• No issues found!

Checklist before submitting a bug

[X] I searched issues in this repository and couldn't find such bug/problem
[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I'm using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

connectivity_plus is currently at version 6, and you are using version 3.
Secondly, as explained in the README, the package will only report if a connection is available as reported by the OS, but it won't warranty that this connection is indeed working or not.

authors: ChanduDA miquelbeltran


text:
util/release: Support exporting images

Incremental patch for #617

Does this dump just the version we want of each image? Or all images in the "repo"?

@titanous previously it would dump the "latest" tag of each of the images in the manifest, but I have now updated it to explicitly tag the images for the export (like the upload currently does).

LGTM

authors: lmars titanous

repo: flynn/flynn


text:
Upgrading flyway from 3.2.1 to 4.0.3 - repeatable migrations DB2 index error

What version of Flyway are you using?
4.0.3
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)
Command-line
What database are you using (type & version)?
DB2 LUW 10.5
What operating system are you using?
Windows 10
What did you do?
(Please include the content causing the issue, any relevant configuration settings, and the command you ran)
I'm trying out the new repeatable migrations, but there appears to still be a unique index on the flyway version table.  This causes flyway migrate to fail with ERROR: Unable to insert row for version 'null' in metadata table
The offending index appears to be:
CREATE UNIQUE INDEX DATA_ACCESS."FLYWAY_VERSION_pk"   ON DATA_ACCESS.FLYWAY_VERSION     ( "version" ASC )   ALLOW REVERSE SCANS   COMPRESS NO   INCLUDE NULL KEYS;
What did you expect to see?
flyway migrate working successfully
What did you see instead?
ERROR: Unable to insert row for version 'null' in metadata table

No idea how you got this. We actually properly drop the primary key constraint during the upgrade. See https://github.com/flyway/flyway/blob/master/flyway-core/src/main/resources/org/flywaydb/core/internal/dbsupport/db2/upgradeMetaDataTable.sql#L20
Did we miss something?

I'm not sure, our metadata table has been around since version 2, I thought that maybe at some point the Index was also created by the code.  Our current production DB which is still using flyway 2.1.1 has three indexes TABLE_pk, TABLE_vr_idx, TABLE_ir_idx, TABLE_s_idx.  The TABLE_pk is a unique index and has to be dropped even though the constraint on the table was changed.  That's what I did to fix it, but I thought that it might be good to check for it during the migrate.

We do not plan anymore to fix this. If this is still an issue, please drop your metadata table and rebaseline your schema with the new Flyway version.

authors: axelfontaine garrmark

repo: flyway/flyway


text:
Compare against List for shouldExecute

Which version and edition of Flyway are you using?
7.3.1 Teams
If this is not the latest version, can you reproduce the issue with the latest one as well? (Many bugs are fixed in newer releases and upgrading will often resolve the issue)
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Command-line
Which database are you using? (Type & version)
MSSQL 2014
Which operating system are you using?
Linux
What did you do? (Please include the content causing the issue, any relevant configuration settings, the SQL statement(s) that failed (if any), and the command you ran)
We're trying to find a way to use the shouldExecute migration precondition in our multi-tenant environment.  We have about 300 copies of the database and occasionally need to roll out changes to the database selectively.  For example, we may to go 1, then 5, then 10, then 25, etc.  Today we're accomplishing this with very unconventional SQL scripts.  If we're able to do some kind of contains or list comparison in shouldExecute, it would make this much better.  Is that possible or is it only ==?
Each of our 300 databases are associated with a store code.  What we'd like to do is have a store code placeholder that we then use in the shouldExecute.  In the example above, the first time would look something like
shouldExecute={StoreCode}==1

where it would only run for StoreCode 1.  Then
shouldExecute={StoreCode}==1,2

where it would only run for StoreCodes 1 and 2.  Of course == wouldn't work in this case, but is there something that would?
What did you expect to see?
What did you see instead?

Are AND and OR supported within there?  If they are, an option could be
shouldExecute={StoreCode}==1 OR {StoreCode}==2

Are AND and OR supported within there?  If they are, an option could be
shouldExecute={StoreCode}==1 OR {StoreCode}==2

At the moment none of these are supported, but adding support for a list of values which is effectively shorthand for OR seems like a nice addition

At the moment none of these are supported, but adding support for a list of values which is effectively shorthand for OR seems like a nice addition

How long would you estimate until we'll see this?  Trying to determine if we should come up with our own work around or not.

How long would you estimate until we'll see this?  Trying to determine if we should come up with our own work around or not.

Support for more extensive boolean expressions in shouldExecute will be available from the next release:)

Support for more extensive boolean expressions in shouldExecute will be available from the next release:)

When do you expect the next release?

When do you expect the next release?

While we make no guarantees, we aim to release every week or so

While we make no guarantees, we aim to release every week or so

authors: DoodleBobBuffPants esauser


text:
flyway-core depends on jackson: fails if not present

Which version and edition of Flyway are you using?
Version 9.19.2
If this is not the latest version, can you reproduce the issue with the latest one as well? (Many bugs are fixed in newer releases and upgrading will often resolve the issue)
yes
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
flyway-core java API
Which database are you using? (Type & version)
postgresql
Which operating system are you using?
linux
What did you do? (Please include the content causing the issue, any relevant configuration settings, the SQL statement(s) that failed (if any), and the command you ran)
upgraded flyway-core from 9.19.1 to 9.19.4
this excerpt reproduces the problem
final Flyway flyway = Flyway
                .configure()
                .configuration(Map.of("flyway.postgresql.transactional.lock", "false"))
                .load();

What did you expect to see?
Expected flyway-core to work normally, even if jackson is not present
What did you see instead?
Exception in thread "main" java.lang.NoClassDefFoundError: com/fasterxml/jackson/databind/ObjectMapper
	at org.flywaydb.core.api.configuration.ClassicConfiguration.determineKeysToRemoveAndRemoveFromProps(ClassicConfiguration.java:1910)
	at org.flywaydb.core.api.configuration.ClassicConfiguration.configure(ClassicConfiguration.java:1479)
	at org.flywaydb.core.api.configuration.FluentConfiguration.configuration(FluentConfiguration.java:959)
	at org.example.Main.main(Main.java:11)
Caused by: java.lang.ClassNotFoundException: com.fasterxml.jackson.databind.ObjectMapper
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
	... 4 more

This seems similar to https://github.com/flyway/flyway/issues/3672. jackson is marked as optional on the pom.xml. Also why is two different json libraries being used ?

And the two different json libraries being used thing will also be taken care of.

authors: JasonLuo-Redgate froque


text:
JDBC escape syntax support

I recently upgraded from flyway 3.0 to version 3.1. In my sql scripts I use something like that:
insert into testDate values ({ts '2015-01-01 00:00:00'});

This doens't work with Flyway 3.1 anymore (postgresql 9.2-1002.jdbc4):
Caused by: org.flywaydb.core.internal.dbsupport.FlywaySqlScriptException:
Migration V1.0.0__foo.sql failed
----------------------------------------------------------------------------------------
SQL State  : 42601
Error Code : 0
Message    : ERROR: syntax error at or near "{"

	at org.flywaydb.core.internal.dbsupport.SqlScript.execute(SqlScript.java:117)
	at org.flywaydb.core.internal.resolver.sql.SqlMigrationExecutor.execute(SqlMigrationExecutor.java:71)
	at org.flywaydb.core.internal.command.DbMigrate$5.doInTransaction(DbMigrate.java:287)
	at org.flywaydb.core.internal.command.DbMigrate$5.doInTransaction(DbMigrate.java:285)
	at org.flywaydb.core.internal.util.jdbc.TransactionTemplate.execute(TransactionTemplate.java:72)
	at org.flywaydb.core.internal.command.DbMigrate.applyMigration(DbMigrate.java:285)
	at org.flywaydb.core.internal.command.DbMigrate.access$800(DbMigrate.java:46)
	at org.flywaydb.core.internal.command.DbMigrate$2.doInTransaction(DbMigrate.java:207)
	at org.flywaydb.core.internal.command.DbMigrate$2.doInTransaction(DbMigrate.java:156)
	at org.flywaydb.core.internal.util.jdbc.TransactionTemplate.execute(TransactionTemplate.java:72)
	at org.flywaydb.core.internal.command.DbMigrate.migrate(DbMigrate.java:156)
	at org.flywaydb.core.Flyway$1.execute(Flyway.java:972)
	at org.flywaydb.core.Flyway$1.execute(Flyway.java:919)
	at org.flywaydb.core.Flyway.execute(Flyway.java:1320)
	at org.flywaydb.core.Flyway.migrate(Flyway.java:919)
	at de.debeka.aktuariatlv.augur.databaseservice.migration.DatabaseMigration.migrateSchema(DatabaseMigration.java:102)
	... 26 more
Caused by: org.postgresql.util.PSQLException: ERROR: syntax error at or near "{"
  Position: 120
	at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2157)
	at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:1886)
	at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:255)
	at org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:555)
	at org.postgresql.jdbc2.AbstractJdbc2Statement.executeWithFlags(AbstractJdbc2Statement.java:403)
	at org.postgresql.jdbc2.AbstractJdbc2Statement.execute(AbstractJdbc2Statement.java:395)
	at org.flywaydb.core.internal.dbsupport.JdbcTemplate.executeStatement(JdbcTemplate.java:238)
	at org.flywaydb.core.internal.dbsupport.SqlScript.execute(SqlScript.java:114)
	...

Closing as upon further consideration I do not wish to expose this jdbc-specific syntax.

Does this mean, that the jdbc syntax is gone forever? I already created over 100 database scripts for our current productive database. Your decision would force me to stick with flyway 3.0 forever...

Ok. I finally fixed my flyway scripts...

authors: axelfontaine maroonyw


text:
Support option to use Slf4j/Commons Logging/JUL when using the command line tool

Please see issue #1075

I ended up implementing it with an automatic switch instead.
Cheers
Axel

authors: axelfontaine ericparton


text:
MBS dependency

Great idea - let's just remove the dependency on the MBS plugin ;-)

and done.

It turned out, that the next serial value is not transferred in a migration – which makes total sense, as the current auto increment is in the domain of the source/production file and should not be changed. Nevertheless, we are able to push way more than 255k into the default value – check out the new version.

authors: mrwatson-de nilswald

repo: fmgarage/ft-buildinfo


text:
🛑 Site nxtc is down

In 8236c19, Site nxtc ($SECRET_SITE_2) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Site nxtc is back up in 198e5f0.

repo: fmmaia/fmAtAllUptime


text:
Swapping iPhone and iPad device order to work for older Ipads

It's not really clear why the original device list had Iphone ahead of Ipad, but the net effect is that because Iphone comes first, anything that has iPhone--which includes iPad devices on old OS versions--while the reverse should affect nothing (e.g. no iPhone UA has ever had iPad in it).
I'm ambivalent about the extra test (or the ua.yml addition), but does break on 2.3.0, and is fixed with this PR. Pretty open to any suggestions or advice, if you have any! 🍻

Hello, @slpsys! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

Merged directly on master (I had to rebase your branch to make that failing test pass).

any chance of a release soon?

Just released v2.4.0.

Good lord, that was blindingly fast. Thanks, @fnando 🏆

authors: apurvis fnando slpsys

repo: fnando/browser


text:
🛑 Contaboo is down

In a58113f, Contaboo (https://contabo.com) was down:

HTTP code: 403
Response time: 406 ms

Resolved: Contaboo is back up in 5fccc82 after 5 hours, 11 minutes.

repo: fnzv/status


text:
🛑 Contaboo is down

In c447451, Contaboo (https://contabo.com) was down:

HTTP code: 403
Response time: 457 ms

Resolved: Contaboo is back up in 63cad90 after 44 minutes.


text:
Port the olympic demo, FilterController, etc.

This includes all the various core changes, and some bugs I exposed in the process.

A general comment about the full-text search: we don't actually support aliases right now. There's a TODO for it in the query parser. Should we add that now(ish)?


text:
Add authentication to groupDAO

groupDAO must be authenticated so users are not allowed to give themselves new permissions.
It will need custom authentication so that users will be allowed to create new groups, but only give those groups permissions that they already have.

Closed by https://github.com/foam-framework/foam2/pull/1615


text:
Box pipeline

Add support for composing box Runnables into a pipelines. Merging + forking pipeline parts is supported, but cycles are not. Each Runnable is registered once as a box service; overriding registry in context allows for creating multiple workers and picking one for units of work.
Tests coming soon.
Example script:
require('./src/foam.js');
require('./src/foam/nanos/nanos.js');
foam.CLASS({ name: 'MyInt', properties: [ { class: 'Int', name: 'value' } ] });
foam.CLASS({
  name: 'SquareIt',
  extends: 'foam.box.Runnable',

  methods: [
    function run(x) {
      this.output(MyInt.create({ value: x.value * x.value }));
    }
  ]
});
foam.CLASS({
  name: 'AddOne',
  extends: 'foam.box.Runnable',

  methods: [
    function run(x) {
      this.output(MyInt.create({ value: x.value + 1 }));
    }
  ]
});
var ctx = foam.box.Context.create();
// ctx = ctx.__subContext__.createSubContext({
//   registry: foam.box.LogBox.create({ name: 'registry', delegate: ctx.registry }, ctx)
// });

// Construct:
// ^2 --           -- ^2
//       >-- ^2 --<
// +1 --           -- +1

var builder = foam.box.pipeline.PipelineBuilder.create(null, ctx);
var shared = builder.then(SquareIt.create());
shared.then(SquareIt.create());
shared.then(AddOne.create());
var squareItFirst = builder.first(SquareIt.create()).build();
var addOneFirst = builder.first(AddOne.create()).build();

var initialMessage = foam.box.Message.create({
  object: MyInt.create({ value: 2 })
});

var boxes = builder.buildAll();

//      -- ^2 --          -- ^2
// 2 --<        >-- ^2 --<
//      -- +1 --          -- +1
//
// ==> 256
// ==> 17
// ==> 81
// ==> 10
boxes[0].send(initialMessage);
boxes[1].send(initialMessage);

@m-cheung PTAL at latest commit. Is this the right fix to the issue we discussed offline?


text:
Instruct Users to update path in terminal script.

This program doesn't work if you install it outside the path you suggest.
For instance I have a path that is $git which is where I installed mine.
It might help some people if you tell them to update the path in the terminalscript.
Also this is mostly functional on macOS.
Simply use homebrew to install pv sox and cool-retro-terminal.
Then either link the binary in the cool-retro-terminal app itself to /usr/local.bin or create an alias in in your zshrc/bashrc.
That being said I am running in to an issue saving and viewing entries so I'm trying to debug that.
Other than that great job. Thanks for the fun app.

BASE_DIR="$(cd "$(dirname "$0")"; pwd)" || exit 2

$BASE_DIR replace $HOME/Fallout3Terminal

The user above, @yangxuanx has kindly updated the script to be able to run anywhere. Apologies for not being as diligent! I had no idea you could even clone to a different directory. Would you mind trying it out now? It works okay for me.

I did try the suggestion above, for some reason I received errors, which is strange because it showed the correct path for the resources but the program said it couldn't be found. I'll try again later and see if I can't get it sorted out.

Thank you for notifying me. It seems to run fine when I run it from anywhere on my computer. Perhaps you are missing a package? Like sox or pv? Do keep me updated, thanks!

Try deleting everything and cloning the git again if you haven't. The new updated script is in there as a new commit

authors: fohtla typkrft yangxuanx


text:
[MODFISTO-405] - error response processing

Purpose

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.

Does this PR meet or exceed the expected quality standards?

[ ] Code coverage on new code is 80% or greater
[ ] Duplications on new code is 3% or less
[ ] There are no major code smells or security issues

Does this introduce breaking changes?

[ ] Were any API paths or methods changed, added or removed?
[ ] Were there any schema changes?
[ ] Did any of the interface versions change?
[ ] Were permissions changed, added or removed?
[ ] Are there new interface dependencies?
[ ] There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

What other modules will these changes impact?
Do JIRAs exist to update the impacted modules?

[ ] If not, please create them
[ ] Do they contain the appropriate level of detail?  Which endpoints/schemas changed, etc.
[ ] Do they have all the appropriate links to blocked/related issues?

Are the JIRAs under active development?

[ ] If not, contact the project's PO and make sure they're aware of the urgency.

Do PRs exist for these changes?

[ ] If so, have they been approved?

Did you modify code to call some additional endpoints?

[ ] If so, do you check that necessary module permission added in ModuleDescriptor-template.yaml file?

Ideally, all the PRs involved in breaking changes would be merged on the same day
to avoid breaking the folio-testing environment.
Communication is paramount if that is to be achieved,
especially as the number of inter-module and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems,
ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

repo: folio-org/mod-finance-storage


text:
UIMARCAUTH-19: Implement Results List Sort options

UIMARCAUTH-19 Authorities Search > Sort options
Purpose

Implement selection by sort options
Add tests

Issue: UIMARCAUTH-19
Approach
Before sorting on backend is not presented, sorting implementing on frontend side. It should be removed in future.
Also was added template for fetch data with sort options.
Screenshots

yarn run v1.22.15
$ eslint .
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/components/SearchResultsList/SearchResultsList.js
91:3  error  Expected exception block, space or tab after '//' in comment  spaced-comment
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/constants/sortOrders.js
3:20  error  Missing trailing comma  comma-dangle
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/views/AuthoritiesSearch/AuthoritiesSearch.js
178:5   error  Expected exception block, space or tab after '//' in comment  spaced-comment
180:1   error  Trailing spaces not allowed                                   no-trailing-spaces
187:11  error  Redundant double negation                                     no-extra-boolean-cast
✖ 5 problems (5 errors, 0 warnings)
5 errors and 0 warnings potentially fixable with the --fix option.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

yarn run v1.22.15
$ eslint .
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/components/SearchResultsList/SearchResultsList.js
91:41  error  Trailing spaces not allowed  no-trailing-spaces
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/views/AuthoritiesSearch/AuthoritiesSearch.js
201:5   warning  Unexpected console statement                                           no-console
204:5   error    Expected an assignment or function call and instead saw an expression  no-unused-expressions
206:26  error    Trailing spaces not allowed                                            no-trailing-spaces
✖ 4 problems (3 errors, 1 warning)
2 errors and 0 warnings potentially fixable with the --fix option.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

yarn run v1.22.15
$ eslint .
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/views/AuthoritiesSearch/AuthoritiesSearch.js
204:35  error  Missing semicolon  semi
✖ 1 problem (1 error, 0 warnings)
1 error and 0 warnings potentially fixable with the --fix option.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

yarn run v1.22.15
$ eslint .
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/hooks/useSortColumnManager.js
3:28  error  Strings must use singlequote  quotes
✖ 1 problem (1 error, 0 warnings)
1 error and 0 warnings potentially fixable with the --fix option.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

yarn run v1.22.15
$ eslint .
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/components/SearchFilters/SearchFilters.js
53:6  warning  React Hook useCallback has a missing dependency: 'setFilters'. Either include it or remove the dependency array. If 'setFilters' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/components/SearchResultsList/SearchResultsList.js
23:3  error    Prop types declarations should be sorted alphabetically                                                                react/sort-prop-types
24:3  error    Prop types declarations should be sorted alphabetically                                                                react/sort-prop-types
25:3  error    Prop types declarations should be sorted alphabetically                                                                react/sort-prop-types
26:3  error    Duplicate key 'loading'                                                                                no-dupe-keys
26:3  error    Prop types declarations should be sorted alphabetically                                                                react/sort-prop-types
27:3  error    Prop types declarations should be sorted alphabetically                                                                react/sort-prop-types
28:3  error    Duplicate key 'onNeedMoreData'                                                                                no-dupe-keys
28:3  error    Prop types declarations should be sorted alphabetically                                                                react/sort-prop-types
29:3  error    Duplicate key 'pageSize'                                                                                no-dupe-keys
111:5  warning  React Hook useMemo has missing dependencies: 'loaded' and 'query'. Either include them or remove the dependency array  react-hooks/exhaustive-deps
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/components/SearchResultsList/SearchResultsList.test.js
11:3  error  'sortOrders' is defined but never used  no-unused-vars
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/hooks/useSortColumnManager/useSortColumnManager.js
28:1  error  Trailing spaces not allowed  no-trailing-spaces
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/queries/useAuthorities/useAuthorities.js
11:10  error  'buildSearch' is defined but never used  no-unused-vars
64:49  error  Missing semicolon                        semi
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/views/AuthoritiesSearch/AuthoritiesSearch.js
144:6  warning  React Hook useEffect has missing dependencies: 'history' and 'location.pathname'. Either include them or remove the dependency array  react-hooks/exhaustive-deps
✖ 16 problems (13 errors, 3 warnings)
8 errors and 0 warnings potentially fixable with the --fix option.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

yarn run v1.22.15
$ eslint .
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/components/SearchFilters/SearchFilters.js
53:6  warning  React Hook useCallback has a missing dependency: 'setFilters'. Either include it or remove the dependency array. If 'setFilters' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/components/SearchResultsList/SearchResultsList.js
108:5  warning  React Hook useMemo has missing dependencies: 'loaded' and 'query'. Either include them or remove the dependency array  react-hooks/exhaustive-deps
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/components/SearchResultsList/SearchResultsList.test.js
11:3  error  'sortOrders' is defined but never used  no-unused-vars
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/hooks/useSortColumnManager/useSortColumnManager.js
28:1  error  Trailing spaces not allowed  no-trailing-spaces
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/queries/useAuthorities/useAuthorities.js
14:3  error  'sortOrders' is defined but never used  no-unused-vars
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/queries/useAuthorities/useAuthorities.test.js
82:57  error  Unnecessary escape character: "  no-useless-escape
82:63  error  Unnecessary escape character: "  no-useless-escape
95:57  error  Unnecessary escape character: "  no-useless-escape
95:63  error  Unnecessary escape character: "  no-useless-escape
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/views/AuthoritiesSearch/AuthoritiesSearch.js
150:6  warning  React Hook useEffect has missing dependencies: 'history' and 'location.pathname'. Either include them or remove the dependency array  react-hooks/exhaustive-deps
✖ 10 problems (7 errors, 3 warnings)
1 error and 0 warnings potentially fixable with the --fix option.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

yarn run v1.22.15
$ eslint .
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/components/SearchFilters/SearchFilters.js
53:6  warning  React Hook useCallback has a missing dependency: 'setFilters'. Either include it or remove the dependency array. If 'setFilters' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/components/SearchResultsList/SearchResultsList.js
108:5  warning  React Hook useMemo has missing dependencies: 'loaded' and 'query'. Either include them or remove the dependency array  react-hooks/exhaustive-deps
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/components/SearchResultsList/SearchResultsList.test.js
11:3  error  'sortOrders' is defined but never used  no-unused-vars
/home/jenkins/workspace/io-org_ui-marc-authorities_PR-38/project/src/views/AuthoritiesSearch/AuthoritiesSearch.js
150:6  warning  React Hook useEffect has missing dependencies: 'history' and 'location.pathname'. Either include them or remove the dependency array  react-hooks/exhaustive-deps
✖ 4 problems (1 error, 3 warnings)
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

authors: Vladyslav-Velytskyi id-jenkins

repo: folio-org/ui-marc-authorities


text:
Wrong parameter name in index.d.ts (radius -> raduis)

Bug Report
Wrong parameter name in the typescript documentation
Description of the problem
inside doc.circle(), parameter radius is misspelled as raduis
Your environment

pdfkit version: ^0.12.1

This is not directly related to PDFKit.
It's a problem related to @types/pdfkit package -> https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/pdfkit

repo: foliojs/pdfkit


text:
PDF image using Uint8Array throws an error

Bug Report
Description of the problem
I am using an image as the Uint8Array that is downloaded from AWS.
doc.image throws the error:
TypeError [ERR_INVALID_ARG_VALUE]: The argument 'path' must be a string or Uint8Array without null bytes. Received Uint8Array(1239071)
The buffer is Uint8Array  as console.log(jpgBuffer instanceof Uint8Array) returns true;
Code sample

const jpgBuffer: Uint8Array = await response.Body.transformToByteArray();
console.log(jpgBuffer instanceof Uint8Array); // true
doc.image(jpgBuffer, 50, 45, { width: 50 });
Your environment

pdfkit version: ^0.13.0
Node version: 16.13.1
Browser version (if applicable):
Operating System: MacOs 13.3.1

@chrishj59
I had the same issue when fetching an image from s3.
Had to create a buffer from the Uint8Array before handing it over to doc.image
const object: GetObjectCommandOutput | undefined = await getImageFromS3(imageName);

const byteArray: Uint8Array | undefined = object?.Body.transformToByteArray();

if (byteArray) {
    const buffer = Buffer.from(byteArray);
    doc.image(buffer);
}