text:
chore: add onDismiss handler for TaxPicker

Details

Add onDismiss handler for TaxPicker
Fixed Issues

$ https://github.com/Expensify/App/issues/42854
PROPOSAL: https://github.com/Expensify/App/issues/42854#issuecomment-2142207131
Tests

Go to the app
Go to workspace settings
Go to Taxes (enable it if not enabled)
Click Settings
Click Workspace currency default
Click on the selected tax rate

App will not unselect the tax rate since Workspace currency default must have a tax rate.  No error happens

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to the app
Go to workspace settings
Go to Taxes (enable it if not enabled)
Click Settings
Click Workspace currency default
Click on the selected tax rate

App will not unselect the tax rate since Workspace currency default must have a tax rate.  No error happens

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.webm

Android: mWeb Chrome

aweb.webm

iOS: Native

https://github.com/Expensify/App/assets/165644294/5ce753e6-6863-4a2f-ba32-8ba6248e0885

iOS: mWeb Safari

https://github.com/Expensify/App/assets/165644294/a0c62504-5852-4578-958e-9240a460dd79

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/165644294/09ad5795-9e73-42d7-be0d-5c479cc04acd

MacOS: Desktop
https://github.com/Expensify/App/assets/165644294/40f98afe-83ee-46c7-9f30-318c8cbfb8c6

This code should also be removed on this PR
https://github.com/Expensify/App/blob/2144fc6a9f8df9f3678c2c80928b2cff847e9953/src/pages/iou/request/step/IOURequestStepTaxRatePage.tsx#L88-L91

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@dominictb There are some minor comments. Please address it. Everything else is fine

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.85-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.85-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.85-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.85-7 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

authors: DylanDylann OSBotify dominictb


text:
fix: no error message for incorrect validation amounts

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/45246
PROPOSAL: https://github.com/Expensify/App/issues/45246#issuecomment-2224624886
Tests

Pre-requisite: Have a workspace that enabled workflows.

Go to Settings > Workspaces > Workspace > Workflows > Connect bank account > Connect manually
Go trough the add bank account process
In "Validate your bank account" page, enter 3 random amounts
Press Validate
Verify an error message says The validation amounts you entered are incorrect. Please double-check your bank statement and try again.

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Same as Tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

https://github.com/user-attachments/assets/1a1abda2-bf33-4486-bb8b-1735f1f52618

iOS: Native

https://github.com/user-attachments/assets/2014ab9e-56a4-4859-99a5-90cb22f39347

iOS: mWeb Safari

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/5946cbf7-a1dc-4e36-9081-3105ef68206a

MacOS: Desktop

little bumo @youssef-lr

@tienifr can you merge main?

@youssef-lr Should be ready again for your final review 😄

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.0.15-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.15-9 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

source: gharchive/pull-request

authors: OSBotify hungvu193 tienifr youssef-lr

repo: Expensify/App

license: MIT

license_type: permissive

license_source: github-api


text:
Block system user from Inviting into Workspace

Details

Block system users from inviting into Workspace.
Fix a silly mistake where users can invite existing multiple users (https://github.com/Expensify/App/pull/4510).
Fix users can invite existing users with phone number login.
Fix copy to show that multiple users can be invited.

Fixed Issues

$ #4646
Tests | QA Steps

Open any workspaces Settings on NewDot.
Open Invite People page.

Test 1

Try to invite System users (chronos@, receipts@, and concierge@).

Test 2

try to invite multiple users(more than one) who already exist in workspaces.

Test 3

Check the copy on the page, it should show that you can invite multiple users.

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web | Desktop | Mobile Web

iOS

Android

Please check the copy text. Let me know what would be the correct one and their translations.

Getting some copy reviewed in the linked issue. However, in it's current state I don't think we'll want User to be capitalized.

Do you think the label and placeholder are correct for the email input?

Do you think the label and placeholder are correct for the email input?

I think Emails or Phones should be Emails or phone numbers

OK. It will look like this with numberoflines 2  after #4649 is merged.

Okay. This PR is not urgent so let's HOLD on https://github.com/Expensify/App/pull/4649

@shawnborton Before we commit, I would like your feedback on the Changes to the Phone & email input here. https://github.com/Expensify/App/pull/4781#issuecomment-904298015

Looks good to me. It seems like with this issue here, we might end up changing this page a bit but I think we still need to go through the design phase first.
The only other feedback is that we should be consistent with how we capitalize the labels used in each textarea on this page. Let's just stick with sentence case?

@roryabraham https://github.com/Expensify/App/pull/4649 is merged. Let's move with this now. Thanks.

Okay, let me get the translations checked

🚀 Deployed to staging by @roryabraham in version: 1.0.88-3 🚀

platform
result

🤖 android 🤖
cancelled 🔪

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.0.90-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

authors: OSBotify parasharrajat roryabraham shawnborton


text:
fix: GBR is missing from the partially approved expense

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/52650
PROPOSAL: https://github.com/Expensify/App/issues/52650#issuecomment-2498865327
Tests

All new Gmail accounts are used
Workspace has an admin, member, and approver
"Add approvals" is enabled and the approver account is set as the approver

Member: Log in
Member: Navigate to the workspace chat
Member: Create two manual expenses with any amounts (amounts should be different)
Member: Open one of the expenses
Member: Put the expense on hold
Approver: Log in
Approver: Navigate to the workspace chat
Approver: Click on "Approve"
Approver: Approve just the pending amount
Verify that: In the LHN, GBR is displayed in chat report (green dot)

[x] Verify that no errors appear in the JS console

Offline tests

Same as tests
QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/d112b255-98fc-45ca-a5fe-d8ae8bb02778

Android: mWeb Chrome

https://github.com/user-attachments/assets/8702b6cd-7be2-493b-8668-8e4f0585207d

iOS: Native

https://github.com/user-attachments/assets/c4abbfd3-84fe-44ba-bfa6-270629927fbc

iOS: mWeb Safari

https://github.com/user-attachments/assets/517549a3-208c-49f4-9594-2e46b22c8202

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/03f19a22-2622-4735-8242-7bd13a64aa87

MacOS: Desktop

https://github.com/user-attachments/assets/46d6b19d-7652-46ad-8590-3f01e6e30f05

@nkdengineer Please update the test steps to reflect this change correctly

authors: DylanDylann nkdengineer


text:
Add login validation route back in NewDot

cc @NikkiWines
Details
Adds a login validation route that was removed in this PR, but should not have been.
Fixed Issues
$ https://github.com/Expensify/App/issues/6136
Tests

Log in to a validated account without any secondary logins in NewDot
Navigate to Settings > Profile and add a secondary login for an account that you have access to
Confirm the sent link routes you to NewDot not OldDot
Click on the link and confirm your secondary login is validated
Repeat steps 1 and 2
Click on Resend to resend the validation link to yourself
Repeat steps 3 and 4

QA Steps

Complete Test steps while logged into an account on NewDot.

For step 5 ensure you are logged into the account when you click on the link

Complete Test steps while logged into an account on NewDot.

For step 5 ensure you are logged out of the account when you click on the link

Tested On

[ ] Web
[ ] Mobile Web
[ ] Desktop
[x] iOS
[ ] Android

Tested this on iOS on a physical device and it worked 🎉

Updated!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @roryabraham in version: 1.1.13-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @Jag96 in version: 1.1.14-4 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

authors: OSBotify roryabraham


text:
[Improvement] Improve E.cash search for group chats

If you haven’t already, check out our contributing guidelines for onboarding!

Platform - version:  All
Problem
Search is frequently how I find a given chat. There are two main problems I currently have with it:

It doesn't work well for group chats. For example I can't type in Lauren Andrew in order to find my group chat with Lauren and Andrew.
It looks for the whole string that I type in to be a match, rather than looking at whether there is a matching user for each word. For example, when I search Alex Revelli nothing comes up because she she is listed as Alexandra Revelli. I would think that she would still show up because the second word in my search, Revelli is a match to her user.

Why is this important?
Easy search makes Expensify.cash an easier, lighter experience.
Solution
Update search to work as follows:

split search string on spaces
return all exact and partial matches to each string
order results by most recent message (meaning the most recent message posted in the chat)

Upwork Job link: https://www.upwork.com/jobs/~01ccd27d2ef43f2d7f

Hi @NicMendonca ,
I would like to work on this issue. Here is my proposal:
I found that search results are generated in ChatSwitcherView.updateSearch() function. I’m planning to modify the following for loop.
https://github.com/Expensify/Expensify.cash/blob/c0069cf6e2df94ba7c3a2c242cf9e6a9c82ddd30/src/pages/home/sidebar/ChatSwitcherView.js#L424-L451
I’m going to split search string on spaces and create an array of words.
isMatch condition should be changed such that our regex matches should work for all words from search string.
https://github.com/Expensify/Expensify.cash/blob/c0069cf6e2df94ba7c3a2c242cf9e6a9c82ddd30/src/pages/home/sidebar/ChatSwitcherView.js#L429
I have a question for ordering results. I see there is an existing ranking that ranks exact matches higher. Do you want me to preserve this ranking or should we order all matches by most recent message time? To implement this, I’m going to sort all search options  by most recent message time that is not available in this function. I need to pass that value somehow.

Hi @NicMendonca ,
I would like to work on this issue. Here is my proposal:
I found that search results are generated in ChatSwitcherView.updateSearch() function. I’m planning to modify the following for loop.
https://github.com/Expensify/Expensify.cash/blob/c0069cf6e2df94ba7c3a2c242cf9e6a9c82ddd30/src/pages/home/sidebar/ChatSwitcherView.js#L424-L451
I’m going to split search string on spaces and create an array of words.
isMatch condition should be changed such that our regex matches should work for all words from search string.
https://github.com/Expensify/Expensify.cash/blob/c0069cf6e2df94ba7c3a2c242cf9e6a9c82ddd30/src/pages/home/sidebar/ChatSwitcherView.js#L429
I have a question for ordering results. I see there is an existing ranking that ranks exact matches higher. Do you want me to preserve this ranking or should we order all matches by most recent message time? To implement this, I’m going to sort all search options  by most recent message time that is not available in this function. I need to pass that value somehow.

@tugbadogan Thanks! Please apply for the job directly through Upwork.
Also a note, we're waiting for other UI changes before we can hire for this job.

Hi @NicMendonca,
I've already apply through Upwork. My Upwork name is Fadime Tugba Oge.

Also a note, we're waiting for other UI changes before we can hire for this job.

No problem, thanks for letting me know. I'm happy to work on this issue later.

@tugbadogan as mentioned last week we did make some UI changes so you might want to give your initial proposal a second look.
Thanks!

Hi @NicMendonca, I created a pull request on top of the most recent UI changes. I fixed this issue and removed redundant regex patterns from the code.

source: gharchive/issue

authors: NicMendonca tugbadogan


text:
Adding newline in the middle of the text doesn't update cursor position on iOS

945c704 + iOS + Fabric
https://github.com/Expensify/react-native-live-markdown/assets/20516055/5d4af057-a45d-42f6-9764-3f892adfe32d

Also reproducible on RN 0.74:
https://github.com/Expensify/react-native-live-markdown/assets/20516055/3af11810-a815-4844-bd0a-4283d169645f

Works correctly on Paper:
https://github.com/Expensify/react-native-live-markdown/assets/20516055/63a12b88-7589-456e-ac00-75f2af57e824

It works correctly when I remove the following lines in App.tsx:
https://github.com/Expensify/react-native-live-markdown/blob/945c704278ece506bb484edbbb9091182b53cbbf/example/src/App.tsx#L102-L103

Still reproducible in RN 0.75, https://github.com/Expensify/react-native-live-markdown/issues/375#issuecomment-2154524921 still holds.

repo: Expensify/react-native-live-markdown


text:
MACE models and openMM OOM error

Hi everyone!
We have been experiencing memory leaks when running molecular dynamics simulations with models trained with physics-ml and using the physics-ml openMM interface. I am suspecting that this originates from the physics-ml openMM interface.
I have attached a zipped folder containing the simulation script (simulation.py), the input topology and coordinate file and the trained MACE model.
simulation.zip
best regards,
marcus

Thanks for posting this. Will have a look a now!
Just to check, it's a CUDA memory leak? and after how many steps roughly does it break?

Hey! so I tested this out and it doesnt seem to be failing at the same point (as I would expect from a memory leak). One time I ran it and it failed after a couple of mins ~2k steps and another I ran it and it ran for ~10k steps before failing. The gpu memory usage was constant for both of these until failure (screenshot below).
I also tested the model torchscript file physicsml_model.pt (which is created to be used in openMM) and I ran it (outside of openMM) with the initial positions for a while and the memory was stable as well.
My suspicion is: The error I saw when it failed once was from the neighbour list asking to allocate a lot of memory. This happens when there are a lot of edges (much more than what a usual point cloud would have). I suspect that at some point in the simulation there was an instability which lead to the positions being very close to each other resulting in a fully connected graph which doesnt fit on the gpu (this is also probably why this doesnt happen at the same number of steps).

Thank you, Ward! Yes, it is a GPU memory problem.

I ran the example you posted Marcus and I also ran into a CUDA memory issue where it tried to allocate 29.40 GiB of CUDA memory. I analysed the 28 frames which were saved before crashing and nothing seems suspicious in terms of the physics (see profile below).
I will do some more investigation and try and verify the behaviour Ward describes as that sounds a sensible suggestion as to the cause of the crash (kind of a "not a bug but a feature" situation in that the crash may be indicative of the model offering poor inference in some configurations of water molecules).

We have investigated this further and observed that in the frames before the GPU OOM error is thrown the temperature and potential energy increase dramatically. @AnnaPicha will post the plots in a minute.

Hi everyone!
Thanks a lot for taking a closer look at our issue.
As described in the script attached above by Marcus, we ran a simulation of a 125 molecules TIP3P waterbox with integration step 0.5 fs, using our "self trained" MACE model. After around 14K steps, we observe (as shown in the plot) a dramatic increase in temperature and energy. Note that the plot does not display the entire simulation but only starts at simulation step 14.220.

Im closing this now (hopefully the PBC fix should sort this out). If it's still persists, we can re-open it. Thanks everyone!

authors: AnnaPicha adambaskerville wardhaddadin1 wiederm

repo: Exscientia/physicsml


text:
🛑 PR Medialogia is down

In bb94a66, PR Medialogia (https://pr.mlg.ru) was down:

HTTP code: 0
Response time: 0 ms

Resolved: PR Medialogia is back up in 73d5fb1 after 7 minutes.


text:
🛑 PR Medialogia is down

In 9da856d, PR Medialogia (https://pr.mlg.ru) was down:

HTTP code: 0
Response time: 0 ms

Resolved: PR Medialogia is back up in 1329291 after 1 hour, 10 minutes.


text: Image for README.md

license: mit

license_source: bigquery


text:
Use AS3 to put a datagroup as HTTP URI condition in a Local Traffic Policy

Trying to use AS3 to configure a Local Traffic Policy that uses a datagroup do match an HTTP URI condition, but couldn't find a way to declare it.
Have already tried to use "datagroup": { "bigip": "/Common/images" } as a value or like the following. All tries return with 422 errors.
 "conditions": [
                            {
                                "event": "request",
                                "index": 1,
                                "name": "1",
                                "path": {
                                    "operand": "matches",
                                    "datagroup": { "bigip": "/Common/images" }
                                },
                                "type": "httpUri"
                            }
                        ],

Is it possible to do that? How to declare?
Thanks!

Hello guys..
Any update about this?
I've also open a case #C3615034 for this request.
Thanks.

Thank you for your feedback. I have added this request to our internal product backlog as AUTOTOOL-2728.

This has been resolved in the 3.32.0 release.


text:
Self IP masklen problem

Configuring the External and Internal Self IP addresses with a /16 masklen seems to fail.  Using /24 works, but does not for F5 GS training lab environment.  Would be very appreciated if you could make it work with /16.  Thanks!

Can you show us at least the SelfIp section of your declaration and the error message?

Sure.  This works:
        "internal-self": {             "class": "SelfIp",             "address": "172.16.0.31/24",             "vlan": "internal-vlan",             "allowService": "default",             "trafficGroup": "traffic-group-local-only"         },         "external-self": {             "class": "SelfIp",             "address": "10.10.0.31/24",             "vlan": "external-vlan",             "allowService": "default",             "trafficGroup": "traffic-group-local-only"         }
This fails:
        "internal-self": {             "class": "SelfIp",             "address": "172.16.0.31/16",             "vlan": "internal-vlan",             "allowService": "default",             "trafficGroup": "traffic-group-local-only"         },         "external-self": {             "class": "SelfIp",             "address": "10.10.0.31/16",             "vlan": "external-vlan",             "allowService": "default",             "trafficGroup": "traffic-group-local-only"         }
With this HTML error message:
The proxy server could not handle the request POST /mgmt/shared/declarative-onboarding/.
 Reason: Error reading from remote server

Running a GET is more helpful and returns:
{   "code": 400,   "status": "ERROR",   "message": "bad declaration",   "errors": [     {       "keyword": "format",       "dataPath": ".Common['internal-self'].address",       "schemaPath": "network.schema.json#/allOf/1/then/properties/address/format",       "params": {         "format": "f5ip"       },       "message": "should match format \"f5ip\""     }   ],
The declaration file is filtered through:
sed -e 's/ \+/ /g' | tr -d '\n'
And delivered with curl.  Thanks!

Thanks - there is a bug in our f5ip regex. Will fix in the next release.

Awesome.  Thank you!


text:
AttributeError: module 'fitlog' has no attribute 'add_to_line'

When I run
python main.py --dataset=semeval_2018_task7 --auto_hyperparam
I got
AttributeError: module 'fitlog' has no attribute 'add_to_line'
Is there a way to fix it?

Hi, thank you for asking the question. You can delete all lines that uses fitlog. It is a library that we use for logging our experiments, and it does not impact the running of the program at all. For example, try comment out # import fitlog and all occurrences of fitlog.

Hi, thank you for asking the question. You can delete all lines that uses fitlog. It is a library that we use for logging our experiments, and it does not impact the running of the program at all. For example, try comment out # import fitlog and all occurrences of fitlog.

authors: shaonanqinghuaizongshishi zhijing-jin


text:
javax.net.ssl.SSLHandshakeException: General SSLEngine problem

我使用web3sdk的源代码建立web工程，利用节点生成的client.keystore文件，并放在了classes路径下，启动的时候，提示下面的内容，请大神看看是什么原因。谢谢
01:12:07.674 DEBUG org.bcos.channel.client.Service$ConnectionCallback 74 onConnect - 已建立连接，将topic发送到该连接:60ead22418294a009eddd53e12be293d
01:12:07.675 DEBUG org.bcos.channel.client.Service$ConnectionCallback 78 onConnect - topics: []
01:12:07.679 ERROR org.bcos.channel.handler.ChannelHandler 147 exceptionCaught - 网络错误 io.netty.handler.codec.DecoderException: javax.net.ssl.SSLHandshakeException: General SSLEngine problem
at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:459) ~[netty-all-4.1.15.Final.jar:4.1.15.Final]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:265) ~[netty-all-4.1.15.Final.jar:4.1.15.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) [netty-all-4.1.15.Final.jar:4.1.15.Final]

可参考这里：https://github.com/FISCO-BCOS/web3sdk/issues/20

长时间没有回复，关闭issue。如果问题没有解决，非常欢迎再次打开

repo: FISCO-BCOS/FISCO-BCOS


text:
🛑 Ambientes is down

In 529045f, Ambientes (https://ambientesproductosdelimpieza.com/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Ambientes is back up in 4cb92c5.

repo: FK-Solutions/monitoring


text:
[Bug] 404 page when click settings on admin default theme

Describe the bug
404 Page /theme_default not found
To Reproduce
Steps to reproduce the behavior:

Go to 'admin area themes setting'
Click on 'admin default settings button'
See error 404

Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser Firefox 107.0,1
FOSS Billing 0.2.1

This should be fixed with https://github.com/FOSSBilling/FOSSBilling/issues/548

authors: BelleNottelling pakdhetimin

repo: FOSSBilling/FOSSBilling


text:
Rework roles to use better defaults

This commit is sizeable and makes many changes to various parts of the WordPress installation process. This change is explained below:
common

Remove existing repo configuration
Install EPEL via package
Use IUS repositories for newer upstream versions

mariadb

Use MariaDB 10.1+
Remove variables (hard-codes a port, but default is okay anyways)

nginx

Minor changes / clean-up
Rework template for wordpress server block configuration

php-fpm

Use PHP 7.2+

Other notes

Everything tested up to WordPress role - WordPress role needs work

@nlMeminger Could you review? Also tagging @Qalthos to take him up on his offer to review a PR here and there, since we're just getting started. :slightly_smiling_face:

I rebased my commits from everyone's feedback. Thanks everyone for the thorough review! Merging. :clapper:

repo: FOSSRIT/infrastructure


text:
Fixup name generation for -fmicrosoft; uppercase type names

Following our discussion, here's a proposed fix for the type names. Please let me know if this works as intended. Thanks!

I tried this out today and it doesn't seem to work for my scenario which involves external types. Consider:
module Test
module B = LowStar.Buffer
assume
val _MY_EXTERNAL_TYPE : Type0

let p_MY_EXTERNAL_TYPE = B.pointer _MY_EXTERNAL_TYPE

let test (x:p_MY_EXTERNAL_TYPE) : bool = true

Extracting this using --codegen krml and then running krml -fmicrosoft -skip-compilation out.krml` produces
/*
  This file was generated by KaRaMeL <https://github.com/FStarLang/karamel>
  KaRaMeL invocation: /home/nswamy/everest/karamel/krml -fmicrosoft -skip-compilation out.krml
  F* version: 46cbaf03
  KaRaMeL version: d6db69ab
 */

#include "Test.h"

BOOLEAN TestTest(TestMyExternalType *X)
{
  return TRUE;
}

I pushed a fix. With your test file, I now get:
/*
  This file was generated by KaRaMeL <https://github.com/FStarLang/karamel>
  KaRaMeL invocation: krml out.krml -skip-compilation -fmicrosoft -d c-names
  F* version: ce8b1957
  KaRaMeL version: fb04bf2a
 */

#ifndef __Test_H
#define __Test_H

#include "krmllib.h"

typedef TEST__MY_EXTERNAL_TYPE *TEST_P_MY_EXTERNAL_TYPE;

BOOLEAN TestTest(TEST__MY_EXTERNAL_TYPE *X);

#define __Test_H_DEFINED
#endif

is this the desired behavior?

ping @nikswamy @tahina-pro ... should this be merged?

Thanks for this fix. I am merging it after offline discussion with @protz ... much appreciated!

authors: msprotz nikswamy

repo: FStarLang/karamel


text:
[hotfix] default parcellation for allen mouse and waxholm mouse

use latest version (v3/4 for waxholm, 2017 for allen mouse) on selection

Fixed by https://jugit.fz-juelich.de/t.dickscheid/brainscapes-configurations/-/merge_requests/25
Waiting release


text:
its slow, i only need rating!!

Hello!
My problem is that approx. 10 seconds to load all of the data of a movie. I'm trying to interpret the class file, but maybe you have a faster solution: I only need the rating, can we leave out all other information so that it doesn't request it? I see that it also puts them in the cache. Thanks!

No, the script needs to fetch the page to finally parse it. :(

No, the script needs to fetch the page to finally parse it. :(

Thank you for your quick response, I'm sorry to hear that. :(
I also made an alternative using the HTML DOM parser, which is a bit faster than yours, but if you need a 1-1 value, it might be more efficient for someone. Since imdb's response itself is slow, retrieving a rating with my internet speed takes 3 seconds.
            include 'dom/simple_html_dom.php'; //https://simplehtmldom.sourceforge.io/docs/1.9/index.html             $var = $imdbid;             $html = file_get_html('https://www.imdb.com/title/'.$var);             $list = $html->find('div[class="sc-bde20123-2 gYgHoj"]',0);             $list_array = $list->find('span');              for($i = 0;$i<sizeof($list_array);$i++) {                 echo $list_array[$i];             }
It returns the value of the rating. If you need another value, you need to understand DOM parser, and replace the find function attributes.

Yeah, if you only need one item, that might be the solution. However, the DOM parsers breaks faster than the regex version, hence my choice back then. ;)

repo: FabianBeiner/PHP-IMDB-Grabber


text:
Drop 'color' prefix from color components

Closes #2897

This pull request is mainly impactful for mods adding custom particles.

repo: FabricMC/yarn


text:
Vehicle Fix causes cart contraptions to stop when they hit something

Describe the Bug
Cart contraptions seem to stop if the front of the contraption's hitbox meets an entity / block.
The hitbox is particularly large which, i am new to create, seems to be overly large. This stops 99% of cart contraptions from doing it's job. The cart contraption stops, and is unable to be pushed until the "obstacle" is removed from its path
Reproduction Steps

Create minecart contraption with blocks in a line from left to right.
Add some blocks / entities in its path
Enable hitboxes in the debug menu
Set the cart contraption off

Expected Result
Cart contraptions are unaffected by mobs / entities and contraptions move right up to the block for drills and break blocks as expected.
Screenshots and Videos

Crash Report or Log
No response
Operating System
Windows 11
Mod Version
0.5.1b
Minecraft Version
1.19.2
Other Mods
No response
Additional Context
No response

need your mod list

I found out the mod, its Vehicle Fix. Someone raised an issue on the mod, and the author's response was to make a datapack to fix it....
Idk if there is something that can be done on your end, but yeah...

This is easily fixable, could fix it and make a pr when im home

Any kind of update on this?

Oops.... forgot, im gonna sleep now but maybe im gonna do it tomorrow

Any progress update?

So, I tried fixing this on the mods side, but the thing is create pretends the create contraption is a minecart, so it doesn't work. I currently don't know how to get if the minecart really is a minecart or a create contraption.

Should be fixed by Vehicle Fix

authors: ChickenDestroyer IThundxr TropheusJ chudders1231 electricsteve

repo: Fabricators-of-Create/Create


text:
Crash after loading in world created in Create Forge

Describe the Bug
I tried to port my forge modpack to fabric, worlds from create forge crash after loading in. Looks like a washing machine is the reason for this crash.
Reproduction Steps

Create a world in Create Forge and make a washing setup
Change mods to Fabric

Expected Result
Expected to have world compat between fabric and forge
Screenshots and Videos

Crash Report or Log
https://pastebin.com/Yvfkz5bW
Operating System
Windows 10
Mod Version
0.5.1d
Minecraft Version
1.20.1
Other Mods

Additional Context
The chunks im loading in consist of an andesite farm

Fixed in patch f

Fixed in patch f

Is patch f out yet? If yes where can I get it?

authors: IThundxr ReMelon


text:
Crash when clicking on the button with glasses on start screen

Describe the Bug
Just a game crash when u click this button
Reproduction Steps

Click the button
That's it

Expected Result
Open some GUI
Screenshots and Videos
No response
Crash Report or Log
https://pastebin.com/4BG5W7Th
Operating System
Manjaro Linux KDE
Mod Version
0.4.1
Minecraft Version
1.18.2
Other Mods
Fabric Mods:
badpackets: Bad Packets 0.1.1
capes: Capes 1.3.0+1.18.2
chime: Chime 1.2.1
cloth-basic-math: cloth-basic-math 0.6.0
cloth-config: Cloth Config v6 6.2.57
com_electronwill_night-config_core: core 3.6.3
com_electronwill_night-config_toml: toml 3.6.3
com_github_llamalad7_mixinextras: mixinextras 0.0.6
com_google_code_findbugs_jsr305: jsr305 3.0.2
completeconfig: CompleteConfig 1.4.0
create: Create mc1.18.2_v0.4.1+535
dev_isxander_settxi: settxi 2.1.0
dripstone_fluid_lib: Dripstone Fluid Lib 1.2.0
entityculling: EntityCulling-Fabric 1.5.1
fabric: Fabric API 0.51.1+1.18.2
fabric-api-base: Fabric API Base 0.4.4+d7c144a860
fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.6.0+2373a54560
fabric-biome-api-v1: Fabric Biome API (v1) 8.0.4+7b0f312660
fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.12+3ac43d9560
fabric-command-api-v1: Fabric Command API (v1) 1.1.9+d7c144a860
fabric-commands-v0: Fabric Commands (v0) 0.2.8+b4f4f6cd60
fabric-containers-v0: Fabric Containers (v0) 0.1.21+d7c144a860
fabric-content-registries-v0: Fabric Content Registries (v0) 3.0.3+d82b939260
fabric-convention-tags-v1: Fabric Convention Tags 1.0.1+474e4f7960
fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.1.11+3ac43d9560
fabric-data-generation-api-v1: Fabric Data Generation API (v1) 2.0.7+6d3e563660
fabric-dimensions-v1: Fabric Dimensions API (v1) 2.1.17+2540745460
fabric-entity-events-v1: Fabric Entity Events (v1) 1.4.8+d7c144a860
fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.4.19+d7c144a860
fabric-events-lifecycle-v0: Fabric Events Lifecycle (v0) 0.2.14+d7c144a860
fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.13+d7c144a860
fabric-item-api-v1: Fabric Item API (v1) 1.4.0+4457765560
fabric-item-groups-v0: Fabric Item Groups (v0) 0.3.11+91896a4960
fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.12+54e5b2ec60
fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.10+b4f4f6cd60
fabric-language-kotlin: Fabric Language Kotlin 1.7.4+kotlin.1.6.21
fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 2.0.3+2d83e92c60
fabric-loot-tables-v1: Fabric Loot Tables (v1) 1.0.11+d7c144a860
fabric-mining-level-api-v1: Fabric Mining Level API (v1) 2.1.0+81ea5b3c60
fabric-models-v0: Fabric Models (v0) 0.3.6+d7c144a860
fabric-networking-api-v1: Fabric Networking API (v1) 1.0.21+d882b91560
fabric-networking-v0: Fabric Networking (v0) 0.3.8+b4f4f6cd60
fabric-object-builder-api-v1: Fabric Object Builder API (v1) 2.1.0+fe4ddef060
fabric-particles-v1: Fabric Particles (v1) 0.2.12+526dc1ac60
fabric-registry-sync-v0: Fabric Registry Sync (v0) 0.9.8+0d9ab37260
fabric-renderer-api-v1: Fabric Renderer API (v1) 0.4.13+d882b91560
fabric-renderer-indigo: Fabric Renderer - Indigo 0.5.0+7faf0d8860
fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.11+b4f4f6cd60
fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.3.7+d7c144a860
fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 2.0.2+54e5b2ec60
fabric-rendering-v0: Fabric Rendering (v0) 1.1.13+b4f4f6cd60
fabric-rendering-v1: Fabric Rendering (v1) 1.10.7+54e5b2ec60
fabric-resource-conditions-api-v1: Fabric Resource Conditions API (v1) 2.0.3+91b7aa6660
fabric-resource-loader-v0: Fabric Resource Loader (v0) 0.4.18+2de5574560
fabric-screen-api-v1: Fabric Screen API (v1) 1.0.10+d882b91560
fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.2.0+1f6558e860
fabric-textures-v0: Fabric Textures (v0) 1.0.12+3ac43d9560
fabric-transfer-api-v1: Fabric Transfer API (v1) 1.6.0+2373a54560
fabric-transitive-access-wideners-v1: Fabric Transitive Access Wideners (v1) 1.0.0+bd8a4a1860
fabricloader: Fabric Loader 0.14.4
fake-player-api: Fake Player API 0.3.0
flywheel: Flywheel 1.18-0.6.2.25
forge_tags: Forge Tags 2.1
forgeconfigapiport: Forge Config API Port 3.2.0
hatlist: Hat List 1.2
indium: Indium 1.0.3+mc1.18.2
iris: Iris 1.2.2-build.32
java: OpenJDK 64-Bit Server VM 17
jsonem: JsonEM 0.1.2
lambdynlights: LambDynamicLights 2.1.0+1.17
lazydfu: LazyDFU 0.1.2
lithium: Lithium 0.7.9
milk: Milk Lib 0.3.0
minecraft: Minecraft 1.18.2
mm: Manningham Mills 2.3
modmenu: Mod Menu 3.1.0
noindium: No Indium? 1.0.1+1.18.2
omega-config: OmegaConfig 1.2.3-1.18.1
org_anarres_jcpp: jcpp 1.4.14
org_aperlambda_lambdajcommon: lambdajcommon 1.8.1
org_bundleproject_libversion: libversion 0.0.3
org_jetbrains_kotlin_kotlin-reflect: kotlin-reflect 1.6.21
org_jetbrains_kotlin_kotlin-stdlib: kotlin-stdlib 1.6.21
org_jetbrains_kotlin_kotlin-stdlib-jdk7: kotlin-stdlib-jdk7 1.6.21
org_jetbrains_kotlin_kotlin-stdlib-jdk8: kotlin-stdlib-jdk8 1.6.21
org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm: kotlinx-coroutines-core-jvm 1.6.1
org_jetbrains_kotlinx_kotlinx-coroutines-jdk8: kotlinx-coroutines-jdk8 1.6.1
org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm: kotlinx-serialization-cbor-jvm 1.3.2
org_jetbrains_kotlinx_kotlinx-serialization-core-jvm: kotlinx-serialization-core-jvm 1.3.2
org_jetbrains_kotlinx_kotlinx-serialization-json-jvm: kotlinx-serialization-json-jvm 1.3.2
org_joml_joml: joml 1.10.2
porting_lib: Porting Lib 0.2.0+1.18.2.2e6c4b3
pride: Pride Lib 1.1.0+1.17
reach-entity-attributes: Reach Entity Attributes 2.1.1
registrate-fabric: Registrate for Fabric MC1.18.2-1.0.x
sodium: Sodium 0.4.1+build.15
spruceui: SpruceUI 3.3.0+1.17
starlight: Starlight 1.0.2+fabric.89b8d9f
suggestion_tweaker: Suggestion Tweaker 1.18.2-1.2.0
wthit: wthit 4.9.0
zoomify: Zoomify 1.4.0
Additional Context
Minecraft launcher says that something happened with Indium

After some tests, I have figured out that crash is caused by Iris. I will test it with latest Iris update and write here again then

Yes, the problem was caused by outdated Iris version


text:
Fix jellyfin external url basepath being ignored

Description
The previous PR introduced a new syntax which ignores external jellyfin base path's. I. e. http://localhost:4124/jellyfin.
Screenshot (if UI-related)
To-Dos

[ ] Successful build yarn build
[ ] Translation keys yarn i18n:extract
[ ] Database migration (if required)

Issues Fixed or Closed

Fixes #237

A potential fix, probably having the trailing slashed removed just once after saving the settings would be the best solution so the code is kept DRY.

Note: The URL class which was used strips any paths from the base.

Note: The URL class which was used strips any paths from the base.

Ohh. How would we handle the trailing slash then 😏

Also urls ending in a / are valid and different to ones without a / and proxies (can) treat them differently

@sambartik Also could you fix the formatting issue so I could quickly release a hot fix?

:tada: This PR is included in version 1.2.1 :tada:
The release is available on:

v1.2.1
GitHub release

Your semantic-release bot :package::rocket:

authors: Fallenbagel sambartik

repo: Fallenbagel/jellyseerr


text:
refactor(i18n): merge weblate/develop into origin/develop

Description
Screenshot (if UI-related)
To-Dos

[ ] Successful build yarn build
[ ] Translation keys yarn i18n:extract
[ ] Database migration (if required)

Issues Fixed or Closed

Fixes #XXXX

Is this still relevant?

authors: Fallenbagel gauthier-th


text:
ffmpeg exits with error

I am converting some videos and here is the log of the errors I am getting for some of the files -
https://paste.fedoraproject.org/paste/syRrH~b0f7gx4IO4MvZRrg/
I am using ffmpeg 3.1.8 on fedora

Try running ffmpeg -n 10 /usr/bin/ffmpeg -i 20050328-Who is Dinky.mp4 -y -acodec copy -vcodec libx265 -filter:v crop=1412:1020:254:56,scale=-1:720 -c:s copy -c:d copy -pix_fmt yuv420p -map 0:0 -map 0:1 -metadata:s:a:1 title="Unknown AAC LC (Stereo)" -metadata:s:0:1 DISPOSITION:default=1 -crf 19 -preset fast /home/akya/Videos/h265/20050328-Who is Dinky.mkv. That should give you a more accurate description of the error.
---- On Tue, 20 Jun 2017 05:10:49 -0700 notifications@github.com wrote ----
I am converting some videos and here is the log of the errors I am getting for some of the files -
https://paste.fedoraproject.org/paste/syRrH~b0f7gx4IO4MvZRrg/
I am using ffmpeg 3.1.8 on fedora
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

This has something to do with cropping because I got this error -

x265 [error]: Picture width must be an integer multiple of the specified chroma subsampling
[libx265 @ 0x5596c7d648a0] Cannot open libx265 encoder.

So I removed the cropping part from the command and the encoding started. I am on the latest version of h265ize btw.. the one from

npm install FallingSnow/h265ize --global

x265 [error]: Picture width must be an integer multiple of the specified chroma subsampling

I never even knew this was a requirement, thank you for bringing it to my attention.
The next iteration of h265ize is almost ready btw. I will be uploading a precompiled version to npm for people to test in the coming days. Anyway here's the repo if you're interested.

authors: FallingSnow akyag


text:
Voucher - link projects requirement

Voucher - link projects requirement
multiple select project needed
change title bcoz tax is not shown there now

Remove Imcome Account as well

projects multiple select (Cantfix)

jo nhi ho saktaa ,usme cant fix wala tag laga do,

authors: ajayrajecb dharmendraecb mitulpanch

repo: Fammeo/EasyCloudBooks


text:
Wrapping content in separate DIV results into non delegated events not being listened to properly

The bound _triggerEvent function has not been added to the content DIV.
This massively complicates the way we are adding event listeners.

Thanks for reporting this @alexanderGugel. How should we go about resolving this?

@FarhadG The DOMRenderer needs to do some ugly things. I'm not sure yet how to best resolve this.

Can you please expand on what you mean by non-delegated events or provide a quick sample?

@jd-carroll Of course!
Currently we are delegating as many events as possible. Unfortunately not all events bubble, therefore we have to add an event listener directly to the element corresponding to the Node when it doesn't bubble (e.g. mouseenter).
The EventMap defines what types of events are being delegated and which constructor function is being used to serialize the event:
E.g.
    click                          : [MouseEvent, true],

means the event of type click is being delegated (true) using the MouseEvent constructor.
This works perfectly fine. But let's say we have an event that doesn't bubble:
    mouseleave                     : [MouseEvent, false],

We need to attach the event listener to that element corresponding to the node. And here is the issue: If we have a content DIV, we need to attach the listener there, otherwise we need to add it to the containing DIV. Currently we don't do that, so non-bubbling events will stop working when setting a content after the listener has been added.

authors: FarhadG alexanderGugel jd-carroll

repo: Famous/engine


text:
module 'cv2.gapi.wip.draw' has no attribute 'Text' when using comfyui-reactor-node

When I'm using comfyui-reactor-node, then comfyui_controlnet_aux fails to load giving me "Cannot import /Users/marek/ComfyUI/custom_nodes/comfyui_controlnet_aux module for custom nodes: module 'cv2.gapi.wip.draw' has no attribute 'Text'"
When I disable comfyui-reactor-node, then comfyui_controlnet_aux loads fine.
`** ComfyUI start up time: 2023-11-29 23:33:07.813969
Prestartup times for custom nodes:
0.0 seconds: /Users/marek/ComfyUI/custom_nodes/ComfyUI-Manager
Total VRAM 65536 MB, total RAM 65536 MB
Forcing FP16.
Set vram state to: SHARED
Device: mps
VAE dtype: torch.float32
Using sub quadratic optimization for cross attention, if you have memory or speed issues try using: --use-split-cross-attention
Loading: ComfyUI-Manager (V1.5.2)
ComfyUI Revision: 1748 [a6676384] | Released on '2023-11-27'
Total VRAM 65536 MB, total RAM 65536 MB
Forcing FP16.
Set vram state to: SHARED
Device: mps
VAE dtype: torch.float32
Torch version: 2.1.1
Traceback (most recent call last):
File "/Users/marek/ComfyUI/nodes.py", line 1798, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "/Users/marek/ComfyUI/custom_nodes/comfyui_controlnet_aux/init.py", line 2, in
from .utils import here, create_node_input_types
File "/Users/marek/ComfyUI/custom_nodes/comfyui_controlnet_aux/utils.py", line 4, in
import cv2
File "/Users/marek/.pyenv/versions/3.10.9/lib/python3.10/site-packages/cv2/init.py", line 181, in
bootstrap()
File "/Users/marek/.pyenv/versions/3.10.9/lib/python3.10/site-packages/cv2/init.py", line 175, in bootstrap
if __load_extra_py_code_for_module("cv2", submodule, DEBUG):
File "/Users/marek/.pyenv/versions/3.10.9/lib/python3.10/site-packages/cv2/init.py", line 28, in __load_extra_py_code_for_module
py_module = importlib.import_module(module_name)
File "/Users/marek/.pyenv/versions/3.10.9/lib/python3.10/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "/Users/marek/.pyenv/versions/3.10.9/lib/python3.10/site-packages/cv2/typing/init.py", line 157, in
Prim = typing.Union[cv2.gapi.wip.draw.Text, cv2.gapi.wip.draw.Circle, cv2.gapi.wip.draw.Image, cv2.gapi.wip.draw.Line, cv2.gapi.wip.draw.Rect, cv2.gapi.wip.draw.Mosaic, cv2.gapi.wip.draw.Poly]
AttributeError: module 'cv2.gapi.wip.draw' has no attribute 'Text'
Cannot import /Users/marek/ComfyUI/custom_nodes/comfyui_controlnet_aux module for custom nodes: module 'cv2.gapi.wip.draw' has no attribute 'Text'
Import times for custom nodes:
0.0 seconds (IMPORT FAILED): /Users/marek/ComfyUI/custom_nodes/comfyui_controlnet_aux
0.0 seconds: /Users/marek/ComfyUI/custom_nodes/ComfyUI-Manager
0.4 seconds: /Users/marek/ComfyUI/custom_nodes/comfyui-reactor-node
Starting server
To see the GUI go to: http://127.0.0.1:8188
`

Same here.

Update your comfyui-reactor-node and reinstall opencv-python package(uninstall it first). Please note that it is pip install opencv-python instead of pip install cv2.

Thank you for the suggestion. I did:

"Update All" from Comfy UI manager menu
pip uninstall opencv-python
pip install opencv-python

Unfortunately still same result:
`marek@Mareks-MacBook-Pro ComfyUI % python main.py --force-fp16
** ComfyUI start up time: 2023-12-05 07:21:48.198266
Prestartup times for custom nodes:
0.0 seconds: /Users/marek/ComfyUI/custom_nodes/ComfyUI-Manager
Total VRAM 65536 MB, total RAM 65536 MB
Forcing FP16.
Set vram state to: SHARED
Device: mps
VAE dtype: torch.float32
Using sub quadratic optimization for cross attention, if you have memory or speed issues try using: --use-split-cross-attention
Loading: ComfyUI-Manager (V1.6.4)
ComfyUI Revision: 1779 [9b655d4f] | Released on '2023-12-04'
Total VRAM 65536 MB, total RAM 65536 MB
Forcing FP16.
Set vram state to: SHARED
Device: mps
VAE dtype: torch.float32
Torch version: 2.1.1
Traceback (most recent call last):
File "/Users/marek/ComfyUI/nodes.py", line 1800, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in _call_with_frames_removed
File "/Users/marek/ComfyUI/custom_nodes/comfyui_controlnet_aux/init.py", line 2, in
from .utils import here, create_node_input_types
File "/Users/marek/ComfyUI/custom_nodes/comfyui_controlnet_aux/utils.py", line 4, in
import cv2
File "/Users/marek/.pyenv/versions/3.10.9/lib/python3.10/site-packages/cv2/init.py", line 181, in
bootstrap()
File "/Users/marek/.pyenv/versions/3.10.9/lib/python3.10/site-packages/cv2/init.py", line 175, in bootstrap
if __load_extra_py_code_for_module("cv2", submodule, DEBUG):
File "/Users/marek/.pyenv/versions/3.10.9/lib/python3.10/site-packages/cv2/init.py", line 28, in __load_extra_py_code_for_module
py_module = importlib.import_module(module_name)
File "/Users/marek/.pyenv/versions/3.10.9/lib/python3.10/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "/Users/marek/.pyenv/versions/3.10.9/lib/python3.10/site-packages/cv2/typing/init.py", line 157, in
Prim = typing.Union[cv2.gapi.wip.draw.Text, cv2.gapi.wip.draw.Circle, cv2.gapi.wip.draw.Image, cv2.gapi.wip.draw.Line, cv2.gapi.wip.draw.Rect, cv2.gapi.wip.draw.Mosaic, cv2.gapi.wip.draw.Poly]
AttributeError: module 'cv2.gapi.wip.draw' has no attribute 'Text'
Cannot import /Users/marek/ComfyUI/custom_nodes/comfyui_controlnet_aux module for custom nodes: module 'cv2.gapi.wip.draw' has no attribute 'Text'
Import times for custom nodes:
0.0 seconds (IMPORT FAILED): /Users/marek/ComfyUI/custom_nodes/comfyui_controlnet_aux
0.0 seconds: /Users/marek/ComfyUI/custom_nodes/ComfyUI-Manager
1.0 seconds: /Users/marek/ComfyUI/custom_nodes/comfyui-reactor-node
Starting server
To see the GUI go to: http://127.0.0.1:8188
FETCH DATA from: /Users/marek/ComfyUI/custom_nodes/ComfyUI-Manager/extension-node-map.json
`

That's wired, Its just import cv2 make sure you at the same python enviroment as comfyui. try these code:cd /Users/marek/.pyenv/versions/3.10.9/bin/ python -m pip uninstall -y opencv-python opencv-contrib-python opencv-python-headless python -m pip install opencv-python==4.7.0.72orpython -m pip install opencv-python==4.8.1.78`

That's wired. it's just import cv2
Are you sure you did my suggestion at the same pyenv as ComfyUI?
try these:
cd /Users/marek/.pyenv/versions/3.10.9/bin/
python -m pip uninstall -y opencv-python opencv-contrib-python opencv-python-headless
python -m pip install opencv-python==4.8.1.78 or python -m pip install opencv-python==4.7.0.72

python -m pip install opencv-python==4.8.1.78

Thank you so much!
python -m pip install opencv-python==4.8.1.78 did not help
but python -m pip install opencv-python==4.7.0.72 worked!

python -m pip install opencv-python==4.8.1.78 did not help
but python -m pip install opencv-python==4.7.0.72 worked!

@mkvt141  Same for me!
Python version: 3.11.5
Torch version: 2.1.0


text:
Update third_party_environments.md first-party environments section

Description

reworked first-party env section, and separated env projects with API projects, (we may want to make a "other APIs" section, similarly to "third party envs" in the future)
moved farama envs to first-party section

Type of change

[X] Documentation only change (no code changed)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[X]  I built the docs, and everything seems fine

@Kallinteris-Andreas Were you planning any more changes?

Not for now

authors: Kallinteris-Andreas pseudo-rnd-thoughts

repo: Farama-Foundation/Gymnasium


text:
Storing selected location

Describe the problem
I'm trying to decide on how to store the location that the user selects in my database. I'd rather not store it as a JSON as I would like to be able to easily search for the location. I was thinking that I would be able to use the place_id but I have no idea how I would go about querying the location details using that id. Is that possible?
I'm not sure how I would query any of the locations from the backend. What would be the best way to store this?
Reproduction - (required - issue will be closed without this)
N/A
Additional context

Library Version: 2.4.1

React Native Version: 0.64.2

[x] iOS

[x] Android

[ ] Web

If you are using expo please indicate here:

[ ] I am using expo

Add any other context about the problem here, screenshots etc

A few options I could think of off the top of my head that could make sense.

Store the place ID.  See which Google APIs we use in the readme here.
store a json object with only a few keys (e.g. lat, long, formatted_address, place id). You can use the GooglePlacesDetailsQuery  prop to specify which fields you want to return from the places api to trim the size of the object.

@bell-steven I'm kind of partial towards the first option but I guess what I'm confused about is how do I go about interfacing with the Google API in the frontend of react native? Is there a library I should be using to call the API or would I have to figure out how to interface with on my own?
Sorry if these are dumb questions I'm new to React Native haha

Decided to store the latitude and longitude

authors: KrisLau bell-steven


text:
[IN PROG] Track last_saw_mq time; More connectivity tracker improvements.

What's New?

Rename last_seen to last_saw_api.
Add last_saw_mq column.
DRY up a bunch of shared logic relating to API/MQ connectivity tracking.
Use last_saw_mq from RESOURCE_READY when MQTT connectivity is not available.

What's Next?

Needs more test coverage.

Coverage decreased (-0.2%) to 59.566% when pulling 04edcc3b857f5827eef7d0102640dd9be018ba99 on RickCarlino:last_saw into fc56137cee493e0c80921141c3c56ede7803e6ff on FarmBot:master.

Coverage decreased (-0.2%) to 59.649% when pulling 1d00d774d1b891617a14370e695c2d251f285077 on RickCarlino:last_saw into ca23404c34a5aafef9e850d6cd03da800eb5e3d3 on FarmBot:master.

Coverage decreased (-0.02%) to 59.785% when pulling 4fe636ad85e94ae5e2aa9464cca0ad9dbf64f780 on RickCarlino:last_saw into ca23404c34a5aafef9e850d6cd03da800eb5e3d3 on FarmBot:master.

Coverage increased (+0.1%) to 59.943% when pulling 1563afc3d962a7b3e0a0f467c1bf61217bf16972 on RickCarlino:last_saw into ca23404c34a5aafef9e850d6cd03da800eb5e3d3 on FarmBot:master.

authors: RickCarlino coveralls

repo: FarmBot/Farmbot-Web-App


text:
Dep upgrades: Major version bumps

see #855
Also, upgrade Jest, tests, and refactoring.

Coverage increased (+0.2%) to 91.306% when pulling ccdbb17be3c9843e90fce19de81516dfc46f7576 on gabrielburnworth:staging into a04c8c00e7b56b400681efbc93efce47d99e30fe on FarmBot:staging.

Coverage increased (+0.2%) to 91.306% when pulling ccdbb17be3c9843e90fce19de81516dfc46f7576 on gabrielburnworth:staging into a04c8c00e7b56b400681efbc93efce47d99e30fe on FarmBot:staging.

authors: coveralls gabrielburnworth


text:
Is there any way to use FastReport OpenSource on linux with .net8 ?

Is there any way to use FastReport OpenSource on linux with .net8 ?

UP

Hello!
FastReport.Opensource does not support development for Linux. System.Drawing.Common, starting with version 7.0, will completely stop supporting non-Windows systems, so the examples of libgdiplus given above will soon not work at all.
Only the commercial version of FastReport.Core.Skia has support.
See here:
https://www.fast-report.com/en/blog/show/fastreport-core-skia/
You will be able to test demo Nuget packages FastReport.Core.Skia and FastReport.Web.Skia in your application for correct work under Linux, you will also need additional packages:
HarfBuzzSharp.NativeAssets.Linux
SkiaSharp.NativeAssets.Linux
Best regards,
Bogdan

you just need install libgdiplus in your linux.

you just need install libgdiplus in your linux.

Have you tried this successfully? Does this works with .NET 8?

Hello!
I am sending you a test application with FastReport.MVC.6.0 application working correctly and using FastReport.Core.Skia.Demo and Online Designer Trial test suites
Application: https://drive.google.com/file/d/1qkO0mOYJMvDba0QlBPApJazmRaPKlZOF/view?usp=sharing
You can also see how to correctly run FastReport.Core on Linux in our article: https://www.fast-report.com/blogs/use-fastreport-core-linux.
Best regards,
Bogdan

authors: BogdanStegachev WBHWebDev jianliulin klindger printferlang

repo: FastReports/FastReport


text:
It's maths

Added calc as an alias but not maths smh
Please describe the changes this PR makes and why it should be merged:
Semantic versioning classification:

[ ] This PR changes the adds extra commands to the bot
[x] This PR improves existing commands
[ ] This PR only includes non-code changes, like changes to documentation, README, or images to memes / reactions

What's 1+1 if this is maths 😉

it's 4

whoops, added it~

repo: Favna/Ribbon

license: Unlicense


text:
⚠ Thumbnails API Endpoint has degraded performance

In 78768ae, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 1647 ms

Resolved: Thumbnails API Endpoint performance has improved in 2596cc4 after 7 minutes.

repo: FearedFusionX/Ro-Status


text:
🛑 Account Settings API is down

In 2f9b3d0, Account Settings API (https://accountsettings.roblox.com) was down:

HTTP code: 404
Response time: 106 ms

Resolved: Account Settings API is back up in d899c73 after 36 minutes.


text:
🛑 Badges API Endpoint is down

In 92b38e9, Badges API Endpoint (https://badges.roblox.com/v1/badges/2124548403) was down:

HTTP code: 503
Response time: 649 ms

Resolved: Badges API Endpoint is back up in cd7ab80 after 9 minutes.


text:
🛑 Roblox Devforum is down

In 947de05, Roblox Devforum (https://devforum.roblox.com) was down:

HTTP code: 403
Response time: 77 ms

Resolved: Roblox Devforum is back up in b318cf3 after 1 minute.


text:
Make the column highlighting useful or get rid of it

It's an automatically enabled accessibility thing. We can turn it off by turning off "level 2 accessibility features" (or some similar name) but I don't want to do that because who knows what else it might turn off that somebody might be using. It's incredibly stubborn and can't be disabled otherwise (not even with reflection afaik), nor can it even be tracked programmatically. If we could track it, then we could do as Dahenjo suggested and use it to allow keyboard column sorting by detecting which column is highlighted and sorting that column when the user presses eg. Ctrl-up or Ctrl-down.
With .NET Core 3, the WinForms source code is part of it and is MIT licensed like everything else, so we can do like we did with the zip stuff and just grab the DataGridView code, modify it, and there you go. We can either use the highlighting to track and allow keyboard nav, or just get rid of it. ETA November

After a very long time of trying angle after angle to try and force the remarkably resistant internal DataGridView code to stop the highlighting, I finally figured out a dumb hack to make it work, so it works now. No more blue highlighting. Hooray!

repo: FenPhoenix/AngelLoader


text:
[FEATURE] Trending Videos

Description
Adding Trending Videos in Categories.
Screenshots
No response
Additional information
No response

Yes @kartikayasija please work on Issue #89 and then implement trending category.

authors: KOMALDEWNANI kartikayasija


text:
AndroidX support

Any plans to support Android X instead of support library?
https://developer.android.com/jetpack/androidx/migrate

There's a branch androidx that started the support of AndroidX, but it's fairly old now and probably needs some updating... Last time I checked it could be used directly from JitPack:
implementation 'com.github.Ferfalk:SimpleSearchView:androidx-SNAPSHOT'

@vkotovv @Ferfalk I updated support for androidx .https://github.com/Ferfalk/SimpleSearchView/pull/13

@Ferfalk this can be closed now I guess

authors: Ferfalk ldavidsp vkotovv

repo: Ferfalk/SimpleSearchView


text:
Allow uppercase Latin letters in database names

Closes https://github.com/FerretDB/FerretDB/issues/2451.
As uppercase letters are allowed, we should remove a diff test for it.

I need to look into this.

@rumyantseva CI should be fixed soon so we can merge this.

repo: FerretDB/dance


text:
Persistent connections and Unicorn preload_app

Rollout seems to get confused when restarting a unicorn setup, because it's using the old Redis connections.
ActionView::Template::Error (Tried to use a connection from a child process without reconnecting. You need to reconnect to Redis after forking.):

Is there any workaround currently? The way I see it, there's no straightforward way to just reinitialize an existing Rollout with a new Redis object, and I'd rather not put the entire Rollout initializer in the unicorn after_fork block.

this seems kind of related to https://github.com/FetLife/rollout/issues/66

This has been resolved in Redis gem https://github.com/redis/redis-rb/pull/414

authors: jlecour kcm reneklacan

repo: FetLife/rollout


text:
Refactor SourceInfo and add support for pretty printing diagnostics

A lot of code has been rewritten. I tested it against several previous submissions, which have shown that the code is working well. Just in case I add this to a new branch.

I'd move everything inside the span package into a separate Maven module, as the code is basically independent of the Autograder itself (similar to the regex parser treeg)

repo: Feuermagier/autograder


text:
Update Readme with new features(#8)

publish version 1.2.0

Pull Request Test Coverage Report for Build 24

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.0%

Totals

Change from base Build 22:
0.0%

Covered Lines:
98

Relevant Lines:
100

💛  - Coveralls

Looks good to me... @alorma what do you think?

Great work @charlypro123 and thanks for the feedback @alorma !

authors: EsteveAguilera charlypro123 coveralls

repo: Fewlaps/Picoleto


text:
Server not automatically updating Mods on all Servers

I am experiencing a weird issue.
We are running a root server hosting 4 Ark Servers connected within a cluster.
For about 2 weeks now, arkmanager is not automatically updating all 4 Servers, only the first or only the first and second server.
All log entrys below the timestamp "2019-07-12 01:29:53" are done manually with "arkmanager checkmodupdate @all"
Cronjob to update Server and Mods:
0 * * * * /usr/local/bin/arkmanager --cronjob update @all  --saveworld --warn --update-mods --args  -- >/dev/null 2>&1

Arkmanager Version:
Version: 1.6
Channel: master
Commit: 5d839a7
Release Tag: v1.6.47
Blob SHA: 17673f8d40e090d1b57e371a274b0c3781b0995d

That looks almost as if you used & instead of && when chaining checkmodupdate / update / restart commands together.  & will background the previous command, while && will only execute the next command if the previous command succeeds.

Hey, thanks for the fast reply :)
What do you mean by "&" and "&&"?

I'm getting something similar.  Mod updates on first map, but the rest fail to notice there's an update with the mod.  When I try to log in I get a mod version mismatch.  checkmodupdate returns All mods are up to date.  My cron is:
*/15 * * * * /usr/local/bin/arkmanager update --update-mods --safe --warn --backup @all > /var/log/arktools/cron.log
Dunno if it matters, but they all share a staging dir.

Ah right, I had also set the staging to true with a directory for it, disabled it like a week ago, since i thought aswell, that it is causing this problem.

Just so we are clear on how far this reaches if it is a problem in the tools. I am having a similar issue and I have been updating my servers manually the whole time. It started about 3 weeks ago i'd say?
I log in and enter these commands:
arkmanager stop @all
arkmanager update --update-mods @all
after that it goes through and updates the first instance both ark and the mods
then it seems to skip updating the mods on every other instance but still updates ark
As others have said when I check to see if a instance has outdated mods via
arkmanager checkmodupdate @
it just returns that all mods are up to date even if they arent. the update screen never said it was downloading updates for it and never did because upon starting all instances only the first one has the correct mods.
The only workaround I have found for this is to update ark itself if it needs it then run arkmanager installmods @all
this forces it to grab all of the mods regardless of whether it needs to or not
Version: 1.6
Channel: master
Commit: f69ba15
Release Tag: v1.6.53
Blob SHA: 6d19e8bff03048aec6541c7301512df6f4d30500
All of my instances are separate directories that are clustered.

@TheMourningWolf If the error persists, please create a new issue.

authors: Alphakilo TheMourningWolf ftmflea fusselshu klightspeed

repo: FezVrasta/ark-server-tools


text:
Model building work [ParkingArea]

The working list for this PR

[ ] Polygon reduction
[x] Separate driveways and sidewalks
[ ] Planting of trees
[ ] Transcription of road signs

I checked, and have some question.
1. Texture missing
The picture I take on this PR branch, looks that the texture for CityHall plant is missing.
I guess this is from apply missing of the material that you told me on the Discord.
But any way, I report this issue.

2. No trees
I opened Environment/vtc_environment_assy.blend, and there are no trees.
But you listed the "Planting of trees".
Thus, I would like to ask you about this.

3. No transcripts
This issue is same as 2. issue.
There are neither no transcripts for road signs.
I also would like to ask you about this.
Best,

Thank you for replying.

Texture missing

I am aware of the CityHall texture loss issue.
This is not the main purpose of PR and I will tackle it another time.

No trees

We were going to plant the trees in Unity.
However, we expect this Blender data to be used in other applications (e.g. Choreonoid).
So I think we need to plant trees in the Blender world as well.

No transcripts

Sorry, I'm trying..

@calm0815
Thank you for your reply.
I miss understood about your list on the first comment.
I thought that is the feature that you want to marge with this PR.
I understand your will.
Thus, please not to write the ToDo lists on here, but to write the check list that you want to marge as new feature with this PR.
About the ToDo list, please create new Issue and write on there.
Bests,

@calm0815
So, what is the feature that you want to merge with this PR ?

Thus, please not to write the ToDo lists on here, but to write the check list that you want to marge as new feature with this PR.
About the ToDo list, please create new Issue and write on there.

OK.
I will do so since the next time.

So, what is the feature that you want to merge with this PR ?

The features of this PR are the same as the checklist.

@calm0815

The features of this PR are the same as the checklist.

If it is true, you need to add Trees & Transcripts & Reduce polygons.
But isn't it ToDo lists (wish lists) ?
If you want to add those feature with THIS PR, it still not implemented.
Thus, I could not merge it.
I think the list is too much.
And it is worth to merge with current states.
Best,

I understood Issue and PR operations.
Next time, I'd like to present a wish list in Issue and achievements in PR.
For this PR, I will present the following results.

[x] Reconfigure the directory.
[x] Added texture tools.
[x] Delete unnecessary files.

The initial wish list I was presenting goes to Issue.
Please check the Issue.

@calm0815
Thank you for your understanding.
The new featere list, I checked is working.
Thus I will merge it.

Thank you for merging !
Please check again when ParkingArea is complete!


text:
Integrate plugin into FT workflow

Matt H has kindly transitioned this plugin to the FT org, and this PR updates the metadata and build workflows to align with the rest of our estate, whilst making sure to preserve his crediting and licensing.

oh, it doesn't look like CircleCI is building this repo yet, i think we should enable that before merging (to check this branch passes)?

authors: apaleslimghost ivomurrell