text:
Use Kubernetes blue as selection color

This is a Feature Request

What would you like to be added
Change the CSS so that text selections use a custom color; in this case, Kubernetes blue (hex #326ce5).
Why is this needed
I'm filing this because:

it can be a good first issue
incremental brand improvements across the whole site are worth making
it's useful to widen the pool of people who have worked on our CSS / SCSS.

Comments
/area web-development
/good-first-issue
ⓘ If you have already worked on CSS for this website, please step back from working on this issue, so that another contributor can use it as their first issue.

/triage accepted
/priority backlog

I haven't worked on CSS or web-development area, so i am willing to take and start investigation on this.
Thanks,
/assign

@T-Lakshmi hi! just saw your message while submitting my PR, thought i'd let you know i think i've just already tackled it haha!

@mostafahanafi,
Alright, please go ahead. unassigning myself.
/unassign

/assign @mostafahanafi

Done as an initial implementation in #40796
In 2023, we may not need the -moz- prefix which was there to support 2009-era Firefox. If anyone wants to tidy things up there, please do.
/close

In 2023, we may not need the -moz- prefix which was there to support 2009-era Firefox. If anyone wants to tidy things up there, please do.

@sftim I looked it up and from what I can see the -moz- prefix was actually used by Firefox up until 2018 and that's why, although not necessary, it may be good practice to keep it around.

checks calendar
That's 5 years ago!

authors: T-Lakshmi mostafahanafi sftim


text:
Feature gate deprecation: Added feature-gates deprecation guidelines and policy as per discussion: SIG-architecture meeting

Added feature-gates deprecation guidelines and policy as per discussion: SIG-architecture meeting

@anlunas PR doesn't seem to be rebased correctly.

Wrong PR, need coffee! & try again

Hey Lubomir, yeah.. sorry for the premature link - the correct PR is
#10294.
On Thu, 13 Sep 2018 at 20:27, Lubomir I. Ivanov notifications@github.com
wrote:

@anlunas https://github.com/anlunas PR doesn't seem to be rebased
correctly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/website/pull/10293#issuecomment-421105868,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbgjZ8HPtJULAoHCbRCOITPAVCVlURmjks5uaqN_gaJpZM4Wn7Rf
.

source: gharchive/pull-request

repo: kubernetes/website

license_type: permissive

license_source: github-api


text:
Update outdated l10n(ko) contents

fixes #10904

/assign @ClaudiaJKang
/lgtm
/approve

authors: ClaudiaJKang gochist


text:
Issue with k8s.io/docs/tutorials/kubernetes-basics/scale/scale-intro/

fixing carousel by adjusting carousel item to bootstrap 4.
Fixes #15128

/lgtm
/approve


text:
Create zh-trans:docs/user-journeys/users/cluster-operator/foundational.md

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Remember to delete this note before submitting your pull request.
For pull requests on 1.15 Features: set Milestone to 1.15 and Base Branch to dev-1.15
For pull requests on Chinese localization, set Base Branch to release-1.14
For pull requests on Korean Localization: set Base Branch to dev-1.14-ko.<latest team milestone>
If you need Help on editing and submitting pull requests, visit:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.
If you need Help on choosing which branch to use, visit:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

/assign @dchen1107
Please give this PR approval.


text:
ja: Make docs/reference/kubectl/cheatsheet.md follow v1.18 of the original text

Closes #23337

/assign @nasa9084

/approve


text:
Improve "look and feel" of tabs to make it clearer where they start/end

Improve "look and feel" of tabs to make it clearer where they start/end
mentioned in #26737

preview: https://deploy-preview-26828--kubernetes-io-master-staging.netlify.app/docs/tasks/tools/install-kubectl/

/area web-development

Thanks for this @lsq645599166, I think it's looking good.
/lgtm
/label tide/merge-method-squash

/lgtm
Defer approval to chairs.

/assign @jimangel

@jimangel Is there any suggestion about this pull request

Hi @lsq645599166 .
I think the changes improve the tab component!
Another page preview:
https://deploy-preview-26828--kubernetes-io-master-staging.netlify.app/docs/setup/production-environment/tools/kubeadm/install-kubeadm/#installing-runtime

authors: kbhawkey lsq645599166 nate-double-u tengqm


text:
Tweak advice about managing resources for containers

Reword Managing Resources for Containers [preview]
Mainly I wanted to link to the new API reference; whilst I was in the area I did some other rewording, including a new title: “Resource Management for Pods and Containers”.

👋 @sftim . What do you think about the comments and suggested edits?

LGTM from me, thanks Tim. All the nits left can be in separate PRs if needed!

This looks great Tim! Just needs a rebase and should be good to go!
/lgtm

/lgtm

The changes look good. Perhaps another PR could revisit the nits and possibly break up the page into two topics.
Thanks.
/approve

authors: jimangel kbhawkey sftim shannonxtreme


text:
Revise downward API documentation

add a glossary entry
add a concept page (helps with https://github.com/kubernetes/website/issues/14579)
revise other documentation in light of above changes

Before
After

not applicable
Downward API concept

Expose Pod Information to Containers Through Environment Variables
Expose Pod Information to Containers Through Environment Variables task

Expose Pod Information to Containers Through Files
Expose Pod Information to Containers Through Files task

downwardAPI volumes
downwardAPI volumes

/label refactor
/kind cleanup

How's this? I added text to explicitly explain that a Pod must include one Container.

@tengqm if you have time, please take another look here.

/lgtm

Hi folks, this is ready for another review (I rebased).

/lgtm

authors: sftim tengqm zacharysarah


text:
typo: update topology-manager.md

Hey @HeGaoYuan,
Thanks for fixing this typo! I think there must be some other errors in this document, would you like to fix them as well?
感謝您找到這個錯字並修正，但通常會出現一個小錯誤，也就代表當初翻譯的人可能不夠細心，這個頁面肯定還有不少地方可以改為更好的翻譯
如果您時間允許，要不要試著多修正幾個錯誤，我們再來 review 這個 PR 呢？
例如 中文翻譯指南 有提到我們會以 **粗體** 代替 *斜體*，但這份文件被翻譯時還沒嚴格實施這項規定，如果您能幫忙一起修改的話就太好了 😊

/lgtm
/approve

authors: HeGaoYuan Sea-n tengqm


text:
Add content/pt-br/docs/setup/production-environment/tools/kops.md

Add content/pt-br/docs/setup/production-environment/tools/kops.md

/assign

@devlware PTAL
/lgtm

/cc @stormqueen1990

/lgtm

/lgtm

@edsoncelio could you take another look?

Thanks!
/approve

authors: edsoncelio juliafmorgado stormqueen1990


text:
[ko] Update outdated files in dev-1.27-ko.1 [M16-21]

Related Issue : https://github.com/kubernetes/website/issues/41631
Files Checked & Modified

[ ]  M16. content/en/docs/concepts/configuration/configmap.md | 2(+XS) 2(-)
[ ]  M17. content/en/docs/concepts/configuration/manage-resources-containers.md | 24(+S) 12(-)
[ ]  M18. content/en/docs/concepts/configuration/overview.md | 6(+XS) 6(-)
[ ]  M19. content/en/docs/concepts/configuration/secret.md | 55(+M) 299(-)
[ ]  M20. content/en/docs/concepts/containers/_index.md | 2(+XS) 2(-)
[ ]  M21. content/en/docs/concepts/containers/container-environment.md | 1(+XS) 1(-)

Comments
M20 : 문서의 변동사항이 없어 수정하지 않았습니다.

M19. content/en/docs/concepts/configuration/secret.md | 55(+M) 299(-)
의 내용이 많이 삭제되어서, 찾아 보니
#38083 에서, content/en/docs/concepts/configuration/secret.md 의 일부 내용이
content/en/docs/tasks/inject-data-application/distribute-credentials-secure.md 로 옮겨졌네요 ㅎㅎ
#41631 이슈의
M188. content/en/docs/tasks/inject-data-application/distribute-credentials-secure.md | 149(+L) 59(-)
작업을 수행할 분께서는
내용 삭제 전의 content/ko/docs/concepts/configuration/secret.md 내용을 참고하시면 되겠습니다.
이 내용은 #41631 이슈에도 코멘트 남겨 놓겠습니다~~

/assign

감사합니다!
이제 squash 를 부탁드립니다.
squash 하실 때, 커밋 메시지는 누구나 봤을 때에도 대략 어떤 커밋인지 알 수 있도록 작성해 주시면 좋습니다. ㅎㅎ
이 PR 제목을 잘 적어 주셔서, 이 PR 제목을 커밋 메시지로 써도 좋겠네요 ㅎㅎ

@jihoon-seo force-push하였습니다! 감사합니다:)

고생 많으셨습니다!
/lgtm
/approve

authors: byeongjaeSon jihoon-seo


text:
Mark TopologyManager feature gate as removed in v1.29

Move feature gates TopologyManager to  feature-gates-removed page
Ref: https://github.com/kubernetes/kubernetes/pull/121252

Please limit your change to English only, in this PR. Do not touch other localization files.

yes, i restored.

/lgtm
/approve

/retitle Mark TopologyManager feature gate as removed in v1.29

this probably should have been to the dev-1.29 branch

Oops, my bad.

With the revert PR merged, we need a new one that targets dev-1.29.

authors: reylejano sftim tengqm tukwila


text:
check-service-exists

Following tutorial step by step at this point service is not defined.

/area web-development

Do we need to check if the service exists again? Considering we've already scaled our application in a previous tutorial as specified in the section on the page titled "Updating an application," it seems redundant to me. What are your thoughts, @divya-mohan0209 and @natalisucks?

/lgtm

authors: mietnik network-charles tengqm


text:
promote HonorPVReclaimPolicy to beta

k/k: https://github.com/kubernetes/kubernetes/pull/124842
kep: https://github.com/kubernetes/enhancements/pull/4397
/hold
for k/k merged
preview https://deploy-preview-46794--kubernetes-io-main-staging.netlify.app/docs/concepts/storage/persistent-volumes/#persistentvolume-deletion-protection-finalizer

/sig storage

/lgtm

/hold cancel

authors: carlory sftim xing-yang


text:
[zh] Sync concepts/storage/volumes.md

Sync with en text:
content/zh-cn/docs/concepts/storage/volumes.md

See preview.

/approve

/lgtm

authors: asa3311 tengqm windsonsea


text:
Add blog for PersistentVolumeLastPhaseTransitionTime feature GA in v1.31

KEP: https://github.com/kubernetes/enhancements/issues/3762

/sig storage

Hey @RomanBednar , it's Matteo from the 1.31 Release comms team.
I'm reaching out with a reminder that the blog ready for review deadline is July 26, 2024.
Please let me know how we can help with content, review or anything else 😄

@mbianchidev you can:

let the author know if they can have an exception (this PR missed a deadline)
if so, assign a tentative publication date

Thanks @sftim !
So @RomanBednar we are ok with stretching the blog deadline for this one.
I'll mark it as ready for review and try to come up with a publication date ASAP.

Thanks @sftim !
So @RomanBednar we are ok with stretching the blog deadline for this one. I'll mark it as ready for review and try to come up with a publication date ASAP.

Currently the publication date is set to the 13th of August!

@mbianchidev Thank you, I've updated the date.

/unhold

/hold
OK to unhold once Kubernetes v1.31 has been released.

@sftim @tengqm Thank you for reviews, I've applied the suggestions and squashed everything.

hey @natalisucks, this one has been lgtm-ed before, now every comment should be addressed, can you help with labels? :eyes:

Thanks @sftim !
So @RomanBednar we are ok with stretching the blog deadline for this one. I'll mark it as ready for review and try to come up with a publication date ASAP.

Currently the publication date is set to the 13th of August!

That is after the date set for the release announcement. Seems wrong.

Thanks @sftim !
So @RomanBednar we are ok with stretching the blog deadline for this one. I'll mark it as ready for review and try to come up with a publication date ASAP.

Currently the publication date is set to the 13th of August!

That is after the date set for the release announcement. Seems wrong.

@RomanBednar the publication date should be August 14th.
cc: @mbianchidev

Let's pick a specific publication time; there are several articles due to go out on release day, and it's important that the earliest one out of the set is the release announcement.

Thanks @sftim !
So @RomanBednar we are ok with stretching the blog deadline for this one. I'll mark it as ready for review and try to come up with a publication date ASAP.

Currently the publication date is set to the 13th of August!

That is after the date set for the release announcement. Seems wrong.

@RomanBednar the publication date should be August 14th.
cc: @mbianchidev

I adjusted the board to reflect the change, it was set to the wrong date.
About setting a time let's pick one for the release blog and the ones going out the day of the release, for any other blog time is probably not-so-sensitive.

Thanks for the heads up, I've set the date to 2024-08-14.
cc @a-mccarthy @sftim @mbianchidev

Given this Slack thread re: specific time for the blog and the clarified items going out on release day, this looks good to me without a specific time
/approve

/lgtm
:stop_sign: Do not unhold or merge before Kubernetes v1.31 is released :stop_sign:

/unhold
Kubernetes v1.31 has been released.

authors: RomanBednar a-mccarthy dipesh-rawat mbianchidev natalisucks sftim


text:
[zh] Sync examples/examples_test.go

Sync with en #49201 and more
content/zh-cn/examples/examples_test.go

/lgtm
/approve
Let's kick it in and see if it works.

authors: tengqm windsonsea


text:
skaffold.dev: Use skaffold to run cluster in development mode

Picks up changes in files (*.go) and re-deploys image to cluster automatically.
NB: Use ./skaffold.sh run to start and skaffold delete to do teardown, and minikube is required.
Install skaffold
$ ARCH="$([ $(uname -m) = "aarch64" ] && echo "arm64" || echo "amd64")"
curl -L --output /usr/local/bin/skaffold "https://storage.googleapis.com/skaffold/releases/latest/skaffold-linux-${ARCH}"
sudo chmod +x /usr/local/bin/skaffold
$ skaffold version
v1.39.2

Bring up cluster
$ minikube start --profile kgw --addons=metallb
$ ./skaffold.sh run
Generating tags...
 - kubeshop/kusk-gateway -> kubeshop/kusk-gateway:latest
Checking cache...
 - kubeshop/kusk-gateway: Not found. Building
Starting build...
Found [kgw] context, using local docker daemon.
Building [kubeshop/kusk-gateway]...
Target platforms: [linux/amd64]
[+] Building 39.5s (18/18) FINISHED
 => [internal] load build definition from Dockerfile                                                                                0.0s
 => => transferring dockerfile: 1.33kB                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.0s
 => => transferring context: 211B                                                                                0.0s
 => [internal] load metadata for gcr.io/distroless/static:nonroot                                                                                1.5s
 => [internal] load metadata for docker.io/library/golang:1.19-alpine                                                                                1.8s
 => [auth] library/golang:pull token for registry-1.docker.io                                                                                0.0s
 => [builder 1/8] FROM docker.io/library/golang:1.19-alpine@sha256:f3e683657ddf73726b5717c2ff80cdcd9e9efb7d81f77e4948fada9a10dc7257                                            6.4s
 => => resolve docker.io/library/golang:1.19-alpine@sha256:f3e683657ddf73726b5717c2ff80cdcd9e9efb7d81f77e4948fada9a10dc7257                                                    0.0s
 => => sha256:46752c2ee3bd8388608e41362964c84f7a6dffe99d86faeddc82d917740c5968 1.36kB / 1.36kB                                                                                0.0s
 => => sha256:f9a40cb7e8ec6730fbc2feaad9b26b429930160c681b6d1e58ad3df1ad72d6f5 5.35kB / 5.35kB                                                                                0.0s
 => => sha256:213ec9aee27d8be045c6a92b7eac22c9a64b44558193775a1a7f626352392b49 2.81MB / 2.81MB                                                                                0.4s
 => => sha256:4583459ba0371c715f926a9bbd37a9dae909234f4b898220160425131eb53bd4 284.73kB / 284.73kB                                                                             0.4s
 => => sha256:93c1e223e6f2123b855e0c95898eba50cb6a055881ba9023527c0a361761c1cf 153B / 153B                                                                                0.4s
 => => sha256:f3e683657ddf73726b5717c2ff80cdcd9e9efb7d81f77e4948fada9a10dc7257 1.65kB / 1.65kB                                                                                0.0s
 => => extracting sha256:213ec9aee27d8be045c6a92b7eac22c9a64b44558193775a1a7f626352392b49                                                                                0.0s
 => => extracting sha256:4583459ba0371c715f926a9bbd37a9dae909234f4b898220160425131eb53bd4                                                                                0.0s
 => => sha256:14bccb3a1cff3b5f09bf1f21ba9ecb17c96329fb82f96605d922cfa4c9a82032 122.25MB / 122.25MB                                                                             3.7s
 => => sha256:861cc3991b26fba6073631f27a1dc32bb27761195d912d05ee2f14b86fdf923f 156B / 156B                                                                                0.6s
 => => extracting sha256:93c1e223e6f2123b855e0c95898eba50cb6a055881ba9023527c0a361761c1cf                                                                                0.0s
 => => extracting sha256:14bccb3a1cff3b5f09bf1f21ba9ecb17c96329fb82f96605d922cfa4c9a82032                                                                                2.4s
 => => extracting sha256:861cc3991b26fba6073631f27a1dc32bb27761195d912d05ee2f14b86fdf923f                                                                                0.0s
 => [stage-1 1/4] FROM gcr.io/distroless/static:nonroot@sha256:380318dd91fd3bea73ae5fe1eb4d795ef7923f576e6f5f8d4de6ef1ea18ed540                                                1.1s
 => => resolve gcr.io/distroless/static:nonroot@sha256:380318dd91fd3bea73ae5fe1eb4d795ef7923f576e6f5f8d4de6ef1ea18ed540                                                        0.0s
 => => sha256:380318dd91fd3bea73ae5fe1eb4d795ef7923f576e6f5f8d4de6ef1ea18ed540 1.67kB / 1.67kB                                                                                0.0s
 => => sha256:daf333843de1f9c4f43807bf2554dd27c59db181af10d8d6a065d80044f45ec1 426B / 426B                                                                                0.0s
 => => sha256:0d4f3baf10895230e85db46bed5a95d6f30f1c18a7d4ae1ac70aa25ee75baae3 478B / 478B                                                                                0.0s
 => => sha256:79e0d8860fadaab56c716928c84875d99ff5e13787ca3fcced10b70af29bf320 801.34kB / 801.34kB                                                                             0.9s
 => => extracting sha256:79e0d8860fadaab56c716928c84875d99ff5e13787ca3fcced10b70af29bf320                                                                                0.1s
 => [internal] load build context                                                                                0.5s
 => => transferring context: 90.55MB                                                                                0.5s
 => [builder 2/8] WORKDIR /workspace                                                                                1.4s
 => [builder 3/8] COPY go.mod go.mod                                                                                0.0s
 => [builder 4/8] COPY go.sum go.sum                                                                                0.0s
 => [builder 5/8] RUN go mod download                                                                                14.4s
 => [builder 6/8] COPY . .                                                                                0.1s
 => [builder 7/8] RUN GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build -v -ldflags "-X 'github.com/kubeshop/kusk-gateway/pkg/analytics.TelemetryToken=$TELEMETRY_TOKEN' -X 'gi  14.4s
 => [builder 8/8] RUN mkdir -m 00755 /opt/manager                                                                                0.2s
 => [stage-1 2/4] COPY --from=builder /workspace/manager .                                                                                0.0s
 => [stage-1 3/4] COPY --from=builder --chown=65532:65532 /opt/manager /opt/manager                                                                                0.0s
 => exporting to image                                                                                0.3s
 => => exporting layers                                                                                0.3s
 => => writing image sha256:feae312d1f6c4e4deae0e37c73bb5f23682cc797c9bc799bb96ef810e7a4fdbf                                                                                0.0s
 => => naming to docker.io/kubeshop/kusk-gateway:latest                                                                                0.0s
Build [kubeshop/kusk-gateway] succeeded
Starting test...
Tags used in deployment:
 - kubeshop/kusk-gateway -> kubeshop/kusk-gateway:feae312d1f6c4e4deae0e37c73bb5f23682cc797c9bc799bb96ef810e7a4fdbf
Starting deploy...
 - customresourcedefinition.apiextensions.k8s.io/apis.gateway.kusk.io created
 - customresourcedefinition.apiextensions.k8s.io/envoyfleet.gateway.kusk.io created
 - customresourcedefinition.apiextensions.k8s.io/staticroutes.gateway.kusk.io created
 - namespace/kusk-system created
 - customresourcedefinition.apiextensions.k8s.io/apis.gateway.kusk.io configured
 - customresourcedefinition.apiextensions.k8s.io/envoyfleet.gateway.kusk.io configured
 - customresourcedefinition.apiextensions.k8s.io/staticroutes.gateway.kusk.io configured
 - serviceaccount/kusk-gateway-manager created
 - role.rbac.authorization.k8s.io/kusk-gateway-leader-election-role created
 - clusterrole.rbac.authorization.k8s.io/kusk-gateway-envoyfleet-manager-role created
 - clusterrole.rbac.authorization.k8s.io/kusk-gateway-manager-role created
 - clusterrole.rbac.authorization.k8s.io/kusk-gateway-metrics-reader created
 - clusterrole.rbac.authorization.k8s.io/kusk-gateway-proxy-role created
 - rolebinding.rbac.authorization.k8s.io/kusk-gateway-leader-election-rolebinding created
 - clusterrolebinding.rbac.authorization.k8s.io/kusk-gateway-envoyfleet-manager-rolebinding created
 - clusterrolebinding.rbac.authorization.k8s.io/kusk-gateway-manager-rolebinding created
 - clusterrolebinding.rbac.authorization.k8s.io/kusk-gateway-proxy-rolebinding created
 - configmap/kusk-gateway-manager created
 - service/kusk-gateway-auth-service created
 - service/kusk-gateway-manager-metrics-service created
 - service/kusk-gateway-validator-service created
 - service/kusk-gateway-webhooks-service created
 - service/kusk-gateway-xds-service created
 - deployment.apps/kusk-gateway-manager created
 - mutatingwebhookconfiguration.admissionregistration.k8s.io/kusk-gateway-mutating-webhook-configuration created
 - validatingwebhookconfiguration.admissionregistration.k8s.io/kusk-gateway-validating-webhook-configuration created
 - configmap/config configured
Waiting for deployments to stabilize...
 - kusk-system:deployment/kusk-gateway-manager: waiting for rollout to finish: 0 of 1 updated replicas are available...
 - kusk-system:deployment/kusk-gateway-manager is ready.
Deployments stabilized in 11.134 seconds
Starting post-deploy hooks...
sleeping for 2 seconds before applying `config/samples/gateway_v1_envoyfleet.yaml`
Completed post-deploy hooks
 - envoyfleet.gateway.kusk.io/default created
Waiting for deployments to stabilize...
Deployments stabilized in 68.121516ms
You can also run [skaffold run --tail] to get the logs
$ kubectl get svc -A
kubectl get svc -A
NAMESPACE     NAME                                   TYPE           CLUSTER-IP       EXTERNAL-IP    PORT(S)                      AGE
default       default                                LoadBalancer   10.108.203.10    192.168.58.2   80:30103/TCP,443:32665/TCP   7s
default       kubernetes                             ClusterIP      10.96.0.1        <none>         443/TCP                      100s
kube-system   kube-dns                               ClusterIP      10.96.0.10       <none>         53/UDP,53/TCP,9153/TCP       99s
kusk-system   kusk-gateway-auth-service              ClusterIP      10.103.40.66     <none>         19000/TCP                    19s
kusk-system   kusk-gateway-manager-metrics-service   ClusterIP      10.100.170.224   <none>         8443/TCP                     19s
kusk-system   kusk-gateway-validator-service         ClusterIP      10.111.54.163    <none>         17000/TCP                    19s
kusk-system   kusk-gateway-webhooks-service          ClusterIP      10.96.171.109    <none>         443/TCP                      19s
kusk-system   kusk-gateway-xds-service               ClusterIP      10.97.183.42     <none>         18000/TCP                    19s
$ curl -v 192.168.58.2
*   Trying 192.168.58.2:80...
* Connected to 192.168.58.2 (192.168.58.2) port 80 (#0)
> GET / HTTP/1.1
> Host: 192.168.58.2
> User-Agent: curl/7.82.0
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 404 Not Found
< date: Tue, 11 Oct 2022 12:51:06 GMT
< server: envoy
< content-length: 0
<
* Connection #0 to host 192.168.58.2 left intact

Cleanup cluster
This deletes everything kusk-related in the cluster.
$ skaffold delete
Cleaning up...
 - customresourcedefinition.apiextensions.k8s.io "apis.gateway.kusk.io" deleted
 - customresourcedefinition.apiextensions.k8s.io "envoyfleet.gateway.kusk.io" deleted
 - customresourcedefinition.apiextensions.k8s.io "staticroutes.gateway.kusk.io" deleted
 - namespace "kusk-system" deleted
 - customresourcedefinition.apiextensions.k8s.io "envoyfleet.gateway.kusk.io" deleted
 - serviceaccount "kusk-gateway-manager" deleted
 - role.rbac.authorization.k8s.io "kusk-gateway-leader-election-role" deleted
 - clusterrole.rbac.authorization.k8s.io "kusk-gateway-envoyfleet-manager-role" deleted
 - clusterrole.rbac.authorization.k8s.io "kusk-gateway-manager-role" deleted
 - clusterrole.rbac.authorization.k8s.io "kusk-gateway-metrics-reader" deleted
 - clusterrole.rbac.authorization.k8s.io "kusk-gateway-proxy-role" deleted
 - rolebinding.rbac.authorization.k8s.io "kusk-gateway-leader-election-rolebinding" deleted
 - clusterrolebinding.rbac.authorization.k8s.io "kusk-gateway-envoyfleet-manager-rolebinding" deleted
 - clusterrolebinding.rbac.authorization.k8s.io "kusk-gateway-manager-rolebinding" deleted
 - clusterrolebinding.rbac.authorization.k8s.io "kusk-gateway-proxy-rolebinding" deleted
 - configmap "kusk-gateway-manager" deleted
 - service "kusk-gateway-auth-service" deleted
 - service "kusk-gateway-manager-metrics-service" deleted
 - service "kusk-gateway-validator-service" deleted
 - service "kusk-gateway-webhooks-service" deleted
 - service "kusk-gateway-xds-service" deleted
 - deployment.apps "kusk-gateway-manager" deleted
 - mutatingwebhookconfiguration.admissionregistration.k8s.io "kusk-gateway-mutating-webhook-configuration" deleted
 - validatingwebhookconfiguration.admissionregistration.k8s.io "kusk-gateway-validating-webhook-configuration" deleted
 - configmap "config" deleted
$ kubectl get svc -A
NAMESPACE     NAME         TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)                  AGE
default       kubernetes   ClusterIP   10.96.0.1    <none>        443/TCP                  10m
kube-system   kube-dns     ClusterIP   10.96.0.10   <none>        53/UDP,53/TCP,9153/TCP   10m
$ kubectl get pods -A
NAMESPACE        NAME                          READY   STATUS        RESTARTS   AGE
default          default-69d7898855-d76vr      1/1     Terminating   0          9m5s
kube-system      coredns-6d4b75cb6d-79rl2      1/1     Running       0          10m
kube-system      etcd-kgw                      1/1     Running       0          10m
kube-system      kube-apiserver-kgw            1/1     Running       0          10m
kube-system      kube-controller-manager-kgw   1/1     Running       0          10m
kube-system      kube-proxy-lks5k              1/1     Running       0          10m
kube-system      kube-scheduler-kgw            1/1     Running       0          10m
kube-system      storage-provisioner           1/1     Running       0          10m
metallb-system   controller-6f655c76ff-gszgf   1/1     Running       0          10m
metallb-system   speaker-d4ktr                 1/1     Running       0          10m
$ kubectl get crds -A
No resources found
$ kubectl get crds
No resources found

Modify a file
Execute ./skaffold.sh dev then modify a go file and observe that the new image is deployed in the cluster.
$ ./skaffold.sh dev
Listing files to watch...
 - kubeshop/kusk-gateway
Generating tags...
 - kubeshop/kusk-gateway -> kubeshop/kusk-gateway:latest
Checking cache...
 - kubeshop/kusk-gateway: Not found. Building
Starting build...
Found [kgw] context, using local docker daemon.
Building [kubeshop/kusk-gateway]...
Target platforms: [linux/amd64]
[+] Building 16.2s (18/18) FINISHED
 => [internal] load build definition from Dockerfile                                                                                0.0s
 => => transferring dockerfile: 38B                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.0s
 => => transferring context: 93B                                                                                0.0s
 => [internal] load metadata for gcr.io/distroless/static:nonroot                                                                                0.4s
 => [internal] load metadata for docker.io/library/golang:1.19-alpine                                                                                1.1s
 => [auth] library/golang:pull token for registry-1.docker.io                                                                                0.0s
 => [builder 1/8] FROM docker.io/library/golang:1.19-alpine@sha256:f3e683657ddf73726b5717c2ff80cdcd9e9efb7d81f77e4948fada9a10dc7257                                            0.0s
 => [stage-1 1/4] FROM gcr.io/distroless/static:nonroot@sha256:380318dd91fd3bea73ae5fe1eb4d795ef7923f576e6f5f8d4de6ef1ea18ed540                                                0.0s
 => [internal] load build context                                                                                0.0s
 => => transferring context: 37.00kB                                                                                0.0s
 => CACHED [builder 2/8] WORKDIR /workspace                                                                                0.0s
 => CACHED [builder 3/8] COPY go.mod go.mod                                                                                0.0s
 => CACHED [builder 4/8] COPY go.sum go.sum                                                                                0.0s
 => CACHED [builder 5/8] RUN go mod download                                                                                0.0s
 => [builder 6/8] COPY . .                                                                                0.1s
 => [builder 7/8] RUN GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build -v -ldflags "-X 'github.com/kubeshop/kusk-gateway/pkg/analytics.TelemetryToken=$TELEMETRY_TOKEN' -X 'gi  14.4s
 => [builder 8/8] RUN mkdir -m 00755 /opt/manager                                                                                0.3s
 => CACHED [stage-1 2/4] COPY --from=builder /workspace/manager .                                                                                0.0s
 => CACHED [stage-1 3/4] COPY --from=builder --chown=65532:65532 /opt/manager /opt/manager                                                                                0.0s
 => exporting to image                                                                                0.0s
 => => exporting layers                                                                                0.0s
 => => writing image sha256:feae312d1f6c4e4deae0e37c73bb5f23682cc797c9bc799bb96ef810e7a4fdbf                                                                                0.0s
 => => naming to docker.io/kubeshop/kusk-gateway:latest                                                                                0.0s
Build [kubeshop/kusk-gateway] succeeded
Tags used in deployment:
 - kubeshop/kusk-gateway -> kubeshop/kusk-gateway:feae312d1f6c4e4deae0e37c73bb5f23682cc797c9bc799bb96ef810e7a4fdbf
Starting deploy...
 - customresourcedefinition.apiextensions.k8s.io/apis.gateway.kusk.io configured
 - customresourcedefinition.apiextensions.k8s.io/envoyfleet.gateway.kusk.io configured
 - customresourcedefinition.apiextensions.k8s.io/staticroutes.gateway.kusk.io configured
 - namespace/kusk-system unchanged
 - customresourcedefinition.apiextensions.k8s.io/apis.gateway.kusk.io configured
 - customresourcedefinition.apiextensions.k8s.io/envoyfleet.gateway.kusk.io configured
 - customresourcedefinition.apiextensions.k8s.io/staticroutes.gateway.kusk.io configured
 - serviceaccount/kusk-gateway-manager unchanged
 - role.rbac.authorization.k8s.io/kusk-gateway-leader-election-role unchanged
 - clusterrole.rbac.authorization.k8s.io/kusk-gateway-envoyfleet-manager-role unchanged
 - clusterrole.rbac.authorization.k8s.io/kusk-gateway-manager-role configured
 - clusterrole.rbac.authorization.k8s.io/kusk-gateway-metrics-reader unchanged
 - clusterrole.rbac.authorization.k8s.io/kusk-gateway-proxy-role unchanged
 - rolebinding.rbac.authorization.k8s.io/kusk-gateway-leader-election-rolebinding unchanged
 - clusterrolebinding.rbac.authorization.k8s.io/kusk-gateway-envoyfleet-manager-rolebinding unchanged
 - clusterrolebinding.rbac.authorization.k8s.io/kusk-gateway-manager-rolebinding unchanged
 - clusterrolebinding.rbac.authorization.k8s.io/kusk-gateway-proxy-rolebinding unchanged
 - configmap/kusk-gateway-manager unchanged
 - service/kusk-gateway-auth-service configured
 - service/kusk-gateway-manager-metrics-service configured
 - service/kusk-gateway-validator-service configured
 - service/kusk-gateway-webhooks-service configured
 - service/kusk-gateway-xds-service configured
 - deployment.apps/kusk-gateway-manager configured
 - mutatingwebhookconfiguration.admissionregistration.k8s.io/kusk-gateway-mutating-webhook-configuration configured
 - validatingwebhookconfiguration.admissionregistration.k8s.io/kusk-gateway-validating-webhook-configuration configured
 - configmap/config unchanged
Waiting for deployments to stabilize...
 - kusk-system:deployment/kusk-gateway-manager: waiting for rollout to finish: 1 old replicas are pending termination...
 - kusk-system:deployment/kusk-gateway-manager is ready.
Deployments stabilized in 11.13 seconds
Starting post-deploy hooks...
sleeping for 2 seconds before applying `config/samples/gateway_v1_envoyfleet.yaml`
Completed post-deploy hooks
 - envoyfleet.gateway.kusk.io/default configured
Waiting for deployments to stabilize...
Deployments stabilized in 52.110579ms
Press Ctrl+C to exit
[manager] METRICS_BIND_ADDR=127.0.0.1:8080
[kube-rbac-proxy] I1011 12:57:17.430810       1 main.go:190] Valid token audiences:
[manager] HEALTH_PROBE_BIND_ADDR=:8081
[manager] ENVOY_CONTROL_PLANE_BIND_ADDR=:18000
[manager] ENABLE_LEADER_ELECTION=false
[manager] LOG_LEVEL=INFO
[manager] WEBHOOK_CERTS_DIR=/tmp/k8s-webhook-server/serving-certs
[manager] ANALYTICS_ENABLED=true
[kube-rbac-proxy] I1011 12:57:17.430853       1 main.go:262] Generating self signed cert as no cert is provided
[manager]
[manager] {"level":"info","ts":1665493037.510534,"logger":"controller-runtime.metrics","caller":"logr@v1.2.3/logr.go:261","msg":"Metrics server is starting to listen","addr":"127.0.0.1:8080"}
[manager] {"level":"info","ts":1665493037.5108223,"logger":"setup","caller":"manager/main.go:244","msg":"Starting Envoy xDS API Server"}
[kube-rbac-proxy] I1011 12:57:17.686846       1 main.go:311] Starting TCP socket on 0.0.0.0:8443
[kube-rbac-proxy] I1011 12:57:17.686986       1 main.go:318] Listening securely on 0.0.0.0:8443
[manager] {"level":"info","ts":1665493037.5108833,"caller":"authz/authz.go:53","msg":"authz listening on","address":":19000"}
[manager] {"level":"info","ts":1665493037.5109699,"logger":"EnvoyConfigManager","caller":"manager/envoy_config_manager.go:79","msg":"control plane server listening","address":":18000"}
[manager] {"level":"info","ts":1665493038.3406372,"logger":"setup","caller":"manager/main.go:289","msg":"Starting K8s secrets watch for the TLS certificates renewal events"}
[manager] {"level":"info","ts":1665493039.900979,"logger":"setup","caller":"manager/main.go:309","msg":"Created admission webhook server certificates and updated K8s Manager's Admission configs with the generated CA certificate"}
[manager] {"level":"info","ts":1665493039.9010339,"logger":"setup","caller":"manager/main.go:311","msg":"Registering EnvoyFleet mutating and validating webhooks to the webhook server"}
[manager] {"level":"info","ts":1665493039.90111,"logger":"controller-runtime.webhook","caller":"webhook/server.go:148","msg":"Registering webhook","path":"/mutate-gateway-kusk-io-v1alpha1-envoyfleet"}
[manager] {"level":"info","ts":1665493039.9012144,"logger":"controller-runtime.webhook","caller":"webhook/server.go:148","msg":"Registering webhook","path":"/validate-gateway-kusk-io-v1alpha1-envoyfleet"}
[manager] {"level":"info","ts":1665493039.901379,"logger":"setup","caller":"manager/main.go:327","msg":"Registering API mutating and validating webhooks to the webhook server"}
[manager] {"level":"info","ts":1665493039.9014447,"logger":"controller-runtime.webhook","caller":"webhook/server.go:148","msg":"Registering webhook","path":"/mutate-gateway-kusk-io-v1alpha1-api"}
[manager] {"level":"info","ts":1665493039.9015114,"logger":"controller-runtime.webhook","caller":"webhook/server.go:148","msg":"Registering webhook","path":"/validate-gateway-kusk-io-v1alpha1-api"}
[manager] {"level":"info","ts":1665493039.90162,"logger":"setup","caller":"manager/main.go:343","msg":"Registering StaticRoute mutating and validating webhooks to the webhook server"}
[manager] {"level":"info","ts":1665493039.9016645,"logger":"controller-runtime.webhook","caller":"webhook/server.go:148","msg":"Registering webhook","path":"/mutate-gateway-kusk-io-v1alpha1-staticroute"}
[manager] {"level":"info","ts":1665493039.9017282,"logger":"controller-runtime.webhook","caller":"webhook/server.go:148","msg":"Registering webhook","path":"/validate-gateway-kusk-io-v1alpha1-staticroute"}
[manager] {"level":"info","ts":1665493039.9017673,"logger":"setup","caller":"manager/main.go:357","msg":"Starting manager"}
[manager] {"level":"info","ts":1665493039.901852,"logger":"controller-runtime.webhook.webhooks","caller":"webhook/server.go:216","msg":"Starting webhook server"}
[manager] {"level":"info","ts":1665493039.90191,"caller":"manager/internal.go:362","msg":"Starting server","kind":"health probe","addr":"[::]:8081"}
[manager] {"level":"info","ts":1665493039.9019277,"caller":"manager/internal.go:362","msg":"Starting server","path":"/metrics","kind":"metrics","addr":"127.0.0.1:8080"}
[manager] {"level":"info","ts":1665493039.902084,"logger":"controller-runtime.certwatcher","caller":"logr@v1.2.3/logr.go:261","msg":"Updated current TLS certificate"}
[manager] {"level":"info","ts":1665493039.902163,"logger":"controller-runtime.webhook","caller":"logr@v1.2.3/logr.go:261","msg":"Serving webhook server","host":"","port":9443}
[manager] {"level":"info","ts":1665493039.9021924,"logger":"controller-runtime.certwatcher","caller":"logr@v1.2.3/logr.go:261","msg":"Starting certificate watcher"}
[manager] {"level":"info","ts":1665493040.0029674,"caller":"controller/controller.go:185","msg":"Starting EventSource","controller":"envoyfleet","controllerGroup":"gateway.kusk.io","controllerKind":"EnvoyFleet","source":"kind source: *v1alpha1.EnvoyFleet"}
[manager] {"level":"info","ts":1665493040.003018,"caller":"controller/controller.go:185","msg":"Starting EventSource","controller":"staticroute","controllerGroup":"gateway.kusk.io","controllerKind":"StaticRoute","source":"kind source: *v1alpha1.StaticRoute"}
[manager] {"level":"info","ts":1665493040.0030375,"caller":"controller/controller.go:193","msg":"Starting Controller","controller":"envoyfleet","controllerGroup":"gateway.kusk.io","controllerKind":"EnvoyFleet"}
[manager] {"level":"info","ts":1665493040.0030437,"caller":"controller/controller.go:193","msg":"Starting Controller","controller":"staticroute","controllerGroup":"gateway.kusk.io","controllerKind":"StaticRoute"}
[manager] {"level":"info","ts":1665493040.0031295,"caller":"controller/controller.go:185","msg":"Starting EventSource","controller":"api","controllerGroup":"gateway.kusk.io","controllerKind":"API","source":"kind source: *v1alpha1.API"}
[manager] {"level":"info","ts":1665493040.0031805,"caller":"controller/controller.go:193","msg":"Starting Controller","controller":"api","controllerGroup":"gateway.kusk.io","controllerKind":"API"}
[manager] {"level":"info","ts":1665493040.1039643,"caller":"controller/controller.go:227","msg":"Starting workers","controller":"api","controllerGroup":"gateway.kusk.io","controllerKind":"API","worker count":1}
[manager] {"level":"info","ts":1665493040.1039562,"caller":"controller/controller.go:227","msg":"Starting workers","controller":"staticroute","controllerGroup":"gateway.kusk.io","controllerKind":"StaticRoute","worker count":1}
[manager] {"level":"info","ts":1665493040.1040132,"caller":"controller/controller.go:227","msg":"Starting workers","controller":"envoyfleet","controllerGroup":"gateway.kusk.io","controllerKind":"EnvoyFleet","worker count":1}
[manager] {"level":"info","ts":1665493040.1041217,"logger":"envoy-fleet-controller","caller":"controllers/envoyfleet_controller.go:68","msg":"EnvoyFleet changed","controller":"envoyfleet","controllerGroup":"gateway.kusk.io","controllerKind":"EnvoyFleet","envoyFleet":{"name":"default","namespace":"default"},"namespace":"default","name":"default","reconcileID":"10ddb422-9c9d-4596-8ba8-2996c1627e69","changed":"default/default"}
[manager] {"level":"info","ts":1665493040.4170942,"logger":"envoy-fleet-controller","caller":"controllers/envoyfleet_controller.go:113","msg":"Calling Config Manager due to change in Envoy Fleet resource","controller":"envoyfleet","controllerGroup":"gateway.kusk.io","controllerKind":"EnvoyFleet","envoyFleet":{"name":"default","namespace":"default"},"namespace":"default","name":"default","reconcileID":"10ddb422-9c9d-4596-8ba8-2996c1627e69","changed":"default/default"}
[manager] {"level":"info","ts":1665493040.4171255,"logger":"controller.config-manager","caller":"logr@v1.2.3/logr.go:261","msg":"Started updating configuration","fleet":"default.default"}
[manager] {"level":"info","ts":1665493040.417136,"logger":"controller.config-manager","caller":"logr@v1.2.3/logr.go:261","msg":"Getting APIs for the fleet","fleet":"default.default"}
[manager] {"level":"info","ts":1665493040.4184847,"logger":"controller.config-manager","caller":"logr@v1.2.3/logr.go:261","msg":"Successfully processed APIs","fleet":"default.default"}
[manager] {"level":"info","ts":1665493040.4185064,"logger":"controller.config-manager","caller":"logr@v1.2.3/logr.go:261","msg":"Getting Static Routes","fleet":"default.default"}
[manager] {"level":"info","ts":1665493040.4185386,"logger":"controller.config-manager","caller":"logr@v1.2.3/logr.go:261","msg":"Successfully processed Static Routes","fleet":"default.default"}
[manager] {"level":"info","ts":1665493040.4185548,"logger":"controller.config-manager","caller":"logr@v1.2.3/logr.go:261","msg":"Processing EnvoyFleet configuration","fleet":"default.default"}
[manager] {"level":"info","ts":1665493040.4209602,"logger":"controller.config-manager","caller":"logr@v1.2.3/logr.go:261","msg":"Generating configuration snapshot","fleet":"default.default"}
[manager] {"level":"info","ts":1665493040.4215462,"logger":"controller.config-manager","caller":"logr@v1.2.3/logr.go:261","msg":"Configuration snapshot was generated for the fleet","fleet":"default.default"}
[manager] {"level":"info","ts":1665493040.4216008,"logger":"CacheManager","caller":"manager/cache_manager.go:114","msg":"assigning active snapshot and updating all nodes","fleet":"default.default"}
[manager] {"level":"info","ts":1665493040.4216113,"logger":"controller.config-manager","caller":"logr@v1.2.3/logr.go:261","msg":"Configuration snapshot deployed for the fleet","fleet":"default.default"}
[manager] {"level":"info","ts":1665493040.4216185,"logger":"controller.config-manager","caller":"logr@v1.2.3/logr.go:261","msg":"Finished updating configuration","fleet":"default.default"}
[manager] {"level":"info","ts":1665493040.4216316,"logger":"envoy-fleet-controller","caller":"controllers/envoyfleet_controller.go:124","msg":"Reconciled EnvoyFleet 'default' resources","controller":"envoyfleet","controllerGroup":"gateway.kusk.io","controllerKind":"EnvoyFleet","envoyFleet":{"name":"default","namespace":"default"},"namespace":"default","name":"default","reconcileID":"10ddb422-9c9d-4596-8ba8-2996c1627e69"}
[manager] {"level":"error","ts":1665493047.4272718,"logger":"SnapshotCache","caller":"manager/envoy_snapshot_cache_logger.go:58","msg":"node does not exist","stacktrace":"github.com/kubeshop/kusk-gateway/internal/envoy/manager.EnvoySnapshotCacheLogger.Warnf\n\t/workspace/internal/envoy/manager/envoy_snapshot_cache_logger.go:58\ngithub.com/envoyproxy/go-control-plane/pkg/cache/v3.(*snapshotCache).GetStatusInfo\n\t/go/pkg/mod/github.com/envoyproxy/go-control-plane@v0.10.3/pkg/cache/v3/simple.go:588\ngithub.com/kubeshop/kusk-gateway/internal/envoy/manager.(*cacheManager).IsNodeExist\n\t/workspace/internal/envoy/manager/cache_manager.go:54\ngithub.com/kubeshop/kusk-gateway/internal/envoy/manager.(*Callbacks).OnStreamRequest\n\t/workspace/internal/envoy/manager/envoy_callbacks.go:65\ngithub.com/envoyproxy/go-control-plane/pkg/server/sotw/v3.(*server).process\n\t/go/pkg/mod/github.com/envoyproxy/go-control-plane@v0.10.3/pkg/server/sotw/v3/server.go:181\ngithub.com/envoyproxy/go-control-plane/pkg/server/sotw/v3.(*server).StreamHandler\n\t/go/pkg/mod/github.com/envoyproxy/go-control-plane@v0.10.3/pkg/server/sotw/v3/server.go:256\ngithub.com/envoyproxy/go-control-plane/pkg/server/v3.(*server).StreamHandler\n\t/go/pkg/mod/github.com/envoyproxy/go-control-plane@v0.10.3/pkg/server/v3/server.go:183\ngithub.com/envoyproxy/go-control-plane/pkg/server/v3.(*server).StreamRoutes\n\t/go/pkg/mod/github.com/envoyproxy/go-control-plane@v0.10.3/pkg/server/v3/server.go:199\ngithub.com/envoyproxy/go-control-plane/envoy/service/route/v3._RouteDiscoveryService_StreamRoutes_Handler\n\t/go/pkg/mod/github.com/envoyproxy/go-control-plane@v0.10.3/envoy/service/route/v3/rds.pb.go:341\ngoogle.golang.org/grpc.(*Server).processStreamingRPC\n\t/go/pkg/mod/google.golang.org/grpc@v1.47.0/server.go:1542\ngoogle.golang.org/grpc.(*Server).handleStream\n\t/go/pkg/mod/google.golang.org/grpc@v1.47.0/server.go:1624\ngoogle.golang.org/grpc.(*Server).serveStreams.func1.2\n\t/go/pkg/mod/google.golang.org/grpc@v1.47.0/server.go:922"}
[manager] {"level":"info","ts":1665493047.427347,"logger":"CacheManager","caller":"manager/cache_manager.go:82","msg":"setting new node snapshot","nodeID":"default-69d7898855-d76vr","fleet":"default.default"}
Watching for changes...
Generating tags...
 - kubeshop/kusk-gateway -> kubeshop/kusk-gateway:latest
Checking cache...
 - kubeshop/kusk-gateway: Not found. Building
Starting build...
Found [kgw] context, using local docker daemon.
Building [kubeshop/kusk-gateway]...
Target platforms: [linux/amd64]
[+] Building 15.9s (17/17) FINISHED
 => [internal] load build definition from Dockerfile                                                                                0.0s
 => => transferring dockerfile: 38B                                                                                0.0s
 => [internal] load .dockerignore                                                                                0.0s
 => => transferring context: 93B                                                                                0.0s
 => [internal] load metadata for gcr.io/distroless/static:nonroot                                                                                0.5s
 => [internal] load metadata for docker.io/library/golang:1.19-alpine                                                                                0.6s
 => CACHED [stage-1 1/4] FROM gcr.io/distroless/static:nonroot@sha256:380318dd91fd3bea73ae5fe1eb4d795ef7923f576e6f5f8d4de6ef1ea18ed540                                         0.0s
 => [builder 1/8] FROM docker.io/library/golang:1.19-alpine@sha256:f3e683657ddf73726b5717c2ff80cdcd9e9efb7d81f77e4948fada9a10dc7257                                            0.0s
 => [internal] load build context                                                                                0.0s
 => => transferring context: 49.34kB                                                                                0.0s
 => CACHED [builder 2/8] WORKDIR /workspace                                                                                0.0s
 => CACHED [builder 3/8] COPY go.mod go.mod                                                                                0.0s
 => CACHED [builder 4/8] COPY go.sum go.sum                                                                                0.0s
 => CACHED [builder 5/8] RUN go mod download                                                                                0.0s
 => [builder 6/8] COPY . .                                                                                0.1s
 => [builder 7/8] RUN GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build -v -ldflags "-X 'github.com/kubeshop/kusk-gateway/pkg/analytics.TelemetryToken=$TELEMETRY_TOKEN' -X 'gi  14.4s
 => [builder 8/8] RUN mkdir -m 00755 /opt/manager                                                                                0.3s
 => [stage-1 2/4] COPY --from=builder /workspace/manager .                                                                                0.0s
 => [stage-1 3/4] COPY --from=builder --chown=65532:65532 /opt/manager /opt/manager                                                                                0.0s
 => exporting to image                                                                                0.3s
 => => exporting layers                                                                                0.3s
 => => writing image sha256:87c1c6ca8dd29734a4b96c81c408e6369a34949822f7e35c98db15e7ee8cb60a                                                                                0.0s
 => => naming to docker.io/kubeshop/kusk-gateway:latest                                                                                0.0s
Build [kubeshop/kusk-gateway] succeeded
Tags used in deployment:
 - kubeshop/kusk-gateway -> kubeshop/kusk-gateway:87c1c6ca8dd29734a4b96c81c408e6369a34949822f7e35c98db15e7ee8cb60a
Starting deploy...
 - deployment.apps/kusk-gateway-manager configured
Waiting for deployments to stabilize...
 - kusk-system:deployment/kusk-gateway-manager: container manager terminated with exit code 1
    - kusk-system:pod/kusk-gateway-manager-8547cd469c-7bml5: container manager terminated with exit code 1
      > [kusk-gateway-manager-8547cd469c-7bml5 manager] METRICS_BIND_ADDR=127.0.0.1:8080
      > [kusk-gateway-manager-8547cd469c-7bml5 manager] HEALTH_PROBE_BIND_ADDR=:8081
      > [kusk-gateway-manager-8547cd469c-7bml5 manager] ENVOY_CONTROL_PLANE_BIND_ADDR=:18000
      > [kusk-gateway-manager-8547cd469c-7bml5 manager] ENABLE_LEADER_ELECTION=false
      > [kusk-gateway-manager-8547cd469c-7bml5 manager] LOG_LEVEL=INFO
      > [kusk-gateway-manager-8547cd469c-7bml5 manager] WEBHOOK_CERTS_DIR=/tmp/k8s-webhook-server/serving-certs
      > [kusk-gateway-manager-8547cd469c-7bml5 manager] ANALYTICS_ENABLED=true
 - kusk-system:deployment/kusk-gateway-manager failed. Error: container manager terminated with exit code 1.
WARN[0062] Skipping deploy due to error:1/1 deployment(s) failed  subtask=-1 task=DevLoop
Watching for changes...

Debugging
To start in debug mode run:
$ ./skaffold dev
$ dlv connect 127.0.0.1:56268
(dlv) stack
0  0x000000000044235d in runtime.gopark
   at /usr/local/go/src/runtime/proc.go:364
1  0x0000000000451e89 in runtime.selectgo
   at /usr/local/go/src/runtime/select.go:328
2  0x0000000001cc0f1f in sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).Start
   at /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.12.3/pkg/manager/internal.go:500
3  0x00000000023d051c in main.main
   at /workspace/cmd/manager/main.go:358
4  0x0000000000441f38 in runtime.main
   at /usr/local/go/src/runtime/proc.go:250
5  0x0000000000471e81 in runtime.goexit
   at /usr/local/go/src/runtime/asm_amd64.s:1594

As can seen from above, that's controller's stackframe.
TODO

Currently I've hardcoded a value runAsNonRoot: false in config/manager/manager.yaml to enable debugging. This isn't ideal or correct. There are better ways of doing this.
Multiple Platform Images: Investigate https://github.com/GoogleContainerTools/skaffold/tree/main/examples/custom-buildx.

References
See https://m0sh1x2.com/posts/optimizing-local-go-kubernetes-deployments/.
Signed-off-by: Mohamed Bana mohamed@bana.io

This is looking legit.
Can you add a README for it so it is easy for everyone to use it

Done in SKAFFOLD.md and linked to in README.md.

repo: kubeshop/kusk-gateway

license: MIT


text:
feature: dependency checking script should check version

Feature Description
It is a problem when the dependency checking script (hack/check_pre_req.sh) claims success but the dependency is at too old of a version.
Proposed Solution
Make the dependency checking script check the versions.
Want to contribute?

[ ] I would like to work on this issue.

Additional Context
If this feature had been present then issue #2491 would not have been raised (the user would have been told that they have too old a version of kflex).

It's not trivial to make it work in general

source: gharchive/issue

authors: MikeSpreitzer francostellari

repo: kubestellar/kubestellar


text:
✨  fix syncer / placement translator minor issue

Summary
The syncer and placement translator were refrencing pre-kcp and post-kcp md files which have been renamed to pre-provider and post-provider.
Related issue(s)
Fixes #

/lgtm
/approve

authors: effi-ofer ezrasilvera


text:
Kubevirt providers are "target" while vmWare and ovirt are "source"

Currently we show "Providers" of 3 types kubevirt, vmWare and oVirt
We need to inform users that "kubevirt" is a target cluster, you can only migrate workloads into it, while
oVirt and vmWare are source clusters and you can only use them to migrate workloads from.
tasks:
a - think what is the best way to inform users about the different providers
b - implement this in the UI

@rszwajko hi,
Now that we have the new list design, updating this issue with todo tasks:
TODO Tasks:
a. enhance the name column with a label indicating a provider if a "source" if it's not a "kubevirt" provider
b. enhance the name column with a label "default" if a kubevirt source is this cluster
c. enhance the "type" filter to have groups "sources" and "targets"
d. ( optional ) enhance the "type" filter with "descriptions" explaining about the different types

Closed by #91


text:
In workflowrun, the status of apply-app step is failed, but app status in vela cli shows ready

apply-app step failed in workflowrun:

but app is running well from vela cli:

component log:

I create the workflowrun in velaux web page, the yaml looks like:
`- name: build-push-image-test
alias: build-push-image-test
type: build-push-image
description: ''
orderIndex: 0
dependsOn: null
properties:
context:
branch: main
git: github.com/FogDong/simple-web-demo
credentials:
image:
key: .dockerconfigjson
name:
dockerfile: ./Dockerfile
image: >-

kanikoExecutor: oamdev/kaniko-executor:v1.9.1
verbosity: info

name: apply-app-test
alias: apply-app-test
type: apply-app
description: ''
orderIndex: 0
dependsOn: null
properties:
data:
apiVersion: core.oam.dev/v1beta1
kind: Application
metadata:
name: my-vela-app-ci-wkfl
namespace:
spec:
components:
- name: my-web-ci-wkfl
namespace:
properties:
image: >-

imagePullSecrets:
-
ports:
- expose: true
port: 80
type: webservice`

close

repo: kubevela/community


text:
May 24, 2022 Community Meeting Agenda

KubeVela Community Meetings
Every two weeks we host a community meeting to showcase new features, review upcoming milestones, and engage in Q&A with the KubeVela community - all are welcome, and we encourage participation.
The purpose of this thread is to form a discussion amongst the KubeVela community on potential topics to highlight during the meeting. If you have a topic you wish to present or learn more about, please comment and be sure to include your name and a short description of the topic.
The conversations in this thread will directly influence the meeting agenda for the community call on Tuesday May 24, 2022 07:30 AM PST. The meeting agenda will be finalized by a Community Call Host days prior to the meeting.
Thank you and we look forward to hearing your input.

Asset
Link

🔗 Meeting Link & Password (English)
Zoom Call: https://us02web.zoom.us/j/88638962723Password: MVhCZnNub2t0R3BmMUNEWE9vendLUT09

🎥 Meeting Recordings (English)
https://docs.google.com/document/d/1nqdFEyULekyksFHtFvgvFAYE-0AMHKoS3RMnaKsarjs

Meeting time
Tuesday May 24, 2022 07:30 AM Pacific Time (PST) - See it in your local time

Introduction to the key features in the KubeVela v1.4. beta release.
A demo of KubeVela Authentication & Authorization with multi clusters.

delivered


text:
[Feature]Air Gapped Kubevela Install

Is your feature request related to a problem? Please describe.
I want to intall Kubevela in air-gapped enviroment.
Describe the solution you'd like
A script that can download all images and other resources needed.
A script that can upload all resources to private repo.
A script that can install Kubevela and addon with private repo.
Describe alternatives you've considered
All-in-one install package.
Additional context

seems lots of users required this feature, working on process

please refer to https://kubevela.io/blog/2022/04/01/offline-deployment-practice for more details, it's Implemented now

authors: wanshicheng wonderflow

repo: kubevela/kubevela


text:
fix templates list filters and namespace changing

📝 Description
fix templates list filters and namespace changing
🎥 Demo

/lgtm

/retest

authors: glekner yaacov

repo: kubevirt-ui/kubevirt-plugin


text:
Bug 2139479: virtualization overview crashes for non-priv user

Signed-off-by: Aviv Turgeman aturgema@redhat.com
📝 Description

NamespaceBar component is causing issues for non-priv users, removed NamespaceBar component and injected via console-extensions

🎥 Demo
Before

After

/lgtm

/retest

authors: avivtur pcbailey


text:
Match builder image with project go version

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/lgtm

/approve

we actually should have closed this one, they merged a fix upstream and I take it into consideration in my PR #167 but never mind Ill rebase it..

authors: ShellyKa13 akalenyu mhenriks

repo: kubevirt/kubevirt-velero-plugin


text:
[prow] running a postsubmitted test failed with - fatal: Couldn't find remote ref deployment-strategy-recreate

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind enhancement

What happened:
Running a postsubmitted test failed with - fatal: Couldn't find remote ref deployment-strategy-recreate
The failure happened on nmstate/kubernetes-nmstate repo.
Link to the job - https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/logs/publish-kubernetes-nmstate/1275716907839787008
What you expected to happen:
Shoudn't fail.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version):
Kubernetes version (use kubectl version):
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

/triage build-officer

/cc @danielBelenky

/close
Moved to nmstate: https://github.com/nmstate/kubernetes-nmstate/issues/567

authors: AlonaKaplan rmohr

repo: kubevirt/kubevirt


text:
WIP - debug

What this PR does
Before this PR:
After this PR:

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

/test pull-kubevirt-e2e-k8s-1.30-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-compute

/test pull-kubevirt-e2e-k8s-1.30-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-compute


text:
virt-launcher, migration: Detach SRIOV devices before migration

What this PR does / why we need it:
Libvirt rejects a migration attempt when host-devices are attached.
In order to allow migration for a VMI with SRIOV devices, detach them
just before the migration is requested from libvirt.
The "detach" operation is not assured to be synchronic (i.e. blocking)
per the documentation (dependent on the hypervisor), therefore,
the flow waits for the device removal events before proceeding.
This change handles the SRIOV migration path at the source.
A separate change will introduce the handling on the target.
For simplicity, several points have not been handled intentionally at this stage:

Reverting the detached devices operation on migration failure (reattaching them back).
The guest PCI address is not passed to the target.

This PR also includes:

The labeling of the SRIOV host-device with "sriov-" prefix, to identify them when reading the domain spec.
Adding XMLName entry to HostDevice structure, allowing proper encoding to XML.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Depends on #4722
Tested locally (on a SRIOV setup) using #4723.
Without detaching the hostdevices, the following error is returned by libvirt upon executing the migration: Operation not supported: cannot migrate a domain with \u003chostdev mode='subsystem' type='pci'\u003e
Release note:
NONE

/uncc danielBelenky vatsalparekh

/uncc danielBelenky vatsalparekh

/cc @AlonaKaplan @ormergi

/cc @AlonaKaplan @ormergi

/cc @AlonaKaplan @ormergi

/cc @AlonaKaplan @ormergi

/cc @vladikr

/cc @vladikr

/retest

/retest

change: Just a rebase.

change: Just a rebase.

change: Fixed some review comments.

change: Fixed some review comments.

/retest

/retest

I think we need to use https://libvirt.org/html/libvirt-libvirt-nodedev.html#virNodeDeviceReAttach
right after the device is detached

I think we need to use https://libvirt.org/html/libvirt-libvirt-nodedev.html#virNodeDeviceReAttach
right after the device is detached

I think we need to add https://libvirt.org/html/libvirt-libvirt-nodedev.html#virNodeDeviceReAttach
right after the device is detached

We cannot do this, as the pod has not privileges on the node/host.
This may be in the scope of the SRIOV CNI/Device-Plugin, although in our case (VFIO mode) it is not needed or supported.

I think we need to add https://libvirt.org/html/libvirt-libvirt-nodedev.html#virNodeDeviceReAttach
right after the device is detached

We cannot do this, as the pod has not privileges on the node/host.
This may be in the scope of the SRIOV CNI/Device-Plugin, although in our case (VFIO mode) it is not needed or supported.

About the "detach" operation is not assured to be synchronic (i.e. blocking), could you refer to a relevant doc?
From what I saw on libvirt documentation it is not mentioned that DetachDevice is a-syncronus.

About the "detach" operation is not assured to be synchronic (i.e. blocking), could you refer to a relevant doc?
From what I saw on libvirt documentation it is not mentioned that DetachDevice is a-syncronus.

About the "detach" operation is not assured to be synchronic (i.e. blocking), could you refer to a relevant doc?
From what I saw on libvirt documentation it is not mentioned that DetachDevice is a-syncronus.

https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainDetachDeviceFlags

Beware that depending on the hypervisor and device type, detaching a device from a running domain may be asynchronous.

About the "detach" operation is not assured to be synchronic (i.e. blocking), could you refer to a relevant doc?
From what I saw on libvirt documentation it is not mentioned that DetachDevice is a-syncronus.

https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainDetachDeviceFlags

Beware that depending on the hypervisor and device type, detaching a device from a running domain may be asynchronous.

change: Added a newSRIOVAlias helper in the tests for creating the domain hostdev alias.

changes: Answered review comment.

change: Squashed the last commit into the prev one.

There is a need to add an e2e test to exercise this change (depends on #4722):

Allow the feature gate to open SRIOV VMI/s for migration (currently hard-blocked).
Test:

Open the feature-gate.
Create VMI.
Create VMIM (migration).
Check it succeeded.

As we are missing the CI part, it will be skipped so the CI will not run it. But it needs to run locally.
Once the changed for the CI are ready, the skip should be removed.

change: rebase

/retest

change: rebase (over the SRIOV feature-gate)

Without detaching the hostdevices, the following error is returned by libvirt upon executing the migration: Operation not supported: > cannot migrate a domain with \u003chostdev mode='subsystem' type='pci'\u003e

Please mention that even after this PR, migration will still be blocked.
Seems that before the detached code is merged, the code of this PR is a dead code.
Maybe we can drop the migration blocking and add a release note mentioning the sriov migration feature gate is experimental and will cause a detachemt of the sriov host device/s.

Without detaching the hostdevices, the following error is returned by libvirt upon executing the migration: Operation not supported: > cannot migrate a domain with \u003chostdev mode='subsystem' type='pci'\u003e

Please mention that even after this PR, migration will still be blocked.
Seems that before the detached code is merged, the code of this PR is a dead code.
Maybe we can drop the migration blocking and add a release note mentioning the sriov migration feature gate is experimental and will cause a detachemt of the sriov host device/s.

I will unlock it and reason why it is ok to do so (even without the attach on the other side).
I will add an e2e test and open the feature-gate in the test.

/retest

change: Answered review

change: answered review

change: Answered review.

/approve
/hold please update the release note.

/retest

Thank you for the reviews!
I have updated the release-notes.
/hold cancel

Investigating a problem detected during tests.
/hold

/retest

change: Workaround a limitation in the registration of events callbacks. Introduced as a separate commit with a detail explanation.

Verified on local setup, SRIOV tests are passing

change: Answered text comment.

Verified on local setup, SRIOV tests are passing

Thank you. Removing the hold.
/hold cancel

/retest

change: Rebase
Specifically, due to #5010

Verified on local setup after rebase, SRIOV tests are passing

/retest

authors: AlonaKaplan EdDev ormergi


text:
Add errcheck linter

What this PR does / why we need it:
This PR integrates the errcheck linter into nogo, and thus is executed as part of the build process - everytime you run make, this linter will be executed.
This PR only fixes the linting errors caught in the following directories:

tests
tools

A follow up PR will remove the following targets from the exclude list:

pkg/...
cmd/...

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Depends-on: #8054
Release note:

NONE

/hold until #8054 is merged ...

This is weird; I'm running make build-functests locally and this is passing. Then, failing on CI.
Seems every now and then I should make clean and start over.
Quite sure my work-flow is missing something. Any clues @rmohr ?

This is weird; I'm running make build-functests locally and this is passing. Then, failing on CI.
Seems every now and then I should make clean and start over.
Quite sure my work-flow is missing something. Any clues @rmohr ?

My initial thought would be that something got merged in the meantime on main which triggers errcheck. Let's have a closer look if a simple rebase on main does not solve this.

This is weird; I'm running make build-functests locally and this is passing. Then, failing on CI.
Seems every now and then I should make clean and start over.
Quite sure my work-flow is missing something. Any clues @rmohr ?

My initial thought would be that something got merged in the meantime on main which triggers errcheck. Let's have a closer look if a simple rebase on main does not solve this.

@maiqueb I checked out your code and played around with it yesterday evening. I was not able to reproduce your issue :/
What I ran into is this:
tests/network/port_forward.go:175:21: unchecked error (errcheck)

I could not get past this fail and the code does not look suspicious:
func testConnectivityThroughLocalPort(ipFamily k8sv1.IPFamily, portNumber int) error {
	return exec.Command("curl", fmt.Sprintf("%s:%d", libnet.GetLoopbackAddressForURL(ipFamily), portNumber)).Run()
}

I just ignored the file then to continue and did not see any other issues, but did you run into that too?
This could be a bug in nogo or the linter, probably also interesting to get a good pro/con picture.

This is weird; I'm running make build-functests locally and this is passing. Then, failing on CI.
Seems every now and then I should make clean and start over.
Quite sure my work-flow is missing something. Any clues @rmohr ?

My initial thought would be that something got merged in the meantime on main which triggers errcheck. Let's have a closer look if a simple rebase on main does not solve this.

@maiqueb I checked out your code and played around with it yesterday evening. I was not able to reproduce your issue :/
What I ran into is this:
tests/network/port_forward.go:175:21: unchecked error (errcheck)

I could not get past this fail and the code does not look suspicious:
func testConnectivityThroughLocalPort(ipFamily k8sv1.IPFamily, portNumber int) error {
	return exec.Command("curl", fmt.Sprintf("%s:%d", libnet.GetLoopbackAddressForURL(ipFamily), portNumber)).Run()
}

I just ignored the file then to continue and did not see any other issues, but did you run into that too?

Yeah, have that once before, and it just happened to me now; it reports:
compilepkg: nogo: errors found by nogo during build-time code analysis:
tests/replicaset_test.go:12:17: unchecked error (errcheck)

... those are just import numbers. Running make clean didn't help ..

This could be a bug in nogo or the linter, probably also interesting to get a good pro/con picture.

@rmohr I have now cleared this error ... It actually meant an error in the port-forward test...
I've also noticed that when it reports errors it sometimes reports the wrong line numbers (I guess it is using some cached files ?.... )

@rmohr I have now cleared this error ... It actually meant an error in the port-forward test...
I've also noticed that when it reports errors it sometimes reports the wrong line numbers (I guess it is using some cached files ?.... )

That should really not be the case. When playing around with the error I saw different line numbers (but not in a predictable way to my change). Will check it out, curious what this is. If this is a structural problem, definitely a strong con.

Must track https://github.com/kisielk/errcheck/pull/215 and wait for its merge.
Without that, we can report wrong line numbers.

Must track kisielk/errcheck#215 and wait for its merge.
Without that, we can report wrong line numbers.

In the meantime, if you like, you can use my fork (go mod edit -replace github.com/kisielk/errcheck=github.com/rmohr/errcheck@comments-before-package && make dep-sync) and continue to see how it goes.

/retest

just rebasing to make sure this doesn't lag behind too much ...
/test pull-kubevirt-generate
/test pull-kubevirt-unit-test
let's see how this fares with these simpler lanes ...

/test pull-kubevirt-e2e-k8s-1.22-sig-network
/test pull-kubevirt-e2e-k8s-1.23-sig-compute
/test pull-kubevirt-e2e-k8s-1.23-operator

/test pull-kubevirt-e2e-k8s-1.22-sig-network
/test pull-kubevirt-e2e-k8s-1.23-sig-compute
/test pull-kubevirt-e2e-k8s-1.23-operator

/test pull-kubevirt-build
/test pull-kubevirt-unit-test
/test pull-kubevirt-generate

Narrowed the scope of this PR down to something less ambitious but a lot more realistic.
Fingers crossed ...

Narrowed the scope of this PR down to something less ambitious but a lot more realistic.
Fingers crossed ...

:crossed_fingers:

/test pull-kubevirt-manifests

wow!
/hold cancel
Looks good.
@rmohr not sure I should expand the scope (remove more pkgs / files from the ignore list vs get this in now and expand later.

Looks good.
@rmohr not sure I should expand the scope (remove more pkgs / files from the ignore list vs get this in now and expand later.

I would leave the scope as is. On the next iteration I would go for production code, just because it would have the highest ROI, not that it would not also make sense for test code.

There seems to be a release tag now for errcheck if you want to bump to it before merging.

/lgtm
/approve

/test pull-kubevirt-e2e-k8s-1.23-sig-compute-migrations

/test pull-kubevirt-e2e-k8s-1.22-sig-compute
/test pull-kubevirt-e2e-kind-1.23-vgpu-nonroot

/test pull-kubevirt-e2e-k8s-1.23-sig-compute-migrations-nonroot

authors: maiqueb rmohr


text:
Update Top consumers dashboard titles

Signed-off-by: Shirly Radco sradco@redhat.com

/approve
/lgtm

authors: erkanerol sradco

repo: kubevirt/monitoring


text:
Default AWS provider - worker nodes fail to join cluster

$kubicorn version
{"Version":"master","GitCommit":"","BuildDate":"2018-07-02 12:21:28.951420752 +0000 UTC","GoVersion":"go1.10","GOOS":"linux","GOArch":"amd64"}
~/go/src/github.com/kubicorn/kubicorn
$git rev-parse HEAD
5914f8b1ee8beb76b1a64a28a44203f5b1d4becd

Trying out the aws provider, no worker nodes are brought up.
Looking at the cloud-init logs on the worker node, I see:
[preflight] Running pre-flight checks.
        [WARNING FileExisting-crictl]: crictl not found in system path
Suggestion: go get github.com/kubernetes-incubator/cri-tools/cmd/crictl
[preflight] Starting the kubelet service
discovery: Invalid value: "": using token-based discovery without DiscoveryTokenCACertHashes can be unsafe. set --discovery-token-unsafe-skip-ca-verification to continue
Cloud-init v. 17.1 running 'modules:final' at Mon, 02 Jul 2018 12:13:44 +0000. Up 10.04 seconds.
2018-07-02 12:14:15,421 - util.py[WARNING]: Failed running /var/lib/cloud/instance/scripts/part-001 [3]
2018-07-02 12:14:15,423 - cc_scripts_user.py[WARNING]: Failed to run module scripts-user (scripts in /var/lib/cloud/instance/scripts)
2018-07-02 12:14:15,424 - util.py[WARNING]: Running module scripts-user (<module 'cloudinit.config.cc_scripts_user' from '/usr/lib/python3/dist-packages/cloudinit/config/cc_scripts_user.py'>) failed
Cloud-init v. 17.1 finished at Mon, 02 Jul 2018 12:14:15 +0000. Datasource DataSourceEc2Local.  Up 40.74 seconds

Adjusting the launch configuration' s user data to use the switches used in https://github.com/kubicorn/bootstrap/blob/0602657f00474e8e4ec34d29aaf504463315ebbd/amazon_k8s_debian_stretch_node.sh#L52 and respawning a node, I now have a worker node and can deploy a test application.
If I've understood things correctly, the bootstrap scripts are pulled from github by kubicorn, not read from disk, so I can't really test the effect of making this change in-code. Nor am I sure whether it is desirable to bypass ca cert checking. I don't see an open issue relating to it.
The amazon_k8s_centos_7_node.sh bootstrap script is also missing this parameter.

Hi there!
Thank you so much for reporting the issue! I have merged kubicorn/bootstrap#17 and kubicorn/bootstrap#18 which should fix the issue. If problems persists, re-open the issue or create a new one.
About the local scripts, it's possible to use scripts from your local machine by setting the KUBICORN_FORCE_LOCAL_BOOTSTRAP environment variable, such as: KUBICORN_FORCE_LOCAL_BOOTSTRAP=1 kubicorn apply mycluster -v 4.
Thanks once again for reporting the issue!

Wow! That was fast!
Thanks for the info on the FORCE_LOCAL flag.
I've got some general questions about using profiles, but they might be better on Slack.

authors: benpriestman xmudrii

repo: kubicorn/kubicorn


text:
fix: not correctly reformatting yaml multiline strings

Fixes the YAML reformatting logic to handle multiline strings set on array objects which wasn’t accounted for.
Signed-off-by: Philipp Rudloff philipp.rudloff@konghq.com

If I use js-yaml and run the yaml used in the test case here through load and then dump and put the output in a <pre> I get this:

... which seems correct, unless I'm missing something?
I can think of one reason why we might not want to use this module, but putting that one aside for the moment, historically was there any reason why aren't using approach this for all our YAML displaying purposes? Feels like YAML parsing etc should be something we depend on.
lmk!

@johncowen To use a different library that already supports our reformatting needs is a good idea. I’m going to try if this works for all our use cases.

I’ve put up a working implementation of switching to js-yaml in https://github.com/kumahq/kuma-gui/pull/578/commits/62e1f754ee32bb040f0b18ffd85ccfdf0bb639bf. There are some differences that I accounted for and a few others that I’ve seen so far that shouldn’t block this change. Most notable is that depending on the source structure, we will now see more quoted values because the data contains the field as a string. This is mostly fine. In some cases, I needed to make adjustments to make sure the underlying data is of type number if the config is supposed to have a number field (e.g. for ports, see data plane proxy wizard).

Ok sounds good

Most notable is that depending on the source structure, we will now see more quoted values because the data contains the field as a string

^ That's another bug fix right? We saw some values that should have been quoted but weren't yesterday I think.

In some cases, I needed to make adjustments to make sure the underlying data is of type number if the config is supposed to have a number field (e.g. for ports, see data plane proxy wizard).

From what I understood from your comment there are some places were without your extra fix in here js-yaml sometimes shows strings instead of numbers. I took a quick scan (I really like that you made a thin helper function over js-yaml), but will have a proper look in the PR now

That's another bug fix right? We saw some values that should have been quoted but weren't yesterday I think.

Hm, good question. As far as I’m aware, strings can be unquoted in YAML as long as it’s unambiguous that it’s a string value. In any case, I prefer strings being quoted so that there is very visibly no ambiguity possible.

From what I understood from your comment there are some places were without your extra fix in here js-yaml sometimes shows strings instead of numbers. I took a quick scan (I really like that you made a thin helper function over js-yaml), but will have a proper look in the PR now

It’s rather that the object passed to toYaml contains string values when they should be numbers. With the previous utility, this didn’t matter because it would never quote them, but with js-yaml, string values are always quoted. Now if the value is actually intended to be a number, that would be wrong (e.g. port: '8080' when port is expected to be a number)

Ok gotcha. Yeah agree, all strings should be quoted.
I would imagine if the API gives us an unquoted number then it should be a number, whereas if its quoted it should be a string i.e. we are just displaying what the API says and if it's wrong then it's because the data we are given is wrong.
I'm not totally sure of all the usecases/potential historical things tho. Also, maybe I'm missing something re: js-yaml. Lemme look properly at this PR and maybe we can catch up if I have more q's

It’s rather that the object passed to toYaml contains string values when they should be numbers. With the previous utility, this didn’t matter because it would never quote them, but with js-yaml, string values are always quoted. Now if the value is actually intended to be a number, that would be wrong (e.g. port: '8080' when port is expected to be a number)

Ah ok so looking at the PR it looks like this is only when the 'numbers' are provided by the user via an input field (which would make them strings) so we have to cast them to numbers first before running them through js-yaml. If this is the case, this all makes sense to me.
I'm guessing that all the API responses will be correct as numbers/strings
Probably should re-word this:

Ok gotcha. Yeah agree, all strings should be quoted.

Ok gotcha. all non-strings should be quote-less.
I don't think its important that strings are quoted or not considering we are displaying YAML, whereas if its a number it shouldn't be quoted.
Anyway pretty sure this is good to go, let me take on last scan

Yes, the special cases that I needed to handle separately come from data that isn’t sourced from the API but in some way from the client side. I haven’t seen anything out of the ordinary for YAML based on API data.

authors: johncowen kleinfreund

repo: kumahq/kuma-gui


text:
Error: V plot index is missing

Hi there,
I'm receiving an error:
00:00:00.283	Error (/bds_atac/atac.bds, line 211, pos 26): V plot index is missing ( '-tss_enrich' )!
I suppose its at the QC step - would it be possible for someone to perhaps suggest how to provide this? Thank you!

Hi,
Which genome are you using? We currently have files for hg19 and mm9 but we plan to add support for other genomes (and genome builds) soon.
The relevant files can be downloaded using the instructions listed here:
https://github.com/kundajelab/bds_atac#genome-data
You may wish to modify the parts of the script that build the bowtie index if you already have one.
Let us know if you have any further issues.
Thanks!

For mm10 and hg38, genome data for ATAQC are currently not avaiable.
I have changed that error to a warning. c1c89d0b85a91f48e6f4ad980ba1ec076ea6ec5f
If genome data is missing for ATAQC, then the pipeline will disable ATAQC.

Hi, it was mm9.
I ended up re-loading genome files - appears it fixed the error. Thank you!

authors: PocketChangeJ csfoo leepc12


text:
Warning styles not coming through

My config:
'selector-no-type': [true, {
  ignore: ['descendant'],
  'severity': 'warning'
}],

And:
'selector-no-universal': [true, {
  'severity': 'warning'
}],

In my editor always Error styles:

My settings file:
{
    "user": {
        "debug": true,
        "delay": 0.25,
        "error_color": "FC1305",
        "gutter_theme": "Packages/SublimeLinter/gutter-themes/Circle/Circle.gutter-theme",
        "gutter_theme_excludes": [],
        "lint_mode": "background",
        "linters": {
            "eslint": {
                "@disable": false,
                "args": [],
                "excludes": []
            },
            "stylelint": {
                "@disable": false,
                "args": [
                    "--syntax",
                    "scss"
                ],
                "excludes": []
            }
        },
        "mark_style": "fill",
        "no_column_highlights_line": false,
        "passive_warnings": false,
        "paths": {
            "*": [],
            "linux": [],
            "osx": [],
            "windows": []
        },
        "python_paths": {
            "linux": [],
            "osx": [],
            "windows": []
        },
        "rc_search_limit": 3,
        "shell_timeout": 10,
        "show_errors_on_save": false,
        "show_marks_in_minimap": true,
        "syntax_map": {
            "html (django)": "html",
            "html (rails)": "html",
            "html 5": "html",
            "javascript (babel)": "javascript",
            "magicpython": "python",
            "php": "html",
            "python django": "python",
            "pythonimproved": "python"
        },
        "warning_color": "FFA500",
        "wrap_find": true
    }
}

NOTE:
"warning_color": "FFA500",
Not sure if I'm missing anything else?

Help I'm also facing the same issue, I can't get lint to perform although i could check it via debug mode on console. I already installed postcss stylelint both globally and locally and the warning not shown.
SublimeLinter: stylelint: new.css ['/home/arianraptor/.nvm/versions/node/v5.11.0/bin/node', '/home/arianraptor/.config/sublime-text-3/Packages/SublimeLinter-contrib-stylelint/stylelint_wrapper.js', '@', '--config', '/home/arianraptor/Projects/my-project/.stylelintrc']
SublimeLinter: stylelint output:

../../../../tmp/SublimeLinter3-arianraptor/new.css
 26:1  ✖  Unclosed block   CssSyntaxError

NOTE: I'm installing node via NVM

@chris-pearce @arianraptor My PR should probably fix your issue

authors: arianraptor chris-pearce niksy

license: mit

license_source: bigquery


text:
[New game]: Trivia Card

🎮 Game Request
It contains a grid of cards. When you click on the card, you get a question with 2 options. You can't click another card until you answer the question. If the option chosen is right, then the points on the card get added to your score and the background-color of the card  changes from red to green. If its wrong, then no points are added to the score and the background-color of the card stays as red.
Point down the features
Game points
Questions with 2 options
Correct answer changes card color from Red to Green and adds points to the final score
Wrong answer doesn't change the color and the card color stays Red and no points are added to the final score
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

/assign

Hey @shreyaslax !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @shreyaslax ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

authors: kunjgit shreyaslax

repo: kunjgit/GameZone


text:
[Documentation Bug]: Broken Links in README.md

Describe the bug ✍
The README.md file of the GameZone repository contains broken links. Several game names are listed as links, but they are not properly formatted or may be pointing to non-existent files or directories.
The broken links need to be fixed to ensure the smooth navigation and functionality of the documentation.
Step-by-step information to reproduce the bug 📄

Navigate to the README.md file of the GameZone repository.
Look for the list of games under the "Games" section.
Check each game name listed as a link.
Observe that several links are broken or improperly formatted.

Provide step by step information reproduce the bug 📄
I plan to address this issue by:
Reviewing the README.md file to identify all broken links.
Correcting the formatting of broken links or removing them if necessary.
Ensuring that all game names listed as links are functional and properly formatted.
Testing the updated README.md file to ensure all links are working as expected.
Select program in which you are contributing
No response
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @GUNJESH843 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

@ishita-43, this issue is a follow-up to your comment(https://github.com/kunjgit/GameZone/pull/4253#issuecomment-2156542043) on my previous PR,
Just had a small request, if you could label my PR as level2.
Thankyou

Hello
I would like to work on this issue

Hello , assign me this issue under GSSOC24

The issues are assigned on basis of first come first serve however you can create issues related to topic which are not still addressed

Hey @GUNJESH843 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


text:
[ Main website ]: Main website is not working properly

Title: Main website is not working properly
Description:
These bugs/enhancements are based on latest clone of the main project as well as published website.

Games don't load as they used to, both in latest clone and main website.
The scroller is not working properly , it hangs anytime anywhere, both in clone and website
There is not much difference between Dark mode and Light mode in clone as website color keeps changing every few seconds.
In footer section of latest clone there is a duplication of Socials
In the footer of website, Instagram link is not provided, but is provided in clone.
Pagination of contributors is not working , the buttons don't work
Html file contains inline style ,we need to move them to style.css for better maintainability of Html code
Some CSS files are getting very large , they should be separated into multiple files and there are CSS properties that are not used anywhere.
Previous and next button needs rearrangement as they look very odd with page number buttons and both are not of same size.
website also needs to be enhanced in terms of responsive design. for small screens the website don't adapt very well.

There may be some other functionality and bugs that may need to be addressed as we resolve these.
Solution steps
The steps to solve these issues can not  be explained before hand , They need to be addressed on the go as we go through codebase.
Although some of them can be explained

I would also like to remove the toggle between dark and light theme , making it permanently dark themed if you agree.
Remove the duplicated socials .
Move all style from Html to separate CSS file.
Adjust CSS of previous and next buttons to make them better inclined with the page.
Add CSS so that the website respond well to small screens

Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @mohitgedar! 🙂
It seems like you are not following proper guidelines !! 👀
Read documentation properly !!🙏
If you have any queries reach out to us on Discord🕹 .

Hey @mohitgedar !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @mohitgedar ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

authors: kunjgit mohitgedar


text:
Fully changed the UI of the game and added more functionalities

PR Description 📜
I have changed the UI of the prev Black_Jack game and made it more realistic.
This closes #1845

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Thank you soo much for contributing to our repository 💗

Thank you @Soumyajit2825 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@kunjgit I have added the game in the main readme
And also added the image in assets folder
Please check carefully

@kunjgit have you checked???

Thank you  @Soumyajit2825 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


text:
CMP funcs should move to a separate file or emmintrin.h

TYPE_FUNC_CMP_PD
FuncListCmp256Pd
g_FunListCmp256Pd
_cmp_eq_oq
_cmp_lt_os
...
These types and functions is currently defined in avxintrin.h, but used by avxintrin.h and avx512intrin.h. I suggest moving these codes to  a separate file or emmintrin.h. And the global  'g_FunListCmp256Pd' 's name should be g_FunListCmpPd, since it has nothing related with bitwidth. Then the intrinsic __mm_cmp_pd (may be implement later in emmintrin.h) could also utilize these codes.

In the new version, 'g_FunListCmpPd' is in immintrin.h, _mm_cmp_pd  and _mm256_cmp_pd are moved to immintrin.h. The new version will update soon.

In the new version, 'g_FunListCmpPd' is in immintrin.h, _mm_cmp_pd  and _mm256_cmp_pd are moved to immintrin.h. The new version will update soon.

authors: DreamyX zh-wei

repo: kunpengcompute/AvxToNeon


text:
Fix string case issue.

Fix string case issue.

\lgtm

repo: kunpengcompute/boostkit-bigdata


text:
add name template to sampleData ingest job's configMap reference

This PR fix error when specify custom guac.sampleData.jobName, the job configmap's name is templated but the reference in job's spec is not.
Templated job name also for consistency

Thanks @nduyphuong for the fix! You need to do a -s when doing the commit. For example: git commit -m "initial commit" -s. That will fix the DCO check.

@nduyphuong sorry for the delay! Can you please rebase the PR? It should trigger the test as well.

authors: nduyphuong pxp928 sunnyyip

repo: kusaridev/helm-charts


text:
Provide a function to set options

In a responsive Web app you may want to change the SmoothDND options on the fly to suite landscape vs portrait etc. Could you please add a function to do this - thanks.

hey @nevf
You can dispose and recreate it with the new set of options.

@kutlugsahin true, however if there are hundreds of elements (which in my app there is) then unwrapping and rewrapping etc. is quite a waste of time and resources, when all that is needed is to change the options.
All the more so on low powered devices like smartphones where responsive changes are more prevalent.

@nevf. This is true indeed in terms of performance. Lets put this in todo list. Cheers!

@kutlugsahin +1 Thanks.

authors: kutlugsahin nevf

repo: kutlugsahin/smooth-dnd


text:
Fixed comparison of identical strings

This function returned -1 when comparing identical strings. Now it returns 0.

Hi, I noticed this was still not merged looks like you missed my second commit :)

Hey @mjomble, thank you so much for this PR. I am very sorry for the long wait after you put in this work. This project and my motivation were in a bad spot. I recently did a lot of work to breathe new life into it (http://locutus.io/2016/05/announcing-locutus/). Unfortunately for your PR this also means it's currently outdated and cannot be merged as is.
I'll close this issues, but if this PR is still relevant to you, please re-open. You should then rebase with this project's master branch, make sure it complies with the contributing document (https://github.com/kvz/locutus/blob/master/CONTRIBUTING.md), and then we can merge this in, because the work really does look good to me.
Again, I'm very sorry for not having attended to this earlier, and putting you through all this extra hassle. I hope you'll agree that the project was in a dead-end street though, and with this new big push, we're going somewhere again.

No problem, will take a look at this in the near future.

Thanks a lot Andres!

authors: kvz mjomble

repo: kvz/phpjs


text:
can't run

docker: Error response from daemon: No command specified.

This is related to your local Docker environment, not a comet issue. You can try reinstalling Docker and Docker Compose or checking to see if it's the latest version.

Client: Docker Engine - Community
Version:           26.1.3
API version:       1.45
Go version:        go1.21.10
Git commit:        b72abbb
Built:             Thu May 16 08:33:49 2024
OS/Arch:           linux/amd64
Context:           default
docker run --dt \ --name naive \ --network host \ -v /etc/naive/config.json:/etc/naive/config.json \ --restart unless-stopped \ kwaabot/naive
docker: Error response from daemon: no command specified.

repo: kwaa/comet

license: WTFPL


text:
Can't get Authorization Bearer Token from request headers

I'm trying to build my first app (CF Worker) with itty-router and seem to be having issues with the headers.
I'm trying to use Authorization Bearer Token Header but when I try to get that from the headers I get undefined.
My previous projects used ExpressJS which returns headers as an object, is there some way I can do the same with itty?
Thanks.

Resolved :)

My favorite sort of tickets... the self-closing kind! :D

repo: kwhitley/itty-router