text:
[helm] support PodMonitor

Support PodMonitor for PrometheusOperator users.
Signed-off-by: Đặng Minh Dũng dungdm93@live.com

Hi @dungdm93
Thank you for your contribution!
I am concerned about this PR being merged because we do not use PrometheusOperator,
it is hard to review and maintain this for us.
If you maintain the feature, we intend to merge this.
Would you let me know your thought on this idea?

@toshipp This MR heavy inspire from Bitnami helm charts, therefore, the features are almost complete.
Here is an quick demo:

If there is any future issues, I'm very happy to help.

@dungdm93 I appreciate your help.
I delegate @satoru-takeuchi and @cupnes to further review, however, my quick thought is controller.metrics or node.metrics is too generic, it is actually for Prometheus Operator, so it may be better to be controller.metrics.PrometheusOperator, IMO.

@toshipp PrometheusOperator has several CRD PodMonitor, ServiceMonitor, Probe and Prometheus and  Alertmanager. So named as controller.metrics.PrometheusOperator make no scene.
Further more, metrics.podMonitor and metrics.serviceMonitor are de-factor in helm community.

@dungdm93 I mean controller.metrics.PrometheusOperator section is for PrometheusOperator, so add podMonitor to controller.metrics.PrometheusOperator.podMonitor.
I personally do not agree podMonitor put under metrics.
If other people want to add another metrics operator configuration, how we should do it? put it as controller.metrics.SomeOtherCR?
If you know how other projects treat this, let me know.

@toshipp Sorry, I mean podMonitor & serviceMonitor are de-factor (not with metrics prefix).
And yeah, in most charts it's located under metrics, some others is under prometheus (e.g cert-manager), or in root (e.g grafana). But I don't see any chart nested it in metrics.prometheusOperator.
metrics.prometheusOperator.podMonitor is bit more longer and harder for end-user, but I'm OK to change.
However, we should make final decision first, cc @cupnes, @satoru-takeuchi

@dungdm93 About podMonitor related paramer names, I consider metrics is ok. Current chart already use metrics as prometheus's metrics, for example, in node.metrics.enabled.
Thank you for adding new parameters and making some cleanups. I'll approve this PR after my trivial change request is reflected.

@satoru-takeuchi
metrics.enable is a predicate to add an annotation for prometheus rather than prometheus operator.
(And currently this style seems to be deprecated on upstream, https://github.com/prometheus/prometheus/pull/4131)
So two different settings in the same section confuse uses, IMO.

Updated. podMonitor are now node.prometheus.podMonitor and controller.prometheus.podMonitor
@toshipp, @@satoru-takeuchi could you take a look

authors: dungdm93 satoru-takeuchi toshipp

repo: topolvm/topolvm


text:
feat: check for diff in yarn.lock

Description
New PR check for diff in yarn.lock file after yarn install command
How to test
CI should fail
Review

[ ] Read CONTRIBUTING.md and Component API principles
[ ] Annotate all props in component with documentation
[ ] Create examples for component
[ ] Ensure that deployed demo has expected results and good examples
[ ] Ensure that tests pass by running yarn test
[ ] Ensure that visuals tests pass by running yarn test:visual. If not - check the documentation how to fix visual tests
[ ] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.

PR commands

List of available commands:

@toptal-bot run all - Run whole pipeline
@toptal-bot run build - Check build
@toptal-bot run visual - Run visual tests
@toptal-bot run deploy:documentation - Deploy documentation
@toptal-bot run package:alpha-release - Release alpha version

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

It seems this issue won’t be resolved as a PR check, due to --frozen-lockfile option that does not modify yarn.lock when not necessary. I will now close the PR and think of another approach

source: gharchive/pull-request

repo: toptal/picasso

license: MIT

license_type: permissive

license_source: github-api


text:
[Bug]: Is showing all steps at once the intended behavior?

Package Scope
@use-funnel/core, @use-funnel/react-router-dom
Bug description
https://github.com/user-attachments/assets/748971ed-f7b4-4bbe-be46-fb4145c3a42b
In the third step, only the second step should be displayed under the Dialog, but the first step is also visible simultaneously. Is showing all steps at once the intended behavior?
https://use-funnel-ex.vercel.app
https://github.com/fe-dudu/use-funnel-ex
Expected behavior
No response
To Reproduce
No response
Possible Solution
No response
etc.
No response

No, the "passwordStep" should be only visibled at overlay step "completeStep".
I'll check this out!

It has a bug when overlay step before step has event step (at example "passwordStep").
I'll fix it soon

This issue is fix at @use-funnel/react-router-dom@0.0.8! Thanks to find issue 🙇🏽

source: gharchive/issue

authors: fe-dudu minuukang

repo: toss/use-funnel


text:
ESP32-S3-BOX-3 not booting

I followed the BOX-3 support added via this MR: https://github.com/toverainc/willow/pull/263
tried flashing using https://feature-esp32-s3-box-3.willow-web-flash.pages.dev/
flashing seems to go well, until the resetting device message, but nothing happens after that
Wrote 16777216 bytes (4914697 compressed) at 0x0 in 88.335 seconds.
Hash of data verified.
Leaving...
Flash successful! Resetting your device.

no display, no boot, nothing shows up on my WAS client list.
If I disconnect and try to connect again, the flasher connects but then just freezes. The only way to recover is to use ESP Launcher to flash stock demo firmware again. I have tried multiple time, with same result
Any ideas how I can troubleshoot further?

I've been having similar issues. It happened to me when I used the wrong WAS url. The device cant boot (and wont show it on display). Because the logs on the webflasher dont work, you cannot guess what is wrong :D
try this flasher: https://feature-serial-output.willow-web-flash.pages.dev/   - it worked better for me to get logs.
So regarding your issue;
Do you have WAS running on local subnet? I do, the URL format that works for me is ws://192.168.1.41:8502/ws

Do you have WAS running on local subnet?
thanks @SamJongenelen, it was probably this. the device Wifi was on a different VLAN to the WAS. I had to add a firewall rule to get past that

I thought these kind of issue would be post boot, so never thought to bother about network configuration at flash stage
Also, thanks for the flasher, very useful. perhaps should be an option on webflasher too :)
All good, I've made progress now. closing this

authors: SamJongenelen ashishpandey

repo: toverainc/willow


text:
add benchmark script for ray backend

Signed-off-by: reiase reiase@gmail.com

/lgtm

authors: filip-halt reiase

repo: towhee-io/towhee


text:
add no cover to display mixin

Signed-off-by: jie.hou jie.hou@zilliz.com

/lgtm


text:
Create TritonModel class

Signed-off-by: Kaiyuan Hu kaiyuan.hu@zilliz.com

/approve
/lgtm

authors: Chiiizzzy junjiejiangjjj


text:
Fix image util annotations

Signed-off-by: Frank Liu frank.liu@zilliz.com
/cc Chiiizzzy

/lgtm

authors: filip-halt fzliu


text:
Implement --path argument

Resolves #408.

I followed the behavior of pip freeze when it using to its own --path and specifically observed how it behaves with --local and --user as well as with virtual envs.

Whoops, need to update some documentation

repo: tox-dev/pipdeptree


text:
SecureRandom backed by wrong Provider exception

PrngFixes is throwing exception on some devices (collected from crash log) such as

Samsung - GT I9663, GT I9082L, GT S7500, SCH R820
Onda - TM 7043XD
Sony - C5303
Lenovo
and more

Android version: 2.3.4, 2.3.6 | 4.1.1, 4.1.2, 4.2.2
java.lang.SecurityException: new SecureRandom() backed by wrong Provider: class com.tozny.crypto.android.AesCbcWithIntegrity$PrngFixes$LinuxPRNGSecureRandomProvider
   at com.tozny.crypto.android.AesCbcWithIntegrity$PrngFixes.installLinuxPRNGSecureRandom(AesCbcWithIntegrity.java:764)
   at com.tozny.crypto.android.AesCbcWithIntegrity$PrngFixes.apply(AesCbcWithIntegrity.java:684)
   at com.tozny.crypto.android.AesCbcWithIntegrity.fixPrng(AesCbcWithIntegrity.java:347)
   at com.tozny.crypto.android.AesCbcWithIntegrity.generateKeyFromPassword(AesCbcWithIntegrity.java:184)
   at com.tozny.crypto.android.AesCbcWithIntegrity.generateKeyFromPassword(AesCbcWithIntegrity.java:234)

Do you have the latest version of the library? There was a bug in Google's PRNG fix that we believe is addressed now in our version here:
https://github.com/tozny/java-aes-crypto/blob/master/aes-crypto/src/main/java/com/tozny/crypto/android/AesCbcWithIntegrity.java#L606
Some details are here:
https://github.com/tozny/java-aes-crypto/pull/11
thanks,
Isaac

Yes, I'm using the latest library.

xDragonZ,
Do you know if this happens when you set the ALLOW_BROKEN_PRNG flag to True?
thanks,
isaac

If I not mistaken the issue has been resolved after I set to "true"

authors: SyntaxPolice xDragonZ

repo: tozny/java-aes-crypto

license: mit

license_source: bigquery


text:
🛑 Asset Delivery is down

In 601e083, Asset Delivery (https://banland.xyz/asset/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Asset Delivery is back up in 94f57cb after 13 minutes.

repo: tp-link-extender/status

license: Unlicense


text:
Codec error with multiple LocalDateTie fields

I have a case class that looks like this:
case class Scientist(
    username: String,
    firstname: Option[String] = None,
    lastname: Option[String] = None,
    email: Option[String] = None,
    bio: Option[String] = None,
    deletionRequestedAt: Option[LocalDateTime] = None,
    deletedAt: Option[LocalDateTime] = None
)

and I've created a Codec that matches the class like so:
val scientist = (text ~ text.opt ~ text.opt ~ text.opt ~ text.opt ~ timestamp.opt ~ timestamp.opt).gimap[Scientist]

But I get this error:
[error] 16 |      .gcontramap[Scientist]
[error]    |                            ^
[error]    |Cannot construct a mapping between the source (which must be a twiddle-list type) and the specified target type com.osi.domain.Scientist (which must be a case class of the same structure)..
[error]    |I found:
[error]    |
[error]    |    skunk.util.Twiddler.product6[P, A, B, C, D, E, F](
[error]    |      com.osi.domain.Scientist.$asInstanceOf$[
[error]    |
[error]    |          (deriving.Mirror.Product{MirroredType = P; MirroredMonoType = P; MirroredElemTypes <: Tuple} &
[error]    |            scala.deriving.Mirror.Product{
[error]    |              MirroredMonoType = com.osi.domain.Scientist; MirroredType = com.osi.domain.Scientist;
[error]    |                MirroredLabel = ("Scientist" : String)
[error]    |            }
[error]    |          ){
[error]    |            MirroredElemTypes = (String, Option[String], Option[String], Option[String], Option[String], Option[java.time.LocalDateTime]
[error]    |              ,
[error]    |            Option[java.time.LocalDateTime]);
[error]    |              MirroredElemLabels = (("username" : String), ("firstname" : String), ("lastname" : String), ("email" : String),
[error]    |                ("bio" : String)
[error]    |              , ("deletionRequestedAt" : String), ("deletedAt" : String))
[error]    |          }
[error]    |
[error]    |      ]
[error]    |    ,
[error]    |      /* missing */
[error]    |        summon[(String, Option[String], Option[String], Option[String], Option[String], Option[java.time.LocalDateTime],
[error]    |          Option[java.time.LocalDateTime]
[error]    |        ) =:= ((String, Option[String]), Option[String], Option[String], Option[String], Option[java.time.LocalDateTime],
[error]    |          Option[java.time.LocalDateTime]
[error]    |        )]
[error]    |    )
[error]    |
[error]    |But no implicit values were found that match type (String, Option[String], Option[String], Option[String], Option[String], Option[java.time.LocalDateTime],
[error]    |  Option[java.time.LocalDateTime]
[error]    |) =:= ((String, Option[String]), Option[String], Option[String], Option[String], Option[java.time.LocalDateTime],
[error]    |  Option[java.time.LocalDateTime]
[error]    |).

The strange thing is that if I remove the last Option[LocalDateTime] property from the case class and the corresponding timestamp.opt from the codec it all seems to work.
Is this a bug or have I misunderstood something?

Are you using Scala 3? If so use text :* text.opt :* ... and then .pmap/.pcontramap/.pimap. The .gXmap methods are deprecated and only go up to 6 in Scala 3. I need to update the doc.

Ahh, yes I am using Scala 3, I'll give that a go today, thanks 👍

Yup that works, although the correct function is *: not :*

authors: PaperPlaneSoftware tpolecat

repo: tpolecat/skunk


text:
Token-viewer: missing "try again" button on partial error

The overall token-display succeeds but there should be a Try-Again button for the multimedia like there is for other failures.

Fixed by #57.

repo: tqtezos/TZComet


text:
Update http4s-backend to 3.8.12

Updates com.softwaremill.sttp.client3:http4s-backend from 3.6.2 to 3.8.12.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.client3", artifactId = "http4s-backend" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.softwaremill.sttp.client3", artifactId = "http4s-backend" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #187.


text:
[Book] Add custom dataset, loader and batcher detailed example

For use cases that differ from the typical examples we have, implementing a custom dataset with loader and batcher seems to be a common struggle among new users.
We should provide a detailed example to help with the user implementation.

Thank you for opening an issue for this, adding some info as a follow up to our chat:
from a new user's perspective I was missing a detailed explanation on how the Dataset, DataLoader and Batcher are related to each other, what exactly each of them is responsible for and how they should be constructed and used from scratch, when trying to work with new training data. The examples that are currently provided in the book are one level beyond that, because they conveniently use already available Datasets (like MNIST), so a very basic example from scratch would be very helpful to get an understanding on how to get your custom data into Burn.

authors: jin-eld laggui

repo: tracel-ai/burn


text:
HOTT-858 Enabled global styles

Sets govuk-body-m on all  tags and govuk-link on all  tags
Jira link
https://transformuk.atlassian.net/browse/HOTT-858
What?
I have added/removed/altered:

[x] set the govuk-global-styles env var

Why?
I am doing this because:

This will automatically set govuk-body-m on all  tags and govuk-link on all  tags
This avoids pages rendering incorrectly because of css classes missed on 'generic' parts of the page

Have you? (optional)

[ ] Reviewed view changes with stake holders
[x] Validated mobile responsive behaviour of view changes

Is there a risk of creating inconsistencies? e.g explicitly mentioning adding the class: govuk-body-m vs not adding them at all because we know it gets added automatically anyway?


text:
Horizontal ribbon

Is there ability to fill horizontal area between, for example in simple case, static price lines like in the attached image

Duplicate of #140

authors: glechic timocov

repo: tradingview/lightweight-charts


text:
feat: add topologySpreadConstraints option

What does this PR do?

Motivation
I wanna use topologySpreadConstraints.
More

[ ] Yes, I updated the chart version

Additional Notes

dups https://github.com/traefik/traefik-helm-chart/pull/466
fixes https://github.com/traefik/traefik-helm-chart/issues/465

repo: traefik/traefik-helm-chart


text:
Ipwhitelist with error middleware

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
Hi,
I want to create a maintenance mode with ipwhitelist middleware and error middleware like my service returns a 403 forbidden like that gets caugth by error middleware:

FROM CLIENT:

A client try to get our dashboard -> whitelist IP get a 403 forbiden
The 403 forbiden is caugth by our error service and return an html maintenance page with css

FROM Admin:
I set up a VPN to bypass whitelist IP and access to the full application
If I change the middleware order -> get 403 forbiden with no error_page
If I use chain middleware -> get 403 forbiden with no error_page
I saw some discussion about that:
https://community.traefik.io/t/combine-ipwhitelist-and-errors-middlewares-is-it-possible/13381
Just I want to know if it's possible to combine whitelistIP and error middleware and maybe what I did wrong to load html but not the css ...
What did you see instead?
FROM CLIENT:

A client try to get our dashboard -> whitelist IP get a 403 forbiden
The 403 forbiden is caugth by our error service and return an html maintenance page
-> That works but all content is not loaded (css gets blocked)

FROM Admin:
I set up a VPN to bypass whitelist IP and access to the full application
If I change the middleware order -> get 403 forbiden with no error_page
If I use chain middleware -> get 403 forbiden with no error_page

What version of Traefik are you using?
traefik 2.10.1
What is your environment & configuration?

global:
  sendAnonymousUsage: false
  checkNewVersion: false
  #insecureSNI: false

entryPoints:
  web:
    address: ":80"
    http:
      redirections:
        entryPoint:
          to: websecure
          scheme: https
          permanent: true
  websecure:
    address: ":443"
    http:
      middlewares:
        - SecHeaders@file
      tls:
        certResolver: letsencrypt
        domains:
          - main: "${PUBLIC_DOMAIN}"
            sans:
              - "*.${PUBLIC_DOMAIN}"
        options: security
  metrics:
    address: :8082

ping:
  manualRouting: true

certificatesResolvers:
  letsencrypt:
    acme:
      email: ${EMAIL}
#      caServer: https://acme-staging-v02.api.letsencrypt.org/directory
      caServer: https://acme-v02.api.letsencrypt.org/directory
      storage: /certificate/acme/acme.json
      keyType: EC256
      dnsChallenge:
        provider: ovh
        delayBeforeCheck: 10
        resolvers:
          - "1.1.1.1:53"
          - "8.8.8.8:53"
      #httpChallenge:
      #  entryPoint: foobar

api:
  #insecure: true
  dashboard: true
  debug: false

log:
  #filePath: "/etc/traefik/applog.log"
  level: INFO
  format: json

accessLog:
  filePath: "/var/log/traefik-access.log"
  format: json

providers:
  docker:
    endpoint: http://dockersocket:2375
    exposedByDefault: false
    watch: true
    swarmMode: true
    network: traefik-public
    constraints: "Label(`traefik.external`, `true`)"
  file:
    directory: /etc/traefik/dynamic-conf/
    watch: true

metrics:
  prometheus:
    addEntryPointsLabels: true
    addRoutersLabels: true
    addServicesLabels: true
    entryPoint: metrics
    buckets:
      - 0.1
      - 0.3
      - 1.2
      - 5.0

If applicable, please paste the log output in DEBUG level
No response

Hello @bdoublet91,
Thank you for your interest in Traefik!
Currently, the error middleware in Traefik is designed to handle only a single response, typically serving a simple error page. This limitation means that it cannot directly serve associated resources such as CSS files needed for styling the error page.
To achieve the desired functionality of serving associated resources (like CSS), you can use a dedicated router to serve these static files.
Here is an example of how you can configure Traefik to serve static files using a dedicated router:

http:
  routers:
    # Define the main router that uses the error middleware
    my-router:
      rule: "Host(`example.com`)"
      service: my-service
      middlewares:
        - error-pages
    # Define a router for serving static files (CSS)
    static-files-router:
      rule: "Host(`example.com`) && PathPrefix(`/static/`)"
      service: static-file-server

  services:
    my-service:
      loadBalancer:
        servers:
          - url: "http://your-app"

    static-file-server:
      loadBalancer:
        servers:
          - url: "http://your-static-file-server"

    error-service:
      loadBalancer:
        servers:
          - url: "http://your-error-page-server"

  middlewares:
    error-pages:
      errors:
        status:
          - "400-599"
        service: error-service
        query: "/error.html"

In this example:
my-router is your main router that includes the error middleware.
static-files-router is the router handling requests for static files, such as CSS.
The static files are served from http://your-static-file-server/static/.

This way, you can ensure that your error pages can reference and utilize external CSS files.
The GitHub issue tracker is dedicated to bug and feature requests.
For help on your configuration, please join our Community Forum and reach out to us on the Traefik section.
We will close this issue accordingly but feel free to re-open it if you think that we missed something.

repo: traefik/traefik


text:
📌 FROM Containous TO Traefik 🚀 ✨

Routing "whoami" from Containous to Traefik ... more information on that later! :speak_no_evil: :detective:
:heart: :heart: :heart:

Dear everyone,
Traefik turns 5 years old today :birthday: !
What an incredible ride thanks to all of you!
We’re celebrating this by:

giving Traefik’s home a new name: Traefik Labs
by releasing a new product: Traefik Pilot
and by sharing our vision for the future of cloud-native networking

Happy birthday Traefik!
https://twitter.com/traefik/status/1308747253738360833

repo: traefik/whoami


text:
Swift button variants: primary / secondary / tertiary

So these button types don't support swappable ? 🤔 Only Button ?

Correct. You swap Button and all button variants will use your swapped implementation

authors: Ignelios mikasdo

repo: trafi/maas-components


text:
Zeros embedded in subject and issuer fields when using certificates generated with makecert (e.g. self-signed for test-signing during driver development)

It appears as if makecert writes Windows-style wchar_t* into these fields verbatim instead of encoding them as, say, UTF-8. This is an issue as it will lead to the strings being interpreted as single-character string, given every other character is a zero byte.
I worked around this locally by creating a function that filters these:
static inline std::string filter_escaped_zero_bytes(char const* instr)
{
    auto input = std::string(instr);
    static std::string const needle = "\\x00";
    std::ostringstream os;
    std::size_t currpos = 0, oldpos{};
    do
    {
        oldpos = currpos;
        currpos = input.find(needle, currpos);
        if (std::string::npos == currpos)
        {
            break;
        }
        os << input.substr(oldpos, currpos - oldpos);
        currpos += needle.size();
    } while (true);
    os << input.substr(oldpos); // remainder
    return os.str();
}

... and using that in the ctor (Certificate::Certificate):
subject_ = filter_escaped_zero_bytes(subject.get());
issuer_ = filter_escaped_zero_bytes(issuer.get());

Not sure this is an issue you'll want to address at all, since it appears that MS and its makecert tool deviate from the standard here. Just wanted to bring this to your attention as well as to the attention of those watching the project.
Feel free to close this pretty much immediately.
PS: this isn't particularly optimized, because I only ever encountered this with those certificates created by makecert and we only use these in testing scenarios. But I'm sure there is still some room for improvement.

The subject and issuer are both exposed as std::string intentionally, since consumers should treat them as a (ptr, len) pair that may have all kinds of weird bytes internally (such as embedded NULLs).

Ah, never mind -- I forgot that we call X509_NAME_oneline which boils it down to char *, causing all this pain. I think we need to replace that call with X509_NAME_print_ex and pass in ASN1_STRFLGS_UTF8_CONVERT, which will perform the UTF-8 conversion.

Isn't ASN1_STRFLGS_UTF8_CONVERT for ASN1_STRING_print_ex() as opposed to X509_NAME_print_ex()? What am I missing?

It's supported by both: from the OpenSSL docs:

The complete set of the flags supported by X509_NAME_print_ex() is listed below.
...
Additionally all the options supported by ASN1_STRING_print_ex() can be used to control how each field value is displayed.

From man 3 X509_NAME_print_ex, also here: https://docs.openssl.org/3.4/man3/X509_NAME_print_ex/
My understanding is that flag should work, but there might be other flags that have similar behavior that have better/more suitable behavior. I haven't gone through all of them 🙂

Yep, it does work. PR incoming for that one.

Ouch, this is trickier than I thought. Getting the name out isn't a problem. But getting it out in the old form is. I can't seem to come up with a combination of flags that could emulate the old behavior of X509_NAME_oneline.
The flag that would seem to make most sense — XN_FLAG_ONELINE — doesn't work. Example for the issuer field:
C = US, O = "DigiCert, Inc.", CN = DigiCert Trusted G4 Code Signing RSA4096 SHA384 2021 CA1

The flag XN_FLAG_RFC2253 looks saner in general, but may not be desirable due to the escaping:
CN=DigiCert Trusted G4 Code Signing RSA4096 SHA384 2021 CA1,O=DigiCert\, Inc.,C=US

Original form with X509_NAME_oneline():
/C=US/O=DigiCert, Inc./CN=DigiCert Trusted G4 Code Signing RSA4096 SHA384 2021 CA1

The most notable difference being the inverse order.
In other words, without going through hoops it will be hard to retain backwards-compatibility. I reckon the correct approach would use X509_NAME_cmp or X509_cmp instead of relying on string representations for comparison. But I know from experience that folks will nevertheless opt to do string comparison and complain bitterly if the format doesn't comply with their particular expectation.

One method that may work would be XN_FLAG_RFC2253 & (~XN_FLAG_DN_REV) which mimics the old order, but then would require some post-processing to deal with:

missing leading slash
replacing commas by slashes
unnecessary escape sequences

Without that it still looks like this:
C=US,O=DigiCert\, Inc.,CN=DigiCert Trusted G4 Code Signing RSA4096 SHA384 2021 CA1

Please advise, @woodruffw ...

Hmm, that's unfortunate. I'm of two minds on this:

uthenticode doesn't stipulate that get_subject() returns a consistent format, and our current encoding is arguably bad and should be changed anyways (since it's specific to OpenSSL, not a standard encoding of Distinguished Names.
More generally, this suggests that get_subject() -> string is probably too high-level of an API: I added that originally just for pretty-printing, not for people to do bytewise comparisons with 🙂

So, I think we should do two things here:

get_subject() should use XN_FLAG_RFC2253. That'll be a compatibility break technically, but we never guaranteed the string format anyways. If you think that'll be too disruptive in 2.x though, we'll document it and do it with a 3.0 series release.
We should probably add a new API, something like get_subject_components() or similar, which returns a vector<string> of all of the DN's entries, serialized individually. I think this can be done with X509_NAME_entry_count and X509_NAME_get_entry.

For now, (1) is probably fine though. (2) is something we can consider if users actually complain and want low-level access to each name component.

authors: hugmyndakassi woodruffw

repo: trailofbits/uthenticode


text:
Failed to cmake in Ubuntu 18.04

When I tried to execute cmake --preset ninja-multi-default     --toolchain ./cmake/lld.toolchain.cmake     -DCMAKE_PREFIX_PATH=/data/llvm-project/build/cmake/modules/CMakeFiles/LLVMConfig.cmake -DCMAKE_CXX_COMPILER=/usr/bin/gcc -DCMAKE_C_COMPILER=/usr/bin/gcc . It turned out to be:
Preset CMake variables:

  CMAKE_CONFIGURATION_TYPES="Release;RelWithDebInfo;Debug"
  ENABLE_TESTING="ON"

-- The C compiler identification is GNU 7.5.0
-- The CXX compiler identification is GNU 7.5.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - failed
-- Check for working C compiler: /usr/bin/gcc
-- Check for working C compiler: /usr/bin/gcc - broken
CMake Error at /usr/local/lib/python3.9/site-packages/cmake/data/share/cmake-3.25/Modules/CMakeTestCCompiler.cmake:70 (message):
  The C compiler

    "/usr/bin/gcc"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /data/vast/builds/ninja-multi-default/CMakeFiles/CMakeScratch/TryCompile-McD7Y0

    Run Build Command(s):/usr/local/bin/ninja cmTC_1af60 && [1/2] Building C object CMakeFiles/cmTC_1af60.dir/Debug/testCCompiler.c.o
    [2/2] Linking C executable Debug/cmTC_1af60
    FAILED: Debug/cmTC_1af60
    : && /usr/bin/gcc -g -fuse-ld=lld CMakeFiles/cmTC_1af60.dir/Debug/testCCompiler.c.o -o Debug/cmTC_1af60   && :
    collect2: fatal error: cannot find 'ld'
    compilation terminated.
    ninja: build stopped: subcommand failed.

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:28 (project)

-- Configuring incomplete, errors occurred!
See also "/data/vast/builds/ninja-multi-default/CMakeFiles/CMakeOutput.log".
See also "/data/vast/builds/ninja-multi-default/CMakeFiles/CMakeError.log".

GCC version: 7.5.0
Could anyone know what should I do next?

Do you have ld installed? What does gcc -print-prog-name=ld and which ld says?
You are probably missing libc6-dev package.
Also I am afraid you won't be able to compile vast with gcc 7.5, as vast requires C++20
features not supported in that version.
There is a Dockerfile .devcontainer/ if you want to try the tool.

@xlauko Thank you for your reply. I tried to use the dockerfile provided, but when I tried to excute cmake --preset ninja-multi-default \     --toolchain ./cmake/lld.toolchain.cmake \     -DCMAKE_PREFIX_PATH=/lib/llvm-15/cmake/LLVMConfig.cmake. It turned out to be :
Preset CMake variables:

  CMAKE_CONFIGURATION_TYPES="Release;RelWithDebInfo;Debug"
  ENABLE_TESTING="ON"

-- Install prefix: /usr/local
-- Found LLVM 15.0.7
-- Using LLVMConfig.cmake in: /usr/lib/llvm-15/cmake
-- Using MLIRConfig.cmake in: /usr/lib/llvm-15/lib/cmake/mlir
CMake Error at /usr/lib/llvm-14/lib/cmake/clang/ClangTargets.cmake:750 (message):
  The imported target "clangBasic" references the file

     "/usr/lib/llvm-14/lib/libclangBasic.a"

  but this file does not exist.  Possible reasons include:

  * The file was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and contained

     "/usr/lib/llvm-14/lib/cmake/clang/ClangTargets.cmake"

  but not all the files it references.

Call Stack (most recent call first):
  /usr/lib/cmake/clang-14/ClangConfig.cmake:19 (include)
  CMakeLists.txt:97 (find_package)

-- Configuring incomplete, errors occurred!
See also "/data/xcy/vast/builds/ninja-multi-default/CMakeFiles/CMakeOutput.log".

Could you tell me what should I do next?

@xlauko Thank you for your reply. I tried to use the dockerfile provided, but when I tried to excute cmake --preset ninja-multi-default \     --toolchain ./cmake/lld.toolchain.cmake \     -DCMAKE_PREFIX_PATH=/lib/llvm-15/cmake/LLVMConfig.cmake. It turned out to be :
Preset CMake variables:

  CMAKE_CONFIGURATION_TYPES="Release;RelWithDebInfo;Debug"
  ENABLE_TESTING="ON"

-- Install prefix: /usr/local
-- Found LLVM 15.0.7
-- Using LLVMConfig.cmake in: /usr/lib/llvm-15/cmake
-- Using MLIRConfig.cmake in: /usr/lib/llvm-15/lib/cmake/mlir
CMake Error at /usr/lib/llvm-14/lib/cmake/clang/ClangTargets.cmake:750 (message):
  The imported target "clangBasic" references the file

     "/usr/lib/llvm-14/lib/libclangBasic.a"

  but this file does not exist.  Possible reasons include:

  * The file was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and contained

     "/usr/lib/llvm-14/lib/cmake/clang/ClangTargets.cmake"

  but not all the files it references.

Call Stack (most recent call first):
  /usr/lib/cmake/clang-14/ClangConfig.cmake:19 (include)
  CMakeLists.txt:97 (find_package)

-- Configuring incomplete, errors occurred!
See also "/data/xcy/vast/builds/ninja-multi-default/CMakeFiles/CMakeOutput.log".

Could you tell me what should I do next?

authors: XCY-Joestar xlauko

repo: trailofbits/vast


text:
Response code 401 (Unauthorized) on users/id/lists/list_id

Recently I've been starting to get a 401 error while trying to retrieve some featured lists data using the users/id/lists or users/id/lists/list_id. In the docs it is stated that OAuth is optional for this endpoints (https://trakt.docs.apiary.io/#reference/users/list/get-personal-list), but perhaps something has since changed?
Example Request:
GET: https://api.trakt.tv/users/andreofgyn/lists/10747986
Error: HTTPError: Response code 401 (Unauthorized)
at EventEmitter. (.../node_modules/got/dist/source/as-promise.js:118:31)

I got a 200 response when trying that URL with a valid Authorization header. It also got a 200 when not sending the Authorization header (which is fine since it's a public resource). I got a 401 when sending an invalid Authorization header.
Are you sure the access token is valid?

Thanks for the quick reply on this matter.
Interesting I am currently using trackt.tv (https://github.com/vankasteelj/trakt.tv/issues) package for a cleaner code (and a bit of laziness if I am honest) to access all the endpoints. I never used Auth within it so it comes as a surprised that i was getting the 401 for a public resource. I mostly query movies, tv series and lists to construct a series of carousels to be served to a client app (the instance on the client for Trakt.tv does have auth and it works without issues).
The only call failing is the one with the lists, the one for shows or movies works just fine (using the exact same instance).
This is how i configure said instance:
const trakt = (req, res, next) => {
  let { clientId, clientSecret } = req.config.trakt;

  let options = {
    client_id: clientId,
    client_secret: clientSecret,
    pagination: true,
    debug: true,
    plugins: {
      // cached: require("trakt.tv-cached"),
      queued: require("trakt.tv-queued"),
    },
    options: {
      queued: {
        concurrency: 2,
        delay: 1,
      },
    },
  };

  const traktInstance = new Trakt(options);
  req.trakt = traktInstance;

  next();
};

Nothing fancy at all. I wonder if underneath the hood the js library for Trakt is doing something else when it comes to calling lists, perhaps since it is optional it sends an empty one which is then rejected?

Here is how I called the API directly, is that working for you? If so, it seems like a potential issue with the library you're using.
curl -i -H "trakt-api-version: 2" -H "Content-type: application/json" -H "trakt-api-key: API_KEY" --compressed https://api.trakt.tv/users/andreofgyn/lists/10747986

Thanks for the example, that helps me clarify that this is not an issue on Trakt side, as in terminal that works perfectly, but rather something to do with the library, will dive in its code to determine where it takes place.

authors: rectifyer tomacotuna

repo: trakt/api-help


text:
Mmayo/mb 15434/include ppm shipments in weight calculations

Jira ticket for this change
Summary
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Setup to Run Your Code

💻 You will need to use three separate terminals to test this locally.
Terminal 1
Start the Storybook locally.
make storybook

Terminal 2
Start the UI locally.
make client_run

Terminal 3
Start the Go server locally.
make server_run

Additional steps

Access the
Login as a

Verification Steps for Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

Frontend

[ ] User facing changes have been reviewed by design.
[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] There are no new console errors in the browser devtools
[ ] There are no new console errors in the test output
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

Screenshots

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against c9965290759046ba9054bacac7630530f7c34df6

authors: mmayo-truss robot-mymove

repo: transcom/mymove


text:
Added test for send to staging

Description
There is a new test called Test_SendStgNotification that sends a real notification to the live staging environment.
You can run the test by running all webhook tests
go test ./cmd/webhook-client/webhook -v
But do check for the successful passing of Test_SendStgNotification
Reviewer Notes
I also renamed db-webhook-notify to just webhook-notify as db was unnecessary.
Reference

MB-6193 Push Deploy: Write e2e test for webhook client - Jira

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 21b2e42996622910abf14130479a81a6824d91f3

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 21b2e42996622910abf14130479a81a6824d91f3

authors: robot-mymove shimonacarvalho


text:
Add migration to regrant permissions to crud user

Summary
It was discovered recently that creating a new view in the demo environment is not being created with permissions for the MilMove database user crud to access it. This results in a error pq: permission denied for view duty_stations error.

this slack thread
this other thread
see these migrations

migrations/app/schema/20210113173236_create_crud_role.up.sql

Possibly related migrations

migrations/app/schema/20201230070814_fix_ecs_user_in_docker.up.sql
migrations/app/schema/20190129115001_master_role.up.sql
migrations/app/secure/20190129115416_ecs_user_for_rds.up.sql
migrations/app/secure/20190726151515_grant_all_ecs_user.up.sql

This needs to be tested in experimental or demo to find out if the migration as it is would be best or if there is something else going on that is preventing permissions from being on the view. Alternate solution that worked but would require a GRANT statement for every future view.
GRANT SELECT, INSERT, UPDATE, DELETE ON duty_stations TO crud;
GRANT SELECT, INSERT, UPDATE, DELETE ON move_to_gbloc TO crud;

Setup to Run Your Code
I can't replicate this locally. I checked and my local db has a crud user but that user has the correct permissions on the view. If you can replicate it locally reseting the database in exp or demo won't be needed to experiment with it. I do have this deployed to Demo for now.
Additional steps

Log into the office in demo and ensure no 500 error.
Use the api to retrieve move with code 7799QT from demo

Verification Steps for Author
These are to be checked by the author.

[X] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[X] Request review from a member of a different team.

Verification Steps for Reviewers
These are to be checked by a reviewer.

Frontend

[ ] User facing changes have been reviewed by design.
[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] There are no new console errors in the browser devtools
[ ] There are no new console errors in the test output
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against e955f55e180f01720951a395373218ae040dc860

Thank you! Please merge when ready!

authors: ahobson gidjin robot-mymove


text:
Feature Request: Add JSON Content-Type option for authorization token refresh

Your Environment

Plugin version: 5.0.0
Platform: Android
Plugin config provided to #ready:

{
  url: `${import.meta.env.VITE_SUPABASE_URL}/functions/v1/upload_location`,
  authorization: {
    accessToken: session.access_token,
    refreshToken: session.refresh_token,
    expires: session.expires_in,
    strategy: "JWT",
    refreshUrl: `${import.meta.env.VITE_SUPABASE_URL}/auth/v1/token?grant_type=refresh_token`,
    refreshPayload: {
      refresh_token: "{refreshToken}",
    },
    refreshHeaders: {
      "content-type": "application/json",
    }
  },
  method: "POST",
}

Expected Behavior
The request should be made with a JSON body
Actual Behavior
The request is made with a form body
Context
I'm trying to refresh the supabase access token, which requires a JSON body
Debug logs

Logs
// BackgroundGeolocation.onAuthorization event
{"code":400,"msg":"Could not read refresh token grant params: unexpected end of JSON input"}

Hey! I'm having the same issue, did you find any workaround? or do we just have to wait until the feature is implemented?

authors: mimissuri niko-gardenanet


text:
Module '"node:crypto"' has no default export

I got the below error while trying to test it at WSL 2 (Ubuntu under Windows), thanks
$ ls
demos  docs  license  main.js  media  node_modules  package-lock.json  package.json  pnpm-lock.yaml  readme.md  src  tsconfig.json  tsup.config.ts  typedoc.json
$ cd demos
$ ls
demo-conversation.ts  demo-on-progress.ts  demo.ts
$ npx tsc demo-conversation.ts
../src/bing-chat.ts:1:8 - error TS1192: Module '"node:crypto"' has no default export.

1 import crypto from 'node:crypto'
         ~~~~~~

../src/bing-chat.ts:3:8 - error TS1259: Module '"/home/hajsf/bing-chat/node_modules/@types/ws/index"' can only be default-imported using the 'esModuleInterop' flag

3 import WebSocket from 'ws'
         ~~~~~~~~~

  ../node_modules/@types/ws/index.d.ts:398:1
    398 export = WebSocket;
        ~~~~~~~~~~~~~~~~~~~
    This module is declared with 'export =', and can only be used with a default import when using the 'esModuleInterop' flag.

Found 2 errors in the same file, starting at: ../src/bing-chat.ts:1

You're supposed to run this using Deno. "node:crypto" is Deno syntax for the built-in crypto module.
:)

You're supposed to run this using Deno. "node:crypto" is Deno syntax for the built-in crypto module.
Deno removes the need to compile Typescript. It's way better, trust me. :)

No; node:crypto is the new standard way of defining imports in Node.js. Deno may support this too (I haven't tested), but this package is meant to be used from Node.js 16+.
@hajsf it looks like a problem with your environment, possibly node.js version, TS version, build chain, etc. Not sure.

You're supposed to run this using Deno. "node:crypto" is Deno syntax for the built-in crypto module.
Deno removes the need to compile Typescript. It's way better, trust me. :)

No; node:crypto is the new standard way of defining imports in Node.js. Deno may support this too (I haven't tested), but this package is meant to be used from Node.js 16+.
@hajsf it looks like a problem with your environment, possibly node.js version, TS version, build chain, etc. Not sure.

Oh. Whoops. I assumed Deno since it uses that exact same syntax for importing it's Node polyfills.

Speaking of Deno, were you able to get this package working with Deno? I keep getting WebSocket error: Error: Unexpected server response: 400

Speaking of Deno, were you able to get this package working with Deno? I keep getting WebSocket error: Error: Unexpected server response: 400

Bad request. You're probably doing something wrong.

authors: Erisfiregamer1 Roosteridk hajsf transitive-bullshit

repo: transitive-bullshit/bing-chat


text:
🛑 TechinAsia_WordPress_API is down

In a31935d, TechinAsia_WordPress_API (https://www.techinasia.com/wp-json/techinasia/2.0/posts) was down:

HTTP code: 403
Response time: 219 ms

Resolved: TechinAsia_WordPress_API is back up in b90b2f4 after 7 minutes.

repo: traqy/upptime


text:
🛑 TechinAsia is down

In 927ecb4, TechinAsia (https://www.techinasia.com) was down:

HTTP code: 403
Response time: 754 ms

Resolved: TechinAsia is back up in d4008ae after 9 minutes.


text:
🛑 TechinAsia is down

In e095d39, TechinAsia (https://www.techinasia.com) was down:

HTTP code: 403
Response time: 753 ms

Resolved: TechinAsia is back up in 50b04de after 11 minutes.


text:
🛑 TechinAsia_WordPress_API is down

In c6df0aa, TechinAsia_WordPress_API (https://www.techinasia.com/wp-json/techinasia/2.0/posts) was down:

HTTP code: 403
Response time: 221 ms

Resolved: TechinAsia_WordPress_API is back up in 992e877 after 15 minutes.


text:
🛑 TechinAsia_WordPress_API is down

In fd588ac, TechinAsia_WordPress_API (https://www.techinasia.com/wp-json/techinasia/2.0/posts) was down:

HTTP code: 403
Response time: 234 ms

Resolved: TechinAsia_WordPress_API is back up in 4740d36 after 9 minutes.


text:
🛑 TechinAsia_WordPress_API is down

In 696b5cd, TechinAsia_WordPress_API (https://www.techinasia.com/wp-json/techinasia/2.0/posts) was down:

HTTP code: 403
Response time: 172 ms

Resolved: TechinAsia_WordPress_API is back up in f60ad8c after 7 minutes.


text:
Run tests with yarn if yarn.lock exists

Was moving to Yarn and we noticed tests are still being run from npm.

I'm not sure if this should go in here. https://yarnpkg.com/en/docs/cli/test says that this is effective only when script is defined in package.json. While it is not impossible to detect this, it seems to me that the user should know to override script in such a case.

https://yarnpkg.com/en/docs/cli/test says that this is effective only when script is defined in package.json.

That's the case for npm as well: https://docs.npmjs.com/cli/test so it doesn't change that behaviour.
I know it's possible to change script yourself, but I think it would be a little nicer for Travis to do it automatically.

Oh! How right you are! In that case, this makes sense. Have you looked into the spec failures?

These failed due to the server responded with status 403, I don't think that's due to my changes?

I see. The error comes from GitHub API rate limiting, I think. :-/
I'll retry.

@BanzaiMan, it's a slightly different concern (though we're affected in thelounge/lounge#1987 as well) but GH issues are not enabled on this, so let me ask here: when switching to Yarn, does the npm registry deploys correctly use yarn publish instead of npm publish?
As you can see, we're using it here and I prefer to make sure before we complete thelounge/lounge#1987).

@astorije Are you asking about deployment with npm? If so, the answer is "no". It only uses the npm publish command.

@xPaw Please open a corresponding docs PR. Thanks!

@BanzaiMan Wasn't sure how to write it nicely, but here's the pr: https://github.com/travis-ci/docs-travis-ci-com/pull/1698

It only uses the npm publish command.

@xPaw, do you think you could look into Yarnifying the npm deploys as well? 🙏
Also, you'll need to rebase this branch with master.

@astorije That would have to be a new deploy process, publishing with Yarn when deploy is explicitly named npm would be odd. I don't want to look into that.

Nah, in my understanding of the docs and other deployments, it's named after the provider, not the tool being used. That's why for Ruby the provider is called rubygems and not gem, etc.
So it's safe(r) to do the same thing you did here at deployment time, because we both know mixing up npm/yarn commands does not always end well (and failing a deployment is the last thing we did...).

Unless there is a good reason to use yarn instead of npm to deploy, it seems rather unnecessary.

@BanzaiMan The reason would be avoiding npm CLI (as yarn is implemented separately, second opinion and all that).

@BanzaiMan, additionally it would be using yarn instead of npm when already installing and testing with yarn. Use a single CLI tool for the entire chain.

Just FYI, yarn publish can't be used in scripts just yet because it expects interactivity. https://github.com/yarnpkg/yarn/issues/610

Deployment is all about deploying the code. It does not matter what tool is used (npm or yarn or plain API calls to accomplish the task. If the existing machinery accomplishes the task, adding support for a new tool is a liability, not a feature.
So far, I have not seen anything to indicate that using yarn brings any benefit to our use case.

@BanzaiMan, it would be good measure to use the same tool on the entire chain. If the entire chain minus deploying is done with one tool, and deploying (the crucial piece) is done with another one, then issues could potentially be discovered only at deploy time.
That said, as @xPaw mentioned and linked to, yarn publish is not totally ready for prod usage yet, so that's a moot point for now.
Going back to the current PR, any chance this could get in? @xPaw, would you mind rebasing your branch on master?

@BanzaiMan so is this PR good to go?

Yup. Planning to merge and deploy tomorrow. Thanks!

authors: BanzaiMan astorije xPaw

repo: travis-ci/travis-build


text:
Update sbt-scalafmt to 2.4.6

Updates org.scalameta:sbt-scalafmt from 2.4.3 to 2.4.6.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "sbt-scalafmt" } ]

labels: sbt-plugin-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #362 (d7d8e4b) into main (df19298) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage   59.87%   59.87%
=======================================
  Files          30       30
  Lines         987      987
  Branches       64       64
=======================================
  Hits          591      591
  Misses        396      396

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df19298...d7d8e4b. Read the comment docs.

Superseded by #419.

authors: codecov-commenter scala-steward

repo: travisbrown/dhallj


text:
16.0.0 updates

Merges master into dhall-lang/16.0.0, updates the dhall-lang version, and rebuilds dhall-prelude with dhall-javagen.

Closing because I think I want to use a slightly different approach for supporting specific Dhall versions.


text:
Default to lazy setup (and an additional check).

In relation to https://github.com/trbs/pid/issues/4.
The following PR is a culmination of fixing the following issue:
with pid.PidFile(lazy=True):
    # (1) pid is locked at this point
    pidfile2 = pid.PidFile(lazy=True)
    with raising(pid.PidFileAlreadyRunningError):
        # (2) the pidfile2._setup() isn't called when performing check()
        pidfile2.check()

I made a test and the appropriate fix to support double lazy checks. I then tried the testsuite defaulting lazy=True and that also worked. Furthermore, I moved the logging to the _setup() phase, because we cannot make assumptions whether the internal logging stream handle would be available after daemonization. It isn't elegant but I beleive it is the correct approach when combining pid with a daemon manager.

Coverage decreased (-0.37%) to 88.89% when pulling 59a61f8dd39fa6c7418a5775f028f9f2a796a14f on nnathan:lazy into b233bfebdce258a835e9654de77bb78015006761 on trbs:lazy.

You inferred the correct case, I like the third approach best. Let me fix up the code (after testing) and let's reevaluate the PR.

trbs, thanks for the feedback. I've implemented the suggested changes:
(1) use the logger property to automatically setup a logging instance (and clean up close()),
(2) remove the term_signal_handler you introduced, I didn't really see the obvious solution was to simply set the register_term_signal_handler=False. I was very confused by the TERM signal handler because I'm not quite familiar with atexit(), but now I understand the intentions when implementing this option.

Coverage decreased (-0.37%) to 88.89% when pulling 17692d1b05c91915ba633c11b8b471a6af3c5e5a on nnathan:lazy into b233bfebdce258a835e9654de77bb78015006761 on trbs:lazy.

Coverage decreased (-0.37%) to 88.89% when pulling 17692d1b05c91915ba633c11b8b471a6af3c5e5a on nnathan:lazy into b233bfebdce258a835e9654de77bb78015006761 on trbs:lazy.

Coverage decreased (-0.45%) to 88.82% when pulling 1cb6565c8e1ed681d26164462141ff2ee48d179b on nnathan:lazy into b233bfebdce258a835e9654de77bb78015006761 on trbs:lazy.

Nice !

authors: coveralls nnathan trbs

repo: trbs/pid


text:
FYI: Trealla trashes effort to port a C-compiler

Windows11/msys2/clang version 18.1.2
InstalledDir: C:/msys64/ucrt64/bin

$ CC=clang make test
Running tests/tests/test065.pl ...
Segmentation fault

#0  0x00007ff6b0f66a10 in sl_set ()
#1  0x00007ff6b0f3a986 in copy_vars ()
#2  0x00007ff6b0f3acb8 in deep_copy_to_tmp_with_replacement ()
#3  0x00007ff6b0f3ae73 in deep_copy_to_heap ()
#4  0x00007ff6b0eeac7b in do_duplicate_term ()
#5  0x00007ff6b0f643f0 in start ()
#6  0x00007ff6b0f4d052 in run ()
#7  0x00007ff6b0f41e0a in load_fp ()
#8  0x00007ff6b0f3d251 in load_file ()
#9  0x00007ff6b0f5e0a3 in pl_consult ()
#10 0x00007ff6b0e71c16 in main ()

This happens after copy_term/2 (test065.pl Line 107) has been 'called' roughly 20.000 times
while Linux and Termux 'calls' copy_term/2 roughly 200.000 times finishing the test successful.

Interesting: Android/Termux/clang version 18.1.2 -- No problem!
Interesting: Windows/msys2//clang version 17.0.6 -- No problem!

Right now I do not have Linux/clang v18.1.2 but expecting to get it soon(Fedora40).

I can only try clang-16 & clang-17 on Ubuntu, and no problem.
On Sun, Mar 31, 2024 at 1:24 PM flexoron @.***> wrote:

Windows/msys2/clang version 18.1.2
InstalledDir: C:/msys64/ucrt64/bin
$ CC=clang make test
Running tests/tests/test065.pl ...
Segmentation fault
#0  0x00007ff6b0f66a10 in sl_set ()
#1  0x00007ff6b0f3a986 in copy_vars ()
#2  0x00007ff6b0f3acb8 in deep_copy_to_tmp_with_replacement ()
#3  0x00007ff6b0f3ae73 in deep_copy_to_heap ()
#4  0x00007ff6b0eeac7b in do_duplicate_term ()
#5  0x00007ff6b0f643f0 in start ()
#6  0x00007ff6b0f4d052 in run ()
#7  0x00007ff6b0f41e0a in load_fp ()
#8  0x00007ff6b0f3d251 in load_file ()
#9  0x00007ff6b0f5e0a3 in pl_consult ()
#10 0x00007ff6b0e71c16 in main ()
This happens after copy_term/2 (test065.pl Line 107) has been 'called' roughly 20.000 times
while Linux and Termux 'calls' copy_term/2 roughly 200.000 times finishing the test successful.
Interesting: Android/Termux/clang version 18.1.2 -- No problem!
Interesting: Windows/msys2//clang version 17.0.6 -- No problem!
Right now I do not have Linux/clang v18.1.2 but expecting to get it soon(Fedora40).
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/issues/520, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSEXV3353IFGFOTDW7ALY256VJAVCNFSM6AAAAABFQB65B6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYTMNZVG4YTQMI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Neither clang-17 on Windows(and Linux) nor clang-18 on Android does produce the fault.
Clang-18 on Windows comes under suspicion.
Closing because it is an FYI (for now :)

Windows is meaningless to me.
On Tue, Apr 2, 2024 at 9:48 AM flexoron @.***> wrote:

FYI:
I decided to discard Windows11/Msys2 as worthless.
After reinstalling msys2 and clang-18 I get four more unexplainable issues.
More crap work:
The msys2-independent installation of the provided
Trealla/tpl-windows-x64.zip file
fails finishing test065.pl, too. It seems gcc-compiled stuff is infected
as well.
And what more could one want? The pty device is unusable:
?- length(L,N).
L = [], N = 0
; % Space is not passed on, you've to press the Enter key.
And if you configure tty(and all those workarounds) to get the space
immediately other terminal-functionality is broken.
Conclusion: Who gives a sh.t.
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/issues/520#issuecomment-2030805659,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSEQNUAACGKCAMA3JTZTY3HW43AVCNFSM6AAAAABFQB65B6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZQHAYDKNRVHE
.
You are receiving this because you commented.Message ID:
@.***>

In contrast: The latest Linux/Intel/oneAPI C-Compiler performs flawlessly.

And what more could one want? The pty device is unusable: ?- length(L,N). L = [], N = 0 ; % Space is not passed on, you've to press the Enter key. And if you configure tty(and all those workarounds) to get the space immediately other terminal-functionality is broken. Conclusion: Who gives a sh.t.

It should be possible to compile with GNU readline (remove ISOCLINE=1) if the msys2 version is installed. I found Isocline not very good, it was only there when I once played with the idea of a true native port to Windows.

I can't imagine any licensing issues with an open source program.
On Wed, 3 Apr 2024, 21:23 guregu, @.***> wrote:

I think the main reason I went with isocline for the Windows release is
because distributing readline statically linked would cause some GPL
issues… maybe? There are other readline alternatives that are probably
better
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/issues/520#issuecomment-2034308681,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSERLFUSDDJJD33Z5MPDY3PRBJAVCNFSM6AAAAABFQB65B6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZUGMYDQNRYGE
.
You are receiving this because you commented.Message ID:
@.***>

Isocline is not good because the developer ignores all issues for a long time: https://github.com/daanx/isocline/issues/11
Isocline is good because it is a lot easier to implement an integrated, sophisticated(working) signal handling.
Readline does not solve the Windows11/TTY issue either.
(msys2/bash and windows/powershell show the same behaviour).

Hmm, might be worth trying something like https://github.com/jart/bestline
I was looking into porting Trealla to cosmopolitan libc and got it mostly working besides the readline bits, which led me to bestline, but I haven't played with it yet. It says it supports cmd.exe though, so maybe better?
The WASM port also has issues due to the lack of raw terminal support, but things have changed a lot in the last year or so, so it's probably worth a revisit.

@guregu Thank you for this link.
Very interesting!
First thing I see is that ppl using bestline found same thing which I tried to address with Isocline:
https://github.com/jart/bestline/issues/22
Seems this issue has been solved with cosmopolitan libc (and worth examining it).

authors: flexoron guregu infradig

repo: trealla-prolog/trealla


text:
Syntax: extended syntax for integers incomplete

Currently,  only spaces and underscores may be included in an integer. This does not help much for very large numbers. Here, we need at least newlines and even better just general layout in between. But only if an integer ends with _ . So an integer that ends with _ is the analogon to \ for double quoted lists and the like.  In this manner one can transmit big integers also when the line width is limited. And layouts are a good idea, since sometimes it is helpful to add some redundant information (how far we are, or intermediate checksums - think of 9^9^9) or page breaks which may need some obscure page break code that may be hidden within comments somehow. Otherwise people invent their own format (they did this for CLP(Q) some time ago, e.g.).
I was very much favoring also 1 000 to permit ISO numbers, but it seems there is no other language doing this and 1_000 doesn't look that bad (and it is much better than using commas for separation which are ruled out explicitly by ISO 31).
?- number_chars(12,"1_\n2").
   error(syntax_error(number),number_chars/2), unexpected.
?- number_chars(12,"1_\n2").
   true. % expected, currently not the case

The problem is integer parsing is done by the big integer library, so if it
doesn't support it it means a custom mod.
On Fri, Jun 17, 2022 at 12:17 AM UWN @.***> wrote:

Currently, only spaces and underscores may be included in an integer. This
does not help much for very large numbers. Here, we need at least newlines
and even better just general layout in between. But only if an integer ends
with _ . So an integers that ends with _ is the analogon to \ for double
quoted lists and the like. In this manner one can transmit big integers
also when the line width is limited. And layouts are a good idea, since
sometimes it is helpful to add some redundant information (how far we are,
or intermediate checksums - think of 9^9^9) or page breaks which may need
some obscure page break code that may be hidden within comments somehow.
Otherwise people invent their own format (they did this for CLP(Q) some
time ago, e.g.).
I was very much favoring also 1 000 to permit ISO numbers
http://en.wikipedia.org/wiki/ISO_31-0#Numbers, but it seems there is no
other language doing this and 1_000 doesn't look that bad.
?- number_chars(12,"1_\n2").
error(syntax_error(number),number_chars/2), unexpected.
?- number_chars(12,"1_\n2").
true. % expected, currently not the case
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/issues/593, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSEXBQSHW452VXN5HIMLVPMZPNANCNFSM5Y662Q2Q
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

?- number_chars(12,"1_\n2").
   true.
?- number_chars(12,"1_\n\n2").
   true.
?- number_chars(12,"1_\n/* A page separating line */\n2").
   error(syntax_error(float),number_chars/2), unexpected.

Easy to fix, but why?
On Mon, 20 June 2022, 16:25 UWN, @.***> wrote:

?- number_chars(12,"1_\n2").
true.
?- number_chars(12,"1_\n\n2").
true.
?- number_chars(12,"1_\n/* A page separating line */\n2").
error(syntax_error(float),number_chars/2), unexpected.
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/issues/593#issuecomment-1160025853,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSEVGNGUWPABGT3XUJR3VQAFHJANCNFSM5Y662Q2Q
.
You are receiving this because you commented.Message ID:
@.***>

Easy to fix, but why?

See above:

And layouts are a good idea, since sometimes it is helpful to add some redundant information (how far we are, or intermediate checksums - think of 9^9^9) or page breaks which may need some obscure page break code that may be hidden within comments somehow. Otherwise people invent their own format (they did this for CLP(Q) some time ago, e.g.).

I should have said layout text in place of layouts.

Seems it was the 'e' in 'page' that was triggering syntax error. It was
expecting a comment there.
On Mon, Jun 20, 2022 at 4:25 PM UWN @.***> wrote:

?- number_chars(12,"1_\n2").
true.
?- number_chars(12,"1_\n\n2").
true.
?- number_chars(12,"1_\n/* A page separating line */\n2").
error(syntax_error(float),number_chars/2), unexpected.
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/issues/593#issuecomment-1160025853,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSEVGNGUWPABGT3XUJR3VQAFHJANCNFSM5Y662Q2Q
.
You are receiving this because you commented.Message ID:
@.***>

Which e?
?- number_chars(12,"1_\n/* Pagæéèêëэɛɜɝʚέήεη𝔢𝕖ｪㅔⅇ */\n2").
   true.

hmm, fiddly
?- Number is 1_ _2.
   Number = 12.
?- Number is 1_ .
   Number = 1.
?- Number is 1_.
Error: syntax error, near '_', operator expected

@flexoron:
``
?- Number is 1_ 2.
Number = 12.
?- Number is 1 .
Number = 1.
?- Number is 1_.
Error: syntax error, near '_', operator expected
All three should rather be errors.

A bit harsh to say...
?- Number is 1 .
Number = 1.
should be an error. That's just the usual whitespace to be ignored.
On Tue, Jun 21, 2022 at 4:47 AM UWN @.***> wrote:

@flexoron https://github.com/flexoron:
``
?- Number is 1_
2. Number = 12. ?- Number is 1 .
Number = 1.
?- Number is 1_.
Error: syntax error, near '_', operator expected
All three should rather be errors.
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/issues/593#issuecomment-1160748723,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSEU4CO2LFLGT3ACU3DLVQC4DXANCNFSM5Y662Q2Q
.
You are receiving this because you commented.Message ID:
@.***>

A bit harsh to say...

... and then you quote ?- Number is 1. which is not what I quoted. All three queries contained at least one underscore. Seems you are reading issues via e-mail.

(Seems you still accept mentioned cases) Note that by making your own extensions, systematic and comparative testing becomes impossible (or much too hard to implement). A frequent test is to count all answers (here, solutions) up to a certain number. And then look if the Nth answer is still the same. With your "inventiveness" this becomes impossible. Think of #253 which meant that no systematic testing was possible.

space cake

It was my birthday, I had chocolate cake.
On Sun, Jul 10, 2022 at 9:00 AM flexoron @.***> wrote:

space cake
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/issues/593#issuecomment-1179618474,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSESJZDJRNNNWRZQMPETVTIAAVANCNFSM5Y662Q2Q
.
You are receiving this because you commented.Message ID:
@.***>

Reshuffle...Rum Truffle.
Best wishes!

authors: UWN flexoron infradig


text:
Fix DigdagClient raises JsonParseException

Fix https://github.com/treasure-data/digdag/issues/947
This issue occurs with digdag >= 0.9.26, and its cause is by resteasy-cient >= 3.0.20.Final.
The resteasy-client now works natually and it seems that the workaround is not needed anymore.

I verified with a local nginx with a conf like:
http {
    include       mime.types;
    default_type  application/octet-stream;

    gzip on;
    gzip_disable "msie6";

    gzip_vary on;
    gzip_proxied any;
    gzip_types text/plain text/css application/json application/javascript text/xml application/xml application/xml+rss text/javascript;

    server {
        listen 80;
        server_name _;

        location / {
            try_files $uri @app;
        }

        location @app {
            proxy_pass http://localhost:65432;
        }
    }
}

tcpdump during digdag push was as:
.q...q..PUT /api/projects?project=sample-r&revision=543bbc1f-8d73-42f3-a912-1f3b084a8e0d HTTP/1.1
Accept-Encoding: gzip, deflate
Content-Type: application/gzip
User-Agent: DigdagClient/0.9.31
Content-Length: 7970
Host: localhost:80
Connection: Keep-Alive

....

.q...q..HTTP/1.1 200 OK                                                                                Server: nginx/1.15.8
Date: Mon, 04 Feb 2019 16:31:42 GMT
Content-Type: application/json                                                                                Transfer-Encoding: chunked
Connection: keep-alive
Vary: Accept-Encoding
Content-Encoding: gzip

it works fine on my local and will merge it into master. Thanks @sonots !

authors: muga sonots

repo: treasure-data/digdag


text:
Fixed parsing seqs, and enum indexed arrays

Prior to this you couldnt serialize enum indexed arrays. and deserializing an object with a sequence would ruin anything after the sequence.

This looks really good! Thank you for taking the time to write it up.
Could I ask you to add tests that would break earlier but fixed with your code? Probably at the end of this file https://github.com/treeform/flatty/blob/master/tests/test_flatty.nim

This looks really good! Thank you for taking the time to write it up.
Could I ask you to add tests that would break earlier but fixed with your code? Probably at the end of this file https://github.com/treeform/flatty/blob/master/tests/test_flatty.nim

Will do, some issues still exist so i've got to figure out where they come from, did not realize this earlier.

Will do, some issues still exist so i've got to figure out where they come from, did not realize this earlier.

thanks!

thanks!

repo: treeform/flatty


text:
Added JsonLines support

FYI http://jsonlines.org

lgtm

authors: fieg mvanduijker

repo: treehouselabs/feeder


text:
Fix GCS Token Refresh

Signed-off-by: Daksh Chauhan dak-x@outlook.com
Pull request
Description
Introduce a wrapper around the reqwest::Client.

Related

Related Issues: fixes #1109

Checklist

[X] The RFC, if required, has been submitted and approved
[X] Any user-facing impact of the changes is reflected in docs.tremor.rs
[X] The code is tested
[X] Use of unsafe code is reasoned about in a comment
[X] Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
[X] The performance impact of the change is measured (see below)

Performance

Coverage decreased (-0.02%) to 85.181% when pulling 1a4dd0bb075095be1cfb03793dc910147116f9a9 on dak-x:main into b170598af29dfe3c67b0e4b131963aa40bb11e94 on tremor-rs:main.

Nice work! 🎸

Thank you @dak-x!

authors: Licenser coveralls dak-x darach

repo: tremor-rs/tremor-runtime


text:
calculate UTC

Is it possible to calculate the UTC time from a client as well ? As you can get the current time I would believe that getting the UTC also would be possible as well and put in some some (hidden) formfield.

see https://stackoverflow.com/questions/13479416/how-to-set-now-button-on-jquery-ui-datetimepicker-to-set-utc-time
/*

override "Today" button to also grab the time.
*/
$.datepicker._base_gotoToday = $.datepicker._gotoToday;
$.datepicker._gotoToday = function (id) {
var inst = this._getInst($(id)[0]),
$dp = inst.dpDiv;
this._base_gotoToday(id);
var tp_inst = this._get(inst, 'timepicker');
selectLocalTimezone(tp_inst);
var now = new Date();
this._setTime(inst, now);
$('.ui-datepicker-today', $dp).click();
};
and simply add the below change,

var now = new Date();
var utcNow = new Date(now.getUTCFullYear(), now.getUTCMonth(), now.getUTCDate(), now.getUTCHours(), now.getUTCMinutes(), now.getUTCSeconds());
this._setTime(inst, utcNow);

authors: Yamakasi prasadbcs

repo: trentrichardson/jQuery-Timepicker-Addon


text:
Cant play the link

The link http://player-castv.c1.biz/get_m3u/piccolo-tv_channels_shqipHD.m3u
Does not work it says chek your link . Its not valid .
Maybe should take another look or i need to find another iptv player

prove working perfect

prove this
;http://player-castv.cf/get_m3u/piccolo-tv_channels_Albania.m3u

This link work thank you .. faleminderit!!

authors: shqiptarial treshi


text:
Allow choosing the bone mapping from the addon UI.

It would great if the addon let you pick which bones are which from the addon's UI instead of having to hardcode your bone names into the script. It would also be great if it did a fuzzy string match to autofill the bone names so you only have to correct the ones that are wrong.

I have this on my radar now, I need to find a way to do this cleanly in the UI without it being distracting for those who don't need it.

I 100% second this. It's a feature I need for my Booth model specifically because changing the bone names would make it incredibly tedious to remap and fix all the toggles and animations in Unity.
I feel like one way you could add this option in the UI is just to make it a dropdown and clearly label it "(optional)". If there is no bone specified in the slot it just uses the hardcoded values.
My bones' names follow the camelcase convention, like "RightLeg" instead of "right_leg". If you could hardcode variants like these that would be great too.

Implemented in 79579a7
It'll be in the next release, probably in a couple  of days.

authors: CheesecakeCG Iconoclass triazo


text:
DiagnosticSeverity Hint is not really useful at the moment

DiagnosticSeverity.Hint are only shown as a little grey ellipsis in the editor. They should point to code actions. Since the code action feature is not yet supported, it may make sense to map compiler Hints to DiagnosticSeverity.Information or Warning instead.

Closed by https://github.com/tricktron/frege-lsp-server/pull/25

repo: tricktron/frege-lsp-server


text:
Initial introduction of AWS CloudWatch Metrics and Log sources

Provide two new knative event sources for AWS:

awscloudwatchsource  to obtain AWS metrics data based on a user-defined query
awscloudwatchlogsource to obtain the AWS logs from a pre-existing logGroup and optional logStream

Both introduce the concept of a polling interval which is how frequently AWS should be polled to obtain updated data. Note that if the polling is frequently enough, then the user may get billed, which is why the defaults are configured to ensure the requests remain within the free tier.
AWSCloudWatchSource
Unlike the other AWS sources, an ARN cannot be used to denote the metrics being sought. Instead the AWS Region must be specified. The metrics query can denote a specific metric collection that is named or expression to apply between two named metrics.
In addition, two response types are created: com.amazon.metrics.metric for the metric values, and com.amazon.metrics.message if there's a message response from the query.
AWSCloudWatchLogSource
The ARN for retrieving logs must always have a log group associated with the entry. There is an optional log-stream attribute that can be included in the ARN resource to indicate a specific steam.  If no stream is specified, or if it is *, then the source will iterate through all streams associated with the logGroup, and create events for each stream that has had data written to it within the pollingFrequency interval.

@cab105 a general observation that didn't fit in the rest of my comments: the service is called CloudWatch Logs (plural), but I see cloudwatchlog (singular) scattered across the code, including the public facing Kubernetes types. I know it's a log of work, but fixing that is probably the right think to do.

@cab105 a general observation that didn't fit in the rest of my comments: the service is called CloudWatch Logs (plural), but I see cloudwatchlog (singular) scattered across the code, including the public facing Kubernetes types. I know it's a lot of work, but fixing that is probably the right think to do.

This is the one area that I was weighing given the naming of awscloudwatchlogsource vs awscloudwatchlogssource. However I did make this update.

given the naming of awscloudwatchlogsource vs awscloudwatchlogssource

It definitely looks ugly :D  I was in favor of not appending "Source" to types that are already in the "sources.triggermesh.io" API, but didn't win this battle.

The failing test doesn't seem to make sense. I ran both tests locally and they passed every time.

The failing test doesn't seem to make sense. I ran both tests locally and they passed every time.

I'm not a fan of failing tests, even for transient cases. Even looking at the diff for CircleCI, the output matches, which makes me wonder if it is comparing pointers instead of the underlying objects.

I found the reason for the failure using delve. Seems like the timezone is set after serialization/deserialization to/from CloudEvent, whereas it is nil in the original data:
(dlv) p metricRecord.Timestamps
[]*time.Time len: 1, cap: 4, [
        *{
                wall: 0,
                ext: 62135596800,
                loc: *time.Location nil,},
]

(dlv) p (*metricOutput.MetricDataResults[0]).Timestamps
[]*time.Time len: 1, cap: 1, [
        *{
                wall: 0,
                ext: 62135596800,
                loc: *(*time.Location)(0x32f6bc0),},
]

@cab105 aha! Unix() use the time.Local location, but the serialization/deserialization uses UTC. It's safer to pin the timezone in tests:
diff --git a/pkg/adapter/awscloudwatchsource/adapter_test.go b/pkg/adapter/awscloudwatchsource/adapter_test.go
index 53947e3..1a4e1e0 100644
--- a/pkg/adapter/awscloudwatchsource/adapter_test.go
+++ b/pkg/adapter/awscloudwatchsource/adapter_test.go
@@ -98,7 +98,7 @@ func TestCollectMetrics(t *testing.T) {
                val              = float64(37.566818845509246)
        )

-       ts := time.Unix(0, 0)
+       ts := time.Date(1970, 1, 1, 12, 0, 0, 0, time.UTC)

        const (
                dimensionName  = "FunctionName"
@@ -193,7 +193,7 @@ func TestSendMetricEvent(t *testing.T) {
                val              = float64(37.566818845509246) // must keep this cast to ensure proper [de]serialization
        )

-       ts := time.Unix(0, 0)
+       ts := time.Date(1970, 1, 1, 12, 0, 0, 0, time.UTC)

        metricOutput := cloudwatch.GetMetricDataOutput{
                Messages: nil,

repo: triggermesh/aws-event-sources


text:
Filter Syntax updates?

Problem Statement
Concise syntax like  x | v>10?
Proposed Solution
Please describe what you envision the solution to this problem would look like.
Alternatives Considered
Please briefly describe which alternatives, if any, have been considered, including merits of alternate approaches and
tradeoffs being made.
Additional Context
Please provide any other information that may be relevant.

(this was added - we support x ? condition )

repo: trilogy-data/pytrilogy


text:
Added TLScan

signed-off-by: crypt0rr 57799908+crypt0rr@users.noreply.github.com

#356

https://github.com/trimstray/the-book-of-secret-knowledge/pull/356/files

repo: trimstray/the-book-of-secret-knowledge


text:
🛑 Appointments is down

In 4983d97, Appointments (https://api.appset.nl/v1/appointments/1) was down:

HTTP code: 503
Response time: 87 ms

Resolved: Appointments is back up in 384cc81 after 7 minutes.

repo: trinitisolutions/triniti-uptime-monitor


text:
Dynamic page load is not working latest version(5.0.0)

I have added router-outlet in  in my html code as follows:
<GridLayout rows="*, auto" columns="*" class="page">
    <Pager #pager [pagesCount]="numItems" [selectedIndex]="currentPagerIndex" (selectedIndexChanged)="onIndexChanged($event)" class="pager">
        <StackLayout height="100%">
            <router-outlet height="100%"></router-outlet>
        </StackLayout>
        <StackLayout height="100%">
            <router-outlet name="Graph"></router-outlet>
        </StackLayout>
        <StackLayout height="100%">
            <router-outlet name="DataList"></router-outlet>
        </StackLayout>
    </Pager>
</GridLayout>

And routing elements as follows:
{
        path: "DetailScreen", component: DetailViewComponent, children: [
          //DetailScreen1 child Components
          { path: "", component: DatalistingComponent, outlet: "DataList" },
          { path: "", component: GraphComponent, outlet: "Graph" },
          { path: "", component: OverviewComponent },
        ]
      },

The code is working fine in version 2.3.0 but working in version 5.0.0.
Any help,
Thank you

If you want to use that code you will need to lock the package to 2.3.0 because 3 + uses templates

authors: Dharmendta triniwiz

repo: triniwiz/nativescript-pager


text:
Add link to OSDS video

Description
Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

Thank you @ebyhr

repo: trinodb/trino-gateway


text:
Helloworld in haskell programming language #131

print Hello world in Haskell Programming language #131
added Helloworld.hs file

Thanks for the contribution!

Thanks for the contribution!