text:
Cannot resize window when KPCTabsControl takes whole width

This one is weird and I don't remember this was a problem a few weeks ago: I have a tab bar at the top of my window + constraints so it has full width. Whatever size the window has in Interface Builder is the final width when I start the program. Height resizes just fine. I don't get any horizontal resizing handles, though. Can't make the window wider or narrower.

It happens even when I ...

set the width to 500 and center it horizontally in its container
don't set a width and center it

(No matter the content hugging or compression resistance.)
It works when I ...

neither set a width or X-location constraint
don't set a width and add leading=0

Hi! Thanks for the issue report. I'll have a look asap, but I am currently traveling. Would it be possible for you to send me a test project with the right problematic setup?

Hi. I just published v1.6.1 with a small fix. I have taken the project demo, and turned Autolayout ON in the  xib. And indeed, it appeared that you couldn't resize the window. I am still struggling a bit at understanding the AutoLayout stuff. I had to revert a boolean in the code (that I already toggled in the past...). But with the new value, the tabs control works whatever the AutoLayout switch in the xib: on and off work. Let me know if it is also ok for you.

Strange: turning AL on alone didn't break the sample app for me. Will integrate the new version today and see in the shipping app.

On 28 May 2016, at 15:41, Cédric Foellmi notifications@github.com wrote:
Hi. I just published v1.6.1 with a small fix. I have taken the project demo, and turned Autolayout ON in the xib. And indeed, it appeared that you couldn't resize the window. I am still struggling a bit at understanding the AutoLayout stuff. I had to revert a boolean in the code (that I already toggled in the past...). But with the new value, the tabs control works whatever the AutoLayout switch in the xib: on and off work. Let me know if it is also ok for you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

That did it, thanks! I wonder what else I messed up when I removed that toggle and it still didn't work 🤔

👍🏻

authors: DivineDominion onekiloparsec

repo: onekiloparsec/KPCTabsControl


text:
add_sign tampering with the xml, resulting in invalid signature

Good day dear,
I'm implementing HTTP-POST which is requiring enveloped signatures.
I implemented your hint on the php repo (and here on other issues) using add_sign
But, indeed add_sign do tamper with the resulting xml (as in #148 ).
I reviewed your commit 5e08bb2 , it certainly look way better at solving the issue but unfortunately it still yields an invalid signature from the idp.
On a side note: If i sign the xml request on the onelogin site online tools, i get through and have no errors.
How can i help resolving this issue ?
Thank you.

@RamezIssac have you tried to validate the generated XML with the validate_sign method?
Also, try to use python3-saml and see if it also give you the same issue.

@pitbulk Thank you for the quick reply
The validate_sign is returning False  (on parameter validate_cert = True or False)
Here is a complete transcript of the flow
saml_settings = OneLogin_Saml2_Settings(custom_base_path=settings.SAML_FOLDER, sp_validation_only=True)
security = saml_settings.get_security_data()  #
authn_req = authn_request.OneLogin_Saml2_Authn_Request(saml_settings, force_authn=True,
                                                       is_passive=False,
                                                       set_nameid_policy=False)

auth_req_xml = authn_req.get_xml()

key = saml_settings.get_sp_key()
cert = saml_settings.get_sp_cert()
signatureAlgorithm = security['signatureAlgorithm']
xmlAlgorithm = security['digestAlgorithm']

signed_xml = OneLogin_Saml2_Utils.add_sign(auth_req_xml, key, cert, sign_algorithm=signatureAlgorithm)
print(OneLogin_Saml2_Utils.validate_sign(signed_xml, cert, key, signatureAlgorithm, validatecert=True))

`
I'll test wtih Python3 and get back to you.

Same behavior on Python3-saml , validate_sign return False.
Adding sign via same procedure as above.

Hello again ,
Can you please share with your findings / insights ?
Were this bug re-produce-able on your end ?
What do you think we should investigate ? Any further ideas?
Thank you in advance.

The problem with using the method OneLogin_Saml2_Utils.validate_sign  is that it currently only supports validate signatures of Message or Assertion (as mentioned in the documentation) if no xpath parameter provided.
You may modify the use of validate_sign as follows. Replace:
OneLogin_Saml2_Utils.validate_sign(signed_xml, cert, key, signatureAlgorithm, validatecert=False)
by
OneLogin_Saml2_Utils.validate_sign(signed_xml, cert, key, signatureAlgorithm, validatecert=False, xpath='/samlp:AuthnRequest/ds:Signature')

It worked for me with the code on master

The same script code that you shared but with the changes I provided

That's weird ...
default settings / advanced settings ?

Ok, This is embracing.
While i was writing the test case to send it as a proof, Falses "magically" turned to Trues and idp is happy, No clear explanation. (just maybe *.pyc files messed with me.. )
And indeed works on master after the commit 5e08bb2
Thank you indeed for your help and time. Closing issue.

source: gharchive/issue

authors: RamezIssac pitbulk

repo: onelogin/python-saml

license: mit

license_type: permissive

license_source: bigquery


text:
Various cleanups to repo

Extract out UPGRADING.md from README.md
Update README version support to reflect reality of CI coverage (Ruby 2.0 and earlier are not currently tested.)
Format line breaks in README.md.
Rename changelog.md --> CHANGELOG.md to match other projects.
Rename actions gem-push.yml --> test.yml
Fix CI status badge in README.md

@pitbulk comment addressed, please review

source: gharchive/pull-request

repo: onelogin/ruby-saml


text:
Fix Tsx import

Hi Onesine, First and foremost, I would like to express my deepest gratitude for the incredible work you've done on this package.
It has truly been a game-changer for my projects, and I greatly appreciate your efforts in creating such a fantastic component.
Recently, while working on a TypeScript project (using "typescript": "^5.0.2"), I encountered a minor issue with the package that seems to be affecting other users as well. After some investigation, I noticed that the problem lies in the import statement within the node_modules/react-tailwindcss-datepicker/dist/constants/index.d.ts file.
The specific error message is as follows:
node_modules/react-tailwindcss-datepicker/dist/constants/index.d.ts:1:35 - error TS2307: Cannot find module 'types' or its corresponding type declarations.
1 import { ColorKeys, Colors } from "types";

To address this, I forked the repository and attempted a fix by modifying the import statement as follows:
import { ColorKeys, Colors } from "../types";

I am pleased to confirm that this adjustment resolved the TypeScript compatibility issue for my project, and I believe it could be a valuable improvement for othes too.
Here's the issue linked: https://github.com/onesine/react-tailwindcss-datepicker/issues/157

Thanks for finding out the issue. I've also encountered this problem and ended up updating the change manually. I'll wait for the merge to be approved and then I'll delete the manual changes.

Hi 👋 @calrloco
So sorry for the delay in responding.
It is we who thank you for using react-tailwindcss-datepicker.
Thank you also for this PR.

Hi 👋 @calrloco
So sorry for the delay in responding.
It is we who thank you for using react-tailwindcss-datepicker.
Thank you also for this PR.

Thanks @onesine Keep up the great work 💪🏻

authors: Seyid-cmd calrloco onesine

repo: onesine/react-tailwindcss-datepicker

license: MIT

license_source: github-api


text:
Save and share the state of deployed contracts

Issue To Be Solved
When contracts are deployed using the project deploy we get addresses for each deployed contract in the result. These addresses are then used by any transactions or script that interacts with the deployed contracts, but currently, they need to be inserted in imports by hand.
We should have a way to save the addresses of deployed contracts in a state file.
Suggest A Solution
CLI new command for deployment allows us to deploy contracts with a simple command to any desired network. This greatly improves the ability to iterate and update but it would even further improve DevEx if any program could benefit from that work. I'm thinking of a way to save and share the state of deployed contracts.
One way of achieving this would be to have a json file containing newly deployed contracts mapping to their addresses and this file could then be included into any other program. Some kind of a manifest file as @psiemens said.
I think this could be a simple and generic approach that would work among any programming language. Manifests could contain addresses for different networks and potentially maybe even sdk-s could support parsing such a file.
I think we need to open discussion on this topic and get different feedback to create the best solution.

I was working on the Kitty Items repo today and ran into two problems that made me think of this issue.
I updated all the Cadence files to import contracts by filename rather than address, so the files no longer specify placeholders like 0xFUNGIBLETOKEN.

After making that change, I wanted a way to use these same files in the Go tests. However, I could no longer do the simple replace(0xFUNGIBLETOKEN, ...) approach. It'd be great if the CLI were to resolve all of the contract filenames and use the new address replacement logic that's now in the CLI to generate a version of the contracts, transactions and scripts rewritten with emulator addresses. It would then be fairly trivial to then automatically generate Go bindings that could be used in the tests.

Similarly, I used a hacky solution to replace the contract filenames in the kitty-items-js project. If we had something like a manifest file (generated by the CLI), it'd be much easier to just parse that JSON file in the JS app and load all of the address mappings.

@MaxStalker I think your generator code also solves problem 2 above. Is that right?
Seeing as we have partial solutions to these problems in both Go and JS, I wonder if we can create a generalized solution that can easily be replicated in other languages.
Here's a rough example of what I'm thinking 👇
// transferKibble.cdc

import Kibble from "../contracts/Kibble.cdc"

...

// kittyItems.manifest.json

{
  "transactions": {
    "transferKibble": {
      "arguments": [
        {"name": "recipient", "type": "Address"},
        {"name": "amount", "type": "UFix64"}
      ],
      "code": "import Kibble from {Kibble} ... ",
    }
  },
  "scripts": {
    // ...
  }
}

I agree, and I think the manifest idea is great. Contracts field can reflect contract addresses on each network. I'm not sure I understand the transactions property.  Are you thinking of storing code that already has replaced addresses for specific transactions in manifest as well? Shouldn't there already be a file with that transaction code same for scripts (with imports the same way there are in contracts)?

I think we need to invite @turbolent as well, since that address would also affect language server ability to resolve it to actual contract.
Also, feels a bit like we are re-inventing ABIs with this approach 😅

I agree, and I think the manifest idea is great. The contracts field can reflect contract addresses on each network.
Transactions and scripts are not "deployable" so we need to do address replacement and save them somewhere. Saving to manifest is one option the other is to have some kind of build folder.
I think the build folder is worth considering since it feels familiar to developers (think webpack, tsc etc.) and it offers a nice separation of files the same way we had them in the source file. Of course, the build folder doesn't allow any other metadata for which manifest is the correct solution if there is a need for such a thing. Another benefit of the build folder is there is no parsing and logic to implement manifest file (which would potentially be implemented in many places for many programming languages - probably would need to be included in the library).
In either case, I think an important aspect is also to think of changes and how are those reflected in any solution. Redeployment of contracts should of course change the state but also change of scripts and transaction files should. I think we could later add some kind of watch feature. Before that developer should probably rerun the command.
Workflow with this functionality:

When a developer deploys contracts state should be updated with new addresses. When they run flow project deploy all this should happen automatically.
When a developer change script or transaction files there should be a command they need to run. Maybe some kind of build command (but in manifest case not build since it implies there is a build folder) or maybe update.

I think in any case there shouldn't be any manual work with the state since the state would be generated with CLI. By that I mean a developer shouldn't change anything in manifest or build files and should just have a CLI to generate that. That is because I don't think it is a good idea to have some things generated and some things manually inserted (problems with overwriting etc).
I think another thing to keep in mind is that our solution should work with task automation tools (grunt, gulp etc). This could even remove the need for us to implement a watch feature. Maybe this is even more appropriate.
@psiemens I wondering why you specify this in an example:
"arguments": [
      {"name": "recipient", "type": "Address"},
      {"name": "amount", "type": "UFix64"}
],

This sounds pretty great!
I left some comments on https://github.com/onflow/kitty-items/pull/32 about this too, but I don't think this adequately solves some issues. In order to do it this way, you still have to copy and paste contracts and contract interfaces to your repos to import them, whereas we should have some way of importing them from another repo.
Same with providing an easy to use package for anyone to import the transaction templates from their app in any language. It looks like that's what you're talking about above though, so that is good. 👍

I think there are two separate issues (both important):

Once you deploy your contracts using the awesome new feature flow project deploy how do you execute your custom scripts/transactions without having to copy-paste previously deployed contract addresses in script/transactions imrpots (what this issue mostly targets)
You shouldn't have to copy-paste standard (or any other) contracts from github just for the deployment to work. I think this should be solved but I also think it can be solved separately since it opens more problems (vscode language processor should know how to parse remote imported contracts etc...). I will open an issue for this since I believe it is a major pain point when developing.

Sending adresses as arguments to scripts contracts would also be nice to think about here. Could there be an cadence.Address method that does this lookup for you?

Sending adresses as arguments to scripts contracts would also be nice to think about here. Could there be an cadence.Address method that does this lookup for you?

Can you please give some examples of usage so I better understand?

https://github.com/versus-flow/auction-flow-contract/blob/master/examples/demo/main.go#L70
Transaction is signed as the marketplace account and the address of the artist is sent in as an argument.

@bjartek you mean you want to pass address as one of the arguments in the script? 🤔

@MaxStalker yes. Ser the example I posted above.

https://github.com/versus-flow/auction-flow-contract/blob/master/examples/demo/main.go#L70
Transaction is signed as the marketplace account and the address of the artist is sent in as an argument.

I like your implementation, it reads really well. And yes ok I understand what you mean. Passing parameters to scripts is actually something @MaxStalker was working on.

authors: MaxStalker bjartek joshuahannan psiemens sideninja

repo: onflow/flow-cli


text:
[Indexer] Integrate

This PR integrates changes for indexer in the main branch.

For contributor use:

[ ] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the standards mentioned here.
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

Probably needs a go mod tidy

authors: m-Peter sideninja

repo: onflow/flow-evm-gateway


text:
Live scraper

THE GOAL
I'm trying to build a live market scraper of nbatopshot
THE PROBLEM
First of all I wanna say that I'm new to this technology and to cadence language, so 99% will be an error in the cadence code.
I've already got an API who can retrieve all the events "MomentListed" (a particular event minted when someone puts a token on the market) and right now I have the token's Id, seller's address and the price (from the event).
I have a cadence script in order to retrieve all the token metadata (such as setName, playName etc...) from the seller address and the token Id, but I get an error while sending the script.
The code:
const express = require('express');
const router = express.Router();
const flow = require('@onflow/sdk');
const types = require('@onflow/types');
const fcl = require('@onflow/fcl');
const { json } = require('express');
const fetch = require("node-fetch");

const config = require("../utils/config.json");
const script = require("../utils/script");

router.use(json());

fcl.config().put("accessNode.api", config.apiAccessNode)

/* GET home page. */
router.get('/', function(req, res, next) {
  //I'm call the API in order t get all the events data
  fetch("http://localhost:8080")
    .then(res => res.json())
    .then(events => {
      events.forEach(({ Id, Seller }) => {

        flow.build([
          flow.script`${script}`,
          flow.args([flow.arg(Id, types.UInt64), flow.arg(Seller, types.String)])
        ])
          .then(scriptBuilted => {
            return flow.resolve(scriptBuilted, [
              flow.resolveArguments,
              flow.resolveParams,
            ])
          })
          .then(scriptResolved => {
            return flow.send(scriptResolved, { node: config.apiAccessNode })
          })
          .then(scriptResponse => {
            return flow.decode(scriptResponse)
          })
          .then(console.log)
          .catch(console.error)
        })

    })
      .catch(console.error)
});

module.exports = router;

The cadence script is:
import TopShot from 0x0b2a3299cc857e29
import Market from 0xc1e4f4f4c4257510
pub struct SaleMoment {
  pub var id: UInt64
  pub var playId: UInt32
  pub var play: {String: String}
  pub var setId: UInt32
  pub var setName: String
  pub var serialNumber: UInt32
  pub var price: UFix64
  init(moment: &TopShot.NFT, price: UFix64) {
    self.id = moment.id
    self.playId = moment.data.playID
    self.play = TopShot.getPlayMetaData(playID: self.playId)!
    self.setId = moment.data.setID
    self.setName = TopShot.getSetName(setID: self.setId)!
    self.serialNumber = moment.data.serialNumber
    self.price = price
  }
}
pub fun main(owner:Address, momentID:UInt64): SaleMoment {
  let acct = getAccount(owner)
  let collectionRef = acct.getCapability(/public/topshotSaleCollection)!.borrow<&{Market.SalePublic}>() ?? panic("Could not borrow capability from public collection")
  return SaleMoment(moment: collectionRef.borrowMoment(id: momentID)!,price: collectionRef.getPrice(tokenID: momentID)!)
}

config file:
{
  "apiAccessNode": "https://access-mainnet-beta.onflow.org",
  "appContractProfile": "0xc1e4f4f4c4257510",
  "eventType": "MomentListed"
}

THE ERROR
the error I have is:
* rpc error: code = Internal desc = failed to execute the script on the execution node execution-160241f88cbfaa0f361cf64adb0a1c9fc19dec1daf4b96550cd67b7a9fb26cd9@execution-002.mainnet4.nodes.onflow.org:3569=1000: rpc error: code = Internal desc = failed to execute script: failed to execute script at block (706ad1c305c20726d1a1848110c8e3275ffea9c82dd9dd4ac7c6386764ee5678): Execution failed:
invalid argument at index 0

I really don't know where is the problem, and also I can't understand the error message. Thanks for the time.

I've built a solution.
It's a web scraper (first version so it's not perfect), it analyze the last 50 blocks and display all the MomentListed (excluding the ones already sold).

I've built a solution.
It's a web scraper (first version so it's not perfect), it analyze the last 50 blocks and display all the MomentListed (excluding the ones already sold).

repo: onflow/flow-js-sdk


text:
JS/Web apps port conflict - auth broken

Hi There,
Thanks for the vast collection of learning resources and tutorials on Flow. Making my way though.
It seems that the node backend and the react web app are started on the same port. The web app runs fine on 3001, but Dapper staging auth is broken because of it.
I've been able authenticate and purchase an item by starting the node backend on 3001 and the web on 3000, but eventually ran into a CORS issue trying to list the same item. Perhaps that is a different issue, not sure.
Thanks

Thanks for reporting @benpolinsky We've got a fix for this and a bunch of other stuff coming soon!

I noticed that in env.local, the REACT_APP_PORT was already set to 3001.  I found a decent solution by modifying the package.json file so that "npm run start" launches the app at port 3001.  Here is the Stack Overflow I used that contains the code for Windows, Mac, and Linux: https://stackoverflow.com/questions/40714583/how-to-specify-a-port-to-run-a-create-react-app-based-project

This should be fixed when we merge PR #27

Fixed by #27

authors: 10thfloor Johnrobmiller benpolinsky

repo: onflow/kitty-items


text:
[Feature] Expose command state

There's currently no way to inspect the command state, i.e. which keys have been punched in and what command is in the process of being built. Knowing this would be useful for a couple of features:

Displaying the current command state, which characters and what count, if any, has been entered, in case you get distracted in the middle of something and forget.

To provide contextual help. This will both reduce the need to memorize commands AND make it easier to learn them. For example, if g has been entered, the UI could display a list of possible characters to "complete" the command:

g - Go to top
t - Go to next tab
T - Go to previous tab
u - Convert to lowercase
U - Convert to uppercase
~ - Swap case
] - See all definitions

Technical details
The command state, at least in normal mode, is stored in state_current->context->ca, a cmdarg_T. state_current->context is a void* and will point to different data structures depending on mode, but normal mode is mostly what I'm interested in here (or "Normal", "Visual" and "Operator" I guess, according to get_real_state()).
A new function vimGetCommandState could return either the entire cmdarg_T struct, or a subset if that's easier to bind to from Reason. Or null if the stars aren't aligned.

This is a great suggestion, @glennsl ! Thank you! I like the idea of vimGetCommandState. Seems like this wouldn't be too hard to wire up - all the information is around.
Contextual help would be an amazing feature and help lower the learning curve & barrier to entry significantly.

authors: bryphe glennsl

repo: onivim/libvim


text:
Support for icon themes

I'm not sure if icon themes are currently supported. I tried material icon theme (pkief.material-icon-theme) and it does not appear to change my icons in explorer. It appears that folders aren't showing an icon  as well (although I have seen other people have posted screenshots with folders icons working). For me, the folder icons don't appear with the default vs-seti either
OS: MacOS Catalina 10.15.6
Build: Tried Version 0.5.9-nightly (0.5.1740) and 0.5.1 stable
Configuration:
{
    "editor.fontFamily": "FiraCode Nerd Font",
    "editor.fontSize": 12,
    "files.exclude": ["_esy", "node_modules", ".git"],
    "workbench.colorTheme": "GitHub Dark",
    "workbench.iconTheme": "material-icon-theme",
    "ui.zoom": 1.2,
    "vim.useSystemClipboard": true,
    "vim.leader": "<space>"
}

Me too

Me too

Same here!

Same here!

same here

just tried out onivim for a little bit and noticed this issue as well. i'm wondering if it's possible to just replicate the way they're pulling in theme extensions and use that for icon themes? if that makes sense

authors: BIKA-C NarongOk alexventuraio petertriho rhyses-pieces


text:
Unable to open in editor shell / terminal in windows.

I have the in editor terminal working correctly in macOS, unfortunately I can't get it to work in windows 10.
I'm using the shell git bash. This has been added to the path on windows. (last entry - note this shell path works on webstorm)

When opening the terminal with :terminal a window for it appears but it is just black.

(webstorm uses the same path for the terminal)

This is a log from me attempting to use the terminal on windows: https://gist.github.com/zacharycarter/b80a9db72f85ef8aa91ac43ae47f5320

authors: yunti zacharycarter


text:
Upgrade torch and torchvision

We have to upgrade torch and torchvision to avoid vulnerabilities mentioned in the LFX and snyk scans.
torchvision 0.15.1 depends on torch==2.0.0

there is also a ref for torch and torch vision in the docker info under docs; I will update that independently as I have a PR for that file

Oh perfect!! Thanks @AlexandreEichenberger

Jenkins Linux ppc64le Build #10292 [push] Upgrade torch and torchv... started at 15:40

Jenkins Linux amd64 Build #11234 [push] Upgrade torch and torchv... passed after 1 hr 16 min

Jenkins Linux s390x Build #11244 [push] Upgrade torch and torchv... passed after 1 hr 45 min

Jenkins Linux ppc64le Build #10292 [push] Upgrade torch and torchv... passed after 2 hr 1 min

repo: onnx/onnx-mlir


text:
Use $(_TargetAssemblyProjectName) in Wpf.targets

This PR contains the latest WPF update from NuGet/Home#5894. I also made a few changes to the WPF sample project, so I could test the update.
Note that I put the *.props and *.targets imports right next to each other, because I could think of no good place to separate them to. I don't know if this will break anything. If you can think of a better place for the *.props import to go, I'm glad to move it. Thanks!

By the way, congrats on your Ninja Cat award @onovotny!

Instead of adding packages to the top-level nuget config, the sample project should be in the \Tests directory and in that solution. The issue is that the main project has to be built before the package is in the local temp directory.
Also, we need to respect the ordering of the props/targets. The workaround can go into the main props/targets with an extra condition to see _TargetAssemblyProjectName isn't blank. Not sure where that's defined yet, but we also want to ensure we're not double-importing, so needs some other condition that we're in the temporary assembly.

I moved the WPF NuGet *.props import into MSBuild.Sdk.Extras.props. I kept the condition intact, as I couldn't quite understand what you were asking me to add. Note that the variable in question is passed directly to the MSBuild engine by the GenerateTemporaryTargetAssembly task (see the picture I posted at https://github.com/NuGet/Home/issues/5894#issuecomment-388520580); it is not defined in any props or targets file.

@wjk that should be fine then, I just didn't want there to be a double import if other projects set the variable.

This isn't working for me, because the WPF targets doesn't define the $(_TargetAssemblyProjectName) property. What toolset are you using that defines that?

Hmmm.... I see that property is set by a global property. I'm seeing that, but the import of my PackageReference's build folder is not happening in my WPF project anyway, while using the msbuild.sdk.extras. I'm still trying to figure out why.

@AArnott The updated .NET 4.7.2 build task for WPF sets that itself

How are you importing it? NuGet Package Explorer seems to be working correctly so far... https://github.com/NuGetPackageExplorer/NuGetPackageExplorer/blob/master/PackageExplorer/NuGetPackageExplorer.csproj

That looks like how I'm importing it as well.
These are the PackageReferences that have build authoring that the WPF project isn't picking up on my machine or on appveyor.

I'm seeing this:
Project "$(BaseIntermediateOutputPath)$(_TargetAssemblyProjectName).*.targets" was not imported by "C:\Users\oren\.nuget\packages\msbuild.sdk.extras\1.5.4\build\platforms\languageTargets\Wpf.targets" at (71,3), due to false condition; ('$(_TargetAssemblyProjectName)' != '' and '$(ImportProjectExtensionProps)' == 'true' and exists('$(BaseIntermediateOutputPath)')) was evaluated as ('GuidGen' != '' and 'true' == 'true' and exists('C:\dev\GuidGen\src\..\obj\GuidGen_anej0tpm_wpftmp\')).

Your $(BaseIntermediateOutputPath) override isn't working for the generated project and it's getting its own version of that without the targets in it.

Not sure where the issue lies, but happy to take a fix for it.

Woot! Thank you. I've applied the small fix/workaround to my own repo. Not a bug or anything that msbuild.sdk.extras can do as far as I can tell. It's just my "read only source tree" property definitions that needed to account for the MSBuildProjectName changing.

authors: AArnott onovotny wjk

repo: onovotny/MSBuildSdkExtras


text:
local_user is nil in CircleCI

Hi!
I used capistrano-slackify in CircleCI 2.0, and encountered below error.
00:00 slack:notify_failed
      Notifying Slack of deploy failed
bundler: failed to load command: cap (/home/circleci/repo/vendor/bundle/ruby/2.4.0/bin/cap)
NoMethodError: undefined method `strip' for nil:NilClass

https://github.com/onthebeach/capistrano-slackify/blob/master/lib/capistrano/tasks/slackify.cap#L64
In CircleCI, local_user is nil.
So, I added Environment Variable USER in CircleCI. But it was difficult to notice this cause.
I am thinking of a pull request like below,
capistrano-slackify/lib/capistrano/tasks/slackify.cap
- set :slack_user, -> { local_user.strip }
+ set :slack_user, -> { local_user.to_s.strip }

what do you think about it? Please tell me any other good ideas.
Thanks!

Hi @mochizukikotaro, thanks for the report - that would be a good approach for me. Capistrano sets this value to ENV["USER"] || ENV["LOGNAME"] || ENV["USERNAME"] if it hasn't been explicitly set, so treating it always as string here seems like something that would inevitably trip us up at some point.

authors: mochizukikotaro seenmyfate

repo: onthebeach/capistrano-slackify


text:
Collect distinct messages and example rows

I have a validation tasks with a million rows, resulting in about two million messages. But there's really only about 200 distinct messages, and 84 rows are sufficient to demonstrate all those problems.
So I wrote some code that collects distinct error["message"]s, then goes back through one of the tables looking for those rows. It writes them to a new table, and updates the error["cell"] with the new row number.
This would be better with:

a command line option: --distinct true, or something
support multiple tables: append _distinct to the table name, or something
just one pass through the tables (here I iterate twice)

I haven't tested this, and it could be more efficient, but let's just merge.


text:
Option to apply to plain string variables

I am using cn (clsw, twMerge) - this means I have class lists inside plain string variables.
Would be nice we could target the formatting for certain string variables:
 	const buttonClassName = 		'flex h-8 w-8 items-center justify-center rounded-l-lg border-1 border-black';
        return(                 <button className={cn(buttonClassName, 'extraClass')}>Button</button>         );
In my VSCode I set up intellisense to recognize "*ClassName" variables, so "buttonClassName" gets the intellisense.  Maybe the prettier config could also target variables with "*ClassName" patterns, or whatever the user chooses.

Hi, sorry for the late reply! I will consider adding that option.
Currently, you can work around this by defining a separate identity function and then adding that function name to the customFunctions option.
const id = (x) => x;

const buttonClassName = id('flex h-8 w-8 items-center justify-center rounded-l-lg border-1 border-black');

{
  customFunctions: ['id']
}


text:
Can you guys add multi themes?

Hi guys, I was testing your lib, congrats, thats great! I'm here to ask if its possible put more than two themes? How can i do it? I was trying wrap the StoryBook with a Provide but the routes crashes rs
thanks

Hello, thanks!

I'm here to ask if its possible put more than two themes? How can i do it?

Do you mean something besides dark/light theme? The point is that dark/light can be synchronized with system settings, but you can pass any ThemeData to the Storybook.

I was trying wrap the StoryBook with a Provide but the routes crashes

That's probably a bug. Could you provide some reproducible example, please?

Hi folks!
Below the code that I'm running:
class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return ChangeNotifierProvider(
      create: (_) => ThemeServices(),
      child: Builder(builder: (BuildContext context) {
        return StoryBook();
      }),
    );
  }
}

But, I would like use like this:
class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return ChangeNotifierProvider(
      create: (_) => ThemeServices(),
      child: Builder(builder: (BuildContext context) {
        ThemeData theme = Provider.of<ThemeServices>(context).currentTheme;
        return MaterialApp(
          theme: theme,
          home: StoryBook()
        );
      }),
    );
  }
}

in first case I had a problem when trying acess routes of the storybook;
What I come across:

Make sure your root app widget has provided a way to generate
this route.
Generators for routes are searched for in the following order:
 1. For the "/" route, the "home" property, if non-null, is used.
 2. Otherwise, the "routes" table is used, if it has an entry for the route.
 3. Otherwise, onGenerateRoute is called. It should return a non-null value for any valid route not handled by "home" and "routes".
 4. Finally if all else fails onUnknownRoute is called.
Unfortunately, onUnknownRoute was not set.
When the exception was thrown, this was the stack

packages/flutter/src/widgets/app.dart 1228:9                                  <fn>
packages/flutter/src/widgets/app.dart 1242:14                                 [_onUnknownRoute]
packages/flutter/src/widgets/navigator.dart 4170:22                           [_routeNamed]
packages/flutter/src/widgets/navigator.dart 4280:35                           pushReplacementNamed
...
Handler: "onTap"
Recognizer: TapGestureRecognizer#d3469
    debugOwner: GestureDetector
    state: ready
    won arena
    finalPosition: Offset(41.6, 73.0)
    finalLocalPosition: Offset(41.6, 24.0)
    button: 1
    sent tap down

The whole code can be accessed in this repo.

The storybook uses MaterialApp under the hood, so yeah, this one won't work:
return MaterialApp(
          theme: theme,
          home: Storybook()
        );

But you can pass the theme directly to the Storybook:
return Storybook(
  theme: theme,
)

In that case, it should work.

Well, thats make sense, I didnt notice it; Thanks

authors: AndersonOli ookami-kb


text:
Windows Defender报毒

Backdoor:PHP/Shell.C
文件：bpcs_uploader-master_bpcs_files_\common.inc.php

dup w/ #28

我对php一窍不通，虽然知道很多时候杀软会误报，但还是希望大概了解一下误报的原因，谢谢

please find out by yourself :)
i don't use windows defender personally.

不好意思，您误解了。我的意思并不是“windows defender”为什么报毒，而是php为什么会导致杀软报毒。比如游戏汉化补丁由于加壳或进程注入而导致杀软报毒。最好还是在readme里面说明一下吧。
Sorry to bother you.

Some PHP backdoors, like PHPSpy, have functions to execute shell commands. That's why anti-virus software has false positive for PHP files. bpcs_uploader do the same thing so it can execute curl, wget or sth which is necessary.
Feel free to open a pull request if you think it's necessary to have it included in README.md.

Thanks


text:
Unable to select video which is on iCloud

I have some videos on icloud because of iPhone Storage. I won't be able to select those videos and images. Please help.!
Thanks

You might have to change some settings on your PHImageManager. Check the documentation.

repo: opalorange/OpalImagePicker


text:
Convert WINDOWS_HOWTO.rtf to Markdown

This makes it easier to read on github

I pushed to the wrong branch. It should be there now.

repo: opcm/pcm


text:
Fix bug causing implausible juvenile indicator values

Closes #292
Fixes for the juvenile density indicator and standardization of some function names.

@Rosejoycrocker tagging you for awareness. Going to merge this directly.


text:
Embedded map settings changes

Overview
Several elements of the embedded map settings page required minor updates.

Updated the text copy to reflect the updated content in the wireframes.
Set the individual contributor fields to be turned off by default, to reflect the actual initial state of the data (the EmbedFields aren't created until a change is made on the settings page).
When a user with an embed_level of null (ie no embedded map access) attempts to access the settings page, shows a message stating that they aren't authorized to access the page and should reach out to OAR staff for access.

Connects #1351
Demo
Unauthorized:

Authorized:

Notes
Text copy
Testing Instructions

Run ./scripts/server and login with a user with a null embed_level.
Navigate to settings.

[x] On the embed tab, you should see the message from the text copy.

Change the user permissions to the highest embed level and refresh the settings.

[x] You should see the usual page.
[x] The text should be updated.
[x] The contributor fields should not be selected by default.

Select the contributor fields.

[x] The fields should be selectable and maintain their selection on refresh as before.

Checklist

[x] fixup! commits have been squashed
[x] CI passes after rebase
[x] CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Thanks for reviewing!


text:
fix image replace issue

replace bytes.Compare to reflect.DeepEqual
fix image replace issue

Signed-off-by: Song Song Li ssli@redhat.com

/lgtm


text:
wait for manifestwork crd before starting manager.

ref: https://github.com/open-cluster-management/backlog/issues/13263
Signed-off-by: morvencao lcao@redhat.com

💯
/lgtm


text:
support custom tenant header and write endpoint

https://github.com/open-cluster-management/backlog/issues/18022
Signed-off-by: Marco llan@redhat.com

/lgtm


text:
Trigger prow build to verify new config

Related Issue:  open-cluster-management/backlog#9582
Description of changes
We've completed the initial config for prow pipeline, and want to ensure that prow will build the search collector when triggered via fork pull request

Add logging comment in main.go

Our fork based pull request successfully triggered the prow build 🎉


text:
[DOC] Add TypeDoc link to the readme

Change in the documentation
https://open-feature.github.io/js-sdk/

Done

repo: open-feature/js-sdk


text:
Correct spelling

Corrected the spelling
I made three changes
- shadown
+ shadow

Thank you very much.
I'm one of the Outreachy applicants
On Sat, Oct 29, 2022, 10:03 AM Bérénice Batut @.***>
wrote:

Merged #508
https://github.com/open-life-science/open-life-science.github.io/pull/508
into main.
—
Reply to this email directly, view it on GitHub
https://github.com/open-life-science/open-life-science.github.io/pull/508#event-7696616204,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A2IWYTBNEOTBDBQJF4M5MZTWFTR7PANCNFSM6AAAAAARRPJNEU
.
You are receiving this because you authored the thread.Message ID:
<open-life-science/open-life-science.github.
@.***>


text:
Different search gives different results when no data for the matching keyword is found.

"*" is wild-card search so its valid search query param for elastic search but rest of them should be consistent

Getting follow response when searched '{'
{"responseMessage":"An exception with message [Elasticsearch exception [type=search_phase_execution_exception, reason=all shards failed]] was thrown while processing request."}
cc @harshach @darth-coder00 @Sachin-chaurasiya

Closing this since it is a corner case and not a critical bug

authors: harshach parthp2107 vivekratnavel

repo: open-metadata/OpenMetadata


text:
Fix SSL related changes

Describe your changes:
Fixes 1.4.x sslCertificate -> caCertificate issue

Type of change:

[ ] Bug fix
[ ] Improvement
[ ] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.


text:
torch 1.5 support

c++ code inside ops will not built since AT_CHECK is deprecated and will thourgh not defined error.
Recommended replace AT_CHECK with TORCH_CHECK to support torch 1.5
#2513
thx

Maybe you can submit a PR 😄

Maybe you can submit a PR 😄

Done that :)

Hi @YuqiHUO , would you kindly submit the PR again? The MMAction2 team deleted our repo and we are resuming it back :)

Hi @YuqiHUO , would you kindly submit the PR again? The MMAction2 team deleted our repo and we are resuming it back :)

please see https://github.com/open-mmlab/mmaction/pull/201

Hi @YuqiHUO , seems that the new PR is empty? Would you like to check again?

please see #202

authors: YuqiHUO loveunk zhaoyue-zephyrus

repo: open-mmlab/mmaction


text:
When I try to verify the installation, error “AttributeError: 'NoneType' object has no attribute 'copy'’’

When I try to verify the installation, get the errorAttributeError: 'NoneType' object has no attribute 'copy'’
I ran the file 'inference_demo', the error code is visualizer.add_datasample(     'result',     img,     data_sample=result,     draw_gt=False,     wait_time=0, ).
When I annotate it, the error disappears and can be able to output an unlabeled image，like this

environment
CUDA 11.0
pytorch1.7.1
MVCC 2.0.0rc4
mmdet 3.0.0
mmengine 0.7.2
error
`
AttributeError                            Traceback (most recent call last)
/tmp/ipykernel_12220/1880806597.py in
5     data_sample=result,
6     draw_gt=False,
----> 7     wait_time=0,
8 )
9 visualizer.show()
~/anaconda3/envs/mmdet/lib/python3.7/site-packages/mmengine/dist/utils.py in wrapper(*args, **kwargs)
358     def wrapper(*args, **kwargs):
359         if is_main_process():
--> 360             return func(*args, **kwargs)
361
362     return wrapper
~/crowdhuman/mmdetection/mmdet/visualization/local_visualizer.py in add_datasample(self, name, image, data_sample, draw_gt, draw_pred, show, wait_time, out_file, pred_score_thr, step)
368                     pred_instances.scores > pred_score_thr]
369                 pred_img_data = self._draw_instances(image, pred_instances,
--> 370                                                      classes, palette)
371             if 'pred_panoptic_seg' in data_sample:
372                 assert classes is not None, 'class information is ' \
~/crowdhuman/mmdetection/mmdet/visualization/local_visualizer.py in _draw_instances(self, image, instances, classes, palette)
158                         'alpha': 0.8,
159                         'pad': 0.7,
--> 160                         'edgecolor': 'none'
161                     }])
162
~/anaconda3/envs/mmdet/lib/python3.7/site-packages/mmengine/dist/utils.py in wrapper(*args, **kwargs)
358     def wrapper(*args, **kwargs):
359         if is_main_process():
--> 360             return func(*args, **kwargs)
361
362     return wrapper
~/anaconda3/envs/mmdet/lib/python3.7/site-packages/mmengine/visualization/visualizer.py in draw_texts(self, texts, positions, font_sizes, colors, vertical_alignments, horizontal_alignments, font_families, bboxes, font_properties)
540                 family=font_families[i],
541                 fontproperties=font_properties[i],
--> 542                 color=colors[i])
543         return self
544
~/anaconda3/envs/mmdet/lib/python3.7/site-packages/matplotlib/cbook/deprecation.py in wrapper(*args, **kwargs)
356                 f"%(removal)s.  If any parameter follows {name!r}, they "
357                 f"should be pass as keyword, not positionally.")
--> 358         return func(*args, **kwargs)
359
360     return wrapper
~/anaconda3/envs/mmdet/lib/python3.7/site-packages/matplotlib/axes/_axes.py in text(self, x, y, s, fontdict, withdash, **kwargs)
768         else:
769             t = mtext.Text(x, y, text=s)
--> 770         t.update(effective_kwargs)
771
772         t.set_clip_path(self.patch)
~/anaconda3/envs/mmdet/lib/python3.7/site-packages/matplotlib/text.py in update(self, kwargs)
175         sentinel = object()  # bbox can be None, so use another sentinel.
176         bbox = kwargs.pop("bbox", sentinel)
--> 177         super().update(kwargs)
178         if bbox is not sentinel:
179             self.set_bbox(bbox)
~/anaconda3/envs/mmdet/lib/python3.7/site-packages/matplotlib/artist.py in update(self, props)
1004
1005         with cbook._setattr_cm(self, eventson=False):
-> 1006             ret = [_update_property(self, k, v) for k, v in props.items()]
1007
1008         if len(ret):
~/anaconda3/envs/mmdet/lib/python3.7/site-packages/matplotlib/artist.py in (.0)
1004
1005         with cbook._setattr_cm(self, eventson=False):
-> 1006             ret = [_update_property(self, k, v) for k, v in props.items()]
1007
1008         if len(ret):
~/anaconda3/envs/mmdet/lib/python3.7/site-packages/matplotlib/artist.py in _update_property(self, k, v)
1001                     raise AttributeError('{!r} object has no property {!r}'
1002                                          .format(type(self).name, k))
-> 1003                 return func(v)
1004
1005         with cbook._setattr_cm(self, eventson=False):
~/anaconda3/envs/mmdet/lib/python3.7/site-packages/matplotlib/text.py in set_fontproperties(self, fp)
1222         if isinstance(fp, str):
1223             fp = FontProperties(fp)
-> 1224         self._fontproperties = fp.copy()
1225         self.stale = True
1226
AttributeError: 'NoneType' object has no attribute 'copy'
`

I met the same question!

I met the same question!

I still haven't sloved this question in this environment. So I lowered the version of mmdet.

I met the same question!

I still haven't sloved this question in this environment. So I lowered the version of mmdet.

what is the version number of mmdet??

I met the same question!

I still haven't sloved this question in this environment. So I lowered the version of mmdet.

what is the version number of mmdet??

mmdet 2.25.0 mmcv-full 1.3.17 mmengine 0.7.2

thanks！

I faced a same problem when testing the model with mmdetection 3.0.0

How do I solve this problem, I work well under liunx, and report this error under Windows

I faced the same problem when testing the model with mmdetection 3.0.0
Request the Great God to resolve it？？？

How do I solve this problem, I work well under liunx, and report this error under Windows

i met the same error and wanna to ask how to do

solved! maybe you install mmdetection through mim so you shouldn't use the first methods  to verify the installation 。 you should use the seconde method to verify the installation

I faced the same problem when testing the model with mmdetection 3.0.0 Request the Great God to resolve it？？？

I met the same problem, too. I find the version of matplotlib is the key factor. In fact, you can upgrade the version of matplotlib by using pip install matplotlib --upgrade

Thanks!That works perfect!

I faced the same problem when testing the model with mmdetection 3.0.0 Request the Great God to resolve it？？？

I met the same problem, too. I find the version of matplotlib is the key factor. In fact, you can upgrade the version of matplotlib by using pip install matplotlib --upgrade

thanks! that works!

收到

authors: GarlicPineapple Ruihyw WjzZwd fat-921 juneodie miaowumonsyer mokby pd162 yulongnan

repo: open-mmlab/mmdetection


text:
DINO网络训练后的模型用mmdet预测结果错误

使用https://github.com/IDEA-Research/DINO 进行了DINO模型的训练，将得到的模型传入mmdet中，修改class等参数进行测试，模型结果识别十分混乱，请问模型的哪里出现了问题呢？

似乎是出现了边框画到图外的情况：
/home/nvidia/envs/dino/lib/python3.8/site-packages/mmengine/visualization/visualizer.py:760: UserWarning: Warning: The bbox is out of bounds, the drawn bbox may not be in the image
warnings.warn(
/home/nvidia/envs/dino/lib/python3.8/site-packages/mmengine/visualization/visualizer.py:831: UserWarning: Warning: The polygon is out of bounds, the drawn polygon may not be in the image

我遇到了和你相同的问题，但是我的框是往左下偏移的。

我刚刚已经解决我的问题了，希望对你有所帮助
config中class_name=('1',)就算只有一个类别也需要加逗号，palette同理
采用coco类型做目标检测时，box 的 xywh是指 左上高宽，不是yolo类型的中点高宽

authors: Ochre-amber klpiy


text:
about the size of Convolution's and Linear‘s parameters

Hello,everyone. I have an issue about the size of Convolution's and Linear's parameters. I try to use two convolution layers instead of the two linear layers behind RoI Pooling. The convolutions' kernel are 7x7x1024 and 1x1x1024。But both the used memory and the used GPU memory are about 4G more than using two linear layers. I check the number of their parameters, the weights’size of convolution layers are [1024,256,7,7] and [1024,1024,1,1],and the weights's size of linear layers are [1024,12544] and [1024,1024]。But 12544 = 7x7x256 ，which means thay have the same number of parameters. So I don't understand why using conv need much more memory than using linear.Anyone can help me ?

Having the same parameters does not mean their implementation cost the same GPU memory.
We cannot provide you a solid answer but this might because the conv use im2col operation for parallelism and thus cost more GPU memory during computation.

authors: ZhangYumi ZwwWayne


text:
loss_rpn_bbox is inf

In the configuration file, the loss of rpn_head uses 'L1Loss'. The training log shows 'loss_rpn_bbox: inf', but the training process can still be completed, how can I remove this 'inf'?

Hi @1428679766, your issue is not very clear. However, I think it's about your lr. Try to decrease it.

Hi @1428679766, your issue is not very clear. However, I think it's about your lr. Try to decrease it.

I also encountered the same problem, and I can train normally in the faster rcnn in mmdet. When using the same data to train the RPN, the loss will become nan in the warmup stage (have tried to lower the lr)。
Looking forward to your reply，thanks！

It usually happens when there are abnormal boxes in the GT.

authors: Fan-shujuan NuaaWill ZwwWayne manhph2211


text:
Mosaic transform

Is there a way to add a probability to the mosaic transform in my train pipeline?
For example : p=0.5 would mean leave the image as it is half the time, and modify it to a mosaic half the time

Currently, mosaic probability can not be set in config.
Try to add if random.uniform(0, 1) > p: in __call__ of the mosaic transform.
We are considering adding this feature in the future.

authors: RangiLyu joihn


text:
Deprecate LoadImage

It's not being used anywhere.

Hi @daavoo ,
Thanks for your kind contribution. It seems that LoadImage is indeed not used in this repo. But in case downstream repos use that, shall we add a warning first before totally removing it?  Can we dd a warning in the __init__ function, and then remove it in the future release (usually after 1-2 months)?

Hi @daavoo ,
Thanks for your kind contribution. It seems that LoadImage is indeed not used in this repo. But in case downstream repos use that, shall we add a warning first before totally removing it? Can we dd a warning in the __init__ function, and then remove it in the future release (usually after 1-2 months)?

It seems very reasonable, I replaced the removal with deprecation warnings

authors: ZwwWayne daavoo


text:
[Feature] Add support for mask diagonal flip in TTA

Add support for mask diagonal flip in mmdet/core/post_processing/merge_augs.py for test-time augmentation.

Hi @yeliudev ,
Thanks for the PR, would you like to also write a unit test for that?

Hi @yeliudev ,
Thanks for the PR, would you like to also write a unit test for that?

Thanks for your review. I've added the unit tests but I'm not sure whether they are in the right place.

authors: ZwwWayne yeliudev


text:
[Bug]  LoadAnnotations3D( with_bbox=True) will cause bugs results['gt_bboxes'] = results['ann_info']['gt_bboxes'] KeyError: 'gt_bboxes'

Prerequisite

[X] I have searched Issues and Discussions but cannot get the expected help.
[X] I have read the FAQ documentation but cannot get the expected help.
[X] The bug has not been fixed in the latest version (dev-1.x) or latest version (dev-1.0).

Task
I'm using the official example scripts/configs for the officially supported tasks/models/datasets.
Branch
main branch https://github.com/open-mmlab/mmdetection3d
Environment
conda install Pytorch
Reproduces the problem - code sample
train_pipeline = [
dict(
type='BEVLoadMultiViewImageFromFiles',
to_float32=True,
color_type='color',
backend_args=backend_args),
dict(
type='LoadPointsFromFile',
coord_type='LIDAR',
load_dim=5,
use_dim=[0, 1, 2, 3, 4],
),
dict(
type='LoadPointsFromMultiSweeps',
sweeps_num=10,
use_dim=[0, 1, 2, 3, 4],
),
dict(type='LoadAnnotations3D', with_bbox_3d=True, with_label_3d=True, with_bbox=True,
with_label=True, with_attr_label=True),
...
]
Reproduces the problem - command or script
bash tools/dist_train.sh projects/configs/fusion/fusion_vov.py 1
Reproduces the problem - error message
Original Traceback (most recent call last):
File "/home/users/sutd/1008377/.conda/envs/py38/lib/python3.8/site-packages/torch/utils/data/_utils/worker.py", line 302, in _worker_loop
data = fetcher.fetch(index)
File "/home/users/sutd/1008377/.conda/envs/py38/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 49, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/home/users/sutd/1008377/.conda/envs/py38/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 49, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/home/users/sutd/1008377/mmdetection3d/mmdet3d/datasets/dataset_wrappers.py", line 153, in getitem
return self.dataset[ori_index]
File "/home/users/sutd/1008377/.conda/envs/py38/lib/python3.8/site-packages/mmengine/dataset/base_dataset.py", line 408, in getitem
data = self.prepare_data(idx)
File "/home/users/sutd/1008377/mmdetection3d/mmdet3d/datasets/det3d_dataset.py", line 386, in prepare_data
example = self.pipeline(input_dict)
File "/home/users/sutd/1008377/.conda/envs/py38/lib/python3.8/site-packages/mmengine/dataset/base_dataset.py", line 58, in call
data = t(data)
File "/home/users/sutd/1008377/.conda/envs/py38/lib/python3.8/site-packages/mmcv/transforms/base.py", line 12, in call
return self.transform(results)
File "/home/users/sutd/1008377/mmdetection3d/mmdet3d/datasets/transforms/loading.py", line 1056, in transform
results = super().transform(results)
File "/home/users/sutd/1008377/.conda/envs/py38/lib/python3.8/site-packages/mmdet/datasets/transforms/loading.py", line 443, in transform
self._load_bboxes(results)
File "/home/users/sutd/1008377/mmdetection3d/mmdet3d/datasets/transforms/loading.py", line 1033, in _load_bboxes
results['gt_bboxes'] = results['ann_info']['gt_bboxes']
KeyError: 'gt_bboxes'
Additional information
I want to load 2D gt_box of mutli-view images in nuscenes annotations, How to do it?

Hi, I'm meeting the same problem, did you find the way to solve it?
Thank you for any help

have you found any solution to this

I am facing a similar error and I want to understand if there has been any update or if anyone using this framework have used gt_bboxes

This error i think something about if pkl file when it has ampty annotations. I replaced the following two methods with following code in mmdet3d/datasets/transforms/loading.py and it worked.
`def _load_bboxes(self, results: dict) -> None:
"""Private function to load bounding box annotations.
    The only difference is it remove the proceess for
    `ignore_flag`

    Args:
        results (dict): Result dict from :obj:`mmcv.BaseDataset`.

    Returns:
        dict: The dict contains loaded bounding box annotations.
    """

    try:
        results['gt_bboxes'] = results['ann_info']['gt_bboxes']
    except KeyError:
        results['gt_bboxes'] = np.array([[0, 0, 0, 0]])

def _load_labels(self, results: dict) -> None:
    """Private function to load label annotations.

    Args:
        results (dict): Result dict from :obj :obj:`mmcv.BaseDataset`.

    Returns:
        dict: The dict contains loaded label annotations.
    """
    try:
        results['gt_bboxes_labels'] = results['ann_info']['gt_bboxes_labels']
    except KeyError:
        results['gt_bboxes_labels'] = np.array([-1])`

authors: Blinkblade QasimMuhammad WinterCodeForEverything joelkny97


text:
Issue installing OpenVINO consumer application.

Hi team!,
we are trying to set up our first sample application in OpenNESS, OpenVINO, following the steps indicated on this github repository link: https://github.com/open-ness/specs/blob/master/doc/applications/openness_openvino.md
We were able set up fine the Client Simulator and OpenVINO Producer applications. But we have a problem installing the OpenVINO Consumer Application. The deployment fails on the step 39. When it tries  to run  “ RUN git config --global http.proxy $http_proxy “. The command output is: “The command '/bin/sh -c git config --global http.proxy $http_proxy' returned a non-zero code: 1”.
Below we paste the whole output.
Could you help us guiding us how we can solve this initial issue?.
Thanks!.
Julián F.
Console output:

[root@node02 consumer]# pwd
/home/edgeapps/applications/openvino/consumer
[root@node02 consumer]# ./build-image.sh
Sending build context to Docker daemon   42.5kB
Step 1/42 : FROM ubuntu:20.04
---> 9873176a8ff5
Step 2/42 : ENV http_proxy=$http_proxy
---> Using cache
---> 1d0a21f01f33
Step 3/42 : ENV https_proxy=$https_proxy
---> Using cache
---> c1d76b44d0c7
Step 4/42 : ENV no_proxy=$no_proxy,eaa.openness,analytics.openness
---> Using cache
---> 701a141f32e6
Step 5/42 : ENV DEBIAN_FRONTEND=noninteractive
---> Using cache
---> 5f03a1903b2d
Step 6/42 : ENV OPENVINO_TASKSET_CPU=7
---> Using cache
---> f0ead192bee7
Step 7/42 : ARG OPENVINO_LINK=https://registrationcenter-download.intel.com/akdlm/irc_nas/17062/l_openvino_toolkit_p_2021.1.110.tgz
---> Using cache
---> 1090f828420e
Step 8/42 : ARG YEAR=2021
---> Using cache
---> c3cbbda32d3a
Step 9/42 : ARG OPENVINO_DEMOS_DIR=/opt/intel/openvino_$YEAR/deployment_tools/open_model_zoo/demos
---> Using cache
---> 9649f7793326
Step 10/42 : ARG MODEL_ROOT=/opt/intel/openvino_$YEAR/deployment_tools/open_model_zoo/tools/downloader
---> Using cache
---> bf2921a38331
Step 11/42 : ENV APP_DIR=/opt/intel/openvino_$YEAR/deployment_tools/inference_engine/demos/python_demos/object_detection_demo_ssd_async/
---> Using cache
---> 131a1165bd0b
Step 12/42 : RUN apt-get update &&      apt-get -y install iputils-ping &&      apt-get -y install build-essential gcc g++ cmake &&     apt-get -y install cpio &&     apt-get -y install sudo &&       apt-get -y install unzip &&     apt-get -y install wget &&      apt-get -y install lsb-core &&  apt-get -y install autoconf libtool && apt-get -y install ffmpeg x264 &&        apt-get -y install git &&       apt-get -y install python3-pip &&       apt-get -y install nginx libnginx-mod-rtmp libjson-c-dev &&     apt-get -y install util-linux &&        apt-get -y install libusb-1.0-0-dev libudev-dev libssl-dev libboost-program-options1.71-dev libboost-thread1.71 libboost-filesystem1.71
---> Using cache
---> 72fce8cfe382
Step 13/42 : RUN cd /tmp &&     wget $OPENVINO_LINK &&  tar xf l_openvino_toolkit*.tgz &&       cd l_openvino_toolkit* &&       sed -i 's/decline/accept/g' silent.cfg &&       ./install_openvino_dependencies.sh &&   ./install.sh -s silent.cfg &&   rm -rf /tmp/l_openvino_toolkit*
---> Using cache
---> 8bb7034cb293
Step 14/42 : RUN pip3 install numpy
---> Using cache
---> ce305e7eca91
Step 15/42 : COPY nginx.conf /etc/nginx/nginx.conf
---> Using cache
---> 79b5a8fee3b0
Step 16/42 : RUN chmod +s /usr/sbin/nginx
---> Using cache
---> 370668d9dbac
Step 17/42 : RUN cd /tmp &&     wget https://github.com/libusb/libusb/archive/v1.0.22.zip &&    unzip v1.0.22.zip && cd libusb-1.0.22 &&        ./bootstrap.sh &&      ./configure --disable-udev --enable-shared &&    make -j4 && make install &&     rm -rf /tmp/1.0.22
---> Using cache
---> 6b214ee2b0b7
Step 18/42 : RUN useradd -ms /bin/bash -G video,users,www-data openvino &&     chown -R openvino /home/openvino
---> Using cache
---> 7a0a9ea7cd32
Step 19/42 : COPY cmd/ /home/openvino
---> Using cache
---> 162df37c1014
Step 20/42 : ADD start.sh /home/openvino
---> Using cache
---> b9f0e06233fc
Step 21/42 : RUN chown -R openvino:openvino /opt/intel/openvino*
---> Using cache
---> 101c9231cc9c
Step 22/42 : RUN chown -R openvino:openvino /home/openvino/*
---> Using cache
---> d3fd41734c40
Step 23/42 : RUN chmod 0777 /etc/hosts
---> Using cache
---> c0aa4544b482
Step 24/42 : USER openvino
---> Using cache
---> 5cbf498db786
Step 25/42 : RUN echo "source /opt/intel/openvino_$YEAR/bin/setupvars.sh" >> ~/.bashrc
---> Using cache
---> 2fb5b5da4423
Step 26/42 : RUN bash -c "source ~/.bashrc"
---> Using cache
---> daf1421dabd2
Step 27/42 : ADD object_detection_demo_ssd_async.patch $APP_DIR
---> Using cache
---> b4b319340a22
Step 28/42 : RUN cd $APP_DIR && patch -p0 object_detection_demo_ssd_async.py object_detection_demo_ssd_async.patch
---> Using cache
---> 20d1d5871d9e
Step 29/42 : RUN cd $MODEL_ROOT && python3 -mpip install --user -r ./requirements.in &&     ./downloader.py --name pedestrian-detection-adas-0002 &&     ./downloader.py --name vehicle-detection-adas-0002
---> Using cache
---> 369be183ebe3
Step 30/42 : RUN cp -r $MODEL_ROOT/intel/vehicle-detection-adas-0002 $APP_DIR/ &&     cp -r $MODEL_ROOT/intel/pedestrian-detection-adas-0002 $APP_DIR/
---> Using cache
---> 3d66dfe00297
Step 31/42 : RUN cd /tmp &&     wget https://dl.google.com/go/go1.15.linux-amd64.tar.gz &&      tar -xvf go1.15.linux-amd64.tar.gz
---> Using cache
---> 01ab39592ec4
Step 32/42 : ENV OPENVINO_ROOT=/opt/intel/openvino_$YEAR
---> Using cache
---> 4689facf64e7
Step 33/42 : ENV GOPATH=/home/openvino/go
---> Using cache
---> 8889983556b6
Step 34/42 : ENV GOROOT=/tmp/go
---> Using cache
---> 913783e47c31
Step 35/42 : ENV GO111MODULE=on
---> Using cache
---> aae2d47bb477
Step 36/42 : ENV PATH=$GOPATH/bin:$GOROOT/bin:$PATH
---> Using cache
---> 679fd530e0a2
Step 37/42 : RUN mkdir $GOPATH
---> Using cache
---> be964332b69f
Step 38/42 : WORKDIR /home/openvino
---> Using cache
---> bd06db562782
Step 39/42 : RUN git config --global http.proxy $http_proxy
---> Running in 955946df7c67
The command '/bin/sh -c git config --global http.proxy $http_proxy' returned a non-zero code: 1
[root@node02 consumer]#

Hi @jafilippini could you check if the http_proxy variable is set in your environment please? It is passed to the consumer build script and is used for this command.

Hi @cjnolan, thanks for your answer, I copy below the ENV variables of the edge node host where we are trying to deploy the Consumer Application. I do not find any variables called: http_proxy, https_proxy or no_proxy.
Could you give us an advise about what we should do?
Thanks!.
Julián

[root@node02 ~]# printenv
XDG_SESSION_ID=199
HOSTNAME=node02
SELINUX_ROLE_REQUESTED=
TERM=xterm
SHELL=/bin/bash
HISTSIZE=1000
SSH_CLIENT=172.20.247.90 57790 22
SELINUX_USE_CURRENT_RANGE=
SSH_TTY=/dev/pts/0
GOPRIVATE=github.com/open-ness
USER=root
LS_COLORS=rs=0:di=01;34:ln=01;36:mh=00:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:mi=01;05;37;41:su=37;41:sg=30;43:ca=30;41:tw=30;42:ow=34;42:st=37;44:ex=01;32:.tar=01;31:.tgz=01;31:.arc=01;31:.arj=01;31:.taz=01;31:.lha=01;31:.lz4=01;31:.lzh=01;31:.lzma=01;31:.tlz=01;31:.txz=01;31:.tzo=01;31:.t7z=01;31:.zip=01;31:.z=01;31:.Z=01;31:.dz=01;31:.gz=01;31:.lrz=01;31:.lz=01;31:.lzo=01;31:.xz=01;31:.bz2=01;31:.bz=01;31:.tbz=01;31:.tbz2=01;31:.tz=01;31:.deb=01;31:.rpm=01;31:.jar=01;31:.war=01;31:.ear=01;31:.sar=01;31:.rar=01;31:.alz=01;31:.ace=01;31:.zoo=01;31:.cpio=01;31:.7z=01;31:.rz=01;31:.cab=01;31:.jpg=01;35:.jpeg=01;35:.gif=01;35:.bmp=01;35:.pbm=01;35:.pgm=01;35:.ppm=01;35:.tga=01;35:.xbm=01;35:.xpm=01;35:.tif=01;35:.tiff=01;35:.png=01;35:.svg=01;35:.svgz=01;35:.mng=01;35:.pcx=01;35:.mov=01;35:.mpg=01;35:.mpeg=01;35:.m2v=01;35:.mkv=01;35:.webm=01;35:.ogm=01;35:.mp4=01;35:.m4v=01;35:.mp4v=01;35:.vob=01;35:.qt=01;35:.nuv=01;35:.wmv=01;35:.asf=01;35:.rm=01;35:.rmvb=01;35:.flc=01;35:.avi=01;35:.fli=01;35:.flv=01;35:.gl=01;35:.dl=01;35:.xcf=01;35:.xwd=01;35:.yuv=01;35:.cgm=01;35:.emf=01;35:.axv=01;35:.anx=01;35:.ogv=01;35:.ogx=01;35:.aac=01;36:.au=01;36:.flac=01;36:.mid=01;36:.midi=01;36:.mka=01;36:.mp3=01;36:.mpc=01;36:.ogg=01;36:.ra=01;36:.wav=01;36:.axa=01;36:.oga=01;36:.spx=01;36:*.xspf=01;36:
OVN_NB_DB=unix:/var/run/ovn/ovnnb_db.sock
MAIL=/var/spool/mail/root
PATH=/root/go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/root/bin
PWD=/root
LANG=en_US.UTF-8
SELINUX_LEVEL_REQUESTED=
HISTCONTROL=ignoredups
SHLVL=1
HOME=/root
GOROOT=/usr/local/go
LOGNAME=root
CVS_RSH=ssh
SSH_CONNECTION=172.20.247.90 57790 172.29.14.234 22
GOPATH=/root/go
LESSOPEN=||/usr/bin/lesspipe.sh %s
XDG_RUNTIME_DIR=/run/user/0
_=/usr/bin/printenv
[root@node02 ~]#

@jafilippini , if your edge node, where you built the openvino-cons-app docker image, has direct Internet connection, I think you should comment out that git config command in the Dockerfile.

Hi @ttzeng, thanks for your answer!.
I have commented that line.
But now receive the following error during the image building:
…..
Step 40/41 : RUN go build main.go openvino.go eaa_interface.go
---> Running in 9ec7716a899d
.   # command-line-arguments
./openvino.go:97:2: undefined: wg
note: module requires Go 1.16
The command '/bin/sh -c go build main.go openvino.go eaa_interface.go' returned a non-zero code: 2
[root@node02 consumer]#
…...
Below we paste the whole output.
We appreciate your value help.
Thanks!.
Julián F.
Console output:

[root@node02 consumer]#
[root@node02 consumer]#
[root@node02 consumer]# ./build-image.sh
Sending build context to Docker daemon   42.5kB
Step 1/41 : FROM ubuntu:20.04
---> 9873176a8ff5
Step 2/41 : ENV http_proxy=$http_proxy
---> Using cache
---> 1d0a21f01f33
Step 3/41 : ENV https_proxy=$https_proxy
---> Using cache
---> c1d76b44d0c7
Step 4/41 : ENV no_proxy=$no_proxy,eaa.openness,analytics.openness
---> Using cache
---> 701a141f32e6
Step 5/41 : ENV DEBIAN_FRONTEND=noninteractive
---> Using cache
---> 5f03a1903b2d
Step 6/41 : ENV OPENVINO_TASKSET_CPU=7
---> Using cache
---> f0ead192bee7
Step 7/41 : ARG OPENVINO_LINK=https://registrationcenter-download.intel.com/akdlm/irc_nas/17062/l_openvino_toolkit_p_2021.1.110.tgz
---> Using cache
---> 1090f828420e
Step 8/41 : ARG YEAR=2021
---> Using cache
---> c3cbbda32d3a
Step 9/41 : ARG OPENVINO_DEMOS_DIR=/opt/intel/openvino_$YEAR/deployment_tools/open_model_zoo/demos
---> Using cache
---> 9649f7793326
Step 10/41 : ARG MODEL_ROOT=/opt/intel/openvino_$YEAR/deployment_tools/open_model_zoo/tools/downloader
---> Using cache
---> bf2921a38331
Step 11/41 : ENV APP_DIR=/opt/intel/openvino_$YEAR/deployment_tools/inference_engine/demos/python_demos/object_detection_demo_ssd_async/
---> Using cache
---> 131a1165bd0b
Step 12/41 : RUN apt-get update &&      apt-get -y install build-essential gcc g++ cmake &&     apt-get -y install cpio &&      apt-get -y install sudo &&      apt-get -y install unzip &&     apt-get -y install wget &&      apt-get -y install lsb-core &&  apt-get -y install autoconf libtool &&  apt-get -y install ffmpeg x264 &&      apt-get -y install git &&        apt-get -y install python3-pip &&       apt-get -y install nginx libnginx-mod-rtmp libjson-c-dev &&     apt-get -y install util-linux &&        apt-get -y install libusb-1.0-0-dev libudev-dev libssl-dev libboost-program-options1.71-dev libboost-thread1.71 libboost-filesystem1.71
---> Using cache
---> be3b7c81c4b8
Step 13/41 : RUN cd /tmp &&     wget $OPENVINO_LINK &&  tar xf l_openvino_toolkit*.tgz &&       cd l_openvino_toolkit* &&       sed -i 's/decline/accept/g' silent.cfg &&       ./install_openvino_dependencies.sh &&   ./install.sh -s silent.cfg &&   rm -rf /tmp/l_openvino_toolkit*
---> Using cache
---> d9be810e1397
Step 14/41 : RUN pip3 install numpy
---> Using cache
---> d55631626b8f
Step 15/41 : COPY nginx.conf /etc/nginx/nginx.conf
---> Using cache
---> a082990e9220
Step 16/41 : RUN chmod +s /usr/sbin/nginx
---> Using cache
---> 70abdc8fea8d
Step 17/41 : RUN cd /tmp &&     wget https://github.com/libusb/libusb/archive/v1.0.22.zip &&    unzip v1.0.22.zip && cd libusb-1.0.22 &&        ./bootstrap.sh &&      ./configure --disable-udev --enable-shared &&    make -j4 && make install &&     rm -rf /tmp/1.0.22
---> Using cache
---> 07807cae6e70
Step 18/41 : RUN useradd -ms /bin/bash -G video,users,www-data openvino &&     chown -R openvino /home/openvino
---> Using cache
---> 00f294e8cbc0
Step 19/41 : COPY cmd/ /home/openvino
---> Using cache
---> 5650fd04e26c
Step 20/41 : ADD start.sh /home/openvino
---> Using cache
---> 4533742a403b
Step 21/41 : RUN chown -R openvino:openvino /opt/intel/openvino*
---> Using cache
---> 28b8dc2c2002
Step 22/41 : RUN chown -R openvino:openvino /home/openvino/*
---> Using cache
---> 9a4e7cfc9197
Step 23/41 : RUN chmod 0777 /etc/hosts
---> Using cache
---> 8d23e60ac564
Step 24/41 : USER openvino
---> Using cache
---> fd8c85004208
Step 25/41 : RUN echo "source /opt/intel/openvino_$YEAR/bin/setupvars.sh" >> ~/.bashrc
---> Using cache
---> a39915f6e1b7
Step 26/41 : RUN bash -c "source ~/.bashrc"
---> Using cache
---> a62d08229923
Step 27/41 : ADD object_detection_demo_ssd_async.patch $APP_DIR
---> Using cache
---> b37f1f529d8b
Step 28/41 : RUN cd $APP_DIR && patch -p0 object_detection_demo_ssd_async.py object_detection_demo_ssd_async.patch
---> Using cache
---> d0b9add699f2
Step 29/41 : RUN cd $MODEL_ROOT && python3 -mpip install --user -r ./requirements.in &&     ./downloader.py --name pedestrian-detection-adas-0002 &&     ./downloader.py --name vehicle-detection-adas-0002
---> Using cache
---> b2638e1f7186
Step 30/41 : RUN cp -r $MODEL_ROOT/intel/vehicle-detection-adas-0002 $APP_DIR/ &&     cp -r $MODEL_ROOT/intel/pedestrian-detection-adas-0002 $APP_DIR/
---> Using cache
---> 959a71a062b9
Step 31/41 : RUN cd /tmp &&     wget https://dl.google.com/go/go1.15.linux-amd64.tar.gz &&      tar -xvf go1.15.linux-amd64.tar.gz
---> Using cache
---> 64423f1b5104
Step 32/41 : ENV OPENVINO_ROOT=/opt/intel/openvino_$YEAR
---> Using cache
---> 0b298125c57c
Step 33/41 : ENV GOPATH=/home/openvino/go
---> Using cache
---> 505d9e0813d3
Step 34/41 : ENV GOROOT=/tmp/go
---> Using cache
---> 310e1c849194
Step 35/41 : ENV GO111MODULE=on
---> Using cache
---> ab3ade636582
Step 36/41 : ENV PATH=$GOPATH/bin:$GOROOT/bin:$PATH
---> Using cache
---> 9124cada7655
Step 37/41 : RUN mkdir $GOPATH
---> Using cache
---> 35eb000d058c
Step 38/41 : WORKDIR /home/openvino
---> Using cache
---> 7165602114c9
Step 39/41 : RUN go get github.com/gorilla/websocket
---> Using cache
---> 142829406673
Step 40/41 : RUN go build main.go openvino.go eaa_interface.go
---> Running in 9ec7716a899d
. # command-line-arguments
./openvino.go:97:2: undefined: wg
note: module requires Go 1.16
The command '/bin/sh -c go build main.go openvino.go eaa_interface.go' returned a non-zero code: 2
[root@node02 consumer]#
[root@node02 consumer]#

@jafilippini, according to the error, it seems you have to define the variable wg with var wg sync.WaitGroup before the wg.Wait() statement. Please also add "sync" module to the import section at the beginning.

Hi @ttzeng, effectively the definition of the var wg is abscent on the openvino.go file when the image is built.
To solve, due I do not know from where docket takes the openfile.go file, I initially created a auxiliary container without the las lines of the original Dockerfile, I ran it, and from there O took the openvino.go file that if wrong.
I created the same file in the consumer folder of the host server, and added to the Dockerfile a line that copy the external openvino.go file to the image.
In this way, I could créate succesfully the consumer image!.
Thanks again!.
Julián

authors: cjnolan jafilippini ttzeng

repo: open-ness/edgeapps


text:
Update OPA to v0.12.2

Automated pull request to revendor OPA

No vendor changes.

authors: ashutosh-narkar opa-updater-automation

repo: open-policy-agent/opa-istio-plugin


text:
Set denied status when it exists.

The denied status is a required field that should be set when a valid http satus is provided. Setting this to nil can cause Envoy to return an Unknown error on a denied request.
Signed-off-by: Ashutosh Narkar anarkar4387@gmail.com

It would be good to cover this kind of change with a unit test.

There is a unit test which covers getResponseHTTPStatus functionality. After system testing, it was discovered this change was not resolving the issue which caused Envoy to return an Unknown status code. The issue was resolved with PR https://github.com/open-policy-agent/opa-istio-plugin/pull/124. The change was both unit and system tested.

authors: ashutosh-narkar tsandall


text:
testing PQ enabled openssl with s_time cmd

Hi! I'm considering doing a little benchmark of the post quantum ciphers in a openssl playground (mainly kex & signature algorithms). I've tested the command line server that comes with the openssl server and generated a self signed certificate with the pq signature of choice. I could connect to this server via the  openssl s_client tool, which lets you specify with the -curves parameter the  algorithm. This option is not available with the s_time command, very handy when benchmarking TLS connections. How do I specifically force a KEX algorithm in the test server/client connection with s_time. Are there any workarounds that you might know?
Thank you!

Hi Ricardo, I haven't tried the s_time command so I am not sure how it works.  We haven't explicitly enabled or tested PQ support in s_time.  If you look at it and can let us know what needs to change or want to submit a patch to that effect, we'd be happy to have it.

authors: RicardoGaGu dstebila

repo: open-quantum-safe/testing


text:
remove self-generated task types in dispatcher during reassignment

Previously, dispatcher_node could only cancel tasks ChargeBattery task during reassignment, since ChargeBattery is auto-generated by RMF. Other task types which are self-generated (non-user submitted) will not get canceled during reassignment. This will solve this.

Hello, build failed with this errror:
   <testcase classname="test_rmf_fleet_adapter.MockAdapterFixture" name="Scenario: ingest item phase" time="0.0">
      <error type="TEST_CASE">
SIGSEGV - Segmentation violation signal
at /home/runner/work/rmf_ros2/rmf_ros2/ros_ws/src/bd883j35yy/rmf_ros2/rmf_fleet_adapter/test/phases/test_IngestItem.cpp:53
      </error>
    </testcase>

at this line: https://github.com/open-rmf/rmf_ros2/blob/main/rmf_fleet_adapter/test/phases/test_IngestItem.cpp#L53
Test results can be downloaded here ( at the bottom ):
https://github.com/open-rmf/rmf_ros2/actions/runs/1069793498

After "rerun" all the checks, it seems to pass. :thinking: It is also quite weird that the previously test_IngestItem failed, considering it's not relevant.

authors: Yadunund youliangtan


text:
fix: multiple-button-injections

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[x] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description
This PR proposes a new handler to resolve the multiple button injections issue, avoid it in any future content-script components without the need for guards in the injection scripts. 570f9ac40e679324c1bf5fbef4b58a1eeccd37ce.
Here's how it works:

A content-script runs when a page is loaded. In our case https://github.com. All of the GitHub processing is done within the processGithubPage function of the content-script. https://github.com/open-sauced/ai/blob/554bdedef96f35b1e967d1dd2cd934b2158fcda2/src/content-scripts/github.ts#L48

Any navigation within GH without a reload doesn't re-run the content-script. Thereby not running the processGithubPage function.

Hence the domUpdateWatch utility was introduced that listens for navigations within https://github.com and runs a callback with a specified delay in ms. The callback being processGithubPage.
https://github.com/open-sauced/ai/blob/554bdedef96f35b1e967d1dd2cd934b2158fcda2/src/content-scripts/github.ts#L45

The multiple injection issue arises when a user navigates back to a page without a reload that was already processed by the content-script. Leading to re-injections.

Currently, we utilize guards like the one below in all the injection scripts to resolve the issue. But this solution introduced redundancy and is prone to edge-cases like #87.
https://github.com/open-sauced/ai/blob/554bdedef96f35b1e967d1dd2cd934b2158fcda2/src/utils/dom-utils/viewOnOpenSauced.ts#L14-L16

This solution resolves the issue using a navigationHistory set that holds the URLs navigated by the user. The processGithubPage returns without any injection if the page was already visited by the user and injections(if any) were done. All the injection guards have been removed from the injection scripts.
https://github.com/open-sauced/ai/blob/5a54b74dbaabf78d7a25a65f3ad2dd59101f498f/src/content-scripts/github.ts#L18-L26

Like mentioned above, the content-script re-runs with every page reload, thereby resetting the navigationHistory set and the injected components are removed, re-injected as required.

Additionally, this PR,

Adds background-color, padding to the extension login page. 29d4212637928b4de0d5b2b5d694e2e154bc6543.
As mentioned in https://github.com/open-sauced/ai/pull/101#issuecomment-1559198667, removes the PR author check before injecting the "Add PR to highlights" button. 5a54b74dbaabf78d7a25a65f3ad2dd59101f498f.

Related Tickets & Documents
Resolves #87.
Mobile & Desktop Screenshots/Recordings
Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

@diivi can you review when you get a moment?

Instead of adding more complexity to the codebase, why not just improve the guard? The actual reason .isEqualNode does not work is because these two a tags are evidently not equal:

This actually simplifies the codebase by a lot. We no longer have to use guards at all.
https://github.com/open-sauced/ai/blob/5a54b74dbaabf78d7a25a65f3ad2dd59101f498f/src/content-scripts/github.ts#L24-L26
These 3 lines handle it for us at the top-level.

This still won't handle all cases though:
In #90, when I merge this PR and remove the guard,

Because during reviewing, no change in the browsing occurs.
Also, I get your point about the injections, but the guards can easily be moved upwards to prevent that from happening?

I was also able to reproduce this bug on this branch:

I was also able to reproduce this bug on this branch, by just clicking everywhere randomly:

I tested this on the beta branch.
About reproduction in #90, that is because of the new DOM watcher https://github.com/open-sauced/ai/blob/d6f6e59add0cccb2de6e5c11b2c0db5fecc13a89/src/utils/dom-utils/prWatcher.ts#L14-L31 introduced in the PR, wherein the AI refactor button is being iteratively injected into each file comment box on DOM mutation. The guard being used here works suits the purpose.
https://github.com/open-sauced/ai/blob/d6f6e59add0cccb2de6e5c11b2c0db5fecc13a89/src/utils/dom-utils/changeSuggestorButton.ts#L13-L15
But this PR resolves duplicate injections caused by the re-navigation to previously visited pages.
Also, we can't actually move the guard used in my example higher up since it uses variables derived from the code above it.

Also, we can't actually move the guard used in my example higher up since it uses variables derived from the code above it.

They are all static variables (no fetching involved) though.

But this PR resolves duplicate injections caused by the re-navigation to previously visited pages.

I still prefer just using guards everywhere (standard) instead of solving some things like this and other by guards.
But this does work (only) for #87, so I'll leave it up to you.

That sounds right. We can update all the guards to use the querySelector with an ID instead of equalsNode like the one at https://github.com/open-sauced/ai/blob/d6f6e59add0cccb2de6e5c11b2c0db5fecc13a89/src/utils/dom-utils/changeSuggestorButton.ts#L13-L15

authors: Anush008 bdougie diivi

repo: open-sauced/ai


text:
Feature: Match Repository Insight Edit Page to Workspace UI

Type of feature
🍕 Feature
Current behavior
This PR https://github.com/open-sauced/app/pull/2949 updated the creation flow for Insights, but missed the edit flow.

Suggested solution
Match the Workspace experience.
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[ ] I agree to follow this project's Contribution Docs

Probably worth updating the Contributor Insights edit page as well.

repo: open-sauced/app


text:
fix some broken conditionals in pipelines

This PR fixes some pipeline if conditionals that didn't work correctly.

@mwear @pjanotti can we get this over the line? :)

Hi @mowies - I approved it a few days back, but, I'm not a maintainer on this repo.

authors: mowies pjanotti


text:
[bug] @types/ioredis4 included in regular non-dev dependencies of ioredis instrumentation

Here is the line in question: https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/opentelemetry-instrumentation-ioredis/package.json#L72
This should be moved to devDependencies. This mistake is currently causing my company's CI to fail due to it not being able to find this package, even though it shouldn't need this package as it should be a dev dependency.
You can even see it included in the dependencies list here: https://www.npmjs.com/package/@opentelemetry/instrumentation-ioredis?activeTab=dependencies and when you click on it, it doesn't exist.
~Related to this: This package doesn't actually seem to exist. Is ioredis4 a typo? @types/ioredis does exist, and when you go to that package is says This is a stub types definition. ioredis provides its own type definitions, so you do not need this installed., so I think this types package isn't even necessary to begin with.~
After looking at it again, it looks like this is a custom specification to use an older version of the @types/ioredis package. Why are you doing this when you use ioredis 5? I feel like this can just be safely removed
What version of OpenTelemetry are you using?

0.41.1 of auto-instrumentations-node

What version of Node are you using?

14 (not really relevant for this)

After looking at the source more, I see why you did it this way.
We also upgraded the service in question to use a later lockfile version as it was still on 1. As a result, the issue is now gone. Sorry for the false bug report

repo: open-telemetry/opentelemetry-js-contrib


text:
feat(graphql): add ignoreTrivialResolveSpans config option

Which problem is this PR solving?
graphql instrumentation is creating a "resolve" span for each field in the query result.
this can be a HUGE amount of spans, out of which most are definitely not interesting.
Objects with many fields or lists can grow to hundreds or thousands spans per query!
Users usually don't write a resolver for each and every field. they have few resolvers to fetch data from database or http endpoint, and then they map the returned object fields using the default field resolver which just look for a property with the same name on the object.
https://graphql.org/learn/execution/#trivial-resolvers
Creating spans for these trivial property resolvers is not very interesting and increases noise and costs.
This PR adds a config option so that for fields that use the custom resolver which just resolve to a property, span creation is skipped.
Example:
const schema = buildSchema(`
    type Query {
        users: [User!]!
    }

    type User {
        name: String
        age: Int
    }
`);

const rootValue = {
    // mock an async call to external data source
    users: Promise.resolve([{ name: 'John', age: 40 }, { name: 'Jane', age: 25 }, { name: 'Bob', age: 31 }]),
};

const source = '{ users { name, age} }';

await graphql({ schema, source, rootValue });

This query will create 7 "resolve" spans. One for resolving the users list, and then 3 for resolving each object name and 3 for resolving the age.
When turning on the new config option, only the first one is recorded. The span describing resolving of the query field "name" from the property "name" on "{ name: 'John', age: 40 }" to 'John' is not instrumented.
Short description of the changes

Added config option to instrumentation config
Documented it and other options in README
updated the resolver function patch to be aware if it's patching the defaultFieldResolver, and if so, to check if it's about to resolve a property (in contrast to function). If so - it will call the original function without any instrumentation.

Thank you @obecny for the review. Very much appreciate it.


text:
SpanContext object returns undefined on @opentelemetry/api@1.3.0 and above

What happened?
Steps to Reproduce
Using version 1.3.0 and above on the @opentelemetry/api package fails to get the traceId and spanId out of the SpanContext object.
Expected Result
trace.getSpan(context.active()).spanContext() should return a SpanContext object like:
{"traceId":"6cba5e5ed2a9d6560799bd732808c5fa","spanId":"d6f516bd95580255","traceFlags":1}

Actual Result
trace.getSpan(context.active()).spanContext() returns undefined.
Additional Details
I have the tracing configured on my NodeJS Serverless Framework lambdas. Currently I am utilizing Lambda layers to set up Open Telemetry. I can verify that version 1.2.0 does not have this issue.
OpenTelemetry Setup Code
// instrumentation.js

/*eslint-disable*/
const { diag, DiagConsoleLogger, DiagLogLevel } = require('@opentelemetry/api');
const { getNodeAutoInstrumentations } = require('@opentelemetry/auto-instrumentations-node');
const { OTLPTraceExporter } = require('@opentelemetry/exporter-trace-otlp-grpc');
const { registerInstrumentations } = require('@opentelemetry/instrumentation');
const { Resource } = require('@opentelemetry/resources');
const { BatchSpanProcessor } = require('@opentelemetry/sdk-trace-base');
const { NodeTracerProvider } = require('@opentelemetry/sdk-trace-node');
const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions');
/* eslint-enable */

diag.setLogger(new DiagConsoleLogger(), process.env.DEBUGGING_WITHOUT_OTEL === 'true' ? DiagLogLevel.NONE: DiagLogLevel.NONE);

const provider = new NodeTracerProvider({
	resource: new Resource({
		[SemanticResourceAttributes.SERVICE_NAME]: `my-application-name-${
			process.env.ENVIRONMENT || process.env.stageName
		}`,
	}),
});

const collectorOptions = {
	url: process.env.ASURE_OTEL_COLLECTOR_ENDPOINT,
};

const spanProcessor = new BatchSpanProcessor(new OTLPTraceExporter(collectorOptions));
provider.addSpanProcessor(spanProcessor);

provider.register();
registerInstrumentations({
	autoDetectResources: true,
	instrumentations: [
		// auto instrumentation
		new getNodeAutoInstrumentations({
			'@opentelemetry/instrumentation-aws-lambda': {
				disableAwsContextPropagation: true,
			},
		}),
	],
});

// handler.ts

import { context, trace } from '@opentelemetry/api';

export const handler = async () => {
	return trace.getTracer('asure.platform.esignature.service')
		.startActiveSpan(
		`handler`,
		async (span) => {
			try {
				console.log(trace.getSpan(context.active())?.spanContext().spanId); // logs undefined on v.1.3.0+
				console.log(trace.getSpan(context.active())?.spanContext().traceId); // logs undefined on v.1.3.0+

				//some operation here...

			} catch (error) {
				// handling error here
			} finally {
				span.end();
			}
		}
	);
};

package.json
{
    "devDependencies": {
        "@serverless/compose": "^1.3.0",
        "@serverless/typescript": "^3.21.0",
        "@types/aws-lambda": "^8.10.92",
        "@types/jest": "^27.4.1",
        "@types/node": "^17.0.21",
        "@typescript-eslint/eslint-plugin": "^5.44.0",
        "@typescript-eslint/parser": "^5.44.0",
        "aws-sdk-client-mock": "^2.0.1",
        "eslint": "^8.28.0",
        "serverless": "^3.25.0",
        "serverless-bundle": "^5.5.0",
        "serverless-domain-manager": "^6.2.1",
        "serverless-offline": "^11.5.0",
        "serverless-plugin-typescript": "^2.1.4",
        "typescript": "^4.5.5"
    },

    ...

    "dependencies": {
        "@aws-sdk/client-dynamodb": "^3.212.0",
        "@aws-sdk/client-s3": "^3.223.0",
        "@aws-sdk/client-secrets-manager": "^3.54.0",
        "@aws-sdk/lib-dynamodb": "^3.224.0",
        "@aws-sdk/s3-request-presigner": "^3.223.0",
        "@aws-sdk/util-dynamodb": "^3.213.0",
        "@opentelemetry/api": "^1.2.0",
        "@opentelemetry/semantic-conventions": "^1.9.1",
        "ajv": "^8.11.2",
        "ajv-errors": "^3.0.0",
        "ajv-formats": "^2.1.1",
        "aws-multipart-parser": "^0.2.1",
        "axios-mock-adapter": "^1.21.2",
        "fs": "0.0.1-security",
        "jsonwebtoken": "^8.5.1",
        "jwk-to-pem": "^2.0.5",
        "mime-types": "^2.1.35",
        "serverless-apigw-binary": "^0.4.4",
        "serverless-plugin-log-subscription": "^2.2.0",
        "winston": "^3.8.2"
    }
}

Relevant log output
No response

Your code uses e.g @opentelemetry/sdk-trace-node but it isn't in your dependencies.
Either something is missing in the description or these modules are present because of something else.
My best guess is that there is a version mismatch, e.g. your version of @opentelemetry/sdk-trace-node,... requires a different API version than that one you have in your dependencies.
Check your node_modules folder for duplicates of @opentelemetry/XXX modules and avoid them by using compatible versions.

@Flarna, Sorry I forgot to mention that I have two different package.json for both the handler code and the otel set up code. In my Otel setup code I do have the @opentelemetry/sdk-trace-node package
{
	"name": "otel-setup",
        ...
	"dependencies": {
		"@opentelemetry/api": "^1.2.0",
		"@opentelemetry/auto-instrumentations-node": "^0.32.0",
		"@opentelemetry/context-async-hooks": "^1.6.0",
		"@opentelemetry/exporter-trace-otlp-grpc": "^0.32.0",
		"@opentelemetry/instrumentation": "^0.32.0",
		"@opentelemetry/sdk-trace-base": "^1.6.0",
		"@opentelemetry/sdk-trace-node": "^1.6.0",
		"@opentelemetry/semantic-conventions": "^1.6.0"
	}
}

This package.json has always had the @opentelemetry/api version at 1.2.0. I'm gonna try updating and matching the version between my otel setup package.json and my handler's package.json would fix the problem.

An API later than the one used in setup cannot be used. This is to avoid the case where your handler code calls a function which doesn't yet exist on the API which was used to set up the globals.

This works as intended I'm closing this. Feel free to reopen or comment if there is an issue.

authors: Breadkenty Flarna dyladan

repo: open-telemetry/opentelemetry-js


text:
@opentelemetry/context-zone Maximum call stack size exceeded occurs when the Redux Tool Chrome Extension is enabled for Next v13.5.4

What happened?

OpenTelemetry Setup Code
import { WebTracerProvider } from '@opentelemetry/sdk-trace-web'
import { Resource } from '@opentelemetry/resources'
import { SemanticResourceAttributes } from '@opentelemetry/semantic-conventions'
import { ZoneContextManager } from '@opentelemetry/context-zone'
import { registerInstrumentations } from '@opentelemetry/instrumentation

const provider = new WebTracerProvider()
provider.register({
  contextManager: new ZoneContextManager(),
})

package.json
"dependencies": {
    "@opentelemetry/api": "^1.4.0",
    "@opentelemetry/context-zone": "^1.9.1",
    "@opentelemetry/core": "^1.13.0",
    "@opentelemetry/exporter-trace-otlp-http": "^0.35.1",
    "@opentelemetry/instrumentation": "^0.39.1",
    "@opentelemetry/instrumentation-fetch": "^0.39.1",
    "@opentelemetry/instrumentation-xml-http-request": "^0.39.1",
    "@opentelemetry/otlp-transformer": "^0.39.1",
    "@opentelemetry/resources": "^1.13.0",
    "@opentelemetry/sdk-trace-web": "^1.13.0",
    "@opentelemetry/semantic-conventions": "^1.13.0"
  }

Relevant log output
No response

The provided screenshot is too low resolution to read and appears to be minified code. Can you please copy and paste a text version of the stacktrace?
Can you also try using the stack context manager and see if the bug still persists? This context manager is not recommended for production but should help us to eliminate variables for debugging.

normalizeRouterState is not opentelemetry code. This might be caused by the extension. Can you please provide a reproduction so we can look into this further?

What is making you think this is caused by the context manager? I don't see reference to it in the stacktrace or error message?

This is a Next.js demo project that includes a secondary development of sdk.js based on OpenTelemetry and imports the "context" package. In Next.js, if you load this project using the "Script beforeInteractive" or "Script afterInteractive" modes during production builds and with Redux DevTools enabled, it may result in a stack overflow error. However, if you load the project using the "lazyOnload" mode, this issue should not occur.
Demo

with Redux DevTools enabled, it will result in an error stating "Maximum call stack size exceeded.". However, if you load the project using the "lazyOnload" mode, this issue should not occur.

This REALLY does sound like the DevTools is adding something to the base prototype (of some class) that has a recursive loop (back to a parent object) so that when the recursive code attempt to traverse the object tree it goes forever.
And based on the normalizeRouterState in the recursive call stack this seems to be what that function is doing.
So it seems like the DevTools is seeing something that the Context Manager is adding that triggeres this scenario -- exactly what! Well thats the million dollar question. Can you (@WeirShir) do some debugging and identify what that normalizeRouterState is repeating on as this will help identify "who" is the culprit. I suspect a fix will be required in the normalizeRouterState and/or the DevTools and not (specifically) in the Context Manager.

This sounds like an issue I need to raise with Redux Tool officials.

FWIW normalizeRouterState is part of Next's use of the Redux DevTools:

https://github.com/vercel/next.js/blob/ffdfd33251165d8b2f092568c8e4e5f08c71a636/packages/next/src/client/components/use-reducer-with-devtools.ts#L12

As far as I know, the Redux DevTools don't do anything to "mess with prototypes".

Really interesting... in this stackblitz, https://stackblitz.com/edit/github-wywdtb?file=src%2Fapp%2Flayout.tsx
You can npm i, and then npm run build && npx serve out - and you'll see in the console the issues.
What seems to happen is that the object prototype is polluted, or somehow there's a self-referential object that just stacks up calls to the normalizeRouterState function.
I am more on the first option:

Why would the zone object end up in the Next.js redux dev tools code 🤔 it has to be pollution right?

Once you get to this point of the debugging, past the __PAGE__ stuff from RSC, there's no way back, it'll just stack up calls to normalizeRouterState 🤔

This sounds like an issue I need to raise with Redux Tool officials
@WeirShi did you ever raise this with redux tools?

@dyladan per above this appears to be an issue with Next's code, not the Redux DevTools

Sorry. I guess the more pertinent question is "can this be closed?" It doesn't seem to be caused by anything we're doing

There hasn't been much interaction on this and it does so far seem to be something in either Next or Redux DevTools. Will close this out for now, but if something new comes up leaning toward otel-js needing a fix, feel free to comment or open a new issue.

authors: JamieDanielson MSNev WeirShi dyladan icyJoseph markerikson


text:
chore(tracing): dont use internal core type #2177

Fixes #2177

We could also export ENVIRONMENT in core. Effectivly it's exported already.

I checked and i couldn't find it, my version has the benefit of not needing the update the type if the getEnv return something else


text:
feat(instrumentation-http): Add API for adding custom metric attributes

Which problem is this PR solving?
Add a clear and intuitive API to configure custom metric attributes that a user may inject (unrelated to span context).
Fixes #4107
Related discussion: https://github.com/open-telemetry/opentelemetry-js/discussions/4088
Short description of the changes
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?
There are only two metrics recorded, they should both get the custom attributes:

[x] Unit test assertion: Ensure custom metric attributes are added to client http bucket
[x] Unit test assertion: Ensure custom metric attributes are added to server http bucket

Checklist:

[x] Followed the style guidelines of this project
[x] Unit tests have been added
[x] Documentation has been updated

@legendecas does it look good to you now?

@legendecas Hi, can we merge this please? 🙏

👻
Guess I got ghosted, lets close this.

Hey @legendecas,
hope you're doing well!
sorry for bumping this.
How can I achieve this functionality with the current implementation of the library?

@klippx @legendecas what happened here? T

Never mind me. I see the changes relate to static label values only and I was looking for a dynamic one.

I'd like to add the service name as an attribute on http metrics - seems like it isn't possible without something like this.

The marked answer has been updated to reflect how we solved this: https://github.com/open-telemetry/opentelemetry-js/discussions/4088#discussioncomment-11187236
This fixes the problem across all metrics, not only http metrics.

authors: GraemeF alexa-gt klippx naorpeled