text:
Flush() in BulkIndexor is funky

This issue is really for @araddon
This works, but has some idiosyncrasies. For instance, in the bulk_test.go file for func TestBulkSmallBatch, if you do not "sleep" and only Flush(), the test fails. So it seems that in order to properly Flush, you have to wait for some unspecified duration of time so that the channel can receive and format the messages - at least I think this is what is happening.
I would not mind if the Flush method actually handled this wait time, but I don't really have any clue as to how to calculate a reasonable wait time.
Does this make sense?

Although fixed at some point, this problem seems to have resurfaced. In my tests, I want to be able to:

bulk index some data
flush the bulk indexer
refresh the index
search

I don't expect to be able to do this in production, but it is a reasonable expectation for testing.
I may well be doing something wrong, but it seems that without a (rather long) delay of between flushing and refreshing, this doesn't work.
Here is the code from the old version:
// Flush all current documents to ElasticSearch
func (b *BulkIndexer) Flush() {
	b.mu.Lock()
	if b.docCt > 0 {
		b.send(b.buf)
	}
	b.mu.Unlock()
	for {
		select {
		case <-wgChan(b.sendWg):
			// done
			return
		case <-time.After(time.Second * time.Duration(MAX_SHUTDOWN_SECS)):
			// timeout!
			return
		}
	}
}

and the current version:
// Flush all current documents to ElasticSearch
func (b *BulkIndexer) Flush() {
	b.mu.Lock()
	if b.docCt > 0 {
		b.send(b.buf)
	}
	b.mu.Unlock()
}

Just a note that this problem also hinders checking for errors at the end of a bulk index operation. Ideally, a developer would like to use a strategy like this:

start a bulk operation
push a bunch of data to the bulk operation
flush the bulk operation
check for errors
if errors, try again (the bulk operations would have to be idempotent)

However, flushing currently only ensures that the data has been passed to the write thread (if I understand correctly), not that it's been written and appropriate errors have been processed, so you don't know if you've gotten the errors yet.
At the very least, the flush operation should be fixed (ideally with some way to collect errors). I can provide a patch and merge request, but I want to make sure I understand the problem correctly. I would first try to fix the flush method in a way that is similar to the old code, and then attempt to provide an additional flush method that returns accumulated errors. Shall I proceed?

authors: bejayoharen dmichael

repo: mattbaird/elastigo


text:
How to use in .js files?

I am writing some jsx tags in a .js file in Atom. However, they are not auto-closing. Is this feature available yet? If so, how do I enable it/get it to work? Thanks for the help!!

Same problem here :)

I forget what I did but if memory serves, the react package takes care of this

This is still an issue for me and feels like it shouldn't be closed since there's no documented way to fix this.

I don't agree that the react package takes care of this, because the react package handles closing tags differently.
For example, the react package auto-closes, but does not add a newline, nor does it indent when I manually press return.
So in short, with the react package alone, I have to press return + tab for every tag.

source: gharchive/issue

authors: carnigian klindroos mpacer wlingke

repo: mattberkowitz/autoclose-html

license: mit

license_type: permissive

license_source: bigquery


text:
Changed _queryCache to an ordered list

Proposed changes
The compatibleArchetypes list can become out of order for QueryResults. This makes it skip over entirely valid archetype strings. Changing it from a set to a list can resolve this. Because it already uses the set _entityArchetypeCache to add new archetypes to queryCaches, there's no overhead trying to see if a new archetype has already been added to a queryCache or not.
Related issues
https://discord.com/channels/1234249974959702056/1283058858536992811
(Sorry this isn't a Github Issue, I was expecting to be committing an error myself).
Additional comments
I initially coded this in the current release, which until this worked without issue in my game.
The working version uses a different nextItem() function that in general seems to be erroring for my game, even prior to any changes. I also can't replicate the bug in the new release (but I think this could be due in part to the random erroring); however, the new version of nextItem() still relies on next(compatibleArchetypes) as a set, and it is my intention to resolve this bug and not the other things happening with queryResult.
A potential related issue with the new implementation of nextItem() would be around the removal of optimizeQueries / storage levels:
I may just be misreading the way the storage system is now working, but looking at the new implementation, this would likely happen on the entity level instead of the archetype level as entity archetypes change. E.g. an unordered list of entities {[1] = ..., [8] = ..., [95] = ..., [88] = ...} is not guaranteed to be in order.
This can be seen in use in nextItem() because it uses entityId, entityData = next(storage[currentCompatibleArchetype]). If this data is being modified, I would expect an entity to be removed from the currentCompatibleArchetype and moved to another archetype, causing the ordering next returns to sometimes change randomly.
But this is speculation, and I haven't thoroughly looked into the new storage implementation.

Another comment related to the way the new nextItem is implemented - the new version removes the previous hasSeen set to determine if the next value can be returned, so if a query changes the archetype of an entity, a new archetype could be added at the end of compatibleArchetypes, and the same entity could then be queried again. Again, I don't know if the storage[1] has some additional things going on the background I'm unaware of, but if it's just the active world's storage in general, I would expect this.

Continued in #137.
Thanks for bringing this up!

source: gharchive/pull-request

authors: TheyCallMeRyan memorycode

repo: matter-ecs/matter

license: MIT

license_source: github-api


text:
Update color of console log lines to yellow

What :computer:

Update color of console log lines to yellow

Why :hand:

So they're easier to read

Evidence :camera:
Example of era_test_node run with a transaction containing console logs:

Approved although I'm not 100% sold on using yellow is the best color as it's normally associated to warnings (like for example in the zksolc compiler).

repo: matter-labs/era-test-node


text:
[Bug]: Mattermost window keeps resizing each time after relaunch

Checks before filing an issue

[X] This issue doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[X] I have checked the issue tracker and have not found an issue that matches the one I'm filing.
[X] This issue is not a troubleshooting question. Troubleshooting questions go here: https://forum.mattermost.com/c/trouble-shoot/16.
[X] This issue is not a feature request. You can request features and make product suggestions here: https://mattermost.com/suggestions/.
[X] This issue reproduces on the most recent stable version, or the most recent prerelease version of the Mattermost Desktop App.
[X] I have read the contribution guidelines.

Mattermost Desktop Version
5.8.1
Operating System
Windows 11
Mattermost Server Version
9.8.1
Steps to reproduce
Restart Mattermost
Expected behavior
Maintains the resized window
Observed behavior
Windows goes smaller each time the app is restarted
Log Output
[2024-06-14 05:05:39.980] [error] Logger Log level set to: info
[2024-06-14 05:05:40.076] [warn]  [App.Initialize] Current working directory is C:\Windows\System32, changing into C:\Users\User\AppData\Local\Programs\mattermost-desktop
[2024-06-14 05:05:40.110] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 05:05:40.133] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 05:05:40.246] [info]  [ServerDropdownView] init
[2024-06-14 05:05:40.271] [info]  [i18nManager] Set new language pl
[2024-06-14 05:05:40.284] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 05:05:40.312] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 05:05:40.762] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 05:05:45.226] [info]  [UpdateManager] Checking for update
[2024-06-14 05:05:45.895] [info]  [UpdateManager] Found version 5.8.1 (url: 5.8.1/mattermost-desktop-setup-5.8.1-win.exe)
[2024-06-14 05:05:45.896] [info]  [UpdateManager] New version available: 5.8.1
[2024-06-14 05:05:48.070] [info]  [UpdateManager] Downloading update from 5.8.1/mattermost-desktop-setup-5.8.1-win.exe
[2024-06-14 05:05:48.075] [info]  [UpdateManager] Cached update sha512 checksum doesn't match the latest available update. New update must be downloaded. Cached: JN2VASptdWiUrL2uVTmF8v37tiKGGXogQ9XN4WEy/DbC5/axD4Zxpb+BDjuYbZqP8uiXHyATTPUVx2Wekgvf0g==, expected: WN50bN8A+5ubG+MyFpmkyJc/GFItGwVItFO3p0hrp//45KkDn0+4AXq4iC7loMr6Ab64KY2vGRFRHsY/S4O88w==. Directory for cached update will be cleaned
[2024-06-14 05:05:48.078] [info]  [UpdateManager] Download block maps (old: "https://releases.mattermost.com/desktop/5.8.0/mattermost-desktop-setup-5.8.0-win.exe.blockmap", new: https://releases.mattermost.com/desktop/5.8.1/mattermost-desktop-setup-5.8.1-win.exe.blockmap)
[2024-06-14 05:05:48.671] [info]  [UpdateManager] File has 980 changed blocks
[2024-06-14 05:05:48.679] [info]  [UpdateManager] Full: 238,004 KB, To download: 20,562.07 KB (9%)
[2024-06-14 05:05:51.066] [error] [UpdateManager] Cannot download differentially, fallback to full download: Error: sha512 checksum mismatch, expected WN50bN8A+5ubG+MyFpmkyJc/GFItGwVItFO3p0hrp//45KkDn0+4AXq4iC7loMr6Ab64KY2vGRFRHsY/S4O88w==, got x7Q0seWiAZsP7K7crh0sA3SU3O/7UVnrf6p9aXjyM+o7KTP+CmEiqLsM1/ON9SWv71hp4nJn/qh3EF5WcypLbQ==
    at t.newError (C:\Users\User\AppData\Local\Programs\mattermost-desktop\resources\app.asar\index.js:2:881006)
    at w.validate (C:\Users\User\AppData\Local\Programs\mattermost-desktop\resources\app.asar\index.js:2:877330)
    at WriteStream.<anonymous> (C:\Users\User\AppData\Local\Programs\mattermost-desktop\resources\app.asar\index.js:2:944607)
    at WriteStream.emit (node:events:514:28)
    at emitCloseNT (node:internal/streams/destroy:132:10)
    at process.processTicksAndRejections (node:internal/process/task_queues:81:21)
[2024-06-14 05:06:03.367] [info]  [UpdateManager] New version 5.8.1 has been downloaded to C:\Users\User\AppData\Local\mattermost-desktop-updater\pending\mattermost-desktop-setup-5.8.1-win.exe
[2024-06-14 05:06:03.369] [info]  [UpdateManager] Downloaded version 5.8.1
[2024-06-14 05:06:06.139] [info]  [UpdateManager] Install on explicit quitAndInstall
[2024-06-14 05:06:06.139] [info]  [UpdateManager] Install: isSilent: false, isForceRunAfter: true
[2024-06-14 05:06:06.139] [info]  [UpdateManager] Executing: C:\Users\User\AppData\Local\mattermost-desktop-updater\pending\mattermost-desktop-setup-5.8.1-win.exe with args: --updated,--force-run
[2024-06-14 05:06:11.146] [info]  [UpdateManager] Install on explicit quitAndInstall
[2024-06-14 05:06:11.146] [warn]  [UpdateManager] install call ignored: quitAndInstallCalled is set to true
[2024-06-14 05:06:11.158] [info]  [UpdateManager] Auto install update on quit
[2024-06-14 05:06:11.158] [info]  [UpdateManager] Install: isSilent: true, isForceRunAfter: false
[2024-06-14 05:06:11.158] [info]  [UpdateManager] Executing: C:\Users\User\AppData\Local\mattermost-desktop-updater\pending\mattermost-desktop-setup-5.8.1-win.exe with args: --updated,/S
[2024-06-14 05:06:18.863] [error] Logger Log level set to: info
[2024-06-14 05:06:19.026] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 05:06:19.052] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 05:06:19.178] [info]  [ServerDropdownView] init
[2024-06-14 05:06:19.222] [info]  [i18nManager] Set new language pl
[2024-06-14 05:06:19.234] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 05:06:19.264] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 05:06:19.284] [error] [App.Utils] clearAppCache TypeError: Object has been destroyed
[2024-06-14 05:06:20.270] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 05:06:24.156] [info]  [UpdateManager] Checking for update
[2024-06-14 05:06:24.751] [info]  [UpdateManager] Update for version 5.8.1 is not available (latest version: 5.8.1, downgrade is disallowed).
[2024-06-14 06:06:23.699] [info]  [UpdateManager] Checking for update
[2024-06-14 06:06:24.295] [info]  [UpdateManager] Update for version 5.8.1 is not available (latest version: 5.8.1, downgrade is disallowed).
[2024-06-14 06:23:09.160] [error] Logger Log level set to: info
[2024-06-14 06:23:09.289] [warn]  [App.Initialize] Current working directory is C:\Windows\system32, changing into C:\Users\User\AppData\Local\Programs\mattermost-desktop
[2024-06-14 06:23:09.353] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:23:09.386] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:23:09.537] [info]  [ServerDropdownView] init
[2024-06-14 06:23:09.592] [info]  [i18nManager] Set new language pl
[2024-06-14 06:23:09.605] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:23:09.638] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:23:10.090] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:23:14.517] [info]  [UpdateManager] Checking for update
[2024-06-14 06:23:15.105] [info]  [UpdateManager] Update for version 5.8.1 is not available (latest version: 5.8.1, downgrade is disallowed).
[2024-06-14 06:23:40.441] [error] Logger Log level set to: info
[2024-06-14 06:23:40.555] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:23:40.580] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:23:40.684] [info]  [ServerDropdownView] init
[2024-06-14 06:23:40.708] [info]  [i18nManager] Set new language pl
[2024-06-14 06:23:40.720] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:23:40.740] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:23:41.067] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:23:45.666] [info]  [UpdateManager] Checking for update
[2024-06-14 06:23:45.916] [info]  [UpdateManager] Update for version 5.8.1 is not available (latest version: 5.8.1, downgrade is disallowed).
[2024-06-14 06:23:58.981] [error] Logger Log level set to: info
[2024-06-14 06:23:59.124] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:23:59.148] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:23:59.241] [info]  [ServerDropdownView] init
[2024-06-14 06:23:59.279] [info]  [i18nManager] Set new language pl
[2024-06-14 06:23:59.291] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:23:59.311] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:23:59.648] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:24:04.233] [info]  [UpdateManager] Checking for update
[2024-06-14 06:24:04.788] [info]  [UpdateManager] Update for version 5.8.1 is not available (latest version: 5.8.1, downgrade is disallowed).
[2024-06-14 06:25:39.683] [error] Logger Log level set to: info
[2024-06-14 06:25:39.800] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:25:39.825] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:25:39.937] [info]  [ServerDropdownView] init
[2024-06-14 06:25:39.961] [info]  [i18nManager] Set new language pl
[2024-06-14 06:25:39.974] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:25:39.994] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:25:40.312] [info]  [App.Config] config.autostart has been configured: true
[2024-06-14 06:25:44.916] [info]  [UpdateManager] Checking for update
[2024-06-14 06:25:45.491] [info]  [UpdateManager] Update for version 5.8.1 is not available (latest version: 5.8.1, downgrade is disallowed).

Additional Information
Problem not occurred in version 5.8.0

Created ticket: https://mattermost.atlassian.net/browse/MM-58780

repo: mattermost/desktop


text:
Automated cherry pick of #2428

Cherry pick of #2428 on release-5.2.
/cc  @devinbinnie
NONE

The file .circleci/config.yml is in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers

authors: mattermod mattermost-build


text:
Translations update from Mattermost Weblate

Translations update from Mattermost Weblate for mattermost-languages-work-in-progress/mattermost-desktop-wip.
Current translation status:

Hello @weblate,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

authors: mattermost-build weblate


text:
Rename setting to enable tray icon

"Show tray icon" instead of "Show icon on menu bar"

:+1:

Closing in favor of #324

Thanks @bwaldvogel for the initial pull request, hope to see you around!

authors: bwaldvogel jasonblais ldziedziul


text:
Request for Documentation: Usage of config.json file when server configuration has been migrated to the database

Mattermost user jason.blais from https://community-release.mattermost.com has requested the following be documented:
Question: What is the expected behavior for the config.json when you've migrated it to the database? Will the file be kept in sync with the DB? If the config file is deleted, should it get re-created with default values?

Answer: The file is obsolete and will be completely ignored by the server.

See the original post here.
This issue was generated from Mattermost using the Doc Up plugin.

Comprehensive product documentation for migrating server configuration to the database is available on docs.mattermost.com. Closing.

authors: cwarnermm matterdoc

repo: mattermost/docs


text:
Update config.yml

This is a test - please ignore. It will be closed shortly.

Thanks @ndavisontest for the pull request!
Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

The file .circleci/config.yml is in the blacklist and should not be modified from external contributors, please if you are part of the Mattermost Org submit this PR in the upstream.
/cc @mattermost/core-security @mattermost/core-build-engineers

authors: mattermod ndavisontest

repo: mattermost/mattermost-helm


text:
Feature/custom mounts

Summary

This adds the possibility to add custom mounts inside the Daemonset.
For example for custom CA's.
Ticket Link

Fixes https://github.com/mattermost/mattermost-helm/issues/375

Hello @patatman,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@phoinixgrr I've added a NL to the EOF, is this what you ment?

@phoinixgrr I've added a NL to the EOF, is this what you ment?

Nice 👍
Thank you @patatman
I'am also referring to the two NL characters introduced in the daemonset template, under volumeMounts and volumes directives.

Ah right! I didn't spot that my bad.
Not sure how to trim those? Do you have any idea?
I'll go and try some things and try to make them go away.

@phoinixgrr Already fixed it, looks like I needed to remove the NL after the yaml template

Triggering tests

cc: @spirosoik  @stylianosrigas  @stafot  @angeloskyratzakos
Any objections merging this?

Merged
@patatman thanks for your contribution 🎖 🏅 🥇

authors: mattermod patatman phoinixgrr


text:
Build faild Android v2 :app:createBundleReleaseJsAndAssets

use Node 18 and npm 8.5.5

I'm using node 18.7.0 and npm 8.18.0 without issue
while building

and it ends up building just fine

Have you made any changes to the code?

I'm using node 18.7.0 and npm 8.18.0 without issue
while building
and it ends up building just fine
Have you made any changes to the code?

i clone origin form master and run it. I don't changes any code

I'm using node 18.7.0 and npm 8.18.0 without issue
while building
and it ends up building just fine
Have you made any changes to the code?

i update versioning_android. and nothing

authors: enahum vigstudio

repo: mattermost/mattermost-mobile


text:
Automated cherry pick of #5511

Cherry pick of #5511 on release-1.45.
/cc  @enahum

/release-note-none

authors: enahum mattermost-build


text:
Bug bounty test - PLEASE DO NOT APPROVE. qxbkci

Bug bounty test - PLEASE DO NOT APPROVE. qxbkci

Hello @pastramahodu,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

authors: mattermost-build pastramahodu

repo: mattermost/mattermost-push-proxy


text:
Multiple Fixes

Summary

Make getChannel selector to complete direct channel info
markChannelAsRead if channel and member are in the store
Mark channel as unread if post is from webhook

Looks good, but you've got a build failure

authors: enahum jwilander

repo: mattermost/mattermost-redux


text:
Translations update from Mattermost Weblate

Translations update from Mattermost Weblate for mattermost-languages-shipped/mattermost-webapp.
Current translation status:

Hello @weblate,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

/release-note-none

authors: m1lt0n mattermod weblate

repo: mattermost/mattermost-webapp


text:
MM-35726 Dependency updates

Nothing super big in terms of upgrades except I added a file that tracks upgrades using npm-upgrade. That file includes references to the ticket numbers for the bigger upgrades that we've been skipping.
Most of the individual line changes are snapshots changes caused by react-intl renaming some of their components internally.
Ticket Link
https://mattermost.atlassian.net/browse/MM-35726
Release Note
NONE

They're being ignored since I wanted to skip packages I knew we weren't upgrading when I was running npm-upgrade. As far as I know, that's the only way to tag them with their corresponding upgrade tickets in a convenient way.

I downgraded Storybook itself. I tried some other things to fix it, but those weren't working, and I don't understand enough about it too get replace addon-knobs. It sounds like it's just deprecated at this point and should continue working until Storybook 7, so I don't know what the issue is other than that.
As for those other ones, I'm not going to bother keeping the minor versions bumped after the initial one I did last week. We'll grab those next dependency update.

@jgilliam17 There's nothing particular to test here outside of a regular smoke test. The only notable things to test outside of what CI covers is that the libraries for syntax highlighting and searching in the system console were updated, and I've tested both of those locally already.

Thanks @hmhealey
I checked PR E2E failures  against master run and there is one issue that reproduces manually on the test server

Searching for individual plugins in the system console search box, more specifically "antivirus" can't be found even though it is installed and visible on the LHS.

@jgilliam17 I ended up downgrading the library we're using for searching in the System Console back to its previous version since I wasn't able to figure out how to get the new one to work. It's ready for another review now.


text:
Report Svelte errors

Think I'm forgetting to surface Svelte errors—just get "could not prerender page" when I'm pretty sure Svelte would say something more specific.

Also consider that when there's a compilation error in Rollup for a Cayo component, these don't get surfaced for some reason—only if you're prerendering the component (not a Cayo) does it show the Rollup message.

repo: matthew-ia/cayo


text:
Update README.md

Spelling 😉

cheers!

authors: JacobBennett matthewtrask

repo: matthewtrask/vue-laravel-forms


text:
Addresses #64, ANTIALIAS deprecated in Pillow 10

Apparently ANTIALIAS and other constants were actually deprecated in Pillow 10 despite the warnings having been removed sometime around v9.4

It looks like PR #66 is the preferred method here, please review that PR instead.

repo: matthewwithanm/pilkit


text:
Allow passing the base URL dynamically in Elm.

Fixes #18.

@mattjbray I've finally tested this, it works. Thank you!

authors: domenkozar mattjbray

repo: mattjbray/servant-elm


text:
Drag with page zoomed

Hi,
First would like to thank you guys for the awesome work put on this draggable-droppable.
I would like to ask if you guys can think anyway to overcome an issue i'm having, basically I have a component similar to a page, where you can add controls inside. Then you should be able to move the controls around. In that component I have a zoom, where the user can zoom in and zoom out, what the zoom is doing is set the css property zoom using percentage. When the page is zoomed and i drag and move, the mouse is more sensitive so the control moves fast and lost the mouse cursor, If I move really slow it kinda works ok, but if you try to move in a normal speed, it really gets hard to use it.
For you be able to reproduce, just open your demo https://mattlewis92.github.io/angular-draggable-droppable/demo/ and add a css zoom: 200% to the div with id="demo".

I found a similar issue using Jquery Draggable, the guy manage to fix it. https://stackoverflow.com/questions/2930092/jquery-draggable-with-zoom-problem
Please let me know,
Thanks a lot.
Abner

One way to get around this could be to set ghostDragEnabled=[false] and then implement the logic yourself for moving the element around that respects the zoom property.


text:
Incorrect calendar unit comparison.

Calendar unit comparison for weekOfYear with year, month is uncorrected
now.
Current ordered is ascending when compare second vs minute , day,
month, year.
But it’s descending for weekOfYear vs year, month. It’s not OK.

See PR #162.

Fixed by #162.

authors: sebastianludwig trunglee yas375

repo: mattt/FormatterKit


text:
🛑 API appointment - PROD is down

In fff3c15, API appointment - PROD (https://appointment.prod.api.eflow.com.ar/swagger) was down:

HTTP code: 0
Response time: 0 ms

Resolved: API appointment - PROD is back up in 595923a after 16 hours, 24 minutes.

repo: mauribesson/upptime


text:
zlib: use nicer patch to install cmake config

This cmake patch seems nicer because it also installs the cmake config.

Appveyor runs through fine and the unit tests pass and then it exits with not-null :man_shrugging:?

Appveyor runs through fine and the unit tests pass and then it exits with not-null man_shrugging?

Seems to fail consistently :thinking:

authors: JonasVautherin julianoes

repo: mavlink/MAVSDK


text:
libaums docs not working

Hey,
any idea why this is not working?
https://www.javadoc.io/doc/me.jahnen/libaums/0.7.7/index.html
artifacts are here https://bintray.com/beta/#/magnusja/maven/libaums/0.7.7?tab=files

It looks like the javadoc.jar was uploaded twice and javadoc.io is only the first one.
I have reindexed the jar manually.

authors: magnusja maxcellent


text:
User Extension causes 500 Internal Server Error

I'm seeing this trace while trying to use the User extension as described in the docs: tower_http::trace::on_failure: response failed classification=Status code: 500 Internal Server Error
I believe that auth_cx.current_user should only be inserted if it exists. I can create a pull request if this solution makes sense.

I’m not following here. Feel free to open a PR if it’ll help clarify the issue.

I created #70 which touches upon this issue. Instead of replacing the Option extension with a User extension like I originally proposed, I added a third extension at the cost of another clone. I'm not sure what the best solution is here but this is an option.

repo: maxcountryman/axum-login


text:
FYI: borgmatic bug affecting exported

Just for your information.
1.9.1 and potentially also 1.9.0 of borgmatic won't work with the exporter due https://projects.torsion.org/borgmatic-collective/borgmatic/issues/939, which is actually already fixed and is waiting to be released.

Thanks for letting me know. I see that 1.9.2 was released shortly after.

authors: maxim-mityutko spali

repo: maxim-mityutko/borgmatic-exporter


text:
Is it able to generate video longer than 15 frames?

I've tried more video frames with the pre-trained model, but the results seem abnormal.
Is this model able to generate video longer than 15 frames? Or is it just applicable for 15 frames at most?

Thank you for your interest. I think we can use something like autogressive to make it generate longer videos. Increasing the length of the video directly while reasoning will result in a mismatch with the training Settings.

maybe helpful - https://arxiv.org/html/2405.11473v1

authors: cc13qq johndpope maxin-cn

repo: maxin-cn/Cinemo


text:
TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/29260

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/29466

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/29598

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/29676

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/30332

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/30592

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/30675

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/31692

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/35296

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/39748

repo: maxkapur/DeferredAcceptance


text:
🛑 Transport Canada / Transports Canada is down

In f8f12c0, Transport Canada / Transports Canada (https://www.tc.gc.ca/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Transport Canada / Transports Canada is back up in ba8c2be after 8 minutes.

repo: maxneuvians/status-statut


text:
Requesting to add podspec for protobuf-c 1.3

Hello Maxi,
Could you please add an updated podpsec for protobuf-c 1.3. So that i can be integrated in  https://cocoapods.org/pods/protobuf-c ? This could be really helpful as protobuf-c 1.3 comes with Google protobuf 3.x, which has various issues fixed.

Sure, just send a pull request.

repo: maxsz/protobuf-c


text:
Fix CI

Hey @maxtheman, I'm sorry you had to struggle with the CI so much. Turns out the issue was with the requirements of the package.

nbdev expects the requirements to be inside settings.ini.
I've moved your requirements from requirements.txt to settings.ini.
I've kept the requirements.txt around in case you turn on dependabot.
I've also cleared the egg-info and checkpoints folder which don't need to be pushed.
And I've updated your .gitignore as well.

All in all, your project is ready to go!

@deven367 Really above and beyond, thank you. Merging now.

repo: maxtheman/proofs


text:
test(bdd): move the openapi_client package into openapi

test(bdd): move the openapi_client package into openapi
use the openapi client directly so python can determine we're using the
correct type and avoids having to specify discard_unknown_keys=true.

fix(test): check if replica is deleted by checking the spec

fix(bdd): use actual openapi Topology types

bors merge

repo: mayadata-io/mayastor-control-plane


text:
deepsea-ai monitor command throws error

I am running deepsea-ai monitor command on Docker image on mbari system DORIS. When I run command, it reports an error in one file processing, then fatally aborts. See log file below
error report deepsea-ai monitor command March 26 2024 Doris.txt

I was able to clear the error by purging the deadletter queue. I saved info on the item in the deadletter queue so we can debug that.

ecsprocess monitor launched from Doris also reports error in db
2024-03-27 18:43:13,200 ERROR Unable to fetch job id from deepsea_ai database: HTTPConnectionPool(host='localhost', port=4000): Max retries exceeded with url: /graphql (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7fbe5833ef10>: Failed to establish a new connection: [Errno 111] Connection refused'))
2024-03-27 18:43:13,200 INFO sqlalchemy.engine.Engine ROLLBACK

repo: mbari-org/deepsea-ai


text:
[QUESTION] How use Index of Array?

I have data:
Shop1
{
"_id" : 1,
"products":
[
{
"name":phone,
"params":["black","small","Germany"]
},
{
"name":tablet
"params":["blue","big","China"]
},
{
"name":apple
"params":["red","big","Sweet"]
}
]
}
Shop2
{
"_id" : 2,
"products":
[
{
"name":phone,
"params":["green","small","France"]
},
{
"name":book
"params":["red","big","China"]
},
{
"name":pumpkin
"params":["yellow","big","Sweet"]
}
]
}
I made index: col.EnsureIndex("Index", "$.products[].params"); It look like: MAP($.products[]=>@.params).
How can i use index in query?
Select $ From DBname WHERE $.products[*].params ANY Like 'red' => return 2 results but
Select $ From DBname WHERE Index ANY Like 'red' => return 0 result

@tivial19 It is not possible to use indexes explicitly. They are used internally to speed up certain queries.

repo: mbdavid/LiteDB


text:
Support for some Angular's event directives

The directive should support some Angular's event directives, such as ng-blur and ng-focus.

This issue was selected to be spring-cleaned by a script. More information can be found here.
If anyone thinks this was a mistake and this issue should be reopened, please leave a message below explaining why. Before doing so, please consider reading the CONTRIBUTING file.

repo: mbenford/ngTagsInput


text:
POI & multi markets

Hi Mo
Do you have a sports-data or a POI example to share?

Will POI get merged into the main branch or kept separate?
any plans to deal with multi markets or event files?

Cheers

Apologies for the late response:

The intention is to ultimately merge the POI with the main branch. The issue with this and indeed any other piece of functionality related to the dashboard is that there are all kinds of different directions it can be taken in and at the moment it's pretty much exclusively my own requirements driving this. If you have any specific feedback on the POI - even if it's just to say it's been really useful to you - that would be helpful
Again, I haven't really had any need to look at multiple markets simultaneously but I can see how this might be useful. Can you give me your thoughts on how you might want to visualise them?

authors: ggoaat mberk

repo: mberk/betfairviz


text:
Removal of Spanish translation repository

Hello. I'm the one who translated the content of this repository into Spanish (see PR #10); for personal reasons, I deleted the fork I made where I translated the content. The Spanish link in the Translations section now points to a 404 page, so I wanted to make you know about this. Nonetheless, I saved the translation in web.archive.org, if you want to keep it and upload it in another branch in this repository, for example (link here). Sorry for the inconvenient.

Hello @JoseDeFreitas Sure, I remember you! That was a pleasure for me. Thank you so much for your help & message here.
I will take care of it. Best wishes

Updated. 🎉 Once again, thank you so much for your contributions here! ✨

Hello, @mbiesiad. I didn't think of adding the link to the web.archive.org page, great idea! Thank you and good luck with everything :smile:.

authors: JoseDeFreitas mbiesiad

repo: mbiesiad/awesome-translations


text:
plugins: Revert changes from #20

During the course of developing #20, I'd temporarily eliminated _GO_PLUGINS_PATHS, which required changes to libexec/plugins. Though I'd restored _GO_PLUGINS_PATHS in the same pull request, I'd forgotten to restore the libexec/plugins implementation.

Coverage decreased (-0.01%) to 95.063% when pulling 33c54b6495032dc8c13fc92f643bce3f30de2b67 on plugins into ce201555fb14885bd314655111c4333f0a4dc5f7 on master.

authors: coveralls mbland

repo: mbland/go-script-bash

license: ISC


text:
Use multiple tags to select services

Does this item only support one label for filtering? I want to use multiple tags to select services (for example: tags [] string), just like the official ServiceMultipleTags() method, but this project does not seem to support it.

Good point. I will mark it as good first issue. If nobody come i will look into it myself.
ETA is end of April.

authors: mbobakov tianheyi

repo: mbobakov/grpc-consul-resolver


text:
'jsdom' breaks on npm install on 3.5.x version

I cloned the master repo which seems to be on '3.5.6' version, when I tried installing node dependencies using npm install it is failing throwing this error: npm install console log.
But if I install jsdom manually using npm install jsdom@latest it's getting installed properly. So if there are no restriction of using the specific jsdom can we upgrade to jsdom's latest version or as you mentioned on other issues can remove jsdom dependency completely but for time being if upgrading to latest version is possible can we just update package.json file accordingly?

It looks like you’re trying to install an older version of D3, specifically, 3.4.1.
In the latest version, JSDOM has been demoted to a devDependency rather than a dependency, which typically means you don’t have to install JSDOM and all its dependencies (the most error-prone of which is Contextify, since it requires compiling native code) if you only depend on D3.
The install should look like this:
$ npm install d3
d3@3.5.6 node_modules/d3
$

The JSDOM dependency is declared as "3", which means we depend on the latest version of JSDOM that has the major version 3. Incrementing the major version is not backwards-compatible, so that’s the most aggressive we should be about using the latest version of JSDOM.
We could upgrade to a more recent version of JSDOM, but that would require everyone to use a newer version of Node (4+). I’m not sure that’s a good idea.
But at any rate, the issue here appears to be you are installing an old version of D3, and assuming you switch to a more recent version, you shouldn’t need to install any version of JSDOM.

@mbostock As I mentioned in my last comment I'm not installing D3 using any package manager either npm or bower, all I did was cloned master branch of D3 repo, which seems to be on 3.5.6 version precisely according to package.json file, and as you said yes the JSDOM is under the devDependency in package.json file, but when I do npm install it throws the error provided in my last comment.
PS: I'm using Node's latest version viz v4.1.2 on my Mac which is running OS X El Capitan (10.11)

Okay, sure, if you’re cloning the repo and running npm install then yes you still need JSDOM because it’s a development dependency.

So is there anything we can do? or is this all depends on JSDOM module to fix the Contextify issue?

authors: iyogeshjoshi mbostock


text:
simplification / DSL layer

Hi,
That d3 is a powerful, awesome toolkit for visualization is obvious to me by now.
As I hack around, I've noticed that I'm applying the same patterns repeatedly (to create line graphs, bar charts).
Naturally I started thinking of the idea of providing a simplified DSL/API layer for creating a pre-cooked line, bar graphs, etc.; ideally taking only my data points and using sensible defaults.
firstly, is there such a layer already?
if not, I'd love to get feedback on the idea, and how would such a DSL/API look like.
Thanks

sounds great, closing!


text:
Fix sample output path since it was moved recently.

Subsequent to #33 here is a corrected path to the sample output files

I signed it!

Hi @roest01, great catch! Sorry for the broken links in the repo as a result of moving the test files.
Looks like @googlebot is still not happy. Can you please verify that your email address in your commit matches the email address used in the CLA that you signed?

Hey @mbrukman - Thank you for the update.
I verified it once more, e-mail is fine. Beside the Corporate CLA (G Suite Group: oss@amicaldo.de / amicaldo GmbH) i have added an individual CLA now. So in hope triggering the @googlebot again with this comment it should work.
Otherwise i need a new idea what is wrong.

Looks like it's all good now. Thanks again @roest01 for the fix and the perseverance with the CLA! Appreciate your help with this.

repo: mbrukman/autogen


text:
feat: Headway Deviation and Adherence components

No Asana ticket. Testing out controlling more values at once.
@ErinLMoore Check me on this, but I think that for the "Alerts to Close" page, we actually want the threshold sliders to be maximum values rather than minimum. Does that seem right to you?

condition

Oh! I get it! Yeah, that sounds good.

authors: ErinLMoore arkadyan


text:
fixed small bugs in web interface

I tried to fix two bugs in the web interface code.

In keypad.html, the variable isConnected is set to true after connection, but when closing the connection, isConnected was still set to true enabling sending commands when the connection is closed.
In simpledesk.js, after resetting an universe, the current page was set to 1, but the faders weren't changed and the page number wasn't changed either.

Makes sense. Thanks for fixing :+1:

Coverage: 28.078%. Remained the same when pulling f0e98d8c0ef8502fc2ac5572179b57d04da061eb on arneBersch:master into 2f3a145d295fd6728be0ea0146b7a7f225fbfe42 on mcallegari:master.

authors: arneBersch coveralls mcallegari

repo: mcallegari/qlcplus


text:
remove sys

sys has been deprecated and it is also is not used

Also fixed in https://github.com/mcavage/node-asn1/pull/21

@pfmooney can this PR be merged?

@peecky : Any update?

Doesn't seem like there's been any movement on this. Just checking in to see if we can get an update on this.

I have seen there is little progress on this project over the past few years.  My project, the net-snmp project, depends on this project, so I have cloned it and migrated (i.e. copied) all the outstanding issues and pull requests.
I will be releasing a new version of my version of this project under the asn1-ber namespace on npmjs.org by the end of the week which should address this particular item (I've already pushed the current code to this namespace to reserve it).
I am now tracking all changes under my own copy at asn1-ber.  Note that this is not a "fork" but a clone and fresh commit to a new repository.  I have of course retained all copyrights and attributed back the original author.
There are quite a few projects dependant on this project, and I want to make sure there is momentum on the issues and feature requests reported.

This issue has been addressed in my version of this project which has now been published to npm:
https://www.npmjs.com/package/asn1-ber

Fixed in #33.

authors: StefH Voles evanlucas melloc stephenwvickers yospeed


text:
Basic rate limiting

Here we implement a simple in-memory rate limiting scheme:

Add comma-separated list of valid auth tokens to app config
If valid token is included in request, apply no rate limiting
Otherwise, apply a 10 req/sec/instance rate limit across all anonymous clients

The rate limiting is applied per deployed instance, because it's implemented in-process using golang.org/x/time/rate.
Fixes #4.

Codecov Report

Merging #6 (a5e4945) into main (6738e51) will decrease coverage by 0.64%.
The diff coverage is 93.54%.

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   97.31%   96.66%   -0.65%
==========================================
  Files           4        5       +1
  Lines         149      180      +31
==========================================
+ Hits          145      174      +29
- Misses          2        3       +1
- Partials        2        3       +1

Impacted Files
Coverage Δ

pkg/httphandler/middleware/middleware.go
96.07% <0.00%> (-3.93%)
:arrow_down:

pkg/httphandler/middleware/ratelimiter.go
100.00% <100.00%> (ø)

authors: codecov-commenter mccutchen

repo: mccutchen/urlresolverapi


text:
🛑 ChatGenie Client API is down

In 4b33751, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in f49e458.


text:
🛑 ChatGenie Client API is down

In 69d831c, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in e73c42f.


text:
🛑 ChatGenie Client API is down

In 84cfd0c, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in 89f3fac.


text:
🛑 ChatGenie Client API is down

In 451da98, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in 0ce4b89.


text:
🛑 ChatGenie Client API is down

In 5f10994, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in 9552d21.


text:
🛑 ChatGenie Client API is down

In fdbd7ca, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in 0a9d583.


text:
🛑 ChatGenie Client API is down

In c5a9a26, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in b48669c.


text:
🛑 ChatGenie Client API is down

In 1998fe3, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in 15d0e4f after 18 minutes.


text:
🛑 ChatGenie Client API is down

In e95d586, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in 62b423f after 22 minutes.


text:
🛑 ChatGenie Client API is down

In e1b1b52, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in ec8b00c after 57 minutes.


text:
🛑 ChatGenie Client API is down

In 61e0679, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in eb6e6e7 after 9 minutes.


text:
🛑 ChatGenie Client API is down

In fb97b5a, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in c8cb2dc after 42 minutes.


text:
🛑 ChatGenie Client API is down

In cdbae21, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in f7cf513.


text:
🛑 ChatGenie Client API is down

In 4a43887, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in 0aeb0c4.


text:
🛑 ChatGenie Client API is down

In 451bb3a, ChatGenie Client API ($CHATGENIE_CLIENT_API) was down:

HTTP code: 0
Response time: 0 ms

Resolved: ChatGenie Client API is back up in c6fc543.


text:
🛑 GitHub Mirror is down

In 96350ca, GitHub Mirror (https://gh.chapro.xyz) was down:

HTTP code: 500
Response time: 111 ms

Resolved: GitHub Mirror is back up in 41a3e40 after 5 minutes.

repo: mchaNetwork/status


text:
🛑 GitHub Mirror is down

In 1182c41, GitHub Mirror (https://gh.chapro.xyz) was down:

HTTP code: 500
Response time: 249 ms

Resolved: GitHub Mirror is back up in a47b843 after 5 minutes.


text:
🛑 GitHub Mirror is down

In cf6e14c, GitHub Mirror (https://gh.chapro.xyz) was down:

HTTP code: 500
Response time: 84 ms

Resolved: GitHub Mirror is back up in bd60068 after 5 minutes.


text:
🛑 GitHub Mirror is down

In 1c83caa, GitHub Mirror (https://gh.chapro.xyz) was down:

HTTP code: 500
Response time: 78 ms

Resolved: GitHub Mirror is back up in 71f17d0 after 19 minutes.


text:
Compute Service Account Needs artifactregistry.reader Role

When following the README sequentially I received the following error in the hello pod logs after running the first CB trigger:
Cannot pull image 'us-west1-docker.pkg.dev/cicd-demo-375021/cloudbuild-demo/hello@sha256:77040bddb0a9c4e9160915d3162143a5d9b2f3e21ffe2582d7e3cb1f0757ff23' from the registry.

I was able to fix the issue but running the following command and triggering the build again:
gcloud projects add-iam-policy-binding PROJECT_ID \
    --member=serviceAccount:$(gcloud projects describe PROJECT_ID \
    --format="value(projectNumber)")-compute@developer.gserviceaccount.com \
    --role="roles/artifactregistry.reader"

That's due to the demo clusters being configured with the default GKE (GCE) service account. I'll add this for now but switch the cluster creation command to use a custom service account

repo: mchmarny/cloudbuild-demo


text:
Improve layouts for small devices

Description

Improve mobile layouts for xs and s devices
Automatically collapse left-side if small devices are detected
Remove grid and switch to flex if small devices are detected
Zoom out of screen to scale Plotly charts properly
Declutter charts in demo app

Remove redundant color legends (e.g. if colors are clear from axis labels already)
Resize colorbars and move titles to side
Shorten chart titles
Set automargin for y and x-axes
Remove facets as it was barely visible
Turn on pagination for table
Remove selected charts that didn't add any value to the dashboard (but we've initially added it in to show certain
features which we now have the feature demo dashboard for)

Note: This is only meant as a quick fix and should by no means be our fully fledged mobile solution. For this we need to refactor our CSS code and components to be fully mobile compatible, which might be simplified if we switch to Bootstrap.
Screenshot
After:
This is how it looks like using the dev-tools now e.g. for an Iphone:

Before:

Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
I have not referenced individuals, products or companies in any commits, directly or indirectly.
I have not added data or restricted code in any commits, directly or indirectly.

Yay! 🥳 Yes, I also feel this was one of my most productive learning time investments 😄
I fully agree with you. It's also on my list to implement the hamburger menu if we go for the Bootstrap approach 👍
I was hoping you would say that 🤣 I will delete the yaml example with pleasure, haha. I do not want to keep it updated, mainly because we will revamp the demo dashboard again soon and archive this example.

repo: mckinsey/vizro


text:
Fix some unicode bugs on Python 2.

To reproduce some issues reported by @ppentchev.

@ppentchev I think your patch only makes sense if we also do this:
https://github.com/mcmtroffaes/pathlib2/pull/63/commits/9ad08c769d75debded043ded7f5e0fa24351561a
What test case triggered your original issue?

Hi,
Sorry, I pushed one additional commit into my branch before I saw that you closed #62 - take a look at https://github.com/ppentchev/pathlib2/commit/7899f601677f9712aec3e993bea5d3d9d2b3d8c3 to see my test case. Of course, it is entirely possible that it is not complete or comprehensive, and it is absolutely, 100% possible that I do not yet fully understand the internal workings of pathlib2 - I completely defer to you on that.
Still, the test_unicode.py file that I added in the above-mentioned commit seems to work without your _py2_fsencode() changes, but, again, it is entirely possible that I've missed something... come to think of it, yes, it's kind of obvious that I did not really test with characters that are outside the US-ASCII range!  Aaaaaaargh! :) Thanks A LOT for actually taking the time to come up with a real test, not my lame excuse for one! :)
G'luck,
Peter

To clarify my comment above: it's true that I did not really test with characters outside the US-ASCII range. The reasons for that are twofold:

this issue came to my attention when I was trying to make a somewhat-comprehensive test case for mypy's typeshed stubs for pathlib2, and all I tried to do was pass Unicode strings as parameters to the pathlib2 methods so that mypy would complain and I would fix the stubs that it complained about
I had the insanely unwise idea to try and finish this after midnight on a Sunday night... so, yeah, my thinking may not have been entirely straight at some point

So..... yeah, once again, thanks a lot for 1. agreeing to reopen pathlib2, 2. taking the time to look into my code, and 3. actually going in and making a better fix yourself before I could get around to providing you with my test case!
G'luck,
Peter

Lovely, thanks for sharing! It's now part of the test suite. I'll run a few more tests and then cut a release on pypi.

BTW, the mypy --py2 problems may be fixed by providing your own *.pyi file, e.g. the one that was accepted into the typeshed project earlier today exactly with the Unicode fixes: see https://github.com/python/typeshed/pull/5727
Of course, if you decide that you do not want to make such a change - start carrying type definitions - right now, that's all right, too.

Ah... and I just realized that carrying your own *.pyi file would help for the public API, but not for the internal functions - for those, you may want to add type hints by hand..... which might very well not be something you want to do right now.

Sure, for now, I'm happy for typeshed to carry these. And many thanks for adding type checking to the library! ❤

authors: mcmtroffaes ppentchev


text:
Condition extractor

Summary
Adds a new helper function to get full entries of bundles.
New behavior
None
Code changes
New function
Testing guidance
This is really to support the PRs in the other two repos. Using this along with those branches should successfully bundle Conditions.

Bar that small nitpick, this looks great! Nice work, and a super useful helper 👍

repo: mcode/mcode-extraction-framework


text:
Invalid char in header strategy

Hi :wave: !
I have a use case in which I have to check for invalid characters in headers (like control characters). Node already does this by default, on both server and client. I was wondering what strategy you would suggest for undici. Should this be implemented in userland space? Should undici do it?

I think tjats doneringar for userland.

Makes sense, thank you.

authors: dnlup ronag

repo: mcollina/undici


text:
One more tool to compare

Hi. I really understand the value of creating your personal tool (it is fun!), just wanted to provide some heads up regarding existing alternatives in addition to documented ones in https://github.com/md2conf/md2conf/blob/master/docs/comparison_with_other_tools.md.
You can take a look at https://github.com/zeldigas/text2confl.
I think, that it has a lot in common with your project - frustration about confluence-publisher asciidoc only and rigid goals of project in general and so on.
Of course it is up to you, feel free to ignore this if you don't see a value.

Zdorovo, Dmitry! :)
Thanks for pointing me on your tool zeldigas/text2confl.
I added zeldigas/text2confl to comparison table.
It's very interesting to see how 2 different tools with similar objectives developed independently in the same time =)
It's very likely that if I waited for couple of years in 2021 that decision to start my project was negative I would prefer to contribute to the text2confl. From the other point, the developing of own tool is really fun. The idea to create own tool become to me in 2018. I started from creating test infrastructure in this commit https://github.com/md2conf/atlassian-sdk-confluence/commit/1fc012687a12af52ed77558fe7a5a6fe804c782f.
Nice to meet you. Watching you project now =)
Regards,
Anton.

Даже не посмотрел на профиль когда писал тикет :). Спасибо что добавили!
А я начинал с попыток улучшений confluence publisher, но там мейнтейнер себе на уме и ничего не смержили. Поэтому решился на свою тулу, с параллельной загрузкой и маркдауном).
Успехов!

Plantuml с точки зрения кода внешняя зависимостью В докер она попадает просто потому что большинству пользователей нужно что-то готовое а не база по которой они соберут себе что-то :). Но да, тут видение может расходиться.

FYI, added more parameters in comparison.
https://github.com/md2conf/md2conf/blob/master/docs/comparison_with_other_tools.md

authors: qwazer zeldigas


text:
Footer Icons Not Displaying Hover Effect

Description
The footer icons are not displaying the expected hover effect when the user hovers over them. Typically, hover effects are used to enhance user interaction by changing the style (such as color, size, shadow, or transition) of icons when a cursor moves over them. However, in this case, no visual change occurs, indicating a possible issue with the CSS or icon setup.
Screenshots

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

/assign

@mdazfar2 i created the issue so please assign to me

Hey @RishabxBhardwaj and @Charul00, we have a hover effect that we want, and it works well according to the website. Can you guys please look at any other good issues/bugs or features that I'm happy to assign to you?

Actually we're getting very close to 100 stars!  Would you mind giving our repository a star?  ⭐


text:
Feat:Adding hover effect to mode changing button

Describe the feature
I will add a hover effect to mode changing button
Add ScreenShots
https://github.com/mdazfar2/HelpOps-Hub/assets/118350936/42d4071d-2ada-4673-a5da-b294a1f97fcd
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[ ] I'm a VSoC'24 contributor
[X] I want to work on this issue

@Ayushmaanagarwal1211


text:
Feat: CI/CD Pipelines: Automating Software Delivery

Describe the feature
CI/CD Pipelines: Automating Software Delivery
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[ ] I'm a VSoC'24 contributor
[X] I want to work on this issue

@arunimaChintu I have been observing for some time. You are raising issues again and again. That's not a good way to work on open source. Why don't you raise and describe everything in a single issue?


text:
FR: Bulk insert fields action available via dedicated command

Version 0.3.3 introduced a fantastic new feature, bulk insert fields action.
As noted in release comments, this action could be called upon via note context menu or metadata menu button.
My feature request is:
Create command for bulk insert fields action.
Commands in Obsidian are typically available:

in Command Palette;
via Hotkeys;
via API (and then e.g. launched by URL through Advanced URI plugin).

I am not sure but I think once a command is assigned, all 3 options are immediately available.
If not, making all 3 triggers possible would be great.
(I first introduced this idea in #146.)

👏👏👏

Shipped in 0.3.4

Mhm, @mdelobelle, nothing really changed for me with the new release.
"Insert missing fields" does nothing.
But anyway, my FR wasnt specifically about missing fields, what I meant is to launch the same fields-bulk-edit menu which could also be triggered by the icon (in e.g. tab bar).

authors: kalmir mdelobelle

repo: mdelobelle/metadatamenu


text:
[P1] Console updates for Firefox 67 (Irene)

[x] Dynamic import in the Console (67)
The user can import existing modules into the current page (using import)
Might be good for testing

[x] Fix link to debugger (67)
Better handling to missing sources
Clicking the source link in the Console panel navigates to the Debugger (if debugger knows the file) or it’s using view-source:// url

[x] Allow to copy link location (67)
The user has new context menu item “Copy Link Location”
Will be improved in 68 (so, it could work for learn link too, bug reported)

[x] console.timeLog & console.timeEnd are different now
The user can have more timers
timeLog & timeEnd have different output in the Console

[x] Opening link should be better
Following the same patterns/principles as Firefox (when the user clicks any link)

[x] Better accessibility with added role=main on the console output container
Tabbing goes directly to the Console output and messages (for screen-readers)

[x] when clearing the console, we clear the error messages cache
This relates to errors that happened before the user opens the Toolbox (they were repeatedly appearing again after reopeing the Toolbox)
Just quality thing

[x] Clear button added to the filter input
There is a new icon in the Filter output (at the top of the panel) allowing the user to clear its content (only visible when there is something in the Filter output)
We could have learn-more icon in the Filter output too (just like the Net monitor, bug reported)

Acceptance criteria

[x] Dynamic import in the Console (67)
[x] Fix link to debugger (67)
[ ] New material reviewed
[x] All new Console features added to the Firefox 67 release notes.

For filtering text, I added an image and description to the Filtering by text section of the Console messages page.

Moved to next sprint. About 0.25 points left.

I will update after the standup with links to the changes made.

I will update after the standup with links to the changes made.

@irenesmith Do you have those links?

Some of the information only needed to go into the release notes as they are improvements, not changes to the old behavior. These include:

Fix link to debugger (67)
Opening link should be better
Better accessibility with added role=main

The following items have new or updated sections in the console documentation:

Copy link location - New content shows the context menu and describes the new menu item "Copy link location".

timeLog and timeEnd are different - The two event descriptions use the same example: timeLog, timeEnd

Clearing the console

Clear button added to filter textbox

Thanks @irenesmith !

authors: irenesmith jmswisher

repo: mdn/sprints


text:
[JS] Arrays, Fx 71 tasks

Trello
https://trello.com/c/yGbpmda3/216-js-arrays-fx-71
Acceptance criteria

[x] Disable Array generics in Nightly (just needs setting to DDC?)

[x] Remove Array generics

Done! this was just the removal of array generics.


text:
fix missized vec

This PR changes the way data is passed back from C to rust, primarily to fix a heap overflow. The out vec is currently allocated with capacity = the number of tokens to predict, however the data copied into out is the full detokenized string, which always has length > the number of tokens. This means every predict() call with a specified token count overflows the out vec's heap allocation.

well done

authors: kallsyms msuiche


text:
Hypercat compliance

The CM should use the /cat endpoint on the arbiter to get the root catalogue. This can then be walked to find all the datastore catalogues which hold sensors and metadata.

For information,
Once the CM and arbiter are started the root Hypercat catalogue is available through the CM proxy via this url: http://127.0.0.1:8989/databox-arbiter/cat
example output:
  {
      "catalogue-metadata": [{
          "rel": "urn:X-hypercat:rels:isContentType",
          "val": "application/vnd.hypercat.catalogue+json"
      }, {
          "rel": "urn:X-hypercat:rels:hasDescription:en",
          "val": "Databox Root Catalogue"
      }, {
          "rel": "urn:X-hypercat:rels:hasHomepage",
          "val": "http://www.databoxproject.uk/"
      }, {
          "rel": "urn:X-hypercat:rels:containsContentType",
          "val": "application/vnd.hypercat.catalogue+json"
      }, {
          "rel": "urn:Xhypercat:rels:supportsSearch",
          "val": "urn:X-hypercat:search:simple"
      }],
      "items": [{
          "item-metadata": [{
              "rel": "urn:X-hypercat:rels:isContentType",
              "val": "application/vnd.hypercat.catalogue+json"
          }, {
              "rel": "urn:X-hypercat:rels:hasDescription:en",
              "val": "databox-driver-twitter-stream-databox-store-blob"
          }],
          "href": "https://databox-driver-twitter-stream-databox-store-blob:8080"
      }]
  }

The 'items' is an array of subcatalogs these can be queried directly using the databoxrequst lib or through the cm proxy:
direct url: https://databox-driver-twitter-stream-databox-store-blob:8080/cat
cm proxy url: http://127.0.0.1:8989/databox-driver-twitter-stream-databox-store-blob/cat
This will return something like this where each 'items' describes an available datasource :
  {
      "catalogue-metadata": [{
          "rel": "urn:X-hypercat:rels:isContentType",
          "val": "application/vnd.hypercat.catalogue+json"
      }, {
          "rel": "urn:X-hypercat:rels:hasDescription:en",
          "val": "Databox Datasource Catalogue"
      }, {
          "rel": "urn:X-hypercat:rels:hasHomepage",
          "val": "http://www.databoxproject.uk/"
      }, {
          "rel": "urn:X-hypercat:rels:containsContentType",
          "val": "application/vnd.hypercat.catalogue+json"
      }, {
          "rel": "urn:Xhypercat:rels:supportsSearch",
          "val": "urn:X-hypercat:search:simple"
      }],
      "items": [{
          "item-metadata": [{
              "rel": "urn:X-hypercat:rels:hasDescription:en",
              "val": "Twitter user timeline data"
          }, {
              "rel": "urn:X-databox:rels:vendor",
              "val": "databox"
          }, {
              "rel": "urn:X-databox:rels:sensortype",
              "val": "twitterUserTimeLine"
          }, {
              "rel": "urn:X-databox:rels:unit",
              "val": ""
          }, {
              "rel": "urn:X-databox:rels:location",
              "val": "The Internet"
          }],
          "href": "https://databox-driver-twitter-stream-databox-store-blob:8080/twitterUserTimeLine"
      }, {
          "item-metadata": [{
              "rel": "urn:X-hypercat:rels:hasDescription:en",
              "val": "Twitter hashtag data"
          }, {
              "rel": "urn:X-databox:rels:vendor",
              "val": "databox"
          }, {
              "rel": "urn:X-databox:rels:sensortype",
              "val": "twitterHashTagStream"
          }, {
              "rel": "urn:X-databox:rels:unit",
              "val": ""
          }, {
              "rel": "urn:X-databox:rels:location",
              "val": "The Internet"
          }],
          "href": "https://databox-driver-twitter-stream-databox-store-blob:8080/twitterHashTagStream"
      }, {
          "item-metadata": [{
              "rel": "urn:X-hypercat:rels:hasDescription:en",
              "val": "Twitter users direct messages"
          }, {
              "rel": "urn:X-databox:rels:vendor",
              "val": "databox"
          }, {
              "rel": "urn:X-databox:rels:sensortype",
              "val": "twitterDirectMessage"
          }, {
              "rel": "urn:X-databox:rels:unit",
              "val": ""
          }, {
              "rel": "urn:X-databox:rels:location",
              "val": "The Internet"
          }],
          "href": "https://databox-driver-twitter-stream-databox-store-blob:8080/twitterDirectMessage"
      }, {
          "item-metadata": [{
              "rel": "urn:X-hypercat:rels:hasDescription:en",
              "val": "Twitter users retweets"
          }, {
              "rel": "urn:X-databox:rels:vendor",
              "val": "databox"
          }, {
              "rel": "urn:X-databox:rels:sensortype",
              "val": "twitterRetweet"
          }, {
              "rel": "urn:X-databox:rels:unit",
              "val": ""
          }, {
              "rel": "urn:X-databox:rels:location",
              "val": "The Internet"
          }],
          "href": "https://databox-driver-twitter-stream-databox-store-blob:8080/twitterRetweet"
      }, {
          "item-metadata": [{
              "rel": "urn:X-hypercat:rels:hasDescription:en",
              "val": "Twitter users favorite tweets"
          }, {
              "rel": "urn:X-databox:rels:vendor",
              "val": "databox"
          }, {
              "rel": "urn:X-databox:rels:sensortype",
              "val": "twitterFavorite"
          }, {
              "rel": "urn:X-databox:rels:unit",
              "val": ""
          }, {
              "rel": "urn:X-databox:rels:location",
              "val": "The Internet"
          }],
          "href": "https://databox-driver-twitter-stream-databox-store-blob:8080/twitterFavorite"
      }, {
          "item-metadata": [{
              "rel": "urn:X-hypercat:rels:hasDescription:en",
              "val": "n/a"
          }, {
              "rel": "urn:X-databox:rels:vendor",
              "val": "databox"
          }, {
              "rel": "urn:X-databox:rels:sensortype",
              "val": "Test"
          }, {
              "rel": "urn:X-databox:rels:unit",
              "val": "n/a"
          }, {
              "rel": "urn:X-databox:rels:location",
              "val": "Test Actuator"
          }, {
              "rel": "urn:X-databox:rels:isActuator",
              "val": true
          }],
          "href": "https://databox-driver-twitter-stream-databox-store-blob:8080/Test"
      }]
  }

Excellent! :100:
I'm sorting out https://github.com/me-box/databox-store-blob/issues/21 right now, and was writing tests for store-side hypercat endpoints. In writing validation functions, I was reading through the specs again, and although they're worded super weirdly, I think 4.3.2 and 4.5.1 are saying that item-metadata need to have urn:X-hypercat:rels:isContentType in them, with some mime type. (By default could just be text/plain, and more structured data as text/csv, up to application/json etc).
Another thing I was looking at is how the (few) existing implementers of Hypercat (mainly Thingful) name their rels.
Since that's up to the driver though, when the time comes to update https://github.com/me-box/databox-driver-twitter-stream/blob/Hypercat/src/lib/databox-datasource-helper.js#L97, I think we might as well follow the pattern and go:
urn:X-databox:rels:vendor →urn:X-databox:rels:hasVendor
urn:X-databox:rels:type →urn:X-databox:rels:hasType
urn:X-databox:rels:unit → urn:X-databox:rels:hasUnit
urn:X-databox:rels:location →urn:X-databox:rels:hasLocation
etc
Also I noticed that some people (outated libs) literally put URLs that link to some naming scheme too, like "http://www.w3.org/2003/01/geo/wgs84_pos#lat" so that's just an interesting possibility too.

All done see #24

authors: Toshbrown yousefamar

repo: me-box/databox-container-manager


text:
Text in Slide?

So, this project looks really slick and the touch behavior is super responsive - but I'm wondering if anyone has endeavored to get text in slides? Seems like this is super dependent on not having any text in there - unless someone can point me to directions to make it work properly with text inside I may have to use another tool.
If anything springs to mind that'd be great - if its simply meant for images it might be good to call that out more clearly in the readme.
Cheers!

Although the sliders are not functional due to only having one slide. I built this skin specialists website using Lory and that text is part of the slide.
http://www.lovelyskin.com/skin-specialists-omaha

Closing this issue. If you need 1:1 help I'd be happy to assist.

I also need help with this...

authors: njrfoto nstanard reidblomquist

repo: meandmax/lory


text:
404 error on Generator Repo link

On http://meanjs.org/docs.html#getting-started the link to Generator Repo is wrong. The issue is also on the 0.4.1 documentation page: http://meanjs.org/docs/0.4.x/#getting-started
The generator is still in development. See the Generator Repo for information on how to use the development version.

Thanks,
Dave

https://github.com/meanjs/mean/blob/gh-pages/_includes/docs/0.4.x/gettingstarted.html#L42

authors: codydaig dfdumaresq

repo: meanjs/mean


text:
New function - Abort

Hello,
I would like to ask you about implementation abort function so we can skip some resources to load, especially in my case images and videos.
I made this function here:
https://github.com/geometerio/playwright-elixir/blob/ab729b6f6f1f4f6d9e238d5e97598757b968c548/lib/playwright/route.ex#L14-L15
@spec abort(t(), binary()) :: :ok
  defp abort(%Route{session: session} = route, error_code \\ nil) do
    Channel.post(session, {:guid, route.guid}, :abort, %{error_ode: error_code})
  end

and implementation:
Playwright.Page.route(page_loader, "**/*", fn route, request ->
      if request.resource_type in ["image", "font"] do
        Playwright.Route.abort(route, "blockedbyclient")
      else
        Playwright.Route.continue(route)
      end
    end)

But it crash server, I very new in playwright so not sure where can be problem.
Doc for abort is here and my code is here

Hi @oliver-kriska, a quick note:
@lexun and I were taking a look at this yesterday. It turns out that the immediate fix/implementation for Route.abort/2 as you implemented is not too difficult[^1], but we discovered some fun edge-case bugs while working on that.
So, thanks for creating this GitHub issue! It's going to lead to additional improvements. I hope to get those out shortly. And, thank you @lexun for your eyes and contributions on this.
Work in progress.
[^1]: indeed, I believe that you solved it later in your fork.

authors: coreyti oliver-kriska

repo: mechanical-orchard/playwright-elixir


text:
为什么没有v1.7.5版本呢？

本来想试试这个pinyin插件，我对应的es是2.3.5， 看说明是需要v1.7.5 release支持。 不过唯独没有这个版本，咋回事？？？

@lyroge v1.7.5 我编译试过了，完全不能用（我也是醉了，居然没有提示），估计也就是为什么没有2.3.5 es版本支持。目前我用的是es5 alpha5 ，这个好用

可是我用的es2.3.5啊， 用哪个es5不行。 都升级一下？

不好意思，for es2.3.5的v1.7.5忘记打标签了，使用方式和之前版本是一样的， @ryancheung 完全不能用是什么意思？

https://github.com/medcl/elasticsearch-analysis-pinyin/releases/tag/v1.7.5

cool . thanks

@medcl 就是拼音不能分词，只有一个token。比如：你是我的小苹果，anyalize出来结果只有 nishiwodexiaopingguo 一个token

@lyroge es5 就 docker 启动时得加个参数，其他搜索功能正常

有参数可以控制
Ryan Cheung notifications@github.com于2016年8月26日 周五下午5:11写道：

@lyroge https://github.com/lyroge es5 就 docker 启动时得加个参数，其他搜索功能正常
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/medcl/elasticsearch-analysis-pinyin/issues/60#issuecomment-242675175,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD754oiimNZWOMZWGgmfwI0aAr0UYlVks5qjq3cgaJpZM4JtrFj
.

是的

authors: lyroge medcl ryancheung

repo: medcl/elasticsearch-analysis-pinyin


text:
[Windows] When the window is maximized, when playing the video in full screen, there will be margins on the four edges of the video

When the window is maximized, when playing the video in full screen, there will be margins on the four edges of the video

A bug from the window package you're using.
We filed a more neutral implementation here: https://github.com/leanflutter/window_manager/pull/367

This is the package I am using now

I linked the PR above. Or, you can use MaterialDesktopCustomButton to call fullscreen method(s) from that package.

I'll give it a try Thank you very much

package:window_manager released a new version, I think it will make our fullscreen implementation compatible out-of-the-box.
Thanks!

repo: media-kit/media-kit


text:
create fix for "focus starting point" on document navigation

the demo works in Chrome, needs to be tested in other browsers. Do not forget about a[name] targets.
might be called observe/fragment

Not required in

Firefox
Chrome, as Blink 454172 was fixed.

Broken default behavior in

WebKit 116046
Trident 1111056

jsbin.com/gimibo shows that all browsers except Chrome retain :focus on an element after tabindex was removed. Maybe this can be abused to mimic "focus navigation starting point"?


text:
Latest changes based past initial code review

Change-Id: I1aa5df07f12bdeebbd8a7b11b94ca7edfa06ac27
Signed-off-by: Roy Golan rgolan@redhat.com

@n1r1 this contains the latest changes based on the review. The last commit also added tests to cover that change.

/lgtm


text:
Bugfix: useResource makes incorrect fetch when called with resource with id

Before:
calling useResource({resourceType: 'ServiceRequest', id: '123'}) would always fetch from the server, even if the resource had been modified on the client.
After:
If calling with a resource that has been modified client-side, re-render if deepEquals fails

Coverage: 93.937% (+0.03%) from 93.905% when pulling 7a66b3c8aa5ebde87b803be9dd7cf51f38fcf430 on rahul-use-resource-modified into bc0d9e844dd5a74aaaec65b941003356f3173ef2 on main.

Summarizing my thoughts:

would always fetch from the server, even if the resource had been modified on the client

At this point, your component is managing its own state, and should use React.useState, not depend on useResource.
We could review the developer experience of useResource + useState -- for example, in cases where you want useState to start the the most fresh data, but you want to be able to manipulate the data.
Consider the setup code in <ResourceForm> (https://github.com/medplum/medplum/blob/main/packages/react/src/ResourceForm/ResourceForm.tsx#L17-L28):
  const medplum = useMedplum();
  const defaultValue = useResource(props.defaultValue);
  const [schema, setSchema] = useState<IndexedStructureDefinition | undefined>();
  const [value, setValue] = useState<Resource | undefined>();

  useEffect(() => {
    if (defaultValue) {
      setValue(JSON.parse(JSON.stringify(defaultValue)));
      medplum.requestSchema(defaultValue.resourceType).then(setSchema).catch(console.log);
    }
  }, [medplum, defaultValue]);

The problem arises when you have a parent component that calls a child that uses useResource. Even if the parent is managing it's own state with useState and passes the modified resource to a child component, it will ignore what was passed in and read from cache instead.
This breaks the parent/child abstraction. The implementer of the parent needs to:

Know that the child component uses useResource
Know that useResource will read from cache if the Resource.id property is set
Delete the Resource.id property from the resource in memory, before passing it as a prop to child.

That requires too much knowledge about the internals of both the child and useResource

Even if the parent is managing it's own state with useState and passes the modified resource to a child component, it will ignore what was passed in and read from cache instead.

useResource and the MedplumClient cache are for "live" data.  In this example, if the parent is managing state and wants to share state with the child, it should pass the modified resource as a prop.
useResource is for "I want the most recent version of this resource".

Closing in favor of #1622

authors: codyebberson coveralls rahul1

repo: medplum/medplum


text:
Corrected example jsonl link

Fixes #
No issue number, broken link in the docs
Description
Fixed a broken link while reviewing the docs
How to test
Make sure the link reference is a good one.  Click the link.

Replaced with https://github.com/meeshkan/hmt/pull/210

repo: meeshkan/hmt


text:
add go ver and git sha to ver

before
EaseProbe v1.6.0
after
EaseProbe v1.6.0 afb3f189c 2022-06-16T09:17:06Z go1.18.3

Hi @tg123
I think this enables debug logging everywhere. check the attached screenshot

I think this is caused by the log.SetLevel(log.DebugLevel), can we change this to only activate when the -v option is given?
I think this is also good to include into the notifications footer of discord, when debug is enabled?

Other than these two comments looks good to me :+1:

mb, I commit debug by accident
will add log level in separate pr

Codecov Report

Merging #142 (24a5f91) into main (89cc8be) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   90.80%   90.95%   +0.14%
==========================================
  Files          44       42       -2
  Lines        2980     2963      -17
==========================================
- Hits         2706     2695      -11
+ Misses        203      199       -4
+ Partials       71       69       -2

Impacted Files
Coverage Δ

daemon/daemon_unix.go

daemon/daemon_windows.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89cc8be...24a5f91. Read the comment docs.

I'm thinking you probably can store that information in EaseProbe struct in global/easeprobe.go, and add them into the FooterString() , then the notification would see such information just like @proditis mentioned above.

is it too long?

authors: codecov-commenter haoel proditis tg123

repo: megaease/easeprobe


text:
Support for xmlSecIORegisterCallbacks etc. or equivalent

I'm trying port some C code to Python that uses xmlsec to sign both a SOAP envelope and an external XML document, which will eventually be bundled into a multipart MIME request. The existing C code uses xmlSecIORegisterCallbacks to handle fetching the data for the corresponding <Reference URI="cid:[some_id]"> node in the template. My naive Python code/template results in (1, 'failed to sign'), and with xmlsec.enable_debug_trace() enabled, I get:
func=xmlSecDSigReferenceCtxProcessNode:file=xmldsig.c:line=1382:obj=unknown:subj=unknown:error=21:invalid node:actual=NULL; expected=DigestValue
func=xmlSecDSigCtxProcessReferences:file=xmldsig.c:line=752:obj=Reference:subj=xmlSecDSigReferenceCtxProcessNode:error=1:xmlsec library function failed:
func=xmlSecDSigCtxProcessSignatureNode:file=xmldsig.c:line=517:obj=unknown:subj=xmlSecDSigCtxProcessReferences:error=1:xmlsec library function failed:
func=xmlSecDSigCtxSign:file=xmldsig.c:line=291:obj=unknown:subj=xmlSecDSigCtxProcessSignatureNode:error=1:xmlsec library function failed:

It doesn't look like these Python expose any way to handle loading of external data, and I don't think the xmlsec.tree.add_ids() function is what I want instead.
How should I go about using external references and/or adding the ability to do so? I can probably get some time to work on adding anything that's needed, with the caveat that C is not my first language.

Done in #188. Thank you @ch3pjw!

repo: mehcode/python-xmlsec


text:
[BUG] "Load calibration" followed by "Capture Background" gives error

"Load calibration" followed by "Capture Background" yields:
Error: unsupported operand type(s) for *: 'NoneType' and 'float'

It seems like the lca{a/b}_{0,60,120} attributes of QLIPP_Calibration are not being set correctly during "Load calibration".
Ziwen, would you mind helping out with this? I think you should be able to recreate this issue locally.

Found these lines in load_calibration:
https://github.com/mehta-lab/recOrder/blob/00cf5ad0d733aad44067a8e65639f67abb446cd5/recOrder/plugin/workers/calibration_workers.py#L370-L372
It seems to me that the return line does not do anything here?

I think the return is used, but in a sneaky way by self.worker.returned here:
https://github.com/mehta-lab/recOrder/blob/main/recOrder/plugin/widget/main_widget.py#L2460
It seems like the calibration must be returned somehow, or else the LCs wouldn't receive any of the data from the thread.
This page was pretty helpful for me to understand how this section works:
https://napari.org/stable/guides/threading.html
"The @thread_worker decorator converts your function into one that returns a WorkerBase instance."

authors: talonchandler ziw-liu

repo: mehta-lab/recOrder


text:
[FEATURE] implement all reconstructions within processing step

Problem
Currently, we implement following compute in the processing step of the pipeline:

QLIPP: pixel-wise reconstruction of retardance and deconvolution of phase from brightfield.
Fluorescence Deconvolution: deconvolution of fluorescence alone
PhaseFromBF: deconvolution of phase from brightfield stack alone.
If QLIPP or PhaseFromBF modes are chosen, fluorescence deconvolution is considered a post-processing step.

This has been a) confusing to the user, and b) affects the efficiency of compute and data i/o.
A specific example of this is #81.
Proposed solution
The user should be presented a simple and cleaner set of choices.
One choice is  between 2D vs 3D reconstruction. Most experiments involve imaging a sample that is either thinner than the depth of field or thicker than the depth of field. The spatio-temporal dimensions are consistent across the channels, most of the time.
The second choice is between types of reconstructions. User may need any or all of the following reconstructions.

Retardance and Orientation: pixel-wise or deconvolution.
Phase from Brightfield.
Fluorescence Deconvolution.

Under the hood, the pipelines need to be optimized to enable the implementation of above reconstructions in arbitrary combinations. Some of the above modes should be disabled if the relevant channels are not found in the input.
An idea for clean implementation is that

user can run only one type of reconstruction from UI at a time if the relevant input channels are present in the zarr store.
new channels can be added to an existing zarr store.

Alternatives you have considered, if any
To develop efficient pipelines along the above lines, @talonchandler and @lihaoyeh  have written scripts using waveorder reader, writer, and compute modules. These scripts are also amenable to parallelization with multiprocessing. Once these scripts are developed, we can incorporate them in the pipeline.

Closing. These features are now present on the main branch of recOrder.

authors: mattersoflight talonchandler


text:
(optimize) fix template loader run twice when webpack frist build in …

观察到 dev 环境下初次 build 的时候 template loader 编译了两次，推测是 webpack config 内 template loader 作用了一次， inline 时也作用了一次，很神奇 inline loader 前缀 -!  没有生效...，根据目前情况.. loader context 内的 loaders 长度为 1 判断为 inline loader 时仅作用 template loader..

close

repo: meidengtech/yurijs


text:
Content of the repo

Would this repo store plain kubernetes manifests, or is the plan to support multiple deployment options?, e.g:

Helm charts
Kustomize
Plain kubernetes manifests

Hi @renehernandez, initially I created this repo in order to get these manifests here.
I am not familiar with kustomize so far, but I guess we could have the plain manifests & the helm charts. If the kustomize file seems good to have here in your opinion we should too :)
What I would like to have is when developers search to deploy MeiliSearch on K8s, they should end there and the README should redirect them to the appropriate way of deploying it on a K8s cluster according to what they are used to do.
Are you a kubernetes user yourself?

Are you a kubernetes user yourself?

Yes, I work with kubernetes in AWS at our company. I have deployed Meilisearch on kubernetes using a helm chart I created for it.

What I would like to have is when developers search to deploy MeiliSearch on K8s, they should end there and the README should redirect them to the appropriate way of deploying it on a K8s cluster according to what they are used to do.

That seems like a good idea. The only concern there is that supporting multiple ways to deploying to kubernete means that every time you are doing a change you need to verify that change is replicated across the different tooling

I am not familiar with kustomize so far, but I guess we could have the plain manifests & the helm charts. If the kustomize file seems good to have here in your opinion we should too :)

I haven't used kustomize in the past, I was asking about it because I know it has traction in the community. IMO, I will start with a helm chart for deployment ( I may be biased here 😂 ), but that will also require to provide a chart repository for developers to be able to fetch the chart and avoid copying it from source

I am going to look if I can open source the code for the meilisearch chart

The only concern there is that supporting multiple ways to deploying to kubernete means that every time you are doing a change you need to verify that change is replicated across the different tooling

Yes, I get your concern.. I do not have any solution in mind so far to avoid this situation..

but that will also require to provide a chart repository for developers to be able to fetch the chart and avoid copying it from source

You're right! I can create a meilisearch/meilisearch-helm repository for this once we have a improved README on this K8s repository ^^
We used k8s internally, so I also have some manifests on my side but they are pretty basic with a deploy, a private volume claim & a service. I only tried them on DO  k8s, so maybe they are not universal.. Do you think we should also provide an ingress manifest?

Do you think we should also provide an ingress manifest?

Definitely, an ingress allows for customizing host and rules access to the service in the cluster.
Also, in my case I went with a statefulset instead of a deployment

Hi everyone, I was the one that suggested kubernetes manifests and @tpayet initially invited me as an maintainer. However vacation and other stuff happened so by the time I got around to it the invitation expired :sweat_smile:, sorry about that.
The initial manifests I wanted to post were kustomize based as is just about everything in our clusters. I'm a big fan of it especially with the components that got introduced in 3.7.0. That said helm charts is probably what the majority of people use and it would be a shame if people would skip this just because of tooling. The downsides of both kustomize and helm is that you can't simply apply them with a kubectl apply -f ./ and because the files on disk do not represent the final output sent to the cluster some unexpected transformations can still occur. Being able to use just git diff the local files is extremely nice to determine if any changes are incompatible with your deployments.
A solution that I've seen is that the helm chart is the primary development target and before release use helm template ./ to generate a set of manifests that get tagged along with the actual helm chart. I think that would be a good place to start. Later on we can add variations if needed.

Hey @Rio :) Thanks for coming back!
Are you saying that we could have manifests automatically generated using helm template that we could commit on this repository? Indeed that sounds a good place to start :)

Exactly. A good example is cert manager's repo.
This way people that quickly want to helm install to play with things can still do so while other operators that like to add customizations and see exactly what is going on in their manifests can still do all of their git and yaml foo. They can even use something like kpt or raw kubectl apply -f https://github.com/meilisearch/meilisearch-kubernetes/releases/download/v0.13.0/ha-install.yaml without trouble.

See https://github.com/Imagine-Impact/meilisearch-helm for a reference chart I previously created

Hey @Rio thanks, following that idea I added manifests and a little getting strated. Can you have a look at https://github.com/meilisearch/meilisearch-kubernetes/pull/10 ?

Thanks for your contributions!!! 🎉

authors: Bajix Rio eskombro renehernandez tpayet

repo: meilisearch/meilisearch-kubernetes


text:
Meilisearch takes a lot of time to accept a file

Once a file has been sent to Meilisearch, it spends a lot of time accepting it, registering it in the queue, and returning the task ID. For example, sending a 26GiB file takes a minute and a half to upload, but Meilisearch takes 8 minutes to process it and return a task ID. Note that the file is a JSON Lines file, and the internal document updates files are ~also JSON Lines files~ OBKV Grenad files where the FieldsIdsMap is put at the end of the grenad file.

https://github.com/meilisearch/meilisearch/blob/0913373a5e7e4c5df6f054e076891bffb0799c7c/milli/src/documents/builder.rs#L60-L81

Hey, do you have an idea in mind?
Have you profiled what takes time? Personally, I think that writing the full file twice (once as jsonlines + once as obkv) is a terrible idea, and we should re-do the PR that @loiclec did a long time ago: https://github.com/meilisearch/milli/pull/576
Iirc, the performance wasn’t good, it wasn’t bad either; it basically didn’t change anything for a big codebase change.
But at the time, we didn’t measure how much time it took to register a task (plus, we rewrote this part entirely with the index-scheduler refactor).
The other thing I think we should do is compress the updated files on the fly; that should greatly reduce the number of IO operations we do + help a lot to reduce the disk consumption due to the unprocessed tasks.

After investigating and measuring the time it takes without deserializing the objects of the NDJSON 26GiB file it was taking 6 minutes. So, Meilisearch is doing a pretty good job at handling 26GiB of JSON and storing them in the tasks queue.

authors: Kerollmops irevoire

repo: meilisearch/meilisearch