text:
filter read candidate bad nodes

Feature Request
hi lettucer
i change PooledClusterConnectionProvider class isReadCandidate method, for filter bad nodes.
file: src/main/java/io/lettuce/core/cluster/PooledClusterConnectionProvider.java
private boolean isReadCandidate(RedisClusterNode master, RedisClusterNode partition) {
return master.getNodeId().equals(partition.getNodeId())
|| master.getNodeId().equals(partition.getSlaveOf())
&& (!partition.getFlags().contains(RedisClusterNode.NodeFlag.FAIL))
&& (!partition.getFlags().contains(RedisClusterNode.NodeFlag.EVENTUAL_FAIL))
&& (!partition.getFlags().contains(RedisClusterNode.NodeFlag.HANDSHAKE))
&& (!partition.getFlags().contains(RedisClusterNode.NodeFlag.NOADDR));
}

That's something to implement in a custom ReadFrom strategy. RedisNodeDescription is typically instance of RedisClusterNode and allows introspection in the strategy class.

repo: lettuce-io/lettuce-core


text:
JMPickerActionSheet below UITabBarController

Hi,
On iPhone, the view is under UITabBarController if there is an UITabBar.

You can reproduce it by adding a UITabBarController in your sample like this :

Have good day !

Got same issue

Some questions about the way you present the JMPickerActionSheet
Are you using this selector ?
showActionSheetDescription:actionSheetDescription inViewController:viewController
viewController is the tabbarController?

source: gharchive/issue

authors: chlebta leoderbois leverdeterre

repo: leverdeterre/JMActionSheetDescription

license: mit

license_type: permissive

license_source: bigquery


text:
[Error] Cannot find index file: .../.git/index

Describe the bug
Opening a file in a git project that has never been committed will result in an error
If ./git/index does not exist, an error will occur.
To Reproduce
init.vim:
let $PLUGIN_DIRECTORY = '~/.config/nvim/.plugged'
set runtimepath^=$PLUGIN_DIRECTORY/plenary.nvim
set runtimepath^=$PLUGIN_DIRECTORY/gitsigns.nvim

lua << EOF
require('gitsigns').setup {
  -- config
}
EOF

Steps to reproduce the behavior:

Make empty git project: $ mkdir sample_proj && cd $_ && git init
Create file: $ touch file.vim
Start nvim: $ nvim -u ~/tmp/init.vim -i NONE file.vim
See error

Observed output
Error messages, logs, etc
Error executing luv callback:
...onfig/nvim/.plugged/gitsigns.nvim/lua/gitsigns/async.lua:21: ...324/.config/nvim/.plugged/gitsigns.nvim/lua/gitsigns.lua:328: Cannot find index file: /home/tamago324/tmp/sample_proj/.git/index

Screenshots
If applicable, add screenshots to help explain your problem or to capture error messages.
Additional context
System: Linux
Neovim version: v0.5.0-dev+1012-gfe1ebea33

You are making an error, explicitly. https://github.com/lewis6991/gitsigns.nvim/blob/b8ff5223a18791b662b93603e58d54435c3ac0af/lua/gitsigns.lua#L326-L330
I'm really sorry.
I am so embarrassed.

You are making an error, explicitly. https://github.com/lewis6991/gitsigns.nvim/blob/b8ff5223a18791b662b93603e58d54435c3ac0af/lua/gitsigns.lua#L326-L330
I'm really sorry.
I am so embarrassed.

As a suggestion, how about using print instead of error?
I was a little concerned about getting an error every time I open a file.

As a suggestion, how about using print instead of error?
I was a little concerned about getting an error every time I open a file.

In case of an error(), I had to press Enter each time, which I found annoying.

In case of an error(), I had to press Enter each time, which I found annoying.

Thanks for this. I haven't considered this scenario. I'll reopen and try and fix this.

Thanks for this. I haven't considered this scenario. I'll reopen and try and fix this.

Thank you very much.
Thanks to the issues template, I was able to quickly create issues.

Thank you very much.
Thanks to the issues template, I was able to quickly create issues.

I'd noticed this bug too, but had been too busy to eliminate wether there was an issue in my setup (I'd been playing with the statusline handlers at the time). FWIW I believe the last commit before this issue was:
9c49451bfd85f397b38ec2362674ac06bf9f3d36

I'd noticed this bug too, but had been too busy to eliminate wether there was an issue in my setup (I'd been playing with the statusline handlers at the time). FWIW I believe the last commit before this issue was:
9c49451bfd85f397b38ec2362674ac06bf9f3d36

Could someone kindly try out https://github.com/lewis6991/gitsigns.nvim/pull/50, It should fix this issue.

Could someone kindly try out https://github.com/lewis6991/gitsigns.nvim/pull/50, It should fix this issue.

@lewis6991 Thank you! I have confirmed that it has been fixed 👍

@lewis6991 Thank you! I have confirmed that it has been fixed 👍

license: MIT

license_source: github-api


text:
Inline blame: long commit messages overwrite text

Description
When there is a long commit message, it overwrites the text of the file, as opposed to being cut off.
Neovim version
0.9.1
Operating system and version
macOS Ventura
Expected behavior
The commit message to be cut off, perhaps with ellipsis or the likes. At the very least, let the file's text to take precedence.
Actual behavior
A file with the follow contents:
The quick brown fox jumps over the lazy dog.

Committed with:
$ git commit -m "this is a very very very long git commit message that happens to be very long, as described"

Shows as such:

Minimal config
for name, url in pairs{
  gitsigns = 'https://github.com/lewis6991/gitsigns.nvim',
  -- ADD OTHER PLUGINS _NECESSARY_ TO REPRODUCE THE ISSUE
} do
  local install_path = vim.fn.fnamemodify('gitsigns_issue/'..name, ':p')
  if vim.fn.isdirectory(install_path) == 0 then
    vim.fn.system { 'git', 'clone', '--depth=1', url, install_path }
  end
  vim.opt.runtimepath:append(install_path)
end

require('gitsigns').setup{
  debug_mode = true, -- You must add this to enable debug messages
  -- ADD GITSIGNS CONFIG THAT IS _NECESSARY_ FOR REPRODUCING THE ISSUE
  current_line_blame = true,
  current_line_blame_opts = {
    virt_text_pos = 'right_align',
  },
}

-- ADD INIT.LUA SETTINGS THAT IS _NECESSARY_ FOR REPRODUCING THE ISSUE

Steps to reproduce

Open a git repository with a long commit message. E.g.:

$ mkdir /tmp/test
$ cd /tmp/test
$ git init
$ echo "The quick brown fox jumps over the lazy dog." >hello
$ git add hello
$ git commit -m "this is a very very very long git commit message that happens to be very long, as described"

nvim --clean -u minimal.lua /tmp/test/hello
Make the window smaller, if need be.

Gitsigns debug messages
signs.init: Using vimfn signs
dprintf: Deriving GitSignsAdd from DiffAdd
dprintf: Deriving GitSignsChange from DiffChange
dprintf: Deriving GitSignsDelete from DiffDelete
dprintf: Deriving GitSignsChangedelete from GitSignsChange
dprintf: Deriving GitSignsTopdelete from GitSignsDelete
dprintf: Deriving GitSignsUntracked from GitSignsAdd
dprintf: Deriving GitSignsAddNr from GitSignsAdd
dprintf: Deriving GitSignsChangeNr from GitSignsChange
dprintf: Deriving GitSignsDeleteNr from GitSignsDelete
dprintf: Deriving GitSignsChangedeleteNr from GitSignsChangeNr
dprintf: Deriving GitSignsTopdeleteNr from GitSignsDeleteNr
dprintf: Deriving GitSignsUntrackedNr from GitSignsAddNr
dprintf: Deriving GitSignsAddLn from DiffAdd
dprintf: Deriving GitSignsChangeLn from DiffChange
dprintf: Deriving GitSignsChangedeleteLn from GitSignsChangeLn
dprintf: Deriving GitSignsUntrackedLn from GitSignsAddLn
dprintf: Deriving GitSignsStagedAdd from GitSignsAdd
dprintf: Deriving GitSignsStagedChange from GitSignsChange
dprintf: Deriving GitSignsStagedDelete from GitSignsDelete
dprintf: Deriving GitSignsStagedChangedelete from GitSignsChangedelete
dprintf: Deriving GitSignsStagedTopdelete from GitSignsTopdelete
dprintf: Deriving GitSignsStagedAddNr from GitSignsAddNr
dprintf: Deriving GitSignsStagedChangeNr from GitSignsChangeNr
dprintf: Deriving GitSignsStagedDeleteNr from GitSignsDeleteNr
dprintf: Deriving GitSignsStagedChangedeleteNr from GitSignsChangedeleteNr
dprintf: Deriving GitSignsStagedTopdeleteNr from GitSignsTopdeleteNr
dprintf: Deriving GitSignsStagedAddLn from GitSignsAddLn
dprintf: Deriving GitSignsStagedChangeLn from GitSignsChangeLn
dprintf: Could not derive GitSignsStagedDeleteLn
dprintf: Deriving GitSignsStagedChangedeleteLn from GitSignsChangedeleteLn
dprintf: Could not derive GitSignsStagedTopdeleteLn
dprintf: Deriving GitSignsAddPreview from DiffAdd
dprintf: Deriving GitSignsDeletePreview from DiffDelete
dprintf: Deriving GitSignsCurrentLineBlame from NonText
dprintf: Deriving GitSignsAddInline from TermCursor
dprintf: Deriving GitSignsDeleteInline from TermCursor
dprintf: Deriving GitSignsChangeInline from TermCursor
dprintf: Deriving GitSignsAddLnInline from GitSignsAddInline
dprintf: Deriving GitSignsChangeLnInline from GitSignsChangeInline
dprintf: Deriving GitSignsDeleteLnInline from GitSignsDeleteInline
dprintf: Deriving GitSignsDeleteVirtLn from DiffDelete
dprintf: Deriving GitSignsDeleteVirtLnInLine from GitSignsDeleteLnInline
dprintf: Deriving GitSignsVirtLnum from GitSignsDeleteVirtLn
attach(1): Attaching (trigger=setup)
run_job: git --version
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 config user.name
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 rev-parse --show-toplevel --absolute-git-dir --abbrev-ref HEAD
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir /Users/mariellh/t/.git -c core.quotepath=off ls-files --stage --other
s --exclude-standard --eol /Users/mariellh/t/hello
watch_gitdir(1): Watching git dir
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir /Users/mariellh/t/.git show :0:hello
update(1): updates: 1, jobs: 5
run_job: git --no-pager --literal-pathspecs -c gc.auto=0 --git-dir /Users/mariellh/t/.git blame --contents - -L 1,+1 --line-porcelain /U
sers/mariellh/t/hello
cli.run: Running action 'debug_messages' with arguments {}

Cannot reproduce:


text:
Metrics integration with datadog

Adds many APM trace metrics and error alerting via datadog integration.

Resolves #611

Codecov Report

Merging #688 (b1c57ab) into main (7969317) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #688   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           68        70    +2
  Lines         2925      3018   +93
  Branches       310       310
=========================================
+ Hits          2925      3018   +93

Impacted Files
Coverage Δ

src/spellbot/cli.py
100.00% <100.00%> (ø)

src/spellbot/client.py
100.00% <100.00%> (ø)

src/spellbot/cogs/about_cog.py
100.00% <100.00%> (ø)

src/spellbot/cogs/admin_cog.py
100.00% <100.00%> (ø)

src/spellbot/cogs/ban_cog.py
100.00% <100.00%> (ø)

src/spellbot/cogs/block_cog.py
100.00% <100.00%> (ø)

src/spellbot/cogs/config_cog.py
100.00% <100.00%> (ø)

src/spellbot/cogs/events_cog.py
100.00% <100.00%> (ø)

src/spellbot/cogs/leave_cog.py
100.00% <100.00%> (ø)

src/spellbot/cogs/lfg_cog.py
100.00% <100.00%> (ø)

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc4360...b1c57ab. Read the comment docs.

source: gharchive/pull-request

authors: codecov-commenter lexicalunit

repo: lexicalunit/spellbot


text:
Refresh Token over LexikJWTAuthenticationBundle (new Bundle)

Hi everyone!
Im developing a bundle that Implements a Refresh Token system over Json Web Tokens in Symfony. This bundle depends of LexikJWTAuthenticationBundle.
This is the link:
https://github.com/gesdinet/JWTRefreshTokenBundle
Do you think we can make a doc chapter for this?

Hello markitosgv, I'm working on the same subject, and I think your bundle has a bad dependency : imo the FosUserBundle should'nt be required.
I'm currently using the Doctrine\Common\Cache\CacheProvider interface as tokens storage, but the final solution must support custom storage layers.

Hi @mRoca,
Maybe is a good next step to work for avoid dependency from FOSUserBundle. Are you working on a open source git repo?
PS. PR on JWTRefreshTokenBundle are more than welcome! :D

I will push my code soon. If I can add it to your repo, I will.

@mRoca perfect we can see it then

Hi, I've created an example project implementing the refresh token. It's an example, and should be refactored to create a true auth listener : https://github.com/mRoca/sf2-jwt-refresh-token .

Now https://github.com/gesdinet/JWTRefreshTokenBundle no depends of FOSUserBundle

Hi, about the initial subject, please feel free to make a PR for a link and a short use case description in the documentation. The best place would be in the https://github.com/lexik/LexikJWTAuthenticationBundle/blob/master/Resources/doc/index.md#notes section, right after the token expiration note.

Hi guys! Question : is there a bundle / feature for invalidate the jwt ?

Answer to @slashfan:
Nice! I'm going to prepare a little text to add to documentation notes.
To @GreGosPhaTos:
A JWT token can't be revoked cause itself is autovalidating until date expires. The only way you can invalidate (all) tokens is resetting your private key.
You can set a low ttl for JWT but then you need to ask to your client his credentials many times.
This is the main cause we release a JWTRefreshToken bundle, to refresh JWT tokens by a refresh_token instead of ask every time credentials to a user.

Ok thanks for your answer @markitosgv , I know that's the invalidation is not a part of the jwt spec, but I am wondering if there's a bundle that can provide a way to blacklist (or whitelist) the tokens for example.
I already implemented the refresh on my API, and I didn't read all the jwt specs but nothing in the spec telling that we cannot implemented a way to blacklist or whitelist the token right ?
Thanks for your answers guys.

You can implement some whitelist or blacklist to check JWT, but then you need to search on every query if JWT is valid, you lose the advantage to no depends on db.
With refresh token you only hit a DB when you need to refresh a JWT.
But maybe do a blacklist system with redis is a good way to revoke tokens.

@GreGosPhaTos see https://github.com/lexik/LexikJWTAuthenticationBundle/issues/58#issuecomment-89641970

Thanks @markitosgv and @slashfan I ll do that, maybe I could create a bundle for that ... I ll let you know about this .

authors: GreGosPhaTos mRoca markitosgv slashfan

repo: lexik/LexikJWTAuthenticationBundle


text:
Change Statix functions to be overridable

First thing: thanks for this awesome lib :)
I found myself wanting to override the functions so that for example I can conditionally add some tags, change the key name etc. Would this be useful for others?
I'm also not sure if the best solution is actually to make transmit part of the "main module" and make just that overridable?
And the tests are pretty much a copy and paste for now.
Thanks in advance :)

Thank you @edgurgel. 💛

Thank you! <3

authors: edgurgel lexmag

repo: lexmag/statix

license: isc


text:
gitignore: ignore conf/{grub.cfg,authorized_keys}

these are locally changed config files that should not be committed

Ack. @eriknordmark Do we need to keep the empty authorized_key file in repo at all? What if we create a README in the conf folder and explain what files are expected to be here in this folder?

I renamed the authorized_keys file to authorized_keys.tmpl. That README already exists? https://github.com/lf-edge/eve/blob/master/docs/CONFIG.md?plain=1#L14

I renamed the authorized_keys file to authorized_keys.tmpl. That README already exists? https://github.com/lf-edge/eve/blob/master/docs/CONFIG.md?plain=1#L14

Yeah, that what I'm asking: do we need to keep an empty file with a name, which actually is not used: authorized_keys.tmpl. If it has some valuable info, then yes: you rename the file and get the expected behavior, but this one is empty (with some comments, but who cares), so whats the reason to keep it in the repo at all?

The nasty issue I always experience (not this PR related, but grub.cfg related) is that once you switched from another branch and does the "make live", the first time  "set_getty" is not set (but it is in the grub.cfg), so you always need to repeat the "make live". I did not investigate that thoroughly. @christoph-zededa have you experienced that?
(again, this is not this PR related)

I renamed the authorized_keys file to authorized_keys.tmpl. That README already exists? https://github.com/lf-edge/eve/blob/master/docs/CONFIG.md?plain=1#L14

Yeah, that what I'm asking: do we need to keep an empty file with a name, which actually is not used: authorized_keys.tmpl. If it has some valuable info, then yes: you rename the file and get the expected behavior, but this one is empty (with some comments, but who cares), so whats the reason to keep it in the repo at all?

Removed it, put the info into docs/CONFIG.md instead

authors: christoph-zededa rouming

repo: lf-edge/eve


text:
to trigger eden workflow based on condition

PR to use the new eden workflows for testing eve changes in PR, master and tag builds. Added concurrency across the workflow with cancel-in-progress: to avoid clogging of the builds. I have used multiple workflow triggers based on different conditions because github actions doesn't supports if else condition as per my understanding.
The run shell is an option but then we have to specificy the attribute runs-on which will cause delay in the trigger(based on the workload)
Please feel free to offer any other suitable options.

LGTM, couple comments:

I'd switch workflows so that there will be no two testing workflows running in paralllel
I'm not sure I understand how concurrency will work in case somebody will re-approve same PR I guess it'll re-trigger tests, which is not desirable, but tolerable for now. I did some digging and there's this fancy github.event.before and github.event.after which we can use to determine if git HEAD has changed, i.e.

      - name: Check if PR is Approved and No New Commits
        id: approval_and_no_new_commits
        run: |
          if [ "${{ github.event_name }}" == "pull_request" ] && [ "${{ github.event.action }}" != "closed" ]; then
            if [ "${{ github.event.pull_request.labels.*.name }}" == "approved" ] && [ "${{ github.event.before }}" == "${{ github.event.after }}" ]; then
              echo "PR is approved and has no new commits."
              echo "::set-output name=approved::true"
            else
              echo "PR is not approved or has new commits."
              echo "::set-output name=approved::false"
            fi
          fi
        shell: bash

      - name: Run Tests
        if: steps.approval_and_no_new_commits.outputs.approved == 'true'
        uses: lf-edge/eden/.github/workflows/test.yml@master
        with:
          eve_image: //...

But if I understand concurrency tag, if we add this and somebody will re-approve concurrency will stop previous job and new will not be triggered since there are no changes in PR. Alternative to it would be to remove concurrency group but then we will have blank jobs, when somebody re-approved job. What are your thoughts @yash-zededa ?

@uncleDecart I think the issue only would be with the PR builds, we can have few more checks but that would involve use of a runner and that in my opinion would contribute to a delay. I think using labels would be an ideal approach, the tests would be triggered on PR only when there is a specific label is present. master branch and tag build should not cause any issue in my opinion. Moving forward, we can also label the PR automatically based on certain conditions - this will also reduce the congestion due to PR builds.

Update: did experiment with new workflows: created PR in fork with changes and approved it twice and it triggered tests twice (1 and 2), which is not desirable.
Will test labels now, if they will work then in order for tests to be run we will have to put labels manually, then we can automatize this by adding github bot.

Update: did experiment with new workflows: created PR in fork with changes and approved it twice and it triggered tests twice (1 and 2), which is not desirable.
Will test labels now, if they will work then in order for tests to be run we will have to put labels manually, then we can automatize this by adding github bot.

The label trigger worked as expected but the combination of approved + labelled is not working. The pull request approval event should have the label info in it for the PR to be build - which is not desriable.
I am testing the https://github.com/abinoda/label-when-approved-action - if this works then we can test the same.

Note that DCO is failing since none of the commits are signed with your name and email. All of the commits need to be signed. git commit -S does that.

Thanks, at times I forget to use -s. Signed all the commits. I will squash all the commits once testing is completed.

Update:
We attempted to use https://github.com/marketplace/actions/label-approved-pull-requests, but it did not work properly. Although the PR was marked test-eden,  the github actions were not initiated.
As of now, we will proceed with the understanding that re-approval of the same PR will result in a new process run and the previous will be cancelled.

We attempted to use https://github.com/marketplace/actions/label-approved-pull-requests, but it did not work properly. Although the PR was marked test-eden, the github actions were not triggered.

Did you try what is suggested in https://stackoverflow.com/questions/62325286/run-github-actions-when-pull-requests-have-a-specific-label ?

yetus failed but generated no annotations against the diffs. Sigh.
Looking at the yetus logs I see this
-1 overall

  | Vote |      Subsystem |  Runtime   | Comment
  ============================================================================
  +---------------------------------------------------------------------------
  |      |                |            | Prechecks
  +---------------------------------------------------------------------------
  |  +1  |       dupname  |   0m  0s   | No case conflicting files found.
  +---------------------------------------------------------------------------
  |      |                |            | master Compile Tests
  +---------------------------------------------------------------------------
  +---------------------------------------------------------------------------
  |      |                |            | Patch Compile Tests
  +---------------------------------------------------------------------------
  |  +1  |     codespell  |   0m  2s   | No new issues.
  |  +1  |    detsecrets  |  12m 44s   | No new issues.
  |  +1  |        blanks  |   0m  0s   | The patch has no blanks issues.
  |  -1  |      yamllint  |   0m  0s   | The patch generated 1 new + 0 unchanged
  |      |                |            | - 0 fixed = 1 total (was 0)
  +---------------------------------------------------------------------------
  |      |                |            | Other Tests
  +---------------------------------------------------------------------------
  |      |                |  12m 51s   |

Can you try yamllint manually? Might need to add the yamllint package to your laptop.

We attempted to use https://github.com/marketplace/actions/label-approved-pull-requests, but it did not work properly. Although the PR was marked test-eden, the github actions were not triggered.

Did you try what is suggested in https://stackoverflow.com/questions/62325286/run-github-actions-when-pull-requests-have-a-specific-label ?

Yes, I tried this but unfortunately it didn't worked, The label was added but the github actions was not triggered when the PR was labelled.

yetus failed but generated no annotations against the diffs. Sigh. Looking at the yetus logs I see this
-1 overall

  | Vote |      Subsystem |  Runtime   | Comment
  ============================================================================
  +---------------------------------------------------------------------------
  |      |                |            | Prechecks
  +---------------------------------------------------------------------------
  |  +1  |       dupname  |   0m  0s   | No case conflicting files found.
  +---------------------------------------------------------------------------
  |      |                |            | master Compile Tests
  +---------------------------------------------------------------------------
  +---------------------------------------------------------------------------
  |      |                |            | Patch Compile Tests
  +---------------------------------------------------------------------------
  |  +1  |     codespell  |   0m  2s   | No new issues.
  |  +1  |    detsecrets  |  12m 44s   | No new issues.
  |  +1  |        blanks  |   0m  0s   | The patch has no blanks issues.
  |  -1  |      yamllint  |   0m  0s   | The patch generated 1 new + 0 unchanged
  |      |                |            | - 0 fixed = 1 total (was 0)
  +---------------------------------------------------------------------------
  |      |                |            | Other Tests
  +---------------------------------------------------------------------------
  |      |                |  12m 51s   |

Can you try yamllint manually? Might need to add the yamllint package to your laptop.

It might because I removed the trigger for eden.yml and not added the # yamllint disable-line rule:truthy line. Let me add this line.

Yetus checks are passing now. I am waiting for PR-884 to be merged and a tag created so that I can point to a release rather than to a branch.

Yetus checks are passing now. I am waiting for Eden PR-884 to be merged and a tag created so that I can point to a release rather than to a branch.

I've metged 884 in eden

BuildJet runners are working link to actions
But this PR needs changes: we are still failing on Upgrade test, because we are changing registry in our workflows here and for PRs we set it as evebuild/danger, therefore when upgrading we try to pull from evebuild/danger, it fails.
There are two possible solutions:

We build eve and use docker tag to link evedanger image to lf-edge/eve image and use lf-edge/eve
We add parameter registry parameter to eden utils download command and specify it in our tests, that way no matter where we are running our new workflows (be it on lf-edge/eve repository or any other fork) we will eve from lf-edge for upgrade test

We will try out 1) approach on local fork since it's easier to implement to confirm that this is the problem

But this PR needs changes: we are still failing on Upgrade test, because we are changing registry in our workflows here and for PRs we set it as evebuild/danger, therefore when upgrading we try to pull from evebuild/danger, it fails.

Is the issue that one of the images (the PR) is in evebuild/danger and the other image is in eve/?
If so, how did we handle this in the old tests?
FWIW pollution eve/ with PRs seems bad; less of an issue to insert/link the eve images we will need for the update test in evebuild/danger.

But this PR needs changes: we are still failing on Upgrade test, because we are changing registry in our workflows here and for PRs we set it as evebuild/danger, therefore when upgrading we try to pull from evebuild/danger, it fails.

Is the issue that one of the images (the PR) is in evebuild/danger and the other image is in eve/?
If so, how did we handle this in the old tests?
FWIW pollution eve/ with PRs seems bad; less of an issue to insert/link the eve images we will need for the update test in evebuild/danger.

Yes it is that issue. We used docker tag to link images we need from evebuild/danger to eve locally, so when eden command runs it'd actually pull evebuild/danger when trying to access image from lf-edge/eve. That Way there was no pollution of lf-edge/eve with PRs and that's why I thought it'd be a good idea to do that.
However, with new workflows it's not that simple. Since we are using reusable workflows and we can't assume that building eve and running docker tag and testing (i.e. executing reusable workflow) will happen on same machine.
We, of course can use artifacts to to push evebulid/danger and I think that will be same polluting as pushing images.
Another alternative which we could explore is GitHub or BuildJet cache, which actually provides 10Gbs of storage (20Gbs f
or BuildJet) for free. That would make it possible to communicate artifacts between jobs without saving them. I think that using cache would actually make sense to speed up our testing even more (i.e. caching kernel builds).
But for now what we should do in my opinion is add parameter registry parameter to eden utils download command and specify it in our tests, that way no matter where we are running our new workflows (be it on lf-edge/eve repository or any other fork) we will eve from lf-edge for upgrade test

@yash-zededa let's try to run new workflows manually, upgrade test should work now I merged https://github.com/lf-edge/eden/pull/893

@yash-zededa let's try to run new workflows manually, upgrade test should work now I merged lf-edge/eden#893

Thanks @uncleDecart, triggering the workflow manually.

@yash-zededa @uncleDecart is this ready to merge?
Once we've build 10.10.0 I'm open to merging it and then we will see how it works in real life.

BuildJet runners are working link to actions

@uncleDecart Collect logs action should also append suite name to the created artifact. Otherwise we only get 4 artifacts, even though there are 11 different workflows.

@milan-zededa created PR for that https://github.com/lf-edge/eden/pull/897

@yash-zededa @uncleDecart is this ready to merge?
Once we've build 10.10.0 I'm open to merging it and then we will see how it works in real life.

@eriknordmark upgrade workflow runs now (at least it worked with zfs) I'd wait for https://github.com/lf-edge/eden/pull/897 to be merged to eden, release eden 0.9.0 and then merge this

@yash-zededa eden 0.9.0 is here https://github.com/lf-edge/eden/releases/tag/0.9.0

@yash-zededa eden 0.9.0 is here https://github.com/lf-edge/eden/releases/tag/0.9.0

It would be good though to include this PR, otherwise we will not be able to find out why onboarding sometimes fails.

@milan-zededa merged your PR and released 0.9.1 https://github.com/lf-edge/eden/releases/tag/0.9.1
@yash-zededa it might be a good idea to point EVE to latest eden version if that's possible

@uncleDecart @yash-zededa It seems that there is some problem with publish-logs/action.yaml not including eve-info.tar.gz in artifacts.
From workflow logs I can see:
Received eve-info.tar.gz with size 1418640
...
Run actions/upload-artifact@v3
  with:
    name: eden-report-networking.tests.txt-tpm-true-ext4
    path: /home/runner/actions-runner/_work/eve/eve/eden/eve-info.tar.gz # created by collect-info action
  /home/runner/actions-runner/_work/eve/eve/eden/trace.log
  /home/runner/actions-runner/_work/eve/eve/eden/info.log
  /home/runner/actions-runner/_work/eve/eve/eden/metric.log
  /home/runner/actions-runner/_work/eve/eve/eden/netstat.log
  /home/runner/actions-runner/_work/eve/eve/eden/console.log
  /home/runner/actions-runner/_work/eve/eve/eden/adam.log

But collected artifact does not contain eve-info.tar.gz.
Maybe working directories between collect/upload actions do not match?

@milan-zededa created PR, this should fix missing artifacts

@yash-zededa PR is merged, can you run locally and see the results?

@yash-zededa PR is merged, can you run locally and see the results?

@uncleDecart I have executed the action pointing to my forked-repo
https://github.com/yash-zededa/eve/actions/runs/6453056486/job/17515985025
Once the execution is successful and the zip file is part of the artefact we are good to merge this.

Looks like some commits lost their DCO signoff: Commit sha: 4eae750, Author: yash-zededa, Committer: yash-zededa; The sign-off is missing. Commit sha: 9500d5f, Author: yash-zededa, Committer: GitHub; The sign-off is missing.
Also, we are waiting on @uncleDecart @giggsoff to figure out the eden PR.

commits are squashed and signed now.

@yash-zededa PR is merged, can you run locally and see the results?

@uncleDecart I have executed the action pointing to my forked-repo
https://github.com/yash-zededa/eve/actions/runs/6453056486/job/17515985025
Once the execution is successful and the zip file is part of the artefact we are good to merge this.

Do you have access to buildjet-4vcpu-ubuntu-2204 runners in your fork? It was my point and it was resolved as I remember.

I think I had seen a run from my work using the buildjet-4vcpu-ubuntu-2204, let me look for that run

@uncleDecart I think we should merge this PR now. It has been going on since quite sometime :). I have pushed the changes considering we would release 0.9.2 tag for eden, Can you please create the required tag on eden.

sure @yash-zededa, but does it work with master on lf-edge's eden repo?

sure @yash-zededa, but does it work with master on lf-edge's eden repo?

Yes, it is working with lf-edge/eve pointing to eden master.
https://github.com/lf-edge/eve/actions/runs/6454241589/job/17519368579
Seems like @giggsoff was correct my forked repo is not having access to the buildjet runners. May be I was confused as we are testing too much, lol :)

sure @yash-zededa, but does it work with master on lf-edge's eden repo?

Yes, it is working with lf-edge/eve pointing to eden master.
https://github.com/lf-edge/eve/actions/runs/6454241589/job/17519368579
Seems like @giggsoff was correct my forked repo is not having access to the buildjet runners. May be I was confused as we are testing too much, lol :)

Seems there is another error: https://github.com/lf-edge/eve/actions/runs/6454241589/job/17520292589#step:3:6919. And another one: https://github.com/lf-edge/eve/actions/runs/6454241589/job/17520292589#step:3:6845 (we skip ssh option because of the problem).
Also I can see not based on an OCI image here. Which indicates that we try to run vnc test (with qcow2 image inside) on the EVE-os without hardware acceleration, which is not expected (but looks like a separate issue for the PR).

@giggsoff I think we can merge it as of now and try to fix tests separately (because this workflow is using 10.4.0 EVE and collect-info.sh should be there)

@giggsoff I think we can merge it as of now and try to fix tests separately (because this workflow is using 10.4.0 EVE and collect-info.sh should be there)

@eriknordmark Appreciate if you can merge this

@giggsoff I created issues in eden addressing your comment
https://github.com/lf-edge/eden/issues/901
https://github.com/lf-edge/eden/issues/902

@giggsoff I created issues in eden addressing your comment
lf-edge/eden#901 lf-edge/eden#902

Thank you!

authors: eriknordmark giggsoff milan-zededa uncleDecart yash-zededa


text:
Delete the search input on registration form

Description 📹
Page link : https://app.starknet.id/register/kevil.stark

Delete the search input
Proposed Actions 🛠
Here’s a checklist of actions to follow for resolving this issue:

Fork and Create Branch:
Fork the repository and create a new branch using the issue number:
git checkout -b fix-[issue-number]

Implement Changes:
[Insert Code snippet if needed with a mardown todo list]

Run Tests and Commit Changes:
Make sure your changes don't break existing functionality and commit with a clear message:
git commit -m "Fix: [Short description of the fix]"

Required 📋
To keep our workflow smooth, please make sure you follow these guidelines:

Assignment: Don't create a pull request if you weren’t assigned to this issue.
Timeframe: Complete the task within 3 business days.
Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
Review Process:

Once you've submitted your PR, change the label to "ready for review".
If changes are requested, address them and then update the label back to "ready for review" once done.

Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏
⚠ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

Can I take this from here?

Is it okay if I take this?

Mind if I take this issue?

Can I work on this issue? @Kevils
I am a fullstack and blockchain developer with experience for more than 1.5 years and would love to work on this issue
ETA-1Day

Could I take on this issue?

Is it okay if I take this?

Could I be assigned to this?

I'd love to give this a go. I’m a full-stack blockchain developer with over 3 years of experience working with Tailwind, React, TypeScript, and Solidity/Rust.

I'd like to take up this issue please.

May I work on this issue? @Kevils
ETA-1Day

I’m interested in this one.

authors: Amarjeet325 Ekene001 Kevils Nityam573 SAIKIRANSURAPALLI SudiptaPaul-31 Verifieddanny ekumamatthew ikennaezef mimisavage ryzen-xp tamaraantonella


text:
🛑 INTERNET GIGA is down

In 91833b5, INTERNET GIGA (gigared.samsa.com.ar) was down:

HTTP code: 0
Response time: 0 ms

Resolved: INTERNET GIGA is back up in b75f0a9.

repo: lgimenezdev/samsanet


text:
SDMMC驱动不正常，SD_InitializeCards返回超时错误（master）

软件版本

[X] 软件已更新到最新版本

您使用的场景？
访问SD卡文件系统
您做了什么操作？
main函数中注释掉大部分任务，只留下UART_task，而SDIO_task设置与启动迁移至UART_task末尾执行，以便在SDIO_task能使用printf打印一些执行情况
您遇到了什么问题？
SD_Init中，执行SD_InitializeCards时返回超时错误
具体为其中的Send CMD9 SEND_CSD部分，发送完命令后，CmdResp2Error等待命令响应超时
（master分支表现如上，LVGL8.3分支也尝试了一下，结果类似，SD_Init返回超时，但暂时没去细测是否表现与master完全一致）
您期望的结果是怎样的？
想正常读写SD卡

1.sd卡容量多大，可能是不兼容你的卡，建议8g以下内存卡
2.线路板上拉电阻画了吗？

1.sd卡容量多大，可能是不兼容你的卡，建议8g以下内存卡 2.线路板上拉电阻画了吗？

不好意思，前面忘了写上硬件环境
卡128MByte，2.0，SDSC，上拉电阻都有
尝试过一份其他的f1c100的sdmmc例程，使用的也是SDIO0，24MHz时钟源，400KHz SDIO CLK，
烧进同一块板是可以正常驱动的
应该是软件上的问题
目前我也在对比查看是为什么，好怪
前面都能正常响应其他CMD，到CMD9 SEND_CSD 的时候就一直没响应
尝试循环send cmd9，然后读STAR寄存器值直至其中的Response Index等于CMD9才跳出
但值一直读出的是是0x1906，Response Index值一直是0x3
即：
bit[16:11]: 0x3（好像是上一个执行的CMD3?（get rca）） —— Response Index
bit[8]: 卡存在  —— CARD_PRESENT 0:not present 1:present
其他位值均为默认值
（以上查自“F1C600 User Manual (Revision 1.0)”  应该F1Cxx系列都适用）

你看一下#4，是否修复了你的问题。如果正常，我就合并入master了。

测试了一下，不行，结果也是一样，发CMD9后等待响应超时了

没有，我的也是128M，很正常

没有，我的也是128M，很正常，可能你的卡哪里不一样吧。要不换张其他卡吧。 立创为什么打不开？打开提示什么？
卡我也换了几张，好像都不行
硬件工程可以了看的了，原来需要使用半离线模式

没有，我的也是128M，很正常，可能你的卡哪里不一样吧。要不换张其他卡吧。 立创为什么打不开？打开提示什么？

工程可以打开了，原来需要半离线模式
我拿手上一些SD卡试了下，好像挑卡：
一张2G卡正常驱动写文件：识别为2.0，立即返回SD_OK
几张小容量卡128、256MB、512MB的都有些问题，情况如下：
识别有1.x或2.0的，有些返回超时，有一两张卡有时超时后的文件操作能正常写入文件
我换可以的先用着吧
后面看看啥时候有空再对比那个可以通读的SDMMC例程看看差异在哪再优化一下

刚买了三张128 256 512试了一下， 测试全部是正常的，库应该没有问题

别用sdsc的卡

authors: AaronChuzb dotdotchan lhdjply


text:
Remove promise polyfill

Since m.prop() is now all stream-based I don't think we should be bundling up a promise polyfill.
Need @lhorie's blessing before I commit though, he may have plans I'm unaware of.

It's not part of the bundle, but I think I'll keep it around for a bit just in case

authors: lhorie tivac


text:
Fix merge issues in develop

Develop isn't compiling due to recently introduced issues.

@mjs  go test ./... hangs on Linux (locally as well). Not sure what it might be

after long delay go test ./... finally passed locally, but still waiting for
xvfb-run --server-args="-screen 0 1024x768x24" make test

that should be related to unit tests updates in recent PR.

As per Slack, go test ./... and xvfb-run --server-args="-screen 0 1024x768x24" make test are working fine on my machine. Hopefully the addition of -timeout tells us something useful.

authors: MaxRis mjs

repo: liamg/aminal


text:
清理报错 & 功能

正如 #3 所提及的，存在报错。
添加当鼠标挪入floating-button 时背景颜色。
点击空白处关闭翻译窗口。
index.tsx 30行处不一定处理正确，必要的话重新编辑一下。

https://github.com/liaoliao666/translate-ext/pull/4/commits/c5b2b177f4952f2e2dcb1fa7531501a3a466bff8
还存在什么问题吗？

我不明白为什么要去除监听mousedown事件

我不明白为什么要去除监听mousedown事件

我的，理解不到位。
想法是认为 addEventListener 会重复添加事件，然而并不会，而且会的话添加第三个参数 once 即可。
已纠正。


text:
bug: liara logs --since=X should fetch all logs from since to now.

Actual Behavior
when using liara logs command like this:
liara logs --since=1714024894

cli will print just a few logs, but it should be many.
Expected behavior
print all the logs from 1714024894 to now
Additional Context
That's because when I don't use --follow, liara cli only makes one single API call to the sever. but in case of --since, cli should do many API calls to the server in a loop

Hello,
We're thrilled to see people getting involved with Liara's open source projects!
We have a limitation when it comes to fetching logs. Retrieving all logs since X can result in a large query. To avoid this, we have added pagination. If you would like to see the most recent logs, use a larger X (meaning closer to now) or simply add --follow.

We have a limitation when it comes to fetching logs. Retrieving all logs since X can result in a large query

I completely understand why this is a heavy task to perform. However, the current implementation of liara logs cannot address many production-grade needs.
Let's say there's a bug in production in my app. I need to somehow get the logs from the last 15 minutes to start the investigation.
If I use plain Docker, this need can be easily satisfied with docker logs NAME --since 15m, but I cannot do the same with Liara CLI.

use a larger X (meaning closer to now)

Not an option. because I only get a few logs which is not enough to start an investigation

or simply add --follow

This hack works, but there's two problems:

It's slow because it will fetch the next page after one second. it may take minutes to save fairly large amount of logs.
The purpose of --follow is clearly different. I don't really want to follow logs.

Overall, I would be very happy if this business-need gets implemented.
Thanks!

Isn't it possible to continue fetching logs until the present moment or until there are no more logs available?

On the logs endpoint, we've got a direction parameter. Perhaps we could consider passing it through the CLI.
@mhemrg

How does it help?

@parishahla PTAL.

This issue got fixed!

authors: erfanium eyeamnoob mhemrg parishahla

repo: liara-cloud/cli


text:
refactor(digest:sha2): optimizing sha2 implementation

inlining/unrolling message scheduling and compression function

Intel Xeon E5-1650 v3 (Haswell, 64bit Linux):
sha256: 190 MB/s => 190 MB/s
sha512: 282 MB/s => 354 MB/s
AMD A10-7850K (Kaveri, 64bit Linux):
sha256: 120 MB/s => 151 MB/s
sha512: 182 MB/s => 244 MB/s

@homu r+

:pushpin: Commit 00abda2 has been approved by hauleth

:zap: Test exempted - status

authors: hauleth homu kazuki

repo: libOctavo/octavo


text:
Allow to set a different doc_type per model

By adding a doc_type attribute in the Elasticsearch class and use it in get_doc_type method, just like the index attribute.
The problem was mentioned in #4.

@NicolasYDDER just for your information, I added a doc_type attribute on the Elasticsearch class in the feature/add-doctype-attr branch, the tests are still passing so you are safe to use it. I will not merge it until I add a test for this functionality and update the docs though.

21ab475e70ea59269aa12058d216383873a1ab89
still needs docs/tests

repo: liberation/django-elasticsearch


text:
Correct new TraversalOrder

The correct check for a custom TraversalOrder should be that order is not a subclass of TraversalOrder and not an instance of it.

Thank you for this PR, it looks correct! I think the type annotation on ORDER_MAP should also be changed, right?

Good catch, I think it should be of Type TraversalOrder.

Awesome, thanks so much! I'll merge this into v1.1.

authors: andrewilyas sanagno

repo: libffcv/ffcv


text:
Gradle with intellij problem evaluating root project: Seems to be RoboVM

So I've tested this on a couple different project setups and have noticed that it happens everytime that no matter what platform I try to compile for I receive this error,
Error:(82, 0) Gradle: A problem occurred evaluating root project 'beta_runner'.
> com/github/jtakakura/gradle/plugins/robovm/RoboVMPlugin : Unsupported major.minor version 51.0

It appears to be an issue with RoboVMPlugin, I have no idea if this is widespread or an isolated case though.

Could you please help me? I am also facing the same issue when building an application for iOS & Desktop App.
Thanks in advance.

Please use the forum if you need help.

I get this with the latest version of Android SDK as well right now.

Error:(1, 1) A problem occurred evaluating root project 'app'.

Plugin with id 'com.android.application' not found.

authors: HimanshuSShephertz Mmarzex Tom-Ski orubel siner01

repo: libgdx/libgdx


text:
[Defect] Gdx.gl20 has no glPointSize

While it's understandable that such method has no use on OpenGL ES, on desktop it still has a role:
setting the gl_PointSize variable on a vertex shader does nothing when rendering points on desktop, the only way to increase points size is to use Gdx.gl10.glPointSize(int), but this is unusable since gl10 is null.
Should the GL20 interface have a glPointSize() method that does nothing on mobile implementation but calls LWJGL's glPointSize on desktop implementation?

I don't think that it's a good idea to add a method to the GL20 interface which is not actually part of the gles 2 spec. Especially not if it is only going to work on one platform only. Note that in the desktop launcher you do have access to all opengl (non ES) methods. See https://github.com/libgdx/libgdx/wiki/Interfacing-with-platform-specific-code.

I agree with @xoppa.

slightly related: https://github.com/libgdx/libgdx/issues/3218 (another GL command that's "missing"); so yup, in a nutshell - for consistency reasons, IMO it's best the way it is.

I get it, I'm currently using plaform specific code on my project but I thought that you'd want to know.
So, this might be closed then, thanks guys :)

authors: FyiurAmron Gtoknu MobiDevelop xoppa


text:
Sound play() method in android (AndroidSound) sometimes doesn't work in Android when sound is looping

Hello there, i find a problem that happens only in android, when i play a sound with loop flag in true (sound.setLooping) it works fine (since 1.9.11-SNAPSHOT), it retrieves the Id and then i use it to stop the sound when i need (storing Id), but in some trys it fails, i mean it generates the Id but nothing is heard, this happends sometimes like every 3 trys and is very wear, for example:
long id=sound.play(v, pitch, pan);
sound.setLooping(id, true);
//after a while..
sound.stop(id);
doing this oftten in some try it will fail (not going to hear)
then i try again and it works, and so on..
it happends to me in a Motorola One with Android 9 using 1.9.11-SNAPSHOT but it happends to me in latests versions too (1.9.5)

Maybe I'm wrong, but last time I checked the old code, it caused a memory leak.

authors: josemiguelhp shatterblast


text:
Added the ability to add new animations to an existing ModelInstance

I faced with problem when there are many files with animations and need to add them to existed ModelInstance.
I described the problem in detail here:
https://stackoverflow.com/questions/47092776/libgdx-cant-play-the-animation-on-3d-model

I think your need is reasonable but your solution has some drawbacks, mainly because the modelInstance modify the shared model :

existing model instance won't be affected
new model instances will be affected

I faced the same need but i solved it differently : I just copy animations from a model to some modelInstance as it's done in model instance creation code like this :
			ModelInstance mi; // a model instance with animations or not
			Model model; // a model with some other animations
			for(Animation anim : model.animations)
			{
				Animation newAnim = new Animation();
				newAnim.duration = anim.duration;
				newAnim.id = anim.id;
				for(NodeAnimation nodeAnim : anim.nodeAnimations)
				{
					NodeAnimation newNodeAnim = new NodeAnimation();
					newNodeAnim.node = mi.getNode(nodeAnim.node.id);
					newNodeAnim.translation = nodeAnim.translation;
					newNodeAnim.rotation = nodeAnim.rotation;
					newNodeAnim.scaling = nodeAnim.scaling;

					newAnim.nodeAnimations.add(newNodeAnim);
				}

				mi.animations.add(newAnim);
			}

Maybe this approach could be used in your addAnimation method.
What do you think ?

Yes, I agree with you.
I made some changes, now it looks clear.

Looks good. A few things though:
addXXX feels not good here, because the animations aren't added as-is, but copied instead. So modifications made to the animation after the method call wont affect the animation within the instance. Just making the copyAnimations method public seems more intuitive to me.
I'd expect that a common use-case would be to add one single animation, which is not possible with this change. So perhaps better split the method into a copyAnimation and copyAnimations method, where the latter just iterates over the animations and calls the copyAnimation method.
Also, because it's part of the public API, this needs javadocs.

Thank you for advice.
I made copyAnimation method public and split it to four methods, check the commit please.

This is exactly what I need for my project, will it be added in soon? :)

hey @mgsx-dev can you take a look at my issue #5643 and see what you think?

authors: GemmaLamont catmanjan dpproduction mgsx-dev xoppa


text:
Add redis zset driver

增加redis zset driver

这个PR进去之后应该可以把develop跟master合一下了，下个project专门做集群稳定性

果然，需要审查更改 🤣

已修改

authors: dxyinme libi

repo: libi/dcron


text:
[executor] Depend on DbReader instead of StorageRead

Motivation
So that it's possible to run the Executor against a local LibraDB.
We will also move away from the grpc- based remote db solution, this is another step to decouple the Executor with the grpc related traits.
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
existing coverage
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

:umbrella: The latest upstream changes (presumably 3b0107a8640c7c0956a16da1696692bb55945b2b) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-libra  r=wqfish

:pushpin: Commit 6b85d95 has been approved by wqfish

:hourglass: Testing commit 6b85d95be4963c9ae0a1a55dd5f099394624e2d7 with merge aa8404661225ca436d395ed9392dd1a2e438143a...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: wqfish
Pushing aa8404661225ca436d395ed9392dd1a2e438143a to master...

authors: bors-libra msmouse

repo: libra/libra


text:
[gha] check breaking tag for all commits in PR

Motivation
Land-blocking workflow fails to check [breaking] tag in all commits in a PR. This makes git log check all commit messages between master HEAD and current branch HEAD.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
auto branch is rebased on master, so git revs will always calculate the right range.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

@bors-libra r=andll

:pushpin: Commit 526a168 has been approved by andll

:hourglass: Testing commit 526a168e20d67f34650136728defe89b788d523d with merge 4fc379033e4940335d001d88339270474b7f0620...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: andll
Pushing 4fc379033e4940335d001d88339270474b7f0620 to master...

authors: bors-libra rustielin


text:
Using all possible token scopes by default for Web API requests breaks specific /web-api/ endpoints, and the /tokens endpoint a long with it

The spotify web-api breaks with specific combinations of token scopes, see #399
If you try creating a token through the spotify web console as found in the WebApihandler you'll get a 'Illegal scope' page
It appears that there's some scopes that can't be used together in a single token, and upon using that token in the spotify web api, as shown in #399, the spotify api simply returns the json model without any content, instead of an explicit error
In the current intended design of api, I could just use /tokens/{scope} to request a specific token with just a singular scope, however, because a token is being generated implicitly with ALL possible scopes, the token returned by /tokens/{scope} is the default token generated with all possible scopes, breaking certain /web-api/ endpoints, and /tokens itself, because getToken finds the first available token of the requested scope, which in this case is a token with ALL possible scopes

The only solution that currently exists is to completely avoid using any /web-api/ endpoint without specifying X-Spotify-Scope, upon calling /web-api/ without X-Spotify-Scope, a token for ALL scopes is generated, without a way to force generate a new token
Potential solution
Remove implicit token generation, and require a X-Spotify-Scope or scope in the /token request, no need to tweak the token store. Tokens will still be stored and cached, and the first token with the needed scope will still be retrieved from the token store list. The only difference is users will need to explicitly add a scope to their /web-api/ request. The issue of unsupported combinations of scopes will still remain though, so a key-value map for token storage might be a better solution. /token could take a third optional parameter, it being the key for the token store map. By default the scope could be used as the key in the store
Version/Commit
v1.6.1

Thank you for the detailed issue, I'll get to this whenever I'll have time. PRs are appreciated.

Thank you for the detailed issue, I'll get to this whenever I'll have time. PRs are appreciated.

It'd appear that something is off with key generation, using only a single scope when a key is generated internally via
    @NotNull
    public static JsonMercuryRequest<GenericJson> requestToken(@NotNull String deviceId, @NotNull String scope) {
        return new JsonMercuryRequest<>(RawMercuryRequest.get(String.format("hm://keymaster/token/authenticated?scope=%s&client_id=%s&device_id=%s", scope, KEYMASTER_CLIENT_ID, deviceId)), GenericJson.class);
    }

The returned access token doesn't work, it seems like I was wrong with compatibility between multiple scopes. This appears to be related to the actual token generation.

This appears to be related to the actual token generation.

The API used for token generation is strictly an internal API which happens to work with the Web API sometimes.

This appears to be related to the actual token generation.

The API used for token generation is strictly an internal API which happens to work with the Web API sometimes.

What would be the best out to take? I notice the length of keys generated via the web-console is quite different than the one being generated by librespot-java, is this something I could debug further, or would it be best to lay certain endpoints aside?

repo: librespot-org/librespot-java


text:
Playing an album track doesn't look like its playing in Spotify apps

I've attached a picture at the bottom of this post indicating the problem.
It seems that the context-resolve endpoint (context-resolve/v1/uri) sometimes returns the UID of a track.
It does not seem to return the uid for album tracks:

Therefeore the PlayerState's track_uid is empty, which I think the clients use to find which track is playing.
If we play the track using the official clients (desktop and web), uid is filled

But I have no idea where to find this UID. The only place I seem to be able to find it is if we do an album resolve (GraphQL endpoint). But the desktop app seems to also know this ID without doing such call (transfering state).
So it's making me believe this could be a computed property.
Does anyone know how ?
Is there even a relationship between the base62 id (spotify:track:2XkDm5m2vPowecEAAR5gmb) and this seeminly base16 id? (67d43c187351cea560aa)

I have always wondered whether the UID can be figured out in some way. So far I have ignored it.

The UID of a track is the same in the following scenarios:

Track in user's saved songs
Track in an album
Track in a user playlist IF the track only appears once

For 3. If the track appears more than once, or the playlist is spotify generated, the UID seems to be very random.
But playlists isnt' really a problem because they are returned with the context-resolve endpoint.
I will try and do more research...


text:
rename MAME 2014 assets to MAME 2015 name

This PR follows the merge of https://github.com/libretro/libretro-super/pull/940 which initiated the process.
The PRs relevant to the name update are:

MAME 2014 repo: https://github.com/libretro/mame2014-libretro/pull/73
libretro-super repo: https://github.com/libretro/libretro-super/pull/942
libretro-database repo: ~~https://github.com/libretro/libretro-database/pull/787~~ Merged
retroarch-assets repo: https://github.com/libretro/retroarch-assets/pull/289

@markwkidd Please resolve merge conflicts.

@orfy OK, I have fixed the conflicts, thank you

@markwkidd some of the icons have numbers in them, you can't just rename those, they have to be modified and re-exported

I'm seeing this message now after I earlier saw the PR to my personal repo and wrote there. Please let me know how you would like me to prefer to proceed.

i sent the pr to your repo so it it will be correct without another pr

Thanks for helping me with this. I merged your PR but there are two conflicting files

git remote add upstream https;//github.com/libretro/retroarch-assets
git fetch upstream
git rebase upstream/master
git add .
git rebase --continue
git push

better use git rebase -s ours upstream/master

That added a lot of commits to this PR but it doesn't have any conflicts at least!

@alfrix I really appreciate your willingness to work with me on these submissions after I just showed up one day! I'm going to close this issue because I don't have anything else to offer that will fix my previous work or improve on what other folks have contributed.
In the future however as we add new games to MAME 2003-Plus I will probably open an issue here to coordinate with you on the thumbnails. There are already about 30-40 new games I need to add thumbnails for since my last update but I may wait till it's a few more before I go through that.

authors: alfrix markwkidd ofry

repo: libretro/retroarch-assets


text:
[FEATURE] Multisig Support

Greetings
first of all thank you for creating this awesome library. I just started diving into Bitcoin development (and Golang) recently and this library, on top of others, is a big help when getting things done the Bitcoin way.
However, one feature that has now come to my attention, as I am trying to solve some more complex problems is Multi Signature Transactions.
Would it be possible for you guys to implement those into the library?
So far I've found an old repository from 2014 (https://github.com/soroushjp/go-bitcoin-multisig) that does it, but it's outdated and many dependencies are broken. It can perhaps serve as a starting point on how to implement things.
I thought about trying to implement it myself, however, I am still to green when it comes to Bitcoin, and I think to keep things secure and usable in the long run, it's probably better if I ask you guys.

hey @betatester899, thanks for reaching out. We actually had some code doing some multisig stuff with electrumsv in the past but got rid of it/commented it out when the p2sh stuff got messy and so was removed. We will be adding bare multisig and accumulator multisig bscripts and doing things properly sometime soon.

Epic! Looking forward to it.

repo: libsv/go-bt

license: ISC


text:
darwin: abort() if (un)locking fs mutex fails

The pthread_mutex_lock() and pthread_mutex_unlock() calls logically
cannot fail in uv__fs_write() but let's check the return value anyway:
cosmic rays and memory corruption do happen.
R=@saghul - for when you're back.

LGTM

authors: bnoordhuis saghul

repo: libuv/libuv


text:
aperture: allow command line flags and add config file

This PR updates aperture to allow specifying configuration options on the command line and adds an optional configfile flag to point to a custom location (rather than the default aperture.yaml).
This change relaxes our requirement that the default aperture.yaml exists, since we could have all of our options specified inline. It also tightens up the validation we require on our config to ensure that we start up with the minimum required config.

@ellemouton @guggero will you take a look? Don't have perms to request review.

Diff updating --help handling here.

repo: lightninglabs/aperture


text:
tapdb: fix time zone issue with timestamps

Fixes an issue where unit tests would fail when being run in certain time zones.

Added a commit message to clarify on this.
It looks like we could customize this by setting ?_time_format=xyz in the DSN query string when initializing the SQLite database (https://gitlab.com/cznic/sqlite/-/blob/v1.25.0/sqlite.go#L347-355). But then we would have different behavior between SQLite and Postgres.
So I think we'll eventually want to solve this on the sqlc level?

repo: lightninglabs/taproot-assets


text:
Regression sshd server

I have embedded in my app the sshd server.
With version Ammonite 1.0.3 it works ok and it's a very useful tool (thanks).
With version 1.1.2, the ssh session ends shortly after the login.
Good working:
"com.lihaoyi" %% "ammonite-repl" % "1.0.3" % Test cross CrossVersion.full,
"com.lihaoyi" % "ammonite-sshd" % "1.0.3" cross CrossVersion.full

Not working:
"com.lihaoyi" %% "ammonite-repl" % "1.1.2" % Test cross CrossVersion.full,
"com.lihaoyi" % "ammonite-sshd" % "1.1.2" cross CrossVersion.full

Version 1.2.1 also quits session prematurely.

I think this is same as #859 ?

I think it can be the cause.

With version 1.7.4 I get an infinite loop
java.lang.RuntimeException: Nonzero exit value: 1
  scala.sys.package$.error(package.scala:30)
  scala.sys.process.ProcessBuilderImpl$AbstractBuilder.slurp(ProcessBuilderImpl.scala:138)
  scala.sys.process.ProcessBuilderImpl$AbstractBuilder.$bang$bang(ProcessBuilderImpl.scala:108)
  ammonite.terminal.TTY$.stty(Utils.scala:114)
  ammonite.terminal.TTY$.init(Utils.scala:97)
  ammonite.terminal.Terminal$.readLine(Terminal.scala:41)
  ammonite.repl.AmmoniteFrontEnd.readLine(AmmoniteFrontEnd.scala:131)
  ammonite.repl.AmmoniteFrontEnd.action(AmmoniteFrontEnd.scala:25)
  ammonite.repl.Repl.$anonfun$action$2(Repl.scala:184)
  ammonite.util.Catching.flatMap(Res.scala:115)
  ammonite.repl.Repl.action(Repl.scala:168)
  ammonite.repl.Repl.loop$1(Repl.scala:208)
  ammonite.repl.Repl.run(Repl.scala:223)
  ammonite.Main.$anonfun$run$1(Main.scala:224)
  scala.Option.getOrElse(Option.scala:189)
  ammonite.Main.run(Main.scala:212)
  ammonite.sshd.SshdRepl$.$anonfun$runRepl$1(SshdRepl.scala:74)
  scala.util.DynamicVariable.withValue(DynamicVariable.scala:62)
  scala.Console$.withErr(Console.scala:196)
  ammonite.sshd.util.Environment$.$anonfun$withEnvironment$2(Environment.scala:39)
  scala.util.DynamicVariable.withValue(DynamicVariable.scala:62)
  scala.Console$.withOut(Console.scala:167)
  ammonite.sshd.util.Environment$.$anonfun$withEnvironment$1(Environment.scala:38)
  scala.util.DynamicVariable.withValue(DynamicVariable.scala:62)
  scala.Console$.withIn(Console.scala:230)
  ammonite.sshd.util.Environment$.withEnvironment(Environment.scala:37)
  ammonite.sshd.SshdRepl$.ammonite$sshd$SshdRepl$$runRepl(SshdRepl.scala:63)
  ammonite.sshd.SshdRepl.$anonfun$sshd$1(SshdRepl.scala:31)
  ammonite.sshd.SshdRepl.$anonfun$sshd$1$adapted(SshdRepl.scala:31)
  ammonite.sshd.ShellSession$$anon$1.run(ShellSession.scala:58)

authors: DavidPerezIngeniero fyi-coursera

repo: lihaoyi/Ammonite


text:
implicits import needs more traits mixed in.

This comes up every now and then in the gitter:

No idea why. In general if I don’t want to pollute the namespace, how should I import scalatags?
I wonder why is it not working, maybe I should add some imports?

Basically, implicits doesn't have enough traits to be used independently like all or short.
Instead of just extending Aggregate, it should also extend DataConverters and Util. That last one is tricky, though, because you can only import ._ from a single object that extends Util(or Cap) or lose implicits to ambiguity. The fact that each of tags, tags2, attrs, styles, styles2, svgTags, svgAttrs extends Cap is then extremely limiting. Sensible sounding imports like the following break:
import svgAttrs._
import svgTags._

import implicits._ //Assuming we make this mix in the implicits from Util, this breaks
import tags._

I suggest refactoring these packages so that only all, short, and implicits extend Util.
I have a proof of concept diff for just the refactor of tags and implicits. The basic idea is to have most packages import from a member of type Util rather than extending it. If that looks like the right direction, I can apply that to the rest and turn it into a PR.

Since this has brought up again via #134, I should share what I've learned.
I've tried removing Util from various objects. This worked fine for tags and attrs, but gets really messy for styles. See my WIP here: https://github.com/stewSquared/scalatags/tree/implicits-import
A better option might be to dig into what's causing the implicits to fail in the first place. I would expect implicit shadowing to solve the problem, since everything that extends Cap/Util, should have implicits of the same name and type. But implicit shadowing seems to be failing. I suspect has something to do with the roundabout inheritance/mixing happening here. The implicits no longer have the same type because Frag, Modifier, etc., all have different types in these objects, causing shadowing to fail.
Maybe someone can come up with a minimal example?

I've just bumped into this again; it seems that even small things like import scalatags.JsDom.svgAttrs._ also pulls in implicits, which can conflict. I think we should get rid of most of the implicits except for those in .all and .implicits, to avoid conflict

authors: lihaoyi stewSquared

repo: lihaoyi/scalatags


text:
Stage 4 : Docker and container (optional)

[ ] Get Started with Docker
[ ] new an accout of docker hub
[ ] Install Docker in your system(for mac and linux user )
[ ] Run docker service
[ ] pull a existing image from docker hub
[ ] try docker-run command

[x] Get Started with Docker
[x] new an accout of docker hub
[x] Install Docker in your system(for mac and linux user )
[x] Run docker service
[x] pull a existing image from docker hub
[x] try docker-run command

authors: Ninomoriaty likelet

repo: likelet/multiexseq


text:
AMD Ryzen 7 8845HS w/ Radeon 780M Graphics run 0.3.10 error="llama runnerprocess has terminated: exit status 0xc0000005"

What is the issue?
AMD Ryzen 7 8845HS w/ Radeon 780M Graphics run 0.3.10 error="llama runnerprocess has terminated: exit status 0xc0000005"
PS C:\Users\kkk\Downloads\ollama-windows-amd64_for_amd> .\ollama.exe serve
2024/09/11 15:03:47 routes.go:1125: INFO server config env="map[CUDA_VISIBLE_DEVICES: GPU_DEVICE_ORDINAL: HIP_VISIBLE_DEVICES: HSA_OVERRIDE_GFX_VERSION: OLLAMA_DEBUG:false OLLAMA_FLASH_ATTENTION:false OLLAMA_GPU_OVERHEAD:0 OLLAMA_HOST:http://127.0.0.1:11434 OLLAMA_INTEL_GPU:false OLLAMA_KEEP_ALIVE:5m0s OLLAMA_LLM_LIBRARY: OLLAMA_LOAD_TIMEOUT:5m0s OLLAMA_MAX_LOADED_MODELS:0 OLLAMA_MAX_QUEUE:512 OLLAMA_MODELS:C:\Users\kkk\.ollama\models OLLAMA_NOHISTORY:false OLLAMA_NOPRUNE:false OLLAMA_NUM_PARALLEL:0 OLLAMA_ORIGINS:[http://localhost https://localhost http://localhost:* https://localhost:* http://127.0.0.1 https://127.0.0.1 http://127.0.0.1:* https://127.0.0.1:* http://0.0.0.0 https://0.0.0.0 http://0.0.0.0:* https://0.0.0.0:* app://* file://* tauri://*] OLLAMA_RUNNERS_DIR:C:\Users\kkk\Downloads\ollama-windows-amd64_for_amd\lib\ollama\runners OLLAMA_SCHED_SPREAD:false OLLAMA_TMPDIR: ROCR_VISIBLE_DEVICES:]"
time=2024-09-11T15:03:47.869+08:00 level=INFO source=images.go:753 msg="total blobs: 0"
time=2024-09-11T15:03:47.869+08:00 level=INFO source=images.go:760 msg="total unused blobs removed: 0"
time=2024-09-11T15:03:47.869+08:00 level=INFO source=routes.go:1172 msg="Listening on 127.0.0.1:11434 (version 0.3.10-0-g486ae43)"
time=2024-09-11T15:03:47.870+08:00 level=INFO source=payload.go:44 msg="Dynamic LLM libraries [cpu_avx2 rocm_v6.1 cpu cpu_avx]"
time=2024-09-11T15:03:47.870+08:00 level=INFO source=gpu.go:200 msg="looking for compatible GPUs"
time=2024-09-11T15:03:48.498+08:00 level=INFO source=types.go:107 msg="inference compute" id=0 library=rocm variant="" compute=gfx1103 driver=6.1 name="AMD Radeon 780M Graphics" total="9.0 GiB" available="8.9 GiB"
[GIN] 2024/09/11 - 15:04:02 | 200 |            0s |       127.0.0.1 | HEAD     "/"
[GIN] 2024/09/11 - 15:04:36 | 200 |     18.3065ms |       127.0.0.1 | POST     "/api/show"
time=2024-09-11T15:04:36.777+08:00 level=INFO source=sched.go:185 msg="one or more GPUs detected that are unable to accurately report free memory - disabling default concurrency"
time=2024-09-11T15:04:36.799+08:00 level=INFO source=sched.go:715 msg="new model will fit in available VRAM in single GPU, loading" model=C:\Users\kkk.ollama\models\blobs\sha256-8de95da68dc485c0889c205384c24642f83ca18d089559c977ffc6a3972a71a8 gpu=0 parallel=4 available=9562652672 required="1.2 GiB"
time=2024-09-11T15:04:36.799+08:00 level=INFO source=server.go:101 msg="system memory" total="23.3 GiB" free="12.9 GiB"free_swap="13.2 GiB"
time=2024-09-11T15:04:36.799+08:00 level=INFO source=memory.go:326 msg="offload to rocm" layers.requested=-1 layers.model=25 layers.offload=25 layers.split="" memory.available="[8.9 GiB]" memory.gpu_overhead="0 B" memory.required.full="1.2GiB" memory.required.partial="1.2 GiB" memory.required.kv="96.0 MiB" memory.required.allocations="[1.2 GiB]" memory.weights.total="288.2 MiB" memory.weights.repeating="150.3 MiB" memory.weights.nonrepeating="137.9 MiB" memory.graph.full="298.5 MiB" memory.graph.partial="405.0 MiB"
time=2024-09-11T15:04:36.803+08:00 level=INFO source=server.go:391 msg="starting llama server" cmd="C:\Users\kkk\Downloads\ollama-windows-amd64_for_amd\lib\ollama\runners\rocm_v6.1\ollama_llama_server.exe --model C:\Users\kkk\.ollama\models\blobs\sha256-8de95da68dc485c0889c205384c24642f83ca18d089559c977ffc6a3972a71a8 --ctx-size 8192 --batch-size 512 --embedding --log-disable --n-gpu-layers 25 --parallel 4 --port 55978"
time=2024-09-11T15:04:36.872+08:00 level=INFO source=sched.go:450 msg="loaded runners" count=1
time=2024-09-11T15:04:36.872+08:00 level=INFO source=server.go:590 msg="waiting for llama runner to start responding"
time=2024-09-11T15:04:36.873+08:00 level=INFO source=server.go:624 msg="waiting for server to become available" status="llm server error"
INFO [wmain] build info | build=3661 commit="8962422b" tid="1968" timestamp=1726038304
INFO [wmain] system info | n_threads=8 n_threads_batch=8 system_info="AVX = 1 | AVX_VNNI = 0 | AVX2 = 0 | AVX512 = 0 | AVX512_VBMI = 0 | AVX512_VNNI = 0 | AVX512_BF16 = 0 | FMA = 1 | NEON = 0 | SVE = 0 | ARM_FMA = 0 | F16C = 1 | FP16_VA = 0 | WASM_SIMD = 0 | BLAS = 1 | SSE3 = 1 | SSSE3 = 1 | VSX = 0 | MATMUL_INT8 = 0 | LLAMAFILE = 1 | " tid="1968" timestamp=1726038304 total_threads=16
INFO [wmain] HTTP server listening | hostname="127.0.0.1" n_threads_http="15" port="55978" tid="1968" timestamp=1726038304
llama_model_loader: loaded meta data with 21 key-value pairs and 290 tensors from C:\Users\kkk.ollama\models\blobs\sha256-8de95da68dc485c0889c205384c24642f83ca18d089559c977ffc6a3972a71a8 (version GGUF V3 (latest))
llama_model_loader: Dumping metadata keys/values. Note: KV overrides do not apply in this output.
llama_model_loader: - kv   0:                       general.architecture str              = qwen2
llama_model_loader: - kv   1:                               general.name str              = Qwen2-0.5B-Instruct
llama_model_loader: - kv   2:                          qwen2.block_count u32              = 24
llama_model_loader: - kv   3:                       qwen2.context_length u32              = 32768
llama_model_loader: - kv   4:                     qwen2.embedding_length u32              = 896
llama_model_loader: - kv   5:                  qwen2.feed_forward_length u32              = 4864
llama_model_loader: - kv   6:                 qwen2.attention.head_count u32              = 14
llama_model_loader: - kv   7:              qwen2.attention.head_count_kv u32              = 2
llama_model_loader: - kv   8:                       qwen2.rope.freq_base f32              = 1000000.000000
llama_model_loader: - kv   9:     qwen2.attention.layer_norm_rms_epsilon f32              = 0.000001
llama_model_loader: - kv  10:                          general.file_type u32              = 2
llama_model_loader: - kv  11:                       tokenizer.ggml.model str              = gpt2
llama_model_loader: - kv  12:                         tokenizer.ggml.pre str              = qwen2
llama_model_loader: - kv  13:                      tokenizer.ggml.tokens arr[str,151936]  = ["!", """, "#", "$", "%", "&", "'", ...
llama_model_loader: - kv  14:                  tokenizer.ggml.token_type arr[i32,151936]  = [1, 1, 1, 1, 1, 1, 1, 1, 1,1, 1, 1, ...
llama_model_loader: - kv  15:                      tokenizer.ggml.merges arr[str,151387]  = ["Ġ Ġ", "ĠĠ ĠĠ", "i n", "Ġ t",...
llama_model_loader: - kv  16:                tokenizer.ggml.eos_token_id u32              = 151645
llama_model_loader: - kv  17:            tokenizer.ggml.padding_token_id u32              = 151643
llama_model_loader: - kv  18:                tokenizer.ggml.bos_token_id u32              = 151643
llama_model_loader: - kv  19:                    tokenizer.chat_template str              = {% for message in messages %}{% if lo...
llama_model_loader: - kv  20:               general.quantization_version u32              = 2
llama_model_loader: - type  f32:  121 tensors
llama_model_loader: - type q4_0:  168 tensors
llama_model_loader: - type q8_0:    1 tensors
time=2024-09-11T15:05:04.564+08:00 level=INFO source=server.go:624 msg="waiting for server to become available" status="llm server not responding"
time=2024-09-11T15:05:04.820+08:00 level=ERROR source=sched.go:456 msg="error loading llama server" error="llama runnerprocess has terminated: exit status 0xc0000005"
[GIN] 2024/09/11 - 15:05:04 | 500 |   28.6405407s |       127.0.0.1 | POST     "/api/chat"
OS
Windows
GPU
AMD
CPU
AMD
Ollama version
0.3.10

I have tested it on my other 7840HS device without any issues

repo: likelovewant/ollama-for-amd


text:
what is self_attn.head_out

Dear, I notice that you need to extract head attention in utils.py (function: get_llama_activations_bau) using the Tracedict method
However, there is no attribute named "model.layers.{i}.self_attn.head_out" in the llama model (actually you can only get q,k,v proj, and o proj).
From my understanding, I guess the activations shall be the output of <softmax(q^T*k)v> right?, i.e., head output before projecting back.
Bests,

baukit can retain module's input, we can modify the trace code as following:
# change from self_attn.head_out to self_attn.o_proj
HEADS = [f"model.layers.{i}.self_attn.o_proj" for i in range(model.config.num_hidden_layers)]

with TraceDict(model, HEADS+MLPS, retain_input=True) as ret:
    output = model(prompt, output_hidden_states = True)
    ...
    head_wise_hidden_states = [ret[head].input.squeeze().detach().cpu() for head in HEADS]

@Sanster Thanks for letting me know!

authors: Sanster likenneth tjlujianqiao


text:
order and tabulation error

At the following lines
https://github.com/likyoo/open-cd/blob/1e03f6383f2a36f09f7c841ab0ecaa86ff86f3f7/opencd/datasets/transforms/loading.py#L385
We should replace
        imgs = []
        if self.to_float32:
            for img in results["img"]:
                img = img.astype(np.float32)
                imgs.append(img)

the following by the folowing:
        imgs = []
        for img in results["img"]:
            if self.to_float32:
                img = img.astype(np.float32)
            imgs.append(img)

Thanks for pointing this out!

If possible, could you create a PR?

fixed

authors: likyoo londumas

repo: likyoo/open-cd


text:
No module named 'mmcv'

Hey I'm getting this error on running infer command:
Traceback (most recent call last):
  File "tools/test.py", line 10, in <module>
    import mmcv
ModuleNotFoundError: No module named 'mmcv'

and when i'm install mmcv, i'm getting this error
Collecting mmcv
  Using cached mmcv-2.0.0.tar.gz (473 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [12 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/private/var/folders/ff/1k6ltqsd42gb85qy9gx5jvyr0000gn/T/pip-install-z3afg0xg/mmcv_5de6ac3785ee44dd94dd614be11c4631/setup.py", line 10, in <module>
          import torch
        File "/Users/sushantmishra/miniconda3/envs/changeDetection/lib/python3.8/site-packages/torch/__init__.py", line 1146, in <module>
          _C._initExtension(manager_path())
        File "/Users/sushantmishra/miniconda3/envs/changeDetection/lib/python3.8/site-packages/torch/cuda/__init__.py", line 15, in <module>
          from . import profiler
        File "/Users/sushantmishra/miniconda3/envs/changeDetection/lib/python3.8/site-packages/torch/cuda/profiler.py", line 3, in <module>
          from . import cudart, check_error
      ImportError: cannot import name 'cudart' from partially initialized module 'torch.cuda' (most likely due to a circular import) (/Users/sushantmishra/miniconda3/envs/changeDetection/lib/python3.8/site-packages/torch/cuda/__init__.py)
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

System : MacOS 13.3.1 (chip M1)

see mmcv document or issues ?

Hey I'm getting this error on running infer command:
Traceback (most recent call last):
  File "tools/test.py", line 10, in <module>
    import mmcv
ModuleNotFoundError: No module named 'mmcv'

and when i'm install mmcv, i'm getting this error
Collecting mmcv
  Using cached mmcv-2.0.0.tar.gz (473 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [12 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/private/var/folders/ff/1k6ltqsd42gb85qy9gx5jvyr0000gn/T/pip-install-z3afg0xg/mmcv_5de6ac3785ee44dd94dd614be11c4631/setup.py", line 10, in <module>
          import torch
        File "/Users/sushantmishra/miniconda3/envs/changeDetection/lib/python3.8/site-packages/torch/__init__.py", line 1146, in <module>
          _C._initExtension(manager_path())
        File "/Users/sushantmishra/miniconda3/envs/changeDetection/lib/python3.8/site-packages/torch/cuda/__init__.py", line 15, in <module>
          from . import profiler
        File "/Users/sushantmishra/miniconda3/envs/changeDetection/lib/python3.8/site-packages/torch/cuda/profiler.py", line 3, in <module>
          from . import cudart, check_error
      ImportError: cannot import name 'cudart' from partially initialized module 'torch.cuda' (most likely due to a circular import) (/Users/sushantmishra/miniconda3/envs/changeDetection/lib/python3.8/site-packages/torch/cuda/__init__.py)
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

System : MacOS 13.3.1 (chip M1)

Hello, have you run through this open CD yet

authors: Sushant-summit kk-kaii likyoo


text:
git repo: rename examples to templates (will break existing hyperlinks)

https://github.com/lima-vm/lima/tree/master/examples
This will break existing hyperlinks, but probably acceptable in v1.0

Some of the examples are broken anyway, so any users of older releases will need to use older versions.
https://github.com/lima-vm/lima/tree/v0.23.2/examples

authors: AkihiroSuda afbjorklund

repo: lima-vm/lima


text:
Скласти інтро

Скласти інтро (вступ), де в 2-4 реченнях описати, що замовник робить, що подобається робити, що хочеться робити краще, що важливо робити, тощо.

― I do not compete with others, the only competition that challenges me is myself. As a fighter, friend and an employee I am known as contemplative, tortured and driven.


text:
Sample notes for issuance of temp creds for S3

@satra @kabilar @yarikoptic
See README.md and scripts -- very brief proof-of-concept for async issuance of temp creds -- could package it into a CLI option for a user to bypass minting of presigned URLs and access data as fast as possible.

Is my understanding correct?

such functionality for minting temp cred would reside in dandi-archive which  has main AWS  IAM credentials
dandi-archive, through API (which endpoint?) would produce a full bundle of 4 fields and share with dandi-cli for an authorized session :

            return {
                "AccessKeyId": credentials['AccessKeyId'],
                "SecretAccessKey": credentials['SecretAccessKey'],
                "SessionToken": credentials['SessionToken'],
                "Expiration": credentials['Expiration']
            }

that AccessKeyId and SecretAccessKey would not be the same as the "main AWS IAM", and would be short lived, client would need to re-request them upon Expiration.

Would be nice to complement example with some use of those credentials for download

Is my understanding correct?

such functionality for minting temp cred would reside in dandi-archive which  has main AWS  IAM credentials
dandi-archive, through API (which endpoint?) would produce a full bundle of 4 fields and share with dandi-cli for an authorized session :

            return {
                "AccessKeyId": credentials['AccessKeyId'],
                "SecretAccessKey": credentials['SecretAccessKey'],
                "SessionToken": credentials['SessionToken'],
                "Expiration": credentials['Expiration']
            }

that AccessKeyId and SecretAccessKey would not be the same as the "main AWS IAM", and would be short lived, client would need to re-request them upon Expiration.

Would be nice to complement example with some use of those credentials for download

Yep, your understand is correct! Theoretically, you could tie the endpoint for providing the temp creds to be linked to a user's DANDI_API_KEY, etc.
The example already has "download" operations provided, as s3:GetObject is included in the IAM policy

Such approach would provide "blanket" access to the resource (well -- as wide as iam policy prescribes), so would work for LINC or any other deployment where overall access to the archive should be "gated" but would not be applicable to any aspect of current DANDI access permission schemes (public and embargoed), correct?

You could issue temporary IAM policies and roles on a per-embargoed-dandiset basis -- engineering would be a bit more complex, but you could make this more defined rather than a blanket use case.

You could issue temporary IAM policies and roles on a per-embargoed-dandiset basis -- engineering would be a bit more complex, but you could make this more defined rather than a blanket use case.

how would you see that feasible given that we do not have a "prefix" per dandiset, and blobs and zarrs are in their respective "keys" without any per-dandiset common prefix?

You could issue temporary IAM policies and roles on a per-embargoed-dandiset basis -- engineering would be a bit more complex, but you could make this more defined rather than a blanket use case.

how would you see that feasible given that we do not have a "prefix" per dandiset, and blobs and zarrs are in their respective "keys" without any per-dandiset common prefix?

I could derive the S3 sub-directory value from the dandiset's assetSummary outputs

how would you see that feasible given that we do not have a "prefix" per dandiset, and blobs and zarrs are in their respective "keys" without any per-dandiset common prefix?

I could derive the S3 sub-directory value from the dandiset's assetSummary outputs

sorry, I am not following how assetSummary could be used here. What I meant is that actual content is spread across all the folders
❯ dandi ls -f json_pp --metadata assets -r DANDI:000029 2>/dev/null | grep 'blobs/'
        "https://dandiarchive.s3.amazonaws.com/blobs/8e5/a7b/8e5a7b66-7608-421c-8f2a-bbb2f5a2cc5a"
        "https://dandiarchive.s3.amazonaws.com/blobs/031/7cf/0317cf5a-4047-4e19-aae1-4f7b7434d2d7"
        "https://dandiarchive.s3.amazonaws.com/blobs/56f/5b8/56f5b879-e5fa-476c-9893-dab482f66b3d"
        "https://dandiarchive.s3.amazonaws.com/blobs/031/7cf/0317cf5a-4047-4e19-aae1-4f7b7434d2d7"
        "https://dandiarchive.s3.amazonaws.com/blobs/e72/88a/e7288a2c-444c-42c5-b7bb-9a58c728992b"
        "https://dandiarchive.s3.amazonaws.com/blobs/c40/57c/c4057c5e-7af5-4370-878f-ccfc971aeba4"
        "https://dandiarchive.s3.amazonaws.com/blobs/180/9f5/1809f541-1cb1-48b8-b916-9a696bab488d"
        "https://dandiarchive.s3.amazonaws.com/blobs/2db/af0/2dbaf0fd-5003-4a0a-b4c0-bc8cdbdb3826"
        "https://dandiarchive.s3.amazonaws.com/blobs/2fd/746/2fd7464f-5459-4c96-a938-27cf13f4d330"

and this is tiny one -- try for 000026 ;)

Ah good point -- I see what you are saying (I'm watching 0000026 stream the output right now 😂 ) -- in that case (to the point of your output here), we would have to loop and gather the blobs/<values-here> and then construct the IAM Policy, unless there is some form of tagging mechanism we could include to contain those sub-directories in singular place
I guess this solution would work well for zarr....non-zarr might be tricky....will have to think more...

I guess this solution would work well for zarr....non-zarr might be tricky....will have to think more...

it works well for a "single zarr". For a dandiset with lots of zarrs (and @satra aims all nwbs to become zarrs ;) ) -- you get to the same issue as with 000026. Even now 000108 has already thousands of zarrs.
Tagging -- I thought about that too but would be tricky as well since blobs are shared across dandisets. Ensuring aligned tagging would be non-trivial.

authors: aaronkanzer yarikoptic

repo: lincbrain/linc-zarr-testing


text:
copier update run

Copier update was run to pull in the latest changes from the python-project-template

Codecov Report

Merging #48 (3985eed) into main (1f48906) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   81.12%   81.12%
=======================================
  Files           6        6
  Lines         408      408
=======================================
  Hits          331      331
  Misses         77       77

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

authors: codecov-commenter dougbrn

repo: lincc-frameworks/lsstseries


text:
Add StreamMessage.endWith(finalizer)

Related issue #4816
Motivation:

As a future work of https://github.com/line/armeria/pull/4727,
users might want to dynamically emit the last message depending on whether the upstream publisher completes successfully or exceptionally.

On #4816, it's good to add StreamMessage.endWith(finalizer)

Modifications:

Add StreamMessage.endWith(finalizer)

Result:

Closes #4816
Now user can dynamically emit the last value depending on whether the StreamMessage completes successfully or exceptionally by using StreamMessage.endWith(finalizer)

Thanks a lot for adding this nice feature, @injae-kim! 🚀 🚀 🚀

authors: injae-kim minwoox

repo: line/armeria


text:
Inject a query string parameter as an annotated method argument

Related to #580
Motivation:
The other framework, such as Spring framework, provides query string parameter injection basically.
So it is better to support the feature on Armeria so that a user writes less codes.
We are going to support parameter injection for a query string of HTTP GET requests and url-encoded form data of HTTP POST requests.
Modifications:

Add @Param annotation for parameter injection.
Add HttpParameters class to inject every parameters.
Replace @PathParam with @Param annotation. @PathParam is removed.
Respond 400 Bad Request if the request has not sufficient arguments or has an invalid argument. (was: 500 Internal Server Error)
Allow path pattern as a value of HTTP method annotations. e.g, @Get("/path")
Add @Optional annotation to specify an optional parameter and its default value. e.g, @Param("name") @Optional("thomas") String name

Result:

A user is able to get parameter easily on his/her annotated service methods.

@trustin I will ping you again, after merging @PathParam and @Param annotations.

Modifications:

Replace @PathParam with @Param annotation. @PathParam is removed.
Respond 400 Bad Request if the request has not sufficient arguments or has an invalid argument. (was: 500 Internal Server Error)

Modifications:

Allow path pattern as a value of HTTP method annotations. e.g, @Get("/path")
Add @Optional annotation to specify an optional parameter and its default value. e.g, @Param("name") @Optional("thomas") String name

Modifications:

Add HttpParameters class and replace ParamMap with HttpParameters so that a user can use convenient methods of Headers.
Change some method names and variable names.

@trustin @minwoox PTAL

Modifications:

Split HttpParameters class into HttpParameters interface and DefaultHttpParameters class.

Thanks a lot, @hyangtack !

authors: hyangtack trustin


text:
Backport the site improvements from Armeria

Use the 'api' and 'parsed_literal_highlight' extensions
Update the CSS

Codecov Report

Merging #208 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   64.35%   64.32%   -0.04%
==========================================
  Files         271      271
  Lines        9695     9695
  Branches     1098     1098
==========================================
- Hits         6239     6236       -3
- Misses       2822     2826       +4
+ Partials      634      633       -1

Impacted Files
Coverage Δ

...centraldogma/server/internal/api/WatchService.java
74.07% <0%> (-7.41%)
:arrow_down:

.../centraldogma/internal/client/AbstractWatcher.java
51.11% <0%> (-2.97%)
:arrow_down:

...erver/internal/mirror/DefaultMirroringService.java
67.05% <0%> (-1.18%)
:arrow_down:

...internal/replication/ZooKeeperCommandExecutor.java
71.94% <0%> (+0.66%)
:arrow_up:

...rver/internal/command/CreateRepositoryCommand.java
64.28% <0%> (+14.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c8b1a...21bc33c. Read the comment docs.

Thanks :-)

authors: codecov-io trustin

repo: line/centraldogma


text:
Updating DP0.2 QA to use the detect_isPrimary flag

Updating DP0.2 QA scripts to use the detect_isPrimary flag, and include in the notebook a markdown indicating that we are using this flag.
Update - October 21, 2024
The scripts are based on the DP0.2 object skinny table, but the corresponding files don't have the column detect_isPrimary. So, the skinny tables must be regenerated including this flag, and including effects such as deredening.  As the person responsible for doing this is Julia, this issue will be marked as blocked until she return from vacation.

Oii, @gschwend! Depois dá uma olhada nisso aqui, quando voltar.

repo: linea-it/pz-compute


text:
Buttons cannot be customized: Can we make them generic over a containing widget?

As it stands, the current implementation of widget::Button cannot be meaningfully customized. Some things that would be nice:

Containing other visual cues, such as a icon
Increasing the size for buttons that are meant to be prominent

Proposal:
The current implementation nests a Label<T> but aside from Button::dynamic() (which we can keep as its a builder method) doesn't do anything label-specific in layout/paint. What if we made Button generic over its contained widget?
That would allow us to keep the button-specific logic we know and love (the hovering, rounded edges, click visuals etc) but enable custom contents as well as some control over sizing.
Happy to send a PR if this works.

I agree, it would be nice to have a clearer strat on what the next-gen improvements & patterns are across our widget base. Agree that discussion might make more sense as a supplementary issue. Do you have something in mind?
At least for this issue around buttons, I'm fairly confident that this fits the existing model of composing widgets within other widgets through a builder method, delegating the non-core events/logic down to descendant widgets while handling whats important for itself (in a buttons case, thats the hover effect, the rounded corners, and the on_click handler).

I've popped the comment above into a new issue (#2160) – if you have any thoughts regarding the above, do add them there as well!

repo: linebender/druid


text:
add a PaintBrush type

I'm reminded by #523 of something we'd talked about a little while ago, and might as well have an issue for. There is currently a PaintBrush type in piet, which is a way of representing disparate different things that act like colors; the idea is that we can treat colors or gradients equivalently for the sake of our API.
@futurepaul brought up a good point, which is that it would be nice if we could treat env/theme keys as colors, where appropriate, so that you could write,
let my_widget = TextBox::raw().padding(5.0).background(theme::BACKGROUND_LIGHT);

And then have your color be determined by the value of that key at runtime.
I think we can do this, and I think it's pretty simple. I propose that we add a type to druid, also called PaintBrush, which should look like this:
pub enum PaintBrush {
    Concrete(piet::PaintBrush),
    Key(Key<Color>),
    // other variants possible
}

And then we should be able to take one of these types, pass it an Env, and get something we can actually paint, like:
impl PaintBrush {
    fn resolve(&self, env: &Env) -> piet::PaintBrush { ... }
}

The idea is that a method like Container::background would take as its argument impl Into<PaintBrush>, and so you could then pass it either an actual color/gradient or a key that could be resolved to a color/gradient at runtime.
This isn't too tricky, but it does require some understanding of the type system and of how Env works, but not much more than that.

I have this working for Key<Color>, having a lifetime issue with Key<LinearGradient>

push a branch and we can take a look?

With #592 merged, is this still relevant? KeyOrValue is ubiquitous in the codebase now.

authors: PoignardAzur cmyr futurepaul


text:
Account -> FungibleAccount on UI

Motivation
GraphQL name changed, so this also needs to change
Proposal
Change name in UIs
Test Plan
Successfully used the UIs

#2020  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andresilva91 and the rest of your teammates on  Graphite

@andresilva91 @christos-h Consider backporting the fix to the devnet branch next time. (I suppose you did for @christos-h' s example repo.)

repo: linera-io/linera-protocol


text:
无法断点下载

修改Demo TasksManagerDemoActivity运行会发现只有url2能够断点下载，url1和Url3无法断点下载，暂停继续后从0开始
String url1 = "http://219.128.78.33/apk.r1.market.hiapk.com/data/upload/2015/05_20/14/com.speedsoftware.rootexplorer_140220.apk";
        String url2 = "http://anzhuo.webdown.paojiao.cn/game/6cb/ab7/cb92a447231d2865d6536b1b32/com.wistone.war2victory_20150909103114_2.8.1_build_16302_wst.apk";
        String url3 = "http://61.144.207.146:8081/11fe58ea-97e8-4452-bff6-59bdc0fcbde2/2001/7d/d8/7dd8739b-fc8e-43fe-9b76-6612838453a6/kfid/422201/ctrip.android.view_100429.apk";
        private void initDemo() {
            if (modelList.size() <= 0) {
//                final int demoSize = 16;
//                for (int i = 0; i < demoSize; i++) {
//                    final String url = Constant.URLS[i];
//                    addTask(url);
//                }

                addTask(url1);
                addTask(url2);
                addTask(url3);

                modelList = dbController.getAllTasks();
            }
        }
```java

你看下在connected回调回来的etag是否为非空。如果为空的话，需要让你们后端同事支持下，断点续传是基于etag的。

谢谢~

请问后端做支持是不是指CDN环境

authors: Jacksgong pengjianbo

repo: lingochamp/FileDownloader


text:
更改标签页的图标

想问一下，标签页上的小水滴可以更改嘛？

当然可以，文件是/avatar/favicon.png，把这个替换成你想要的图标就可以了✌

好的非常感谢！