text:
Mate weather applet fails to get weather

Issue description
The weather applet included in mate-applets fails to download weather information. It just shows "0°F", or sometimes "--" instead. I've tried setting it to different cities all over the world, none of them work.
Interestingly, for UK cities, I get see the following in journalctl -xe, perhaps it fails for a similar reason on other cities (though I don't see an error message for these):
.mateweather-ap[NNNN]: Failed to get Met Office forecast data: 6 TLS/SSL support not available; install glib-networking.

Steps to reproduce
Install the weather applet in MATE and try to get it to show anything useful.
I've tried adding glib-networking to the buildInputs of both mate-applets and libmateweather, but it doesn't help at all.
Technical details

system: "x86_64-linux"
host os: Linux 4.19.13, NixOS, 19.03pre165037.eebd1a92637 (Koi)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.1.3
channels(shane): ""
channels(root): "nixos-19.03pre165037.eebd1a92637"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Ran into this, please reopen. I'm running MATE on NixOS, but not Gnome.

Yep, also seeing this: https://github.com/NixOS/nixpkgs/issues/311066

2 ugly workarounds are done right now:

#262496 propagated glib-networking
#311074 enabled ervices.gnome.glib-networking

So I assume this is already fixed in 23.11. Note that since https://github.com/NixOS/nixpkgs/pull/289062 the weather applet is built in-process since we want to package the wayland session.

authors: AshleyYakeley HammyHavoc bobby285271 duairc


text:
openblas: build broken on aarch64 (master & release 19.03)

Issue description
It looks like that https://github.com/NixOS/nixpkgs/pull/56216 broke the build on aarch64:
gfortran: error: unrecognized command line option '-m64'

Steps to reproduce
For example see https://hydra.nixos.org/build/89399945 for a build log.

I stumbled onto this when trying to build postgis on master.

source: gharchive/issue

authors: ingenieroariel markuskowa

repo: NixOS/nixpkgs

license: MIT

license_type: permissive

license_source: github-api


text:
Lost git over ssh access to GitLab after update

Describe the bug
After doing a general update (nixos-rebuild switch --upgrade) and running nix-collect-garbage -d followed by a system reboot, I lost access to my GitLab repositories. I cannot tell which of the above steps exactly caused the problem to start, but it worked before and didn't after.
At the beginning the problem I got was this:
$ git pull
The project you were looking for could not be found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I found the reason for this were entries in /var/gitlab/state/home/.ssh/authorized_keys' where the following path was used for ssh-agent`:
/nix/store/ccm7c2hmjqiah3y3k8xv56z9k58dh4i0-gitlab-shell-10.0.0/bin/gitlab-shell key-3

(Note the path directily into the nix-store.)
After removing the key and re-adding it (using the GitLab web interface) I saw that the following path is used now:
/run/current-system/sw/bin/gitlab-shell key-15

But still it didn't work, just the error message changed:
$ git pull
The project you were looking for could not be found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Following to that I changed the path on the other keys as well. Interestingly on the other keys I now get access to the repository. So I have one GitLab account with three ssh keys added. One of the ssh-keys produces the "The project you were looking for could not be found." error message while the other two keys started to work again after I updated the path to gitlab-shell.
The content of /var/gitlab/state/home/.ssh/authorized_keys is:
# Managed by gitlab-rails
command="/run/current-system/sw/bin/gitlab-shell key-3",no-port-forwarding,no-X11-forwarding,no-agent-forwarding,no-pty ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDL1NI9UmBTL8OoGfInxhvcRkTWXU+C9HJNy0rAfPpubOgtsvVWUMTHQY3epRBRT6Y68j49yEY0VJgzZ1R/7tZNnVh7uNX4IifD39DHNPQzkSUKgsLQc8UhkU4Vn7Tfqzz8oXrCCqWfbQhtliMFJvtKaZRfZN+TaOhOFo3A5xoG/gw6oC4626tzYIKWL9OyAihpNw55aWvAeiWNECY19FQQMwR78xwCuL0lmLwIYqt5WzK61/NGuZBfT7FPbFQMHCtGgeNFHsIuTXzzu6iO7HHkXITHUF3Jx3WsA9PF7Yzw51ZWDqDyAz+u1RQfQk1L8m1LBZYOQsCH20nqN6ceQ/V5
####################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################
command="/run/current-system/sw/bin/gitlab-shell key-5",no-port-forwarding,no-X11-forwarding,no-agent-forwarding,no-pty ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDxgOFmsFVEIX4oJgZYOtnBfXl6QkedUfdYZu6DPG8gdTwWjbnZeEwhbMf1ZP08aHPRrXGb25khHeZ2ZjYdFR8yEcx2UobI5aG9/S/uhpz/DrvFw7dqT3qT8roxd4yrzfQIpcEFbCN20i00vBmnIUoVx2NAFRtg4V5MrI3jCV2wy4msvYLvCJvntj49bxrXzI4NpqnJcSaOuogIOX4roZN0SVOZlNJKf1Ibk7kG84u/CcU6IN/BL0gqi4ZBfzkmtqKFo1DLO4c6lDfOJLzi780SrJd6J3HntrIoN9cqHReyymrYtieeM0jA+HwrBAaC0h58OAg3lRdzAAOJ4P67WZiZ
command="/run/current-system/sw/bin/gitlab-shell key-10",no-port-forwarding,no-X11-forwarding,no-agent-forwarding,no-pty ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIBRnQyr2lliJ2y0NYIP9KAr5yKmt+VoQMBVSkqxyR3Ju
command="/run/current-system/sw/bin/gitlab-shell key-11",no-port-forwarding,no-X11-forwarding,no-agent-forwarding,no-pty ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIOcMw5VjheX5cRMlrQ5rbmM4tSV+h+o7uiScDvdMAQX5
#####################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################
#####################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################################
command="/run/current-system/sw/bin/gitlab-shell key-14",no-port-forwarding,no-X11-forwarding,no-agent-forwarding,no-pty ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDinClM7SYMUt/qil+dt34OFYYWf+ZyCk4XROKmf0KsyoTn7DCk7+xkhNiDc2O+n1GT9s5KBcsh/haJcKlQuqxnvjbQSpDgtjugORhR6GK47Q1RnBqEsnE2pP/KYyNk+iq8j3/QEphVHOvDy1ZD3sIRvSE01ly/kMdnYV2VnBNBcugjSObvQKICuOLubk9hClDFcNH50iI7Z/+1TgcOEAbbQ+Wk8WZgwL9ze3RO3G6j72ID5x4Dcv1+mt+hD0rGukoNsLyA+e9vpJ4jJLjpFiDHGTj2flYyttrS+cMkNR7IyzfzcVVVQVf1dB2yBopnTeVdptCx1wW8vSTY66FVtTI9
command="/run/current-system/sw/bin/gitlab-shell key-15",no-port-forwarding,no-X11-forwarding,no-agent-forwarding,no-pty ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDL1NI9UmBTL8OoGfInxhvcRkTWXU+C9HJNy0rAfPpubOgtsvVWUMTHQY3epRBRT6Y68j49yEY0VJgzZ1R/7tZNnVh7uNX4IifD39DHNPQzkSUKgsLQc8UhkU4Vn7Tfqzz8oXrCCqWfbQhtliMFJvtKaZRfZN+TaOhOFo3A5xoG/gw6oC4626tzYIKWL9OyAihpNw55aWvAeiWNECY19FQQMwR78xwCuL0lmLwIYqt5WzK61/NGuZBfT7FPbFQMHCtGgeNFHsIuTXzzu6iO7HHkXITHUF3Jx3WsA9PF7Yzw51ZWDqDyAz+u1RQfQk1L8m1LBZYOQsCH20nqN6ceQ/V5
command="/run/current-system/sw/bin/gitlab-shell key-16",no-port-forwarding,no-X11-forwarding,no-agent-forwarding,no-pty ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDJsmQHXMn3jCaw1KH75Oi3TC/iYcPISTQdbgh5MH/WDUpiRUwDwSXKxVVQUZjFzXyMkPOUmUhj9yBNJr4Bp1t9HaadQod1LzWe1bxfVI7lCstZ06Ao9KA78lQ9qkwr3bPHcjnO+0p+Fe05Te5gJGVZhgGZGZcYk1ucoHZTT+wCMuqAnWT5nB0ueXz7fKnck6YrApdGBDJlNiJ98ZvfFhKyPZX3oI2gZ/tERyx5BZgMe8u66dJBnOzw+QK0T8VkwOa0hnkZahm6ENZ+bWtv94xO4xxx2/k8MsxnNFnYrS6efAO82EcowRyRxvgYn+5bnyox3JrCxzgZTTqwFTTRbXkx

Only key-15 isn't working.
To Reproduce
Sorry, I don't know. Probably the way GitLab on NixOS handled this changed and an older version of GitLab has to be installed first to generate configuration, that contains paths into the nix store. Then it seems to fail after you upgrade and get a system where the nix store location of gitlab-agent changes.
Expected behavior
I would expect, that I continue to be able to access my git repositories over ssh after an update of GitLab and NixOS.
Metadata

system: "x86_64-linux"
host os: Linux 4.19.87, NixOS, 19.09.1481.f3fa5a101eb (Loris)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
attribute:
- gitlab
- gitlab-shell
module:
- services.gitlab

Must be due to backport of #74278
cc @flokli @petabyteboy @globin @fpletz @krav

Try removing/commenting out the broken key and re-adding it from the interface, we had this broken state for a few keys too and that fixed it. It also is fixed on current nixpkgs branches

@veprbl why that PR specifically? f3eb063ecfb0cb76e2cef1e9c9764cdee92f9ed7 and a33ddd7a68d222d1096d390df39068651cc13c79 patched gitlab-shell to write /run/current-system/sw/bin/gitlab-shell instead of just the hardcoded path to /var/gitlab/state/home/.ssh/authorized_keys (which was a bug previously) - but there's no code fixing up manually in that file.

@globin I did that for all three keys. For two of them it helped, for the third one it didn't help. I just tried it once again and still this key is not working.

I found that the key that was not working was present in /var/gitlab/state/home/.ssh/authorized_keys twice. (I don't know why …) GitLab was always managing the last occurrence of the key in this file … while ssh uses the first match it found. Therefore a key number was passed to gitlab, that gitlab didn't know about anymore.
Removing the first occurrence of the duplicate key manually solved the problem for me.

I'm not sure if we can/should add code which tries to fixup halfway broken state - maybe it'd be a better idea to add some note to the changelog. @mawis, WDYT?

@flokli I agree that somehow broken authorized_keys (with the key being in there several times) should not be “fixed”. This could cause more harm than good (because you cannot know which is the correct entry). But I think the path to gitlab-shell should be fixed from hard coded to /run/current-system/sw/bin/gitlab-shell (as I read your message from Dec 6 as well).

@mawis shouldn't this already be the case in pkgs/applications/version-management/gitlab/remove-hardcoded-locations.patch:160? (both on master and 19.09)

@flokli Thanks for pointing this out. I must have missed, that this was fixed. Would have expected someone to have closed the ticket in that case already. I guess I should do so now :)

authors: flokli globin mawis veprbl


text:
Fractal crashes when displaying inline video

Describe the bug
Fractal crashes on opening a chat with an embedded video( or some other form of gstreamer thingy?).
To Reproduce
Steps to reproduce the behavior:

Get fractal nix-shell -p fractal
Start fractal fractal
(optional) create account and login.
Open a channel with an embedded video. (I tried the fractal channel #fractal-gtk:matrix.org)
See a few messages getting rendered, right before the crash. (This last step takes about 2 seconds)

Expected behavior
The channel's contents are displayed. The application does not crash.
Screenshots Output
% nix-shell -p fractal

[nix-shell:~/src/nixpkgs]$ RUST_BACKTRACE=1 fractal
thread 'main' panicked at 'Missing dependency: element gtksink is needed (usually, in gstreamer-plugins-good or in gst-plugin-gtk).: BoolError { message: "Failed to create element from factory name", filename: "/build/fractal-4.4.0-vendor.tar.gz/gstreamer/src/auto/element_factory.rs", function: "gstreamer::auto::element_factory", line: 184 }', fractal-gtk/src/widgets/inline_player.rs:249:20
stack backtrace:
   0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
   1: core::fmt::write
   2: std::io::Write::write_fmt
   3: std::panicking::default_hook::{{closure}}
   4: std::panicking::default_hook
   5: std::panicking::rust_panic_with_hook
   6: rust_begin_unwind
   7: core::panicking::panic_fmt
   8: core::result::unwrap_failed
   9: fractal_gtk::widgets::inline_player::VideoPlayerWidget::new
  10: fractal_gtk::widgets::message::MessageBox::build_room_msg_body_bx
  11: fractal_gtk::widgets::message::MessageBox::widget
  12: fractal_gtk::widgets::message::MessageBox::create
  13: fractal_gtk::widgets::room_history::create_row
  14: glib::source::trampoline
  15: g_main_context_dispatch
  16: g_main_context_iterate.isra.0
  17: g_main_context_iteration
  18: g_application_run
  19: <O as gio::application::ApplicationExtManual>::run
  20: fractal_gtk::main
  21: std::rt::lang_start::{{closure}}
  22: std::rt::lang_start_internal
  23: main
  24: __libc_start_main
  25: _start
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Aborted (core dumped)

Additional context
I tried adding gst-plugins-good as the output suggests, but had no luck.
diff --git a/pkgs/applications/networking/instant-messengers/fractal/default.nix b/pkgs/applications/networking/instant-messengers/fractal/default.nix
index 2abd733b277..f36a51a800f 100644
--- a/pkgs/applications/networking/instant-messengers/fractal/default.nix
+++ b/pkgs/applications/networking/instant-messengers/fractal/default.nix
@@ -59,6 +59,7 @@ rustPlatform.buildRustPackage rec {
     gst_all_1.gst-editing-services
     gst_all_1.gst-plugins-bad
     gst_all_1.gst-plugins-base
+    gst_all_1.gst-plugins-good
     gst_all_1.gstreamer
     gst_all_1.gst-validate
     gtk3

Notify maintainers
@dtzWill @worldofpeace @jtojnar
Metadata
% nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.4.59-hardened, NixOS, 20.09.git.c59ea8b8a0eM (Nightingale)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.7`
 - channels(root): `"nixos-20.09pre239318.c59ea8b8a0e"`
 - channels(user): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: pkgs.fractal
# a list of nixos modules affected by the problem
module:

gtksink is not build by default, you would need
(gst-plugins-good.override {
  gtkSupport = true;
})

The suggested fix works for me. :tada:
I created a PR so in the future installing fractal just works out of the box.

authors: jtojnar tnias


text:
Vulnerability roundup 92: terraform-0.13.0: 1 advisory [9.8]

search, files

[ ] CVE-2018-9057 CVSSv3=9.8 (nixos-unstable)

Scanned versions: nixos-unstable: c59ea8b8a0e.
Cc @Chili-Man
Cc @babariviere
Cc @kalbasit
Cc @marsam
Cc @peterhoeg
Cc @zimbatm

See also: #94014, #93260

Bit of a confusing report on NVD.  It's not terraform that's vulnerable but terraform-provider-aws  which has a different versioning scheme

To the best of my knowledge, we don't package terraform-provider-aws.

@ckauhaus The aws provider is package by nixpkgs: https://github.com/NixOS/nixpkgs/blob/241eef1ec360ea3a578d996cee71051ee563c3c6/pkgs/applications/networking/cluster/terraform-providers/data.nix#L75-L82
This issue should still be closed since according to NVD report it looks like its referencing a pretty old version of the aws provider:

aws/resource_aws_iam_user_login_profile.go in the HashiCorp Terraform Amazon Web Services (AWS) provider through v1.12.0

@sarcasticadmin Thank you for the pointer. I did not find the thing somehow.

authors: arianvp ckauhaus sarcasticadmin


text:
zoom_us: add xdg_utils to PATH

This allows Zoom to open a web browser other than Google Chrome,
Firefox or Opera when xdg_utils is not installed.

Motivation for this change
It may help with https://discourse.nixos.org/t/no-sso-in-zoom-unless-firefox-is-installed/9453.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/no-sso-in-zoom-unless-firefox-is-installed/9453/2

It may help with https://discourse.nixos.org/t/no-sso-in-zoom-unless-firefox-is-installed/9453

So we are not sure if it fixes the issue?

It may help with https://discourse.nixos.org/t/no-sso-in-zoom-unless-firefox-is-installed/9453

So we are not sure if it fixes the issue?

Honestly, I have no idea, I don't use zoom myself. I'm doing this because https://github.com/qt/qtbase/blob/dev/src/gui/platform/unix/qgenericunixservices.cpp#L126 suggests it may help.

It can't hurt anything, and it does appear Qt is indeed shelling out to xdg-open for this interaction. This may explain the SSO/Google login issues, as I have xdg-open in my $PATH but other users may not.

I would have tested that myself, but I don't have a way to sign in with SSO to reproduce the behavior. OTH, if someone else has SSO, uninstalling xdg_utils for the sake of testing this shouldn't be difficult.

source: gharchive/pull-request

authors: doronbehar nixos-discourse xfix


text:
python37Packages.mongoengine: 0.20.0 -> 0.21.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.mongoengine is: "MongoEngine is a Python Object-Document Mapper for working with MongoDB"
meta.homepage for python37Packages.mongoengine is: "http://mongoengine.org/"
meta.changelog for python37Packages.mongoengine is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.21.0 with grep in /nix/store/9zgnibcgw798cacjcj13idp4yr635cxk-python3.7-mongoengine-0.21.0

directory tree listing: https://gist.github.com/b6a60080f1cf9bc3ebee325508611f31

du listing: https://gist.github.com/247ff2c524c35dac6f05aee3df0ce273

Rebuild report (if merged into master) (click to expand)

35 total rebuild path(s)

9 package rebuild(s)

9 x86_64-linux rebuild(s)
9 i686-linux rebuild(s)
8 x86_64-darwin rebuild(s)
9 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
apache-airflow
buku
python37Packages.apache-airflow
python37Packages.flask-admin
python37Packages.flask-mongoengine
python37Packages.mongoengine
python38Packages.flask-admin
python38Packages.flask-mongoengine
python38Packages.mongoengine

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/9zgnibcgw798cacjcj13idp4yr635cxk-python3.7-mongoengine-0.21.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python37Packages.mongoengine https://github.com/r-ryantm/nixpkgs/archive/8db1fca48c296144b8e5fb836918bf2db8badf19.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/9zgnibcgw798cacjcj13idp4yr635cxk-python3.7-mongoengine-0.21.0
ls -la /nix/store/9zgnibcgw798cacjcj13idp4yr635cxk-python3.7-mongoengine-0.21.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

8 packages built:

apache-airflow (python37Packages.apache-airflow)
buku
python37Packages.flask-admin
python37Packages.flask-mongoengine
python37Packages.mongoengine
python38Packages.flask-admin
python38Packages.flask-mongoengine
python38Packages.mongoengine

Maintainer pings
cc @costrouc for testing.

Can someone rebase this branch on master to fix the eval error?


text:
wasm-bindgen-cli: 0.2.67 -> 0.2.69

https://github.com/rustwasm/wasm-bindgen/releases/tag/0.2.69
https://github.com/rustwasm/wasm-bindgen/releases/tag/0.2.68

@zimbatm
Motivation for this change
Update wasm-bindgen-cli to the newest release version
Things done
regenerate Cargo.lock and fix hash for wasm-bindgen-cli version 0.2.69
add rizary as package maintainer.

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 107088 run on x86_64-linux 1

1 package failed to build:

wasm-bindgen-cli

hash mismatch in fixed-output derivation '/nix/store/maysfdqshdfg79p4rizc3pkckdda80zk-wasm-bindgen-cli-0.2.69-vendor.tar.gz.drv':
  specified: sha256-KMX0fqSOEmd+BZCbDwcK9PqR51OifSaCJOsWs+g+Ak8=
     got:    sha256-5i7YsMEETMZijVNG6TqjHJ7SN60j7FOxrMGqwY6nLvM=

Result of nixpkgs-review pr 107088 run on x86_64-linux 1

1 package built:

wasm-bindgen-cli

authors: Rizary zimbatm


text:
hdf4: Fix aarch64 build

Motivation for this change
The last glibc bump did break the aarch64 build of hdf4. We fix it by
adding the libtirpc dependency, which was previously part of glibc.
Fixes: #108340
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I only built this on my x86_64 machine guessing that this will just work.
After spinning up my raspberry-pi it turns out that this actually isn't enough.

I only built this on my x86_64 machine guessing that this will just work.
After spinning up my raspberry-pi it turns out that this actually isn't enough.

After pulling some patches from Fedora, this seems to build fine now.

After pulling some patches from Fedora, this seems to build fine now.


text:
nixos/haproxy: check conf on build

Motivation for this change
Current services will continue deploying configuration even though config may contain syntax errors. This pull request check config syntax on build which makes it easier to notice errors.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

ping @symphorien @Ma27

ping @symphorien @Ma27

@SuperSandro2000 Anything else needs to be revised? I am not sure about the editorConfig test tho: I intended to leave an extra newline when generating before appending user config.

@SuperSandro2000 Anything else needs to be revised? I am not sure about the editorConfig test tho: I intended to leave an extra newline when generating before appending user config.

@NeverBehave please review this PR: https://github.com/NixOS/nixpkgs/pull/62853

@NeverBehave please review this PR: https://github.com/NixOS/nixpkgs/pull/62853

I'm not familiar with haproxy. Does it check that paths like certificates http://cbonte.github.io/haproxy-dconv/2.4/configuration.html#ca-file (Bind options) exist during the configuration check ? If this is the case, the test will fail in the sandbox and there should be an option to disable checking (off by default).
Same concern for the chroot option, and probably may other that I don't know.
I had a quick look and it seems there is no "include" statement for the configuration file (which could point to outside of the store).
Disabling the check is also probably necessary if someone ever wants to cross compile a full nixos system with haproxy.
All those concerns are theoretical, they may or may not refer to realistic use cases.

I'm not familiar with haproxy. Does it check that paths like certificates http://cbonte.github.io/haproxy-dconv/2.4/configuration.html#ca-file (Bind options) exist during the configuration check ? If this is the case, the test will fail in the sandbox and there should be an option to disable checking (off by default).
Same concern for the chroot option, and probably may other that I don't know.
I had a quick look and it seems there is no "include" statement for the configuration file (which could point to outside of the store).
Disabling the check is also probably necessary if someone ever wants to cross compile a full nixos system with haproxy.
All those concerns are theoretical, they may or may not refer to realistic use cases.

I'm not familiar with haproxy. Does it check that paths like certificates http://cbonte.github.io/haproxy-dconv/2.4/configuration.html#ca-file (Bind options) exist during the configuration check ? If this is the case, the test will fail in the sandbox and there should be an option to disable checking (off by default).
Same concern for the chroot option, and probably may other that I don't know.
I had a quick look and it seems there is no "include" statement for the configuration file (which could point to outside of the store).
Disabling the check is also probably necessary if someone ever wants to cross compile a full nixos system with haproxy.
All those concerns are theoretical, they may or may not refer to realistic use cases.

From the manual it said “Only checks config file and exits with code 0 if no error was found, or exits with code 1 if a syntax error was found.” I believe only syntax error will fail the build, where the path won’t be touch during validation. I didn’t thought about that at first so I would give it a shot.

I'm not familiar with haproxy. Does it check that paths like certificates http://cbonte.github.io/haproxy-dconv/2.4/configuration.html#ca-file (Bind options) exist during the configuration check ? If this is the case, the test will fail in the sandbox and there should be an option to disable checking (off by default).
Same concern for the chroot option, and probably may other that I don't know.
I had a quick look and it seems there is no "include" statement for the configuration file (which could point to outside of the store).
Disabling the check is also probably necessary if someone ever wants to cross compile a full nixos system with haproxy.
All those concerns are theoretical, they may or may not refer to realistic use cases.

From the manual it said “Only checks config file and exits with code 0 if no error was found, or exits with code 1 if a syntax error was found.” I believe only syntax error will fail the build, where the path won’t be touch during validation. I didn’t thought about that at first so I would give it a shot.

[nix-shell:~]$ haproxy -c -f haproxy.conf
[NOTICE] 016/052037 (9649) : haproxy version is 2.3.2-d522db7
[NOTICE] 016/052037 (9649) : path to executable is /nix/store/fw0yfwfpadhdsfsljrfmsckpafrmd8fg-haproxy-2.3.2/bin/haproxy
[ALERT] 016/052037 (9649) : parsing [haproxy.conf:3] : 'bind 10.0.0.3:443' : unable to stat SSL certificate from file '/etc/ssl/certs/mysite.pem' : No such file or directory.
[ALERT] 016/052037 (9649) : Error(s) found in configuration file : haproxy.conf
[ALERT] 016/052037 (9649) : Fatal errors found in configuration.

Well it looks like that the certificate file will be checked. Then I think it is better to keep it away from the sandbox for now. Thanks for pointing this out.

[nix-shell:~]$ haproxy -c -f haproxy.conf
[NOTICE] 016/052037 (9649) : haproxy version is 2.3.2-d522db7
[NOTICE] 016/052037 (9649) : path to executable is /nix/store/fw0yfwfpadhdsfsljrfmsckpafrmd8fg-haproxy-2.3.2/bin/haproxy
[ALERT] 016/052037 (9649) : parsing [haproxy.conf:3] : 'bind 10.0.0.3:443' : unable to stat SSL certificate from file '/etc/ssl/certs/mysite.pem' : No such file or directory.
[ALERT] 016/052037 (9649) : Error(s) found in configuration file : haproxy.conf
[ALERT] 016/052037 (9649) : Fatal errors found in configuration.

Well it looks like that the certificate file will be checked. Then I think it is better to keep it away from the sandbox for now. Thanks for pointing this out.

authors: NeverBehave aanderse symphorien


text:
bup: 0.31 -> 0.32

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/bup/versions.
meta.description for bup is: "Efficient file backup system based on the git packfile format"
meta.homepage for bup is: "https://github.com/bup/bup"
meta.changelog for bup is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.32 with grep in /nix/store/i7g9hnsipisbrhf68qxkan15dz4q7a5h-bup-0.32

directory tree listing: https://gist.github.com/fb90d0f81e0b32d7f36b6627f3aa6d61

du listing: https://gist.github.com/ad20789851ad5613ac406888d56c0f88

Rebuild report (if merged into master) (click to expand)

27 total rebuild path(s)

7 package rebuild(s)

7 x86_64-linux rebuild(s)
7 i686-linux rebuild(s)
6 x86_64-darwin rebuild(s)
7 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
bup
git-annex
git-annex-metadata-gui
haskellPackages.git-annex
python37Packages.git-annex-adapter
python38Packages.git-annex-adapter
python39Packages.git-annex-adapter

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/i7g9hnsipisbrhf68qxkan15dz4q7a5h-bup-0.32 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A bup https://github.com/r-ryantm/nixpkgs/archive/f020af824d7ced8a7972618bf64fd8382072c5a2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/i7g9hnsipisbrhf68qxkan15dz4q7a5h-bup-0.32
ls -la /nix/store/i7g9hnsipisbrhf68qxkan15dz4q7a5h-bup-0.32/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages failed to build:

git-annex-metadata-gui
python37Packages.git-annex-adapter
python38Packages.git-annex-adapter
python39Packages.git-annex-adapter

2 packages built:

bup
git-annex

Maintainer pings
cc @muflax for testing.

Built and tested basic save/restore functionality:
$ export BUP_DIR=$PWD/bup-test

$ bup init
hint: Using 'master' as the name for the initial branch. This default branch name
hint: is subject to change. To configure the initial branch name to use in all
hint: of your new repositories, which will suppress this warning, call:
hint:
hint: 	git config --global init.defaultBranch <name>
hint:
hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
hint: 'development'. The just-created branch can be renamed via this command:
hint:
hint: 	git branch -m <name>
Initialized empty Git repository in /home/rnhmjoj/bup-test/

$ bup index src/nixboot/
Indexing: 110, done (1169 paths/s).

$ bup save -n nixboot src/nixboot --strip
Reading index: 110, done.
Saving: 99.98% (18217/18221k, 110/110 files), done.

$ bup ls nixboot/latest
LICENSE       coreboot.nix  result        systems
README.md     gbe.nix       scripts
rnhmjoj@wigfrid i~

$ bup cat-file nixboot/latest/README.md | head
# Nixboot

### Simple declarative and reproducible coreboot images

This repository contains a minimal interface to build coreboot images using Nix.
Coreboot is already near 100% binary reproducible and can be configured via
[Kconfig](https://doc.coreboot.org/getting_started/kconfig.html); however
the process is somewhat involved: it requires maintaining a local checkout of
the coreboot source, several config files and shell scripts. Nixboot automates
this process and allows to control it declaratively from a single file.

$ bup restore nixboot/latest/README.md
Restoring: 1, done.
rnhmjoj@wigfrid i~

$ stat README.md
  File: README.md
  Size: 3694      	Blocks: 8          IO Block: 4096   regular file
Device: 2eh/46d	Inode: 4985786     Links: 1
Access: (0644/-rw-r--r--)  Uid: ( 1000/ rnhmjoj)   Gid: (  100/   users)
Access: 2020-12-31 01:23:40.975197000 +0100
Modify: 2020-12-31 01:23:25.667021000 +0100
Change: 2021-01-19 18:30:46.480908108 +0100
 Birth: -

Built and tested basic save/restore functionality:
$ export BUP_DIR=$PWD/bup-test

$ bup init
hint: Using 'master' as the name for the initial branch. This default branch name
hint: is subject to change. To configure the initial branch name to use in all
hint: of your new repositories, which will suppress this warning, call:
hint:
hint: 	git config --global init.defaultBranch <name>
hint:
hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
hint: 'development'. The just-created branch can be renamed via this command:
hint:
hint: 	git branch -m <name>
Initialized empty Git repository in /home/rnhmjoj/bup-test/

$ bup index src/nixboot/
Indexing: 110, done (1169 paths/s).

$ bup save -n nixboot src/nixboot --strip
Reading index: 110, done.
Saving: 99.98% (18217/18221k, 110/110 files), done.

$ bup ls nixboot/latest
LICENSE       coreboot.nix  result        systems
README.md     gbe.nix       scripts
rnhmjoj@wigfrid i~

$ bup cat-file nixboot/latest/README.md | head
# Nixboot

### Simple declarative and reproducible coreboot images

This repository contains a minimal interface to build coreboot images using Nix.
Coreboot is already near 100% binary reproducible and can be configured via
[Kconfig](https://doc.coreboot.org/getting_started/kconfig.html); however
the process is somewhat involved: it requires maintaining a local checkout of
the coreboot source, several config files and shell scripts. Nixboot automates
this process and allows to control it declaratively from a single file.

$ bup restore nixboot/latest/README.md
Restoring: 1, done.
rnhmjoj@wigfrid i~

$ stat README.md
  File: README.md
  Size: 3694      	Blocks: 8          IO Block: 4096   regular file
Device: 2eh/46d	Inode: 4985786     Links: 1
Access: (0644/-rw-r--r--)  Uid: ( 1000/ rnhmjoj)   Gid: (  100/   users)
Access: 2020-12-31 01:23:40.975197000 +0100
Modify: 2020-12-31 01:23:25.667021000 +0100
Change: 2021-01-19 18:30:46.480908108 +0100
 Birth: -

authors: r-ryantm rnhmjoj


text:
cinelerra: 2018-05-16 -> 2021-02-14

Motivation for this change
A previous pull request, #112680, unbroke the build by including a not-yet-merged upstream pull request among the patches. Meanwhile upstream has progressed (and incorporated a different solution to the compilation issue), rendering the patch unnecessary. It seems simpler to imply track upstream, even though (apart from unbreaking the build) no user-facing commits have landed since the version which is currently in nixpkgs.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 113249 at 53da1836 run on x86_64-linux 1

1 package built:

cinelerra

1 suggestion:

warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/applications/video/cinelerra/default.nix:1:33:
  |
1 | { lib, stdenv, fetchFromGitHub, fetchpatch, autoconf, automake, libtool
  |                                 ^

Thank you dear friendly bot :-) Shouldn't have missed that, fixed in new force-push.

authors: iblech r-rmcgibbo


text:
shfmt: 3.2.2 -> 3.2.4

https://github.com/mvdan/sh/releases/tag/v3.2.4

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 115449 at 3c986e82 run on aarch64-linux 1

1 package marked as broken and skipped:

zoxide

2 packages built:

bat-extras.prettybat
shfmt

authors: r-rmcgibbo zowoq


text:
R: 3.2.2 -> 3.2.3

cc @peti

Please delete fix-tests-without-recommended-packages.patch if it's no longer required.

Done.

authors: michelk peti


text:
htslib: 1.11 -> 1.12

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/htslib/versions.
meta.description for htslib is: "A C library for reading/writing high-throughput sequencing data"
meta.homepage for htslib is: "http://www.htslib.org/"
meta.changelog for htslib is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.12 with grep in /nix/store/sn6zm7bq69m8kxmdfy3kw248v694fv9d-htslib-1.12

directory tree listing: https://gist.github.com/035027c65e6bd82e1cf5f776333f4a3c

du listing: https://gist.github.com/2bf1ed5b14e4832047a659190639e03c

Rebuild report (if merged into master) (click to expand)

53 total rebuild path(s)

17 package rebuild(s)

17 x86_64-linux rebuild(s)
13 i686-linux rebuild(s)
12 x86_64-darwin rebuild(s)
11 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
bcftools
deeptools
delly
htslib
lumpy
mosdepth
octopus-caller
platypus
python38Packages.HTSeq
python38Packages.cnvkit
python38Packages.pysam
python39Packages.HTSeq
python39Packages.cnvkit
python39Packages.pysam
samtools
tebreak
truvari

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/sn6zm7bq69m8kxmdfy3kw248v694fv9d-htslib-1.12 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A htslib https://github.com/r-ryantm/nixpkgs/archive/d7521a0324c41b3ee17712dc3146789cbe891857.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/sn6zm7bq69m8kxmdfy3kw248v694fv9d-htslib-1.12
ls -la /nix/store/sn6zm7bq69m8kxmdfy3kw248v694fv9d-htslib-1.12/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

11 packages failed to build:

deeptools
lumpy
python38Packages.HTSeq
python38Packages.cnvkit
python38Packages.pysam
python39Packages.HTSeq
python39Packages.cnvkit
python39Packages.pysam
samtools
tebreak
truvari

6 packages built:

bcftools
delly
htslib
mosdepth
octopus-caller
platypus

Maintainer pings
cc @mimame for testing.

Result of nixpkgs-review pr 116704 at d7521a03 run on aarch64-linux 1

6 packages marked as broken and skipped:

deeptools
python38Packages.HTSeq
python38Packages.cnvkit
python39Packages.HTSeq
python39Packages.cnvkit
truvari

1 package failed to build (new failures):

samtools

4 packages built successfully:

bcftools
delly
htslib
mosdepth

Result of nixpkgs-review pr 116704 run on x86_64-linux 1

11 packages failed to build:

deeptools
lumpy
python38Packages.HTSeq
python38Packages.cnvkit
python38Packages.pysam
python39Packages.HTSeq
python39Packages.cnvkit
python39Packages.pysam
samtools
tebreak
truvari

6 packages built:

bcftools
delly
htslib
mosdepth
octopus-caller
platypus

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 116704 run on x86_64-linux 1

11 packages failed to build and are new build failures:

deeptools: log was empty
lumpy: log was empty
python38Packages.HTSeq: log was empty
python38Packages.cnvkit: log was empty
python38Packages.pysam: log was empty
python39Packages.HTSeq: log was empty
python39Packages.cnvkit: log was empty
python39Packages.pysam: log was empty
samtools: log was empty
tebreak: log was empty
truvari: log was empty

6 packages built:

bcftools
delly
htslib
mosdepth
octopus-caller
platypus

Build has a lot of failures, but seems as if it's not necessarily the fault of this package or this version bump. Can we get a review by someone who is familiar with the package and use-case?

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 116704 run on x86_64-linux 1

2 packages failed to build and already failed to build on hydra master:

python38Packages.cnvkit: log was empty
python39Packages.cnvkit: log was empty

9 packages failed to build and are new build failures:

deeptools: log was empty
lumpy: log was empty
python38Packages.HTSeq: log was empty
python38Packages.pysam: log was empty
python39Packages.HTSeq: log was empty
python39Packages.pysam: log was empty
samtools: log was empty
tebreak: log was empty
truvari: log was empty

6 packages built:

bcftools
delly
htslib
mosdepth
octopus-caller
platypus

new release available

authors: Artturin SuperSandro2000 r-rmcgibbo r-ryantm tomberek


text:
[20.09] Added mime info path for mimemagic

Motivation for this change
The fixes done to make mimemagic continue to work with Nix should be backported to the current stable version since there is currently no version of mimemagic available that can be built without these fixes.
Original commits/discussion in https://github.com/NixOS/nixpkgs/pull/117702
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 119757 run on x86_64-linux 1

1 package marked as broken and skipped:

frab

4 packages built:

gitlab
gitlab-ee
iruby
redmine

Please follow the contributing guide when backporting commits.

I am unsure what changes are being requested here. I made a best effort attempt at following the contributing guidelines here and if I have made some mistake it isn't obvious to me. Happy to make any changes but not sure what needs to be done here.

The important part for this PR is https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes and especially the git cherry-pick -x part.

This is needed to resolve #120413, so this indirectly becomes a "security" tag.
ping @SuperSandro2000 please :heart:

Thanks!

authors: SuperSandro2000 aanderse nixy


text:
nixos/swap: allow luks discards if swap discards are enabled

Motivation for this change
There was a discardPolicy option added for swap in #107728 but it will work only for unencrypted swap partitions. This PR adds --allow-discards option to cryptsetup in case discardPolicy is specified.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

cc @nessdoor

Sounds reasonable to me, and the change is rather small.
I suppose there are no funny effects when the backing device is a file instead of a raw partition, right? I remember something along the lines of "in reality, a swap file is not really used like a file, but as a reserved offset + size area inside another partition", so I guess the operations are sent directly to the underlying device?
Sorry for the vagueness, but I can't recollect the details and I haven't used encrypted drives in a long time...

I suppose there are no funny effects when the backing device is a file instead of a raw partition, right?

Should be fine - I tested it executing cryptsetup plainOpen --allow-discards on a file and it worked.

@ThibautMarty @ajs124 @SuperSandro2000 pinging you since you reviewed/merged #107728 . Sorry if it's too annoying - not sure how I should deal with this so that it's not lost in thousands of MRs :)

I suppose this PR is needed for "encrypted secondary swap partition" situation. For the boot drive
boot.initrd.luks.devices.<name>.allowDiscards seems suffice as root and swap should be mounted during initrd.

I don't use luks but from a quick glance I think this is good :+1:

@bb2020 Prompted by your comment I looked at the current man page for configuration.nix, and it says that a swapDevices.*.encrypted.enable should add encrypted swap devices to boot.initrd.luks.devices automatically, but I cannot find the code for it. So I guess it doesn't? This is not strictly related to what you said, though, it was a concomitant discovery.
Anyway, from the contents of  swap.nix it seems that swap devices are not mounted in early userspace (as there is no reason for them to be), and they are all registered through the same unit file-based interface, so I think that there is no distinction between primary and secondary swap partitions, and they are all mounted after early userspace, right?

@bb2020 Prompted by your comment I looked at the current man page for configuration.nix, and it says that a swapDevices.*.encrypted.enable should add encrypted swap devices to boot.initrd.luks.devices automatically, but I cannot find the code for it. So I guess it doesn't? This is not strictly related to what you said, though, it was a concomitant discovery.

It does here. Although I am not sure if drives with randomEncryption are added to boot.initrd.luks.devices.

Anyway, from the contents of swap.nix it seems that swap devices are not mounted in early userspace (as there is no reason for them to be), and they are all registered through the same unit file-based interface, so I think that there is no distinction between primary and secondary swap partitions, and they are all mounted after early userspace, right? Or maybe I am totally missing something.

Normally swap is mounted along with root partition during boot because they have corresponding entries in
hardware-configuration.nix. This PR makes a change only on swapDevices.<name>.randomEncryption feature.

I think this option should be a toggle and named as swapDevices.<name>.randomEncryption.allowDiscards. The user may not be informed about unsafety of using discard on an encrypted area.

I think this option should be a toggle and named as swapDevices..randomEncryption.allowDiscards. The user may not be informed about unsafety of using discard on an encrypted area.

Then specifying discardPolicy in this case won't do anything in case of encrypted swap which also might be misleading. Probably just adding a warning to discardPolicy description will be be enough?

That is the point, you should explicitly opt-in for trim on encrypted area. discardPolicy is also used on unencrypted area, so it will be understandable. boot.initrd.luks.devices.<name>.allowDiscards also have a similar design.
The warning will be unseen in bulky nixos-rebuild output.

Another example would be not utilizing discardPolicy, but running fstrim manually. This way discard will not be propagated.

@bb2020 willing to make a PR? :)

You can copy from here.

authors: aanderse bb2020 kurnevsky nessdoor


text:
python3Packages.holidays: 0.11.1 -> 0.11.2

Motivation for this change
Update to latest upstream release 0.11.2
Change log: https://github.com/dr-prodigy/python-holidays/releases/tag/v0.11.2

Related Home Assistant change: https://github.com/home-assistant/core/pull/53191
Target Home Assistant release: current (only dependency update, no code changes)

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

had an issue with home-assistant, not sure how flakey the test is:
        await hass.async_block_till_done()
        lock_online_with_doorsense_name = hass.states.get("lock.online_with_doorsense_name")
>       assert lock_online_with_doorsense_name.state == STATE_LOCKED
E       AssertionError: assert 'unlocked' == 'locked'
E         - locked
E         + unlocked
E         ? ++

activities = [<LockOperationActivity action=lock activity_type=ActivityType.LOCK_OPERATION activity_start_time=2021-07-22 18:38:43....rated_remote>
config_entry = <tests.common.MockConfigEntry object at 0x7ffdcc5b4940>
hass       = <homeassistant.core.HomeAssistant object at 0x7ffdc51fef40>
lock_one   = <yalexs.lock.LockDetail object at 0x7ffdc45c61c0>
lock_online_with_doorsense_name = <state lock.online_with_doorsense_name=unlocked; battery_level=92, friendly_name=online_with_doorsense Name @ 20>
pubnub     = <yalexs.pubnub_async.AugustPubNub object at 0x7ffdc45c63d0>

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 131043 run on x86_64-linux 1

5 packages built:

home-assistant
python38Packages.aiopvpc
python38Packages.holidays
python39Packages.aiopvpc
python39Packages.holidays

authors: SuperSandro2000 fabaff jonringer


text:
python3Packages.plugwise: 0.11.1 -> 0.11.2

Motivation for this change
Update to latest upstream release 0.11.2
Change log: https://github.com/plugwise/python-plugwise/releases/tag/0.11.2
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 133234 run on x86_64-linux 1

3 packages built:

home-assistant
python38Packages.plugwise
python39Packages.plugwise


text:
opentelemetry-collector: 0.31.0 -> 0.33.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/open-telemetry/opentelemetry-collector-contrib/releases.
meta.description for opentelemetry-collector is: "OpenTelemetry Collector"
meta.homepage for opentelemetry-collector is: "https://github.com/open-telemetry/opentelemetry-collector"
meta.changelog for opentelemetry-collector is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/lfz2l8lyzrj0yqya3gbd0n8md4bf2f1i-opentelemetry-collector-0.33.0/bin/otelcontribcol passed the binary check.

1 of 1 passed binary check by having a zero exit code.

0 of 1 passed binary check by having the new version present in output.

found 0.33.0 with grep in /nix/store/lfz2l8lyzrj0yqya3gbd0n8md4bf2f1i-opentelemetry-collector-0.33.0

found 0.33.0 in filename of file in /nix/store/lfz2l8lyzrj0yqya3gbd0n8md4bf2f1i-opentelemetry-collector-0.33.0

directory tree listing: https://gist.github.com/dad6082140a4cbc888981286aeadd904

du listing: https://gist.github.com/1e93f92a6d0f6325cd49715cd6ee55c6

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
opentelemetry-collector

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lfz2l8lyzrj0yqya3gbd0n8md4bf2f1i-opentelemetry-collector-0.33.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A opentelemetry-collector https://github.com/r-ryantm/nixpkgs/archive/71f3892be7d403bd0c0954d686370e4565e7d1ea.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lfz2l8lyzrj0yqya3gbd0n8md4bf2f1i-opentelemetry-collector-0.33.0
ls -la /nix/store/lfz2l8lyzrj0yqya3gbd0n8md4bf2f1i-opentelemetry-collector-0.33.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

opentelemetry-collector

Maintainer pings
cc @uri-canva @kalbasit for testing.

Can't build it on darwin:
# github.com/open-telemetry/opentelemetry-collector-contrib/cmd/otelcontribcol
/nix/store/5psc6givws1ww94hbvr8411mb59nqqy4-go-1.16.7/share/go/pkg/tool/darwin_amd64/link: running clang failed: exit status 1
duplicate symbol '_readdrivestat' in:
    /private/tmp/nix-build-opentelemetry-collector-0.33.0.drv-0/go-link-390201380/000029.o
    /private/tmp/nix-build-opentelemetry-collector-0.33.0.drv-0/go-link-390201380/000032.o
ld: 1 duplicate symbol for architecture x86_64
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
builder for '/nix/store/34057slahhipnfp1y3qyji0512yyhz5i-opentelemetry-collector-0.33.0.drv' failed with exit code 1
error: build of '/nix/store/34057slahhipnfp1y3qyji0512yyhz5i-opentelemetry-collector-0.33.0.drv' failed

Will wait for ofborg: https://github.com/NixOS/nixpkgs/pull/135243/checks?check_run_id=3392948661

It is just failing for darwin. We could ignore that because the error seems strange for me.

I don't think we should ignore it, it's a regression, the current version works on darwin.

I don't think we should ignore it, it's a regression, the current version works on darwin.

sure, but do you have a darwin machine and know how to fix it? I don't and darwin is a 2nd class citizen because of those weird breakages and that it is harder to test for people.

I think any change is hard to test on hardware you don't own, but we shouldn't merge in changes that break a system just because of that, and ofborg is there to catch unintentional breakages.
One can test changes on hardware they don't have access to using vms. A cursory search for macos vms shows up https://github.com/myspaghetti/macos-virtualbox for example. Can't vouch whether it's any good or not, I do have a darwin machine, so I have only needed to set up linux vms.

darwin is a 2nd class citizen

I don't think it is, the set of packages on it is definitely smaller than on linux, but I see it as just as supported as any non-nixos linux.

This seems to be related: https://groups.google.com/g/golang-nuts/c/sh4bxSnfY3w.

Related discussion on whether darwin breakages should block updates and how darwin maintainers might not be able to handle the load of reviewing / addressing darwin specific issues: https://github.com/NixOS/rfcs/pull/112

Sorry after more discussion in https://github.com/NixOS/rfcs/pull/112 I've realised I was wrong to block this PR because of darwin compatibility, it is ok to proceed by marking darwin as broken.

Preparing a new PR to bump to 0.38.0, will try disabling CGO.

New PR up, supersedes this one: https://github.com/NixOS/nixpkgs/pull/145283.

authors: SuperSandro2000 r-ryantm uri-canva


text:
cisco-packet-tracer: init at 7.3.1 and 8.0.1

This PR is ready for merge

Motivation for this change
People need Cisco Packet Tracer for uni assignments. I've added both 7.x and 8.x versions because both are incompatible and the 8.x cause some problems to people that can require everyone working on the 7.x version.
Things done

Added cisco-packet-tracer7 at 7.3.1
Added cisco-packet-tracer8 at 8.0.1
Credits to people that sent code to start from in gists on nixpkgs issues, in special @buckley310 that posted his Cisco 8 code that I stolen to adapt for my needs.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Should we bump it to 8.0.1?

packettracer7 and packettracer8 runs for me.

After a very long/slow download I was able to run the software. It's relevant to hint the user of this long wait without feedback. Maybe using builtins.trace (or some other better method)?

The package source is not an upstream channel. I don't know how nixpkgs handle this (allowed or not?). But would be nice to contact upstream and request them to make it accessible publicly at least for our use case (as a Linux distribution).

I've made a wrapper around requireFile asking the user to download the deb file from NetAcad, the internet archive link saying that is slow, or somewhere else saying that the file must match the provided sha256 hash.

/marvin opt-in
/status needs_reviewer

Should be bumped to 8.0.1 before the merge, as you cannot download 8.0.0 officially anymore.

Looks good to me.
I might be inclined to remove the comments at the top of 7.nix and 8.nix, though. I don't mind stuff pointing at my repo, but I'll be deleting my package if nixpkgs gets an official one.

Looks good to me.
I might be inclined to remove the comments at the top of 7.nix and 8.nix, though. I don't mind stuff pointing at my repo, but I'll be deleting my package if nixpkgs gets an official one.

What do you think it's better?

Remove entirely the "based on" comments
Change the URL to a permalink, that will work even if you delete the package on your repo. It will keep working unless you force push before that commit or delete the repo.

If it was my PR, I probably wouldn't include the comment.

This all looks good to me. 7 and 8 both run and function.

I think I solved the mess after dropping a commit xD

/status needs_merger

I spun both versions up and poked around. They look good.

I receive this message.
Unfortunately, we cannot download file CiscoPacketTracer_801_Ubuntu_64bit.deb automatically. Please go to https://www.netacad.com to download it yourself, and add it to the Nix store using either   nix-store --add-fixed sha256 CiscoPacketTracer_801_Ubuntu_64bit.deb or   nix-prefetch-url --type sha256 file:///path/to/CiscoPacketTracer_801_Ubuntu_64bit.deb
But the installer now has the name CiscoPacketTracer_811_Ubuntu_64bit.deb
I've downloaded, renamed and tried this below conforms suggested by terminal.
suporte@SUPORTE-01:~]$ nix-prefetch-url --type sha256 file:///home/suporte/Documentos/CISCO/NETACAD/CiscoPacketTracer_801_Ubuntu_64bit.deb warning: dumping very large path (> 256 MiB); this may run out of memory [304.4 MiB DL] path is '/nix/store/gnyqxprncz4yww49dr0342wzgkxfpa1q-CiscoPacketTracer_801_Ubuntu_64bit.deb' 1gra4cr0vk6mzv4znygqlk7k6h118br405fywx5acmq2m9qk3i88
Without success. It's in loop.

Created a PR to bump the version. 811 will work afterward. https://github.com/NixOS/nixpkgs/pull/165695
Newer debs will not work with the older package, and Cisco doesn't let you download older debs, so renaming the file is a dead end in this case.
If you need to get it running in a hurry, you could always go searching in places like archive.org for the old version, since the deb is checked for validity by Nix.

Oh, many thanks @buckley310 ! This tip help me so much. I've used the required file on this link, https://archive.org/download/cisco-packet-tracer-801

Oh yeah, when I was working on this PR I initially added a direct link to
the Internet Archive but unfortunately the source is very slow. Fortunately
with hash validation you can download the deb from any shady site and if
it's the right file it will allow you to use that. The only tricky detail
is that the file must have the same name.
Em qui., 24 de mar. de 2022 às 21:36, Fábio Mendes @.***>
escreveu:

Oh, many thanks @buckley310 https://github.com/buckley310 ! This tip
help me so much. I've used the required file on this link,
https://archive.org/download/cisco-packet-tracer-801 http://url
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/135789#issuecomment-1078541139,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADXXO6CGFMIAJGFA5NTYTH3VBUC7FANCNFSM5C3INSBA
.
You are receiving this because you authored the thread.Message ID:
@.***>

is there an option to use the following site as a repository?
https://www.computernetworkingnotes.com/ccna-study-guide/download-packet-tracer-for-windows-and-linux.html
so that the .dev is automatically downloaded from a nonofficial site instead of requesting a manual .deb?

is there an option to use the following site as a repository? https://www.computernetworkingnotes.com/ccna-study-guide/download-packet-tracer-for-windows-and-linux.html so that the .deb is automatically downloaded from a nonofficial site instead of requesting a manual .deb?

For Cisco 7 I am afraid that not but Cisco 8 you can override the src parameter with overrideAttrs.

cool thanks, 2 things:

when installing the .deb you have to agree to the license, i would advise you inform the user of the licence you accepted on their behalf.
the packettracer8 works only on wayland, on x11 you get a backend error (maybe inform the user about that also)

by informing i mean in the https://search.nixos.org/packages page or anywhere else.
thanks for answering btw!

@lucasew can you help me with this (and maybe future visitors) how can i set the source?
i have the following:
let ciscoPacketTracer8new = pkgs.ciscoPacketTracer8.overrideAttrs (old: {
    src = fetchurl {
        url = "https://archive.org/download/cisco-packet-tracer-820-ubuntu-64bit/CiscoPacketTracer_820_Ubuntu_64bit.deb";
        sha256 = "1b19885d59f6130ee55414fb02e211a1773460689db38bfd1ac7f0d45117ed16";
    };
});
in {
    services.ciscoPacketTracer8.package = ciscoPacketTracer8new;
}

but i get `error: undefined variable 'fetchurl'

@lucasew can you help me with this (and maybe future visitors) how can i set the source? i have the following:
let ciscoPacketTracer8new = pkgs.ciscoPacketTracer8.overrideAttrs (old: {
    src = fetchurl {
        url = "https://archive.org/download/cisco-packet-tracer-820-ubuntu-64bit/CiscoPacketTracer_820_Ubuntu_64bit.deb";
        sha256 = "1b19885d59f6130ee55414fb02e211a1773460689db38bfd1ac7f0d45117ed16";
    };
});
in {
    services.ciscoPacketTracer8.package = ciscoPacketTracer8new;
}

but i get `error: undefined variable 'fetchurl'

pkgs.fetchurl or builtins.fetchurl

authors: NL-TCH buckley310 fabiomen10 lucasew superherointj thiagokokada


text:
oh-my-zsh: 2016-03-11 -> 2016-03-19

Things done:

[X] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
Built on platform(s)

[X] NixOS
[ ] OS X
[ ] Linux

[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Fine by me, thanks for bumping the version.

authors: NeQuissimus scolobb


text:
python3Packages.slugid: init 2.0.0

Motivation for this change
cos why not ...
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

cos why not ...

cos the slugid "library" has only 20 lines of code, which can be reduced to 16 lines
(the current default.nix has 28 lines)
# Licensed under the Mozilla Public Licence 2.0.
# https://www.mozilla.org/en-US/MPL/2.0
import sys, uuid, base64

def _ascii(s):
    if sys.version_info.major != 2 and isinstance(s, bytes):
        return s.decode('ascii')
    return s

def encode(uuid_):
    return _ascii(base64.urlsafe_b64encode(uuid_.bytes)[:-2])

def decode(slug):
    return uuid.UUID(bytes=base64.urlsafe_b64decode(_ascii(slug) + '=='))

def v4():
    return encode(uuid.uuid4())

def nice():
    s = v4()
    if s[0] == '-' or s[0] == '_':
      s[0] = 'f'
    return s


text:
synergy: 1.13.1.41 -> 1.14.1.32

Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Got it to build and run on my machine thanks for the tip! You all rock! let me know what to do next really appreciate it! I'd love to start backporting it to nixos 21.05 let me know next steps, hopefully I can provide better value in the future with less handholding.

How to rebase:
# finding the common merge base will avoid pinging all CODEOWNERs
common=$(git merge-base origin/master origin/staging)
git rebase --onto=$common HEAD~1 # or however many commits you want to pull
git push .. ... --force

then change the base branch in the github PR from master -> staging
See https://nixos.org/nixpkgs/manual/#submitting-changes-staging-branch for more details on staging branch

Thank you and sorry!
On Tue, Nov 2, 2021 at 1:40 PM Jonathan Ringer @.***>
wrote:

How to rebase:
finding the common merge base will avoid pinging all CODEOWNERs
common=$(git merge-base origin/master origin/staging)
git rebase --onto=$common HEAD~1 # or however many commits you want to pull
git push .. ... --force
then change the base branch in the github PR from master -> staging
See https://nixos.org/nixpkgs/manual/#submitting-changes-staging-branch
for more details on staging branch
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/143683#issuecomment-958029334, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AEAHD3FDDRZJKLD5BTPS4O3UKA5DVANCNFSM5G7TDJNQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Zachary Hunsaker
Interim Security Engineer II
NCAR - Wyoming Supercomputing Center
@.***
307-996-4327
##########################################
GCIH, GWAPT, GPYC, GIAC Advisory Board, CHFI


text:
i3status-rust: 0.20.7 -> 0.21.2

Motivation for this change
Update to the latest release
cc @backuitist @globin @ma27
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

FYI there's now 0.21.2.

FYI there's now 0.21.2.

Updated to the latest release.


text:
kubergrunt: 0.7.11 -> 0.8.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/kubergrunt/versions.
meta.description for kubergrunt is: "Collection of commands to fill in the gaps between Terraform, Helm, and Kubectl"
meta.homepage for kubergrunt is: "https://github.com/gruntwork-io/kubergrunt"
meta.changelog for kubergrunt is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/qf0bz4lj5zkcw727k4x08ybjpvsm5adz-kubergrunt-0.8.0/bin/kubergrunt had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 0.8.0 with grep in /nix/store/qf0bz4lj5zkcw727k4x08ybjpvsm5adz-kubergrunt-0.8.0
found 0.8.0 in filename of file in /nix/store/qf0bz4lj5zkcw727k4x08ybjpvsm5adz-kubergrunt-0.8.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
kubergrunt

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qf0bz4lj5zkcw727k4x08ybjpvsm5adz-kubergrunt-0.8.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A kubergrunt https://github.com/r-ryantm/nixpkgs/archive/00b94e3b6e8f72972f97b1d847229a14e4ee06a6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qf0bz4lj5zkcw727k4x08ybjpvsm5adz-kubergrunt-0.8.0
ls -la /nix/store/qf0bz4lj5zkcw727k4x08ybjpvsm5adz-kubergrunt-0.8.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

kubergrunt

Maintainer pings
cc @psibi @kalbasit for testing.

This can be merged. CC: @r-ryantm / @SuperSandro2000

authors: psibi r-ryantm


text:
eiciel: init at 0.9.13.1

Description of changes

Eiciel is a viewer/editor for ACLs and xattrs. It integrates with Nautilus, but also works standalone. https://rofi.roger-ferrer.org/eiciel/
I don't know if the Nautilus integration works; I installed eiciel and nautilus with nix-env and it doesn't seem to work, I don't know if that's because I packaged it wrong or if it's because I would have to install them both system-wide. I copied the method from https://github.com/NixOS/nixpkgs/blob/66be55b715edbc42f879b4bcccafe86d7f6bff10/pkgs/applications/networking/dropbox/cli.nix.
The "help" button doesn't seem to do anything, I don't know why that is – https://github.com/rofirrim/eiciel/commit/96fbd782cdfa4c47d7f6b91789e92a62614f7e6b looks relevant, and isn't included in a release yet, but building from that doesn't seem to fix it, so maybe I don't have some help viewer installed on my system.
Closes #165947
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 165970 run on x86_64-linux 1

1 package built:

eiciel

authors: Sciencentistguy sersorrel


text:
zerotierone: 1.1.4 -> 1.1.6

Motivation for this change
Bump to 1.1.6
There is currently one major breaking issue with 1.1.4 which has since been fixed in 1.1.6:
https://github.com/zerotier/ZeroTierOne/issues/336
this was fixed in this commit:
https://github.com/zerotier/ZeroTierOne/commit/039790cf267cb67a5130fb82caf97998d8b0959e
Building the manpages is a bit more complicated because it would depend on "ronn" or "marked-man", neither of which are currently packaged for nixpkgs.
See https://github.com/zerotier/ZeroTierOne/blob/master/doc/build.sh
CC @sjmackenzie @zimbatm
Things done

[x] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Fixes #15438 looks like

Great! I'll merge this PR as zerotier is basically useless right now, we can work on the manpages later.

#16620 includes the fix to the manpages

authors: danielfullmer jb55 zimbatm


text:
headscale: Add restricted_nameservers option to configure SplitDNS.

Description of changes
This adds the restricted_nameservers to the headscale configuration which allows us to configure SplitDNS.
The default is an empty attribute set, i.e. no SplitDNS is setup, which should not break any existing setup.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@kradalby Does this seem ok to you?


text:
qt5.mkDerivation Support creating overlay style overridable recursive attribute sets

Description of changes
Implemented in #119942 and was pointed out that it wasn't working in https://github.com/NixOS/nixpkgs/pull/119942#issuecomment-1117327772.
Tested with
libsForQt5.mkDerivation (finalAttrs: { name = "hi"; version = finalAttrs.name; } )

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I think it used to do more but now is a historical dept that was kept mainly for back compat?

So what would be a good path forward, is it ok to just fix all occurrences in nixpkgs and then remove it, or do you think we need to deprecate it first somehow (for users outside nixpkgs)?

seems to be quite a lot packages are using this actually, so it will be some work..

deprecate it first somehow

Should be a matter of adding a lib.warn call that explains briefly what to do instead.
The new way can already be used in the 21.11 release (or possibly earlier), so it won't be a problem for community expressions to switch over to it when the warning hits the channel.
Please only add the warning after the internal usages have been taken care of.

authors: adisbladis roberth xaverdh


text:
grpc: 1.46.1 -> 1.46.3

Description of changes

https://github.com/grpc/grpc/releases/tag/v1.46.2
https://github.com/grpc/grpc/releases/tag/v1.46.3
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build bear sysdig libtensorflow


text:
bisq-desktop: 1.8.4 -> 1.9.1

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for bisq-desktop is: "A decentralized bitcoin exchange network"
meta.homepage for bisq-desktop is: "https://bisq.network"
meta.changelog for bisq-desktop is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.9.1 with grep in /nix/store/43020qik57xrwp89p6r669830qd3ig6l-bisq-desktop-1.9.1
found 1.9.1 in filename of file in /nix/store/43020qik57xrwp89p6r669830qd3ig6l-bisq-desktop-1.9.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

0 x86_64-linux rebuild(s)
0 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
bisq-desktop

Instructions to test this update (click to expand)

Build yourself:
nix-build -A bisq-desktop https://github.com/m0rtis0/nixpkgs/archive/8b5ed8b77ec8f6d5138f8d0be99bb3966eac013d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/43020qik57xrwp89p6r669830qd3ig6l-bisq-desktop-1.9.1
ls -la /nix/store/43020qik57xrwp89p6r669830qd3ig6l-bisq-desktop-1.9.1/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @uningan @emmanuelrosa for testing.

Oh, sorry. Thanks for catching!


text:
pkgsCross.ppc64.libffi: pull patch to support gcc-12

Without the change libffi fails to build against gcc-12 as:
libtool: compile:  powerpc64-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I. -I../include -Iinclude \
    -I../src -O3 -fomit-frame-pointer -fstrict-aliasing -ffast-math -Wall -fexceptions -c ../src/tramp.c \
    -fPIC -DPIC -o src/.libs/tramp.o
../src/powerpc/linux64_closure.S: Assembler messages:
../src/powerpc/linux64_closure.S:363: Error: unrecognized opcode: `lvx'

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg eval


text:
audible-cli: 0.1.3 -> 0.2.0

Description of changes
Changelog: https://github.com/mkb79/audible-cli/releases/tag/v0.2.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@jonringer @FRidh @SuperSandro2000 is this ready to merge?


text:
metal-cli: 0.7.4 -> 0.9.0

https://github.com/equinix/metal-cli/releases/tag/v0.8.0
https://github.com/equinix/metal-cli/releases/tag/v0.9.0
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 179145 run on x86_64-linux 1

1 package built:

metal-cli


text:
python310Packages.zadnegoale: init at 0.6.5

Description of changes
Python wrapper for getting allergen concentration data from Żadnego Ale servers
https://github.com/bieniu/zadnegoale

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 185475 run on x86_64-linux 1

2 packages built:

python310Packages.zadnegoale
python39Packages.zadnegoale


text:
Add htmlhint and csslint to nodePackages

These patches add the NPM packages htmlhint and csslint, linters
for HTML and CSS respectively, to nodePackages.

merged both thanks!

Thanks for merging!