text:
i'm sorry it's just a normal problem while using this lib

how can i get the chinese character from a .ttf font file with fonttools through python?

Something like this should work:
from fontTools.ttLib import TTFont
from fontTools.pens.basePen import _TestPen

p = 'a/font/containing/chinese/charaters.ttf'

f = TTFont(p)
cmap = f.getBestCmap()  # look up the encoding
char = "\u4F5C"  # a char to try
glyphName = cmap[ord(char)]
glyphSet = f.getGlyphSet()
glyph = glyphSet[glyphName]
pen = _TestPen(glyphSet)
glyph.draw(pen)

i'm sorry , the problem is that i have no idea which character containing in this .ttf file, and your code seems  like try to guess whether a character in or not.
i find some code in the internet but i don't know whether it will help with this problem.
def getTTCharMap(font):

	if isinstance(font, str):
		font = ttLib.TTFont(font)

	if not 'cmap' in font:
		raise Exception('missing cmap table')

	gl = {}
	bestCodeSubTable = None
	bestCodeSubTableFormat = 0

	for st in font['cmap'].tables:
		if st.platformID == 0:  # 0=unicode, 1=mac, 2=(reserved), 3=microsoft
			if st.format > bestCodeSubTableFormat:
				bestCodeSubTable = st
				bestCodeSubTableFormat = st.format

	if bestCodeSubTable is not None:
		for cp, glyphname in bestCodeSubTable.cmap.items():
			if cp in gl:
				raise Exception('duplicate unicode-to-glyphname mapping: U+%04X => %r and %r' % (
					cp, glyphname, gl[cp]))
			gl[cp] = glyphname

	return gl

the ttf file is here:
demo.zip
i just want get all of the characters in the file , by the way , i don't want try with every chinese character cause it will take loooooong time.
hope my poor English don't bother you, thank you very much :-)

cmap.keys() will give you all the code points in the font, glyphSet.keys() will give you all the glyph names in the font.
In recent fonttools, much of the function you quote can be done with f.getBestCmap().

thaks bro, but what i want is the character in with red box not the green one, i can open the ttf file with other tools by hands,  but i want get all chinese character with python code .

The code I posted earlier demonstrates how you can extract outlines from a font.

so…can I know which chinese character it is from the outline? (I'm sorry I know nothing about ttf file )

Uhm, fonttools is not an optical character recognition library...

thanks bro，can you give me some advice about get chinese character from a . ttf file? A Lib or something else

Now I have a .fft font file, it contain  some chinese character as I show you before , I want a Lib help me get them and show in Python console . For example I have a font file with English character "A" , I want use a Lib read this file and output a str like character A in Python console.

I'm not sure I can help you. It depends on what application you specifically mean with "Python console". But it seems that fonttools is not the tool to accomplish what you need.
Depending on your shell environment, printing unicode characters may just work. It does in Terminal on macOS:
>>> print("\u4F5C")
作

(This is Python 3 btw. which does unicode a lot better than Python 2.)

if i want print a character "作" like the way you show me , i should have  the unencode character "\u4F5C",
can you tell me if i have a font file , how can i get the character in the red box

You still don't tell me what exactly you mean by "get the character in the red box". Get the character how? Where? In what environment? What platform? What application?

What did you try, what was the result, what was the result that you expected.

for example , i have a font file and i open it with a software named "High-Logic FontCreator" , then i got the  picture like this

i want get the character "A" with python code , what should i do?
i'm using win10 , python3.5 , i try to get all character in the font file, it seems like i open a font file abc.ttf with python and get output "A","B","C",..."Z"

i want it become a str and print it use python

Perhaps you mean:
from fontTools.ttLib import TTFont

p = 'path/to/font.ttf'

f = TTFont(p)
cmap = f.getBestCmap()  # look up the encoding

for char in sorted(cmap):
    print(chr(char))

that's the solution! thank you bro

authors: Dashu-Xu justvanrossum

repo: fonttools/fonttools


text:
Too many fonts for TTC to complete subset

unicodes have up to 6 digits U+10XXXX
test font file
Font.zip

Can you elaborate what this issue is about?

source: gharchive/issue

license: mit

license_type: permissive

license_source: bigquery


text:
pyftsubset: WOFF2 files keep .woff2 extension despite being saved as .otf/.ttf

If you don't provide a --flavor, a WOFF2 file will be saved as an OTF/TTF file, but still with the .woff2 file extension.
This causes unintended false alarms:
Input font: 373412 bytes: Literata-VariableFont_opsz,wght.woff2
Subset font: 599880 bytes: Literata-VariableFont_opsz,wght.subset.woff2

(The font seems ~250K bigger than before subsetting)

Right...
Which one is more desirable, to inherit the flavor of the original? Or to default to ttf/otf?

If the file extension is based on the original, the file should probably also be. Maybe also auto detect for an explicit output file name?

I guess I expected it to stay in the format the input font is in.
And by extension, I would expect the optional --flavor to do any conversion. To WOFF, WOFF2, but maybe also back to OTF/TTF?

authors: RoelN behdad justvanrossum


text:
[ttLib] allow the glyf table to be incomplete when dumping to XML

Allow the glyf table to be incomplete — to not contain all glyphs listed in the glyph order — when writing to XML. Partially addresses #684.

hm.. instead of continue shouldn't you dump an empty TTGlyph element instead?

what happens when loading fromXML where not all glyphs from GlyphOrder are actually present in the glyf table dump? You end up with an incomplete glyf table?
I think there is an implicit guarantee that the glyf table keys and ttFont.getGlyphOrder() be the same, at least after loading a font from file (whether binary or xml).
There's lots of code around that loops over for glyphName in ttFont.getGlyphOrder(): glyph = ttFont["glyf"][glyphName]

oh I see now, you want to support #684...

Well, to some extent. It allows the font from #684 to be dumped, but not recompiled. I'm not sure we need to support either, actually. I was just thinking it doesn't harm us if we allow an incomplete glyf table to be dumped, even if it's broken according to the spec.

ok. how about at least logging a warning for the missing glyphs?

how about at least logging a warning for the missing glyphs?

Good idea, done. Let me know if you want the warning to be worded differently.

source: gharchive/pull-request

authors: anthrotype justvanrossum


text:
Changed logging to use logfmt

Added logfmt as a dependency in the pom file.
Changed defaultLoggingFormatter to use logfmt.
Adjusted test to match the new format.
For the Java logging inconsistencies GUS

Codecov Report

Merging #132 (dec7a91) into main (de22dce) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #132      +/-   ##
============================================
+ Coverage     90.11%   90.15%   +0.04%
- Complexity      522      523       +1
============================================
  Files            92       92
  Lines          1588     1595       +7
  Branches        101      102       +1
============================================
+ Hits           1431     1438       +7
  Misses          143      143
  Partials         14       14

Impacted Files
Coverage Δ

...ns/jvm/runtime/logger/DefaultLoggingFormatter.java
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de22dce...dec7a91. Read the comment docs.

authors: codecov-commenter doriskwan

repo: forcedotcom/sf-fx-runtime-java

license_source: github-api


text:
Remove fields with complex type from WHERE filter in SOQL builder or show validation errors when a user selects them

Steps To Reproduce:

Open SOQL Builder and pick "Contact" as the SObject type
In the Filter section of the builder, pick "MailingAddress"

Expected result
Filter section doesn't allow the user to pick "MailingAddress" when building a conditional expression or shows a validation error when it is selected since "MailingAddress" is of complex type "address"
Actual result
No validation is performed and when the query is run, the user gets the following error message.
Address fields can only be filtered using Distance expressions
https://user-images.githubusercontent.com/10749920/106962003-407dbb80-66f3-11eb-9995-d254e5aaffa3.mov

It would be best to just show a validation error in the UI here instead of removing the field

authors: dehru praksb

repo: forcedotcom/soql-tooling


text:
Detect file moves in local source tracking

What does this PR do?
What issues does this PR fix or reference?
https://github.com/forcedotcom/cli/discussions/2682
@W-15354803@

QA notes:
using deploy-retrieve 3.6.12-dev.2 (dev) w/ dreamhouse
preview looks good before a deploy.
✅ running both this change and regular, the result is consistently 91 items to deploy.
retrieve preview
actual deploy
preview after deploy
create new packageDir and move a file to the same dir over there
renaming an existing file [should still show up as a add + delete]
moving a field from 1 custom object to another
move an unresolvable file (ex: a markdown file)
move an entire bundle
move customLabels file
we see the expected logs coming from STL
deploy preview where we move a file and it's changed in the org [expect a conflict in the new location]

QA notes:
✅ copy paste is treated as an add
✅ move classes to a different dir
✅ move a field from one obj in force-app to another
✅ move the entire object into other-dir
✅ move one field back to an empty object in force-app

QA:
✅ tested with env true, false and not set

authors: iowillhoit mshanemc

repo: forcedotcom/source-tracking


text:
Remove --output-format void in favour of a --no-user-output flag for a more consistent CLI experience

closes  #279

bors r+

repo: foresterre/cargo-msrv


text:
Fix low priority validation for browser password autofill.

Follow-up fix for the https://github.com/formium/formik/pull/2854#issuecomment-722529976
Some edge cases impossible to test without mocking scheduler internals, but since all the scheduler methods considered unstable I think the best way is to test inside the browser.

Ahh shoot can you open another pr with the changeset for this one. It should be a patch. You just need to run yarn changeset and it will walk you through it

authors: jaredpalmer umidbekkarimov

repo: formium/formik


text:
fix(multiCheckbox): Set 'required' validation only when desired. Clos…

…es #37

Looks good. I'll release when I get to my laptop.

Cool :+1:

Thanks! Released as 5.0.2

Nice, I'm glad to help ;)


text:
FN alert on address poisoning

For some reason although this alert was triggered by the address poisoning bot, it was not picked up by the scam detector.
It ended up in an effective address poisoning scam. Here.

Would you mind checking these two other cases? I believe the address poisoning triggered but the logic implemented in the scam detector stopped it from triggering the alert.

Case 1: Address poisoning tx here
. tx when the target fall into the scammer here

Case 2: Address poisoning tx here tx when the target fall into the scammer here

fixed

repo: forta-network/starter-kits

license: MIT


text:
Tracking outage of Travis CI

This is the issue for tracking the out of balance issue with Travis CI.
Updates

So far at 2023-07-13T20:56:44Z, outage of Travis CI issue still not been solved.

Also, since master branch has already migrated  GHA, Travis CI then is only needed for old versions.
And for bors, there's some workflow update need to add make it works with GHA instead of using GCH's merge queue (which is still in Beta)

Migrated to GitHub Action on master branch.
For old branches , we will continue to use Travis CI if we still have enough credit.

Migrated to GitHub Action on master branch.
For old branches , we will continue to use Travis CI if we still have enough credit.

repo: fortanix/rust-mbedtls


text:
fix: Added toast when a badge is saved

Fixes #411
Changes: A toast notification is shown when a badge is saved.
Screenshots for the change:

@adityastic please review.

repo: fossasia/badge-magic-android


text:
Implement standard project workflow

Please implement the standard project workflow with a development branch.

[x] Keep the master dev branch to deploy to heroku.
[x] Add a deployment to heroku from the dev branch.
[ ] Increase code coverage. (Why is it only 30%?)

@hpdang @mariobehling
First two points are already done
https://open-event-generator.herokuapp.com - for master
https://opev-webgen-dev.herokuapp.com - for dev

@championswimmer Thanks for adding the Heroku badge.
Please do add a "deploy to heroku" badge. It is not there. Second point is not done.
Please also include documentation in the /docs folder.

@mariobehling done point 2 now

@hpdang 56% is covered. In the next few days will cover even more.
Please close the issue if all looks good :)

Thanks! Good job.

authors: championswimmer hpdang mariobehling

repo: fossasia/open-event-webapp


text:
Fix erroneous Line Breaks in Track Info Areas

Tries to fix #700 .
The bug mentioned in the issue #700 was occurring because no explicit width was mentioned for the inline block. A new css class titletext is added to fix the issue. 140px was the maximun size i could go with, from 141px onwards the line breaks occur again
Before :

After :

Current coverage is 42.58% (diff: 100%)

Merging #713 into development will not change coverage

@@           development       #713   diff @@
=============================================
  Files                6          6
  Lines              688        688
  Methods             71         71
  Messages             0          0
  Branches           112        112
=============================================
  Hits               293        293
  Misses             395        395
  Partials             0          0

Powered by Codecov. Last update b17761e...4944fa5

@shubham-padia Thank you, but I have already solved this. I will merge this , if it looks good. Please comment on assigned issues before generating PR.

@aayusharora Okay :smile:

Ok @shubham-padia  This is giving not the desired output.
It is giving this

No idea why that occurs :smile: , looks like this on my pc

Ok, I have already solved this https://github.com/fossasia/open-event-webapp/pull/714 hence closing this.

authors: aayusharora codecov-io shubham-padia


text:
Convert rst to md and ensure the documentation builds

Most FOSSASIA repos are using MD files. In order to be able to easily copy from one repo to another for the user documentation here, please convert the rst files to md files.

Can I work on it? Please assign to me.

Go ahead. No need to ask.

@Dishebh I am also working on it.

@Dishebh I am also working on it.

@vidhyav656 cool, I won't interfere then. Just let me know incase if I can join you in it. Or you can just solve it on your own.

With #50 merged, I am closing this. Thank you!

authors: Dishebh mariobehling orangecms vidhyav656

repo: fossasia/pslab-documentation


text:
wrapper utility method for wrapping an FMS model with a Huggingface API

Currently, in order to get the HF adapted FMS model variant, one would need to know the model type and call the appropriate model_class.from_fms_model method. This was somewhat cumbersome and was not great for writing generic script writing as you would need to provide logic to decide what model to create. This PR introduces a new wrap method which will determine the type of FMS model and provide the proper wrapping.
before:
# this gets you the fms model
model = get_model("llama", "7b", model_path=model_path, source="hf", device_type="cuda")

# this gets you the hf adapted fms model
model = HFAdaptedLLaMAForCausalLM.from_fms_model(model)

after
# this gets you the fms model
model = get_model("llama", "7b", model_path=model_path, source="hf", device_type="cuda")

# this gets you the hf adapted fms model
model = wrap(model)

we might want to call it "hf_wrap" or something like that, to be more specific/clearer the exact wrapping we're doing, but otherwise lgtm

renamed to to_hf_api


text:
Background image breaking foundations columns in outlook

How can we reproduce this bug?
Using foundations for email , I have a background image with text overlay that breaks in Outlook.
Write out the HTML (or Inky code) that causes the issue.
This is the code that is causing the problem:

            <spacer size="20"></spacer>

             <spacer size="10"></spacer>

Training Plan Store

Browse through the worlds largest collection of triathlon, cycling and running plans and take the guesswork out of your training.

             <spacer size="6"></spacer>

Browse Training Plans

               <spacer size="16"></spacer>

        </columns>
        <columns small="1" large="1"></columns>
      </row>

**What did you expect to happen?**
Background image to appear with text overlay in a row and column.

What happened instead?
In outlook the image repeats, is full width and breaks the columns below and above.

What email clients does this happen in?
outlook - all

Outlook doesn't support background images, so you're luck you got anything at all... BTH if the text is static and doesn't dynamically change via data then I would just use a full image for this section.

@turneja,

Outlook doesn't support background images...

That's not entirely accurate. This effect is possible in Outlook using Vector Markup Language. Email on Acid Article. Litmus Article.

That's not entirely accurate. This effect is possible in Outlook using Vector Markup Language. Email on Acid Article. Litmus Article.

But not really a cross-client solution =)

@DanielRuf and it's completely out of scope for this project! #wontfix

I agree with @shnizmuffin that this is a very specific usecase that has to be covered by custom CSS and markup.
Alternatively use normal images like most of us do.

authors: DanielRuf mhiland247 shnizmuffin turneja

repo: foundation/foundation-emails


text:
multiple issues with verification on blockscout since version nightly-87bc53fc6c874bd4c92d97ed180b949e3a36d78c

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (43974b0 2023-05-09T00:17:51.920839000Z)
What command(s) is the bug in?
forge create
Operating System
macOS (Apple Silicon)
Describe the bug
When running forge create with the --verify flag and a --verifier-url on a custom chain, I get an error:
ETHERSCAN_API_KEY must be set, even if I have set the flag --etherscan-api-key or set ETHERSCAN_API_KEY as an environment variable.
If I add the --verify flag with a known chain that uses blockscout, I get an error on verification:
"Received error response: status=0,message=Contract source code not verified, result=None"
Deploying to Scroll Alpha
I believe scroll alpha's rpc url is a known chain. When deploying  WETH contract to the scroll alpha chain and verifying it:
on latest nightly version:
forge create --rpc-url https://alpha-rpc.scroll.io/l2 \
  --legacy \
  --private-key $PRIVATE_KEY \
  --etherscan-api-key abc \
  --verifier-url https://blockscout.scroll.io/api? \
  --verify \
  src/WETH10.sol:WETH10

This is the output:
Deployer: 0xf69fEc6d858c77e969509843852178bd24CAd2B6
Deployed to: 0x0ef82DaB14798E63F1B99479Ba689e3f6A6fEb6C
Transaction hash: 0xe56b35386af9f9e63d544c08f3bcafddaa9dd9e95b3bebdefafc2789bc9abdcb
Starting contract verification...
Waiting for etherscan to detect contract deployment...
Start verifying contract `0x0ef82dab14798e63f1b99479ba689e3f6a6feb6c` deployed on scroll-alpha-testnet
Error:
Received error response: status=0,message=Contract source code not verified, result=None

If I go back to version nightly-94777647f6ea5d34572a1b15c9b57e35b8c77b41 the issue goes away:
foundryup --version nightly-94777647f6ea5d34572a1b15c9b57e35b8c77b41

forge create --rpc-url https://alpha-rpc.scroll.io/l2 \
  --legacy \
  --private-key $PRIVATE_KEY \
  --etherscan-api-key abc \
  --verifier-url https://blockscout.scroll.io/api? \
  --verify \
  src/WETH9.sol:WETH9

Output:
Deployer: 0xf69fEc6d858c77e969509843852178bd24CAd2B6
Deployed to: 0x97eb05B8db496B12244BCcf17CF377d00a99b67a
Transaction hash: 0xde25493333138d7a9d63c54a7cc2e583636e71cb02b4bfd66504d01620f36fa0
Starting contract verification...
Waiting for etherscan to detect contract deployment...
Start verifying contract `0x97eb05b8db496b12244bccf17cf377d00a99b67a` deployed on 534353

Submitting verification for [src/WETH9.sol:WETH9] "0x97eb05B8db496B12244BCcf17CF377d00a99b67a".
Submitted contract for verification:
	Response: `OK`
	GUID: `97eb05b8db496b12244bccf17cf377d00a99b67a645a9371`
	URL:
        https://blockscout.scroll.io/api?/address/0x97eb05b8db496b12244bccf17cf377d00a99b67a
Contract verification status:
Response: `OK`
Details: `Unknown UID`

Deploying on a custom L2 chain and verifying on blockscout
When running on a custom l2 chain that I believe forge doesn't recognize, with the latest version I always get the error.
Here is the command I run:
ETHERSCAN_API_KEY=abc forge create --rpc-url {{ my rpc url }} \
  --chain-id {{ my chain id }} \
  --private-key $PRIVATE_KEY \
  --etherscan-api-key asdfasdf \
  --verifier-url {{my blockscout verifier url}} \
  --verify \
  src/WETH9.sol:WETH9

I always get an error on verification:
Start verifying contract `0x961b527b5e298569dbd7b1d90630cc515eb17a4a` deployed on {{ my custom chain id }}
Error:
ETHERSCAN_API_KEY must be set

If I roll back to version nightly-94777647f6ea5d34572a1b15c9b57e35b8c77b41
The command works successfully and my contract is verified.

After some light digging:
ethers-rs does a preverify check to ensure the contract is not already verified
It expects Contract source code not verified as the start of the result object for non-verified contracts.
However, blockscout returns ```
{
"message": "Contract source code not verified",
"result": null,
"status": "0"
}

for not verified. However, the blockscout response is:

{
"message": "Contract source code not verified",
"result": null,
"status": "0"
}

and this is in the message field not the result field.

There may be further issues.

I confirm this issue. We're having exactly the same problem. Rolling back to nightly-94777647f6ea5d34572a1b15c9b57e35b8c77b41 fixes the problem.

I think it’s actually the request parameters being different.
I noticed constructorArguments is misspelled for etherscan and blockscout
doesn’t like that.
On Fri, May 19, 2023 at 11:13 Matthias Seitz @.***>
wrote:

@Evalir https://github.com/Evalir perhaps this is due to Evm versions
ptal
—
Reply to this email directly, view it on GitHub
https://github.com/foundry-rs/foundry/issues/4909#issuecomment-1554737750,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGMCOBCOFLNFCGYC36PHLDXG6E2JANCNFSM6AAAAAAX3WE5BA
.
You are receiving this because you commented.Message ID:
@.***>

ack on this—will give it a closer look. The "good" binary is from quite a while ago so it could be a combination of things—I'd expect this to be a result of changes to the upstream APIs too

@Evalir I have a public devnet that you can use here: https://app.conduit.xyz/published/view/initial-maroon-gull-l2q9o5k7zz
The standard dev accounts have infinite eth. Example command I'm running that runs into an issue:
% forge verify-contract 0xdc64a140aa3e981100a9beca4e685f962f0cf6c9 ./src/Counter.sol:Counter --chain-id 901 --verifier-url https://explorerl2-initial-maroon-gull-l2q9o5k7zz.t.conduit.xyz/api --verifier blockscout""
Counter.sol is just the bundled contract from forge init.

awesome, thanks for that @kahuang. I've hunted down what seemed to be the last issue on blockscout-etherscan verification: https://github.com/gakonst/ethers-rs/pull/2453
I've tested deploying quite a few contracts and verifying them across different chains including yours—but I can't seem to verify any contracts on your instance. The same contract with solc and evm version combo that works when verified on other chains doesn't work on yours. More accurately, it throws this error:
{ status: "1", message: "OK", result: "Unknown UID" }
I think it might be that the instance is not configured properly—there are also some other features broken (search, for example). Is it possible for you to check? Happy to follow up as soon as you do.
Also, note that you must not use a solidity version above 0.8.18, nor an evm version higher than london—verification won't work otherwise as your chain doesn't support these. I recommend setting these on your foundry.toml.

@oveddan Could you try putting --etherscan-api-key after --verify, otherwise the options will be omitted by verify command

Still have this issue :(

any fix for this? facing the same issue

authors: Evalir Hugo0 Kuzirashi hunter-bera iainnash kahuang oveddan silvercondor

repo: foundry-rs/foundry


text:
Test behaves unexpected when using via-ir=true (the Yul pipeline)

Component
Forge
Have you ensured that all of these are up to date?

[x] Foundry
[x] Foundryup

What version of Foundry are you on?
forge 0.2.0 (e918c81 2023-06-27T00:04:31.801932823Z)
What command(s) is the bug in?
forge test
Operating System
Linux
Describe the bug
Problem
    /**
     * Demonstrate that tests don't work as expected with Yul
     * This test should fail, and does fail when run with via-ir=false.
     * But it succeeds when compiled with via-ir=true.
     */
    function testYul() public {
        uint256 time = block.timestamp;
        assertTrue(time == 1, "time is not 1 at the beginning");
        console.log("stored time before: ", time);
        // Problem 1: this warp changes the contents of the "time" variable, even though it shouldn't
        vm.warp(2 hours);
        console.log("stored time after: ", time);

        // Problem 2: none of these assertions fail, even though at least one should
        assertTrue(time == 1, "time is not 1 after warp");
        assertTrue(time == 2 hours, "time is not 1 after warp");

        console.log("This line is executed even though it shouldn't be reachable");
    }

time should always stay 1 in this test.
The test should fail because of the conflicting assertions.

Both expectations hold when compiling with via-ir=false, but neither of them holds when compiling with via-ir=true.
How to reproduce
Find the demo repository and follow the README.
Additional info
I found this problem when compiling my existing tests with via-ir=true for the first time. Now I am unsure how to proceed. In my opinion, this minimal example suggests some bug in foundry. Please advise on how to proceed.
I have not found any related issues.
Praise
Foundry rocks!

Closing as a duplicate, more info and workarounds are found in this linked issue and the other issues that comment links to: https://github.com/foundry-rs/foundry/issues/4934#issuecomment-1546667682


text:
Performance regression between 2bcb4a1 and 293fad7

Component
Anvil
Have you ensured that all of these are up to date?

[X] Foundry
[ ] Foundryup

What version of Foundry are you on?
forge 0.2.0 (293fad7 2024-01-14T00:29:03.206718800Z)
What command(s) is the bug in?
.\anvil.exe --fork-url "ws://127.0.0.1:8546" --auto-impersonate --no-storage-caching --no-mining
Operating System
Windows
Describe the bug
I encounter 2 performance issues between nightly builds 2bcb4a1 (2 Jan 2024) and 293fad7 (14 Jan 2024)
I also verified prior and post versions (Nov 2023-Feb 2024) to be certain the issues showed up sometime between the 2 builds and it's still present in the latest nightly (14 Feb 2024)

Establishing rpc websocket connections fail when opening 32 instances of anvil.exe and requires a wait time of about 6-7 seconds compared to 3 seconds on 2bcb4a1 and around 4-5 in some of the older ones. The behavior is consistent - I mean it's slower in the newer versions for some reason. Opening one instance for the human eye seems to be the same, but it's obviously not quite the same

Opening one instance in fork mode of geth node in the same network (I mean it's low latency) and trying to interact with some contracts takes up to 10x more time more. The environment, code, inputs and calls are the same, only the anvil.exe is different

In one instance eth_call execution time jumped from 19-21 seconds on the older versions to 193-200 seconds on the newer ones.

the contract allows batch reading balances of an input array of tuples like [account address, erc20 token address]

I'm sending 100 calls of 1000 tuples each

the inner code does a simple for and calls balanceOf 1000 times and writes the balance in an output array

the contract was compiled with solidity version 0.8.22 and I used both the non optimized and yul/inline assembly versions and they exhibit the same slow down in newer anvil versions

to get the mentioned execution times (19 seconds/193 seconds) the accounts count is 50K and 11k erc20 tokens mixed to achieve 100k tuples

each anvil version execution time stays roughly the same if I rerun the code - I mean it's consistent within the same version. The 10x it's not a one time thing, it's there all the time for the newer versions

keep in mind the --no-storage-caching option so everything is in memory, but anvil starts from scratch in these tests so nothing is cached anyway

anvil is forked on the latest live block - not using historical data

On the other hand erc20 transfer transactions seem to perform about the same, the performance seems slower on the newer versions but very slightly and I also perform evm_mine and anvil_reset after each transfer transaction so it's hard to reproduce reliably.
The eth_call is blatantly slower

what regressed?
any additional info would be helpful

Enrique the admin in the telegram group mentioned that it might be related to the switch from ethers to alloy
https://github.com/foundry-rs/foundry/pull/6219
I'm going to build a project and share it here to pinpoint the issue better so you may reproduce it much easier

@vlad-blana getting a repro would be amazing 🙏

Here is the repo that reproduces both issues. I only managed to add the demo for the startup issue. The demo for the eth_call issue will come later in 1-2 days.
https://github.com/vlad-blana/repro-foundry-rs-7131

I added the 2nd demo and I understood how to trigger the issue.
The performance regression happens when calling concurrent eth_call at the same time.
A single eth_call seems faster on the newer versions, but when calling 100 it suffers a huge performance penalty that grows even larger on public nodes, 30-40 times slower on the best rpcs and the newer anvil nightly builds.
I built the demos on pulsechain as the fork because I only have a pulsechain private node, but you could easily use your ethereum mainnet rpc and it would still work because the contracts I used exist on both networks and if you also change the contract addresses (uniswap v2 factory and multicall 3) it could easily run on any evm network.
I did not try, but maybe it would be enough to make any 100 concurrent eth_calls and experience the performance regression between the anvil pre 2 Jan versions and post 14 Jan ones.
Also public nodes should be avoided because of the network latency that ruins the experience. But you could change a few settings to minimize the number of network interactions. I mentioned them in the readme, but ask anyway if it's not clear.

authors: Evalir mattsse vlad-blana


text:
fix inline test config: enable ast for test

Motivation
Closes #7310

Solution

pending some test fixes

I thought it never worked, we don't have any tests for inline config.
In any case, I don't want to enable this for all tests since this defeats the purpose of https://github.com/foundry-rs/foundry/pull/7197. I would much rather refactor inline config parsing to not use Solc AST.

I thought it never worked, we don't have any tests for inline config. In any case, I don't want to enable this for all tests since this defeats the purpose of #7197. I would much rather refactor inline config parsing to not use Solc AST.

Hope you bring it back soon. The use case for me is to limit the runs for fork fuzzing tests which are rate limited while going crazy on local fuzzing runs.

I thought it never worked, we don't have any tests for inline config. In any case, I don't want to enable this for all tests since this defeats the purpose of #7197. I would much rather refactor inline config parsing to not use Solc AST.

There are actually couple of tests but seems they are run with ast on https://github.com/foundry-rs/foundry/blob/master/crates/forge/tests/it/inline.rs

Hope you bring it back soon. The use case for me is to limit the runs for fork fuzzing tests which are rate limited while going crazy on local fuzzing runs.

Understandable, I will look into this today, thanks for flagging

Opened https://github.com/foundry-rs/foundry/pull/7431

authors: DaniPopes grandizzy shuhuiluo


text:
2.4 - Remove "Unidentified Description" from Spell Items

I think that spells do benefit from having the Description and Chat Description, but I dont think that the Unidentified Description makes sense for this Item type. Is the Multi-editor All or Nothing?

Tools, loot, and containers also have 'Unidentified description' but do not have an identified property to toggle. For these item types, the description should either be removed, or the toggle added.
Features should have the unidentified description removed.

For Tools, Loot, and Containers I would vote for adding the Identified toggle, as each category can have magical items that require Identification.

This can be closed, the Unidentified description has been removed from the Spell items, and the Tools, Loot, and Containers have added the Identification toggle


text:
System migration compatibility with DataModels

System migrations are currently asynchronous and called from a "ready" hook. In order for full adoption of actor and item TypeDataModels the system frame needs to be adapted. The current hazy plan is:

TypeDataField#migrateSource overrides should check the document's schema version: if lower than a certain cutoff point, data-model migrations are skipped.
System asynchronous migrations operate on the document, catching it up to the schema version cutoff.
The document's TypeDataField is notified to recheck and run migrations for schema versions past the cutoff point, which are exclusively synchronous.
A no-diff update is made for each migrated document, synchronizing the data maintained by the server and what is found in #_source.

Questions/challenges:

Will unlinked tokens suddenly have ballooned delta with the no-diff update? If so, how can this be avoided?
Though we may wish to avoid it in the future, there may be a very strong perceived need for later asynchronous migrations. Should this be anticipated as inevitable and somehow accommodated?

I asked openly in the discord, but would #2 work if a data model exists for the document? @In3luki was under the impression that it will not because the source data will be altered by the data model, and that v12 has not changed in this regard. There was no clarification otherwise in dev-general.

Though we may wish to avoid it in the future, there may be a very strong perceived need for later asynchronous migrations. Should this be anticipated as inevitable and somehow accommodated?

This can only be addressed in core, but one advantage of sync migrations and duplicating the data we're overwriting to make that work is that we don't have to be afraid of future updates to the source data. This thing we did was inherently unsafe and its good that we have to avoid it.
One potential compromise that occurred to me though was flagging an item as "needs refresh". This could skip all later migrations and then asynchronously update the item afterwards. Skipping later migrations would avoid the problem scenario of updating an item to its most recent version, then running a migration that assumes an older version, which is a potential problem of our current structure.

authors: CarlosFdez stwlam


text:
FR: Make Personality section entries on Biography tab expand vertically to fit the content

Currently the Personality section is the only part of the Biography tab that doesn't expand to fit all the text, making it somewhat cumbersome to check at a glance if the contents are longer than a couple words.
Section in question:

For comparison, the Campaign Notes section shows the text in full regardless of the length:

I'd like to highlight this again since the new Edicts and Anathema fields are now also part of this issue. The fields are unfortunately too small for even the shortest examples of Edicts and Anathema to fit in there.


text:
Maps do not work

Create a file with the following:
$my_map: (
    a: 1,
    b: 2
);
```

The error reported is:
```
While building the application:
test.scss: Scss compiler error: undefined
/path/to/test.scss:2: error: error reading values after a
```

@fourseven are source maps working yet?

hi @keyvanfatehi - no they're not, libsass still has issues generating them, which look to be improved in v3.2. node-sass is using v3.1 of libsass in their 2.0.0 beta, so it might be a while yet unfortunately.

too bad. i wanted to ask this as well.
although it seems to be fixed in libsass 3.1.0-beta
http://sassmeister.com/gist/511dee5bbd1a40054d92
btw, a bit OOT, but i tried switching to grigio:ruby-sass. but i'm getting this error even though i already removed your package.
While building the application:
error: conflict: two packages included in the app, grigio:ruby-sass and
fourseven:scss, are both trying to handle .scss
error: conflict: two packages included in the app, grigio:ruby-sass and
fourseven:scss, are both trying to handle .sass

authors: ShimShamSam fourseven keyvanfatehi rizkysyazuli

repo: fourseven/meteor-scss


text:
cpp: support linking statically on Windows

Changelog
Allows building and linking the mcap library statically on Windows.
Docs
None
Description
I'm using mcap_builder to use the mcap library in my project.
Even though mcap is a header-only library, mcap_builder creates a library for the client application to link against.
mcap_builder currently always creates a shared library. I have a PR open to support creating a static library: https://github.com/olympus-robotics/mcap_builder/pull/4
Creating and linking against a static library on Windows causes linking issues because visibility.hpp implicitly assumes dynamic linking.
This PR adds a define that needs to be set when building the library statically. The PR is backwards compatible, i.e. the behavior remains the same as before if the define is not set. The define is named based on CMake convention, see https://cmake.org/cmake/help/latest/module/GenerateExportHeader.html

A few thoughts after a quick review:

I don't like the undocumented and un-commented MCAP_STATIC_DEFINE
This seems like an issue created by mcap_builder and not specific to the mcap library here.

What is an alternative approach that does not mean introducing CMAKE specific un-documented defines to this library?

I guess this could be solved in mcap_builder by not compiling the mcap library into a static or dynamic library but to consume it as header-only library (through CMake interface library).
However, mcap already provides the MCAP_PUBLIC #define which is only required when compiling the mcap library into a static or dynamic library. What is missing, is the support for the specific combination of compiling it as a static library on Windows. The other combinations (dynamic/Windows, static/Linux, dynamic/Linux) are already supported. And not supporting one specific combination is inconsistent.
Regarding documentation, I'm happy to add this to the PR if you point me to the location where it should go (comment in the visibility.hpp header or in some README?).

I think this is fine so long as this additional flag is explained in cpp/README.md under the "Including in your Project" heading.

@wrightsg ping on updating the readme and then we can merge

@wrightsg ping on updating the readme and then we can merge

The README is now updated, apologies for the delay.

authors: defunctzombie james-rms wrightsg

repo: foxglove/mcap


text:
Crazy idea to make an always up to date language-typescript equivalent

Brain dump of an idea I just had before I go to sleep to get around the language-typescript problem:

Make a .d.ts of https://github.com/Microsoft/TypeScript/blob/master/src/compiler/types.ts *.
Somehow convert this to haskell ghcjs ffi, either by using this tool or manually.
Rebuild this tool using the actual typescript parser and types (run it using ghcjs).
We can then automatically regenerate step 2) using this tool rather than doing it manually.
???
Profit

The parser should always be up to date and accurate this way. Requires integrating with typescript though.
* Well, the subset needed by the parser.

That's an awesome idea, I like it!
As mentioned in your PR, it seems that language-typescript is either a bit out of date or lacking some features for parsing these definition files.  Here's the modifications I needed to make to the ace.d.ts to get it to build: https://github.com/fpco/ghcjs-from-typescript/commit/91173fd3013354bf5107cce38aa13db093d666f8
So, probably to bootstrap this for step 2, we can just manually cut down the typescript compiler's definitions till they work with the current tool (possibly filling in some of the missing cases in the code).

authors: CRogers mgsloan

repo: fpco/ghcjs-from-typescript


text:
Catch SIGABRT, and run app-shutdown logic

EDIT we now observed that SIGABRT does not lead to execution of the shutdown lifespan logic. If we can get this to work, then @mfranzon explored a promising route for cleaning up "orphan" jobs - ref https://github.com/fractal-analytics-platform/fractal-server/pull/1506).

(requires #1498)

Verify what is needed upon shutdown (e.g. should we call some cleanup function for the db engines?).
Verify which signals trigger execution of the shutdown (i.e. post-yield operations).

We are especially interested in the following situation

Start fractal-server through gunicorn (with a single worker)
Trigger a timeout error (with a fake endpoint that takes long) or directly send an abort signal to the correct pid
Is the shutdown logic executed?

If the answer is yes, we should add the following:

Query the DB for all V1 and V2 jobs that are marked as submitted
Mark all these jobs as failed
Append a line to these jobs logs, saying something like "Failed because the app was shut down"
If possible, also update the dataset history.

Note: it turns out that in the current version the sigabrt does not trigger the lifespan shutdown. This can probably be changed in fastapi or uvicorn - TBD

Note: it turns out that in the current version the sigabrt does not trigger the lifespan shutdown. This can probably be changed in fastapi or uvicorn - TBD

This changes if we use a custom UvicornWorker class and subclass the init_signals and handle_abort method - see proof of principle in #1506, where we are converting SIGABRTs into SIGTERMs.
The nice aspect of this solution is that it is opt-in:

The standard fractalctl start would not include this feature
For gunicorn, this feature would only be enabled when we modify the startup command (changing the --worker-class option so that it points to this new class).

This means that if we ever hit an issue due to this change of signals, we can roll-back the feature by restarting gunicorn and using the standard uvicorn worker. That's a useful safety net, since this is a bit of an advanced feature which we cannot fully test programmatically.

See https://github.com/fractal-analytics-platform/fractal-server/pull/1506#issuecomment-2124111370 for a minor improvement of the current proof of principle


text:
Optimal I/O and on-disk storage for zarr arrays (chunking scheme + Zarr store)

Opening an issue here for a discussion topic that came up today: What is the optimal chunking we should have for our files.
Thanks to @tcompa 's work on improved chunking here, we now have the ability to rechunk zarr files and to save them with desired chunk sizes at all pyramid levels, see here: https://github.com/fractal-analytics-platform/mwe_fractal/issues/32
What is the optimal size we should chunk files as?
There are two main concerns that may go in sync for a while, but may also become trade-off.
Concern 1)
Interactive accessibility of the data.
Specifically, how nicely can we read in just the chunk of data we are interested in and what kind of access patterns will we have (e.g. at the moment, we are loosely optimizing for displaying xy layers of the data, but not to display xz layers). Also, what is the optimal chunk size for visualization? Increasing chunk sizes for lower-res pyramid structures helped a lot in interactive performance. Would further increases still help or start to hinder performance?
Concern 2)
Number of folders and files saved to the filesystem
I'm no filesystem expert, what we've already started noticing that copying zarr files is quite slow, because it's a very nested structure. And IT at the FMI became worried about file numbers today when we presented our plans for fractal and OME-Zarr usage with regard of what it would mean about number of files needing to be saved. Their preference would be that we'd have equal or fewer files that the raw data.
Both concerns are things we should explore further to find good tradeoffs and exchange with e.g. the OME-Zarr developers about how they handle this on their side.
Also, Zarr has support for reading from zip stores directly (=> would just be 1 file on disk, right?), see her: https://zarr.readthedocs.io/en/stable/tutorial.html#storage-alternatives
Additionally, there are cloud storage approaches for Zarrs for AWS, Google Cloud Storage etc. that may be worth having a look at.

Very interesting discussions & inputs in this image.sc thread: https://forum.image.sc/t/storing-large-ome-zarr-files-file-numbers-sharding-best-practices/70038/6
My main takeaways for Fractal:

Sharding will be the way this will eventually be solved. Things are moving, but hard to judge when sharding will be available. But on a positive note: The Python implementation (which is most relevant to us) will likely be the first implementation. That should allow us to get started with it, even if full adoption as part of OME-NGFF may still take a bit longer.

From Jonathan Striebel:
2) ZIP stores are actually still quite interesting. The main reason nobody seems to have touched them in the OME-NGFF community: They are not

repo: fractal-analytics-platform/fractal


text:
Support react-native-screens in FluidNavigator

We should add support for using react-native-screens in FluidNavigator to be able to minimize the memory and resource pressure on big navigation hierarchies.

Closed by #104

repo: fram-x/FluidTransitions


text:
🛑 SIU Guarani is down

In 7eebe06, SIU Guarani (https://siufai.uncoma.edu.ar/informatica) was down:

HTTP code: 500
Response time: 2869 ms

Resolved: SIU Guarani is back up in e44726f after 20 minutes.


text:
🛑 FAI-web is down

In cd9ad80, FAI-web (https://faiweb.uncoma.edu.ar/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: FAI-web is back up in 828882d.


text:
Adding S3Storage support

As previously discussed, you will find here the following change and addition :

Changed func tableOvhCloudStorage() to func tableOvhCloudSwiftStorage()
Added func tableOvhCloudS3Storage() (different OVH API path from Swift Storage even if Object Storage)

I have tried to make indentation/spacing for the tables and struct definitions clean and have considered the table naming convention.

Change suggestions have been applied and committed.
Thanks for the review.


text:
Potential misinformation and false advertising

On the site it says this library is "small without any external dependency". This is completely dishonest considering you use Gtk for Linux support. This is not only an external dependency, but it's also quite a big/bloated dependency too.

GTK3 is not considered a third-party dependency since it is present "naturally" in practically all Linux distributions. In the same way, WinAPI or Cocoa are not considered third-party dependencies either.
However, NAppGUI tries to be honest with its users and includes a list of all the technologies it depends on.
https://nappgui.com/en/start/start.html#h4

GTK3 is not considered a third-party dependency since it is present "naturally" in practically all Linux distributions. In the same way, WinAPI or Cocoa are not considered third-party dependencies either.
However, NAppGUI tries to be honest with its users and includes a list of all the technologies it depends on. https://nappgui.com/en/start/start.html#h4

WinAPI are Cocoas are APIS which are apart of the OS. GTK is not. GTK is a toolkit libraries which uses the linux APIs. Using GTK is using a library which is doing exactly what your library is doing and more. Except GTK is very bloated too and poorly designed. It does not come by default with linux unless the user has a GTK program installed.
I don't think you're being purposefully dishonest, but you're at least being ignorant.

GTK also supports windows and MacOS why don't you use GTK for those if you're going to use it for one part of your library anyway?

GTK is considered a native UI tech for Linux by other GUI platforms as well, e.g. Eto. It's very standard to assume it as the primary native GUI renderer on Linux.

you're at least being ignorant

You can express disagreements without implying another's ignorance or dishonesty. Let's keep our community welcoming and productive. Thank you.

It is simply not the native GUI renderer for linux and anyone who claims it is is wrong. I don't know what you mean by "the standard native GUI renderer" considering many apps and libraries do not use GTK.
I would suggest you look into software such as xlib and glx or wayland api. Those are native renderers.
GTK is not even designed as a renderer, as the documentation for this library even notes, it is a high level toolkit. This library is also trying to be a high level toolkit. Why would a library trying to be a toll kit use anotehr toolkit? Why would I not just use GTK instead of using another toolkit that just wraps around GTK?
Do you understand what I mean? It's not the native renderer, it's just a very common GUI toolkit.

authors: ColleagueRiley frang75 turbo


text:
Think about to fix the issues found by adapter checker

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:
https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/frankjoke/ioBroker.broadlink2

[ ] [E106] Title should not have word "adapter" in the name. It is clear, that this is adapter. Now: Broadlink2 (RM++, SP++, A1) Adapter for multiple W-Lan devices
[ ] [E115] No license found in io-package.json
[ ] [E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: "npm owner add bluefox iobroker.broadlink2"

ERR:["E106","E115","E201"]:ERR
Thanks,
your automatic adapter checker.

Thanks, that all bugs have been fixed.


text:
Investigate sensor options for Intake, Catapult, Climber position

There will be a need to know whether the Intake is extended before we are able to fire the catapult. The most basic options is that when we extend the Intake we immediately set its internal state to extended. Then we wait a certain amount of time after before allowing the catapult to fire.
Another option would be use a sensor like a limit switch or a Hall effect sensor (magnetic boolean sensor)
https://en.wikipedia.org/wiki/Hall_effect_sensor
These would allow us to sense the position of the intake so that we can get precise timing on knowing when it is extended.

Implemented climber limit switch


text:
Unexplainable delay after "Set outputs"

What time-consuming activity happens after "Set outputs" is printed? I couldn't grasp from the code immediately.

https://github.com/freckle/stack-action/actions/runs/8108910449/job/22163043510#step:3:546

I saw that too, but it seemed intermittent and something happening on the runner that I couldn't observe. Even with debug enabled we're done all of our work before the delay happened. I would love to get to the bottom of this.
My memory is fuzzy, but I think it happened when we had a cache miss but not when we had a cache hit?

@pbrisbin, please reopen this issue (I can't). #69 hasn't solved it, unfortunately

authors: deemp pbrisbin

repo: freckle/stack-action


text:
🛑 EC is down

In 69bef96, EC (https://ec.tut.ac.za) was down:

HTTP code: 0
Response time: 0 ms

Resolved: EC is back up in b440607.

repo: fredre/ecMonitor


text:
Merge refs/heads/1.8/feature/875 into alpha

Merge refs/heads/1.8/feature/875 into alpha

This PR has not been merged into alpha. Please fix the issues and re-open the PR.

repo: fredyk/westack-go


text:
Register sivan.is-a-backend.dev

Added sivan.is-a-backend.dev using the CLI.

Please send a screenshot of your website. Also, what provider are you using?

Please send a screenshot of your website. Also, what provider are you using?

Please send a screenshot of your website. Also, what provider are you using?

Personal website dev

repo: free-domains/register


text:
[Bugs]Support of NIA3 and NEA3 Integrity and Ciphering algorithms

Describe the bug
AMF is not implemented with NIA3 and NEA3 Integrity and ciphering algorithms
I installed the free5GC Stage 3 Installation Guide from this link " https://www.free5gc.org/installations/stage-3/" by following the link "https://www.free5gc.org/stage-3-videos/create-ubuntu-machine/" and the UERANSIM from " https://github.com/aligungr/UERANSIM/wiki/Installation".
I am trying to test all Ciphering and integrity algorithms but found its not implemented yet.
Is there anything i am missing to configure or support is not really present
i can see the below prints on 5GCore console
In 5GCore NEA3 Ciphering algorithm not supported
2021-07-09T03:21:30Z [INFO][AMF][NGAP][10.22.109.75:36574][AMF_UE_NGAP_ID:1] Uplink NAS Transport (RAN UE NGAP ID: 1)
2021-07-09T03:21:30Z [ERRO][AMF][NAS][AMF_UE_NGAP_ID:1][SUPI:imsi-208930000000001] Encrypt error: NEA3 not implement yet.
2021-07-09T03:21:36Z [WARN][AMF][GMM][AMF_UE_NGAP_ID:1][SUPI:imsi-208930000000001] T3560 expires, retransmit Security Mode Command (retry: 3)
In 5GCore NIA3 integrity not supported.
2021-07-09T03:28:18Z [INFO][AMF][GMM][AMF_UE_NGAP_ID:1][SUPI:imsi-208930000000001] Send Security Mode Command
2021-07-09T03:28:18Z [ERRO][AMF][GMM][AMF_UE_NGAP_ID:1][SUPI:imsi-208930000000001] MAC calcuate error: NIA3 not implement yet.
please let me know if logs required.
UERANSIM free5gc-ue.yaml config :
integrity:
IA1: true
IA2: true
IA3: true
ciphering:
EA0: true
EA1: true
EA2: true
EA3: true
5GCore AMF config :
security:  # NAS security parameters
integrityOrder: # the priority of integrity algorithms
- NIA3
# - NIA0
cipheringOrder: # the priority of ciphering algorithms
- NEA3
# - NEA2
To Reproduce
Configure NIA3 or NEA3 algo in amfcfg.yaml config file
Attach UE
Expected behavior
Core should support NIA3 or NEA3 Integrity and ciphering algorithsm
Environment (please complete the following information):
free5GC Version: 3.0.5
OS: Ubuntu 20.04
Kernel version: 5.4.0-77-generic
go version go1.14.4 linux/amd64

Hi @anvi55 ,
In the current version (v3.3.0) or older ones, NIA3 and NEA3 are not supported, we will be working on this.
BRs,
linpoyi


text:
Remove unused parts of strip-comments

          Going through this made it obvious just how little of strip-comments we actually use.

We should expand our tests a little (since we're implicitly relying on a bunch of tests in https://github.com/jonschlinkert/strip-comments that we don't run) and remove everything we don't need, but I'll do that in another PR.
Originally posted by @ojeytonwilliams in https://github.com/freeCodeCamp/curriculum-helpers/issues/120#issuecomment-1907906065

Hi there. Should a test with this as the expected output actually pass? As things stand right now, I'm fairly certain it won't pass.
https://github.com/jonschlinkert/strip-comments/blob/master/test/expected/html/quoted.html

repo: freeCodeCamp/curriculum-helpers


text:
[BETA] Test failure & Typo in "React: Create a Controlled Form" Waypoint

Challenge Name
https://beta.freecodecamp.org/en/challenges/react/create-a-controlled-form
Issue Description
Typo: The lesson states -

The submit handler will be called when the formed is submitted.

Suggested Replacement:

The submit handler will be called when the form is submitted.

Test Failure
Can't get last test to pass [no closed or open issues here, nor on forum], despite testing JSX proving that my code does do what is asked. (I added some html elements to the render() method to prove to myself I wasn't crazy and that the <input/> tag was triggering onChange events that were being handled properly. The extra code I added in the attached codeblock is as follows:

{this.state.input}

The second line should (and does) update with every added or deleted character in the input.
The first line creates a horizontal rule that separates the
 from the
 that displays the value of {this.state.submit}, but doesn't appear until the button is clicked. If the error messages were correct, and "Typing in the input element [doesn't] update the input property of the component's state," then the h2 element shouldn't mirror the input's value.
Browser Information

Browser Name, Version: Firefox 59.0.2
Operating System: Win 8.1, 64-bit
Mobile, Desktop, or Tablet: Desktop

Your Code
class MyForm extends React.Component {
  constructor(props) {
    super(props);
    this.state = {
      input: '',
      submit: ''
    };
    this.handleChange = this.handleChange.bind(this);
    this.handleSubmit = this.handleSubmit.bind(this);
  }
  handleChange(event) {
    this.setState({
      input: event.target.value
    });
  }
  handleSubmit(event) {
    // change code below this line
    this.setState({
      submit: this.state.input
    });
    event.preventDefault();
    // change code above this line
  }
  render() {
    return (

        <form onSubmit={this.handleSubmit}>
          { /* change code below this line */ }
          <input value={this.state.value} onChange={this.handleChange} />
          { /* change code above this line */ }
          <button type='submit'>Submit!</button>
        </form>
        { /* change code below this line */ }

{this.state.submit}

{this.state.input}

        { /* change code above this line */ }

    );
  }
};

Your input value should be {this.state.input} instead.

Thanks! The tests pass now. Which implies to me that the testing suite is looking at something other than the state variables themselves. I am just getting started, so I don't know if those state variables are accessible outside of components in React, or if the test is a regex on the JSX. If the latter, and the test is the best it can be, should I edit my issue back down to just the typo?

It's not a regex matching. The test simply compares value of the input with this.state.input. I'm not 100% sure but looks like if value of input is set to this.state.value which doesn't exist, the test fails to grab the input value itself?

Thanks for the peek under the hood. I was a little confused as to why the behavior seemed to work despite my typo (which I only introduced on the fourth try of resetting my code because I couldn't wipe out other, weirder errors.

Can I fix the typo?

@EditB Thanks for your consideration. I already did it. Their are many issues, no one is working on. You can takeup those issues. Make sure you comment on that issue, that you are working on it. So, anyone else don't duplicate his/her efforts. Happy Coding!

Thanks @varunzxzx. I have a browse and see what else I can fix.

authors: EditB bqnguyen94 varunzxzx vipatron

repo: freeCodeCamp/freeCodeCamp


text:
Sass: Apply a Style Until a Condition is Met with @while Text-1 not passing test

Describe your problem and how to reproduce it:
On the Sass task called "Sass: Apply a Style Until a Condition is Met with @while" the test does not pass for text-1
Add a Link to the page with the problem:
https://learn.freecodecamp.org/front-end-libraries/sass/apply-a-style-until-a-condition-is-met-with-while
Tell us about your browser and operating system:

Browser Name: Chrome
Browser Version: 71.0.3578.98
Operating System: Windows 10 64bit

If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box):

Can you post your actual code, vs. a screenshot, because it appears as if your code is correct, but maybe you have some hidden characters which are throwing off the tests.  Also, did you bring this issue up on the forum first?

Sure:
`
Hello
Hello
Hello
Hello
Hello
Hello
Hello
Hello
Hello
Hello`

Sure

  $x: 1;
  @while $x < 11 {
    .text-#{$x} { font-size: 5px * $x;}
    $x : $x + 1;
    }

</style>

Hello

Hello

Hello

Hello

Hello

Hello

Hello

Hello

Hello

Hello
```

Your code passes when I use it.  You may just need to refresh your browser or clear your cache and try again.  If you would have posted this to the forum, you would have received the same instructions and a much faster response.

I already closed and restarted my browser multiple times however. I am aware that this issue was opened some times earlier on here as well and has since been closed. I tried all the instructions however and it still does not work for me.
What I have not done yet is clearing my cache, however since I am in incognito mode (I am using someone elses notebook for the moment) this should not be much of an issue right?

@RandellDawson I don't think the PR fixing it hasn't been shipped yet. When did we last push the repo to production ?

@mstachalski I am wondering if you have a browser setting which is affecting your ability to go below 6.6667px.  I will ask some others for some more feedback on why you maybe seeing that one specific test related to the text-1 class.
As far as the 2nd issues regarding the increment error, that is a bug in the tests which has yet to be fixed (@thecodingaviator I tested this same code locally on the latest version of the master branch` and it still fails.  I have created PR #35100 to deal with the spacing issues related to incrementing the index.

I was able to get a similar error when my browser was zoomed to 80%. Try making the zoom 100% or other zoom levels and run the tests again @mstachalski.

@RandellDawson Chrome's minimum font size is 6px.

@mstachalski What zoom percentage are you using when you experience this issue.  If you change to 100% zoom, do you still experience the problem?

Hey, sorry for my late reply.
I don't remember anymore since it was quite some time ago. I'm pretty sure it was on 100%. However I was programming on a convertible laptop , alike Microsoft surface. Maybe the screen size / resolution / ratio of that might be the issue?

To anyone who has had problems with this challenge using Chrome, if you go to chrome://settings/fonts and make sure you set minimum font size to the lowest setting, does that allow you to pass all the tests?

To anyone who has had problems with this challenge using Chrome, if you go to chrome://settings/fonts and make sure you set minimum font size to the lowest setting, does that allow you to pass all the tests?

@mstachalski  and @RandellDawson
Thank for your reporting and handling this issue. You saved my day!

authors: PongtheGreat RandellDawson akiko-pusu moT01 mstachalski thecodingaviator


text:
404 Search "See all results for ..."

Describe the bug
Using the search-Field and clicking "See all results ..."
To Reproduce
Steps to reproduce the behavior:

Go to 'https://www.freecodecamp.org/'
Click on 'Search Field' and enter s.th. I did "Flutter" and then I clicked "See all results for Flutter"
See error: "404 Page not found"

I think the error is easy to fix:
The automatic created result link after clicking has double "news"-part:  https://www.freecodecamp.org/news/news/search/?query=Flutter
if I manually remove one "news" as https://www.freecodecamp.org/news/search/?query=Flutter
the result would be the correct one.

@uwsd Thanks for the report!
It seems it's a problem with redirection.

https://freecodecamp.org/ redirects to
https://www.freecodecamp.org/news

and the link is to

https://freecodecamp.org/news/search/?query=flutter which redirects to
https://www.freecodecamp.org/news/news/search/?query=flutter

cc: @raisedadead

Thank you for reporting this @uwsd. This was also a problem on /news. I deployed a quick fix and am working on PRs now.
I noticed that we could change the URLs in the search related files from https://freecodecamp.org/news/search/?query=flutter to https://www.freecodecamp.org/news/search/?query=flutter. This seems to get around the problematic redirect, at least for search results. Still an issue we need to investigate further for other use cases.

@scissorsneedfoodtoo search is still broken? I can't get anything to load for generic searches.

authors: ojeytonwilliams raisedadead scissorsneedfoodtoo uwsd


text:
[RDB] Clarify Salon Appointment Scheduler "Subtask 1.1:16" user story

Affected page
Relational Database Alpha
Salon Appointment Scheduler
Your code
#! /bin/bash
PSQL="psql -X --username=freecodecamp --dbname=salon --tuples-only -c"
# display title
  echo -e "\n~~~~~ MY SALON ~~~~~\n"
  echo -e "Welcome to My Salon, how can I help you?\n"

# get services
SERVICES=$($PSQL "SELECT service_id, name FROM services ORDER BY service_id;")

MAIN_MENU(){

  # display argument if exist
  if [[ $1 ]]
  then
    echo -e "\n$1"
  fi

  # show service menu
  echo "$SERVICES" | while read SERVICE_ID BAR SERVICE_NAME
  do
    echo "$SERVICE_ID) $SERVICE_NAME"
  done

  read SERVICE_ID_SELECTED
  #if input is not INT
  if [[ ! $SERVICE_ID_SELECTED =~ ^[0-9]+$ ]]
  then
    # return to main menu
    MAIN_MENU "I could not find that service. What would you like today?"
  fi

  SERVICE_ID=$($PSQL "SELECT service_id FROM services WHERE service_id =$SERVICE_ID_SELECTED;")
  #if the number input not found
  if [[ -z $SERVICE_ID ]]
  then
    # return to main menu
    MAIN_MENU "I could not find that service. What would you like today?"
  fi
  SERVICE_NAME=$($PSQL "SELECT name FROM services WHERE service_id=$SERVICE_ID")

  # if a valid option
  # ask for phone number
  echo -e "\nWhat's your phone number?"
  read CUSTOMER_PHONE
  CUSTOMER_NAME=$($PSQL "SELECT name FROM customers WHERE phone='$CUSTOMER_PHONE';")

  # if customer not found
  if [[ -z $CUSTOMER_NAME ]]
  then
    # ask for customer name
    echo -e "\nI don't have a record for that phone number, what's your name?"
    read CUSTOMER_NAME
    # insert customer data
    UPDATE_CUSTOMER_RESULT=$($PSQL "INSERT INTO customers(phone, name) VALUES('$CUSTOMER_PHONE','$CUSTOMER_NAME');")
  fi
  CUSTOMER_ID=$($PSQL "SELECT customer_id FROM customers WHERE phone='$CUSTOMER_PHONE';")

  # add appointment time
  echo -e "\nWhat time would you like your $(echo $SERVICE_NAME | sed -r 's/^ *| *$//g'), $(echo $CUSTOMER_NAME | sed -r 's/^ *| *$//g')?"
  read SERVICE_TIME

  # if no time input
  if [[ -z $SERVICE_TIME ]]
  then
    MAIN_MENU "You have to input the time, please try again"
  fi

  #insert appointment
  APPOINTMENT_RESULT=$($PSQL "INSERT INTO appointments(customer_id, service_id, time) VALUES($CUSTOMER_ID, $SERVICE_ID, '$SERVICE_TIME')")
  if [[ $APPOINTMENT_RESULT=='INSERT 0 1' ]]
  then
    echo -e "\nI have put you down for a $(echo $SERVICE_NAME | sed -r 's/^ *| *$//g') at $(echo $SERVICE_TIME | sed -r 's/^ *| *$//g'), $(echo $CUSTOMER_NAME | sed -r 's/^ *| *$//g')."
  else
    MAIN_MENU "Unexpected error occur, please try again."
  fi
}

MAIN_MENU

Expected behavior
I expect it should pass subtask 1.1:16 "If you pick a service that doesn't exist, you should be shown the same list of services again"
Screenshots

System

Device: [e.g. iPhone6, Laptop]
OS: [e.g. iOS 14, Windows 10, Ubuntu 20.4]
Browser: [e.g. chrome, safari]
Version: [e.g. 22]

Additional context
I tried many times, and the code seems fulfill all requirements (especially subtask 1.1:16) (passed all other subtask already)
It's great if anyone can point out the problem
After the user input SERVICE_ID_SELECTED, the code check whether input is a number. If it is a number, the code will check whether the service_id exist in services table. User will be sent back to MAIN_MENU if either condition do not pass

Can you share a dump of your database using the command in the instructions @Ken-Leung-5? pg_dump -cC --inserts -U freecodecamp salon > salon.sql

I am sorry, seems I accidentally close this issue since I am a new user

Reopen

The test runs your script and enters these values at each prompt: 'BadInput', '1', '555-5555', 'Test', 'FakeTime'. I just ran your script with those values and at the end, the script doesn't finish. I get prompted again for my phone number. The script needs to finish so the test can see the output. I think if you change the script so it does that, you will pass. Let me know if that works. I can look into rewording that user story so it's more clear on what happens.

Reopening, because I think that user story could use some clarification.

Had the same issue.
Solved by not echoing the first argument of MAIN_MENU.
ex.
I Changed:
MAIN_MENU "I could not find that service. What would you like today?"
to:
echo -e "I could not find that service. What would you like today?"
MAIN_MENU

After that the tests passed.
Happy coding 👾


text:
Remove class example for step 6 of css box model project

Describe the Issue
For step 6 of the box model project, the third sentence shows an example of how to add a class to a div.
For example,
.

But at this point, the camper will have already built 4 practice projects and 1 certification project before getting to this step.
They will have had plenty of practice to add classes between the colored markers project and cafe menu.
Plus I haven't seen anyone on the forum struggling with this step.
So I don't think we need to add this third sentence at all
Proposed new text
Add a div element in the body and set the class attribute equal to canvas.
This will act as the canvas for your painting.
Affected Page
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-the-css-box-model-by-building-a-rothko-painting/step-6

Hi @jdwilkin4  If you haven't assigned to anyone then could you assign to me so that i will make my first contribution  to open source.

@rahul9852-dot
We are still discussing the issue so it is not available for contribution yet.
To learn more about how to contribute to freeCodeCamp, please read through the contributing docs.

@jdwilkin4 I have gone through contributing docs and installed the project and running in my local. If something came please assign to me.

@rahul9852-dot
We don't assign issues except for staff and moderators.
But any issue marked with the good first issue or help wanted labels are free to work on and you don't need to be assigned to them.
It looks like we have a few help wanted issues open 👍

I agree. We should remove the For example,
. from this step.


text:
spreadsheet project - step 103 instructions are unclear

Describe the Issue
The instructions for step 103 of the spreadsheet project request that a range be created from an array.
The say:
Add a range property which generates a range from nums. Remember that you have a range function you can reuse here.
My solution (listed below) tries to do that by passing in the first number found in nums and the last number found in nums as arguments to the range function.
This solution is not accepted and the hint says:
Your range function should return an array of consecutive numbers from the first number in the argument to the second number in the argument.
On reading this initially I have no clue what this hint is attempting to say. Does it want the range to span from the first number of the array to the second number only? Does it want the range property to define a function that takes two arguments? I'm really not sure what it wants.
After some investigations though it seems that this step wanted the range to be between the first and second numbers of the array.
I think this confusion could have been easily avoided if the instructions just said that.
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-functional-programming-by-building-a-spreadsheet/step-103
Your code

range: nums => range(nums[0], nums[nums.length-1])

Expected behavior
Change the instructions to say:
Add a range property which generates a range from the first number in numsto the second number innums. Remember that you have a range function you can reuse here.
Screenshots
No response
System
N/A
Additional context
No response

One of the tests is checking assert.deepEqual(spreadsheetFunctions.range([1, 5, 10]), [1, 2, 3, 4, 5]);, so it's clearly intended to use first and second number.


text:
fixed markdown formatting

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


text:
ajuste de titulo

ajuste de titulo

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.

authors: AdilsonMoraes RandellDawson


text:
Docker installation monitor not available

after you press : Monitor in web gui you will get :
The page could not be displayed
Monitor Service is not running!
Log extract :
`
2018-07-31 13:29:51 [qtp2124448375-62] INFO  o.a.c.httpclient.HttpMethodDirector - I/O exception (java.net.ConnectException) caught when processing request: Connection refused (Connection refused)
2018-07-31 13:29:51 [qtp2124448375-62] INFO  o.a.c.httpclient.HttpMethodDirector - Retrying request
2018-07-31 13:29:51 [qtp2124448375-62] INFO  o.a.c.httpclient.HttpMethodDirector - I/O exception (java.net.ConnectException) caught when processing request: Connection refused (Connection refused)
2018-07-31 13:29:51 [qtp2124448375-62] INFO  o.a.c.httpclient.HttpMethodDirector - Retrying request
2018-07-31 13:29:51 [qtp2124448375-62] INFO  o.a.c.httpclient.HttpMethodDirector - I/O exception (java.net.ConnectException) caught when processing request: Connection refused (Connection refused)
2018-07-31 13:29:51 [qtp2124448375-62] INFO  o.a.c.httpclient.HttpMethodDirector - Retrying request
2018-07-31 13:29:51 [qtp2124448375-62] WARN  c.g.f.w.app.page.monitor.MonitorPage - Could not find the monitor server
java.net.ConnectException: Connection refused (Connection refused)
at java.net.PlainSocketImpl.socketConnect(Native Method)
at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
at java.net.Socket.connect(Socket.java:589)
at java.net.Socket.connect(Socket.java:538)
at java.net.Socket.(Socket.java:434)
at java.net.Socket.(Socket.java:286)
........
'

yes i am aware of it. the monitor service was removed at one point, in addition to some other services that i also dont want to continue supporting. I am currently thinking about what i can replace it with.
If you are in docker, you can verify that services are running by issuing docker ps in command line and inspecting output.

Going to bring back the monitor service, but it will be redesigned to work with spring boot actuator endpoints, which are much better to assess system status.

Brought back to live in https://github.com/freeacs/freeacs/commit/4e4585859baca1ff086ee5badbc5d83ce47e4d7e

Fixed. do a docker-compose -p freeacs down and docker-compose -p freeacs up -d (i think it will pull latest images). Monitor should now work.

nope i cannot confirm that it started to work . i pulled latest version images and
after it i did "docker-compose -p freeacs up --force-recreate -d" and still have same issue.

how are you running the docker compose file? i introduced a new file, .env that needs to be in the same directory as docker-compose.yml. Either download that file or clone the repo. Its in the scripts folder.
You need to run docker-compose -p freeacs pull .. figured that out for myself now :P

i needed an .env file to be able to override host for syslog server and generally being able to override env variables in docker-compose. Oh .. you need to redownload the docker compose file. Its changed

see https://github.com/freeacs/freeacs/issues/162 for how to get stuff working after my last changes.

repo: freeacs/freeacs


text:
chore: lombokify and cleanup

Summary by CodeRabbit

New Features

Enhanced file type handling with a new method for easier setting and conversion.

Refactor

Improved code quality across various components with the introduction of Lombok annotations for cleaner data handling and reduced boilerplate code.
Streamlined database interaction patterns, including more robust null checks and the use of try-with-resources for better resource management.
Updated method signatures and logic for increased efficiency and readability.

Bug Fixes

Fixed potential null pointer exceptions in syslog event expressions.

Documentation

Updated Javadoc comments for better clarity on method functionalities.

@coderabbitai review UnitJobs after last commit

@coderabbitai are the new sql text block sqls identical to their previous counterparts ?


text:
"Token is invalid" error if not filling user and organisation

Description:
Alice opens the dialog to manually add an entry, provides a name, and copies correctly the value of the Secret, as well as the right settings for Type, Digits, Algorithm...
Expected result:
The OTP entry gets added.
Actual result:
An error message is shown saying:

Token is invalid!
The token you are attempting to add is invalid. Please alert your token provider

What actually happens:
If either the name (the input box prefilled jdoe@example.com) or organisation (the input box prefilled Example Inc.) is empty, the procedure fails with the above misleading message.
These fields are not actually needed for functionality (in fact, it is possible to edit the entry later and remove them), and the error message is misleading, since it complains about an invalid token, while the secret is fine, the application is really rejecting the entry metadata.
What should be happening:
It should be possible to leave empty the name, organisation or even both field, when manually adding a token.

@justin-stephenson I would like to fix this, since I think this behaviour is really confusing. Would you like to force having user and organization with a proper error message or allow to leave it blank?

@DreamyLynn I am okay to allow leaving those fields blank, as they can always be edited and changed later. Thank you.

authors: DreamyLynn Keisial justin-stephenson

repo: freeotp/freeotp-android


text:
How to delete an entry?

Scanned two times Amazon qrcode and got two entries obviously the second one obsoletes the first but the UI has no delete .... wonder if I missed anything? Cheers

Hi @fkam18,
Click on the service icon then trash icon that appeared in the top toolbar.


text:
Hide TOTP code on second tap

I need to be able to hide a TOTP code once I have entered it, could you consider adding this functionality?

Why do you want this? Can you help me understand what you are protecting against with this feature?

When I am setting up a new machine I need to keep the FreeOTP app open for a while, but at the same time I want to keep the amount of time these codes are visible to the minimum. So I'd like to be able to hide the ever-changing TOTP for an account once I am done.

I don't think this provides any additional security. The TOTP should only be valid for a single use. So having someone see the code after you use it doesn't matter.

The code may be valid for a single use, but multiple codes are shown - the code keeps on changing while the app is open.

Example:

All codes are hidden
Tap the Red Hat account to get a code
Code is unhidden and stays on screen
Enter code on Red Hat
Go to GitHub, tap Git Hub account to get a code
Code is also unhidden and also stays on screen
etc.

Either only one code should be visible at a time on screen, or codes should only be displayed until they change, or the user can decide when a code gets hidden without having it pushed onto them.

Could you reconsider this?
Having a password/code visible for longer than it needs to be visible is really bad!

Yes, this is a problem. I will address it.

Doesn't the app show a maximum amount of two codes per token? After that time the codes disappear and only show "- - - - - -". But it should show two codes. It happens often that when tapping, the remaining time for the first code is not long enough and you have to wait for the second. Maybe we could implement a setting? So users can choose if the app shall show one or two codes.

The app shows two codes per token tap once and the code shows, but I expected tap again to hide, and didn't get any reaction so I posted here.

as a workaround you can tap-hold which starts the move-mode(so to speak) it but also hides the code

authors: hpaantee npmccallum roweryan xftroxgpx


text:
Feature request: Get icon from site favicon.

When you add an authentication method, it would be nice if the icon defaulted to the favicon for that site, rather than being left as the default.

I think the favicon would have way too small resolution. Use apple touch icon instead

authors: mueller-ma peterbraden


text:
Documentation in contrast to to PR#129

Hello,
thanks alot for FreeOTP!
I have found an the following inconsistency:  The user is informed, that  when creating a locked token as follows "WARNING: Locked tokens are not included in backups for security reason" , while parts of the code indicate the oposite:

Code informing the user that locked tokens are not backed up:
https://github.com/freeotp/freeotp-ios/blob/5a1696ef1eaf5e0c1f739b6d0e75f136ba6671d6/FreeOTP/Base.lproj/Main.storyboard#L401

while this part of the code  intends to exactly do the opposite.  (this was introduced in   PR #129  "Enable encrypted keystore backup ")
https://github.com/freeotp/freeotp-ios/blob/5a1696ef1eaf5e0c1f739b6d0e75f136ba6671d6/FreeOTP/KeychainStore.swift#L55
Before PR  #129  The code did what was displayeds to the user:
https://github.com/freeotp/freeotp-ios/blob/b053bfbf8dc31b951e2480c2eddf81116eff45a6/FreeOTP/KeychainStore.swift#L55

I would like to petition for  having tokens that can not leave the device  or can be configured not to leave the device.  Reason: With Two Factor Authentication there should be the factors "Knowledge" (Password) and Ownership (Token) involved. When the token can be backed up (encrypted with an other password) and be restored to multiple devices the "Two Factor" is circumvented.   If following this idea the Change in line 55 in file FreeOTP/KeychainStore.swift  from PR #129  should be reverted.
Kind regards,
Manon

Hello,
...
I would like to petition for having tokens that can not leave the device or can be configured not to leave the device.

Hello, locked keychain items are protected with biometrics userPresence flag. This enforces device only access, locked tokens will not be included in encrypted backups. You should be able to easily confirm this behavior by testing, if you have any suggestions to improve documentation then feel free to submit a PR. Thank you.

@manonfgoo Are you okay to close this issue, or do you need any further clarification?

authors: justin-stephenson manonfgoo

repo: freeotp/freeotp-ios


text:
Gradle 4.0.1

Please add an image for Gradle 4.0.1.
Thanks!

ok, created build to 4.0.1, thank you.

authors: cazacugmihai frekele

repo: frekele/docker-gradle


text:
Failing e-Internationalization unit test

One of the brokers unit test fails:
http://rv1443.1blu.de:8082/job/Broker/672/ says
Failed tests:
  EInternationalizationTest.testOdt:151 expected:<400> but was:<200>

Tests run: 42, Failures: 1, Errors: 0, Skipped: 0

[ERROR] There are test failures.

@borriellom can you please check whats wrong there and maybe fix the problem?

That's a test from the Broker unit tests. I don't know why the response was 400. Nothing has changed in the management of odt files in e-Internationalization.

Sorry for the noise. I think the test failed because of https://github.com/freme-project/freme-ner/issues/64 . So the problem originates from FREME NER and not from e-Internationalization.
I leave this open. We will check again if the tests fail when the issue with FREME NER is solved.

FREME NER is up and running but the problem still occurs.
@ArneBinder  can you please try to fix the problem?

The problem originates from within e-Internationalization. I added some debug output to the ODT unit test. A test ODT file with some content gets converted to
@prefix xsd:   <http://www.w3.org/2001/XMLSchema#> .
@prefix itsrdf: <http://www.w3.org/2005/11/its/rdf#> .
@prefix nif:   <http://persistence.uni-leipzig.org/nlp2rdf/ontologies/nif-core#> .
@prefix dc:    <http://purl.org/dc/elements/1.1/> .

<http://freme-project.eu/~okapi-23_OpenOfficeFilter_1850160987989945710.tmp/#char=0,0>
        a       nif:String , nif:Context , nif:RFC5147String .

There is no isString property. This causes the failure.

This should be fixed now. Please, @jnehring  check if tests are successful now.

Works fine. Thank you

authors: borriellom jnehring

repo: freme-project/e-Internationalization


text:
GROUP function on our SPARQL endpoint

Our SPARQL endpoint does not support the GROUP function. We need this for the filter queries.
@m1ci can you do something about that?
I recall from our discussions on the hackers meeting in Athens that we either have to update Virtuoso to the latest version (7.something) or we have to install a certain extension.

Can you please share SPARQL query which is using GROUP BY aggregation and does not work?

Endpoint: http://rv2622.1blu.de:8890/sparql
Graph IRI: http://localhost:8890/test-jan
SPARQL query:
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
select  (lang(?anchorOf) as ?language) (str(?anchorOf) as ?anchor) ?confidence (GROUP_CONCAT(DISTINCT ?label;SEPARATOR = ", ") AS ?new_label) (GROUP_CONCAT(DISTINCT ?uri;SEPARATOR = ", ") AS ?new_uri) where {
 ?term <http://www.w3.org/2005/11/its/rdf#term> "yes".
 ?term <http://persistence.uni-leipzig.org/nlp2rdf/ontologies/nif-core#annotationUnit> ?annotationUnit .
  ?term <http://persistence.uni-leipzig.org/nlp2rdf/ontologies/nif-core#anchorOf> ?anchorOf.
 ?annotationUnit rdfs:label ?label.
 ?annotationUnit <http://www.w3.org/2005/11/its/rdf#taConfidence> ?confidence.
 ?term <http://www.w3.org/2005/11/its/rdf#termInfoRef> ?uri
}
group by  ?annotationUnit ?confidence ?anchorOf ORDER by desc ( ?confidence )

Error message
Virtuoso 37000 Error SP030: SPARQL compiler, line 4: syntax error at 'GROUP_CONCAT' before '('

SPARQL query:
define sql:big-data-const 0
#output-format:text/html
define sql:signal-void-variables 1 define input:default-graph-uri <http://localhost:8890/test-jan> PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
select  (lang(?anchorOf) as ?language) (str(?anchorOf) as ?anchor) ?confidence (GROUP_CONCAT(DISTINCT ?label;SEPARATOR = ", ") AS ?new_label) (GROUP_CONCAT(DISTINCT ?uri;SEPARATOR = ", ") AS ?new_uri) where {
 ?term <http://www.w3.org/2005/11/its/rdf#term> "yes".
 ?term <http://persistence.uni-leipzig.org/nlp2rdf/ontologies/nif-core#annotationUnit> ?annotationUnit .
  ?term <http://persistence.uni-leipzig.org/nlp2rdf/ontologies/nif-core#anchorOf> ?anchorOf.
 ?annotationUnit rdfs:label ?label.
 ?annotationUnit <http://www.w3.org/2005/11/its/rdf#taConfidence> ?confidence.
 ?term <http://www.w3.org/2005/11/its/rdf#termInfoRef> ?uri
}
group by  ?annotationUnit ?confidence ?anchorOf ORDER by desc ( ?confidence )

I've updated our Virtuoso instance to version 07.20.3212
This should fix your issue. The query is valid.

Thanks. Unfortunately the query produces no output.
I also cannot open the conductor: http://rv2622.1blu.de:8890/conductor/
The query SELECT ?s ?p ?o WHERE {?s ?p ?o} does not produce any output as well on my graph http://localhost:8890/test-jan. Is it maybe deleted?

Thanks. Unfortunately the query produces no output.
The query SELECT ?s ?p ?o WHERE {?s ?p ?o} does not produce any output as well on my graph http://localhost:8890/test-jan. Is it maybe deleted?

Yes, it was deleted.

I also cannot open the conductor: http://rv2622.1blu.de:8890/conductor/

Trying to fix that now.

fixed, please check.

Ok thanks. I can open the conductor now. But my dataset is gone.  It is no problem that my test dataset is gone, but did we loose any other important datasets?

No we did not. Actually, we have backup dumps of all our datasets. Also, everything is available via LDF too.

Ok thanks for updating the endpoint

repo: freme-project/e-Link


text:
Question: does the tool support arbitrary Darwin Core terms / column names?

I noticed the CSV file with column name, types, ...
I understand the usefulness of having types and restrictions on columns, but given the variability of the DwC-A "in the wild" and the difficulty to know exactly what's part of each standard, I think it would be good if the tool also support arbitrary columns (assign them the type string).
(maybe that's already the case, didn't checked...)

That's indeed already the case. Terms not present in the DwCVocabulary table are treated with 'string' type.

authors: andrejjh niconoe

repo: frictionlessdata/FrictionlessDarwinCore


text:
[docs] Do "Needs Analysis" and generate job stories

Documentation serves a purpose, especially so for Frictionless Data project. It would be great to start out by clarifying the "need" or "job to be done" for docs, and, more broadly, content such as tutorials etc. We could then distill these needs into job stories (or user stories) - see http://handbook.datopian.com/job-stories/

INVALID / DUPLICATE. See #497

repo: frictionlessdata/project


text:
v0.1.16

PR Description
Summary

pf vm list is deprecated. Now pf gpu list should be used.
When creating a deployment, GPU type and GPU count are used instead of VM type.
Deployment config schema is changed.
"max_num_tokens_to_replace" option is added to the deployment config.

Type of Change

New feature
Breaking change
Documentation update

Currently, GitHub Actions service is down. I will merge this PR as-is even if the CI fails. I will re-run the CI after the GitHub

repo: friendliai/periflow-client


text:
update requirements, update owa/email app

WIP:
[x] remove comment "# No extra requirements needed" when requirements were present
[x] email/OWA: remove unused libs, added message-id as top field in returned json
[x] email: return nested dict instead of flat one like in owa, upload email/attachments to shuffle

Nice :fire:

Nice :fire:

authors: dadokkio frikky

repo: frikky/Shuffle-apps


text:
reduce bundle sizes

Hi! I thought a good first task would be to see if the bundled JS can be reduced.
Here's a summary of my changes. Please let me know if you have any questions or if I should remove anything!
Miscellaneous

Minor README fixes after setting up the project
Fixed Python warning about yaml.load
Add .prettierrc and run Prettier on JS/HTML

Prettier is a tool that automates code formatting

Removed .vscode from .gitignore

Associate HTML files with Jinja
Added Jinja and Prettier as recommended extensions

Bundle Size

Added npm run stats which produces stats.json

You can plug the stats into something like Webpack Visualizer

Replaced bundled Mapbox with CDN links

mapbox-gl.js comprised 70% of the bundle, over 600k
Easier to cache separately (Mapbox's server is already a network dependency anyway)
Much less to download for new versions

Don't include all of @babel/polyfill

useBuiltIns: 'usage' includes polyfills as-needed
shippedProposals: true avoids transforming features that have been shipped to browsers for a while
corejs 3 for future-proofing

Results

Bundle with mapbox; 884.3k for main.js

Bundle without mapbox; 102.1k for main.js

Bundle without mapbox or entire @babel/polyfill; 65.6k for main.js

This looks great, thank you! Is it possible to separate out the formatting changes from those that reduce the bundle size?

For sure! I'll update this and make that a separate PR.

thank you--very excited about incorporating this! such a huge improvement

Fixed!

awesome, thanks :)

authors: frnsys pstoica

repo: frnsys/scanmap


text:
mdx-loader not working with react-scripts@5.0.0

After updating an existing React app lxkns to react-scripts 5.0.0 the documented method of using mdx-loader with babel-loader
import AboutMDX from "!babel-loader!mdx-loader!./About.mdx"

does not work anymore. AboutMDX contains a string which is the path name to the Javascript file compiled from the .mdx source, but not the required React component or function.

Yup, having the same issue here. Had to downgrade react-scripts to 4.0.3

authors: TheDiveO mzusev

repo: frontarm/mdx-util


text:
Maniac will never break combo, and no option to do so

Basically as the title suggests. Either you set the humanization/randomization very high and it will be all over the place and sometimes miss, or, if you want it to get decent scores, you set them both at a place where they will hit some 200s in fast parts, but there is no way the program will accidentally drop a note. Maybe a nice feature to add would be the option to have a chance to miss a note at high notes per second after the combo is x high

As I understand the idea you're suggesting, it is a special case of #88 so I'll close it in favor of that.

repo: fs-c/maniac


text:
Update google-cloud-nio to 0.127.14

About this PR
📦 Updates com.google.cloud:google-cloud-nio from 0.127.11 to 0.127.14
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.cloud", artifactId = "google-cloud-nio" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.google.cloud", artifactId = "google-cloud-nio" }
}]

labels: test-library-update, early-semver-minor, semver-spec-patch, commit-count:1

Superseded by #1066.