text:
HBASE-25113 [testing] HBaseCluster support ReplicationServer for UTs

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 11s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-24666 Compile Tests _

+1 :green_heart:
mvninstall
4m  4s
HBASE-24666 passed

+1 :green_heart:
checkstyle
1m 16s
HBASE-24666 passed

+1 :green_heart:
spotbugs
2m 10s
HBASE-24666 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 53s
the patch passed

-0 :warning:
checkstyle
1m 12s
hbase-server: The patch generated 5 new + 206 unchanged - 1 fixed = 211 total (was 207)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
18m 54s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 20s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

43m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2662

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml

uname
Linux 46dbe6d44000 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-24666 / 34e49bc8f6

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-24666 Compile Tests _

+1 :green_heart:
mvninstall
5m 41s
HBASE-24666 passed

+1 :green_heart:
compile
1m 24s
HBASE-24666 passed

+1 :green_heart:
shadedjars
9m  5s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
HBASE-24666 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 29s
the patch passed

+1 :green_heart:
compile
1m 26s
the patch passed

+1 :green_heart:
javac
1m 26s
the patch passed

+1 :green_heart:
shadedjars
8m 28s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 50s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
136m 58s
hbase-server in the patch passed.

173m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2662

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 454c245094ce 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-24666 / 34e49bc8f6

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/1/testReport/

Max. process+thread count
4438 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 47s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-24666 Compile Tests _

+1 :green_heart:
mvninstall
5m  8s
HBASE-24666 passed

+1 :green_heart:
compile
1m 13s
HBASE-24666 passed

+1 :green_heart:
shadedjars
8m 16s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
HBASE-24666 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 42s
the patch passed

+1 :green_heart:
compile
1m 18s
the patch passed

+1 :green_heart:
javac
1m 18s
the patch passed

+1 :green_heart:
shadedjars
8m 49s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
156m  1s
hbase-server in the patch passed.

190m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2662

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d9f5d8c39016 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-24666 / 34e49bc8f6

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/1/testReport/

Max. process+thread count
3928 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m  6s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-24666 Compile Tests _

+1 :green_heart:
mvninstall
4m 31s
HBASE-24666 passed

+1 :green_heart:
checkstyle
1m 14s
HBASE-24666 passed

+1 :green_heart:
spotbugs
2m 13s
HBASE-24666 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  2s
the patch passed

+1 :green_heart:
checkstyle
1m 18s
hbase-server: The patch generated 0 new + 206 unchanged - 1 fixed = 206 total (was 207)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
19m 55s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s
The patch does not generate ASF License warnings.

46m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2662

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml

uname
Linux 7bc521d1625e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-24666 / 34e49bc8f6

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m  7s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-24666 Compile Tests _

+1 :green_heart:
mvninstall
3m 58s
HBASE-24666 passed

+1 :green_heart:
compile
1m  5s
HBASE-24666 passed

+1 :green_heart:
shadedjars
6m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
HBASE-24666 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  0s
the patch passed

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

+1 :green_heart:
shadedjars
6m 38s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

-1 :x:
unit
133m 29s
hbase-server in the patch failed.

164m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2662

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ab1b01d21bda 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-24666 / 34e49bc8f6

Default Java
AdoptOpenJDK-11.0.6+10

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/2/testReport/

Max. process+thread count
4428 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-24666 Compile Tests _

+1 :green_heart:
mvninstall
3m 49s
HBASE-24666 passed

+1 :green_heart:
compile
0m 59s
HBASE-24666 passed

+1 :green_heart:
shadedjars
6m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
HBASE-24666 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
shadedjars
6m 33s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
142m 56s
hbase-server in the patch passed.

169m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2662

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f786a772d93c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-24666 / 34e49bc8f6

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/2/testReport/

Max. process+thread count
4644 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
7m 42s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  1s
The patch does not contain any @author tags.

_ HBASE-24666 Compile Tests _

+1 :green_heart:
mvninstall
4m 13s
HBASE-24666 passed

+1 :green_heart:
checkstyle
1m 15s
HBASE-24666 passed

+1 :green_heart:
spotbugs
2m 13s
HBASE-24666 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 51s
the patch passed

+1 :green_heart:
checkstyle
1m 15s
hbase-server: The patch generated 0 new + 206 unchanged - 1 fixed = 206 total (was 207)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
19m 32s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 17s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

50m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2662

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle xml

uname
Linux 983ea7dc6b5c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-24666 / 34e49bc8f6

Max. process+thread count
84 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-24666 Compile Tests _

+1 :green_heart:
mvninstall
4m 30s
HBASE-24666 passed

+1 :green_heart:
compile
1m 12s
HBASE-24666 passed

+1 :green_heart:
shadedjars
8m 24s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
HBASE-24666 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 17s
the patch passed

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

+1 :green_heart:
shadedjars
7m 57s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
151m 47s
hbase-server in the patch passed.

183m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2662

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux badcadb5d46e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-24666 / 34e49bc8f6

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/3/testReport/

Max. process+thread count
4445 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 16s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-24666 Compile Tests _

+1 :green_heart:
mvninstall
4m 44s
HBASE-24666 passed

+1 :green_heart:
compile
1m 12s
HBASE-24666 passed

+1 :green_heart:
shadedjars
7m 23s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
HBASE-24666 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 29s
the patch passed

+1 :green_heart:
compile
1m 12s
the patch passed

+1 :green_heart:
javac
1m 12s
the patch passed

+1 :green_heart:
shadedjars
7m 20s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
204m 13s
hbase-server in the patch passed.

235m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2662

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c3b55fee7e70 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-24666 / 34e49bc8f6

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/3/testReport/

Max. process+thread count
3184 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2662/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

authors: Apache-HBase ddupg


text:
HBASE-25559 Terminate threads of oldsources while RS is closing

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 56s
master passed

+1 :green_heart:
compile
3m 21s
master passed

+1 :green_heart:
checkstyle
1m  4s
master passed

+1 :green_heart:
spotbugs
2m  8s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 33s
the patch passed

+1 :green_heart:
compile
3m  9s
the patch passed

+1 :green_heart:
javac
3m  9s
the patch passed

+1 :green_heart:
checkstyle
1m  5s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
20m 34s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m 28s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

51m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2938/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2938

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 0cc5b36cadde 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d6aff6cbae

Default Java
AdoptOpenJDK-1.8.0_232-b09

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2938/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 33s
master passed

+1 :green_heart:
compile
1m  8s
master passed

+1 :green_heart:
shadedjars
6m 59s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 12s
the patch passed

+1 :green_heart:
compile
1m  9s
the patch passed

+1 :green_heart:
javac
1m  9s
the patch passed

+1 :green_heart:
shadedjars
6m 50s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
133m  7s
hbase-server in the patch passed.

162m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2938/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2938

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 9e5a84c2c5bf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d6aff6cbae

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2938/1/testReport/

Max. process+thread count
4528 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2938/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 17s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 55s
master passed

+1 :green_heart:
compile
1m  1s
master passed

+1 :green_heart:
shadedjars
6m 38s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 32s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
6m 36s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
149m  2s
hbase-server in the patch passed.

176m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2938/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2938

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ae46464e63f1 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / d6aff6cbae

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2938/1/testReport/

Max. process+thread count
4366 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2938/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thanks @wchevreuil @virajjasani @saintstack for reviwing, I added a UT for this PR, please take a look.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 49s
master passed

+1 :green_heart:
compile
3m 11s
master passed

+1 :green_heart:
checkstyle
1m  7s
master passed

+1 :green_heart:
spotbugs
2m  1s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 24s
the patch passed

+1 :green_heart:
compile
3m  8s
the patch passed

+1 :green_heart:
javac
3m  8s
the patch passed

+1 :green_heart:
checkstyle
1m  5s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 16s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m  9s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

45m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2938/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2938

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 0d25814265e6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ae063f953e

Default Java
AdoptOpenJDK-1.8.0_232-b09

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2938/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 20s
master passed

+1 :green_heart:
compile
1m  7s
master passed

+1 :green_heart:
shadedjars
6m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 13s
the patch passed

+1 :green_heart:
compile
1m  9s
the patch passed

+1 :green_heart:
javac
1m  9s
the patch passed

+1 :green_heart:
shadedjars
6m 53s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
139m 38s
hbase-server in the patch passed.

168m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2938/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2938

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f7e9aaee6b62 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ae063f953e

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2938/2/testReport/

Max. process+thread count
4502 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2938/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 50s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 18s
master passed

+1 :green_heart:
compile
1m  3s
master passed

+1 :green_heart:
shadedjars
7m 31s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 45s
the patch passed

+1 :green_heart:
compile
0m 59s
the patch passed

+1 :green_heart:
javac
0m 59s
the patch passed

+1 :green_heart:
shadedjars
6m 46s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
148m 33s
hbase-server in the patch passed.

178m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2938/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2938

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 18a5f0a14f6e 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / ae063f953e

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2938/2/testReport/

Max. process+thread count
4046 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2938/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

source: gharchive/pull-request

repo: apache/hbase

license_type: permissive

license_source: github-api


text:
add 'oraclejdk10' to Travis build matrix

The build was failing due to conflicts with Maven Surefire plugin and Mockito.

repo: apache/httpcomponents-client


text:
IGNITE-9669 implemented

IGNITE-9669
Closed

authors: SGrimstad dspavlov

repo: apache/ignite


text:
fix import/export csv script bug

I have fixed this issue

authors: MyXOF qiaojialin

repo: apache/incubator-iotdb


text:
adjust nginx logs to be more consistent with system logs

@jeremiaswerner is this still valid? If so, can you rebase and assign?

not merged

authors: jeremiaswerner rabbah

repo: apache/incubator-openwhisk


text:
[TC-7] break down mysql-to-postgres conversion docker-compose setup

merged to psql-rebase

repo: apache/incubator-trafficcontrol


text:
KAFKA-3782: Ensure heartbeat thread restarted after rebalance woken up

FYI: I've had about 30 successful executions of the failing test case. Previously, I could get the failure after 2-3 executions.

LGTM. Merged to both trunk and 0.10.1.

authors: guozhangwang hachikuji

repo: apache/kafka


text:
KAFKA-6382: Make ProducerConfig and ConsumerConfig constructors public

DO NOT MERGE
This is the PR for KIP-243 that is not voted yet.
Related to #4315 -- if the other PR get's merge first, we should update this PR to make use of the available constructors. If this PR gets merged first, #4315 need to be updated before merged.
Call for review @bbejeck @guozhangwang @dguy


text:
Cleanup docs for HDFS connector

@prateekm @lhaiesp FYI..

repo: apache/samza

license_source: bigquery


text:
Update old snapshot deps to current snapshots

I think that since it's a sample it's better to use the latest releases if possible.

Will try with releases and update the pr

The release versions worked but I had to also had to add the hc api as dependency.. seems it is not included transitively anymore.

authors: cschneider rombert

repo: apache/sling


text:
STORM-2338: Subprocess exception handling is broken in storm.py on Windows environment

+1

authors: HeartSaVioR tibkiss

repo: apache/storm


text:
STORM-1196: Upgrade to thrift 0.9.3

Travis failure appears unrelated.

+1 looks good to me.

+1. This would simplify a lot of pull requests

+1, great for removing date. It also removes unneeded ';' from python generated codes which looks better.

authors: HeartSaVioR kishorvpatil knusbaum revans2


text:
THRIFT-3108 Defaulted struct parameters on a service generates invalid Haskell

Closing for now to figure out the test failures. Sorry for the spam.

repo: apache/thrift


text:
C language support in tests

@swift-ci please test

@ddunbar updated

@swift-ci please test

LGTM... We still need Xcodeproj support is that right?

The files do come up in generated xcode proj but filetype is wrong (sourcecode.c.c) so it doesn't build. I remember filing a bug for that, will try to look into it.

repo: apple/swift-package-manager


text:
Add distance function

@harshvirani Since, the repo is supposed to make snippet within 30 seconds, please make the snippet shorter as possible.

Okay i will make new pull request.

authors: harshvirani sohelamin


text:
Run tests outside of xunit synccontext

@BrennanConroy seems like this made things worse. I'm seeing lots of failures locally.

Works on my machine

🎉

authors: BrennanConroy anurse davidfowl

repo: aspnet/SignalR


text:
New express-tools

MD5: 2319ac34f4848755a639fd524038dfd3
NSP - Security Report
This is an automated security audit of this project. Please do not modify its contents
Vulnerabilities found: 21
Affected Modules: hoek, hoek, hoek, hoek, hoek, superagent, superagent, superagent, superagent, superagent, mime, mime, mime, mime, mime, superagent, superagent, superagent, superagent, uglify-js, uglify-js
Summary:

Prototype pollution attack
Prototype pollution attack
Prototype pollution attack
Prototype pollution attack
Prototype pollution attack
Large gzip Denial of Service
Large gzip Denial of Service
Large gzip Denial of Service
Large gzip Denial of Service
Large gzip Denial of Service
Regular Expression Denial of Service
Regular Expression Denial of Service
Regular Expression Denial of Service
Regular Expression Denial of Service
Regular Expression Denial of Service
Large gzip Denial of Service
Large gzip Denial of Service
Large gzip Denial of Service
Large gzip Denial of Service
Regular Expression Denial of Service
Incorrect Handling of Non-Boolean Comparisons During Minification

Detailed report
Prototype pollution attack
Affected Module: hoek
Installed version: 2.16.3
Patched versions: > 4.2.0 < 5.0.0 || >= 5.0.3
Advisory: https://nodesecurity.io/advisories/566
Path: auth0-logs-to-application-insights@2.0.5 > auth0-extension-express-tools@1.1.6 > webtask-tools@3.2.1 > boom@2.10.1 > hoek@2.16.3

Prototype pollution attack
Affected Module: hoek
Installed version: 2.16.3
Patched versions: > 4.2.0 < 5.0.0 || >= 5.0.3
Advisory: https://nodesecurity.io/advisories/566
Path: auth0-logs-to-application-insights@2.0.5 > auth0-extension-tools@1.3.1 > jsonwebtoken@7.4.3 > joi@6.10.1 > hoek@2.16.3

Prototype pollution attack
Affected Module: hoek
Installed version: 2.16.3
Patched versions: > 4.2.0 < 5.0.0 || >= 5.0.3
Advisory: https://nodesecurity.io/advisories/566
Path: auth0-logs-to-application-insights@2.0.5 > auth0-log-extension-tools@1.3.1 > auth0-extension-tools@1.3.1 > jsonwebtoken@7.4.3 > joi@6.10.1 > hoek@2.16.3

Prototype pollution attack
Affected Module: hoek
Installed version: 2.16.3
Patched versions: > 4.2.0 < 5.0.0 || >= 5.0.3
Advisory: https://nodesecurity.io/advisories/566
Path: auth0-logs-to-application-insights@2.0.5 > jsonwebtoken@7.4.3 > joi@6.10.1 > hoek@2.16.3

Prototype pollution attack
Affected Module: hoek
Installed version: 2.16.3
Patched versions: > 4.2.0 < 5.0.0 || >= 5.0.3
Advisory: https://nodesecurity.io/advisories/566
Path: auth0-logs-to-application-insights@2.0.5 > webtask-tools@3.2.1 > boom@2.10.1 > hoek@2.16.3

Large gzip Denial of Service
Affected Module: superagent
Installed version: 1.8.5
Patched versions: >=3.7.0
Advisory: https://nodesecurity.io/advisories/479
Path: auth0-logs-to-application-insights@2.0.5 > auth0-extension-express-tools@1.1.6 > webtask-tools@3.2.1 > superagent@1.8.5

Large gzip Denial of Service
Affected Module: superagent
Installed version: 1.8.5
Patched versions: >=3.7.0
Advisory: https://nodesecurity.io/advisories/479
Path: auth0-logs-to-application-insights@2.0.5 > auth0-extension-tools@1.3.1 > webtask-tools@2.2.0 > superagent@1.8.5

Large gzip Denial of Service
Affected Module: superagent
Installed version: 1.8.5
Patched versions: >=3.7.0
Advisory: https://nodesecurity.io/advisories/479
Path: auth0-logs-to-application-insights@2.0.5 > auth0-log-extension-tools@1.3.1 > auth0-extension-tools@1.3.1 > webtask-tools@2.2.0 > superagent@1.8.5

Large gzip Denial of Service
Affected Module: superagent
Installed version: 1.8.5
Patched versions: >=3.7.0
Advisory: https://nodesecurity.io/advisories/479
Path: auth0-logs-to-application-insights@2.0.5 > auth0-oauth2-express@1.3.0 > superagent@1.8.5

Large gzip Denial of Service
Affected Module: superagent
Installed version: 1.8.5
Patched versions: >=3.7.0
Advisory: https://nodesecurity.io/advisories/479
Path: auth0-logs-to-application-insights@2.0.5 > webtask-tools@3.2.1 > superagent@1.8.5

Regular Expression Denial of Service
Affected Module: mime
Installed version: 1.3.4
Patched versions: >= 1.4.1 < 2.0.0 || >= 2.0.3
Advisory: https://nodesecurity.io/advisories/535
Path: auth0-logs-to-application-insights@2.0.5 > auth0-extension-express-tools@1.1.6 > webtask-tools@3.2.1 > superagent@1.8.5 > mime@1.3.4

Regular Expression Denial of Service
Affected Module: mime
Installed version: 1.3.4
Patched versions: >= 1.4.1 < 2.0.0 || >= 2.0.3
Advisory: https://nodesecurity.io/advisories/535
Path: auth0-logs-to-application-insights@2.0.5 > auth0-extension-tools@1.3.1 > webtask-tools@2.2.0 > superagent@1.8.5 > mime@1.3.4

Regular Expression Denial of Service
Affected Module: mime
Installed version: 1.3.4
Patched versions: >= 1.4.1 < 2.0.0 || >= 2.0.3
Advisory: https://nodesecurity.io/advisories/535
Path: auth0-logs-to-application-insights@2.0.5 > auth0-log-extension-tools@1.3.1 > superagent@1.2.0 > mime@1.3.4

Regular Expression Denial of Service
Affected Module: mime
Installed version: 1.3.4
Patched versions: >= 1.4.1 < 2.0.0 || >= 2.0.3
Advisory: https://nodesecurity.io/advisories/535
Path: auth0-logs-to-application-insights@2.0.5 > auth0-oauth2-express@1.3.0 > superagent@1.8.5 > mime@1.3.4

Regular Expression Denial of Service
Affected Module: mime
Installed version: 1.3.4
Patched versions: >= 1.4.1 < 2.0.0 || >= 2.0.3
Advisory: https://nodesecurity.io/advisories/535
Path: auth0-logs-to-application-insights@2.0.5 > webtask-tools@3.2.1 > superagent@1.8.5 > mime@1.3.4

Large gzip Denial of Service
Affected Module: superagent
Installed version: 2.3.0
Patched versions: >=3.7.0
Advisory: https://nodesecurity.io/advisories/479
Path: auth0-logs-to-application-insights@2.0.5 > auth0-extension-express-tools@1.1.6 > auth0-extension-tools@1.3.1 > superagent@2.3.0

Large gzip Denial of Service
Affected Module: superagent
Installed version: 2.3.0
Patched versions: >=3.7.0
Advisory: https://nodesecurity.io/advisories/479
Path: auth0-logs-to-application-insights@2.0.5 > auth0-extension-tools@1.3.1 > superagent@2.3.0

Large gzip Denial of Service
Affected Module: superagent
Installed version: 2.3.0
Patched versions: >=3.7.0
Advisory: https://nodesecurity.io/advisories/479
Path: auth0-logs-to-application-insights@2.0.5 > auth0-log-extension-tools@1.3.1 > auth0-extension-tools@1.3.1 > superagent@2.3.0

Large gzip Denial of Service
Affected Module: superagent
Installed version: 1.2.0
Patched versions: >=3.7.0
Advisory: https://nodesecurity.io/advisories/479
Path: auth0-logs-to-application-insights@2.0.5 > auth0-log-extension-tools@1.3.1 > superagent@1.2.0

Regular Expression Denial of Service
Affected Module: uglify-js
Installed version: 2.2.5
Patched versions: >=2.6.0
Advisory: https://nodesecurity.io/advisories/48
Path: auth0-logs-to-application-insights@2.0.5 > auth0-oauth2-express@1.3.0 > jade@1.11.0 > transformers@2.1.0 > uglify-js@2.2.5

Incorrect Handling of Non-Boolean Comparisons During Minification
Affected Module: uglify-js
Installed version: 2.2.5
Patched versions: >= 2.4.24
Advisory: https://nodesecurity.io/advisories/39
Path: auth0-logs-to-application-insights@2.0.5 > auth0-oauth2-express@1.3.0 > jade@1.11.0 > transformers@2.1.0 > uglify-js@2.2.5

license: MIT


text:
ISS-312 - STRICT compare payload

solves #312

authors: authorjapps nirmalchandra

repo: authorjapps/zerocode


text:
Feature/convolution workspace

@homu r+

:pushpin: Commit dad281f has been approved by hobofan

:hourglass: Testing commit dad281f with merge 47a6a00...

:sunny: Test successful - status

authors: hobofan homu

repo: autumnai/collenchyma-nn


text:
Minor edits

This was merged with dd000a6.

authors: Kha avigad


text:
Replace "let me google that for you" link with source

Well, alright...
Thanks @mhluska

authors: avishayil mhluska

repo: avishayil/caponeme


text:
Move #example? to Language::NodePattern

@bquorning quick change to review. Can come before or after #294

:+1:

authors: backus bquorning

repo: backus/rubocop-rspec

license: mit


text:
add reverse in tableutil.lua

这次没加刘桐伟review咩?~

这个pr用了master分支了，不能提交修改，我再重新建个分支

repo: baishancloud/lua-acid


text:
Update to warrior-21.0.3

@resin-jenkins test this please

repo: balena-os/balena-allwinner


text:
Talent selection not available when skipping event parsing

You can close this

source: gharchive/issue


text:
Adds self-verify functionality

This depends on this feature: https://github.com/hyperledger/aries-cloudagent-python/pull/181
Once that is merge, we will need to cut a new release of aca-py and update this repo to build from the new release

This depends on this feature: hyperledger/aries-cloudagent-python#181
Once that is merge, we will need to cut a new release of aca-py and update this repo to build from the new release

@andrewwhitehead please let me know when aca-py 0.3.3 is out, and I will release a new version of aries-cloudagent-container so that we can re-build and test these changes.

@esune, Please confirm whether or not your requests have been addressed.

Caught me while I was on lunch! The latest commit updates the image.

I've tested this locally and everything works.
We are still "faking" the verified response because of the bug in libindy. Once this change has been merged and released, we can update to remove the workaround:
https://github.com/hyperledger/indy-sdk/pull/1893

Looks good to me. I see we also already have an issue logged to track this ( #349 ). 👍

@WadeBarnes this is ready to go once your request for changes is dismissed.

authors: WadeBarnes esune nrempel

repo: bcgov/indy-catalyst


text:
Improve methods of disabling rule from comment (# robocop=disable:rulename,rulename2)

I would also allow to disable all rules for a specific line with a comment # robocop=disable and exclude it for all rules and checkers

There is typo in title, what I meant is :
robocop:disable=rulename, rulename
Or to match all
robocop:disable
It will work only for current line.

Together with this feature I also added feature for disabling checkers for whole blocks or files.
robocop: disable:rule1,rule2
some lines of code..
robocop: enable:rule2
some lines of code..
Will disable rule2 checks until enable command. rule1 will stay disabled until end of file
If # robocop: disable is provided in first line, whole file will be ignored (not parsed at all).

authors: bhirsz mnojek

repo: bhirsz/robotframework-robocop


text:
Dev

Current coverage is 100% (diff: 100%)

Merging #14 into master will not change coverage

@@           master   #14   diff @@
===================================
  Files           2     2
  Lines          32    30     -2
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
- Hits           32    30     -2
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 18f035a...c5fe8b4

authors: codecov-io sbellem

repo: bigchaindb/bigchaindb-driver


text:
Cannot add customer when Editing Order

Duplicate of #113

authors: harsimranmaan shreyansjain

repo: bigpanther/shipanther


text:
Updated Readme For Both

@bislara  I have updated the readme but I noticed that by mistake I have added Image Cartoonizer file in Invisible Cloak..if possible please remove it from there I have added another copy of it directy in Python directory..

Okay fine. Better u can make a commit deleting those files from the Invisible Cloak folder

Okay i have removed it and made the commit please check once

authors: TestPrab bislara

repo: bislara/code-n-stitch


text:
Upgrade dependencies

Coverage remained the same at 93.128% when pulling 48acf574645c6562b57a7c80b4fdca22476cb568 on braydonf:deps into c9b8d8c364cf6aad4184c2f4a09f651f7e46447d on bitpay:master.

Coverage remained the same at 93.128% when pulling e36e15ef121870defa27e994d73fb38d06518504 on braydonf:deps into c9b8d8c364cf6aad4184c2f4a09f651f7e46447d on bitpay:master.

Coverage remained the same at 93.128% when pulling 8aa433a2ef146a47725af4ca10f4a80a85d8c21e on braydonf:deps into c9b8d8c364cf6aad4184c2f4a09f651f7e46447d on bitpay:master.

authors: braydonf coveralls

repo: bitpay/bitcore-payment-protocol


text:
F1.3 Compass

Introduce Compass
Teach them how to set up
Talk about functionality
Go through an example of it being used

repo: bitprj/curriculum


text:
Update changelog/package.json for 1.34.0 release

Codecov Report

Merging #526 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #526   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          54     54
  Lines        1737   1737
  Branches      261    261
=====================================
  Hits         1737   1737

Flag
Coverage Δ

#builder
100% <ø> (ø)
:arrow_up:

#runtime
100% <ø> (ø)
:arrow_up:

#srcapp
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b99932b...d9e3e61. Read the comment docs.

authors: Blackbaud-SteveBrush codecov-io

repo: blackbaud/skyux-builder


text:
Add vue-float-menu package

Hi @eladcandroid
Can you resolve the conflicts?

@blacksonic Done!

authors: blacksonic eladcandroid


text:
Release 0.17

Requires resolving https://github.com/bocadilloproject/bocadillo-cli/issues/13 first. :-)

 Bocadillo v0.17

Bocadillo CLI 0.3 is ready for the joint release!
Next step: write the 0.17 release notes in docs/news/.

Next step: write the 0.17 release notes in docs/news/.

Done! Release incoming. :tada:

repo: bocadilloproject/bocadillo


text:
Additional style options for blockquote component

Added invert logo fix, and updated blockquote markdown file. @sghoweri

repo: bolt-design-system/bolt


text:
rsmq-worker: export Client interface and fix option interface

@MugeSo thanks mate!

authors: MugeSo vvakame

repo: borisyankov/DefinitelyTyped


text:
efs only available on us-west-2

:ship:

authors: kyleknap rayluo

repo: boto/botocore


text:
Fragment refactor (Incomplete, Do not merge)

Verified that @varungu has signed the CLA. Thanks for the pull request!

authors: boxcla varungu

repo: box/box-android-share-sdk


text:
Add contribution guidelines

+1


text:
7.4 release

Closed with 6fc0fd755c1a7f92ebe6743fa36be394a1c2cdf6

authors: menski meyerdan


text:
ci: build the app cross OS

Already integrated and verified as part of https://github.com/camunda/camunda-modeler/pull/2242.

repo: camunda/camunda-modeler


text:
fix: project add validation

:tada: This PR is included in version 0.105.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

authors: adlerhurst fforootd

repo: caos/zitadel


text:
Is it mandatory to set --region while running in new version 0.8.24.1 ? This was not the case with previous version

@kumarsiyer - it should not be mandatory.  It still sets a default region if it is not supplied.  Are you getting an error?  If so, please share

@scotwk custodian run --assume xxx -c xxx.yml -s ./out --cache-period 0
2017-05-18 17:53:17,333: c7n.policies:WARNING policy:ami resources:ec2 not available in region:None
Empty policy file(s).  Nothing to do.

@kumarsiyer - looks like it is not finding your default region.  what does this command return for you?
python -c 'import boto3; print(boto3.Session().region_name)'

 python -c 'import boto3; print(boto3.Session().region_name)' None

@kumarsiyer - set a default in your ~/.aws/config.  Here is mine:
$ cat ~/.aws/config
[default]
region = us-east-1

I'm going to close this, but feel free to re-open if you have more questions

yeah, I noticed that. Sorry should have checked the ENV variables :( my bad

@kumarsiyer - no worries - it is not a helpful error message.  I am going to make this more user friendly.  I've submitted PR #1196 for this.

authors: kumarsiyer scotwk

repo: capitalone/cloud-custodian


text:
Upgrade ShiftIt to 1.6.3

This needs a rebase

Superseded in https://github.com/caskroom/homebrew-cask/pull/10890.

authors: fanquake fikovnik vitorgalvao

repo: caskroom/homebrew-cask


text:
add Watch Screenshot Magic

@vitorgalvao sorry, fixed


text:
Use seperate ports per test variation

Thought parts of the travis tests were getting stuck here but the problem is elsewhere

repo: caspervonb/amok


text:
Adds index to browse examples

just need to categorize to navigate faster in the list

Done, also moved the index to the root folder and added a link to the tests.

authors: cedricpinson jtorresfabra

repo: cedricpinson/osgjs


text:
assignment 2

all good

authors: cengique dmitchner

license: Unlicense


text:
Riviera simulator added to Readme

Accepted. Thank you for providing the change.

authors: aprnath danielmlynek

repo: chipsalliance/Cores-SweRV


text:
Fixes #3: Fix github repo link.

Thank you

license: isc


text:
container_service: create config implementation

unneeded issue

repo: cisco/arc


text:
GA Refactor for plugin-phone

treating this as reviewed since many PRs were opened against this branch and reviewed.

repo: ciscospark/spark-js-sdk


text:
add more tests

Thanks for the reviews.

repo: cjihrig/uvwasi


text:
WIP: New protocol implementation

Rebased changes to merge conflicting travis file with master.
Added 4 commits, after the last review.
@jodh-intel @dlespiau @sboeuf  Can you review the last 4 commits, so that this can be merged?

@jodh-intel I have addresses your review comments. Please have a look.

@dlespiau @sboeuf @sameo @sameo Can we have this merged?

LGTM

LGTM

authors: amshinde sameo sboeuf

repo: clearcontainers/shim


text:
RPC ledger & representatives sorting

Merged to another request https://github.com/clemahieu/raiblocks/pull/184

Why I don't see my my work ng raiblocks captcha... I type and type but I
don't know what is my the? Newbie here
On Wednesday, September 6, 2017, SergiySW notifications@github.com wrote:

Closed #170 https://github.com/clemahieu/raiblocks/pull/170.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/clemahieu/raiblocks/pull/170#event-1235665720, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AT-XDHXRl_RBiBdBPNCTkAb8dQQxgovFks5sfbIPgaJpZM4O8rhK
.

--
null

authors: Nearnotes SergiySW

repo: clemahieu/raiblocks


text:
Self-signed certificates not supported by default

Coverage remained the same at 91.295% when pulling 2c526c3859f77dd1c1df8d19c6ff8c0e534448cb on SAP:reject_unauthorized into 87dc920ec237683714668162bbb5a12b495116ba on cloudfoundry-incubator:master.

Coverage remained the same at 91.295% when pulling 2c526c3859f77dd1c1df8d19c6ff8c0e534448cb on SAP:reject_unauthorized into 87dc920ec237683714668162bbb5a12b495116ba on cloudfoundry-incubator:master.

Coverage remained the same at 91.295% when pulling 2c526c3859f77dd1c1df8d19c6ff8c0e534448cb on SAP:reject_unauthorized into 87dc920ec237683714668162bbb5a12b495116ba on cloudfoundry-incubator:master.

authors: coveralls hsiliev

repo: cloudfoundry-incubator/cf-abacus


text:
Clean up EidosMention

👍

Although there is automatic deduplication of top-level, surface Odin Mentions, there is significant duplication of the "underlying" Mentions in triggers and arguments hiding under the surface which  EidosMention is left to contend with.  Those have been sorted out haphazardly in the past, with ties often being broken based on which order the graph of Mentions is traversed, and decisions about multiple contenders being spread out across code execution.  This PR addresses the situation, concentrating all deduplication information into two local variables of EidosMention.asEidosMentions and calculating their values in two separate recursive passes which do not need to be coordinated.  This prevents different (by identity) Mentions from being displayed when only one (by equality) is meant to have deduplicated them.

A bunch of distracting, potentially reusable utility/library classes have been moved out of the way, variables and methods have been reordered and marked protected, Time and Geo are no longer dependent on EidosMention, some tests for equality are avoided when identity will suffice, some names have been updated for clarity, hopefully.  Behavior shouldn't change except in ambiguous situations, examples forthcoming.

Since == for Mentions does not include the foundBy field, and probably rightly so, the usual way to observe problems with deduplication is to spot this value changing in a regression test.  Some examples are below.  It looks like the new algorithm is favoring the Mention with the longer list of rules.  If this isn't the desired behavior, there is a good place to change it.  A report of rule-changing deduplications might be output short of having to compare against previous runs.  Some values look strange and might be diagnostic.  Migration was not yet removed for this run.

Old foundBy
New foundBy

simple-np
simple-np++GeoNormFinder++location-backoff-expand-common++location-backoff

simple-np
simple-np++migration-verbs

simple-np
simple-np++TimeNormFinderSUTime++time-stanford

simple-np
simple-np++number-stanford

simple-np
simple-np++location-expand-conjunction

simple-np++GeoNormFinder
simple-np++migration-verbs++GeoNormFinder

simple-vp++simple-np
simple-vp++migration-verbs++simple-np

simple-np++gazetteer++GeoNormFinder
simple-np++migration-verbs++gazetteer++GeoNormFinder

simple-np
simple-np++location-backoff-expand

simple-np
simple-np++gazetteer

simple-np++gazetteer++GeoNormFinder
simple-np++migration-pass++gazetteer++GeoNormFinder

simple-np
simple-np++migration-displace

simple-np
simple-np++GeoNormFinder

@BeckySharp, now it's ready for a look.  You're too sharp (tm)!

love it! ❤ ❤ ❤

The mentions in the left column of the table above are now chosen over those in the right column.

hmm.... i worry about the choosing left vs right... something smells fishy
to me.
should we consider taking a step back and thinking about why we have so
many duplicate mentions and if there's a better way to handle things?
On Fri, Jun 19, 2020 at 11:59 AM Keith Alcock notifications@github.com
wrote:

External Email
Merged #881 https://github.com/clulab/eidos/pull/881 into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/881#event-3463585893, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJCPCPITCKITZCVJDOONI3RXOYSRANCNFSM4OAKOB3A
.

Sure, but I would call it taking a step forward.  In the past the "choice" was made largely by chance, so I don't mind changing it willfully.  In the table above the left column is (except in maybe one case I discovered later) what Eidos was getting before I made the changes, so this is mostly a reversion to previous behavior.  I'm not clear on how deduplication is performed by Odin.  Does it ever happen that a mention found by Odin is made subordinate to another (as a trigger, argument, etc.) and then is no longer in the list which Odin would consider being a duplicate?  By Odin I might mean inside an Eidos Finder or GlobalAction or something.

Yes -- it's DEF a step forward!
re: how deduplication is performed, we try to pick the most
complete/attachiest mention from a given span, but that bit of code is like
our skeleton in the closet. you have made it more sound over the years FOR
sure with tie breaking and all, but it's really complicated, and not that
awesome, and we seem to still be continually dealing with issues with
"duplicates".
I guess I was wondering if we could do it fundamentally differently,
knowing what we "know now" (i.e., 3 years into the program).
Re: the subordinate question -- likely!  I know you dig in and retrieve the
subordinate ones, but that's after the fact, and I know that, for example,
I had to be careful to dig in and manually propagate attachments to args
etc., which felt gross... :)
On Fri, Jun 19, 2020 at 1:22 PM Keith Alcock notifications@github.com
wrote:

External Email
Sure, but I would call it taking a step forward. In the past the "choice"
was made largely by chance, so I don't mind changing it willfully. In the
table above the left column is (except in maybe one case I discovered
later) what Eidos was getting before I made the changes, so this is mostly
a reversion to previous behavior. I'm not clear on how deduplication is
performed by Odin. Does it ever happen that a mention found by Odin is made
subordinate to another (as a trigger, argument, etc.) and then is no longer
in the list which Odin would consider being a duplicate? By Odin I might
mean inside an Eidos Finder or GlobalAction or something.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/881#issuecomment-646847012, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJCPCKOA2ZZK3U2PNVA2RDRXPCIFANCNFSM4OAKOB3A
.

authors: BeckySharp kwalcock

repo: clulab/eidos


text:
更新ボタンなどを追加

操作ミスです
ごめんなさい


text:
@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/aeppl-feedstock#3.

authors: brandonwillard conda-forge-linter

repo: conda-forge/aeppl-feedstock


text:
Update to 1.6.0

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

authors: conda-forge-linter ocefpaf


text:
Beta library!

:+1:

authors: AaronLaBrie rltvty

repo: contextio/ContextIO-node


text:
fixed readme instructions

@balajisiva - thanks; LGTM

authors: balajisiva jainvipin

repo: contiv/netplugin


text:
fix(config): wrap config with a function to load the .env vars correctly

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

repo: copa-ch/copa-backend


text:
Print "global" in fleetctl list-unit-files

Related to #1072

Change LGTM, but I can't remember what we decided re: backwards compatibility? Just have a note in the release notes?

The field is currently "-" for global/unscheduled units, while it's a machine ID & IP address for scheduled units. The argument here is that the field is utterly useless and misleading in the case of a global unit, so I believe it is safe to look at this as fixing a bug rather than simply a backwards-incompatible change. We'll definitely release-note this.

authors: bcwaldon jonboulle

repo: coreos/fleet


text:
Update version.go

@tclavier LGTM, thank you!

authors: bcwaldon tclavier


text:
Enhance babel env config to transpile for IE9+

Coverage remained the same at 95.283% when pulling e4431a3736a8c5c24f6e49dd43290ebf3eea5523 on env-config-update into 26387b86c15d4677975a5a351febbc9e46a03d79 on master.

I don't see any issue with this. I haven't bug very deep into env so all appears right from the surface.

authors: coryhouse coveralls kwelch

repo: coryhouse/react-slingshot


text:
swappiness

Done.


text:
Feature Chart Unit Tests

Codecov Report

Merging #1117 into master will increase coverage by 1.46%.
The diff coverage is 98.24%.

@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
+ Coverage   98.27%   99.74%   +1.46%
==========================================
  Files         349      349
  Lines        8511     8523      +12
  Branches     2037     2023      -14
==========================================
+ Hits         8364     8501     +137
+ Misses        147       22     -125

Impacted Files
Coverage Δ

src/components/chart/YGrid.tsx
100% <100%> (+70%)
:arrow_up:

src/components/chart/InfoLine.tsx
100% <100%> (+72.72%)
:arrow_up:

src/components/chart/LineSeries.tsx
100% <100%> (+60%)
:arrow_up:

src/components/chart/ChartContainer.tsx
100% <100%> (+77.27%)
:arrow_up:

src/components/chart/BarSeries.tsx
100% <100%> (+66.66%)
:arrow_up:

src/components/chart/XYChart.tsx
100% <100%> (+69.23%)
:arrow_up:

src/components/chart/XGrid.tsx
100% <100%> (+70%)
:arrow_up:

src/components/chart/XYAxis.tsx
100% <100%> (+83.33%)
:arrow_up:

src/components/chart/ChartTooltipContent.tsx
100% <100%> (+61.11%)
:arrow_up:

src/components/chart/ScatterSeries.tsx
100% <100%> (+57.14%)
:arrow_up:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1da4be2...6b2480f. Read the comment docs.

authors: GermainBergeron codecov-io

repo: coveo/react-vapor


text:
clean and install before bumping a version

Codecov Report

Merging #592 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #592   +/-   ##
=======================================
  Coverage   99.72%   99.72%
=======================================
  Files         259      259
  Lines        6502     6502
  Branches     1517     1517
=======================================
  Hits         6484     6484
  Misses         18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fec652...dd29eab. Read the comment docs.


text:
JBPM-6892 - Remove spacing between table results and controls (#988)

@bsremac cherry pick from master.

repo: cristianonicolai/jbpm-wb


text:
Feature solr nested documents

Coverage increased (+0.2%) to 38.016% when pulling ab0250a5c30d46e778ff0515cd82dfd88e9c6d38 on kilip:feature-solr-nested-documents into 0c10500fcd5631abe7af957f2e69eb4faebccd4b on cross-solution:develop.

authors: cbleek coveralls

repo: cross-solution/YAWIK


text:
Serializable, remove version conditions

seems travis still use 0.24.2

What about also removing the TODO in line 106 in https://github.com/crystal-lang/crystal/blob/master/spec/std/object_spec.cr by using :property1?

repo: crystal-lang/crystal


text:
pull from remote

pull from remote

repo: crystalxs/prospector


text:
prepare test suite agains selenium (travis-ci)

done - together as with capybara-webkit :-)


text:
Fix the yaml so we can deploy

Fixed


text:
Add integer-based std_exp

@rachitnigam Should this be moved to unsigned? Eventually I'll need to implement another for fixed point.

This should probably be re-named to std_pow to follow classic naming convention.

LGTM, merge whenever you're ready.

I also failed to mention that that the actual component was essentially pulled from @rachitnigam's Invoke PR, #300.

authors: cgyurgyik rachitnigam

repo: cucapra/calyx


text:
Remove duplication

Looks good. :shipit:

Thank you James :-)

authors: joebandenburg mrpotes

repo: cuppa-framework/cuppa


text:
Add wrapper for SDL_mixer

Excellent work, thanks a lot!
Just a note about "destructor flags" to clear up the misconception.
In the past I thought a destructor might be called multiple times, so this would be needed:
~this()
{
    if(_chunk !is null)
    {
        debug ensureNotInGC("SDLSample");
        Mix_FreeChunk(_chunk);
        _chunk = null;
    }
}

Actually class destructors are never called twice and such a test is useless. The code can safely become:
~this()
{
    debug ensureNotInGC("SDLSample");
    Mix_FreeChunk(_chunk);
}

The destructor is still called if an exception is thrown in the constructor. So, in this case it might be useful to prevent calling Mix_FreeChunk with a null pointer, I'm not sure if it handles it correctly.

Damn you're right. https://dpaste.dzfl.pl/11ba07e0e6e5
A lot of GFM objects aren't exception-safe then.

repo: d-gamedev-team/gfm

license: unlicense


text:
Merge into d3-color, d3-interpolate.

Would you still be interested in a PR for this? Can probably whip one up.

closing due to inactivity—extensions to d3-color are (soon to be) documented in https://github.com/d3/d3-color#extensions

authors: Fil austinpray mbostock


text:
Fixed wrong member function call

Nice!

authors: daavoo mawall

repo: daavoo/pyntcloud


text:
Improve README of the project

Talk about Redis dependency.

repo: damienlethiec/modern-rails-template


text:
Update apache.txt

The location is now Discovery/Web-Content/apache.txt

repo: danielmiessler/SecLists


text:
[API] how to collect report?

or just provide report and report->text and print-text these APIs? Users can do anything else to fit specific requirement.

repo: dannypsnl/reporter


text:
Fix CI test failures

@GenevieveBuckley FYI there were wide spread test failures here similar to what we were seeing in https://github.com/dask/dask/pull/7740. To try and narrow things down, I compared the packages which were installed between the last CI build in that PR (which was failing) and the most recent commit on main (which was passing at the time it ran). For the macOS / Python 3.9 build these were the package builds which differed:
66c66
<   - fasteners=0.16.1=pyhd3eb1b0_0
---
>   - fasteners=0.16=pyhd8ed1ab_0
79c79
<   - fsspec=2021.6.0=pyhd8ed1ab_0
---
>   - fsspec=2021.5.0=pyhd8ed1ab_0
164a165
>   - monotonic=1.5=py_0
215c216
<   - python-jose=3.3.0=pyhd8ed1ab_0
---
>   - python-jose=3.2.0=pyhd8ed1ab_0
226c227
<   - s3fs=0.6.0=pyhd8ed1ab_0
---
>   - s3fs=2021.5.0=pyhd8ed1ab_0

Initially none of these packages seemed particularly related to the error message we were seeing in https://github.com/dask/dask/pull/7740.
Though after trying to reproduce the test failures locally, which I was able to do, I was surprised to see that the contents of my entire local dask fork had been deleted. Because of this, I now suspect the latest fsspec=2021.6.0 release may be the source of the problem. I've pinned fsspec to 2021.5.0 in CI to test this hypothesis.

Alright, test builds are starting to pass. It looks like the fsspec=2021.6.0 release was the underlying issue (cc @martindurant). Briefly looking through the changelog for that release, https://github.com/intake/filesystem_spec/pull/647 sticks out as potentially related because Windows CI builds still pass with fsspec=2021.6.0 (though this is just a hunch)

Good sleuthing!
I wasn't able to reproduce the failures locally, but I also didn't re-create a new dask environment (I just used my existing environment). So that makes sense to me.

Merging to unblock CI for the time being. We can remove this pinning after things have been resolved upstream in fsspec

authors: GenevieveBuckley jrbourbeau

repo: dask/dask


text:
Move lat/lng and credit to url query string

Resolved in recent commits

repo: datadesk/web-map-maker


text:
Typo dans numérique.yaml

Merci :)

authors: johangirod laem

repo: datagir/nosgestesclimat


text:
Ridership privacy

now that you mentioned it, yea async properties make sense here.
I prefer watchers for properties that are likely to change, because i prefer the manual debounce control. not in this case though, so wait for my fix

repo: datagovsg/beeline-admin


text:
Pass exceptions out close #377

Coverage decreased (-0.7%) to 78.27% when pulling cb04f8a097583f894d97ce2c70445af95a4e1ae9 on queue-timeout into 87a4cf37cc21d3834e94e8fa3417dec793bb66e5 on master.

authors: coveralls fgregg

repo: datamade/dedupe


text:
352 - Feature: Added a function to clear/resize statement parameters

👍

authors: mikefero mpenick

repo: datastax/cpp-driver


text:
Add generator and arbitrary for Ior

Hey, how come this got closed?

repo: davenverse/cats-scalacheck


text:
Fix guides link from homepage

closed since this is built version..

repo: davewasmer/denali


text:
Add option to build debug python library

Until this is done, WIN32 AND Debug should probably error out.

So…has anyone gotten a successful build of any kind on Windows from this build? It builds, but the install tree is unworkable. I'm getting the feeling that I'm doing things undone before here…
@jcfr @vibraphone

Few comments:

CMake'ified python is build on daily basis on windows (it is used within Slicer).

The debug build is not (yet) supported because on windows VTK, Paraview, etc ... always built against a release build python independently of the build config (Release, Debug, ...)

Within Slicer we currently explicitly specify the path to include dir, exectuable and library .. that way the existing call to find_package(PythonLibraries ..) works as expected.

When you mention the install tree is unworkable, what do you mean exactly ? We made effort to match the layout obtained on windows after doing an install using the official python build system.

Alright, so there is some hope :) . What do you do about libraries needed by compiled modules which live beside python.exe? In my case, zlib is linked by binascii.pyd but installed beside the executable and therefore fails. It appears that python.org's installer doesn't even have a python27.dll, so that's another difference. Anyways, I need binascii for building numpy, so it isn't something I can just turn off.

It seems this issue is not specific to cmake'ified python.
To workaround this sort of problem and ensure the configure and build work as expected, within Slicer, there is are few  concepts:

instead of setting PYTHON_EXECUTABLE to the original python.exe, we pass a launcher named customPython. See [1]. The launcher will look for a settings file [2] that we also configure [3]

since zlib is build statically, there are no issue on that side. On the other hand, OpenSSL is built as shared. And in that case, the setting are configured accordingly. See [4]

Moving forward, the setting will be configured more automatically. Similarly to how it is done for the launcher settings associated with the Slicer executable. See r23724

Finally, note that the launcher we used is statically linked against Qt and is pre-built for all platform we support. See [5] and [6]

[1] https://github.com/Slicer/Slicer/blob/7f471a37d7b168c419d2b923b821fd1dd7180199/SuperBuild/External_python.cmake#L149-L165
[2] https://github.com/Slicer/Slicer/blob/master/SuperBuild/python_customPythonLauncherSettings.ini.in
[3] https://github.com/Slicer/Slicer/blob/121d28f3d03c418e13826a83df1ea1ffc586f0b7/SuperBuild/python_customPython_configure.cmake.in
[4] https://github.com/Slicer/Slicer/blob/121d28f3d03c418e13826a83df1ea1ffc586f0b7/SuperBuild/python_customPython_configure.cmake.in#L78
[5] http://commontk.org/index.php/Tools:_Application_launcher
[6] http://packages.kitware.com/packages/application/view?applicationId=10

Note also that we build Numpy 1.4.1 every night.
There is also an experimental branch building the latest OpenBlas, NumPy and SciPy using a statically built mingw compiler. See https://github.com/jcfr/Slicer/tree/upgrade-to-numpy-1.9.0-and-scipy-0.14.0
Looking at the module ExternalProjectForNonCMakeProject may also be interesting.
An example of use is available here: https://github.com/Slicer/Slicer/blob/7f471a37d7b168c419d2b923b821fd1dd7180199/SuperBuild/External_NUMPY.cmake#L22-L113

I'll have to look into the launcher thing; that's probably the way to go. A batch file should do the trick for us; I don't think we need a complete configuration system for it since we only really need it for the build steps of numpy (and I don't think the other tools we build use any of the compiled modules during their builds) and after that pvpython is the expected way to do things which should work already. Not the prettiest setup, but it's really just to get binaries…
Unfortunately, static Qt and rest-of-stack is pretty much a no-go (I have enough headaches just getting Qt to compile normally without trying to stuff QtWebKit into a static library on a machine with less than 16G of memory…and Qt5 is around the corner…) since compiling static binaries of just ParaView already starts to push the memory limits when in a parallel build on my main machine, so we will need to support using shared libraries as dependencies of compiled modules.
As for numpy, 1.4.1 is likely way too old to apply here. We're using 1.6.2 and I'd really like to bump to 1.8.x (and upstream is at 1.9.2 already…). We're currently using a hacked up build which allows us to do a static build for ParaView to use on supercomputers (though numpy's build "system" is used for normal builds), but that isn't applicable to Windows anyways.

authors: jcfr mathstuf

repo: davidsansome/python-cmake-buildsystem


text:
mutex mutex mutex

草草草
你这是在说啥啊

mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex

你这说的是啥啊...

mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex
mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex mutex

今天刚好学到互斥锁……网页也需要这个嘛，代码果然是共通的

看情况吧，如果有需求的话
Simon
simon30002021@icloud.com

2020年6月15日 下午3:28，Neteraxe notifications@github.com 写道：
今天刚好学到互斥锁……网页也需要这个嘛，代码果然是共通的
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/dd-center/vtbs.moe/issues/129#issuecomment-644134973, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADAR5CHT2LCCH7RHQIYXPFTRWYOXHANCNFSM4KBXFGZA.

估计是代码优化的一部分了
在Android里，优化是很了不起的一件事，像QQ运行时占1G内存，都已经是优化后的结果了，毕竟Android是基于Linux系统改进的

咦，不是为了防止多个来源同时访问同一个数据造成问题吗
Simon
simon30002021@icloud.com

2020年6月15日 下午4:43，Neteraxe notifications@github.com 写道：
估计是代码优化的一部分了
在Android里，优化是很了不起的一件事，像QQ运行时占1G内存，都已经是优化后的结果了，毕竟Android是基于Linux系统改进的
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/dd-center/vtbs.moe/issues/129#issuecomment-644177944, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADAR5CD2FVLNBVIV3EGVKWLRWYXPNANCNFSM4KBXFGZA.

在Java中可以用synchronized，这个会自动解锁上锁，只是操作上有性能问题，不过作者看起来像是苹果党

哦耶 完全忘自己在说什么，所以close 🎉


text:
Refactoring in frontend_tests/node_tests/reactions.js

Coverage before:

Statements   : 53.77% ( 913/1698 )
Branches     : 23.13% ( 111/480 )
Functions    : 40.81% ( 162/397 )
Lines        : 53.76% ( 909/1691 )

After:

Statements   : 53.82% ( 915/1700 )
Branches     : 23.13% ( 111/480 )
Functions    : 39.43% ( 153/388 )
Lines        : 53.7% ( 907/1689 )


text:
Support Transport Layer Security for TCP connections

This is quite high priority, be good to get done for a 1.1 client ( and server ) release.

Won't fix in favour of using wss for secure connections

Closing as part of 2.0

authors: WolframHempel yasserf


text:
Use SLF4J

Obviated by Vettraino moving to log4j2 (issues 100?)


text:
Tweaks for DCT commands in readme

:broken_heart: Test Failed - Build images and run cluster test

:broken_heart: Test Failed - Build images and run cluster test

/land

/land

authors: bors-libra coryhill davidiw

repo: diem/diem


text:
Update _header.scss

@Radhika-Modi what's the purpose of this PR?


text:
Update app.py

:eyes: youre definitely doing it wrong

Not sure how to respond to this

Just clap

insert slow clap

Shouldn't this have been covered by https://blog.github.com/2018-04-18-new-tools-for-open-source-maintainers/#accidental-and-drive-through-pull-request-prevention :thinking:

👏

authors: CauaTheKing GigaFyde Plutoberth Repulser YaBoyWonder napstr


text:
Bf/text/add 3dr footnotes

Superseded by #35

repo: dispatchrabbi/half-day-security-guide


text:
Removed doubled line from templatetags reference

:+1:

authors: czpython evildmp

repo: divio/django-cms


text:
Fixed #24479 -- Added system check to prevent both ordering and order_wrt

Also, due to my comment (https://github.com/django/django/pull/4343#discussion_r26579162), it will be good to have a test which will run model check with only ordering and only order_with_respect_too, so we will see if there are such problems.

Thanks for the review.

This will not work. cls._meta.ordering is defined in django.db.models.options.Options#_prepare if order_with_respect_to used, so it will fail if I will use only order_with_respect_to.

I see what you mean. I added the suggested tests and, indeed, some are failing expectations.
It would seem to me that using the system checks framework is too late to analyze this as the _meta object has already be prepared. Would it make sense to detect this in django.db.models.options.Options#_prepare and raise an ImproperlyConfigured error if ordering is already defined?

Well, ImproperlyConfigured is kinda overhead for this issue. It will be great to have exactly system check for it. Need to find some way to do it, otherwise if there will be no ability to do this, we will need to simply document this issue.
(This is my IMO, need to have core devs opinion)

Couldn't we set an attribute like _ordering_overridden in Options.contribute_to_class() if the user specified a Meta.ordering to distinguish it from the ordering that over_with_respect_to sets?

Thanks @timgraham.
I looked into your idea and made a solution that will allow the system check. Let me know if this is what you had in mind or is a reasonable solutions. With this change all tests are passing including the the situation pointed out by @coldmind. Cheers.

Thanks for the review. I believe I have addressed your recent concerns. More feedback welcome.

merged in 966a29c2b83fed2fc7c2b5b09de80cbebc94ac74, thanks!

authors: coldmind jdufresne timgraham

repo: django/django


text:
Use Kernel#singleton_class

With rails cache_classes:
input> Benchmark.bm do |b|
     |   client = Client.new
     |   b.report('classic #spec') {  1_000.times { client.spec } }
     |   b.report('fast #spec')    {  1_000.times { client.fast_spec } }
     | end
       user     system      total        real
classic #spec  2.110000   0.010000   2.120000 (  2.130218)
fast #spec  0.000000   0.000000   0.000000 (  0.000412)

Without rails cache_classes:
input> Benchmark.bm do |b|
     |   client = Client.new
     |   b.report('classic #spec') {  1_000.times { client.spec } }
     |   b.report('fast #spec')    {  1_000.times { client.fast_spec } }
     | end
       user     system      total        real
classic #spec 64.910000   0.120000  65.030000 ( 65.637576)
fast #spec  0.000000   0.000000   0.000000 (  0.000361)

repo: dlozano/workflow


text:
Make DictionaryType APIs throw if KeyPath is ill-formed

Current coverage is 83.01% (diff: 44.26%)

Merging #61 into master will decrease coverage by 2.89%

@@             master        #61   diff @@
==========================================
  Files            42         42
  Lines          1362       1501   +139
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1170       1246    +76
- Misses          192        255    +63
  Partials          0          0

Powered by Codecov. Last update 90c5356...3723c6c

authors: codecov-io jsbean

repo: dn-m/Collections


text:
added service metrics, renamed modelfactory to resource

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #13   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           5      6    +1
  Lines         144    170   +26
=====================================
+ Hits          144    170   +26

Impacted Files
Coverage Δ

model.go
100% <100%> (ø)
:white_check_mark:

metrics.go
100% <100%> (ø)

handlers.go
100% <100%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f393e6...4b94db9. Read the comment docs.

authors: codecov-io gereji

repo: dndungu/rest


text:
DNN-8773: add default providers in web.config.

Code review done


text:
Add Packet driver

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "packet-driver-link" git@github.com:betawaffle/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

LGTM

LGTM

Yay!

authors: GordonTheTurtle betawaffle dgageot jeanlaurent pandrew

repo: docker/machine


text:
Add a small hook to check if opam metadata have been updated correctly

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:samoht/vpnkit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Seems to work:
ERROR: b05c13b405504c0930d5101d502cf2b007f919ef manually updates
opam/[darwin|win32]/packages/packages/upstream. Instead, please run:

    make -C opam

opam/check-upstream.sh returned exit code 1

Action failed: opam/check-upstream.sh

See https://github.com/docker/vpnkit/pull/47#issuecomment-224928308 for the rational

/cc @djs55 and @yomimono

authors: GordonTheTurtle samoht

repo: docker/vpnkit


text:
Router.md

此章节由我翻译，翻译时间为 2018.03.01-2018.03.01

此章节由我翻译，翻译时间为2018.03.01-2018.03.02

此章节我已翻译完成。见 PR #13

authors: Neptune189zj QC-L Xqqqqqq


text:
Remove unused can-import

These files have changed and this is no longer needed. Sorry for not getting to this earlier.

repo: donejs/place-my-order


text:
Remove SQL Server books online references

Thanks Tom! Since these are low pri articles, I decided not to spend the extra time to make the nit change.

repo: dotnet/docs


text:
Power source indique 3

Fixed in next release

repo: doudz/jeedom-plugin-zigate


text:
fix npm install command in README

Yep I guest it will clarify a lot of stuff. Thanks
(I will be fixing the expected source map later today to match with the babel release)

authors: deepsweet douglasduteil

repo: douglasduteil/isparta

license: WTFPL


text:
Fix incorrect name in "TopN queries" docs

@abbondanza can you sign http://druid.io/community/cla.html?

@fjy signed.

@abbondanza signed!
On Thu, Jun 8, 2017 at 9:07 PM Fangjin Yang notifications@github.com
wrote:

@abbondanza https://github.com/abbondanza can you sign
http://druid.io/community/cla.html?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/druid-io/druid/pull/4386#issuecomment-307267768, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AE3Ovy972bOwyF_uD5GzvZKlY6I3sIBqks5sCJrtgaJpZM4N0o_l
.

--
Rafael Abbondanza
(914) 513-1066
“You have heard that it was said, ‘You shall love your neighbor and hate
your enemy.’ But I say to you, Love your enemies and pray for those who
persecute you."
-Jesus; Matthew 5:43-44

authors: AmarJayR abbondanza fjy

repo: druid-io/druid


text:
Circleci integration

@zhihzhang I added a circleci file to test the build however it seems to fail at the moment: https://circleci.com/gh/wcandillon/YiDB/2 (but works locally).

@zhihzhang I fixed the build: https://circleci.com/gh/wcandillon/YiDB/5

repo: eBay/YiDB


text:
Swagger support data

http://wwwdev.ebi.ac.uk/uniprot/api/doc/support-data-openapi3.yaml
and
http://wwwdev.ebi.ac.uk/uniprot/api/doc/?urls.primaryName=support-data#/

repo: ebi-uniprot/uniprot-rest-api


text:
Fixed typo in a potentially user-facing error message.

Thanks! Appreciate those fixes. Hard to catch, yet, makes all the difference.

authors: elazarl rdbell

repo: elazarl/goproxy


text:
Centros de Acopio Qro

Gracias por la aportación @javarv87, pero en la version actualizada del sitio puedes agregar formas de ayudar mediante un formulario, puedes realizar tu aportacion dando click al enlace "Contáctanos" o directamente en este link: https://docs.google.com/forms/d/e/1FAIpQLSf_kylBvkVQXaJmBAILdpjKCsl6lERlhtnhFfB1_22g43sz4g/viewform

repo: eldelentes/comoayudarmx


text:
removing duplicate 'to'

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:

authors: Awlexus josevalim

repo: elixir-ecto/ecto


text:
add react storybook

there will be few custom components on this site. Let's forget this for now.


text:
Přidání mého souboru

.

repo: encukou/prezencka


text:
Added dummy file for testing. DO NOT MERGE!

Build triggered. sha1 is merged.

Build started sha1 is merged.

Build finished. No test results found.

repo: endocode/fleet


text:
Feature/vue cli 3 transition

Hello!
Are we going to be able to push this to staging first (when we have one)? We also need to make sure that this is in sync with other big pending PRs.
Thanks!

authors: asvae jean-moldovan

repo: epicmaxco/vuestic-admin


text:
Update eds-static SSL certificate

Done

repo: equinor/design-system


text:
use pangaea to determine dates where possible; allow qinit

Coverage decreased (-0.1%) to 83.999% when pulling bf72b45f8075be87795aa6474c9cb138425c1e60 on snowman2:lsm_one_input into a4764eb81659074efe7399d136538f1df6d30098 on erdc-cm:master.

Coverage decreased (-0.1%) to 83.999% when pulling 6dbec3fea5d848909acc09f230d0ac2abfffda48 on snowman2:lsm_one_input into a4764eb81659074efe7399d136538f1df6d30098 on erdc-cm:master.

Coverage decreased (-0.1%) to 83.999% when pulling 1df65a2104755a11fa55469927d555d7cd555e94 on snowman2:lsm_one_input into a4764eb81659074efe7399d136538f1df6d30098 on erdc-cm:master.

Coverage decreased (-0.1%) to 83.994% when pulling 1df65a2104755a11fa55469927d555d7cd555e94 on snowman2:lsm_one_input into a4764eb81659074efe7399d136538f1df6d30098 on erdc-cm:master.

repo: erdc-cm/RAPIDpy


text:
Upgrade java agent to 3.15.0

I'd recommend using "current" for java agent version, and downloading *.jar. will always grab latest...
ex:
2.2.0 :001 > require 'open-uri'
=> true
2.2.0 :002 > url_content = open('https://download.newrelic.com/newrelic/java-agent/newrelic-agent/current/') {|f| f.read.lines.grep(/jar/i).to_s }
=> "["<a href=\"newrelic-agent-3.15.0.jar\">newrelic-agent-3.15.0.jar                          31-Mar-2015 18:22             7064901\r\n"]"
2.2.0 :003 > name = url_content.split(/\W+jar/).first.to_s.split("\"").last + '.jar'
=> "newrelic-agent-3.15.0.jar"
2.2.0 :004 >

I'd rather keep the recipe as deterministic as possible, even if the consumer doesn't define a particular agent version.

@mausch I don't agree. I'd agree if the cookbook was more opinionated but this cookbook is being used by many in a very generic way and is being wrapped up to define a specific version. In fact, we're forced to wrap it because this cookbook consistently runs behind the current.
If you look at other community cookbooks, like say Java, it does pull the latest, at least for a major. I don't feel it's the task of a cookbook like this to define a version, that's the responsibility of the people using it. It's also less work for the maintainers and probably for you, since you don't have to submit/wait on a PR every time you want a version bump.

Hi guys,
thanks for this thread. We're making some changes to the agent recipes (introduction of LWRPs) and I'm keen on getting a solution that allows you to have ['newrelic']['java_agent']['version'] set to 'latest' (=new default value for attribute), in which case some logic based upon @amonje's suggestion will be used to get the latest/current version and otherwise grab a particular version, which is how it works right now.
This way the cookbook will be able to grab latest by default, but you can still be more deterministic if your setup requires so. FYI: I'll reference the PR/commit once it goes out.
Hope this helps!
Kind regards,
David

authors: amonje djoos ge1st mausch

repo: escapestudios-cookbooks/newrelic


text:
Add link to Web gateway to README

:)

authors: homotopycolimit thomaskuntzz

repo: ethersphere/swarm-home


text:
Rethink the Representation / body distinction

Representations are in much better shape now, I'm going to close this ticket until I have something more concrete.

repo: evert/ketting


text:
Указал этаж для БК

спасибо @andreyors

authors: andreyors ewgRa


text:
adding formatting to options, tokens, and formats for better readability

Can you clarify on your thoughts on how it makes it more readable? It seems weird to add a background color to the headings, especially where the background does not extend the full page width, like a heading normally would. It also seems to deviate from the styling of all the other modules in our orgs, so if this is really desirable, we should make a plan to update them all to be consistent and not let them each drift into weirdly different styles.

Can you clarify on your thoughts on how it makes it more readable?

When browsing the list of tokens, options, or predefined formats, I found it easier to see the individual items and then read the description of the item.  Without the formatting, it was harder to process each individual item and I found myself reading the beginning of each description before moving on to the next item.
I was reading through the multer readme which does this for their options.  I see that other repos in the express org don't format options like this.

Strange, as I feel like it is harder to read them with this change, as they are no longer bold...

Strange, as I feel like it is much easier to skip over the headings with this change, as they are no longer bold...

fair enough! i'll close this pr

authors: dougwilson ryhinchey

repo: expressjs/morgan


text:
Add signature check to BlueJeans

This looks fine to me, but as part of the PR, please paste in the relevant output of autopkg run -vv  to prove that it works.

Please provide the requested test plan.

Processing BlueJeans/BlueJeans.download.recipe...
URLTextSearcher
{'Input': {'re_pattern': u'https://swdl\\.bluejeans\\.com/desktop/mac/[0-9.]*/[0-9.]*/BlueJeans\\.[0-9.]*.pkg',
           'url': u'https://swdl.bluejeans.com/desktop/mac/live.json'}}
URLTextSearcher: No value supplied for CURL_PATH, setting default value of: /usr/bin/curl
URLTextSearcher: No value supplied for result_output_var_name, setting default value of: match
URLTextSearcher: Found matching text (match): https://swdl.bluejeans.com/desktop/mac/1.37/1.37.22/BlueJeans.1.37.22.pkg
{'Output': {'match': 'https://swdl.bluejeans.com/desktop/mac/1.37/1.37.22/BlueJeans.1.37.22.pkg'}}
URLDownloader
{'Input': {'CURL_PATH': '/usr/bin/curl',
           'url': u'https://swdl.bluejeans.com/desktop/mac/1.37/1.37.22/BlueJeans.1.37.22.pkg'}}
URLDownloader: No value supplied for CHECK_FILESIZE_ONLY, setting default value of: False
URLDownloader: Item at URL is unchanged.
URLDownloader: Using existing /Users/example/Library/AutoPkg/Cache/com.facebook.autopkg.download.bluejeans/downloads/BlueJeans.1.37.22.pkg
{'Output': {'pathname': u'/Users/example/Library/AutoPkg/Cache/com.facebook.autopkg.download.bluejeans/downloads/BlueJeans.1.37.22.pkg'}}
EndOfCheckPhase
{'Input': {}}
{'Output': {}}
CodeSignatureVerifier
{'Input': {'expected_authority_names': (
    "Developer ID Installer: Blue Jeans Network, Inc. (HE4P42JBGN)",
    "Developer ID Certification Authority",
    "Apple Root CA"
),
           'input_path': u'/Users/example/Library/AutoPkg/Cache/com.facebook.autopkg.download.bluejeans/downloads/BlueJeans.1.37.22.pkg'}}
CodeSignatureVerifier: Verifying installer package signature...
CodeSignatureVerifier: Package "BlueJeans.1.37.22.pkg":
CodeSignatureVerifier:    Status: signed by a developer certificate issued by Apple for distribution
CodeSignatureVerifier:    Certificate Chain:
CodeSignatureVerifier:     1. Developer ID Installer: Blue Jeans Network, Inc. (HE4P42JBGN)
CodeSignatureVerifier:        SHA256 Fingerprint:
CodeSignatureVerifier:            57 8E A9 2D 8B EE 20 3B 09 45 A8 AD DF 6D 16 CB 55 A7 FF 8F 9B 06
CodeSignatureVerifier:            8C C6 B1 68 12 95 6A 4C 08 C5
CodeSignatureVerifier:        ------------------------------------------------------------------------
CodeSignatureVerifier:     2. Developer ID Certification Authority
CodeSignatureVerifier:        SHA256 Fingerprint:
CodeSignatureVerifier:            7A FC 9D 01 A6 2F 03 A2 DE 96 37 93 6D 4A FE 68 09 0D 2D E1 8D 03
CodeSignatureVerifier:            F2 9C 88 CF B0 B1 BA 63 58 7F
CodeSignatureVerifier:        ------------------------------------------------------------------------
CodeSignatureVerifier:     3. Apple Root CA
CodeSignatureVerifier:        SHA256 Fingerprint:
CodeSignatureVerifier:            B0 B1 73 0E CB C7 FF 45 05 14 2C 49 F1 29 5E 6E DA 6B CA ED 7E 2C
CodeSignatureVerifier:            68 C5 BE 91 B5 A1 10 01 F0 24
CodeSignatureVerifier:
CodeSignatureVerifier: Signature is valid
CodeSignatureVerifier: Authority name chain is valid
{'Output': {}}
Receipt written to /Users/example/Library/AutoPkg/Cache/com.facebook.autopkg.download.bluejeans/receipts/BlueJeans.download-receipt-20191015-134301.plist

Nothing downloaded, packaged or imported.

authors: nmcspadden williamtheaker

repo: facebook/Recipes-for-AutoPkg


text:
Website update

All changes approved.

repo: facebookresearch/sumo-challenge


text:
Gradle action: remove code to delete apks

:cool: :ship: it

authors: asfalcone mfurtak

repo: fastlane/fastlane


text:
Release artifacts for M66.1

Note that we released Firestore 1.11.2 on top of release-6.19. Should release 6.20 include that?

Yep the Firebase.podspec should be updated to include 1.11.2

OK. I created https://github.com/firebase/firebase-ios-sdk/pull/5091 to merge that to master.

Thanks for doing that - I can cherry-pick now!

authors: paulb777 ryanwilson wilhuff

repo: firebase/firebase-ios-sdk


text:
Support languages other than Python

Probably not a big use for this

@twinters007 If another team wanted to use this it would be nice to support. Not a big issue for now though.

True...


text:
Update consolidate to 0.14.1 to add Twig & slm support

Thanks @stowball - will merge now :-)

authors: allmarkedup stowball

repo: frctl/consolidate-adapter


text:
Initial Drivers Setup Separation

Note: the nodejs syntax is probably wrong in the SetupDriver.js

repo: fsoppelsa/kitematic


text:
一帮精神太监让让技术不应该夹杂政治。可当某人用政治肆无忌惮迫害技术的时候你们去了哪儿？

美国利用政治肆无忌惮迫害我国技术公司华为中兴的时候你们去哪里了？

@jvbaocn 哈哈一看到提“迫害”华为中兴的睿智真的笑掉大牙。华为都能叫被“迫害”，那Google/FB/Youtube被墙算啥？双标玩的真溜

@listar2000 谷歌拒绝删除危害我国和平稳定的反动言论，甚至纵容他们传播！华为传播反动言论了吗？？

NSA搞监听是为了防止恐怖分子伤害本国国民，而某国监控主要目的是为了防止民间讨论高层腐败、社会不公甚至争取民主。一个是为了保护国民，一个是为了高层的统治压迫国民。

NSA搞监听是为了防止恐怖分子伤害本国国民

那么美国窃听欧洲各国领导人是为了啥？难道欧洲各国领导人都是潜在恐怖分子吗？？那么美国领导人如果是潜在恐怖分子该咋办？？凭啥美国领导人就该知道世界上所有机密，宁有种乎？？

repo: fuck-xuexiqiangguo/Fuck-XueXiQiangGuo


text:
fix syntax error

Thank you for the fix :+1:

authors: FbN paldepind

repo: funkia/hareactive


text:
Map Activity

Started working on this now @peter-tackage

@maritoast OK, feel free to push anything you have to a work in progress PR to get some early feedback.

authors: maritoast peter-tackage

repo: futurice/freesound-android


text:
Gh 1458 cache generics mismatch

Codecov Report

Merging #1719 into develop will decrease coverage by 0.01%.
The diff coverage is 64.86%.

@@              Coverage Diff              @@
##             develop    #1719      +/-   ##
=============================================
- Coverage       65.9%   65.89%   -0.02%
  Complexity      2010     2010
=============================================
  Files            815      816       +1
  Lines          26509    26534      +25
  Branches        3402     3402
=============================================
+ Hits           17472    17485      +13
- Misses          7668     7680      +12
  Partials        1369     1369

Impacted Files
Coverage Δ
Complexity Δ

...a/uk/gov/gchq/gaffer/federatedstore/PairCache.java
50% <50%> (ø)
0 <0> (?)

...chq/gaffer/federatedstore/FederatedStoreCache.java
78.57% <92.3%> (+0.79%)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3e5de5...b667e9c. Read the comment docs.

Not an optimal solution.

repo: gchq/Gaffer