text:
feature:S3C-4180 OSE Design for User Flows

Hello saitharunthodupunuru,
My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.
Status report is not available.

Waiting for approval
The following approvals are needed before I can proceed with the merge:

the author

2 peers

reduce to 1 hr cache for assume role
margin of expiration time for cache from creds expiry time
ListusersMarker cache

Codecov Report

Merging #23 (6928e4a) into development/1.0 (0428b60) will not change coverage.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             development/1.0      #23   +/-   ##
==================================================
  Coverage              92.02%   92.02%
  Complexity               103      103
==================================================
  Files                     11       11
  Lines                    301      301
  Branches                  22       22
==================================================
  Hits                     277      277
  Misses                     7        7
  Partials                  17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0428b60...6928e4a. Read the comment docs.

the role will be visible and editable by the root account user or an IAM user with the right permisions (iam:list-roles, iam:deleteRoles...).

Done in 4835f2c54b51bdf2b2a626fe6f9aa9238b606277

Role name : osis (So role-arn can be generated in the format arn:aws:iam::[account-id]:role/osis

Please, indicated here that the role will be visible and editable by the root account user or an IAM user with the right permisions (iam:list-roles, iam:deleteRoles...).
From my PoV, the role and the policie used by OSIS should be hidden until we implement AWS organization.
@scality-gdoumergue and @scality-trevorbenson do you agree with that?

Yes, I do.

As discussed with GS, the role name should not be visible.
This was confirmed and agreed upon a couple of weeks back: scality.atlassian.net/browse/S3C-4094?focusedCommentId=276721
Why did we change this?

My recommendation here:
OSE is an external app and needs a role to operate, so it shall create the role with an unambiguous name, and the role must be visible. For info that is the normal behavior of all "external apps" on AWS.
Here are the reasons:

Maintainability: if a special hidden role is used then somebody trying to understand the system may not understand why some special rights are granted to some apps.
Security through obscurity: some apps have special rights hidden in the system. An attacker may exploit this specificity, e.g. if we forget that some hidden roles/policies are still stored.
Development:  it forces up to implement specific, non-rational, duplicate code in Vault, and as a result we produce more code in Vault which means more potential bugs, more maintenance. All this for a functionality which already works as specified by AWS, etc.

However there is the potential issues of somebody accidentally deleting the role preventing the system to work properly: so we address this by detecting this situation and re-creating the role dynamically.

As discussed with GS, the role name should not be visible.
This was confirmed and agreed upon a couple of weeks back: scality.atlassian.net/browse/S3C-4094?focusedCommentId=276721
Why did we change this?

My recommendation here:
OSE is an external app and needs a role to operate, so it shall create the role with an unambiguous name, and the role must be visible. For info that is the normal behavior of all "external apps" on AWS.
Here are the reasons:

Maintainability: if a special hidden role is used then somebody trying to understand the system may not understand why some special rights are granted to some apps.
Security through obscurity: some apps have special rights hidden in the system. An attacker may exploit this specificity, e.g. if we forget that some hidden roles/policies are still stored.
Development:  it forces up to implement specific, non-rational, duplicate code in Vault, and as a result we produce more code in Vault which means more potential bugs, more maintenance. All this for a functionality which already works as specified by AWS, etc.

However there is the potential issues of somebody accidentally deleting the role preventing the system to work properly: so we address this by detecting this situation and re-creating the role dynamically.

Incorporated these changes in the Design document,
Note:
* This role will be visible and can be edited by the root account user (or) the IAM user with the right permissions (iam:list-roles, iam:deleteRoles...). Editing this role is strictly not suggested. If edited, this role must be manually deleted
* If this role is deleted, it will be auto populated (Refer here)
@scality-gdoumergue and @scality-trevorbenson
Please let us know if any concerns / issues with this approach

Jumping in to add :100: support to @vrancurel comment in https://github.com/scality/vmware-ose-scality/pull/23#issuecomment-818940209. Our OSE integration is, from the Scality products PoV, an external application, for which no 'special trickery' inside the products should be added, especially in the 'security' area.

@wabernatScality fixed all the suggestions in e3666aaa48301ad0187513dd6e2afd9c530c4869

Codecov Report

Merging #23 (51b978e) into development/1.0 (c58e364) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 51b978e differs from pull request most recent head 15f53b3. Consider uploading reports for the commit 15f53b3 to get more accurate results

@@                Coverage Diff                 @@
##             development/1.0      #23   +/-   ##
==================================================
  Coverage              92.02%   92.02%
  Complexity               103      103
==================================================
  Files                     11       11
  Lines                    301      301
  Branches                  22       22
==================================================
  Hits                     277      277
  Misses                     7        7
  Partials                  17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c58e364...15f53b3. Read the comment docs.

Update from GS over slack:

Trevor Benson  2 days ago
I recall reading them yesterday, but not seeing it as part of conversation in PR23. I'll find which it was and add my "seconding", with Nicolas, of agreeing with Vianneys comment to keep the role visible.

@vrancurel  @anurag4DSB
I added latest changes of the design in the commit c1cc56602b590be96bfda10223fd7da94132b909
Please re-review
Thanks
Sai

/approve

In the queue
The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.
The changeset will be merged in:

:heavy_check_mark: development/1.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.
IMPORTANT
Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.
The following options are set: approve

I have successfully merged the changeset of this pull request
into targetted development branches:

:heavy_check_mark: development/1.0

Please check the status of the associated issue S3C-4180.
Goodbye saitharunthodupunuru.

authors: NicolasT anurag4DSB bert-e codecov-commenter codecov-io saitharunthodupunuru scality-gdoumergue vrancurel

repo: scality/vmware-ose-scality


text:
Update to latest credo.

Coverage remained the same at 97.756% when pulling 230c16adde255d0e84a44040a6d74abf44c3f933 on update-credo into c9532a22bcb1378f3f4cebfc621652866dbdcabd on master.

source: gharchive/pull-request

authors: coveralls scouten

license: mit

license_type: permissive

license_source: bigquery


text:
sort by view count/date flag

user can do this by parsing JSON output if they want

source: gharchive/issue

repo: seanbreckenridge/twitchlive

license: MIT

license_source: github-api


text:
Add comments for new code

good enough

repo: sekrit-twc/zimg

license: WTFPL


text:
Select2 supports manual input?

It's unclear what "manual input" means in this context.  I will assume it refers to "programmatically creating a new item", which is now documented here: https://select2.org/programmatic-control/add-select-clear-items

authors: McXmart alexweissman


text:
Add information about licensing

Yes. I forgot.
Added.
Thanks.

Thank you for information.

authors: seventhmoon vbauer

repo: seventhmoon/GeoIp-android


text:
new

you should create a pull request to master.

authors: maratgaip nazirauzak

repo: seytechschool/first-contributions


text:
tech-debt and docs updates

Pull Request Test Coverage Report for Build 924793637

81 of 82 (98.78%)  changed or added relevant lines in 13 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 92.303%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/path_util.go
4
5
80.0%

Totals

Change from base Build 922264381:
0.6%

Covered Lines:
1379

Relevant Lines:
1494

💛  - Coveralls


text:
update to sxd_document 0.2

can you do a release with this?

can you please do a release with this?

Oops, thanks for reminding me! 0.2.0 is out now.

authors: flying-sheep shepmaster

repo: shepmaster/sxd-xpath


text:
ember-cli 3.18 and updates

does this contain any breaking changes?

@Turbo87 I believe the only breaking changes are only supporting Ember versions where you can do this.foo instead of this.get('foo').

repo: shipshapecode/ember-prism


text:
create unit tests for cloud api

Setup running in-memory mongo for tests.
Write some tests for existing endpoints.

3/29 We are comfortable with the level of unit tests

authors: hanatgit johntseng stevendyk

repo: sillsdev/webonary


text:
feat: Add Router route method (#19)

@yokuze back to you to rebase because merging your #29 unfortunately created a merge conflict here.

Coverage increased (+0.03%) to 99.205% when pulling 2f6b64ca65f1c600f98ac1659b44009e54bbd533 on yokuze:add_router_route_19 into 9c33a1e3ceafb910027143636f17ad4d28ecc39d on silvermine:master.

Coverage increased (+0.03%) to 99.205% when pulling 2f6b64ca65f1c600f98ac1659b44009e54bbd533 on yokuze:add_router_route_19 into 9c33a1e3ceafb910027143636f17ad4d28ecc39d on silvermine:master.

Coverage increased (+0.03%) to 99.205% when pulling 2f6b64ca65f1c600f98ac1659b44009e54bbd533 on yokuze:add_router_route_19 into 9c33a1e3ceafb910027143636f17ad4d28ecc39d on silvermine:master.

I pushed these changes.
diff --git a/src/interfaces.ts b/src/interfaces.ts
index 86b76d1..50da097 100644
--- a/src/interfaces.ts
+++ b/src/interfaces.ts
@@ -187,6 +187,7 @@ export interface IRouter {
     *       // Runs for all HTTP verbs
     *    })
     *    .get(function(req, res, next) {
+    *       // Handle GETs to /hello
     *       res.json(...);
     *    })
     *    .post(function(req, res, next) {
@@ -247,7 +248,7 @@ export interface IRoute {
 export interface RouteProcessorAppender<T> {

    /**
-   * @param handlers the processors to mount to this route's path
-   */
+    * @param handlers the processors to mount to this route's path
+    */
    (...handlers: ProcessorOrProcessors[]): T;
 }
diff --git a/tests/integration-tests.test.ts b/tests/integration-tests.test.ts
index a2d806a..11efd89 100644
--- a/tests/integration-tests.test.ts
+++ b/tests/integration-tests.test.ts
@@ -623,12 +623,11 @@ describe('integration tests', () => {
          assert.calledOnce(putSpy);
          assert.notCalled(getSpy);
          assert.notCalled(postSpy);
-         postSpy.resetHistory();
+         putSpy.resetHistory();
       });

       it('registers route handlers properly', () => {
-         let handlers: SinonSpy[] = [],
-             methods: (keyof IRoute & keyof IRouter)[],
+         let methods: (keyof IRoute & keyof IRouter)[],
              allHandler: SinonSpy,
              route: IRoute;

@@ -643,34 +642,46 @@ describe('integration tests', () => {

          // Register a handler for each method
-         _.each(methods, (method) => {
-            let handler = spy((_req: Request, resp: Response) => { resp.send('Test'); });
+         const handlers = _.reduce(methods, (memo, method) => {
+            let handler = spy((_req: Request, resp: Response) => { resp.send(`Test ${method}`); });

             // Save the handler spy for testing later
-            handlers.push(handler);
+            memo[method] = handler;

+            // add the handler to our route
             route[method](handler);
-         });
+
+            return memo;
+         }, {} as { [k: string]: SinonSpy });

          app.use((_req: Request, resp: Response) => {
             resp.send('not found');
          });

          // Run once for each method type
-         _.each(methods, (method) => {
-            testOutcome(method.toUpperCase(), '/test', 'Test');
+         // Both a path with and without a trailing slash should match
+         _.each([ '/test', '/test/' ], (path) => {
+            _.each(methods, (method) => {
+               testOutcome(method.toUpperCase(), path, `Test ${method}`);
+
+               // Check that the "all" handler was called
+               assert.calledOnce(allHandler);
+               allHandler.resetHistory();
+
+               // Check that only the one handler was called
+               _.each(handlers, (handler, handlerMethod) => {
+                  if (method === handlerMethod) {
+                     assert.calledOnce(handler);
+                  } else {
+                     assert.notCalled(handler);
+                  }
+                  handler.resetHistory();
+               });
+            });
          });

-         // Check that each handler was called exactly once
-         _.each(handlers, (handler) => { assert.calledOnce(handler); });
-
-         // Check that the "all" handler was called for each method
-         expect(allHandler.callCount).to.strictlyEqual(methods.length);
-
          // Other tests
          _.each(methods, (method) => {
-            // Ensure trailing slash matches
-            testOutcome(method.toUpperCase(), '/test/', 'Test');
             // Ensure only exact matches trigger the route handler
             testOutcome(method.toUpperCase(), '/test/anything', 'not found');
          });

authors: coveralls jthomerson yokuze

repo: silvermine/lambda-express


text:
Duplicates/repeats in fluff_profile.py

This is fixed now, isn't it?

repo: simonvh/fluff


text:
Rework retrieving actions with cursor_id + add details RPC

@adonagy
please check this clippy: https://github.com/simplestaking/tezedge/pull/477/files#diff-dfe524e1df6b53fdb37d91fc018e02aacce551e8120b8118e6a7d44cfd1d9693R164

@adonagy
Ado, pls. check also this clippy:
https://github.com/simplestaking/tezedge/pull/477/files#diff-63e0f96b392bbe184e431cfcbaaf173aa85e2e34ae65e7fe0f6114a3b5924291R208
https://github.com/simplestaking/tezedge/pull/477/files#diff-63e0f96b392bbe184e431cfcbaaf173aa85e2e34ae65e7fe0f6114a3b5924291R220
https://github.com/simplestaking/tezedge/pull/477/files#diff-63e0f96b392bbe184e431cfcbaaf173aa85e2e34ae65e7fe0f6114a3b5924291R1141

@adonagy
Ado, pls. check also this clippy:
https://github.com/simplestaking/tezedge/pull/477/files#diff-63e0f96b392bbe184e431cfcbaaf173aa85e2e34ae65e7fe0f6114a3b5924291R208
https://github.com/simplestaking/tezedge/pull/477/files#diff-63e0f96b392bbe184e431cfcbaaf173aa85e2e34ae65e7fe0f6114a3b5924291R220
https://github.com/simplestaking/tezedge/pull/477/files#diff-63e0f96b392bbe184e431cfcbaaf173aa85e2e34ae65e7fe0f6114a3b5924291R1141

Fix one warning, get 3 more. Seems like a good deal to me 😄

authors: adonagy bkontur

repo: simplestaking/tezedge


text:
请问使用flask-manage怎么部署呢？

http://flask.pocoo.org/docs/1.0/  自己去看文档


text:
CSS update

Merging for now, will fix the review comments later

authors: TnWn smspillaz

repo: smspillaz/pubmed-retraction-analysis


text:
Write a tutorial for running GetDOS in jupyter notebook at SNS analysis cluster

See https://github.com/sns-chops/multiphonon/wiki/Use-jupyter-notebook-to-run-GetDOS-calculation-at-SNS-analysis-cluster

Old tutorial. Don't need the setup anymore. Setup is now automatic.
This page explains how to set up your jupyter notebook environment at SNS. This only has to be done for once.
Connect to SNS analysis cluster using thinlinc
SNS jupyter service is now only available from inside the SNS analysis cluseter. So the first step is
to connect to SNS analysis cluster using thinlinc.

Open http://analysis.sns.gov in a browser and log in

Log in again if the screen saver was on

Set up jupyter notebook environment
All the following steps happen inside the thinlinc window of the SNS analysis cluster.

Open a browser

Browse to https://jupyter.sns.gov and log in

You are now presented the jupyter view of your home directory at analysis cluster as shown below. Click "New" and then select the "SNS jupyter environment" kernel to create a new notebook.

You are now presented with a new, empty notebook

Type in the code

import sje;
sje.setup()

to setup your jupyter notebook environment.

6. Close this notebook

7. It is done! Your SNS jupyter environment was set up. You are ready to move on to the next step. Use the jupyter notebooks for your data analysis.

Even older tutorial

This tutorial is obsolete

Connect to SNS analysis cluster using thinlinc client or browser. All the following actions happen inside the SNS analysis cluster window.

First open a browser window:

Then start a terminal and type in the following commands to start the jupyter server:

    $ /SNS/ARCS/shared/sns-chops/start-jupyter

Now a new browser tab will show up with a welcoming page

Jupyter notebook is now ready to use. You should not need to do this again unless the jupyter notebook server was killed.

Done. see wiki page

repo: sns-chops/multiphonon


text:
Add support for Scala 2.13

Released in 0.15.0, thanks!

repo: softwaremill/elasticmq


text:
add diagrams to gloo edge workshop

LGTM

👍

authors: asayah lgadban

repo: solo-io/workshops


text:
Add tests against Rails 4. Fixes #64

Not sure why tests are now failing, are the tables kept between test runs?

merged via https://github.com/soundcloud/lhm/commit/2bf8dc3a923dc8fdce494442a209e385542c2c0e
thanks

authors: arthurnn awendt

repo: soundcloud/lhm


text:
Update to new MariaDB driver 2.1.1

Newest is 2.1.2

repo: speedment/speedment


text:
Added ukbconv and simple help text

Thank you!

authors: kasbohm spiros

repo: spiros/docker-ukbiobank-utils


text:
Migrate to new docs

see you again

authors: marcingrzejszczak power-man

repo: spring-cloud/spring-cloud-gateway


text:
Convert Headers to Kotlin

I regressed something:
 okhttp3.CallTest > requestHeaderNameWithSpaceForbidden FAILED java.lang.AssertionError at CallTest.java:3226 okhttp3.URLConnectionTest > requestHeaderValidationIsStrict FAILED java.lang.AssertionError at URLConnectionTest.java:3130 okhttp3.URLConnectionTest > requestHeaders FAILED java.lang.IllegalArgumentException at URLConnectionTest.java:152 okhttp3.URLConnectionTest > responseHeaders FAILED java.lang.IllegalArgumentException at URLConnectionTest.java:207 okhttp3.HeadersTest > addInstantNull FAILED java.lang.IllegalArgumentException at HeadersTest.java:855 okhttp3.HeadersTest > setDateNull FAILED java.lang.IllegalArgumentException at HeadersTest.java:876 okhttp3.HeadersTest > setInstantNull FAILED java.lang.IllegalArgumentException at HeadersTest.java:897 okhttp3.HeadersTest > addDateNull FAILED java.lang.IllegalArgumentException at HeadersTest.java:835 okhttp3.HeadersTest > ofMapThrowsOnNull FAILED java.lang.NullPointerException at HeadersTest.java:206 okhttp3.RequestTest > headerForbidsNullArguments FAILED java.lang.IllegalArgumentException at RequestTest.java:184 okhttp3.RequestTest > headerForbidsControlCharacters FAILED java.lang.AssertionError at RequestTest.java:229 2219 tests completed, 11 failed, 34 skipped

Two kinds of regressions:

Manual null check becomes an IllegalArgumentException when enforced by Kotlin
I created an off-by-one error on checkName() and checkValue()!

repo: square/okhttp


text:
Fix Android Q with Conscrypt or Session Tickets

09:29:05 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: numtests=13
09:29:05 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: stream=
09:29:05 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: test=testConscryptRequest
09:29:05 V/InstrumentationResultParser: INSTRUMENTATION_STATUS_CODE: 1
09:29:05 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: class=okhttp.android.test.OkHttpTest
09:29:05 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: current=13
09:29:05 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
09:29:05 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: numtests=13
09:29:05 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: stream=.
09:29:05 V/InstrumentationResultParser: INSTRUMENTATION_STATUS: test=testConscryptRequest
09:29:05 V/InstrumentationResultParser: INSTRUMENTATION_STATUS_CODE: 0
09:29:06 V/InstrumentationResultParser: INSTRUMENTATION_RESULT: stream=
09:29:06 V/InstrumentationResultParser:
09:29:06 V/InstrumentationResultParser: Time: 14.037
09:29:06 V/InstrumentationResultParser:
09:29:06 V/InstrumentationResultParser: OK (12 tests)
09:29:06 V/InstrumentationResultParser:
09:29:06 V/InstrumentationResultParser:
09:29:06 V/InstrumentationResultParser: INSTRUMENTATION_CODE: -1
09:29:06 V/InstrumentationResultParser:
09:29:06 I/XmlResultReporter: XML test result file generated at /Users/yuri/workspace/okhttp/android-test/build/outputs/androidTest-results/connected/TEST-New_Device_API_29(AVD) - 10-android-test-.xml. Total tests 13, passed 11, assumption_failure 1, ignored 1,
09:29:06 V/ddms: execute 'am instrument -w -r   -e notClass org.conscrypt.KitKatPlatformOpenSSLSocketImplAdapter okhttp.android.test.test/android.support.test.runner.AndroidJUnitRunner' on 'emulator-5554' : EOF hit. Read: -1
09:29:06 V/ddms: execute: returning
09:29:06 V/ddms: execute: running pm uninstall okhttp.android.test.test
09:29:06 V/ddms: execute 'pm uninstall okhttp.android.test.test' on 'emulator-5554' : EOF hit. Read: -1
09:29:06 V/ddms: execute: returning

> Task :android-test:connectedAndroidTest
> Task :android-test:connectedCheck

Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/5.5/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 28s


text:
Multiple styling bugs

This bug has been rectified

repo: sr-temp-repos/LogAggrigator-AptCache


text:
added rotate method

This looks good to me. Useful too. I'd love for a second set of eyeballs, but I'm inclined to say merge it. 👍
Only request: could you add it to the readme also?

👍 LGTM

Thanks guys, just updated the readme :)

authors: alvinsight mattdesl rreusser

license: Zlib


text:
Upgrade spoon runner, gradle tools, fix example lollipop screenshots

@roman-mazur thoughts?

Updated, PTAL

And how was the conflict resolved?

The official plugin added unit tests support in 1.1, breaking the unofficial android-unit-test plugin I was using (https://github.com/JCAndKSolutions/android-unit-test).  I also had to do some gradle transitive dependency exclusion (com.google.code.findbugs from espresso-core and com.android.support from assertj-android).

authors: edenman roman-mazur

repo: stanfy/spoon-gradle-plugin


text:
small code refactors

:+1: lgtm

authors: eddiemonge jenius

repo: stevelacy/gulp-stylus


text:
wip improve stocks

von wieviel bis wieviel soll die volatilität gesetzt werden? Was ist realistisch bei unserem Algorithmus? @RohrerF

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   46.24%   46.24%
=======================================
  Files          51       51
  Lines         653      653
  Branches       75       75
=======================================
  Hits          302      302
  Misses        341      341
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce276a4...21b152d. Read the comment docs.

0.1(fast nix) - 10%(bitcoin like)

Abgeschrieben von hier:
https://stackoverflow.com/a/8597889/6271609

authors: RohrerF codecov-io maracuja-juice

repo: stockmarkat/stockmarket-simulation


text:
[FEATURE] Repository account status

ack

authors: notsure turbo-ele

repo: sulu-io/SuluSalesOrderBundle


text:
Removing unwanted logging in python script

Hi Sinoj,
Thanks for your comments and Pull Request.
Can you please update the code with proper logging , then i will merge it to main branch

authors: sinojkoratty sunishsurendrank


text:
Use docker-compose

OK

repo: suzu-devworks/cpp-examples


text:
Change the min SDK to 17

please check it again


text:
Use prettier format code.

@AnthonyLaw about what this issue is?

yes, we are now using eslint rules from Symbol submodule.
prettier won't be required.

authors: AnthonyLaw cryptoBeliever

repo: symbol/explorer


text:
Wait for promise to resolve in Undo activity handler

Thx👍

authors: akihikodaki syuilo

repo: syuilo/misskey


text:
style fixes

Coverage remained the same at 46.212% when pulling ede5856b5fef9b9599ff41478e01965e50d1d61c on jorjoh:master into 246dba67d32466f6e5023862dc7661b3d68e462f on telemark:master.

authors: coveralls jorjoh


text:
Adding Sprite and load

Pull Request Test Coverage Report for Build 63

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.934%

Totals

Change from base Build 61:
0.0%

Covered Lines:
820

Relevant Lines:
1324

💛  - Coveralls

Pull Request Test Coverage Report for Build 63

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.934%

Totals

Change from base Build 61:
0.0%

Covered Lines:
820

Relevant Lines:
1324

💛  - Coveralls

authors: coveralls shancarter

repo: tensorflow/lucid


text:
fill_array32

maybe related to #6

repo: termoshtt/rust-sfmt


text:
Support bbqueue auto-drop

@thalesfragoso ready for review again

repo: thalesfragoso/esb


text:
Add link to React Native client

You can add it here https://github.com/the-road-to-graphql/fullstack-apollo-express-mongodb-boilerplate and here https://github.com/the-road-to-graphql/fullstack-apollo-react-boilerplate as well :) Thanks for your contribution!


text:
3016 repeat group csv

I wonder if we should wait to merge this until after the critical path changes for UUIDs are merged. That way if there are conflicts, I can fix them without blocking  the critical path.

Update: when UUID work is merged in I will rebase, resolve conflicts and merge.

repo: thecartercenter/elmo


text:
Make InitialMapper multibyte proof

Coverage remained the same at 100.0% when pulling 5a32bd3f12e1b921ac147c3df51287a3e2421db4 on scribbr:multibyte-initials into 9a54a713bf5b2e7fd990828147d42de16bf8a253 on theiconic:master.

Hey @rvanlaak . Sorry, been busy - are you still working on this?
I was thinking i'm a bit hesitent to blanco-require the mbstring extension as it's not active by default. I would therefore prefer we added an abstraction file (or two) for all string operations - could be a class or just namespaced functions so we can use the mbstring versions when that extension is loaded and the standard one when not and thereby degrade gracefully.
What do you think?

Names by their nature simply can be multibyte. Abstracting out the multibyte implementation might cause problems when users don't get that. I would not advise to do that.

@rvanlaak Please have a look at #39 .
I believe this is a good way of doing this while still providing fallback (inspired by the function abstractions in GuzzleHttp).

I'm ok with calling these methods if you decide that name-parser isn't going to be multibyte-proof by default 👍 Could you write a not about that in the README?

Yes, i'm happy to add a note to the README. But i would like to have coverage for all the string functions used in the parser. Do you think you could expand on this and provide a PR that has all the native calls replaced with these?

authors: coveralls rvanlaak wyrfel

repo: theiconic/name-parser


text:
Document M2 usage

Covered by e2d7d977895ef67d03ca67a77a23a4acb08b8569.

repo: timkurvers/blizzardry


text:
Build for Scala 2.13.0-M5

Closed by #40

repo: tkrs/mess


text:
Refactored TestIo to use stringbuilder; implemented missing methods

LGTM

authors: jclc juvester

repo: tmc-cli/tmc-cli


text:
Re-add -ignore-unsupported flag into llvm38 branch

Done in master.

repo: trailofbits/mcsema


text:
APT whitelist request for libmpg123-dev

So what happens now? Is this waiting for someone to clear it, or it will never be added to the whitelist?

We'd also like to use libmpg123 in our Travis configuration; any word on how to proceed with this issue?

I need this as well. Any updates on when these can be added?

authors: dsvensson jaredpetersen kaoskorobase

repo: travis-ci/apt-package-whitelist


text:
Patch and plugin updates

Codecov Report

Merging #233 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   97.53%   97.53%   +<.01%
==========================================
  Files          24       24
  Lines         891      892       +1
  Branches       60       60
==========================================
+ Hits          869      870       +1
  Misses         22       22

Impacted Files
Coverage Δ

core/src/main/scala/io/iteratee/Enumeratee.scala
100% <0%> (+0.46%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06557d...fd470f6. Read the comment docs.

authors: codecov-io travisbrown

repo: travisbrown/iteratee


text:
Save chekbox "Realistic physics" state between different sessions

Уточнение: надо подумать, куда сохранять. Наверное, это должно быть частью задачи, то есть в qrs и поддержать как "нередактируемое".

authors: anastasiia-kornilova iakov

repo: trikset/trik-studio


text:
Removed per client/server specific acquire/release and consolidated them in one place

Can you add more context in the description?
For instance:

How current heron works
What is the problem of current way
How this pull request works
What will change?

Thanks

@maosongfu updated pr.

authors: maosongfu srkukarni

repo: twitter/heron


text:
Added a generalized reduceByKeyAndWindow operator inside the Streamlet

@jerrypeng

I've tried this out locally and it works as expected. Just made one comment re: variable naming. Another thing I'd recommend is enabling the same thing for reduceByWindow. There doesn't seem to be a compelling reason not to allow for that same logic there.

@srkukarni I think the existing:
@Override
public KVStreamlet<KeyedWindow, V>
reduceByKeyAndWindow(WindowConfig windowCfg, SerializableBinaryOperator reduceFn)
should called the more generic version with the identity parameter.  The identity parameter can just be passed as null or something.  This way you don't have two implementations of the same thing essentially

@jerrypeng That makes sense. I've re-implemented it as one version

@lucperkins I'm modeling the naming on native java functions which have essentially the same concept. For example look at https://docs.oracle.com/javase/tutorial/collections/streams/reduction.html.

@lucperkins I've added the reduceByWindow general function as you requested

@srkukarni Got it. If that's standard usage, I'd say go for it.

@srkukarni it would be nice if you can also write some unit tests to test out the logic of the ReduceByKeyAndWindowOperator and ReduceByWindowOperator

@jerrypeng Added the unittests that you requested.

authors: jerrypeng lucperkins srkukarni


text:
Resizable columns. Truncate cell text. #3582

doesn't work for me -- no change in behavior from master.

@scottdraves which table you've tried?
i tried on beaker.rates data and it works for me

authors: mnavasiolava scottdraves

repo: twosigma/beaker-notebook


text:
When noop tracer is configured, do not return a new context with span

Pull Request Test Coverage Report for Build 236

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 73.484%

Totals

Change from base Build 235:
0.007%

Covered Lines:
8206

Relevant Lines:
11167

💛  - Coveralls

authors: coveralls shreyassrivatsan

repo: uber-go/cadence-client


text:
Fix repository in package.json

Coverage remained the same at 100.0% when pulling 3c3a06753be77eff57d38437d4b7be1f8d9b5086 on pdehaan:patch-1 into 9badb7d95dafbc9096be190b28e2a402b0577b93 on uber-web:master.

Good catch, thanks!

authors: coveralls dawsonbotsford pdehaan

repo: uber-web/uber-eslint


text:
Develop

Changes Unknown when pulling e36d94e0c9da09b7a2873b1ca054cb7ab8247d1b on develop into ** on master**.

authors: coveralls fanglinfang

repo: uw-it-aca/uw-restclients-trumba


text:
Fix the TreeGrid selection

Closes #4 and #7


text:
Add license to optout version, for webjars

LGTM

authors: Artur- tomivirkki

repo: vaadin/vaadin-usage-statistics


text:
Update values.php

En over snittet edruelighetsorientert pull request.

authors: kbrabrand rexxars

repo: vaffel/kjerneverdi


text:
Update Junit Jacoco Plugin

Current coverage is 93.76%

Merging #40 into master will not affect coverage as of c629f08

@@            master     #40   diff @@
======================================
  Files           15      15
  Stmts          609     609
  Branches       122     122
  Methods          0       0
======================================
  Hit            571     571
  Partial         19      19
  Missed          19      19

Review entire Coverage Diff as of c629f08

Powered by Codecov. Updated on successful CI builds.

authors: codecov-io vanniktech

repo: vanniktech/OnActivityResult


text:
Login redesign

Hey @yuliia-n,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
View build log
TravisBuddy Request Identifier: 12916b30-dafa-11e9-a83c-6d8e6b7d4c6a

authors: TravisBuddy yuliia-n

repo: vasinkevych/ReactNativeApp


text:
Fix paths on windows

Just that the path doesn't include 'builds' with the wrong direction slash

repo: vector-im/riot-builder


text:
Added next raw to community plugins.

Hey! We're deprecating this repository hence why this PR hasn't been merged. I just updated the readme. You can try adding it to the community awesome list: https://github.com/unicodeveloper/awesome-nextjs.

authors: Myoxocephalus timneutkens

repo: vercel/next-plugins


text:
Filter out metrics for nodes not in service

The node sets itself in rotation when it has initialized completely, and has received an answer from content cluster nodes it should talk to. The former can take a long time, and the latter even longer with tx replay. In addition, the node can take itself out of rotation later, if backends become unresponsive (or if the local content node does, if this is a combined cluster with single-node-group content distribution).

repo: vespa-engine/vespa


text:
Add Node School's Git, SQLZoo and Free Code Camp

@vhf Rather than having FCC posted twice on the list, I think we should have a "Full Stack web development" section. While Full Stack is a bit of a buzz word, I think it can include the following:

Free Code Camp (new, JS focused)
Odin Project (existing, Ruby/Rails focused)

I agree on the idea @onebree but I'm not sure about the section name you suggest. I'll think about it.

Hi @vhf did you have time to think about this? Please let me know if you have any questions about Free Code Camp or the other resources I recommended adding.

authors: QuincyLarson onebree vhf

repo: vhf/free-programming-books


text:
Another migration fix

Ack

authors: Vitalynx romanornr

repo: vialectrum/vialectrum


text:
added ToC & some books to Git

Good work 🎉 @bomholtm


text:
Cover master

Changes Unknown when pulling c86b6fc0fd4feb3e0511674e759e85f0b60eee70 on cover_master into ** on master**.

Changes Unknown when pulling b6548acc856ce8241f771297dd7ed907f0664ef3 on cover_master into ** on master**.

Changes Unknown when pulling c30a0d00ed57e876068adc9ba059d02657e0c0f5 on cover_master into ** on master**.

Changes Unknown when pulling c30a0d00ed57e876068adc9ba059d02657e0c0f5 on cover_master into ** on master**.

authors: coveralls vincentLiuxiang

repo: vincentLiuxiang/lu


text:
New profile for nano

Kann gemerged werden.

repo: vision-it/vision-editors


text:
Add documentation on the mainMenu module in its unit tests

New estimation: 0.5 hours.

repo: vk-x/vk-x


text:
SASS

Test integration with trello

repo: voronin-ivan/insta-preview


text:
[question] som api: should we have a client to hold an authentication object?

this is done - the user must have a token to use the api, and the client manages (and refreshes) that token when necessary.
https://github.com/vsoch/som/blob/master/som/api/base/auth.py
Note that authentication is handled in the base class, which the identifiers api creates an instance of (and adds further details/functions). This is done so in the future other api clients could be added, taking advantage of the same basic get/put/authenticate functions. Closing!

repo: vsoch/som


text:
Translate v2/guide/custom-directive

Por que aparecen aqui los dos commits de anoche, que supuestamente ya fueron "merged" en el ultimo PR?

Antes de hacer el nuevo PR, has incorporado los cambios de este branch (el merge) en tu repositorio?

vale perdona, me olvide de hacer el pull antes de hacer el PR.


text:
Add download buttons from webflow

@jbothma are you able to check what is the problem with WIP code?
The code there causes Uncaught SyntaxError: Unexpected end of input error.
What's weird, even if comment that code out it still shows an error.
I tried with getElementByID - the same problem.
Can you please check on your machine?

Maybe I did something wrong in terms of your rule here:
It is critical that none of the static files or templates in the webflow app are modified directly. That code is modified in webflow.com and imported here. Direct changes will be overwritten.

The javascript to implement this feature is in static/js/webflow.```

@jbothma what is the solution... change yarn version from 1.21 to 1.22 - thats what I hate FE for! :D

repo: vulekamali/datamanager


text:
On mobile viewports, placement of the "hamburger" menu toggle button could be better

This came from a comment on https://github.com/wagtail/wagtail/pull/6930
So maybe @thibaudcolas can tell.

Ah, I see now... With the large title it pushes the hamburger to the another line.

I guess we could just hide the title on small screens.

There's also an accessibility issue related to this that I just discovered: That button has no text in it (or aria-label), so it won't be read by screen readers. I will look at fixing in conjunction with this issue.

Fixed in #109.

authors: Scotchester allcaps tbrlpld thibaudcolas


text:
[ コーディング ] ナビゲーション

完了


text:
Object grab does not update object physics model

Fixed long ago.

repo: webaverse/app


text:
header刷新高度有问题，可以由高变矮，但是不能由矮变高

reload之前要remove self.constraints, 另外configureheader之前也要remove header.constraints否则同一个header的高度发生改变后会add多个不同的constraints，有冲突！

为什么会向上移动70像素啊？？？

authors: CalmHeart haoero

repo: weijingyunIOS/HHHorizontalPagingView


text:
Minor changes in README.md

@lex111 Thanks for the contribution

repo: whera/SimpleUpload


text:
Amazon elasticsearch signed requests support

Pleaase add a link to docs. What the hell is it?

Links attached, sorry

This would be nice to have, but I think it would take some work. Requests allows a callable http_auth object to float all the way through from the transport class to a PreparedRequest object which can then (and probably not safely sooner) process the final body and headers for signing. There are also a few more gymnastics needed, for instance ensuring header date (if provided) matches the signing key's scope date.
At the surface, aiohttp looks similar, but underneath the implementation is different. Headers could, in theory, float through to the ClientSession from the ES init (c/o transport/connection), but after a quick scan I didn't see an opportunity to trigger a callable/hook. Perhaps I'm overlooking an approach within aiohttp.

any news on this, we need it as well.
@hellysmile did you try something with the flow from aiobotocore?

authors: asvetlov hellysmile jeremyblow sloev

repo: wikibusiness/aioelasticsearch


text:
Sync required EAP changes back upstream

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/240/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/241/
Test PASSed.

authors: fusesource-ci tdiesler

repo: wildfly-extras/wildfly-camel


text:
fixes display fundraiser text instead of title

Pull Request Test Coverage Report for Build 581161156

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 74.208%

Totals

Change from base Build 492130030:
0.0%

Covered Lines:
1673

Relevant Lines:
2057

💛  - Coveralls

authors: coveralls jaapstronks

repo: wingscms/wings


text:
Please add x86_64   thx

OK.
And maybe you can try add it yourself.

Ok then what is the version of ffmpeg ？

https://github.com/wysaid/android-gpuimage-plus/issues/447

Done.

repo: wysaid/android-gpuimage-plus


text:
what is difference between RRDB_ESRGAN_x4 and RRDB_PSNR_x4

As far as I understood, RRDB_ESRGAN_x4 is the current ESRGAN model, and RRDB_PSNR_x4 is a standart SRGAN one that gives smoother results (can be found here https://github.com/xinntao/BasicSR/blob/master/metrics/calculate_PSNR_SSIM.py).

No, PSNR is the model trained only using content loss to initialize the filters. You use the PSNR model as a pre-trained model to train the ESRGAN model with feature loss and adversarial loss, so it converges faster to the global minima. Read the paper, it's explained there.

repo: xinntao/ESRGAN


text:
Интегрировать новый стиль демо-интерфейса

 Login UE 4 - интегрировать дизайн в виджет


text:
[patch] release

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   81.72%   81.72%
=======================================
  Files          14       14
  Lines         476      476
=======================================
  Hits          389      389
  Misses         77       77
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a5e742...1e43883. Read the comment docs.

authors: codecov-io kevindiu

repo: yahoojapan/authorization-proxy


text:
Add support for string concatenation in keys

@yellowblood I updated the code, just take a look now, and merge if ok

repo: yellowblood/hocon-js


text:
Added missing line for Api token storage in docs. Fixes #300.

Thanks

repo: yelouafi/redux-saga


text:
Добавлена информация в README

Codecov Report

Merging #5 (448d1bb) into master (22204fa) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #5   +/-   ##
=========================================
  Coverage     75.00%   75.00%
  Complexity       19       19
=========================================
  Files             6        6
  Lines           124      124
  Branches          4        4
=========================================
  Hits             93       93
  Misses           28       28
  Partials          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0992dd...448d1bb. Read the comment docs.

authors: codecov-commenter layfe


text:
嵌套在ScrollView中的话，会出现轮播图第一个item无法获取点击事件，滑动到第二个就好的问题

同求~ 请问解决了吗？

已经解决了！ 把这个方法 banner.start(); 放到点击事件后就可以了！！

厉害

authors: andnr03 skyYoungJade tokiii


text:
您好，我希望两个轮播图片之间有一定的距离，应该怎么实现

@shenyunmeng0519  https://github.com/wenchaosong/Banner 这是我修改这个库实现的

https://github.com/qssq/Banner

authors: qssq shenyunmeng0519 wenchaosong


text:
List var

lgtm
Can you check if there's relevance in repeating these tests for v3?

If v3 is using dbapi and field_types then no, if you are using something custom then yes.

authors: shrutip sougou

repo: youtube/vitess


text:
【待校对】附2：用反向传导思想求导（Deriving gradients using the backpropagation idea）

校对完成


text:
Bumb TypeScript Version to 2.0

Related to: https://github.com/zalando-incubator/lib-oauth-tooling/issues/2
We should get rid of all external dependencies!

authors: awaltert bzums

repo: zalando-incubator/lib-oauth-tooling


text:
Upgrade jest and simplify .babelrc

Okay. Looks good to me.

authors: arunoda brikou


text:
Move static file downloads to fast hosting location

DigitalOcean spaces: https://zeropingheroes.ams3.digitaloceanspaces.com/

Moved to DigitalOcean spaces in dc61eaf5c0c143aaf1232e06735ed9bc131484c6 and faf824014de1ddecfb4629585621b433c6dc6065

repo: zeropingheroes/game-servers


text:
Support UNDO on readline

This issue is dupplicated #116

repo: zetamatta/nyagos


text:
Typescript

Nice)

Thanks

Thank you for the work done!


text:
Feature/doctrine module zend hydrator

I've just come across this issue:
Fatal error: Declaration of ZF\Apigility\Doctrine\Server\Resource\DoctrineResource::setHydrator() must be compatible with Zend\Hydrator\HydratorAwareInterface::setHydrator(Zend\Hydrator\HydratorInterface $hydrator) in /blah_project/vendor/zfcampus/zf-apigility-doctrine/src/Server/Resource/DoctrineResource.php on line 38
Is there anything I can do to help resolve the build failures?
Cheers
Alex

https://github.com/doctrine/DoctrineModule/issues/546#issuecomment-227930932

authors: TomHAnderson alexb-uk

repo: zfcampus/zf-apigility-doctrine


text:
Fixed class name typo

Any movement on this?

Ran into the same issue, and applied the same fix as the PR is doing.

@weierophinney any change this PR can be merged and a patch release 1.3.1 can be brought to life ?

@dominiksagi just for future reference: submit bugfixes against master, and feature changes against develop. I'll cherry pick this into master for now.

authors: DannyvdSluijs dominiksagi jeandormehl weierophinney

repo: zfcampus/zf-rpc


text:
Return useful error codes

This fixes #25

repo: zmap/zdns


text:
New PR to test SignCLA at 2019-04-18 13:34:08.557626558 -0700 PDT m=+5.769034849

Body of PR

corp-pass-fork-staging: test succeeded

repo: google-test/signcla-probe-repo-dev