text:
feat: Add option to define a delimiter for metric-alarms-by-multiple-dimensions

Description
Add option to define a delimiter between alarm name and dimension key for metric-alarms-by-multiple-dimensions
Motivation and Context
While creating multiple alerts I noticed that there is no delimiter between common prefix and dimension resource name, so I had to prefix them by space character:
" ${local.project.name}-postgres-${local.env}"

and this does not look so pretty:
inputs = {
    items = {
        rds-cpu-usage = {
...
            dimensions = {
                " ${local.project.name}-postgres-${local.env}" = {
                   DBClusterIdentifier = "${local.project.name}-postgres-${local.env}"
                }
            }
...
        }
...

Breaking Changes
None, default value falls back to previous behaviour.
How Has This Been Tested?
There are no examples that use metric-alarms-by-multiple-dimensions, so I tested it only on my local project.

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

[x] I have executed pre-commit run -a on my pull request

This PR is included in version 5.3.0 :tada:

authors: antonbabenko caseycs


text:
Adding the r5.16xlarge to the ebs optimized list

PR o'clock
Description
The r5.16xlarge is missing from the list
Checklist

[x] terraform fmt and terraform validate both work from the root and examples/ebs_optimized_test_fixture directories (look in CI for an example)
[ ] Tests for the changes have been added and passing (for bug fixes/features)
[ ] Test results are pasted in this PR (in lieu of CI)
[ ] Docs have been added/updated (for bug fixes/features)
[ ] Any breaking changes are noted in the description above

This issue has been resolved in version 0.2.1 :tada:

source: gharchive/pull-request

license_type: permissive

license_source: github-api


text:
Missing Module idempotency when re-applying to non-changing Lambda within VPC

Hey folks,

EDIT: Looks like a wider AWS Terraform provider --> https://github.com/hashicorp/terraform-provider-aws/issues/17385

We're facing a quite weird issue when trying to re-run a non-changing Lambda function that lives within a VPC (security group and subnet IDs configured as inputs). Our configuration is quite simple and sticks with your complete example inside this module. I noticed there was a very similar issue raised by another chap and fixed here, but this seems different as only occurs when the Lambda gets deployed into a VPC
No significant changes nor nothing that would lead to a confusion, latest version of terraform-aws-lambda consumed as a module.
We think this issue may reside in the null_resource.deploy because the Lambda function itself "changed" based on the data resource it gather at runtime. If we for instance, change the publish variable to false in a subsequent execution, the module remains idempotent as such.
Using vanilla Terraform 0.14.6 at the minute. An snippet of a subsequent terraform apply execution that produces this error.
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  ~ update in-place
-/+ destroy and then create replacement
 <= read (data resources)

Terraform will perform the following actions:

  # module.lambda_deploy.data.aws_iam_policy_document.assume_role[0] will be read during apply
  # (config refers to values not yet known)
 <= data "aws_iam_policy_document" "assume_role"  {
      ~ id      = "12345678" -> (known after apply)
      ~ json    = jsonencode(
            {
              - Statement = [
                  - {
                      - Action    = "sts:AssumeRole"
                      - Effect    = "Allow"
                      - Principal = {
                          - Service = "codedeploy.amazonaws.com"
                        }
                      - Sid       = ""
                    },
                ]
              - Version   = "2012-10-17"
            }
        ) -> (known after apply)
      - version = "2012-10-17" -> null

      ~ statement {
          - not_actions   = [] -> null
          - not_resources = [] -> null
          - resources     = [] -> null
            # (2 unchanged attributes hidden)

            # (1 unchanged block hidden)
        }
    }

  # module.lambda_deploy.data.aws_lambda_alias.this[0] will be read during apply
  # (config refers to values not yet known)
 <= data "aws_lambda_alias" "this"  {
      ~ arn              = "(SENSITIVE)" -> (known after apply)
      + description      = (known after apply)
      ~ function_version = "1" -> (known after apply)
      ~ id               = "(SENSITIVE)" -> (known after apply)
      ~ invoke_arn       = "(SENSITIVE)" -> (known after apply)
        name             = "dev"
        # (1 unchanged attribute hidden)
    }

  # module.data.aws_lambda_function.this[0] will be read during apply
  # (config refers to values not yet known)
 <= data "aws_lambda_function" "this"  {
      ~ arn                            = "(SENSITIVE)" -> (known after apply)
      + code_signing_config_arn        = (known after apply)
      ~ dead_letter_config             = [] -> (known after apply)
      ~ description                    = "(SENSITIVE)" -> (known after apply)
      ~ environment                    = [
          - {
              - variables = {
                  - "(SENSITIVE)" = "(SENSITIVE)"
                }
            },
        ] -> (known after apply)
      ~ file_system_config             = [] -> (known after apply)
      ~ handler                        = "index.handler" -> (known after apply)
      ~ id                             = "(SENSITIVE)" -> (known after apply)
      ~ invoke_arn                     = "(SENSITIVE)" -> (known after apply)
      + kms_key_arn                    = (known after apply)
      ~ last_modified                  = "2021-02-10T12:17:18.647+0000" -> (known after apply)
      ~ layers                         = [] -> (known after apply)
      ~ memory_size                    = 256 -> (known after apply)
      ~ qualified_arn                  = "(SENSITIVE):1" -> (known after apply)
      ~ qualifier                      = "1" -> (known after apply)
      ~ reserved_concurrent_executions = -1 -> (known after apply)
      ~ role                           = "(SENSITIVE)" -> (known after apply)
      ~ runtime                        = "nodejs12.x" -> (known after apply)
      + signing_job_arn                = (known after apply)
      + signing_profile_version_arn    = (known after apply)
      ~ source_code_hash               = "FhBljq72lzd6yS3/=" -> (known after apply)
      ~ source_code_size               = (SENSITIVE)-> (known after apply)
      ~ tags                           = {} -> (known after apply)
      ~ timeout                        = 10 -> (known after apply)
      ~ tracing_config                 = [
          - {
              - mode = "PassThrough"
            },
        ] -> (known after apply)
      ~ version                        = "1" -> (known after apply)
      ~ vpc_config                     = [
          - {
              - security_group_ids = [
                  - "(SENSITIVE)",
                ]
              - subnet_ids         = [
                  - "subnet-(SENSITIVE)",
                  - "subnet-0(SENSITIVE)",
                  - "subnet-0(SENSITIVE)",
                ]
              - vpc_id             = "vpc-0(SENSITIVE)"
            },
        ] -> (known after apply)
        # (1 unchanged attribute hidden)
    }

  # module.lambda_deploy.aws_iam_role.codedeploy[0] will be updated in-place
  ~ resource "aws_iam_role" "codedeploy" {
      ~ assume_role_policy    = jsonencode(
            {
              - Statement = [
                  - {
                      - Action    = "sts:AssumeRole"
                      - Effect    = "Allow"
                      - Principal = {
                          - Service = "codedeploy.amazonaws.com"
                        }
                      - Sid       = ""
                    },
                ]
              - Version   = "2012-10-17"
            }
        ) -> (known after apply)
        id                    = "(SENSITIVE)"
        name                  = "(SENSITIVE)"
        tags                  = {}
        # (6 unchanged attributes hidden)
    }

  # module.lambda_deploy.null_resource.deploy[0] must be replaced
-/+ resource "null_resource" "deploy" {
      ~ id       = "(SENSITIVE)" -> (known after apply)
      ~ triggers = {
          - "appspec_sha256" = "4e64a69ea61baad2bc"
          - "force_deploy"   = "false"
        } -> (known after apply) # forces replacement
    }

  # module.lambda_function.aws_lambda_function.this[0] will be updated in-place
  ~ resource "aws_lambda_function" "this" {
        id                             = "(SENSITIVE)"
      ~ qualified_arn                  = "(SENSITIVE):1" -> (known after apply)
        tags                           = {}
      ~ version                        = "1" -> (known after apply)
        # (18 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

Plan: 1 to add, 2 to change, 1 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value:

Any help would be appreciated!

If someone jumps into this thread, this issue is being investigated here --> https://github.com/hashicorp/terraform-provider-aws/issues/17385

This has already been fixed in the upstream AWS provider. Closing this issue now

source: gharchive/issue


text:
Consecutive terraform plan always show changes to Lambda function

Description
Every time a terraform plan is run, the filename of the Lambda function is changing. "null_resource" "archive" is different every time, and thus the lambda function is destroyed and recreated on every apply.
I think the issue is related to executing this module twice in the same config. According to the docs for the Lambda module, a collision can occur if you do that and so there's an extra_hash you can add, but I don't see that as an input for this module.
⚠ Note
Before you submit an issue, please perform the following first:

Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
Re-initialize the project root to pull down modules: terraform init
Re-attempt your terraform plan or apply and check if the issue still persists

Versions

Terraform:
v1.1.2
Provider(s):

provider registry.terraform.io/hashicorp/aws v3.71.0
provider registry.terraform.io/hashicorp/external v2.2.0
provider registry.terraform.io/hashicorp/local v2.1.0
provider registry.terraform.io/hashicorp/null v3.1.0

Module:

Reproduction

Steps to reproduce the behavior:

Define this module twice in the same config. You will need to override the lambda_function_name otherwise there will be a collision.

No

Yes

Apply once successfully
Change nothing, immediately run terraform plan and see that several resources are proposed to be replaced.

Code Snippet to Reproduce

Expected behavior
I would expect that a successful apply and subsequent plan would not have any changes
Actual behavior
What is actually happening is that 6 resources are being proposed to be added, 5 changed, and 6 destroyed.
Terminal Output Screenshot(s)

Additional context

You will need to override the lambda_function_name otherwise there will be a collision.

lambda_function_name should be unique to avoid the behavior you are seeing. I can't imagine a better workaround for this, yet.
Closing this issue.

lambda_function_name is unique, but the behavior is as I described


text:
fix: Rg output

Description

Release required?

[ ] No release
[x] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

:tada: This PR is included in version 1.2.1 :tada:
The release is available on:

GitHub release
v1.2.1

Your semantic-release bot :package::rocket:

repo: terraform-ibm-modules/mock-module


text:
chore(deps): update terraform-module

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/event-notifications/ibm (source)
module
patch
1.15.5 -> 1.15.8

terraform-ibm-modules/secrets-manager/ibm (source)
module
patch
1.19.4 -> 1.19.8

Release Notes

terraform-ibm-modules/terraform-ibm-event-notifications (terraform-ibm-modules/event-notifications/ibm)
v1.15.8
Compare Source
Bug Fixes

deps: update terraform-module (#357) (2b4f55c)

v1.15.7
Compare Source
Bug Fixes

deps: update terraform-module (#353) (75cb73c)

v1.15.6
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#348) (3a46daf)

terraform-ibm-modules/terraform-ibm-secrets-manager (terraform-ibm-modules/secrets-manager/ibm)
v1.19.8
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/event-notifications/ibm to v1.15.7 (#258) (af11cdb)

v1.19.7
Compare Source
Bug Fixes

deps: update terraform-module (#249) (20ac785)

v1.19.6
Compare Source
Bug Fixes

deps: DA updates:- locked ibm provider version to 1.73.08 updated KMS module version to 4.18.1 (#257) (51b861f)

v1.19.5
Compare Source
Bug Fixes

updated the region selector in the DA to only show Secrets Manager supported regions (#251) (b43e33b)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline


text:
fix: add extra validation for kms

Description
add extra validation for kms
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content
add extra validation for kms when creating new kms key and existing kms instance is empty.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline


text:
fix(deps): update terraform terraform-ibm-modules/cbr/ibm to v1.9.1

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cbr/ibm (source)
module
patch
1.9.0 -> 1.9.1

Release Notes

terraform-ibm-modules/terraform-ibm-cbr (terraform-ibm-modules/cbr/ibm)
v1.9.1
Compare Source
Bug Fixes

update module references in README (#284) (321229b)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


text:
chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
67f3ce5 -> 616b101

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
minor
v1.35.4 -> v1.36.0

go (source)
toolchain
patch
1.22.5 -> 1.22.6

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.36.0
Compare Source
Features

simplify testprojects TearDown logic (#845) Simplified the logic around when resources or projects should get deleted during TestTearDown in the testprojects package, also added unit tests to verify all permutations. (380757f)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

:tada: This issue has been resolved in version 3.16.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


text:
chore(deps): update common-dev-assets digest to d583c56

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
eec8f4a -> d583c56

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


text:
Revert "fix: "dependency_version_2": true"

Reverts terraform-ibm-modules/terraform-ibm-landing-zone#924

/run pipeline

:tada: This PR is included in version 6.4.2 :tada:
The release is available on:

GitHub release
v6.4.2

Your semantic-release bot :package::rocket:

authors: ocofaigh terraform-ibm-modules-ops


text:
chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
a043dc4 -> e143de9

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
minor
v1.24.1 -> v1.25.0

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.25.0
Compare Source
Features

add ability to unskip upgrade test (#702) (95cbb82)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.15.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


text:
chore(deps): update module github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper to v1.2.7

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.2.6 -> v1.2.7

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by Renovate Bot.

Blocked due to known issue. Support case open

:tada: This PR is included in version 5.1.0 :tada:
The release is available on:

GitHub release
v5.1.0

Your semantic-release bot :package::rocket:


text:
chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
ce80a6d -> 3324eff

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.28.3 -> v1.28.4

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.28.4
Compare Source
Bug Fixes

deps: update module golang.org/x/crypto to v0.19.0 (#757) (72d3f03)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


text:
chore(deps): update common-dev-assets digest to 0ba1b37

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
e11eb25 -> 0ba1b37

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 3.2.0 :tada:
The release is available on:

GitHub release
v3.2.0

Your semantic-release bot :package::rocket:


text:
feat: Add the ability to define the scope of SCC attachement

Description
Add the ability to define the scope of SCC attachement
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content
Add the ability to define the scope of SCC attachement
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

@jor2 you may also want to consider including this change too https://github.com/terraform-ibm-modules/terraform-ibm-scc-da/issues/149

/run pipeline

/run pipeline

Oh @jor2 The new inputs need to be added to ibm_catalog.json - you should make the attachment_schedule a dropdown with the supported values

updated, is that what you meant by dropdown?

/run pipeline

/run pipeline

@SirSpidey The support_details were added to all of the DAs in the community registry. There is no cloud docs to link to for those DAs. And they are not supported through support cases as they are not in main catalog

:tada: This issue has been resolved in version 1.15.0 :tada:
The release is available on:

GitHub release
v1.15.0

Your semantic-release bot :package::rocket:

authors: jor2 ocofaigh terraform-ibm-modules-ops


text:
chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
c92be0f -> 554fc45

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.10.18 -> v1.10.19

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.10.19
Compare Source
Bug Fixes

deps: update gomod (#607) (3101f35)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


text:
Add a private secret manager example and test

Description
A private only secrets manager example needs to be created and used in a test in the pr_test.go.
New or affected modules

By submitting this issue, you agree to follow our Code of Conduct

@kierramarie instead of adding a whole new example, maybe update one of the existing ones to deploy private only since we already have 2 examples

authors: kierramarie ocofaigh


text:
Update 1D block converter to prevent negative area components.

Description

The HexComponentsToCylConverter class is updated in this to properly handle and check for
negative area components after the conversion has occurred. This is a scenario that was previously
not handled and can occur when the user implements a block design in the blueprints where
two solid components are connected with a "gap-like" component and then have overlaps due
to thermal expansion. This "gap-like" component can be named anything and can either have
Void or some Liquid material type. Void components explicitly named "gap" are already handled
correctly, but that logic was not sufficient to also handle negative area components in edge modeling
cases.

Checklist

[x] The code is understandable and maintainable to people beyond the author.
[x] Tests have been added/updated to verify that the new or changed code works.
[x] There is no commented out code in this PR.
[x] The commit message follows good practices.
[x] All docstrings are still up-to-date with these changes.

If user exposed functionality was added/changed:

[x] Documentation added/updated in the doc folder.
[x] New or updated dependencies have been added to setup.py.

Hi @john-science - I added a unit test to confirm the behavior of treating negative area components on the 1D conversion process.

repo: terrapower/armi


text:
update filecounter, Docker, Readme

standardize filecounter code
add beginnings of Dockerfile & Readme

Closing this one for https://github.com/terraref/computing-pipeline/pull/531/files

repo: terraref/computing-pipeline


text:
SW-5795 Use dynamic IDs in ThumbnailStoreTest

Stop using hardwired file and thumbnail IDs in ThumbnailStoreTest, and remove the
ability to create them with hardwired IDs.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2285  👈
#2284
#2283
#2282
#2281
#2280
#2279
#2278
#2277
#2276
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgrimm and the rest of your teammates on  Graphite

Merge activity

Aug 14, 12:21 PM EDT: @sgrimm started a stack merge that includes this pull request via Graphite.

repo: terraware/terraware-server


text:
Bump webpack-dev-middleware from 5.3.3 to 5.3.4

Seeing this update works when I open a PR with the same changes as the PR Dependabo opened.

Closing as this PR is a duplicate of this PR.

repo: terraware/terraware-web


text:
feat: rn60 podspec

add a podspec file driven by package.json as per RN recommendations:
- Contact the library maintainers or send them a PR to add a podspec. The react-native-webview podspec is a good example of a package.json driven podspec. See
https://github.com/react-native-community/react-native-webview/blob/master/react-native-webview.podspec

Hey, see new release https://github.com/terrillo/rn-apple-healthkit/releases/tag/0.7.0v
Merged in [Added Pods Header in Header Search Path #101] first

authors: kevinsperrine terrillo

repo: terrillo/rn-apple-healthkit

license: mit

license_source: bigquery


text:
Don't re-render course graph on dark mode toggle

=> Is this even possible

I don't think that's possible, dark mode impacts some node colors in the course graph

I don't think that's possible, dark mode impacts some node colors in the course graph

If we don't change the color and take out of useDarkMode() hook in the component, then it won't re-render

Maybe re-render wasn't the right word, it's mainly the startup animation we could probably get rid of


text:
move update instructions back to here

@johnnyman727 I had moved this out when I moved instructions to the t2-docs repo, but I shouldn't have. These ones should stay here; we can update the other one to t2 update but people working on the CLI should know how to update their firmware manually.

looks good


text:
Crash/Exception with option textord_heavy_nr=1

Environment

Tesseract Version: 5.2.0
Platform: Windows10 64-Bit, running Tesseract 32-Bit Debug

Current Behavior:

Crash/Exception with option textord_heavy_nr=1
Call: tesseract.exe test.bmp stdout --tessdata-dir %DataDir% -l deu --psm 6 -c textord_heavy_nr=1
Not dependent on image
The value 0xDDDDDDDD is used by Microsoft's C++ debugging heap to mark freed heap memory
Same error with Tesseract 5.1.0
Build:
cmake -B %BuildDir% -S %SourceDir% -G "Visual Studio 15 2017" -A Win32 -DSW_BUILD=OFF -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON -DCMAKE_TOOLCHAIN_FILE=%VcpkgToolchain% -DBUILD_TRAINING_TOOLS=OFF -DHAVE_LIBCURL=OFF -DHAVE_LIBARCHIVE=OFF -DDISABLED_LEGACY_ENGINE=ON -DCMAKE_INSTALL_PREFIX=%InstallDir% -DDISABLE_ARCHIVE=ON -DDISABLE_CURL=ON
cmake --build %BuildDir% --config Debug --target INSTALL --clean-first

Expected Behavior:
No Exception
Suggested Fix:

It looks like a double free here:
#5  0x000000000047af0c in tesseract::BLOBNBOX::~BLOBNBOX (this=0x154c410) at ../../../src/ccstruct/blobbox.h:154
154	      delete cblob_ptr;

tesseract --dpi 300 https://user-images.githubusercontent.com/3341558/179373903-ef6cc246-f4e5-4633-a762-ded4dd22708f.jpg - -c textord_heavy_nr=1
=================================================================
==1511914==ERROR: AddressSanitizer: heap-use-after-free on address 0x602000ad0e18 at pc 0x00000057532d bp 0x7ffe8d1cb660 sp 0x7ffe8d1cb658
READ of size 8 at 0x602000ad0e18 thread T0
    #0 0x57532c in tesseract::ELIST::empty() const /tesseract/bin/debug/clang,sanitize/../../../src/ccutil/elst.h:125:13
    #1 0x164d2db in tesseract::ELIST::internal_clear(void (*)(void*)) /tesseract/bin/debug/clang,sanitize/../../../src/ccutil/elst.cpp:42:8
    #2 0x63a809 in tesseract::X_LIST<tesseract::ELIST, tesseract::ELIST_ITERATOR, tesseract::C_OUTLINE>::clear() /tesseract/bin/debug/clang,sanitize/../../../src/ccutil/list.h:54:16
    #3 0x63a677 in tesseract::X_LIST<tesseract::ELIST, tesseract::ELIST_ITERATOR, tesseract::C_OUTLINE>::~X_LIST() /tesseract/bin/debug/clang,sanitize/../../../src/ccutil/list.h:49:5
    #4 0x63a60a in tesseract::C_OUTLINE_LIST::~C_OUTLINE_LIST() /tesseract/bin/debug/clang,sanitize/../../../src/ccstruct/coutln.h:74:1
    #5 0x63a5a0 in tesseract::C_BLOB::~C_BLOB() /tesseract/bin/debug/clang,sanitize/../../../src/ccstruct/stepblob.h:40:16
    #6 0x8c1401 in tesseract::BLOBNBOX::~BLOBNBOX() /tesseract/bin/debug/clang,sanitize/../../../src/ccstruct/blobbox.h:154:7
[...]

The issue is fixed in commit ee34b100bf9b54d3f201c7417d263988a9ad0b3f.

authors: jam-codx stweil

repo: tesseract-ocr/tesseract


text:
Fix crash caused by undefined value of local variable

Commit b1f03cb6975ee4bde6d8c9450ea55f111cc36ac1 added a call of function
FreeFeatureSet to fix a memory leak, but introduced a new bug because the
local variable FloatFeatures was not always assigned a value.
Now FloatFeatures is always assigned a value, and we only need a single
place where FreeFeatureSet is called.
Signed-off-by: Stefan Weil sw@weilnetz.de

Looks good to me. Thanks. In my testing, this revision fixes the crash issue.

authors: rmtheis stweil


text:
Change Default psm to 13 in Makefile

As per https://github.com/tesseract-ocr/tesstrain/pull/159#issuecomment-615713572

Thank you!

authors: Shreeshrii stweil

repo: tesseract-ocr/tesstrain


text:
Add additional config option - provision_docker_command

Similar to provision_command but you can specify the Dockerfile command prefix for each.
Opted to go this way to avoid breaking provision_command current functionality.
Includes example use case in README.
This PR supercedes https://github.com/portertech/kitchen-docker/pull/133 and depends on https://github.com/portertech/kitchen-docker/pull/136 for ADD and COPY commands.

This is better handled by making a custom Dockerfile template.

authors: CpuID coderanger

repo: test-kitchen/kitchen-docker


text:
Proposal: Decision Table Interpreter

I have an Idea for a new Decision Table Interpreter:
https://gist.github.com/slu-it/6852ac47deb7998a911127459c5a1d60

Pull Request containing a real implementation: #22

API classes of this proposal were merged with #22


text:
How to stream "docker logs" to logger for DockerComposeContainer

In #94 was discussed a solution to stream log files of a single container to a given Logger. But how can i archieve this with a DockerComposeContainer ? I mean i would like to log the output of each ambassadorContainer. At the moment some of my test which use DockerComposeContainers fail and i would like to see the logs of the container for error analysis.

I tried to implement this by https://github.com/arnzel/testcontainers-java/commit/56c48c748530d7c842930a61d6609a9cb34dd06c but it does not work. Does anyone see why ?

I'm afraid I've not had time to try and run this yet, but what's the problem you're seeing. Is it the problem described in #367?

hi the problem is that i see no logs as the following line in the test expected
waitingConsumer.waitUntil(frame -> frame.getType() == STDOUT && frame.getUtf8String().contains("seq=2"));

It has nothing to do with #367

Add withTailChildContainers(true) to DockerComposeContainer when creating it. Your example also won't override the MariaDb entrypoint (not sure if this is possible with compose), so your assert on the ping output won't work.
In your example you also don't attach the waiting consumer.

Okay thanks for looking on it. i will try it soon

@arnzel Any updates on this? I would like to close the issue if it works for you, or do you think we have to expand the docs in this area?

Hi, currently i have no time to work on it, so it still does not work.

Okay, I'll close this for now since the proposed solution should work. Please notify if this is still an issue for you after applying the proposed changes to your code.

authors: arnzel kiview rnorth

repo: testcontainers/testcontainers-java


text:
Add pgRouting container

This adds pgRouting container and junit test for it.

Hi @Sanych,
thanks a lot for your PR.
I wasn't aware that there are that many Postgres flavors. Since this seems to be a generic feature (use PostgreSQLContainer instance from JDBC driver with a custom image), I wonder if we can't find a generic solution for this problem.
I would be fine to merge this though and refactor this later, WDYT @rnorth?

I'm afraid I think this is probably going to be a little too niche to be a core module published by Testcontainers. I think I'd like to park this for now.
You could release this as a third party extension library. If there's sufficient demand to add this to Testcontainers core modules, we can revisit in the future.
I'm sorry to disappoint, and thanks for your effort in contributing.

authors: Sanych kiview rnorth


text:
No ports exposed from ryuk container.  Is this normal?

I'm using testcontainers withExposedPort and all i see is the ryuk container.   The ryuk container has no exposed ports either.  Is this normal?

I set DEBUG=testcontainers* and this is the output:
2022-08-18T22:51:51.208Z testcontainers DEBUG Found applicable Docker client strategy: UnixSocketStrategy
2022-08-18T22:51:51.242Z testcontainers DEBUG Testing Docker client strategy URI: unix:///var/run/docker.sock
2022-08-18T22:51:51.259Z testcontainers DEBUG No registry auth locator found for registry: "https://index.docker.io/v1/"
2022-08-18T22:51:51.267Z testcontainers INFO  Using Docker client strategy: UnixSocketStrategy, Docker host: localhost
2022-08-18T22:51:51.311Z testcontainers DEBUG Not pulling image as it already exists: ipfs/go-ipfs:v0.13.0
2022-08-18T22:51:51.313Z testcontainers DEBUG Creating new Reaper for session: 01b11bfacf2d8ae268ab882102dcaee2
2022-08-18T22:51:51.313Z testcontainers DEBUG Re-using cached auth for registry https://index.docker.io/v1/
2022-08-18T22:51:51.356Z testcontainers DEBUG Not pulling image as it already exists: testcontainers/ryuk:0.3.2
2022-08-18T22:51:51.357Z testcontainers INFO  Creating container for image: testcontainers/ryuk:0.3.2
2022-08-18T22:51:51.399Z testcontainers INFO  Starting container testcontainers/ryuk:0.3.2 with ID: c2909c641a8057ab40436e40e4543d9a5f751a9c6915199a9db9ee5d3d77c18c
2022-08-18T22:51:51.547Z testcontainers DEBUG Waiting for container to be ready: c2909c641a8057ab40436e40e4543d9a5f751a9c6915199a9db9ee5d3d77c18c
2022-08-18T22:51:51.547Z testcontainers DEBUG Waiting for log message "/.+ Started!/"
2022-08-18T22:51:51.595Z testcontainers:containers TRACE c2909c641a8057ab40436e40e4543d9a5f751a9c6915199a9db9ee5d3d77c18c: 2022/08/18 22:51:51 Pinging Docker...
2022-08-18T22:51:51.596Z testcontainers:containers TRACE c2909c641a8057ab40436e40e4543d9a5f751a9c6915199a9db9ee5d3d77c18c: 2022/08/18 22:51:51 Docker daemon is available!
2022-08-18T22:51:51.596Z testcontainers:containers TRACE c2909c641a8057ab40436e40e4543d9a5f751a9c6915199a9db9ee5d3d77c18c: 2022/08/18 22:51:51 Starting on port 8080...
2022-08-18T22:51:51.597Z testcontainers:containers TRACE c2909c641a8057ab40436e40e4543d9a5f751a9c6915199a9db9ee5d3d77c18c: 2022/08/18 22:51:51 Started!
2022-08-18T22:51:51.602Z testcontainers INFO  Container is ready

Hi @jsdevel, no that's not right, as you haven't filled out the issue template I can't tell you what could be your issue. Here's the docker ps output when I run a test:

@cristianrgreco perhaps this has something to do with it?
reads (main) $ docker run -it testcontainers/ryuk:0.3.2 sh
/ # /app
2022/08/20 07:36:15 Pinging Docker...
panic: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

goroutine 1 [running]:
main.main()
	/go/src/github.com/testcontainers/moby-ryuk/main.go:36 +0x457
/ # ls -al /var
total 48
drwxr-xr-x   11 root     root          4096 Apr 23  2020 .
drwxr-xr-x    1 root     root          4096 Aug 20 07:28 ..
drwxr-xr-x    4 root     root          4096 Apr 23  2020 cache
dr-xr-xr-x    2 root     root          4096 Apr 23  2020 empty
drwxr-xr-x    5 root     root          4096 Apr 23  2020 lib
drwxr-xr-x    2 root     root          4096 Apr 23  2020 local
drwxr-xr-x    3 root     root          4096 Apr 23  2020 lock
drwxr-xr-x    2 root     root          4096 Apr 23  2020 log
drwxr-xr-x    2 root     root          4096 Apr 23  2020 opt
lrwxrwxrwx    1 root     root             4 Apr 23  2020 run -> /run
drwxr-xr-x    3 root     root          4096 Apr 23  2020 spool
drwxrwxrwt    2 root     root          4096 Apr 23  2020 tmp
/ # ls -al /var/run
lrwxrwxrwx    1 root     root             4 Apr 23  2020 /var/run -> /run

If you have an issue you need help with then please fill out the issue template when you raise it.

turned out i had old containers that the latest docker daemon couldn't start, so it failed to create the default bridge network.  nuking all my containers fixed my issue.

authors: cristianrgreco jsdevel

repo: testcontainers/testcontainers-node

license: MIT


text:
td.replace(path) is relative to the setupTestFrameworkScriptFile not the path of the test

I will do some more digging to see what is going on but wanted to give you a heads up in case you know anything about this.
I was getting really weird behavior when trying to td.replace() in my test. Here is the situation. I am currently writing a test for model.js that needs to mock a dependency it has on query.js. The test is happening in __test__/model.test.js

Here is the setup of my test

I get the following error. jestSetup.js is my SetupTestFrameworkScriptFile:

As soon as I change the td.replace() path relative to that setup file things work

Here is my package.json for completeness
{
  "name": "arbiter-salesforce",
  "version": "0.1.1",
  "description": "A Salesforce ORM powered by jsforce",
  "main": "index.js",
  "tonicExample": "const arbiter = require('arbiter-salesforce')",
  "repository": {
    "type": "git",
    "url": "git://github.com/skbolton/Arbiter"
  },
  "scripts": {
    "test": "standard && jest",
    "fix": "standard --fix"
  },
  "jest": {
    "setupTestFrameworkScriptFile": "test/jestSetup.js"
  },
  "keywords": [],
  "author": "Stephen Bolton",
  "license": "ISC",
  "standard": {
    "env": "jest",
    "globals": [
      "td",
      "specify"
    ]
  },
  "devDependencies": {
    "jest": "^22.4.2",
    "rimraf": "^2.6.1",
    "standard": "^10.0.2",
    "testdouble": "^3.5.2",
    "testdouble-jest": "^1.0.1"
  },
  "dependencies": {
    "dot-prop": "^4.1.1",
    "jsforce": "^1.8.0",
    "superstruct": "^0.5.1",
    "type-detect": "^4.0.0"
  }
}

Sorry for the dump of images I just thought they show some things better

After a little more digging it is reproducible by changing the setupTestFrameworkScriptFile in the example code in this repo to being different from the folder the tests are in.

Ok, I think I have this fixed. This should work as of testdouble@3.6.0 and testdouble-jest@2.0.0

I just created a test project using only the npm versions of testdouble, quibble, and testdouble-jest (prior to release  I had to use links which made me a little wary), and everything seems to work ok.
Hopefuly the mechanism used to absolutify paths works in all cases

Sounds good. I did the same thing. Their source takes some serious time to digest and I got to that same module you are talking about. I will give the new versions a go. Thanks for tackling this!

authors: searls skbolton

repo: testdouble/testdouble-jest


text:
Distribute code as ES5 module

Currently, you are distributing code that has been bundled using webpack. You should distribute code as an es5 module. I would recommend you switch to babel to distribute your code.

I am curious if prop-types is being distributed in react-text-mask. Adding react as an external in the webpack configuration prevents react from being distributed with the rest of the bundle.
Prop-types is not listed as an external so it might be distributed with react-text-mask.
https://github.com/text-mask/text-mask/blob/master/react/webpack.buildReactIntegration.js#L41-L50
I think this also means if my application is importing prop-types, then it will probably be included twice in the bundle because webpack will not be able to dedupe it.

I cloned the repo and ran
npm install && npm run build
cd/react/dist/

The build script generated your distributed assets as well as a stats.json file. I used that file in the analyze tool

I can see that prop-types is being bundled with your code.

@Matt-Butler An ES5 module sound like the way to go to me.. what changes are required to make it so..
a PR would be awesome.

Since there are relative imports to shared code, we would want to publish that shared code as its own package. (maybe text-mask-core?)
After that shared package has been published, we would add that as a dependency for all of the other packages.
We could then use babel to compile the code as ES5 modules. Distributing it as ES5 is nice for consumers because then they no longer need to transpile your src code.
The main attribute in the package.json should be updated to point to the lib(ES5) entry point. This would be non-passive to some consumers. If a consumer is not using a tool like webpack, then they might still want the code as it is distributed today.

we would want to publish that shared code as its own package. (maybe text-mask-core?)

text-mask-core is already available as an npm module.

we would add that as a dependency for all of the other packages.

The angular2-text-mask and ember-text-mask components are already work this way.
I'm happy for the other components to be updated to work the same way, but I have limited time and I'm not very familiar with React, so I'm probably not the best person to code it.  If someone wants to submit a PR then we can go from there..

Cool, I didn't look to see what angular2-text-mask and ember-text-mask were doing. This update should be easier than I thought. If I have time this week, I'll send out a PR with these changes.
@lozjackson thank you!

@Matt-Butler Did you ever get around to putting up that PR?

authors: Matt-Butler erikshestopal lozjackson

repo: text-mask/text-mask

license: Unlicense


text:
Issue #456: Adding min max year to AutoCorrectedDatePipe

This change was requested a few times and my team needed it for a project we're working on. Essentially it works by blocking or allowing numbers to be entered based on a range specified in the pipe.
It checks the substring against the range. So if the range is 1950 to 2000 and the user enters 1, it will allow because 1 is between 1 and 2. If the user enters 18, the pipe will block the input as 18 is not between 19 and 20... and so on.
I've added as many tests as I could and also added documentation to the site and readme for the pipe.

@lozjackson Could you take a second to take a look at this? I'm not sure how to resolve the CI issues because it seems that it timed out.

@dclark27 try to close PR and then re-open it. This will trigger CI for new check.

hello, this still not working for me,
i am trying something like this
createAutoCorrectedDatePipe('mm dd yyyy', 1990, 2020)
and still able to enter values outside this range

@nassif7
autoCorrectedDatePipe = createAutoCorrectedDatePipe('yyyy/mm/dd',{minYear:1900})
this.maskedInputController = textMask.maskInput({
pipe: this.autoCorrectedDatePipe,
keepCharPositions : true
});
});
Try this. It works for me


text:
Update go-datastore to v0.6.0

Add context param where needed to make calls compatible with updated interfaces of ipfs/go-datatastore
Signed-off-by: vkost viktor.kostadinov@gmail.com

@vkost looks like a some failing test here, otherwise looks good!

Yes - that was failing on my end too.
The failing test is using a docker container to run mongodb, then I think
it runs queries against it. The container is not initializing in time and
the test fails. I am not sure what you would like me to do with it - should
I make it work using any mongo container that would run normally? Or
something else?
The thing is, I've had a lot of problems with containerized mongo recently
if I try to use the replica-set option. Since I don't care for replica-sets
locally, I resolved it by simply removing that part of the initialization
cmd. But I'm not sure if it's the right thing to do or not. Please advise.
Thank you
On Tue, Sep 20, 2022 at 1:48 PM Sander Pick @.***>
wrote:

@vkost https://github.com/vkost looks like a some failing test here,
otherwise looks good!
—
Reply to this email directly, view it on GitHub
https://github.com/textileio/go-ds-mongo/pull/4#issuecomment-1252700874,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWARFFXF5TF2NYQANFTPODV7H2FXANCNFSM6AAAAAAQOLICWU
.
You are receiving this because you were mentioned.Message ID:
@.***>

authors: sanderpick vkost

repo: textileio/go-ds-mongo


text:
ModuleNotFoundError: No module named 'bitters.modules.image_tokenizer'

Traceback (most recent call last):
  File "train_vae.py", line 4, in <module>
    from bitters.loader import ImageDataModule
  File "/BITTERS/bitters/loader.py", line 20, in <module>
    from bitters.modules.image_tokenizer.tokenizer import DiscreteImageTokenizer
ModuleNotFoundError: No module named 'bitters.modules.image_tokenizer'

I tried to train BITTERS model on docker environment and it returns this error,
It seems like there is no directory or file image_tokenizer in bitters/module, is it missing?
Thank you.

Hi, thank you for letting me know. Please clone newly updated version and let me know if the error persists.

Now it works fine! Thank you for fixing!

repo: tgisaturday/BITTERS


text:
inplace updates

What should I write in knex to issue update table set foo = foo + 1?
TIA

Oh, there's increment.

Uh, why increment/decrement is tied to integer values...

repo: tgriesser/knex


text:
Sqlite3 engine mismatch error

Environment
Knex version: 0.14.6
Database + version: sqlite3 4.0.0
OS: ubuntu (using c9.io)
Bug

Explain what kind of behaviour you are getting and how you think it should do

I am trying to update dependencies that are out of date, and I am getting an error now when my program runs with the latest knex and sqlite3

Error message

Error: Cannot find module '/home/ubuntu/workspace/node_modules/sqlite3/lib/binding/node-v46-linux-x64/node_sqlite3.node'
I am getting this error because it appears I instead have /node_modules/sqlite3/lib/binding/node-v57-linux-x64. Clearly there's some kind of engine level mismatch I'm not sure how to resolve.

Found the issue, it seems to be a problem with c9. It's running different versions of node in different terminal tabs. I'll figure that one out.


text:
methods to serialize and deserialize from base 64 encoded string

Please consider the pull request for the methods  ToBase64 and FromBase64.  I have provided a test case.  I currently use the feature with a web service that stores the roaring bitmaps in a redis key value store.

@tvmaly  Code looks good. Merging.
Do you have a simple code sample (for documentation purposes) of the use of roaring in redis?

@tvmaly  I will be adding your name to the list of contributors (in the README).

Professor, for a redis sample,  assuming usage of the library "github.com/garyburd/redigo/redis"
and a connection to redis in variable conn, and the key somekey where the string is stored it would be as follows:
roaring_string, err := redis.String(conn.Do("GET", somekey))
rb := roaring.NewRoaringBitmap()
		if roaring_string != "" {
			_, err = rb.FromBase64(roaring_string)
			if err != nil {
				log.Printf("Error decoding key %s base64 to roaring: %s\n", somekey, err)
				return err
			}
		}

@tvmaly
Excellent... do you have a code sample to store an existing roaring object in redis?

@tvmaly  The goal would be to add to the documentation so that other users who are interested in using redis know right away how to call your contributed methods. (I find that people really like concrete code examples.)

authors: lemire tvmaly

repo: tgruben/roaring


text:
Add Telegram music scrobbling support

Now telegram enable to listen music, can you support this new platform to scrobble?
Thank you

Please continue discussion at original request here #263

repo: tgwizard/sls


text:
Username collisions

Should be using steam ID as primary key to avoid collisions. Can be read from the players page.

Solved in branch "refactor"


text:
Add re package to OptionsData

Setting df=True throws an error:

options_data.get_options_symbols(symbol="QQQ", df=True)
Traceback (most recent call last):
File "", line 1, in
File "/opt/homebrew/lib/python3.12/site-packages/uvatradier/options_data.py", line 222, in get_options_symbols
option_df = symbol_list_to_df(option_list);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/lib/python3.12/site-packages/uvatradier/options_data.py", line 191, in symbol_list_to_df
match = re.match(r'([A-Z]+)(\d{6})([CP])(\d+)', option)
^^
NameError: name 're' is not defined. Did you forget to import 're'?

Added import statements for datetime and re - issue fixed


text:
Add compatibility for sort without ext labels

In https://github.com/thanos-io/thanos/pull/6299 we changed the comparison algorithm in the store proxy to ignore store-specific external labels. This causes problems during long rollouts because old stores and new stores will sort data differently, leading to incorrectly deduplicated results.
This commit adds a new flag to the store info message to indicate whether the store sorts data with or without external labels. The querier uses this flag to decide whether to resort the store response set before starting a merge.

[ ] I added CHANGELOG entry for this change.
[x] Change is not relevant to the end user.

Changes

Resort response set data if stores do not support sorting without external labels.

Verification

This was tested in a staging environment by running a querier from the branch against stores with an old version.
Added a unit test for the sorting functionality.

We will try to solve this problem differently. It seems hard to fix it with compatibility flags.

repo: thanos-io/thanos


text:
Multilanguage not working. How to add or override language ?

Laravel Version: 5.6.*
Voyager Version: 1.1.1
PHP Version:7.1.3
Database Driver & Version:

Description:
Multilanguage not working  . How to add new or override language ?
I try config files.
config/voyager.php
'multilingual' => [
        /*
         * Set whether or not the multilingual is supported by the BREAD input.
         */
        'enabled' => true,

        /*
         * Select default language
         */
        'default' => 'vi',

        /*
         * Select languages that are supported.
         */
        'locales' => [
            'vi',
            //'pt',
        ],
    ],

and config/app.php
return [
    ...
    'locale' => 'vi',
    ....
];

I created folder lang/vi . see image.
http://www.upsieutoc.com/image/45hwiN
Steps To Reproduce:
Install Laravel with Voyager
Change multilingual in config/voyager.php
Change locales in config/app.php

This is described in the Laravel docs

Thanks for answer @emptynick ,
But Not working. I can not override it . Maybe  Voyager not accept override language or it error.

First of all, if you get an error, it's immensely helpful to provide the actual error message and stacktrace.
For your issue, it's likely because you're only adding the translations to your app.  For Voyager to be able to find them, you need to add them to the Voyager namespace (resources/lang/vendor/voyager/vi/)

Thanks a lot.
I just want to use Vietnamese.
pls see images : http://www.upsieutoc.com/image/48w8XA
I have read the voyager's document follow the instructions but it only accepts english language.
Thanks.

@mrtieutien90,
Nếu bạn chỉ dùng ngôn ngữ Vietnamese (VI), bạn copy vào đường dẫn sau là xong.
Root: /vendor/tcg/voyager/publishable/lang/vi
If you only use the Vietnamese language (VI), you just copy folder VI into the following path is finished:
Root: /vendor/tcg/voyager/publishable/lang/vi
It work fine!!!

Thankyou @hungxinh.
This is always add to the packet of voyager. I follow the instructions of @ fletch3555 and @emptynick but not working.

Thankyou @hungxinh.
This is always add to the packet of voyager. I follow the instructions of @ fletch3555 and @emptynick but not working.

You need clear cache.
php artisan config:cache

This bug stills happening on year 2020 (version 1.4), clearing the cache as @quocchienit explained makes it work. I will edit de documentation so everybody can avoid this confusion.

authors: emptynick fletch3555 hungxinh josepcrespo mrtieutien90 quocchienit

repo: the-control-group/voyager


text:
Fixing installation problem through npm

fix #9

Coverage remained the same at 97.884% when pulling b782512bb5b32f43c163e83d9cccecd146dbdc3f on willgm:master into e17e60e43baf4aecaf509b329d334fc5ec1ee669 on the-darc:master.

authors: coveralls willgm

repo: the-darc/br-validations


text:
Add a reminder feature

Desp: The feature must be such that the user must be able to set events which directly get updated in the pc's calender.
Eg: If the user types in "Farewell Party on 23/7/18 (some date format) at 6pm" it needs to directly upatde as an event on the calender

Can I work on this issue @the-ethan-hunt ?

I am working on adding event on the Google Calendar, @CodHeK @the-ethan-hunt, and so it will also remind the user on that particular day.

Alright @hmangukia .

Please review the PR and let me know if any changes need to be made 😄

@the-ethan-hunt Since PR #122 is merged, we can close this now.

authors: CodHeK hmangukia sara-02 the-ethan-hunt


text:
item with same name

Hi,
I noticed that there are objects with the same name, but which are different, such as "Key Sigil" materials or "Prized Isshin Blade" weapons.
How can I do to retrieve information from different objects ?

hmm I'm not sure how to fix this

Can now search for data with the same name by adding a number. Indexed at 0. Must set matchAliases to true.
Example: genshindb.achievements('Let the wind lead 1', { matchAliases: true })
v4.3.1

authors: Sairei theBowja

repo: theBowja/genshin-db


text:
How to use https for featured image?

I have set this up in content/_index.md:
cascade:
  featured_image: 'image/welcome.jpg'

I get that message in firefox:
Parts of this page are not secure (as images)
And when I look at the html source code of the index page I see:
<header class="cover bg-top" style="background-image: url('http://www.-------.fr/image/welcome.jpg');">

Would it be possible to get those links in https?

Is the baseURL in your site configuration an http URI, by any chance?

You are right! My bad...

authors: jhenstridge pietrodito

repo: theNewDynamic/gohugo-theme-ananke


text:
how to insert json object in statement?

"geoip": {
"ip": "120.27.47.144",
"city_name": "Beijing"
}
how to insert 'ip' or 'city_name' in statement?

I believe something like this should work for you:
statement => [ "INSERT INTO log (ip, city_name) VALUES(?, ?, ?)", "[geoip][ip]", "[geoip][ip]" ]

got it, thanks

authors: jiekechoo theangryangel

repo: theangryangel/logstash-output-jdbc


text:
Improve Consistency in Docs/Descriptions

Review documentation & improve consistency, review query examples and add some additional ones.
Also ensure the descriptions for tables/columns is more consistent.

These are actually fairly consistent & seem fine - closing.

repo: theapsgroup/steampipe-plugin-gitlab


text:
issues using ARIA

There seems to be a problem with ARIA when using bootstrap.native in v3 and v4.
This example works on jQuery and Bootstrap v3: https://codepen.io/Sp00ky/pen/aZJWLa
When using bootstrap.native, it stops working (check the upper chevron): https://codepen.io/1100101/pen/RjXqeg

Thanks for reporting, please test latest master.

@tobwen please test latest master.

https://codepen.io/1100101/pen/RjXqeg
Updated & Working. Thanks!

authors: thednp tobwen


text:
Following your matrix decompose trail

Hey,
I've been trawling through various npm packages in the hope of finding a way to decompose a CSS 3d transform matrix back to the transform function values (e.g. rotateX, scaleZ etc), and I keep seeing your posts popping up :)
Did you end up using mat4-decompose or morf.js in the end?
Thanks!
Sebastian

None, I rely entirely on DOMMatrix() API, for my use case I don't really need it.

OK, thanks for letting me know!

authors: sebastianwebb thednp


text:
🛑 dynamiteevents.co.uk/ is down

In 70e75d0, dynamiteevents.co.uk/ (https://dynamiteevents.co.uk/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: dynamiteevents.co.uk/ is back up in 2d751a8.

repo: thegreatgulper/checksitestatus


text:
fix init.py in templates

Reported by a user:
FILE_PATH = file
should be in the init.py files

https://github.com/theislab/sfaira/commit/63c1b06b8350c591e4884a124d48336db6c245d2

repo: theislab/sfaira


text:
[SHIPA-2139] enforce unit test coverage

Description
Fixes # 2139

adds Go script to assert unit test coverage is at or above current levels
adds bypass mechanism
script has optional update flag, which raises (never lowers) unit test coverage limits to current per-package

Do we like unit_test_coverage/main.go? Move it into a separate repo?
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Chore (documentation addition or typo, file relocation)

Testing

[x] New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
[x] This change requires no testing (i.e. documentation update)

Documentation

[x] All added public packages, funcs, and types have been documented with doc comments
[x] I have commented my code, particularly in hard-to-understand areas

Final Checklist:

[x] I followed standard GitHub flow guidelines
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings

@DavisFrench I have the same question. Maybe it would be more idiomatic to just sed package coverages and compare to some file maintained in the .github directory?

@DavisFrench Forget everything I said. I moved the unit-test-coverage script to a separate repo. This PR is just the CI steps now.

repo: theketchio/ketch


text:
Add option to append random numbers to nick on the config file and a few more ideas

Hello. I'd like to know if it's possible to somehow append randow numbers to a nick, on the config file.
on config.js:
defaults: {
...
// Nick
//
// @type     string
// @default  "lounge-user"
//
nick: "lounge-user",

In here, adding an option like "nick_?" where ? corresponds to at least 3 random numbers.

If a network dont have The Lounge set in webirc mode on their IRCd conf file, if two users  connects at the same time, one of them will be unable to connect due to nick collision
         //
         // Username
         //
         // @type     string
         // @default  "lounge-user"
         //
         username: "lounge-user",

If blank and if "useHexIp: false," & " webirc: null," set the same as nick, otherwise if "useHexIp: true," that will send the hexed ip of the user.
          //
          // Real Name
          //
          // @type     string
          // @default  "The Lounge User"
          //
          realname: "The Lounge User",

          //
          // Channels
          // This is a comma-separated list.
          //
          // @type     string
          // @default  "#thelounge"
          //
          join: "#thelounge"
  },

I've searched but didn't found the PR/Issue with something related to this one:
If private server is restarted/dies, all "log" are lost, even with the option to save logs to disk enabled.
That's one thing that could be improved.
The overall of The Lounge is very good and it fits very well even on smartphones.
Keep up the good work.

Just wondering, what would this accomplish? What's the use case?

at least the append random numbers to nick is due to the fact if two users of same thelounge instance tries to connect with the same nick, the second user will not be able to connect, as the nick is already in use.

Lounge already handles that case on its own. And it does so by appending random numbers.

my idea was to set it with numbers since the first user connecting.. even if was the 1st user connecting, would be 'lounge-user-number', in example. and also for each "?" append 2 numbers, so if i choose "lounge-user-??" there will be 4 numbers appended..
but i see it handles it pretty well, and maybe the nick collision i've saw was something weird..

and one more.. if i use the public server, even with lockNetwork: true, the network and server appears there, but i know it cant be changed..
is there anyway to hide Network Settings and leave just User Preferences?

@TheMythPT, look at the displayNetwork option, I believe that's what you are looking for :)
Closing this feature request as it is already implemented as @xPaw mentioned. If you notice this again, that would be a bug rather than a feature request, and we can reopen this ticket. Just make sure to get as much info as you can so we can reproduce and/or understand better where the issue comes from.

authors: TheMythPT astorije xPaw

repo: thelounge/lounge


text:
Version Bump, Font Awesome Updated

This commit updates font awesome, select2, and bumps the version.

I realise the reason why select2 was removed from dependency. I am submitting another PR with similar change.


text:
Génération d'une copie PDF à partir d'images

Actuellement nous recevons beaucoup de copies sous la forme de photos que nos élèves / étudiants nous envoient avec leur smartphone.
Peut-être PDF4Teachers inclura un jour cette fonctionnalité (besoin qui n'existait pas avant le COVID-19 !), mais en attendant, je propose une solution très efficace pour générer des PDF depuis des dossiers contenant des photos des différentes pages des copies : ceci requiert l'installation de ImageMagick + Ghostscript.
Linux : à adapter en fonction de votre packager :
> sudo apt-get install imagemagick
Je crois que Ghostscript est installé par défaut.
OSX : à installer à travers brew
> brew install imagemagick
> brew install ghostscript
Windows 64 bits , télécharger et installer avec les options par défaut :
https://github.com/ArtifexSoftware/ghostpdl-downloads/releases/download/gs952/gs952w64.exe
https://sourceforge.net/projects/imagemagick/files/im7-exes/ImageMagick-7.0.7-25-Q8-x64-static.exe/download
ImageMagick s'utilise en ligne de commande:
windows : ouvrir un terminal de commande (cmd), aller dans le dossier des images avec la commande cd, puis par exemple :
> magick *.jpg -resize 2000000@> test.pdf
Ceci a pour effet de génèrer un PDF nommé test.pdf, à partir de toutes les images .jpg contenues dans le dossier, après avoir réduit les images à la taille 2Mpixels (si elles sont plus grandes). Elles sont insérées dans l’ordre alphabétique de leur nom.
On peut remplacer *.jpg par *.pdf si on a reçu des scan page par page au format PDF mais ImageMagick n'étant pas conçu à la base pour prendre du PDF en entrée, ceci a tendance à générer un PDF visuellement un peu dégradé.
Linux et OSX : ouvrir un terminal de commande, aller dans le dossier des images avec la commande cd, puis par exemple :
> convert *.jpg -resize 2000000@> test.pdf
Je joins ici un script que j'ai écrit pour traiter un lot de sous dossiers, en fabriquant un pdf du nom de chaque sous-dossier. Il faut prendre soin de nommer intelligemment les sous-dossiers d’images (par exemple prénom.nom) et après c’est du velours.
Exemple d’arborescence de dossiers :
Dossier_DS_du groupe_G1
-> Truc.Machin (sous-dossier qui contient les photos de la copie de Truc Machin)
-> Choupinette.Bidule  (sous-dossier qui contient les photos de la copie de Choupinette Bidule)
-> ….
-> ….
Sous Windows, je propose de copier ce script dans le dossier C:\Windows, pour qu'il soit dans le PATH(chemin de recherche des exécutables). Sous OSX et Linux, pour qu'il soit dans le PATH, placez le dans /usr/local/bin par exemple. Personnellement, je préfère me créer dans mon dossier perso un dossier scripts et modifier mon PATH en éditant le fichier caché .bash_profile, en y ajoutant la ligne:
export PATH=$PATH:~/scripts
Bonne génération automatisée de PDFs !
script windows : img2pdf.txt, à renommer en img2pdf.bat :
img2pdf_lot.txt
script OSX uniquement pour fusionner des pages PDF en un seul document PDF :
mergePDF.txt

Je confirme que ce sera une fonctionnalité fort intéressante, de pouvoir sélectionner indifféremment un PDF ou une image (voire un ODT/DOC) qui serait converti immédiatement en PDF pour l'intégrer dans l'appli.
Merci en tout cas pour cette application dont je fais beaucoup de publicité sur Twitter !


text:
🛑 My Shortlink Website is down

In edaaffe, My Shortlink Website ($REALZZY_SHORTLINK) was down:

HTTP code: 0
Response time: 0 ms

Resolved: My Shortlink Website is back up in 7a7fd02.


text:
Timesheet - 14/04/2021 - TRUYEN HOANG

Task 1

Refactor to modulize backend service to help provision multiple environment in the future
Implement aws application loadbalancer to share between backend/other services in same cluster to saving cost
Route based on host and path
Fix issue with backend yesterday

Proof of Work

https://github.com/thenewboston-developers/iac/commit/4a5cc48a66d9448238d4ffa1ab2a7b9ad49d95d5

Time Spent
2.5 hours

Total Time Spent
2.5 hours
Account Number
5d52e2bb5acf296a120dc2a16efd46f6803c9a4f55cda44d6b1b6dd42d9f1a6d

Approved

Approved

authors: itsnikhil manishram truyenhv


text:
Timesheet - 22/05/2021 - Dmitry Mugtasimov

Task 1
Working on https://github.com/thenewboston-developers/Website/issues/1752
Proof of Work

See https://docs.google.com/document/d/1_6OCmqL0OK5UiWJROe-EbRYAQa9s-iuIIQOdv_Vd5Bs/edit# comments

Time Spent
1 hours

Task 2
Work on task: https://github.com/thenewboston-developers/thenewboston-node/issues/130
Proof of Work

https://github.com/thenewboston-developers/thenewboston-node/pull/137
https://github.com/thenewboston-developers/thenewboston-node/pull/138
https://github.com/thenewboston-developers/thenewboston-node/pull/139
https://github.com/thenewboston-developers/thenewboston-node/pull/141
https://github.com/thenewboston-developers/thenewboston-node/pull/141
https://github.com/thenewboston-developers/thenewboston-node/pull/142

Time Spent
X hours

Total Time Spent
X hours
Account Number
757d598308bf1e2943bd1a9fc34ae7b8951ca864d64228b59e62614b27ddefc4

@dmugtasimov, any update on this timesheet?

authors: dmugtasimov tspearing


text:
Updated Docs for Primary Validator - Accounts #962 Fix

Fixes #962.
@buckyroberts, for the URL params (/accounts/<account_number>/balance for example) I think we are not adding them into tables, correct? If we are, I'll add a table, but as far as I could see, we only use tables for body params. If I am wrong, just let me know, I'll add the tables

@shahraizali I added the pagination query params, but I think we should make a difference between the query params & URL parameters, or I should remove the url/path parameters?
To be more specific, I am talking about differentiating /accounts/<account_number>/balance and /accounts?limit=50&offset=50
Right now both are called "URL parameter".
maybe account_number could stay "URL parameter" and the query params should be "Query parameter"? Let me know what you think.

How about renaming the one that is part of url to 'Path parameters'
SOURCE: https://idratherbewriting.com/learnapidoc/docapis_doc_parameters.html
as far as the name URL parameter and Query Parameter I also looked it up a couple of days ago when I saw your PR. In my finding, they are used interchangeably and are arguably the same thing, In my opinion, that's fine.

Agreed. I changed them to PATH.

repo: thenewboston-developers/Website


text:
Alternative way to preload async chunks

Hey there! Not really an issue, I just didn't know how to share it with you. I wrote a blog post around an alternative way to preload async chunks (compared to the one used in this repo where you concatenate the chunk string) and I think you might found it helpful! https://mmazzarolo.com/blog/2024-08-13-async-chunk-preloading-on-load/
By the way, big fan of your work! I implemented most of the things mentioned here a few times in my previous jobs, and I always wanted to create a project similar to the one shared in this repo... but you surely did it in a nicer way than I would have done it :p keep up the great work!

@mmazzarolo
Thanks! I'll take a look at that.
I'm currently about to push another big optimization I've been working on, you can take a look at that here if you are interested:
https://github.com/theninthsky/client-side-rendering/tree/dynamic-source-inlining
https://dynamic-source-inlining.client-side-rendering.pages.dev/

authors: mmazzarolo theninthsky

repo: theninthsky/client-side-rendering


text:
inherit $HOME environment variable for test

This is a simple way of ensuring $HOME is available for uv to detect .netrc.
Fixes #103

Thanks, didn’t know about RunEnvironmentInfo.

authors: chrisirhc mark-thm


text:
Writing to CSV results in partially corrupted output

Currently running into an issue where writing data to CSVs in production is resulting in corrupted data on the second row, across multiple servers. The first row of data is correct, and the third row of data -Nth row of data is correct, but the second row of data always contains corrupted data.
When I open the file in Sublime Text I get this (sorry github doesn't like Dropbox screenshot embedding):
https://www.dropbox.com/s/ud0tbhyc7x5orkk/Screenshot 2016-01-14 11.53.54.png?dl=0
And in VIM it just becomes a slew of this:
@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@^@

Some character is being inserted that VIM and sublime interpret, TextEdit on Mac just strips the character. Trying to think of what else you might need, but can't think of anything else.
PHP: 5.5.30
Platform: CentOS 6.5
Package: 7.1.2

Have you tried the latest version ? Since 2 new versions where released since 7.1.2

So an update here, I found out the code that was written to write the CSV data to file was not using an SplFileObject, but an SplTempFileObject and then writing this data to file in another manner. To get the contents of the Writer, the code was triggering it's __toString method which uses ob_start and ob_get_clean. The second we moved the code away from using the output buffer, our corruption issue was resolved.

great to hear about this :+1:  I'll close this issue since it is not related to the library in itself

authors: hskrasek nyamsprod

repo: thephpleague/csv


text:
League\Csv\ stream. php may have problems

Bug Report
public function seek($position)
    {
        if ($position < 0) {
            throw new Exception(sprintf('%s() can\'t seek stream to negative line %d', __METHOD__, $position));
        }

        $this->rewind();
        while ($this->key() !== $position && $this->valid()) {
            $this->current();
            $this->next();
        }

        $this->offset--;
        $this->current();
    }

If  $opsition is equal to 0, then $this->offset is equal to minus 1

if $position is equal to 0 then your code $this->offset is equal at 1 in the loop and end up being equal to 0 after the loop 😉

If $position is equal to 0, then it won't enter the loop, so $offset-- after $this->offset is -1.

why won't it enter the loop ???

$this->rewind() result return $this->offset = 0, so $this->key() === $position,so won't enter the loop.😝

yes but we don't really care because the current() method does not use the offset property which will be incremented to 0 when next() is used. I'll look into it after work but yeah there should not be any issue in how the Stream class is used in the package. Since the class is marked as @internal  we are safe but I can look into it to see if some use cases may end up in error. If you could provide such example It would be easier to investigate/fix but I don't see an instance where this could come up 🤔

seems to be easy to fix... I'm in the process of releasing 9.2.0... I'll create a small branch with the fix and add it to the release. The way the Stream class is used in the package is not impacted by this bug but fixing it is still possible and will be addressed. If you prefer to submit a PR you are welcomed to do it also in the meantime 😉

Yes, this problem has no impact on the use of the basic, but if the user use key() may cause a little ambiguity, so, I submitted a PR , 😝

authors: CoderChenHZ nyamsprod


text:
AbstractProvider contains logging

Hi :)
While setting up an integration I noticed that you are logging the parsed response in AbstractProvider.php line 537, see Log::info($response);. In my opinion this could be a security concern, as access tokens can be logged in unsecure log files, without the developer knowing.
VER. 2.6.0
 public function getAccessToken($grant, array $options = [])
    {
        $grant = $this->verifyGrant($grant);

        $params = [
            'client_id'     => $this->clientId,
            'client_secret' => $this->clientSecret,
            'redirect_uri'  => $this->redirectUri,
        ];
        $params   = $grant->prepareRequestParameters($params, $options);
        $request  = $this->getAccessTokenRequest($params);
        $response = $this->getParsedResponse($request);
        Log::info($response);
        if (false === is_array($response)) {
            throw new UnexpectedValueException(
                'Invalid response received from Authorization Server. Expected JSON.'
            );
        }
        $prepared = $this->prepareAccessTokenResponse($response);
        $token    = $this->createAccessToken($prepared, $grant);

        return $token;
    }

I'm not sure where that Log::info($response) line is coming from. It's not in our code. We've never used a static logging library like this.
https://github.com/thephpleague/oauth2-client/blob/2334c249907190c132364f5dae0287ab8666aa19/src/Provider/AbstractProvider.php#L517-L547

authors: mikkellindblom ramsey


text:
PCI Compliance

Stripe has this to say about PCI compliance with their product:
https://support.stripe.com/questions/do-i-need-to-be-pci-compliant-what-do-i-have-to-do
So, if I use OmniPay, does it utilize stripe.js? If not, then I may have to do quite a bit of PCI compliance changes and quarterly PCI auditing to use OmniPay, wouldn't I?

It does, see https://github.com/thephpleague/omnipay-stripe#stripejs

authors: barryvdh volomike

repo: thephpleague/omnipay


text:
Build failed, Unknown target name ''

I know, I'm trying to do this on a Sun T4-1 in Solaris 11.4 SPARC.  But things seemed to be going along well and I even got an mrustc executable.  But during the build it goes:
root@hemlock:~/mrustc/mrustc# gmake RUSTC_TARGET=x86-windows-msvc -f minicargo.mk
gmake -f Makefile all
gmake[1]: Entering directory '/export/home/michele/mrustc/mrustc'
gmake[1]: Nothing to be done for 'all'.
gmake[1]: Leaving directory '/export/home/michele/mrustc/mrustc'
gmake -C tools/minicargo/
gmake[1]: Entering directory '/export/home/michele/mrustc/mrustc/tools/minicargo'
gmake[1]: Nothing to be done for 'all'.
gmake[1]: Leaving directory '/export/home/michele/mrustc/mrustc/tools/minicargo'
tools/bin/minicargo rustc-1.19.0-src/src/libstd --script-overrides script-overrides/stable-1.19.0-linux/ --output-dir output/
BUILDING core from core v0.0.0 with features []
> bin/mrustc rustc-1.19.0-src/src/libcore/lib.rs --crate-name core --crate-type rlib -g --cfg debug_assertions -O -o output/libcore.hir -L output
Unknown target name ''
BUILD FAILED
gmake: *** [minicargo.mk:64: output/libstd.hir] Error 1
root@hemlock:~/mrustc/mrustc#

The target supplied in the command line is one listed in src/trans/target.cpp.  Who's not picking up the target?

"It is easy to cross-compile from x86_64 Linux to SPARC Solaris. You can do this by running ./x.py --target sparcv9-sun-solaris inside a rust checkout on the x86_64 Linux (virtual) machine. "
Wow, that would be awesome if that worked.  Unfortuately, it didn't for me.  I gave that ocmmand and it took off downloading and compiling a bunch of stuff before stopping like this:
michele@michele-VirtualBox:~/rust$ ./x.py --target sparcv9-sun-solaris
...
   Compiling bootstrap v0.0.0 (/home/michele/rust/src/bootstrap)
    Finished dev [unoptimized] target(s) in 2m 15s
Usage: x.py <subcommand> [options] [<paths>...]

Subcommands:
    build       Compile either the compiler or libraries
    check       Compile either the compiler or libraries, using cargo check
    clippy      Run clippy (uses rustup/cargo-installed clippy binary)
    fix         Run cargo fix
    fmt         Run rustfmt
    test        Build and run some test suites
    bench       Build and run some benchmarks
    doc         Build documentation
    clean       Clean out build directories
    dist        Build distribution artifacts
    install     Install distribution artifacts

To learn more about a subcommand, run `./x.py <subcommand> -h`

failed to run: /home/michele/rust/build/bootstrap/debug/bootstrap --target sparcv9-sun-solaris
Build completed unsuccessfully in 0:11:48

What am I doing wrong?

I could probably walk you through the procedure, but I wouldn't be the best at it (and this isn't the correct forum).
If you haven't managed to solve this on your own yet, I suggest asking on the rust discord or on the forums.

repo: thepowersgang/mrustc


text:
feat(SDK): Windows Mixed Reality Support

Windows MIxed Reality Support for VRTK (Issue: https://github.com/thestonefox/VRTK/issues/1565):

Add Mixed Reality Headset and Controllers
Add Mixed Reality to every example scene
Add controller visualization (with GLTF and new Newtonsoft.JSON.dll)
Update with newest MRTK scripts and plugins
Include Touchpad Two in Controller Events
Add highlighting and tooltips for Mixed Reality Controller
Add .NET scripting backend support
Bug fixing

Known issues:

Haptic feedback is irregular (and does not work in Editor)
Area teleport has an increasing offset in Example Scene 12 (https://github.com/Innoactive/IA-unity-VR-toolkit-VRTK/issues/19)
No interaction with cube in Example Scene 35 (https://github.com/Innoactive/IA-unity-VR-toolkit-VRTK/issues/21)
No falling and height offset in Example Scene 37 (https://github.com/Innoactive/IA-unity-VR-toolkit-VRTK/issues/20)

Thanks to @DDReaper @thestonefox @bddckr @if1live @vladkol

I think you may need to rebase in the latest version of the 3.3.0-alpha branch into your branch, it looks like there's a number of things in this commit that may have already been done.

Thanks, just double checked. It's already rebased to the latest 3.3.0-alpha (e9cbee0f512f1a32703e04946cda345ff004187f) and there are no conflicts.

I played around with it the last 8 hours, trying to make it work, without much success. I used this pull as well as the 3.3.0-alpha (pure).
At both versions I was sometimes stuck in the ground and the controllers mostly weren't there at all.
Bruteforce restarting the game (in editor) made them appear some times but only when I was stuck in the ground, and then the controllers would be above the ground. Sometimes the handedness in WindowsMR_TrackedObject wasn't set in the controllers.

How do I download the version with WMR support?

@skyteks the 3.3.0 alpha (pure) does not have WMR included, only SteamVR Mixed Reality support.
Being stuck in the ground is caused by Stationary Tracking instead of Room Scale Tracking. Stationary puts you at (0, 0, 0), so in the ground. The camera has a script where you can toggle if you want Room Scale to be forced which is sometimes necessary. You also need Room Scale Setup in the Mixed Reality Portal for that.
Room Scale is for normal applications while Stationary is for something like video players.
About the controllers not being shown. I sometimes had this issue too and I feel like it's an Editor problem. Closing (and opening) the Mixed Reality Portal usually helped. In a built project it works fine.
Before I opened the pull request I went through all scenes and double checked if the handedness is set, quite annoying...I just realized switching from Standalone to UWP resets the Handedness to unknown (as well as some other things), at least in the current scene. This is caused by code that only works with UWP.
@265lutab you can get this branch for testing https://github.com/Innoactive/IA-unity-VR-toolkit-VRTK/tree/feature/windows-mixed-reality-rebased

@tomwim Thank you. What version of unity does this support and is it meant to not have the holotoolkit also imported to the project? I'm getting a number of errors saying thinks like:
Assets/VRTK/Source/SDK/WindowsMR/Additional/GLTF/Scripts/Schema/Sampler.cs(99,14): error CS0101: The namespace GLTF' already contains a definition for MagFilterMode'

@265lutab I developed with MRTP-5 since that is the latest version recommended by Microsoft. It should work with 2017.2 as well but not guaranteed. Follow issue https://github.com/thestonefox/VRTK/issues/1565 for more information.
VRTK is VRTK, whatever you add is your choice but this works as it is.

I'm currently using MRTP-5

Just FYI, 2017.2.1 includes all the MRTP fixes, as does 2017.3RC2
These are now the recommended builds for Mixed Reality :D

Is it recommended to include SteamVR or remove it when using VRTK for Mixed Reality?

If you want to use Standalone with Steam VR then use Steam VR, if you want to use UWP then use this branch.

Any indications when this will be merged in to the Alpha branch? @thestonefox / @tomwim
Anything I can do to help that along?

I need to go through it and test the PR, then go over the PR code and make sure it's all good in the hood.
I've got a VR laptop now, so i just need the time to do it, with Christmas fast approaching I'm not sure it will be this side of Christmas (maybe even after the New Year).

I did a load of testing on the previous branch and did run this through when it showed up.
Will retest on 2017.3 (now that it's out and has all the MR fixes) and update

poo, I made a conflict. Example scene 25 is in conflict now :(

Ok quick look at the repo and the first thing I've noticed is all of the windows SDK scripts have been included. These shouldn't be included with VRTK, it's adding a large bulk of windows specific code to the repo which people may not ever use.
Shouldn't this stuff be downloaded separately and have instructions included of how to download and integrate that?

There shouldn't be any windows related code, as it's built in to windows itself, there isn't even an SDK.
There is the gLTF importer, but that is just a stop gap as Unity doesn't have an importer itself yet. (MRTK does the same)

@DDReaper this pull request contains a directory called Source/SDK/WindowsMR/Additional
That additional folder is full of Windows MR extensions that shouldn't be included in VRTK. These extensions should be downloaded separately the same way that SteamVR is downloaded separately.

It's as @DDReaper says, that stuff is from MRTK and redone to work for VRTK. I agree with you though, that it is unnecessary for people that do not want Windows MR. But the whole Controller part is not as nicely done as with Oculus and Steam and there is not a supported package/source for Windows MR.
But I could rework it and try to make a second Repo where the Additional stuff can be downloaded and integrated. That won't happen before new year though.

The stuff in the additional folder is only available as source and isn't downloadable atm. The hope is unity will add GLTF support in the future and this won't be needed.
Everything in that folder is either gLTF code or supporting WMR classes for VRTK AFAIK.
@tomwim can you confirm?

Isn't all the gLTF stuff purely to display controller models though?
To me, I feel this Additional folder is massive overkill. If anything it should be a seaprate package like the way Oculus Avatar is, then in VRTK it wouldn't support displaying controller models unless you have that separate package (that's how Oculus SDK does it).

OK, fair enough. If we have a prescient in another SDK, then that makes sense. However the package will need to be made available somehow, as it's not provided by anyone currently.
I noticed @tomwim S comment saying he may look in to that in the new year. Hopefully it can be done before the 3.3 release

I'm going to try and take a look at making a separate repo for it over the Christmas period. It would probably be better being owned by MRTK though, but if I can do a lot of the grunt work then maybe it can just be copied straight over.

It's not really an MRTK thing either.  The project is also separate there.
It's been "sort of" provided by MS until Unity get their act together.
But having it as a "pluginable" project would be hugely beneficial.  Just the gLFT importer/renderer of course, there are other scripts in that folder that @tomwim created for VRTK boilerplate

It's not really an MRTK thing either.  The project is also separate there.
It's been "sort of" provided by MS until Unity get their act together.
But having it as a "pluginable" project would be hugely beneficial.  Just the gLFT importer/renderer of course, there are other scripts in that folder that @tomwim created for VRTK boilerplate.

Ok cool, I'll try get the model stuff as a separate repo, then pick out the bits that are core to vrtk

Righteo, if you want me to help / test, just shout :D

Any update on this PR getting merged?  Anything I can do to help? @tomwim @thestonefox

@DDReaper this PR probably won't get merged, but will be used to form a new PR.
I'm about a month behind on the stuff I want to get finished on VRTK for 3.3.0 (especially since I've rebuilt all the example scenes!). Hopefully soon we'll have WMR support :)

Like I said, shout if you want me to pitch in @thestonefox
Kronos updated their GLTF lib already since this PR anyway and the MRTK have done so as well.

@thestonefox sorry for the huge delay... I had no time anymore to do anything on my work PC but finally got a proper graphics card at home. I would rework everything this weekend or did you start working on native WMR support?
Which branch do you recommend to rebase to, since there are a lot of changes from your side?

@tomwim no worries, as soon as the new example scenes PR is merged then the WMR stuff is ready to be worked on.
I'm happy to do it, as most of it is going to be just taking your existing SDK and migrating it over.
As for controller models, I still think that should be a separate repo (maybe already is from MRTK?) and we treat it like we treat oculus avatar rather than bake in controller model support into VRTK.

Hi @thestonefox . I got a Windows mixed reality headset recently and been digging around the MRTK repo. Is there anything I could help regarding the WMR support?

@DDReaper Do you know if anyone is working on the Controller models with a newer version of GLTF? I saw it's still a quite early iteration and since then the repo from Khronos changed a lot

We updated MRTK to use the latest version of the Kronos source.  Wasn't massively different, just streamlined the asset download.

Thanks, found it. Missed that it's included in the Dev branch not in master.

Correct and in stabalisation (which is the next release)

@tomwim @DDReaper does this mean that we can just piggy back on that khronos stuff for WMR controller representation in VRTK as well?
Then VRTK is just the SDK bridge and we use a separate asset for controllers? (like oculus avatar)

Yes that is the idea. Like you said before you do not like all that plugins and scripts in VRTK if it is just for visualization, which I agree on.
I am working on a repo that can be included which handles controller visualization. It is based on the MRTK implementation (which includes Khronos' GLTF to load models on runtime) but unfortunately I cannot copy everything 1:1.

The big difference between WMR and other SDK's is that the controller models are provided by the platform and are not contained in any package.  Which is good for support as MS can update them without affecting anyone, but requires a little more magic for SDK's enabling this.

SteamVR doesn't contain them either, it streams the models in at runtime. (At least the Unity SteamVR plugin does.)

Thanks @bddckr , wasn't aware of that based on the current VRTK implementation.

@DDReaper @thestonefox
I updated and refactored my VRTK branch and added all the controller visualization stuff to an extra repository.
VRTK: feature/windows-mixed-reality-refactoring
VRTK-Windows-MR-Extension: release/vrtk-3.3.0-alpha
Just add the extension to the Unity project. It works fine for me and I hope it does in general and for everyone. I added some explanation to the README of the Extension.
Issues:

Haven't updated the example scenes and SDK Setup yet. Will do so when I get your okay to rebase to latest VRTK 3.3.0 alpha. Updating these scenes broke so often for me that I'd rather do it once and not multiple time...
The material looks really weird. Super dark and metallic. It's the same shader and material as in MRTK so I have no idea why it's broken. Maybe you have an idea @DDReaper ?
Unfortunately same issues as mentioned in the original post

@tomwim if you get the new 3.3.0 alpha branch then there are new example scenes and all of the SDK setup stuff is done in 1 scene which is additively loaded in, so you only need to update 1 scene :)
The legacy scenes are still there, but you don't have to bother with them.

Perfect. Am I right that the only scene I have to change is VRTK_SDKManager_Constructor and the prefab in there?

@tomwim yup that's all

Closed and opened a new PR #1743

authors: 265lutab DDReaper bddckr moscartong skyteks thestonefox tomwim

repo: thestonefox/VRTK


text:
task-web displays only one project (and not all) in macOS Big Sur 11.1

While the "task" tab seems to work as intended, with the buttons for Pending, Waiting, Completed, and Deleted listing all the corresponding tasks, when I click on the other tab (i.e. "Projects"), the new page lists only the tasks of the "inbox" project.
However I have at least other two projects and their tasks or the project name do not show up.

After experimenting a bit more, I now understand that:

the "projects tab" will hide those projects whose tasks are not pending;
If there is at least one task pending, its project will be shown;
all the tasks (pending, waiting, completed) will be showed in the "projects tab".

In my understanding, this might not be the intended behaviour. All projects with at least one non-completed task should show up in the "projects tab".

repo: theunraveler/taskwarrior-web


text:
UI macros not working after installing 4.7 in Madrid

I have installed 4.7 in my companies development instance and for some reason UI actions are not displaying at all. Is this an actual bug?

Note: I cannot even backout of 4.7 because the ui action to back out is not available.

It looks like maybe it was a cache issue, the macros worked fine when I restarted my computer.

repo: thewhitespace/Xplore


text:
preventing the flash of blue header on the bootstrap template

I think we've discussed this before but can't find an existing issue...
When the header colour is changed in a Bootstrap project there is still a flash of the default blue header when the page first loads. It shows up most when the header colour is set to white or even set to hidden as in this example http://xerteacademy.com/xt/play_9
I'm not sure how to prevent this and perhaps it will be helped if we have separate themes for the bootstrap project but would certainly be good if we could prevent this.

Here's a simpler demo of the issue with the header colour set to white and the header text colour set to black there is an annoying 'blue flash' of the default header including default text when the page first loads http://training.mitchellmedia.co.uk/xot/play.php?template_id=278

Hi @ronm123 can you check if that fixes this? I thought this was fixed a while back... I know you definitely mentioned it before though...

Hi @JohnSmith-LT yes that definitely fixes it - thanks! Also sorry I just followed the links from github and realised that the first link I posted yesterday is part of a set embedded in my conference presentation last year so set to only display when viewed from that resource. However the second simpler link was fully public and I've updated both installations and both that don't show the flash of blue header.
Cheers
Ron

Thanks John - I've been meaning to look into this for a while!

Just added an additional change to this to also hide the top nav bar. Not sure if this quick animated gif will play here but shows that with some of my projects the black navbar was still flashing before this change.
Had to add an id so called it topnav hope that's ok.

authors: FayCross JohnSmith-LT ronm123

repo: thexerteproject/xerteonlinetoolkits


text:
Copy-pasting equations from Word makes Word hang

Bug 🐛.
What is the current behavior?
on macOS 10.13, copy-pasting the full Word 2010 paste test document into the demo site's filtered editor causes Word to crash (a beachball appears, Word hangs, nothing gets into the field)
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. GIFs and screenshots are very helpful too.

Open the 2010 paste test document in Word.
Select all, copy
Paste into the demo site's filtered editor

What is the expected behavior?
Shouldn't crash / hang
Which versions of the filters or of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of the filters / Draft.js?
Filters 1.0.0, Draft.js 0.10.5 – I think this used to work?

This is due to the "Equation" content. I've had the same issue before but thought it was specific to IE11 – apparently macOS is affected as well. See https://github.com/thibaudcolas/draftjs-filters/tree/master/pasting#ie11.

I'll close this now because I can't reproduce this anymore. I imagine there are more specific circumstances to this (eg. the computer being slower), but that's most likely an issue with Word or the browser rather than Draft.js / the filters.

repo: thibaudcolas/draftjs-filters