text:
Explain how to handle skipped required checks

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct.

What article on docs.github.com is affected?
https://github.com/github/docs/blob/2289ca70c7ec7ec1b81eafdb333cd0157fafaa08/content/github/administering-a-repository/troubleshooting-required-status-checks.md
What part(s) of the article would you like to see updated?
A section should be added that explains that if people use paths for a required check, they'll want to add a second copy of the check with paths-ignore for the same content that just returns true.
Additional information
It's a FAQ in https://github.community

Hello
I'm so sorry for the late.,my phone was infected by trojan hours. I have so
I didn't know how to fix it try downloa like 10 it program for antivru
dos't go what I can do?
On Tue, Aug 10, 2021, 03:52 Josh Soref @.***> wrote:

Code of Conduct

I have read and agree to the GitHub Docs project's Code of Conduct.

What article on docs.github.com is affected?
https://github.com/github/docs/blob/2289ca70c7ec7ec1b81eafdb333cd0157fafaa08/content/github/administering-a-repository/troubleshooting-required-status-checks.md
What part(s) of the article would you like to see updated?
A section should be added that explains that if people use paths for a
required check, they'll want to add a second copy of the check with
paths-ignore for the same content that just returns true.
Additional information
It's a FAQ in https://github.community
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/docs/issues/8926, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AURFIC4MBSWK7NQV3DADDFLT4CPAVANCNFSM5B3JIGOA
.

Subscribe my channel

Hai frnd

It's a FAQ in https://github.community

Hi @jsoref, could you link to one or more examples? Thanks!

https://github.community/t/github-pull-request-is-waiting-for-required-status-checks-even-with-ci-skip-in-commit-message/827
https://github.community/t/github-actions-checks-when-not-in-triggers/194399
https://github.community/t/pr-stuck-waiting-for-checks-which-should-be-skipped/18485
https://github.community/t/feature-request-conditional-required-checks/16761/9
https://github.community/t/skip-ci-ci-skip-dont-work-if-a-repo-has-branch-protection-enabled-travis-ci-pull-request/15326
https://github.community/t/github-actions-and-required-checks-in-a-monorepo-using-paths-to-limit-execution/16586
https://github.community/t/dealing-with-checks-enforced-by-branch-protection-but-skipped-by-path-filter/18451
https://github.community/t/monorepos-and-limiting-workflows-by-changed-files-required-status-checks/136030
https://github.community/t/force-succeed-required-workflow-when-skipped/124055

Thanks @jsoref! This sounds like a great plan that will address a very common source of confusion. You or anyone else is welcome to open that PR! ⚡

Because I landed here from google search, the documented solution is here: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks

@jsoref I'm trying to research this topic, but all the links in https://github.com/github/docs/issues/8926#issuecomment-900516450 are dead. Where can I find those old forum topics?

Dunno. They did a real number in github.community in their migration. It didn't occur to me when I filed this that I'd need to quote the full contents of each item here...

I tried searching for some slugs without dashes but no results, not even on Google.

@TWiStErRob IA appears to have at least some of them..., here's an example: https://web.archive.org/web/20200928033538/https://github.community/t/github-pull-request-is-waiting-for-required-status-checks-even-with-ci-skip-in-commit-message/827

Oo nice, forgot about that.

May someone please review and merge - https://github.com/github/docs/pull/24182 ?

The proposed solution has been removed (as of this commit).
What is now the recommended way of dealing with this?
The docs seem to imply that using a conditional rather than path/branch filtering is the correct way to deal with this.
If this is recommended, could there be an example to show how it works?
PS: does anyone have a link for this issue (as a technical implementation) to follow up there too?

When a workflow is run as a required workflow it will ignore all the filters in the on: section, for example: branches, branches-ignore, paths, types etc. The required workflow will run only for the pull_request and pull_request_target default events. For more information on default activity types, see "Events that trigger workflows."

https://docs.github.com/en/actions/using-workflows/required-workflows#prerequisites

Great! If previously it was inconvenient, now it became a nonsense.
There are two problems with the document that @jsoref referenced:

There is no such thing as required workflow. At least I cannot find one when I am configuring setting for a branch. What it does allow me is to setup a required check. It is very confusing and misleading, especially when there are more than one check (a.k.a. job) in a workflow (a.k.a. file).
Ignoring any filters when a job is marked as required, means breaking a contract of the job configuration. It makes the "required check" feature confusing, introduces longer (than expected) check running times and may introduce extra costs.

Such decisions should be published for community feedback before they make intro the product.

For 1), @minherz scroll up on the linked page for an explanation. Also notice the banner:

Note: Required workflows for GitHub Actions are in private beta and are not available for new signups.

@TWiStErRob I don't believe they existed when I opened this issue.

authors: Fadiabukhadrah Fran-Rg JJ-connect TWiStErRob cb-shivamagarwal jsoref lecoursen minherz rolerider


text:
Update enabling-codespaces-for-your-organization.md/BSTOOPIDTRAPPXNCOLLAB

Add Straight forward Education on coding

Why:
Closes [issue link]

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[x] This pull request impacts the contribution experience

[x] I have added the 'writer impact' label
[x] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

Auto Learning coding Required

Good

source: gharchive/pull-request

repo: github/docs

license_type: permissive

license_source: github-api


text:
Small screen resolution precision

It appears that the branch '{% octicon "git-branch" aria-label="The branch icon" %}' gets removed past a certain resolution and this tutorial, altho correct, becomes somewhat of a big question mark.
I have never had the issue happen until i started using this 15 inches NEC monitor SIDEWAYS as a second monitor on my current dev stack in order to test out somewhat accurately some odd resolutions mobiles have and their effects on browsing.
I couldn't figure out why i had been able to delete branches from the web gui for all i can remember and now, very very confusingly, couldnt figure out it for the life of me. Even so i had to google it because it killed my chi.
Decided to add to the docs, please feel free to do whatever you want with that and, thanks!

Why:
caused an issue as described when using small resolution screens which hide the subject
Closes #13662
What's being changed:
just a precision within a NOTE block
Check off the following:

[X] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[X] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

This is the result of command xrandr on the computer i'm using with regards to the monitor in question.
VGA-1 connected 768x1024+1920+0 right (normal left inverted right x axis y axis) 304mm x 228mm
   1024x768      75.03 +  70.07    60.00*
   832x624       74.55
   800x600       72.19    75.00    60.32    56.25
   640x480       75.00    72.81    66.67    59.94
   720x400       70.08

It is rotated to the right. and is part of a larger display server of (1920+768)=2688 px
Thanks!

Could also mention that the thing can be accessible via url /branches within a project

@mathieu-aubin
Thanks so much for opening a PR! I'll get this triaged for review :zap:

I think that we should fix this bug instead of documenting the workaround.  🤔  Let me pass this on to the engineering team.

@mathieu-aubin, thanks for doing this! I agree with @ethomson above that we should treat this as a bug to fix so that the workaround wouldn't be necessary.

Thanks for weighing in! I'm going to close out this PR since we will fix the bug instead of documenting this, but we hope to see more contributions from you in the future @mathieu-aubin !

Great. All i hoped for was some kind of resolution. But... is this fair to call this a BUG? I mean... it seems the site IS functionnal yet, the DOCS dont take the programming into consideration. Is this a bug or an omission, a mishap in writting docs, maybe not writting as universally as it best would be.
Dont get me wrong, i will, again, repeat; im all about resolution on issues that might pose new users or heck, all for any kind of resolution.
I really am puzzled with the fact that its called a bug - i dont see 'wording' or 'written explanations' being able to be affected by what we can call a bug (as in the moth flew into the glass tube amp and fucked it all).
I appreciate whatever input you have on my concern, no matter opinionated with regards to me being 'pulling hairs' or bein anal about a docs group being accurate.
That being said, its all 'write' with me, i wont loose sleep over it as i dont do much of that lately!
Cheers and may the shwartz be with j00

authors: davidstaheli ethomson mathieu-aubin ramyaparimi skedwards88


text:
Add auth mismatch to SSH troubleshooting

Not sure if this is written in the most clear way, but I consider myself a pro and I've tripped on this many times. IUt always takes a while to be remember that a very basic workflow I take for granted sometimes leads to the most cryptic of problems.

@conartist6 Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

I'm sorry I'm not more excited to jump through hoops. This is a paid product and I don't work for GitHub. Consider this PR a concrete suggestion as to how to improve your documentation to cover a common "gotcha".


text:
Update index.md

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or  employee).

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[x] Content (and my changes are in index.md)

David Chaum came up with the concept of Mix networks in 1981, Stuart Haber and W. Scott Stornetta came up with cryptographic and secured blocks in 1991. Satoshi coined the term blockchain in 2008 prior to releasing Bitcoin in 2009. I think it is fair that not only Satoshi is credited as the sole inventor in the Github explore page, and you change it to, "David Chaum, Stuart Haber, W. Scott Stornetta, Satoshi Nakamoto and various authors", which is technically more historically accurate.

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Yes agreed. Only including Satoshi would undermine the fact that core aspects of the technology was there decades ago. I think removing the credited by makes sense in your point that it would be much more simple then listing various others on topics.

repo: github/explore


text:
Update made-in-india.md

Add some of @thefallenmerc 's project.
Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[ ] Content (and my changes are in index.md)

I have added some interesting project's of @thefallenmerc. These projects inspired me to learn a lot and I wanted to addd those here in so that other devs around world can learn from it.

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Hi @TheAlphamerc. Thanks for your contribution.
Unfortunately, these projects don't seem to be widely used enough right now to be featured.
See relevant text from our contributing guidelines:

We are likely to consider suggestions to curate a topic or collection that is valuable to GitHub's community. Valuable topics, for example, include those that are already widely used by repositories, or a topic that currently lacks important information. When suggesting content, please consider how to make your contribution broadly useful and relevant to others, rather than serving a specific use case.

authors: TheAlphamerc mvkaran


text:
Request body object is passed as-is

Current behavior
When providing a non-stringified object as a request body, whatwg-fetch propagates that object to XMLHttpRequest.send() as-is.
fetch('/example', {
  method: 'POST',
  headers: {
    'Content-Type': 'application/json'
  },
  body: { a: 1 }
})

Expected behavior
Expected for this scenario to behave as native window.fetch, where such non-stringified request body would be transformed into the "[object Object]" string, stating that this is not a valid body per request headers.
Justification
This raises an incongruence between the polyfill and the implementation it polyfills, producing a different behavior in a browser and NodeJS for the same request issuing code.

Originated from https://github.com/mswjs/msw/issues/433

Reproduction
See this reproduction repository.

I understand this is a slightly different testing context between the two cases, but I hope it showcases the issue.
Browser
Unlike whatwg-fetch, window.fetch in the browser doesn't rely on XMLHttpRequest class, so the most objective way to see what it does with the non-stringified body is to inspect the "Request payload' in the network of DevTools.
NodeJS
In NodeJS I can see that whatwg-fetch dispatched XMLHttpRequest.open with the request body as-is. By inspecting the polyfill implementation I also conclude that there's no logic that would attempt to stringify the body:
https://github.com/github/fetch/blob/61372fdeb8e6eb59e13da265d518dca21467c1d3/fetch.js#L216-L258

Same issue

@JakeChampion, sure thing. I'd be glad to ship a fix.

Hey, @JakeChampion. Please, would there be a chance to review my pull request (https://twitter.com/ApiMocking/status/1362084398632488961)? That'd be of huge help.

Hey, @JakeChampion. Please, would there be a chance to review my pull request (#881)? That'd be of huge help.

The pull-request was opened as a draft so I assumed it was not ready for a review. I've reviewed it now.  Thank you for the contribution :-)

Thank you for the review, @JakeChampion! 🎉 My bad, I haven't marked it as ready. Excited to see this merged and looking forward to the release!

This is released in v3.6.0 -- https://github.com/github/fetch/releases/tag/v3.6.0

source: gharchive/issue

authors: JakeChampion kettanaito miccycn monstro805

repo: github/fetch

license: mit

license_source: bigquery


text:
vendor: vendor dependencies in vendor/ using Glide

script/vendor received an update in order to work with Glide
import paths have been rewritten to work with GO15VENDOREXPERIMENT

It's highly suspicious that this diff removes so many lines of code, since it should just be moving the files. Turns out we had both github.com/ThomsonReutersEikon/log4go and code.google.com/p/log4go vendored, and code.google.com/p/log4go was removed since that import path is not used anymore.
I think this is a good change :+1: A couple more things:

[ ] Fix any GO15VENDOREXPERIMENT=0 in the repo to GO15VENDOREXPERIMENT=1.
[ ] Update the contributing guide to mention Glide and the new vendor path here.

I'm not 100% sold on glide, but hopefully this makes it easier to switch those tools later. Once everything lives in vendor/, all we'll have to change is script/vendor and some docs.

Yep, just need to re-add code.google.com/p/log4go and we should be back to normal 👍

Do we? If everything is using github.com/ThomsonReutersEikon/log4go instead, we should probably just keep that. AFAIK only the ntlm package uses any log4go.

Looks like this commit removes go-ntlm's dependency on log4go, so maybe you can drop that repo.

@grahamking great find! @technoweenie and I spent a while wrestling with glide before I 👀 this.

We tried a few Go package management tools, but ended up using none of them. We just copy the code into our vendor/ directory, delete it's .git dir and *_test.go files, and commit that. Couldn't get much simpler.
To update you checkout the latest version of your dependency somewhere else and copy it into your vendor directory again. Easier than learning a new tool.

Glide seems to be working mostly okay. The problem is that go test ./... started failing because it was testing all the vendored packages. That's why I filed a PR against your log4go fork to fix the imports from its examples package. Turned out that didn't matter because it couldn't compile the examples/*.go files into a single package.
../go/src/github.com/github/git-lfs/vendor/github.com/ThomsonReutersEikon/log4go/examples/FileLogWriter_Manual.go:17: main redeclared in this block

I'm really glad you removed the log4go dependency from go-ntlm though :metal:

Small point but you should update script/lint to not mention Nut and instead say to run glide up.

Looks good. I didn't want to make any updates to dependencies in this PR, but the go-ntlm package made a single commit that removed log4go 🎉
https://github.com/ThomsonReutersEikon/go-ntlm/compare/52b7efa603f1b809167b528b8bbaa467e36fdc02...b00ec39bbdd04f845950f4dbb4fd0a2c3155e830

authors: grahamking sinbad technoweenie ttaylorr

repo: github/git-lfs


text:
Parse the commands for the external scripts

With this modification the external scripts commands are parsed and added to the hubot-help output.

I haven't had time to think about this (maybe this week?), but I'm very confused... I don't see problems with external scripts not being in the command list, and yet your change looks like it should be required. My guess (without investigation): the loader in every external module calls parseHelp for each script it loads.

I have a feeling this is one of those bits of functionality that has seen churn. I haven't found the old references, but I'm pretty sure this used to exist and was causing problems. In addition, we've encouraged script authors to include code in their index.coffee to parse help, so this would mean having duplicate help messages.

cc #858 because help-parsing needs to be part of programmatic loading

If you look at the default hubot scripts, they all have a index.coffee like https://github.com/hubot-scripts/hubot-pugme/blob/master/index.coffee (makes sense since I used generator-hubot). You'll notice they are calling robot.loadFile. robot.loadFile calls @parseHelp.
That means as is, it'd result in duplicate help commands. I'm going to close because of that.
It does bring up some interesting potential ideas though. Using @parseHelp(require.resolve(pkg)), it means you could make a package script, and the script would just be the main as specified in package.json, meaning less boilerplate. I'd be :+1: to that idea, but the migration path would be tricky for all the script packages already out there.

Using @parseHelp(require.resolve(pkg)), it means you could make a package script, and the script would just be the main as specified in package.json, meaning less boilerplate.

Huh? You lost me...

the script would just be the main as specified in package.json

referring to this main https://github.com/hubot-scripts/hubot-pugme/blob/master/package.json#L30

meaning less boilerplate.

If there was only a single script, and hubot handled parsing the docs of it, there wouldnt' be a need for https://github.com/hubot-scripts/hubot-pugme/blob/master/index.coffee

Got it; thanks!

repo: github/hubot


text:
SPARQL (.rq) files aren't detected

Hi,
I have a repository in which I have two SPARQL queries, but this files isn't being detected in the languages graph.
Problem Description
It is strange because there is only one sh files and it is detected, but the two SPARQL files aren't detected. At the beginning I thought that maybe SPARQL wasn't admitted as language for the graph or it haven't been added, but I confirmed that it is well-configured checking languages.yml.
URL of the affected repository:
CanaryBot
Last modified on:
2018-02-02
Expected language:
SPARQL
Detected language:
I don't know if it is being confusing with Python or with Shell, but I think the main problem is that it isn't being detected.
Thanks in advance!
Iván

It expected that for your SPARQL files to be counted in the language stats as SPARQL is considered a data language and not a programming language by Linguist:
https://github.com/github/linguist/blob/812797b51da51356deeacfbe18b5a5990246918d/lib/linguist/languages.yml#L4076-L4077
... and Linguist doesn't include data languages in the stats by default.
You can however now change that by using the linguist-detectable override.

Oh, thank very much @lildude :), for the information and for the help to make it detectable.
I am going to close this issue because you have explained me why it happens with this kind of languages and how it can be "solved" if I want to make it detectable.
Regards,
Iván

authors: ivanhercaz lildude

repo: github/linguist

license: MIT


text:
feat: add support for AbortSignal

To manage events, typically these projects have followed a pattern of using subscribe():  () => void where the returned function is the unsubscribe method. This gives us a more "ergonomic" mechanism for managing multiple event handlers, such that they can be quickly unbound.
This has worked fine, but it is a pattern we've developed in "user space" and so does not align with any spec. However, there is a spec which can help us here, which is AbortSignal. Events now support being given an AbortSignal which will unsubscribe the event when the signal is triggered.
https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#add_an_abortable_listener
This change adds {signal} as an option that can be passed to the install methods, which will be passed back to the event listeners.

No please delete

This is fraud from ex

authors: keithamus mmfiv

repo: github/paste-markdown


text:
Avoid loading openssl + securerandom unless needed

I've been profiling boot time for some scripts that are short-lived / high throughput and noticed that requiring the openssl lib (brought in via statsd.rb) can add a pretty massive 30ms user+sys cpu overhead:
Thread ID: 69933375328960
Fiber ID: 69933379015820
Total: 0.049605
Sort by: self_time

 %self      total      self      wait     child     calls  name
 12.78      0.008     0.006     0.000     0.002        1   RequireProf#require:openssl.so
  6.11      0.005     0.003     0.000     0.002        1   RequireProf#require:socket
  6.10      0.003     0.003     0.000     0.000        1   RequireProf#require:zlib
  5.76      0.030     0.003     0.000     0.027        2   RequireProf#require:openssl
  5.61      0.003     0.003     0.000     0.000        1   RequireProf#require:date_core
  5.44      0.003     0.003     0.000     0.000        1   RequireProf#require:stringio
  5.18      0.008     0.003     0.000     0.006        1   RequireProf#require:time
  4.97      0.002     0.002     0.000     0.000        1   RequireProf#require:fcntl
  4.48      0.005     0.002     0.000     0.003        1   RequireProf#require:openssl/config
  4.22      0.002     0.002     0.000     0.000        1   RequireProf#require:socket.so
  4.01      0.002     0.002     0.000     0.000        1   RequireProf#require:openssl/x509
  3.88      0.002     0.002     0.000     0.000        1   RequireProf#require:openssl/buffering
  3.85      0.007     0.002     0.000     0.005        1   RequireProf#require:openssl/ssl
  3.61      0.003     0.002     0.000     0.001        1   RequireProf#require:securerandom
  2.99      0.006     0.001     0.000     0.004        1   RequireProf#require:date
  2.94      0.002     0.001     0.000     0.000        1   RequireProf#require:openssl/digest
  2.93      0.002     0.001     0.000     0.000        1   RequireProf#require:openssl/cipher
  2.87      0.001     0.001     0.000     0.000        1   RequireProf#require:digest.so
  2.80      0.001     0.001     0.000     0.000        1   RequireProf#require:openssl/bn
  2.53      0.001     0.001     0.000     0.000        1   RequireProf#require:date/format
  2.45      0.050     0.001     0.000     0.048        1   RequireProf#require:statsd
... snip everything < 1ms ...

This PR avoids loading the openssl and securerandom libs unless a signing key was provided. I've also removed the 'time' require. The core Time class has Time.now built in. Explicitly requiring 'time' brings in a bunch of formatting functions like Time#iso8601, stuff we don't here.
/cc @jssjr, @tmm1, @vmg, @github/perf

:+1: Legit

:+1:

:ship:

authors: dbussink jssjr rtomayko vmg

repo: github/statsd-ruby


text:
Git Out of Trouble is in Trouble (Broken Links)

@beardofedu @hollenberry
Very related to #484:
[Set Up Your Environment](/on-demand/git-trouble/01) does not resolve to /git-trouble/git-set-up as well.
Here is a search for all occurrences.
Here is one of the five pages on which the link does not work.
A customer is asking for a fix in this Zendesk ticket. Thanks a lot in advance!

cc @github/services-training
@mwiesen I'm not sure I understand the problem. I tried to replicate based on the instructions in the Zendesk ticket, but wasn't getting broken links. Am I missing something?

OH! Of course, after I comment, I see. I understand now, @mwiesen. I will work on fixing this today.

@brianamarie thanks for the very quick fix! ❤

authors: brianamarie mwiesen

repo: github/training-kit


text:
Fixing markdown rendering

This markdown file renders ok on https://blocks.githubnext.com/githubnext/blocks/blob/main/docs/Developing blocks/2 Building your first block.md :

But on github it is not rendered properly https://github.com/githubnext/blocks/blob/main/docs/Developing blocks/2 Building your first block.md

This should fix the rendering on GitHub

Thanks @bessarabov!

authors: bessarabov idan

repo: githubnext/blocks


text:
Merge Micycle1975/master

added option for full diff of files

This needs another fix: set a default value to "$size" of "function getCommit" in "Repository.php", but I can't figure out how to submit my change to the correct branch... :-/ Will continue tomorrow.

Work finished from my side.

repo: gitlist-php/gitlist


text:
doc typos

This just fixes a few typos in the doc examples.
Thanks for the great library!

many thanks @chunkerchunker !

authors: chunkerchunker giusepperaso


text:
Add Circle CI config

CircleCIのコンフィグファイルを追加しました。READMEにバッジも追加しました。
また、TravisCIのコンフィグファイルは削除しました。

@koka831 review me

@shunjikonishi mergeお願いします


text:
TTA embedded cussheet causes duplicate scrobbls

foobar 1.5.5
file: 発熱巫女～ず - ''Everflowering'' Masterpieces of Hatsunetsumiko's 2011 - 2013.tta
(I don't know if it will cause any problem, but i will give the files for you to test)
https://mega.nz/folder/8llHQSQB#YbhptauVaJWNsZmlOa5hQA
When I use cue file, it works well. But if I embed cuesheet in the tta file and open the tta file, foobar will scrobble it every second.
like this.

And foobar will send error album artist.
error
https://www.last.fm/zh/music/陽花/'Everflowering'+Masterpieces+of+Hatsunetsumiko's+2011+-+2013
it should be
https://www.last.fm/zh/music/発熱巫女～ず/'Everflowering'+Masterpieces+of+Hatsunetsumiko's+2011+-+2013
How can I solve this problem? Thanks
PS:
I have tried to use other tta files, they repeated those problems.

This seems to be a bug in  foo_input_tta. When playing such a TTA file, the "dynamic info track" event is continuously emitted, even though the artist/title hasn't changed.

authors: Soulcrzkc gix


text:
🛑 BCDC APIs List is down

In f3d28b8, BCDC APIs List (https://catalogue.data.gov.bc.ca/dataset?type=WebService&download_audience=Public) was down:

HTTP code: 500
Response time: 294 ms

Resolved: BCDC APIs List is back up in b65bd71.

repo: gjlawran/apsmon


text:
Library build fails due to errors in index.d.ts

Hi everyone! I'm using the three-mesh-csg inside of the library, that is written in Angular 10. With the recent addition of typescript types it stopped building due to errors in the index.d.ts file of three-bvh-csg. There are two main issues:

Generic type 'Array<T>' requires 1 type argument(s). ts(2314) - The "Array" keyword, which is treated as a generic type and requires at least one type argument. I haven't delved deep into the implementation of each particular method, but unless it is specified differently, the fix would be to either add  type to the array generic, at least for now, so that typescript will be okay with that, or to add the target type, that the method related to this issue should return.

export class TriangleIntersectionSets {

  addTriangleIntersection( ia: number, tribA: Triangle, ib: number, triB: Triangle ): void;
  getTrianglesAsArray( id?: number ): Array;
  getTriangleIndices(): Array;
  getIntersectionIndices( id: number );
  getIntersectionsAsArray( id?: number, id2: number ): Array;

}

A required parameter cannot follow an optional parameter. ts(1016) For the declaration of getIntersectionsAsArray( id?: number, id2: number ): Array the error is concerning the id2 argument, which can't be required. Looking at the implementation of this method, this argument could be also marked as optional.

Hi @RobertS21! Would you like to make a PR to fix the issues? The npm run lint command runs the following tsc line:
tsc -p tsconfig.json --noEmit

Perhaps the typescript check can be adjusted to make sure we catch these issues, as well?
Thank you!

I'm afraid that my knowledge of tsconfig is too small to be able to implement some useful changes. I've tested the repository with the above command, although no issues were found in terms of typescript. I guess an important note is that the errors that were found for me were thrown by an ngc compiler, not tsc, so I'd say it was strictly an issue with using three-bvh-csg with Angular.

I'm afraid that my knowledge of tsconfig is too small to propose some solution that would catch errors like this. I've tested the above mentioned method and there were no issues found. I've also once again checked logs and found out, that the errors were thrown by ngc compiler, not tsc. That said, it could probably be an Angular integration of three-bvh-csg issue.

Interesting - could it be a difference in Typescript version, as well?

Hmm... this is very likely. I've been using Typescript 4.0.6 with Angular 10. Tested it on some other branch with Angular 13 and Typescript 4.6.4 and error is not thrown despite not having the types defined. I'd have to read into Typescript patch notes between those versions.

Great thanks for checking. The more explicit types are better, anyway so we'll get those merged!

Closed via #84

repo: gkjohnson/three-bvh-csg


text:
panicked when working  with tokio async

when use reqwest to request schema registry with tokio async ,like my code below in warp main thread or use tokio::spawn to create a async block will exit
use warp::Filter;
use schema_registry_converter::schema_registry::{SrSettings};

#[tokio::main]
async fn main() {
     let hello = warp::path!("hello" / String)
        .map(|name| format!("Hello, {}!", name));
     let sr_settings = SrSettings::new(String::from("http://localhost:8081/"));

    warp::serve(hello)
        .run(([127, 0, 0, 1], 3030))
        .await;
}

thread 'main' panicked at 'Cannot drop a runtime in a context where blocking is not allowed. This happens when a runtime is dropped from within an asynchronous context.', ~/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-0.2.22/src/runtime/blocking/shutdown.rs:49:21
stack backtrace:
   0:        0x1083da9ee - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h72782cdbf82d2e78
   1:        0x1083fc1ac - core::fmt::write::h0f2c225c157771c1
   2:        0x1083d52d9 - std::io::Write::write_fmt::h6d219fc26cb45a24
   3:        0x1083dc865 - std::panicking::default_hook::{{closure}}::hde29d026f53869b1
   4:        0x1083dc5a2 - std::panicking::default_hook::h5de23f27de9ce8ce
   5:        0x1083dcdc5 - std::panicking::rust_panic_with_hook::h720143ee15fc80ba
   6:        0x10840664e - std::panicking::begin_panic::h80d64999a84f0366
   7:        0x108297874 - tokio::runtime::blocking::shutdown::Receiver::wait::hc15bfd5c68b76ca0
   8:        0x1082cbfc5 - tokio::runtime::blocking::pool::BlockingPool::shutdown::h702cd79db6adf80b
   9:        0x1082cc07d - <tokio::runtime::blocking::pool::BlockingPool as core::ops::drop::Drop>::drop::h0ab515030d41ffa8
  10:        0x1082d6215 - core::ptr::drop_in_place::h1df0de4e6c94e3fe
  11:        0x1082d8252 - core::ptr::drop_in_place::h94c49217ab7681ef
  12:        0x10801a738 - reqwest::blocking::wait::enter::he7b4b5e4e35343bf
  13:        0x108019bd7 - reqwest::blocking::wait::timeout::h7234a2ddbbcb0534
  14:        0x10803b703 - reqwest::blocking::client::ClientHandle::new::hd976e58a3aac69e4
  15:        0x10803ae1d - reqwest::blocking::client::ClientBuilder::build::h18af5d75937efe22
  16:        0x10803aece - reqwest::blocking::client::Client::new::h09aac586c8993277
  17:        0x107eff6ea - schema_registry_converter::schema_registry::SrSettings::new::h3b74a91814783f96
  18:        0x107d0a3f3 - my_web::main::{{closure}}::hbb912dd7df4aeb4d
  19:        0x107ca4120 - <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::ha2815f8e7aca5dc1
  20:        0x107c8865d - tokio::runtime::enter::Enter::block_on::{{closure}}::h6b5e9b23e5c4d655
  21:        0x107c8e506 - tokio::coop::with_budget::{{closure}}::hb18b9d07d0e693a7
  22:        0x107cebdee - std::thread::local::LocalKey<T>::try_with::ha9811a7840d57628
  23:        0x107ceb4ac - std::thread::local::LocalKey<T>::with::hcb4e45ba7e69edaa
  24:        0x107c884ad - tokio::runtime::enter::Enter::block_on::h8dea6c389ed18880
  25:        0x107d11315 - tokio::runtime::thread_pool::ThreadPool::block_on::h274b9930f19cc162
  26:        0x107ca76e8 - tokio::runtime::Runtime::block_on::{{closure}}::hf60396b6d86ee761
  27:        0x107cc90b8 - tokio::runtime::context::enter::hcb90097146788eb6
  28:        0x107c653db - tokio::runtime::handle::Handle::enter::h7963a1ebbf377697
  29:        0x107ca763d - tokio::runtime::Runtime::block_on::h61ecdca8fd87f99b
  30:        0x107cb24cc - my_web::main::h372f3d2471b960b7
  31:        0x107d1171e - std::rt::lang_start::{{closure}}::h6532f1318acae0d5
  32:        0x1083dd14f - std::rt::lang_start_internal::hbbd10965adc92ae7
  33:        0x107d11701 - std::rt::lang_start::ha5adc3b371471675
  34:        0x107cb2532 - main

Currently it's all blocking sync. Mainly because cashing will be hard. Also I don't have much experience using async jet.
So the reqwest client inside the SrSettings one is blocking. I don't really understand what your trying to do.
Something I could do, is at least for the schema_registry module, is offering async calls, by using the async reqwest client.
My main concern is with the converters. Kafka is really fast, so if I get a million messages with the some id in a second, and the Sr calls also need a second, I don't want to that a million times.
Most likely there are solutions to this, I just haven't take a look at them. I'm trying to finalise for the 2.0.0 release, it's probably good to mention the current version is blocking.
I'd love to hear how you think about those things.

What I'm trying to do is to build a http server by using warp to put all request into a channel and then with a async task to produce those requests into Kafka.

Ok, but are you using Schema Registry? In that case it would be nice if you could use this library for some of the stuff related to that.
Just to be sure, this library is not sending anything to Kafka, you need either https://crates.io/crates/rdkafka or https://crates.io/crates/Kafka for that. Now that rdkafka is async by default it would probably make sense to have async converters as well. But at this point I really don't know how much work it would be.

Sure . I'm trying to using this crate to encode message to Avro

Ok, can't promise anything, and don't think I want it to be part of 2.0.0. But seems like a valid use case with rdkafka being async by default. And know the http calls already use reqwest I don't see any problems beside the cache. But seems like a problem that has likely be solved already, so definitely going to look into it.

That's great and thanks for you work.

Thanks, at the very least I want to be confident enough I don't need to break to api to implement it. So very much thinking of adding at least support to schema_registry for async, and have the converters return an error when used with async SrSettings. Api would then be something like:
let sr_settings = SrSettings::new_builder(String::from("https://condluent.cloud.url"))
    .async()
    .build()
    .unwrap();

to create the async version. I'm not convinced async as default is a good idea, but I'll give it some thought.

I decided to bite the bullet, and split the code in blocking and async, much like how reqwest has done. I'm also going to default to async, as that seems to make most sense as both reqwest and rdkafka are async by default. I'm not sure how much will be available async when 2.0.0 comes out, but at least I don't need breaking changes adding more async features later on this way.
So unlike my last message it will be  probably the case you need to add the feature "blocking" to get access to the blocking api, and all else will be async, but like I said, the initial available async api will likely be minimal since I really want to have 2.0.0 out before Kafka summit.

@undeflife Could you maybe check if you can use it async now? Just merged in the async Avro encoder/decoder. It should use async by default, so you should only need the feature avro, and then be able to use the AvroEncoder and AvroDecoder with async implementations.

Works as expect! Thanks.

authors: gklijs undeflife


text:
🛑 Schoelcher is down

In f817aa2, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 6e4e517.

repo: glefait/martinique-public-websites


text:
🛑 Trois-Ilets is down

In 0528f75, Trois-Ilets (https://villedestroisilets.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Trois-Ilets is back up in 1a6bc58.


text:
🛑 Schoelcher is down

In cd1f3f2, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 37e462e.


text:
🛑 Le Lamentin is down

In a84a534, Le Lamentin (http://www.mairie-lelamentin.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Le Lamentin is back up in 6e0f2bb after 2 days, 10 hours, 27 minutes.


text:
🛑 Biodiversite Martinique is down

In c1e9e51, Biodiversite Martinique (http://www.biodiversite-martinique.fr) was down:

HTTP code: 503
Response time: 1363 ms

Resolved: Biodiversite Martinique is back up in 51b404d after 5 minutes.


text:
🛑 Schoelcher is down

In b7057bd, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in c4c0123.


text:
🛑 Schoelcher is down

In c89502c, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 79ab050.


text:
🛑 Schoelcher is down

In b676a25, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 3ac1195.


text:
🛑 Office du tourisme du centre de la Martinique is down

In abbbe04, Office du tourisme du centre de la Martinique (https://tourisme-centre.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Office du tourisme du centre de la Martinique is back up in 733c07d.


text:
🛑 Comite Martiniquais du tourisme is down

In 5ba1ac2, Comite Martiniquais du tourisme (https://www.martinique.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Comite Martiniquais du tourisme is back up in 716f14d.


text:
🛑 Le Lamentin is down

In 794f260, Le Lamentin (http://www.mairie-lelamentin.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Le Lamentin is back up in 77b85ed.


text:
🛑 Schoelcher is down

In e0a05c6, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 5f9ad75.


text:
🛑 Comite Martiniquais du tourisme is down

In 277b260, Comite Martiniquais du tourisme (https://www.martinique.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Comite Martiniquais du tourisme is back up in dae788d.


text:
Ability to add custom readers and writers

I would like to be able to add the ability to transit moment objects in this library (using https://github.com/ianks/moment-transit).
Would you be open to extending the API to allow for customer readers/writers?

Yep, that would be great - I'm surprised it hasn't come up before actually!

I suppose the best way would be to accept some new options (readerHandlers and writerHandlers), which would be merged into the base configuration for transit. Thoughts?

I think a withHandlers method could match the records API nicely.
Perhaps accepting an array of read/write pairs?

As mentioned in #30 - we could also export the readers and writers from this module, allowing a consumer to combine them in any way they like with other codecs.

I've started some WIP on this - https://github.com/glenjamin/transit-immutable-js/pull/31
I reckon I'll also add a withExtraHandlers function which takes an array of 3-tuples, [class, readHandler, writeHandler].
The advantage of this approach is most users won't need to care about the internal transit map data-type.

@glenjamin Would this approach work with https://github.com/ianks/moment-transit?

Not as-is, looks like they'd need to either expose their handlers or provide a similar extension mechanism to withExtraHandlers

It would be nice to just have a way to pass arbitrary reader and writers a la moment-transit. If that were possible, we could just create a library of common readers and writers and they could be plug and play without any additional knowledge of immutable transit. I don't know how feasible that is though.

As far as I'm aware, transit's reader and writer instances don't compose - only the handlers do.
Here you can see where moment-transit wraps it's handlers into a reader and writer: https://github.com/ianks/moment-transit/blob/master/index.js#L22-L34
That's pretty much what this lib does as well at the moment, exposing the handlers as in the PR will allow people to combine them together and create their own reader/writer instances.

Makes sense. I have to say, the transit API is a little... confusing :)
If you could provide an example in the docs that would be incredible! Thanks for your work on this.

Yep, I'll be sure to expand the docs to include examples when the PR gets merged.
In the mean time, would you be able to export the read/write handlers from moment transit - I only just realised its your lib!
I can imagine a couple of levels of API will end up being available:
The transit-immutable-js wrapper, which hides the details of transit's API:
var transitImmutable = require("transit-immutable-js");
var moment = require("moment");
var momentTransit = require("moment-transit");

var transit = transitImmutable.withExtraHandlers([
  {class: moment.fn.constructor, write: momentTransit.MomentHandler, tag: "moment", read: moment}
]);

Or the user assembles the transit reader/writer instances themselves:
var transit = require("transit-js");
var transitImmutable = require("transit-immutable-js");
var moment = require("moment");
var momentTransit = require("moment-transit");

var readHandlers = transitImmutable.handlers.read;
readHandlers.moment = moment;
var reader = transit.reader("json", { handlers: readHandlers });

var writeHandlers = transitImmutable.handlers.write;
writeHandlers.set(moment.fn.constructor, momentTransit.MomentHandler);
var writer = transit.writer("json-verbose", { handlers: writeHandlers });

@ianks @gusvargas I've updated the PR #31 with docs, tests and a working implementation.
Do you have any feedback on this before I do a release?

#31 is now released in v0.7.0.

authors: glenjamin ianks

repo: glenjamin/transit-immutable-js


text:
Hot update sometime not working

Hi, I'm using win7, Cygwin and IDEA.
Find that sometime hot middleware can't detect file updating. And if I try redo, undo, redo, undo, redo, undo. It works again.
I have to keep console open so that know if it's hot reloaded or need repeat to make it trigger.
Thanks

Update. It seems restart machine can keep updating again.

I meet this issue too, Hot update sometime not working, but sometime is working~

@zombieJ    How did you solve it？

@ipluser , IDEA provide safe save mode which will create a new file and then replace the original one. That will miss trigger the hook of hot update. Close the safe save will help.

@zombieJ
Thx~

authors: ipluser zombieJ

repo: glenjamin/webpack-hot-middleware


text:
Is it necessary to encapsulate  vim.diagnostic.config in saga？

This is an open topic. Is it necessary to encapsulate vim.diagnostic.config in saga. Will any configuration about diagnostic be easy? I see that many plugins support configuring sign and virtualtext. It's weird. Is vim.diagnostic.config unfriendly to newbies?

In my mind, if there's already a builtin way of defining a configuration option in nvim, then it seems reasonable to expect that option to at least be the fallback value for related plugins. In the larger ecosystem, this would ensure consistency and limited configuration overhead when using multiple plugins which are complementary in functionality or when migrating between plugins. I can see the potential need for one specific plugin to act differently, but I feel like this is probably an edge case.
I personally wasn't even aware of vim.diagnostic.config for quite a while. I feel like that was because every plugin has their own unique configuration scheme, causing the builtin config to rarely be mentioned in a way that newbies could even know about it, but that could just be my experience.
So I guess, for my two cents, I wouldn't say it's absolutely necessary but I think the whole nvim plugin community would benefit greatly from unifying around common practices already builtin.

right. so closed.

authors: glepnir jsatt


text:
Outline auto_refresh does not work with Java core API files

Describe the bug
auto_refresh does not update the outline if the target buffer contains a Java source file.
Steps to reproduce

Use "goto definition" with a Java API import like:

import java.util.Comparator;

the source class file for Comparator.class is opened in a new buffer.

Open the outline with :Lspsaga outline. The outline is correctly opened for Comparator.class
Switch to another buffer.  The outline will refresh.
Switch back to Comparator.class. The outline will not refresh.

Expected behavior
Java API source files on Linux are kept in a .zip file (i.e. /usr/lib/jvm/openjdk-17/lib/src.zip). I think extraction of this file is handled by the LSP server automatically. The unpacked file is not a real file. The file path for the Comparator.class looks like
 jdt://contents/java.base/java.util/Comparator.class?=app/%5C/usr%5C/lib%5C/jvm%5C/java-17-openjdk-amd64%5C/lib%5C/jrt-fs.jar%60java.base=/javadoc_location=/https:%5C/%5C/docs.oracle.com%5C/en%5C/java%5C/javase%5C/17%5C/docs%5C/api%5C/=/%3Cjava.util(Comparator.class.
The buffer with Comparator.class therefore has the nofile flag set. And this is excluded in the outline.lua:
https://github.com/glepnir/lspsaga.nvim/blob/1d56a915d42a79242ef1237dba63836fcf3c7307/lua/lspsaga/outline.lua#L301-L308
I'm not sure, how this could be fixed without breaking other nofile buffers that should be ignored. Maybe check the file path for jdt://?
Neovim version (nvim -v)
0.8.3
lspsaga commit
1d56a91
Terminal name/version
Gnome Terminal 3.44.0

the class file buftype and filetype output is what.

filetype: java
buftype: nofile

so there need a double check ?

Yes, that should work I think. Or maybe only check for filetype=='java' and then skip ignore?

just thinking auto refresh should be work inside lspattach. then no need these check.

I don't understand. Is this something I should test? Where/how?

Hmm, the fix doesn't work. Now auto_refresh does not work at all anymore.

damn it  only work  when first open . .. wait

Better - but not perfect yet:

Open file 1
Open :Lspsage outline
Open file 2

File 2 is visible in the active buffer but outline is not updated.
It only works if the order is reversed:

Open file 1
Open file 2
Open :Lspsage outline

works for lua file  i had test this way before update

also tested in c c++ go rust.

I added a print:
function ot:auto_refresh()
  api.nvim_create_autocmd('BufEnter', {
    group = self.group,
    callback = function(opt)
      print('bufenter', api.nvim_get_current_buf())

Open file 1
Open :Lspsage outline
Open file 2

[Lspsaga.nvim] there is no server attatched this buffer
bufenter 1
bufenter 12
bufenter 1
bufenter 13
[lspsaga.nvim] there is already a request for outline please wait

Outline is only updated if i switch to file 1 then back to file 2.

I tested also with PHP: Does not work there either.

Wait, it only happens if I open the file via nvim-fzf. It works with :e file2.php.

Yes, it only fails with https://github.com/junegunn/fzf.vim. I use this in a custom function to fuzzy search files.
I will investigate further.

it use the actually buffer number in that window ? not sure .

Hmm, when a file is openen with my fzf plugin it first goes back to the initial buffer, then switches to the new buffer:
So what happens is this:
[Lspsaga.nvim] there is no server attatched this buffer
bufenter 1
<--- fzf is opened here
bufenter 12  <-- buffer for fzf select
<--- file is selected in fzf here
bufenter 1 <-- triggers outline request
bufenter 13 <-- ... request for 1 is still active
[lspsaga.nvim] there is already a request for outline please wait

I don't know, why it first goes back to buffer 1 before going to the new buffer 13. Hmm.

buffer 1 has outline ?

Yes.
After 2nd file is opened I'm in buffer 13 and see outline of buffer 1. Then I do :bp and :bn. Now the outline for buffer 13 works.

i had update some patch for outline. you can test it.

It almost works now, thank you! 👍🏻
Minor issue:

:e file1
:Lspsaga outline
:e file2
:bd

I'm in an empty buffer now and have to :bp to get back to file1.
Note: I use nvim-dap which seems to create a couple of hidden buffers, even if inactive. Here's the output of :buffers1 after :bd:
:buffers!
  1 #h   "models/EventParticipant.php"  Zeile 30
  2u h   "[Notizen]"                    Zeile 0
  3u%a-  "DAP Breakpoints"              Zeile 1
  4u h-  "DAP Scopes"                   Zeile 0
  5u h-  "DAP Stacks"                   Zeile 0
  6u h   "DAP Watches"                  Zeile 0
  7u h-  "DAP Hover"                    Zeile 0
  8u h   "[dap-repl]"                   Zeile 0
 14u     "models/Event.php"             Zeile 1
 15u h   "[Notizen]"                    Zeile 0

So active buffer is 3 which is unlisted.

when you use bd the outline will close ? and I don't use that plugin.

Yes, outline closes. Only the wrong buffer is active (3 in the list above instead of 1). Shouldn't it ignore unlisted buffers?

authors: glepnir mikehaertl


text:
Weights for pre training

Do you have trained model weights? I would greatly appreciate it if you could provide it!

Can you implement and train the Fit Hubert model?

authors: HajarMazaheri NicholasLiuSc


text:
fix(std): export missing assertions in std.test

I forgot to export the ordering assertion functions in my previous PR.

bors r+

authors: Etherian Marwes

repo: gluon-lang/gluon


text:
GUAC-1172: Implement file browsing UI

This change adds a new file browsing interface, accessible by clicking on any drive listed within the new "Devices" section of the Guacamole menu. From within this interface, files can be downloaded individually or uploaded into the current directory.
The file transfer manager has been moved out of the Guacamole menu and into a dialog that appears only while transfers are in progress.

Now using an actual template and the $templateRequest service available as of Angular 1.3.x. Also took this chance to remove the old manual usage of $templateCache and $http that was added to replicate $templateRequest while using Angular 1.2.x (a7366e8).

repo: glyptodon/guacamole-client


text:
UIImage for each item?

Could we use image for each one?

hmmmm, and no answer...

I have been working on a solution that allows the consumer to create any kind of segments. An image-only segment is present there already.
I intend to merge it back to master as soon as I get image + text segments working.
https://github.com/gmarm/BetterSegmentedControl/tree/SegmentProtocol
Apologies for my very late answer!

Ok) Thanks you for answer)
пн, 2 квіт. 2018 о 12:15 George Marmaridis notifications@github.com пише:

Closed #58 https://github.com/gmarm/BetterSegmentedControl/issues/58.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/gmarm/BetterSegmentedControl/issues/58#event-1551700274,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AgJ9UwuhQQAX4y8WRmF7qaqhaPCvLizNks5tkewlgaJpZM4PMgEn
.

@gmarm image+text together would rule for segments. Just curious, how can we set just an image-only currently, since you mentioned in this thread that an image-only segment is present?

I just asked if it possible to set image
вт, 19 черв. 2018 о 00:02 morganmattr notifications@github.com пише:

@gmarm https://github.com/gmarm image+text together would rule for
segments. Just curious, how can we set just an image-only currently, since
you mentioned in this thread that an image-only segment is present?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/gmarm/BetterSegmentedControl/issues/58#issuecomment-398209977,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AgJ9Ux83EN2i0ldIrW6lGwE3eZHEk9w7ks5t-COKgaJpZM4PMgEn
.

authors: aloveric gmarm morganmattr yuratrotskyi

repo: gmarm/BetterSegmentedControl


text:
could test.sh operate in unprivileged mode?

since https://github.com/gmkurtzer/singularity/pull/159 is merged, I thought it would be nice to avoid sudoing while testing for various reasons ;)

I suspect we'd need a separate test.sh to avoid using sudo.
One problem we have is any use of raw disk images will require a setuid binary for the next year or so: you can only use chroot directories.

Not all of test.sh uses sudo, I'd suggest we just have a set of tests that are not calling sudo and operate on a directory in which the test image would be exported to.
A year? hehe, you are optimistic! I wonder if the loop devices would ever be namespaced. Have you heard anything on this?
Thanks!

I think that, once FUSE mounts are available to unprivileged users, then libguestfs would provide the ability to read/write the filesystem (alternately, fuseext may work).  Based on current progress, it seems reasonable to guess this would be available to mainline kernels within a year.  That would mean RHEL8 or so?
Looks like loopback device support would be feasible, but perhaps further out.

I am going to close this because I don't think there is much that can be done (at least not at present and/or for a while). Fuze integration does potentially offer a really good option if loop devices can not be made namespace-able. Feel free to comment to the thread if you feel I should re-open it.
Thanks!

authors: bbockelm gmkurtzer yarikoptic

repo: gmkurtzer/singularity


text:
Skip and Take throw Exception.

An exception is thrown when outside the bounds but that's a problem when using seq aiming for laziness, it will force you to check first the length of the sequence.
That's how they're implemented in F# but I prefer the Linq implementation which works as Haskell's drop and take, in those cases it returns an empty list which logically represents 'no results'.

The F# equivalent of Take from LINQ is called truncate that does not throw if the sequence has fewer elements than the specified count.

So, may be can we leave them as they are and add another 2 functions: drop and truncate with that (safe) behaviour.

I used the name Limit instead of Truncate because Truncate will conflict with the method of the same name for Numerics.

authors: atifaziz gmpl

repo: gmpl/FsControl


text:
🛑 Good News From Indonesia is down

In 0d1fc07, Good News From Indonesia (https://www.goodnewsfromindonesia.id) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Good News From Indonesia is back up in cf8fbbd after 10 minutes.

repo: gnfi/status


text:
🛑 GoodStats Data is down

In 97100b8, GoodStats Data (https://data.goodstats.id) was down:

HTTP code: 404
Response time: 795 ms

Resolved: GoodStats Data is back up in 21b173b after 46 minutes.


text:
🛑 Blog is down

In 13534c9, Blog (https://blog.goodnewsfromindonesia.id) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Blog is back up in 0a9eaed after 30 minutes.


text:
Fix code example mistake

What it solves
Resolves #97
How this PR fixes it
Replacing create with connect.

I have read the CLA Document and I hereby sign the CLA

repo: gnosis/safe-core-sdk


text:
🛑 Blockscout Explorer is down

In 7173997, Blockscout Explorer (https://blockscout.com/xdai/mainnet) was down:

HTTP code: 521
Response time: 205 ms

Resolved: Blockscout Explorer is back up in 5153222 after 12 minutes.

repo: gnosischain/gnosischain-uptime


text:
Disabling views - returning only JSON responses

Is it possible to disable the views parts after login, logout, etc. and just return a JSON response and let the web client handle the views itself?
Thanks

It's not actually possible in Authboss's current state. It's an unfortunate oversight. We really built it with the "Devise" solution in mind which is the views are done for you, etc.
Both myself and @kris-runzer agree that Authboss needs a refactoring to be able to pull out the various pieces: auth itself, token generation, views - into separate pieces. This would allow us to help out those with SPA-style pages as well as the server side rendering crowd. A much more take-what-you-need approach.
More unfortunate than having not made it that way in the first place, is that we don't have enough time to recreate Authboss in that image currently. That means; it's planned - but don't hold your breath :(

@aarondl is this still true today in v2?

@ernsheong Nope. Lots of the reason behind v2 was to absract the HTTP stack and let you make it behave as you want it to. Now it renders and responds how you tell it to in v2. There are interfaces in the config, namely:
authboss.Config.Core.ErrorHandler
authboss.Config.Core.Responder
authboss.Config.Core.Redirector
authboss.Config.Core.ViewRenderer

These control what gets back to the user's browser.
The defaults package implements many things that are JSON-aware including:

Renderer
Responder & Redirector

@aarondl thanks for the response!

authors: aarondl ernsheong o-r-r

repo: go-authboss/authboss


text:
allow to customize if the user is going to be signed in after confirm

this pr is related with the issue https://github.com/go-authboss/authboss/issues/123.
Now we can customize if we want our user being signed in after confirming his account

Hey @aarondl you made a good point and I've thought about it when I was working on it. Checking the tests I saw that we are checking some expectations in each method.  Like the func TestConfirm_Confirm has 6 expectations. In order to add the other case we would need to change it or duplicate the code. As I'm testing the critic point I'm comfortable letting the other untested for now, when we change the expectations we fix it. I can create an issue for it and work on it eventually
`

Thanks :)

authors: aarondl kaiomagalhaes


text:
Clarification on Middleware ordering

Ran into this today and it tripped me up.
// Admin routes
admin := fuego.Group(root, "")
fuego.Use(admin, auth.EnsureValidToken)
fuego.Use(admin, auth.IsAdmin)

Typically every other lib i've used when registering middleware they are invoked in the order they are registered. So for instance EnsureValidToken would be invoked first in the above example.
However, in the case of fuego this seems to be the opposite. In this case IsAdmin is invoked first. Is this intentional?
Current workaround is to just flip them of course. If it is a bug let me know I'd be happy to fix it. However,  you're probably gonna beat me to it 😄, by the time I get back to a computer.

This is unintentionnal, I must have missed the append order!
My project doesn't need ordering so I didn't catch it, thank you for noticing.
This should be an easy fix, but I would be happy to have a test case for it  :)

Cool, so whoever gets to it. Also ensure that group inheritance order is preserved as that's where I noticed it being the most detrimental.
Enjoy the weekend 😄

authors: EwenQuim dylanhitt

repo: go-fuego/fuego


text:
Invalid session expiration time

Gitea Version
release/v1.12
Git Version
2.31.0.windows.1
Operating System
windows
How are you running Gitea?
I built gitea on windows,it is runing from a command-line
Database
MySQL
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Description
my app.ini config:
[session]
PROVIDER = file
SESSION_LIFE_TIME = 30
When I log in to gitea and wait for 30 seconds, the session should have expired, but when I visit again, and there is no prompt to log in.
But when PROVIDER is set to memory, the login operation will be prompted.
Screenshots
No response

release/v1.12 is toooo old.
This bug should have been fixed in the latest release.
If you meet problem with the latest release, feel free to reopen the issue.

release/v1.15 also has this problem.
When PROVIDER is set to file, the login status is always valid and has nothing to do with the SESSION_LIFE_TIME configuration item

I cannot replicate this.
Please ensure that you've closed all the browser pages to ensure that the /user/events event stream is closed.

I cannot replicate this.
Please ensure that you've closed all the browser pages to ensure that the /user/events event stream is closed.

Yes, if the session is saved in a file, I need to log in again only after closing the browser.
If the session is stored in the memory, I don't need to close the browser, I have to log in again as soon as the session expires.
So when the session is saved in a file, the session expiration time seems meaningless.

I didn't say close the browser. I said close the browser pages to ensure that the /user/events eventstream is closed.
you can happily keep the browser open just not a gitea webpage.

我明白了，谢谢。

authors: wxiaoguang xingzhaowu zeripath

repo: go-gitea/gitea


text:
User or Admin can't see the private activity by yourself if logged

Gitea version (or commit ref): 1.0.0+149-g8bc43195
Git version:
Operating system:
Database (use [x]):

[x] PostgreSQL
[x] MySQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[x] Yes https://try.gitea.io/appleboy?tab=activity
[ ] No
[ ] Not relevant

Log gist:

Description
User or Admin can't see the private activity by yourself if logged but the dashboard is working.
Public activity:
https://try.gitea.io/appleboy?tab=activity

Dashboard:

...

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/41573611-user-or-admin-can-t-see-the-private-activity-by-yourself-if-logged?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github).

@lunny Please assigned to me.


text:
Try to prevent autolinking of displaynames in activation emails by email readers

Unfortunately many email readers will (helpfully) detect url or url-like names and
automatically create links to them, even in HTML emails. This is not ideal when
usernames can have dots in them.
This PR tries to prevent this behaviour by sticking ZWJ characters between dots and
also set the meta tag to prevent format detection.
Not every email template has been changed in this way - just the activation emails but
it may be that we should be setting the above meta tag in all of our emails too.
Signed-off-by: Andrew Thornton art27@cantab.net

Questions:

Do we need to add the meta tag to the rest of the templates?
Should we be doing more dot escaping elsewhere in the emails?
Should we strip out ZWJ from usernames posted in to login forms? (My suspicion is that the number of users affected here will be so so small that it might not actually be worth implementing that.)


text:
Fix task list checkbox toggle to work with YAML front matter (#25184)

Backport #25184 by @jtran
Fixes #25160.
data-source-position of checkboxes in a task list was incorrect whenever there was YAML front matter.  This would result in issue content or PR descriptions getting corrupted with random x or space characters when a user checked or unchecked a task.

duplicated with #25227

authors: GiteaBot lunny


text:
full directory support for wiki

directory support for wiki
previously this was part of #7225 - lets split it up
This PR

add support for directories inside wiki. Create/update/delete pages works well. If an old page is updated, the file will be moved to subdirectory.

allows to read files with nearly all letters, as it is possible to push all via wiki gitrepo

files can exists in old and new structure.

files are selected by link, so it is possible to access and view both
writing to one of them will delete both, and create new one in directory structure
delete will delete the selected file

support images relative to directory path

fix preview on preview rendering

fix 500 error if wiki contains pages with invalid uri encoding (e.g. filename: badescaping%%.md)

ui fixes

add button 'Abort' to wiki edit and new page

fix #823
Signed-off-by: Michael Gnehr michael@gnehr.de

Codecov Report

Merging #7390 into master will increase coverage by 0.03%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #7390      +/-   ##
==========================================
+ Coverage   41.19%   41.22%   +0.03%
==========================================
  Files         469      469
  Lines       63536    63635      +99
==========================================
+ Hits        26171    26235      +64
- Misses      33943    33970      +27
- Partials     3422     3430       +8

Impacted Files
Coverage Δ

modules/markup/markdown/markdown.go
80.95% <ø> (+2.24%)
:arrow_up:

routers/routes/routes.go
82.38% <100%> (+0.02%)
:arrow_up:

routers/repo/wiki.go
40.95% <55.35%> (+0.07%)
:arrow_up:

models/wiki.go
59.72% <72.63%> (+2.84%)
:arrow_up:

models/unit.go
62.16% <0%> (-5.41%)
:arrow_down:

models/repo_list.go
73.09% <0%> (+1.01%)
:arrow_up:

modules/log/event.go
65.64% <0%> (+1.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c3f749...d10e0fd. Read the comment docs.

Please resolve the conflicts

Please resolve the conflicts.

@Cherrg

Well, this is frustrating, would really appreciate this feature. :( To bad I'm not proficient at Go.

This PR has been stale for long time, and the Wiki Title problem has been improved by https://github.com/go-gitea/gitea/pull/24143
Would there be new progress of this PR?

It has been stale for a long time and I can't think of a way to handling it other than closing it. Feel free to reopen if there's any new progress and I could also help.

authors: Cherrg codecov-io ferrydeboer gsantner lunny wxiaoguang


text:
关于自动 预加载，可以支持 隐式加载数据？

Describe the feature
默认不加载关联数据，当需要关联数据时，自动读取数据到关联目标，
user{
id int
name string
avatars []avatar
}
例如
user := user{}
db.find(&user)
我们可以在 获取 user.avatars 时读取数据 ，从数据库加载或内存

http://v2.gorm.io/docs/preload.html

authors: jinzhu ufowiner

repo: go-gorm/gorm


text:
use micro.Server(gsvr.NewServer()),an error occurred

Describe the bug
errer :
../../pkg/mod/github.com/asim/go-micro/plugins/server/grpc/v3@v3.7.0/grpc.go:401:6: undefined: logger.Extract
code here:
package main

import (
	"hero/handler"
	pb "hero/proto"

	gsvr "github.com/asim/go-micro/plugins/server/grpc/v3"
	"github.com/asim/go-micro/v3"
	log "github.com/asim/go-micro/v3/logger"
)

var (
	service = "hero"
	version = "latest"
)

func main() {
	// Create service
	srv := micro.NewService(
		micro.Server(gsvr.NewServer()),
		micro.Name(service),
		micro.Version(version),
	)
	srv.Init()

	// Register handler
	pb.RegisterHeroHandler(srv.Server(), new(handler.Hero))

	// Run service
	if err := srv.Run(); err != nil {
		log.Fatal(err)
	}
}

You're using micro v3, which is not supported anymore. Please use micro v4.

Upgrade github.com/asim/go-micro/v3 to v3.7.1

authors: Davincible suxing9980 xpunch

repo: go-micro/go-micro


text:
added method DiscoverSQLMigrationsFromFilesystem

In our project we are using vfsgen for embed static content like go templates and database migrations. Unfortunately go-pg migrations only supports the os filesystem and the files have to exist on production systems. We took a look around for other migration frameworks but decided to add the vfs feature to go-pg because its already running and we also like to work with the orm.
Changes:

added method DiscoverSQLMigrationsFromFilesystem(fs http.FileSystem, dir string) which we can use with a filesystem generated by vfsgen
the file contents also loaded using the given fs instead of os.open

In the testcase you can see some generated code by vfsgen which is used for discover the SQL.
Thanks in advance,
Stephan

@vmihailenco, @smcdonald45, I think this could fix my problem #73, who can merge it?

Thanks - this looks good. I will try to merge this tomorrow. Sorry for delay.

repo: go-pg/migrations


text:
New feature: Top level short hand declaration.

Top level short hand declaration can make declaration much cleaner and better readability.
Here are two examples for comparison.
// Without top level short hand declaration.
package foo

const Foo = int64
var Bar = Foo(10)

And
// With this new feature.
package foo

Foo := int64
Bar := Foo(10)

// Even shorter.
Foo, Bar := int64, Foo(10)

I take a look again this feature design and have a different decision now.
The top level declaration is not a must-have for generic types. I'll support it in Rat parser as a special mode but drop the design in Rat language.

repo: go-rat/language-design


text:
update时使用AllCols()的method仍然没有更新空值的field

插入如下数据:
{
   "userid":1,
    "name":"Scofield",
   "age":0,
   "sex":"male"
}

代码:
engine.Id(user.Userid).AllCols().Update(&user)

生成的sql
update `user` set `name`="Scofield",`sex`="male" where `userid`=1

其中age=0的更新被忽略

user 是一个map？@scofieldpeng

不是,一个struct

我测试了，没有发现这个问题。。。

好的,那我下班回家在看看代码,麻烦肖大哥了:-)

先关闭了，如果有进一步消息请打开。

authors: lunny scofieldpeng

repo: go-xorm/xorm


text:
Packr with external module?

I have a module A which contains a static HTML page with some CSS/JS. I'd like to import A from a separate golang project (call it B), and be able to serve the same HTML/CSS/JS from B.
Currently this doesn't seem to work - is there something I'm missing?

@bobby-brennan I wasn't able to replicate this... I created a moduleA repo here: https://github.com/timraymond/moduleA which is what I think you're trying to do. I was able to import this and read the contents of templates in moduleA.
Maybe I'm not following. Could you provide a small reproduction test case and the error that you're seeing to help debug this?

I think I've gotten this working in packr2 - will reopen if I run into the issue again.
Thanks!

authors: bobby-brennan timraymond

repo: gobuffalo/packr


text:
Do you have a quickstart example?

Hi there, this seems lovely but I couldn't manage to run it for a simple analyze of a SELECT 1 query in a custom golang program, would you be able to add a quickstart program in the readme to show how it is being used? Thanks!

go-zetasql still only supports parser feature. The analyzer is currently under development. See parser_test.go for how to use parser

thanks a lot, I'll start playing around with it. One of the problems I am having is to figure out what types would I get in the parsed result, and since there are many methods and types with similar name it seems to be a guessing game for now for me, would you have any recommendations about how to learn more about them?

You can either print the type with %T or look it up with ast.Walk . Example is here https://github.com/goccy/go-zetasql/blob/8607e154d95576c8e69567c61fc647bb8bf1b99f/parser_test.go#L74-L77

thanks a lot, I appreciate it, have a lovely day!

authors: goccy karakanb

repo: goccy/go-zetasql


text:
How would I pass a HTMLElement to a Collector like .visit()?

TLDR: How would I pass a HTMLElement to a Collector? Instead of asking it to visit a URL?
cases.OnHTML("div.col-result", func(e *colly.HTMLElement) {
	log.Println("Case result found:", e)
	// This is something I want!
	case_detail_link.pass_html_to_collection(e)
})

//case_detail_link is a collector
case_detail_link.OnHTML("a.cta-primary", func(e *colly.HTMLElement) {
	log.Println(e.Attr("href"))
})

"Why do you want it this way? Why not just...":
Hey I totally get it. I could simply just have the 2nd collector logic embedded in the first cases.OnHTML call.
However, because I am toying around with the idea of doing building JSON config files in real time into colly-based executables, I think this is a behavior I need to make it work.

cases.OnHTML("div.col-result", func(e *colly.HTMLElement) {
	log.Println("Case result found:", e)
	e.ForEach("a.cta-primary", func(_ int, e *colly.HTMLElement) {
		log.Println(e.Attr("href"))
	})
})

is this what you're trying to do?

cases.OnHTML("div.col-result", func(e *colly.HTMLElement) {

	log.Println("Case result found:", e)

	e.ForEach("a.cta-primary", func(_ int, e *colly.HTMLElement) {

		log.Println(e.Attr("href"))

	})

})

is this what you're trying to do?

Yes it is. I am grateful for your time to write it out. However, as I said in the "why not..." section, because I have a specific agenda in mind, I wonder if it is possible to feed the HTML to another collector.

authors: WGH- winston-bosan

repo: gocolly/colly


text:
needs a way to save your high score

What's an endless runner game without a high score?

do you mean to keep it saved while the game is running (game.gd) or to persist it on the players device memory?

I added non-persistent high-score tracking.
I considered saving a file to user://, but that would just cruft up people's user directory for no good reason.

authors: kvonspiczak plexsoup


text:
Add is_instance_valid to GDNative

ff1e7cfbf4b7ad9b327588ce7dffb43d31fee3e9 added is_instance_valid to GDScript, but GDNative users may also need it.

Fixed by #21602.

authors: akien-mga endragor

repo: godotengine/godot


text:
Rigidbody2d bouncing around

Using the current version on steam, 3.0.6 i think, windows 10 with latest updates.
https://mega.nz/#!DZ8ixSBC!moDkQ8eIqZL3_aMrbt8NnT4evxMbackH4UFIDzFBHbk
I created a rigidbody2d, instance it 3times on top of eachother, and they starting bouncing/vibrating randomly.
They are on top of a tilemap, but its the same if they are on top of a static body.
platformer_slash_folder.zip

I can't reproduce on master.
@AndreaCatania was this fixed already ?

I couldn't reproduce on master either, but found annoying that the character can't slide along the floor smoothly without some minor vertical bumping, perhaps RayShape2D should help.

I don't know, I didn't touched physics 2D

I don't know, I didn't touched physics 2D

Arf... indeed. Sorry for that ^^

Seems to work fine in the current master branch (or I don't understand how to use the MRP to trigger the issue - I just piled a few players on top of each other).

authors: AndreaCatania Xrayez akien-mga groud indiemaniac


text:
Implement automatic word wrap based on Line Lenght Guideline

Godot version:
3.1
OS/device including version:
Windows 10 x64
Issue description:
The current Word Wrap option (Editor > Editor Settings > Text Editor > Line Numbers > Word Wrap) is currently wrapping only based on the text editor window size.
It would be useful if there is an option to wrap based on the Line Lenght Guideline Column option  (Editor > Editor Settings > Text Editor > Line Numbers > Lenght Guideline Column)

But why? The purpose of word wrap is to make long lines fully visible. Why make that space even smaller? Especially since you are not supposed to go past guideline column at all.

If I want to ensure that my text never exceeds 80 columns, it would be useful to break the line on the Guideline length.
See this behavior in PyCharm:

Then it's not a standard word wrap, because word wrap is only visual. Doing automatic line breaking is more difficult, because you can't start a newline anywhere.

@KoBeWi The issue is asking for word wrap on the line length guideline, similar to the one made for end-of-line. It is not asking for automatic insertion of newlines.

In fact, the example was not good.
The idea is just the visual break, you do not need to create a new line.
The main purpose is to have the entire line visible within the max column limit defined by the Guideline.

But you see when your text crosses the line :/
And if it's only visual then you'd have to break the line yourself if you don't want to exceed the limit.
Anyways, IMO it's only limiting the available space, because you are loosing what is between the line and editor width. I just don't see how could that be useful.

So let's back. In the Pycharm example above, the line was automatically broken based on these parameters:

My proposal is to let the user decide if he wants to break the line manually or automatically, based on these parameters.

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.
The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.
If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!

authors: KoBeWi bojidar-bg clayjohn rogeriodec


text:
3.2 BETA 6 - Major Editor Viewport Performance Degradation

Godot version:
3.2 BETA 6
OS/device including version:
Windows 10 Pro 1903
GPU: NVIDIA GeForce GTX 1070
Primary Display: 2560x1440 @ 144Hz
Secondary Display: 1920x1080 @ 60Hz
Issue description:
When using Godot 3.2 Beta 5 projects maintain at or near 144 FPS (6.94 ms) in the editor viewport while moving the camera. When opening (or creating) a project in Godot 3.2 Beta 6 the editor viewport performs at around 72 FPS (13.89 ms) while moving the camera. The problem appears in both brand new projects and project templates.
This is not an error with the FPS readout because the difference in performance of the editor is visually discernible without the aid of an FPS overlay.
Steps to reproduce:

Create a new project in Godot 3.2 Beta 6.
Toggle the editor viewport FPS display via the perspective menu (i.e. "Perspective->View FPS") in the viewport.
Note the lower performance when compared to performing the same steps for Godot 3.2 Beta 5 or Godot 3.1.2.

Note: You may not be able to reproduce this issue without a monitor with a 120Hz or higher refresh rate.

I did some digging around in other beta 6 issues and found the cause of this problem. It looks like it's related to #34968 and having sync_via_compositor enabled in projects. This settings also seems to become enabled automatically for beta 5 projects at are opened in beta 6.
If you turn off Vsync Via Compositor under Project Settings->Display->Window and restart the editor then your viewport performance will be fixed.

Looks like this is a duplicate of https://github.com/godotengine/godot/issues/35038 then. Closing in favour of https://github.com/godotengine/godot/issues/35038.

@Jakob-PB Does setting "Vertical sync" to "Use the 3D application setting" in the Nvidia control panel fix your issue?

@hoontee For me vsync was already set to "Use the 3D application setting" in the Nvidia control panel.
I tested the other vsync settings and both "on" and "adaptive" seem to help the issue while Vsync Via Compositor is on although there is a performance impact (I'm at around ~122FPS or ~8ms in an empty scene so I'm losing about 20 frames/1 millisecond to something). I disconnected my second monitor while testing this just to make sure it's not a factor.
The most optimal setting combination in terms of performance is still vsync set to "Use the 3D application setting" and Vsync Via Compositor off.

@Jakob-PB Just to be clear, what settings are causing you to get halved framerate when vsync_via_compositor is enabled?

@Jakob-PB Just to be clear, what settings are causing you to get halved framerate when vsync_via_compositor is enabled?

Use the 3D application setting
Off
Adaptive (half refresh rate)
Fast

@Jakob-PB I've made a few fixes to the PR. Replace platform/windows/context_gl_windows.cpp with this file and recompile:
context_gl_windows.zip
It will also now tell you in the console if it detects any discrepancies with the graphics driver ("VSYNC FORCED ON", "VSYNC FORCED OFF", "VSYNC FORCED OTHER"). Use this to aid in further testing.

@hoontee Recompiled and I'm seeing the same performance results I reported on earlier.
Not sure if this is useful information but I retested with all Nvidia vsync settings and I could never get VSYNC FORCED OFF to show up (I would assume it would show up when I force vsync off in the control panel). However, VSYNC FORCED ON and VSYNC FORCED OTHER showed up as expected for vsync set to On and Adaptive respectively.

@Jakob-PB I'm perplexed.
For both of the devices I've tested (AMD & Nvidia), halved framerate only occurred when vsync was forced (On or Adaptive) in the graphics driver settings. The PR fixed it for both devices.
For you, halved framerate occurred in every situation except when vsync was forced (On or Adaptive) in the graphics driver settings. The PR did nothing.
The only thing that makes sense right not is VSYNC FORCED OFF not showing up - the PR doesn't detect a discrepancy because vsync_via_compositor technically disables vsync. If vsync_via_compositor is disabled, the message appears.
The only thing I could think of you doing at this point is going through every graphics driver setting and recording what's not set to default.

@hoontee Just went through the settings and looks like everything is default except "Monitor Technology" is set to "Fixed Refresh" instead of "Gsync Compatible". I restored all the Nvidia settings to default just to be sure and after a restart I'm still seeing the same behavior.
I'm on driver version 441.87 (the latest of the game ready edition) and Windows version 1903. Perhaps something changed in the new 1909 update or in a driver update?
I'm also going to try to get in touch with a friend who I know also has an Nvidia card and a 144Hz monitor.

authors: Jakob-PB clayjohn hoontee


text:
OS.window_fullscreen causing input latency

Godot version:
v3.2.beta2
OS/device including version:
Windows 10
Issue description:
I was trying to debug input latency in my game and noticed that there were 3-5 additional frames while vsync was enabled.
After some more testing I found that there was only 1 extra frame if project setting display/window/size/fullscreen was set to false (or OS.window_fullscreen = false)
Steps to reproduce:
Run project with fullscreen option off and on to compare input delay.
I recorded the project running with screen capturing software and a key overlay so I could count frames between keypress and when the action was applied.
Minimal reproduction project:
input_latency_test.zip
Press W to toggle/test input latency

Can anyone still reproduce this bug in Godot 3.2.3 or any later release?
I tried the project and don't see anything wrong. Windows 10.

I tested again last night and saw the same results as in the initial issue description.
To add a little more info I found my GPU settings and confirmed that triple buffering is disabled. I can't see any other obvious settings that might have helped here.
Is it correct that Godot does not use Windows exclusive fullscreen? I've heard that this can help avoid any input latency introduced by the compositing process.
On a related note, is it just me or is turning Vsync off mostly pointless? (Without a good way to limit the framerate)
I suppose there is a scenario where someone might want their game to process thousands of times per second but it seems unlikely most of the time.

Is it correct that Godot does not use Windows exclusive fullscreen? I've heard that this can help avoid any input latency introduced by the compositing process.

Indeed, Godot doesn't use exclusive fullscreen. That said, Windows 10 is supposed to be smart about this and avoids adding latency when using a borderless window.

@benbishopnz Can you (or anyone else) still reproduce this bug in Godot 3.4.4 or any later release?
If yes, please ensure that an up-to-date Minimal Reproduction Project (MRP) is included in this report (a MRP is a zipped Godot project with the minimal elements necessary to reliably trigger the bug). You can upload ZIP files in an issue comment with a drag and drop.
PS: Godot 3.x only uses exclusive fullscreen if the window size is equal to the screen size, and if Borderless is unchecked in the project settings.

Closing due to lack of response. Please comment if you can still reproduce this bug.
PS: If no minimal reproduction project was included in the original bug report, please upload one as well to ease troubleshooting.

authors: Calinou KoBeWi benbishopnz


text:
GPU Driver crash on GLES 3 on Geforce 210

What hardware I have?

Geforce 210

What's my issue?

Windows and Windows manager crash if you switch to the GLES 3 mode or create a GLES 3 project.

What version

It keeps happening since 3.2

Sorry to say, the Geforce 210 is way too low end to support the GLES3 renderer. Its a 12 year old GPU it was nearly their lowest-end card back then.
We have GLES2 so that we can support such old hardware. If you want to run the engine, you will have to use the GLES2 backend.
That being said, it should not be crashing windows under any circumstances. When Windows crashes, do you have to do a full reboot to get things back?

I have the same card test, this creates a new project with gles3 and tests with this configuration

@clayjohn  The issue isn't really that my card can't run GLES 3, is fine if godot GLES 3 can't be run with it.
The issue I am reporting is that it causes my GPU windows driver to crash and reboot.
On Linux (Lubuntu) It produces a hard crash that makes the session of the user to close.

Are you able to capture any errors printing out when that happens? It is extremely uncommon for a GPU driver to completely crash a system like that.
Please also try updating to the newest drivers provided by NVidia if you are not already using them.

@clayjohn I can't catch errors because it goes directly into black screen.
Also I'm using Windows 10 x64 and using the drivers that are installed by the OS.
As such I'm using Version 341.74 of Geforce 210 drivers.

Are those the latest drivers available?

The latest drivers for that chipset are 342.01: https://www.nvidia.com/Download/driverResults.aspx/112596/en-us
Might be worth an update, even though it's no guarantee that it will fix anything.

The issue I am reporting is that it causes my GPU windows driver to crash and reboot.
On Linux (Lubuntu) It produces a hard crash that makes the session of the user to close.

If it crashes both on Windows and Linux in a way that makes the user environment or kernel bail out, that sounds like hardware failure to me. It's unlikely that different drivers would fail the same on Windows and Linux, so it must be a hardware problem (Godot itself is too high level to crash your system).

I can confirm the error (Godot 3.2.1 + GeForce 210, driver version 342.01).
Notes:

Godot 3.1.2 does not crash the system even though GLES3 is used.
Out of several attempts only one didn't end up with system crash (black screen). For that single event in Windows Event Viewer I can find related entry: The NVIDIA OpenGL driver detected a problem with the display driver and is unable to continue. The application must close.

I'm also experiencing this issue.
System Info

OS: Windows 7 Ultimate Service Pack 1 (64-bit)
Graphics Card: 256MB NVIDIA GeForce 8400 GS (ZOTAC International)
Graphics Driver: 342.01-desktop
Godot Version: v3.3.2.stable.official (win64)

From Godot console:
Godot Engine v3.3.2.stable.official - https://godotengine.org
OpenGL ES 3.0 Renderer: GeForce 8400 GS/PCIe/SSE2
OpenGL ES Batching: ON

Issue
Same as in the original issue.
Screen goes black and loses connection with the monitor when:

Starting a new project in Godot using GLES 3 (the default setting).

Opening a Godot project which uses GLES 3.

Running a project exported by Godot that uses GLES 3.

The first time I encountered this issue, I had an error pop up:

The NVIDIA OpenGL driver lost connection with the display driver due to exceeding the Windows Time-Out limit and is unable to continue.
The application must close.
Error code: 7
Would you like to visit http://nvidia.custhelp.com/cgi-bin/nvidia.cfg/enduser/std_adp.php?p_faqid=3007 for help?

Since, I have not been able to get the error to appear again. It now only cuts to black and must be restarted by toggling the power.
GLES 2 works perfectly.
Expected Behavior
An error message stating that the program cannot run because GLES 3 is incompatible with the system's graphics card, then gracefully quit without crashing the graphics driver.
Current Workaround
Use GLES 2.
An existing project cannot be changed to GLES 2 through the editor, because opening the editor will cause the crash. Instead, edit the project.godot file directly with a text editor. Find the section [rendering]. Beneath it, add the line quality/driver/driver_name="GLES2" and save the file.
Now the project can be opened in Godot.
Comments
Of particular concern to me is that it can affect anyone who even runs a game created with Godot.
The workaround is necessary to complete the official tutorial which uses projects that are set to GLES 3. This could discourage new users.

The workaround is necessary to complete the official tutorial which uses projects that are set to GLES 3. This could discourage new users.

The documentation should be changed to link to https://github.com/godotengine/godot-demo-projects/releases/download/3.3-2d4d233/2d_instancing.zip instead. The project now uses GLES2, like all demo projects that don't require GLES3 features to have their expected visuals.

@Lemntum  I had the same problem with my video card. I came to this page by searching Google. I couldn't open the 3d tutorial made with gles3 on the github page because of this problem. Thanks.

authors: Calinou Lemntum akien-mga ca3games clayjohn matiashak maxiproduksiyon585 tomsiw


text:
Help window closes when filter is selected

Godot version:
4.0.dev.calinou.fafb0ba06
OS/device including version:
Kubuntu 19.10, KDE Plasma 5.16.5
Issue description:
Help window closes when filter is selected.
Steps to reproduce:

Minimal reproduction project:
—

For me this also happens randomly with other types of windows on Ubuntu 19.10

I am confirming the same with Scene/Recent files submenu - as soon as I am hovering over it, full menu hides. Build from master, Fedora 31

I have found this happens on "Project -> Tools -> Orphan Resource Explorer" dropdowns too. Project dropdown closes when hovering Tools.
Probably with any type of popup and those that inherit it.
Being the same issue as #37732, this could be a functionality programmed to allow closing dropdowns when changing the focus inside the editor and had unintended consequences like messing up all popups.

authors: dalexeev dreamsComeTrue giarve qarmin


text:
GDScript null deref when a script member has a resource type

Godot version:
f733746
OS/device including version:
Fedora 32
Issue description:
When you have a GDScript with a variable that has a variable with a resource type, like the following:
extends Node
class_name MyClass

var variable: MyResource = MyResource.new()

func test(variable: MyResource):
	pass

The script_type is dereferenced, when it's nullptr https://github.com/godotengine/godot/blob/master/modules/gdscript/gdscript_function.h#L145
This fixes the issue, though I'm not sure it's the proper fix:
@@ -141,8 +141,13 @@ struct GDScriptDataType {
                                } break;
                                case SCRIPT:
                                case GDSCRIPT: {
-                                       info.type = Variant::OBJECT;
-                                       info.class_name = script_type->get_instance_base_type();
+                                       if (script_type == nullptr) {
+                                               info.type = Variant::NIL;
+                                               info.usage |= PROPERTY_USAGE_NIL_IS_VARIANT;
+                                       } else {
+                                               info.type = Variant::OBJECT;
+                                               info.class_name = script_type->get_instance_base_type();
+                                       }
                                } break;

Minimal reproduction project:
TestCrash.zip

This crash happens only when you start the project. While you create it, the crash doesn't happens, but it will be if you just reopen the project.

@AndreaCatania Would it be possible to test this on a recent build (e.g. from hugo.pro) or explain the precise reproduction steps?
I wasn't able to reproduce a problem with the latest build of godot 85186bc) but I'm not sure what to look for. There doesn't appear to be any crash. I'm on Windows 10.

authors: AndreaCatania lyuma