text:
Win7 Pro 32bit 6.1.7601.24520 says fully supported, but only 2 concurrent RDP allowed

As in the title, I cannot connect more than 2 users at a time. Running Win7Pro 32bit, rdpwrap.ini after installation was partially supported, updated to include
[6.1.7601.24402]
SingleUserPatch.x86=1
SingleUserOffset.x86=1A675
SingleUserCode.x86=nop
SingleUserPatch.x64=1
SingleUserOffset.x64=17F26
SingleUserCode.x64=Zero
DefPolicyPatch.x86=1
DefPolicyOffset.x86=19E41
DefPolicyCode.x86=CDefPolicy_Query_eax_esi
DefPolicyPatch.x64=1
DefPolicyOffset.x64=17CFE
DefPolicyCode.x64=CDefPolicy_Query_eax_rdi
and since then it says it's fully supported, yet I am limited to 2 users concurrently.
I was hoping someone can give me a solution.
Cheers

Hello,
Sorry for my English.
I have the same problem. Windows 7 32bit. Updated RDPWrap ini for full support. It accepts only two RDP connections and one local. Other than that it doesn't connect anymore.
I did the test, removed the RDPWrap, installed the "Concurrent RDP Patcher" patch from raymond.cc. And the same thing happens.

This problem occures when you use other RDP software like teamviewer

authors: eiol kartman85 sebaxakerhtc


text:
Save pointcloud to any user-chosen directory

User should have a way to save pointclouds in any directory available to write

Fixed - now user can choose a directory and save all the visible pcd files.

source: gharchive/issue

license_type: permissive

license_source: github-api


text:
Decommision Devise Turbo hacks once an official solution is in place

Now that Devise has released version 4.9.0.
See pull request heartcombo/devise/#5548 for update,  as well as issues #14 and pull request #17 on this repo.
The Devise wiki has an upgrade guide.

Resolved by #41

license: Unlicense


text:
Fast Refresh blocks machine definition updates when using useMachine+@xstate/inspect

Description
This is an issue I've been noticing for awhile that I finally tracked down to what appears to be the react version being used. For the longest time when using @xstate/inspect with React, @xstate/inspect wouldn't update when I'd save changes to the machine. I had to manually refresh the entire CodeSandbox and allow it to open a new inspector window to see any updates.
Expected Result
When saving changes to a machine being used with useMachine(machine, {devTools: true}), the inspector updates to show the changes.
Actual Result
The inspector doesn't update when I save changes to the machine.
Reproduction
Both of the following CodeSandbox examples are identical except for their react and react-dom versions. Both use the latest versions of xstate, @xstate/inspect, @xstate/react, and react-scripts.
Working CodeSandbox: https://codesandbox.io/s/lucid-ellis-vsn3x?file=/src/App.js
This example is using react@16.8.6 and react-dom@16.8.6. When you save changes to toggleMachine, the inspector correctly updates the machine. You can see the inspector page refresh entirely and afterwards the updated machine is shown.
Broken CodeSandbox: https://codesandbox.io/s/serene-butterfly-y120n?file=/src/App.js
This example is using react@16.9.0 and react-dom@16.9.0. When you save changes to the machine in this example, the inspector does not update. You can see the machine title (toggle (x:1)) flash very briefly when you save, but the inspector page doesn't refresh and no changes are shown.
Additional context
I tried to run both of these locally to see if the issue is particular to CodeSandbox and interestingly enough, the broken example is broken in the same way, but the example that works in CodeSandbox doesn't work at all locally. The machine title doesn't even flash. I'm really not sure what to make of that.

This might be a problem with our use of useConstant(...) to create the machine (cc. @Andarist) - it holds a (potentially lazy) reference to a machine that lives forever, even through fast refresh, apparently.
This also might leak into the other problem re: changing the machine passed into useMachine(machine), and what the expected behavior is there. Currently, we ignore any new machines.

This might be a problem with our use of useConstant(...) to create the machine (cc. @Andarist) - it holds a (potentially lazy) reference to a machine that lives forever, even through fast refresh, apparently.
This also might leak into the other problem re: changing the machine passed into useMachine(machine), and what the expected behavior is there. Currently, we ignore any new machines.

Yep - this is an issue with Fast Refresh itself. It's currently broken in multiple ways with how useMachine works - adding @xstate/inspect into the mix only makes things worse.
The ideal fix for us would be if we could detect that Fast Refresh is happening so we could handle this in a special manner during dev environments. I'll be trying to chat with React team about exposing this information on the Fast Refresh runtime.

Yep - this is an issue with Fast Refresh itself. It's currently broken in multiple ways with how useMachine works - adding @xstate/inspect into the mix only makes things worse.
The ideal fix for us would be if we could detect that Fast Refresh is happening so we could handle this in a special manner during dev environments. I'll be trying to chat with React team about exposing this information on the Fast Refresh runtime.

This also might leak into the other problem re: changing the machine passed into useMachine(machine), and what the expected behavior is there. Currently, we ignore any new machines.

@Andarist Is the ideal to not ignore new machines, but replace/update them? In product, this wouldn't typically happen (unless there's a dynamic state generator?), but updating when machine definitions/references change would be least surprising, right?

From our PoV the machine definition is/should be static and we treat it as such. It's like a formalized behavior of your component and that shouldn't generally be dynamic. There are uneasy questions that would have to be answered to allow for this (for example - what happens with currently invoked services?) and we don't really think that those are valid questions to ask in the first place.
It's also not like this is creating precedence - those are already there 😅 Just think of useMachine as of useState's initializer function. Changing it won't affect your state anyhow, right? 😉

I believe that the situation around this got substantially improved by https://github.com/statelyai/xstate/pull/4436 for the upcoming v5 release
The inspector might still need some follow-up work to handle this properly but I think that the "core" issue has been solved and that we can track further improvements separately.

authors: Andarist davidkpiano ericclemmons with-heart

repo: statelyai/xstate

license: MIT


text:
Oppdatert versjonsnummer til 0.10.1

PR Notes

[ ] Have set labels for release level

Oppdatert dokumentasjon for XSD

source: gharchive/pull-request

repo: statisticsnorway/kostra-barnevern-xsd


text:
Dedupe logic for both server and client

Added a Dedupe test to verify the numbers are good when concurrently calling logEvent

Closing in favor of the private PR

authors: daniel-statsig vijaye-statsig

repo: statsig-io/dotnet-sdk

license: ISC


text:
Segfault on second getMessage() call after EAGAIN error

The handler (with getMessage()) where this happens is: https://github.com/status-im/nim-eth-p2p/blob/master/eth_p2p/discovery.nim#L243
I think segfault will occur because of following flow:

Error (EAGAIN in this case) occurs on recvfrom in readDatagramLoop and setReadError is ran.
A raise transp.getError() is done in getMessage or peekMessage in  the transport function (see handler above).
Next time the handler is ran for this DatagramTransport the segfault will occur at getMessage.

Why EAGAIN happens, I don't know.
So far, I can only reproduce this (not 100% of the time) by running: https://github.com/status-im/nim-eth-p2p/blob/master/tests/tshh_connect.nim
This was tested only on a Linux x86_64 machine.

I need to understand when EAGAIN happens, at the end or in process?

in process, the err var here contains it:
And then it gets raised by the getMessage call in the handler. The segfault happens only later on a second getMessage.

But why you are trying to perform one more getMessage()?

I don't. It gets called automatically by the handler on next data received by same DatagramTransport.

I think I found the root cause of my EAGAIN error. It is due to a poll() in an async proc (which is not nice anyhow, but that was not the point).
If you look at the poll() code it makes sense that this can happen, although it requires some conditions.
A "normal" poll() which adds the async proc with the poll() inside to the callbacks and next also the readDatagramLoop handler on an Event.Read . processCallbacks must run first the async proc with poll(). Next in that poll again Event.Read for same socket, processCallbacks runs again, both callbacks are run ... et voila, EAGAIN
So I guess this can be closed, but perhaps some documentation could be added that this should not be done.

authors: cheatfate kdeme


text:
Exception ao gerar etiqueta para postagem Sedex 10 (40215)

Boa tarde, alguém mais está tendo problemas pra gerar etiquetas Sedex 10 (Código 40215) ?
Meu PHP cospe o seguinte exception:
Parse error: syntax error, unexpected ';', expecting ')' in /vendor/stavarengo/php-sigep/src/PhpSigep/Pdf/Script/CircularText.php on line 18
A linha mencionada contém o seguinte trecho de código:
for ($i = 0; $iMax = strlen($text); $i < $iMax; $i++) {
Que poderia ser modificada para:
for ($i = 0; $i < strlen($text); $i++) {
A linha 37 também possui o mesmo trecho.
Estou usando PHP 7.0, instalação foi feita via composer (stavarengo/php-sigep-fpdf e stavarengo/php-sigep branchs master). A geração de etiqueta foi feita usando os arquivos de exemplo.
O mais estranho é que o problema não ocorre no site de demonstração do projeto.
Uma dúvida fora da issue. A lista de serviços de postagens utilizada no site de demonostração é bem menor do que a lista de serviços contidas em \PhpSigep\Model\ServicoDePostagem.
Depende do contrato com os correios ou existe algum outro motivo?

@rblaurin Pode verificar? Pelo visto esse erro está sendo causado pelos seus últimos PR #373 e #374

Addendum: Ao utilizar a chancela sedex-2016 \PhpSigep\Pdf\CartaoDePostagem::TYPE_CHANCELA_SEDEX_2016, o problema não ocorre.
Utilizar a chancela sedex (\PhpSigep\Pdf\CartaoDePostagem::TYPE_CHANCELA_SEDEX) o problema está sempre ocorrendo.

@rdvetromilla Respondendo a sua dúvida: alguns serviços são exclusivos para certos tipos de contratos. No caso do site de demonstração, acho que o @stavarengo optou por somente colocar os mais comuns.

Entendido, obrigado @andersonls

Pessoal vou fechar a issue pois utilizar a chancela mencionada resolve a situação perfeitamente.

authors: andersonls rdvetromilla

repo: stavarengo/php-sigep

license: mit

license_source: bigquery


text:
Using stdlib behind corporate proxy

Hi, I'm trying to install and use stdlib on a computer behind our corporate proxy and I was able to get it installed by changing my npm proxy settings, but when trying to log in with my stdlib credentials, I get an error that says Error: Server Unavailable, and was wondering if there was some way to configure lib proxy settings like I did with npm.

Hey @matt6500 ! We now have a way to create, manage, and deploy Standard Library APIs via our online IDE Code.xyz that might work better for you behind a proxy. Let me know if that helps.

@jacoblee93 Thanks. That's amazing!
Trying to follow along with this article
Having similar trouble login in:

Thanks @panchalkalpesh! It'd be tough to debug without being next to you and having access to your proxy. If it helps, all outbound API requests from the CLI go to api.polybit.com, you could try whitelisting that?

repo: stdlib/lib


text:
debugging

http://www.commitstrip.com/en/2019/01/30/anti-freeze/

http://www.commitstrip.com/en/2018/08/22/profiling/

repo: stealify/stealify


text:
typo throws error; breaks live reloading

load.name should be name.
https://github.com/stealjs/steal-css/blob/master/css.js#L190

@matthewp 1.1.0 should be unpublished; I believe this needs to happen within the next 12 hours.

Please don't ask for timelines for things that you aren't paying for.

It's a timeline set by npm, not me; you can't unpublish version after 24 hours has passed.

Ah ok, sorry for the mix up then.

I published your fix as 1.1.1 anyways, no need to unpublish.

kk

authors: Bajix matthewp

repo: stealjs/steal-css


text:
hello!I have a question

hello!I have a question.Have you tested the mAP and mAR of your semantic segmentation module? If my segmentation does not achieve a high accuracy rate, will it not work well with grasp detection?

Hi,
for evaluation of the semantic segmentation results, we only considered the mean IOU as we thought this is the most suited evaluation metric for this task.
For your second question: The accuracy for grasp detection can be high, although the results for segmentation are bad. The reason for this is that we have two independent branches for grasp detection and segmentation ( both branches only share the same backbone feature extractor). The only thing that you have to keep in mind is that we use the segmentation results to assign the grasp candidates to the objects. This will not be possible without good segmentation results.
If your dataset does not contain ground truth for semantic segmentation, or the quality of the segmentation ground truth is bad, you can also consider to simply remove the segmentation branch and only use the grasp detection.

authors: meiguiz stefan-ainetter


text:
PyPI: Add switch for choosing between binary wheels and source distributions

Add a switch for the --package option to download either a binary wheel or the source distribution. This is especially useful for native code to have a look at the source code copyrights as well.

Added in https://github.com/stefan6419846/license_tools/commit/fd8b28c20cac94e2822eaef8f2c747b0b80eff74.


text:
support Simplified Chinese language

There is no localization for Simplified Chinese language.

Migrated to transifex

authors: Calvin-he yakky

repo: stefanfoulis/cmsplugin-filer


text:
stefka97's file

created a file and made a commit, and opened a pull request

no changes


text:
Display information

Hello,
Could you please upload the information to add the OLED display.

I'm currently away and won't be able to get to this until late next week. Will post an update then.

I've added a .pdf that shows how to add the OLED display. You'll find it here.
Note that I used a typical 0.96"128x64 OLED display when designing my case. If you have something different, you'll need another case design.

Thank You

authors: awholecorndog steindevices


text:
Add [btcusd] #airdrop #wallet #custodian #issuer #personal GD673R…5CZRLH

Address: GD673RRHM5IANVP4FFFOMAW2QJL3FTUWOETANMZXWBC4GDXB235CZRLH
Tags: airdrop wallet custodian issuer personal
Title: btcusd
Requested by @devongu

Non-existing account

authors: orbitlens stellar-expert-deploy

repo: stellar-expert/public-directory


text:
Improve error message after Stellar-Core crash

Currently, when Stellar-Core crashes when preparing a new range it logs the following error message:
error preparing range: Error fast-forwarding to 17089856: error reading frame length: unmarshalling XDR frame header: xdr:DecodeUint: EOF while decoding 4 bytes - read: '[]'

This is really confusing. We should improve this message and, if possible, log the latest error level message from Stellar-Core.

Related https://github.com/stellar/go/pull/4066

https://github.com/stellar/go/pull/4066

Yeah, looks like there's another place in the code we aren't doing this properly.

repo: stellar/go


text:
[WIP] ANCHOR-104 fix e2e test

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
[TODO: Short statement about what is changing.]
Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Closing as was fixed in #714

authors: Ifropc stellar-jenkins

repo: stellar/java-stellar-anchor-sdk


text:
[ANCHOR-257] Validate that each asset is unique on startup

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Ticket: https://stellarorg.atlassian.net/browse/ANCHOR-257
Why
Validated PropertyAssetConfig on start to avoid duplicate ticker being added.
Known limitations
N/A
See tests for test plan

Reference Server Preview is available here:https://anchor-ref-pr958.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr958.previews.kube001.services.stellar-ops.com/

Alternatively, we could enforce the uniqueness constraint in the initialization of DefaultAssertService. The underlying data structure is a List of assets which can be swapped to a Map. I'm thinking this is something we would want for performance reasons anyway for Anchors supporting a large number of assets.

Yeah I also prefer to move uniqueness constrain to DefaultAssetService  initialization phase. No assetService should be returned if config is invalid.
Regarding to swap List to Map, let's do it in separate PR due to it and its underlying object being referenced in multiple places. @lijamie98 what do you think ?

Reference Server Preview is available here:https://anchor-ref-pr958.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr958.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr958.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr958.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr958.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr958.previews.kube001.services.stellar-ops.com/

authors: JiahuiWho philipliu stellar-jenkins


text:
Update stellar network command to use root cli for error logging

Similar to this update for stellar contract init: https://github.com/stellar/stellar-cli/pull/1584

it looks like this has been taken care of already, so I'm closing this issue

repo: stellar/stellar-cli


text:
Is there a way to log into blob storage in a text file instead of xml? And can I append to it ?

I'm using the following for now :
    <appender name="AzureBlobAppender" type="log4net.Appender.AzureBlobAppender, log4net.Appender.Azure">
      <param name="ContainerName" value="testblobcontainer" />
      <param name="DirectoryName" value="logs/" />
      <!-- You can either specify a connection string or use the ConnectionStringName property instead -->
      <param name="ConnectionString" value="UseDevelopmentStorage=true;" />
      <!--<param name="ConnectionStringName" value="GlobalConfigurationString" />-->
      <bufferSize value="5" />
    </appender>

But as expected I'm ending up with MANY xml files. So my question is, can I log into 1 text file? If not, can I at least end up with 1 xml file instead of 1 for each log message?
PS: I tried using the following but didnt work
<appender name="AzureAppendBlobAppender" type="log4net.Appender.AzureAppendBlobAppender, log4net.Appender.Azure">
  <param name="ContainerName" value="testblobcontainer"/>
  <param name="DirectoryName" value="logs"/>
  <!-- You can either specify a connection string or use the ConnectionStringName property instead -->
  <param name="ConnectionString" value="UseDevelopmentStorage=true"/>
  <!--<param name="ConnectionStringName" value="GlobalConfigurationString" />-->
  <bufferSize value="5" />
</appender>

the Append Blob operations are not supported by the emulator currently so appending to one file won't work for me since im using the development storage. Still no idea how to make it in a txt file instead of XML though.


text:
README: add a GIF of a console session

An animated GIF of a console session helps give a quick illustration of what a CLI tool like this one does. A good example is https://github.com/pypa/pipenv#readme

Added Makefile recipe and a demo.sh to create an asciinema. Added link to README.

repo: stencila/dockter


text:
Use latest protobuf and prune travis config

@stepancheg

right now you're on an ancient 2.2, because that's the latest version provided by travis' old ubuntu. using 2.6 means you can start adding features like anyof, allow_alias, import public, etc. (see https://github.com/google/protobuf/blob/master/CHANGES.txt)

Ubuntu 12.04 used in travis is ancient indeed. protobuf version in Ubuntu 12.04 is 2.4.1. Anyway, 2.4.1 it is still old.
However, rust-protobuf does not need latest protoc to implement features like anyof. Rust-protobuf git repository contains descriptor.proto and generated descriptor.rs. That descriptor is taken from 2.5, and descriptor from 2.6 can be used instead: descriptor.proto from 2.6 doesn't use modern features and can be compiled even with protoc 2.4.
Modern protobuf is actually needed to implement tests for rust-protobuf (tests, which invoke protoc), but I'd rather made tests of modern protobuf features optional, rather than forced travis to download latest protobuf.
I don't like the idea of downloading protobuf from internet in travis for two reasons:

it adds extra load to travis servers
it makes build fragile, as build may produce false positive in case of network errors

Summary: rust-protobuf does not need latest protobuf to implement modern protobuf features.

I'll just leave this here until you decide that testing all functionality is more important that conserving trivial travis-ci resources (the download is < 2MB).
FWIW, this stuff is almost straight out of travis-ci's own guides http://docs.travis-ci.com/user/installing-dependencies/#Installing-Projects-from-Source.

rebased

Applied.

authors: stepancheg tamird

repo: stepancheg/rust-protobuf


text:
Incorrectly parsed sets. Why is default value static?

While parsing to a std::set of objects with a std::set field, I noticed that the field of subsequent objects contained an accumulation of the field entries from all previous object entries.
A reproduction of what I mean:
struct Thing { std::set<int> field; };
std::set<Thing> things;
const auto input_string = R"([
  {"field": [1] },
  {"field": [2,3]},
  {"field": [4,5]}
])";
glz::read_json(things, input_string);
// parsed incorrectly
assert(glz::write_json(things)  == R"([
  {"field": [1] },
  {"field": [1,2,3]},
  {"field": [1,2,3,4,5]}
])";

Tracking this down came to the use of static on the parsing for sets here:
               if constexpr (sizeof(V) > 8) {
                  static thread_local V v;  // <---- static used here
                  read<json>::op<Opts>(v, ctx, it, end);
                  if (bool(ctx.error)) [[unlikely]]
                     return;
                  value.emplace(v);
               }
               else {
                  V v;
                  read<json>::op<Opts>(v, ctx, it, end);
                  if (bool(ctx.error)) [[unlikely]]
                     return;
                  value.emplace(std::move(v));
               }

This use of 'static' causes subsequent entries in a set not to be default constructed - instead, the previously parsed value is used as the "default". Consequently, operations that amend the "default" value, like parsing a std::set field, as opposed to replacing the "default" value, like parsing an int, contain remnants of previously parsed entries.
Why is static used here? It seems to be for a performance reason. Can it be removed or is there an alternative solution to this issue?

@justend29
Thanks for pointing this out. In this case because we are always emplacing the item, we don't need to use static thread_local.
I've merged in more std::set tests (#356), including what I thought matches your issue, along with removing static thread_local. However, even before removing static thread_local, my test case that was designed to match yours worked. So, you might want to check my test case called "std::set<set_object>" to see how your use case differs from this one.

You're right with my little example, it doesn't illustrate the problem.
I was trying to come up with something simple, instead of my actually use-case, and was a little too confident in it.
I'll close the issue but will soon try to correct my example to reproduce the issue properly.

repo: stephenberry/glaze


text:
Noob question, how to load custom extension?

Amazing library.
I have a question. I wanted to use this extension (embedding for SQLite). How can I use it with SQLite.swift?
https://github.com/asg017/sqlite-vss
Thanks,

How can that solution be adapted to a Swift project? Looks like main.m doesn't exist in that context 🤷♂

Ty. Actually eventually figured it out (I'm an extension author not iOS dev 😅) --
https://github.com/tantaman/xcode-starter/blob/a755ad175caf091b3e61d4aa0fe69e996082ecf4/xcode-starter/xcode_starterApp.swift#L10-L14
The new wrinkle is this:
SQLITE_DEPRECATED_NO_REPLACEMENT("Process-global auto extensions are not supported on Apple platforms", macos(10.10, 10.10), ios(8.2, 8.2), watchos(2.0, 2.0), tvos(9.0, 9.0))
SQLITE_API int sqlite3_auto_extension(void(*xEntryPoint)(void));

so sqlite3_auto_extension always returns an error.
We've worked around that problem by using the sqlite3 package from cocoapods

authors: longseespace tantaman


text:
Portfolio-setup-and-mobile-first

Created a portfolio for the  phone interface first
Transformed figma UI design into code
Added background image to design

I'm I supposed to use the exact words in the template, or am I allowed to
use my own words?
On Thu, 12 Jan 2023 at 17:49, Desmond Owusu Ansah @.***>
wrote:

@.**** requested changes on this pull request.
Hi @stephenkati https://github.com/stephenkati ,
Good job so far!
There are some issues that you still need to work on to go to the next
project but you are almost there!
https://camo.githubusercontent.com/19614f2c31a5ce50709fbc289e15ba5b57fd5ffc18b67c9c8e30ffab4e35190b/68747470733a2f2f6d65646961332e67697068792e636f6d2f6d656469612f4c3432324a6f4e6c4242424434327a6b51392f67697068792e676966
Highlights
📌 No Linters error ✅
📌 Descriptive pull request✅
📌 Great working on the setup of the project ✅
📌 Good commit messages ✅(I like the way you have capitalized your commit
messages 😄 )
Required Changes ♻
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop
the approval of this PR. However, I strongly recommend you to take them
into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
Please, do not open a new Pull Request for re-reviews. You should use the
same Pull Request submitted for the first review, either valid or invalid
unless it is requested otherwise.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In README.md
https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#discussion_r1068155283
:

+

Microverse README Template

Why don't you remove this Microverse logo since it is optionally
meant to be replaced with your own logo if you have one? 😊

In README.md
https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#discussion_r1068157858
:

+

Client

No client yet build

+

Since you are building this project using HTML and CSS, it is better
if you specify that you since HTML and CSS.

In README.md
https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#discussion_r1068159795
:

+## 🚀 Live Demo

+> Add a link to your deployed project.

+- Live Demo Link

I think it is better if you say that you have no live demo link yet
rather than using this broken link.

In README.md
https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#discussion_r1068177980
:

+## 💻 Getting Started

+A new developer can get the project from my Github repo link i shall provide.

+To get a local copy up and running, follow these steps.

+### Prerequisites

+In order to run this project you need:

+

+### Setup

+Clone this repository to your desired folder:

+

+### Install

+Install this project with:

+

+### Usage

+To run the project, execute the following command:

Please make sure that your getting started section is more
descriptive and the content should be the steps to follow to get your
project up and running on a local machine.

For example,
Getting started
You can add the steps to follow to clone your project,
Prerequisites
if you don't have git installed on your machine you can download it from here.
Setup
Once you have git installed on your machine you can clone your project by running the command below to clone your project to your local machine
git clone <your project link>
Alternatively, you can download the zip file of your project by clicking on the Code button on the right side of your project page and clicking on Download ZIP
Install
Install this project with:

  cd my-project

``

For this project, you don't need to install any dependencies but if you prefer to install any dev dependencies run:

``

npm install

``

### Usage

To run the project,

Locate the folder where you cloned your project and open the `index.html` file in your browser to view your project.

------------------------------

In README.md
<https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#discussion_r1068178777>
:

> +

+## 👥 Authors

+

 - Please since you are the only contributor to this project you can
 singularize the Authors section to Author 😄

------------------------------

In index.html
<https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#discussion_r1068180579>
:

> +    <meta charset="UTF-8">

+    <meta http-equiv="X-UA-Compatible" content="IE=edge">

+    <meta name="viewport" content="width=device-width, initial-scale=1.0">

+    <title>My Portfolio</title>

+    <link rel="stylesheet" href="css/style.css">

+    <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.2.1/css/font-awesome.min.css">

+

+

+

+

+
Welcome

+

+

+

+

+
I'm Stephen Katuli, nice to meet you

 - Please make sure the main title (e.g., "I'm Marianne ...") is an h1
 tag. This will help so that If you want that google (and other search
 engines) know about a specific topic, in this case, you, use an h1 tag. Check
 this link <https://www.reliablesoft.net/h1-tag/> for more info.

------------------------------

In index.html
<https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#discussion_r1068182729>
:

> @@ -0,0 +1,31 @@

+<!DOCTYPE html>

+

+

+    <meta charset="UTF-8">

+    <meta http-equiv="X-UA-Compatible" content="IE=edge">

+    <meta name="viewport" content="width=device-width, initial-scale=1.0">

+    <title>My Portfolio</title>

+    <link rel="stylesheet" href="css/style.css">

+    <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.2.1/css/font-awesome.min.css">

+

+

+

+

+
Welcome

+

 - Please make sure that the hamburger button has a nav tag. The nav
 tag is for semantics reasons and the right position for convention and user
 experience for mobile devices. 🙏

------------------------------

In index.html
<https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#discussion_r1068184867>
:

> @@ -0,0 +1,31 @@

+<!DOCTYPE html>

+

+

+    <meta charset="UTF-8">

+    <meta http-equiv="X-UA-Compatible" content="IE=edge">

+    <meta name="viewport" content="width=device-width, initial-scale=1.0">

+    <title>My Portfolio</title>

+    <link rel="stylesheet" href="css/style.css">

+    <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.2.1/css/font-awesome.min.css">

+

+

+

+

+
Welcome

 - Please make sure that the logo has a link (a tag). This is for three
 reasons: convention, semantics, and user experience(UX). Check this
 link
 <https://ux.stackexchange.com/questions/81727/why-is-it-standard-for-a-website-logo-to-navigate-to-the-home-page>
 for more info. 🙏

------------------------------

In index.html
<https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#discussion_r1068190652>
:

> +

+

+

+

+

+

 - I think your social media links should be a list of icons a use a ul
 tag to group them, and li per icon; each icon has a link (a tag).
 Apart from being semantically correct, the a tag will let you connect
 your social networks with the icons, using href Like this

------------------------------

In css/style.css
<https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#discussion_r1068194791>
:

> +.header {

+  /* font-family: 'Inter'; */

+  font-style: normal;

+  font-weight: 700;

+  font-size: 40px;

+  line-height: 52px;

+  text-align: center;

+}

 - Please from the project requirements, you need to lay out the
 elements on the page and you should use Flexbox to display this section.
 The content should be aligned with flexbox. This gives us a lot of options
 to align all our elements, plus, it's responsive. 😊

------------------------------

In css/style.css
<https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#discussion_r1068204429>
:

> +.intro {

+  /* font-family: 'Inter'; */

+  font-style: normal;

+  font-weight: 400;

+  font-size: 20px;

+  line-height: 28px;

+  text-align: center;

+  color: #172b4d;

+}

+

 - Please from the project requirements, you need to lay out the
 elements on the page and you should use Flexbox to display this section.
 The content should be aligned with flexbox. This gives us a lot of options
 to align all our elements, plus, it's responsive. 😊

------------------------------

In css/style.css
<https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#discussion_r1068213682>
:

> +.contacts {

+  display: flex;

+  justify-content: center;

+  align-items: baseline;

+}

+

+i {

+  color: black;

+}

+

+.contacts i {

+  padding-left: 1em;

+  font-size: 25px;

+}

+

+.small {

+  display: none;

+}

+

***@***.*** only screen and (max-width: 600px) {

+  body {

+    background-image: ***@***.***");

+    background-size: 370px;

+    background-position: 60% 70%;

+  }

+

+  header {

+    display: flex;

+    justify-content: space-between;

 - From your design, I don't know the template you have chosen from the
 Figma design to work on but from the project requirement, you must stick to
 the design as much as possible (e.g. font, colors, images, text, margins)
 using the templates in Figma
 <https://www.figma.com/file/l7SqJ3ZfkAKih9sFxvWSR4/Microverse-Student-Project-1?node-id=0%3A1>
 but as you can see, your design hee does not match any template
 [image: Screenshot from 2023-01-12 14-39-21]
 <https://user-images.githubusercontent.com/92303891/212097550-bb0bc884-1252-45f7-bd46-03738ae3447a.png>

—
Reply to this email directly, view it on GitHub
<https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#pullrequestreview-1245653271>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALI2SSQJSWMRU2KJQ76VDM3WSAKZJANCNFSM6AAAAAATZHUWEI>
.
You are receiving this because you were mentioned.Message ID:
<stephenkati/Portfolio-setup-and-mobile-first/pull/1/review/1245653271@
github.com>

i don't understand what you mean with the last comment
On Fri, 13 Jan 2023 at 04:45, David A. Tamayo @.***>
wrote:

@.**** requested changes on this pull request.
Hi @stephenkati https://github.com/stephenkati 🙋♂,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are
still some which aren't been addressed yet.
https://camo.githubusercontent.com/78087f8205c5736aa2d7d71fc32f3ec42ca7302de1c46e79464a18f3fba32dfb/68747470733a2f2f6d65646961322e67697068792e636f6d2f6d656469612f333151333645484a3743355a6f494d7737392f67697068792e676966
Top highlight 🎯

The Pull Request follows the GitHub Flow ✅
The PR title and description are professional and descriptive ✅
Linters are working properly ✅

Suggested changes

Check the comments under the review. ⬇

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this
PR. However, I strongly recommend you to take them into account as they can
make your code better. Some of them were simply missed by the previous
reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In index.html
https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#discussion_r1068831484
:

Welcome

You did an amazing job adding the required changes, but please make
sure that the nav tag only wraps the hamburger button and not the
element. The nav tag is for semantics reasons and the right position for
convention and user experience for mobile devices 👍

In index.html
https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#discussion_r1068832664
:

@@ -0,0 +1,38 @@

+
+
+

My Portfolio

+

Welcome

As the previous reviewer said, please 🙏 make sure that the logo or

 element has an  or link tag. Check this link

 for more info

In index.html
https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#discussion_r1068834740
:

Good job implementing  and  tags 👍 , but to be semantically
correct you should use a  element per icon and not only one for
all the  tags.

In index.html
https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#discussion_r1068835945
:

@@ -0,0 +1,38 @@

+
+
+

My Portfolio

+

As mentioned by the previous reviewer, you need to lay out the
elements on the page using Flexbox because it gives a lot of options to
align your elements. To learn more you can check this page
https://css-tricks.com/snippets/css/a-guide-to-flexbox/ 👍

—
Reply to this email directly, view it on GitHub
https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#pullrequestreview-1246791919,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALI2SST7C436T2LG36MAJ2DWSCXUHANCNFSM6AAAAAATZHUWEI
.
You are receiving this because you were mentioned.Message ID:
<stephenkati/Portfolio-setup-and-mobile-first/pull/1/review/1246791919@
github.com>

Thanks for the feedback!
On Fri, 13 Jan 2023 at 06:05, Francisco Borja Lobato <
@.***> wrote:

@.**** approved this pull request.
Hi @stephenkati https://github.com/stephenkati,
STATUS: APPROVED 😃
[image: git-merge]
https://user-images.githubusercontent.com/58642949/212227841-7a4c013d-3792-4a48-b52f-3a697c551bbc.gif
Your project is complete! There is nothing else to say other than... it's
time to merge it [image: :shipit:]
Congratulations! 🎉
Highlights

No linter errors ✔
Correct Github flow ✔
Descriptive PR ✔
Professional README file ✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this
PR. However, I strongly recommend you to take them into account as they can
make your code better. Some of them were simply missed by the previous
reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In index.html
https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#discussion_r1068874125
:

[OPTIONAL] All the images should have the alt attribute that
describes the content of the image for a good practice of HTML&CSS, please
🙏🏽 add them.

—
Reply to this email directly, view it on GitHub
https://github.com/stephenkati/Portfolio-setup-and-mobile-first/pull/1#pullrequestreview-1246840952,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALI2SSTGQINIIBOJBYXPG33WSDA77ANCNFSM6AAAAAATZHUWEI
.
You are receiving this because you were mentioned.Message ID:
<stephenkati/Portfolio-setup-and-mobile-first/pull/1/review/1246840952@
github.com>


text:
Django 4.0.0 compatibility

Change deprecated and removed methods in Django 4.0

url => re_path
smart_text => smart_str
is_safe_url => url_has_allowed_host_and_scheme
force_text => force_str
ungettext => ngettext
urlquote => quote (urllib.parse)

Fix Signals init
Add pytz to requirements. Should migrate from pytz to zoneinfo at some point
Still a WIP. There are few tests that fail with 4.0 but I want to see what happens with the CI and if there are other things that might require attention.
Also gets the filebrowser_safe from my branch that is already 4.0 compatible TODO: this must be switched back as soon as upstream has merged my patch. Also should probably get the package from pypi not from the master branch in git.
Fixes: #2008 and #2007

https://github.com/stephenmcd/mezzanine/blob/a2fa5c8d96ac6e0a724d214135c5581cae1c8b52/.github/workflows/main.yml#L91 should probably be removed from the on push / pr  and another "deploy" workflow be implemented for just the master branch?

Great work @tswfi!

authors: jerivas tswfi

repo: stephenmcd/mezzanine


text:
feat: add biome-lint

Adding support for using biome lint command. It is mainly used for the tailwind sorting (and more) which is why the --unsafe flag is there.

you're right, just tried it with the --unsafe flag and got the intended results. Thanks!


text:
clean up inline docs from so-fancy script

Now that it's in a real readme, maybe you want to clean out the inline docs.
you can definitely remove the TODO about npm, since you did that. :)

ooh! and thanks for adding me to the repo!
didn't realize that, so i just committed a change to the readme, when i thought it was going to make a PR. :)

Sure, this is your project. Your also the owner on npm :)

authors: paulirish stevemao

repo: stevemao/diff-so-fancy


text:
Working (Failing) with Jekyll

I've done a lot of searching and can't seem to find a solution. I am currently using Jekyll for my blog and I can not seem to get Instafeed to render my images. I have tested the same code I have in a plain html page and it renders my images fine, so I have to assume it's failing because of Jekyll. I don't have any other plugins or anything strange working with Jekyll. I'm using a template with Instafeed and in my source code is show's my image tag rendered like this: . If anyone can direct me to a solution, I'd love to find one.

Hi @maxatbrs ,
I´ve used your suggestion about verbatim and Twig and got it working.
Thank You very much.

@armaduarte :100:

authors: ChrisSki kamburi maxatbrs


text:
Take 2016 tax changes into account

The tax changes for 2016 are quite significant. I made the change already for the brackets since that's easy but I have no idea how the credits work...couldn't find any decent explanation on how to calculate your credits. Very confusing.

thank you for this pointing out!
I'll update them asap

Sweet :+1:, thanks for your work on the credits, spent ages myself trying to figure out how they work but gave up in the end!

updated the brackets for 2016 and made it possible to calculate both (2015 and 2016).

authors: JaTochNietDan stevermeister


text:
Dotting my i's and j's sometimes doesn't work

First, awesome library (again!).
I was enjoying myself, swirling and curving away, when suddenly I noticed a few of my i's lost their dots.
macOS Mac Mini M1
Chrome
Drawing with a mouse
Here's a screen cap:
https://user-images.githubusercontent.com/4045376/108576562-f5f36600-72d2-11eb-874e-114a95e7c0ea.mov

Should be fixed in 0.2.0! I may still tweak the outline shape for dots / short marks, but you're at least bound to get a shape now.

authors: StephenHaney steveruizok

repo: steveruizok/perfect-freehand


text:
Add nullable for getImageUrl()

In a Kotlin project getImageUrl() thinks it will always return a URL, which makes it had to distinguish between a message and image.
Added a simple @nullable annotation to make it compatible with Kotlin

Hello,
considering that the library is not maintained and I actively use it, I have decided to fork it for the time being under the same name. Changes to naming and other practices will come in the future.
In the mean time, I have merged your PR and appreciate your contribution.
I hope we can revive this project together.
https://github.com/mario/chatkit
Cheers,
Mario

authors: dmathewwws mario

repo: stfalcon-studio/ChatKit


text:
Remove google analytics code

https://github.com/sthapa15/sthapa15.github.io/blob/e32df8203ca0c05822daba567e08a448a56d62d2/_includes/footer.html#L7
Hi there, you seem to be using my google analytics code on your website - probably from using my github repo as your template.  Can you please remove this?

I've removed it. Apologies!

No worries, thanks!


text:
fix data map documentation

Should use the identifier with lowerCamelCase.

Thanks for the pull request. The case convention for HTML attribute names is kebab-case—see the Data Maps reference page for details.

@sstephenson i know, but the -[reference]- part (component name) needs to be lowerCamelCase, if your component name consists of multiple words.

Controller identifiers are always in kebab-case.

authors: boschr sstephenson

repo: stimulusjs/stimulus


text:
osflow rework

I extracted the commits from #98 which add ECP5 support but which are not specific about OrangeCrab. Then, I reworked the structure in osflow for reducing the board specific subdirectories, which might be misleading.

There is a setups/osflow/constraints directory containing the PCF/LPF files for all boards.
setups/osflow/BOARDNAME/Makefile were renamed to setups/osflow/boards/BOARDNAME.mk. Those BOARDNAME.mk now only contain the tasks which are specific to a board (such as a custom bitstream load command).
I added setups/osflow/boards/index.mk and common.mk, which contain all the targets common to any board.

As a result, now there is no Makefile in setups/osflow/**, making it explicit that those are all resources to be used from some other entrypoint (precisely, setups/examples/Makefile). See https://github.com/umarcor/neorv32/tree/osflow-rework/setups/osflow

Wow! Thank you so much for all that work and effort! :+1:

authors: stnolting umarcor


text:
Fix calculation of currently-viewed page.

Previously, this relied on a hard-coded constant determining the
height of a page. However, that's unnecessary -- we know the scroll
height of the window and the number of pages, so we can compute it.
This addresses the problem reported in #669 in perhaps a more principled way.
@stolksdorf, I'd appreciate your thoughts on this one. I'm not familiar enough with react stuff to judge whether what I did is always safe. The semantic change is in the handleScroll function; the rest of the diff merely removes the now-unused pageHeight attribute.

This looks good to me and makes a lot more sense. It was mentioned in #669 that the scrolling has also become laggy, but I notice the same lag on the live site after a document reaches about 1,200 lines, and gets progressively worse with more pages. I think that is a separate optimization issue.

repo: stolksdorf/homebrewery


text:
2.3.x fix stale event cache

Signed-off-by: James Talton jtalton@redhat.com
https://github.com/stolostron/backlog/issues/19561

/lgtm

/unhold

authors: KevinFCormier jamestalton

repo: stolostron/console


text:
MGMT-9313: Sorting by nodes and adding a sortable creation date in cluster list

Related to https://issues.redhat.com/browse/MGMT-9313

/hold
this is a 2.6 feature, please dont merge yet

/unhold /ok-to-test

/unhold

/lgtm


text:
Separate "Additional trust bundle" for proxy and disconnected settings

https://github.com/stolostron/backlog/issues/22693

/test lint-check-unittests-sonarcloud

/cc @jeswanke


text:
ACM-5597

https://issues.redhat.com/browse/ACM-5597

/hold

/test unit-tests-sonarcloud


text:
chore(main): release 0.0.1

:robot: I have created a release beep boop
0.0.1 (2024-11-12)
Features

implement Env (68d3e4a)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.0.1
:sunflower:

repo: stonemjs/env


text:
Social Login via API

Fixes #112.
This PR adds support for social login from SPAs with for example the Angular SDK.
Includes

Support for login using providerData instead of username/password with the login API
A new API route, /oauth/providers, that returns a list of all OAuth providers and their configurations
Logouts with the Accept header set to application/json will respond with 200 instead of a redirect

Notes

Is the route /oauth/providers the best route for this purpose?

How to verify

Setup a server with this branch
Verify the login, logout, etc. works with the AngularJS SDK: https://github.com/stormpath/stormpath-sdk-angularjs/pull/48
Run tests

Looking good so far =)

I've reviewed the code changes and I like it, I don't have any comments on the code.  But please add the following to this PR:

JSDoc comments for new functions

Tests for these cases:

That the /oauth/providers endpoint is serving the expected object, if the application is mapped to a directory that has provider data

That the /oauth/providers endpoint returns an empty object, {}, when there are no account stores with provider data on the application

Thanks @robertjd, I will fix the docs and tests then this should be ready for final review :)

@rdegges @robertjd @typerandom This is ready for final review! I've added some jsdocs and some tests and fixed the conflicts. I don't know why the Travis build fails though?

Thanks for the review, @typerandom! I've addressed your comments in my latest commit.

Closing in favor of #171

authors: rdegges robertjd timothyej

repo: stormpath/express-stormpath


text:
how can i get access_token?

I see it in cookies, but it has http only flag and can't be read with my js, which is i believe to protect from xss, but how can i get access_token?

Hi @liesislukas, unfortunately this is currently not possible when using our cookie authentication strategy. We're currently working on having token support in local storage (see PR #137). Once this is merged using this new authentication strategy you'll be able to access your token directly client-side.

could you implement onLogin or similar callback and pass that token there?

authors: liesislukas typerandom

repo: stormpath/stormpath-sdk-react


text:
Switching devices when deep linking does not go to the selected story

After a story other than the default one is selected, if the user switches devices, the new device does not automatically navigate to the currently selected story.

:rocket: Issue was released in v1.0.5 :rocket:

repo: storybookjs/native


text:
Test runner does not recognize files other than ".stories."

Using @storybook/test-runner v0.3.0 and jest v27
In my main.js my stories are described as such and it runs fine with yarn storybook

I have multiple story files and when I run test-runner for just *.stories.tsx it works fine

As soon as I use

I get this error

However I have tried, as a test, to change the name of the file from Accordion.fixtures.tsx -> Accordion.stories.tsx (there wasn't one existing) and it works fine. Same holds true for Accordion.examples.tsx -> Accordion.stories.tsx
Wondering what might be the issue....

Fixed by adding transform options in test-runner-jest.config.js

Though this is still a bug.

Hi, I faced the same issue, and I explained here how I fixed it https://github.com/storybookjs/test-runner/issues/249.
I was coming to open an issue to add that documentation to the README or to find a way to fix it.

Hey @gabrielperales thanks for that! Would you mind making a PR to introduce some documentation for this? Thank you so much <3

I just ran into this as well.
getJestConfig returns a proper value fortestMatch (which for me to is to write it as .story.tsx), but the transform value still references .stories.
  testMatch: [ '<rootDir>/src\\react\\**\\*.stories.tsx' ],
  transform: {
    '^.+\\.stories\\.[jt]sx?$': '@storybook/test-runner/playwright/transform',
    '^.+\\.[jt]sx?$': <redacted>\\.yarn\\__virtual__\\@swc-jest-virtual-61723854d4\\0\\cache\\@swc-jest-npm-0.2.26-890d01518c-771821ed08.zip\\node_m
odules\\@swc\\jest'
  },

Perhaps the config could take testMatch, strip the <rootDir>/, convert the globs to regular expressions (glob-to-regexp?) and add them to the transform object?

Didn't get the above to work easily, but this works for me (and maybe for more people):
.storybook/main.js:
stories: ["../src/react/**/*.story.tsx"],

test-runner-jest.config.js:
const {getJestConfig} = require('@storybook/test-runner');

const jestConfig = getJestConfig();

/**
 * @type {import('@jest/types').Config.InitialOptions}
 */
module.exports = {
    ...jestConfig,
    transform: jestConfig.testMatch.reduce((result, matcher) => {
        const transformMatcher = matcher
            .replace(/(^.+?\*)(\.\w+\.\w+)/, '$2$')
            .replace(/\./g, '\\.');

        return {
            [transformMatcher]: '@storybook/test-runner/playwright/transform',
            ...result
        };
    }, jestConfig.transform)
};

authors: StephanBijzitter amywangg gabrielperales yannbf

repo: storybookjs/test-runner


text:
does this addon work with other admins like the "info" addon?

I'm curious b/c this addon requires switching from add to addWithJsx.

When using this addon together with https://github.com/storybooks/storybook/tree/master/addons/info then the output in the JSX Panel contains a lot more (basically all added info + boilerplate).
Example:
(storiesOf('Common/Button', module))
  .addWithJSX(
    'submit',
    wInfo(`
    ### Notes

    It's a simple submit button.

    ### Usage

    ~~~js
    <Button type="submit">Submit</Button>
    ~~~`)(() => <Button type="submit">Submit</Button>)
  )
);

Output:
<Story
  PropTable={function (props) {
    if (!props.type) {
      // eslint-disable-line
      return null;
    }

    var type = props.type;
    var propDefinitionsMap = hasDocgen(type) ? propsFromDocgen(type) : propsFromPropTypes(type);
    var propDefinitions = Object.values(propDefinitionsMap);
    return _react.default.createElement(Component, (0, _extends2.default)({
      propDefinitions: propDefinitions
    }, props));
  }}
  components={{
    a: function A(_ref4) {
    var href = _ref4.href,
        children = _ref4.children;
    var style = {
      color: '#3498db'
    };
    return _react.default.createElement("a", {
      href: href,
      target: "_blank",
      rel: "noopener noreferrer",
      style: style
    }, children);
  },
    code: function Code() {
      (0, _classCallCheck2.default)(this, Code);
      return (0, _possibleConstructorReturn2.default)(this, (0, _getPrototypeOf2.default)(Code).apply(this, arguments));
    },
    h1: function H1(_ref) {
    var id = _ref.id,
        children = _ref.children;
    var styles = (0, _objectSpread2.default)({}, _components.baseFonts, {
      borderBottom: '1px solid #eee',
      fontWeight: 600,
      margin: 0,
      padding: 0,
      fontSize: '40px'
    });
    return _react.default.createElement("h1", {
      id: id,
      style: styles
    }, children);
  },
    h2: function H2(_ref2) {
    var id = _ref2.id,
        children = _ref2.children;
    var styles = (0, _objectSpread2.default)({}, _components.baseFonts, {
      fontWeight: 600,
      margin: 0,
      padding: 0,
      fontSize: '30px'
    });
    return _react.default.createElement("h2", {
      id: id,
      style: styles
    }, children);
  },
    h3: function H3(_ref3) {
    var id = _ref3.id,
        children = _ref3.children;
    var styles = (0, _objectSpread2.default)({}, _components.baseFonts, {
      fontWeight: 600,
      margin: 0,
      padding: 0,
      fontSize: '22px',
      textTransform: 'uppercase'
    });
    return _react.default.createElement("h3", {
      id: id,
      style: styles
    }, children);
  },
    h4: function H4(_ref4) {
    var id = _ref4.id,
        children = _ref4.children;
    var styles = (0, _objectSpread2.default)({}, _components.baseFonts, {
      fontWeight: 600,
      margin: 0,
      padding: 0,
      fontSize: '20px'
    });
    return _react.default.createElement("h4", {
      id: id,
      style: styles
    }, children);
  },
    h5: function H5(_ref5) {
    var id = _ref5.id,
        children = _ref5.children;
    var styles = (0, _objectSpread2.default)({}, _components.baseFonts, {
      fontWeight: 600,
      margin: 0,
      padding: 0,
      fontSize: '18px'
    });
    return _react.default.createElement("h5", {
      id: id,
      style: styles
    }, children);
  },
    h6: function H6(_ref6) {
    var id = _ref6.id,
        children = _ref6.children;
    var styles = (0, _objectSpread2.default)({}, _components.baseFonts, {
      fontWeight: 400,
      margin: 0,
      padding: 0,
      fontSize: '18px'
    });
    return _react.default.createElement("h6", {
      id: id,
      style: styles
    }, children);
  },
    li: function LI(_ref2) {
    var children = _ref2.children;
    var style = (0, _objectSpread2.default)({}, _components.baseFonts, {
      fontSize: '15px'
    });
    return _react.default.createElement("li", {
      style: style
    }, children);
  },
    p: function P(_ref) {
    var children = _ref.children;
    var style = (0, _objectSpread2.default)({}, _components.baseFonts, {
      fontSize: '15px'
    }); // <P> is oftentimes used as a parent element of
    // <a> and <pre> elements, which is why <div>
    // is used as the outputted element when parsing
    // marksy content rather than <p>.

  return _react.default.createElement("div", {
      style: style
    }, children);
  },
    ul: function UL(_ref3) {
    var children = _ref3.children;
    var style = (0, _objectSpread2.default)({}, _components.baseFonts, {
      fontSize: '15px'
    });
    return _react.default.createElement("ul", {
      style: style
    }, children);
  }
  }}
  context={{
    kind: 'Common/Button',
    parameters: {
      fileName: './src/components/Button/Button.stories.tsx'
    },
    story: 'submit'
  }}
  excludedPropTypes={[]}
  info="
    ### Notes

    It's a simple submit button.

    ### Usage

    ~~~js
    <Button type="submit">Submit</Button>
    ~~~"
  maxPropArrayLength={3}
  maxPropObjectKeys={3}
  maxPropStringLength={50}
  maxPropsIntoLine={3}
  propTables={[]}
  propTablesExclude={[]}
  showHeader
  showInline
  showSource={false}
  styles={function (s) {
      return (0, _nestedObjectAssign.default)({}, s, options.styles);
    }}
>
  <Button type="submit">
    Submit
  </Button>
</Story>

@Regaddi @davidyeiser @kevinbarabash anything actionable here or can i close?

@hipstersmoothie
I haven't had much contact with storybook lately. If it helps I can create a reproduction repository demonstrating the issue.
If I remember correctly the code shown in the source panel was not the real source code for the story and had a lot of generated additions in it.

Yeah a repro repo would be perfect

There we go: https://github.com/Regaddi/storybook-with-info-output-reproduction
With most recent versions of storybook and addons the original case is not reproducible anymore for me.
The only thing I noticed is an additional onClick prop, which is not part of the original source.
<Button type="submit">Hello Button</Button>

vs.
<Button
  onClick={function onClick() {}}
  type="submit"
>
  Hello Button
</Button>

But overall combining info and jsx addons seems to work just fine.

authors: Regaddi hipstersmoothie kevinbarabash

repo: storybooks/addon-jsx


text:
addon: info - truncating props? how to update and change?

If i use the info addon: https://github.com/storybooks/storybook/tree/master/addons/info
sometimes props are truncated. How can i change that?

I will add to documentation after finding the information.

@blairanderson take a look at this PR: https://github.com/storybooks/storybook/pull/1157

Here is my config for this problem
// config.js
import infoAddon, { setDefaults } from '@storybook/addon-info';

// addon-info
setDefaults({
  inline: true,
  maxPropsIntoLine: 1,
  maxPropObjectKeys: 10,
  maxPropArrayLength: 10,
  maxPropStringLength: 100,
});
setAddon(infoAddon);

authors: Stupidism blairanderson shilman

repo: storybooks/storybook


text:
How to use existing build process and use storybook as lib

Describe the solution you'd like
I would like to use my existing build process (in this case parcel-bundler) with it's own capabilities (build, serve, hmr) and omit storybook build system, just use it as library.
Describe alternatives you've considered
As my setup involves typescript I started to setup storybook as described at the official docs, but it seems to be wrong to setup a parallel build system just for storybook when I have already everything in place.
Are you able to assist bring the feature to reality?
maybe

Hi @rolandjohann! This is something that we've considered in the past:

it is one solution to a similar problem with Meteor: https://github.com/storybooks/storybook/issues/3329
I did a POC PR here: https://github.com/storybooks/storybook/pull/3360
it was also discussed here: https://github.com/storybooks/storybook/issues/2140

I think this is something that @shilman might be thinking about as he starts to think about docs mode; not guaranteed to happen but there might be some related refactoring that makes it much easier to do.
Perhaps it makes sense to leave this ticket open to track the idea?

There's also a node API by @igor-dv , which hasn't been documented and which I'd like to change:
import build from '@storybook/react/standalone';
build({
  mode: 'dev',
  port: 9009,
  configDir: './storybook',
})
  .then(() => console.log('done'))

Hi together, thanks for quick reply.
@tmeasday thanks for pointing to existing issues. Doing the discussion at this ticket makes sense.
@shilman I played with that API already which triggers webpack anyway. It seems that the code for build and the actual business logic of storybook is not encapsulated in a way to just use storybook. Are there any detailed plans yet to refactor this and where I can help?

Hi @rolandjohann -- no plans that I know of? Maybe @ndelangen can weigh in here? I'd be open to some refactoring if it can also simplify the default webpack build process AND make it more debuggable. Every time we change anything related to webpack/babel it generates TONS of issues, so I'm hesitant to make changes here unless they are both well-justified and well-tested.

Maybe a solution would be to try to externalize a render api that takes an id and a list of stories as a parameter that way anybody can customize it the way they want ?

Hey all, I've been experiementing / thinking about this a little.
I think there are three things here. We can probably achieve all of this of this quite easily and potentially even as part of 5.1 if someone has some time to do some of it.
1. Allow arbitrary preview URL
We should add a new CLI option to start-storybook and build-storybook that sets a arbitrary preview URL. Right now it is hard coded here: https://github.com/storybooks/storybook/blob/next/lib/ui/src/components/preview/preview.js#L305
It probably wouldn't be too hard to pass it into the manager (lib/ui) somehow.
If someone sets such a URL we should also not start the preview webpack process or require a .storybook/config.js.
2. Allowing @storybook/core to be used from inside any build process.
This is actually almost possible already. I tried the following code inside a Meteor process:
import { configure, storiesOf } from '@storybook/react';

configure(() => {
  storiesOf('chapter').add('story', () =>
Story
);
});

And apart from one issue with expecting module to be defined it worked, no problems.
If you add the following code and browse to http://localhost:XYZ/iframe.html?id=chapter--story (where XYZ is the port of your process), it should work fine.
The main thing to change here would be "binding" to a subpath. Right now there is code in the StoryStore that looks for the id query parameter (and some other back-compat ones) and also changes the URL when the manager tells it to change the story. If it could do that on a subpath (like http://localhost:XYZ/storybook?id=chapter--story), it would be great I think.
3. Allowing the preview iframe to not use the story store (i.e @storybook/core)
This part is even easier actually. We probably just need to document and resolve to stick to the post message "channel" API that the manager uses to communicate with the story store.
I've been thinking about how we could make a @storybook/server API that could be used to render server-rendered components (like Rails partials, for instance) inside Storybook's UI. If anyone is keen to see this happen, get in touch and we can talk through how to do it.
The tricky part would be addons here -- if the addon needs code to run inside the preview window (e.g. a11y) then it's not going to work. However a fair few addons don't; they just have a expectations about the parameters that are set for a story. We could document that too.

If anyone is keen to look at 1, 2 or 3 above, let me know. I plan to look at it at some point but I am not sure when.

Number 2 would probably be one of the most flexible solution.
Just adding some documentation and examples and people could use what ever build process or bundler they want with Storybook (parcel, fusebox, etc)
What kind of HTML do you need for number 2 to work and for the storybook UI to render properly ?

apart from one issue with expecting module to be defined it worked, no problems
can that be bypassed ?

Hi @RPDeshaies -- these aren't either/ors -- both 1&2 would be required in the simplest case.
It's a good question about HTML. All the storybook view layers (@storybook/react etc) render into a #root element (e.g. https://github.com/storybooks/storybook/blob/next/app/react/src/client/preview/render.js#L7). Refactoring to allow this to be configured also might be a good idea.

@tmeasday so if someone would want to use storybook with any bundler they would only need to have

a html file that includes a javascript file
that javascript files that contains

import { configure, storiesOf } from "@storybook/react";
import React from "react";

configure(() => {
  storiesOf("Category 1").add("Test 1", () =>
Category 1 - Test 1
);
  storiesOf("Category 2")
    .add("Test 1", () =>
Category 2 - Test 1
)
    .add("Test 2", () =>
Category 2 - Test 2
);
}, {});

Right ?
So right now, I've done that (with ParcelJS) but the HTML only renders my story and not the whole storybook UI

Any ideas why ?
I'm probably missing something simple, but once I can make that work, I could make an example repo  that you guys could include in the doc to use StorybookJS with ParcelJS

@RPDeshaies does the above work, e.g. if you browse to ?path=/story/category-1--test-2? If so great!
To make it really work we'd still need to do part (1), which would allow the storybook UI to run and point at that. So the way you would use it would be to start your app as normal (including the part that renders the stories as above) and also start Storybook pointing at your app.
Also I suspect the above code snippet will interact badly with the rest of your app (overwriting routes etc possibly), and we probably want to do part (2) to contain the storybook behaviour in your app to a single route.
Are you interested in working on this? I can help out if you want to have a go at it!

does the above work

This url works for example: http://localhost:1234/?selectedKind=Category%202&selectedStory=Test%202
and loads the right story

Also I suspect the above code snippet will interact badly with the rest of your app

I personally think its fine as I think storybook should be rendered in its own app.
That, at least, could be an easy MVP
For example, I've been using React cosmos for months now and I have a very custom build to use it with parcel but when I use it, it's never executed inside the same app context as the rest of my app.
It just uses a similar bundling pattern

Are you interested in working on this?

Maybe ? I dont know anything about the project so I would need some guiding if you have some time

I personally think its fine as I think storybook should be rendered in its own app.

That's true, that could be a first step.

Maybe ? I dont know anything about the project so I would need some guiding if you have some time

If you have the time to experiment I can definitely point you in the right direction. What we need to do is:

add a CLI option (to prod and dev). Perhaps --preview-url?

When that option is set, ensure the webpack dev server (in dev) or build (in prod) does not add the preview entry point and associated configs to the webpack setup. I'm not 100% clear on how this is done and there are some layers to it (in here - https://github.com/storybooks/storybook/tree/next/lib/core/src/server) but I'm sure myself and others can help you figure it out if you want to start looking.

Wire the --preview-url option through to the Preview component -https://github.com/storybooks/storybook/blob/next/app/react/src/client/preview/render.js#L7
I'm not sure how best to do this; probably using the webpack DefinePlugin?

Happy to have a chat about this if you want to have a go once you've taken a look around.

Alright maybe I don't understand what you want clearly because I thought the goal was to existing build process and use storybook as lib
Wouldn't we just need to export the Preview Component ?
If the goal is to use an existing build process, I don't think updating webpack would help us doing that no ?

Sorry if it is unclear. Storybook consists of two parts:

the manager which is the UI of storybook itself
the preview which is the stories that run via code pulled from your app.

Right now Storybook starts a webpack process for both parts and embeds the preview inside the manager (via the Preview component linked above).
What I am proposing is to continue to run the manager via webpack and Storybook's config (this is our code unless you are writing addons).
The tricky part is running your own code inside webpack if you don't use webpack. So instead, you'll run the preview part of storybook yourself, either in a route inside your own app, or in its own app using which ever build tool you like (as you say).

Gotcha. I'll dig inside the code and will come back with either a solution and or questions

Questions

Should I branch off master or next in my fork ?

I as able to add the CLI config for the preview url and realized there was already a ignorePreview
Do you think it's OK if I reuse it to make sure the preview mode is disabled when my flag is also passed ?
e.g.
// lib/core/src/server/build-dev.js
export async function buildDev({ packageJson, ...loadOptions }) {
  const cliOptions = await getDevCli(packageJson);
  const hasPreviewUrlCliOption = !!cliOptions.previewUrl;

  await buildDevStandalone({
    ...cliOptions,
    ...loadOptions,
    packageJson,
    configDir: loadOptions.configDir || cliOptions.configDir || './.storybook',
    // IMPORTANT PART 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇
    ignorePreview: loadOptions.ignorePreview || hasPreviewUrlCliOption,
  });
}

I found multiple places where iframe.html is used  like

addons/storyshots/storyshots-puppeteer/src/url.js
lib/core/src/server/preview/iframe-webpack.config.js (I don't think this one is important though since I think it's only used when the preview is turned on, right ?
lib/ui/src/components/preview/preview.js (default props)

And that is pretty much it.
Though even though I'm trying to debug/log I don't seem to be able to find where it's ACTUALLY used by the HTML to load the iframe.
Maybe I'm missing something

According to the doc, you need to run yarn boostrap --core followed by yarn dev
yarn dev seems to build all the projects inside the app even though I just need to core really to be rebuilt on file change.
Is there a way to accomplish that ? My computer's RAM and CPU you thank you very much

Should I branch off master or next in my fork ?

Branch off next

Do you think it's OK if I reuse it to make sure the preview mode is disabled when my flag is also passed ?

Seems great, yeah! (Someone else, e.g. @igor-dv could probably say for sure)

addons/storyshots/storyshots-puppeteer/src/url.js

I think eventually we might want to be able to customize this too but not a high priority

I don't think this one is important though since I think it's only used when the preview is turned on, right ?

👍

Though even though I'm trying to debug/log I don't seem to be able to find where it's ACTUALLY used by the HTML to load the iframe.

I found the way the props/components get passed through the UI to be pretty confusing too but I can definitely say for sure that when I changed the default prop in lib/ui/src/components/preview/preview.js it definitely changed what was loaded in the iframe.
What is confusing is that if you say yarn link @storybook/core you'll run into the issue that it uses the DLL that is built by the UI won't get updated as you update the core package. So you won't see changes in a test app. To work around this in the official-storybook in the repo we somehow don't use the DLL. I'm not sure exactly how to set that up for another app.
The TLDR is it's easiest to do any development against the official-storybook.

yarn dev seems to build all the projects inside the app even though I just need to core really to be rebuilt on file change.

Once it has run it shouldn't do much though? I find it takes a little while to get going but then it's OK.

Once it has run it shouldn't do much though?
I guess it's ok ;)

The TLDR is it's easiest to do any development against the official-storybook.
Gotcha, it works fine now.

Manager
So, if all the stories are inside the "preview view" managed by another bundler, how is the manager supposed to know the list of stories to display on the left side of the page?

I'm able to load my preview in the iframe now but the manager has no idea what to display (which is normal I guess)
https://gyazo.com/eb1810e7307ebbe74350242198f91cea

Also, do you have any idea or example that you guys are already going on how to pass a CI options down to the UI / component layer?

I'm able to load my preview in the iframe now but the manager has no idea what to display (which is normal I guess)

It looks like maybe the right messages aren't coming over the channel for the storybook. Try watching the console messages at the "debug" level and you'll see what stories are reported by your preview.

Also, do you have any idea or example that you guys are already going on how to pass a CI options down to the UI / component layer?

I'm not aware of it being done (although it might be) already, but I think webpack define plugin is the typical way this is done?

PS feel free to reach out on discord

Alright I don't know what I changed but it works now

Will create a PR

https://github.com/storybooks/storybook/pull/6323

PR is still opened and currently in the review process...

Huzzah!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-alpha.33 containing PR #7235 that references this issue. Upgrade today to try it out!
You can find this prerelease on the @next NPM tag.
Closing this issue. Please re-open if you think there's still more to do.

Gadzooks!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-alpha.34 containing PR #7245 that references this issue. Upgrade today to try it out!
You can find this prerelease on the @next NPM tag.

@shilman I'm testing the alpha release heavily and it seems like the "zoom" button are throwing an exception and make the page entirely blank.
Does that ring a bell ? Should we open another issue for this ?
Uncaught TypeError: Cannot read property 'body' of null
    at IFrame.setIframeBodyStyle (vendors~main.d85284da259e1b1da394.bundle.js:166262)
    at IFrame.shouldComponentUpdate (vendors~main.d85284da259e1b1da394.bundle.js:166247)
    at checkShouldComponentUpdate (vendors~main.d85284da259e1b1da394.bundle.js:64940)
    at updateClassInstance (vendors~main.d85284da259e1b1da394.bundle.js:65410)
    at updateClassComponent (vendors~main.d85284da259e1b1da394.bundle.js:68418)
    at beginWork (vendors~main.d85284da259e1b1da394.bundle.js:69368)
    at performUnitOfWork (vendors~main.d85284da259e1b1da394.bundle.js:73036)
    at workLoop (vendors~main.d85284da259e1b1da394.bundle.js:73076)
    at HTMLUnknownElement.callCallback (vendors~main.d85284da259e1b1da394.bundle.js:53873)
    at Object.invokeGuardedCallbackDev (vendors~main.d85284da259e1b1da394.bundle.js:53923)

The above error occurred in the  component:
    in IFrame (created by ActualPreview)
    in div (created by Context.Consumer)
    in Styled(div) (created by Context.Consumer)
    in div (created by ActualPreview)
    in ActualPreview (created by Context.Consumer)
    in div (created by Context.Consumer)
    in Styled(div) (created by Preview)
    in Provider (created by Preview)
    in Provider (created by Preview)
    in Preview (created by Context.Consumer)
    in ManagerConsumer
    in Unknown (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Preview)
    in Preview (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in Main (created by Layout)
    in Layout (created by Context.Consumer)
    in WithTheme(Layout)
    in Unknown
    in Unknown
    in div (created by Context.Consumer)
    in Styled(div)
    in Unknown
    in Unknown (created by SizeMeRenderer(Component))
    in SizeMeReferenceWrapper (created by SizeMeRenderer(Component))
    in SizeMeRenderer(Component) (created by SizeMe(Component))
    in SizeMe(Component) (created by Manager)
    in ThemeProvider (created by Manager)
    in Manager (created by Context.Consumer)
    in Location (created by QueryLocation)
    in QueryLocation (created by Root)
    in LocationProvider (created by Root)
    in HelmetProvider (created by Root)
    in Root

@RPDeshaies Thanks for following up on this. Yeah I think it's a new issue!

@shilman Thanks for the awesome work, this preview-url feature is amazing! One note though: I couldn't manage to get addons to work in such setup. Not sure if I'm doing something wrong or it is not supported yet (or maybe an unrelated bug).
So in my parcel entrypoint I try to add info addon:
import { configure, addDecorator } from '@storybook/react';
import { withInfo } from '@storybook/addon-info';

function loadStories() {
  require('../../packages/typed-form/**/*.stories.tsx');
}

addDecorator(withInfo as any);
configure(loadStories, module);

And in the storybook in browser it displays loading state for eternity and in the console there is error:
Uncaught Error: Cannot find module './lib/nestedObjectAssign.js'
    at newRequire (storybook.9d40b3f6.js:37)
    at localRequire (storybook.9d40b3f6.js:53)
    at Object.parcelRequire.../../node_modules/nested-object-assign/index.js../package.json (index.js:3)
    at newRequire (storybook.9d40b3f6.js:47)
    at localRequire (storybook.9d40b3f6.js:53)
    at Object.parcelRequire.../../node_modules/@storybook/addon-info/dist/index.js.core-js/modules/es.object.assign (index.js:21)
    at newRequire (storybook.9d40b3f6.js:47)
    at localRequire (storybook.9d40b3f6.js:53)
    at Object.parcelRequire.storybook.tsx.@storybook/react (storybook.tsx:2)
...

localhost-1563670564688.log
Storybook version: 5.2.0-beta.4

@Eoksni that's possible! Mind filing a new issue so we can follow up on that?

@shilman Ok I'll try to reproduce it in a fresh setup and create new issue later today.

@Eoksni Ideal repro is in the storybook monorepo itself, since that's where we'll be debugging and iterating. TBH your current comment is probably enough 😄

@shilman Unfortunately I could not set up storybook monorepo - it failed the bootstrap at the node-gyp stage with some compilation errors, so I created fresh repo here https://github.com/Eoksni/poc-storybook-preview (using @storybook/react@next) and created new issue #7514.

authors: Eoksni RPDeshaies rolandjohann shilman tmeasday


text:
addon-backgrounds doesn't hide the addons panel when transparent

Describe the bug
Addon-backgrounds overwrites the background color of the preview. However, if the color is "cleared" or set to transparent, then the preview panel is also transparent and will not show the default theme background color but instead reveal the underlying addons-panel that should be hidden. This is due to the fact that "Showing or Hiding the Addons Panel" does in fact not change the size of the addons panel but changes the size of the preview panel so it completely covers it.
To Reproduce
Steps to reproduce the behavior:

Create a new empty directory
Create the HTML Kitchensink with npx -p @storybook/cli sb init --type html
Add addon-backgrounds with npm i -D @storybook/addon-backgrounds
Add import to config.js: import '@storybook/addon-backgrounds/register';
Add backgrounds to /stories/index.stories.js:

import { storiesOf } from '@storybook/html';
storiesOf('Demo', module)
  .addParameters({
    backgrounds: [
      { name: 'transparent', value: 'transparent', default: true },
      { name: 'facebook', value: '#3b5998' },
    ],
  })
  .add('heading', () => '
Hello World
');

Start the Storybook
Untick the "show Addons" in the "..." Dropdown or press hotkey A
BUG: It still shows the Addons Panel
Select "facebook" as background color in the background selector
Select "Clear Background" as background color in the background selector
BUG: It still shows the Addons Panel

Expected behavior
The Addon Panel should be hidden. Instead it still shows.
Screenshots

Additional context
Although this is technically correct (transparent being transparent), it should not be transparent because the preview panel needs one fallback background color. this should be the default background theme color.

Shiver me timbers!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.7 containing PR #6042 that references this issue. Upgrade today to try it out!
Because it's a pre-release you can find it on the @next NPM tag.

Ta-da!! I just released https://github.com/storybooks/storybook/releases/tag/v5.0.2 containing PR #6042 that references this issue. Upgrade today to try it out!

authors: glitchperfect shilman


text:
Revert "match phrase fix bug fix"

Reverts strandls/biodiv-esmodule#62

feature deployed via new branch hence closing the pr

repo: strandls/biodiv-esmodule


text:
Please tell me about unknown errors.

Even if I enter the parameters correctly, I get the following error
Do you know the cause?
ERROR 1 --- [nio-8080-exec-5] c.s.x.f.c.xrp.XrplClientServiceImpl      : Error sending payment to addressr....
java.lang.IllegalArgumentException: com.google.common.io.BaseEncoding$DecodingException: Invalid input length 29

curl -X POST --header 'Content-Type: application/json' --header 'Accept: application/json' -d '{
"amount": "2",
"currencyName": "CSC",
"fromClassicAddress": "rEvs...",
"fromPrivateKey": "s...",
"fromSigningPublicKey": "021...B5528",
"toClassicAddresses": [
"r...",
"r..."
],
"trustlineIssuerClassicAddress": "rCSCManTZ8ME9EoLrSHHYKW8PPwWMgkwr"
}' 'http://localhost:8080/api/payment'

Response Code:200
Response Body
{
"responseMessages": [
"FAILED to pay r...",
"FAILED to pay r..."
]
}

Your private key looks incorrect.  It should start with ED......
If you get the latest code I've added quite a bit of documentation to the swagger page.

authors: barryrknapp ramd

repo: strategyengine/fsedistributionservice


text:
Add "callbyname" API call on RPC controller

This PR includes the following:

Adds a "callbyname" API call to a new RPC controller
Adds a test case to test "callbyname".

Thank you, this is really nice.
I have some improvements in mind, we can discuss more here https://github.com/stratisproject/StratisBitcoinFullNode/issues/620

authors: bokobza quantumagi

repo: stratisproject/StratisBitcoinFullNode


text:
Feature/coinview flushing issue 525 take two

Before, during IBD, coinview did not flush. Flushing was implemented to be done in consensus loop in case our consensus chain processed a block that is at the tip of the best chain (i.e. not in IBD). Second flushing was implemented in FetchCoinsAsync method if the number of items in the cache reached certain (very high limit). Third flushing execution path was during shutdown.
Before, we fixed #426, which was a race condition between consensus loop accepting of a new block and the shutdown flushing thread. We solved it by first stopping the consensus loop and only then doing the flush. Naturally this problem is not present in the first flush way because it is done from consensus loop, but we did not fix the second way from FetchCoinsAsync.
So we have now removed flushing possibility from FCA and we kept the already fixed shutdown flushing and we changed flushing from consensus loop thread in a way it would flush more often (not just when we are at the tip). Now it is normal that this consensus loop flush does the flush in the middle of IBD and it does so if the last flush is more than 1 minute old.
This prevents the negative effect of #525, which was that due to no flushing for very long time, there were even hundreds of thousands blocks of data unflushed and when user invoked shutdown of the node, the waiting time for the flush to finish was even in hours. This should not happen anymore since we flush every minute during IBD.
Fix #525

Ah this is a much more simple solution then I though you are going to do.
Let me review closer and we commit.

Yes that is correct, initially I was looking for little more complex solution, but due to #426 problem, it was not easily possible. I would have to start introducing async locks (that don't yet exist in the code base) and the whole thing would be little bit messy. So I've decided to solve the problem with nonflushing during IBD with this simple approach and I think it is good enough.

Originally, I wanted to introduce two things - time limit and item limit. However, after quick analysis, the item limit would require maintenance of the counter and that would just increase the complexity without any great benefit. So at the end I ended up with just time limit.

Looks good now.

authors: Aprogiena dangershony


text:
V0.0.7 dev

Made single binary for Indigo node and Tendermint core
Improved tmstore websocket
Changed license to MPL-2.0

Codecov Report

Merging #109 into master will decrease coverage by -3.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   80.45%   77.15%   -3.31%
==========================================
  Files          29       29
  Lines        1847     1847
==========================================
- Hits         1486     1425      -61
- Misses        269      348      +79
+ Partials       92       74      -18

Impacted Files
Coverage Δ

generator/repo/repo.go
23.97% <0%> (-41.79%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 339004f...ad2a4a1. Read the comment docs.

repo: stratumn/sdk


text:
storetesting: improvements

I wanted to refactor the store tests to leverage test fixtures and assertions.
Test fixtures allow tests to run much faster (especially TMStore and other future blockchain stores) because we were previously creating a ton of blocks in each test case basically for nothing at all (especially in the FindSegments tests). We have benchmark tests to test what happens with a lot of segments, so normal tests don't need to create that many block.
I think that the tests are now much more readable.
I restructured a bit the files to better match the new store interfaces.
The push build now takes 13 minutes instead of 17: it's a good improvement!
And locally tests run faster which is nice when you're doing big changes :)

This change is

Great work!

Reviewed 14 of 14 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

authors: such t-bast


text:
Add support for description argument in mutations

Currently, when defining a Query, strawberry.django.field accepts a description kwarg, which will allow you to populate the GraphQL endpoint's autodoc with a description of that query.
Example:
@strawberry.type
class Query:
    recipes: List[Recipe] = strawberry.django.field(
        filters=RecipeFilter, description="Get a list of all Recipes."
    )

This works as expected.
Request:  Add support for the description argument to strawberry_django.mutations CUD views.
@strawberry.type
class Mutation:
    createTag: Tag = mutations.create(TagInput, description="Test")
    # This raises an unexpected argument error

I'll be submitting a PR for this issue as well.  It seems simple enough.

PR: https://github.com/strawberry-graphql/strawberry-graphql-django/pull/111
Not sure why Black is having an import failure on CI.