text:
Crash in Microsoft::Applications::Events::TelemetrySystem::handleIncomingEventPrepared?

OneDsCppSdk.iOS (3.5.117.1)

Hello, we often see this crash in our AppCenter crashes. Is this a common/known issue? Is this something that is fixed in more recent versions of OneDS?
Steps to reproduce.
We don't have a repro, just a stack trace.
What is the expected behavior?
No crash?
What is the actual behavior?
Crash
Additional context.
Stack trace

I had the same problem. But @lalitb i can't repro it. As you said, if it is caused by multi-threading, can it be changed to thread-safe?
Incident Identifier: 470597fe-450d-4d70-92bd-54f1ac57e8ea
CrashReporter Key:   38757214-F4B1-47D3-A4ED-32737E471AB5
Hardware Model:      iPhone11,6
Process:         XXX [648]
Path:            /private/var/containers/Bundle/Application/4C596567-0E15-4BA0-AEA6-CA5C8FA9C08D/XXX.app/XXX
Identifier:      XXX
Version:         22.4.400420001 (400420001)
Code Type:       arm64
Parent Process:   [1]

Date/Time:       2022-04-25T04:47:51.999Z
Launch Time:     2022-04-25T04:42:35Z
OS Version:      iPhone OS 14.7.1 (18G82)
Report Version:  104

Exception Type:  SIGSEGV
Exception Codes: SEGV_MAPERR at 0x283d6bbc80037
Crashed Thread:  2

Thread 2 Crashed:
0   XXX                        0x0000000100b0285c std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >::operator()(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) const (string:1459)
1   XXX                        0x0000000100b02be4 std::__1::__tree_node_base<void*>*& std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, CsProtocol::Value>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, CsProtocol::Value>, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, CsProtocol::Value> > >::__find_equal<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(std::__1::__tree_end_node<std::__1::__tree_node_base<void*>*>*&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) (map:537)
2   XXX                        0x0000000100b6a880 std::__1::pair<std::__1::__tree_iterator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, Microsoft::Applications::Events::Variant>, std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, Microsoft::Applications::Events::Variant>, void*>*, long>, bool> std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, Microsoft::Applications::Events::Variant>, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, Microsoft::Applications::Events::Variant>, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, Microsoft::Applications::Events::Variant> > >::__emplace_unique_key_args<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::piecewise_construct_t const&, std::__1::tuple<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&&>, std::__1::tuple<> >(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::piecewise_construct_t const&&&, std::__1::tuple<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&&>&&, std::__1::tuple<>&&) (__tree:2093)
3   XXX                        0x0000000100b269b8 Microsoft::Applications::Events::ILogConfiguration::operator[](char const*) (map:1560)
4   XXX                        0x0000000100b0f548 Microsoft::Applications::Events::RuntimeConfig_Default::IsClockSkewEnabled() (RuntimeConfig_Default.hpp:186)
5   XXX                        0x0000000100b43478 Microsoft::Applications::Events::OfflineStorageHandler::GetAndReserveRecords(std::__1::function<bool (Microsoft::Applications::Events::StorageRecord&&)> const&, unsigned int, Microsoft::Applications::Events::EventLatency, unsigned int) (OfflineStorageHandler.cpp:334)
6   XXX                        0x0000000100b36fd8 Microsoft::Applications::Events::StorageObserver::handleRetrieveEvents(std::__1::shared_ptr<Microsoft::Applications::Events::EventsUploadContext> const&) (StorageObserver.cpp:53)
7   XXX                        0x0000000100afacfc Microsoft::Applications::Events::TransmissionPolicyManager::uploadAsync(Microsoft::Applications::Events::EventLatency) (TransmissionPolicyManager.cpp:217)
8   XXX                        0x0000000100b483f8 Microsoft::Applications::Events::PlatformAbstraction::WorkerThread::threadFunc(void*) (WorkerThread.cpp:241)
9   XXX                        0x0000000100b48ae4 void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(void*), void*> >(void*) (type_traits:3918)
10  libsystem_pthread.dylib              0x00000001de5dcbfc _pthread_start + 316
11  libsystem_pthread.dylib              0x00000001de5e5758 thread_start + 4

Thread 0:
0   MicrosoftCognitiveServicesSpeech     0x00000001044b5670 0x1040d4000 + 4068976
1   libsystem_c.dylib                    0x000000019bd165c4 exit + 24
2   UIKitCore                            0x000000019536b2f0 -[UIApplication _terminateWithStatus:] + 500
3   UIKitCore                            0x00000001949b78cc -[_UISceneLifecycleMultiplexer _evalTransitionToSettings:fromSettings:forceExit:withTransitionStore:] + 124
4   UIKitCore                            0x00000001949b74fc -[_UISceneLifecycleMultiplexer forceExitWithTransitionContext:scene:] + 216
5   UIKitCore                            0x0000000195360dc0 -[UIApplication workspaceShouldExit:withTransitionContext:] + 208
6   FrontBoardServices                   0x00000001a1f3c9a8 -[FBSUIApplicationWorkspaceShim workspaceShouldExit:withTransitionContext:] + 84
7   FrontBoardServices                   0x00000001a1f6b3d4 __63-[FBSWorkspaceScenesClient willTerminateWithTransitionContext:]_block_invoke_2 + 76
8   FrontBoardServices                   0x00000001a1f4f6a4 -[FBSWorkspace _calloutQueue_executeCalloutFromSource:withBlock:] + 236
9   FrontBoardServices                   0x00000001a1f6b36c __63-[FBSWorkspaceScenesClient willTerminateWithTransitionContext:]_block_invoke + 128
10  libdispatch.dylib                    0x000000019255b81c _dispatch_client_callout + 16
11  libdispatch.dylib                    0x000000019255f30c _dispatch_block_invoke_direct + 264
12  FrontBoardServices                   0x00000001a1f93fa0 __FBSSERIALQUEUE_IS_CALLING_OUT_TO_A_BLOCK__ + 44
13  FrontBoardServices                   0x00000001a1f93c30 -[FBSSerialQueue _targetQueue_performNextIfPossible] + 444
14  FrontBoardServices                   0x00000001a1f94184 -[FBSSerialQueue _performNextFromRunLoopSource] + 28
15  CoreFoundation                       0x00000001928e8990 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 24
16  CoreFoundation                       0x00000001928e888c __CFRunLoopDoSource0 + 204
17  CoreFoundation                       0x00000001928e7b90 __CFRunLoopDoSources0 + 264
18  CoreFoundation                       0x00000001928e1b70 __CFRunLoopRun + 816
19  CoreFoundation                       0x00000001928e1308 CFRunLoopRunSpecific + 596
20  GraphicsServices                     0x00000001a9f64734 GSEventRunModal + 160
21  UIKitCore                            0x000000019535f75c -[UIApplication _run] + 1068
22  UIKitCore                            0x0000000195364fcc UIApplicationMain + 164
23  XXX                        0x0000000100801810 main (main.swift:17)
24  libdyld.dylib                        0x000000019259dcf8 start + 0

Thread 1:
0   libsystem_kernel.dylib               0x00000001c0b344fc mach_msg_trap + 8
1   CoreFoundation                       0x00000001928e7e58 __CFRunLoopServiceMachPort + 368
2   CoreFoundation                       0x00000001928e1cf8 __CFRunLoopRun + 1208
3   CoreFoundation                       0x00000001928e1308 CFRunLoopRunSpecific + 596
4   Foundation                           0x0000000193bd0d8c -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 228
5   Foundation                           0x0000000193bd0c58 -[NSRunLoop(NSRunLoop) runUntilDate:] + 88
6   UIKitCore                            0x0000000195414304 -[UIEventFetcher threadMain] + 512
7   Foundation                           0x0000000193d4230c __NSThread__start__ + 860
8   libsystem_pthread.dylib              0x00000001de5dcbfc _pthread_start + 316
9   libsystem_pthread.dylib              0x00000001de5e5758 thread_start + 4

Thread 3:
0   libsystem_kernel.dylib               0x00000001c0b590cc __psynch_cvwait + 8
1   libc++.1.dylib                       0x00000001a74f3f98 std::__1::condition_variable::__do_timed_wait(std::__1::unique_lock<std::__1::mutex>&, std::__1::chrono::time_point<std::__1::chrono::system_clock, std::__1::chrono::duration<long long, std::__1::ratio<1l, 1000000000l> > >) + 96
2   JavaScriptCore                       0x000000019cd61118 bmalloc::Scavenger::threadRunLoop() + 548
3   JavaScriptCore                       0x000000019cd60bcc bmalloc::Scavenger::threadEntryPoint(bmalloc::Scavenger*) + 12
4   JavaScriptCore                       0x000000019cd620e4 void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, void (*)(bmalloc::Scavenger*), bmalloc::Scavenger*> >(void*) + 44
5   libsystem_pthread.dylib              0x00000001de5dcbfc _pthread_start + 316
6   libsystem_pthread.dylib              0x00000001de5e5758 thread_start + 4

Thread 4:
0   XXX                        0x0000000100ccfc14 mach_exception_callback (PLCrashReporter.m:296)
1   XXX                        0x0000000100cdb88c exception_server_thread (PLCrashMachExceptionServer.m:780)
2   libsystem_pthread.dylib              0x00000001de5dcbfc _pthread_start + 316
3   libsystem_pthread.dylib              0x00000001de5e5758 thread_start + 4

Thread 5:
0   libsystem_kernel.dylib               0x00000001c0b344fc mach_msg_trap + 8
1   CoreFoundation                       0x00000001928e7e58 __CFRunLoopServiceMachPort + 368
2   CoreFoundation                       0x00000001928e1cf8 __CFRunLoopRun + 1208
3   CoreFoundation                       0x00000001928e1308 CFRunLoopRunSpecific + 596
4   CoreFoundation                       0x00000001928e23f4 CFRunLoopRun + 60
5   XXX                        0x0000000100d22548 -[BCNRunLoopThread threadLoop] (BCNRunLoopThread.m:113)
6   Foundation                           0x0000000193d4230c __NSThread__start__ + 860
7   libsystem_pthread.dylib              0x00000001de5dcbfc _pthread_start + 316
8   libsystem_pthread.dylib              0x00000001de5e5758 thread_start + 4

Thread 6:
0   libsystem_kernel.dylib               0x00000001c0b344fc mach_msg_trap + 8
1   CoreFoundation                       0x00000001928e7e58 __CFRunLoopServiceMachPort + 368
2   CoreFoundation                       0x00000001928e1cf8 __CFRunLoopRun + 1208
3   CoreFoundation                       0x00000001928e1308 CFRunLoopRunSpecific + 596
4   CoreFoundation                       0x00000001928e23f4 CFRunLoopRun + 60
5   CoreMotion                           0x000000019da78c78 CLClientCreateIso6709Notation + 196100
6   libsystem_pthread.dylib              0x00000001de5dcbfc _pthread_start + 316
7   libsystem_pthread.dylib              0x00000001de5e5758 thread_start + 4

Thread 7:
0   libsystem_kernel.dylib               0x00000001c0b344fc mach_msg_trap + 8
1   CoreFoundation                       0x00000001928e7e58 __CFRunLoopServiceMachPort + 368
2   CoreFoundation                       0x00000001928e1cf8 __CFRunLoopRun + 1208
3   CoreFoundation                       0x00000001928e1308 CFRunLoopRunSpecific + 596
4   AudioSession                         0x000000019a390f20 GenericRunLoopThread::Entry(void*) + 160
5   AudioSession                         0x000000019a3930d8 CAPThread::Entry(CAPThread*) + 88
6   libsystem_pthread.dylib              0x00000001de5dcbfc _pthread_start + 316
7   libsystem_pthread.dylib              0x00000001de5e5758 thread_start + 4

Thread 8:
0   libsystem_kernel.dylib               0x00000001c0b344fc mach_msg_trap + 8
1   CoreFoundation                       0x00000001928e7e58 __CFRunLoopServiceMachPort + 368
2   CoreFoundation                       0x00000001928e1cf8 __CFRunLoopRun + 1208
3   CoreFoundation                       0x00000001928e1308 CFRunLoopRunSpecific + 596
4   CFNetwork                            0x00000001931bfb38 _CFURLStorageSessionCopyCache + 64264
5   Foundation                           0x0000000193d4230c __NSThread__start__ + 860
6   libsystem_pthread.dylib              0x00000001de5dcbfc _pthread_start + 316
7   libsystem_pthread.dylib              0x00000001de5e5758 thread_start + 4

Thread 9:
0   libsystem_kernel.dylib               0x00000001c0b344fc mach_msg_trap + 8
1   CoreFoundation                       0x00000001928e7e58 __CFRunLoopServiceMachPort + 368
2   CoreFoundation                       0x00000001928e1cf8 __CFRunLoopRun + 1208
3   CoreFoundation                       0x00000001928e1308 CFRunLoopRunSpecific + 596
4   WebCore                              0x00000001a00961ac RunWebThread(void*) + 684
5   libsystem_pthread.dylib              0x00000001de5dcbfc _pthread_start + 316
6   libsystem_pthread.dylib              0x00000001de5e5758 thread_start + 4

Thread 10:
0   libsystem_kernel.dylib               0x00000001c0b5a0a4 __workq_kernreturn + 8
1   libsystem_pthread.dylib              0x00000001de5e574c start_wqthread + 4

Thread 11:
0   libsystem_kernel.dylib               0x00000001c0b5a0a4 __workq_kernreturn + 8
1   libsystem_pthread.dylib              0x00000001de5e574c start_wqthread + 4

Thread 12:
0   libsystem_kernel.dylib               0x00000001c0b5a0a4 __workq_kernreturn + 8
1   libsystem_pthread.dylib              0x00000001de5e574c start_wqthread + 4

Thread 13:
0   libsystem_kernel.dylib               0x00000001c0b5a0a4 __workq_kernreturn + 8
1   libsystem_pthread.dylib              0x00000001de5e574c start_wqthread + 4

Thread 14:
0   libsystem_kernel.dylib               0x00000001c0b5a0a4 __workq_kernreturn + 8
1   libsystem_pthread.dylib              0x00000001de5e574c start_wqthread + 4

Thread 15:
0   libsystem_kernel.dylib               0x00000001c0b5a0a4 __workq_kernreturn + 8
1   libsystem_pthread.dylib              0x00000001de5e574c start_wqthread + 4

Thread 16:
0   libsystem_kernel.dylib               0x00000001c0b590cc __psynch_cvwait + 8
1   JavaScriptCore                       0x000000019cce7978 WTF::ParkingLot::parkConditionallyImpl(void const*, WTF::ScopedLambda<bool ()> const&, WTF::ScopedLambda<void ()> const&, WTF::TimeWithDynamicClockType const&) + 2776
2   JavaScriptCore                       0x000000019c522d1c bool WTF::Condition::waitUntil<WTF::Lock>(WTF::Lock&, WTF::TimeWithDynamicClockType const&) + 192
3   JavaScriptCore                       0x000000019ccb41e8 WTF::Detail::CallableWrapper<WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0, void>::call() + 200
4   JavaScriptCore                       0x000000019cd0b84c WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 312
5   JavaScriptCore                       0x000000019cd0e00c WTF::wtfThreadEntryPoint(void*) + 12
6   libsystem_pthread.dylib              0x00000001de5dcbfc _pthread_start + 316
7   libsystem_pthread.dylib              0x00000001de5e5758 thread_start + 4

Thread 17:
0   libsystem_kernel.dylib               0x00000001c0b590cc __psynch_cvwait + 8
1   JavaScriptCore                       0x000000019cce7978 WTF::ParkingLot::parkConditionallyImpl(void const*, WTF::ScopedLambda<bool ()> const&, WTF::ScopedLambda<void ()> const&, WTF::TimeWithDynamicClockType const&) + 2776
2   JavaScriptCore                       0x000000019c522d1c bool WTF::Condition::waitUntil<WTF::Lock>(WTF::Lock&, WTF::TimeWithDynamicClockType const&) + 192
3   JavaScriptCore                       0x000000019ccb41e8 WTF::Detail::CallableWrapper<WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0, void>::call() + 200
4   JavaScriptCore                       0x000000019cd0b84c WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 312
5   JavaScriptCore                       0x000000019cd0e00c WTF::wtfThreadEntryPoint(void*) + 12
6   libsystem_pthread.dylib              0x00000001de5dcbfc _pthread_start + 316
7   libsystem_pthread.dylib              0x00000001de5e5758 thread_start + 4

Thread 18:
0   libsystem_kernel.dylib               0x00000001c0b590cc __psynch_cvwait + 8
1   JavaScriptCore                       0x000000019cce7978 WTF::ParkingLot::parkConditionallyImpl(void const*, WTF::ScopedLambda<bool ()> const&, WTF::ScopedLambda<void ()> const&, WTF::TimeWithDynamicClockType const&) + 2776
2   JavaScriptCore                       0x000000019c522d1c bool WTF::Condition::waitUntil<WTF::Lock>(WTF::Lock&, WTF::TimeWithDynamicClockType const&) + 192
3   JavaScriptCore                       0x000000019ccb41e8 WTF::Detail::CallableWrapper<WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0, void>::call() + 200
4   JavaScriptCore                       0x000000019cd0b84c WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 312
5   JavaScriptCore                       0x000000019cd0e00c WTF::wtfThreadEntryPoint(void*) + 12
6   libsystem_pthread.dylib              0x00000001de5dcbfc _pthread_start + 316
7   libsystem_pthread.dylib              0x00000001de5e5758 thread_start + 4

Thread 19:
0   libsystem_kernel.dylib               0x00000001c0b590cc __psynch_cvwait + 8
1   JavaScriptCore                       0x000000019cce7978 WTF::ParkingLot::parkConditionallyImpl(void const*, WTF::ScopedLambda<bool ()> const&, WTF::ScopedLambda<void ()> const&, WTF::TimeWithDynamicClockType const&) + 2776
2   JavaScriptCore                       0x000000019c522d1c bool WTF::Condition::waitUntil<WTF::Lock>(WTF::Lock&, WTF::TimeWithDynamicClockType const&) + 192
3   JavaScriptCore                       0x000000019ccb41e8 WTF::Detail::CallableWrapper<WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0, void>::call() + 200
4   JavaScriptCore                       0x000000019cd0b84c WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 312
5   JavaScriptCore                       0x000000019cd0e00c WTF::wtfThreadEntryPoint(void*) + 12
6   libsystem_pthread.dylib              0x00000001de5dcbfc _pthread_start + 316
7   libsystem_pthread.dylib              0x00000001de5e5758 thread_start + 4

Thread 20:
0   libsystem_kernel.dylib               0x00000001c0b590cc __psynch_cvwait + 8
1   JavaScriptCore                       0x000000019cce7978 WTF::ParkingLot::parkConditionallyImpl(void const*, WTF::ScopedLambda<bool ()> const&, WTF::ScopedLambda<void ()> const&, WTF::TimeWithDynamicClockType const&) + 2776
2   JavaScriptCore                       0x000000019c522d1c bool WTF::Condition::waitUntil<WTF::Lock>(WTF::Lock&, WTF::TimeWithDynamicClockType const&) + 192
3   JavaScriptCore                       0x000000019ccb41e8 WTF::Detail::CallableWrapper<WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0, void>::call() + 200
4   JavaScriptCore                       0x000000019cd0b84c WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 312
5   JavaScriptCore                       0x000000019cd0e00c WTF::wtfThreadEntryPoint(void*) + 12
6   libsystem_pthread.dylib              0x00000001de5dcbfc _pthread_start + 316
7   libsystem_pthread.dylib              0x00000001de5e5758 thread_start + 4

Thread 2 crashed with arm64 Thread State:
   x21: 0x000000016f9d2db8     x2: 0x0000000000000000    x16: 0x00000001de5d8a70     x3: 0xfffffffffffffff1
   x22: 0x000283d6bbc80020     x4: 0x0000000000000065    x17: 0x0000000000000002   cpsr: 0x0000000080000000
    x5: 0x0000000000000074    x23: 0x000283d6bbc80000     x6: 0x000000000000006d    x18: 0x0000000000000000
   x10: 0x0000000000000000     lr: 0x0000000100b02be4     x7: 0x000000016f9d2cc0    x24: 0x000000016f9d2e78
   x11: 0x0000000000000000     x8: 0x000283d6bbc80000    x19: 0x000000016f9d2d78    x25: 0x00000000000001bf
    x9: 0x0000000000000000    x12: 0x0000010000000000     fp: 0x000000016f9d2d10    x26: 0x00000000016926bc
   x13: 0x0000000000000000     pc: 0x0000000100b0285c    x27: 0x0000000282848d80    x14: 0x0000000000000000
   x20: 0x0000000283d7000e     x0: 0x000000016f9d2db8     sp: 0x000000016f9d2d00    x28: 0xfffffffffffffffa
   x15: 0x0000000000000000     x1: 0x000283d6bbc80020

Binary Images:
0x00000001007fc000 -        0x0000000103623fff +XXX arm64  <c189a7ec0d013a6e91e8356f25557e17> /private/var/containers/Bundle/Application/4C596567-0E15-4BA0-AEA6-CA5C8FA9C08D/XXX.app/XXX
0x0000000103e0c000 -        0x0000000103e13fff +MSMapNavigationTelemetryAria arm64  <ccbc8133a7853166838563025d317a3f> /private/var/containers/Bundle/Application/4C596567-0E15-4BA0-AEA6-CA5C8FA9C08D/XXX.app/Frameworks/MSMapNavigationTelemetryAria.framework/MSMapNavigationTelemetryAria
0x0000000103fd4000 -        0x0000000104057fff +AriaObjC arm64  <bdb7a27f41433458b51b38a0378af57b> /private/var/containers/Bundle/Application/4C596567-0E15-4BA0-AEA6-CA5C8FA9C08D/XXX.app/Frameworks/AriaObjC.framework/AriaObjC
0x00000001040d4000 -        0x00000001049e7fff +MicrosoftCognitiveServicesSpeech arm64  <da051163ba4837bbb12f9a2646df918a> /private/var/containers/Bundle/Application/4C596567-0E15-4BA0-AEA6-CA5C8FA9C08D/XXX.app/Frameworks/MicrosoftCognitiveServicesSpeech.framework/MicrosoftCognitiveServicesSpeech
0x0000000104d3c000 -        0x0000000104d57fff +MicrosoftMapsMicrosoftTextToSpeech arm64  <c88b1cafaad639e697545c5be49cddf7> /private/var/containers/Bundle/Application/4C596567-0E15-4BA0-AEA6-CA5C8FA9C08D/XXX.app/Frameworks/MicrosoftMapsMicrosoftTextToSpeech.framework/MicrosoftMapsMicrosoftTextToSpeech
0x0000000104d98000 -        0x0000000105bbffff +MicrosoftMapsNavigation arm64  <976d81dfa64e3143973c9b20e23c1231> /private/var/containers/Bundle/Application/4C596567-0E15-4BA0-AEA6-CA5C8FA9C08D/XXX.app/Frameworks/MicrosoftMapsNavigation.framework/MicrosoftMapsNavigation
0x0000000107dbc000 -        0x0000000107dd7fff +MicrosoftNavigationGPSTrace arm64  <ceb787dcccdc3289a554485d46e9503c> /private/var/containers/Bundle/Application/4C596567-0E15-4BA0-AEA6-CA5C8FA9C08D/XXX.app/Frameworks/MicrosoftNavigationGPSTrace.framework/MicrosoftNavigationGPSTrace
0x0000000107e14000 -        0x0000000107e2bfff +SSZipArchive arm64  <d0d22c511aa935929a0340346a229886> /private/var/containers/Bundle/Application/4C596567-0E15-4BA0-AEA6-CA5C8FA9C08D/XXX.app/Frameworks/SSZipArchive.framework/SSZipArchive
0x0000000192557000 -        0x000000019259bfff  libdispatch.dylib arm64e  <9555d7d99c923af39837ae1f5aa7da44> /usr/lib/system/libdispatch.dylib
0x000000019259c000 -        0x00000001925d8fff  libdyld.dylib arm64e  <ff7d256792773aa6b3dd2c5748e432a6> /usr/lib/system/libdyld.dylib
0x0000000192845000 -        0x0000000192c04fff  CoreFoundation arm64e  <338f58b19b7538a0b908e2574ab1d39a> /System/Library/Frameworks/CoreFoundation.framework/CoreFoundation
0x0000000192f74000 -        0x0000000193406fff  CFNetwork arm64e  <df2aa3047ef2311688065072ece34942> /System/Library/Frameworks/CFNetwork.framework/CFNetwork
0x0000000193bc8000 -        0x0000000193e7efff  Foundation arm64e  <4e7d1ff66b6438339e60cc662afe2647> /System/Library/Frameworks/Foundation.framework/Foundation
0x0000000194795000 -        0x0000000195ba0fff  UIKitCore arm64e  <41d9bf6284393b2199594e27e75c294e> /System/Library/PrivateFrameworks/UIKitCore.framework/UIKitCore
0x000000019a384000 -        0x000000019a39bfff  AudioSession arm64e  <1e000caa0b2034debab4ba6000e48199> /System/Library/PrivateFrameworks/AudioSession.framework/AudioSession
0x000000019bcbe000 -        0x000000019bd3dfff  libsystem_c.dylib arm64e  <117637f82c663b93b239a0e23fc95d62> /usr/lib/system/libsystem_c.dylib
0x000000019bd89000 -        0x000000019ce59fff  JavaScriptCore arm64e  <dbc92bff45e83eb0b670612c8cc19b56> /System/Library/Frameworks/JavaScriptCore.framework/JavaScriptCore
0x000000019d92c000 -        0x000000019db9ffff  CoreMotion arm64e  <ba3987d6a1af360aa6c324399bf3d66d> /System/Library/Frameworks/CoreMotion.framework/CoreMotion
0x000000019f534000 -        0x00000001a1adbfff  WebCore arm64e  <dab838aed09e3e3aaadfe0edafcc6902> /System/Library/PrivateFrameworks/WebCore.framework/WebCore
0x00000001a1f36000 -        0x00000001a1fbffff  FrontBoardServices arm64e  <7c0b0af0337138af85345e4bb65286f4> /System/Library/PrivateFrameworks/FrontBoardServices.framework/FrontBoardServices
0x00000001a74ea000 -        0x00000001a7545fff  libc++.1.dylib arm64e  <a0b465d224273dd08577866a3f211ebb> /usr/lib/libc++.1.dylib
0x00000001a9f61000 -        0x00000001a9f69fff  GraphicsServices arm64e  <04a3f8ac0afa3689ab0c613cf170255a> /System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices
0x00000001c0b30000 -        0x00000001c0b62fff  libsystem_kernel.dylib arm64e  <ef6b203fbeed30698623bf884b0f2bad> /usr/lib/system/libsystem_kernel.dylib
0x00000001de5d3000 -        0x00000001de5d9fff  libsystem_platform.dylib arm64e  <987d48d53caa34d79141c0bd6e2351e8> /usr/lib/system/libsystem_platform.dylib
0x00000001de5db000 -        0x00000001de5e6fff  libsystem_pthread.dylib arm64e  <9f849e98f7423b3db01a61f75acf0540> /usr/lib/system/libsystem_pthread.dylib

@iCodeWoods - this seems to be the scenario where Thread0 is exiting, while Thread2 is still trying to upload the events. Please refer to the use-after-free.md on how to properly shutdown the application without crash.

We are also observing similar crashes in Teams mobile iOS. Not able to reproduce the crash though. Mainly happening in the logTrace.
<img width="1438" alt="Screenshot 2022-05-02 at 11 01 03 AM" https://user-images.githubusercontent.com/85876413/166188644-5facfb3f-a389-44c2-ad62-ae9d6b77b7cc.png">
cc: @aamittal1989

Please refer to comment here : https://github.com/microsoft/cpp_client_telemetry/issues/1012#issuecomment-1115758486

@iCodeWoods , @nishchith-cp  - Did above suggestion worked, or are you still seeing this issue?

I was blocked from updating the SDK to the latest due to API issues, Hence couldn't verify this. Will be updating and making these changes this month.

@tachtevrenidis  @iCodeWoods @nishchith-cp  - Keeping it open for this week if there is any repro of the issue. As mentioned earlier, if this issue is happening during shutdown, Please refer to the use-after-free.md on how to properly shutdown the application without crash.

Hey @lalitb
I am still seeing the crashes after making the below changes.

Updated the SDK to the latest version
Calling the below method on app termination (before force quit also) scenarios of the application.

ODWLogManager.flush()
ODWLogManager.applicationWillTerminate() // This inturn calls pauseTransmission and flushAndTeardown

Attaching the reports here.
TeamsAppCrash.txt
cc: @aamittal1989

Hi @lalitb Any updates on this.

@nishchith-cp - This crash seems to be coming from ongoing requests which can't be stopped/paused using pauseTransmission, and flushAndTearDown. As of now, you can try to wait for random time between pause and teardown. This will reduce the possibility of crash but won't eliminate it.
The more complete solution needs to be implemented in v4 release - #822. Please raise a dependency ask to our team for this to be taken care in next semester planning asap. Reach out to our PM Carter Socha for that. I don't see any better solution for this as of now.

@nishchith-cp - Can you confirm if the latest thread is during app shutdown? In that case, can you ensure that all the ongoing threads are joined to main thread before shutdown, and before invoking flush and applicationWillTerminate from main thread.  Looking into the crash dump, there are threads in the application which are still trying to send the event.

Hey @lalitb
With the proposed fix we still observed crashes during app termination. We added a fix to stop any telemetry being logged on app termination or the app force quit scenarios. Will continue to monitor.
Though we are able to see crashes pointing to OneDS SDK when we force quit the application. The crash log I attached is mainly when the app is being forced to quit by calling exit(0) in scenarios like AppCenter app update, some settings changes, etc.
Below crash on app force quit scenario.
report-2517411459120009999-fc42b211-6b47-42a7-9dff-88fea4c5d731.txt
Is there a way we can join the ongoing thread to the main thread? I don't this so. Once the task in the thread is triggered we don't have control over it.

Is there a way we can join the ongoing thread to the main thread? I don't this so. Once the task in the thread is triggered we don't have control over it.

Why is this not possible. Just curious - Which thread library is used here? In case of force exit, the 1ds sdk library behavior is undefined.

@lalitb We are using dispatch_queue and once the task is dispatched we don't have any control over it. We cannot log events on the main thread.

Hey @lalitb
With the updated SDK and the clean-up changes we are seeing around 43.5k crashes on app termination flow with 100% rollout. Can we do something from SDK side to avoid these crashes. Or any more suggestions on app side changes?
We have created below

Here is the crash report.
report-2517392601050009999-8d6601a2-791f-4378-8cd9-9fcd6a0947b8.txt
Below is the dependency task craeted.
https://dev.azure.com/msazure/One/_workitems/edit/15323230
cc: @aamittal1989

@iCodeWoods Are you still seeing these crashes in AppCenter post the suggested fix?

authors: iCodeWoods lalitb nishchith-cp tachtevrenidis


text:
"Condition not met" errors

Thank you for building and releasing this tool!
I am attempting to load a log file into Deopt Explorer, but unfortunately it is not yet working for me.
Running node with these flags (copied from https://devblogs.microsoft.com/typescript/introducing-deopt-explorer/?ref=refind#generating-a-log):
--log-deopt \
--redirect-code-traces \
--redirect-code-traces-to=\\.\NUL \
--log-ic \
--log-maps \
--log-maps-details \
--log-code \
--log-source-code \
--prof \
--log-internal-timer-events \
--detailed-line-info \
--logfile=v8.log \
--no-logfile-per-isolate \
--unhandled-rejections=strict

This is the first line logged:
[INFO: 16:29:09.153] Detected log for V8 9.3.345.19-node.14

It tries to load the file for a while, and I see a bunch of errors (hundreds or maybe thousands) like the following logged in the Output:
[ERR!: 16:29:09.535] line 3411: Condition not met
Error: Condition not met
    at t.assert (/Users/joe_lencioni/.vscode/extensions/rbuckton.deoptexplorer-vscode-1.1.0-darwin-arm64/dist/extension.js:2:80962)
    at t.LogProcessor.processMapEvent (/Users/joe_lencioni/.vscode/extensions/rbuckton.deoptexplorer-vscode-1.1.0-darwin-arm64/dist/extension.js:2:186804)
    at u.dispatchLogRow_ (/Users/joe_lencioni/.vscode/extensions/rbuckton.deoptexplorer-vscode-1.1.0-darwin-arm64/dist/extension.js:165:35867)
    at u.processLogLine_ (/Users/joe_lencioni/.vscode/extensions/rbuckton.deoptexplorer-vscode-1.1.0-darwin-arm64/dist/extension.js:165:36324)
    at u.processLogLine (/Users/joe_lencioni/.vscode/extensions/rbuckton.deoptexplorer-vscode-1.1.0-darwin-arm64/dist/extension.js:165:34613)
    at t.LogProcessor.processContent (/Users/joe_lencioni/.vscode/extensions/rbuckton.deoptexplorer-vscode-1.1.0-darwin-arm64/dist/extension.js:2:174533)
    at t.measureAsync (/Users/joe_lencioni/.vscode/extensions/rbuckton.deoptexplorer-vscode-1.1.0-darwin-arm64/dist/extension.js:5:27435)
    at t.LogProcessor.process (/Users/joe_lencioni/.vscode/extensions/rbuckton.deoptexplorer-vscode-1.1.0-darwin-arm64/dist/extension.js:2:174807)
    at /Users/joe_lencioni/.vscode/extensions/rbuckton.deoptexplorer-vscode-1.1.0-darwin-arm64/dist/extension.js:5:41968

I also spotted this in the logs:
[ERR!: 16:39:25.422] dropping: overflow

After waiting a bit more, the extension usually crashes and the logs are cleared. I managed to have it run once where instead of crashing it just kept running, and I saw the following logged:
[INFO: 16:40:43.129] processContent took 83,184.0ms
[INFO: 16:40:43.184] Error: ENOENT: no such file or directory, realpath '/Users/joe_lencioni/repo/node_modules/ts-node/src/index.ts'
    at Function.realpathSync.native (node:fs:2602:3)
    at Function.native (node:electron/js2c/asar_bundle:2:4804)
    at h (/Users/joe_lencioni/.vscode/extensions/rbuckton.deoptexplorer-vscode-1.1.0-darwin-arm64/dist/extension.js:5:28829)
    at f (/Users/joe_lencioni/.vscode/extensions/rbuckton.deoptexplorer-vscode-1.1.0-darwin-arm64/dist/extension.js:5:28959)
    at /Users/joe_lencioni/.vscode/extensions/rbuckton.deoptexplorer-vscode-1.1.0-darwin-arm64/dist/extension.js:2:110463
    at Array.map (<anonymous>)
    at t.SourceMap.get sources [as sources] (/Users/joe_lencioni/.vscode/extensions/rbuckton.deoptexplorer-vscode-1.1.0-darwin-arm64/dist/extension.js:2:110434)
    at /Users/joe_lencioni/.vscode/extensions/rbuckton.deoptexplorer-vscode-1.1.0-darwin-arm64/dist/extension.js:2:175455
    at t.measureAsync (/Users/joe_lencioni/.vscode/extensions/rbuckton.deoptexplorer-vscode-1.1.0-darwin-arm64/dist/extension.js:5:27435)
    at t.LogProcessor.process (/Users/joe_lencioni/.vscode/extensions/rbuckton.deoptexplorer-vscode-1.1.0-darwin-arm64/dist/extension.js:2:174925)
    at /Users/joe_lencioni/.vscode/extensions/rbuckton.deoptexplorer-vscode-1.1.0-darwin-arm64/dist/extension.js:5:41968 {
  errno: -2,
  syscall: 'realpath',
  code: 'ENOENT',
  path: '/Users/joe_lencioni/repo/node_modules/ts-node/src/index.ts'
}

Unfortunately, I cannot share the code that I am running this on, but I can say that I am running this code using ts-node/register with the swc transpiler, in case that matters here.
I also am running with some code like the following, which overrides node's Module._resolveFilename to enable some special import path formats:
const Module = require('module');

const transformPath = require('.');

const origResolveFilename = Module._resolveFilename;

Module._resolveFilename = function _resolveFilename(request, ...extraArgs) {
  return origResolveFilename(transformPath(request), ...extraArgs);
}

Please let me know if there is some more info I can provide.

The v1.1.1 version that I just published should help with the ENOENT error you saw in the log.
I have an idea as to the possible cause of the "Condition not met" error, and I'm looking into a fix. In this case, it's coming from a map transition that is pointing to a prior map that wasn't recorded or couldn't be resolved.

I've made a minor change in #28 related to the "Condition not met" error. I've switched this to instead log a warning to the output channel with a better description, and to try and use whatever information is available when recording the update. However, I don't think this change will have a major impact on the crashes you were seeing. In the meantime, I'd suggest trying again with the latest version of the extension to check if you are still seeing a crash.
I don't have a repro for the "condition not met" issue at present. Without a repro this is likely the best I can do to resolve this.

Thank you!

source: gharchive/issue

authors: lencioni rbuckton

repo: microsoft/deoptexplorer-vscode

license: MIT

license_type: permissive

license_source: github-api


text:
Incongruence Color Switching from Dark to Light Theme

Dev Home version
0.601.297.0
Windows build number
10.0.22631.2338
Other software
OS Build Version: 10.0.22631.2338.amd64fre.ni_release.220506-1250
.NET Version: .NET 6.0.23
Steps to reproduce the bug
• Open the app
• Tap on Settings
• Tap on Theme Preferences
• Tap on Accordion and select the Light theme
Expected result
I expect every section of the app, text and screen, to be consistent with the theme set
Actual result
The app doesn't apply the light theme evenly.
It is impossible to read the text in the left sidebar.

Included System Information
Physical Memory: 5.88GB (2.14GB free)
Processor Architecture: x64
Included Extensions Information
Extensions:
Microsoft.Windows.DevHome_0.601.297.0_x64__8wekyb3d8bbwe
Microsoft.Windows.DevHomeGitHubExtension_0.600.283.0_x64__8wekyb3d8bbwe

Duplicate of #993

repo: microsoft/devhome


text:
The version and platform specific code seems not necessary and still could fails to meet the need of Ignore case comparison.

The version and platform specific code seems not necessary and still could fails to meet the need of Ignore case comparison.
Originally posted by @Lxiamail in https://github.com/microsoft/dotnet-apiport/pull/809

Closing as API Port was deprecated in favor of binary analysis in .NET Upgrade Assistant.

authors: Lxiamail terrajobst

repo: microsoft/dotnet-apiport


text:
Need tool to generate BTF data from PE images generated by MSVC tool chain

BTF is a machine-readable format for introspection of OS interfaces (like syscalls). Linux has a tool called pahole that does this, but Windows lacks a similar feature.

@Alan-Jowett please add more details on possible solutions to this for someone else to pick this up. And please add use cases (such as invoking helpers with BTF Id).

https://github.com/aquasecurity/btfhub/blob/main/docs/how-to-use-pahole.md

authors: Alan-Jowett dthaler shankarseal

repo: microsoft/ebpf-for-windows


text:
ADUtils.cs appears to have the wrong token suffix

Line 43 should be "/oauth2/v2.0/token" rather than "/oauth2/token".

Will change the loader to use a service client (rather than MSI) in non-proxy installations.

@TerriblyVexed we're now using a library to acquire tokens.

authors: TerriblyVexed daemel mikaelweave

repo: microsoft/fhir-loader


text:
(Watch XXX Video)Erin Bugis Leaked Video Trending ON Twitter Melayu Telegram

9 seconds ago — F.ULL V.IDEOS] Erin Bugis L.eaked V.ideo V.iral On S.ocial M.edia
Erin Bugis video took the internet by storm and amazed viewers on various social media platforms. Erin Bugis, a young and talented digital creator, recently became famous thanks to this interesting video.
Erin Bugis video instagram
Erin Bugis video oficial twitter

➤►
▶
➤►
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼  𝗙𝘂𝗹𝗹 𝗛𝗗 ▶
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼 𝗙𝘂𝗹𝗹 𝗛𝗗  ▶
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 1920x 𝗙𝘂𝗹𝗹 𝗛𝗗▶
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
▶
➤►
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼  𝗙𝘂𝗹𝗹 𝗛𝗗 ▶
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼 𝗙𝘂𝗹𝗹 𝗛𝗗  ▶
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 1920x 𝗙𝘂𝗹𝗹 𝗛𝗗▶
➤►
▶
➤►
▶
➤►
➤►
▶
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼  𝗙𝘂𝗹𝗹 𝗛𝗗 ▶
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼 𝗙𝘂𝗹𝗹 𝗛𝗗  ▶
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 1920x 𝗙𝘂𝗹𝗹 𝗛𝗗▶
➤►
▶
➤►
▶
➤►
➤►
▶
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼  𝗙𝘂𝗹𝗹 𝗛𝗗 ▶
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼 𝗙𝘂𝗹𝗹 𝗛𝗗  ▶
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 1920x 𝗙𝘂𝗹𝗹 𝗛𝗗▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼  𝗙𝘂𝗹𝗹 𝗛𝗗 ▶
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼 𝗙𝘂𝗹𝗹 𝗛𝗗  ▶
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 1920x 𝗙𝘂𝗹𝗹 𝗛𝗗▶
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼  𝗙𝘂𝗹𝗹 𝗛𝗗 ▶
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼 𝗙𝘂𝗹𝗹 𝗛𝗗  ▶
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 1920x 𝗙𝘂𝗹𝗹 𝗛𝗗▶
▶
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼  𝗙𝘂𝗹𝗹 𝗛𝗗 ▶
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼 𝗙𝘂𝗹𝗹 𝗛𝗗  ▶
📺📱 🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 1920x 𝗙𝘂𝗹𝗹 𝗛𝗗▶
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
📺📱 [🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼  NOW ▶]
📺📱 [🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼  ONLINE ▶]
📺📱 [🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 DOWNLOAD 𝗙𝘂𝗹𝗹 𝗛𝗗▶]
➤►
➤►
▶
➤►
➤►
▶
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
▶
➤►
➤►
▶
📺📱 [🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼  NOW ▶]
📺📱 [🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼  ONLINE ▶]
📺📱 [🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 DOWNLOAD 𝗙𝘂𝗹𝗹 𝗛𝗗▶]
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
➤►
▶
➤►
➤►
▶
▶
📺📱 [🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼  NOW ▶]
📺📱 [🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 𝗙𝘂𝗹𝗹 𝗩𝗶𝗱𝗲𝗼  ONLINE ▶]
📺📱 [🔴 ➤►𝗪𝗔𝗧𝗖𝗛👉 DOWNLOAD 𝗙𝘂𝗹𝗹 𝗛𝗗▶]
▶
➤►
➤►
▶
➤►
▶
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶
➤►
➤►
▶

repo: microsoft/fhir-server


text:
Adds example to squash commit documentation

Description
Adds an example of a squash commit header and description.
Note: this is simply my interpretation of our current documentation! I am very open to changing this. I am mainly looking to have an example here to add some clarity.
FHIR Team Checklist

✅ Update the title of the PR to be succinct and less than 50 characters
✅ Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
✅ Tag the PR with the type of update: Bug, Dependencies, Enhancement, or New-Feature
✅ Tag the PR with Azure API for FHIR if this will release to the managed service
✅ Review squash-merge requirements

Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)

Do we want a uniform title/description for the dependabot PRs? The names it generates for PRs are often too long for the heading.

Do we want a uniform title/description for the dependabot PRs? The names it generates for PRs are often too long for the heading.

@LTA-Thinking Good question, I'm not sure. A relevant note that might be helpful: I asked @CaitlinV39 about #1340 when I was merging it, wondering if I should shorten auto-generated name, and Caitlin said it was alright to leave it for now. I think we might have plans to shorten it, but I will defer to her to answer fully.

Do we want a uniform title/description for the dependabot PRs? The names it generates for PRs are often too long for the heading.

@LTA-Thinking Good question, I'm not sure. A relevant note that might be helpful: I asked @CaitlinV39 about #1340 when I was merging it, wondering if I should shorten auto-generated name, and Caitlin said it was alright to leave it for now. I think we might have plans to shorten it, but I will defer to her to answer fully.

Do we want a uniform title/description for the dependabot PRs? The names it generates for PRs are often too long for the heading.

@LTA-Thinking Good question, I'm not sure. A relevant note that might be helpful: I asked @CaitlinV39 about #1340 when I was merging it, wondering if I should shorten auto-generated name, and Caitlin said it was alright to leave it for now. I think we might have plans to shorten it, but I will defer to her to answer fully.

@LTA-Thinking chatted with @CaitlinV39 and confirmed that it is fine to leave auto-generated PRs as-is for now. I specified this in the docs in 0074627.

Do we want a uniform title/description for the dependabot PRs? The names it generates for PRs are often too long for the heading.

@LTA-Thinking Good question, I'm not sure. A relevant note that might be helpful: I asked @CaitlinV39 about #1340 when I was merging it, wondering if I should shorten auto-generated name, and Caitlin said it was alright to leave it for now. I think we might have plans to shorten it, but I will defer to her to answer fully.

@LTA-Thinking chatted with @CaitlinV39 and confirmed that it is fine to leave auto-generated PRs as-is for now. I specified this in the docs in 0074627.

source: gharchive/pull-request

authors: LTA-Thinking rotodd


text:
Adjust Notification Padding Tokens

Platforms Impacted

[x] iOS
[ ] macOS

Description of changes
The bounds of a couple elements were off in the figma, so the tokens were slightly wrong. This change adjusts them to what they should be!

Before
After

Pull request checklist
This PR has considered:

[ ] Light and Dark appearances
[ ] iOS supported versions (all major versions greater than or equal current target deployment version)
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
[ ] iPad Pointer interaction
[ ] SwiftUI consumption (validation or new demo scenarios needed)
[ ] Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow

minimumHeightForOneLine still correctly increase larger text and longer message that will be more that one line?  would you midn updating your before / afterscreenshots please?

minimumHeightForOneLine still correctly increase larger text and longer message that will be more that one line? would you midn updating your before / afterscreenshots please?

@harrieshin Screenshots updated! Let me actually confirm the minimum height specs with design team. The figma doesn't specify heights for one-line scenario.

Ian just updated the figma so it should be 62 for multiline and 52 for single line. https://www.figma.com/file/ArWQiU7BAlrDGNmbrGEXbA/Fluent-2-iOS-specs?node-id=3165%3A48344

minimumHeightForOneLine still correctly increase larger text and longer message that will be more that one line? would you midn updating your before / afterscreenshots please?

@harrieshin Screenshots updated! Let me actually confirm the minimum height specs with design team. The figma doesn't specify heights for one-line scenario.

Ian just updated the figma so it should be 62 for multiline and 52 for single line.

62 was just the height for that specific example in the figma, but the minimum should be 52 for all toasts!

authors: harrieshin jeaniehuynh joannaquu

repo: microsoft/fluentui-apple


text:
Fix transform plugin so it can handle more than one matched import sources

Currently, the transform plugin only keeps tab of the last import statement where the package name (moduleSource) is a match. For example, in:
import { dupImport1 } from 'custom-package';
import { createStyles } from 'custom-package';
import { dupImport2 } from 'another-custom-package';
import { otherImport } from 'another-package';

with config:
{
  "modules": [
    { "moduleSource": "custom-package", "importName": "createStyles" },
    { "moduleSource": "another-custom-package", "importName": "createMyStyles" }
  ]
}

The plugin will only focus on the 3rd import line (import { dupImport2 } from 'another-custom-package';) and then decide that there's no placement needed, thus missing the 2nd import where createStyles actually exists.
This PR fixes this issue by changing the importDeclarationPath into an importDeclarationPaths array, so we don't miss any imports to replace.

There are CI failures on non-existing imports:
__fixtures__/duplicated-imports/code.ts:3:28 - error TS2307: Cannot find module 'another-custom-package' or its corresponding type declarations.

3 import { dupImport2 } from 'another-custom-package';

You can use @ts-expect-error to get rid of them:
https://github.com/microsoft/griffel/blob/222a470836840b134075f231d19202aaea35b93f/packages/babel-preset/__fixtures__/import-custom-name/code.ts#L1-L2

authors: layershifter statm

repo: microsoft/griffel


text:
Set endpoint for OpenAI calls

It seems like the endpoint attribute is not set for the OpenAI LLM. This causes the system to fail when using the REST API caller. We've also added a warning to the user when falling back to defaults, in case the API endpoint or version changes in the future.

@microsoft-github-policy-service agree

I think that this has been obsoleted by the large refactoring which occurred at the end of last year?

authors: Jmkernes riedgar-ms

repo: microsoft/guidance


text:
New LGBM Version 4.0.0 changes

LGBM 4.0.0 was released 3 days ago. From Friday runner test_onnxml_lightgbm_converter.py:
>       from lightgbm.basic import (
            _LIB, FEATURE_IMPORTANCE_TYPE_MAPPER, _safe_call,
            json_default_with_numpy)
E       ImportError: cannot import name 'FEATURE_IMPORTANCE_TYPE_MAPPER' from 'lightgbm.basic' (C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\lightgbm\basic.py)

C:\hostedtoolcache\windows\Python\3.10.11\x64\lib\site-packages\onnxmltools\convert\lightgbm\operator_converters\LightGbm.py:267: ImportError

They have added an underscore to many things. Ex: FEATURE_IMPORTANCE_TYPE_MAPPER becomes _FEATURE_IMPORTANCE_TYPE_MAPPER. See https://github.com/microsoft/LightGBM/pull/5654
Also in test_onnxml_lightgbm_converter.py:
FAILED tests/test_onnxml_lightgbm_converter.py::TestONNXLightGBMConverter::test_lightgbm_booster_classifier - AttributeError: 'Booster' object has no attribute 'attr'

Need to investigate what other breaking changes for us.

The errors is coming from onnxmltools  (   self.booster_.attr('objective') and FEATURE_IMPORTANCE_TYPE_MAPPER )  . Opened https://github.com/onnx/onnxmltools/issues/632
Will pin for now!

repo: microsoft/hummingbird


text:
Image loading in dataloader code

Hello, and thank you very much for the contribution of the code.
While running your I have noticed that only the first page of a PDF file is loaded (as image). Indeed, in your class PregeneratedDatasetBase, the add_images() routine features the line
 im = convert_from_path(im_path)[0]
While in the original DUE code the _get_page_img() routine uses the page_no field to fetch the relevant page.
Can you please explain this situation?
Thank you!

Hello, I also busy with it! I'm curious about how can we get the images and corresponding Q-A pairs. Do you have any experience?

Well, I just took the DUE repo as reference, and brute force fixed the
dataloader to fetch the relevant page.
On Wed, 6 Sep 2023, 20:04 Coobiw, @.***> wrote:

Hello, I also busy with it! I'm curious about how can we get the images
and corresponding Q-A pairs. Do you have any experience?
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/i-Code/issues/108#issuecomment-1708777915,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACOBU6UTZVAHSHOWE5GQ5RDXZCUKPANCNFSM6AAAAAA4NJXH7A
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thanks for your reply! So I thought that you first generate the memmaps. After that, you use the memmaps to build the dataloader, and save the results(image-QA pairs) into a format file just like json?

Yes, I used the DUE-baselines repo to generate the memmaps, then did
the finetuning, and then the --evaluate option in the train config saves
the predictions. Please notice you need to convert these predictions to
another format (back in the   DUE-baselines) in order to run them against
the GT annotations in the DUE-evaluator repo. Then, finally, you get the
performance numbers.
On Thu, Sep 7, 2023 at 10:39 AM Coobiw @.***> wrote:

Thanks for your reply! So I thought that you first generate the memmaps.
After that, you use the memmaps to build the dataloader, and save the
results(image-QA pairs) into a format file just like json?
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/i-Code/issues/108#issuecomment-1709633828,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACOBU6QUD5RCALMVOLQKP63XZF24BANCNFSM6AAAAAA4NJXH7A
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thank you very much!!! I want convert the memmaps into png files because I want to use the images as inputs. I want to ask that what process repo did you use? The benchmarker in UDOP repo or the original one in DUEBenchmark/baselines?

authors: Coobiw jshtok

repo: microsoft/i-Code


text:
PowerShell: Command history is not available using up and down arrows

When inside inshellisence, using up or down arrows will not bring up commands from the command history.
Applicable to PowerShell, not tested with bash or other shells.

Closing as this was fixed in 0.0.1-rc.5

node: v20.18.0 inshellisense: 0.0.1-rc.16 powershell
Name	Value
PSVersion	5.1.19041.5007
PSEdition	Desktop
PSCompatibleVersions	{1.0, 2.0, 3.0, 4.0...}
BuildVersion	10.0.19041.5007
CLRVersion	4.0.30319.42000
WSManStackVersion	3.0
PSRemotingProtocolVersion	2.3
SerializationVersion	1.1.0.1
it stuck in
cd ~\Developer\intro-to-react-by-day\day-10-ts\ ; bun run dev

This Might Help:

if i add trailing spaces in ConsoleHost_history.txt file after run dev it's doesn't stuck

but trailing spaces doesn't always help eg:

with trailing spaces code --user-data-dir="${HOME}/.vscode-root"  ❌ stuck
without trailing spaces code --user-data-dir="${HOME}/.vscode-root" ❌ stuck
with .exe code.exe --user-data-dir="${HOME}/.vscode-root" ✔ doesn't stuck

@cpendery is there a workaround like
[bindings.previousSuggestion]
key = "up"
ctrl = true
this is really annoying

I can't replicate this on 0.0.1-rc.16. Can you try on 0.0.1-rc.18 and run inshellisense with the -V option? The logs will be at ~/.inshellisense/inshellisense.log and it would help alot if you could provide them here

authors: cpendery philibertperusse

repo: microsoft/inshellisense


text:
samples: update azure-vote-front sample

Update sample to point to valid repo location. mcr.microsoft.com one
seems to no longer be available. So built a new one from
https://github.com/Azure-Samples/azure-voting-app-redis and pushed
to marinerconfpodsdev.azurecr.io
test run: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=650312&view=results

Not ready for merge yet. Sample doesn't achieve running state as expected https://dev.azure.com/mariner-org/mariner/_build/results?buildId=650312&view=ms.vss-test-web.build-test-results-tab&runId=258043&resultId=100168&paneView=debug

Closing in favor of https://github.com/microsoft/kata-containers/pull/237 and due to image rebuilt not working as expected

repo: microsoft/kata-containers


text:
Add actions object when there is a declarative copilot file in the output directory

Is your feature request related to a problem? Please describe the problem.
No response
Client library/SDK language
None
Describe the solution you'd like
When creating an API Plugin, Kiota should add the actions object in the declarativeCopilot.json file when there is one in the output directory.
    "actions": [
        {
            "id": "<plugin-name>",
            "file": "<plugin-file-generated>" //<plugin-name>-apiplugin.json
        }
    ]

So as an example, for a plugin named githubrepo, the action object would be:
    "actions": [
        {
            "id": "githubrepo",
            "file": "githubrepo-apiplugin.json"
        }
    ]

Additional context
No response

Should we ask the user to "select" its declarativeCopilot, knowing that in the future there might be more than one supported? And just default to the one in the package for now?

similar to #4476 but not the same.
@maisarissi can you update the specs as well for clarity please?

Hey @sebastienlevert, based on our conversation yesterday I'm assuming we can close this issue as we are not going to implement that, right?

For now, I'd say we refrain from doing it, yep!

Closing for now!

authors: baywet maisarissi sebastienlevert

repo: microsoft/kiota


text:
Nested JSON/additional_data datetimes not round-tripped

What are you generating using Kiota, clients or plugins?
API Client/SDK
In what context or format are you using Kiota?
Windows executable
Client library/SDK language
Python
Describe the bug
I am trying to GET my entity, and without any changes to the object, PUT the object.
Expected behavior
I expect the object to be the same when serialized to the server for the PUT as when it was read with the GET
(either exactly, or at least semantically equivalent.)
How to reproduce
request_config = RequestConfiguration[ItemRequestBuilderV2.ItemRequestBuilderGetQueryParameters]()
request_config.query_parameters = ItemRequestBuilderV2.ItemRequestBuilderGetQueryParameters(opt='xxx')
e = asyncio.run( client.v2.Entity.by_id(id).get(request_config))

asyncio.run( client.v2.Entity.put(e))

The entity contains an arbitrarily nested JSON object that should maintain its integrity when reserialized.
When the entity is GET on the Python side when deserialized it looks like this:
e.Contents.additional_data['installationDate'] = DateTime(2023, 3, 24, 0, 0, 0, tzinfo=TimeZone('UTC'))
In this case the JSON value had the string value "2023-03-24".
I expect this value to be serialized back out as either the original format "2023-03-24" by not converting to a date but keeping the original string, or by serializing as "2023-03-24T00:00:00+00:00". (The former is preferred.)
(This example is at the top-level, but also happens in deeper nestings.)
However, when the entity is PUT back, what gets serialized is the empty object - inspecting in the debugger in the C# server, the PUT controller method sees this entry in the dictionary - an empty object rather than the date string:
installationDate = ValueKind(Object, "{}")
How do I keep the original string format of the dates and round-trip them exactly?
And for reference, how to keep the DateTimes and serialize them back out as ISO format strings rather than the empty objects?
thanks
Open API description file
Unable to provide
Kiota Version
1.19.1
Latest Kiota version known to work for scenario above?(Not required)
No response
Known Workarounds
No response
Configuration
x64, vscode
Debug output
Click to expand log
```

</details>

### Other information

_No response_

Thanks for raising this @thelazydogsback
As the item is placed in the additionalData, the culprit would most likely lie in the function here.
https://github.com/microsoft/kiota-python/blob/d700d67a2b5da0ab37f2362dcc7504b51a4ef283/packages/serialization/json/kiota_serialization_json/json_serialization_writer.py#L492
Any chance you are able to confirm the version of the python libraries you are using with your generated client?
Would you be willing to submit a pull request with a failing test with a date-time object in the additional_data to help us understand the issue here?
https://github.com/microsoft/kiota-python/blob/d700d67a2b5da0ab37f2362dcc7504b51a4ef283/packages/serialization/json/tests/unit/test_json_serialization_writer.py#L92

My microsoft-kiota libs were a bit stale -- but unfortunately updating to latest (1.6.2) didn't change the behavior.
Does this mean I can write a subclass that implements write_datetime and register this somehow when I init my client?

Yes I understand the request but (not trying to be rude at all) I'll see what I can do, but my first order of business is to get the required functionality working for our users.
This is similar to the custom subclasses of AzureIdentity{AccessToken|Auth}Provider I needed to write to allow for auth over HTTP.
Outside of this bug (assuming it is one) I assume that overriding the behavior of dynamic data handling is useful because whatever default assumptions are made are likely not what some clients need in certain scenarios.

UPDATE: @andrueastman
It turns out that update the kiota libs did solve the issue of the dates being written out as {} -- however, it has brought out other issues.
(1) When parsing a string that is date only (such as "2023-03-24"), rather than being read as a date, it is being read as a datetime with no date-part set. Thus when serializing back out, it takes the form of "2023-03-24T00:00:00+00:00" rather than "2023-03-24".  In this case this causes a BAD REQUEST in my downstream Azure service, because it's expecting an RFC3339 date type, not a datetime.
(2) In order to fix this at serialization time, I'm figured I'd write a customer serializer to handle this. I used the factory pattern and the classes below:

However, there seems to be a bug where the factory is used when the writer is first created, but then later in the code the factory is ignored when a temp writer is created:

This means that by the time we get want to write the date from the parent write_object, then custom writer is no longer being used.
Please let me know if I'm missing something here.
Thanks

Thank you for the additional information.
So if I'm understand correctly, the only remaining issue at this point is that when parsing a date only for additional properties, it's being instantiated as a datetime instead of a date only?
If so this section is most likely what's causing the issue here.

authors: andrueastman baywet thelazydogsback


text:
Need IP range for this resource to allow through company firewalls

Describe the problem you are experiencing.

We have an on-premises CICD tool and one of our containers needs to pull from packages.microsoft.com. It is blocked by our company firewall and they require that we provide a static list of IP addresses to allow through and not an FQDN
Describe any possible solutions that you would like to see.

Could you publish a page or add to the default landing page the public IP's to expect for this page or a CIDR range if it could rotate between a few?
Additional context.

Updates to our edge delivery infrastructure may result in new VMs with new IP addresses being added to service pools and old VMs dropping out. The IP addresses in use could come from any IP address block allocated to Microsoft Azure.
Microsoft publishes its allocated IP address blocks and updates them as they change. See https://www.microsoft.com/en-us/download/details.aspx?id=53602.

authors: jasonzio wstr-ncrum

repo: microsoft/linux-package-repositories


text:
Change default Architecture

For maximize_capability, the capability needs to accept both x64 and Arm64 architectures. When it just defaults to x64, this blocks deployment of undefined Arm64 SKUs with ARM images.

I have some concerns with how these changes will impact this code: https://github.com/microsoft/lisa/blob/f99fb4aa47a9725485933534b1b50fd70fe140f3/lisa/sut_orchestrator/azure/features.py#L1995-L1997
I believe the capability should always be resolved to a string, but for non-GA SKUs I am not certain about the behavior. Can you help me understand what test cases / test scenarios utilize this code so that I can test the behavior in all scenarios?

@LiliDeng LGTM

I have some concerns with how these changes will impact this code:
https://github.com/microsoft/lisa/blob/f99fb4aa47a9725485933534b1b50fd70fe140f3/lisa/sut_orchestrator/azure/features.py#L1995-L1997
I will test the behavior of resize tests on undefined ARM SKU. Let me know if I should test any other scenarios.

This code is irrelevant for undefined SKUs. The test case already fails on the following line
https://github.com/microsoft/lisa/blob/62ce27e3ee409404570a0bccf86e22d211626f14/lisa/sut_orchestrator/azure/features.py#L1942
I don't foresee any other issues.

authors: kamalca squirrelsc

repo: microsoft/lisa


text:
Setting up docs

Fixes : #54
Summary
This pull request introduces the basic structure for the project documentation. The following components have been added:

Directory Setup: Created a dedicated docs/ folder.
Skeleton Files: Added placeholders for key sections like Introduction, Installation, and Usage.

docs/
├── User Guide/              # For end users
│   ├── README.md            # Overview and quick start guide
│   ├── Configuration.md     # Configuring the tool based on the use case, prereq
│   ├── usage.md             # Detailed usage instructions
│   ├── FAQ.md               # FAQ, Support and glossary
│
├── Contributor Guide/       # For developers and contributors
│   ├── Contributing.md      # How to contribute to the project
│   ├── Changelog.md         # History of changes and updates

Feedback needed on :
1. Proposed: Moving `SECURITY.md` under Contributor Guide/. Do you agree with this organization?
2. Do you want me to add any other file / breakdown any other aspect in detail in a new file ?

To-Do
Planned updates over the next week:

[x]  Set up the file skeleton
[x] Write contributing.md
[ ] Set up a specific template to use for changelog.md
[ ] Provide usage examples and FAQs.

Request for Feedback
Feedback on the structure or additional sections to include is welcome! If you have suggestions or improvements, please share them.
Notes
This PR is a work-in-progress and will evolve as outlined.
@gagb @jackgerrits

@microsoft-github-policy-service agree

I prefer to keep file names consistent in style, using all uppercase, like README.md and CONTRIBUTING.md

authors: l-lumin lalithaar

repo: microsoft/markitdown


text:
The FileOpenPicker's method PickSingleFileAsync throws ComException

Describe the bug
Hi, just tried to pick an image but got an exception - System.Runtime.InteropServices.COMException: 'Invalid window handle. (0x80070578)' To reproduce try the following code.
Steps to reproduce the bug
            FileOpenPicker filePicker = new FileOpenPicker();
            foreach(string ext in new []{ ".jpeg", ".jpg", ".png", ".bmp" })
                filePicker.FileTypeFilter.Add(ext);

            filePicker.ViewMode = PickerViewMode.Thumbnail;
            filePicker.SuggestedStartLocation = PickerLocationId.PicturesLibrary;
            filePicker.SettingsIdentifier = "ImageFilePicker";
            filePicker.CommitButtonText = "Insert";

            StorageFile file = await filePicker.PickSingleFileAsync(); //throws exception

Expected behavior

Screenshots

Version Info

NuGet package version:
[WinUI 3 - Project Reunion 0.5: 0.5.7]

Windows app type:

UWP
Win32

Yes

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

October 2020 Update (19042)

May 2020 Update (19041)
Yes

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Xbox

Surface Hub

IoT

Additional context

You need to cast the picker to IInitializeWithWindow and call it's Initialize with the window handle to use it in a desktop app.

See #2716

https://docs.microsoft.com/en-us/uwp/api/windows.storage.pickers.fileopenpicker.-ctor?view=winrt-19041#remarks

Thanks all for the answers. But it still looks like a bug. The WA is ok but believe should be fixed in the future versions.

repo: microsoft/microsoft-ui-xaml


text:
Open source of Hub control

Proposal: Open source of Hub control
I need Hub control in Uno Platform
https://github.com/unoplatform/uno/issues/5249#issuecomment-890324172
The easiest way of porting is to take original Hub control sources and migrate to Uno Platform.
Rationale

Hub control is a crucial control for an app home page
Uno platform is the major motivation to use UWP and WinUI and drastically expand its spreading

As a part of Winui3 we will be making the framework open source, this will need to wait for that.

@ryandemopoulos FYI

What is the time frame of that?

Hello @xperiandri, this is our backlog and we don't expect to get to it till sometime next year. Hope that helps!

The Hub source is all shared now, with https://github.com/microsoft/microsoft-ui-xaml/blob/winui3/release/1.5-stable/dxaml/xcp/dxaml/lib/Hub_Partial.cpp as one of the main files. This code is in ABI style, so it won't map easily to C# or C++/WinRT code.

authors: StephenLPeters akilarajesh1313 codendone xperiandri


text:
contextflyout is not triggered in some cases

Describe the bug
if GridViewItem DataTamplate content background is not setted, could not trigger context menu in padding area.
if GridViewItem DataTamplate content background is setted (even if it's Transparent),  context menu can be triggered in padding area.
Steps to reproduce the bug

run demo.
right click on GridView' item padding (padding is 30).

Expected behavior
contextflyout can be triggered with or without setting the background
Screenshots

NuGet package version
WinUI 3 - Windows App SDK 1.2.5: 1.2.230313.1
Windows version
Windows 11 (22H2): Build 22621
Additional context
Windows App SDK: 1.3.230331000.
ContextFlyoutDemo.zip

Add: if GridViewItem DataTamplate content background is not setted, could not trigger PointerEntered event in padding area.

It seems that this is expected, otherwise the event cannot be passed down


text:
TeachingTip: Fix background for light-dismissable tip

Description
This PR fixes two background issues for a light-dismissable TeachingTip:

TeachingTip's Content UI background did not use transient background (regression)
TeachingTip's HeroContent UI background did not use transient background

Motivation and Context
Fixes https://github.com/microsoft/microsoft-ui-xaml/issues/3436
How Has This Been Tested?
Tested visually and extended API test.
Screenshots:
<muxc:TeachingTip Title="Title" Subtitle="Subtitle"
              IsLightDismissEnabled="True">
    <muxc:TeachingTip.HeroContent>
        <Rectangle Fill="Transparent" Width="100" Height="70" />
    </muxc:TeachingTip.HeroContent>
    <TextBlock Text="Extra Content" Margin="0,10,0,0"/>
</muxc:TeachingTip>

So with light dismiss, the Background property gets ignored by the "main" area of the TeachingTip. This should either be documented or background should be respected regardless if the TeachingTip is in lightdismiss-mode.

One way to go here would be to apply the TeachingTipTransientBackground theme resource only if no Background property is set. If Background is set, it will take precendence. Generally speaking, I'm in favor of respecting existing APIs whenever possible.
This will likely require adding code behind though as we won't be able to do that purely in XAML markup as of now.

Yes, unfortunately, this is nothing we can do without code behind. Given that this isn't the first time where we needed this, having a converter for this might be the better approach here. Though, a converter would of course break the lightweight styling aspect as bindings don't get reevaluated in users apps.

@Felix-Dev can you pull master into this branch to pickup the pipeline stability change that went in today? If you could do the same for your other PR's that would be great (I'm sorry they aren't getting the attention they deserve :( )

@StephenLPeters Done for my most recent PRs and some older ones. I am still holding out merging with master for my older PRs adding interaction tests (like https://github.com/microsoft/microsoft-ui-xaml/pull/3137) since that would for now block me locally from running interaction tests again (until PR https://github.com/microsoft/microsoft-ui-xaml/pull/3359 has been merged).
I can bring those few PRs up-to-date though in case you want to take a look at the downlevel/test pipeline test failures and don't want to wait for PR #3359.

/azp run

/azp run

/azp run

Merged with master. We can try starting the test pipeline again (failed to run the previous time). @StephenLPeters FYI.

/azp run

So with light dismiss, the Background property gets ignored by the "main" area of the TeachingTip. This should either be documented or background should be respected regardless if the TeachingTip is in lightdismiss-mode.

We already do this for ContentRootGrid, I think we can make this change as is and should it be needed look at a way to fix this behavior.

authors: Felix-Dev StephenLPeters chingucoding ranjeshj


text:
Adding more to WinRT API changes doc

Adding notes about CoreInputView and CoreTextServicesManager.

/azp run

authors: anawishnoff ranjeshj


text:
How could I add space around content?

Because of some reasons, I want to add some space around the content(view-lines). I found the way to add space on the left of the content using the API lineDecorationsWidth, but I have no idea how to add space on the other side, top, bottom and right and keep the action work well, such as copy, select all, input...

@chhpt may be you're looking for the lineHeight?

@myfoxtail Could the lineHeight change the space on the left or right? I can't find the usage that show it could change the space around the content. It only change the space between the line. I don't think the lineHeight is the proper way.

@chhpt I guess you can try to create a decoration and apply it to the particular range if your content. Every decoration has it's own css class which I guess you can fill with margins and paddings.
const decorationId = this.editor.deltaDecorations([], [
        {
          range: new monaco.Range(
              lineNumberStart
            , columnStart
            , lineNumberEnd
            , columnEnd),
          options: {
            inlineClassName: 'sqleditor-dsp-link', // use this class to add some paddings
            stickiness     : 1,
            hoverMessage   : {value: 'hello my friend'}
          }
        }
      ]);

@myfoxtail  I have tried it. It seems that it is not working. The inlineClassName has effect on the inline block. But when I add padding on it, it cause the content chaos. And I also have tried the className, it is not work as expect.

You could try with decorations that use ::before and ::after css selectors, like e.g. beforeContentClassName
var jsCode = [
	'"use strict";',
	'function Person(age) {',
	'	if (age) {',
	'		this.age = age;',
	'	}',
	'}',
	'Person.prototype.getAge = function () {',
	'	return this.age;',
	'};'
].join('\n');

var editor = monaco.editor.create(document.getElementById("container"), {
	value: jsCode,
	language: "javascript"
});

var decorations = editor.deltaDecorations([], [
	{ range: new monaco.Range(7,1,7,24), options: { beforeContentClassName: 'myInlineDecoration' }},
]);

.myInlineDecoration::before {
    content: " ";
    background: red;
    width: 100px;
    display: inline-block;
}

@alexandrudima
Maybe I should show my thoughts more clearly. First please see this pic. If I don't do anything, it look like this. This doesn't look so good.

So I decided to add some space around the content. I add a padding attribute on the  parent container, it became like this:

All is well except the scrollbar. I want to find way that could make it work like this but make the scrollbar on the edge. May like this:

The beforeContentClassName API is something else, it make cause like this. it is not what I except.
And if edit the content, such as delete something, it work weird. Is there a way could change the position of the scrollabr?
var decorations = editor.deltaDecorations([], [
    { range: new monaco.Range(1,1,10,24), options: { beforeContentClassName: 'myInlineDecoration' }},
]);

Thanks for posting screenshots, it makes it clearer for me what you're trying to do.
At this time, the editor doesn't support any form of padding inside the content (such that the scrollbar stays put).

@alexandrudima  Do you have a plan to realize it? I hope the feature could be come ture.

Any update related this feature? @alexdima

How do I get to put a consistent single space between words on the same line. I am using a plaintext editor. Please help me . I want to use create a data like tab separated files. Eg.
Name    address
Johnd    london
Dhdhb   Newyork

authors: Mani-108 alexandrudima chhpt diyyap myfoxtail

repo: microsoft/monaco-editor


text:
model_context module not present in nni.nas

**Hi,
The instruction was - "Use nni.nas.model_context, rather than nni.nas.fixed_arch".
However I am getting error for 2.10 version -,
import nni.nas.model_context
Traceback (most recent call last):
File "C:\Users\ADMIN\AppData\Local\Temp\ipykernel_14148\1503585595.py", line 1, in
import nni.nas.model_context
ModuleNotFoundError: No module named 'nni.nas.model_context'
I checked that nni.nas has NOT got any module named model_context in either v2.10 or v3.0. Please help.
Thanks**:
Environment:

NNI version:
Training service (local|remote|pai|aml|etc):
Client OS:
Server OS (for remote mode only):
Python version:
PyTorch/TensorFlow version:
Is conda/virtualenv/venv used?:
Is running in Docker?:

Configuration:

Experiment config (remember to remove secrets!):
Search space:

Log message:

nnimanager.log:
dispatcher.log:
nnictl stdout and stderr:

How to reproduce it?:

This is for NAS v3.0.
Also you need: from nni.nas import model_context, rather than import nni.nas.model_context.

Do you still have other questions or it work for your question? @ShrutiSarikaChakraborty

repo: microsoft/nni


text:
Fix pmem build error

Fix 'pmem declared and not used' build error introduced with https://github.com/microsoft/opengcs/pull/375.
When testing things to solve the 5.4 kernel build failure I had been doing all of
the work on a '54-kernel-failure' branch, so when we discovered the dax issue I
added the fix to this branch and built off of it to verify. When seeing that this
resolved the issue I created a new branch and just added the removing of dax changes
and forgot to add what is in this commit before pushing.

Signed-off-by: Daniel Canter dcanter@microsoft.com

@microsoft/containerplat we should build the repo/run tests like we do for the shim to avoid things like this :frowning:

repo: microsoft/opengcs


text:
Support CPU jobs on GPU nodes in HiveD scheduler

Support CPU jobs on GPU nodes in HiveD scheduler.
Closes #5058.

Coverage decreased (-0.008%) to 34.215% when pulling a559632493399153af2d88a96563fa37cbaaee60 on xiongyf/support-mixture-job into df25b985699b75a3813a2080ee6d437ca0db1bf2 on master.

authors: abuccts coveralls

repo: microsoft/pai


text:
How to load OntoNotes?

Hi
I'm probably at the wrong place to ask this question because this is not about Presidio but how do I conveniently load OntoNotes?
In one of the notebook, there is a code block like this
## Download OntoNotes data
ontonotes = ""

I have downloaded OntoNotes and there are a lot of files. I haven't found an easy way to load OntoNotes in the format that can be used by the rest of the notebook yet so if anyone can shed some light, that would be awesome
Thanks in advance
Alex

;) Found a way to do it so closing.

repo: microsoft/presidio-research


text:
overlap event triggering between incorrect types in /beta

Describe the bug
regression in beta causing overlap event to trigger between incorrect sprites
To Reproduce
Steps to reproduce the behavior:

Go to https://makecode.com/_WD77cfADmfxp in /beta
main relevant files are ball.ts creating the sprites / firing the ball, and player.ts which creates the players and has the overlap event that is triggering incorrectly. Maybe const.ts too, which has the definitions for the spritekinds?
See that splash screen shows a few seconds in; this shows that the second param is the wrong type for the event. event is between PlayerTeam and OpposingTeam, but actually triggers between PlayerTeam and the other two kinds. (see console logs for a bit more detail)

works perfectly on live site
Expected behavior
event should only trigger between the player and opposing team sprites, not shadows targets
@mmoskal this is that weird bug I was talking about. caused by https://github.com/microsoft/pxt/pull/5916/commits/dbb397dd089647edc5776dbb406b1b65564e0ad5 from https://github.com/microsoft/pxt/pull/5916; reverting just that commit makes everything work nicely. worth noting that the overlap occurs correctly once, and then switches to be between the wrong two kinds after that: example console output
Actual kinds: 1007 1008
triggering between 1007 1008  <<< correct
[32]triggering between 1007 1005 <<< this is now between PlayerTeam and the Target, incorrect
[10]triggering between 1007 1004 <<< and then triggers between PlayerTeam and shadow for a bit...

It seems I broke capture in for-in:
game.consoleOverlay.setVisible(true)

function test() {
    let f = []
    for (const q of [1, 12]) {
        f.push(() => {
            console.log(q)
        })
    }

    f[0]()
    f[1]()
}

test()

authors: jwunderl mmoskal

repo: microsoft/pxt-arcade


text:
Compilation failure in /beta f4

Describe the bug
https://forum.makecode.com/t/accelerometer-lis3dh-reading-in-console/632
Program fails to compile when downloading for meowbit in /beta
To Reproduce
Steps to reproduce the behavior:

Go to https://makecode.com/_TyDFFAJJRVb9
download to meowbit
See error

Expected behavior
should compile
Additional context
works in live

Should this also leave a more detailed error in build/output.txt or somewhere else?

I have used the Meowbit target on beta over the weekend without issues. What is the version of the firmware you are using? (It shows on the uf2 bootloader screen) The latest is v2.7.5 which you can get from: https://meowbit-doc.kittenbot.cn/#/more/upgrade (Chinese only page) Direct download link is here: https://cdn.kittenbot.cn/meowbit/meowbit-flasher.uf2

fixed with https://github.com/microsoft/pxt-common-packages/pull/993
re: built/output.txt being useless, there are certain cases where that file is accidentally cleared when it shouldn't be; usually some poor interaction with auto-run automatically clearing it - usually the file is there for ~ half a second, and if you click on it during that time period where the error is listed it will show up with the error properly. I believe there's another issue for that somewhere, but it's definitely something we're aware of / that needs to be fixed at some point.

authors: gbraad jwunderl kevinjwalters


text:
Skillmap: Refreshing the tutorial page will return the homepage

Describe the bug
Skillmap: Refreshing the tutorial page will return the homepage
Steps to reproduce the behavior
1.Navigate to https://arcade.makecode.com/beta--skillmap
2.Learn to Make a Platformer----->Simple Platformer----->START
3.Refresh the page
Actual behavior
Skillmap: Refreshing the tutorial page will return the homepage

Additional context
1.OS: Windows(rs6)
2.arcade version: 1.4.7
3.Microsoft MakeCode version: 6.9.12

This is by design

@riknoll But it won't return to the homepage if refreshing the page in other tutorials.

Closing again as per design. Eventhough it is different in tutorials.

authors: Sheila111 abchatra riknoll


text:
Ok to include Jumpy Platformer in McAirpos?

To whom it may concern(maybe one of the authors, @jwunderl?),
May I please bundle a compiled .elf of the Jumpy Platformer game in my McAirpos repository, so that upon installations the users already have at least one good demo game available, and the MakeCode Arcade "emulator" entries show up immediately in the EmulationStation menus of RetroPie, Recalox, Batocera etc.?
Alternatively, do you know of another great MakeCode Arcade demo game that you could recommend and that do not come with license issues or other objections?
Br,
Vegard

All content in MakeCode is MIT licensed. Feel free to use.


text:
cannor run code

We have written the needed data into your clipboard because it was too large to send. Please paste.

Thanks for the report. Would you please resubmit the issue with the repro steps and the logs as described in troubleshooting

repo: microsoft/pylance-release


text:
same method name appears twice and redundant object name in pylance auto completion

Environment data

VSCode version: 1.59.0-insider (system setup)
Language Server version: pylance v2021.7.5
OS and version: Windows 10 19043.1110
Python version (& distribution if applicable, e.g. Anaconda): miniconda

Expected behaviour
no redundant method name and object name
Actual behaviour

same method name appears twice（tobitmap and im.tobitmap is same method)

when press tab or enter, it will add redundant object name in editor

Code Snippet / Additional information
this problem happens in any python code

This looks like a Jupyter completion bug, if anything. Can you try the same thing in a regular Python file, not a notebook?

This looks like a Jupyter completion bug, if anything. Can you try the same thing in a regular Python file, not a notebook?

it is normal in regular python code, but some method completion are missing(like to_thumb in jupyter completion)

Thanks; I'm pretty sure those extra completions are coming from the Jupyter kernel and aren't being merged correctly. I'll transfer this to their tracker.


text:
Training time is too long

It took 8 hours to train an LSTM model, but there was no result. Is such a long training time normal?

Hi, could you please tell us how you run the model? Usually, you can train the LSTM model to convergence with one GPU in 1 hour.

Hi, could you please tell us how you run the model? Usually, you can train the LSTM model to convergence with one GPU in 1 hour.

Run the model directly on the jupyter notebook without using qrun. Use Chinese market, Shanghai and Shenzhen 300, data within one year

It is most likely that you are running the models on CPU. I would suggest you check your jupyter with torch.cuda.is_available().
If the result is true, then pytorch should detect your GPU and use gpu to train the model. If not, maybe you could refer to this and enable your GPU on jupyter.

It is most likely that you are running the models on CPU. I would suggest you check your jupyter with torch.cuda.is_available().
If the result is true, then pytorch should detect your GPU and use gpu to train the model. If not, maybe you could refer to this and enable your GPU on jupyter.

知道了，谢谢。

authors: Derek-Wds onepointfuck

repo: microsoft/qlib


text:
[FEATURE] Efficiency enhancement in surprise_utils.py

Description
In recommenders/reco_utils/recommender/surprise/surprise_utils.py  compute_ranking_predictions function, the code will try to get unique items or users in every for-loop step, which will decrease the efficiency.
Expected behavior with the suggested feature
Better to use memory to improve code efficiency,
users = data[usercol].unique()
items = data[itemcol].unique()
for user in users:
        for item in items:
...

Other Comments

this is really nice, do you want to do a PR?

this is really nice, do you want to do a PR?

Yes! For sure, I would like to do that. Thanks.

thanks for the contribution @zhaisw!
https://github.com/microsoft/recommenders/pull/1224

authors: miguelgfierro zhaisw

repo: microsoft/recommenders


text:
 All CLA requirements met.

          [![CLA assistant check](https://cla.opensource.microsoft.com/pull/badge/signed)](https://cla.opensource.microsoft.com/microsoft/security-devops-action?pullRequest=20) <br/>All CLA requirements met.

Originally posted by @microsoft-cla-retired[bot] in https://github.com/microsoft/security-devops-action/issues/20#issuecomment-1122142484

https://github.com/microsoft/security-devops-action/issues/41#issue-1580665513

https://github.com/microsoft/security-devops-action/issues/41#issue-1580665513

repo: microsoft/security-devops-action


text:
.Net: Bug: semantic kernel injecting user message between tool calls response messages

Describe the bug
Semantic Kernel is adding a user message between tool response messages, which causes the LLM to fail the request with 400 since its expecting to receive response from all tools first.
To Reproduce
Steps to reproduce the behavior:

Create a flow which the LLM requests multiple tools to be called
one of the tools should fail (except the last one) by throwing an exception (which should be handled here)
Semantic kernel will handle the exception by adding a tool message with the exception and a following user message indicating tool failure
A following tool should succeed. We should have a chat history similar to:

tool_message
user_message
tool_message
tool_message

LLM will return the error below

---> Azure.RequestFailedException: An assistant message with 'tool_calls' must be followed by tool messages responding to each 'tool_call_id'. The following tool_call_ids did not have response messages: call_iE1vjQZ6NXoB3qJC0q2wtgAE, call_JZ7RjkHTMVjXrGw0hz5MjAHM
Status: 400 (model_error)

Content:
{
  "error": {
    "message": "An assistant message with 'tool_calls' must be followed by tool messages responding to each 'tool_call_id'. The following tool_call_ids did not have response messages: call_iE1vjQZ6NXoB3qJC0q2wtgAE, call_JZ7RjkHTMVjXrGw0hz5MjAHM",
    "type": "invalid_request_error",
    "param": "messages.[7].role",
    "code": null
  }
}

Expected behavior
Semantic kernel should send all tool responses in sequence, and just after that add any specific user message related to tool failure. This could be achieved by initially aggregating all user messages related to tool failures, and add them to the history only after the function responses loop
Platform

OS: Windows
IDE: Visual Studio
Language: C#
Source: 1.8.0

Additional context

We are using FunctionCallingStepwisePlanner
I know we are not using the latest version, but I checked it and the problem seems to be there as well.

@franklinlindemberg Thanks for reporting this issue!
Could you please try to use automatic function calling instead of FunctionCallingStepwisePlanner and see if you can reproduce the problem? We recommend automatic function calling for planning capabilities since it's more efficient approach in terms of performance and cost.
Here is more information:

https://devblogs.microsoft.com/semantic-kernel/planning-with-semantic-kernel-using-automatic-function-calling/
https://github.com/microsoft/semantic-kernel/blob/main/dotnet/samples/Concepts/Planners/AutoFunctionCallingPlanning.cs
https://github.com/microsoft/semantic-kernel/blob/main/dotnet/samples/Demos/StepwisePlannerMigration/README.md

@dmytrostruk Thanks for the reply!
I'm gonna try using the automatic function calling and will let you know!
Also just wanted to clarify that this is not really a blocker for us (the try catch on each tool implementation kinda fixed it) but I decided to open the issue anyway since I had already debugged this and had all the details (it might be helpful in case other folks face the same issue)

@franklinlindemberg thanks for identifying the cause!
@dmytrostruk i can confirm it for  ToolCallBehavior = ToolCallBehavior.AutoInvokeKernelFunctions

@franklinlindemberg It would be great to learn about your experience using automatic function calling and if you can reproduce this issue with it. As for now, I'm going to close the issue, since we no longer recommend using FunctionCallingStepwisePlanner and suggest using automatic function calling instead. But in case you can still reproduce it with automatic function calling - feel free to re-open this issue or create a new one. Thanks a lot!

repo: microsoft/semantic-kernel


text:
Add SequentialPlanner support to Copilot ChatApp

Motivation and Context

See issue/feature request #1137
Description

Add SequentialPlanner support in Copilot ChatApp
Contribution Checklist

[X] The code builds clean without any errors or warnings
[X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
[X] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
[X] All unit tests pass, and I have added new tests where possible
[X] I didn't break anyone :smile:

@thomasgobin how have you tested this? Can you share some steps and screenshots?

Hey @thomasgobin, I've been testing the SequentialPlanner with Copilot Chat and results we're seeing aren't deterministic, so we're going to hold off on merging these changes until we can get the SequentialPlanner into a more stable state. I'll keep you posted, but these changes should be enough to get it working in your local environment for your personal use

authors: teresaqhoang thomasgobin


text:
fix: Add Azure OpenAI support for python/08-native-function-inline

Motivation and Context
Other Semantic Kernal samples allow using both OpenAI and Azure OpenAI by setting a different set of environment variables and toggling the useAzureOpenAI bool value
Description
Add the same snippet used in other notebooks such as 02-running-prompts-from-file to use Azure OpenAI to the 08-native-function-inline
Contribution Checklist

[ ] The code builds clean without any errors or warnings
[ ] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
[ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
[ ] All unit tests pass, and I have added new tests where possible
[ ] I didn't break anyone :smile:

Thanks for adding this! Great to have consistency between the rest of the notebooks.

authors: alexchaomander mattmazzola


text:
.Net: [Feature Branch] Function Call Filters

Motivation and Context

Related: https://github.com/microsoft/semantic-kernel/issues/5470
This PR contains changes for new type of filter - function call filters. They work similarly to function filters, but they have more information in a context (specific to function calling, like iteration number), and more control:

The ability to cancel function call loop (inner loop) - when single request to LLM returns multiple function calls, and we want to stop further execution.
The ability to cancel request loop (outer loop) - when all function are called, the last step is always a request to LLM to generate final message. This feature allows to avoid last request to LLM and return result of last executed function instead.
The ability to skip function execution - in this case function call process will proceed to the next function in pipeline.

Usage:
public class FunctionCallFilter(ILogger logger) : IFunctionCallFilter
{
    private readonly ILogger _logger = logger;

    public async Task OnFunctionCallInvocationAsync(FunctionCallInvocationContext context, Func<FunctionCallInvocationContext, Task> next)
    {
        // Example: get function information
        var functionName = context.Function.Name;

        // Example: get function call iteration information
        this._logger.LogDebug($"Function call iteration: {context.FunctionCallIteration + 1} out of {context.FunctionCallCount}");

        // Example: get request iteration
        this._logger.LogDebug($"Request iteration: {context.RequestIteration + 1}");

        // Calling next filter in pipeline or function itself.
        // By skipping this call, next filters and function won't be invoked, and function call loop will proceed to the next function.
        await next(context);

        // Example: get function result
        var result = context.Result;

        // Example: override function result value
        context.Result = new FunctionResult(context.Result, "Result from function call filter");

        // Example: stop further function calling. but proceed with request iteration
        context.Action = FunctionCallAction.StopFunctionCallIteration;

        // Example: call remaining functions, but stop request iteration
        context.Action = FunctionCallAction.StopRequestIteration;

        // Example: stop function calling and request iterations, return immediately
        context.Action = FunctionCallAction.StopRequestIteration | FunctionCallAction.StopFunctionCallIteration;
    }
}

Contribution Checklist

[x] The code builds clean without any errors or warnings
[x] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[x] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

It would be nice if you add also support for this in other connectors.

It would be nice if you add also support for this in other connectors.

@Krzysztof318 Thanks for feedback. The plan is to add this functionality to OpenAI connector first. In parallel, we are working on new function calling abstractions, and most probably all function calling logic will be extracted from connectors and moved to common place. Then, we will move filtering logic from OpenAI connector to this common place, which will be used by other connectors that support function calling. In this way, we will enable filtering for all connectors that support function calling feature.

@dmytrostruk oh okay, I totally forgot work on function calling abstraction is in progress 😶🌫


text:
CopilotChat: Add Azure Cog Search for Semantic Memory

Motivation and Context
Enable integration of Azure Cognitive Search as a semantic memory source.
Description

Added "AzureCognitiveSource" option for "MemoriesStore"
Refactored DI to provide full SemanticTextMemory instead of just MemoryStore since the Azure Cognitive Search connector does not have support for vectors and therefor is implemented at the SemanticTextMemory layer.

Does the SemanticMemory  example in kernel syntax examples need to be updated at all due to this change?

Does the Semantic Memory example need to be updated at all due to this change? (/samples/dotnet/kernel-syntax-examples/Example14_SemanticMemory.cs)

Does the Semantic Memory example need to be updated at all due to this change? (/samples/dotnet/kernel-syntax-examples/Example14_SemanticMemory.cs)

It does not - we are using the already provided ACS connector.

authors: adrianwyatt gitri-ms


text:
Optimized test resources

Updated tests setup calls to re-use existing templates, clients, databases and collections.
Improves CI by 10x factor.

Codecov Report

Merging #430 into master will increase coverage by 0.49%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
+ Coverage    73.7%   74.19%   +0.49%
==========================================
  Files          46       46
  Lines        1373     1372       -1
  Branches      154      154
==========================================
+ Hits         1012     1018       +6
+ Misses        279      269      -10
- Partials       82       85       +3

Impacted Files
Coverage Δ

...ing/data/cosmosdb/core/ReactiveCosmosTemplate.java
77.91% <100%> (+6.57%)
:arrow_up:

.../spring/data/cosmosdb/core/DocumentDbTemplate.java
86.41% <0%> (-1.65%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4886608...47f4360. Read the comment docs.

authors: codecov-io kushagraThapar

repo: microsoft/spring-data-cosmosdb


text:
Wait for page to load dom and css

Wait for page to load dom and css

Wanna bump the version now or add some commits ?

Updated version. In next push will update playwright also to 1.17.1 from current 1.11.1

repo: microsoft/storywright


text:
Issue Reporting App no longer available to add to new Teams channels

My organization uses the Issue Reporting App for a variety of purposes in different Teams channels and has plans to implement it further in the future. However, approximately 2 weeks ago, I discovered that the Issue Reporting App is no longer available to install/add to new Teams channels. The app does remain present and fully functional in Teams channels where it was already installed prior to this discovery.
It appears that the app has been removed from the default apps list. Is this a known issue? Has the app simply been relocated, or will it be restored? Thanks in advance for any help/info you are able to provide.

See issue #26 - may help

Thanks @RebeccaWilso. I did experience that same issue on 31Jan with the app after it had already been installed to an existing Team, but it was resolved the next day.
Unfortunately, I'm now having a different issue where the App seems to have disappeared from the list of default apps that can be added to a new Team.

authors: RebeccaWilso SamanthaGW

repo: microsoft/teams-powerapps-app-templates