text:
Default LocalQueue

What would you like to be added:
I would like to be able to indicate a default LocalQueue per namespace to be used for a workload
Why is this needed:
If an administrator creates a single LocalQueue per namespace that all workloads are expected to use, defaulting the queue let's quota consumers ignore the need to include Queue specific request labels in their workloads and enforces the need to be associated with a Queue in order to be scheduled.
Completion requirements:

[ ] API changes to LocalQueue spec which allow admin to specify it as default
[ ] Mutating webhook which will get the default LocalQueue and apply the appropriate label
[ ] Validating webhook which ensures that only one LocalQueue is marked as default

This enhancement requires the following artifacts:

[x] Design doc
[x] API change
[x] Docs update

The artifacts should be linked in subsequent comments.

@KPostOffice Do you assume that automatically https://kueue.sigs.k8s.io/docs/tasks/manage/setup_job_admission_policy/ generation?

@KPostOffice Do you assume that automatically https://kueue.sigs.k8s.io/docs/tasks/manage/setup_job_admission_policy/ generation?

Are you referring to the example AdmissionPolicy outlined in the documentation?

https://kueue.sigs.k8s.io/docs/tasks/manage/setup_job_admission_policy/

Yes, I indicated the ValidatingAdmissionPolicy.

/assign

Yeah, the assumption here would be that the policy would be in place

If we are going to modify API to have "default" field, it might be tricky to validate that only one LQ is a default. Are we going to abandon setting LQ as default if another default LQ is present in the namespace (in this case we do not validate the object itself)? If we can have multiple default LQs, which one is an actual default? It could be a first one or the last one.
To avoid those questions and the API change, I suggest to default LocalQueue that has default name, WDYT?

Let's have the "default" default LocalQueue and put the whole feature behind a feature gate, so we don't break anyone by accident.

Using the default LQ name behind a feature gate would be a fine solution from my perspective

It feels this feature requires a KEP, even if there is no "API" changed, we still introduce a feature-gate. Also, I feel the mechanism will evolve in the future, so having some reference we can update will be useful. It does not need to be long, just one pager to collect the use-cases and the proposed solution.

It feels this feature requires a KEP, even if there is no "API" changed, we still introduce a feature-gate. Also, I feel the mechanism will evolve in the future, so having some reference we can update will be useful. It does not need to be long, just one pager to collect the use-cases and the proposed solution.

+1

/reopen
For the documentation update

Basically, we want to have all features documented. Two places come to my mind (could be separate PRs):

LocalQueue page: https://github.com/kubernetes-sigs/kueue/blob/main/site/content/en/docs/concepts/local_queue.md?plain=1
a new section in the administrative tasks: https://github.com/kubernetes-sigs/kueue/tree/main/site/content/en/docs/tasks/manage/enforce_job_management, could be entitled "Setup Local Queue defaulting"

cc @PBundyra wdyt?

Basically, we want to have all features documented. Two places come to my mind (could be separate PRs):

LocalQueue page: https://github.com/kubernetes-sigs/kueue/blob/main/site/content/en/docs/concepts/local_queue.md?plain=1
a new section in the administrative tasks: https://github.com/kubernetes-sigs/kueue/tree/main/site/content/en/docs/tasks/manage/enforce_job_management, could be entitled "Setup Local Queue defaulting"

cc @PBundyra wdyt?

Agreed, I would also consider adding some note to the Run A Kubernetes Job page. However, I believe the note shouldn't be limited only to default LQ but it should also cover jobs without the LQ

Agreed, I would also consider adding some note to the Run A Kubernetes Job page. However, I believe the note shouldn't be limited only to default LQ but it should also cover jobs without the LQ

LocalQueueDefaulting is not limited to Kubernetes Job only, seems sigs/kueue/tree/main/site/content/en/docs/tasks/manage/enforce_job_management is the best place.

authors: KPostOffice PBundyra mimowo mwielgus tenzen-y yaroslava-serdiuk

repo: kubernetes-sigs/kueue


text:
Support kubeflow.org/tfjob

What type of PR is this?
/kind feature
What this PR does / why we need it:
I added the tfjob-controller to the frameworkjob-manager.
Which issue(s) this PR fixes:

Part-of https://github.com/kubernetes-sigs/kueue/issues/297
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Support kubeflow.org/tfjob

/assign @trasc

I can take this one
/assign

/label tide/merge-method-squash

@alculquicondor I addressed your comments. PTAL.

/lgtm
Awesome!

source: gharchive/pull-request

authors: alculquicondor tenzen-y

license_type: permissive

license_source: github-api


text:
update golang crypto to 0.31.0

What type of PR is this?
/kind bug

What this PR does / why we need it:
CVE scanners are flagging this now.
https://github.com/golang/go/issues/70779
CVE-2024-45337
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/hold
Going to test kueue-viz first.

hmm. I am having trouble getting kueue-viz to work without this PR on latest main.

okay. I think that was just user error.
/hold cancel


text:
fix(plugins/plugin-client-default): compilation error

Fixes #7546
When I merged PRs into master, git seemed to mess up rebasing https://github.com/kubernetes-sigs/kui/commit/0b95d9cdd216424206f57347e5de1d0821e21e53, due to duplicate variable names.
I first merged the S3 plugin PR, which removed the import of isPopup from plugin-client-default/index.tsx. https://github.com/kubernetes-sigs/kui/commit/177457f3156bf1e36d1fc671b96982ee6e89aa7f#diff-8d9874cfcd3046ea3d4915be2efb64cb7121331a6352b74ceb0e1db3824088c8L19
Then I merged the "enable split in Popup mode" PR, which uses isPopup() to put spacefiller. https://github.com/kubernetes-sigs/kui/commit/177457f3156bf1e36d1fc671b96982ee6e89aa7f#diff-8d9874cfcd3046ea3d4915be2efb64cb7121331a6352b74ceb0e1db3824088c8L19
I should get merge conflict when merging the second PR, but GitHub doesn't show Merge Conflict probably because index.tsx has another variable called isPopup?
Anyways, this PR fixed the compilation issue.

Description of what you did:

My PR is a:

[ ] 💥 Breaking change
[x] 🐛 Bug fix
[ ] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[x] Multiple commits are squashed into one commit.
[x] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[x] All npm dependencies are pinned.

/lgtm

repo: kubernetes-sigs/kui


text:
Add spoc, the Security Profiles Operator CLI

What type of PR is this?
/kind feature
What this PR does / why we need it:
We discussed in our last sync meeting that it would be helpful to have a slimmer SPO CLI for faster execution in edge scenarios. For that we would need a new binary, which can be used to directly interact with features like the ebpf recorder.
Which issue(s) this PR fixes:
Refers to https://github.com/kubernetes-sigs/security-profiles-operator/issues/1482
Does this PR have test?
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?

Added `spoc` binary, the Security Profiles Operator CLI. This new binary is also part of the default container images.

@kubernetes-sigs/security-profiles-operator-maintainers PTAL

/lgtm cancel
Let's let other maintainers look at this first

How do you envision the workflow of using the CLI? Does one need to run the spoc container on the same host next to another container for which the recording is performed?

No, my main idea was to provide 2 distinct sets of functionality:

Doing something without having a need for kubernetes at all, means that there is also no operator deployed
Having sort of client interface to the operator

Means we can start with the first one and trying to integrate bpf recording of executables. Later on we can use the same binary for other features.

authors: JAORMX saschagrunert


text:
Getting simulator scenario launch errors when current user IP doesn't match security group rule.

Create infrastructure from IP 1
Connect from IP 2
Run simulator scenario launch node-shock-tactics
SSH timeout is long, then errors as the TCP connection times out at the security group

Fix:

Run simulator infra create a second time when connected to IP 2 -- this creates the appropriate security group rules and then scenario deployment works

Debug output:
1.5733158573249292e+09  INFO    simulator/launch.go:61  Setting up the "Node Shock Tactics" scenario on the cluster
ssh: connect to host 3.9.118.211 port 22: Connection timed out
[2019-11-09T16:13:08+0000] ./perturb.sh: No hash found
[2019-11-09T16:13:08+0000] ./perturb.sh: Found scenario
[2019-11-09T16:13:08+0000] ./perturb.sh: Running scenario/node-shock-tactics/ against 172.31.2.37
Connection timed out during banner exchange
[2019-11-09T16:13:11+0000] ./perturb.sh: Cannot connect to 172.31.2.37
1.5733159911121545e+09  ERROR   cmd/scenario.go:54      Error launching scenario        {"error": "Error running perturb with simulator.PerturbOptions{Bastion:net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
0x0, 0x0, 0xff, 0xff, 0x3, 0x9, 0x76, 0xd3}, Master:net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xff, 0xff, 0xac, 0x1f, 0x2, 0x25}, Slaves:[]net.IP{net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0
, 0x0, 0x0, 0xff, 0xff, 0xac, 0x1f, 0x2, 0x33}, net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xff, 0xff, 0xac, 0x1f, 0x2, 0x2b}}, ScenarioName:\"node-shock-tactics\"}: Error waiting for child pr
ocess ./perturb.sh: exit status 3", "errorVerbose": "exit status 3\nError waiting for child process ./perturb.sh\ngithub.com/controlplaneio/simulator-standalone/pkg/util.Run\n\t/go/src/github.com/controlpla
neio/simulator-standalone/pkg/util/run.go:58\ngithub.com/controlplaneio/simulator-standalone/pkg/simulator.Perturb\n\t/go/src/github.com/controlplaneio/simulator-standalone/pkg/simulator/perturb.go:76\ngith
ub.com/controlplaneio/simulator-standalone/pkg/simulator.Launch\n\t/go/src/github.com/controlplaneio/simulator-standalone/pkg/simulator/launch.go:62\ngithub.com/controlplaneio/simulator-standalone/cmd.newSc
enarioLaunchCommand.func1\n\t/go/src/github.com/controlplaneio/simulator-standalone/cmd/scenario.go:49\ngithub.com/spf13/cobra.(*Command).execute\n\t/home/build/go/pkg/mod/github.com/spf13/cobra@v0.0.5/comm
and.go:826\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\t/home/build/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:914\ngithub.com/spf13/cobra.(*Command).Execute\n\t/home/build/go/pkg/mod/github.com/
spf13/cobra@v0.0.5/command.go:864\ngithub.com/controlplaneio/simulator-standalone/cmd.Execute\n\t/go/src/github.com/controlplaneio/simulator-standalone/cmd/root.go:109\nmain.main\n\t/go/src/github.com/contr
olplaneio/simulator-standalone/main.go:13\nruntime.main\n\t/usr/lib/go-1.11/src/runtime/proc.go:201\nruntime.goexit\n\t/usr/lib/go-1.11/src/runtime/asm_amd64.s:1333\nError running perturb with simulator.Per
turbOptions{Bastion:net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xff, 0xff, 0x3, 0x9, 0x76, 0xd3}, Master:net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xff, 0xff, 0xac, 0x1f, 0x2, 0
x25}, Slaves:[]net.IP{net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xff, 0xff, 0xac, 0x1f, 0x2, 0x33}, net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xff, 0xff, 0xac, 0x1f, 0x2, 0x2b}
}, ScenarioName:\"node-shock-tactics\"}\ngithub.com/controlplaneio/simulator-standalone/pkg/simulator.Launch\n\t/go/src/github.com/controlplaneio/simulator-standalone/pkg/simulator/launch.go:64\ngithub.com/
controlplaneio/simulator-standalone/cmd.newScenarioLaunchCommand.func1\n\t/go/src/github.com/controlplaneio/simulator-standalone/cmd/scenario.go:49\ngithub.com/spf13/cobra.(*Command).execute\n\t/home/build/
go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:826\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\t/home/build/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:914\ngithub.com/spf13/cobra.(*Command).
Execute\n\t/home/build/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:864\ngithub.com/controlplaneio/simulator-standalone/cmd.Execute\n\t/go/src/github.com/controlplaneio/simulator-standalone/cmd/root.

go:109\nmain.main\n\t/go/src/github.com/controlplaneio/simulator-standalone/main.go:13\nruntime.main\n\t/usr/lib/go-1.11/src/runtime/proc.go:201\nruntime.goexit\n\t/usr/lib/go-1.11/src/runtime/asm_amd64.s:1
333"}```
1.5733158573249292e+09  INFO    simulator/launch.go:61  Setting up the "Node Shock Tactics" scenario on the cluster
ssh: connect to host 3.9.118.211 port 22: Connection timed out
[2019-11-09T16:13:08+0000] ./perturb.sh: No hash found
[2019-11-09T16:13:08+0000] ./perturb.sh: Found scenario
[2019-11-09T16:13:08+0000] ./perturb.sh: Running scenario/node-shock-tactics/ against 172.31.2.37
Connection timed out during banner exchange
[2019-11-09T16:13:11+0000] ./perturb.sh: Cannot connect to 172.31.2.37
1.5733159911121545e+09  ERROR   cmd/scenario.go:54      Error launching scenario        {"error": "Error running perturb with simulator.PerturbOptions{Bastion:net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
0x0, 0x0, 0xff, 0xff, 0x3, 0x9, 0x76, 0xd3}, Master:net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xff, 0xff, 0xac, 0x1f, 0x2, 0x25}, Slaves:[]net.IP{net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0
, 0x0, 0x0, 0xff, 0xff, 0xac, 0x1f, 0x2, 0x33}, net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xff, 0xff, 0xac, 0x1f, 0x2, 0x2b}}, ScenarioName:\"node-shock-tactics\"}: Error waiting for child pr
ocess ./perturb.sh: exit status 3", "errorVerbose": "exit status 3\nError waiting for child process ./perturb.sh\ngithub.com/controlplaneio/simulator-standalone/pkg/util.Run\n\t/go/src/github.com/controlpla
neio/simulator-standalone/pkg/util/run.go:58\ngithub.com/controlplaneio/simulator-standalone/pkg/simulator.Perturb\n\t/go/src/github.com/controlplaneio/simulator-standalone/pkg/simulator/perturb.go:76\ngith
ub.com/controlplaneio/simulator-standalone/pkg/simulator.Launch\n\t/go/src/github.com/controlplaneio/simulator-standalone/pkg/simulator/launch.go:62\ngithub.com/controlplaneio/simulator-standalone/cmd.newSc
enarioLaunchCommand.func1\n\t/go/src/github.com/controlplaneio/simulator-standalone/cmd/scenario.go:49\ngithub.com/spf13/cobra.(*Command).execute\n\t/home/build/go/pkg/mod/github.com/spf13/cobra@v0.0.5/comm
and.go:826\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\t/home/build/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:914\ngithub.com/spf13/cobra.(*Command).Execute\n\t/home/build/go/pkg/mod/github.com/
spf13/cobra@v0.0.5/command.go:864\ngithub.com/controlplaneio/simulator-standalone/cmd.Execute\n\t/go/src/github.com/controlplaneio/simulator-standalone/cmd/root.go:109\nmain.main\n\t/go/src/github.com/contr
olplaneio/simulator-standalone/main.go:13\nruntime.main\n\t/usr/lib/go-1.11/src/runtime/proc.go:201\nruntime.goexit\n\t/usr/lib/go-1.11/src/runtime/asm_amd64.s:1333\nError running perturb with simulator.Per
turbOptions{Bastion:net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xff, 0xff, 0x3, 0x9, 0x76, 0xd3}, Master:net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xff, 0xff, 0xac, 0x1f, 0x2, 0
x25}, Slaves:[]net.IP{net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xff, 0xff, 0xac, 0x1f, 0x2, 0x33}, net.IP{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xff, 0xff, 0xac, 0x1f, 0x2, 0x2b}
}, ScenarioName:\"node-shock-tactics\"}\ngithub.com/controlplaneio/simulator-standalone/pkg/simulator.Launch\n\t/go/src/github.com/controlplaneio/simulator-standalone/pkg/simulator/launch.go:64\ngithub.com/
controlplaneio/simulator-standalone/cmd.newScenarioLaunchCommand.func1\n\t/go/src/github.com/controlplaneio/simulator-standalone/cmd/scenario.go:49\ngithub.com/spf13/cobra.(*Command).execute\n\t/home/build/
go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:826\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\t/home/build/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:914\ngithub.com/spf13/cobra.(*Command).
Execute\n\t/home/build/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:864\ngithub.com/controlplaneio/simulator-standalone/cmd.Execute\n\t/go/src/github.com/controlplaneio/simulator-standalone/cmd/root.

go:109\nmain.main\n\t/go/src/github.com/controlplaneio/simulator-standalone/main.go:13\nruntime.main\n\t/usr/lib/go-1.11/src/runtime/proc.go:201\nruntime.goexit\n\t/usr/lib/go-1.11/src/runtime/asm_amd64.s:1
333"}
github.com/controlplaneio/simulator-standalone/cmd.newScenarioLaunchCommand.func1
        /go/src/github.com/controlplaneio/simulator-standalone/cmd/scenario.go:54
github.com/spf13/cobra.(*Command).execute
        /home/build/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:826
github.com/spf13/cobra.(*Command).ExecuteC
        /home/build/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:914
github.com/spf13/cobra.(*Command).Execute
        /home/build/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:864
github.com/controlplaneio/simulator-standalone/cmd.Execute
        /go/src/github.com/controlplaneio/simulator-standalone/cmd/root.go:109
main.main
        /go/src/github.com/controlplaneio/simulator-standalone/main.go:13
runtime.main
        /usr/lib/go-1.11/src/runtime/proc.go:201
```

github.com/controlplaneio/simulator-standalone/cmd.newScenarioLaunchCommand.func1
        /go/src/github.com/controlplaneio/simulator-standalone/cmd/scenario.go:54
github.com/spf13/cobra.(*Command).execute
        /home/build/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:826
github.com/spf13/cobra.(*Command).ExecuteC
        /home/build/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:914
github.com/spf13/cobra.(*Command).Execute
        /home/build/go/pkg/mod/github.com/spf13/cobra@v0.0.5/command.go:864
github.com/controlplaneio/simulator-standalone/cmd.Execute
        /go/src/github.com/controlplaneio/simulator-standalone/cmd/root.go:109
main.main
        /go/src/github.com/controlplaneio/simulator-standalone/main.go:13
runtime.main
        /usr/lib/go-1.11/src/runtime/proc.go:201

</details>

We should exit perturb early with a well-known status code so we can advise the user in a more friendly way and not spew a stack trace

Perhaps the main point to document is the connecting from multiple ips is not an expected pattern?

@raoulmillais @sublimino are you guys OK with this being a position issue, if so lets close this out

@jondkent If we're closing this issue I think we need a paragraph or so of explanation before (or as) this issue is closed. At the moment I don't think this discussion will inform anyone not already familiar with simulator why this will not be worked on.
Also, I think there should be a new ticket created for @raoulmillais suggestion and linked here before this issue is closed.

source: gharchive/issue

authors: jondkent raoulmillais s-irvine sublimino

repo: kubernetes-simulator/simulator


text:
[cinder-csi-plugin] update plugin to v1.18.0

Use the latest version of the cinder-csi-plugin and related sidecars.
https://github.com/kubernetes/cloud-provider-openstack/releases/tag/v1.18.0
https://github.com/kubernetes-csi/external-attacher/releases/tag/v2.2.0
https://github.com/kubernetes-csi/external-provisioner/releases/tag/v1.6.0
https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v2.1.1
https://github.com/kubernetes-csi/external-resizer/releases/tag/v0.5.0
https://github.com/kubernetes-csi/node-driver-registrar/releases/tag/v1.3.0
[cinder-csi-plugin] update plugin to v1.18.0 and related sidecars to version compatible to 1.18 chart-version: 1.1.1

I updated the chart version. When there is a change (this was a change of a default) a minor version should be better bumped. Not a strong opinion on this but it is a good practice.

/ok-to-test

@strigazi Thanks for updating . Could you make the sidecar versions also compatible with 1.18 release. https://github.com/kubernetes/cloud-provider-openstack/blob/release-1.18/manifests/cinder-csi-plugin/

@strigazi Thanks for updating . Could you make the sidecar versions also compatible with 1.18 release. https://github.com/kubernetes/cloud-provider-openstack/blob/release-1.18/manifests/cinder-csi-plugin/

@ramineni Can you check the versions? Most sidecars mention that they are compatible with 1.18 but manifests in this repo are not using the latest. Also let me know if you want me to update the manifests you linked.

@ramineni Can you check the versions? Most sidecars mention that they are compatible with 1.18 but manifests in this repo are not using the latest. Also let me know if you want me to update the manifests you linked.

Thanks for the update. Looks good. Ya, not using latest as they might need some changes in code to use also not tested. So for 1.18 cinder-csi , we can update only currently tested versions which are part of the 1.18 release branch

@strigazi Could you update description as well , currently it contradicts with actual code changes

@strigazi Could you update description as well , currently it contradicts with actual code changes

done

Thanks.
/lgtm

Thanks, who needs to /approve ?

/lgtm

/approve

authors: jichenjc lingxiankong ramineni strigazi

repo: kubernetes/cloud-provider-openstack

license_source: bigquery


text:
update tags to v1.26.2

What this PR does / why we need it:
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

@zetaab when are you planning to release 1.26.2?

/approve

@kayrus can you add /lgtm

/lgtm

/override openstack-cloud-csi-cinder-e2e-test-release-126

authors: kayrus zetaab


text:
[occm] Make manage-security-groups work with OVN

What this PR does / why we need it:
OVN keeps the source IP of the incoming traffic. This means that the SG
on the members of the LB (nodes) needs to have a rule opening traffic
not only from inside the cluster, but also elsewhere. This can
restricted by using the Service.Spec.LoadBalancerSourceRanges and this
commit also makes sure the setting is taken into account.
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:
Release note:

[openstack-cloud-controller-manager] Implemented support for `loadBalancerSourceRanges` for OVN Octavia Provider (with manage-security-groups enabled).

This is based on #2287, I'll rebase it once it merges.

/hold

Is this behaviour dependent on externalTrafficPolicy?

Is this behaviour dependent on externalTrafficPolicy?

Not really. Motivations for this PR:

OVN needs different SGs as it keeps original source IP of the traffic.
OVN does not implement support for allowed_cidrs property on the LB listeners. Instead we're supposed to set the SGs on the LB members to limit traffic. This commit makes sure we're using loadBalancerSourceRanges to set the correct CIDRs on these SG rules.

/hold cancel

Doesn't this give unprivileged cluster users the ability to open the firewall to arbitrary ports on worker nodes? This doesn't sound like a good idea.

Hm, good question… So this particular change does not really affect ports being open, the [LoadBalancer]manage-security-groups set to true does.
This change only makes sure OVN LBs will open what's required for them to work (unfortunately it's 0.0.0.0/0 as we don't know source IP) and use LoadBalancerSourceRanges to limit that range if specified. This doesn't affect how SG rules are created in Amphora use case. And without this PR OVN LBs would only be accessible from inside the cluster when manage-security-groups is enabled.
Now in regards to ports - without manage-security-groups=true you need to open the whole NodePorts range (30000-32767 by default, just below ephemeral ports range) on the nodes anyway to make your LoadBalancer Services working. Example in OpenShift ^1.
The idea of manage-security-groups is to only open these ports selectively when a Service is created with such a NodePort. While user can request a certain NodePort number when creating a Service instead of letting K8s assign it at random, it still has to be from the NodePort range:
# services "test2" was not valid:
# * spec.ports[0].nodePort: Invalid value: 22: provided port is not in the valid range. The range of valid ports is 30000-32767

So to me both this patch and manage-security-groups=true doesn't make the situation worse, but better.

code good , but we are adding more and more features into the repo
I think we should think about enable such in the CI @dulek @mdbooth , e.g OVN or manage-security-groups=true ?

/approve

code good , but we are adding more and more features into the repo I think we should think about enable such in the CI @dulek @mdbooth , e.g OVN or manage-security-groups=true ?

Yeah, that makes perfect sense. I'll see what I can do to extend the testing.

authors: dulek jichenjc mdbooth


text:
[occm] Allow changing cluster-name on existing deployments

What this PR does / why we need it:
It's a common issue that clusters are deployed with the default --cluster-name=kubernetes and later on it's discovered that next deployments on the same cloud will have conflicts when trying to manage LBs of the same namespace and name.
This commit aims at allowing to change the cluster-name on a running environment and handling all the renames of the LB resources and their tags.
Which issue this PR fixes(if applicable):
fixes #2241
Special notes for reviewers:

Release note:
It's now allowed to change the `--cluster-name` on existing deployments and OCCM will handle all the LB renames.

This is a WiP, definitely needs unit tests and some more manual testing from me.

It's a common issue that clusters are deployed with the default --cluster-name=kubernetes and later on it's discovered that next deployments on the same cloud will have conflicts when trying to manage LBs of the same namespace and name.

I remember it's been discussed multiple times before (with --cluster-name=kubernetes)
at that time seems the conclusion is related to cloud provider itself or I might remember wrong thing
but I think it's worthy to open an issue to have some discussion there to get agreement on the goal and fix proposal..

@jichenjc: I dug out #2241 and added it to this PR. Citing @zetaab from there:

the problem is that quite many cluster still uses default clusterName which is kubernetes. It is also difficult to migrate away from it.

This is what the PR proposes - to make it easier to migrate away from a wrong clusterName.

Hey, @stephenfin, could you take a preliminary look?

And you @gryf.

Looks good from my side as well. Good job, @dulek!

/lgtm
...is what I meant :sweat_smile:

/approve
I think @zetaab you approved this :)
will read this later and input if I have more time

authors: dulek gryf jichenjc stephenfin


text:
Ingress glbc pod: NodePort should have a firewall rule auto-created for health check

It looks like the glbc pod gets created with a dynamic NodePort.
Under the GCE HTTP console, the health check for this service shows up as "unhealthy" - because no firewall rule has been created to allow the HTTP load balancer to probe the service.
Users should not be required to create the firewall rule for this to work (very confusing). Ideally, any firewall rules should be auto-created.

Thanks for the report. I agree we should create the firewall rule for the default backend service because this service is create as part of kube-up. It shouldn't affect traffic to your other endpoints, though.

authors: bprashanth wstrange

repo: kubernetes/contrib


text:
change simple nginx example to use kubectl create instead of kubectl run

Fix #277
I updated the simple nginx example to only use not deprecated commands.

/assign @sebgoa

/ok-to-test

authors: ebriand idvoretskyi pontiyaraja

repo: kubernetes/examples


text:
docs(logo): add the official helm logo png

/cc @runseb

+1

authors: runseb technosophos

repo: kubernetes/helm


text:
Surpport snippet for server section by the annotation of the ingess

eg:
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
annotations:
ingress.kubernetes.io/server-snippet: |
set $agentflag 0;

if ($http_user_agent ~* "(Mobile)" )
{
set $agentflag 1;
}

  if ( $agentflag = 1 ) {
    return 301 https://m.example.com;
  }

This change is

Coverage decreased (-0.04%) to 43.673% when pulling 15c6a1175a0d71212c322653b797d6e67c6dd556 on decker502:server-snippet into 37bd14dcd2af5c006e9a717d11d270f2590f26a8 on kubernetes:master.

Coverage increased (+0.04%) to 43.752% when pulling 5dfee7ba9a04ef19d10931e83b507c8d0ede9645 on decker502:server-snippet into 37bd14dcd2af5c006e9a717d11d270f2590f26a8 on kubernetes:master.

/lgtm

@decker502 thanks!

repo: kubernetes/ingress


text:
Service Principal doesn't reference a valid application object

inside  the docker, after make docker-dev a run of make deploy dies shortly after the creation of the client ID instance.
The error state ls:
2016-09-30T03:58:24.611Z:
{ Error: {"odata.error":{"code":"Request_BadRequest","message":{"lang":"en","value":"The appId of the service principal does not reference a valid application object."},"values":[{"item":"PropertyName","value":"appId"},{"item":"PropertyErrorCode","value":"NoBackingApplicationObject"}]}}
  <<< async stack >>>
  at __1 (/usr/lib/node_modules/azure-cli/lib/commands/arm/ad/ad.servicePrincipals.js:174:41)
  at __3 (/usr/lib/node_modules/azure-cli/lib/commands/arm/ad/ad.servicePrincipals.js:172:30)
  <<< raw stack >>>
    at /usr/lib/node_modules/azure-cli/node_modules/azure-graph/lib/operations/servicePrincipals.js:145:19
    at retryCallback (/usr/lib/node_modules/azure-cli/node_modules/ms-rest/lib/filters/exponentialRetryPolicyFilter.js:140:9)
    at handleRedirect (/usr/lib/node_modules/azure-cli/node_modules/ms-rest/lib/filters/redirectFilter.js:36:9)
    at /usr/lib/node_modules/azure-cli/lib/util/utils.js:587:7
    at handleRedirect (/usr/lib/node_modules/azure-cli/lib/util/utils.js:564:9)
    at /usr/lib/node_modules/azure-cli/lib/util/logging.js:339:7
    at Request._callback (/usr/lib/node_modules/azure-cli/node_modules/ms-rest/lib/requestPipeline.js:125:16)
    at Request.self.callback (/usr/lib/node_modules/azure-cli/node_modules/request/request.js:187:22)
    at emitTwo (events.js:106:13)
    at Request.emit (events.js:191:7)
  stack: [Getter/Setter],
  statusCode: 400,
  request:
   { rawResponse: false,
     queryString: {},
     method: 'POST',
     headers:
      { 'x-ms-client-request-id': '50ab48e0-85d7-4000-83cb-aa9094b67cfe',
        'accept-language': 'en-US',
        'Content-Type': 'application/json; charset=utf-8',
        'user-agent': 'WindowsAzureXplatCLI/0.10.5' },
     url: 'https://graph.windows.net/8134123d-2209-41c1-87f1-c410786b408f/servicePrincipals?api-version=1.6',
     body: '{"appId":"36c3f8b4-f370-4782-a6ac-a459833329b3","accountEnabled":true}' },
  response:
   { body: '{"odata.error":{"code":"Request_BadRequest","message":{"lang":"en","value":"The appId of the service principal does not reference a valid application object."},"values":[{"item":"PropertyName","value":"appId"},{"item":"PropertyErrorCode","value":"NoBackingApplicationObject"}]}}',
     headers:
      { 'cache-control': 'private',
        'content-type': 'application/json;odata=minimalmetadata;charset=utf-8',
        server: 'Microsoft-IIS/8.5',
        'ocp-aad-diagnostics-server-name': 'HgGHeNSQrM9XpX3oc/01cDMvT65hkzBBO7e+bQY/4x4=',
        'request-id': '2afba286-0eab-453c-9214-48ff0c73ecf4',
        'client-request-id': '83d133c1-61d6-4bfc-9133-b98df79922c5',
        'x-ms-dirapi-data-contract-version': '1.6',
        'ocp-aad-session-key': '<removed>',
        'strict-transport-security': 'max-age=31536000; includeSubDomains',
        'access-control-allow-origin': '*',
        'x-aspnet-version': '4.0.30319',
        'x-powered-by': 'ASP.NET, ASP.NET',
        duration: '2357676',
        date: 'Fri, 30 Sep 2016 03:58:25 GMT',
        connection: 'close',
        'content-length': '278' },
     statusCode: 400 },
  body:
   { code: 'Request_BadRequest',
     message: 'The appId of the service principal does not reference a valid application object.' },
  __frame:
   { name: '__1',
     line: 173,
     file: '/usr/lib/node_modules/azure-cli/lib/commands/arm/ad/ad.servicePrincipals.js',
     prev:
      { name: '__3',
        line: 103,
        file: '/usr/lib/node_modules/azure-cli/lib/commands/arm/ad/ad.servicePrincipals.js',
        prev: undefined,
        calls: 1,
        active: false,
        offset: 69,
        col: 29 },
     calls: 0,
     active: false,
     offset: 1,
     col: 40 },
  rawStack: [Getter] }
Error: {"odata.error":{"code":"Request_BadRequest","message":{"lang":"en","value":"The appId of the service principal does not reference a valid application object."},"values":[{"item":"PropertyName","value":"appId"},{"item":"PropertyErrorCode","value":"NoBackingApplicationObject"}]}}
  <<< async stack >>>
  at __1 (/usr/lib/node_modules/azure-cli/lib/commands/arm/ad/ad.servicePrincipals.js:174:41)
  at __3 (/usr/lib/node_modules/azure-cli/lib/commands/arm/ad/ad.servicePrincipals.js:172:30)
  <<< raw stack >>>
    at /usr/lib/node_modules/azure-cli/node_modules/azure-graph/lib/operations/servicePrincipals.js:145:19
    at retryCallback (/usr/lib/node_modules/azure-cli/node_modules/ms-rest/lib/filters/exponentialRetryPolicyFilter.js:140:9)
    at handleRedirect (/usr/lib/node_modules/azure-cli/node_modules/ms-rest/lib/filters/redirectFilter.js:36:9)
    at /usr/lib/node_modules/azure-cli/lib/util/utils.js:587:7
    at handleRedirect (/usr/lib/node_modules/azure-cli/lib/util/utils.js:564:9)
    at /usr/lib/node_modules/azure-cli/lib/util/logging.js:339:7
    at Request._callback (/usr/lib/node_modules/azure-cli/node_modules/ms-rest/lib/requestPipeline.js:125:16)
    at Request.self.callback (/usr/lib/node_modules/azure-cli/node_modules/request/request.js:187:22)
    at emitTwo (events.js:106:13)
    at Request.emit (events.js:191:7)

my git state is: efd642dfb0d09995e5fe1c27664cfa5a1dcd3410

Can you please delete your .config and .config.json and try again? I
strongly suspect some stale state from a previous attempt is interfering.
On Sep 29, 2016 9:14 PM, "George Michaelson" notifications@github.com
wrote:

my git state is: efd642d
https://github.com/kubernetes/kubernetes-anywhere/commit/efd642dfb0d09995e5fe1c27664cfa5a1dcd3410
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes-anywhere/issues/251#issuecomment-250654619,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAT9dEg8lCD1cfjsXolEbIX330m8znIUks5qvIyJgaJpZM4KKtZG
.

I re-ran with make clean and rm -f .config .config.json. Same outcome.

Successfully built 942eb6dc568c
Starting Kuberetes Anywhere deployment shell in a container
docker run -it --rm --env="PS1=[container]:\w> " --net=host --volume="`pwd`:/opt/kubernetes-anywhere" kubernetes-anywhere:v0.0.1 /bin/bash
[container]:/opt/kubernetes-anywhere> make clean
rm -rf .tmp
rm -rf phase3/.tmp
rm -rf phase1/gce/.tmp
rm -rf phase1/azure/.tmp
[container]:/opt/kubernetes-anywhere> rm .config .config.json
[container]:/opt/kubernetes-anywhere> make deploy
make config
make[1]: Entering directory '/opt/kubernetes-anywhere'
CONFIG_="." kconfig-conf Kconfig
*
* Kubernetes Minimal Turnup Configuration
*
*
* Phase 1: Cluster Resource Provisioning
*
number of nodes (phase1.num_nodes) [4] (NEW)
cluster name (phase1.cluster_name) [kubernetes] (NEW) ggm4
*
* cloud provider
*
cloud provider (phase1.cloud_provider) [gce] (NEW) azure
  *
  * Azure configuration
  *
  Azure SubscriptionID (phase1.azure.subscription_id) [] (NEW) 4babca81-4251-40e1-9f9c-def756f4db23
  Azure TenantID (phase1.azure.tenant_id) [] (NEW)  8134123d-2209-41c1-87f1-c410786b408f
  Azure Active Directory ServicePrincipal ClientID (phase1.azure.client_id) [] (NEW)
  Azure Active Directory ServicePrincipal ClientSecret (phase1.azure.client_secret) [] (NEW)
  Base Virtual Machine OS Image (phase1.azure.image_publisher) [canonical] (NEW)
  Base Virtual Machine OS Image (phase1.azure.image_offer) [ubuntuserver] (NEW)
  Base Virtual Machine OS Image (phase1.azure.image_sku) [16.04.0-LTS] (NEW)
  Base Virtual Machine OS Image (phase1.azure.image_version) [latest] (NEW)
  Virtual Machine Size (Master) (phase1.azure.master_vm_size) [Standard_D1_v2] (NEW)
  Virtual Machine Size (Node) (phase1.azure.node_vm_size) [Standard_D1_v2] (NEW)
  Private IP address of Master (phase1.azure.master_private_ip) [10.240.1.4] (NEW)
  Resource Location (phase1.azure.location) [westus2] (NEW)
  Virtual Machine Admin Username (phase1.azure.admin_username) [kube] (NEW)
  Virtual Machine Admin Password (phase1.azure.admin_password) [Ch@ng3ThisPassword] (NEW) <removed>
*
* Phase 2: Node Bootstrapping
*
installer container (phase2.installer_container) [docker.io/colemickens/k8s-ignition:latest] (NEW)
docker registry (phase2.docker_registry) [gcr.io/google-containers] (NEW)
kubernetes version (phase2.kubernetes_version) [v1.4.0] (NEW)
*
* Phase 3: Deploying Addons
*
Run the addon manager? (phase3.run_addons) [Y/n/?] (NEW)
  Run kube-proxy? (phase3.kube_proxy) [Y/n/?] (NEW)
  Run the dashboard? (phase3.dashboard) [Y/n/?] (NEW)
  Run heapster? (phase3.heapster) [Y/n/?] (NEW)
  Run kube-dns? (phase3.kube_dns) [Y/n/?] (NEW)
#
# configuration written to .config
#
make[1]: Leaving directory '/opt/kubernetes-anywhere'
util/config_to_json .config > .config.json
make do WHAT=deploy-cluster
make[1]: Entering directory '/opt/kubernetes-anywhere'
( cd "phase1/$(jq -r '.phase1.cloud_provider' .config.json)"; ./do deploy-cluster )

Azure 'client_id' and 'client_secret' are empty.
This will now create a ServicePrincipal named 'ggm4', identified by 'http://ggm4' which will be granted 'Contributor' access to the specific subscription.
Proceed and create new ServicePrincipal? [y/n] y
info:    Executing command login
/info:    To sign in, use a web browser to open the page https://aka.ms/devicelogin. Enter the code HAHSHDNGF to authenticate.
-info:    Added subscription Free Trial
info:    Setting subscription "Free Trial" as default
+
info:    login command OK
error:   {"odata.error":{"code":"Request_BadRequest","message":{"lang":"en","value":"The appId of the service principal does not reference a valid application object."},"values":[{"item":"PropertyName","value":"appId"},{"item":"PropertyErrorCode","value":"NoBackingApplicationObject"}]}}
error:   Error information has been recorded to /root/.azure/azure.err
error:   ad sp create command failed

Makefile:53: recipe for target 'do' failed
make[1]: *** [do] Error 1
make[1]: Leaving directory '/opt/kubernetes-anywhere'
Makefile:41: recipe for target 'deploy-cluster' failed
make: *** [deploy-cluster] Error 2
[container]:/opt/kubernetes-anywhere>

Hi @ggm-at-apnic. On the other thread you wrote that you "applied the patches, and got the outcome". Does that mean things are working now?
The only change made today that would've affected you is adding an additional sleep to workaround AAD propagation delays. (It's possible that it can still happen. Unfortunately the best I can do for now is to add that extra sleep and document that users may have to wait a minute or two and retry.)
If it's all working we can go ahead and close this out, hopefully. Thanks!

No, It is not working.
I applied all the patches you have shipped, I am on head. I get the error I
consistently send you, in any response. The added delay has not fixed my
problem.
Please don't close this out: the docker and commands as documented do not
work for me, on a clean state.
On 30 September 2016 at 16:27, Cole Mickens notifications@github.com
wrote:

Hi @ggm-at-apnic https://github.com/ggm-at-apnic. On the other thread
you wrote that you "applied the patches, and got the outcome". Does that
mean things are working now?
The only change made today that would've affected you is adding an
additional sleep to workaround AAD propagation delays. (It's possible that
it can still happen. Unfortunately the best I can do for now is to add that
extra sleep and document that users may have to wait a minute or two and
retry.)
If it's all working we can go ahead and close this out, hopefully. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes-anywhere/issues/251#issuecomment-250669356,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHfeSM6Swe61xnRbaYTb31PTMY8pzu5Lks5qvKvegaJpZM4KKtZG
.

I'm not going to close it until we get it sorted.
Can you please change cluster_name and try again? Again, I suspect that you are having issues because you are re-using a SP/App name that was misconfigured by your other attempts.

Alternatively, you can login to the new AAD section of the Azure Portal and clear out the existing ggm4 Application and see if that helps you progress further.

here is a log of a clean-state run.
I even blew away the package and re-cloned.
ggmwork-2 $ rm -rf kubernetes-anywhere
ggmwork-2 $ git clone https://github.com/kubernetes/kubernetes-anywhere.git
(push)
-bash: syntax error near unexpected token `('
ggmwork-2 $ git clone https://github.com/kubernetes/kubernetes-anywhere.git
Cloning into 'kubernetes-anywhere'...
remote: Counting objects: 3774, done.
remote: Total 3774 (delta 0), reused 0 (delta 0), pack-reused 3774
Receiving objects: 100% (3774/3774), 3.92 MiB | 1.11 MiB/s, done.
Resolving deltas: 100% (2360/2360), done.
ggmwork-2 $ cd kubernetes-anywhere/
ggmwork-2 $ make docker-dev
docker build -t kubernetes-anywhere:v0.0.1 .
Sending build context to Docker daemon 158.7 kB
Step 1 : FROM mhart/alpine-node:6.4.0
---> ecd37ad77c2b
Step 2 : RUN apk add --update bash
---> Using cache
---> 3ccd42197a72
Step 3 : ADD ./util/docker-build.sh /opt/
---> Using cache
---> 2ec520abd49b
Step 4 : RUN /opt/docker-build.sh
---> Using cache
---> dfcab737b706
Step 5 : WORKDIR /opt/kubernetes-anywhere
---> Using cache
---> d95255151329
Step 6 : ADD . /opt/kubernetes-anywhere/
---> Using cache
---> af4ea238493b
Step 7 : CMD make
---> Using cache
---> 6bef7b3aba25
Successfully built 6bef7b3aba25
Starting Kuberetes Anywhere deployment shell in a container
docker run -it --rm --env="PS1=container:\w> " --net=host
--volume="pwd:/opt/kubernetes-anywhere" kubernetes-anywhere:v0.0.1
/bin/bash
container:/opt/kubernetes-anywhere> make clean
rm -rf .tmp
rm -rf phase3/.tmp
rm -rf phase1/gce/.tmp
rm -rf phase1/azure/.tmp
container:/opt/kubernetes-anywhere> rm .config .config-json
rm: can't remove '.config': No such file or directory
rm: can't remove '.config-json': No such file or directory
container:/opt/kubernetes-anywhere> rm .config .config.json
rm: can't remove '.config': No such file or directory
rm: can't remove '.config.json': No such file or directory
container:/opt/kubernetes-anywhere> make deploy
make config
make[1]: Entering directory '/opt/kubernetes-anywhere'
CONFIG_="." kconfig-conf Kconfig

Kubernetes Minimal Turnup Configuration

Phase 1: Cluster Resource Provisioning

number of nodes (phase1.num_nodes) [4] (NEW)
cluster name (phase1.cluster_name) [kubernetes] (NEW) newrandomkube

cloud provider

cloud provider (phase1.cloud_provider) [gce] (NEW) azure

Azure configuration

Azure SubscriptionID (phase1.azure.subscription_id) [] (NEW)
4babca81-4251-40e1-9f9c-def756f4db23
Azure Active Directory ServicePrincipal ClientID (phase1.azure.client_id)
[] (NEW)
Azure Active Directory ServicePrincipal ClientSecret
(phase1.azure.client_secret) [] (NEW)
Base Virtual Machine OS Image (phase1.azure.image_publisher) [canonical]
(NEW)
Base Virtual Machine OS Image (phase1.azure.image_offer) [ubuntuserver]
(NEW)
Base Virtual Machine OS Image (phase1.azure.image_sku) [16.04.0-LTS]
(NEW)
Base Virtual Machine OS Image (phase1.azure.image_version) [latest] (NEW)
Azure Storage Account Name (phase1.azure.storage_account_name) [] (NEW)
Virtual Machine Size (Master) (phase1.azure.master_vm_size)
[Standard_D1_v2] (NEW)
Virtual Machine Size (Node) (phase1.azure.node_vm_size) [Standard_D1_v2]
(NEW)
Private IP address of Master (phase1.azure.master_private_ip)
[10.240.1.4] (NEW)
Resource Location (phase1.azure.location) [westus2] (NEW)
Virtual Machine Admin Username (phase1.azure.admin_username) [kube] (NEW)
Virtual Machine Admin Password (phase1.azure.admin_password)
[Ch@ng3ThisPassword] (NEW)

Phase 2: Node Bootstrapping

installer container (phase2.installer_container) [
docker.io/colemickens/k8s-ignition:latest] (NEW)
docker registry (phase2.docker_registry) [gcr.io/google-containers] (NEW)
kubernetes version (phase2.kubernetes_version) [v1.4.0] (NEW)

Phase 3: Deploying Addons

Run the addon manager? (phase3.run_addons) [Y/n/?] (NEW)
Run kube-proxy? (phase3.kube_proxy) [Y/n/?] (NEW)
Run the dashboard? (phase3.dashboard) [Y/n/?] (NEW)
Run heapster? (phase3.heapster) [Y/n/?] (NEW)
Run kube-dns? (phase3.kube_dns) [Y/n/?] (NEW)

configuration written to .config

make[1]: Leaving directory '/opt/kubernetes-anywhere'
util/config_to_json .config > .config.json
make do WHAT=deploy-cluster
make[1]: Entering directory '/opt/kubernetes-anywhere'
( cd "phase1/$(jq -r '.phase1.cloud_provider' .config.json)"; ./do
deploy-cluster )
Azure 'client_id' and 'client_secret' are empty.
This will now create a ServicePrincipal named 'newrandomkube', identified
by 'http://newrandomkube' which will be granted 'Contributor' access to the
specific subscription.
Proceed and create new ServicePrincipal? [y/n] y
info:    Executing command login
/info:    To sign in, use a web browser to open the page
https://aka.ms/devicelogin. Enter the code HBLPTK9MH to authenticate.
/info:    Added subscription Free Trial
info:    Setting subscription "Free Trial" as default

info:    login command OK
error:
{"odata.error":{"code":"Request_BadRequest","message":{"lang":"en","value":"The
appId of the service principal does not reference a valid application
object."},"values":[{"item":"PropertyName","value":"appId"},{"item":"PropertyErrorCode","value":"NoBackingApplicationObject"}]}}
error:   Error information has been recorded to /root/.azure/azure.err
error:   ad sp create command failed
Makefile:53: recipe for target 'do' failed
make[1]: *** [do] Error 1
make[1]: Leaving directory '/opt/kubernetes-anywhere'
Makefile:41: recipe for target 'deploy-cluster' failed
make: *** [deploy-cluster] Error 2

Hm! Thanks for your patience and help in troubleshooting this.
Would you mind giving me a copy of the azure.err file? If you want, you can run this (`cp /root/.azure/azure.err /opt/kubernetes-anywhere/azure.err), and it will copy it into the volume so you can access it from your host to drag/drop on Github or as a Gist.
I may have to consult with some more folks tomorrow to make more forward progress.

Ok. here it is.
azure.err.zip

status? I am basically roadblocked on this.
-G
On 30 September 2016 at 17:01, Cole Mickens notifications@github.com
wrote:

Hm! Thanks for your patience and help in troubleshooting this.
Would you mind giving me a copy of the azure.err file? If you want, you
can run this (`cp /root/.azure/azure.err /opt/kubernetes-anywhere/azure.err),
and it will copy it into the volume so you can access it from your host to
drag/drop on Github or as a Gist.
I may have to consult with some more folks tomorrow to make more forward
progress.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes-anywhere/issues/251#issuecomment-250674146,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHfeSKmSVAfXg6Qi4x14WwRkaAE9wfg9ks5qvLPfgaJpZM4KKtZG
.

Hi @ggm-at-apnic, I'll take a look at this again today.
In the meantime, you can create your own App / Service Principal through the legacy portal and unblock yourself: https://www.terraform.io/docs/providers/azurerm/ has instructions.

Additionally, if you can edit the file phase1/azure/create-azure-service-principal.sh and add set -x near the top, and then try the deployment again (with a new/unique cluster_name) and send me the output, that would be helpful.
So far, I'm having a hard time understanding why Graph API is telling you that it created the App but then when you go to create an SP, it claims to not know about that App. That's not meant to happen, and I'm unable to repro, so more hints from you would be helpful depending on how much you want to help debug this.

[container]:/opt/kubernetes-anywhere> make deploy
make config
make[1]: Entering directory '/opt/kubernetes-anywhere'
CONFIG_="." kconfig-conf Kconfig
*
* Kubernetes Minimal Turnup Configuration
*
*
* Phase 1: Cluster Resource Provisioning
*
number of nodes (phase1.num_nodes) [4] (NEW)
cluster name (phase1.cluster_name) [kubernetes] (NEW) ggmtestingatapnicdotnet
*
* cloud provider
*
cloud provider (phase1.cloud_provider) [gce] (NEW) azure
  *
  * Azure configuration
  *
  Azure SubscriptionID (phase1.azure.subscription_id) [] (NEW) 4babca81-4251-40e1-9f9c-def756f4db23
  Azure Active Directory ServicePrincipal ClientID (phase1.azure.client_id) [] (NEW)
  Azure Active Directory ServicePrincipal ClientSecret (phase1.azure.client_secret) [] (NEW)
  Base Virtual Machine OS Image (phase1.azure.image_publisher) [canonical] (NEW)
  Base Virtual Machine OS Image (phase1.azure.image_offer) [ubuntuserver] (NEW)
  Base Virtual Machine OS Image (phase1.azure.image_sku) [16.04.0-LTS] (NEW)
  Base Virtual Machine OS Image (phase1.azure.image_version) [latest] (NEW)
  Azure Storage Account Name (phase1.azure.storage_account_name) [] (NEW)
  Virtual Machine Size (Master) (phase1.azure.master_vm_size) [Standard_D1_v2] (NEW)
  Virtual Machine Size (Node) (phase1.azure.node_vm_size) [Standard_D1_v2] (NEW)
  Private IP address of Master (phase1.azure.master_private_ip) [10.240.1.4] (NEW)
  Resource Location (phase1.azure.location) [westus2] (NEW)
  Virtual Machine Admin Username (phase1.azure.admin_username) [kube] (NEW)
  Virtual Machine Admin Password (phase1.azure.admin_password) [Ch@ng3ThisPassword] (NEW) mumbledypeg
*
* Phase 2: Node Bootstrapping
*
installer container (phase2.installer_container) [docker.io/colemickens/k8s-ignition:latest] (NEW)
docker registry (phase2.docker_registry) [gcr.io/google-containers] (NEW)
kubernetes version (phase2.kubernetes_version) [v1.4.1] (NEW)
*
* Phase 3: Deploying Addons
*
Run the addon manager? (phase3.run_addons) [Y/n/?] (NEW)
  Run kube-proxy? (phase3.kube_proxy) [Y/n/?] (NEW)
  Run the dashboard? (phase3.dashboard) [Y/n/?] (NEW)
  Run heapster? (phase3.heapster) [Y/n/?] (NEW)
  Run kube-dns? (phase3.kube_dns) [Y/n/?] (NEW)
#
# configuration written to .config
#
make[1]: Leaving directory '/opt/kubernetes-anywhere'
util/config_to_json .config > .config.json
make do WHAT=deploy-cluster
make[1]: Entering directory '/opt/kubernetes-anywhere'
( cd "phase1/$(jq -r '.phase1.cloud_provider' .config.json)"; ./do deploy-cluster )

Azure 'client_id' and 'client_secret' are empty.
This will now create a ServicePrincipal named 'ggmtestingatapnicdotnet', identified by 'http://ggmtestingatapnicdotnet' which will be granted 'Contributor' access to the specific subscription.
Proceed and create new ServicePrincipal? [y/n] y
+ set -eu -o pipefail
+ :
+ case ${1:-} in
+ subscription_id=4babca81-4251-40e1-9f9c-def756f4db23
+ shift
+ :
+ case ${1:-} in
+ app_name=ggmtestingatapnicdotnet
+ shift
+ :
+ case ${1:-} in
+ client_secret=56506c9e-3a8e-43b8-b70a-83e58dfb9adf
+ shift
+ :
+ case ${1:-} in
+ app_url=http://ggmtestingatapnicdotnet
+ shift
+ :
+ case ${1:-} in
+ output_format=text
+ shift
+ :
+ case ${1:-} in
+ break
+ [[ ! -z 4babca81-4251-40e1-9f9c-def756f4db23 ]]
+ [[ ! -z http://ggmtestingatapnicdotnet ]]
+ [[ ! -z 56506c9e-3a8e-43b8-b70a-83e58dfb9adf ]]
+ [[ ! -z '' ]]
+ which jq
+ which azure
+ azure account show

++ azure account show --json
++ jq -r '.[] | .tenantId'
+ tenant_id=127d8d0d-7ccf-473d-ab09-6e44ad752ded
++ azure ad app create -n ggmtestingatapnicdotnet -i http://ggmtestingatapnicdotnet --home-page http://ggmtestingatapnicdotnet -p 56506c9e-3a8e-43b8-b70a-83e58dfb9adf --json
+ raw_json='{
  "objectId": "8c355709-70f6-49c3-9c3d-c83a382fe177",
  "objectType": "Application",
  "appId": "2c18775b-56ab-4d67-9975-e854b46c0769",
  "availableToOtherTenants": false,
  "displayName": "ggmtestingatapnicdotnet",
  "identifierUris": [
    "http://ggmtestingatapnicdotnet"
  ],
  "replyUrls": [],
  "homepage": "http://ggmtestingatapnicdotnet"
}'
++ jq -r .appId
++ echo '{' '"objectId":' '"8c355709-70f6-49c3-9c3d-c83a382fe177",' '"objectType":' '"Application",' '"appId":' '"2c18775b-56ab-4d67-9975-e854b46c0769",' '"availableToOtherTenants":' false, '"displayName":' '"ggmtestingatapnicdotnet",' '"identifierUris":' '[' '"http://ggmtestingatapnicdotnet"' '],' '"replyUrls":' '[],' '"homepage":' '"http://ggmtestingatapnicdotnet"' '}'
+ app_id=2c18775b-56ab-4d67-9975-e854b46c0769
+ azure ad sp create --applicationId 2c18775b-56ab-4d67-9975-e854b46c0769
error:   {"odata.error":{"code":"Request_ResourceNotFound","message":{"lang":"en","value":"Resource 'ServicePrincipal_e70ec1f9-5e1e-426d-b3c4-caab61536b18' does not exist or one of its queried reference-property objects are not present."}}}
error:   Error information has been recorded to /root/.azure/azure.err
error:   ad sp create command failed

Makefile:53: recipe for target 'do' failed
make[1]: *** [do] Error 1
make[1]: Leaving directory '/opt/kubernetes-anywhere'
Makefile:41: recipe for target 'deploy-cluster' failed
make: *** [deploy-cluster] Error 2
[container]:/opt/kubernetes-anywhere>

Thank you. I'm trying to run this down internally. Please feel free to ping me if I don't get back by early next week.

It's not a great situation, but if you were to insert a sleep 60 in that script between the azure ad app create line and the azure ad sp create line, you'll likely make further progress.

ok. I've hit the weekend and I am trying to get a decent work-life balance,
so this will wait until next week now.
if the value(s) in question are pollable, perhaps the azure script could
re-write to do some simple while $(true test); do sleep 2;  test-the-value
if [ condition -eq 'ok' ] ... type logic with a sleep 2; or some other form
which in shell did a smaller cost busy-wait cycle around completion? 60
feels like the kind of arbitrary value which we both know is going to fail
for somebody, or enrage the people who live closer to the factory and
really only needed to wait 10
On 28 October 2016 at 16:14, Cole Mickens notifications@github.com wrote:

It's not a great situation, but if you were to insert a sleep 60 in that
script between the azure ad app create line and the azure ad sp create
line, you'll likely make further progress.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes-anywhere/issues/251#issuecomment-256844600,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHfeSEmVu1bGDnexdSoNwP_6IaKZ9j1dks5q4ZLhgaJpZM4KKtZG
.

Yeah, I've been asking about that as well...  the problem is: you might poll one server that is replicated, proceed, and then hit another server that hasn't actually replicated.
Unfortunately, global replication status isn't exposed so you can't query that and wait either.
I'll push on this and figure out how we're supposed to handle these sorts of things without just inserting large sleeps... I'm definitely not a fan of that solution.

(Thanks again for the patience)

I had the same issue, for me it solved by manual removal of application account in AAD.

authors: colemickens ggm-at-apnic uthark

repo: kubernetes/kubernetes-anywhere


text:
Issue with /docs/getting-started-guides/kubeadm/

Issue with /docs/getting-started-guides/kubeadm/
The yum repo to use files.rm-rf.ca does not seem to use gpg keys.
I would be nice to get a more legitimate sounding repo to get the packages, as well as a proper gpgkey.
maybe something like k8s.io

@sebgoa this is very old, let's close 👍

authors: errordeveloper sebgoa


text:
Fix broken link

Fix broken link

NOTE: Please check the “Allow edits from maintainers” box below to allow
reviewers fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.

This change is

@zhangxiaoyu-zidif I think we're having some problems w/ the Travis check right now, which is unrelated to your change, so I will merge this PR as soon as we fix that. Thx

@chenopis OK, =).

authors: chenopis zhangxiaoyu-zidif


text:
Capitalize replica set -> Replica Set for consistency.

Small change; changing the capitalization.

Thanks, @Kashomon !

authors: Kashomon johndmulhausen


text:
Use monospace for filesystem paths in Minikube setup guide

This is an enhancement request

What would you like to be added
I'd like https://kubernetes.io/docs/setup/learning-environment/minikube/#mounted-host-folders to use monospace (like this) text for the paths in the two rightmost columns in the table:

HostFolder
VM

Why is this needed
Improved styling. It's a minor thing that's nice to have.
Comments
/kind cleanup
/language en

If anyone would like to work on this, please feel free to open a pull request.

/remove-lifecycle rotten
/good-first-issue

Hey @sftim, I would like to work on this.

Anyone who'd like to open a PR that addresses this issue is welcome to. Dive in!

I am working on this, will submit a PR shortly. 🚀

authors: JubayerJoy imbhuvnesh sftim

repo: kubernetes/website


text:
Improvement for k8s.io/docs/tasks/tools/install-kubectl/

There are too many paths to keep track of on this page and following Mac install, non-homebrew, it doesn't work after the download and mv to /usr/local/bin.  I would suggest breaking out the pages by OS at a minimum.

/triage needs-information


text:
Issue with k8s.io/docs/tasks/administer-cluster/kubelet-config-file/

This is a Bug Report

Problem:
This page does not tell me, nor point me to any page that tells me, what are all the fields (name, type, default value) in the kubelet configuration file.
Proposed Solution:
Document this.
Page to Update:
k8s.io/docs/tasks/administer-cluster/kubelet-config-file/

In the text there IS a pointer to the source code. That is the best thing we can get so far.

The subset of the Kubelet’s configuration that can be configured via a file is defined by the KubeletConfiguration struct here (v1beta1).

/kind feature

/language en

related: #21109

/triage accepted
/priority backlog
/remove-lifecycle rotten
Might be relevant to issue #23889

/remove-lifecycle rotten

This is resolved.

authors: MikeSpreitzer sftim tengqm


text:
Issue with k8s.io/docs/tutorials/stateful-application/mysql-wordpress-persistent-volume/

This is a Bug Report

create mysql-deployment.yaml and wordpress-deployment.yaml fail, because pvc is in pending.
root@centos7-2 mysql-wordpress-pd]# kubectl apply -k ./
service/wordpress-mysql created
service/wordpress created
deployment.apps/wordpress-mysql created
deployment.apps/wordpress created
persistentvolumeclaim/mysql-pv-claim created
persistentvolumeclaim/wp-pv-claim created
[root@centos7-2 mysql-wordpress-pd]# kubectl get pvc
NAME             STATUS    VOLUME   CAPACITY   ACCESS MODES   STORAGECLASS   AGE
mysql-pv-claim   Pending                                                     22s
wp-pv-claim      Pending                                                     22s
[root@centos7-2 mysql-wordpress-pd]# kubectl get pods
NAME                               READY   STATUS    RESTARTS   AGE
wordpress-6857459697-4fkwx         0/1     Pending   0          26s
wordpress-mysql-5f4b68ff8f-tqndw   0/1     Pending   0          26s
[root@centos7-2 mysql-wordpress-pd]# kubectl describe pgc mysql-pv-claim
error: the server doesn't have a resource type "pgc"
[root@centos7-2 mysql-wordpress-pd]# kubectl describe pvc mysql-pv-claim
Name:          mysql-pv-claim
Namespace:     default
StorageClass:
Status:        Pending
Volume:
Labels:        app=wordpress
Annotations:   Finalizers:  [kubernetes.io/pvc-protection]
Capacity:
Access Modes:
VolumeMode:    Filesystem
Mounted By:    wordpress-mysql-5f4b68ff8f-tqndw
Events:
Type    Reason         Age               From                         Message

Normal  FailedBinding  4s (x5 over 60s)  persistentvolume-controller  no persistent volumes available for this claim and no storage class is set
Kubernetes version is v1.18.4
The k8s cluster is in a windows Server 2012R2 Host, where I created 4 centos7 virtual guests through hyper-v.
Why PVC always fail?

You will need to provision the PV volumes manually before running this example. The message is pretty clear on that: "no persistent volumes available for this claim and no storage class is set".

/triage support

/remove-lifecycle stale

/close

/close

authors: irvifa michael1589 tengqm


text:
Issue with k8s.io/zh-cn/docs/reference/command-line-tools-reference/kubelet/

Kubelet how to enable cAdvisor to collect network metric data for each container, instead of only pod pause containers

/transfer kubernetes


text:
Right side panel is not displaying properly

This is a Bug Report

Problem:
[Install and Set Up kubectl on Linux] page layout is collapsed.
Right side layout is displaced to down.
Proposed Solution:
Right side layout should be in place.
Page to Update:
https://kubernetes.io/docs/tasks/tools/install-kubectl-linux/#install-kubectl-binary-with-curl-on-linux

Additional Information:

/language en
/area web-development

@dipesh-rawat (or any maintainers) Can i get some hint and go ahead to work on this please?

It appears that the changes in https://github.com/kubernetes/website/pull/42913 have inadvertently resulted in the layout of page broken. Potentially addressing https://github.com/kubernetes/website/pull/42913#discussion_r1336990733 could solve it.

We should fix the layout of the page.
/triage accepted
/priority backlog

/retitle Page layout for "Install and Set Up kubectl on Linux" is broken

/remove-area web-development
This is more of a content fix.

authors: dipesh-rawat sftim steve-hardman tamilselvan1102


text:
Request for examples in documentation for Custom Resources

This is a...

[X] Feature Request
[ ] Bug Report

Problem:
The description of custom resources is very abstract. Someone from the K8S team pointed me towards CRDs as a possible way to describe nodes with custom hardware (eg "this node has a GPU, and that node has an FPGA accelerator"), but the description of CRs and controllers is so high-level that it's difficult for me to understand how to map the concepts well.
Proposed Solution:
Two or three examples of real-world uses of CRs would be appreciated. Ideally one or two of these would be a "typical" example showing how people are using the feature today, and one or two of them would be "extreme" examples showing how the feature could be stretched, as well as the benefits and drawbacks of stretching the feature in that way. Combined, these would give intermediate-level K8S users a reasonable mental model of how the feature should, as well as could, be used.
Page to Update:
https://k8s.io/docs/concepts/api-extension/custom-resources/

@adrianludwin 👋 There's a PR in progress to help with this: #6238. It's in review right now, hopefully it'll be published within the next week.

Great to hear, thanks.

authors: adrianludwin zacharysarah


text:
Hugo Migration - Kubeadm Reference Docs don't show up correctly

Kubeadm doesn't show up correctly in the left nav for Hugo.

Link: https://hugo-migration.docs.kubernetes.io/docs/reference/setup-tools/kubeadm/generated/kubeadm_alpha_phase/

The scripts that autogenerates docs into this site needs to be adjusted and re-generated. @zacharysarah has that on his TODO list. In this particular case they need front matter with a proper title. And probably also weight if specific order.

@Bradamant3 you are right, my mistake. I see it now.

I have added a temporary fix for this, but now my commit access is revoked, so I cannot push it.
This is, looking at it more closely, related to the missing adaptation of the generated docs.

kubeadm is a section
kubeadm/generated was not a section, hence it was put in the kudeadm section
all the files in kubeadm/generated missed a title, hence it looked odd in the menu (blanks)
I have added a _index.md file with toc_hide: true to the /generated folder, which makes it a section and hides it in the menu

But I cannot push this to the server because I have no push access.

This issue looks to be fixed per Bjorn's commit https://github.com/kubernetes/website/commit/c9fbb9c6d2ca4161c4a018959dc5da313ba844cf

authors: Bradamant3 bep jaredbhatti


text:
Update AKS mitigation link

Updated to include link to AKS documentation on mitigation.

Have updated with suggested changes

/lgtm

@kbarnard10 could you please take a look and state your approval.

/approve


text:
(doc-fix): Removing extra space in kubectl command

Signed-off-by: Raj mail.rajdas@gmail.com
removing extra space in some kubectl commands

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Remember to delete this note before submitting your pull request.
For pull requests on 1.18 Features: set Milestone to 1.18 and Base Branch to dev-1.18
For pull requests on Chinese localization, set Base Branch to release-1.16
Feel free to ask questions in #kubernetes-docs-zh
For pull requests on Korean Localization: set Base Branch to dev-1.16-ko.<latest team milestone>
If you need Help on editing and submitting pull requests, visit:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.
If you need Help on choosing which branch to use, visit:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

/assign @jaredbhatti

@rajdas98 if you can get the CLA signed, we can take a look; if you have any trouble signing that, and would like help, please reply with your questions.

/kind cleanup
/lgtm

Thanks @rajdas98!

Thanks. I applied for CLA.
Next time, I will sign the PR.

authors: php-coder rajdas98 sftim


text:
fix some translation errors

“安装脚本通常会启动同一个计算机上所有控制平面组件” should be translated by “设置脚本通常会在同一个计算机上启动所有控制平面组件”

@NeoTse Please sign the CLA in order for this to be reviewed.

I signed it

/lgtm
/approve

authors: NeoTse tengqm


text:
Remove deprecated scheduling plugin NodeResourceLimits from config.md

Scheduling plugin “NodeResourceLimits” has been deprecated and code has been reomove from kubernetes/kubernetes.
https://github.com/kubernetes/kubernetes/pull/91883

/hold
I'm trying to find the root removal of this in Kubernetes/kubernetes before merging.

Here is the issue: https://github.com/kubernetes/kubernetes/issues/91817
Deprecation PR: https://github.com/kubernetes/kubernetes/pull/91883
Docs (apparently was incomplete): https://github.com/kubernetes/website/pull/22089/

Thank you so much @ahg-g!
/hold cancel

/lgtm
/approve

/sig scheduling

authors: ahg-g celestehorgan houjun41544 sftim


text:
static pod not support configmap or secret

Add note that static pods do not support configmap or secret.
fix: #28611

This issue is about documentation that is sourced from the website repo.  For documentation that is in comments in the code, see https://github.com/kubernetes/kubernetes/issues/103167 .

@MikeSpreitzer Thanks for the clarification. I've updated the doc with your comments.

@kbhawkey @mikedanese Could you please review the PR? Thanks a lot!

@tengqm Thanks for the review. I've updated with your comments.

/approve

/lgtm

authors: MikeSpreitzer bart0sh chenxuc tengqm


text:
[en]Removed duplicated sectioncontainer on runtimes.md

There are two parts that repeat,fllow #36558
content/en /docs/setup/production-environment/container-runtimes.md

en:

/lgtm
Thanks for spotting it!

/approve

authors: jimangel mehabhalodiya yanrongshi


text:
[zh] updated distribute-credentials-secure.md

Add anchors
Other minor changes

content/zh-cn/docs/tasks/inject-data-application/distribute-credentials-secure.md

Preview: https://deploy-preview-37320--kubernetes-io-main-staging.netlify.app/zh-cn/docs/tasks/inject-data-application/distribute-credentials-secure/

Thanks.
/lgtm
/approve

authors: tengqm windsonsea


text:
Add pt-br/docs/reference/glossary/workload.md

This PR adds Portuguese translation to the glossary term workload.
Signed-off-by: Rodrigo V. Del Monte rvdelmonte@gmail.com

Hey @edsoncelio,
Thank you for your review!
The suggestions were applied!

/lgtm

Thanks!
/lgtm

/approve


text:
[ru] remove extra tags in KubeCon section

Description

Issue

Closes: #

/area web-development

It was me who put those extra
's. Now, I realise there's a problem due to this page being rendered differently in different browsers.
Here's an updated version as offered in this PR rendered in Chrome/Linux. Looks good:

But here's what will happen in Firefox/Linux (which I use by default). Doesn't look good:

I need to think about what can be done to avoid this in Firefox after we remove extra
's.

According to my current experiments, it has something to do with the fonts. If we use a smaller font (15px instead of 18px) or a bigger line-height (e.g. 1.8 instead of 1.5) in the Russian version, everything works fine. To conclude, it looks like different fonts are used or they are rendered differently (for the Russian version). Someone with good, relevant experience (CSS for Firefox) is needed to solve this.

According to my current experiments, it has something to do with the fonts. If we use a smaller font (15px instead of 18px) or a bigger line-height (e.g. 1.8 instead of 1.5) in the Russian version, everything works fine. To conclude, it looks like different fonts are used or they are rendered differently (for the Russian version). Someone with good, relevant experience (CSS for Firefox) is needed to solve this.

Good solution, but in my opinion I would redo this section as a whole.

in my opinion I would redo this section as a whole.

I would definitely support this! It started a while ago with fewer conferences/buttons in place. Later, it hasn't evolved well enough to handle current needs. It should be fixed in the original (English) version first then.

JFYI: #49167 should resolve the issue we've discussed here.

authors: Arhell dipesh-rawat shurup


text:
feature:  Improve the README Instructions for the Deployment of the KS Monitoring Tools

Feature Description
We need to improve the instructions to deploy the KS monitoring tools:
a) Use a consistent name of the status agent and match the terminology already used in our KS documentation;
b) Make it clear the  combination of NS, APIService, and Instance that works for a given target APIServer and KS controllers;
c) Clarify in the README what distinguish two WECs apart using the command below:
mspreitz@mjs13 kubestellar % kubectl --context cluster1 -n open-cluster-management-agent-addon get Endpoints
NAME                      ENDPOINTS         AGE
status-agent-controller   10.244.0.9:8080   31m

mspreitz@mjs13 kubestellar % kubectl --context cluster2 -n open-cluster-management-agent-addon get Endpoints
NAME                      ENDPOINTS         AGE
status-agent-controller   10.244.0.9:8080   33m

Proposed Solution
To improve the instructions and address the items listed above:
Want to contribute?

[ ] I would like to work on this issue.

Additional Context
No response

See also the other unresolved conversations in #2458

repo: kubestellar/kubestellar


text:
[Feature] ingress traits add tls support

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

add tls support
Describe alternatives you've considered

Additional context

dup with #3496

authors: daixijun wonderflow

repo: kubevela/kubevela


text:
Live migrations fail when VMI has cloud-init user data defined

/kind bug
What happened:
Migrating a VMI that defines cloud-init userdata fails. The failure appears to be occurring from within libvirt.
I believe this worked correctly when migrations were first introduced. I think this may be related to some of the libvirt changes that occurred recently. We recently updated the libvirt packages in our virt-launcher container from 4.2.0 to 4.10.0 which could be related.
How to reproduce it (as minimally and precisely as possible):
using this VMI
apiVersion: kubevirt.io/v1alpha2
kind: VirtualMachineInstance
metadata:
  creationTimestamp: null
  labels:
    special: vmi-ephemeral
  name: vmi-ephemeral
spec:
  domain:
    devices:
      disks:
      - disk:
          bus: virtio
        name: containerdisk
        volumeName: registryvolume
      - disk:
          bus: virtio
        name: cloudinitdisk
        volumeName: cloudinitvolume
    machine:
      type: ""
    resources:
      requests:
        memory: 64M
  terminationGracePeriodSeconds: 0
  volumes:
  - containerDisk:
      image: registry:5000/kubevirt/cirros-container-disk-demo:devel
    name: registryvolume
  - cloudInitNoCloud:
      userData: |
        #!/bin/sh

        echo 'printed from cloud-init userdata'
    name: cloudinitvolume

and then migrating with this migration job.
apiVersion: kubevirt.io/v1alpha2
kind: VirtualMachineInstanceMigration
metadata:
  creationTimestamp: null
  name: migration-job
spec:
  vmiName: vmi-ephemeral
status: {}

The migration job will fail and report a libvirt error.

/cc @vladikr @fabiand
I'll post more details about the specific error that libvirt returns soon. I just wanted to make people aware of the issue.

for reference, here's the libvirt error output.
{"component":"virt-launcher","level":"error","msg":"internal error: qemu unexpectedly closed the monitor: Receiving block device images","pos":"virNetClientProgramDispatchError:174","subcomponent":"libvirt","timestamp":"2018-12-20T18:18:55.642000Z"}
{"component":"virt-launcher","level":"info","msg":"Completed 0 %\rCompleted 2 %\rCompleted 4 %\rCompleted 6 %\rCompleted 9 %\rCompleted 11 %\rCompleted 13 %\rCompleted 15 %\rCompleted 18 %\rCompleted 20 %\rCompleted 22 %\rCompleted 24 %\rCompleted 27 %\rCompleted 29 %\rCompleted 31 %\rCompleted 33 %\rCompleted 36 %\rCompleted 38 %\rCompleted 40 %\rCompleted 42 %\rCompleted 45 %\rCompleted 47 %\rCompleted 49 %\rCompleted 51 %\rCompleted 54 %\rCompleted 56 %\rCompleted 58 %\rCompleted 60 %\rCompleted 63 %\rCompleted 65 %\rCompleted 67 %\rCompleted 69 %\rCompleted 72 %\rCompleted 74 %\rCompleted 76 %\rCompleted 78 %\rCompleted 81 %\rCompleted 83 %\rCompleted 85 %\rCompleted 87 %\rCompleted 90 %\rCompleted 92 %\rCompleted 94 %\rCompleted 96 %\r2018-12-20T18:18:55.435090Z qemu-system-x86_64: error while loading state section id 1(block)","subcomponent":"libvirt","timestamp":"2018-12-20T18:18:55.642703Z"}
{"component":"virt-launcher","level":"info","msg":"2018-12-20T18:18:55.435618Z qemu-system-x86_64: load of migration failed: Input/output error","subcomponent":"libvirt","timestamp":"2018-12-20T18:18:55.642776Z"}

repo: kubevirt/kubevirt


text:
Point to latest kubevirtci commit to fetch changes in the kind lane.

What this PR does / why we need it:
The sriov provider has a couple of changes, the most notable is that it now allows multiple nodes (instead of just one), to make it more similar to the sr-iov operator use case scenario (it is supposed to have at least one master and one worker).
This pr fetches the changes applied to the lane and makes the sr-iov tests run on two nodes.
Release note:

NONE

/lgtm
/approve

Let's see if we did not break the sr-iov lane :sweat_smile:

/lgtm

I've also sent https://github.com/kubevirt/kubevirt/pull/2752 few days ago.
I guess that you're basing on a newer version so should I drop my change?

I've also sent #2752 few days ago.
I guess that you're basing on a newer version so should I drop my change?

Think so, mine got merged this afternoon

ok, let's make sure this one is merged asap since I need the new kubevirtci version to verify my pr :)

ok, let's make sure this one is merged asap since I need the new kubevirtci version to verify my pr :)

Sure :+1:

/retest

@danielBelenky :tada:

authors: cynepco3hahue danielBelenky fedepaol


text:
remove [QUARANTINE] tag from test_id:4746

Signed-off-by: Barak Mordehai bmordeha@redhat.com

What this PR does / why we need it:
remove the [QUARANTINE] tag from test_id:4746
due to the test stabilization.
https://github.com/kubevirt/kubevirt/pull/6734
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

/ok-to-test
/lgtm

/cc @fgimenez

/retest

/cc @jean-edouard

/retest

/retest


text:
Fix smally typo

This fixes issue #612
github-issue#612
Backport of https://github.com/kubic-project/velum/pull/624#pullrequestreview-145154356
Signed-off-by: Flavio Castelli fcastelli@suse.com
(cherry picked from commit 0b93b79ee3099647027e5ba3c678ca1289c4c38b)

Given this is a 1 line typo - I don't think a bug is strictly necessary.. @jordimassaguerpla - correct me if I'm wrong :)

@kiall: Better have a bsc number, even if this is simple, so this is verified by QA.

@flavio : please could you add a reference to bsc#1107109 in the commit message?

@jordimassaguerpla I've updated the commit message to include the bsc number. Can you please approve the PR again?

There's a typo in the pull request title.

authors: bear454 flavio jordimassaguerpla kiall

repo: kubic-project/velum


text:
Output Nodes?

I am looking at the attached graph on TensorBoard. I assumed avod_nms was the output node, but it seems like the gather operations are regarded as nodes in the graph as well. Does this mean that the output nodes are these?
avod_nms/GatherV2
avod_nms/GatherV2_1
avod_nms/GatherV2_2
avod_nms/GatherV2_3
avod_nms/GatherV2_4
avod_nms/GatherV2_5

Thanks for your help. I'm trying to freeze the graph and looking for the correct output_nodes to do this with.

The tf.gather operation is used to gather output from several different nodes, using the indices returned by tf.image.non_max_suppression
https://github.com/kujason/avod/blob/b7dcf31e50230c67bcf19ed063549a8b1bc4a785/avod/core/models/avod_model.py#L504-L545

authors: kujason villanuevab

repo: kujason/avod

license: MIT


text:
[Bug]: When import ESModule from CommonJS, Error: Must use import to load ES Module

Version
29.2.4
Steps to reproduce

Clone my repo: https://github.com/sugoroku-y/ts-jest-test
Run the command: npm ci
Run the command: npm test
Succeeded because the version of ts-jest is 29.2.3.
Update ts-jest: npm update ts-jest
Run the command: npm test
Failed.

  ● ts-jest-test › import

    Must use import to load ES Module: E:\nodejs\ts-jest-test\esm\index.js

      1 | describe('ts-jest-test', () => {
      2 |     test('import', async () => {
    > 3 |         const { default: esm } = await import('./esm/index.js');
        |                                  ^
      4 |         expect(esm).not.toBeUndefined();
      5 |     });
      6 |     test('require', async () => {

      at Runtime.requireModule (node_modules/jest-runtime/build/index.js:850:21)
      at ts-jest-test.test.ts:3:34
      at async Object.<anonymous> (ts-jest-test.test.ts:3:34)

Expected behavior
I expect to be able to import as in ts-jest version 29.2.3.
Actual behavior
When trying to import an ESModule, Error occurs: Must use import to load ES Module: ...
Debug log
ts-jest.log
Additional context
No response
Environment
System:
  OS: Windows 10 Home 22H2
  CPU: i7-2600
Binaries:
  Node: v20.15.0
  npm: 10.7.0
npmPackages:
  jest: 29.7.0
  ts-node: 10.9.2
  typescript: 5.5.4

We reverted the support of Node16/NodeNext in 29.2.4 because it caused breaking changes for many users. The behavior now is similar to 29.2.1 that whenever user uses Node16/NodeNext for Jest ESM mode, we will automatically override it to ESNext.
In your repo, to make the test work correctly, you need to adjust your jest.config.ts to be like this
export default {
    extensionsToTreatAsEsm: ['.ts'],
    transform: {
        '\\.ts$': ['ts-jest', {
            useESM: true
        }],
    },
} satisfies Config;

This is because I'm seeing your test script attempts to run Jest in ESM mode, so the jest.config.ts should enable ts-jest to use ESM mode too (via useESM: true).
Perhaps we can deprecate useESM option and rely entirely on Jest to tell us when to use ESM and when to use CJS. That would be the enhancement.
The support for Node16/NodeNext will be in the next major release.

I just spent the morning building a demo repo showing the difficulty in configuring ts-jest to support Node16/NodeNext modules.  https://github.com/jmannau/ts-jest-node16
Without supporting Node16/NodeNext it appears to be impossible/very difficult to support projects that require support for mixing CommonJS & ESM dependencies.
Is there anything we can do to help restore support for Node16/NodeNext?

We actually reverted the support because it caused big impact on users.
One thing I can think of is, temporarily introducing an experimental flag which allows to use Node16/NodeNext and remove this flag in the next major release. What do you think?

I understand that it caused issues and I know reverting was the right move.
My feeling is that ts-jest should respect the "module" in tsconfig.json type and not override it.  If users need to have a different module format, then they can configure a tsconfig.jest.json to customise it.
Having said that, is it possible to add a flag, similar to "useESM" that will instruct ts-jest to preserve the target "module"?
ie:
"transform": {
    "^.+\\.ts$": [
        "ts-jest",
        {
            "preserveTsModule": true
        }
    ]
},

or perhaps if jest testEnvironment = node then just preserve the tsconfig.json module type?

Indeed the goal is not implicitly overriding module value. I would go for a new config option.

Just hijacking this but moduleResolution should not be set to ESNext, this is not a valid moduleResolution. At the moment we get an error Argument for '--moduleResolution' option must be: 'node', 'classic', 'node16', 'nodenext'

Just hijacking this but this._ts.ModuleResolutionKind.Node10 is not working and should be this._ts.ModuleResolutionKind.NodeJs instead. This is undefined in our typescript version (4.9.5) and only contains
export enum ModuleResolutionKind {
        Classic = 1,
        NodeJs = 2,
        Node16 = 3,
        NodeNext = 99
    }

Thanks for the comment.
I tried useESM and didn't see any change.
Then I ran the test with different versions from 29.0.0 to 29.2.4 and it failed only on 29.2.4 with or without useESM.
I did a quick debug run...
https://github.com/kulshekhar/ts-jest/blob/v29.2.4/src/legacy/compiler/ts-compiler.ts#L150-L157

const moduleResolution = this._ts.ModuleResolutionKind.Node10
if (!isEsm) {
  return {
    ...compilerOptions,
    module: this._ts.ModuleKind.CommonJS,
    moduleResolution,
  }
}

It seems that moduleResolution is set to Node10 because isESM here is false regardless of the value of the useESM setting.
And,
https://github.com/kulshekhar/ts-jest/blob/v29.2.4/src/legacy/compiler/ts-compiler.ts#L175-L176

const isEsmMode = this.configSet.useESM && options.supportsStaticESM
this._compilerOptions = this.fixupCompilerOptionsForModuleKind(this._initialCompilerOptions, isEsmMode)

It appears that isEsmMode is false because the above options.supportsStaticESM is false, which is specified for isESM.
As far as I can follow in the debug run, options.supportsStaticESM is the value passed from jest-runtime, and the default value of false is used without being affected by any configuration value.
I think there is a logic error somewhere, what do you think?

Idk exactly how jest-runtime sets the value for options.supportsStaticESM. I remember the value is only affected by the flag --experimental-vm-modules  for NodeJS. Anyways, it's more about workaround for your problem.
I believe with a support implementation for Node16/NodeNext, it would be more proper way to go forward.

If --experimental-vm-modules is not specified, the import function will give a syntax error Unexpected token 'export'.
So I always specify --experimental-vm-modules.
If options.supportsStaticESM is only affected by the --experimental-vm-modules, then options.supportsStaticESM is always set to false and moduleResolution is always set to Node10. The import function is always converted to a require function, and dynamic import of an ESModule always results in an error.
It is not always possible to change the build environment to the next major release, so hopefully this will be addressed in 29.x.x.
If changing the configuration file would allow the test to pass, that would be fine, but I can't find that setting.

or perhaps if jest testEnvironment = node then just preserve the tsconfig.json module type?

I gonna use the name useModernModuleFormat

https://github.com/jestjs/jest/blob/main/packages/jest-runtime/src/index.ts#L94-L100

const defaultTransformOptions: InternalModuleOptions = {
  isInternalModule: false,
  supportsDynamicImport: esmIsAvailable,
  supportsExportNamespaceFrom: false,
  supportsStaticESM: false,
  supportsTopLevelAwait: false,
};

The default value for options.supportsStaticESM appears to be the value written here.
It appears that the --experimental-vm-modules flag affects options.supportsDynamicImport, not options.supportsStaticESM.
As far as I can tell from searching under node_modules, the following appears to affect supportsStaticESM

true when importing an ESModule
Inherited from the caller in babel-jest
true when reading files with the extensions specified in extensionsToTreatAsEsm

If you can import ESModule, this Issue has already been resolved, so the first one is meaningless.
The second is irrelevant because we are not using Babel this time.
So, I set *.test.mts to be targeted by JEST by specifying testMatch etc., and specified .mts in extensionsToTreatAsEsm, and I saw that I can import with import function by setting useESM to true.
I would have been happy if this was a happy end, but I could not access the global variable jest in this way. I wanted to use a mock function in the test case, so this method was not available.

Referring to @jmannau 's ts-jest-node16, I separated only the import function into separate files as CommonJS JavaScript.
Object.defineProperty(exports, '__esModule', { value: true });

exports.default = function wrappedImport(packageName) {
    return import(packageName);
};

export default function wrappedImport<T>(packageName: string): Promise<T>;

Added the above js file and d.ts file, and
// @ts-ignore Whether it's CommonJS or ESModule doesn't affect it because it's an import as a type.
const {default: esm} = await wrappedImport<typeof import('./esm/index.js')>('./esm/index.js');

Rewriting the import function as above, the test now passes even with ts-jest 29.2.4.
I use @ts-ignore instead of @ts-expect-error because it is an error on VSCode but not through ts-jest.
If you pass eslint, you may need one more comment to suppress the warning.
I'll let this pass until Node16/NodeNext support is restored.
Thanks to @jmannau for the helpful comments.

authors: Kirdock ahnpnl jmannau sugoroku-y

repo: kulshekhar/ts-jest


text:
Fix generator to work custom style in pseudo css correctly

This is for https://github.com/kuma-ui/kuma-ui/issues/349.
Mapping of custom styles in pseudo-elements when generating styles was not correct.
I couldn't setting custom style in test code in src/system/generator.test.ts, so I added k.button element in the next.js example as a test.

fix #349

authors: poteboy tomoyuki-hiranuma

repo: kuma-ui/kuma-ui


text:
chore: removes charts being clickable

Removes the feature making charts link to related pages which people were generally surprised existed in the first place and doesn't seem to serve much purpose.
Signed-off-by: Philipp Rudloff philipp.rudloff@konghq.com
Note: This removes one of the last uses of store.state.selectedMesh. The last one will be removed in a follow up in which I’m dropping the sidebar store module (its main purpose no longer exists and we only use a bit of its state).

Was it intentional to remove the clicks from the charts here also? They shouldn't require the selectedMesh right?

authors: johncowen kleinfreund

repo: kumahq/kuma-gui


text:
Kuma Updates

Updates the docs based on the jira tickets. For the most part that is:

Add redirect
Add information where necessary
Change the title where necessary
Replace Kuma with {{ site.mesh_product_name }}

Closing this PR (but keeping the branch) until we start working on the Kuma 2.1 IA rework.

authors: Guaris cloudjumpercat

repo: kumahq/kuma-website


text:
multi-second response times

Hi,
we noticed that libvirt_exporter will need more than 20 seconds for some requests.
When getting some of the stats via virsh directly I noticed some requests taking more time as well, so we decided to reduce our scrape rate because if this, worrying about the impact on libvirtd (unknown to me)
This is probably normal, just wanted to know if you experience the same?
http_request_duration_microseconds{job="libvirt_exporter",quantile="0.9"}

rate(http_requests_total{job="libvirt_exporter"}[5m])

Hi Steffen,
It looks like our libvirt setups respond a lot faster than yours:

If this really remains a problem for you, we could consider scraping all domains in parallel, but that would only help if the scraping is not CPU bound on libvirtd's side. If libvirtd is already using 100% CPU while scraping, parallelising would only make it worse.
Could you take a look at libvirtd's CPU usage while scraping?

Hi Ed,
it does not seem to be a real problem for now, but I will definitely dig further when there is some more time for it.
Thanks for sharing your data on this, good to know that your responses come in faster.

authors: EdSchouten stefreak


text:
Webpack can't compile when I import "gradient"

I have an issue when I'm trying to import this library.
I'm using webpack, and it doesn't compile the JS file and throws an error at the line:
import gradient from 'chartjs-plugin-gradient';
Here is the error message:

"./node_modules/chartjs-plugin-gradient/dist/chartjs-plugin-gradient.esm.js" contains a reference to the file "chart.js/helpers".
This file can not be found, please check it for typos or update it if the file got moved.

If I try something like:
import helpers from 'chart.js/helpers'; I have no error, so the helpers are found... But I keep having the issue at the line where I import gradient...
Any idea?

Sorry, can not figure out what could be wrong from the information given

I encountered the same issue

Trying to use that plugin from TypeScript and I get a similar issue.

Probably has something to do with bundler and module vs commonjs. Webpack 4?

I'm not sure I'm rather a noob in Node.js.
Looks like I'm running webpack 5.75.0.

Here are the actual error logs:
ERROR in ./node_modules/chartjs-plugin-gradient/dist/chartjs-plugin-gradient.esm.js 7:0-60
Module not found: Error: Can't resolve 'chart.js/helpers' in '.\node_modules\chartjs-plugin-gradient\dist'
Did you mean 'helpers.mjs'?
BREAKING CHANGE: The request 'chart.js/helpers' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '*.mjs' file, or a '*.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.

@Slion I'm assuming you are using chart.js 4.2.1, right?
Would you be able to create (a very simple) reproduction of the issue?

I'm assuming you are using chart.js 4.2.1, right?

Using chart.js v3.9.1. I could upgrade though I guess.
Gradient plugin seems to work fine once you manage to load it.

Would you be able to create (a very simple) reproduction of the issue?

I'm sure I would not sure I will find the time though.

I thought I found a proper workaround but somehow that's still not working:
https://stackoverflow.com/questions/70964723/webpack-5-in-ceate-react-app-cant-resolve-not-fully-specified-routes

@Slion did you figure out any solution here?

I think I just had my own copy of the plugin that fixed the import path specifying the extension. It's all fairly well explained in the error logs posted above. Ultimately though we stopped using that plugin cause our gradient design specs needed some more fancy stuff. It is a really good plugin though and helped me understand gradients in chart.js.

authors: Mudit18 Slion kurkle sofiia-chorna vgross

repo: kurkle/chartjs-plugin-gradient


text:
open file is responseless

XdebugTraceViewer 0.1.3
Electron 5.0.9
win32 10.0.15063
Locale: zh-CN

maybe the file is too large, please send the file to me, i will test it.

@arron9 Can you try again with the latest master? I had also run into issues with opening trace files and saw some javascript errors that have been (at least partially) fixed by https://github.com/kuun/xdebug-trace-viewer/pull/9#event-3810835858

Same issue for me. My file is around 3GB. and it just doesnt do anythign when I open it.

@abdrmdn Maybe you file is too large, the app needs read the total content then processes it, it may eat large memory. please try t o change xdebug config to reduce the trace file size.

authors: abdrmdn arron9 berliner kuun

repo: kuun/xdebug-trace-viewer


text:
[doc] Wrong example for DeviceMappingsManager.registerMeasure()

For me the following code doesn't work:
https://github.com/kuzzleio/kuzzle-device-manager/blob/5812b9f1e6feb4e4d4f993991a30fa4282217ec0/doc/1/classes/devices-custom-properties/register-measure/index.md?plain=1#L38-L61
I needed to do something similar to this:
 deviceManagerPlugin.devices.registerMeasure(
   'temperature',
   {
     fahrenheit: { type: 'float' },
     celsius: { type: 'float' }
   });

In addition to the different hierarchical position of the properties (no properties) the third argument doesn't exist on the method (any more):
https://github.com/kuzzleio/kuzzle-device-manager/blob/5812b9f1e6feb4e4d4f993991a30fa4282217ec0/lib/core-classes/DeviceMappingsManager.ts#L56

Also this document seems to have the same mistake:
https://github.com/kuzzleio/kuzzle-device-manager/blob/c81198fd2b44d9db3b2a19fafd6681e1e2efdd8b/doc/1/guides/mappings/index.md?plain=1#L198-L209

Hello @UncleSamSwiss
Thanks for pointing this mistake. We are currently working on the plugin v2 which will improve this part

authors: Aschen UncleSamSwiss

repo: kuzzleio/kuzzle-device-manager


text:
Won't compile

Are you trying to code on Source Code (Haxe) or on the Downloaded Build (Lua)?
Source Code
Show an screenshot/video of your problem.
All I get are these errors, not sure if I installed stuff correctly

I have the same problem

same with TitleState.hx

use haxe 4.1.1 or 4.2.5 or like recommended versions from the compiling wiki i guess

repo: kviks/Psych-Engine-Android


text:
erubis - Cross-site Scripting (XSS) - Fix:

https://github.com/adunkey fixed the vulnerability associated with XSS.
This fix is being submitted on behalf of adunkey - they have been awarded $25 for fixing the vulnerability through the huntr bug bounty program.
Think you could fix a vulnerability like this - get involved (https://huntr.dev).
Q | A
Version Affected | ALL
Bug Fix | YES
Further References | https://github.com/418sec/erubis/pull/5

@kwatch - any updates on this?

Why hasn't this been merged ? @kwatch
Do you need maintainers ?

authors: JamieSlome dragma

repo: kwatch/erubis

license: mit


text:
Open to adding GitHub topics?

Firstly, this is EXACTLY what I was looking for. A mini router for cloudlfare workers! Thanks a lot for releasing this. 🧡 🧡 🧡
Would you be up for adding a few topics to the GitHub repo? That might make it easier for folks to find this code. I only found it via a link from another repo.

I think there's an auto complete when you edit the repo settings. I'm not sure what's in there. I'd guess topics like router, cloudflare workers, stuff like that?

Great suggestion!  A bunch of topics added, but feel free to suggest others!

authors: chmac kwhitley

repo: kwhitley/itty-router


text:
refactor code for expressions

Many aspects of Stata code take arbitrary expressions. Create a type in the repository for expressions that aligns with Stata's syntax for it.

Note that di varname[round(2*2)] is valid code.

repo: kylebarron/language-stata


text:
Carthage support

I'm just wondering if this project is open to putting official support for Carthage. Perviously it was possible to get Mockingjay (sort of) working with Carthage just by adding both Mockingjay and URITemplate to the Cartfile.
But moving to Swift 3 support and this no longer works.
One of the reasons is that URITemplate has now removed the Xcode project file for the repo which Carthage relies on to build the framework. This means that if we are going to add Carthage support for this, we will probably need to restore the project file in the URITemplate repo.
The other issue is that, as I mentioned above, the previous method only sort of worked. I'm not 100% sure on this, but because this repo includes URITemplate as a submodule, when Carthage checkouts/clones this repo as a dependency, it also checkouts the URITemplate submodule. So I think that when the project is built, it is using the commit/version of URITemplate that the submodule points to. Then when used in our test target, it uses a different version of URITemplate framework which is built using the commit/version that is resolved by Carthage (which might no necessarily be the same as the one that is pointed to by the URITemplate submodule in this repo).
TBH, I'm not necessarily sure what the best way is to resolve the issue above. A solution might involve changing the location of the URITemplate project to the Carthage/Checkout/URITemplate path, and using Carthage to checkout the dependencies before building the project in Xcode.
Thoughts?

updates about this?

I do not intend to add this, if you're looking for similar functionality OHHTTPStubs provides almost an identical API and supports Carthage.

authors: callo90 ehuynh kylef

repo: kylef-archive/Mockingjay


text:
Add region to skr tests

Description
Changes proposed in this pull request:

Add region parameter to provisioning calls for non trial plans
Remove not used subAccountRegion from provisioning url request

Related issue(s)

See also https://github.com/kyma-project/control-plane/issues/3006

/test pre-kyma-environment-broker-presubmit-scanner

/test pre-kyma-environment-broker

/hold

/unhold

/test pre-kyma-environment-broker

repo: kyma-project/kyma-environment-broker


text:
Change kyma-environments-cleanup-job image registry

Description
The image is in a new registry and the old one is not updated
Changes proposed in this pull request:
Related issue(s)

/test pre-kyma-environment-broker

/test pre-kyma-environment-broker

/test pre-kyma-environment-broker