text:
HDFS-14755. [Dynamometer] Hadoop-2 DataNode fail to start

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
154
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1614
trunk passed

+1
compile
29
trunk passed

+1
checkstyle
26
trunk passed

+1
mvnsite
31
trunk passed

+1
shadedclient
925
branch has no errors when building and testing our client artifacts.

+1
javadoc
30
trunk passed

0
spotbugs
64
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
60
trunk passed

_ Patch Compile Tests _

+1
mvninstall
31
the patch passed

+1
compile
19
the patch passed

+1
javac
19
the patch passed

+1
checkstyle
14
the patch passed

+1
mvnsite
25
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
970
patch has no errors when building and testing our client artifacts.

+1
javadoc
25
the patch passed

+1
findbugs
49
the patch passed

_ Other Tests _

+1
unit
482
hadoop-dynamometer-infra in the patch passed.

+1
asflicense
43
The patch does not generate ASF License warnings.

4674

Subsystem
Report/Notes

Docker
Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1320/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1320

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 7f6de639b055 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 6244502

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1320/1/testReport/

Max. process+thread count
927 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra U: hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1320/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@tasanuma, thanks for submitting this! I don't think this will work if you have multiple storage locations configured, which is a common pattern. Is there anything we can do which will both support multiple storage locations, but also be backwards-compatible?

@xkrogen  Thanks for your review!
In fact, I tested multiple storage locations and seems it works fine.

Can you explain why it works? This is the code MiniDFSCluster uses to parse it (within GenericTestUtils):
  public static File getTestDir() {
    String prop = System.getProperty(SYSPROP_TEST_DATA_DIR, DEFAULT_TEST_DATA_DIR);
    if (prop.isEmpty()) {
      // corner case: property is there but empty
      prop = DEFAULT_TEST_DATA_DIR;
    }
    File dir = new File(prop).getAbsoluteFile();

(SYSPROP_TEST_DATA_DIR is the same as PROP_TEST_BUILD_DATA)
I would expect new File(prop) to complain if you give it a comma-separated list of directories.

Thanks for your explanation, @xkrogen.
I see. I'm not sure why my job worked, but it should be one directory there. So if we have multiple storage locations, we should use the first of them here, right?
Updated the PR. It handles that case while keeping the compatibility between hadoop-2 and hadoop-3.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
144
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1542
trunk passed

+1
compile
26
trunk passed

+1
checkstyle
26
trunk passed

+1
mvnsite
28
trunk passed

+1
shadedclient
904
branch has no errors when building and testing our client artifacts.

+1
javadoc
29
trunk passed

0
spotbugs
56
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
50
trunk passed

_ Patch Compile Tests _

+1
mvninstall
31
the patch passed

+1
compile
22
the patch passed

+1
javac
22
the patch passed

+1
checkstyle
15
the patch passed

+1
mvnsite
26
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
977
patch has no errors when building and testing our client artifacts.

+1
javadoc
21
the patch passed

+1
findbugs
62
the patch passed

_ Other Tests _

+1
unit
489
hadoop-dynamometer-infra in the patch passed.

+1
asflicense
47
The patch does not generate ASF License warnings.

4574

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1320/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1320

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux b3eae61d6407 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 5e156b9

Default Java
1.8.0_222

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1320/2/testReport/

Max. process+thread count
925 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra U: hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1320/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
102
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1473
trunk passed

+1
compile
28
trunk passed

+1
checkstyle
25
trunk passed

+1
mvnsite
31
trunk passed

+1
shadedclient
881
branch has no errors when building and testing our client artifacts.

+1
javadoc
27
trunk passed

0
spotbugs
52
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
47
trunk passed

_ Patch Compile Tests _

+1
mvninstall
32
the patch passed

+1
compile
20
the patch passed

+1
javac
20
the patch passed

+1
checkstyle
17
the patch passed

+1
mvnsite
24
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
946
patch has no errors when building and testing our client artifacts.

+1
javadoc
21
the patch passed

+1
findbugs
50
the patch passed

_ Other Tests _

+1
unit
502
hadoop-dynamometer-infra in the patch passed.

+1
asflicense
38
The patch does not generate ASF License warnings.

4401

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1320/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1320

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux eea15bb01f2a 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ee7c261

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1320/3/testReport/

Max. process+thread count
927 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra U: hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1320/3/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

I see. The problem is just that getUri() is private in branch-2, so we can still leverage the functionality of DataNode.getStorageLocations, we just can't directly convert it to a URI. This will fail in some scenarios, e.g. a PROVIDED storage type, but I think this is fine. +1 from me.

Thanks!

authors: hadoop-yetus tasanuma xkrogen

repo: apache/hadoop


text:
HBASE-24713 backport to branch-2

@ramkrish86

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
13m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 21s
branch-2 passed

+1 :green_heart:
checkstyle
1m 21s
branch-2 passed

+1 :green_heart:
spotbugs
2m 32s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 14s
the patch passed

+1 :green_heart:
checkstyle
1m 19s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
14m 55s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

53m 57s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2201/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2201

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 2cee9213fd99 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 8979202c7a

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2201/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

please make sure commit messages start their subject with the jira key

source: gharchive/pull-request

authors: Apache-HBase busbey gkanade

repo: apache/hbase

license_type: permissive

license_source: github-api


text:
HBASE-23333 Provide call context around timeouts and other failure scenarios

Initial commit simply include the output of Call#toString where before we only have call.id. Looking to see if there's a sensible way to include a call stack that tracks up into the application code. Will be back.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 25s
master passed

+1 :green_heart:
compile
0m 26s
master passed

+1 :green_heart:
checkstyle
0m 32s
master passed

+1 :green_heart:
shadedjars
4m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 25s
master passed

+0 :ok:
spotbugs
1m  7s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  6s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 50s
the patch passed

+1 :green_heart:
compile
0m 25s
the patch passed

+1 :green_heart:
javac
0m 25s
the patch passed

+1 :green_heart:
checkstyle
0m 32s
hbase-client: The patch generated 0 new + 7 unchanged - 3 fixed = 7 total (was 10)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 33s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 45s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 23s
the patch passed

+1 :green_heart:
findbugs
1m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 53s
hbase-client in the patch passed.

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

49m  8s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-872/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/872

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 435e5cb8da54 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-872/out/precommit/personality/provided.sh

git revision
master / ee730c8c79

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-872/1/testReport/

Max. process+thread count
294 (vs. ulimit of 10000)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-872/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

I found more-or-less what I was looking for over on HBASE-22316. Somehow the piece of stack trace i found in my logs was omitted. Settling for this for now.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 55s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 46s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 15s
master passed

+1 :green_heart:
compile
0m 49s
master passed

+1 :green_heart:
checkstyle
0m 59s
master passed

+1 :green_heart:
shadedjars
4m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
master passed

+0 :ok:
spotbugs
1m  4s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 49s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 56s
the patch passed

+1 :green_heart:
compile
0m 48s
the patch passed

+1 :green_heart:
javac
0m 48s
the patch passed

+1 :green_heart:
checkstyle
0m 26s
The patch passed checkstyle in hbase-common

+1 :green_heart:
checkstyle
0m 31s
hbase-client: The patch generated 0 new + 7 unchanged - 3 fixed = 7 total (was 10)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 35s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 38s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 45s
the patch passed

+1 :green_heart:
findbugs
2m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
3m 15s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 55s
hbase-client in the patch passed.

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

59m 42s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-872/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/872

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux aa33225b15ec 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-872/out/precommit/personality/provided.sh

git revision
master / 5e34a59d90

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-872/2/testReport/

Max. process+thread count
292 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-872/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Maybe this is too verbose?
org.apache.hadoop.hbase.client.RetriesExhaustedException: Failed after attempts=11, exceptions:
Thu Dec 05 23:11:14 UTC 2019, null, java.net.SocketTimeoutException: callTimeout=60000, callDuration=60160: Call to redacted:16020 failed on local exception: org.apache.hadoop.hbase.ipc.CallTimeoutException: Call[id=4,methodName=Scan,param=region { type: REGION_NAME value: "hbase:meta,,1" } scan { column { family: "info" } start_row: “my_table,,” stop_row: “my_table ,," time_range { from: 0 to: 9223372036854775807 } max_versions: 1 cache_blocks: true max_result_size: 2097152 caching: 100 include_stop_row: false readType: PREAD } number_of_rows: 100 close_scanner: false client_handles_partials: true client_handles_heartbeats: true track_scan_metrics: false limit_of_rows: 2147483647], waitTime=60021, rpcTimeout=59999 row ‘my_table,,’ on table 'hbase:meta' at region=hbase:meta,,1.1588230740, hostname=redacted,16020,1575517640564, seqNum=-1

Rebased onto master and reduced the verbosity to just call.id and call.methodName. It would be nice to selectively include parameters, such as all non-default values. Could update the log sites to log less when the redundant values are already in the params...
What do you folks think?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 16s
master passed

+1 :green_heart:
compile
0m 50s
master passed

+1 :green_heart:
checkstyle
1m  0s
master passed

+1 :green_heart:
shadedjars
4m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
master passed

+0 :ok:
spotbugs
1m  7s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 53s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 56s
the patch passed

+1 :green_heart:
compile
0m 50s
the patch passed

+1 :green_heart:
javac
0m 50s
the patch passed

+1 :green_heart:
checkstyle
0m 25s
The patch passed checkstyle in hbase-common

+1 :green_heart:
checkstyle
0m 31s
hbase-client: The patch generated 0 new + 7 unchanged - 3 fixed = 7 total (was 10)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 49s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 44s
the patch passed

+1 :green_heart:
findbugs
2m  9s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
3m  9s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 52s
hbase-client in the patch passed.

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

57m 51s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-872/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/872

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 5620002d1c93 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-872/out/precommit/personality/provided.sh

git revision
master / 6d251efa04

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-872/3/testReport/

Max. process+thread count
292 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-872/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Still have objections @Apache9 ?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 21s
master passed

+1 :green_heart:
compile
0m 49s
master passed

+1 :green_heart:
checkstyle
0m 58s
master passed

+1 :green_heart:
shadedjars
4m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
master passed

+0 :ok:
spotbugs
1m  5s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 50s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 54s
the patch passed

+1 :green_heart:
compile
0m 49s
the patch passed

+1 :green_heart:
javac
0m 49s
the patch passed

+1 :green_heart:
checkstyle
0m 26s
The patch passed checkstyle in hbase-common

+1 :green_heart:
checkstyle
0m 31s
hbase-client: The patch generated 0 new + 7 unchanged - 3 fixed = 7 total (was 10)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 31s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 38s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 44s
the patch passed

+1 :green_heart:
findbugs
2m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
3m 15s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 58s
hbase-client in the patch passed.

+1 :green_heart:
asflicense
0m 24s
The patch does not generate ASF License warnings.

58m  7s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-872/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/872

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 79f2b61f1698 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-872/out/precommit/personality/provided.sh

git revision
master / 85ecdd10a9

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-872/4/testReport/

Max. process+thread count
286 (vs. ulimit of 10000)

modules
C: hbase-common hbase-client U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-872/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

authors: Apache-HBase ndimiduk


text:
CVE vulnerability for jackson-databind 2.9.6

PR is not associated with a ticket. Apache Ignite issues are managed under Apache JIRA: https://issues.apache.org/jira/projects/IGNITE/
Please see how to associate ticket and PR in:
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-Creation
Closing PR (which seems to be test-only) due to inactivity.
Feel free to reopen this PR if it is actual.

authors: antkr dspavlov

repo: apache/ignite


text:
Updated ExportQ and CFM to use new ObserverProvider API

This depends on apache/incubator-fluo-recipes#128

I am going to resubmit this PR with the CollisionFreeMap deprecated and renamed to CombineQueue.  The CombineQueue will only support the new Observer API.

repo: apache/incubator-fluo-recipes


text:
HAWQ-1061. Fix data loss when file locations include directories, check policy and bucketnum in all mode.

cc @ictmalili @wcl14

also cc @zhangh43  @linwen

LGTM. +1

Merged into master, thanks.

authors: ictmalili xunzhang

repo: apache/incubator-hawq


text:
Backport #209

Verified that it is pulling the correct branches
Working with ref: refs/heads/releases/9.0
Working with a branch: releases/9.0
Triggered by change in APPS

repo: apache/incubator-nuttx-apps


text:
[MRESOLVER-184] Destroy Redisson semaphores if not used anymore

IMO -1 for this PR (but +1 for removal of semaphores, but let's do it differently), let me explain:
a) you do same thing as lock factory (map of locks by name), repeating
b) lets add new method (ie. destroy()) on NamedLockSupport that is by default noop, and is overridden by those (redis, hz) that needs to do something when lock destroyed by factory (as ref count goes to 0).
This way, all this PR becomes just a change in createLock method, where you override destroy method of created NamedLockSupport. WDYT?

Alternate PR https://github.com/apache/maven-resolver/pull/110

Superseded by #111.

authors: cstamas michael-o

repo: apache/maven-resolver


text:
NIFI-2815: Fixed InvokeScriptedProcessor to allow changes to script engine type

+1

+1 merging into master

repo: apache/nifi


text:
Add support for Swift 5.4.2

@swift-ci test

repo: apple/swift-docker


text:
[WIP] Update README.md

@swift-ci test tensorflow

repo: apple/swift


text:
RangeInfo: Report RValue type if a decl reference is of read-only LValue type.

@swift-ci please smoke test

@swift-ci please smoke test


text:
Add Goodreads QOTD and Hitokoto API

已进入强迫症阶段，说明差不多好了 :-)

Looks good!

Thanks very much, you taught me so much! @apsun

@Yubyf How would you like to be credited? Is a link to your GitHub profile fine?

Yes, it's OK. And thx again.

authors: Yubyf apsun

repo: apsun/QuoteLock

license: mit

license_source: bigquery


text:
Add relay term startup error to README

@mray190 Ready for re-review

@mray190 Do we know why 1 check is still expected?

@mray190 Can you re-approve please? Accidentally had the base branch set to master

repo: armPelionEdge/snap-pelion-edge


text:
Fix: es_destroy is broken.

Is it worth keeping the helper?

Coverage increased (+1.04%) to 91.954% when pulling fe92234f724401f44b3fd9ba32631010e5409dab on dblock:es-destroy into 2e40a629646b8b04e376ace3f171077f2c26ddcb on artsy:master.

Coverage increased (+1.04%) to 91.954% when pulling fe92234f724401f44b3fd9ba32631010e5409dab on dblock:es-destroy into 2e40a629646b8b04e376ace3f171077f2c26ddcb on artsy:master.

we use the helper in our gravity callback:
self.class.sidekiq_delay(queue: 'low').es_delete_document(id)

Makes sense, I put it back.

Coverage increased (+1.1%) to 92.045% when pulling ac2ec0c038a1061c66389b67801734def795f9b2 on dblock:es-destroy into 2e40a629646b8b04e376ace3f171077f2c26ddcb on artsy:master.

great spot with this bug. 💥 💥 💥

authors: cavvia coveralls dblock

repo: artsy/estella

license: MIT


text:
@mzikherman => Run danger and CI on Travis

          1 Warning

:warning:
Please include a PR summary

  Generated by :no_entry_sign: Danger

Thanks for this PR! It helped me integrate it on a non-ruby project when the documentation didn't work for me :)

authors: ArtsyOpenSource Sloy mzikherman

repo: artsy/force


text:
Prepare rc16 release

I think codefactor warnings should be no reason to fail a pr.

Codecov Report

Merging #1741 into master will decrease coverage by 0.38%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1741      +/-   ##
============================================
- Coverage     79.82%   79.44%   -0.39%
- Complexity     1934     1942       +8
============================================
  Files           324      332       +8
  Lines          5467     5531      +64
  Branches       1006     1009       +3
============================================
+ Hits           4364     4394      +30
- Misses          581      613      +32
- Partials        522      524       +2

Impacted Files
Coverage Δ
Complexity Δ

...urbosch/detekt/sample/extensions/SampleProvider.kt
0% <0%> (ø)
0% <0%> (?)

...le/extensions/processors/QualifiedNameProcessor.kt
92.3% <0%> (ø)
2% <0%> (?)

.../extensions/reports/QualifiedNamesConsoleReport.kt
0% <0%> (ø)
0% <0%> (?)

...ekt/sample/extensions/rules/TooManyFunctionsTwo.kt
0% <0%> (ø)
0% <0%> (?)

...e/extensions/reports/QualifiedNamesOutputReport.kt
0% <0%> (ø)
0% <0%> (?)

...rbosch/detekt/sample/extensions/reports/Reports.kt
0% <0%> (ø)
0% <0%> (?)

...le/extensions/processors/NumberOfLoopsProcessor.kt
100% <0%> (ø)
2% <0%> (?)

...detekt/sample/extensions/rules/TooManyFunctions.kt
90% <0%> (ø)
4% <0%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5948565...306faf3. Read the comment docs.

authors: arturbosch codecov-io schalkms

repo: arturbosch/detekt


text:
How can you not thank .NET?

It was midnight I was doing that 🦆

repo: asc-community/AngouriMathLab


text:
Mondo master: ServerTests StaticFiles and Session

Can you also update the Directory.Build.props files to use the right url? This impacts sourcelink and symbols generation, so we should fix this when merging to new repos. We can go back and fix this later in release/2.1 and 2.2 which isn't impacted by this yet.
-    <RepositoryUrl>https://github.com/aspnet/AADIntegration</RepositoryUrl>
+    <RepositoryUrl>https://github.com/aspnet/AspNetCore</RepositoryUrl>

Are you running the tests? We're expecting issues with ServerTests similar to https://github.com/aspnet/AspNetCore-Internal/issues/1320#issuecomment-440336006

@natemcmaster: updated.
@Tratcher: We're letting the PR checks check for breaks for us, but if we know this is going to happen is someone working on a fix already?

They're still designing a fix.

Also, let's resolved this first: https://github.com/aspnet/AspNetCore-Internal/issues/1411

:up::date:

authors: Tratcher natemcmaster ryanbrandenburg

repo: aspnet/AspNetCore


text:
Finished About page and started Sponsorships page

Merge to master


text:
fix(input-info): add missing error classes

Thanks @MaximBalaganskiy

authors: MaximBalaganskiy bigopon

repo: aurelia/ux


text:
Initial draft

Send to wordy.com after that.

Change date and good to go my friend :).

authors: mgonto sandrinodimattia


text:
chore/release: prepare 0.3.0 release

@homu r+

:pushpin: Commit 6c84d33 has been approved by hobofan

:zap: Test exempted - status

authors: hobofan homu

repo: autumnai/collenchyma-nn


text:
Cygwinへの対応

第2世代以降のCygwin対応には、Cygwin環境がもつlibcのヘッダファイルを読み込む必要があり現実的ではないので、暫定的に第1世代のみの対応とする。

source: gharchive/issue


text:
chore(ESLint): まとめ項目を常体に統一

@stak ありがとうございます。

authors: azu stak

repo: azu/JavaScript-Plugin-Architecture


text:
Changed .smalltalk.ston

Pull Request Test Coverage Report for Build 40

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+8.7%) to 93.37%

Totals

Change from base Build 35:
8.7%

Covered Lines:
9323

Relevant Lines:
9985

💛  - Coveralls

authors: coveralls fortizpenaloza

repo: ba-st/Aconcagua


text:
posts

Funny

repo: barryclark/jekyll-now


text:
Initial changes for riak_control.

+1 merge - agree the certs should probably be auto-generated, we can file it as an additional task to convert.  It doesn't need to hold up the merge.

authors: jonmeredith massung

repo: basho/riak


text:
Create 2017-09-26-release-cadence.md

Do not review yet

Merge?

Let's merge after release policy and roadmap are published.

Oh I see you have merged; pressing the button now.

And everything is pushed now :)

authors: damienmg dslomov

repo: bazelbuild/bazel-blog


text:
[Fix #1773] Fix typo ('strptime' to 'strftime')

:+1:

authors: bbatsov palkan

repo: bbatsov/rubocop


text:
translate 2015-Google-IO New Android Tools.

@reondz 基本没啥问题，翻译得很好哈，去掉原文之后我这边直接合并。谢啦 :)

@bboyfeiyu 也是自己的学习过程＝w＝。那就麻烦你啦。

@reondz  去掉原文我就合并啦

authors: bboyfeiyu reondz

repo: bboyfeiyu/android-tech-frontier


text:
Ampersand in project folder fails

@elliottkember: Certain characters in a URL such as &,!,: are encoded so that the browser knows how to render them. Due to this Anvil will render & as %26 when passing it to the URL. Since Anvil uses pow to handle symlink/DNS. Pow does not render the %26 (&) back into the ASCII character. So I believe this is a pow issue and not a Anvil issue.
Anvil shows url's with & fine in its program. And does send those URL's correctly to the browser.

authors: elliottkember pbrocker

repo: beachio/anvilformac


text:
After allowing creation of Dat archive, focus should return to page

Added to TODOs, thanks for reporting

Done!

Thank you, Paul!

Sure thing!
On Wed, Sep 5, 2018 at 10:13 AM Aaron Shafovaloff notifications@github.com
wrote:

Thank you, Paul!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/beakerbrowser/beaker/issues/1128#issuecomment-418768112,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABNhU8eURr3zEL78BlfqB-aoXYaHk2B-ks5uX-oRgaJpZM4WIG6u
.

authors: aaronshaf pfrazee

repo: beakerbrowser/beaker


text:
Develop -> Master

:tada: This PR is included in version 1.17.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: beeman/kikstart-ui


text:
Update uglify-js version

+1

https://github.com/bem/borschik/pull/113

authors: DimitryDushkin doochik tadatuta

repo: bem/borschik


text:
change description and name

Спасибо большое!

authors: makishvili pahaz

repo: bevis-ui/bevis-todo


text:
Update documentation

ping @pedelman @philipmuir

:hammer:


text:
How can i use my self-defined sequence to evaluate the model?

First of all, make sure the format of your video (image names, groundtruth, etc.) follows the OTB standard. You can refer to assets/KiteSurf' or videos in here
If you want to evaluate the model on just one sequence, use scripts/run_tracking.py and change the input_files to your video path
https://github.com/bilylee/SiamFC-TensorFlow/blob/f572dca95f2b3b2861f54de467259753428e468c/scripts/run_tracking.py#L37
If you have multiple sequences and want to compute the AUC metric. This involves much more effort. Please read the code of the OTB toolkit and figure it out.

Thanks very much.

authors: bilylee hainanxzg

repo: bilylee/SiamFC-TensorFlow


text:
Added msi + code signing and homebrew

Fixed #107

repo: bitmaelum/bitmaelum-suite


text:
Add preconditions to consumer for refundAddress and fundingKey

Coverage increased (+1.07%) to 92.74% when pulling 72bb83e054efc4cfef02b14b43c61f77f1935fb2 on braydonf:preconditions-consumer into 762330308f4977c28f61a5ddeb9c0a2dbf947b1c on bitpay:master.

LGTM

ACK

So I think now the guide is wrong?
http://bitcore.io/guide/module/channel/index.html

authors: aynik braydonf coveralls eordano pnagurny

repo: bitpay/bitcore-channel


text:
Add asserts to most (all?) tests that raises if event loop or any RE caches are dirty.

Closing as unintelligble. What was @danielballan thinking. Ugh...

repo: bluesky/bluesky


text:
Added three missing methods to $urlMatcherFactory

@chr22 thanks mate!

note
http://angular-ui.github.io/ui-router/site/#/api/ui.router.util.$urlMatcherFactory

repo: borisyankov/DefinitelyTyped


text:
Fix a typo

Thank you for the fix

Thanks for reading the blog post @hosewiejacke

authors: FriedrichGretz hosewiejacke schorg

repo: boschresearch/blech-doc


text:
cmd/bosun: Kill on double ctrl-c

Why?

While developing, I hit ctrl-c to kill the process. This triggers the save method. Sometimes I just want to kill it right now and abort the save because I have new code to test. When I'm testing against the production state file, it can take 10s of seconds to save. I don't want to wait for that, I just want it to die.

+1
On Wed, Apr 29, 2015 at 4:56 PM, Matt Jibson notifications@github.com
wrote:

While developing, I hit ctrl-c to kill the process. This triggers the save
method. Sometimes I just want to kill it right now and abort the save
because I have new code to test. When I'm testing against the production
state file, it can take 10s of seconds to save. I don't want to wait for
that, I just want it to die.
—
Reply to this email directly or view it on GitHub
https://github.com/bosun-monitor/bosun/pull/929#issuecomment-97583692.

authors: kylebrandt mjibson

repo: bosun-monitor/bosun


text:
issue-57 update to include search setting via the delegate

Verified that @jdizoglio has signed the CLA. Thanks for the pull request!

authors: boxcla jdizoglio

repo: box/box-ios-browse-sdk


text:
feat: Add configurable local address

Should there be an addition to docker-compose.yml as well?
Also, I can't tell from the mobile web view; is this going into the docker-for-mac branch?

Yes, this should be targeting the docker-for-mac branch. I didn't want to the value to docker-compose because we don't know what it should be. That should be up to the user. It will fallback to the original implementation if not defined.

The docker-compose.yml addition could just include the key (with no value) and it will take the value from the host environment. It seems like it is more or less required to be set to be useful.

Updated docker compose to default LOCAL_ADDR to shell LOCAL_ADDR: 113767a

authors: bpholt jasonmead


text:
Add external-ci-notifications email to .travis.yml

:+1:

You should actually be using
notifications:
  email:
      - email@example.com

http://docs.travis-ci.com/user/notifications/#Email-notifications

Thank you for catching that @lkorth! Will update immediately.

:+1:

:+1:

authors: NickTomlin jeffcarp lkorth matthewpatterson mrak

repo: braintree/framebus


text:
add real content to index file

Good shit, dawg,

repo: bravogeorge/write-the-docs


text:
Fix misc typos in email_confirm_fail, activate_fail templates/translations, issue #145

Thank you for your work on this, much appreciated.

authors: mikek wunki

repo: bread-and-pepper/django-userena


text:
Add yarn installation method

Hi @Kerumen, and thanks for contributing to react-waypoint! I hadn't heard of yarn before, thanks for introducing this to me/us. Can you give a little bit more context on why you think we should have this in the README. It could be argued that yarn users should be aware of the fact that they can install npm modules.

yarn uses the same registry as npm so it's transparent for the users. You can read more here.

authors: Kerumen trotzig

repo: brigade/react-waypoint


text:
Confirm preemptible shows up on the GCE VM as expected.

👍

Nice :+1:

authors: cjllanwarne mcovarr ruchim

repo: broadinstitute/centaur


text:
Fixed vulnerablity in browserify-sign by update from 4.0.0 to 4.0.4

The vulnerability is already fixed, since ^4.0.0 includes ^4.0.4. This change is nice, but is not necessary for anyone to fix the vulnerability.

Duplicate of #217.

authors: gustawdaniel ljharb

repo: browserify/crypto-browserify


text:
Fix getDefinitions for SingleLoc and add getCodeLenses

Thanks!

authors: bubba cocreature

repo: bubba/lsp-test


text:
Complete list element component

closed by #128

repo: caciviclab/disclosure-frontend


text:
Project commands more requests

I think you must change the name of the PR for semrel

authors: adlerhurst fgerschwiler

repo: caos/zitadel


text:
Build @carbon/ibm-cloud-paks npm module

Acceptance criteria to be defined in Slack

It was discussed on the call with ide-components guild that it might be an idea to have separate releases for patterns

Given that the patterns themselves are individually versioned and changed.
This will help us deal with breaking changes.
We can release patterns into the open source one by one much easier
We could consider a core package which contains some of the smaller more common, or pattern agnostic components. e.g. Buttons,  DataTable

If we ensure that we maintain one shared build pipeline i think the overhead here will be worth it.

@joshblack is there an existing build pipeline for carbon that we can leverage here? Some additional considerations (maybe I just need more clarification here):

I thought I heard that we want to settle on a monthly delivery cadence. If that is true then how do we organize individual versioning?
Are there any documentations on how we should do dogfooding before releasing?
@SimonFinney

@gatfora / @Georgegriff I'd like to understand more about what we mean when we say component and pattern versioning - Are we talking about a component and pattern lifecycle, similar to what IDE does today, or truly individual packages?

At this point it was mostly a suggestion but I think we're talking about individually versions npm packages with one or more components in them, the reason being if we/design have to break a single pattern it's easier to deal with

would it make sense to align any of the versioning? eg if we aligned the major minor versions for monthly release cadence (which introduces new features, new functions, etc) and have teams increment their patch version as needed?
I guess all of this is mostly semantics since it still relies on a build model and tooling that supports individual team build/publish.

@joker23 definitely can share our setup and plans moving forward. Probably the simplest option for the monorepo here is to use Lerna plus a timed GitHub action if you all want to release on a schedule 👀
Lerna can help with versioning/publishing based on conventional commits, it can also help with cutting pre-releases for nightly builds or release candidates.
In general, we follow a time-based release schedule matching the following for a given month:

Nightlies occur daily
Hotfixes are published as-needed on off weeks as patches
Minors are published every other week (~26 releases/year)
Release candidates are published the week of the release and floated to smoke test teams

Looking forward, we're going to start moving towards two types of packages:

Component-specific packages, contain only the relevant component code and docs
Entrypoint packages, combine component packages into a single entrypoint

Separately, let me know if you all want to collaborate on any of the smoke-testing tooling for having teams try-out pre-releases! Our hope is to automate this process further on our end and use it to drive go/no-go decisions on releases or specific features.

authors: Georgegriff SimonFinney dbrugger joker23 joshblack

repo: carbon-design-system/ibm-cloud-paks


text:
Add some getters

@zazabe please review

lgtm

authors: vogdb zazabe

repo: cargomedia/janus-gateway-js


text:
Add README

@Kininaru @tangyang9464

Working on this.

@tangyang9464 plz add the README

authors: Kininaru hsluoyz

repo: casdoor/casdoor-java-sdk


text:
Upgrade GameSalad.app to v0.13.27

Thank you for the contribution. It was merged directly as de9a3464397d9d160a98baae30dc216f8ca4760a to keep commit history cleaner. Your contribution is still credited to you.

authors: Ngrd vitorgalvao

repo: caskroom/homebrew-cask


text:
Add zap stanza to not-tetris

Thank you for the contribution. It was merged directly as 5f7d55c5c582b0a61495aac85a32b4893d4ac115 to keep commit history cleaner. Your contribution is still credited to you.

authors: scribblemaniac vitorgalvao


text:
Update Rowmote Helper to 4.1.4

Thank you for the contribution. It was merged directly as e5678f435a782ac7c9089ef055959cb2b08beaee to keep commit history cleaner. Your contribution is still credited to you.

authors: buo vitorgalvao


text:
updated xamarin-studio (5.10.0.871-0)

Merged as 117d76ca38be0b7e92f006cc82157baf9334bf24.


text:
Add role and rolebinding for cephfs

This PR removes the unwanted rules and also adds the role and role binding for cephfs controller provisioner

@kfox1111 @rootfs @gman0 PTAL

repo: ceph/ceph-csi


text:
:true -> true in README

Thanks!

authors: barelyknown zeppelin

repo: cerebris/jsonapi-resources


text:
Add GenTX for ushakov

Hello, your gentx seems invalid; you have used a wrong chain-id. Make sure you set a correct chain-id when you create your gentx with --chain-id=shentu-rts flag, usually when initializing your directory. Could you resubmit your gentx?

repo: certikfoundation/chain


text:
FIX #26: Short URL is based on localhost hos

@GSokol, I just deployed the changes and it works just fine. Thank you again and star the repo if you like :). Also, feel free to report issues and fix them. It's an open source micro-project.


text:
Some modules might not be available in some DICOM files

Coverage decreased (-0.01%) to 2.489% when pulling 392e020199c6619727b292e070ffe596647d90d4 on campanflaviu:master into 400526a91918afcf88c662edae82e04714b13198 on chafey:master.

Thanks!

authors: campanflaviu coveralls swederik

repo: chafey/cornerstoneWADOImageLoader


text:
Refactor code

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 4

Complexity decreasing per file
==============================
+ src/js/app.js  -1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2

Complexity decreasing per file
==============================
+ src/js/app.js  -1

See the complete overview on Codacy

repo: chalu/smart-search


text:
ensure ACL'd items are handled correctly by search

This looks good, but I'd like to see explicit confirmation that a user who does have the right ACEs can perform the search and see the expected results.  This may just require modifying can_perform_* to accept a requestor argument.

:+1:

This has been merged

authors: marcparadise thommay

repo: chef/oc-chef-pedant


text:
cmake: Set visibility to hidden by default

Codecov Report

Merging #26 into master will increase coverage by 0.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   84.54%   84.98%   +0.44%
==========================================
  Files           8        8
  Lines        1585     1585
  Branches      149      149
==========================================
+ Hits         1340     1347       +7
+ Misses        166      159       -7
  Partials       79       79

authors: chfast codecov-io

repo: chfast/evmone


text:
Update File wokring workflow and setup pandas util

Related to the https://github.com/chimplie/google-documents/projects/1#card-12532216

repo: chimplie/google-documents


text:
Increase config coverage

Coverage increased (+0.3%) to 47.943% when pulling 988194604c4c4906b0d2f8d279513c304da8323c on jodh-intel:increase-config-coverage into 557148a13a1891d0c27ec97a0ef9a88dc694c2f7 on clearcontainers:master.

Coverage increased (+0.4%) to 48.168% when pulling a6d2cae21164f79cfce9be74bca2318038114aab on jodh-intel:increase-config-coverage into 9c2b909abc5816705429d0bac2405c6e2f0c7f63 on clearcontainers:master.

LGTM

@sboeuf - thanks.
@devimc - could you take a look when you get a chance?

lgtm

authors: coveralls devimc jodh-intel sboeuf

repo: clearcontainers/runtime


text:
Add option to switch orientation

:+1: You could also add a simple test for the new methods in the PHP class. :white_check_mark:

LGTM

authors: hkdobrev phgeorgiev

repo: clippings/phantom-pdf


text:
Endpoints can appear connected when they are not

@nwmac Tried to reproduce this but failed, we might have fixed it separately. Was there an specific ways to reproduce?

I fixed an issue that if an endpoint failed to connect it would still show as connected (and vice versa). Does this ring a bell @nwmac?

Yes - the issue observed was the icon would show connected even if the connect failed.

authors: KlapTrap nwmac richard-cox

repo: cloudfoundry-incubator/stratos


text:
Rewrite reload to avoid nulls and vars

This code may be changed soon as processor access is rerouted to the server.  The compiler says that lazy vars are not an option.  Only vals can be lazy.  Agro is soon to be changed.

Nice.

authors: MihaiSurdeanu kwalcock

repo: clulab/eidos


text:
Issue #332 Add test story to deploy local image

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

repo: code-ready/crc


text:
Update uk.coffee

Thank you for contributing, @wyyi!

repo: codecombat/codecombat


text:
Added GDCR2018 Auckland

Hello, I am going to change the utcOffset, AFAIK New Zealand doesn't change the time until April, so you current timezone is +13 from UTC.

Yes, that's correct @jdvr - thanks!
I used the generator which obviously had the wrong offset. I didn't notice, sorry.

authors: jdvr mightymuke


text:
Adjust time stamp on call log for EST

Doesn't seem to be an issue in local/development but is an issue in staging and prod, so I wonder if it's a mongolab thing.

Investigating this now. System clock seems to be four hours fast, probably thinks it's GMT.

Happening to all uses of time we have (such as Notes)

authors: colinxfleming eheintzelman


text:
Update openblas pin

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

authors: conda-forge-linter jschueller

repo: conda-forge/ipopt-feedstock


text:
Update scotch to 6.0.5

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

authors: conda-forge-linter dalcinl

repo: conda-forge/scotch-feedstock


text:
save into database - possible?

When you create the preference fragment you can load default values from whatever source you choose. Use findPreference(key); to find the Preference you'd like to setup. Then you can add OnPreferenceChangeListener to said Preference and store new values in the callback method.
It is beyond the scope of this library to provide tools for loading data from databases, content providers, network resources, etc.

Thank you. This will help me a lot.


text:
mazone s3 save file test ok.

@osguydch Please add these new driver package to Dockyard, and insure Dockyard compiling success, thx.

done

LGTM

authors: MabinGo osguydch

repo: containerops/dockyard


text:
Add clipboard for test

#1


text:
Documentation: LDAP connector documentation.

@ericchiang.

YAML does not allow extra lines between attributes :(

I've found that the id attribute also needs to be set for it to work at all.

Ah you're totally right, I think we even check that earlier now that https://github.com/coreos/dex/pull/686 is in.

Thanks @Calpicow

lgtm

authors: Calpicow ericchiang rithujohn191

repo: coreos/dex


text:
V1.4.0 beta.3 patchset

lgtm

repo: coreos/kubernetes


text:
Subcommand

bors: r+

bors: r-

bors: r+

bors: r-

bors: r+
(I cancelled the wrong PR oops)

repo: crate-ci/cargo-ghp-upload


text:
add group vs arbitrary benchmark

ack

authors: mfelsche seut

repo: crate/crate


text:
updated to crate admin 0.14.1

ack

authors: chaudum mikethebeer


text:
Set up WASI CI and releases

Depends on #68

I'd love to see a way to automatically upload the module to WAPM, if possible.
Let me know if that might interest you and I can help on the process :)

@syrusakbary Thanks for dropping by! Prior to creating this issue, I considered wapm as another target for our releases, however, I was concerned a bit. I might be mistaken, but for me it seems like that wapm is mostly for executables, and not libraries.
If that's not the case, then we will happily setup a wapm release pipeline for sure!

@battila7 Thanks for the feedback! WAPM is also a great fit for libraries.
I will talk with the team to see what we can do to make it clearer on the website :)

Note: A lot of features for the library use case are coming soon... stay tuned!

@syrusakbary Great, thanks! I'm really looking forward to those features as a fan of WASM!
If we need any help regarding the wapm deployment, we will reach out to you!

repo: cryptid-org/cryptid-native


text:
Mark SELECT into and locking clauses as not supported

Seems the build fails for an unrelated issue (Python 3.6 packaging), is there a way to retry?

I've restarted that job

Thanks for the PR! Looks good.

authors: Mytherin hannesmuehleisen jdahlin

repo: cwida/duckdb


text:
CLI for Conjur v5 is published as a pre-release gem

CLI has been released.

authors: jvanderhoof kgilpin

repo: cyberark/conjur-cli


text:
Variable Cache

it looks same as #21

Seems to be the same as #21 so I'll go with that once it's working.
Thanks anyway!

authors: chicoxyzzy daniel-lundin dmadan86


text:
[QUESTION] So I know how to apply a pull requests and compile them, but there are some old Osiris pull requests that I want to try out. How do I apply/fix some old pull requests?

config.cpp, if the pull request has old config.cpp style, adapt the code to the new one (write, read), remember to do config.h. but, if its so old that it causes shit tons of errors, maybe you need to do some basic pasting (read the code, and ask people on uc, learn cpp)

config.cpp, if the pull request has old config.cpp style, adapt the code to the new one (write, read), remember to do config.h. but, if its so old that it causes shit tons of errors, maybe you need to do some basic pasting (read the code, and ask people on uc, learn cpp)

Thanks, I were trying to make the bomb damage to work, but there were 2 errors. It was like "c4Ticking" and "getLocalePlayer" or something. It is an error from "hacks/misc.cpp", not on the config.cpp
I think I modified it to the latest version's "format"

most of them just require you to change the config read/save stuff

most of them just require you to change the config read/save stuff

Ok thanks

authors: YeetingWaterbottle mkot2 wemanzoz

repo: danielkrupinski/Osiris


text:
怎样导入本地音乐呢？

暂时还没有这个feature
On Sun, Sep 25, 2016, 10:40 Canux notifications@github.com wrote:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/darknessomi/musicbox/issues/396, or mute the thread
https://github.com/notifications/unsubscribe-auth/AD_RSmCoKSPfDw2o9SLyZ9vGSiZcMwBjks5qtd8CgaJpZM4KFzSr
.

ok, thanks.

authors: crazy-canux kigawas

repo: darknessomi/musicbox


text:
Add add, radd, div, divide, rdiv, truediv, rtruediv, mul, multiply, rmul, sub, substract, rsub in Series

Codecov Report

Merging #401 into master will decrease coverage by 0.14%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
- Coverage   94.77%   94.62%   -0.15%
==========================================
  Files          42       42
  Lines        4590     4615      +25
==========================================
+ Hits         4350     4367      +17
- Misses        240      248       +8

Impacted Files
Coverage Δ

databricks/koalas/missing/series.py
100% <ø> (ø)
:arrow_up:

databricks/koalas/series.py
92.85% <84.21%> (-1.11%)
:arrow_down:

databricks/koalas/tests/test_indexes.py
94.33% <0%> (-1.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6dff88...2853212. Read the comment docs.

Thanks, @ueshin

authors: HyukjinKwon codecov-io

repo: databricks/koalas


text:
Fix spark_df when set_index(.., drop=False).

Codecov Report

Merging #792 into master will decrease coverage by <.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #792      +/-   ##
==========================================
- Coverage   94.28%   94.27%   -0.01%
==========================================
  Files          32       32
  Lines        5770     5768       -2
==========================================
- Hits         5440     5438       -2
  Misses        330      330

Impacted Files
Coverage Δ

databricks/koalas/internal.py
95.85% <80%> (-0.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e992200...a9cbbd3. Read the comment docs.

Thanks! merging.

authors: codecov-io ueshin


text:
add snippet return

Sorry.

repo: dblock/slack-google-bot


text:
docs(CHANGELOG.md): update for v2.0.0-beta3

🚢

authors: jchauncey mboersma

repo: deis/fluentd


text:
Let's Swift 5.0 🚀

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7179561). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master     #10   +/-   ##
========================================
  Coverage          ?   43.8%
========================================
  Files             ?       3
  Lines             ?     105
  Branches          ?       0
========================================
  Hits              ?      46
  Misses            ?      59
  Partials          ?       0

Impacted Files
Coverage Δ

Sources/Carte/CarteViewController.swift
0% <ø> (ø)

Sources/Carte/Carte.swift
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7179561...27f8638. Read the comment docs.

authors: codecov-io devxoul

repo: devxoul/Carte


text:
수정내용을 삭제할 때 물어보는 창을 띄우기.

done.


text:
Entrega da atividade ta04

Ok's!

authors: PedroTreck diogocezar


text:
Fix missing comma in monitor snippet

This has been fixed in latest rewrite

authors: Pandraghon bdistin

repo: dirigeants/klasa-vscode


text:
add Ganhuo

Hey @xu6148152 - going to remove this for now.. pls resubmit when app is more complete and update the readme. thx

repo: dkhamsing/open-source-ios-apps


text:
Merge remote-tracking branch 'upstream/stable' into merge_stable

Have you seen the build failure @wilzbach? Looks like dpl-docs no longer builds due to a dependency resolution error.

#dlang_org is full of current deployment errors too, but I merged this anyhow because it's unrelated.

See #2413 for an attempt at resolving this.
It seems worse as the automated website fails atm.

authors: MartinNowak wilzbach


text:
Add @safe and @system to std.uri unit tests

Auto-merge toggled on

authors: WalterBright atilaneves

repo: dlang/phobos


text:
Added attributes and usage of immutable to std.net.isemail

AFAIK the functionality of validating email addressing with specific problems given back to the user isn't in vibe.d

Auto-merge toggled on


text:
benchmarks and supported rsync options

Not sure what you want based on the title alone - care to elaborate ?
As I said is the README, I'm pretty happy with the feature set right now and I find the performances good enough for my use cases

Explaining the behavior in contrast to rsync or simply copying the rsync definition (rsync -r and rsync -rp would be my guess, but the README and help does not elaborate).
Compare the two options against rsync.

We'll there's only one command-line option, --no-perms and it's documented in --help. I'll add a line in the README

repo: dmerejkowsky/rusync


text:
fixed NSDate + SHTimeInterval

Propre !

authors: dmiotti yomw

repo: dmiotti/SwiftHelpers


text:
Switch logging output to stdout

PR merged

repo: dobriak/autoscaler


text:
Fix comment for container.Start

LGTM

repo: docker/libcontainer


text:
[d3d10] Fix resource type for buffers.

Good catch, thanks!

authors: doitsujin nsivov

repo: doitsujin/dxvk

license: Zlib


text:
fix: add new feature "selectedToTop"

I have add "lodash" to bower.json for making it easy sorting selected Items. Looking forward for your answer

I'm not (re)adding lodash as a dependency, as long as it is a dependency I can't merge in this PR

authors: JuliaNsk pkempenaers


text:
Add Ref/Range tests

Codecov Report

Merging #14 into master will increase coverage by 0.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   98.67%   99.22%   +0.54%
==========================================
  Files          19       19
  Lines        1286     1286
==========================================
+ Hits         1269     1276       +7
+ Misses         10        5       -5
+ Partials        7        5       -2

Flag
Coverage Δ

#dot
99.22% <ø> (+0.54%)
:arrow_up:

#dot_encoding
96.42% <ø> (ø)
:arrow_up:

#dot_encoding_rich_text
100% <ø> (ø)
:arrow_up:

#dot_encoding_set
100% <ø> (ø)
:arrow_up:

#dot_encoding_sparse
100% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

ref.go
100% <0%> (+4.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c23ca4...5bed561. Read the comment docs.

authors: codecov-io rameshvk

repo: dotchain/dot


text:
Corrected the indentation and removed trailing whitespaces

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Shah-Nisarg sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

authors: Shah-Nisarg dnfclas

repo: dotnet/docs


text:
added new fields to support detailed android push notifications

Will revise and send a new PR soon.

repo: dreipol/django-scarface


text:
How I can get Host/IP address for the wifi gree ac?

use https://github.com/ddenisyuk/homebridge-gree-heatercooler

Thabk you.
One more question, How I can get the host number for each AC.

In your router dhcp list.

Thank you .. it is working now
Do you know how plugin so I can set up my Mi camera in apple homekit ?
Thank you

repo: duculete/homebridge-gree-ac


text:
fixed google search

any thoughts on this PR's future?

no time only now or no interest and i should close the PR?

@duilio Would it make more sense to have someone else with more time take over as the official fork?

@dhermes Probably it would make more sense to add a maintainer instead of fork.

authors: dhermes duilio mstreuhofer

repo: duilio/pelican-octopress-theme


text:
Fast DDS CMake options documentation

Build status:

Build status:

Build status:

Build status:

Build status:

Build status:

repo: eProsima/Fast-RTPS-docs


text:
Fix for liveliness changed struct [5765]

Testing this branch against release/1.8.1:

All tests passed on Ubuntu
All tests passed on mac

This branch resolved the issues in ROS 2's test suite https://github.com/ros2/rmw_fastrtps/pull/296#issuecomment-506422015

authors: nuclearsandwich raquelalvarezbanos

repo: eProsima/Fast-RTPS


text:
Test editorconfig-core-tests PR#23

Out of date. Replaced by https://github.com/ec4j/ec4j/pull/96


text:
fix typo

@LuisGalazM Thank you for this PR

authors: LuisGalazM sberyozkin

repo: eclipse/microprofile-jwt-auth


text:
修复了多行输入的bug

Coverage remained the same at 83.016% when pulling bdeb89f759232a5c43576774dd08d88bc998dd02 on develop into 13b9ddaca84caabd7e99e0085e356ee52fa08732 on master.

repo: ecomfe/san-mui


text:
Added flutter icon

Great stuff! I've added this - but if you remove some of the whitespace, I think you can get it even smaller :-)

On it! 😄

authors: edent leanthonyml

repo: edent/SuperTinyIcons


text:
Hackathon: AMD support for XBlocks

Thanks for the pull request, @e-kolpakov! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.
To automatically create an OSPR issue for this pull request, just visit this link: https://openedx-webhooks.herokuapp.com/github/process_pr?repo=edx%2Fxblock-sdk&number=75

@singingwolfboy you mentioned in IRC that you were interested in this feature. The build is currently failing, but I wanted to make sure that you knew this pull request was out there, in case you wanted to offer any commentary.

authors: Lyla-Fischer e-kolpakov edx-webhook

repo: edx/xblock-sdk


text:
Added minify options; updated test cases

I actually want it to minify the whole bundle instead, like terser-webpack-plugin, rather than per-file minification.

authors: egoist mathew-kurian

repo: egoist/esbuild-loader


text:
Adding Demio App ( A Webinar Platform )

Hi @jlord ,
This is my new PR , did some changes  , I am Core Engineer of this Platform and talked with Founders too
Please merge :) Thanks!

Thanks, @destromas1

@zeke Thanks a lot Buddy!


text:
elm repl --no-colors should not output any ANSI codes

See https://github.com/elm/compiler/issues/1804

I would appreciate feedback on this pull request.

@evancz I see you are working on the compiler. Do you have plans to review some of the pull requests ? Or PRs are not part of the process of the Elm community ?

I eventually understood that I missed to sign the Contributor Agreement. I sent it today.

repo: elm/compiler


text:
Add rule against using specific deprecated jQuery Methods (Blacklisted)

I'm also totally cool with moving this effort/PR into a branch and keeping it there. I'm unsure if this type of linting rule is applicable to many folks? @stefanpenner

@rwjblue brought up a good point regarding import declarations and ensuring we are covering use-cases like:
import jQuery from 'jquery';

jQuery.add()

I'm going to append this commit to include the updated rule and test(s) for above.

@rwjblue brought up another good point (DM) to leverage a schema to allow folks to modify the BLACKLIST via .eslintrc.js as a param. Updated PR coming.

LGTM 👍

authors: lynchbomb scalvert


text:
Add build yaml file

LGTM

authors: arthurvandijk yasinkocak

repo: emielb/omt-odt-language


text:
driving commod

@FlanFlanagan looks good to me


text:
Fix react router to display multiple nested components

I think this needs deeper research, becase I got same result when I didn't pass location prop.

This is just fix, butI do not like this idea of cloning element with complete state.
I have in my project very small implementation of this:
@connectState({
  state: {
    email: ['auth', 'form', 'fields', 'email']
  },
  actions: {
    authActions: ['auth'],
    setFormField: ['auth', 'setFormField']
  }
})
export default class Page extends Component {

basically what it does, before every smart component you can setup this decorator, which will take parts of state and put them into props so this:
 email: ['auth', 'form', 'fields', 'email'] take email from state getIn(['auth', 'form', 'fields', 'email']) and put it to this.props.email
similar thing is to take actions and map them to state. Only one thing is that every feature has it own scope of actions so you can take only small part of actions to component.
You can also do prefetch by adding:
  prefetch: [
    ['auth', 'logout']
  ]

which will call action logout in componentDidMount (using common/components/fetch.js) for it

@steida @grabbou I would like to know your opinion about this?

I would love to see oficial react-router solution for that. @grabbou Do you know more?

This is a known issue and @bulby97 already had it I guess, or @webkadabra and we solved it on Gitter.
Not sure if you are asking about the 3rd comment here or the issue by itself, speaking issue wise, the problem is that if you have hierarchy like this:
[App] -> [Dashboard] -> [Orders]

and app passes all the props to dashboard component, dashboard component will keep rendering itself, because reference to Orders is being overwritten by that to Dashboard passed down from App. The solution presented here is valid to me.

But it looks like magic boilerplate. We have to figure out simpler or explicit approach.

What exactly is magic boilerplate? Excluding children from the props we pass down? This is rather quite idiomatic React approach to me, although it's confusing because not everyone is aware of all the props (and it's quite error prone if more props like children are there in the future).

@grabbou sorry for confusing you.
I put two things to one issue.
Will update PR #535 to match what you commented
Thing in this issue is how you propagate data from APP component to sub components (which are rendered by router)
You are sending data by props to sub components. This magic boilerplate chooses only parts of state which you need in sub component (1 part), then you can select actions you need (2 part) and last part is doing fetch action (3 part).
All those things are done by @connect from redux. Fetching part is using you fetch, which work on server too.
I will create pull request for that, if you are interested.

@steida @grabbou Better this way?

I would add explaining comment to any suspicious piece of code as grabbou did.

I will fix it soon. Thank you for PR.

authors: AlesJiranek grabbou ondrejbartas steida

repo: este/este


authors: BelfordZ meowsbits shanejonas


text:
v22.6.18 - disable tests agains PHP7.1 as doctrine have some bugs

Current coverage is 100% (diff: 100%)

Merging #643 into master will not change coverage

@@           master   #643   diff @@
====================================
  Files          29     29
  Lines         439    439
  Methods       111    111
  Messages        0      0
  Branches        0      0
====================================
  Hits          439    439
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update 4ac1066...c30a9cd

authors: codecov-io eugene-matvejev

repo: eugene-matvejev/battleship-game-api


text:
Update Copyright

@frodenas Will you please review this PR to re-assign copyright, and merge if you approve?

repo: evandbrown/gcp-tools-boshrelease


text:
Add the alphametics exercise & babel-polyfil dependency

Why does it keep including all the other commits that have already been merged? Also looks like the build failed again.

@arthurchipdean I'm not sure why you're seeing those commits, but that's not a big deal-- you can squash everything as we discussed before.
I'm guessing your build failure is because you have a/some package.json files in individual exercises that don't match the global one.  Running make test should copy the global file to each directory.  I would give that a try, commit the result, then push.  See if that resolves the build issue.

@matthewmorgan I tried that already and it wasn't working. It's listing all files from those commits as new after I run git reset --soft . I just committed the result.

OK, I will pull down this branch and have a closer look.  I'll let you know what I find out.  Thanks for your efforts!

OK,
A couple of things:

When I tried using reset --soft it appeared to work.  I can't be sure, because I can't push back to your branch.  FYI I ran git reset --soft 5252b42, then committed the result, and got only one commit in my history.  GItHub may be doing something different, but it worked with git.
@tejasbubane called out an issue with the Makefile in #301 .  I verified that problem, and when I commented out the test-package-files command, I was able to run the test suite on your branch with no problem.

Bottom line, I think we need to fix #301 before we can build anything, including your branch.  If I have time today I will check it out....I think it may be as simple as setting the -max-depth parameter on find.

@arthurchipdean Can you check if this works? https://babeljs.io/docs/plugins/transform-regenerator/#usage-via-babelrc-recommended-
Since babel-plugin-transform-regenerator is already installed, I think it would be better if that can be used instead of adding a new package.

@tejasbubane  Yes that worked! I committed the change.

@matthewmorgan I tried that git reset soft using the hash you provided and it seems to be adding more commits.

@arthurchipdean We have Babel settings in package.json ( see babel
section). Add the transform plugin there and remove the .babelrc file.
On Jun 2, 2017 8:19 PM, "Arthur Dean" notifications@github.com wrote:
@matthewmorgan https://github.com/matthewmorgan I tried that git reset
soft using the hash you provided and it seems to be adding more commits.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/exercism/xecmascript/pull/299#issuecomment-305810302,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA73L6_NAGILklz3ZIJ-Mz0jJ68eizBlks5sACEHgaJpZM4NsaBG
.

@arthurchipdean I pulled your branch and it looks like you are in the middle of a REBASE that has created some merge conflicts.  This is very common, and should be resolvable.  I would suggest following these steps:

Edit the config.json file to remove the problems key and its values.  Please also remove any conflict artifacts like ========== etc.
git add config.json
git rebase --continue

I believe this should put you back in a proper state.  Then try pushing the changes back up and let's see what we have.  If that doesn't work, don't worry- I'll help you sort it out!

@matthewmorgan I followed your steps.

@arthurchipdean the current problem is that the package.json file in one or more exercises does not match the global package.json file, so the test-package-files task in the makefile is failing.
Unfortunately, there is not a simple way to copy that file to every exercise.  That is our fault-- we prematurely merged that new task into the makefile without providing an easy way to copy those files over.  Let me see what I can do about that.

@arthurchipdean I've made a change to master that will work around this problem for now.  You can either pull that change in to your branch, or simply delete line 36 from the Makefile:
	@$(MAKE) -s test-package-files

and re-run make test from the xecmascript/exercises directory.  This should copy all those files over to the individual directories for you.
I'll open an issue to modify the Makefile to perform this task automatically so others don't have the same issue.  I feel terrible that this has been such a hassle for you.

@arthurchipdean is there anything I can do do help you get this one finished?

@matthewmorgan sorry for the delay, I have been busy. I'm attempting your feedback right now. Tests are running. So after running the tests I'll just commit the result and push?

It's failing here :(
 FAIL  exercises/connect/tmp/temp.connect.spec.js
  ● Test suite failed to run

    Cannot find module './_copyObject' (While processing preset: "/root/xecmascript/exercises/connect/node_modules/babel-preset-env/lib/index.js")

@arthurchipdean no worries I have been busy myself!  End of school year etc.
I pulled down your branch and was able to run it locally with no trouble at all.  I'm going to try making another branch with your code and opening a PR to see if there's any issue in CI for me.

@arthurchipdean Travis is apparently struggling to keep up with submitted PRs, so I don't have CI result.
I found two issues with your PR, I'm not sure either would have caused this problem, but I changed them in my branch:

alphametics has a jest_0 directory with a few artifacts.  That dir should be removed.
config.json has a reference to flatten-array, which is not part of this track.

Anyway, as soon as I see a result from Travis I'll report back, and we can go from there.

@arthurchipdean I made a new branch from yours here.
I fixed a few issues (flatten-array is not in master, but was in your branch, removed jest artifacts) and everything is now passing the CI build on Travis.
It looks to me like everything in my branch is what you intended to be in your PR: altered config.json files for all exercises, and the new alphametics exercise.
I would suggest that you pull the main exercism repo down again and merge my branch acd-resolved-config in to this one.  Push it back up, let's see if the build passes. I believe it will.

@arthurchipdean I would like to see your work incorporated into the repo.  Let me know if you'd like to finish up this PR, or I can instead merge #309.
Either way, we appreciate your contribution!

Closed in favor of #309 .  @arthurchipdean Thanks for doing the heavy lifting on this one!

repo: exercism/xecmascript


text:
setting Firedac Query

This validation will be removed as it is redundant.

authors: OneideLuizSchneider ezequieljuliano


text:
use openshift imagestreams for non java pipelines

retest this please

[merge]


text:
Code missing? if this is the official repo for the book then why is the code missing?

true dat!
@ian, where's the code man? your book is very promising, but you can't have a hands-on book without code. not cool.

true dat!
@ian, where's the code man? your book is very promising, but you can't have a hands-on book without code. not cool.

Yes. I have to clean up data as some files needed for chapter 2 are corrupted. I don't mind but this is demotivating. I am also facing errors, though I have typed in every line word to word.
@falloutdurham when will you upload the code? Is there an alternate source?

Check the other repo for the downloading code - https://github.com/falloutdurham/pytorchupandrunning - I'm hoping to get most of the rest uploaded this week!

Check the other repo for the downloading code - https://github.com/falloutdurham/pytorchupandrunning - I'm hoping to get most of the rest uploaded this week!

Ah! Only if you would have replied a moment ago, wouldn't have typed in the above comment.

np ;)

(and apologies - I've been a little ill and running behind on this part!)

@falloutdurham oh that sucks! Hope you're feeling better.  really enjoyed your content as well. I've the online version and looks like your book was just released very recently.
so the link you posted above isn't pertinent to training the model using pytorch, unless I missing something?

Thank you! I'm still a little behind but I'm still hoping to get at least notebooks for Chapters 2 -6 up this weekend! The link I posted earlier is for downloading the cat/fish dataset (and the book got renamed partway along the process, hence the slight confusion in repos). The model training should be up by the end of Sunday! And again, apologies to all…

Thank you! I'm still a little behind but I'm still hoping to get at least notebooks for Chapters 2 -6 up this weekend! The link I posted earlier is for downloading the cat/fish dataset (and the book got renamed partway along the process, hence the slight confusion in repos). The model training should be up by the end of Sunday! And again, apologies to all…

That will be good. Get well soon!

hi, so the chapters 7+ notebooks will be posted one day as well?

Yes! Chapter 7 is up already (as well as part of Chapter 9), and I'm hoping to fill in the gaps on 8 and 9 this week!

authors: Poltigo faisito falloutdurham necronomican winkhai


text:
Regularly republish announces to the DHT

The user should regularly call dht.announce if they want to announce regularly on an interval.

repo: feross/bittorrent-dht


text:
Added support for fixed precision integers. #177

closes #178

repo: finos/morphir-elm


text:
implement fish update

implemented in 54ec34b

repo: fishworks/fish


text: Get rid of unnecessary flutter_root argument.

authors: abarth pylaligand

repo: flutter/flutter


text:
Add obscureText field to TextInputConfiguration

test?

Added a test.

Partial fix for #9411 and #6760

authors: Hixie cbracken


text:
Fix: path for staging cluster

You need to sign your commit, see https://github.com/fluxcd/flux2-kustomize-helm-example/pull/1/checks?check_run_id=1369900915

authors: nlamirault stefanprodan


text:
bootstrap: Don’t eat error during discoverd wait

LGTM

authors: josephglanville titanous

repo: flynn/flynn


text:
Documented using event handlers to handle input without direct DOM reads or refs

Thanks for the edit, this is definitely a better approach.

Thanks for the edit, this is definitely a better approach.

authors: jeswin spiffytech

repo: forgojs/forgo


text:
MacOS release

Implemented in https://github.com/foundpatterns/torchbear/commit/92d6f770114478bf27bc04afe3f9513341c8e3a1

repo: foundpatterns/torchbear


text:
Longest Common Substring length in C++

I have made the required changes, and added longest common substring length in C


text:
Refactor disk

I better test crc32c with ext4 as suggested by @fittestbits in IRC.

repo: froggey/Mezzano


text:
Add --version option

@touilleMan Thank you for this, I've merged these changes onto a new branch with the conflicts resolved. This will be merged via https://github.com/gabrieldemarmiesse/python-autopxd2/pull/21

authors: elijahr touilleMan


text:
fix(package): update sequelize to version 5.18.1

Coverage remained the same at 99.488% when pulling e4decfc69d5ac33a5e18eb8aac0aedd787a307cf on greenkeeper/sequelize-5.18.1 into abd8a2f6004c6ecf1dcdc66f3fca67933769c8d7 on master.

authors: coveralls gabrieltanchen

repo: gabrieltanchen/expense-api


text:
Implements Skiplist encoding and zset rule

@misterion ,
It would be nice to analyze memory usage for zset objects! I hope you mean it with this issue.

authors: misterion muravjov

repo: gamenet/redis-memory-analyzer


text:
Add print to file with filename

Codecov Report

Merging #18 (05dee2e) into master (8fa5e18) will decrease coverage by 1.77%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##            master      #18      +/-   ##
===========================================
- Coverage   100.00%   98.22%   -1.78%
===========================================
  Files            6        6
  Lines          333      338       +5
===========================================
- Hits           333      332       -1
- Misses           0        6       +6

Impacted Files
Coverage Δ

src/watchpoints/watch_print.py
96.92% <75.00%> (-3.08%)
:arrow_down:

src/watchpoints/util.py
91.11% <0.00%> (-8.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fa5e18...05dee2e. Read the comment docs.

authors: codecov-io gaogaotiantian

repo: gaogaotiantian/watchpoints


text:
Community creation script creating an extra cluster

Could not reproduce on develop. Next time trying it on production, add a raise inside the spec/support/defaults.rb file in the cluster method.

Production reveals the issue is with household factory via people generator.
Need to:

Change how the default cluster and community are setup in spec/support/config/002_cluster_setup.rb
This would enable us to explicitly declare a cluster and community in spec/models/utils/fake_data/main_generator_spec.rb
And then stub the cluster and community methods in spec/support/defaults.rb to raise an error if called. This would prevent this from happening inadvertently in the future again.

repo: gather-community/gather


text:
change ogr error handlings

 OgrSource: Default-Geometry rauswerfen

repo: geo-engine/geoengine-ui


text:
Fix typo

bors r+

authors: Napokue kvark

repo: gfx-rs/gfx-memory


text:
Lazy parsing

Coverage increased (+0.4%) to 78.351% when pulling 45f8532f4a27552661b53cf0ee714c8fca33b662 on philipc:context into 047728843475853330f03446d9b7e7fca024d31a on gimli-rs:master.

Ah, I guess the problem is that that would keep a &mut borrow on self alive?
In that case a (ref)cell may be worth considering - it has the added bonus of not requiring &mut for the query functions either.

Yeah it was due to the &mut borrow, but I just did similar to what we used to do before hardliner, instead of thinking about it much; I'll look into it more tomorrow. Cell isn't appropriate because it needs to move the value in and out of the Cell. I've not had much experience with RefCell, but I think that would be trading &mut for runtime panics if you happen to use this from multiple threads, so I don't think that works either?

There's also https://crates.io/crates/lazy-init

I've not had much experience with RefCell, but I think that would be trading &mut for runtime panics if you happen to use this from multiple threads, so I don't think that works either?

No, what RefCell does is simply that it moves the borrow checker from compile time to runtime (at least that's how I think of it). It's basically the single-threaded version of RwLock.
I didn't consider multi-threaded environments. In that case, lazy-init does seem like a better solution.

Added a commit for lazy-init.
I looked into using RefCell but it was starting to get complicated because the Ref needed to live as long as IterFrames.

Coverage decreased (-0.1%) to 77.778% when pulling b34cd8ddfd999d9a6689368ee66f4b006050e1e1 on philipc:context into 047728843475853330f03446d9b7e7fca024d31a on gimli-rs:master.

Coverage increased (+8.2%) to 86.174% when pulling 4e488182d129e8fd97ce973e153b2f8ecbb9e81e on philipc:context into 047728843475853330f03446d9b7e7fca024d31a on gimli-rs:master.

authors: coveralls main-- philipc


text:
Create Basic.gitignore

@mosesag0813 could you tell me a bit about where these rules are defined?

@shiftkey Yea, heres a link as to the repo i am working on.

Also the rules are defined in the repo

@mosesag0813 that link seems to 404 - is that right?

Weird... Let me try again.

Right...the gitignore has changed, the reason for the 404. I may have not done this right, but here the gitignore.

The repo will be integrated with a custom build.

I'm going to close this out because I still have no details about the motivation behind this template.
@mosesag0813 if you feel like this should still be a template listed here, please read the section about specialized templates and open a new pull request with more details.

repo: github/gitignore


text:
Update readme with details about linguist-generated

@mkdynamic If you merge in master, resolve any conflicts, and then accept the CLA we can go ahead and :ship: this.

These changes have now been made to the README in https://github.com/github/linguist/pull/3588 so closing this PR as we don't need it anymore.

authors: lildude mkdynamic

repo: github/linguist


text:
Use Travis CI

Solved

repo: globocom/azkaban-cli


text:
Adding Aave and Sablier apps

Travis automatic deployment:
https://pr1045--safereact.review.gnosisdev.com/app

authors: gnosis-info nicosampler

repo: gnosis/safe-react


text:
Add an option to duplicate selected objects (Ctrl + D)

Thanks!

authors: Firstject HeartCodeGames


text:
Make FFT size and oversampling adjustable in smbPitchShifter, add windowing to smbFFT

See Code style guidelines for details on the style guide and how to apply clang-format locally.
And PR workflow on how to rebase your branch to squash the current two commits together and do necessary fixups with git commit --amend.

For the reference, this is a re-do of #28547.

@akien-mga After about one million screwups with git rebase... Is this ok?

It looks good yes, thanks :)

Thanks!

authors: akien-mga mdahlgrengadd

repo: godotengine/godot


text:
Get Polymer to work with Phonegap

Made it work inside an iframe. This is currently in branch initial-draft.


text:
[UPDATE] fork

Oops wrong forking direction, 🤦 . Apologies for the noise

repo: goodhertz/coldtype


text:
Add Cholesky to symmetric backend

Hi, i would love to work on this issue

repo: google/TensorNetwork


text:
Fixing some warnings and formatting hints

Sorry, my mistake.


text:
some minor-ish fixes to the gl backend and framegraph

auto textureResource = dynamic_cast<ResourceEntry<FrameGraphTexture> const*>(subresource);
:-(

authors: pixelflinger romainguy

repo: google/filament


text:
Upgrade MoltenVK.

@prideout No, we shouldn't need it anymore. My original iOS Filament port used MoltenVK, but that's been long since abandoned.

@prideout No, we shouldn't need it anymore. My original iOS Filament port used MoltenVK, but that's been long since abandoned.

Ah, that makes sense thanks.  I amended the commit...23.5 MB removed from the repo!

authors: bejado prideout


text:
Changed the .gitignore to use a bit more generic ignore rules

Looks like this isn't off master.  Some changes to the ignore when in yesterday so this has conflicts.

@sgl0v can you sync/rebase this off trunk to confirm if things are still needed?

repo: google/google-api-objectivec-client


text:
go: List methods don't respect requests' PageSize

Fixed by #2041.

repo: googleapis/gapic-generator


text:
feat: Add CCAI API

Self-merging to unblock autosynth

repo: googleapis/google-cloud-dotnet


text:
docs: update sample, regenerate README

@sofisl looks like this breaks the sample tests, might need to do some digging.

@sofisl it looks like the reference to @google-cloud/functions is missing from samples/package.json, I believe is the issue here.

@bcoe, thanks for the debugging 👍  saved me a bunch of time!

authors: bcoe sofisl

repo: googleapis/nodejs-functions


text:
Dev

@googlebot I consent.

authors: fgoyal maxhchen

repo: googleinterns/pieced


text:
Fix runtests --force_default_poller on linux

Actually on windows I'm still seeing this after applying this patch:
2017-05-17 20:17:21,515 PASSED: tools\run_tests\helper_scripts\build_csharp.bat [time=16.6sec; retries=0:0]
Traceback (most recent call last):
  File "tools/run_tests/run_tests.py", line 1565, in <module>
    build_only=args.build_only)
  File "tools/run_tests/run_tests.py", line 1462, in _build_and_run
    if not args.travis and not _has_epollexclusive() and platform_string() in _POLLING_STRATEGIES and 'epollex' in _POLLING_STRATEGIES[platform_string()]:
  File "tools/run_tests/run_tests.py", line 1439, in _has_epollexclusive
    subprocess.check_call('bins/%s/check_epollexclusive' % args.config)
  File "C:\python_27_amd64\files\lib\subprocess.py", line 506, in check_call
    retcode = call(*popenargs, **kwargs)
  File "C:\python_27_amd64\files\lib\subprocess.py", line 493, in call
    return Popen(*popenargs, **kwargs).wait()
  File "C:\python_27_amd64\files\lib\subprocess.py", line 679, in __init__
    errread, errwrite)
  File "C:\python_27_amd64\files\lib\subprocess.py", line 896, in _execute_child
    startupinfo)

Ok, this is the reason:
def _has_epollexclusive():
  try:
    subprocess.check_call('bins/%s/check_epollexclusive' % args.config)
    return True
  except subprocess.CalledProcessError, e:
    return False

I pushed a fix for Windows and non-C languages to this branch and I'm merging as this issue making development hard for everyone.
Please double check your run_tests.py changes next time you are changing it - there are other platforms than linux and other languages than C.

authors: ctiller jtattermusch

repo: grpc/grpc


text:
Add copyright checks to sanity; make them verify copyright year is valid

Only the sanity check and comments were changed, and the sanity tests passed. The Mac tests seem to be taking a long time because we only have one running Mac worker.


text:
Document rpc details as string type

Closed in favor of https://github.com/grpc/grpc/pull/7378


text:
Warning when element size or position is 0 or negative

It calls engine.console.warn so it's only visible with ?log=1

repo: gss/engine


text:
can not use with react 0.32

👍  that library doesn't work for me either in 0.39

authors: jonbrennecke onlyoneonly


text:
Training

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.

repo: hashicorp/hashicat-aws


text:
Fix examples link on both READMES (/modules & /examples)

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.

authors: hashicorp-cla jnerin

repo: hashicorp/terraform-aws-consul


text:
HIP - PoC Ripple Method

Thanks, Anthony!
Rendered view: https://github.com/helium/HIP/blob/c27ef2243e36c679158edadd3ef607aa61010695/xxxx-poc-ripple-method.md

Looks great, numbering and merging. This will be HIP14
Please direct future feedback and questions to the tracking issue: https://github.com/helium/HIP/issues/50

authors: PharkMillups anthonyra jamiew

repo: helium/HIP


text:
Group Programming

Ini apa ya maksudnya?

No description provided.


text:
Numa gxm

can you please resubmit for numa_gxm branch?

I will merge it into numa_gxm, so no problem this time.

Merged.

authors: alheinecke hfp ska278

repo: hfp/libxsmm


text:
HHH-10689 - Fix tests failing when switching to Oracle

Applied upstream.

repo: hibernate/hibernate-orm


text:
using _crc16_update() from avr-libc makes crc16 computation 3 times faster

Thank you for your PR and so sorry for late reply. Now I use much faster and flexible library so I will update this repository to the wrapper of such library. Thanks again!

authors: AlexIII hideakitai

repo: hideakitai/CRC


text:
Change protocol https to http for 'https proxy'

This breaks support for my universities proxy server. They only proxy https connections if the proxy is accessed via https.

authors: max-te saburto


text:
Registered postcss-single-line plugin.

Dear Dave,
Sorry, my mistake. I just made the requested change. Is that all right now?
Thanks!

repo: himynameisdave/postcss-plugins


text:
Readme update

Coverage remained the same at 100.0% when pulling db4ba5a20f113751879d250f4e1c4ed0f7b2cf41 on readme-update into d28462978433e6066a203d814be7533e5a89d9da on master.

authors: coveralls hootnot


text:
test(error): increasing test coverage of error module

Coverage increased (+0.08%) to 89.27% when pulling 59d8e80e6c61bfbfb4c1289d8315acb0fdf9ff4e on winding-lines:coverage into 9dc85279ac07302400ec42ceb7d9ff405c5d4f91 on hyperium:master.

Coverage increased (+0.09%) to 89.27% when pulling b24e1a5e6c479aedf719bd491366079331ccaec2 on winding-lines:coverage into 9dc85279ac07302400ec42ceb7d9ff405c5d4f91 on hyperium:master.

hm, this PR is not very successful in increasing coverage, I may just drop it.

I'll merge this, since it also tests the cause() part, which is a good idea. If there was a way to pass to kcov to ignore all fns inside a #[cfg(test)] mod, that would greatly help reduce inflated "lines missed" values.

Great :)
Marius

On May 28, 2015, at 10:39 AM, Sean McArthur notifications@github.com wrote:
I'll merge this, since it also tests the cause() part, which is a good idea. If there was a way to pass to kcov to ignore all fns inside a #[cfg(test)] mod, that would greatly help reduce inflated "lines missed" values.
—
Reply to this email directly or view it on GitHub.

authors: coveralls seanmonstar winding-lines

repo: hyperium/hyper


text:
Update OWNERS

/assign iamsubratp

/assign @iamsubratp

/woof

/assign @iamsubratp

/packagebuild

authors: iamsubratp subratp-testing

repo: iamsubratp/osconfig


text: Add gui notification when connection drops

repo: ibissource/iaf


text:
Update pg_dump command to avoid deprecated -i flag

This is rectified in this commit: 211bb6ecd164f51c0ca8bd5dbfc1b20c682cbd31.

authors: dylanwolff timriley

repo: icelab/dry-web-skeleton


text:
ssdb能进行主从切换吗？

在设置成 sync 模式后 可以把从提为主吗？

可以, 但需要进行一些停机运维操作.

假设现在是两台机器 A, B. A 作为 master, B 作为 slave.
停止两台机器.
将 A 的 data 目录移走到别的地方进行备份, 让 A 成为一个完全没有数据的节点.
修改 B 的配置文件, 移除 slaveof 配置.
修改 A 的配置文件, 添加 slaveof B 配置.
启动 A, B.
这时, A 会从 B 获取一份全新的数据.

authors: githubtianfeng ideawu

repo: ideawu/ssdb


text:
feat(dropdownlist): genome in dropdownlist

Thank you for your contribution.  However we already have 1 covid-19 assembly (ASM985889v3).   How does this one differ, or more importantly how is the user to know what assembly this is?     Also we don't want to change the port in the http-server startup by default.

authors: jrobinso thanh-nguyen-dang

repo: igvteam/igv-webapp


text:
Hotifx/ci vulnerability

According to this discussion, "To trigger a workflow runs on the workflow_run event, the workflow file should exist on the master or default branch", which means we need to merge it first to see if it works (and to remove that pull_request_target one)

repo: illright/attractions


text:
Add compiled Rmd to gitignore

You are right. It is only a problem when compilation was not succesful. It occurs by times ;-)
You can choose.

I'm closing this because I like to keep thing minimal

authors: ThierryO florisvdh


text:
Add additional broker HTTP redirection.

lgtm, :shipit:

authors: benbjohnson pauldix

repo: influxdb/influxdb


text:
WIP Test cabal new-build

@erikd Do we still need this PR?

authors: erikd jcmincke

repo: input-output-hk/cardano-sl


text:
Incorporate Frisby's feedback on the style guide

bors merge

repo: input-output-hk/ouroboros-network


text:
Empty lists can not be uploaded

Hello @mbasil09! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file intermine/lists/listmanager.py:

Line 269:80: E501 line too long (82 > 79 characters)
Line 271:80: E501 line too long (97 > 79 characters)

repo: intermine/intermine-ws-python