text:
Make text summaries of video's

It would be great to have a text summary of video's, for example:

explaining the Roadmap overview

I agree. This helps for alot of different reasons and can be consider into the "Curation/Aggregation" Project board

I hope this problem of "tax payments and invoicing" is pretty soon solved.
Then we can put bounties on these kind of tasks. Like 100 USD per summary
(can be teamwork as well).
Probably it's best to withhold like 30% tax on each payment and that RChain
pays it to the tax office. That would guarantee also a continuous flow of
RHOC to the market. RChain is then obliged to convert big amounts of RHOC
into BTC and then USD.
--
Cheers,
HJ
On Tue, May 16, 2017 at 7:48 PM, patrick727 notifications@github.com
wrote:

I agree. This helps for alot of different reasons and can be consider into
the "Curation/Aggregation" Project board
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rchain/Members/issues/38#issuecomment-301860884, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB0x902I9HCS-BcE_DbOSKT0mNNPJBILks5r6eFvgaJpZM4NbY0x
.

repo: rchain/Members


text:
Add ValidationCode constants for all other diagnostics

At the moment, only three types of diagnostics have codes, LOWERCASE, EXTRA_ARGUMENT, and INVALID_ESCAPE_DIRECTIVE. We should add codes for the remaining diagnostics.

The refactoring has completed. Also covered by da5062397b4eed0363a05b34b964d95a85c7b7d7 and 13c3cd8e5f0616af5e91a95fff4bdd2648f3261e.

source: gharchive/issue

license: mit

license_type: permissive

license_source: bigquery


text:
Oraaud with rpm

Using a tar file was problematic.  Using an RPM package from a local file system (as opposed to a yum repository) solved the dependency issue.  However, the RPM uses a post install script, which may or may not be approved by the rest of the team.

very nice!

source: gharchive/pull-request

authors: jtmfam rcompos

repo: rcompos/oraaud


text:
Fix python 2.7 compatibility

cc @gizatt

Codecov Report

Merging #7 into master will increase coverage by 0.43%.
The diff coverage is 74.5%.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   87.13%   87.56%   +0.43%
==========================================
  Files           5        6       +1
  Lines         373      402      +29
==========================================
+ Hits          325      352      +27
- Misses         48       50       +2

Impacted Files
Coverage Δ

src/meshcat/commands.py
93.93% <100%> (+0.6%)
:arrow_up:

src/meshcat/geometry.py
86.81% <56%> (+0.22%)
:arrow_up:

src/meshcat/tests/test_ports.py
91.3% <91.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49fd691...c62504f. Read the comment docs.

authors: codecov-io rdeits

repo: rdeits/meshcat-python


text:
Issue #25: Ensure only needed files are packaged

This is a proposal to solve the issue of packaging unnecessary files.
It is achieved by moving the types to a src directory and building the types into a dist directory identified in package.json's files.
https://github.com/rdfjs/types/compare/master...matthieubosquet:rdfjs-types:packaging#
I updated the GitHub actions and simplified the tsconfig to accommodate those changes.
Running npm pack packages the files as shown in below screenshot:

It certainly would be a simple solution but making the configuration and packaging more complex seems detrimental to long term maintainability of this project. Hence my choice of moving files to a familiar and widespread directory structure.

Thanks for the PR @matthieubosquet!
It does look like this PR does much more than just fixing #44.
I'm sure they are valuable, but in order to keep our commit history valid, we may want to apply these changes incrementally.
I'm also in favor of the files entry approach. I don't mind the current directory structure (without dist) tbh.

authors: matthieubosquet rubensworks

repo: rdfjs/types

license: MIT

license_source: github-api


text:
CLI Sync runs every instance of the plugin

Running CLI Sync mode runs every instance of the plugin.
When I have two or more instances of the plugin in my docusaurus.config.js  and I use the CLI Sync mode with
docusaurus download-remote-fakeRepoOne it actually runs every instance of the plugin.
Related to:
https://github.com/rdilweb/docusaurus-plugin-remote-content/issues/45

Will fix this later today.

After doing some investigating, it appears this only happens if noRuntimeDownloads is disabled.  Can you check if that is the case in your config?

Setting noRuntimeDownloads: true does fix the issue.

Worth noting that this is still a bug, one which will require a pretty ugly hack.

authors: RDIL motionsuggests


text:
fix(Events): Support for multiple context parameters

https://github.com/rdkcentral/firebolt-openrpc/issues/91

:tada: This PR is included in version 2.0.0-next.3 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: rdkcentral/firebolt-openrpc


text:
XIONE-1555: ContinueWatching API fails

Reason for change: Return token correctly
Test Procedure: Run curl commands from ticket.
Risks: Low
Signed-off-by: Mark Vandenbriele mark.vandenbriele@consult.red

Cleaning up older PRs. Please create new PR on latest sprint if required.

authors: MarkVandenbriele anand-ky

repo: rdkcentral/rdkservices


text:
Add catagory name to gst logs

Summary: Print the category name of the logging component.
Type: Feature
Test Plan: Youtube Cert Tests
Jira: N/A

https://jenkins.code.rdkcentral.com/job/github-triggered/34416/ started

https://jenkins.code.rdkcentral.com/job/build-component/72309/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/2515/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/5293/ started.

Sanity tests for ['RPI3 Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/12108/

Sanity tests for ['RPI3 Hybrid/MC'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/12109/

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/12112/

authors: rdkcmf-jenkins skywilliamsonl

repo: rdkcentral/rialto


text:
[WIP] Add More standard protonation sates of HIS

Introduce HIE, HID, HIP residues to bond order matching.

@mwojcikowski : I haven't reviewed this since it's marked as WIP. Let me know when you'd like an actual review. I'm happy to take a look before it's done if you want.

I'm thinking of going further with this since there are a lot of problems with current implementation. If you came across unknown (unless to RDKit) residue, then all bonds are single, which leads to terrible connectivity, like hydrogenated backbone O. How do you feel about extending the list of less common residues? (only protein ones)
I'd have to go through loads of PDBs to catch most of them and see what we can do about it.

Having support for non-standard, but common, residues would certainly be reasonable.
It's probably worth thinking at some point about providing a mechanism for client code to provide their own list of residues and definitions, but that's likely not for this PR.

authors: greglandrum mwojcikowski

repo: rdkit/rdkit


text:
🛑 RDPStudio Commuinty 社区 is down

In 9130b6f, RDPStudio Commuinty 社区 (https://rdpstudioforum.flarum.cloud) was down:

HTTP code: 500
Response time: 845 ms

Resolved: RDPStudio Commuinty 社区 is back up in 91d6014.

repo: rdp-studio/status


text:
🛑 SuperPi@Home is down

In 9fc9ac3, SuperPi@Home (https://piathome.utools.club) was down:

HTTP code: 0
Response time: 0 ms

Resolved: SuperPi@Home is back up in 1a43e4b.

repo: rdp-studio/upptime


text:
Add more id3 v2.4 support details.

Summary
This is a…

[ ] Correction
[ ] Addition
[ ] Restructuring
[x] Minor / simple change (like a typo)
[ ] Other

Reason for the Change
Give more info for Windows users.
Description of the Change
SoftPointer AudioShell 2
Additional Action Required
We could probably do with a special page covering support for various music and tagging formats under various software under various operating systems.

I'm not disputing the information, but I'm not sure that I understand how it really applies to Picard and adds value to the documentation -- especially stating that an update from Microsoft is supposed to provide support but hasn't been verified.  Can you help me understand?  Thanks.

It adds value by helping users decide which version of ID3v2 tagging to use.
I have AudioShell 2 installed and my music is tagged with ID3v2.3 so I have no idea whether newer versions of WIndows 10 display ID3v2.4 tags in File Explorer or not. I suppose I can test it if you wish so we can make this statement a bit more definitive rather than totally wishy-washy, but without testing it on various back-level versions of Windows 10 (though I may have a virtual Windows 10 image of 1709 that I keep for a specific application) I am not sure that we can be completely definitive.
P.S. Regarding a special page covering support for various music and tagging formats by various players / file explorers, I still think it is a useful idea, but I suspect that the maintenance effort may be too large to be acceptable.

Thanks.  That helps.  Also, I don't think it's fair to ask you to go out of your way to do any amount of testing.

P.S. Regarding a special page covering support for various music and tagging formats by various players / file explorers, I still think it is a useful idea, but I suspect that the maintenance effort may be too large to be acceptable.

Yeah, I need to think about that a bit.  I see the potential value, but keeping it up-to-date would probably be a nightmare.  It would really require input from users of all the different systems and software, and we haven't yet achieved any sort of critical mass of contributors to sustain what we already have.  I'm afraid that it would rapidly become outdated and reflect incorrect information, and in my mind that's worse than no information at all.
@zas / @phw:  Any comments on this PR and the topics raised in the discussion?

Yeah, I need to think about that a bit. I see the potential value, but keeping it up-to-date would probably be a nightmare. It would really require input from users of all the different systems and software, and we haven't yet achieved any sort of critical mass of contributors to sustain what we already have. I'm afraid that it would rapidly become outdated and reflect incorrect information, and in my mind that's worse than no information at all.

I am a great believer (as far as Open Source is concerned) that if you ask the community for help a significant part of it will step up to the mark.
So if we were to have such a page, we would need to encourage such involvement by heading it up with a statement that the page is entirely community written and supported and ask people to correct anything that they find is inaccurate and to add anything that they find is missing.
We could even give it a try and see (over the first 6 or 12 months) whether it gets supported or not, and if not we will remove it. And we could add a statement saying that this is a trial so please contribute.

I am a great believer (as far as Open Source is concerned) that if you ask the community for help a significant part of it will step up to the mark.

I'd really like to believe that, but so far that has not been the case with this documentation project.  I have repeatedly asked in the MetaBrainz Community Forum for people to have a look at the docs and let us know if they find something that is wrong, isn't clear, could be improved, or should be added.  I'm not naive enough to think that it's flawless.  So far, you are pretty much the only one that has responded.
I manually did the French translation by myself using Google Translate (because I don't speak French), and asked on the Forum for people to have a look and let me know where the translation is incorrect or could be improved.  Not a single comment.  Same thing with my call for volunteers to help translate into another language or act as translation leads.  Nada.

So if we were to have such a page, we would need to encourage such involvement by heading it up with a statement that the page is entirely community written and supported and ask people to correct anything that they find is inaccurate and to add anything that they find is missing.

Okay, I'm prepared to give it a try, but suggest that we maybe include it as its own section (Appendix D) to make it a bit more prominent than including it in the configuration page that you originally suggested.  Would a title / topic of "System / Player Compatibility" be appropriate?  This could then provide a chart or listing of the systems and players and the relevant configuration settings and other notes to have Picard properly tag the files to work with that system / player.  This appendix could then be referenced in the appropriate locations throughout the rest of the document, such as "configuration" and "troubleshooting".  What do you think?

We could even give it a try and see (over the first 6 or 12 months) whether it gets supported or not, and if not we will remove it. And we could add a statement saying that this is a trial so please contribute.

To get a sense of the level of support, perhaps we could start a new topic in the Forum stating that we'd like to include this information in the Picard Documentation, explain what information we're looking to include, and ask the Community to provide the input to develop the initial page / section?  People could provide their input there and we could transfer it to the new appendix once there are a few entries to make it worthwhile (and continue to add as the information comes in).  We would also know who responded so that we could be sure to add them to the list of contributors in the documentation.  Do you think this has a chance of working, or do you have another suggestion?

The content of such a section might be something like:
Browser Name (os platforms)
Picard Configuration Settings
This would include things like tag type and any other relevant settings such as embedding coverart, etc.
Notes / Considerations
This could include things like recommended best practices, or information such as your note about Windows 10 update possibly correcting an issue.

I was thinking more about a simple table - music file format across the top, o/s & app down the side - cells containing details of what is supported.
As for getting people to contribute, it is all about how you pitch it - here is what I might say...
"We would like to help more people use Picard more effectively by helping them understand how they can utilise the tags in their music files that Musicbrainz and Picard generate. And this page is our attempt at doing this. HOWEVER...
The Picard applications is entirely written and supported by a small number of unpaid volunteers - what we can do is limited by how much help we can get. In particular we do not have the time or resources to document every application that can be used to look at or play the files tagged by Picard or how to configure Picard and these applications to make best use of the metadata.
This is where YOU come in...
If you want to find out what software works best with Picard tagged files, please feel free to use this page to find out what other people have tried (hopefully avoiding re-inventing the wheel). If in the end you find that your own experience is NOT documented here, please please pay forward the help you got by updating this page with your own experiences in order to help other people in the future.
And of course, if you want to contribute to improving other pages of this documentation, or help with Picard / Picard plugin development, or to help maintain the massive Musicbrainz database of metadata that drives the whole process, then your help there would also be very welcome."

I was thinking more about a simple table - music file format across the top, o/s & app down the side - cells containing details of what is supported.

Something like the following (sample data not verified but for demonstration purposes only), or were you somehow intending to intermix the file formats like WAVE, MP3, etc.?

ID3v2.3
ID3v2.4
APEv2
RIFF

Windows Explorer
X
Note 1

X

MediaMonkey
X
X
X

Foobar2000
X
X

DeaDBeef
X
X

Notes:

Windows 10 Creators Update v1703 onwards is supposed to support the reading and display of ID3 v2.4 tags in Windows Explorer, though this has not been verified.  In earlier versions of Windows, support in Windows Explorer can be added using
SoftPointer AudioShell 2.

As for getting people to contribute, it is all about how you pitch it - here is what I might say...

Sounds good.  How much in the Appendix page, and how much in the Community Forum posting?

Yes - a bit like that table but...
Columns: mp3 ID3v2.3, mp3 ID3v2.4, FLAC, AAC etc.
But I do worry that the learning curve for Github and the markup language might be too steep - perhaps a sticky community topic where people can document their experiences less formally using some basic template and we can then add to our page every so often based on that.

Columns: mp3 ID3v2.3, mp3 ID3v2.4, FLAC, AAC etc.

You do realize that there are currently 22 file formats supported, comprising 34 different file extensions.  Depending how you look at it, that's either 23 or 35 columns, including the first column specifying the browser/player.  Not exactly conducive to display as a table on a web page.

But I do worry that the learning curve for Github and the markup language might be too steep - perhaps a sticky community topic where people can document their experiences less formally using some basic template and we can then add to our page every so often based on that.

That's actually what I had in mind, to make it as easy as possible for people to contribute.
I still don't know how we would effectively show this as a 35 column (or even 23 column) table without massive scrolling.  This becomes even worse as the table becomes longer (more lines), because the scroll bar shows at the very bottom of the table on the web page, and the user will typically lose track of which line they are trying to track if they have to scroll it off the screen to get to the horizontal scroll bar.  That is why I ended up reformatting the mapping table in Appendix B.
We could offer this as a spreadsheet or stand-alone web page, which is what I have done with the tag mapping information.  The links are shown in the opening paragraph when displaying the Appendix B page in the on-line User Guide.
The information is maintained in a Python file and the spreadsheet, stand-alone web page and restructured-text file for the User Guide (website, epub and pdf outputs) are rebuilt automatically whenever an update to the site is published.  @phw and I reviewed our options for presenting the information in a tabular format and this is what we decided to use.  This also makes it fairly easy to maintain and check the information before publishing.  Perhaps not ideal, but it does offer the users three different alternatives for viewing the information -- each with its own strengths and weaknesses -- so they can choose which best suits them.  All this while we only have to maintain the information in one place.

authors: Sophist-UK rdswift

repo: rdswift/picard-docs


text:
navigationOptions does not work when it is a function

just discovered this package, and i'm trying to follow the getting started tutorial on the docs. whenever i make navigationOptions a function that returns an object instead of a plain object, the header doesn't show anything but a button to go to the previous screen on the stack. also, adding a button to the header with headerRight doesn't work either. here's my code:
// App.js

import React, { Component } from 'react';
import {
  Button,
  Text,
  View
} from 'react-native';
import { StackNavigator } from 'react-navigation';

class HomeScreen extends Component {
  static navigationOptions = {
    title: 'welcome'
  };
  render() {
    return (
      <View>
        <Text>hello, navigation</Text>
        <Button
          onPress={() => this.props.navigation.navigate('chat')}
          title='chat with alice'
        />
      </View>
    );
  }
}

class ChatScreen extends Component {
  // this works
  static navigationOptions = {
    title: 'chat with alice'
  };

  // // this works, but the button does not show
  // static navigationOptions = {
  //   title: 'chat with alice',
  //   headerRight: <Button title='info'/>
  // };

  // // this does not work at all
  // static navigationOptions = ({ navigation }) => ({
  //   title: `chat with ${navigation.state.params.user}`
  // });

  render() {
    return (
      <View>
        <Text>chat with alice</Text>
      </View>
    );
  }
}

const App = StackNavigator({
  home: { screen: HomeScreen },
  chat: { screen: ChatScreen }
});

export default App;

running into this issue on both iOS and Android. am i missing something obvious? i used crna setup the project if that makes a difference. here are my installed dependencies, and let me know if there's any other extra info i should share.
{
  "devDependencies": {
    "jest-expo": "^0.3.0",
    "react-native-scripts": "0.0.27",
    "react-test-renderer": "~15.4.1"
  },
  "dependencies": {
    "expo": "^15.1.0",
    "react": "~15.4.0",
    "react-native": "0.42.3",
    "react-navigation": "^1.0.0-beta.7"
  }
}

Same here, just spotted it is not called

Not working on Android Emulator when placed inside the StackNavigator config (instead of being a static property) object as well.

The new version isn't released yet. Try get this library from master and it should work

i can confirm that this works; did a yarn add https://github.com/react-community/react-navigation and everything's looking good. thanks @ms88privat!

Now that 1.0.0-beta.9 is released, npm update fixed the problem for me.

authors: CvBlixen Rewieer ms88privat reinisriekstins thekelvinliu

repo: react-community/react-navigation


text:
Tab Navigator icons not showing

I try to set icons to tabs but these aren't shown. There are only green squares. I have no idea what to do.
It's my first time I try to set icons to tabs.
:   (
import { StyleSheet, View, Text } from "react-native";
import { TabNavigator } from "react-navigation";
import FontAwesome, { Icons } from "react-native-fontawesome";
import Colors from "../miscellaneous/colors";

const styles = StyleSheet.create({
	tab: {
		padding: 5
	},
	indicator: {
		width: 0,
		height: 0
	},
	label: {
		fontSize: 10
	},
	icon: {
		width: 20,
		height: 20,
		backgroundColor: "green"
	},
	tabBar: {
		backgroundColor: Colors.darkBlue,
	}
});

export const MainNavigator = TabNavigator(
	{
		Videos: {
			screen: VideosScreen,
			navigationOptions: ({ navigation }) => ({
				title: "Videos",
			})
		},
		ScoresAndOdds: {
			screen: ScoresAndOddsNavigator,
			navigationOptions: ({ navigation }) => ({
				title: "Scores & Odds",
				icon: ({ tintColor }) => <FontAwesome>{Icons.times}</FontAwesome>
			})
		},
		Picks: {
			screen: PicksScreen,
			navigationOptions: ({ navigation }) => ({
				title: "Picks",
			})
		},
		MyScores: {
			screen: MyScoresScreen,
			navigationOptions: ({ navigation }) => ({
				title: "My Scores",
			})
		}
	},
	{
		initialRouteName: "ScoresAndOdds",
		tabBarPosition: "top",
		swipeEnabled: true,
		animationEnabled: true,
		lazy: true,
		order: ["Videos", "ScoresAndOdds", "Picks", "MyScores"],
		backBehavior: "initialRoute",
		tabBarOptions: {
			activeTintColor: Colors.white,
			inactiveTintColor: Colors.transparentWhite,
			showLabel: true,
			showIcon: true,
			upperCaseLabel: false,
			pressColor: Colors.transparentWhite,
			scrollEnabled: false,
			tabStyle: styles.tab,
			indicatorStyle: styles.indicator,
			labelStyle: styles.label,
			iconStyle: styles.icon,
			style: styles.tabBar
		}
	}
);

React Native 0.44

It's triple to put code into a block. One is only for a line

@tiaaaa123 , thanx for help, but could you help me with my real problem? :   )

Possible cause: indicatorStyle of width: 0, height: 0. I would recommend use backgroundColor: 'transparent'. It all depends of how the bottom line is implemented. But at the same time, it's only for Android... I haven't used much of react-navigation (and I tried using tabRouter).. So I can't help you much... sorry

@mocanSergiu666
I have the same problem.

The problem was that I used "icon" instead of "tabBarIcon".
Correct example:
tabBarIcon: ({ tintColor }) => <FontAwesome style={{ color: tintColor }}>{Icons.videoCamera}
The issue will be closed by me.

I got the same issue event using tabBarIcon.
My code:
static navigationOptions = {
    tabBarIcon: () => (
      <Image
        source={require('@assets/icons/home.png')}
        style={CommonStyles.tabBarIcon}
      />
    )
  }

Hi @huyb1991 , I had the same issue and changed the syntax to fix it.
Have you tried removing the wrapping parentheses so that you return directly the <Image> component?
Like so:
tabBarIcon: () =>       <Image         source={require('@assets/icons/home.png')}         style={CommonStyles.tabBarIcon}       />

it show on iOS but not Android

full code:
import React from 'react';
import { View, Text, StyleSheet, Button, Image } from 'react-native';
import { StackNavigator, TabNavigator } from 'react-navigation';

class MyHomeScreen extends React.Component {
  static navigationOptions = {
    tabBarLabel: '开始放大',
    // Note: By default the icon is only shown on iOS. Search the showIcon option below.
    tabBarIcon: ({ tintColor }) => (
      <Image
        source={require('./assets/add.png')}
        style={[styles.icon, { tintColor: tintColor }]}
      />
    ),
  };

  render() {
    return (
      <Button
        onPress={() => this.props.navigation.navigate('Notifications')}
        title="Go to notifications"
      />
    );
  }
}

class MyNotificationsScreen extends React.Component {
  static navigationOptions = {
    tabBarLabel: '放大记录',
    tabBarIcon: ({ tintColor }) => (
      <Image
        source={require('./assets/history2.png')}
        style={[styles.icon, { tintColor: tintColor }]}
      />
    ),
  };

  render() {
    return (
      <Button
        onPress={() => this.props.navigation.goBack()}
        title="Go back home"
      />
    );
  }
}

class ProfileScreen extends React.Component {
  static navigationOptions = {
    tabBarLabel: '账号设置',
    tabBarIcon: ({ tintColor }) => (
      <Image
        source={require('./001-settings.png')}
        style={[styles.icon, { tintColor: tintColor }]}
      />
    ),
  };

  render() {
    return (
      <Button
        onPress={() => this.props.navigation.goBack()}
        title="Go back home"
      />
    );
  }
}

const styles = StyleSheet.create({
  icon: {
    width: 26,
    height: 26,
  },
});

const MyApp = TabNavigator({
  Home: {
    screen: MyHomeScreen,
  },
  Notifications: {
    screen: MyNotificationsScreen,
  },
  Profile: {
    screen: ProfileScreen,
  },
}, {
    tabBarPosition: 'bottom',
    animationEnabled: true,
    // tabBarOptions: {
    //   activeTintColor: '#e91e63',
    // },
  });

export default MyApp;

@1c7
For Android you should set showIcon in tabBarOptions to true (it's false by default):
https://reactnavigation.org/docs/navigators/tab#tabBarOptions-for-TabBarTop-default-tab-bar-on-Android
It might be beneficial to create separate tabBarOptions for the different platforms. I.e. you might want to do something like this:
import { Platform } from 'react-native'

const tabBarOptions = Platform.OS === 'ios' ?
  {
    // iOS tabBarOptions
    showLabel: true
  } : {
    // Android tabBarOptions
    showIcon: true,
    showLabel: true
  }

@northern Thank you!

@northern it work!

thanks for @northern and @1c7 . I got same issue .

My Icons are cutting off only on android and I cannot figure out why...
Here is the code for tabNavigation.js:
`const HomeTabNavigation = TabNavigator(
{
Profile: { screen: Profile },
PhotoCard: { screen: PhotoCard },
Chat: { screen: Chat }
},
{
tabBarPosition: "bottom",
tabBarComponent: TabBarBottom,
initialRouteName: "PhotoCard",
swipeEnabled: false,
lazy: true,
tabBarOptions: {
showIcon: true,
showLabel: false,
style: {
backgroundColor: 'white',
borderTopColor: 'white',
borderTopWidth: 1,
height: metrics.DEVICE_HEIGHT * 0.08
},
tabStyle: {
width: metrics.DEVICE_WIDTH * 0.33333333333333333333333333333333333333333,
height: metrics.DEVICE_HEIGHT * 0.08,
},
indicatorStyle: {
backgroundColor: 'white',
width: 0,
height: 0,
padding: 0,
margin: 0
},
},
}
);
export default (HomeTabNavigation);`
Here is the code for index.Js in PhotoCard:
static navigationOptions = {     tabBarIcon: ({ focused }) => (       focused        ? <Text style={styles.activeText}>Let'sWait</Text>       : <Text style={styles.inActiveText}>Let'sWait</Text>     )   }

Didn't know that. Thanks man!

import { TabNavigator,TabBarBottom , StackNavigator } from 'react-navigation';
import {Icon} from 'native-base';
.
.
.
export const Tabs = TabNavigator({
Feed: {
screen: tab1,
navigationOptions: {
tabBarLabel: 'label',
tabBarIcon: ({ tintColor }) => ,
},
},
Me: {
screen: tab2,
navigationOptions: {
tabBarLabel: 'Me',
},
},
},
{
tabBarOptions: {
activeTintColor: 'red',
inactiveTintColor: 'gray',
style: {
backgroundColor: '#EEEEEE',
},
showIcon: true,
showLabel: true
},
tabBarComponent: TabBarBottom,
tabBarPosition: 'bottom',
animationEnabled: true,
swipeEnabled: true,
});

@Unlighten did you figure this out?  If so, what is your solution? I am still experiencing wonky behavior where my icon is getting cutoff

Having this problem too! Icons cutting off.

Look up this medium article here: https://medium.com/@c.nwaugha/how-to-show-an-icon-with-react-navigation-tab-navigator-ea9b653241e1

Adding width to icon style fixes the icon from getting cut off.
I.e.


text:
根据 #29 关闭出场动画后，原本该被出场删除的元素未被删除

如图，数据是父组件 ajax 异步 props 过来的，都设置有唯一稳定的 key，请求后新数据入场，旧数据没被删除，onEnd 事件也没有旧数据的出场回调，如果不设置  interval={[100, 0]} duration={[450, 0]} 旧数据在动画完成后会被删除！

请求后新数据入场，旧数据没被删除，

没懂! 旧数据是还保留着的吗？

好的，我调试出来了，我看下什么问题。。。

1.6.2

@jljsj33 不会消失的问题修复了，但是还有 BUG，我开个 issues 写 demo 你看看

repo: react-component/queue-anim


text:
feat: Add a stream interception to the onDragOver event

The Question：
Calls when an element has been dropped into the grid from outside，The trigger frequency of ondragover events is too high, causing the problem of stuck

The Solution:
ondragover adds interception
The Effect

Please don't commit package.json changes and built files.

Please, keep in mind that inside onDragOver handler end user could  do some actions to affect dnd process, e.g. apply e.dataTransfer.dropEffect, which affects visual look of mouse pointer, ability to dop (e.g. prevents drop if set to 'none') and could be used later in onDrop handler.
If onDragOver is throttled - dropEffect will be applied not immediately and this could produce bugs in end-user applications.
So, in my opinion only re-render of grid layout could be trottled to improve performance, but all DnD-related staff (like call of onDragOver handler etc.) should be handled immediately. In other way - there is very high risk of various DnD bugs for the end users.

authors: STRML avasuro githubobil

repo: react-grid-layout/react-grid-layout


text:
Redirect uri is not working

Describe the bug

To Reproduce

Expected behavior

Screenshots

Smartphone

Device:
OS:
Version

Additional context

Hello.
It is working well. Check your Keycloak server configuration for the redirect and remember that the URL must be the same on client and server, otherwise it will not working

Underscores can’t be used in domain names, as the underscore character isn’t permitted.

authors: IronTony aarpitgoel

repo: react-keycloak/react-native-keycloak


text:
iOS 13 New UI close button doesn't reject promise

Steps to reproduce
On iOS 13 we have issue with new close button:
If user clicks on new iOS 13 UI close button - .catch() callback doesn't fire, so Promise is not rejected in this case. On iOS 12 with previous UI Cancel button it works correctly
Expected behaviour
catch callback should be called, promise should be rejected.
Actual behaviour
catch callback is not called, promise is not rejected.
Environment

React Native version: 0.61.2
React Native platform + platform version: iOS 13.0

react-native-share
Version: 2.0.0"

I have the same issue. Looks like IOS 13 updated Share menu has uncompleted functionality

I have the same issue. Looks like IOS 13 updated Share menu has uncompleted functionality

Yep, looks like for new iOS 13 UI "react-native-share" need a small patch to handle new "close" icon and throw an exception like on iOS 12

@oleksandr-dziuban I think we need a major release after fixing this. 🤔
Also do you have any clue on the new "Modal" event can be handled?

@MateusAndrade Yes, I think new major version is OK.
New Modal works fine, just we have this issue with close button + swipe down gesture.
Also one more weird issue: when we select "Save Image" we can see rejected Promise and error
"No callback found with cbID 6377 and callID 3188 for ActionsSheetManager.showShareActionSheeyWithOptions - most likely callback was already invoked"
I think this is broken behavior too now with iOS 13

New Share Menu is one of the biggest breaking changes in iOS 13

Also experiencing this, any ideas on a fix? We aren't able to implement this library on our app because of the crash.

Just library should be fixed according to latest iOS 13 changes. For this we need ask maintainers to fix this

Anyone interested on working on this fix?

Same issue here. The broken behavior for Save Image and Save to Files options. iOS 13.

@jgcmarins I'll open a PR for the promise not resolving when the sharesheet is dismissed by the user. After that a new release needs to be made, #584 and #586 both fixed crashes on iOS 13 but haven't made it into a new release.

@tomtargosz Thanks a lot!

@tomtargosz Could you please publish the new version?

We plan to release a new version as soon as possible.
Could you use master branch to check if everything is fine?

@tomtargosz When the new version with this fix will be available?

@Simek I'm just a contributor so I don't have the permissions to create a release. @oleksandr-dziuban can you confirm that your issues are now resolved with the fixes merged into master? After that @jgcmarins should be good to make a new release 👍

@tomtargosz I can confirm that code from master do not produce error in our project based on RN 60.6 on iOS 13.1.3.

@tomtargosz Same for me, issue fixed, please publish new release. Thanks

@oleksandr-dziuban, @Simek, @tomtargosz  thanks for letting us know that the master version looks stable. I got really busy on the last weeks, and cannot give the proper attention to react-native-share.
If anybody can help me testing the master version, i can plan a release on the next week. Please, let me know if anynone find anything related to the master version that can be a breaking change or even a bug. :smiley:

Easy to reproduce on iOS 13:

On share dialolg, select Messages like you are about to SMS text PDF
Press Cancel (or Send)

2019-11-06 12:37:09.327 [fatal][tid:main] Illegal callback invocation from native module. This callback type only permits a single invocation from native code.
2019-11-06 12:37:09.327451-0600 UtiliGuard[14029:3724994] Illegal callback invocation from native module. This callback type only permits a single invocation from native code.

Using:
    "react": "^16.9.0",
    "react-native": "0.60.6",
    "react-native-pdf": "5.1.7",

@esutton Unfortunately since that fix has been merged there was no release published.
Until then you can replace react-native-share version string with http://react-native-community/react-native-share (this will use master branch from GitHub repository which include the fix but may be unstable in long run).
More information: https://docs.npmjs.com/files/package.json#git-urls-as-dependencies

@Simek Thanks.
Stability was definitely a concern so I used the commit hash in my package.json
Master fixed it at d88e542ddd0983d09a4aa1a82737bb05b5731801
    "react-native-share": "https://github.com/react-native-community/react-native-share#d88e542ddd0983d09a4aa1a82737bb05b5731801",

@esutton No problem. Just a tip - you can simplify your version string to:
    "react-native-share": "react-native-community/react-native-share#d88e542",

authors: MateusAndrade Simek YuraPostevka esutton jgcmarins oleksandr-dziuban toddychen tomtargosz zachrnolan


text:
integration with react-native-video, missing React headers

Hi, I'd like to implement video playback in my TVOS app. I used react-native-tvos to init a project then runs in the apple TV simulator. I npm installed react-native-video which requires manually linking RCTVideo.a in Xcode. However, after adding it, the build fails with missing React headers. For example React/RCTViewManager.h file not found in RCTVideoManager.m.
I don't think it's necessarily an issue with this repo, just wondering if anybody has had similar issues or knows how to fix. Maybe this repo needs to be synced with newest react-native?
I have added custom header search paths, unchecked paralellize build and added React in custom build order, tried editing podfile, different versions ,etc.
Any help or even another good video playback solution appreciated.

I would not try to manually link the binary.... apps using current and recent versions of React Native should use Cocoapods to bring in dependencies like react-native-video.
See this example project: https://github.com/dlowder-salesforce/RNAppleTVTalk
In particular, look at package.json and iOS/Podfile.

Thanks for the quick reply. You have a tvOS project using react-native-video... awesome!!
I think I was just missing the line that adds react-native-video as a pod in the Podfile? I've added and reinstalled pods.
I'm getting black screen for the  component, but idk if it's a build issue, my environment, my code or a bug at this point. I'll keep digging. If nothing else I should be able to reference your Apple TV talk project to figure it out.
Thanks for this repo, I've almost got a fully functional video streaming app!

Great to hear -- good luck with the app :)

authors: dlowder-salesforce jerrolb


text:
Menu disappears in 0.15.2

I upgraded to 0.15.2 because I saw it fixed #127
However now I can't see the menu.

+1 experienced the same thing earlier.

How to reproduce it?

And well, I'm a bit confused: 0.15.2? I can find only 0.15.0-rc

I tried npm info react-native-side-menu versions. 0.15.2 is there.

Ah, sorry, I though you're talking about RN version :laughing:
So, what about it, btw? Which RN version are you using?

@yifeic you experience this with this example?

@Kureev Yes. And I changed the "react-native-side-menu": "Kureev/react-native-side-menu#bug/side-menu-shows-first" to 0.15.2

0.15.3 has been released with a fix from @xxsnakerxx

authors: Kureev cbrevik yifeic


text:
Upload through fetch

Any suggestions on uploading an image to a server using fetch?

Not quite there yet with our react native project. I'm mostly a front-end guy. Will post here once we have it sending the photos to our server.

@mschipperheyn I think you must have found it by now. if you havent you can use https://github.com/booxood/react-native-file-upload

Here's my approach if anyone is curious:
var options = {
title: 'Upload image',
cancelButtonTitle: 'Cancel',
takePhotoButtonTitle: 'Take Photo...',
chooseFromLibraryButtonTitle: 'Choose from Library...',
returnBase64Image: true,
returnIsVertical: false
};
UIImagePickerManager.showImagePicker(options, (type, response) => {
if (type !== 'cancel') {
var source;
if (type === 'data') {
source = {uri: 'data:image/jpeg;base64,' + response, isStatic: true};
} else {
source = {uri: response};
}
    console.log("uploading image");

     fetch('my-server-endpoint',{
       method: 'post',
       body: "data=" + encodeURIComponent(source.uri)
     }).then(response => {
       console.log("image uploaded")
       console.log(response)
     }).catch(console.log);

    //this.setState({avatarSource:source});
  } else {
    console.log('Cancel');
  }
});

Simply use decodeURIComponent on the server to get the image data

Thanks @darkrishabh and @sorenbs...closing this.

Anyone have experience uploading to a Django backend? I keep getting image is not a file when i send the post request as image: source.uri
I've tried encoding it but that didn't work either. I'm not very familiar with Django so not sure what it expects for an image.

@MikaelCarpenter I'm experiencing the same issue, have you managed to solve it?

Let's continue this discussion on #31 - I just posted a comment.

@sorenbs Can you please share your code sample on the backend too? Thanks!

Any body solved this React Native to Django backend image upload?  I am using fetch and multipart-form.  It works on iOS simulator with Expo XDE.  But it fails on Android.

I want to upload the selected image to my server here is my code...
anyone can help?
async function getUser() {
try {
const response = await axios.post(
'https://mysite.com/api/v1/idimage'
);
console.log(response);
console.log(response.status);
          navigation.navigate('NationalIDCard');
        } catch (error) {
          console.error(error);
        }
      }
      getUser();

import React, {Fragment, Component} from 'react';
import ImagePicker from 'react-native-image-picker';
import {
SafeAreaView,
StyleSheet,
View,
Text,
StatusBar,
Image,
Button,
Dimensions,
TouchableOpacity,
} from 'react-native';
import IconAD from 'react-native-vector-icons/AntDesign';
import IconSLI from 'react-native-vector-icons/SimpleLineIcons';
import DateTimePickerModal from 'react-native-modal-datetime-picker';
import {
Colors,
} from 'react-native/Libraries/NewAppScreen';
export default class NationalIDCard extends Component {
constructor(props) {
super(props);
this.state = {
filepath: {
data: '',
uri: '',
},
fileData: '',
fileUri: '',
};
}
chooseImage = () => {
let options = {
title: 'Select Image',
  storageOptions: {
    skipBackup: true,
    path: 'images',
  },
};
ImagePicker.showImagePicker(options, response => {
  console.log('Response = ', response);

  if (response.didCancel) {
    console.log('User cancelled image picker');
  } else if (response.error) {
    console.log('ImagePicker Error: ', response.error);
  } else {
    const source = {uri: response.uri};

    // You can also display the image using data:
    // const source = { uri: 'data:image/jpeg;base64,' + response.data };
    // alert(JSON.stringify(response));
    // console.log('response', JSON.stringify(response));
    this.setState({

      filePath: response.path,
      fileData: response.data,
      fileUri: response.uri,
    });
    console.log(response.path);
  }
});

};
renderFileData() {
if (this.state.fileData) {
return (
<Image
source={{uri: 'data:image/jpeg;base64,' + this.state.fileData}}
style={styles.images}
/>
);
} else {
return (

<IconAD name={'upload'} size={150} color={'#707070'} />

);
}
}
state = {visibility: false, DateDisplay: 'Enter Expiry Date'};
handleConfirm = date => {
this.setState({DateDisplay: date.toString()});
};
onPressCancel = () => {
this.setState({visibility: false});
};
onPressButton = () => {
this.setState({visibility: true});
};
pressHandlerContinue = () => {
this.props.navigation.navigate('Welcome');
};
render() {
return (

<View
style={{
flex: 0.2,
justifyContent: 'center',
alignItems: 'center',
}}>
Add National ID card

<View
style={{
flex: 0.5,
justifyContent: 'center',
alignItems: 'center',
}}>
{this.renderFileData()}

      <View style={styles.btnParentSection}>
        <TouchableOpacity
          onPress={this.chooseImage}
          style={styles.btnSection}>
          <Text style={styles.btnText}>Choose File</Text>
        </TouchableOpacity>
       <Text style={{fontSize:16,fontWeight:'700'}}>
         {'Enter Expiry Date: '}
       </Text>
        <TouchableOpacity
          onPress={this.onPressButton}
          style={{
            flexDirection: 'row',
            justifyContent: 'center',
            paddingLeft: 10,
            width: '80%',
            alignItems: 'center',
            borderWidth: 1,
          }}>
          <IconSLI name="calendar" size={20} color="#6F6F6F" />
          <Text
            style={{
              height: 50,
              width: '95%',
              textAlignVertical:'center',
              color: '#707070',
              padding:15
            }}>
            {this.state.DateDisplay}
          </Text>
          <DateTimePickerModal
            isVisible={this.state.visibility}
            onConfirm={this.handleConfirm}
            onCancel={this.onPressCancel}
            mode="date"
          />
        </TouchableOpacity>
      </View>
      <View
        style={{
          flex: 0.1,
          justifyContent: 'center',
          alignItems: 'center',
        }}>
        <TouchableOpacity
          onPress={this.pressHandlerContinue}
          style={{
            backgroundColor: '#FD941E',
            height: 50,
            width: '80%',
            justifyContent: 'center',
            alignItems: 'center',
          }}>
          <Text style={{fontSize: 20, color: '#ffffff'}}>
            CONTINUE TO HOME
          </Text>
        </TouchableOpacity>
      </View>
    </View>
  </Fragment>
);

}
}
const styles = StyleSheet.create({
body: {
flex: 1,
backgroundColor: Colors.white,
height: Dimensions.get('screen').height - 20,
width: Dimensions.get('screen').width,
},
title: {
fontWeight: 'bold',
fontSize: 20,
margin: 10,
},
images: {
width: 300,
height: 400,
borderColor: 'black',
borderWidth: 1,
alignSelf: 'center',
justifyContent: 'center',
alignItems: 'center',
},
iconStyle: {
width: 300,
height: 400,
borderColor: 'black',
borderWidth: 1,
alignSelf: 'center',
justifyContent: 'center',
alignItems: 'center',
},
btnParentSection: {
flex: 0.2,
alignItems: 'center',
marginTop: 30,
},
btnSection: {
width: '80%',
height: 50,
backgroundColor: '#DCDCDC',
alignItems: 'center',
justifyContent: 'center',
borderRadius: 3,
marginBottom: 10,
},
btnText: {
textAlign: 'center',
color: 'gray',
fontSize: 14,
fontWeight: 'bold',
},
});

authors: MikaelCarpenter MuhammadArsalan472121 Settao alvaromb darkrishabh marcshilling mschipperheyn percyteng sorenbs


text:
Support for PHPickerViewController

Motivation
This PR adds support for the iOS 14 PHPickerViewController to address Issue #1428
Test Plan
Tested using the included example app to load images/videos and verify that the output matches that of the original.

Thanks for the PR, I'll see if I can squeeze in some testing soon and revert back.

@JanGorman I have added few comments, can you check it and revert with changes or your POV

@ravirajn22 Thanks for the comments. Agreed! I factored out the common pieces

Need to check the PR again, will update and push before this weekend.

I did some testing and mostly works okay.
I get the following error when quickly tapping an image twice

@Johan-dutoit Thanks for the feedback. I'll see how to work around that

if @ravirajn22 is happy with the code, I'm happy to give the thumbs up.

Does this PR allow users of the library to set the selection limit, in order to select multiple images at once?

@Sven65 It does not. The library currently doesn't offer this option either. It's straightforward to add that option but IMO better done in a separate PR

@ravirajn22 Have you had  chance to review? If there's anything I can do to help unblock the PR please let me know 🙂

@ravirajn22  last chances for a review, going to merge this today, unless there are any objecetions.

@Johan-dutoit I will review and tell before tomorrow. This change affects many lines including styling and refactor of unrelated lines. I don't know if its the right way to add feature + refactor together. Just give some time.

I did some testing and mostly works okay.
I get the following error when quickly tapping an image twice

Regarding this error, we can handle this in another PR. Just setting the callback to nil after sending response and checking if callback != nil before sending the response should fix this issue. This issue exist even in current production build I think.

LGTM

Thanks @JanGorman, I'll do some basic testing locally and get this merged.

@Johan-dutoit Is there anything left that I can help with to merge? :)

Does this support the durationLimit param?


text:
[BUG]: Error while updating 'SelectedTextTrack'

Version
v6 (Beta)
What platforms are you having the problem on?
Android
Architecture
Old architecture
What happened?
My text tracks looks like below JSON. Initially, index 1 is selected. when I am selecting 2 or 3 indexes its working fine but as soon i am selecting index 0 app is getting crashed in 6.0.0-rc.0
Stream URL - https://bitmovin-a.akamaihd.net/content/sintel/hls/playlist.m3u8
"textTracks": [{"index": 0, "language": "de", "selected": false, "title": "Deutsch", "type": "text/vtt"}, {"index": 1, "language": "en", "selected": true, "title": "English", "type": "text/vtt"}, {"index": 2, "language": "es", "selected": false, "title": "Espanol", "type": "text/vtt"}, {"index": 3, "language": "fr", "selected": false, "title": "Français", "type": "text/vtt"}]

Reproduction
repository link
Reproduction
Step to reproduce this bug are:

Logs -
1 -
Error while updating prop selectedTextTrack
                                                                                java.lang.reflect.InvocationTargetException
                                                                                at java.lang.reflect.Method.invoke(Native Method)
                                                                                at com.facebook.react.uimanager.ViewManagersPropertyCache$PropSetter.updateViewProp(ViewManagersPropertyCache.java:93)
                                                                                at com.facebook.react.uimanager.ViewManagerPropertyUpdater$FallbackViewManagerSetter.setProperty(ViewManagerPropertyUpdater.java:136)
                                                                                at com.facebook.react.uimanager.ViewManagerPropertyUpdater.updateProps(ViewManagerPropertyUpdater.java:56)
                                                                                at com.facebook.react.uimanager.ViewManager.updateProperties(ViewManager.java:48)
                                                                                at com.facebook.react.uimanager.NativeViewHierarchyManager.updateProperties(NativeViewHierarchyManager.java:142)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue$UpdatePropertiesOperation.execute(UIViewOperationQueue.java:93)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue$1.run(UIViewOperationQueue.java:915)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue.flushPendingBatches(UIViewOperationQueue.java:1026)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue.access$2600(UIViewOperationQueue.java:47)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback.doFrameGuarded(UIViewOperationQueue.java:1086)
                                                                                at com.facebook.react.uimanager.GuardedFrameCallback.doFrame(GuardedFrameCallback.java:29)
                                                                                at com.facebook.react.modules.core.ReactChoreographer$ReactChoreographerDispatcher.doFrame(ReactChoreographer.java:175)
                                                                                at com.facebook.react.modules.core.ChoreographerCompat$FrameCallback$1.doFrame(ChoreographerCompat.java:85)
                                                                                at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1648)
                                                                                at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1659)
                                                                                at android.view.Choreographer.doCallbacks(Choreographer.java:1129)
                                                                                at android.view.Choreographer.doFrame(Choreographer.java:1045)
                                                                                at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1622)
                                                                                at android.os.Handler.handleCallback(Handler.java:958)
                                                                                at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                at android.os.Looper.loopOnce(Looper.java:230)
                                                                                at android.os.Looper.loop(Looper.java:319)
                                                                                at android.app.ActivityThread.main(ActivityThread.java:8893)
                                                                                at java.lang.reflect.Method.invoke(Native Method)
                                                                                at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:608)
                                                                                at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)
                                                                                Caused by: java.lang.NumberFormatException: s == null
                                                                                at java.lang.Integer.parseInt(Integer.java:759)
                                                                                at java.lang.Integer.parseInt(Integer.java:915)
                                                                                at com.brentvatne.exoplayer.ReactExoplayerView.setSelectedTrack(ReactExoplayerView.java:1665)
                                                                                at com.brentvatne.exoplayer.ReactExoplayerView.setSelectedTextTrack(ReactExoplayerView.java:1833)
                                                                                at com.brentvatne.exoplayer.ReactExoplayerViewManager.setSelectedTextTrack(ReactExoplayerViewManager.java:284)
                                                                                at java.lang.reflect.Method.invoke(Native Method)
                                                                                at com.facebook.react.uimanager.ViewManagersPropertyCache$PropSetter.updateViewProp(ViewManagersPropertyCache.java:93)
                                                                                at com.facebook.react.uimanager.ViewManagerPropertyUpdater$FallbackViewManagerSetter.setProperty(ViewManagerPropertyUpdater.java:136)
                                                                                at com.facebook.react.uimanager.ViewManagerPropertyUpdater.updateProps(ViewManagerPropertyUpdater.java:56)
                                                                                at com.facebook.react.uimanager.ViewManager.updateProperties(ViewManager.java:48)
                                                                                at com.facebook.react.uimanager.NativeViewHierarchyManager.updateProperties(NativeViewHierarchyManager.java:142)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue$UpdatePropertiesOperation.execute(UIViewOperationQueue.java:93)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue$1.run(UIViewOperationQueue.java:915)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue.flushPendingBatches(UIViewOperationQueue.java:1026)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue.access$2600(UIViewOperationQueue.java:47)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback.doFrameGuarded(UIViewOperationQueue.java:1086)
                                                                                at com.facebook.react.uimanager.GuardedFrameCallback.doFrame(GuardedFrameCallback.java:29)
                                                                                at com.facebook.react.modules.core.ReactChoreographer$ReactChoreographerDispatcher.doFrame(ReactChoreographer.java:175)
                                                                                at com.facebook.react.modules.core.ChoreographerCompat$FrameCallback$1.doFrame(ChoreographerCompat.java:85)
                                                                                at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1648)
                                                                                at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1659)
                                                                                at android.view.Choreographer.doCallbacks(Choreographer.java:1129)
                                                                                at android.view.Choreographer.doFrame(Choreographer.java:1045)
                                                                                at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1622)
                                                                                at android.os.Handler.handleCallback(Handler.java:958)
                                                                                at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                at android.os.Looper.loopOnce(Looper.java:230)
                                                                                at android.os.Looper.loop(Looper.java:319)
                                                                                at android.app.ActivityThread.main(ActivityThread.java:8893)
                                                                                at java.lang.reflect.Method.invoke(Native Method)
                                                                                at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:608)
                                                                                at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)
2024-04-23 17:03:47.530 22890-22890

2-
E  Exception in native call
                                                                                com.facebook.react.bridge.JSApplicationIllegalArgumentException: Error while updating property 'selectedTextTrack' of a view managed by: RCTVideo
                                                                                at com.facebook.react.uimanager.ViewManagersPropertyCache$PropSetter.updateViewProp(ViewManagersPropertyCache.java:101)
                                                                                at com.facebook.react.uimanager.ViewManagerPropertyUpdater$FallbackViewManagerSetter.setProperty(ViewManagerPropertyUpdater.java:136)
                                                                                at com.facebook.react.uimanager.ViewManagerPropertyUpdater.updateProps(ViewManagerPropertyUpdater.java:56)
                                                                                at com.facebook.react.uimanager.ViewManager.updateProperties(ViewManager.java:48)
                                                                                at com.facebook.react.uimanager.NativeViewHierarchyManager.updateProperties(NativeViewHierarchyManager.java:142)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue$UpdatePropertiesOperation.execute(UIViewOperationQueue.java:93)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue$1.run(UIViewOperationQueue.java:915)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue.flushPendingBatches(UIViewOperationQueue.java:1026)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue.access$2600(UIViewOperationQueue.java:47)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback.doFrameGuarded(UIViewOperationQueue.java:1086)
                                                                                at com.facebook.react.uimanager.GuardedFrameCallback.doFrame(GuardedFrameCallback.java:29)
                                                                                at com.facebook.react.modules.core.ReactChoreographer$ReactChoreographerDispatcher.doFrame(ReactChoreographer.java:175)
                                                                                at com.facebook.react.modules.core.ChoreographerCompat$FrameCallback$1.doFrame(ChoreographerCompat.java:85)
                                                                                at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1648)
                                                                                at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1659)
                                                                                at android.view.Choreographer.doCallbacks(Choreographer.java:1129)
                                                                                at android.view.Choreographer.doFrame(Choreographer.java:1045)
                                                                                at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1622)
                                                                                at android.os.Handler.handleCallback(Handler.java:958)
                                                                                at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                at android.os.Looper.loopOnce(Looper.java:230)
                                                                                at android.os.Looper.loop(Looper.java:319)
                                                                                at android.app.ActivityThread.main(ActivityThread.java:8893)
                                                                                at java.lang.reflect.Method.invoke(Native Method)
                                                                                at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:608)
                                                                                at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)
                                                                                Caused by: java.lang.reflect.InvocationTargetException
                                                                                at java.lang.reflect.Method.invoke(Native Method)
                                                                                at com.facebook.react.uimanager.ViewManagersPropertyCache$PropSetter.updateViewProp(ViewManagersPropertyCache.java:93)
                                                                                at com.facebook.react.uimanager.ViewManagerPropertyUpdater$FallbackViewManagerSetter.setProperty(ViewManagerPropertyUpdater.java:136)
                                                                                at com.facebook.react.uimanager.ViewManagerPropertyUpdater.updateProps(ViewManagerPropertyUpdater.java:56)
                                                                                at com.facebook.react.uimanager.ViewManager.updateProperties(ViewManager.java:48)
                                                                                at com.facebook.react.uimanager.NativeViewHierarchyManager.updateProperties(NativeViewHierarchyManager.java:142)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue$UpdatePropertiesOperation.execute(UIViewOperationQueue.java:93)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue$1.run(UIViewOperationQueue.java:915)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue.flushPendingBatches(UIViewOperationQueue.java:1026)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue.access$2600(UIViewOperationQueue.java:47)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback.doFrameGuarded(UIViewOperationQueue.java:1086)
                                                                                at com.facebook.react.uimanager.GuardedFrameCallback.doFrame(GuardedFrameCallback.java:29)
                                                                                at com.facebook.react.modules.core.ReactChoreographer$ReactChoreographerDispatcher.doFrame(ReactChoreographer.java:175)
                                                                                at com.facebook.react.modules.core.ChoreographerCompat$FrameCallback$1.doFrame(ChoreographerCompat.java:85)
                                                                                at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1648)
                                                                                at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1659)
                                                                                at android.view.Choreographer.doCallbacks(Choreographer.java:1129)
                                                                                at android.view.Choreographer.doFrame(Choreographer.java:1045)
                                                                                at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1622)
                                                                                at android.os.Handler.handleCallback(Handler.java:958)
                                                                                at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                at android.os.Looper.loopOnce(Looper.java:230)
                                                                                at android.os.Looper.loop(Looper.java:319)
                                                                                at android.app.ActivityThread.main(ActivityThread.java:8893)
                                                                                at java.lang.reflect.Method.invoke(Native Method)
                                                                                at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:608)
                                                                                at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)
                                                                                Caused by: java.lang.NumberFormatException: s == null
                                                                                at java.lang.Integer.parseInt(Integer.java:759)
                                                                                at java.lang.Integer.parseInt(Integer.java:915)
                                                                                at com.brentvatne.exoplayer.ReactExoplayerView.setSelectedTrack(ReactExoplayerView.java:1665)
                                                                                at com.brentvatne.exoplayer.ReactExoplayerView.setSelectedTextTrack(ReactExoplayerView.java:1833)
                                                                                at com.brentvatne.exoplayer.ReactExoplayerViewManager.setSelectedTextTrack(ReactExoplayerViewManager.java:284)
                                                                                at java.lang.reflect.Method.invoke(Native Method)
                                                                                at com.facebook.react.uimanager.ViewManagersPropertyCache$PropSetter.updateViewProp(ViewManagersPropertyCache.java:93)
                                                                                at com.facebook.react.uimanager.ViewManagerPropertyUpdater$FallbackViewManagerSetter.setProperty(ViewManagerPropertyUpdater.java:136)
                                                                                at com.facebook.react.uimanager.ViewManagerPropertyUpdater.updateProps(ViewManagerPropertyUpdater.java:56)
                                                                                at com.facebook.react.uimanager.ViewManager.updateProperties(ViewManager.java:48)
                                                                                at com.facebook.react.uimanager.NativeViewHierarchyManager.updateProperties(NativeViewHierarchyManager.java:142)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue$UpdatePropertiesOperation.execute(UIViewOperationQueue.java:93)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue$1.run(UIViewOperationQueue.java:915)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue.flushPendingBatches(UIViewOperationQueue.java:1026)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue.access$2600(UIViewOperationQueue.java:47)
                                                                                at com.facebook.react.uimanager.UIViewOperationQueue$DispatchUIFrameCallback.doFrameGuarded(UIViewOperationQueue.java:1086)
                                                                                at com.facebook.react.uimanager.GuardedFrameCallback.doFrame(GuardedFrameCallback.java:29)
                                                                                at com.facebook.react.modules.core.ReactChoreographer$ReactChoreographerDispatcher.doFrame(ReactChoreographer.java:175)
                                                                                at com.facebook.react.modules.core.ChoreographerCompat$FrameCallback$1.doFrame(ChoreographerCompat.java:85)
                                                                                at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1648)
                                                                                at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1659)
                                                                                at android.view.Choreographer.doCallbacks(Choreographer.java:1129)
                                                                                at android.view.Choreographer.doFrame(Choreographer.java:1045)
                                                                                at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1622)
                                                                                at android.os.Handler.handleCallback(Handler.java:958)
                                                                                at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                at android.os.Looper.loopOnce(Looper.java:230)
                                                                                at android.os.Looper.loop(Looper.java:319)
                                                                                at android.app.ActivityThread.main(ActivityThread.java:8893)
                                                                                at java.lang.reflect.Method.invoke(Native Method)
                                                                                at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:608)
                                                                                at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)

Same is happening with audio update -

it arises while setting index as selectedTrack. You can convert index to string it will solve the problem

Is it not valid anymore with new version?

No, it should work - I will fix this

Thanks @KrzysztofMoch

@KrzysztofMoch is there anyway that we can set exoplayer ffmpeg extension in react native video as some formats are not playable

@KrzysztofMoch is there anyway that we can use exoplayer ffmpeg extension in react native video as some formats are not playable
can i share you file url which you can try as the file is hevc still it does not play

No, currently not, I tried to enable it, but exoplayer doesn't support it as a plug in anymore.
To achieve that you need to rebuild exoplayer... (Not 100% sure with media3 I checked with exoplayer 2.18 If I remember well)

I just open a PR to fix this issue. If you want to test it it would be great !
Thank youi

Thanks @freeboub. Sure will test it and confirm.

Hi @freeboub Android issue is fixed but in ios switching between audio tracks is not working and subtitles are not visible in ios (I'm not sure if it is working or not).
Tested using the same stream URL.

@freeboub Any update on it?

@rahulnainwalttn I was working on the issue, I have just push a pull request !

authors: KrzysztofMoch freeboub mkbhdana rahulnainwalttn

repo: react-native-video/react-native-video


text:
fix(android): check disableFocus when state is ready

Update the changelog
fix(android): check disableFocus when state is ready
Describe the changes
check disableFocus prop when state is ready (currently only works on playback toggle)

I don't understand why you do this change ...
Audio focus and keep screen on are 2 differents features, controlled independently.
No need of this change in my point of view

@freeboub
You're right, I was just trying to sync the behavior with this code.
I think it would be better to remove the if (!disableFocus) from the existing code, what do you think?

@YangJonghun I agree, removing the other reference makes more sense !

@freeboub I fixed it. thanks!

authors: YangJonghun freeboub


text:
Guide to linking with hybrid iOS apps

Hi there!
Thanks for a great library :)
I found it a bit hard to stumble on how to get react-navigation working in a hybrid app.
It just requires you adding the RCTLinkingIOS subspec in your podfile under React and running pod install, a la: https://github.com/react-navigation/react-navigation/issues/2977
Is there somewhere can document this? Happy to open a PR if someone could inform me where this sort of documentation should live!
Thanks

hi @James-E-Adams - wow I don't know how I missed this for so long. It does indeed require RCTLinkingIOS to be added - this is the default behavior when initializing a new project but I imagine in hybrid apps you may not opt-in to including it. A pull request for this is welcome! I also added a "Hacktoberfest" tag to this issue :P (see more)

Nice! I just signed up for Hacktoberfest so I'll look at this tomorrow potentially? :)

Done. https://github.com/react-navigation/react-navigation.github.io/pull/259

authors: James-E-Adams brentvatne


text:
How can I slow down useTransition?

So I finally have useTransition working properly (YAY!) but the fade out and in again is just a little bit too fast for my tastes.
Is there any way to slow down the animation a bit?
Here's my code:
const ViewContainer = (props) => {
  const [state] = useState(true);
  const transition = useTransition(state, null, {
    from: { opacity: 0 },
    enter: { opacity: 1 },
    leave: { opacity: 0 }
  });
  return transition.map(({ item, key, props: fade }) =>
    item && <Container key={key} style={fade}>{props.children}</Container>
  )
}

See here: https://www.react-spring.io/docs/hooks/api

so, first i tried this, and nothing seemed to change:
const ViewContainer = (props) => {
  const [state] = useState(true);
  const transition = useTransition(state, null, {
    from: { opacity: 0, config: config.molasses },
    enter: { opacity: 1, config: config.molasses },
    leave: { opacity: 0, config: config.molasses }
  });
  return transition.map(({ item, key, props: fade }) =>
    item && <Container key={key} style={fade}>{props.children}</Container>
  )
}

export default ViewContainer

then I tried this:
const ViewContainer = (props) => {
  const [state] = useState(true);
  const transition = useTransition(state, null, {
    from: { opacity: 0, config: { duration: 1000 } },
    enter: { opacity: 1, config: { duration: 1000 } },
    leave: { opacity: 0, config: { duration: 1000 } }
  });
  return transition.map(({ item, key, props: fade }) =>
    item && <Container key={key} style={fade}>{props.children}</Container>
  )
}

export default ViewContainer

...and got a few error messages, including:

so, I guess I don't quite get how to implement things from the common API in the useTransition hook specifically. I can get them to work in the useSpring hook, but the useTransition hook seems to work differently, no?

You should always provide a repro (eg: CodeSandbox or git repository)
Make sure your Container component is wrapped with animated()
The from prop must only contain animated values, so config is invalid

If 2 and 3 don't fix your problem, come back with 1. Thanks 👍

I have a somewhat similar issue, not sure what I'm doing wrong here.
I have a component like this (bezier method is from bezier-easing package):
const easing = bezier(.61,.16,.24,1.53);

const Button = ({ onClick, children }) => {
    const { expanded, setExpanded } = useContext(FabContext);
    const transitions = useTransition(expanded, null, {
        from: { transform: 'scale(0)' },
        enter: { transform: 'scale(1)' },
        leave: { transform: 'scale(0)' },
        config: {
            duration: 100,
            easing: t => easing(t),
        },
    });

    const handleClick = (e) => {
        e.preventDefault();
        setExpanded(false);

        onClick();
    };

    return transitions.map(({ item, key, props }) => item ? (
        <animated.button key={key} style={props} onClick={handleClick} className="fab --child">
            {children}
        </animated.button>
    ) : null);
};

For some reason, the easing doesn't ever seem to do anything for me. Any ideas?
Sorry if this is the wrong place to ask.

@jakewtaylor 	Please open a new issue.

authors: aleclarson jakewtaylor rchrdnsh

repo: react-spring/react-spring


text:
Input Component: Misalignment of maxLength counter when error is rendered onFocus

FYI, this issue only occurs on Safari and Mobile Safari.
I am attempting to only show the error once my input has been focused once. In order to accomplish this, I use the state to determine when the input has been focused once and then I render the error. However, this causes the counter to be misaligned when the error is rendered after the input has been active. I have confirmed that this issue does not occur if the error is rendered prior to the input being active.
Repro'd using the react-toolbox playground:
class InputTest extends React.Component {
  state = { touched: false };

  handleChange = (name, value) => {
    this.setState({...this.state, [name]: value});
  };

  focused() {
    this.setState({
      touched: true
    });
  }

  getError() {
    if (this.state.touched) {
      return (Error!!);
    }
    return null;
  }

  render () {
    return (

        <Input onFocus={this.focused.bind(this)} type='text' label='error' maxLength={20} error={this.getError()} />

    );
  }
}

return <InputTest />;

On Chrome:

On Safari:

Any updates on this?

If this is low priority, can one of the maintainers at least let me know? @javivelasco @soyjavi

repo: react-toolbox/react-toolbox


text:
List Item customization

As follow up to https://github.com/react-toolbox/react-toolbox/pull/226
This PR is backwards compatible with current ListItem syntax and enables following customizations:

<List>
  <ListItem leftIcon='send' rightIcon='done' caption='Reference item'/>
  <ListItem rightIcon='done' caption='Item with custom left icons'>
    <FontIcon value='send' />
    <Avatar image='https://pbs.twimg.com/profile_images/459485216499720192/ufS4YGOY_400x400.png'/>
  </ListItem>
  <ListItem leftIcon='send'>
    <ListItemContent caption='custom right icons' legend='ListItemContent acts as a divider'/>
    <FontIcon value='done' />
    <FontIcon value='undo' />
  </ListItem>
  <ListItem leftIcon='mail' rightIcon='create'>
    <ListItemContent>
      <ListItemText primary> Custom Caption </ListItemText>
    </ListItemContent>
  </ListItem>
  <ListItem leftIcon='save' rightIcon='delete'>
    <ListItemContent>
      <ListItemText primary onClick={() => {console.log('clicked caption');}}>
        Custom caption with events
      </ListItemText>
      <ListItemText> Custom legend with correct height </ListItemText>
    </ListItemContent>
  </ListItem>
  <ListItem caption='Item with a button'>
    <Button icon='save' label='save'/>
  </ListItem>
</List>

FontIcon and Avatar custom components are applied with default styles to match current list style. Everything else, like the Button in the example above would have to be styles manually by end user or added to default styles.
@javivelasco  @nathanmarks, what do you think of this implementation?

Looks a lot cleaner than the last one! Nice
Quick thing that we need to make sure is possible (it's a relatively common pattern in google apps)
The rows should be easily turned into clickable rows with a ripple, with the ability to link an avatar or an icon independently. I haven't checked this out yet but @kagux can you confirm whether this is possible or not in your implem?

@nathanmarks thanks!
I tried following example on a List with ripple selectable
<ListItem caption='Item with overlayed click events' onClick={() => console.log('clicked row')}>
  <FontIcon value='send' onClick={e => {e.stopPropagation(); console.log('clicked avatar');}}/>
  <Avatar
    image='https://pbs.twimg.com/profile_images/459485216499720192/ufS4YGOY_400x400.png'
    onClick={e => {e.stopPropagation(); console.log('clicked avatar');}}
  />
</ListItem>

While you can link avatar/icon seprately from row itself, Ripple component overlays the whole row so you see ripples no matter where you click.
I'll see if there is a way to make it work.

@kagux Okay cool.
What about z-index that is conditionally applied? Remember, we don't want icons that aren't supplementary actions to not trigger the main list item click handler.
Here's a good example of where the combined functionality is needed:

@nathanmarks your example makes perfect sense, I agree that it should be possible.
Ripple is positioned absolutely and also is a sibling of a parent. That makes z-index irrelevant because of stacking context.

@kagux we can wrap the other list contents separately.
ListItem

contents
ripple

I'm also wondering if a <button> should be injected as an additional wrapper in the list item if an onClick handler is provided -- this would be semantically correct.

@nathanmarks could you elaborate your idea we can wrap the other list contents separately?

@kagux pseudo-html
<ListItem>
  <ListItemContents>
  <Ripple>
</ListItem>

That's how the current list is too IIRC

@kagux It looks like the actions are already clickable -- so all it would take is preventing the click event bubbling back and triggering the main ripple.
I wonder if we should actually leave this up to the user. What do you think?

@nathanmarks but that's what causing the issue right now because Ripple is sibling of a parent for every element inside a list. Unless I'm missing something.
DOM from this PR is similar

@kagux When you click on the current list, on an icon, it is the the node that triggers the event:

So yeah, since the list items are composable now, we could leave the event bubbling prevention up to the user. Sometimes it's hard to find the balance between keeping things simple and making it easy to implement common spec examples

@nathanmarks you're right, the icon span node triggers event. If I add onMouseDown={e => e.stopPropagation()} it doesn't bubble up and no ripple.
We can stop bubbling here https://github.com/react-toolbox/react-toolbox/pull/282/files#diff-b5ed0f8b3f5d36a8a158464c29236615R12 when wrapping components. If we let user mark clickable components with a property like clickable/listItemClickable, then it would be trivial. That would solve most common use case and users would still be able to take control of event propagation if they wanted to.

@kagux perhaps something like secondaryAction -- is more expressive than clickable and makes it clear the the action is secondary to a primary action and therefore should not bubble the event.
On the other hand, maybe we could leave the prop out for now to keep the API surface small. If someone is wiring up individual icons on lists they are already getting deep enough into things that preventing the bubbling is easy.
I also want to avoid doing too much in this specific area as after you've done your PR I want to look into creating some automatic wrappers to make components more semantic output-wise.
For example, having a <li> element with an event handler on it would be better served with a <button> injected as the immediate child with an aria-label on it.

@nathanmarks I've updated PR with small change to stop Click/MouseDown propagation if item action component defines onClick. That would be the most common scenario to add onClick events to action component root. It prevents ripple and row click. If a user wants a more complicated component, then it's up to them to stop propagation.

nice, sounds good

Amazing work guys. Good to go!
Thanks so much both of you!

authors: javivelasco kagux nathanmarks


text:
Add rename warning to legacy django-idom

Current Situation
django-idom has been renamed to reactpy-django. We need to warn existing users about this change.
Proposed Actions
Add a print/log statement to src/django_idom/__init__.py to tell users about the rename.
We need to create a new branch based off of commit b1ff783c887bbd7d93fdf586d21555692b502dcb in order create new django-idom releases.

@rmorshea Can you review https://github.com/reactive-python/reactpy-django/commits/legacy-django-idom before I send out a release?

Is there a PR associated with that commit?
I'm away from my computer now, but I can create a legacy-idom branch that we can merge that into tomorrow. I can manually release that then.

I already created the branch, but did so without a PR.

LGTM.

authors: Archmonger rmorshea

repo: reactive-python/reactpy-django


text:
Modifies rules 1.09 and 2.13 to mandate java.lang.NullPointerException...

... be thrown.
Updates the TCK, Spec and example implementations.
@reactive-streams/contributors As discussed in #204, here is my proposed spec, tck, example amendment for null handling. Please comment and vote before the 9th of February 2015 as we should attempt to ship 1.0.0.RC2 STAT.

I'm :+1: on the changes other than the wording comment I added.

Thanks @benjchristensen!

Looks good :+1:
Though it's missing the "anti tck-regression tests" we've been keeping recently, whipped them up for you here @viktorklang: https://github.com/ktoso/reactive-streams/commit/dade90910a01edef26ebb359626046044350f92e#diff-f058033d69037e8082bda05ee49d781aR144 Feel free to cherry pick or include at will. (splits test in 3 parts, so it's actually testable for these separate messages).

@ktoso Thanks Konrad, I amended my commit with your update!

You're welcome :) LGTM

@reactive-streams/contributors Merging without objection :)

RC2 ?

@smaldini I was hoping we'd be able to solve the onSubscribe|onComplete|onError before we cut RC2.
Want to help out getting that done?
It seems like the current majority opinion is that we should aim for onSubscribe ~ onNext* ~ (onError | onComplete)

I'm waiting for consensus and then go RC2. But yeah I'm for that too, I think @rkuhn and I shared the concern by necessity (meaning facing not nice issues when implementing a more relaxed version). And I don't think this brings much more to bypass it.

I was about to unleash a reactor RC1 too but I can wait slightly more.

But yeah I'm standing for the community order to issue the release
Sent from my iPhone

On 9 Feb 2015, at 12:16 pm, Viktor Klang (√) notifications@github.com wrote:
@smaldini I was hoping we'd be able to solve the onSubscribe|onComplete|onError before we cut RC2.
Want to help out getting that done?
It seems like the current majority opinion is that we should aim for onSubscribe ~ onNext* ~ (onError | onComplete)
—
Reply to this email directly or view it on GitHub.

authors: benjchristensen ktoso smaldini viktorklang

repo: reactive-streams/reactive-streams


text:
When can cookie prop be undefined?

According to this TypeScript definition https://github.com/reactivestack/cookies/blob/master/packages/react-cookie/src/types.ts#L4
cookies prop can be undefined, but in practice it's always there. Can we remove ? from the definition or am I missing some crucial step in the lifecycle?

You don't need to specify the value on the browser, only on the server. Thus, it is optional.

authors: eXon pokonski

repo: reactivestack/cookies


text:
Not getting closed when clicked outside

When clicked outside modal i.e on overlay modal is not getting closed
<Modal
  isOpen={this.state.openDialog}
  contentLabel="Modal"
  shouldCloseOnOverlayClick={true}
  style={this.modalClass}>

Hello

I am a modal

 </Modal>

this.modalClass = {
            overlay: {
                position: 'fixed',
                top: 0,
                left: 0,
                right: 0,
                bottom: 0,
                backgroundColor: 'rgba(0, 0, 0, 0.3)',
                zIndex:999
            },
            content: {
                position: 'absolute',
                top: '40px',
                left: '40px',
                right: '40px',
                bottom: '40px',
                border: '1px solid #ccc',
                background: '#fff',
                overflow: 'auto',
                WebkitOverflowScrolling: 'touch',
                borderRadius: '4px',
                outline: 'none',
                padding: '20px',
                zIndex:9999

            }
        };

Expected behavior: Should close when clicked outside modal
Additional Information: I have another overlay with zIndex '3' on a background image. With more z-index I'm able to see the  modal on top of everything, but not getting closed

You need to have a onRequestClose prop on the modal.  That will let the modal know what to do in order to close.  Something as simple as onRequestClose={() => this.setState({openDialog: false}) should do it for you.
I'll make sure to note this down and make sure it's documented more clearly.  We're changing things around the props for v2 see #282 for more details.

@claydiffrient Thanks man !!!

authors: anandrikka claydiffrient

repo: reactjs/react-modal


text:
Update pt-PT.json

New maintainer

Hi folks, sorry for no response.
We've been working on new React docs, and so translations of the old site were deprioritized.
In the meantime, it looks like our GitHub permissions sync may have broke.
Now that we've rolled out the new site and reset the repositories for new translations, I'm going to close all old pull requests including this one so that we can start from a clean slate. If you'd like to still make the same change, please open a new PR.
Thanks, and sorry for the churn.

authors: gaearon horberlan


text:
Hooks support redux?

Hi All,
I am using react version 16.13.1
Can i use redux with hooks in my project which is on banking domain.

redux hooks should be compatible with any version past 16.8. If you need any more help check out our community support.

Can I use hook context instead of redux for large project to maintaining state. Also does that hook context support for jest and enzyme test cases


text:
Update reconciliation.md

typo on this page.

I don’t see the typo. Lack of space is intentional.


text:
Warn When dispatching During Middleware Setup

Recreates #1345
Closes #1240
Switched this to throw an error now.

Ugh, forgot the branch :)

repo: reactjs/redux


text:
无搭建开发环境了？

0.55~0.59版本React native的文档都没有“搭建开发环境”相关说明了？？？

感谢反馈，已修复

authors: EarlyLau sunnylqm

repo: reactnativecn/react-native-website


text:
🛑 Bellshade API is down

In 25f3daa, Bellshade API (https://api.bellshade.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Bellshade API is back up in b79d8b6.