text:
map nodejs4.3 to nodejs as base

this is not needed anymore...

repo: iron-io/functions


text:
fixed: index file for concepts/security

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fleeto
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content_zh/OWNERS [fleeto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

source: gharchive/pull-request

authors: fleeto istio-testing

license_type: permissive

license_source: github-api


text:
Add login, plugin publishing to abot CLI

Side Note: Publishing plugins through itsabot.org causes a strconv.ParseInt error...
@egtann Do we have a slack group, gitter, etc? Because communication for the project could be improved :stuck_out_tongue_closed_eyes:

Yup, we have an IRC room on freenode, #abot-dev. I'm in there now. We can also do email, and I try to be pretty quick in responding (evan / at / itsabot.org)

authors: egtann njaremko

repo: itsabot/abot

license: mit

license_source: bigquery


text:
Adjust to fit in Altoid's tin

Moved power connector in as much as possible.  I think it should fit but will not know until we get the A2 boards back.

Still would like to find a shorter power connector.

I've ordered some PCBs from OSH Park to do a mechanical mock-up to verify the fix. I've not identified a source of a shorter power connector.

Would implementing issue 39 (new BMS) allow us to use a different power connector? Is the barrel jack currently used to charge the battery or is it used for directly powering the processor?
https://github.com/jadonk/beaglebone-blue/issues/39

The barrel jack is primarily for charging the battery but can provide power to the 5V regulator when no battery is connected. We picked this connector because of how ubiquitous 12v wallwarts are with this 5.5mm barrel jack. I just wish there were half-length jacks available.

I've not been able to find a shorter jack, which is very surprising to me.
A2 still does NOT fit in an Altoids tin. :-(

@StrawsonDesign For rev B, can we switch the power input to a JST connector?
https://www.sparkfun.com/products/8734
I wonder how much it would cost to include that in the kit. :-/

Hmmmm, sorry but I really really like the universal barrel jack. We would
get so much pushback from people complaining about needing dedicated
adapters just to charge the thing just like Apple gets with their headphone
jack adapters. I do adore the Altoids tin concept, don't get me wrong! But
in practice I don't think anyone is running their board in a conductive
tin, whereas everyone will need to charge it and everyone with a wifi
router has one of these 12v dc wallwarts in their home already.
Charging via a 9v or 12v capable USB-C connector may get initial pushback
too but at least that's looking a bit more towards a future universal
standard.
Respectfully,
James
On 9 Feb 2017 2:27 pm, "Jason Kridner" notifications@github.com wrote:

@StrawsonDesign https://github.com/StrawsonDesign For rev B, can we
switch the power input to a JST connector?
https://www.sparkfun.com/products/8734
I wonder how much it would cost to include that in the kit. :-/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jadonk/beaglebone-blue/issues/33#issuecomment-278795022,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF9HoD6GTmkTX53KhxxFVraWTu7sq_Zgks5ra5LrgaJpZM4KVPuS
.

Issue migrated to beagleboard/beaglebone-blue#50

source: gharchive/issue

authors: StrawsonDesign erikwelsh jadonk jonnycowboy

repo: jadonk/beaglebone-blue


text:
Create migration strategy (seed/schema)

complete

license: MIT


text:
Add missing location to module_eval

Great catch, thank you!

authors: janko-m printercu

repo: janko-m/shrine


text:
support the cortex-m7f

:pushpin: Commit b0d634c has been approved by japaric

@homunkulus r+

:hourglass: Testing commit b0d634c with merge b0d634c...

:broken_heart: Test failed - travis

@homunkulus r+

:pushpin: Commit bb31d8b has been approved by japaric

:hourglass: Testing commit bb31d8b with merge bb31d8b...

:sunny: Test successful - travis

authors: homunkulus japaric


text:
Cleanup Graphql client interfaces

 cleanup GraphQL client interface


text:
Is there an example on how to use AMP with Razzle ?

@faizanathar Did you figure out a working example?

maybe this https://github.com/jimmy319/amp-react-renderer-plugin helps you.

authors: faizanathar milesalex nimaa77

repo: jaredpalmer/razzle


text:
Bumped all Angular related dependencies.

Good idea, thanks.

authors: TunedMidja jchatkinson

repo: jchatkinson/ng-svg

license: unlicense


text:
Add Tower / fournova (git-tower.com)

Thank you! Can you add region information and add a company profile? Merging this as-is for now.

authors: gittower jessicard

repo: jessicard/remote-jobs


text:
MarkerWithLabel fix for latest maps version

MarkerWithLabel fix for latest maps version

@arkhipovandrei Are you able to verify if v2.0.2 fixes the issues you were seeing?

authors: arkhipovandrei jesstelford

repo: jesstelford/node-MarkerWithLabel


text:
Add files via upload

wag muna hehe di pa okay yan

repo: jetrocks/tuplive


text:
Ensure there is no allocation in final aggregation step.

:+1: Thanks!

authors: gwenn jgallagher

repo: jgallagher/rusqlite


text:
Element symbols

Changes have been made. Underscores have been removed as valid symbols, and the app should not be crashing anymore, at least for .xyz and radius files. I'm not equally familiar with .pdb files, so I haven't made all the same changes to that section.

repo: jmaglic/MoloVol


text:
Dinodex

@zsyed91 Nice first pass at this exercise. Please take a look at the comments and refactor.


text:
Added Swift badge

Dose there be some way to update swift badge to the latest version?

@johnlui It's all about changing the version on the url:

I do not want to update the tiny version after the point...

You can also update the major version:

Haha, I found that the you can put any word at 2.1 position.
https://img.shields.io/badge/swift-latest-orange.svg
https://img.shields.io/badge/swift-latest-orange.svg

authors: johnlui lfarah

repo: johnlui/SwiftNotice


text:
update browser compatibility

Hurray! And thank you, @christianhaller !

authors: christianhaller jonathantneal

repo: jonathantneal/closest


text:
New server.js file to start the server

Thank you!


text:
rebase with master to get the latest in this branch.

@jordan-brough wdyt? Not sure why this is not mergeable btw. When I propose this as a PR on the solidus repo directly I have no issues.

Closing since @peterberkenbosch is driving this forward in Solidus PR 1414

authors: jordan-brough peterberkenbosch

repo: jordan-brough/solidus


text:
Add submodule

LGTM

authors: hamanishi taniTk


text:
improve document

I got what you are trying to say, but I think what you have written is all about python, not the about imutils. It is not suitable for imutils document.


text:
Fix typo

Thanks

authors: azu sanemat


text:
Update index.md

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset1/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset1/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset1/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset1/new.md
:white_check_mark:Succeeded
View

docset1/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset1/index.md
:white_check_mark:Succeeded
View

docset1/new.md
:white_check_mark:Succeeded
View

docset1/TOC.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

Line 110: [Error] W:\mozd-s\docset1\docfx.json for docset docset1-jsntcy doesn't exist

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset1/TOC.md
:white_check_mark:Succeeded

docset1/index.md
:white_check_mark:Succeeded

docset1/new.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset1/TOC.md
:white_check_mark:Succeeded

docset1/index.md
:white_check_mark:Succeeded

docset1/new.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

repo: jsntcy/pr-branch-fallback


text:
fix(Publishing): Incorrect google project name

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

repo: juliansangillo/datingapp-example


text:
New announcement and added decipher to the team

Fixed.

👍 Merging

Good job guys :) Great to see some live breathed into this!

Thanks! Our pleasure.

authors: danielpcox jmcudd tannerlinsley

repo: jumpsuit/jumpstate


text:
Update xeus-python to 0.11.0

@SylvainCorlay  The Linux build fails because we are building against a specific commit, it should be fine if we release again xeus-python

@SylvainCorlay The Linux build fails because we are building against a specific commit, it should be fine if we release again xeus-python

Oh yeah that's because we use the tag to make the version number, which we should not do.

Merging!

authors: SylvainCorlay martinRenou

repo: jupyter-xeus/xeus-python-wheel


text:
Optimized lines and improved GetSuccessors

This does not compile
0.93s$ cd cpp; make
g++ -Wall 8puzzle.cpp -o 8puzzle
g++ -Wall findpath.cpp -o findpath
findpath.cpp:77:1: error: expected class-name before ‘{’ token

Oh, sorry. I didn't even note that AStarState has a generic type.

authors: justinhj thelostt

repo: justinhj/astar-algorithm-cpp


text:
Vector all the things

Coverage remained the same at 91.26% when pulling 9f782c3d97c7be4e8351d07bedac4edb2d6b98c0 on vector-all-the-things into ea46eaefdda12fe36a55bd5821ba65a22ad69d54 on master.

authors: coveralls kammce


text:
Inversion still exists on [480] [NOX] NR and NR+TIMER scripts

https://github.com/kastyr1984/FFBE-Macros/blob/mcgillbymini/Mcgillby/Nox/no_refills_[480]_[memu].txt

https://github.com/kastyr1984/FFBE-Macros/blob/mcgillbymini/Mcgillby/Nox/no_refills_%2B_timer_[480]_[memu].txt

TM refill 480 working perfectly

Also exists all NOX versions except TM Refill 720 and 480

Merged new changes in at: https://github.com/kastyr1984/FFBE-Macros/tree/mcgillbymini
Please test when you can

thanks, just got home form work, testing now, ill slow down on the comments, sorry, i didnt realize it was linked to  your email :\

Okay so I have tested NO Refill, Id like to make adjustments to the timings of the click release. I can use a text editor and change all 01000 to 10000 in the timing, it seems to work better, but Id like to make the changes here so we can compare them, how do I do that, or should I just do it and send you the updated file?

Question for you, If I was able to get phone resolutions for HIRO like 1080x1920 or 1440x2560 would it run on peoples smartphones?

Yeah. We can either convert with tool or rely on Hiro to do conversion
automatically. I'll also teach you how to do branchs and pull requests
later.
On Apr 6, 2017 7:20 PM, "Mcgillby" notifications@github.com wrote:

Question for you, If I was able to get phone resolutions for HIRO like
1080x1920 or 1440x2560 would it run on peoples smartphones?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kastyr1984/FFBE-Macros/issues/15#issuecomment-292358689,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARPJh024NB6ksAe0Of1wRJW2HbtQV6FRks5rtXNbgaJpZM4M1H9M
.

K thanks, Ive tested all the 480 resolutions, everything looks good.

Sorry Im not seeing NOX 720 No Refill & NR + Timer, Just HIRO. Im in the minitree.

Okay I ran into a major problem with the converted MEmu to NOx 720 script. The touches are hitting slightly right and up of where they are supposed to be, the code is right, what is happening? Im adjusting the numbers to hit the buttons, im completly missing the friend request deny, I have to run some more tests, you have any idea why its doing this?

https://github.com/kastyr1984/FFBE-Macros/blob/mcgillbymini/Mcgillby/Nox/tm_refills_720.txt
you able to try this and see if it misses the friend request deny for you ? the numbers are right but for some reason its missing, every other button is working tho.

I fixed it. I think I did the pull request thing right

maybe you or @biribussi  can test it?

I went ahead and merged your changes. I'd test but it's late and I've been running around all day and I'm totally zonked. Problem should be fixed with #17 so I'm closing this issue for now.


text:
Away in personal emergency - mum in ICU on ventilator life support

From the base of my heart I wish all the best.

So sorry to hear that, we wish you the best during this difficult time.

so sory I hope he will recover soon and get health.

Hi @RaiMan @youleaf @muratcim thank you for your wishes. Yes we need all the medical help and prayers to bring her through this ordeal.
She is starting to regain consciousness. Still on ventilator life support. Medical team has started treatment on her microscopic polyangiitis condition and we are praying for improvement in her lungs to be able to breathe on her own soon.

Closing this issue as there is now continuity in support for users who raise issues on GitHub.
My part-time contract with AI Singapore is ending and I'll not be renewing for time being. My colleague @siowyisheng will help support TagUI users with issues they raise on GitHub.
My mum has improved slightly over the past week but is still on ventilator support. We are praying for her lungs to continue to recover and for her kidneys to start recovering.
For my personal project RPA for Python, I'll leave a similar issue there https://github.com/tebelorg/RPA-Python/issues/144 open because there won't be continuity in fast and timely user support from me.

authors: RaiMan kensoh muratcim youleaf

repo: kelaberetiv/TagUI


text:
Resolved #256

Codecov Report

Merging #257 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
- Coverage   24.87%   24.86%   -0.02%
==========================================
  Files          62       62
  Lines        1636     1637       +1
  Branches      196      196
==========================================
  Hits          407      407
- Misses       1159     1160       +1
  Partials       70       70

Impacted Files
Coverage Δ

...s-frontend/src/pages/UserPage/FilteringHeatmap.tsx
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1729f5...41315b9. Read the comment docs.

authors: codecov-io kenkoooo

repo: kenkoooo/AtCoderProblems


text:
Update versions of dependencies

Thanks!


text:
CDK-952: Add CLI list command.

+1, ship it!

Thanks, Joey!

authors: joey rdblue

repo: kite-sdk/kite


text:
Simple e2e test for DLQ from Broker.

Awesomesauce!
/lgtm
/approve

repo: knative-sandbox/eventing-rabbitmq


text:
refactor docker-compose.yml

確かにこれすんごい拡張性悪いような感じはする笑
結局srcの中でディレクトリ作られたら，ディレクトリ移動しないとあかんようなるし
そうなっちゃうと今回のリファクタ，なんの意味もなくなるしな笑

repo: kogepanh/latex-vscode-container


text:
Add the Lupa crawler

@bortzmeyer Thanks 🙏 🌈


text:
ktl proposal

One quick note: I didn't see "using right version of kubectl depending on the targeted cluster" part in the proposal or I missed. It was part of the POC code you shared (1.7 vs 1.8 switching of kubectl).

It was a fun part of the PoC, but I wanted to keep this focussed

@smarterclayton @sttts @liggitt @soltysh @juanvallejo

Thanks @deads2k  I understand the issues with vendoring kubernetes/kubernetes better now.  Will incorporate feedback into the proposal.

Thanks for the responses.  Out for the holidays.  Will follow up next year.  See you all in January!

I doubt that vendoring just kubectl-related code will solve any of the concerns everyone mentioned. As you know kubectl code is too tightly integrated with current k8s code base which will always lead to all the aforementioned problems. Why not ktl being all-generic approach to talk to k8s? With all the work happening right now we're moving majority of responsibilities to the server so the direction of less loaded client seems like a good approach.

Closing this for now.  Will reopen in some other form.

authors: deads2k pwittrock soltysh

repo: kubernetes/kubectl


text:
tasks-debug-application-cluster-local-debugging-pr-2017-12-05

updated

updated

@Tony-CCIE @linyouchong if there are no more problems, please ping a member to merge

@pigletfly 如何操作

ping @lichuqiang @markthink

updated

updated

@pigletfly @lichuqiang 可以 merge 时，@我..

@pigletfly @markthink LGTM

authors: Tony-CCIE lichuqiang markthink pigletfly

repo: kubernetes/kubernetes-docs-cn


text:
Healthcheck

Current coverage is 100% (diff: 100%)

Merging #85 into develop will not change coverage

@@           develop    #85   diff @@
=====================================
  Files           61     63     +2
  Lines         1758   1836    +78
  Methods          0      0
  Messages         0      0
  Branches         0      0
=====================================
+ Hits          1758   1836    +78
  Misses           0      0
  Partials         0      0

Powered by Codecov. Last update 7d2ecec...fd359b9

Thanks.  Merging

authors: codecov-io kyle-long

repo: kyle-long/pyshelf


text:
Pep8

This involves adding pep8 or autopep8 as dev-depdency and then running it once.

repo: ladybug-tools/queenbee


text:
fixed typo in $vpxdlogfile reference

another typo needs to be fixed too

repo: lamw/vghetto-scripts


text:
NE tool wrapper complies with recent change in WSEV

v2.1.0 resolves this. Closing the issue.


text:
[5.4] Fix getGlobalScope()

Merged.

authors: taylorotwell themsaid

repo: laravel/framework


text:
500 pages and error handling for lbry.tv

There are two things to handle for errors:

When an error happens client-side in React that cannot be recovered from, does the app end up on an error page and not result in broken behavior?
When an error happens server-side (server.js), show a simple HTML page indicating as such.

@seanyesmunt this should also largely fall out of web server architecture changes.

Closing in favor of #3178

authors: kauffj seanyesmunt

repo: lbryio/lbry-desktop


text:
Add note on generating XML file if it doesn’t exist

Wow! In order to create a short, simple library for testing purposes, I created a new account on my Mac, created a simple library and playlist, then discovered there was NO .xml file in ~/Music/iTunes. Then found the Apple doc mentioned in this PR. So we can NOT assume the user has an XML file at all!

repo: liamks/libpytunes


text:
对中文的数据集有做过测试吗？表现如何？

Nope. I only tested on English datasets, those four listed in ReadMe.

Nope. I only tested on English datasets, those four listed in ReadMe.

thanks!


text:
想知道kotlin环境下如何实现自己控制请求和回调线程

他是会根据我启动协程时指定的线程而变化吗，还是始终是IO

结合协程发请求，默认在IO线程发请求(这个不能更改)，至于回调，协程就没有回调，通过返回值获取结果。

authors: BlackDEH liujingxing

repo: liujingxing/okhttp-RxHttp


text:
add coveralls task

LGTM

Can you see if you can get it to work in coveralls? I try to add the repo but nothing comes up

https://coveralls.io/r/lob/hapi-bookshelf-models
it wasnt added to coveralls. Should work now

Cool - that was the part I couldn't get to work. Wouldn't show up in the list on coveralls.io

authors: leore pon

repo: lob/hapi-bookshelf-models


text:
added event logging

Good! :)

authors: mcollina pelger

repo: logentries/docker-logentries


text:
Pause and resume recording. Fix #220

Coverage remained the same at 30.376% when pulling bbfe5d7a7ee2e92ff31c0948b7c3c4c52e3fd3d1 on pause into df923a0748788d61dcc7cf513a454379cea6e5b5 on master.

authors: coveralls juanjmerono

repo: loowid/loowid


text:
[csrng/data] moving csrng to D2 status

@mateenfaisal FYI
Thanks @mwbranstad for your work on getting CSRNG to this stage!

authors: imphil mwbranstad

repo: lowRISC/opentitan


text:
flutter new stable: 1.7.8+hotfix.4

This will be picked up automatically after problem with Excavator is solved.

Update checkver to "windows_v([\\w+-.]+)-stable" (added + symbol)
And maybe this should close #2439

repo: lukesampson/scoop-extras

license: Unlicense


text:
Implement nacl cipher

closes #321

repo: mailchain/mailchain


text:
Add possibility to send array of recipients for 'to', 'bcc' and 'cc'

Hi @Emendiel ,
First of all, thank you for your interest in Mailjet! Also, please excuse us for the delay in our response.
We tested your PR and everything went as expected. Given the fact that your PR brings a valuable addition to the wrapper, we are gladly accepting it!
However, due to the state of our repo, we will integrate your changes manually into branches of upcoming releases: 1.0.8 & 2.0.0 (resp. 108-merge & sboo-master).

Your changes have been integrated into the 1.0.8 & 2.0.0 branches.
Thanks again!
Refs to commits: 1.0.8; 2.0.0.

Thank you for your integration.

authors: Emendiel Gormador


text:
use -f test to not only check they are non-empty but also that they point to valid files

I was afraid of setting these to the wrong things - I looked to see if the script will tell me if I set them incorrectly, and there really isn't a check done by these scripts to tell me that they are really pointing to what it expected (and that is - the kubeconfig file). The -z just checks to see that you set them - but you should also check that they at least point to a valid file (and not, say, an invalid file or a directory instead of a file).

/ok-to-test

authors: jmazzitelli jwendell

repo: maistra/istio


text:
Tests and bug verifications

Khurram,
Could you please review ?
Thanks !
Vicky.

Vicky tests look good. Verified commit id and tests and expected results. LGTM.

Thank you, Khurram.

authors: kfaraaz vmarkman

repo: mapr/drill-test-framework


text:
CALCITE-1124: backport timestampadd / timestampdiff functionality

-1. We need to stop backporting changes onto the Calcite fork and move back to master.

Sounds reasonable. What features do we have in Drill Calcite fork that are
missing in Calcite?
On Wed, Mar 9, 2016 at 6:38 PM Jacques Nadeau notifications@github.com
wrote:

-1. We need to stop backporting changes onto the Calcite fork and move
back to master.
—
Reply to this email directly or view it on GitHub
https://github.com/mapr/incubator-calcite/pull/5#issuecomment-194386355.

authors: arina-ielchiieva jacques-n

repo: mapr/incubator-calcite


text:
Tagged unions

Coverage decreased (-0.05%) to 84.288% when pulling 056a3cc32994a8ace99250c4db93c243e5ec0951 on tagged_unions into 570cd1ff147423ccf9b530dfa1afbd7f8759595a on master.

authors: coveralls mariosangiorgio

repo: mariosangiorgio/rulox


text:
remove deprecated methods from StructuredQueryBuilder

Done.  Testing is rolled into dup issue #621

repo: marklogic/java-client-api


text:
Add modules and decide how to compile them

Modules will be bundled into a single bytecode file

repo: matter-labs/zksync


text:
Group apply page

Codecov Report

Merging #143 into master will increase coverage by 0.57%.
The diff coverage is 36.53%.

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage    21.9%   22.48%   +0.57%
==========================================
  Files          91       93       +2
  Lines         566      596      +30
  Branches       25       30       +5
==========================================
+ Hits          124      134      +10
- Misses        428      446      +18
- Partials       14       16       +2

Impacted Files
Coverage Δ

app/screens/CreateGroup/CreateGroup.js
0% <ø> (ø)
:arrow_up:

app/redux/reducers.js
100% <ø> (ø)
:arrow_up:

...CreateGroupApplyOkSnackBar/GroupApplyOkSnackBar.js
0% <ø> (ø)
:arrow_up:

app/screens/Groups/Groups.js
0% <ø> (ø)
:arrow_up:

...roup/GroupApplyStatus/GroupApplyStatusContainer.js
0% <0%> (ø)

app/screens/Groups/JoinGroup/JoinGroupContainer.js
0% <0%> (ø)
:arrow_up:

...ps/JoinGroup/GroupApplyStatus/GroupApplyStatus.jsx
100% <100%> (ø)

app/redux/ui/ui.actions.js
100% <100%> (ø)

app/redux/groups/groups.actions.js
22.5% <26.08%> (+4.85%)
:arrow_up:

app/redux/ui/ui.reducer.js
50% <50%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b336b09...47c78d4. Read the comment docs.

authors: codecov-io mbernardeau


text:
Checkout if we wan't to replace greenkeeper with renovateapp

Is this not already done? @TheReincarnator @LKuechler

This was done with #352

authors: LKuechler tilmx

repo: meetalva/alva


text:
Spelling fixes

Looks like you do a lot of spelling fixes across repos. Are you a bot or a peruser of codebases? :)

I'm not a bot. I tend to look into projects I either use, have used, or am considering using. This project is in that final category.
I do use a script, but I have to pick the corrections on a per misspelled word basis.

Hey,
Sorry it took me a while to come back to this. I'm not going to merge it as a bunch of tiny commits since people have used that to inflate commit statistics in the past. If you're interested in merging, would you mind squashing and rebasing against 'next'?
thanks!

@dormando: done.
Note that it is much easier for me to rebase individual fixes than it is a collapsed commit, which is why I submit changes as individual things. It also makes it easier for me to handle things like "we're en-GB, don't change us to en-US" or "X is an API" or "Y is an intentional misspelling that we need for ".
I don't care about statistics, I'm happy to collapse changes once a project has indicated it will take them. -- As you've noted, I've contributed to more than enough projects that it really doesn't matter at this point.

I totally understand; I usually make a bunch of commits and collapse later. I just prefer that collapsing at the end where possible.
I've merged this for the next release. I really make an impressive amount of typos... It's nice to get all of these at once, since I tend to get random one-off spelling fixes every month anyway. thanks!

For reference, this is now: 79e35287df4cd9e410c3a160c2552ea40a335e2c

authors: dormando jsoref

repo: memcached/memcached


text:
Added UP in the list

Nice to see a company outside of Kathmandu valley, the first one on the list.
Thanks @kalwar

@mesaugat Thanks for creating and maintaining the list.

authors: kalwar mesaugat

repo: mesaugat/tech-companies-in-nepal


text:
possibility to have errors in result data

In order to

Fix lint errors :)

This PR might not be necessary according to this comment https://github.com/mesg-foundation/core/issues/610#issuecomment-443533797.
We might be solving to issues with one single solution and this current solution will not be necessary.

This PR might not be necessary according to this comment #610 (comment).
We might be solving to issues with one single solution and this current solution will not be necessary.

Why do you think that this PR might not be necessary? When a service sends an invalid result to Core, an application that listens for that result will never have it. In the mean while Core will witness this. So, it can inform application by submitting the result but with the actual error that raised from SubmitResult API which is the purpose of this PR. I read the #610 but I couldn't understand it fully. I'll give a second look tomorrow.

I'm removing this PR from v0.5 in order to do more test and to implement the changes in the application libraries.

This PR could be done a bit differently to include also a fix https://github.com/mesg-foundation/core/issues/610. On this issue, if we have the error in the execution the problem is solved so what about having this error inside the execution instead of outside and in the api.SubmitResult set the error in the execution through a Failed function in the execution.
Like that the execution is marked as failed and all the time send to the stream and also all the time stored in the database to be able to extract these data if we need to.
I have the modifications of this changes, I can open a PR just to explain with code if it helps

Currently we pass an error in the execution.Complete() func and if it's not nil execution will complete with an error. I don't mind extracting this part to a separate ComleteWithFail() but I cannot see a benefit.

As I checked, this PR already includes #610. https://github.com/mesg-foundation/core/issues/610#issuecomment-445720962

Having an additional failed status is not mandatory -because we already have this Error field that we can check if execution completed with failure- but would be nice.
Passing string value to api.SubmitResult() still fees a bit odd because that will make submit result api to be JSON aware. Keeping this decoding part in the interface pkg where we deal with network feels more natural because JSON is used to transmit data over network so it's more relevant to keep it there. We also do the encoding part of listen result, event, task inside interface pkg as well. Only moving the decoding part to api pkg also feels odd.
Maybe we can discuss/solve this one under another issue because this is just an improvement. But still, if you really think that we should do these changes, I'm glad to do the updates. 👍

This PR might also solve this issue https://github.com/mesg-foundation/core/issues/637

needs review

Should we close this one in favor of https://github.com/mesg-foundation/core/pull/651

authors: NicolasMahe antho1404 ilgooz krhubert

repo: mesg-foundation/core


text:
Exceptions when forms save are being added to the list alert rather than the form alert

Fixed with commit 29e01044961d0609ef614cf2c4d6cac459885432

repo: metronical/metron


text:
Provide unit tests

pytest unit structure is in place, two unit tests implemented.

repo: microsoft/jschema-to-python


text:
Context menu commands should be grouped/sorted

This looks even worse now. Every item defaults to its own group if it doesn't have a group (probably a change on VS Code's side, but easy enough for us to fix on our side):

That's a vscode bug: https://github.com/Microsoft/vscode/issues/62875

Only repros on insiders.

Fixed in https://github.com/microsoft/vscode-cosmosdb/pull/1793

authors: EricJizbaMSFT StephenWeatherford ejizba

repo: microsoft/vscode-cosmosdb


text:
Cache not invalidated with non-source changed files

This doesn't actually matter now -- the sprockets cache gets updated

repo: middleman/middleman-sprockets


text:
sbt 1

Many thanks ... merging :-)

authors: milessabin xuwei-k

repo: milessabin/macro-compat


text:
refactor steppy-toolkit names: sklearn keras

done

repo: minerva-ml/steppy-toolkit


text:
Deprecate push  task

Turn it into a separate gem


text:
PAT-594 Add endpoint to retrieve user details given a list of multiple user names

superseding with another PR

repo: ministryofjustice/community-api


text:
组件 support new cache url

有个conflict mip-wkad/package.json @momofan 解决一下

repo: mipengine/mip-extensions


text:
is_local property for BaseRequest

Sorry, I don't think this belongs into Werkzeug.

repo: mitsuhiko/werkzeug


text:
Remove tools:ignore for allowsBackup

@joeatwork sorry to trouble you again. can you please let us know why we added AllowBackup?

@yinfeiru I believe lint was complaining. I'd rather have lint throw a warning (there are many lint warnings currently) than affect existing customers. We probably want to be able to merge manifests in the future.

merge it!

authors: patedit yinfeiru

repo: mixpanel/mixpanel-android


text:
Chang demo project structure to work with Idea + Spring Boot setup

OK.

repo: moberwasserlechner/vaadin-chartjs


text:
rename create_pipeline to new_pipeline

implemented in renaming branch

repo: monashbiomedicalimaging/arcana


text:
add grammar

LGTM


text:
Remove BitBucket references from Firefox documentation

Thanks!


text:
Redesign edit profile page

Initial rebased branch combining both frontend with discrete commits is here:
https://github.com/johngian/mozillians/commits/profile-ui-latest-rebased

I squashed all the UI to one commit since there was a single bug for the frontend stuff. Kept all the commit messages to describe the functionality.

@akatsoulas Do you think that I should also squash 3c465235630b3fc8b31db1a415c1744aa35d92dd with 6cdbcf63ca3f42dce84f1a7be77e0846f433e1ba to have a single commit for the backend?

@akatsoulas @comzeradd Please take a look to see if something went wrong in the rebase because there where many conflicts.

@johngian makes sense to me

PR still has some issues. Some of them can be tackled while QA works on updating the tests that gives us time to do some polishing. The rest of them are blocking this PR. FYI most of the blockers are already mentioned in previous reviews.
Some things might also be broken because of the rebasing that's why we need to take a look.

Blocking

* TODO Issue with privacy buttn in external accounts save
** TODO JS buttons doesn't initialize hidden privacy input
*** Steps to reproduce:
*** Go to external accounts
*** Add >2 external accounts
*** Inspect hidden privacy element
*** Default value = " "
* TODO Wrong position for privacy errors http://pix.toile-libre.org/upload/original/1441800668.png
* TODO Delete account button is clickable by default
** Steps to reproduce
*** Edit your profile, go to delete section
*** Delete button is clickable
*** Toggle the value
*** Now the button is not clickable
* TODO Location form needs some love (registration) - too much space http://pix.toile-libre.org/upload/original/1441795455.png

Non blocking

* TODO Add messages on profile creation to inform user to fill the profile
* TODO Persona button still misaligned (compare with prod)
* TODO Front page vertical line/alignment changed (need to double check UI with more data)
* TODO Misaligned (view groups, functional areas) http://pix.toile-libre.org/upload/original/1441793788.png
* TODO Fix UI for link contribution story
* TODO Fix UI for country/region/city
* TODO Fix next per section not per tab
* TODO Contribution section has different types of textboxes http://pix.toile-libre.org/upload/original/1441794640.png

I'm pushing small commits on branch comzeradd:profile-ui-2 that fix each of the pending issues.

Updated branch comzeradd:profile-ui-3

@akatsoulas Added latest changes and updated notes above. Do you want take a look or should I merge ?

@akatsoulas bump

Haven't tested this. The changes in the back-end look good code-wise. Since you have reviewed the UI multiple times, I skipped it completely.  Having said that, I still have a pending comment on profile_edit.js. For me it seems to be working fine without those lines.
r+wc :beers: :rocket:  really nice job.

I've tested this branch and it seems to be OK in terms of functionality.
@comzeradd Any comments about @tasos comment?

The specific line is needed for the mobile view to display properly in cases where a user opens a url with a location.hash (eg. #groups) that it's not visible on mobile. Otherwise user gets an empty page.

After doing some testing it seems that the user gets the correct page (eg. #mygroups). The only problem is that it's collapsed. If you click the Show all settings it correctly expands the mygroups section. This happens without those lines. If we leave those lines there and you try to open the mygroups hash then you get an open page starting from the basic info.

Yes, that's the intended behavior. A user should never get an empty page with just a reveal button. This js code ensures that profile and location settings are always visible on mobile.

I agree, the user should never get a page with an expand button. The solution is to have the page expanded to the correct hash and not collapsed. With the solution that you are proposing to this PR the user gets all the profile page from the top, which is the basic info, and not the correct hash (eg #mygroups).

Yes, the user should always get the mobile view of Settings regardless on how he landed there. Otherwise he'll struggle to realize how to get to Profile settings without the sidebar.

@johngian we reviewed the registration page with @ppapadeas and it just needs a minor fix for now. Can you cherry-pick the last commit on my branch.

I am not quite sure we are talking about the same thing. Probably, I am not understanding something right. I am going to re-check this thoroughly. That being said, one last question, can't we use a media selector for this?

On mobile view we don't use location.hash to amend the view. So my take is that we should ignore it even when it's present. That's why unfortunately we can't use a media selector to do this. We can only do this in js.

authors: akatsoulas comzeradd johngian

repo: mozilla/mozillians


text:
Update virtualenv var.

Looks ok. r+

authors: akatsoulas johngian


text:
[bug 1208368] Exclude curators from invalidation.

Code looks OK, though I haven't tested it locally.
Please add some tests and make sure that the correct waffle switches are set in prod.

r+wc


text:
Push a verified profile to CIS.

Coverage increased (+0.0009%) to 90.741% when pulling 54ce8e606fc795736c10f0bce80cd047fc8974ad on akatsoulas:push-verified-profiles-to-cis into 4a1783433255c6742f7d72b3cdb7cf4593a0c383 on mozilla:master.

authors: akatsoulas coveralls


text:
Nginx plus integration test

@mrkschan Wasn't aware that cover is part of the standard repo. Good to know, means we can also remove it on our side.

close #35

@ruflin Actually, I find that the docker container cannot go get it and then took a look at the docs of cover, where I find it's no longer maintained according to the docs.
FYI, find below the error message from the docker container.
mkdir -p build/coverage
# coverage tools
go get golang.org/x/tools/cmd/cover
package golang.org/x/tools/cmd/cover: unrecognized import path "golang.org/x/tools/cmd/cover"
scripts/Makefile:70: recipe for target 'prepare-tests' failed
make: *** [prepare-tests] Error 1

Removing it in all our beats: https://github.com/elastic/beats/pull/1072

authors: mrkschan ruflin

repo: mrkschan/nginxbeat


text:
Fix path of file to edit on app page

@vbhargavmbis Thanks for the contribution (and finding this). As the path is agnostic to how you install (with/without Express as) - would you mind to update the PR to respect that?
Alternatively can you give me edit rights on the PR, so that I can push that change? Thanks!

No response from contributor.

authors: muenzpraeger vbhargavmbis

repo: muenzpraeger/lwc-create-app


text:
Make sure vbomange installed with $VBOX_MSI_INSTALL_PATH is defined

This looks great.
@mattn - we do a similar check for vagrant in util/vagrant.go, do you know if we would need to make a similar update there as well?

updated.

oops. sorry. debug message ramains. will fix soon

Ah, probably it should be same on non-windows OSs.

done

@mattn looks good. I like exec.Lookpath(), I wonder if we use that with virtualbox as well (just for consistency) rather than exec.Run()? What are your thoughts?

VirtualBox on windows doesn't modify $PATH. But set $VBOX_MSI_INSTALL_PATH instead.
And vagrant is unix like tool. So it append the path into $PATH.

@mattn great, thanks for clarifying that. I'll go ahead and merge this in

authors: mattn sdomino

repo: nanobox-io/nanobox


text:
is it possible to create a Home app push notification when when a defined weather condition exist ?

You can use the eve homekit app to create automations based on the weather condition category but I think no notifications.

repo: naofireblade/homebridge-weather-plus


text:
Update podaac_utils.py

Coverage remained the same at 88.18% when pulling 8eb6ed7f571778ad46f8f61a4c0764891c10e9ec on STejas6:patch-1 into 9ec1e5b790e1379dc7291420d497b0be381e4d35 on nasa:master.

repo: nasa/podaacpy


text:
Don't call refresh_market_info in Binance constructor

#77

It's required to have the market information to place an order in order to round the decimal to the correct values. You can see the different tests placing orders failed.

authors: mankinskin steffenix

repo: nash-io/openlimits


text:
Restricting access to users s3 objects

Thanks for adding so much detail! It should be really useful when we're referring back to it.

authors: TomJKing suzannehamilton

repo: nationalarchives/tdr-dev-documentation


text:
Bump rubocop version and linelength restrictions

👍

authors: luke-hill tgaff


text:
Change kotlin dependency to compileOnly

Reviewed by: @sanha @sjstyle

repo: naver/spring-jdbc-plus


text:
Upgrade react 16

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #37   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           3      3
  Lines          17     17
=====================================
  Hits           17     17

Impacted Files
Coverage Δ

src/__tests__/setup.js
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9727007...12fb32f. Read the comment docs.


text:
chore: update ckb contracts deps

Codecov Report

Merging #206 (258906c) into main (dab9785) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   36.13%   36.13%
=======================================
  Files          53       53
  Lines        6002     6002
  Branches      139      139
=======================================
  Hits         2169     2169
  Misses       3833     3833

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dab9785...8205182. Read the comment docs.

authors: codecov-io huwenchao

repo: nervosnetwork/force-bridge-eth


text:
Accept user name password from env. Closes #38

Codecov Report

Merging #39 into master will decrease coverage by 0.18%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   93.95%   93.76%   -0.19%
==========================================
  Files          16       16
  Lines         430      433       +3
==========================================
+ Hits          404      406       +2
- Misses         26       27       +1

Impacted Files
Coverage Δ

pyns/api.py
97.36% <66.66%> (-1.27%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 648a597...6a0e308. Read the comment docs.

authors: adelavega codecov-io

repo: neuroscout/pyNS


text:
Fix Prism components loading order

Coverage remained the same at 100.0% when pulling eaf18ad69eb23153d66cad5fa3f4258aca6599bf on fix-prism into d4e150240d7819ae4e9ccb101e69587a0ce10feb on master.

Coverage remained the same at 100.0% when pulling 9b70a96359aa7a004d46f6cb5fad2642e8da7dc5 on fix-prism into d4e150240d7819ae4e9ccb101e69587a0ce10feb on master.

Coverage remained the same at 100.0% when pulling 0b124748fa546d923f4c9914cb4ddc885ed748e3 on fix-prism into d4e150240d7819ae4e9ccb101e69587a0ce10feb on master.

authors: coveralls ngs

repo: ngs/draft-js-markdown-shortcuts-plugin


text:
Move net into its own package

Coverage increased (+10.9%) to 45.326% when pulling 4c33e3aaaebafb4fd567361ab8bb18edf2c37e50 on refactor/move-net into 957f2b6b19c04bfe0d7637afe9d6f6bb6bf169fd on master.

authors: coveralls geoah

repo: nimona/go-nimona-fabric


text:
Fix circle ci badge

Thanks!

authors: OrdonTeam nmoskalenko

repo: nmoskalenko/RxFirebase


text:
《致姗姗来迟的你》播放时是另外一首歌

阿肆的？歌曲 ID 是多少
请贴上 log 截图说明匹配到了哪个地址
我试了下没问题
今天凌晨 3 点有次 release，修了一个匹配的 bug，请检查版本
遇到问题先去搜搜 issue #74 #76
Duplicate

[432506809] 致姗姗来迟的你
http://p1.music.126.net/8vj0Gicm_uMNu6JrztqVEA==/18669707440351870

是这个问题，已经 fix，请 pull 新版本

👌

之前重拉代码《致姗姗来迟的你》匹配正确，这次重拉代码，《致姗姗来迟的你》又匹配错误了

之前重拉代码《致姗姗来迟的你》匹配正确，这次重拉代码，《致姗姗来迟的你》又匹配错误了 @nondanee

@attenton
我没有问题，匹配到的地址贴一下，应该就是这个
http://p1.music.126.net/itvWex5x8yZtFjF97u09Vw==/18669707440351874

好像是因为之前缓存了错误的歌曲，清了缓存就好了，多谢

authors: attenton nondanee

repo: nondanee/UnblockNeteaseMusic


text:
Mention the version of dal it reuses concepts from

thank you for this (tiny, but precise) patch ;o)

authors: brunobord jpic

repo: novafloss/django-agnocomplete


text:
solve delete user bug + allow Mac os read

test comment from nlt cli


text:
[T4A3][T14-B2] Chen Rui Wen

@ruiwen905 Please create a new branch for each unrelated activity.


text:
[T6A3][W11-C3] Albert Yeoh Ji Bin

You should have removed this or combine it into your group PR..

authors: bertojo jeffryhartanto


text:
Add 'Debugging tests on macOS' notes

Codecov Report

Merging #3724 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #3724   +/-   ##
=======================================
  Coverage   98.25%   98.25%
=======================================
  Files          18       18
  Lines        1144     1144
  Branches      308      308
=======================================
  Hits         1124     1124
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f184016...a56a669. Read the comment docs.

authors: codecov-io galvez


text:
add 404 to activate and deactivate

Great!!! now test coverage improved! thank you!!


text:
add fine grain API to ui admin

fixed in #2577

repo: odpi/egeria


text:
Update kustomization.yml

@msigis thanks!

repo: okteto/polling


text:
Refactoring

Codecov Report

Merging #97 into master will increase coverage by <.01%.
The diff coverage is 95.76%.

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   98.98%   98.98%   +<.01%
==========================================
  Files          11       13       +2
  Lines        1572     1579       +7
==========================================
+ Hits         1556     1563       +7
  Misses         16       16

Impacted Files
Coverage Δ

correios/client.py
100% <100%> (+2.87%)
:arrow_up:

correios/serializers.py
100% <100%> (ø)

correios/models/builder.py
90.24% <90.24%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2fff3d...eefb21b. Read the comment docs.

Why you put builder in models package but not the serializer?

Why you put builder in models package but not the serializer?

For me, serializer and model are distinct things. Model has the code logic and serializer only represents that. It makes no sense for me to be together.

For me, serializer and model are distinct things. Model has the code logic and serializer only represents that. It makes no sense for me to be together.

I agree. So lets push this a little...
Add a new PostingList.serialize(serializer) method https://github.com/olist/correios/blob/master/correios/models/posting.py#L684:
def serialize(serializer_class: PostingListSerializer):
   serializer = serializer_class(self)
   serializer.validate()
   return serializer.get_result()

... then we refactor the current serializer code and clients do make it work correctly...
What you think?

... then we refactor the current serializer code and clients do make it work correctly...
What do you think?

IMHO it seems weird the serialization being done by the model and by using type hints it makes look like the model is tied to the PostingListSerializer.
But I think it would be good to have the serializer related to the model and have:
serializer = Serializer(model)
serializer.validate()
serializer.get_xml()

instead of
serializer = Serializer()
document = serializer.get_document()
serializer.validate(document)
serializer.get_xml(document)

IMHO it seems weird the serialization being done by the model and by using type hints it makes look like the model is tied to the PostingListSerializer.

The Model.serialize(serializer) is a helper method. Helper methods exists to make life easier in the best style of Zen of Python "Although practicality beats purity". The responsability for serialization still relies on the Serializer class.
On the other half of your comment you suggest
serializer = Serializer(model)
serializer.validate()
serializer.get_xml()

This construction is "ok" if your serializer exists to serializes only one model. Example:
result = []
for posting_list in posting_lists:
    serializer = Serializer(posting_list)  # creates a serializer exclusively for this posting_list
    serializer.validate()
    result.append(serializer.get_xml())

Now using the idea that a Serializer 'serializes things'
result = []
serializer = Serializer()
for posting_list in posting_lists:
    serializer.validate(posting_list)
    result.append(serializer.get_xml(posting_list))

You can also extend and customize Serializer
r = []
serializer = Serializer(codec="iso-8859-1")  # serialize objects using iso-8859-1 codec
for obj in objects:
    serializer.validate(obj)
    r.append(serializer.get_xml(obj))

The main issue, at the end, is the .validate(obj) method in Serializer class that ends up with two responsabilities: validate && serialize objects. Could we include a deeper refactoring and move .validate() method into model class?

The Model.serialize(serializer) is a helper method. Helper methods exists to make life easier in the best style of Zen of Python "Although practicality beats purity". The responsability for serialization still relies on the Serializer class.

Then I would think a helper function would work better:
def serialize(model: Model, serializer_class: Serializer):
    serializer = serializer_class(model)
    ...

This way we don't tie the helper function to a specific model or serializer and it's still easy to use.

This construction is "ok" if your serializer exists to serializes only one model. Example:

I don't see any problem in doing things this way when performing serialization on a list of models...

You can also extend and customize Serializer

It's also possible to extend and customize Serializer the other way

The main issue, at the end, is the .validate(obj) method in Serializer class that ends up with two responsabilities: validate && serialize objects. Could we include a deeper refactoring and move .validate() method into model class?

Model validation and serialization validation are different. I think it does make sense to validate stuff on the model, but we can't just move serializer validation (that involves the loading of a xsd file etc.) to the model.

This way we don't tie the helper function to a specific model or serializer and it's still easy to use. But it requires the creation of the Model and Serializer base classes which I think makes sense if we're planning a bigger refactor.

Ok. This is a question of style. I don't like to use functions in an OO software.

I don't see any problem in doing things this way when performing serialization on a list of models...

I see. A lot. Why we need to instantiate one serializer for each model to discard it after serialization (refcount/GC costs memory and CPU)?

It's also possible to extend and customize Serializer the other way

Not in all directions. I can extend Serializer to extend more than one model, eg:

class XMLSerializer(Serializer):
    def __init__(self, charset="utf-8"):
        self.charset = charset

    def _get_xml_from_dom(self, dom):
        ...

    def serialize_posting_list(self, posting_list):
        for sl in posting_list.shipping_labels:
            ... = self.serialize_shipping_label(sl)
       return self._get_xml_from_dom(self, dom)

    def serialize_shipping_label(self, shipping_label):
        ...

In other way I'd have to implement one serializer for each model duplicating the code or creating a complex hierarchy of classes.
Besides that you will pay the price in usability and creates an artificial coupling between model and serializer:
class Serializer:
    def __init__(self, model, charset='utf-8'):  # we've data arguments *and* config arguments conflicting
        self.model = model  # now serializers has a model dependency

Model validation and serialization validation are different. I think it does make sense to validate stuff on the model, but we can't just move serializer validation (that involves the loading of a xsd file etc.) to the model.

So we need to ".validate()" the xsd internally in serializer but assure that the model is correct enough to guarante that serializer will never generate an invalid XML.

I'm closing this PR but I'm applying some parts of it on #109

authors: codecov-io jairhenrique lamenezes osantana

repo: olist/correios


text:
Added floki into quickstart

for https://github.com/oltarasenko/crawly/issues/62

@Ziinc Huge thanks for the changes!

authors: Ziinc oltarasenko

repo: oltarasenko/crawly


text:
Doesn't seem to work with React Native 0.8.0

did you have any luck with this Michael?

I guess my react is 0.9.0 , i just tried and its working. One of the error I found was this issue and got a quick fix from the reply  https://github.com/onefold/react-native-chart/issues/9

authors: arilitan cjmling michaelryancaputo

repo: onefold/react-native-chart


text:
Code | Numeric Pattern 173

@aryashah2k kindly assign it to me.

repo: openAOD/Python-PatternHouse


text:
Code | Numeric Pattern 273

@aryashah2k kindly assign it to me.


text:
Code | Numeric Pattern 314

@aryashah2k kindly assign this one to me.


text:
If R(m2g | CORR) < good; fix

@jovo @willgray we briefly discussed what is needed for the CORR paper in this regard today, but kind of left it hanging. Let's discuss the needs/requirements of m2g for CORR early next week?

i think what we need is a quantitative QC metric that enables us to justify
kicking out scans.
i'm not sure graph density is sufficient.
perhaps we can run disa's statistics suite and look at the distributions of
those ~7 n-dimensional features?
in summary, yes, let's discuss next week, either before the m2g meeting, or
at it.
On Fri, Jul 17, 2015 at 4:39 PM, Greg Kiar notifications@github.com wrote:

@jovo https://github.com/jovo @willgray https://github.com/willgray
we briefly discussed what is needed for the CORR paper in this regard
today, but kind of left it hanging. Let's discuss the needs/requirements of
m2g for CORR early next week?
—
Reply to this email directly or view it on GitHub
https://github.com/openconnectome/m2g/issues/93#issuecomment-122406533.

--
the glass is all full:  half water, half air.
openconnecto.me, jovo.me, office hours
https://www.google.com/calendar/embed?src=e2ktu4lrgul8anp8hclrcminp8%40group.calendar.google.com&ctz=America/New_York

in any case, i think you finished this task.
might need a new one to run corr again later.

authors: gkiar jovo


text:
WIP: refactor progress dialog

depends on https://github.com/opendatakit/androidcommon/pull/44

runtests

authors: clarlars wbrunette

repo: opendatakit/tables


text:
Show attribution on all maps

imagery-list.json:

Update title and attribution fields for Mapbox layers

authors: lambdatronic sirmspencer

repo: openforis/collect-earth-online


text:
Add verifier the ability to run tests (just flows testing content )

Going to deal with it in version 0.8 - when adding system tests & unit-tests to the content

repo: openscore/score-language


text:
Add: v1.4.0

Codecov Report

Merging #593 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #593   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files         183    183
  Lines        1828   1828
=====================================
  Hits         1828   1828

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855d420...a2a2a7b. Read the comment docs.

authors: codecov-io openset

repo: openset/leetcode


text:
fix issues with current code not compiling

LGTM :shipit:

repo: openshift/aws-account-operator


text:
adding error handling, fixing pylint issues

👍

authors: joelsmith rhdedgar

repo: openshift/openshift-tools


text:
Thes .sti directory does not need to be hidden.

@bparees I'm pretty much OK with this change, we indeed don't need to hide this directory...
[test]

This change is probably technically fine, but I just want to remind ourselves that we look for a .sti directory in repositories with user code. That's probably the reason why in sti-* repos we follow that pattern.

@rhcarvalho may be some completely different name (suggestions?) would help to prevent confusion.

@voxik I think the original idea was to allow users to copy the .sti directory (as it is) and then do customization of the scripts depending on their application. It is easier to advise them to just copy the .sti directory as it is than telling them to copy the content of XYZ directory. But I don't have any strong opinions here and I'm fine with different directory name (as long as it will be documented ;-)

@voxik I don't think yet another name would prevent confusion ;-)
On user's repo side, we'll most likely support .sti indefinitely, even if one day we decide to "rename" it (we'd then have to support two directory names for scripts).

@rhcarvalho we should in fact rename it to .s2i :D

yeah I sort of prefer the symmetry here that the directory name we use matches to what you'd use if you copied it into your source repository.  it guides the user a little bit better when they start trying to use this stuff in their own repo.
not to mention if we're going to change it here, we need to change it in all our s2i image repos.
Is there a strong argument for doing this?

It is inconvenient to work with the source code. You want to copy it around, the .sti directory is not included. You open it in your editor, but the directory is not show. You search for something, this directory is excluded. IOW, you don't typically care about dot files, even the .sti directory of the app is typically stuff you don't care about on daily basis, but this does not apply for this directory in this context.

@voxik make the rename ".sti->s2i" instead of ".sti->sti" (the dir inside the image will still be /usr/local/sti for now and that's fine) and i'll merge.

@bparees I updated the PR following your suggestion.

LGTM

@bparees IMHO changing the directory name to s2i now hurts the symmetry even more than .sti → sti.
I think of myself a few months ago, looking at sti-* repos for the first time. Imagine having sti-ruby contain a directory s2i with some scripts, while ruby-hello-world has .sti for similar scripts. That's unnecessary confusion.
Having all Source-To-Image script directories named consistently makes it easier to document and easier for users to understand and adopt the Source-To-Image tool, and hackers to create new custom image builders (like sti-lisp, if you will).
Can't we rename this directory while keeping the symmetry with what user repos can have? I propose we support s2i in other places before changing it here.

It is inconvenient to work with the source code.

@voxik I don't think it is that inconvenient in the source code editing and file manipulation perspective.

You want to copy it around, the .sti directory is not included.

I see two concrete use cases for this, both of which works without any special incantation:

copying 2.0/.sti or 2.2/.sti into a project for later customization

$ cp -vR 2.0/.sti /tmp/myproject/
‘2.0/.sti’ -> ‘/tmp/myproject/.sti’
‘2.0/.sti/bin’ -> ‘/tmp/myproject/.sti/bin’
‘2.0/.sti/bin/assemble’ -> ‘/tmp/myproject/.sti/bin/assemble’
‘2.0/.sti/bin/run’ -> ‘/tmp/myproject/.sti/bin/run’
‘2.0/.sti/bin/usage’ -> ‘/tmp/myproject/.sti/bin/usage’

copying 2.2 to 2.3 for bootstrapping support for a new Ruby version

$ cp -vR 2.2 2.3
‘2.2’ -> ‘2.3’
‘2.2/Dockerfile’ -> ‘2.3/Dockerfile’
‘2.2/Dockerfile.rhel7’ -> ‘2.3/Dockerfile.rhel7’
‘2.2/README.md’ -> ‘2.3/README.md’
‘2.2/.sti’ -> ‘2.3/.sti’
‘2.2/.sti/bin’ -> ‘2.3/.sti/bin’
‘2.2/.sti/bin/assemble’ -> ‘2.3/.sti/bin/assemble’
‘2.2/.sti/bin/run’ -> ‘2.3/.sti/bin/run’
‘2.2/.sti/bin/usage’ -> ‘2.3/.sti/bin/usage’
‘2.2/contrib’ -> ‘2.3/contrib’
‘2.2/contrib/.gemrc’ -> ‘2.3/contrib/.gemrc’
{snip}

Copy-pasting with Nautilus did the same correct thing too.

You open it in your editor, but the directory is not show.

Vim, Atom, Gedit, all show .sti for me.

You search for something, this directory is excluded.

Both find and grep works for me:
$ find . -name assemble
./2.2/.sti/bin/assemble
./2.0/.sti/bin/assemble

$ grep -lr puma_installed
2.2/.sti/bin/run
2.0/.sti/bin/run

Also works within text editors.

@rhcarvalho

copying 2.0/.sti or 2.2/.sti into a project for later customization

This would be very surprising if this would not work. You explicitly specify the directory. But I am the most interested in this:
$ mkdir foo
[vondruch@unused-4-232 sti-ruby (master %)]$ cp -R 2.0/* foo/
[vondruch@unused-4-232 sti-ruby (master %)]$ ls -la foo/
celkem 24
drwxrwxr-x. 4 vondruch vondruch 4096  4. srp 15.21 .
drwxrwxr-x. 7 vondruch vondruch 4096  4. srp 15.21 ..
drwxrwxr-x. 3 vondruch vondruch 4096  4. srp 15.21 contrib
-rw-rw-r--. 1 vondruch vondruch 1479  4. srp 15.21 Dockerfile
-rw-rw-r--. 1 vondruch vondruch 1155  4. srp 15.21 Dockerfile.rhel7
lrwxrwxrwx. 1 vondruch vondruch   12  4. srp 15.21 README.md -> ../README.md
drwxrwxr-x. 4 vondruch vondruch 4096  4. srp 15.21 test

You open it in your editor, but the directory is not show.

Vim, Atom, Gedit, all show .sti for me.

NerdTree does not show the directory, nor ":vim /DISABLE_ASSET_COMPILATION/ **/*" finds this key word in 2.0/.sti/bin/assemble

copying 2.0/.sti or 2.2/.sti into a project for later customization
This would be very surprising if this would not work. You explicitly specify the directory. But I am the most interested in this:

[vondruch@unused-4-232 sti-ruby (master %)]$ cp -R 2.0/* foo/

What's the use case for that and why should we support it?
IMHO this is about knowing how your shell works. Different shells will have different default behaviors and might be configured differently.

NerdTree does not show the directory, nor ":vim /DISABLE_ASSET_COMPILATION/ */" finds this key word in 2.0/.sti/bin/assemble

Not a NerdTree user myself, searching the web I found this:
Type :help NERDTreeMappings to read through all of the default keyboard shortcuts.
These are the ones I use the most frequently:

...
I: Toggle hidden files
...

I don't think we should justify changing code based on some particular tool. We can configure our tools to do what we want.

Dne 4.8.2015 v 16:01 Rodolfo Carvalho napsal(a):

    1) copying 2.0/.sti or 2.2/.sti into a project for later
    customization
    This would be very surprising if this would not work. You
    explicitly specify the directory. But I am the most interested
    in this:

    |[vondruch@unused-4-232 sti-ruby (master %)]$ cp -R 2.0/* foo/ |

What's the use case for that and why should we support it?
IMHO this is about knowing how your shell works. Different shells will
have different default behaviors and might be configured differently.

This is precisely what I need to do for import into OSBS.

NerdTree does not show the directory, nor ":vim
/DISABLE_ASSET_COMPILATION/ */" finds this key word in
2.0/.sti/bin/assemble

Not a NerdTree user myself, searching the web I found this
http://usevim.com/2012/07/18/nerdtree/:
|Type :help NERDTreeMappings to read through all of the default
keyboard shortcuts. These are the ones I use the most frequently: ...
I: Toggle hidden files ... |

While you have covered the former, you ignore the latter

I don't think we should justify changing code based on some particular
tool. We can configure our tools to do what we want.

This is obviously not about one tool. And when I need to open help to
find out something like you suggested for the NerdTree, then it is
obviously suboptimal.
But I don't think we should waste more time by this discussion. Some of
you are probably in favor this change, some others might be against. So
please either merge it or reject it.

@voxik sorry if our discussion frustrates you but i think it's been valuable.  keep in mind we have 5 s2i repos we're going to want to update if we make this change, not to mention whether we want to also rename the actual ".s2i" folder name within source repos, so while it seems like a trivial/no-downside change, it's not entirely free.
that said, "s2i" is the direction we want to move in and we can do this now w/o having to rebuild/update our images, so i'm going to merge it.
@voxik Are you also going to prepare PRs for the other 4 repositories (php, perl, python, nodejs) to rename there as well?

authors: bparees jhadvig mfojtik rhcarvalho voxik

repo: openshift/sti-ruby


text:
Normalize/divide MocoGoal outputs by number of subgoal terms (i.e. number of coordinates, markers, etc)

Advocated for by @brian-umberger. @carmichaelong also has some thoughts about this.
This could be a breaking change, so doing it sooner rather than later might be good.

Along the lines of @carmichaelong's idea of a flag, I think the flag could be generic and live in the base MocoGoal.
For the cost terms added by the solvers themselves, we don't need an option, I think.

authors: chrisdembia nickbianco

repo: opensim-org/opensim-moco


text:
Stable/juno

Thank you for contributing to openstack/cinder!
openstack/cinder uses Gerrit for code review.
Please visit http://wiki.openstack.org/GerritWorkflow and follow the
instructions there to upload your change to Gerrit.

authors: AshleyLai openstack-gerrit

repo: openstack/cinder


text:
preset for railway=tram_stop

https://wiki.openstreetmap.org/wiki/Tag:railway%3Dtram_stop

repo: openstreetmap/iD

license: ISC


text:
Shorten SinguarityRequest ID

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

  Generated by :no_entry_sign: Danger

Codecov Report

Merging #370 into master will decrease coverage by 0.02%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage   66.69%   66.67%   -0.03%
==========================================
  Files         145      145
  Lines        8198     8210      +12
==========================================
+ Hits         5468     5474       +6
- Misses       2289     2291       +2
- Partials      441      445       +4

Impacted Files
Coverage Δ

lib/deployment.go
84.21% <100%> (+1.65%)
:arrow_up:

lib/source_location.go
69.81% <66.66%> (-0.41%)
:arrow_down:

ext/singularity/deployer.go
69.71% <71.42%> (-2.01%)
:arrow_down:

ext/docker/image_mapping.go
74.61% <0%> (-0.88%)
:arrow_down:

lib/auto_resolver.go
89.55% <0%> (+1.49%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf70d4...36baa7f. Read the comment docs.

authors: alrs codecov-io sous-machine-account

repo: opentable/sous


text:
[dua] add NdProxy table on Backbone Router

This PRs adds the initial implementation of ND proxy table without Backbone related features.
Please take a look when you have time. @abtink @jwhui

repo: openthread/openthread


text:
add GenericTraitCatalogImp

Codecov Report

Merging #379 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   54.48%   54.48%   -0.01%
==========================================
  Files         341      341
  Lines       58417    58417
==========================================
- Hits        31829    31826       -3
- Misses      26588    26591       +3

Impacted Files
Coverage Δ

src/lib/profiles/security/WeaveCert.cpp
88.5% <0%> (-0.46%)
:arrow_down:

src/test-apps/TestCASE.cpp
95.89% <0%> (-0.23%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42cdfa...9e86faa. Read the comment docs.

authors: codecov-io yunhanw-google

repo: openweave/openweave-core


text:
Sending env in param

Nice work @laniltee
Lets try to fix the issue in loading tiles when frontend scrolling (Y)

authors: laniltee osandadeshan


text:
Use VerticalTabs widget for images in semantics

done


text:
Change to propagate exceptions thrown by commitAsync

Part of #117.


text:
Desktop 2.3.2: Release

@SamuAlfageme Can you help doing a smoke test for Windows and one of the Linux builds?
I'll do Mac now..

Looks good on staging.
@lefherz I am pushig live now, @guruz guruz writes an announcement now.

authors: guruz jnweiger


text:
Bump to pac4j 3.0.0

good point, I added it :)


text:
Add a setClientAuthenticationMethodAsString on the OidcConfiguration

Would some parsing need to be done here or there is a conversion available?

You should certainly use the static parse method of the ClientAuthenticationMethod class to take a String and create the ClientAuthenticationMethod.


text: Fix a bug where pool.Close() can crash

authors: derekchiang jdoliner

repo: pachyderm/pachyderm


text:
Fix packet link by adding protocol

Thanks!

authors: ThaiWood johnstudarus

repo: packet-labs/BGP-Anycast-Workshop


text:
WIP: add method to list files

@lachmanfrantisek I haven't found any reference to listing files in Pagure API yet. Are we going to merge and possibly add the Pagure method later?

@lachmanfrantisek I haven't found any reference to listing files in Pagure API yet. Are we going to merge and possibly add the Pagure method later?

If we don't currently need that, create an issue for it and we can go on with github/gitlab only for now.

In addition, have you already looked into the requre problem? It still does not work for me to generate the response files.

authors: lachmanfrantisek lbarcziova

repo: packit-service/ogr


text:
install python-kubernetes as an rpm

self-merging so I can deploy

repo: packit-service/packit-service


text:
DROID-737: Add support for GET v5/license (Percolate Java SDK)

@MarekPataky Approved with this note. Looks like test coverage went down in this PR. Any way to keep coverage level or improve in this PR?

authors: MarekPataky tabuchid

repo: percolate/percolate-java-sdk


text:
Update doc in README.md

Hi @gigglernitin thx for the PR but I am not sure it matches the scope of the component. The first headline is the component's name, its title "Web Photo Filter"  and it is kind of separate  of my Github handle, but thx anyway for the suggestion!

@peterpeterparker but try it
it looks cools

I definitely appreciate a lot that you took the time, thx a lot!
Just feel like the headline is ok like this and match the scope of the component.

authors: gigglernitin peterpeterparker

repo: peterpeterparker/web-photo-filter


text:
Fix the gradient of Gather by setting axis

/test

repo: pfnet-research/chainer-compiler


text:
step by step instructions on how to install windows with visual studio

thanks for installation guidance , I put it in the wiki page.

authors: rexdf taizan

repo: pfnet/PaintsChainer


text:
Review documentation

Reviewed the documentation, LGTM. Ready for release.

repo: php-http/promise


text:
Array exercises

Array exercises 4,5 and 6


text:
démarer la doc et interface API opendata

globaliser le system de Tokens et utilisation API Communecte

Bonjour, j'essaye d'accéder à l'api mais
curl https://www.communecter.org/ph/communecter/data/get/projects

me renvoie une 404. Est-ce qu j'ai mal compris comment accéder à l'API ?

salut Pierre Alexis
tu vas trouver ton bonheur ici
https://www.communecter.org/api
tu avais un pb d'url
amuse toi bien et merci de ton feedback

Super, c'est bon j'ai accès.
Par contre votre certificat SSL est pour www.communecter.org mais pas pour communecter.org :)

authors: RaphaelRIVIERE oceatoon pciavald

repo: pixelhumain/communecter


text:
Fix Crash Issue With Custom Structure DataPack

The error no longer recurs without this patch, I don't understand, I close this PR because of this.


text:
Fix small typos

+1

thanks!

authors: chantastic geolessel skylarsch

repo: planningcenter/react-patterns


text:
Remove spaces inside square brackets

Thanks for your contribution @Kosmas, but I feel this is more a cosmetic change so I'm gonna give it a no go.

@carlosantoniodasilva yes you are right that is a small style change.
But the reason for this PR, is that every time I (and suppose other people too), use a code review tool, I get warnings for the spaces, and I have to remove them manually.
See here for the reason the warnings come up: https://github.com/bbatsov/ruby-style-guide#no-spaces-braces
So by making this change, I believe many people would be happier if these warnings don't come up.
And further than this, inside the same file there are places that square brackets are used without spaces. So it would be more consistent too.

I'm sorry for the delay @Kosmas.
These code review tools make me somewhat :disappointed:. In any case, there are lots of other places in the devise source code that have the space convention, so if we'd ever change it, it'd have to be global, in a single commit.
I might take care of that in the future, thanks for your contribution.

@carlosantoniodasilva no worries.
And it's only about convention not religion ;-)
These two files are the ones that people see after using devise, since they are generated by devise. So maybe this is a special case.
But will try and have a look at the whole code and do a different PR, if you prefer that.
Thanks for replying

@Kosmas I merged a squashed version of your commits and did a final pass: 18b6064d74726147eccd69b24812000074261bbb, hopefully that should keep everyone happy now. Thanks!

@carlosantoniodasilva that is great ! Thank you very much for doing that. Sorry I did not get the time to do it myself. Thanks again!

authors: Kosmas carlosantoniodasilva

repo: plataformatec/devise


text:
Give an option when creating a db to use json instead of yaml

#32

repo: playsavage/savagedb


text:
HashTable

Замечания не критичные, принято полностью.
Но впредь лучше исправлять замечания :)

authors: dormidon igorlaryush


text:
Refactor to build my own

Sorry, clicked the wrong button accidentally.


text:
add a step multiplier when pressing 'alt'

Try this on letterbox sliders. It doesn't even have good defaults

reopen if you are going to make happen. closing due to inactivity.

authors: Jorolf peppy

repo: ppy/osu-framework


text:
Improved dmsisdn setting

@gsvr review please

Over the shoulder review. Thanks @gsvr

repo: praekelt/ndoh-control


text:
Removed features .org do not want in the final build.

:+1:

authors: chrislombaard phalamag

repo: praekelt/nurseconnect


text:
Refactor to component provider

problem with build, will reopen PR

repo: prinz-nussknacker/prinz


text:
Think about special kind of Hook that would allow implementing resolvers cache.

I was thinking about this a bit and actually, I'm hesitate a bit.
I'm starting to have strong opinion that caching should be domain of resolver function itself. Adding some 'top-layer' for such scenario might be good for some, but limiting for others.
While I believe @Before and @After hooks have some reasonable use-cases, another type of hooks that is able to interrupt resolver workflow might be wrong direction.
I'd see typegql more like library rather than framework.
If there will be no external input about it, I'll close issue without adding such Hooks.

repo: prismake/typegql


text:
Fix babel

Deploy preview for koku ready!
Built with commit 6bd87a712f1a83d316c88b9baccc1ba033f0b566
https://deploy-preview-43--koku.netlify.com

repo: project-koku/koku-ui


text:
Reject content

Codecov Report

Merging #508 into release-2.2.0 will decrease coverage by 0.12%.
The diff coverage is 5.45%.

@@                 Coverage Diff                 @@
##             release-2.2.0     #508      +/-   ##
===================================================
- Coverage            32.36%   32.24%   -0.13%
- Complexity            1225     1228       +3
===================================================
  Files                  170      171       +1
  Lines                15010    15100      +90
  Branches              2377     2395      +18
===================================================
+ Hits                  4858     4869      +11
- Misses                9422     9501      +79
  Partials               730      730

Impacted Files
Coverage Δ
Complexity Δ

...g/ekstep/taxonomy/mgr/impl/ContentManagerImpl.java
72.41% <0%> (-2.59%)
15 <0> (ø)

...kstep/taxonomy/controller/ContentV3Controller.java
51.33% <0%> (-2.15%)
18 <0> (ø)

...g/ekstep/taxonomy/mgr/impl/BaseContentManager.java
55.89% <100%> (+0.12%)
69 <0> (ø)
:arrow_down:

...nt/mgr/impl/operation/content/RejectOperation.java
2.38% <2.38%> (ø)
1 <1> (?)

...ava/org/ekstep/content/mgr/impl/ContentManger.java
85.71% <50%> (-5.96%)
6 <0> (ø)

...kstep/framework/mgr/impl/FrameworkManagerImpl.java
75.86% <0%> (-8.43%)
22% <0%> (ø)

...ntent/mgr/impl/operation/plugin/CopyOperation.java
27.09% <0%> (-2.25%)
8% <0%> (-1%)

...ep/framework/controller/FrameworkV3Controller.java
91.07% <0%> (-1.79%)
8% <0%> (-1%)

...va/org/ekstep/graph/cache/util/RedisStoreUtil.java
0% <0%> (ø)
0% <0%> (ø)
:arrow_down:

.../ekstep/learning/framework/FrameworkHierarchy.java
0% <0%> (ø)
0% <0%> (ø)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85db72c...bc99f39. Read the comment docs.

authors: codecov-io rheafernandes


text:
Email notification service for course batch operation i.e: enroll unenroll

Release 1.11 is completed. Closing this PR. Please raise a new PR once you are ready with the rework.

repo: project-sunbird/sunbird-utils


text:
Upgrade to v2.2.1 of the NewRelic Terraform Provider

What does it take to make this happen?
Is this something I can make a PR for?

This was blocked by: https://github.com/pulumi/pulumi-terraform-bridge/pull/238
I took a stab at updating this project without completely knowing what I am doing:
https://github.com/pulumi/pulumi-newrelic/compare/master...fieldju:feature/upgrade_new_relic_terraform_provider?expand=1
After running make build and yarn linking the resulting node lib and trying things out locally, I was not able to make it all work:
Previewing update (prod):
     Type                          Name                                Plan     Info
     pulumi:pulumi:Stack           plumi-newrelic-infrastructure-prod
     └─ pulumi:providers:newrelic  default_3_1_0_RC1                            1 error
Diagnostics:
  pulumi:providers:newrelic (default_3_1_0_RC1):
    error: rpc error: code = Unknown desc = could not validate provider configuration: 1 error occurred:
        * Internal validation of the provider failed! This is always a bug
    with the provider itself, and not a user issue. Please report
    this bug:
    1 error occurred:
        * resource newrelic_nrql_alert_condition: ConflictsWith: critical configuration block reference (term.0) can only be used with TypeList and MaxItems: 1 configuration blocks

I suspect I am not upgrading the underlying terraform provider properly.

ok @fieldju
We found the way forward for this work and I will be rolling this out this afternoon :) Thank you for your patience here!
Paul

This is great news, I will give it a go as soon as it is ready!

repo: pulumi/pulumi-newrelic


text:
(BKR-940) Update package testing to puppet 4.8.0

Wouldn't this be nicer if we had these values parameter-ized so that we could control them from the job rather than needing code changes? Below is one simple idea of how we might do this..
:version        => ENV['BEAKER_PUPPET_VERSION'] || '4.8.0',

What do you think?

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3369/

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/3370/

@ferglor if you merge this and rebase your PR, you should be good to go.

authors: kevpl puppetlabs-jenkins tvpartytonight

repo: puppetlabs/beaker


text:
(BOLT-697) Push to PCR for successful builds

CLA signed by all contributors.

authors: adreyer puppetcla

repo: puppetlabs/bolt


text:
Fact 1380

since there's no (obviously visible) link between github and puppet's jira, can you please be a little more descriptive in your PR?

CLA signed by all contributors.

authors: IrimieBogdan igalic puppetcla

repo: puppetlabs/facter


text:
(maint) mergeup 4.10.x -> 5.3.x

CLA signed by all contributors.

authors: johnduarte puppetcla

repo: puppetlabs/puppet


text:
(PDB-2800) Add release notes for PDB 4.1.2

:+1:

authors: mwaggett senior

repo: puppetlabs/puppetdb


text:
Readme 20

The git diff is too large to view on github. I've copied the readme contents to a private google doc for commenting.

Closing this PR in favor of 3.x PR.

authors: hunner jbondpdx

repo: puppetlabs/puppetlabs-netscaler


text:
Allow setting the cluster (defaulting to mt1 for backwards compatibility)

tested on testpypi

released as 0.2.0 https://pypi.python.org/pypi/django-pusherable

repo: pusher/django-pusherable


text:
Add coverage reporting & JUnit XML to tests.

Do we do that on the site? It doesn't seem like we do, and I have no idea how we would publish the HTML on Azure..

I did it on snekbox. It's actually pretty nice. You can reference that repo.

Does Azure have some place to view a graph of how code coverage evolves over time?

Does Azure have some place to view a graph of how code coverage evolves over time?

I don't see anything. If anywhere, my guess is it would be in the analytics tab. Perhaps some configuration in Azure can be done to add more analytics?

It definitely publishes it, I think maybe it'll add it to the analytics tab once the main branch has some?

Ah, actually, they're using this external tool to generate that table. Maybe not, then.

That tool looks like it can provide a history though and we can install it somehow, can't we? I think being able to view coverage history for the bot on there would be something useful to have.

Taken from here: https://docs.microsoft.com/en-us/azure/devops/pipelines/test/review-code-coverage-results?view=azure-devops

Doesn't "merging" mean this in that case?

as in "take multiple coverages and combine them", not "display a coverage summary"

authors: MarkKoz gdude2002 jchristgit

repo: python-discord/bot


text:
Export certificates in media directory

@euribates Cierro esta issue. Me da la sensación de que está hecha. Si no es así, puedes abrirla de nuevo. Gracias.

@euribates Cierro esta issue. Me da la sensación de que está hecha. Si no es así, puedes abrirla de nuevo. Gracias.

authors: euribates sdelquin

repo: pythoncanarias/web


text:
Modify /server/port endpoint to persist port change to config file

@jedesah -> Will this cover logfile location and SSL Configuration as specified in "Server" tab on the front-end or are those covered in a separate ticket?

This is done. Forgot to close. But no, it doesn't cover SSL and auditing config. This was done in Quasar whereas those two other things are specific to SlamData backend. Currently struggling with how to achieve reusability in SlamData Backend so to not just re-do the work that was done in Quasar. We've accumulated some technical debt in that regard

authors: jedesah zeeiyerWork

repo: quasar-analytics/quasar


text:
use npm for installation

Other than this package having nothing to do with Node, I'm all for this. Will work on getting this live soon.

Done! Install via npm install -g pyvm. :smile:


text:
Update README.md

readme doc


text:
setup.py: Fix reST

Thanks!

authors: msabramo rasbt

repo: rasbt/pyprind


text:
modified readme

Pull request must have been closed before completetion of jenkins job. Please check

Pull request must have been closed before completetion of jenkins job. Please check

Pull request must have been closed before completetion of jenkins job. Please check

repo: rashmichennagiri/dummy-csi


text:
DELIA-46592: Fix for setBlink API not working for single color

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant tijotjc

repo: rdkcentral/rdkservices


text:
Dependencies

SonarQube analysis reported 1 issue

 1 major

Watch the comments in this conversation to review them.

repo: rducom/TarCompressCrypt


text:
chore: upgrade dependencies

The total bundle-size has increased +2.5% just by upgrading the dependencies!? We need to look into this :thinking: cc @voliva

repo: re-rxjs/react-rxjs


text:
Removed Prettier configs. closes #4

closes #4

repo: reactrewind/react-rewind


text:
Make mget faster

LGTM

Maybe later

authors: ngaut siddontang

repo: reborndb/reborn


text:
react.createclass is not a function

same problem

How did this got resolveD?

There is a mistake in the index.js file.
go to node_modules/react-native-material-switch/index.js
and change the import statements like this:
import React         from 'react'
import {
  PanResponder,
  View,
  TouchableHighlight,
  Animated,
}                    from 'react-native'

I think the npm version has to be updated. because I used the index.js version and it worked. The npm version doesn't match the version that's posted here.

fixed in master. @recr0ns please publish new version

Warning: React.createClass is no longer supported. Use a plain JavaScript class instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement. (https://fb.me/migrating-from-react-create-class)

This error still occurs. Why are you still using createClass? Please fix.

authors: airTradies aligfl developer239 nidaorhan pencilcheck roots-ai skv-headless thebuddha


text:
Add a dockerfile + instructions to run the tool in a container

Thanks!

repo: rememberYou/gen-cisco


text:
Cartes annuelles AZUR

Cartes annuelles ajoutés en récupérant les tuiles servies par le serveur AZUR.

Reste à insérer la légende
Si application web, il faudra donc mapserver.

Ok


text:
OPS-3010 we now deserialize symbols in safe_yaml

Works for me!

authors: mark-dotson-rs markitoxs


text:
Fix typo in README.md

Thank you haha


text:
Add codecov

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@d6589a4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             develop     #40   +/-   ##
=========================================
  Coverage           ?   0.00%
=========================================
  Files              ?       1
  Lines              ?      30
  Branches           ?       1
=========================================
  Hits               ?       0
  Misses             ?      30
  Partials           ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6589a4...5f607b1. Read the comment docs.

authors: codecov-io ilanolkies

repo: rsksmart/rLogin


text:
Replace the name 'Dave Snider' with RTD

I don't think we have a standard way of doing it, but probably should. I think "Read the Docs, Inc & contributors" is probably the most legally correct.

I do feel bad removing Dave's name from the explicit listing, since it was his creation originally. Is there a problem we're trying to solve with this?

Not specifically just that we are not giving hardly any attribution to current authors. I would be fine with add Dave to "Read the Docs, Inc & contributors"

Are we agreed on "Dave Snider, Read the Docs, Inc. & contributors"?

"Dave Snider, Read the Docs, Inc. & contributors" sgtm.

authors: Blendify davidfischer ericholscher


text:
Fixed link to API reference

Bors r+

repo: rtfm-rs/cortex-m-rtfm


text:
fix initializer warning

Thanks!

authors: davidgoli runspired

repo: runspired/ember-gestures


text:
feature: report build times when using build.py (clock & cpu)

Fixed. Example of output:
Generate: 0:00:01.778906s
Build: 0:00:01.782562s
Framework creation: 0:00:00.321703s
Test: 0:00:00.020270s
-
Total: 0:00:03.903817s

authors: headupinclouds ruslo

repo: ruslo/polly


text:
add dirfd on unix

@bors: r+
Thanks!

:pushpin: Commit 8c83dd5 has been approved by alexcrichton

:hourglass: Testing commit 8c83dd5 with merge d8e5f64...

:broken_heart: Test failed - status-travis

Ah looks like this may not be defined on rumprun?

Interesting, because dirfd already appeared in 4.2BSD in 1983.

How can I exclude rumprun, but include netbsd?

I think there should be some examples in the netbsd module as well but the gist is to use target_vendor in the cfg.
Dunno what's up with rumprun to cause this failure...

@Mic92 Want to try pushing this again and seeing if it was a CI glitch? It'd be great to get this supported so we can support it in nix-rust/nix also.

still the same problem.

dirfd is declared in dirent.h in NetBSD. This header file is included by the build.rs script in libc-test. So I'm not certain what's the problem, though I'm not too familiar with the testing framework used by libc. @alexcrichton Any other ideas?

Could it be because dirfd is actually a macro on NetBSD? Source

Want to just duplicate it to each platform and leave it out on NetBSD?

I think the correct solution here is to just skip the check for this function on NetBSD. There's already precedent for this with many other functions.
Additionally it might be worth pinging some people in the NetBSD IRC and seeing if our understanding here is correct.

In nix we can just inline the netbsd macro.

@bors: r+

:pushpin: Commit 5900879 has been approved by alexcrichton

:hourglass: Testing commit 5900879 with merge 539e50c...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 539e50c4a966535c4028f0a49f79c5634477ad6e to master...

I would have suggested inlining that macro within libc instead of in a higher-level library as libraries will probably expect it to exist in libc on that platform. Would that be rejected if it was submitted in a separate PR?

Nah yeah we typically include macros for other platforms for common functionality, so including that for netbsd sounds fine by me!

@Mic92 Could I convince you to file an additional PR bringing dirfd to NetBSD as well? :-)

@Susurrus ^

authors: Mic92 Susurrus alexcrichton bors

repo: rust-lang/libc


text:
needs more cowbell

Can we assign this to @ryskiz?

repo: ryskiz/machi-koro-nyc