text:
Update Upgrade-to-the-new-Expensify-Card-from-Visa.md

fixing broken link:

https://github.com/Expensify/Expensify/issues/386408
https://expensify.slack.com/archives/C02QSAC6BJ8/p1717085671163579

Details

Fixed Issues

$
PROPOSAL:
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videosundefined

not having C+ review based on -- https://expensify.slack.com/archives/C02QSAC6BJ8/p1717086424606549?thread_ts=1717000880.405499&cid=C02QSAC6BJ8

A preview of your ExpensifyHelp changes have been deployed to https://c3b62815.helpdot.pages.dev ⚡

@rlinoz -- darn, the link is still broken on dev.
it must have to do with how the link is bumping up to the special formatting markdown:

do you know how to format that URL so that the link works within that text box?

You will have to drop the [url] and the parenthesis around the link
issue a new card.

issue a new card.
Also, I just tested and I don't think some other links are working, like the create an expense in the Track Expense page for the same reason.

@rlinoz - ah gotcha. let me do that now.

Also, I just tested and I don't think some other links are working, like the create an expense in the Track Expense page for the same reason.

Oy, okay. i can see if @rushatgabhane has an easy way to review/update those all at once.

done! https://github.com/Expensify/App/pull/42855#issuecomment-2145689946

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

authors: OSBotify maddylewis rlinoz


text:
fix: default notification to be hidden for new chat

Details

fix: default notification to be hidden for new chat
Fixed Issues

$ https://github.com/Expensify/App/issues/43218
PROPOSAL: https://github.com/Expensify/App/issues/43218#issuecomment-2157793520
Tests

Start a new chat/a new group chat
Click on the header of the newly created chat
Verify that the notify me about new messages option should not appear

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Start a new chat/a new group chat
Click on the header of the newly created chat
Verify that the notify me about new messages option should not appear

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/165644294/35dad2bd-7146-4187-b2fb-7729176e3cdd

Android: mWeb Chrome

https://github.com/Expensify/App/assets/165644294/dbeb68e0-e48f-4838-9dd3-48c8f51b0fbe

iOS: Native

https://github.com/Expensify/App/assets/165644294/edb257ad-2a94-48f7-9675-7b33a62819ee

iOS: mWeb Safari

https://github.com/Expensify/App/assets/165644294/269e517d-ca9f-49d9-be36-17778acf8abf

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/165644294/c747365c-093c-47f5-86b7-1078fe10fcb0

MacOS: Desktop

https://github.com/Expensify/App/assets/165644294/0a6b4d90-8301-444b-86e4-2a586de1c1ac

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@cead22 All yours

[x] Verify that no errors appear in the JS console
[x]  I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)

@dominictb @DylanDylann you checked these, but there are console errors. Can you link to where they're being addressed?

encountered two children with the same key
this syntethic event is reused for performance
function components cannot be given refs

And out of curiosity, do you fill out the checklist by reading each item for each PR, or do you check them all in one go now that you're used to submitting PRs in this repo? It's ok if it's the latter, you wouldn't be the first that do these, and I want to know to see if we need to change this solution
Also, do you know if these bugs have been reported? If not, can you report them?
Menu items truncated / not full width

one
two

Floating referral box and compose box / Bottom of the screen not calculated correctly

one
two
three

Only the first and the third warning logs will need to be fixed, the second one is from warning log from RN devtool I believe so @cead22 . I believe we don't need to fix that, or I'm not really sure whether we can fix/disable it properly. For the first and the third one, should I report that on Slack or what @cead22 @DylanDylann?

Yes, please report them on slack, including the RN dev tool one, so we can have a discussion about it. And link those discussions here

It's more on the latter, even though I think as a contributor I could still follow the checklist consistently without explicitly checking for individual items. For example, if I encounter some weird error logs, I will report it immediately, but the warning logs you saw seem date back long time ago, so probably me (and some others) are well trained to ignore it, thinking it might have been reported/fixed by someone else.

Totally. I think it'd be ideal if we start reporting every single console warning or error, and that way we can prioritize fixing them, so it'll be uncommon when they happen. As opposed to now, where they're very common, but we've been seeing them for a while so they don't get as much attention. What do you think?

@cead22 I recalled these bugs have been reported somewhere as deploy blockers? I haven't been able to pin down the exact reported issue numbers, maybe @DylanDylann can try? ll try to merge main again to see if the issues are fixed.

If you find the slack convos, feel free to revive them, and if not, let's start new ones

@cead22 Thanks for the reminder, I'll keep that in mind in the next PRs. @dominictb created a Slack thread on the Open Source Channel. Should I bring these bugs to #expensify-bugs channel?

Should I bring these bugs to #expensify-bugs channel?

If the convos aren't moving forward, or we don't have issues for these warnings, then yes let's report them on expensify-bugs to get issues created for these and get them fixed

🚀 Deployed to staging by https://github.com/cead22 in version: 9.0.2-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

source: gharchive/pull-request

authors: DylanDylann OSBotify cead22 dominictb

repo: Expensify/App

license: MIT

license_type: permissive

license_source: github-api


text:
Changed Personal and Company Address Labels

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/4631
Tests / Web QA

Head over to http://localhost:8080/bank-account/new or http://staging.new.expensify.com/bank-account/new
Click Connect Manually
Enter 123123123 for both fields
Observe the label on the Company Address input.

Tested On

[ ] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

cc @MitchExpensify

I'm assuming @shawnborton will want a little bit more space between the input and the text, but anything else Shawn?

Can we use our hint text styles for the text that goes under the input? It should be at 13pt (in our fontSizeLabel var), in our colorMuted text color, and have a margin between the label and the input of 8px (or mt2). We might already have a style for it.

+1 to @shawnborton

Updated the code and the screenshot in the description. Lemme know what you think @shawnborton
I wouldn't mind scooting the message to the right but it depends on whether that's consistent with our design philosophy.

Looks good! I like it aligned to the left, I think that is consistent with other places as well. The only thing I am curious about is perhaps we want to make the gap between input and hint just 4px, this way it looks more like the hint is tied to the input above it? Otherwise right now it kinda floats perfectly in between inputs and doesn't look quite visually connected to what's above. Thoughts on that?

Yea I think it looks better with 4px 👍

Looks good to me, thanks Luke! All yours @Jag96 and @tylerkaraszewski

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Going to CP this to staging to check it off the deploy checklist

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by @Jag96 in version: 1.0.85-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


text:
Fix user can edit tag name to existing tag name in X:Y format

Details

Currently, if we edit a tag name in X:Y format, we can edit it to the existing tag name. This PR fix it.
Fixed Issues

$ https://github.com/Expensify/App/issues/45067
PROPOSAL: https://github.com/Expensify/App/issues/45067#issuecomment-2217636309
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Open workspace tag page
Add 2 new tags in X:Y format
Open the 2nd tag and try to edit the name to the 1st tag name
Verify an error that the tag already exists is shown

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/f7384e2b-3200-4327-be56-bd5d8b91ecd1

Android: mWeb Chrome

https://github.com/user-attachments/assets/c38a3362-a24a-4949-9ade-e695568b30c0

iOS: Native

https://github.com/user-attachments/assets/38fab47f-66b4-4cb4-887a-9e0a9ef3ab5b

iOS: mWeb Safari

https://github.com/user-attachments/assets/854c47f8-8d0d-4e5a-88e5-e02720c8f2e0

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/4b0fb3d9-e2c4-4157-a4ed-dd41b5623608

MacOS: Desktop

https://github.com/user-attachments/assets/85d3003c-3a88-4f4e-8c60-180a3bde9875

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@bernhardoj this probably doesn't need to CP'd, right? Since this PR fixes a case in a PR that fixed a bug in staging & prod...

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.0.20-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Beamanator yeah, I don't think this needs a CP since https://github.com/Expensify/App/pull/46556 probably is not on staging yet, and also this isn't a regression but fixing another existing bug in prod.

FYI I believe this was deployed to prod yesterday, from this checklist - #47356

authors: Beamanator OSBotify bernhardoj


text:
Bump react-native-live-markdown to 0.1.187

Explanation of Change
We need to bump react-native-live-markdown  because there were several fixes introduced in the library, as part of keeping E/App up to date.
Also quite soon we would like to add worklets to this library which will unblock: https://github.com/Expensify/App/issues/50949
This version is a step that has to be done before that.
Changes introduced:
https://github.com/Expensify/react-native-live-markdown/commits/0.1.187
Fixed Issues

$ https://github.com/Expensify/App/issues/50949
PROPOSAL:
Tests

verify that live markdown input works correctly on chats
verify that live markdown input works correctly on forms

Offline tests

QA Steps

open chat
test live markdown functionality in the chat input (composer),
also test input in other places like description field in expense forms

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/ee7fd7b3-5419-4ae0-8b1a-1d8d21280dba

Android: mWeb Chrome
https://github.com/user-attachments/assets/f323bc5a-10c3-40eb-adde-ba5ce8e961f9

iOS: Native
https://github.com/user-attachments/assets/edbed0f6-f254-4393-bbb1-efcf6568fa15

iOS: mWeb Safari
https://github.com/user-attachments/assets/8b029c33-1608-4c7d-a5a8-65bbf57a9909

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/0a633dd9-a563-4fb4-822b-7d1106de19da

MacOS: Desktop

CC @tomekzaw @289Adam289 I did not verify the native builds yet, will open the PR once this is tested.

I have tested on all platforms and provided videos, everything seems ok.
Would be probably safe to have some QA test this as well?
CC @tomekzaw @Skalakid @luacmartins (Carlos is involved in Search, and we need live-markdown to be on newest version for introducing worklets later)
Also @thienlnam I heard you are involved in bumping RNLM as well :)

Would be probably safe to have some QA test this as well?

I think we can go ahead with out. We'd know pretty fast into regression if there's something wrong and this would be an easy revert, so I don't think we need to run regression tests on an adhoc build

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

authors: Kicu OSBotify ikevin127 luacmartins


text:
Android - Chat - Tapping plus opens chat instead of new or group chat options

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Expected Result:
2 options appear. One to create a new chat and one to create a group.
Actual Result:
Opens the chat window, + button non functional
Action Performed:

Launch the app and login
Tap the +button

Workaround:
No workaround.
Platform:
Where is this issue occurring?
Web
iOS
Android ✔
Desktop App
Mobile Web
Version Number: 1.0.11-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Issue not reproducible in production.
https://user-images.githubusercontent.com/44479856/113362234-eb89aa80-931b-11eb-9f81-1b667ce59ddb.mp4
Expensify/Expensify Issue URL:

This regression was caused by https://github.com/Expensify/Expensify.cash/pull/2183

https://github.com/Expensify/Expensify.cash/issues/2151

cc @aliabbasmalik8

source: gharchive/issue

authors: isagoico marcaaron


text:
bugfix

Description
This PR fixes a bug in the hipen vacuum test in which multiple indizes were passed instead of an integer.
Status

[ ] Ready to go

Codecov Report

Merging #21 (a23534d) into main (c02f78e) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

authors: codecov-commenter wiederm

repo: Exscientia/StableNetGuardOwl


text:
Add controller-branch

Add controller-branch
Modify service-branch

Add controller-branch
Modify service-branch

repo: Ezeah/person-api


text:
🛑 SM Medialogia is down

In ebf9cd5, SM Medialogia (https://sm.mlg.ru) was down:

HTTP code: 0
Response time: 0 ms

Resolved: SM Medialogia is back up in 27d751f after 6 minutes.


text:
Added EEPROM option for saving the antenna delay

Q
A

Bug fix?
no

New feature?
yes

Doc update?
no

BC breaks?
no

Deprecations?
no

Relative Issues
#62

I added some methods to save anttenna delay in the EEPROM, some sample code:
  uint16_t randNumber = random(300);
  Serial.println("Now in EEPROM: " + String(DW1000Ng::getSavedAntennaDelay()));
  Serial.println("TX delay: " + String(DW1000Ng::getTxAntennaDelay()));
  Serial.println("RX delay: " + String(DW1000Ng::getRxAntennaDelay()));
  DW1000Ng::setAntennaDelayFromEEPROM();
  Serial.println("Restored from EEPROM");
  Serial.println("TX delay: " + String(DW1000Ng::getTxAntennaDelay()));
  Serial.println("RX delay: " + String(DW1000Ng::getRxAntennaDelay()));
  Serial.println("Got random num: " + String(randNumber));
  Serial.println("Saving");
  DW1000Ng::setAndSaveAntennaDelay(randNumber);
  Serial.println("Now in EEPROM: " + String(DW1000Ng::getSavedAntennaDelay()));
  Serial.println("TX delay: " + String(DW1000Ng::getTxAntennaDelay()));
  Serial.println("RX delay: " + String(DW1000Ng::getRxAntennaDelay()));
  Serial.println("------------------------------------------");

Gives the following output:
15:18:37.582 -> Now in EEPROM: 177
15:18:37.582 -> TX delay: 0
15:18:37.582 -> RX delay: 0
15:18:37.627 -> Restored from EEPROM
15:18:37.627 -> TX delay: 177
15:18:37.672 -> RX delay: 177
15:18:37.672 -> Got random num: 219
15:18:37.672 -> Saving
15:18:37.717 -> Now in EEPROM: 219
15:18:37.717 -> TX delay: 219
15:18:37.717 -> RX delay: 219
15:18:37.762 -> ------------------------------------------

Hope this is what was needed, please comment if this is incorrect.

Hi @Bartvelp, thanks for this pull request, it's very useful.
I think there is a bug in this code, though. Based on your code the maximum settable antenna delay is 255. In fact, you can specify an only one-byte position, so you can only hold a value from 0 to 255. Depend on your circuit the antenna delay can be > 255. You should identify how many bytes are required (based on the antenna delay input) and then use a for loop to write the value in one or more memory locations.
The most complex part of the code could be for the "get" method.
Another trick to increase EEPROM life can be the use of .update() method, in case of the value (already saved into the EEPROM) is the same you had.

Hi @Sonic0
Thanks for your interest, I am trying to participate a bit in the hacktoberfest. But I am afraid you've mistaken EEPROM.put() for EEPROM.write()
This .put method can be used a lot more freely and is not constrained to 1 byte values, see the docs here.
It also already uses .update() internally so the EEPROM life should be fine if you call it a lot with the same value
Here is some output from values > 255.
Code:
  uint16_t randNumber = random(65535);
  Serial.println("Now in EEPROM: " + String(DW1000Ng::getSavedAntennaDelay()));
  Serial.println("TX delay: " + String(DW1000Ng::getTxAntennaDelay()));
  Serial.println("RX delay: " + String(DW1000Ng::getRxAntennaDelay()));
  DW1000Ng::setAntennaDelayFromEEPROM();
  Serial.println("Restored from EEPROM");
  Serial.println("TX delay: " + String(DW1000Ng::getTxAntennaDelay()));
  Serial.println("RX delay: " + String(DW1000Ng::getRxAntennaDelay()));
  Serial.println("Got random num: " + String(randNumber));
  Serial.println("Saving");
  DW1000Ng::setAndSaveAntennaDelay(randNumber);
  Serial.println("Now in EEPROM: " + String(DW1000Ng::getSavedAntennaDelay()));
  Serial.println("TX delay: " + String(DW1000Ng::getTxAntennaDelay()));
  Serial.println("RX delay: " + String(DW1000Ng::getRxAntennaDelay()));
  Serial.println("------------------------------------------");

Output:
11:47:02.346 -> Now in EEPROM: 44334
11:47:02.392 -> TX delay: 0
11:47:02.392 -> RX delay: 0
11:47:02.439 -> Restored from EEPROM
11:47:02.439 -> TX delay: 44334
11:47:02.439 -> RX delay: 44334
11:47:02.483 -> Got random num: 57788
11:47:02.483 -> Saving
11:47:02.483 -> Now in EEPROM: 57788
11:47:02.529 -> TX delay: 57788
11:47:02.529 -> RX delay: 57788
11:47:02.574 -> ------------------------------------------

Yes, @Bartvelp I did. Sorry for the mistake.

Thank you for this pull request, really interesting.
I just want to point out that one piece of code could be changed from this:
uint16_t getSavedAntennaDelay(uint8_t eeAddress) {
		EEPROM.begin(64);
		uint16_t delay;
		EEPROM.get(eeAddress, delay);
		EEPROM.end();
		return delay;
	}

	uint16_t setAntennaDelayFromEEPROM(uint8_t eeAddress) {
		EEPROM.begin(64);
		uint16_t delay;
		EEPROM.get(eeAddress, delay);
		setAntennaDelay(delay);
		EEPROM.end();
	}

To this:
uint16_t getSavedAntennaDelay(uint8_t eeAddress) {
		EEPROM.begin(64);
		uint16_t delay;
		EEPROM.get(eeAddress, delay);
		EEPROM.end();
		return delay;
	}

	uint16_t setAntennaDelayFromEEPROM(uint8_t eeAddress) {
		uint16_t delay = getSavedAntennaDelay(eeAddress);
		setAntennaDelay(delay);
	}

That is indeed more elegant, I missed it.

Thanks @0nism and @Bartvelp.
@Bartvelp, last but not least... can you make a complete Arduino example (in the examples directory) to explain to all users how to use your functions? Just basic configuration + your previous example?

Sure, see above commit


text:
Feature request: Verify using bom versions

This is an amazing plugin. Found it while looking for a plugin to verify and enforce bom usages.
Is there a way to enforce that the specified boms version is used and not allow modules to use hardcoded versions of the dependencies?

That is most likely possible, but completely out of scope here. It would require a build plugin to check configurations, but this is a settings plugin - too early in the chain.


text:
Enh.docs

Clarifies #1303 documentation example, plus:

expanded user guide information
all existing f5.bigip endpoints added to apidocs

Can't set status; build succeeded.

ready for review, @caphrim007

@jasonrahm needs a rebase. there are commits included here that are not part of your work

license_source: bigquery


text:
Fixes File Transfer Endpoint

Fixes #952, #944
Problem:
File Transfer Endpoint for ASM does not exist pre 11.6.0, also there were few minor changes that were required in the file-transfer class.
Analysis:
Added minimum version to asm file-transfer class, did a minor refactor of the asm file-transfer endpoint
Tests:
Flake8
Unit
Functional

merging this as there are no jenkins tests to be run, jenkins seems to have crashed


text:
Cleanup CIDR and DNSView from internal Requests

Signed-off-by: Subba Reddy Veeramreddy subbareddyv.uoh@gmail.com
Description:  Add Issue/Feature description
Changes Proposed in PR:
Fixes: #Github issue id
General Checklist

[x] Updated Added functionality/ bug fix in release notes
[x] Added examples for new feature
[x] Updated the documentation

CRD Checklist

[x] Updated required CR schema

/azp run

/azp run


text:
🛑 SIS Api is down

In b6e913e, SIS Api (https://sisapi.aden.org/api/v1/acropolis/test) was down:

HTTP code: 0
Response time: 0 ms

Resolved: SIS Api is back up in eddd6ce after 54 minutes.

repo: FAD-Desarollo/upptime


text:
Add Test for ReflectionUtil

I try to understand the code, and write some tests.
Found out that the ReflectionUtil, if used incorrectly, instead of throwing a NoSuchFieldException, it will create a Endless Loop. Should that also be fixed right away? Seems like it shouldn't do this but it seems it also be now problem till now

Is there a Reason Coveralls don't se that some line are covered? Did i need to setup the Test special for it? Jacocoo On IDEA show the coverage

Can u squash commits?

repo: FAForever/downlords-faf-client


text:
change payment percentage on scripts

We should change our payment percentage for each app participant to:

15% Marketplace;
15% Creators;
70% Operators.

Also, update Operator.

repo: FAIR-Protocol/script-examples


text:
🛑 Schuh-Frank Webseite is down

In ff69435, Schuh-Frank Webseite (https://www.schuh-frank.de/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schuh-Frank Webseite is back up in cb19f4a.


text:
Adjust the turn to angle command

The turn to angle command was no longer able to complete its turn during the elimination rounds at State. Adjust this command so it can.

Possible solutions - Close velocity on the drivetrain, add an I term or create a trapezoidal motion profile for each motor using Smart Motion (will be almost definitely faster when turning but much harder).


text:
Stops After shrinking 1 or 2 VHDXs

Hi Jim,
Thanks for the Script, Great job!
I am having a couple of problems probably me and not the script but I would much appreciate your help!
I have made no changes to the script and running the following:
PS C:> .\Invoke-FslShrinkDisk.ps1 -path "\internal\data\fslogixprofiles" -Recurse -LogFilePath C:\Logman8_4.csv -IgnoreLessThanGB 8
We have over 900 VHDXs in this directory and it picks them all up but the script terminates after shrinking 1 or 2 of them. I run the same command again and it shrinks another 1 or 2. Running the command manually over and over gets the space down but Ideally, I want to run this unattended.
I doubt its related but I also get the following output in the shell:
WARNING: Failed to delete temp mount directory
C:\Users\ADMIN~1.ROS\AppData\Local\Temp\133\FSLogixMnt-2f7dc7d5-0284-4e10-bc3f-803358570639
WARNING: Failed to delete temp mount directory
C:\Users\ADMIN~1.ROS\AppData\Local\Temp\133\FSLogixMnt-8e6253ad-94c9-43fb-9420-5f996a7194c7
Get-RunspaceData : An object at the specified path C:\Users\ADMIN~1.ROS does not exist.
At C:\ITAdmin\scripts\FSLogixShrinkDisk\Invoke-FslShrinkDisk.ps1:725 char:21

                Get-RunspaceData

                ~~~~~~~~~~~~~~~~

CategoryInfo          : InvalidArgument: (:) [Write-Error], PSArgumentException
FullyQualifiedErrorId : Argument,Get-RunspaceData

Thanks
Ross

Hi Ross, I'd like to take a look at this, what timezone are you on?  you can mail me at jim dot moyle at microsoft dot com

So I've just added better error reporting to the script please redownload and try again

Thanks Jim!
Ryan, are you able to look at this? I'm not back to work for another week
Cheers,
Ross
07781107294
Sent from my Samsung Galaxy smartphone.
-------- Original message --------
From: Jim Moyle notifications@github.com
Date: 12/08/2020 16:07 (GMT+00:00)
To: FSLogix/Invoke-FslShrinkDisk Invoke-FslShrinkDisk@noreply.github.com
Cc: WakeGSY rmgsy@outlook.com, Author author@noreply.github.com
Subject: Re: [FSLogix/Invoke-FslShrinkDisk] Stops After shrinking 1 or 2 VHDXs (#9)
So I've just added better error reporting to the script please redownload and try again
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FFSLogix%2FInvoke-FslShrinkDisk%2Fissues%2F9%23issuecomment-672930806&data=02|01||d5cf856af5a24b7da69608d83ed17896|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637328416669896735&sdata=tUcjN5egQ2SYYTPysTO0AxvzDNUavBt5v0enLIe721Y%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAQPIBL77JDWF77DMK623B7LSAKV4DANCNFSM4PSPOFKA&data=02|01||d5cf856af5a24b7da69608d83ed17896|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637328416669896735&sdata=aFekMOnjVvgrxmR8Z1FqDx1Emz79SnQlUmvrQa0SGfI%3D&reserved=0.

So I've made some changes, adding retries etc. can you test the script i this branch?
https://github.com/FSLogix/Invoke-FslShrinkDisk/tree/Optimize-OneDisk
Thanks
Jim

Closing due to non-activity

authors: JimMoyle WakeGSY

repo: FSLogix/Invoke-FslShrinkDisk


text:
Parser.Dep: interpret inline_for_extraction on any decl, not just Vals

This is relevant for Pulse, which uses %splice to generate Vals during
typechecking time, so the parser will miss the qualifier and mess up
the dependency analysis.

This passed our brand spanking new check-world workflow, so I'm merging. https://github.com/FStarLang/FStar/actions/runs/10689266115

repo: FStarLang/FStar


text:
Jaren servos

Before issuing a pull request, please see the contributing page.
yo mama
Finished coding da servos

sorry, we have new servo code now


text:
fix/add preserveAspectRatio attribute to symbol tag (if present on …

…SVG)

You can use reserveAspectRatio like this. You don't need other modifications.
<svg reserveAspectRatio="xMaxYMin none">
    <use xlink:href="hapes.svg#svg-some-svg"></use>
</svg>

repo: FWeinb/grunt-svgstore

license: mit


text:
Feature: Provide mapping between all-paragraph and visible-paragraph index systems

Given an index in area.getParagraphs(), one should be able to map it to its respective area.getVisibleParagraphs() index. Likewise, the index of the latter should be mappable to the index of the former. Thus, we should add an API like
public final Optional<Integer> allParToVisibleParIndex(int allParIndex);
public final int visibleParToAllParIndex(int visiblePar);

@JordanMartinez Great! Thank you. How can I use it?

@grenche see the Readme's instructions on the snapshot release.

authors: JordanMartinez grenche

repo: FXMisc/RichTextFX


text:
[bug] cannot instantiate two connectivity-browser at the same time

as of d274c93ce38f3f1e1929da300235d1f8b62d3dcf or 055118579a26ad9e7454105f0d934d681f8cad00
to reproduce:
1/ insert the following code in any template:
    <connectivity-browser>
    </connectivity-browser>
    <connectivity-browser>
    </connectivity-browser>

expected behaviour: two connectivity browser renders
actual behaviour: only the first connectivity browser render
attached: DOM tree

Fixed


text:
Tauri v2-beta permission errors

Tauri v2.0.0-beta gives the following permission error.

there should be a capability file in src-tauri/capabilities with a bunch of permissions, just add "oauth:allow-start" to that array.

authors: FabianLars liyasthomas

repo: FabianLars/tauri-plugin-oauth


text:
22w15a stuff

First PR, hope I did stuff correctly

Nice first PR 👍

repo: FabricMC/yarn


text:
Disable MidnightControls Auto Switch mode

What config to change
Auto Switch Mode

Why should it be changed
Because if i have a controller plugged-in my pc it auto switch to it and show the HUD while unnecessary.
Because it has caused issues in the past like if you have Joy-Cons with Joy-Con drift issue it'll constantly send input to the game even if you play keyboard.
It will also create problem if you have a wireless controller in a case where some button or joystic is pressed by inadvertance.
https://discord.com/channels/859124104644788234/922363933980000286/1000701966147661914
https://discord.com/channels/859124104644788234/859124571005648946/1000617259548557442
Category
Mod config option
Additional details
Auto Switch can be useful but it's prone to cause problems like this

Because the controller keybinds button is found next to normal keybinds button, this could be done while still being obvious that users can use a controller. Still, looking for feedback on this.

I believe that Auto Switch is very useful + BE parity feature. I usually swap from my controller to my keyboard at certain times and it would be very annoying to change the controller mode manually every time I use my controller. You can make an issue in MidnightControls to disable the controller HUD after a customizable controller inactivity time.

I believe that Auto Switch is very useful + BE parity feature. I usually swap from my controller to my keyboard at certain times and it would be very annoying to change the controller mode manually every time I use my controller. You can make an issue in MidnightControls to disable the controller HUD after a customizable controller inactivity time.

What about the Joy-Con drift problems, etc ? Because they drift, they make activity.

What about the Joy-Con drift problems, etc ? Because they drift, they make activity.

Make an issue about it too :ioa:

What about the Joy-Con drift problems, etc ? Because they drift, they make activity.

Make an issue about it too :ioa:

No this is a Nintendo issue you can't fix that 🤣
You can only make it not being problematic by making it not do inputs.

What about the Joy-Con drift problems, etc ? Because they drift, they make activity.

Make an issue about it too :ioa:

No this is a Nintendo issue you can't fix that 🤣
You can only make it not being problematic by making it not do inputs.

technically you can fix it - https://youtu.be/JluAuIJ-tSY

What about the Joy-Con drift problems, etc ? Because they drift, they make activity.

Make an issue about it too :ioa:

No this is a Nintendo issue you can't fix that 🤣
You can only make it not being problematic by making it not do inputs.

technically you can fix it - https://youtu.be/JluAuIJ-tSY

Technically yes but in reality well...
It's more up to the contructor than you

https://github.com/TeamMidnightDust/MidnightControls/issues/81 is now implemented

https://github.com/TeamMidnightDust/MidnightControls/issues/81 is now implemented, so unless anyone has counter-arguments, this is what I will do with the next version.
You might want to test it as well to be sure how it works though.

So now by default Auto-Switch will be disabled and a pop-up will appear to tell the user they can use a controller ?

In FO, yes.

In FO, yes.

Perfect thanks 👍

Implemented in 3.12.2 and 4.2.0-beta.1


text:
Initial code for CI plugin

Refactored the Trivy code to make it more reusable and then wrote some initial code for the CI utility.

@rbren I made some changes based on your feedback. I feel like this lead to some code that still needs to be cleaned up. But especially the Filename issue I wanted to see what you thought of what I had here. While I'm scanning the YAML files I capture the comment and filename of each resource and match any Action Items that come back to those to figure out what file they came from.

repo: FairwindsOps/insights-plugins


text:
Send the Admission plugin version to the Insights API, from the version.txt file

This PR is an alternate possibility for PR 582 that avoids copying plugin version.txt files within the pkg sub-directory, and breaking local plugin builds.
Checklist

[x] I have signed the CLA
[x] I have updated/added any relevant documentation

Description
What's the goal of this PR?
Submit the plugin version, taken from the version.txt file, in submissions to the Insights API, including plugin packages used by other plugins, such as Admission using OPA / Polaris.
What changes did you make?

Added an embed.go to the root of each plugin, which must be located at the same location as the version.txt file we use to track the plugin version.
Import the new package, using an alias: admission version "GitHub.com/fairwindsops/insights-plugins/plugins/admission
Use these packages to obtain current plugin versions, such as admission version.String() or opaversion.String().

What alternative solution should we consider, if any?
This Slack thread contains discussion about other options.

Using a hard link to mirror the version.txt file within pkg sub-directories doesn't work because git doesn't preserve hard links.
Copying version.txt within pkg sub-directories (via the Dockerfile) does work, but it complicates / breaks a local go build, and requires the Admission Dockerfile to copy version.txt in place for other plugins (OPA / Polaris).

This strategy looks great to me. Thanks for working through it Ivan and Barnie!

@rbren / @makoscafee I'd like to call out that importing the new version pkg from embed.go is not able to include the word version; it uses the top-level plugin path in the import. That looks like:
import (
  admission version "GitHub.com/fairwindsops/...../admission"
)

I have tried to improve on this, but naming the package something more descriptive in the import would require the package be located in a different sub-directory ... which defeats the purpose of having embed.go located with version.txt.
I want to make sure you're aware of / ok with this?

This strategy looks great to me. Thanks for working through it Ivan and Barnie!

@rbren / @makoscafee I'd like to call out that importing the new version pkg from embed.go is not able to include the word version; it uses the top-level plugin path in the import. That looks like:
import (
  admissionversion "GitHub.com/fairwindsops/...../admission"
)

I have tried to improve on this, but naming the package something more descriptive in the import would require the package be located in a different sub-directory ... which defeats the purpose of having embed.go located with version.txt.
I want to make sure you're aware of / ok with this?

We covered this in Slack:
RobertB: :nod: yeah I think that's fine At 3:28 PM yesterday


text:
The movie is marked as available even though only the 4K version is.

Description
When a movie is downloaded only in 4K, it is marked as "available" and "4K available", so we cannot request it in HD.
I haven't tested it for TV shows, but it might also be the case.
Version
1.4.1
Steps to Reproduce

4K radarr instance needed
Go on a movie
Ask for the movie in 4K
Waiting for the movie to download
The movie is marked available

Screenshots

The movie in jellyfin :

Logs
No response
Platform
desktop
Device
PC
Operating System
Windows 11
Browser
Chrome
Additional Context
My Jellyseerr instance is hosted on Docker using the 'latest' tag.
Code of Conduct

[X] I agree to follow Overseerr's Code of Conduct

This is already fixed and will be available in the next branch. If you want to try it out you can also try it using the development tag. You'll have to manually clear data of the media affected tho

I am also facing the same issue. I am using 1.5.0 version currently

I am also facing the same issue. I am using 1.5.0 version currently

You might wanna clear data and rescan. That will fix it with the new version

I have started using jellyseerr from the 1.5.0 version. Just set it up yesterday. I did the rescan now but that didn't fix the issue. (I am using the merge versions plugin in jellyfin btw)

I tested the same on shows, and it seems to work fine with the 4k-only shows. Only The 4k-only movies are experiencing this issue.

4k and 1080p movies are in separate folders in the filesystem. Still, in Jellyfin, all these folders are added to the same library, and I use the merge versions plugin in Jellyfin to combine different versions if they exist.
It is the same as above with shows too. But shows have no issues.

4k and 1080p movies are in separate folders in the filesystem. Still, in Jellyfin, all these folders are added to the same library, and I use the merge versions plugin in Jellyfin to combine different versions if they exist.
It is the same as above with shows too. But shows have no issues.

Could you try putting two test ones in two seperate libraries and see if they detect? (As so far everyone who reported before show fix and after show fix mentioned that movies were working fine. It was the shows that were borked and after the fix they mentioned shows were working as well)

I don't understand what you mean by putting 2 files in separate libraries.😅
I think I wasn't clear in explaining my issue😅.
The issue is when I have only one version of the movie (4k), jellyseerr is falsely detecting that both versions exist.(which isn't true).
This is what is happening currently in my library.
Scenario 1:
4k version exists in jellyfin
1080p version exists in jellyfin
Jellyseerr shows both as available.
Scenario 2:
4k version doesn't exist in jellyfin
1080p version exists in jellyfin
Jellyseerr shows that 1080p is available along with an option to request for 4k.
Scenario 3(the issue):
4k version exists in jellyfin
1080p version doesn't exist in jellyfin
Jellyseerr shows that both versions are available(even though 1080p actually isn't available).
What else should I test to diagnose the issue? Are there any logs I can provide?
Thanks for responding so quickly and trying to solve my issue.

@Rover1176 could you reach out on discord server so its easier to troubleshoot? I'll update here once done

This was fixed in bc9017f54d84ec24c4d74d38e1b4e24219425d41 and 3bf04f2abd96bf95a1363dd16e4de46cf621ab5d

authors: Fallenbagel JolanLar Rover1176

repo: Fallenbagel/jellyseerr


text:
Add explanation of WWW structure

In the specification, g7:WWW is defined only as having a URL payload, with no indication of what it means in context. The specification text is:

A URL or other locator for a World Wide Web page, as defined by any relevant standard such as whatwg/url, RFC 3986, RFC 3987, and so forth.
If an invalid or no longer existing web address is present upon import, it should be preserved as-is on export.

We should specify what it means. Because it has no specified meaning in 7.0 (or 5.5.1, which has even less text defining it) , we can't limit its meaning in a patch or minor version, but we can add recommendations and notes about how to handle it.

An initial rough draft of possible added wording:

Like other substructures, the WWW structure provides details about the subject of its superstructure, not about some other subject. For example, a MARR.WWW is a world wide web address of the marriage event, not the personal website of the couple or the entry in an online database serving as a source documenting the marriage. However, this meaning was only implicit when WWW was introduced in version 5.5.1 and many files were created that use WWW to store a more tangentially-related web address, so applications are recommended to interpret the WWW structure's meaning cautiously.

repo: FamilySearch/GEDCOM


text:
cant remove a text hologram

git-Purpur-2136 (MC: 1.20.4)
FancyHolograms version 2.0.5
[19:51:45 INFO]: czychuuu issued server command: /holo remove test
[19:51:45 ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing 'holo remove test' in de.oliver.fancyholograms.commands.HologramCMD(hologram)
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:178) ~[purpur-api-1.20.4-R0.1-SNAPSHOT.jar:?]
at org.bukkit.craftbukkit.v1_20_R3.CraftServer.dispatchCommand(CraftServer.java:1001) ~[purpur-1.20.4.jar:git-Purpur-2136]
at org.bukkit.craftbukkit.v1_20_R3.command.BukkitCommandWrapper.run(BukkitCommandWrapper.java:64) ~[purpur-1.20.4.jar:git-Purpur-2136]
at com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73) ~[brigadier-1.2.9.jar:?]
at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:32) ~[purpur-1.20.4.jar:git-Purpur-2136]
at net.minecraft.commands.execution.tasks.ExecuteCommand.execute(ExecuteCommand.java:13) ~[purpur-1.20.4.jar:git-Purpur-2136]
at net.minecraft.commands.execution.UnboundEntryAction.lambda$bind$0(UnboundEntryAction.java:8) ~[purpur-1.20.4.jar:git-Purpur-2136]
at net.minecraft.commands.execution.CommandQueueEntry.a(CommandQueueEntry.java:5) ~[purpur-1.20.4.jar:git-Purpur-2136]
at net.minecraft.commands.execution.ExecutionContext.runCommandQueue(ExecutionContext.java:101) ~[purpur-1.20.4.jar:git-Purpur-2136]
at net.minecraft.commands.Commands.executeCommandInContext(Commands.java:442) ~[?:?]
at net.minecraft.commands.Commands.performCommand(Commands.java:344) ~[?:?]
at net.minecraft.commands.Commands.performCommand(Commands.java:331) ~[?:?]
at net.minecraft.server.network.ServerGamePacketListenerImpl.performChatCommand(ServerGamePacketListenerImpl.java:2286) ~[?:?]
at net.minecraft.server.network.ServerGamePacketListenerImpl.lambda$handleChatCommand$17(ServerGamePacketListenerImpl.java:2246) ~[?:?]
at net.minecraft.util.thread.BlockableEventLoop.lambda$submitAsync$0(BlockableEventLoop.java:59) ~[?:?]
at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ~[?:?]
at net.minecraft.server.TickTask.run(TickTask.java:18) ~[purpur-1.20.4.jar:git-Purpur-2136]
at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?]
at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?]
at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1488) ~[purpur-1.20.4.jar:git-Purpur-2136]
at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:194) ~[purpur-1.20.4.jar:git-Purpur-2136]
at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?]
at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1465) ~[purpur-1.20.4.jar:git-Purpur-2136]
at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1388) ~[purpur-1.20.4.jar:git-Purpur-2136]
at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:136) ~[?:?]
at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1366) ~[purpur-1.20.4.jar:git-Purpur-2136]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1255) ~[purpur-1.20.4.jar:git-Purpur-2136]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:323) ~[purpur-1.20.4.jar:git-Purpur-2136]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: java.lang.IllegalStateException: HologramHideEvent may only be triggered asynchronously.
at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:40) ~[purpur-1.20.4.jar:git-Purpur-2136]
at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:126) ~[purpur-1.20.4.jar:git-Purpur-2136]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:617) ~[purpur-api-1.20.4-R0.1-SNAPSHOT.jar:?]
at org.bukkit.event.Event.callEvent(Event.java:45) ~[purpur-api-1.20.4-R0.1-SNAPSHOT.jar:?]
at de.oliver.fancyholograms.version.Hologram1_20_4.hide(Hologram1_20_4.java:218) ~[FancyHolograms.jar:?]
at de.oliver.fancyholograms.api.Hologram.hideHologram(Hologram.java:98) ~[FancyHolograms.jar:?]
at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?]
at java.util.Collections$UnmodifiableCollection.forEach(Collections.java:1092) ~[?:?]
at de.oliver.fancyholograms.api.Hologram.hideHologram(Hologram.java:105) ~[FancyHolograms.jar:?]
at de.oliver.fancyholograms.commands.hologram.RemoveCMD.run(RemoveCMD.java:29) ~[FancyHolograms.jar:?]
at de.oliver.fancyholograms.commands.HologramCMD.execute(HologramCMD.java:92) ~[FancyHolograms.jar:?]
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:168) ~[purpur-api-1.20.4-R0.1-SNAPSHOT.jar:?]
... 28 more

Fixed in the latest dev builds: https://fancyplugins.de/FancyHolograms/download/

authors: JasonHorkles czychuuu

repo: FancyMcPlugins/FancyHolograms


text:
Convert struct classes to records

Our "object" classes are stored here. Not all of them can be, but the ones that can should be converted to records.

Hi! I'd like to contribute, I'm pretty new to contributing, I'd like to try this issue as it involves more code. But can I get a clarification on what records actually are? What do you want to be converted exactly?

Hello! Thank you for your interest in contributing! Java records are a feature added in version 15, you can view more about them here.  The idea is to replace things that can be replaced in the package net.farlands.sanctuary.data.struct

Would the converted classes be in the same package?
This seems simple enought I think, I'd like to work on this if you'd assign me to it. Thanks!

Yes.  You'd be replacing the classes that are currently there if it can be replaced with a record.
Thank you again for your interest :D

I'm having trouble downloading the RegionProtection depedency, it spits out this error
Authentication failed for https://maven.pkg.github.com/FarLandsMC/mavenpackages/com/kicas/rp/regionprotection/1.2.0-SNAPSHOT/regionprotection-1.2.0-SNAPSHOT.pom 401 Unauthorized

Ah, you'll need to modify your ~/.m2/settings.xml to have
<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 https://maven.apache.org/xsd/settings-1.0.0.xsd">
  <servers>
    <server>
      <id>github</id>
      <username>GITHUB USERNAME</username>
      <password>TOKEN</password>
    </server>
  </servers>
</settings>

Where TOKEN is a personal access token generated in GitHub

Thanks, that fixed it!

Thank you for your contribution! :D

authors: Majekdor ReyhanPatria funnyboy-roks

repo: FarLandsMC/FarLands


text:
Add performance debuging utilities

Description
Adds benchmark_step, benchmark_init, benchmark_render.
I have used these for development of MuJoCo-v5
inspired from: https://github.com/Farama-Foundation/PettingZoo/blob/master/pettingzoo/test/performance_benchmark.py
Fixes # (issue)
Type of change

[X] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Checklist:

[x] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

time.time() is plenty precise for this test

repo: Farama-Foundation/Gymnasium