text:
The automated release is failing 🚨

:rotating_light: The automated release from the master branch failed. :rotating_light:
I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.
You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this 💪.
Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.
Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.
If you are not sure how to resolve this, here is some links that can help you:

Usage documentation
Frequently Asked Questions
Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

Invalid npm token.
The npm token configured in the NPM_TOKEN environment variable must be a valid token allowing to publish to the registry https://registry.npmjs.org/.
If you are using Two-Factor Authentication, make configure the auth-only level is supported. semantic-release cannot publish with the default auth-and-writes level.
Please make sure to set the NPM_TOKEN environment variable in your CI with the exact value of the npm token.

Good luck with your project ✨
Your semantic-release bot :package::rocket:

:rotating_light: The automated release from the master branch failed. :rotating_light:
I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.
You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this 💪.
Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.
Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.
If you are not sure how to resolve this, here is some links that can help you:

Usage documentation
Frequently Asked Questions
Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

Invalid npm token.
The npm token configured in the NPM_TOKEN environment variable must be a valid token allowing to publish to the registry https://registry.npmjs.org/.
If you are using Two-Factor Authentication, make configure the auth-only level is supported. semantic-release cannot publish with the default auth-and-writes level.
Please make sure to set the NPM_TOKEN environment variable in your CI with the exact value of the npm token.

Good luck with your project ✨
Your semantic-release bot :package::rocket:

repo: Nargonath/cra-build-watch


text:
Disable banner

Disable banner for commands: https://github.com/Narno/zf-console.

Ref.: 9e295ce1e1b6be3733cdb8947bc5978f1c8ea215.

Done: f0f9e6e53539422252e84c1fb9c0687f45e1267c.

source: gharchive/issue

repo: Narno/PHPoole

license: mit

license_type: permissive

license_source: bigquery


text:
Get jest tests to run properly

I added some simple jest tests... but they are not running

running:
yarn test

leads to:
FAIL specs/series.jest.ts
  ● Test suite failed to run

    Jest encountered an unexpected token

    This usually means that you are trying to import a file which Jest cannot parse, e.g. it's not plain JavaScript.

    By default, if Jest sees a Babel config, it will use that to transform your files, ignoring "node_modules".

    Here's what you can do:
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/en/configuration.html

    Details:

    C:\workspace\grafana-plugins\grafana-plotly-panel\specs\series.jest.ts:2
    import { SeriesWrapperSeries } from '../src/SeriesWrapper';
    ^^^^^^

    SyntaxError: Unexpected token import

      at ScriptTransformer._transformAndBuildScript (node_modules/jest-runtime/build/script_transformer.js:403:17)

Hey, @ryantxu! I had the same issue in another project.
You should add babel to your jest config.
Here is jest.config.js I wrote to make it work (added useBabelrc field to globals.ts-jest):
module.exports = {
  "verbose": true,
  "globals": {
    "ts-jest": {
      "useBabelrc": true,
      "tsConfigFile": "tsconfig.jest.json"
    }
  },
  "transform": {
    "\\.ts": "ts-jest"
  },
  "testRegex": "(\\.|/)([jt]est)\\.[jt]s$",
  "moduleFileExtensions": [
    "ts",
    "js",
    "json"
  ],
  "setupFiles": [
    "<rootDir>/spec/setup_tests.ts"
  ]
};

.babelrc must be in root directory with such contents:
{
  "plugins": [
    "transform-es2015-modules-commonjs"
  ]
}

Added these deps to make it work:
"babel-core": "^6.26.0",
"babel-jest": "^23.4.2",
"babel-preset-env": "^1.6.0",

For more info: https://github.com/facebook/jest/issues/2081

thank @rozetko can you make a pull request :)

@ryantxu Created: https://github.com/NatelEnergy/grafana-plotly-panel/pull/44

authors: rozetko ryantxu

repo: NatelEnergy/grafana-plotly-panel

license: MIT

license_source: github-api


text:
Startup still long ~13 seconds up to 20 seconds

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting

**Current behavior**
A clean install, then `npm start.android`
copy and install the (debug) apk on the physical device.
13 to 21 seconds...

**Expected behavior**
First start "slow" 10 seconds, every other start 2.5 to 4 seconds...

**Minimal reproduction of the problem with instructions**
clean install

**Please tell us about your environment:**
Android 6.0
2 gb internal
Honor 5x (huawei)

N/a.

authors: Dutchboy NathanWalker

repo: NathanWalker/angular-seed-advanced


text:
sleigh -x : unknown option: -x

Describe the bug
Can't specify -x to get debug information. Flag is listed in the Usage info but not accepted ?
To Reproduce
$ /opt/ghidra/Ghidra/Features/Decompiler/os/linux_x86_64/sleigh

USAGE: sleigh [-x] [-dNAME=VALUE] inputfile [outputfile]
   -a              scan for all slaspec files recursively where inputfile is a directory
   -x              turns on parser debugging
   -u              print warnings for unnecessary pcode instructions
   -l              report pattern conflicts
   -n              print warnings for all NOP constructors
   -t              print warnings for dead temporaries
   -e              enforce use of 'local' keyword for temporaries
   -c              print warnings for all constructors with colliding operands
   -o              print warnings for temporaries which are too large
   -s              treat register names as case sensitive
   -DNAME=VALUE    defines a preprocessor macro NAME with value VALUE

$ /opt/ghidra/Ghidra/Features/Decompiler/os/linux_x86_64/sleigh -x
Unknown option: -x

Steps to reproduce the behavior:

run "sleigh -x" from CLI

Environment (please complete the following information):

OS: Arch
Java Version: 19
Ghidra Version: 10.2.2
Ghidra Origin: distro

 $ find /opt/ghidra/ | grep "sleigh"
/opt/ghidra/Ghidra/Features/Decompiler/os/linux_x86_64/sleigh
...
...
/opt/ghidra/support/sleigh

Ah yes... I had only tried the first one. Never noticed the other until now (it's not in $PATH by default).
Sorry for the noise.

Was gonna ask if arch put specific things on PATH or not.
There's those c versions and this java version, I've only ever used the Java version.  I imagine the c is just compatibility checks for decompiler code maybe.

authors: fenugrec mumbel

repo: NationalSecurityAgency/ghidra


text:
NPE fix and Respect checkForSideEffects in CreateThunkFunctionCmd

resolves #714

No longer applicable. Should have been fixed by 8fbdec4eca4bfeb5014dd059f2a2089cf259fa58

source: gharchive/pull-request


text:
Self Report Workload: Configuring all skills under a subject fails when that subject has a group

Add All skills  under a subject:

An error example:

PR: https://github.com/NationalSecurityAgency/skills-service/pull/1897

:+1:

authors: rmmayo sudo-may

repo: NationalSecurityAgency/skills-service


text:
App not re-installed properly on iOS 8/9 Simulators

If you already have old application with name TestApp installed and then you want to test different app, which is also named TestApp the framework will not re-install the app on iOS8/9 Simulators and tests will run against old app.
Notes: Not reproducible for iOS 10 Simulators, Android emulators and devices.

Fixed with https://github.com/NativeScript/functional-tests-core/pull/6

repo: NativeScript/functional-tests-core


text:
UIApplication's deprecated writable properties should be read-only

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

iOS Runtime: 5.2.0

Describe the bug
According to https://developer.apple.com/documentation/uikit/uiapplication/1622988-statusbarstyle?language=objc UIApplication.statusBarStyle is deprecated. Similarly, the statusBarHidden property is deprecated as well. Actually, what is deprecated is these properties being writable, as can be seen in UIKit/UIApplication.h:
NS_CLASS_AVAILABLE_IOS(2_0) @interface UIApplication : UIResponder
...
@property(readonly, nonatomic) UIStatusBarStyle statusBarStyle __TVOS_PROHIBITED; // default is UIStatusBarStyleDefault
@property(readonly, nonatomic,getter=isStatusBarHidden) BOOL statusBarHidden __TVOS_PROHIBITED;
...
@end

...
@interface UIApplication(UIApplicationDeprecated)
...
// Setting the statusBarStyle does nothing if your application is using the default UIViewController-based status bar system.
@property(readwrite, nonatomic) UIStatusBarStyle statusBarStyle NS_DEPRECATED_IOS(2_0, 9_0, "Use -[UIViewController preferredStatusBarStyle]") __TVOS_PROHIBITED;
- (void)setStatusBarStyle:(UIStatusBarStyle)statusBarStyle animated:(BOOL)animated NS_DEPRECATED_IOS(2_0, 9_0, "Use -[UIViewController preferredStatusBarStyle]") __TVOS_PROHIBITED;

// Setting statusBarHidden does nothing if your application is using the default UIViewController-based status bar system.
@property(readwrite, nonatomic,getter=isStatusBarHidden) BOOL statusBarHidden NS_DEPRECATED_IOS(2_0, 9_0, "Use -[UIViewController prefersStatusBarHidden]") __TVOS_PROHIBITED;
- (void)setStatusBarHidden:(BOOL)hidden withAnimation:(UIStatusBarAnimation)animation NS_DEPRECATED_IOS(3_2, 9_0, "Use -[UIViewController prefersStatusBarHidden]") __TVOS_PROHIBITED;

@end

Current behavior
The properties are exposed to JS as writable.
Expected behavior
Expose these properties in JavaScript as read-only.

Fixed with https://github.com/NativeScript/ios-runtime/pull/1100

repo: NativeScript/ios-runtime


text:
Interop Marshalling Bug?

I've recently been working on converting my Android SQLite wrapper onto the IOS side.  And I ran into a Marshalling issue that I'm not sure how to fix as it seems to be a bug in the IOS runtime.  The Repo is https://github.com/Nathanaela/nativescript-sqlite
The issue is https://github.com/Nathanaela/nativescript-sqlite/blob/master/sqlite.ios.js#L478
The prototype for this function is: const unsigned char* sqlite3_column_text(sqlite3_stmt, int iCol);
The ios-runtime apparently marshall's this into a Interop.Reference() type.    In this case the ref.value ends up being only the First Character (and in numeric form so "A" = 65) of the result string rather than the full string.   I can't seem to figure a way to get the full string back.
Test Code, you just need to run "database_code();" :
var sqlite = require('./node_modules/nativescript-sqlite/sqlite');

var database_code = function() {
    var dbp = new sqlite("test.db", function(err, ndb) {
        if (err) {
            console.error("Sqlite returned error", err);
        }
        console.log("Callback db is good");
    });

    dbp.then(function(db) {
        console.log("Then called with db", typeof db, sqlite.isSqlite(db) ? "Yes" : "No");
        db.execSQL("create table if not exists test (id integer, data text)");
        db.execSQL("insert into test (id, data) values (?,?)", [1, "blah"]);
        db.execSQL("insert into test (id, data) values (?,?)", [2, "cing"]);
        db.all("select * from test where data=?", "cing", function(err, data) {
            if (err) console.log("Error", err);
            for (var i = 0; i < data.length; i++) {
                console.log("Get Data", data[i]);
            }

            db.close();
        });

    }, function(err) {
        console.error("Promise failed", err);
    });
};

Hi, you can see how to convert a char* or interop.Reference to a string in the examples.

Awesome and THANKS! -- That is EXACTLY what I needed to know.   I hope you had that Gist already made; because you didn't have to do all that work to answer my question.   Just your line NSString.stringWithUTF8String(statement) is what I needed.     My sqlite wrapper works perfectly except for retrieving the text column.
We might need to clean up the docs a little -- even with the information you provided I still don't really see where I would make that conclusion from the docs -- or that we can even do that to a Interop.Reference to a C Pointer..

@jasssonpet I've looked on this and the gist also, but had no luck with my code to get the error message from sqlite3_errmsg
The code is:
...
var res = sqlite3_bind_text( ... );
// above gives an error, so try to show the error complete message
if (res)
{
  var errMsg = sqlite3_errmsg(db_instance);
  var message = NSString.stringWithUTF8String(errMsg.value);
  console.log('SQLITE.Binding Error', res, message);
}

Any advice?

Sorry've found it: the call should be:
  var message = NSString.stringWithUTF8String(errMsg);

Cheers!

authors: NathanaelA Nathanaela jacargentina jasssonpet


text:
Why do we ignore default metadata?

The basic logger purges rather useful metadata like line file and function.
When I tested this locally, I was able to completely wipe out the blacklisted fields and this library worked just fine.
I'm happy to make a PR with my changes to remove the rather annoying discard if we're up for that.

@SophisticaSean it was coming from a time when we weren't able to properly encode functions (because we did not have a safe encoder), and even before the same list was part of some Elixir.Logger code :).
The basic formatter is very minimalistic, I'm not sure it's a good idea to change it now because we don't want to accidentally send more data to log ingestion than people that already use it are expecting. If you want to have them in your logs it's better to define your own formatter.

@SophisticaSean I just stared using the basic logger and I was also very surprised that it basically ignores all metadata.
I think the docs should clearly mention what metadata is supported and what not. Right now, there's no mention of metadata being removed.

Thanks @AndrewDryga. However, it's the system metadata (especially mfa) I'm interested in :)
Not saying you guys don't have good reasons for it, all I'm saying is that there should be a sentence in the docs mentioning this.

@maxmarcon I pushed an updated readme, please tell me if you have ideas on how to make it more explicit.

Many thanks @AndrewDryga ! Really appreciated. I left a comment on the commit.

authors: AndrewDryga SophisticaSean maxmarcon


text:
feat: allow converting otel trace ids to datadog values

This is to allow Open Telemetry trace ids to be converted into Datadog format so logs and traces can be linked together. Datadog has a page on how to do this. Most of the code was stollen from the golang example, and then the test values were stollen from known good versions based off that go code. You'll notice that the code is very defensive in case some bad value gets there and starts breaking things. I'll also mention that this is probably not the most optimized version. I'm not great with binary pattern matching so improvements welcome.
Currently this is what would show up out of the box in Datadog with https://github.com/open-telemetry/opentelemetry-erlang setup.

Note I'm going to be running this locally for a bit on a project in production to ensure nothing breaks and works as intended.

Coverage increased (+0.5%) to 75.385% when pulling 5f4f9fd8aaa556cba2a74c7cdb16327359d11903 on btkostner:dd-trace into 9ca7542166beeb7ddfc723e8885282ddbebf331a on Nebo15:master.

I can confirm this is working in live production code now. I will continue to let it run in case something creeps up

Alright, after some function optimization one of my coworkers came up with a better solution. Benchmarks:
Name                      ips        average  deviation         median         99th %
new long string        1.62 M        0.62 μs  ±3721.34%        0.55 μs        1.07 μs
old long string        0.38 M        2.66 μs   ±602.14%        2.49 μs        3.62 μs

Name                       ips        average  deviation         median         99th %
new short string        1.79 M        0.56 μs  ±2125.00%        0.51 μs        0.90 μs
old short string        0.62 M        1.61 μs  ±1400.36%        1.49 μs        2.20 μs

Name                     Memory usage
new integer              0.0313 KB
old integer              3.70 KB - 118.50x memory usage +3.67 KB

new short string         0.26 KB
old short string         2.93 KB - 11.36x memory usage +2.67 KB

new long string          0.40 KB
old long string          6.02 KB - 15.12x memory usage +5.63 KB

Some how missed charlist encoding not working. Should be fixed now. Working again on our side.

Alright, it's been in production for a bit now. No errors that I can see and from a quick spot test, traces and logs are being correlated correctly. No noticeable performance hit for memory or CPU.

@btkostner thank you for another great PR ❤. I'm moving between houses now and will be able to look more closely/merge it in a day or two, sorry for the delay.
Also, I got an idea I decided to discuss with you. I feel like change like this one can be generalized: with the new commit that added formatter_state we can actually make a configuration option (something like metadata_mappers: [span_id: MyModule.otel_span_id/1] but I bet there is a better name for it) and allow users to define custom functions that will process some of the keys. The function can receive a value and recturn a tuple {new_key, new_value}.
This will ensure that no matter what use case you have - you can always integrate OTEL or anything else that writes keys to the Logger metadata and you can control how it's encoded and under which key is stored.
I'm thinking to implement such refactoring after we merge this PR. What do you think?

No rush on the review. Take your time.
As for something like metadata_mappers, that sounds like a great idea. It should keep the logger pretty easy to extend for everyone's use case. If we find people are using a common function we could include it this library under a util module or something for ease of use. It could also cover the "filter params" use case.

authors: AndrewDryga btkostner coveralls


text:
/dev/i2c-7 messes up non rockpi units

if you add:
      - /dev/i2c-7:/dev/i2c-7

to a device (such as raspberry pi) that doesn't have this devices on the host-os then it fails to start those containers (diag and miner in this case).
Need to see if we can find a workaround for that

Possibly privileged: true is a good solution

This has fixed things so it works on both RockPi and RasPi.
The only question is whether there's any detrimental effects of using privileged: true in general

privileged containers can be exploited to have full access to the host's devices (Ref: https://blog.trailofbits.com/2019/07/19/understanding-docker-container-escapes/) but in our case should not be an issue as we're using these boards for the single purpose of running the helium miner software. And that too is only possible with some constraints. So if a user that has our boxes wants to exploit this he is just messing with his own hardware. For a remote attacker he would first need someway to get a footprint into the container (via balena or some fault in our code). As we have balena public device urls disabled mostly that shouldn't be an issue.
My 2c - Not that risky considering where we're using it.

@kashifpk that was my thoughts also.
I guess the alternative is to maintain another repo for the RockPi version of the software but that seems unnecessary given this being the only required difference.
I wonder if it's possible to achieve this with any cap-add directive? Or whether we can make privileged: true more secure using cap-drop?
Also relates to #259

I think it is inevitable that we will have to add multiple docker-compose files. Perhaps a better solution is to simply modify the build script to automatically configure /dev/i2c accordingly. That will unfortunately require us to run on different fleets, but perhaps it is the path of least resistance.

@vpetersson I think we will have to run on different fleets anyway because of the VARIANT being different on different hardware. We haven't solved that yet and not convinced we can...

Yeah we were just discussing this in the stand-up. Then we can just auto-generate the docker-compose.yml file on run time (similar to Balena's Dockerfile.template) and just render it according to the target.

Perhaps for Testnet we use privileged: true and for other units we use different i2c bus.
Having said that...I don't see any particular reason not to use privileged: true on production devices.
Either way, the tooling isn't terribly difficult whichever path we choose

I want to keep the delta between testnet and mainnet minimal.  privileged: true is a big one that can cause a lot of different behaviors and bugs to go undiscovered.

@vpetersson then we have to maintain multiple different testnets as well

I wonder if there's a way to remap i2c-7 on RockPi to i2c-1 (and vice versa) but probably more hassle than it's worth and not a good idea / something balena will support as will mean differences between operation on native and balenaOS

@vpetersson then we have to maintain multiple different testnets as well i.e. RockPi testnet and RasPi testnet

Yeah good point. I think we should do that.

I wonder if there's a way to remap i2c-7 on RockPi to i2c-1 (and vice versa) but probably more hassle than it's worth and not a good idea / something balena will support as will mean differences between operation on native and balenaOS

Possible, but i think it's more likely they will allow the container to start w/out the device existing tho.

I suppose one benefit to having different testnets is that we can more easily isolate hardware specific issues

Yeah exactly.

@vpetersson created a PR in #264 to sort this

Blocked by completion of: https://github.com/NebraLtd/helium-miner-software/pull/272

authors: kashifpk marvinmarnold shawaj vpetersson

repo: NebraLtd/helium-miner-software


text:
Cannot add host folder (Could not parse size: unable to parse size)

I am receiving this error message when trying to add an 20gb host folder:
Could not parse size: unable to parse size
Command:
"./siac host folder add /root/sia/Sia-v1.2.1-linux-amd64/host_folder 20" on Ubuntu 14.04.4 LTS

you need to provide a unit. 20GB should work.

authors: geckogecko lukechampine

repo: NebulousLabs/Sia


text:
add rpc documentation

This PR aims to add documentation for the RPC code, and make it more clear what calls are available, and how they work. This should also make it easier in the future to write clients in other languages.
I'm not sure if this initial state is good enough, please collaborate and give feedback where needed :)
I am not sure if I should omit the (incomplete) type info or not, for now it's there, but if you rather have me remote that part, I'll do so.

Does this require more changes?

yeah, I have some minor comments for the sections I didn't get to previously. So far it's looking good though

Cool @lukechampine, feel free to push those changes yourself to this branch though, I think as a owner of this repo you can do that. Might be quicker than going back and forward :) And makes this a real collaborative PR 👍

I think only you can push to the branch since it's on your repo. We sometimes push to each other's PRs on Sia because the branches are all part of the NebulousLabs repo.

@lukechampine ah, didn't know that. Somehow I thought that you were also able to push to it. Might have misread that at some point, a couple of months ago.
I added the changes you requested.

Removed comma as requested.

Woo

authors: DavidVorick GlenDC lukechampine


text:
🛑 Becpl Angular UI is down

In 0b5802c, Becpl Angular UI ($BECPL_ANGULAR_URL) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Becpl Angular UI is back up in 8b6a50c after 5 minutes.

repo: NehalDamania/becpl-uptime


text:
🛑 Becpl Angular UI is down

In c8d440f, Becpl Angular UI ($BECPL_ANGULAR_URL) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Becpl Angular UI is back up in 55343e4 after 11 minutes.


text:
🛑 Becpl Angular UI is down

In cc097a6, Becpl Angular UI ($BECPL_ANGULAR_URL) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Becpl Angular UI is back up in d0f6bf2 after 5 minutes.


text:
🛑 Becpl Angular UI is down

In c4080bb, Becpl Angular UI ($BECPL_ANGULAR_URL) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Becpl Angular UI is back up in ed8602b after 10 minutes.


text:
🛑 Becpl Angular UI is down

In 1385bab, Becpl Angular UI ($BECPL_ANGULAR_URL) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Becpl Angular UI is back up in b7f2406 after 16 minutes.


text:
🛑 Becpl Angular UI is down

In 9f6f71e, Becpl Angular UI ($BECPL_ANGULAR_URL) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Becpl Angular UI is back up in 551e2f8 after 5 minutes.


text:
🛑 Becpl Angular UI is down

In 05592df, Becpl Angular UI ($BECPL_ANGULAR_URL) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Becpl Angular UI is back up in 5358cd3 after 5 minutes.


text:
Question: separate public path for routes

Hi, first off, thanks so much for support this plugin!
I'm wondering if there is a way to make this plugin support my use-case:
Let's say I have all my public assets (JavaScript/CSS) served from www.example.com/static
my "Single Page Application" is rooted to www.example.com/render such that any requests to www.example.com/render/**/* will always fallback to serve the base HTML that is at www.example.com/render/ and the Javascript will handle the routing past that.
Is is possible to configure this plugin to cache both routes so that I can get true offline support?
Would I need ANOTHER service worker to handle the SPA?
Thanks again for any help!

@nicksrandall see if the SPA example can be of help. You'd have to use the correct publicPath for your configuration / application.

Would I need ANOTHER service worker to handle the SPA?

You certainly do need more than one ServiceWorker. What you need is to make your sw.js be in root of your website, i.e. /sw.js, this was it will be able to cache both places.
Also you will need to configure ServiceWorker.navigateFallbackURL or cacheMaps option.  For that see already mentioned SPA example and this https://github.com/NekR/offline-plugin/blob/master/docs/caches.md.

I'm having the same issue. I tried following the SPA example the problem is that my assets are being server out of static while the app is being server out of '/' If I set publicPath: '/' then the serviceWorker tries to fetch the static files at '/' instead of '/static'.  If I set it to publicPath: '/' then  it doesn't fetch the index file at '/'. I tried using
              // This is code from default rewrites() function, feel free to remove it
              // if not needed
              const newAsset = asset.replace(/^([\s\S]*?)index.htm(l?)$/, (match, dir) => dir || '/');
              console.log(newAsset);

              if (newAsset === '/') {
                  console.log('fired');
                  return '/';
              }

              return prepend + newAsset;

          },```
but that didn't work either.

ServiceWorker cannot cache things outside of its scope. If you generated it into /static/ then that's its scope and it cannot cache /. You need to generated sw.js into / and your assets into /static/, easiest way to do it is by settings webpack's output path to your dist folder and setting filename option to static/[name].js or something like that.  If you generated other assets with wepback, e.g. images, then it might be trickier this way.
Another way to leave everything is as, set offline-plugin's ServiceWorker.publicPath option to /sw.js and manually move sw.js out of static/ folder to the parent folder after the build.
You didn't provide more information, so that's all what I can suggest.

This is what ended up working for me
      safeToUseOptionalCaches: true,
      publicPath: '/',
      updateStrategy: 'changed',
      ServiceWorker: {
        publicPath: '/sw.js',
        events: true,
        // navigateFallbackURL: '/',
        entry: './src/sw-handler.js'
      },
      AppCache: false,
      rewrites: (asset) => {
        // This is code from default rewrites() function, feel free to remove it
        // if not needed
        const newAsset = asset.replace(/^([\s\S]*?)index.htm(l?)$/, (match, dir) => dir || '/');

        if (newAsset === '/') {
          return '/';
        }

        return `/client-assets/${newAsset}`;
      },
    })```
I set the path for the serviceWorker itself and the app root to '/' and switched all of the other ones to 'client-assets' This wasn't perfect since my other routes that I would like to server render wouldn't cache and in the end I ended up deciding to not cache the server render since it was having several auth and other related issues. But just posting it here in case someone else wants to try it.

Not sure if that's the best way, but good if it works for you. Thanks @pdiniz13!

authors: GGAlanSmithee NekR nicksrandall pdiniz13

repo: NekR/offline-plugin


text:
[feature-request] Add  to manifest for each requested permission

When trying to request some permission, if it is not declared on AndroidManifest.xml, Android will not even try to request it and directly return false when checking. I solved this temporally by adding this code on config.xml, maybe it can be added automatically.
<config-file parent="/manifest" target="AndroidManifest.xml">      <uses-permission android:name="android.permission.CAMERA" />      <uses-permission android:name="android.permission.RECORD_AUDIO" />      <uses-permission android:name="android.permission.MODIFY_AUDIO_SETTINGS" />      <uses-feature android:name="android.hardware.microphone" /> </config-file>

Thanks you made my day!

If someone has problems with android namespace, just put this in <widget> as a property so the xml is valid:
xmlns:android="http://schemas.android.com/apk/res/android"

I agree that the plugin only asks for permissions declared with <uses-permission>, but doesn't this defeat the use of the plugin?
I'm not an Android expert, but isn't the whole point to avoid <uses-permission> for runtime permissions?
After all, also the Android guide describes <uses-permissions> as problematic:

Also, when publishing an app via the Play Console such permissions are listed as "required":

...however I need these sensitive permissions only in certain rare situations and the user should not need to grant these permissions on install.
Am I missing something?

@jampy As the docs say:

Beginning with Android 6.0 (API level 23), the user can approve or reject some app permisions at runtime. But no matter which Android version your app supports, you must declare all permission requests with a <uses-permission> element in the manifest. If the permission is granted, the app is able to use the protected features. If not, its attempts to access those features fail.

All runtime permissions must be declared in the manifest to be able to ask for them to be granted at runtime.

authors: iakanoe jampy numerized vladoski


text:
Add nix support

Hei there
This PR adds support for the nix package manager, so people can simply run
nix-build default.nix

I wasn't sure if the instructions belong into the readme.md or in the wiki, what to you think?

@noeleont thank you for your contributions!
@Infinisil I am not too familiar with nix and its package management system, but is this PR different from what you were working on?

Yeah this is a bit different. What I'll be doing is adding dijo to nixpkgs, which is the standard package repository for Nix, which also builds all packages with CI for distribution. This notably also works without any Nix involvement from the project itself.
This PR on the other hand adds a way for the project itself to specify how the package can be built with Nix. Ideally the Nix expressions here would be the same as the ones for nixpkgs, but this is often problematic due to restrictions in nixpkgs. Namely Nix expressions would have to be synchronized manually (nixpkgs doesn't allow fetching Nix expressions from upstream repos), and a certain type of evaluation isn't allowed (IFD, which the expressions in this PR use).
So this PR is largely irrelevant for nixpkgs in its current state. In addition, I personally wouldn't merge this PR unless somebody is willing to maintain these Nix expressions in the future, perhaps with CI verifying that it builds with Nix.

Just opened the nixpkgs PR for it: https://github.com/NixOS/nixpkgs/pull/93597

@noeleont I would prefer the package definitions for NixOS to exist on the nixpkgs repo for the same reasons as @Infinisil mentioned:

nixpkgs has a more rigorous method of verifying/testing package definitions
maintaining nix expressions alongside dijo might get a little out of hand

Nevertheless, thanks a lot @noeleont and @Infinisil for all the help with packaging dijo for NixOS!

authors: Infinisil NerdyPepper noeleont

repo: NerdyPepper/dijo


text:
[Py API] small refactor of NodeFactory + Py helpers

This PR

~adds visit_attribute method for Interpolate and DetectionOutput~

~Modify Python API for Constant to use NodeFactory through AttributeVisitor.~

Add few python helpers for converting numpy/python type into nG type string representation (ie. np.float32 -> f32

Check in NodeFactory if someone tries to create Constant node, which is not supported from NodeFactory

Py API for ops using struct attributes are in this PR: https://github.com/NervanaSystems/ngraph/pull/4670

OV CI: passed.

OV CI

repo: NervanaSystems/ngraph


text:
Adding LED support to the BLE demo hangs the program.

After extending the BLE demo to blink an LED during the working cycle, the program operates for a few seconds then seems to hang and does not recover anymore.
Source code:
#include "riotee.h"
#include "riotee_ble.h"
#include "riotee_gpio.h"
#include "riotee_timing.h"

// <---- NEW LINE
#define TOGGLE_LED PIN_LED_CTRL
// --->

const uint8_t adv_address[] = {0x01, 0xEE, 0xC0, 0xFF, 0x03, 0x02};
const char adv_name[] = "RIOTEE";

static struct {
  unsigned int counter;
} ble_data;

void reset_callback(void) {
  riotee_ble_init();
  // <---- NEW LINE
  riotee_gpio_cfg_output(TOGGLE_LED);
  // --->
}

// <---- NEW LINES
void turnoff_callback(void) {
  riotee_gpio_clear(TOGGLE_LED);
}
// --->

int main() {
  riotee_ble_adv_cfg_t adv_cfg = {.addr = adv_address,
                                  .name = adv_name,
                                  .name_len = 6,
                                  .data = &ble_data,
                                  .data_len = sizeof(ble_data),
                                  .manufacturer_id = RIOTEE_BLE_ADV_MNF_NORDIC};
  riotee_ble_adv_cfg(&adv_cfg);
  ble_data.counter = 0;
  for (;;) {
    riotee_wait_cap_charged();
    // <---- NEW LINE
    riotee_gpio_set(TOGGLE_LED);
    // --->

    riotee_ble_advertise(ADV_CH_ALL);
    ble_data.counter++;
    /* Sleep at least 250ms before next advertising round */
    riotee_sleep_ms(250);
  }
}

Compiled with Arduino IDE 2.2.1 + Riotee Board.

The problem is the turnoff_callback(). This function was renamed to suspend_callback() with commit 8c3a794e87e5ab56a2a75ad87428e4772ba1d092. Please rename the function and close the issue if your application runs as expected.

I upgraded to the newest version of the Riotee SDK (14/01/2024) and renamed to suspend_callback and unfortunately the problem still persists. Interestingly, I accidentally tried a version without the renaming which seemed to not dead-lock. I assume that in that case the code compiles but no callback is ever called on suspension in which case
riotee_gpio_clear(TOGGLE_LED);
is never called. Could be some indication that interaction with the GPIO during suspension seems to cause the dead-lock.

OK, after fixing the turnoff_callback naming, your example seems to run fine when compiled with the SDK's makefile. The other problem is that you implement a main() and reset_callback() in an Arduino sketch. An Arduino sketch generally consists of two special functions setup() and loop(). I'm surprised that the Arduino IDE doesn't throw an exception when you try to implement the main function. Anyway, here's a version of your code adjusted to the Arduino API:
#include "riotee.h"
#include "riotee_ble.h"
#include "riotee_gpio.h"
#include "riotee_timing.h"

// <---- NEW LINE
#define TOGGLE_LED PIN_LED_CTRL
// --->

const uint8_t adv_address[] = {0x01, 0xEE, 0xC0, 0xFF, 0x03, 0x02};
const char adv_name[] = "RIOTEE";

static struct {
  unsigned int counter;
} ble_data;

void setup(void) {
  riotee_ble_init();
  // <---- NEW LINE
  riotee_gpio_cfg_output(TOGGLE_LED);
  // --->
  riotee_ble_adv_cfg_t adv_cfg = {.addr = adv_address,
                                  .name = adv_name,
                                  .name_len = 6,
                                  .data = &ble_data,
                                  .data_len = sizeof(ble_data),
                                  .manufacturer_id = RIOTEE_BLE_ADV_MNF_NORDIC};
  riotee_ble_adv_cfg(&adv_cfg);
  ble_data.counter = 0;
}

// <---- NEW LINES
void suspend_callback(void) {
  riotee_gpio_clear(TOGGLE_LED);
}
// --->

void loop() {

    riotee_wait_cap_charged();
    // <---- NEW LINE
    riotee_gpio_set(TOGGLE_LED);
    // --->

    riotee_ble_advertise(ADV_CH_ALL);
    ble_data.counter++;
    /* Sleep at least 250ms before next advertising round */
    riotee_sleep_ms(250);

}

Please close the issue if that works for you. I'll try to clarify this point in the documentation.

I tried both the original code (with the suspend_callback fix) compiled in VS code and your proposed solution compiled with Arduino IDE. The problem remains either way.
I can reproduce this problem with different Riotee devices (so it does not seem to be just one broken probe), different light sources, and different capacitor settings (I tried the smallest 3, 4, 5). The LED keeps blinking a few times (somewhat unpredictable) and BLE packets are received at the scanner, but after a while the device seems to simple hang without blinking and no more packets arrive. Only a full device reset, will make the device working again for a few seconds.
Do you have any suggestions how to debug this issue further?

Thanks for following up with this. I just tried again with the Arduino sketch and the VSCode project and both run for minutes without problems on my setup. Let's try a few things:
Debugging
The first thing I usually do to debug problems on Riotee is to attach an analog channel of a logic analyzer (or an oscilloscope) to the Vcap pin and monitor the capacitor voltage. I use a 1V constant power supply connected to Vin via a 1k resistor as a harvesting emulator as described here. You may want to try that to avoid problems due to an inadequate power supply. It's probably best to start with a known working application like the blinky example. You should see a typical intermittent execution pattern like this:

Now when running your troubled application, watch out for the capacitor voltage dropping below around 2.5V. That indicates that something goes wrong.
Reference code/binary
I've attached a zipped version of the vscode app that works on my setup:
VSCode_App.zip
Please adjust the .vscode/settings.json according to your platform and try compiling and uploading the code.
I've also attached the Arduino sketch that works on my setup:
Arduino_sketch.zip
Please give it a try.
Finally, I'm also attaching the binary hex that's just the compiled code from the vscode app binary.hex.zip. Please unzip it and upload the hex to your board with riotee-probe program -d nrf52 -f binary.hex. Does that work?
Arduino, SDK and compiler versions
Please send me the output of arm-none-eabi-gcc --version, the SDK version which you find under /path/to/sdk/.bumpversion.cfg`and the version of the Arduino package which is displayed in the Arduino IDE's board manager.
Let's hope we can get to the bottom of this!

@pbauszat  Any update on this issue?

I assume this issue has been resolved. Please reopen if not.

authors: geissdoerfer pbauszat


text:
Prometheus is unable to connect to the poller port after harvest upgrade: dial tcp 10.10.10.10:15019: connect: connection refused

Describe the bug
I upgraded harvest to latest version 21.05.3 yesterday. After the upgrade, Prometheus is unable to scrap the metrics and showing   "dial tcp 10.10.10.10:15019: connect: connection refused" error.
In the harvest log file, i can see below error.
{"level":"error","Poller":"clus01","caller":"command-line-arguments/poller.go:630","time":"2021-07-14T23:09:30-07:00","message":"no exporter of name:type prom80:prometheus"}
There are no changes to the harvest.yml file. We are using the same file from GA version of the harvest 2.0 and it was working fine till the upgrade.
Environment

Harvest version: harvest version 21.05.3-2 (commit b482aff) (build date 2021-06-28T21:08:05+0530) linux/amd64
Command line arguments used: harvest start clus01
OS: CentOS Linux release 7.9.2009 (Core)
Install method: YUM
ONTAP Version: 9.8P4

To Reproduce
NA
Expected behavior
Prometheus should continue to scrap the metrics
Actual behavior
Prometheus is failing to scrap metrics

hi @madhusudhanarya can you share your harvest.yml? If it has sensitive info, you can redact using bin/harvest doctor --print
Going by what you've pasted above, also double check that the exporter: value is Prometheus (capital P) not prometheus (lower case P).
Exporters:
    prom80:
        exporter: Prometheus

Thank you @cgrinds. Updating "prometheus" to "Prometheus" has fixed the issue.

authors: cgrinds madhusudhanarya

repo: NetApp/harvest


text:
Flush styles for styled-components

Follow along with https://github.com/zeit/next.js/tree/master/examples/with-styled-components to handle styled-components. Currently only styles for styled-jsx are flushed with the current setup.

This may involve upgrading the nteract components (that now use styled-components)

Done!

repo: Netflix-Skunkworks/commuter


text:
HystrixNetworkAuditorEventListener#handleNetworkEvent() is not invoked when encountered with Simple Network Excpetions

handleNetworkEvent() is  not invoked with few Simple Network exceptions. Here is the link for one of them.
http://stackoverflow.com/questions/40643621/hystrixnetworkauditoreventlistener-is-not-invoked-upon-failure-in-connecting-to
Is there anything that could be done. Not sure if it's the new issue . Any info on this issue would be helpful.

Just to make sure we're on the same page, the intent of the network auditor is not to detect anything about successful/network connections.  The intent is just to find all network connections that are made outside of a Hystrix command.  These are network operations which don't get the bulkheading that Hystrix offers, and are latent risks to the system.
The agent looks for Java stack traces which include java.net.Socket$2 or java.nio.channels.SocketChannel, so it's fairly naive.
If you can include the actual stack trace of the network connection you're making, then we can determine if one of these regexes should be matching or not.

Thanks for the prompt reply.
To be clear,  I just wrote a simple program that connects to local URL. It doesn't have hystrix command in code. So I expected the HystrixNetworkAuditorAgent to detect it as its not wrapped in Hystrix command.
Here is the stacktrace from my main() method. Its not detected by HystrixNetworkAuditorAgent.
java.net.ConnectException: Connection refused: connect
at java.net.PlainSocketImpl.socketConnect(Native Method)
at java.net.PlainSocketImpl.doConnect(PlainSocketImpl.java:351)
at java.net.PlainSocketImpl.connectToAddress(PlainSocketImpl.java:213)
at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:200)
at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:366)
at java.net.Socket.connect(Socket.java:529)
at java.net.Socket.connect(Socket.java:478)
at sun.net.NetworkClient.doConnect(NetworkClient.java:163)
at sun.net.www.http.HttpClient.openServer(HttpClient.java:411)
at sun.net.www.http.HttpClient.openServer(HttpClient.java:525)
at sun.net.www.http.HttpClient.(HttpClient.java:208)
at sun.net.www.http.HttpClient.New(HttpClient.java:291)
at sun.net.www.http.HttpClient.New(HttpClient.java:310)
at sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(HttpURLConnection.java:987)
at sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:923)
at sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:841)

From what I can tell, that stack trace isn't matched by the hard-coded regex that HystrixNetworkAuditorAgent uses.  I'm not sure if that's an artifact of making a local connection or not.  I think the next steps are:

Try running the agent against real calls to remote services and seeing if it is working the way you expect.
If you have examples of undetected network calls, then a PR for an addition to the regexes would be great.

Closing due to inactivity

authors: karthikitzmi mattrjacobs

repo: Netflix/Hystrix


text:
Use ember-cli-sass instead of pre-compiling scss

To work around an issue with including SASS in an Ember-CLI Add-On, the styles and building thereof, are now located under styles/ and must be built from the command line as so:

README.md#generating-styles
Basically, this isn't needed anymore.

Right. The style thing was a remnant of this being an old ember cli ~0.0.38 project.

Closing this completely as I'm moving away from SASS entirely. I find it encourages overly specific CSS output. See #96

authors: blesh jayphelps

repo: Netflix/ember-cli-nf-graph


text:
Remove PathSyntax

In response to #564
We are going to remove path syntax.  Here are some of the reasons why.

Intended use for ES6 template strings which can pull in the path-syntax library when needed.
Array understanding is required to properly build Router JSON endpoints and debugging the client.
Performance impact
Adds library size

@jhusain @ktrott @sdesai

Could you explain with an example:
“todos[0].name” <---- this is obsolete ?
’[“todos”][0][“name”]’ <---- this is the only way ?
thank you

Hey Bretto,

You would use ["todos", 0, "name"], as discussed here
e.g.
modle.get(["todos", 0, "name"])...

Alternatively, you'd require('falcor-path-syntax'), and continue to use the path syntax as you do today:
e.g.
var parser = require('falcor-path-syntax');
model.get(parser("todos[0].name"))...

The end goal, with ES6, is to support this:
get(path`todos[0].name`)

which is basically equivalent to parser("todos[0].name"), but more succinct.
See: ES6 Tagged Template Strings

@michaelbpaulson This is in master, correct?

authors: Bretto ktrott michaelbpaulson sdesai

repo: Netflix/falcor


text:
Feature request: Only report unjustified issues

I tried turning on emails reports, but these emails are filled with issues that have already been justified, which makes these reports far too noisy. I only want to be informed of unjustified issues so I can more easily identify and respond to new, unresolved issues.
This can be accomplished by simply changing the code here:
https://github.com/Netflix/security_monkey/blob/e261f7ce344a194616a42086957426e871f5871c/security_monkey/auditor.py#L721
This would be changed to:
for issue in item.db_item.issues:
    if not issue.justified:    # Added to avoid reporting previously justified issues
        item.totalscore = item.totalscore + issue.score

Good idea. Should add another if-statement as well:
if not issue.justified and not issue.fixed:
On Thu, Oct 19, 2017 at 9:10 AM Scott Piper notifications@github.com
wrote:

I tried turning on emails reports, but these emails are filled with issues
that have already been justified, which makes these reports far too noisy.
I only want to be informed of unjustified issues so I can more easily
identify and respond to new, unresolved issues.
This can be accomplished by simply changing the code here:
https://github.com/Netflix/security_monkey/blob/e261f7ce344a194616a42086957426e871f5871c/security_monkey/auditor.py#L721
This would be changed to:
for issue in item.db_item.issues:
if not issue.justified:    # Added to avoid reporting previously justified issues
item.totalscore = item.totalscore + issue.score
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Netflix/security_monkey/issues/844, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AHo1piGvpaVgcfTs9f80_LQKg0c46an2ks5st3SRgaJpZM4P_e16
.

Hey @0xdabbad00  - Are you able to PR the fix for this or would you like me to take care of it?

@monkeysecurity Probably easiest for you to PR it.  I've also noticed that I receive reports for issues for audit checks that I've disabled and will try to find how that is happening as well.  For example, the report emails include "Cert has expired" messages, but under Settings -> "Auditor Settings" I've disabled that check.

That should work.  Thank you!


text:
Unneeded IAM privilege in assumed role policy

We noticed the ses:sendemail action listed in the proposed role policy for cross-account access.

`scripts/secmonkey_role_setup.py
docs/iam_aws.md

I'll admit I didn't do more than a cursory check of the code to see if that was needed but by my reasoning that permission should only be needed on the server's policy, not the cross-account role.

Sorry, never mind I realize this is fixed on develop.


text:
fix-basestring-reload-unicode-for-Python3

unicode() was removed in Python 3 because all str are Unicode so this PR:

Changes all calls to unicode() into calls to six.text_type()
Change all instances of (str, unicode) to six.string_types
Change remaining instances of unicode to six.text_type

basestring was removed in Python 3 so for each Python file that contains basestring, this PR adds from six import string_types and replaces basestring with string_types.
The builtin reload() was moved into importlib in Python 3 because it was being overused and led to odd behavior that was often difficult to diagnose.  Here we are trying to reload(sys) probably because 'utf-8' encoding and Unicode strs are not the default in Python 2.  They are however the default in Python 3 so this PR therefor suggests that a pass would be satisfactory in Python 3.

Coverage increased (+0.02%) to 72.009% when pulling a928c1a1914018196680475b4d100100a8118424 on cclauss:unicode-to-six.text_type into f1d0a191613bace0683b841d723891e9a9067b9f on Netflix:develop.

authors: cclauss coveralls


text:
Wait For Titus Isolate to Isolate Workload Before Starting Workload

Titus isolate waits for Docker events, and such. This sometimes
can take a moment. In order to avoid racing, and have the application
read the CPU state, and then configure itself based on that CPU
state, we wait for titus-isolate up to some timeout.

Pull Request Test Coverage Report for Build 2969

41 of 87 (47.13%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.2%) to 25.948%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

executor/runtime/docker/docker_isolate.go
28
37
75.68%

executor/runtime/docker/docker.go
13
50
26.0%

Files with Coverage Reduction
New Missed Lines
%

executor/runtime/docker/docker.go
1
6.48%

Totals

Change from base Build 2956:
0.2%

Covered Lines:
2996

Relevant Lines:
11546

💛  - Coveralls

authors: coveralls sargun

repo: Netflix/titus-executor


text:
Build OpCode analyzer

Build an analyzer that walks through the opcodes of the given contract and analyzes it and finds chunks of opcodes that match a sequence that is ILed and known to be optimized. That would result in creation of ILInfo for the given byte code.
The decision whether or when the given CodeInfo should be a subject of analysis would be left for later.
Plan of Action

[ ] create IlInfo component that is constructed from the byte code
[ ] make IlInfo dense and small, for example (ushort[] pcs, byte[] iledMethods) for storing all the data
[ ] add HasOverride(int pc) and the delegating method

@Demuirgos

repo: NethermindEth/IL-EVM


text:
Integrate "starknet-abi-forms" for contract deployment & interaction

Integrate the form tool from @prix0007: https://www.npmjs.com/package/starknet-abi-forms

Will be solved by #215

repo: NethermindEth/starknet-remix-plugin


text:
Add support for IrregularlySampledSignal in NeoMatlabIO

fixes #1126

Hello @apdavison! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file neo/io/neomatlabio.py:

Line 40:78: W291 trailing whitespace

Thanks for the extension! Looks good to me :)

authors: JuliaSprenger apdavison pep8speaks

repo: NeuralEnsemble/python-neo


text:
filter empty files while reading in neuralynxrawio.py

We have multiple records, where some channels are missing, i.e., they have only the header in it. Therefore the pull request

Hello @sin-mike! Thanks for submitting the PR.

In the file neo/rawio/neuralynxrawio.py, following are the PEP8 issues :

Line 91:41: E225 missing whitespace around operator
Line 482:27: E127 continuation line over-indented for visual indent

Coverage increased (+0.4%) to 49.969% when pulling 924b24cef27770672a22a6c05b536a3f0304410b on sin-mike:master into 9ec44c692b0e1b48931f2ea435ff3769afc6f195 on NeuralEnsemble:master.

Coverage increased (+0.4%) to 49.969% when pulling 924b24cef27770672a22a6c05b536a3f0304410b on sin-mike:master into 9ec44c692b0e1b48931f2ea435ff3769afc6f195 on NeuralEnsemble:master.

Coverage increased (+0.4%) to 49.969% when pulling 924b24cef27770672a22a6c05b536a3f0304410b on sin-mike:master into 9ec44c692b0e1b48931f2ea435ff3769afc6f195 on NeuralEnsemble:master.

Hi @sin-mike!
Thanks for your contribution! Indeed, we never had any empty files, so I never considered this case.
However, I would prefer not to print every time there is an empty file to avoid unnecessary output. Could you remove the print? If this information is important for you, I would suggest to rather track this somewhere in the io, so you can access it from your scripts.

Hi @sin-mike! and @JuliaSprenger
Maybe we could apply this case only to ncs files because an empty nev could be something valid or desired:

          if os.path.getsize(filename)<=HEADER_SIZE and ext=='ncs':
              self._empty_files.append(filename)
              continue

Best,
Samuel

It is OK for me.
Thank you very much for the patch.
I guess it is the very first commit from kazan!!
Welcome.

authors: JuliaSprenger coveralls pep8speaks samuelgarcia sin-mike


text:
framework.py vs. init.py

Just a thought -- maybe instead of framework.py, you could use relative imports in init.py to achieve the same result? Then instead of e.g.
import framework as f
you could have something like
import netpyne as N
and then this would work both inside and outside of the repository. For an example see
https://github.com/optimamodel/Optima/blob/cleaned-up-imports/optima/__init__.py
To do this __init__.py would simply be:
from . import sim
from . import analysis
from .network import Network
from .cell import Cell, PointNeuron, Pop
from . import utils
from . import default

import pylab

so each of the modules (eg. sim, network or analysis) import framework to have access to other modules -- would this work with the init.py method?
I cant access https://github.com/optimamodel/Optima/blob/cleaned-up-imports/optima/init.py
thanks

ok found a way around it -- all sim functions are now in simFunc.py; framework.py is renamed as sim.py and imports all simFuncs, as well as all other modules.
So now everything is accessed via sim

authors: cliffckerr salvadord

repo: Neurosim-lab/netpyne


text:
Add installer for Windows

Hey Neversink,
how do you feel about a little PowerShell script to copy the file to the correct directory automatically?
For people that clone the repo, like me, this would help.
For people that don't use git, they could potentially run Invoke-WebRequest, though that means they have to trust you. :-D

The Windows powershell script is really just a one liner to download the filter:
curl https://raw.githubusercontent.com/NeverSinkDev/NeverSink-PoE2litefilter/refs/heads/main/NeverSinks Litefilter.filter -o "$($ENV:userprofile)\Documents\My Games\Path of Exile 2\NeverSinks-Litefilter.filter"

The version with http-proxy:
Invoke-WebRequest https://raw.githubusercontent.com/NeverSinkDev/NeverSink-PoE2litefilter/refs/heads/main/NeverSinks%20Litefilter.filter -OutFile "$($ENV:userprofile)\Documents\My Games\Path of Exile 2\NeverSinks-Litefilter.filter" -Proxy "http://127.0.0.1:7777"

I think I'll pass on this one.
It's true that this is more comfortable and intuitive, but I see some dangers here, that users might start thinking filters require an installer and that trust can be abused by others.
This filter is at most temporary and I hope we'll be back to subscription/filterblade-export style filters soon.

authors: NeverSinkDev abevol andrewrkerr totkeks


text:
Is real TRX Wallet?

this is app create wallet is a eth wallet ?

Yes, I also found this to be an ETH wallet, we were misled.

repo: NewHorizonLabs/TRX-Wallet


text:
Update default featured image on app load

Currently, when the app loads, it shows an unrelated image in the featured section while the app loads.
I think it makes sense to make this either a loading icon or something that signifies a loading state to the user.

@samclaridge thoughts on this?

fixed by https://github.com/NewSpring/Apollos/pull/710

authors: johnthepink jonhorton samclaridge

repo: NewSpring/Apollos


text:
MCS-1771: Monitor process script to handle timeouts

Will be off by default, but wanted to get this in since it happened for me for a couple of scene types during Eval 6.
Basically, if a timeout situation occurs and the user stops taking any steps: there is code on the Python API side to create a scene history + video files if there is inactivity for x amount of time, but something else needs to handle actually quitting TA1's runner code + exiting Unity, otherwise things just hang.
Note that I only incorporated this for MESS, but tried to leave detailed instructions in case its needed elsewhere.

The code looks good. Is there anything you want us to do in order to test it ourselves? I haven't run the MESS code before, so getting setup might be more trouble than it's worth. I'm fine with approving the PR with just looking over the code though :)

I think that's fine -- I'll run an additional retest now just in case that I've reverted some things but I don't expect anyone else to get spun up on how MESS worked in Eval 6. I'll leave this open for a bit though before merging in case others want to take a look.

Finished retest mentioned in earlier comment, things look good. I don't expect anyone to do this, but in case anyone wants to test with MESS:

be sure to update mess.yaml with local variables (i.e. eval-35-test for the s3_folder and s3_movie_folder, updating cluster and user names, updating timeout to a smaller interval so you don't have to wait around as long, setting has_monitor_process to true.)
set workers in mess.yaml to 0 so you're only running a head node + if you're running on one node its easier to guarantee that things are recovering properly between scenes
make a mako/*.yaml run file referencing a directory with one or a few scenes to test (some scenes that triggered the timeout situation for MESS include 'kilo_0011_01' and 'kilo_0011_02')

repo: NextCenturyCorporation/mcs-pipeline


text:
docs: translate docs/routing/shallow-routing.md

遅くなってごめんなさい。やる気がどっかにいってしまってました。
docs/routing/shallow-routing.md を翻訳しました。
不備等あったらおしえてください！一瞬で直します。

添削ありがとうございます。指摘された箇所を修正しました。

お手数おかけしてすみません！
修正しました。ご確認おねがいします。

@all-contributors please add @tanakaKSUK for translation

翻訳していただきありがとうございます！LGTMです！

authors: hiro08gh tanakaKSUK yokinist


text:
docs: remove static optimization indicator

「静的最適化インジケータ」ページの状態を本家に追従させるための PR です。
本家では現在、マークダウンファイルは存在するものの、docs/manifest.jsonから削除され、公式サイトからは閲覧できない状態になっています。
また、関連項目が削除され、注意書きが追加されています。
https://github.com/vercel/next.js/blob/5baedf55/docs/api-reference/next.config.js/static-optimization-indicator.md
docs/manifest.jsonから削除される際に、Automatic Static Optimizationからのリンクも削除されています。
https://github.com/vercel/next.js/blob/5baedf55/docs/advanced-features/automatic-static-optimization.md
この PR で、本家と同じ状態になります。
cf. https://github.com/vercel/next.js/pull/18629

docs/manifest.json については, 3日前に Timがまた static optimization indicator の項目を前とは別の場所に追加するコミットをしていますね🤔

全く気付きませんでした……。Issue でも議論されてますが、本家に追従していくのはかなり大変そうですね。
私としては、どちらの対応でも構わないです。

docs/manifest.json については, 3日前に Timがまた static optimization indicator の項目を前とは別の場所に追加するコミットをしていますね🤔

全く気付きませんでした……。Issue でも議論されてますが、本家に追従していくのはかなり大変そうですね。
私としては、どちらの対応でも構わないです。

PRありがとうございます！
ここについては翻訳済ドキュメントの追従方針がまだ決まっていなかったので #189 にもイシューをたてていたところでした！
なので、まずは追従方針(特に今回の場合はタイミング)について決める必要があると思っています！
個人的には気付いたときに随時追従/更新する方針だと、きりがなく運用が大変そうなのと今回のように今後変わりうる可能性も高いものもあるので、基本的には新しいマイナーバージョン(例えば次だったら v10.1.0 など)が出たタイミングに絞り追従させる方針がいいのかなと思いました。（先日更新させた #186 は方針決まっておらず、その時点でのcanaryを追従させてしまいました...🙇♂）
あくまで判断材料としてですが、マイナーバージョンのリリースタイミングに絞るとなると現時点で最新が v10.0.6-canary.7 になるので追従先は v10.0.0 になりそうです（既に反映してしまったのと以前の更新もリリース時のものでなかったので、もしこの運用でやるなら次リリースから運用したいと思います）。
https://github.com/vercel/next.js/tree/118ab7992bc8f7a7e5a7bb996510d9b56ffe4f68
何かアイデアあればコメントいただけると嬉しいです 🙏

PRありがとうございます！
ここについては翻訳済ドキュメントの追従方針がまだ決まっていなかったので #189 にもイシューをたてていたところでした！
なので、まずは追従方針(特に今回の場合はタイミング)について決める必要があると思っています！
個人的には気付いたときに随時追従/更新する方針だと、きりがなく運用が大変そうなのと今回のように今後変わりうる可能性も高いものもあるので、基本的には新しいマイナーバージョン(例えば次だったら v10.1.0 など)が出たタイミングに絞り追従させる方針がいいのかなと思いました。（先日更新させた #186 は方針決まっておらず、その時点でのcanaryを追従させてしまいました...🙇♂）
あくまで判断材料としてですが、マイナーバージョンのリリースタイミングに絞るとなると現時点で最新が v10.0.6-canary.7 になるので追従先は v10.0.0 になりそうです（既に反映してしまったのと以前の更新もリリース時のものでなかったので、もしこの運用でやるなら次リリースから運用したいと思います）。
https://github.com/vercel/next.js/tree/118ab7992bc8f7a7e5a7bb996510d9b56ffe4f68
何かアイデアあればコメントいただけると嬉しいです 🙏


text:
Invalid response from DBD CDN on dev branch

When trying to access https://dbd.wolfer.io/api/archive?branch=dev the following error is shown
Invalid response from DBD CDN
There seems to be problem with Access Denied when accessing the branch, I guess some specific authentication is needed for the branch. Is it possible to implement it such authentication for dev branch on your side?
PS: Thanks for your great work.

Hello! Sorry for the long response, I'll start debugging the API and see why its returning an invalid response. Maybe the devs changed part of their api/cdn to require authentication.

After checking with some people, it seems they protected the endpoint with some credentials we dont have. So saddly we cannot make it grab the dev branch of the archives. Sorry, if someone tells us how I can add it to the website, but until then I guess it'll have to stay the way it is. :(

authors: Nexure wladimiiir

repo: Nexure/DBD-API


text:
报错信息为1003, 登录超时

都按Markdown里面的步骤来的，最后actions里面跑的时候每次都是{'code': 1003, 'msg': '登录超时'}，token和教务系统网站以及账号密码那些应该都对的，不知道哪里出问题了
总不可能是因为验证码的问题？

提供一下教务系统url，我看下是否是版本不支持 suinian666@gmail.com

https://jwweb.scujcc.cn/

你的教务系统版本太老了

你的教务系统版本太老了

你的教务系统版本太老了

提供一下教务系统url，我看下是否是版本不支持 suinian666@gmail.com

https://jwweb.scujcc.cn/

你的教务系统版本太老了

提供一下教务系统url，我看下是否是版本不支持 suinian666@gmail.com

https://jwweb.scujcc.cn/

你的教务系统版本太老了

好吧，不过还是谢谢了😂

repo: NianBroken/ZFCheckScores


text:
NiftyNet need new logo and some style.

Hello,
this my logo design for your project. Its free, created on Utopian platform where users are rewarded for contributions to open-source projects. You dont have to agree on anything or pay anything, its free to use, just like your code.
https://busy.org/@andrejcibik/niftynet-logo-open-source-convolutional-neural-networks-platform

To ease the discussion, I am copying the alternative suggestion made in #59 by @Colmena-PM:

https://steemit.com/utopian-io/@colmena-powmax/logo-designs-for-niftynet

I'd like to thank @Colmena-PM and @andrejcibik for their designs.
Comments to @andrejcibik's design:

I like the simplicity of this logo.
The colours could be a bit more prominent and shiny. Or maybe black can be used for "NiftyNet" as well as the two triangular / shadowy shapes?
The shape to the left looks a bit too random to me. How does it relate to NiftyNet?
The colours look "speckled". Is that deliberate?
The font of "NiftyNet" is edgy while the shape is not.

Comments to @Colmena-PM's design:

The colour is catchy, but causes a bit of strain to the eyes.
Also I'm not sure how well it will play with other logos, for instance on a PowerPoint slide.
The "font" of the "N" in the logo does not match that of the N's in "NiftyNet"
I assume the second shape in the logo is an "N" as well? However this is not immediately clear, and a bit confusing. Also, I can't relate the components that make up that second "N" to anything relevant to NiftyNet.

If just a styled brain :) "specs" and shadows are just part of the presentation :) Thank you for feedback anyways.
If you would like all user on Utopian to "compete" to make you a new design, you can register and createso called "Task request"..... for free :)

more ideas @ utopian.io:
https://utopian.io/project/NifTK/NiftyNet/github/101853569/all

Copying proposal from @moenawar85 in #64 for convenience.

Hello,
this my logo design for your project. Its free, created on Utopian platform where users are rewarded for contributions to open-source projects. If you like it, spread the good work about the platform.

Can I contribute new logo design for Nifty Net??

We need to revive this. Also just saw that the logo of Subtle Medical is somehow similar to the first one proposed in this thread: https://www.linkedin.com/company/subtlemedical/

@tvercaut @mjorgecardoso What are we doing here? It has been open for 1 year and no action. Closing for now?

@mmodat No, this is still open.

NiftyNet is now unmaintained. This issue can thus be closed.

authors: andrejcibik dzhoshkun mmodat nasirparwaz tvercaut wyli

repo: NifTK/NiftyNet


text:
Add indication to download button when download is finished

The problem
Currently the download button in ImageViewer does not display progress nor any status of what has happened with the download itself.
The purposed solution
Add some kind of indication (CircularProgressBar/Icon) to display the status of current download state.
We already have a function for tracking progress, we need to have a hook that'd change download button's contents depending on the status.
/// lib/pages/image_viewer_page.dart:90
await Dio(BaseOptions(headers: {"User-Agent": "IbukiMobile/1.0.0 Ibuki/1.0.0 (Night Sky Studio)"})).download(
    image.originalFileURL,
    savePath,
    onReceiveProgress: (received, total) {
        if (total != -1) {
            debugPrint("${(received / total * 100).toStringAsFixed(0)}%");
            //you can build progressbar feature too
        }
    }
);

Fixed in #15

repo: Night-Sky-Studio/ibuki-mobile


text:
'Failed to resolve directive: el' when inside a bootstrap-vue popover

Detailed description
I'm trying to render this slider component inside a bootstrap-vue popover but it fails with following warn message:
Failed to resolve directive: el

Code
HTML
 <b-popover  placement="bottom" target="popoverId" triggers="click blur">
     <vue-slider ref="slider" v-model="value"></vue-slider>
 </b-popover>

root.js
import vueSlider from 'vue-slider-component/src/vue-slider.vue'
Vue.component('vue-slider',vueSlider)

component.js
 export default {
        props: [],
        data()
        {
            return {
                value : 1
            };
        }
    };

Environment

vue: 2.5.3
bootstrap-vue: 1.1.0
vue-slider-component: 2.4.5

Sorry, my mistake.

The slider is rendered now but the mouse (drag) event is very laggy and slow and at 99% in the cases the piecewise dot block at the init positions and didn't move anymore. I've rendered two sliders binded to the same data source to make the issue clear. See the screenshot below.

Console
`
[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
[Violation] Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
[Violation] 'message' handler took 161ms
[Violation] Added non-passive event listener to a scroll-blocking 'touchmove' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
`

I am sorry for late reply.
Are you experiencing the problem for this reason?
https://github.com/NightCatSama/vue-slider-component#exceptions
example: https://jsfiddle.net/2xy72dod/253/

authors: NightCatSama lachezargrigorov

repo: NightCatSama/vue-slider-component


text:
Want to add some documentations

Want to add CODE_OF_CONDUCT.md and also update your readme.md

I don't think we need this right now


text:
[BUG] Windows defender false(?) positive issue

Versions

EasyAuth 3.0.19
Fabric API 0.92.2

Describe the bug
Windows defender marks mod's .jar file as a virus (Trojan:AndroidOS/ZkarletFlash)
To Reproduce
Steps to reproduce the behavior:

Launch minecraft
See "Incompatible mods found!" screen
Read
FileNotFoundException: path to mods folder\easyauth-mc1.20-3.0.19. jar (Операция не
была успешно завершена, так как файл содержит вирус или потенциально нежелательную программу)

Expected behavior
minecraft launches and works fine like it did yesterday and the day before

It's a false positive, and the reason (I think) some antiviruses trigger on this file is because I tried to recompress included libraries to make the JAR smaller.
You can download 3.0.19 from GitHub, and it will not trigger antiviruses:
https://github.com/NikitaCartes/EasyAuth/releases/tag/3.0.19
You can also compare versions from Modrinth/CurseForge and GitHub and see that their content is identical

authors: NikitaCartes kryakvanya

repo: NikitaCartes/EasyAuth


text:
Camera wiggling

When i reset to the checkpoint the camera is wiggling
https://user-images.githubusercontent.com/122171922/211163016-621ff17e-48d8-400d-b6de-7acd1af0fb2b.mp4

This is just the way the plugin works.  It can't actually freeze time so it constantly moves everything back to the checkpointed position, which can result in things looking this way.


text:
NonUniqueDeviceError while Yubikey NEO is connected

Hi,
I use a YubiKey NEO along with my NK3 (for static password and some sites which only support Yubico OTP).
As long as the Yubikey is connected to my PC, I am unable to interact with my NK3:
PS Z:\> nitropy.exe fido2 list-credentials
Command line tool to interact with Nitrokey devices 0.4.4
Please provide pin:
Critical error:
An unhandled exception occurred
Exception encountered: NonUniqueDeviceError()

I am also unable to register the NK3 for U2F on any website.
When I remove the Yubikey, everythink works fine. Happens on v1.5.0, just upgraded to v1.6.0-rc.1, same issue.
Is this expected behaviour? The Yubikey NEO doesn't even support FIDO2.
Windows 11 23H2 (Build 22631.2715)

The first issue: accessing the Nitrokey 3 while another FIDO2 device is present should be solvable by also passing the specific device like that:
nitropy fido2 list-credentials -s device=/dev/hidraw11

With the device being what is written in the first column in nitropy nk3 list. At least this is what works (for Linux) if you have connected more than one Nitrokey 3.
The other issue, the U2F register is pretty weird, also just tested this successfully on webauthn.io using 2x Nitrokey 3. Registering the device works with both devices and both will ask for the user confirmation (user presence) and the one which is confirmed will then be registered for the service.
On a first glance this looks like the Yubikey Neo does not behave as expected (defined by the spec). Although it has no FIDO2 capabilities it comes with U2F (which likely is also the reason the non-unique error is shown by nitropy) and my guess would be that this is roughly the same reason why registering won't work if both devices are plugged in.

Thanks for your answer. Do you have any idea how to select the device on Windows?
nitropy.exe nk3 list
Command line tool to interact with Nitrokey devices 0.4.42
:: 'Nitrokey 3' key\\?\hid#vid_20a0&pid_42b2&mi_01#c&22afc97d&0&0000#{4d1e55b2-f16f-11cf-88cb-001111000030}: Nitrokey 3 D5DAB95933C43C5691135B4681EC888E

Tried various parts from that output but it always throws errors like ArgumentError("argument 1: <class 'TypeError'>: wrong type").

authors: daringer jwgn


text:
nitropy fido2 update fails with NoSoloFoundError('no Nitrokey FIDO2 found') <FIXED: usbguard>

I tried to update the firmware of a Nitrokey FIDO2 using nitropy.
The update starts nicely, it detects the USB device, tries to enter bootloader mode, and asks for confirmation with the button on the key.
I press the button on the FIDO2 key, and directly after that the software returns a critical error, and says that no FIDO2 key could be found.
After that the Nitrokey shows a blinking (alternating?) red and blue light.
I will attach the log that was produced in /tmp.
nitropy.log.l9gp9su2.txt

I am so sorry.
I found the problem, and fixed it.
I am running usbguard, and that blocked the USB device.
When performing the update, and switching to bootloader mode, the USB device ID changes.
The new USB device ID was blocked by usbguard.
I added the second USB device ID to usbguard, and the update was 100% OK.
-> Maybe this is something for the FAQ?

closing in favor of: https://github.com/Nitrokey/nitrokey-documentation/issues/190

authors: daringer ek-alliander

repo: Nitrokey/pynitrokey


text:
Screen sharing in Firefox with Wayland Gnome

Describe the bug
A couple of days ago screen sharing stopped working. I primarily use it with JitSi in Firefox and it used to work just fine.
To Reproduce
Steps to reproduce the behavior:

Using Gnome with Wayland start Firefox (from a terminal to see error message below)
Navigate to a website with screen sharing, e.g. https://meet.jit.si/screen-sharing-test
Try sharing the screen

Expected behavior
After selecting the screen it will be shared with the web application.
Screenshots
https://user-images.githubusercontent.com/1684495/115152378-222c2880-a071-11eb-9fae-7d2664a69c0c.mp4
Additional context
The firefox-wayland package is installed using Home Manager from nixpkgs. Current (affected) version is 87.0.
In the terminal where I ran Firefox I see an error:
[E][000000378.275192][context.c:224 pw_context_new()] context 0x7fb26b509400: can't load config client.conf: No such file or directory

It works if I downgrade to Firefox 85.0.1, for example like this:
$ nix-shell \
  -p firefox-wayland \
  -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/bed08131cd29a85f19716d9351940bdc34834492.tar.gz
...
[nix-shell:~]$ firefox --version
Mozilla Firefox 85.0.1

[nix-shell:~]$ firefox
...

Notify maintainers
@edolstra
@lovesegfault
@mweinelt
Metadata

system: "x86_64-linux"
host os: Linux 5.11.11, NixOS, 20.09.3793.cce26cd83d2 (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.4pre20210317_8a5203d
channels(root): "nixos-20.09.3824.dec334fa196"
channels(tad): "home-manager, nixpkgs"
nixpkgs: /home/tad/.nix-defexpr/channels/nixpkgs

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/screen-sharing-with-wayland-gnome/12449/5

Can only test this on sway on nixos-unstable, works on Firefox 87.0 for me. Your Firefox version is quite dated. Also the issue could be in the xdg-desktop-portal. What is your config with regard to that?

Thanks for getting back to me. I am on version 87.0 too. That's the one with the issue. In version 85.0.1 it works for me. Sorry, it wasn't clear in my original message. I edited it.
Previously I didn't have any XDG Portal specific configuration and it was working. After the problem began I tried setting up xdg portal as described in https://nixos.wiki/wiki/Firefox and now I have the following lines in my /etc/nixos/configuration.nix:
{ config, pkgs, ... }:

{
# ...

  services.xserver.desktopManager.gnome3.enable = true;
  services.xserver.displayManager.gdm.wayland = true;
  services.xserver.displayManager.gdm.enable = true;

  ## This is from https://nixos.wiki/wiki/Firefox
  ## Trying to get https://discourse.nixos.org/t/screen-sharing-with-wayland-gnome/12449
  ## Makes Gnome Shell startup very slow (> 60s) and doesn't fix the sharing problem
  # xdg = {
  #   portal = {
  #     enable = true;
  #     extraPortals = with pkgs; [
  #       xdg-desktop-portal-wlr
  #       xdg-desktop-portal-gtk
  #     ];
  #     gtkUsePortal = true;
  #   };
  # };

# ...
}

As you see I've tried to explicitly setup XDG portal (the commented out lines) but it didn't help.
Here are relevant parts of ~/.config/nixpkgs/home.nix:
{ config, pkgs, ... }:

{
# ...

  systemd.user.sessionVariables = {
    # firefox screencapture
    MOZ_ENABLE_WAYLAND="1";
    MOZ_USE_XINPUT2="1";

    # SDL
    SDL_VIDEODRIVER="wayland";

    # QT
    QT_QPA_PLATFORM="wayland";
  };

  programs.firefox = {
    enable = true;
    package = pkgs.wrapfirefox pkgs.firefox-unwrapped {
      forcewayland = true;
      extrapolicies = {
        extensionsettings = {};
      };
    };
  };
  ## Previously was:
  # programs.firefox.enable = true;

# ...
}

Sorry, no idea why it would not work on GNOME.

I got the screen sharing to work by installing Firefox globally (i.e. via /etc/nixos/configuration.nix and not Home Manager). More details here: https://discourse.nixos.org/t/screen-sharing-with-wayland-gnome/12449/8.

authors: mweinelt nixos-discourse tad-lispy

repo: NixOS/nixpkgs


text:
Add GDM option to hide users list

Issue description
I'd like to have a NixOS option to make GNOME Display Manager (GDM) hide the list of users that it shows on its log-in screen. This sounds simple enough (1, 2), and I wrote a patch, but I don't understand DConf or know what I'm doing with this GNOME stuff, nor do I know how to test a patch to a NixOS module.
Technical details

system: "x86_64-linux"
host os: Linux 5.10.62-hardened1, NixOS, 21.11 (Porcupine)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.15
channels(root): "nixos-21.11pre313614.09cd65b33c5"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

https://nixos.wiki/wiki/Nixpkgs/Reviewing_changes


text:
Hatchling backport

I cannot use hatchling as part of poetry2nix from nixos-21.11, because it's only in nixpkgs-unstable.
Is there any chance it could be backported?
The question came from here: https://github.com/nix-community/poetry2nix/issues/605

cc @r-ryantm and mweinelt

If it just works with python packages on 21.11 maybe, if it requires more changes definitely no.

@SuperSandro2000 sounds good to me. How do we check?

Clone the repo, checkout nixos-21.11, cherry-pick the commit and see hot that works.

@SuperSandro2000 Trying that here: https://github.com/NixOS/nixpkgs/pull/171541
Looks like it's not that simple.

fixed in https://github.com/NixOS/nixpkgs/pull/171576

authors: NorfairKing SuperSandro2000 dotlambda


text:
Ruby's mkmf produces Makefiles with incorrect paths

Describe the bug
Ruby's mkmf library produces a Makefile containing the linker flag -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-ruby-2.7.6/lib. Both Ruby 3.1.2p20 and Ruby 2.7.6 produce Makefiles with that exact same path.
Steps To Reproduce
Steps to reproduce the behavior:

Create the file extconf.rb with the following two lines.require 'mkmf'
create_makefile('bug')

Run nix-shell --pure -p ruby. (Or nix-shell --pure -p ruby_3_1.)
Run ruby extconf.rb
Examine the Makefile.

Here's the output when I follow these steps.
% printf "require 'mkmf'\ncreate_makefile('bug')\n" > extconf.rb
% nix-shell --pure -p ruby_3_1

[nix-shell:~/programming/extconf-bug]$ ruby extconf.rb
creating Makefile

[nix-shell:~/programming/extconf-bug]$ grep eeeee Makefile
ldflags  = -L. -fstack-protector-strong -L/nix/store/kajnjyc3340hqd3hby7fz7hdw26aa9dy-gettext-0.21/lib -L/nix/store/k8nl69w6vyks538qxdx62al8g9z394w7-file-5.41/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-ruby-2.7.6/lib -L/nix/store/v6fvmjvp520s0vg15zsfpvn01rpy7vzi-libffi-3.4.2-dev/lib -L/nix/store/xkngbsr08qm90qrz7ngckf38anval8bi-ncurses-6.3-dev/lib -L/nix/store/5k4yvh7dsndny15zf7wjk5hs3pp7vs6w-zlib-1.2.12-dev/lib -L/nix/store/azp0qdvjmcws7hj2b5pzj68v4vpp7p6b-openssl-1.1.1o-dev/lib -L/nix/store/mbmnl59rfaj6kww61w3pwgdvdqib14nz-gdbm-1.23/lib -L/nix/store/6fpbrnj9v3babx03zj07zk03msbqnpja-libyaml-0.2.5/lib -L/nix/store/hxygwa1k49my5b8k8nm3nqjjr12ayj02-libiconv-50/lib -L/nix/store/knxwdpj06dziskmzhqrqgrab5a4g6wlp-libobjc-11.0.0/lib -L/nix/store/4qwaj5hmblwdhblk7vfxwg0hbqngjf03-libobjc-11.0.0/lib -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-clang-wrapper-11.1.0/resource-root/lib -L/nix/store/lg0ykg3q8rdmpilhiqwxvas3wdpx890s-libSystem-11.0.0/lib

Expected behavior
I expect this to produce a Makefile without the linker flag to the nonexistent path.
Notify maintainers
@vrthra @manveru @marsam
Metadata
% nix-shell -p nix-info --run "nix-info -m"
these 2 paths will be fetched (0.01 MiB download, 0.14 MiB unpacked):
  /nix/store/9is81fx0kgpggn91wpqak6nzmrn1l5d5-DarwinTools-1
  /nix/store/wca7qkln6jf20w5m3aqbsqvvq105m8ma-nix-info
copying path '/nix/store/9is81fx0kgpggn91wpqak6nzmrn1l5d5-DarwinTools-1' from 'https://cache.nixos.org'...
copying path '/nix/store/wca7qkln6jf20w5m3aqbsqvvq105m8ma-nix-info' from 'https://cache.nixos.org'...
 - system: `"aarch64-darwin"`
 - host os: `Darwin 21.5.0, macOS 12.4`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.8.0`
 - channels(steve): `"nixpkgs-21.11-darwin-21.11-darwin"`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

Seems darwin-specific. Can't reproduce on linux, but happens on x86 darwin as well.

I believe this is making some of the gems on my project not be able to build. Has anyone find a workaround  yet?

@donferi My experience as a maintainer of a gem that has a native extension is that the extra linker flags cause warnings like
ld: warning: directory not found for option '-L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-ruby-2.7.6/lib'

but that the build succeeds despite the warning. Which gems are failing for you?

@viraptor I believe the paths come from the base Ruby version. Perhaps that's set on macOS but not on Linux for some reason. I didn't dig into why they're different, but #213841 should hopefully take care of the problem.

authors: donferi stevecheckoway viraptor


text:
Libreoffice Base crashes at start

Describe the bug
Libreoffice crashes near the start when making a new Base file.
Steps To Reproduce

Open Libreoffice
Create a new "Base" file. Accept the default settings and click next a few times.

Additional context
NixOS x86_64-linux
nixpkgs nixos-22.11 @ 339fc3dcc98f39d08496fb90c0d6b5fb81519246
Same result with pkgs.libreoffice or pkgs.libreoffice-fresh
Exception in thread "Thread-0" java.lang.NoClassDefFoundError: java/sql/SQLException
Caused by: java.lang.ClassNotFoundException: java.sql.SQLException
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
Exception in thread "Thread-0" java.lang.NoClassDefFoundError: java/sql/SQLException
Caused by: java.lang.ClassNotFoundException: java.sql.SQLException
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)

Fatal exception: Signal 11
Stack:
/nix/store/3h5qzzfwx50nqs1ykaanfy7zi3bshx4a-libreoffice-7.3.7.2/lib/libreoffice/program/libuno_sal.so.3(+0x401d3)[0x7fc2550c31d3]
/nix/store/3h5qzzfwx50nqs1ykaanfy7zi3bshx4a-libreoffice-7.3.7.2/lib/libreoffice/program/libuno_sal.so.3(+0x40394)[0x7fc2550c3394]
/nix/store/cd37wc6s7ycgn69w5z74w3xqwnpy5941-openjdk-minimal-jre-17.0.3+7/lib/server/libjvm.so(+0xd86906)[0x7fc225f21906]
/nix/store/cd37wc6s7ycgn69w5z74w3xqwnpy5941-openjdk-minimal-jre-17.0.3+7/lib/server/libjvm.so(JVM_handle_linux_signal+0x23d)[0x7fc225f2233d]
/nix/store/9xfad3b5z4y00mzmk2wnn4900q0qmxns-glibc-2.35-224/lib/libc.so.6(+0x3dbf0)[0x7fc254dc4bf0]
/nix/store/cd37wc6s7ycgn69w5z74w3xqwnpy5941-openjdk-minimal-jre-17.0.3+7/lib/server/libjvm.so(+0x28a2c0)[0x7fc2254252c0]
/nix/store/cd37wc6s7ycgn69w5z74w3xqwnpy5941-openjdk-minimal-jre-17.0.3+7/lib/server/libjvm.so(+0x8b45f7)[0x7fc225a4f5f7]
/nix/store/3h5qzzfwx50nqs1ykaanfy7zi3bshx4a-libreoffice-7.3.7.2/lib/libreoffice/program/../program/libjdbclo.so(+0x42f94)[0x7fc226529f94]
/nix/store/3h5qzzfwx50nqs1ykaanfy7zi3bshx4a-libreoffice-7.3.7.2/lib/libreoffice/program/../program/libjdbclo.so(+0x43664)[0x7fc22652a664]
/nix/store/3h5qzzfwx50nqs1ykaanfy7zi3bshx4a-libreoffice-7.3.7.2/lib/libreoffice/program/../program/libjdbclo.so(+0x31128)[0x7fc226518128]
/nix/store/3h5qzzfwx50nqs1ykaanfy7zi3bshx4a-libreoffice-7.3.7.2/lib/libreoffice/program/../program/libjdbclo.so(+0x3256d)[0x7fc22651956d]
/nix/store/3h5qzzfwx50nqs1ykaanfy7zi3bshx4a-libreoffice-7.3.7.2/lib/libreoffice/program/../program/libjdbclo.so(+0x37aa7)[0x7fc22651eaa7]
/nix/store/3h5qzzfwx50nqs1ykaanfy7zi3bshx4a-libreoffice-7.3.7.2/lib/libreoffice/program/libgcc3_uno.so(+0xa016)[0x7fc249a45016]
/nix/store/3h5qzzfwx50nqs1ykaanfy7zi3bshx4a-libreoffice-7.3.7.2/lib/libreoffice/program/libgcc3_uno.so(+0x93c8)[0x7fc249a443c8]
/nix/store/3h5qzzfwx50nqs1ykaanfy7zi3bshx4a-libreoffice-7.3.7.2/lib/libreoffice/program/libgcc3_uno.so(+0x9896)[0x7fc249a44896]
/nix/store/3h5qzzfwx50nqs1ykaanfy7zi3bshx4a-libreoffice-7.3.7.2/lib/libreoffice/program/libuno_cppu.so.3(+0x1d095)[0x7fc2540e9095]
/nix/store/3h5qzzfwx50nqs1ykaanfy7zi3bshx4a-libreoffice-7.3.7.2/lib/libreoffice/program/libaffine_uno_uno.so(+0x2408)[0x7fc24119a408]
/nix/store/3h5qzzfwx50nqs1ykaanfy7zi3bshx4a-libreoffice-7.3.7.2/lib/libreoffice/program/libaffine_uno_uno.so(+0x2443)[0x7fc24119a443]
/nix/store/3h5qzzfwx50nqs1ykaanfy7zi3bshx4a-libreoffice-7.3.7.2/lib/libreoffice/program/libaffine_uno_uno.so(+0x2cba)[0x7fc24119acba]
/nix/store/3h5qzzfwx50nqs1ykaanfy7zi3bshx4a-libreoffice-7.3.7.2/lib/libreoffice/program/libuno_sal.so.3(+0x42db8)[0x7fc2550c5db8]
/nix/store/9xfad3b5z4y00mzmk2wnn4900q0qmxns-glibc-2.35-224/lib/libc.so.6(+0x88e86)[0x7fc254e0fe86]
/nix/store/9xfad3b5z4y00mzmk2wnn4900q0qmxns-glibc-2.35-224/lib/libc.so.6(+0x10fd70)[0x7fc254e96d70]

Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 5.4.228, NixOS, 22.11 (Raccoon), 22.11.20230121.339fc3d`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.11.1`
 - channels(root): `""`
 - channels(r): `""`
 - nixpkgs: `/home/user/src/nixpkgs`

Oh, that's too bad: what else can be wrong after #212556?

could you try with the qt version? I did just that on unstable and it was fine.

Same result with libreoffice-qt on master and nixpkgs-unstable.

release-22.05@0874168639713f produces the same result.
release-21.11@eabc38219184 does not crash. It presents a dialog with an error:

JRE is Defective
LibreOffice requires a Java Runtime Environment (JRE) to perform this task. The selected JRE is defective. Please select another version or install a new JRE and select it under Tools - Options - LibreOffice - Advanced.

This is working for me now with libreoffice-fresh on nixpkgs master@2287bee5ab. I'm not sure what I did to make it work, though. One thing I did that may have helped is to rm -rf ~/.config/libreoffice.
I was straceing libreoffice to see what was going on. I noticed it was reading the wrong JDK path in the Nix store. It should be using the one available at libreoffice-fresh.jdk. But it was reading a different one that didn't contain the SQL classes, as indicated in the error message.
Perhaps there was some configuration pointing it to the wrong JDK? This was my first time using Libreoffice Base, and I don't recall ever doing any JDK configuration in LibreOffice.

authors: peterhoeg squalus wegank


text:
Documentation: Add instructions for updating maintainer's GPG key

Problem
From CONTRIBUTING.md and/or maintainers/README.md it is not clear how to update information about the maintainer's GPG key in the maintainer-list.nix.
Should the update commit be signed with a new key or an old one?
What should the maintainer do if the old key is revoked or lost?
Proposal
Describe in maintainers/README.md the procedure for updating maintainer information for common cases. Including for the GPG key change case.
Checklist

[X] checked latest Nixpkgs manual (source) and latest NixOS manual (source)
[X] checked open documentation issues for possible duplicates
[X] checked open documentation pull requests for possible solutions

@infinisil


text:
Boot broken on Raspberry Pi CM4 when using linux_rpi4 kernel package

Describe the bug
Booting a Raspberry Pi Compute Module 4 with boot.kernelPackages = pkgs.linuxKernel.packages.linux_rpi4 is not possible. Booting freezes at "Starting kernel ..." and does not progress, no other activity (network, any monitor, serial) can be detected.
Steps To Reproduce
Steps to reproduce the behavior:

Flash the CM4 with sd-image 23.05.4930.f741f8a83991-aarch64-linux or 23.11beta509.21af6ad5395b-aarch64-linux
Add boot.kernelPackages = pkgs.linuxKernel.packages.linux_rpi4 to configuration.
nixos-rebuild and reboot

Expected behavior
Boot should progress to login screen.
Additional context
A custom carrier board is being used from Seeed Studio for their EdgeBox RPI-200. Behaviour is reproducible on a standard CM4 IO board though
Notify maintainers
@TredwellGit
@Ma27
@NeQuissimus
@alyssais
@thoughtpolice
Metadata
(This is running WITHOUT the kernelPackage as its not possible to boot with it)
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"aarch64-linux"`
 - host os: `Linux 6.1.63, NixOS, 23.11 (Tapir), 23.11beta509.21af6ad5395b`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixos-23.11beta509.21af6ad5395b"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Priorities
Add a :+1: reaction to issues you find important.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/pi4-broken-on-23-11-uefi-zfs-root/36375/2

Please see my edits in the bug description.
The root cause is actually loading the bcm2711-rpi-cm4.dtb, not the patched kernel… mainline does not load this dtb, linux_rpi4 does, hence the issue is reproduced only with linux_rpi4.
Could I please have some input on this problem?

I've used linux_rpi4 on a CM4 for more than a year, and never had boot issues. I do have bcm2711-rpi-cm4.dtb in my dtbs folder.
Is your CM4's bootloader EEPROM updated? You might also want to check your firmware partition's config.txt (although the one included with the NixOS SD image has worked for me).

authors: Majiir n-hass nixos-discourse


text:
Build failure: davinci-resolve

Steps To Reproduce
Steps to reproduce the behavior:

build davinci-resolve

Build log
@nix { "action": "setPhase", "phase": "unpackPhase" }
Running phase: unpackPhase
unpacking source archive /nix/store/j215gk383lmzvrcwyp92l0rbs6w5galj-davinci-resolve-src.zip
source root is .
setting SOURCE_DATE_EPOCH to timestamp 1710842831 of file ./DaVinci_Resolve_18.6.6_Linux.run
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: configurePhase
no configure script, doing nothing
@nix { "action": "setPhase", "phase": "buildPhase" }
Running phase: buildPhase
no Makefile or custom buildPhase, doing nothing
@nix { "action": "setPhase", "phase": "installPhase" }
Running phase: installPhase
Uncompress DaVinci_Resolve_18.6.6_Linux.run of type 02 @ offset 193760

Write on output file failed because No space left on device

FATAL ERROR: writer: failed to write file /build/home/.cache/appimage-run/792fae885f94171d1d08999bee6d93afc782ba0fb2cf0627ce3d253dfd62fafd/libs/CanonLUTs/BT2020_CanonLog2-to-BT2020_WideDR_V1.bin
DaVinci_Resolve_18.6.6_Linux.run is now installed in /build/home/.cache/appimage-run/792fae885f94171d1d08999bee6d93afc782ba0fb2cf0627ce3d253dfd62fafd
/build/home/.cache/appimage-run/792fae885f94171d1d08999bee6d93afc782ba0fb2cf0627ce3d253dfd62fafd/installer: error while loading shared libraries: libQt5Widgets.so.5: cannot open shared object file: No such file or directory
Copying '/nix/store/d7bqw4gb6hncjx3rcizw6c0q3kb885fw-davinci-resolve.desktop/share/applications/davinci-resolve.desktop' into '/nix/store/x3wq9ml9bxfl4y42hilw54hfb94986vb-davinci-resolve-18.6.6/share/applications'
@nix { "action": "setPhase", "phase": "fixupPhase" }
Running phase: fixupPhase
shrinking RPATHs of ELF executables and libraries in /nix/store/x3wq9ml9bxfl4y42hilw54hfb94986vb-davinci-resolve-18.6.6
checking for references to /build/ in /nix/store/x3wq9ml9bxfl4y42hilw54hfb94986vb-davinci-resolve-18.6.6...
patching script interpreter paths in /nix/store/x3wq9ml9bxfl4y42hilw54hfb94986vb-davinci-resolve-18.6.6
ln: failed to create symbolic link '/nix/store/x3wq9ml9bxfl4y42hilw54hfb94986vb-davinci-resolve-18.6.6/libs/libcrypt.so.1': No such file or directory
/nix/store/v5lsd029lz5lfhamivbgqyp3zdv94ah2-stdenv-linux/setup: line 131: pop_var_context: head of shell_variables not a function context

Additional context
Add any other context about the problem here.
Notify maintainers
@jshcmpbll @orivej
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.8.5, NixOS, 24.05 (Uakari), 24.05.20240412.cfd6b5f`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - nixpkgs: `/etc/nix/path/nixpkgs`
output here

Add a :+1: reaction to issues you find important.

Uncompress DaVinci_Resolve_18.6.6_Linux.run of type 02 @ offset 193760

Write on output file failed because No space left on device

Uncompress DaVinci_Resolve_18.6.6_Linux.run of type 02 @ offset 193760

Write on output file failed because No space left on device

Where does nix build packages?

In a subdirectory of /tmp, generally

Any way to change that? i couldnt find much on the web

@ilovethensa This comment might help: https://github.com/NixOS/nixpkgs/issues/242091#issuecomment-1633339047
I wish that error was a bit clearer and maybe pointed users in the right direction to increase tmpfs

authors: eclairevoyant ilovethensa jshcmpbll


text:
swi-prolog 6.6.3 on Darwin crashes with Abort trap: 6

This is on MacOS X 10.9 (Mavericks).
My swi-prolog 6.4.1 was working fine, I think
I notice a lot of this sort of build output:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip: can't process non-object and non-archive file: /nix/store/1xy4vrm1nrqjfx8zm0m07drbbakx09q3-swi-prolog-6.6.3/lib/swipl-6.6.3/xpce/prolog/lib/Xserver.pl
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip: can't process non-object and non-archive file: /nix/store/1xy4vrm1nrqjfx8zm0m07drbbakx09q3-swi-prolog-6.6.3/lib/swipl-6.6.3/xpce/README
patching script interpreter paths
/nix/store/1xy4vrm1nrqjfx8zm0m07drbbakx09q3-swi-prolog-6.6.3/lib/swipl-6.6.3/customize/edit: interpreter directive changed from "/bin/sh -f" to "/nix/store/85h1r887x7raf97l1invbm9zg1c1sfxr-bash-4.2-p45/bin/sh -f "
/nix/store/1xy4vrm1nrqjfx8zm0m07drbbakx09q3-swi-prolog-6.6.3/lib/swipl-6.6.3/doc/packages/examples/http/debian-init-script: interpreter directive changed from "/bin/sh" to "/nix/store/85h1r887x7raf97l1invbm9zg1c1sfxr-bash-4.2-p45/bin/sh  "
building path(s) `/nix/store/kf907jfhyyaxzklml5d5kscip2x851j0-user-environment'
created 1523 symlinks in user environment

@kowey can you try again on master? swipl doesn't crash for me, but I also don't know what you were doing when it crashed :)

No response for over a year, closing

authors: gridaphobe joachifm kowey


text:
rsyslog not working as expected

Issue description
I've enabled rsyslog on a server but I don't see any files being generated under /var/log from rsyslog. I would expect to see some output by simply enabling the service.
If I'm missing a step I would appreciate knowing what.
Steps to reproduce
Add services.rsyslogd.enable = true; to your configuration.
Technical details
Please run nix-shell -p nix-info --run "nix-info -m" and paste the
results.

system: "x86_64-linux"
host os: Linux 4.14.70, NixOS, 18.09beta408.b853e73d528 (Jellyfish)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.1.1
channels(root): "nixos-18.09pre148742.945a24db1ba"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Well after digging some more I found a great article on the Arch wiki.
Needed to add ForwardToSyslog=yes to journald.conf to get this working. I'll make a PR for this.
https://wiki.archlinux.org/index.php/rsyslog