text:
oxipng: 6.0.0 -> 6.0.1

Description of changes
https://github.com/shssoichiro/oxipng/releases/tag/v6.0.1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 190148 run on x86_64-linux 1

3 packages built:

discourse
discourseAllPlugins
oxipng

source: gharchive/pull-request

repo: NixOS/nixpkgs

license: MIT

license_type: permissive

license_source: github-api


text:
check-meta.nix: fix checkMetaRecursively option

In specific cases, combining the checkMeta and checkMetaRecursively config options would result in error: infinite recursion encountered
To reproduce and confirm the fix:
nix eval --impure --expr 'with import <nixpkgs> { config = { checkMetaRecursively = true; checkMeta = true; }; }; libsysprof-capture.meta'

fixes #193296
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Cleaned up this fix thanks to @piegamesde's suggestion - this just makes available an unchecked/extra meta key handled like any other now.

Nevermind - removing it entirely doesn't work because I didn't realise that it already checks for extraneous attrs - changed to unspecified instead

Do we also want to remove checkMetaRecursively in this PR?

No, actually removing the option (and presumably making it the default behaviour) is a whole other set of changes/discussion/benchmarks/etc. that's out of scope for this fix for the infinite recursion in the type check.

authors: arcnmx piegamesde


text:
datree: 1.6.42 -> 1.6.48

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/datreeio/datree/releases.
meta.description for datree is: "CLI tool to ensure K8s manifests and Helm charts follow best practices as well as your organization’s policies"
meta.homepage for datree is: "https://datree.io/"
meta.changelog for datree is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.6.46 with grep in /nix/store/mr1sm3d4d13szgdzxk9hiyavl4lwdii8-datree-1.6.46
found 1.6.46 in filename of file in /nix/store/mr1sm3d4d13szgdzxk9hiyavl4lwdii8-datree-1.6.46

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
datree

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/mr1sm3d4d13szgdzxk9hiyavl4lwdii8-datree-1.6.46 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A datree https://github.com/r-ryantm/nixpkgs/archive/ca3b31d81ef572425ef4f30162cf6c373bb3ac05.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/mr1sm3d4d13szgdzxk9hiyavl4lwdii8-datree-1.6.46
ls -la /nix/store/mr1sm3d4d13szgdzxk9hiyavl4lwdii8-datree-1.6.46/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

datree

Maintainer pings
cc @jceb for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/datreeio/datree/releases.
meta.description for datree is: "CLI tool to ensure K8s manifests and Helm charts follow best practices as well as your organization’s policies"
meta.homepage for datree is: "https://datree.io/"
meta.changelog for datree is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.6.48 with grep in /nix/store/98l4an13rq754n0k08z0d4mbiw4gakmf-datree-1.6.48
found 1.6.48 in filename of file in /nix/store/98l4an13rq754n0k08z0d4mbiw4gakmf-datree-1.6.48

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
datree

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/98l4an13rq754n0k08z0d4mbiw4gakmf-datree-1.6.48 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A datree https://github.com/r-ryantm/nixpkgs/archive/8cd7d737896ddb1333f00bf7ce172ff1f767554d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/98l4an13rq754n0k08z0d4mbiw4gakmf-datree-1.6.48
ls -la /nix/store/98l4an13rq754n0k08z0d4mbiw4gakmf-datree-1.6.48/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

datree

Maintainer pings
cc @jceb for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/datreeio/datree/releases.
meta.description for datree is: "CLI tool to ensure K8s manifests and Helm charts follow best practices as well as your organization’s policies"
meta.homepage for datree is: "https://datree.io/"
meta.changelog for datree is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.7.1 with grep in /nix/store/1n195sd88rkf97abl2aabm4kknm9cja0-datree-1.7.1
found 1.7.1 in filename of file in /nix/store/1n195sd88rkf97abl2aabm4kknm9cja0-datree-1.7.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
datree

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/1n195sd88rkf97abl2aabm4kknm9cja0-datree-1.7.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A datree https://github.com/r-ryantm/nixpkgs/archive/4bfe6aee1f05741459f57cf1eaf8c8095bfeb870.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/1n195sd88rkf97abl2aabm4kknm9cja0-datree-1.7.1
ls -la /nix/store/1n195sd88rkf97abl2aabm4kknm9cja0-datree-1.7.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

datree

Maintainer pings
cc @jceb for testing.

Will be handled in #200601.

authors: azahi r-ryantm


text:
[22.11] jetbrains-jdk: add JCEF support

Description of changes
Backport of #196738, with @GenericNerdyUsername's patch. Anyone know how to wire this into IDEA to test it properly on 22.11?
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@niknetniko This would be really useful to have.

@niknetniko This would be really useful to have.

I'm not entirely sure why I was pinged here, as I had no part in creating the original patch, and I am not a maintainer for Intellij, just a user. Perhaps you'll have better luck in finding reviewers/someone who can merge by posting in https://discourse.nixos.org/t/prs-ready-for-review/3032?
Anyway, I tried reviewing locally: Goland could not be built, but I am unsure if this was the case already or not (I don't use 22.11 myself). The last log lines were:
/nix/store/zp8vq02cd40x1r1c7r69hizpb7m8rlzz-goland-2022.2.4/goland/plugins/remote-dev-server/bin/launcher.sh: interpreter directive changed from "#!/bin/sh" to "/nix/store/96ky1zdkpq871h2d>
/nix/store/zp8vq02cd40x1r1c7r69hizpb7m8rlzz-goland-2022.2.4/goland/bin/remote-dev-server.sh: interpreter directive changed from "#!/bin/sh" to "/nix/store/96ky1zdkpq871h2dlk198fz0zvklr1dr->
...
/nix/store/zp8vq02cd40x1r1c7r69hizpb7m8rlzz-goland-2022.2.4/goland/bin/format.sh: interpreter directive changed from "#!/bin/sh" to "/nix/store/96ky1zdkpq871h2dlk198fz0zvklr1dr-bash-5.1-p1>
/nix/store/zp8vq02cd40x1r1c7r69hizpb7m8rlzz-goland-2022.2.4/goland/bin/inspect.sh: interpreter directive changed from "#!/bin/sh" to "/nix/store/96ky1zdkpq871h2dlk198fz0zvklr1dr-bash-5.1-p>
checking for references to /build/ in /nix/store/zp8vq02cd40x1r1c7r69hizpb7m8rlzz-goland-2022.2.4...
patchelf: cannot find section '.dynamic'. The input file is most likely statically linked
patchelf: cannot find section '.dynamic'. The input file is most likely statically linked
patchelf: cannot find section '.dynamic'. The input file is most likely statically linked
patchelf: getting info about '/nix/store/zp8vq02cd40x1r1c7r69hizpb7m8rlzz-goland-2022.2.4/goland/plugins/go-plugin/lib/dlv/linux/dlv': No such file or directory

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1911

I'm not entirely sure why I was pinged here, as I had no part in creating the original patch, and I am not a maintainer for Intellij, just a user.

I pinged you because you were the reviewer of the original PR.

Perhaps you'll have better luck in finding reviewers/someone who can merge by posting in https://discourse.nixos.org/t/prs-ready-for-review/3032?

Thanks for the tip! Posted there.

This is redundant, as 23.05 is out and has this change.

authors: l0b0 niknetniko nixos-discourse


text:
Update tmuxp to 1.23.0

tmuxp 1.12.0 depends on a libtmux where you can import which from the library. This has been changed in libtmux, and we now need to use shutil.which to avoid the error:
ImportError: cannot import name 'which' from 'libtmux.common'
Updating the package fixes this issue.
Description of changes

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Please follow the contributing guide when naming your commits.

Commit says 1.12.0 but diff says 1.12.1

Yes, I messed that one up in the commit message. Nice catch :)


text:
kime: 2.5.6 -> 3.0.2

Description of changes
Update kime to 3.0.2. The change is based on https://github.com/NixOS/nixpkgs/pull/202871.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[x] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

had a deeper look at changes to kime, and it looks like removing the yaml format as you did was correct! many apologies. sweat
kime 3 uses custom yaml tags, which aren't supported at all by the current pkgs.format.yaml implementation. so your initial commit (a1865a6) looks like the best solution after all. (rfc42 won't save us here, yaml merging tools also don't usually like the tags, so extraConfig really seems to be the only stable option)

No need to apologize! I was not aware of it too.


text:
todoman: skip flaky test

Description of changes

The icalendar dependency of todoman changed how it serializes datetimes, which broke one of its tests (but didn't break any functionality). todoman updated the test back in November but hasn't pushed a new release yet, so figure it's worth skipping the broken test for now.
Things done

Built on platform(s)

[x] x86_64-linux  - nix-shell -I nixpkgs=. -p todoman works
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

diff LGTM, the commit message should be todoman: skip flaky test just as the PR title, and you can provide links to upstream issues or additional contexts in the comments and commit message.

I squashed the commits on my branch into one w/ the title and message from this PR, but don't have the ability to merge the PR. @NickCao are you able to help with that?

Thanks :pray:

authors: NickCao johnjameswhitman


text:
python311Packages.pygame: marked broken for python >3.11

python311Packages.pygame: mark broken for python >3.11

src_c/pypm.c:209:12: fatal error: longintrepr.h: No such file or directory

It is already broken in master.
python310Packages.pygame builds fine. Seems some issue specific to 3.11. (But don't ask me!)

Logs: https://termbin.com/l71yq
Only marking broken to reduce false positives in downstream builds.

Result of nixpkgs-review pr 218680 run on x86_64-linux 1

Result of nixpkgs-review pr 218680 run on x86_64-linux 1

Ok, same result. I'm not sure what is the difference.
From what I understand, the package won't build because it is broken (for whatever reason). So marking broken does make sense.

@wegank Thanks!


text:
elisp-packages/manual-packages.nix: use self-scoped callPackage

Description of changes
Hey @AndersonTorres! I was just about to submit a PR for lsp-bridge and I noticed that #219698 breaks the manual emacs packages. It looks like we should be using the self-scoped callPackage for them instead.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 219982 run on x86_64-linux 1

1 package marked as broken and skipped:

emacsPackages.perl-completion

43 packages built:

emacsPackages.agda-input
emacsPackages.agda2-mode
emacsPackages.color-theme-solarized
emacsPackages.control-lock
emacsPackages.ebuild-mode
emacsPackages.ghc-mod (emacsPackages.elisp-ffi)
emacsPackages.ement
emacsPackages.ess-R-object-popup
emacsPackages.evil-markdown
emacsPackages.evil-textobj-tree-sitter
emacsPackages.evil-tree-edit
emacsPackages.font-lock-plus
emacsPackages.git-undo
emacsPackages.haskell-unicode-input-method
emacsPackages.header-file-mode
emacsPackages.helm-tree-sitter
emacsPackages.helm-words
emacsPackages.idris2-mode
emacsPackages.isearch-plus
emacsPackages.isearch-prop
emacsPackages.jam-mode
emacsPackages.llvm-mode
emacsPackages.matrix-client
emacsPackages.ott-mode
emacsPackages.pod-mode
emacsPackages.power-mode
emacsPackages.prisma-mode
emacsPackages.pygn-mode
emacsPackages.rect-mark
emacsPackages.sunrise-commander
emacsPackages.sv-kalender
emacsPackages.symex
emacsPackages.tree-edit
emacsPackages.tree-sitter
emacsPackages.tree-sitter-ess-r
emacsPackages.tree-sitter-indent
emacsPackages.tree-sitter-ispell
emacsPackages.tree-sitter-langs
emacsPackages.tsc
emacsPackages.urweb-mode
emacsPackages.voicemacs
emacsPackages.yes-no
emacsPackages.youtube-dl

Waiting ofborg.

authors: AndersonTorres kira-bruneau


text:
mindustry-wayland: set SDL environment variables

SDL_VIDEODRIVER=wayland seems to be a requirement for GLEW to initialize when using glew-egl.
SDL_VIDEO_WAYLAND_WMCLASS associates the application with the .desktop file (in GNOME Shell, at least, if not other Wayland desktops).
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@chkno @fgaz @TheKostins Any feedback on this?


text:
terraform: setup completion only

Description of changes
Use code from the cli library used by Terraform to setup completions.
The default approach depends on mutability.
This time without the refactoring trojan horse.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 224008 run on x86_64-linux 1

1 package failed to build:

coder

2 packages built:

terraform
terraform_plugins_test

Apart from the refactoring how is this different from #223926?

So far, that part is the same.

@lucasew Which of bash/fish/zsh have you tested and on what platforms?

@lucasew Which of bash/fish/zsh have you tested and on what platforms?

Bash on linux
BTW I was able to succed by running these commands before the complete -C thing
autoload -Uz compinit bashcompinit
compinit
bashcompinit

If we're going to add this stuff to the package it really needs to work out of the box.

If we're going to add this stuff to the package it really needs to work out of the box.

Ok then, I was actually thinking in the case that many completions would call this exact initialization logic.
A shell taking many seconds to boot is not very cool.

Result of nixpkgs-review pr 224008 run on x86_64-linux 1

1 package failed to build:

coder

2 packages built:

terraform
terraform_plugins_test

Looks like the completion lib hardcodes paths that it installs to, could we patch the paths to $PWD and then install them?

Looks like the completion lib hardcodes paths that it installs to, could we patch the paths to $PWD and then install them?

It's possible. But the lib basically just generates a reference to the binary.
And upstream is studying to migrate to another completion library because that seems abandoned.

Zsh still doesn't work for me, it is in fpath but it doesn't work.
Sourcing the file seems to work and matches with how it works in terraform, writing to zshrc.
Not sure if we're going to be able to get it to work as a normal, installed completion.
I don't want to merge something that doesn't work so maybe just have bash completion and drop the rest?

Result of nixpkgs-review pr 224008 run on x86_64-linux 1

1 package failed to build:

coder

2 packages built:

terraform
terraform_plugins_test

fish and bash likely work, too, you just mixed the variables up in the previous patch https://github.com/NixOS/nixpkgs/pull/223926/files#r1154208291

fish and bash likely work, too, you just mixed the variables up in the previous PR https://github.com/NixOS/nixpkgs/pull/223926/files#r1154208291

Fish is working even without this PR (no idea why or how)
ZSH is broken with the copy and adapt approach (no idea why)
Bash is my daily driver and started working with this PR, just don't know why it doesn't work with nix-shell, but nixpkgs-review recognizes it properly.

Only for linking sake
#223926 #223973

authors: SuperSandro2000 lucasew zowoq


text:
python310Packages.siobrultech-protocols: 0.7.0 -> 0.9.0

Description of changes
Diff: https://github.com/sdwilsh/siobrultech-protocols/compare/refs/tags/v0.7.0...v0.9.0
Changelog: https://github.com/sdwilsh/siobrultech-protocols/releases/tag/v0.8.0
https://github.com/sdwilsh/siobrultech-protocols/releases/tag/v0.9.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 225959 run on x86_64-linux 1

9 packages built:

home-assistant-component-tests.greeneye_monitor
python310Packages.greeneye-monitor
python310Packages.greeneye-monitor.dist
python310Packages.siobrultech-protocols
python310Packages.siobrultech-protocols.dist
python311Packages.greeneye-monitor
python311Packages.greeneye-monitor.dist
python311Packages.siobrultech-protocols
python311Packages.siobrultech-protocols.dist

authors: dotlambda fabaff


text:
wyoming-piper: init at 0.0.3, wyoming-faster-whisper: ini at 0.0.3

Wyoming Server for Piper, a fast local neural TTS system.
Wyoming Server for faster-whisper, a reimplementation of OpenAI's Whisper model using CTranslate2.

TODO:

ctranslate2
faster-whisper

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Confirming that after configuring the wyoming integration for piper and whisper, stt works. tts fails on "No SGEMM backend on CPU" but that's on me.

RuntimeError: No SGEMM backend on CPU

I think that's because I built ctranslate without a usable backend.
https://opennmt.net/CTranslate2/installation.html#build-options

ctranslate2 now also builds on x86_64-darwin :clown_face: Not sure who even cares, but was easy enough to achieve.

authors: ibizaman mweinelt


text:
nsync: 1.25.0 -> 1.26.0

Description of changes
https://github.com/google/nsync/releases/tag/1.26.0
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2392

authors: Luflosi nixos-discourse


text:
pipewire: 0.3.71 -> 0.3.72

Diff: https://gitlab.freedesktop.org/pipewire/pipewire/-/compare/0.3.71...0.3.72
Description of changes
Now with 1394% more FireWire.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

What made you realize that firewire support was missing? Or did some one upstream add it in the new version?

It was added in this release upstream.

Huh, I was sure we had that. Oh well.

hm build failed for me locally because of a timeout:
post-installation fixup
Moving /nix/store/v09hbczv5rs5zjrca0dmd0bny0gb9w22-libjxl-0.8.2/lib/pkgconfig to /nix/store/0582pv9k725jwy7pbmn4bbrbnl9hvp8d-libjxl-0.8.2-dev/lib/pkgconfig
[236/240] Linking target tests/websocket-test
Patching '/nix/store/0582pv9k725jwy7pbmn4bbrbnl9hvp8d-libjxl-0.8.2-dev/lib/pkgconfig/libjxl.pc' includedir to output /nix/store/0582pv9k725jwy7pbmn4bbrbnl9hvp8d-libjxl-0.8.2-dev
Patching '/nix/store/0582pv9k725jwy7pbmn4bbrbnl9hvp8d-libjxl-0.8.2-dev/lib/pkgconfig/libjxl_threads.pc' includedir to output /nix/store/0582pv9k725jwy7pbmn4bbrbnl9hvp8d-libjxl-0.8.2-dev
[205/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-header-names.c.o
shrinking RPATHs of ELF executables and libraries in /nix/store/v09hbczv5rs5zjrca0dmd0bny0gb9w22-libjxl-0.8.2
shrinking /nix/store/v09hbczv5rs5zjrca0dmd0bny0gb9w22-libjxl-0.8.2/bin/djxl
shrinking /nix/store/v09hbczv5rs5zjrca0dmd0bny0gb9w22-libjxl-0.8.2/bin/jxlinfo
shrinking /nix/store/v09hbczv5rs5zjrca0dmd0bny0gb9w22-libjxl-0.8.2/bin/benchmark_xl
[206/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-client-input-stream.c.o
[237/240] Generating libsoup/Soup-2.4.typelib with a custom command
shrinking /nix/store/v09hbczv5rs5zjrca0dmd0bny0gb9w22-libjxl-0.8.2/bin/cjxl
shrinking /nix/store/v09hbczv5rs5zjrca0dmd0bny0gb9w22-libjxl-0.8.2/bin/cjpeg_hdr
[ 48%] Building C object src/CMakeFiles/libcmark.dir/html.c.o
shrinking /nix/store/v09hbczv5rs5zjrca0dmd0bny0gb9w22-libjxl-0.8.2/lib/libjxl_threads.so.0.8.2
[207/321] Compiling C object libsoup/libsoup-3.0-static.a.p/websocket_soup-websocket-connection.c.o
shrinking /nix/store/v09hbczv5rs5zjrca0dmd0bny0gb9w22-libjxl-0.8.2/lib/libjxl.so.0.8.2
[208/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-http2-utils.c.o
[209/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-date-utils.c.o
checking for references to /build/ in /nix/store/v09hbczv5rs5zjrca0dmd0bny0gb9w22-libjxl-0.8.2...
patching script interpreter paths in /nix/store/v09hbczv5rs5zjrca0dmd0bny0gb9w22-libjxl-0.8.2
stripping (with command strip and flags -S -p) in  /nix/store/v09hbczv5rs5zjrca0dmd0bny0gb9w22-libjxl-0.8.2/lib /nix/store/v09hbczv5rs5zjrca0dmd0bny0gb9w22-libjxl-0.8.2/bin
[ 51%] Building C object src/CMakeFiles/libcmark.dir/commonmark.c.o
[210/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-init.c.o
[211/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-connection-manager.c.o
[212/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-form.c.o
[56/154] Compiling C object src/libqmi-glib/libqmi-glib-compat.a.p/qmi-compat.c.o
[57/154] Linking static target src/libqmi-glib/libqmi-glib-compat.a
[58/301] Compiling C++ object src/libharfbuzz.so.0.60730.0.p/hb-ft.cc.o
[238/240] Generating libsoup/libsoup-2.4.vapi with a custom command
[213/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-logger-input-stream.c.o
[214/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-io-stream.c.o
[58/154] Compiling C object src/libqmi-glib/libqmi-glib.so.5.9.0.p/qmi-endpoint.c.o
[215/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-connection.c.o
[ 55%] Building C object src/CMakeFiles/libcmark.dir/latex.c.o
shrinking RPATHs of ELF executables and libraries in /nix/store/0582pv9k725jwy7pbmn4bbrbnl9hvp8d-libjxl-0.8.2-dev
[217/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-method.c.o
Summary of Failures:
checking for references to /build/ in /nix/store/0582pv9k725jwy7pbmn4bbrbnl9hvp8d-libjxl-0.8.2-dev...
[218/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-headers.c.o
patching script interpreter paths in /nix/store/0582pv9k725jwy7pbmn4bbrbnl9hvp8d-libjxl-0.8.2-dev
stripping (with command strip and flags -S -p) in  /nix/store/0582pv9k725jwy7pbmn4bbrbnl9hvp8d-libjxl-0.8.2-dev/lib
[59/154] Compiling C object src/libqmi-glib/libqmi-glib.so.5.9.0.p/qmi-device.c.o
[219/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-message-headers.c.o
[220/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-logger.c.o
[60/154] Compiling C object src/libqmi-glib/libqmi-glib.so.5.9.0.p/qmi-enums-dms.c.o
building '/nix/store/ianq58bff18xbr40b87j1g12qx19dymg-python3.10-pygobject-3.44.1.drv'...
[59/301] Compiling C++ object src/libharfbuzz.so.0.60730.0.p/hb-static.cc.o
[221/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-message-queue-item.c.o
[222/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-misc.c.o
[223/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-socket-properties.c.o
[224/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-session-feature.c.o
[225/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-multipart-input-stream.c.o
[226/321] Compiling C object libsoup/libsoup-3.0-static.a.p/content-decoder_soup-brotli-decompressor.c.o
[227/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-uri-utils.c.o
[228/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-version.c.o
[229/321] Compiling C object libsoup/libsoup-3.0-static.a.p/soup-status.c.o
[ 59%] Building C object src/CMakeFiles/libcmark.dir/houdini_href_e.c.o
[ 62%] Building C object src/CMakeFiles/libcmark.dir/houdini_html_e.c.o
[ 66%] Building C object src/CMakeFiles/libcmark.dir/houdini_html_u.c.o
[ 70%] Building C object src/CMakeFiles/libcmark.dir/cmark_ctype.c.o
[61/154] Compiling C object src/libqmi-glib/libqmi-glib.so.5.9.0.p/qmi-endpoint-qmux.c.o
[62/154] Compiling C object src/libqmi-glib/libqmi-glib.so.5.9.0.p/qmi-enums-nas.c.o
[63/154] Compiling C object src/libqmi-glib/libqmi-glib.so.5.9.0.p/qmi-enums-wds.c.o
[64/154] Compiling C object src/libqmi-glib/libqmi-glib.so.5.9.0.p/qmi-helpers.c.o
libwacom:all / pytest time out (After 30 seconds)                        29/30s
7/7 libwacom:all / pytest                               TIMEOUT        30.31s   killed by signal 15 SIGTERM
>>> MESON_SOURCE_ROOT=/build/source MALLOC_PERTURB_=53 /nix/store/hzv8xjxk35i72jrljvjhl9y5i00vnsqn-python3.10-pytest-7.2.1/bin/pytest /build/source
 ✀
============================= test session starts ==============================
platform linux -- Python 3.10.12, pytest-7.2.1, pluggy-1.0.0
rootdir: /build/source
collected 1869 items

../test/test_data_files.py ............................................. [  2%]
........................................................................ [  6%]
........................................................................ [ 10%]
........................................................................ [ 13%]
........................................................................ [ 17%]
........................................................................ [ 21%]
........................................................................ [ 25%]
........................................................................ [ 29%]
........................................................................ [ 33%]
........................................................................ [ 37%]
........................................................................ [ 40%]
........................................................................ [ 44%]
........................................................................ [ 48%]
........................................................................ [ 52%]
........................................................................ [ 56%]
........................................................................ [ 60%]
........................................................................ [ 64%]
.........................................

7/7 libwacom:all / pytest                        TIMEOUT        30.31s   killed by signal 15 SIGTERM

7/7 libwacom:all / pytest                        TIMEOUT        30.31s   killed by signal 15 SIGTERM

Ok:                 5
Expected Fail:      0
Fail:               0
Unexpected Pass:    0
Skipped:            1
Timeout:            1

Full log written to /build/source/build/meson-logs/testlog.txt
FAILED: meson-internal__test
/nix/store/2fyi668mbivk9syigxh40irfdf65lsnv-meson-1.1.1/bin/meson test --no-rebuild --print-errorlogs
ninja: build stopped: subcommand failed.
error: builder for '/nix/store/9nvjqzwf0fa1l41maisddi6fxsd82ddd-libwacom-2.7.0.drv' failed with exit code 1;
       last 10 log lines:
       > Expected Fail:      0
       > Fail:               0
       > Unexpected Pass:    0
       > Skipped:            1
       > Timeout:            1
       >
       > Full log written to /build/source/build/meson-logs/testlog.txt
       > FAILED: meson-internal__test
       > /nix/store/2fyi668mbivk9syigxh40irfdf65lsnv-meson-1.1.1/bin/meson test --no-rebuild --print-errorlogs
       > ninja: build stopped: subcommand failed.
       For full logs, run 'nix log /nix/store/9nvjqzwf0fa1l41maisddi6fxsd82ddd-libwacom-2.7.0.drv'.
error: 1 dependencies of derivation '/nix/store/gjvh399591iiw6sv28qq8yh9hassq6nz-libinput-1.23.0.drv' failed to build
building '/nix/store/mw4z7fhasq37jxas8lg5mch10jcpk2ma-libaom-3.6.1.drv'...
error: 1 dependencies of derivation '/nix/store/awcgnb0ng8slb80m0crrpz9lp55hzb2l-qtbase-5.15.9.drv' failed to build
error: 1 dependencies of derivation '/nix/store/mh0jk00cnvdz7rx3xzlfmlzvd7arjw27-python3.10-PyQt5-5.15.9.drv' failed to build
error: 1 dependencies of derivation '/nix/store/wqdwchnkfv7plky7rkn29rz0z044q9bw-ffado-2.4.7.drv' failed to build
error (ignored): error: cannot unlink '/tmp/nix-build-libaom-3.6.1.drv-0/source/aom_dsp/x86': Directory not empty
error: 1 dependencies of derivation '/nix/store/c04rjq5jkg6z7r6va2cxpi951xzxsrdr-pipewire-0.3.72.drv' failed to build

any ideas? Might also be my laptop being to slow (i7-8650U and 16gig ram)?


text:
python310Packages.python-lsp-server: 1.7.3 -> 1.7.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.python-lsp-server is: Python implementation of the Language Server Protocol
meta.homepage for python310Packages.python-lsp-server is: https://github.com/python-lsp/python-lsp-server
meta.changelog for python310Packages.python-lsp-server is: https://github.com/python-lsp/python-lsp-server/blob/v1.7.4/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.7.4 with grep in /nix/store/g1g5rzrn4iynnw79sarq5fx77sz2jm91-python3.10-python-lsp-server-1.7.4
found 1.7.4 in filename of file in /nix/store/g1g5rzrn4iynnw79sarq5fx77sz2jm91-python3.10-python-lsp-server-1.7.4

Rebuild report (if merged into master) (click to expand)

21 total rebuild path(s)

21 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.pyls-flake8
python310Packages.pyls-isort
python310Packages.pyls-memestra
python310Packages.pyls-spyder
python310Packages.pylsp-mypy
python310Packages.pylsp-rope
python310Packages.python-lsp-black
python310Packages.python-lsp-ruff
python310Packages.python-lsp-server
python310Packages.spyder
python311Packages.pyls-flake8
python311Packages.pyls-isort
python311Packages.pyls-memestra
python311Packages.pyls-spyder
python311Packages.pylsp-mypy
python311Packages.pylsp-rope
python311Packages.python-lsp-black
python311Packages.python-lsp-ruff
python311Packages.python-lsp-server
python311Packages.spyder
spyder

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/g1g5rzrn4iynnw79sarq5fx77sz2jm91-python3.10-python-lsp-server-1.7.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.python-lsp-server https://github.com/r-ryantm/nixpkgs/archive/62b79368803f82f1435dc099fd0f71559be3530e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/g1g5rzrn4iynnw79sarq5fx77sz2jm91-python3.10-python-lsp-server-1.7.4
ls -la /nix/store/g1g5rzrn4iynnw79sarq5fx77sz2jm91-python3.10-python-lsp-server-1.7.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages failed to build:

spyder (python310Packages.spyder)
python311Packages.spyder

18 packages built:

python310Packages.pyls-flake8
python310Packages.pyls-isort
python310Packages.pyls-memestra
python310Packages.pyls-spyder
python310Packages.pylsp-mypy
python310Packages.pylsp-rope
python310Packages.python-lsp-black
python310Packages.python-lsp-ruff
python310Packages.python-lsp-server
python311Packages.pyls-flake8
python311Packages.pyls-isort
python311Packages.pyls-memestra
python311Packages.pyls-spyder
python311Packages.pylsp-mypy
python311Packages.pylsp-rope
python311Packages.python-lsp-black
python311Packages.python-lsp-ruff
python311Packages.python-lsp-server

Maintainer pings
cc @fabaff for testing.

@ofborg build python310Packages.python-lsp-server python310Packages.python-lsp-server.passthru.tests

authors: r-ryantm wegank


text:
nixos/mbpfan: adjust defaults

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg eval


text:
uptime-kuma: 1.22.1 -> 1.23.0

Description of changes
https://github.com/louislam/uptime-kuma/releases/tag/1.23.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 249840 run on x86_64-linux 1

1 package built:

uptime-kuma

@ofborg test

@ofborg test uptime-kuma

Result of nixpkgs-review pr 249840 run on x86_64-linux 1

1 package built:

uptime-kuma

authors: Frostman JulienMalka


text:
bash: disable bash-malloc everywhere, not just on musl

TIme to time I bump into pathological behaviour of bash memory allocator. Today's example:
$ time { ls /nix/store/ > /dev/null; }
real    0m0,965s user    0m0,876s sys     0m0,087s
$ time { echo /nix/store/* > /dev/null; }
real    2m18,287s user    2m17,946s sys     0m0,125s
$ time { echo /nix/store/* > /dev/null; }
real    0m1,764s user    0m1,712s sys     0m0,048s

Note how initial echo takes alsmot 2 minutes to finish.
Let's rely  on system's allocator instead.
After the change initial run is fast again:
$ time { echo /nix/store/* > /dev/null; }
real    0m1,328s user    0m1,264s sys     0m0,063s

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Should test to see if a system with a hardened malloc is affected by this.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2612

authors: nixos-discourse risicle trofi


text:
s6-linux-init: 1.1.1.0 -> 1.1.1.1

s6-linux-init: 1.1.1.0 -> 1.1.1.1
s6-linux-init: add usage test

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@kampka are you still planning to work on this, it seems there is a merge conflict by now

authors: kampka yu-re-ka


text:
azure-static-sites-client: 1.0.023121 -> 1.0.023911

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 256321 run on aarch64-linux 1

authors: veehaitch wegank


text:
nextcloud: 11.0.2 -> 12.0.0

Motivation for this change
Upgrade to latest stable version
Things done

[y] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[y] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Side note: If you put an 'x' in the brackets instead of a 'y', GitHub will render it with a pretty checkmark.
So
- [x] a done item

becomes

[x] a done item

Applied to master (46e2c1398f5ae44717dd00cd5846e54d02980ae0). Thanks!

authors: bachp bjornfor lverns


text:
kmscon: set strictDeps, fix cross compilation

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[x] riscv64-linux (cross) (depends on https://github.com/NixOS/nixpkgs/pull/270542)
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

Thanks! I will look into it.

authors: NickCao omasanori


text:
proj: 9.3.0 -> 9.3.1

Description of changes
Update PROJ to the latest patch release.
List of changes: https://github.com/OSGeo/PROJ/releases/tag/9.3.1

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 271993 run on x86_64-linux 1

5 packages marked as broken and skipped:

python310Packages.worldengine
python310Packages.worldengine.dist
python311Packages.worldengine
python311Packages.worldengine.dist
t-rex

20 packages failed to build:

python310Packages.bsuite
python310Packages.bsuite.dist
python310Packages.opensfm
python310Packages.opensfm.dist
python310Packages.plotnine
python310Packages.plotnine.dist
python310Packages.python-mapnik
python310Packages.python-mapnik.dist
python310Packages.rlax
python310Packages.rlax.dist
python311Packages.bsuite
python311Packages.bsuite.dist
python311Packages.opensfm
python311Packages.opensfm.dist
python311Packages.plotnine
python311Packages.plotnine.dist
python311Packages.python-mapnik
python311Packages.python-mapnik.dist
python311Packages.rlax
python311Packages.rlax.dist

128 packages built:

apacheHttpdPackages.mod_tile
cloudcompare
entwine
gdal (python311Packages.gdal)
gdalMinimal
gmt
gnudatalanguage
gplates
grass
libLAS
libgeotiff
libgeotiff.dev
librasterlite2
libspatialite
libspatialite.dev
mapcache
mapnik
mapproxy
mapproxy.dist
mapserver
merkaartor
mysql-workbench
octavePackages.mapping
octavePackages.octproj
openorienteering-mapper
osm2pgsql
osmscout-server
paraview
pdal
perl536Packages.Tirex
perl536Packages.Tirex.devdoc
perl538Packages.Tirex
perl538Packages.Tirex.devdoc
postgresql12JitPackages.postgis
postgresql12JitPackages.postgis.doc
postgresql12Packages.postgis
postgresql12Packages.postgis.doc
postgresql13JitPackages.postgis
postgresql13JitPackages.postgis.doc
postgresql13Packages.postgis
postgresql13Packages.postgis.doc
postgresql14JitPackages.postgis
postgresql14JitPackages.postgis.doc
postgresql14Packages.postgis
postgresql14Packages.postgis.doc
postgresqlJitPackages.postgis (postgresql15JitPackages.postgis)
postgresqlJitPackages.postgis.doc (postgresql15JitPackages.postgis.doc)
postgresql15Packages.postgis
postgresql15Packages.postgis.doc
postgresql16JitPackages.postgis
postgresql16JitPackages.postgis.doc
postgresql16Packages.postgis
postgresql16Packages.postgis.doc
proj
proj.dev
python310Packages.basemap
python310Packages.basemap.dist
python310Packages.cartopy
python310Packages.cartopy.dist
python310Packages.django-bootstrap4
python310Packages.django-bootstrap4.dist
python310Packages.fiona
python310Packages.fiona.dist
python310Packages.folium
python310Packages.folium.dist
python310Packages.gdal
python310Packages.geopandas
python310Packages.geopandas.dist
python310Packages.labelbox
python310Packages.labelbox.dist
python310Packages.osmnx
python310Packages.osmnx.dist
python310Packages.owslib
python310Packages.owslib.dist
python310Packages.pygmt
python310Packages.pygmt.dist
python310Packages.pyproj
python310Packages.pyproj.dist
python310Packages.rasterio
python310Packages.rasterio.dist
python310Packages.wktutils
python310Packages.wktutils.dist
python310Packages.wrf-python
python310Packages.wrf-python.dist
python311Packages.basemap
python311Packages.basemap.dist
python311Packages.cartopy
python311Packages.cartopy.dist
python311Packages.django-bootstrap4
python311Packages.django-bootstrap4.dist
python311Packages.fiona
python311Packages.fiona.dist
python311Packages.folium
python311Packages.folium.dist
python311Packages.geopandas
python311Packages.geopandas.dist
python311Packages.labelbox
python311Packages.labelbox.dist
python311Packages.osmnx
python311Packages.osmnx.dist
python311Packages.owslib
python311Packages.owslib.dist
python311Packages.pygmt
python311Packages.pygmt.dist
python311Packages.pyproj
python311Packages.pyproj.dist
python311Packages.rasterio
python311Packages.rasterio.dist
python311Packages.wktutils
python311Packages.wktutils.dist
python311Packages.wrf-python
python311Packages.wrf-python.dist
pytrainer
pytrainer.dist
qgis
qgis-ltr
qmapshack
saga
spatialite_gui
spatialite_tools
sumo
survex
therion
tunnelx
udig
valhalla
vpv
xastir

@NixOS/geospatial , @dotlambda , I think this PR is now good to go. Please review.

GDAL's test_osr_esri_28 test is failing with PROJ 9.3.1.

For now, this test is disabled and it will be fixed in next GDAL release.

@Mindavi , thanks for merging.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/week-in-geospatial-team-11-17-dec-2023/37035/1

authors: imincik nixos-discourse


text:
python311Packages.google-cloud-vision: 3.4.5 -> 3.5.0

Changelog: https://github.com/googleapis/python-vision/blob/v3.5.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 274436 run on x86_64-linux 1

8 packages built:

python310Packages.google-cloud-vision
python310Packages.google-cloud-vision.dist
python310Packages.layoutparser
python310Packages.layoutparser.dist
python311Packages.google-cloud-vision
python311Packages.google-cloud-vision.dist
python311Packages.layoutparser
python311Packages.layoutparser.dist


text:
wallust: add imagemagick dependency

Description of changes
imagemagick is needed for the wal backend.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3245

I think that I mistook the wal backend for the builtins-pywal themes, which are provided by the themes feature. Going to refactor this PR just for adding imagemagick.
But in regards to imagemagick not being optional, there was a PR 3 days ago stating that it is required to use the wal backend. Perhaps the program allowing its usage without imagemagick is a bug?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1372

authors: nixos-discourse onemoresuza


text:
python311Packages.cypari2: fix build

Description of changes
Unfortunately requires downgrading the Cython version for cysignals and fpylll. Sage tests still fail after this, but Sage builds. I am not sure if this is worth merging. I will upgrade Sage as soon as possible to fix the test issues.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build sageWithDoc

@ofborg build sageWithDoc

@ofborg build sageWithDoc

Merged to help with #282301.

@ofborg eval


text:
python311Packages.hishel: 0.0.21 -> 0.0.22

Diff: https://github.com/karpetrosyan/hishel/compare/refs/tags/0.0.21...0.0.22
Changelog: https://github.com/karpetrosyan/hishel/blob/0.0.22/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 285357 run on x86_64-linux 1

2 packages failed to build:

python311Packages.githubkit
python311Packages.githubkit.dist

2 packages built:

python311Packages.hishel
python311Packages.hishel.dist

Result of nixpkgs-review pr 285357 run on x86_64-linux 1

4 packages built:

python311Packages.githubkit
python311Packages.githubkit.dist
python311Packages.hishel
python311Packages.hishel.dist


text:
nixos/mysql: remove fixed timeout and use notify service type

Description of changes
Removes the hard coded 30 second startup timeout in postStart since systemd's TimeoutStartSec is a suitable and more flexible alternative. The 30 second timeout also not long enough for large databases where innodb initialization can often take >1min.
The systemd service type itself is changed to "notify" for MySQL >= 8.0 [1]. This means none of the MySQL/MariaDB versions in nixpkgs use the "simple" service type and therefore don't even need the manual loop/polling for the socket. However, there may be other MySQL implementations added to nixpkgs in the future (MyRocks, etc.) that may be based on MySQL < 8.0 and require the "simple" service type.
[1] https://dev.mysql.com/doc/refman/8.0/en/using-systemd.html
Things done
The mysql test for mysql80 and mariadb both pass. I've confirmed that systemd's TimeoutStartSec setting applies to both the ExecStart and ExecStartPost scripts.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

does anyone here have a database that takes longer than a second to start up that can test this?
this looks fine but it would be really nice if we could practically test this
if not... i guess we merge and rely on logic

@aanderse My synthetic testing method was to add a sleep 30 to the beginning of the ExecStart script to test that the ExecStartPost script is also postponed an additional 30 seconds. Technically, this doesn't test that MySQL itself waits to send the systemd READY=1 status until after the socket is available - just going by upstream docs and observed behavior.
Here's the log of the mysql test with the 30 second delay but without sub-second resolution it's hard to confirm:
Feb 15 08:19:23 mariadb80 mysql-pre-start[861]: 2024-02-15T08:19:23.122910Z 0 [System] [MY-013169] [Server] /nix/store/vwcld5bqs1dg7h2ffcgz8am4vdrxw176-mysql-8.0.36/bin/mysqld (mysqld 8.0.36) initializing of server in progress as process 861
Feb 15 08:19:23 mariadb80 mysql-pre-start[861]: 2024-02-15T08:19:23.155992Z 1 [System] [MY-013576] [InnoDB] InnoDB initialization has started.
Feb 15 08:19:23 mariadb80 mysql-pre-start[861]: 2024-02-15T08:19:23.756727Z 1 [System] [MY-013577] [InnoDB] InnoDB initialization has ended.
Feb 15 08:19:24 mariadb80 mysql-pre-start[861]: 2024-02-15T08:19:24.149674Z 0 [Warning] [MY-013501] [Server] Ignoring --plugin-load[_add] list as the server is running with --initialize(-insecure).
Feb 15 08:19:25 mariadb80 mysql-pre-start[861]: 2024-02-15T08:19:25.123350Z 6 [Warning] [MY-010453] [Server] root@localhost is created with an empty password ! Please consider switching off the --initialize-insecure option.
Feb 15 08:19:27 mariadb80 mysql-start[988]: MySQL delay start...
Feb 15 08:19:57 mariadb80 mysql-start[988]: MySQL delay end...
Feb 15 08:19:57 mariadb80 mysql-start[988]: 2024-02-15T08:19:57.716130Z 0 [System] [MY-010116] [Server] /nix/store/vwcld5bqs1dg7h2ffcgz8am4vdrxw176-mysql-8.0.36/bin/mysqld (mysqld 8.0.36) starting as process 988
Feb 15 08:19:57 mariadb80 mysql-start[988]: 2024-02-15T08:19:57.732427Z 1 [System] [MY-013576] [InnoDB] InnoDB initialization has started.
Feb 15 08:19:58 mariadb80 mysql-start[988]: 2024-02-15T08:19:58.121585Z 1 [System] [MY-013577] [InnoDB] InnoDB initialization has ended.
Feb 15 08:19:58 mariadb80 mysql-start[988]: 2024-02-15T08:19:58.453086Z 0 [Warning] [MY-010068] [Server] CA certificate ca.pem is self signed.
Feb 15 08:19:58 mariadb80 mysql-start[988]: 2024-02-15T08:19:58.454453Z 0 [System] [MY-013602] [Server] Channel mysql_main configured to support TLS. Encrypted connections are now supported for this channel.
Feb 15 08:19:58 mariadb80 mysql-start[988]: 2024-02-15T08:19:58.478320Z 0 [System] [MY-011323] [Server] X Plugin ready for connections. Bind-address: '::' port: 33060, socket: /run/mysqld/mysqlx.sock
Feb 15 08:19:58 mariadb80 mysql-start[988]: 2024-02-15T08:19:58.479943Z 0 [System] [MY-010931] [Server] /nix/store/vwcld5bqs1dg7h2ffcgz8am4vdrxw176-mysql-8.0.36/bin/mysqld: ready for connections. Version: '8.0.36'  socket: '/run/mysqld/mysqld.sock'  port: 3306  Source distribution.
Feb 15 08:19:58 mariadb80 mysql-post-start[1162]: Creating initial database: testdb3

This worked for me on a large database that was not starting before the post start script caused the service to restart.

authors: Nhasty Princemachiavelli aanderse


text:
python312Packages.cle: migrate to pynose

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 299957 run on x86_64-linux 1

10 packages built:

python311Packages.angr
python311Packages.angr.dist
python311Packages.angrcli
python311Packages.angrcli.dist
python311Packages.angrop
python311Packages.angrop.dist
python311Packages.cle
python311Packages.cle.dist
python312Packages.cle
python312Packages.cle.dist


text:
nixos/deconz: delay signalling service readiness until it's actually up

Description of changes
Fixes test flakiness (nix-build -A nixosTests.deconz).

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Rebased to fix grammar: s/readyness/readiness/


text:
python3Packages.pyrad: fix build failing

ZHF: #309482
Description of changes

Failing on ZHF https://hydra.nixos.org/build/258464455
Fix python3Packages.netaddr to use the correct version
Fix use of deleted methods in python312 causing build fail

Things done
2.4 to 2.4-unstable-2023-06-13

Built on platform(s)

[X] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 310187 run on x86_64-linux 1

4 packages built:

python311Packages.pyrad
python311Packages.pyrad.dist
python312Packages.pyrad
python312Packages.pyrad.dist

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3903

Result of nixpkgs-review pr 310187 run on aarch64-linux 1

4 packages built:

python311Packages.pyrad
python311Packages.pyrad.dist
python312Packages.pyrad
python312Packages.pyrad.dist

I've taken the liberty to update pyrad from 2.4 to 2.4-unstable-2023-06-13 as a lot of the patches are solved issues upstream.
https://github.com/pyradius/pyrad/commit/ffe182a44909e8f8278fb3e2ea052ddc097b48b9
https://github.com/pyradius/pyrad/commit/0d5237d6df4d937aab63a82e0a7c4dc18e58ed88

@ofborg build python3Packages.pyrad

tiny nit pick
python3Packages.pyrad: adopt
commit message should not be from your point of view
python3Packages.pyrad: add drawbu to meta.maintainers   or other alternatives

As my commits are signed, I have no idea how to do it. I'll try

all done!

authors: drawbu getchoo kirillrdy nixos-discourse


text:
python3Packages.uxsim: 1.1.1 -> 1.3.0

Description of changes
Updates uxsim to 1.3.0 & fixes python 3.12 build
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 311372 run on x86_64-linux 1

4 packages built:

python311Packages.uxsim
python311Packages.uxsim.dist
python312Packages.uxsim
python312Packages.uxsim.dist

Result of nixpkgs-review pr 311372 run on x86_64-linux 1

4 packages built:

python311Packages.uxsim
python311Packages.uxsim.dist
python312Packages.uxsim
python312Packages.uxsim.dist

authors: pbsds vinnymeller


text:
trivy: 0.51.1 -> 0.51.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/aquasecurity/trivy/releases.
meta.description for trivy is: A simple and comprehensive vulnerability scanner for containers, suitable for CI
meta.homepage for trivy is: https://github.com/aquasecurity/trivy
meta.changelog for trivy is: https://github.com/aquasecurity/trivy/releases/tag/v0.51.2
Updates performed

Golang update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.51.2 with grep in /nix/store/i0s2kq5cn1f8zkh9m7249jiw6x0ydf9y-trivy-0.51.2
found 0.51.2 in filename of file in /nix/store/i0s2kq5cn1f8zkh9m7249jiw6x0ydf9y-trivy-0.51.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

trivy

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/i0s2kq5cn1f8zkh9m7249jiw6x0ydf9y-trivy-0.51.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A trivy https://github.com/r-ryantm/nixpkgs/archive/c83d01249c5b9b8cf8e7f316e6fc81c10c336da9.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/c83d01249c5b9b8cf8e7f316e6fc81c10c336da9#trivy

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/i0s2kq5cn1f8zkh9m7249jiw6x0ydf9y-trivy-0.51.2
ls -la /nix/store/i0s2kq5cn1f8zkh9m7249jiw6x0ydf9y-trivy-0.51.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

trivy

Maintainer pings
cc @fabaff @06kellyjac for testing.

@ofborg eval

authors: cole-h r-ryantm


text:
nomad: 1.7.7 -> 1.8.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/hashicorp/nomad/releases.
meta.description for nomad is: A Distributed, Highly Available, Datacenter-Aware Scheduler
meta.homepage for nomad is: https://www.nomadproject.io/
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 1.8.0 with grep in /nix/store/rhn3kqx3zvfb6zbid77qndnzsv64y8h1-nomad-1.8.0
found 1.8.0 in filename of file in /nix/store/rhn3kqx3zvfb6zbid77qndnzsv64y8h1-nomad-1.8.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

nomad
nomad_1_7

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/rhn3kqx3zvfb6zbid77qndnzsv64y8h1-nomad-1.8.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A nomad https://github.com/r-ryantm/nixpkgs/archive/d375cd3872effd16ab69e70b89bffc3c2ccbc408.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/d375cd3872effd16ab69e70b89bffc3c2ccbc408#nomad

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/rhn3kqx3zvfb6zbid77qndnzsv64y8h1-nomad-1.8.0
ls -la /nix/store/rhn3kqx3zvfb6zbid77qndnzsv64y8h1-nomad-1.8.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

nomad (nomad_1_7)

Maintainer pings
cc @rushmorem @pradeepchhetri @techknowlogick @cottand for testing.

what probably should be done is add # nixpkgs-update: no auto update in the file, OR fix the update script, OR move this line
https://github.com/NixOS/nixpkgs/blob/4f6eb3c339773fc03bab9685a4cda75b661c6581/pkgs/applications/networking/cluster/nomad/default.nix#L55
to aliases.nix (since iirc nixpkgs-update won't update nomad_1_7 past 1.7.x, but nomad as an attrname has no such restriction in its eyes)

authors: eclairevoyant r-ryantm


text:
segger-jlink: 796b -> 796k, segger-jlink-headless: init, plus misc changes

Description of changes

Miscellaneous fixes to segger-jlink. I have added a headless variant of the package that excludes the qt4 bundle, removing the need for adding it to the list of insecure packages. The headless variant is exposed as a toplevel attribute with the -headless suffix.
As for other changes, I've added a changelog link, added myself to maintainers, added an update script and bumped the package version
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Does nrfconnect work with the new segger-jlink-headlessas a dependency? Then I suggest to use that, see https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/by-name/nr/nrfconnect/package.nix#L23 . After this PR is tested and merged, I will also update #214195 .

Does nrfconnect work with the new segger-jlink-headless as a dependency?

I'm not entirely sure tbh, but I think so. It's a suite of tools made for the nordicsemi boards, and while they need jlink to probe the devkits, it would be weird if they embedded usage of segger's gui tools within their own.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4189


text:
jinja-lsp: init at 0.1.81

Description of changes
Adds jinja-lsp from https://github.com/uros-5/jinja-lsp. I've also added myself as a contributor.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thanks for your review! I have made some changes, can you take a look again?


text:
python312Packages.lox: init at 0.12.0

Homepage: https://github.com/BrianPugh/lox
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I gave a try and I got something different, though I don't know which one is best to use.
diff --git a/pkgs/development/python-modules/lox/default.nix b/pkgs/development/python-modules/lox/default.nix
index 02e58f703370..7f81c0cfc5d5 100644
--- a/pkgs/development/python-modules/lox/default.nix
+++ b/pkgs/development/python-modules/lox/default.nix
@@ -3,8 +3,10 @@
   fetchFromGitHub,
   lib,

+  setuptools,
+  setuptools-scm,
   pathos,
-  pip,
+  sphinx_rtd_theme,
   pytestCheckHook,
   pytest-benchmark,
   pytest-mock,
@@ -15,6 +17,7 @@
 buildPythonPackage rec {
   pname = "lox";
   version = "0.12.0";
+  format = "setuptools";

   src = fetchFromGitHub {
     owner = "BrianPugh";
@@ -23,9 +26,15 @@ buildPythonPackage rec {
     hash = "sha256-Iv3ZdfsvFLU6lhlH1n+eQ+KIrXESsnC1S2lVFnKFV08=";
   };

-  propagatedBuildInputs = [ pathos ];
+  build-system = [
+    setuptools
+    setuptools-scm
+  ];

-  buildInputs = [ pip ];
+  dependencies = [
+    pathos
+    sphinx_rtd_theme
+  ];

   checkInputs = [
     pytestCheckHook
--
2.45.2

Could you please rename the PR to: python3Packages.lox: init at 0.12.0 and also make sure there's only one commit in it so that the builds are automatically triggered by the CI ?

As mentioned in the packaging guidelines for Python, the current naming scheme is correct. I have also squashed this down to a single commit.

authors: drupol greg-hellings