text:
New Maven RemoveDuplicateDependencies recipe

For now the recipe can only remove duplicates, but in the future it could maybe also sort dependencies (only by scope since sorting dependencies within a scope may have undesired effects due to Maven's dependency resolution).
Fixes #2381

This is still work in progress. Not sure if it really makes sense to call this thing OrganizeDependencies. Also for sure more tests are required.

Great to see you got started on this one. Some general comments to give you some immediate feedback, before those with more experience can chime in from their timezones.
Naming wise I'd got with something like RemoveDuplicateDependencies; typically recipes are fairly specific to a single use case, which makes it easy to combine them in yaml files or through doAfterVisit/doNext. Specifically in this case we'd like to remove duplicate dependencies after swapping another dependency, but perhaps not sort dependencies at the same time, for a minimal changeset that's easier to review. Sorting can then become a separate recipe, with both perhaps combined in a third best practices (yaml) recipe.
I don't have any experience with Maven recipes yet, but if they are like the visitors we have for Java, you might be able to only implement visitTag; alternating between returning any dependency tags you've not seen, and returning null when seen before. That would also ensure there's not any inadvertent changes to the order of the tags, as you only drop affected tags. Again, not entirely sure returning null would work for Maven recipes, but perhaps it should. :)
Testing wise it might be good to have some isolated tests where there's differences in terms of <scope> or <classifier>, as those could give false positives in terms of duplicates. I'm not saying there's an issue in the current implementation, but it might be good to cover that with tests.
Typically we override the estimated effort on recipes as well; that helps to give a total on the amount of time saved through automation, which is a nice metric to have.
I'm doubting if there's any applicability tests we could add to the recipe; I imagine they could duplicate some of the logic to find duplicated dependencies. Perhaps a very minimal applicability test can check for the presence of dependencies at all, so we can exclude some parent pom.xmls for instance.
Hope this helps & thanks again for picking this up!

Thanks for your elaborate feedback. I will try to take a look at this early next week again.

A few more remarks / questions:

My thinking was to use options like removeDuplicates, sortDependencies, etc. to control the behavior of the recipe. But since you are saying that this would inconsistent with how other recipes are divided up, I will go with RemoveDuplicateDependencies as you propose (and remove the removeDuplicates option)
To me it looks like there should basically for the same reason also be a separate recipe to do the same for managed dependencies, although there I think the pattern is a bit less clear and I also can't really think of a reason when you would only remove duplicates from either the managed or the actual dependencies
Regarding scope and classifier. AFAIK there should only be one dependency per type and classifier. So if there is a second dependency with the same type and classifier (even though scope or version may be different), it should be considered a duplicate
I will take a look at if I see examples of visitTag I can study
Sure, I can add a simple applicability test

@timtebeek Sorry about the many small amendments. From my point of view I am now done with the PR. Please let me know if there is something more that I should change.

No worries at all, glad to see you're working on this. I'm tagging @tkvangorder for review, as he chimed in on slack for this one as well.

I definitely think having a separate recipe to sort dependencies makes sense. We could use this recipe when adding/changing dependencies (in addition to removing them)
And you are correct, we don't have a solid pattern for combining/separating operations on dependencies and managed dependencies. I think it is ok to combine these two concepts for your current recipe.

@tkvangorder Is there anything that still needs changing?
I ran the tests locally and couldn't get them to fail, so I now rebased the commit and pushed it again. If the build fails again in CI, I will take a closer look.

authors: knutwannheden timtebeek tkvangorder


text:
Only the pages that have been "completed" should be marked as done

The original ALIDADE was designed as a simple linear questionnaire. PESIA is longer and users will likely move around and answer it in a non-linear manner. When they do this all the menu items on the left above the last visited page will be marked as done in the tick boxes.
Only the pages that have been "completed" should be marked as done. This could happen when users click the "next page" button at the bottom of the pages.
Is this possible?

This is a bit of a tricky one - the system saves a record for a completed slide whenever the slide is visited.  It doesn't make a distinction between complete and in-progress slides.
I've updated the sidebar to show a check-mark based on whether a slide has been visited or not.  Let me know if that's sufficient or if you'd like to go back to the previous method.

Thanks Dan, do we have a way to link the tick box to a trigger from the save and next button?
--
Sent from Canary (https://canarymail.io)

On Friday, Nov 29, 2019 at 1:54 am, Daniel Ramsay <notifications@github.com (mailto:notifications@github.com)> wrote:
This is a bit of a tricky one - the system saves a record for a completed slide whenever the slide is visited. It doesn't make a distinction between complete and in-progress slides.
I've updated the sidebar to show a check-mark based on whether a slide has been visited or not. Let me know if that's sufficient or if you'd like to go back to the previous method.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (https://github.com/openrightsgroup/alidade/issues/56?email_source=notifications&email_token=AAIDREOCN2NIU2QFF2QBKQDQWBY6TA5CNFSM4JNJRD4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNVNZQ#issuecomment-559634150), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAIDREIDHODO47OEYNX674LQWBY6TANCNFSM4JNJRD4A).

Not at the moment. Navigating away from the page appears to save the contents (even if all the fields are empty), the same as the save &continue button.
I'd be tempted to remove that, so that the page is only saved when the user clicks save.  I think this was discussed in another issue, but I can't remember which one.
On 29 November 2019 10:05:07 GMT, javierruizorg notifications@github.com wrote:

Thanks Dan, do we have a way to link the tick box to a trigger from the
save and next button?>

-->
Sent from Canary (https://canarymail.io)>

On Friday, Nov 29, 2019 at 1:54 am, Daniel Ramsay
<notifications@github.com (mailto:notifications@github.com)> wrote:>

This is a bit of a tricky one - the system saves a record for a
completed slide whenever the slide is visited. It doesn't make a
distinction between complete and in-progress slides.>

I've updated the sidebar to show a check-mark based on whether a
slide has been visited or not. Let me know if that's sufficient or if
you'd like to go back to the previous method.>

—>
You are receiving this because you authored the thread.>
Reply to this email directly, view it on GitHub
(https://github.com/openrightsgroup/alidade/issues/56?email_source=notifications&email_token=AAIDREOCN2NIU2QFF2QBKQDQWBY6TA5CNFSM4JNJRD4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNVNZQ#issuecomment-559634150),
or unsubscribe
(https://github.com/notifications/unsubscribe-auth/AAIDREIDHODO47OEYNX674LQWBY6TANCNFSM4JNJRD4A).>

-- >
You are receiving this because you were assigned.>
Reply to this email directly or view it on GitHub:>
https://github.com/openrightsgroup/alidade/issues/56#issuecomment-559734649

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

I think it’s better to have active save as used can navigate around a a lot and could even override stuff
--
Sent from Canary (https://canarymail.io)

On Friday, Nov 29, 2019 at 11:31 pm, Daniel Ramsay <notifications@github.com (mailto:notifications@github.com)> wrote:
Not at the moment. Navigating away from the page appears to save the contents (even if all the fields are empty), the same as the save &continue button.
I'd be tempted to remove that, so that the page is only saved when the user clicks save. I think this was discussed in another issue, but I can't remember which one.
On 29 November 2019 10:05:07 GMT, javierruizorg notifications@github.com wrote:

Thanks Dan, do we have a way to link the tick box to a trigger from the
save and next button?>

-->
Sent from Canary (https://canarymail.io)>

On Friday, Nov 29, 2019 at 1:54 am, Daniel Ramsay
<notifications@github.com (mailto:notifications@github.com)> wrote:>

This is a bit of a tricky one - the system saves a record for a
completed slide whenever the slide is visited. It doesn't make a
distinction between complete and in-progress slides.>

I've updated the sidebar to show a check-mark based on whether a
slide has been visited or not. Let me know if that's sufficient or if
you'd like to go back to the previous method.>

—>
You are receiving this because you authored the thread.>
Reply to this email directly, view it on GitHub
(https://github.com/openrightsgroup/alidade/issues/56?email_source=notifications&email_token=AAIDREOCN2NIU2QFF2QBKQDQWBY6TA5CNFSM4JNJRD4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFNVNZQ#issuecomment-559634150),
or unsubscribe
(https://github.com/notifications/unsubscribe-auth/AAIDREIDHODO47OEYNX674LQWBY6TANCNFSM4JNJRD4A).>

-- >
You are receiving this because you were assigned.>
Reply to this email directly or view it on GitHub:>
https://github.com/openrightsgroup/alidade/issues/56#issuecomment-559734649

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (https://github.com/openrightsgroup/alidade/issues/56?email_source=notifications&email_token=AAIDREIMDCYIEPJMZFEFLULQWGQ4PA5CNFSM4JNJRD4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFPVCHA#issuecomment-559894812), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAIDREK3EL3Y25Y5Y4LZIT3QWGQ4PANCNFSM4JNJRD4A).

This has been updated.  Slides are only marked as done when an answer is saved using the save & continue button.  The check boxes in the sidebar match this use.

source: gharchive/issue

authors: dantheta javierruizorg

repo: openrightsgroup/alidade

license_type: permissive

license_source: github-api


text:
[VMware/NGC] Backup interface lists same volume in multiple rows

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:
NGC Plugin UI displays same volume multiple times in backup and restore window.

What you expected to happen:
Display volume only once
How to reproduce it (as minimally and precisely as possible):
create mutiple volumes and open backup window popup
Anything else we need to know?:
Environment:

NBP version:v0.7.0
OS (e.g. from /etc/os-release):windows
Kernel (e.g. uname -a):
Install tools:
Others:

Fix delivered in hotpot https://github.com/opensds/opensds/pull/1142

repo: opensds/nbp

license_source: bigquery


text:
Sync viewers containing images with different sizes and scales

Hi,
first of all thanks for the great work!
My use case is a little bit specific: I have some wsi (whole slide images) slides which I want to show one next to each other. I want to make sure that any operation done on one image is reflected to the other one, like zooming and panning. This would seem simple enough but now I have to consider that the images are not always of the same size and scale.
I've found this codepen https://codepen.io/iangilman/pen/BpwBJe in which the images are the same and pan/zoom accordigly, but modifying it a little bit (https://codepen.io/lcl45/pen/PoyJwyM) gives me a strage result (for me at least): what I want to do is to pan the same point between the two images (or zooming). Like, if I pan clicking on the center of the left image I want the right one to pan also from the center of it. You can see the "error" in particular from the start since the two images get aligned on the top side but i want, instead, to be aligned on the center.
In all of this, I want to make also sure that the same pan is applied across images with different scales. Unfortunatly I can't manage to make it work on codepen: what I get for now, is that one image is moving faster than the other across the screen.
What I've done for now is to transform the center of the dragging one in image coordinates, which will then be re-transformed in viewport coordinates of the other image, still not solving the scale issue. I think, however, that a better solution might exist so I'm asking for a solution to this problem.
Thanks a lot!!

I'm just thinking about this now, but it occurs to me what might work best for this scenario would be to lay the images out so that their viewport coordinates match up. For instance, if image A is 2:1 aspect ratio and image B is 1:2 aspect ratio, you could load them in so viewer1 has:
tileSources: {
    x: -1,
    y: -0.5,
    width: 2,
    tileSource: 'a.dzi'
}

... And viewer2 has:
tileSources: {
    x: -0.5,
    y: -1,
    width: 1,
    tileSource: 'b.dzi'
}

This will line up their centers at (0,0) and make them overlap each other as much as possible.

Thanks a lot! I'll give it a try as soon as possible and will let you know how it goes.

Maybe I'm missing something. I'm declaring my openSeadragon instance with the following code
let openSeaDragon = OpenSeadragon({
    element: containerDiv,
    animationTime: 1,
    zoomPerScroll: 1.25,
    showNavigator: true,
    showNavigationControl: false,
    tileSources: {
        height: imageHeight,
        width: imageWidth,
        tileSize: 512,
        getTileUrl: (level, x, y) => tileUrl(apImage, level, x, y),
    },
});

where tileSources.height and tileSource.width are the actual image sizes (that, just for the sake of the example, are 41216 and 104448).
Setting x and y as you did doesn't do anything and the viewport still remains the same.
What am I missing?

Yeah, the tileSources interface can be pretty confusing! Here's some more info on it:
https://openseadragon.github.io/examples/multi-image/
In your case, this should work:
let openSeaDragon = OpenSeadragon({
    element: containerDiv,
    animationTime: 1,
    zoomPerScroll: 1.25,
    showNavigator: true,
    showNavigationControl: false,
    tileSources: {
        tileSource: {
            height: imageHeight,
            width: imageWidth,
            tileSize: 512,
            getTileUrl: (level, x, y) => tileUrl(apImage, level, x, y),
        },
        x: -imageWidth / 2,
        y: -imageHeight / 2,
        width: imageWidth
        // We don't specify height here because OSD uses the aspect ratio from the tileSource.
    },
});

The entire object put in the tileSources is something we don't have a good name for but maybe you could call it a "open specification". It includes the actual tileSource but also some additional positioning information. Note that the width and height you pass into the tileSource is in image coordinates (the actual pixels of the image), whereas the x, y, and width you put in the open specification are in viewport coordinates, which are arbitrary. You can, as in this case, use the same coordinates for each, but you might not want to; for instance, if you have two images with different sizes, but the same aspect ratio, you might want them to overlap each other exactly, rather than being locked to their original sizes.
More about coordinate systems here:
https://openseadragon.github.io/examples/viewport-coordinates/
I hope all that makes sense!

@lcl45 Great! This seems like an elegant solution. Thank you for sharing your zoom level code :)

repo: openseadragon/openseadragon


text:
[Backport 2.x] Search latency tracking - Coordinator node

Description
Changing version guards to 2.11
Backport https://github.com/opensearch-project/OpenSearch/pull/8386
Related Issues
Resolves #[Issue number to be closed when this PR is merged]

Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@msfroh Need help with this. Will update main branch too with 2.11

@sgup432 Can you prepare the PR for main with the updated version checks?
That way we can merge it as soon as possible after this one.

@msfroh PR on main branch - https://github.com/opensearch-project/OpenSearch/pull/10280/files

source: gharchive/pull-request

repo: opensearch-project/OpenSearch


text:
Added jackson dependency to server

Signed-off-by: Ryan Bogan rbogan@amazon.com
Description
In order for extensions to be read, the jackson dependency must be included in the server build.gradle file.  This PR adds the license, notice, and SHA files necessary to accomplish this.
Note: Although the jackson files for plugins and modules are being deleted with this PR, they still have access under server and no functionality will be changed for them.
Check List

[X] New functionality includes testing.

[X] All tests pass

[X] New functionality has been documented.

[X] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff
[X] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ryanbogan this is interesting, it seems like  :libs:opensearch-x-content brings these dependencies to the server already?
+--- project :libs:opensearch-x-content
|    +--- project :libs:opensearch-core
|    +--- org.yaml:snakeyaml:1.32
|    +--- com.fasterxml.jackson.core:jackson-core:2.14.1
|    +--- com.fasterxml.jackson.dataformat:jackson-dataformat-smile:2.14.1
|    +--- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.14.1
|    \--- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.14.1

@ryanbogan this is interesting, it seems like :libs:opensearch-x-content brings these dependencies to the server already?
+--- project :libs:opensearch-x-content
|    +--- project :libs:opensearch-core
|    +--- org.yaml:snakeyaml:1.32
|    +--- com.fasterxml.jackson.core:jackson-core:2.14.1
|    +--- com.fasterxml.jackson.dataformat:jackson-dataformat-smile:2.14.1
|    +--- com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.14.1
|    \--- com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.14.1

Without the dependency in the server build.gradle file, import errors are thrown on compilation for every object in the jackson library.

Assuming you can get this to 🟢 I don't see any reasons not to merge this.

Can you reproduce the failure locally?

> Task :plugins:discovery-ec2:qa:amazon-ec2:yamlRestTestContainerCredentials FAILED

=== Standard output of node `node{:plugins:discovery-ec2:qa:amazon-ec2:yamlRestTestContainerCredentials-0}` ===

»    ↓ errors and warnings from /var/jenkins/workspace/gradle-check/search/plugins/discovery-ec2/qa/amazon-ec2/build/testclusters/yamlRestTestContainerCredentials-0/logs/opensearch.stdout.log ↓
» ERROR][o.o.b.OpenSearchUncaughtExceptionHandler] [yamlRestTestContainerCredentials-0] fatal error in thread [main], exiting
»  java.lang.ExceptionInInitializerError: null
»  	at com.amazonaws.util.VersionInfoUtils.userAgent(VersionInfoUtils.java:142) ~[?:?]
»  	at com.amazonaws.util.VersionInfoUtils.initializeUserAgent(VersionInfoUtils.java:137) ~[?:?]
»  	at com.amazonaws.util.VersionInfoUtils.getUserAgent(VersionInfoUtils.java:100) ~[?:?]
»  	at com.amazonaws.ClientConfiguration.<clinit>(ClientConfiguration.java:80) ~[?:?]

Can you reproduce the failure locally?

Yes I can reproduce it locally.

@ryanbogan will need a manual backport to come to 2.x

authors: dblock reta ryanbogan


text:
Added TransportActions support and removed LocalNodeResponse for extensions

Description
This PR merges the fourth batch of feature/extensions into main and will then be backported to 2.x.  It adds TransportActions support and removes LocalNodeResponse for extensions
Note: This PR must be merged after https://github.com/opensearch-project/OpenSearch/pull/5597/ as it contains all of the changes from that PR.
Issues Resolved
Issue with links to PR's included in this merge: https://github.com/opensearch-project/OpenSearch/issues/5273
Meta issue for entire feature/extensions merge: https://github.com/opensearch-project/OpenSearch/issues/5263
Check List

[X] New functionality includes testing.

[X] All tests pass

[X] New functionality has been documented.

[X] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff
[X] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #5615 (0e12953) into main (306b199) will increase coverage by 0.15%.
The diff coverage is 73.80%.

:exclamation: Current head 0e12953 differs from pull request most recent head f974304. Consider uploading reports for the commit f974304 to get more accurate results

@@             Coverage Diff              @@
##               main    #5615      +/-   ##
============================================
+ Coverage     70.84%   70.99%   +0.15%
- Complexity    58296    58541     +245
============================================
  Files          4741     4757      +16
  Lines        278541   279026     +485
  Branches      40268    40309      +41
============================================
+ Hits         197322   198105     +783
+ Misses        65068    64764     -304
- Partials      16151    16157       +6

Impacted Files
Coverage Δ

...va/org/opensearch/extensions/ExtensionRequest.java
29.41% <ø> (ø)

...arch/extensions/UpdateSettingsResponseHandler.java
0.00% <0.00%> (ø)

...rch/extensions/rest/RestSendToExtensionAction.java
27.77% <0.00%> (ø)

...a/org/opensearch/extensions/ExtensionsManager.java
54.04% <30.00%> (-6.72%)
:arrow_down:

...ch/extensions/action/ExtensionTransportAction.java
50.00% <50.00%> (ø)

...rg/opensearch/env/EnvironmentSettingsResponse.java
60.00% <60.00%> (ø)

...g/opensearch/extensions/UpdateSettingsRequest.java
63.33% <63.33%> (ø)

...sions/AddSettingsUpdateConsumerRequestHandler.java
65.21% <65.21%> (ø)

...ns/action/TransportActionRequestFromExtension.java
69.23% <69.23%> (ø)

...nsions/action/ExtensionHandleTransportRequest.java
70.00% <70.00%> (ø)

... and 514 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dblock @reta Thank you for all the feedback so far on these extensions PR's.  This is the last one before we will be working completely on main.  I would love to get this merged today if possible before everyone is gone for the holidays so can you take a look at some point today when you get a chance?

authors: codecov-commenter ryanbogan


text:
Allow OpenSearch BWC Tests to Run in HTTP or HTTPS

Description
Allow configuration of test clusters to run with TLS.
I copied the change patterns from this PR: https://github.com/opensearch-project/OpenSearch/pull/1051/files. Thank you @VachaShah for the help. From there this is the linked issue about figuring out how to exercise the changes in these files directly: https://github.com/opensearch-project/OpenSearch/issues/1086. Seems unaddressed, so hopefully this will not be a blocker.
Related Issues
https://github.com/opensearch-project/security/issues/3056
Check List

[ ] ~New functionality includes testing.~

[ ] ~All tests pass~

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I'm having trouble seeing how the value 'http.protocal' is used, shouldn't there be a change ~line 575 so the WaitForHttpResource object uses the correct protocol?

Yeah, we need to take the value from the settings and use it where you mentioned. The issue is it is not clear how we can configure the tests on the fly and actually change that value. There is a lot of circular logic between the OpenSearchCluster and OpenSearchNode files and most the values appear hard coded. The settings that are passed are all about the file structure which is not what we want. I will have to ask someone more familiar with this test setup because I cannot find a way to actually pass a value on execution.

I don't know why the parsing is not working again. @dblock do you have any idea why the swap to the input would cause the failure even when it passed before? If not I will take another look, but I also do not know how to test this locally...

Precommit failure is from runner crash. Should not be related to code.

I believe this is all set.

Messaged GitHub on call for a second review.

I broke this again, because I think we need to be able to use the configuration setting to figure out the protocol for all nodes.

@scrawfor99 Were you able to test the changes locally?

Hi @peternied, Craig figured out how to test the changes locally while I was out. I have not looked at what he did yet but I will be speaking with him about it this afternoon. We should be able to manually verify the changes we want to make as a result.
That being said, I don't plan to add formal coverage tests as part of this PR given the testing scenario mentioned in the description.

I'm happy to approve once you've confirmed (manually or via automation) that this change will works.  I am concerned there might be an immediate follow up for how credentials are provided or trusting the certs from the cluster.

Here are the steps to test locally:

Clone core and make all changes you want
Clone security from this fork @cwperks made https://github.com/cwperks/security/tree/single-cluster-test
./gradlew localDistro & ./gradlew publishToMavenLocal core
Go to the location where the local distribution was placed and create a zip file of the distribution
Go to the Security plugin and run ./gradlew assemble
Grab the .zip file created in the security plugin and move it into the single-cluster-test/src/test/resources/3.0.0.0 directory
Navigate back to /single-cluster-test and run  ./gradlew runTestCluster -PcustomDistributionUrl="<path_to_core_zip>/opensearch-3.0.0-SNAPSHOT.tar.gz" -i

This should allow you test changes by passing different settings with the tests.opensearch. prefix in build.gradle file of the single-cluster-test.
Unfortunately, this does not appear to work on M1 chips?
I am presented a jarhell issue when running while @cwperks is able to run the exact same setup on an intel chip.

Just a follow-up, we don't want to merge this until testing is complete. The steps shared above work for Craig, but I am unable to use them on either my work or personal laptop.

Update: The above approach seems to only work on Craig's laptop. Neither of us could reproduce it....
I found an alternative solution which involves using the System properties to pass a custom setting.
By using command line we can get confirmation it works: ```Starting node{::singleCluster0-1}
SYSTEM PROPERTIES ARE: {java.specification.version=17, sun.jnu.encoding=UTF-8, sun.arch.data.model=64, java.vendor.url=https://adoptium.net/, sun.boot.library.path=/Users/steecraw/.sdkman/candidates/java/17.0.5-tem/lib, sun.java.command=org.gradle.launcher.daemon.bootstrap.GradleDaemon 8.2.1, jdk.debug=release, java.specification.vendor=Oracle Corporation, java.version.date=2022-10-18, java.home=/Users/steecraw/.sdkman/candidates/java/17.0.5-tem, file.separator=/, java.vm.compressedOopsMode=Zero based, line.separator=
, java.vm.specification.vendor=Oracle Corporation, java.specification.name=Java Platform API Specification, sun.management.compiler=HotSpot 64-Bit Tiered Compilers, java.runtime.version=17.0.5+8, user.name=steecraw, file.encoding=UTF-8, java.vendor.version=Temurin-17.0.5+8, java.io.tmpdir=/var/folders/8w/r3phsz2j09x9tky11pj8_ydh0000gr/T/, java.version=17.0.5, java.vm.specification.name=Java Virtual Machine Specification, tests.opensearch.http.protocol=https, native.encoding=UTF-8, java.library.path=/Users/steecraw/Library/Java/Extensions:/Library/Java/Extensions:/Network/Library/Java/Extensions:/System/Library/Java/Extensions:/usr/lib/java:., java.vendor=Eclipse Adoptium, sun.io.unicode.encoding=UnicodeBig, library.jansi.path=/Users/steecraw/.gradle/native/jansi/1.18/osx, java.class.path=/Users/steecraw/.gradle/wrapper/dists/gradle-8.2.1-bin/5hap6b9n41hkg4jeh2au2pllh/gradle-8.2.1/lib/gradle-launcher-8.2.1.jar, java.vm.vendor=Eclipse Adoptium, user.variant=, user.timezone=America/New_York, java.vm.specification.version=17, os.name=Mac OS X, user.country=US, sun.java.launcher=SUN_STANDARD, sun.cpu.endian=little, user.home=/Users/steecraw, user.language=en, org.gradle.appname=gradlew, path.separator=:, os.version=13.4, java.runtime.name=OpenJDK Runtime Environment, java.vm.name=OpenJDK 64-Bit Server VM, java.vendor.url.bug=https://github.com/adoptium/adoptium-support/issues, user.dir=/Users/steecraw/security/single-cluster-test, os.arch=aarch64, java.vm.info=mixed mode, java.vm.version=17.0.5+8, java.class.version=61.0}
Http protocol is now: https

We will also need to add a change to auth the request since without it we get an SSL exception.

Security Plugin installs:

Build Successful when running steps here: https://github.com/opensearch-project/OpenSearch/pull/8900#issuecomment-1672143707

Command to run:

Flaky test failures:

  | Test Result (6 failures  / +6)org.opensearch.cluster.routing.ShardMovementStrategyTests.testClusterGreenAfterPartialRelocationNoPreferenceShardMovementPrimaryFirstEnabledorg.opensearch.cluster.routing.ShardMovementStrategyTests.classMethodorg.opensearch.cluster.routing.allocation.BalancedSingleShardTests.classMethodorg.opensearch.cluster.routing.allocation.BalancedSingleShardTests.classMethodorg.opensearch.cluster.routing.allocation.MaxRetryAllocationDeciderTests.classMethodorg.opensearch.snapshots.SnapshotResiliencyTests.testTransportGetSnapshotsAction
-- | --

[Test Result](https://build.ci.opensearch.org/job/gradle-check/22531/testReport/) (6 failures / +6)

    [org.opensearch.cluster.routing.ShardMovementStrategyTests.testClusterGreenAfterPartialRelocationNoPreferenceShardMovementPrimaryFirstEnabled](https://build.ci.opensearch.org/job/gradle-check/22531/testReport/junit/org.opensearch.cluster.routing/ShardMovementStrategyTests/testClusterGreenAfterPartialRelocationNoPreferenceShardMovementPrimaryFirstEnabled/)
    [org.opensearch.cluster.routing.ShardMovementStrategyTests.classMethod](https://build.ci.opensearch.org/job/gradle-check/22531/testReport/junit/org.opensearch.cluster.routing/ShardMovementStrategyTests/classMethod/)
    [org.opensearch.cluster.routing.allocation.BalancedSingleShardTests.classMethod](https://build.ci.opensearch.org/job/gradle-check/22531/testReport/junit/org.opensearch.cluster.routing.allocation/BalancedSingleShardTests/classMethod/)
    [org.opensearch.cluster.routing.allocation.BalancedSingleShardTests.classMethod](https://build.ci.opensearch.org/job/gradle-check/22531/testReport/junit/org.opensearch.cluster.routing.allocation/BalancedSingleShardTests/classMethod_2/)
    [org.opensearch.cluster.routing.allocation.MaxRetryAllocationDeciderTests.classMethod](https://build.ci.opensearch.org/job/gradle-check/22531/testReport/junit/org.opensearch.cluster.routing.allocation/MaxRetryAllocationDeciderTests/classMethod/)
    [org.opensearch.snapshots.SnapshotResiliencyTests.testTransportGetSnapshotsAction](https://build.ci.opensearch.org/job/gradle-check/22531/testReport/junit/org.opensearch.snapshots/SnapshotResiliencyTests/testTransportGetSnapshotsAction/)

@scrawfor99 Retriggered CI

@scrawfor99 This test failure look related to your change
3: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':example-plugins:custom-settings:yamlRestTest'.
> `cluster{:example-plugins:custom-settings:yamlRestTest}` failed to wait for cluster health yellow after 40 SECONDS

@peternied I think this should be set now
Flaky test:

  | Test Result (1 failure  / ±0)org.opensearch.client.RestClientSingleHostIntegTests.testRequestResetAndAbort
-- | --

[Test Result](https://build.ci.opensearch.org/job/gradle-check/22548/testReport/) (1 failure / ±0)

    [org.opensearch.client.RestClientSingleHostIntegTests.testRequestResetAndAbort](https://build.ci.opensearch.org/job/gradle-check/22548/testReport/junit/org.opensearch.client/RestClientSingleHostIntegTests/testRequestResetAndAbort/)

Test failures are different:

  | The following steps that have been detected may have insecure interpolation of sensitive variables         (click here for an explanation):         sh: [DOCKER_PASSWORD, DOCKER_USERNAME]
-- | --

Test Result (2 failures  / ±0)

org.opensearch.geo.search.aggregations.metrics.GeoBoundsITTestCase.classMethod

org.opensearch.index.translog.RemoteFSTranslogTests.testMetadataFileDeletion

The following steps that have been detected may have insecure interpolation of sensitive variables [(click here for an explanation)](https://jenkins.io/redirect/groovy-string-interpolation):

    sh: [DOCKER_PASSWORD, DOCKER_USERNAME]

[Test Result](https://build.ci.opensearch.org/job/gradle-check/22634/testReport/) (2 failures / ±0)

    [org.opensearch.geo.search.aggregations.metrics.GeoBoundsITTestCase.classMethod](https://build.ci.opensearch.org/job/gradle-check/22634/testReport/junit/org.opensearch.geo.search.aggregations.metrics/GeoBoundsITTestCase/classMethod/)
    [org.opensearch.index.translog.RemoteFSTranslogTests.testMetadataFileDeletion](https://build.ci.opensearch.org/job/gradle-check/22634/testReport/junit/org.opensearch.index.translog/RemoteFSTranslogTests/testMetadataFileDeletion/)

Seems like definitely flaky.

@dblock can I get a review and possible merge please? Thank you :)

Thanks @scrawfor99 ! We needs signoff from @dblock

Failing precommit seems unrelated.

Hi @dblock, that is a good question haha. I am adding some notes to using it in the Security repo, but basically it is used with this process: https://github.com/opensearch-project/security/issues/3056#issuecomment-1675386278. In short, with this change, you can go into the security repo and grab the code changes that will shortly be merged when I fix them all. The working branch is here: https://github.com/scrawfor99/security/tree/testClusterChanges.
Then you will run the BWC tests bwcTestSuite and provide arguments for the system properties I detailed here. Specifically, it will look something like
./gradlew -p bwc-test clean bwcTestSuite \
   -Dtests.security.manager=false \
   -Dtests.opensearch.http.protocol=https \
   -Dtests.opensearch.username=admin \
   -Dtests.opensearch.password=admin \
   -PcustomDistributionUrl="/Users/steecraw/OpenSearch/distribution/archives/linux-tar/build/distributions/opensearch-min-3.0.0-SNAPSHOT-linux-x64.tar.gz" \
   -i

This lets you specify security information when running our BWC tests so we can then confirm when the tests operate with Security and establish secure connections between the nodes.

Can we add this info to https://github.com/opensearch-project/OpenSearch/blob/main/TESTING.md#testing-backwards-compatibility as part of this PR please?

Sorry for the late review. Your changes broke some of my tests in another repo and I started investigation.

What repo? Do you have an issue you can link?

@scrawfor99
I already found a fix. But you are welcome to review:
https://github.com/Bit-Quill/opensearch-project-sql/pull/335

@scrawfor99 updated link for Yury's PR: https://github.com/opensearch-project/sql/pull/1986
Please take a look if you have a moment.  This allows us to run IT tests against a cluster & remote cluster that has the security and SQL plugins installed.

authors: Yury-Fridlyand acarbonetto dblock peternied reta scrawfor99


text:
[Refactor] CircuitBreaker foundation classes to core library

This PR refactors the following CircuitBreaker foundation classes from the server module to the core library:

o.o.common.breaker.CircuitBreaker
o.o.common.breaker.CircuitBreakingException
o.o.common.breaker.NoopCircuitBreaker
o.o.indices.breaker.AllCircuitBreakerStats
o.o.indices.breaker.CircuitBreakerService
o.o.indices.breaker.CircuitBreakerStats
o.o.indices.breaker.NoneCircuitBreakerService

The following base support classes are also refactored from the server to appropriate common or core libraries as a net positive side effect:

o.o.common.component.AbstractLifecycleComponent
o.o.common.component.Lifecycle
o.o.common.component.LifecycleComponent
o.o.common.component.LifecycleListener
o.o.common.unit.ByteSizeUnit
o.o.common.unit.ByteSizeValue

Tests and documentation are updated.
This refactor continues the unwinding of foundation classes from the server monolith to separable libraries in support of JPMS and serverless and cloud native implementations.
relates #5910
relates #8110

Opened bug fix #9011

Blocked by 9011

Strange. The build passed.. But the GHA failed.. cool. refiring.

More breaking changes for god of breaking changes! ©

Will this PR be backported to 2.x?

Opening the backport now.

This PR changes the namespace on large number of classes.  Could we have move these classes to different parts of core into a new library without the namespace change, then at a later date roll out the list of sed /this/that/ all at once?

The divergence with 2.x won't last long. This backport is next in the queue after #9050 merges

authors: Yury-Fridlyand cwperks nknize peternied


text:
Updated issue templates from .github.

Signed-off-by: dblock dblock@dblock.org
Description
Coming from Signed-off-by: dblock dblock@dblock.org
Description
Coming from https://github.com/opensearch-project/.github/issues/64, updated issue templates for bugs and features.
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
, updated issue templates for bugs and features.
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

CI is failing :(

@qreshi could I please get this merged?

repo: opensearch-project/alerting


text:
Kafka source bug fixes

Description

Kafka source will be able to fetch data with and without Schema registry.
Authentication related YAML changes done for the PR#2858.
Implemented a generic consumer to handle all the three data formats like plaintext, json and avro.
Added more Junits.

Issues Resolved
Github issue https://github.com/opensearch-project/data-prepper/issues/254
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ajeeshakd I am not sure how this PR was merged. If I did it on accident I apologize, but I really don't remember merging this, and not sure how I had permissions to merge without any approvals. Please create a new PR to follow up any changes to needed to complete this one

repo: opensearch-project/data-prepper


text:
Use Netty 4.1.68 which fixes CVE-2021-37136 and CVE-2021-37137

Description
Fixes two CVEs which are in the currently used version of Netty.
See https://netty.io/news/2021/09/09/4-1-68-Final.html
Issues Resolved
N/A
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

:exclamation: No coverage uploaded for pull request base (1.2@3eb5f2e). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             1.2     #661   +/-   ##
======================================
  Coverage       ?   91.38%
  Complexity     ?      583
======================================
  Files          ?       74
  Lines          ?     1788
  Branches       ?      148
======================================
  Hits           ?     1634
  Misses         ?      116
  Partials       ?       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eb5f2e...d1b458a. Read the comment docs.

authors: codecov-commenter dlvenable


text:
Explain index's date-time pattern in Sink's README.md file.

Signed-off-by: Han Jiang jianghan@amazon.com
Description
Explain index's date-time pattern in Sink's README.md file.
Issues Resolved
#767
Check List

[x ] New functionality includes testing.
[ x] New functionality has been documented.

[ ] New functionality has javadoc added. NA

[x ] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks for putting this together! I viewed the file on GitHub and found it to be somewhat hard to ready with all the symbols. I think putting the index names in back ticks will help with the formatting.

Good point! I should have thought of that. Updated.


text:
merge content and remove duplicate file for update mapping APi

Description
Initial PR for minor fix to test workflow. Partial fix for issue 485.
Issues Resolved
in-progress for 485
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

made too many mistakes. going to start fresh with new branch.


text:
Write blog for index operation-shrink

Write something for the index operation's blog, mainly about shrink index operation.

All work are done.


text:
[BUG] Invalid UTF-8 start byte issue

Describe the bug
It's not possible to save item with non-ASCII characters into OpenSearch
To Reproduce
Steps to reproduce the behavior:

Run OpenSearch in a Docker container:

docker run -d -p 9200:9200 -p 9600:9600 -e "discovery.type=single-node" -e "plugins.security.disabled=true" opensearchproject/opensearch:latest

Setup and install logstash-oss-8-5-2 (Windows)
Install logstash-output-opensearch plugin:

<path/to/your/logstash/dir>/bin/logstash-plugin install --version 2.0.0 logstash-output-opensearch

Use below sample code to run the logstash, save file as logstash-example.conf

input {
    stdin { }
}

filter {
# if you remove letter 'ß' error will dissapear
    mutate { add_field => { "name" =>  "Groß" } }
    prune { whitelist_names => [ "^name$" ] }
}

output {
    opensearch {
        hosts => ["localhost:9200"]
        auth_type => {
            type => 'basic'
            user => 'admin'
            password => 'admin'
        }
        index => "test_index"
        action => "index"
    }

   # if elasticsearch is instaled, you can make sure that it works properly:
   # elasticsearch {
   #     hosts => ["localhost:9200"]
   #     index => "test_index"
   #     action => "index"
   #     codec => "json"
   # }

}

Run the logstash as:

<path/to/your/logstash/dir>/bin/logstash -f logstash-example.conf

Type any text into std input, press enter
See the error:

"status"=>400, "error"=>{"type"=>"mapper_parsing_exception", "reason"=>"failed to parse", "caused_by"=>{"type"=>"json_parse_exception", "reason"=>"Invalid UTF-8 start byte 0xa0\n at [Source: (byte[])"{"event":{"original":"\r"},"message":"\r","@timestamp":"2023-01-19T11:07:14.447970Z","name":"Gro∩┐╜","host":{"hostname":"DESKTOP-SP31NNN"},"@version":"1"}"; line: 1, column: 98]

WireShark caught next request:

you can see that OpenSearch filter encodes letter 'ß' non-correctly (a0)
And here is how request looks like with elasticsearch and Logstash 7.11 output filter:

you can see that Elastic filter encodes letter 'ß' correctly (c3 9f)
Expected behavior
There should not be any error and new item with field "name": "Groß" should appears in the index "test_index"
Plugins
logstash-output-opensearch
Screenshots

Host/Environment:

OS: Windows 11
Version 10.0.22621 N/A Build 22621

UPD 23.01.2023
I tried to execute the script for ElasticSearch 8.6.0 (and elasticsearch output plugin) and received the same error.
On the first step run ElasticSearch in a Docker container:

docker run -p 9200:9200 -p 9300:9300 -e "discovery.type=single-node" -e "xpack.security.enabled=false" docker.elastic.co/elasticsearch/elasticsearch:8.6.0

Also I tried with Logstash-8-6-0 and the issue is not reproduced.
So, the issue is in Logstash OSS version

How to fix that issue?
I have probably something similar right now:
[2023-10-11T03:10:58,777][ERROR][logstash.outputs.opensearch][pipeline-1][fed1f28e886bd8e7cf9bf004b9cfbf237a68a06e057ab9af8d9b82881119c28b] An unknown error occurred sending a bulk request to OpenSearch (will retry indefinitely) {
  :message=>"ASCII-8BIT",
  :exception=>Java::JavaNioCharset::UnsupportedCharsetException,
  :backtrace=>[
    "java.nio.charset.Charset.forName(java/nio/charset/Charset.java:528)",
    "org.apache.http.entity.ContentType.create(org/apache/http/entity/ContentType.java:257)",
    "org.apache.http.entity.StringEntity.<init>(org/apache/http/entity/StringEntity.java:116)", "jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)",
    "jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(jdk/internal/reflect/NativeConstructorAccessorImpl.java:77)",
    "jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(jdk/internal/reflect/DelegatingConstructorAccessorImpl.java:45)",
    "java.lang.reflect.Constructor.newInstanceWithCaller(java/lang/reflect/Constructor.java:499)",
    "java.lang.reflect.Constructor.newInstance(java/lang/reflect/Constructor.java:480)",
    "org.jruby.javasupport.JavaConstructor.newInstanceDirect(org/jruby/javasupport/JavaConstructor.java:207)",
    "org.jruby.RubyClass.new(org/jruby/RubyClass.java:917)",
    "org.jruby.RubyClass$INVOKER$i$newInstance.call(org/jruby/RubyClass$INVOKER$i$newInstance.gen)",
    "RUBY.sign_aws_request(/opt/bitnami/logstash/vendor/bundle/jruby/3.1.0/gems/logstash-output-opensearch-2.0.2-java/lib/logstash/outputs/opensearch/http_client/manticore_adapter.rb:210)",
    "RUBY.perform_request(/opt/bitnami/logstash/vendor/bundle/jruby/3.1.0/gems/logstash-output-opensearch-2.0.2-java/lib/logstash/outputs/opensearch/http_client/manticore_adapter.rb:166)",
    "RUBY.perform_request_to_url(/opt/bitnami/logstash/vendor/bundle/jruby/3.1.0/gems/logstash-output-opensearch-2.0.2-java/lib/logstash/outputs/opensearch/http_client/pool.rb:272)",
    "RUBY.perform_request(/opt/bitnami/logstash/vendor/bundle/jruby/3.1.0/gems/logstash-output-opensearch-2.0.2-java/lib/logstash/outputs/opensearch/http_client/pool.rb:259)",
    "RUBY.with_connection(/opt/bitnami/logstash/vendor/bundle/jruby/3.1.0/gems/logstash-output-opensearch-2.0.2-java/lib/logstash/outputs/opensearch/http_client/pool.rb:348)",
    "RUBY.perform_request(/opt/bitnami/logstash/vendor/bundle/jruby/3.1.0/gems/logstash-output-opensearch-2.0.2-java/lib/logstash/outputs/opensearch/http_client/pool.rb:258)",
    "RUBY.Pool(/opt/bitnami/logstash/vendor/bundle/jruby/3.1.0/gems/logstash-output-opensearch-2.0.2-java/lib/logstash/outputs/opensearch/http_client/pool.rb:266)",
    "org.jruby.RubyProc.call(org/jruby/RubyProc.java:373)",
    "RUBY.bulk_send(/opt/bitnami/logstash/vendor/bundle/jruby/3.1.0/gems/logstash-output-opensearch-2.0.2-java/lib/logstash/outputs/opensearch/http_client.rb:179)",
    "RUBY.bulk(/opt/bitnami/logstash/vendor/bundle/jruby/3.1.0/gems/logstash-output-opensearch-2.0.2-java/lib/logstash/outputs/opensearch/http_client.rb:157)",
    "RUBY.safe_bulk(/opt/bitnami/logstash/vendor/bundle/jruby/3.1.0/gems/logstash-output-opensearch-2.0.2-java/lib/logstash/plugin_mixins/opensearch/common.rb:276)",
    "RUBY.submit(/opt/bitnami/logstash/vendor/bundle/jruby/3.1.0/gems/logstash-output-opensearch-2.0.2-java/lib/logstash/plugin_mixins/opensearch/common.rb:157)",
    "RUBY.retrying_submit(/opt/bitnami/logstash/vendor/bundle/jruby/3.1.0/gems/logstash-output-opensearch-2.0.2-java/lib/logstash/plugin_mixins/opensearch/common.rb:106)",
    "RUBY.multi_receive(/opt/bitnami/logstash/vendor/bundle/jruby/3.1.0/gems/logstash-output-opensearch-2.0.2-java/lib/logstash/outputs/opensearch.rb:277)",
    "org.logstash.config.ir.compiler.OutputStrategyExt$AbstractOutputStrategyExt.invokeOutput(org/logstash/config/ir/compiler/OutputStrategyExt.java:153)",
    "org.logstash.config.ir.compiler.OutputStrategyExt$SimpleAbstractOutputStrategyExt.doOutput(org/logstash/config/ir/compiler/OutputStrategyExt.java:279)",
    "org.logstash.config.ir.compiler.OutputStrategyExt$SharedOutputStrategyExt.output(org/logstash/config/ir/compiler/OutputStrategyExt.java:312)",
    "org.logstash.config.ir.compiler.OutputStrategyExt$AbstractOutputStrategyExt.multiReceive(org/logstash/config/ir/compiler/OutputStrategyExt.java:143)",
    "org.logstash.config.ir.compiler.OutputDelegatorExt.doOutput(org/logstash/config/ir/compiler/OutputDelegatorExt.java:111)",
    "org.logstash.config.ir.compiler.AbstractOutputDelegatorExt.lambda$multiReceive$0(org/logstash/config/ir/compiler/AbstractOutputDelegatorExt.java:121)",
    "co.elastic.logstash.api.TimerMetric.lambda$time$0(co/elastic/logstash/api/TimerMetric.java:35)",
    "org.logstash.instrument.metrics.timer.ConcurrentLiveTimerMetric.time(org/logstash/instrument/metrics/timer/ConcurrentLiveTimerMetric.java:47)",
    "co.elastic.logstash.api.TimerMetric.time(co/elastic/logstash/api/TimerMetric.java:34)",
    "org.logstash.config.ir.compiler.AbstractOutputDelegatorExt.multi_receive(org/logstash/config/ir/compiler/AbstractOutputDelegatorExt.java:121)",
    "org.logstash.generated.CompiledDataset7.compute(org/logstash/generated/CompiledDataset7)",
    "org.logstash.generated.CompiledDataset8.compute(org/logstash/generated/CompiledDataset8)",
    "org.logstash.config.ir.CompiledPipeline$CompiledUnorderedExecution.compute(org/logstash/config/ir/CompiledPipeline.java:351)",
    "org.logstash.config.ir.CompiledPipeline$CompiledUnorderedExecution.compute(org/logstash/config/ir/CompiledPipeline.java:341)",
    "org.logstash.execution.ObservedExecution.lambda$compute$0(org/logstash/execution/ObservedExecution.java:17)",
    "org.logstash.execution.WorkerObserver.lambda$observeExecutionComputation$0(org/logstash/execution/WorkerObserver.java:39)",
    "org.logstash.instrument.metrics.timer.ConcurrentLiveTimerMetric.time(org/logstash/instrument/metrics/timer/ConcurrentLiveTimerMetric.java:47)",
    "org.logstash.execution.WorkerObserver.lambda$executeWithTimers$1(org/logstash/execution/WorkerObserver.java:50)",
    "org.logstash.instrument.metrics.timer.ConcurrentLiveTimerMetric.time(org/logstash/instrument/metrics/timer/ConcurrentLiveTimerMetric.java:47)",
    "org.logstash.execution.WorkerObserver.executeWithTimers(org/logstash/execution/WorkerObserver.java:50)",
    "org.logstash.execution.WorkerObserver.observeExecutionComputation(org/logstash/execution/WorkerObserver.java:38)",
    "org.logstash.execution.ObservedExecution.compute(org/logstash/execution/ObservedExecution.java:17)",
    "org.logstash.execution.WorkerLoop.abortableCompute(org/logstash/execution/WorkerLoop.java:113)",
    "org.logstash.execution.WorkerLoop.run(org/logstash/execution/WorkerLoop.java:86)",
    "jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)",
    "jdk.internal.reflect.NativeMethodAccessorImpl.invoke(jdk/internal/reflect/NativeMethodAccessorImpl.java:77)",
    "jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(jdk/internal/reflect/DelegatingMethodAccessorImpl.java:43)",
    "java.lang.reflect.Method.invoke(java/lang/reflect/Method.java:568)",
    "org.jruby.javasupport.JavaMethod.invokeDirectWithExceptionHandling(org/jruby/javasupport/JavaMethod.java:329)",
    "org.jruby.javasupport.JavaMethod.invokeDirect(org/jruby/javasupport/JavaMethod.java:193)",
    "RUBY.start_workers(/opt/bitnami/logstash/logstash-core/lib/logstash/java_pipeline.rb:304)",
    "org.jruby.RubyProc.call(org/jruby/RubyProc.java:352)",
    "java.lang.Thread.run(java/lang/Thread.java:833)"]}

@zentavr do you have the text that's being sent here (a few log lines around this error)?

@dblock the error is gone when I'd disabled http_compression for opensearch.

@zentavr It's good info, but you should definitely enable lower level logging and extract the actual data being sent (I am thinking this could be https://github.com/opensearch-project/logstash-output-opensearch/pull/217 or similar). Open a new issue with that info.

@dblock unfortunately there is no in the docs how can I enable more verbose logging and extract the actual data. Having that would save several days of my work actually :)

authors: dblock dstepanov25 zentavr


text:
Fix benchmark nightly runs for remote-store feature

In the current implementation the remote-store nightly runs require an S3 bucket to be created as part of the CDK deployment to be able to upload the data, the bucket policy is set to DESTROY with autoDeleteObjects enabled, this creates a custom resource lambda that initiates object delete when the stack is destroyed.
After the benchmark run has completed and stack destroy is initiated, the lambda gets triggered and deletes ll the objects in the S3 bucket and then get deleted immediately after, however the S3 bucket gets deleted later on, during this time-interval data is still getting synced between OS process running on ec2 instance and S3 bucket.
Due to this the stack delete fails with Bucket not empty error and stale resources are created in the AWS account.
To fix this we are proposing to handle the S3 delete as part of post action and set RETAIN policy on the S3 bucket so that it is skipped during stack delete.

Closing this issue as it is no longer required.

repo: opensearch-project/opensearch-build


text:
[FEATURE] Improve opensearch-cli profile create command

Is your feature request related to a problem?
I would like to improve the opensearch-cli profile create command to allow passing in flags for the "AWS Profile name" and "AWS Service name". These options currently require user input which makes it difficult to explain to colleagues how to set up opensearch-cli or to automate the process of setting up profiles for different clusters on different accounts.
What solution would you like?
I would like to see a --profile and --service flag added to the profile create command.
What alternatives have you considered?
You can also potentially use --aws-profile or --aws-service flags to differentiate between an opensearch profile and AWS profile.
Do you have any additional context?
My internal alias is aljohri@ if anyone is interested in chatting further.

I came here to make the same request. The current flow prevents me from easily scripting profile creation.

authors: AlJohri robfig

repo: opensearch-project/opensearch-cli


text:
[PROPOSAL] ModelTestCase.mapper improvements

What/Why
What are you proposing?

Modify the ModelTestCase model's mapper to use only one fixedly or both to use both fixedly.

What problems are you trying to solve?

I don't think it's good code if a test passes or breaks randomly. It seems like a good idea to organize the reasons for using two mappers and improve it so that they are always used when both are needed.

What is the developer experience going to be?

No more cases of partially passing or failing tests

100% thanks!

Do you think that both mapper should support here? I think I can work on it once the decision is made.

Hi @channel-dante and @dblock ,  we are adding a default Mapper in JsonUtils in this PR , please follow this comment to know the context, I think we can use that , rather than hardcoding one of them, the idea is to take the provider from the classpath instead of hardcoding one of the jakarta or Jackson

I am not sure what the implications of either are, let's look at the code! Thank you.

authors: Jai2305 channel-dante dblock

repo: opensearch-project/opensearch-java


text:
Avoid using important in style sheets

https://uxengineer.com/css-specificity-avoid-important-css/
If there are situations where it is conflicting then we should consider fixing conflicts.
Origin: https://github.com/opensearch-project/oui/pull/131/

Currently present in 73! files. I think this is something we can work on incrementally, as there is some risk to attempting to fix these.

Currently present in 73! files. I think this is something we can work on incrementally, as there is some risk to attempting to fix these.

Completely agree. I think it would probably be possible to break these down into smaller issues.
Additionally, I think it would be nice to understand why important is used. For example, when I was working on breadcrumbs, I needed to use it to override the color of links to a custom color, which otherwise wouldn't be possible.

authors: BSFishy joshuarrrr kavilla

repo: opensearch-project/oui


text:
Incremented version to 1.3.2.

Coming from https://github.com/opensearch-project/opensearch-build/issues/1805 post release activity.
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaiksaya  Build is failing because of the test-retry dependency version missing. I think it was made unintentionally during replacing 1.3.1 to 1.3.2.
Plugin [id: 'org.gradle.test-retry', version: '1.3.2'] was not found in any of the following sources:

- Gradle Core Plugins (not a core plugin, please see https://docs.gradle.org/6.6.1/userguide/standard_plugins.html for available core plugins)
- Plugin Repositories (could not resolve plugin artifact 'org.gradle.test-retry:org.gradle.test-retry.gradle.plugin:1.3.2')
  Searched in the following repositories:
    Gradle Central Plugin Repository

@gaiksaya Build is failing because of the test-retry dependency version missing. I think it was made unintentionally during replacing 1.3.1 to 1.3.2.
Plugin [id: 'org.gradle.test-retry', version: '1.3.2'] was not found in any of the following sources:

- Gradle Core Plugins (not a core plugin, please see https://docs.gradle.org/6.6.1/userguide/standard_plugins.html for available core plugins)
- Plugin Repositories (could not resolve plugin artifact 'org.gradle.test-retry:org.gradle.test-retry.gradle.plugin:1.3.2')
  Searched in the following repositories:
    Gradle Central Plugin Repository

Fixed it. Also I removed the hard corded value for opensearch.version from workflows since default points to 1.3.2-SNAPSHOT

Codecov Report

Merging #153 (5fcb1f1) into 1.3 (1b43e2e) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.3     #153      +/-   ##
============================================
- Coverage     72.04%   71.92%   -0.12%
+ Complexity     2962     2944      -18
============================================
  Files           376      376
  Lines         18834    18774      -60
  Branches       1465     1437      -28
============================================
- Hits          13569    13504      -65
+ Misses         4681     4680       -1
- Partials        584      590       +6

Impacted Files
Coverage Δ

...pensearch/performanceanalyzer/jvm/HeapMetrics.java
40.62% <0.00%> (-15.63%)
:arrow_down:

...performanceanalyzer/rca/framework/api/Symptom.java
90.90% <0.00%> (-9.10%)
:arrow_down:

.../org/opensearch/performanceanalyzer/core/Util.java
62.50% <0.00%> (-8.34%)
:arrow_down:

...formanceanalyzer/PerformanceAnalyzerWebServer.java
68.65% <0.00%> (-5.98%)
:arrow_down:

...anceanalyzer/reader/AdmissionControlProcessor.java
72.09% <0.00%> (-2.33%)
:arrow_down:

...ceanalyzer/reader/MasterMetricsEventProcessor.java
88.88% <0.00%> (-1.86%)
:arrow_down:

.../opensearch/performanceanalyzer/jvm/GCMetrics.java
55.88% <0.00%> (-1.48%)
:arrow_down:

...nsearch/performanceanalyzer/rca/RcaController.java
79.29% <0.00%> (-1.33%)
:arrow_down:

...manceanalyzer/rca/persistence/SQLitePersistor.java
75.30% <0.00%> (-0.93%)
:arrow_down:

...ensearch/performanceanalyzer/hwnet/NetworkE2E.java
80.18% <0.00%> (+2.70%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b43e2e...5fcb1f1. Read the comment docs.

authors: codecov-commenter gaiksaya sruti1312


text:
Confirmation dialog for removing permission is unstyled at bottom of page

If you attempt to delete anything from the index permissions tab of a role, the confirmation dialog pops up in the lower-left of the screen completely unstyled. I suspect this problem occurs in other places, as well.
Reproducible in Chromium Edge and Firefox.

Make a new role with an index pattern and some permissions in ODFE 1.4.0.
Save Role Definition.
Edit the role.
Try to remove a permission.

@aetter This was fixed in ODFE 1.4.0.0. How are you running kibana (docker, cloudfront.. ) ?
Probably the release was cut before the fix was applied.
FIx PR: https://github.com/opendistro-for-elasticsearch/security-kibana-plugin/pull/136

I'm on Docker images amazon/opendistro-for-elasticsearch:1.4.0 and amazon/opendistro-for-elasticsearch-kibana:1.4.0.

@aetter I will check with the infra team and make a new release if necessary for ODFE docker.

Apologies for the late reply here. Tested with OpenSearch 1.2.4 and the issue is no longer reproducible (the UI has changed substantially and those buttons are no longer there in that form).

authors: aetter davidlago sujithvm


text:
Adds system index permission as allowed action under static drop down list

Description
At present, the allowed action system:admin/system_index is not visible in the static drop down list and hence is not available to be assigned to a role. This PR adds that capability
Category
Bug fix
Issues Resolved

Resolves https://github.com/opensearch-project/security-dashboards-plugin/issues/1697

Testing

[x] Should be present in Index permissions:

[x] Should not be present in cluster permissions:

Check List

[x] New functionality includes testing
~- [ ] New functionality has been documented~
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Do we want to separate out the two functionality? It seems like this is packaging the index permission with some of the admin:admin work, but I am generally ok with this as is

Its a relatively small change, and should be okay to merge.

Do we want to separate out the two functionality? It seems like this is packaging the index permission with some of the admin:admin work, but I am generally ok with this as is

Lets separate the permissions changes from the default password changes.  The additional permissions option doesn't seem time sensitive and it would be good to make a clear PR / commit when we've been changing how passwords are handled.

authors: DarshitChanpura peternied


text:
Update json-path to address CVE-2023-51074

Description

Category (Maintenance)
Updates the json-path library to address CVE-2023-51074

Issues Resolved
https://www.cve.org/CVERecord?id=CVE-2023-51074
Testing
Manually built and ran the security plugin according to the developer guide.
Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This dependency was removed on main in #3262. I will look into backporting that change to 1.3.

@cwperks I can see that you've already raised the backport PR. Thank you for doing that!  PR. I'll go ahead and close this one then.

repo: opensearch-project/security


text:
remove footer from calc pages

While working with designs for the current sprint and discussing them with Madeline we realized that it was not necessary to have the footer showing up on the calc pages (not in the SOT either), and having users focus more on the calc itself would be better, all navigation is still available through the main menu navigation.
Having the footer there was a by product of other changes to the footer I believe, so this is kind of a bug fix I think.
Am I right about this? Let me know.

This change might result in someone forgetting to add in the footer to new pages/routes in the future. I think a more future-proof solution would be to keep the route structure as is, but add a conditional either in App.js or Footer.tsx that prevents it from appearing if the path includes /calculator.

This change might result in someone forgetting to add in the footer to new pages/routes in the future. I think a more future-proof solution would be to keep the route structure as is, but add a conditional either in App.js or Footer.tsx that prevents it from appearing if the path includes /calculator.

Good point. I will see about update it to work that way.

authors: dylankershaw sjpaige

repo: openseattle/clearviction

license: MIT


text:
Service Object requires property uses permissions that seem CF-specific

https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md#-service-objects-
The requires property lists (currently limited) set of syslog_drain, route_forwarding and volume_mount. The permissions appear CF-specific. Is there plan to either extend this property to allow more general set of permissions, even implementation-specific ones, or is this field being removed as part of making the API more generic?

#116 is a proposal that will generally address this. On the bigger picture, we want to support parametrised output for the binding operation. You can also check out #115 as an effort to remove (or at least deprecate) CF-only fields from the spec.
Please check if those efforts overlap with your request.

Thanks for the additional pointers. Hopefully even though the #115 doesn't seem to explicitly mention the requires property, it will be included and then replaced by binding schemas (and perhaps some additional mechanism, unless binding schemas also address issue of permissions).

I'm going to close this in favour of #392 which should open the door to having bindings defined by schemas rather than the requires property in the catalog.

authors: angarg12 martinmaly mattmcneeney

repo: openservicebrokerapi/servicebroker


text:
Implement SMI metrics API server

Please describe the Improvement and/or Feature Request

Add an implementation for OSM to the SMI metrics API server.
Scope (please mark with X where applicable)

New Functionality          [X]
Install                    [ ]
SMI Traffic Access Policy  [ ]
SMI Traffic Specs Policy   [ ]
SMI Traffic Split Policy   [ ]
Permissive Traffic Policy  [ ]
Ingress                    [ ]
Egress                     [ ]
Envoy Control Plane        [ ]
CLI Tool                   [ ]
Metrics                    [X]
Certificate Management     [ ]
Sidecar Injection          [ ]
Logging                    [ ]
Debugging                  [ ]
Tests                      [ ]
CI System                  [ ]
Project Release            [ ]

Possible use cases

This work is basically complete. Only waiting to merge the changes required by #984 once upstream Envoy supports WASM filters. Code is on my fork: https://github.com/nojnhuh/smi-metrics/tree/openservicemesh

Reopening until this is merged.

PR open: https://github.com/servicemeshinterface/smi-metrics/pull/77

I think we should create a slim osm-metrics chart in the OSM repo under charts/ and allow folks to install it via the osm CLI now that envoy has WASM support cc/ @nojnhuh @nojnhuh
What do ya'll think?

@nojnhuh please could you share your status on this issue? Looks like you did some work here, is it complete? If there is no more action, please could you close the issue.

@snehachhabria There aren't any more changes we need to make to OSM for this. I planned to keep this issue open until the upstream PR I linked above is merged but I'm fine if we want to close it.

authors: michelleN nojnhuh snehachhabria

repo: openservicemesh/osm


text:
feat(pkg/reconciler) : Adding a reconciler in OSM for the CA bundle in the mutating webhook configuration

Description:
This PR added a controller that watched for mutating webhook resources in OSM and updates only OSM's mutating webhook with the latest CA bundle, whenever it is missing ( due to deletion)
Fixes : #1909
Affected area:

New Functionality      [X]
Documentation          [ ]
Install                [ ]
Control Plane          [X]
CLI Tool               [ ]
Certificate Management [ ]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests                  [ ]
CI System              [ ]
Performance            [ ]
Other                  [ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution? no

Codecov Report

Merging #1976 (f41412f) into main (19fb9fe) will increase coverage by 0.02%.
The diff coverage is 41.83%.

@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
+ Coverage   56.63%   56.66%   +0.02%
==========================================
  Files         141      142       +1
  Lines        5673     5755      +82
==========================================
+ Hits         3213     3261      +48
- Misses       2457     2491      +34
  Partials        3        3

Impacted Files
Coverage Δ

pkg/kubernetes/mock_controller.go
0.00% <0.00%> (ø)

cmd/osm-controller/osm-controller.go
28.64% <14.70%> (-2.76%)
:arrow_down:

pkg/reconciler/mutatingwebhook/reconcile.go
80.76% <80.76%> (ø)

pkg/kubernetes/client.go
89.69% <93.33%> (+9.20%)
:arrow_up:

pkg/injector/webhook.go
72.28% <100.00%> (ø)

pkg/envoy/route/config.go
96.03% <0.00%> (+0.79%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed9cffd...f41412f. Read the comment docs.

authors: codecov-io snehachhabria


text:
ref(*): Unfify all osm control pane pod names as one constant

Description:
Remove duplicate references of osm control plane pod names by creating a
constant and updating all code to use this.
Signed-off-by: Sneha Chhabria snchh@microsoft.com
Affected area:

Functional Area

New Functionality
[ ]

CI System
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[ ]

Demo
[ ]

Documentation
[ ]

Egress
[ ]

Ingress
[ ]

Install
[ ]

Networking
[ ]

Observability
[ ]

Performance
[ ]

SMI Policy
[ ]

Security
[ ]

Sidecar Injection
[ ]

Tests
[ ]

Upgrade
[ ]

Other
[X]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? no

Did you notify the maintainers and provide attribution?

Is this a breaking change? no

Codecov Report

Merging #4172 (46a852e) into main (9574661) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4172      +/-   ##
==========================================
- Coverage   69.86%   69.82%   -0.04%
==========================================
  Files         212      212
  Lines       11583    11583
==========================================
- Hits         8092     8088       -4
- Misses       3438     3442       +4
  Partials       53       53

Flag
Coverage Δ

unittests
69.82% <100.00%> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/osm-bootstrap/osm-bootstrap.go
32.20% <ø> (ø)

pkg/k8s/events/events.go
66.17% <ø> (ø)

pkg/crdconversion/crdconversion.go
71.42% <100.00%> (-4.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9574661...46a852e. Read the comment docs.

authors: codecov-commenter snehachhabria


text:
Add atomic registry

Add atomic registry to the VM

+1 if you will expose it

+1

+1

authors: jfmatth jorgemoralespou marekjelen ostests

repo: openshift-evangelists/vagrant-origin


text:
[main] Use target/midstream branch instead of upstream tag to infer tag

This caused https://github.com/openshift-knative/eventing/pull/280

/assign @Cali0707 @creydr

repo: openshift-knative/eventing


text:
tools: add license boilerplate

Legally speaking probably redundant, but let's be consistent.

/hold

holding to update the new tool added in https://github.com/openshift-kni/numaresources-operator/pull/653

/hold cancel
/cc @Tal-or

repo: openshift-kni/numaresources-operator


text:
exception with latest run_latest_build.sh

This form is for bug reports and feature requests. Major features will go through a spec process.
Bug:
# apb list
Exception occurred! unsupported operand type(s) for +: 'NoneType' and 'str'
What happened:
just ran run_latest_build.sh.
it throws a error as below
What you expected to happen:
should list the apbs
How to reproduce it:
download and run run_latest_build.sh
33ba88f3e527ef07f103de1956ee8411  run_latest_build.sh
asb pod's log:
[2018-04-29T21:09:44.898Z] [DEBUG] - set spec: 3f85c20e073a9c761d3f8560b4c5180b
[2018-04-29T21:09:44.936Z] [DEBUG] - set spec: 9f7da06f179b895a8ee5f9a3ce4af7ef
[2018-04-29T21:09:44.959Z] [DEBUG] - set spec: 1dd62d51c52cc2ac404d58abc0c8fa94
[2018-04-29T21:09:44.969Z] [DEBUG] - set spec: 60836f0ce3bd7d325587211dd7791f5b
[2018-04-29T21:09:44.984Z] [DEBUG] - set spec: f86f8e54b99f9332e7610df228fc11d3
[2018-04-29T21:09:45.091Z] [DEBUG] - set spec: 411c51353e6605302235d3379de3ebd0
[2018-04-29T21:09:45.096Z] [DEBUG] - set spec: aff6d7bb9c7f57c9ce8b742228e4caa3
[2018-04-29T21:09:45.404Z] [DEBUG] - set spec: ddd528762894b277001df310a126d5ad
[2018-04-29T21:09:45.427Z] [DEBUG] - set spec: b95513950bb3f132de25d58fb75f8dca
[2018-04-29T21:09:45.443Z] [DEBUG] - set spec: c4ef25f81a0c275c8f1bee1b736f3068
[2018-04-29T21:09:45.74Z] [DEBUG] - set spec: a946a139a9308a59bf642ac52b4ba317
[2018-04-29T21:09:45.745Z] [DEBUG] - set spec: 6df7afbd132c094704b4a8bfd44378c0
[2018-04-29T21:09:45.825Z] [DEBUG] - set spec: c65fbd4e701cb71d74fd2cc35e14432b
[2018-04-29T21:09:45.984Z] [DEBUG] - set spec: 9519424a4ffdd1d2f77797987166a9f8
[2018-04-29T21:09:45.992Z] [DEBUG] - set spec: f6c4486b7fb0cdac4b58e193607f7011
[2018-04-29T21:09:46.108Z] [DEBUG] - set spec: d889087d9f39d5b09a06842518f5d9e2
[2018-04-29T21:09:46.299Z] [DEBUG] - set spec: 21e1bfbf09d5a7fb8a54042f504f26be
[2018-04-29T21:09:46.501Z] [DEBUG] - set spec: 2c79572fbf83125231198451c26e7cf9
[2018-04-29T21:09:46.7Z] [DEBUG] - set spec: 1882ffca5d72b1084e9107e3485f5066
[2018-04-29T21:09:46.903Z] [DEBUG] - set spec: 880ef3b4ba5fa8d80908e9974228e603
[2018-04-29T21:09:47.1Z] [DEBUG] - set spec: eebf92c7670f30007a4b8db3a8166d5c
[2018-04-29T21:09:47.299Z] [DEBUG] - set spec: 4408b368ae2f09a5358340a2a10e197b
[2018-04-29T21:09:47.5Z] [DEBUG] - set spec: 693cb128e68365830c913631300deac0
[2018-04-29T21:09:47.699Z] [DEBUG] - set spec: d4684c1b61cd094af9aa6ec4a90b4d69
[2018-04-29T21:09:47.899Z] [DEBUG] - set spec: f4509733ca0636df3d69b6af53260160
[2018-04-29T21:09:48.1Z] [DEBUG] - set spec: 5d0062cce443e5ecb8438ca5f664dcd7
[2018-04-29T21:09:48.361Z] [DEBUG] - set spec: ca91b61da8476984f18fc13883ae2fdb
[2018-04-29T21:09:48.541Z] [DEBUG] - set spec: bbce85a73bfc09a1136a587a7a058b14
[2018-04-29T21:09:48.7Z] [DEBUG] - set spec: ba9c2d4db404ce97111bea80225de968
[2018-04-29T21:09:48.9Z] [DEBUG] - set spec: 0e991006d21029e47abe71acc255e807
[2018-04-29T21:09:49.099Z] [DEBUG] - set spec: f755257efed3e3d43c8b82afd0db1181
[2018-04-29T21:09:49.512Z] [DEBUG] - set spec: fd9b21a9caa8bf8b42b27bb0c90d3b74
[2018-04-29T21:09:49.518Z] [DEBUG] - set spec: 595db86e75325f430afa4fa3f7d69af9
[2018-04-29T21:09:49.724Z] [DEBUG] - set spec: 67042296c7c95e84142f21f58da2ebfe
[2018-04-29T21:09:49.901Z] [DEBUG] - set spec: 1830d9181b425e281b36efbf22f378a4
[2018-04-29T21:09:50.099Z] [DEBUG] - set spec: 1dda1477cace09730bd8ed7a6505607e
[2018-04-29T21:09:50.301Z] [DEBUG] - set spec: 135bd0df0401e2fdd52fd136935014fb
[2018-04-29T21:09:50.5Z] [NOTICE] - Broker successfully bootstrapped on startup
[2018-04-29T21:09:50.5Z] [DEBUG] - RefreshInterval: 10m0s
[2018-04-29T21:09:50.5Z] [DEBUG] - calling NewSecureServingOptions
[2018-04-29T21:09:50.63Z] [DEBUG] - Creating k8s apiserver
ERROR: logging before flag.Parse: I0429 21:09:50.632362       1 serve.go:89] Serving securely on [::]:1338
[2018-04-29T21:09:50.632Z] [NOTICE] - Listening on https://[::]:1338
[2018-04-29T21:09:50.632Z] [NOTICE] - Ansible Service Broker Starting

@SaravanaStorageNetwork this happens when the apb tools fails to communicate to the broker over the route.
# apb list
Exception occurred! unsupported operand type(s) for +: 'NoneType' and 'str'

try using the endpoint instead:
apb list --broker $(oc get endpoints --no-headers | grep asb | grep -w 1338 | awk '{ print $2 }')

The error message needs to be improved :)

authors: SaravanaStorageNetwork rthallisey

repo: openshift/ansible-service-broker


text:
Docs

New doc designed around setting up a development environment.

/lgtm

authors: c-e-brumm tparikh

repo: openshift/certman-operator


text:
OCPBUGS-25947: Fix changing load balancer scope

This PR reverts commit a5df7a381a10c965db03889fbc46a62f0bbd073d, just like upstream.
It also updates the GoogleCloudPlatform/k8s-cloud-provider library to v1.25.0 and updates associated API calls.
Backporting this change to 4.15 since changing scope for an Ingress was broken.

/jira refresh

/approve
/lgtm
/label backport-risk-assessed

/test verify-commits

After building a 4.15 cluster with this PR applied, changing the scope on an Ingress object updates the router.
❯ diff router-foo-{before,after}.yaml
5d4
<     cloud.google.com/load-balancer-type: Internal
9d7
<   - gke.networking.io/l4-ilb-v1
23c21
<   resourceVersion: "43934"
---
>   resourceVersion: "45014"
53,54c51,52
<      ingress:
<      - ip: 34.170.87.50
---
>     ingress:
>     - ip: 34.170.87.50

/label qe-approved

/label cherry-pick-approved

/lgtm

authors: JoelSpeed nrb sunzhaohua2

repo: openshift/cloud-provider-gcp


text:
Fix AttributeError during release:gen-payload

Context here

/lgtm

authors: joepvd locriandev

repo: openshift/doozer


text:
[hiveutil] Add --azure-cloud-name parameter.

To make generating objects easier, eg.
./bin/hiveutil create-cluster abutcher-azgov \
  --cloud=azure \
  --azure-base-domain-resource-group-name=os4-common \
  --region=usgovvirginia \
  --azure-cloud-name=AzureUSGovernmentCloud

Looks reasonable to me.
/lgtm
/hold
unhold if you're ready for this to go.

/test e2e

Rebased since https://github.com/openshift/hive/pull/1617 merged and I had a different comment in this PR

Good to go though
/hold cancel

/lgtm

repo: openshift/hive


text:
OCPBUGS-18127: Ensure machineTemplate name length respects RFC1123 spec

What this PR does / why we need it:
follow-up of https://github.com/openshift/hypershift/pull/2956
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/jira refresh

/hold
How will old templates be garbage collected?

/hold cancel

/hold
https://github.com/openshift/hypershift/pull/2981

/hold cancel
https://github.com/openshift/hypershift/pull/2988 is fixing high HO reads issue

/approve

/test e2e-kubevirt-aws-ovn

authors: csrwng muraee sjenning

repo: openshift/hypershift