text:
After deleting a managed node group from the eks_managed_node_groups cluster security group was also deleted.

Description
Please provide a clear and concise description of the issue you are encountering, and a reproduction of your configuration (see the examples/* directory for references that you can copy+paste and tailor to match your configs if you are unable to copy your exact configuration). The reproduction MUST be executable by running terraform init && terraform apply without any further changes.
If your request is for a new feature, please use the Feature request template.

[ x ] ✋ I have searched the open/closed issues and my issue is not listed.

⚠ Note
Before you submit an issue, please perform the following first:

Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
Re-initialize the project root to pull down modules: terraform init
Re-attempt your terraform plan or apply and check if the issue still persists

Versions

Module version [Required]:

Terraform version: v1.1.7

Provider version(s): 3.72.0

Module version: 18.0.6

Reproduction Code [Required]

Steps to reproduce the behavior:

Not using workspaces

Didn't clear local cache

Delete a managed node group from eks_managed_node_groups then run terraform plan and terraform apply
Expected behavior

Delete a managed node group from eks_managed_node_groups without any side effects.
Actual behavior

After deleting a managed node group from the eks_managed_node_groups cluster security group was also deleted.
Terminal Output Screenshot(s)

Additional context

Its not the cluster security group that is deleted, its the security group that is created with each node group https://github.com/terraform-aws-modules/terraform-aws-eks/blob/d969e94bbea89ed616713bdab849f042ceda87ac/modules/eks-managed-node-group/main.tf#L362

Its not the cluster security group that is deleted, its the security group that is created with each node group
https://github.com/terraform-aws-modules/terraform-aws-eks/blob/d969e94bbea89ed616713bdab849f042ceda87ac/modules/eks-managed-node-group/main.tf#L362

Thanks for the reply, I created a new eks cluster and try to reproduce the issue, but the auto-delete EKS control plane sg issue is not happening, so I try to find a clue from the cloud trail, turns out the sg was accidentally deleted before we delete a managed node group from the eks_managed_node_groups. sorry for opening the issue.

authors: bryantbiggs xiayanzheng

repo: terraform-aws-modules/terraform-aws-eks


text:
Error when creating a read replica

This modules returns an error while creating a Read Replica in both cases, same region and Cross-Region.
In order to create a replica the variable replicate_source_db it must be populated. I.e:
replicate_source_db = "${module.db.this_db_instance_arn}"

The aws_rds_resource doesn't require of username and password variables when being an instance of a read replica (https://www.terraform.io/docs/providers/aws/r/db_instance.html):
username - (Required unless a snapshot_identifier or replicate_source_db is provided) Username for the master DB user.
Trying to use this module without Username or password fails on terraform init:
Error: module "db-crossregion-replica": missing required argument "username"

Error: module "db-crossregion-replica": missing required argument "password"

Trying to add an empty password and get the following error on terraform plan:
Error: Error running plan: 1 error(s) occurred:

* module.db-replica.module.db_instance.local.this_db_instance_password: local.this_db_instance_password: Resource 'aws_db_instance.this' does not have attribute 'password' for variable 'aws_db_instance.this.*.password'

So password needs to be populated with some value and an error is returned on terraform apply:
Error: Error applying plan:

1 error(s) occurred:

* module.db-replica.module.db_instance.aws_db_instance.this: 1 error(s) occurred:

* aws_db_instance.this: error modifying DB Instance (demodb-replica): InvalidParameterCombination: Cannot change master user password on an RDS Postgres Read Replica because it uses physical replication and therefore cannot differ from its parent.
	status code: 400, request id: 794f2fc6-9f70-442a-acc6-5724b81b2d0c

Expected result
A Read Replica is created without errors
Actual result
Replica is created but it returns an error.

Same error here, Replica created but got error  Cannot change master user password on an RDS Postgres Read Replica because it uses physical replication and therefore cannot differ from its parent
After additional run of terraform apply  it finish without error.

I believe this is what @dpiddockcmp has fixed in #108 and it has been released as v1.27.0 an hour ago.
Please let us know if there is something still missing (or not working as expected).

source: gharchive/issue

authors: adv4000 antonbabenko carlosfrancia

repo: terraform-aws-modules/terraform-aws-rds

license_type: permissive

license_source: github-api


text:
Added delete timeout for db_option_group

Fixed #144

v2.13.0 has been just released for Terraform 0.12 users.

source: gharchive/pull-request


text:
Q: Workaround for computed resource output as shared key?

it cannot use a computed resource output (e.g. random_password.my_shared_key.result) as input for the shared key
Is this an anti-pattern or should the module be able to support that?

It probably makes sense to always store any computed resource ouput password as a secret outside of terraform and then use a data source.

There is a long-standing issue in Terraform - https://github.com/hashicorp/terraform/issues/4149 - which means that users need to create such resources in advance using -target and then run terraform apply to create the rest of resources.

authors: antonbabenko naseemkullah


text:
Fix deprecation warning

Warnings:

aws_iam_instance_profile.s3_readonly: "roles": [DEPRECATED] Use role instead. Only a single role can be passed to an IAM Instance Profile

Thank you for this improvement, v1.3.0 has been just released.

authors: JimiHFord antonbabenko

license_source: bigquery


text:
chore: update examples for int tests

examples use current modules for int tests
add sample label to example for int test
Fixes #254

Thanks for the PR! 🚀
Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

⚠check_terraform
Failed Terraform check. More details below.

Running terraform fmt
examples/cloudrun/main.tf
--- old/examples/cloudrun/main.tf
+++ new/examples/cloudrun/main.tf
@@ -31,7 +31,7 @@
  ssl                             = var.ssl
  managed_ssl_certificate_domains = [var.domain]
  https_redirect                  = var.ssl
-  labels                          = {"Example Label"="Cloudrun Example"}
+  labels                          = { "Example Label" = "Cloudrun Example" }

  backends = {
    default = {
Error: terraform fmt failed with exit code 3
Check the output for diffs and correct using terraform fmt <dir>

authors: apeabody comment-bot-dev


text:
chore(deps): update common-dev-assets digest to 8481592

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
73ae5e3 -> 8481592

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.4.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


text:
fix: update ocp_version description and only allow latest instead of default

Description
The logic has always actually selected the latest version, and not the default version. So updating the variable description and removing support for passing default as a value, and replaced it with latest.
Technically its a breaking change since we have removed support for something, so we should probably bump the major version
No release required

[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI-related update (pipeline, etc.)
[ ] Other changes that don't affect Terraform code

Release required

[ ] Bug fix (patch release (x.x.X): Change that fixes an issue and is compatible with earlier versions)
[ ] New feature (minor release (x.X.x): Change that adds functionality and is compatible with earlier versions)
[x] Breaking change (major release (X.x.x): Change that is likely incompatible with previous versions)

Release notes content
Replace this text with information that users need to know about the bug fixes, features, and breaking changes. This information helps the merger write the commit message that is published in the release notes for the module.

Checklist for reviewers

[ ] The PR references a GitHub issue.
[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

Merge by using "Squash and merge".

Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.
The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

authors: ocofaigh terraform-ibm-modules-ops


text:
chore(deps): update module github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper to v1.28.4

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.28.3 -> v1.28.4

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.28.4
Compare Source
Bug Fixes

deps: update module golang.org/x/crypto to v0.19.0 (#757) (72d3f03)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.1.8 :tada:
The release is available on:

GitHub release
v1.1.8

Your semantic-release bot :package::rocket:


text:
ci: fix releaserc

Description
Please include a summary of the change and which issue is fixed. Also, please include the motivation and context for the change. List any dependencies that are required for this change.
Check the relevant boxes:

[ ] Bug fix (nonbreaking change that fixes an issue)
[ ] New feature (nonbreaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI related update (pipeline, etc.)

Checklist

[ ] If relevant, a test for the change has been added or updated as part of this PR.
[ ] If relevant, documentation for the change has been added or updated as part of this PR.

Merge

Merge using "Squash and merge".
Make sure to use a relevant conventional commit message that is based on the PR contents. The commit message determines whether a new version of the modules needs to be released, and if so, which semver number to use).

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

repo: terraform-ibm-modules/terraform-ibm-cos


text:
chore(deps): update module github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper to v1.10.12

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.10.10 -> v1.10.12

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.10.12
Compare Source
Bug Fixes

deps: update module github.com/ibm/platform-services-go-sdk to v0.41.0 (#582) (77a309d)

v1.10.11
Compare Source
Bug Fixes

deps: update module github.com/gruntwork-io/terratest to v0.43.8 (#581) (5b1468a)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


text:
chore(deps): update common-dev-assets digest to 223c0bd

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
fafc30b -> 223c0bd

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

repo: terraform-ibm-modules/terraform-ibm-hpc


text:
chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
95f6c1e -> 81754c2

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.41.4 -> v1.41.5

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.41.5
Compare Source
Bug Fixes

deps: update module github.com/ibm/vpc-go-sdk to v0.62.0 (#896) (f84c9e7)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 1.8.12 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


text:
chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
cf15dc9 -> ede5101

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
minor
v1.30.8 -> v1.31.6

go (source)
toolchain
minor
1.21.3 -> 1.22.2

terraform-ibm-modules/common-pipeline-assets
action
minor
v1.21.9 -> v1.22.0

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.31.6
Compare Source
Bug Fixes

deps: update gomod (#802) (efcfa2f)

v1.31.5
Compare Source
Bug Fixes

ensure all stack members are listed in the stack order (#800) (04e23c7)

v1.31.4
Compare Source
Bug Fixes

enhance error message (#799) (0409a07)

v1.31.3
Compare Source
Bug Fixes

update log messages (#798) (c1f41db)

v1.31.2
Compare Source
Bug Fixes

minor projects fixes (#797) (cfe0774)

v1.31.1
Compare Source
Bug Fixes

update stack input handling (#796) (99dbf4e)

v1.31.0
Compare Source
Features

alpha projects/stacks support (#793) (d0a6052)

terraform-ibm-modules/common-pipeline-assets (terraform-ibm-modules/common-pipeline-assets)
v1.22.0
Compare Source
Features

add pages release action (#681) (f06fe28)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

:tada: This PR is included in version 1.10.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


text:
chore(deps): update common-dev-assets digest to 9b0b7af

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
a95caad -> 9b0b7af

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


text:
chore(deps): update common-dev-assets digest to 9211b0b

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
9d04954 -> 9211b0b

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


text:
chore(deps): update module github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper to v1.3.4

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.3.2 -> v1.3.4

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper
v1.3.4
Compare Source
Bug Fixes

set API_DATA_IS_SENSITIVE=true which is required by restapi provider (#310) (2afe543)

v1.3.3
Compare Source
Bug Fixes

deps: update module github.com/ibm/go-sdk-core/v5 to v5.12.0 (#309) (6aad3c8)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


text:
feat: subnet output created to be consumed by terraform-base-ocp-vpc module

Description
This is to simplify the subnet output to be consumed by terraform-base-ocp-vpc module.
Refer Issue 399
Types of changes in this PR
New output value is added.
No release required

[ ] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI-related update (pipeline, etc.)
[x] Other changes that don't affect Terraform code

Release required

[ ] Bug fix (patch release (x.x.X): Change that fixes an issue and is compatible with earlier versions)
[x] New feature (minor release (x.X.x): Change that adds functionality and is compatible with earlier versions)
[ ] Breaking change (major release (X.x.x): Change that is likely incompatible with previous versions)

Release notes content
Replace this text with information that users need to know about the bug fixes, features, and breaking changes. This information helps the merger write the commit message that is published in the release notes for the module.

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[x] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

Merge by using "Squash and merge".

Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.
The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).

I don't think the word cluster should be used anywhere here. This is the VPC module which is completely independent of any cluster. All we are doing is outputting subnets in a particular format

Thank you for mentioning this @ocofaigh. I will remove the word cluster.

:tada: This PR is included in version 4.2.0 :tada:
The release is available on:

GitHub release
v4.2.0

Your semantic-release bot :package::rocket:

authors: imprateeksh terraform-ibm-modules-ops


text:
chore(deps): update common-dev-assets digest to dede5d0

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
e26eae2 -> dede5d0

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.1.4 :tada:
The release is available on:

GitHub release
v1.1.4

Your semantic-release bot :package::rocket:


text:
chore(deps): update module github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper to v1.2.16

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.2.15 -> v1.2.16

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper
v1.2.16
Compare Source
Bug Fixes

update output of failed consistency test to show exact diff (#227) (7e76e6e)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 5.2.2 :tada:
The release is available on:

GitHub release
v5.2.2

Your semantic-release bot :package::rocket:


text:
chore(deps): update common-dev-assets digest to 1f71760

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
13ad070 -> 1f71760

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 6.0.0 :tada:
The release is available on:

GitHub release
v6.0.0

Your semantic-release bot :package::rocket:


text:
chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

github.com/gruntwork-io/terratest
require
patch
v0.46.15 -> v0.46.16

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.35.1 -> v1.35.2

terraform-ibm-modules/common-pipeline-assets
action
patch
v1.22.3 -> v1.22.4

Release Notes

gruntwork-io/terratest (github.com/gruntwork-io/terratest)
v0.46.16
Compare Source
Description

Updated github.com/hashicorp/go-getter from 1.7.4 to 1.7.5.

Related links

https://github.com/gruntwork-io/terratest/pull/1415

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.35.2
Compare Source
Bug Fixes

bug, fail test on any deploy error (#833) (79923b8)

terraform-ibm-modules/common-pipeline-assets (terraform-ibm-modules/common-pipeline-assets)
v1.22.4
Compare Source
Bug Fixes

added support for trailing spaces in pipeline run command (#699) (215fa1a), closes #701

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

:tada: This issue has been resolved in version 3.0.0 :tada:
The release is available on:

GitHub release
v3.0.0

Your semantic-release bot :package::rocket:


text:
fix(deps): update terraform-module

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cbr/ibm (source)
module
patch
1.23.1 -> 1.23.5

terraform-ibm-modules/cos/ibm (source)
module
minor
8.9.1 -> 8.10.1

terraform-ibm-modules/event-notifications/ibm (source)
module
patch
1.9.0 -> 1.9.4

Release Notes

terraform-ibm-modules/terraform-ibm-cbr (terraform-ibm-modules/cbr/ibm)
v1.23.5
Compare Source
Bug Fixes

Set enforcement mode as disabled for EN by default, as SMTP API does not support report mode.(#497) (e76f4b4)

v1.23.4
Compare Source
Bug Fixes

mqcloud is removed from default target service list and fscloud doc is updated (#495) (5af76ee)

v1.23.3
Compare Source
Bug Fixes

fixed bug where global deny target service details could potentially be missing consumer customizations (#489) (e902247)

v1.23.2
Compare Source
Bug Fixes

added fix to ensure only service-group-id should be specified when the pseudo service IAM is used (#487) (8108e45)

terraform-ibm-modules/terraform-ibm-cos (terraform-ibm-modules/cos/ibm)
v8.10.1
Compare Source
Bug Fixes

deps: update required_provider to latest for the deployable architecture solution (#690) (214b30b)

v8.10.0
Compare Source
Features

support to create service credentials in secrets manager (#687)This enhancement will enable users to create service credentials in an existing secrets manager for a COS instance. Users can choose to use an existing secret group or create a new one for the service credentials. (b10af71)

v8.9.2
Compare Source
Bug Fixes

deps: updated KMS module to 4.15.2 in the bucket DAs (#685) (412cdb5)

terraform-ibm-modules/terraform-ibm-event-notifications (terraform-ibm-modules/event-notifications/ibm)
v1.9.4
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/kms-all-inclusive/ibm to v4.15.5 (#269) (a128ac9)

v1.9.3
Compare Source
Bug Fixes

deps: update terraform-module (#261) (a2d55d2)

v1.9.2
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#264) (4b107b5)

v1.9.1
Compare Source
Bug Fixes

deps: update terraform-module (#260) (21d69a2)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This issue has been resolved in version 1.7.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

repo: terraform-ibm-modules/terraform-ibm-scc


text:
chore(deps): update module github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper to v1.41.1

This PR contains the following updates:

Package
Type
Update
Change

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
minor
v1.40.4 -> v1.41.1

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.41.1
Compare Source
Bug Fixes

deps: update gomod (#885) (092ec2a)

v1.41.0
Compare Source
Features

Increase default stack poll time to 60sec and expose as option (#883) (b31c896)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

ℹ Artifact update notice
File name: tests/go.mod
In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

3 additional dependencies were updated

Details:

Package
Change

github.com/IBM-Cloud/power-go-client
v1.8.1 -> v1.8.3

github.com/IBM/go-sdk-core/v5
v5.17.5 -> v5.18.0

github.com/IBM/platform-services-go-sdk
v0.69.2 -> v0.69.3

/run pipeline

:tada: This PR is included in version 1.2.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


text:
fix(deps): update icr.io/appcafe/open-liberty/samples/getting-started:latest docker digest to fd04ce5

This PR contains the following updates:

Package
Update
Change

icr.io/appcafe/open-liberty/samples/getting-started
digest
b99e5af -> fd04ce5

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

:tada: This PR is included in version 1.4.6 :tada:
The release is available on:

GitHub release
v1.4.6

Your semantic-release bot :package::rocket:


text:
OCM-201: Add support for mapping_method

Added mapping_method support.

Validation
idp create
idp read
subsytem tests

Considering ROSA CLI flow SGTM

LGTM

authors: gdbranco oriAdler sagidayan

repo: terraform-redhat/terraform-provider-ocm


text:
add google idp test case and additional fixes

/lgtm

/approve

/lgtm

authors: amalykhi shellymiron xueli181114


text:
SW-1603 Detect collision of suggested species name

If species 1 and 2 exist, and species 2 has an incorrect name (misspelled or
synonym) that should be changed to the same name as species 1, return HTTP 409
(Conflict) with a descriptive error message rather than an internal server error
when the user tries to accept the suggested edit.
Eventually we'll most likely want to add logic to merge the two species, but
until then, we should at least show a meaningful error message.

Current dependencies on/for this PR:

main

PR #713   👈

This comment was auto-generated by Graphite.

repo: terraware/terraware-server


text:
SW-5327 Updated all modules view text

Updated copy text
Formatted

#2600  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tommylau523 and the rest of your teammates on  Graphite

Merge activity

May 9, 3:12 PM EDT: @tommylau523 started a stack merge that includes this pull request via Graphite.

repo: terraware/terraware-web


text:
SW-2145 Implement page that accepts withdrawn quantity information grouped by Species/Batch-Number

This needs a new web-component version to allow sending a value to the table function

Looks good for now - if you want to iterate on this since the PR is getting big.

I will merge this and create a following PR with styles


text:
Create badge component with label, backgroundColor, borderColor args

Current dependencies on/for this PR:

#475  👈
main

This stack of pull requests is managed by Graphite.

publish rc

Are all badges currently one size?
Changes are clean and straight forward, looks good 👍

Currently, I think so. Only two places where they exist (that I'm aware of) for now. Can easily modify this later if we need more customization

Are all badges currently one size?
Changes are clean and straight forward, looks good 👍

Currently, I think so. Only two places where they exist (that I'm aware of) for now. Can easily modify this later if we need more customization

We have badges in some existing places (accessions status, draft badge in planting sites list) - all of them have custom implementations.. will be good to replace them all with this badge. I believe the size should work for those use-cases.

authors: karthikbtf nickgraz

repo: terraware/web-components


text:
Introduces layerappearance clickable property

This introduces the clickable property for the layerappearance model. The property can be used to set clickable and hoverable configs separately.
This change comes in handy when working with the newly introduced BasiGX hoverClick plugin.

Migrations must be placed in the corresponing project implementation (if needed).

authors: dnlkoch jansule

repo: terrestris/shogun-core


text:
Fix the ui displaying last year's instructors

this is also good on explore page now

Looking Amazing


text:
Add content to Testimonial Page (S)

As a user I want to read testimonial from past clients so that I can read their success stories.
Acceptance Criteria
A/C 1: Displays 'Testimonials' content.
Implementation Notes
Note 1: Add content to the page
See the content linked below.
https://docs.google.com/document/d/19FITnh3Ilh8e_sErc1ToVEvHD5tRNdxi_rXlXgx5lj0/edit
I would recommend using stock images of people but their faces aren't showing.  Maybe images of the bottom half of the face.

repo: tersiakoetzee/Hope-Again-Recovery

license: ISC


text:
Rename blacklist -> disallowed

Fixes #1556

Coverage remained the same at 85.972% when pulling 3194a852b8c823f24d6ce959bec08a70aec94af0 on fix-1556-rename-compressionBlacklist into 33fafec25ee281ef9cf4af3555d1b4999c2d3781 on master.

authors: HipsterBrown coveralls

license: mit


text:
wasm32 support

File loading does not work and is kind of out of the scope for now I think, audio data should be loaded as frames (the best way to do this is download the audio data using fetch, decode it using WebAudio and play).
This is blocked by aspenluxxxy/nanorand-rs#19.
Demo: https://first-kira-web-demo.surge.sh/
(wasm file and audio data loading start when clicking on play)

In wasm, nanorand uses the default time-based random generator. However, it provides the ability to use the getrandom dependency to obtain higher quality entropy from the browser. While it is not absolutely needed in our context, it is better practice to have good entropy and using getrandom allows us to not have to wait for a new nanorand release with the fix in the PR mentioned above, hence why I added it.

Honestly, it's usually recommended to use getrandom anyways. It's just not default because it's not a required dependency.

authors: Moxinilian aspenluxxxy

repo: tesselode/kira


text:
Recognition on x32

Environment

Tesseract Version: 4.0.0-beta4
Platform: Ubuntu 16.04 x32

Current Behavior:
Bad text recognition on x32-bit server ;C
Expected Behavior:
Good recognition.
Suggested Fix:
Additional building flags ?

Support for x32 might indeed be interesting, because it should be significantly faster than 32 bit code and could even be slightly faster than 64 bit code because of better cache usage. I expect that it will require some work on the Tesseract code base to fix all portability issues. See https://wiki.debian.org/X32Port for a few first hints.

@qb1t0, is the recognition on other installations better? Could you provide an example for the bad text recognition (image, command line, results)?

With the test image from https://github.com/tesseract-ocr/tessdata/issues/108, I get the same results for x32 and for x86_64 when I add --psm 6.
There is a difference when running tesseract test.tif -: x32 shows the well know assertion contains_unichar_id(unichar_id):Error:Assert failed:in file src/ccutil/unicharset.h, line 509

@zdenop Please label as Feature Request.

I think it can be closed, as x32 and x86_64 deliver the same results.

authors: Shreeshrii qb1t0 stweil

repo: tesseract-ocr/tesseract


text:
LSTM Box configuration missing documentation for box file generation

I am trying to understand how to generate box files using tesseract. I am following the Making box files section in the https://tesseract-ocr.github.io/tessdoc/TrainingTesseract-4.00.html#making-box-files link.
I could not find any reference to lstmbox configuration. Can you please provide me some direction?
Can tesseract be trained to ocr english handwritting?

Please see https://github.com/tesseract-ocr/tesstrain/wiki

authors: Shreeshrii seshubabuarava


text:
New Oracle FREE support

Is this something you want in the existing module or in a new module? Any reason why its not supported yet? Want to add the new Oracle image as a compatibility in the existing OracleContainer instead? (besides the APEX port it seems to work).

Hi @ecki, I wonder if you are able to continue working on this PR? Hope everything is doing well.

Yes but I probably just close it, I am not sure why I made my own copy when in principle only the image name changes.
btw free starts really fast, it only needs 4mins for downloads, which is then (hopefully) cached.

Implement by #7749 (for inofficial image)

authors: ecki eddumelendez

repo: testcontainers/testcontainers-java


text:
Update google-cloud-bigtable to 2.40.0

About this PR
📦 Updates com.google.cloud:google-cloud-bigtable from 2.5.3 to 2.40.0
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.cloud", artifactId = "google-cloud-bigtable" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.google.cloud", artifactId = "google-cloud-bigtable" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #323.

repo: testcontainers/testcontainers-scala

license: MIT


text:
🛑 Jira Plugin is down

In 49fb6f6, Jira Plugin (https://jira.testomat.io/) was down:

HTTP code: 502
Response time: 509 ms

Resolved: Jira Plugin is back up in b9a7587.

repo: testomatio/status


text:
transfer repo to nix-community

according to https://nix-community.github.io/#org-owners, I should ping some members from the list.
So @zimbatm @worldofpeace Iwould like to transfer this repo to nix-community (while keeping commits right). Is that ok/fine ?
under what name ? lua2nix ? luarocks2nix ? luarocks-nix

I think luarocks-nix sounds sensible. I'd say the name is up to you, though from the readme I did struggle to figure out how it was nix related. But that's nothing we can't fix once it's in nix-community.

(while keeping commits right).

Everyone will for sure have admin access to the project they maintain.

according to https://nix-community.github.io/#org-owners, I should ping some members from the list.

That does sound correct, but It doesn't seem I can invite you into the org,
It seems that's limited to the owners which don't seem to be information someone who isn't a member can access. We should probably add an induction process to https://nix-community.github.io/ to clear this up.

luarocks-nix converts lua rockspec https://luarocks.org/manifests/openresty/lua-cjson-2.1.0.6-1.rockspec into a nix derivation. That's the program used to generate https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/lua-modules/generated-packages.nix .
I could add a README if needed.

Repo is now moved to nix-community :)

welcome @teto ! :tada:

authors: adisbladis teto worldofpeace zimbatm

repo: teto/luarocks


text:
Protect the $ alias by using a wrapper function

Hi,
I had some problems using your bundle with multiple versions of jQuery loaded.
Feel free to implement it yourself because it looks like I messed with the indentation somehow.
Thanks

Thanks. This is a good idea. I'll take a look in the next week or so. Very busy right now.

I added this myself, being careful with the indentation.

Thanks !

authors: magnetik tetranz


text:
Default values for frozen attrs classes

Base type attribute are initialized as None with the comment that default values can be specified via object processors.
https://github.com/textX/textX/blob/c8a49a2fb286f5ad3f63b5a0a0fb33b8a312849e/textx/metamodel.py#L460-L464
However for frozen attrs classes, object processors are run too late to actually change the value of the attribute, so there is no obvious way to provide a default value for such classes.
One way to solve this would be to filter out any None values when constructing the dictionary passed to __init__ and use the standard mechanisms for default values.
https://github.com/textX/textX/blob/c8a49a2fb286f5ad3f63b5a0a0fb33b8a312849e/textx/model.py#L836-L840
would become
                attrs = {k: v for k, v in attrs.items()
                         if (k in obj.__class__._tx_attrs
                         or k == 'parent')
                         and v is not None}

User have full control over user classes so the obvious and preferred way to provide defaults is in the class constructor. For dynamically created textX classes we don't have other options but to use object processors.

Sounds reasonable. The issue is that currently the defaults provided by the class constructor are not used because TextX sets missing properties explicitly to None. Thats why I suggest filtering out the None values for user classes, though this would be a change to a public API.

Yeah, it would be a change to the way it worked before. I guess that documenting the preferred way of providing the defaults might be a better approach. Something like:
class MyUserClass:
    def __init__(self, first_param, ...):
        self.fist_param = <default value> if first_param is None else first_param
....

This is a good practice anyway as the usage of default values directly in the parameter list can lead to bugs if mutable values are used.

I think best practice is to use a custom sentinel value as default rather than None, so that setting a value to None does not get confused with using the default value.
I discovered this on my own when I was bitten by some subtle bugs during a project at work, but I have since then discovered that attrs uses the same pattern with attr.NOTHING as sentinel value. Though I would always recommend to create your own sentinel value rather than reusing the sentinel value of another project. I just found this blog post which also recommends this design pattern.
It would be great if there was a way to ask textx to not set missing values to None, in order to create compatibility with attrs and enable the user to use their custom sentinel value for defaults.

Sounds like a good idea. I think it would be relatively straightforward to implement it as an optional parameter to model_from* where the default value may be None so it stays backward compatible.

OTOH, textX will only set value to None if it is missing in the input so the only benefit of providing sentinel value would be if user-classes are also instantiated by the user code outside of textX. But, if you think it would be usable I think it would be ok for textX to provide it.

authors: igordejanovic markusschmaus

repo: textX/textX


text:
Feature suggestion: Inclusion of Just Not Sorry

Observing https://github.com/defmethodinc/just-not-sorry would this be a good feature lint?

You can create a rule using just-not-sorry/src/warnings/phrases.json
Docs: https://textlint.github.io/docs/rule.html
textlint's core does not includes rule as built-in.

authors: BrandonKMLee azu

repo: textlint/textlint


text:
Number of bakers

Hi there,
I'd like to configure a single baker - not three.
Looking here I'm not sure how to configure this, but I'm guessing its possible.
Thanks,
Mike

Hi,
try override bakers.hjson with one baker, that should do it.
BUT...
I really do not recommend to do that. Latest version of octez have trouble to run with single baker. It was possible prior v20 iirc. But in latest versions octez is sometimes too fast and it bakes blocks in advance which gets denied by node and the sandboxed chain gets stuck because there is no other baker to baker round 2.

authors: cryi mweichert

repo: tez-capital/tezbox


text:
Support to update hosts file

Suggestion to update hosts file the same way as navcontainerhelper does. Reason for asking is the network issue on Windows 1809 resulting in new ip-address for the containers after each reboot. The updatehosts option from navcontainerhelper resolves this.
Steps needed:
Create a volume to c:\windows\system32\drivers\etc

Copy updatehosts.ps1 to the my folder
File could be downloaded from https://raw.githubusercontent.com/Microsoft/navcontainerhelper/master/ContainerHandling/updatehosts.ps1 (and let's hope Freddy doesn't change that location)
Add a line to AdditionalOutput.ps1 to run updatehosts:
. (Join-Path $PSScriptRoot "updatehosts.ps1") -hostsFile "c:\driversetc\hosts" -hostname bcsandbox -ipAddress $ip
Only possible when you support navcontainerhelper as requested in the other issue.

@ajkauffmann I've implemented a more generic solution that not only works with NAV/BC containers and also is better at cleaning up (I hope ;) ). Give it a try when alpha6 is released and let me know if you like it

authors: ajkauffmann tfenster

repo: tfenster/BCinaB


text:
Destroy method doesn't wait for client shutdown

knex.destroy() resolves before the clients in the pool are actually destroyed. I believe the destroyRawConnection method should listen for the relevant client event (usually end) and only resolve when all clients have emitted an end/close event.
Seems like quite a major oversight that knex doesn't cleanly shut down.

Can't reproduce... did you try on 0.12.6?
knex = require('knex')({ client: 'pg', connection: 'postgres:///objection_test'});
Promise.all([knex.raw('select 1'), knex.raw('select 1')])
  .then(() => knex.destroy())
  .then(() => console.log("==================== DESTROY RESOLVED ======================"))

>   knex:pool INFO pool postgresql:pg:client0 - dispense() clients=1 available=2 +1m
  knex:client acquired connection from pool: __knexUid1 +1ms
  knex:pool INFO pool postgresql:pg:client0 - dispense() clients=1 available=1 +2ms
  knex:client acquired connection from pool: __knexUid2 +0ms
  knex:query select 1 +2ms
  knex:bindings [] +0ms
  knex:query select 1 +1ms
  knex:bindings [] +0ms
  knex:client releasing connection to pool: __knexUid1 +1ms
  knex:pool INFO pool postgresql:pg:client0 - dispense() clients=0 available=1 +0ms
  knex:client releasing connection to pool: __knexUid2 +1ms
  knex:pool INFO pool postgresql:pg:client0 - dispense() clients=0 available=2 +0ms
  knex:pool INFO pool postgresql:pg:client0 - draining +0ms
  knex:pool INFO pool postgresql:pg:client0 - force destroying all objects +0ms
==================== DESTROY RESOLVED ======================

Closing for now until there is way to reproduce...

authors: elhigu simontabor

repo: tgriesser/knex


text:
Flaky Oracle test

Environment
Knex version: 0.17.0
Database + version: Oracle
Node 6
From CI:
 1) oracle | oracledb
       knex.migrate
         knex.migrate.up
           should only run the first migration if no migrations have run:
      AssertionError: expected [] to have a length of 1 but got 0
      + expected - actual
      -0
      +1

      at /home/travis/build/tgriesser/knex/test/integration/migrate/index.js:534:38
  From previous event:
      at Builder.Target.then (lib/interface.js:38:24)
      at knex.migrate.up.then (test/integration/migrate/index.js:533:16)
  From previous event:
      at Context.<anonymous> (test/integration/migrate/index.js:530:12)

Observed on Node 10:
  1) oracle | oracledb
       knex.migrate
         knex.migrate.status
           should return 0 if code matches DB:
      AssertionError: expected -1 to equal 0
      + expected - actual
      --1
      +0

      at /home/travis/build/tgriesser/knex/test/integration/migrate/index.js:160:39
  From previous event:
      at Context.<anonymous> (test/integration/migrate/index.js:159:12)
  From previous event:

Thanks. I'll fix those. Probably adding forUpdate() to some query when checking value from DB is enough. There are already other disabled tests which will catch this error.

Released in 0.20.10.

authors: elhigu kibertoad


text:
question - any way to avoid babel dependencies and its deprecation messages?

Environment
Knex version: 0.7.3
Database + version: Postgres 10, 11
OS: OSX, AWS Linux
Questions about how to use knex
This is not a request, but more of a wish disguised in a question.
Right now, when doing a fresh npm install of knex (.e.g., each docker build), we get a lot of babel messages deprecation and otherwise. Nothing seems to break, but it's a little worrisome, as we usually do not fancy deprecation warnings and babel related libs in our production running code.
Would it be possible to remove any babel/corejs from the knex distribution?
I see that the master branch (the future 0.8.x I assume) does not seem to have babel or corejs, so, it is perhaps already in the plan.
npm WARN deprecated @babel/polyfill@7.4.4: 🚨 As of Babel 7.4.0, this
npm WARN deprecated package has been deprecated in favor of directly
npm WARN deprecated including core-js/stable (to polyfill ECMAScript
npm WARN deprecated features) and regenerator-runtime/runtime
npm WARN deprecated (needed to use transpiled generator functions):
npm WARN deprecated
npm WARN deprecated   > import "core-js/stable";
npm WARN deprecated   > import "regenerator-runtime/runtime";
npm WARN deprecated mixin-deep@1.3.1: Critical bug fixed in v2.0.1, please upgrade to the latest version.
npm WARN deprecated set-value@2.0.0: Critical bug fixed in v3.0.1, please upgrade to the latest version.
npm WARN deprecated set-value@0.4.3: Critical bug fixed in v3.0.1, please upgrade to the latest version.

> core-js@2.6.9 postinstall /service/node_modules/core-js
> node scripts/postinstall || echo "ignore"

Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!

The project needs your help! Please consider supporting of core-js on Open Collective or Patreon:
> https://opencollective.com/core-js
> https://www.patreon.com/zloirock

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

You can use 0.18.0-next2. It does not use babel anymore.

as @kibertoad said

One last question, is 0.18.0-next2 as stable as 0.17.x or should we wait the official 0.18.0?

@jeremychone I don't expect 0.18.0-next2 to be any less stable than 0.17.x, we didn't get to any scary structural changes (such as redoing transaction disposal mechanism) yet, so unless you hit some really weird edge case that escaped both our testing and our automated test suite, you should be as good or better using 0.18.0-next2; and we definitely would appreciate getting some feedback from you!

TBH, I would expect official 0.18.0 to be less stable than 0.18.0-next2 at this rate, unless we decide to postpone disposal mechanism replacement until 0.19.0, which we may ultimately decide to do.

@koistya Ok, I am going to use 0.18.0-next.. for one of my prod application and will report any issue.
I am having other deprecation warnings (see below) which I think come from 0.18.0.-next... or one of its sub-dependencies (not urgent, but from my client's project, I usually like to not have those warnings). I can log a separate ticket if you want.
0.18.0-next2 deprecation warning
npm WARN deprecated mixin-deep@1.3.1: Critical bug fixed in v2.0.1, please upgrade to the latest version.
npm WARN deprecated set-value@2.0.0: Critical bug fixed in v3.0.1, please upgrade to the latest version.
npm WARN deprecated set-value@0.4.3: Critical bug fixed in v3.0.1, please upgrade to the latest version.

@jeremychone Could you please generate full dependency tree and figure out which knex dependency is causing these warnings? We are quite up-to-date with our dependencies, so to fix that I would need to raise a PR in someone else's repo.

Here you go.

As a side note, there is one thing I still don't get with npm. Sometime, I get those warnings (when building from a docker image), but I don't on my local osx npm install knex...

Anyway, you can see below set-value@2.0.0, set-value@0.4.3, and mixin-deep@1.3.1, but they are quite deep indeed.
├─┬ knex@0.18.0-next2
│ ├── bluebird@3.5.5
│ ├── colorette@1.0.8
│ ├── commander@2.20.0
│ ├─┬ debug@4.1.1
│ │ └── ms@2.1.2
│ ├── getopts@2.2.4
│ ├── inherits@2.0.3
│ ├── interpret@1.2.0
│ ├─┬ liftoff@3.1.0
│ │ ├── extend@3.0.2 deduped
│ │ ├─┬ findup-sync@3.0.0
│ │ │ ├── detect-file@1.0.0
│ │ │ ├── is-glob@4.0.1 deduped
│ │ │ ├─┬ micromatch@3.1.10
│ │ │ │ ├── arr-diff@4.0.0
│ │ │ │ ├── array-unique@0.3.2
│ │ │ │ ├─┬ braces@2.3.2
│ │ │ │ │ ├── arr-flatten@1.1.0
│ │ │ │ │ ├── array-unique@0.3.2 deduped
│ │ │ │ │ ├─┬ extend-shallow@2.0.1
│ │ │ │ │ │ └── is-extendable@0.1.1
│ │ │ │ │ ├─┬ fill-range@4.0.0
│ │ │ │ │ │ ├─┬ extend-shallow@2.0.1
│ │ │ │ │ │ │ └── is-extendable@0.1.1 deduped
│ │ │ │ │ │ ├─┬ is-number@3.0.0
│ │ │ │ │ │ │ └─┬ kind-of@3.2.2
│ │ │ │ │ │ │   └── is-buffer@1.1.6
│ │ │ │ │ │ ├── repeat-string@1.6.1
│ │ │ │ │ │ └─┬ to-regex-range@2.1.1
│ │ │ │ │ │   ├── is-number@3.0.0 deduped
│ │ │ │ │ │   └── repeat-string@1.6.1 deduped
│ │ │ │ │ ├── isobject@3.0.1 deduped
│ │ │ │ │ ├── repeat-element@1.1.3
│ │ │ │ │ ├── snapdragon@0.8.2 deduped
│ │ │ │ │ ├─┬ snapdragon-node@2.1.1
│ │ │ │ │ │ ├─┬ define-property@1.0.0
│ │ │ │ │ │ │ └─┬ is-descriptor@1.0.2
│ │ │ │ │ │ │   ├─┬ is-accessor-descriptor@1.0.0
│ │ │ │ │ │ │   │ └── kind-of@6.0.2 deduped
│ │ │ │ │ │ │   ├─┬ is-data-descriptor@1.0.0
│ │ │ │ │ │ │   │ └── kind-of@6.0.2 deduped
│ │ │ │ │ │ │   └── kind-of@6.0.2 deduped
│ │ │ │ │ │ ├── isobject@3.0.1 deduped
│ │ │ │ │ │ └─┬ snapdragon-util@3.0.1
│ │ │ │ │ │   └─┬ kind-of@3.2.2
│ │ │ │ │ │     └── is-buffer@1.1.6 deduped
│ │ │ │ │ ├─┬ split-string@3.1.0
│ │ │ │ │ │ └── extend-shallow@3.0.2 deduped
│ │ │ │ │ └── to-regex@3.0.2 deduped
│ │ │ │ ├─┬ define-property@2.0.2
│ │ │ │ │ ├─┬ is-descriptor@1.0.2
│ │ │ │ │ │ ├─┬ is-accessor-descriptor@1.0.0
│ │ │ │ │ │ │ └── kind-of@6.0.2 deduped
│ │ │ │ │ │ ├─┬ is-data-descriptor@1.0.0
│ │ │ │ │ │ │ └── kind-of@6.0.2 deduped
│ │ │ │ │ │ └── kind-of@6.0.2 deduped
│ │ │ │ │ └── isobject@3.0.1 deduped
│ │ │ │ ├─┬ extend-shallow@3.0.2
│ │ │ │ │ ├── assign-symbols@1.0.0
│ │ │ │ │ └─┬ is-extendable@1.0.1
│ │ │ │ │   └── is-plain-object@2.0.4 deduped
│ │ │ │ ├─┬ extglob@2.0.4
│ │ │ │ │ ├── array-unique@0.3.2 deduped
│ │ │ │ │ ├─┬ define-property@1.0.0
│ │ │ │ │ │ └─┬ is-descriptor@1.0.2
│ │ │ │ │ │   ├─┬ is-accessor-descriptor@1.0.0
│ │ │ │ │ │   │ └── kind-of@6.0.2 deduped
│ │ │ │ │ │   ├─┬ is-data-descriptor@1.0.0
│ │ │ │ │ │   │ └── kind-of@6.0.2 deduped
│ │ │ │ │ │   └── kind-of@6.0.2 deduped
│ │ │ │ │ ├─┬ expand-brackets@2.1.4
│ │ │ │ │ │ ├─┬ debug@2.6.9
│ │ │ │ │ │ │ └── ms@2.0.0 deduped
│ │ │ │ │ │ ├─┬ define-property@0.2.5
│ │ │ │ │ │ │ └── is-descriptor@0.1.6 deduped
│ │ │ │ │ │ ├─┬ extend-shallow@2.0.1
│ │ │ │ │ │ │ └── is-extendable@0.1.1 deduped
│ │ │ │ │ │ ├── posix-character-classes@0.1.1
│ │ │ │ │ │ ├── regex-not@1.0.2 deduped
│ │ │ │ │ │ ├── snapdragon@0.8.2 deduped
│ │ │ │ │ │ └── to-regex@3.0.2 deduped
│ │ │ │ │ ├─┬ extend-shallow@2.0.1
│ │ │ │ │ │ └── is-extendable@0.1.1 deduped
│ │ │ │ │ ├── fragment-cache@0.2.1 deduped
│ │ │ │ │ ├── regex-not@1.0.2 deduped
│ │ │ │ │ ├── snapdragon@0.8.2 deduped
│ │ │ │ │ └── to-regex@3.0.2 deduped
│ │ │ │ ├─┬ fragment-cache@0.2.1
│ │ │ │ │ └── map-cache@0.2.2 deduped
│ │ │ │ ├── kind-of@6.0.2
│ │ │ │ ├─┬ nanomatch@1.2.13
│ │ │ │ │ ├── arr-diff@4.0.0 deduped
│ │ │ │ │ ├── array-unique@0.3.2 deduped
│ │ │ │ │ ├── define-property@2.0.2 deduped
│ │ │ │ │ ├── extend-shallow@3.0.2 deduped
│ │ │ │ │ ├── fragment-cache@0.2.1 deduped
│ │ │ │ │ ├── is-windows@1.0.2
│ │ │ │ │ ├── kind-of@6.0.2 deduped
│ │ │ │ │ ├── object.pick@1.3.0 deduped
│ │ │ │ │ ├── regex-not@1.0.2 deduped
│ │ │ │ │ ├── snapdragon@0.8.2 deduped
│ │ │ │ │ └── to-regex@3.0.2 deduped
│ │ │ │ ├── object.pick@1.3.0 deduped
│ │ │ │ ├─┬ regex-not@1.0.2
│ │ │ │ │ ├── extend-shallow@3.0.2 deduped
│ │ │ │ │ └─┬ safe-regex@1.1.0
│ │ │ │ │   └── ret@0.1.15
│ │ │ │ ├─┬ snapdragon@0.8.2
│ │ │ │ │ ├─┬ base@0.11.2
│ │ │ │ │ │ ├─┬ cache-base@1.0.1
│ │ │ │ │ │ │ ├─┬ collection-visit@1.0.0
│ │ │ │ │ │ │ │ ├─┬ map-visit@1.0.0
│ │ │ │ │ │ │ │ │ └── object-visit@1.0.1 deduped
│ │ │ │ │ │ │ │ └─┬ object-visit@1.0.1
│ │ │ │ │ │ │ │   └── isobject@3.0.1 deduped
│ │ │ │ │ │ │ ├── component-emitter@1.3.0 deduped
│ │ │ │ │ │ │ ├── get-value@2.0.6
│ │ │ │ │ │ │ ├─┬ has-value@1.0.0
│ │ │ │ │ │ │ │ ├── get-value@2.0.6 deduped
│ │ │ │ │ │ │ │ ├─┬ has-values@1.0.0
│ │ │ │ │ │ │ │ │ ├── is-number@3.0.0 deduped
│ │ │ │ │ │ │ │ │ └─┬ kind-of@4.0.0
│ │ │ │ │ │ │ │ │   └── is-buffer@1.1.6 deduped
│ │ │ │ │ │ │ │ └── isobject@3.0.1 deduped
│ │ │ │ │ │ │ ├── isobject@3.0.1 deduped
│ │ │ │ │ │ │ ├─┬ set-value@2.0.0
│ │ │ │ │ │ │ │ ├─┬ extend-shallow@2.0.1
│ │ │ │ │ │ │ │ │ └── is-extendable@0.1.1 deduped
│ │ │ │ │ │ │ │ ├── is-extendable@0.1.1 deduped
│ │ │ │ │ │ │ │ ├── is-plain-object@2.0.4 deduped
│ │ │ │ │ │ │ │ └── split-string@3.1.0 deduped
│ │ │ │ │ │ │ ├─┬ to-object-path@0.3.0
│ │ │ │ │ │ │ │ └─┬ kind-of@3.2.2
│ │ │ │ │ │ │ │   └── is-buffer@1.1.6 deduped
│ │ │ │ │ │ │ ├─┬ union-value@1.0.0
│ │ │ │ │ │ │ │ ├── arr-union@3.1.0 deduped
│ │ │ │ │ │ │ │ ├── get-value@2.0.6 deduped
│ │ │ │ │ │ │ │ ├── is-extendable@0.1.1 deduped
│ │ │ │ │ │ │ │ └─┬ set-value@0.4.3
│ │ │ │ │ │ │ │   ├─┬ extend-shallow@2.0.1
│ │ │ │ │ │ │ │   │ └── is-extendable@0.1.1 deduped
│ │ │ │ │ │ │ │   ├── is-extendable@0.1.1 deduped
│ │ │ │ │ │ │ │   ├── is-plain-object@2.0.4 deduped
│ │ │ │ │ │ │ │   └── to-object-path@0.3.0 deduped
│ │ │ │ │ │ │ └─┬ unset-value@1.0.0
│ │ │ │ │ │ │   ├─┬ has-value@0.3.1
│ │ │ │ │ │ │   │ ├── get-value@2.0.6 deduped
│ │ │ │ │ │ │   │ ├── has-values@0.1.4
│ │ │ │ │ │ │   │ └─┬ isobject@2.1.0
│ │ │ │ │ │ │   │   └── isarray@1.0.0 deduped
│ │ │ │ │ │ │   └── isobject@3.0.1 deduped
│ │ │ │ │ │ ├─┬ class-utils@0.3.6
│ │ │ │ │ │ │ ├── arr-union@3.1.0 deduped
│ │ │ │ │ │ │ ├─┬ define-property@0.2.5
│ │ │ │ │ │ │ │ └── is-descriptor@0.1.6 deduped
│ │ │ │ │ │ │ ├── isobject@3.0.1 deduped
│ │ │ │ │ │ │ └─┬ static-extend@0.1.2
│ │ │ │ │ │ │   ├─┬ define-property@0.2.5
│ │ │ │ │ │ │   │ └── is-descriptor@0.1.6 deduped
│ │ │ │ │ │ │   └─┬ object-copy@0.1.0
│ │ │ │ │ │ │     ├── copy-descriptor@0.1.1
│ │ │ │ │ │ │     ├─┬ define-property@0.2.5
│ │ │ │ │ │ │     │ └── is-descriptor@0.1.6 deduped
│ │ │ │ │ │ │     └─┬ kind-of@3.2.2
│ │ │ │ │ │ │       └── is-buffer@1.1.6 deduped
│ │ │ │ │ │ ├── component-emitter@1.3.0
│ │ │ │ │ │ ├─┬ define-property@1.0.0
│ │ │ │ │ │ │ └─┬ is-descriptor@1.0.2
│ │ │ │ │ │ │   ├─┬ is-accessor-descriptor@1.0.0
│ │ │ │ │ │ │   │ └── kind-of@6.0.2 deduped
│ │ │ │ │ │ │   ├─┬ is-data-descriptor@1.0.0
│ │ │ │ │ │ │   │ └── kind-of@6.0.2 deduped
│ │ │ │ │ │ │   └── kind-of@6.0.2 deduped
│ │ │ │ │ │ ├── isobject@3.0.1 deduped
│ │ │ │ │ │ ├─┬ mixin-deep@1.3.1
│ │ │ │ │ │ │ ├── for-in@1.0.2 deduped
│ │ │ │ │ │ │ └─┬ is-extendable@1.0.1
│ │ │ │ │ │ │   └── is-plain-object@2.0.4 deduped
│ │ │ │ │ │ └── pascalcase@0.1.1
│ │ │ │ │ ├─┬ debug@2.6.9
│ │ │ │ │ │ └── ms@2.0.0 deduped
│ │ │ │ │ ├─┬ define-property@0.2.5
│ │ │ │ │ │ └─┬ is-descriptor@0.1.6
│ │ │ │ │ │   ├─┬ is-accessor-descriptor@0.1.6
│ │ │ │ │ │   │ └─┬ kind-of@3.2.2
│ │ │ │ │ │   │   └── is-buffer@1.1.6 deduped
│ │ │ │ │ │   ├─┬ is-data-descriptor@0.1.4
│ │ │ │ │ │   │ └─┬ kind-of@3.2.2
│ │ │ │ │ │   │   └── is-buffer@1.1.6 deduped
│ │ │ │ │ │   └── kind-of@5.1.0
│ │ │ │ │ ├─┬ extend-shallow@2.0.1
│ │ │ │ │ │ └── is-extendable@0.1.1 deduped
│ │ │ │ │ ├── map-cache@0.2.2 deduped
│ │ │ │ │ ├── source-map@0.5.7
│ │ │ │ │ ├─┬ source-map-resolve@0.5.2
│ │ │ │ │ │ ├── atob@2.1.2
│ │ │ │ │ │ ├── decode-uri-component@0.2.0
│ │ │ │ │ │ ├── resolve-url@0.2.1
│ │ │ │ │ │ ├── source-map-url@0.4.0
│ │ │ │ │ │ └── urix@0.1.0
│ │ │ │ │ └── use@3.1.1
│ │ │ │ └─┬ to-regex@3.0.2
│ │ │ │   ├── define-property@2.0.2 deduped
│ │ │ │   ├── extend-shallow@3.0.2 deduped
│ │ │ │   ├── regex-not@1.0.2 deduped
│ │ │ │   └── safe-regex@1.1.0 deduped
│ │ │ └─┬ resolve-dir@1.0.1
│ │ │   ├── expand-tilde@2.0.2 deduped
│ │ │   └─┬ global-modules@1.0.0
│ │ │     ├─┬ global-prefix@1.0.2
│ │ │     │ ├── expand-tilde@2.0.2 deduped
│ │ │     │ ├── homedir-polyfill@1.0.3 deduped
│ │ │     │ ├── ini@1.3.5
│ │ │     │ ├── is-windows@1.0.2 deduped
│ │ │     │ └── which@1.3.1 deduped
│ │ │     ├── is-windows@1.0.2 deduped
│ │ │     └── resolve-dir@1.0.1 deduped
│ │ ├─┬ fined@1.2.0
│ │ │ ├─┬ expand-tilde@2.0.2
│ │ │ │ └── homedir-polyfill@1.0.3 deduped
│ │ │ ├── is-plain-object@2.0.4 deduped
│ │ │ ├─┬ object.defaults@1.1.0
│ │ │ │ ├── array-each@1.0.1
│ │ │ │ ├── array-slice@1.1.0
│ │ │ │ ├── for-own@1.0.0 deduped
│ │ │ │ └── isobject@3.0.1 deduped
│ │ │ ├─┬ object.pick@1.3.0
│ │ │ │ └── isobject@3.0.1 deduped
│ │ │ └─┬ parse-filepath@1.0.2
│ │ │   ├─┬ is-absolute@1.0.0
│ │ │   │ ├─┬ is-relative@1.0.0
│ │ │   │ │ └─┬ is-unc-path@1.0.0
│ │ │   │ │   └── unc-path-regex@0.1.2
│ │ │   │ └── is-windows@1.0.2 deduped
│ │ │   ├── map-cache@0.2.2
│ │ │   └─┬ path-root@0.1.1
│ │ │     └── path-root-regex@0.1.2
│ │ ├── flagged-respawn@1.0.1
│ │ ├─┬ is-plain-object@2.0.4
│ │ │ └── isobject@3.0.1
│ │ ├─┬ object.map@1.0.1
│ │ │ ├─┬ for-own@1.0.0
│ │ │ │ └── for-in@1.0.2
│ │ │ └─┬ make-iterator@1.0.1
│ │ │   └── kind-of@6.0.2 deduped
│ │ ├─┬ rechoir@0.6.2
│ │ │ └── resolve@1.11.0 deduped
│ │ └─┬ resolve@1.11.0
│ │   └── path-parse@1.0.6
│ ├── lodash@4.17.11
│ ├─┬ mkdirp@0.5.1
│ │ └── minimist@0.0.8
│ ├── pg-connection-string@2.0.0
│ ├── tarn@1.1.5
│ ├── tildify@2.0.0
│ ├── uuid@3.3.2 deduped
│ └─┬ v8flags@3.1.3
│   └─┬ homedir-polyfill@1.0.3
│     └── parse-passwd@1.0.0

https://github.com/jonschlinkert/remarkable/pull/340
Rabbit hole goes deep... Started from the bottom, will bubble up from there. Hopefully projects with outdated dependencies are at least semi-maintained at this point :D

0.18.0 is released. Not many changes since next2, TBH, and we postponed scary changes till later, so it's a safe update.

authors: elhigu jeremychone kibertoad


text:
⚠ DDoS-Relay US-W-hil-2 has degraded performance

In e45735b, DDoS-Relay US-W-hil-2 (http://5.78.111.66:42069/;csv) experienced degraded performance:

HTTP code: 200
Response time: 31 ms

Resolved: DDoS-Relay US-W-hil-2 performance has improved in 3d47c1a after 5 minutes.

repo: tgstation-operations/status


text:
Account for bulk viscosity

We should probably be including the effects of the bulk viscosity in the momentum equation: the ⅓μ∇(∇⋅u) term.
See: https://en.wikipedia.org/wiki/Navier–Stokes_equations#Compressible_flow
Probably doesn't matter for the simpler verification tests we've carried out. Also not sure if it's included (or accounted for) with LES. Will have to investigate more.

I added this when I was working on the n-gas model, actually. I'll link to
a relevant commit once I push one.
On Thu, Feb 6, 2020, 9:25 PM Ali Ramadhan notifications@github.com wrote:

We should probably be including the effects of the bulk viscosity in the
momentum equation: the ⅓μ∇(∇⋅u) term.
See:
https://en.wikipedia.org/wiki/Navier–Stokes_equations#Compressible_flow
Probably doesn't matter for the simpler verification tests we've carried
out. Also not sure if it's included (or accounted for) with LES. Will have
to investigate more.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/thabbott/JULES.jl/issues/58?email_source=notifications&email_token=ACZDSTUOWF4P4FB5JPSCMJDRBTBAZA5CNFSM4KRHKQ62YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ILWAJAA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACZDSTQ3MRC7RHDXDKDRQETRBTBAZANCNFSM4KRHKQ6Q
.

authors: ali-ramadhan thabbott


text:
Finish test for testCreatePeerListener

There are a whole mess of fairly straight forward tests we haven't finished in testCreatePeerListener. They are important for confirming even basic functionality.

This is really about the iOS tests we haven't put in. That is covered under other bugs.


text:
fix build

This change is

PR is added to the queue for testing as 1. task. (4cf5745)

Hi @cicorias, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Shawn Cicoria). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

PR is added to the queue for testing as 2. task. (46f0d89)

Test (Success) 65681676 build is completed (4cf5745)
See https://github.com/ThaliTester/TestResults/tree/656816764cf5745_fix_build_cicorias/ for the logs

Test (Success) 65681676 build is completed (46f0d89)
See https://github.com/ThaliTester/TestResults/tree/6568167646f0d89_fix_build_cicorias/ for the logs

Test 656816764cf5745(4cf5745) has failed
See https://github.com/ThaliTester/TestResults/tree/656816764cf5745_fix_build_cicorias/ for the fail logs

Test 6568167646f0d89(46f0d89) has failed
See https://github.com/ThaliTester/TestResults/tree/6568167646f0d89_fix_build_cicorias/ for the fail logs

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

authors: ThaliTester cicorias msftclas yaronyg


text:
#include  error when build file 'demo18a01-barrier.cpp'

Hi, when I build file 'demo18a01-barrier.cpp' with command 'g++ -o output_exe demo18a01-barrier.cpp -lpthread -std=c++17' in ubuntu 20.04, no such file errors occurs. Is this is because barrier  header file only included in c++20 from this ? how do I fix this error?

Hi,
You faced this error because std::barrier is supported since C++20 (read here).
Please try compiling by this command:
g++ -o output_exe -lpthread -std=c++20 demo18a01-barrier.cpp
(and make sure that g++/gcc in your computer supports C++20 standard)
Hope it works.

Thanks.


text:
Do not strip parenthesis

Trimming parenthesis leads to bugs with distributed query evaluation because Prometheus does not properly stringify subquery expressions when they are not wrapped.
For example, the query max_over_time((bar/bar)[30s:15s]) gets transformed into max_over_time(bar/bar[30s:15s]).

Hm, this seems to break explicit assertions now, like timestamp((bar)).

repo: thanos-io/promql-engine


text:
could not delete LabelSets (cluster not used) on store-gateway

Thanos, Prometheus and Golang version used:

thanos version: v0.12.1
promethues version: v2.3.2
Object Storage Provider: minio
What happened:

I used a bucket for three clusters' sidecars, after several days, I assigned clusters “ci-prod-cluster-xxx” to another bucket and remove it on querier, but the LabelSets of  “cluster=ci-prod-cluster-xxx” on store-gateway wasn't deleted.
And I also retry to restart & re-deploy store-gateway, but it didn‘t work.
What you expected to happen:
the LabelSets of  “cluster=ci-prod-cluster-xxx” on store-gateway deleted automatically.
How to reproduce it (as minimally and precisely as possible):
Full logs to relevant components:

Anything else we need to know:

Hmm, if I understood you correctly then you have removed the Sidecars that have produced those blocks but you still left those blocks in the remote object storage? In such a case, it is expected that they would still show up from Thanos Store since the data is still there. Could you please clarify this?

@GiedriusS Yes, that's right, I didn't clean up the “ci-prod-cluster-xx” data in the bucket after remove it, because there are too many blocks in the bucket and I don't know which need to be deleted :-( That's very kind of you to tell me how to delete the residual block data.
from the docs block-deletion, it says that deletion-mark.json can help to delete the block that was chosen, but I don't know how to write this file and where to upload.

Just delete the appropriate directories according to their external labels. deletion-mark.json is an internal implementation thing that Thanos uses to mark blocks before their deletion. You could create them yourself by looking at the code to gracefully delete blocks but I don't think this is the way to go forward. I believe this will be properly solved during GSoC. Take a look at this PR: https://github.com/thanos-io/thanos/pull/2780.

authors: GiedriusS heisenbergye

repo: thanos-io/thanos


text:
[docs] Broken CONTRIBUTING.md link on thanos docs

What happened:
Broken link (CONTRIBUTING.md) at https://thanos.io/tip/thanos/getting-started.md/#contributing

I would be happy to contribute!

Looks like this issue duplicates #4364 which collected also a few more broken links

authors: matej-g rahulii


text:
Discuss CI/CD logic and optimise the process

Is your proposal related to a problem?
Currently we use circleci for:

any update to main, which publishes a new docker image
any update on a tag, which does a crossbuild and publish image + tarballs
both also do the make test as requirement

I would not call it a problem but since we are on GitHub with our repo, I think it makes more sense to have the logic from above just in Github actions as well. Furthermore there is the need to support more architectures in our builds.
I've tried to make things different/better via;

https://github.com/thanos-io/thanos/issues/4988
https://github.com/thanos-io/thanos/issues/4989
https://github.com/thanos-io/thanos/pull/4986

but IMO we can go for a different/better direction
Describe the solution you'd like

Move all our CI/CD to GitHub, which should make it easier to follow / iterate on than two different environments
Remove Promu
Use either buildx or even goreleaser
Don't build on every commit to main, but let's go towards nightly builds
Have an option to build artifacts/images in a PR with something like /build so a user can get a freshly build image to test on
I believe we have some compute stuff from the CNCF, so use that as runners instead of the free tier at GitHub (hopefully also helps with flaky tests)
Implement parallelism where possible (especially if we are going to add more archs)

+100 to a more environmentally friendly approach.
Few notes:

We should only build things that matter on a PR (e.g someone changes docs, why we rebuild and test the code?)
I believe we have some compute stuff from the CNCF, so use that as runners instead of the free tier at GitHub (hopefully also helps with flaky tests) is not true. I don't think we have any free tier. What I heard actually is that CircleCI increased their open source allowance, so we might want to this direction? I was in Birmingham DevOps days and met them (they had booth) and their tier sound quite generous. GH Action were proven to be harder to use generally (vs CircleCi Orbs Prometheus reuses) and not that fast (flakes we have on even parallel e2e tests). GH action does not work well without e2e tests also (they don' focus on error, you have to scroll a lot - but probably it's our fault)

So.. I wonder if moving fully to GH actions actually helps. Otherwise other points makes very much sense! 💪🏽 Thanks.

We should also work with Prometheus team to share same Orbs for Circle Ci? and building mechanisms? 🤔
See https://github.com/prometheus/circleci

I'm all in for helping each other out but we are still two different projects. I've spend quite some time on checking out Promu (for which we use a very old version (: ) but in the end I came to the conclusion;

Why use something that's opinionated towards the Prometheus ecosystem?
Why not keep it simple? All we need is a test, a build and a release. I.e. goreleaser instantly fixes that without any issues.

I guess tl;dr my point being: there are a lot of things (buildx, goreleaser, native GH stuff) that adds value without creating/making our own tools. It "should" be really easy.
So the Orbs are awesome for exporters and everything related to their project. But I wonder if we even need certain components from it. I took a look at this doc; https://docs.google.com/document/d/1Ql-f_aThl-2eB5v3QdKV_zgBdetLLbdxxChpy-TnWSE/edit#heading=h.24x0bg1hyuak and you see the problems they want to solve. That makes a lot of sense for their rich ecosystem with different projects. I don't think it makes that much sense for Thanos.
As for GH Actions vs circleci, I don't have any hard preference. It's also absolutely not the case that I dislike circleci or that we have issues with it. It's merely keeping it a bit more uniform in one place. I do think that the 'feedback' we get from GH jobs are easier to understand for users.
p.s. for GH, you should be able to see what runners we have. I not an admin/owner of the Thanos org on GH, so I don't have those insights.

Why use something that's opinionated towards the Prometheus ecosystem?

We don't. Prometheus also evaluates goreleaser and most likely moves there cc @roidelapluie It would be smart to reuse same technique. Why recreating everything from scratch? Including potential Orb or GH action shared library for this? 🤔

That makes a lot of sense for their rich ecosystem with different projects. I don't think it makes that much sense for Thanos.

I would not be so sure - we start add more projects in to thanos-community and thanos-io orgs and on sibling orgs like observatorium (:

p.s. for GH, you should be able to see what runners we have. I not an admin/owner of the Thanos org on GH, so I don't have those insights.

You are now, just changed it (you are official Thanos maintainer at the end).

As for GH Actions vs circleci, I don't have any hard preference. It's also absolutely not the case that I dislike circleci or that we have issues with it. It's merely keeping it a bit more uniform in one place. I do think that the 'feedback' we get from GH jobs are easier to understand for users

Same here, I don't know answer. My point is that moving to GH actions might not be so default at the end - there might be missed opportunity, so let's think twice.
Overall; I think we are on the same page here (:

While we are evaluating goreleased, there are a few blockers here. I am investigating adding more capabilities to promu (like deb and rpm's) in the coming weeks, to me promu is not dead.

Input from community hours meeting;

Need to check if we can do some colab with circleCI
What about new users, we need some gate to prevent everything to run, to prevent mining/etc.

I am in general happy with goreleaser, except that the nightly builds has moved to the Pro/paid tier. So we would still have to set something up for the nightly builds.
I think it's also a great idea to keep using and also grow promu. Bonus: With goreleaser locking some features behind a pay wall, it would be great to have a completely FOSS alternative that not only Thanos and Prometheus but many other projects can use.

Interesting to add to the discussion: now we bundle a version of Cortex inside internal and also run its unit tests. This is making the build even longer and Cortex's tests are showing intermittent failures: https://app.circleci.com/pipelines/github/thanos-io/thanos/10225/workflows/34954c6e-2d15-4f2a-ba30-728a9072b1ad/jobs/19790

Interesting to add to the discussion: now we bundle a version of Cortex inside internal and also run its unit tests. This is making the build even longer and Cortex's tests are showing intermittent failures: https://app.circleci.com/pipelines/github/thanos-io/thanos/10225/workflows/34954c6e-2d15-4f2a-ba30-728a9072b1ad/jobs/19790

I think what we should add is a test cache. So for the PR, only the relevant tests can run. For the merges, we can run the whole suit.
Especially considering we moved objstore tested out of the repo. I would have expected tests to run faster.

@kakkoyun goreleaser calls nightly builds what you call snapshot builds, I think:

Whether if you need beta builds or a rolling-release system, the nightly builds feature will do it for you.

Taken from https://goreleaser.com/customization/nightlies/. Our use case would be the rolling release for commits pushed to main.

Note that the idea behind GoReleaser's snapshots is for local builds or to validate your build on the CI pipeline. Artifacts won't be uploaded and will only be generated into the dist folder.

Taken from https://goreleaser.com/customization/snapshots/. Doesn't seem to fit our use case. 🤔

The snapshots are what I've been using for PR branch builds or main branch merge builds for years now :D It basically skips a bunch of checks. And when you add --skip-publish that's all you need. So no need to have a pro version.

@kakkoyun but we do want some level of "publishing", don't we? i.e. the container images for each commit. Is this also going well for ou? If yes, I think we've got everything we need then.

@douglascamata  Aha yes, GoReleaser does a lot of stuff, you're right. We don't use GoReleaser to build the containers, though. We use another step to build images. Yet we mimic the same behaviour, so we build binaries using GoReleaser and then copy them inside the container images. Exactly as GoReleaser.
I don't recommend using GoReleaser because there's no way to produce reproducible builds with docker "buildx" (GoReleaer uses this to produce multi-arch images). You need podman for that, and podman is only available for Pro version. And I believe reproducible builds and signing images are a must-have for an infrastructure project like Thanos to ensure supply chain security.
If we decide to use GoReleaser, I'm happy to implement all these for Thanos. I've spent quite some time on these, and I would be happy to help.

That's all very useful information! 🤓
Especially because I was adding multi-arch images to github.com/observatorium and used buildx there (less things to set up, pretty straightforward), without goreleaser. From what I see, we might eventually want to migrate it to a mix of goreleaser & podman too in the future. 🤔

authors: bwplotka douglascamata kakkoyun roidelapluie wiardvanrij


text:
Update coil from 1.0.0-rc3 to 1.0.0

Updates coil to 0.10.0.
Changelog: https://github.com/coil-kt/coil/blob/master/CHANGELOG.md#100---october-22-2020

@thatfiredev  I knew I remembered that username from somewhere! ;)

repo: thatfiredev/firecoil


text:
FormData polyfill for IE / Edge

This restores the ability to save changes in IE11 and Edge.

If you refer to Mozilla docs on FormData, cross-browser support is pretty shaky:
https://developer.mozilla.org/en-US/docs/Web/API/FormData#Browser_compatibility

Thanks @hooch
So, currently the form submission is not working in IE 11 and edge is that why the Polyfill is needed?
Just want to clarify.
Thanks.

Moving to 1.x as it requires rebuilding and republishing JS.

authors: fletch3555 hooch tnylea

repo: the-control-group/voyager


text:
Queria controlar o numero de casas decimais do filtro percentage

Queria controlar o numero de casas decimais do filtro percentage

You're able to do that, looking at the source, in percentage filter the functions takes an argument called decimal that's related to the number of decimals house. So, you should use |percentage:{numberOfDecimals} without the brackets.

authors: guylhermetabosa rhuanbarreto

repo: the-darc/angular-br-filters


text:
Error in lab 2a set up

Hi,
When launching the lab 2a on Pytorch Lightning in Colab (https://colab.research.google.com/github/full-stack-deep-learning/fsdl-text-recognizer-2022-labs/blob/main/lab02/notebooks/lab02a_lightning.ipynb#scrollTo=sVx7C7H0PIZC), the first cell runs fine:
lab_idx = 2

if "bootstrap" not in locals() or bootstrap.run:
    # path management for Python
    pythonpath, = !echo $PYTHONPATH
    if "." not in pythonpath.split(":"):
        pythonpath = ".:" + pythonpath
        %env PYTHONPATH={pythonpath}
        !echo $PYTHONPATH

    # get both Colab and local notebooks into the same state
    !wget --quiet https://fsdl.me/gist-bootstrap -O bootstrap.py
    import bootstrap

    # change into the lab directory
    bootstrap.change_to_lab_dir(lab_idx=lab_idx)

    # allow "hot-reloading" of modules
    %load_ext autoreload
    %autoreload 2
    # needed for inline plots in some contexts
    %matplotlib inline

    bootstrap.run = False  # change to True re-run setup

!pwd
%ls

But the second outputs an error.
import pytorch_lightning as pl

version = pl.__version__

docs_url = f"https://pytorch-lightning.readthedocs.io/en/{version}/"  # version can also be latest, stable
docs_url

The error is:
OSError: /usr/local/lib/python3.10/dist-packages/torchtext/lib/libtorchtext.so: undefined symbol: _ZN3c109TupleTypeC1ESt6vectorINS_4Type24SingletonOrSharedTypePtrIS2_EESaIS4_EESt8optionalINS_13QualifiedNameEESt10shared_ptrINS_14FunctionSchemaEE

yes ... I'm having the same issue. is this course maintained ?

It is not actively maintained anymore.

Changing the versions for torch and torchtext fixed the issue for me.
! pip install -U torch==2.1 torchtext==0.16.0

The torch version from the course repo's requirement should be 2.1.*. The corresponding supported version for torchtext is 0.16.0 (source).

authors: SuibhneOFoighil charlesfrye kunschg vinaykakkad


text:
PL: bossowie → bossy

PL: bossowie → bossy

Description 🗒
Change wrong form of "bosses" in Polish.

Examples 📸

Related Issues 🔗

 Expand for Help

Have questions about the review or deployment process? View our contributing docs
Need additional help and want to chat in real time? Join our community Discord

By submitting this pull request, you agree to our code of conduct

Can you commit the changes of the other PR #376  on this?

.deploy

authors: Faalagorn Razzmatazzz Shebuka

repo: the-hideout/tarkov-dev


text:
Language Switcher 🌐

Language Switcher 🌐
This pull request adds a language toggle on the /settings page so users can change what language the site is in

n

.deploy to development