text:
Enhance CONTRIBUTING documentation

https://github.com/zricethezav/gitleaks/blob/0d471653b5389029ab9126c35ea960b480114135/CONTRIBUTING.md?plain=1#L41

There is not actually a section called "regex". It probably refers to the paragraph that begins with generateSemiGenericRegex. It would probably be more clear to have a section header.

https://github.com/zricethezav/gitleaks/blob/0d471653b5389029ab9126c35ea960b480114135/CONTRIBUTING.md?plain=1#L71-L75

Assuming "should" uses roughly the RFC definition, it would be good to know in what cases one might choose to use different keywords vs identifiers.
Generally, it would be good to know what is the difference between keywords vs identifiers

https://github.com/zricethezav/gitleaks/blob/0d471653b5389029ab9126c35ea960b480114135/config/gitleaks.toml#L162-L169

Although perhaps it's obvious, it might good to discuss how each item in the {provider}.go file maps to each item in the generated rule above.

contributing docs rock dude what are you talking about ;P
gonna close this though for now though. happy to accept PRs making improvements to the docs

authors: weineran zricethezav

repo: gitleaks/gitleaks


text:
🛑 Discord Markdown Badge (server endpoint) is down

In 28f797e, Discord Markdown Badge (server endpoint) (https://dcbadge.limes.pink/api/server/zkspfFwqDg) was down:

HTTP code: 429
Response time: 201 ms

Resolved: Discord Markdown Badge (server endpoint) is back up in 7bf11c0 after 58 minutes.

source: gharchive/issue

repo: gitlimes/status

license: MIT

license_type: permissive

license_source: github-api


text:
🛑 MSP-002 is down

In 0e5d4d2, MSP-002 (https://msp-portal.gw002.oneitfarm.com/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: MSP-002 is back up in 4091053.

repo: gitsrc/upptime


text:
Retrieve the block txs from the chronik client

The txs are non longer included in the block with the chronik node version, so we need to call the block-txs endpoint.
Test Plan:
cargo test

Tests pass on my machine

source: gharchive/pull-request

authors: EyeOfPython Fabcien

repo: givelotus/bitcoinsuite


text:
Colored list #4

Colored lists #4
Don't merge, yet!
The development has not quite finished, yet. This is just a preview.

So, that's what I've done so far:

I added the Markdown-flavored renderer (MarkdownTextRenderer) and the Noop renderer (NoopRenderer) as well as abstract interfaces and factories for these two.
I implemented these into the list.
I wrote a lot of unit tests so nothing will (hopefully) break.

What needs to be done:

Fixing the regex (I don't know how to do that correctly. I'd appreciate someone's help.)
Adding a ASCII escape code renderer. (Done in a3f1384).
Tests under real work scenarios.
Writing docs on how to implement it (See: https://github.com/Matt3o12/termui/wiki/Color-Renderers)
Refactoring the code (I need some advice from a native speaker here)[2] :) (if you have any feedback, please give it now. Nothing is in the master branch, yet).
Adding the renderers to other Bufferer-components? Added in e9e3e40 (Par only).

How do I use/test the new text renderer?
Just do: myList.RendererFactory = termui.MarkdownTextRendererFactory{} :)
Are these changes backwards compatible?
Short: yes, at least when you used NewList() instead of List{} as you're supposed to.
These changes add a new field to the List: RendererFactory, which generates the TextRenderers. List uses this field for generating the appropriate (colorful) output. If you didn't use the list constructor (NewList()), the compiler will yield an error because of a missing field.
If you use the constructor, the constructor will set the field to NoopRendererFactory which will not generate any formatted output (as the name states: No Operation).
--
If you have any question or feedback, just leave comment.

[1]: The current regex implementation for finding text sequences that need formatting, doesn't work properly. It will not format: [[ERROR]](red,bold) foo correctly, which should normalize to: [ERROR] foo. Here is the current regex in action with example it should find (https://regex101.com/r/fC0gD1/1). Currently only one expression fails.
If you know a regex that will work, please let me know!
[2]: Everything that formats a text is called TextRenderer. In my dictionary I couldn't find Renderer and I wonder if that is a word, which makes sense. If you find that this word fits properly, let me know. If it doesn't, could you suggest a better one?

Neat! There are a lot of changes I need to look into. Some suggestions:

For the ASCII escape code, you have to escape the escape code (e.g. "\\e[33;My Text here"). I am afraid that people won't like this limitation, so let us just focus on what we've done right now.

We just exposed RendererFactory to uses. This is part of implementations that users don't need to know. Suggest that it may be better if we add a field like ColorSyntax="markdown" instead.

To be honest when I saw Noop, the first thing got into my mind was: is that a noodle thing or something?... (Umm... IDK, PlainRenderer sounds better?)

For the ASCII escape code, you have to escape the escape code (e.g. "\e[33;My Text here"). I am afraid that people won't like this limitation, so let us just focus on what we've done right now.

People can always choose their favorite (e.g. escape codes, the markdown-like syntax, or their own implementation). And if they really don't want to escape every character, they can just use raw strings (e.g. entry := `\e[33;My Text here`), which will work just fine. Of course, raw strings are not preferable for human text and have limitations but many people are used to escaping characters like \ anyways when writing regular expressions in other languages.
Also, currently the markdown renderer can't render [[ERROR]](red,bold) message because the regex won't work correctly. This might be a problem for some projects and I don't know how to fix it (I'm not good at regexs).

We just exposed RendererFactory to uses. This is part of implementations that users don't need to know. Suggest that it may be better if we add a field like ColorSyntax="markdown" instead.

user != developer. The code aims at other developer who should be able to read docs and understand a few basic things about programming, like the factory pattern. We could also add a method method like UseColorSyntax(name string) and SetColorSyntax(factory TextRendererFactory) just like I did in themes.go.

To be honest when I saw Noop, the first thing got into my mind was: is that a noodle thing or something?... (Umm... IDK, PlainRenderer sounds better?)

It was late and I couldn't come up with a better name. I'll rename it along with a  few other things :)

2 questions still remain:

The regex doesn't quite work (do you know anyone who could fix that)?
Is TextRenderer a good name or do you know a better one.

So, I think I'm done.
I added 3 markdown renderes. The plain one (previously NoopRenderer), the MarkdownRenderer and the EscapeCodeRenderer (you don't even need to escape the \033 because go recognizes it as a letter).
I implemented the renderers in Par and List. The other components didn't seem to need it.
I also wrote a Wiki page. I'd be nice if you could merge it as well. The wiki is a separate git repo, if you didn't know, so this pull request does not include the page.
If you believe I've forgotten something, please let me know :)

@Matt3o12
I'm not an expert by any means, but I think to have a robust and correct regex for what you want it to do you can't actually use Go's native regexp library. This is because Go uses the RE2 engine, which, while offering O(n) worse-case time, doesn't support quite a few features of PCRE such as recursion -- which would make what you want to do a lot simpler.
If you were to use a Go PCRE binding, the regex would probably look quite similar to
(\[((?:(?>[^[\]]+)|(?-2))*)\])\(([a-z\s,]+)\)

which gives results like this. This seems to be approximately how markdown works, from my experiments. If that's not what you're looking for, apologies, and let me know if I can improve it.
Also, for reference, github.com/martinolsen/go-pcre/regexp seems to be pretty much just a drop-in replacement for the standard regexp package, so it would be pretty easy to change over to using that.

Hey!
Thank you for the suggestion! The regex seems to work (and I wrote a similar with Lookbehind which didn’t work either due to Go’s old regex implementation) but yours seem to be a better suited.
I’d be very happy to use that regex but I don’t know if adding another dependency is such a good idea.
Furthermore, go get  github.com/martinolsen/go-pcre/regexp fails:
# github.com/martinolsen/go-pcre
/Volumes/Shared HD/Developing/go/src/github.com/martinolsen/go-pcre/pcre.go:4:11: fatal error: 'pcre.h' file not found
 #include <pcre.h>
          ^
1 error generated.

I don’t think we should add non-go dependencies. It makes cross-compiling harder and speed doesn’t really matter much when parsing short texts (and I think the time to call a C function is higher then just doing it in go).
However, it is not up to me whether or not we should use that.
BTW. If don’t really care whether or not it’s just a drop-in replacement as long as it returns where the regex starts and where it ends.

On Apr 18, 2015, at 3:08 PM, TalkTakesTime notifications@github.com wrote:
@Matt3o12 https://github.com/Matt3o12
I'm not an expert by any means, but I think to have a robust and correct regex for what you want it to do you can't actually use Go's native regexp library. This is because Go uses the RE2 engine, which, while offering O(n) worse-case time, doesn't support quite a few features of PCRE such as recursion -- which would make what you want to do a lot simpler.
If you were to use a Go PCRE binding, the regex would probably look quite similar to
([((?:(?>[^[]]+)|(?-2))*)])(([a-z\s,]+))
which gives results like this https://regex101.com/r/aN1kX1/4. This seems to be approximately how markdown works, from my experiments. If that's not what you're looking for, apologies, and let me know if I can improve it.
Also, for reference, github.com/martinolsen/go-pcre/regexp https://godoc.org/github.com/martinolsen/go-pcre/regexp seems to be pretty much just a drop-in replacement for the standard regexp package, so it would be pretty easy to change over to using that.
—
Reply to this email directly or view it on GitHub https://github.com/gizak/termui/pull/22#issuecomment-94164105.

Hm, you're probably right. For the record, you can probably solve your go get issue by doing brew install pcre (I assume you're on a Mac due to /Volumes). Admittedly even having to do this is less than ideal.
Unfortunately, I believe it's impossible to correctly match an arbitrarily deep recursive expression using a single true regular expression (the language matched by PCRE is a superset of the language matched by "true" regular expressions, but I don't know its exact definition). If using an external dependency isn't an option, I guess the next best method for getting accurate results would be write a slightly more sophisticated parser than just a regex.
I'll have a look for alternatives and a play around myself and see if I come up with anything.

Hi @Matt3o12, this is merged onto another branch refactoring, and I will use your code as a basic underlying text processing.
There is a lot of work need to be done for refactoring, but I think (hopefully) the branch will merge onto master soon.

authors: Matt3o12 TalkTakesTime gizak

repo: gizak/termui

license: mit

license_source: bigquery


text:
Feat: Compress

Implement Compress operator.

I'll take this one

I'll take this one

😏

I'll take this one

😏

Oups sorry, missed it

authors: hakymulla raphaelDkhn

repo: gizatechxyz/orion


text:
Calling pyvantage.set_variable() that does not exist

https://github.com/gjbadros/hass-vantage/blob/master/custom_components/vantage/__init__.py#LL160C75-L160C75

Abandon

repo: gjbadros/hass-vantage


text:
Environmental covariate by Taxa matrix deployment

Why have changes been made?
We want to be able to only use select covariates for each species group (taxa). This push allows us to select TRUE or FALSE for each environmental covariate on a taxa basis. There is also a bug fix (more on that below).
What changes have been made?

data/external/focalCovariates.csv - New columns entitled "selected_speciesGroup" allow us to provide covariates on a taxa basis.
pipeline/import/environmentalImport.R - Since there are now multiple "selected" columns, we need to take all covariates that have TRUE in at least one of these columns
functions/modelPreparation.R - This function now selects covariates to add to the model workflow based on the taxon in use. If there is no particular selecton for a taxa then it simply adds all covariates that were calculated.
pipeline/models/speciesModelRuns.R - Need to import focal covariates

Additional changes
GeoNorge had an update yesterday and changed the categorisation of their road types. This means we have to update the geonorge script. There was also an error in the get_modis script. It should have used regionGeometry instead of regionGeometryBuffer, and the net_primary_productivity script was using an incorrect file path.

functions/get_geonorge.R - Now we update the roads based on a new column.
pipeline/import/utils/defineEnvSource.R - The section where we refien the vector data down to relevant types is now in the get_geonorge function. regionGeometry is now used in the get_modis function.
functions/get_modis.R - The data path for MODIS data has been updated.

Works on my end. I will approve the PR, but I think it would be more intuitive to specify desired covariates as columns in focalTaxa rather than a column for each taxa in focalCovariates. I can see it being cumbersome to add/remove taxa columns in focalCovariates, especially if there are many taxa. Because number of available covariates is much more static, I think it is would be easier to specify covariates in focalTaxa.csv. the change would also replace the "selected_speciesGroup" syntax with covariate columns in focalTaxa with the same name as the covariates being added. will make issue to reconsider this approach.

Yes this makes much more sense

authors: RRTogunov samaperrin

repo: gjearevoll/BioDivMapping


text:
Max distance terminated rays render as transparent when alpha is enabled

It should just terminate to black

This seems to be an artifact of affording transparent objects to render the background alpha through them and there are portions of dragon model that severely bend the light such that the background is rendered from off to the side. An option could be added to disable transparent rendering through objects?

In blender settings you can set glass to be transparent and set a roughness threshold:
https://docs.blender.org/manual/en/latest/render/cycles/render_settings/film.html

repo: gkjohnson/three-gpu-pathtracer


text:
Chunks for commented function body

Part #150
WIP.

Almost done.
I thought about move chunk and writer to root and move writer::defines to parent or reexport it.

Seems mod to_code needed be pub to stable.

:umbrella: The latest upstream changes (presumably #152) made this pull request unmergeable. Please resolve the merge conflicts.

Rebased to master. All done in this PR.

I don't see the point of aliasing Vec<String> to Strings: verbosity savings are small, semantics exactly the same. Also some functions seem to consume Strings without a need.

I thought that some formatters will need consume so make it all consuming.
As main formating go to rustfmt and all current can receive &[String], seems I was wrong.
One more reason remove Strings, as it better use slice as input parameter. I remove Chunks also.

Replaced map with for. Removed String and Chunks.
Removed commit with TABs replace, I will try make \t\t later.

\t and tabs(x) would probably coexist then.
Thanks!
@homu r+

:pushpin: Commit d201a65 has been approved by gkoz

:hourglass: Testing commit d201a65 with merge 8c32ca9...

:sunny: Test successful - status

authors: EPashkin gkoz homu

repo: gkoz/gir


text:
aws cli timing out

All other bash commands are working great and "which aws" returns the path to the aws client. However, anytime I try to run aws command it times out, even "aws --version" which should not require any kind of credentials or network connections. I even set timeout to 10 seconds. Just hangs on the aws binary.

Increased memory and now it runs. Have other issues but will open a new issue for that.

I had to add HOME=/tmp to my function. Also had to use AWS_* vars but added "2" to end so I could reference them in my code or they got over-written. Now working well.

repo: gkrizek/bash-lambda-layer


text:
namespace collision

OpenAI also uses the command openai in their implementation:
https://github.com/openai/openai-python
So one cannot use your script and OpenAI's implementation, but must choose one or the other.

Thank you for this information. I'll take care of that 👍

authors: glcraft kiil

repo: glcraft/nu-scripts


text:
🛑 Schoelcher is down

In 5d3ceb4, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 05e7431.

repo: glefait/martinique-public-websites


text:
🛑 Schoelcher is down

In bd9a214, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 9e665df.


text:
🛑 Technopole Martinique is down

In 5005d72, Technopole Martinique (https://www.technopolemartinique.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Technopole Martinique is back up in cdfb10a.


text:
🛑 Schoelcher is down

In b5637a7, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 760cc9d after 5 minutes.


text:
🛑 Schoelcher is down

In 553b210, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 9e9b2d2.


text:
🛑 Schoelcher is down

In 79f7473, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 4bf04ae.


text:
🛑 Comite Martiniquais du tourisme is down

In ea944e9, Comite Martiniquais du tourisme (https://www.martinique.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Comite Martiniquais du tourisme is back up in 51973ab.


text:
🛑 Schoelcher is down

In 57ed29d, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 7f7f23c.


text:
🛑 Schoelcher is down

In 823a3f4, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 66d33c3.


text:
🛑 Schoelcher is down

In e664cd4, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in adc1972.


text:
Requiring webpack on my server file errors

I was following the instructions on your readme, and then tried to run webpack.  As soon as I add var webpack = require('webpack'); into my server.js equivalent, I get errors like:
`  ERROR in ./node_modules/fsevents/node_modules/node-pre-gyp/lib/info.js
Module not found: Error: Can't resolve 'aws-sdk' in '[path to repo]/node_modules/fsevents/node_modules/node-pre-gyp/lib'
Any idea?

Sounds like your server is also building a bundle which is then failing on a missing dependency.
This is a webpack / webpack config issue, not related to hot middleware.

authors: DaveStein glenjamin

repo: glenjamin/webpack-hot-middleware


text:
Custom Command For Different Actions

Can I have my own custom commands for the dashboard actions instead of using the default ones?

yup

authors: JuniorSuperTux glepnir

repo: glepnir/dashboard-nvim


text:
cannot override row border color

It seems that no matter what I set to borderColor or horizontalBorderColor in my getRowThemeOverride, the border color values from the global theme are used instead. Other values from getRowThemeOverride are applied fine.

which border would you expect to be overridden by the row themes border color props? Top or bottom?

Either one. Currently nothing changes with the row border overrides

Also overriding the borderColor in the cell theme override has no effect.

Due to performance reasons the borders cannot be overridden at the cell
level. One of the major optimizations of the grid is drawing the borders in
a single pass. Changing even the row theme border color will have some
negative impact but not nearly as bad as doing it per cell.
On Tue, Apr 19, 2022 at 2:10 AM Benjamin Grosse @.***>
wrote:

Also overriding the borderColor in the cell theme override has no effect.
—
Reply to this email directly, view it on GitHub
https://github.com/glideapps/glide-data-grid/issues/270#issuecomment-1102353921,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAHN23TUIO6QJOL2UEMN3TVFZZ6ZANCNFSM5TVO25HA
.
You are receiving this because you commented.Message ID:
@.***>

Fixed on 4.0.3

authors: bjgrosse jassmith

repo: glideapps/glide-data-grid


text:
Improving costs page exhibition

Resultado:

Nova versão com campos solicitados

Codecov Report

Merging #747 (7a29a7a) into dev (3e3d2d7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #747   +/-   ##
=======================================
  Coverage   41.38%   41.38%
=======================================
  Files         341      341
  Lines       25349    25349
=======================================
  Hits        10490    10490
  Misses      14859    14859

Flag
Coverage Δ

unittests
41.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3d2d7...7a29a7a. Read the comment docs.

Nova versão em inglês

authors: Erkmann codecov-commenter

repo: globocom/database-as-a-service


text:
Failed to download

I need detailed information on how to create a .wvd file

There are already detailed instructions on README

authors: glomatico hacbachmaquan

repo: glomatico/gamdl


text:
Feature request: Add option to remove all internal/private types which arent used

For reference, it was the only (still open) feature request on Google Code:
http://code.google.com/p/il-repack/issues/detail?id=1

And it's done ! (see linker branch for integration, and 2.1.0-beta1 pre-release for build)

repo: gluck/il-repack


text:
[GlueSQL-js] selecting columns which have same name occurs problem

Hello, I'm using gluesql-js in my personal project. Thank you for the amazing work!
Description
I found that selecting multiple columns which have same name has some problem. Because gluesql-js returns the retrieved row as object and column name is used as object's key, this problem happened.
I ran my sql queries in gluesql cli and I can confirm that this behavior happened only in gluesql-js. Here is the query I ran

sql queries and results for each platform
queries
CREATE TABLE IF NOT EXISTS users (
  id TEXT PRIMARY KEY,
  name TEXT NOT NULL,
  profile INTEGER NOT NULL
);
CREATE TABLE IF NOT EXISTS files (
  id TEXT PRIMARY KEY,
  name TEXT NOT NULL,
  size INTEGER NOT NULL,
  type TEXT NOT NULL,
  download_count INTEGER NOT NULL,
  hands_up BOOLEAN NOT NULL,
  uploaded_by TEXT NOT NULL,
  uploaded_at TIMESTAMP NOT NULL
);
CREATE TABLE IF NOT EXISTS links (
  id TEXT PRIMARY KEY,
  text TEXT NOT NULL,
  view_count INTEGER NOT NULL,
  hands_up BOOLEAN NOT NULL,
  uploaded_by TEXT NOT NULL,
  uploaded_at TIMESTAMP NOT NULL
);
CREATE TABLE IF NOT EXISTS comments (
  id TEXT PRIMARY KEY,
  data_id TEXT NOT NULL,
  data_type TEXT NOT NULL,
  text TEXT NOT NULL,
  sender_id TEXT NOT NULL,
  receiver_id TEXT NOT NULL,
  created_at TIMESTAMP NOT NULL
);
CREATE TABLE IF NOT EXISTS comment_metadata (
  data_id TEXT PRIMARY KEY,
  last_read_comment_id TEXT
);
CREATE TABLE IF NOT EXISTS notifications (
  id TEXT PRIMARY KEY,
  type TEXT NOT NULL,
  text TEXT NOT NULL,
  data_id TEXT NOT NULL,
  data_type TEXT NOT NULL,
  sender_id TEXT,
  created_at TIMESTAMP NOT NULL
);
INSERT INTO users VALUES ("naive-id-1", "naive-name-1", 1);
INSERT INTO users VALUES ("naive-id-2", "naive-name-2", 2);
INSERT INTO users VALUES ("naive-id-3", "naive-name-2", 2);
INSERT INTO files VALUES (
  "naive-file-id-1", "naive-file-name-1", 128, "PNG", 1, false,
  "naive-id-3", "2022-10-01T14:48:00.000Z");
INSERT INTO files VALUES (
  "naive-file-id-2", "naive-file-name-2", 256123, "JPEG", 0, true,
  "naive-id-2", "2022-10-01T15:48:00.000Z");

INSERT INTO files VALUES (
  "naive-file-id-3", "naive-file-name-3", 256123, "HWP", 0, true,
  "naive-id-2", "2022-10-05T15:48:00.000Z");

INSERT INTO files VALUES (
  "naive-file-id-4", "naive-file-name-2", 256123, "JPEG", 0, true,
  "naive-id-2", "2022-10-02T15:48:00.000Z");

INSERT INTO files VALUES (
  "naive-file-id-5", "naive-file-name-5", 256123, "JPEG", 0, true,
  "naive-id-2", "2022-09-01T15:48:00.000Z");

INSERT INTO links VALUES (
  "naive-link-id-1", "naive-link-name-4", 0, false,
  "naive-uploader", "2022-10-02T15:48:00.000Z");

INSERT INTO links VALUES (
  "naive-link-id-2", "naive-link-name-2", 0, false,
  "naive-uploader", "2022-10-02T16:48:00.000Z");

INSERT INTO comments VALUES (
  "naive-comment-id-2", "naive-file-id-1", "FILE", "i want to download but i
  can’tdaklfdjaslkdjfalkdsnfaldlafksldkfjalsdkjfaljdflksa",
  "naive-sender", "naive-id-3", "2022-10-02T16:48:00.000Z");

INSERT INTO comments VALUES (
  "naive-comment-id-3", "naive-file-id-1", "FILE", "hoho",
  "naive-sender", "naive-id-3", "2022-10-02T17:48:00.000Z");

INSERT INTO comments VALUES (
  "naive-comment-id-4", "naive-file-id-1", "FILE", "hoho",
  "naive-sender", "naive-uploader", "2022-10-02T12:28:00.000Z");

INSERT INTO comments VALUES (
  "naive-comment-id-5", "naive-file-id-2", "FILE", "hoho",
  "naive-sender", "naive-id-2", "2022-10-02T16:48:00.000Z");

INSERT INTO comments VALUES (
  "naive-comment-id-6", "naive-file-id-2", "FILE", "i want to download but i
  can’tdaklfdjaslkdjfalkdsnfaldlafksldkfjalsdkjfaljdflksa",
  "naive-sender", "naive-id-2", "2022-10-02T08:21:00.000Z");

INSERT INTO comment_metadata VALUES (
  "naive-file-id-2", "naive-comment-id-5"
);
INSERT INTO notifications VALUES (
  "naive-noti-id-1", "COMMENT", "notification came hohoho", "naive-file-id-2",
  "FILE", "naive-id-2", "2022-10-02T08:21:00.000Z"
);
INSERT INTO notifications VALUES (
  "naive-noti-id-2", "COMMENT", "another notification came hohoho", "naive-file-id-1",
  "FILE", "naive-id-2", "2022-10-02T08:17:00.000Z"
);
INSERT INTO notifications VALUES (
  "naive-noti-id-3", "STATUS", "peer downloaded!", "naive-link-id-1",
  "FILE", "naive-id-1", "2022-10-02T12:17:00.000Z"
);
SELECT u.*,
      f.*,
      f.id
  FROM   users u
      LEFT JOIN (SELECT uploaded_by AS id,
                    type,
                    Max(uploaded_at)
             FROM   files
             GROUP  BY files.uploaded_by) f
         ON u.id = f.id;

results in gluesql cli

results in chrome browser

Question
Is there a way to improve? If there is no way to make improvement, then should I be careful using gluesql-js?

The thing is.. we may gotta solve this issue in gluesql-core.
In Most regacy databases, ambiguous columns gots error like below.
mysql> select * from (select 1 as a, 2 as a) sub;
ERROR 1060 (42S21): Duplicate column name 'a'

And I am solving those kinda issues #868 . Please wait for a few hours days 😢
*But it can be solved by client level as well.
Some client implemented sugar-function like; automatically concatenate prefix _n. eg) select id, id ... => id_1, id_2

Nice! Now I understand. Thank you for the answer.

But you still got the point.
Cuz If it is not derived from table or inline view, below query should work but not with js Object lol
mysql> select 1 as a, 2 as b;
+---+---+
| a | b |
+---+---+
| 1 | 2 |
+---+---+

repo: gluesql/gluesql


text:
debug pr

Description of proposed changes

Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

closing in favour of #503

license: Unlicense


text:
detect idle time and … do something

on macOS, this probably means maintaining a counter in the background, on a timer, with CGEventSourceCounterForEventType

too vague to be actionable, not sure what we could change here with the Nexus design, practically

repo: glyph/Pomodouroboros


text:
Remove spurious wheel dependency from setup.py

This isn't a build dependency so it shouldn't be in setup_requires.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d20a7a4) 91.82% compared to head (500de49) 91.82%.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk     #150   +/-   ##
=======================================
  Coverage   91.82%   91.82%
=======================================
  Files          11       11
  Lines        1260     1260
=======================================
  Hits         1157     1157
  Misses        103      103

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

authors: codecov-commenter jameshilliard

repo: glyph/automat


text:
New version of Jenkins (2.107.3) is available for download

Noticed today on http://nemo.gmacario.it:9080/manage:

Performed a fresh install on a new machine (dory.gmacario.it), the newly created Docker image is based on Jenkins ver. 2.107.3

Closing issue

repo: gmacario/easy-jenkins


text:
create Hello Python!

create 1st commit

Please change to Hello world


text:
WIP: Compose approach

This is a slight variation on the original skeleton, which uses docker compose to provision a Postgres container that can work as a target warehouse.
NOTE: if the POSTGRES_HOST is set to host.docker.internal then this setup would simply ignore the postgres container and use a server that the host is connected to.

Hi @boblannon-fp. I like the approach of using docker compose to make it simpler for users to get things set up with a postgres container.

Thanks! As noted, it's just a WIP, wanted to see what you thought of the general idea.  Feel free to close it if you'd rather not have a draft PR hanging around.

However, the current PR breaks some existing functionality that I'd want to see fixed.

I will look into this, but probably not very soon.  If anyone would like to branch off of this and try something different, by all means, have at it!

Also, I believe the README would need to be adjusted to support the new workflow?

Yes, definitely.

repo: gnilrets/dbt-container-skeleton


text:
Additional fee subsidies per user.

In the future, we will want to have additional fee subsidies depending on the trader account. One example of a user that we may want to grant additional subsidies to in the future are users that are holding or staking a certain amount of BAL or GNO (or eventually GPT).

I think we can close this one in favor to https://github.com/gnosis/gp-v2-services/issues/1686.


text:
feat(tx-builder): review and confirm screen

What it solves
Resolves #320
Figma designs: https://www.figma.com/file/G7snLqBXWNPANcOj5MhiR7/Transaction-Builder?node-id=1%3A2
How this PR fixes it
Added React Router v6 to handle routing. Now we have only two routes defined in routes.ts file:

/ path with the Dashboard Screen.
/review-and-confirm with the new Review and Confirmation Screen

Extra
Added the new Header component.
Added some minor improvements about some minor visual issues described in this other PR:

Links to Block Explorer are not implemented in this PR, because currently, we do not have access to this data:

How to test it
Screenshots

Hi! a couple of notes from my end:
-I think that it would be neat & more convenient for users to keep the form cached when going 'back to transaction creation screen'.

-I feel like some padding between the method & the method data would help improve presentation.

Maybe also use a smaller font for the method names as well?:
-What about changing the “Create batch” button text on the main screen of the tx builder to “Review batch” seeing that we now have this awesome screen?

-What about changing the color of the cancel button from green to a more aggressive red? as all data is going to be removed and flow will need to be restarted from zero when clicking it.

Cheers!

Another small note and a question regarding this pop up:

-Keep in mind that signing and or signing + executing the batch can have already happened when sending the batch (thinking on 1/1 thresholds, for example) making the "You can now sign and execute it" not that accurate.
Un saludo ;)

After sync with Lila, as said by Jago, Cancel button should use RED color.
Also "Create batch" can be renamed to "Review batch"

All good! Top job with the feature and the fixes / improvements ;)

authors: DaniSomoza JagoFigueroa dasanra

repo: gnosis/safe-react-apps


text:
Allow certificates errors only for the Electron-created back end

What it solves
This commit ensures that the Electron app allows only the Electron-created backend at https://localhost:5000 to have an invalid (self-signed) certificate.
How this PR fixes it
Instead of appending 'ignore-certificate-errors' to the command line, catch certificate errors and check the associated origin.
Reference: https://www.electronjs.org/docs/latest/api/app#event-certificate-error

Pull Request Test Coverage Report for Build 1607527724

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 32.278%

Totals

Change from base Build 1607185745:
0.0%

Covered Lines:
3083

Relevant Lines:
8488

💛  - Coveralls

Thank you for all the PRs @Vasco-jofra!

authors: Vasco-jofra coveralls katspaugh

repo: gnosis/safe-react


text:
Show a meaningful error message on Safe creation

It was saying just "Safe creation failed". I've added an actual error message.

Pull Request Test Coverage Report for Build 1678265135

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 32.43%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/routes/opening/index.tsx
0
1
0.0%

Totals

Change from base Build 1677658745:
0.0%

Covered Lines:
3113

Relevant Lines:
8552

💛  - Coveralls

Is this the message expected?

Looks like there's an error in that error. Will fix.

Added a workaround for formatting issue.

Other errors seem more legible:

Looks good to me. Had both messages just fine (one on each attempt)

authors: coveralls francovenica katspaugh


text:
🛑 Beacon RPC is down

In 162d783, Beacon RPC (https://rpc-gbc.gnosischain.com/eth/v1/beacon/headers) was down:

HTTP code: 503
Response time: 300 ms

Resolved: Beacon RPC is back up in c05f988.

repo: gnosischain/gnosischain-uptime


text:
Fix docker registry error on Nexus and coding.net Registry

Which changes (Bug/Feature):

Fixes #188
Special notes for reviewers:
使用strings.EqualFold进行忽略大小写的比较
使用strings.index来进行字符串判断，防止截取意外的“=”

Codecov Report

Merging #189 (679c393) into master (c14ef35) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #189   +/-   ##
=======================================
  Coverage   22.36%   22.36%
=======================================
  Files           8        8
  Lines         304      304
=======================================
  Hits           68       68
  Misses        234      234
  Partials        2        2

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

authors: codecov-commenter sampsonye

repo: go-atomci/atomci


text:
可以多个字段吗？

以前用过Lucen，比如一文章，有标题，内容，创建时间，在建索引时我可以设置标题的权重0.7，内容的权重0.3，创建时间保存，但不参加索引。
不知道用你这个可不可以做到这样的效果。

Fields, Score field.

repo: go-ego/riot


text:
On minimize, on resize, on close events

Is this possible with go-flutter?

Using a https://github.com/go-flutter-desktop/go-flutter/wiki/GLFW-Plugin-example yes

repo: go-flutter-desktop/go-flutter


text:
gitea keys fails: Forbidden attempt to access internal url

Gitea Version
1.15.6-rootless
Git Version
No response
Operating System
No response
How are you running Gitea?
I'm running the "gitea:1.15.6-rootless" docker image under rootless podman.
Database
MySQL
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
https://gist.github.com/rmsc/b4bcdec9ee84cd67a2ed2f1870ce73d2
Description
I'm using gitea keys in an AuthorizedKeysCommand. ~It used to work in at least in version 1.15.4~, but is not working anymore, and is failing with a weird error:
$ sudo -u git /usr/bin/podman exec -it gitea-app /usr/local/bin/gitea keys -u git -t ed_25519 -k <REDACTED>
2021/10/30 22:02:52 main.go:117:main() [F] Failed to run app with [/usr/local/bin/gitea keys -u git -t ed_25519 -k <REDACTED>]: Failed to update public key: readObjectStart: expect { or n, but found F, error found in #1 byte of ...|Forbidden
	|..., bigger context ...|Forbidden
	|...

The error happens regardless of whether the key is correct or not. The server log reports a Forbidden attempt to access internal url, as per the provided log gist.
Screenshots
No response
EDIT: I'm not so sure I was using the rootless version of 1.15.4 when it worked.

$ sudo -u git /usr/bin/podman exec -it gitea-app /usr/local/bin/gitea keys -c /path/to/app.ini -u git -t ed_25519 -k <REDACTED>

That did help, thanks! Now I get:
$ sudo -u git /usr/bin/podman exec -it gitea-app /usr/local/bin/gitea keys -c /etc/gitea/app.ini -u git -t ed_25519 -k <REDACTED>
2021/10/31 07:52:12 main.go:117:main() [F] Failed to run app with [/usr/local/bin/gitea keys -c /etc/gitea/app.ini -u git -t ed_25519 -k <REDACTED>]: Failed to update public key: public key does not exist [id: 0]

2021/10/31 07:52:12 Started POST /api/internal/ssh/authorized_keys for [::1]:51002
2021/10/31 07:52:12 Completed POST /api/internal/ssh/authorized_keys 500 Internal Server Error in 991.758µs

The key does exist.
One thing that is weird is that there are 3 config files in the system:

/etc/gitea/app.ini containing the main configuration
/etc/gitea/conf/app.ini containing the INTERNAL_TOKEN
/var/lib/gitea/custom/conf/app.ini also containing the INTERNAL_TOKEN

I would expect the main config to sit in /etc/gitea/conf/app.ini so that it's picked up by the cli. Any reason why that isn't the case?

My bad, the key type I was entering was wrong. It should have been -t ssh-ed25519 instead of -t ed_25519. Now AuthorizedKeysCommand works fine. Thanks!
Now regarding the config files, I did a clean install on a new VM, and now the only configuration file is /etc/gitea/app.ini. Any reason for that location rather than /etc/gitea/conf/app.ini?

OK I think it's time we start compiling the docker build with the appropriate linker commands so that gitea just looks in the right places without having to use -c

@zeripath that would be great!

authors: rmsc zeripath

repo: go-gitea/gitea


text:
Migration stuck for some repos

Gitea version (or commit ref): 1.11.0+dev-155-gdce22efbe
Git version: whatever runs on try.gitea.io
Operating system: whatever runs on try.gitea.io
Database (use [x]): whatever runs on try.gitea.io

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[X] Yes (provide example URL) : https://try.gitea.io/pcsv/Pix-Art-Messenger
[ ] No
[ ] Not relevant

Log gist:

Description
Trying to migrate https://github.com/kriztan/Pix-Art-Messenger with issues, wiki, pull requests and releases to Gitea, the migration is stuck, and the repo inaccessible.
No Settings tab either, so it is impossible to cancel the migration or delete the broken repo.
Screenshots

@lunny
This is clearly a kind/bug.
The migration fails silently and the animation is running forever.
Not even the first issue (which is a PR with deleted branches) is migrated properly.

I think we can add a cancel button here.

@lunny
Sure, but that does not fix the underlying problem. The migrations fails somehow, always, reproducible with the repo mentioned above https://github.com/kriztan/Pix-Art-Messenger

it works on gitea.com ( 1.11.0+dev-110-gc4bc5abda)
and 1.9.5 (with a timeout message but it works)
but not on (1.11.0+dev-163-g86a44f6b4 ) try.gitea.io

maby some space limitations based on user? or something like that?

@lunny what happen wen a user run out of granted space when he has a migration job?

@6543 The repository should be deleted if any error found on the migrating. And a notice will be displayed on admin panel notices.

As an enhancements for the migration process, I will send another PRs to split the process as serval parts.

@6543
No it does not work when migration with issues and pr, please read the original issue description:

with issues, wiki, pull requests and releases to Gitea, the migration is stuck, and the repo inaccessible.

Imho problem is that if Gitea is restarted while migration is running it will be left unfinished

@lafriks
@lunny
No, it happens always on any instance, not only when restarting.
We did not restart try.gitea.io (we can't) and it happens on our test instance also. You can reproduce it easily by migrating https://github.com/kriztan/Pix-Art-Messenger

@ashimokawa I will try that repository.

I started to debug this a bit and ran out of time but if it is helpful for you @lunny what is happening is that at some point inserting a batch of releases from this repo is throwing the error:
UNIQUE constraint failed: release.repo_id, release.tag_name

And then it goes into rollback but never comes out. It seems to get here:
https://github.com/go-gitea/gitea/blob/45f219239e420f707a2452b99b27a68f45d5d4ca/vendor/xorm.io/xorm/session_delete.go#L211
And then the it hits this code and seems to never really do anything after that:
https://github.com/go-gitea/gitea/blob/45f219239e420f707a2452b99b27a68f45d5d4ca/vendor/xorm.io/xorm/session_raw.go#L177-L179
That runs some code in the specific driver for the database, but I'm able to reproduce on sqlite3 and assume try.gitea.io and codeberg are using something else so I wonder if it just isn't returning an error where it should at some point. Not familiar with xorm at all though :-/
I tried with lafriks patch too but seems unrelated in this case (though helpful in general)

@mrsdizzie
Yep, codeberg.org runs mariadb and not sqlite.
I assume you tried the repo I mentioned with full migration?
The only thing a saw in logs is that a rollback failed (timout? stuck?), I really do not remember because I was also in a hurry.

@mrsdizzie Thanks for your work!
So
UNIQUE constraint failed: release.repo_id, release.tag_name

means there are duplicated releases on that repository??? I will take a look at that code.

I can confirm that migrating the repository without releases works.

It seems unusual that there would be a duplicate release, as I'm not sure that git allows same tag to be used twice. Regardless of that assumption, I am able to replicate same error as above, but able to have successful migration when release is unchecked (I tested on sqlite as that's what I am using on my dev instance, but will try with postgres later, as that's whats on my prod instance).

It could be a bug in the migrating that perhaps tries to insert the same release twice as well.
The 100% certain bug is that the rollback isn't finishing but I didn't know enough about xorm etc to really figure out why that is happening here.

#9319 shoud fix another bug but not this one. But @ashimokawa , you can still try it.

The specific example from this issue should be fixd, see:
https://try.gitea.io/mrsdizzie/Pix-Art-Messenger
But the original issue exposed a lower level bug in rollback that is still present (though not triggered anymore through this issue) and should probably stay open until that is fixed.
Plus there are the other aspects like not being able to cancel a migration that is stuck for any reason which should be possible

@mrsdizzie it could be deleted from admin panel currently. :)

@lunny
I can confirm that the specific case I opened this issue for is fixed. So normally I would close this one.

@lunny @mrsdizzie
Stuck repos can be deleted by the user by just manually navigating to his settings, even in that stuck state.
https://try.gitea.io/mrsdizzie/Pix-Art-Messenger/settings
Don't know if that is good or not.

@ashimokawa :)

There is no link to that settings page if it is stuck migrating (though visiting the URL directly works). So it is good but could be better.
I think the general bug still exists that it shouldn't be possible for it to get stuck at all (it should work or fail), but now this example will not trigger it so perhaps harder to reproduce. @lunny maybe if you have time to look at the xorm code from above, if not then I'm not sure : ) Glad that this example helped fix the bug causing it anyway so thanks!

I faced the issue while migrating https://github.com/jitsi/jitsi-meet.
See https://try.gitea.io/dashadsh/jitsi-meet for the reproduced problem.

Just had this happen to me after migrating many repos to my backup site.  How does not get rid of this aborted migration?  Not via the webui as there is no access to "settings" since the migration was not completed.  I restarted my instance and web server but it must be in the db itself.  How can on repair the git.db?
Of Note.  I see that I had 7000+ pages of system notices all one date all about not being able to access the main git from which the migrations come.  This backup install has been acting funny too.  Slow page loads, popup notices above loosing data if moving to another page which I wasn't.  I'm guessing this is a corrupted data base maybe from loading up on all those system notifications.  7000 pages is excessive no :-).   Luckily I have daily backups and a backup from when I upgraded in Jan.  Will try those if I can solve this otherwise.

I was able to delete all the notifications via the UI and under site administration /admin/repos I was able to delete the offending migration.
I then attempted to make anew the migration and it was the same issue :-(
I have been using 1.1  now going to try upgrading to 1.96.

I upgraded both installs to 1.9.6.  I deleted and recreated the offending repo on the main gitea install and pushed it again from local.  Then tried again to make a migration on my backup gitea from main gitea install and YEA that worked.
So only 2 issues for me now.

that my git.db on my backup install is still 47mb.  Apparently sqlite has no way to compact after deleting all those pages of notifications? https://www.recoveryandmanagement.com/repair-sqlite-database-manually/

Why did gitea create 7000 pages worth of notifications/logs.  Was that 'bug' fixed going from 1.1 to 1.9.6?

That admin notices could be deleted after your problem resolved.

@dkebler Sincerely, 1.1 was so long ago... so many things have changed since then: refactors, rewriting, updating libraries... I'd even suggest you upgrade to 1.11.3 while you're at it; a lot of good features and bugfixes were added since 1.9.6 already.

I found the bug like this.

Gitea version (or commit ref):1.11.4
Git version:2.17.1
Operating system:linux
Database : SQLite
When I  Migration a Repositories from gogs(,need a user name a password ,but I don't give,so
the task is in dead loop.(This bug is also in gogs.)

@qdzhaov What version of Gogs are you migrating from? (I take it's not an upgrade but a site-to-site migration)

I've upgraded from 6af13dbac to 15d3aa7b95e37cc2e9a06208089169cbe04383b5, because I had this issue on the former version. Now the issue is gone and mirroring works.

I encounter the issue of migration getting stuck while trying to mirror https://github.com/apache/spamassassin to my Gitea instance, using Gitea 1.14.8 on Debian 10. Restarting the Gitea server did not fix the importing for me.

using Gitea 1.14.8 on Debian 10

Currently Gitea is version 1.12.4 heading towards 1.13.

@1byte2bytes found a bug related to DefaultBranch != "master" - it could have hit you ...

(#12843)

ok since Pix-Art-Messenger can be migrated (tested) I think it's time to close this issue
@1byte2bytes if gitea v1.12.5 has ben released and it still does not work, feel free to create an issue :)
and for cancel suggestions: (#12845)

authors: 1byte2bytes 6543 Codeberg-org ashimokawa dkebler guillep2k jolheiser lafriks lunny mrsdizzie qdzhaov saurasambit techknowlogick theAkito


text:
add request review from specific reviewers feature in pull request

add a way to notify specific reviewers to review like github , by add  or delet a  special type
review . The acton is  is similar to Assign ,  so many code reuse the function and items of
Assignee, but the meaning and result is different.
The Permission style is is similar to github, that only writer can add a review request from Reviewers,
but the poster can recall and remove a review request after a reviwer has revied even if he don't have
Write Premission. only manager , the poster and reviewer of a request review can remove it.
The reviewers can be requested to review contain all readers for private repo , for public, contain
all writers and watchers.
The offical Review Request will block merge if Reject can block it.
an other change: add ui otify for Assignees.
screenshots:

@lafriks Thanks for your checking!

Codecov Report

Merging #10756 into master will decrease coverage by 0.04%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master   #10756      +/-   ##
==========================================
- Coverage   43.53%   43.48%   -0.05%
==========================================
  Files         589      589
  Lines       82683    82875     +192
==========================================
+ Hits        35993    36038      +45
- Misses      42221    42361     +140
- Partials     4469     4476       +7

Impacted Files
Coverage Δ

models/branches.go
41.76% <0.00%> (ø)

models/issue_comment.go
46.68% <ø> (ø)

modules/notification/base/null.go
66.66% <0.00%> (-2.09%)
:arrow_down:

modules/notification/mail/mail.go
27.02% <0.00%> (-1.96%)
:arrow_down:

modules/notification/notification.go
76.97% <0.00%> (-2.29%)
:arrow_down:

routers/repo/issue.go
36.67% <0.00%> (-1.21%)
:arrow_down:

services/issue/assignee.go
34.88% <0.00%> (-16.85%)
:arrow_down:

models/review.go
32.68% <4.39%> (-10.07%)
:arrow_down:

modules/notification/ui/ui.go
64.10% <48.00%> (-6.27%)
:arrow_down:

models/notification.go
64.32% <60.00%> (-0.39%)
:arrow_down:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c61b902...d98e20a. Read the comment docs.

@guillep2k hello, I have changed it follow your suggestions,  about reviewers who can be requested to review, add all readers for private repo, but olny add all watchers and writers in repo , because , readers mean all user in the platform for a public repo, but It's not necessary, Because people who don't watch it won't like to make a review for this repo.

I'm not sure using the watchers list is a good idea. A public repository's branch could have a very limited number of reviewers, and they may or may not be watching the repo. Or repositories like Gitea may have hundreds of watchers (currently 460). Maybe we could use the "watchers" function for branches that are not protected (or have no reviewer restrictions) but use the list of official/whitelisted reviewers when the target branch has one.
By the way, a public repository whose owner is a hidden organization (visible: false) should be considered like a private repository.

@guillep2k Hello, I'm sorry , but I can't fully agree with you,  first this list only show who can be requested to review not help users to choose, And in gitea any user who can read can make a review. but for the public repo, which will become a problem , Because if not have some additional limit, which will mean all users in the platform should in this list, but it's not necessary. So only add offical users (which can found in accesses table) and watchers, but I really forget the whitelisted reviewers for protect branches,  they should alse be check and add to this list. and also because this list may become very big  I add a filter box which is provided by "Semantic UI" , and may be it should become a search because load many users may cost too much time, but now I have no idea about how to do it . that's my think. thanks

As long as the whitelisted users for the target branch is included in the list, I'm OK with that.

@guillep2k Hello, after carefully check , I think It's not necessary to load  whitelisted users or groups
because thy all can be found in accesses table, which has been load firstly. so It's not necessary to load them again. you can see these codes:
https://github.com/go-gitea/gitea/blob/209045f55b1cfdb6e52fa7a67078c1a4edb1cf4f/routers/repo/setting_protected_branch.go#L120-L125
they just use users who can found in accesses table.
and all users in the teams of the own  organization can be found in by this way also.
So , that means after these code. all users who can be choose into whitelisted users or the groups has been loaded by these codes:
https://github.com/a1012112796/gitea/blob/69e40d604fe77fc3e5460a9c63ee962ead7eb33a/models/repo.go#L665-L674
so it's not necessay to load again. Do you think it's right ,thanks.

When possible, please try to avoid force-pushing a large PR like this. Github loses track of what changes where reviewed and review comments get orphaned. 😓

When possible, please try to avoid force-pushing a large PR like this. Github loses track of what changes where reviewed and review comments get orphaned. 😓

Sorry , I forgort to split new changes. do  force-pushing is to make my brabch base on the latest commit in master, and get a simple comit history. I will tI'll be careful next time.

Sorry I kept using "whitelisted reviewers", while the proper term should have been "official reviewers". That must have been confusing. 😅

Please resolve the conflicts.

Hello, I have  resolved the conflicts and do some ui changes, please review , Thanks.
@lunny @guillep2k @zeripath ....

Great work, looks good now ;)

Make lgtm work

It's better to add the feature in comparsion doc.


text:
Fix issue with issue default mail template (#16956)

Backport #16956
The mail template rendering was failing with the error -
...vices/mailer/mail.go:301:composeIssueCommentMessages() [E] ExecuteTemplate [issue/default/body]: template: issue/default:65:10: executing "issue/default" at <.i18n.Tr>: can't evaluate field i18n in type *models.Comment
The issue was the template variable i18n is available in the outer scope.
Fix #16877

@delvh if you dont mind please have a look at discord :)

make L-G-T-M work

@delvh Please apply as a maintainer of Gitea(since you have submitted over 4 PRs merged), otherwise your approval will not be counted.

authors: 6543 lunny prasadkatti


text:
Refactor mirror code & fix StartToMirror (#18904)

Backport #18904.

The potential break is when those instances have tasks in the mirror disk queue when upgrading.

I know ... just oint that up to admins on release info

authors: 6543 Gusted lunny


text:
Cache statistics and provide estimation methods

Currently whenever the prometheus metrics endpoint or /admin endpoint are viewed
the statistics are recalculated immediately - using COUNT rather than a less expensive
method.
This PR provides a mechanism to cache these statistics, avoids generating all of the
metrics on the admin page and provides an estimation method for the plain table counts.
Fix #17506
Signed-off-by: Andrew Thornton art27@cantab.net

Maybe it's database's responsibility to optimize the select count(*)?

Maybe it's database's responsibility to optimize the select count(*)?

All (at least most) transnational database's COUNT(*) is a full table (index) scan.

Since there is a new related PR #19561 , I still think the mechanism should be simplified to providing estimated numbers without cache, with no setting option.
Complexity is the enemy if it's not a must. If the accurate numbers don't help admins really, then it's not necessary to make it complex. It's not ideal to introduce more and more (not-that-useful) options, now there were 4 new options, if there are other similar requirements in future then there will be 6 or 8 options which doesn't help users really.
And simplified code would help other PRs like #19561 and maybe more.

I must absolutely disagree about the cache. We should be caching these statistics.
It's insanely wasteful to be repeatedly recalculating these results everytime you go to the admin dashboard.
I also disagree about whether we should be simply providing estimates or not. If drop to Estimates by default we will IMMEDIATELY receive complaints from people because the numbers are "incorrect". It's simply not worth the hassle.

In terms of providing estimates the non-simple counts, e.g. the UserCount in postgres we can use:
EXPLAIN SELECT COUNT(*) FROM `user` WHERE `type`=0;

and postgres will return something like:
                            QUERY PLAN
------------------------------------------------------------------
 Aggregate  (cost=10.25..10.26 rows=1 width=8)
   ->  Seq Scan on user  (cost=0.00..10.20 rows=20 width=0)

Extracting the rows=... from this will give a reasonable estimate of the number of rows.
MySQL also has EXPLAIN and will return the numbers of rows in a rows column but I'm not sure whether it will provide a quicker estimate.
For MSSQL we likely need to add a NONCLUSTERED COLUMNSTORE INDEX on to the appropriate columns.

. If drop to Estimates by default we will IMMEDIATELY receive complaints from people because the numbers are "incorrect". It's simply not worth the hassle.

I disagree that we should make code more than complex just because of some non-sense complaints.
There are 2 kinds of complaints, one is that the user is really hurt, one is that the user doesn't know what they want or what they are doing.
For this case, I believe it's kind two (users do not know what they want). Do users really know what the accurate action/comment number mean? Will they be really hurt by estimated numbers to make wrong decisions?
And if you use cache, when the underlying number keeps changing (like comments/actions), do users really get accurate numbers? They are already contradictions, because in they end they still read the estimated numbers instead of the accurate ones.

Could there be some compromise plans that for small tables like user always use accurate numbers, for large and non-sense tables like comment/action just use estimated numbers? Then no more option, no complex code and no complaint.

OK I've dropped the ESTIMATE_COUNTS option.
You can field and answer the issues when they complain - because they will.

OK I've dropped the ESTIMATE_COUNTS option.
You can field and answer the issues when they complain - because they will.

Could we make a poll about how to continue?

Introduce new options ESTIMATE_COUNTS=true/false, STATISTICS_TTL=5m (totally 4 new options) (vote 🚀 )

(vs) Introduce no option, just tell users some numbers are estimated (vote: 🎉 ), what I mean is:

there are too many options already, if a new option doesn't really help users, then we should avoid it.
write the StatisticsTtl as a const to 5m in code, if there is any real requirements, use a new simple PR to make it an option next time. Do not pay the not-happened-yet cost for future.
for small tables like user / repository, Gitea can provide accurate numbers. Because on the user/repository list page, these tables are always counted, so accurate counting is fine.
for large tables like attachment / action / comment, estimated numbers are enough because accurate numbers helps nothing, when the table becomes large, it only wastes the database's performance.
on the dashboard UI, tell users the some numbers are estimated, by using a unicode char ≈.
I could take all the work I described (I could work on this PR directly if you don't mind)

Indeed, my personal opinion might be wrong (and it's not a blocker). If nobody else likes any of the idea, such improvement can not get merged.

Can't we just cache values and reset cache on specific events (user created/deleted etc)?

Codecov Report

Merging #19474 (da9579d) into main (59b30f0) will decrease coverage by 0.13%.
The diff coverage is 53.48%.

:exclamation: Current head da9579d differs from pull request most recent head 27f8b14. Consider uploading reports for the commit 27f8b14 to get more accurate results

@@            Coverage Diff             @@
##             main   #19474      +/-   ##
==========================================
- Coverage   47.39%   47.26%   -0.14%
==========================================
  Files         956      958       +2
  Lines      133115   133426     +311
==========================================
- Hits        63093    63062      -31
- Misses      62393    62708     +315
- Partials     7629     7656      +27

Impacted Files
Coverage Δ

cmd/admin.go
0.00% <0.00%> (ø)

cmd/doctor.go
0.00% <ø> (ø)

cmd/hook.go
7.11% <0.00%> (ø)

cmd/serv.go
2.33% <0.00%> (ø)

cmd/web_acme.go
0.00% <0.00%> (ø)

models/asymkey/gpg_key.go
58.64% <0.00%> (ø)

models/asymkey/ssh_key_authorized_keys.go
16.15% <0.00%> (+0.24%)
:arrow_up:

models/asymkey/ssh_key_principals.go
5.63% <0.00%> (+0.50%)
:arrow_up:

models/db/context.go
70.10% <0.00%> (-14.90%)
:arrow_down:

models/error.go
35.87% <ø> (-0.90%)
:arrow_down:

... and 242 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa5dec9...27f8b14. Read the comment docs.

After long time, nobody complains that "the action is not accurate".
I have 100% confidence that my conclusion is right: no need to do more ticks for these large tables.
In the following PR, I will do:

Remove the "estimated action number"
Move the statistics to a separate page to avoid it affecting the default admin dashboard page's loading time.

So this PR could be closed.

authors: codecov-commenter lafriks lunny wxiaoguang zeripath


text:
Refactor validaton package (#19478)

Backport #19478

Conflict


text:
Fix dashboard feed icon color

https://github.com/go-gitea/gitea/pull/25790 had changed this icon color to body text color, revert it to previous shade. Before and after:

The icon also lost its margin on right side. I think it looks better with some margin, will check.

Replaced by https://github.com/go-gitea/gitea/pull/26829.


text:
Only do counting when count_only=true for repo dashboard

Ref: #29878

I was unable to create a backport for 1.21. @wxiaoguang, please send one manually. :tea:
go run ./contrib/backport 29884
...  // fix git conflicts if any
go run ./contrib/backport --continue

authors: GiteaBot wxiaoguang


text:
Update TRANSLATORS

Hi,
I'm the guy who translated gitea during June in Italian.
I would like to have my name added to the translators list.
I translated nearly a thousand and a half words.
Thank you.
Please check the following:

Make sure you are targeting the master branch, pull requests on release branches are only allowed for bug fixes.
Read contributing guidelines: https://github.com/go-gitea/gitea/blob/master/CONTRIBUTING.md
Describe what your pull request does and which issue you're targeting (if any)

You MUST delete the content above including this line before posting, otherwise your pull request will be invalid.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e500b82). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #5194   +/-   ##
========================================
  Coverage          ?   37.5%
========================================
  Files             ?     309
  Lines             ?   45791
  Branches          ?       0
========================================
  Hits              ?   17172
  Misses            ?   26158
  Partials          ?    2461

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e500b82...9db2e9c. Read the comment docs.

@briolantonio thanks for PR, and also thank you for translating many words 😄

authors: briolantonio codecov-io techknowlogick


text:
'Record not found' when calling db.Create()

GORM Playground Link
https://github.com/go-gorm/playground/pull/119
Description
See pull request. Added bug description into the code.

Hi @Techassi
Seems no issue in your tests, but I think you might got this issue, check out the breaking changes
https://gorm.io/docs/v2_release_note.html#Method-Chain-Safety-Goroutine-Safety

Noted!
I already thought about the new re-use system. So thank you for pointing me to the right direction and confirm my suspection.

Hi @jinzhu
To be perfectly honest this change makes ma life so much more harder. Take this simple scenario for example:

A new user of some service wants to register to said service, it fails with the error Error 1062: Duplicate entry 'Test' for key 'PRIMARY' because the username already exists (For this example we will use the username Test)
The user with the username Test wants to login, it fails with the same error as above (Error 1062: Duplicate entry 'Test' for key 'PRIMARY') because of statement re-use.

So basically I am forced to make all by DB calls use WithContext() like
err := db.WithContext(context.Background()).Where("username = ?", username).First(user).Error

or
err := db.WithContext(context.Background()).Create(user).Error

I don't feel like this is either intended or a very programmer-firendly way to make DB queries. I look forward to your opinion @jinzhu

Any update on this @jinzhu ?

it is clearly described and there is a detailed example in the document.
You don't always need a WithContext method but only when you are sharing your db conditions, which is not a common case in your whole application.

Thank you @jinzhu
Well I read through the linked document. Still the above example should NOT fail. I am NOT sharing any conditions and still the returned error persists across two totally different queries. Is this intended behaviour?
Can you please comment on the above example and why the error persists across multiple database calls.

can you make the tests run & fail？

I'm having the same issue but with v1. The problem is that when executing db.Create(), instead of issuing an INSERT as expected, the resulting query is a SELECT * FROM "table" WHERE "table"."id" = 0, which of course returns a record not found error.
In v1 there doesn't seem to be a WithContext() method, and I'm honestly at a loss on how to fix this.

authors: Techassi ahmed-abderraham jinzhu

repo: go-gorm/gorm


text:
youtube-roomID2

大佬你好，我刚刚发现有些ID是user或C的，还有些官方频道是直接用的ID的，希望大佬有空适配一下。
https://www.youtube.com/user/elliegoulding
https://www.youtube.com/c/EliminateHQ
https://www.youtube.com/insomniac

https://support.google.com/youtube/answer/6180214
你发的这几个是 YouTuber 个人定制化的 url, 而 channel ID 是目前通用且一定存在的，
具体操作可以随便点进一个视频，再通过视频页点进 YouTuber 的主页就能看到了

明白了，谢谢大佬，还有一个情况，如果一个用户同时开着两个直播间，可以选择全部都录吗

哈哈，youtube 就是这点和其他的平台不一样，一个频道可以能同时开多个直播间
因为我当时录的主播只开了一个，所以目前是只录了第一个直播间

authors: luxcgo mbskter

repo: go-olive/olive


text:
How can I set a table prefix from config???

I use github.com/qiangxue/golang-restful-starter-kit bun can`t find, how can I set table_prefix from config
server.go > buildRouter () {
...
artistDAO := daos.NewArtistDAO()
apis.ServeArtistResource(rg, services.NewArtistService(artistDAO))
}

Error:
level=error msg="Error 1146: Table 'db.table' doesn't exist"
I need set table-prefix from config by this query "SELECT * FROM db.prefixTable ..."

You can set the whole table name by implementing the TableModel interface:
type TableModel interface {
    TableName() string
}

E.g. like
func (ArtistDAO) TableName() string {
    return "myprefix_artists";
}

or
    // snip
    return myDynamicPrefix()+"artists"

but I do agree with you that a prefix would be very helpful. Currently having the same prob here. Maybe one should implement it and make a pull request.

About to implement that. One topic I'd like to discuss:
struct.go defines
251:  func GetTableName(a interface{}) string {
...:      // snip
268: }

as a static function. Is there a reason to implement it statically instead of an instance method of *DB for example? The latter would allow to configure it in a clean way and also allow to use ozzo-dbx multiple times in a single process, possibly connecting to the same DB instance only using different table prefixes.
I'd personally prefer that latter implementation and would (if not suggested differently here) leave the old static method in for now so that software already using ozzo does not have to be changed.
Comments?

Implemented with pull request #69

authors: kPshi maksym-kasianov-nikohdiuk

repo: go-ozzo/ozzo-dbx


text:
Is there anyway parse url.values direct to map[string]any

So How can I parse formdata to map[string]any directly like laravel?

not sure what the ask is here?

not sure what the ask is here?

I must use a struct to unmarshal a form data. So there is a method to unmarshal a form data to a anymouns map[string]any ？

repo: go-playground/form


text:
InsertMulti() does not update primary key field

Is your feature request related to a problem? Please describe.
When bulk-inserting via Querier.InsertMulti the primary key field on the structs are not updated with the key it was assigned after inserting. This seems on purpose since a comment on the method notes this behavior. This makes it difficult to use, especially if you plan to assign those IDs to foreign-key fields of another set of structs to bulk-insert. I'm open to attempting to add this functionality, but wanted to first see if there's a specific reason why this was excluded or cannot be done.
Describe the solution you'd like
The structs have their primary key field populated after bulk-inserting.
Describe alternatives you've considered
None yet.

wanted to first see if there's a specific reason why this was excluded or cannot be done

That's because I don't know how to implement that functionality with databases and drivers that use LastIsnertId() (like MySQL) and don't want to implement only for some databases/drivers (like PostgreSQL), but not others.

authors: AlekSi mikestefanello

repo: go-reform/reform


text:
Tuple validation requires all items

Problem statement
When generating a model with array defining a tuple, the generated validation code requires all items to be present in an instance of the tuple.
But the JSON schema 4 spec states that tuple items are not required.
Environment
swagger version: master
go version: 1.9.1
OS:

The way I see this validation is that:

it should be allowed to be Zero provided the previous tuple property is defined (they cannot be arbitrarily zero: only trailing elements may be omitted)

Any thought?

Did I misunderstood this reading: https://cswr.github.io/JsonSchema/spec/arrays/ ??

Note that the default behaviour of JSON Schema allows us to have fewer items, as long as the
corresponding (sub)schemas are satisfied.

it has to validate as a schema on that same position so they are not optional when there is more than 1
https://tools.ietf.org/html/draft-handrews-json-schema-validation-01#section-6.1.1
   The value of "items" MUST be either a valid JSON Schema or an array
   of valid JSON Schemas.

   This keyword determines how child instances validate for arrays, and
   does not directly validate the immediate instance itself.

   If "items" is a schema, validation succeeds if all elements in the
   array successfully validate against that schema.

   If "items" is an array of schemas, validation succeeds if each
   element of the instance validates against the schema at the same
   position, if any.

   Omitting this keyword has the same behavior as an empty schema.

if any  is important
In our code, we pass through all P_n_ properties and check they are required.
This means that if, say, the last one is omitted the validation fails.
I understand it is positional, so P_n_ may not be omitted if P_n+1_ is  already there.

it will always need something there whether it's null or something that passes validation, but it can't skip positions. This makes it requred

OK so here are some facts.
Here is a simple schema generating a tuple:
{
  "type": "array",
  "items": [
    {
      "type": "string",
      "enum": [
        "CONST1",
        "CONST2"
      ]
    },
    {
      "type": "string",
      "enum": [
        "CONST3",
        "CONST4"
      ]
    }
  ]
}

Here is the model generated from this schema (attached).
tuple_thing.go.txt

NOTE: The generated code has been slightly modified: the unmarshalling fails on nil pointers.
This is another bug and this story shall also be told...

Here is the sample data to be validated:
Fixture 1: [ "CONST1", "CONST3" ]
Fixture 2: [ "CONST1" ]
Fixture 3: [ "CONST3" ]
Fixture 4: [ "CONST1", "CONST3", "anything" ]
I tested validation with: generated model validator, go-openapi/validate validator, node JS ajv and python jsonschema validator.

Fixture #
Model validator
go-openapi/validate
ajv
python
comment

1
Pass
Pass
Pass
Pass
as expected

2
Fail
Pass
Pass
Pass
incomplete tuple should pass

3
Fail
Fail
Fail
Fail
as expected because of the enum constraint

4
Pass
Pass
Pass
Pass
as expected because default additionalItems=true*

: model validator just ignores additionalItems=[true|false]

authors: casualjim fredbi

repo: go-swagger/go-swagger


text:
Client template interfaces

Trying to complete #1981

fixes #1138

Supersedes #1981
NOTE: TODO regen examples

I'm sorry that I didn't put more effort into finishing what I started. I got a bit confused by the pipeline failures since I'm not too familiar with the codebase.
I can help with the review process though, as I've ended up using a slightly modified version of these templates here.

authors: fredbi rokf


text:
请问支持 postgresql 有ip地址和mac 类型

我在文档里面没有找到关于postgresql 对于网络类型的支持，cidr,inet,macaddr,macaddr8(https://www.postgresql.org/docs/current/static/datatype-net-types.html)
请问当前有支持这个类型吗，或者有支持的计划吗？

请问，大概什么时候可以支持这个功能？

repo: go-xorm/xorm


text:
Manual ack/nacks

Hey there,
Thanks a lot for Hutch! I am really enjoying it. I am looking to do something that may or may not be possible today, if not, I am glad to help make it happen.
I see that broker.rb has a "nack" and "ack" method, however they seem to only be used by Hutch internally in "worker.handle_message" (maybe others). I "think" Hutch will only send a "nack" if it has a problem handling the message and not if it fails to complete the "work" the message entails.
Would there be a way for me to "nack" or "ack" from within Worker's job itself, vs having Hutch do it automatically? Specifically, would it be possible to implement this logic:
A) A worker who executes without exceptions sends an "ack" after successful execution.
B) A "nack" is sent if the worker code hits any exception.
My goal here would be that if my code hits an exception, a job is not lost, but later retried. Any advice appreciated!
Cheers,
Tim

@tvaillancourt Hutch currently acks successfully processed messages automatically. So what are you looking to do, ack manually or let Hutch do it?
Note that re-queueing on exception can (and frequently will) lead to very long or endless redelivery loops.

Thanks Michael!
I think what I'd specifically like to do is have Hutch send a "nack" if my Hutch worker encountered a Ruby Exception while working on the message. It would be cool if this was automatic or could be defined as some sort of Exception handler, but manual would be fine also.
Ultimately, my goal is to keep messages if my worker code is faulty or I cannot process the message somehow. In my scenario, a redelivery loop is better than a lost message, essentially.
Cheers,
Tim

After reviewing #168, I think there should be 3 acknowledgement modes:

automatic (as in Bunny)
manual (as in Bunny)
framework (current default, Hutch acks unless there was an exception)

The 3rd option may include what @teodor-pripoae suggested in #169.
Thoughts?

I think we can handle user defined callbacks on consumer level, similar to activerecord. I'm not sure the if the use case should be global or consumer based.
First option is the most clean one but not extensible, the 2nd and 3rd are more verbose.
class MyConsumer
  include Hutch::Consumer

  on_failure :requeue
  # or
  on_failure :failure_callback
  # or
  on_failure Proc.new{ requeue! }

  def failure_callback
    requeue!
  end
end

This looks good but I'd perhaps add it after we merge the new acknowledgement modes. This also needs to play well with exception loggers/collectors.

I threw together a way to customize what happens when a consumer fails. By default a nack is always sent. https://github.com/dkastner/hutch/commit/e9e3a1fb7ed038b88cab47197fd7824b5fb46558

This is in part addressed by #177. I'm curious how many people are interested in customizing when messages are (positively) acknowledged. I'd expect not that many, so maybe #177 addresses this entirely?

I would appreciate per consumer callbacks. Allows to handle those cases in context of the consumer instead of moving the logic too far, in another class.

authors: dkastner gottfrois michaelklishin teodor-pripoae tvaillancourt

repo: gocardless/hutch


text:
Event work

There were some inexplicable issues with tooltips when trying to implement the NO_TT flag.
I had to make run_event use signals to get everything straight.
Please refer to the individual commit messages for more information.

Very cool ! I like the idea of formalizing Escoria events as a class. It may even be interesting to externalize it it its own script if necessary.

Nice, thanks!
I was thinking of NO_TT (and maybe NO_HUD is around the corner if there's a strong-enough use case. or maybe CUTSCENE that disables hud and input), but then I started thinking that a clean event object could be useful in many ways...
Like we've talked about testing on IRC, that it would be useful to have something that runs events from the outside. Making them easy to create and inject would be a big win.
I think the code could be further developed to pass instances more around; now it's a bit like constructing them on the go. That will have to wait, because the immediate itch is scratched, but it's something worth keeping in mind.

authors: StraToN mjtorn

repo: godotengine/escoria


text:
3.0 Shading Language: Editor crashes when you enter letter as index

Operating system or device, Godot version, GPU Model and driver (if graphics related):
windows, nvidia, c71ee77
Issue description:
if you type character as index like blah[x] editor will crash
i know that it is wrong, i made a misstype, but crashing the editor is too much for a punishment

This should technically work as it's being checked, but here's the code in case anyone wants to inquiry more about it:
https://github.com/godotengine/godot/blob/master/servers/visual/shader_language.cpp#L2586

Operating system or device, Godot version, GPU Model and driver (if graphics related):
windows, nvidia, 50a9bd4e23e62579e2249de3c27624d6c56df1d0
Issue description:
Unable to recreate, and there seems to be an fix for this in 7764640f2241b5972a48665ff2e0d001aff0993c

Closing as fixed then.

authors: MarcusSvensson81 akien-mga curly-brace reduz

repo: godotengine/godot


text:
Interpolated particles between frames

Potential Related Issue
Interpolated particles #7850
Godot version:
Godot 3.0.6 from Steam
OS/device including version:
Win10, x86_64
GTX1070
Issue description:
When I try to use particles with local_coords = false to present a "trail" effect, it just emits particles on each frame and seems “discrete”.

The rotation of sword is driven by an AnimaitonPlayer.
Is there any way to emit these particles smoothly but not explode on each frame?
Steps to reproduce:
1.open unzipped project with godot 3.0.6
2.press f5 to run the project
3.press Space key to trigger animation
Minimal reproduction project:
interpolated_particles.zip

"set_fractional_delta" seems not work in Particles2D, but works in CPUParticles2D.

"set_fractional_delta" seems not work in Particles2D, but works in CPUParticles2D.

Could you please help to share any information about CPUParticles2D? Is that available on 3.0.6?

Could you please help to share any information about CPUParticles2D? Is that available on 3.0.6?

CPUParticles is already present on the master branch (which will become 3.1 in the future), but it is not in 3.0.6.

Closing in favor of https://github.com/godotengine/godot/issues/47973, which has more information about the issue at hand.

authors: Calinou JustusPan zhagsenkk


text:
godot 3.1 exe size

Hi
just noticed that my game size is a little big 34mb
i am using godot win32 version , maybe thats because godot was compiled using mingw
i am sure if you build it with MSVC the size will reduced dramatically

i am sure if you build it with MSVC the size will reduced dramatically

Try it and tell us :)

I dont know how :p
On Mar 16, 2019 22:10, "Rémi Verschelde" notifications@github.com wrote:

i am sure if you build it with MSVC the size will reduced dramatically
Try it and tell us :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/27140#issuecomment-473593014,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKT_82fOtMC4xYq8yjP-zeJssWRqb7W9ks5vXV2rgaJpZM4b4B6n
.

you can use UPX to compress your executable by the way
https://upx.github.io/

See Optimizing a build for size in the documentation.

Well I can already tell you that there is no significant size difference between MSVC and MinGW binaries nowadays. 34 MB is just Godot's size.
We switched from MSVC to MinGW between 3.0.2 and 3.0.3, see the size differences:
https://downloads.tuxfamily.org/godotengine/3.0.2/
https://downloads.tuxfamily.org/godotengine/3.0.3/
The Win32 zip for the editor build did go from 15.9 MB to 17.1 MB (7% increase), while the Win64 zip went from 19.3 MB to 17.3 MB (10% decrease).
Godot 3.1 is a bit bigger because it has a lot more features and some more dependencies.

yeah , you are right there is no big deference  , i don't know where i get the impression that msvc could generate significant smaller size !

godot 3.1 MSVC compiled sizes are
56 109 056 godot.windows.opt.tools.64.exe
28 927 488 windows_32_debug.exe
25 346 048 windows_32_release.exe
33 345 536 windows_64_debug.exe
29 228 032 windows_64_release.exe

authors: Calinou akien-mga avril-gh codz01 reduz


text:
event.relative in _input-function is broken on mac os

Godot version:

3.1 stable
OS/device including version:

Imac 5k, AMD Radeon R9 M390
Issue description:

Using the code form the official FPS demo.
In the _input function I update the cameras position by the event.relative position. If i press the left mouse-button and move the mouse simultaneously i get a laggy outcome. When the left mouse button is pressed the relative position creates a huge gap and the camera snaps to the new position. This ONLY happends on mac os, on windows it works just fine!
Heres an image of the relative position and what happends to it in the _input function(event) when the left mouse button get pressed.

Steps to reproduce:
For simplicity you could use: https://github.com/TwistedTwigleg/Godot_FPS_Tutorial
and run it on a mac os.
Minimal reproduction project:

https://github.com/TwistedTwigleg/Godot_FPS_Tutorial

CC @godotengine/macos

Can't reproduce on current master and 3.1 stable, relative mouse position seems identical with or without button pressed and smooth in both cases, macOS 10.14.4 (18E226), tested with ROG Sica wired and TeckNet WM289 wireless mouse.

well thats weird. Im using the same macOS version. I've bootcamped my imac and tested on windows aswell. On windows its all smooth, but on macOS its not.

@bruvzg @grusad Can you share details about the monitor you're usiing? I have a hunch this may be related to retina screen scaling.

@samgreen Im using the 5k monitor on the iMac 27 inch. 2015 model.

@grusad: Do you have DPI scaling on in Windows? In Mac?

Can you share details about the monitor you're usiing?

I'm using late 2013 Mac Pro (aka "trash can") with two 32'', 1440p Samsung displays. Displays are not HiDPI, but I'm testing all macOS staff in manually enabled 720p HiDPI mode (probably this is somewhat different from real retina display since I can't reproduce some other HiDPI related issues as well).

@grusad I don't have access to a 5k iMac and cannot repro on other retina screens I have tried. Would you mind changing your resolution to something closer to non-retina and testing my hunch? You can drag the slider all the way to the right in the Displays preferences pane from System Preferences.

https://www.eizoglobal.com/support/compatibility/dpi_scaling_settings_mac_os_x/

In case of Mac Pro without built-in display there's no slider, but resolution list:

As default i had the "Defauly for display" checked. I can now confirmt hat the options in the green rect solves the problem, and the ones in the red rect gives the same problem as if i had the "Default for display" checked.

Thanks, I have a plan for a fix on this one.

Can anyone still reproduce this bug in Godot 3.2.3 rc3 or any later release?

No answer, so closing. Please comment if you can still reproduce it, and make sure that an up-to-date reproduction project is included.

authors: KoBeWi Zireael07 akien-mga bruvzg grusad samgreen


text:
GDScript (int-float arithmetic?) behaves differently in release mode

Godot version: v3.1.stable.official and v3.1.1.stable.official
OS/device including version: Arch Linux 64bit, but shouldn't care (see issue description)
Issue description:
I should have narrowed down the problem enough... may not be the full story, but this is what's happening to me:
if a script has a variable (as a member, declared in its "global" space - i.e. not inside a function) of type int and I try to subtract a float value from it, the value doesn't get updated only when the project is exported in Release mode. I tested this on Linux and Android exports, so this shouldn't tied to my system. I also tried setting the script export mode to "Text" instead of "Compiled" without any luck.
This doesn't happen with a variable local to the function or with an int-int subtraction (i.e. if I subtract an int value from the script variable, it also works in Release mode)
Steps to reproduce:
I'll attach a minimal project where this happens, but without having you download and open it, this is the script I used:
extends Control

var own_value : int = 100

func console_print(text):
	print(text)
	$Label.text += text + "\n"

func myfunc(amount : float):
	self.own_value -= amount

func _on_Button_pressed():
	self.console_print("")

	var value : int = 100
	var amount : float = 5.0

	self.console_print("value=" + str(value))
	self.console_print("amount=" + str(amount))
	self.console_print("doing value -= amount")
	value -= amount
	self.console_print("value=" + str(value))

	self.console_print("own_value=" + str(own_value))
	self.console_print("doing own_value -= amount")
	self.own_value -= amount
	self.console_print("own_value=" + str(own_value))

	self.console_print("calling myfunc(amount : float)")
	self.myfunc(amount)
	self.console_print("own_value=" + str(own_value))

	var int_amount : int = 10
	self.console_print("int_amount=" + str(int_amount))
	self.console_print("calling myfunc(int_amount : int)")
	self.myfunc(int_amount)
	self.console_print("own_value=" + str(own_value))

	self.console_print("doing own_value -= int_amount")
	self.own_value -= int_amount
	self.console_print("own_value=" + str(own_value))

	self.console_print("setting own_value to 200")
	self.own_value = 200
	self.console_print("own_value=" + str(own_value))

The output in debug mode:
value=100
amount=5
doing value -= amount
value=95
own_value=100
doing own_value -= amount
own_value=95
calling myfunc(amount : float)
own_value=90
int_amount=10
calling myfunc(int_amount : int)
own_value=80
doing own_value -= int_amount
own_value=70
setting own_value to 200
own_value=200

And the output in release mode:
value=100
amount=5
doing value -= amount
value=95
own_value=100
doing own_value -= amount
own_value=100
calling myfunc(amount : float)
own_value=100
int_amount=10
calling myfunc(int_amount : int)
own_value=100
doing own_value -= int_amount
own_value=90
setting own_value to 200
own_value=200

You can clearly see it's behaving differently and wrongly in release mode, the value is not updated.
To reproduce with the project... run with F5 for Debug mode or add an export profile for whatever platform, ensure "Export with Debug" is off and run... I mean I don't think I should be telling you guys this, but just in case... :smile:
Minimal reproduction project:
GDScriptReleaseIssue.zip

Was able to reproduce for Win10 64-bit Editor/Release builds of 84401e8

I think I have the same issue with int/float in Release mode.
Posting this for further clarification.
Godot version:
v3.1.1.stable.official
OS/device:
macOS 64-bit 10.13 and 10.14
Issue description:
In a Release export the label displays "99" instead of the expected "100" (the constant values are not relevant).
extends Node2D

class V:
	var x : int = 99

var _v1 : V = V.new()

func _ready():
	_v1.x = 100

	find_node('Label').text = str(_v1.x)
	return

Any of the following work around the issue to display "100" in both Debug and Release exports:

change constant 100 to 100.0
change type of V.x to int
use a float for _v1 instead of a class type

Minimal reproduction project:
28663_repro.zip

authors: avencherus gdelazzari johngirvin


text:
stretch only certain area of image

it is possible to set an image in a panel and stretch image when panel it is resized.
But it would be useful to stretch only certain area of image.
e.g. in this image I want to stretch only yellow areas and not to stretch red areas

AFAIK, godot already can do it.
There is Patch9Frame control.
And you can skin panel. http://www.godotengine.org/projects/godot-engine/wiki/GUI_Skinning

oh thank you,
I did not know this.
sorry for the issue.
I close it

authors: GrandFunkR volzhs


text:
Cannot debug Godot with GDB on WSL

Godot version
master
System information
Windows 10, Nvidia GTX 750 Ti
Issue description
I compiled Godot under WSL/WSL2 and been trying to mess around in the engine in VScode with WSL though I'm being currently halted by a GDB terminal error.
Terminal output:
&"warning: GDB: Failed to set controlling terminal: Operation not permitted\n"
[1] + Done                       "/usr/bin/gdb" --interpreter=mi --tty=${DbgTerm} 0<"/tmp/Microsoft-MIEngine-In-koccktbn.vlf" 1>"/tmp/Microsoft-MIEngine-Out-ususmfus.ggs"

Debug console output:
ERROR: Unable to start debugging. Unexpected GDB output from command "-exec-run". Warning:
Cannot insert breakpoint 1.
Cannot access memory at address 0x401b8b

This is the launch.json file that I currently have:
{
	// Use IntelliSense to learn about possible attributes.
	// Hover to view descriptions of existing attributes.
	// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
	"version": "0.2.0",
	"configurations": [
		{
			"name": "Launch Editor",
			"type": "cppdbg",
			"request": "launch",
			"program": "${workspaceFolder}/bin/godot.windows.tools.64.exe",
			"args": [],
			"stopAtEntry": false,
			"cwd": "${fileDirname}",
			"environment": [],
			"externalConsole": false,
			"MIMode": "gdb",
			"miDebuggerPath": "/usr/bin/gdb",
			"setupCommands": [
				{
					"description": "Enable pretty-printing for gdb",
					"text": "-enable-pretty-printing",
					"ignoreFailures": true
				}
			],
		}
	]
}

Note that when searching up for a fix on this issue, some people say to set the externalConsole variable to true, though this hasn't worked for me at all as it just completely gets stuck trying to launch Godot.
Steps to reproduce
Compile for Windows with Linux with these instructions:
https://docs.godotengine.org/en/stable/development/compiling/compiling_for_windows.html#cross-compiling-for-windows-from-other-operating-systems
After that, copy the exact launch.json code from the issue description debug and put that in the .vscode in the project root.
Minimal reproduction project
No response

I did some researching and someone else has been having this issue also with GDB though it doesn't seem like its related to Godot at all
Here's the issue on vscode's c++ tools repository
https://github.com/microsoft/vscode-cpptools/issues/8011

Some extra note here, this might not be an issue with Godot though an issue with vscode's c++ tools instead though its still worth noting somewhere.
On the issue that I linked, the person that posted the issue says a temporary solution to go around this is to attach the debugger instead of launching it. I will try to see if this solution works.

When using the attach option, I couldn't find the process ID for Godot when Godot was opened. The rest that I'm about to say is a guess. When running GDB, it can't see the Godot process because the Godot process is running on Windows instead of Linux. From what I'm guessing, this is because the GDB that is being launched is from WSL or the linux environment and not GDB on Windows. The GDB process on linux can't see the Godot process on Windows which would probably make sense then.


text:
Shortcut Play (command + B) doesn't work when cursor is on code editor

Godot version
v4.0.alpha1.official.31a7ddbf8
System information
macOS Monterey 12.1, Intel i9, Radeon Pro 560x 4GB
Issue description
If cursor is on code editor, the shortcut "Play" (command+B) doesn't work.
Useful info:

The shortcut "Play Scene" (command+R) works fine.
I mapped another key combination to command "Play" (eg. command+shift+9) and worked fine
If code is on screen, but the mouse focus is on another pane (eg. file explorer, debugger, inspector, open scripts list, methods list), the shortcut (command+B) works.

Steps to reproduce

Create a godot project
Create a scene
Attach script to created scene
Click inside code pane
Try to use "command + B" shortcut

Minimal reproduction project
No response

Duplicate of #56961

Sorry for the duplicated issue. I search for "command + b" and "play shortcut" and didn't find the other issue.
Thanks.