text:
HBASE-26767 Rest server should not use a large Header Cache.

Added a new HBase rest wrapper for "jetty.httpConfig.headerCacheSize" configuration property. Set the default value to the maximum allowed in the jetty 9.4.x branch

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 44s
master passed

+1 :green_heart:
compile
0m 25s
master passed

+1 :green_heart:
checkstyle
0m  9s
master passed

+1 :green_heart:
spotbugs
0m 26s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 20s
the patch passed

+1 :green_heart:
compile
0m 23s
the patch passed

+1 :green_heart:
javac
0m 23s
the patch passed

+1 :green_heart:
checkstyle
0m  7s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 48s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
0m 28s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

27m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4123/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4123

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux fab1db2baa4c 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / cd45cadbc1

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
60 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4123/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 55s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 39s
master passed

+1 :green_heart:
compile
0m 20s
master passed

+1 :green_heart:
shadedjars
5m 25s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 15s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
compile
0m 19s
the patch passed

+1 :green_heart:
javac
0m 19s
the patch passed

+1 :green_heart:
shadedjars
5m 24s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
6m 36s
hbase-rest in the patch passed.

29m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4123/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4123

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 336f3314e39d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / cd45cadbc1

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4123/1/testReport/

Max. process+thread count
1034 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4123/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 19s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 11s
master passed

+1 :green_heart:
compile
0m 22s
master passed

+1 :green_heart:
shadedjars
5m 34s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 19s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 49s
the patch passed

+1 :green_heart:
compile
0m 21s
the patch passed

+1 :green_heart:
javac
0m 21s
the patch passed

+1 :green_heart:
shadedjars
5m 33s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 16s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
5m 48s
hbase-rest in the patch passed.

30m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4123/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4123

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux c4a1872dbdab 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / cd45cadbc1

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4123/1/testReport/

Max. process+thread count
1031 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4123/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 44s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m  1s
master passed

+1 :green_heart:
compile
0m 15s
master passed

+1 :green_heart:
shadedjars
4m 53s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 13s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 38s
the patch passed

+1 :green_heart:
compile
0m 15s
the patch passed

+1 :green_heart:
javac
0m 15s
the patch passed

+1 :green_heart:
shadedjars
5m  1s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 12s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
4m 17s
hbase-rest in the patch passed.

22m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4123/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4123

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux aa6e8e72bcf0 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / cd45cadbc1

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4123/2/testReport/

Max. process+thread count
1096 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4123/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 46s
master passed

+1 :green_heart:
compile
0m 17s
master passed

+1 :green_heart:
shadedjars
4m 43s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 15s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 29s
the patch passed

+1 :green_heart:
compile
0m 18s
the patch passed

+1 :green_heart:
javac
0m 18s
the patch passed

+1 :green_heart:
shadedjars
4m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
5m 37s
hbase-rest in the patch passed.

23m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4123/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4123

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1c6cae3cd9b8 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / cd45cadbc1

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4123/2/testReport/

Max. process+thread count
993 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4123/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 17s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
2m 43s
master passed

+1 :green_heart:
compile
0m 28s
master passed

+1 :green_heart:
checkstyle
0m 11s
master passed

+1 :green_heart:
spotbugs
0m 28s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 23s
the patch passed

+1 :green_heart:
compile
0m 26s
the patch passed

+1 :green_heart:
javac
0m 26s
the patch passed

+1 :green_heart:
checkstyle
0m 10s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 32s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
0m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 11s
The patch does not generate ASF License warnings.

25m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4123/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4123

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux cab60319a23e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / cd45cadbc1

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
60 (vs. ulimit of 30000)

modules
C: hbase-rest U: hbase-rest

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4123/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I'm in the process of merging this now. One flaky test in hbase-thrift on branch-2 I'm checking out instead of blindly merging.

authors: Apache-HBase joshelser ss77892


text:
HBASE-26941 LocalHBaseCluster.waitOnRegionServer should quit while th…

…read is interrupted

Since this is usually used in UT I think a better way is to just throw the exception out and let the callers deal with it.
Some modified classes are marked IA.LimitedPrivate, so it is not suitable to be backported to branch-2.4. I think either we just ignore this change on branch-2.4 or we prepare a special patch for branch-2.4. But in fact I do not know what is the suitable way to fix this without throwing exception out, as if the thread is interrupted, Thread.sleep will be useless too...
@busbey FYI. This is why we eat all the spaces on some jenkins node.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 42s
master passed

+1 :green_heart:
compile
4m  9s
master passed

+1 :green_heart:
checkstyle
1m  4s
master passed

+1 :green_heart:
spotbugs
2m 45s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 17s
the patch passed

+1 :green_heart:
compile
4m  2s
the patch passed

+1 :green_heart:
javac
4m  2s
the patch passed

+1 :green_heart:
checkstyle
1m  2s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 15s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
3m  1s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 20s
The patch does not generate ASF License warnings.

49m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4333

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 7a0f6329c70e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3ae0d9012c

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-server hbase-testing-util U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  0s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 16s
master passed

+1 :green_heart:
compile
0m 45s
master passed

+1 :green_heart:
shadedjars
3m 44s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 59s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed

+1 :green_heart:
javac
0m 44s
the patch passed

+1 :green_heart:
shadedjars
3m 46s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
183m 42s
hbase-server in the patch passed.

+1 :green_heart:
unit
1m 20s
hbase-testing-util in the patch passed.

202m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4333

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux fdea91a1a1b9 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3ae0d9012c

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/testReport/

Max. process+thread count
3369 (vs. ulimit of 30000)

modules
C: hbase-server hbase-testing-util U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

-0 :warning:
yetus
0m  2s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 14s
master passed

+1 :green_heart:
compile
1m 13s
master passed

+1 :green_heart:
shadedjars
4m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m  4s
the patch passed

+1 :green_heart:
compile
1m 24s
the patch passed

+1 :green_heart:
javac
1m 24s
the patch passed

+1 :green_heart:
shadedjars
5m 15s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
207m 40s
hbase-server in the patch passed.

+1 :green_heart:
unit
1m 32s
hbase-testing-util in the patch passed.

234m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4333

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a339efc8ac50 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3ae0d9012c

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/testReport/

Max. process+thread count
2702 (vs. ulimit of 30000)

modules
C: hbase-server hbase-testing-util U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4333/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

source: gharchive/pull-request

repo: apache/hbase

license_type: permissive

license_source: github-api


text:
能像zabbix一样用snmp监控网络设备硬件吗？

Question
如果只能监控软件，是不是有缺陷？希望能真正代替zabbix。

hi, it can. See https://hertzbeat.apache.org/docs/advanced/extend-snmp

原来可以支持snmp协议，太好了，能不能像zsbbix一样内置一些常用设备的模块，因为对于新手来讲，这是一件很难的事。

hi, it can. See https://hertzbeat.apache.org/docs/advanced/extend-snmp

原来可以支持snmp协议，太好了，能不能像zsbbix一样内置一些常用设备的模块，因为对于新手来讲，这是一件很难的事。

原来可以支持snmp协议，太好了，能不能像zsbbix一样内置一些常用设备的模块，因为对于新手来讲，这是一件很难的事。

可以查看下现有的或者其它朋友网络分享的，这个我们会慢慢新增更多。

什么时候能增加对浪潮、深信服、奇安信等国内品牌的网络设备的支持？

source: gharchive/issue

repo: apache/hertzbeat


text:
HIVE-27429: Disable flaky test TestCompactionMetrics#testCleanerFailuresCountedCorrectly

What changes were proposed in this pull request?

Why are the changes needed?

mvn test -Dtest=TestCompactionMetrics#testCleanerFailuresCountedCorrectly  -pl ql/
http://ci.hive.apache.org/job/hive-flaky-check/697/testReport/
I also have found several PR  integration tests failed with the test TestCompactionMetrics#testCleanerFailuresCountedCorrectly
http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-4408/1/tests
http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-4404/1/tests/
http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-4402/4/tests/
http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-4360/5/tests/
http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-4372/10/tests/
Does this PR introduce any user-facing change?

How was this patch tested?

@zhangbutao The following PR should fix this flaky test - #4410 .

@zhangbutao The following PR should fix this flaky test - #4410 .

It is greate if it can be fixed! I will test it again after https://github.com/apache/hive/pull/4410 is merged.

@zhangbutao #4410 is merged, can you please check if this PR is still needed? if not can we close this?

@zhangbutao #4410 is merged, can you please check if this PR is still needed? if not can we close this?

yes，closing it

authors: SourabhBadhya akshat0395 zhangbutao

repo: apache/hive


text:
[Bug]: Random NullPointerException on Dummy Transforms

Apache Hop version?
2.6
Java version?
openjdk version "11.0.20" 2023-07-18
Operating system
Docker
What happened?
Hello
We have discovered a problem that cannot be directly understood, but occurs very frequently.
We are daily staring a workflow over the webservice which starts several pipelines in parallel.
And randomly, not every day and not the same pipeline one or more pipelines crashes on a dummy transform with:
2023/11/22 22:10:43 - DPK.0 - ERROR: Unexpected error
2023/11/22 22:10:43 - DPK.0 - ERROR: java.lang.NullPointerException
2023/11/22 22:10:46 - forb_transaction - Pipeline detected one or more transforms with errors.
2023/11/22 22:10:46 - forb_transaction - Pipeline is killing the other transforms!
DPK ist ein Dummy
Wenn man die betroffene Pipeline dann gleich wieder startet gibt es keine Probleme.
Wenn mehrere Pipelines betroffen sind tritt das Zeitgleich auf.
Issue Priority
Priority: 1
Issue Component
Component: Transforms

Can you provide a stack trace of the issue please, this information is not giving us much to work with.

only in form of screenshot some weeks ago ... at the moment because of another problem, which seems to be a config error on our site we do not get pipeline logs (or even pipelines) in the hop status if a workflow runs.

its still warm ...
2023/11/23 22:12:30 - DPK.0 - ERROR: Unexpected error
2023/11/23 22:12:30 - DPK.0 - ERROR: java.lang.NullPointerException
2023/11/23 22:12:30 - DPK.0 - 	at org.apache.hop.pipeline.transform.BaseTransform.putRowToRowSet(BaseTransform.java:1270)
2023/11/23 22:12:30 - DPK.0 - 	at org.apache.hop.pipeline.transform.BaseTransform.noPartitioning(BaseTransform.java:1212)
2023/11/23 22:12:30 - DPK.0 - 	at org.apache.hop.pipeline.transform.BaseTransform.handlePutRow(BaseTransform.java:1097)
2023/11/23 22:12:30 - DPK.0 - 	at org.apache.hop.pipeline.transform.BaseTransform$DefaultRowHandler.putRow(BaseTransform.java:3794)
2023/11/23 22:12:30 - DPK.0 - 	at org.apache.hop.pipeline.transform.BaseTransform.putRow(BaseTransform.java:1010)
2023/11/23 22:12:30 - DPK.0 - 	at org.apache.hop.pipeline.transforms.dummy.Dummy.processRow(Dummy.java:51)
2023/11/23 22:12:30 - DPK.0 - 	at org.apache.hop.pipeline.transform.RunThread.run(RunThread.java:55)
2023/11/23 22:12:30 - DPK.0 - 	at java.base/java.lang.Thread.run(Thread.java:829)
2023/11/23 22:12:30 - DPK.0 - Finished processing (I=0, O=0, R=44, W=44, U=0, E=0)

I think the best option to investigate better on this issue is to provide a reproduction path? Can you provide that sample?

How should I make a reproduction plan of this? :)

Hi, I am a member of cupro's team and will try to clarify our issue:
Our Workflow starts multiple pipelines in parallel.
After some time, some pipelines crash with this mentioned error - this happens only every few days.
However, when we execute the same pipeline, with the same input data a few minutes later, everything is fine (Data is processed correctly).
However, we cant really get the error to be reproducible. We have a second hop instance running that has the same error with the same pipelines. Also, as you may understand, we cant give you access to our data.
From our perspective the error seems to be completely random - we actually even considered this to be an hardware issue of our server, but we ruled that one out with testing the same instance on another server.
Is there any way we could provide you with additional info ?

Hello, we recently started migrating our transformations and jobs to Apache Hop, we were previously using PDI, and in some jobs we are running into this same problem of NullPointerException on Dummy. And the worst thing is that this occurs completely randomly, this problem for me happens when running a workflow as a for.

The issue might have been resolved with #3056
You can test it in a test environment using an unreleased version of hop fetched from here

@hansva After using version 2.8 of the hop, the NullPointerException problem stopped happening, I tested it again on the same load that caused the problem before and the error was resolved. Thank you for the quick and prompt response.

It took a while for us to upgrade to 2.8, but yes, the problem is solved.

authors: CuproAT Cupropituvanso Phsacar Wescley-Brasil hansva sramazzina

repo: apache/hop


text:
[Task]: clean up doc warnings

What needs to happen?
[07:44:09.394] WARN (asciidoctor): section title out of sequence: expected level 1, got level 2
    file: /Users/bart/git-hop/hop/docs/hop-user-manual/modules/ROOT/pages/how-to-guides/joins-lookups.adoc:25
    source: /Users/bart/git-hop/hop/ (refname: main <worktree>, start path: docs/hop-user-manual)
[07:44:09.397] WARN (asciidoctor): section title out of sequence: expected level 1, got level 2
    file: /Users/bart/git-hop/hop/docs/hop-user-manual/modules/ROOT/pages/how-to-guides/joins-lookups.adoc:83
    source: /Users/bart/git-hop/hop/ (refname: main <worktree>, start path: docs/hop-user-manual)
[07:44:09.398] WARN (asciidoctor): section title out of sequence: expected level 1, got level 2
    file: /Users/bart/git-hop/hop/docs/hop-user-manual/modules/ROOT/pages/how-to-guides/joins-lookups.adoc:149
    source: /Users/bart/git-hop/hop/ (refname: main <worktree>, start path: docs/hop-user-manual)
[07:44:09.611] WARN (asciidoctor): section title out of sequence: expected level 1, got level 2
    file: /Users/bart/git-hop/hop/docs/hop-user-manual/modules/ROOT/pages/workflow/workflows.adoc:23
    source: /Users/bart/git-hop/hop/ (refname: main <worktree>, start path: docs/hop-user-manual)
[07:44:09.612] WARN (asciidoctor): section title out of sequence: expected level 1, got level 2
    file: /Users/bart/git-hop/hop/docs/hop-user-manual/modules/ROOT/pages/workflow/workflows.adoc:38
    source: /Users/bart/git-hop/hop/ (refname: main <worktree>, start path: docs/hop-user-manual)
[07:44:09.612] WARN (asciidoctor): section title out of sequence: expected level 1, got level 2
    file: /Users/bart/git-hop/hop/docs/hop-user-manual/modules/ROOT/pages/workflow/workflows.adoc:54
    source: /Users/bart/git-hop/hop/ (refname: main <worktree>, start path: docs/hop-user-manual)
Site generation complete!

Issue Priority
Priority: 3
Issue Component
Component: Documentation

.take-issue


text:
Improve datadog reporter

Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Currently I'm afraid in case of wrong credential + skip validation, there is no way to be aware. Then here the skip validation will catch any error bit log something. I guess this is what one would expect instead of silent nothing
Jan 11, 2024 15:37:33 ForwardXu @.***>:

@.**** commented on this pull request.
why change this?
—
Reply to this email directly, view it on GitHub[https://github.com/apache/hudi/pull/10433#pullrequestreview-1815749219], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ACIX65TIIU7TWLPNBJ52PZLYN72KRAVCNFSM6AAAAABBG2RIL2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMJVG42DSMRRHE].
You are receiving this because you authored the thread.
[Tracking image][https://github.com/notifications/beacon/ACIX65XVKNMBBCFEFBKTTQLYN72KRA5CNFSM6AAAAABBG2RIL2WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTTMHIRGG.gif]

repo: apache/hudi


text:
[HUDI-7351] Handle case when glue expression larger than 2048 limit

Change Logs
After few days in production it turns out glue has a hard limit of expression (= 2048 chars). This patch handle this case, by fallback to returning all existing partitions.
Also the documentation was wrong about the pushdown max size. Fixed it and added a test case
Impact
None
Risk level (write none, low medium or high below)
None
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

maybe @danny0405


text:
[HUDI-4609] Improve usability of upgrade/downgrade commands in Hudi CLI

Change Logs
This PR improves usability of upgrade/downgrade commands in Hudi CLI by the following:

For the upgrade command (upgrade table), if --toVersion is not specified, the current/latest table version is used.
Adds support for numeric table version.  If the numeric table version is provided through --toVersion, it is converted to the HoodieTableVersion enum name internally, e.g., 2 -> TWO.

This PR adds new tests for the conversion of the input version option to the desired version name.
Impact
Only affecting the upgrade and downgrade commands in Hudi CLI.
Risk level: low
Tested the following CLI commands and they all work as expected:

upgrade table --sparkMaster local[2]: Hoodie table upgraded/downgraded to FIVE
downgrade table --toVersion 2 --sparkMaster local[2]: Hoodie table upgraded/downgraded to TWO
upgrade table --toVersion FIVE --sparkMaster local[2]: Hoodie table upgraded/downgraded to FIVE
downgrade table --toVersion TWO --sparkMaster local[2]: Hoodie table upgraded/downgraded to TWO

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@hudi-bot run azure


text:
[HUDI-6464] Codreview changes for Spark SQL Merge Into for pkless tables'

Codreview changes for Spark SQL Merge Into for pkless tables (see #9083)
Change Logs
Codreview changes for Spark SQL Merge Into for pkless tables (See #9083)
Impact
None
Risk level (write none, low medium or high below)
None
Documentation Update
None
Contributor's checklist

[X] Read through contributor's guide
[X] Change Logs and Impact were stated clearly
[X] Adequate tests were added if applicable
[X] CI passed

@yihua Can you please review

@hudi-bot run azure

There is a severe function regression, can we fix it as soon as possible https://issues.apache.org/jira/browse/HUDI-6472, @amrishlal .


text:
[AIRFLOW-2581] Fix DbApiHook autocommit

JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-2581

Description

[x] Here are some details about my PR:
DbApiHook.run actually do not commit when I set to autocommit=True
For example: hook.run(sql,autocommit=True)
This commit fixed this problem.

Tests

[x] My PR does not need testing for this extremely good reason:
bug fix, no need for tests

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

@bolkedebruin @Fokko  PTAL. this bug was introduced from here , and there is a fix here , which didn't fix it at all, it runs correctly after I fix it in the PR.

Codecov Report

Merging #3482 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #3482   +/-   ##
=======================================
  Coverage   77.16%   77.16%
=======================================
  Files         203      203
  Lines       15119    15119
=======================================
  Hits        11666    11666
  Misses       3453     3453

Impacted Files
Coverage Δ

airflow/hooks/dbapi_hook.py
82.2% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab81767...3e55f87. Read the comment docs.

@roc I’ll have a look. But can you please stop closing/opening the Pr for the sake trying it? Apache Infra has asked us not to do this.

@bolkedebruin  OK, I was trying to retrigger the CI because of the CI failure  😅

it seems that the CI failure was not related

I think this pr causes couples of unit tests failed which caused current CI is broken. Are you planning to fix it?

authors: bolkedebruin codecov-io feng-tao imroc

repo: apache/incubator-airflow

license_source: bigquery


text:
[AMORO-2698] Display more details in the page of Optimizing->Optimizers

Why are the changes needed?

Close #2698.
Brief change log

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before making a pull request

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.97%. Comparing base (882b78b) to head (e68b49c).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2699      +/-   ##
============================================
- Coverage     34.02%   33.97%   -0.05%
+ Complexity     4364     4362       -2
============================================
  Files           604      604
  Lines         50754    50754
  Branches       6673     6673
============================================
- Hits          17269    17246      -23
- Misses        32086    32119      +33
+ Partials       1399     1389      -10

Flag
Coverage Δ

core
32.28% <ø> (-0.01%)
:arrow_down:

trino
50.50% <ø> (-0.43%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

authors: codecov-commenter tcodehuber

repo: apache/incubator-amoro


text:
[Feature][plugin/github] Automatically adding a trailing / to the GitHub connection endpoint

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Use case
We can automatically add / to reduce the burden on users.

doc link: https://devlake.apache.org/docs/next/Configuration/GitHub#endpoint-url
Description
No response
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @aFlyBird0 Do you still want to do it?

Hi @aFlyBird0 Do you still want to do it?

Sure, I'm willing to do that. Open-Source is Cool! Is it Okay to open a PR before Friday?

@aFlyBird0 Sure, I'm looking forward to your PR

authors: Startrekzky aFlyBird0 mindlesscloud

repo: apache/incubator-devlake


text:
docs: Add English blog of QoS_Team2

What is the purpose of the change
Add English version of QoS blog.
Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Test your code locally by running docsite start, and make sure it works as expected.
[x] Make sure no files under build directory is added.
[ ] If this contribution is large, please follow the Software Donation Guide.

Comment from Team 9:

line 3

For example, by adjusting and manipulating the weighs of ports of a router dynamically via QoS,
"Weighs" should be "weights", as "weigh" is a verb.

line 5

and launching or withdrawing services (i.e registering to or unregistering services from registration center).
"Withdraw services" is confusing, and "stop services" might be better.

line 11

QoS in based on Netty4.
This is not a complete sentence. "in based on" should be changed to "is based on".

line 11

there's no bother adding configurations because Netty4 is listed as a dependency by default.
"There's no bother" is a combination of "there is no need" and "no bother". Preserve either one will be better.

line 20

Executing commands and return with responses.
“Executing” should be "Execute" here, obviously.

line 142

performed a offline action
"a" should be "an".

line 155

Now use ls to check providers' status at the current moment.
"at the current moment" is kind of redundant, "now" will be fine.

line 185

Enable remote access
Based on Chinese version, it should be "Enable remote access or not".

line 240

If You Are Using spring-boot

To stay consistent with subtitles above, "Spring-boot auto configuration" will be more appropriate.

line 208

and copy the following codes into it
line 218
you can try this
line 242
If you are developing a spring-boot application
Just for fun! These sentences are not serious enough for a tech docs : )

authors: liaoandi wendzhue

repo: apache/incubator-dubbo-website


text:
[Dubbo- support unit router feature] May be a nice feature.

What is the purpose of the change
Support unit router feature for dubbo.
What problems can this feature solve?
case 1:
If we have two instance of services or more, we call it serviceA(192.168.0.1), serviceA(192.168.0.2)

We want to invoke serviceA (192.168.0.2) first, if serviceA (192.168.0.2) is not available then invoke  serviceA (192.168.0.1) automatically.
case 2:
If we have many relative services, We call it serviceA(192.168.0.1), serviceA(192.168.0.2), serviceB(192.168.1.1), serviceB(192.168.1.2), serviceC(192.168.3.1), serviceC(192.168.3.2)
dependencies of service:
serviceA -> serviceB -> serviceC

We can flexibly build call paths and automatically downgrade calls.
case 3:
We can take advantage of this feature to realize the priority routing of the same machine room service.
Notes:
if use unit feature, unit router will be last invoked,
because if the unit router has no match, it will return the previous available invokers, this is very important !
Easy to use:
Set service and reference are same unit value. or use global configuration.
case 1：
consumer.xml:  <dubbo:reference id="XXX" check="false" interface="XXX" unit="anything"/>
provider.xml:     <dubbo:service interface="XXX" ref="bean" unit="same as reference"/>
case 2：(global)
consumer.xml & provider.xml : <dubbo:provider unit="anything"/>， "anything"  suggest same both side.
Brief changelog

add unit property for dubbo.xsd
add new UnitRouter and so on

Verifying this change
Here is more detail unit tests:

com.alibaba.dubbo.rpc.cluster.router.unit.UnitRouterTest
com.alibaba.dubbo.registry.dubbo.RegistryDirectoryTest

I have verified that the unit test has been correct and passed.
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #1438 into master will increase coverage by 0.04%.
The diff coverage is 45.28%.

@@            Coverage Diff             @@
##           master    #1438      +/-   ##
==========================================
+ Coverage   31.59%   31.63%   +0.04%
==========================================
  Files         682      684       +2
  Lines       33035    33183     +148
  Branches     6592     6646      +54
==========================================
+ Hits        10436    10498      +62
- Misses      20748    20806      +58
- Partials     1851     1879      +28

Impacted Files
Coverage Δ

.../dubbo/registry/integration/RegistryDirectory.java
0% <ø> (ø)
:arrow_up:

.../main/java/com/alibaba/dubbo/common/Constants.java
88.88% <ø> (ø)
:arrow_up:

...va/com/alibaba/dubbo/common/utils/StringUtils.java
45.02% <0%> (-3.29%)
:arrow_down:

...bbo/rpc/cluster/router/unit/UnitRouterFactory.java
100% <100%> (ø)

.../rpc/cluster/router/condition/ConditionRouter.java
71.11% <100%> (ø)
:arrow_up:

...dubbo/rpc/cluster/directory/AbstractDirectory.java
41.09% <20%> (-14.72%)
:arrow_down:

...libaba/dubbo/rpc/cluster/support/ClusterUtils.java
56.89% <22.22%> (-6.37%)
:arrow_down:

.../alibaba/dubbo/config/AbstractInterfaceConfig.java
38.39% <33.33%> (-0.07%)
:arrow_down:

...a/dubbo/rpc/cluster/directory/StaticDirectory.java
38.46% <46.15%> (+9.89%)
:arrow_up:

...baba/dubbo/rpc/cluster/router/unit/UnitRouter.java
73.46% <73.46%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2308427...d14d9a0. Read the comment docs.

If this PR only support specify a specific unit at startup, I think that makes no difference with Dubbo's group.
I think we should consider the following aspects as a whole:

The initial call decides the whole invoke chain automatically.
We may need some support from third-party infrastructures, such as systems that can group instances automatically based on instance IP.
Support change group/unit of an instance dynamically at runtime.
Support adds routing rules dynamically at runtime.

I will close this PR temporarily, and will reopen it or create a new ticket to track this feature later.

authors: chickenlj codecov-io zonghaishang

repo: apache/incubator-dubbo


text:
设置label的position定位问题：数据值有正有负，如何实现正值position设置为top，负值设置为bottom.求教！

Version
4.5.0-rc.2
Steps to reproduce
依据数据可自定义label的position定位
What is expected?
{
name: '柱状图',
type: 'bar',
barWidth: 40,
z: 10,
data: [1,2,43]
itemStyle: {
color: '#00a0e9',
},
label: {
show: true,
color: '#666',
position: 1>0? 'top' : 'bottom'
}
}
What is actually happening?
现在position无法根据数据自定义

柱状图label的position是否可以根据柱状图高度显示inside或者top

repo: apache/incubator-echarts


text:
Can't format the "detail" object for a gauge series

What problem does this feature solve?
This option exists in the docs (https://echarts.apache.org/en/option.html#series-gauge.detail.formatter), but the formatter doesn't exist for the "detail" object of the gauge series (echarts v4.8.0). I would like to format the value as a percentage.
What does the proposed API look like?
It should work exactly like in the editor. The "detail" object of a series should have a "formatter" property.

It seems that it is just a grammar test error, Is it the drawing result is correct?
Can you give examples or screenshots?

If I change the return type from SeriesGauge to "any", the drawing result is correct. However, that defeats the point of using TS

As document says, series-gauge.detail.formatter should return a function or a number, so is it better to set return type as Function | number?

I'm not sure if my problem is understood. What I need as return type is a "series-gauge" object. that object contains object detail which, in the docs, contains "formatter" which is a function or a string. However, the Node JS interface "series-gauge.detail" does not contain the "formatter" property.

Could you tell me what library you are using, is it  ECharts@types ?

yes

That seems to be a bit weird.
I saw it exists in https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/echarts/options/series/gauge.d.ts#L2026

It's indeed for missing formatter option in series.gauge, maybe you need to add it manually.
After all, we can see that this repository is maintained at a long period interval and many of the types have been changed.
ECharts team is already developing with TypeScript under next branch, in the near future, ECharts@types will be not necessary any more.

A simple fix would be changing the return value to as any. You may also make a pull request to DefinitelyTyped, or wait for it to be fixed in next branch.

A simple fix would be changing the return value to as any. You may also make a pull request to DefinitelyTyped, or wait for it to be fixed in next branch.

This is indeed how I temporarily fixed it.


text:
triggerEvent xAxisIndex全是0

One-line summary [问题简述]
我在某个x类目轴打开了triggerEvent，绑定了事件，然后查看传给回调的参数，结果发现所有xAxisIndex都是0. 如图

Version & Environment [版本及环境]

ECharts version [ECharts 版本]: 3.3.2
Browser version [浏览器类型和版本]: Chrome  54.0.2840.98
OS Version [操作系统类型和版本]: OS X 10.11.6

Expected behaviour [期望结果]
应该是0，1，2……才对
ECharts option [ECharts配置项]

option = {
    "tooltip": {
        "trigger": "axis"
    },
    "toolbox": {
        "feature": {
            "dataView": {
                "show": true,
                "readOnly": false
            },
            "magicType": {
                "show": true,
                "type": [
                    "line",
                    "bar"
                ]
            },
            "restore": {
                "show": true
            },
            "saveAsImage": {
                "show": true
            }
        }
    },
    "legend": {
        "textStyle": {
            "color": "#7a818d",
            "fontSize": 14
        },
        "data": [
            {
                "name": "学生正确率",
                "icon": "pin"
            },
            {
                "name": "平均正确率",
                "icon": "pin"
            }
        ]
    },
    "xAxis": [
        {
            "type": "category",
            "data": [
                "测试学生4",
                "测试学生5",
                "测试学生6"
            ],
            "axisLabel": {
                "textStyle": {
                    "color": "#1d73ff",
                    "fontSize": 14
                }
            },
            "axisLine": {
                "lineStyle": {
                    "color": "#ececec"
                }
            },
            "offset": 14,
            "triggerEvent": true
        }
    ],
    "yAxis": [
        {
            "type": "value",
            "min": 0,
            "max": 100,
            "interval": 10,
            "axisLabel": {
                "formatter": "{value}%",
                "textStyle": {
                    "color": "#7a818d",
                    "fontSize": 14
                }
            },
            "axisLine": {
                "lineStyle": {
                    "color": "#ececec"
                }
            },
            "splitLine": {
                "lineStyle": {
                    "color": "#f5f5f5"
                }
            }
        }
    ],
    "color": [
        "#5e95ef",
        "#36cc95",
        "#b368e2",
        "#fbc138",
        "#f56464",
        "#fb8d58",
        "#6ae7da"
    ],
    "series": [
        {
            "name": "学生正确率",
            "type": "line",
            "smooth": true,
            "data": [
                {
                    "value": 42,
                    "name": "测试学生4"
                },
                {
                    "value": 0,
                    "name": "测试学生5"
                },
                {
                    "value": 27,
                    "name": "测试学生6"
                }
            ]
        },
        {
            "name": "平均正确率",
            "type": "line",
            "smooth": true,
            "data": [
                23,
                23,
                23
            ]
        }
    ]
}

Other comments [其他信息]

I'm also looking for a feature like this.
I use one chart to display four (different) types of charts: Scatter, Line, Sankey and Pie (in one chart).
This is no problem at all, it works smooth and as i expect.
Tooltip is also working if i just use one Tooltip for the scatter and Sankey and none for the others..
But as Scatter needs "item" or "axis"+"cross" trigger, this is not really nice for the line chart.

xAxisIndex 指的是你 xAxis 组件的 index，你如果只有一个 xAxis，那这个值肯定一直都为 0

抱歉其实我真实需求是这样的：x轴的item可以点击，触发事件然后进行一些操作，问题是triggerEvent目前返回的信息太少了，希望至少能包含我的原始数据，不然仅凭一个字符串，我要做个操作很麻烦。

参数就是你传入的原始数据

只有一个value啊，其他信息都看不到。

hello，你这个问题解决了吗？我也遇到这个问题，只有一个value值信息太少了。

authors: Mijago cryingbat pissang sxcooler


text:
箱线图Boxplot箱子宽度根据样本数量变化

@leeight  你好，我在源码中见到TODO注释里面有关于添加箱子宽度根据样本数量显示的计划，请问什么时候可以实现？这个功能挺对箱线图重要的，如果可以我也希望能提供帮助。谢谢！
var BoxplotSeries = SeriesModel.extend({

    type: 'series.boxplot',

    dependencies: ['xAxis', 'yAxis', 'grid'],

    // TODO
    // box width represents group size, so dimension should have 'size'.

    /**
     * @see <https://en.wikipedia.org/wiki/Box_plot>
     * The meanings of 'min' and 'max' depend on user,
     * and echarts do not need to know it.
     * @readOnly
     */
    defaultValueDimensions: [
        {name: 'min', defaultTooltip: true},
        {name: 'Q1', defaultTooltip: true},
        {name: 'median', defaultTooltip: true},
        {name: 'Q3', defaultTooltip: true},
        {name: 'max', defaultTooltip: true}
    ],

Related issue: #8888

Duplicate of #8888

authors: Ovilia dontry


text:
[CORE] Enable to_utc_timestamp Spark function

What changes were proposed in this pull request?
Enable to_utc_timestamp
How was this patch tested?
Added a UT.

@PHILO-HE can you please review? Thanks!

repo: apache/incubator-gluten


text:
[GLUTEN-7035][VL] Get head for target_build_commit

What changes were proposed in this pull request?
Get head for target_build_commit
Fixes: #7035
How was this patch tested?

I feel a better fix is to use git ls-remote $VELOX_REPO refs/heads/$VELOX_BRANCH which looks up a unique ref.

I feel a better fix is to use git ls-remote $VELOX_REPO refs/heads/$VELOX_BRANCH which looks up a unique ref.

Thanks, this looks like a better way.

But it doesn't work for a tag

Yes neither tag nor commit hash works.  Perhaps we have to keep the original solution.

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_master_08_28_2024_time.csv
log/native_master_08_26_2024_5db9de5601_time.csv
difference
percentage

q1
40.10
41.14
1.037
102.59%

q2
30.34
29.61
-0.726
97.61%

q3
52.02
53.63
1.604
103.08%

q4
40.89
42.24
1.346
103.29%

q5
103.89
107.54
3.649
103.51%

q6
13.28
10.83
-2.454
81.52%

q7
116.54
117.95
1.411
101.21%

q8
115.70
120.99
5.290
104.57%

q9
169.83
170.67
0.838
100.49%

q10
67.03
66.86
-0.167
99.75%

q11
27.13
26.86
-0.270
99.00%

q12
30.03
29.53
-0.495
98.35%

q13
51.89
52.01
0.126
100.24%

q14
26.74
26.47
-0.266
99.01%

q15
53.59
54.81
1.225
102.29%

q16
19.99
18.50
-1.492
92.54%

q17
130.36
129.54
-0.820
99.37%

q18
197.94
200.27
2.331
101.18%

q19
27.96
26.33
-1.633
94.16%

q20
42.29
42.35
0.058
100.14%

q21
380.46
385.88
5.426
101.43%

q22
15.92
16.01
0.092
100.58%

total
1753.91
1770.02
16.110
100.92%

authors: GlutenPerfBot wForget zhztheplayer


text:
[HUDI-62] Added index handle times

Added index timers

@vinothchandar Hi Please can you tell me why Travis is failing? Sorry never worked with Travis so not aware what needs to be done here. I see warnings for spacing? Is there a specific format I am supposed to use?

@taherk77 you can click on "Details" and it will take you to the job page.. there you can click again on the failing job and look at the logs
 [WARN] /home/travis/build/apache/incubator-hudi/hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java:175:25: WhitespaceAround: '=' is not preceded with whitespace. [WhitespaceAround]
[WARN] /home/travis/build/apache/incubator-hudi/hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java:175:26: WhitespaceAround: '=' is not followed by whitespace. Empty blocks may only be represented as {} when not part of a multi-block statement (4.1.3) [WhitespaceAround]
[WARN] /home/travis/build/apache/incubator-hudi/hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java:177: Line is longer than 120 characters (found 133). [LineLength]

Looks like you have checkstyle failures.. Typically, people first build, run the tests locally , get them to pass and then push it to gh. may be we can try that?

Hey Sorry for that @vinothchandar, I did run all the junits before pushing the code.

@taherk77 so checkstyle passes locally for you? Just skimming the code     indexLookupContext=metrics.getIndexLookupCtx(); for e.g wont pass checkstyle unless it has spaces like     indexLookupContext = metrics.getIndexLookupCtx();

repo: apache/incubator-hudi


text:
Extended Services Runner erases data on dates with Decision Update

When creating a decision and looking at dates that are in the generated form, if you make any change to the DMN Decision (add or remove ()s for instance, not changing the data types), the form wipes out all data. This makes the process of updating rules and validating much harder if you have to keep putting in the dates. The ideal state with decision changes are that the data should remain in place and the update not affect the data types. This is how you would typically test a decision to validate it is working correctly with the data you know should render the appropriate answer. See attached gif for example.

One other comment on this, the Data Object used is a Java Import from VS Code, not sure if relevant, but it is a piece I forgot to mention.

repo: apache/incubator-kie-tools


text:
[Question] (jdk11+scala2.12.16) An error is reported when the Linkis project is fully compiled

Before asking

[X] I have read the How to ask for help (我已阅读如何寻求帮助指引文档).

Your environment

Linkis version used: 1.1.2
Environment name and version:

cdh-5.14.2
hdp-3.1.5
hive-2.1.1
spark-3.2.1
scala-2.12.2
jdk 1.8.0_121
....

Describe your questions
(jdk11+scala2.12.16) An error is reported when the Linkis project is fully compiled
mv n -N install
mvn clean install error

File-->Settings-->Build,Execution,Deployment-->Compiler-->scala compiler , modify the compiler order to Scala Then Java build project and report an error

Eureka service list

eg:
Some logs info or acctch file

linkis-xxx.log:

<!--日志文字贴到这里-->

log file:

linkis-xxx.log

specific code branch?
Compatibility issues with JDK11 The current compatibility issues with JDK11 are as follows
sun.misc.{Signal, SignalHandler}
import sun.misc.Unsafe;
Like hadoop, the requirements for the jdk version, hadoop2.7 does not support jdk11
There are already students in the community who are doing adaptation follow-up, you can pay attention to the corresponding feature progress, or temporarily use the JDK8 version
具体代码分支？
JDK11的兼容性问题 目前对于JDK11的兼容性问题如下
sun.misc.{Signal, SignalHandler}
import sun.misc.Unsafe;
像hadoop之类的，对jdk版本的要求，hadoop2.7都不支持jdk11
社区已经有同学在做适配跟进，可以关注对应的特性进展，或则暂时先使用JDK8版本

repo: apache/incubator-linkis


text:
MADLIB-962. Add LICENSE NOTICE and RAT checks to the project

Please take a look

Everything looks good, though I'm not clear on how to test the pom.xml.

repo: apache/incubator-madlib


text:
mxnet

library("mxnet")
Error: package or namespace load failed for 'mxnet':
.onLoad failed in loadNamespace() for 'mxnet', details:
call: dyn.load(file, DLLpath = DLLpath, ...)
error: unable to load shared object '/mnt/data/gulinlin/software/NR/lib64/R/library/mxnet/libs/libmxnet.so':
libopencv_imgcodecs.so.3.2: cannot open shared object file: No such file or directory
can you help me?

@gulinlin Thanks for using MXNet. Can you give more details on the platform you are using?
@anirudhacharya Seems like R installation issue, Can you take a look?
@sandeep-krishnamurthy Can you please add labels: Installation, R

Hi @gulinlin Could you provide more details of the setup/platform you are using like OS, R version, GPU/CPU and we can help you with the issue.

@mxnet-label-bot please add [Pending Requester Info]

@nswamy @sandeep-krishnamurthy Could you please close this issue due to inactivity as the issue is not reproducible.
@gulinlin  Please feel free to reopen the issue  case it if closed in error.

authors: Roshrini ankkhedia gulinlin lupesko

repo: apache/incubator-mxnet


text:
How can I debug mxnet?

Hi, I want to debug mxnet, and I use mxnet in python. How can I smoothly debug mxnet and its submodule nnvm?

DEBUG flag in make config, and gdb

Yes, that's how I do this now. So there's no elegant way to do this? Because I want to debug every function in the mxnet.

@mxmxlwlw what would you describe as elegant? IDE integration?

for example, I want to run python and when the code goes into the library, it stopped, and so I can debug it.

@mxmxlwlw I see. I found the following two posts that are relevant, though I haven't tried gdb this way myself.
http://johntfoster.github.io/posts/debugging-cc%2B%2B-libraries-called-by-python.html
https://stackoverflow.com/questions/13653467/gdb-break-in-shared-library-loaded-by-python

@szha I know these method. However, it still can't be stopped when the code goes into the library unless you already know what function it will goes in.

Building mxnet with visual studio DEBUG mode may be a good choice.

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!
Also, do please check out our forum (and Chinese version) for general "how-to" questions.

authors: chinakook mxmxlwlw szha


text:
Add path_suffixes for finding cudnn.lib

On Windows, the directory structure layout for CUDNN is:
/t/incubator-mxnet ❯❯❯ unzip -l /tmp/cudnn-9.0-windows10-x64-v7.1.zip
Archive:  /tmp/cudnn-9.0-windows10-x64-v7.1.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
   122719  04-28-2018 08:01   cuda/include/cudnn.h
    38963  05-01-2018 11:50   cuda/NVIDIA_SLA_cuDNN_Support.txt
    49070  05-05-2018 08:48   cuda/lib/x64/cudnn.lib
331319808  05-05-2018 08:48   cuda/bin/cudnn64_7.dll
---------                     -------
331530560                     4 files

When CUDA_ROOT is set to /path/to/extracted/cudnn/cuda, the find_library() call failed, because it couldn't find cudnn.lib
The find_library() call tries to find cudnn.lib in %CUDA_ROOT% and %CUDA_ROOT%/include but doesn't look in %CUDA_ROOT%/lib or %CUDA_ROOT%/lib/x64. This patch fixes the problem by specifying the path suffixes to include lib and lib/x64.

I am setting CUDNN_ROOT as an environment variable, if it that makes any difference. Also, I traced it being called from: https://github.com/apache/incubator-mxnet/blob/1.2.0/CMakeLists.txt#L414

This is still present in the current HEAD: https://github.com/apache/incubator-mxnet/blob/37c8165748457e1b648ec49f68e70027da2af6f2/CMakeLists.txt#L406

This for the quick reply.  I wanted to verify since this file seems quite out of date to me.  I'll try setting CUDNN_ROOT and see if I follow this code path.  The whole FisrtCuda path is a bit of a mystery to me.  I think it is mostly reliant on what cmake version you have (later versions of some support for native cuda projects).
This is all orthogonal to this PR, which LGTM.  I like the PATH_SUFFIXES, seems more concise than what we have in our modules.

FWIW, I was using CMake 3.11.1

I wonder if you'd also be willing to contribute the change to this project?  https://github.com/dmlc/mshadow/blob/master/cmake/Cuda.cmake#L225

authors: KellenSunderland nehaljwani


text:
License update

Description
Update license file to include Clojure, R, ONNX-TRT and location of 3rd party location.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ X] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@larroy - please approve and @sergeykolychev please merge.


text:
[int8] Add MobileNetV2_1.0 & ResNet18 Quantization

Description
Add MobileNetV2_1.0 & ResNet18 Quantization.
ResNet18 Performance on Skylake 8180 28c

resnet18_v1
fp32
int8
speedup

1
309.61
492.18
1.59

64
810.82
1341.55
1.65

accuracy
70.07%/89.30%
69.85%/89.23%

#14819 will improve mobilenetv2 fp32/int8 performance

mobilenetv2_1.0
fp32
int8
speedup
fp32_opt
int8_opt
speedup

1
75.22
162.12
2.16
240.51
413.92
1.72

64
291.63
469.28
1.61
795.86
3137.77
3.94

accuracy
70.14%/89.60%
63.62%/84.84%

70.14%/89.60%
69.53%/89.24%

@pengzhao-intel @ZhennanQin
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @zhreshold

@mxnet-label-bot add [Quantization, Example]

Merging now. @xinyu will refactor the script in the next PR.

authors: pengzhao-intel roywei xinyu-intel


text:
Add unit tests for potri and potrf backward and check output shape.

Add unit tests for backward linalg_potri and linalg_potrf operators. Verify output shape.
Test results (with modified function names):
python3 -m pytest --verbose tests/nightly/test_large_array.py::test_potrf tests/nightly/test_large_array.py::test_potri
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.7.7, pytest-5.4.1, py-1.8.1, pluggy-0.13.1 -- /home/ubuntu/anaconda3/bin/python3
cachedir: .pytest_cache
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/home/ubuntu/incubator-mxnet/.hypothesis/examples')
rootdir: /home/ubuntu/incubator-mxnet, inifile: pytest.ini
plugins: remotedata-0.3.2, openfiles-0.4.0, astropy-header-0.1.2, timeout-1.4.1, hypothesis-5.8.3, arraydiff-0.3, doctestplus-0.5.0
timeout: 1200.0s
timeout method: signal
timeout func_only: False
collected 2 items

tests/nightly/test_large_array.py::test_potrf PASSED                                                                                [ 50%]
tests/nightly/test_large_array.py::test_potri PASSED                                                                                [100%]

============================================================================ 2 passed in 1654.43s (0:27:34)  ============================================================================

@mxnet-bot run ci [unix-gpu]

@mxnet-bot run ci [unix-gpu]

LGTM

@mxnet-bot run ci [unix-gpu, unix-cpu]

@mxnet-bot run ci [unix-gpu]

@mxnet-bot run ci [unix-gpu]

@mxnet-bot run ci [unix-gpu]

@mxnet-bot run ci [unix-gpu]


text:
Basic pin mapping for RedBear Blend2

Based mostly on BSP for rb-nano2.
Updated pin mapping for UART0

LED Pin remapped
SPI0 remapped/enabled
I2C-0 remapped/enabled
UART1/TWI-1/SPIM-1  - remapped/disabled due to pin conflicts

The pull request looks good except for one item: it appears you have mapped the LED_BLINK_PIN (P25) to both the LED and SPI0 SCK pin. I took a look at the schematic and P25 does seem to be the LED pin (although not sure what that MCP6002T chip is) so you will need to map SCK to some other pin. Note that I do not have a blend2 board with which to test and admittedly I did not go through every line of the .ld files and scripts so am taking some of this on faith :-)
To answer your questions:

Best way to make UART1 optional is to go into the syscfg.yml file and change UART_1 to value: 0
Looking at the schematic it appears that there are two sets of pins for i2c: SDA1/SCL1 (pins 26/27) and SDA/SCL (pins 13/12). So I would map i2c to those pins. None of those pins appear mapped already in your syscfg or hal_bsp.
I would not map SPI1 personally. There are not a ton of GPIO that go out to the connectors. If folks need another SPI they should just map it in their BSP.

Believe it or not... P25 is "officially" shared with SPI0_SCK
https://github.com/redbear/nRF5x#blend-2
Should we follow the "official" image, or... do you think we should make a command decision to make something more... "useful"?
Looking into the other items...

Wanted to post an update in regards to your feedback.
I added I2C_0 to syscfg/hal_bsp
I left UART_1 configured as value:1 because "most arduino shaped boards like the Blend2" have serial on those pins.
I'll post another note when I have time to test the new pin mappings.

Regarding the .ld/script files - since the rb-nano2 and rb-blend2 share the same "Redbear MB-N2" module, it's quite likely that the rb-nano2 settings can simply be used for the rb-blend2.

I would not share the LED with SCK personally. There are other pins to use and you can use any pin for any peripheral so keeping them separate makes sense to me

@wes3 You know what's crazy? In the Arduino Uno pinout, SCK and LED are actually officially shared.
Does MyNewt have any intention of following the Arduino Uno pinout for boards like the Blend2 which are based on the Arduino Uno pinout?

I cannot speak for all of Mynewt obviously but I think folks generally try to allocate the pins such that there is one i2c interface, one spi interface, and the LEDs are not shared. I see no reason to commit a bsp that shares any of these unless there is not enough gpio. I do not think that is the case with any of the boards you mention (although I could be wrong).

@wes3 Here's some more info for both sides of the coin:
http://playground.arduino.cc/Main/ShieldPinUsage
Any correctly designed shield will connect the SPI lines(MISO, MOSI, SCK) via the ICSP header instead of the standard Arduino I/O pin headers because the SPI is found on different pins depending on the board.
But.... the Blend2 board (in the pinning for the Arduino Uno) doesn't have an ICSP header, so.......
Would it be better to at least have the Arduino Uno standard available? (not a super strong argument in light of even Arduino saying "don't do it")
Anyways, this is the only reason I can find to keep SCK and LED on the same pin.
Otherwise, I totally agree with you.

I'm totally out of good reasons to support keeping with the Arduino Uno SPI standard especially when Arduino says don't do it.
So I picked the next nearest pin which is unassigned.
Is there a suggested place to document this "deviation" from the official "RedBear Blend2 pinout diagram" so that new users aren't surprised?

You could submit a tutorial here that describes getting the blend2 up and running: http://mynewt.incubator.apache.org/latest/os/introduction/
Otherwise a comment in the code is fine :-)

It looks good; commit has been merged.

@pctj101 Please close this issue, the PR was already merged but the issue was not automatically closed. Thanks!

repo: apache/incubator-mynewt-core


text:
[NETBEANS-643] Mercurial Annotate fails on file with spaces and leading dots

In PR #508 it was suggested to modify the regular expression used to parse the
output of the mercurial annotate command. While testing it was identified, that
more corner cases need to be covered.
This PR supersedes the referenced PR with a further modified regexp. It also
adds an analysis/description for the format and supplies unittests.
Closes: #508

Just a moment while I make sure it works with what I have...

Thanks for checking!

authors: SirIntellegence matthiasblaesing

repo: apache/incubator-netbeans


text:
sched: task: Fix nxtask_exit() for SMP

Summary

I noticed that nxsched_merge_pending() is called outside a critical section
The issue happens if a new rtcb does not hold a critical section
Actually, global IRQ control is done in nxsched_resume_scheduler() in nxtask_exit()
However, nxsched_merge_pending() was called after calling nxsched_resume_scheduler()
This commit fixes the issue by moving nxsched_merge_pending() before the function
NOTE: the sequence was changed for SMP but works for non-SMP as well

Impact

This commit affects both SMP and non-SMP

Testing

Tested with ostest with the following configurations
spresense:wifi_smp (NCPUS=2 and 4)
spresense:wifi (non SMP)
sabre-6quad:smp (QEMU)
esp32-core:smp (QEMU)
maix-bit:smp (QEMU)
sim:smp
lc823450-xgevk:rndis

@btashton
Could you backport this PR to 10.0?

repo: apache/incubator-nuttx


text:
littlefs_stat: Fix directory size

Summary
lfs_info.size is only valid for LFS_TYPE_REG.
For directory, use 0 instead of stack garbage.
Impact
Testing
tested on esp32

lfs_info.size is only valid for LFS_TYPE_REG.

see https://github.com/littlefs-project/littlefs/blob/40dba4a556e0d81dfbe64301a6aa4e18ceca896c/lfs.h#L273-L274


text:
Initial commit for Scheduler

This is an initial commit for the new core component, "the scheduler".
This PR supersede the previous PRs, #4507, #4532.
Now we agree with incremental merging into the master.
We will implement modules based on the order defined in this page and add design documents under the page as well:
https://cwiki.apache.org/confluence/display/OPENWHISK/Component+Design
I added the first component design document for the "scheduler" component.
https://cwiki.apache.org/confluence/display/OPENWHISK/Scheduler
I created a new label, "scheduler".
All PRs which are dependent on this PR will be labeled with it.

I think there are supposed to be two checks, jenkins-ci/pr and travis-ci/pr.
I have no idea why there is another check, jenkins-ci/push, but I believe this PR is ready to merge.
jenkins-ci/push is failing because I removed the branch(add-scheduler) in the upstream master.
And that branch is not relevant to this PR.

Kindly review this for subsequent PRs.

Could anyone please review this?

Codecov Report

Merging #4547 into master will increase coverage by 22.85%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #4547       +/-   ##
===========================================
+ Coverage      57%   79.86%   +22.85%
===========================================
  Files         176      176
  Lines        8104     8104
  Branches      535      535
===========================================
+ Hits         4620     6472     +1852
+ Misses       3484     1632     -1852

Impacted Files
Coverage Δ

...whisk/connector/kafka/KafkaConsumerConnector.scala
61.76% <0%> (+1.47%)
:arrow_up:

.../org/apache/openwhisk/core/entity/EntityPath.scala
100% <0%> (+1.88%)
:arrow_up:

...a/org/apache/openwhisk/core/entity/Parameter.scala
95.45% <0%> (+2.27%)
:arrow_up:

...sk/core/containerpool/docker/DockerContainer.scala
96.34% <0%> (+2.43%)
:arrow_up:

.../org/apache/openwhisk/http/PoolingRestClient.scala
91.17% <0%> (+2.94%)
:arrow_up:

...hisk/core/controller/actions/SequenceActions.scala
92.24% <0%> (+3.44%)
:arrow_up:

...pache/openwhisk/core/containerpool/Container.scala
87.5% <0%> (+3.75%)
:arrow_up:

...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala
4% <0%> (+4%)
:arrow_up:

...tainerpool/docker/DockerClientWithFileAccess.scala
96% <0%> (+4%)
:arrow_up:

...rg/apache/openwhisk/core/entity/ExecManifest.scala
97.87% <0%> (+4.25%)
:arrow_up:

... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0d48c8...02f47d3. Read the comment docs.

closing for now.

repo: apache/incubator-openwhisk


text:
[core] Introduce sort-spill-threshold

Purpose

If the maximum number of sort readers exceeds this value, a spill will be attempted.
This prevents too many readers from consuming too much memory and causing OOM.

Tests

API and Format

Documentation

+1

repo: apache/incubator-paimon


text:
Pinot ui can't show all the pinot servers

We have 30 server clusters but this ui just show 10

@shahsank3t

@cxing @xiangfu0
PR raised: https://github.com/apache/incubator-pinot/pull/6956

repo: apache/incubator-pinot


text:
Make transform functions support underscore in the query functions

Description
This PR is to support any underscore in transform functions. e.g. IN_ID_SET, ARRAY_SUM, ARRAY_AVERAGE, etc.
Sample query:
SELECT arrary_sum(intsColum) FROM myTable;

Codecov Report

Merging #6125 into master will decrease coverage by 20.80%.
The diff coverage is 48.75%.

@@             Coverage Diff             @@
##           master    #6125       +/-   ##
===========================================
- Coverage   66.44%   45.64%   -20.81%
===========================================
  Files        1075     1228      +153
  Lines       54773    60010     +5237
  Branches     8168     8795      +627
===========================================
- Hits        36396    27392     -9004
- Misses      15700    30320    +14620
+ Partials     2677     2298      -379

Flag
Coverage Δ

#integration
45.64% <48.75%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ot/broker/broker/AllowAllAccessControlFactory.java
100.00% <ø> (ø)

.../helix/BrokerUserDefinedMessageHandlerFactory.java
52.83% <0.00%> (-13.84%)
:arrow_down:

...org/apache/pinot/broker/queryquota/HitCounter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...che/pinot/broker/queryquota/MaxHitRateTracker.java
0.00% <0.00%> (ø)

...ache/pinot/broker/queryquota/QueryQuotaEntity.java
0.00% <0.00%> (-50.00%)
:arrow_down:

...ava/org/apache/pinot/client/AbstractResultSet.java
26.66% <0.00%> (-30.48%)
:arrow_down:

.../main/java/org/apache/pinot/client/Connection.java
22.22% <0.00%> (-26.62%)
:arrow_down:

.../org/apache/pinot/client/ResultTableResultSet.java
24.00% <0.00%> (-10.29%)
:arrow_down:

...not/common/assignment/InstancePartitionsUtils.java
64.28% <ø> (-8.89%)
:arrow_down:

.../apache/pinot/common/exception/QueryException.java
90.27% <ø> (+5.55%)
:arrow_up:

... and 1208 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81028ce...16384aa. Read the comment docs.


text:
JNI error while trying to execute bin/pulsar standalone

Hey guys,
I'm new to Pulsar and just downloaded the latest version, tried to execute it and got this error.
Error: A JNI error has occurred, please check your installation and try again Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/pulsar/client/admin/PulsarAdminException 	at java.lang.Class.getDeclaredMethods0(Native Method) 	at java.lang.Class.privateGetDeclaredMethods(Class.java:2701) 	at java.lang.Class.privateGetMethodRecursive(Class.java:3048) 	at java.lang.Class.getMethod0(Class.java:3018) 	at java.lang.Class.getMethod(Class.java:1784) 	at sun.launcher.LauncherHelper.validateMainClass(LauncherHelper.java:544) 	at sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:526) Caused by: java.lang.ClassNotFoundException: org.apache.pulsar.client.admin.PulsarAdminException 	at java.net.URLClassLoader.findClass(URLClassLoader.java:381) 	at java.lang.ClassLoader.loadClass(ClassLoader.java:424) 	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331) 	at java.lang.ClassLoader.loadClass(ClassLoader.java:357) 	... 7 more
I have no clue why this is happening, hope you guys can shed some light on it.

Hi @turboT4, can you specify which pulsar version and which environment OS / Java version?

Thanks for the reply @merlimat , I'm trying to run Pulsar on macOS Sierra and Java version 1.8.0_121.

@turboT4 is this issue resolved at your side?

Seems there is no activities here. Closing this issue for now. @turboT4 if this happens again, feel free to report back.

authors: merlimat sijie turboT4

repo: apache/incubator-pulsar


text:
shardingsphere 4.0.0-RC2

Could not initialize class org.apache.shardingsphere.core.parse.core.rule.registry.ParseRuleRegistry
java.lang.NoClassDefFoundError: Could not initialize class org.apache.shardingsphere.core.parse.core.rule.registry.ParseRuleRegistry
at org.apache.shardingsphere.core.parse.SQLParseEngine.parse0(SQLParseEngine.java:71) ~[sharding-core-parse-common-4.0.0-RC2.jar:4.0.0-RC2]
at org.apache.shardingsphere.core.parse.SQLParseEngine.parse(SQLParseEngine.java:53) ~[sharding-core-parse-common-4.0.0-RC2.jar:4.0.0-RC2]
at org.apache.shardingsphere.core.route.router.sharding.ParsingSQLRouter.parse(ParsingSQLRouter.java:66) ~[sharding-core-route-4.0.0-RC2.jar:4.0.0-RC2]
at org.apache.shardingsphere.core.route.PreparedStatementRoutingEngine.route(PreparedStatementRoutingEngine.java:64) ~[sharding-core-route-4.0.0-RC2.jar:4.0.0-RC2]
at org.apache.shardingsphere.core.PreparedQueryShardingEngine.route(PreparedQueryShardingEngine.java:60) ~[sharding-core-entry-4.0.0-RC2.jar:4.0.0-RC2]
at org.apache.shardingsphere.core.BaseShardingEngine.executeRoute(BaseShardingEngine.java:86) ~[sharding-core-entry-4.0.0-RC2.jar:4.0.0-RC2]
at org.apache.shardingsphere.core.BaseShardingEngine.shard(BaseShardingEngine.java:70) ~[sharding-core-entry-4.0.0-RC2.jar:4.0.0-RC2]
at org.apache.shardingsphere.shardingjdbc.jdbc.core.statement.ShardingPreparedStatement.shard(ShardingPreparedStatement.java:224) ~[sharding-jdbc-core-4.0.0-RC2.jar:4.0.0-RC2]
at org.apache.shardingsphere.shardingjdbc.jdbc.core.statement.ShardingPreparedStatement.execute(ShardingPreparedStatement.java:170) ~[sharding-jdbc-core-4.0.0-RC2.jar:4.0.0-RC2]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_201]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_201]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_201]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_201]
at org.apache.ibatis.logging.jdbc.PreparedStatementLogger.invoke(PreparedStatementLogger.java:59) ~[mybatis-3.5.0.jar:3.5.0]
at com.sun.proxy.$Proxy322.execute(Unknown Source) ~[?:?]
at org.apache.ibatis.executor.statement.PreparedStatementHandler.update(PreparedStatementHandler.java:47) ~[mybatis-3.5.0.jar:3.5.0]
at org.apache.ibatis.executor.statement.RoutingStatementHandler.update(RoutingStatementHandler.java:74) ~[mybatis-3.5.0.jar:3.5.0]
at org.apache.ibatis.executor.SimpleExecutor.doUpdate(SimpleExecutor.java:50) ~[mybatis-3.5.0.jar:3.5.0]
at org.apache.ibatis.executor.BaseExecutor.update(BaseExecutor.java:117) ~[mybatis-3.5.0.jar:3.5.0]
at org.apache.ibatis.executor.CachingExecutor.update(CachingExecutor.java:76) ~[mybatis-3.5.0.jar:3.5.0]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_201]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_201]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_201]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_201]
at org.apache.ibatis.plugin.Plugin.invoke(Plugin.java:63) ~[mybatis-3.5.0.jar:3.5.0]
at com.sun.proxy.$Proxy321.update(Unknown Source) ~[?:?]
at org.apache.ibatis.session.defaults.DefaultSqlSession.update(DefaultSqlSession.java:198) ~[mybatis-3.5.0.jar:3.5.0]
at org.apache.ibatis.session.defaults.DefaultSqlSession.insert(DefaultSqlSession.java:185) ~[mybatis-3.5.0.jar:3.5.0]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_201]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_201]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_201]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_201]
at org.mybatis.spring.SqlSessionTemplate$SqlSessionInterceptor.invoke(SqlSessionTemplate.java:433) ~[mybatis-spring-2.0.0.jar:2.0.0]
at com.sun.proxy.$Proxy179.insert(Unknown Source) ~[?:?]
at org.mybatis.spring.SqlSessionTemplate.insert(SqlSessionTemplate.java:278) ~[mybatis-spring-2.0.0.jar:2.0.0]
at com.baomidou.mybatisplus.core.override.MybatisMapperMethod.execute(MybatisMapperMethod.java:64) ~[mybatis-plus-core-3.1.0.jar:3.1.0]
at com.baomidou.mybatisplus.core.override.MybatisMapperProxy.invoke(MybatisMapperProxy.java:61) ~[mybatis-plus-core-3.1.0.jar:3.1.0]
at com.sun.proxy.$Proxy218.insert(Unknown Source) ~[?:?]
at com.baomidou.mybatisplus.extension.service.impl.ServiceImpl.save(ServiceImpl.java:105) ~[mybatis-plus-extension-3.1.0.jar:3.1.0]
at com.baomidou.mybatisplus.extension.service.impl.ServiceImpl$$FastClassBySpringCGLIB$$76535273.invoke() ~[mybatis-plus-extension-3.1.0.jar:3.1.0]
at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218) ~[spring-core-5.1.6.RELEASE.jar:5.1.6.RELEASE]
at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:684) ~[spring-aop-5.1.6.RELEASE.jar:5.1.6.RELEASE]

Can you change the title to more make sense?

Closed for not change title

authors: chaiyanliang terrymanu

repo: apache/incubator-shardingsphere


text:
sharding-jdbc and sharding-proxy use same metaData refresh strategy.

i find sharding-jdbc and sharding-proxy have same code for metaDataRefresh after execute ddl.
so i remove MetaDataRefreshStrategy from Sharding-jdbc-core to ShardingSphere-common.
then sharding-jdbc ,sharding-proxy can use same code.

Pull Request Test Coverage Report for Build 10852

6 of 12 (50.0%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 57.317%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/executor/AbstractStatementExecutor.java
0
3
0.0%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/impl/ShardingSchema.java
0
3
0.0%

Totals

Change from base Build 10851:
0.2%

Covered Lines:
11664

Relevant Lines:
20350

💛  - Coveralls


text:
[Question] <When the project is started, the ZK node cannot be found exception occurs>

Question
jdk version: jdk11
shenyu version : 2.4.1
exception stack：
Exception in thread "shenyu-disruptor-shenyu_disruptor_consumer_-17" org.I0Itec.zkclient.exception.ZkNoNodeException: org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /shenyu/register/metadata/http/knowledge-mall//knowledge-mall/--knowledge-mall-**
at org.I0Itec.zkclient.exception.ZkException.create(ZkException.java:47)
at org.I0Itec.zkclient.ZkClient.retryUntilConnected(ZkClient.java:1001)
at org.I0Itec.zkclient.ZkClient.create(ZkClient.java:528)
at org.I0Itec.zkclient.ZkClient.create(ZkClient.java:499)
at org.I0Itec.zkclient.ZkClient.createPersistent(ZkClient.java:386)
at org.apache.shenyu.register.client.zookeeper.ZookeeperClientRegisterRepository.registerMetadata(ZookeeperClientRegisterRepository.java:95)
at org.apache.shenyu.register.client.zookeeper.ZookeeperClientRegisterRepository.persistInterface(ZookeeperClientRegisterRepository.java:64)
at org.apache.shenyu.client.core.disruptor.subcriber.ShenyuClientMetadataExecutorSubscriber.executor(ShenyuClientMetadataExecutorSubscriber.java:51)
at org.apache.shenyu.client.core.disruptor.executor.RegisterClientConsumerExecutor.run(RegisterClientConsumerExecutor.java:47)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)

please provide more information of your setup step, and related project and configuration.

when project bootstrap. occur this exception.
config:
shenyu:
client:
registerType: zookeeper
serverLists: zk1.yaomaitong.net:2181
props:
props:
appName: appName
# 当前mvc项目在ShenYu网关的路由前缀
contextPath: ${server.servlet.context-path}
# 本项目的启动端口
port: ${server.port}
# 设置true 代表代理你的整个服务，false表示代理你其中某几个controller
isFull: true

can you format your config file?

step1:
shenyu:
    client:
    registerType: zookeeper
    serverLists: zk1.yaomaitong.net:2181
    props:
      contextPath: ${server.servlet.context-path}
      port: ${server.port}
      isFull: true

ZookeeperClientRegisterRepository
DEBUG1：

DEBUG2:

when DEBUG2,  occur the exception.
step2:
I created a metaRegisterDTO object that is the same as in the DEBUG1 picture and tested it in the 2.4.1 source code
ZookeeperClientRegisterRepositoryTest#testPersistInterface():
    @Test
    public void testPersistInterface() {
        MetaDataRegisterDTO data = MetaDataRegisterDTO.builder()
                .rpcType("http")
                .host("192.168.3.179")
                .port(8081)
                .contextPath("/qxs-api/**")
                .ruleName("/qxs-api/**")
                .build();
        repository.persistInterface(data);
        String metadataPath = "/shenyu/register/metadata/http/qxs-api/qxs-api-**";
        Assert.assertTrue(zookeeperBroker.containsKey(metadataPath));
        Assert.assertEquals(zookeeperBroker.get(metadataPath), GsonUtils.getInstance().toJson(data));
        repository.close();
    }

Test Result：
09:33:31.507 [main] INFO org.apache.shenyu.register.client.zookeeper.ZookeeperClientRegisterRepository - http zookeeper client register success: MetaDataRegisterDTO{appName='null, contextPath='/qxs-api/**, path='null, pathDesc='null, rpcType='http, serviceName='null, methodName='null, ruleName='/qxs-api/**, parameterTypes='null, rpcExt='null, enabled=false, host='192.168.3.179, port=8081, pluginNames=[], registerMetaData=false}

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.shenyu.register.client.zookeeper.ZookeeperClientRegisterRepositoryTest.testPersistInterface(ZookeeperClientRegisterRepositoryTest.java:132)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)

the method's target replace "/" to "-" ，but when context path is "/xx/" rule name is "/xx/"， then final nodeName still exist "/"

step1:
shenyu:
    client:
    registerType: zookeeper
    serverLists: zk1.yaomaitong.net:2181
    props:
      contextPath: ${server.servlet.context-path}
      port: ${server.port}
      isFull: true

ZookeeperClientRegisterRepository DEBUG1：
DEBUG2:
when DEBUG2, occur the exception.
step2: I created a metaRegisterDTO object that is the same as in the DEBUG1 picture and tested it in the 2.4.1 source code
ZookeeperClientRegisterRepositoryTest#testPersistInterface():
    @Test
    public void testPersistInterface() {
        MetaDataRegisterDTO data = MetaDataRegisterDTO.builder()
                .rpcType("http")
                .host("192.168.3.179")
                .port(8081)
                .contextPath("/qxs-api/**")
                .ruleName("/qxs-api/**")
                .build();
        repository.persistInterface(data);
        String metadataPath = "/shenyu/register/metadata/http/qxs-api/qxs-api-**";
        Assert.assertTrue(zookeeperBroker.containsKey(metadataPath));
        Assert.assertEquals(zookeeperBroker.get(metadataPath), GsonUtils.getInstance().toJson(data));
        repository.close();
    }

Test Result：
09:33:31.507 [main] INFO org.apache.shenyu.register.client.zookeeper.ZookeeperClientRegisterRepository - http zookeeper client register success: MetaDataRegisterDTO{appName='null, contextPath='/qxs-api/**, path='null, pathDesc='null, rpcType='http, serviceName='null, methodName='null, ruleName='/qxs-api/**, parameterTypes='null, rpcExt='null, enabled=false, host='192.168.3.179, port=8081, pluginNames=[], registerMetaData=false}

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:86)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertTrue(Assert.java:52)
	at org.apache.shenyu.register.client.zookeeper.ZookeeperClientRegisterRepositoryTest.testPersistInterface(ZookeeperClientRegisterRepositoryTest.java:132)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)

please change metadataPath from  String metadataPath = "/shenyu/register/metadata/http/qxs-api/qxs-api-"; to
String metadataPath = "/shenyu/register/metadata/http/qxs-api//qxs-api/--qxs-api-";

yes, as your context contains / in middle.

zk node can't be found exception,

this url contains two //, please check.
/shenyu/register/metadata/http/knowledge-mall//knowledge-mall/--knowledge-mall-**

throw exception NoNode for /shenyu/register/metadata/http/qxs-api//qxs-api/--qxs-api-**

NoNode for /shenyu/register/metadata/http/qxs-api//qxs-api/--qxs-api-**

zk node can't be found exception,

this url contains two //, please check.
/shenyu/register/metadata/http/knowledge-mall//knowledge-mall/--knowledge-mall-**

that is editor's problem, i upload image, please view image’s exception

have you checked whether zk server has that node?

There is no node of that ZK, because the NO NODE exception is reported when it is created

can you give me for your wechat ? wecaht chat

shenyu:
client:
registerType: zookeeper
serverLists: zk1.yaomaitong.net:2181
props:
contextPath: /qxs-api/**   change to /qxs-api
port: ${server.port}
isFull: true
please change contextPath from /qxs-api/** to /qxs-api and retry

can you give me for your wechat ? wecaht chat

ahahage@163.com please send you wechat there

this is a bug, as user config is as below, isFull proxy all controller, but contextPath will rewrite to /contextPath/, add /,  when register metadata, and call zkClient.createPersistent(realNode, GsonUtils.getInstance().toJson(metadata)); realNode will contain two /, in zk it means two level directory, but parent node is not created ever, this call print error.

// if contextPath has two /, in zk means two folder, we need to create parent folder first, or else it will throw no node exception
zkClient.createPersistent(realNode, true);             zkClient.writeData(realNode, GsonUtils.getInstance().toJson(metadata));

authors: AhahaGe wtlihao

repo: apache/incubator-shenyu