text:
Clean up example samples

Why are these changes needed?

This PR cleans up the "complete" and "autoscaler" sample yamls a bit.
Unnecessary pod spec fields are removed without sacrificing the completeness of the examples.
The idea is to make the configuration look less intimidating.
Related issue number

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

great. These configuration are covered by codes. Looks good to me

We could consider automatically configuring the init container and pre-stop hook in the 0.4.0 release.

Just going to double check that the configs don't have any issues before merging.

authors: DmitriGekhtman Jeffwan

repo: ray-project/kuberay


text:
[Zoom] RangeError: Invalid time value when opening upcoming meetings

Extension – Zoom
Author: @thomaslombart

Description
When running the "Upcoming Meetings" command I get the following error:

Error:
P.S. I had to truncate line 66 because it was too long to fit in this GitHub issue.
RangeError: Invalid time value

Ez:upcoming-meetings.js:66:62949

---
63:       ${e>0&&e<1?`<path d="${SP(50,50,s,0,e*360)}" stroke="${t}" stroke-width="${a}" fill="none" />`:""}
64:     </svg>
65:   `.replaceAll(`
66: `,"")}`}cu.getProgressIcon=kP});var Gw=g(Lr=>{"use strict";var MP=Lr&&Lr.__createBinding||(Object.create?func...
67: Content-Disposition: form-data; name="`;return e.forEach((a,u)=>typeof a=="string"?A.push(n+eB(u)+`"\r
68: \r
69: ${a.replace(/\r(?!\n)|(?<!\r)\n/g,`\r
---

Ioe:upcoming-meetings.js:79:3634
upcoming-meetings.js:79:4063
    at Array.reduce (<anonymous>)
BH:upcoming-meetings.js:79:4024
upcoming-meetings.js:79:7545
Object.useMemo:react-reconciler.production.min.js:5:27195
exports.useMemo:react.production.min.js:25:208
Coe:upcoming-meetings.js:79:7540
Ql:react-reconciler.production.min.js:5:20846

Raycast version
Version: 1.39.1

do you perhaps have a meeting which somehow doesn't have start time?

@IGassmann Do you happen to have recurring meetings in your upcoming meetings? I was able to reproduce the bug with this kind of meetings.

@thomaslombart Yes, I do. Most of them actually.

That's the culprit. I assumed every meeting had a start time which is not the case with these types of recurring meetings. I'll fix that bug soon.

The issue should be fixed with the following PR: #2757.

source: gharchive/issue

authors: IGassmann mathieudutour thomaslombart

repo: raycast/extensions

license: MIT

license_type: permissive

license_source: github-api


text:
[Jira] ...

Extension
https://www.raycast.com/raycast/jira
Description
Error:
Error: Worker terminated due to reaching memory limit: JS heap out of memory

NodeError:errors:399:5
[kOnExit]:worker:287:26
Worker.<computed>.onexit:worker:209:20

Steps To Reproduce
Environment: MacBook Pro 16-Inch 2021 16 GB, MacOS Ventura 13.4

Click "Search Issues"

Current Behaviour
Something went wrong
Expected Behaviour
Display a list of Jira issues

Thanks for bringing this up. It appears that this is a duplicate of issue #7013, so I'll mark it as such.

authors: daghoidahl thomaslombart


text:
[Arc]...

Extension
https://raycast.com/the-browser-company/arc
Description
Error:
SyntaxError: Unexpected token u in JSON at position 6404
    at JSON.parse (<anonymous>)
    at Object.E5 [as current] (/Users/loekbosman/.config/raycast/extensions/606e26d8-b3c5-4760-8001-dccce1b872c4/search-tabs.js:87:20)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Steps To Reproduce
search within tabs
Current Behaviour
No response
Expected Behaviour
No response

Hi @loekbosman 👋
Is there any weird characters in your tab names at the moment?

Are emoji's weird?
On Mon, Aug 07, 2023 at 14:50:32, Per Nielsen Tikær < @.*** > wrote:

Hi @ loekbosman ( https://github.com/loekbosman ) 👋
Is there any weird characters in your tab names at the moment?
—
Reply to this email directly, view it on GitHub (
https://github.com/raycast/extensions/issues/7829#issuecomment-1667799393
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/ASQY5F4U554C56UEH7UGCUTXUDQBRANCNFSM6AAAAAA3G2REU4
).
You are receiving this because you were mentioned. Message ID: <raycast/extensions/issues/7829/1667799393
@ github. com>

@loekbosman  - I wasn't able to reproduce this bug, even with emoji's in the title. Do you have some of your tab titles that I can use to reproduce the error?

Hi,
I just reinstalled the extension, I instantly get this error.
Some of the tabs open:
On Tue, Aug 08, 2023 at 03:15:31, hugo < @.*** > wrote:

@ loekbosman ( https://github.com/loekbosman ) - I wasn't able to reproduce
this bug, even with emoji's in the title. Do you have some of your tab
titles that I can use to reproduce the error?
—
Reply to this email directly, view it on GitHub (
https://github.com/raycast/extensions/issues/7829#issuecomment-1668769113
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/ASQY5F37RJX6FDJTQU24D43XUGHLHANCNFSM6AAAAAA3G2REU4
).
You are receiving this because you were mentioned. Message ID: <raycast/extensions/issues/7829/1668769113
@ github. com>

I have the same issue:
Error:
SyntaxError: Unexpected token  in JSON at position 7650
    at JSON.parse (<anonymous>)
    at Object.E5 [as current] (/Users/maurelian/.config/raycast/extensions/606e26d8-b3c5-4760-8001-dccce1b872c4/search-tabs.js:89:17)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

I have a ton of tabs (that's what Arc is for after all), but I looked for weird characters, and closed a lot of tabs and cannot get it to work.
I did notice the the position number given seems to always decrease when I close a tab, which suggests to me that the unexpected token is at the end.
How would one go about getting this JSON string out?

Maybe someone could update the title of this issue to make it more descriptive? Would help me to find and check-in on it occasionally.

Do you know how to Fork an extension @maurelian? If so you should be able to npm run dev and find the location in the code

authors: hugivar loekbosman maurelian pernielsentikaer


text:
New extension: Supernova.io

Description
Supernova.io is a super fast-growing platform to help designers and developers manage their design system, design system data and documentation.
We have created a Raycast extension to make accessing design system data easy for all of our users. In general, the extension allows you to:

Search user documentation site
Search design system styles
Search design system assets
Search and action upon design system components

We have used lot of fancy things that your API allows to do and also worked around some limitations in creative ways. We have made the system as performant as possible.
Screencast
To help you understand this a little bit better, I made a video just for the purposes of review, enjoy!
https://www.youtube.com/watch?v=FJcyuqnzo0U&ab_channel=Supernova
How to test yourself
You'll need API key to test app yourself. For that, I have prepared a test account with some data linked to it. The access is as follows:

Sign in here: https://cloud.supernova.io/
Username: raycast-review [at] domain.com
Password: IFuckingLoveRaycast

Let us know what you think! I am available on Raycast Slack as Jiri (Supernova.io) should you have some questions - reach out if needed!
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

I have added title case where appropriate (command titles) unless command specifically mentions dynamic name (ie. Download page.png) as that is a filename and naming will be consistent for all commands in the list. I have added icon to custom actions where missing. Thank you for pointing this out, I will be more diligent in reading the list next time :)

@pernielsentikaer Yes, I have, my bad. For security reasons, I have removed Figma integration for the reviewer account and it is used to render the images. I have reconnected the Figma integration for the review so you can proceed :) I have also exposed the error in the error message popup.

source: gharchive/pull-request


text:
Add new Laravel shift extension

Description
Running Laravel Shift  makes upgrading Laravel applications a breeze.
If needed, there is a possibility to run the shifts locally instead of in the cloud, due to policies or agreements which prevent you from sharing code it in any way, which applies to me.
To run a Shift locally, a command with some parameters, a SHIFT_TOKEN and a SHIFT_CODE is needed.
It can be hard to remember all the possible shift codes and you always have to look up the shift code.
That's where this extension comes in: easily generating Laravel Shift commands for Docker
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi @pernielsentikaer,
Thanks for your reply.
At first I had the toast, while the goal of this command is just copying the command, I thought it would make more sense if you just close the form after copying.
But I can Imagine, people will make additions to the generated command (which is why I made the output field editable), so maybe a toast is more user friendly?
I can also made it configurable in the extension settings.
What do you think?

Thanks for the corrections, much appreciated ❤🔥
Could you check my corrections and make sure I didn't break anything

@pernielsentikaer many thanks for the corrections, everything still works fine! 😊

It still feels like the UX should be improved, like when it's showing the command and you focus the field (if you want to modify it) it just copies it and you'll have to blur and focus again to copy it
I'm not sure what the best way to do this is, what do you think?

I agree with that. What if we change the behaviour of the onChange trigger on the TextArea to something like this?
// onChange={setShiftCommand}
onChange={(shiftCommand: string) => {
    setShiftCommand(shiftCommand);
    copyToClipboard(shiftCommand).then(() => showToast(Toast.Style.Success, "Command copied to clipboard"));
}}

This wil update the command while you're typing, and at the same time copying it to the clipboard.
It may need a timeout of a few ms to prevent a lot of trigger events?
https://user-images.githubusercontent.com/3907144/231433311-650c2827-08d4-4512-ac50-a4bedde62801.mov

@pernielsentikaer So you mean that only the dropdown and textfield (project path) will trigger the text area being filled and copied to the clipboard. That means that the manual call for Generating Shift Command with the command+enter will be removed.
Wat to do if you manually change the contents of the textarea? Just let the user copy the contents manually?

Ideally, I would just make the action into a copy that will copy whatever is in the text field and make the two other fields update it 😊
Then you can both copy manually or use the action

Ah great, thanks, I can build that I guess. I will try to fix this today (afternoon). If I have any questions I will let you know.
Thanks for so far and taking the time to improve the extension, I really appreciate that 😊

That would nice, and yes, let me know if you need anything at all, I'm here to help you out

authors: denniseilander pernielsentikaer


text:
Error 0x2e OrderAtSlotIsPlace

Hi,
I encounter an error, with code 0x2e (OrderAtSlotIsPlaced) when send transaction to remove liquid from a LP.
I am unable to locate where the error comes from as there is nowhere in the raydium-amm code base produce this error.
Please let me know what is wrong here?
Thanks

Early version, there is nothing wrong with this problem.

authors: RainRaydium bachkimn

repo: raydium-io/raydium-amm


text:
Promise not to buffer par_bridge

Closes #1068

bors r+

repo: rayon-rs/rayon


text:
[raymath.h] Small code refactor

The pull request is divided into 2 small commits, so you may don't want to merge both.

I identified two functions that have duplicated code, so I refactored to avoid it. You might don't want to merge this change because you might prefer the readability, but I just wanted to give it a try in case you agree with it :)
A ternary operator didn't have proper left space as the rest. Some divisions have both spaces also.

@idircarlos Nice! Thanks for the review!

license: Zlib


text:
[rcore] [web] Simplify EmscriptenResizeCallback()

So it doesn't depend on macro'd JS functions. Changes can be tested with:
// Note: usage of `minshell.html` is recommended since it won't force canvas CSS overrides

#include "raylib.h"
int main(void) {
    InitWindow(800, 450, "test");
    SetTargetFPS(60);

    SetWindowState(FLAG_WINDOW_RESIZABLE);

    while (!WindowShouldClose()) {
        BeginDrawing();
        ClearBackground(RAYWHITE);

        DrawText("Resize the browser window manually", 20, 20, 20, BLACK);
        DrawText(TextFormat("canvas size: %i x %i", GetScreenWidth(), GetScreenHeight()), 20, 40, 20, BLACK);

        EndDrawing();
    }
    CloseWindow();
    return 0;
}

@asdqwe Nice! Thanks for the review!


text:
fixes github actions

Description
Please include a summary of the change, motivation and context.

Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:

[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules

Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

Codecov Report

:exclamation: No coverage uploaded for pull request base (rzp_main@9d96a71). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             rzp_main       #4   +/-   ##
===========================================
  Coverage            ?   43.26%
  Complexity          ?       69
===========================================
  Files               ?       14
  Lines               ?      557
  Branches            ?       33
===========================================
  Hits                ?      241
  Misses              ?      303
  Partials            ?       13

Flag
Coverage Δ

unit
43.26% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

repo: razorpay/hypertrace-config-bootstrapper


text:
Panic on order create

This is how my code looks like
data := map[string]interface{}{
	"amount":          amountInCents,
	"currency":        "INR",
	"receipt_id":      receiptID,
	"payment_capture": 1,
}
extra := map[string]string{}
body, err := os.RPClient.Order.Create(data, extra)
if err != nil {
	glog.Error("Failed from RazorPay - ", err)
}

I am getting this error
Failed from RazorPay - %!v(PANIC=Error method: runtime error: invalid memory address or nil pointer dereference)

I figured that the order create request is returning 400 in the SDK but the same request on curl is returning 200.
What am I missing?

Facing similar issue. It has been 14 days for me and no one from razor pay team has responded.  Not at all a good experience while integrating.

The documentation is incorrect, it should be receipt and not receipt_id in payload
data := map[string]interface{}{
	"amount":          amountInCents,
	"currency":        "INR",
	"receipt":      receiptID,
	"payment_capture": 1,
}

This is how my code look like
data := map[string]interface{}{
	"amount":          1000,
	"currency":        "INR",
	"receipt":      receiptID,
	"payment_capture": 1,
}
extraHeader := map[string]string{
		"API_KEY": "SECRET_KEY",
	}
body, err := client.Order.Create(data, extraHeader)
if err != nil {
		log.Println(err)
}

I am getting this error when i create order with incorrect api key or secret key
%!v(PANIC=Error method: runtime error: invalid memory address or nil pointer dereference)

I want to know which type of error is returning
Same request on curl returning 401 response code

401 response code is the error for UnAuthorized error or Invalid Key & Permission Denied

Few issues with error handling in the library.

Errors are not being hydrated correctly here
The Err attribute isn't set here, and is read later causing nil pointer errors.

Will patch this in an upcoming release.

authors: amitmahbubani rebootcode sanbornsen shashankvivek shyamkumargithub

repo: razorpay/razorpay-go


text:
Is there any way for styling?

Hi there,
thanks for fantastic work. Is there any way to style components for dark mode? I'd like to change a text colour for FloatInput's label for example.
Thank you for any advice :)

Sure. You can use antd customize theme. All props same as antd.
Thanks.

I see, but cannot find the right way to change colours of the custom components. Can you provide some very basic example of how to change border colour and label colour of FloatingInput, please?

You can try the codes
<ConfigProvider theme={{token: {colorPrimary: "#FF00CC"}  }}>
    <FloatInput placeholder="User Name" />
</ConfigProvider>


text:
Convert the SQLite job queueing service to a Redis queue.

The current SQLite usage of for a job queueing system has a lot of vulnerabilities and might not have full run to completion if a job is lost. A redis queue would solve this.

this would be nice

authors: rbitia samkreter

repo: rbitia/aci-demos

license: mit

license_source: bigquery


text:
text_operand serialize

Hello, I would like to ask, when will the following piece of code be called?
Will it be called when a binding occurs?
If I simply use serialize to convert a statement into a raw statement string, is it possible to invoke it?
include/sqlpp11/data_types/text/operand.h
template
Context& serialize(const text_operand& t, Context& context)
{
context << ''' << context.escape(t._t) << ''';
return context;
}

It will be invoked when you serialize an expression with a text operand, e.g. tab.my_string == "sample".

authors: qbgbmpty rbock


text:
Change load balacing mode in f5-config.py to least-connections-node

Do NOT include any confidential information, this issue will be created on a public repo
This section is completed by the issue reporter
On which version(s) do you encounter this issue?
Please provide the output to 'git describe --all' for  all deployments where you have confirmed it occurs.
What type of issue is this? Please tick the appropriate box.

[x] bug - existing functionality that does not work for you as documented
[ ] feature - new functionality that you would like to see added

What is the expected behavior?
fastest-node mode is used instead of least-connections here:
https://github.com/rcbops/rpc-openstack/blob/master/scripts/f5-config.py#L106
What is actually happening?
See above
What were you attempting to do when you encountered this error (give as much detail as possible)?
NA
How can we reproduce this issue?
NA
How can we verify your issue is addressed?
NA
If you are using or know of a workaround please describe the necessary steps?
NA
What is your evaluation on the importance of this issue, and why?
prio-3 per email conversation with @dpham
This section is completed during the issue resolution process. If you are reporting an issue, please do not modify the section below.
Which branches are impacted by this issue?
Remove branches that are not impacted.
For each pull request, update the branch line to reference it.

[x] master
[x] newton-14.0
[x] mitaka-13.1
[ ] liberty-12.2

Upgrade impact. Consider the impact on moving between major, minor and patch releases.

[x] This change does not impact upgrades
[ ] This change addresses a potential upgrade impact
[ ] The upgrade impact is being tracked by another issue.

The issue tracking the upgrade impact is:
Testing impact

[ ] An issue/pull-request has been create or exists to track the testing gap, and is referenced below
[ ] This change includes additional testing
[x] This change is tested by the existing setup

Additional testing links:
Release note

[ ] This change includes a release note.
[x] This change does not require a release note.

Doc Impact
Does your change require documentation?

[ ] Yes, and I submitted an issue to Docs issues
[ ] Yes, and I contributed a documentation patch to docs-rpc
[x] No documentation required for this change

Additional documentation links (please add links if you have ticked yes):

Closing as this is solved by: https://github.com/rcbops/rpc-openstack/pull/1921

repo: rcbops/rpc-openstack


text:
Debug tests

add flush queue on stopping logging

now i am done. It will be merged to master after this test is sucessfully run

repo: rchicoli/docker-log-elasticsearch


text:
Wrong URL for issues in Magic tags help

Currently the link leads to https://github.com/rcvd/MagicTags/issues, instead of https://github.com/rcvd/magic-tags/issues

Fixed with the upcoming release

authors: kvistgaard rcvd

repo: rcvd/magic-tags


text:
Re-generate starting plans

... assuming that we use GerryChain's default sampling method (Kruskal) and don't use GerryChain's from_random_assignments.

... or get from_random_assignments() to work for all states and plan types.

repo: rdatools/rdabase


text:
deviceDisplay.MainDisplayInfo = 'deviceDisplay.MainDisplayInfo' threw an exception of type 'Xamarin.Essentials.NotImplementedInReferenceAssemblyException'

Hi there,
First of all thanks for making this nuget available. Im just having an issue though with the IDeviceDisplay and calling the MainDisplayInfo. In my app in the App.cs class I am checking the device main display info and the exception being raised is:
deviceDisplay.MainDisplayInfo = 'deviceDisplay.MainDisplayInfo' threw an exception of type 'Xamarin.Essentials.NotImplementedInReferenceAssemblyException'

Would this be because I'm running unit tests without on an actual device and there is simply no implementation of it therefore?
I actually Registered the service prior to calling it using FreshMVVM i.e.
 private void setupIOC()
        {
...
            FreshIOC.Container.Register<IDeviceDisplay, DeviceDisplayImplementation>();
        }

Then I resolve it later in app.cs class but exception occuring here:
            IDeviceDisplay deviceDisplay = FreshIOC.Container.Resolve<IDeviceDisplay>();

            // Get Metrics
            DisplayInfo mainDisplayInfo = deviceDisplay.MainDisplayInfo;

Anyway to resolve this so it returns DisplayInfo?

Im guessing its better to avoid the call to MainDisplayInfo with a condition check i.e if not supported like following:
if (DeviceInfo.Platform != DevicePlatform.Unknown)
            {
                   Safe to call deviceDisplay.MainDisplayInfo;
             }

Howdy - yes, the error is saying that the display API has no implementation in the reference (shared/cross-platform) assembly, because the implementations are provided for each specific platform (iOS/Android, etc.). In a 'headless' scenario like you are describing, you have no platform implementation so you end up with this.

Im guessing its better to avoid the call to MainDisplayInfo with a condition check i.e if not supported like following:

That should work; another test-friendly approach would be to register a mock implementation instead, like:
public class UnitTestDeviceDisplay : IDeviceDisplay
{
	public bool KeepScreenOn { get; set; }

	public DisplayInfo MainDisplayInfo => new DisplayInfo();

	public event EventHandler<DisplayInfoChangedEventArgs> MainDisplayInfoChanged;
}

Or you could use a mocking library, particularly if you need values on MainDisplayInfo to be sensible (in the above width/height etc. will be zero).

Avoiding the call works for now, the only reason MainInfo needs to be called is because I used a different ResourceDictionary with styles dependant on that device size. However in a unit test scenario this is fairly trivial. If I do need values Ill mock it with NSubstitute with I use for mocking.

authors: LeoJHarris rdavisau

repo: rdavisau/essential-interfaces


text:
Gif branch problems

There's no documentation for how to install the gif brach, replacing files didin't work for me.
I'm on windows 10, using python 3.10
Edit: Alright you have to replace the themes folder, nothing else
Anyway, gif branch seems as slow when resizing, I would rename this to gif brach problems now.

There's no documentation for how to install the gif brach

Yeah it isn't on Pypi, you can download it only from here.

Anyway, gif branch seems as slow when resizing, I would rename this to gif brach problems now.

Hmmm... Interesting.
The point of making ttk themes with gif images is to increase its speed, so if even that is laggy, I can't really do much more to optimize it.
I don't experience any lagging on a 13-year-old computer running Debian, with either the png or gif versions, so this may be a limitation of the Windows port of Tkinter.

Oh, so we use the theme the window will be laggy and thw window resize with be to slow (When my window resize the CPU using is high and exponential growth )?

Even there is no doc to install the gif branch, but i successed, @xdanielc, you can see my github project "CodeNoteBook", i replace the png branch to gif branch, it looks great, the scrollerbar is good than png branch, but the window is still laggy, but CPU using is slow... okay, not really slow, just kick down a little.

The CPU usage is indeed higher (like 40-50%) when resizing the window, but unfortunately I can't address that issue here. It's simply the nature of ttk. It uses png/gif images for widget parts, and cropping, copying and scaling them is just slow 😕

Doing further experiments, I realized, that the 40-50% is not that bad compared to other, quite simple applications. For example my screenshot tool and emoji selector (both Qt-based) have around the same CPU-usage when resizing the window.

for my app I just disable the option to resize it

Why can't thinter's author update tkinter and fix tkinter...

Or just tkinter.ttk's author find a way to fix ttk widget image show

Because it's not that easy. First, Tkinter uses an other GUI toolkit under the hood, called Tcl/Tk, so it cannot be fixed in Tkinter. Second, it's simply not possible. Tcl/Tk uses native APIs to render images, and this speed is the fastest possible.

......ay

authors: HuyHung1408 rdbende sadjok xdanielc

repo: rdbende/Sun-Valley-ttk-theme


text:
Link to Slack is not working

The link provided to the slack channel is not working? I was wonder if that can be updated or if anyone can send me some practice questions for RHCSA8?
Thanks!

i have the same issue

can you renew the slack link ? join.slack.com/


text:
support for triangular meshes with vertices and faces

Meshcat is awesome. I want to know if I can visualize an arbitrary triangular mesh with vertices and faces. I have code which is generating the mesh online and I want to visualize it using meshcat. Is it possible?

I am seriously considering using meshcat and meshcat-python for my project. Having this support can get me working with meshcat right away.

This should be working as soon as https://github.com/rdeits/meshcat-python/pull/59 is merged! Can you please let me know if that works for your use case?

Thanks! Works great for me :)

authors: kunguz nitin-ppnp rdeits

repo: rdeits/meshcat-python


text:
Eslint minify

Eslint does not minify JS and also append @lightningjs/core package into appBundle.js file. Result is appBundle file with enormous  file size.
This PR, minify source code and remove litghtning.js dependency. Output is less JS code in appBundle. Much better result than rollup.

@michielvandergeest Yet another PR. :-)

repo: rdkcentral/Lightning-CLI


text:
ut-core: 5.0.0 - ut-core: maintenance

This milestone is tracking issues with the current setup, these will be separated later into a valid milestone

Milestone no longer required.

repo: rdkcentral/ut-core


text:
Cannot import the module with require('rdkit')

I wanted to test the library (would be really cool to have RDKit in the browser!), but unfortunately was unable to get it to work. I am using what I assume is the latest version (0.5.1) from npm.
When I execute the following code:
const RDKit = require('rdkit'); // using 'rdkit' because 'RDKit' from the README did not work for me

I am getting the following error:
TypeError: rdkit.wast is not a valid URL.

Callstack:
locateFile rdkit.js:21
    integrateWasmJS rdkit.js:63
    rdk rdkit.js:63
    js rdkit.js:77
    __WEBPACK_AMD_DEFINE_RESULT__ rdkit.js:52
    js rdkit.js:53
    js rdkit.js:59
    js 1.chunk.js:289967
    Webpack 28

Relevant code bit:
  18 | var path = getCurrentPathBrowser();
  19 | var Module = {
  20 |   locateFile(url) {
> 21 |     return new URL(url, path).href;
     | ^  22 |   },
  23 |   onRuntimeInitialized() {
  24 |     resolve();

Any idea? Thanks!

Hi @martin-sicho : we aren't really supporting this any more (and should indicate that in the documentation).
There's a new JS wrapper for using the RDKit in the browser that's part of the core RDKit. There's a description with some background info here:
http://rdkit.blogspot.com/2019/11/introducing-new-rdkit-javascript.html

please use the more supported version https://github.com/rdkit/rdkit/tree/master/Code/MinimalLib

@greglandrum Maybe it worth to update npm package to currect version or create new npm package?

We should probably delete the npm package.
I'd be happy to make uploading the new package to npm part of the standard rdkit release cycle if

it's ok to upload large wasm files to npm
someone explains to me how to do it
Note that I have limited time to invest in figuring this stuff out.

authors: greglandrum martin-sicho rmrmg thegodone

repo: rdkit/RDKitjs


text:
anaconda & python2

I've installed newest RDkit with anaconda and (within the enviroment) it works only with python3. In python2 I have ImportError: No module named rdkit. Is it possible to use python2 in conda env?

yes, it should work with Python2.
Which operating system are you using and how did you install the RDKit in the python2 environment?

I've installed anaconda2 (https://repo.continuum.io/archive/Anaconda2-5.1.0-Linux-x86_64.sh) and  followed instruction on http://www.rdkit.org/docs/Install.html. The OS is Mint 18, but as far as I understood conda make installation independent from OS.

It's important to know the OS (linux, windows, or Mac) in order to be able to diagnose problems.
From inside the shell where you are trying to run the RDKit, can you please do:
conda list | egrep "rdkit|python"
and send the output?

I assumed that everyone use one of Linux distros ;) In conda list I had:
python                    3.6.4                hc3d631a_3
python-dateutil           2.7.2                    py36_0
rdkit:           2017.09.3.0-py36_1    rdkit
I recreate env with following command:
conda create -c rdkit -n my-rdkit-env rdkit python=2.7
now rdkit is available in python2.7 (and python command executes 2.7.x version).
It solved me problem (I think it will be good to add this information to install page), however in such env I cannot used rdkit in python3 (which is not problem for me).
By the way: I am not familiar with conda, so I ask this question to be 100% sure: are the conda env truly independent from each other and from system's library?

You have to have separate environments for python2 and python3 (not separate conda installs, just separate environments).
And, yes, they are quite independent of each other and reasonably independent of the OS libraries.

I had the same problem under linux, but not under Mac: both have (mini)conda2 installed. When installing rdkit under Mac, using condo install -c rdkit -n <env-name> rdkit was sufficient and it installed for python2.7 and worked fine. When I used exactly the same command under linux, it installed rdkit for python3.6 which it also installed in the environment. Adding the python=2.7solved this for me. Seems more like an issue with anaconda.

RDKit no longer supports Python2.
Please move further questions to the "discussion" tab.

authors: JulianNaumann d-b-w greglandrum rmrmg

repo: rdkit/rdkit


text:
Incorrect InChI generation after applying Chem.RemoveStereochemistry

Describe the bug
Stereochemistry information is retained in some way in the molecule after running Chem.RemoveStereochemistry since InChI outputs stereo related information.
To Reproduce
from rdkit import Chem

molfile = """
     RDKit          2D

 18 19  0  0  0  0  0  0  0  0999 V2000
   15.3270   -1.2375    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   16.1520   -1.2375    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   14.9145   -1.9520    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   16.5645   -0.5231    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   14.0921   -1.9492    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   13.6797   -2.6628    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   14.0922   -3.3784    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   14.9215   -3.3758    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   15.3302   -2.6615    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   17.3902   -0.5258    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   17.8026    0.1878    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   17.3901    0.9033    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   16.5608    0.9007    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   16.1520    0.1865    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
   15.3365   -4.0887    0.0000 O   0  0  0  0  0  0  0  0  0  0  0  0
   12.8547   -2.6625    0.0000 O   0  0  0  0  0  0  0  0  0  0  0  0
   17.8016    1.6184    0.0000 O   0  0  0  0  0  0  0  0  0  0  0  0
   18.6266    1.6195    0.0000 C   0  0  0  0  0  0  0  0  0  0  0  0
  9  3  1  0
  3  5  2  0
  4 10  2  0
  1  3  1  0
 10 11  1  0
  5  6  1  0
 11 12  2  0
  1  2  2  0
 12 13  1  0
  6  7  2  0
 13 14  2  0
 14  4  1  0
  2  4  1  0
  8 15  1  0
  7  8  1  0
  6 16  1  0
 12 17  1  0
  8  9  2  0
 17 18  1  0
M  END
"""

mol = Chem.MolFromMolBlock(molfile)

# remove stereo
Chem.RemoveStereochemistry(mol)

# unexpected final /b3-2+ layer in inchi
print(Chem.MolToInchi(mol))

# But no double stereo bonds found!
for bond in mol.GetBonds():
    bs = bond.GetStereo()
    if bs != Chem.BondStereo.STEREONONE:
        print(bs)

Working as expected if reading from SMILES
ms = Chem.MolFromSmiles("COc1ccc(/C=C/c2cc(O)cc(O)c2)cc1")
print(Chem.MolToInchi(ms))

Chem.RemoveStereochemistry(ms)
print(Chem.MolToInchi(ms))

Expected behavior
InChI not showing stereo related information (/b3-2+ in the example) that was theorically removed with Chem.RemoveStereochemistry
Configuration (please complete the following information):

RDKit version: 2024.03.3
OS: google colab
Are you using conda? Yes
If you are using conda, which channel did you install the rdkit from? conda-forge

Hi @eloyfelix. This is happening because the molecule has coordinates (a conformer) and those coordinates are passed to the InChI code. Double bonds always have stereo if coordinates are present unless you mark them as unknown.
One possible solution is to remove all conformers from the molecule:
In [3]: mol.RemoveAllConformers()

In [4]: print(Chem.MolToInchi(mol))
[16:15:54] WARNING: Omitted undefined stereo

InChI=1S/C15H14O3/c1-18-15-6-4-11(5-7-15)2-3-12-8-13(16)10-14(17)9-12/h2-10,16-17H,1H3

The other option is to explicitly mark all double bonds as being STEREOANY:
In [5]: mol = Chem.MolFromMolBlock(molfile)

In [6]: Chem.RemoveStereochemistry(mol)

In [7]: for bond in mol.GetBonds():
   ...:     if bond.GetBondType() == Chem.BondType.DOUBLE:
   ...:         bond.SetStereo(Chem.BondStereo.STEREOANY)
   ...:

In [8]: print(Chem.MolToInchi(mol))
[16:18:39] WARNING: Omitted undefined stereo

InChI=1S/C15H14O3/c1-18-15-6-4-11(5-7-15)2-3-12-8-13(16)10-14(17)9-12/h2-10,16-17H,1H3

Hi @greglandrum, many thanks for the quick reply and the solution!

authors: eloyfelix greglandrum


text:
styled-components style get overriden

React Boilerplate
Issue Type

[X] Bug (https://github.com/react-boilerplate/react-boilerplate/blob/master/.github/CONTRIBUTING.md#bug-reports)

Description
This bug is similar to #620 but with styled-components. I am loading Bootstrap from the app.js file :
// Import bootstrap style
import 'bootstrap/dist/css/bootstrap.min.css'

// Import CSS reset and Global Styles
import './global-styles';

// Font awesome font icons
import 'font-awesome/css/font-awesome.min.css'

Whatever the order, the <style> tag for Bootstrap is always loaded after the <style> tag for the styled components. As global-styles are concatenated in the same tag, it is loaded before Bootstrap as well.
Thus I can't manage to override Bootstrap (specifities are of course equal) since it is always inserted after.
Versions

React-Boilerplate (see package.json): 3.4.0
Node/NPM: 6.3

I've had similar issues @eric-burel and to summarize, the imported styles are injected into the <head> via webpack + plugins and the ordering cannot be guaranteed, so specificity is going to be your friend :bear:
Please take a look at this issue and let me know if it resolves the issue?
https://github.com/styled-components/styled-components/issues/85

Thanks for the link. I think they closed the issue a bit quickly in the styled-components repo, increasing specificity is a quick (somehow dirty) fix, not a solution.
The issue is that I deliver code to a client: will the next developper know that he must add && {} to every styled components?

Another option would be to import your bootstrap styles in the index.html <head> specifically:
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/latest/css/bootstrap.min.css">
This should help as the styles imported via JS will be placed after the above. Does that work?

Might be related to https://github.com/webpack/webpack/issues/215? Seems impossible to make webpack include css in a specific order. Had the same problem in a project @ work, and ended up "fixing" it by inlcuding reset / bootstrap etc styles directly in the <head> as @samit4me suggested.

@samit4me Yes it does :) , that's quite cleaner than the specificity override.

@GGAlanSmithee Thanks for the link to the source of the issue 👍
@eric-burel I agree, glad it worked 😄
Do you guys think we should add something to the docs regarding this? Maybe on this page?

Definitely. Using a third party css lib is a natural use case, especially for user wanting to work with a boilerplate.
When we start working with styled-components, we naturally expect the same behaviour as inline styles (specificity always maximal), which is not the case. It makes this issue a bit tricky.

@eric-burel I've added a section to the FAQs (see PR above) any feedback would be greatly appreciated. 👍

Closing as problem has been resolved and the updated docs have been merged

authors: GGAlanSmithee eric-burel samit4me

repo: react-boilerplate/react-boilerplate


text:
Quick click, jump many times。。。

Current Behavior

<Button
onPress={() => navigate('Chat', { user: 'Lucy' })}
title="Chat with Lucy"
/>
If you click this button quickly, you will jump over the interface many times.
Expected Behavior

Click on many times, only jump once, follow-up click No effect.
Your Environment

software
version

react-navigation

react-native

node

npm or yarn

This is a repeat of https://github.com/react-community/react-navigation/issues/135. Currently, navigation actions are not idempotent unless they are from a TabNavigator.

I use debounce from lodash as a workaround.

@johnnylc How do you fix this? I can't find where to write the code

authors: CocoaZX Hmily-68 johnnylc matthamil

repo: react-community/react-navigation


text:
Reduce unnecessary re-rendering by injecting a smart shouldComponentUpdate.

Fixes partially #608 (i.e. only for (point 1) described in https://github.com/react-community/react-navigation/issues/608#issuecomment-328635042)
Motivation
This PR reduces unnecessary re-rendering with Stack Navigator by injecting a smart shouldComponentUpdate which judges whether the given scene is active or not.
Please note that I tried to use StaticContainer like https://github.com/react-community/react-navigation/issues/608#issuecomment-328689388, but it cannot prevent from re-rendering child components which refers to state managed by Redux.
Test plan
~I tested this PR in my modified ReduxExample project which has a TextInput component for updating state managed by Redux.~
~I confirmed that only one component was re-rendered when updating state which multiple components refers to by entering texts in the TextInput.~
~If needed, I can share my modified ReduxExample for testing purpose (but its code is a bit dirty).~
Please see https://github.com/react-community/react-navigation/pull/2942#issuecomment-343527899.

@kelset I’d like you to review this PR because it is inspired by your suggestion.

We can probably test this PR using @RoryKelly’s example (https://github.com/react-community/react-navigation/issues/608#issuecomment-343208937).

I've created a test repo: https://github.com/exKAZUu/react-navigation-issues-608 thanks to RoryKelly’s example (https://github.com/react-community/react-navigation/issues/608#issuecomment-343208937).
The test app with this PR shows the following result when pushing the Dispatch button on the screen D:
got action INCREMENT
D Rendered

Also, it seems to keep the current animation behavior.
In contrast, the test app with the current react-navigation shows the following result:
got action INCREMENT
A Rendered
B Rendered
C Rendered
D Rendered

Hey thanks for submitting, I'm not sure this weekend I'll have enough time to review it properly, but I'll take a look asap

Thanks! I intend not to rush you and I just want to contribute.

Btw I'd like to ping @dantman since he proposed a solution for performances here so he may have an opinion on your approach.
Still not sure I've time to properly review today :(

I like dealing with the performance issue by blocking render. However there are some tweaks needed and I'm not quite sure about this exact way of doing it.
First, we don't actually want a sole isActive check. We also may want to render "if prev.isActive != next.isActive" and "if prev.params !== next.params". Allowing a single render when isActive changes gives the component a single render where it knows it has become inactive, this way if the component is really complex it can stop timers or cleanup things temporarily while it is inactive. And if a setParams dispatch is explicitly made (changing params) it's probably a good idea to let that screen render with those new params even if it's not currently visible.
Second, I'm not sure about suddenly exposing screen to components.
Finally, I really don't think this way of hacking shouldComponentUpdate instead of putting it inside of some form of static container is a good idea.

Having react-navigation mutate a component like this feels like a really horrible hack.
This code may not actually work correctly in some situations. Remember that besides React.createClass and ES6 classes, React also supports "Stateless Functional Components" ie: a function that just returns render results instead of being an instanced class. These do not have a Component prototype for you to modify shouldComponentUpdate in a way React will actually use it.
From what I'm reading I believe this code in its current implementation will actually leak memory, slowly degrade performance a bit, and (unless the js engine applies a tail call optimization to the shouldComponentUpdate) eventually crash the app with a stack overflow. Every time render() is called this code saves the current shouldComponentUpdate, creates a new function that wraps and calls it, and replaces the shouldComponentUpdate with it. The second time the SceneView gets a render call (which will be for any navigation state change, not just ones related to this scene), it will do this again, taking the shouldComponentUpdate wrapper it created last render and wrapping it again. And it will keep doing this every single time the navigation state changes making a deeper and deeper stack of wrappers as you navigate the app until either the device's memory or js environment's stack limit is exhausted.

I understand this was done to workaround redux tunnelling through the optimization. Though I'm wary of using this hack even for that. I'll need to know more about how redux is causing this problem (how @connect or props.navigation would do this I'm not entirely certain at the moment). But I'm wary about it because if redux used on the scene view (which is patched with this hack) causes problems that bypass the shouldComponentUpdate optimization, then what about children of that screen route that also might use redux and are not patched.
I think there's probably another solution to the redux issue we haven't thought of yet that will pop up when we investigate what the cause of the redux issue is.

I'm going to close this pull request because @dantman raises many valid concerns. We'll continue to discuss this in https://github.com/react-navigation/react-navigation/issues/608 and hopefully soon that will carry over into a RFC.

@dantman Thank you for giving your valuable review comments!
@brentvatne Sorry for leaving WIP code.
I think my reproduction (but bit old) is still useful for you.
https://github.com/exKAZUu/react-navigation-issues-608
If there is something I can help you, please let me know.

authors: brentvatne dantman exKAZUu kelset


text:
support for maximum, minimum or time ranges?

Do you have any plans to support a maximum or minimum time or maybe a range of available times to select from?

I'd like to have some feature similar to this. I'm looking to only show 15 minute intervals (00, 15, 30, 45) but from what I can tell, this isn't possible.
Thanks for the plugin!

@afc163 Any plans adding this soon? Otherwise I'll create a PR.

Use disabledXxxxx and hideDisabledOptions like antd does: https://ant.design/components/time-picker/#components-time-picker-demo-disable-options

authors: afc163 andyrichardson cshanejennings sveinpg

repo: react-component/time-picker


text:
[Feature]: 翻译 guides/ssr.md

What is the new or updated feature that you are suggesting?
增加中文版
Why should this feature be included?
增加中文版

我翻译guides/ssr.md，时间2021.12.29-2022.01.03

authors: Terence-Cheng ruanye

repo: react-document/reactrouter


text:
bounds don't work with svg element

Hi below is a very simple replication of the use case i am trying to do. I can confirm that bounds work with regular divs, but once i switch the exact same setting to within svg, it doesn't work anymore
using bounds="parent" will error out.
using bounds="#mostouter" wouldn't error out, but feature is ineffective.

export const test = function(){
	return (

			<svg style={{overflow:'visible'}}>
				<Draggable bounds="#mostouter"> //{{right: 300, bottom: 300}} works
					<g>
					<rect
						width={50}
						height={50}
						rx="10"
						ry="10"
						style={{ fill: "rgba(0,0,0,0.5)" }}
					></rect>
					</g>
				</Draggable>

			</svg>

)
}

Don't use it as SVG. Encode SVG and give it as source to an image inside dragable. It will work fine.

repo: react-grid-layout/react-draggable


text:
Why the north and west resizable handles works in reverse?

In the float mode I'm expecting to resize in all direction but when i try to resize left it grows or shrinks from the right side. Same with the north side. I didn't find anything about this in the docs. Should i try to implement custom handles?

+1

Yeah, this surprised me when I first started to use RGL too :) I ended up keeping the default south east handle only, like they do in Kibana

+1 any update?

+1

Interestingly, I think this should be actually solved by this PR https://github.com/react-grid-layout/react-resizable/pull/136.

Not Stale. The same as @qwe12e is happening to me, no resize to left or north directions as expected

Same problem here, any solution?

Any solution?

Why is it closed? Is there a solution?

Looking for solution too... How does it work on the demo page (https://react-grid-layout.github.io/react-grid-layout/examples/0-showcase.html)?

Looking for solution too... How does it work on the demo page (https://react-grid-layout.github.io/react-grid-layout/examples/0-showcase.html)?

@timoisalive , I believe this was fixed in v1.4.0 through this PR

@timoisalive , I believe this was fixed in v1.4.0 through this PR

Indeed it seems to be, thank you @sid2u! 🥳

authors: AntonioGally DominikScholz Foraminiferatrv Ichicoro TanYJie alon24 ddolcimascolo dsalgador qwe12e sid2u timoisalive

repo: react-grid-layout/react-grid-layout


text:
fix: reference the code example to v6 in ApiPageV6

I found that the sample code of reset is misplaced with v7 (keepErrors is v7. In v6 it was called error). Then after tracing the source code, I found that there are lots of code examples in v6 that are referencing v7. This PR aims to reference the correct code examples. Thank you!

thanks, buddy!

repo: react-hook-form/documentation


text:
[General] Cleanup

About
I call this cleanup task, but it's actually a to do that I believe will increase the usability of this repo.
Open for any discussion/proposals. If someone would like to help with anything, feel free to (just post in this issue).
Todo list
Auto-generated documentation

[ ] In progress

I believe simple HTML-from-markdown generator would do the job. We currently have two pages - API and Manual Linking - so GitHub pages should be sufficient to display them as HMTL.
Unit tests for JS interface

[ ] In progress

Test public interface that consumes the native module.
Done:

GitHub template issues
To help maintainers maintain and issuers issue, unified way of communication is the key. I believe a separate template for bugs, feature request, and questions would be helpful here.

Write CONTRIBUTORS guide
A helpful guide for newcomers, willing to help out with Async Storage.

Automatic sematic releases
Automatic, regular, semantic releases with patches/fixes would be useful.

More to come
The list will keep growing over time, so feel free to post your ideas/thoughts.
Thanks!

I've noticed the "Manual Linking" guide is missing info for iOS https://github.com/react-native-community/react-native-async-storage/blob/master/docs/Linking.md

@jcurtis 	Hey,
Would you like to help with that?
I'd love this guide to have some screenshots from manual linking steps, I find those more useful than raw text.
thanks.

@Krizzu I ended up using the steps from the react native docs 👉  https://facebook.github.io/react-native/docs/linking-libraries-ios#manual-linking

Closing this in favor of v2.

authors: Krizzu jcurtis


text:
ECONNRESE: cli process crashes sometimes.

Environment
React Native Environment Info:
System:
OS: Linux 3.10 CentOS Linux 7 (Core)
CPU: (4) x64 AMD Opteron(tm) Processor 6348
Memory: 1.88 GB / 7.64 GB
Shell: 4.2.46 - /bin/bash
Binaries:
Node: 11.6.0 - ~/.nvm/versions/node/v11.6.0/bin/node
npm: 6.5.0-next.0 - ~/.nvm/versions/node/v11.6.0/bin/npm
npmPackages:
react: 16.5.0 => 16.5.0
react-native: https://github.com/expo/react-native/archive/sdk-31.0.0.tar.gz => 0.57.1
Description
Process crashes often with information below:

And the process is:
root     27491  0.3  1.0 938304 84540 ?        Sl   10:43   0:29 /root/.nvm/versions/node/v11.6.0/bin/node /root/pixies/pixies-app/node_modules/react-native/local-cli/cli.js start --port 19001 --customLogReporterPath /root/pixies/pixies-app/node_modules/expo/tools/LogReporter.js --assetExts ttf --reset-cache
See Expo ticket for full details.
Reproducible Demo
expo start a simple project on linux server, and open exp:xxx:19000 on many android/ios devices.

Closing, as reading through the comments in the linked issue it seems like an Expo problem.

authors: EltonZhong thymikee

repo: react-native-community/react-native-cli


text:
Fixed #78 Invalid Icon 'component' propType

I think React Native Components are mostly 'func' type. 'element' type returns true if it is constructed using React.createElement().

@max2three can you link me to any documention that explicilty states this? Thanks.

@Monte9
React.PropTypes.element
React Element
React Component
So, I think validating a component against element type will always gives you a warning as they are not the same.
Correction: Calling createElement() explicitly if you are not using JSX.

Closed this PR as issue #78 is closed.


text:
[Error: INVALID_ACCOUNT]

loginController.js
import React, {Component, Fragment} from 'react';
import {
  SafeAreaView,
  StyleSheet,
  ScrollView,
  View,
  Text,
  StatusBar,
  Button,
  Image,
} from 'react-native';

import {
  Header,
  LearnMoreLinks,
  Colors,
  DebugInstructions,
  ReloadInstructions,
} from 'react-native/Libraries/NewAppScreen';
import {
  GoogleSignin,
  GoogleSigninButton,
  statusCodes,
} from 'react-native-google-signin';
import firebase from 'react-native-firebase';

export default class LoginController extends Component {
  constructor(props) {
    super(props);
    this.state = {
      pushData: [],
      loggedIn: false,
    };
  }
  componentDidMount() {
    GoogleSignin.configure({
      // scopes: ['https://www.googleapis.com/auth/drive.readonly'], // what API you want to access on behalf of the user, default is email and profile
      webClientId:
        '697941268844-b6q8bsct1hjk4qtijjmsrpbkkp91m3io.apps.googleusercontent.com', // client ID of type WEB for your server (needed to verify user ID and offline access)
      offlineAccess: true, // if you want to access Google API on behalf of the user FROM YOUR SERVER
      hostedDomain: '', // specifies a hosted domain restriction
      loginHint: '', // [iOS] The user's ID, or email address, to be prefilled in the authentication UI if possible. [See docs here](https://developers.google.com/identity/sign-in/ios/api/interface_g_i_d_sign_in.html#a0a68c7504c31ab0b728432565f6e33fd)
      forceConsentPrompt: true, // [Android] if you want to show the authorization prompt at each login.
      accountName: 'com.authen', // [Android] specifies an account name on the device that should be used
      // iosClientId: '124018728460-krv1hjdv0mp51pisuc1104q5nfd440ae.apps.googleusercontent.com', // [iOS] optional, if you want to specify the client ID of type iOS (otherwise, it is taken from GoogleService-Info.plist)
    });
  }

  firebaseGoogleLogin = async () => {
    try {
      // add any configuration settings here:
      await GoogleSignin.hasPlayServices();

      const userInfo = await GoogleSignin.signIn();  // some problems with this line

      this.setState({userInfo: userInfo, loggedIn: true});
      console.log('User info: ' + userInfo);
      // create a new firebase credential with the token
      const credential = firebase.auth.GoogleAuthProvider.credential(
        userInfo.idToken,
        userInfo.accessToken,
      );
      // login with credential
      const firebaseUserCredential = await firebase
        .auth()
        .signInWithCredential(credential);

      console.warn(JSON.stringify(firebaseUserCredential.user.toJSON()));
    } catch (error) {
      console.log(error);
      if (error.code === statusCodes.SIGN_IN_CANCELLED) {
        // user cancelled the login flow
        console.log('user cancelled the login flow');
      } else if (error.code === statusCodes.IN_PROGRESS) {
        // operation (f.e. sign in) is in progress already
        console.log('operation (f.e. sign in) is in progress already');
      } else if (error.code === statusCodes.PLAY_SERVICES_NOT_AVAILABLE) {
        // play services not available or outdated
        console.log('play services not available or outdated');
      } else {
        // some other error happened
        console.log('some other error happened');
      }
    }
  };

  signOut = async () => {
    try {
      await GoogleSignin.revokeAccess();
      await GoogleSignin.signOut();
      this.setState({user: null, loggedIn: false}); // Remember to remove the user from your app's state as well
    } catch (error) {
      console.error(error);
    }
  };

  render() {
    return (
      <Fragment>
        <StatusBar barStyle="dark-content" />
        <SafeAreaView>
          <ScrollView
            contentInsetAdjustmentBehavior="automatic"
            style={styles.scrollView}>
            <Header />
            {global.HermesInternal == null ? null : (
              <View style={styles.engine}>
                <Text style={styles.footer}>Engine: Hermes</Text>
              </View>
            )}
            <View style={styles.body}>
              <View style={styles.sectionContainer}>
                <GoogleSigninButton
                  style={{width: 192, height: 48}}
                  size={GoogleSigninButton.Size.Wide}
                  color={GoogleSigninButton.Color.Dark}
                  onPress={this.firebaseGoogleLogin}
                  disabled={this.state.isSigninInProgress}
                />
              </View>
              <View style={styles.buttonContainer}>
                {!this.state.loggedIn && (
                  <Text>You are currently logged out</Text>
                )}
                {this.state.loggedIn && (
                  <Button
                    onPress={this.signOut}
                    title="Signout"
                    color="#841584"></Button>
                )}
              </View>

              {!this.state.loggedIn && <LearnMoreLinks />}
              {this.state.loggedIn && (
                <View>
                  <View style={styles.listHeader}>
                    <Text>User Info</Text>
                  </View>
                  <View style={styles.dp}>
                    <Image
                      style={{width: 100, height: 100}}
                      source={{
                        uri:
                          this.state.userInfo &&
                          this.state.userInfo.user &&
                          this.state.userInfo.user.photo,
                      }}
                    />
                  </View>
                  <View style={styles.detailContainer}>
                    <Text style={styles.title}>Name</Text>
                    <Text style={styles.message}>
                      {this.state.userInfo &&
                        this.state.userInfo.user &&
                        this.state.userInfo.user.name}
                    </Text>
                  </View>
                  <View style={styles.detailContainer}>
                    <Text style={styles.title}>Email</Text>
                    <Text style={styles.message}>
                      {this.state.userInfo &&
                        this.state.userInfo.user &&
                        this.state.userInfo.user.email}
                    </Text>
                  </View>
                  <View style={styles.detailContainer}>
                    <Text style={styles.title}>ID</Text>
                    <Text style={styles.message}>
                      {this.state.userInfo &&
                        this.state.userInfo.user &&
                        this.state.userInfo.user.id}
                    </Text>
                  </View>
                </View>
              )}
            </View>
          </ScrollView>
        </SafeAreaView>
      </Fragment>
    );
  }
}

const styles = StyleSheet.create({
  ...
});

App.js:

import LoginController from './loginController';

const App = () => {
  return <LoginController />;
};

export default App;

When ever it runs to const userInfo = await GoogleSignin.signIn(); // some problems with this code the error will be reproduced
Environment
Platform: Android (did not set up ios)
"dependencies": {
"react": "16.9.0",
"react-native": "0.61.4",
"react-native-firebase": "^5.5.6",
"react-native-google-signin": "^2.1.0"
},

from debugger:
Error: INVALID_ACCOUNT
at Object.fn [as signIn] (NativeModules.js:99)
at GoogleSignin.signIn$ (GoogleSignin.js:20)
at tryCatch (runtime.js:45)
at Generator.invoke [as _invoke] (runtime.js:271)
at Generator.prototype. [as next] (runtime.js:97)
at tryCatch (runtime.js:45)
at invoke (runtime.js:135)
at runtime.js:145
at tryCallOne (core.js:37)
at core.js:123

Did you figure it out? I'm having the same problem.

Did you figure it out? I'm having the same problem.

try to comment 'accountName' and try again, it is possible you are using it wrong

authors: johnnyhoichuen odradek123 valeriik


text:
Offline is always repoted as "unknown" instead of "none" ?

Platforms
Android
Versions

Android: 8.1 (Motorola G5), 9 (Pixel 2)
react-native-netinfo: 2.0.0
react-native: 0.59.4
react: 16.8.6

Description
Calling NetInfo.getConnectionInfo() always returns type "unknown" when wifi is turned off, and cellular data is turned off.
One would expect that "none" is returned instead. Right now, it is impossible to tell the difference between actually being offline, or not being able to tell the network status at all.
Since network info can be sometimes be unreliable (such as when called in background #64 ), being able to tell the difference between unknown and none is actually very important, since you can then implement different behaviors for each case.

👋 This was fixed in 2.0.5. Upgrade and let me know if that resolves the issue.
https://github.com/react-native-community/react-native-netinfo/releases/tag/v2.0.5

Using 2.0.5 it is still being reported as unknown on both Motorola G5 (Android 8.1) and Google Pixel 2 (Android 9).
This happens when the device has wifi turned off, and no mobile data (no sim card at all actually)

👍 I have a Pixel 2, so I'll test this myself when I get the chance.

@cristianoccazinsp I've created a fix in PR #96.

Amazing, will keep an eye and test it once it gets merged. Thank you!.


text:
FlexBox issues?

Apologies, I'm new to React Native so this maybe a really stupid problem. I'm getting "Adjacent JSX elements must be wrapped in an enclosing tag" errors
Here's my code:
const SideMenu = require('react-native-side-menu');

class ContentView extends React.Component {
  render() {
    return (
      <View style={styles.container}>
        <Text style={styles.welcome}>
          Welcome to React Native!
        </Text>
        <Text style={styles.instructions}>
          To get started, edit index.ios.js
        </Text>
        <Text style={styles.instructions}>
          Press Cmd+R to reload,{'\n'}
          Cmd+Control+Z for dev menu
        </Text>
      </View>
    );
  }
}

class Test extends Component {
  render() {
    const menu = <Menu navigator={navigator}/>;
    return (
      <SideMenu menu={menu}>
        <ContentView/>
      </SideMenu>

      <View style={styles.container}>

        <View style={styles.navBar}>
          <Text style={styles.navBarButton}>Back</Text>
          <Text style={styles.navBarHeader}>Awesome App</Text>
          <Text style={styles.navBarButton}>More</Text>
        </View>
        <View style={styles.content}>
          <Text style={styles.text}>
            Welcome to Awesome App!
          </Text>
        </View>
        <View style={styles.tabBar}>
          <View style={[styles.tabBarButton, styles.button1]} />
          <View style={[styles.tabBarButton, styles.button2]} />
          <View style={[styles.tabBarButton, styles.button3]} />
          <View style={[styles.tabBarButton, styles.button4]} />
          <View style={[styles.tabBarButton, styles.button5]} />
        </View>
      </View>
    );
  }
}

Hi @patrickchoi!
<SideMenu> and <View> should have a common parent. Wrap your render content into <View>, so it'll look like this:
render() {
  return (
    <View>
      <SideMenu />
      <View>...</View>
    </View>
  );
}

Thanks! That seemed to got past it. But now I'm getting this:

Unfortunately, I don't know anything about LearningFlexbox component. Please, check appropriate repository (or your code if it isn't a third-party dependency).
On a side note: I'm trying to keep issues in this repo related to the project itself. If you have generic React/RN questions, you may ask them on StackOverflow or ping me on Twitter (@kureevalexey). If I have time, I will try to help you :)
Best of luck!

authors: Kureev patrickchoi


text:
swipe enabled ={true} not swipe between tabs

Current behaviour
I set swipeEnabled to true and when I try to swipe between tabs, nothing happened
Expected behaviour
to swipe between tabs (without press on tab bar buttons)
Code sample
  _handleIndexChange = index =>
    this.setState({
      index,
    });

  renderLabel = ({ route, focused, color }) => {
    console.log('route', route, focused, color)
    return (
      <View style={style.view_label}>
        <Text
          style={[
            style.tab_label_text,
            focused ? style.selected_tab_label : {}
          ]}
        >
          {route.title}
        </Text>
      </View>
    )
  }

  _renderTabBar = props => (
    <TabBar
      {...props}
      renderLabel={this.renderLabel}
      activeColor={Colors.pink}
      inactiveColor={Colors.black}
      indicatorStyle={style.indicator_tab}
      style={style.content_tabs}
      tabStyle={style.tab_style}
    />
  );

  _renderScene = SceneMap({
    contacts: FirstRoute,
    albums: SecondRoute,
  });

 <TabView
          style={this.props.style}
          navigationState={this.state}
          renderScene={this._renderScene}
          renderTabBar={this._renderTabBar}
          tabBarPosition="top"
          onIndexChange={this._handleIndexChange}
          swipeEnabled={true}

        />

Your Environment

software
version

ios or android
android

react-native
0.57.8

react-native-tab-view
^2.0.0-alpha.5

react-native-gesture-handler
^1.0.12

react-native-reanimated
^1.0.0-alpha.12

node
v9.10.0

npm or yarn
yarn

Did you finish the additional steps for linking gesture handler as mentioned here? https://github.com/react-native-community/react-native-tab-view#installation

@satya164  sorry, I didn't see. after follow these steps, it's working. thanks


text:
react-native run-android, error: react-native-video:prepareReleaseDependencies

After I install, run the error.  “Execution failed for task ':react-native-video:prepareReleaseDependencies'.”  Who can help me?

Take a look at the proposed fix in #914 and reopen if that doesn't fix it.


text:
Not work with RN 0.56.0

A problem occurred configuring project ':app'.

Could not resolve all dependencies for configuration ':app:_debugApk'.
A problem occurred configuring project ':react-native-smart-splashscreen'.
The SDK Build Tools revision (23.0.3) is too low for project ':react-native-smart-splashscreen'. Minimum required is 25.0.0

PR https://github.com/react-native-component/react-native-smart-splash-screen/pull/35 fixes this issue, but like many other PRs they haven't been merged. You can either fork it or check other forks that have updated versions.

authors: billel-boudchicha webraptor


text:
Crash: HostObject::get(propName:RNDeviceInfo)

Bug

When upgrading this project from v3.1.4 -> current 4.0.1, we have noticed an issue with the app crashing almost immediately on launch, citing a HostObject::get(propName:RNDeviceInfo) fatal error (that doesn't seem to give much more info than what's shown in this screenshot).

Numerous other references to this same obscure error seem to mention the possibility of nil return values in the NSDictionary that is returned over the bridge via the constantsToExport  function.
I have narrowed this particular instance of the error down to the call of [self getAppName] in  RNDeviceInfo.m here. Commenting out that line seems to resolve the crash.
Digging deeper, it looks like the implementation of that function retrieves CFBundleDisplayName which can be nil and get us into the state described above (indeed, this was exactly what was going on in our project).
According to Apple Docs, it looks like CFBundleDisplayName is now marked as 'required' and the older CFBundleName is 'recommended' despite there not being any enforcement of that rule (to date?) and despite conflicting info on this page (conversely saying it is 'recommended' for ios).
For good measure I will implement CFBundleDisplayName in our app to get around this, but thought I would suggest these fixes to resolve the issue for anyone who may be in a similar scenario (upgrading an older project to newer RN + newer library versions):

Update the getAppName function to grab the value of CFBundleName as a fallback to CFBundleDisplayName, since that can be nil (as other repos do)
OR Return an empty string that does not cause this nil issue (and therefore have no fallback, if that's not desired)

Environment info

React native info output:
System:
    OS: macOS Mojave 10.14.5
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
    Memory: 1.59 GB / 32.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 10.15.3 - ~/.nvm/versions/node/v10.15.3/bin/node
    Yarn: 1.15.2 - ~/.nvm/versions/node/v10.15.3/bin/yarn
    npm: 6.11.1 - ~/.nvm/versions/node/v10.15.3/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.1, DriverKit 19.0, macOS 10.15, tvOS 13.0, watchOS 6.0
  IDEs:
    Xcode: 11.1/11A1027 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: 0.61.2 => 0.61.2
  npmGlobalPackages:
    react-native-clean-project: 3.2.4
    react-native-cli: 2.0.1
    react-native: 0.60.5

Library version: 4.0.1
Steps To Reproduce

Run an app that includes this repo but does not include the CFBundleDisplayName key in it's info.plist file.
Notice that the app crashes almost immediately with the obscure HostObject::get(propName:RNDeviceInfo) error
Modify return values of getAppName to prove the concept

Describe what you expected to happen:

Out of the box, the app should run normally and not crash before making any calls to DeviceInfo functions.

Reproducible sample code
Using the example project in this repo, remove CFBundleDisplayName

This is fantastic sleuthing @renatoniro - thanks for opening an issue on it with the details all included. I'll see if I can get a patch release out quickly, in the meantime feel free to use patch-package to make a quick patch in node_modules (with patch-package persisting it across all your team / installs) that alters https://github.com/react-native-community/react-native-device-info/blob/643577cfadd92b9577b68ff2906af931ae81689b/ios/RNDeviceInfo/RNDeviceInfo.m#L142 to use CFBundleName to get you moving - that'd be the work of maybe 10 minutes
The real fix will probably be a CFBundleDisplayName attempt with fallback to CFBundleName but that's a few more minutes work of course (unless you want to make a PR, then I'm sure it'll just be 2 minutes, no more ;-) )

This will be out in v5 in a moment - packing everything up now for a release

@mikehardy sorry to bring this dinosaur up, but can you tell me exactly what was the patch/fix?
We are seeing a similar issue in this library and I wonder if it is the same bug: https://github.com/RonRadtke/react-native-blob-util/issues/34

It's okay, it actually rhymed with something else from react-native-firebase. Check this out - getExternalFilesDir may be null, and that might be your crash https://github.com/invertase/react-native-firebase/pull/5118/files
god luck!

Just saw you were in Uruguay! Que bien! Bienvenidos desde Ecuador :), Quiero viajar alla - pero en esta epoca no es posible cierto? Cuidate

Thanks!
Borders are closed but under special circumstances you may be able to come.
Skilled people is always welcome :)
El sáb., 15 de may. de 2021 11:48, Mike Hardy @.***>
escribió:

Just saw you were in Uruguay! Que bien! Bienvenidos desde Ecuador :),
Quiero viajar alla - pero en esta epoca no es posible cierto? Cuidate
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/react-native-device-info/react-native-device-info/issues/846#issuecomment-841670031,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALU263EO6JVVDFLMTNNHOQTTN2CUNANCNFSM4JBDPSSQ
.

For me, it happened because of using the wrong variable name in the "Info.plist" file.

authors: cristianoccazinsp mikehardy renatoniro tgvishal


text:
[iOS] playback-metadata-received support

This pr extends support for the playback-metadata-received event to iOS. Note that the source property of this event is currently not yet aligned with that of the Android version. More discussion on this here: https://github.com/react-native-kit/react-native-track-player/issues/933

this pull request is now ready for review

Is there any update on this? Would be great to have the metadata available on iOS

@curiousdustin Any reason this isn't merged yet? Would like to help.

@dylancom (hoi) would you like to give it a final test? then I will merge it

@puckey (hallo) just gave it a test and it works great!

Hey @puckey! Are there any blockers preventing merging?
Also, thank you so much for this PR. I have been wanting this feature for a long time 😄

@puckey could you merge it? :)

@puckey currently working on a new app for my company and having this would allow us to get over a big hurdle. Any update on merging this?

@puckey thank you so much for this! I've added your support for metadata directly into the SwiftAudio fork: https://github.com/DoubleSymmetry/SwiftAudio/commit/7370ad05e6e2522b8f836c9559a41b7d7046f154
and ported the rest of your changes into the branch for /v2 as that's where the Android additions are in: https://github.com/DoubleSymmetry/react-native-track-player/pull/1175

authors: CharlesCarey dcvz dylancom lostchopstik puckey


text:
Sound from video link does not play on iOS

Bug
I to try android it working, but when  to try it not working IOS, can you tell me know why IOS not play sound. Please.

Platform

Which player are you experiencing the problem on:

iOS
Android ExoPlayer
Android MediaPlayer
Windows UWP
Windows WPF

Environment info

React native info output:
 // paste it here

Library version: x.x.x
Steps To Reproduce

Link video: https://kidbox.vn/media/2021/4/6/akidbox-video0-1617691890_1617691892821.mp4
Sound not play
...

Expected behaviour

Reproducible sample code

Video sample
If possible, include a link to the video that has the problem that can be streamed or downloaded from.

I have the same bug, ios 14, react-native 0.64, react-native-video 5.1.1

I have a similar problem, in my case, I set Uri in source but it doesn't display the video... :/ any idea?
"react-native-video": "^5.1.1"
"react-native": "0.63.4",

I already have the answer, my problem was that I tried display a video from youtube but react-native-video support generally .mp4, so I will use react-native-youtube-iframe or react-native-webview. good day :D
More info: https://stackoverflow.com/questions/57413156/play-youtube-video-in-react-native-video

I have a similar problem, in my case, I set Uri in source but it doesn't display the video... :/ any idea?
react-native-video: 5.1.1
react-native: 0.63.4
@khuongsatou in IOS, you just installed the library? or configure anything more?

I found the reason that the video link opened by safari didn't play the sound, so I asked the "team backend" to decode the link and play the video on safari it also worked with react webview.

Hey I'm having this video https://stream.mux.com/fHTBBwJGJT44eTVqHhp6zp1htrGmmZ99dzAI01aySibU.m3u8 which shows OK in no time but without any sound, I tested on safari and VLC and audio is there.
This is happening on iOS, "react-native": "0.64.3", "react-native-video": "^5.2.0",

@ghacosta I was having the same issue. I noticed in the issuer's screenshot he's using an ignoreSilentSwitch='ignore' prop. That worked for me, might wanna give it a shot.

authors: amie-wilt ghacosta iljaiwjew khuongsatou ssancheza227

repo: react-native-video/react-native-video


text:
External links for sharing the website does not open

Bug description:
Hi there. I have added a website (https://www.roomvo.com/my/vekoal/rooms/615c4480f40c40c4ba624a8c2f2f3f23) inside react-native-webview that it is developed with Next.js. On this website are two buttons on the right menu drawer that shares on Facebook and Whatsapp by opening new tabs, but non of them is working inside react-native-webview. I hate tried to add some props that I think will help me but no success. Can anyone help me with this, please?
p.s
It has another problem with the download button. It crashes the app because is using data:base64 but I will open a new issue for that.
To Reproduce:
import React from 'react';
import { WebView } from 'react-native-webview';

const HomeScreen = props => {
  return (
    <WebView source={{ uri: 'https://www.roomvo.com/my/vekoal/rooms/615c4480f40c40c4ba624a8c2f2f3f23' }} />
  );
};

export default HomeScreen;

Expected behavior:
I expect to open a new tab external on phone default browser.
Environment:

OS: Android
OS version: 9.0
Expo version: 4.1.0
Expo SDK version: 40.0.0
react-native version: 0.63
react-native-webview version: 11.0.0

@daniel1up have you fixed it?


text:
history.replaceState pushes to history stack instead of replacing

Bug description:
The history.replaceState method should replace the current position in the history stack without reloading the page.  Instead, it pushes a new entry to the stack.
Example:
Initial history state:    ["/", "/foo"]
Expected result after replaceState:  ["/", "/bar"]
Actual result after replaceState:   ["/", "/foo", "/bar"]
To Reproduce:
Inside webview, run the following:

window.history.pushState(null, null, "/page1")
window.history.pushState(null, null, "/page2")
window.history.replaceState(null, null, "/page3")
window.history.back() should return to /page2

Expected behavior:
It should replace the current history position with the new url
In the above example, it should return to /page1
Environment:

OS: iOS & Android
OS version: iOS 14.4
react-native version: ^0.63.4
react-native-webview version: ^11.6.4

same issue

authors: doylio yorickshan


text:
When native postMessage to web, method of iOS and android is unmatched

Bug description:

When calling webView.postMessage(), the dispatchEvent method of iOS and android is differnt as below.
android: document.dispatchEvent(event)
https://github.com/react-native-webview/react-native-webview/blob/6b8e4f3f5f3cc006ebca8cb3c7ab692805824685/android/src/main/java/com/reactnativecommunity/webview/RNCWebViewManager.java#L758
iOS: window.dispatchEvent(event)
https://github.com/react-native-webview/react-native-webview/blob/a68df8526527a8fa5a21f62eea1d60e956a833db/apple/RNCWebView.m#L909
As a result, developer need to addEventListener on both of document and window target which is redundant
docuemt.addEventListener('message', cb)
window.addEventListener('window', cb)

So, is it right to modify android file to change document into window?

https://github.com/react-native-webview/react-native-webview/issues/356#issuecomment-1290912572

authors: tkmin zerosrat


text:
Adding a tabindex to the input component

When laying out a form, it's important to be able to control the order of the user's tabs. So, I added that as an optional prop that can be passed.

Hi! Sorry for answering this late, the code looks good, but the tests are failing

authors: rubenmoya thatgibbyguy

repo: react-toolbox/react-toolbox


text:
[Table] enhancements

allow usage of react components in table cells (header and rows): https://github.com/react-toolbox/react-toolbox/issues/268
allow changing table header titles (via title prop in model): https://github.com/react-toolbox/react-toolbox/issues/296
allow specifying onChange handler per column (via model) in order to make only certain columns editable instead of the whole table

Sample usage can be seen in the update Table test file.

Let me check it this afternoon :) Great work

Nice one! Allowing to pass ReactComponents for fields and headers makes total sense.
As we go that way, wouldn't' make sense also deprecate the magic around auto-editable fields?
now, we can pass custom components. Why not let those components to be bound to onChange events, or onclick, or whatever. The table is supposed to display in a tabl-y way. All the other behaviour should be on each passed component. We can pass now any Input, Autocomplete, select, etc.
Anyways, if you don't want to deprecate that behavior (for BC), I don't think that adding the onChange by column is necessary anymore, for the same points stated above.
What do you think?

I agree with @epilgrim that the cell content should be responsible for doing the proper onChange handling.
But I wanted to make as little changes as possible to achieve all 3 goals listed above without introducing breaking changes to existing code.

Very useful, thanks!

authors: Kosta-Github epilgrim javivelasco


text:
Error in onSubmit

Hi, in my code i get this error:

My code:
<Form onSubmit={(val, e) => {
    e.preventDefault();
     console.log(val);
 }}>
  {formApi => (
     <form onSubmit={formApi.submitForm}>
        ....

How to fix it? Thanks.

Im solved with (move e.preventDefault to second form)
<Form onSubmit={(val) => {
       console.log(val);
 }}>
       {formApi => (
             <form onSubmit={(e) => {
                  e.preventDefault();
                  return formApi.submitForm(e);
        }}>

Im solved with (move e.preventDefault to second form)
<Form onSubmit={(val) => {
     console.log(val);
}}>
   {formApi => (
            <form onSubmit={(e) => {
                  e.preventDefault();
                return formApi.submitForm(e);
   }}>

repo: react-tools/react-form


text:
getProps throws row not defined error

React table version @6.7.6
This issue comes only when the rows in the data are less than the pagesize in the react table. I have also tested it on the sandbox:
https://codesandbox.io/s/zw7lnqj19m
Above the data is only 5 rows and the pagesize is 10. So error occurs.

Well I got a workaround to get rid of it eventually:
https://codesandbox.io/s/wol7jrv30l

Just use:
minRows={0}

This feature/issue has been tagged as one that will likely be fixed or improved in the next major release of React-Table. This release is expected to be completed in the next 6 - 8 months. Please see #1143 for more detail. If you believe this feature can be easily fixed, we invite you to fork the project, attempt the fix, and use it until the latest version is available. If the fix is simple enough, we will also consider it as a PR to the current version.

authors: matiosfree rajmiglani tannerlinsley

repo: react-tools/react-table


text:
Events App

Name your screen design
Events App
Share the design source / link
https://dribbble.com/shots/6331112-Events

@miinos nice animations & micro interactions, this one can take a longer time to develop.

Wow, superb design!

authors: NelsonPRSousa hetmann miinos


text:
[BUG] Can't handle generic base classes

Describe the bug

Pharmasist does not pick up events contained in a base class with generics.
public class TabbedPage : MultiPage, IBarElement, IElementConfiguration
Steps To Reproduce

Add pharmacist to your Xamarin Forms project.
Try to access observables from events generated from a page with generics.
public class TabbedPage : MultiPage, IBarElement, IElementConfiguration
Events like CurrentPageChanged is not generated.
Environment
Xamarin Forms 4.3

See https://www.nuget.org/packages/ReactiveMarbles.ObservableEvents.SourceGenerator/ and https://github.com/reactivemarbles/ObservableEventsSourceGenerator
This will handle generic base classes I believe.

authors: glennawatson modplug

repo: reactiveui/Pharmacist


text:
[WIP] feature: bring reactiveui.fody into the main project

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
@kswoll has been doing a stunning job over the last couple years maintaining his addin. I think it's high time to in-line his work and make it official. We had conversations back in May - this PR just makes it official and does the needed to make it happen.
What is the new behavior (if this is a feature change)?
We are in-lining https://github.com/kswoll/ReactiveUI.Fody and making it an official thing.  Kirk Woll will get commit bit access to the reactiveui/reactiveui repository as a contributor/maintainer so that he can still work autonomously but over time the core team will also increase their knowledge of things they maintain to include fody.
What might this PR break?
Nothing
Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
We need @kswoll to be the person that presses the merge button.

@ghuntley,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Hello all!  Catching up on this, but excited to see this all get merged.  Currently ReactiveUI.Fody is using AppVeyor to build and publish to Nuget.  How do you see this happening going forward?  What is the best strategy?  Will this get incorporated into the regular ReactiveUI build process?  Should I add one or more people as owners to the nuget package?

Okay so @kirkplangrid you'll no-longer be a single person maintaining this, the software and yourself will inherit a team of maintainers. Yay. Additionally you'll no longer need to run your own CI pipeline or any of that awesome stuff that often ends up being a timesuck from doing software development. The biggest change will be that Fody's version number will match the ReactiveUI version number and will be pinned to only work with that particular release (this is a very good thing!)
I need you to add add the NuGet.org users "@ghuntley" and "@reactiveui" as owners to the NuGet package. Thx 👍

Wooot - thank-you. Can confirm that NuGet is setup appropriately.  Need to clean up the PR a little bit and tweak build.cake then we can ship v8 compatible version.

@kswoll A label has been created especially for reactiveui-fody

You now have maintainer access to do things like merge pull-requests, triage labels etc. Please drop on by Slack and speak with myself before doing your first couple of PRs and I'll show you the ropes. For example GitHub issues are automatically closed after 67 of inactivity unless the maintainer tags the issue with an exemption. https://github.com/reactiveui/ReactiveUI/blob/develop/.github/stale.yml#L8
A PR has been sent over back upstream to your repository that directs people to this discussion and informs them that the project has moved.
https://github.com/kswoll/ReactiveUI.Fody/pull/51

Coverage remained the same at 69.487% when pulling 8a626749feddc321e6cdd8677f3d897193af704b on fody into 08d9e58425174cedcbb9073ae0d8fd2b7c2cea7a on develop.

Anything blocking this pull request. I've just discovered that my upgrade to ReactiveUI.Fody to support 8.0 doesn't actually work.

Are there any workarounds for this atm? I'm trying to update another nuget package that has a dependency on 8.0.

@ghuntley,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

This PR is open for further work. @worldbeater could you please take it over and finish it up?

Ok, I'll dive into it! Will need some time c:

I think the only thing remaining here is to fix the versioning and the NuGet package format. I'm pretty sure the netstandard ReactiveUI.Fody.dll should be in the package root for Fody to actually pick it up. Because of this, I also think netstandard is the only TargetFramework required for the ReactiveUI.Fody project. Additionally, ReactiveUI.Fody should probably have a dependency on ReactiveUI.Fody.Helpers since it won't work without it.
I know how to fix the versioning and add the reference, but I'm not familiar enough with the new csproj/NuGet to know how to drop the files in the root of the package instead of the lib folder. This is how the current ReactiveUI.Fody package looks:

How can I help?

I think the only part remaining is updating the docs to add Fody

When and how can we use this?
Today, I added Fody package, added  in FodyWeavers.xml and it cannot find the weaver. Is this how this will work?
Cannot wait till it's done

@qrzychu This was released a couple months ago. You need to reference the newer ReactiveUI.Fody package and add <ReactiveUI /> to FodyWeavers.xml. If you have problems, please turn to StackOverflow or create a new issue with more details. This is already confirmed working by many people.

authors: bradphelan coveralls dnfclas ghuntley gtbuchanan kswoll qrzychu vatsalyagoel wmcainsh worldbeater

repo: reactiveui/ReactiveUI


text:
Spanish translation of faq-functions

References to #4
@dmoralesm , @carburo  and @alejandronanez

Hey @florenciasilva, welcome to the project!!! Is this ready for another review?
Thanks!

Hey @florenciasilva, welcome to the project!!! Is this ready for another review?
Thanks!

Hey! I just committed all the changes, so it should be ready for a review!

Thank you! I'm merging it then.

authors: alejandronanez carburo florenciasilva


text:
Translation for Hello World

Bonsoir,
Hop à mon tour :)

Salut @setheal j'ai quelques retours pas encore traités sur ta PR, tu peux rejeter un œil ?

Salut @tdd normalement c'est réglé :)

authors: setheal tdd


text:
Translate managing-state

Translate Managing State page

Hello! Any updates? :)


text:
Add support for DocSearch

Congrats on almost finishing the core Mongolian translation! One of the final steps is to change the DocSearch API key. One of the maintainers needs to sign up for DocSearch in order to do this.

Thanks, ok understood.

authors: Zorig tesseralis


text:
JSX in depth PL translation

Było kilka wątpliwości, przeczytajcie i sprawdźcie proszę czy jest ok :)

@stepek Fajnie, że wpadłeś :-) Nie chciałoby Ci się czegoś przetłumaczyć?

Spoko coś wezmę ;)

Ok widzę już skąd tutaj zamieszanie, chciałem zastosować tylko część zmian z poziomu interfejsu github'a, a resztę wprowadzić i wypchnąć w drugim kroku. Natomiast github po commicie ze zmianami z inferfejsu przedawnił wszystkie wątki. Poprawię resztę na dniach

@stepek Chciałbyś coś jeszcze dodać? Czy mergujemy?

authors: PanFrontend jakubdrozdek stepek


text:
Add onBlur property

would be nice to have ability to track focus lost event

You can provide event handlers in props.inputProps. Example:
<Autocomplete
  inputProps={{ onBlur () { console.log('blur') } }}
/>

@CMTegner how to add ref to input so I can control focus?

There's currently no official way of doing it, but you can get to the input element if you add a ref on Autocomplete:
class MyComponent extends Component {
  handleButtonClick () {
    this.input.focus()
  }
  render () {
    return (
      <div>
        <Autocomplete ref={ac => this.input = ac.refs.input } />
        <button onClick={this.handleButtonClick.bind(this)}>Focus input</button>
      </div>
    )
  }
}

Keep in mind that this is unsupported, so use it at your own risk. v2 will include an imperative API so you can access the common HTMLInputElement methods directly from Autocomplete.

Version 1.5.0 has focus, blur, setSelectionRange, and a few other methods you are used to seeing on <input> elements. Check the documentation for an example.

authors: CMTegner vorlov

repo: reactjs/react-autocomplete


text:
In addition to the specify by 'mapStateToProps', others actions will re-render component

For performance reasons, i use reselect.
There is a very serious problem for me.

The highlight log info is trigger by my component render is invoked.
When page initial work done, the component re-render 19 times...
And there are my code:
let mapToState = createSelector(
  [ (state, props)=> state.get(props.storeKey),
    (state, props)=> state.getIn([props.storeKey, 'meta']),
    (state, props)=> state.get(props.loadingKey || 'isLoading'),
    (state,props)=> props
  ],

  (source, meta, isLoading,props)=> {
    let res = {
      source: props.data(source.toJS()),
      meta: meta.toJS(),
      isLoading
    }
    return res
  }
)

export default connect(mapToState)(ReduxListView)

In addition to reducer handle user or guestModeInfo data, others reducer handle will re-render component...
For example,
There are 5 action,
UPDATE_USER
UDATE_GUESTMODEINFO
UPDATE_PROJECT
CREATE_MESSAGE
DO_SOMETHINGELSE

When reducer UPDATE_PROJECT CREATE_MESSAGE DO_SOMETHINGELSE be fired, the component will re-render.
But UPDATE_USER UDATE_GUESTMODEINFO reducer will be cached by reselect...

@jimbolla Thanks your answer!! In this component , your way is worked! But the most serious problem is on ReduxListView component, i change this issue , the example code is the selector of ReduxListView component.

This is a usage question, not a bug report. Please ask this on Stack Overflow. You'll have more people viewing the problem and will get better answers as a result.

repo: reactjs/react-redux


text:
API feature: dynamically-built list of links

Currently, to build a list of links dynamically based on what is specified in the routes requires something like this:
https://gist.github.com/debugwand/d13ded09fabb2ef2ff4d
This relies on examining this.props.routes[0].childRoutes, assuming your routes are nested correctly, which looks like something not supposed to be interrogated.
An API method such as getNestedRoutes()or getRoutes() that returns an array of Router objects would be useful if this part of the object is not supposed to be looked at.  Alternatively a component that produces a collection of links could be useful.
The use-case for me is creating a style-guide that consists of many pages, this could also be useful for the huge app example.

This doesn't belong in core. Among other things, the semantics aren't clear in the case of async routes anyway. You have to do this yourself; if you find a common use-case, make an addon library.

authors: debugwand taion

repo: reactjs/react-router


text:
The 'const [title, setTitle] = useState('');' at the beginning of the TravelPlan component is redundant

Challenge 2 of 4: Fix a broken packing list at the choosing-the-state-structure page, the const [title, setTitle] = useState(''); at the beginning of the TravelPlan component is redundant

Would you like to send a PR to remove it?

@harish-sethuraman done

authors: CassieRan harish-sethuraman


text:
Be more precise about when false will stop default behaviour in an event handler.

The example shows an attached function in React, however doing the same in plain HTML event handler as a function with returning false would simply have no effect.

Amends wording to me more exact.
Attaches an external link to help understand the topic for one in need.

Would it be worth differentiating between event.preventDefault() and event.stopPropagation()?

On the Synthetic Events page stopPrpagation is mentioned in the 1st note anyway.
I think this topic should be mentioned here, because an inline handler is in the plain HTML and the React example uses a callback. And when you use a plain HTML callback it behaves differently. Also nice for people coming from jQuery.
How would you differentiate preventDefault and stopPropagation?

But if you thought about clarifying the difference between the 2 methods, Event Order article also mentioned on MDN is a nice starting point.

authors: alexkrolick sinkaszab


text:
Update tools-misc.md

Add packtracker.io to the tools section.

We've removed this page.

authors: gaearon jondavidjohn


text:
createSelector w/o dependencies

It's really minor - we've got the following code in our project:
export const selectAllByConnections = createSelector(
    state => state, //reselect's createSelector always needs a dependency
    state => state
        .get('connections')
        .map(connection => allByConnection(connection)(state))
);

I can't move the state.get('connections') to a different selector as i require the full state for the core selection task.

There is no need for a selector in this case, just use the bare function. createSelector creates a selector that memoizes on its arguments, so using createSelector without dependencies is essentially a no-op.

repo: reactjs/reselect


text:
Translate Forms to Thai

Translate Forms Page, รบกวนรีวิวด้วยครับ

เยียมเลยครับผม

authors: iphayao svnnynior


text:
🛑 Bellshade Website is down

In 9cf59fe, Bellshade Website (https://bellshade.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Bellshade Website is back up in c1012c1 after 11 minutes.


text:
🛑 Bellshade Website is down

In b63d81d, Bellshade Website (https://bellshade.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Bellshade Website is back up in 188f3a7 after 12 minutes.


text:
multiselect-component fix

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description
I have tried to  fix the type errors in multiselect-component  play
Type of change

[✅] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
tested by me in my local system.
Checklist:

[ ✅] I have performed a self-review of my own code
[ ✅] I have commented my code, particularly in hard-to-understand areas
[ ✅] I have made corresponding changes to the documentation
[ ✅] My changes generate no new warnings
[ ✅] I have added tests that prove my fix is effective or that my feature works
[✅ ] New and existing unit tests pass locally with my changes
[ ✅] Any dependent changes have been merged and published in downstream modules

Screenshots or example output

@yung-coder Which issue this PR for?

Actually it's linked to  plays folder cleanup issue specifically multi select-comp.

Updated @atapas can you please give it a look.

@yung-coder please pull, clean up node-Modules, do yarn and yarn start to test your changes are working fine...
then push and let me know.

@yung-coder please pull, clean up node-Modules, do yarn and yarn start to test your changes are working fine...
then push and let me know.

Sure @atapas

@atapas i have removed react  from  .eslintrc.json
but this is showing these errors

done @atapas

@yung-coder Please pull the main and make it ready.

Merged but it's breaking...?
@atapas

Merged but it's breaking...?
@atapas

What's breaking?

Merged but it's breaking...?
@atapas

What's breaking?

it has some conflicts with the base...?

Merged but it's breaking...?

@atapas

What's breaking?

it has some conflicts with the base...?

Do you need help? Let's discuss in code clean up channel

I think as this branch is made from code clean-up branch which is 1 commit behind the main so it's conflicting...?

@yung-coder Do we need this PR?

No, you can discard it.
@atapas

authors: atapas yung-coder

repo: reactplay/react-play