text:
Impossible to install

- VSCode Version: LATEST
- OS Version: OS X 10.13 (17A405)
Steps to Reproduce:

Run ./scripts/npm.sh install
Run npm install

`npm install

code-oss-dev@1.18.0 preinstall /Users/lionel/Documents/Lab/vscode-master
node build/npm/preinstall.js

You can't use plain npm to install Code's dependencies.
Please run './scripts/npm.sh install' instead.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! code-oss-dev@1.18.0 preinstall: node build/npm/preinstall.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the code-oss-dev@1.18.0 preinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/lionel/.npm/_logs/2017-10-30T16_09_10_150Z-debug.log
Mini-de-Lionel:vscode-master lionel$ npm test

code-oss-dev@1.18.0 test /Users/lionel/Documents/Lab/vscode-master
mocha

module.js:515
throw err;
^
Error: Cannot find module '../out/vs/loader'
at Function.Module._resolveFilename (module.js:513:15)
at Function.Module._load (module.js:463:25)
at Module.require (module.js:556:17)
at require (internal/module.js:11:18)
at Object. (/Users/lionel/Documents/Lab/vscode-master/test/all.js:39:14)
at Module._compile (module.js:612:30)
at Object.Module._extensions..js (module.js:623:10)
at Module.load (module.js:531:32)
at tryModuleLoad (module.js:494:12)
at Function.Module._load (module.js:486:3)
at Module.require (module.js:556:17)
at require (internal/module.js:11:18)
at /Users/lionel/Documents/Lab/vscode-master/node_modules/mocha/lib/mocha.js:220:27
at Array.forEach ()
at Mocha.loadFiles (/Users/lionel/Documents/Lab/vscode-master/node_modules/mocha/lib/mocha.js:217:14)
at Mocha.run (/Users/lionel/Documents/Lab/vscode-master/node_modules/mocha/lib/mocha.js:469:10)
at Object. (/Users/lionel/Documents/Lab/vscode-master/node_modules/mocha/bin/_mocha:404:18)
at Module._compile (module.js:612:30)
at Object.Module._extensions..js (module.js:623:10)
at Module.load (module.js:531:32)
at tryModuleLoad (module.js:494:12)
at Function.Module._load (module.js:486:3)
at Function.Module.runMain (module.js:653:10)
at startup (bootstrap_node.js:187:16)
at bootstrap_node.js:608:3
npm ERR! Test failed.  See above for more details.`
Reproduces without extensions: Yes

What npm version are you using?

Here's my NodeJS version: v8.8.1

We don't support npm 5.x currently. Can you try cleaning and reinstalling using npm 4.x

v4.8.4 is supported ?

yes. Still running into issues using it?

Same error
`npm install

code-oss-dev@1.18.0 preinstall /Users/lionel/Documents/Lab/vscode-master
node build/npm/preinstall.js

You can't use plain npm to install Code's dependencies.
Please run './scripts/npm.sh install' instead.
npm ERR! Darwin 17.0.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "install"
npm ERR! node v7.10.1
npm ERR! npm  v4.2.0
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! code-oss-dev@1.18.0 preinstall: node build/npm/preinstall.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the code-oss-dev@1.18.0 preinstall script 'node build/npm/preinstall.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the code-oss-dev package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node build/npm/preinstall.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs code-oss-dev
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls code-oss-dev
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/lionel/.npm/_logs/2017-10-30T16_57_03_832Z-debug.log`

Wait, are you running both ./scripts/npm.sh install and npm install? You should only need to run the first. Regular npm install is not supported

So, I should use this one ? ./scripts/npm.sh

yes that will install everything

Thanks, it works!

authors: Flynrod mjbvz


text:
SCSS: Broken syntax highlighting for nested selectors

VSCode Version: 1.18.0
OS Version: macOS High Sierra (10.13.1) and Windows 7

Steps to Reproduce:
All SCSS files now have broken syntax highlighting for nested elements since the latest update. It's the same for everyone on my team, which are split between OSX and Windows. I've done a lot of searching but somehow can't find any mention of this elsewhere, which is odd since we're all on different setups here.

Reproduces without extensions: Yes

That's what I see in 1.18 with the Dark+ theme and no extensions installed.

Maybe there was a change in the theme that you use?

Am I missing something? It also seems to be broken in your screenshot. I'm assuming that P tag is a different colour if you take it out of that nest?
Also from my original post - "Reproduces without extensions: Yes"
I've tried without any extensions whatsoever, and like I said it's on multiple machines.

Sorry, I didn't realize you only meant the p. This one in now fixed in 1.19

Ah great, thanks. It was the P and the H4 in my original screenshot, but it pretty much does it for all element selectors that are nested in any of my scss.

Same issues
Not recognizing &-name as parent-selector-suffix

looks like parsing problems as in same file later got not recognized closing brackets but selector suffix is recognized properly

Not recognizing pseudo elements correctly and double semicolon (first one is treated as punctuation separator but second as meta property value) also opening bracket is treated as part of meta property value

Pseudo elements recognized as support.type.property-name same as all css properties

Treating entity.other.attribute-name.parent-selector-suffix as variable when starts with "--"

Treating "label" tag as support.type.property-name

Treating nested tags as meta.property-name and not as entity.name.tag

Problem with recognizing ending brackets

All looks like parsing problems switching to SASS syntax for same file and everything is ok

@bartech101 There was a grammar update for 1.19 that fixed most of the issues. 1.19 will be out in the coming days.

VSCode Version: 1.19.0
OS Version: Windows 10

Most of the issues are fixed in 1.19.0 but some still exists
'cursor' property is treated as entity.name.tag

BEM "&--modifier" recognized as variable

animation name with "-" not recognized properly

source: gharchive/issue

authors: aeschli bartech101 spncrmoo

repo: Microsoft/vscode

license: MIT

license_type: permissive

license_source: github-api


text:
[feature] Interface and type names EMOJI Support!!

Since all type declarations and infos will be omitted when compiled to JS, it would be safe and great to have interface and type names with emoji support !!!
Just like this:

This would be a feature request for the typescript project :)

Thank you! I've posted this issue to TypeScript project.

authors: hsir roblourens


text:
Missing command to set focus to "currently open project" in side bar

Someone closed out the last issue I had open for this, without a proper answer, so I'm creating a new one.
https://github.com/Microsoft/vscode/issues/3968

There's options for View: Focus into Side Bar and View: Focus on Working Files, but there isn't any option for View: Focus into Open Project. Please add this.

The "answer" that was authoritatively posted into that thread, only works if focus was not previously set to the Working Files section of the Side Bar. If Working Files was the last "area" to have focus in the Side Bar, before focus was moved away, then the CMD + SHIFT + E shortcut will simply return it to Working Files instead of the project.
SIDE NOTE: I'd recommend allowing people some time to respond, before closing out their GitHub issues. People who don't administer the GitHub project cannot re-open their issues, if they're closed out by a project member. Recently, I've been quite diligent about following up on tickets that I've reported, so I'd appreciate an opportunity to hash things out fully, instead of assumptions being made. The Visual Studio Code team has been doing some very good work; it's my hope that this continues.
Cheers,
Trevor Sullivan
Microsoft MVP: PowerShell

@pcgeek86 sorry but what is wrong with commenting on the closed issue so that I can reopen it? Am I missing something?

@bpasero Because there is a good chance that it will not be re-opened by someone, and disappear under closed issues long term. Perhaps with the VS Code team this is less of an issue, but I've seen it happen on other Microsoft projects, so I'm investing my time and effort in a way that I know it'll get noticed.

@pcgeek86 try it out please :)

@bpasero Thanks a lot! I'll test this out once it's available.


text:
Multi root launches do not switch working directory to correct root dir

testing #42036:

two folder workspace with this launch config in each folder "f1" and "f2":  	{
  		"type": "node",
  		"request": "launch",
  		"name": "Launch f1",
  		"program": "${workspaceFolder}/app.js"
  	}

compound launch config in workspace settings: 	{
 		"name": "Compound",
 		"configurations": ["Launch f1","Launch f2"]
 	}

Launch the "Compound" launch config results in this output:

Problem: both programs are launched from the same folder "f1".
We might want to consider to change the working directory for every launched program to the corresponding folder.
@dbaeumer are you doing this for tasks?

Now this works as expected:


text:
Suggestion to have option for the Terminal pane to be open by default on start

I'm looking for a native way to allow the terminal window to be open by default whenever I open VS Code.  I'm trying to avoid having to do cmd + backtick every time I load a new workspace.  According to my stack overflow question, this feature does not appear to exist yet:
https://stackoverflow.com/questions/48626872/vs-code-how-to-have-terminal-pane-open-by-default/

VSCode Version: 1.19.3
OS Version: OS X El Capitan - 10.11.6

Steps to Reproduce:

This is more of a feature request than a bug.

Does this issue occur when all extensions are disabled?: Yes

Since we would probably have to introduce a setting for each of our views and panels to be consistent, it is unlikely we would add this. Closing as designed to not add it. Thanks for the suggestion though.

authors: bpasero robhitt


text:
Problems with folding //#region area

VSCode Version: 1.22.1
OS Version: Windows 7 32bit

Folding symbol next to the //#region and folding of //#region area behaves strangely in v1.22.1.

Steps to Reproduce:

JavaScript, enter this code in one window and another and try to switch between windows (ctrl+tab):

const ddd = '';

module.exports = {
	blablabla: aaa,
	blablabla2: bbb,
}

//#region function aaa()
/**
 *
 */
function aaa()
{

}
//#endregion

//#region function bbb()
/**
 *
 * @param param
 */
function bbb(param)
{

}
//#endregion

Does this issue occur when all extensions are disabled?: I have no extensions installed
Sorry for my English.

P.S. sorry for duplicate - it took some time for me to write code, capture screens, comment them and try to find what's causing this bug.

Fixed on my install of 1.22.1 by adding:
"typescript.experimental.syntaxFolding": false to my workspace settings.json.

Duplicate of #44530
Setting "typescript.experimental.syntaxFolding": false will disable the new syntax based folding and should fix this issue.

authors: Jusys kash4kev mjbvz


text:
File paste feature request

Modify file paste in the explorer to either ask to replace an existing file instead of pasting it with a new name, or provide a paste-and-replace feature that replaces existing files with what is being pasted. It is really cumbersome to first find and delete the files before pasting, and even worse to paste and then have to delete the original and rename the new file.
Regards

@jmussman thanks for the feedback however we will not change this behavior. This is how native os explorers behave.
You can make an extension which contributes the action which you need and rebing the keybindings to invoke the action of your extension.

I understand that you don’t want to do it, and that’s your choice. But, please TELL ME ONE EXPLORER THAT HAS THE NATIVE BEHAVIOR AS VS CODE WORKS? NOT WINDOWS, NOT OS X, AND NOT ONE SINGLE LINUX DESKTOP THAT I CAN THINK OF. Microsoft arrogance and stupidity, all over again. God, you people are so frustrating, and have been for decades.
From: Isidor Nikolic notifications@github.com
Reply-To: Microsoft/vscode reply@reply.github.com
Date: Monday, April 30, 2018 at 5:08 AM
To: Microsoft/vscode vscode@noreply.github.com
Cc: Joel Mussman jmussman@smallrock.net, Mention mention@noreply.github.com
Subject: Re: [Microsoft/vscode] File paste feature request (#48915)
@jmussmanhttps://github.com/jmussman thanks for the feedback however we will not change this behavior. This is how native os explorers behave.
You can make an extension which contributes the action which you need and rebing the keybindings to invoke the action of your extension.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/vscode/issues/48915#issuecomment-385346068, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AF4nu_NhNvFSyj2cDiQ3QgU8oM9DypSlks5tttSfgaJpZM4Tr0na.

Really? Without a chance to respond? You people are so arrogant.
From: "vscodebot[bot]" notifications@github.com
Reply-To: Microsoft/vscode reply@reply.github.com
Date: Monday, April 30, 2018 at 5:09 AM
To: Microsoft/vscode vscode@noreply.github.com
Cc: Joel Mussman jmussman@smallrock.net, Mention mention@noreply.github.com
Subject: Re: [Microsoft/vscode] File paste feature request (#48915)
Closed #48915https://github.com/Microsoft/vscode/issues/48915.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/vscode/issues/48915#event-1601116718, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AF4nu0wdiCrzMlJu9MLwFVgrg33u86EIks5tttSpgaJpZM4Tr0na.

authors: isidorn jmussman


text:
Mouse disapears in VScode for MacOS

Issue Type: Bug
Mouse/cursor isn't visible within the canvas (writing area), move to the chrome/edge UI and the mouse re appears.
VS Code version: Code 1.23.1 (d0182c3417d225529c6d5ad24b7572815d0de9ac, 2018-05-10T16:03:31.083Z)
OS version: Darwin x64 17.5.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz (4 x 3100)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
6, 6, 6

Memory (System)
8.00GB (0.03GB free)

Process Argv
/Applications/Visual Studio Code.app/Contents/MacOS/Electron

Screen Reader
no

VM
0%

Extensions (13)

Extension
Author (truncated)
Version

vscode-markdownlint
Dav
0.17.0

xml
Dot
1.9.2

vscode-devskim
MS-
0.2.2

vscode-docker
Pet
0.0.27

sort-lines
Tyr
1.7.0

code-runner
for
0.9.3

auto-comment-blocks
kev
1.0.1

markdown-shortcuts
mdi
0.8.1

PowerShell
ms-
1.7.0

wordcount
ms-
0.1.0

copy-json-path
nid
0.0.1

partial-diff
ryu
1.1.0

markdown-pdf
yza
1.2.0

I'm experiencing this issue now, and per my testing, it seems related to the external monitor I'm using. I don't have the issue on the MacBook Pro's display when not connected to an external monitor. The issue surfaces when I'm connected to one monitor (Dell P2715Q) but not when connected to another (Dell U3417W). I believe the biggest difference between the two is the P2715Q (the one that produces the issue) is 4k while the other one (that doesn't produce the issue) is not.

Are we certain this is a duplicate? This does not appear to be an OS specific bug. I'm seeing this only in the code editor window, and only in Visual Studio Code. No other apps.

I'm actually seeing it in SublimeText when using a dark theme there also.
If I use a light theme in either app, the cursor remains. The only
workaround that's working for me at this time is to use the Accessibility
settings to make my cursor ever so slightly larger than normal size. I wish
it wasn't necessary. There's definitely a bug here somewhere, which would
be nice to see fixed.
On Mon, Jun 4, 2018 at 1:17 PM Drew Covi notifications@github.com wrote:

Are we certain this is a duplicate? This does not appear to be an OS
specific bug. I'm seeing this only in the code editor window, and only in
Visual Studio Code. No other apps.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/50409#issuecomment-394449018,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACuRtruskhT7DVj3CgNTGpuUagb1zVCjks5t5XmcgaJpZM4UMwQT
.

authors: azarainey drewcovi stefcameron


text:
notification icons missing after latest update

Issue Type: Bug
I just edited and saved a couple of files and then spotted the little blue change count notifications on VC icon are missing.
Was fine before I updated yesterday

VS Code version: Code 1.24.0 (6a6e02cef0f2122ee1469765b704faf5d0e0d859, 2018-06-06T17:35:40.560Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6650U CPU @ 2.20GHz (4 x 2208)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: unavailable_softwarewebgl: enabledwebgl2: enabled

Memory (System)
15.93GB (10.47GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe .

Screen Reader
no

VM
0%

Extensions (20)

Extension
Author (truncated)
Version

project-manager
ale
0.25.2

npm-intellisense
chr
1.3.0

path-intellisense
chr
1.4.2

gitignore
cod
0.5.0

vscode-markdownlint
Dav
0.18.0

vscode-eslint
dba
1.4.12

git-extension-pack
don
0.1.3

githistory
don
0.4.1

gitlens
eam
8.3.5

EditorConfig
Edi
0.12.4

vscode-npm-script
eg2
0.3.4

prettier-vscode
esb
1.5.0

search-node-modules
jas
1.3.0

prettify-json
moh
0.0.3

debugger-for-chrome
msj
4.6.0

vscode-versionlens
pfl
0.21.1

nodejs-extension-pack
wad
0.1.9

JavaScriptSnippets
xab
1.6.0

html-css-class-completion
Zig
1.17.1

vscode-open-in-github
ziy
1.3.1

(2 theme extensions excluded)

Duplicate of #51396

@SteveALee Did you try to change the position of the SCM icon on the left (activity bar) like in issue #51396 ?

What a nice friendly bot! :)
@sandy081 I assume that means drag it down in the icon order? Who knew you could do that? :) Sadly that makes no difference for me.

@joaomoreno Moving this to you as it looks unrelated to the bug I fixed.

@SteveALee Did you change the git.countBadge setting?

@joaomoreno Nope. And I can't see it any reference in settings file.
The project is free of any git or code config files - https://github.com/straight-street/mulberry-symbols
Is there an easy way to temporarily disable all extensions? Gitlens is active.

Yeah, use --disable-extensions. Does it still reproduce like that too? Does the issue happen often, or was it just that one time? Can you reproduce with any other project?

Full marks for the obvious switch! :) I missed that had arrived after I made a request.

Does it still reproduce like that too?

Sadly

Does the issue happen often, or was it just that one time? Can you reproduce with any other project?

Always happens, any project. :(
I do have latest Git4Windows installed as well as I use it's bash for my CLI

OK some more info after I updated to 12.4.1

Other project work fine. This one still fails
t
The blue clock overlay icon appears and then vanishes
This project is a slightly unusual structure and the EN folder contains > 3K files

All other projects work fine, but this fails...
Can you show me a quick video recording of you staging some files, committing others...?

Sure, https://www.youtube.com/watch?v=HRzPTH5O6F0

@SteveALee It says that the video is unavailable.

It's definitely there!
I wonder if only some regions? I'm UK - will check

This one came from right clicking on the video https://youtu.be/HRzPTH5O6F0

😢

This crazy! What is up with YouTube! (:
`
http://opendirective.net/GPII/VSCode51595.zip

Yup, that was a great video! Unfortunately, I have no clue why this might be happening...
Can you try running with a new user data dir and see whether it still reproduces on that folder? Try code --user-data-dir DIRNAME.
It's very interesting how this only happens for one specific project...

OK it's fixed somehow.
I tried --user-data-dir DIRNAME . and it worked then tried without and it still worked!
I've not knowingly changed anything in the project or global code or git config.
Just have to put it down to one of those things.
thanks for your help

So odd. Let me know if it comes back!

authors: SteveALee joaomoreno sandy081


text:
Fix imports changes more than is required

Issue Type: Bug
When renaming or moving a file and answering yes to fixing up the imports, causes unrelated imports to be changed.
For example, renaming a completely unrelated file, caused this import to change in a bunch of files.
import { /* */ } from “vscode-languageserver”

to
import { /* */ } from “vscode-languageserver/lib/main”

It seems that the fix up shouldn't change anything other than the imports that are required to change because of the rename/move operation.
At the same time, I don't know why it would change to that deeper import anyway -- which seems similar to https://github.com/Microsoft/vscode/issues/54841
//cc @mjbvz
VS Code version: Code - Insiders 1.26.0-insider (befea2253626b1918352df04477cae83eee618ac, 2018-07-24T05:20:05.823Z)
OS version: Windows_NT x64 10.0.17713

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.93GB (18.19GB free)

Process Argv
C:\Users\Eric\AppData\Local\Programs\Microsoft VS Code Insiders\Code - Insiders.exe C:\Users\Eric\code\codestream\vscode-codestream\codestream.code-workspace

Screen Reader
no

VM
0%

I can't repo this in a small example project using TS-3.0.1-insiders.20180723
Do you have an example project where this is happening? Please share the jsconfig/tsconfig and locations of the files being renamed at least

I'm still using Typescript 2.92 -- is that why? If not, then I'll look into providing an example.

I have observed a similar issue in TypeScript 2.5.2, e.g. when renaming a file
import { State } from '@progress/kendo-data-query';
becomes
import { State } from '@progress/kendo-data-query/dist/es/main';
in files that do not even reference the renamed file.
My project builds fine but some of the import changes (especially with rxjs) result in ambiguous runtime errors that are very difficult to trace.
VSCode 1.25.1

Yes this is only fixed in TS 3.0+. Let me know if you still see it using a newer version

authors: eamodio mjbvz tomfumb


text:
Icon in top left corner is misaligned

The picture below shows what I mean.
I've made a mockup with a slightly larger icon(36x36 pixels), in contrast to the original (28x28 pixels), as I think it looks better with a larger icon to match the size of the side-panel icons.

@Splike Is the left side what you are seeing in the product today? If so, do you always see this or is this after some resizing or some other relayout behavior?

Yes, this is what I see in the product today (1.27.2), where I have set "window.titleBarStyle": "custom" and no additional options have been set or resizing done.

I've had to reinstall VS code and now mine does look like your picture.
But would it still be possible to align  and center the icon, like in my right picture?

@Splike Thanks for the suggestion, I'll try it out and get back.

authors: Splike sbatten


text:
The powershell program keep opening in the background

VSCode Version: 1.29.0-insider(user setup)
OS Version: Windows 7 x64 Professional SP1

Steps to Reproduce:
In my cash, when you debug a node problem, it will open sereral powershell programs, but it won't close itself when I stop debuging. Do it more times the Code has to reopen after tens of powershell programs are running in the background because of the RAM had run out.

Does this issue occur when all extensions are disabled?: No extensions installed

duplicate of #60585

authors: egamma sondragon


text:
debug.startDebugging doesn't work with named configurations

VSCode Version: 1.28.2
OS Version: 10.13.5

Steps to Reproduce:

Add a launch configuration with name Foo.
Execute vscode.debug.startDebugging ( undefined, 'Foo' ); from an extension.
Instead of launching the debugger I get this error 'launch.json' does not exist., needless to say that launch.json exists and that I can actually start the Foo configuration from the debug view.

the documentation of startDebugging says it all:
		/**
		 * Start debugging by using either a named launch or named compound configuration,
		 * or by directly passing a [DebugConfiguration](#DebugConfiguration).
		 * The named configurations are looked up in '.vscode/launch.json' found in the given folder.
		 * Folder specific variables used in the configuration (e.g. '${workspaceFolder}') are resolved against the given folder.
		 * @param folder The [workspace folder](#WorkspaceFolder) for looking up named configurations and resolving variables or `undefined` for a non-folder setup.
		 * @param nameOrConfiguration Either the name of a debug or compound configuration or a [DebugConfiguration](#DebugConfiguration) object.
		 * @return A thenable that resolves when debugging could be successfully started.
		 */

If you pass undefined as the folder, the launch config cannot be found.

authors: fabiospampinato weinand


text:
Scroll Synchronization

This is more of a feature request...
When viewing a markdown file in split panes with one side being the raw markdown and the other being the HTML preview, I'd like to be able to have the two panes stay in sync as I scroll one or the other. For example, if I scroll down in the raw pane, I'd like the preview pane to scroll down as well so the markdown and preview stay in sync with each other. This is a feature found in MarkdownPad, my current/previous markdown editor, that I'd like to see in VS Code as well.
Thanks!

The key point of synchronized scrolling is mapping the preview html sections to markdown source. A dirty but quick solution is injecting hidden splitters to html preview then map them to line numbers of markdown source. Since we've moved the markdown rendering code to a separate extension, this kind of hack should go with the extension either.
The missing feature in VS Code is how to scroll the preview panel. We are previewing the content by triggering htmlPreview command with content bytes, it's likely we should bind some scrollHandler to the htmlPreview action.

+1
really needs this feature

+1

+1

+1

I'd very much like this as well.
I'm sure it could be implemented as an extension, but it seems small enough that it would probably make sense to be a core feature.

I'd love this feature as well, would make VS Code my default Markdown editor.
The Markdown Editor for Visual Studio 2015 has this feature already. But using the full-fleshed VS IDE for markdown seems like overkill... It also has the ability to follow links, as asked for in the issue

+1 I use VS Code md for my project docs, and having them out of sync is painful. Also, when leaving and returning to the md preview pane, it resets to the top. This makes it difficult to follow links in the md.

+1

Closing as duplicate of #5047, which also requested this feature.

+1 this feature very usefull

+1 would be great

when the vscode have the feature?

+1

+1

amazing! Awesome! Thanks!!

How can I enable this function? I updated to version 1.9.0, but Synchronized Markdown Preview doesn't work. Only click event works well, other feature is not working.

@jihunx Please open a new issue with some repo steps and I'll take a look

Thanks a lot but how does this work?
Do yo need to install an extension to make the Markdown preview work?
In the documentation I read:
VS Code supports Markdown files out of the box. You just start writing Markdown text, save the file with the .md extension and then you can toggle the visualization of the editor between the code and the preview of the Markdown file

But when I click the preview button, nothing happens, or do you have to enable a setting?

I also don't see it working.

Removed all extensions beside the 'Auto-Open MarkdownPreview' uninstalled, reinstalled VSC and rebooted computer.
I see two issues:
Issue 1:
The preview now works out of the box for a file like:
# How to create documentation

__Todo:__ create content, blabla....

Explain documents are created with Markdown, commit, Git, VSTS location, automatic build and automatic deploy to web site/SharePoint

![](img/CreateDocumentationProcess.jpg)

## Using Visual Studio Code with Markdown

[https://code.visualstudio.com/docs/languages/markdown](https://code.visualstudio.com/docs/languages/markdown)

But is does not work for the same file with some meta data added to the top. Instead the preview keeps blinking and cpu usage spikes, but preview stays empty, I have to kill the Visual Studio Code task through the Task Manager. It happens with this file:
---
Header: Coding Guidelines
Type:
Title: How to create documentation
Description:
Version: v1.0
Date: 20170108
TopicId: 30
...

# How to create documentation

__Todo:__ create content, blabla....

Explain documents are created with Markdown, commit, Git, VSTS location, automatic build and automatic deploy to web site/SharePoint

![](img/CreateDocumentationProcess.jpg)

## Using Visual Studio Code with Markdown

[https://code.visualstudio.com/docs/languages/markdown](https://code.visualstudio.com/docs/languages/markdown)

Issue 2:
I can open a long document (without the meta lines) and show the preview. But when I scroll through the document, the preview is not scrolled in sync, VSC version is 1.9.0

Update Issue 1:
When I identify the meta block at the beginning with dashes only, then the preview works and no spkie in cpu usage. I think I will use this as a work around for the moment and change my Markdown files like this:

Synced Scrolling with preview is still not working

---
Header: Coding Guidelines
Type:
Title: How to create documentation
Description:
Version: v1.0
Date: 20170108
TopicId: 30
---

# How to create documentation

__Todo:__ create content, blabla....

Explain documents are created with Markdown, commit, Git, VSTS location, automatic build and automatic deploy to web site/SharePoint

![](img/CreateDocumentationProcess.jpg)

## Using Visual Studio Code with Markdown

[https://code.visualstudio.com/docs/languages/markdown](https://code.visualstudio.com/docs/languages/markdown)

PR with fix for the cpu usage: #19894
@RobDaPraia We currently don't support using ... to terminate a frontmatter block. Using it will break syntax highlighting and cause the entire rest of the document to be treated as yaml instead of markdown.
In the future, please open new issues so that we can track individual issues and feature requests better

@mjbvz Thanks for the explanation
create new issue: yes will do so next time, makes sense ;)

Thanks for the Update: 1.9.1
Still a question about the scrolling now with update 1.9.1:
1   When I scroll the preview window, the source window is also scrolling
2   When I scroll the source window, the preview window is not scrolling
3   When I double click in the preview window the cursor in the source window is placed on the object
4   When I click in the source window the preview window scrolls to the same location
I'm very pleased that 1,3 and 4 work, but should 2 also work out of the box or is this the intended behavior?

@RobDaPraia Yes, that is the expected behavior with VSCode 1.9. Source to preview scroll sync is tracked by #19459

authors: Emeryao Mucaccino RobDaPraia Zicore a1018875550 akzaidi amazingandyyy b1as forehalo iebox jbramwell jihunx jingniao jordanroskelley joshsleeper mjbvz neilyoung nonoroazoro rebornix


text:
Notifications not being read out by VoiceOver

From @PeterSaathoff-Harshfield
There are alerts that appear at the bottom right corner of the window. When VoiceOver focuses on them, they are reported as "notification toast." VoiceOver doesn't read anything more than "notification toast" for each one. They can't be interacted with, and therefore can't be read or dismissed with VoiceOver. Also, "toast" is maybe not a meaningful word for many people in this context even though programmers may know what a toast is.
Isidor: I could not really reproduce this, as when I focus the notification list I get the content nicely read out.
However I do see in code the Notification Toast here
@PeterSaathoff-Harshfield how do you get into a state that only "notificatino toast" is being read out?

I would like to reproduce this and record a short video, but I don't know a way of creating notifications.

@PeterSaathoff-Harshfield you can have a .extensions.json inside the .vscode folder with this content
That way you will always get a notification when you open that workspace inv vscode.
{
	// See http://go.microsoft.com/fwlink/?LinkId=827846
	// for the documentation about the extensions.json format
	"recommendations": [
		"eg2.tslint"
	]
}

authors: PeterSaathoff-Harshfield isidorn


text:
Not opening multiple files in tabs

Issue Type: Feature Request
my vs code is not opening multiple files at a time. when I click other file, it replaces old one.
VS Code version: Code - Insiders 1.32.0-insider (11416de365a1e96302e171c9eebc2547872ac230, 2019-02-23T08:18:00.091Z)
OS version: Windows_NT ia32 6.1.7601

This is what's called Preview Mode. See https://code.visualstudio.com/docs/getstarted/userinterface#_preview-mode on how it works, and how you can turn it off if you prefer.
Perhaps worth reading the rest of the Getting Started page as well...

@gjsjohnmurray exactly! ;)

Now solved, thank you so much.
On Mon, Apr 15, 2019, 4:15 PM John Murray notifications@github.com wrote:

This is what's called Preview Mode. See
https://code.visualstudio.com/docs/getstarted/userinterface#_preview-mode
on how it works, and how you can turn it off if you prefer.
Perhaps worth reading the rest of the Getting Started page as well...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/72331#issuecomment-483210162,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AtvfD6tl-MHph61RDlV3Iw-2S3aAY78Xks5vhF9hgaJpZM4cvtH7
.


text:
Integrated terminal: Setting font size to 1 freezes application

Testing #8222

VSCode Version: Code - Insiders 1.3.0-insider (d0c2b891903d73e83dcdc7786398ebfa764fc4ee, 2016-06-28T05:07:32.441Z)
OS Version: Windows_NT ia32 6.3.9600

Steps to Reproduce:

Open user settings, set terminal.integrated.fontSize to 1
Open console -> application freezes

Work on Linux:

Works on macOS.

Can't reproduce anymore... (Tried Windows 8.1 and 10.)

Closing then, maybe you hit some other issue disguised as this?

authors: Tyriar chrmarti csholmq


text:
Can't build in Windows 10

I followed instructions from https://github.com/Microsoft/vscode/wiki/How-to-Contribute#build-and-run-from-source , but the build is unsuccessful.
I'm using node v5.1.0, Visual Studio 2015 Community (I installed C++ build tools), MSBuild v14.0.24720.0
npm-debug.log file gives following error:
21173 verbose stack Error: oniguruma@5.1.1 install: `node-gyp rebuild`
21173 verbose stack Exit status 1
21173 verbose stack     at EventEmitter.<anonymous> (C:\Program Files\nodejs\node_modules\npm\lib\utils\lifecycle.js:232:16)
21173 verbose stack     at emitTwo (events.js:87:13)
21173 verbose stack     at EventEmitter.emit (events.js:172:7)
21173 verbose stack     at ChildProcess.<anonymous> (C:\Program Files\nodejs\node_modules\npm\lib\utils\spawn.js:24:14)
21173 verbose stack     at emitTwo (events.js:87:13)
21173 verbose stack     at ChildProcess.emit (events.js:172:7)
21173 verbose stack     at maybeClose (internal/child_process.js:818:16)
21173 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
21174 verbose pkgid oniguruma@5.1.1
21175 verbose cwd E:\Github\vscode
21176 error Windows_NT 10.0.10586
21177 error argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install"
21178 error node v5.1.0
21179 error npm  v3.3.12
21180 error code ELIFECYCLE
21181 error oniguruma@5.1.1 install: `node-gyp rebuild`
21181 error Exit status 1
21182 error Failed at the oniguruma@5.1.1 install script 'node-gyp rebuild'.
21182 error Make sure you have the latest version of node.js and npm installed.
21182 error If you do, this is most likely a problem with the oniguruma package,
21182 error not with npm itself.
21182 error Tell the author that this fails on your system:
21182 error     node-gyp rebuild
21182 error You can get their info via:
21182 error     npm owner ls oniguruma
21182 error There is likely additional logging output above.
21183 verbose exit [ 1, true ]

Git shell is giving following error:
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.Cpp.Platform.targets(64,5):
error MSB8020: The build tools for v140 (Platform Toolset = 'v140') cannot be found.
To build using the v140 build tools, please install v140 build tools.  Alternatively, you may upgrade to
 the current Visual Studio tools by selecting the Project menu or right-click the solution, and then
selecting "Upgrade Solution...".
[E:\Github\vscode\node_modules\vscode-textmate\node_modules\oniguruma\build\oniguruma.vcxproj]

However, as I mentioned earlier, my MSBuild version is 14.0.24720.0
I tried following workarounds from * User/Repository#Num: nodejs/node-gyp#679 :

set environment variable GYP_MSVS_VERSION = 2015
tried to run ```scripts\npm install --msvs_version=2015
update Visual Studio
But still without success.

Steps to reproduce the bug:

install Visual Studio Community 2015
install node.js v5.1.0
clone repository using command ```git clone https://github.com/microsoft/vscode
go to repository cd vscode
install mocha gulp ```npm install -g mocha gulp
run install script scripts\npm install

@Umriyaev not sure how to fix the specific node-gyp issue you run into.
But here is a hackish workaround. It involves "manually installing" vscode-textmate@1.0.8 in the node_modules such that npm does not need to install it:

download VSCode for windows as a zip
extract the zip and take resources\app\node_modules\vscode-textmate and copy it to where you have checked out vscode in $\node_modules\vscode-textmate
the vscode-textmate version in that zip is 1.0.6 and we now use 1.0.8 on master, so npm install will still try to install it, therefore:
download vscode-textmate@1.0.8
extract the tgz on top of $\node_modules\vscode-textmate

Run scripts\npm install again. This time, since npm finds vscode-textmate@1.0.8 it won't try to install it, therefore it won't utilise node-gyp and will continue with the other node modules (that don't require node-gyp).

Can you try installing Visual Studio 2013 instead of 2015?

I did manage this on a Windows 10 pc, with only VS2015. If I recall correctly I installed alot of packages with npm install <name> --no-bin-links manually because of some very weird errors. Will try to check it out again tonight

@alexandrudima Thank you so much! Your workaround worked for me.
I guess it should be added to How to build and run from source .
Of course after finding more generic solution.

It's definitely just a workaround, let's try to find why you couldn't compile. I'll set up a VM tomorrow with exactly your setup and see what I get.

Just set up a brand new Windows 10 VM. Installed VS Community 2015, node 5.1.0 and Python 2.7. Got some errors at first, but realised I did not install the C++ tooling. Went to Control Panel, hit Modify in the Visual Studio item and added the Visual C++ tooling.

I successfully ran .\scripts\npm.bat install afterwards.
Not sure what is wrong with your system, but it's at best a Visual Studio and/or npm issue.

You seem to be in a system that has had Visual Studio 2013 installed before, since you mention the following path:
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.Cpp.Platform.targets

In my brand new VM, I only have the V140 directory, not the V120:
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140

I see.
Thank you for your help.

In case you actually find a solution to your problem, can I ask you to post it here? Maybe it'll help others. :+1:

Sure! Of course I will

authors: DickvdBrink Umriyaev alexandrudima joaomoreno


text:
fix for #39

https://github.com/Microsoft/vscode/issues/39

Hi @weinand, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (André Weinand). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

source: gharchive/pull-request

authors: msftclas weinand


text:
Support undo and redo in input fields (fixes #151)

Follows the same strategy as we had for the "Select All" command by using document.execCommand in case an input field or textarea currently has focus. This enables undo and redo via keyboard on macOS if focus is inside these.
This also enables Edit > Undo and Edit > Redo to work properly on all OS.
One behavioural change is that invoking Undo/Redo when the editor does NOT have focus will now execute these commands in the editor even though it does not have focus. This is the same with the Select All command. We could control this behaviour and say that Undo/Redo only work if the editor has focus. I leave that up to you.

LGTM

authors: alexandrudima bpasero


text:
Integrate docs - broken link

The links to the Visualstudio integrate are broken: https://www.visualstudio.com/integrate/extensions/overview

Looks like the redirect is back now

Agreed. Closing issue.

authors: nschonni sztaylorakgov

repo: Microsoft/vss-web-extension-sdk

license: mit

license_source: bigquery


text:
Code Coverage Excludes for Native C++ Code

Steps to reproduce

What steps can reproduce the defect?

Not sure if it is a defect. May only be a question. Just run any C++ Native Source Code project, linked to any external library/header, and with the linker setup as described in https://blogs.msdn.microsoft.com/jsocha/2011/08/16/capturing-c-code-coverage-with-visual-c/.
I work for Microsoft btw (alias ercintra) and have the full example uploaded to VSTS.
In my example, I've used the command line: vstest.console.exe C:\SandBox\UnitTestFrameworkEvaluation\Debug\ExampleCode.MSTests.dll /enablecodecoverage /Settings:TestsAndCoverage.runsettings
My RunSettings file is:

1
.\TestResults
x86

.*CPPUnitTestFramework.*
.*examplecode.mstests.dll Microsoft*

        <!-- We recommend you do not change the following values: -->
        <UseVerifiableInstrumentation>True</UseVerifiableInstrumentation>
        <AllowLowIntegrityProcesses>True</AllowLowIntegrityProcesses>
        <CollectFromChildProcesses>True</CollectFromChildProcesses>
        <CollectAspDotNet>False</CollectAspDotNet>

      </CodeCoverage>
    </Configuration>
  </DataCollector>

</DataCollectors>

True
false
False
False

Expected behavior
I should be able to specify a ModulePath for exclusion that allows me to exclude everything that starts with Microsoft.
Actual behavior
I either can exclude all the examplecode.mstests.dll or anything. The screenshot here helps to understand the behaviour:

Environment
Visual Studio 2017 Enterprise 15.6.6 Enterprise
Native C++ Code
Compiled to x86, machine running x64.

@ericlemes , I'm not sure what is the exact ask here, you mentioned that you would want to exclude anything that contains "Microsoft" in path, which is possible today as you can mention such modules under   section of code coverage configuration.
Also as per your screenshot I see only one module covered which is exam**.dll, which I suppose is what you would want.
Are you looking for a way to exclude source files , namespaces.. etc? We also support those, please look here for complete information on configuring codecoverage settings.

Hi @mayankbansal018
The issue here is that because it is C++ and there are external libraries compiled and linked inside the module examplecode.mstests.dll, some namespaces which does not make sense to track coverage are being tracked. In the example above, Microsoft::VisualStudio::CppUnitTestFramework is the unit test framework compiled inside the .dll. I don't want to track that coverage, because it is not my code.
Same for fakeit.
I can exclude only the full module, which does not solve my problem.

@ericlemes , you can exclude functions under namespaces, by specifying then under Function tag of Coverage Configuration, please look at https://msdn.microsoft.com/en-us/library/jj159530.aspx, for details on how namespaces, source files, modules etc can be excluded from Coverage.
For your specific e.g. above, we already exclude "Microsoft::VisualStudio::CppUnitTestFramework" namespace by default in CodeCoverage configuration

Hi @mayankbansal018,
Thanks! That is really helpful.  But I've bumped in a new issue.

Is it possible to exclude these "static void __scr_initialize" and similar. This is not my code...
I used these expressions and they don't work:
scrt.
dllmain_.
_IMAGE_SECTION_HEADER.
_get_entropy.
FakeIt.
^static
It is being very painful to set this up. I found odd that the code coverage setup is in the test run configuration and you have to setup files and everything. I personally found the OpenCppCoverage way easier to setup (even though still complex), and everything can be contained simply in the command line. I'm sending just in case you are interested in doing some benchmarks to simplify the whole process for C++.
Thanks for your help.

@ericlemes , we also control exclusion at file level, & by default we ignore certain paths for C++, e.g.  any source file from "\atlmfc\." , "\vctools\."   etc..
We will take this feedback, & try to improve the experience for C++ coverage.

Hi @mayankbansal018,
This information is very helpful. But I still didn't manage to do what I want. To clarify the use case I'm expecting is:

Run coverage on command line
Publish results on a CI tool (TeamCity and VSTS)
Provide reports for the developer, allowing to run specific files
Provide a html coverage report that can be upload to the CI tool.

So, the process using the .TestSettings and excluding by file worked fine. My problem now is that running vstest.console with /EnableCodeCoverage, does not allow me to specify where the .output coverage file will be, making very difficult to deliver step 2 of the use case, since I need somehow to figure out which the test run.
If I run CodeCoverage.exe and wraps vstest.console inside, the coverage output does not  follow the excludes used in the /Settings parameter of vstest.console.
Is there any way of setting the .coverage output file?

I'll open a new issue, since this one was closed even.

repo: Microsoft/vstest


text:
Add Chrome web browser to Hosted Linux agent

We would like to have Chrome available for running web app unit tests on the Linux hosted agents. It is available on the Hosted VS2017 agents and works great on there:
https://github.com/Microsoft/vsts-image-generation/blob/master/images/win/Vs2017-Server2016-Readme.md

I added the google-chrome package: https://github.com/Microsoft/vsts-agent-docker/commit/cf55875fb42b55a0f68419df844b2d90d4d40e19
Ill close this when it is deployed to hosted pools, but the updated images are pushed and you can try them out if you run it as a private agent

Actually, since this related to Hosted Pools, please track the progress here: https://github.com/Microsoft/vsts-image-generation/issues/181
From the Docker image perspective, this is complete.

Can you confirm if CHROME_BIN gets set as part of the installation?

authors: dakale stewx

repo: Microsoft/vsts-agent-docker


text:
NUnit FixtureSetup failures do not count as failures

Some of our test fixtures use a method annotated with [TestFixtureSetup] to perform some once-off initialisation/validation. If that setup method throws an exception, nunit will correctly mark the entire fixture as failed and not run any tests. I've attached a copy of a test run which fails in this way.
An example of a failing suite can be seen here. It is an xml file but i had to rename it to txt to upload it here:
failures.txt

As recommended by @SadagopanRajaram we're going to work around this by ensuring our process exit code indicates failure. That way we will know when we have to manually review the result xml.
I may also try to rewrite the test so that we catch the exception from the fixture-level setup and manually re-throw it inside the per-test [Setup] method. That should give us good visibility into each individual test failure. At the moment the NUnit xml is incomplete as it lists zero tests in the event of a fixture-level exception.

@alanmcgovern - doesn't seem like an agent issue (agent is generic and just runs tasks).  Is it a task or test factoring issue?

If it's a task issue log in vsts-tasks repo.

If you're telling me this is a task issue, then it is a task issue and i'll file it against that repository. I don't have the knowledge to answer your question :p

authors: alanmcgovern bryanmacfarlane

repo: Microsoft/vsts-agent


text:
Getting test results using VSTS rest API

I am using Nodejs for consuming rest API of VSTS
Getting Builds and work items is working fine.
But I am confused about the endpoint which will return me the test results of particular build.
Kindly help me with this.

@kksevta Check out https://www.visualstudio.com/en-us/docs/integrate/extensions/reference/client/api/tfs/testmanagement/restclient/testhttpclient2_2

repo: Microsoft/vsts-dotnet-samples


text:
Support code information in TeamCity extension

The TeamCity extension should provide the same code information as the Jenkins integration does

As Jenkins integration can now show commits and linked Jira work items is the same possible through the REST API and for the TeamCity integration?

@pascalberger It is possible to extend teamcity task to publish commits/workitems, similar to how jenkins task does it https://github.com/Microsoft/vsts-tasks/blob/master/Tasks/JenkinsDownloadArtifacts/jenkinsdownloadartifacts.ts#L144

authors: omeshp pascalberger

repo: Microsoft/vsts-rm-extensions


text:
Fix spaces on Windows in cmd and args

Only as a suggestion for #112.
Note: I had to increase the timeouts on Windows, but left them as-is because this probably works better on your end.
Also, it took me a while to realise this, but node.js tasks run in an embedded node, which at this time is 5.10.1. Quoting toolName does not work on node 4.4.7.
And apologies for the whitespace changes, default editor settings...

Fixed as part of PR https://github.com/Microsoft/vsts-task-lib/pull/157. Effectively runs shell=true for .cmd and .bat files and applies different quoting rules.

authors: adriaanthomas ericsciple

repo: Microsoft/vsts-task-lib


text:
Run Functional Test task aborts on warnings instead of continuing

We have a test assembly that contains methods with the [testmethod] attribute, but the methods accept a parameter.  These methods are not actually 'executed' in the test run, however the run functional test task discovers these and aborts the test run after printing a warning that a teatmethod must not have parameters. The console logs this as a warning, and running from the command line vstest.console.exe logs this same warning but continues to execute the requested tests.
Run Functional Tests should behave the same way that VSTest.console behaves.  It should log the warning but continue to run the choosen tests.
> DistributedTests: Test run is aborted. Logging details of the run logs.
> DistributedTests: New test run created.
> Test Run queued for Project Collection Build Service (TEAM FOUNDATION).
> DistributedTests: Test discovery started.
> DistributedTests: Test Run Discovery Aborted . Test run id : 1401359
> DistributedTests: UnExpected error occured during test execution. Try again.
> DistributedTests: Error : UTA007: Method MyMethod defined in class MyClass does not have correct signature. Test method marked with the [TestMethod] attribute must be non-static, public, return-type as void and should not take any parameter. Example: public void Test.Class1.Test(). Additionally, return-type must be Task if you are running async unit tests. Example: public async Task Test.Class1.Test2()
> DistributedTests: Test run aborted. Test run id: 1401359
> System.Exception: The test run was aborted, failing the task.

Can you share a sample repro project to devops_tools@microsoft.com.

I tried to repro this problem. Vstest.console have given this warning and exited out without executing tests for me. what version of VS have you used ?

Thanks,
I found my issue - I had a typo in my filters: TestCatagory instead of TestCategory, however that error wasn't being returned from the build.  Only after a careful visual inspection and trying the same from the command line did I see that the command line fails with an unknown option error, which doesn't show in the build.

authors: AshwiniChalla abbottbd

repo: Microsoft/vsts-tasks


text:
Unit Tests that that create UI controls fail with latest version of vstest.console.exe

using vstest.console.exe version as described here:
https://github.com/Microsoft/vsts-tasks/issues/5404#issuecomment-332210558
It now publishes properly but now we are getting exceptions with unit tests that create UI controls (running on TFS 2017 server):
System.InvalidOperationException: The calling thread must be STA, because many UI components require this.
These worked fine with the Built In version of vstest.console.exe.
Now am stuck - if I use version of vstest.console.exe that passes all tests (including these UI tests), then it can't publish it (issue 5404 above).  If I use version of vstest.console.exe that can publish properly, then some of the UI tests fail.
What to do?

just to make clearer
This one fails on UI tests:
"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\Extensions\TestPlatform\vstest.console.exe"
Version 15.0.0.0
System.InvalidOperationException: The calling thread must be STA, because many UI components require this.
When I use the “latest platform version” – I believe it uses the following?  This one doesn’t publish results:
"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TestWindow\vstest.console.exe"
Version 15.0.26720.2
Error: C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TestWindow\vstest.console.exe failed with return code: 1
2017-09-21T20:29:17.9532729Z ##[warning]Failed to publish test results: '�', hexadecimal value 0x10, is an invalid character. Line 10256, position 10.

@santoorman
For the STA issue, can you please try setting the execution-thread-apartment-state
https://github.com/Microsoft/vstest-docs/blob/master/docs/configure.md#execution-thread-apartment-state

thanks but no go:
2017-09-29T21:22:21.9246859Z Error: Invalid settings 'RunConfiguration'. Unexpected XmlElement: 'ExecutionThreadApartmentState'.
2017-09-29T21:22:21.9246859Z ##[warning]Vstest failed with error. Check logs for failures. There might be failed tests.

.\TestResults
x64
Framework45

also tried to add this in build definition (Override test run parameters):
RunConfiguration.ExecutionThreadApartmentState=STA

This issue was moved to Microsoft/vstest#1164

authors: abhishkk santoorman singhsarab


text:
Accessing Git repo

This is maybe not directly on issue with the tasks but more with the agent. What is the recommended approach to run Git operation during a build?
My use case is that I have a repository utilizing git-lfs. Since VSTS only does a checkout I manually need to call git lfs fetch afterwards. The problem here is the authentication. I want to avoid to have to setup an service account for accessing the repo just for this case. The agent already somehow manages to checkout the repo. Is it possible to use the same approach for additional operations?

The current prepare does it via libgit and uses the generated per build OAuth token sent down to the agent.
That oauth token is available to custom task authors so that's one possibility.
However in the sprint rolling out right now (S92 - in a couple scale units so far), we added a checkbox on the options tab to make the token available to 'ad-hoc scripts'.  This means you trust everyone that can edits your definition :)  It's a variable (can't remember off the top of my head - do a set and inspect)
Now, onto getting git.exe to use it.  There's ASKPASS and credhelpers but those are actually problematic with per build passwords since cred helpers can store and then you don't get called back, then your token for that build expires, next build fails :(
So, one option is to edit your remote.  Call get to set the remote to Ouath:@  At the end of the script you can set it back.
We are contemplating doing what I just mentioned for you as an option.  If we do that (and you check that box), ad-hoc git scripting via cmd files just works.  What won't work is authenticated sub-modules with that approach since the url is embedded in the sub-module ref

Thanks. I will wait for S92 and try the OAuth token / edit remote way.

@bryanmacfarlane I tried to update the git remote using the SYSTEM_ACCESSTOKEN environment variables but couldn't make it work. Did I get it right that I should be able to replace the url of the origin remote (https://mytenant.visualstudio.com/DefaultCollection/MyProject/_git/MyRepo) with the OAuth token like this: https://<Token>@mytenant.visualstudio.com/DefaultCollection/MyProject/_git/MyRepo) and then be able to perform git lfs operations? Unfortunately I still get an "Git credentials not found error"

Needs to be username:password
So use any username like OAuth and then token as password

Thanks, https://OAuth:<Token>@mytenant.visualstudio.com/DefaultCollection/MyProject/_git/MyRepo unfortunately still doesn't work

Hmmm - that's what our xplat agent does.  I'll try it out later.  Until then any other details like the cmds run, output, scripts etc would help

I've written a build task which updates the remote. You can find it in this PR or in this ZIP.
My test build definition is:

The custom build task
A command line task calling git with lfs fetch as argument

Allow Scripts to Access OAuth Token is set in the options. Repository clean is set to true.
The repo contains one binary file which was added with git lfs.
While calling the git lfs fetch it throws the Git credentials for https://mytenant.visualstudio.com/DefaultCollection/MyProject/_git/MyRepo/info/lfs/objects/841e3a4174433932fc9e0a7f506cfda7f240b640199a656632300a971d11bd58 not found. error.
If I manually call git remote -v in the Git repository on the agent after running the build it shows the remotes being updated with username/password.

Just as a test - does it work if it's just gig fetch?  Trying to figure out if it's an lfs thing ...

A git fetch works fine. Seems to be an lfs issue

@bryanmacfarlane I opened a ticket on git-lfs regarding this: github/git-lfs/issues/906

Closing the issue since the VSTS related part seems to work fine with standard Git commands. Lfs related stuff should be handled in github/git-lfs/issues/906.
Thanks @bryanmacfarlane for the help!

As some feedback i think we could have a GetSources as a task,where we have a primary source  but can i have other sources.. TeamCity allows this with multiple VCS roots

@rmarinho agreed. we are working toward that.

@ericsciple is there any reference on VSTS features timeline about it I can look for to know when this will be completed and actually released?

@ggirard07 no but we've been wanting to do it for a long time and we're working a feature now that i think is going to force it (next few months would be my best guess). we've also been making incremental steps along the way to decouple get sources from the agent.
for a workaround today you could clone the repo yourself. if you check Allow scripts access to OAuth token then you can use the token for the Project Collection Build Service identity.

@ericsciple - would you happen to have any additional info on the possibility of VSTS builds being able to checkout multiple git repositories? Would be very nice to have first-class support for this.
Dave Burnison mentions the steps needed to cleanly clone the git repo yourself:

Use a PowerShell task to call a script that:
– Changes directories to the $(build.sourcesDirectory)
– Creates a new folder called “Build” under $(build.sourcesDirectory)
– Changes directories to the $(build.sourcesDirectory)\Build
– Calls “git init”
– Calls “git clone https://VSTSAccountName.visualstudio.com/SomeCollection/Build/_git/BuildUtilsStoredInGit” where the URL points to a Git repository that has a set of scripts that are similar to $/Build/PSScripts in the blog post.
Use additional PowerShell tasks to execute the script(s) as needed from $(build.sourcesDirectory)\Build (e.g. $(build.sourcesDirectory)\Build\PSScripts\ApplyVersionToAssemblies.ps1 )
At the end of your build process add a command line task to call the following command which will remove the local copy of the Git repository
– RmDir /S /Q “$(build.sourcesDirectory)\Build”

(see his 'June 1, 2016 at 8:22 pm' comment here: https://blogs.msdn.microsoft.com/premier_developer/2016/04/13/tips-for-writing-powershell-scripts-to-use-in-build-and-release-tasks/)

It's something we want to do for multiple reasons. It's not next though.

authors: bryanmacfarlane ericsciple fahnzmode ggirard07 pascalberger rmarinho


text:
MsBuild property pointing to InstallDir\MsBuild

Hello,
I have a VSIX that when installed, will install some targets to the [InstallDir]\MsBuild directory:  https://docs.microsoft.com/en-us/visualstudio/extensibility/set-install-root
I then have a project template - I need the project to import the targets from there installed location (i.e the [InstallDir]\MsBuild directory).

  <Import Project="$(WHAT MSBUILD PROPERTY TO USE HERE)\MsBuild\DnnVsProjectSystem.props" />

Any ideas how I can solve this? Can I use vswhere?

I think MSBuildExtensionsPath was what I was looking for!

repo: Microsoft/vswhere


text:
Deprecated

the code doesn't compile and when we change the type to match the API it fail with error code 109 token expired

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3e77d29c-dc31-0a29-3e49-8f14ed2095fd
Version Independent ID: 07f4aa06-335f-9558-0d77-1988683f8ae0
Content: Walkthrough: Bing Ads Desktop Application in Java - Bing Ads
Content Source: BingAds/bingads-12/guides/walkthrough-desktop-application-java.md
Service: bing-ads
GitHub Login: @eric-urban
Microsoft Alias: eur

@scauglog thanks for catching the compile issue. I've fixed it in my local branch, and will refresh the documentation next opportunity.
The 109 error indicates that your access token has expired. You can refresh it using a the previous refresh token.
((OAuthDesktopMobileAuthCodeGrant)(authorizationData.getAuthentication())).requestAccessAndRefreshTokens(refreshToken);

Best regards,
Eric

Hi, great reactivity. I have found that the refresh token problem is due to a mismatch of environment. The code create a OAuthDesktopMobileAuthCodeGrantin Production (line 34) but it create ServiceClient for sandbox (line 88).

@scauglog great feedback, and we'll also update the sample to centralize the environment setting.

authors: eric-urban scauglog

repo: MicrosoftDocs/BingAds-docs


text:
Defender Portal OAuth apps tab moved?

[Enter feedback here]
I am no longer seeing -> "In the Microsoft Defender Portal, under Cloud Apps select OAuth apps."
OAuth apps has disappeared at least from my tenant. Does docs need updating?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3543307c-9c07-720c-e4fe-3aa6cb43f680
Version Independent ID: df363f37-c41a-7493-6573-c7a8f4ff1aaf
Content: Manage OAuth apps - Microsoft Defender for Cloud Apps
Content Source: CloudAppSecurityDocs/manage-app-permissions.md
Service: defender-for-cloud-apps
GitHub Login: @batamig
Microsoft Alias: bagol

Hi @ucgeek, thanks for writing into docs. If you don't see the OAuth apps page, please check for your apps on the App Governance page. For more information, see View your app details with app governance.
We'll check into the documentation to see what needs to be updated. We appreciate your feedback!

This is all I see - no OAuth apps or App Governance:

Hi @ucgeek, in this case, it might be a permissions issue. You can see the roles required for app governance here:
Turn on app governance for Microsoft Defender for Cloud Apps.
If you don't have app governance turned on, I suggest that you open a support ticket so that the support team can help understand your specific scenario.

hi @ucgeek, we've updated this page to clarify issues for when users have preview features and App governance turned on.
However, this may not be relevant if your issue is related to permissions.
I'm closing this issue for now, but feel free to continue commenting if you have more feedback on the docs.
We appreciate your contribution!
#please-close

authors: batamig ucgeek

repo: MicrosoftDocs/CloudAppSecurityDocs


text:
Need Clarification on Code Integrity Protection

The section on Code Integrity doesn't specifically mention the HoloLens 2. Is code integrity protection enabled on the HoloLens 2? Is it configurable via a compliance policy in InTune?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bbc3f4cf-2024-5b09-cde2-db1e0e876286
Version Independent ID: ecbe4837-4f6c-e19d-238d-a426f8d8b86f
Content: Hardware backed integrity and runtime attestation
Content Source: hololens/security-hardware-backed-integrity.md
Product: hololens
Technology: windows
GitHub Login: @evmill
Microsoft Alias: v-evmill

Hello @ARGs-code / Andrew.
There is no way to turn off Code Integrity. Similar to the way HoloLens handles Bitlocker, it is an "always on" style of design. It it not configurable via any means.

authors: ARGs-code evmill

repo: MicrosoftDocs/Hololens


text:
Should this work in the new CORE powershell?

Should this work in the new CORE powershell? I use V7.0.0 and get:
Connect-MsolService: The term 'Connect-MsolService' is not recognized as the name of a cmdlet,

@Ofer-Gal I am looking into the official position now.

@Ofer-Gal I just confirmed that the MSOnline module and "Msol" cmdlets are not supported by PowerShell Core. You need to run them from Windows PowerShell. I will update the Office 365 PowerShell articles for this in the near future. Thanks for your feedback.

authors: JoeDavies-MSFT Ofer-Gal

repo: MicrosoftDocs/OfficeDocs-Enterprise


text:
External O365 users not recieving invitation email

Hi,
I am testing the SP B2B preview.
When I share my file with an external Office365 user, this user doesn't get the invitation e-mail.
In my AAD, the user is added as 'invited user'.
Any idea how to resolve this?
It seems to be happening only when sharing to O365 domains, I've tried multiple.
Kr,
Maarten

@Maartenf2 thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

repo: MicrosoftDocs/OfficeDocs-SharePoint


text:
Missing new parameter

For SPMT release 3.4.120.7 there is mention of a new Start-SPMTMigration parameter -ReplacementOfInvalidChar, however this parameter is not in the cmdlet documentation and does not exist in the cmdlet (installed latest version). What happened?
Thanks
Kevin

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3c911d1d-3570-6e0a-cfa7-77b7516a1f55
Version Independent ID: 261252f1-7191-5be9-a735-cdb307b72a7c
Content: SharePoint Migration Tool (SPMT) Release notes - Migrate to Microsoft 365
Content Source: migration/new-and-improved-features-in-the-sharepoint-migration-tool.md
Service: sharepoint-online
GitHub Login: @JoanneHendrickson
Microsoft Alias: jhendr

@kdavison-uk Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hello @kdavison-uk
Installed the last one and the parameter is not there anymore, seem it was removed later.

authors: get-itips kdavison-uk scanum


text:
Update Asynchronous-metadata-read-api.md

#866
Steps Taken:
Added the following article , as this has an example and explanation about reading Output Parameters of Migration API especially AzureContainerManifest and JobQueueUri
SharePoint Online Migration API
https://github.com/SharePoint/sp-dev-docs/blob/master/docs/apis/migration-api-overview.md
SPO provided Migration Azure container and queue
https://docs.microsoft.com/en-us/sharepoint/dev/apis/migration-api-azure-container-and-queue
Other references:
Site.CreateMigrationJob method
https://docs.microsoft.com/en-us/previous-versions/office/sharepoint-server/mt143031(v=office.15)
OneDrive for Business and SharePoint Online Migration API encryption
https://github.com/SharePoint/sp-dev-docs/blob/master/docs/apis/migration-api-encryption.md

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@JoanneHendrickson Changes look correct. Could you please review and merge? Thanks!

This content needs to stay offline. It is not in the TOC and shouldn't be searchable.

This content is being taken offline.

authors: JoanneHendrickson scanum sukihanabi


text:
The page refers to the fact that Teams Resource account licenses are free of cost. This is not true anymore, only a very limited set of resource accounts are for free.

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 23ff8713-7e33-ad8e-99df-9308a7c006d7
Version Independent ID: c9263eba-599b-831b-37fb-837046df9d6a
Content: Plan for Teams Auto attendants and Call queues - Microsoft Teams
Content Source: Teams/plan-auto-attendant-call-queue.md
Service: msteams
GitHub Login: @DaniEASmith
Microsoft Alias: danismith

I'll propose to clarify that section, thank you

authors: ervalk get-itips


text:
There is no explanation about the accepted SMTP domains of Email integration.

It is necessary to press "space" key when entering domain.
Also, need to turn off the allow setting to enable accepted domain.
Despite the need for complicated operations, the item for this parameter does not exist.
Please describe about the details of Email integration setting.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2c9b7f77-061d-a224-ff1c-8d3e15d21221
Version Independent ID: 00fa9550-c4c4-3398-ffbb-271cc724048f
Content: Manage Microsoft Teams features in your Office 365 organization
Content Source: Teams/enable-features-office-365.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@lyncjp  - Thank you for submitting this feedback.
I was able to get this into the backlog for the Teams team. The team will get this prioritized into a sprint plan. Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@ritika2502 - should we update the article?

Hi @lyncjp hope you are doing great.
Thanks for your comments.
This specific article doesn't mention Accepted Domains, is this maybe the article you are referring to? https://docs.microsoft.com/en-us/microsoftteams/manage-external-access
You can find more information about email integration here https://support.office.com/en-us/article/send-an-email-to-a-channel-in-teams-d91db004-d9d7-4a47-82e6-fb1b16dfd51e
Hope this information has helped  you.

@get-itips  Thank you very much for the contribution and sharing this explanation. @lyncjp
Hope this comment is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

authors: LolaJacobsen MishaTravis get-itips lyncjp yogkumgit


text:
URL broken

Very first URL to the EHLO blog is incorrect, should be https://blogs.technet.microsoft.com/exchange/2019/02/08/retiring-unified-messaging-in-exchange-online/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 63f7281d-e17d-c4e8-ced8-f4d695785e6c
Version Independent ID: 40876324-10aa-e412-e1c2-868d1be2b9b1
Content: Exchange Unified Messaging Online migration support
Content Source: Skype/SfBServer2019/plan/exchange-unified-messaging-online-migration-support.md
Product: skype-for-business-itpro
GitHub Login: @heidip
Microsoft Alias: heidip

Thanks will get this corrected.

@officedocsbot assign @scanum

Hi @TorrenManson
We've verified the very first URL that you've referred in the document and we've found that it has been correctly pointing to the URL as you mentioned in the issue description. Kindly recheck and confirm us to close this issue. Thank you.

Hi,
The URL was fixed on Feb 8th.
You can close this issue.
Thanks,
Torren
From: sowjanya365 notifications@github.com
Sent: March 13, 2019 11:09 PM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness OfficeDocs-SkypeForBusiness@noreply.github.com
Cc: Torren Manson Torren@torren.ca; Mention mention@noreply.github.com
Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] URL broken (#1579)
Hi @TorrenMansonhttps://github.com/TorrenManson
We've verified the very first URL that you've referred in the document and we've found that it has been correctly pointing to the URL as you mentioned in the issue description. Kindly recheck and confirm us to close this issue. Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/1579#issuecomment-472716961, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AF7dv865t69na6pqogoS2nkmy4jGiULYks5vWeeAgaJpZM4axeL8.

Thank you for the confirmation, @TorrenManson.

To be clear, only version SfB/Lync would get impacted due to EXUM online retirement is 2010, right? Lync server 2013 and SfB server 2015 already working with ExUM Online should be still supported with Cloud Voice without any manual intervention, I assume. Would someone please confirm this? Thanks a lot!

@TorrenManson  Thank you for submitting this feedback.
From our understanding the issue has been resolved. If you feel it hasn't been resolved please re-open this issue.

@officedocsbot close


text:
SKU's supported

Teams and M365 Business Voice with guest access is also supported on Essentials.
Guest is a user type in Microsoft Teams that is included with all Office 365 Business Premium, Office 365 Enterprise, and Office 365 Education subscriptions. No additional Office 365 license is necessary. Read more about guest access licensing below.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6f1d577c-1360-c2c1-a850-9ac6a941ec2f
Version Independent ID: 346e43d4-22e0-2800-b80d-9fbdac324f75
Content: Manage guest access in Microsoft Teams - Microsoft Teams
Content Source: Teams/manage-guests.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

@dgordonb Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hi @dgordonb
Thank you for reaching out to us!
Would you be so kind as to elaborate more on this? Are you suggesting us to update the current content? If yes, could you please let us know the content that you want us to update.
Looking forward to your response. Thank you!

Business Voice is also supported on O365 Business Essentials.  Effectively any SKU that includes Teams.
my MS email is dobro@microsoft.com and I work on Business Voice in the Teams engineering team.

Sure, @dgordonb
Thank you for your feedback! We will verify and update the content.

authors: dgordonb scanum sowjanya365


text:
Missing details on the "Automatically Admit people" setting

Missing options - need to add to table

People in my organization, trusted organizations, and guests
Invited Users Only

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4521de2b-1aae-93de-ee1a-222146194700
Version Independent ID: b4f9087c-e1a3-8b47-917c-7c294d46fcca
Content: Manage meeting policies for participants and guests - Microsoft Teams
Content Source: Teams/meeting-policies-participants-and-guests.md
Service: msteams
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Thanks for reporting @danmyhre

authors: danmyhre get-itips scanum


text:
fix: Single value metadata

Ran "Cleanup:Single-value metadata" script from MS Docs Authoring pack

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@CarolynRowe  PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

authors: nschonni scanum


text:
Inconsistency in the Engagement report doc

The Engagement report default value is Off. This is mentioned in the notes of View and download meeting attendance reports in Teams and in Microsoft Teams meeting attendance report. The option is turned off when a new Teams meeting policy is created from Teams admin portal, but Enabled when a new Teams meeting policy is created in PowerShell.

Thank you for the review, @JohanFreelancer9. I'm not sure I'm doing it right, as I only have the 'Close pull request' button available.

Looks like I can't commit. I don't have write access to the repository.

There is a problem with this PR.  The change is inconsistent with the paragraph following the change.
@robertpp Can  you please clarify?
Proposed change says the policy is off by default:
This policy is off by default. If you turn this on, your organizers can see who registered and attended the meetings and webinars they set up. To turn it on in the Teams admin center, go to Meetings > Meeting policies, and set the Engagement report setting to Turn on.
But two paragraphs down still says the parameter is Enabled by default.
By default, the AllowEngagementReport parameter is set to Enabled in PowerShell. To prevent a meeting organizer from downloading the meeting attendance report, set the AllowEngagementReport parameter to Disabled.

If the following is true, then we need to clarify.  Because current change request doesn't clarify the following:  The option is turned off when a new Teams meeting policy is created from Teams admin portal, but Enabled when a new Teams meeting policy is created in PowerShell. I would also follow up with the PMs.  Is this the expected behavior?

Hello @CarolynRowe . This request was due to an incorrect understanding on my side based on incomplete information and erroneous assumptions. There are more details about this on another request.
In summary, the policy is no longer off by default in the Global policy. According to the references mentioned in the first post and internal documentation, this was supposed to be off by default, due to privacy concerns. Something must have changed on how PG regards this feature.
There is also a dependency between the AllowEngagementReport value in the Global policy and the AllowEngagementReport in new meeting policies. All new policies follow the setting in the Global policy if not set. This is not documented anywhere and became the scope of the second GitHub item.
Finally, I made a confusion regarding the 'Turn on' visible in TAC when a new meeting policy is created. I interpreted it as an option to turn on the feature, meaning it is currently turned off, when it actually means the feature is turned on. Probably the best here would be to change 'Turn on' with 'Enabled' and 'Turn off' with 'Disabled', which would match the PS implementation and would prevent confusions, but this is not within the scope of this request.
To conclude, the actual purpose of this item remains alignment of the public documentation with respect to the actual default value of the policy. It turns out the needed change is to update the 2 references in the first post, which continue to state the default is off. At least one of them should probably mention also why such default is not regarded as a concern for privacy, since such default might raise a brow with our GDPR-compliant customers.

@CarolynRowe

authors: CarolynRowe robertpp scanum


text:
Porche EBC

testing Issue automation

Thanks for reporting - this issue is under review.  This is a Microsoft Internal DevOps Bug ID AB#326051

repo: MicrosoftDocs/architecture-center


text:
Spell - Ulta -Update load-balancing-overview.md

Spell

@puluguv : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks for the typo/spelling fix @puluguv

authors: PRMerger17 ktoliver puluguv


text:
[WIP] [ContainersARB] Refresh - Deploy microservices with Azure Container Apps

AFTER YOUR PR HAS BEEN CREATED, expand this section for tips and additional instructions.
These are common guidelines for contributions across the repos managed by the Cloud Architecture Content Team (CACT). Some repositories may have additional specific requirements that are not listed here.
Guidance for all contributors

Topic
Guidance

Draft PR
If your PR will be a work-in-progress for more than a day or two, select the Convert to draft link in the upper right of the page (under Reviewers) to change it to a draft. For future reference, you can also do this using the Create pull request button drop-down during PR creation.

ms.date metadata
Don't update an article's "ms.date" metadata property unless you've done a full freshness review of the content. A full freshness review includes changes required to correct or improve the full technical accuracy of the article.Don't update "ms.date" if you're doing targeted changes to improve non-technical aspects of the article, such as editorial quality, art improvements, article template alignment, etc.If you've changed any "ms.date" properties for work that wasn't part of full review for freshness, please reset them to their previous value.

Placement and linking
If you're creating a new article or articles, include updates to the related TOC.yml file to propose where the article(s) should be placed. Also consider other places within the document set where it would be beneficial to cross-reference and link to your new article(s).

PR build
After you open your PR, and for each successive commit that you push to your branch, the publishing platform will run validation on the files in your pull request. A summary of the build results for each file will be inserted inline into your pull request, which includes any build suggestions/warnings/errors. PRs cannot be merged until all build errors and most warnings are resolved.

Publishing
Following a successful merge, most repos publish to the live site at least once per (business) day, usually around 10am Pacific.

Additional resources
Learn.Microsoft.Com contributor guide

Additional guidance for private repos and internal contributors

Topic
Guidance

PR size
If your PR is more than ~5 lines of changes, or you'd like for the changes to go through editorial or larger review, open a contribution request at https://aka.ms/Contribution and include a link to the PR in response #8. Once it's processed, you'll be notified of the next steps.

PR title prefix
Select the Edit button to the right of the PR title if you need to revise it. The following prefixes are reserved for specific contribution types:[Quality Check] - maintenance work related to content quality (edit passes, art improvements, template alignment)[LinkFix] - recurring/adhoc PRs to correct link URLs[Pipeline] - new/updated contributor success pipeline content[WIP] - a work-in-progress draft requiring several days/weeks

PR preview
Following successful build of your PR, publishable files will also include Preview URL links to staged previews of your new/updated articles. Be sure to review these for verification of your intended contributions, or to send to other internal contributors for review.

PR sign-off (public repo)
If an article you own is updated in a public repo PR, you are responsible for sign-off. You will be automatically notified via email. The PR will not be merged until you've had a chance to review and sign-off.

PR sign-off (private repo)
After you've completed your proposed changes, addressed build warnings, and completed all review work, you can begin the sign-off process for review and merge:If your PR is in draft mode, remove "[WIP]" from the title and select Ready for review button at the bottom of the PR.Enter "#sign-off" in a new comment. This comment indicates that you're confident the work meets or exceeds Microsoft's standards for publication, and will trigger the review process.Your PR may be selected for initial review by the CACT. Following CACT review, you may receive questions or requests for additional changes. You should have initial feedback from CACT review within a few business days. If you have an urgent request or need to contact the team, please mention @MicrosoftDocs/cloud-architecture-content-team-pr-reviewers in your PR and someone will get back to you. After CACT review is complete, a CACT #sign-off will be added.Final review/merge is done by the PR review team. The PR team may also respond with feedback, categorized as "Blocking" (requires action from you), or "Non-blocking" (to be addressed in a future PR).

Additional resources
Learn.Microsoft.Com internal contributor guideAuthoring templates: architecture-center-pr, well-architected-prTo contact the CACT use e-mail, or @mention our GitHub team in your PR comments using: @MicrosoftDocs/cloud-architecture-content-team-pr-reviewers

@cebundy
Can you review the proposed changes?
When the changes are ready for publication and the PR is moved out of DRAFT mode, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Makes sense. The suggestions look good to me.
On Thu, 16 Mar 2023 at 13:55, Catherine Bundy @.***>
wrote:

@.**** requested changes on this pull request.
Hi @rishabhsaha https://github.com/rishabhsaha Looks good. I have just
a few suggestions.
In
docs/example-scenario/serverless/microservices-with-container-apps-content.md
https://github.com/MicrosoftDocs/architecture-center/pull/3955#discussion_r1139045544
:

-- Container Apps supports Azure Active Directory (AD) managed identities allowing your app to easily authenticate other Azure AD-protected resources such as Azure Key Vault, without managing credentials in your container app.  For services that don't support AD authentication, you can store secrets in Azure Key Vault and use a managed identity to access Key Vault to access the secrets.
+- Container Apps supports Azure Active Directory (AD) managed identities allowing your app to easily authenticate other Azure AD-protected resources such as Azure Key Vault, without managing credentials in your container app. A container app can be granted a system assigned identity or an user assigned identity. For services that don't support AD authentication, you can store secrets in Azure Key Vault and use a managed identity to access Key Vault to access the secrets.
⬇ Suggested change
-- Container Apps supports Azure Active Directory (AD) managed identities allowing your app to easily authenticate other Azure AD-protected resources such as Azure Key Vault, without managing credentials in your container app. A container app can be granted a system assigned identity or an user assigned identity. For services that don't support AD authentication, you can store secrets in Azure Key Vault and use a managed identity to access Key Vault to access the secrets.
+- Container Apps supports Azure Active Directory (AD) managed identities allowing your app to easily authenticate other Azure AD-protected resources, such as Azure Key Vault, without managing credentials in your container app. A container app can use system-assigned, user-assigned, or both types of managed identities. For services that don't support AD authentication, you can store secrets in Azure Key Vault and use a managed identity to access Key Vault to access the secrets.

In
docs/example-scenario/serverless/microservices-with-container-apps-content.md
https://github.com/MicrosoftDocs/architecture-center/pull/3955#discussion_r1139147897
:

@@ -164,9 +164,9 @@ Security provides assurances against deliberate attacks and the abuse of your va

Environment variables: sensitive values can be securely stored at the application level.  When environment variables are changed, the container app will spawn a new revision.

-- Network security:  Backend services in the drone delivery app aren't exposed via external ingress. All requests are passed from the Ingestion service through the Azure Service Bus.
+- Network security:  Backend services in the drone delivery app aren't exposed via external ingress. All requests are passed from the Ingestion service through the Azure Service Bus. The Ingestion service is the only service configured with an external ingress. Azure Container Apps run in the context of an environment, which is supported by a virtual network (VNET). When you create an environment, you can provide a custom VNET, otherwise a VNET is automatically generated for you. Generated VNETs are inaccessible to you as they're created in Microsoft's tenant. To take full control over your VNET, provide an existing VNET to Container Apps as you create your environment. Do note in this example a VNET is automatically generated for you which means you can't add custom NSGs or similar. Additional details can be found here.
⬇ Suggested change
-- Network security:  Backend services in the drone delivery app aren't exposed via external ingress. All requests are passed from the Ingestion service through the Azure Service Bus. The Ingestion service is the only service configured with an external ingress. Azure Container Apps run in the context of an environment, which is supported by a virtual network (VNET). When you create an environment, you can provide a custom VNET, otherwise a VNET is automatically generated for you. Generated VNETs are inaccessible to you as they're created in Microsoft's tenant. To take full control over your VNET, provide an existing VNET to Container Apps as you create your environment. Do note in this example a VNET is automatically generated for you which means you can't add custom NSGs or similar. Additional details can be found here.
+- Network security:  To limit external access, only the Ingestion service is configured for external ingress. The backend services are accessible only through the internal virtual network (VNET) in the Container Apps environment. Incoming requests are passed from the Ingestion service to the backend services through the Azure Service Bus. When you create an environment, you can provide a custom VNET; otherwise, a VNET is automatically generated. Generated VNETs are inaccessible to you as they're created in Microsoft's tenant, so you cannot add Azure network security groups (NSGs).  This example uses an automatically generated VNET.   For more information, see  Networking architecture in Azure Container Apps.
The user can set up allow and deny IP restrictions on ingress. So maybe we
just say that they can't add NSGs?
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/architecture-center/pull/3955#pullrequestreview-1344305262,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADBAWALDMPXLX3TKOQ4IGODW4NHYJANCNFSM6AAAAAAV5KVVVE
.
You are receiving this because you were mentioned.Message ID:
@.***>

@rishabhsaha  - Can you commit the requested changes or let us know if you would like us to commit them?
@cebundy  - After the changes are made, please add a sign-off command to signal that the PR is ready to merge.

@rishabhsaha -- in the future, please use architecture-center-pr -- thanks!

@cebundy @ckittel - Let us know if you'd like the PR review team to commit the suggested changes, remove draft mode, and merge. Otherwise, we'll wait for @rishabhsaha to do these tasks.

@ShannonLeavitt Tomorrow is my last day.  So I am fine with you handling the commit and merge.

Yeah, go ahead and commit those changes and then we can do a merge.  Thanks for checking!

@ckittel - Looks like I don't have write access to the file now. @rishabhsaha - Can you commit the changes that @cebundy proposed?

@ckittel - Looks like I don't have write access to the file now. @rishabhsaha - Can you commit the changes that @cebundy proposed?

suggestions applied and committed.

@rishabhsaha - if you can commit the last suggestion i made as well, we can merge this pr. thanks!

@rishabhsaha - nudge. see my previous comment. thanks!

CACT #sign-off

authors: Court72 Jak-MS ShannonLeavitt cebundy ckittel rishabhsaha