text:
Enable EOS and BOS tokens?

Please correct me if I'm wrong, but shouldn't there be a BOS and EOS token enabled for these kinds of tokenization?
https://github.com/Lightning-AI/lit-gpt/blob/91014a7783d83c7dcb745d384a01bedaa7a8799e/scripts/prepare_dolly.py#L116
My thinking is that during inference since the fine-tuned LLM doesn't know that answering a question results in an EOS, the outputs might go on for too long.
Can be resolved by setting eos & bos to true, or making that an argument in these function. If people agree with me, happy to open a PR to amend this for the various tokenization scripts.

Very good point.
I think it depends on the model and tokenizer used. E.g. GPT models don't use BOS or EOS tokens (only <|endoftext|> when concatenating multiple texts).
But I also agree with you and think there should definitely be tokens enabled though, depending on the model.
What we need to do here is probably just extract this info from the tokenizer.json files (see screenshot below from the Llama 2 one, which uses a BOS but not EOS token).
But then, I think it's already being taken care of by the Tokenizer class: https://github.com/Lightning-AI/lit-gpt/blob/91014a7783d83c7dcb745d384a01bedaa7a8799e/scripts/prepare_dolly.py#L51C1-L51C1
Any insights @carmocca ?

Thanks for the quick reply! That’s important surrounding code & configs I missed. Would be curious to hear @carmocca 's thoughts too, because it looks like the tokenizer loads that config, but doesn’t use it for declaring which special tokens to use and not use.
Maybe around here (https://github.com/Lightning-AI/lit-gpt/blob/91014a7783d83c7dcb745d384a01bedaa7a8799e/lit_gpt/tokenizer.py#L33)
There are some lines like:
self.bos = config.get("add_bos_token")
and you can use that for the including these special tokens in the encoding function. Can still enable some sort of override in the encode function too.
One issue with this is I took a look at a Falcon config, and it looks like the info is stored slightly differently :-)
https://huggingface.co/tiiuae/falcon-180B/blob/main/tokenizer_config.json

Finetuning only uses the input_ids field (https://github.com/Lightning-AI/lit-gpt/blob/91014a7783d83c7dcb745d384a01bedaa7a8799e/finetune/lora.py#L283) which does set eos=True (https://github.com/Lightning-AI/lit-gpt/blob/91014a7783d83c7dcb745d384a01bedaa7a8799e/scripts/prepare_dolly.py#L117)
But you are right that we don't use bos by default, whereas HuggingFace does:
from pathlib import Path
from transformers import LlamaTokenizer
from lit_gpt.tokenizer import Tokenizer

prompt = "Hello friends!"

ours = Tokenizer(Path("checkpoints/openlm-research/open_llama_7b"))
print(ours.encode(prompt))

theirs = LlamaTokenizer.from_pretrained("openlm-research/open_llama_7b")
print(theirs.encode(prompt))

And yes, this might need special consideration for the different checkpoints

@carmocca is this a feature you think worth adding to lit-gpt? Glad to volunteer/ submit a PR that makes this special consideration for the different model types, and defaults to not including the BOS (& EOS) token.

Absolutely. However one detail:

defaults to not including the BOS (& EOS) token.

Why would this be? This would be chosen based on the model's tokenizer configuration.

Thanks! And ah that wasn't clear by me, what I meant was if for some reason I can't find whether or not to use the BOS token (like it's not evident to me in the metadata) I will make it so that the default is to have the same behavior as there is now.
Apologies if that's still confusing I hope it will make more sense when I send a PR your way!

authors: carmocca nkasmanoff rasbt

repo: Lightning-AI/lit-gpt


text:
Too much time during next in dataloader

Bug description
during training, I find that the next() in dataloader will spend 10~20s, I already set higher num_worker form 8 to 32, It's still spend long time in load data form dst to  cpu, Can you give me more advice to solve this problem
What version are you seeing the problem on?
v2.1
How to reproduce the bug
Batchsize is 1280, num_worker from 8 to 32

Error messages and logs
# Error messages and logs here please

time spend:
device : 0 , batch_idx: 33 , current_batch_cost_time耗时： 0.8724958896636963
device : 0 , batch_idx: 34 , current_batch_cost_time耗时： 0.857274055480957
device : 0 , batch_idx: 35 , current_batch_cost_time耗时： 0.8920135498046875
device : 0 , batch_idx: 36 , current_batch_cost_time耗时： 0.9099960327148438
device : 0 , batch_idx: 37 , current_batch_cost_time耗时： 0.8724958896636963
device : 0 , batch_idx: 38 , current_batch_cost_time耗时： 0.857274055480957
device : 0 , batch_idx: 39 , current_batch_cost_time耗时： 0.8920135498046875
device : 0 , batch_idx: 40 , current_batch_cost_time耗时： 2.0968360900878906
device : 0 , batch_idx: 41 , current_batch_cost_time耗时： 3.006289005279541
device : 0 , batch_idx: 42 , current_batch_cost_time耗时： 2.6699347496032715
device : 0 , batch_idx: 43 , current_batch_cost_time耗时： 1.8450953960418701
device : 0 , batch_idx: 44 , current_batch_cost_time耗时： 2.9467151165008545
device : 0 , batch_idx: 45 , current_batch_cost_time耗时： 1.0156996250152588
device : 0 , batch_idx: 46 , current_batch_cost_time耗时： 3.1411638259887695
Environment

Current environment
#- Lightning Component (e.g. Trainer, LightningModule, LightningApp, LightningWork, LightningFlow):
#- PyTorch Lightning Version 2.1
#- PyTorch Version 2.1.3
#- Python version 3.9
#- OS (e.g., Linux): linux
#- CUDA/cuDNN version: 11.4
#- GPU models and configuration:
#- How you installed Lightning(`conda`, `pip`, source):
#- Running environment of LightningApp (e.g. local, cloud):

More info
No response
cc @justusschock @awaelchli

@niuliling123 Have you tried just iterating over the dataloader directly and measuring the time, without Lightning Trainer?
t0 = time.time()
for i, batch in enumerate(train_dataloader):
    print(i, time.time() - t0, "seconds")
    t0 = time.time()

If your dataloading code is just slow, then that will explain it. And the only option there is to optimize it. For general implementation help, I suggest posting in the forum or on our Discord.

@niuliling123 Can you take a look at my reply?

Due to lack of response, I'm closing this for now.

t0 = time.time()
for i, batch in enumerate(train_dataloader):
print(i, time.time() - t0, "seconds")
t0 = time.time()    from this, it‘s clearly that the dataloader cost too much time, and somtimes the cost time is very large
like this:
0.00012564659118652344
0.00011205673217773438
0.23346352577209473
0.00016689300537109375

Can you measure the time again, once with DataLoader(num_workers=0) and once with DataLoader(num_workers=4)?

source: gharchive/issue

repo: Lightning-AI/pytorch-lightning

license_type: permissive

license_source: github-api


text:
Point cloud from depth map?

Hi, and thanks for making this code available!
Is it possible to calculate a 3d point cloud from the depth map?
Are the depth maps at consistent, or arbitrary scale?
Thanks again

Arbitrary scale as far as I found.

I would update the focal_length here https://github.com/LiheYoung/Depth-Anything/blob/5935968f82018d68fff44946573d34cdf27db827/metric_depth/evaluate.py#L78
Then use this to get the 3D point cloud: https://github.com/LiheYoung/Depth-Anything/blob/5935968f82018d68fff44946573d34cdf27db827/metric_depth/zoedepth/utils/geometry.py.

Please refer to this discussion: https://github.com/LiheYoung/Depth-Anything/issues/36

authors: 1ssb LiheYoung antithing loevlie

repo: LiheYoung/Depth-Anything


text:
Update Settings “manifest”

Automatically generated by Netlify CMS

👷 Deploy Preview for ekhdmny processing.

Name
Link

🔨 Latest commit
362f314afca087a1542f9ed476d25e202453c412

🔍 Latest deploy log
https://app.netlify.com/sites/ekhdmny/deploys/63833fc70d5b620008557468

source: gharchive/pull-request

license: MIT


text:
b-s-i: No longer builds on armhf and arm64 architectures

./configure --prefix= --datarootdir=/snap/audio-recorder/current/share CC=ccache gcc CXX=ccache g++
make -j4
make install DESTDIR=/build/audio-recorder/parts/audio-recorder/install
Failed to stage: Parts 'desktop-gtk3' and 'audio-recorder' have the following files, but with different contents:
    usr/lib/aarch64-linux-gnu/libxkbcommon.so.0.0.0
    usr/share/doc/libxkbcommon0/changelog.Debian.gz

Snapcraft offers some capabilities to solve this by use of the following keywords:
    - `filesets`
    - `stage`
    - `snap`
    - `organize`

To learn more about these part keywords, run `snapcraft help plugins`.
Build failed

make install DESTDIR=/build/audio-recorder/parts/audio-recorder/install
Failed to stage: Parts 'desktop-gtk3' and 'audio-recorder' have the following files, but with different contents:
    usr/lib/arm-linux-gnueabihf/libxkbcommon.so.0.0.0
    usr/share/doc/libxkbcommon0/changelog.Debian.gz

Snapcraft offers some capabilities to solve this by use of the following keywords:
    - `filesets`
    - `stage`
    - `snap`
    - `organize`

To learn more about these part keywords, run `snapcraft help plugins`.
Build failed

Seems to be fixed, all supported architectures green

repo: Lin-Buo-Ren/audio-recorder-snap


text:
Update getdents_syscall tests and comments

Description
This PR adds comments and tests to getdents_syscall

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Test A - lind_project/tests/test_cases/test_a.c
Test B - lind_project/tests/test_cases/test_b.c

Checklist:

[x] My code follows the style guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been added to a pull request and/or merged in other modules (native-client, lind-glibc, lind-project)

Some weird formatting things that I'd like you to take a quick look at but otherwise this is GTG

repo: Lind-Project/safeposix-rust


text:
🛑 SearXNG is down

In 0fe5612, SearXNG (https://searxng.linerly.tk) was down:

HTTP code: 0
Response time: 0 ms

Resolved: SearXNG is back up in 6d65d65.

repo: Linerly/status


text:
🛑 LinerlyBot (Discord) is down

In f91745a, LinerlyBot (Discord) (https://linerlybot-discord.linerly.tk) was down:

HTTP code: 0
Response time: 0 ms

Resolved: LinerlyBot (Discord) is back up in 76aa689.


text:
🛑 SearXNG is down

In 4d11402, SearXNG (https://searxng.linerly.repl.co) was down:

HTTP code: 0
Response time: 0 ms

Resolved: SearXNG is back up in cf841b6.


text:
[Bug | Regression] Favorites: Add to Fav Icon missing on Product Page

Previously, there was a Fav Icon to the left of the product title on any product page (outline when not added, filled red when added).
Currently this icon is missing and product can't be added to Favs from here.
Also, previously this icon only worked to add products to Favs but not to remove them.
It would be preferable if clicking on a red Fav icon removed the current product from Favs.

Hello,
I've made a lot of changes, I noticed this problem that is already fixed and will soon be updated on the Chrome Web Store.

Figured it's a known issue, wanted to mention it just in case.

Icon is now visible.


text:
Change use of Mycroft JSON config file to a skill-only YAML configuration file

Using Config file with self.config in skills will end with the 19.08 release. Change so that it uses another file if users don't want to use home. The file will be ~/.mycroft/email-skill/email.yml. I will use yaml.
Before 19.08:

[ ] Define self.config  in the skill.

In the Longer Run:

[ ] Change code to use YAML file, over home settings, if existent.

[ ] Keep backwards compatibility with Config file

I might want to have the skill say if the user is using the old config file something like: You are using the old version of configuring the skill on the device. Please go to [insert url here] to learn more.

[ ] Update docs

[ ] Change the config file to the yaml file
[ ] Create a "moving" page which user will land on when directed by the skill (see above)

[ ] Promote change.

Found that I could get around this with the Mycroft Config. just define self.config  My self. However, I should just switch it to yaml because its is nicer.
I'm going to keep the bug label on this issue until I define self.config in the skill.

So what exactly do I have to do to get this skill to work? I've been fighting with this for the last couple days, so any help would be appreciated.

right now, the local configuration isn't working due to some changes made in Mycroft core. This is on my todo list.

Hi @JonahEmbry The skill has been updated to fix this problem, and has been submitted to the market place for review. Once it is accepted, you should use the new docs to configure the skill. Alternatively, just using the home.mycroft.ai settings has been verified to work.


text:
how to train my own darasets?

how to get det1.npy ,det2.npy?
how to train my own darasets?
thanks

Npy files are in ./align. You can get the faces extracted from the process and the way on how to train depends on your model.

authors: Linzaer zhangdengp

repo: Linzaer/Face-Track-Detect-Extract


text:
🛑 PIVX is down

In 6a4c549, PIVX (https://pivx.flitswallet.app/api) was down:

HTTP code: 0
Response time: 0 ms

Resolved: PIVX is back up in 7eae90f.


text:
🛑 SCC is down

In 2f3f362, SCC (https://scc.flitswallet.app/api) was down:

HTTP code: 0
Response time: 0 ms

Resolved: SCC is back up in 46f6f37.


text:
🛑 MERGE is down

In 858271e, MERGE (https://merge.flitswallet.app/api) was down:

HTTP code: 502
Response time: 915 ms

Resolved: MERGE is back up in 798d543.


text:
Can't figure out how to install modules please help

I have tried to follow the big number example but I can't get it to work when i require() in my js code.
I used $npm install bignumber.js
This creates a node_modules folder in my root folder, but when i try to use var BigNumber = require("bignumber.js");
I get the following  error:
E/JSEXCEPTION: Unhandled exception: Error: java.lang.reflect.InvocationTargetException
service.js:2
var BigNumber = require('bignumber.js')
^

this repo seems not maintain anymore

repo: LiquidPlayer/LiquidCore


text:
should do verify when component init

I specified a rule, if the sample field is '', it will produce error, but this rule not works when the component init. Sample
I must manually invoke the verify function now. Sample

This is a feature, not a bug.
The form component usually indicates what went wrong only after the user has entered something, rather than displaying the form screen and popping up a bunch of errors like "required field not filled" immediately afterwards because the form has no input. So by default, slimeform needs to check for valid input only after the content has changed, but you can do this manually at any time.

authors: LemonNekoGH LittleSound

repo: LittleSound/slimeform


text:
suggestion: Purple light recolor TOA

A setting to change the color of the purple chest at the end would be nice.
For example a green light instead of purple when it's in my name.
Very useful in 8man raids.

added in #47

repo: LlemonDuck/tombs-of-amascut


text:
python3.9兼容问题

如图

用了2.6.2 版本 一样的问题，建议增加相关编码处理逻辑

又是python3.9....这个毒瘤版本真的...

我后面想办法把3.9的适配做一下吧，这个版本的语法改动太多了，不好做兼容

嗯嗯 大佬辛苦了

authors: LoRexxar soapffz

repo: LoRexxar/Kunlun-M


text:
Swift 3 / Xcode 8 / Carthage: usable version available soon?

Are there plans to have a working version of this very nice project soon that can be used with Swift 3 and be checkout out via Carthage?
I had a look at #58 but current state doesn't even contain a Xcode project. The Swift 3 branch over at PureJsonSerializer also seems very outdated.
Would be cool to have and working Swift 3 version soon. It's the one thing holding me back from upgrading to Xcode 8.

+1

Hey, I'll be hopping on this more sometime next week. I don't know how Carthage works well enough, does it require an xcodeproj. 3.0 has been building to swift official package manager, but there's less iOS support than I had planned on.
I may need to add project back if that ends up being the case.
Thanks!

Great to know you are on it!
Yes, Carthage needs a Xcode project. In particular a framework target with a shared scheme.
If you need some help let me know. I'm happy to contribute some bits and pieces.

@t-unit I finished the final touches intended, and I've reached a point I feel comfortable calling 3.0. As I mentioned earlier, this is largely structured around SwiftPM, and there are going to be some minor modifications required to make it Cocoapods and Carthage ready.
This work is started here: #68
I have no idea how to begin working on Carthage even, so any help getting it up to spec would be great. There are no longer any dependency requirements necessary, so should be easier to configure in theory.

Basically it is already working. I'm currently testing if there are still some problems.
I did some some small adjustments – #69. Not sure if you actually want to merge them since the whole Xcode project got recreated.

@t-unit That should be ok short term. For Carthage, is the xcproj required to be top level directory?
If no, perhaps we can nest it in a folder and maintain it, then we can leave other project gitignored and generate for dev.
Waiting on Travis, then I'll merge PR and tag 3.0.1

Merged and tagged @t-unit https://github.com/LoganWright/Genome/releases/tag/3.0.1
Thank you for your help 🙌

@LoganWright thanks for merging.
Having the Xcode project file in a subfolder is absolutely no problem (reference). So feel free to move it around.

authors: LoganWright high5code t-unit

repo: LoganWright/Genome

license: mit

license_source: bigquery


text:
Please Register Loot Tables to allow LootTweaker Integration (suggestion)

In developing my modpack I discovered that NetherEX was not registering any loot tables for the mobs it adds. This is an issue because without appropriately registered loot tables the modpack development tool LootTweaker cannot edit the drops for a mob. I would love to use LootTweaker to add drops to the various NetherEX mobs as they make very frightening adversaries and they should have rewards that are appropriate for their difficulty, but unfortunately with unregistered loot tables I cannot do that.
To confirm that this wasn't a mod interaction with another mod in my pack, I made a new instance with the following details:
Minecraft v1.12.2
Forge v14.23.5.2795
CraftTweaker v4.1.13
LibEx v1.0.8
LootTweaker v0.0.8
NetherEX v2.0.8
In this instance, I created a new world and used the command "/ct loottables all" to dump all registered loot tables. I then checked in the "[Instance]\dumps\loot_tables" directory and confirmed that no loot tables were dumped that originated from NetherEX.
In the mean time, if you cannot push an update that registers this mod's loot tables for whatever reason, if you could post the locations of the loot tables within the mod I could potentially use that to hack together a way to edit the loot tables. Currently LootTweaker cannot do this, but in their upcoming 0.0.9 release they're adding a way to edit an unregistered loot table, but only if you already know its directory path. Without knowing where to write to that feature is insufficient - I need your help to find the directory path.
Thank you for your time and understanding.

I also understand that this would help enable integration with Just Enough Resources, a JEI addon that displays monster and chest loot. Like LootTweaker, JER finds the data it displays by using the list of registered loot tables, so if your loot tables are unregistered it cannot detect them. I'm not certain if it's automatic past that point or not, there may be another step, but I know getting the loot table registered is one of the steps.

I'm working on, I hope the PR will be ready soon.

It looks like JER can't read modded mobs' loottables properly, as a guy from ModdedMC Discord told me. And I can't get anything working using jei+jer api.
If you have an example of mod that made custom mob loottables, please tell me

I got it!

I can't get the loottables. When I dump all tables with looktweaker, there is no folder for netherex. Am I doing something differently?

This will be fixed in upcoming release.

repo: LogicTechCorp/NetherEx


text:
Optionally restrict selection to surfaces or edges

"I would like to restrict selection mode to faces only so that I don't accidentally select edges and move those. I like to keep my boxes intact for now. There could be two check boxes to select both or one of the modes."

I will close this ticket once it's available from the asset store

repo: LogicalError/realtime-CSG-for-unity


text:
any

This error occurs when I develop an npm package based on a hook and then reference it in another project:
https://reactjs.org/warnings/invalid-hook-call-warning.html
i find the problem is "You might have more than one copy of React in the same app."

This sounds like you are either bundling React with your npm module (you shouldn’t) or you are using the hook incorrectly.
Specifically re: bundling, this is not something hx can help you with. If you’re using shadow-cljs, I would ask in the #shadow-cljs channel in slack or open an issue.

repo: Lokeh/hx


text:
Run under SYSTEM profile by default

This PR will store data under the SYSTEM profile by default, I feel this is a better stance for servers as opposed to a per user configuration. Additionally, this means tasks are set to run as SYSTEM without requiring the user to be logged on (https://github.com/Lone-Coder/letsencrypt-win-simple/wiki/Windows-Task-Scheduler-Settings), which was in fact the primary goal of this PR.
The current behaviour of user storage and tasks and be enabled using the --user command line option.

With it being a runtime option, it will mess up renewals if someone wants to change it. Renewals themselves are stored via the BaseUri, that's the same with how the renewal task is named. That means that if someone sets it for a single binding, it will overwrite all of the other renewals for that same BaseUri. That's why i'm thinking it would be better as an application setting (app.config) than a runtime option.

There have been some changes since you did your request. Also, after thinking about it, i'm not sure how useful this would really be. There has already been a change to move the certificates to another folder, so this would just be for the registration and signer file and I think those really should be per user not per computer as there could be multiple users on a computer and they will have different email addresses.

repo: Lone-Coder/letsencrypt-win-simple


text:
🛑 jpvir is down

In de747f8, jpvir ($JPVIR) was down:

HTTP code: 0
Response time: 0 ms

Resolved: jpvir is back up in b81a4c7.

repo: LonelyJupiter/UPPTIME


text:
🛑 jpvir is down

In ab0a6d9, jpvir ($JPVIR) was down:

HTTP code: 0
Response time: 0 ms

Resolved: jpvir is back up in 4227175.


text:
🛑 Link Shortener is down

In 113a49a, Link Shortener (https://lr-link.vercel.app) was down:

HTTP code: 504
Response time: 10633 ms

Resolved: Link Shortener is back up in 25a20ae.

repo: LordRonz/status


text:
Fix/bo behaviour

I made several fix for my project:

prevent enter key to submit form on autocomplete.
not display 500 error in BO page if lat and long has missing in BDD value

I propose this PR if this fix you seem useful.
Thanks for this bundle.

Hello there! 😄
Looks good to me. thank you for your contribution!

authors: LordSimal napley

repo: LordSimal/bolt-geolocation-field


text:
开发体验修改建议：通过Msbuild任务来创建mod软链接

建议：
可以通过Msbuild任务来自动创建mod软链接，可以让开发人员即使在删除bin目录时不需要再运行bat文件
缺陷：
由于mklink命令需要windows管理员运行，所以需要用管理员身份启动visual studio

用管理员身份启动visual studio太麻烦了,还是运行下bat算了,方便
谁没事管理员跑vs(

authors: LorisYounger MJEdwin

repo: LorisYounger/VPet


text:
Create action to build project

Use GitHub actions to create builds on pull request and push to master.

The build action is working, so resolving this issue. Thanks @chreden.
https://github.com/LostArtefacts/TR-Rando/actions/runs/4582939322

repo: LostArtefacts/TR-Rando


text:
Focus claimed after each interaction with the page

The canvas claims the focus after each interaction with the page it is embedded in (e.g., typing in an input field).
I suspect that continuously claiming the focus
https://github.com/LuCEresearchlab/react-expression-tree/blob/6836bb2375fa1c3eaf83b5f78835e633bb8d8a08/src/components/ExpressionTreeEditor/ExpressionTreeEditor.jsx#L293-L296
is unnecessary: we only want to react to keyboard events when the component already has the focus.

I did not test this issue yet, but I agree that line 296 should be improved.
Probably we want to create a new flag isSelected, which is set to true when the component is clicked.
Keypress events will work only when the flag is true.
Question:
Can users press keys if isSelected is false, but they are hovering the mouse on the component?
I believe that in some cases this is a needed behavior, but it is not in Expression Tutor. If there is a selected input in the page, there will be issues.
Maybe we should also create a configurable property allowSelectedOnHover which allows the component to automatically be selected when the mouse hovers on the component.

I did not test this issue yet, but I agree that line 296 should be improved.
Probably we want to create a new flag isSelected, which is set to true when the component is clicked.
Keypress events will work only when the flag is true.
Question:
Can users press keys if isSelected is false, but they are hovering the mouse on the component?
I believe that in some cases this is a needed behavior, but it is not in Expression Tutor. If there is a selected input in the page, there will be issues.
Maybe we should also create a configurable property allowSelectedOnHover which allows the component to automatically be selected when the mouse hovers on the component.

I don't think that anybody expects that hovering something (without clicking) grabs the focus. That's just not how users are used to UIs. I'd just fix the issue by removing the annoying behavior for now, and only later if we have time add yet another config.

I don't think that anybody expects that hovering something (without clicking) grabs the focus. That's just not how users are used to UIs. I'd just fix the issue by removing the annoying behavior for now, and only later if we have time add yet another config.

Fixed in b1c2ecc567bcf9b79bed1c2904e9cec64861e388

Fixed in b1c2ecc567bcf9b79bed1c2904e9cec64861e388

authors: lucach thefooly

repo: LuCEresearchlab/react-expression-tree


text:
[9.3.0] Shelf no longer has icon_type, breaks most of getLibrary

Steps to reproduce

Login
getLibrary()
Try to access any section (library.liked_videos, library.playlists_section, etc)

All of the sections return undefined, because the sections don't have the icon_type property anymore, which is being used to identify the section
Failure Logs
N/A

Expected behavior
Sections in Library work as expected
Current behavior
All sections has no types

Version
Default
Anything else?
I guess the ItemSection.target_id (which is target_id or  sectionIdentifier) should be used to identify the the id of these special feeds
Checklist

[X] I am running the latest version.
[X] I checked the documentation and found no answer.
[X] I have searched the existing issues and made sure this is not a duplicate.
[X] I have provided sufficient information.

Now that YouTube no longer has a library, just a "You" page, I say we refactor this to something more generic to avoid things breaking like this in the future..
I think simply exposing contents & header should be enough, and perhaps also a few methods (we can identify them using the browseId) to get all content for some of the shelves.

Now that YouTube no longer has a library, just a "You" page

For me https://www.youtube.com/feed/you and https://www.youtube.com/feed/library look exactly the same

PS: I thought visiting https://www.youtube.com/feed/you would browse FEmy_youtube, but it was doing FElibrary

authors: LuanRT iBicha


text:
Fix bug where tolist was called on a float

Fixes the issue raised in #85

Thank you!

authors: ffelten wilrop

repo: LucasAlegre/morl-baselines


text:
Initial upload

Enjoy

Hello Matias, thank you for the pull request.
Can you please specify the exact part number for the potentiometers used for compatibility with this model? It sounds like the tolerances on your potentiometer are different from mine.

Alright, so after thinking about this for a bit, I think the best way to go about handling promoting modded versions that use different hardware, for now, is for me to make a list of modded versions in the readme, and then linking to the repositories of modded versions. Going to add that list today, and you will be free to PR your link onto the list (so we can make sure you're credited as a contributor).
Thank you so much for making a modded version to support more hardware! I'll get in touch with you soon on discord so we can get you on the list.

authors: MaksimMalygin lucas-vrtech

repo: LucidVR/lucidgloves-hardware


text:
[Snyk] Security upgrade mocha from 10.1.0 to 10.6.0

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):

package.json
package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Cross-site Scripting (XSS) SNYK-JS-SERIALIZEJAVASCRIPT-6147607
  626

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Cross-site Scripting (XSS)

Pull Request Test Coverage Report for Build 9774150548
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 6865373962:
0.0%

Covered Lines:
1504

Relevant Lines:
1504

💛  - Coveralls

authors: LuckyStarry coveralls

repo: LuckyStarry/luckystarry-collections


text:
⚡ v2.8.0

new look Configuration
performance

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


text:
Handle value type variance

It should hold T via P <: U via P for T <: U.
It has to be made sure that when accessing a U via P that is originally a T via P we use the correct peer value cache, namely the one for type T.

I found that we actually don't need type-specific caches. Using one single non-generic cache with Any-typed values while accessing assuming the type on accessing the value reference should be easier. This allows covariance in the value type relying on Scala's type system.


text:
Circle CI failures with circleci/rust

I just started up with Zero2Prod and tried running the provided CircleCI config as-is. It seems that CircleCI's circleci/rust Rust images has been replaced with by the cimg/rust series of images. The result of this seems to be that using the circleci/rust image causes package failures on the build step that require later versions of Rust.
I tried replacing the image using - image: cimg/rust:1.68.0 (just to match the Rust version I have locally), and upon doing so, the Security Step fails on the Cache Permission with the following: ^@^@chown: cannot access '/usr/local/cargo': No such file or directory. I was thinking that maybe in the cimg/rust:1.68.0 image that cargo is installed somewhere else, but since I am working on a Mac machine I can't seem to run the image and inspect much further.
Curious if you have any ideas as to why this might be happening, and how we can resolve it? Once we find a fix then I can open up a PR and make a contribution.
Docker and setting up CI/CD pipelines is new for me, so any advice and tips on debugging would be greatly appreciated!

So I actually ended up fixing this shortly after. What would be the best way to put in a PR for your Gist on the CircleCI config?

If you link the fixed config I can update the gist on my own 👍🏻

https://github.com/DennisTheMenace780/newsletter/blob/master/.circleci/config.yml

Updated!
Thanks again 😁

repo: LukeMathWalker/zero-to-production


text:
Update Rust version in Dockerfile

Description of changes:
Update Rust version in Dockerfile and add a comment to warn people to keep the Rust version in sync.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This has been done 👍🏻


text:
🛑 Bank of China Australia is down

In 55bff53, Bank of China Australia (https://obdevp.bank-of-china.net.au/cds-au/v1/banking/products) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Bank of China Australia is back up in 21c50dc.

repo: LukePrior/OpenBankingUptime


text:
🛑 National Australia Bank is down

In 4076103, National Australia Bank (https://openbank.api.nab.com.au/cds-au/v1/banking/products) was down:

HTTP code: 0
Response time: 0 ms

Resolved: National Australia Bank is back up in 3dde290.


text:
🛑 MOVE Bank is down

In e7ffc65, MOVE Bank (https://api.movebank.com.au/OpenBanking/cds-au/v1/banking/products) was down:

HTTP code: 500
Response time: 17679 ms

Resolved: MOVE Bank is back up in 86bc23e.


text:
Add support for Microsoft Teams

This script is not working in Microsoft Teams or I'm doing something wrong but If i'll paste this code into console in MS Teams it's not working.

Yes, you are doing something wrong. This script is for testportal.net, not for MS Teams.

It's working in Microsoft Teams, don't paste code into console, just follow tutorial.

Go to the Releases page (then download newest version (.zip)) - https://github.com/Lumm1t/anti-testportal/releases/tag/v3.0.0.
Unpack ZIP file.
Go to the extensions page (chrome://extensions or Chrome menu -> More tools -> Extensions).
Enable Developer mode (upper right corner).
Click Load unpacked (or drag the folder anywhere on the page).
Indicate the folder you unpacked.

What do you mean with Microsoft Teams? Tests on it are safe and you can leave page whenever you want.

I mean, It's not working in application.

Of course this is not working in ms teams app, it's browser extension, it's working only in web (http://teams.microsoft.com)


text:
Fix JSON generated on Array2DMatrixToString

A 2D matrix in valid json is [[1,1],[1,1]], while now is represented as [1,1][1,1] which is invalid and jq fails to parse.
This patch fixes it.

Author ceyusa not on autobuild list. Waiting for curator authorization before starting CI build.

Thanks for the clear PR. You can leave out the newline handling ( << GetNewlineString(toStringFlags)) since Convert's JSON generation is at a moment of transition right now where we had decided to be JSON Lines only and formatted JSON can no longer be enabled, but remnants remain.
If you will be making any more substantial commits to Convert, just a heads-up that we are currently integrating and bringing to parity an external contribution of a similar tool, currently named Export in the PR's related to it.

CI gfxreconstruct build queued with queue ID 34681.

CI gfxreconstruct build # 2494 passed.

Author ceyusa not on autobuild list. Waiting for curator authorization before starting CI build.

Manually started CI Build Manual/job/gfxreconstruct/2495/ without trace regression testing for speed of completion given the triviality here.

Patch applied locally and confirmed to fix the JSON output as verified by feeding it through jq and seeing an error before but not after.
Thanks again for catching this!

authors: andrew-lunarg ceyusa ci-tester-lunarg

repo: LunarG/gfxreconstruct


text:
Android VVL Documentation

This PR adds instructions for building gfxrecon-replay with Vulkan Validation Layer support and instructions for enabling validation during replay.

CI gfxreconstruct build queued with queue ID 18798.

CI gfxreconstruct build # 504 running.

CI gfxreconstruct build queued with queue ID 18807.

CI gfxreconstruct build queued with queue ID 18809.

CI gfxreconstruct build queued with queue ID 18815.

CI gfxreconstruct build queued with queue ID 18826.

CI gfxreconstruct build # 508 running.

CI gfxreconstruct build # 508 failed.

CI gfxreconstruct build queued with queue ID 18921.

@patrick-lunarg I think your CI failure is due to an exposure getting to dev before you branched for this PR, and if you rebase on dev again CI will pass.

CI gfxreconstruct build queued with queue ID 19252.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: patrick-lunarg:x: bradgrantham-lunargYou have signed the CLA already but the status is still pending? Let us recheck it.

CI gfxreconstruct build # 514 running.

CI gfxreconstruct build # 514 passed.

CI gfxreconstruct build queued with queue ID 19490.

CI gfxreconstruct build # 520 running.

CI gfxreconstruct build queued with queue ID 19500.

CI gfxreconstruct build # 521 running.

authors: CLAassistant ci-tester-lunarg lunarpapillo patrick-lunarg


text:
🛑 EnderChest（末影箱-云盘） is down

In 300206f, EnderChest（末影箱-云盘） (https://enderchest.anavi.cn) was down:

HTTP code: 0
Response time: 0 ms

Resolved: EnderChest（末影箱-云盘） is back up in ace3d23 after 17 minutes.

repo: LxnChan/status


text:
🛑 Official（泠泫凝的异次元空间-主页） is down

In 1691cfd, Official（泠泫凝的异次元空间-主页） (https://lxnchan.cn) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Official（泠泫凝的异次元空间-主页） is back up in ade37c4 after 5 minutes.


text:
🛑 EnderChest（末影箱-云盘） is down

In 866e56d, EnderChest（末影箱-云盘） (https://enderchest.anavi.cn) was down:

HTTP code: 0
Response time: 0 ms

Resolved: EnderChest（末影箱-云盘） is back up in 59ebfe5 after 206 days, 8 hours, 27 minutes.


text:
🛑 EnderChest（末影箱-云盘） is down

In 6201d04, EnderChest（末影箱-云盘） (https://enderchest.anavi.cn) was down:

HTTP code: 0
Response time: 0 ms

Resolved: EnderChest（末影箱-云盘） is back up in e2b2c3d.


text:
🛑 Official（泠泫凝的异次元空间-主页） is down

In f36f770, Official（泠泫凝的异次元空间-主页） (https://lxnchan.cn) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Official（泠泫凝的异次元空间-主页） is back up in bff8115 after 12 minutes.


text:
🛑 EnderChest（末影箱-云盘） is down

In e948672, EnderChest（末影箱-云盘） (https://enderchest.anavi.cn) was down:

HTTP code: 0
Response time: 0 ms

Resolved: EnderChest（末影箱-云盘） is back up in 038215f after 49 minutes.


text:
🛑 115Wiki is down

In 01c7b8c, 115Wiki (https://115.anavi.cn) was down:

HTTP code: 0
Response time: 0 ms

Resolved: 115Wiki is back up in f18303e.


text:
🛑 EnderChest（末影箱-云盘） is down

In d5cb9de, EnderChest（末影箱-云盘） (https://enderchest.anavi.cn) was down:

HTTP code: 0
Response time: 0 ms

Resolved: EnderChest（末影箱-云盘） is back up in 7b93224.


text:
🛑 Official（泠泫凝的异次元空间-主页） is down

In 2c6f388, Official（泠泫凝的异次元空间-主页） (https://lxnchan.cn) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Official（泠泫凝的异次元空间-主页） is back up in 5efeca6 after 8 minutes.


text:
[Bug Report]

Platform
Windows 24H2
Panel Version
10.4.1
Daemon Version (Optional)
4.5.0
Recurrence Probability
100%
Bug Description
在使用24H2和windos server 2025时，开始运行网页和守护程序时发生闪退。

node version? log?

升级一下MCSM版本，再尝试一下，旧版本的 MCSM 面板对新系统兼容有点问题

在官网下载后修复了，谢谢

repo: MCSManager/MCSManager


text:
WSS and HTTPS

Hello, I noticed this application doesn't like https.
Is there any way to make it work with wss and https so it connects to daemon properly ?
It only works with ws and http. When I connect to the panel via https and go to Applications it shows daemon wss connection error. Setting daemon address like this wss://address in the interface makes daemon status go offline, setting daemon address like this ws://address makes daemon go online but then it doesn't want to connect when you go to Applications.

Are you using Nginx reverse proxy?
You need to enable both Web and Daemon to support ssl, and use the public IP to connect to it in Daemons management (for example: wss://43.123.123.123:23333).

if i directly connect to the Daemon on the browser with link like https://43.123.123.123:8082 (image below) it does gets connected:

but if i put it in the panel like wss://43.123.123.123 with the port 8082, it does not connect, even though the panels is also in https:

authors: alexjabka eyhc1 unitwk


text:
HASTAC admin no longer able to add group members

One of the group admins for the HASTAC Scholars group is experiencing an issue where she is no longer an admin for the group. Based on looking into this further, this may have accidentally been turned into a managed group, which could lead to the issues this user reported, although it's not clear whether this was supposed to be a managed group.
"A user will request to join, I will accept the request, and then it immediately kicks them out of the group after a few seconds. I've been able to work around this when it happens by adding users manually, but that did not work this time - and now it kicked me out of the group too, unfortunately. I can still view the group contents and such though..."

Issue resolved.

repo: MESH-Research/commons


text:
Cleaning in pkg/diagnostics

What changes does this PR introduce?

Cleaner code where main pkg/diagnostics header file DIAGNOSTICS.h is never included outside pkg/diagnostics src files. This is also safer as many variables and storage arrays in DIAGNOSTICS.h are not named with specific pkg/diagnostics suffix.
Small updates to help in tracking issues: specific pkg/diagnostics "debugLevel" ; add new argument to 2 subroutines to identify where they have been called from: this allows to fix debug report to "diagnostics_status" that was overwritten when using ADJ-diags.

What is the current behaviour?

DIAGNOSTICS.h is included outside pkg/diagnostics as parameter  useDiag4AdjOutp is needed in several places. This also requires to include DIAG_OPTIONS.h and DIAGNOSTICS_SIZE.h
"diagnostics_status" files (written when debugLevel is set to 3 or higher) can be overwritten when using ADJ-diags (same file name in forward and backward sweep).

What is the new behaviour?

New header file DIAGNOSTICS_P2SHARE.h, for now just holding useDiag4AdjOutp, intended to included anywhere (and not just inside pkg/diagnostics`).
new argument to S/R DIAGNOSTICS_SWITCH_ONOFF and S/R DIAGNOSTICS_SUMMARY that identifies where S/R is called from, allowing to fix "diagnostics_status" issue.
New parameter diag_dBugLevel (default value: debugLevel) enable to get more debug-print from pkg/diagnostics without all additional debug messages that would come if setting main model debugLevel to the same value.

Does this PR introduce a breaking change?
no.
Other information:
Note: Before the addition of Adj-Diags, DIAGNOSTICS.h was not included outside pkg/diagnostics. This PR restaures a clean separation.
Suggested addition to tag-index
will be added later

The changes in this PR are minor (but still affect a significant number of files). Some issues remains with ADJ-diags (e.g., not working with DIVA) and could be easier to fix once this PR is merge given (a) the fix/improvement in debug-report and (b) the new argument seqFlag that identify where S/R has been called from.

@mjlosch Thanks for the review. I might go towards merging this PR soon, in the coming days, unless someone wants to add something.

repo: MITgcm/MITgcm


text:
Add Linux support

The following functions, get_double_click_interval_seconds and get_double_click_distance_pixels in utils.py only work for Windows and Mac platforms. The goal is to add Linux support as well.
    if hasattr(get_double_click_interval_seconds, "override_value"):
        return get_double_click_interval_seconds.override_value
    if sys.platform == "darwin":
        from AppKit import NSEvent
        return NSEvent.doubleClickInterval()
    elif sys.platform == "win32":
        # https://stackoverflow.com/a/31686041/95989
        from ctypes import windll
        return windll.user32.GetDoubleClickTime() / 1000
    else:
        raise Exception(f"Unsupported {sys.platform=}")

def get_double_click_distance_pixels():
    if sys.platform == "darwin":
        # From https://developer.apple.com/documentation/appkit/nspressgesturerecognizer/1527495-allowablemovement:
        #     The default value of this property is the same as the
        #     double-click distance.
        # TODO: do this more robustly; see:
        # https://forum.xojo.com/t/get-allowed-unit-distance-between-doubleclicks-on-macos/35014/7
        from AppKit import NSPressGestureRecognizer
        return NSPressGestureRecognizer.new().allowableMovement()
    elif sys.platform == "win32":
        import win32api
        import win32con
        x = win32api.GetSystemMetrics(win32con.SM_CXDOUBLECLK)
        y = win32api.GetSystemMetrics(win32con.SM_CYDOUBLECLK)
        if x != y:
            logger.warning(f"{x=} != {y=}")
        return max(x, y)
    else:
        raise Exception(f"Unsupported {sys.platform=}")```

Looks like this might be window-manager specific; see:
https://stackoverflow.com/questions/50868129/how-to-get-double-click-time-interval-value-programmatically-on-linux
https://bbs.archlinux.org/viewtopic.php?id=240001
https://unix.stackexchange.com/questions/45925/how-to-configure-the-double-click-behavior-in-an-x-terminal

We are currently using a modified version of pynput at https://github.com/abrichr/pynput that supports distinguishing between organic and injected input. Last time I checked this was not supported on Linux, but strictly speaking it's not absolutely necessary for our purpose.

authors: Mustaballer abrichr

repo: MLDSAI/OpenAdapt


text:
你好，这个库支持进口电视（例如索尼电视）的投屏吗？

你好，这个库支持进口电视（例如索尼电视）的投屏吗？

现在有一个叫乐播投屏商业化的SDK，支持大部分国产TV，缺点就是不支持进口电视。我们公司就采用了乐播投屏的SDK，总有用户抱怨不能投屏的问题。

@zhang-yong-shuai 请问你有解决索尼投屏的问题吗？我用的Platinum库来投屏，国内电视基本没问题，但是索尼电视初始化投屏时调用SetAVTransportURI(PLT_DeviceDataReference& device, NPT_UInt32 instance_id, const char* uri, const char* metadata, void* userdata)，返回错误，应该是metadata设置为空导致的问题。
参考：https://stackoverflow.com/questions/28422609/how-to-send-setavtransporturi-using-upnp-c
不知道你有没有别的解决方案呢？

@ChippyBiu
MetaData建议参考这个类的代码
CLUPnPRenderer.m
https://github.com/MQL9011/MRDLNA/blob/master/MRDLNA/Classes/ARC/DLNA/CLUPnPRenderer.m

@MQL9011 好的，我去尝试一下，非常感谢。

@ChippyBiu SetAVTransportURI()的metadata参数必须要传拼装好的DIDL，可以自己按照标准格式拼装，或者直接使用DMS配置好的。

@GintokiS 谢谢，用DMS配置好的成功投屏到索尼电视上了，不过投屏到夏普电视上的果果投屏，会导致音画不同步，抓包发现是Subscribe之后，不断地sendMessage，不确定是不是私有协议。

@ChippyBiu SetAVTransportURI()的metadata参数必须要传拼装好的DIDL，可以自己按照标准格式拼装，或者直接使用DMS配置好的。

在哪里可以查找标准格式？我发现有的设备不需要metadata，有的必须要，不同媒体类型的metadata还不一样，有标准格式就好了

@AceLearnGit 暂时没有找到，可以参考GintokiS 的方法。

@YogurtBiu 你好 我编译Platinum遇到点问题能向您请教一下吗

authors: AceLearnGit ChippyBiu GintokiS MQL9011 ShiverZm YogurtBiu zhang-yong-shuai


text:
Share Zen between Party members.

It would be a nice optional feature if implementable, to have ZEN sharing between group members.
Ech Group member gets 1/n part of the zen value and if amount is not splitable without reminder than the player who picked the zen up should get the reminder.

It should already work, because it's implemented in Party.DistributeMoneyAfterKill(...). The players which receive the money must be in range of the killed monster, though.
Can you confirm, that it doesn't work?

repo: MUnique/OpenMU


text:
画面遷移図first

画面遷移図を提出いたします。よろしくお願いいたします。
画面遷移図
Figma: https://www.figma.com/file/2shW2gj4lRB8dpAYwkmW9j/MAO_the_3Days?type=design&node-id=5%3A128&mode=design&t=wvDgJwB2bTFtoRXh-1
README に記載した機能

[x] ユーザー登録機能(SNS 認証)
[x] 生成 AI によるキャラクター（アバター）作成機能
[x] 活動報告とパラメータ変化
[x] 活動履歴確認
[x] 報酬とアイテム購入機能
[x] バトル（簡易）
[x] 他ユーザーの情報確認
[x] LINE 通知
[ ]

未ログインでも閲覧または利用できるページ

[x] 全ページ参照可能。気楽にアプリを触って欲しいため。
ただし未ログイン時は下記の制限を加える
[x] AI 画像生成はあらかじめ用意してある画像からランダムで選択されたもの（無尽蔵な API 使用を防ぎつつ、アプリの雰囲気は理解してもらえる）
[x] 活動のデータベース保存はできない。ただし入力はできるので挙動は確認できる

概ね良いかと思います。LGTMです。

ありがとうございます！


text:
Import using chunks seems to be not working

[BUG] I am following as per the documentation and queue executes fine, but no data after 1st are not stored in to database. Please refer my code below.
Package version: 2.1.0
Laravel version: 5.4.36
Excel::filter('chunk')->load(storage_path('users.csv'))->chunk(250, function($results){
$row_set = $results->toArray();
foreach ($row_set as $key => $row) {
Storage::disk('local')->put(rand(10, 100).'_users.txt', json_encode($row));
}
});
Configurations:
php.ini -> auto_detect_line_endings : true
export.php
force_sheets_collection: true,
QUEUE_DRIVER=database
Please help me to resolve this issue and I spend around 2 days to find a solution in different bug reports and solutions.

I'll ask the most obvious question first, are you sure you have > 250 rows of data in your file?
I would also use a better naming scheme than rand(10, 100), you're sure to get collisions with something that simple.

Yes, there are around 800 records, i used rand(10, 100) to create random
files, but tried to import to DB but the result was same.
On Fri, Dec 8, 2017 at 3:38 AM, Jacobi notifications@github.com wrote:

I'll ask the most obvious question first, are you sure you have > 250 rows
of data in your file?
I would also use a better naming scheme than rand(10, 100), you're sure
to get collisions with something that simple.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Maatwebsite/Laravel-Excel/issues/1450#issuecomment-350109467,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE5f9jF7nUpG6sNcY5dVkFu4E7bCf8qcks5s-GHKgaJpZM4Q1cOr
.

--
Regards,
Muhammad Ali KM
Cell : +919400502367

I am also experiencing the exact same issue.
Did you manage to resolve it?

No, I could not

I manage to get it working. If you make use of chunks then it does not work
on multiple sheets in one excel file.
This worked for me:
Excel::filter('chunk')->selectSheetsByIndex(0)->load($path)->chunk(1000,
function($results)
{
                    //

         });

On Wed, Dec 20, 2017 at 2:24 AM, Muhammad Ali notifications@github.com
wrote:

No, I could not
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Maatwebsite/Laravel-Excel/issues/1450#issuecomment-352927622,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADbzE7NJXx-QrCSbTdzC8tpAkC2bpKQ8ks5tCFOwgaJpZM4Q1cOr
.

authors: jesnasali mariusmow whyayala

repo: Maatwebsite/Laravel-Excel


text:
Using Exportable properties in map and headings methods

PHP version: 7.1.7
Laravel version: 5.6
Package version: 3.0

Description
Is there a way I can use my Exportable Model properties inside headings & map? I trued to call $this->type within those methods and get unknowned property of null error. I want to be able to dynamically change the headers and data based on this certain "type". See below
Code
<?php
namespace App\Exports;

use App\Model\User\User;
use Maatwebsite\Excel\Concerns\FromQuery;
use Maatwebsite\Excel\Concerns\Exportable;
use Maatwebsite\Excel\Concerns\WithMapping;
use Maatwebsite\Excel\Concerns\WithHeadings;
use Illuminate\Queue\SerializesModels;
use Illuminate\Contracts\Queue\ShouldQueue;
use Auth;

class UsersExport implements FromQuery, WithMapping, WithHeadings, ShouldQueue

{
    use Exportable, SerializesModels;

    public function __construct($users, $type)
    {
        $this->users = $users;
        $this->type = $type;
    }

    public function query()
    {
        return $this->users->orderBy('first_name');
    }

    public function map($user): array
    {
        if($this->type == 'client'){
            return [
                $user->first_name,
                $user->last_name,
                $user->email,
                $user->work_phone,
                $user->work_phone_ext,
                $user->cell_phone,
                $user->account_status,
                $user->roles->count() ? $user->roles[0]->name : ''
            ];
        }else{
            return [
                $user->first_name,
                $user->last_name,
                $user->email,
                $user->work_phone,
                $user->work_phone_ext,
                $user->cell_phone,
                $user->account_status,
                $user->roles->count() ? $user->roles[0]->name : '',
                $user->client->name
            ];
        }

    }

    public function headings(): array
    {
        if($this->type == 'client'){
            return [
                'First Name',
                'Last Name',
                'Email',
                'Work Phone',
                'Ext',
                'Cell Phone',
                'Account Status',
                'User Type'
            ];
        }else{
            return [
                'First Name',
                'Last Name',
                'Email',
                'Work Phone',
                'Ext',
                'Cell Phone',
                'Account Status',
                'User Type',
                'Client Name'
            ];
        }

    }

}

Does the developer ever comment on these issues?

Dear Taylor,
Yes, our developers try to help as much as possible. Please read this information: https://laravel-excel.maatwebsite.nl/3.0/getting-started/support.html
If you need elaborate support or need it urgently, we can offer this on a commercial basis. Please contact info@maatwebsite.nl or via phone +31 (0)10 744 9312


text:
[BUG] some records not inserted after 50000 rows

Prerequisites

[X ] Checked if your Laravel Excel version is still supported: https://docs.laravel-excel.com/3.1/getting-started/support.html#supported-versions
[X ] Able to reproduce the behaviour outside of your code, the problem is isolated to Laravel Excel.
[X ] Checked that your issue isn't already filed.
[ X] Checked if no PR was submitted that fixes this problem.
[ X] Filled in the entire issue template

Versions

PHP version: 7.4
Laravel version: 8.12
Package version: 3.1

Description
I faced a problem with excel data (100000 rows) insertion.
the problem is when queue is work, I refresh mysql to show how many records inserted, when it is reach 50000 record it is ok.
form 50000 to 55000, some records not inserted.
For your information I duplicate 50000 record twice.
Here is Import class
class ProductImport implements ToModel, WithBatchInserts, WithChunkReading, ShouldQueue
{

    /**
    * @param array $row
    *
    * @return Product|null
    */
    public function model(array $row)
    {
        return new Product([
            'type_code'     => $row[0],
            'name'          => $row[1],
            'description'   => $row[2],
            'price'         => $row[3],
            'level'         => $row[4],
            'quantity'      => $row[5],
        ]);
    }

    public function chunkSize(): int
    {
        return 5000;
    }

    public function batchSize(): int
    {
        return 5000;
    }
}

What is this issue?
Best regards,

I'm not sure how to help. I'm able to import that many rows, so I'm not able to tell based on your information why it fails for u. Try to monitor your queue and see if it actually continues importing

authors: greatsami patrickbrouwers


text:
Respect of Options Flag

My current command is:
sudo /usr/local/Installomator/patchomator.sh --yes --options IGNORE_APP_STORE_APPS=no BLOCKING_PROCESS_ACTION=silent_fail NOTIFY=silent INTERRUPT_DND=no REOPEN=no PROMPT_TIMEOUT=300 --verbose --write \ --ignored "firefox firefox_da firefox_intl firefoxdeveloperedition firefoxesr firefoxesr_intl firefoxesrpkg firefoxpkg_intl googlechromeenterprise googlechrome microsoftedgeconsumerstable microsoftedgeenterprisestable microsoftonedrive-rollingout microsoftonedrive-rollingoutdeferred microsoftonenotereset microsoftoutlook-monthly microsoftoutlookdataremoval microsoftoutlookreset microsoftpowerpointreset zoomclient zoomgov zoomrooms microsoftteamsclassic microsoftteamsnew googledrivebackupandsync googledrivefilestream"
It doesn't matter where I place --options IGNORE_APP_STORE_APPS=no BLOCKING_PROCESS_ACTION=silent_fail NOTIFY=silent INTERRUPT_DND=no REOPEN=no PROMPT_TIMEOUT=300, `--verbose- always shows:
[NOTICE] Verbose Mode enabled. [NOTICE] Option Count 10 [NOTICE] Installomator Options: [NOTICE]  - IGNORE_APP_STORE_APPS="no" [NOTICE]  - LOGGING="INFO" [NOTICE]  - SYSTEMOWNER="0" [NOTICE]  - NOTIFY_DIALOG="1" [NOTICE]  - NOTIFY="success" [NOTICE]  - INTERRUPT_DND="yes" [NOTICE]  - LOGO="appstore" [NOTICE]  - REOPEN="yes" [NOTICE]  - BLOCKING_PROCESS_ACTION="tell_user" [NOTICE]  - PROMPT_TIMEOUT="86400"
How can I verify the --options I have passed are used by Patchomator?

The challenge is I just want labels generated on devices. Applications shouldn't be installed. However, in testing, I'm getting popups for application update notifications. I thought passing Installomator options would fix this issue, but unfortunately it persists.

installomator options need to be passed all together, inside quotes, each one separated by commas.
so
--options "setting1=yes, setting2=no"

Amazing, thank you so much! That work. I really appreciate all of your hard work on Patchomator!

authors: Mac-Nerd davidkrause-campfire

repo: Mac-Nerd/patchomator


text:
Convert views.py into Views folder.

Views folder should have 2 folders:  class_based and function_based

Resolved.

repo: Macainian/BaseDjangoProject


text:
parsing of HTML file

facing issues with HTML parsing

parsing issues fixed with https://github.com/Madara9744/webmagic/pull/6


text:
🛑 Nitter (nitter.net) is down

In ccbd59f, Nitter (nitter.net) (https://nitter.net) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Nitter (nitter.net) is back up in 88b74ef.

repo: Magic-Services/upptime


text:
🛑 Liberapay is down

In 89bac06, Liberapay (https://liberapay.com) was down:

HTTP code: 502
Response time: 10600 ms

Resolved: Liberapay is back up in cbb01ce.


text:
🛑 Crowdin is down

In 82897f9, Crowdin (https://crowdin.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Crowdin is back up in d3bbe2a.


text:
🛑 Nitter (nitter.net) is down

In 219cd7c, Nitter (nitter.net) (https://nitter.net) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Nitter (nitter.net) is back up in 3c11d20.


text:
Crash on some Windows XP machines

I have a crash that happens only on some Windows XP machines. At the moment the crash is happening on start-up on just one machine that my app is deployed to.
What steps will reproduce this issue?
I can't reproduce the issue locally using a Windows XP VM. I've only seen it happen on a remote point-of-sale machine that I have limited access to.
The crash happens on app start-up, but not every time. Our app is deployed with Click-Once, and starts at login using a short-cut in the user's Startup folder.
The crash seems to be related to loading themes on Windows XP. I have found 2 similar issues on StackOverflow:

WPF Application Ribbon crash
RibbonControlsLibrary XamlParseException issue VS 2010

--
Environment

MahApps.Metro 1.2.4.0 installed from NuGet.
Microsoft Windows XP Professional (I don't have a more accurate version available to me. I should be able to add some additional logging to extract this if needed).
Visual Studio 2015 Update 2 running on AppVeyor
.NET Framework 4 Client Profile

Error
Win32Exception

HRESULT_FROM_WIN32(ERROR_NOT_FOUND)

Trace
XamlParseException: Initialization of 'FlipdishPOSv1.MainWindow' threw an exception.
  Module "FlipdishPOSv1.App", line 12, col 0, in Main
    Void Main()
  Module "System.Windows.Application", line 29, col 0, in Run
    Int32 Run(System.Windows.Window)
  Module "System.Windows.Application", line 225, col 0, in RunInternal
    Int32 RunInternal(System.Windows.Window)
  Module "System.Windows.Application", line 31, col 0, in RunDispatcher
    System.Object RunDispatcher(System.Object)
  Module "System.Windows.Threading.Dispatcher", line 94, col 0, in PushFrame
    Void PushFrame(System.Windows.Threading.DispatcherFrame)
  Module "System.Windows.Threading.Dispatcher", line 74, col 0, in PushFrameImpl
    Void PushFrameImpl(System.Windows.Threading.DispatcherFrame)
  Module "MS.Win32.UnsafeNativeMethods", col 0, in DispatchMessage
  Module "MS.Win32.HwndSubclass", line 280, col 0, in SubclassWndProc
    IntPtr SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr)
  Module "System.Windows.Threading.Dispatcher", line 97, col 0, in InvokeImpl
    System.Object InvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32)
  Module "MS.Internal.Threading.ExceptionFilterHelper", line 2, col 0, in TryCatchWhen
    System.Object TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
  Module "System.Windows.Threading.ExceptionWrapper", line 123, col 0, in InternalRealCall
    System.Object InternalRealCall(System.Delegate, System.Object, Int32)
  Module "MS.Win32.HwndSubclass", line 54, col 0, in DispatcherCallbackOperation
    System.Object DispatcherCallbackOperation(System.Object)
  Module "MS.Win32.HwndWrapper", line 49, col 0, in WndProc
    IntPtr WndProc(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
  Module "System.Windows.Threading.Dispatcher", line 63, col 0, in WndProcHook
    IntPtr WndProcHook(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef)
  Module "System.Windows.Threading.Dispatcher", line 209, col 0, in ProcessQueue
    Void ProcessQueue()
  Module "System.Windows.Threading.DispatcherOperation", line 15, col 0, in Invoke
    System.Object Invoke()
  Module "System.Threading.ExecutionContext", line 0, col 0, in Run
    Void Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
  Module "System.Threading.ExecutionContext", line 134, col 0, in Run
    Void Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
  Module "System.Threading.ExecutionContext", line 50, col 0, in RunInternal
    Void RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
  Module "System.Runtime.CompilerServices.RuntimeHelpers", col 0, in ExecuteCodeWithGuaranteedCleanup
  Module "System.Threading.ExecutionContext", line 24, col 0, in runTryCode
    Void runTryCode(System.Object)
  Module "System.Windows.Threading.DispatcherOperation", line 7, col 0, in InvokeInSecurityContext
    Void InvokeInSecurityContext(System.Object)
  Module "System.Windows.Threading.DispatcherOperation", line 43, col 0, in InvokeImpl
    Void InvokeImpl()
  Module "MS.Internal.Threading.ExceptionFilterHelper", line 2, col 0, in TryCatchWhen
    System.Object TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate)
  Module "System.Windows.Threading.ExceptionWrapper", line 123, col 0, in InternalRealCall
    System.Object InternalRealCall(System.Delegate, System.Object, Int32)
  Module "System.Windows.Application", line 15, col 0, in <.ctor>b__1
    System.Object <.ctor>b__1(System.Object)
  Module "System.Windows.Application", line 31, col 0, in OnStartup
    Void OnStartup(System.Windows.StartupEventArgs)
  Module "FlipdishPOSv1.App", line 184, col 0, in Application_Startup
    Void Application_Startup(System.Object, System.Windows.StartupEventArgs)
  Module "FlipdishPOSv1.MainWindow", line 44, col 0, in .ctor
    Void .ctor(System.Uri, System.Action`1[System.String])
  Module "FlipdishPOSv1.MainWindow", line 28, col 0, in InitializeComponent
    Void InitializeComponent()
  Module "System.Windows.Application", line 358, col 0, in LoadComponent
    Void LoadComponent(System.Object, System.Uri)
  Module "System.Windows.Markup.XamlReader", line 267, col 0, in LoadBaml
    System.Object LoadBaml(System.IO.Stream, System.Windows.Markup.ParserContext, System.Object, Boolean)
  Module "System.Windows.Markup.WpfXamlLoader", line 20, col 0, in LoadBaml
    System.Object LoadBaml(System.Xaml.XamlReader, Boolean, System.Object, System.Xaml.Permissions.XamlAccessLevel, System.Uri)
  Module "System.Windows.Markup.WpfXamlLoader", line 238, col 0, in Load
    System.Object Load(System.Xaml.XamlReader, System.Xaml.IXamlObjectWriterFactory, Boolean, System.Object, System.Xaml.XamlObjectWriterSettings, System.Uri)
  Module "System.Windows.Markup.XamlReader", line 0, col 0, in RewrapException
    Void RewrapException(System.Exception, System.Xaml.IXamlLineInfo, System.Uri)
Win32Exception: HRESULT_FROM_WIN32(ERROR_NOT_FOUND)
  Module "MS.Internal.Xaml.Runtime.ClrObjectRuntime", line 21, col 0, in InitializationGuard
    Void InitializationGuard(System.Xaml.XamlType, System.Object, Boolean)
  Module "System.Windows.FrameworkElement", line 41, col 0, in EndInit
    Void EndInit()
  Module "System.Windows.FrameworkElement", line 44, col 0, in TryFireInitialized
    Void TryFireInitialized()
  Module "System.Windows.FrameworkElement", line 22, col 0, in OnInitialized
    Void OnInitialized(System.EventArgs)
  Module "System.Windows.FrameworkElement", line 18, col 0, in UpdateThemeStyleProperty
    Void UpdateThemeStyleProperty()
  Module "System.Windows.StyleHelper", line 304, col 0, in GetThemeStyle
    System.Windows.Style GetThemeStyle(System.Windows.FrameworkElement, System.Windows.FrameworkContentElement)
  Module "System.Windows.FrameworkElement", line 7, col 0, in OnThemeStyleChanged
    Void OnThemeStyleChanged(System.Windows.DependencyObject, System.Object, System.Object)
  Module "System.Windows.StyleHelper", line 131, col 0, in UpdateThemeStyleCache
    Void UpdateThemeStyleCache(System.Windows.FrameworkElement, System.Windows.FrameworkContentElement, System.Windows.Style, System.Windows.Style, System.Windows.Style ByRef)
  Module "System.Windows.StyleHelper", line 136, col 0, in DoThemeStyleInvalidations
    Void DoThemeStyleInvalidations(System.Windows.FrameworkElement, System.Windows.FrameworkContentElement, System.Windows.Style, System.Windows.Style, System.Windows.Style)
  Module "System.Windows.StyleHelper", line 110, col 0, in InvalidateContainerDependents
    Void InvalidateContainerDependents(System.Windows.DependencyObject, MS.Utility.FrugalStructList`1[System.Windows.ContainerDependent] ByRef, MS.Utility.FrugalStructList`1[System.Windows.ContainerDependent] ByRef, MS.Utility.FrugalStructList`1[System.Wind...
  Module "System.Windows.StyleHelper", line 25, col 0, in ApplyStyleOrTemplateValue
    Void ApplyStyleOrTemplateValue(MS.Internal.FrameworkObject, System.Windows.DependencyProperty)
  Module "System.Windows.DependencyObject", line 1016, col 0, in UpdateEffectiveValue
    System.Windows.UpdateResult UpdateEffectiveValue(System.Windows.EntryIndex, System.Windows.DependencyProperty, System.Windows.PropertyMetadata, System.Windows.EffectiveValueEntry, System.Windows.EffectiveValueEntry ByRef, Boolean, Boolean, System.Window...
  Module "System.Windows.DependencyObject", line 0, col 0, in NotifyPropertyChange
    Void NotifyPropertyChange(System.Windows.DependencyPropertyChangedEventArgs)
  Module "System.Windows.FrameworkElement", line 8, col 0, in OnPropertyChanged
    Void OnPropertyChanged(System.Windows.DependencyPropertyChangedEventArgs)
  Module "System.Windows.DependencyObject", line 106, col 0, in OnPropertyChanged
    Void OnPropertyChanged(System.Windows.DependencyPropertyChangedEventArgs)
  Module "MahApps.Metro.Behaviours.StylizedBehaviors", line 179, col 0, in OnPropertyChanged
    Void OnPropertyChanged(System.Windows.DependencyObject, System.Windows.DependencyPropertyChangedEventArgs)
  Module "System.Windows.FreezableCollection`1", line 14, col 0, in AddHelper
    Int32 AddHelper(T)
  Module "System.Windows.FreezableCollection`1", line 196, col 0, in OnCollectionChanged
    Void OnCollectionChanged(System.Collections.Specialized.NotifyCollectionChangedAction, Int32, T, Int32, T)
  Module "System.Windows.FreezableCollection`1", line 15, col 0, in OnCollectionChanged
    Void OnCollectionChanged(System.Collections.Specialized.NotifyCollectionChangedEventArgs)
  Module "System.Windows.Interactivity.AttachableCollection`1", line 71, col 0, in OnCollectionChanged
    Void OnCollectionChanged(System.Object, System.Collections.Specialized.NotifyCollectionChangedEventArgs)
  Module "System.Windows.Interactivity.BehaviorCollection", line 8, col 0, in ItemAdded
    Void ItemAdded(System.Windows.Interactivity.Behavior)
  Module "System.Windows.Interactivity.Behavior", line 149, col 0, in Attach
    Void Attach(System.Windows.DependencyObject)
  Module "MahApps.Metro.Behaviours.BorderlessWindowBehavior", line 0, col 0, in OnAttached
    Void OnAttached()
  Module "Microsoft.Windows.Shell.WindowChrome", line 6, col 0, in .ctor
    Void .ctor()
  Module "Microsoft.Windows.Shell.SystemParameters2", line 7, col 0, in get_Current
    Microsoft.Windows.Shell.SystemParameters2 get_Current()
  Module "Microsoft.Windows.Shell.SystemParameters2", line 158, col 0, in .ctor
    Void .ctor()
  Module "Microsoft.Windows.Shell.SystemParameters2", line 30, col 0, in _InitializeThemeInfo
    Void _InitializeThemeInfo()
  Module "Standard.NativeMethods", line 60, col 0, in GetCurrentThemeName
    Void GetCurrentThemeName(System.String ByRef, System.String ByRef, System.String ByRef)
  Module "Standard.HRESULT", line 177, col 0, in ThrowIfFailed
    Void ThrowIfFailed(System.String)

This commit should protect against cases where this issue occurs: https://github.com/MahApps/MahApps.Metro/commit/a30ec941b6f425541268b238ef98b26098b868e3
I'll try to repro the issue on Windows XP some more tomorrow.

@marcomorain I added try/catch from original wpf-shell repo 105d9b74dfbf20b547161e87c247cdc2b6a9a6a7

Thanks so much @punker76 :100:


text:
Accent Brush does not change when theme is changed from code

I bumped into an issue and maybe i'm doing it wrong but this is what i experience:
Our application uses the Dark.Blue Theme which is declared in Application.xaml for example:
<ResourceDictionary.MergedDictionaries>
    <ResourceDictionary Source="pack://application:,,,/MahApps.Metro;component/Styles/Themes/Dark.Blue.xaml" />
</ResourceDictionary.MergedDictionaries>

In the MainWindow.xaml we have set the GlowBrush like this:
GlowBrush="{StaticResource MahApps.Brushes.Accent}"

More complete:
<mah:MetroWindow
    x:Class="MainWindow"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:mah="http://metro.mahapps.com/winfx/xaml/controls"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:iconPacks="http://metro.mahapps.com/winfx/xaml/iconpacks"
    xmlns:local="clr-namespace:MyApp"
    xmlns:materialDesign="http://materialdesigninxaml.net/winfx/xaml/themes"
    xmlns:materialDesignConverters="clr-namespace:MaterialDesignThemes.Wpf.Converters;assembly=MaterialDesignThemes.Wpf"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
    Width="1280"
    Height="800"
    MinWidth="1280"
    MinHeight="800"
    AllowsTransparency="True"
    Background="{StaticResource MahApps.Brushes.ThemeBackground}"
    GlowBrush="{StaticResource MahApps.Brushes.Accent}"
    Language="en-EN"
    NonActiveGlowBrush="{StaticResource MahApps.Brushes.Control.Validation}"
    Opacity="0"
    ResizeMode="CanResizeWithGrip"
    ShowCloseButton="False"
    TitleCharacterCasing="Normal"
    WindowStartupLocation="CenterScreen"
    WindowState="Normal"
    mc:Ignorable="d">

              ........ All UI Stuf ........

</mah:MetroWindow>

Now if upon startup a certain condition is met then we change the theme from code, using this:
' Set the application theme to Dark.Green
ThemeManager.Current.ChangeTheme(Me, "Dark.Green")

As described here: Theme Usage
Now this does change the UI to Dark.Green except the GlowBrush stays Blue. This is either because the update of the property isn't notified or the ThemeManager doesn't change the MahApps.Brushes.Accent ? If i change the Application.xaml to use Dark.Green then the MahApps.Brushes.Accent is green.
MahApps.Metro version: v2.4.7
Windows build number: Win10 pro 20H2 [Version 10.0.19042.685]
Visual Studio: 2019 16.11.0
Target Framework: .Net Framework v4.7.2

Doh! I overlooked that GlowBrush has a StaticResource assigned. That's why it didn't change.... For more explanation https://stackoverflow.com/a/200875/4847008

@TripleNico thank you for sharing your own solution 👍

authors: TripleNico timunie


text:
Add a result view for quiz

Maybe there is the need of a ModuleSetting (type "Survey" or "Quiz") - when it is a quiz, there should be a result displayed immediately after the questions are answered, and it should display something like
Question 1
Correct answer: Lorem
Your answer: Lorem :heavy_check_mark:
Question 2
Correct answer: Ipsum
Your answer: Dolor :x:
etc.
Your score:
:white_square_button::white_square_button::white_square_button::white_square_button::white_square_button::white_square_button::white_square_button::black_square_button::black_square_button::black_square_button: 7/10
Well - something like this...

Implemented


text:
Make FactorioServer.Settings use a map instead of a struct

To prevent future Factorio updates breaking the server settings,
use a map to store settings. Also, comments are now preserved and
used as help text in the UI. Note: they are also passed through
the settings form, but hidden. Also improved: error handling/logging in
FactorioServer init and more error checking in the handler.

Awesome those comments in the UI for all the settings is great.
I have still have a bit of work to do to get the server-settings UI in good shape.  Right now I'm having issues with making sure all the different settings stay as the same type but hopefully I'll have a bit of time to work on it soon.

authors: MajorMJR sean-callahan

repo: MajorMJR/factorio-server-manager


text:
[MORPHY] set autosde openapi_client_gem version to 1.1.0

Physical-storage system_type was changesd in autosde from svc to FlashSystems/SVC.
This should also be part of the M release
links
related info about this PR can be found in:
https://github.com/ManageIQ/manageiq-providers-autosde/pull/99
https://github.com/ManageIQ/manageiq-providers-autosde/pull/103

For background, we didn't originally include this enhancement in morphy because the gem introduced a breaking API change that caused the release branches to fail.
AutoSDE team wants this feature backported to the morphy branch so we're going to bump the gem version here

Closing in favor of backporting https://github.com/ManageIQ/manageiq-providers-autosde/pull/99

Using this as the backport PR for #99

authors: Fryguy agrare llivne

repo: ManageIQ/manageiq-providers-autosde


text:
[WIP] Latest docker image is outdated

Latest docker image of MiQ is outdated, does not contain the latest commits, such as "Download as PDF".
About -> Version: master.20160927140428_

@abonas this is not middleware problem, but it blocks QE

cc @karelhala @martinpovolny
I have used: "docker.io/manageiq/manageiq:latest"
About Version is: "master.20160929103631_"

Strange, looks like docker build is fine manageiq/builds but wait for Martin, he'll point you to correct people whom you can ask why is this happening.

Looking for "Download as PDF" functionality to be available on latest.
PR is https://github.com/ManageIQ/manageiq/pull/10942/files

Verified the docker image isn't outdated, the latest image has the latest commit.
The reason for "Download as PDF" not showing up is due to prince RPM not being installed. Once you install the RPM (can't ship with the product for license reason), that item will be available.

@simaishi thank you for the research, closing the issue

authors: hhovsepy karelhala simaishi

repo: ManageIQ/manageiq


text:
Use anonymous classes in tests to avoid constant conflicts

Followup of more tests that were defining a class in a before block and calling remove_const in an after block.  Anonymous classes can do everything needed and not mess with the list of defined constants.

@miq-bot add_label test, refactoring
@jrafanie Please review

gems/pending/spec/util/extensions/miq-module_spec.rb
❗ - Line 24, Col 28 - Style/ExtraSpacing - Unnecessary spacing detected.

@bdunne can you fix that in a follow up PR?

authors: bdunne jrafanie


text:
Externalizing Apache config parameters for 2.4 support

Software Collection Libraries (SCL) install different versions
of Apache in /opt/rh/httpdXX to differentiate the one that ships
with the OS.
These changes externalize the Apache config parameters so that we
can support a different version of Apache other than the standard one
by just changing the /etc/default/evm

@jrafanie @Fryguy @kbrock @brandondunne @gmcculloug
Please Review

@brandondunne and @kbrock can you also please review.

authors: Fryguy mkanoor


text:
Remove unused association

These associations are shadowed by delegations defined few lines
below

@miq-bot add_label refactoring
@miq-bot assign @agrare


text:
Add an ExtManagementSystem#refresh instance method

This PR adds the ExtManagementSystem#refresh instance method. Unlike refresh_ems, this would not be queued.
I've also added a queue_refresh alias for the refresh_ems method to help avoid confusion because IMHO that method name does not make it obvious that the operation  is queued.
I also added some comments and specs.

Strong :+1: for this... I've always wanted this method, and never wrote it myself :)


text:
Convert plugin generator to GitHub Actions

Update the ManageIQ plugin generator to use GitHub Actions.

Overall LGTM - just one question on dynamically generating the ruby version stuff

authors: Fryguy agrare


text:
Tenants API

Resolves https://trello.com/c/QdPWdhWN
@abellotti @gtanzillo please review

@miq-bot add-label core api

@miq-bot add-label enhancement

@miq-bot add-label core, api

looks good @imtayadeway  minor comments, and the rubocop warn. Thanks.

@abellotti addressed your comments and the rubocop offense (and some new rubocop offenses) in subsequent commits. Anything to add?
One thing I meant to bring up yesterday - do the GETs need to have RBAC applied to them? I see that there are roles for lists and shows for tenants, but could not get this to work so left it out.
I'll squash the smaller stuff before this gets merged :)

@h-kataria can you advise on the proper roles for list/show of tenants in the API?

@imtayadeway all the tenant features are listed in miq_product_features.yml, https://github.com/ManageIQ/manageiq/blob/master/db/fixtures/miq_product_features.yml#L2290 for list & show of Tenants you might need rbac_tenant_view feature that allows both rbac_tenant_show_list & rbac_tenant_show features. Let me know if you need more information.

Thanks @h-kataria, that helps.
Added some infrastructure here https://github.com/ManageIQ/manageiq/pull/4754 to support adding RBAC validation for the show/list actions

@abellotti just rebased to incorporate RBAC for GET requests, with added tests

@abellotti just applied your patch and waiting for green. Thanks!

:cake:

authors: abellotti h-kataria imtayadeway


text:
Honor feed_type when updating an RSS widget

On #show RSS widget is considered internal when widget.resource exists.
On #edit RSS widget is considered external when widget.options[:url] exists.
Messy. First step is to ensure data integrity on update.
This addresses broken RSS widget when user changes external to internal
or vice versa.
@miq-bot add_label ui, bug

@gtanzillo @jrafanie please review

@miq-bot add_label wip

Here is some update @jrafanie and @gtanzillo.
This controller is quite complex and randomly moving some parts to model is not possible or it will not buy us much. After discussion with @martinpovolny I have learned that it is like this in any other controller.
There are three shades to the problem

the model is too complex (3 possible sub-types with no clear distinction, no clear integrity boundaries)
data are stored in three places: (1) model, (2) complex hash in session, (3) params
the manipulation of the data is split into multiple routines, each does a little bit to the data

I have learned that I cannot drop the session data until we migrate this to angular (or unless we always send all the params). Looking into the code, I have also learned that the simplifying the manipulation routines will not be easy either.
So, @martinpovolny proposed to convert the hashes to Structs, and then perhaps move some of the logic to the Struct itself. It would look like:
WidgetData = Struct.new(
    :chosen_pivot1,
    :chosen_pivot2,
    :chosen_pivot3,
    :description,
    :enabled,
    :feed_type,
    :fields,
    :filter,
    :groups,
    :pivotby1,
    :pivotby2,
    :pivotby3,
    :pivotby4,
    :repfilter,
    :repfilter_typ,
    :roles,
    :rss_feed_id,
    :row_count,
    :shortcuts,
    :shortcut_keys,
    :start_date,
    :start_hour,
    :start_min,
    :subfilter,
    :txt_url,
    :title,
    :timer_weeks,
    :timer_days,
    :timer_hours,
    :timer_typ,
    :timer_months,
    :url,
    :visibility_typ,
    :wtype
  )

This could be improvement however we would end-up with struct that is not reusable.
So my proposal is to refactor the pieces of the data that are common amongst multiple controller to structs. Then I can decrease the complexity of the controllers by moving some of the data manipulation logic to the specific structs. The candidates would be the timers, visibility, and pivots.
I am looking forward to do this. However, I propose to merge this pr (it is just bugfix with tests) and start the refactoring in the new pr. What do you think?
@miq-bot remove_label wip

The benefit of using a Struct instead of a Hash is that when reading the code or debugging stuff, you actually see what is in the @edit or @new and you know all the valid fields in the Struct unlike Hash keys. Also as you wrote, you can move some basic operations with the structure to the class itself and even test those ;-)
We are attacking this problem from the other side by moving to Angular avoiding the server round trips for field updates and that will move the logic to javascript. So you would be refactoring code that's going to be deleted.

:+1: Agreed, let's not refactor soon to be deleted code. :scissors: :fire:

authors: chessbyte isimluk jrafanie martinpovolny


text:
Don't allow adding duplicate widgets into a dashboard

https://bugzilla.redhat.com/show_bug.cgi?id=1333795

Closing/reopening since #8684 was merged to fix master

@h-kataria Do you think we should get the spinner to come up faster?  Perhaps we can keep this fix, but addresss that as well?

@mzazrivec @dclarizio i agree, we should look into fixing the code so the spinner does not stop until transaction is complete, maybe change https://github.com/ManageIQ/manageiq/blob/master/app/assets/javascripts/miq_application.js#L1576 in miqWidgetToolbarClick JS function to
miqJqueryRequest("/dashboard/widget_add?widget=" + itemId, {beforeSend: true});

Or we can change miqAjax function to receive an additional parameter to substitute the value for 'complete' attribue

@h-kataria Fixed as suggested.

I'm adding WIP, since I need to change the specs.

@miq-bot remove_label wip

Specs updated.

LGTM, verified fix in UI, ready to merge once Travis is green.

authors: dclarizio h-kataria jrafanie mzazrivec


text:
Uses passive listeners to improve scrolling performance

Hi,
First of all - thank you for the nice library!
It seems like there is a small space for improvement. I've been running a website audit using google devtools/Lighthouse and I've got this kind of recommendation:

This is it (Learn more link from the screenshot above): https://developers.google.com/web/tools/lighthouse/audits/passive-event-listeners?utm_source=lighthouse&utm_medium=devtools

Recommendations
Add the passive flag to all of the event listeners that Lighthouse has identified. In general, add the passive flag to every wheel, mousewheel, touchstart, and touchmove event listener that does not call preventDefault().

There are a few event listeners (touchstart and touchmove) in the slideout that do not have passive: true on them. That's what I fix with this PR. I didn't commit compiled files
Audit results after the fix:

Coverage remained the same at 69.88% when pulling 2f15ae8f3d8e6f4203131c35f31a74d4c2eaee08 on alvaxet:touch-performance into 6eb8440ddc7e94194723f86f6580de4d101762a3 on Mango:master.

Why didnt this get merged?

authors: alvaxet coveralls inoas

repo: Mango/slideout


text:
OpenGLSurface  using colorscale changes surface color as it is moved

Description of bug / unexpected behavior

When an OpenGLSurface is created using colorscale the surface changes color as it is moved.
Why is this happening?
When an OpenGLSurface is created using colorscale a copy of the axes the surface is created on is passed to OpenGLSurface to calculate the colors of the surface.  When the surface is moved the colors are recalculated based on that copy of the axes.
Why does OpenGLSurface need a copy of the axes?
Unlike a Surface in Cairo, the points and colors of an OpenGLSurface are recalculated whenever anything about the surface is changed, including movements and rotations.  To recalculate the colors using colorscale, the [x, y, z] values of each point relative to the axes needs to be known.
How do we fix this?
That is what I am asking.  I can submit a PR fixing this issue, but how should it be fixed?  Should we have some sort of pointer to the axes, so that when the colors are refreshed the updated axes is known?  Or should we add a private attribute to OpenGLSurface to keep track of the original [x, y, z] values of the surface relative to the axes?  Are there any other possible solultions?
Expected behavior

The colors of an OpenGLSurface should stay consistent when the surface is moved.
How to reproduce the issue

Code for reproducing the problem
from manim import *
from manim.opengl import *
import numpy as np

class Test(ThreeDScene):
    def construct(self):
        self.set_camera_orientation(phi=75 * DEGREES, theta=-107 * DEGREES)

        axes = ThreeDAxes(
                x_range=[-3, 3, 1],
                y_range=[-3, 3, 1],
                z_range=[-1, 1, 1],
                )

        def func(x, y):
            return np.cos(x) * np.sin(y)

        surface = axes.plot_surface(
            function=func,
            u_range = (-3, 3),
            v_range = (-3, 3),
            resolution = (42, 42),
            fill_opacity = 0.6,
            colorscale = ['#482173', '#2e6f8e', '#29af7f', '#bddf26']
        )

        surface_mobjects = OpenGLGroup(axes, surface)
        surface_mobjects.scale(0.8)

        self.add(surface_mobjects)
        self.play(surface_mobjects.animate.shift(4 * IN))
        self.play(surface_mobjects.animate.shift(8 * OUT))
        self.play(surface_mobjects.animate.shift(4 * IN))

Additional media files

Images/GIFs

https://user-images.githubusercontent.com/79891353/211151769-5c5760f7-6703-4bb8-8e60-1734f2bc44eb.mp4

Logs
Terminal output

PASTE HERE OR PROVIDE LINK TO https://pastebin.com/ OR SIMILAR

System specifications
System Details

OS (with version, e.g., Windows 10 v2004 or macOS 10.15 (Catalina)):
RAM:
Python version (python/py/python3 --version):
Installed modules (provide output from pip list):

PASTE HERE

LaTeX details

LaTeX distribution (e.g. TeX Live 2020):
Installed LaTeX packages:

FFMPEG
Output of ffmpeg -version:
PASTE HERE

Additional comments

This was fixed by #3134.

repo: ManimCommunity/manim


text:
BUG: incorrect generation of missing tiles

During parsing of opera phenix data missing tiles (resulting from a focus failure) should be replaced with black .tifs so that the data can still be stitched and assembled into whole slide images. This seems to be faulty as when trying to stitch data with a missing tile afterwards I get the following error during stitching:
pattern: Timepoint001_Row03_Well01_{channel}_zstack01_r{row:03}_c{col:03}.tif
Output directory at PATH/stitched already exists, overwriting.
Error: Could not read images with the given pattern Timepoint001_Row03_Well01_{channel}_zstack01_r{row:03}_c{col:03}.tif. Please check the path PATH/parsed_images and pattern. Exception: Tiles do not form a full rectangular grid

At the provided location the following files could be found:
['Timepoint001_Row03_Well01_Alexa488_zstack01_r022_c021.tif',
'Timepoint001_Row03_Well01_Alexa488_zstack01_r025_c079.tif',
'Timepoint001_Row03_Well01_Alexa647_zstack01_r041_c163.tif',
'Timepoint001_Row03_Well01_Alexa647_zstack01_r006_c090.tif',
...
]

This turned out to not be an issue with the incorrect generation of missing tiles but an issue with parsing (the process aborted before it completed correctly).
To make troubleshooting of these problems simpler in the future I would implement a function that checks for missing tiles and gives you information on what is missing.

Closing as this has been addressed and currently no issues regarding this problem are known.

repo: MannLabs/scPortrait


text:
Proposition: Generate default value for Observable

Instead of manually patching all directives with a pre-subscription initialization, we can provide a value before the resize event is trigger.

Great, I've seen what you've done and it's a much cleaner way to do this. ; )

Hi,
Yes I wasn't sure it would work at first but yeah it does !
I have only plugged it on the show/hideitbootstrap and on the new ResponsiveSizeInfo directive.

Fixed! Thanks!

authors: ManuCutillas no-more


text:
Typo in viewmodel-property.js

line 271:
isArray(value) must be _.isArray(value)

Fixed on 4.1.3

authors: HatemJerbi ManuelDeLeon

repo: ManuelDeLeon/viewmodel


text:
Bug with markdown

@vinber Can you provide the displayed markdown content?

Ok, found it!

ok but now bug with tittle :)

http://test.rudomap.xyz/t/19c127-Essai_image

Oh crap, my bad ;P
I'm fixing that.

authors: GuillaumeAmat vinber

repo: MapContrib/MapContrib


text:
Mapster IMapper with config fork

How to properly use IMapper (dependency injection) with a config fork?? I have the following class:
`public class Example: IExample
{
#region Variables and Properties
public IAppContext Context { get; }
private readonly IMapper _mapper;

#endregion Variables and Properties

#region Constructors

public Example(IAppContext context, IMapper mapper)
{
    Context = context;
    _mapper = mapper;
}

#endregion Constructors

}`
How to use _mapper with a fork in TypeAdapterConfig?
Thanks.

No way for now, currently a mapper has only one config. Can you provide your use case? So I can see how to support this.

Hi @chaowlert! Thanks for your time. I'll try to explain.
I have configured mapping in Startup (ConfigureServices):
           services.AddSingleton(GetConfiguredMappingConfig());             services.AddScoped<IMapper, ServiceMapper>();
Than I have the GetConfiguredMappingConfig method:
`        private static TypeAdapterConfig GetConfiguredMappingConfig()
{
TypeAdapterConfig config = new TypeAdapterConfig();
        config.Default.PreserveReference(true);
        config.AllowImplicitSourceInheritance = true;
        config.AllowImplicitDestinationInheritance = true;

        // Ignores the TimeStamp field for all mappings
        config.Default.Ignore("TimeStamp");

        config.NewConfig<WBaseEntity, WBaseEntity>()
            .Ignore(dest => dest.Id)
            .Ignore(dest => dest.ChangeDate)
            .Ignore(dest => dest.ChangeUserId);

        config.NewConfig<TimeSpan, uint>()
            .MapWith(s => (uint)Math.Round(s.TotalMinutes));

        config.NewConfig<TimeSpan?, uint?>()
            .MapWith(s => s.HasValue ? (uint)Math.Round(s.Value.TotalMinutes) : null);

        config.NewConfig<uint, TimeSpan>()
            .MapWith(s => TimeSpan.FromMinutes(s));

        config.NewConfig<uint?, TimeSpan?>()
            .MapWith(s => s.HasValue ? TimeSpan.FromMinutes(s.Value) : null);

        config
            .NewConfig<ResourceAvailability, ResourceAvailability>()
            .Map(dest => dest.Id, src => Guid.NewGuid());

        return config;
    }

`
I have this class ResourceAvailability that is not a entity nor a dto. It's a class that I use in a heavy process and I need to constantly make copies of it. I'm using mapster to do that, because a need high performance and mapster is doing great.
In most cases when mapping from a ResourceAvailability to another ResourceAvailability, I need a new Guid for Id field. But in some specific cases, I need to simple copy Id field. That's the reason why I need a difrent config.
Is there a way of doing that?
Thanks.

This is dependency injection topic, not Mapster itself. A lot of DI libraries can solve this problem. If you prefer not to use DI library, you can use Dictionary<string, IMapper> as a factory.
services.AddSingleton(GetConfiguredMappingConfig());
services.AddScoped<IMapper, ServiceMapper>();
services.AddSingleton(provider =>
{
    var copyIdConfig = GetCopyIdConfig();
    var copyIdMapper = new ServiceMapper(provider, copyIdConfig);

    // other mappers here

    return new Dictionary<string, IMapper>
    {
        ["copyId"] = copyIdMapper,
        // other mapper keys
    };
});

Now you can have multiple kinds of IMapper instances.
public MyService(
    IMapper mapper,     // this is default mapper
    Dictionary<string, IMapper> mapperFactory) {

    var copyIdMapper = mapperFactory["copyId"];    // this is copyId mapper
}

authors: adriano-digiere chaowlert

repo: MapsterMapper/Mapster


text:
Fix issue #524 - Added support Update function TDistination in Object Adapter

Fix issue #524
Before:
if Type was packaged into an object:
object _source = new TSource()
Instead of updating with data from TSource, it was converted to the TDistination type
_source.Adapt(_destination) == _source.Adapt<TDistination>

@andrerav  It still doesn't work as it should.
Now it working  this  _source.Adapt<TDestination>().Adapt(TDestination);
There will be problems with updating when the number of fields in the TSource is less than in TDestination

Seems like, It was simply necessary to apply an already developed solution. By adding it to a standard adapter. :)

Hello @andrerav
It looks like the simplest and most correct solution would actually be to use the mechanism from the special overload of the Adapt Method.

In general, the Expression for an adapt is created based on the types of generic arguments.
With this call, generation will always occur for the object type as a TSource or TDestination. Since the generic method was called for them :)
The Received conversion Adapt function is  called with Runtime arguments (variables)  passed for updating.
But since the lambda has already been generated for the Object type, processing for it will occur as an Object.

Therefore, this is not exactly an adapter object problem, as I initially decided.
You just need to initially generate the Adapt function for the type Packed into an object and not the object itself

@andrerav  It looks like now the work on the fix is really complete.
I left the endless loop breaker in both places, for greater reliability ))


text:
Say.js stoped working on Windows 10

Error: At line:1 char:1

    at Socket.<anonymous> (...\node_modules\say\platform\base.js:44:16)
    at Object.onceWrapper (events.js:422:26)
    at Socket.emit (events.js:315:20)
    at addChunk (_stream_readable.js:309:12)
    at readableAddChunk (_stream_readable.js:280:11)
    at Socket.Readable.push (_stream_readable.js:223:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)

That's cool 😆

Same thing happening to me, I have no idea how to fix it

Same thing happening to me, I have no idea how to fix it

just allow threat in windows defender