text:
Target charging cannot be stopped anymore

Describe the bug
With latest master, target charging is always enabled.
To Reproduce
Start latest master, try to remove target charging time - log shows still "target charging active" and GUI shows high grid power draw despite PV mode.
Expected behavior
Target charging can be switched off to get back "regular" behavior.
EVCC details:
Show output of evcc -v:
evcc version 0.62 (3986b75)

Show output of evcc dump -c configfile:
config
======
grid: grid
Power:          -3421W
Current L1..L3: 5.08A 4.15A 5.28A
pv: pv
Power: 3794W
loadpoint 1
charge: warpmeter
Power:          2W
Current L1..L3: 0.03A 0.01A 0.01A
charger: warp
Charge status: B
Enabled:       false

Show evcc log output with --log debug:
[lp-1  ] WARN 2021/09/03 15:18:19 poll mode '{always 2h0m0s}' may deplete your battery or lead to API misuse. USE AT YOUR OWN RISK.
[lp-1  ] INFO 2021/09/03 15:18:19 vehicle updated: unknown -> Zoe
[lp-1  ] DEBUG 2021/09/03 15:18:21 max charge current: 7A
[lp-1  ] INFO 2021/09/03 15:18:21 loadpoint 1:
[lp-1  ] INFO 2021/09/03 15:18:21   mode:      pv
[lp-1  ] INFO 2021/09/03 15:18:21   charger:   power ✗ energy ✗ currents ✗ timer ✗
[lp-1  ] INFO 2021/09/03 15:18:21   meters:    charge ✓
[lp-1  ] INFO 2021/09/03 15:18:21     charge:  power ✓ energy ✗ currents ✓
[lp-1  ] INFO 2021/09/03 15:18:21   vehicles:  ✓
[lp-1  ] INFO 2021/09/03 15:18:21     car 0:   range ✓ finish ✓ status ✓ climate ✓
[lp-1  ] DEBUG 2021/09/03 15:18:32 charge power: 2W
[lp-1  ] DEBUG 2021/09/03 15:18:32 charge currents: [6.96 6.94 6.95]A
[lp-1  ] DEBUG 2021/09/03 15:18:32 charger status: C
[lp-1  ] INFO 2021/09/03 15:18:32 start charging ->
[push  ] ERROR 2021/09/03 15:18:32 invalid message template for start: wanted: [socCharge], got: [vehiclePresent minCurrent siteTitle connectedDuration gridCurrents chargeCurrents minSoC vehicleCapacity title pvPower enabled batteryConfigured charging hasVehicle gridPower chargeDuration vehicleTitle chargeCurrent chargeConfigured gridConfigured phases chargedEnergy pvConfigured activePhases chargePower maxCurrent connected targetSoC mode]
[lp-1  ] DEBUG 2021/09/03 15:18:33 vehicle soc: 77%
[lp-1  ] DEBUG 2021/09/03 15:18:33 vehicle range: 274km
[lp-1  ] DEBUG 2021/09/03 15:18:35 target charging active for 0001-01-01 00:00:00 +0000 UTC: projected 2021-09-03 15:19:00 +0200 CEST (0s remaining)
[lp-1  ] DEBUG 2021/09/03 15:18:35 target charging: speedup (23A)
[lp-1  ] DEBUG 2021/09/03 15:18:35 max charge current: 23A
[lp-1  ] DEBUG 2021/09/03 15:18:35 charge power: 2W
[lp-1  ] DEBUG 2021/09/03 15:18:35 charge currents: [6.96 6.94 6.95]A
[lp-1  ] DEBUG 2021/09/03 15:18:35 detected phases: 3p [6.96 6.94 6.95]A
[lp-1  ] DEBUG 2021/09/03 15:18:35 charger status: C
[lp-1  ] DEBUG 2021/09/03 15:18:35 next soc poll remaining time: 1h59m57s
[lp-1  ] DEBUG 2021/09/03 15:18:35 vehicle soc: 77%
[lp-1  ] DEBUG 2021/09/03 15:18:35 vehicle range: 274km
[lp-1  ] DEBUG 2021/09/03 15:18:37 target charging: speedup (23A)
[lp-1  ] DEBUG 2021/09/03 15:18:38 charge power: 12471W
[lp-1  ] DEBUG 2021/09/03 15:18:38 charge currents: [17.1 17.1 17]A
[lp-1  ] DEBUG 2021/09/03 15:18:38 detected phases: 3p [17.1 17.1 17]A
[lp-1  ] DEBUG 2021/09/03 15:18:38 charger status: C
[lp-1  ] DEBUG 2021/09/03 15:18:38 next soc poll remaining time: 1h59m57s
[lp-1  ] DEBUG 2021/09/03 15:18:38 vehicle soc: 77%
[lp-1  ] DEBUG 2021/09/03 15:18:38 vehicle range: 274km
[lp-1  ] DEBUG 2021/09/03 15:18:40 target charging: speedup (23A)
[lp-1  ] DEBUG 2021/09/03 15:18:41 charge power: 15723W
[lp-1  ] DEBUG 2021/09/03 15:18:42 charge currents: [21.9 21.9 21.8]A
[lp-1  ] DEBUG 2021/09/03 15:18:42 detected phases: 3p [21.9 21.9 21.8]A
[lp-1  ] DEBUG 2021/09/03 15:18:42 charger status: C
[lp-1  ] DEBUG 2021/09/03 15:18:42 next soc poll remaining time: 1h59m56s
[lp-1  ] DEBUG 2021/09/03 15:18:42 vehicle soc: 77%
[lp-1  ] DEBUG 2021/09/03 15:18:42 vehicle range: 274km
[lp-1  ] DEBUG 2021/09/03 15:18:44 target charging: speedup (23A)
[lp-1  ] DEBUG 2021/09/03 15:18:46 charge power: 15717W
[lp-1  ] DEBUG 2021/09/03 15:18:47 charge currents: [21.9 21.9 21.8]A
[lp-1  ] DEBUG 2021/09/03 15:18:47 detected phases: 3p [21.9 21.9 21.8]A
[lp-1  ] DEBUG 2021/09/03 15:18:47 charger status: C
[lp-1  ] DEBUG 2021/09/03 15:18:47 next soc poll remaining time: 1h59m55s
[lp-1  ] DEBUG 2021/09/03 15:18:47 vehicle soc: 77%
[lp-1  ] DEBUG 2021/09/03 15:18:47 vehicle range: 274km
[lp-1  ] INFO 2021/09/03 15:18:48 set target charge: 85 @ 1970-01-01 01:00:00 +0100 CET
--> at 2021/09/03 15:18:48 another attempt at deleting target charging date was made

Hello,
I have exactly the same issue. I activated target mode yesterday evening for today 7:30 which worked fine, but from that point on the evcc started to charge with full power not recognizing the pv mode nor the power coming from pv. It pulled grid power for the rest.

Will take a look tomorrow. Goal is to fix this before the next release

I have a similar problem, when starting evcc  charching target 0001-01-01 is set and charging starts immedialty with max power.
[site  ] DEBUG 2021/09/04 10:52:31 pv power: 1608W
[site  ] DEBUG 2021/09/04 10:52:31 grid power: -564W
[site  ] DEBUG 2021/09/04 10:52:31 site power: -564W       <-- this is below pv start power, charching should not start
[lp-1  ] DEBUG 2021/09/04 10:52:31 charge power: 0W
[lp-1  ] DEBUG 2021/09/04 10:52:31 charge currents: [0 0 0]A
[lp-1  ] DEBUG 2021/09/04 10:52:31 charger status: B
[lp-1  ] DEBUG 2021/09/04 10:52:32 vehicle soc: 22%
[lp-1  ] DEBUG 2021/09/04 10:52:32 vehicle range: 5km
[lp-1  ] DEBUG 2021/09/04 10:52:32 target charging active for 0001-01-01 00:00:00 +0000 UTC: projected 2021-09-04 10:53:00 +0200 CEST (0s remaining)                     <--- default startup value is long ago
[lp-1  ] DEBUG 2021/09/04 10:52:32 target charging: speedup (16A)
[lp-1  ] DEBUG 2021/09/04 10:52:32 max charge current: 16A
[lp-1  ] DEBUG 2021/09/04 10:52:32 charger enable                   <--- we are above min soc, below pv enable threshold, charger should not start!
[site  ] DEBUG 2021/09/04 10:52:41 ----
[site  ] DEBUG 2021/09/04 10:52:41 pv power: 1603W
[site  ] DEBUG 2021/09/04 10:52:41 grid power: -699W
[site  ] DEBUG 2021/09/04 10:52:41 site power: -699W
[lp-1  ] DEBUG 2021/09/04 10:52:41 charge power: 2870W
[lp-1  ] DEBUG 2021/09/04 10:52:41 charge currents: [12.7 0 0]A
[lp-1  ] DEBUG 2021/09/04 10:52:42 charger status: C
[lp-1  ] DEBUG 2021/09/04 10:52:42 charge start energy: 128kWh
[lp-1  ] INFO 2021/09/04 10:52:42 start charging ->
[lp-1  ] DEBUG 2021/09/04 10:52:42 soc estimated: 22.00% (vehicle: 22.00%)
[lp-1  ] DEBUG 2021/09/04 10:52:42 vehicle soc: 22%
[lp-1  ] DEBUG 2021/09/04 10:52:42 vehicle range: 5km
[lp-1  ] DEBUG 2021/09/04 10:52:42 target charging: speedup (16A)    <- charges with max power, but should be disabled. Power does not decrease over time
[site  ] DEBUG 2021/09/04 10:52:51 ----
[site  ] DEBUG 2021/09/04 10:52:51 pv power: 1604W
[site  ] DEBUG 2021/09/04 10:52:51 grid power: 2115W
[site  ] DEBUG 2021/09/04 10:52:51 site power: 2115W
[lp-1  ] DEBUG 2021/09/04 10:52:52 charge power: 3300W
[lp-1  ] DEBUG 2021/09/04 10:52:52 charge currents: [14.5 0 0]A
[lp-1  ] DEBUG 2021/09/04 10:52:52 detected phases: 1p [14.5 0 0]A
[lp-1  ] DEBUG 2021/09/04 10:52:52 charger status: C
[lp-1  ] DEBUG 2021/09/04 10:52:52 soc estimated: 22.13% (vehicle: 22.00%)

Zielladen ist momentan kaputt. Ich muss mir das nochmal ganz in Ruhe anschauen...

Ich mache mal zu. Das akute Problem ist behoben, Zielladen bekommt nochmal einen Neustart wenn wir soweit sind.

authors: Alestrix andig bacanol schenlap

repo: evcc-io/evcc


text:
Don't show phase timer when already 3p

After restart, WB was already running on 3p (detected phases):
[site  ] DEBUG 2023/06/12 11:25:57 pv power: 4896W
[site  ] DEBUG 2023/06/12 11:25:57 grid power: -359W
[site  ] DEBUG 2023/06/12 11:25:57 site power: -359W
[lp-1  ] DEBUG 2023/06/12 11:25:57 charge currents: [6.05 5.75 5.4]A
[lp-1  ] DEBUG 2023/06/12 11:25:57 detected active phases: 3p
[lp-1  ] DEBUG 2023/06/12 11:25:57 charge meter total import: 1853.045kWh
[lp-1  ] DEBUG 2023/06/12 11:25:57 charger status: C
[lp-1  ] DEBUG 2023/06/12 11:25:57 vehicle soc: 92%
[lp-1  ] DEBUG 2023/06/12 11:25:57 available power 4300W > 4140W min 3p threshold
[lp-1  ] DEBUG 2023/06/12 11:25:57 phase scale3p in 31s
[lp-1  ] DEBUG 2023/06/12 11:25:57 pv charge current: 6.52A = 6A + 0.521A (-359W @ 3p)

Still phase timer is running.

Aktuell keine Priorität, closing.

source: gharchive/issue

license: MIT

license_type: permissive

license_source: github-api


text:
🛑 /getCommentsByUrl - Get comments list by video URL is down

In 7a6c246, /getCommentsByUrl - Get comments list by video URL (https://tiktok.evelode.com/getCommentsByUrl?video_url=https%3A%2F%2Fwww.tiktok.com%2F%40onerepublic%2Fvideo%2F7141505394869898538%3Fis_copy_url%3D1%26is_from_webapp%3Dv1&cache_timeout=0&license_key=$API_KEY) was down:

HTTP code: 400
Response time: 10173 ms

Resolved: /getCommentsByUrl - Get comments list by video URL is back up in 9c49b8f after 5 minutes.

repo: evelode/tiktok-status


text:
ECO codes https://github.com/evidenceontology do not have a grouping designation

ECO codes https://github.com/evidenceontology do not have a grouping designation
These ECO codes are seen in gpa files from ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/ and https://github.com/evidenceontology/evidenceontology/blob/master/eco-basic.obo, but not seen in https://github.com/evidenceontology/evidenceontology/blob/master/gaf-eco-mapping-derived.txt:
**ERROR:     14,035 INSTANCES OF ECO:0005547 IN GPAs
**ERROR:      3,390 INSTANCES OF ECO:0005544 IN GPAs
**ERROR:        712 INSTANCES OF ECO:0005546 IN GPAs
**ERROR:        470 INSTANCES OF ECO:0005610 IN GPAs
**ERROR:        152 INSTANCES OF ECO:0005543 IN GPAs

Is it expected that some ECO codes will have no group designation, such as ISA, IEA, ISS, etc.?
Many researchers use the grouping designation, rather than the ECO codes. If some ECO codes have no grouping designation, then we need to update our annotation file readers to reflect this. Currently, there are only five ECO codes that have no grouping designation.
FYI, these annotation files contain ECO codes that do not exist in the ECO definition file:
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/ARABIDOPSIS/goa_arabidopsis.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/CHICKEN/goa_chicken.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/COW/goa_cow.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/FLY/goa_fly.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/HUMAN/goa_human.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/MOUSE/goa_mouse.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/PIG/goa_pig.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/RAT/goa_rat.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/WORM/goa_worm.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/YEAST/goa_yeast.gpa.gz
  ftp://ftp.ebi.ac.uk/pub/databases/GO/goa/ZEBRAFISH/goa_zebrafish.gpa.gz

Additional context
All files downloaded Dec 21, 2021
https://github.com/geneontology/helpdesk/issues/372

Hello,
These 5 terms should map to the GO evidence code IC.
We were asked to wait to make a mapping update until after the December GO release - but that has now happened so we will update these soon and push a new version of the derived file.
looping in @nsuvarnaiari

Hello again,
We are planning to push a new release of ECO and the derived file during the first week of January.
Is that soon enough to meet your needs?
Also, I realized that I didn't reply to one of your questions. In fact, not all ECO terms will map to a GO evidence code (as not all ECO terms contain evidence types that are covered by a GO evidence code), however we endeavor to make it such that all ECO terms that are relevant to a GO evidence code do have those mappings.
Michelle

Hello,
The new mappings for the above terms are in the latest ECO release.
I'm going to close this issue. But please reopen if you have further questions or concerns.
Regards,
Michelle

repo: evidenceontology/evidenceontology


text:
:bug: Fix(unplugin): strangling console.log

Description
Strangling console.log

Current dependencies on/for this PR:

main

PR #726   👈

This stack of pull requests is managed by Graphite.

source: gharchive/pull-request

repo: evmts/evmts-monorepo


text:
Add info how to fill invitation form

Alexander

Add advice how to fill Aufenthaltstitel field inside invitation form.
В процессе заполнение анкеты возникли вопросы c полем Identitätsdokument. В данном PR показано как правильно заполнять это поле. Проверено на личном опыте.
Возможно информация будет полезна тем, кто будет заполнять после меня.

Alexey

mr-mig approved these changes a day ago View changes
Подтверждаю: в одном случае к отсутствию информации о двух документах конкретно придрались.
Во втором случае напомнили, что нужно указывать оба документа

спасибо @alexandr-g

authors: alexandr-g ewgRa

license: mit

license_source: bigquery


text:
Keyboard Shortcut to Pause autocomplete?

Is there a key binding or a way to key bind to pause the autocomplete?

Was about to ask this question


text:
[Maybe] Add rotation

Zwibbler allows you to rotate all the elements. I'm not sure I've ever used it and it's been more annoying in my experience. Creating an issue to think about it

In my opinion I’d only implement this for the arrow since I’m not sure that rotating other shapes would be useful

Arrow don't need to be rotated (in what I had in mind for this PR), changing the two end points would work just fine (basically resizing).

Rotating other shapes, namely rectangle, can be useful to create diamond shapes for conditional logic diagrams.

We could add support for diamond directly as well

Would be nice to rotate shapes :)

There are some shapes that would be nice to have rotated, adding shapes instead of adding a simple rotate feature seems off.

@GrimTheReaper do you have concrete examples?

@vjeux concrete examples of what? Implementing a rotate feature or the fact that most shape editors have a rotate feature? Also on another note, can you even make the excalidraw logo in excalidraw?

My mental process for building product is to ask why people want a certain feature, in many cases there's actually a better solution to solve their problem. For example if you want to make a diamond, it's convoluted to draw a square and then rotate it.
It doesn't mean that we shouldn't implement rotate, I'm just curious what use cases people have with it. It's not a trivial feature to implement so if we can get away without it that would be nice :)

What if, I wanted to have an offset diamond? inbetween 45 and 90

@GrimTheReaper yeah, you'd need rotation for it. Is this something you actually wanted to do in practice?

@vjeux realistically, probably not that specific example. But I feel that a better rational for adding it is the fact that without it, shapes can be more limited in terms of being on the canvas. While I fail to better articulate this fact, I feel that adding it would be substantial while being a little more trivial.

Let's keep this open for now until we polish up what we have so far, or until someone comes here with a dire need :).

Just to be clear, if someone implements it that would be a welcome addition. But it’s not at a very high priority.

Fine by me, I just wanted to make sure it would be on a roadmap somewhere.

I think it might be nice to have preset rotations for each shape.
So rectangles, diamonds, ellipses, and lines don't need them.
But as soon as they're more polygons like triangles (△, ▹, ◸, +) and hexagons (⬡,⎔), rotation becomes the easiest way to configure it.

^ Same need. I'd like to align text with some arrows that aren't flat basically.

Text rotation + rectangle rotation is something that I've run into wanting so just wanted to add my use case.
I am not sure what industry or what purpose everyone is using the tool for but for me I stumbled across it from HN  and so far have liked using it for Mechanical Engineering purposes. Specifically, I really like it for brainstorming and quick drawings of Free Body Diagrams.
So for instance, the drawing in wikipedia for the FBD page can be done with a diamond if you only want it to be a square and at a perfect 45 degree ramp (as shown), but this is idealistic.  Any other example becomes harder to illustrate.

Here it is, drawn in Excalibur (notice how I had to do a 45 degree incline plane, no text rotated, etc.)

That's a great use case! We should add rotation

It's finally released! Enjoy..

authors: Fausto95 GrimTheReaper RichiCoder1 dwelle jdestgermain lipis szympajka vjeux xenophilicibex

repo: excalidraw/excalidraw


text:
[grouping] selecting another group sibling shouldn't exit group

When you're editing a group, selecting or shift+selecting another sibling shouldn't exit the group editor.
steps:

group 2 elements
double-click on an element to edit group
click on the 2nd element (or shift+click on the 2nd element)

In case of shift+click, it should select both so you can edit multiple group elements at once (e.g. move them, useful for groups consisting of many elements).
Figma, Affinity et al. does this.

This seems to work already (even in the original commit) so not sure what I did wrong before.


text:
No logs will be recorded every day at 8am

No logs will be recorded every day at 8am

Can you please provide more information like versions and behaviors you are seeing as well as any log messages.

The current situation is that after 8 o'clock every day, exceptionless can correctly receive the log information submitted by the application service,

but it does not seem to write to elasticsearch. Now I restart the application service IIS site, and it will record the log normally Yes, found this in elasticsearch log.

Is there something wrong with my elasticsearch configuration?

What is your utc time zone offset? Seems like there may be issues with creating the index, and there is nothing else in the logs right before 8pm? What happens if you restart the app at 7:55pm?
Sent from my iPhone

On Jan 6, 2020, at 7:25 PM, luocm notifications@github.com wrote:

The current situation is that after 8 o'clock every day, exceptionless can correctly receive the log information submitted by the application service,
but it does not seem to write to elasticsearch. Now I restart the application service IIS site, and it will record the log normally Yes, found this in elasticsearch log.
Is there something wrong with my elasticsearch configuration?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

My side is China's time zone, which is East 8 district. The problem was before 8am, not afternoon. The log before 8 am can be recorded normally. I have repeatedly confirmed. The last entry is 2020-01-07 07:59:38. At 8 o’clock, it is not recorded.

What version of Elasticsearch are you running? I'm pretty sure 8am for you is midnight utc which is when the daily index rolls over. Can you turn on verbose logging as per the self hosting troubleshooting docs and send the output around 7:59-8:01am. Sounds like something is goofy going on, also can you please ensure you are on the latest 5.6.x Elasticsearch.

hello,Elasticsearch version is
{
"name": "R0YDX9v",
"cluster_name": "elasticsearch",
"cluster_uuid": "DI3pi06GQBiqfY_9E8guAw",
"version": {
"number": "5.6.16",
"build_hash": "3a740d1",
"build_date": "2019-03-13T15:33:36.565Z",
"build_snapshot": false,
"lucene_version": "6.6.1"
},
"tagline": "You Know, for Search"
}
And i have confirmed that it is a time zone issue, but after I changed the server time to UTC time yesterday, the index will not be created automatically. Is there any solution?

There is a log posted at 7: 59-8: 01 AM, and I still have no effect after I change the server time to UTC. My personal computer and local environment are connected to Elasticsearch service, and then it is possible to allocate the Exceptionless ServerUrl of the application station to this machine, but it is not possible to deploy to the production server after publishing. This should confirm that the interaction between Exceptionless and Elasticsearch in the production environment is missing the configuration, but it has not been known what it is.

Now I can confirm one thing. I cannot create the elascsearch index when I deploy to IIS. Only in F5 directly in VS. Even if it's deployed to my local IIS. But my dotnet exceptionless.web.dll can't run. Excuse me, in a windows environment, except IIS, how to run Exceptionless in the console mode?

I'd recommend upgrading to the latest version which is hosted in docker. It sounds like IIS is part of the problem and I'm not really sure why.

Can you please see if this is still an issue with 6.x release

Were you able to see if this is still an issue with 6.x release. I'm really not sure what's going on. If this is still an issue once running on 6.x let me know and we'll reopen this. We haven't been able to reproduce this issue.

repo: exceptionless/Exceptionless


text:
using sphinx-thebelab

This removes thebelab-specific JS from this repository and uses sphinx-thebelab instead.
cc @akhmerov - here's an example of how we can use sphinx-thebelab to build on top of it, WDYT

Looks good!
Shouldn't configuring the extension this also go into theme itself? Every user of the book theme will have the same selectors.

@akhmerov yeah I was thinking that too. We could just "update" the sphinx-thebelab configuration with whatever is in the sphinx-book-theme?

Exactly, that's what I was thinking as well.

@akhmerov just made some pushes to update the UI and configurability. What do you think?
(note taht I also realized that the binder environment doesn't actually work with the code that's here 😬 but that's fixed in this PR, just won't work until it's merged)

gonna merge this so that we can try it out and see how it works

Sorry, late to the party. Everything looks good at a glance.
The only things I noticed were:

The branch could be potentially obtained from git, as opposed to being master
thebe_config.get("selector_input", "") + ",.cell_input div.highlight" could seemingly produce an illegal selector if the first part is empty. Shouldn't this be ','.join(...)?

ah that's why I'm lstriping everything just after that :-)
re: the branch obtained from git...could you clarify a bit?

e.g. using the output of git rev-parse --abbrev-ref HEAD instead of master. Not sure whether it's a reasonable default: it would slow down binder on PRs due to rebuilding the image, but would allow testing easier.

maybe we should re-name "branch" to "ref"? Then it could point to commits etc

I didn't mean the name of the variable as much as actually doing subprocess.check_output to see whether we are in a git repository and whether we can infer a good branch name. Also not hard-coding master is maybe a good idea with the discussions of alternative default branch names.

ahhh I see what you mean - so you mean if no explicit branch is given, then try to infer the branch from the current repository, and if that doesn't work then defer to master?

Yes, exactly!

it's a cool idea - wanna open up an issue about it?

Sounds good, I was just wondering: should it be here or in sphinx-thebelab?

good point - probably sphinx-thebelab

authors: akhmerov choldgraf

repo: executablebooks/sphinx-book-theme


text:
ENH: Enable support for format in _toc.yml

Description / Summary
We should explicitly link the format types that are defined in _toc.yml to the operation of this extension and ensure support for jb-article and jb-book.
Documentation for the latest format definitions are available here:
https://jupyterbook.org/customize/toc.html#
and definitions are here:
https://sphinx-external-toc.readthedocs.io/en/latest/user_guide/sphinx.html#using-different-key-mappings
We have tested against jb-book primarily so we should do additional testing for jb-article
Value / benefit
This will tie in nicely with the available metadata now available through the format key in _toc.yml to enable more targeted assumptions in the LaTeX translation. If we know the jb-article key is provided we can make more assumptions about the document structure when parsing the sphinx.ast.
Implementation details
TBD
Tasks to complete

[ ] review the best way to add jb-article and jb-book

@AakashGfude this is the issue I put together to start thinking about how we can tailor this extension to use the metadata contained in _toc.yml to make tighter and more accurate assumptions etc.


text:
Test Exercises with Docker Images in Github Action

extend original test script to test all exercises like in exercism production enviroment
Test Run https://github.com/marianfoo/abap/runs/4741973810?check_suite_focus=true

looks good 👍

Should i add a 'Non-Docker' Version for local tests that include linting too?

not sure, need to think about what options we have to make the setup easier

anything else here to do?

need to fix the downport in abaplint before this can be merged, so it will show green

moving ahead, merging

authors: larshp marianfoo

repo: exercism/abap


text:
Prepare ABOUT.md for nextercism

Hello :)
On nextercism the ABOUT.md is currently rendered like this:

I have removed line breaks and the double bullet points to make it look lots nicer. I have not edited the content itself. It will now render like this (the space on the right for the code snippet)

See https://github.com/exercism/meta/issues/84 for more details.

This looks good, thanks :). I will go ahead and merge.
@kytrinyx I'll have some time this weekend to work on updating tracks for Nextercism, I'll work on rewriting the description then.

@patricksjackson Thank you 💙

authors: iHiD patricksjackson

repo: exercism/cpp


text:
Fix unit tests for Bracket-push exercise

As per issue #436:

Change default import bracket to named import { bracketPush }.
Change all function calls in the test suite to bracketPush'
Change export statement of example.js from a default to a named export.

👍

authors: matthewmorgan xarxziux

repo: exercism/ecmascript


text:
Modify Chessboard exercise to comply with standard chess notation

The current exercise swaps the definition or file and rank of a chessboard. This could be confusing for people who know chess.
https://en.wikipedia.org/wiki/Chessboard
Also, the expected response of the first two examples do not match the diagram and the test data provided. This PR corrects both issues while respecting the spirit of the exercise

My husband is into chess and he looked over my shoulder and saw the old diagram in the test file. He was also immediately like "That's not right!". So thanks a lot for the catch and fix @cruzfarfan!

authors: cruzfarfan junedev

repo: exercism/go


text:
Fix typo in high-score board instructions

In this PR I propose to fix a small typo in the high-score board instructions file.
Let me know if you would prefer to group this fix with other fixes. I haven't spotted others so far. I see that https://github.com/exercism/swift/pull/725 is still open, so maybe they can be grouped.

I think it is okay to not group this pr with 725, I will let the contributor get some more time to make the changes I said had to be made.
Meanwhile these changes should also be applied to the following files:

concept:numbers:about.md
exercise:freelancer-rates:introduction.md

Otherwise, the changes look good!

@meatball133 Thank you for your comment, I looked at the files you mentioned but did not see any change needed there. Let me know if I missed some, or if you wanted me to check files related to the same concept.
I used the opportunity to cleanup the concepts:dictionaries:about.md file by removing some dangling code fences and adding a missing code example (copied from another file).
Can you review these changes, or should I wait for another maintainer to comment on the PR ?
Thank you again for your time.

I took a very and I mean very hasty look at the pr and didnt check the underlying docs. But realized quickly after I took another look rn after your comment that the docs are incorrectly structured (not anything you have done or could have known). The about file should always be longer than the introduction file and often to keep things simple it is often quite good to keep those files rather similiar. Seems like the author of this didnt do any of that.
So I will approve your pr and merge it and put this on my list to reorginze.

repo: exercism/swift


text:
Add Word Search practice exercise

Port the word-search exercise to V.
The following tracks have implemented Word Search:

csharp
elixir
fsharp
go
java
javascript
lua
python
tcl
typescript

The canonical-data would suggest a function  search(grid strings, words_to_search_for strings) returning a map from string to optional word location.
Option A
Have a single function that returns a map, with location [[-1, -1], [-1, -1]] for absent words.
Option B
struct Pair {
	column int
	row    int
}

struct WordLocation {
	start Pair
	end   Pair
}

// define the WordSearcher type here
struct WordSearcher {
}

fn new_word_searcher(grid []string) WordSearcher {
}

fn (searcher WordSearcher) find(word string) ?WordLocation {
}

I think Option B better helps students learn V.

Option C
Have a single function that returns a map, with location none for absent words.
struct WordLocation {
}

fn search(grid []string, words_to_search_for []string) map[string]?WordLocation {
}

repo: exercism/vlang


text:
Make canonical data for RLE test generator friendly.

Change the format of the canonical data json for the
run length encoding exercise to be the same as that for
the other multi-function exercises.
This is more useful for test generators (certainly the Ocaml
one).
Descriptions also updated to be a little clearer.

I agree with the suggestions in #336 for putting a function name in or near each test case - that would allow a more flexible order if required.
Updating to a new schema would certainly break the OCaml test generator, but it's a pretty small piece of code so would not be significant effort to fix.

repo: exercism/x-common


text:
Should we settle on C99?

This will give us (guaranteed) access to stdint types and is generally a more pleasant experience than C89. Shall we proceed to take advantage of C99 in all of our examples and tests where appropriate?

I think C99 is the way to go.  I can't think of any negatives.

Okay, let's go for it.

authors: palisaide ryanplusplus

repo: exercism/xc


text:
GaussianProcess docstring would benefit from enhancements

There is an inconsistency between the celerite2 Getting Started tutorial and the Exoplanet tutorials in the use of GaussianProcess and compute. Specifically, in the celerite2 tutorial compute is called explicitly but in the Exoplanet tutorials that include celerite2, compute is implicitly called through supplying the t keyword.
I don't think this is a particular problem, but it would be good if the main GaussianProcess docstring stated that if t is supplied then the compute method is automatically run.
In addition, the theano.GaussianProcess class doesn't have a docstring so this would benefit from having the same docstring as the main  GaussianProcess class, also with the addition of the note about compute.

I would be happy to make these changes and submit a pull request, if that would be useful and you agree these changes are a good idea.

Sure - that would be awesome! Thanks Tom!

authors: dfm mrtommyb


text:
fix working with local api server

Checklist

[ ] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.
[ ] I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why
Follow-up to https://github.com/expo/eas-cli/pull/744. I didn't notice it before but that PR broke development with the local www server.
How
Use different API URL when EXPO_LOCAL is set.
Test Plan
EXPO_LOCAL eas whoami works now.

Put up a revert here since there is a neater fix on the API server side. https://github.com/expo/eas-cli/pull/750

authors: dsokal ide

repo: expo/eas-cli


text:
can't run node example/mvc

I got this error on my terminal.
SyntaxError: Unexpected token ILLEGAL
at Object.exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:513:28)
at Object.Module._extensions..js (module.js:550:10)
at Module.load (module.js:458:32)
at tryModuleLoad (module.js:417:12)
at Function.Module._load (module.js:409:3)
at Module.require (module.js:468:17)
at require (internal/module.js:20:19)
at /Users/distravantari/Downloads/express-master/examples/mvc/lib/boot.js:12:15
at Array.forEach (native)

Hmm, that is weird, I've never seen that before. Maybe there is a stray file in your controllers folder. Can you provide the output of the following command?
$ ls -la /Users/distravantari/Downloads/express-master/examples/mvc/controllers

this is the output:
drwxr-xr-x@ 7 distravantari  staff   238 Jan 26 11:47 .
drwxr-xr-x@ 9 distravantari  staff   306 Jan 26 11:46 ..
-rw-r--r--@ 1 distravantari  staff  6148 Jan 26 11:47 .DS_Store
drwxr-xr-x@ 3 distravantari  staff   102 Jan 20 22:05 main
drwxr-xr-x@ 4 distravantari  staff   136 Jan 20 22:05 pet
drwxr-xr-x@ 4 distravantari  staff   136 Jan 20 22:05 user
drwxr-xr-x@ 3 distravantari  staff   102 Jan 20 22:05 user-pet
it seems that .DS_STORE is the problem, I solve it by simply delete the file.
thank you @dougwilson .

Hi @distravantari glad I could help! But yea, the .DS_Score was messing it up, but seems like something the example should be ignoring, since it only cares about directories anyway. I'll patch the example to help people in the future :) !

authors: distravantari dougwilson

repo: expressjs/express


text:
Request triager role for @mastermatt

I have read and understood the project's Code of Conduct.
I also have read and understood the process and best practices around Express triaging.
I request for a triager role for the following GitHub organizations:
jshttp
pillarjs
express

All set. Thanks.


text:
Provide Anne with commit access

(Username will be given shortly.)

Anne’s username to set up commit access on ap210.org: @zw66

Invited @ZW66. Anne could you join the organization on this page (https://github.com/expresslang)? Then access will be granted. Thanks!

@zw66 already has access to the org and repo.

authors: ronaldtse strogonoff


text:
feat: Add http code decorator

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?
N/A
Issue Number: https://github.com/expressots/expressots/issues/267
What is the new behavior?
This PR adds the decorator http, used in controller methods to modify the http status code response rather than using the default ones. Adjustments will be required on the expressots side as well depending on the direction we decide to go.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications below.
Other information
Currrently, this can be said as a proof of concept. The expressots part will need to be done after this PR is complete. For now, the easiest way to test this PR and see it functioning may be to just add this middleware to an expressots project:
import { ExpressoMiddleware } from "@expressots/core";
import { NextFunction, Request, Response } from "express";
import "reflect-metadata";

export class CustomMiddleware extends ExpressoMiddleware {
  use(req: Request, res: Response, next: NextFunction): void | Promise<void> {
      if (req.method === "POST") {
        res.statusCode = 250;
      } else if (Reflect.getMetadata("status_code", Reflect, req.path)) {
        res.statusCode = Reflect.getMetadata("status_code", Reflect, req.path);
      }
      next();
  }
}

and then add it to configureServices() like so:
    protected configureServices(): void {
        this.provider.register(Env);

        this.middleware.addBodyParser();
        this.middleware.addMiddleware(new CustomMiddleware())
        this.middleware.setErrorHandler();
    }

Good job @projectjimcs

authors: projectjimcs rsaz

repo: expressots/adapter-express


text:
Disambiguate Vault namespaces for auth and secret retrieval

Describe the solution you'd like
The current SecretStore and ClusterSecretStore CRD specification for the Vault provider has a namespace field at the top-level. This field is overloaded, it is used both for authenticating with the cluster, as well as the location of the secret fetched and retrieved into kubernetes. However, if secrets are stored in a namespace in Vault, but the auth backend is configured on the root namespace, then secrets can not be fetched. External Secrets will try and authenticate with the namespace, which inherits the auth method of the root, but does not have it mounted at the namespace level. See the Vault namespace architecture for details.
Ideally, the SecretStore of ClusterSecretStore spec would contain an additional optional field, vaultAuthNamespace (or perhaps vaultNamespace if that is too wordy), which when not empty, would be used as the authentication mount for vault.
Note: Because "" represents the root namespace, we need to note in the docs to use "root" instead to indicate that the root namespace is intended. Using the empty string "" is problematic and confusing for users (empty strings usually indicate an unused or unset field and could be stripped). Instead, Vault special-cases the namespace name "root" and redirects it to the root namespace.
What is the added value?
Vault Enterprise users will no longer need to explicitly configure auth backends for each Vault namespace in use with External Secrets. Auth backends can be defined at the root namespace and configured only once if desired.
Give us examples of the outcome
Example SecretStore spec for Vault:
apiVersion: external-secrets.io/v1alpha1
kind: SecretStore
metadata:
  name: example
  namespace: example-ns
spec:
  provider:
    vault:
      server: "https://vault.acme.org"
      path: "secret"
      version: "v2"
      namespace: "a-team"
      vaultAuthNamespace: "root"

After discussing some with @mbillow he suggested a SecretStore in this format:
apiVersion: external-secrets.io/v1alpha1
kind: SecretStore
metadata:
  name: example
  namespace: example-ns
spec:
  provider:
    vault:
      server: "https://vault.acme.org"
      path: "a-team/secret"
      version: "v2"
      namespace: "root"

Which I tested and was able to successfully auth External Secrets against the root namespace and populated the secret from the target namespace by setting the namespace as a prefix in the path + root namespace in the SecretStore crd. So we can follow that pattern for Vault Enterprise and won't need this.

repo: external-secrets/external-secrets


text:
Failed to create a PR against this repo

Describe the solution you'd like
I created my first PR in https://github.com/external-secrets/external-secrets/pull/800 however it is closed due to You seem to have opened more PR's than this Repo Allows but I have never created one before.
I have checked the doc but it does not help :(
What is the added value?
More people more helps better the project.
Give us examples of the outcome
People can contribute to the project.

The bot closes PRs after a limit of 15... and dependabot spamed PRs 10 hours ago :sweat_smile: We need to increase the limit, or remove it.
https://github.com/external-secrets/external-secrets/pull/794

authors: kinyat knelasevero


text:
feat: attach sbom/provenance files to GH release, fix clomonitor

This PR attaches sbom and provenance files to GH release assets.
Further, it fixes a couple of minor clomonitor issues, see https://clomonitor.io/projects/cncf/external-secrets:

maintainers
roadmap
sbom
signed releases
license scanning

Proof of work
https://github.com/moolen/external-secrets/releases/tag/v0.6.1-rc3

I've added the @external-secrets/maintainers team recently (mgmt deeplink) or are you referring to something else?

I just found the issue @IdanAdar, the team @external-secrets/maintainers didn't have explicit access to this repository. This has been fixed now.


text:
first draft of microservice dockerfile

@pjbreaux
This is the first change necessary to roll out the dockerization of our ansible server.
The Dockerfile is a the spec for the our ansible microservice.
The new install of git (with yum) is the minimum change we needed to make to the controller to install the agent and driver.

I tested these changes by pointing my development branches at my fork of this repo, and running the tlc commands.

@pjbreaux it looks like I don't have the authority to assign you...


text:
Overriding max-width on label broken in Firefox

The CSS rule in paper-chip.html on L256 wins the specificity check over external max-width styling in Firefox:
:host(:not([opened])) #label ::slotted([slot="label"]) {
  @apply --paper-font-common-nowrap;
  max-width: 80px;
}

In Chrome it seems to prefer external styling over this internal rule.
Perhaps it's best to assign a CSS variable to this property to let people set their own width requirements or even disable max-width.

Yes, this (probably) happens in every browser without Shadow DOM due how to shimming of ::slotted is done by the WebComponents polyfill.
@alelb is providing a CSS variable to ensure the wanted max-width is always in place.
Thanks a lot for noticing it, keep helping us !

authors: leodido mbierlee

repo: fabbricadigitale/paper-chip


text:
docs: add object related documentations

Implemented object related docs as discussed in https://github.com/fabian-hiller/valibot/issues/287

@fabian-hiller
I modified Property.tsx a little bit without breaking changes.
Plz let me know what you think 🙏

To express WithQuestionMarks's intersection type, I modified Property.tsx (https://github.com/fabian-hiller/valibot/pull/357/commits/d71f4dc2663e049264ca9c46fd4ce9de74c92661).

To express RequiredKeys's object index access, I modified Property.tsx (https://github.com/fabian-hiller/valibot/pull/357/commits/814f2e3a643d8f48ae08e7e36be3052f3c019621)

I convert this PR to draft, because I haven't written the example of object 🙏
After finishing writing the example, I'll open this PR.

Thank you for this PR! I will review it later today or in the next few days.

I will merge this PR later.

repo: fabian-hiller/valibot


text:
Support TLS/Ciphersuite configuration options

We would like to be able to configure Fabio to only accept TLS 1.2 + certain ciphersuites. Would you accept a contribution for this? Looking for some guidance on an impl that would be accepted. Thanks!
Thoughts:

Expose config options here: https://github.com/eBay/fabio/blob/4d8e2b1cce7edcf2c566ad7652d957cf32858efe/config/config.go#L29-L36

TLSMinVersion String ("1.0", "1.1", or "1.2" recognized options)
CipherSuites String (comma-separated list)

Pass more options along here: https://github.com/eBay/fabio/blob/4d8e2b1cce7edcf2c566ad7652d957cf32858efe/listen.go#L92
Take advantage of the tls.Config options here: https://github.com/eBay/fabio/blob/4d8e2b1cce7edcf2c566ad7652d957cf32858efe/cert/source.go#L89-L94

    // CipherSuites is a list of supported cipher suites. If CipherSuites
    // is nil, TLS uses a list of suites supported by the implementation.
    CipherSuites []uint16

   ...

    // MinVersion contains the minimum SSL/TLS version that is acceptable.
    // If zero, then TLS 1.0 is taken as the minimum.
    MinVersion uint16

from tls package common.go
const (
	VersionSSL30 = 0x0300
	VersionTLS10 = 0x0301
	VersionTLS11 = 0x0302
	VersionTLS12 = 0x0303
)

from tls package cipher_suites.go
// A list of cipher suite IDs that are, or have been, implemented by this
// package.
//
// Taken from http://www.iana.org/assignments/tls-parameters/tls-parameters.xml
const (
	TLS_RSA_WITH_RC4_128_SHA                uint16 = 0x0005
	TLS_RSA_WITH_3DES_EDE_CBC_SHA           uint16 = 0x000a
	TLS_RSA_WITH_AES_128_CBC_SHA            uint16 = 0x002f
	TLS_RSA_WITH_AES_256_CBC_SHA            uint16 = 0x0035
	TLS_RSA_WITH_AES_128_CBC_SHA256         uint16 = 0x003c
	TLS_RSA_WITH_AES_128_GCM_SHA256         uint16 = 0x009c
	TLS_RSA_WITH_AES_256_GCM_SHA384         uint16 = 0x009d
	TLS_ECDHE_ECDSA_WITH_RC4_128_SHA        uint16 = 0xc007
	TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA    uint16 = 0xc009
	TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA    uint16 = 0xc00a
	TLS_ECDHE_RSA_WITH_RC4_128_SHA          uint16 = 0xc011
	TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA     uint16 = 0xc012
	TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA      uint16 = 0xc013
	TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA      uint16 = 0xc014
	TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256 uint16 = 0xc023
	TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256   uint16 = 0xc027
	TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256   uint16 = 0xc02f
	TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 uint16 = 0xc02b
	TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384   uint16 = 0xc030
	TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 uint16 = 0xc02c
	TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305    uint16 = 0xcca8
	TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305  uint16 = 0xcca9

	// TLS_FALLBACK_SCSV isn't a standard cipher suite but an indicator
	// that the client is doing version fallback. See
	// https://tools.ietf.org/html/rfc7507.
	TLS_FALLBACK_SCSV uint16 = 0x5600
)

That sounds like a good idea since it provides more control over the defaults. I'm inclined to consider this an option of the listener since it more about the TLS handshake than managing certificates.
I'd go with adding a tlsmin and ciphers option to the listener config. The challenge here is that ciphers would be a comma-sep list inside a semicolon sep list inside a comma-sep list, e.g.
proxy.addr = :9999,:443;cs=ssl;tlsmin=1.2;ciphers="TLS_RSA_WITH_AES_256_CBC_SHA,TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,..."

So you would have to first update the flagset code to ignore commas in a quoted string. I'd also allow both the hex code and the named constants which you should try to resolve via reflection to avoid future maintenance.

For the values of the tlsmin option I suggest to use the lower-cased constants without the Version prefix, e.g. ssl30, tls10, tls11, tls12, ...

@ajlake Are you going to pick this up or shall I do this?

someone, please implement this feature

I'll have a look.

I've pushed a branch which contains a fix for this issue. You can add tlsmin, tlsmax and tlsciphers as listener options and the values are the ones defined in https://golang.org/pkg/crypto/tls/#pkg-constants. The tlsciphers are specified as a comma-separated list in a quoted string. This required replacing the simple string.Split approach of the old config parser to be replaced with a proper lexer and parser.
Example:
proxy.addr = :443;cs=ssl;tlsmin=0x301;tlsciphers="0xc00a,0xc02b"

I still need to add a test and update the documentation in fabio.properties but it would be great if someone could test whether this works.

authors: ajlake kostyrev magiconair

repo: fabiolb/fabio


text:
Fix changelog link in docs footer

You can also consider changing the link to CHANGELOG.md.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you!

authors: CLAassistant magiconair xmikus01


text:
NUMP

Introduction
Adding the possibility for a country to calculate emission for a National Urban Mobility Plan

[ ] Add the second possibility to describe transport activity (fleet approach)
[ ] Modify project information page (allowing to choose between a SUMP and a NUMP)

-> based on the excel-based tool

[ ] Suggesting values from NUMP to SUMP cities that are in the same country (mid-term objective)

https://github.com/fabmob/myc-emissions-calculator/issues/20

I have added a selection in the project info page. Selecting NUMP removes the City field:

I have also modified the transport activity step, I'm unsure about the content and UI, but it works for now.
Vkt are automatically calculated using fleet approach, an additional source also appears when selecting the fleet approach.

[ ] Maybe edit the current text: "Use pre-computed vehicle kilometers travelled information" to be clearer

authors: TTalex maloufabmob

repo: fabmob/myc-emissions-calculator


text:
fix(test): verifies that listing projects contains created one

and bumps down WF Swarm

Thanks!

authors: bartoszmajsak gastaldi


text:
Add prometheus as a javaagent, add config and script support for prometheus

Add prometheus as a javaagent, add config and script support for prometheus

@cunningt it looks like you made the changes directly to the jboss/* and rhel/* files. We use [fish-pepper|https://github.com/fabric8io-images/fish-pepper], which uses template files in templates/* and generates the jboss and rhel images.
Please make your changes to the template files (where appropriate, some files may be image specific) and run fish-pepper to re-generate image files?
The PR should include both updates to templates and the generates images (since our Jenkins pipelines do not currently use fish-pepper to update the image files).

@dhirajsb : I went ahead and added the fish-pepper changes (sorry about missing that the first time).   I added a local block for the prometheus changes, and I've gone through and tested the jboss java and karaf images - prometheus seems to start and the metrics seem to be exposed on 9779 for me in minishift.

@cunningt LGTM, thanks!

@cunningt @dhirajsb Sorry, the PR escaped under my radar, but I wonder why not leveraging agent-bond which contains both, Jolokia and jmx_exporter ? (actually that's the whole idea of agent-bond to have only a single agent to attach).

@rhuss I think we decided on using jmx_exporter vs. agent-bond for maintenance (update jmx_exporter version directly rather than have to update agent-bond, release, update agent-bond version), but I think the long term plan may be to replace the jmx_exporter here with the hawkular java agent, which will include the jmx exporter and offer a secured http endpoint.

authors: cunningt dhirajsb rhuss


text:
Upgrade to Docker-maven-plugin 0.14.1 with new groupId io.fabric8

Upgrade to newest docker-maven-plugin
Andrea

Can one of the admins verify this patch?

ok to test

authors: davsclaus fusesource-ci oscerd


text:
On http://prod-preview.openshift.io, logging with Firefox presents the user with a blank screen

This happens at the 18 second mark of the referenced screencast:
https://drive.google.com/open?id=0B1s-ZoxD8FjUcmRqSlpUQXBzT3M

@ldimaggi can you file this under the www.openshift.io repo and close this issue? This is most likely a problem with routing or caching from the homepage and is not related to Planner.

https://github.com/openshiftio/www.openshift.io/issues/68


text:
fix(board view): add kebob menu

Fix: #1623
Fix: #1595
Fix: #638

@vikram-raj snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-1636-fabric8-planner.int.rdu2c.fabric8.io

@vikram-raj snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-1636-fabric8-planner.int.rdu2c.fabric8.io


text:
Create a global .Navbar component

A global component for the navbar area at the top of the mobile and desktop apps.
This branch also adds a desktop variant, .NavBar--desktop, that includes default spacing for use the desktop app.

Pass!

authors: paddyduke robbiemanson

repo: fac/origin


text:
NavySetup should not involve the MockDevice

Describe the bug
After this  commit was merged, the script ./contrib/build.sh -d -j -v no longer works  because the CMakeLists.txt file in the cachebench directory does not add the dependencies for gtest and gmock. This results in numerous undefined reference errors when I compile the project:
/usr/bin/ld: ../allocator/libcachelib_allocator.a(NavySetup.cpp.o): in function `std::__detail::_MakeUniq<facebook::cachelib::navy::MockDevice>::__single_object std::make_unique<facebook::cachelib::navy::MockDevice, unsigned long, unsigned int>(unsigned long&&, unsigned int&&)':
/usr/include/c++/14.1.1/bits/unique_ptr.h:1076:

(.text._ZSt11make_uniqueIN8facebook8cachelib4navy10MockDeviceEJmjEENSt8__detail9_MakeUniqIT_E15__single_objectEDpOT0_[_ZSt11make_uniqueIN8facebook8cachelib4navy10MockDeviceEJmjEENSt8__detail9_MakeUniqIT_E15__single_objectEDpOT0_]+0x79):

undefined reference to `facebook::cachelib::navy::MockDevice::MockDevice(unsigned long, unsigned int,std::shared_ptr<facebook::cachelib::navy::DeviceEncryptor>)'

Although you could add gtest and gmock to cachelib/cachebench/CMakeLists.txt and move the constructor from MockDevice.cpp to MockDevice.h to fix this, I don't think it is a good solution. We shouldn't include the test file in the source file.
target_link_libraries(cachelib_cachebench PUBLIC
   cachelib_datatype
   cachelib_allocator
   gflags
+  gtest
+  gmock
 )

//MockDevice.cpp
namespace facebook {
 namespace cachelib {
 namespace navy {
-MockDevice::MockDevice(uint64_t deviceSize,
-                       uint32_t ioAlignSize,
-                       std::shared_ptr<DeviceEncryptor> encryptor)
-    : Device{deviceSize, nullptr, ioAlignSize, 0, 0},
-      device_{deviceSize == 0
-                  ? nullptr
-                  : createMemoryDevice(
-                        deviceSize, std::move(encryptor), ioAlignSize)} {
-  ON_CALL(*this, readImpl(testing::_, testing::_, testing::_))
-      .WillByDefault(
-          testing::Invoke([this](uint64_t offset, uint32_t size, void* buffer) {
-            XDCHECK_EQ(size % getIOAlignmentSize(), 0u);
-            XDCHECK_EQ(offset % getIOAlignmentSize(), 0u);
-            return device_->read(offset, size, buffer);
-          }));
-
-  ON_CALL(*this, writeImpl(testing::_, testing::_, testing::_, testing::_))
-      .WillByDefault(testing::Invoke(
-          [this](uint64_t offset, uint32_t size, const void* data, int) {
-            XDCHECK_EQ(size % getIOAlignmentSize(), 0u);
-            XDCHECK_EQ(offset % getIOAlignmentSize(), 0u);
-            Buffer buffer = device_->makeIOBuffer(size);
-            std::memcpy(buffer.data(), data, size);
-            return device_->write(offset, std::move(buffer));
-          }));
-
-  ON_CALL(*this, flushImpl()).WillByDefault(testing::Invoke([this]() {
-    device_->flush();
-  }));
-
-  ON_CALL(*this, allocatePlacementHandle()).WillByDefault(testing::Invoke([]() {
-    return -1;
-  }));
-}
 } // namespace navy
 } // namespace cachelib
 } // namespace facebook

// MockDevice.h
   std::unique_ptr<Device> device_;
 };

+MockDevice::MockDevice(uint64_t deviceSize,
+                       uint32_t ioAlignSize,
+                       std::shared_ptr<DeviceEncryptor> encryptor)
+    : Device{deviceSize, nullptr, ioAlignSize, 0, 0},
+      device_{deviceSize == 0
+                  ? nullptr
+                  : createMemoryDevice(
+                        deviceSize, std::move(encryptor), ioAlignSize)} {
+  ON_CALL(*this, readImpl(testing::_, testing::_, testing::_))
+      .WillByDefault(
+          testing::Invoke([this](uint64_t offset, uint32_t size, void* buffer) {
+            XDCHECK_EQ(size % getIOAlignmentSize(), 0u);
+            XDCHECK_EQ(offset % getIOAlignmentSize(), 0u);
+            return device_->read(offset, size, buffer);
+          }));
+
+  ON_CALL(*this, writeImpl(testing::_, testing::_, testing::_, testing::_))
+      .WillByDefault(testing::Invoke(
+          [this](uint64_t offset, uint32_t size, const void* data, int) {
+            XDCHECK_EQ(size % getIOAlignmentSize(), 0u);
+            XDCHECK_EQ(offset % getIOAlignmentSize(), 0u);
+            Buffer buffer = device_->makeIOBuffer(size);
+            std::memcpy(buffer.data(), data, size);
+            return device_->write(offset, std::move(buffer));
+          }));
+
+  ON_CALL(*this, flushImpl()).WillByDefault(testing::Invoke([this]() {
+    device_->flush();
+  }));
+
+  ON_CALL(*this, allocatePlacementHandle()).WillByDefault(testing::Invoke([]() {
+    return -1;
+  }));
+}
+

To Reproduce
just run ./contrib/build.sh -d -j -v
Desktop (please complete the following information):

OS: arch-linux

I also encountered the same problem in ubuntu 20.04.

The build works now. The CMakeLists has been fixed along with the FDP tests. The FDP tests only run when FDP is enabled in the system.

authors: ByteMansion pbhandar2 tang-hi

repo: facebook/CacheLib


text:
Wrong main.js file is tried to download after a deploy (CRA + S3 + Cloudfront)

Is this a bug report?
I think that yes, maybe related to service worker func.
Did you try recovering your dependencies?
It isn't related with this.
Environment
Node version: v8.11.1
Yarn version: v1.2.1
Hosted on Amazon S3 + Cloudfront
Steps to Reproduce

Build app using "react-scripts build", a new main.yyyy.js is generated.
Sync to aws s3 bucket
Invalidate cloudfront cache
Try access to webapp url.
The magic occurs:

The browser try to get old main.xxxxx.js generating an 404 not found error (user see a white screen), if you reload the browser web app is loaded rightly.
Expected Behavior
After a deploy with the steps mentioned, when we try to access web app url this should get the new main.js file, avoiding the first white screen.
I've reviewed this issue: https://github.com/facebook/create-react-app/issues/3688 that is exactly the same problem, but i've not found a solution for this.
It's very important for us, thanks in advance for your help.

@segulino how did you resolve this? i am trying invalidate cache on cloudfront but not getting any succes. i have tried below AWS command but still getting this behavior.. Not picking the right main.js at first hit but on 2nd.
aws cloudfront create-invalidation --distribution-id ${CLOUDFRONT_ID} --paths '/index.html'

aws cloudfront create-invalidation --distribution-id ${CLOUDFRONT_ID} --paths '/*'

Having the same issue. If I'm really unlucky and refresh the page the wrong time it seems as it downloads the new service worker and then caches the main.js file which is invalid cause it has not yet finished uploading.

Has anyone resolved this issue? Currently facing the same problem.

This is fixed with the default service worker behavior in v2.

@bill-vatomic
version 2 of create react app and changing the uploading order to s3 (upload service-worker.js and index.html last) seems to solved it for me.

@bill-vatomic
version 2 of create react app and changing the uploading order to s3 (upload service-worker.js and index.html last) seems to solved it for me.

Thanks for the reply! Looks like I am still on version 1.5. I will look into upgrading, but I was able to solve our problem by chunking out my JavaScript files. I found out that the service-worker in this version of CRA has a 2MB file limit, and our main JS file passed 2 MB a few weeks ago. I am now dynamically loading the routes in my app, which chunked all the files out to files under 2 MB.

authors: Timer andidev bill-vatomic lalzada segulino

repo: facebook/create-react-app


text:
Update to PostCSS 8

Fixed #9664
postcss-loader 4.0 moved PostCSS to peerDependencies

Would be awesome if update to PostCSS 8 would be released with support for custom config https://github.com/facebook/create-react-app/pull/8907 🤞

hello has the issue  with postCSS 8 on '' Create react app '' fix ?
because am still getting errors when i run "npm run  build ".
👇🏿👇🏿👇🏿👇🏿👇🏿👇🏿
C:\Users\cilium\Desktop\ebuka\webdev\tailwindCSS> npm run build

tailwindCSS@1.0.0 build C:\Users\cilium\Desktop\ebuka\webdev\tailwindCSS
postcss css/tailwind.css -o public/build/tailwind.css

Error: PostCSS plugin autoprefixer requires PostCSS 8.
Migration guide for end-users:
https://github.com/postcss/postcss/wiki/PostCSS-8-for-end-users
at Processor.normalize (C:\Users\cilium\Desktop\ebuka\webdev\tailwindCSS\node_modules\postcss\lib\processor.js:153:15)
at new Processor (C:\Users\cilium\Desktop\ebuka\webdev\tailwindCSS\node_modules\postcss\lib\processor.js:56:25)
at postcss (C:\Users\cilium\Desktop\ebuka\webdev\tailwindCSS\node_modules\postcss\lib\postcss.js:55:10)
at C:\Users\cilium\Desktop\ebuka\webdev\tailwindCSS\node_modules\postcss-cli\index.js:218:14
at async Promise.all (index 0)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! tailwindCSS@1.0.0 build: postcss css/tailwind.css -o public/build/tailwind.css
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the tailwindCSS@1.0.0 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\cilium\AppData\Roaming\npm-cache_logs\2020-11-16T16_00_30_816Z-debug.log
PS C:\Users\cilium\Desktop\ebuka\webdev\tailwindCSS>

Changes look good (approving), but the tests seem a bit broken?

@clarkd it was some unrelated error, but for some reason log was already cleaned.
Seems like PR review took too long for CI.

@iansu is there a release date for the 4.0.2 milestone?

The build was failing for me, updating the packages wasn't enough. I had to change the Webpack config to reflect postcss-loader changes, wrapping up some of the options in the postcssOptions key.
{
  // Options for PostCSS as we reference these options twice
  // Adds vendor prefixing based on your specified browser support in
  // package.json
  loader: require.resolve('postcss-loader'),
  options: {
    postcssOptions: {
      // Necessary for external CSS imports to work
      // https://github.com/facebook/create-react-app/issues/2677
      ident: 'postcss',
      plugins: () => [
        require('postcss-flexbugs-fixes'),
        require('postcss-preset-env')({
          autoprefixer: {
            flexbox: 'no-2009',
          },
          stage: 3,
        }),
        // Adds PostCSS Normalize as the reset css with default options,
        // so that it honors browserslist config in package.json
        // which in turn let's users customize the target behavior as per their needs.
        postcssNormalize(),
      ],
    },
    sourceMap: isEnvProduction ? shouldUseSourceMap : isEnvDevelopment,
  },
},

I only saw this PR today - The pull-request #10003 is done as part of the webpack 5 update #9994 and updating postcss dependencies and configuration in general - tests are passing locally etc.

@ai thanks for the PR. Apologies that this hasn't been adressed sooner. I've merged #10003 as it included the configuration updates, and updated the other related postcss packages.

@ianschmitz when do you plan to release it?
I need to add instructions for [PostCSS migration docs](https://github.com/postcss/postcss/wiki/PostCSS-8-for-end-users.

this doesn't work for me.
still getting the error:
🚫 Error: PostCSS plugin postcss-nested requires PostCSS 8.

@JimLynchCodes ask CRA team. not me.
They didn’t merged my PR and still do not have PostCSS 8 support https://github.com/facebook/create-react-app/pull/10003

@ianschmitz any news regarding this?

#10003 was reverted #10456 is a retry

Anyone else following this up?

any news regarding this?

I really hate to add to the noise but to answer the question of why this probably isn't released: webpack 5 support is being worked on as well (see pinned issue).
I would imagine that they want to finish that before pushing a new version of react scripts so breaking changes are consolidated.

When will this issue be fixed with CRA?

released in v5 alpha

@raix react-scripts 5? or webpack 5? this thread is about postcss 8 support in react-scripts

CRA v5 (currently in alpha, the postcss 8 upgrade was a major version due to node 10 deprecation, therefor it was moved to v5, along webpack 5, node 10+12 deprecation etc.)

are there any plans for this?

Bump

tailwindcss 3.0.0 is on postcss 8! Please support!

Yes, please! Tailwindcss 3.0 requires postcss 8.

Please support this for tailwindcss 3.0.0

Please support this must have!

Tailwindcss 3.0.0 is on PostCSS 8! Please support!

#11717

Please support PostCSS for TailwindCSS 3.0.

We need PostCSS for TailwindCSS 3.0. Definitely need to support

Please support PostCSS for TailwindCSS 3.0.

To everyone coming here for Tailwind CSS / PostCSS support, the new version (react-scripts@5.0.0) should support both of these.
Read about the new version and how to upgrade here:
https://github.com/facebook/create-react-app/releases/tag/v5.0.0

authors: Aspyryan JimLynchCodes Mancancode MikePrus OmerWow Shrroy UltiRequiem agusterodin ai andremonteiro95 billshannon cheesea3 chenrico clarkd goforbg hegelstad hugosego ianschmitz iiLearner jetro4u karlhorky kevinstueber michaelschadhauser piecyk raix


text:
Allow imports to be above h1 heading

🚀 Feature
With the current frontmatter-less parsing, the h1 heading must be at the top of the file, excluding frontmatter, for it to be used as the title rather than the filename. It'd be useful if import nodes could be placed above the heading without compromising the h1 heading's function as the title.
Have you read the Contributing Guidelines on issues?
yes
Motivation
It's just a quality of life feature that in my opinion would be useful
Pitch
ES6 JS imports are always placed at the top of the file, and this should be permitted for the markdown files as well without unintended side effects. Keeping the imports at the top of the file, separate from all the other content (including the h1 heading title) also helps decouple the actual "page content" of the file and the "metadata" associated with it (frontmatter, imports, etc)

agree, using imports at the top of the file should be supported

authors: duanwilliam slorber

repo: facebook/docusaurus


text:
Archived version docs links are broken

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Description
Netlify-links to archived version docs are dead:
https://github.com/facebook/docusaurus/blob/main/website/versionsArchived.json
With v3 coming in, time to remove old 2.0 prereleases from the json?
Self-service

[X] I'd be willing to address this documentation request myself.

Thanks, it's a known issue and I'm waiting for an answer from someone at Meta to see how we decide to archive older versions for Meta open-source sites. I was not able to get an answer yet?.
The archiving process options are described here: https://github.com/facebook/react-native-website/issues/3819
Duplicate of https://github.com/facebook/docusaurus/issues/8634

authors: fflaten slorber


text:
feat(v2): docs versioning :snowflake:

Motivation
This is pretty much a WIP, but putting it here first since the nature of this PR is very big and its just easier to let people peek into it 😢. Up until 13/11 this is still the NodeJS part of the code though. and it is able to generate all the correct route and pages. You won't be able to check it in netlify preview yet because I haven't cut the docs lol Try it here: https://deploy-preview-1983--docusaurus-2.netlify.com/ with alpha.35 docs cut

This also includes major refactoring on docs plugin especially on metadata. I try to avoid building object dynamically and prefer assigning all fields during object instantiation so that v8 can compile our code better. Also avoid hidden class transition
I added a LOT of tests.
Stronger docs typing

I try to make the folder structure as similar as v1 as possible for ease of migration and because directory structure is very related to CI. Changing versioned docs structure could reset Jest's translation back to 0 because crowdin don't understand if website/versioned_docs/version-1.0.0/hello.md is the same as website/<new_versioned_docs_directory_name>/hello.md
Overview
Directory structure
website/
├── sidebars.json          # sidebar for master (next) version
├── docs/                # docs directory for master (next) version
│   ├── foo/
│   │   └── bar.md       # https://mysite.com/docs/next/foo/bar
│   └── hello.md         # https://mysite.com/docs/next/hello
│
├── versions.json             # file to indicate what versions are available
├── versioned_docs/
│   ├── version-1.1.0
│   │    ├── foo
│   │    │   └── bar.md      # https://mysite.com/docs/foo/bar
│   │    └── hello.md
|   │
│   └── version-1.0.0
│        ├── foo
│        │   └── bar.md      # https://mysite.com/docs/1.0.0/foo/bar
│        └── hello.md
├── versioned_sidebars/
│   ├── version-1.1.0-sidebars.json
│   └── version-1.0.0-sidebars.json
│
├── docusaurus.config.js
└── package.json

Path
Web route

docs/guides/hello.md
http://mysite.com/docs/next/hello

versioned_docs/version-1.1.0/hello.md
http://mysite.com/docs/hello

versioned_docs/version-1.0.0/hello.md
http://mysite.com/docs/1.0.0/hello

Tagging a new version

First, finsh your work on docs . A version always should be based from master.
Enter a new version number

yarn docusaurus docs:version 1.1.0

When tagging a new version, the document versioning mechanism will:

Copy full docs/ folder contents into a new versioned_docs/version-<version>/ folder.
Copy sidebars file and alter it. Saved as versioned_sidebars/version-<version>-sidebars.json.
Place a new version number in versions.json

Files
Creating new files

Place the new file into correspondent version folder.
Include the reference for the new file into correspondent sidebar file, according version number.

Master docs
# the new file
docs/new.md

# edit the correspondent sidebar
sidebar.js

Older docs
# the new file
versioned_docs/version-1.0.0/new.md

# edit the correspondent sidebar
versioned_sidebars/version-1.0.0-sidebar.json

Linking files

Remember to include the .md extension.
Files will be linked to correct corresponding version
Relative paths work as well

The [@hello](hello.md#paginate) document is great!

See the [Tutorial](../getting-started/tutorial.md) for more info.

Versions
Each subfolder in versioned_docs/ will represent a documentation version
Updating a existent version
You can update multiples docs versions at the same time. Because each docs/ subfolder represents specifics routes when published.

Edit any file.
Commit and push changes.
It will be published to the correspondent version.

Example: When you change any file from versioned_docs/version-2.6/, it will publish changes only for 2.6 docs version.
Changes from v1

Read up https://v2.docusaurus.io/blog/2018/09/11/Towards-Docusaurus-2#versioning first for reasoning on v1's problem
We use snapshot now, every versioned docs does not depends on other version. It is possible to have foo.md in version-1.0.0 but it doesn't exist in version-1.2.0. This is not possible in previous version due to Docusaurus v1 fallback functionality (https://docusaurus.io/docs/en/versioning#fallback-functionality )
Unlike v1, The markdown header for each versioned doc is no longer altered by using version-${version}-${original_id} as the value for the actual id field. See scenario below for better explanation.

Example, you have a docs/hello.md.
---
id: hello
title: Hello, World !
---
Hi, Endilie here :)

When you cut a new version 1.0.0
In Docusaurus v1, website/versioned_docs/version-1.0.0/hello.md looks like this
---
id: version-1.0.0-hello
title: Hello, World !
original_id: hello
---
Hi, Endilie here :)

In comparison, Docusaurus 2 website/versioned_docs/version-1.0.0/hello.md looks like this (exactly same as original)
---
id: hello
title: Hello, World !
---
Hi, Endilie here :)

Since we're going for snapshot and allows people to move (and edit) docs easily inside version. The id frontmatter is no longer altered, it's gonna be keep as it is. But internally it is set as version-${version}/${id}

Refer to versioned_docs id as version-${version}/${id} (v2) instead of version-${version}-${original_id} (v1).

Why ? because in v1 there is a good chance someone created a new file with front matter id "version-${version}-${id}" that can conflict with versioned_docs id
Example, docusaurus 1 can't differentiate docs/xxx.md
---
id: version-1.0.0-hello
---
Another content

and  website/versioned_docs/version-1.0.0/hello.md
---
id: version-1.0.0-hello
title: Hello, World !
original_id: hello
---
Hi, Endilie here :)

Since we don't allow / in v1 & v2 for frontmatter, conflict is less likely.
So v1 users need to migrate their versioned_sidebars file
Example:
{
  "version-1.0.0-docs": {
    "Test": [
+    "version-1.0.0/foo/bar",
-    "version-1.0.0-foo/bar",
    ],
    "Guides": [
+    "version-1.0.0/hello",
-    "version-1.0.0-hello"
    ]
  }
}

Have you read the Contributing Guidelines on pull requests?
yes
TODO (will keep updated)

[x] Generate all correct metadata and pages route if website has versioning
[x] Relative linking works in versioned docs
[x] Check no regression for basic site functionality
[x] Split generated routes by version so that routes looks like this

import React from "react";
import ComponentCreator from "@docusaurus/ComponentCreator";

export default [
  {
    path: "/",
    component: ComponentCreator("/"),
    exact: true
  },
  {
    path: "/docs/1.0.0/:route",
    component: ComponentCreator("/docs/1.0.0/:route"),
    routes: [
      {
        path: "/docs/1.0.0/foo/bar",
        component: ComponentCreator("/docs/1.0.0/foo/bar"),
        exact: true
      },
      {
        path: "/docs/1.0.0/foo/baz",
        component: ComponentCreator("/docs/1.0.0/foo/baz"),
        exact: true
      },
      {
        path: "/docs/1.0.0/hello",
        component: ComponentCreator("/docs/1.0.0/hello"),
        exact: true
      }
    ]
  },
  {
    path: "/docs/next/:route",
    component: ComponentCreator("/docs/next/:route"),

    routes: [
      {
        path: "/docs/next/advanced-plugins",
        component: ComponentCreator("/docs/next/advanced-plugins"),
        exact: true
      },
      {
        path: "/docs/next/using-plugins",
        component: ComponentCreator("/docs/next/using-plugins"),
        exact: true
      },
      {
        path: "/docs/next/using-themes",
        component: ComponentCreator("/docs/next/using-themes"),
        exact: true
      }
    ]
  },
  {
    path: "/docs/:route",
    component: ComponentCreator("/docs/:route"),
    routes: [
      {
        path: "/docs/foo/bar",
        component: ComponentCreator("/docs/foo/bar"),
        exact: true
      },
      {
        path: "/docs/hello",
        component: ComponentCreator("/docs/hello"),
        exact: true
      }
    ]
  },
  {
    path: "*",
    component: ComponentCreator("*")
  }
];

[x] Work on the cut version command (i will do in separate PR i think)
[ ] Create an automated cli tools to convert v1 versioned docs to v2 structure ??? (doing this in separate PR, we dogfood the versioning first)
[x] Close https://github.com/facebook/docusaurus/issues/1792
[ ] Docs (separate PR)

Blockers

[ ] Generic Dropdown in Navbar like infima dropdown. (still waiting for mobile support in infima)

Syntax
// docusaurus/config.js
module.exports = {
  themeConfig: {
    navbar: {
      links: [
        {
          to: 'docs/docusaurus.config.js',
          label: 'docusaurus.config.js',
          items: [
            {
              to: 'docs/docusaurus.config.js#required-fields',
              label: 'Required Field'
            },
            {
              to: 'docs/docusaurus.config.js#optional-fields',
              label: 'Optional Field'
            }
          ]
        },
        // ... other links
      ],
    }
}

Test Plan

All codes added is unit tested. We still maintain 100% docs plugin test coverage so regression from this PR in functionality is less likely.

I added lot of tests to ensure everything works perfectly

TBD

Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

I think this should be eligible for first round of review. This PR is getting big already. What's left is quite isolated from current PR.

Cutting the docs version (fairly easy)
Converting v1 versioned_docs to v2 (I think that should be in separate PR). Or even better we dogfood the versioning first for v2 users only)
UI. There are blockers from infima such as waiting for mobile support on navbar dropdown

Alright I've cut alpha.35 docs for this preview with the new command.
This is ready for review. I will feel bad if I keep adding more stuff and make this PR bigger.
Pretty satisfied with 100% test coverage and a lot and lot of tests
Works needed that will be done in separate PR is

Converting v1 versioned_docs to v2 (I think we shouldn't do this yet, we dogfood the versioning first for v2 users only. After it has endured several alpha versions, we'll let v1 versioned site migrate.
Documentation (separate PR, but the content can be seen from this PR)

Let's ship it without the cut docs for now. To make this PR smaller and easy to look in the future

🚀 Ship it ....


text:
fix(v2): markdown title parser should ignore all forms of MDX import statements

Motivation
Currently the markdown title can be parsed after some kind of import statements. For example:
import Component1 from '@site/src/components/Component1';

import './styles.css';

# Markdown Title

Lorem Ipsum

This PR allow the most of import syntaxes.
import DefaultComponent from '@site/src/components/Component1';
import DefaultComponent2 from '../relative/path/Component2';
import * as EntireComponent from './relative/path/Component3';

import { Component4 } from "double-quote-module-name";
import { Component6 as AliasComponent6 } from "module-name";
import DefaultComponent8, { DefaultComponent81 } from "module-name";
import DefaultComponent9, * as EntireComponent9 from "module-name";

import _ from 'underscore';
import "module-name";

# Markdown Title

Lorem Ipsum

Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Already added test for the change.
Related PRs
From @slorber's suggestion in #4729.
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

thanks for this :) looks great

authors: nam-hle slorber


text:
fix(core): various broken anchor link fixes

Motivation
Fix some edge cases in the newly released (v3.1) broken link checker anchor support
Previous implementation did not report broken local anchor links such as [local link](#local-heading-id), among other things. As a result it didn't detect all the broken links we had on our own website.
Also fix https://github.com/facebook/docusaurus/issues/9717, edge case related to encoding of the anchor id
MDX elements such as <li> (used in footnotes), and <details> should also collect anchor ids
I'll explore making this more automatic in the future but for now it's a good-enough improvement.
Test Plan
unit tests + dogfood
Test links
https://deploy-preview-9732--docusaurus-2.netlify.app/

Thank you!

authors: ravilach slorber


text:
Backspacing and deletion of immutable/segmented entities handled incorrectly with some Android keyboards

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
When backspacing using some Android keyboards such as the Google keyboard, no key events are fired and no key codes are provided by the input event data when editOnInput gets called. This is an issue with the keyboard and is not likely to be fixed in the near future, if at all. As a result of this issue, backspacing cannot currently be detected before the editOnInput event fires and is being handled incorrectly. Among other problems, the selection state being used in editOnInput is incorrect and there is no support for deleting entities.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. You can use this jsfiddle to get started: https://jsfiddle.net/stopachka/m6z0xn4r/.
This bug is reproducible on Android phones using the Google keyboard. It can be reproduced by inserting an immutable entity into the editor and then trying to delete it by backspacing into it.
What is the expected behavior?
The expected behaviour is that backspacing is handled the same on Android devices as it is with other devices, including entity deletion.
Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?
This issue affects all versions of Draft.js on Android.

Merging this into general android bug issue - see https://github.com/facebook/draft-js/issues/1895

authors: flarnie mmmoussa

repo: facebook/draft-js


text:
After using Modifier.setBlockData selection in currentContent is changed

After using Modifier.setBlockData the selection in the current content is being changed to the passed by selectionState. This is in my opinion wrong behaviour. The submitted blockData shall be applied to the given selectionState, but the selection in the editor must not be changed!

Any news on this?

Closing because of inactivity.


text:
Link example is broken

This is a bug where opening examples/link/link.html  trying to create a 'link' throws an error.
Marking this 'high-priority' because it's blocking manual testing of other bug fixes and PRs.
In Chrome:
Uncaught TypeError: Cannot read property 'create' of undefined

In Firefox it throws a more informative error:
TypeError: Entity is undefined
_confirmLink()
browser.js%20line%203193%20%3E%20Function:93
bound _confirmLink()
self-hosted
bound bound _confirmLink()
self-hosted
[64]</ReactErrorUtils.invokeGuardedCallback()
react.js:11110
executeDispatch()
react.js:2891
executeDispatchesInOrder()
react.js:2914
[17]</executeDispatchesAndRelease()
react.js:2346
[17]</executeDispatchesAndReleaseTopLevel()
react.js:2357
forEach()
self-hosted
bound call()
self-hosted
Call()
es6-shim.js:278
forEach()
es6-shim.js:1298
forEachAccumulated()
react.js:17732
[17]</EventPluginHub.processEventQueue()
react.js:2533
runEventQueueInBatch()
react.js:11135
[65]</ReactEventEmitterMixin.handleTopLevel()
react.js:11146
handleTopLevelImpl()
react.js:11224
[114]</Mixin.perform()
react.js:16987
[59]</ReactDefaultBatchingStrategy.batchedUpdates()
react.js:10324
batchedUpdates()
react.js:14689
[66]</ReactEventListener.dispatchEvent()
react.js:11301
bound ()
self-hosted
browser.js%20line%203193%20%3E%20Function:93:11

This is also affecting examples/media/media.html.
There is something wrong with the examples/tex/ example, which could be related. Will open a separate issue for that if it ends up not being related.

i got a lot of other errors when i tried implement Link example

So in #376 the 'Entity' module was deleted, but it looks like examples are still trying to use it in some cases. That is one part of the issue. Looking into whether we should put back part of the 'Entity' module or if there is a new syntax that should be used. cc @johanneslumpe
None of this should affect version 0.9.1, which does not include the #376.

Just updating - the new syntax is:
    const contentStateWithEntity = contentState.createEntity(
      'LINK',
      'MUTABLE',
      {url: urlValue}
    );
    const entityKey = contentStateWithEntity.getLastCreatedEntityKey();

I have a fix for the link example, but still working on fixing the media example.

@flarnie sorry for commenting late - I'm currently moving. I thought I updated the examples though. Sorry for missing that!

The documentation seems to be lagging behind on this one too.  That'd be good to keep in sync.

@ajhyndman you're still kind of right - I haven't addresses the documentation when making the PR. As soon as I have some free time I will send another PR to update the docs to match this feature.
cc @flarnie

@flarnie I'm trying to implement the media.html logic in my own component, following everything exactly like in the demo.
When I use
 const contentStateWithEntity = contentState.createEntity(       'LINK',       'MUTABLE',       {url: urlValue}     );     const entityKey = contentStateWithEntity.getLastCreatedEntityKey();
I get an exception: createEntity is not a function.
On the media.html it works fine, on my end it doesn't.
media.html uses version 0.9.0.
I'm using 0.9.1.
I tried following your conversation over here, not 100% sure what's the outcome of your discussion.
Any chance you can help?
Thanks!

@ar7casper There is no version 0.9.1 yet. The new entity handling is only available in the master branch as of now, not in a release.

@johanneslumpe got it.
So what do you recommend me doing in that case?

@ar7casper either use the master branch in your application or use the "legacy" version of doing things, which can be seen in the examples bundled with version 0.9.1. I cannot vouch for the stability of master, but using it will reduce quite a few pain points around entities.

Still getting same error as @flarnie when I'm using versions 0.9.0 (which I assume is the master) or 0.9.1.
Not sure what I'm missing. My examples work but when running it through webpack with draft-js installed via npm, the error appears.
Any suggestions?
Thanks!

@fanus the version on npm does not include the new entity handling. 0.9.0 is not master. Master has the new entity handling merged in. What is your exact issue?

Getting the "createEntity is not a function error".
I will try cloning again and manually include the src from master into my
app (bypassing npm). Based on your response I assume that might solve my
issue.
Will report back of the error persists.
On 03 Oct 2016 12:27 AM, "Johannes Lumpe" notifications@github.com wrote:

@fanus https://github.com/fanus the version on npm does not include
the new entity handling. 0.9.0 is not master. Master has the new entity
handling merged in. What is your exact issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/draft-js/issues/676#issuecomment-251000494,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABL7XsBRweqz-9u6TJko8NWlH951Xrnyks5qwC_UgaJpZM4KCH6b
.

when will it be pushed to master?

This is on master.

sorry, I mean to npm

It's a bit confusing that the examples are up to date with master and not with the latest stable branch. Any plans to release the current master branch on NPM?

@flarnie - any chance you have an update on this?

Here is the old link example. It works nicely for people using version 0.9.0

authors: Fanus StevenIseki ajhyndman ar7casper davidchang flarnie johanneslumpe jonaswindey optimatex rovansteen


text:
Class instances flow to interface constraints without validating statics

Given the following, Flow doesn't generate any errors:
interface I {
  static x: number;
  static fn(): number
}

class Impl {
  static x: string;
  static fn(): string {
    return "some string";
  }
};
Impl.x = "another string";

function f(c: I): number {
  return c.constructor.fn();
}

var i = new Impl();
var n: number = f(i);

Flow should flag both members of Impl as incompatible with the corresponding members of I, right?  (I stumbled on this when babel 6.5.2--latest npm version--choked on an interface that includes the static "unexpected token" before a static method's signature.  Before I open a bug report over there, I want to verify that interfaces are intended to include statics--I asked this over at #803 a while back, but it was never really resolved.)

@popham there seem to be some inconsistencies in what Flow is doing right now. Here's some strange behavior I'm observing in 0.42.0:
/* @flow */

interface I {
  static x: number;
}

class Impl implements I {
  static y: number;
}

const iClass: Class<I> = Impl;
const implClass: Class<Impl> = Impl;

console.log(iClass.y);
console.log(iClass.x);
console.log(implClass.y);
console.log(implClass.x);

14: console.log(iClass.y);
                       ^ property `y`. Property not found in
14: console.log(iClass.y);
                ^ statics of I
17: console.log(implClass.x);
                          ^ property `x`. Property not found in
17: console.log(implClass.x);
                ^ statics of Impl

There should probably also be an error since Impl doesn't fully implement I, but Flow is noticing that iClass does have the static x while it doesn't have y.

authors: popham wbyoung

repo: facebook/flow


text:
Introduce new type DOMEventTarget and use it to replace type EventTarget in SyntheticEvent

In the flow-type definitions of SyntheticEvent, the properties currentTarget and target are defined as type EventTarget
declare class SyntheticEvent {
    bubbles: boolean;
    cancelable: boolean;
    currentTarget: EventTarget;
    defaultPrevented: boolean;
    eventPhase: number;
    isDefaultPrevented(): boolean;
    isPropagationStopped(): boolean;
    isTrusted: boolean;
    nativeEvent: Event;
    preventDefault(): void;
    stopPropagation(): void;
    +target: EventTarget;
    timeStamp: number;
    type: string;
    persist(): void;
}

https://github.com/facebook/flow/blob/39f8e3e9433b7220db9b8066cc74addbceeea9ed/lib/react.js#L277
However, if I look at react SyntheticEvent, it says the attributes currentTarget and target are of type DOMEventTarget.

boolean bubbles
boolean cancelable
DOMEventTarget currentTarget
boolean defaultPrevented
number eventPhase
boolean isTrusted
DOMEvent nativeEvent
void preventDefault()
boolean isDefaultPrevented()
void stopPropagation()
boolean isPropagationStopped()
DOMEventTarget target
number timeStamp
string type

https://facebook.github.io/react/docs/events.html
In fact, I just noticed that the nativeEvent attribute is defined as a DOMEvent in reactjs docs, but as an Event in flow.
By defining the target and currentTarget as type EventTarget,  DOM attributes such as id and class are not detected by flow and it throws an error. e.g.
handleClick(evt: SyntheticEvent) {
    const selectedTaskId = evt.currentTarget.id.split('*')[1];
    dispatch({type: 'viewtask', selectedTaskId: selectedTaskId })
  }

gives the flow error
16:     const selectedTaskId = evt.currentTarget.id.split('*')[1];
                                                 ^^ property `id`. Property not found in
16:     const selectedTaskId = evt.currentTarget.id.split('*')[1];
                               ^^^^^^^^^^^^^^^^^ EventTarget

Perhaps, the correct thing to do would be to introduce a DOMEvent and DOMEventTarget and use these so that DOM attributes like id are detected?

Also met this today

Please see the fix is here: https://github.com/facebook/flow/issues/218

After upgrading flow and referring to the docs at https://flow.org/en/docs/react/events/ I was able to correctly use this.

authors: RusAlex singhshashi


text:
Nesting generic react components throws error if callback with generic is included

We have two react component, whereby both of them have a generic type. The generic type is used in a prop called value and in a callback. One of these react components uses the other one, and this is leading to some errors.
I have created the following minimum example showing this error (which I would say is not correct) in this flow try. The code looks something like this: (copied from the flow try)
// @flow
import React from 'react';

type Props<T> = {
  onChange: (T) => void,
  value: T,
};

class C2<T> extends React.Component<Props<T>> {

}

class C1<T> extends React.Component<Props<T>> {
  handleChange = (value: T) => {
  	this.props.onChange(value);
  };

  render() {
    return <C2
      onChange={this.handleChange}
      value={this.props.value}
    />;
  }
}

I am currently using flow 0.71.0, but the issue also seems to exist in the latest release.

This has to do with the fact that handleChange is declared as a class
property. It suffices to desugar the property manually:
class C1<T> extends React.Component<Props<T>> {
  handleChange: T => void;

  constructor(props) {
    super(props);
    this.handleChange = (value: T) => {
      this.props.onChange(value);
    };
  }

  render() {
    return <C2 onChange={this.handleChange} value={this.props.value} />;
  }
}

It similarly suffices to declare handleChange as a function rather
than a class property:
class C1<T> extends React.Component<Props<T>> {
  handleChange(value: T): void {
    this.props.onChange(value);
  }

  render() {
    return (
      <C2 onChange={this.handleChange.bind(this)} value={this.props.value} />
    );
  }
}

I agree that this behavior is a bug: Flow should accept both versions.

@wchargin Thanks for letting us know how to fix it! Would still be nice if the bug would be fixed one day :smiley:

No longer errors

authors: SamChou19815 danrot wchargin


text:
Typo; possible also secondary issue

The typo I picked up was on List#min():
Returns the maximum value in this collection. If any values are comparatively equivalent, the first one found will be returned.
min(comparator?: (valueA: V, valueB: V) => number): V
The secondary concern I noticeed was that I tried briefly to navigate to the master copy, fork, change it, and issue a pull request. But I couldn't immediately find where

Sorry, dumb me hit the wrong button.
I couldn't immediately find where to navigate to the file in question; perhaps facebook / immutable-js / docs could be created with a stub saying "If you want to change the docs, they're over at _______."

Hey @JonathanHayward thanks for the report.
For future reference, if you scroll to the bottom of any of the pages in the docs, there's a red box explaining that they are autogenned with links to the relevant files.

Thanks!
On Mon, Mar 2, 2015 at 2:44 PM, Lee Byron notifications@github.com wrote:

Hey @JonathanHayward https://github.com/JonathanHayward thanks for the
report.
For future reference, if you scroll to the bottom of any of the pages in
the docs, there's a red box explaining that they are autogenned with links
to the relevant files.
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/immutable-js/issues/354#issuecomment-76816073
.

--
[image: Christos Jonathan Seth Hayward] http://jonathanscorner.com/
Jonathan S. Hayward, a full stack web developer with Python/Django and
AngularJS/jQuery.
Articles on Technology http://jonathanscorner.com/technology/ • Book: Django
JavaScript Integration
http://www.packtpub.com/django-javascript-integration-ajax-and-jquery/book
• Email jsh@jsh.name • Github http://github.com/JonathanHayward •
LinkedIn http://www.linkedin.com/in/jonathanhayward • Main Website
http://jonathanscorner.com/ • Professional Site http://jsh.name/
I invite you to visit my professional site! http://jsh.name/

authors: JonathanHayward leebyron

repo: facebook/immutable-js


text:
Run error

I used in carthage. Then when run tests. It occurs error:
2017-04-11 10:08:37.433 SnapDemo[70214:38529003] Failed to load test bundle from file:///Users/zouliangming/Library/Developer/Xcode/DerivedData/SnapDemo-gxljashuxqwkkcabgwojzlpyduyt/Build/Products/Debug-iphonesimulator/SnapDemo.app/PlugIns/SnapDemoTests.xctest/: Error Domain=NSCocoaErrorDomain Code=3587 "dlopen_preflight(/Users/zouliangming/Library/Developer/Xcode/DerivedData/SnapDemo-gxljashuxqwkkcabgwojzlpyduyt/Build/Products/Debug-iphonesimulator/SnapDemo.app/PlugIns/SnapDemoTests.xctest/SnapDemoTests): Library not loaded: @rpath/FBSnapshotTestCase.framework/FBSnapshotTestCase

My mistake. Sorry.

repo: facebook/ios-snapshot-test-case