text:
Roll Flutter Engine from f721db653dd1 to 8903904389dc (1 revision)

https://github.com/flutter/engine/compare/f721db653dd1...8903904389dc
2022-11-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Y30GJYiorAEkSGP_l... to HIyR3VT4K1bz5xMC_... (flutter/engine#37189)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Y30GJYiorAEk to HIyR3VT4K1bz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


text:
Remove Tooltip mouse tracker listener & update hovering/MouseRegion logic & animation

Fixes https://github.com/flutter/flutter/issues/117627
Behavior changes:

If fade in/fade out animation is already in progress, hiding/showing the tooltip will immediately take effect without waiting for waitDuration.
Removed _revealLastTooltip  (not sure what that was meant for)
A PointerDownEvent that doesn't become a part of a "trigger" gesture dismisses the tooltip, even for hovered ones.
The OverlayEntry is now updated only when the previous tooltip was completely dismissed. This can be fixed by OverlayPortal but I'm not sure what the correct behavior is.

Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

The _revealLastTooltip was to deal with nested widgets which each had a tooltip on them so that only the deepest one would be shown.  See the before/after videos in this PR:
https://github.com/flutter/flutter/pull/90457

Ah because MouseRegion doesn't notify you when you move from the inner MouseRegion to the outer one?

Ah because MouseRegion doesn't notify you when you move from the inner MouseRegion to the outer one?

Yes.

Hi @gspencergoog would you like to take a look at this one when you get a chance?

Setting Google Testing to passing: the failures were expected, LGTM'ed by internal customer.

source: gharchive/pull-request

authors: LongCatIsLooong gspencergoog

repo: flutter/flutter

license_type: permissive

license_source: github-api


text:
[Material 3] Chips showCheckmark from theme being ignored

M3 chips, it looks like the RawChip widget itself ignores the showCheckmark from the themes, because its instance value (priority) has a default = true on the constructor.
Previously, the checkmark in the ChoiceChip component was not being hidden when using Material 3.
To address this issue, we have added two new parameters to the ChoiceChip component. The first parameter, showCheckMark, allows us to hide or show the checkmark based on true/false conditions. The second parameter, checkMarkColor, provides the ability to customize the colour of the checkmark displayed.
With these changes, the ChoiceChip component now works as expected with Material 3, and provides greater flexibility and control over the display of the checkmark.
Fixes #119163
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Thanks @GayathrideviGA, this is a nice improvement. Please consider adding these capabilities to Chip theming as well.
Theming should imo always be on par with widget styling capabilities and with what M3 defaults can deliver. Otherwise we negate the usefulness of theming as a concept and force users to the poor practice of using widget styling over making the theme match your general design need.
The Chip theming is sadly already a bit flawed and has a number of issues making it impossible to with themes reproduce the M3 styles, using e.g. different colors, see https://github.com/flutter/flutter/issues/115364
cc @HansMuller @guidezpl

Maybe it is already in there, I might have missed it. The theme has checkMark and color for it, so if it already using them as fallback after new widget props and before M2/M3 defaults, it should be fine.
I forgot how messy the Chip variant implementations are. Considering that they still don't support correct M3 specs, and we cannot recreate the variants with theming, using different colors choices than you get via defaults. I'm still torn between if it was the right choice to re-use the old M2 widget as base for creating the M3 versions.

Hi @GayathrideviGA
I just reviewed https://github.com/flutter/flutter/pull/124743 and it looks like it addresses the same issue and also contains the test and it was also filed before this PR.
Thank you for your contribution. Next time please confirm a PR is already open for an issue that addresses it. I'm closing this.

authors: GayathrideviGA TahaTesser rydmike


text:
Roll Flutter Engine from 1376288f5c2a to da3ad0776b01 (1 revision)

https://github.com/flutter/engine/compare/1376288f5c2a...da3ad0776b01
2024-09-17 skia-flutter-autoroll@skia.org Roll Skia from 0409718f34c6 to be871a37a154 (1 revision) (flutter/engine#55250)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


text:
Remove unused import from kt plugin template

Remove import as @NonNull is no longer used by https://github.com/flutter/flutter/pull/129472.

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Is there anything I can do for the autosubmit label? Thank you.


text:
[LAND] Add dropdownbutton form field convenience class

This is a basic wrapper for the DropdownButton Widget to use it as a part of a form. I didn't see anything similar that was already extant, though if I missed something, please let me know.

  @override
  Widget build(BuildContext context) {
    return new Scaffold(
      appBar: new AppBar(
        title: new Text("DropdownButtonFormFieldDemo"),
      ),
      body: new Builder(
        builder: (BuildContext context) {
          return new Container(
            padding: const EdgeInsets.all(12.0),
            child: new DropdownButtonFormField(
                value: _value,
                hint: new Text("Select value"),
                decoration: new InputDecoration(
                  prefixIcon: const Icon(Icons.fastfood),
                ),
                items:
                  ["First", "Second", "Third"].map((v) {
                    return new DropdownMenuItem(
                        value: v,
                        child: new Text(v));
                  }).toList(),
                onChanged: (v) {
                  setState(() {
                    _value = v;
                  });
                },
                validator: (v) => v == null ? "Must select value" : null
          ));
        },
      )
    );

This will need a small test to verify that we don't regress having this widget (otherwise we might delete it one day thinking it's dead code).

(Sorry it took so long for us to review this PR.)

@Hixie let me know if this test will work or if it needs something more comprehensive.

looks great, thanks!

looks great, thanks!

@ihildebrandt  I'm going to close this PR since you're not working on it right now, but if you have time to come back to it please don't hesitate to reopen or open a new one or whatever, and if you need anything please don't hesitate to cc me. Thanks!

Seems to work well, shame it's gone quiet and been closed. For anyone else finding this (like I did), you'll need to add isEmpty: value == null to the InputDecorator to ensure that the label expands accordingly when nothing is selected.

authors: Hixie dereklakin ihildebrandt


text:
Roll engine 8b1a299ed52d..246f0e3f4ab4 (20 commits)

https://github.com/flutter/engine/compare/8b1a299ed52d...246f0e3f4ab4
git log 8b1a299ed52d4ef9521ccd65c6c52d563129d8af..246f0e3f4ab402ece70784d86f3c0a230c40c02a --no-merges --oneline
246f0e3f4 Add an allocator specific check to ensure that strings passed to the timeline are not heap allocated. (flutter/engine#8168)
7a6bb9998 Roll src/third_party/skia feb720f746dc..512e38091c85 (11 commits) (flutter/engine#8169)
5825bdac9 Roll src/third_party/dart 7d560f8385..7418238239 (61 commits)
66fdeb163 Add dump-shader-skp switch to help ShaderWarmUp (flutter/engine#8148)
403337ebb Do not pass short-lived buffers as labels to Dart_TimelineEvent (flutter/engine#8166)
e514f0bd1 Ensure that typed data is released within SendPlatformMessage scope. (flutter/engine#8155)
f2b42d6c5 Roll src/third_party/skia f699bf0437db..feb720f746dc (15 commits) (flutter/engine#8165)
fbca3d34e Roll src/third_party/skia 5412618d503c..f699bf0437db (2 commits) (flutter/engine#8164)
23cff1a1c Roll src/third_party/skia 8b9b8f8c5846..5412618d503c (1 commits) (flutter/engine#8163)
bbd58fab5 Roll src/third_party/skia 1386b2d5579d..8b9b8f8c5846 (3 commits) (flutter/engine#8162)
cdf55a8d7 Roll src/third_party/skia 29d5dec9a078..1386b2d5579d (123 commits) (flutter/engine#8161)
cae083657 Roll src/third_party/dart 1bd36d694d..7d560f8385 (27 commits)
fcc66fc23 Suppress deprecation warning for use of Build.CPU_ABI (flutter/engine#8154)
fdad56f5f Anti-Aliasing for shape layers (flutter/engine#8157)
906d684a7 Reland ""Add support for trace counters with variable arguments and instrument the raster cache." (flutter/engine#8145)
3c9381783 Add “full-dart-debug” that disabled optimizations in the Dart VM. (flutter/engine#8147)
b1b388f1c Encode scroll motion events in the Android touch processor (flutter/engine#8149)
2daebebf4 Fix text.dart height docs (flutter/engine#8079)
2e427030f Revert "Disable build_ios task due to lack of credits. (#8150)" (flutter/engine#8153)
8be2aca56 Roll src/third_party/dart 1bd36d694d..674fd0e060 (48 commits) #8152
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/4898025502670848

Commit queue failed; closing this roll.


text:
find all repo packages

move the logic to find the repo's project packages into one location (fix https://github.com/flutter/flutter/issues/3359)
use it from update-packages and analyze
fix some issues in dev/benchmarks/complex_layout and examples/hello_android/app/src/flutter

fix https://github.com/flutter/flutter/issues/3157

This is great.

Happy to take another look if you decide to change this substantially based on my last comment above, but either way is fine.

I updated this to use a marker file (.dartignore). It doesn't have any content - unlike .gitignore files. If this works out I'll roll the same logic into the atom plugin.

LGTM!

authors: Hixie devoncarew


text:
Fix quotes error in update flutter bash script

Fixes:
$ flutter upgrade
/flutter/flutter/bin/flutter: line 16: [: !=: unary operator expected
Could not find a command named "upgrade".

Sorry, I am not sure what's happened.
`cat "$STAMP_PATH"` looks ok. Maybe REVISION was empty so a comparison was like:
if [ "1ddc71aa460d604bb52be3e4713f35b847c6aa7" =  ] instead of if [ "1ddc71aa460d604bb52be3e4713f35b847c6aa7" =  "" ]
Anyway, I can't reproduce it anymore.

I think it would be reasonable to quote $REVISION.

LGTM, thanks!

authors: IvBaranov abarth


text:
Remove ModalPosition (for real)

It has no more clients.
Follow-up to #3734.
Fixes #2484.

@abarth

Crazy, I thought I did that.  LGTM

authors: Hixie abarth


text:
Add BoxDecoration styling to CupertinoPicker

Description
Allow user to add box decoration styling to CupertinoPicker. Right now background is changeable but ideally the border line of magnifier screen color should be customisable to match background color.
CupertinoPicker(
  itemExtent: 50,
  decoration: BoxDecoration(
    border: Border(
      top: BorderSide(width: 0.0, color: CupertinoColors.activeGreen),
      bottom: BorderSide(width: 0.0, color: CupertinoColors.activeOrange),
    ),
  ),
  onSelectedItemChanged: (int index) {},
  children: List<Widget>.generate(10, (int index) {
    return Center(
      child: Text(index.toString()),
    );
  }),
);

Related Issues
Tests
I added a test in packages/flutter/test/cupertino/picker_test.dart
Creating a CupertinoPicker with BoxDecoration given a custom color
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I signed the [CLA].
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
[x] No, this is not a breaking change.

I have signed in!

@googlebot I signed it!

Thanks for the pull request! The approach looks good to me, but I'm not sure if we still need this new parameter once https://github.com/flutter/flutter/pull/39919 relands.
In https://github.com/flutter/flutter/pull/39919, the borders become translucent (in accordance with https://developer.apple.com/design/resources/):
/// Color of the 'magnifier' lens border.
const Color _kHighlighterBorder = CupertinoDynamicColor.withBrightness(
  color: Color(0x33000000),
  darkColor: Color(0x33FFFFFF),
);

Hi @terryx it seems #39919 has relanded in the master branch. Does that change cover your use case?

I believe so, let me close this.

authors: LongCatIsLooong terryx


text:
[flutter_tools] don't print shuffling message when shuffle is zero or  null

Description
don't pass shuffle if the user does not want to shuffle, since this results in test printing out a message confirming the seed.
Fixes https://github.com/flutter/flutter/issues/51010

Closing in favor of https://github.com/flutter/flutter/pull/51018


text:
Allow selection controls for SelectableText

Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change. If you're changing visual properties, consider including before/after screenshots (and runnable code snippets to reproduce them).
Related Issues
Fixes #55177
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I signed the CLA.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I updated/added relevant documentation (doc comments with ///).
[X] All existing and new tests are passing.
[X] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[X] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: Replace with a link to your migration guide

@googlebot I signed it!
On Sun, Apr 19, 2020 at 8:44 PM googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot
I signed it! and we'll verify it.
What to do if you already signed the CLA Individual signers

It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.

Corporate signers

Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version https://opensource.google/docs/cla/#troubleshoot).
The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
https://cla.developers.google.com/clas and verify that your email is
set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
The email used to register you as an authorized contributor must
also be attached to your GitHub account
https://github.com/settings/emails.

ℹ Googlers: Go here
https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fflutter%2Fflutter%2Fpull%2F55178
for more info.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/pull/55178#issuecomment-616254249,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAOIHIQKCZE7CC3YKX4YELRNOLF7ANCNFSM4MMA4KHA
.

--
--Stefan Rusek
stefan@rusek.org

Can you explain your reasoning for wanting this feature? I wonder if it won't also be necessary to be able to pass selectionControls to TextField/CupertinoTextField.

In my case, I am porting an existing ebook app from android/ios to flutter, and the app needs to allow rich text with the ability to select sections then add highlights and annotations. So additional actions need to be added to the selection toolbar.
I'd say any widget that allows selection, would benefit from being able to set the selection controls. @justinmc  Does it make sense to pull this stuff into a mixin?

Got it.  The widgets that allow selection right now are TextField and CupertinoTextField, in addition to SelectableText.
What did you have in mind for the mixin?  It might be overkill for just adding the selectionControls param if that's what you're thinking.  I have been meaning to come up with an easy way to add custom items to the selection menu though.  I just finished adding overflow support (https://github.com/flutter/flutter/pull/54140 and https://github.com/flutter/flutter/pull/49391) so I think it's ready to support custom items.

@justinmc In that case I actually think adding the ability to specify custom actions via [ToolbarOptions] would be a better solution than exposing the selection controls. In my app, I have to create a custom selection controls class that delegates to material and cupertino for most of its functionality and it just makes its own toolbar.

Ok, I'm going to look into what this feature would look like and I'll post back later with a quick proposal.  That way you'll have some idea how long the feature would take and what it would look like, and we can decide what to do with this PR.  I don't want to block you from finishing your app port so we'll try to work around that.

@justinmc I actually have the code in this PR in my app, because the app is running on beta channel. My selection control delegates were written back before SelectableText was written. So my app isn't blocked by this PR, but I have spent TONs of time digging through the selection / text classes trying to figure out how to make text selection work like I needed.
My proposal would be to add something like the following:
add
class SelectionAction {
    final WidgetBuilder label;
    final void Function(TextSelectionDelegate delegate) onPressed;
}

add an actions list to [ToolbarOptions] and [TextSelectionDelegate]
List<SelectionAction> get actions;

then have [EditableTextState] which implement [TextSelectionDelegate] just return `toolbarOptions.actions'
List<SelectionAction> get actions => toolbarOptions.actions;

Then replace the following in _CupterinoTextSelectionControls:
void addToolbarButtonIfNeeded(
  String text,
  bool Function(TextSelectionDelegate) predicate,
  void Function(TextSelectionDelegate) onPressed,
) {
  if (!predicate(delegate)) {
    return;
  }

  items.add(CupertinoButton(
    child: Text(
      text,
      overflow: TextOverflow.ellipsis,
      style: _kToolbarButtonFontStyle,
    ),
    color: _kToolbarBackgroundColor,
    minSize: _kToolbarHeight,
    padding: _kToolbarButtonPadding.add(arrowPadding),
    borderRadius: null,
    pressedOpacity: 0.7,
    onPressed: () => onPressed(delegate),
  ));
}

addToolbarButtonIfNeeded(localizations.cutButtonLabel, canCut, handleCut);
addToolbarButtonIfNeeded(localizations.copyButtonLabel, canCopy, handleCopy);
addToolbarButtonIfNeeded(localizations.pasteButtonLabel, canPaste, handlePaste);
addToolbarButtonIfNeeded(localizations.selectAllButtonLabel, canSelectAll, handleSelectAll);

with:
void addToolbarButton(
  Widget label,
  VoidCallback onPressed,
) {
  items.add(CupertinoButton(
    child: DefaultTextStyle(
      child:label,
      overflow: TextOverflow.ellipsis,
      style: _kToolbarButtonFontStyle,
    ),
    color: _kToolbarBackgroundColor,
    minSize: _kToolbarHeight,
    padding: _kToolbarButtonPadding.add(arrowPadding),
    borderRadius: null,
    pressedOpacity: 0.7,
    onPressed: onPressed,
  ));
}

void addToolbarButtonIfNeeded(
  String text,
  bool Function(TextSelectionDelegate) predicate,
  void Function(TextSelectionDelegate) onPressed,
) {
  if (!predicate(delegate)) {
    return;
  }

  addToolbarButton(Text(text), () => onPressed(delegate));
}

addToolbarButtonIfNeeded(localizations.cutButtonLabel, canCut, handleCut);
addToolbarButtonIfNeeded(localizations.copyButtonLabel, canCopy, handleCopy);
addToolbarButtonIfNeeded(localizations.pasteButtonLabel, canPaste, handlePaste);
addToolbarButtonIfNeeded(localizations.selectAllButtonLabel, canSelectAll, handleSelectAll);

for (final action in delegate.actions ?? []) {
  addToolbarButton(
    action.label,
    () => action.onPressed(delegate),
  );
}

and the equivalent change to _MaterialTextSelectionControls.
Additional things that could be done:

make rather than List<SelectionAction> get actions it could be List<SelectionAction> getActions(TextEdtingValue value) so that actions could be dynamic based on what the selected text is, ie phone numbers, addresses etc.
remove can<Action> and <Action>enabled properties and handle<Action> methods and replace them with defaults (from Semantics data) ToolbarOptions.fromContext(BuildContext context), SelectionAction.copy(BuildContext context), SelectionAction.paste(BuildContext context), SelectionAction.cut(BuildContext context), , SelectionAction.selectAll(BuildContext context). This would allow more flexibility in the ordering of items.

@justinmc https://github.com/flutter/flutter/pull/55895

Thanks so much for the quick PR!!  This looks similar to what I was thinking at first glance.  I'll give you a detailed code review tomorrow morning.

Should this be closed assuming that we'll move forward with https://github.com/flutter/flutter/pull/55895?

Yes

authors: justinmc stefanrusek


text:
[a11y] Fix semantics for nested Navigators

Description
ModalBarriers include a BlockSemantics widget, which drops the semantics of all sibling semantics nodes within the same container. It's meant to only drop the semantics of sibling routes, but in some nested navigator situations it may also incorrectly drop the semantics nodes of siblings to the Navigator (if those end up sharing the same semantics container with the ModalBarrier/BlockSemantics widget). This PR fixes the issue by wrapping the Navigator in its own Semantics container to ensure that the siblings semantics nodes of the navigator don't become siblings to the BlockSemantics semantics node.
Related Issues
Fixes https://github.com/flutter/flutter/issues/55758.
Tests
I added the following tests:

test derived from repro case in https://github.com/flutter/flutter/issues/55758

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: Replace with a link to your migration guide

Turns out, this is a breaking change because lots of tests are not expecting the extra semantics node. Functionally, this extra node doesn't change anything, but all those tests will have to be updated.


text:
[flutter_tools] fix tests that depend on correct cache existance

Description
These tests will hit the real Cache, failing if the flutter root has been modified

Started Google testing for this PR

authors: flutter-github-sync jonahwilliams


text:
Implement Router widget and widgets app api

Description
Introduce router widget and widgets app api, I will include the stock app rewrite in a separate pr once we agree on the api details
stock app rewrite draft https://github.com/chunhtai/flutter/pull/2
Related Issues
https://github.com/flutter/flutter/issues/45938
Tests
I added the following tests:
See files
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I signed the CLA.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[ ] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

a friendly bump

FWIW, it's hard for me to evaluate the API really without the stocks app migration as well.

FWIW, it's hard for me to evaluate the API really without the stocks app migration as well.

Check out this link https://github.com/chunhtai/flutter/pull/2

Can you talk about the RouteInformation stuff and how it corresponds to what was in the original design? I'm trying to understand how the old design maps to this one.

The RouteInformation is trying to support the browser history entry(which contains both url and a state object), https://docs.google.com/document/d/1QodTFmwVr1yk8dyQvoqkeILxvm92oikB1bVhHTtp6R4/edit#heading=h.4bauy8cp70w0
The reason why we don't want to use the url alone is that something like scroll offset and textfield value do not usually store into query parameter. They are commonly stored into the state of a browser history.
There are also discussions about how do we utilize state restoration. https://docs.google.com/document/d/1d25VJmHJIqoh5Hw4PyvCcl9R4GYdF4AmBRUy-UwB2dQ/edit#heading=h.4qsx9pjitde1
for the lake of a better name, i changed the name RoutePackage in the document into RouteInformation

ready for another look @goderbauer @Hixie @mdebbar
I moved the serialization method into route information provider, and makes the router only report the route information back if the RouteInformation.location has changed. The changes to RouteInformation.configuration alone will not trigger the reporting.

I had to squash all previous commits to resolve merge conflict otherwise it is a nightmare to try to reapply all commits. The changes that aim to address the last review comments from @goderbauer are in the last commit. Beside that, i also choose to rename RouteInformation.configuration back to state because we are already using the name configuration in the route information parser and router delegate. This pr is ready for another look.

This is looking great. My comments are mere minor nits.

This is ready for another look. @goderbauer  changes are in the last commit

Some of my earlier comments, in particular for example the one about how we should not be using JSON, do not seem to yet have been taken into account.

Some of my earlier comments, in particular for example the one about how we should not be using JSON, do not seem to yet have been taken into account.

I didn't use any json encode or decode in the router, the only place that uses it is navigation system channel that use json codec. If we want to get rid of it, we can either convert navigation channel to use standard codec or create a different channel.
I am not sure which is more desirable. also cc @goderbauer

We should convert it to use the standard codec, if we can. I just don't want to be adding any more places where we're converting data to JSON, it's highly inefficient.

@Hixie I opened a separate issue about converting navigation channel https://github.com/flutter/flutter/issues/63121
I would not do it as part of this pr because it may involve multiple stage migration and this pr is already massive
in the meanwhile, I addressed all other comments. This pr is ready for another look @goderbauer and @Hixie

Looks like there are some doc errors.
The StandartMessageCodec/JSON question aside, this LGTM.

addressed all comments, and also updated the stock app rewrite pr https://github.com/chunhtai/flutter/pull/2/files

authors: Hixie chunhtai goderbauer


text:
Make Scrollables restorable

Description
Enabled the Scrollable widgets (ListView, GridView, PageView, etc) to restore their scroll offset with the state restoration framework.
The change is slightly awkward because Scrollables already had a restoration mechanism with PageStorage. The plan is to eventually replace that mechanism with the new state restoration approach once state restoration supports keeping state information around even when the owning widget is getting disposed.
Related Issues
https://github.com/flutter/flutter/issues/62916
Tests
I added the following tests:

Added for all migrated Scrollables and the new RestorationManager.flushData method.

Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

LGTM modulo the async logic in the restoration code

I removed the async logic in the restoration code. It's not necessary and was just leftover from a different approach.

I'll intend to land this when the tree goes green unless I hear otherwise.

authors: Hixie goderbauer


text:
Roll Engine from 38d75c9e77e2 to daa0f7a0747c (4 revisions)

https://github.com/flutter/engine/compare/38d75c9e77e2...daa0f7a0747c
2020-10-24 dnfield@google.com Revert "Add a golden scenario test for fallback font rendering on iOS take 2 (#22033)" (flutter/engine#22095)
2020-10-24 jason-simmons@users.noreply.github.com Reformat some files that were not auto-formatted (flutter/engine#21940)
2020-10-24 fmil@google.com [fuchsia] Adds a test for timezone change (flutter/engine#21934)
2020-10-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from zDfaxkqlv... to kCSI3uPt1... (flutter/engine#22087)
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from zDfaxkqlvQqv to kCSI3uPt1r8L
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.


text:
Roll Engine from 59b4baea5124 to 1c1d27345bf4 (6 revisions)

https://github.com/flutter/engine/compare/59b4baea5124...1c1d27345bf4
2020-12-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from M_8svVndh... to IuiLYXJbt... (flutter/engine#22880)
2020-12-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 1EKjnjmeP... to eEeK509UF... (flutter/engine#22879)
2020-12-04 yjbanov@google.com copy the glibc fix to felt (flutter/engine#22878)
2020-12-04 yjbanov@google.com re-enable pointer events inside platform views (flutter/engine#22874)
2020-12-04 skia-flutter-autoroll@skia.org Roll Skia from fdb8dbe69cc2 to bc3c41b8742a (3 revisions) (flutter/engine#22877)
2020-12-04 skia-flutter-autoroll@skia.org Roll Skia from c0c5106bd4d4 to fdb8dbe69cc2 (8 revisions) (flutter/engine#22872)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from M_8svVndhWML to IuiLYXJbtDJF
fuchsia/sdk/core/mac-amd64 from 1EKjnjmePORP to eEeK509UFvPS
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.


text:
[in_app_purchase] Fix finishing purchases upon payment dialog cancel…

Description
This PR fixes finishing purchases upon payment dialog cancellation on iOS.
When the user cancels the payment dialog there is no transactionIdentifier which means the transaction cannot be finished in the current implementation and therefore not initiated again.
Duplicate of:

https://github.com/flutter/plugins/pull/3074

Related Issues

https://github.com/flutter/flutter/issues/66253
https://github.com/flutter/flutter/issues/66886

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

@googlebot I signed it!

Still getting an error after completePurchase method in iOS 14.0.1.
PlatformException(storekit_invalid_argument, Argument type of finishTransaction is not a Dictionary, null, null)

Hi! I'm experiencing the same error PlatformException(storekit_invalid_argument, Argument type of finishTransaction is not a Dictionary, null, null)

Updated to version 0.3.4+12 but it still not pop up purchase dialog :(. Anyone has same error ??

Updated to version 0.3.4+12 but it still not pop up purchase dialog :(. Anyone has same error ??
@DangKhoi1997 I think dialog not showing up is a different issue and not related to this PR. Apple Pay UI/dialog is not showing up is related to not finishing transactions. Can you try something similar to following code to see if your problem is solved:

class PurchaseService{
    final _connection = InAppPurchaseConnection();

    const PurchaseService(){
          _connection.purchaseUpdatedStream.listen((detail) {
               ...
              // Verify the receipt for succeeded transactions and handle the error for the failed
              // transaction here.
              _connection.completePurchase(detail);
          });
    }
}

you
U cant pass the detail(List) into completePurchase because Future completePurchase(PurchaseDetails purchase,{String developerPayload});
Any workaround to track or clear the transactions ?

@LHLL  U cant pass the detail(List) into completePurchase because Future completePurchase(PurchaseDetails purchase,{String developerPayload});
Any workaround to track or clear the transactions ?

After restarting ip the issue gone but exist when hitting cancel button 3-4 times.

Updated to latest version 0.3.4+12 but we are still not able to buy again whenever we cancel the purchase dialogue. The button works fine if we complete the purchase flow and I am able to buy many time if the purchase flow ends correct, but whenever I cancel and try to tap again the button it won’t open the purchase dialogue. Do we need to add any additional code to our implementation?

Updated to latest version 0.3.4+12 but we are still not able to buy again whenever we cancel the purchase dialogue. The button works fine if we complete the purchase flow and I am able to buy many time if the purchase flow ends correct, but whenever I cancel and try to tap again the button it won’t open the purchase dialogue. Do we need to add any additional code to our implementation?

@daoc13 do you find any solution for this issue :((

Updated to latest version 0.3.4+12 but we are still not able to buy again whenever we cancel the purchase dialogue. The button works fine if we complete the purchase flow and I am able to buy many time if the purchase flow ends correct, but whenever I cancel and try to tap again the button it won’t open the purchase dialogue. Do we need to add any additional code to our implementation?

@daoc13 do you find any solution for this issue :((

@hai199580 I did not find a solution for this issue. I recommend you to use Revenue Cat, we implemented it in 4 hours and it works fine. I will keep using Revenue Cat until this issue is solved. Hope it helps!

repo: flutter/plugins


text:
[url_launcher_web] Fix Link misalignment issue

The Link widget builds a Stack on the web. The Stack by default loosens the constraints passed by the parent. This is what was causing the misalignment.
In order to fix it, we just need to pass fit: StackFit.passthrough to the Stack.
Fixes https://github.com/flutter/flutter/issues/70053

You'll also have to do a quick rebase of the branch after this lands: https://github.com/flutter/plugins/pull/3478
(Apologies, flutter/plugins has been closed for 3 days with very weird issues, I hope the above is the last fix for master)

You'll also have to do a quick rebase of the branch after this lands: https://github.com/flutter/plugins/pull/3478
(Apologies, flutter/plugins has been closed for 3 days with very weird issues, I hope the above is the last fix for master)

Try again, friendly bot, the submit-queue is green!

Try again, friendly bot, the submit-queue is green!

The tree is green, but submit-queue didn't get the memo (issue). Merging.

The tree is green, but submit-queue didn't get the memo (issue). Merging.

authors: ditman mdebbar


text:
[webview_flutter] Migrate more integration tests to local web server

Replaces youtube.com URLs in integration tests with URLs using the local web server
running inside of the integration test.
No CHANGELOG change: Only internal test details are changing
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[ ] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

AFAICT the issue here is that the webview delegate is sometimes (it doesn't happen for me locally) using the delegate from the example, not the test, which suggest there's some kind of race condition and state bleed here. I have no idea why that would be happening though.

I've split video_player changes into https://github.com/flutter/plugins/pull/5103 to unblock those.

Closing until I have time to revisit this and figure out what's going on with the delegate.


text:
Framework not found flutter_image_compress

After importing this package, it shows this error when debugging and compliing:

Actually, I did execute flutter clean and pod install --repo-update, but also not works.
And, the error occurs on here:

We guess, it might be cuased from the version of Mantle, as we locked it on 1.x.
Thanks a lot.

Me too

Me too

same here :(

I had the same problem and I succeeded in fixing it like this:

Fix iOS platform in the iOS Podfile to iOS 12.0 (should be the first line of the file).
Run flutter clean && flutter pub get.
Run pod install --repo-update.
Open Runner.xcworkspace from the iOS folder (NOT xcodeproj).
In Xcode, go to Product > Clean build folder....

I hope this will help you 🙏

same issue after update  Launching lib/main.dart on iPhone 15 Pro in debug mode...
Running Xcode build...
└─Compiling, linking and signing...                      2,289ms
Xcode build done.                                           78.5s
Failed to build iOS app
Error (Xcode): Framework not found flutter_image_compress
Error (Xcode): Linker command failed with exit code 1 (use -v to see invocation)
Could not build the application for the simulator.
Error launching application on iPhone 15 Pro.

source: gharchive/issue

authors: RoleWong amoinier buimanhhungit graceinsel smallooo vlad-ed-git

license: MIT


text:
更新 Flutter 1.17.0 后无法编译

经查：
是 extended_image_slide_page_route.dart 中下图方法缺少参数：

下图是 Flutter 1.17.0 的代码

希望作者尽快升级 extended_image 至最新版
PS：另外打开相册确实非常卡，，非常非常卡。。。不知可有什么优化没，iOS&Andorid

正在思考怎么处理版本兼容问题...
另外，打开相册也不应会卡顿，顶多是加载时间较长，在1.4.x已经做了分页，是否有尝试？

稍后我录个屏看看

性能问题请开一个新的issue进行记录。版本冲突问题已进行调整。


text:
♻ Make XFileCapturedCallback return a boolean result

XFileCapturedCallback provides the ability to handle the produced file. However, it cannot handle case-by-case when the file or the preview type is different.
By updating the signature, users can return a boolean result when arguments are truly handled by the callback.
/cc @ZhuBoao

Beautiful & elegant :)


text:
Video speed returns to default when iOS takes the video forward for 15 seconds.

After ios change the video speed, when the video is advanced for 15 seconds, the video playback speed becomes default, but the selected value does not change, it stays when I choose it, the playback speed continues to work as in normal 1.

Will you be able to share a sample code for us to check this?

I didn't make any changes in the code, I encountered an error while using the chewie controller, when you increase the video speed to 1.75 and advance the video with the 15 seconds forward button, the video playback speed drops to 1.0 again. I think there should be a state that holds the user's change here.
Instead of the original controller, I created my own controls with the customer request, I did not do anything in the source code, sorry.

Yes , I've also  encountered this error. Is it fixed ?

Same issue here

repo: fluttercommunity/chewie


text:
Configure proxy for source controller

Is your feature request related to a problem ?
We need configure https_proxy for source controller to get those sources, but the deployment does't accept extra env vars.
Describe the solution you'd like.
Add value extraEnv in the controller deployment.
Describe alternatives you've considered.
None
Additional context.
No response

Feel free to open a PR

authors: pierluigilenoci uqix

repo: fluxcd-community/helm-charts


text:
Align name of release files for easier consumption

This PR also split workflows in the attempt to decrease the time required to build/release.
Note that the workflow split between all-libs and libgit2-only is a step stone towards the decommissioning of Managed Transport. Once that takes place we no longer will require all-libs and the compilation times that comes with it.
Relates to https://github.com/fluxcd/source-controller/issues/820 and https://github.com/fluxcd/image-automation-controller/issues/404.

Build seems stuck, do will close and reopen the PR as nothing else seem to get build back.

Closed in favour of https://github.com/fluxcd/golang-with-libgit2/pull/32 due to the issues with GitHub checks.


text:
source-controller Deployment manifest expects the default cluster domain

It looks like the latest version of the manifest expects that the cluster domain is .cluster.local:
https://github.com/fluxcd/source-controller/blob/6497680d0d60b417654775cac8f6fb71c8d704b8/config/manager/deployment.yaml#L60
When I installed flux on a GKE cluster with Cloud DNS configured for VPC scope DNS, the kustomize-controller encountered errors like: failed to download artifact, error: GET http://source-controller.flux-system.svc.cluster.local./gitrepository/flux-system/[ELIDED] giving up after 10 attempt(s): Get "http://source-controller.flux-system.svc.cluster.local./gitrepository/flux-system/[ELIDED]": dial tcp: lookup source-controller.flux-system.svc.cluster.local. on 169.254.20.10:53: no such host". If I understand correctly, the problem is that when GKE uses Cloud DNS with VPC scope DNS, it sets the cluster domain to the name of the GKE cluster, rather than .cluster.local.
I think I can fix this by patching the source-controller Deployment to modify this argument in my own flux setup. But I am curious, is it necessary to specify the default cluster domain? It is unclear to me if it provides much value over simply specifying source-controller.$(RUNTIME_NAMESPACE).svc.

If you haven't already found the --cluster-domain option of flux bootstrap, this is the intended way to set the cluster domain. Some users are not using bootstrap and that might be a separate issue.
We don't recommend using the manifests directly out of the development repository, right now at least, as there are some subtle differences with the manifests that get installed by flux install --export or flux bootstrap – most notably the namespace, but there can be others. If you can use the --cluster-domain option it should solve your issue.
The substitutions you suggested look like they should also work.

Relaying on Kubernetes DNS search it’s not something we want, each call will result in at least 3 queries. People have to option to specify their cluster domain at bootstrap, so we can avoid spamming the DNS when the controllers talk to each other, and they do that a lot, both to source-controller and notification-controller.

This explanations make sense. Thanks.

authors: kingdonb stefanprodan willchan

repo: fluxcd/source-controller


text:
🛑 AOL is down

In 07dffde, AOL (https://extranet.osam.org.ar/OSAM) was down:

HTTP code: 0
Response time: 0 ms

Resolved: AOL is back up in c913e96.

repo: flvanney/OSAMuptime


text:
Extension no longer functioning.

Does not appear to work anymore. When I try to search nothing happens and this message pops up "Oh snap, no bookmarked tweets are loaded. Wait a little longer or reload to try again."

Check out my tool, it is free and also open soure. https://twillot.com/

repo: flybayer/twitter-bookmarks-search


text:
Add channel UI with JSON API backend

Summary:

Use an in-memory TUF database which is updated every 5 minutes
Add /api/channels which serves the stable and nightly channels as JSON, including the current version and history with markdown formatted changelogs
Add web page which gets the channels from the API, renders the current channel versions followed by the history for each channel

Preview:

The design could do with some TLC, but I think we should do that in a separate PR.
/cc @titanous @jvatic

/cc @jvatic for JS review.

It looks like information is downloaded for every API request? Instead the update loop should populate everything directly and store it into a sync.Atomic so that no outbound requests are triggered by API calls.

https://github.com/jvatic/asset-matrix-go can be used to package the assets. It'd also be great to standardize on a front-end stack for all apps.

@jvatic I tried using a simple asset matrix (32eb192) but on go run compile.go I get errors downloading / installing node-sass:
$ go run compile.go
2016/07/18 20:46:51 Installing dependencies...
npm WARN deprecated npmconf@2.1.2: this package has been reintegrated into npm and is now out of date with respect to npm
npm WARN deprecated pangyp@2.3.3: use node-gyp@3+ instead
npm WARN deprecated lodash@1.0.2: lodash@<3.0.0 is no longer maintained. Upgrade to lodash@^4.0.0.
npm WARN deprecated minimatch@0.2.14: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated graceful-fs@1.2.3: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN deprecated graceful-fs@3.0.8: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN deprecated minimatch@2.0.10: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
\
> node-sass@3.2.0 install /home/ubuntu/go/src/github.com/flynn/flynn-releases/assets/node_modules/node-sass
> node scripts/install.js

Cannot download "https://github.com/sass/node-sass/releases/download/v3.2.0/linux-x64-46_binding.node": HTTP error 404 Not Found

> node-sass@3.2.0 postinstall /home/ubuntu/go/src/github.com/flynn/flynn-releases/assets/node_modules/node-sass
> node scripts/build.js

Building: /usr/bin/nodejs node_modules/pangyp/bin/node-gyp rebuild --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library=
make: Entering directory `/home/ubuntu/go/src/github.com/flynn/flynn-releases/assets/node_modules/node-sass/build'

...

In file included from ../src/binding.cpp:1:0:
../node_modules/nan/nan.h:324:27: error: redefinition of ‘template<class T> v8::Local<T> Nan::imp::NanEnsureHandleOrPersistent(const v8::Local<T>&)’
   NAN_INLINE v8::Local<T> NanEnsureHandleOrPersistent(const v8::Local<T> &val) {
                           ^

...

make: Leaving directory `/home/ubuntu/go/src/github.com/flynn/flynn-releases/assets/node_modules/node-sass/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/home/ubuntu/go/src/github.com/flynn/flynn-releases/assets/node_modules/node-sass/node_modules/pangyp/lib/build.js:272:23)
gyp ERR! stack     at emitTwo (events.js:87:13)
gyp ERR! stack     at ChildProcess.emit (events.js:172:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)
gyp ERR! System Linux 4.4.0-28-generic
gyp ERR! command "/usr/bin/nodejs" "/home/ubuntu/go/src/github.com/flynn/flynn-releases/assets/node_modules/node-sass/node_modules/pangyp/bin/node-gyp" "rebuild" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_libra
ry="
gyp ERR! cwd /home/ubuntu/go/src/github.com/flynn/flynn-releases/assets/node_modules/node-sass
gyp ERR! node -v v4.4.7
gyp ERR! pangyp -v v2.3.3
gyp ERR! not ok
Build failed

Any thoughts?

@lmars I've got assets compiling via a buildpack on deploy and switched to React. Also bumped the node-sass version so it should compile locally for you.
UI is still the same:

and

@jvatic thanks, the asset changes LGTM.
@titanous I moved getting the channel info into the update loop, please review.

@titanous comments addressed

I think we should run a synchronous update before turning on the HTTP server, so that the first requests can't panic due to a lack of data.

@titanous an update is run before starting the HTTP server (main calls NewRepository before starting the server, which runs an update before returning).

Ah, missed that. LGTM

authors: jvatic lmars titanous

repo: flynn/flynn-releases

license_source: bigquery


text:
dashboard: Updating env always uses latest release

#1389

LGTM

Updated to copy SLUG_URL env from latest release.

Neat, LGTM!

authors: jvatic titanous

repo: flynn/flynn


text:
Add Raw Output Metadata to events

Signed-off-by: Haytham Abuelfutuh haytham@afutuh.com
TL;DR
Add Raw Output Metadata to events to remove the read access dependency to the blobstore where outputs are currently written to.
Type

[ ] Bug Fix
[x] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[ ] Smoke tested
[x] Unit tests added
[x] Code documentation added
[ ] Any pending items have an associated Issue

Tracking Issue
https://github.com/flyteorg/flyte/issues/1327
Follow-up issue
NA

@kumare3

authors: EngHabu katrogan

repo: flyteorg/flyteidl


text:
Upgrade Spring JDBC dependency to the latest version

Hi,
the Spring JDBC version used in Flyway is 2.5.6 and the goal would be to update it to the latest Spring version.
Thanks and regards,
Guy

Closing. See my comment on pull request.

authors: axelfontaine guylabs

repo: flyway/flyway


text:
Repair: also correct migration type

What version of Flyway are you using?
flyway-4.2.0
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)
Command-line
What database are you using (type & version)?
Mysql 5.8
What operating system are you using?
windows 10
What did you do?
(Please include the content causing the issue, any relevant configuration settings, and the command you ran)
I wrote a V38__Change.sql and executed migrate，but now I want to change V38 to jdbc migrate, because it's difficult to implement new requirement with sql.  With repair I can only change checksum, but cant change type.
What did you expect to see?
With a command I can change version type instead of modifying with mysql states handly. and databases which already migrated to version higher than V38, should ignore new Jdbc-type V38 other than fail.
What did you see instead?
There is no such command.

I am a freshman in programming, and this is my first time to contribute to an open source project. I'm so excited to see my name in the releaseNotes. This is really a big inspiration for me. Thank u very much!

@wanglin0413 No worries. It was an unusual scenario, but it made sense to include it. Thanks for the detailed report explaining your reasoning and situation. To be honest, this is often much more valuable than a pull request. Cheers!


text:
tcolorbox idea + example

Summary
Hey there! This isn't so much a request, as an example. Last night I came up with a tcolorbox solution to replace the kaobox that I thought was worth sharing. I've barely used GitHub, so hopefully this is the right way to do this. 😅
Big disclaimer: I've only been using latex for about a week, so I might've overlooked some glaring issue. I've been putting together a business plan for the past few months, and I got fed up with MS Word's inconsistencies, so I converted it to latex.
Details
With the example below, you should be able to create a new box style in one line of code:
\tcbcreate{env_name}{box_title}{base_colour}{fontawesome_icon}

Here's an example of what it'll produce:

If you're interested, later on I can show you the other modifications I'm making to the class, but it's definitely not in a 'typical' latex style anymore. To figure out how it all works, and make it easier for me to modify, I pulled the code apart and reorganised it into packages which are progressively loaded by the class in order by:

style-level (brand colours, fonts, i18n, etc.)
page-level
environment-level
book-level

Example Code

Minimal Example

% Example of tcolorbox boxes

\documentclass[10pt]{article}

\RequirePackage[usenames,dvipsnames,table]{xcolor}
\RequirePackage[fixed]{fontawesome5}
\RequirePackage{tcolorbox}

\tcbuselibrary{most}

% Brand Colours

\definecolor{primary}{HTML}{124889} % primary blue
\definecolor{secp}{HTML}{8E0883} % secondary purple
\definecolor{secy}{HTML}{D1CE0C} % secondary yellow
\definecolor{tertg}{HTML}{317658} % tertiary green
\definecolor{terto}{HTML}{EB8A16} % tertiary orange

% General box settings:

\tcbset{%
    enhanced,
    before skip balanced=2mm,
    after skip balanced=3mm,
    boxrule=0.4pt,
    sharp corners,
    left=10mm, right=2mm, % control text position
    top=1mm, bottom=1mm,
    drop small lifted shadow=black,
    fonttitle=\bfseries
}

% Command to create new boxes:

\newcommand{\tcbcreate}[4]{
    \newtcolorbox{#1}[1][]{
        colback=#3!10!white,
        colframe=#3,
        title=#2,
        underlay={%
            \path[fill=#3!80!white,draw=none] (interior.south west) rectangle
            node[#3!5!white]{\Large\bfseries#4} ([xshift=8mm]interior.north west);
        }
    }
}

% Boxes to be used in document:

\tcbcreate{boxinfo}{Further Information}{primary}{\faLightbulb[regular]}
\tcbcreate{boxexample}{Practical Example}{tertg}{\faComments[regular]}
\tcbcreate{boxquestion}{Outstanding Question}{terto}{\faExclamationCircle}

\begin{document}
    \begin{boxinfo}
        hello world
    \end{boxinfo}

    \begin{boxexample}
        hello world
    \end{boxexample}

    \begin{boxquestion}
        hello world
    \end{boxquestion}
\end{document}

Great work, thanks! I am impressed that you could pull apart the code after using LaTeX for only one week :) I think many people would be interested in the other modifications, so definitely feel free to share them!

authors: JamesMRamm fmarotta

repo: fmarotta/kaobook


text:
🛑 Site nxtcATS is down

In 7185732, Site nxtcATS ($SECRET_SITE_4) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Site nxtcATS is back up in 2725df2.

repo: fmmaia/fmAtAllUptime


text:
Runtime python should work

ie: fn init --runtime python pfunc doesn't work, but it should.
And instead of python3.6, can we just make that python3?

I’m not sure that is the case. How would I know if the runtime is 3.6 but not 3.4? Code for 3.6 is not compatible with 3.4
Moreover, we use base image that is python:3.6, that’s why the runtime is also 3.6

Oh, I didn't realize Python had so many incompatibilities. What if we responded with something more helpful then?  ie: if you run fn init --runtime python, it will print a message with the available options.

I made the PR that adds back python alias, it’s not a big deal.

this is done

authors: denismakogon rdallman treeder

repo: fnproject/cli


text:
Old docs to be deleted

Link to issue this resolves

Removes old out of date docs and feature docs.

What I did

Deleted the files from my branch.

How I did it

From command line.

How to verify it

ls

One line description for the changelog

Old docs to be deleted. Docs no longer relevant or outdated.

One moving picture involving robots (not mandatory but encouraged)

Bernard smashes old files.

Thanks Reed. I'm on it. I'll post a comment with links once I have the files or parts of the files moved.

File and content have been added to the new repo:

Pagination: https://github.com/fnproject/docs/blob/master/fn/develop/pagination.md
Log Stores: https://github.com/fnproject/docs/blob/master/fn/operate/log-stores.md

repo: fnproject/fn


text:
🛑 Contaboo is down

In 9b91c20, Contaboo (https://contabo.com) was down:

HTTP code: 403
Response time: 419 ms

Resolved: Contaboo is back up in 1abfdf6 after 2 hours, 58 minutes.

repo: fnzv/status


text:
foam.util.compare() is broken

There are several observed instances where foam.util.compare will not return the expected value
For example:

Given a = undefined and b = anything
foam.util.compare(a, b) => 1 and foam.util.compare(b, a) => 1

Given a = null and b = anything
foam.util.compare(a, b) => 1 and foam.util.compare(b, a) => 1

Given a = true and b = FObject (This one is really weird...)
foam.util.compare(a, b) => 0 and foam.util.compare(b, a) => 1

Here are some examples of cases that remain unresolved by #368. These really don't have an intuitive answer to them and design choices will likely need to be made.
For all cases below, the current result is foam.util.compare(a, b) => 1 and foam.util.compare(b, a) => 1

a = [] and b = 1
a = [] and b = null
a = "" and b = null
a = function() {} and b = null
a = function() {} and b = undefined
...

The core idea behind the issue stems from the fact that the primitive types usually perform a type check (typeOf(b) == typeOf(a)) and returns 1 when the types are not the same. Thus, we get 1 no matter what order is specified when these elements are compared.

To resolve the remaining issues, precedence has been assigned to each type.
In the first attempt, precedence was determined by alphabetically (with foam.Object and foam.core.FObject being placed last). As you can see in this Travis build, this breaks some of the tests concerning the DAO. The main issue stems from the fact that undefined is the first parameter in a call to foam.util.compare in foam.mlang.predicate.Gt
In the second attempt, precedence was given to foam.Undefined and foam.Null, with the rest remaining in the same order as above. However, as you can see in this Travis build, a test with regards to Date was broken. The failing test is expect(foam.util.compare(new Date(234324), null)).toEqual(1);
Alternatively, all of the tests will pass if priority is given just to foam.Undefined while the rest remain in the initial order that was described.
@mdittmer has suggested that the second approach makes the most sense and it gives precedence to the "simplest" types. @kgrgreer I would appreciate any input you can give on this.

@m-cheung fixed this in #368

authors: m-cheung mdittmer


text:
Add background color

How to add Background color

See lines 28 and 29 in this example to see how background colors are set.

// overlay background color
dc.SetHexColor("#008080")			// choose colour
dc.DrawRectangle(0, S/1.3, S, S/4)
dc.Fill()

You can try fill

repo: fogleman/gg

license: mit


text:
[MODEBSNET-3] Added a new test suite for mod-ebsconet

Created a new test suite for mod-ebsconet, including the GET feature. The new suite was also added to TestRail, along with a new section.
MODEBSNET-3

authors: AndreiMPV damien-git

repo: folio-org/folio-integration-tests


text:
MODINREACH-288 -  INN-Reach Transactions List Action Menu Item: INN-Reach paging slips

Purpose
When viewing the INN-Reach transactions interface in the INN-Reach app, the user should be able to generate a set of paging/pick slips for INN-Reach Item Hold transactions using pre-defined custom templated specifically for INN-Reach and custom to each connected central server.
Approach

Implement paging slips
Update open api schema and module descriptor
Add tests

TODOS and Open Questions

Learning

Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.

Does this PR meet or exceed the expected quality standards?

[ ] Code coverage on new code is 80% or greater
[ ] Duplications on new code is 3% or less
[ ] There are no major code smells or security issues

Does this introduce breaking changes?

[ ] Were any API paths or methods changed, added or removed?
[ ] Were there any schema changes?
[ ] Did any of the interface versions change?
[ ] Were permissions changed, added, or removed?
[ ] Are there new interface dependencies?
[ ] There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

What other modules will these changes impact?
Do JIRAs exist to update the impacted modules?

[ ] If not, please create them
[ ] Do they contain the appropriate level of detail?  Which endpoints/schemas changed, etc.
[ ] Do they have all they appropriate links to blocked/related issues?

Are the JIRAs under active development?

[ ] If not, contact the project's PO and make sure they're aware of the urgency.

Do PRs exist for these changes?

[ ] If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment.  Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

INFO: api-schema-lint: Using api-schema-lint version: 1.0.4
INFO: api-schema-lint: Assessing schema files (https://dev.folio.org/guides/describe-schema/)
INFO: api-schema-lint: Found 91 JSON schema files under directory 'src/main/resources/swagger.api'
ERROR: api-schema-lint: src/main/resources/swagger.api/schemas/pagingSlipsDTO.json: Missing "description" for: slip
ERROR: api-schema-lint: There were processing errors. See list above.

Note: When those ERRORs are fixed, then any INFO and WARNING messages will be gone too. See Jenkins "Artifacts" tab for ApiSchemaLintReport.

authors: id-jenkins oliinyko

repo: folio-org/mod-inn-reach


text:
Added gunzip, zlib decompression support and revamped API

I added basic support for zlib and gzip input (little validation - focused on performance and file size), as well as autodetection of format. This makes the API a lot easier to use for those with zlib/gzip data. I also added JSDoc and type annotations for the methods, which allows for better autocomplete and TypeScript support.
Possibly most importantly of all, I made the second parameter (the output array) optional, so that those without knowledge of the output size can still use this awesome library. It will automatically use an (admittedly inefficient) standard array to store the result of the decompression before switching to a Uint8Array. If the data is gzipped, a header tells us the output file size, so we use that to maximize memory efficiency. The new API is still 100% compatible with the old API.
Thanks for creating this wonderful library!

@devongovett Do you think this is in scope for the project? If not, let me know, and I'll make a fork and publish my own NPM package with the changes.

It's been a few months so I would like to know your opinion @devongovett. I'm currently using this PR in a project but would like to use the NPM package.

I've now created my own tool fflate that is much faster than this library (and even pako), supports compression, but is about 3.5kB minified and 2kB gzipped when using tree shaking to use only the decompression API. I'll leave this PR open in case you decide to use it, but for anyone looking for a tiny compression/decompression library, I would suggest using fflate instead.

repo: foliojs/tiny-inflate


text:
feature: lag plugin commits considered for updates by some amount of time

Did you check the docs?

[X] I have read all the lazy.nvim docs

Is your feature request related to a problem? Please describe.
I generally enjoy staying pretty up to date with plugins, but there are two problems when updating plugins.

It could be buggy
It could be a compromised, attack release.

Bugs happen all the time, and are just a fact of life. And while I haven't heard of any packaging "supply-chain" attacks on (neo)vim plugins, they've happened in every popular programming language package repos, so it's probably only a matter of time before someone targets neovim plugins.
Describe the solution you'd like
When considering the list of commits to update to, I'd like to only consider ones that are some arbitrary time ago. Let's say 2 weeks, but it doesn't matter much. It is of course not a perfect solution to either problem, but it goes a long way. Probably in 2 weeks people would have discovered and fixed any bad bugs for a new release, and also probably any sort of compromised GitHub account or whatever would have been discovered.
This wouldn't work if everyone was lagged by 2 weeks, but realistically the number of people who consider these issue and care about them and would opt into only pulling plugins from the past is small.
Describe alternatives you've considered
Sticking to released semver versions helps a bit, but not all plugins do releases, and also a freshly released plugin can still have the same problems anyway.
Additional context
No response

Just update your plugins manually with gu?

authors: folke will


text:
Remapping "jk" in insert mode to  doesn't seem to be working when i set the timeoutlen to 0

I have the below stuff in the options.lua
local behaviourOptions = {
    timeoutlen = 0,-- need to be other than 0 for the jk remap
    updatetime = 300,                        -- faster completion (4000ms default)
}
for k,v in pairs(behaviourOptions) do
    vim.opt[k] = v
end

keymaps.lua
local noresil = { noremap = true, silent = true }
local keymap = vim.api.nvim_set_keymap
keymap("i", "jk", "<ESC>",noresil)

The issue is that if I set timeoutlen to 0, the remap doesn't work at all. I'm just setting it to 300ms for now to get by but is there a setting i'm missing so i can enable the intended behavior of pulling up a WK popup immediately with 0 delay but completely disabling it in visual, insert and visual block modes?

Its correct behaviour.. no one is that much fast to type jk or jj in 0ms..   may be try typing them together it might work !! 😉

The map is working, but you must press both j and k almost simultaneously, considering your timeoutlen is 0

authors: Conecsion bhushan bokonist


text:
Use hashchange event instead of click event?

Hijacking the hash might be less evil and more efficient than hijacking click events
https://github.com/follywolly/web-app-from-scratch-18-19/blob/960a98a709d761ef74e11f55198b69b69f2db8b2/src/js/modules/router.js#L4-L17

Good call. Implemented

authors: follywolly joostf


text:
Preparing v0.13.0a0 pre-release

v0.13.0a0 (2024-Sep-13)
Noteworthy code-changes

Profile owners,  please take a look at the pending_review lists in your profile definitions. If you move them to exclude_checks it means you do not want the check in your profile. If you just remove from pending_review, then the check becomes effective in your profile. And if you do nothing, the checks still not reviewed will continue being automatically excluded from your profile.
This release adopts a new naming scheme for checks. We had reports of users getting confused by the meaning of the reverse domain names included as prefixes of check-IDs, such as com.google.fonts. The real meaning was that the organization identified by such domain was the first contributor of a given check implementation. But some users were confused thinking that it mean the check belong to that organization's vendor-specific profile.
Now profiles do not include that reverse domain prefix. And do not also have the "/check/" keywork anymore. As an example, com.google.fonts/check/tabular_kerning (on the Universal profile) is now simply called tabular_kerning
Also, there's been a large number of checks migrated among profiles. Mosly towards the Universal one.
The checks themselves also moved around in the code-repository, in an attempt to remove any resemblance of profile allocation within the /Lib/fontbakery/checks/ directory, which should be seen as a general pool of check implementations. As much as possible, profile definition should happen inside /Lib/fontbakery/profiles instead.
The exception to this are the checks that are surely vendor-specific. All those were placed in sub-directories inside Lib/fontbakery/checks/, such as Lib/fontbakery/checks/vendorspecific/microsoft/.
As this is the "a0" pre-release, there may be additional migrations and renames of checks, before we make an actual v0.13.0 release. Please open an issue if you have suggestions of better names or better profile allocations.

hi @felipesanches just to undertand better what I need to do. I’m a bit confused with the checks listed under pending_review there are some that I recongnized I had commented out on the previous profile but in general how did you make the list?

hi @felipesanches just to undertand better what I need to do. I’m a bit confused with the checks listed under pending_review there are some that I recongnized I had commented out on the previous profile but in general how did you make the list?

Sorry about the late reply. I've inspected the files with the definitions for each of the profiles and I used some logical inference to make by best effort in determining which checks would potentially be useful for each vendor. There were comments left by profile owners and other clues that helped me on those decisions.
For instance, I considered that whenever a profile included the entirety of googlefonts by default (using the "include_profile" field), it meant that the checks migrated from googlefonts to universal would not need to be reviewed by that profile owner (because those checks were already being automatically included, so would probably already be considered good). But for profiles that did not include googlefonts, the new checks migrated to universal profile would necessarily need to be reviewed first, so those were added to the "pending_review" list. And there were also similar cases for checks migrating among other profiles, for which I used similar logical reasoning.
I hope this clarifies the matter for you and I''ll be glad to answer any additional questions you may still have about it.

Hi, @felipesanches do you have a target date for a release including those changes?

repo: fonttools/fontbakery


text:
Some classes out of date with sfdx-project.json schema

Summary
From what I can see, the schema has been updated but not the class, which is causing Typescript to have a fit. Specifically in our custom plugin and specifically for apexTestAccess, though I noticed that others are also missing as well like unpackagedMetadata.
The PackageDir class the code is using is @salesforce\core\lib\sfdxProject.d.ts
Steps To Reproduce:
Reference apexTestAccess on a PackageDir object
Expected result
No syntax error
Actual result
Syntax error
Additional information

SFDX CLI Version
sfdx-cli/7.118.1 win32-x64 node-v14.17.4
SFDX plugin Version:
@oclif/plugin-autocomplete 0.3.0 (core)
@oclif/plugin-commands 1.3.0 (core)
@oclif/plugin-help 3.2.3 (core)
@oclif/plugin-not-found 1.2.4 (core)
@oclif/plugin-plugins 1.10.1 (core)
@oclif/plugin-update 1.4.0-3 (core)
@oclif/plugin-warn-if-update-available 1.7.0 (core)
@oclif/plugin-which 1.0.3 (core)
@salesforce/sfdx-diff 0.0.6
@salesforce/sfdx-plugin-lwc-test 0.1.7 (core)
alias 1.1.10 (core)
apex 0.2.8 (core)
auth 1.7.1 (core)
config 1.2.34 (core)
custom-metadata 1.0.12 (core)
data 0.6.1 (core)
generator 1.2.0 (core)
limits 1.2.1 (core)
mo-dx-plugin 0.3.2
org 1.7.0 (core)
plugin-lightning-testing-service 1.0.1
salesforce-alm 52.3.3 (core)
schema 1.0.8 (core)
sfdx-cli 7.118.1 (core)
sfdx-git-delta 4.9.0
sfdx-git-packager 0.3.3
sfdx-isdot 2.7.0 (link) C:\Users\jpetraglia\repos\isdot
sfdx-jayree 3.11.2
└─ @jayree/sfdx-plugin-prettier 1.0.4
source 1.0.15 (core)
telemetry 1.2.3 (core)
templates 52.1.0 (core)
texei-sfdx-plugin 1.10.1
trust 1.0.7 (core)
user 1.4.0 (core)
OS and version:
Windows 10

This issue is fixed in the 2.42.6 (May 22, 2024) release.

authors: jonnypetraglia jshackell-sfdc

repo: forcedotcom/cli