text:
fix: action button fill

What does this PR do?
Fix the yellow border when the action button is filled
Context
This PR is related to this PR.  Tailwind migration caused a lot of changes to the code base since my last commit, so I decided to create a new PR and close the old one
Externals
Before fix:

After fix:

Hey @pedrorezende! Thanks for your review, I've provided fixes for your comments. Please check when you have a chance. Thanks

Hello @RuslanGlaznyov . Thank you very much for this PR and for pointing out this issue. We've made a huge refactor in the ActionButton component last week, and addressed this hairline behaviour using a different approach (#921) . We're sorry for the delay in getting back to you about this, this PR is really good, and we had planned to revisit this as soon as we had some time to make this refactor. We've done this, but we were able to find a simpler approach using css grids. We really appreciate this contribution, and apologize again for the lack of response.

authors: RuslanGlaznyov pedrorezende

repo: anoma/namada-interface


text:
Deprecation warning in Google Chrome

polyfill-svg-uri.min.js:1 [Deprecation] 'webkitURL' is deprecated. Please use 'URL' instead.
polyfill-svg-uri.min.js:1 [Deprecation] 'window.webkitStorageInfo' is deprecated. Please use 'navigator.webkitTemporaryStorage' or 'navigator.webkitPersistentStorage' instead.
Please help.
Thanks in Advance

Hi @ajithpmohan, thank you for the comment.
No problem because that is warnings not errors. That is correct behavior.

No reply came. I close this issue.

source: gharchive/issue

authors: ajithpmohan anseki

repo: anseki/polyfill-svg-uri

license: mit

license_type: permissive

license_source: bigquery


text:
UnboundLocalError: local variable 'requests' referenced before assignment

Issue Type

Bug report

Molecule and Ansible details

Latest

Molecule installation method (one of):

pip

Ansible installation method (one of):

pip

Desired Behavior
When docker python dependency is not installed an error message is shown not a stack trace.
Actual Behaviour
--> Sanity checks: 'docker'
Traceback (most recent call last):
  File "/home/foobar/work/barfoo/infrastructure/.venv/lib/python3.8/site-packages/molecule/driver/docker.py", line 223, in sanity_checks
    import docker
ModuleNotFoundError: No module named 'docker'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/foobar/work/barfoo/infrastructure/.venv/bin/molecule", line 8, in <module>
    sys.exit(main())
  File "/home/foobar/work/barfoo/infrastructure/.venv/lib/python3.8/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/foobar/work/barfoo/infrastructure/.venv/lib/python3.8/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/foobar/work/barfoo/infrastructure/.venv/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/foobar/work/barfoo/infrastructure/.venv/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/foobar/work/barfoo/infrastructure/.venv/lib/python3.8/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/foobar/work/barfoo/infrastructure/.venv/lib/python3.8/site-packages/click/decorators.py", line 21, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/foobar/work/barfoo/infrastructure/.venv/lib/python3.8/site-packages/molecule/command/test.py", line 147, in test
    base.execute_cmdline_scenarios(scenario_name, args, command_args)
  File "/home/foobar/work/barfoo/infrastructure/.venv/lib/python3.8/site-packages/molecule/command/base.py", line 107, in execute_cmdline_scenarios
    execute_scenario(scenario)
  File "/home/foobar/work/barfoo/infrastructure/.venv/lib/python3.8/site-packages/molecule/command/base.py", line 149, in execute_scenario
    execute_subcommand(scenario.config, action)
  File "/home/foobar/work/barfoo/infrastructure/.venv/lib/python3.8/site-packages/molecule/command/base.py", line 138, in execute_subcommand
    return command(config).execute()
  File "/home/foobar/work/barfoo/infrastructure/.venv/lib/python3.8/site-packages/molecule/command/destroy.py", line 107, in execute
    self._config.provisioner.destroy()
  File "/home/foobar/work/barfoo/infrastructure/.venv/lib/python3.8/site-packages/molecule/provisioner/ansible.py", line 700, in destroy
    pb.execute()
  File "/home/foobar/work/barfoo/infrastructure/.venv/lib/python3.8/site-packages/molecule/provisioner/ansible_playbook.py", line 105, in execute
    self._config.driver.sanity_checks()
  File "/home/foobar/work/barfoo/infrastructure/.venv/lib/python3.8/site-packages/molecule/driver/docker.py", line 228, in sanity_checks
    except requests.exceptions.ConnectionError:
UnboundLocalError: local variable 'requests' referenced before assignment

Resolved by pip install docker==4.2.0 btw.

repo: ansible-community/molecule

license: MIT

license_source: github-api


text:
Inconsistency issue for task 2.2.16

Describe the Issue
There appears to be an inconsistency between the when conditionals of the tasks for rule 2.2.16.
Expected Behavior
All when conditionals should have the rule's number mentioned. For example:
when:       - ubtu22cis_rule_2_2_16
Actual Behavior
Only the when conditionals of the tasks within the block contain the rule's number. The when conditional of the actual block does not.
Control(s) Affected
2.2.16 | PATCH | Ensure rsync service is either not installed or masked
Environment (please complete the following information):

branch being used: [e.g. devel]

Additional Notes
Anything additional goes here
Possible Solution
I will provide the fix in a PR!

I believe that this issue has been addressed and the fix merged?
I will close this issue, please feel free to reopen or raise a new one if this particular problem still exists.
Many thanks
uk-bolly

authors: DianaMariaDDM uk-bolly


text:
Add run action to support interactive and stdout mode

Add run subcommand with interactive and stdout mode
to invoke playbook
Remove explore and playbook commandline option and
relevant changes
Refactor runner invocation code to use the new run_command
ansible-runner interface
Doc updates

Superseded by https://github.com/ansible/ansible-navigator/pull/108

source: gharchive/pull-request

repo: ansible/ansible-navigator


text:
Add more tests for tags

More tests for #236

@MarkusTeufelberger Next time we need negative tests.

These might also be worth it:
Playbooks:
- name: Array with members but not string
  hosts: localhost
  tags:
    - 123 # <-- not allowed

Tasks:
- name: Array with members but not string
  ansible.builtin.debug:
    msg: foo
  tags:
    - 123 # <-- not allowed

We can do this after we remove the old schemas via #239 as I do not fancy updating 3 files instead of one.

...these tests already do not pass (correctly), there would be no change necessary other than adding them.

authors: MarkusTeufelberger ssbarnea

repo: ansible/schemas


text:
Is there a way to shrink the report 'frame'?

in all the examples the report is super wide and on a phone it is wider than the phone. Styling seems to have no effect on shrinking the viewer.. Is there a way to make the viewer fit the container?

you can pass your styling in canvasCss prop as a class

Can you please paste an example? I tried a variety of things but anything I do messes up all the navigation. Can you show how to make the width like 500 rather than the default 1000? I am using this on a mobile so needs to be more narrow. I tried passing strings, a style as a string, tried a few things and no changes to the width and just messes up the panning :-(

@ansu5555. the internal size is 1000px and fixed.. can you share an actual example of how to provide a custom size? When I tried it broke the navigation since when you pass in canvasCSS it will also send all the navigation over to the canvasCSS :-(


text:
Simulation configuration bug with exporting json when DC sources are defined

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
PinGroup doesn't have _json_format method implemented.
Steps To Reproduce
NA
Which Operating System are you using?
Windows
Which Python version are you using?
3.10
Installed packages
pyaedt

Resolved and fixed in PyEDB

repo: ansys/pyaedt


text:
issue#1478 seems to persist in pyaedt 0.7: Changing plating thickness of Vias does not have effect on exported files to Maxwell (Vias are exported filled)

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
Hello,
it appears that issue #1478 is still persistent in 0.7. When trying to export from EDB to Maxwell the vias are filled regardless of the assigned plating thickness
Steps To Reproduce
import pyaedt
Version="2022.2"
ExportName="Export"
filename="Test.aedb"
PlatingThickness=0.1E-3
path=os.path.abspath(os.getcwd())
aedb_path =os.path.join(path,filename).replace('\','\\')
HideSiWave=True
edb = pyaedt.Edb(edbversion=Version, edbpath=aedb_path)
edb.save_edb() # Save the edb file
options_config = {
'LAUNCH_MAXWELL' : 0,
'NUM_PADS_FACET_COUNT': 8,
'NUM_ANTIPAD_FACET_COUNT': 8,
'DEFAULT_SOLDERBALL_FACET_COUNT' : 8,
'VIA_SEGMENTS' : 8,
'DEFAULT_BONDWIRE_FACET_COUNT' : 6,
'UNITE_NETS' : 0,
'EXCLUDE_TERMINALS_FROM_UNITE' : 1,
'SIMPLY_VIA_MODEL' : 0,
'IGNORE_DIELECTRICS' : 0,
'SEPARATE_DIELECTRICS' : 1,
'UNITE_LAYERS_WITH_SAME_MATERIALS' : 1,
'IGNORE_UNCONNECTED_PADS' : 0,
'CLIP_TRACES' : 0,
'CUT_DIELECTRICS' : 0,
'CREATE_SHEET_BODIES' : 0,
'GENERATE_TERMINALS' : 0,
'IGNORE_PLANES_WITH_AREA_LESS_THAN_THRESOLD' : 1,
'IGNORE_FLOAT_BODIES' : 0,
'MIN_PLANE_AREA' : 0.358979,
'MIN_EDGE_LENGTH_PADS' : '1um',
'MIN_EDGE_LENGTH_PLANES' : '1um',
'MIN_EDGE_LENGTH_TRACES' : '1um',
'MIN_DIELECTRIC_EDGE_LENGTH' : '10um',
'DIELECTRIC_EXPANSION_FACTOR' : 0.100000,
'IGNORE_HOLES' : 0,
'MIN_HOLE_AREA' : 0.358979,
'REMOVE-PLATING_TAILS' : 0,
'SUBTRACT_METAL_FROM_SUBSTRATE' : 0,
'DISCRETIZE_ARCS' : 0,
'CHOP_TRACE_ENDS' : 0,
'AIRBOX_THICKNESS_FACTOR' : 1.100000,
'AIRBOX_PAD_AMOUNT_PLUS_Z' : 0.500000,
'AIRBOX_PAD_AMOUNT_MINUS_Z' : 0.500000,
'PORT_PAD_AMOUNT' : 0.500000,
'CREATE_PORTS_FOR_PWR_GND_NETS' : 0,
'PORTS_FOR_PWR_GND_NETS' : 0,
'LAUNCH_HFSS' : 0,
'USE_CAUSAL_MATERIALS' : 1,
'AUTO_DC_THICKNESS' : 0,
'SOLVE_CAPACITANCE' : 0,
'SOLVE_DC_RESISTANCE' : 0,
'SOLVE_DC_INDUCTANCE_RESISTANCE' : 0,
'SOLVE_AC_INDUCTANCE_RESISTANCE' : 0,
'SOLVE_PROJECT' : 0,
'LAUNCH_Q3D' : 0,
'ASSIGN_SOLDER_BALLS_AS_SOURCES' : 0,
'Q3D_MERGE_SOURCES' : 0,
'Q3D_MERGE_SINKS' : 0,
'ACIS_VERSION' : 0
}
edb.write_export3d_option_config_file(path, options_config)
PadStackNames=[x for x in edb.core_padstack.padstacks] #API CALL: read all padstacks
for x in PadStackNames:
try:
edb.core_padstack.padstacks[x].hole_plating_ratio=0
edb.core_padstack.padstacks[x].hole_plating_thickness=PlatingThickness # API CALL: set plating thickness
except Exception as e:
    continue

edb.save_edb()
edb.export_maxwell(path_to_output=path,aedt_file_name=ExportName,hidden=HideSiWave)
edb.save_edb() #API CALL: Save file
edb.close_edb()
Which Operating System are you using?
Windows
Which Python version are you using?
3.7
Installed packages
C:\temp>python -m pip freeze
ansys-pythonnet==3.1.0rc3
cffi==1.16.0
clr-loader==0.2.6
defusedxml==0.7.1
fonttools==4.47.2
fpdf2==2.7.7
numpy==1.26.3
pandas==2.2.0
pillow==10.2.0
plumbum==1.8.2
psutil==5.9.8
pyaedt==0.7.10
pycparser==2.21
python-dateutil==2.8.2
pytz==2023.3.post1
pywin32==306
rpyc==5.3.1
six==1.16.0
tzdata==2023.4

@Jan-Hammer In the Closed Issue, @maxcapodi78 mentioned that it was a limitation in SIWave API, so PyAEDT can not solve it until SIwave does not expose the method.
I am not sure if it is fixed, but if it is, you will need to update to a new Ansys version.
Please @ring630 @svandenb-dev , this is an EDB related issue, could you help?
Thanks

@Samuelopez-ansys may be we can implement this in PyAEDT.

@Jan-Hammer it looks like there is no keyword in configure file to toggle 100% via fill checkbox. I am waiting answer from development.

@Jan-Hammer the keyword is TOTAL_VIA_FILL. The SIwave documetation will be updated. By setting it to 0, the via will have a hole  in maxwell.
options_config = {'TOTAL_VIA_FILL' : 0}

authors: Jan-Hammer Samuelopez-ansys ring630


text:
export_to_ipc2581() results in an error arcs = path_step.primitive_object.GetCenterLine().GetArcData() System.Exception: Cannot get parametric ArcData

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
Using Pycharm I tested this function using the 3D-Layout example diff_via.
def TestIpc2581Export():
edb = pyaedt.Edb(edbversion="2024.2", edbpath=testPCB)
edb.export_to_ipc2581(ipc2581_file, "inch")
edb.close_edb()
It resulted in  arcs = path_step.primitive_object.GetCenterLine().GetArcData()
System.Exception: Cannot get parametric ArcData
at Ansys.Ansoft.Edb.Geometry.PolygonData.GetArcData()
Steps To Reproduce
Using Pycharm I tested this function using the 3D-Layout example diff_via.
def TestIpc2581Export():
edb = pyaedt.Edb(edbversion="2024.2", edbpath=testPCB)
edb.export_to_ipc2581(ipc2581_file, "inch")
edb.close_edb()
Got the following trace back:
Traceback (most recent call last):
File "C:\Program Files\JetBrains\PyCharm Community Edition 2023.2.1\plugins\python-ce\helpers\pydev\pydevd.py", line 1500, in _exec
pydev_imports.execfile(file, globals, locals)  # execute the script
File "C:\Program Files\JetBrains\PyCharm Community Edition 2023.2.1\plugins\python-ce\helpers\pydev_pydev_imps_pydev_execfile.py", line 18, in execfile
exec(compile(contents+"\n", file, 'exec'), glob, loc)
File "D:\Companies\AMD\scripts\VRM_testing\main.py", line 34, in
TestIpc2581Export()
File "D:\Companies\AMD\scripts\VRM_testing\main.py", line 29, in TestIpc2581Export
edb.export_to_ipc2581(ipc2581_file, "inch")
File "D:\Companies\AMD\scripts\VRM_testing.venv\lib\site-packages\pyedb\dotnet\edb.py", line 743, in export_to_ipc2581
ipc.load_ipc_model()
File "D:\Companies\AMD\scripts\VRM_testing.venv\lib\site-packages\pyedb\ipc2581\ipc2581.py", line 66, in load_ipc_model
self.add_layer_features()
File "D:\Companies\AMD\scripts\VRM_testing.venv\lib\site-packages\pyedb\ipc2581\ipc2581.py", line 342, in add_layer_features
self.ecad.cad_data.cad_data_step.add_layer_feature(layer, polys[layer_name])
File "D:\Companies\AMD\scripts\VRM_testing.venv\lib\site-packages\pyedb\ipc2581\ecad\cad_data\step.py", line 224, in add_layer_feature
layer_feature.add_feature(poly)
File "D:\Companies\AMD\scripts\VRM_testing.venv\lib\site-packages\pyedb\ipc2581\ecad\cad_data\layer_feature.py", line 58, in add_feature
feature.path.add_path_step(obj_instance)
File "D:\Companies\AMD\scripts\VRM_testing.venv\lib\site-packages\pyedb\ipc2581\ecad\cad_data\path.py", line 40, in add_path_step
arcs = path_step.primitive_object.GetCenterLine().GetArcData()
System.Exception: Cannot get parametric ArcData
at Ansys.Ansoft.Edb.Geometry.PolygonData.GetArcData()
python-BaseException
Which Operating System are you using?
Windows
Which Python version are you using?
3.10
Installed packages
annotated-types==0.7.0
ansys-pythonnet==3.1.0rc3
attrs==23.2.0
certifi==2024.6.2
cffi==1.16.0
charset-normalizer==3.3.2
click==8.1.7
click-plugins==1.1.1
cligj==0.7.2
clr-loader==0.2.6
colorama==0.4.6
contourpy==1.2.1
cycler==0.12.1
defusedxml==0.7.1
et-xmlfile==1.1.0
fast_simplification==0.1.7
fiona==1.9.6
fonttools==4.53.0
fpdf2==2.7.9
geopandas==0.14.4
idna==3.7
imageio==2.34.1
joblib==1.4.2
jsonschema==4.22.0
jsonschema-specifications==2023.12.1
kiwisolver==1.4.5
matplotlib==3.8.4
networkx==3.3
numpy==1.26.4
openpyxl==3.1.4
osmnx==1.9.3
packaging==24.1
pandas==2.2.2
pillow==10.3.0
platformdirs==4.2.2
plumbum==1.8.3
pooch==1.8.2
psutil==6.0.0
pyaedt==0.9.6
pycparser==2.22
pydantic==2.7.4
pydantic_core==2.18.4
pyedb==0.18.0
pyparsing==3.1.2
pyproj==3.6.1
python-dateutil==2.9.0.post0
pytomlpp==1.0.13
pytz==2024.1
pyvista==0.43.10
pywin32==306
typing_extensions==4.12.2
tzdata==2024.1
urllib3==2.2.2
utm==0.7.0
vtk==9.2.6

moving this issue to PyEDB

authors: cmesibov svandenb-dev


text:
Removing edit button fix

It should remove redundancy in code.
Close #2254

I'm highly skeptical of this honestly

Waiting for a new release of ansys-sphinx-theme. @Revathyvenugopal162

I'm going to merge "blindly" because I cannot check without it getting online I guess????.....

@Revathyvenugopal162

It seems to work ok.
I am checking the changes. For example this link:
node — PyMAPDL (pyansys.com)

The edit on Github button takes you to the right file, but at the very top. Not to the right function. But it opens the editor.

The [Source] button takes you to the right function/class definition. So I would say it is more precise. But it just on "view mode" not editor.

I see a bit of redundancy, but I would probably keep both. However I would expect that the editor mode will take you to the right lines. But maybe it is not possible.

The source is fully on our control, so we could go to precise file, but edit this button is just a modification on pydata-sphinx-theme.

repo: ansys/pymapdl


text:
如何编译demo？

目前官网上的demo是通过iframe访问阿里服务器上的网页，如何在本地生成demo网页？执行npm run build后，docs-dist文件夹中并不包含demo内容。

next分支，npm run dev

#305
npm run dev即可编译

repo: ant-design/ant-design-mini


text:
使用ListSort 拖动排序 调用堆栈大小溢出

const dataArray = [
        {
          icon: 'smile-o',
          color: '#FF5500',
          title: '自由',
          id: '1001'
        },
        {
          icon: 'smile-o',
          color: '#5FC296',
          title: '平等',
          id: '1002'
        },
        {
          icon: 'smile-o',
          color: '#2DB7F5',
          title: '公正',
          id: '1003'
        },
]

 const childrenToRender = dataArray.map((item) => {
      const {icon, color, title, id} = item;
      return (
        <div key={id} className={`${this.props.className}-list`}>
          <div className={`${this.props.className}-icon`}>
            <Icon type={icon} style={{color}}/>

          <div className={`${this.props.className}-text`}>

{title}

      );
    });
<ListSort
	dragClassName = "list-drag-selected"
	appearAnim = {{animConfig: {marginTop: [5, 30], opacity: [1, 0]}}}

>
{childrenToRender}
</ListSort>

ListSort组件
"react": "^16.2.1",
"react-dom": "^16.2.1",

https://codesandbox.io/s/50qk2539mk  没什么问题啊。。。

可能是我这边项目包冲突了吧，解决了，用react@15.x就可以了

repo: ant-design/ant-motion


text:
Horizontal scrollbar disappear

Describe the bug
If you open a table that has many columns to view the records, when you switch between tabs and go back to the table view, the horizontal scrollbar disappears.
When the window is resized, scrollbar appears again.
To Reproduce
Steps to reproduce the behavior:

Select table to view records
Open or change tab
Go back to previous tab

Screenshots

Application (please complete the following information):

Version 0.5.7
Installation source: Microsoft Store

Environment (please complete the following information):

OS name: Windows 10
OS version 21H2 19044.1766

Hi Agustín,
thanks for the report!
This bug was fixed some commit ago (8f01740475ea6d5d9b5eefabdbf27099df76f2cf). Next days a new update will be released with this fix.

repo: antares-sql/antares


text:
About the definition of different parameters in the ply file.

Thanks for the great opensource project!
I have a few questions about the definition of different parameters in the ply file and I wonder if there is any official documentation about them. For example, what is the unit of different parameters. How do you define scale_0, 1, 2? Is it based on x, y, z directions? I'm working on calculating the projection size of each splats on the canvas and need a more clear definition of them. Many thanks.

The .ply format here comes from the underlying gaussian splat training engine. I believe the scales are axis aligned before they are rotated by the rot parameters.


text:
terraform_tflint does not find problems that manifest across multiple files

Describe the bug
tflint has checks like terraform_unused_declarations that can only reasonably be checked across multiple files and terraform_tflint does not find them because  it only checks single files.
How can we reproduce it?
Create a directory with two files: variables.tf and main.tf and add to variables.tf:
variable "unused" {
  type = string
}

Also add a tflint.hcl:
plugin "aws" {
  enabled = true
  version = "0.7.2"
  source  = "github.com/terraform-linters/tflint-ruleset-aws"
}

rule "terraform_unused_declarations" {
  enabled = true
}

rule "terraform_comment_syntax" {
  enabled = true
}

rule "terraform_unused_required_providers" {
  enabled = true
}

rule "terraform_naming_convention" {
  enabled = true
}

rule "terraform_typed_variables" {
  enabled = true
}

pre-commit run --all-files will not find a problem. I wrote an own hook that does:
  - repo: local
    hooks:
      - id: tflint
        name: tflint
        entry: bash -c 'tflint --init && echo $@ | xargs dirname | sort --unique | xargs -n1 tflint'
        language: system
        files: \.tf$
        require_serial: true

gives:
Warning: variable "unused" is declared but not used (terraform_unused_declarations)

  on variables.tf line 1:
   1: variable "unused" {

terraform_tflint should give the same warning?
Environment information

OS: MacOS Darwin
Tools availability and versions:

pre-commit 2.15.0
Terraform v1.0.8
Python 3.9.7
Python 3.9.7
checkov checkov SKIPPED
terraform-docs version v0.14.1 darwin/amd64
terragrunt SKIPPED
terrascan terrascan SKIPPED
TFLint version 0.31.0
+ ruleset.aws (0.7.2)
tfsec tfsec SKIPPED

.pre-commit-config.yaml:

  - repo: git://github.com/antonbabenko/pre-commit-terraform
    rev: v1.50.0
    hooks:
      - id: terraform_fmt
      - id: terraform_tflint

Seeing the same issue with new version. Any ETA when this will be fixed?

This works as expected. (for 1.50.0 too)
repos:
  - repo: git://github.com/antonbabenko/pre-commit-terraform
    rev: v1.51.0
    hooks:
      - id: terraform_fmt
      - id: terraform_tflint

Just need to rename tflint.hcl to .tflint.hcl
Confirm ERROR in ././: output in v1.52.0
Workaround
Downgrade to v1.51.0 and wait fix

authors: MaxymVlasov ichiman sblask

repo: antonbabenko/pre-commit-terraform


text:
DragEventCreation

New method for event creation. Press and pull for event creation like in google calendar.

Hi, I have been testing this.  The dragging doesn't adhere to snapToTime, like dragResize does.  And when creating a new event, the calendar rapidly emits cell-click.

Hi @Csandori,
Thanks for your good work, that's great!
I was considering to add this feature and never had time.
I have a few concerns that will need some tedious modification from you though, sorry about that part:

Please pull master into your code

Please respect the linting styles in place in the codebase: for instance no semi-column, simple quotes in Javascript, space before parenthesis on method definition, etc. Unfortunately It looks like you have reformatted the whole files you worked in. So it's really hard for me to go through the changes before accepting, there must be a thousand lines changed due to the formatting. :/
the linter is all setup in vue-cal codebase but there is currently an issue https://github.com/babel/babel-eslint/issues/681#issuecomment-595591823 that prevents running in the background.
You always run npm run lint and npm run lint --fix it will correct a fair amount of issues for you 👍

Please put back the CSS you did not change as it was.

Please respect the naming convention in place in the codebase: all the emitted events are kebab-case.

If an instruction is on a single line, leave it on a single line.

Last but not least, please don't do a pull request before you are done or before you are done testing.
You can also create an issue where we can discuss a new feature  before you start it if it's not small changes, might end up useful :)
Sorry to make you change your formatting now, but it should be straightforward with the help of npm run lint.
Thanks for your contribution again it looks quite promising, I will test it and review it when you are done. 😉
Cheers!

It's totally fine, thank for reviewing. This is my first attempt to contribute, so every help appreciated. I'm on it :)

Awesome, I haven't tested but I'm sure you're doing a great feature.
Thanks @r32rf for your help testing as well.

Ok, I think I've done everything you asked. If not let me know :)

This looks great @Csandori!
Thanks for this great feature and reformatting, I will merge it soon and review it.
Sorry it's been dragging for some time, I am very busy atm.

This is really some good work @Csandori, love it. 👏👏
I will integrate it with more constraints and options and document it.
Will let you know when ready

We also need to check mousemove mouseup on the whole document so there is no problem when dragging and releasing outside of the cell or split. I'll add that

For information I moved this whole feature in the drag-event-creation as it still needs some dev.
I will work in it until I merge back to master.
if ever you you do some change please do it there and pull regularly.
The master is currently reverted so I can do urgent patches.
You should pull that one too if you plan to do other PRs.

Hi @Csandori,
Quick heads-up regarding this PR: I have finished refactoring and adding new features on top of this. It looks great.
I now need to write the documentation and update all the example about event creation.
Thanks for your work again!
Now that you know the codebase, you would be nailing new features!
If ever you want to get onboard on Vue Cal dev, let's get in touch via email.
My email is in the package.json.
Cheers!

Great!
Looking forward for the release!
I've already sent the email.

Hi @Csandori, it is now live: https://antoniandre.github.io/vue-cal/#release-notes 3.5.0!
PS. Will reply to your email soon.

authors: Csandori antoniandre r32rf

repo: antoniandre/vue-cal


text:
Adicionando mais dois ditados

Adicionei mais dois ditados no arquivo ditados,js

I feel like these are slang expressions, not exactly ditados.

replace two ditados.js

authors: Dani-jardim antonioalmeida

repo: antonioalmeida/ditado-api


text:
Add ranks-to-hash method to FEN::Result

Please add a method to FEN::Result that converts obtained ranks into a hash in which the keys are chess-coordinates and the values are chess pieces.
Here is an example implementation:
use FEN::Grammar;
use FEN::Actions;

my $fen = 'rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR';
my $match = FEN::Grammar.parse($fen);

my $actions = FEN::Actions.new;
my $match = FEN::Grammar.parse($fen, actions => $actions);
my $resObj = $match.made;
my @ranks = $resObj.ranks; # Array of ranks

my %to-letters = (^8) Z=> 'a'..'h';
my @ranks2 = @ranks.kv.map( -> $k, $v { $v.map( { (8 - $k, %to-letters{$_.head}) => $_.tail }) }).flat;
say @ranks2

[(8 a) => r (8 b) => n (8 c) => b (8 d) => q (8 e) => k (8 f) => b (8 g) => n (8 h) => r (7 a) => p (7 b) => p (7 c) => p (7 d) => p (7 e) => p (7 f) => p (7 g) => p (7 h) => p (2 a) => P (2 b) => P (2 c) => P (2 d) => P (2 e) => P (2 f) => P (2 g) => P (2 h) => P (1 a) => R (1 b) => N (1 c) => B (1 d) => Q (1 e) => K (1 f) => B (1 g) => N (1 h) => R]

Wrong repository.


text:
Game Support for Player Unknown Battlegrounds

What are you experiencing an issue with?

[ ] Aurora
[x ] Aurora supported game, (Player Unknown Battlegrounds)
[ ] Aurora Wrapper
[ ] Aurora Profile
[ ] Aurora supported device, (Fill in problematic devices)
[ ] Aurora Scripts
[ ] Aurora Updater
[ ] Aurora Lighting issue
[ ] Other, (Fill in another issue here)

Profile does not change when game has been launched. Have already set the target file but to no avail.
I am aware it is a new game so you might have to add support for it but I am just letting you know. Wonderful program otherwise

It could be great to have lights on the game ! looking forward to news !

Currently, there doesn't appear to be any way to realistically implement support for PUBG. Closing until further notice.

authors: Boiijek TristanPra simon-wh

repo: antonpup/Aurora


text:
Listening on the index of current  active slide

Hi,
I've read the documents, and still don't know how to use events.
Could you give an example about how to listen on the index of current active slide?

Hi @sarahxoxo,
The fact that vue-glide provides only those events that are in the glide.js that are prefixed with glide:. Glide.js not provide index of active slide.
Currently, vue-glide has a custom event glide: slide-click which returns the index of the slide on which the click was made. This part is a further development in which I plan to add slide switching by click.

Hi @antonreshetov ,
Got it. Thanks for your reply.

@antonreshetov

This part is a further development in which I plan to add slide switching by click.

Is there a way to do this currently with the slider. ?

My solution if it helps someone, using the slide-click
 <vue-glide           ref="slider"           @glide:slide-click="moveSlide"         >
moveSlide(index) {       this.$refs.slider.glide.go(=${index})     }

@antonreshetov

This part is a further development in which I plan to add slide switching by click.

Is there a way to do this currently with the slider. ?

<vue-glide ref="slider" @glide:swipe-end="setDataProducts">
Methods:
setDataProducts(){
this.$refs.slider.glide.index
}

authors: Enigama antonreshetov madhurikulkarni sarahxoxo

repo: antonreshetov/vue-glide


text:
[IPv6] Support dual-stack mode in no-encap mode with Linux

Describe what you are trying to solve
Antrea should support dual-stack in no-encap mode with Linux.
Current the basic Node/Pod to Pod cross-node traffic fails. When adding routes to other nodes, the destination pod CIDR and NodeIP are not in the same IP family.
E0715 15:34:18.049419       1 node_route_controller.go:344] Error syncing Node zhecheng-ipv6-1-0, requeuing. Error: failed to install route to peer zhecheng-ipv6-1-0 (10.176.26.41) with netlink. Route config: {Ifindex: 0 Dst: 2001:db8:42::/64 Src: <nil> Gw: 10.176.26.41 Flags: [] Table: 0}. Error: gateway, source, and destination ip are not the same IP family

Describe the solution you have in mind

[x] Upgrade dual-stack testbeds to support both IPv4, IPv6 address in Node's internalIP. Improve the cluster performance.
[ ] Fix bugs in antrea that only one NodeIP is used when adding routes to other nodes.
[ ] Maybe file bug in kubernetes repo about the incomplete doc: https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/dual-stack-support/

Test plan
At least test dual-stack mode in no-encap mode once after the fix is ready. Maybe have a regular job but I am not sure if it is necessary.

Now, dual-stack testbeds include 2 InternalIP: IPv4 and IPv6.
Due to more resource consumption of dual-stack testcase, testbeds' CPU and memory are enhanced: 3 -> 8 CPU, 4 -> 12G

repo: antrea-io/antrea


text:
[VM Agent] Fix agent crash issue with nil pointer exception

Set default value on config.Egress.SNATFullyRandomPorts with VM Agent scenario to avoid agent crash, although routeClient is not really consumed.

/test-vm-e2e

/test-vm-e2e

authors: XinShuYang wenyingd


text:
请问维度为 Cat 类型的图表，怎么做趋势线？？

内容描述不够清晰，数据是 cat 或者 timecat 本身影响不大。

内容描述不够清晰，数据是 cat 或者 timecat 本身影响不大。

详见 #2545，我的需求是维度使用分类字段时，如何做趋势线？

详见 #2545，我的需求是维度使用分类字段时，如何做趋势线？

详见 #2545，我的需求是维度使用分类字段时，如何做趋势线？

已经回复了。

详见 #2545，我的需求是维度使用分类字段时，如何做趋势线？

已经回复了。


text:
【G2 多轴图】多个柱形+一个折线共用横坐标轴，tooltip框内容显示错误

问题描述
需求是要把多个柱子放在同一位置进行展示，方便比较柱子之间的差距，同时加上折线图显示百分比值。
目前问题出现在柱子两侧的tooltip上，正常情况下应该显示四个值，但是只显示了两个值，值出现的规律与柱形图注册顺序相关。
比如折线图是w，柱形图的注册顺序是：a，b，c。
在柱子左侧会显示：w、a。
柱子中间会显示：w、a、b、c。
在柱子右侧会显示：w、c
重现链接
https://stackblitz.com/edit/vitejs-vite-ze2cao?file=src%2Findex.js
重现步骤
1、将鼠标放在重现链接内的柱子左侧

2、顺着从左往右的方向继续滑动

3、直到到达柱子右侧

预期行为
期望无论是在哪个位置，都可以完整的显示y轴的值
平台

操作系统: [macOS, Windows, Linux, React Native ...]
网页浏览器: [Google Chrome, Safari, Firefox]

屏幕截图或视频（可选）
No response
补充说明（可选）

同，请问解决了吗

@amzfcy  https://github.com/antvis/G2/pull/6295 解决了这个问题，过几天会发布

@RobinJason @amzfcy #6295 解决了这个问题，过几天会发布

感谢修复🙏

同，请问解决了吗

我更新到了5.1.23版本，打开看已经OK了，发布的应该是这个版本，你也更新试试看吧

authors: RobinJason amzfcy pearmini


text:
修改饼图图例联动示例交互异常问题

Checklist

[x] npm test passes
[x] tests and/or benchmarks are included
[x] commit message follows commit guidelines

Description of change

demo 中交互的时候交互动画异常，原因就在于chart 多次 rander 导致交互响应不及时，这里把 Annotation 更新放在单独的 view 中，独立 render ,不再 render 外部图形

Pull Request Test Coverage Report for Build 770046843

0 of 0   changed or added relevant lines in 0 files are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.06%) to 93.497%

Files with Coverage Reduction
New Missed Lines
%

src/chart/controller/gesture.ts
7
82.14%

Totals

Change from base Build 769538230:
-0.06%

Covered Lines:
10921

Relevant Lines:
11326

💛  - Coveralls

官方示例
我看这个官方示例里面，我在饼图各图形间移动，交互效果动画会出现问题。我的电脑 win10，chrome 90 版本。出现这个问题的原因是因为多次重复render的结果

authors: coveralls yonggeCode


text:
docs(get-start): add docs when disposing the node

快速上手步骤里新增步骤3，提示用户何时需要销毁实例，避免新手踩坑。

Checklist

[ ] npm test passes
[ ] tests and/or benchmarks are included
[ ] commit message follows commit guidelines

Description of change

根据您提出的问题，我这边已经做了补充和修改。 @hustcc


text:
将近500个combos渲染卡顿问题

问题描述
1.7000个节点，9000多条边，500个combo渲染很慢，并且渲染完成后，操作非常卡顿，除了节点有连线，combo之间也有连线

重现链接
无
重现步骤
1.进入页面，渲染时间长
预期行为
希望能支持大数据渲染
平台

操作系统: [macOS, Windows, Linux, React Native ...]
网页浏览器: [Google Chrome, Safari, Firefox]
G6 版本: [4.5.1 ... ]

屏幕截图或视频（可选）
No response
补充说明（可选）
No response

combo 多确实很消耗性能，因为有很多层级关系需要计算，可以给个例子我看下怎么优化。
这里有一些优化思路：https://g6.antv.antgroup.com/manual/faq/performance-opt


text:
区域图颜色是否支持渐变色

想让区域图中的图层颜色为渐变色，当时是否支持？
如果支持，应该如何实现，文档中并无相关说明

L7Plot Version:
Platform:

不支持

authors: lvisei zoushujun


text:
🤔

🏷 Version

Package
Version

@antv/s2
1.54.2

@antv/s2-react
1.46.0

Sheet Type

[ ] PivotSheet
[x] TableSheet
[ ] GridAnalysisSheet
[ ] StrategySheet
[ ] EditableSheet

🖋 Description

官网明细表隐藏表头示例，展示动图可以点击隐藏表头，在实例内showTooltip和hiddenColumns为true了，但是表头那没有出现，hiddenColumns是控制是否展示隐藏按钮的吗，还需要其他的设置吗
tooltip: {
        showTooltip: true,
        operation: {
          // 开启手动隐藏
          hiddenColumns: true,
        },
      },

🔗 Reproduce Link
s2官网示例

😊 Expected Behavior
😅 Current Behavior

官网明细表隐藏表头示例，展示动图可以点击隐藏表头

s2Options.tooltip.operation.hiddenColumns 控制是否允许手动点击隐藏 ( 列头 tooltip 中的小眼睛 icon)
s2Options.interaction.hiddenColumnFields 控制默认隐藏的列头

@antv/s2 没有实现 tooltip 的 UI, 所以点击列头不会展示 tooltip, 官网这里有说明
@antv/s2-react 是基于 antd 封装的 UI, 你反馈的这个 Demo 对应的 gif 有点问题, gif 录制的时候用的是 React 版本的, 代码示例又是用的 @antv/s2, 所以造成误解了, 后续我们更换一下 gif, 抱歉, 可以查看 React 版本的 demo, 这个是正确的

还需要其他的设置吗

你使用的 React 版本, 所以不会有这个问题, 只需要引入相应的样式即可, 可以这样理解:
@antv/s2 提供手动隐藏的能力和相应 API, 只支持控制默认隐藏的列头, 如果想手动点击列头隐藏, 需要自己实现 Tooltip 的 UI, 然后调用相应的 API
@antv/s2-react 是基于上诉步骤封装的, 所以可以直接使用.


text:
fix: :bug: 修复s2-react组件污染全局样式问题 close#1144

👀 PR includes

🐛 Bugfix

[x] Solve the issue and close #1144

:tada: This PR is included in version @antv/s2-react-v1.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


text:
G6自定义图形对IE支持问题

例子：http://antv.alipay.com/zh-cn/g6/1.x/demo/flow/saoma.html
自定义图形使用getHtml返回一个定义好的DOM元素，这个方法的实现使用G6.Util.createDOM()创建元素，然后appendChild()添加元素，但是在IE环境中对嵌套元素是有问题的，只能识别一层关系，必须使用document.createElement()的方式才能正确识别，希望改进G6.Util.createDOM()对IE的实现。
var e = G6.Util.createDOM('
ab
');
container.appendChild(e);
// 结果<container>

</container>, 内部span元素不会被IE识别
IE需要如下方式:
var div = document.createElement('div');
var span1 = document.createElement('span');
var span2 = document.createElement('span');
span1.appendChild(document.createTextNode('a'));
span2.appendChild(document.createTextNode('b'));
div.appendChild(span1);
div.appendChild(span2);
   container.appendChild(div);  // 这种方式IE识别

修改

感谢反馈，会排期改进。

这个是用 innerHtml 做的，经测，没有这个兼容性问题。

authors: TomHuangCN jcllove


text:
Scroll to top bar fixed and added also fixed footer of saveNature page

My issue No is  #146
I have added the scroll to top to the save nature page and also fixed the footer page

brother can you check and approve pr request

Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


text:
拼接问题

我代码水平菜，按我的理解，是把影像切割，训练，预测，拼接。训练的越多，拼接的效果越好。那拼接的意思就是直接硬拼是吗，我感觉那就是concat这个函数解决的拼接问题对吗？就像两个矩阵拼在一起一样，是吗？感谢解答疑惑。

是的，硬拼
发自我的 iPhone
在 2023年2月7日，15:49，不夜候 @.***> 写道：

我代码水平菜，按我的理解，是把影像切割，训练，预测，拼接。训练的越多，拼接的效果越好。那拼接的意思就是直接硬拼是吗，我感觉那就是concat这个函数解决的拼接问题对吗？就像两个矩阵拼在一起一样，是吗？感谢解答疑惑。
—
Reply to this email directly, view it on GitHubhttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fanxiangsir%2Fdeeplabv3-Tensorflow%2Fissues%2F36&data=05|01||e8fa5722a7844124b20108db08dfcc93|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638113529549152190|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=ZPqMqSKUgMQrFpqXEPCB3zPaumCxHCayxE9afDRe%2FEk%3D&reserved=0, or unsubscribehttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHN3KJVLDVXMSCHGDAM2RGLWWH47LANCNFSM6AAAAAAUTTVVZI&data=05|01||e8fa5722a7844124b20108db08dfcc93|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|638113529549152190|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=x15U33QHuhjbf7t14XNxLVTNQXVYaytUhIeKYcA5QZs%3D&reserved=0.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

authors: anxiangsir yijian-stack


text:
Feature async message

Implemented Async Messages /c @skryukov  #2

Thanks for the PR. Closing in favor of #9


text:
Custom storage location

Have you read a contributing guide?

[X] I have read CONTRIBUTING.md
[X] I have searched the existing requests and didn't find any that were similar
[X] I have considered creating a pull request instead and want to proceed

Clear and concise description of the problem
If I setup server with SBC which has Linux on small ssd 128Gb I'd like to setup easily custom location for mounted HDD with 1TB of storage.
Suggested solution
Please, add environment variable that allow to store Volume on bigger HDD drive
Alternative
No response
Additional context
No response

I added "STORAGE_DIR" variable https://github.com/anyproto/any-sync-dockercompose/releases/tag/v5.0.0
before use, please read the update and configuration guides.

@fb929 after the update to 5.x.x version I got redis container unhealthy error, it disappeared somehow, but now mongo 'unhealthy' error appeared. Don't know why. Tried clean re-install without any luck.

@Onefabis did you moving files ?
https://github.com/anyproto/any-sync-dockercompose/wiki/Configuration#existing-setup

Sorry, that was my fault, forgot to add that lines to docker-compose.override.yml
services:
  mongo-1:
    healthcheck:
      test: echo "rs.initiate({_id:'${MONGO_REPLICA_SET}',members:[{_id:0,host:\"mongo-1:${MONGO_1_PORT}\"}]}).ok || rs.status().ok" | mongo —port ${MONGO_1_PORT} —quiet

repo: anyproto/any-sync-dockercompose


text:
ru_RU - Correction of links, translations, localization of illustration

[x] I understand that contributing to this repository will require me to agree with the CLA

Description

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[ ] 🐛 Bug Fix
[x] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 tech-docs
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@fuksman Hi, could you check it out 🤓 I'd really appreciate it.

@any contributor @tamerlan-pro docs l10n

authors: fuksman tamerlan-pro

repo: anyproto/docs


text:
Create static anyM creational methods for Try, FeatureToggle, Case and Cases

Missing anyM creational methods for Monad types not in base module

also Failure biased option for cyclops Try

Try and FeatureToggle have AnyM creational and conversion methods

repo: aol/cyclops


text:
bug find

On around like 284
export PATH=$TDIR/bin:$PATH
sudo -E make install
echo "MOLOCH: Installed, now type sudo make config'"
else
echo "MOLOCH: Now type 'sudo make install' and 'sudo make config'"
fi
That three part code uses sudo combined with export. Do you see that?
Please read man sudo
Look at the -E flag
Seems like sudo doesn't pass environment variables.
Can you all look at this? Open a bug and fix it?

I don't understand what your issue is.  Can you open an issue please.

authors: awick kennafray

repo: aol/moloch


text:
Remove old upgrade steps

Since we will only need to support upgrading from the most recent LTM release, any upgrade code that exists to upgrade to 2.1 is no longer needed for 3.0, and should be removed to simplify maintenance of the upgrade process.

This was done with #3160

repo: apache/accumulo


text:
Unlimited threads for compaction reservation can oversubscribe manager memory

Describe the bug
When a compactor request a compaction job from the manager the following things happen.

The request runs in the general client thrift thread pool (note this thread pool will slowly automatically increase)
The request reads tablet metadata and then writes a conditional mutation to add the the compaction to tablet metadata.

When there are lots of compactors and there is a problem writing to the metadata table these threads will grow in an unlimited manner. Saw this problem occur and it was probably caused by not having the fixes for #5155 and #5168, however there are many other potential causes that could cause threads to get stuck or be slow.
Expected behavior
The number of threads concurrently executing compaction reservation is somehow constrained.  This must be done w/o blocking other manager functionality.   A simple way to achieve this goal would be to add a semaphore around this functionality, however this would cause general thrift threads that execute all manager functionality to block which could cause other problems but maybe that is ok since the manager thread pool always grows.
One possible way to achieve this goal would be to use #5018 and in the async code for executing compaction reservation runs in a limited thread pool. #5018 was created for performance reason, but it can also easily satisfy this goal of protecting manager memory.
Another possible way to achieve this goal would be run another thrift server w/ its own port for getting compaction jobs and limit the thread pool size for this.

The Jetty solution (or another async solution like gRPC) would be interesting to try because you'd get the performance benefits as well. As you pointed out, we'd need to make sure to limit things by passing in a thread pool when there is a job available at this line and that should prevent trying to reserve too many jobs at once.
Another thing that would help solve this problem would be #4978 because if those changes were made then the compaction coordinator would no longer be handling the job reservations as that responsibility would be moved to the compactor itself

Another thing that would help solve this problem would be https://github.com/apache/accumulo/issues/4978 because if those changes were made then the compaction coordinator would no longer be handling the job reservations as that responsibility would be moved to the compactor itself

That is a good point.  I made a comment on 4978 about async processing for tserver conditional mutation processing.  I think that would make that change work really smoothly, but may not be required for it work smoothly.

That is a good point. I made a comment on 4978 about async processing for tserver conditional mutation processing. I think that would make that change work really smoothly, but may not be required for it work smoothly.

I think the final solution will probably be both changes working together to make it very fast and lower the required resources. if we move the compaction job request to async then that keeps the request threadpool free so we don't block other requests, it allows us to bound the number job we requests we process to at one time with a worker thread pool, and it moves the reservation to the compactor which reduces the load even further on the manager.

authors: cshannon keith-turner


text:
Prevent tserver shutdown when only 1 tserver running.

Closes #1753
Add new test to ShutdownTServerTest and rewrite single test

With an ERROR being thrown instead of logged, it looks like the FATE Tx will actually fail:

2022-05-27T12:43:33,843 [fate.Fate] WARN : Failed to execute Repo, FATE[61940a2dc650bf6c]
java.lang.IllegalStateException: Only 1 tserver running and it contains the Root table. Not shutting down localhost:9997[100019a892c0005]
        at org.apache.accumulo.manager.tserverOps.ShutdownTServer.isReady(ShutdownTServer.java:62) ~[accumulo-manager-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
        at org.apache.accumulo.manager.tserverOps.ShutdownTServer.isReady(ShutdownTServer.java:38) ~[accumulo-manager-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
        at org.apache.accumulo.manager.tableOps.TraceRepo.isReady(TraceRepo.java:47) ~[accumulo-manager-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
        at org.apache.accumulo.fate.Fate$TransactionRunner.run(Fate.java:89) ~[accumulo-core-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
        at org.apache.accumulo.core.trace.TraceWrappedRunnable.run(TraceWrappedRunnable.java:52) ~[accumulo-core-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[?:?]
        at org.apache.accumulo.core.trace.TraceWrappedRunnable.run(TraceWrappedRunnable.java:52) ~[accumulo-core-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
        at java.lang.Thread.run(Thread.java:829) ~[?:?]

I don't think this is the right place to do this. I think it would be better to just check in Admin before executing the operation. Closing this.


text:
Fix FlushNoFileIT

IT was failing to find a flushID for every tablet in the table because it was not inserting data into every tablet.

Talked with @keith-turner about this - I don't think we want to merge this. The error that is being thrown, the absence of a flush ID, is likely due to the test only inserting data into one of the tablets. The other tablet is likely not hosted, so a flush does not happen and the flushID is not incremented. This is no longer an error.

Closing in favor of #4064


text:
ARTEMIS-698 Remove full path + executability check of java

Fixes issues with systems that have no "which", as well as the fallback
to using plain "java" from PATH.
This is an alternative fix to #732, see discussion in it for more details.

@scop  I think you should close this PR, and squash this commit into #732
if you squash it and push -f the PR will be updated.

Done.

authors: clebertsuconic scop

repo: apache/activemq-artemis


text:
[AMBARI-23942] Invalid repo url displayed on Ambari UI during service…

… installation
What changes were proposed in this pull request?
In case there are multiple repo versions for a stack UI picks up the first one and uses it in the Add Service Wizard. Fixed it to find the current standard current repo version
How was this patch tested?
Modified the tests
21540 passing (25s)
48 pending

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2435/
Test FAILed.
Test FAILured.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2434/
Test PASSed.

authors: asfgit ishanbha

repo: apache/ambari


text:
[Improvement]: Change the color of the status icon in the running state

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?

How should we improve?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Subtasks
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@nafisreza I think we should just replace ACTIVE with RUNNING.
Refer to : https://github.com/apache/amoro/pull/3173

Thank you. I have added both status and their colors.

authors: nafisreza zhongqishang

repo: apache/amoro


text:
APEXMALHAR-2382 code changes to create meta table

@DT-Priyanka please review,

Please close this PR until there is agreement on the approach. In the future, please have the discussion first. One more minor thing, there is no need to mention "code changes" in commits and PR titles...

authors: Hitesh-Scorpio tweise

repo: apache/apex-malhar


text:
bug: Always try to fetch LoadBalancer when has no LoadBalancer resource defined

Current Behavior
When there is no defines any LoadBalancer resource object in the cluster, the ingress controller consistently attempts to obtain the LoadBalancer object, and continuous print error logs.
Expected Behavior
The error message need to pe suppressed and should not be continuously print when LoadBalancer object has not found. Cause there has some scenes, APISIX will working on NodePort mode and manually controls Load Balancer listeners on cloud.
Error Logs
error	ingress/ingress.go:472	failed to get APISIX gateway external IPs	{"error": "resource name may not be empty"}
Steps to Reproduce

Install APISIX on cluster
Do not create any LoadBalancer object
Make APISIX Gateway service working on NodePort mode
Create Ingress object with APISIX Ingress annotation

Environment

APISIX Ingress controller version: 1.6.0
Kubernetes cluster version: v1.23.8

Maybe we can simply set disable_status_updates to true to avoid this error?
https://github.com/apache/apisix-ingress-controller/blob/589bae607192a5965833fef0a11c210db8d7500d/pkg/providers/ingress/ingress.go#L506C35-L506C35
But i can not ensure that will not cause any unexpected errors.

@yai-dev You can do that in your config overriding the value while installing helm chart. It's just that the the status field on Ingress resource won't be update. There shouldn't be any other issues.

@yai-dev You can do that in your config overriding the value while installing helm chart. It's just that the the status field on Ingress resource won't be update. There shouldn't be any other issues.

Thanks!!

authors: Revolyssup yai-dev

repo: apache/apisix-ingress-controller


text:
long-term stored benchmark performance

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to  the what)
More of a question than a feature request -- I'm wondering if there are plans for running benchmarks on a consistent basis and storing the results so we can see how performance is changing over time in DataFusion. I see there's the conbench directory which presumably could somehow be hooked up to this -> https://conbench.ursa.dev/ . Is that something I could help get running?
If not, do we have any hardware on which we can consistently run benchmarks? I don't think it needs to be as fancy as conbench is at the start, nor would it need to run for every commit. But something simple to help show progression (or regression) would be nice.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I see there's the conbench directory which presumably could somehow be hooked up to this -> https://conbench.ursa.dev/ . Is that something I could help get running?

I think that would be good. I did some work on this but did not get through the work of actually hooking this up.

I finally got around to organizing some thoughts in this area and filed https://github.com/apache/arrow-datafusion/issues/5504 to track getting regular running benchmark runs. Any help people could offer would be super helpful!

authors: alamb andygrove kmitchener

repo: apache/arrow-datafusion


text:
CREATE TABLE SQL support extension

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
CREATE TABLE COMPANY(
   ID INT PRIMARY KEY     NOT NULL,
   NAME           TEXT    NOT NULL,
   AGE            INT     NOT NULL,
   ADDRESS        CHAR(50),
   SALARY         REAL,
   JOIN_DATE	  DATE
);

is not working currently.
NotImplemented("Only `CREATE TABLE table_name AS SELECT ...` statement is supported")

Describe the solution you'd like
It can be done with catalog management.
Describe alternatives you've considered
You can always use with SELECT query, however this usage is more essential.
Additional context
NA

This is implemented currently in the sqllogictest runnner https://github.com/apache/arrow-datafusion/blob/224c682101949da57aebc36e92e5a881ef3040d4/datafusion/core/tests/sqllogictests/src/engines/datafusion/insert.rs#L30
It might be ok to bring the default implementation into SessionContext (alongside the various other Create type statements)

authors: alamb metesynnada


text:
Prune columns / pages that are all null in ParquetExec by connecting up row_counts in pruning statistics

Is your feature request related to a problem or challenge?
@appletreeisyellow  added PruningStatistics::row_counts() in https://github.com/apache/arrow-datafusion/pull/9223 which allows better pruning of columns which are all null.
However, I believe we have not hooked that API up into the ParquetExec, so it won't prune row groups based on this information.
For example, if column a is all NULL, a predicate `a > 5' can never be true, but the  the ParquetExec won't be able to prune row groups or pages for this case
Describe the solution you'd like
Implement RowGroupPruningStastics::row_counts
https://github.com/apache/arrow-datafusion/blob/2dad90425bacb98a3c2a4214faad53850c93104e/datafusion/core/src/datasource/physical_plan/parquet/row_groups.rs#L345-L347
And PagesPruningStatistics::row_counts
https://github.com/apache/arrow-datafusion/blob/2dad90425bacb98a3c2a4214faad53850c93104e/datafusion/core/src/datasource/physical_plan/parquet/page_filter.rs#L550-L552
Describe alternatives you've considered
I think the row counts can be found on https://docs.rs/parquet/latest/parquet/format/struct.ColumnMetaData.html
So this ticket should be a matter of copying the row counts correctly and writing some tests in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/parquet/row_group_pruning.rs / https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/parquet/page_pruning.rs
Additional context
No response

cc @Ted-Jiang  and @progval  as you have been working in this area recently

@alamb Thanks for ping me,  i will check this today

authors: Ted-Jiang alamb


text:
Tests for support try_cast/cast decimal to numeric

Which issue does this PR close?

part of #1443
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

It's ready to review.

I will try and review this later today but I may not be able to review until tomorow

It appears this PR has some conflicts that need to be resolved now

Thanks @liukun4515 -- the only comment I have is it would be nice to reduce some of the duplication if possible, but also a bit of duplication in the tests isn't a horrible thing either.
👍

I have traced this as a subtask in https://github.com/apache/arrow-datafusion/issues/1443

Thanks again @liukun4515


text:
Add window expression part 1 - logical and physical planning, structure, to/from proto, and explain, for empty over clause only

Which issue does this PR close?

Closes #.
This will partly close #298.
Work to be done next: finish #298 and #299
Rationale for this change

this is a very stretch version of adding window function constructs to the planner, proto, etc.
What changes are included in this PR?

logical expression for window expression
physical expression for window expression
basic exec plan structure
basic from/to proto parsing
support explain parsing now

> explain select c1, sum(c3) over () from test;
+--------------+------------------------------------------------------------------+
| plan_type    | plan                                                             |
+--------------+------------------------------------------------------------------+
| logical_plan | Projection: #c1, #SUM(c3)                                        |
|              |   WindowAggr: windowExpr=[[SUM(#c3)]] partitionBy=[], orderBy=[] |
|              |     TableScan: test projection=None                              |
+--------------+------------------------------------------------------------------+
1 row in set. Query took 0 seconds.

> explain select c1, c3, sum(c3 + 2) over () from test;
+--------------+--------------------------------------------------------------------------------+
| plan_type    | plan                                                                           |
+--------------+--------------------------------------------------------------------------------+
| logical_plan | Projection: #c1, #c3, #SUM(c3 Plus Int64(2))                                   |
|              |   WindowAggr: windowExpr=[[SUM(#c3 Plus Int64(2))]] partitionBy=[], orderBy=[] |
|              |     TableScan: test projection=None                                            |
+--------------+--------------------------------------------------------------------------------+
1 row in set. Query took 0 seconds.

Are there any user-facing changes?

I wonder which approach makes more sense:

To implement proto and serde as an API first and leave a lot of unimplemented stubs
To try to cover a minimal working end to end feature and leave advanced use cases like window frames for later

@Jimexist I think it would be perfectly fine if more "advanced" features like window frames etc. are not supported, just as not all window functions have to be supported.
If we could just support e.g. ROW_NUMBER() OVER () or  MAX(x) OVER () with default spec that would be great already.

@Dandandan @alamb PTAL

I will try to review this later today but I may not get to it until tomorrow

Checking it out...

I haven't had the time to go through yet;
Since this is a large decomposable change, a suggestion here is to create a branch and merge this on that branch, so that we do not have incomplete features in master and allow PRs to that branch without an issue. Then merge the branch into master once its first iteration is ready (e.g. logical and 1 physical plan).
(This is something that I wished to have when implementing large features; it gives the time to review in parts without the risk of having incomplete code in master)
With that said, I am also fine risk it and merg to master; @Jimexist do you have any preference how would you prefer to work on this here? :)

I am supportive of putting this directly on master -- we have various other "not yet implemented" functionality in DataFusion and I think we can handle any potential confusion with additional documentation

I haven't had the time to go through yet;
Since this is a large decomposable change, a suggestion here is to create a branch and merge this on that branch, so that we do not have incomplete features in master and allow PRs to that branch without an issue. Then merge the branch into master once its first iteration is ready (e.g. logical and 1 physical plan).
(This is something that I wished to have when implementing large features; it gives the time to review in parts without the risk of having incomplete code in master)
With that said, I am also fine risk it and merg to master; @Jimexist do you have any preference how would you prefer to work on this here? :)

I wish to:

add unit tests
fix some small comments like
adding filter clause to leave room for future room without API disruption,
adding nth_value and tile
merge it into master as it

3 because although I agree with having a feature branch, the maintenance of continuous rebasing is trouble some. if I can keep the merged code isolated and structurally correct then there's little worry about breaking changes in future: I believe this PR:

is isolated because  the explain works, while actually executing the window SQL returns zero rows, due to unimplemented exec plan, which I intend to do next
is structurally correct if reviewers can focus on the phase and timing of the window clause in the query planner. future changes of e.g. adding one or more sort phases requires only modifications within the .window fn and thus can be non-intrusive

I went over this PR quite carefully. Thank you very much @Jimexist for the contribution! ❤
❤ -- this PR looks to be in great shape.
All I think this PR needs is a few more tests and it could be merged in.
I am not familiar with the ballista code, but it looked ok to me. @andygrove do you have any suggestions of who might be interested in those changes?

thanks for the comment! @andygrove I am not 100% sure of the oneof usage in the window_frame field, so I guess that's one place to look at.

@alamb @jorgecarleitao updated
> explain select c1, max(c3) over (), avg(c3) over () from test;
+--------------+----------------------------------------------------------------------------+
| plan_type    | plan                                                                       |
+--------------+----------------------------------------------------------------------------+
| logical_plan | Projection: #c1, #MAX(c3), #AVG(c3)                                        |
|              |   WindowAggr: windowExpr=[[MAX(#c3), AVG(#c3)]] partitionBy=[], orderBy=[] |
|              |     TableScan: test projection=None                                        |
+--------------+----------------------------------------------------------------------------+
1 row in set. Query took 0 seconds.

🤔  it looks like there is one test failure now:
---- physical_plan::window_functions::tests::test_cume_dist_return_type stdout ----
Error: Plan("The function expected 0 arguments but received 1")
thread 'physical_plan::window_functions::tests::test_cume_dist_return_type' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `0`: the test returned a termination value with a non-zero status code (1) which indicates a failure', /rustc/9bc8c42bb2f19e745a63f3445f1ac248fb015e53/library/test/src/lib.rs:193:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- physical_plan::window_functions::tests::test_window_function_from_str stdout ----
Error: Plan("There is no built-in function named cum_dist")
thread 'physical_plan::window_functions::tests::test_window_function_from_str' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `0`: the test returned a termination value with a non-zero status code (1) which indicates a failure', /rustc/9bc8c42bb2f19e745a63f3445f1ac248fb015e53/library/test/src/lib.rs:193:5

🤔 it looks like there is one test failure now:
---- physical_plan::window_functions::tests::test_cume_dist_return_type stdout ----
Error: Plan("The function expected 0 arguments but received 1")
thread 'physical_plan::window_functions::tests::test_cume_dist_return_type' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `0`: the test returned a termination value with a non-zero status code (1) which indicates a failure', /rustc/9bc8c42bb2f19e745a63f3445f1ac248fb015e53/library/test/src/lib.rs:193:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- physical_plan::window_functions::tests::test_window_function_from_str stdout ----
Error: Plan("There is no built-in function named cum_dist")
thread 'physical_plan::window_functions::tests::test_window_function_from_str' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `0`: the test returned a termination value with a non-zero status code (1) which indicates a failure', /rustc/9bc8c42bb2f19e745a63f3445f1ac248fb015e53/library/test/src/lib.rs:193:5

@alamb sorry I did try to add more tests, but then forgot to push.

Codecov Report

Merging #334 (6941151) into master (913bf86) will decrease coverage by 0.95%.
The diff coverage is 36.84%.

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
- Coverage   75.89%   74.94%   -0.96%
==========================================
  Files         144      146       +2
  Lines       23771    24314     +543
==========================================
+ Hits        18040    18221     +181
- Misses       5731     6093     +362

Impacted Files
Coverage Δ

...lista/rust/core/src/serde/logical_plan/to_proto.rs
62.37% <0.00%> (-5.46%)
:arrow_down:

datafusion/src/optimizer/constant_folding.rs
91.63% <0.00%> (-0.30%)
:arrow_down:

datafusion/src/optimizer/hash_build_probe_order.rs
60.50% <0.00%> (-1.57%)
:arrow_down:

datafusion/src/optimizer/projection_push_down.rs
91.11% <0.00%> (-7.63%)
:arrow_down:

datafusion/src/optimizer/utils.rs
47.76% <0.00%> (-2.05%)
:arrow_down:

datafusion/src/physical_plan/mod.rs
82.75% <0.00%> (-1.95%)
:arrow_down:

datafusion/src/physical_plan/planner.rs
76.51% <0.00%> (-4.11%)
:arrow_down:

datafusion/src/physical_plan/sort.rs
92.07% <ø> (ø)

datafusion/src/physical_plan/windows.rs
0.00% <0.00%> (ø)

datafusion/tests/sql.rs
99.89% <ø> (ø)

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 913bf86...6941151. Read the comment docs.

authors: Dandandan Jimexist alamb codecov-commenter jorgecarleitao


text:
Change cast error from Internal to NotImplemented

Which issue does this PR close?
re https://github.com/apache/arrow-datafusion/issues/3922
Rationale for this change
Reporting an InternalError is confusing
What changes are included in this PR?
Change InternalError to NotImplemented when a particular cast is not supported
Are there any user-facing changes?
different error

LGTM

authors: alamb waitingkuo


text:
Fix decimal scalar dyn kernels

Which issue does this PR close?

Follow of #5151.
Rationale for this change

For add_decimal_dyn_scalar and subtract_decimal_dyn_scalar, it should call get_precision_scale and decimal_array_with_precision_scale like multiply_decimal_dyn_scalar and divide_decimal_dyn_scalar as the input/output could be DictionaryArray.
What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

CI seems broken:
warning: Not a git repository. Use --no-index to compare two paths outside a working tree
usage: git diff --no-index [<options>] <path> <path>

Proposed CI fix at #5182.


text:
Update README.md fix [welcoming community] links

Which issue does this PR close?

Closes #.
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Thanks @jiangzhx

authors: jackwener jiangzhx


text:
Parallelize Parquet Serialization (Alternative Implementation)

This is a draft PR to show an alternative implementation for #7562 which was largely unsuccessful. The goal of this alternative implementation was to reduce memory usage, but it ultimately did not reduce memory usage and also slowed down execution time significantly. See #7562 for benchmarking results.

This actually turned out to be ~10% faster and slightly lower memory usage in a release build. The approach from this PR is pulled into the main PR now, so I am closing this one as no longer needed.


text:
Add support for opening a database

We can use constant user and database for now.

Done by #14.

repo: apache/arrow-flight-sql-postgresql


text:
Strongly Typed Array Slicing

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently calling Array::slice returns an ArrayRef, even if calling on a strongly typed array. This results in a lot of code of the form
let a = Int32Array::from(vec![Some(15), None, Some(9), Some(8), None]);
let a = a.slice(1, 4);
let a = a.as_primitive();

This is not only verbose but has potential performance implications.
Describe the solution you'd like

Arrays should provide Array::slice(&self, offset: usize, len: usize) -> Self
Describe alternatives you've considered

Additional context

Part of #3880

label_issue.py automatically added labels {'parquet'} from #3930

repo: apache/arrow-rs


text:
[C++][Parquet] Allow partial prebuffer in parquet FileReader

The current FileReader can only work in  one of the two modes, coalescing (when Prebuffer is called) and non-coalescing (when Prefufer is not called), due to the if statement here
Since Prebuffer is basically caching all specified column chunks, it would raise concerns on memory usage for systems with tight memory budget. In such scenarios, one may want to Prebuffer some small chunks while being able to read the rest chunks using  BufferedInputStream.
Reporter: Jinpeng Zhou / @jp0317
Assignee: Jinpeng Zhou](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=zjpzlz) / @jp0317
PRs and other links:

GitHub Pull Request #36192

Note: This issue was originally created as PARQUET-2316. Please see the migration documentation for further details.

Gang Wu / @wgtmac:
Issue resolved by pull request 36192
https://github.com/apache/arrow/pull/36192

repo: apache/arrow


text:
ARROW-571: [Python] Add unit test for incremental Parquet file building, improve docs

This was actually already documented. I improved the docstring for ParquetWriter and added a unit test to validate the user API. Added ParquetWriter to the API listing also

Travis fails with
Traceback (most recent call last):
 File "<string>", line 1, in <module>
 File "/home/travis/build/apache/arrow/pyarrow-test-2.7/lib/python2.7/site-packages/pyarrow/parquet.py", line 275, in <module>
 """.format(_parquet_writer_arg_docs)
AttributeError: attribute '__doc__' of 'type' objects is not writable```

Thanks, will fix

authors: wesm xhochy


text:
GH-37017: [C++] Guard unexpected uses of BMI2 instructions.

Rationale for this change
Some functions introduced with Acero only check for AVX2 availability, but they actually invoke BMI2 instructions.
This can have two negative consequences:

compiling BMI2 intrinsics may fail because BMI2 was not explicitly enabled on the compiler (gh-37017)
some rare CPUs (Via CPUs perhaps) may support AVX2 but not BMI2; other CPUs by AMD have a very inefficient implementation of some BMI2 instructions

What changes are included in this PR?

Ensure that the suitable compiler flag is passed when compiling code with BMI2 intrinsics
Make sure the CPU supports BMI2 adequately before invoking functions featuring BMI2 instructions

Are these changes tested?
Yes, assuming CI covers enough diversity of target platforms.
Are there any user-facing changes?
No, but performance might change (positively or negatively) depending on the CPU and platform.

Closes: #37017

@github-actions crossbow submit r-binary-packages

@github-actions crossbow submit -g cpp

I assume that the remaining errors on r-binary-packages above are not related, but I'd appreciate if someone more competent could double-check? @assignUser or @thisisnic  perhaps?

Oh thanks @pitrou I will check!

Yeah the remaining errors look unrelated (brotli linking error and actions/checkout failing on centos7...) +1

I'm somewhat surprised we don't just fold AVX2 + efficient BMI2 into a single SIMD level

Historically we didn't use BMI2 at all. It then appeared only for a very special operation in Parquet, while AVX2 can be implicitly enabled in lots of other places.
This was manageable, but of course the stealth use of BMI2 in Acero makes the situation more annoying.

If I understand correctly we compile the _avx2.cc files with both AVX2 and BMI2 enabled. Doesn't this meant that any function in any _avx2.cc file may contain a bmi2 operation?

Nit: only two _avx2.cc files are concerned, those that use explicit BMI2 intrinsics.

In other words, even if we examine a file and determine it has no explicit pext, pdep, etc. then wouldn't it still be possible for the compiler to insert those instructions itself as an implicit operation?

Indeed. But this PR introduces matching runtime guards when calling those functions, so this shouldn't be a problem.
Am I missing another concern here?

(distantly related: https://github.com/apache/arrow/issues/26514 )

Am I missing another concern here?

Consider the file level_comparison_avx2.cc. It doesn't contain any explicit bmi2 instructions.  Currently, we compile it with -mavx2 -march=haswell and so it also won't contain any implicit bmi2 instructions (inserted by the compiler).
However, if I understand this PR, it is changing this to compile with -mbmi2 -mavx2 -march=haswell.  So, even though there are not any explicit bmi2 instructions, isn't the compiler free to insert bmi2 instructions in an optimization pass?
That being said, I just tested this file, and several others with avx2 in the name, and adding the -mbmi2 flag did not change the compiled object file at all.  So maybe gcc doesn't do any bmi2-specific optimization or maybe these files just can't take advantage of it.

That's not what this PR does. The BMI2 flag should only be passed for three files: parquet/level_conversion_bmi2.cc, arrow/compute/key_map_avx2.cc and arrow/compute/util_avx2.cc. Are you seeing something else?

No, it's ok to merge since everyone seems to be ok with the approach.

I posted #37623 as a followup to reenable more code paths.

authors: assignUser pitrou westonpace


text:
GH-37694: [Go] Add SetNull to array builders

Rationale for this change
We are proposing to add a SetNull(i int) to the Builder interface.
The underlying builder type implements this for most types.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?
The SetNull is added to the Builders type.

Closes: #37694

Thanks for taking a look.
I'll add the tests now, which was the plan all along, just had to attend a meeting. :sweat_smile:


text:
ARROW-6292: [C++] Add option to use the mimalloc allocator

mimalloc is a cross-platform memory allocator that promises good performance, by Microsoft.
https://github.com/microsoft/mimalloc/
Also refactor the memory pool API and tests to expose all available memory pool
implementations, not just the default one.

@ursabot build

Here are some builder benchmarks on Ubuntu 18.04.
jemalloc
BuildBooleanArrayNoNulls              74276370 ns   74094476 ns          8   3.37407GB/s
BuildIntArrayNoNulls                 100167339 ns   99885463 ns          7   2.50287GB/s
BuildAdaptiveIntNoNulls               38526266 ns   38314882 ns         18   6.52488GB/s
BuildAdaptiveIntNoNullsScalarAppend  256890072 ns  256757146 ns          3   997.051MB/s
BuildBinaryArray                     765304063 ns  763166736 ns          1   335.444MB/s
BuildChunkedBinaryArray              562859306 ns  562392265 ns          1   455.198MB/s
BuildFixedSizeBinaryArray            433497460 ns  432849329 ns          2    591.43MB/s
BuildDecimalArray                    707405716 ns  706233881 ns          1   724.972MB/s
BuildInt64DictionaryArrayRandom      567658859 ns  567498732 ns          1   451.102MB/s
BuildInt64DictionaryArraySequential  553848082 ns  553671639 ns          1   462.368MB/s
BuildInt64DictionaryArraySimilar     792605270 ns  792404016 ns          1   323.068MB/s
BuildStringDictionaryArray          1474137106 ns 1473564522 ns          1   231.775MB/s

mimalloc
BuildBooleanArrayNoNulls              42640858 ns   42612607 ns         16   5.86681GB/s
BuildIntArrayNoNulls                 251661873 ns  250780401 ns          3   1020.81MB/s
BuildAdaptiveIntNoNulls               48525877 ns   48288881 ns         14   5.17718GB/s
BuildAdaptiveIntNoNullsScalarAppend  251730236 ns  251655962 ns          3   1017.26MB/s
BuildBinaryArray                     791121016 ns  786811687 ns          1   325.364MB/s
BuildChunkedBinaryArray              563158593 ns  562747126 ns          1   454.911MB/s
BuildFixedSizeBinaryArray            619441757 ns  616826068 ns          1   415.028MB/s
BuildDecimalArray                   1103273055 ns 1100933684 ns          1    465.06MB/s
BuildInt64DictionaryArrayRandom      580926981 ns  580342914 ns          1   441.119MB/s
BuildInt64DictionaryArraySequential  566534124 ns  566351591 ns          1   452.016MB/s
BuildInt64DictionaryArraySimilar     815753240 ns  815327030 ns          1   313.984MB/s
BuildStringDictionaryArray          1506459440 ns 1505203767 ns          1   226.903MB/s

system (glibc) allocator
BuildBooleanArrayNoNulls             110038461 ns  109787541 ns          5   2.27713GB/s
BuildIntArrayNoNulls                 410357811 ns  408636698 ns          2   626.473MB/s
BuildAdaptiveIntNoNulls              110562371 ns  110004564 ns          6   2.27263GB/s
BuildAdaptiveIntNoNullsScalarAppend  265685649 ns  265574583 ns          3   963.948MB/s
BuildBinaryArray                    1003602377 ns 1001422515 ns          1   255.636MB/s
BuildChunkedBinaryArray              605066945 ns  603859093 ns          1    423.94MB/s
BuildFixedSizeBinaryArray            770560241 ns  766574117 ns          1   333.953MB/s
BuildDecimalArray                   1367764643 ns 1361969548 ns          1   375.926MB/s
BuildInt64DictionaryArrayRandom      649778764 ns  649486539 ns          1   394.158MB/s
BuildInt64DictionaryArraySequential  647419063 ns  646682221 ns          1   395.867MB/s
BuildInt64DictionaryArraySimilar     888502530 ns  887294599 ns          1   288.517MB/s
BuildStringDictionaryArray          1601959588 ns 1601238920 ns          1   213.294MB/s

@emkornfield

I've also run the builder benchmarks on Windows 7. It's on a VM, so take the results with a grain of salt:
mimalloc
BuildBooleanArrayNoNulls             716817081 ns    714843750 ns            4 bytes_per_second=358.12M/s
BuildIntArrayNoNulls                 320958235 ns    319444444 ns            9 bytes_per_second=801.391M/s
BuildAdaptiveIntNoNulls               68958525 ns     69196429 ns           42 bytes_per_second=3.6129G/s
BuildAdaptiveIntNoNullsScalarAppend  385890944 ns    386160714 ns            7 bytes_per_second=662.936M/s
BuildBinaryArray                    1195201624 ns   1195312500 ns            2 bytes_per_second=214.17M/s
BuildChunkedBinaryArray              883791376 ns    885416667 ns            3 bytes_per_second=289.129M/s
BuildFixedSizeBinaryArray            815379981 ns    812500000 ns            3 bytes_per_second=315.077M/s
BuildDecimalArray                   1143211358 ns   1140625000 ns            2 bytes_per_second=448.877M/s
BuildInt64DictionaryArrayRandom      939496500 ns    937500000 ns            3 bytes_per_second=273.067M/s
BuildInt64DictionaryArraySequential  931547352 ns    932291667 ns            3 bytes_per_second=274.592M/s
BuildInt64DictionaryArraySimilar    1228586035 ns   1226562500 ns            2 bytes_per_second=208.713M/s
BuildStringDictionaryArray          2366846066 ns   2375000000 ns            1 bytes_per_second=144.817M/s

system allocator
BuildBooleanArrayNoNulls             853392168 ns    843750000 ns            3 bytes_per_second=303.407M/s
BuildIntArrayNoNulls                 493460249 ns    489583333 ns            6 bytes_per_second=522.894M/s
BuildAdaptiveIntNoNulls              155757987 ns    155381944 ns           18 bytes_per_second=1.60894G/s
BuildAdaptiveIntNoNullsScalarAppend  452317869 ns    447916667 ns            6 bytes_per_second=571.535M/s
BuildBinaryArray                    1501523238 ns   1500000000 ns            2 bytes_per_second=170.667M/s
BuildChunkedBinaryArray             1190399758 ns   1187500000 ns            2 bytes_per_second=215.579M/s
BuildFixedSizeBinaryArray           1025575783 ns   1015625000 ns            3 bytes_per_second=252.062M/s
BuildDecimalArray                   1483240328 ns   1484375000 ns            2 bytes_per_second=344.926M/s
BuildInt64DictionaryArrayRandom     1069301638 ns   1052083333 ns            3 bytes_per_second=243.327M/s
BuildInt64DictionaryArraySequential 1013390715 ns   1015625000 ns            3 bytes_per_second=252.062M/s
BuildInt64DictionaryArraySimilar    1348361174 ns   1351562500 ns            2 bytes_per_second=189.41M/s
BuildStringDictionaryArray          2503895327 ns   2500000000 ns            1 bytes_per_second=137.576M/s

(I have no idea why the "bytes_per_second" message is different on Windows)

Codecov Report

Merging #5217 into master will decrease coverage by <.01%.
The diff coverage is 80.39%.

@@            Coverage Diff             @@
##           master    #5217      +/-   ##
==========================================
- Coverage   87.67%   87.66%   -0.01%
==========================================
  Files        1025     1025
  Lines      147008   147085      +77
  Branches     1437     1437
==========================================
+ Hits       128886   128945      +59
- Misses      17760    17778      +18
  Partials      362      362

Impacted Files
Coverage Δ

cpp/src/arrow/memory_pool.h
100% <ø> (ø)
:arrow_up:

cpp/src/arrow/io/file_test.cc
95.1% <0%> (-0.16%)
:arrow_down:

cpp/src/arrow/allocator.h
83.87% <0%> (-2.8%)
:arrow_down:

cpp/src/arrow/memory_pool_test.cc
100% <100%> (ø)
:arrow_up:

cpp/src/arrow/memory_pool.cc
80.76% <79.31%> (-4.82%)
:arrow_down:

cpp/src/arrow/dataset/file_parquet_test.cc
93.84% <0%> (-6.16%)
:arrow_down:

js/src/visitor/indexof.ts
97.26% <0%> (-1.37%)
:arrow_down:

python/pyarrow/table.pxi
87.44% <0%> (-0.69%)
:arrow_down:

cpp/src/arrow/vendored/xxhash/xxhash.c
73.6% <0%> (-0.38%)
:arrow_down:

python/pyarrow/tests/test_table.py
99.62% <0%> (ø)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e29732b...155343a. Read the comment docs.

Overall, looks OK to me, but my CMake knowledge is rusty, it might be good for someone else to take a look and offer a second opinion on conditional API changes.

I think I addressed all review comments.

The Travis-CI job failures look genuine. I opened an issue upstream: https://github.com/microsoft/mimalloc/issues/147

We had issues with static TLS in jemalloc, does mimalloc have a similar option to turn it off?

@wesm See above about CI errors. Answer: yes, I filed a PR which just got merged.

Pushed an update which will hopefully fix the TLS-related issue with Ruby and R (I wonder why Python didn't barf).

I rebased and restored the thirdparty/jemalloc/README.md that had gotten lost in a rebase

In case we're able to do this for 0.15.0: https://issues.apache.org/jira/browse/ARROW-6504

authors: codecov-io emkornfield kszucs pitrou wesm


text:
ARROW-825: [Python] Rename pyarrow.from_pylist to pyarrow.array, test on tuples

The idea is to make this function more semantically analogous to numpy.array -- convert to native data structure with optional explicit type.

Rebased

Agreed. Let's open a new JIRA for this? The existing NumPy import assumes the pandas memory model / null encoding, but here I think we would want to import as-is without any null assumptions

I created https://issues.apache.org/jira/browse/ARROW-838

+1


text:
ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

This adds a one hour timeout to the R builds.  It changes the R CI test script to use reporter="location" by default.  It adds a dump test logs step to the end of the build that will always dump the test output regardless of success/failure.
These three changes combined will make it much easier to debug test failures in R tests.

@jonkeane I think I've added the save test log step to all of the crossbow tasks but I'm not sure how to run those so haven't verified that at all.

@github-actions crossbow submit -g r

That should (if I haven't mis-spelled something!) run all of the r crossbow tests.
You can also run a single crossbow test with @github-actions crossbow submit {test name as found in arrow/dev/tasks/tasks.yaml}

authors: jonkeane westonpace


text:
AVRO-2311: Remove findbugs dependency

Apart of solving this issue, this PR includes other commits to fix issues reported by mvn dependency:analyze, as well as some updates to maven-enforcer-plugin and some other deps.

R: @dkulp

Would be nice to have the dependencies up to date for 1.9, but putting everything into one PR might be a bit tricky.

Yep better to have the approach you started bringing some PRs later on.

authors: Fokko iemejia

repo: apache/avro


text:
[Bug]: BigQuery cross-language ReadFromQuery is outputting Beam rows with a different UUID than expected output.

What happened?
This was found in the Go SDK but the root cause seems to be in the expansion service. When performing an xlang BigQueryIO read from a query, the Beam rows it outputs end up being structurally identical to the registered output type in Go, but not actually equivalent, so it can't be converted to the named struct output despite being structurally identical.
Workaround in Go SDK
To workaround this issue in the short term, turn the named struct type that's being used as the output to a type alias of the unnamed type. This can easily be done by inserting an = sign.
Before: type OutputRow struct {...}
After: type OutputRow = struct {...}
Note that this doesn't play well with Beam Go's type registration, you'll need to avoid registering the type alias.
Log Snippets
Here's a snippet of the error on the Go side to see how it manifests:
panic: interface conversion: interface {} is struct { Counter *int64 "beam:\"counter\""; Rand_data *struct { Flip *bool "beam:\"flip\""; Num *int64 "beam:\"num\""; Word *string "beam:\"word\"" } "beam:\"rand_data\"" }, not bigquery.TestRowPtrs
Full error:
while executing Process for Plan[s02-67]:
2: DataSink[S[ptransform-65@localhost:12371]] Coder:W;coder-80<LP;coder-81<R[bigquery.TestRow]>>!GWC
3: PCollection[pcollection-72] Out:[2]
4: ParDo[bigquery.castFn] Out:[2]
1: DataSource[S[ptransform-64@localhost:12371], 0] Coder:W;coder-76<LP;coder-77<R[struct { Counter *int64 "beam:\"counter\""; Rand_data *struct { Flip *bool "beam:\"flip\""; Num *int64 "beam:\"num\""; Word *string "beam:\"word\"" } "beam:\"rand_data\"" }]>>!GWC Out:4
	caused by:
panic: interface conversion: interface {} is struct { Counter *int64 "beam:\"counter\""; Rand_data *struct { Flip *bool "beam:\"flip\""; Num *int64 "beam:\"num\""; Word *string "beam:\"word\"" } "beam:\"rand_data\"" }, not bigquery.TestRowPtrs goroutine 58 [running]:
runtime/debug.Stack()
	/usr/lib/google-golang/src/runtime/debug/stack.go:24 +0x65
github.com/apache/beam/sdks/v2/go/pkg/beam/core/runtime/exec.callNoPanic.func1()
	{...}/repos/beam/sdks/go/pkg/beam/core/runtime/exec/util.go:58 +0xa5
panic({0xe0d380, 0xc0003a04e0})
	/usr/lib/google-golang/src/runtime/panic.go:866 +0x212
github.com/apache/beam/sdks/v2/go/pkg/beam/register.(*caller1x1[...]).Call1x1(...)
	{...}/repos/beam/sdks/go/pkg/beam/register/register.go:3205

And a snippet of the raw schema protos that are received by the Go SDK, compared with the schema it's expecting.
Received schema:
Schema proto: fields: {
  name: "counter"
  type: {
    nullable: true
    atomic_type: INT64
  }
}
fields: {
  name: "rand_data"
  type: {
    nullable: true
    row_type: {
      schema: {
        fields: {
          name: "flip"
          type: {
            nullable: true
            atomic_type: BOOLEAN
          }
        }
        fields: {
          name: "num"
          type: {
            nullable: true
            atomic_type: INT64
          }
          id: 1
          encoding_position: 1
        }
        fields: {
          name: "word"
          type: {
            nullable: true
            atomic_type: STRING
          }
          id: 2
          encoding_position: 2
        }
        id: "141b0073-d725-456c-bcdc-46c9c84e7a6d"
      }
    }
  }
  id: 1
  encoding_position: 1
}
id: "d520c5bd-86f8-4a7b-8cbd-af6816f09f61"

Expected schema:
Schema proto: fields: {
  name: "counter"
  type: {
    nullable: true
    atomic_type: INT64
  }
}
fields: {
  name: "rand_data"
  type: {
    nullable: true
    row_type: {
      schema: {
        fields: {
          name: "flip"
          type: {
            nullable: true
            atomic_type: BOOLEAN
          }
        }
        fields: {
          name: "num"
          type: {
            nullable: true
            atomic_type: INT64
          }
        }
        fields: {
          name: "word"
          type: {
            nullable: true
            atomic_type: STRING
          }
        }
        id: "c39b4c69-1e23-4267-9fb2-776e1a61a34f"
      }
    }
  }
}
id: "952f2fc2-afb0-4646-aaec-88b9a0f307be"

To see the data above, simply add the following lines after graphx/coder.go:371:
sp := prototext.Format(&s)
log.Warnf(context.Background(), "Schema proto: %v", sp)
log.Warnf(context.Background(), "Schema type: %v", t)
return coder.NewR(typex.New(t)), nil

Issue Priority
Priority: 2
Issue Component
Component: cross-language

Hey @youngoli :)
Do you happen to have a working example with the workaround?
I am not quite sure how to make it work with the aliasing.
Best regards!

Well, the example here exists, but it doesn't have aliasing.
The aliasing work around is demonstrated here, in the integration tests:
https://github.com/apache/beam/blob/ffa46b330fb62d49baa3c7afc9c9cd89384ad774/sdks/go/test/integration/io/xlang/bigquery/bigquery_test.go#L153

authors: capthiron lostluck youngoli

repo: apache/beam


text:
Use more informative assertions in some py tests

This just replaces assertions with equivalent ones that can give a better error message.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---

---
---

Java

Python

---

---
---

XLang
---
---
---

---
---
---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

Ping! (this is an easy one)

Is this waiting on a review from @robertwb or can it be merged?

I think I was delaying because Python seems very unhealthy on master, just as a matter of discipline. This does seem unlikely to break anything...

authors: TheNeuralBit kennknowles


text:
[BEAM-10471] Change assertion method to improve expressiveness and increase error margin on non deterministic size test in CassandraIO to avoid flakiness

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)

Lang
SDK
Dataflow
Flink
Samza
Spark
Twister2

Go

---

---

---

Java

Python

---

---

XLang

---

---

---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website

Non-portable

Portable
---

---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

Flake that looks like a real problem in JdbcIO: https://issues.apache.org/jira/browse/BEAM-10513

Run Java PreCommit

Thanks Kenn, merging. Indeed, there are a lot of flakes lately that seem due to load: I see Elasticsearch and Cassandra having timeouts

authors: echauchot kennknowles


text:
[BEAM-10937] Add first introductory notebook

This is the first notebook of a new "Tour of Beam" section we want to create to help improve the onboarding experience for beginners.
The plan is to have the "Tour of Beam" section to include links to all the notebooks we currently have, as well as to offer a new set of introductory notebooks to explain concepts gradually in an interactive environment. The landing page will come up as following PR.
This notebook covers the following:

Basic concepts: pipeline, PCollection, PTransform
Explanation of the | and >> operators
Basic transforms: Map, FlatMap, Filter, Combine, GroupByKey

The "What's next?" section at the end of the notebook contains links to existing documentation, but will be updated once we have more notebooks for new topics.
R: @aaltay
R: @rosetn
Staged: https://colab.sandbox.google.com/github/apache/beam/blob/b321ab285d7034b2e1b3ab0cb5d4b5d786640a39/examples/notebooks/tour-of-beam/getting-started.ipynb

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)

Lang
SDK
Dataflow
Flink
Samza
Spark
Twister2

Go

---

---

---

Java

Python

---

---

XLang

---

---

---

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website
Whitespace
Typescript

Non-portable

Portable
---

---
---
---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

@rosetn could you make the first review pass?

/cc @KevinGG

Where were we planning on hosting this? On the main landing page https://beam.apache.org/ or Documentation landing page https://beam.apache.org/documentation/ ?

I was thinking on the "Get Started" section, and probably replace the "Try Beam" button in the main landing page with the "Tour of Beam" page once it's done. The "Try Beam" notebook would also be referenced in the "Tour of Beam". What do you think?

SGTM. I'm in favor of placements that lets users know where they can find all of the interactive notebooks at try them out. Querying "apache beam notebooks" on the Google search engine or DuckDuckGo, the Try Beam page is in the top 10 results for me:  https://beam.apache.org/get-started/try-apache-beam/

I've updated the link to the staged version to the latest commit

@aaltay I'm done with my review

Could you update the staged version after your next commit?

Just updated it, forgot to update it yesterday.

I forgot to note this--can you add alt text to these images?

@aaltay -- comments addressed, and staged link updated. This should be ready for review

authors: aaltay davidcavazos rosetn


text:
[BEAM-12949] Fix DatastoreIO template compatibility

Switches hintNumWorkers to a ValueProvider in order to make this configurable from existing classic Dataflow templates.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunner compliance status (on master branch)

Lang
ULR
Dataflow
Flink
Samza
Spark
Twister2

Go
---

---

Java

Python
---

---

XLang

---

Examples testing status on various runners

Lang
ULR
Dataflow
Flink
Samza
Spark
Twister2

Go
---
---
---
---
---
---
---

Java
---

---
---
---
---
---

Python
---
---
---
---
---
---
---

XLang
---
---
---
---
---
---
---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go
Java
Python

Pre-Commit Tests Status (on master branch)

---
Java
Python
Go
Website
Whitespace
Typescript

Non-portable

Portable
---

---
---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @tvalentyn

Sorry, I found another incompatibility I need to fix. I will ping here again when the PR is ready.

PR is now ready for review.

R: @udim

@tvalentyn
Throttling on our Dataflow templates is currently broken, so I'd like to get this fix in before 2.34.0 is cut. Please take a look.

R: @pabloem

LGTM. I don't know if we have a postcommit test for this connector... I'll run Java postcommit in any case and merge after getting a passing run. FWIW, I think we should add an integration test if we don't have it.

Run Java PostCommit

Thanks! These are both good features to have

Thank you!
There are a few integration tests for reads & writes, admittedly they're pretty basic so they don't scaling behavior or things like that.

authors: danthev pabloem