text:
Webpack error with dynamic requires

I'm trying to integrate this npm package with my Node + React.js + Webpack app.
When I try to import the package in React with import OSTSDK from '@ostdotcom/ost-sdk-js, I get the error Error: Cannot find module ".".
This error is caused by Webpack not supporting dynamic requires, as stated in their documentation https://webpack.js.org/guides/dependency-management/#require-with-expression. So an expression like serviceV0ManifestKlass    = require(rootPrefix + '/services/v0/manifest') in the index.js file causes an error with Webpack, because it does not allow any dynamic variables (in this case rootPrefix) in the require function.
Another example of this issue can be seen here: https://github.com/webpack/webpack/issues/5680.
Would be amazing if this issue could be fixed soon, so we can use the package with a Webpack configuration :)

Hi @vliegenthart ,
Thanks for reporting the issue.
We had considered making the SDK work on browser in the past.
But, we always ended-up coming to a conclusion that prevented us from proceeding further.
The Conclusion:
If you are using sdk from client-side (browser), you are exposing your API key and secret.
Having said that, we would like to understand more about your needs.

Thanks for your response. I completely understand your reasoning about server-side vs client-side.
I was just experimenting with some testing setups, so it was more an issue out of interest why it does not work with client-side. By now I have integrated the OST SDK JS in my Express API server, so there is no need for any fixes from my side. Thank you :)

Closing the issue as consensus has been reached.

authors: rachinkapoor vliegenthart

repo: OpenSTFoundation/ost-sdk-js


text:
Performances in two tables in README are different?

Table1:

Table2:

And in table2, NL+BBOX performance is lower than BBOX, what's the discovery?

Table 1 shows the performance reported in the paper. Table 2 shows the performance of the released checkpoint.
We use mixed modal data (NL, BBOX, NL+BBOX) to train the model. Empirically, the more NL+BBOX samples, the better NL+BBOX tracking performance. Thus, NL+BBOX reference does not absolutely perform better than BBOX reference for our tracker. In our paper, we adopt a relatively balanced sample proportion to achieve good performance across different modal references.

So no checkpoint  corresponding to performance in the paper release?
I think the community prefers the consistent checkpoint to plot figures in their future research.

Thank you for your attention and advice. The raw results are consistent with the paper, which provides the reference of our tracker for their future research. But, the original checkpoints were broken during migration, so we retrain our model and release the last checkpoint.

No wonder. Thank you and your nice work.

source: gharchive/issue

repo: OpenSpaceAI/UVLTrack

license: MIT

license_type: permissive

license_source: github-api


text:
Fix DaVinci Resolve compatibility and export NetworkLocators

Fixes https://github.com/AcademySoftwareFoundation/OpenTimelineIO/issues/766
DaVinci Resolve requires top level composition mobs to have a primary timecode track.
This is inline with the AAF Edit  Protocol

6.3 Top-level Composition
...
A top-level composition shall contain one or more timecode tracks and include a Primary timecode track.
Timecode tracks shall use the MobSlot::PhysicalTrackNumber property to distinguish their type

This pull request also adds exporting of media references as NetworkLocators, which helps resolve find the media.
There are still lots of caveats to getting Resolve to link to media and further testing is required.
Linking image sequences works, the URL needs to be the first frame or this f"[{first_frame:05d}-{last_frame:05d}]" syntax.
https://github.com/AcademySoftwareFoundation/OpenTimelineIO/wiki/Editorial-File-Format-Notes#aaf
The image sequence needs to be strictly named and numbered, and I believe EXRS need to have embed timecode to work.

Codecov Report
Base: 90.15% // Head: 90.59% // Increases project coverage by +0.44% :tada:

Coverage data is based on head (86b163b) compared to base (c432f29).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   90.15%   90.59%   +0.44%
==========================================
  Files           3        3
  Lines        1107     1159      +52
==========================================
+ Hits          998     1050      +52
  Misses        109      109

Flag
Coverage Δ

unittests
90.59% <100.00%> (+0.44%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...tio_aaf_adapter/adapters/aaf_adapter/aaf_writer.py
97.58% <100.00%> (+0.27%)
:arrow_up:

..._aaf_adapter/adapters/advanced_authoring_format.py
86.03% <100.00%> (+0.10%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

It looks like this fixes OTIO raising an exception when trying to generate an .aaf with ImageSequenceReferences?
This is something I'd love to see working!

@timlehr if you have some time could you take a look at this? I've been using it for a long time. It would be nice to get it finally merged.

@markreidvfx I had a look and while I didn't test it myself, the code looks good to me. I don't seem to have the permission to approve this however.

source: gharchive/pull-request

authors: austinwitherspoon codecov-commenter markreidvfx timlehr

repo: OpenTimelineIO/otio-aaf-adapter


text:
ENinit function

The function works well for me.
I suggest to change the input parameters names to more readable ones. Maybe UnitsType  instead of ff and HeadlossFormula instead of hf.
Also enumeration of the available headloss formulas is needed: EN_HW, EN_DW and EN_CM.
I'll take care of it.

Some functions in ENinit are normally called after the network has been loaded:
  adjustdata();
  initunits();
  inittanks();
  convertunits();

Need to think how to handle these calls.

@eladsal can you say more about what needs to be handled?

Haven't looked on all of the code there yet which relates to elements which are not loaded yet but for example in inittanks there are calculations min. max. and init. volumes for tanks with a volume curve.
Do we have a way to update a curve for a tank at the moment?
I'll scan the function to see what else is there.

ENinit is not working for me on matlab. I try this

[e,f2,f3]=calllib('epanet2','ENinit','test.txt','test.bin', 0, 0)

authors: Mariosmsk eladsal samhatchett

repo: OpenWaterAnalytics/EPANET


text:
Finetune production exception handling

Exceptions for mismatched versions are reported (they should not be).
Exceptions for database errors (missing column for example) are not reported but return a HTTP 500.
Exceptions for connection errors (redis, postgres) are not reported but return a HTTP 500.

Closed by deprecating exception_notifications in favour of Bugsnag.

repo: OpenWebslides/openwebslides-backend


text:
Switchbot Bot issuing two clicks when activated via Home App

Describe Your Problem
Switchbot Bot issuing two clicks when activated via Home App.  For coffeemaker it is essentially turning on and then immediately turning off the coffeemaker.
Relevant log output
[12/22/2022, 7:20:31 AM] [SwitchBot] Bot: Coffee maker Set On: true
[12/22/2022, 7:20:34 AM] [SwitchBot] Bot: Coffee maker Set On: true

Config for homebridge-switchbot
No response
Screenshots
No response
Device & Model
SwitchBot Bot
Node.js Version
v18.12.1
NPM Version
no idea
Homebridge Version
v1.6.0
Homebridge SwitchBot Plugin Version
v2.3.2
Homebridge Config UI X Plugin Version
No response
Operating System
MacOS13.1

Does this happen when it is invoked from Homebridge? Subsequent requests should be ignored when they are issued that close together. Also odd that there was no intermediary false state (unless that was cut out).

Can you try the latest beta:

Click here to find out how to install Beta

Hi, it appears that this has been resolved with the new version!

authors: alvst donavanbecker macguyincali

repo: OpenWonderLabs/homebridge-switchbot

license: ISC


text:
Improve Mixins design to address intersections

Currently, we have some functions repeated among mixins (ex: supports_interface) that don't allow us to use them in the same preset (ERC721 with AccessControl for example).
We should design how to address these cases in Wizard and the library.

Remember @arielelp mentioned this was intended to be addressed in Cairo's upcoming component design, I believe something around prefixing the component's name to functions, as with un/flattened storage structs but I can't recall exactly.

authors: ericnordelo martriay

repo: OpenZeppelin/cairo-contracts


text:
Add "equals" method to SafeMath

🎉 Description
Add "equals" to SafeMath. Currently mul / div / sub / add create a clean syntax. It would be nice to have an "equals" operation that could be added to require statements and return values.

[x] 📈 This is a feature request.

📝 Details
In detail this could be used for example like this inside methods:
require(x.equals(0));
return x.equals(0);

@rbval:
Maybe you got the inspiration for that from off-chain code that you have (e.g., Javascript assert module, which is often used in Truffle tests, etc).
In the on-chain side, such functionality is absolutely worthless.
The functions in SafeMath are wrappers for the Solidity language arithmetic operators, allowing the user to execute them "safely".
A wrapper for the Boolean operator == will not provide any additional functionality here, nor will it make the code look "cleaner" (if that's what you had in mind).

I think you are both right. One more poke: in the sub method there’s a requirement the first number to be greater than the second one. I believe this is due to not getting output of a negative number. Could that be applied here where we could demand both numbers to be greater than zero ( > 0 ) before comparing them as two integer overflowed numbers can be equal? I think the compiler throws warnings but it could be a good safe method? @nventuro @barakman

authors: barakman rbval

repo: OpenZeppelin/openzeppelin-solidity


text:
Blight+Spreading Rot+Spell Totem not working

If I set 2 Spreading Rot(jewel) and activate spell totem with Blight my poison damage not increased, but enemy should receive 50% increased chaos dmg.

Forget set checkbox Hindered Enemy

repo: Openarl/PathOfBuilding

license: mit

license_source: bigquery


text:
bug: Infrequent systematic issues with pause and run clock features

Overview
There are three different events that seem to be happening with different OT-2s.

Event 1 Moved to a separate issue: #7216
Event 2 Moved to a separate issue: #7272
Event 3 Moved to a separate issue: #7273

Steps to reproduce
I have not tried to reproduce the issue yet.

Closing this in favor of several smaller tickets.

Closing this in favor of several smaller tickets.

authors: SyntaxColoring ethanfjones

repo: Opentrons/opentrons


text:
style(app): phase II app styling revisions

Phase II app styling revisions
PR will fix #10488

[x] (1) Missing the enabled state (no fill background), and needs a hover state linked up.
[x] (2) Remove the white fill from the button
[x] (3) When I press on the button, i get the orange outline. The orange outline is only the focus state and should only appear when a user tabs through all the links using 'tab' on their keyboard. So remove this please! (Already Done)
[x] (4) update 'sort by' text to our darkGreyEnabled
[x] (5) Looks like we're missing the hover state for the protocol cards. Check the design system for info
[x] (7) Update this text across all cards to our darkGreyEnabled
[x] (8) The columns should have a min-width of 170px so regardless of what content is in them, the columns will always align. These columns should be responsive when the user shrinks the viewport.
[x] (9) Update both of these so it's our label text in darkGreyEnabled. No uppercase here
[x] (10) Update text should align to the bottom of the other containers to the left.
[x] (11) Update to be our p-semibold, currently it's bold
[x] (12) Update to our label-semibold styling.
[x] (13) Double check the colour of the text and the icon. They should be the same
[x] (14) Update the spacing here between header and text below to .25 rem

Changelog

The following list above has been completed.
Styling of icons has been modified
Styling of text colors
Icon behaviors has been revised

Review requests
Low

Risk assessment
Low

Round 3, T1 Protocols Page
Link to annotated frame in Figma

[ ] (1) Button needs some attention. Currently barely visible and the states need updating. *
[ ] (2) Still missing the enabled state *
[ ] (3) Still need to update 'sort by' text to our darkGreyEnabled *
[ ] (4) Still missing missing the hover state for the protocol cards. Check the design system for info *
[ ] (5) Revert the colour of the subtext to our darkGreyEnabled, only the headline should be #707075
[ ] (6) Still need to update the spacing here between header and text below to .25 rem *
[ ] (7) Update the colour of this text to what the design has
[ ] (8) Still needs: The columns should have a min-width of 170px so regardless of what content is in them, the columns will always align. These columns should be responsive when the user shrinks the viewport. Maybe align with @koji on this since he's been working on the device cards on the T1 Devices page which should follow the same pattern. *
[ ] (9) Still needs: Update text should align to the bottom of the other containers to the left. *
[ ] (10) open menu should be placed 4px below the menu icon, placing a screenshot of what it should look like here
[ ] (11) Update these links to the colour in our designs
[ ] (12) Missing space above the open sort by menu
[ ] (13) Move updated column further to the right, it should have 1rem of spacing with the right hand side of its container and the card container
[ ] (14) Update the colour in this text on loading state
[ ] (15) Can you let me know what's happening with the skeleton loader?

I also want to note that 7 of the tasks have been marked with a *. These are tasks that were marked completed but when I check the branch, I cannot see the change. Can you let me know what's going on there?

Round 2 feedback on the empty state of the T1 Protocols page. First round can be found on #10208
Annotated Figma frame link

[ ] (1) Update this text to our h1 style
[ ] (2) Add in margin between h1 and p copy
[ ] (3) Can you add in our hover state for our blue links for the word "browse"?
[ ] (4) I'm assuming fixing these links for the main page would fix these here too
[ ] (5) Center this entire section to the middle of the page (see purple rectangle)


text:
NO_OP installer has references to logger_logs table

From @sChintamani on September 23, 2014 21:26
Hi,
The no_op installer has anchored references to logger_logs table.  This I found the hard way, once the script went to deployment into near PROD env.
We installed the regular version in DEV & QA environments and no_op version was required on the PROD env.  When we ran the no_op version without un-installing the previous logger, the builds went fine and we didn't realize this anchoring until we hit PROD.  I just now came back from this deployment (it's 3:00 AM in the morning :( !)..  Please see the attached screen-shot for details.
Would be nice to have an updated script checked in into git-hub.  I 'll be more than happy to contribute the updated version, we came up with.

Copied from original issue: tmuth/Logger---A-PL-SQL-Logging-Utility#77

There were several approaches we could have taken on this issue. The main two were as follows:

Create record types for all the object types and put in logger.pks. Developers would then need to reference these record types instead of the object types (ex: logger_logs.scope%type).
Create all the objects in the NO_OP script.

Decided to go with the second option. The NO_OP script will now install all the objects so if any of your code references it, queries from the views, etc it will still compile (though no data is stored).

repo: OraOpenSource/Logger


text:
Install aborts when zip file name has parenthesis "(" in it.

When installing, I used a downloaded ZIP file from Oracle that had a (1) in the file name and the install failed. No errors were given, it just aborted. The file that caused the error is shown below. I renamed the file and removed the (1) and the install completed successfully.
#Assuming the file is placed in the /tmp folder on the machine
OOS_ORACLE_FILE_URL=file:///tmp/ords.3.0.9.348.07.16(1).zip

jani@mba:~$ foo=foo.zip
jani@mba:~$ foo=foo(1).zip
-bash: syntax error near unexpected token `('
jani@mba:~$ foo="foo(1).zip"
jani@mba:~$

Add the quotes to the examples in README and config.properties "template"-file ?
OOS_ORACLE_FILE_URL="CHANGEME"

repo: OraOpenSource/OXAR


text:
Bug report: Could not recognize letter 'r'

I report a strange bug here...
When there exists a letter r in the expression except for \right, the calculator could not evaluate it, like (➡ means after pressing Ctrl + Shift + Alt + E)

a*a ➡ a*a=a^{2}
r*r ➡ Message "I expected something else here r*r ^"
\left(a\right)*a ➡ \left(a\right)*a=a^{2}
\int_0^{+\infty}e^{-x}dx ➡ \int_0^{+\infty}e^{-x}dx=1
\int_0^{+\infty}e^{-r}dr ➡ Message "I expected something else here \int_0^{+\infty}e^{-r}dr ~~~~~~~~~~~~~~~~~~~~^"
\int_0^r e^{-x}dx ➡ Message "I expected something else here \int_0^re^{-x}dx ~~~~~~~^"
\int_0^a e^{-x}dx ➡ \int_0^a e^{-x}dx=1 - e^{- a}

Anyway, this extension is amazing! Yet please help to fix this bug, thanks a lot!

It is a bug and I found it some months ago. But I can't figure it out after several times of tries.
You can substitute it with other letters like \rho.
I am sorry about it :-(

Yeah, I know there might well be an unexpected 'r'... Yet let's think about it from another way.
When couldn't 'r' be replaced? Only when 'r' is used in a LaTeX command. What is special about commands? They all start with a backslash, and except for several symbols like \#, \, etc., they are all composed of alphabets and numbers (Click here to see all common commands in LaTeX). So why couldn't we write the replace algorithm like this?
# Updated by Na2CuCl4
def latex2latex(tex):
    # All supported Greek alphabets
    replacement = [ r'\alpha', r'\beta', r'\gamma', r'\delta', r'\epsilon', r'\varepsilon', r'\zeta', r'\eta', r'\theta', r'\vartheta', r'\iota', r'\kappa', r'\lambda', r'\mu', r'\nu', r'\xi', r'\pi', r'\varpi', r'\rho', r'\varrho', r'\sigma', r'\varsigma', r'\tau', r'\upsilon', r'\phi', r'\varphi', r'\chi', r'\psi', r'\omega', r'\Gamma', r'\Delta', r'\Theta', r'\Lambda', r'\Xi', r'\Pi', r'\Sigma', r'\Upsilon', r'\Phi', r'\Psi', r'\Omega' ]

    # Replace r with another symbol
    replaced = ""
    newTex = ""
    for expr in replacement:
        if tex.find(expr) == -1:
            replaced = expr
            TexCmd = False # If it is a LaTeX command
            for ch in tex:
                if ch == '\\':
                    if TexCmd: TexCmd = False # Line break
                    else: TexCmd = True # New command
                    newTex += ch
                elif ch.isalnum() and TexCmd: # Still a command
                    newTex += ch
                else: # Not a command
                    TexCmd = False
                    if ch == 'r': # Replace
                        newTex += replaced + ' '
                    else:
                        newTex += ch
            break

    # Evaluation
    newTex = sympy.latex(simplify(latex2sympy(newTex).subs(variances).doit().doit())).replace(r'\left[\begin{matrix}', r'\begin{bmatrix}', -1).replace(r'\end{matrix}\right]', r'\end{bmatrix}', -1)

    # Modify the result
    if replaced == "":
        return newTex
    else:
        return newTex.replace(replaced, 'r', -1)

This will not involve any unexpected 'r'. Hope it might help!


text:
Commands to add for OI Wiki test

Scanned by script

[x] \notag
[x] \brack
[x] \triangle
[x] \impliedby
[ ] \LaTeX
[x] \space
[x] \lnot
[x] \mathop
[x] \vert
[x] \middle
[x] \lvert
[x] \rvert
[x] \lVert
[x] \Bbb
[x] \implies
[x] \boxed
[x] \checkmark
[x] \substack
[x] \dotsb
[x] \dbinom
[x] \*
[ ] \wedge
[ ] \subsetneqq
[x] \emptyset
[ ] \pod
[x] \lor
[ ] \cr
[x] \tag
[ ] \varphi*
[x] \brace
[x] \begin{alignedat}

https://katex.org/docs/support_table There is also a support table in katex. Hope that helps

https://katex.org/docs/support_table There is also a support table in katex. Hope that helps

We have been aware of that, but there are too many commands and feel boring on binding them all. We may only bind some commonly used commands and oiwiki used commands in first release. @OrangeX4
All rest commands will be added in later versions.

Yes, I see there are a lot of weird things on that page. 🤣

\varphi* is fixed by #31

authors: Enter-tainer Myriad-Dreamin


text:
Fixes #5879: Layout part OnIndexing fails when called in a background task

Fixes #5879
And maybe other issues, when the GetContext(httpContext) method, the one that has an HttpContextBase parameter, is called in the context of a BackgroundTask.

Same kind of issue in DefaultCacheStorageProvider.cs
When a content item is published it is removed from the httpcontext cache. But, through the Publish Later command, this is done in the context of a backgroud task...

repo: OrchardCMS/Orchard


text:
Error indexing

I found an error that occurs when the background task tries to index a content.
In Lucene\LuceneIndexProvider.cs, method CreateLuceneDocument
case DocumentIndex.Types.DateTime:
When the PublishedUtc property is added, there is an error because entry.Value.Value is null.
A simple fix would be to check if entry.Value.Value != null.

As it is in a background task, I had to be in debug to watch the Exception appear and as I am running on IISExpress, there is no console open.
We should enable Debug console logging and File logging in app_data\sites{tenant}\logs for this kind of problem. See #458

Reminder : Indexing still need to be fixed.

Fixed in https://github.com/OrchardCMS/Orchard2/commit/90df48f851f44766f868ea9e05ed29598953a2c7

authors: agriffard sebastienros


text:
Smart contract architecture for listings

Current thinking is a master listing registry, individual contracts for each listing, then child contracts for booking instances

Same here.
Saw that this is marked as Done in the project tracker but not Closed. Can someone update on status?

We currently have solidity contracts in place for ListingRegistry, Listing, and Purchase. @wanderingstan can probably give a more comprehensive update. But I'll mention there has been some discussion in this related issue (contract mutability vs. immutability):
https://github.com/OriginProtocol/platform/issues/19

I think we've got our Listing/Purchase contract architecture in place for now. We may modify some of the internals when we add edit functionality, but for now, we are good.

authors: DanielVF matthewliu tyleryasaka

repo: OriginProtocol/platform


text:
License of Oryx code and data

Thanks for releasing this great code! Can you please add a license to the Oryx code and data? It will guide us how to use them.

Hi, we follow the open-source MIT license for Oryx code. Our data is collected from open-sourced academic datasets, you can follow the instructions of the source for usage.

Thank you!

repo: Oryx-mllm/Oryx


text:
[BUG] WINDOWS install not finding gpt-4-with-ocr

Hi,
Update:
I created a new key and receiving an other error:
[Self-Operating Computer][gpt-4-with-ocr] That did not work. Trying another method
[Self-Operating Computer][Operate] That did not work. Trying again  Error code: 404 - {'error': {'message': 'The model `gpt-4-vision-preview` does not exist or you do not have access to it. Learn more: https://help.openai.com/en/articles/7102672-how-can-i-access-gpt-4.', 'type': 'invalid_request_error', 'param': None, 'code': 'model_not_found'}}
[Self-Operating Computer][Error] -> cannot access local variable 'content' where it is not associated with a value

Previous:
I get this error:
[Self-Operating Computer][gpt-4-with-ocr] That did not work. Trying another method
[Self-Operating Computer][Operate] That did not work. Trying again  Error code: 401 - {'error': {'message': 'Incorrect API key provided: sk-dT0tN***************************************3YFi. You can find your API key at https://platform.openai.com/account/api-keys.', 'type': 'invalid_request_error', 'param': None, 'code': 'invalid_api_key'}}
[Self-Operating Computer][Error] -> cannot access local variable 'content' where it is not associated with a value

I have chatgpt4, the key is correct and has access set to all.
What could be the reason?

Kr,
Peter

I tried the latest on another computer, but I'm getting the same message.

@peterthrees Have you spent at least $5 on API credits? See the bottom of the README for more info. People typically get that error when they haven't yet spent the required $5 to gain access to GPT-4 Vision.

@michaelhhogue  Thanks, that was indeed the issue.
Maybe it is explained somewhere in this git rpo and I have missed it? But I thought the Api key and subscription was sufficient.
If the feedback is from chatgpt, they should maybe provide feedback with the correct error like, "not enough credits".

It works now, but a subscription to chatgpt4 is not enough.
You also NEED to buy credits from chatgpt4, i bought credits for 5$ to test it because every api call will cost you something.
It's not cheap if you want to use it a lot. I tried a few test and I'm alsmost at 1$.
I hope there will be some alternatives later that are much cheaper or open source to do this.
Also it can't work with MS dos navigation. It does some weard things like cd c/\git\pong\ for example

What do you mean paid for credits? I currently have 21.95 in credit in my API account... does that count? I'm having the same error meesage on both computers I've attempted installation on:
[Self-Operating Computer | gpt-4-with-ocr]
Hello, I can help you with anything. What would you like done?
[User]
test
[Self-Operating Computer][gpt-4-with-ocr] That did not work. Trying another method
[Self-Operating Computer][Operate] That did not work. Trying again  Error code: 404 - {'error': {'message': 'The model `gpt-4-vision-preview` has been deprecated, learn more here: https://platform.openai.com/docs/deprecations', 'type': 'invalid_request_error', 'param': None, 'code': 'model_not_found'}}
[Self-Operating Computer][Error] -> local variable 'content' referenced before assignment

C:\Users\eddie\Ai Tools>

repo: OthersideAI/self-operating-computer


text:
feat: update localizable

Related Issue

#546 #545 #552 #554 #570 #544 #540
Summary of Changes

Need Regression Testing

[x] Yes
[ ] No

Risk Assessment

[ ] Low
[x] Medium
[ ] High

Additional Notes

Screenshots (if applicable)

I can't find the changes related to #540. Are these already implemented, just missing the language translations?

yes, Let me go to crowdin and check it out.

repo: Outblock/FRW-iOS


text:
Only first task in sequence runs

Note: we first noticed this issue after upgrading to node 4.4.4. Unsure whether or not that's related.
gulpfile.js:
var gulp = require('gulp');
var sequence = require('run-sequence');

gulp.task('foo', function (cb) {
    console.log('foo');
});
gulp.task('bar', function (cb) {
    console.log('bar');
});

gulp.task('default', function (cb) {
    sequence('foo', 'bar', cb);
});

package.json:
{
  "name": "bug-test",
  "version": "1.0.0",
  "engines": {
    "node": "4.4.4"
  },
  "devDependencies": {
    "gulp": "^3.9.0",
    "run-sequence": "^1.2"
  }
}

gulp output:
 ~/dev/run-sequence-bug# gulp
[18:00:19] Using gulpfile ~/dev/run-sequence-bug/gulpfile.js
[18:00:19] Starting 'default'...
[18:00:19] Starting 'foo'...
foo
 ~/dev/run-sequence-bug# echo $?
0

Your tasks aren't finishing, they aren't configured correctly.  If you accept the callback in your task, you have to call it at some point.
Please read the Usage section.
I'm using run-sequence on Node 4, 5, and 6 without issue.

@OverZealous got it, thanks!

authors: OverZealous mfonda

repo: OverZealous/run-sequence


text:
Styling of links within bubbles

Hi!
I'm trying to apply CSS style to links within the chat window. Since it is rendered within #shadowroot it seems to be impossible just to apply the color globally.
Is there any way the pass the style for links (<a href=...) to DeepChat?
Example (app is in dark mode and I would like to make the links more readable):

Best regards

+1 on this, tried to nest the & a selector in some of the styling props and it didn't workout for me

We finally got it! Use AuxiliaryStyle for it!

auxiliaryStyle={"a:-webkit-any-link{ color: green; cursor: pointer;text-decoration: underline;}"}

authors: ki-zeitalter michaelleungbowtie

repo: OvidijusParsiunas/deep-chat


text:
修改默认登录密码和主题应该如何在diy.sh中实现？

通过您的脚本，我已经成功实现了自动编译。
DIY.SH里的修改默认ip也大致明白，应该就是替换语句对吧？
我还想编译时修改默认密码，比如lean的是默认是password。而他的config里面是
set network.$1.password='password'
如果我直接替换password这个单词肯定不行，请问如何来实现呢？
另外我还想默认修改主题，修改哪里呢？
谢谢

sed -i 's/'password'/'123456'/g' openwrt/package/base-files/files/bin/config_generate
这样能否实现？

sed -i 's/root::0:0:99999:7:::/root:$1$V4UetPzk$CYXluq4wUazHjmCDBCqXF.:0:0:99999:7:::/g' /etc/shadow

$1$V4UetPzk$CYXluq4wUazHjmCDBCqXF.
这些字符就是密码passwd，把这些字符修改成你密码的字符，如何转换，简单的就是把固件修改成你想要的密码，然后复制粘贴

#删除默认密码
sed -i "/CYXluq4wUazHjmCDBCqXF/d" package/lean/default-settings/files/zzz-default-settings

多谢 修改密码成功了
那么还有两个问题，修改默认主机名和主题在哪个路径文件？

我找到了修改主题的文件，应该是/etc/config/luci，请问我要修改成argon主题改如何配置diy.sh

在diy.sh里面我试了几次都不行，最后在配置文件里实现的。
添加你需要的主题包估计你会。
下面这行代码可以取消默认主题：
sed -i '/set luci.main.mediaurlbase=\/luci-static\/bootstrap/d' feeds/luci/themes/luci-theme-bootstrap/root/etc/uci-defaults/30_luci-theme-bootstrap
你把它添加到clone代码后面运行。

我只加个一个主题，和默认的加起来是两个，取消掉默认主题来达到我想要的主题的效果

把默认bootstrap主题改成material：
sed -i 's/luci-theme-bootstrap/luci-theme-material/g' ./feeds/luci/collections/luci/Makefile

P大有没有兴趣再写一个单独编译插件的模版。有时候编译固件就为添加或者升级一个插件，费时费力。

多谢 修改密码成功了
那么还有两个问题，修改默认主机名和主题在哪个路径文件？

请问而你用什么方法修改的？麻烦贴一下

请教各位大神，固件里边的版本号怎么自定义呀？虚拟机编译我知道是修改zzz-default-settings文件。但是Action里边，我在替换ip地址下边添加了一行sed命令，sed -i 's/R20.6.18/R202006/g' package/lean/default-settings/files/zzz-default-settings，替换版本号为R202006。一直通不过编译不出来呀？

authors: BtQiang DFOUD goukey grootsong lphgor lyin888 mzxwt yang12me


text:
Update network_discovery.sh

It appears that the ipinfo.io API query is returning null for the location of the IPs.
I will adjust the script to better handle these cases and ensure the output is clear even if the location is not available.

Okay, looks like it worked


text:
Lets change default for tree to FastTree with no refinement

I've done a small analysis on the time it takes for the trees to run, and I suggest that we reset the defaults for the phylogenetic tree so that users can get some returns in a reasonable time, with the ability for them to scale up if they desire.

I also think that we need to have a serious discussion about how many genomes users can compare at a time, or expanding the computational resources to handle tree building.  I started a series of trees with the same genomes and all possible parameters.  There were 22 ingroup genomes, and 5 outgroup genomes, and the ingroup genomes were all Escherichia.  When I run this tree at Va Tech, it might take 10 hours.  The first tree, with RaxML and progressive refinement as the options, has been running 20 hours now, but what concerns me is that it has tied up the queue, and two of the trees have are not even "in progress" after 20 hours.  If the service is popular, it could drag down other services.

I made the change on the submission GUI and submit a pull request. @hyoo

deployed

authors: ARWattam dawenx hyoo


text:
Error with VPS

Hello,
I have an VPS with Ubuntu 15.10 XFCE (64 bits) with servers, and I get this error:
http://pastebin.com/xHKfEDq9

Your jvm setup is probably incorrect -- something with the certificate store maybe? This is beyond our ability to help you however -- it's tied quite closely into your OS setup, not PEX.

repo: PEXPlugins/PermissionsEx


text:
Help fast

I created groups : coal , iron , gold etc .. i gave each one some permissions like fly.fly , when i check in console to see what commands each group has it shows them , but when i give myself one of the ranks no commands works and it says you do not have acces to that command . What is happening?pls help me fast

Permission nodes are directly related to the plugins which give those abilities.  The node fly.fly would have to be from a plugin of some sort in order for it to do anything on the server.  As far as I'm aware, fly.fly isn't from a plugin, so no users would be able to fly if you give that node to them.

authors: Stormbow kiraakkira


text:
提交的图片和Markdown文件的图片无法正常显示

如图，提交上来的图片无法正常显示

无论是png\jpg\jpeg，相对路径或同目录下，均无法解析

@wenjia03 您好，CodeFever 在设计的时候就不允许直接下载 二进制文件，因此在 md 中引用媒体文件可能不会正常显示。

repo: PGYER/codefever


text:
Support for generating time-lapse video?

Q
A

Bug?
no

New Feature?
no

Version Used
v1.2.0

FFmpeg Version
v6.1.1

OS
MacOS 14.2.1

It may be just not supported, but I'm trying to use PHP-FFMpeg to generate a time-lapse from a series of images. I have a working ffmpeg command to generate the timelapse, but I can't figure out how to map it into code:
ffmpeg -framerate 3 -pattern_type glob -i "image-*.jpeg" output.mp4
I've tried mapping this into a function which uses concat and an array of the image paths instead of the glob pattern, but it (somewhat expectedly) fails.
$snapshotPaths = [
    'image-1.jpeg',
    'image-2.jpeg',
    'image-3.jpeg',
    'image-4.jpeg',
    // ...
];

$ffmpeg = FFMpeg::create();
$video = $ffmpeg->open(array_shift($snapshotPaths));

$video
    ->concat($snapshotPaths)
    ->saveFromDifferentCodecs(new X264(), 'output.mp4');

So again, is this a supported use case that I'm just missing some configs like setting the frame rate?

Is there a good solution now? I want to implement it

repo: PHP-FFMpeg/PHP-FFMpeg


text:
authoriSation shoud be authoriZation

authoriSation should be authoriZation in response data

It is possible, that this code is part of your codebase? I can't find authorisation in this project.

I didn't find it too as well. I believe this is part of your codebase.

This is en-GB vs en-US, so both are correct (unless it differs from documentation) 😄

authors: Brainiac24 Messhias eschricker lcobucci

repo: PHP-Open-Source-Saver/jwt-auth


text:
LiDAR2IMU Data Representation/数据表示

2021-10-26-16-21-29-468 0.999999487 0.000000001 0.000000005 0.000000000 0.000000001 1.000000458 0.000000061 0.000000000 0.000000005 0.000000061 1.000000354 0.000000000
2021-10-26-16-21-29-568 0.999999487 -0.000016799 0.000011083 0.000086150 0.000016801 1.000000457 0.000002765 -0.000044056 -0.000011073 -0.000002643 1.000000354 -0.000057432
2021-10-26-16-21-29-668 0.999999486 -0.000030950 0.000017494 0.000149598 0.000030953 1.000000457 0.000001618 -0.000081122 -0.000017486 -0.000001495 1.000000353 -0.000108566
2021-10-26-16-21-29-768 0.999999487 -0.000026525 0.000013749 0.000168331 0.000026526 1.000000457 0.000020940 -0.000118806 -0.000013739 -0.000020816 1.000000353 -0.000121137
2021-10-26-16-21-29-868 0.999999486 -0.000027556 0.000027000 0.000221277 0.000027556 1.000000456 0.000025740 -0.000156440 -0.000026992 -0.000025616 1.000000353 -0.000150710
2021-10-26-16-21-29-969 0.999999487 -0.000036470 0.000023235 0.000234609 0.000036471 1.000000456 0.000028331 -0.000172442 -0.000023227 -0.000028207 1.000000353 -0.000132037
2021-10-26-16-21-30-069 0.999999485 0.000032281 0.000065063 0.000299835 -0.000032287 1.000000452 0.000103572 -0.000194594 -0.000065051 -0.000103451 1.000000347 -0.000212796
2021-10-26-16-21-30-169 0.999999485 0.000026849 0.000057538 0.000285176 -0.000026853 1.000000451 0.000105360 -0.000225432 -0.000057525 -0.000105238 1.000000347 -0.000268844
2021-10-26-16-21-30-269 0.999999484 0.000026782 0.000074307 0.000341075 -0.000026787 1.000000451 0.000105466 -0.000226351 -0.000074295 -0.000105345 1.000000345 -0.000327082
2021-10-26-16-21-30-369 0.999999485 0.000018866 0.000063211 0.000309279 -0.000018872 1.000000452 0.000107897 -0.000208814 -0.000063200 -0.000107775 1.000000346 -0.000348987
top_center_lidar_pose.txt
What does each data represent? and How are do one interchange between or collect data from
每个数据代表什么？如何在以下设备之间交换数据或从以下设备收集数据?
NovAtel-pose-lidar-time.txt
top_center_lidar-enu.txt
top_center_lidar-pose.txt
top_center_lidar-utm.txt
Why does manual_calib uses top_center_lidar-pose.txt but auto_calib uses NovAtel-pose-lidar-time.txt?
@friskit-china @YueDayu @yikang-li @BOBrown

can anyone tell what those 12 values represents and in which order?
My IMU sensor topic echo is in this format:
header:
stamp:
sec: 1710008269
nanosec: 882852351
frame_id: imu_link
orientation:
x: -0.006825877990883415
y: -0.002594882655552313
z: -0.7126842273063086
w: -0.7014469802647005
orientation_covariance:

0.00042593543332150943
0.0
0.0
0.0
0.00038638801831553105
0.0
0.0
0.0
0.13248230474005496
angular_velocity:
x: -0.004857184302894783
y: 0.008244611230212863
z: -0.0011483339340475234
angular_velocity_covariance:
0.0
0.0
0.0
0.0
0.0
0.0
0.0
0.0
0.0
linear_acceleration:
x: -0.03084136856920639
y: 0.03636305442003258
z: -0.04104681350873415
linear_acceleration_covariance:
0.0
0.0
0.0
0.0
0.0
0.0
0.0
0.0
0.0

can anyone tell what those 12 values represents and in which order? My IMU sensor topic echo is in this format: header: stamp: sec: 1710008269 nanosec: 882852351 frame_id: imu_link orientation: x: -0.006825877990883415 y: -0.002594882655552313 z: -0.7126842273063086 w: -0.7014469802647005 orientation_covariance:

0.00042593543332150943
0.0
0.0
0.0
0.00038638801831553105
0.0
0.0
0.0
0.13248230474005496
angular_velocity:
x: -0.004857184302894783
y: 0.008244611230212863
z: -0.0011483339340475234
angular_velocity_covariance:
0.0
0.0
0.0
0.0
0.0
0.0
0.0
0.0
0.0
linear_acceleration:
x: -0.03084136856920639
y: 0.03636305442003258
z: -0.04104681350873415
linear_acceleration_covariance:
0.0
0.0
0.0
0.0
0.0
0.0
0.0
0.0
0.0

我和你的IMU数据一样，你的问题解决了吗，如果你能看到，请＋q 525614957 一起交流一下

My IMU data is the same as yours. Has your problem been solved? If you can see it, please +q 525614957 to communicate with us.

I still didn't quite figure out what the heck are those values. I read somewhere in one of these issues where someone mentioned it's R1, R2, R3, T1, R4, R5, R6, T2, R7, R8, R9, T3. I wrote a script to prepare data https://buffalo.box.com/s/9dsmt6b0fp7m6g0qt9fckcc71r38zy97
in this format and still it doesn't work.
In paper they say our method only takes 19 seconds to calibrate but preparing the data for this package itself takes forever. LOL! So I have changed the package and now I am using ROS1 based LiDAR2IMU Calibration package which works great!
Here's the proof >> https://buffalo.box.com/s/vmlo1m046tshr5v13jp2v6ibfa6moxfb
I am still refining the parameters and it will get done. It takes 10-15 minutes (WARNING: CPU USAGE AT PEAK) to calibrate depending on how many 8 loops timestamps you are feeding into the algorithm.
The ROS1 bsed package & guide >>  https://autowarefoundation.github.io/autoware-documentation/release-v1.0_beta/how-to-guides/integrating-autoware/creating-vehicle-and-sensor-model/calibrating-sensors/lidar-imu-calibration/
NOTE: While using this ROS1 based package, forget about live visualizing calibration process errors. Let the package do it's job after you execute "roslaunch" command. In the end, you will get calibration results in txt, csv, and PCDs as well.
Good Luck :)

repo: PJLab-ADG/SensorsCalibration


text:
Blue Topaz 无法支持字体连字

在Blue Topaz主题下使用Cascadia Code连字失效，切换主题却能够使用

style settings中“字间距”改为0

authors: Xuyaoyan whyt-byte


text:
fix(mis): 修复导入用户有时指定拥有者不成功的bug

当前系统中, 如果账户数过多引起table组件分页, 并且用户在选择某个账户后切换到其它页面提交导入用户请求, 则会丢失拥有者信息, 导致新导入的账户没有拥有者
这是由于table组件不会渲染所有页面造成的, 当切换到其它页面的时候, 之前填写过的form项会丢失
现在修改了一下界面交互逻辑, 当用户选择的账户没有拥有者时, 用message提示

有一个新的问题，我试了好多次，不确定具体触发条件对不对，但是是稳定复现的，新提了个issue
https://github.com/orgs/PKUHPC/projects/1/views/30?pane=issue&itemId=26159313

有一个新的问题，我试了好多次，不确定具体触发条件对不对，但是是稳定复现的，新提了个issue https://github.com/orgs/PKUHPC/projects/1/views/30?pane=issue&itemId=26159313

网关超时问题，可忽略

authors: lyl-available qhqhqhq

repo: PKUHPC/SCOW


text:
🛑 MUSA is down

In 2d0fce7, MUSA (https://storemusa.com/) was down:

HTTP code: 403
Response time: 272 ms

Resolved: MUSA is back up in bdbcb4e after 21 minutes.

repo: POCLANOS/status


text:
refactor: Move Token next to Expr

Previously Token was in prqlc-parser, and Expr (one of them...) was in prqlc-ast. This means that we can't add a comments field containing a Token to Expr when working on the formatting.
I'm increasingly of the view that splitting out prqlc-ast may not have been the correct approach, particularly given the maturity of our library, and that a simpler approach would be to collapse some of these distinctions; particularly those which don't help split up the stages of the compiler.
(While this increases the size of prqlc-ast, it arguably reduces the split's significance, so I think a reasonable small step to the goal above, as well as solving an immediate issue...)

CC @m-span

It would be good to have docblock comments too.

Docblocks are unrelated to this change.

I think these changes are a good idea. I'm almost there - since my changes are a bit larger, I'd like to get mine in first

Just merged #4470 so this is unblocked

OK great, merging this too now.
And I'm increasingly of the view that we should move the parts of prqlc-ast that are consumed by prqlc-parser into prqlc-parser. Modularity is great but we should be emphasizing the modularity through the compiler stages, and the additional crate doesn't pull its weight without that.
...which I think was your view recently @m-span ...

authors: aljazerzen m-span max-sixty vanillajonathan

repo: PRQL/prql


text:
Create PCA_analysis.qmd

Performing PCA Analysis

I'll give this an initial review shortly!

This is a great start!  The code chunks in here look like they're missing the backticks (```) to indicate the start and end of code chunks and also the heading tags (e.g. #) for some of the text.  Mind adding those in please @royano19 ?

This is a great start! The code chunks in here look like they're missing the backticks (```) to indicate the start and end of code chunks and also the heading tags (e.g. #) for some of the text. Mind adding those in please @royano19 ?

Sure Let me check

The build is failing as we have a couple of missing package dependencies, but we can take a look at making a PR to your fork to update this as it's a little but of a weird process.  Will ping once we have something together!

yes I donno first time it is passing all the checks but now it's not working. strange

Hello! @royano19 @thisisnic i created a PR with the changes to the renv.lock that should fix the issue. https://github.com/royano19/CAMIS/pull/2
@royano19 if you merge it, you'll see the changes in this PR to the original CAMIS repo

@ines-gimeno-molina @thisisnic I have merged. Now what else I need to do?

The checks are now passing @royano19 @thisisnic

Thanks @ines-gimeno-molina . @thisisnic you can have a review.

authors: ines-gimeno-molina royano19 thisisnic

repo: PSIAIMS/CAMIS


text:
Fix to test_basic.py

This PR fixes test_basic.py to specify the r_gov_shift parameter as a list.  This is necessary after changes from PR #852.
Also fixes a comparison of the dimensions between the baseline solution and the reform parameters.

Codecov Report

Merging #854 (3beface) into master (e4c2275) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #854   +/-   ##
=======================================
  Coverage   82.24%   82.24%
=======================================
  Files          18       18
  Lines        3987     3987
=======================================
  Hits         3279     3279
  Misses        708      708

Flag
Coverage Δ

unittests
82.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rickecon This PR is ready for your review.

@jdebacker. I just reviewed and approved the changes. I am now rerunning the CI tests that failed. I wonder if the failures are coming from our tests taking more than the allotted compute time. We might have to choose whether we test on Python 3.9 or 3.10.

@jdebacker. All tests have passed now. Looks great. Merging.

authors: codecov-commenter jdebacker rickecon

repo: PSLmodels/OG-Core


text:
Fixes Trinkets

This PR fixes trinkets (as mentioned in the commit message) by changing when the gravestones code is run, previously it listened on drop inventory but that is called after dropEquipment (if shouldDropLoot and DO_MOB_LOOT game rule is true) so now it listens on the drop function in LivingEntity and cancels it if gravestones is enabled.

Worked with elytra trinket, create goggles seem to not be working, as in, puts it in every single trinket slot, gonna test another trinket mod and hope create is the exception not the rule (and that elytra trinket was not the exception either), otherwise gonna need to rework that logic quite a bit

Will probably move this to a separate branch, not sure why I didn't do that initially though


text:
Program 'ffmpeg' is not found

I'm running on Windows 11, and I got this error:
Program 'ffmpeg' is not found
How to solve?

see #11

authors: ctivia speedyconzales

repo: PWhiddy/PokemonRedExperiments


text:
Mavros offboard example mistake?

I was learning how to write ROS nodes to interact with mavros. On the example http://dev.px4.io/ros-mavros-offboard.html, it says
// wait for FCU connection
  while(ros::ok() && current_state.connected){
        ros::spinOnce();
        rate.sleep();
    }

Is it !current_state.connected instead of current_state.connected?
In addition, I am not sure why we want to send a few instructions before the vehicle is armed. Is it because there can be a lag between sending the signal and receiving the signal on the FCU?
    //send a few setpoints before starting
    for(int i = 100; ros::ok() && i > 0; --i){
        local_pos_pub.publish(pose);
        ros::spinOnce();
        rate.sleep();
    }

please read it carefully, mavros-offboard,
The px4 flight stack has a timeout of 500ms between two offboard commands. If this timeout is exceeded, the commander will fall back to the last mode the vehicle was in before entering offboard mode. This is why the publishing rate must be faster than 2 Hz to also account for possible latencies. This is also the same reason why it is recommended to enter offboard mode from POSCTL mode, this way if the vehicle drops out of offboard mode it will stop in its tracks and hover.

Thanks @huanglilong. So my understanding is since the px4 flight stack has a timeout of 500ms, we would like to prepare a bunch of commands in its task queue, otherwise, if the the FCU times out, it will f
the FCU times out, it will leave the OFFBOARD mode.

"In addition, I am not sure why we want to send a few instructions before the vehicle is armed. Is it because there can be a lag between sending the signal and receiving the signal on the FCU?"
before switch to OFFBOARD mode, you should send a bunch of commands to FCU, if not, FCU(pixhawk) will reject switching to OFFBOARD mode. it has nothing to do with delay.

offnode, i have tested it with gazebo and pixhawk

@huanglilong In the cpp file you provided, I don't think you ever send the service requests.

you can try this package

authors: huanglilong zhahaoyu


text:
Adding vertical (Z) velocity to inav estimator

This is needed for high-accuracy GNSS sensors (like Ashtech MB100 we are using). It allows copter to maintain better altitude stability.
Basically copying horizontal code.
Here is the log http://dash.oznet.ch/view/wxpvxAKYstGZjXvkKTSkye

Could you provide a more detailed analysis / logs if this actually improves flight performance? We would need plots of the GPS velocity and flights with and without. I'm concerned that in noisy GPS reception situations this patch can deteriorate flight performance as GPS altitude is much more affected than position once the signal quality / sky view deteriorates.

By default the weight for Z velocity can be 0. It needed only for RTK receivers, where altitude accuracy is ~10cm, in this case using velocity may be very useful.

We've done lots of flying with and without this patch. We tested with regular Ublox and with Ashtech GPS board. We also played with various combinations of INAV_W_Z_GPS_P/INAV_W_Z_GPS_V/INAV_W_Z_GPS_BARO. The majority of tests were performed before merging Anton's L1 into trunk on MPC_TRACK branch. We haven't noticed any deterioration of quality. However there wasn't definite result on improving quality either. We just didn't have enough time before we stopped flying due to winter. I have plenty of log files with this patch showing very good vertical precision, but can't isolate effect of this particular patch vs overall quality of algorithm / hardware.

Ok. Happy to merge with default weight set to zero then.

Ok. Happy to merge with default weight set to zero then.

Default is changed to zero.

Thanks!

Thanks a lot!

authors: DrTon LorenzMeier anatolfilin dyeldandi


text:
Qurt rebase updates 3

Added dspal as a PX4 submodule.
Removed the re-definitions of the usage method in the posix/main.cpp file.
Added qurt_external_hook interface to call externally linked module.
Fixed code format to comply with PX4 style.
Added usage information to main app and handled cases for unknown arguments.
Fixed the orb_priority interface to use int32_t instead of int.
Fixes to get hil working with led changes.
Added the config_eagle_adsp.mk file and update the make files to to use new
include/lib paths

Thanks!

authors: LorenzMeier mcharleb


text:
[WIP] use local coordinates for position control (Global to local)

We thought it makes sense to create this PR to get an overview of the current state
What has been done:

mission_item will be handed over to navigator_item (which still has lat/lon/alt, but we wanted to get rid of it -> needs to be checked with fixed wing). That means mission_item is only being used for reading mission information from the dataman. Since the mission_item are being stored, they need to be small whearas the size of the navigator_item does not matter.
mc_pos_controller uses local coordinates

What needs to be done:

[ ] General flight testing (only SITL so far)
[ ] Fixed wing @dagar can you maybe have a look at that and test?
[ ] Offboard maybe @mhkabir or @Stifael?
[ ] LPE needs more testing
[ ] Check capability for long missions (remains the same so far for MC)
[ ] Global coordinate functions to local

Anything else?

@ChristophTobler is it possible to add the feature I referenced in https://github.com/PX4/Firmware/issues/7368, meaning adding the possibility of the global origin being set and the local origin have an offset to it? It would be useful for multi-entity systems and it would follow the ROS REP 105 regarding the coordinate frames (earth<->map<->odom<->base_link). This means that adding this feature will mean setting the earth frame, which will have an offset WRT map/odom (local origin).
I can add a commit against this PR with that implementation if needed.

@TSC21 I still don't completely understand how that is not already known. Currently the local origin is set at the moment the vehicle is powered on, and will remain there until you turn off the vehicle and restart it.
In contrast, the global origin (=home position) is set once you have armed, and will be reset to a new global origin anytime the vehicle disarms and arms again. The offset, however, is known at any time, and in fact is used to convert global setpoints into local setpoints. Am I missing something?

@Stifael probably this will help: http://www.ros.org/reps/rep-0105.html#earth. This is the coordinate frame I'm referencing. For a single vehicle, the global origin is equal to the local origin. But for multi-entities, that is not true because they don't have the same home_position. In a translation to what happen in ROS, for a single vehicle/robot, you don't require earth, eventhough you can state it as being coincident with map (global is equal to the local frame). But for multiple systems, like a swarm for example, that will not apply, and you should define a global origin (earth) which is the same to all the entities, while having a different offset between the home_position and this global origin.
Is it clear to you? This is not a most a it is a neat feature which for example we already support on MAVROS side. Would be good if we could follow up the implementation here. Would be something very simple I suppose cause we just need to add support to the msgs and at the same time keep track of the earth origin and the local offset to it in the navigator.

In the short term do we need the position controllers to accept both global and local?

not sure for FW. Global is in there because of FW. MC uses local only

I was referring to the publishing side. I can make FW work with local only.

@ChristophTobler do you accept the proposed idea? I can PR the code soon if it makes sense to all.

@TSC21 Sure

@ChristophTobler perfect. Will do it ASAP. Thanks

why is the local origin not set before arm. why at start of the system? why is there no possibility to reset the local position via mavlink/mavros?

The local origin is never supposed to change after the estimator initializes. If you want, you can capture the value of the local position at arm time and subtract that from the estimate.

I rebased it to the newest master. It compiles, but I encountered at least one issue, which I currently don't understand. For whatever reason, the update check for local position is always false (https://github.com/PX4/Firmware/blob/d4ac87e5edd3e241012b5d95dd2dd347841e4051/src/modules/navigator/navigator_main.cpp#L361).
If I ignore the check, then it works normally.
@dagar, do you know why the update check always fails?

The navigator loop is polling local on master now. https://github.com/PX4/Firmware/blob/master/src/modules/navigator/navigator_main.cpp#L277
If you're immediately doing an orb_check on local there probably won't be new data.

@dagar what is the state of the FW?
next step is to remove all lat-lon computation within navigator. The MC is in a state where such a transition is possible.

I'm not sure, but if you'd like to push this through let's get it rebased on master and I'll make sure FW is working completely. It'll be easier to handle local only in fw_pos rather than figure out if the lat/lon is valid.

I won't suggest we tackle at the same time, but this is making me question the overall design.
We have mavlink items that the mavlink module receives, converts to mission_items and dumps in navigator. Now navigator pulls the mission_items and converts to navigator items? Maybe we should be directly storing the original mission.
Secondly, I think it would be fine to continue calling using _mission_item everywhere in navigator. This drastically reduces the size of the diff and gives downstream consumers a chance of actually merging.

@bkueng , can you give more info about mission_item?
i was told that mission_item is primarily used as a storage structure for dataman. Consequently, it is not meant to be passed around through the entire navigator module. the new navigator_item was introduced to replace it with the goal to reduce it farther such that it only contains local setpoints. the only reason why the navigator_item still contains lat, lon and other stuff is because the first step is to remove the dependency to the mission_item. Once that is established and we succeeded in making a transition to local, we then can easily reduce the navigator item farther.
independent to this Pr:  the navigator interface and local variables are anyway not  well defined. In my opinion there has to be an interface for getting new mission related things (mission_item) and one interface that published the desired setpoints (position triplets). But right now mission_item and position_triplets are used all over the place, which makes it difficult to read the code in general.

It is now rebased with newest master. I quickly did some tests for multicopter, and the first tests were successful. However, I expect to have some small regression issues.
For the moment I kept lat/lon/alt in the triplets because vmount uses it and also mavlink_messages.cpp also streams triplets.lat/lon/alt.
Not sure what the next step is.
@dagar started here https://github.com/PX4/Firmware/commit/ecb598750992530f46e527e8660f71c950ec4b77 to add support for different frame for mission_item. I could start to integrate that, but on the other hand I am not sure if it is worth the effort, especially if we plan to go from mission_item to triplets (or navigator member variables) directly

In order to use only local coordinates for fixedwing, the l1 controller need to be updated as well because it uses global coordinates. I don't think it is necessary to use global for l1. What I could do is to extend the l1 controller such that it can be used with local coordinates as well.
@priseborough do you have any good reason why that would be a bad idea?

@TSC21 sure

Still relevant

FYI @bresch

@TSC21 @dagar @julianoes is this still relevant?

@Pedro-Roque Position control uses local position now

authors: ChristophTobler Pedro-Roque Stifael TSC21 TobiMiller bresch dagar julianoes mhkabir


text:
Generalize float-only conversion

Fixes https://github.com/PX4/Matrix/issues/135

Fixed by the very speedy https://github.com/PX4/Matrix/pull/136

Coverage remained the same at 100.0% when pulling a87751167bd429c5d913b53fd8cfbc419d82785e on quaternion-non-float into 9a30828a0a1d79e87fd09653bb9f936d7ca0ba17 on master.

authors: coveralls jkflying