text:
FINEMAP credible sets not included in the results

While exploring the results in the echolocatoR Shiny app, I noticed that FINEMAP never returns more than 1 credible set per locus. This was confusing since SuSiE often returns more than 1 credible set.
I started diving into the code, and I think the issue is that it only looks for data.cred, when FINEMAP returns data.cred# where # is the number of credible sets. PolyFun obtains the credible sets by searching backwards from the maximum number of causal SNPs until it finds a .cred file (source):
        #add causal set info
        df_finemap['CREDIBLE_SET'] = 0
        cred_file = None
        for m in range(num_causal_snps, 0, -1):
            if os.path.exists(cred_filename+str(m)):
                cred_file = cred_filename+str(m)
                break
        if cred_file is None:
            raise IOError('cred file not found')
        df_cred = pd.read_table(cred_file, sep=' ', usecols=(lambda c: c.startswith('cred')), comment='#')
        df_finemap.set_index('SNP', inplace=True, drop=False)
        for c_i, c in enumerate(df_cred.columns):
            df_finemap.loc[df_cred[c].dropna(), 'CREDIBLE_SET'] = c_i+1
        df_finemap.reset_index(inplace=True, drop=True)

echolocatoR only checks for data.cred:
https://github.com/RajLabMSSM/echolocatoR/blob/b055ac0fb74c914d7600e3afc650a2ffd7149396/R/FINEMAP.R#L336
And then when it is extracting the PIPs from the .snp file, it assigns any SNP that meets the PIP threshold to CS 1.
https://github.com/RajLabMSSM/echolocatoR/blob/b055ac0fb74c914d7600e3afc650a2ffd7149396/R/FINEMAP.R#L363-L364
I attempted to put together a minimal, reproducible example to demonstrate this behavior. However, using the latest version on master, FINEMAP is currently returning NA for both the .CS and the .PP columns.

See here for minimal, reproducible example

library(echolocatoR)
stopifnot(packageVersion("echolocatoR") == "0.1.2")

data("Nalls_top_SNPs")
top_SNPs <- import_topSNPs(
  topSS = Nalls_top_SNPs,
  position_col = "BP",
  pval_col = "P, all studies",
  effect_col = "Beta, all studies",
  gene_col = "Nearest Gene",
  locus_col = "Nearest Gene",
  remove_variants = "rs34637584"
)
fullSS_path <- example_fullSS()

Nalls23andMe_2019.results <- finemap_loci(
  top_SNPs = top_SNPs,
  results_dir = file.path(getwd(), "results"),
  loci = "BST1",
  dataset_name = "Nalls23andMe_2019",
  remove_tmps = FALSE,
  fullSS_path = fullSS_path,
  query_by = "tabix",
  snp_col = "RSID",
  pval_col = "p",
  effect_col = "beta",
  stderr_col = "se",
  freq_col = "freq",
  MAF_col = "calculate",
  bp_distance = 10000,
  min_MAF = 0.001,
  finemap_methods = c("FINEMAP", "SUSIE"),
  LD_reference = "UKB",
  download_method = "axel",
  plot.types = c()
)

Nalls23andMe_2019.results[SUSIE.CS > 0, list(SNP, FINEMAP.CS, FINEMAP.PP, SUSIE.CS, SUSIE.PP)]
readLines("results/GWAS/Nalls23andMe_2019/BST1/FINEMAP/data.snp", n = 3)
readLines("results/GWAS/Nalls23andMe_2019/BST1/FINEMAP/data.cred5")

sessionInfo()

See here for the results

> source("reprex.R", echo = TRUE)

> library(echolocatoR)
Registered S3 method overwritten by 'GGally':
  method from
  +.gg   ggplot2
Possible Ensembl SSL connectivity problems detected.
Please see the 'Connection Troubleshooting' section of the biomaRt vignette
vignette('accessing_ensembl', package = 'biomaRt')Error in curl::curl_fetch_memory(url, handle = handle) :
  SSL certificate problem: self signed certificate in certificate chain

Bioconductor version 3.12 (BiocManager 1.30.12), ?BiocManager::install for help

> stopifnot(packageVersion("echolocatoR") == "0.1.2")

> data("Nalls_top_SNPs")

> top_SNPs <- import_topSNPs(
+   topSS = Nalls_top_SNPs,
+   position_col = "BP",
+   pval_col = "P, all studies",
+   effect_col = "Beta, all studie ..." ... [TRUNCATED]
[1] "+ Assigning gene_col and locus_col independently"

> fullSS_path <- example_fullSS()

> Nalls23andMe_2019.results <- finemap_loci(
+   top_SNPs = top_SNPs,
+   results_dir = file.path(getwd(), "results"),
+   loci = "BST1",
+   dataset_ .... [TRUNCATED]
[1] "+ CONDA:: Activating conda env 'echoR'"
[1] "Checking for tabix installation..."
[1] "Checking for bcftools installation..."

)   )  ) ))))))}}}}}}}} {{{{{{{{{(((((( (  (   (
BST1 (1 / 1)
)   )  ) ))))))}}}}}}}} {{{{{{{{{(((((( (  (   (
[1] "+ Extracting relevant variants from fullSS..."
[1] "+ Query Method: tabix"
[1] "+ QUERY: Chromosome = 4 ; Min position = 15727348 ; Max position = 15747348"
[1] "TABIX:: Converting full summary stats file to tabix format for fast querying..."
[1] "+ CONDA:: Identified bgzip executable in echoR env."
[1] "( grep 'CHR' ./Nalls23andMe_2019.fullSS_subset.tsv; grep -v ^'CHR' ./Nalls23andMe_2019.fullSS_subset.tsv | sort -k1,1 -k2,2n ) | ~/mambaforge/envs/echoR/bin/bgzip -f > ~/echolocatoR/results/GWAS/Nalls23andMe_2019/Nalls23andMe_2019.fullSS_subset.tsv.gz"
[1] "+ CONDA:: Identified tabix executable in echoR env."
[1] "TABIX:: Indexing"
[1] "~/mambaforge/envs/echoR/bin/tabix -f -S 1 -s 1 -b 2 -e 2 ~/echolocatoR/results/GWAS/Nalls23andMe_2019/Nalls23andMe_2019.fullSS_subset.tsv.gz"
[1] "Determining chrom type from file header"
[1] "Chromosome format = 1"
[1] "+ CONDA:: Identified tabix executable in echoR env."
[1] "TABIX:: Extracting subset of sum stats"
[1] "+ TABIX:: ~/mambaforge/envs/echoR/bin/tabix -h ~/echolocatoR/results/GWAS/Nalls23andMe_2019/Nalls23andMe_2019.fullSS_subset.tsv.gz 4:15727348-15747348"
[1] "+ TABIX:: Returning 115 x 11 data.table"
[1] "++ Saving query ==> ~/echolocatoR/results/GWAS/Nalls23andMe_2019/BST1/BST1_Nalls23andMe_2019_subset.tsv.gz"
[1] "LD:: Standardizing summary statistics subset."
[1] "++ Preparing Gene col"
[1] "++ Preparing A1,A1 cols"
[1] "++ Preparing MAF,Freq cols"
[1] "++ Inferring MAF from frequency column..."
[1] "++ Preparing N_cases,N_controls cols"
[1] "++ Preparing `proportion_cases` col"
[1] "++ Calculating `proportion_cases`."
[1] "++ Preparing N col"
[1] "+ Preparing sample_size (N) column"
[1] "++ Computing effective sample size."
[1] "++ Preparing t-stat col"
[1] "+ Calculating t-statistic from Effect and StdErr..."
[1] "++ Assigning lead SNP"
[1] "++ Ensuring Effect, StdErr, P are numeric"
[1] "++ Ensuring 1 SNP per row"
[1] "++ Removing extra whitespace"
[1] "++ Saving subset ==> ~/echolocatoR/results/GWAS/Nalls23andMe_2019/BST1/BST1_Nalls23andMe_2019_subset.tsv.gz"
[1] "+ Extraction completed in 6.72 seconds"
[1] "+ 115 SNPs x  16 columns"
[1] "LD:: Using UK Biobank LD reference panel."
[1] "+ UKB LD file name: chr4_15000001_18000001"
[1] "+ LD:: Downloading full .gz/.npz UKB files and saving to disk."
[1] "+ CONDA:: Identified axel executable in echoR env."
[1] "+ CONDA:: Identified axel executable in echoR env."
[1] "+ LD:: load_ld() python function input: ~/echolocatoR/results/GWAS/Nalls23andMe_2019/BST1/LD/chr4_15000001_18000001"
[1] "+ LD:: Reading LD matrix into memory. This could take some time..."
~/echolocatoR/results/GWAS/Nalls23andMe_2019/BST1/LD/chr4_15000001_18000001.gz
~/echolocatoR/results/GWAS/Nalls23andMe_2019/BST1/LD/chr4_15000001_18000001.npz
Processed URL: ~/echolocatoR/results/GWAS/Nalls23andMe_2019/BST1/LD/chr4_15000001_18000001
Some other message at the end
[1] "+ Full UKB LD matrix: 20815 x 20815"
[1] "+ Full UKB LD SNP data.table: 20815 x 5"
[1] "+ LD:: Saving LD matrix ==> ~/echolocatoR/results/GWAS/Nalls23andMe_2019/BST1/LD/BST1.UKB_LD.RDS"
[1] "115 x 115 LD_matrix (sparse)"
[1] "+ FILTER:: Filtering by LD features."
[1] "FILTER:: Filtering by SNP features."
[1] "+ FILTER:: Removing SNPs with MAF < 0.001"
[1] "+ FILTER:: Post-filtered data: 115 x 16"
vvvvv-- FINEMAP --vvvvv
✅ All required columns present.
✅ All suggested columns present.
vvvvv-- SUSIE --vvvvv
✅ All required columns present.
✅ All suggested columns present.
[1] "++ Fine-mapping using multiple tools: FINEMAP, SUSIE"

+++ Multi-finemap:: FINEMAP +++
[1] "++ FINEMAP:: Constructing master file."
[1] "++ FINEMAP:: Constructing data.z file."
[1] "++ FINEMAP:: Constructing data.ld file."
[1] "+ Using FINEMAP v1.4"

|--------------------------------------|
| Welcome to FINEMAP v1.4              |
|                                      |
| (c) 2015-2020 University of Helsinki |
|                                      |
| Help :                               |
| - ./finemap --help                   |
| - www.finemap.me                     |
| - www.christianbenner.com            |
|                                      |
| Contact :                            |
| - christian.benner@helsinki.fi       |
| - matti.pirinen@helsinki.fi          |
|--------------------------------------|

--------
SETTINGS
--------
- dataset            : all
- corr-config        : 0.95
- n-causal-snps      : 5
- n-configs-top      : 50000
- n-conv-sss         : 100
- n-iter             : 100000
- n-threads          : 1
- prior-k0           : 0
- prior-std          : 0.05
- prob-conv-sss-tol  : 0.001
- prob-cred-set      : 0.95

------------
FINE-MAPPING (1/1)
------------
- GWAS summary stats               : FINEMAP/data.z
- SNP correlations                 : FINEMAP/data.ld
- Causal SNP stats                 : FINEMAP/data.snp
- Causal configurations            : FINEMAP/data.config
- Credible sets                    : FINEMAP/data.cred
- Log file                         : FINEMAP/data.log_sss
- Reading input                    : done!

- Number of GWAS samples           : 216621
- Number of SNPs                   : 115
- Prior-Pr(# of causal SNPs is k)  :
  (0 -> 0)
   1 -> 0.584
   2 -> 0.292
   3 -> 0.0964
   4 -> 0.0237
   5 -> 0.00461
- 1616 configurations evaluated (0.104/100%) : converged after 104 iterations
- Computing causal SNP statistics  : done!
- Regional SNP heritability        : 0.00763 (SD: 0.000422 ; 95% CI: [0.00679,0.0085])
- Log10-BF of >= one causal SNP    : 2.28e+04
- Post-expected # of causal SNPs   : 5
- Post-Pr(# of causal SNPs is k)   :
  (0 -> 0)
   1 -> 0
   2 -> 0
   3 -> 0
   4 -> 2.87e-262
   5 -> 1
- Computing credible sets          : done!
- Writing output                   : done!
- Run time                         : 0 hours, 0 minutes, 0 seconds
[1] ".cred not detected. Using .snp instead."
[1] "+ FINEMAP:: Importing prob (.snp)..."
Error in `[.data.table`(x, r, vars, with = FALSE) :
  column(s) not found: prob
[1] "++ Credible Set SNPs identified = 0"
[1] "++ Merging FINEMAP results with multi-finemap data."

+++ Multi-finemap:: SUSIE +++
[1] "+ Preparing sample_size (N) column"
[1] "+ `N` column already present in data."
[1] "+ SUSIE:: sample_size= 216621"
[1] "+ SUSIE:: max_causal = 5"
[1] "+ Subsetting LD matrix and finemap_dat to common SNPs..."
[1] "+ LD:: Removing unnamed rows/cols"
[1] "+ LD:: Replacing NAs with 0"
[1] "+ LD_matrix = 115 SNPs."
[1] "+ finemap_dat = 115 SNPs."
[1] "+ 115 SNPs in common."
[1] "+ SUSIE:: Using `susie_suff_stat()` from susieR v0.10.1"
[1] "+ SUSIE:: Extracting Credible Sets..."
[1] "++ Credible Set SNPs identified = 3"
[1] "++ Merging SUSIE results with multi-finemap data."
[1] "+ Identifying Consensus SNPs..."
[1] "++ support_thresh = 2"
[1] "++ top_CS_only=FALSE"
[1] "+ Calculating mean Posterior Probability (mean.PP)..."
[1] "+ Replacing PP==NA with 0"
[1] "++ 2 fine-mapping methods used."
[1] "++ 3 Credible Set SNPs identified."
[1] "++ 0 Consensus SNPs identified."
[1] "+ Fine-mapping with ' FINEMAP, SUSIE ' completed:"
Time difference of 3.1 secs

Fine-mapping complete in:
Time difference of 1.7 mins
[1] "+ Identifying Consensus SNPs..."
[1] "++ support_thresh = 2"
[1] "++ top_CS_only=FALSE"
[1] "+ Calculating mean Posterior Probability (mean.PP)..."
[1] "+ Replacing PP==NA with 0"
[1] "++ 2 fine-mapping methods used."
[1] "++ 3 Credible Set SNPs identified."
[1] "++ 0 Consensus SNPs identified."

> Nalls23andMe_2019.results[SUSIE.CS > 0, list(SNP, FINEMAP.CS, FINEMAP.PP, SUSIE.CS, SUSIE.PP)]
          SNP FINEMAP.CS FINEMAP.PP SUSIE.CS  SUSIE.PP
1: rs34559912         NA         NA        3 1.0000000
2:  rs4389574         NA         NA        1 1.0000000
3:  rs6852450         NA         NA        2 0.9999992

> readLines("results/GWAS/Nalls23andMe_2019/BST1/FINEMAP/data.snp", n = 3)
[1] "index rsid chromosome position allele1 allele2 maf beta se z prob log10bf mean sd mean_incl sd_incl"
[2] "1 rs6828144 4 15727389 T C 0.0263 0.1765 0.0309 5.71197 1 11.8522 1.40649 0.0355444 1.40649 0.0355444"
[3] "111 rs11947310 4 15744576 A C 0.1909 0.0823 0.012 6.85833 1 11.8522 1.40649 0.0355444 1.40649 0.0355444"

> readLines("results/GWAS/Nalls23andMe_2019/BST1/FINEMAP/data.cred5")
[1] "# Post-Pr(# of causal SNPs is 5) = 1"
[2] "#log10bf 22448.9 NA 22432.1 NA 20843.6 NA 556.379 NA 264.033 NA"
[3] "#min(|ld|) 1 NA 1 NA 1 NA 1 NA 1 NA"
[4] "#mean(|ld|) 1 NA 1 NA 1 NA 1 NA 1 NA"
[5] "#median(|ld|) 1 NA 1 NA 1 NA 1 NA 1 NA"
[6] "index cred1 prob1 cred2 prob2 cred3 prob3 cred4 prob4 cred5 prob5"
[7] "1 rs11947310 1 rs11933202 1 rs1807250 1 rs6828144 1 rs73123615 0.999999"

> sessionInfo()
R version 4.0.3 (2020-10-10)
Platform: x86_64-conda-linux-gnu (64-bit)
Running under: CentOS Linux 7 (Core)

Matrix products: default
BLAS/LAPACK: ~/mambaforge/envs/echoR/lib/libopenblasp-r0.3.12.so

locale:
 [1] LC_CTYPE=en_US.UTF-8       LC_NUMERIC=C
 [3] LC_TIME=en_US.UTF-8        LC_COLLATE=en_US.UTF-8
 [5] LC_MONETARY=en_US.UTF-8    LC_MESSAGES=en_US.UTF-8
 [7] LC_PAPER=en_US.UTF-8       LC_NAME=C
 [9] LC_ADDRESS=C               LC_TELEPHONE=C
[11] LC_MEASUREMENT=en_US.UTF-8 LC_IDENTIFICATION=C

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] echolocatoR_0.1.2

loaded via a namespace (and not attached):
  [1] colorspace_2.0-0            ellipsis_0.3.1
  [3] class_7.3-18                biovizBase_1.38.0
  [5] htmlTable_2.1.0             XVector_0.30.0
  [7] GenomicRanges_1.42.0        base64enc_0.1-3
  [9] gld_2.6.2                   dichromat_2.0-0
 [11] rstudioapi_0.13             proxy_0.4-25
 [13] DT_0.17                     bit64_4.0.5
 [15] AnnotationDbi_1.52.0        fansi_0.4.2
 [17] mvtnorm_1.1-1               xml2_1.3.2
 [19] R.methodsS3_1.8.1           splines_4.0.3
 [21] ggbio_1.38.0                cachem_1.0.4
 [23] rootSolve_1.8.2.1           knitr_1.31
 [25] jsonlite_1.7.2              Formula_1.2-4
 [27] Rsamtools_2.6.0             dbplyr_2.1.1
 [29] cluster_2.1.1               R.oo_1.24.0
 [31] png_0.1-7                   graph_1.68.0
 [33] BiocManager_1.30.12         compiler_4.0.3
 [35] httr_1.4.2                  backports_1.2.1
 [37] assertthat_0.2.1            Matrix_1.3-2
 [39] fastmap_1.1.0               lazyeval_0.2.2
 [41] htmltools_0.5.1.1           prettyunits_1.1.1
 [43] tools_4.0.3                 gtable_0.3.0
 [45] glue_1.4.2                  lmom_2.8
 [47] GenomeInfoDbData_1.2.4      reshape2_1.4.4
 [49] dplyr_1.0.5                 rappdirs_0.3.3
 [51] Rcpp_1.0.6                  Biobase_2.50.0
 [53] vctrs_0.3.7                 Biostrings_2.58.0
 [55] rtracklayer_1.50.0          crosstalk_1.1.1
 [57] xfun_0.20                   stringr_1.4.0
 [59] lifecycle_1.0.0             ensembldb_2.14.0
 [61] XML_3.99-0.6                zlibbioc_1.36.0
 [63] MASS_7.3-53.1               scales_1.1.1
 [65] BSgenome_1.58.0             VariantAnnotation_1.36.0
 [67] ProtGenerics_1.22.0         hms_1.0.0
 [69] MatrixGenerics_1.2.1        RBGL_1.66.0
 [71] parallel_4.0.3              SummarizedExperiment_1.20.0
 [73] expm_0.999-6                susieR_0.10.1
 [75] AnnotationFilter_1.14.0     RColorBrewer_1.1-2
 [77] curl_4.3                    Exact_2.1
 [79] reticulate_1.18             memoise_2.0.0
 [81] gridExtra_2.3               ggplot2_3.3.3
 [83] biomaRt_2.46.3              rpart_4.1-15
 [85] reshape_0.8.8               latticeExtra_0.6-29
 [87] stringi_1.5.3               RSQLite_2.2.5
 [89] S4Vectors_0.28.1            e1071_1.7-6
 [91] checkmate_2.0.0             GenomicFeatures_1.42.2
 [93] BiocGenerics_0.36.0         boot_1.3-27
 [95] BiocParallel_1.24.1         GenomeInfoDb_1.26.4
 [97] rlang_0.4.10                pkgconfig_2.0.3
 [99] matrixStats_0.58.0          bitops_1.0-6
[101] lattice_0.20-41             purrr_0.3.4
[103] GenomicAlignments_1.26.0    htmlwidgets_1.5.3
[105] bit_4.0.4                   tidyselect_1.1.0
[107] GGally_2.1.1                plyr_1.8.6
[109] magrittr_2.0.1              R6_2.5.0
[111] IRanges_2.24.1              DescTools_0.99.40
[113] generics_0.1.0              Hmisc_4.5-0
[115] DelayedArray_0.16.3         DBI_1.1.1
[117] pillar_1.5.1                foreign_0.8-81
[119] survival_3.2-10             RCurl_1.98-1.3
[121] nnet_7.3-15                 tibble_3.1.0
[123] crayon_1.4.1                utf8_1.2.1
[125] OrganismDbi_1.32.0          BiocFileCache_1.14.0
[127] jpeg_0.1-8.1                progress_1.2.2
[129] grid_4.0.3                  data.table_1.14.0
[131] blob_1.2.1                  digest_0.6.27
[133] R.utils_2.10.1              openssl_1.4.3
[135] stats4_4.0.3                munsell_0.5.0
[137] askpass_1.1
Warning message:
In susie_func(bhat = subset_DT$Effect, shat = subset_DT$StdErr,  :
  IBSS algorithm did not converge in 100 iterations!

Hi @jdblischak, thanks for reporting this in such detail!
Here are my thoughts currently, any suggestions are welcome.
Credible Sets
Currently, I only record the top credible set in the multi-finemap file bc I was trying to avoid assigning multiple PPs to each SNP to keep FINEMAP.PP as a single column (all my other echolocatoR code is built around this structure). So basically, if SNPs are in the top CS they're assigned FINEMAP.CS=1 else 0. Perhaps there's a better way to do this that preserves this information without the user having to read in multiple .cred files themselves after running finemap_loci().
I can think of two strategies currently:

Assign each FINEMAP CS to its own column (e.g. FINEMAP1.PP, FINEMAP1.CS, FINEMAP2.PP, FINEMAP2.CS, FINEMAP3.PP, FINEMAP3.CS, etc.) and revise the rest of echolocatoR's code to account for this change.
Continue using only one col for each: FINEMAP.PP and FINEMAP.PP. When a SNP occurs in multiple CS, only record its FINEMAP.PP within the first CS it appears and assign its FINEMAP.CS to that first CS. This will work with the rest of the code but isn't exactly a faithful representation of the FINEMAP results.

FINEMAP version differences

There's some pretty substantial differences in arguments/file outputs/formats across the various versions of FINEMAP. I've tried to account for all of these but I may have missed some.
In FINEMAP v1.4, multiple .cred files are produced (e.g. .cred5), whereas in older versions, only a single .cred file is produced (with no number after it). For the reasons I mentioned above, I only took the top CS (corresponding to the first .cred# file in v1.4). But i think I accidentally changed the code at some point such that it didn't account for the # suffix in v1.4. I can at least make this more flexible with a grep() search rather than endsWith().

zstandard

This is something I've been having ongoing issues with, for some reason FINEMAP v1.4 throws dylib errors despite the fact that I have zstd installed and updated via brew (see Issue #40 ). I also tried with a conda env version, but FINEMAP doesn't seem to recognize this.
It seems this only occurs on Mac since you've been able to run it fine on CentOS Linux (which has been my experience too). Still trying to figure this one out, but I may have to to email the original author since there doesn't seem to be any GitHub or issues forum for FINEMAP (at least that I've come across).

@bschilder Thanks for the detailed follow-up. My thoughts below:

So basically, if SNPs are in the top CS they're assigned FINEMAP.CS=1 else 0.

I didn't realize that FINEMAP.CS was only supposed to include the top CS. This is confusing when comparing to, e.g. the results from SuSiE. When the echolocatoR results show multiple CS from SuSiE but a single one from FINEMAP, this indicates a difference in behavior. But I think that is just due to echolocatoR, not a difference in the methods.
Also, I don't think that is what the code does, at least not for FINEMAP 1.4. As far as I can tell, the CS info from FINEAMP 1.4 is not consulted at all. Instead the algorithm appears to be if PIP > threshold, assign FINEMAP.CS = 1 else NA. Thus every SNP with a large PIP gets assigned to CS=1, even if they were assigned to separate CS.

Assign each FINEMAP CS to its own column (e.g. FINEMAP1.PP, FINEMAP1.CS, FINEMAP2.PP, FINEMAP2.CS, FINEMAP3.PP, FINEMAP3.CS, etc.) and revise the rest of echolocatoR's code to account for this change.

I don't understand this. The PIP for a SNP is unaffected by the CS it is assigned. My recommendation would be to obtain the information the same as the PolyFun authors do, unless you have a compelling reason that is incorrect:

Obtain FINEMAP.PP from the column "prob" in the.snp output file
Obtain FINEMAP.CS from the .cred# output file, where # is the largest one available

I'm happy to help with this. And my apologies if I am missing something obvious.

I may have to to email the original author since there doesn't seem to be any GitHub or issues forum for FINEMAP

You should absolutely email the author for help troubleshooting the installation on macOS. There is no public forum for discussing these issues, and the code is closed source, so we can't build a conda package to ease installation.

Thanks for the feedback @jdblischak!
This does get rather confusing so I may have not have explained some things very well. I've tried a number of different ways about this so it's entirely possible I could be mixing up strategies from different version of echolocatoR and FINEMAP (apologies if this is the case).
Credible Sets and Posterior Probabilities
One of the main decision points I've gone back and forth on is whether to use .snp (marginal probabilities across all SNPs) vs .cred (conditional probabilities only for SNPs within a specific credible set) when constructing the final multi-finemap results file.

I think your suggestion makes quite a bit of sense to me. But I've also received some feedback from an anonymous reviewer that seems to have pretty intimate knowledge of FINEMAP who was adamant about using the conditional probabilities from .cred (I was previously using marg probs from .snp).
In the FINEMAP output, each configuration (each with a different # of causal SNPs modeled) is assigned a probability.  So if I specified the max # of causal SNPs as 5, FINEMAP v1.4 would return 5 .cred# files (though I think only 1 .cred file is returned in v1.3, and no .cred file is returned in older versions). For FINEMAP v1.4, The reviewer suggested that I
use the .cred# file that shows largest posterior probability for the number of causal variants (line 1 of the file) and extract credible sets and SNP-wise conditional probabilities from that file. In my experience, FINEMAP usually gives the .cred# file with the highest # of assumed causal SNPs the highest probability, but this isn't necessarily always the case.
More recent versions of FINEMAP also return a .config file, which I think could also be used to select the top configuration based on its PP.

This is all a bit tricky to explain in words so I'm going to push some of these proposed changes to the dev branch. If you don't mind, perhaps you could then look these over and see if they seem sensible to you?
FINEMAP support
I tried reaching out to the FINEMAP author a couple weeks ago via email but haven't heard back yet (christian.benner@helsinki.fi and cc'ed finemap@christianbenner.com). Not sure if he still uses these emails but I can't seem to find any others. Also tried reaching out via LinkedIn. I'll keep you posted if I have any luck.
Thanks again for your help!
-Brian

I think your suggestion makes quite a bit of sense to me. But I've also received some feedback from an anonymous reviewer that seems to have pretty intimate knowledge of FINEMAP who was adamant about using the conditional probabilities from .cred (I was previously using marg probs from .snp).

This doesn't make sense to me. If the goal is to produce results that can be compared across the different fine-mapping methods, I don't see why the conditional probabilities should be reported. For susieR you are reporting the PIPs in SUSIE.PP.
https://github.com/RajLabMSSM/echolocatoR/blob/b055ac0fb74c914d7600e3afc650a2ffd7149396/R/SUSIE.R#L194-L195
From your documentation:
https://github.com/RajLabMSSM/echolocatoR/blob/6b9086d6755be0cc802027b76fb8314058fa0bf1/README.Rmd#L311
From the FINEMAP documentation for data.snp (emphasis mine):

prob column contains the marginal Posterior Inclusion Probabilities (PIP). The PIP for the l th SNP is the posterior probability that this SNP is causal.

From the FINEMAP documentation for data.cred:

The l th credible set shows the best candidate SNPs and their posterior probability of being in a k-SNP causal configuration that additionally contains k - 1 SNPs.

If you want to report the posterior probability that a given SNP is causal, I think you should report prob from data.snp.
In cases where there are only 1 SNP per CS, I don't think it matters whether you report the PIP from data.snp or the PP from data.cred#. The PP will be 1, and the PIP will be 1 or very close to it. However, when there are multiple SNPs in a CS, the PIP can be different from the PP.
As an example, here's code to run the example shipped with FINEMAP:
mkdir /tmp/fmexample
cd /tmp/fmexample
wget http://christianbenner.com/finemap_v1.4_x86_64.tgz
tar xf finemap_v1.4_x86_64.tgz
cd finemap_v1.4_x86_64/
./finemap_v1.4_x86_64 --sss --in-files example/master -dataset 1

Taking a quick look at the results in R, PIP and PP are not identical (though they are correlated). The most dramatic difference is rs6. It's PIP is only 0.04. However, it's PP for being included in cred3 is 0.17.
library(data.table)
snp <- fread("example/data.snp")

snp[prob > 0.009, .(rsid, prob)]
#    rsid      prob
# 1:  rs7 1.0000000
# 2: rs30 0.9999690
# 3:  rs6 0.0417854
# 4: rs31 0.0107216
# 5:  rs8 0.0105046
# 6: rs48 0.0100717

cred2 <- fread("example/data.cred2", skip = 5)
cred2
#    index cred1 prob1 cred2 prob2
# 1:     1   rs7     1  rs30     1

cred3 <- fread("example/data.cred3", skip = 5)
cred3[prob3 > 0.02, ]
#     index cred1 prob1 cred2 prob2 cred3     prob3
#  1:     1   rs7     1  rs30     1   rs6 0.1733260
#  2:     2  <NA>    NA  <NA>    NA  rs31 0.0433775
#  3:     3  <NA>    NA  <NA>    NA   rs8 0.0424081
#  4:     4  <NA>    NA  <NA>    NA  rs48 0.0405975
#  5:     5  <NA>    NA  <NA>    NA  rs46 0.0361650
#  6:     6  <NA>    NA  <NA>    NA  rs14 0.0281224
#  7:     7  <NA>    NA  <NA>    NA  rs10 0.0253583
#  8:     8  <NA>    NA  <NA>    NA  rs11 0.0248557
#  9:     9  <NA>    NA  <NA>    NA  rs19 0.0246048
# 10:    10  <NA>    NA  <NA>    NA  rs32 0.0242520
# 11:    11  <NA>    NA  <NA>    NA  rs20 0.0241354
# 12:    12  <NA>    NA  <NA>    NA  rs17 0.0237760
# 13:    13  <NA>    NA  <NA>    NA  rs13 0.0233587

For FINEMAP v1.4, The reviewer suggested that I
use the .cred# file that shows largest posterior probability for the number of causal variants (line 1 of the file) and extract credible sets and SNP-wise conditional probabilities from that file.

This is a reasonable suggestion, but may not be worth the effort. If you report the highest number of credible sets, the user can always apply a PIP threshold to remove the SNPs that are less convincing (and thus remove the less convincing credible sets as well). The earlier credible sets should be unchanged.
The FINEMAP example above illustrates this. The PP that there are only 2 causal SNPs is much higher than the PP for 3 causal SNPs. However, if you were to report the results from data.cred3, and the user applied even a minimal PIP cutoff per SNP (e.g. >= 0.05), the final results would be identical.
% head -n 1 example/data.cred2
# Post-Pr(# of causal SNPs is 2) = 0.773769

% head -n 1 example/data.cred3
# Post-Pr(# of causal SNPs is 3) = 0.202562

This is all a bit tricky to explain in words so I'm going to push some of these proposed changes to the dev branch. If you don't mind, perhaps you could then look these over and see if they seem sensible to you?

Looking at b351c10b4cb25c21446abb3791a8cb0bb4084eda, I think it's good you now detect cred files other than data.cred.
https://github.com/RajLabMSSM/echolocatoR/blob/6b9086d6755be0cc802027b76fb8314058fa0bf1/R/FINEMAP.R#L337-L340
Though for the reason I stated above (and for consistency with PolyFun), I think you should select the cred file with the largest number of configurations, not the fewest, i.e. cred_path <- cred_path[length(cred_path)]
https://github.com/RajLabMSSM/echolocatoR/blob/6b9086d6755be0cc802027b76fb8314058fa0bf1/R/FINEMAP.R#L380-L382

authors: bschilder jdblischak

repo: RajLabMSSM/echolocatoR


text:
Configuração de envio de e-mail automático para o cliente.

https://www.youtube.com/watch?v=2NH3nLFMfz8
Esse vídeo é de nossa autoria em nossa canal para ajudar o pessoal aqui no mapos4, a configurar o e-mail automático assim que abre um novo orçamento, ou os entre outros.

Show de bola...
Seria possível fazer um vídeo com uma instalação limpa do MAPOS com os passos todos corretos? Iria ajudar muita gente!
Valeu!

Show de bola...
Seria possível fazer um vídeo com uma instalação limpa do MAPOS com os passos todos corretos? Iria ajudar muita gente!
Valeu!

Opa...
Achei aqui no seu canal..
https://www.youtube.com/watch?v=mo7vn4ws03g
Os procedimentos continuam iguais a esses?

https://www.youtube.com/watch?v=2NH3nLFMfz8
Esse vídeo é de nossa autoria em nossa canal para ajudar o pessoal aqui no mapos4, a configurar o e-mail automático assim que abre um novo orçamento, ou os entre outros.

se poder faz um de como configura o mercado pago e o gerencianet :)

Bom dia pessoal!
Gilberto, estou com dificuldades no envio automático para o cliente.
Já visualizei seu tuto no youtube, porem nada de solução.
Minha hospedagem é na hostinger.
Segue uma parte do log:
ERROR - 2021-02-26 14:11:03 --> 220 ESMTP smtp.hostinger.com
hello: 250-nl-srv-smtpout1.hostinger.io
starttls: 220 2.0.0 Ready to start TLS
hello: 250-nl-srv-smtpout1.hostinger.io
from: 250 2.1.0 Ok
to: 553 5.7.1 andre_guilherme@msn.com: Sender address rejected: not owned by user teste@andrehoffmann.website
The following SMTP error was encountered: 553 5.7.1 andre_guilherme@msn.com: Sender address rejected: not owned by user teste@andrehoffmann.website
quit: 221 2.0.0 Bye
Unable to send email using PHP SMTP. Your server might not be configured to send mail using this method.From: andre_guilherme@msn.com
Subject: Ordem de Serviço - Criada
To: andguihofros@gmail.com
Acontece que o serviço de SMTP está ativo.
Poderia me ajudar?

source: gharchive/issue

license_type: permissive

license_source: github-api


text:
I get IPFS module not found no fresh install

webrun
internal/modules/cjs/loader.js:800
    throw err;
    ^

Error: Cannot find module 'ipfs'
Require stack:
- /Users/gozala/Projects/archivist/node_modules/@rangermauve/webrun/src/plugins/ipfs.js
- /Users/gozala/Projects/archivist/node_modules/@rangermauve/webrun/src/index.js
- /Users/gozala/Projects/archivist/node_modules/@rangermauve/webrun/bin/cli.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:797:15)
    at Function.Module._load (internal/modules/cjs/loader.js:690:27)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/Users/gozala/Projects/archivist/node_modules/@rangermauve/webrun/src/plugins/ipfs.js:4:14)
    at Module._compile (internal/modules/cjs/loader.js:959:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Function.Module._load (internal/modules/cjs/loader.js:727:14)
    at Module.require (internal/modules/cjs/loader.js:852:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/gozala/Projects/archivist/node_modules/@rangermauve/webrun/src/plugins/ipfs.js',
    '/Users/gozala/Projects/archivist/node_modules/@rangermauve/webrun/src/index.js',
    '/Users/gozala/Projects/archivist/node_modules/@rangermauve/webrun/bin/cli.js'
  ]
}

Were there any error during install? It should be loading js-ipfs. Though stuff may have broken since I last visited this module. 😰

I have not noticed any errors during install, but I was not paying attention to be honest. For what it's worth I would really like if plugins like Dat or IPFS where things you could add instead of having those baked inn.
All I really want I suppose is a drop-in replacement for https://deno.land/.

Yeah! I agree. I was thinking it'd be cool to have a list of webrun-plugin-*s that the default would attempt to load and ignore silent fails.

You know what. I can't focus on real work right now so I'll spend a bit of time getting that together to warm up. 💜

Making progress on this. Try version 3.0.2 in the meantime.

K, I've taken out the IPFS and Dat plugins into separate modules.
https://github.com/RangerMauve/webrun-plugin-ipfs
https://github.com/RangerMauve/webrun-plugin-dat
Try installing version 4.0.0. 😁

authors: Gozala RangerMauve

repo: RangerMauve/webrun

license: MIT


text:
Remplir les champs obligatoire

Vous devriez remplir tous les champs ayant une étoile comme étiquette lors de vos inscription sur le site de biblioplus.

Pré-conditions: Un visiteur veut être membre de Biblioplus et décide de créer un compte.
Déclencheur: Le visiteur clique sur le bouton "créer un compte".
Déroulement: Le visiteur  remplie les champs qui sont affichés par Biblioplus  pour qu'il puisse être membre et  clique sur "Enregistre" pour mettre fin a la transaction.

Si le visiteur clique sur "Enregistre",  et  que tous les champs ne sont pas complètement remplis un message s'affichera par Biblioplus lui demandant de remplir tous les champs vide.
Si le visiteur clique sur "Enregistre", et que c'est complément  rempli Biblioplus affichera un message indiquant au visiteur d'aller confirmer son compte sur l'email qu'il avait donné.

Post-condition:" Ouvrage enregistrer"


text:
rest api error

from future import absolute_import
from future import division
from future import print_function
from future import unicode_literals
import logging
from rasa_core.channels.channel import InputChannel
from rasa_core import utils
from rasa_core.agent import Agent
from rasa_core.interpreter import RasaNLUInterpreter
from rasa_core.channels.channel import UserMessage
from rasa_core.channels.channel import CollectingOutputChannel
from rasa_core.channels import RestInput
from flask import Blueprint, request, jsonify
logger = logging.getLogger(name)
class SimpleWebBot(RestInput):
"""A simple web bot that listens on a url and responds."""

def blueprint(self, on_new_message):
    custom_webhook = Blueprint('custom_webhook', __name__)

    @custom_webhook.route("/status", methods=['GET'])
    def health():
        return jsonify({"status": "ok"})

    @custom_webhook.route("/", methods=['POST'])
    def receive():
        payload = request.json
        sender_id = payload.get("sender", None)
        text = payload.get("message", None)
        out = CollectingOutputChannel()
        on_new_message(UserMessage(text, out, sender_id))
        responses = [m["text"] for _, m in out.messages]
        return jsonify(responses)

    return custom_webhook

def run(serve_forever=True):
#path to your NLU model
interpreter = RasaNLUInterpreter("models/nlu/default/current")
# path to your dialogues models
agent = Agent.load("models/dialogue", interpreter=interpreter)
#http api endpoint for responses
input_channel = SimpleWebBot()
if serve_forever:
    agent.handle_channels(InputChannel(5005, "/chat", input_channel))
return agent

if name == 'main':
utils.configure_colored_logging(loglevel="INFO")
run()

the above code giving the below response

Thanks for the question, our Github issue board is for bugs and feature requests only, though 😕
Please ask this question in the forum✨
If you were describing a bug, please create a report and fill out the template

authors: mlcode-jeevan sara-tagger

repo: RasaHQ/rasa


text:
default intents should not raise undefined parsing error

these aren't defined in the domain, but they are valid intents, and should not log an error. In addition, I think if you add default intents to your domain it might actually break things... (unconfirmed)
Your input ->  /restart
2019-11-01 11:50:14 WARNING  rasa.core.processor  - Interpreter parsed an intent 'restart' that is not defined in the domain.
Your input ->  /back
2019-11-01 11:50:32 WARNING  rasa.core.processor  - Interpreter parsed an intent 'back' that is not defined in the domain.
Your input ->

Hi @erohmensing , following function in rasa/core/processor.py contains this feature.

These are valid intents but rasa shows them as warnings. If any developer forget them to add in domain.yml. I suggest it should be there, its very helpful specially in the last moment.

If you add default intents to your domain.yml, it didn't break things.

def _log_unseen_intent(self, parse_data: Dict[Text, Any]) -> None:         """check if the NLU picks up intent that aren't in the domain.         """         intent = parse_data["intent"]["name"]         if intent and self.domain and intent not in self.domain.intents:             logger.warning(                 "Interpreter parsed an intent '{}' "                 "that is not defined in the domain.".format(intent)

My suggestion here is that you shouldn't have to add the valid default intents to the domain in order to get them to work (this is the case right now). So it would be nice if _log_unseen_intent would take those intents (e.g.restart, back) into account as well as those in self.domain.intents.

This can be taken care of in the code.

Would love for you to contribute a PR for it!


text:
add condition in sql/mongo tracker store in additional_events when retrieve_events_from_previous_conversation_sessions is true

Proposed changes:

closes https://github.com/RasaHQ/rasa/issues/8238
closes https://github.com/RasaHQ/rasa/issues/8237
fix calculation of _additional_events when retrieve_events_from_previous_conversation_sessions=true

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[x] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

I parametrized the existing tests to confirm same behaviour - is there another side that should be tested?

tests/core/test_evaluation.py::test_e2e_with_entity_evaluation is failing although it passes locally; can it be because the timeout for the test (240)  is longer than the timeout for the pytest session (120s)?

source: gharchive/pull-request


text:
Passing custom payload when handling message / text to retrieve in action

Rasa Core version: >=0.11.12
Python version: 3.6.6
Operating system (windows, osx, ...): Windows
Issue: Is there any way of passing custom payload when handling / parsing a message that I can retrieve from for example the tracker during the custom action?
I have some additional information which I need when actions are happening.
Basically I would like to:
Use handle_message / text, pass any kind of container as payload as well as the message.
in the custom action retrieve the payload object and utilize the information.
Content of domain file (if used & relevant):

Just to clarify, do you want to pass this custom payload with the bot message or with the user message?

With the user message.
To be more clear, something like:
agent.handle_message(UserMessage(text="Hello World", sender_id="Testperson1", payload={"additional_information:" additional_information_object}))
or
agent.handle_text("Hello World", payload={"additional_information:" additional_information_object})
So I can retrieve that additional_information_object from the tracker of the custom action for example.

i don't think this is something we'll add, how would you know which payload to send with which user message?

In my case I don't get the messages directly. They're coming in asynchronous with information about channel / user / permissions / respond where / etc.. I can work around it and build a temporary storage then map the payload with the message + sender_id to identify it, the hassle will be with the lifetime of that temporary stored object as only some messages trigger actions, so I figured I'd ask if there's a way that would save me some headache :)

Yeah I think that's something you need to handle in your custom implementation then. As of now this is not something we'll be adding

license_source: bigquery


text:
XMPP support

Currently there is facebook, slack, telegram, mattermost and twilio connections.
This is good, however lots of organisations also run XMPP servers. Do you plan to add such a channel?

Does XMPP provides an API to integrate their chatroom?

It is possible to access XMPP servers using BOSH protocol.
Multiple python client implementations exists like Sleekxmpp which in my opinion would be better to implement directly as all administrators do not activate BOSH interface.

If you have the time, feel free to create a PR for it :)

authors: Priprocks akelad tigre-bleu


text:
Duckling Component

Proposed changes:

adds duckling support to pipelines (found entities will be normalized (e.g. dates or numbers) if they are found as an entity)
new config value duckling_processing_mode (either duckling entities replace only value of already found entities or new entities only found by duckling will be appended to the list returned entities)

Status:

[x] ready for code review
[x] documentation updated
[x] changelog updated

will ner_duckling classify any of it's pre-named entities in the users speech, or do I need to add training data with exemples for that entity?

authors: anaportela tmbo


text:
🛑 GiteeSite is down

In c5b0567, GiteeSite (https://ravelloh.gitee.io) was down:

HTTP code: 0
Response time: 0 ms

Resolved: GiteeSite is back up in a86d793.

repo: RavelloH/sitemonitor


text:
Projectile logic

I usually really dislike projectiles (bullets/hook) having much logic in them and prefer limiting their functionality to just visuals like animation and particles. Shooter would contain all the logic of actually moving, colliding, hitting, etc. It can be located in a separate component inside the Shooter.
The reason is that the logic of those 2 things is inherently VERY closely integrated. You will certainly end up passing a lot of data between the two, like speed and damage.
For example damage cannot be easily changed when it is in the bullet, making upgrades and buffs more complicated. Basically, you are forcing yourself to do something like bullet.damage = damage for each and every parameter stored in the bullet that might need to be changed.
You also might need to communicate from bullet back to shooter, for example if you want heal-on-dealing-damage mechanic, forcing you to create some bullet events.
There is, however, one issue with this: if the entity gets destroyed while it still has bullets flying, ShooterComponent will also get forcefully freed, leaving all those bullets without logic. This might be fixed by simply delaying entity destruction for long enough, perhaps by setting the minimum delay timer from ShooterComponent directly. It's quite simple since you already have destruction delay.
At the very least i would do this for the hook, since it doesn't even suffer from above problem.
I am not 100% sure this a good approach for shooters though. There are other solutions as well.
Bundling things in packages helps a lot, for example shooter can put entire HealthComponent.ChangePackage objects into the bullet, passing everything that health system supports.
Or having some sort of StatContainer component, that would be used by shooter, passed into bullet, and maybe even used by other components. Then, in order to upgrade the entity you wouldn't even need to find any specific components. However, all those stats will have to rely on arbitrary magic strings, which you will have to use basically everywhere.

Nah, this rant was mostly nonsense

repo: RavioliMavioli/malware-slayer


text:
Fix deprecations, and preserve selections when commenting

I also made a small semantic tweak so that string concatenation isn't used for negation.

Fixes #9 #10 #11 #12

repo: RayKwon/atom-block-comment

license: mit


text:
Pepsi

Description
Description of the project here
Code of Conduct

[X] I follow Contributing Guidelines of this project.

/assign

repo: Rayman-Sodhi/Clone-IT


text:
Sandbox

Morning;
I got erro for  Sandbox;
using CC;

Using FPX;

When users from other countries, for example malaysia want to make a payment... they can't use FPX?
thanks;

hi @msazzree , please share us the Merchant ID u test and screenshot the settings for the plugin

hi @msazzree , please share us the Merchant ID u test and screenshot the settings for the plugin

hi @msazzree , based on the screenshot given, it seems like you are using the Production Merchant ID (verityintellige), please change the dropdown for Account Type from Sandbox to Production

hi manage to get sandbax account;
i try make payment using VISA card, but after click continue i got error as below;

hi @msazzree , you need to disable sequential ordering plugin if you do not install it

if yes you need to enable cookie in http header for wordpress, because by default it is disabled

authors: msazzree wankimmy


text:
Adventure card not showing adventure

Describe the bug
On the web side in Deck list, adventures cards are showing like simple creature in image and description. Without any mention of the adventure.
Example :
https://mtgarena.pro/cards/function toLowerCase() {    [native code]}/murderous-rider-swift-end-eld-97/
Correct card :
https://gatherer.wizards.com/Pages/Card/Details.aspx?multiverseid=473059

Not sure if double cards have the same problem

repo: Razviar/mtga-pro-tracker


text:
打卡失败，控制台提示以下信息

之前都是正常的

看着像是 from Crypto.Cipher import DES3 导包时，包内部的错误，错误重试应该就没事了

重新获取设备ID和用新的scf包重新上传都试过了，还是不行，求解答
------------------ 原始邮件 ------------------
发件人: @.>;
发送时间: 2022年1月6日(星期四) 上午9:49
收件人: @.>;
抄送: @.>; @.>;
主题: Re: [ReaJason/17wanxiaoCheckin] 打卡失败，控制台提示以下信息 (Issue #73)
看着像是 from Crypto.Cipher import DES3 导包时，包内部的错误，错误重试应该就没事了
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: @.***>

看着像是 from Crypto.Cipher import DES3 导包时，包内部的错误，错误重试应该就没事了

重新获取设备ID和用新的scf包重新上传都试过了，还是不行，求解

你如果还是报这个错误的话，尝试打开 src/Crypto/Cipher/init.py 看第 36 行，Cipher 有没有多余的空格删掉

确实多了个空格，解决了，感谢！

authors: Oiaslly ReaJason


text:
After updating react-tooltip package version from "4.2.21" to "5.19.0" it throws many mjs errors

If this is a bug or a Feature request reported using this template, we will close this issue, for those, please use the correct template.
This will be handled as a Question.
Hi team , I have recently updated react-tooltip package from 4.2.21 to 5.19.0 and I am encountering many errors when i run "npm run webpack" , could someone please help me with it . Attaching my package.json file for package reference
{   "name": "DirectorUI",   "version": "3.1.0",   "private": true,   "scripts": {     "preinstall": "npx npm-force-resolutions@0.0.3",     "app": "http-server ./",     "newapp": "cd server && npm run devserver",     "webpack": "npm run lint && npm test && webpack",     "webpackDev": "webpack",     "buildViews": "babel ./ui/ --out-dir ./uiBuild/ --watch",     "less": "lessc ./css/style.less ./css/style.css && lessc ./newcss/style.less ./css/director.css",     "lessMin": "lessc --clean-css ./css/style.less ./css/style.css && lessc --clean-css ./newcss/style.less ./css/director.css",     "lessSpinnerMin": "lessc --clean-css ./css/cc-spinner.less ./css/cc-spinner.css",     "lint": "eslint ./ui",     "fixESlint": "eslint --fix ./ui ",     "runESlint": "eslint ./ui > esLint.out",     "htmlESlint": "eslint ./ui -f html > eslintreport.html",     "loc": "sloc ./ui ./locales ./css --exclude ./css/font-awesome --format cli-table",     "buildLodash": "lodash include=debounce,throttle --output ./ui/common/lodash.js -m",     "test-jest": "jest ./ui/test/main.test.js --config=jestOld.config.js > unit_testing_results_jest.txt --colors",     "test-coverage": "jest --coverage ./ui/test/main.test.js --config=jestOld.config.js",     "test-watch": "jest ./ui/test/main.test.js --config=jestOld.config.js > unit_testing_results.txt --colors --watchAll",     "test:update": "jest --updateSnapshot",     "jestTeamCityIntegration": "jest ./ui/test/main.test.js --config=jestOld.config.js SET TEAMCITY_VERSION=1 && webpack",     "newTests": "jest --runInBand --config=jest.config.js",     "oldTests": "jest ./ui/test/main.test.js --config=jestOld.config.js --silent",     "test": "npm run newTests && npm run oldTests"   },   "resolutions": {     "unset-value": "2.0.1",     "glob-parent": "5.1.2"   },   "dependencies": {     "@cas/cas-ui-utils": "1.2.41",     "@citrix/rdx": "^3.0.0",     "@citrixgs/g11n-sdk-react": "~22.16.2",     "axios": "0.27.2",     "canvas": "^2.11.2",     "classnames": "2.2.5",     "fixed-data-table-2": "^0.8.13",     "flux": "^4.0.3",     "highcharts": "9.3.3",     "lodash": "4.17.21",     "lodash.clonedeep": "^4.5.0",     "lodash.debounce": "^4.0.8",     "lodash.defer": "^4.1.0",     "lodash.orderby": "^4.6.0",     "moment": "2.29.2",     "moment-timezone": "0.5.21",     "npm-force-resolutions": "0.0.10",     "rdx": "2.5.1",     "react": "^17.0.2",     "react-datetime": "^2.8.10",     "react-dom": "^17.0.2",     "react-microservice-app": "^1.2.25",     "react-router-dom": "5.3.3",     "react-tooltip": "5.19.0",     "react-transition-group": "2.9.0",     "semantic-ui-react": "^2.1.4",     "serve-favicon": "~2.4.1",     "validator": "13.7.0"   },   "devDependencies": {     "@babel/cli": "^7.22.9",     "@babel/core": "^7.22.9",     "@babel/helper-function-name": "^7.22.5",     "@babel/plugin-proposal-class-properties": "^7.0.0",     "@babel/plugin-proposal-decorators": "^7.22.7",     "@babel/plugin-proposal-export-namespace-from": "^7.0.0",     "@babel/plugin-proposal-function-sent": "^7.22.5",     "@babel/plugin-proposal-json-strings": "^7.0.0",     "@babel/plugin-proposal-numeric-separator": "^7.0.0",     "@babel/plugin-proposal-throw-expressions": "^7.22.5",     "@babel/plugin-syntax-dynamic-import": "^7.0.0",     "@babel/plugin-syntax-import-meta": "^7.0.0",     "@babel/polyfill": "^7.12.1",     "@babel/preset-env": "^7.22.9",     "@babel/preset-react": "^7.22.5",     "babel-core": "^7.0.0-bridge.0",     "babel-eslint": "^10.1.0",     "babel-jest": "^28.1.3",     "babel-loader": "^8.3.0",     "babel-plugin-add-module-exports": "^0.2.1",     "babel-plugin-styled-components": "1.5.1",     "copy-webpack-plugin": "^6.4.1",     "core-js": "2.6.12",     "css-loader": "0.28.9",     "debug": "^2.6.6",     "enzyme": "^3.11.0",     "enzyme-adapter-react-17-updated": "^1.0.2",     "eslint": "^7.32.0",     "eslint-plugin-react": "7.30.0",     "eslint-plugin-react-hooks": "^4.6.0",     "expect": "^1.20.2",     "http-server": "^14.1.1",     "jest": "^28.1.1",     "jest-cli": "28.1.1",     "jest-environment-jsdom": "28.1.1",     "jest-enzyme": "7.1.2",     "jest-teamcity-reporter": "^0.9.0",     "jsdom": "19.0.0",     "jsdom-global": "3.0.2",     "less": "4.1.3",     "less-plugin-clean-css": "^1.5.1 ",     "react-test-renderer": "17.0.2",     "regenerator-runtime": "^0.13.11",     "shortid": "^2.2.14",     "sinon": "^2.2.0",     "sloc": "0.2.1",     "string.prototype.replaceall": "^1.0.7",     "style-loader": "0.18.2",     "terser-webpack-plugin": "4.2.3",     "url-loader": "0.5.9",     "webpack": "4.46.0",     "webpack-cli": "^4.9.2"   } }

Tried version 5.18.0 still facing the same result.

Please check out this answer on StackOverflow
https://stackoverflow.com/a/65982614/7731997
It relates to a ruby on rails setup, but maybe adding this rule to webpack configuration solves your issue.
environment.config.merge({
  module: {
    rules: [
      {
        test: /\.mjs$/,
        include: /node_modules/,
        type: "javascript/auto"
      }
    ]
  }
})

If it doesn't work, also try upgrading webpack to the latest version and let us know.

It worked, thank you @gabrieljablonski :) .

repo: ReactTooltip/react-tooltip


text:
Update redux state via API call with location change

Hi, I'm a bit new to this whole routing stuff with react-router. If I may, I would love to get a solution for my following problem that I'm facing. So here it comes.
I want to create a search function that replace the URL path every time I submit the new keyword (e.g. if I search for keyword cat, the URL will be /search/cat). It works when I do that and the API call will fire to display the search results of the keyword. But then, I search for another keyword, (e.g. dog), API call is fired, results are displayed, nice! Then here is where I start to be confused (apology for my noob-ness). I want the user to be able to press back button, which in the example that I mentioned, will go from /search/dog to /search/cat. I managed to change the URL properly but I'm not really sure how to update the search results back to cat. Please, any help will do me a great favor....
Thank you in advance. 🙇

This is a bug tracker, not a support system. For usage questions, please use Stack Overflow or Reactiflux where there are a lot more people ready to help you out. Thanks!

authors: alamchrstn timdorr

repo: ReactTraining/react-router


text:
match not helpful under HashRouter.

match is not informative with HashRouter. It strips the anchor tag information out, which is of course, the route, if you are using HashRouter. path is always '/'. true, but not helpful.
Any way you can provide the hash route for match under HashRouter?

That is not how HashRouter functions. You are likely using it incorrectly. Post some examples of how you're using it on Stack Overflow or Reactiflux.

authors: bingomanatee timdorr


text:
Document generatePath function

I've created PR. Let me know if something should be changed.
Any comments are appreciated. 👨💻

How about documenting the fact that params keys can be null if they are optional in the route?
E.g.
```jsgeneratePath('/user/:id/:action?', { id: 1, action: null }); // Will generate /user/1 withoutaction`, sinse action is optional in the path
``

I think that's a good start. Thanks!

authors: ElForastero timdorr


text:
ToObservable missing in dotnetcore?

Hi all,
For some reason I can't seem to get ToObservable working in dotnetcore? I've tried all the following usings:
using System.Reactive;
using System.Reactive.Linq;
using System.Reactive.Concurrency;
using System.Reactive.Disposables;
using System.Reactive.Subjects;
The compiler is complaining that ToObservable doesn't exist.
        var t = Enumerable.Range(1,10).ToObservable();

Any ideas?

I found the answer here:
http://stackoverflow.com/questions/38264418/observable-class-and-toobservable-missing-from-system-reactive-3-0
need to install System.Reactive as a separate package.

not sure how to close this.


text:
Add Single, Maybe and Completable

RxJava 2 has the concept of Single, Maybe and Completable. They got quickly adopted by RxSwift 3.3.0.
I couldn't find anything about those reactive types in rxjs. Are they planned?

No, it's not planned. It is not a goal of v5 to create full-compliant operator set to other languge bindings or even v4, and there are some added opeator or dropped operator between. Once there is suffecient usecase and demand it can be obviously discussed in further.

I'm also not sure I would look to RxJava for inspiration. Java is severely lacking in expressive power, even with its recent editions. JavaScript has long had better expressiveness as have most other languages.

I'm closing this issue for now, haven't got subsequent details of operator to initiate discussion to be included in core sets. If this operator seems need to be included in core operator sets, please refer https://github.com/ReactiveX/rxjs/issues/2299 and https://github.com/ReactiveX/rxjs/pull/2524 as starting baseline to include details for discussions.

Just want to make sure this issue didn't got closed accidentally. It's not about new operators. It's about other base classes besides Observable
-Observable: 0..N flows, no backpressure

Single: a flow of exactly 1 item or an error
Completable: a flow without items but only a completion or error signal
Maybe: a flow with no items, exactly one item or an error

@passsy yes, while attached references are saying only about operators, you can consider same for any other cases like this one, or either removing, changing existing operator behavior as well. There is no big differences of having new operator, or either new base class in perspective of discussing it to add into core set.

If y'all are open to a bit of discussion on the topic, I do think there are use cases for a type analogous to RxJava's Completable:

Represents a deferred computation without any value but only indication for completion or exception.

That said, the workaround isn't too bad right now, one can (assuming the stream is hot) filter all of the values (e.g. .filter(() => true)).
Example use case
In a redux-observable epic, if you want to dispatch an event after some chain of other actions.
A bit of setup using the example they have on their website:
const PING = 'PING';
const PONG = 'PONG';

const ping = () => ({ type: PING });

const pingEpic = action$ =>
  action$.ofType(PING)
    .delay(1000)
    .mapTo({ type: 'PONG' });

const pingReducer = (state = { isPinging: false }, action) => {
  switch (action.type) {
    case 'PING':
      return { isPinging: true };

    case 'PONG':
      return { isPinging: false };

    default:
      return state;
  }
};

Now if you wanted to dispatch an action after count number of PONG actions have occurred:
const START_ROUND_TRIPS = 'START_ROUND_TRIPS';
const END_ROUND_TRIPS = 'END_ROUND_TRIPS';

const endRoundTrip = (count) => ({type: END_ROUND_TRIPS, payload: {count}})

const roundTripEpic = action$ =>
  action$.ofType(START_ROUND_TRIPS)
    .concatMap((action) => Observable.concat(
      Completable.from(action$.ofType(PONG).take(action.payload.count)), // Up for discussion
      Observable.of(endRoundTrip(action.payload.count))
    ))

It's important that the inner observable not actually contain the actions$.ofType(PONG) values because that would re-dispatch those actions. It's arguable whether this is preferable over .filter(() => true) (I think it's a touch more readable) but I do think is a use case.

@passsy @whymarrh isn't this already possible w/ the single(), defaultIfEmpty() and ignoreElements() operators?

(I had forgotten about ignoreElements(), that works better than the .filter(() => true), thanks!)

[I]sn't this already possible w/ the single(), defaultIfEmpty() and ignoreElements() operators?

Some combination of those work as a replacement for a hypothetical Completable, yup.

From a pure technical point of view one might argue that a completeable is unnecessary since an observable can be used for the job.
However when designing an api it is useful to know whether 0, 1 or N objects can be emitted by a stream. While this should be documented in the jsdoc or javadoc, knowing that by looking at the class of stream makes it a lot easier. It is also useful if those classes enforce those cardinality-constraints so you don't accidentally break your api-contract.
As the rx guy in our team I would also like to point out that there is a barrier of entry you tend to forget about when having worked with rx for some time. Having classes that are called completable, single and maybe - even if they are all essentially observables under the hood - is much easier for rx beginners to understand and work with.

You can simple create the objects in next releases, is useful to have them for some cases and also makes the code more readable (knowing for what a Completeable, Single and a Maybe are for)

@trxcllnt Just wanted to point out something. Yes, all of this is possible with combinations of single(), defaultIfEmpty() and ignoreElements(). But I guess having types like Single, Maybe and Completable isn't about runtime expressiveness. It is about what they convey in the type system: why have only void when you can also have null, undefined, never, etc. Whether they should be expressed as classes or type alias is another problem (I'd bet on type alias however).

Would it be possible to revisit this? I think @WowMuchName makes some compelling points. Personally I have found that using Observables as Singles, while technically possible, creates ambiguity and leads to bugs.

+1 on this, Single/Maybe and Completable make it more understandable and maintainable by explicitly saying what behavior you'll have. Having just Observable is for me as bad as saying Any on return type of a method, you don't know what you'll have except if you actually look the implementation...

authors: WowMuchName aluanhaddad darkyelox jaumard kwonoj passsy ptitjes sawthompson trxcllnt whymarrh

repo: ReactiveX/rxjs


text:
Lazy version of withLatestFrom

Feature Request
Is your feature request related to a problem? Please describe.
There are many use cases for delaying evaluation of the arguments to withLatestFrom. A common example is in NgRx, where there might be effect like so:
createEffect(() => this.actions$.pipe(
  ofType(c),
  withLatestFrom(this.store.select(getSelectedBookId)),
  switchMap(([action, selectedBookId]) => this.bookService.getDetails(selectedBookId).pipe(
    map(...),
    catchError(...)
  )
);

When the arguments to pipe are evaluated, so is this.store.select. In NgRx, performing a select has memory and performance implications.
Ideally, then, because we don't care about the values from the observable produced by this.store.select(getSelectedBookId) until we receive an action of type this.store.select(getSelectedBookId), we could do something like:
createEffect(() => this.actions$.pipe(
  ofType(c),
  concatMap(action =>
      of(action).pipe(
      withLatestFrom(store.select(someThing))),
  withLatestFrom(this.store.select(getSelectedBookId)),
  switchMap(([action, selectedBookId]) => this.bookService.getDetails(selectedBookId).pipe(
    map(...),
    catchError(...)
  )
);

Describe the solution you'd like
Create an operator which is functionality equivalent to the solution above to delay evaluation of withLatestFrom.
(If this is new operator request) describe reason it should be core operator
I'm not confident it should be. The use case may be too specific to NgRx, hence why https://github.com/ngrx/platform/issues/2222 is open on their platform.
However, if it is common that other types of observables should be delayed when using withLatestFrom, then this may be worthy of a core operator.

Also fitting this use case is this potential operator: https://gist.github.com/sod/a34fc7705b396f61d0ef00713b807209

Introduced a PR to NgRx for now. If it looks like it belongs here instead, tell me https://github.com/ngrx/platform/pull/2760

I think all you want to do is put your "other sources" in a defer:
createEffect(() => this.actions$.pipe(
  ofType(c),
  withLatestFrom(defer(() => this.store.select(getSelectedBookId))), // <---- here
  switchMap(([action, selectedBookId]) => this.bookService.getDetails(selectedBookId).pipe(
    map(...),
    catchError(...)
  )
);

I'll close this for now, but feel free to reopen if that's not what you're after.

@benlesh defer only delays evaluation until subscription. The purpose of the operator is to defer evaluation until the last moment it is needed, when the operator is called to transform some value. This spec defines the desired behavior: https://github.com/ngrx/platform/pull/2760/files#diff-65f81e5d2793f31b4cc23991c7068b1dcd0a8b327be69f0c195aebc1f5c96ea3R24-R36

authors: benlesh david-shortman


text:
Update observable.md

Consistency in comparison table.

Description:
Minor improvement in the documentation.

Coverage remained the same at 97.644% when pulling 23e31df5cbfac2384e1feca37b07cf7f3a13b120 on rzymek:patch-1 into e38711379f357f55290ead7fabcf8c70c5b31961 on ReactiveX:master.

LGTM, I would just merge right ahead if I had the rights

@staltz thought you already have it?

I had and Ben sort of removed it I guess

authors: coveralls kwonoj rzymek staltz


text:
Property overrides and bug fixes.

Issue #54: Curator ServiceManager has no default instances.
Issue #55: Property overriding.

Verified by @greglarious.

repo: ReadyTalk/cultivar


text:
dev to main sync

Date: 23-11-2023
Developer Name: @shubhamsigdar1
Issue Ticket Number:-

https://github.com/Real-Dev-Squad/website-status/issues/1014
https://github.com/Real-Dev-Squad/website-status/issues/1012

PR Number(s):-

https://github.com/Real-Dev-Squad/website-status/pull/1013
https://github.com/Real-Dev-Squad/website-status/pull/1011

Is Under Feature Flag

[ ] Yes
[X] No

Database changes

[X] Yes
[ ] No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

[ ] Yes
[x] No

Is Development Tested?

[x] Yes
[ ] No

Tested in staging?

[x] Yes
[ ] No

Add relevant Screenshot below
https://github.com/Real-Dev-Squad/website-status/assets/107163260/edf452b7-2aae-4a50-8235-5c0e348af786

Date: 23-11-2023
Developer Name: @ajoykumardas12
Issue Ticket Number:-

https://github.com/Real-Dev-Squad/website-status/issues/999

PR Number(s):-

https://github.com/Real-Dev-Squad/website-status/pull/1010

Frontend Changes:

[x] Yes
[ ] No

Backend Changes:

[ ] Yes
[x] No

Feature Flag:
This change affects both features under feature flag and out of feature flag.
Dev Tested:

[x] Yes
[ ] No

Tested in staging?

[x] Yes
[ ] No

Add relevant Screenshot below
https://github.com/Real-Dev-Squad/website-status/assets/107163260/edf452b7-2aae-4a50-8235-5c0e348af786

Staging Proof for #1032
Date: 03-12-2023
Developer Name: @ajoykumardas12
Issue Ticket Number:-

#1029

PR Number(s):-

#1032

Frontend Changes:

[x] Yes
[ ] No

Backend Changes:

[ ] Yes
[x] No

Feature Flag:
This PR takes a feature(#935 ) out of feature flag.
Dev Tested:

[x] Yes
[ ] No

Tested in staging?

[x] Yes
[ ] No

Staging Proof
https://github.com/Real-Dev-Squad/website-status/assets/87164140/19b97973-d5e1-4fca-973e-ce05edae3a9a

Date: 03-12-2023
Developer Name: @ardourApeX
Issue Ticket Number:-

https://github.com/Real-Dev-Squad/website-status/issues/996

PR Number(s):-

https://github.com/Real-Dev-Squad/website-status/pull/1018
https://github.com/Real-Dev-Squad/website-status/pull/1024
https://github.com/Real-Dev-Squad/website-status/pull/1026
https://github.com/Real-Dev-Squad/website-status/pull/1028
https://github.com/Real-Dev-Squad/website-status/pull/1034

Dev Tested:

[x] Yes

Under Feature Flag:

[x] Yes

Frontend Changes:

[x] Yes

Staging Proof

repo: Real-Dev-Squad/website-status


text:
Обновить инфу и данные

Чайник, привет!
Можно попросить тебя пофиксить сайт?
Новый ip (213.32.8.157) для карты и статуса сервера + игроков онлайн (кстати, для удобства ip можно заменить на play.bbyaworld.com:25565 - а я через регистратора буду привязку к ip делать).

версия 1.11.2

Новый ip (213.32.8.157) для карты и статуса сервера + игроков онлайн (кстати, для удобства ip можно заменить на play.bbyaworld.com:25565 - а я через регистратора буду привязку к ip делать).

Кажется, так было сделано с самого начала.
Остальное сделаю по мере возможности, времени и сил.

authors: Red-Teapot VELLEVET


text:
[IVANCHUK] Add translations for ivanchuk

@simaishi

@martinpovolny @himdel please review

authors: mzazrivec simaishi


text:
Device groups: Get all device groups.

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # THEEDGE-1588
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

Checklist:

[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] I run go fmt ./... to check that my code is properly formatted
[X] I run go vet ./... to check that my code is free of common Go style mistakes

Codecov Report

Merging #590 (d5fedaf) into main (68d6ffc) will decrease coverage by 0.02%.
The diff coverage is 28.78%.

@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
- Coverage   30.20%   30.17%   -0.03%
==========================================
  Files          34       36       +2
  Lines        3523     3589      +66
==========================================
+ Hits         1064     1083      +19
- Misses       2315     2355      +40
- Partials      144      151       +7

Impacted Files
Coverage Δ

pkg/services/devicegroups.go
0.00% <0.00%> (ø)

pkg/routes/devicegroups.go
42.22% <42.22%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d6ffc...d5fedaf. Read the comment docs.

authors: codecov-commenter ldjebran

repo: RedHatInsights/edge-api


text:
Fixed issue #455

Description
Fixed issue #455
Fixes #455
Type of change

Bug fix (non-breaking change which fixes an issue)
Documentation update

Testing steps
N/A

Codecov Report

Merging #461 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   80.56%   80.56%
=======================================
  Files          15       15
  Lines        1636     1636
=======================================
  Hits         1318     1318
  Misses        221      221
  Partials       97       97

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b11f1...ee22082. Read the comment docs.

authors: codecov-commenter tisnik


text:
Add dvo-writer to pr-check

Description
Fixing the pr-check CI job for https://github.com/RedHatInsights/insights-results-smart-proxy/pull/1210 because dvo-writer is now a dependency for aggregator.
Type of change

Bug fix (non-breaking change which fixes an issue)

Testing steps
CI.
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b704b51) 70.85% compared to head (7bec1b8) 70.85%.

:exclamation: Current head 7bec1b8 differs from pull request most recent head a1e61dc. Consider uploading reports for the commit a1e61dc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1213   +/-   ##
=======================================
  Coverage   70.85%   70.85%
=======================================
  Files          25       25
  Lines        3768     3768
=======================================
  Hits         2670     2670
  Misses        828      828
  Partials      270      270

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

authors: codecov-commenter juandspy


text:
Add Images tab with table to Cluster detail page

https://issues.redhat.com/browse/RHINENG-8289
Mockups: https://www.figma.com/file/LN2itBiyx8gr2aufrSib8U/💻Vulnerability-for-OpenShift?type=design&node-id=12%3A4265&mode=design&t=BfWshx27SBozXkwa-1
What was changed:

split page header and table store into two in Cluster detail page
renamed cluster detail table to cluster cve table and created a second table on cluster detail page -- cluster images table along with its store
split cluster detail table into two routes -- /cves and /images -- one for each active tab
generalized NoMatchingClusters empty state to NoMatchingItems where parent component can choose what kind of item is displayed in the empty state
fixed TextFilter to clear its text when filters are reset

Actual results:

@mkholjuraev I have addressed all of your comments -- the main change is the creation of TableTabs which isolates tabs implementation from ClusterDetailPage

When the table is empty, sorting is not disabled. This does not affect the UI at all, but other apps disable sorting.
I will address this in a separate PR, thank you!


text:
Flaw References and Comments support

Added support for Flaw References and Flaw Comments via OSIDB entities.
This PR should be coordinated with PR which brings additional functionality into OSIDB bindings.

lgtm ... might be worth including as a separate commit to this PR - bump python cryptographic module (as per github reported vuln)

LGTM - can we also bump cryptographic module as per github reported vuln ?

definitely, will add that

authors: JakubFrejlach JimFuller-RedHat

repo: RedHatProductSecurity/griffon


text:
Normalization/simplification function

I want a function similar to what we call "normal" in cubicaltt. The purpose of this function is to normalize/simplify terms as far as possible, this means that it has to go under binders, unfold all definitions and compute all coe/hcom's as far as possible.
This is very useful for seeing how complicated definitions really are. I've found many things in cubicaltt that look innocent on the surface but once you start unfolding things you see that they are really complicated because they contain coe/hcom's in complicated types that unfold to a lot more hcom/coe's.
Another very useful thing with this kind of function is that they can be used to debug the system. If I have a term t : T in cubicaltt I can normalize/simplify it to get t', I can then ask the typechecker if t' : T. If this fails then I know that there is a bug somewhere and we managed to find a lot of bugs this way by doing this for the term inhabiting the type of the univalence axiom. In RedPRL we can probably not do exactly the same, but it might be that the heuristics are powerful enough to see that "t' : T" in many cases?
Note that it might be necessary for such a normalization/simplification function to be type-directed in RedPRL in order for things like (@ p 0) to reduce.

I think it would be nice to expose some sort of Eval Foo. (for non-stable closed-term evaluation) and Reduce Foo. (for stable reduction under binders) at the top level. Currently you can use the reduce tactic to play around with this inside a proof.
Some of what you are saying is not possible:

auto cannot always prove t : T, so it certainly cannot always prove t' : T for the value t' of t.
Types are not unique so you can't really have a type-directed simplification procedure. I think what you have in mind is reduce plus some fragment of auto. For example, given (@ p 0), p might be a variable of line type, in which case we know nothing about (@ p 0); a variable of type (path [_] a m n), in which case it is equal to m in a but might not be equal to m in some other type; or it could even be a variable of function type but we are inside the body of a function (-> void a) so the code is "dead."

authors: cangiuli mortberg

repo: RedPRL/sml-redprl


text:
chore: add user-agent field

What/Why/How?
Add a user-agent field for Redocly requests.
Testing
Screenshots (optional)
Check yourself

[x] Code is linted
[x] Tested with redoc/reference-docs/workflows
[ ] All new/updated code is covered with tests

Security

[x] Security impact of change has been considered
[x] Code follows company security practices and guidelines

@adamaltman good catch. I think I've missed it 😄

repo: Redocly/redocly-cli


text:
Implementation of DynamicClient Registration as per rfc7591

Placeholder to track the work needed for the implementation of:
Dynamic Client Registration: rfc7591
Other than just implementing the POST (to create the record), we also need to evaluate where we will create the remaining methods to administer the records aka crud operations.

The work must be aligned with https://github.com/oauthlib/oauthlib/pull/706 once it has some progress.

authors: JonathanHuot lfdesousa

repo: Refinitiv/bottle-oauthlib


text:
[bug]: no-direct-set-state-in-use-(layout?)-effect should warn only for the set function

Describe the bug
Given a code like that:
const [fn] = useState(() => () => "Function");
// ...
useEffect(() => {
  fn();
}, [...])

If the state is a function, invoking it will result in an error because we do not check which value is being called.
https://github.com/Rel1cx/eslint-react/blob/c4f84dabcd7075fe46ee719c78736d33b23800c2/packages/plugins/eslint-plugin-react-hooks-extra/src/rules/no-direct-set-state-in-use-effect.ts#L65-L69
O.some() will match both data and setData
Reproduction
const [fn] = useState(() => () => "Function");
// ...
useEffect(() => {
  fn();
}, [...])

Expected behavior
It should only warn for calling setState
Platform and versions
@eslint-react: ^1.5.27

Stack trace
No response
Additional context
No response

Yes! Good Catch. Thanks!

Thanks for addressing
I'm curious about the duplication between no-direct-set-state-in-use-effect and no-direct-set-state-in-use-layout-effect. Why they are not a single rule or at least single functionality.

Thanks for addressing
I'm curious about the duplication between no-direct-set-state-in-use-effect and no-direct-set-state-in-use-layout-effect. Why they are not a single rule or at least shared functionality?

There are multiple rules because it gives the user the ability to control whether or not this rule applies to other terms just by switching the ESLint rules on or off, rather than having to add options or exceptions to the single rule to accomplish this.
It also prevents any potential differences between useEffect and useLayoutEffect in future versions of React that might change the behavior of a single rule.
And if other terms such as useLayoutEffect are deprecated, we just deprecate the no-direct-set-state-in-use-layout-effect rule, and the no-direct-set-state-in-use-effect rule doesn't get affected.
Although these benefits are certainly not obvious in the case of no-direct-set-state-in-use-(layout?)-effect, and they are more obvious with some of the other rules in the project such as no-children-* or no-set-state-in-component-did-*.

or at least shared functionality

Agreed, I would extract the shared functionality in one place to avoid modifying the same code in multiple places.


text:
fix: redo the style changes into master

The last PR went into a branch that was killed

I'm not generally one to use the phrase, but it seems apt here: LOL. I completely missed the target branch...

repo: RelationalAI/rai-test-julia


text:
Is it possible to only get AMD GPU Temperature sensors ?

Is there a dll where i just be able to get the temperature sensors without control ? I am using AMD software to control the Fan of the GPU.
I know a bit of C# programming. But haven't used dll's so far. But simple instructions i can follow.
Maybe it would be even handy. To make a amd just sensors fork. Or trying to implement that single piece in the main version.
Help Appreciated :)

You can use the plugin and "not" use the control, by not toggling it on. If I remember correctly, the temperatures and RPM readings worked fine.


text:
Mesh refinement

Being able to refine the mesh on the left hand side, so that we have roughly 5um/1500 = 0.003 um / cell in the first 5 um.

Fixed with #13

repo: RemiTheWarrior/Ttrap


text:
Ajout de la page d'accueil

- Ajout d'un logo du site temporaire renvoyant vers la page d'accueil
- Ajout d'une image de robot temporaire
- Ajout d'un bouton "c'est parti"
- Ajout d'une phrase d'accroche

Changement des pages d'exemples

En fait on va pas faire comme ça, je refais une pr propre

En fait on va pas faire comme ça, je refais une pr propre


text:
🛑 Repetiti Api is down

In 61eab17, Repetiti Api (https://app.repetiti.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Repetiti Api is back up in 7373e25 after 11 minutes.

repo: Repetiti-Com/repetiti-uptime


text:
DRAFT: Ordering/filtering of model runs and proposed sites fix

Addresses these issues
https://smartgitlab.com/TE/RD-WATCH/-/issues/50 - Filter model runs by evaluation
https://smartgitlab.com/TE/RD-WATCH/-/issues/52 - Order model runs by evaluation, region, performer
https://smartgitlab.com/TE/RD-WATCH/-/issues/53 - Number of sites should be number of proposed sites

Merged in recent Mode changes. Evaluation filter works as intended.

Was transferred into #340 which was merged, closing this PR.

authors: BryonLewis Sean-S-Wang

repo: ResonantGeoData/RD-WATCH


text:
ImageViewSet.data redirect error for S3 files

If an Image (it's ChecksumFile) is stored remotely on S3, this endpoint errors:
https://github.com/ResonantGeoData/ResonantGeoData/blob/efb2ab026c68ffa852a399aa122d9b38c320afcc/django-rgd-imagery/rgd_imagery/rest/viewsets.py#L67-L71
We should provide a workaround of some sort as the Python client calls this endpoint expecting data to be returned.
Perhaps for S3 files, we can just pass back the S3 URL and let the user figure it out?
Otherwise, we'd have to proxy the whole file through RGD's web server

We should probably just send the s3:// protocol URL as text.

Otherwise, we'd have to proxy the whole file through RGD's web server

Django is not really equipped to do this. This would exhaust our available threads if deployed without gevent or eventlet. Even then, I'm not sure how capable those libraries are suited for holding long TCP sessions.
An alternative is much more complex: redirect to presigned URLs of the data. This involves issuing commands with the S3 provider's API to acquire the resigned URLs.

We should probably just send the s3:// protocol URI as text.

Let's do this. @mcovalt, could you implement when you have a chance (lowest priority in your queue)

Do we know why the endpoint errors? To my knowledge (emphasis on my, I could be wrong here), since ChecksumFile.file is a S3FileField, calling checksum_file.file.url should return a signed download URL, which should work with HttpResponseRedirect without any problems.

@mvandenburgh, you're right when working with S3FF but the ChecksumFile model has two modes: S3FF or a URL string, see
https://github.com/ResonantGeoData/ResonantGeoData/blob/71c4cd38fa5ec830a2b62765f1dd3772e22debfa/django-rgd/rgd/models/file.py#L38-L40
https://github.com/ResonantGeoData/ResonantGeoData/blob/71c4cd38fa5ec830a2b62765f1dd3772e22debfa/django-rgd/rgd/models/file.py#L73-L75
https://github.com/ResonantGeoData/ResonantGeoData/blob/71c4cd38fa5ec830a2b62765f1dd3772e22debfa/django-rgd/rgd/models/file.py#L83-L94
This issue is referring to the case of FileSourceType.URL ChecksumFile records that have an s3:// URL.
For instance:
In [1]: f = ChecksumFile(type=2, url='s3://sentinel-cogs/sentinel-s2-l2a-cogs/2020/S2A_34JCL_20200309_0_L2A/S2A_34JCL_20200309_0_L2A.json')

In [2]: f.get_url()
Out[2]: 's3://sentinel-cogs/sentinel-s2-l2a-cogs/2020/S2A_34JCL_20200309_0_L2A/S2A_34JCL_20200309_0_L2A.json'

So when we do:
https://github.com/ResonantGeoData/ResonantGeoData/blob/efb2ab026c68ffa852a399aa122d9b38c320afcc/django-rgd-imagery/rgd_imagery/rest/viewsets.py#L67-L71
We are trying to redirect to an s3:// URL which does not work.
Instead, what we should do remake the endpoint to redirect only for ChecksumFile records of type = FileSourceType.FILE_FIELD and have the FileSourceType.URL type return a text record of the URL (not signed)

Ohh I see, I wasn't thinking about URL files, thanks for the explanation. I'll go ahead and tweak the endpoint to return the URL as a string for FileSourceType.URL files

It'd be good to make sure this is handled in
https://github.com/ResonantGeoData/ResonantGeoData/blob/a0e5d346a72d1926d468491280546639e1cd02b9/django-rgd/rgd/rest/viewsets.py#L62-L64
and have
https://github.com/ResonantGeoData/ResonantGeoData/blob/efb2ab026c68ffa852a399aa122d9b38c320afcc/django-rgd-imagery/rgd_imagery/rest/viewsets.py#L67-L71
call that

authors: banesullivan mcovalt mvandenburgh

repo: ResonantGeoData/ResonantGeoData


text:
add -j $J_CORES

Please wait before merging it ...

It's now well tested.
You can merge it.


text:
Send firmware + hardware version from controller -> GUI

Summary:
Add nanopb implementation of ControllerIdentification message that is being sent on reboot currently.
Details:
Add serializing functionality and use it in comms library.

@jlebar Please add some details

@Miceuz can you clarify what you meant by this bug?  Is this "send software version from controller to the GUI"?

Yes, now this issue is just about providing version information to GUI.
Both firmware version and hardware version. I have asked electronics guys to include hardware identification via resistor combination on board, didn't yet look how they implemented that, but have seen the issue close.

need solution for how to set hardware version, but the SW version part of this can be picked up and implemented by soemone

Hardware Revision ID bits are on GPIO pins, described in the Rev A Interface Control Document lines 14 and 15: https://docs.google.com/spreadsheets/d/1EPEkAWZGx5ASWL2mgTzymS2f11Ow9ptx9c8Sycb3_Go/edit?usp=sharing
ID 00 is Rev 1.0, ID 01 is Rev A Hardware

authors: Miceuz inceptionev jkff jlebar martukas

repo: RespiraWorks/Ventilator


text:
Implement mode selection

We intend to support Command Pressure aka Mandatory Ventilation (device commands all breaths), Pressure Assist (device detects inhale effort and helps that breath, but also initiates breaths if patient doesn't), CPAP with O2 therapy aka HFNC (light constant positive O2-saturated air pressure, non-invasive).
Latest UI requirements are here: https://github.com/RespiraWorks/VentilatorSoftware/wiki/UI-Requirements

This is done: the GUI can select between the modes. Command Pressure and Pressure Assist are actually implemented, HFNC is not.

authors: jkff tapemaster

repo: RespiraWorks/VentilatorSoftware


text:
add guidelines when to use mainQueueManagedObjectContext vs persistentStoreManagedObjectContext vs newChildManagedObjectContextWithConcurrencyType

@blakewatters if you could add examples / guidelines (or in RKGist tutorial) some general rules on when to use mainQueueManagedObjectContext vs persistentStoreManagedObjectContext vs newChildManagedObjectContextWithConcurrencyType.
We have an use case where a background is loading a huge list (in chunks of 100 objects at a time), but the UI wants to render that list and also makes references to some other objects already in CoreData... when all that happens, I see deadlocks and I'm still not sure exactly what's going on.

Old, but +1!

Here's my +1

authors: rodrigo-lima thomers

repo: RestKit/RKGist


text:
RKPaginator : objectRequestOperation already in progress

I'm implementing an infinte scroll on a UITableView by loading the next page each time the bottom is reached.
- (void)scrollViewDidEndDecelerating:(UIScrollView *)scrollView {
    if ([_listingsPaginator isLoaded] && [_listingsPaginator hasPageCount] && [_listingsPaginator hasNextPage]) {
     [_listingsPaginator loadNextPage];
    }
}

If the previous request is in progress an assert failure is triggered from RKPaginator.m:163.
NSAssert(! self.objectRequestOperation, @"Cannot perform a load while one is already in progress.");

I'm looking for a way to check if a request is in progress, I've tried by setting a variable in setCompletionBlockWithSuccess:failure: , then, before doing a loadPage checking that variable, but I don't think is the right approach.
Is there any other way to accomplish this?
Using Restkit 0.20.0pre.

Any progress on this?

I'm struggling with the exact same issue. I would love to see an elegant solution. Meanwhile, I will use the subcass solution provided by @matej

+1 for PR this into current paginator

I just realized you can check the objectRequestOperation in RKPaginator to know if a request is already in progress.
-(BOOL)loadInProgress = {
return self.objectRequestOperation;
}

wait for progress on this

authors: imton pblondin slash7 wanxsb

repo: RestKit/RestKit


text:
Trust wallet unauthorized smart contract

Name
https://www.trust-inst.com/?code=5ENZE5
Description
https://www.trust-inst.com/?code=5ENZE5
This website asks for bnb gas fees for mining USDT and then executed 2 transactions where all my USDT went away without my authorization.
Addresses
1: 0x55d398326f99059fF775485246999027B3197955
https://bscscan.com/address/0x55d398326f99059fF775485246999027B3197955
2: 0xCa35fB03597A958dA6d8D467B135E4F8d5A49961
https://bscscan.com/address/0xCa35fB03597A958dA6d8D467B135E4F8d5A49961
3: 0x4532CFA96E7eB67af5103Fe5EE9030F46030732b
https://bscscan.com/address/0x4532CFA96E7eB67af5103Fe5EE9030F46030732b
Meta Article URLs
https://www.trust-inst.com/?code=5ENZE5

Hi, thank you for reporting these addresses. This falls under a "phishing scam" though, which we don't include in this repository.

authors: ArAnAnArAn rkalis

repo: RevokeCash/allowance-exploit-list


text:
Scrolling issue

When scrolling down and using the navbar, then the new page does not scroll back up to the top. Instead, the new page will open up scrolled to somewhere in the middle

Could just rip the user up to the top of the screen whenever they click on a nav link? @noahbass

Fixed this in the registration Pr. Issue will close when registration merges

added registration milestone which closes this issue

authors: domfarolino zacharysang

repo: RevolutionUC/revolutionuc-website


text:
Move y-axis of vertical bar charts to the right side like other charts.

Closes #82
@brittsikora , version is vertical-bars-y-axis-fix

Expected Result: the y-axis of the vertical bar charts are now on the right side of the chart
Outcome: Pass

authors: brittsikora samussiah

repo: RhoInc/web-codebook


text:
Error ENOENT for package bresenham

URL: https://bundle.run/bresenham@0.0.4
Error: ENOENT: no such file or directory, open '/var/app/current/.tmp/e2b6abaa1248eb808cc18725c8bc97cca17b0733/package/index.js.js'

Response headers:
age: 253
content-length: 962
date: Thu, 30 May 2019 18:22:42 GMT
server: nginx/1.12.1
status: 200
via: 1.1 ffa01f5c992a803f4470401daea2d541.cloudfront.net (CloudFront)
x-amz-cf-id: yUV0QY07-lojjGM7gxqFUCzBErCpEdP4GHVmwUQjvxazFoe0NRsrwg==
x-cache: Hit from cloudfront
x-powered-by: Express

Have you tried again? I get a response.

Yep, it's working now.

authors: PlNG mootari

repo: Rich-Harris/packd


text:
How to integrate NSwag with Azure Function Worker and Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCore

Hello,
I am working on a project that involves Microsoft.Azure.Functions.Worker  and Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCore
Right now I am using the NSwag studio to get the JSON specification from the link, but I would like to do it automatically when building in the Azure DevOps pipeline.
I would like to know if there would be a way to integrate NSwag at build time with Azure Function Worker to generate .Net Clients.
Could you please share some guidance or resources on this topic? I appreciate your help.
Thank you.

To generate .Net client with NSwag you need OpenAPI definition file. For NSwag client generation it doesn't matter where that file comes from (azure function worker or anywhere else). So no special guidance is needed for client generation IMO.

To generate .Net client with NSwag you need OpenAPI definition file. For NSwag client generation it doesn't matter where that file comes from (azure function worker or anywhere else). So no special guidance is needed for client generation IMO.

Sorry, my first language is not english.
What I wanted to ask in the first place is:
I am trying to get the OpenApi/Swagger JSON specification file from the the Azure function at BUILD time.
Azure Function is using the Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCore(which has the Asp.Net core request response types) integration with HttpTriggers and Microsoft.Azure.Functions.Worker.Extensions.OpenApi which has the OpenApi requried attributes.
Would it be possible?
Thanks again for your help.

It seems that Microsoft has a recommended solution for this: https://github.com/Azure/azure-functions-openapi-extension/blob/main/docs/generic-cicd-pipeline-support.md which involves running PowerShell or bash script in CI/CD pipeline.
I don't think they are using NSwag library in functions' OpenAPI extension, so I doubt you could use NSwag there...

It seems that Microsoft has a recommended solution for this: https://github.com/Azure/azure-functions-openapi-extension/blob/main/docs/generic-cicd-pipeline-support.md which involves running PowerShell or bash script in CI/CD pipeline. I don't think they are using NSwag library in functions' OpenAPI extension, so I doubt you could use NSwag there...

We are using that script, but if you are using any of the following Triggers ServiceBus, EventGrid, or EventHub, you'll have to disable them somehow when running in CI/CD Pipeline and sometimes it will time out because the AzureFunction takes a bit of time to do the initialization, even if you increase the time it will still time out some times.
Anyway, thank you for your time.

authors: davidpetric olegd-superoffice

repo: RicoSuter/NSwag


text:
CSharpClient code generator issues

I'm looking at this OpenAPI 3 schema: Bankart and C# generator generates wrong code (syntax error) on two issues:

ThreeDSecureData.3dsecure property - it generates constructor like public ThreeDSecureData(ThreeDSecureData_3dsecure? @3dsecure, ... where argument name can't start with a number and should be prefixed with an underscore public ThreeDSecureData(ThreeDSecureData_3dsecure? @_3dsecure instead. '@' doesn't do anything.
For some reasons it creates references to CLASS_NAME2 (it postfixes 2 to class name), like in Customer's paymentData argument - PaymentData2 instead of PaymentData) sometimes.

Had the same problem.
Seems to be "classStyle": "Record" creates this broken constructors
Using "classStyle": "Poco" with "generateNativeRecords": true still gets me records but without the constructors


text:
Add template for Client method annotations

Adds a new template to expose Annotations for the Client methods (on both the interface and classes) for more consistency and to unblock certain scenarios.

If I am able to check in this PR (and get it into the NuGet package), I am able to workaround the other PRs I have made.


text:
JSON controller outputs exception and stack trace

I'm trying to use the framework as part of a web GUI, but using the Json output is not working; it just outputs an error.  The error displayed in the browser is:
Internal server error

Exception
Message:
Exception was thrown: System.ArgumentException
Stack Trace:
System.Reflection.MethodBase::Invoke
Rinsen.WebServer.Serializers.JsonSerializer::Serialize
Rinsen.WebServer.Serializers.JsonSerializer::Serialize
Rinsen.WebServer.Controller::SetJsonResult
Reflow_Oven_Controller.Web_GUI.DataController::Index
System.Reflection.MethodBase::Invoke
Rinsen.WebServer.HttpApplicationHandler::Execute
Rinsen.WebServer.RequestResponseHandler::CreateResponse
Rinsen.WebServer.RequestResponseHandler::ProcessRequest
Rinsen.WebServer.SocketListener::ProcessRequest
Rinsen.WebServer.SocketListener::ProcessClientRequest
Rinsen.WebServer.SocketListener::StartListening
Rinsen.WebServer.ServerBase::MyThreadStart
Rinsen.WebServer.ServerBase::<StartServer>b__0

And the entire code for my Json controller is:
using System;
using Microsoft.SPOT;
using Rinsen.WebServer;
namespace Reflow_Oven_Controller.Web_GUI
{
    class DataController : Controller
    {
        public void Index()
        {
            var Data = new JsonData
            {
                OvenTemperature = OvenController.OvenTemperature,
                BayTemperature = OvenController.BayTemperature,
                CPUUsage = OvenController.CPULoad.LoadPercentage,
                MemUsage = OvenController.FreeMem,
                Running = false,
                RunTime = -1,
                DoorOpen = OvenController.DoorAjar
            };
            SetJsonResult(Data);
        }

        public class JsonData
        {
            public float OvenTemperature{get; set;}
            public float BayTemperature { get; set; }
            public uint MemUsage { get; set; }

            public int CPUUsage { get; set; }
            public int RunTime { get; set; }

            public bool Running { get; set; }
            public bool DoorOpen { get; set; }
        }
    }
}

Hi!
I have made a fix for this tha i will commit tomorrow. The problem is that the json serializer has a very basic type support for built in C# types and i have added some more type handling but I need to test this a bit more before it´s good enough to use.
So i will get back when it´s done.

I have commited this change now and it should fix you´re problems.
One thing to remember is that the default C# stringbuilder float parser gives garbage back, in a perfect world this should be customizable in some way but right now it´s not. For an example you can check the test i have added that´s called WhenSerializeWithMoreDatatypes_GetSerialiedJsonString.

And i also changed bool parsing to be only lower case letters in json data object to follow common json standards.

authors: Rinsen Sukasa

repo: Rinsen/WebServer


text:
🛑 Catbox is down

In d82e325, Catbox (https://catbox.moe/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Catbox is back up in 992693d.

repo: RitsuProject/ritsu-status


text:
Error 😭

how do i fix this error? i compile the executor, but when i try to open, this error appears

I already compiled the latest release in the releases section. Download it from there, you will get issues with compilers if you haven't set it up right

repo: Riz-ve/Xeno


text:
Update JIRA dependencies (it fixes a theming issue in backstage 1.1.1)

With this pull request I'm updating some package versions in the JIRA plugin. While testing it in our internal project, we found out that some material-ui package versions were different than the ones used in the latest version of Backstage, causing the theming to be incorrect, specially in the dark mode. After updating those versions, the plugin will be completely up to date. No tests are needed for this.
:heavy_check_mark: Checklist

[ ] Added tests for new functionality and regression tests for bug fixes
[x] Added changeset (run yarn changeset in the root)
[ ] Screenshots of before and after attached (for UI changes)
[x] Added or updated documentation (if applicable)

Hey thank you for fixing this! It seems there is a conflict, could you pls try to resolve it?

Yeah, just forgot to pull the last changes done 15 hours ago. Now it's solved

authors: ivangonzalezacuna kissmikijr

repo: RoadieHQ/roadie-backstage-plugins