text:
Alert windows with error message

OS: Ubunu 24.04 with all recent updates
Sourcegit version: 8.40, installed from released .deb package
git version: 2.43.0
Almost any action causes pop-up of the alert window with the error message, saying about incorrect usage of git rev-list command.

I suppose, these messages are caused by this line: https://github.com/sourcegit-scm/sourcegit/blob/ee8206794079958ec0b39d4776b5802c909b41d0/src/Commands/QueryCommitChildren.cs#L14
git rev-list --help does not show -max option.

According to git documentations, -<number> option should in git 2.43
https://git-scm.com/docs/git-rev-list/2.43.0#Documentation/git-rev-list.txt--ltnumbergt

Indeed, I've missed curly brackets around max.
String interpolation should take place.
Probably, it doesn't.

I think, my installation is missing Preference.Instance.MaxHistoryCommits parameter.
I've tried to issue git rev-list command from a terminal.
If I omit a number after the first dash, then I get such output.
Compare:
❯ git rev-list -10 --parents --branches --remotes --tags ^6d74533
2819df565474a3ac3dd1350da1dc7b443952bb76 9e4dcb06fa19c2f10b3bfcb001ccf705d85fb47e e53b9bd1a03ccc830ba88b2a12abe707110231b4
e53b9bd1a03ccc830ba88b2a12abe707110231b4 f9f193a456032019a6cfa06cce2de6b52a343525
f9f193a456032019a6cfa06cce2de6b52a343525 1d1a5a29d2820ff3bd8d052feb7f6f2b6587a410
1d1a5a29d2820ff3bd8d052feb7f6f2b6587a410 7b7146c0d3501b4c4076dfec8519c02dbba25931
7b7146c0d3501b4c4076dfec8519c02dbba25931 840fea5e80635e5ec1f3b318dd92b05139a95196
840fea5e80635e5ec1f3b318dd92b05139a95196 54de0ffcd0e7858ff8fc2c9baa70a1491f2abb19
54de0ffcd0e7858ff8fc2c9baa70a1491f2abb19 ccb526d2da6dcb1db9c9a5ef223b1b3e8486f42b
ccb526d2da6dcb1db9c9a5ef223b1b3e8486f42b 9e4dcb06fa19c2f10b3bfcb001ccf705d85fb47e
9e4dcb06fa19c2f10b3bfcb001ccf705d85fb47e 09f53f3c40ae26da0ad5f2437c0f18594c732d53
09f53f3c40ae26da0ad5f2437c0f18594c732d53 c159aad9268be1f6a315bacd62df2ef264954cbb 6d74533cf9b27f9ceeb8c3a2de5a83a2e9be8f34

Just - instead of -10:
❯ git rev-list - --parents --branches --remotes --tags ^6d74533
usage: git rev-list [<options>] <commit>... [--] [<path>...]

limiting output:
--max-count=<n>
--max-age=<epoch>
--min-age=<epoch>
--sparse
... (many more lines)

This doesn't seem to be a problem with QueryCommitChildren, as this command is only executed when Show children in commit details is enabled to view commit details.
There is another place in the project using git rev-list command - QueryTrackStatus, which is used to obtain differences between the branch and its tracking upstream branch.

@wl2776 can you try git rev-list --left-right LOCAL_BRANCH...REMOTE_BRANCH
Remember replacing the LOCAL_BRANCH and REMOTE_BRANCH with yours

Try change the History Commits to another value, and see if this issue solved?
Looking forward for your feedback.

Have tried to change this value to 5000, 100000, 25000 - same result.
I have also tried to manually edit preferences.json, and add "HistoryCommits" along with "MaxHistoryCommits", my changes have no effect and get overwritten.

And I observe these windows only in one repository, that is, unfortunately, private, and I cannot give access to it.

@wl2776 can you try git rev-list --left-right LOCAL_BRANCH...REMOTE_BRANCH
Remember replacing the LOCAL_BRANCH and REMOTE_BRANCH with yours

I get empty output:
$ git rev-list --left-right master...origin/master
$

What is correct form of naming local and remote branches?

@wl2776 can you try git rev-list --left-right LOCAL_BRANCH...REMOTE_BRANCH
Remember replacing the LOCAL_BRANCH and REMOTE_BRANCH with yours

I get empty output:
$ git rev-list --left-right master...origin/master
$

What is correct form of naming local and remote branches?

If you go empty output, it means the local branch is update to its tracking remote. Otherwise, it will print the commit hashes with a prefix '<' (un-pushed commits) or '>' (remote newer changes)

For example:

It means you have 4 commits in local branch release that has not pushed to the remote origin/release

If you go empty output, it means the local branch is update to its tracking remote. Otherwise, it will print the commit hashes with a prefix '<' (un-pushed commits) or '>' (remote newer changes)

This is not the case for this repo. All local and remote branches are in sync.

If you can debug this project, try to add breakpoint to all lines that contains App.RaiseException(...) in src/Commands/Command.cs

If you can debug this project, try to add breakpoint to all lines that contains App.RaiseException(...) in src/Commands/Command.cs

I believe that I have enough skills to debug this project, but I'm not very familiar with C#.
I mostly write in Python and C++.
How can I get started?

On Ubuntu, you can use VSCode + .NET SDK + C# extension to debug this project.
.NET SDK installation : https://learn.microsoft.com/zh-cn/dotnet/core/install/linux-ubuntu-install?pivots=os-linux-ubuntu-2410&tabs=dotnet9

I believe that I have enough skills to debug this project, but I'm not very familiar with C#. I mostly write in Python and C++.

If you are more familiar with PyCharm, etc., you can also use Jetbrains Rider, which is now free.

Git receives the following command line
rev-list -100000  --parents --exclude=feature/branch-name-mlflo[w] --decorate-refs-exclude=refs/heads/feature/branch-name-mlflo[w] --exclude=HEA[D] --branches --exclude=origin/feature/branch-name-mlflo[w] --decorate-refs-exclude=refs/remotes/origin/feature/branch-name-mlflo[w] --exclude=origin/HEA[D] --remotes --tags  ^2819df565474a3ac3dd1350da1dc7b443952bb76
My git does not have --decorate-refs-exclude command line option.
And I doubt that [w] and [D] at ends of mlflo[w] and HEA[D] are valid patterns.

According to documentation, --decorate-refs-exclude is the option for git log, not git rev-list

try to use --branches --remotes to replacing the {filters} in Args to see if this issue solved.

This resolves the issue:
diff --git a/src/Commands/QueryCommitChildren.cs b/src/Commands/QueryCommitChildren.cs
index 293de912..4006b01f 100644
--- a/src/Commands/QueryCommitChildren.cs
+++ b/src/Commands/QueryCommitChildren.cs
@@ -9,8 +9,8 @@ namespace SourceGit.Commands
WorkingDirectory = repo;
Context = repo;
_commit = commit;
-            if (string.IsNullOrEmpty(filters))
-                filters = "--branches --remotes --tags";
+            //if (string.IsNullOrEmpty(filters))
+            filters = "--branches --remotes --tags";
Args = $"rev-list -{max}  --parents {filters} ^{commit}";
}

You can download the latest CI build from Github Action.

repo: sourcegit-scm/sourcegit


text:
Modify autocomplete to use all surrounding code as context

This is a work from @abeatrix  on https://github.com/sourcegraph/cody/pull/885/ Just worded slightly differently so that I could understand how autocomplete actually functions.
I am referencing this code for example
https://github.com/sourcegraph/cody/blob/66bf5f1d6bb991c106e59cbfe0fbbb5fc49083a9/vscode/src/custom-prompts/utils/menu.ts#L176-L218
Lets say the cursor is at Line 208 then if you look above the cursor you see a few config menu options
Before
In the current behaviour when you try to add a comment it takes into account only the config menu options and makes a docstring
https://github.com/sourcegraph/cody/assets/11155207/7d1e747e-b1e2-4452-a896-4866fdf6c9ac
On asking GPT4 we realize the docstring doesn't make perfect sense(which is obviously try coz its missing the suffix context)

After
https://github.com/sourcegraph/cody/assets/11155207/dd68c040-d3e0-469d-8e4e-1aed1e85ee32
Now in the new code the docstring makes a lot of sense coz it has the suffix context also and I checked whether the docstring makes sense with GPT4 also.

The essence of this PR is that adding suffix context and sending that to the autocomplete gives much better results and I tried that in other contexts too.
Test plan

The local tests are passing

 ✓ |vscode| src/completions/context/bestJaccardMatch.test.ts (4)
 ✓ |vscode| src/services/InlineAssist.test.ts (16)
 ✓ |vscode| src/completions/utils/string-comparator.test.ts (12)
 ✓ |vscode| src/non-stop/utils.test.ts (3)
 ✓ |agent| src/index.test.ts (2)
 ✓ |e2e| src/entity-detection.test.ts (3)
 ✓ |vscode| src/completions/text-processing.test.ts (12)
 ✓ |agent| src/AgentTextDocument.test.ts (5)
 ✓ |web| src/sample.test.ts (1)
 ✓ |vscode| src/configuration.test.ts (2)
 ✓ |vscode| src/completions/vscodeInlineCompletionItemProvider.test.ts (11) 462ms
 ✓ |shared| src/utils.test.ts (11)
 ✓ |shared| src/experimentation/FeatureFlagProvider.test.ts (6)
 ✓ |shared| src/chat/transcript/transcript.test.ts (10)
 ✓ |shared| src/guardrails/index.test.ts (6)
 ✓ |shared| src/common/markdown/markdown.test.ts (12)
 ✓ |shared| src/chat/bot-response-multiplexer.test.ts (9)
 ✓ |shared| src/codebase-context/rerank.test.ts (1)
 ✓ |shared| src/sourcegraph-api/utils.test.ts (4)
 ✓ |shared| src/chat/recipes/fixup.test.ts (2)

 Test Files  31 passed (31)
      Tests  282 passed | 1 skipped (283)
   Start at  01:46:17
   Duration  6.44s (transform 1.40s, setup 1.18s, collect 9.97s, tests 1.56s, environment 9.21s, prepare 5.19s)

 PASS  Waiting for file changes...
       press h to show help, press q to quit

I stopped at the debugger at various places to actually check the prompt to make sure it includes text AFTER the cursor position and now that it does that we can get much better results.

Hey @arafatkatze! Thanks for the contributions. I think we should launch this behind a feature flag so we can measure the effects of the prompt change, do you mind adding one following the example of e.g. this PR
Also I’m curious if you have any anecdotal thoughts to that: When I tried out this prompt change, it causes me to insert code comments much more often then desired. It also returned no results more often than the previous implementation but I don't think this was necessarily a bad thing - It's just unexpected.

@philipp-spiess Here are some anecdotal thoughts from me

When I tried out this prompt change, it causes me to insert code comments much more often then desired.

So given that this new method takes into account the context AFTER the code the comments now would make a lot more sense than before coz the comment would be explaining the upcoming function. I hope that's what you meant and I hope the extra comment suggestions isn't problematic. Do let me know if you meant something else and I am happy to take a look.

It also returned no results more often than the previous implementation but I don't think this was necessarily a bad thing - It's just unexpected.

There is a very good reason for that behaviour and I am quite happy with it. In the previous code we do
text: `Complete this code: ${OPENING_CODE_TAG}${head.trimmed}${CLOSING_CODE_TAG}.`,

What this does is that it shows 1-2 lines before the position of the current cursor whereas now we do
${OPENING_CODE_TAG}
                ${head.trimmed}${OPENING_CODE_TAG}${tail.trimmed}${CLOSING_CODE_TAG}${this.options.docContext.suffix}`,

My guess is that  because of tail.trimmed  when you are writing stuff and its only partially complete like the completion results tend to be empty string and then when you write a full word then the completion results tend to be meaningful. That's what I found in my local tests with the debugger.
c  => Nothing on completion
co  => Nothing on completion
con  => Nothing on completion
cons  => Nothing on completion
const   =>  shows  "const variableName = something"
The above example is what I usually found in my local testing with the debugger.
Let me add a feature flag now.

So given that this new method takes into account the context AFTER the code the comments now would make a lot more sense than before coz the comment would be explaining the upcoming function. I hope that's what you meant and I hope the extra comment suggestions isn't problematic. Do let me know if you meant something else and I am happy to take a look.

I meant that when I played around with Beatrix's prototype, the code suggestions would be comments // do something instead of actual code.

It also returned no results more often than the previous implementation but I don't think this was necessarily a bad thing - It's just unexpected.
There is a very good reason for that behaviour and I am quite happy with it. In the previous code we do
text: `Complete this code: ${OPENING_CODE_TAG}${head.trimmed}${CLOSING_CODE_TAG}.`,

What this does is that it shows 1-2 lines before the position of the current cursor whereas now we do
${OPENING_CODE_TAG}
                ${head.trimmed}${OPENING_CODE_TAG}${tail.trimmed}${CLOSING_CODE_TAG}${this.options.docContext.suffix}`,

My guess is that  because of tail.trimmed  when you are writing stuff and its only partially complete like the completion
results tend to be empty string and then when you write a full word then the completion results tend to be meaningful. That's what I found in my local tests with the debugger.
c  => Nothing on completion
co  => Nothing on completion
con  => Nothing on completion
cons  => Nothing on completion
const   =>  shows  "const variableName = something"
The above example is what I usually found in my local testing with the debugger.

I’m not sure I follow. What does this has to do with the prompt? When I try this locally, it does seem to give completions. Here's an example where the prefix is con, for example:
█ CompletionLogger:onComplete: {"type":"completion","status":"success","duration":807}  {
  "result": {
    "completion": "sol.log(bubbleSort([5,3,6,2,10]));",
    "stopReason": "stop_sequence"
  },
  "params": {
    "temperature": 0.5,
    "messages": [
      {
        "speaker": "human",
        "text": "You are a code completion AI that writes high-quality code like a senior engineer. You are looking at test.ts. You write code in between tags like this: <CODE5711>/* Code goes here */</CODE5711>."
      },
      {
        "speaker": "assistant",
        "text": "I am a code completion AI that writes high-quality code like a senior engineer."
      },
      {
        "speaker": "human",
        "text": "Complete this code: <CODE5711>function bubbleSort(arr) {\n  const len = arr.length;\n  for (let i = 0; i < len; i++) {\n    for (let j = 0; j < len - i - 1; j++) {\n      if (arr[j] > arr[j + 1]) {\n        let temp = arr[j];\n        arr[j] = arr[j + 1];\n        arr[j + 1] = temp;\n      }\n    }\n  }\n\n  return arr;</CODE5711>."
      },
      {
        "speaker": "assistant",
        "text": "Here is the code: <CODE5711>}\n\ncon"
      }
    ],
    "maxTokensToSample": 50,
    "stopSequences": [
      "\n\nHuman:",
      "</CODE5711>",
      "\n\n"
    ]
  }
}

One unrelated thing that I saw now though is that you add the suffix starting from the same line. In my experience with fill-in-middle based models like StarCoder or Code LLama (which we will be running A/B tests with very shortly btw., so hopefully they will provide much better suggestion that the chat based Claude Instant model. 🤞), I noticed that if the line already has a suffix (e.g. you're here: function bubbleSort(█) {} and the same line suffix is ) {}), the models tend to not perform so well. Instead, what we do here is cut off the suffix after the cursor: https://github.com/sourcegraph/cody/blob/main/vscode/src/completions/providers/unstable-fireworks.ts#L73
Might make completions better in the case where there is something after the cursor.

@philipp-spiess Here are some anecdotal thoughts from me
When I tried out this prompt change, it causes me to insert code comments much more often then desired.
So given that this new method takes into account the context AFTER the code the comments now would make a lot more sense than before coz the comment would be explaining the upcoming function. I hope that's what you meant and I hope the extra comment suggestions isn't problematic. Do let me know if you meant something else and I am happy to take a look.
It also returned no results more often than the previous implementation but I don't think this was necessarily a bad thing - It's just unexpected.
There is a very good reason for that behaviour and I am quite happy with it. In the previous code we do
text: Complete this code: ${OPENING_CODE_TAG}${head.trimmed}${CLOSING_CODE_TAG}.,
What this does is that it shows 1-2 lines before the position of the current cursor whereas now we do
${OPENING_CODE_TAG}
${head.trimmed}${OPENING_CODE_TAG}${tail.trimmed}${CLOSING_CODE_TAG}${this.options.docContext.suffix}`,
My guess is that because of tail.trimmed when you are writing stuff and its only partially complete like the completion results tend to be empty string and then when you write a full word then the completion results tend to be meaningful. That's what I found in my local tests with the debugger.
c => Nothing on completion
co => Nothing on completion
con => Nothing on completion
cons => Nothing on completion
const  => shows "const variableName = something"
The above example is what I usually found in my local testing with the debugger.

Let me add a feature flag now.

Nice! Thank you

Closing in favour of the extraordinary work from @abeatrix  in https://github.com/sourcegraph/cody/pull/974  🙇

source: gharchive/pull-request

authors: arafatkatze philipp-spiess

repo: sourcegraph/cody

license_type: permissive

license_source: github-api


text:
Automated PR: Standardising Files

This PR will standardise the files we have with out agreed spec in sous-chefs/repo-management.
This repo has been identified by topic(s) of chef-cookbook

Released as: 7.5.3

repo: sous-chefs/iis


text:
Automated PR: Standardising Files

This PR will standardise the files we have with out agreed spec in sous-chefs/repo-management.
This repo has been identified by topic(s) of chef-cookbook

Released as: 11.1.6

repo: sous-chefs/nagios


text:
[BUG] Do not rely on api-platform/core attributes classes but on interfaces instead

Q
A

Branch?
3.0

Tickets
N/A

License
MIT

Doc PR
N/A

In case of a custom GetCollection operation attribute class, the AttributesResourceMetadataCollectionFactory generates the same name as Get operation attribute, which erases the previous operation. api-platform/core should not rely on its own attributes but on interfaces (like CollectionOperationInterface). Same for Post operation, that's why I created a PostOperationInterface.

Merged in api-platform/core:3.0

repo: soyuka/core

license: mit

license_source: bigquery


text:
Tile fixes

Set some of the defaults in the definition to what we use for most prototypes
Added planet variant for dirt to avoid black space
Dirt looks like literal poop but will have another sprite for it soon

:cl:

fix: Fix breaking planet tiles leading to the void.

bors r+

bors cancel

bors r+

license: MIT


text:
Adds cosmetic sunglasses

About the PR

Added cosmetic sunglasses.
Barkeeper vendor only has cosmetic sunglasses.
Musician spawns with cosmetic sunglasses.
Added cosmetic sunglasses to clothesmate vendor.
Security and command still have access to flash resistant sunglasses, revs still spawn with flash resistant sunglasses if they choose to keep them, but having sunglasses on you won't be weird anymore.
Why / Balance

Curbs metagaming of head revs if everyone has easy access to sunglasses

#22072

Changelog
:cl: Whisper

add: Added cosmetic sunglasses to the clothesmate
tweak: Musician and bartender now have cosmetic sunglasses

Shouldn't the bartender use the beer glasses instead?

oh they already have those

is there a way to tell between regular and cosmetic sunglasses without getting flashed? there should be a description change but not a name change. but I can see how officers will rip the glasses off everybody to check them

I dont think its good idea to rip off INTENDED security items from non-sec jobs like bartender or musician. If it were metagamed, so i am sorry, thats an admin issue.
If you wish to go in that way, so what about to rid off head rev glasses instead?

I dont think its good idea to rip off INTENDED security items from non-sec jobs like bartender or musician. If it were metagamed, so i am sorry, thats an admin issue.
If you wish to go in that way, so what about to rid off head rev glasses instead?

Why are they intended? what's the use case?

when the populace has nothing to defend themself, thats a police state

it's 3 sunglasses at most but sure we can revert that if that's wanted

removing gear from non-sec positions (or reverse power creep) also makes rev rounds a lot harder for revs. imagine if the chef got dull knives, the botanists got their hatchet nerfed, sci couldnt print chemical payloads anymore, ect.

I dont think its good idea to rip off INTENDED security items from non-sec jobs like bartender or musician. If it were metagamed, so i am sorry, thats an admin issue.
If you wish to go in that way, so what about to rid off head rev glasses instead?

Why are they intended? what's the use case?

Okay, maybe i have rushed with conclusions that they should have intended sunglasses, but at first place, its a commoner sunglasses, one type for everyone.
You know, i can tell that sunglasses should have defence to flashes, sure or not. Making a "decorative" is a weird design that will put things into confusion, like making two diffrent stuff from one thing.
If we use uhhh, space station 13, were sunglasses are used to defence against flashes(but not to flashbangs)(they also defence against unwielding that is weird). And you can upgrade them by using departament hud.
Yeah, not a conclusive text, only just my thoughts.
In a final i would say that changes shouldnt revolve around people whom actively metagaming/powerbreaking/rulebreaking, cause its a human factor that can't be resolved.

just make it so you need hearing protection to not be flashbanged, problem solved

sure

sure

you just merged two conflicting PR's lmao #22312

conflicts were resolved prior to merge, you wouldnt be able to merge otherwise

nevermind then :trollface:


text:
Replace Romerol with Ambuzol in chemist guidebook

About the PR

Changed Romerol to Ambuzol in the chemist-medicine guidebook.
Why / Balance

Romerol isn't Medicine and Ambuzol is the one that is important for the chemist.
Technical details

Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

Counterpoint: It cures Death.

It's weird we have no interactions between romerol and necrosol due to their namesakes


text:
Southern accent

About the PR

Added a new speech trait to sort of replicate Southern accents by replacing "-ing" suffixes with "-in'". It also adds some contractions, like "is not" to "ain't" and "you all" to "y'all".
Why / Balance

I've seen quite a few people manually do what this trait would do. Not to mention, many players that I have talked to also yearn for more accents.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

add: Nanotransen is now recruitin' personnel that speak with a Southern drawl.

my old PR (25693) was closed for good reason. it was a webedit and i didn't really know what i was doing.
this is the same exact code except it was done better. enjoy.

american-centric moment.

authors: UBlueberry metalgearsloth


text:
fix health analyzer crash

About the PR
fixes analyzer crashing when patient is deleted
Why / Balance
:bug: :hammer:
Technical details
yep
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
no
Changelog
no cl no fun

could also make the status say INACTIVE I guess

authors: deltanedas ficcialfaint


text:
antag objective issuing refactor

About the PR
instead of every system that has random objectives copy pasting shit, add AntagRandomObjectives to the gamerule yml
also moved fixed objectives part of genericantag into its own component AntagObjectivesComponent, which currently thief uses but will make everything that used genericantag use it too before nuking it entirely
Why / Balance
negative diff (with genericantag deleted) good
Technical details
an AntagObjectiveSet defines the objective groups prototype, probability of the set being used, the max tries it can have
AntagRandomObjectives can have multiple sets, like thief which has 70% chance of adding 1 animal objective and guaranteed chance of trying to add up to 10 normal objectives, difficulty permitting
traitor just has 1 set of groups: TraitorObjectiveGroups since it doesnt do anything funny
Media
it work

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
TraitorRule and ThiefRule no longer add objectives, they need AntagRandomObjectives in the gamerule now
Changelog
no cl no fun

picks20 lives another day


text:
Many improvements to disposals room

Changed the airlock so it had a name and could occlude, added a small light

The diff is so big because all the parents and many of the IDs were updated and some APCs drawed power for some reason and modified their startingCharge by a bit.

HAHA EAT MY MERGE CONFLICT IDIOT

HAHA EAT MY MERGE CONFLICT IDIOT

Reverting pr in 3... 2...

Merge conflicts solved

authors: AJCM-git SweptWasTaken metalgearsloth


text:
Damp rag now looks like damp rag

About the PR

Damp rag Texture finally changed
Why / Balance

N/A
Technical details

N/A
Media

[
before

now] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
[ ]

Breaking changes

Changelog

tweak : Damp rag now looks like damp rag!

it looks slightly like gauze honestly

the new sprite doesnt really look like anything, it just feels like random pixels

New sprite is unreadable. Old sprite at least looks like a lump of something.


text:
Bump operative reinforcement cost

See https://github.com/tgstation/tgstation/blob/838742297ee2cd692362c42b8bccde8a5e307376/code/modules/uplink/uplink_items/nukeops.dm for tg values
Few issues:

I wanted to make borgs cheaper but we don't have as many tools to deal with borgs as in 13 so I left that higher for now until they're more fleshed out and we can balance them better (though they can be super squishy in some situations which is eh).
Operatives seem to be getting used frequently as they're easy to arm up and bump nukie numbers where they might've been 3-5 to 5-8.

:cl:
tweak: Bumped nukie operative cost from 14 to 35TC.

Woah that's a massive bump. You practically cant get them unless you warops.

changelog said 14 but the price is 16

Woah that's a massive bump. You practically cant get them unless you warops.
Doesn't TG also have TC earning mechanics?

no idea but considering mechs go up to 100TC seems fine to me.

This is awful.
35 TC for a suicide bomber

Better PR https://github.com/space-wizards/space-station-14/pull/29557

authors: Brandon-Huu Dutch-VanDerLinde IProduceWidgets metalgearsloth


text:
Reduce Cost of Bloodred Mags to 2TC

About the PR

Reduces the cost of bloodred magboots to 2TC in the syndicate uplink catalog.
Why / Balance

Currently for syndicates you need a way to prevent slipping and that boils down to 1/2 items in the uplink

No-slips: cham tech, no slipping, the stealthier of the two options
Bloodred Magboots: Magboots, gives slowdown, is a 2 minute jetpack, no stealth capability

Currently no-slips have no downsides and are purely better for Traitors, they are cheaper, give no disadvantages, and don't make you valid. On the other side bloodred Magboots cost twice the TC, provide similar functionality to the no-slips in most situations, and make you instantly valid. Unless you're specifically planning on taking out gravity no-slips are always the better option. I don't see why the more niche of the 2 items should cost 2x the amount. This would mostly affect Traitors due to the smaller budget while slightly "nerfing" nukie agents by "removing" 2 tc from their starting equipment. The slowdown and cost are more noticeable now than ever due to the elite suit nerfs.
Technical details

yml edits
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

tweak: Bloodred Magboots are now 2TC

This is a nukie buff not a nerf

This is a nukie buff not a nerf

Its 2tc, at most its going to make taking out grav 8-10tc out of 200tc cheaper for the whole team. So sure, its more of a buff for nukies, but they also got a massive nerf to elite hardsuits.

Failing tests from changing one number... huh...

Failing tests from changing one number... huh...

this test fail is not your fault i think

Discussed with maintainers and opting not to change the price at this time.

authors: Cojoke-dot IProduceWidgets Killerqu00 metalgearsloth


text:
Syndicate CHIMP buffs

About the PR

Removed metagaming potential on Syndicate CHIMP; matches normal CHIMP on examination
Changed damage from 20 Heat to 15 Heat and 8 Shock to bypass armour
CHIMP upgrade chip now indicates Syndicate origin, Omega particle functionality, and being unremovable
Mapping: Syndicate CHIMP has DO NOT MAP tag, Experimental CHIMP (major contraband and only fires Omega particles) available for mapping

Why / Balance

The Experimental CHIMP is very underused despite being a rare Syndicate ranged energy weapon. It is easily metagamed by examination and easily loses charge in combat.
Matching the appearance of normal CHIMPs should let Syndicate scientists be more discrete, especially since a modified CHIMP shouldn't be immediately obvious to the naked eye.
At 20 Heat damage, Omega particles kill unarmoured crew in five shots, armoured crew (20% heat protection) in seven shots. By changing the damage to 15 Heat and 8 Shock (23 total), both unarmoured and armoured crew die in five shots. Shock damage gives an interesting twist compared to other weapons as it is not normally resisted, and helpfully conserves more charges when fighting security and unable to recharge on the run.
Smaller QoL features were added; the chip itself now describes how Omega particles will cause anomalies to go supercritical, as well as being unremovable to avoid confusion.
Technical details

yml changes only

Resources/Prototypes/Entities/Objects/Devices/Syndicate_Gadgets/chimp_upgrade_kit.yml (changed chip name and description)
Resources/Prototypes/Entities/Objects/Weapons/Guns/Battery/battery_guns.yml (changed Upgraded CHIMP contraband and removed description)
'Resources/Prototypes/Entities/Objects/Weapons/Guns/Projectiles/projectiles.yml' (changed Upgraded CHIMP damages)

Requirements

[x] I have read and am following the Pull Request and Changelog Guidelines.
[x] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

N/A
Changelog

:cl:

tweak: Syndicate-upgraded (formerly Experimental) CHIMPs are now much easier to hide as they match the name, description and contraband level of normal CHIMPs.
tweak: CHIMP handcannon upgrade chip is now renamed to CHIMP Omega chip and describes Omega particles and use in combat.

I feel like the changes regarding the name and how it can be metagamed are fine. I honestly dont think it needs to be buffed to do more damage to armored targets though.

Removed metagaming potential on Syndicate CHIMP;

I mean, if a sec is going to metagame it they can still just right-click and check the particles. I like the pr though, it never made much sense to me for it to chang the name of the item.

Nevermind 7 shots is a lot..

7 is about proportional to how many shots a laser rifle takes to down a secoff. 5 shots makes the CHIMP more efficient in comparison.
However, syndies don't usually get the luxury of recharging on the run, and the CHIMP shoots projectiles rather than hitscan lasers.

This is probably for the best since most laser weapons are hit scan while the CHIMP has a slow projective speed.

Hey, this balance change got internal approval by the maintianers and I gave it an in-game test and it feels good to me. It is a little stronger than the cobra which also costs 4TC and is rechargeable on top, but considering it is science restricted and has slower projectiles that should be fine.
Two requests before merging:

Keep an additional non-stealth prototype with the old description for mapping purposes.
Keep the doafter. While testing I found it is useful to have some feedback that the chip is being installed instead of it simply disappearing.

I don't know what you mean by this, it would defeat the purpose of making the CHIMP stealthy when mapped

Yeah, one maintainer requested a non-stealth version for mapping. So make another prototype that has a different name, description and contraband status.

Yeah, one maintainer requested a non-stealth version for mapping. So make another prototype that has a different name, description and contraband status. Keeping the normal one stealthy is fine.

I will do this, but what circumstance would you need to map an openly Syndicate CHIMP?

Space ruins, wrecks, random gun generation, anything that uses the Experimental C.H.I.M.P as a normal gun spawn. I mainly want this for SSS, but I feel like it'd just generally be useful to have for other purposes.
It's important to mark that it's different in instances like these, so that people actually know it's not just a normal C.H.I.M.P. The weapon has unique properties, and I think there's plenty of usecases for spawning it outside of just being an uplink item (even if said use cases are fairly niche.)

Any suggestions on how to improve this are welcome.

Just putting this here, someone else can make the issue, but a good one could be:
Any object or item that exhibits qualities or abilities of another object or item that is contraband or restricted can have those same or higher restrictions applied to the firstly mentioned item.
For example:

A pen (energy dagger) exhibits qualities of an energy sword. Applying the restrictions of the energy sword to the pen, that pen is now syndicate contraband.
A pen (hypopen) exhibits qualities of a hypospray. Applying the restrictions of the hypospray to the pen, that pen is now restricted contraband or higher.
A lantern (extra-bright lantern) exhibits qualities of a flasher. Applying the restrictions of a flasher to the lantern, that lantern is now restricted contraband or higher.
A pair of boxing gloves (rigged boxing gloves) exhibit behavior of a deadly weapon (knife). Applying the restrictions of a knife to the boxing gloves, those boxing gloves are now restricted weaponry.

Obviously this requires much, much more writing and time put into it than my 10 second spitball. Obvious flaws you can see is a hypopen technically being allowed, just restricted, same with the lantern.
You could modify the clause to:
Any object or item that exhibits intentionally hidden qualities or abilities of another object or item that is contraband or restricted will have syndicate contraband restrictions applied to the firstly mentioned item.

Hey, we had some more discussion among maintainers and the simplest way to solve the contraband problem would be to make the chip removable again so sec can identify the CHIMP as contraband upon closer inspection, while it can stay a stealth weapon on first look. Could you add a deconstruction step using a screwdriver to the construction graph for this?

Yeah, the same problem will still exist for the other items, and we mostly want to not any more to that list until we solve that. One approach for that would be a contraband scanner for sec that can identify them. But for the CHIMP it should be fine since you can already see the omega particles upon closer inspection and removing the chip would give you proof it has been tampered with.

Yeah, that would be really bad. I bumped the internal discussion and asked for ideas on an alternative solution that does not require rewriting construction.

If you change the construction node to lead to prototypes with empty batteries it avoids the issue of infinite shots via screwdriver.
It's definitely a bit of a nasty bodge though, and I think we do probably need to get construction to preserve power at some point.

if I fix the merge conflict can we just merge this

patience young one

authors: ArtisticRoomba Cojoke-dot DieselMohawk Flareguy IProduceWidgets K-Dynamic gusxyz slarticodefast sleepyyapril


text:
Makes secure crates harder to break into

Made a metallic damage type that can't be damaged below a rather high threshold (read: nearly impossible to break without high end weapons like captains sabre or guns / laser weapons). This means far less cargonia.
:cl:

tweak: Sad day for Cargonia. All secure crates have been buffed so your basic tools won't break them anymore,

yo can this be applied to doors

Fixes #5742

I only partially agree with this. I think that without the emag being in, this makes cargo traitor borderline impossible. Raising the threshold on the gun crates is fine, since that gives security plenty of warning when they hear the inevitable emitter noises - but I think cargo should be reasonably able to build an AME if they want, or get bombsuits.
A better solution would be to implement order history on the console and put cargo computers in the HoP office/on the bridge in most stations to make it clear if and when cargo orders guns.

What if I PR an initial version of the emag (opens + breaks doors, crates, lockers)? Both will merge at the same time cos feature freeze right?

I only partially agree with this. I think that without the emag being in, this makes cargo traitor borderline impossible. Raising the threshold on the gun crates is fine, since that gives security plenty of warning when they hear the inevitable emitter noises - but I think cargo should be reasonably able to build an AME if they want, or get bombsuits.
A better solution would be to implement order history on the console and put cargo computers in the HoP office/on the bridge in most stations to make it clear if and when cargo orders guns.

Fair comments. It's simple to for now just set the parent for those crates back to genericcrate rather than basesecurecrate or however I named it.
2nd solution assumes you have competent players which right now we do not. We have cargonia every single round and self antags. In Ss13 I don't recall ever being able to break into a crate without a mining mech but I do agree maybe gun crates should realistically be more secure than bomb suit crates or w/e.

On second thought no I think this stands. Cargo shouldn't be able to get stuff in secure crates and if they do want it then they can steal an ID or get HoP.
Cargo making AME is bad stuff.

authors: Mith-randalf Peptide90 TimrodDX


text:
HoP Cloak description had a spelling error

About the PR
The examine description for the HoP Cloak said "shoudlers" instead of shoulders. The most minor thing to fix but this is the limit of my abilities.
Changelog

:cl:

fix: HoP's cloak description now correctly drapes over your shoulders instead of your "shoudlers"

you removed soul


text:
hovering over header links leaves remains

when you hover the main header links the text decoration leaves some remains

That's almost certainly a browser bug.

How much do you hate this as a fix? https://cdn.discordapp.com/attachments/240556998112968704/712422027872436234/simplescreenrecorder-2020-05-19_17.33.01.mp4

Change the colors a bit so they're not as harsh and it's probably fine.

source: gharchive/issue

repo: space-wizards/website-content


text:
Check for updated docker image before running system tests

Right now, if I run system tests locally, I have to remember to make dockerpush with my latest code changes, or else a.) all of the tests will fail with a very opaque error (if I forget to push any image matching the current branch), or b.) they'll run against an older version of the code. It shouldn't be too hard to add a check that a docker image has been built, and pushed to dockerhub, containing the current code in the branch, every time we try to run system tests. The workflow should be something like:

make dockerbuild in the current branch
Compare the output image hash to the latest image hash with the same tag on dockerhub
Print a meaningful error, and do not start system tests, if an image matching this tag and this hash isn't found on dockerhub

This might also prevent issues like the one we ran into today in #2328

Running make dockerbuild is costly, so we don't want to run it on repeated runs (otherwise, making it a step in the testing code is simpler than your solution).
Here's an alternative: We could use tags that are the commit hash instead of the branch name. We could first check if a tag exists and run a build and push only if it doesn't. This doesn't account for cases where we run with uncommitted changes, so we could check if the repo is dirty and if it is - add the timestamp (or some other differentiating value) to the tag name - causing a new build for every run in that case.

I stupidly made this same mistake again. We should address this.

This doesn't account for cases where we run with uncommitted changes, so we could check if the repo is dirty and if it is - add the timestamp (or some other differentiating value) to the tag name - causing a new build for every run in that case.

I think we already handled this part, by adding -dirty to the tag name in this case.

authors: lrettig noamnelke

repo: spacemeshos/go-spacemesh


text:
fixed all lint errors in prque, mainly fixed comments.

Motivation
clean code
Changes
fixed comments

bors merge

bors r-

Merged as part of Consolidated linting (#1958)

authors: antonlerner noamnelke y0sher


text:
Clean up log output

Motivation
Closes #1570
Closes #1923
Closes #1973
Changes
One minor bugfix (489089398e1170232cf89947ae9a038458d98994). The rest of the changes are cosmetic, affecting log output only.
TODO

[x] Fix bytes representations to something readable: Failed sending HARE_PROTOCOL msg [123 129 185 230 148 211 148 26 48 31 95 93] to (already fixed in 1fc34b2a9e2578570b33077cb1371e6f8d743420)
[x] In the message Failed sending newBlock msg [22 91 102 90 183 144 70 218 165 121 166 12] to 6S3sSsvzYv4kb2oQLsbCHae2xS5GtLKU6JvTCMMfG6uP, reason=connection was closed the peer name is not the correct peer we failed sending the message to.
[x] In the log could not get result for layer in range there is "error":"no result for the requested layer" The word error should not appear (#1951)
[x] Block id is now a short string/id of 5 characters -- causes too collisions (in the logs) -- should be longer (12 char. ?)
[x] "got new ATX" should include all possible information: similar to the info in "ATX published!" + other ATX fields (in particular `epoch_id').
[ ] fix JSON in starting build atx in epoch %v and re-entering atx creation in epoch %v (CAN'T FIND)
[x] late hare messages (late preround / "contextually invalid message") should include the node_id that sent the message. "contextually invalid" is not a good name - should be "late" / "not in time" (if too early)
[x] we have sending message failed %!(EXTRA *service.DataMsgWrapper=&{true 6 1 [113 169 217 46 19 216 93 89 35 103 13 132 9 97 7 74 149 179 217 161 81 4 131 209 229 113 105 88 151 40 90 48]}, string= error: , *errors.errorString=connection was closed) as well as peer responded with nil to poet request DFjCnmocNHoa3Kyd16LWQpFTTcRZThP1CS6vuB8WvFEj%!(EXTRA []uint8=[113 169 217 46 19 216 93 89 35 103 13 132 9 97 7 74 149 179 217 161 81 4 131 209 229 113 105 88 151 40 90 48]) should fix the presentation to something comprehensible (in all relevant places)
[x] see also:
handle atx request {atx_ids %!s(zapcore.FieldType=15) %!s(int64=0) [ca1cfd21703c8ed26655722c3da2f37a009ec7aeabe2131140498422af57514a b1a56aa5afc2d523f7d1c907c88bd579ecaa29d5dbfaf947cbc9d06d84c19a67 d5b4af7d28cf9df9d8ef568e843a7544cd5a78d5a1760ee91971441d851a61c9 789885c3ac2307cad568ca9fa70de707dcb434b8353fe923f396cd1180ba8647 6c34150b8a2bd843246185c3b8f84a2f15424493ce4608c0ed25426db941026a ] <nil>}
[x] Reward calculated appears twice in each layer
[x] Fix atx size %!s(int=18956)%!(EXTRA log.Field={atx_id 15 0 f6f9c <nil>}). It is better if this is part of the "ATX published!" log
[x] Add epoch_id to "I've created a block"
[x] unfamiliar atx was requested (id: %s), fix %s
[x] Add duration to "finished PoST execution"
[x] Any log about the initial post creation / proof root etc.?
[x] the function CalcActiveSetSize should print the calculated active set size. Can write it under done calculating active set size
[x] block created should have associated ATX in short string
[x] fetched all block data or adding block should have associated ATX in short string
[ ] already synced for layer appears every 10 seconds. Consider the benefit of printing it (CAN'T FIND; node is synced?)
[ ] "release tick" log statement should include epoch ID and node ID (#1980)
[x] Blocks coming by fetching (as opposed to gossip) should have all the logs as in got new block. Currently some logs are under the start handle block log (in the handleBlock() function).
[x] got new atx should have longer ids than 5 characters (atx_id, _sender_id etc.) to prevent collisions and displaying inaccurate information. (For dashboard purposes)
[x] miner %v is eligible for %d blocks on %d layers in epoch %d should print the actual layers not just no. of blocks in this epoch
[ ] new state root printed twice per layer (won't fix: https://github.com/spacemeshos/go-spacemesh/pull/1952#issuecomment-612502720)
[ ] @ilans: can every log line include node_id, epoch, and layer? (#1980)
[x] certificate validation duration and SVP validation duration => DEBUG
[x] Hare prints Should not participate but it doesn't print anything if the node is participating in this round
[x] 2020-03-26T03:28:45.451Z        INFO    21f52.sync              handle tx request {atx_ids %!s(zapcore.FieldType=15) %!s(int64=0) [30783166303036303034653361383433613438653630633031393830366330646531393865...
[x] ALL log messages regarding messages from p2p (not local things) should include the sender's node_id.
[x] block has no missing blocks in view INFO -> DEBUG
[x] Allocated cache and file handles

"release tick" log statement should include epoch ID and node ID (why is it missing node ID?)

This one is tough. Neither the ticker nor the clock, which it lives inside of (and which instantiates it), knows anything about epochs or about the current node. I don't know why the log statement isn't printing the node_id - maybe something to do with the fact that it's an "event"?

new state root printed twice per layer

Once is after applying rewards, the other time is after applying transactions. If there are no transactions, the state root will be the same. I think this behavior is correct so I won't change this.

@ilans please review to make sure you're aware of these changes!
@noamnelke would you mind reviewing? 🙏🙏🙏

@noamnelke I fixed the Field/LoggableField type issues. Let me know if you're okay with the way I'm assembling an array of LoggableFields for data structures such as Block:
https://github.com/spacemeshos/go-spacemesh/pull/1952/files#diff-a5963108f18ed56664af656e1536751eR157
also ActivationTx:
https://github.com/spacemeshos/go-spacemesh/pull/1952/files#diff-fbc8f466cd0cde2afe76fa37ca7ee514R178
In the case of Block, it might be possible to use the same LoggableField interface trick you explained to turn the whole thing into a string (so that it could be logged directly), but it would require a bunch of string manipulation. That's why I think returning an array of field types is cleaner.
In the case of ActivationTx, outputting a complete description of the data structure also requires passing in parameters (layersPerEpoch, size) so that's probably not an option.

Found the circular dependency issue. common/types/block_test.go relies on miner.AtxsPerBlockLimit but the miner package relies on common.types. This is why I moved AtxsPerBlockLimit into common.types before. I need to sort this out. Maybe this belongs in a separate constants package as @noamnelke suggested. Or maybe I can just refactor this test.

bors merge


text:
Show parent comment author (if it's there) on the user's comments page

As discussed, I'm fetching parent comments list separately and providing this to UI as a comment_id -> comment pairs

simplified enrichment a bit and verified locally

repo: spaceshelter/orbitar


text:
Introduce Configurable Astrodrizzle call for Cosmic Ray Rejection

This is the first ticket in our effort towards cosmic ray rejection using Astrodrizzle. This work is based off of an architecture discussion between @haticekaratay @Russell-Ryan and myself. Based on our discussions, care is taken to identify the useful components and clean out all the intermediary files. This still isn't fully polished, but I wanted to get this online for review from @Russell-Ryan. ~Still to do: unit test and documentation~

Ok I think I addressed all the comments I could, this PR should be ready for rereview!

Thanks for the review @Russell-Ryan!

repo: spacetelescope/slitlessutils


text:
Can't   expert_portv2  maybe is operation error

Thank your  releases
I run python3 export_v2.py --encoder vitb --input-size 518,error is as follows, already upgrade urllib3 (2.2.2) or chardet (5.2.0),maybe is operation error ,
error is as follows,
kiosk@ubuntu-c:~/worker/deep estimation/tensorrt_version/Depth-Anything-V2$ python3 export_v2.py --encoder vitb --input-size 518
/usr/lib/python3/dist-packages/requests/init.py:89: RequestsDependencyWarning: urllib3 (2.2.2) or chardet (5.2.0) doesn't match a supported version!
warnings.warn("urllib3 ({}) or chardet ({}) doesn't match a supported "
Traceback (most recent call last):
File "export_v2.py", line 47, in
main()
File "export_v2.py", line 37, in main
example_output = depth_anything.forward(dummy_input)
File "/home/kiosk/worker/deep estimation/tensorrt_version/Depth-Anything-V2/depth_anything_v2/dpt.py", line 179, in forward
features = self.pretrained.get_intermediate_layers(x, self.intermediate_layer_idx[self.encoder], return_class_token=True)
File "/home/kiosk/worker/deep estimation/tensorrt_version/Depth-Anything-V2/depth_anything_v2/dinov2.py", line 308, in get_intermediate_layers
outputs = self._get_intermediate_layers_not_chunked(x, n)
File "/home/kiosk/worker/deep estimation/tensorrt_version/Depth-Anything-V2/depth_anything_v2/dinov2.py", line 277, in _get_intermediate_layers_not_chunked
x = blk(x)
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1541, in _call_impl
return forward_call(*args, **kwargs)
File "/home/kiosk/worker/deep estimation/tensorrt_version/Depth-Anything-V2/depth_anything_v2/dinov2_layers/block.py", line 247, in forward
return super().forward(x_or_x_list)
File "/home/kiosk/worker/deep estimation/tensorrt_version/Depth-Anything-V2/depth_anything_v2/dinov2_layers/block.py", line 105, in forward
x = x + attn_residual_func(x)
File "/home/kiosk/worker/deep estimation/tensorrt_version/Depth-Anything-V2/depth_anything_v2/dinov2_layers/block.py", line 84, in attn_residual_func
return self.ls1(self.attn(self.norm1(x)))
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1541, in _call_impl
return forward_call(*args, **kwargs)
File "/home/kiosk/worker/deep estimation/tensorrt_version/Depth-Anything-V2/depth_anything_v2/dinov2_layers/attention.py", line 76, in forward
x = memory_efficient_attention(q, k, v, attn_bias=attn_bias)
File "/home/kiosk/.local/lib/python3.8/site-packages/xformers/ops/fmha/init.py", line 276, in memory_efficient_attention
return _memory_efficient_attention(
File "/home/kiosk/.local/lib/python3.8/site-packages/xformers/ops/fmha/init.py", line 403, in _memory_efficient_attention
return _fMHA.apply(
File "/usr/local/lib/python3.8/dist-packages/torch/autograd/function.py", line 598, in apply
return super().apply(*args, **kwargs)  # type: ignore[misc]
File "/home/kiosk/.local/lib/python3.8/site-packages/xformers/ops/fmha/init.py", line 74, in forward
out, op_ctx = _memory_efficient_attention_forward_requires_grad(
File "/home/kiosk/.local/lib/python3.8/site-packages/xformers/ops/fmha/init.py", line 428, in _memory_efficient_attention_forward_requires_grad
op = _dispatch_fw(inp, True)
File "/home/kiosk/.local/lib/python3.8/site-packages/xformers/ops/fmha/dispatch.py", line 119, in _dispatch_fw
return _run_priority_list(
File "/home/kiosk/.local/lib/python3.8/site-packages/xformers/ops/fmha/dispatch.py", line 55, in _run_priority_list
raise NotImplementedError(msg)
NotImplementedError: No operator found for memory_efficient_attention_forward with inputs:
query       : shape=(1, 1370, 12, 64) (torch.float32)
key         : shape=(1, 1370, 12, 64) (torch.float32)
value       : shape=(1, 1370, 12, 64) (torch.float32)
attn_bias   : <class 'NoneType'>
p           : 0.0
flshattF@v2.5.7 is not supported because:
device=cpu (supported: {'cuda'})
dtype=torch.float32 (supported: {torch.bfloat16, torch.float16})
cutlassF is not supported because:
device=cpu (supported: {'cuda'})
smallkF is not supported because:
max(query.shape[-1] != value.shape[-1]) > 32
device=cpu (supported: {'cuda'})
unsupported embed per head: 64

Hi! I have exactly the same issue. Have you managed to solve it?


text:
Cannot install on Windows + Python 2.7, but can on 3.3, 3.4, and 3.5

I've created a minimal example of installing murmurhash using pip on AppVeyor here: https://github.com/suchow/test-murmurhash. It runs successfully on Windows and Python 3.3, 3.4, and 3.5, but not on 2.7.
The error it gives is:
murmurhash/mrmr.cpp(248) : fatal error C1083: Cannot open include file: 'stdint.h': No such file or directory
error: command 'C:\\Users\\appveyor\\AppData\\Local\\Programs\\Common\\Microsoft\\Visual C++ for Python\\9.0\\VC\\Bin\\cl.exe' failed with exit status 2

Here are the full build logs: https://ci.appveyor.com/project/suchow/test-murmurhash/build/1.0.1/job/r9t9duixfppuaefx#L13.

Microsoft forgot to include that header in VS Studio 2008, it's a common error that's not specific to murmurhash. Please obtain the header, e.g., from https://msinttypes.googlecode.com/svn/trunk/stdint.h and place it in an include directory (e.g., under /include).

Thank you, I can confirm that this fixed the issue.

Btw: we are now packaging stdint.h with murmurhash, so you don't need to download/install it yourself anymore.

authors: henningpeters suchow

repo: spacy-io/murmurhash


text:
release planning: v1.18.0

See milestone at https://github.com/sparklemotion/nokogiri/milestone/32
Keeping the scope of this release pretty small because time is tight.

[x] drop Ruby 3.0, add Ruby 3.4 - #3273

[x] drop Ruby 3.0

https://github.com/sparklemotion/nokogiri/pull/3368

[x] #3369

https://github.com/sparklemotion/nokogiri/pull/3374

[x] add Ruby 3.4

[x] https://github.com/rake-compiler/rake-compiler-dock/pull/130
[x] release rake-compiler-dock 1.6.0 dropping manylinux
[x] use rcd 1.6.0 and ship musl native gems - https://github.com/sparklemotion/nokogiri/pull/3375
[x] revert musl compat hacks - https://github.com/sparklemotion/nokogiri/pull/3384
[x] release rake-compiler-dock 1.7.0 adding ruby 3.4

[x] https://github.com/rake-compiler/rake-compiler-dock/pull/131

[x] https://github.com/sparklemotion/nokogiri/pull/3376

focus on performance improvements

[x] #3266

[x] https://github.com/sparklemotion/nokogiri/pull/3378

[x] go through other candidates

not going to add any more scope at this time

remaining hack day / kwarg PRs and methods

decided not to do this in 1.18

Released v1.8.0.rc1: https://github.com/sparklemotion/nokogiri/releases/tag/v1.18.0.rc1

Release v1.18.0 / 2024-12-25 · sparklemotion/nokogiri

repo: sparklemotion/nokogiri


text:
nth-child broken for DocumentFragment

Task: get last div (with text "3").
d = Nokogiri::HTML::Document.parse('
1

2

3
')
p d.css('div:last-child')
# => [
#  #<Nokogiri::XML::Element:0x769abc name="div" children=[#<Nokogiri::XML::Text:0x769814 "3">]>
# ]

This works fine.
d = Nokogiri::HTML::Document.parse('
1

2

3
')
p d.css('div:last-child')
# => [
#   #<Nokogiri::XML::Element:0x7972b4 name="div" children=[#<Nokogiri::XML::Text:0x797048 "3">]>
# ]

Surprisingly this also works fine. Let's try using :root CSS3 selector:
d = Nokogiri::HTML::Document.parse('
1

2

3
')
p d.css(':root:last-child')
# => [
#   #<Nokogiri::XML::Element:0x96936c name="html" children=[
#     #<Nokogiri::XML::Element:0x96c274 name="body" children=[
#       #<Nokogiri::XML::Element:0x96bedc name="div" children=[#<Nokogiri::XML::Text:0x96bba8 "1">]>,
#       #<Nokogiri::XML::Element:0x970090 name="div" children=[#<Nokogiri::XML::Text:0x96fd70 "2">]>,
#       #<Nokogiri::XML::Element:0x96faa0 name="div" children=[#<Nokogiri::XML::Text:0x96f80c "3">]>
#     ]>
#   ]>
# ]

Ok. Now we see that it implicitly wraps content with "html + body" tags.
Let's try the same with DocumentFragment class
d = Nokogiri::HTML::DocumentFragment.parse('
1

2

3
')
p d.css('div:last-child')
# => [
#   #<Nokogiri::XML::Element:0x97dca4 name="div" children=[#<Nokogiri::XML::Text:0x9db354 "1">]>,
#   #<Nokogiri::XML::Element:0x97dc68 name="div" children=[#<Nokogiri::XML::Text:0x9de414 "2">]>,
#   #<Nokogiri::XML::Element:0x97dc2c name="div" children=[#<Nokogiri::XML::Text:0x9dd9c4 "3">]>
# ]

Nope. It doesn't work.
d = Nokogiri::HTML::DocumentFragment.parse('
1

2

3
')
p d.css(':root:last-child')
# => [
#   #<Nokogiri::XML::Element:0x97dca4 name="div" children=[#<Nokogiri::XML::Text:0x9db354 "1">]>,
#   #<Nokogiri::XML::Element:0x97dc68 name="div" children=[#<Nokogiri::XML::Text:0x9de414 "2">]>,
#   #<Nokogiri::XML::Element:0x97dc2c name="div" children=[#<Nokogiri::XML::Text:0x9dd9c4 "3">]>
# ]

Doesn't work also. Let's try with full body
d = Nokogiri::HTML::DocumentFragment.parse('
1

2

3
')
p d.css('div:last-child')
# => [
#   #<Nokogiri::XML::Element:0x96eccc name="div" children=[#<Nokogiri::XML::Text:0x97c3e0 "1">]>,
#   #<Nokogiri::XML::Element:0x96ec90 name="div" children=[#<Nokogiri::XML::Text:0x97bbac "2">]>,
#   #<Nokogiri::XML::Element:0x96ec68 name="div" children=[#<Nokogiri::XML::Text:0x97e730 "3">]>
# ]

Nope. Seems like nth-child CSS3 selector is broken for DocumentFragment.

Related to #572

authors: flavorjones maximkulkin


text:
sqlite3-ruby.yml - mswin/sqlcipher - install sqlite3

Changing the vcpkg input from "sqlcipher" to "sqlite3 sqlcipher" seems to allow compile & test to pass?  Not.sure.
Also, ci log for 'bundle exec rake test' shows:
info: sqlite3-ruby version: 1.5.0.rc1/1.5.0.rc1
info: sqlite3 version: 3.39.1/3.37.2
info: sqlcipher?: true
info: threadsafe?: true

Not sure what 'sqlite3 version: 3.39.1/3.37.2' is about?
Lastly, CI is ran on Windows 'mingw', which is a Ruby head build, 'ucrt' is also available...  Didn't change.

Hey, @MSP-Greg - thank you for putting this together!
I think the output "3.39.1/3.37.2" is telling us that this isn't working as expected -- I think it's compiling against sqlite3 and dynamically loading sqlcipher. This is pointing at a lack of both compile-time and run-time assertions that we're pulling in the expected flavor of db library, a shortcoming that dates back to the original PR, #232.
I'm going to add a commit onto this PR that will introduce some checking and I think that will confirm my suspicions by failing CI.

@flavorjones
Need.more.coffee.
Thank you!
Last night I looked here to double check whether it was running CI against mswin.  I'm working on some custom Ruby builds, and wanted to see about extension gems.  This morning I'm looking at the code...

I think the output "3.39.1/3.37.2" is telling us that this isn't working as expected

So that's runtime vs compile, correct?  Question - if one builds with sqlcipher, can one use it just like 'normal' sqlite3?  Or, is it mutually exclusive?
Regardless, I've got vcpkg locally, anything I can check about the sqlcipher install?

Installed vcpkg sqlcipher locally.  Two files sqlcipher/sqlite3.h and sqlcipher/sqlite3ext.h.  Haven't installed vcpkg sqlite3 yet.

I rebased onto master and added checks to extconf.rb and the test suite. Let's see what that tells us before I speculate on the vcpkg packages.

I came up with a possible solution, not sure about naming, etc.  Seems like all CI passes.  I rebased a few hours ago, and added a commit.  Might be a bit hacky...
Test suites:
https://github.com/MSP-Greg/sqlite3-ruby/actions/runs/2827064397
https://github.com/MSP-Greg/sqlite3-ruby/actions/runs/2827065516
sqlcipher log:
https://github.com/MSP-Greg/sqlite3-ruby/runs/7751455763?check_suite_focus=true#step:6:59
Seems like the main issue is that vcpkg sqlcipher is the only platform with the two header files in an sqlcipher folder?

Your solution seems reasonable to me, though I'm realizing now there are a few problems that are interacting here:

the vcpkg header path issue (which your commit fixes!)
macos seems to have a problem with compiled version vs loaded version as well, which fails the test I just introduced in this PR, see https://github.com/sparklemotion/sqlite3-ruby/runs/7751685748?check_suite_focus=true#step:7:10 for an example
the library seen at extconf time is not sqlcipher as expected on mswin 2022, see https://github.com/sparklemotion/sqlite3-ruby/runs/7751684731?check_suite_focus=true for an example

I'm going to add your commit to this PR to see what happens.

I'm going to add your commit to this PR to see what happens.

Sorry, forgot.  The vcpkg input needs to be vcpkg: "sqlcipher", then it should work...

Right, thanks. Fixed!

libname is called a few times, should that value be saved?  Maybe lib_name, @lib_name, or something?

extconf.rb - wondering about the statement elsif find_header("#{libname}/sqlite3.h").  maybe should be:
elsif @lib_name == 'sqlcipher' && find_header("sqlcipher/sqlite3.h")?

Trying to tighten what runs it, as the only problem is mswin & sqlcipher?

:thinking: I'm going to remove my attempt in the extconf to determine whether the libraries is "really sqlcipher", because the sqlcipher library doesn't appear to present that information in a stable, predictable way.
That will get mswin green, I think. I'm still worried about macos versioning being strange, but I can handle that in a different PR.

@MSP-Greg I'm not too worried about making this code perfect -- sqlcipher is an edge case that I don't think many people opt into, and if they do they're responsible for bringing their own (and using the config flags if necessary).
If you'd like to clean it up, I'd be happy to take it, but I'm a bit under water today and won't get to it.

I think this can be merged! @MSP-Greg thanks again for digging in on this. Are you OK with the changeset as-is?

Are you OK with the changeset as-is?

Yes.  Maybe later we can look at reducing the calls to some methods.  Thanks for the quick review, etc...
JFYI, SQLCipher has a new release (4.5.2, uses SQLite 3.39.2), opened a PR in vcpkg to update it.  Haven't checked MSYS2 yet.

authors: MSP-Greg flavorjones


text:
Support pandoc > 2.0.0

Currently nbsphinx complains with a warning about pandoc being version 2.0 or higher.
On macOS, you get only pandoc 2.2+ via Homebrew, on Debian you still get 1.x from the package manager, but it is easy to download the latest pandoc version as a single binary from their git: https://github.com/jgm/pandoc/releases
Is there any plan to add support for pandoc > 2.0.0?
Thanks!

This warning actually comes from the nbconvert module.
I've asked about it in https://github.com/jupyter/nbconvert/issues/928
And there is a further issue and a PR:

https://github.com/jupyter/nbconvert/issues/815
https://github.com/jupyter/nbconvert/pull/933

Feel free to leave a comment there!
It looks like there is no progress in nbconvert, probably I'll have to avoid this warning from within nbsphinx.

BTW, pandoc >= 2 is fully supported, this warning message can be ignored.

Thank you!

I was able to get this warning to go away by adding this to my environment.yml file - which I use with conda like conda env update -f environment.yml:
name: my-conda-env
dependencies:
  # this version is needed to make sure pip upgrades are actually run
  - conda>=4.6.13
  # other stuff...
- pip:
  # using nbconvert master until v5.5 comes out
  - git+https://github.com/jupyter/nbconvert@master
  # other stuff...

When v5.5 lands, you can probably remove this nbconvert line/dependency.

@aaronmarkham It looks like nbconvert was released just a few hours before your comment (also on conda-forge).
I guess this issue can be closed.
Please comment if there are still problems!

authors: aaronmarkham dmfigol mgeier

repo: spatialaudio/nbsphinx


text:
Echo appears when blocksize is around 0.7 sesonds

I use this example of "Input to Output Pass-Through": wire.py
But when blocksize is 8*4096 (around 0.7 seconds with samplerate = 44.1 kHz) I hear echo for every sound.
Is it expected behaviour or is it bug? How can I fix it?
P.S.: my requirement is blocksize should be not less than 8*4096

By the way, when blocksize is less than 4096 there is no echo.

With echo do you mean that the input signal is played twice (once delayed) via the output?
Or is the input only played twice and you perceive it as an echo? The latter can be considered as part of a known psychoacoustic effect commonly called "echo threshold". Above a certain delay, around a few tens of miliseconds according to literature, two partially coherent sound events transition from being perceived as a single event to being perceived as a distinct echo.

Any news on this @sergorl?
It might also be helpful to switch from loudspeakers to headphones (or vice versa) and to hear if the perceived echo is the same.
But be careful to avoid acoustic feedback when using loudspeakers.

authors: HaHeho mgeier sergorl

repo: spatialaudio/python-sounddevice


text:
Bugfix/sim player auth issue

Description
Sim client scripts run in parallel could fail due to conflicting permission requests. This change implements a simple lock to ensure only one script does the initial user modifications and fixes https://improbableio.atlassian.net/browse/UNR-3280
Tests
https://buildkite.com/improbable/product-research-benchmarks-run/builds/9124
Primary reviewers
@aleximprobable @improbable-danny

I think I may have been requested as a mistake instead of @improbable-danny?

authors: ashleydavies m-samiec

repo: spatialos/UnrealGDK


text:
bug: installation error on networkx

Trying to install on the ucr cluster I'm hitting:
Processing dependencies for osnap==0.1.0
error: networkx 2.2 is installed but networkx<2.0.0 is required by {'region'}

Will investigate. Wanted to flag it here in case other had hit this?

Yeah I get this error on every install, but nothing is broken afaict.

not sure why region is pinned to the older version. The solution might me to update that dependency in region/spopt

we’re defining networkx as a dependency for onsap, so it’s getting installed before region, then we get the warning once the installer gets to region. We don’t really need networkx outside of region, so we could remove this dependency and just allow installation of the version that region is pinned to?

I think this is resolved by #72

authors: knaaptime sjsrey

repo: spatialucr/osnap


text:
Make models with HasBinaryUuid trait serializable when the model key is not selected

Right now this injects the key to the returned array, even when the key is not selected. Which makes Model::select(fields) a pain to use when the primary key is not selected.
Problem:
// Model with `HasBinaryUuid` trait
Model::select('created_at')->first()->toArray();

Throws an error saying uuid cannot be null:

TypeError: Argument 1 passed to Model::decodeUuid() must be of the type string, null given, called in spatie/laravel-binary-uuid/src/HasBinaryUuid.php on line 89

This is fixed, thanks to your PR; in 1.1.7: https://github.com/spatie/laravel-binary-uuid/releases/tag/1.1.7

repo: spatie/laravel-binary-uuid


text:
setManipulations Watermark path

I am trying to add a watermark to my image:
$this->addMediaConversion('large')
    ->setManipulations(['fm' => 'jpg', 'mark' => 'watermark.png', 'markw' => '40', 'markh' => '40', 'markpad' => '15', 'markpos' => 'top-left'])
    ->performOnCollections('images');

Following the Glide doc (http://glide.thephpleague.com/1.0/api/watermarks/) I added a new filesystem for watermarks, in the laravel's config/filesystems.php file.
However, my generated thumb doesnt have any watermark on it. And there is no log error report.
Where should I place my watermark.png file ? I tried in storage/images and storage/watermarks and even modifying  'mark' => storage_path('images/watermark.png') but I can't get it working.

Could try using the absolute path to you watermark file?

Hi, I tried absolute path
GlideImage::create(public_path().'/uploads/posts/cropped-1555.jpg')
->modify(['mark' => '/home/vagrant/Code/mysite/public/uploads/posts/mark-100h.png'])
->save(public_path(). '/output.jpg');
with no luck.

This has been fixed in v.3.0.1. You can now use the absolute path in the mark parameter.

Tested it on local and production, works like a charm using public_path()
Thanks for the fix!

authors: PhilMarc freekmurze tlandn

repo: spatie/laravel-glide


text:
Some arrows in the generated puml are pointing in the wrong direction

I think that all <|-- arrows should point in the other direction --|>

You are correct, @maxhbr. I'll fix this.

Fixed in https://github.com/spdx/spec-parser/commit/2e8a8c6942810af732a461dd107e63e43cdc87ed

authors: maxhbr zvr

repo: spdx/spec-parser


text:
CLI: read version from document if not provided

Currently it defaults to "SPDX-2.3" and raises a validation error if the document is of another version.

fixed by #442

repo: spdx/tools-python


text:
fix the source for search domains

What this PR does / why we need it:
This PR fixes the source of DNS search domains, to retrieve the value from IPPool annotations.
Which issue(s) this PR fixes:
Fixes #19

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: abhinavnagaraj
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [abhinavnagaraj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: abhinavnagaraj, jzhoucliqr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [abhinavnagaraj,jzhoucliqr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

authors: abhinavnagaraj jzhoucliqr spectro-prow


text:
how to inference in .py  not shell

how to inference in .py  not shell

Hey, it depends on what you would like to do (exactly). If it's from hugging face, you can just copy and past the "commands" otherwise, you might want to describe a bit more what you would like to do so we can help

i want inference from wav file or stream, what can i do ?

From wav file inference, you can basically take a look here:
https://huggingface.co/speechbrain/asr-crdnn-rnnlm-librispeech
As you know, we have special classes designed to do inference on different
models.
On Fri, 19 Mar 2021 at 06:13, Arthur Wu @.***> wrote:

i want inference from wav file or stream, what can i do ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/speechbrain/speechbrain/issues/585#issuecomment-802713272,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEA2ZVV37V5SFUNDAWFTFI3TEMPWNANCNFSM4ZN7WROA
.

authors: TParcollet mravanelli wac81

repo: speechbrain/speechbrain


text:
Support OpenSCAD

This pull request adds the language OpenSCAD: https://openscad.org/
For now it belongs to "programming" category but I think we should create a "modeller" category.
I'm even have the ascii art for onefetch but if I'm not wrong is still not supported there? just until gengo is merged?
                 ________
             .:------------:   ...
          .-+=             =+=-    :.
        :+***               +**=:   .:.
       =*****+             +*****=    -.
      +**********+++++++**********+    -
     =*****************************=   -
    .*+==+********************+++***. .:
 .::-:.   .-+***************-     =*-..
-.    .:.    -************=        *.
=       .:.   :**********-        :+
=         :.   =********=        .+.
.-         -   .********-       :=.
 .-.       :   =********+.   .:=-
   ::     .-:=************++==:
     ·...·   .-=++*****++=-.
                ---------

[X] If this language conflicts with another language (same extension), I've added heuristics
[X] If this language conflicts with another language, I've linked to the pull request that added the other language here:

Awesome, thanks! Would you be willing to add a sample to the samples-test/samples directory?

I'm even have the ascii art for onefetch but if I'm not wrong is still not supported there? just until gengo is merged?

Yeah until https://github.com/o2sh/onefetch/pull/1305 is merged we use tokei to detect languages. It doesn't look like tokei supports OpenSCAD yet.

I added a sample file, I contacted author of sFeeder project and let me use the OpenSCAD script.
https://github.com/mgineer85/sFeeder/pull/1#issuecomment-2091367657

OK, cool, I guess with that explicitly stated permission we're good. Thanks!

authors: hasecilu spenserblack

repo: spenserblack/gengo


text:
noTimes feature broken for some files

According to #574 and the documentation, running hugo --noTimes=false should cause Hugo to keep the modification time of files copied from static. This would avoid superfluous uploads when synchronizing via FTP, for instance.
However, it seems that Hugo applies the original modification time for some files on the second run of hugo only. For instance:
$ rm -rf public
$ ls -lart@ static/test
-rw-r--r--  1 mburger  staff       0  1 Jan  2014 somefile
-rw-r--r--  1 mburger  staff       0  3 Apr 18:53 someotherfile
-rw-r-----  1 mburger  staff  295061  3 Apr 18:53 some.pdf
drwxr-xr-x  5 mburger  staff     272  7 Apr 07:07 ..
drwxr-xr-x  2 mburger  staff     170  7 Apr 07:17 .
$ hugo --noTimes=false
[...]
$ ls -lart@ public/test
-rw-r--r--   1 mburger  staff       0  1 Jan  2014 somefile
-rw-r--r--   1 mburger  staff       0  3 Apr 18:53 someotherfile
drwxr-xr-x   2 mburger  staff     170  7 Apr 07:17 .
-rw-r-----   1 mburger  staff  295061  7 Apr 19:45 some.pdf
drwxr-xr-x  11 mburger  staff     612  7 Apr 19:45 ..
$ hugo --noTimes=false
[...]
$ ls -lart@ public/test
-rw-r--r--   1 mburger  staff       0  1 Jan  2014 somefile
-rw-r--r--   1 mburger  staff       0  3 Apr 18:53 someotherfile
-rw-r-----   1 mburger  staff  295061  3 Apr 18:53 some.pdf
drwxr-xr-x  11 mburger  staff     612  7 Apr 07:07 ..
drwxr-xr-x   2 mburger  staff     170  7 Apr 07:17 .

As you can see, file some.pdf gets the original modification time on the second run only.
Interestingly enough, running hugo --noTimes=true causes exactly the same behavior.
Note that I am running Hugo 0.13 installed via Homebrew on OS X Yosemite 10.10.2.

I just saw that command line argument noTimes is referred as notimes:
syncer.NoTimes = viper.GetBool("notimes")
Source: https://github.com/spf13/hugo/blob/master/commands/hugo.go#L281
Maybe that typo, if any, in use of capital and small letters causes this issue?

No, viper isn't case sensitive.

I just opened issue mostafah/fsync#4 as this issue here might be caused by that library.

Hugo uses package spf13/fsync (see: hugo.go#L29) which was forked from mostafah/fsync.
In that fork, support for "Afero - A FileSystem Abstraction System for Go" was added in commit 1fdf08f. As far as I understand that change, one might have forgotten to adapt feature "update dst's modification time" which implements preservation of file modification time.
While many (well, almost all) calls to os-interfaces have been replaced by calls to alternative interfaces provided by Afero, in that very line that replacement has not been followed through. I think it is very likely that this is related to this issue.
I would have opened an issue in spf13/fsync; however, issues seems to be unavailable in that project.

@martinburger Thanks for your detective work.
@spf13 not sure what's the reasoning behind the fork? Keep it or do some merging?

The only reason for the fork is to add support for afero which was experimental so I didn't want to contribute it back to the main fsync project yet. It's also a big change for them to be dependent on a new project.
I think we should update spf13's fork to include the latest commits to the upstream one and reach out to see if we can't combine efforts. I think afero is pretty stable and well tested at this point.

@martinburger sorry for this late response. I have looked at the code and the arero correctly delegates to os.Stat, so it should work ...
I will test this myself on LInux (I use content hashing to synch changes), but I suspect this must be an OS issue of some kind.

Just tell me if I could help debug somehow.
Am 24. April 2015 03:04:35 MESZ, schrieb "Bjørn Erik Pedersen" notifications@github.com:

@martinburger sorry for this late response. I have looked at the code
and the arero correctly delegates to os.Stat, so it should work ...
I will test this myself on LInux (I use content hashing to synch
changes), but I suspect this must be an OS issue of some kind.

Reply to this email directly or view it on GitHub:
https://github.com/spf13/hugo/issues/1054#issuecomment-95765685

Hi @martinburger,
Thank you for reporting this issue.  I think we have found the problem and solved it.  Please read mostafah/fsync#5 for the discussion, and mostafah/fsync@42330bf for the fix.  :-)
As you may have noticed, the some.pdf in your example had a special permission of 0640 rather than the usual 0644 for umask 0022.  So, in the first run, when some.pdf was first copied from static/ to public/ for the first time, fsync had to do the extra work to change the permission bits of public/some.pdf, but then the code promptly return before it has chance to set the modification time.  In the second run, since the file permissions were already identical, it did not fall into the return trap and finally reached the code to sync modification time.
The return had been there since September 2012 when the code only sync'ed permissions, and it was perfectly fine to be there, whereas "sync-mtime-too" was a new feature added in October 2014, so it must have been too easy to miss that innocuous return.
Once recent mostafah/fsync fixes are merged into spf13/fsync (see spf13/fsync#2), please test hugo --noTimes=false again to make sure it works for you too.  Thanks in advance!

Hi @martinburger,
spf13 is quick!  Before I knew it, spf13 has already merged the fix!  (Thanks spf13!)
So, when you have time, please verify if this fixes your problem!  Many thanks!

I just tried to reproduce this bug with above test case and v0.15. Fortunately, without success. :-)
Furthermore, when I deploy my site via ftp, only files that have been actually changed are synchronized to the server, while other unchanged files - like static PDF files - do not cause superfluous uploads anymore. This saves a lot of time. Thanks!
Thus, I close this issue as resolved / fixed.

authors: anthonyfok bep martinburger spf13


text:
Question : best way to translate failf messages ?

If I want to write a non english interface, what is the best way to translate the error messages ?

@kpym There is currently no easy way. There was some work on this in #114. I think if you really wanted to, you could maybe hijack stdout and do the translation there, but that seems like a mess.
I've been giving this a little thought recently on my fork and was looking at using the new i18n package, but didn't come up with an elegant API yet. If you'd like to try your hand at a PR on my fork, I'd definitely take a look!

@cornfeedhobo Thanks for your advice. Probably I'll use text/transform to hijack this.

authors: cornfeedhobo kpym


text:
DOCO: the docs claim a default value parameter

The docs mention a default value parameter, but there is none.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant bhamail


text:
[text] Artist and song name are misaligned and first letters are cut off

Describe the bug
Artist and song name are misaligned and first letters are cut off
To Reproduce
Steps to reproduce the behavior:

launch spotify with text theme installed
Expected behavior
artist and song name are fully shown

Specifics (please complete the following information):
OS: [win11]
Spotify version [1.2.13.661]
Spicetify version [v2.36.1]
text

The theme is incompatible with the Cover Ambience extension; it's not the theme itself that is broken.

Sadly the issue still occurs after uninstalling Cover Ambience extension.

Okay, so when I hid the song cover that's in the left bottom corner, the text aligned correctly, but now I don't know how to get the image back 🤔

What are you using to get the image on the left side there? If its like that by default, then you're running an older spotify version that the theme may not be compatable with.

authors: darkthemer harbassan krolremizy

repo: spicetify/spicetify-themes


text:
Colors are inverted

The colors in Street View are inverted, and both Street View and Map (on the bottom left) show "The page can't load Google Maps correctly." on startup.
Find the screenshot.

I am having this issue as well. Did you find a solution for this?

repo: spider-hand/Geoguess-Master


text:
Night CI 2023-03-17: Failed

action url: https://github.com/spidernet-io/spiderpool/actions/runs/4451267907

The same issue as #1477.

authors: iiiceoo weizhoublue

repo: spidernet-io/spiderpool


text:
Plot quirks

Plot quirks to check:

[x] plot_task_structure: check inputs for event lines (seems to require lists, but inputs of arrays are common)
[x] plot_position_1d: passing in a custom alpha value fails

Addressed in #178 - closing here

repo: spiketools/spiketools


text:
chore(ci): Mergify - merge Autobumps on release-*

And request review for failed autobump builds on master and release branches.
Lastly, remove Travis CI related rule. It's not used.

@mergifyio backport release-1.27.x release-1.28.x

authors: dbyron-sf kskewes-sf


text:
New feature request: Physics modify support

How can we get/set physics properties
And enable/disable(Play/Pause) physics
An example will be nice

Any updates or any idea if this is possible, if yes then please provide a stand-alone sample

hi any updates

this is much needed and will be very useful

repo: splinetool/react-spline


text:
qintelpmi: New App - Initial Commit of the Qintel PMI App

Pull Request Checklist
Please check if your PR fulfills the following requirements:

[X] Testing of all the changes has been performed (for bug fixes / features)
[X] The readme.html has been reviewed and added / updated if needed (for bug fixes / features)
[X] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[X] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[X] Verify all checks are passing.
[X] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[X] Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type
Please check the type of change your PR introduces:

[X] New App
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation
[ ] Other (please describe):

Security Considerations (REQUIRED)

[ ] If you are exposing any endpoints using a REST handler,
please document them in the readme.html.
[X] If this is a new connector or you are adding new actions

[X] Please document in the readme.html all methods (eg, OAuth) used to authenticate
with the service that the connector is integrating with.
[ ] If any actions are unable to run on SOAR Cloud, please document this in the readme.html.

[ ] Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
[ ] Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
the Vault API.
[ ] Are you are marking code to be ignored by Semgrep with nosemgrep?
If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

Initial release, providing the "get cve intel" command

What is the current behavior? (OPTIONAL)

NA

What is the new behavior? (OPTIONAL)

New App

Other information (OPTIONAL)
Pay close attention to (OPTIONAL)
Screenshots (if relevant)

Thanks for contributing!

Hello @calvin-qintel,
In order to speed up the review process, we request pull request authors to grant us edit permission for the branch.

@ishans-crest I am unable to provide edits for maintainers since Github doesn't seem to currently support this for forks living under an organization. See here for how this was handled last time we submitted.

The changes are incorporated in PR2 and the app is released.

authors: calvin-qintel ishans-crest

repo: splunk-soar-connectors/qintelpmi


text:
fix: resolving rate limit issue

Fixed two issues:

429 rate limit
Docker pull limit per hour

Reduced api calls from around ~100 to 1.
Redesigned the splunk_matrix_update.py file and added doc strings for better understanding.

Incorporates https://github.com/splunk/addonfactory-test-matrix-action/pull/175.

:tada: This issue has been resolved in version 2.1.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

repo: splunk/addonfactory-test-matrix-action


text:
make labels a bit shorter

We need to prevent the labels for the name of a search from being too long because it can cause issues in the user interface.
As such, we have removed the words - Experimental -, - Deprecated -, and - RIR - from the action.correlationsearch.label field in savedsearches.conf.

Tested on Gamorr, the build looks good!  Originally this search errors out when we try to save this. Not any more:
Slack Thread: https://splunk.slack.com/archives/C06S8S085HP/p1722267799266179
Testing:

repo: splunk/contentctl


text:
Exception: Read  where  or  was expected.

Error raised by Splunk Client .net core version :
Read </results> where <result> or <response> was expected.
When executing:
using (SearchResultStream results = await client.ExportSearchResultsAsync(search, searchExportArgs))

I managed to get a trace:
Method: GET, RequestUri: 'https://splunk:7089/services/search/jobs/export?search=search index%3Dvast sourcetype%3Dvast%3A eventtype%3Dvast_detection_event earliest%3D1634870997 latest%3D1634871222 | sort 500000 %2B _indextime&f=HOST_ID&f=IP&f=PORT&f=PROTOCOL&f=TRACKING_METHOD&f=TYPE&f=severity&f=_indextime&f=_time&f=_cd&max_count=5000', Version: 1.1, Content: , Headers:
{
Cookie: splunkd_7089=NDgRyfr4E7LciL7MTXmk0CTt7jkmp83QMMuzHVt_AqfvF004Ss2VjZmFmMY_cnu33RHj_jwomfeRuZruHTa5m_mtPJh8IqJopYiDvM9f^EzNeVdofdbkA9Mk79sSaN7MsdL
User-Agent: splunk-sdk-csharp/2.2.8
}

HOST_ID
IP
PORT
PROTOCOL
TRACKING_METHOD
TYPE
severity
_indextime
_time
_cd

Your timerange was substituted based on your search string

Throws error:
Read  where  or  was expected.
Also the user agent is not what I expected, probably should have been something like: splunk-sdk-csharp-core/1.0.7

Splunk Server
Version: 8.2
Build: e053ef3c985f

This SDK is deprecated and no longer under active development.

authors: YulerB ncanumalla-splunk

repo: splunk/splunk-sdk-csharp-pcl


text:
read me documentation regarding -egg splunk-sdk install step

when I perform the pip install --egg splunk-sdk step per steps in the read me i get the following:
no such option: --egg
is this older for python2.7 perhaps?

Hi @hiqqs , sorry for the delay in response. Support for --egg has been deprecated from pip since v9.0.0(2016).
Thanks for bringing this to our attention, we will be updating the README to avoid any such confusions.

authors: ashah-splunk hiqqs

repo: splunk/splunk-sdk-python


text:
WIP: TabbedCard component

Hey, I just made a Pull Request!
TabbedCard component
:heavy_check_mark: Checklist

[x] All tests are passing yarn test
[x] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[x] Prettier run on changed files
[ ] Tests added for new functionality
[ ] Regression tests added for bug fixes

Veery early example. I'm creating PR to discuss how we want to do with controlled/uncontrolled mode of the component. Currently it's just a very thin layer on top of Material UI.
Do we want it to work without manually setting the values of the selected tab etc, and if we do, do we still want to keep the option of setting it manually?
I've also moved the BottomLink component to the layout folder for reusing it in TabbedCard. It feels a bit wrong to have it there, but i can't think of a better place atm. Any suggestions?

For some reason the PR seems a bit broken. I based it on the InfoCard typescript branch and now GitHub doesn't realise that has already been merged...

Could you please add a screenshot?

I updated the component to use a simpler API. The styling is not entirely done yet, but some feedback on how the API looks is welcome.

Added a option to ignore vars from destructed objects is the rest property is used as a fix to a lint issue i was having. Keep it or should i fix it some other way?

authors: hooloovooo stefanalund

repo: spotify/backstage


text:
Update protobuf-java to 3.15.2

Updates com.google.protobuf:protobuf-java from 3.13.0 to 3.15.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.google.protobuf", artifactId = "protobuf-java" } ]

labels: library-update, semver-minor

Superseded by #384.

repo: spotify/ratatool


text:
debugger statement in the code

The is debugger statement in
https://github.com/spotify/redux-location-state/blob/master/src/createReduxLocationActions.js#L39

@joshbDev @palmerj3  please look on this.

👍 😃

repo: spotify/redux-location-state


text:
Problem in composer requirements

Composer.json file is not correct.
Version for package "doctrine/dbal" is locked ("2.5.4"). It should be "^2.5".
Latest stable version of Doctrine DBAL is "2.5.5". If you use Composer from command line to add Spot2 package on an existing uptodate Symfony project, you cannot install it because you already have Doctrine DBAL "2.5.5" installed.
To bypass this, you must edit your composer.json file manually and add your "vlucas/spot2" requirement BEFORE "doctrine/orm". On next composer update, it will download an install Spot2 and also downgrade Doctrine DBAL to "2.5.4".

Personally I agree. We should be able to trust DBAL does not break BC. However I remember @vlucas mentioning that there is a reason for this. Do I remember correctly?

Yes - I agree that we should be able to trust the DBAL team to not break BC here. This can probably be safely changed.

@vlucas @tuupola This thread may be closed since it's solved.

authors: bgillet hakuno tuupola vlucas


text:
How to execute some code assertion while parsing and get the position?

E.g we have the parsers below. I want to

check the value of a state variable ( foo() : bool )
get the position of the current line and column (the current position)
if the code assertion fails stop trying this rule (when foo() is false this rule should not succeed).
Is this possible in Sprache?

public static readonly Parser<string> QuotedText =
    (from open in Parse.Char('"') if(foo()){ Console.WriteLine(_the current position_)} else {stop to parse this rule};
     from content in Parse.CharExcept('"').Many().Text()
     from close in Parse.Char('"')
     select content).Token();

static readonly Parser<string> Identifier =
            from first in Parse.Letter.Once()
            from rest in Parse.LetterOrDigit.XOr(Parse.Char('-')).XOr(if(foo()){ Console.WriteLine(_the current position_)} else {stop to parse this rule}; Parse.Char('_')).Many()
            select new string(first.Concat(rest).ToArray());

Use Span() to obtain the position and Where() to fail conditionally.
Here is a sample parser fails if the position of b is greater than 10:
static Parser<string> Sample =
	from a in Parse.Char('a').Many().Text().Token()
	from b in Parse.Char('b').Many().Text().Token().Span()
	where b.Start.Pos <= 10
	select a + b.Value;

How to add line and column to an ParseException? As I see Sprache does not add them to the exception.Data object? Is there a global state?
    static readonly Parser<string> _char =
        from first in Parse.Letter select first.ToString();

    static readonly Parser<string> nl =
        from first in Parse.String("\n")
        .XOr(Parse.String("\r\n"))
            .XOr(Parse.String("\r"))
        select "";

    public static Parser<string> verb =
         from aa in Parse.String("verb")
         from a2 in Parse.String("*").Optional()
         from a3 in _char.Not()
         from a4 in Parse.AnyChar
         from a5 in Parse.AnyChar.Except(Parse.Char(a4)).Except(nl).Many().Text()
         from a6 in Parse.AnyChar
         where a4 == a6 ? true : throw new ParseException("MESSAGE") (HOW TO ADD LINE, COLUMN)
         select a2.IsEmpty ? "isVerb" : "isVerb*";

Sprache is stateless, so there is no global state.
To get the position, use Span(), something like this (not tested):
public static Parser<string> verb =
     // ... the first 5 lines are the same ...
     from a6 in Parse.AnyChar.Span()
     where a4 == a6.Value ? true :
       throw new Exception($"Error at: {a6.Start.Line}, {a6.Start.Column}")
     select a2.IsEmpty ? "isVerb" : "isVerb*";

repo: sprache/Sprache


text:
Unable to register automatically

我们鼓励使用英文，如果不能直接使用，可以使用翻译软件，您仍旧可以保留中文原文。
We recommend using English. If you are non-native English speaker, you can use the translation software.
Which Component
eg. Nacos Discovery, Sentinel
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
when i used new SpringApplicationBuilder(DispacherApplication.class).web(WebApplicationType.NONE).run(args); to start springboot2.1.1 ,can not auto register to nacos
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
e.g.  nacos、Java8 、 springboot2.1.1

use this code SpringApplication.run(DispacherApplication.class);,it is work

spring cloud discovery won't register when WebApplicationType.NONE

what should i do ,i want it

As you said, using SpringApplication.run(DispacherApplication.class) to run application.

that's too regretful

commandline 手动注册 namingService.registerInstance("service-dispacher","10.0.41.90",8848);`` @NacosInjected     private NamingService namingService; NPM


text:
Refactor something about SMS & Sentinel

Describe what this PR does / why we need it
as titled.
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews

Codecov Report

Merging #398 into master will increase coverage by 0.01%.
The diff coverage is 4.54%.

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
+ Coverage   38.95%   38.96%   +0.01%
==========================================
  Files         209      209
  Lines        5370     5371       +1
  Branches      554      554
==========================================
+ Hits         2092     2093       +1
  Misses       3129     3129
  Partials      149      149

Impacted Files
Coverage Δ

...ework/cloud/alicloud/sms/endpoint/SmsEndpoint.java
0% <ø> (ø)
:arrow_up:

.../cloud/alicloud/sms/base/TokenGetterForAlicom.java
0% <0%> (ø)
:arrow_up:

.../alicloud/sms/base/DefaultAlicomMessagePuller.java
0% <0%> (ø)
:arrow_up:

...ud/alibaba/sentinel/endpoint/SentinelEndpoint.java
96.29% <100%> (+0.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc01277...14d505b. Read the comment docs.


text:
Invalid CSRF Token 'null' was found on the request parameter '_csrf' or header 'X-CSRF-TOKEN'

I used postman to send a POST request of http: // localhost: 8080 / uaa / oauth / authorize with a Token of type Bearer Token, prompting Invalid CSRF Token 'null' was found on the request parameter '_csrf' or header 'X- CSRF-TOKEN '.

2020-05-16 05:32:26.379 DEBUG 19716 --- [nio-8080-exec-4] o.s.security.web.csrf.CsrfFilter         : Invalid CSRF token found for http://localhost:8080/uaa/oauth/authorize

repo: spring-cloud-samples/authserver


text:
mvn assemble results in build failure

when I try  mvn assemble I get the following output:
[ERROR] Unknown lifecycle phase "assemble". You must specify a valid lifecycle phase or a goal
in the format <plugin-prefix>:<goal> or <plugin-group-id>:<plugin-artifact-id>[:<plugin-version>]
<goal>. Available lifecycle phases are: validate, initialize, generate-sources, process-sources,
generate-resources,process-resources, compile, process-classes, generate-test-sources,
process-test-sources,generate-test-resources, process-test-resources, test-compile,
process-test-classes, test, prepare-package, package, pre-integration-test, integration-test,
post-integration-test, verify, install, deploy, pre-clean, clean, post-clean, pre-site, site, post-site,
site-deploy. -> [Help 1]

mvn package seems to work fine though.

fixed in 9c6f05e24ea821d3a3bf66deac7fac043924eb27

repo: spring-cloud-samples/fortune-teller


text:
If an accessKey or secretKey exists Disable DefaultAWSCredentialsProviderChain

accessKey or secretKey exists, I think it is better not to use DefaultAWSCredentialsProviderChain.

@tramyu Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@tramyu Thank you for signing the Contributor License Agreement!

authors: pivotal-issuemaster tramyu

repo: spring-cloud/spring-cloud-aws