text:
avatar: Remove remaining URL construction for initial load.

This follows up on #4344 to address part of the remaining performance regression from #4230.
We still construct URL objects in the get methods, lazily and memoized; but never up front when simply taking in all the initial data from the server, or the rehydrated data we've stored.  This should save a further slice of time in the initial load.
To do so, we introduce predicates isUrlAbsolute and isUrlPathAbsolute, which have very simple implementations but clearly defined semantics in terms of the URL Standard.

Great, thanks! This LGTM except I wonder about commenting on the new functions with something like, "why might we use these instead of new URL? Because new URL is expensive... (etc.)". That way a well-meaning contributor might be less likely to try to sweep them away for #4146.
Shall I do another round of benchmarking for this change, maybe just before and just after it? It could probably be merged before then, anyway; we certainly don't expect it to make anything worse.

Shall I do another round of benchmarking for this change, maybe take measurements just before and just after it? I'm sure it could be merged before I do so, anyway; we certainly don't expect it to make anything worse.

Ha, well, I went to go and do this, with the timing code that captures both the network time and the transform time (this code). My measurements for before this PR went like this:

(I kept going past 12 because of the surprising drop in times.)
So it seems something happened with my network connection quality that threw the measurements off. I'll set it up to just time transform in api.registerForEvents, then.

I'll set it up to just time transform in api.registerForEvents, then.

OK, here we go. With this logging code (and the other logging code undone):
diff --git src/api/registerForEvents.js src/api/registerForEvents.js
index 655849892..50445f24a 100644
--- src/api/registerForEvents.js
+++ src/api/registerForEvents.js
@@ -5,6 +5,7 @@ import type { ApiNarrow } from './apiTypes';
 import type { CrossRealmBot, User } from './modelTypes';
 import { apiPost } from './apiFetch';
 import { AvatarURL } from '../utils/avatar';
+import * as logging from '../utils/logging';

 type RegisterForEventsParams = {|
   apply_markdown?: boolean,
@@ -69,5 +70,9 @@ export default async (auth: Auth, params: RegisterForEventsParams): Promise<Init
     fetch_event_types: JSON.stringify(fetch_event_types),
     client_capabilities: JSON.stringify(client_capabilities),
   });
-  return transform(rawInitialData, auth);
+  const before = Date.now();
+  const transformResult = transform(rawInitialData, auth);
+  const after = Date.now();
+  logging.logToProfiling({ durationMs: after - before, ip: '192.168.1.7' });
+  return transformResult;
 };

Er, hang on, I'm getting an error:

Thanks for the review and the new measurements!

I wonder about commenting on the new functions with something like, "why might we use these instead of new URL? Because new URL is expensive... (etc.)". That way a well-meaning contributor might be less likely to try to sweep them away for #4146.

I think it's fine because AFAICT there isn't a direct way to answer these questions using URL. Like if I try to write a sentence for the jsdoc like "This is equivalent to [something involving new URL], but more efficient.", I don't see how to fill in the blank.
At the one call site, in avatar.js, there is a comment explaining that, so anyone trying to remove these should pretty quickly find that.
I'm also coming to think that #4146 may not be entirely the right direction, and we'll want to amend what it says, just because new URL turns out to be so slow. (Though there's probably some relatively easy improvements that could be made within its implementation to make it noticeably less so, like maybe 2x.) I guess I'll go write some thoughts on that over on that thread.

Merged, with one bugfix: Https://example/ is an absolute URL, just like https://example/.
I discovered that one while adding more tests, as part of an experimental followup branch working through some of our existing tangly URL-handling functions in pursuit of a different angle on #4146.

Thanks for the review and the new measurements!

I wonder about commenting on the new functions with something like, "why might we use these instead of new URL? Because new URL is expensive... (etc.)". That way a well-meaning contributor might be less likely to try to sweep them away for #4146.

I think it's fine because AFAICT there isn't a direct way to answer these questions using URL. Like if I try to write a sentence for the jsdoc like "This is equivalent to [something involving new URL], but more efficient.", I don't see how to fill in the blank.
At the one call site, in avatar.js, there is a comment explaining that, so anyone trying to remove these should pretty quickly find that.

Ah OK, right—thanks for pointing those things out, and thanks again for the PR. 🙂

I'm also coming to think that #4146 may not be entirely the right direction, and we'll want to amend what it says, just because new URL turns out to be so slow. (Though there's probably some relatively easy improvements that could be made within its implementation to make it noticeably less so, like maybe 2x.) I guess I'll go write some thoughts on that over on that thread.

Mmm, yeah—thanks.

authors: chrisbobbe gnprice


text:
Replace Casper developer documentation with Puppeteer documentation

CC @priyank-p, @chdinesh1089

I think this is probably one of the most important things we need to do for the Puppeteer stuff.

Can one of you just write notes here summarizing what it's important to know about how to debug Puppeteer tests?  I can then help turn that into proper documentation.

Mostly, debugging involves looking at the error message, the failure screenshot and reading the relevant test. Doing what the test does manually is also helpful and reading the test doesn't require one to fully know the puppeteer API either it just bunch of .click, .type and such but linking the puppeteer docs is still helpful.  The depending on the failure you might need to add waitForSelector and such.
For context, I never needed to look at the actual browser to debug flakes until now. It's mostly been doing it manually and figuring it out.
(I don't know if this was helpful or not for converting it into docs!)

I think it is also important that we mention await common.screenshot(page, name<this arg is optional>). It can be very helpful to add that line in a few places while debugging to know what's happening. But it might become obsolete when Priyank's PR(#16036) gets merged but might still be useful as sometimes we cannot see few things in the recording because of puppeteer being fast.

Another thing that often comes handy is page.on('console', msg => console.log("LOG:", msg.text()); to print the logs in browser console.

Addressed as a first pass in 0b2854f0107a27ba5a85a3b37b4a53c699f1cdc0; leaving this open until we do a bit more work on that.  That commit has several TODOs in the debugging section that I'd love you folks to tackel in a follow-up PR, but should provide a framework for adding your insights.
For that console.log thing -- should we just add that to what runs by default in the testing infrastructure?

@chdinesh1089 @priyank-p @Riken-Shah to what extent do we consider this resolved?  It may be worth starting a chat.zulip.org thread on potential further work, and then opening more specific issues and closing this.

I think so only some TODOs are left to document,

And adding some tips on how to debug.

@chdinesh1089 @priyank-p @Riken-Shah to what extent do we consider this resolved? It may be worth starting a chat.zulip.org thread on potential further work, and then opening more specific issues and closing this.

Started a thread at https://chat.zulip.org/#narrow/stream/43-automated-testing/topic/Puppeteer.20documentation/near/1201338 answering the TODOs in that list and mentioning what else needs to be done.

@Riken-Shah @chdinesh1089 is there a reason we haven't finished this last bit of documentation?  We should get it on someone's TODO list :)

Closing as I don't think that last bit is very important and this issue is basically clutter at this point with most of it finished.

source: gharchive/issue

authors: Gittenburg Riken-Shah chdinesh1089 priyank-p timabbott

repo: zulip/zulip

license_type: permissive

license_source: github-api


text:
design suggestion: no URL if image preview

from Zulip chat
Would it be possible to hide the URL link if it's pointing to a .gif, .webp or other image files? Our users are very font of sending gifs and it would look more natural and less cluttered if the blue URL wasn't showing in those cases.
here is a

We should only do this in the event that the entire message is the link, but I think it's a great cleanup.

@zulipbot claim

The basic version was just completed; I opened https://github.com/zulip/zulip/issues/7537 as a follow-up to this.  Thanks for the suggestion @vbNETonIce!

authors: aero31aero timabbott vbNETonIce


text:
docs: Add note about creating a non-root user.

https://github.com/zulip/zulip/issues/10694
Testing Plan:
Made the changes on a development server and ran ./tools/build-docs. Screenshot of change below.
GIFs or Screenshots:

@scottilee thanks for fixing this!  Like your other docs PR, I think the main documentation for this belongs in remote.md, but we should have a link.  I went ahead and moved + tweaked your changes and merged this as 32f1a13c7b86579050bf29e7f97255349536a2c5.
(Note that I also tweaked the commit message to ensure merging this commit auto-closes the original issue.
Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages)
Again, thanks for fixing this!

source: gharchive/pull-request

authors: scottilee timabbott


text:
file_io: Migrate open statements to use with.

Fixes: #12419
Testing Plan:
tools/test-*
git grep ".* = open(.*"
Remaining files:
tools/update-prod-static:fp = open('var/log/update-prod-static.log', 'w')
zerver/lib/parallel.py:            sys.stdin = open("/dev/null", "r")
zerver/management/commands/enqueue_file.py:            f = open(file_name)

@timabbott fyi :)

Merged as e331a758c3142e39d8877b7c96eee7c12f174f05, after fixing the above.  Thanks @whoodes!

open(…).close() was actually fine, and with open(…) as f: f.close() asks for two closes, although Python deduplicates them. A more direct translation would have been with open(…): pass.
Many open( calls escaped this migration:
$ git grep 'open(' | grep -v '\(def \|with \|\.\|\w\)open('
corporate/tests/test_stripe.py:        fixture = ujson.load(open(fixture_path, 'r'))
scripts/lib/hash_reqs.py:    for line in open(fpath):
scripts/lib/setup_path_on_import.py:    exec(open(activate_this).read(), activate_locals)
scripts/lib/upgrade-zulip-from-git:                              stdout=open('/dev/null', 'w'))
scripts/lib/upgrade-zulip-from-git:                          stdout=open('/dev/null', 'w'),
scripts/zulip-puppet-apply:        open("/etc/puppet/hiera.yaml", "a").close()
tools/create-test-api-docs:        for line in open(fn):
tools/lib/find_add_class.py:        lines = list(open(full_fn))
tools/lib/graph.py:    open('zulip-deps.dot', 'w').write(s)
tools/lib/provision.py:        sha_sum.update(open('scripts/lib/setup-apt-repo', 'rb').read())
tools/lib/provision.py:        sha_sum.update(open('scripts/lib/setup-yum-repo', 'rb').read())
tools/lib/provision.py:            sha_sum.update(open(bp, 'rb').read())
tools/lib/provision.py:    exec(open(activate_this).read(), dict(__file__=activate_this))
tools/lib/provision_inner.py:    open(version_file, 'w').write(PROVISION_VERSION + '\n')
tools/lib/test_server.py:            log = open(log_file, 'a')
tools/lib/test_server.py:            log = open(log_file, 'w')
tools/test-backend:                    for line in open(filepath):
tools/update-prod-static:fp = open('var/log/update-prod-static.log', 'w')
tools/zulint/custom_rules.py:        for i, line in enumerate(open(fn)):
zerver/lib/bugdown/__init__.py:    tlds = [tld.lower().strip() for tld in open(tlds_file, 'r')
zerver/lib/dev_ldap_directory.py:    profile_images = [open(path, "rb").read() for path in
zerver/lib/parallel.py:            sys.stdin = open("/dev/null", "r")
zerver/lib/test_classes.py:        return open(fn).read()
zerver/lib/test_classes.py:        return open(fn).read()
zerver/lib/test_helpers.py:    return open(os.path.join(test_avatar_dir, filename), 'rb')
zerver/management/commands/enqueue_file.py:            f = open(file_name)
zerver/management/commands/send_webhook_fixture_message.py:        return ujson.dumps(ujson.loads(open(fixture_path).read()))
zerver/migrations/0097_reactions_emoji_code.py:    unified_reactions = ujson.load(open(path_to_unified_reactions))
zerver/tests/test_auth_backends.py:                'thumbnailPhoto': [open(static_path("images/team/tim.png"), "rb").read()],
zerver/tests/test_auth_backends.py:                'thumbnailPhoto': [open(static_path("images/team/tim.png"), "rb").read()]
zerver/tests/test_auth_backends.py:                'thumbnailPhoto': [open(static_path("images/logo/zulip-icon-512x512.png"), "rb").read()]
zerver/tests/test_auth_backends.py:            'thumbnailPhoto': [open(static_path("images/team/tim.png"), "rb").read()],
zerver/tests/test_decorators.py:        for line in open(user_agents_path).readlines():
zerver/tests/test_narrow.py:        scenarios = ujson.loads(open(fixtures_path, 'r').read())
zerver/tests/test_signup.py:        self.assertEqual(open(zulip_path_id, "rb").read(), open(hamlet_path_id, "rb").read())
zerver/tests/test_transfer.py:        self.assertEqual(image_key.get_contents_as_string(), open(avatar_disk_path(user), "rb").read())
zerver/tests/test_transfer.py:        self.assertEqual(original_image_key.get_contents_as_string(), open(avatar_disk_path(user, original=True), "rb").read())
zerver/tests/test_transfer.py:        self.assertEqual(medium_image_key.get_contents_as_string(), open(avatar_disk_path(user, medium=True), "rb").read())
zerver/tests/test_upload.py:        self.assertEqual(open(source_path_id, "rb").read(), open(target_path_id, "rb").read())
zerver/tests/test_upload.py:        self.assertEqual(open(source_original_path_id, "rb").read(), open(target_original_path_id, "rb").read())
zerver/tests/test_upload.py:        self.assertEqual(open(source_medium_path_id, "rb").read(), open(target_medium_path_id, "rb").read())
zerver/tests/test_upload.py:        self.assertEqual(image_file.read(), open(file_path + ".original", "rb").read())
zilencer/management/commands/add_mock_conversation.py:        upload_avatar_image(open(filename, 'rb'), user, user)

It seems like it'd be good to clear those out as well.  Overall not a priority.

Thanks Anders; added as a low priority.

authors: andersk timabbott whoodes


text:
dev-docs-setup: Add installation instructions for WSL 2.

Instructions were added by doing the setup on Ubuntu 18.04 WSL 2. While
the setup should be similar for other distributions supported by our
./tools/provision script, it has not been tested.
czo discussion - https://chat.zulip.org/#narrow/stream/49-development-help/topic/Running.20Zulip.20on.20Windows.20(WSL)

Merged as ca0154c42547dfb4319c1534295b74635cc6cf82 after a bit of polishing (E.g. using a numbered list for the steps).  Huge thanks for doing this @amanagr!

authors: amanagr timabbott


text:
dependencies: Upgrade Node.js and JavaScript dependencies

css-loader@^4 is also available, but we can’t use it yet because of https://github.com/webpack-contrib/css-loader/issues/1164.
Testing Plan: Dev server.

lgtm assuming CI passes.

authors: andersk timabbott


text:
apidocs: Move stray descriptions to OpenAPI.

Testing plan:
GIFs or screenshots:

@timabbott This should be ready for review after the prep PR is merged. This step crosses the last hurdle in creating a common template, and I think we have reached maximum coverage once this gets merged :)

@timabbott Addressed most of the comments above. I think the PR would be easier to review after the prep one gets merged(since the things can't be verified directly on this PR as of now).

I just merged the prep commit, so you can rebase this now.  It'd be great if you can post the HTML diff output after completing this one.
(As a sidenote, did you end up writing a tool for that sort of HTML diff work?  I wonder if it'd be worth checking it and documenting it).

@timabbott Done with the rebase. Attaching the diff of the files:
old-archive-stream new-archive-stream
246d245
<
Note: The following parameters are all URL query parameters.

old-get-events new-get-events
320,324d319
<
Note: The parameters documented above are optional in the sense that
< even if you haven't registered a queue by explicitly requesting the
< http://localhost:9991/api/v1/register endpoint, you could pass the parameters for
< the http://localhost:9991/api/v1/register endpoint to this
< endpoint and a queue would be registered in the absence of a queue_id.

4534,4535c4529,4534
<
If the target event queue has been garbage collected, you'll get the
< following error response:

---
>
This error occurs if the target event queue has been garbage collected.
> A compliant client will handle this error by re-initializing itself
> (e.g. a Zulip web app browser window will reload in this case).

>
See the /register endpoint docs for details on how to
> handle these correctly.

>
The following is the error response in such case:

4543,4546d4541
<
A compliant client will handle this error by re-initializing itself
< (e.g. a Zulip web app browser window will reload in this case).

<
See the /register endpoint docs for details on how to
< handle these correctly.

old-get-messages new-get-messages
402,404d401
<
When a request is successful, this endpoint returns a dictionary
< containing the following (in addition to the msg and result keys
< present in all Zulip API responses).

601c598,601

When a request is successful, this endpoint returns a dictionary
> containing the following (in addition to the msg and result keys
> present in all Zulip API responses).
> A typical successful JSON response may look like:

old-get-stream-id new-get-stream-id
263d262
<
Note: The following parameters are all URL query parameters.

old-get-streams new-get-streams
270d269
<
Note: The following parameters are all URL query parameters.

old-get-user new-get-user
257d256
<
Note: The following parameters are all URL query parameters.

old-get-user-by-email new-get-user-by-email
264d263
<
Note: The following parameters are all URL query parameters.

old-get-users new-get-users
276d275
<
Note: The following parameters are all URL query parameters.

old-update-message new-update-message
218a219,220
>
Note: See configuring message editing for detailed documentation on under what
> circumstances users are allowed to edit topics.

278,285d279
<
Permissions

<
You only have permission to edit a message if:

<

<
You sent it, OR:

<
This is a topic-only edit for a (no topic) message, OR:

<
This is a topic-only edit and you are an admin, OR:

<
This is a topic-only edit and your realm allows users to edit topics.

<

old-upload-custom-emoji new-upload-custom-emoji
246c246
<

curl -sSX POST http://localhost:9991/api/v1/realm/emoji/demo \
---
>

curl -sSX POST http://localhost:9991/api/v1/realm/emoji/smile \
254,257c254,260
<
As described above, the image file to upload must be provided in the
< request's body.

<
Emoji name

<
The emoji name can only contain letters, numbers, dashes, and spaces.
---
>

>
emoji_name string required in path

>

>         Example: "smile"
>

>

The name that should be associated with the uploaded emoji image/gif.
> The emoji name can only contain letters, numbers, dashes, and spaces.
260c263,268
< handles emoji).

---
> handles emoji).

>

>

>
>
As described above, the image file to upload must be provided in the
> request's body.

Also, I'm using combination of a python script and a bash script to store raw HTMLs in files old-<endpoint-name> and new-<endpoint-name>, and showing diff of the respective older and newer files if they not exactly same(using cmp bash command).

For upload-custom-emoji, I think smile is a terrible example, since that's a built-in emoji name, and custom emoji are primarily for adding new custom emoji. We can merge this, but we should change that example to something that's a reasonable custom emoji name; I think demo (as was previously presentis OK, butmy_new_emoji` might be better.

The emoji name can only contain letters, numbers, dashes, and spaces.

Is this accurate?  I would have thought that we used underscores, not -s, for this purpose.

Merged after a small whitespace change for the "delete message" one to add a blank line after the heading.  Thanks @MSurfer20!
Can you take care of the small follow-up issues mentioned in my last batch of comments?
It's exciting how close we are to being able to delete the templates.


text:
developer docs: Update GSoC documentation.

Testing plan:
manual
GIFs or screenshots:

Note that I italicized the quotes by hand -- I dunno if a CSS change would be better instead.

Merged, thanks @alya!

authors: alya timabbott


text:
install: Support Debian 12

https://chat.zulip.org/#narrow/stream/3-backend/topic/Debian.20bookworm

Merged, thanks @andersk!


text:
Show images on Accept: preferring images, redirect to login for unauth access denied

This needs tests, and also needs final assets; right now, it's just using the whale and turtle pngs we already bundle.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

The strategy lgtm.

Merged, thanks @alexmv! Glad to have this completed.

authors: alexmv timabbott


text:
message_edit: Lay out edit buttons with flexbox

This PR does three things:

It moves various message_edit selectors and styles from zulip.css into message_row.css
It removes some dead CSS related to message-edit structures that no appear to exist in the codebase.
It strengthens the layout of the message edit buttons with flexbox, especially the load spinner on the Save button. The kinds of fiddly tweaks in #28134 should no longer be necessary, as flexbox is responsible for all alignment matters, instead of positioning and brittle pixel-offset tweaks.

Screenshots and screen captures:
As this is a code-quality PR, there should be no visual changes.

Before
After

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

lgtm, merged, thanks @karlstolley!

authors: karlstolley timabbott


text:
docs: Conform docs to user documentation styling guidelines.

Fixes: #3015, #3018
Conforms Change the date and time format and Move the users list to the left sidebar docs to user documentation styling guidelines as requested in the issues.

Automated message from Dropbox CLA bot
@synicalsyntax, it looks like you've already signed the Dropbox CLA. Thanks!

authors: smarx synicalsyntax


text:
bootstrap: Remove unused bootstrap button classes.

This PR removes the button-secondary, button-group and bootstrap-btn-group classes which don't have any corresponding styles attached to them or are no longer in use in the codebase.
Fixes: https://github.com/zulip/zulip/pull/32357#discussion_r1842734544, https://github.com/zulip/zulip/pull/32357#discussion_r1842736088, https://github.com/zulip/zulip/pull/32357#discussion_r1842736921

Screenshots and screen captures: N/A

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @sayamsamal!

authors: sayamsamal timabbott


text:
drafts: Add timestamps showing when last modified.

I think I need to discuss what we should show as a timestamp, currently, it is showing day when it is last modified.
Also noticed when we update an old draft it doesn't move to bottom(don't know if it's intentional, and if not then this might be itself a new issue).
Fixes: #3790.

Also noticed when we update an old draft it doesn't move to bottom
This is probably because we get the drafts as they are stored in Local Storage (which is in order of creation). You'll probably need to sort the drafts by updatedAt in the format_drafts function before displaying.

Oh, thanks, @sampritipanda for clearing that, I will discuss the sorting along with the look of the timestamp.

You should modify the Casper tests to check for this as well.

I've updated the PR with some little changes and sort drafts accordingly to last time modified.

Thanks @shubhamdhama! Small comments:

I think we'll want the time for recent things, so 3:45 if it was today, but Yesterday if it was yesterday, and Dec 23 if it was before yesterday. Only if this is easy / we already have the function for it in timerender.js
The last modified can be in the title text on hover; I don't think we need it written for every message

I've updated the PR and here is new GIF(link only as it's heavy in size)
(https://user-images.githubusercontent.com/22238472/34405647-72928e94-ebda-11e7-96cb-9d874ac0ea78.gif)

Looks great, merged, thanks @shubhamdhama!

authors: rishig sampritipanda shubhamdhama timabbott


text:
[3pt] Add game and author constructor

All Game class properties visible in the diagram should be defined and set up in the
constructor method.
All Author class properties visible in the diagram should be defined and set up in the
constructor method.

Closing the issues as this task has been completed in the Pull Request No. 28

license: MIT


text:
Introduce $include-html-dropdown-classes setting

The dropdown HTML styles are currently included based on the $include-html-button-classes variable.
Surely a variable, $include-html-dropdown-classes, would make more sense for those wishing to use the dropdown classes but define their own buttons?

I was reviewing previous issues before opening my own one about this problem and I fond this one, so let me join to this request.
By what I saw, Foundation 6 won't separate buttons from dropdown buttons and this flag variable stuff will change, so I would like to know if (after 2 years from @cmwinters comment) a PR would be accepted to solve this in Foundation 5.
Thanks and sorry for getting this old closed issue back :wink:.

repo: zurb/foundation-sites

license: mit

license_source: bigquery


text:
Abide validates disabled form elements (checkbox, radio)

Don't validate disabled checkbox and radio inputs.

this is a good hamburger

authors: MrEfrem carloskf


text:
flex-video doesn't seem to work on Microsoft Edge

I wanted a responsive Google Embed Maps for my website. And I read on SO that I can achieve that if I put the <iframe> inside a div with a class of flex-video. And it works flawlessly in Chrome and Firefox. But when I tried the website on Edge, the Maps doesn't appear. There are no errors but just that nothing is visible. If I remove the flex-video div around the iframe, map is visible on both the browsers but when I include it, map isn't visible.

Hmm… Which version of IE?
It could be a DOCTYPE issue. An iframe in IE9 inherits the DOCTYPE of its parent when it's in quirks mode. Try adding this to the head of your markup.
<meta http-equiv="X-UA-Compatible" content="IE=8" />

Can you reproduce this in a codepin?

It contains the exact markup and styles as my website: http://jsfiddle.net/eu2ojocL/3/
And I have corrected the issue as I can see the maps working on IE. But still not on Edge. The JSFiddle here shows weird height and I don't know why. I tried specifying height to both row, column and container but the problem is there. And the <iframe> also has a specified height, but the div is stuck in some weird height I think.

It looks like this might be related to display: flex; that is added to the .about-section. If you remove that it seems to work OK for me in Edge. Not sure on what would cause this though, I'm pretty new to flexbox.

@brettsmason Yeah, that does solve the problem. Thank you. But still I would like to know the reason behind this.

I just ran into the same issue. The intrinsic padding trick doesn't work consistently within a flexbox parent.
The solution is to move the height and padding-bottom to a pseudo element.
Here is a working demo: http://jsfiddle.net/eu2ojocL/10/
This new method seems to work with and without the flexbox parent but some more browser testing is required. You can read more details on stackoverflow.

That's a good idea, @slavanga. I recently used the zero-heigh/padding-bottom trick on a pseudo element for a responsive background image 'cause I needed the actual element to act as a container. Worked really well. Didn't consider it for this case. I think this bug warrants changing the Flex Video method to use a pseudo element. Maybe I should consider this in the PR I'm working on for refactoring Flex Video (#8199).

Is this still an issue?  Did we determine it is a user css issue, or something that should get handled by foundation?

From looking back over this the issue is adding display: flex; to a parent container causes flex-video not to display correctly. I'm not familiar with flexbox but @andycochran was what you mentioned above still valid? I know you were looking at flex video.

I think this was probably an edge case. Closing. We can reopen if someone runs into Edge + Responsive Embed issues again.

authors: akshaybharwani andycochran brettsmason kball slavanga


text:
Setup Job to send notifications at specified times

As a user, I should be able to get notifications periodically, so I and my teammates can know the status of reminders via mail or notifications.
Acceptance

[ ] I have a scheduler running that gets all reminders and sends them at the time specified.
[ ] I have a queue to handle the messages that are being sent by the scheduler

Steps

Install agenda from here https://www.npmjs.com/package/agenda
Create a job, that runs every minute. Inside the job,
Retrieve all reminders by calling the respective database function,
Write a logic that checks if the date is an hour to expiration, then send the reminder object to a queue
The queue picks it up and sends the respective mails to the individuals.

live link
https://reminders.zuri.chat/api/v1/oneHourToGo

authors: iyosayi tamsay


text:
feat(config): Add Parameter 17 to Zen71 Switch (firmware dependent)

Adds Parameter 17 to configs for FW version 10.0+.
Toggles local control of Inclusion, Exclusion, and LED settings.

I can't read what the Semantic issue is, not sure what I need to change here. The title is ok, as far as I can tell.

@zwave-js-bot rename commit

repo: zwave-js/node-zwave-js


text:
[question] Node ID skipping numbers

Call it an OCD thing, but why is it when something gets messed up like the security requirement getting skipped, do node IDs that are removed/excluded get skipped on the next inclusion? If I remove my kitchen switch and re-add it due to an error, why can’t it have the same ID?

This is something zwave-protocol specific, in order to re-use same ids you should use replace failed node instead of exclusion. Once a node is excluded that id cannot be taken again. The only way is to factory reset the stick and add back each one one by one

authors: hessercan robertsLando


text:
chore: bump cdk to 2.0.0-rc.7 and projen to 0.23.1

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #79 (c60effe) into main (2974dfe) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   83.33%   83.33%
=======================================
  Files           2        2
  Lines         126      126
  Branches       31       30    -1
=======================================
  Hits          105      105
  Misses         21       21

Impacted Files
Coverage Δ

example/src/main.ts
88.46% <100.00%> (ø)

src/index.ts
82.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e6f4d9...c60effe. Read the comment docs.

authors: codecov-commenter zxkane

repo: zxkane/snat


text:
Set Premake build folder

프리메이크로 생성하는 파일들 ( sln, vs files.. )을 build폴더에서 관리하도록 수정

(#2)
#결과물

이렇게 되면 vcxproj, vcxproj.filter 등은 Engine안에 생기는 건가요?

@zxwnstn 넵 그렇습니다.

repo: zxwnstn/AnrealEngine


text:
Lyrics not working

This is my initialization:
const lyrics = new Genius.Client(process.env.GENIUSTOKEN);

this is my command:
lyrics.songs.search("Omfori Skidder Skidder Skidder").then(async x => {
          return x?.length ? await x[0].lyrics() : null;
});

This is the output:
Error: No result was found

It is because this happens when u fetch the uri:
https://milrato.com/codeshare/code/63a41dd1b7ad972a43f9380a
But when I open it in the BROWSER of the SERVER where I'M making the request of, it does not show cloudflare:

Please make it possible to change browser origin headers.
So I can use the ones from my BROWSER (Firefox, linux, etc.) (defaultUserAgent )
because I'd need: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:108.0) Gecko/20100101 Firefox/108.0

maybe cookies could help?

cause lyrics you scrape

just changing the defaultUserAgent, did not fix it
maybe cookies could?

just changing the defaultUserAgent, did not fix it maybe cookies could?

Maybe. Cloudflare checks are not easy to bypass afaik.

It's not really a cloudflare check, it's more a google captcha

It's not really a cloudflare check, it's more a google captcha

No, it's actually Cloudflare Captcha.

Okay

If you could show me where to insert what, to test cookies, I can test it

Sample code for setting headers:
new Genius.Client("your_token", {
        requestOptions: {
            headers: {
                "user-agent": "your_custom_user_agent",
                cookie: "cookies",
            }
        }
    })

using cookies, doesnt fix it either
hmmm
since I'm on ovh, I can't get lyrics anymore... sadge

Imma build some sort of a proxy cache wrapper then..

Thanks tho.

Closing this since this can't be fixed.

repo: zyrouge/node-genius-lyrics


text:
Windows - Does not report that programs disabled in Task Manager > Startup are disabled

After enabling startup using auto-launch, the program will appear inside the Task Manager "Startup" tab. If it is then disabled, auto-launch still reports the program as being enabled.
Setting this values changes the registry entry inside HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\StartupApproved\Run for the app. When enabled, the hex value is 0x020000000000000000000000 (source, also verified myself on Windows 10). When disabled, it appears to be something else, it's not consistent between apps.
It would be nice if AutoLaunch::is_enabled() factored this registry value into its result to reflect changes made in Task Manager. I intend to implement this and raise a PR for it soon.

Note that the hex value when enabled isn't always 0x02..., I saw 0x00 and others have reported 0x06 and 0x08. A better test seems to be whether the last 8 bytes are zeros. More details in the PR.

I have fixed some issues and updated to version 0.5.0, you can give it a try

Updated to use 0.5.0, everything seems good, thanks!

authors: OmegaJak zzzgydi

repo: zzzgydi/auto-launch


text:
Multiple includes are very slow

I am trying to do some unit tests with Effort where I have the following:
    investment = db.Investment
        .Include(e => e.Positions.Select(p => p.Transactions))
        //.Include(e => e.Positions.Select(p => p.InvestmentCarry))
        .Include(e => e.RelatedInvestments)
        .Include(e => e.PrivateInvestment)
        .Include(e => e.CoInvestment)
        .FirstOrDefault(e => e.Id == id)
        ;

The time it takes to execute this is about 4-5 minutes.
I've loaded the source code and debugged it. According to the stack trace pasted below, it is spending it's time at "NMemory.dll!NMemory.Execution.ExecutionPlan<System.Collections.Generic.IEnumerable>.Execute(NMemory.Execution.IExecutionContext context) Line 48", and ultimately to an external assembly method of "mscorlib.dll!System.Reflection.Emit.DynamicMethod.CreateDelegate(System.Type delegateType, object target)".
Any ideas?
Paste of stack trace:
[Managed to Native Transition]
mscorlib.dll!System.Reflection.Emit.DynamicMethod.CreateDelegate(System.Type delegateType, object target)   Unknown
[Lightweight Function]

NMemory.dll!NMemory.Execution.ExecutionPlan<System.Collections.Generic.IEnumerable>.Execute(NMemory.Execution.IExecutionContext context) Line 48 C#
NMemory.dll!NMemory.Execution.CommandExecutor.ExecuteQuery(NMemory.Execution.IExecutionPlan<System.Collections.Generic.IEnumerable> plan, NMemory.Execution.IExecutionContext context, NMemory.Tables.ITable[] tablesToLock, bool cloneEntities) Line 83  C#
NMemory.dll!NMemory.Execution.CommandExecutor.ExecuteQuery(NMemory.Execution.IExecutionPlan<System.Collections.Generic.IEnumerable> plan, NMemory.Execution.IExecutionContext context) Line 57    C#
NMemory.dll!NMemory.Linq.TableQuery.GetEnumerator(System.Collections.Generic.IDictionary<string, object> parameters, NMemory.Transactions.Transaction transaction) Line 116  C#
NMemory.dll!NMemory.Linq.TableQueryWrapper.GetEnumerator() Line 49   C#
NMemory.dll!NMemory.Linq.TableQueryWrapper.System.Collections.IEnumerable.GetEnumerator() Line 54    C#
Effort.dll!Effort.Provider.EffortDataReader.EffortDataReader(System.Collections.IEnumerable result, int recordsAffected, Effort.Internal.Common.FieldDescription[] fields, Effort.Internal.DbManagement.DbContainer container) Line 56  C#
Effort.dll!Effort.Internal.CommandActions.QueryCommandAction.ExecuteDataReader(Effort.Internal.CommandActions.ActionContext context) Line 96    C#
Effort.dll!Effort.Provider.EffortEntityCommand.ExecuteDbDataReader(System.Data.CommandBehavior behavior) Line 133   C#
System.Data.dll!System.Data.Common.DbCommand.ExecuteReader(System.Data.CommandBehavior behavior)    Unknown
EntityFramework.dll!System.Data.Entity.Infrastructure.Interception.DbCommandDispatcher.Reader.AnonymousMethod__c(System.Data.Common.DbCommand t, System.Data.Entity.Infrastructure.Interception.DbCommandInterceptionContext<System.Data.Common.DbDataReader> c)    Unknown
EntityFramework.dll!System.Data.Entity.Infrastructure.Interception.InternalDispatcher<System.Data.Entity.Infrastructure.Interception.IDbCommandInterceptor>.Dispatch<System.Data.Common.DbCommand, System.Data.Entity.Infrastructure.Interception.DbCommandInterceptionContext<System.Data.Common.DbDataReader>, System.Data.Common.DbDataReader>(System.Data.Common.DbCommand target, System.Func<System.Data.Common.DbCommand, System.Data.Entity.Infrastructure.Interception.DbCommandInterceptionContext<System.Data.Common.DbDataReader>, System.Data.Common.DbDataReader> operation, System.Data.Entity.Infrastructure.Interception.DbCommandInterceptionContext<System.Data.Common.DbDataReader> interceptionContext, System.Action<System.Data.Entity.Infrastructure.Interception.IDbCommandInterceptor, System.Data.Common.DbCommand, System.Data.Entity.Infrastructure.Interception.DbCommandInterceptionContext<System.Data.Common.DbDataReader>> executing, System.Action<System.Data.Entity.Infrastructure.Interception.IDbCommandInterceptor, System.Data.Common.DbCommand, System.Data.Entity.Infrastructure.Interception.DbCommandInterceptionContext<System.Data.Common.DbDataReader>> executed)   Unknown
EntityFramework.dll!System.Data.Entity.Infrastructure.Interception.DbCommandDispatcher.Reader(System.Data.Common.DbCommand command, System.Data.Entity.Infrastructure.Interception.DbCommandInterceptionContext interceptionContext)    Unknown
EntityFramework.dll!System.Data.Entity.Internal.InterceptableDbCommand.ExecuteDbDataReader(System.Data.CommandBehavior behavior)    Unknown
System.Data.dll!System.Data.Common.DbCommand.ExecuteReader(System.Data.CommandBehavior behavior)    Unknown
EntityFramework.dll!System.Data.Entity.Core.EntityClient.Internal.EntityCommandDefinition.ExecuteStoreCommands(System.Data.Entity.Core.EntityClient.EntityCommand entityCommand, System.Data.CommandBehavior behavior)  Unknown
EntityFramework.dll!System.Data.Entity.Core.Objects.Internal.ObjectQueryExecutionPlan.Execute<CDH.CFF.Data.DAL.Models.Investment>(System.Data.Entity.Core.Objects.ObjectContext context, System.Data.Entity.Core.Objects.ObjectParameterCollection parameterValues) Unknown
EntityFramework.dll!System.Data.Entity.Core.Objects.ObjectQuery<CDH.CFF.Data.DAL.Models.Investment>.GetResults.AnonymousMethod__6() Unknown
EntityFramework.dll!System.Data.Entity.Core.Objects.ObjectContext.ExecuteInTransaction<System.__Canon>(System.Func<System.__Canon> func, System.Data.Entity.Infrastructure.IDbExecutionStrategy executionStrategy, bool startLocalTransaction, bool releaseConnectionOnSuccess) Unknown
EntityFramework.dll!System.Data.Entity.Core.Objects.ObjectQuery<CDH.CFF.Data.DAL.Models.Investment>.GetResults.AnonymousMethod__5() Unknown
EntityFramework.dll!System.Data.Entity.Infrastructure.DefaultExecutionStrategy.Execute<System.__Canon>(System.Func<System.__Canon> operation)   Unknown
EntityFramework.dll!System.Data.Entity.Core.Objects.ObjectQuery<CDH.CFF.Data.DAL.Models.Investment>.GetResults(System.Data.Entity.Core.Objects.MergeOption? forMergeOption) Unknown
EntityFramework.dll!System.Data.Entity.Core.Objects.ObjectQuery<System.__Canon>.System.Collections.Generic.IEnumerable.GetEnumerator.AnonymousMethod__0()    Unknown
EntityFramework.dll!System.Data.Entity.Internal.LazyEnumerator<CDH.CFF.Data.DAL.Models.Investment>.MoveNext()   Unknown
System.Core.dll!System.Linq.Enumerable.FirstOrDefault<CDH.CFF.Data.DAL.Models.Investment>(System.Collections.Generic.IEnumerable<CDH.CFF.Data.DAL.Models.Investment> source)    Unknown
EntityFramework.dll!System.Data.Entity.Core.Objects.ELinq.ObjectQueryProvider.GetElementFunction.AnonymousMethod__1<CDH.CFF.Data.DAL.Models.Investment>(System.Collections.Generic.IEnumerable<CDH.CFF.Data.DAL.Models.Investment> sequence)    Unknown
EntityFramework.dll!System.Data.Entity.Core.Objects.ELinq.ObjectQueryProvider.ExecuteSingle<CDH.CFF.Data.DAL.Models.Investment>(System.Collections.Generic.IEnumerable<CDH.CFF.Data.DAL.Models.Investment> query, System.Linq.Expressions.Expression queryRoot) Unknown
EntityFramework.dll!System.Data.Entity.Core.Objects.ELinq.ObjectQueryProvider.Execute<CDH.CFF.Data.DAL.Models.Investment>(System.Linq.Expressions.Expression expression)    Unknown
EntityFramework.dll!System.Data.Entity.Internal.Linq.DbQueryProvider.Execute<CDH.CFF.Data.DAL.Models.Investment>(System.Linq.Expressions.Expression expression) Unknown
System.Core.dll!System.Linq.Queryable.FirstOrDefault<CDH.CFF.Data.DAL.Models.Investment>(System.Linq.IQueryable<CDH.CFF.Data.DAL.Models.Investment> source, System.Linq.Expressions.Expression<System.Func<CDH.CFF.Data.DAL.Models.Investment, bool>> predicate)    Unknown
CDH.CFF.Services.dll!CDH.CFF.Services.Services.InvestmentService.Retrieve(int id) Line 59   C#
CDH.CFF.Services.Tests.dll!CDH.CFF.Services.Tests.InvestmentServiceTests.GetInvestmentTest() Line 256   C#
[Native to Managed Transition]
[Managed to Native Transition]
Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.dll!Microsoft.VisualStudio.TestPlatform.MSTestFramework.TestMethodRunner.DefaultTestMethodInvoke(object[] args)    Unknown
Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.dll!Microsoft.VisualStudio.TestPlatform.MSTestFramework.TestMethodRunner.RunTestMethod()   Unknown
Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.dll!Microsoft.VisualStudio.TestPlatform.MSTestFramework.TestMethodRunner.ExecuteTest() Unknown
Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.dll!Microsoft.VisualStudio.TestPlatform.MSTestFramework.TestMethodRunner.ExecuteInternal() Unknown
Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.dll!Microsoft.VisualStudio.TestPlatform.MSTestFramework.TestMethodRunner.Execute() Unknown
Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.dll!Microsoft.VisualStudio.TestPlatform.MSTestFramework.UnitTestRunner.RunInternal(Microsoft.VisualStudio.TestPlatform.MSTestFramework.TestMethod testMethod, bool isDataDriven, System.Collections.Generic.Dictionary<string, object> runParameters)  Unknown
Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.dll!Microsoft.VisualStudio.TestPlatform.MSTestFramework.UnitTestRunner.RunSingleTest(string name, string fullClassName, bool isAsync, System.Collections.Generic.Dictionary<string, object> runParameters) Unknown
[AppDomain (C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO 14.0\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\TESTWINDOW\Extensions\Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.dll, #2) -> AppDomain (UnitTestAdapter: Running test, #4)]
Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.dll!Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.MixedModeExecutor.ExecuteTests(System.Collections.Generic.IEnumerable<Microsoft.VisualStudio.TestPlatform.ObjectModel.TestCase> tests, Microsoft.VisualStudio.TestPlatform.ObjectModel.Adapter.IRunContext runContext, Microsoft.VisualStudio.TestPlatform.ObjectModel.Adapter.ITestExecutionRecorder testExecutionRecorder, Microsoft.VisualStudio.TestPlatform.MSTestFramework.UnitTestRunner testRunner, Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.TmiTestRun tmiTestRun)   Unknown
Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.dll!Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.MixedModeExecutor.ExecuteDurontoTestsInternal(System.Collections.Generic.IEnumerable<Microsoft.VisualStudio.TestPlatform.ObjectModel.TestCase> tests, Microsoft.VisualStudio.TestPlatform.ObjectModel.Adapter.IRunContext runContext, Microsoft.VisualStudio.TestPlatform.ObjectModel.Adapter.ITestExecutionRecorder testExecutionRecorder, string source, Microsoft.VisualStudio.TestPlatform.MSTestFramework.TestRunDirectories runDirectories, Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.TmiTestRun tmiTestRun) Unknown
Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.dll!Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.MixedModeExecutor.ExecuteDurontoTests(System.Collections.Generic.IEnumerable<Microsoft.VisualStudio.TestPlatform.ObjectModel.TestCase> tests, Microsoft.VisualStudio.TestPlatform.ObjectModel.Adapter.IRunContext runContext, Microsoft.VisualStudio.TestPlatform.ObjectModel.Adapter.IFrameworkHandle frameworkHandle, string source, Microsoft.VisualStudio.TestPlatform.MSTestFramework.TestRunDirectories runDirectories, Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.TmiTestRun tmiTestRun) Unknown
Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.dll!Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.MixedModeExecutor.ExecuteTests(System.Collections.Generic.IEnumerable<Microsoft.VisualStudio.TestPlatform.ObjectModel.TestCase> tests, Microsoft.VisualStudio.TestPlatform.ObjectModel.Adapter.IRunContext runContext, Microsoft.VisualStudio.TestPlatform.ObjectModel.Adapter.IFrameworkHandle frameworkHandle, Microsoft.VisualStudio.TestPlatform.MSTestFramework.TestRunDirectories runDirectories, bool isDeploymentDone, string source) Unknown
Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.dll!Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.MixedModeExecutor.ExecuteTests(System.Collections.Generic.IEnumerable<Microsoft.VisualStudio.TestPlatform.ObjectModel.TestCase> tests, Microsoft.VisualStudio.TestPlatform.ObjectModel.Adapter.IRunContext runContext, Microsoft.VisualStudio.TestPlatform.ObjectModel.Adapter.IFrameworkHandle frameworkHandle, Microsoft.VisualStudio.TestPlatform.MSTestFramework.TestRunDirectories runDirectories, bool isDeploymentDone)    Unknown
Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.dll!Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.MixedModeExecutor.RunTests(System.Collections.Generic.IEnumerable<Microsoft.VisualStudio.TestPlatform.ObjectModel.TestCase> tests, Microsoft.VisualStudio.TestPlatform.ObjectModel.Adapter.IRunContext runContext, Microsoft.VisualStudio.TestPlatform.ObjectModel.Adapter.IFrameworkHandle frameworkHandle, Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.TestRunCancellationToken cancellationToken) Unknown
Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.dll!Microsoft.VisualStudio.TestPlatform.Extensions.VSTestIntegration.MSTestExecutor.RunTests(System.Collections.Generic.IEnumerable<Microsoft.VisualStudio.TestPlatform.ObjectModel.TestCase> tests, Microsoft.VisualStudio.TestPlatform.ObjectModel.Adapter.IRunContext runContext, Microsoft.VisualStudio.TestPlatform.ObjectModel.Adapter.IFrameworkHandle frameworkHandle) Unknown
TE.RockSteadyHost.dll!WEX.TestExecution.ExecutionPlugin.ExecuteTests(System.IntPtr context, System.IntPtr logSessionPtr, System.Collections.Generic.IDictionary<string, string> rockSteadySettings) Unknown
TE.RockSteadyHost.dll!WEX.TestExecution.InteropMethods.ExecuteTests(string[] rockSteadySettings, int rockSteadySettingsSize, System.IntPtr context, System.IntPtr logSessionPtr)    Unknown
[AppDomain Transition]

Hi @markjjordan
Thank you for reporting this and sorry for the very late response. Your input is pretty useful, it seems that DynamicMethod is the source of this issue.
Doing a couple of optimisation here should solve the problem:
https://github.com/tamasflamich/nmemory/blob/53359bacd0facf0876eb398302d2c3e39f844a85/Main/Source/NMemory/Common/DynamicMethodBuilder.cs
See more info here:
http://stackoverflow.com/a/13432022/1024317

Hello @markjjordan ,
I will close this issue since @tamasflamich already made some optimizations.
If you believe more optimization is required, feel free to repost this issue here: https://github.com/zzzprojects/EntityFramework-Effort/
Best Regards,
Jonathan

authors: JonathanMagnan markjjordan tamasflamich

repo: zzzprojects/nmemory


text:
chore: remove redundant words in comment

Closing due to suspected bot activity.

authors: bobbinth loselarry


text:
Ajout de champs 2le/2le#3717

conflict, please correct

authors: sebheitzmann valentin-helies


text:
Lib3mf libs update from repo branch

Opened it for testing to check code coverage token between forked repo and branch. Behaved the same. So closing this PR.


text:
Create Aggressive_Cows.cpp

Hey Pal,
This repo is only for Searching and Sorting Algorithms.
Happy Coding !


text:
fixed

rip trying to fix on krnl


text:
Add orchard spending key encoding

Codecov Report

Merging #63 (75c17b3) into main (3e9bbb8) will increase coverage by 0.18%.
The diff coverage is 93.93%.

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   88.74%   88.93%   +0.18%
==========================================
  Files         112      112
  Lines        6186     6208      +22
==========================================
+ Hits         5490     5521      +31
+ Misses        696      687       -9

Flag
Coverage Δ

LinuxHost
88.93% <93.93%> (+0.18%)
:arrow_up:

Release
88.93% <93.93%> (+0.18%)
:arrow_up:

WindowsHost
?

macOSHost
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

src/Nerdbank.Zcash/Orchard/SpendingKey.cs
82.14% <81.81%> (+4.36%)
:arrow_up:

...t/Nerdbank.Zcash.Tests/Orchard/SpendingKeyTests.cs
100.00% <100.00%> (ø)

authors: AArnott codecov-commenter


text:
shard the parquet file when it crosses a threshold

done

repo: AI-Northstar-Tech/vector-io


text:
二维码过期了

不会有这种东西了，就在这里提 issue 吧

repo: AIFSH/ComfyUI-Hallo


text:
Update UserGuide.md

Codecov Report

Merging #153 (bdcb11d) into master (3059576) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #153   +/-   ##
=========================================
  Coverage     73.04%   73.04%
  Complexity      570      570
=========================================
  Files            89       89
  Lines          1762     1762
  Branches        187      187
=========================================
  Hits           1287     1287
  Misses          411      411
  Partials         64       64

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3059576...bdcb11d. Read the comment docs.

authors: codecov-commenter xpzmichael


text:
Testcase

Codecov Report

Merging #132 (6acf58f) into master (fa84445) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #132      +/-   ##
============================================
+ Coverage     75.04%   75.08%   +0.04%
- Complexity      846      858      +12
============================================
  Files           110      110
  Lines          2408     2444      +36
  Branches        309      310       +1
============================================
+ Hits           1807     1835      +28
- Misses          511      518       +7
- Partials         90       91       +1

Impacted Files
Coverage Δ

.../java/seedu/address/model/util/SampleDataUtil.java
40.57% <0.00%> (-5.08%)
:arrow_down:

...c/main/java/seedu/address/model/patron/Patron.java
97.77% <0.00%> (-2.23%)
:arrow_down:

...rc/main/java/seedu/address/model/ModelManager.java
98.91% <0.00%> (+0.02%)
:arrow_up:

src/main/java/seedu/address/model/LibTask.java
95.58% <0.00%> (+0.13%)
:arrow_up:

...a/seedu/address/model/patron/UniquePatronList.java
93.02% <0.00%> (+0.34%)
:arrow_up:

src/main/java/seedu/address/model/patron/Id.java
83.33% <0.00%> (+1.51%)
:arrow_up:

...rc/main/java/seedu/address/model/patron/Email.java
83.33% <0.00%> (+1.51%)
:arrow_up:

src/main/java/seedu/address/model/patron/Name.java
86.66% <0.00%> (+4.84%)
:arrow_up:

...u/address/logic/commands/book/FindBookCommand.java
100.00% <0.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d50871...6acf58f. Read the comment docs.

authors: Halpfrog codecov-commenter


text:
Improve find command keyword-matching

Codecov Report
Base: 66.19% // Head: 66.19% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (e52e60b) compared to base (1f54f31).
Patch coverage: 73.07% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #250      +/-   ##
============================================
- Coverage     66.19%   66.19%   -0.01%
- Complexity      629      648      +19
============================================
  Files           121      127       +6
  Lines          2204     2254      +50
  Branches        240      250      +10
============================================
+ Hits           1459     1492      +33
- Misses          673      684      +11
- Partials         72       78       +6

Impacted Files
Coverage Δ

...se/model/person/NameContainsKeywordsPredicate.java
100.00% <ø> (ø)

.../model/person/PersonContainsKeywordsPredicate.java
66.66% <66.66%> (ø)

...model/person/AddressContainsKeywordsPredicate.java
71.42% <71.42%> (ø)

...e/model/person/EmailContainsKeywordsPredicate.java
71.42% <71.42%> (ø)

...e/model/person/PhoneContainsKeywordsPredicate.java
71.42% <71.42%> (ø)

...inurse/model/tag/TagContainsKeywordsPredicate.java
71.42% <71.42%> (ø)

...model/person/PatientContainsKeywordsPredicate.java
85.71% <85.71%> (ø)

...ava/seedu/uninurse/logic/commands/FindCommand.java
90.00% <100.00%> (-10.00%)
:arrow_down:

...seedu/uninurse/logic/parser/FindCommandParser.java
100.00% <100.00%> (ø)

... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

authors: codecov-commenter rama-pang


text:
Page Break for saving and loading section in UG

beeg brek


text:
Update UG, DG, and index with new info

Codecov Report
Base: 72.10% // Head: 72.10% // No change to project coverage :thumbsup:

Coverage data is based on head (8ec1cbf) compared to base (6f05295).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #75   +/-   ##
=========================================
  Coverage     72.10%   72.10%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1233     1233
  Branches        125      125
=========================================
  Hits            889      889
  Misses          312      312
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


text:
update developer guide for v1.1

Codecov Report
Base: 72.15% // Head: 72.15% // No change to project coverage :thumbsup:

Coverage data is based on head (bf7cbad) compared to base (fd3a2da).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #27   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


text:
Standardize EditClientCommand error msgs

Codecov Report
Base: 63.26% // Head: 63.17% // Decreases project coverage by -0.08% :warning:

Coverage data is based on head (fa8f3c2) compared to base (a0017c0).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #318      +/-   ##
============================================
- Coverage     63.26%   63.17%   -0.09%
  Complexity      650      650
============================================
  Files           112      112
  Lines          2273     2273
  Branches        266      268       +2
============================================
- Hits           1438     1436       -2
- Misses          736      737       +1
- Partials         99      100       +1

Impacted Files
Coverage Δ

.../address/logic/parser/EditClientCommandParser.java
77.41% <75.00%> (-4.40%)
:arrow_down:

...eedu/address/logic/commands/EditClientCommand.java
86.86% <100.00%> (-0.77%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


text:
Cascade EditCommand for Leaves and Department

leaves settled. Will settle departments


text:
Add Lookup Command

LGTM


text:
Fix phone

Fixes #149


text:
Регистрация

Добавить интерцепторы для axios.  Использовать токен в headers.  Добавить snackbar для показа успешного действия или ошибочного.


text:
add tiktok option

@AbhishekDoshi26 I want to work on this. Please assign me.

@Shreemanarjun sure go on :)

Fixed by #15 @AbhishekDoshi26

Please assign the bug label to hacktoberfest if possible.

If the issue is still open, i will like to work on it.

Fixed in #15

authors: AbhishekDoshi26 Imsurajr Shreemanarjun danchengash


text:
Support SDC-Somalia-PDRC evaluation question 1

Closing in favour of the more complete #85

repo: AfricasVoices/Pool-IMAQAL


text:
update packages

:white_check_mark: Build TheIdServer 1.1.2-fix-dependencies1-0009 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/b984e5ee5b by @)

authors: AppVeyorBot aguacongas

repo: Aguafrommars/TheIdServer


text:
User/ole

:x: Build TheIdServer 7.0.0-user-ole1-0028 failed (commit https://github.com/Aguafrommars/TheIdServer/commit/81a256f8a6 by @)

:x: Build TheIdServer 7.0.0-user-ole1-0029 failed (commit https://github.com/Aguafrommars/TheIdServer/commit/aa300a5235 by @)

:white_check_mark: Build TheIdServer 7.0.0-user-ole.1+29.build.2778 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/aa300a5235 by @)


text:
What about using LLVM 16?

Not going to be supported until it is available to me on linux. I can only install LLVM 9, 11 or 13 with apt.

okay

Error: Found unsupported LLVM version 15.0.7. Only LLVM 11 and LLVM 13 are supported.

This error message comes from Makefile.posix, which hard-codes the versions 11 and 13 in various places.

Okay, let me test with 15 again.

Sooooo.....

It failed with a seg fault.

This error message comes from Makefile.posix, which hard-codes the versions 11 and 13 in various places.

So we make a branch, update it to 15 and try again?

Now there is also LLVM 16. I should upgrade Jou at some point :)
I'm not super excited about newer LLVM versions because they compile slower. It feels like newer LLVM versions have more stuff that I don't really need.

authors: Akuli Moosems littlewhitecloud

repo: Akuli/jou


text:
Fixes build instructions in README

Builds upon #47 but fixes the order of instructions as well.

Ping @Alberplz

Ping @Alberplz

Closing due to inactivity


text:
CDM-309 Additional optional eligibility and claim extensions

New extensions, examples and code/value sets. Non-breaking changes.

repo: Alvearie/alvearie-fhir-ig


text:
bump build-number, and add s390x support

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_9caowfdhr3/clone/recipe/meta.yaml:0: missing_version_or_name: The recipe is missing name and/or version
ERROR: /tmp/abs_9caowfdhr3/clone/recipe/meta.yaml:24: missing_hash: The recipe is missing a sha256 checksum for a source file
WARNING: /tmp/abs_9caowfdhr3/clone/recipe/meta.yaml:24: http_url: http://download.sinenomine.net/clefos/epel7/s390x/pandoc-static-1.16.0.2-1.el7.s390x.rpm is not https
WARNING: /tmp/abs_9caowfdhr3/clone/recipe/meta.yaml:26: http_url: http://download.sinenomine.net/clefos/epel7/s390x/pandoc-static-1.16.0.2-1.el7.s390x.rpm is not https
ERROR: /tmp/abs_9caowfdhr3/clone/recipe/meta.yaml:26: missing_hash: The recipe is missing a sha256 checksum for a source file
ERROR: /tmp/abs_9caowfdhr3/clone/recipe/meta.yaml:28: missing_hash: The recipe is missing a sha256 checksum for a source file
WARNING: /tmp/abs_9caowfdhr3/clone/recipe/meta.yaml:28: http_url: http://download.sinenomine.net/clefos/epel7/s390x/pandoc-static-1.16.0.2-1.el7.s390x.rpm is not https
ERROR: /tmp/abs_9caowfdhr3/clone/recipe/meta.yaml:50: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: EPL-2.0
ERROR: /tmp/abs_9caowfdhr3/clone/recipe/meta.yaml:51: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: EPL-2.0
WARNING: /tmp/abs_9caowfdhr3/clone/recipe/meta.yaml:59: missing_license_url: The recipe is missing a license_url
WARNING: /tmp/abs_9caowfdhr3/clone/recipe/meta.yaml:60: missing_license_url: The recipe is missing a license_url
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_1fbv64i9tg/clone/recipe/meta.yaml:0: missing_version_or_name: The recipe is missing name and/or version
ERROR: /tmp/abs_1fbv64i9tg/clone/recipe/meta.yaml:24: missing_hash: The recipe is missing a sha256 checksum for a source file
WARNING: /tmp/abs_1fbv64i9tg/clone/recipe/meta.yaml:24: http_url: http://download.sinenomine.net/clefos/epel7/s390x/pandoc-static-1.16.0.2-1.el7.s390x.rpm is not https
WARNING: /tmp/abs_1fbv64i9tg/clone/recipe/meta.yaml:26: http_url: http://download.sinenomine.net/clefos/epel7/s390x/pandoc-static-1.16.0.2-1.el7.s390x.rpm is not https
ERROR: /tmp/abs_1fbv64i9tg/clone/recipe/meta.yaml:26: missing_hash: The recipe is missing a sha256 checksum for a source file
ERROR: /tmp/abs_1fbv64i9tg/clone/recipe/meta.yaml:28: missing_hash: The recipe is missing a sha256 checksum for a source file
WARNING: /tmp/abs_1fbv64i9tg/clone/recipe/meta.yaml:28: http_url: http://download.sinenomine.net/clefos/epel7/s390x/pandoc-static-1.16.0.2-1.el7.s390x.rpm is not https
ERROR: /tmp/abs_1fbv64i9tg/clone/recipe/meta.yaml:53: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: MPL-2.0
ERROR: /tmp/abs_1fbv64i9tg/clone/recipe/meta.yaml:54: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: MPL-2.0
WARNING: /tmp/abs_1fbv64i9tg/clone/recipe/meta.yaml:62: missing_license_url: The recipe is missing a license_url
WARNING: /tmp/abs_1fbv64i9tg/clone/recipe/meta.yaml:63: missing_license_url: The recipe is missing a license_url
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_c3_b4juzis/clone/recipe/meta.yaml:0: missing_version_or_name: The recipe is missing name and/or version
WARNING: /tmp/abs_c3_b4juzis/clone/recipe/meta.yaml:24: http_url: http://download.sinenomine.net/clefos/epel7/s390x/pandoc-static-1.16.0.2-1.el7.s390x.rpm is not https
ERROR: /tmp/abs_c3_b4juzis/clone/recipe/meta.yaml:24: missing_hash: The recipe is missing a sha256 checksum for a source file
ERROR: /tmp/abs_c3_b4juzis/clone/recipe/meta.yaml:26: missing_hash: The recipe is missing a sha256 checksum for a source file
WARNING: /tmp/abs_c3_b4juzis/clone/recipe/meta.yaml:26: http_url: http://download.sinenomine.net/clefos/epel7/s390x/pandoc-static-1.16.0.2-1.el7.s390x.rpm is not https
WARNING: /tmp/abs_c3_b4juzis/clone/recipe/meta.yaml:28: http_url: http://download.sinenomine.net/clefos/epel7/s390x/pandoc-static-1.16.0.2-1.el7.s390x.rpm is not https
ERROR: /tmp/abs_c3_b4juzis/clone/recipe/meta.yaml:28: missing_hash: The recipe is missing a sha256 checksum for a source file
ERROR: /tmp/abs_c3_b4juzis/clone/recipe/meta.yaml:53: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: ZPL-2.0
ERROR: /tmp/abs_c3_b4juzis/clone/recipe/meta.yaml:54: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: ZPL-2.0
WARNING: /tmp/abs_c3_b4juzis/clone/recipe/meta.yaml:62: missing_license_url: The recipe is missing a license_url
WARNING: /tmp/abs_c3_b4juzis/clone/recipe/meta.yaml:63: missing_license_url: The recipe is missing a license_url
Errors were found

authors: anaconda-pkg-build katietz

repo: AnacondaRecipes/pandoc-feedstock


text:
기획서 작성

기획서 작성 완료했습니다. 전체적인 클라이언트 게임의 흐름과 룰, 공식에 대해서 작성해두었습니다.
각자 한번씩 확인 후, 코멘트 부탁드립니다.
@AppliedAlpha @Kimhyeog @cba700
https://brick-pong.notion.site/BrickPong-2315890adff4438183cf48facc08321b?pvs=4

확인했습니다. 해당 내용에 대해 보충해주시면 더 좋을 것 같습니다.

플레이 흐름의 '맵 선택' 장면 부분에서 (만약 볼륨 상의 문제가 없다면) Circle/One-Line/Classic 옵션을 선택할 수 있는데, 해당 옵션들에 대한 맵은 어떻게 구성되나요?
경기 화면에서 필요한 객체들은 각각 어떤 클래스들로 구성시킬 수 있으며(classify), 해당 클래스들은 어떤 속성과 메소드를 지니게 될까요?

당장의 결과물이 어떻게 나올지 모든 팀원의 머릿 속에 같은 장면이 그려져야 하고, 따라서 상세한 부분을 제외한 핵심적 부분들에 대한 기획서입니다.
맵의 디자인이 어떻게 설계되어 있을지, 경기화면에서 어떤 클래스들을 구현하고 적용하게 될 지는 추후 회의와 담당자의 작업을 통해서 정하게 될 것 같습니다.

빌드가 완성됨에 따라서 해당 이슈를 종료합니다.

authors: AppliedAlpha OruteZ

repo: AppliedAlpha/Brick-Pong


text:
[instrumentation] convenience methods for chain spans

Spit balling here:
from openinference.instrumentation import agent, chain, trace

@agent(name="calculator-agent")
def agent():
   ....

@chain
def apply_parameters():
   ....

In addition I may want to imparatively create a span inside of a function body:
tracer = tracer_provider.get_tracer(__name__)

def some_llm_function(input):
   tracer.start_as_active_span(
                               kind="chain"
                                input) as span:
              # do work
               stan.set_output(output)

authors: axiomofjoy mikeldking

repo: Arize-ai/openinference


text:
小游戏虚拟支付功能可以接入吗

check this module

有些字段不完善，可以提merge合并吗，一般多久会合并

repo: ArtisanCloud/PowerWeChat


text:
fix: externalize powershell to module

Should fix #9

repo: ArwynFr/actions-conventional-versioning


text:
Update Day 1_Data PreProcessing.md

update the link

update link


text:
add and test resource ID to Activity Log alerts

Completed.

repo: Azure/AzureMonitorStarterPacks


text:
[WIP] check default value for keyword only arguments

Hi @iscai-msft , would you help to check whether the current generated code is our goal for this issue?
And I find currently DefaultXXX don't work for None value, I plan to add logic in it to handle None default values.