text:
More ChEMBL molecules that fail bounds smoothing

['C=C1NC(=O)C(C(C)C)NC(=O)C(C(C)CC)NC(=O)c2nc(oc2-c2ccccc2)-c2coc(n2)-c2csc(n2)-c2coc(n2)-c2coc1n2',
'CCC(C)C1NC(=O)c2nc(oc2-c2ccccc2)-c2coc(n2)-c2csc(n2)-c2coc(n2)-c2coc(n2)CNC(=O)C(C(C)C)NC1=O',
'CCC(C)C1NC(=O)c2nc(oc2-c2ccccc2)-c2coc(n2)-c2csc(n2)-c2coc(n2)-c2coc(n2)C(COC(C)=O)NC(=O)C(C(C)C)NC1=O',
'CCC(C)C1NC(=O)c2nc(oc2-c2ccccc2)-c2coc(n2)-c2csc(n2)-c2coc(n2)-c2coc(n2)C(COC(=O)COCCOCCOC)NC(=O)C(C(C)C)NC1=O',
'C=C1NC(=O)C(C(C)C)NC(=O)C(C(C)CC)NC(=O)c2nc(oc2-c2ccccc2)-c2coc(n2)-c2csc(n2)-c2coc(n2)-c2nc1oc2C',
'C=C1NC(=O)C(C(C)C)NC(=O)C(C(C)CC)NC(=O)c2nc(oc2-c2ccccc2)-c2nc(oc2C)-c2csc(n2)-c2coc(n2)-c2nc1oc2C',
'CCC(C)C1NC(=O)c2nc(oc2-c2ccccc2)-c2coc(n2)-c2csc(n2)-c2coc(n2)-c2coc(n2)C(COC(=O)COCCOC)NC(=O)C(C(C)C)NC1=O',
'C=C1NC(=O)C(C(C)C)NC(=O)C(C(C)CC)NC(=O)c2nc(oc2-c2ccccc2)-c2nc(oc2C)-c2csc(n2)-c2coc(n2)-c2coc1n2',
'CCC(C)C1NC(=O)c2nc(oc2-c2ccccc2)-c2coc(n2)-c2csc(n2)-c2coc(n2)-c2coc(n2)C(COC(=O)C(N)CCCNC(=N)N)NC(=O)C(C(C)C)NC1=O']

This bears a passing resemblance to #696

But then, after looking more closely, it becomes clear that these all have a S-containing aromatic heterocycle. @sriniker : we saw this problem while working on the ETKDG paper.

Yes, we had problems with these three SMILES:
C[C@@H]1[C@@H]2Cc3ccc(O)cc3[C@]1(C)CCN2CCN4CCCCCC4
CCN(CC)CCN1CC[C@]2(C)C@H[C@@H]1Cc3ccc(O)cc23
C[C@@H]1[C@@H]2Cc3ccc(O)cc3[C@]1(C)CCN2CCN(C)C
where no conformation could be generated.
If one stereocenter was changed, everything worked fine:
C[C@@H]1[C@H]2Cc3ccc(O)cc3[C@]1(C)CCN2CCN4CCCCCC4
CCN(CC)CCN1CC[C@@]2(C)C@H[C@@H]1Cc3ccc(O)cc23
C[C@@H]1[C@H]2Cc3ccc(O)cc3[C@]1(C)CCN2CCN(C)C

Weren't there some examples where an aromatic S in a five-membered ring was a problem?

True. There was also an issue with the following molecule
CCOC(=O)N1N(C(=O)OCC)[C@]2(c3ccccc3)S[C@@]1(c1ccccc1)C(=O)N2c1ccccc1
where some distance bounds are not optimal. This is, however, not an aromatic ring. Nevertheless, I guess the problem is related.
On 14 Dec 2015, at 12:47, Greg Landrum notifications@github.com wrote:

Weren't there some examples where an aromatic S in a five-membered ring was a problem?
—
Reply to this email directly or view it on GitHub.

authors: greglandrum sriniker


text:
SMARTS-pattern [r] only works to max 20 members

While implementing certain filter from certain commercial molecular modeling toolkit in RDKit, I noticed that the member limit for SMARTS-pattern [r] is a bit low.
To invoke error,
from rdkit import Chem
works = Chem.MolFromSmarts("[r20]")
fails = Chem.MolFromSmarts("[r21]")
I get an Range error message pointing to function makeAtomMinRingSizeQuery() at QueryOps.cpp.
This is not an issue in my specific application as I worked around this by modifying my filter to stop at value 20 instead of the original value of 24, but still...

How far out do you think it should go?

The filter in question had SMARTS for [r24] so I'd guess that should be enough.

I encountered this today, coincidentally with up to r24, too.
Just out of curiosity, what is the reason for having an upper limit here? Is there a performance optimization elsewhere that limits ring-finding to a certain length?

It's not a performance thing, it's just that the way those queries are implemented requires that there be a explicit enumeration of all possible ring sizes in the C++ code.

An idea without knowing the code. Could the enumeration be done lazy so
that if a user requests a larger ring size, the pattern is added
dynamically?
On Mon, Dec 12, 2016 at 10:39 PM Greg Landrum notifications@github.com
wrote:

It's not a performance thing, it's just that the way those queries are
implemented requires that there be a explicit enumeration of all possible
ring sizes in the C++ code.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/issues/723#issuecomment-266631495, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIUQvzgna_xxkB3h1z9Pga_qY06T4cZaks5rHhNUgaJpZM4HBHqs
.

The code could certainly be rewritten to allow that, but I'm not really sure that I see this as a frequently occurring use case. How often is it useful to search for an atom in such large smallest rings?
Given a particular (reasonable) upper limit, it's easy enough to modify the code.
Remember that this isn't going to allow "atom is in a ring larger than 20" type queries in any case.

Thank you; I've looked at the code now and see this is due to the way templates are used to supply the predicate functions implementing the r atomic primitive.
The issue has arisen when people use an existing SMARTS-based tool to find macrocycles, so in order to suggest a limit one could ask, how large can an "interesting" macrocycle be? Maybe 50, which the paper below suggest is close to the limit for naturally occurring macrocycles?
"Although the size of naturally occurring macrocycles can reach 50+ atoms in the largest ring, a recent analysis of natural products suggested that 14-, 16-, and 18-membered frameworks are the most common naturally occurring macrocyclic scaffolds" -- http://pubs.rsc.org/en/content/articlehtml/2015/sc/c4sc03089c
Admittedly, SMARTS is not ideal for this because the r primitive does not allow a range, much less an open one; sometimes I see ugly queries like "[r11,r12,r13,r14,r15,r16,r17,r18,r19,r20]". But there's a certain convenience to users who do this as just one piece of their SMARTS-based filtering workflow.

This seems like a great example of the class of problem that's better solved using a bit of code instead of a SMARTS pattern.
Here's an example using the current RDKit capabilities that shows at least part of how this could look:
In [4]: m = Chem.MolFromSmiles('C2'+'CC1(CCC1)'*15 + 'C2')

In [5]: from rdkit.Chem import rdqueries

In [6]: qa = rdqueries.MinRingSizeGreaterQueryAtom(24)

In [7]: qa2 = rdqueries.MinRingSizeLessQueryAtom(40)

In [15]: ms1 = set(x.GetIdx() for x in m.GetAtomsMatchingQuery(qa))

In [16]: ms2 = set(x.GetIdx() for x in m.GetAtomsMatchingQuery(qa2))

In [17]: ms1 & ms2
Out[17]: {0, 1, 6, 11, 16, 21, 26, 31, 36, 41, 46, 51, 56, 61, 66, 71, 76}

Of course the predicate we want is not MinRingSize but InRingSize (which does not currently exist), but hopefully the idea is clear.

source: gharchive/issue

authors: TuomoKalliokoski gedeck greglandrum i-tub

repo: rdkit/rdkit

license_type: permissive

license_source: github-api


text:
Make FMCS check bond stereo.

Reference Issue
Fixes issue discussed in https://github.com/rdkit/rdkit/discussions/5000
What does this implement/fix? Explain your changes.
the RMCS checkBondStereo function only compared if the bond stereo was defined for one bond, and not for the other.  It didn't check to see that if they were both set, that they matched.  Thus CC\C=C\CC and CC\C=C/CC were deemed a match.
Any other comments?
Tested on macOS and C++ only.

I don't think the failures are mine, although they both fail in testRGroupDecomp which smells a bit suspicious.  That test works on my MacBook Pro.  I don't have a windows build environment.

@DavidACosgrove https://github.com/rdkit/rdkit/blob/0d8e985c381080a87adad96ab3b0372850005de1/Code/GraphMol/RGroupDecomposition/testRGroupDecomp.cpp#L1319
https://github.com/rdkit/rdkit/blob/0d8e985c381080a87adad96ab3b0372850005de1/Code/GraphMol/RGroupDecomposition/testRGroupDecomp.cpp#L1321

Thanks @ptosco, that's done the job nicely.

Thanks @DavidACosgrove! I'll merge this once the tests pass.

source: gharchive/pull-request

authors: DavidACosgrove greglandrum ptosco


text:
Work with images and other assets

Hello, I don't understand how to work with assets.
I have follow structure: (shortly)
app/
|   assets/
|   |   images/
|   |   fonts/
|   components/
|   containers/
|   app.js
build/
internals/

In folder assets/images I have a *.png images and I would like to you use them as background in styled-components.
But webpack can not find and load them.
I found solution like this:
import '!file-loader?name=./assets/images/[name].[ext]!./bg.png';

But when I run build I get an error:
ERROR in ./app/app.js
Module not found: Error: Can't resolve './bg.png' in '/my locale path/app'

Is there some tutorial or something else how to work with assets?
Thank you

Try use import '!file-loader?name=[name].[ext]!./assets/images/bg.png'; in your app.js

@archansel Thx, it looks like it works.
I think I understand. It's something like alias. When you want to use them like for example background image you can not use full path but only file name. There was the problem :)

Seems like i'm having the same issue, except this solution does not work for me. I have checked my route in my css
background-image: url(./images/icons/logo/big.png);
but it seems i am only getting an html page whenever my image is requested. and i have the following code in my app/app.js
import '!file-loader?name=[name].[ext]!./images/icons/logo/big.png';

Nevermind, i just figured it out. I have to require the image and use it:
const img = require('../images/icons/logo/big.png');

Hello, how can we use image in custom css file.
background: url(/images/header/book.png) no-repeat;
I tried it but cannot show.
Thanks

authors: archansel mmclau14 nguyenhuutinh zvitek

repo: react-boilerplate/react-boilerplate

license: mit

license_source: bigquery


text:
Remove state update in componentWillUpdate

This PR removes the setState() in componentWillUpdate of the ProgressBar component.
See React.Component componentwillupdate documentation.

Coverage remained the same at 99.242% when pulling c0aef89d3813a40b7489c1d90b1a5ec2108475e5 on mawi12345:dev into cfe0c7ce16e376bb32df1ac6b27ac715a6cf6c1f on react-boilerplate:dev.

With this PR it is possible to switch to Inferno by running:
yarn add inferno inferno-compat
yarn remove react react-dom

and adding in webpack.base.babel.js:79 the alias configuration:
  ...
  resolve: {
    alias: {
      react: 'inferno-compat',
      'react-dom': 'inferno-compat',
    },
  ...

LGTM 👍

authors: coveralls justingreenberg mawi12345


text:
How to remove filter label and add arrow for the dropdown?

Hi
I am new to React and have started using bootstrap table 2. I have two questions:

How can I remove the filter label?
Why is the dropdown arrow not showing?

Thank you.

I am facing the same issue. Tried multiple work-arounds such as removing the label text from core libraries of react-bootstrap-table2. However it doesn't work :-(

license: MIT


text:
Support for victory-native (https://github.com/FormidableLabs/victory-native)

Is victory-native supported with create-react-native-app?
I tried this example https://github.com/sibelius/victory-native-demo-crna which uses create-react-native-app but it didn't work. I got the following error message - "Error while updating property 'd' in shadow node of type:RNSVGPath" (see attached image).
I am already discussing this with the author but I just wanted to check in case it's a known issue that victory-native doesn't work with create-react-native-app.

Hi! victory-native does work when loaded in Expo, we use it in one of our test projects:
https://github.com/expo/native-component-list/blob/master/screens/SVGScreen.js
with this package.json:
https://github.com/expo/native-component-list/blob/master/package.json#L17
You can load the app in the Expo client at this URL:
https://expo.io/@community/native-component-list
You can find the victory-native example if you tap the ^ icon in the top right and scroll down to the SVG example.
I'd recommend trying this with the latest RN and SDK versions supported, the example project you linked uses SDK 14. See the versions guide for information about upgrading.
cc @sibelius

Hi! I'm also getting the same error message, but after saw your comment I just look over your test project, but I cannot understand the usage of react-native-svg in your SVGScreen.js file.
And I'm just trying with your code for render victory chart and getting this error:

authors: AvijitDutta95 dikaiosune nikhilag

repo: react-community/create-react-native-app


text:
Change header color

The below is my code. I tried to various ways to change the header color but i cant seem to get it right. can anyone help?
 static navigationOptions = ({navigation}) => ({

    title: 'Welcome',
    drawerLabel: 'Home',
    headerLeft: (
        <View style={{padding:10}}>
            <Icon
                onPress={() => navigation.navigate('DrawerOpen')}
                name='menu'
                //type='ionicon'
                color='black'
            />
        </View>
    )
  });

You can add headerStyle: {
backgroundColor: yourcolor,
},

@xght  hi! thanks for the help! it works.
do you have any idea how to remove the shadow from the header?

found #297

 static navigationOptions = ({navigation}) => ({

    title: 'Welcome',
    drawerLabel: 'Home',
      headerStyle: {
            backgroundColor: '#b510d3',
            elevation: 0,
        },
    headerLeft: (
        <View style={{padding:10}}>
            <Icon
                onPress={() => navigation.navigate('DrawerOpen')}
                name='menu'
                //type='ionicon'
                color='black'
            />
        </View>
    )
  });

i cant seem to get the elevation to be removed. Got warning saying bad object.

authors: saeropark xght

repo: react-community/react-navigation


text:
I need to disable gestures about swipe to change screen

I need to disable gestures about swipe to change screen
but i choose false for gesturesEnabled it's not working
https://gist.github.com/boyinfotronics/b48a6cd4726fc66fbc5fa37f9ce4846b

Hi! In an effort to get the hundreds of issues on this repo under control I'm closing issues tagged as questions. Please don't take this personally - it's simply something we need to do to get the issues to a manageable point. If you still have a question I encourage you to re-read the docs, ask on StackOverflow, or ask on the #react-navigation Reactiflux channel. Thank you!

authors: boyinfotronics spencercarli


text:
Getting [js] ';' expected When added Constructor to Drawer Page

Why I Got This Error: [js] ';' expected When added Constructor to My MyPhotosHomeScreen Page in DrawerNavigator?
MyPhotosHomeScreen Page:
const MyNavScreen = ({ navigation }) => (
  <View>
    <View style={styles.containerNavbar}>
      <TouchableHighlight onPress={() => navigation.navigate('DrawerOpen')}>
        <Icon name="bars" size={30} color="#fff" />
      </TouchableHighlight>
      <Text style={styles.navbarTitle}>Photos</Text>
    </View>

    <ScrollView>
      <View><Text>photo</Text></View>
      <Button onPress={() => navigation.goBack(null)} title="Go back" />
    </ScrollView>

    <ListView
      style={styles.listContainer}
      renderRow={this.renderRow.bind(this)}
      dataSource={this.state.dataSource}
    />
  </View>
);

const MyPhotosHomeScreen = ({ navigation }) => (
  <MyNavScreen navigation={navigation} />
);
MyPhotosHomeScreen.navigationOptions = {
  title: 'Photos',
  drawerIcon: ({ tintColor }) => (
    <MaterialIcons
      name="photo"
      size={24}
      style={{ color: tintColor }}
    />
  ),
};
export default MyPhotosHomeScreen;

And I want to add This constructor:
constructor(props) {
  super(props)
  const ds = new ListView.DataSource({ rowHasChanged: (r1, r2) => r1 !== r2 })
  this.state = {
    dataSource: ds.cloneWithRows(data),
  }
}

Bot I Got This:

the constructor needs to be inside a class...


text:
Error: navigation.state.params is always undefined in 'static navigationOptions'

I have the most bizarre problem that has had me stuck for days now. The heart of the problem is that when I have this in my navigationOptions:
static navigationOptions = ({ navigation }) => {
    console.log(navigation)
    console.log(navigation.state)
}

Current Behavior
The first 'console.log' statement returns the navigation object complete with "navigation.state.params" containing the params that I have passed into it, just as expected.
However, the second 'console.log' returns the 'navigation.state' object but for some reason the 'params' are undefined. When I try to access 'navigation.state.params' it gives me the error 'cannot read [param] of undefined'.
Expected Behavior
navigation.state.params should contain what I want it to in the second call, no?
Your Environment

Here is how I am setting the navigation params (from redux):
function mapStateToProps(state, props) {
    let sum = 0
    for (let product in state.cart) {
        sum += state.cart[product]
    }
    return props.navigation.state = {params: {cartSum: sum}}
}

And my dev environment:

software
version

react-navigation
1.0.0-beta.11

react-native
0.46.4

node
6.10.1

redux
3.7.1

react-redux
5.0.5

That's odd - a running example of this issue would be very helpful. Thanks!

Closing for inactivity, but feel free to reopen, ideally with a minimal repro on expo snack.

authors: philipshen spencercarli vonovak


text:
Fix flowtype errors on React Native >= 0.43

When using react-native>=0.43 (flow ^0.40.0), flow errors have been introduced, which breaks build steps. I've bumped the version to match what React Native installs by default and fixed these errors.
I'm unsure as to whether the flow errors are actually a result of a flow bug, however. There is this issue on the flow repository, but unfortunately no one has chimed in to say whether it's intended or not. In any case, the error was stemming from two different types of React elements being conditionally returned.
Maybe the deps version bump would be better off as a separate pull request entirely. Happy to tweak things if necessary.

@satya164 Could you do me a favor and have a look at this? This currently blocks our team :/

Closed in https://github.com/react-community/react-navigation/commit/2bbfc03cd0669e01cfd8f7f2d22ccae23e4dfb88

authors: DanielMSchmidt grabbou joemckie


text:
JS Animation

Hi,
I'm trying to animate an image on appear, enter and leave with JS.
i'm doing something like that:
<Animate
          component=""
          transitionAppear={false}
          transitionEnter={false}
          transitionLeave={false}
          onEnd={this.animateEnded.bind(this)}
          animation={this.state.animationObject}>
          {
            this.state.imageStatus &&
            <img
              key={new Date()}
              ref="image"
              src={this.state.currentImgSource}>
            </img>
           }
</Animate>

The appear event work correctly and is triggered but the others are not.
I only change imageStatus state to true or false if img is loaded or not.
When i set imgStatus state to false the img disappear without the leave animation and the appear animation is triggered again...
it should not, right ? :)
(i added a key on the img tag, with a date, i don't know if i have to do this)
I don't figure out what i'm doing wrong...
Thanks

请问  Animate 的onEnd事件 怎么触发？

authors: FredHasselot hqwlkj

repo: react-component/animate


text:
Handling multiple date-ranges in a single parent

I'm using react-dates in an advanced search component that incorporates multiple date-range fields.
I'm trying to figure out the best way to detect which of the date-range pickers is being changed and handle the event accordingly in the onFocusChange and onDateChange callbacks without writing a separate handler with superficial differences to target the appropriate attribute for each instance of the component.
Is there a way to access the event target within the defined callbacks?
I'm imagining something along the lines of:
onFocusChange(event, focusedInput){
    var newState = object.assign({}, this.state);
    newState[event.target.id].focusedInput = focusedInput;
    this.setState(newState);
}

But maybe it would be a better approach to store another variable on the state which stores the focused date-range picker?
Any insight would be greatly appreciated!
Update: I've written a closure to return a case-specific handler for each field which is adequate to my use case, but I am still curious if it's possible to access the source event.

Hmmm, maybe we should pass it back just in case. I will mull this over.

I'm in the same boat here. I am managing a few massive forms, and all other inputs update the parent state in much the same way that @andosteinmetz has described:
handleUpdateField = (e, date) => {
  const property = e.target.name;
  this.setState({
    publication: {
      ...this.state.publication,
      [property]: date
    }
  });
}

My thoughts were that react-dates would behave much like any other input element. Of course the moment object needs to be passed to the callback, but it seems counter-intuitive to not have the event passed like any other input.
Did you find a temporary workaround?

Hi @tyleralves ,
My solution was to write a closure that returns a function specific to the active react dates instance.
In my case there was one instance to set a range for when a record was created, and another range for the date the record was most recently modified: called 'created' and 'changed' respectively.
Here are my two handler functions for focus and date changes respectively:
function handleFocusChange(attr){
    return function(focusedInput){
        var dates = this.state[attr];
        dates.focusedInput = focusedInput;
        let newState = {};
        newState[attr] = dates;
        this.setState(newState);
    }
}

function handleDatesChange(attr){
    return function({startDate, endDate}){
        var dates = this.state[attr];
        dates.startDate = startDate;
        dates.endDate = endDate;
        startDate ? dates.gte = startDate.format('YYYY[-]MM[-]DD') : delete dates.gte;
        endDate ? dates.lte = endDate.format('YYYY[-]MM[-]DD') : delete dates.lte;
        let newState = {};
        newState[attr] = dates;
        this.setState(newState);
    }
}

and here's how I used it in my component:
class MyComponent extends React.Component
{
    constructor(props){
        super(props);
        this._onCreatedFocusChange = handleFocusChange('created').bind(this);
        this._onCreatedDatesChange = handleDatesChange('created').bind(this);
        this._onUpdatedFocusChange = handleFocusChange('changed').bind(this);
        this._onUpdatedDatesChange = handleDatesChange('changed').bind(this);
    }

and then in the ReactDates instances:
render(){
        const createdRange = (

                <DateRangePickerField
                    isOutsideRange = {() => false }
                    showClearDates = {true}
                    label = 'Created:'
                    focusedInput = {this.state.created.focusedInput}
                    startDate = {this.state.created.startDate}
                    endDate = {this.state.created.endDate}
                    onDatesChange = {this._onCreatedDatesChange}
                    onFocusChange = {this._onCreatedFocusChange}
                />

        );

        const changedRange = (

                <DateRangePickerField
                    isOutsideRange = {() => false}
                    showClearDates = {true}
                    label = 'Updated:'
                    focusedInput = {this.state.changed.focusedInput}
                    startDate = {this.state.changed.startDate}
                    endDate = {this.state.changed.endDate}
                    onDatesChange = {this._onUpdatedDatesChange}
                    onFocusChange = {this._onUpdatedFocusChange}
                />

        );

Hope this is helpful in your case as well!

@andosteinmetz Hmm, we have a different setup but your solution got me to where I needed to go. Thanks!
My situation is a container component (EditPublicationContainer) that maintains the full form state and has many child input components (FormInput). An onUpdateField function on the EditPublicationContainer component updates state. The onUpdateField may not be bound to the child component's this because it still must call this.setState in the parent component.
  /* EditPublicationContainer Component */
  handleUpdateField = (value: any, self?: any) => {
    // Update local state (temp form data) when input value changes
    // React-datepicker doesn't return an event object, so component props are passed through self
    const property = self.props.property;

    this.setState({
      publication: {
        ...this.state.publication,
        [property]: value
      }
    });
  }

/* FormInput Component
export class FormInput extends React.Component<FormInputProps, any> {
  constructor() {
    super();
  }

  // React-datepicker doesn't return a consistent event object, so we pass this directly instead
  handleUpdateDateField = (date: any) => this.props.onUpdateField(date, this);

  render() {
    const {props} = this;

    let inputElement;

    switch (props.type) {
      case 'date':
        // tslint:disable-next-line max-line-length
        // tslint:disable
        inputElement = (
          <DatePicker
            data-type={props.type}
            id={`form-input-${props.type}-${props.property}`}
            name={props.property}
            selected={props.value || moment()}
            onChange={this.handleUpdateDateField}            // Call the class property
            {...props.xtra}/>
        );
        break;
        ...

I am using multiple DateRangePicker that dynamically added in single page. There is another solution.
constructor(props) {
    super(props);
    this.onDatesChange = this.onDatesChange.bind(this);
    this.onFocusChange = this.onFocusChange.bind(this);
    this.state = {
      startDate: {},
      endDate: {},
      focusedInput: {},
    };
  }

// id is unique value for each instance and you can define it
onDatesChange(id, { startDate, endDate }) {
    const start = this.state.startDate;
    const end = this.state.endDate;
    start[id] = startDate;
    end[id] = endDate;
    this.setState({
      startDate: start,
      endDate: end,
    });
  }

  onFocusChange(id, value) {
    const focusedInput = this.state.focusedInput;
    focusedInput[id] = value;
    this.setState({
      focusedInput,
    });
  }

<DateRangePicker
                    startDate={this.state.startDate[id]}
                    endDate={this.state.endDate[id]}
                    onDatesChange={({ startDate, endDate }) => this.onDatesChange(id, { startDate, endDate })}
                    focusedInput={this.state.focusedInput[id]}
                    onFocusChange={(focusedInput) => this.onFocusChange(id, focusedInput)}
                  />

@munkhjin0223 if the startDate is null, typed error occurred

Hi all,
I just wonder if I can use two separate DateRangePicker at one page, and if so how can I do it?
I created two widgets with different IDs but they seem do not work together.

not work together. if we can add two date range picker

authors: IIAT-MR-LHL andosteinmetz majapw munkhjin0223 olegbolden ovesh-ampush tyleralves

repo: react-dates/react-dates


text:
React Native peer dependency warning

Summary:
yarn add @react-native-community/async-storage
when running rn 0.59.0 gives:
warning " > @react-native-community/async-storage@1.2.2" has incorrect peer dependency "react-native@^0.57.0".
Test Plan:

Hey @mifi ,
Can you provide a status of this PR?
thanks.

I updated the pr now

:tada: This PR is included in version 1.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: Krizzu mifi


text:
Animation not working at all most of the time, when setting 'isLoading' to true by default

I have a screen that always needs a skeleton screen to be rendered underneath another screen, I get no animation at all when setting 'isLoading' to true.
const App = () => {
  const firstLayout = [
    {
      width: 60,
      height: 60,
      borderRadius: 30,
    },
    {
      width: 140,
      height: 30,
    },
  ];
  const secondLayout = [
    {
      width: 240,
      height: 100,
      marginBottom: 10,
    },
    {
      width: 180,
      height: 40,
    },
  ];
  const thirdLayout = [
    {
      width: 220,
      height: 20,
      marginBottom: 6,
    },
    {
      width: 180,
      height: 20,
    },
  ];

  return (
    <View style={styles.container}>
      <SkeletonContent
        containerStyle={styles.top}
        layout={firstLayout}
        isLoading={true}
      />

      <SkeletonContent
        containerStyle={styles.titleContainer}
        layout={secondLayout}
        isLoading={true}
      />

      <SkeletonContent
        layout={thirdLayout}
        containerStyle={styles.descContainer}
        isLoading={true}
      />
    </View>
  );
};

const styles = StyleSheet.create({
  container: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
    backgroundColor: '#ecf0f1',
    padding: 8,
  },
  image: {
    resizeMode: 'contain',
    height: 36,
  },
  titleContainer: {
    width: 300,
    padding: 20,
    justifyContent: 'flex-start',
    flex: 2,
  },
  descContainer: {
    width: 300,
    padding: 20,
    flex: 1,
  },
  top: {
    width: 300,
    flex: 1,
    flexDirection: 'row',
    alignItems: 'center',
    justifyContent: 'space-between',
    padding: 20,
  },
  imageContainer: {
    width: 60,
    height: 60,
    borderRadius: 30,
    alignItems: 'center',
    justifyContent: 'center',
  },
  normalText: {
    fontSize: 18,
  },
  bigText: {
    fontWeight: 'bold',
    fontSize: 28,
  },
  card: {
    height: 400,
    width: 300,
    borderRadius: 10,
    backgroundColor: '#fff',
  },
});

export default App;

Using React Native Version 0.62
Using non-expo version
System:
OS: macOS 10.15.4
CPU: (8) x64 Intel(R) Core(TM) i7-8569U CPU @ 2.80GHz
Memory: 1.05 GB / 16.00 GB
Shell: 5.8 - /usr/local/bin/zsh
Binaries:
Node: 13.12.0 - ~/.nvm/versions/node/v13.12.0/bin/node
Yarn: 1.22.4 - /usr/local/bin/yarn
npm: 6.14.4 - ~/.nvm/versions/node/v13.12.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.9.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 13.4, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
Android SDK:
API Levels: 28, 29
Build Tools: 28.0.3, 29.0.3
System Images: android-29 | Google Play Intel x86 Atom
Android NDK: Not Found
IDEs:
Android Studio: 3.6 AI-192.7142.36.36.6392135
Xcode: 11.4.1/11E503a - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_252 - /usr/bin/javac
Python: 2.7.17 - /usr/local/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.11.0 => 16.11.0
react-native: 0.62.2 => 0.62.2
npmGlobalPackages:
react-native: Not Found

This can be partially resolved when adding in some state like so:
  const [_, forceState] = useState<string>();

  useEffect(() => {
    forceState('');
  }, []);

But then sometimes it stops doing the animation properly:

And sometimes the animation is in 1 corner and barely visiable...

Wrong library !


text:
Modal does not show animations

My Modal does not show animations when I try using: "animationIn" or "animationOut" but for some reason when I try animationType="slide" it does slide but its very slow and looks ugly because firstly the black opacity background slides in and then the modal just pops up after few seconds.
I created a Stackoverflow Q for this before asking here but maybe you guys know the answer.
LINK: https://stackoverflow.com/questions/55648575/react-native-modal-doesnt-show-animations

I would suggest you to create a small repository with a minimal example to reproduce your issue.
Most of the times by doing so you'll be able to detect where the issue is.
Unfortunately without it (and without any info from the issue template) we won't be able to help... feel free to re-open an issue here if you discover any bug!
Good luck!

authors: mmazzarolo yesIamFaded


text:
fix android sms share default app issue

Overview
In my Android phone, the sms share is not functional.
So I use android.provider.Telephony.Sms.getDefaultSmsPackage to get system provider package name.
Test Plan
when android use Share.shareSingle with sms, will correctly work.  ( call to internal sms app ).

LGTM!

@Seachaos you can try verifying your commit please?
If you have any doubt about this, please give a look at: https://help.github.com/en/articles/checking-your-commit-and-tag-signature-verification-status

@Seachaos you can try verifying your commit please?
If you have any doubt about this, please give a look at: https://help.github.com/en/articles/checking-your-commit-and-tag-signature-verification-status

OK, I try use PGP and make commit verified signature..
Is this work ?
Thanks.

Interesting - if I understand this correctly, did you have a non-default SMS provider installed on your phone? If you do, and this only works with your fix (which LGTM as well), this would show how rare it is for people to change their default SMS provider or try to share by it! It would have never worked above API19 without this

authors: MateusAndrade Seachaos mikehardy


text:
i can not remove video when changing to another page

I run the app on android TV, in fact when every page has a video component,app would be crash.
so i need to remove video before change pages

Please post a question on StackOverflow if you need help with implementation.

authors: jenshandersson sasaluo


text:
'react-native-video': platform 'android-25' not found.

Getting this error when building from Android Studio:
Error: Module 'react-native-video' platform 'android-25' not found.

Did you installed the Android SDK build tools for Android 25?

It sounds like you are missing the build tools like @Ziv-Barber said.

authors: Ziv-Barber cobarx dht


text:
fix: position of dots indicator

Summary
Close #93
Test Plan
Press button Hide/Show Dots and check page control view

OS
Implemented

iOS
✅

Android
❌

Checklist

[x] I have tested this on a device and a simulator
[x] I added the documentation in README.md
[x] I added a sample use of the API in the example project (example/App.js)


text:
Main Issue

Welcome!
This will be the first Application that will develop in the React Native Dojo.
Idea
App for Blood Donation
App's goals:: Engage people to donate blood; Learn bleeding edge technologies
Features that the App should be able to do:

[ ] Show hospitals and Mostrar Hospitais and local blood collections
[ ] Push notification when blood stock is low, asking user to donate some blood
[ ] Share on Social Networks
[ ] Invite friends to use the app
[ ] Charts with Blood Donation Statistics
[ ] ... and so on - TODO - add more features later

You should click on Watch and Start buttons on top, to follow the progress of this repo
We will use Rounds (Milestones) of development.
In each Milestones - N participants will focus on M issues

pinging all participants:
@maugravena
@lucasbsilva
@guipsamora
@charbelram
@eduardochenrique
@dehbmarques
@gustvao
@pedpess
@tzdesing
@arthur-vieira
@varnion
@arthur-vieira

@henriquesosa add all of them for this repo, so we can assign them to issues

@arthur-vieira responsible for the Mobile Design #2

@pedpess responsible for the Web Screens Design #3

@lucasbsilva and @tzdesing responsible for the Database Design #4

I'd like to participate in the front-end dev.

@charbelrami I forget to explain this - We will use Rounds (Milestones) of development, in the first round, 4 people will work on some issues. In the next round, another users will be assigned to another tasks

OK, thanks!

why i'm not a participant? :(

@ylaguna my fault, sorry, added. Did I missed anyone else?

@sibeliusseraphini no problem, thanks :)

Guys, it's very important for everybody mind other products who has the same 'core' (blood donation), i found this article about some apps that could help and guide us in design and development (in portuguese).
http://www.plugbr.net/aplicativos-ajudam-bancos-de-sangue-salvar-vidas-app-avisa-doador-estoques-de-tipos-de-sangue-agenda-coleta-retorno-e-urgencias/
Would be great to analyze this products and maybe provide something that they are not.

@EduardoCHenrique we could open one issue per feature, and discuss whether it is necessary or not, and what we need to do to deliver it.
Feel free to open the first one

@sibeliusseraphini why we still on 1st round?

@ylaguna thanks for this questions.
Last week we were discussing on Gitter about the right approach to proceed with the development of this Dojo
I didn't have time to discuss with @keuller and @henriquesosa what will be the next steps for this project.
@keuller proposed to start by the View (Web and Mobile) part instead of the Model.
The ideia would be to first design all the app using only mocked (fake) data without server interaction, and after that we start to develop the server as well.
I really want this to work out to everybody here, and I would like to here some feedback on this discussion, feel free to go to Gitter and discuss with us

can I still enter the development? =)

sure!

@gionaufal  I created a new milestone to the project. If you want to help us, please enjoy!

authors: EduardoCHenrique charbelrami gionaufal henriquesosa sibeliusseraphini ylaguna

repo: react-native-dojo/BloodDonationDojo


text:
Error: Given track ID was not found in queue

Configuration
React Native Environment Info:
System:
OS: Linux 4.15 Ubuntu 18.04.2 LTS (Bionic Beaver)
CPU: (4) x64 Intel(R) Core(TM) i7-5500U CPU @ 2.40GHz
Memory: 814.81 MB / 11.60 GB
Shell: 4.4.19 - /bin/bash
Binaries:
Node: 8.10.0 - /usr/bin/node
Yarn: 1.16.0 - /usr/bin/yarn
npm: 6.9.0 - /usr/local/bin/npm
IDEs:
Android Studio: 3.3 AI-182.5107.16.33.5314842
npmPackages:
react: ^16.8.6 => 16.8.6
react-native: ^0.59.8 => 0.59.8
Issue
Maybe I missed undestood about this functions add(tracks, insertBeforeId), but its supposed the second song of my array object start to play in first place or am I wrong?
Code
const tracks = [
{
    id: "1002",
    url: "https://url_song",
    title: "Awesome music",
    artist: "Artist name",
    album: "Best album",
    artwork: "https://cover_url"
},
{
    id: "1003",
    url: "https://url_song",
    title: "Awesome music",
    artist: "Artist name",
    album: "Best album",
    artwork: "https://cover_url"
},
];

TrackPlayer.add(tracks, tracks[1].id);

If I understand your question correctly then yes you have misunderstood.
Firstly add doesn’t play.
Secondly insertById doesn’t skip, skip does
What you want is:
Trackplayer.add(tracks)
Trackplayer.skip(tracks[1].id)
Trackplayer.play()
The second param of add indicates where to add the new tracks in the existing queue

@brenwell, you rock.

I also get this Issue than I want to Play the PlayList of the Local Files in IOS.

authors: Sandeep155Vibhuti brenwell ithustle


text:
Style element

Question
I'm using this smooth-code svg to jsx converter to render my svg components. My designer co-worker is sending me the svg files with the style element, it looks like this:
<style>.a{fill:none;}.b{clip-path:url(#a);}.c{clip-path:url(#b);}.d{fill:#fff;}.e{fill:#f8cd2d;}.f{fill:#e2222c;}.g{fill:#14673b;}.h{clip-path:url(#c);}</style>
smooth-code converts them but with this message:
/* SVGR has dropped some elements not supported by react-native-svg: style */
And because of that, the svg is fully black when rendered.. I dont know what to say to my co-worker to fix this at his end (He uses Adobe XD), so the workaround I found is to manually add the fill prop with the needed color..
Is there a better solution?

If you enable the svgo option in svgr, then it simplifies away the style element, and resolves them into inline styles instead.

Also, https://jakearchibald.github.io/svgomg/ can be used for optimizing, or https://github.com/svg/svgo directly

If you enable the svgo option in svgr, then it simplifies away the style element, and resolves them into inline styles instead.

SVGO option at smooth-code converter didnt fully worked, it resolved a couple but not all of them.
I'm exploring https://jakearchibald.github.io/svgomg/ atm but at first glance the result is the same as SVGO option..
I havent tried https://github.com/svg/svgo yet, but I'll get back with a answer in a few hours.
Thanks for the reply @msand !

If you enable the svgo option in svgr, then it simplifies away the style element, and resolves them into inline styles instead.

SVGO option at smooth-code converter didnt fully worked, it resolved a couple but not all of them.
I'm exploring https://jakearchibald.github.io/svgomg/ atm but at first glance the result is the same as SVGO option..
I havent tried https://github.com/svg/svgo yet, but I'll get back with a answer in a few hours.
Thanks for the reply @msand !

Just tested https://github.com/svg/svgo. Same result as the others, didnt fully worked.

@LuizFBrisighello This would be a great opportunity to test if the pull request fixes this problem:

Clone https://github.com/iqqmuT/react-native-svg to TMPDIR and move there
Switch to develop branch: git checkout develop
Run npm install && npm run prepare
Move to your own project directory and install cloned react-native-svg:
npm install $(npm pack TMPDIR | tail -1)

You can restore original npm react-native-svg by npm install react-native-svg@9.11.1

There is support for the style element in SvgCss nowadays

@msand is SvgCss a package that can be imported into a react native project along with 'react-native-svg' ? I can't seem to find information on SvgCss

does anyone have any approach for XML files? I mean, what should we do if and style element is included in dynamic XMLs

@goff-studio convert the styles to inline styles. This fixed it for me

@myitelekt those are dynamic xmls that I receive from the backend. the solution was using SvgCss,

authors: LuizFBrisighello ajsaule goff-studio iqqmuT msand myitelekt

repo: react-native-svg/react-native-svg


text:
Update Android dependency to JitPack!

Updated Android-ScalableVideoView to use JitPack instead of JCenter as JCenter has been deprecated. https://www.jitpack.io/#thang2162/Android-ScalableVideoView
Thanks for opening a PR!
Since this is a volunteer project and is very active, anything you can do to reduce the amount of time needed to review and merge your PR is appreciated.
The following steps will help get your PR merged quickly:
Update the documentation
If you've added new functionality, update the README.md with an entry for your prop or event.
The entry should be inserted in alphabetical order.
Update the changelog
After you open the PR, update the CHANGELOG.md file with an entry pointing to your PR.
Provide an example of how to test the change
If the PR requires special testing setup provide all the relevant instructions and files. This may include a sample video file or URL, configuration, or setup steps.
Focus the PR on only one area
Testing multiple features takes longer than isolated changes and if there is a bug in one feature, prevents the other parts of your PR from getting merged until it gets fixed.
If you're touching multiple different areas that aren't related, break the changes up into multiple PRs.
Describe the changes
Add a note describing what your PR does. If there is a change to the behavior of the code, explain why it needs to be updated.

+1; can we get this merged?

Can you please merge this?

@thang2162 Yeah I was hoping that the comments would get maintainers' attention; this change would be a huge help

authors: samuelpbowman thang2162 vanGalilea

repo: react-native-video/react-native-video


text:
Fix transitionConfig types link

The link explaining TransitionConfig is broken, so I've updated it to point to the type definitions on the v1.9.4 tag. Since it's pointing to the tag instead of master it shouldn't break again. The transition config is gone in v5 so there's nothing to change in the original file.

For sure, yeah pointing to the branch would be better.


text:
🚀 8.0.0 milestones (collecting ideas)

[ ] making all hooks available with full docs (useSprings, useSpring, useTrail, useTransition, useChain)
[x] maybe making useSprings the base primitive internally for code re-use and leaner bundle size
[ ] decide on uniform api shapes, for instance useTransition(items, keys, props), useTrail(length, props), useSpring(length, props)
[x] useKeyframes is probably purposeless since custom hooks fulfil all its core values. Hooks can already be scripted, chained, canceled and awaited. Maybe some of the functionality (arrays, async scripting) could be made generic so that all primitives get use it instead of just transitions and keyframes (useSpring({ to: [{ opacity: 1 }, { color: 'red' }, { opacity: 0 }] })). or to: async next => {...}, though that's what the set method already does.
[ ] while we're at it, do we need to at all when using hooks, should it be a separate arg, separate from the config (delay, config, immediate, etc)
[x] slowly removing dependencies from class based primitives, making hooks the preferred api but allowing it at the same time to be as lean as possible without carrying around old bulk
[ ] turn animated/createAnimatedComponent.js into a function
[ ] deciding on a brand/icon

render props are safe of course and won't be affected by any of this.

You forgot about SSR feature, currently incompatible(partial support, only in hooks).

Here's a preview: http://react-spring-hooks.surge.sh
The beta is live under 8.0.0-beta.4

Wow, @drcmda. You have certainly been busy.
It's just hooks now, yes? Components are gone, true?

No component are all there, it's just import { Spring, ... } from 'react-spring/renderprops'

@drcmda What do you think moving project to typescript, you can gradually do it buy first editing hooks calls in typescript, its types anyways have to be rewritten

not without help. i don't use it or have never used it at least. but i wouldn't be opposed to it.

@drcmda Well, hooks are officially out.
As far as I have noticed b5 is super solid (too).
Anything major other than docs to get it released?:)

it's already published ... i just wait and see if we can get the new website running, if not i will announce later on this day. 😇

@drcmda  Quick q:  animating 'auto' is not supported?   Is there such a magic trick we could use to get "auto" height or should we deploy an extra hook to measure?

here's an example: https://twitter.com/0xca0a/status/1094683974679621633
there are two demos for auto: https://github.com/react-spring/react-spring-examples the new docs website will be published tomorrow hopefully
basically, hooks don't render, they don't know the view, so "auto" is gone. but doing it is easier than ever, and far more powerful. like the tree demo above, that's a worst-case nested auto scenario, that wouldn't have possible before.
there will be tons of hooks for this, react-measure or react-resize-aware are the ones i know.

That's fantastic.
I came up with something similar but, for a moment, felt an anti-pattern for me.
Thank you!

authors: drcmda fnpen jas99 phaistonian

repo: react-spring/react-spring


text:
Fix TS error about missing Omit type

i'm using typescript 3.4.5., where Omit is not included as part of TS,  and i get the following error when using this (awesome!!) lib:
 ../../node_modules/react-use-gesture/dist/hooks.d.ts:16:45 - error TS2304: Cannot find name 'Omit'.
[1] 16 declare type PartialGestureConfig = Partial<Omit<GestureConfig, 'passiveEvents'>>;

since this project already defined and exported a type helper for Omit, importing it should fix this.

@orouz Hey thanks for the PR! I'm just curious, since Omit is now part of Typescript 3.5 and that the typescript dependency of this package is 3.6 shouldn't Omit be removed at all? I don't know much about Typescript hence me asking!

Technically, yes. but it'll require some additional work, as specified here (see typesVersions)
the gist is to add a typesVersions property to package.json and tell it to use a different types file for different TS versions.
i can do the that if you prefer, but honestly i think just importing the Omit type helper would be best in this case.

Ok! Does that mean that we should also downgrade the typescript version in package.json?

importing the Omit helper should be sufficient. i don't think there's a need to change versions.

Ok! I’ll accept the PR and release 6.0.12 this afternoon GMT+1!

6.0.12 is now up and running! Thanks for your help on this :)

authors: dbismut orouz

repo: react-spring/react-use-gesture


text:
Async suggestions

Use case: tag suggestions based on (potentially thousands of) tags used elsewhere.
I'm going to fork and implement this, is a PR for this acceptable? Is this api good?
<ReactTags
  tags={tags}
  suggestions={this.state.loading ? this.state.suggestions : []}

  loading={this.state.loading}
  loadingMessage="Loading..."
  onIncompleteInput={(text) => undefined}
  />

If loading is truthy, display an additional item at the end of the suggestions with the loading class.
Additional classes:

ReactTags__tagInput--loading

use case: spinner on right side of input

ReactTags__suggestions--loading

use case: change background color, etc.

ReactTags__loading-indicator

use case: style the loadingMessage (could be an icon or whatever).

@brigand: Looks good and I'm definitely up for accepting the PR. Quick note about the API.. what does the onIncomepleteInput prop required for?

It gives you a place to start requests to the server.
onIncompleteInput={
  (text) => ajaxAutocomplete(text).then((suggestions) => this.setState({suggestions})
}

Right. Makes sense. :+1:

It seems like this type of request can be handled in the PR I created for #19 @brigand

Thanks @checkhavoc for your work on this! Closing this issue.

It gives you a place to start requests to the server.
onIncompleteInput={
  (text) => ajaxAutocomplete(text).then((suggestions) => this.setState({suggestions})
}

This should be in the documentatioin.

authors: brigand checkhavoc prakhar1989 yifeikong

repo: react-tags/react-tags


text:
Add helper text to input

Add ability to insert Helper text
https://material.io/guidelines/components/text-fields.html#text-fields-layout

@javivelasco Do we all need to modify our PRs merging current master so that travis stops failing to build? Or will you merge it as is?

repo: react-toolbox/react-toolbox


text:
[BUG] RoutingState wont run on UI thread in WPF

Describe the bug

I have service, which just reads from serial COM port employee card and command which I want to navigate automatically:
this.promagCardReaderService.CardScanned.SelectMany(cardId=> Login(cardId)).Subscribe();
this.promagCardReaderService.CardRemoved.SelectMany(_=>Logout()).Subscribe();

NavigateToLogin = ReactiveCommand.CreateFromObservable(() => NavigationService.Router.Navigate.Execute(LoginViewModel),outputScheduler: RxApp.MainThreadScheduler);

The login function is simple and looks like this:
private async Task<Unit> Login(string cardId)
        {
            using var repo = Locator.Current.GetService<IWmsRepository>();
            var employee = await repo.EmployeeRepository.GetEmployeeByCardNumber(cardId);

            if(employee is not null)
            {
                await employeeAuthenticationService.Login(employee);
                await NavigateToTerminal.Execute();
            }

            return Unit.Default;
        }

But in once I instert the card, subject gets triggered and code gets to there:
await NavigateToTerminal.Execute();
then it is running not on the UI thread 1, but something else 4,5 etc... seen in screenshot:

Steps To Reproduce
I cant give unfortunately access to this code base, but its just subjects and reactive command.
Expected behaviour

The navigation should occur on UI thread.
Screenshots

Environment

OS:       Windows
Version   19041.1288
ReactiveUI Version:    16.2.6

Additional context

The scheduler seems to be set to dispatcher...

You need the method you're calling inside the select many to be set to the UI thread. you can do something along the lines of
this.promagCardReaderService.CardScanned.ObserveOn(RxApp.MainThreadScheduler).Subscribe(async cardId => await Login(cardId));
this.promagCardReaderService.CardRemoved.ObserveOn(RxApp.MainThreadScheduler).Subscribe(async _ => await Logout());

May I ask for what purpose is the scheduler on ReactiveCommand for?

it's for the commands downstream UI\Observable event subscription chain. Execute() itself doesn't use it
https://www.reactiveui.net/docs/handbook/commands/#controlling-scheduling
It's important to understand that the execution logic for a reactive command is not scheduled to execute
on the provided scheduler (just as is the case for any canExecute observable you provide). Instead, it is left
to the caller to implement any required scheduling inside their execution pipeline. This means it is entirely
possible for your execution logic to execute on a thread other than that owned by the provided scheduler:

authors: dpvreony tomasfil

repo: reactiveui/ReactiveUI


text:
Setup WinRTAutoSuspendApplication to also be watching the app.Resuming for the IsUnPausing behavior on AutoSuspendHelper because of how Fast Resume works

As it stands now I can't get IsUnpausing to fire which I'm pretty sure is caused by the fact that the Fast Resume features of Win 8.1 means App.OnLaunched is never called because "resuming" in WinRT isn't really the same as :"Launching" ..  As I understand it a Suspended WinRT application stays in memory (with limited functionality) unless it's actually terminated and will usually just stay in memory for awhile unless memory pressures dictate otherwise...  The info on it (https://msdn.microsoft.com/en-us/library/windows/apps/hh464925.aspx) says it might just sit there in memory suspended for days
Hopefully that makes sense... The language in RxUI doesn't correlate to WinRT's names for things (not saying it should) but that might make what I'm saying confusing :-x
Here's my stab at the modification that seems to work when I tested it in the PlayGround projects
            var fastResuming = new Subject<ApplicationExecutionState>();
            app.Resuming += (o, e) => fastResuming.OnNext(ApplicationExecutionState.Suspended);
            var unpausing = new[] { ApplicationExecutionState.Suspended, ApplicationExecutionState.Running, };
            RxApp.SuspensionHost.IsUnpausing = _launched
                .Select(x=> x.PreviousExecutionState)
                .Merge(fastResuming)
                .Where(x => unpausing.Contains(x))
                .Select(_ => Unit.Default);

Suspended in WinRT still means you're entering a limited state of functionality (for example you can't get GPS location) so it's not like it's just same behavior but not visible it's still "suspended" so it's a good thing to be able to wire into....    Which is why I ran into this :-)  Because I need to suspend some GPS/network stuff going on if the user "suspends" the app and then start those things back up with the app enters the foreground

@PureWeen closing this off due to after/branch no longer exists. Sorry about the poor turn-around. Raise another PR if this is something that still needs addressing.

authors: PureWeen ghuntley


text:
Client Only Rendering

We are doing server side rendering
However fur our devs that is sooooo slock while compiles the bundle.
So, any way to do Client only rendering as parameter of @Html.React()?
That means server wont take time compiling the JSX, just send the autogenereated div with the model and when calling  @Html.ReactInitJavaScript() the component will be render.
I know that is not optimal but could be much faster during development.

There is a clientOnly flag, but that won't save you the initial JSX compiling. We use browserify (or webpack) to incremental JS compiling outside of React.NET which makes the development loop much quicker. It also gives us much more control over the process.

We also have webpack.
And we put that webpack compiled script into a bundle.
bundles.Add(new ScriptBundle("~/Bundles/React").Include("~/webpackBundle.js"));

I dont know if the slowness is causes by the bundle creation...

@jslatts We also have webpack.
And we put that webpack compiled script into a bundle.
bundles.Add(new ScriptBundle("~/Bundles/React").Include("~/webpackBundle.js"));

I dont know if the slowness is causes by the bundle creation...

@ricardopolo We don't use the asp.net bundles at all since we do our own minification using browserify. You can add your compiled code to react without transformation. This is our ReactConfig.cs:
ReactSiteConfiguration.Configuration.AddScriptWithoutTransform("~/wwwroot/js/server.bundle.js");
ReactSiteConfiguration.Configuration.AddScriptWithoutTransform("~/wwwroot/js/core.bundle.js");

// Don't use slower IE engine
ReactSiteConfiguration.Configuration.AllowMsieEngine = false;

// Don't use built in babel
ReactSiteConfiguration.Configuration.LoadBabel = false;

// Don't use built in react
ReactSiteConfiguration.Configuration.LoadReact = false;

We just reference the code directly in our master layout via a script tag:
<script src="@Url.Content("~/wwwroot/js/vendor.bundle.js")"></script>
<script src="@Url.Content("~/wwwroot/js/core.bundle.js")"></script>

Closing issues older than a year, please re-open if you think this is still relevant.

authors: dustinsoftware jslatts ricardopolo


text:
Bulgarian spell check for iOS

Just for the record: here is a Bulgarian spell checker https://discussions.apple.com/thread/7377363

This also works pretty good online so you don't have to install or integrate anything http://www.stars21.com/spelling/bulgarian_spell_checker.html

https://bg.linguee.com/български-английски


text:
Missing very important step in this documentation for JSX syntax

When I was trying to follow this documentation: https://reactjs.org/docs/add-react-to-a-website.html#optional-try-react-with-jsx
all worked fine until I replaced native JavaScript to JSX.
The missing step is to replace the line:
ReactDOM.render(e(LikeButton), domContainer);
with
ReactDOM.render(<LikeButton />, domContainer);

https://gist.githubusercontent.com/gaearon/0b180827c190fe4fd98b4c7f570ea4a8/raw/b9157ce933c79a4559d2aa9ff3372668cce48de7/LikeButton.js
The same result if you write some code like this, just without state:
React.createElement('button', { onClick: () => alert('The button was clicked') }, 'Click me')

authors: ahmadrasyidsalim amitshahc


text:
translate tutorial/nav.yml in Navigation

Thanks for the fixes.
But changes in jsx-in-depth.md file does not belong to here. You should create another branch for this task. Can you please revert the changes only in jsx-in-depth.md file?
Thanks

I didn't want to add jsx-in-depth.md to this pull request, sorry about that. Removed.


text:
Loosen dependency versions?

Since this is basically just a meta-package, any chance the dependency versions 0.4.* could be loosened to ^0.4 in composer.json?

During DPC @clue discussed this and in the long run we rather deprecate and abandon this package in the long run as we prefer user to target individual packages directly. Also 0.4.* is effectively the same as ^0.4 :wink: .

@WyriHaximus  Ok, that makes sense.  Thanks.  I will discontinue use of this meta-package.
Btw,
0.4.* matches versions >= 0.4.0 and < 0.5.0
^0.4 matches versions >= 0.4.0 and < 1.0

@siwinski No, as @WyriHaximus said, ^0.4 matches versions >= 0.4.0 and < 0.5.0. See https://getcomposer.org/doc/articles/versions.md#caret-version-range-

@jsor @WyriHaximus Oh, wow. I'm so sorry.  I have been treating that case wrong all this time :(  I apologize.

No need to be sorry, took me some time too until i learned that pre-1.0 versions are treated differently with ^. :)

authors: WyriHaximus jsor siwinski

repo: reactphp/react


text:
Add AccountingServer to keep track of (limit of) open connections

Add AccountingServer to limit number of open connections. This can be useful to limit how many resources are spent on handling connections vs. handling the requests that arrive on each connection (HTTP).
Builds on top of #84

Updated to work around a legacy PHP 5.3 issue due to old react/event-loop :shipit:

Out of curiosity: Is Accounting a common term for this? Because when i've read the notification of this PR, i've been very confused by the name ;)

Afaict "accounting" is not a common name for this feature and I'm open for suggestions :-) Afaict, this is not exactly a common feature in the first place, because this is often implemented as part of the underlying "server" instead of via decoration. Given our current design, I would vote to keep this via decoration (e.g. this allows us to limit the number of TLS connections), but I'm not opposed to renaming this feature :+1:
FWIW, the name "accounting" is related to "accountant" or "book keeping", which I think is good fit for this feature, because it does more than just "limiting".

FWIW, the name "accounting" is related to "accountant" or "book keeping", which I think is good fit for this feature, because it does more than just "limiting".

Yeah, i figured after seeing the code, but looked strange just from the name ;)
What about ConnectionControllingServer?

Alright, renamed AccountingServer to LimitingServer, as I think confusion with "managing accounts" is a valid concern :+1: :shipit:

authors: clue jsor

repo: reactphp/socket


text:
How to use ReadiumJS in a new Web Reader project?

I have read all the articles I can find about readium project, mainly from the ReadiumJS home page (https://readium.github.io/) and three github project page (readium-js-viewer, readium-js, readium-shared-js).
I followed the instructions on readium-viewer-js and have successfully made it runs on the local machine. Now I want to move to the next step -- build my own web eReader, that's where I cannot find enough information to go on.
I just want to build a web app just like Cloud-Reader-Lite provided as demo. But I don't know how to do it.
Specifically, I have two major problems.

It is hard to figure out how you guys write the cloud-reader-lite, the "src/cloud-reader-lite" folder (under readium-js-viewer)  only has an "index.html" file. All the js files are put in the "src/js" folder. Then you build all the js file into one bundle, and the "index.html" refers this all-in-one bundle js. It is really hard to mimic it. Can you give me some instruction about how to "read the learn" the cloud-reader-lite project?

If I decide to write one all from scratch, even without referencing the cloud-reader-lite demo, where should I start? If this is the case, should I start at the readium-js layer or readium-shared-js layer? I have found an instruction here (https://github.com/readium/readium-js/blob/master/API.md), is this the right place to start? Are there more instructions? Thanks.

Thank you very much.

Once your local clone of the readium-js-viewer repository is fully synchronized / up-to-date with the branch of your choice (master or develop, I recommend the latter), including the submodules readium-js, readium-shared-js and readium-cfi-js, you simply invoke the command line: npm run prepare followed by npm run dist+sourcemap. All the instruction are in the README:
https://github.com/readium/readium-js-viewer/blob/master/README.md#distribution
There is no documentation that explains how to replicate / create-your-own readium-js-viewer. My advice would be to study the code, hack the HTML / CSS, or even the Javascript source tree. This is a good way to get familiar with how the various Readium modules are assembled.
Alternatively, take a look at the readium-js "dev" setup, which demonstrates a minimal ReadiumJS boostrap:
https://github.com/readium/readium-js/blob/develop/dev/index.js
Le us know if this helps.

Thank you very much, sir.
It indeed helps.
^_^

repo: readium/readium-js-viewer


text:
[Bug] Issue with Vertical Mongolian EPUB Page Navigation in TestApp

Describe the bug
First, thank you for your contributions to the e-book ecosystem! I've encountered a small issue with Mongolian e-books while using TestApp and would appreciate your help.
While testing vertical Mongolian EPUB files, I noticed some interesting behavior:

The cover page and first page display perfectly ✨
However, from the second page onwards, there are some minor issues:

Cannot swipe right to turn pages
Can only scroll up/down to view content
Page counter remains stuck at "2/x"

How to reproduce?

Open TestApp
Load a vertical Mongolian EPUB file
Navigate past the first page
Attempt to swipe right to turn pages
Uploading test.epub.zip…

Readium version
3.0.0
OS version
18.1.1
Testing device
iPhone 15 Pro (emulator) and iPhone 15
Environment
No response
Additional context
No response

The book was not uploaded in your ticket. Could you share it again? Thanks.

Hello developer, after repeated testing, I understand that the current issue is not about staying on the second page. Instead, the problem is that when flipping pages, it goes by chapters. If it lands on the first page of a chapter, the remaining content in that chapter can only be viewed by scrolling up and down. Flipping the page again will take you to the next chapter. For example, if the first page is the cover page and the second page is the first page of chapter one, then flipping from the second page will take you to the first page of chapter two. I want to change this to the traditional page-flipping mode where it goes by content. What do I need to modify? Thank you for your help!

You need to wait for the book to be uploaded before submitting the comment.

Thank you for your patience and help. The upload failed due to network problems.
test.epub.zip

Hello, have you reproduced the problem I encountered? Is it a problem with my epub file?

authors: Huxiuqi mickael-menu

repo: readium/swift-toolkit


text:
Proof of Concept: Hide search matches

Unfortunately, the highlighting of search results has been removed in https://github.com/readthedocs/readthedocs.org/pull/6087.
I don't like this, and I think the real problem is that the RTD theme doesn't have a simple way to remove those highlights, like other Sphinx themes have, see #816.
This PR shows a really simple way to add this feature back to the theme.
Once we have this, we can revert the removal of the highlighting, see https://github.com/readthedocs/readthedocs.org/issues/6305.
I'm not interested in the styling (can somebody else please do that?), I just want to demonstrate a very simple way to get this functionality.
The relevant CSS selectors would probably be #searchbox .highlight-link for the
 and #searchbox a (or #searchbox p a?) for the link itself.
I think it makes sense to add the "Hide Search Matches" link close to the search text field, but if desired, it could be placed anywhere be simply adding a

. That's all there's to it.
Please note that this does not remove ?highlight=... from the URL. Such a feature, if desired, should be implemented in Sphinx itself.
What do y'all think about this?

Any reason to continue with this PR with search highlighting back on RTD?

Well yes. Highlighting is back (which is great!), but there is still no button or whatever to hide the current highlighting in the RTD theme, right?
But this PR is just a proof of concept, feel free to create a nicer styling.

I am not sure how up to date the current PR is, but I would be very interested in the highlighting being fixed indeed.
More specifically, it currently highlights the searched word in all subsequently visited pages.
As far as I'm concerned, I would prefer highlighting to be altogether disabled: I don't quite ever foresee a use case where I would want the technical term I looked for to find a session be bright yellow for its 30 or so occurrences in the text I'm gonna read.
But if people like it, I would at least appreciate a light way to disable it (ideally, hitting escape for instance) other than manually editing the URL to remove the option.
In particular, @cpitclaudel mentioned on Zulip that it could be easily disabled by editing the following CSS:
.rst-content .highlighted {
    background: #F1C40F;
    display: inline-block;
    font-weight: bold;
    padding: 0 6px;
}

I would like to support the pull request.
The feature is really missing as one can't easily (URL needs to be adjusted) hide the highlighted text.

Please note that this does not remove ?highlight=... from the URL. Such a feature, if desired, should be implemented in Sphinx itself.

I've just suggested such a change in https://github.com/sphinx-doc/sphinx/pull/9551.

I would also like to support this PR. The highlighting is extremely annoying for me.

@YaZko

But if people like it, I would at least appreciate a light way to disable it (ideally, hitting escape for instance)

In the meantime, this has been implemented in Sphinx: https://github.com/sphinx-doc/sphinx/pull/9337

authors: YaZko agjohnson ana-borges marxin mgeier


text:
Added some introductory text

added some introductory text to specific steps in Getting Started where previously these pages were blank

LGTM

authors: aglover zoready

repo: readysettech/docs


text:
Determine how best to manage code documentation

We should configure rubocop lints to enforce top-level documentation for classes and modules and documentation for public methods. We should also consider using a tool like yard.

We are using yard

repo: readysettech/readyset-rails


text:
Implement own version of binary kafka protocol

None of the current kafka protocol implementations is feature complete. To minimize dependencies on other libraries we could implement our own protocol. This should also enable #51

See https://github.com/real-digital/esque-wire

authors: hfjn swenzel

repo: real-digital/esque


text:
项目没发布到IIS根目录，加载不出来呢？

路径如： http://10.48.2.20/AEMS/logdashboard， AEMS不在Default Web Site, 而是是在Default Web Site/AEMS.

js,css路径不对，你要改一下。 https://github.com/realLiangshiwei/LogDashboard/issues/63

看你的请求路径，我也不知道你的项目什么情况

If I just use services.AddLogDashboard(), there're many 404;
then, when I added the pathmatch,
services.AddLogDashboard(opt =>
{
opt.PathMatch = "/AEMS";
});
Uncaught ReferenceError: value is not defined
at js.jquery.min.js:1
(anonymous) @ js.jquery.min.js:1
js.Chart.min.js:1 Uncaught ReferenceError: value is not defined
at js.Chart.min.js:1
(anonymous) @ js.Chart.min.js:1
js.bootstrap.min.js:1 Uncaught ReferenceError: value is not defined
at js.bootstrap.min.js:1
(anonymous) @ js.bootstrap.min.js:1
js.moment.min.js:1 Uncaught ReferenceError: value is not defined
at js.moment.min.js:1
(anonymous) @ js.moment.min.js:1
js.tempusdominus-bootstrap-4.js:1 Uncaught ReferenceError: value is not defined
at js.tempusdominus-bootstrap-4.js:1
(anonymous) @ js.tempusdominus-bootstrap-4.js:1
js.spin.min.js:1 Uncaught ReferenceError: value is not defined
at js.spin.min.js:1
(anonymous) @ js.spin.min.js:1
js.log.js:1 Uncaught ReferenceError: value is not defined
at js.log.js:1
(anonymous) @ js.log.js:1
js.home.js:1 Uncaught ReferenceError: value is not defined
at js.home.js:1
(anonymous) @ js.home.js:1
logdashboard:192 Uncaught ReferenceError: logInfo is not defined
at HTMLAnchorElement.onclick (logdashboard:192)

For example: http://10.48.2.20/AEMS/logdashboard
  opt.PathMatch = "AEMS/logdashboard";

It is working properly, thanks!
opt.PathMatch = "/AEMS/logdashboard";

repo: realLiangshiwei/LogDashboard


text:
Crash when querying...

Goals
What do you want to achieve?
Query and remove Realm objects whose "_expires" field is in the past.
Expected Results
Query returns an array of Realm objects to delete.
Actual Results
The app crashes, with the following details in the debugging console:

Traceback (most recent call last):
File "/Users/darrenehlers/Library/Application Support/Realm/rlm_lldb.py", line 210, in RLMResults_SummaryProvider
return 'Unevaluated query on ' + class_name
TypeError: cannot concatenate 'str' and 'NoneType' objects

Steps to Reproduce
What are steps we can follow to reproduce this issue?
Code Sample
{
    NSPredicate*                predicate       = [NSPredicate predicateWithFormat:@"_expires < %@", [NSDate date]];
    RLMResults<DAORealmBeer*>*  expiredItems    = [DAORealmBeer objectsWithPredicate:predicate];

    [RLMRealm.defaultRealm transactionWithBlock:
     ^()
     {
         [RLMRealm.defaultRealm deleteObjects:expiredItems];
     }];
}

Version of Realm and Tooling
In the CONTRIBUTING guidelines, you will find a script,
which will help determining these versions.
Realm version: 0.98.7
Xcode version: 7.3.1
iOS/OSX version: 9.3.2
Dependency manager + version: /usr/local/bin/pod  0.39.0

Hi @ehlersd! Sorry to hear you've been experiencing a crash.
Before we proceed, there's a few things I'd like to ask first:

You're running on Ream 0.98.7, which is quite old at this point, and we've shipped a lot of bug fixes since then. Is there a reason why you haven't updated your copy of Realm?
Can you please post the model definition for your DAORealmBeer object?
Are you performing any checks to see if expiredItems actually contains any objects (i.e. expiredItems.count > 0) before starting a Realm transaction?

Please let me know these things as soon as you can! Thanks!

@TimOliver No, I guess I just haven't updated my pods recently.  I will update them and retry.
Also, no, I don't check for expiredItems.count > 0.  I can easily do that, but is it required that the array contain at least 1 item?

This looks like #3579, which was fixed in #3603 and included in 0.103.0. @ehlersd could you please update to Realm 1.0 and let us know if you're still seeing this?

I'm running Realm 1.0 and have the exact same issue. On each of the following lines, I get that error.
Code:
NSString *predicateString = [NSString stringWithFormat:@"facebook_token = '%@'", token];
RLMResults<User *> *users = [User objectsWhere:predicateString];

Error:
Traceback (most recent call last):
  File "/Users/bond/Library/Application Support/Realm/rlm_lldb.py", line 210, in RLMResults_SummaryProvider
    return 'Unevaluated query on ' + class_name
TypeError: cannot concatenate 'str' and 'NoneType' objects

I am having the exact same issue as well.
Code:
`    NSPredicate *pred = [NSPredicate predicateWithFormat:@"batteryTypeId='%@'", batteryId];
RLMResults<RMScreening *> *screenings=[RMScreening objectsWithPredicate:pred];
Error:
2016-06-01 10:29:38.912 DANA[65351:1133949] Main View Appeared Traceback (most recent call last):   File "/Users/Steve/Library/Application Support/Realm/rlm_lldb.py", line 210, in RLMResults_SummaryProvider     return 'Unevaluated query on ' + class_name TypeError: cannot concatenate 'str' and 'NoneType' objects (lldb)

@jpsim Updating seems to have resolved the error I was seeing.  I will address it again if it reappears.

@SteveTrombley @shanemileham you're both seeing #3655, which was discovered in this thread but is otherwise unrelated to this issue.

authors: SteveTrombley TimOliver ehlersd jpsim shanemileham

repo: realm/realm-cocoa


text:
Realm Results aren't updated if there's a NotificationToken observing the Results

In trying to replicate #6709 I'm running into what might be a related issue. This code should work, right?
Expected Results
Realm Results is up-to-date after adding new object
Actual Results
Realm Results is not updated after adding a new object when observing for changes via NotificationToken
Steps for others to Reproduce

Open provided project RealmTest.zip
Run pod install
Run the app
Result: App crashes due to trying to access just added object in Results

Code Sample
class ViewController: UIViewController {

    private var markers: Results<SongMarker>?
    private var markersChangeTableUpdateNotificationToken: NotificationToken?

    override func viewDidLoad() {
        super.viewDidLoad()

        let jsonString = "[{\"organizationShows\":[{\"id\":\"7f5cdcfa-5ff6-11ea-9e98-22000b74e21e\",\"songs\":[{\"id\":\"91a01616-6d1b-11ea-ae0e-22000b74e21e\"},{\"id\":\"09d141c8-5ff7-11ea-8c8f-22000b74e21e\"}]}],\"id\":\"00000000-5ab5-1de9-f4d1-b6b91ed1b036\"}]"
        let jsonData = jsonString.data(using: .utf8)!
        let jsonObject = try! JSONSerialization.jsonObject(with: jsonData, options: []) as! [[String: Any]]

        DataModel.shared.importFromJSON(jsonObject)

        let song = DataModel.shared.realm!.object(ofType: Song.self, forPrimaryKey: "91a01616-6d1b-11ea-ae0e-22000b74e21e")!

        markers = DataModel.shared.realm?.objects(SongMarker.self).filter("ANY songs.id = %@", song.id).sorted(by: [SortDescriptor(keyPath: "time"), SortDescriptor(keyPath: "createdAt", ascending: false)])

        //commenting these out fixes it
        markersChangeTableUpdateNotificationToken?.invalidate()
        markersChangeTableUpdateNotificationToken = markers?.observe { changes in
        }

        markers?.realm?.beginWrite()

        let marker = SongMarker()
        song.markers.insert(marker, at: 0)

        print(markers?[0])
    }

}

Version of Realm and Tooling
Realm framework version: 5.3.5
Realm Object Server version: ?
Xcode version: 11.6
iOS/OSX version: iOS 13.6
Dependency manager + version: CocoaPods 1.9.3

It looks like the specific circumstances that are broken are:

It must be the first access of the Results
There must be a notifier, and the initial run of the async query needs to have completed
The access must be inside a write transaction following a change which should have invalidated the async query results.

Should be easy to fix.

Should this be resolved in version 5.4.0? I continue to see this crash.

I forgot to actually bump the submodule pointer to pull it in. It'll be in the next release.

authors: hipwelljo tgoyne


text:
Listen to changes

I've tried to look for a way to listen to realm changes so that data can be synced to an api or another external database (MySQL or postgres, firebase)
I wasn't able to find anything except syncing to mongodb online offering. Am I missing something?
Thank you

Hi @orangeswim,
We don't provide syncing to external data sources. But we support changes notifications. You can see the documentation. Is this the thing that you need?

authors: desistefanova orangeswim

repo: realm/realm-dart


text:
helm: make reana-auth component images configurable

Current behaviour
The reana-auth-* component images have hard-coded values, for example in the maint-0.9 branch:
$ rg KRB5_CONTAINER_IMAGE reana_commons/config.py
• reana_commons/config.py
461:KRB5_CONTAINER_IMAGE = os.getenv(
462:    "KRB5_CONTAINER_IMAGE", "docker.io/reanahub/reana-auth-krb5:1.0.1"
$ rg _CONTAINER_IMAGE reana_job_controller/config.py
• reana_job_controller/config.py
74:VOMSPROXY_CONTAINER_IMAGE = os.getenv(
75:    "VOMSPROXY_CONTAINER_IMAGE", "docker.io/reanahub/reana-auth-vomsproxy:1.3.0"
90:RUCIO_CONTAINER_IMAGE = os.getenv(
91:    "RUCIO_CONTAINER_IMAGE", "docker.io/reanahub/reana-auth-rucio:1.1.1"

We are upgrading default values in the code from time to time, and create new REANA component images with the new values, which is somewhat tedious.
Expected behaviour
It should be possible to pass environment variables (or specify fully-qualified image names) via Helm charts in order to use desired reana-auth components on a REANA installation.
For example, this would allow to use CERN Harbor registry instead of Docker Hub for these images just by modifying the Helm values file.

Following up #781 this is already possible. Here is an example of the Helm values file that would use reana-auth-krb5 image from CERN Harbor registry:
diff --git a/helm/configurations/values-dev.yaml b/helm/configurations/values-dev.yaml
index 9526e06..2df9891 100644
--- a/helm/configurations/values-dev.yaml
+++ b/helm/configurations/values-dev.yaml
@@ -14,14 +14,24 @@ components:
       REANA_RUNTIME_KUBERNETES_KEEP_ALIVE_JOBS_WITH_STATUSES: failed
   reana_workflow_engine_cwl:
     image: docker.io/reanahub/reana-workflow-engine-cwl
+    environment:
+      KRB5_CONTAINER_IMAGE: "registry.cern.ch/reanahub/reana-auth-krb5:1.0.3"
   reana_workflow_engine_yadage:
     image: docker.io/reanahub/reana-workflow-engine-yadage
+    environment:
+      KRB5_CONTAINER_IMAGE: "registry.cern.ch/reanahub/reana-auth-krb5:1.0.3"
   reana_workflow_engine_serial:
     image: docker.io/reanahub/reana-workflow-engine-serial
+    environment:
+      KRB5_CONTAINER_IMAGE: "registry.cern.ch/reanahub/reana-auth-krb5:1.0.3"
   reana_workflow_engine_snakemake:
     image: docker.io/reanahub/reana-workflow-engine-snakemake
+    environment:
+      KRB5_CONTAINER_IMAGE: "registry.cern.ch/reanahub/reana-auth-krb5:1.0.3"
   reana_job_controller:
     image: docker.io/reanahub/reana-job-controller
+    environment:
+      KRB5_CONTAINER_IMAGE: "registry.cern.ch/reanahub/reana-auth-krb5:1.0.3"
   reana_message_broker:
     image: docker.io/reanahub/reana-message-broker
   reana_ui:

repo: reanahub/reana


text:
Add isSame function with granularity

Hello,
I need some granularity for the isSame method so I created the missing bindings.
Also it looks like I have a refmt issue

Hey @DCKT,
Your changes look good to me!

Hello @Jimexist I think so

Hello there,
Any news about this PR ? 😄

Hey @DCKT,
Your changes look good to me!

Hey @DCKT,
Your changes look good to me!

authors: DCKT TravisBuddy

repo: reasonml-community/bs-moment


text:
Delegate method doesn't called

Hello! Thank you so much for Parchment.
Have some problem:
func pagingViewController(_ pagingViewController: PagingViewController,
widthForPagingItem pagingItem: T, isSelected: Bool) -> CGFloat?
Doesn't called for me.

Hey, have you set these:

@LinusGeffarth yes, sure

Hi @voytov1ch! Which version of Parchment are you using? It seems to work just fine here.

Met the same problem @rechsteiner  version Using Parchment (1.3.0)
`    let pagingViewController = PagingViewController()
override func viewDidLoad() {
super.viewDidLoad()
addChildViewController(pagingViewController)
pagingViewController.dataSource = self
pagingViewController.delegate = self
view.addSubview(pagingViewController.view)
pagingViewController.didMove(toParentViewController: self)
pagingViewController.textColor = .warmGrey
pagingViewController.options.indicatorColor = .strawberry
pagingViewController.options.selectedTextColor = .black51
pagingViewController.options.selectedFont = UIFont.robotoRegular(fontSize: 14)
pagingViewController.options.font = UIFont.robotoRegular(fontSize: 14)
pagingViewController.options.menuItemSize = .sizeToFit(minWidth: 70, height: 38)
pagingViewController.options.borderColor = .clear
pagingViewController.indicatorOptions = .visible(height: 3, zIndex: 0, spacing: UIEdgeInsets.init(top: 0, left: 0, bottom: 0, right: 0), insets: UIEdgeInsets.init(top: 0, left: 5, bottom: 0, right: 5))
}
func pagingViewController(_ pagingViewController: PagingViewController, widthForPagingItem pagingItem: T, isSelected: Bool) -> CGFloat? {
guard let item = pagingItem as? PagingIndexItem else { return 0 }
let insets = UIEdgeInsets(top: 0, left: 20, bottom: 0, right: 20)
let size = CGSize(width: CGFloat.greatestFiniteMagnitude, height: pagingViewController.menuItemSize.height)
let attributes = [NSAttributedStringKey.font: pagingViewController.font]
let rect = item.title.boundingRect(with: size,
options: .usesLineFragmentOrigin,
attributes: attributes,
context: nil)
let width = ceil(rect.width) + insets.left + insets.right
if isSelected {
return width * 1.5
} else {
return width
}
}
`

@funlabuz thanks for the report! Managed to reproduce it now. Will get a fix out shortly 👍

Pushed a fix for this now #244 ✌
@voytov1ch @funlabuz could you target the master branch and verify that this actually fixes the issue for you as well?

authors: LinusGeffarth funlabuz rechsteiner voytov1ch

repo: rechsteiner/Parchment


text:
Source maps

Looks like the Vite build (or, rather, the manual renaming afterwards) breaks connection between the minified JS and the source map build.

If it helps, it looks like it starts at version 2.4.2 - 2.4.1 loads just fine.

Thanks, yes. I changed the build tool between these versions. Already have an idea how to fix it. Will be ok again in the next release.

Fixed in commit cf94545ebdf4ffc6d4ee35c5a8ed9493f1054589

authors: darkmich rsimon

repo: recogito/annotorious


text:
Announcement LF

Description

A new hope

Imagine the music ...
Related Issues

References

Checklist:

[ ] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.
[ ] This PR is being made to staging branch and not to main branch.

can we actually put the Luke's photo in our main page? I love this hahaha

authors: loomlike miguelgfierro

repo: recommenders-team/recommenders


text:
Fix the count

This should fix https://github.com/rectorphp/getrector.org/issues/186
However, I didn't test it at all because I was not sure how
I also changed the fallback count to 600? The real count is 625 right now if my regex is correct

Looks good, thanks!

Thanks to this issues I've finally added category support to @symplify - https://github.com/symplify/symplify/pull/2547
Now should be restored to almost original format:
https://github.com/rectorphp/rector/pull/4688

authors: TomasVotruba orklah


text:
Add error identifiers

Situation
I'm in a situation where I want to enable some/all checks this extension provides in general, but ignore specific cases.
Right now I can only use the old approach of either ignoring by regex via config or baseline, or add generic "ignore anything here" @phpstan-ignore-line/@phpstan-ignore-next-line comments.
What I want is to explicitly ignore a certain rule in specific places (see use case below).
For that I'd need support of error identifiers (e.g. type_perfect.narrow_return), cf.:
https://phpstan.org/blog/phpstan-1-11-errors-identifiers-phpstan-pro-reboot
Use Case
I have a class that has properties with mutable types (interfaces containing methods that allow object mutation).
On the same class I have methods that return these properties but use immutable return types (interfaces that do not advertise methods capable of object mutation). These cases are correctly detected by narrow_return but I want to ignore these specific cases.

Thanks for the suggestions. It looks good to me :+1: Could you send PR?

Could you send a PR?

I probably could but it's really not that hard given that you already require PHPStan ^1.11 (so error identifiers support is there and you don't need to support older versions that don't have it).
It's as simple as calling identifier('X') in the right places, cf.
https://phpstan.org/error-identifiers (includes links to PHPStan sources).

authors: InvisibleSmiley TomasVotruba

repo: rectorphp/type-perfect


text:
feat: Update Sonarr French Recyclarr templates

Anime (MULTi & VOSTFR)
Web 1080p (MULTi & VOSTFR)
Web 2160p (MULTi & VOSTFR)
Created Includes for all FR profiles
Updated the templates with latest changes

[Upcoming]

Will do another PR later this week with the Radarr ones

@yammes08, you should have permission to merge the PR if you want. Use the "Squash and merge" setting. This will let you type out the commit message exactly as you want it to appear. If you'd rather me do it, let me know. Also if you don't have permission to merge, also let me know and I'll fix that for you.

@yammes08, you should have permission to merge the PR if you want. Use the "Squash and merge" setting. This will let you type out the commit message exactly as you want it to appear. If you'd rather me do it, let me know. Also if you don't have permission to merge, also let me know and I'll fix that for you.

All good, I've done this previously - I wanted to give @NiceTSY a chance to review the commit message but I just tweaked what was there instead.

Thanks, @yammes08, did not know that, will keep it in mind for next time!

authors: NiceTSY rcdailey yammes08

repo: recyclarr/config-templates


text:
Added New York city's Taxi and Limousine Commission green taxi trip support

Related Issue

https://github.com/red-data-tools/red-datasets-parquet/issues/1

What I did

added New York city's taxi and limousine commission green taxi trip support
added simple unit test

Details

Green Trips Data Dictionary

There is no explanation about ehail_fee and congestion_surcharge in this dictionary.

ehail_fee: https://www1.nyc.gov/site/tlc/businesses/e-hail-providers.page
congestion_surcharge: https://www1.nyc.gov/site/tlc/about/congestion-surcharge.page

ref: https://www1.nyc.gov/site/tlc/about/tlc-trip-record-data.page

What I Didn't

added following datasets related with NYC Taxi and Limousine Commission

FHV Trips Data
High Volume FHV Trips Data

What I checked

ran tlc-green-taxi-trip example

% ruby example/tlc-green-taxi-trip.rb
[:veri_fone_inc, 2022-01-01 09:14:21 +0900, 2022-01-01 09:15:33 +0900, false, :standard_rate, 42, 42, 1.0, 0.44, 3.5, 0.5, 0.5, 0.0, 0.0, nil, 0.3, 4.8, :cash, :street_hail, 0.0]
[:creative_mobile_technologies, 2022-01-01 09:20:55 +0900, 2022-01-01 09:29:38 +0900, false, :standard_rate, 116, 41, 1.0, 2.1, 9.5, 0.5, 0.5, 0.0, 0.0, nil, 0.3, 10.8, :cash, :street_hail, 0.0]

Thank you for reviewing this PR. I dealt with all of them your comments so far🙏

Thank you for reviewing this PR. I dealt with all of them your comments so far🙏

Thanks!

authors: kou otegami

repo: red-data-tools/red-datasets-parquet


text:
Revert "fix(mm-monitoring): revert the code logic but set to disable as delete"

Reverts red-hat-data-services/rhods-operator#151

@danielezonca @VaishnaviHire if we want to go this way: keep old mm monitoring resource in the cluster, then we can merge this "revert" PR

repo: red-hat-data-services/rhods-operator


text:
nfs: add support for clients in the StorageClass

The clients parameter in the storage class is used to limit access to the export to the set of hostnames, networks or ip addresses specified.
/cc spuiuk
/assign Madhu-1

/lgtm

repo: red-hat-storage/ceph-csi


text:
Invoke-ExecuteCommand: Issue with backslashes being escaped

The backslash at the end of the find command that contain -exec is incorrectly being escaped.
For example, the command for atomic-test T1552.004-3 is find #{search_path} -name id_rsa -exec cp --parents {} #{output_folder} \;.   After it is escaped the command becomes find / -name id_rsa -exec cp --parents {} /tmp/art-staging \\;.  An extra backslash is added causing the following error when executed find: missing argument to -exec.
Found this escaping scheme is causing issues for other tests, T1552.004-4 and T1217
Updating the command to remove the backslash escaping does resolve the errors with the find commands
From:
$finalCommand = $finalCommand -replace "[\\`"]", "`\$&"

To:
$finalCommand = $finalCommand -replace "[`"]", "`\$&"

It looks like that fix was proposed in PR #24 but later was enhanced to the current code submitted in PR #33
Saw that the escape logic was removed from the command_prompt executor block.  Attempted to remove the line from the bash/sh logic bloc, but it broke atomic-test T1083-4

Thank you for the PR to fix!

repo: redcanaryco/invoke-atomicredteam


text:
Appstudio update test-component-pac-cqhp

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-cqhp-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
13 seconds
clone-repository

✅ Succeeded
30 seconds
sast-snyk-check

✅ Succeeded
1 minute
build-container

✅ Succeeded
8 seconds
deprecated-base-image-check

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
8 seconds
inspect-image

✅ Succeeded
41 seconds
clamav-scan

✅ Succeeded
6 seconds
sbom-json-check

✅ Succeeded
5 seconds
show-sbom

✅ Succeeded
6 seconds
show-summary

Pipelines as Code CI/test-component-pac-cqhp-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
4 seconds
init

✅ Succeeded
18 seconds
clone-repository

✅ Succeeded
7 seconds
sast-snyk-check

✅ Succeeded
22 seconds
build-container

✅ Succeeded
1 minute
clair-scan

✅ Succeeded
36 seconds
clamav-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
31 seconds
inspect-image

✅ Succeeded
8 seconds
deprecated-base-image-check

✅ Succeeded
7 seconds
show-summary

✅ Succeeded
8 seconds
show-sbom


text:
Appstudio update test-component-pac-swph

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-swph-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
25 seconds
build-container

✅ Succeeded
17 seconds
deprecated-base-image-check

✅ Succeeded
18 seconds
inspect-image

✅ Succeeded
38 seconds
clamav-scan

✅ Succeeded
10 seconds
clair-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
17 seconds
label-check

✅ Succeeded
17 seconds
optional-label-check

✅ Succeeded
6 seconds
show-summary

Pipelines as Code CI/test-component-pac-swph-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
4 seconds
init

✅ Succeeded
12 seconds
clone-repository

✅ Succeeded
32 seconds
build-container

✅ Succeeded
33 seconds
clamav-scan

✅ Succeeded
13 seconds
deprecated-base-image-check

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
13 seconds
inspect-image

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
9 seconds
label-check

✅ Succeeded
9 seconds
optional-label-check

✅ Succeeded
5 seconds
show-summary


text:
Appstudio update test-component-pac-xepm

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-xepm-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
10 seconds
init

✅ Succeeded
30 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
18 seconds
inspect-image

✅ Succeeded
19 seconds
deprecated-base-image-check

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
33 seconds
sbom-json-check

✅ Succeeded
15 seconds
label-check

✅ Succeeded
15 seconds
optional-label-check

✅ Succeeded
9 seconds
show-sbom

✅ Succeeded
9 seconds
show-summary

Pipelines as Code CI/test-component-pac-xepm-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
9 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
5 minutes
build-container

✅ Succeeded
10 seconds
deprecated-base-image-check

✅ Succeeded
12 seconds
inspect-image

✅ Succeeded
13 seconds
clair-scan

✅ Succeeded
39 seconds
clamav-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
24 seconds
optional-label-check

✅ Succeeded
24 seconds
label-check

✅ Succeeded
5 seconds
show-sbom

✅ Succeeded
6 seconds
show-summary

Pipelines as Code CI/test-component-pac-xepm-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
9 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
5 minutes
build-container

✅ Succeeded
10 seconds
deprecated-base-image-check

✅ Succeeded
12 seconds
inspect-image

✅ Succeeded
39 seconds
clamav-scan

✅ Succeeded
13 seconds
clair-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
24 seconds
optional-label-check

✅ Succeeded
24 seconds
label-check

✅ Succeeded
5 seconds
show-sbom

✅ Succeeded
6 seconds
show-summary


text:
fix(STONEINTG-401): remove check for integration bundle

Bundles are deprecated and are replaced by resolvers

Description
Remove the check for bundle to unlock migration to Tekton resolvers.
Issue ticket number and link
STONEINTG-401
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

/lgtm

/test redhat-appstudio-e2e

authors: dirgim flacatus


text:
ci: Enable konflux build

What type of PR is this?
/kind ci
What does this PR do / why we need it:
Enables CI build on konflux. The PR job builds on amd only and the PUSH job builds on all supported arch i.e amd64, arm64, ppc64le & s390x.

The image build is successful on Konflux
$ docker run -it --rm --entrypoint /bin/bash quay.io/redhat-user-workloads/rh-openshift-gitops-tenant/gitops-must-gather:on-pr-9f06669e7b22b1d187489e066fcb4c29b116a88c-linux-x86-64
WARNING: image platform (linux/amd64) does not match the expected platform (linux/arm64)
[root@685cec0225f5 /]# cat /usr/bin/gather
#!/usr/bin/env bash

set -eu -o pipefail

LOGS_DIR="/must-gather"

mkdir -p ${LOGS_DIR}

GITOPS_CURRENT_CSV=$(oc get subscription.operators.coreos.com --ignore-not-found -A -o json | jq '.items[] | select(.metadata.name=="openshift-gitops-operator") | .status.currentCSV' -r)

The PR is ready for review. Will fix the failing static check job in another PR.

LGTM

authors: anandrkskd svghadi

repo: redhat-developer/gitops-must-gather


text:
[wip] Separate layers - Application

What type of PR is this?
/kind cleanup
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #?
PR acceptance criteria:

[ ] Unit test

[ ] Integration test

[ ] Documentation

[ ] I have read the test guidelines

How to test changes / Special notes to the reviewer:

Kubernetes Tests finished with errors.
View logs: TXT HTML

OpenShift Tests finished with errors.
View logs: TXT HTML

Kubernetes Tests finished with errors.
View logs: TXT HTML

Unit Tests finished successfully.
View logs: TXT HTML

OpenShift Tests finished with errors.
View logs: TXT HTML

Unit Tests finished successfully.
View logs: TXT HTML

Kubernetes Tests finished successfully.
View logs: TXT HTML

Unit Tests finished successfully.
View logs: TXT HTML

OpenShift Tests finished successfully.
View logs: TXT HTML

Kubernetes Tests finished successfully.
View logs: TXT HTML

Unit Tests finished successfully.
View logs: TXT HTML

OpenShift Tests finished successfully.
View logs: TXT HTML

Kubernetes Tests finished successfully.
View logs: TXT HTML

Unit Tests finished successfully.
View logs: TXT HTML

OpenShift Tests finished successfully.
View logs: TXT HTML

Kubernetes Tests finished successfully.
View logs: TXT HTML

OpenShift Tests finished successfully.
View logs: TXT HTML

Unit Tests finished successfully.
View logs: TXT HTML

Kubernetes Tests finished successfully.
View logs: TXT HTML

Unit Tests finished successfully.
View logs: TXT HTML

OpenShift Tests finished successfully.
View logs: TXT HTML

Kubernetes Tests finished successfully.
View logs: TXT HTML

Unit Tests finished successfully.
View logs: TXT HTML

OpenShift Tests finished successfully.
View logs: TXT HTML

Moved to https://github.com/redhat-developer/odo/pull/5293

repo: redhat-developer/odo