text:
Update multiwallet to fix BB bugs

Coverage remained the same at 33.694% when pulling ca3d6f466c7aebcc42837c2805d4e55cc1caf7a5 on TS_blockbook into 42402909abe37b2214f5b25dab3eb5746198821c on blockbook_test.

This looks like it was included in https://github.com/OpenBazaar/multiwallet/pull/34 and https://github.com/OpenBazaar/golang-socketio/pull/1. I will come back to this after I update vendor packages to see if there's still a diff.

These changes were included into master via another merge. Closing as redundant.

authors: coveralls placer14 tyler-smith


text:
Adicionar possibilidade de alunos avaliarem as cadeiras de acordo com sua dificuldade

É uma boa ideia e levaremos à discussão futuramente 😄

source: gharchive/issue

authors: felipesqra tarsojabbes

repo: OpenDevUFCG/Tamburetei

license: MIT

license_type: permissive

license_source: github-api


text:
这个压缩效率怎么样呀

试试不就知道了吗，都是在原生压缩的

太差了，压出来的小尺寸比大尺寸原图的体积还大一倍

authors: JarvanMo WhiteCjy ghostgzt


text:
fix assignment calculations

The main doubts are: 'if the config for the percent base changes, should the displayed percentages in a poll change, too'?

order fixed
votes cast/ valid should now correctly  influence the percents again

ping @emanuelschuetze

next round of fixes done @emanuelschuetze

assignment abstains now don't show percentages on 'YES/NO' based polls @emanuelschuetze

source: gharchive/pull-request

repo: OpenSlides/OpenSlides


text:
Improving error handling in before_test.cmd

Codecov Report

Merging #417 into dev will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #417      +/-   ##
==========================================
+ Coverage   69.35%   69.36%   +0.01%
==========================================
  Files          22       22
  Lines        9767     9767
==========================================
+ Hits         6774     6775       +1
+ Misses       2993     2992       -1

Impacted Files
Coverage Δ

src/smatrix.c
98.81% <0%> (+0.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ba8d93...b86b150. Read the comment docs.

authors: codecov-io michaeltryby

repo: OpenWaterAnalytics/EPANET


text:
Add stable spinnaker chart to helm repo

@Nirmalyasen going ahead and merging this. Moved the spinnaker chart source to spinnaker-helm repo

repo: OpsMx/enterprise-spinnaker


text:
Fixes #6189 : TextAreaElement throwing on null ProcessedValue

Does it only applies to TextArea?

Other elements affected by the PR (Checkbox, Email, URL, Hidden and Text) are not concerned by this issue as ProcessedValue is applied to an attribute. It doesn't matter if it's null.
TextArea element is the only one using tagBuilder.SetInnerText(string innerText)

authors: TFleury sebastienros

repo: OrchardCMS/Orchard

license_source: bigquery


text:
docs: add tips to save time and resource

#143


text:
[WIP] flighttask static method to check if data is available

With the current Flighttask architecture it is possible to enter a state where the commander demands to switch to a task (for instance Auto), but the FlightTaskAuto has not received a valid triplet. If that happens, FlightTaskAuto will return 0 and the task not run. Unfortunately, this also means that the old FlightTask from which a switch was demanded, is lost as well due to FlightTask union.
It would be beneficial to be able to check for the required data of a specific task before instantiating that particular task. One possible solution could be to add a static method to each task which can be called before the task is actually instantiated. I quickly laid out this approach in this PR, but I am not very happy in term of implementation.

@bkueng any reason why it would be a bad idea to make _subscription_array static?

What about adding a 2nd slot (TaskUnion) for the next task, and not fully switch until it's active and happy?
If there's a failure it should be reported (position controller status) so that commander can enter a proper failsafe state.
I'm still thinking about different ways we could tie this all together coherently in a modular fashion.

In the AUTO example you mentioned are you expecting the position setpoint triplet to continue to be invalid in any case?
Here we can do a better job with a separate mission status coming from navigator. Navigator mission can still check this while inactive and with feedback the state machine can block the transition to mission in the first place.

What about adding a 2nd slot (TaskUnion) for the next task, and not fully switch until it's active and happy?

That would require to have a second instance. This is possible and definitely an option, but I would prefer to find a better solution.

If there's a failure it should be reported (position controller status) so that commander can enter a proper failsafe state.

Not in this case, otherwise it would never enter Auto. It is not a failsafe case. The issue that I am describing is cause by having different threads running at different frequencies.
Simple example:

commander wants to go into Auto
navigator and mc_pos_control switch into Auto
mc_pos_control requires triplets from the navigator, but there is no guarantee that these triplets have already been updated by the time when mc_pos_control wants to execute Auto.

In the AUTO example you mentioned are you expecting the position setpoint triplet to continue to be invalid in any case?

No. The triplet will be valid after a few loops.

Here we can do a better job with a separate mission status coming from navigator. Navigator mission can still check this while inactive and with feedback the state machine can block the transition to mission in the first place.

In this particular case that could work, it does not solve the general handling of consuming data from different threads.

Seems like a second TaskUnion is the best solution for now, and then keep switching between them.

Seems like a second TaskUnion is the best solution for now, and then keep switching between them.

And why that? I don't see why that is the case, since we haven't searched for alternatives yet. Let's step back for a second.
Right now I don't look for an immediate solution, because it already works with the current state. In addition, failsafe feedback to the commander is already implemented if switching does not work: https://github.com/PX4/Firmware/blob/master/src/modules/mc_pos_control/mc_pos_control_main.cpp#L1101-L1150
I will try to write down the pros and cons of the two approaches that we have right now, but I actually was hoping to gather first a couple more solutions before evaluating the pros and cons.
Second union
Advantage

easy to implement
does not require any changes in mc_pos_control and only small changes in FlightTasks

Disadvantage

increases size of Flighttasks. In fact, there will be almost two "position-controllers" active at the same time, which is just a waste of memory.
most likely it will not fit into older platforms such as fmu-v2
in the future it is desired to have Fixedwing and Vtol to use FlightTasks as well. With a second union we would have 6 position controller active at the same time.

Static method
Advantage

enables for checking. It can also be used by other modules to just check if a flighttask can be run or not
will not increase memory usage

Disadvantage

with current approach, requires another method that needs to be generated
checking for data might require duplicate code:  in the static method and once during the update-method after FlightTask got instantiated.

What about having the FlightTask (eg FlightTaskAuto) activate immediately, but do something safe and continuous in the interim until all the necessary data is available (updated valid position setpoint triplet)? The local position validity checks you're doing are redundant and could be dropped. Again, if the data doesn't become available in some generous period the MPC should publish a failure status (not a mode change) to commander, which would then activate the failsafe.
Then we need to take a look at all of these cases overall and lock it down (state machine) so that potentially invalid transitions are prevented in the first place (eliminating the need to fallback to the previous FlightTask as much as possible).

In addition, failsafe feedback to the commander is already implemented if switching does not work: https://github.com/PX4/Firmware/blob/master/src/modules/mc_pos_control/mc_pos_control_main.cpp#L1101-L1150

This is actually kind of problematic. If you change a mode like that it could be difficult or even impossible to discern from a mode change that came in from mavlink or rc. Regardless of the outcome of this discussion let's create an issue to change this.

It's a different side to the same problem. You either try to handle the dependencies upfront and not use the task until everything is ready, or handle it within the task itself. Not ideal either way.
In some cases I could see handling it explicitly in the new task being better than continuing with whatever setpoints you already had.
Currently a TaskUnion is 760 bytes of memory. Having a second instance isn't great, but we can handle that even on fmu-v2. The problem we kept hitting on px4fmu-v2 (and will hit again soon) is limited flash (code space). Generating code can end up using more flash than you might expect.

What about having the FlightTask (eg FlightTaskAuto) activate immediately, but do something safe and continuous in the interim until all the necessary data is available (updated valid position setpoint triplet)?

I also don't think that this is a good idea, because then every Flighttask needs to have such a logic. I still think it is better to have an implementation that allows for checking first (let's assume it is done with a second union), and then if it fails, we need to define what should happen.
In the legacy code, if the triplets were not valid but auto was requested, then all the velocity setpoints were just set to 0. However, that was actually never really defined officially nor discussed what the desired behavior should be, but rather was added because it was not handled at all. Now we have the chance to define it once and for all.
There are several options:

stay in the current task
just set velocity to 0
exit current task and go into failsafe task in which loiter, zero velocity or even land is executed depending on what estimation states are available

In all three options feedback can be sent back to the commander. The commander then needs to decide if he wants to continue to request a specific mode or not. This decision, however, is not something very simple to make. While the commander receives the feedback, the mc_pos_control would execute one of the options above (or something else).
I also want to emphasize that the last option does not overwrite the commander nor does it replace the commander state-machine. It just handles that case similar to the legacy code where the setpoints were set to 0.

What about having the FlightTask (eg FlightTaskAuto) activate immediately, but do something safe and continuous in the interim until all the necessary data is available (updated valid position setpoint triplet)?

I also don't think that this is a good idea, because then every Flighttask needs to have such a logic. I still think it is better to have an implementation that allows for checking first (let's assume it is done with a second union), and then if it fails, we need to define what should happen.

I agree, I was just trying to brainstorm possible alternatives that wouldn't require an additional slot.
Having the current active FlightTask fully available while constructing the next could be useful. For example you could initialize the relevant setpoints based on what the previous was actually doing.

authors: Stifael bkueng dagar


text:
local predictor and RPC batch interface unified

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: wangjiawei04:x: rootroot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

repo: PaddlePaddle/Serving


text:
项目里面怎么加入骨架屏页面

这和本项目有什么关系么？

切换路由的时候右边页面还没出来时候会有空白，提前占位感觉会用户体验好些

后台加 Skeleton其实蛮奇怪的，还不如加loadingl。

好的，谢了哈

authors: PanJiaChen zhoutaiping

repo: PanJiaChen/vue-element-admin


text:
update download link to latest version (1.5.1.0)

I made a fork at automatically parses and builds with the very latest downloadlink found on the android-studio website :) https://github.com/mfonville/android-studio ; builds @ https://launchpad.net/~maarten-fonville/+archive/ubuntu/android-studio

@mfonville That's really nice :) Can we merge the 2 projects?

@PaoloRotolo of course :-) if that is possible in some way
I did attach my server to daily run the configure script and check for updates and it automatically pushes new builds to my PPA. I am not sure how we could redirect or copy these builds for users of your existing users in an automatic way though. But for sure you could at those moments a stable-build is released copy it from my PPA to yours.

Okay, I'll update my website as well writing that beta and canary builds are available on your PPA.

@PaoloRotolo thanks! :-)

@mfonville I am not familiar with the packaging system; how does APT knows that there is an update when it apt-get upgrade? Does @PaoloRotolo need to manually push the updates to his PPA (so that end user see them)? If so, your script of fetching the latest version should not be in the PPA, but instead a separate cron job on your computer (or maybe some server).

@franklinyu yes, @PaoloRotolo could indeed also run the script himself and push to his PPA :-)
but I have indeed a cronjob set-up on my server, so at that the moment the binaries should already be available in the PPA and availble to be copied, which is very probably faster and less effort for him.

authors: PaoloRotolo franklinyu ldez mfonville

repo: PaoloRotolo/android-studio


text:
Code | Numeric Pattern 7

Issue has been resolved in the PR! Thank You!

repo: PatternHouse/Python-PatternHouse


text:
Test env var

Test name
Status

api-tests
passed

Test name
Status

api-tests
passed

authors: JNKPercona hors

repo: Percona-Lab/percona-version-service


text:
Update dependencies

Coverage remained the same at 91.563% when pulling 25d726df38724b839b5a00d682a1271216aef52b on rel_branch into 0b2ace8bad963f8ae6a68d46e369dc9696bb73f4 on master.

authors: alexpenev-s coveralls

repo: Peripli/service-broker-proxy-cf


text:
Add deeply nested relations context fix

Coverage increased (+0.004%) to 90.384% when pulling 2abcf3982e214005ac8df4e9556fb3d8666cb6bb on SampsonCrowley:master into 648aab53a65ab7868f9f88f1f543e79247490180 on PhilWaldmann:master.

Coverage remained the same at 90.38% when pulling 540ca9ad546d79f5c89e5c9b7c5870bef6ed7a04 on SampsonCrowley:master into 648aab53a65ab7868f9f88f1f543e79247490180 on PhilWaldmann:master.

authors: SampsonCrowley coveralls

repo: PhilWaldmann/openrecord

license: mit


text:
Add $contact_infos.details

@kenlog Thank you for your contribution. :hugs:
Could you explain in an issue your initial bug for this PR (or may be link to an issue) ?
Could you give us a scenario which permits to test the bug before and after this PR ?
Thanks :+1:

@Progi1984 I would add an issue but they are disabled. However this addition gives the possibility to show in the front-end.

@kenlog Create it on the main repository : https://github.com/PrestaShop/PrestaShop/issues/new/choose Thanks !

Okay I'll do it there


text:
Add CC-BY image and ISSN to footer (#424)

Codecov Report

Merging #426 (201497c) into develop (9ef6137) will increase coverage by 0.98%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop      #426      +/-   ##
============================================
+ Coverage    99.01%   100.00%   +0.98%
============================================
  Files          114         5     -109
  Lines         5779        77    -5702
  Branches         6         6
============================================
- Hits          5722        77    -5645
+ Misses          57         0      -57

authors: codecov-commenter thatbudakguy

repo: Princeton-CDH/ppa-django


text:
Fix/03 14 fixes

Got a second round of fixes for you @Koded

repo: PublicHealthEngland/talktofrank-beta


text:
V0.1 (Presented to first focus group on 20th May)

@kerzmaximilian we need to first merge this PR https://github.com/RADAR-CNS/RADAR-Questionnaire/pull/50 and update this branch, so that we can lint and test this code.

@kerzmaximilian please fix the problems shown in Travis.

authors: herkulano kerzmaximilian

repo: RADAR-CNS/RADAR-Questionnaire


text:
增加简洁易用的led控制包

ci访问不了码云的吗

repo: RT-Thread/packages


text:
Swift 3.0 Compatibility

@robcadwallader I updated this for Swift 3 in Xcode 8b6, and changed the PR to point to develop instead of master (GitHub just added that feature today).

@robcadwallader ah, it looks like the definition of the ~ is going to need a little massaging, but I don't know how to use the new precedence groups.

Is there an ETA for Swift 3 compatibility?

Hey @DavdRoman -- it's my high priority list, I'm hoping we'll get some commits up by Monday.  Sorry for the delay!

In the meantime, you can point your project at the top commit of the Swift 3 branch, and that should work. I say top commit, and not the branch itself, because if the branch is merged and deleted, your reference may break (depending on what dependency manager you're using).

authors: DavdRoman KingOfBrian ZevEisenberg robcadwallader

repo: Raizlabs/Anchorage


text:
Adds infoPlist strings for instabug permissions

addresses #67

repo: Raizlabs/ios-template


text:
Add Jamie McDade to Contributors list

The tutorial was great and it was very useful in making my transition into the large world of OSS 👍

I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh

repo: Roshanjossey/first-contributions


text:
Add matrop to Contributors list

Hi  @matrop, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

authors: Roshanjossey matrop


text:
Datenbank Schema

`LOCATIONS
ID   = INTEGER
NAME = STRING
LAT  = DOUBLE
LON   = DOUBLE
OCCUPANCY_ESTIMATIONS
ID          = INTEGER AUTO_INCREMENT
LOCATION_ID = INTEGER
CREATOR     = STRING
TIMESTAMP   = TIMESTAMP
OCCUPANCY   = DOUBLE
`

CREATE DATABASE postgres
WITH
OWNER = postgres
ENCODING = 'UTF8'
LC_COLLATE = 'en_US.utf8'
LC_CTYPE = 'en_US.utf8'
TABLESPACE = pg_default
CONNECTION LIMIT = -1;

CREATE TABLE public.locations
(
id bigint NOT NULL,
name text NOT NULL,
lat double precision NOT NULL,
lon double precision NOT NULL,
PRIMARY KEY (id)
);
ALTER TABLE public.locations
OWNER to postgres;

repo: SAKPaaS/backend


text:
Updated screenshot in Document Classification tutorial

Closing pull request as there is now another change I'd like to push

repo: SAPDocuments/Tutorials


text:
Make an interface for both 2D and 3D in one place.

done here: 621c311f170203457249a13fe78ac695d5d04f79


text:
test

:white_check_mark: Build SMT 0.1.176 completed (commit https://github.com/SMTorg/SMT/commit/b98fb09ae0 by @bouhlelma)

authors: AppVeyorBot bouhlelma

repo: SMTorg/smt


text:
Fixing 1763

operator new(size_t) is useless because when calling new thread_data lookup doesn't go to outmost namespaces and overload resolution says no, no overload

The "won't be called" stuff that actually "might be called" makes me uneasy. If those certainly won't be called, and given that's a requirement for the program to be well-formed, why not enforcing that requirement by the design?

@K-ballo ugh, the first point is absolutely correct, thanks.
In what scenarios that operator new(size_t) "might be called"? What do you suggest? I personally don't like those run-time assertions and would rather prefer having it deleted to cause link-time error.

@AntonBikineev can we close this now?

@hkaiser think so

authors: AntonBikineev K-ballo hkaiser

repo: STEllAR-GROUP/hpx


text:
Format JSON to syslog and enable GelfToStringFormatter for syslog authentication channel

:bell: @DRvanR

bar CI: :+1:

authors: DRvanR rjkip

repo: SURFnet/Stepup-Gateway


text:
Review rpm and firstboot configurations

LGTM

authors: flavio jordimassaguerpla

repo: SUSE/Portus


text:
Checking box next to repository name without being puzzled by whitespace

+1

authors: Bischoff MalloZup

repo: SUSE/spacewalk-testsuite-base


text:
chore: cut release

:tada: This PR is included in version 1.1.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

repo: Seavenly/paypal-messaging-components


text:
UI

the company logo at the bottom is struck through by a line and it does not look good

the main menu and the colour stripe of active menu occupies approximately half the height of the page, so it leaves not too much space for the content

the main menu and/or the open menu stripe could be frozen, so you could have the navigation in your reach every time and know the context of the content

authors: herflis iviczl


text:
Removed writing to vars we never read

This pull request fixes 1 alert when merging fe7cb1700048ee30adf8f7ea1a41ddf1ad5b8762 into 62c5b7474cd609577e3fcf34893470256b58cf80 - view on LGTM.com
fixed alerts:

1 for Unused or undefined state property

Comment posted by LGTM.com

repo: ServiceInnovationLab/FSD


text:
Add keyword in SRL for JavaScript to add g flag

#3

repo: SimpleRegex/SRL-JavaScript


text:
Add main to resume

Add main to index.html

repo: SmallNinjaKiller/homepage


text:
Adding branching support to code coverage

Coverage decreased (-3.9%) to 77.63% when pulling 5f9fd7a782047e392ec146bfe27e74f48291164b on feature/branchcoverage into ef40e9ab8109f19396aff6d3c4dd7eece7c10536 on master.

authors: coveralls rpeach-sag

repo: SoftwareAG/apama-lambdas


text:
Would be nice to be able to generate all/multiple tables at once.

You can do
schemats generate -c postgres://conn_url_here -t table_1 -t table_2 -t table_n -n SameNameSpace -o out.ts

I also believe this would be helpful. I think we could add an argument -s or --schema where if you provide it, we'd take all tables in this schema. I think schema is granular enough, I think all tables in database is too much because of information_schema and pg_catalog which we probably don't want.

I think we could add an argument -s or --schema where if you provide it, we'd take all tables in this schema.

Yes, good suggestion, and also very easy to implement

I think this issue can be close, it works now (there's a pending PR to update the readme).

authors: abenhamdine geon xiamx zigomir

repo: SweetIQ/schemats


text:
People update

Updated. Thanks Allen


text:
TSPOON

ไม่มีคำอธิบายให้

H

repo: T-Spoon/Android-Developer-Toolbelt


text:
Read Config_environment system property to select config files (Fixes #39)

Coverage increased (+0.3%) to 90.785% when pulling 3dec596cdfd320b73b0e6ea44d2566a99fea74be on feature/env_property into 1d0cdf099ecd0d52f2b318de62e08f6ea6300dc6 on master.

authors: coveralls rgonalo

repo: Telefonica/toolium


text: Drone Drive


text:
#27 - Fixed NullReference exception when access null Map and FormsMap

I will had the fix manually as this references the master branch.

@TorbenK I had to add some more null references you should take across :)

(Which branch should I use so you don't have to do this manually?)

Development

Added manually. Thank you very much, you are added as contributor on the readme

authors: CliffCawley TorbenK


text:
fix: Focus inconsistency fixed

[BOT] Preview available: https://embed.typeform.com/a0fe3b552070d96286fa0d2a3b5ff51f0462e1ca/embed.js

@prilutskiy does this work have a related ticket?

[BOT] Preview available: https://embed.typeform.com/ee3e1de31a04dd01a418394499a80a20fa8f13ce/embed.js

[BOT] Preview available: https://embed.typeform.com/b930a5b25531a7e5debfad34e5dcaca27c548cdb/embed.js

:tada: This PR is included in version 0.24.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

authors: mathio prilutskiy travis-tf

repo: Typeform/embed


text:
updated link for coverage to ubc

Pull Request Test Coverage Report for Build 12

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 11:
0.0%

Covered Lines:
84

Relevant Lines:
84

💛  - Coveralls

authors: coveralls tarinib

repo: UBC-MDS/InstaR


text:
Crear documentacion con gitbook

Enlace al libro

:+1: :ok:

authors: Losnen crguezl

repo: ULL-ESIT-GRADOII-TFG/classroom


text:
add readData.RDS

awesome!

Coverage remained the same at 0.0% when pulling c758841bb69550273dbc0d39750c5a0b78c1558c on lindsaycarr:master into c73f645b298aa0fccf6aa9c4d1ceecb7d2a78f92 on USGS-VIZLAB:master.

authors: aappling-usgs coveralls lindsaycarr

repo: USGS-VIZLAB/vizlab


text:
Readme update

No need to test

repo: UrsusPilot/firmware


text:
First version of the German translation Files

ups, should have checked this first https://github.com/VividWeb/vivid_store/pull/77

authors: LennDa Remo


text:
Add an inspection that reports properties being set to their default value

These providers had errors when I ran the schema extractor but I ignored them as out of scope:

terraform-provider-azure-classic
terraform-provider-google-beta
terraform-provider-oci
terraform-provider-scaffolding

And there were 4 new providers which I also ignored:

bigip
netlify
rightscale
tencentcloud

Thank you for contribution.
First, could you please sign JetBrains CLA
About PR itself I see there're some useless parts of shema being generated.
        "Default": {
          "Type": "string"
        }

Apart from that I'd like to have separate commit for code and shema update (or even no schema update since it's hard to navigate through PR diff and I'd anyway regenerate them just before releasing next version)

I've addressed all the PR comments.
The useless schema like below is because of json:",omitempty",  I've put in a kludge to work around it.
"Default": {
  "Type": "string"
}

repo: VladRassokhin/intellij-hcl


text:
Bump dependencies

@ChezzPlaya @BenjaminSieg I have merged both of your changes in this PR.
Please let me know if it looks alright. I haven't touched WPF stuff in ages.

Looks good to me!

Should be good, yes!
Thanks!

Should be good, yes!
Thanks!

Thank you! We'll start with a pre-release version to see if it works as intended.

Thank you! We'll start with a pre-release version to see if it works as intended.

authors: BenjaminSieg ChezzPlaya edongashi


text:
add interface to get finished transaction ids

Codecov Report

Merging #104 into release-rc4 will decrease coverage by 0.02%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##             release-rc4     #104      +/-   ##
=================================================
- Coverage          32.23%   32.20%   -0.03%
  Complexity           361      361
=================================================
  Files                 54       54
  Lines               4514     4518       +4
  Branches             376      377       +1
=================================================
  Hits                1455     1455
- Misses              2951     2955       +4
  Partials             108      108

Impacted Files
Coverage Δ
Complexity Δ

.../java/com/webank/wecross/stub/bcos/BCOSDriver.java
22.56% <0.00%> (-0.03%)
34.00% <0.00%> (ø%)

.../webank/wecross/stub/bcos/proxy/ProxyContract.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

...bcos/performance/hellowecross/PerformanceTest.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

...erformance/hellowecross/proxy/PerformanceTest.java
0.00% <0.00%> (ø)
0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e429e6a...ed62fea. Read the comment docs.

authors: Shareong codecov-commenter


text:
XT 使用中遇到的问题

this.bgImageView.image = require('../assets/fitness_bg@2x.png')
代码中使用 require 会报错：[ts] 找不到名称“require”。

xt.d.ts 中本身包含了这个 declare
暂时没发现是什么问题，暂时先在对应的文件中加入
declare var require: (path: string) => any;
即可正常使用。

https://github.com/XTStudio/XT/commit/5f9b8f0bb91069f991ad7555f38502bb1b34c3e1
Fixed.

authors: PonyCui errnull

repo: XTStudio/XT


text:
Understand the code and make some minor adjustments

对于Git的使用，建议一个commit尽可能的干一件事。

authors: YahuiAn xiefeifeigithub

repo: YahuiAn/BJUTservice


text:
changes in readme file

lgtm, Thanks Mukul!

authors: YashIndane kavinjeveriya

repo: YashIndane/pyculas


text:
Resolve compiler warnings

Thanks!

authors: paulofaria sundeepgupta

repo: Zewo/Zewo


text:
bug：长按录制视频，然后取消，再录制，重复几次后，发现视频播放不了，经查发现视频没有生成。

我写的逻辑是每次点取消之后, 之前录制的视频就会消失, 然后重新录制, 如果你最后一次是点的取消, 那么没有视频就是对的, 如果是最后一此拍完没有视频播出, 有可能是中间删除的时候出现问题了, 但我试了几次都没有问题

你好，我这里测试是你录制一段视频后，然后点击左边的按钮退到视频拍摄界面，这时点击back键退出，再次进入，然后录制，之后到达预览界面，这时会发生鬼畜...请楼主测试一下试试

我已经更新代码逻辑，增加了挺多功能 其中有分段拍摄， 你可以再试一下

仍然会鬼畜..

我也有这个问题

第一次录制正常，退出录制界面，再重新进去录制只能录制不到一秒的时间，不知道为什么！

authors: Pr-Jiang SunShaoNing Zhaoss lixxxiang zhangxi28

repo: Zhaoss/WeiXinRecordedDemo


text:
Use project.pluginManager instead of project.plugins whenever possible

Fixed with https://github.com/aalmiray/kordamp-gradle-plugins/commit/0fc9c5b559adedd5d83561f606b0b834181a5aee

repo: aalmiray/kordamp-gradle-plugins


text:
Look into/fix mythical high eye shape for USDC

Fixed this in https://github.com/aavegotchi/aavegotchi-contracts/commit/774c8ae0a15fd467b1a4aa30da5e2489f42b9486.

Fixed this in https://github.com/aavegotchi/aavegotchi-contracts/commit/774c8ae0a15fd467b1a4aa30da5e2489f42b9486.

authors: cinnabarhorse mudgen

repo: aavegotchi/aavegotchi-contracts


text:
Remove "vault_password_file" configuration from ansible.cfg

Resolved by #8

authors: dvaccarosenna sglover


text:
map function comparable to arduino's map()

Could we call this something besides _map so that it sounds different than the map builtin when spoken? How about map_range or rerange?

map_range 👍

authors: asherlie ladyada tannewt


text:
Ctrl + Left

@HodofHod  Could you provide more description of what the issue actually is.

I apologize, I started writing an issue, then deleted it. Somehow, this still got submitted.
Sorry 'bout that :(

No worries!

authors: HodofHod nethip

repo: adobe/brackets


text:
Removing deprecated refs to flask.ext.*

Coverage remained the same at 81.856% when pulling cc390eddc67e4753797be3dfd99490477317e5ce on mistercrunch:flask_ext into 89f9efd3a3de9316d5163ccc68d74d8802b90406 on airbnb:master.

authors: coveralls mistercrunch

repo: airbnb/caravel


text:
Add queue depth JMX stats

looks good

authors: dain martint

repo: airlift/airlift


text:
Use something better than webrick if available

Closing, marked project as inactive

repo: akerl/onetimedownload


text:
Fix Matchbox link

Thanks for the fix!

authors: JayAndCatchFire dhamaniasad

repo: aleksandar-todorovic/awesome-linux

license: WTFPL


text:
Add link to docs

Thanks @SaeX :sparkles:

authors: SaeX frewsxcv

repo: alex/django-taggit


text:
Fix/issue 95

Changes Unknown when pulling 5f36ee516765a2ee3d7496edef9b6263893e3775 on fix/issue-95 into ** on develop**.

authors: coveralls rayrutjes


text:
IDEA 插件：注解没有提示 “注释缺少@author信息”

麻烦提供下截图

Annotation

Class

@kerie 看一下。

大佬们这是什么情况

@openshell 类上添加
/**
 * @author <作者>
 * @since <版本>
 */

@openshell 类上添加
/**
 * @author <作者>
 * @since <版本>
 */

谢谢啦 ，我知道为啥了 是因为我第一排注释星号中间多了个空格。

authors: 1346735074 openshell pexcn xuantan


text: Feat/proposal card voting ui 27

repo: alicedapp/AliceX


text:
Fix typo

Thank you.

authors: aliostad eugene-g

repo: aliostad/PerfIt


text:
credential release ts

Codecov Report

Merging #287 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #287   +/-   ##
=========================================
  Coverage     96.75%   96.75%
  Complexity       21       21
=========================================
  Files             3        3
  Lines           154      154
  Branches          3        3
=========================================
  Hits            149      149
  Misses            4        4
  Partials          1        1

Flag
Coverage Δ
Complexity Δ

#go
96.93% <ø> (ø)
0.00 <ø> (ø)

#java
96.42% <ø> (ø)
21.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8652b1c...baecba6. Read the comment docs.

authors: codecov-commenter yuanyaoqi

repo: aliyun/aliyun-ccp


text:
travis: add 1.x instead 1.9 to go versions

Coverage remained the same at 98.915% when pulling e12aed4388c23beb3c76ed027f6d9374778890ff on dvrkps:patch-1 into ae221b5af13a74b99104683424f403934ba0afb3 on allegro:master.

@dvrkps Thanks!

authors: coveralls dvrkps janisz

repo: allegro/bigcache


text:
bump tf version to latest

Can we do the Ruby version to 2.6 as well?

in a separate PR, but yes

We forgot .travis.yml.


text:
Create client premade components

Create client components from react app installation and modify models

also add service worker

complete

repo: amiedawn/taco-shop


text:
Implementing Feedback After The First Checkpoint Defence

Coverage decreased (-2.04%) to 97.959% when pulling 29ca913f887d360367230995084063f5a8e8c71e on develop into 59970300e151aca6eacbeb3e53e8c7997ebc1f0b on old-state.

Coverage decreased (-2.04%) to 97.959% when pulling 29ca913f887d360367230995084063f5a8e8c71e on develop into 59970300e151aca6eacbeb3e53e8c7997ebc1f0b on old-state.

@andela-anwosu your Angular code base is also riddled with console.logs, alerts and // commented out code.
Rethink and refactor accordingly.

Coverage decreased (-2.2%) to 97.826% when pulling 4ba066f716c3da056e41e99da39c2456c9d481a3 on develop into 59970300e151aca6eacbeb3e53e8c7997ebc1f0b on old-state.

Coverage decreased (-100.0%) to 0.0% when pulling 4ba066f716c3da056e41e99da39c2456c9d481a3 on develop into 59970300e151aca6eacbeb3e53e8c7997ebc1f0b on old-state.

Coverage decreased (-100.0%) to 0.0% when pulling 4ba066f716c3da056e41e99da39c2456c9d481a3 on develop into 59970300e151aca6eacbeb3e53e8c7997ebc1f0b on old-state.

Coverage decreased (-2.08%) to 97.917% when pulling db5f5a449e5a97189b3bbbf7dafe3a1aeb87f81d on develop into 59970300e151aca6eacbeb3e53e8c7997ebc1f0b on old-state.

Coverage decreased (-2.08%) to 97.917% when pulling db5f5a449e5a97189b3bbbf7dafe3a1aeb87f81d on develop into 59970300e151aca6eacbeb3e53e8c7997ebc1f0b on old-state.

Coverage decreased (-2.08%) to 97.917% when pulling 9d6e7f94b34d1c45af91a2c7be2be64f1e8ada5d on develop into 59970300e151aca6eacbeb3e53e8c7997ebc1f0b on old-state.

Coverage decreased (-2.08%) to 97.917% when pulling 33e7c1ade4581fb25ce69ff85c3a1909725b8bcf on develop into 59970300e151aca6eacbeb3e53e8c7997ebc1f0b on old-state.


text:
Omit invalid props and version bumps

Can you break this into 2 prs.

GitHub's Pull Requests are designed to be per-branch. I cannot open 2 separate prs. If you want I can send one and after merge send the other one.

You can create another branch, rebase out one of the commits. It's doable.

Ive just published fix for this issue, so gonna close this.

authors: Andarist hosmelq jdalton

repo: andreypopp/react-textarea-autosize


text:
Extract sbt-dependency-mngr sub-project, add tests

cc @maasg

repo: andypetrella/spark-notebook


text:
Can you add support for Angular2?

README states:

Early adopters of Angular2 can use the  ng2 branch.

Are you facing issues with it?
I haven't yet done a release since I'm hesitant about using the same npm package with just a version increase or using a new repo like ui2-sortable.
Waiting for your feedback.

@Ajeey Did the ng2 branch work for you?
Any feedback?

@thgreasi Will be trying out this weekend and update you. Thanks

Any feedback on this?
Thodoris Greasidis

Closing this for now, feel free to re-open if necessary.

authors: Ajeey thgreasi

repo: angular-ui/ui-sortable


text:
Type checker replacements

Converting circular structure to JSON
    at JSON.stringify (<anonymous>)
    at new Server (/tmp/angular-cli-e2e-11892-90-1lxtz35.zgki/test-project/node_modules/karma/lib/server.js:65:41)
    at Observable.rxjs_1.Observable.obs [as _subscribe] (/tmp/angular-cli-e2e-11892-90-1lxtz35.zgki/test-project/node_modules/@angular-devkit/build-angular/src/karma/packages/angular_devkit/build_angular/src/karma/index.ts:102:29)

Looks like you shouldn't pass the logger to karma.

@alan-agius4 I think it's not the logger since karma doesn't import it directly, but rather the circular dependency between the type checker and compiler plugin introduced by the new message. I'll refactor the messages into a separate file.

@alan-agius4 ran some debugging on the circular object reported by Karma and indeed it's the logger property inside the AngularCompilerPlugin instance.
@clydin that's probably the best approach, yeah. Unsure of the limitation on Node's child process IPC channel used here for logging (https://nodejs.org/api/child_process.html). I think it's very likely that the main thread is blocked transferring large files. Doing that properly is essentially a virtual FS server, something that I discussed with @hansl in the past. Not transferring unchanged files is very important in that scenario too.

repo: angular/angular-cli


text:
Add Tailwind CSS IntelliSense

Nice work on the plugin @bradlc!

authors: bradlc joshmanders

repo: aniftyco/awesome-tailwindcss


text:
Just blank when i call class="spinner"? how to use that

@kevinaltaf have you tried adding the theme.spinner to your tailwind config?

@kevariable if you apply theme.spinner.default.color (like in the readme) it works.
They way its set up is weird thought.. .spinner has color: transparent !important set, and .spinner:after has its color come from currentColor. So it always pulls transparent and never the actual text color.. 🤷♂

authors: HugoDF hroland kevariable

repo: aniftyco/tailwindcss-spinner


text:
Create License

Done

repo: anjandebnath/ArchitectureComponent


text:
Add CTRL-w to delete words.

I was about to add this feature request also. Cheers

repo: antirez/linenoise


text:
ARTEMIS-900 fix compatibility after address changes

I will merge this myself after extensive testing... we can fix anything on master later

repo: apache/activemq-artemis


text:
guard against possible NPE when rebinding legacy catalog items

LGTM; merging.

authors: ahgittin aledsage

repo: apache/brooklyn-server


text:
Fix javadoc

Coverage remained the same at 94.927% when pulling 8ed330b6e85f9fc4a88a071c6d12a7a08c91e8e5 on arturobernalg:fixjavadoc into acd7283f1931644acad1f739325e2ec2024729a6 on apache:master.

authors: arturobernalg coveralls

repo: apache/commons-lang


text:
[hotfix] Add logging for RocksDB backup durations

+1 to merge

authors: aljoscha rmetzger

repo: apache/flink


text:
Sharding rule lambda modify.

Pull Request Test Coverage Report for Build 10643

15 of 18 (83.33%)  changed or added relevant lines in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 57.764%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/ShardingRule.java
15
18
83.33%

Files with Coverage Reduction
New Missed Lines
%

sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java
3
76.0%

Totals

Change from base Build 1189:
-0.05%

Covered Lines:
11826

Relevant Lines:
20473

💛  - Coveralls

repo: apache/incubator-shardingsphere


text:
move the example help pages relating to specific modules into those modules

lgtm +1

authors: smarthi steveblackmon

repo: apache/incubator-streams


text:
[TUBEMQ-29] Change the package name to "org.apache.tubemq."

Seems it is a huge change, I would suggest merging once CI passed. @gosonzhang what do you think?

I'm adding more test cases, need wait some time and then merge them.
A large-scale change is inevitable if we need change the package name.

authors: chenjunjiedada gosonzhang

repo: apache/incubator-tubemq


text:
KAFKA-4035: AclCommand should allow Describe operation on groups

@omkreddy is this backward compatible. What happens to the clients that are on older versions are they going to get any auth exceptions

@harshach AFAIK There are no compatibility issues. Current AclCommand does't support to add Describe operation on Group Resource. This is a valid combination and we are already handling this combination.
https://github.com/omkreddy/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaApis.scala#L854

@omkreddy : Thanks for the patch. LGTM. Could you rebase?

@junrao rebased the PR.

+1

Thanks @omkreddy  merged into trunk

authors: harshach junrao omkreddy

repo: apache/kafka


text:
NUTCH-2399: Fix indexer-elastic-rest for multivalue fields

+1

Any chance for this fix to be considered in the next release?

authors: kaidul thilohaas

repo: apache/nutch


text:
Update UI.

Coverage increased (+0.002%) to 16.825% when pulling b822c7b66d12877d2e18a58f52433f81cdc565e0 on ui-update into effe49a102e94d4473f49bdb5d29107631fd02b5 on master.

authors: coveralls wu-sheng

repo: apache/skywalking


text:
[SPARK-25451][HOTFIX] Call stage.attemptNumber instead of attemptId.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5375/
Test PASSed.

Test build #99292 has started for PR 23149 at commit 9c84f18.

The PR builder is past the compile failure, so I'm merging this.

Test build #99292 has finished for PR 23149 at commit 9c84f18.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99292/
Test PASSed.

authors: AmplabJenkins SparkQA vanzin

repo: apache/spark


text:
add a util method for changing the log level while running

Let's close this issue pending an update from @holdenk.

authors: holdenk pwendell


text:
TS-4683 Adds better error handling on config problems

FreeBSD build failed! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/460/ for details.

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/356/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/461/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/357/ for details.

👍

Made the changes per Gancho's suggestions.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/468/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/365/ for details.

authors: atsci jpeach zwoop

repo: apache/trafficserver


text:
correct spelling mistake

Merged, thanks!

authors: EdwardBetts aperezdc

repo: aperezdc/signify

license: ISC


text:
Sema: Change a getBaseIdentifier() to userFacingName()

@swift-ci Please smoke test

repo: apple/swift


text:
[Update checkout] Add scheme for swift-5.1-branch-03-18-2019

@swift-ci smoke test and merge


text:
Added Hitokoto category configuration menu imitated the BrainyQuote.

Cool! At this rate, you might as well just take over the development of this app :-p

@apsun Thx, and I still need to learn more. ^_^

authors: Yubyf apsun

repo: apsun/QuoteLock


text:
In Swift method

how to use in swift.

repo: aryaxt/iOS-Slide-Menu


text:
Add upload size validation

Codecov Report

Merging #235 into master will increase coverage by 0.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
+ Coverage   67.37%   67.39%   +0.01%
==========================================
  Files          31       31
  Lines        1824     1825       +1
==========================================
+ Hits         1229     1230       +1
  Misses        595      595

Impacted Files
Coverage Δ

opwen_email_client/webapp/views.py
42.8% <0%> (ø)
:arrow_up:

opwen_email_client/webapp/config.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6beca85...1f22fa3. Read the comment docs.

authors: c-w codecov-io

repo: ascoderu/opwen-webapp


text:
what is the weird blank space over the dialog?

could you attach screenshot or describe it more in which version you are facing this issue?

The blank space over the title.
on jellybean and lollipop

Also, is there a way to omit the loader when you swipe the dialog?

authors: ashishbhandari paxdron

repo: ashishbhandari/AndroidTabbedDialog


text:
Create a test specification package

cc @Eilon \ @davidfowl \ @khellang

LGTM :+1:

:shipit:

cc @tillig \ @alexmg for Autofac

I dig it. It'll be nice to not copy these into our test project directly.

authors: Eilon khellang pranavkm tillig

repo: aspnet/DependencyInjection


text:
Add support for detecting when the user cancels the trust prompt and a mode to check for the validity and trust of existing certificates

let me pivot from ranting on CLI verbs to build stuff. It looks like compilation is failing. The new .sources packages should be available now. Once you've update the package versions so this repo passes on AppVeyor/Travis, go ahead and :shipit:

authors: javiercn natemcmaster

repo: aspnet/DotNetTools


text:
Turn on xplat tests

@divega This turns on the xplat test runs, unfortunately the current shared code has the attributes, so even though these should pass for the in memory providers, they are picking up the Skips still.  Filed an issue for this separate from the EF specific local db one...
https://github.com/aspnet/Identity/issues/673

Updated removing the attributes and using a manual skip method check which does the same checks, this allows the non SQL providers to run on xplat now.

:shipit: but the skip conditions in those "one off, standalone, non-shared" tests smell like regular engineering debt :smile: If that is the case, please make sure we have a bug tracking it.

a66f50c1ba2dec01b0ca001dc22767d77ece29f2

authors: HaoK divega

repo: aspnet/Identity


text:
removed unnecessary AUParameterTree variable declarations

Another person committed to clean code, I'm loving it!

authors: aure yyshin

repo: audiokit/AudioKit


text:
Producer c-chain parallel processing

Pull Request Test Coverage Report for Build 654489805

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 25.423%

Totals

Change from base Build 640560334:
0.0%

Covered Lines:
1713

Relevant Lines:
6738

💛  - Coveralls

authors: coveralls tasinco

repo: ava-labs/ortelius


text:
Update to support django 2.1

Please see https://github.com/lionheart/django-pyodbc/ which this has been deprecated in favor of.

repo: avidal/django-pyodbc


text:
Introduce generate_calendar.sql

Fixed some casting and fixed a typo in the notes.

Looks good. Would suggest add a description column for the holiday name

authors: ericfe zach-data

repo: awslabs/amazon-redshift-utils


text:
trailing space in directory name 'pytorch/native/src '

@gabe2001
Thanks for reporting this issue. will work on a fix.

repo: awslabs/djl


text:
account is current defaultly

Codecov Report

Merging #153 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   69.32%   69.27%   -0.05%
==========================================
  Files          76       76
  Lines        4648     4645       -3
==========================================
- Hits         3222     3218       -4
- Misses       1048     1049       +1
  Partials      378      378

Impacted Files
Coverage Δ

plugin/kube/client.go
18.51% <ø> (+0.66%)
:arrow_up:

api/object.go
91.11% <100.00%> (-0.38%)
:arrow_down:

server/mis_server.go
59.57% <0.00%> (-4.26%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbf0879...40a0be5. Read the comment docs.

repo: baetyl/baetyl-cloud


text:
kube modelstorage code refactor

Codecov Report

Merging #165 (7cbf0ee) into master (54fd60f) will decrease coverage by 0.14%.
The diff coverage is 88.13%.

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   69.21%   69.06%   -0.15%
==========================================
  Files          76       75       -1
  Lines        4674     4675       +1
==========================================
- Hits         3235     3229       -6
- Misses       1054     1063       +9
+ Partials      385      383       -2

Impacted Files
Coverage Δ

service/application.go
80.71% <80.95%> (-1.87%)
:arrow_down:

service/node.go
78.19% <85.71%> (-0.17%)
:arrow_down:

service/config.go
65.21% <90.00%> (ø)

service/namespace.go
84.61% <100.00%> (ø)

service/secret.go
66.66% <100.00%> (ø)

service/sync.go
52.50% <100.00%> (+0.08%)
:arrow_up:

api/api.go
6.52% <0.00%> (-8.70%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54fd60f...7cbf0ee. Read the comment docs.

authors: codecov-io yibishufange


text:
Resolve package loading issue and separate packages to modules

:x: Build ballerina-lang 102 failed (commit https://github.com/ballerina-platform/ballerina-lang/commit/61c75e1901 by @lankavitharana)

:x: Build ballerina-lang 103 failed (commit https://github.com/ballerina-platform/ballerina-lang/commit/6c18472f74 by @lankavitharana)

:x: Build ballerina-lang 104 failed (commit https://github.com/ballerina-platform/ballerina-lang/commit/6b4b220752 by @lankavitharana)

:white_check_mark: Build ballerina-lang 105 completed (commit https://github.com/ballerina-platform/ballerina-lang/commit/4eb37d6583 by @lankavitharana)

authors: AppVeyorBot lankavitharana

repo: ballerina-platform/ballerina-lang


text:
Release pipelines

Done.


text:
docs: fix typo

All good!

repo: benhmoore/Argon


text:
Adding base user

Good job!

fix #28

Please add the fix comment to the main message,
otherwise, it'll not link the issue to the PR (look at Linked issues on the right side of the screen), meaning It'll be harder to track AND the ticket will need to be closed manually when this PR is done.
Also, please describe in the description what does this PR include.

Done,
I still can't see the issue in the linked issues though

@Omeramsc @1Oreo please review

authors: AmitAharoni Micha546 Omeramsc simzacks


text:
Add umi_tools suite

Danke!

authors: bgruening blankclemens

repo: bgruening/galaxy-freiburg-tools


text:
Nael/update default perl5lib

Since we've been running without this, and apply the /opt/app/lib in the startup line instead, I'll close this.

authors: nael-binary tom-binary

repo: binary-com/docker-perl


text:
quick fix after test deploy

Changes Unknown when pulling 28e18fe530011beb4483688d2765472a444e8882 on antgonza:patch-53_fix into ** on biocore:master**.

authors: antgonza coveralls

repo: biocore/qiita


text:
demo page with examples

Is there a plunker, JSFiddle, or codepen with examples? Even a screen capture would be helpful.

I made a simple example for my own use. But it works under webpack, and i don't know if it is acceptable for this project to use webpack. Thats why i didn't made pull-request =)
You can see a screenshot here https://snag.gy/u5pwqO.jpg

Here is a plunker example with local data:
http://embed.plnkr.co/LtJB8eOf0q1wuCGzxK7Y
All relevant code is in the app.ts

add this link on main page

authors: AmyBlankenship daliri72 dindong nblum rovico


text:
Feature: add http2 transport

Codecov Report

Merging #104 into master will decrease coverage by 2.35%.
The diff coverage is 20.1%.

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   83.19%   80.84%   -2.36%
==========================================
  Files          52       53       +1
  Lines        3738     3853     +115
  Branches      759      780      +21
==========================================
+ Hits         3110     3115       +5
- Misses        557      646      +89
- Partials       71       92      +21

Impacted Files
Coverage Δ

src/transports/udp.js
90.32% <ø> (+11.1%)
:arrow_up:

src/transports/mux.js
90.47% <ø> (+6.95%)
:arrow_up:

src/transports/h2.js
0.82% <0.82%> (ø)

src/proxies/socks.js
73.24% <100%> (ø)
:arrow_up:

src/transports/defs.js
81.25% <100%> (+3.12%)
:arrow_up:

src/core/mux-relay.js
94.8% <100%> (ø)
:arrow_up:

src/core/config.js
86% <100%> (ø)
:arrow_up:

src/core/acl.js
63.18% <100%> (ø)
:arrow_up:

src/core/relay.js
84.33% <32.35%> (-13.48%)
:arrow_down:

src/core/hub.js
84.75% <58.82%> (-1.97%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa71a71...2b3cdf7. Read the comment docs.

authors: codecov-io micooz

repo: blinksocks/blinksocks


text:
Create LinearSVC_StandardScaler_PolynomialFeatures.ipynb

add meta description in Gsheet for all of your submission

repo: blobcity/ds-seed


text:
Fix a grammatical error in the README

Can one of the admins verify this patch?

:+1:

authors: blueboxjesse msambol paulczar

repo: blueboxgroup/ursula


text:
Discover catalogs through 'intake.catalogs' entrypoint

For anyone who happens to be following along, @gwbischof proposed this for intake in https://github.com/intake/intake/issues/404. This prototype will be pushed upstream shortly.

authors: danielballan gwbischof

repo: bluesky/databroker


text:
implement FromIterator for FixedBitSet

Thanks. I left a response in the last fold, too.

authors: bluss jrraymond

repo: bluss/fixedbitset


text:
Fixed Wrong URL

Well spotted thanks!

repo: boekkooi/openshift-diy-nginx-php


text:
Updated definition to support foundation 5

close the PR because this is too old.

authors: georgemarshall vvakame

repo: borisyankov/DefinitelyTyped


text:
support configuring misc http headers for Graphite requests

Code looks good to me. What is you use case for this?

We use the litmus graphite-kairosdb storage plugin which uses an x-org-id header for authorization

Litmus is raintanks upcoming sass monitoring product (for context)
On Jul 30, 2015 19:04, "Dieter Plaetinck" notifications@github.com wrote:

We use the litmus graphite-kairosdb storage plugin which uses an x-org-id
header for authorization
—
Reply to this email directly or view it on GitHub
https://github.com/bosun-monitor/bosun/pull/1221#issuecomment-126515603.

authors: Dieterbe captncraig kylebrandt

repo: bosun-monitor/bosun


text:
Carthage conversion

Verified that @scottliubox has signed the CLA. Thanks for the pull request!

authors: boxcla scottliubox

repo: box/box-ios-browse-sdk


text:
Fixes checking for http:// in srcset attributes

Closing this one, as it will be eclipsed by #38 once that's merged ;)

authors: bramus jamieburchell

repo: bramus/mixed-content-scan


text:
Delete old data from database — don’t keep everything forever

Duplicate of #373 and #374.

repo: brentsimmons/NetNewsWire


text:
switched @balances.io emails to balancesapp@gmail.com

:+1: :shipit:

authors: ianhirschfeld wellsriley

repo: brunchmade/balances


text:
remove deprecated meta tags for old Windows Mobile and BlackBerry

Thanks!

authors: budparr coliff

repo: budparr/gohugo-theme-ananke


text:
Allow the page to configure Relay retries

🚩

authors: keithpitt toolmantim

repo: buildkite/frontend


text:
add git to bionic stack build image

@mgibson1121 This change should be present on 0.0.1-rc.2. For acceptance:
docker run -it --rm cnbs/build:0.0.1-rc.2 bash
git version

You should see a version number if git is present.

This story passes acceptance

will ship in v0.0.1

authors: ameyer-pivotal ekcasey mgibson1121

repo: buildpack/stacks


text:
Add tag parameter to health.service()

Thanks for this! I've tagged and pushed to pypi as v0.3.15

Thank you for merging. :)

authors: cablehead reversefold

repo: cablehead/python-consul


text:
Azure - Add Batch and VM Scale Set resources

The cleanup on batch arm template is good, but the VMSS one still deploys Cognitive services and other stuff - I'd try to clean it up so its just the VMSS so its easy to deploy/delete for unit tests.

repo: capitalone/cloud-custodian


text:
Update Kitematic to 0.5.25

Please amend the commit message to include the name of the updated cask.

authors: cawcaw vitorgalvao

repo: caskroom/homebrew-cask


text:
Upgrade Atom.app to v1.3.1

Merged as 4883735a8d600ab67f0db36934522ee4c95bf074.


text:
Update SourceTree to 2.2.3

Thank you for the contribution. It was merged directly as 1622e01fcffa53d2b9c03979764ac1dae1749a8c to keep commit history cleaner. Your contribution is still credited to you.

authors: RJHsiao vitorgalvao


text:
This is Eric Jenkins

Good

license: Unlicense


text:
Make shallow clone the default

Example and groovydoc comment for the new parameters? What is disable_submodule variable? Adding groovydoc comment helps with understanding and also adds it to docs.

@sleitner and @imuchnik Can we resolve this? Would be nice to have in place.

I am going to close this and add it in another PR along with everything that is needed for docs.

:+1: to @imuchnik

Turns out it is already in the code.

@imuchnik I'm confused. We want shallow clone to be the default. It seems like the default is still false.

authors: Scotchester imuchnik sleitner

repo: cfpb/jenkins-automation


text:
Implement Delete function, fix #58

Will you also add a section to the README for the method?

yes ill do readme

Do you also want to uupdate the example "Open messages and delete them"?
Done for today, it's late here.

That'd be great

I would also need a search function without fetch, just to get the uids. Would you combine this with a second search+delete method, or handle in a separate feature?
One more question. My use case is simple, i want delete all mails older than 1 month. My code:
	debug(`deleting mails before ${deleteMailsBefore}`)
		let searchCriteria = [
			['!DELETED'],
			['BEFORE', deleteMailsBefore]
		];

	const imapUnderlying = this.connection.imap

	const uids = await new Promise((resolve, reject) => {
		imapUnderlying.search(searchCriteria, (err, uids) => {
			if (err) {
				reject(err)
			} else {
				resolve(uids || [])
			}
		})
	})

	if (uids.length === 0) {
		return
	}
	await this.connection.deleteMessage(uids)

Either one sounds reasonable. If you wanted a search without fetch we could make the search take an optional parameter to skip the fetch. Out we could add a deleteWhere that accepts search criteria.

done, you can merge

@chadxz Would be great if you could merge this, so it could be release - and also #49

Released as v5.0.0
Thanks for the nudge @TeNNoX

authors: TeNNoX chadxz synox

repo: chadxz/imap-simple


text:
Fix typo in README

Merged another PR for the same issue so closing. Sorry.

authors: etimberg ternel


text:
添加 npm 包以及包使用说明

@jackeyGao 可将 chinese-poetry 包转给你，或者添加共同维护者。

您好，
我不太懂前端的开发， 可不可以单独创建一个仓库， 然后在 README.md 中添加引用？我建议是在案例展示中引用， 打包的形式如果这样说明（在 README.md 详细说明）的话，后面其他打包形式也会这样说明， 会造成 README.md  混乱。 这个仓库主要做数据的维护， 其他衍生构建形式我还是建议通过案例引用的形式展示。 当然如果您愿意可以 transfer 到这个组织。 不知您的意见如何？

@jackeyGao 可以建个新 repos 将 chinese-poetry/chinese-poetry 当做子仓库引入(submodule) 这个其实我在 Node.js 后端玩儿，当然前端也可以使用。

嗯， 可以的。 我的意思是这个 NPM 的介绍可以单独创建个仓库， 这个仓库的 README.md  来介绍安装过程（或许还包括其他的相信信息）。 然后在 chinese-poetry 的 README.md 中增加这个仓库地址的引用和简短的介绍。 维持下 chinese-poetry的 README.md 的精简。

@jackeyGao 你可以组织里面建这么一个包，我来贡献。

@jaywcjlove 我邀请你来参与到这个组织了， 仓库的命名您比我更加明白一点。 可以在这个组织新建项目， 如果需要我帮助的地方， 随时联系。

@jackeyGao 好的。

authors: jackeyGao jaywcjlove

repo: chinese-poetry/chinese-poetry


text:
bump version to 0.1.0-beta.3

Codecov Report

Merging #58 (cad73fd) into main (984c684) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   85.55%   85.55%
=======================================
  Files          79       79
  Lines        2596     2596
  Branches      246      246
=======================================
  Hits         2221     2221
  Misses        307      307
  Partials       68       68

Flag
Coverage Δ

test-macOS-latest-3.8
?

test-ubuntu-latest-3.8
85.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/pyfx/__version__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 984c684...cad73fd. Read the comment docs.

authors: cielong codecov-commenter

repo: cielong/pyfx


text:
Add config loading package

I noticed that you've changed test verification from assert.Equal to assert.Check. Is there a reason why you prefer the latter?

also, the convention for Go's assert generally is to have expected values come first (example: https://pkg.go.dev/github.com/stretchr/testify/assert#Equal) but we have it the other way around. Is this our agreed convention?

also, the convention for Go's assert generally is to have expected values come first (example: https://pkg.go.dev/github.com/stretchr/testify/assert#Equal) but we have it the other way around. Is this our agreed convention?

The library we use takes a completely agnostic view to this, referring to them as x, y (I also don't feel particularly strongly)

I noticed that you've changed test verification from assert.Equal to assert.Check. Is there a reason why you prefer the latter?

assert.Check is a soft assertion, whereas assert.Assert is a hard assertion. Hard assertions fail immediately, while soft ones will allow the test to continue, gathering up as much information as possible.
The top level functions like assert.Equal all internally delegate to assert.Assert, so they are all hard assertions.
I would only use a hard assertion where proceeding further in the test would cause a panic, or some other failure making progress of no value.
e.g. you often do assert.Assert(t, err) if the error means that a returned value was nil, for example.

@erickim-circleci if you're looking at this, a stamp would be much appreciated!

authors: erickim-circleci pete-woods

repo: circleci/ex


text:
refactor(widget-message-meet) add immutable conversation to store

@bzang please re-review

repo: ciscospark/spark-js-sdk


text:
Clarify wording for Director Tasks section

Merged.

authors: cppforlife wlindner

repo: cloudfoundry/docs-bosh


text:
CFY-5056: print error message

@idanmo done.

repo: cloudify-cosmo/cloudify-cli


text:
Develop

Fechado

Fechado


text:
add canonical url tags

not sure what this is. But I merged it.

I just saw your slack message. Understood.

authors: brianek stvnrlly

repo: codefordc/clean-slate


text:
Support for J16

Fixed, now supports J17 with gradle 7.3-rc2.

repo: codingchili/chili-core


text:
Please add me

Yes of course!

authors: NiallJoeMaher annmariecl

repo: codu-code/contributors


text:
add puppet-lint and fix lint tests

Hi:
Thanks for submitting this PR and sorry for the delayed reply. I'd love to merge this! The change unfortunately breaks the test suite, I believe because of the change to the epel5 package installation.
If that change can be reverted, or if you know of a work-around, I'd be happy to merge this!

I think this should do it. The test for pygpgme was wrong, and centos5 being the only env where pygpgme is not available, it was failing.

tests are passing again -- thanks!! i'm going to merge this now.

repo: computology/computology-packagecloud


text:
adjust recipe for boostrapping

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

authors: conda-forge-linter katietz

repo: conda-forge/patch-feedstock


text:
Fix typo in README

Thank you! Will merge when next at my box!

Sorry for the delay, thanks again!

repo: conda-incubator/setup-miniconda


text:
Add SiaCashCoin and Logo

120x120 transparent logo attached

你好，已经添加代币，目前1.0版本修改名称会造成用户代币不显示，需要重新搜索添加，故不更改名称，会显示logo，可以建议用户使用2.0国际版，不会有名称重复显示数字，谢谢。

authors: SiaCashCoin wenyanwang

repo: consenlabs/token-profile


text:
Rvf

请按照我们的规范提交 Logo

authors: aboluoyes makoshan


text:
Create swift.yml

This will never work.
With the Actions set here, there is no root manifest set. ...Which this project doesn't have.
If I was to actually try to make a root manifest here, it would still fail.
I'll try to see what I can do, but I am almost positive this will not work.


text:
enable the postgresql protocol by default

lgtm

authors: kovrus mfussenegger

repo: crate/crate


text:
Fix to GetAllEntities only returning prop types

Looks good, Thanks!
(Guess this is okay to merge @crosire ? GitFlow also says it needs to go into master since it's a simple hotfix, correct?

As far as I know master = release branch, so this goes into dev until the next release is ready.

authors: JohnnyCrazy crosire zorg93

repo: crosire/scripthookvdotnet

license: Zlib


text:
Refactor scripts to gatsby-source-github-releases

Each release should probably get its own node. This way you can make single page per release if you want to.

I can share with you some code from the undefined that I wrote to create a source for simplecast RSS feed for the podcast site

Here is my simplecast source plugin for gatsby.
// ./plugins/gatsby-source-simplecast/gatsby-node.js
const axios = require('axios');
const crypto = require('crypto');

const digest = i =>
  crypto
    .createHash('md5')
    .update(JSON.stringify(i))
    .digest('hex');

exports.sourceNodes = async ({ actions }, options = {}) => {
  const { createNode } = actions;
  const { id, apiKey } = options;
  // Create nodes here, generally by downloading data
  // from a remote API.
  const { data } = await axios(
    `https://api.simplecast.com/v1/podcasts/${id}/episodes.json?api_key=${apiKey}`
  );
  data
    .filter(datum => datum.duration != null)
    .forEach(child => {
      createNode(
        Object.assign({}, child, {
          id: `${child.id}`,
          parent: null,
          children: [],
          internal: { type: 'Episode', contentDigest: digest(child) },
        })
      );
    });

  // We're done, return.
  return;
};```

Done 👍

authors: crosscompile jaredpalmer

repo: crosscompile/release-notes


text:
implement correct reload subroutine when running via electron

Please close if the issue is resolved.

authors: valzav wmbutler

repo: cryptonomex/graphene-ui


text:
lazyRequire 怎么和开源的路由库结合呢 比如说react-navigation

lazyRequire ：
LazyModule module = lazyRequire('xxx');

LazyModule = {
   function load() {
       if (loaded) {
           return module;
       } else {
           // do load
       }

   }
}

在具体路由库跳转页面之前调用lazyModule的load方法即可。

react-navigation 在配置的时候需要
const pages={home: {
screen: require("./page/home")
},
subpage:{screen:require('./page/subpage')}
}
createStackNavigator(pages,config),那么这里pages应该都是加载了吧，请问如何解决这个问题，比如一开始我只希望只是加载home的，其他页面在跳转的时候动态加载，请问如何配置？

react-navigation 在配置的时候需要
const pages={             home: {                      screen: require("./page/home")             },            subpage:{                      screen:require('./page/subpage')}            }    }
createStackNavigator(pages,config),那么这里pages应该都是加载了吧，请问如何解决这个问题，比如一开始我只希望只是加载home的，其他页面在跳转的时候动态加载，请问如何配置？

authors: RaySaii chufengma moseszhou

repo: ctripcorp/CRN


text:
optimize portal ui

Changes Unknown when pulling 4930452cfd96faf36329287e05e14ec938a4db49 on lepdou:logo into ** on ctripcorp:master**.

authors: coveralls lepdou

repo: ctripcorp/apollo


text:
8 ament model permissions

Coverage increased (+3.06%) to 94.059% when pulling b331eef39a231d30c0a47a6b7163064bc5b5c4a7 on 8-ament-model-permissions into a2e0bfc503539c9be7353e0be3813ee6a8cbd637 on master.

Coverage increased (+3.06%) to 94.059% when pulling b331eef39a231d30c0a47a6b7163064bc5b5c4a7 on 8-ament-model-permissions into a2e0bfc503539c9be7353e0be3813ee6a8cbd637 on master.

Coverage increased (+3.06%) to 94.059% when pulling b331eef39a231d30c0a47a6b7163064bc5b5c4a7 on 8-ament-model-permissions into a2e0bfc503539c9be7353e0be3813ee6a8cbd637 on master.

Coverage increased (+3.06%) to 94.059% when pulling b331eef39a231d30c0a47a6b7163064bc5b5c4a7 on 8-ament-model-permissions into a2e0bfc503539c9be7353e0be3813ee6a8cbd637 on master.

authors: coveralls lefterisnik

repo: ctxis/django-admin-view-permission


text:
Issue with autoplay

I believe this is because timestamps aren't being saved after creating a Curious Reader Audio object. When you go back and edit the Curious Reader Audio object, all the timestamps are missing.
Temporary fix: if you have saved the timestamps to a text file, choose to edit the Curious Reader Audio object and place the timestamps in manually and press save.

More info... it looks like timestamps that AREN'T manually typed in by the user aren't saved. That is, all values that are put in as the result of using the waveform editor don't actually save.


text:
chacha20-ietf-poly1305 有计划支持吗？

实际上如果是想代理某s服务的话，不需要支持该加密方式，直接在服务端启动 ss-local，然后配置 cow 的 socks5 代理就行了。

authors: airyland freedomlang

repo: cyfdecyf/cow


text:
adding human cortical development dataset

Reformatted to meet spec, data here: https://github.com/czi-hca-comp-tools/easy-data/blob/master/datasets/ucsc_human_cortex.md

authors: batson maximilianh

repo: czi-hca-comp-tools/easy-data


text:
Preliminaries/Probability

Job d2l-zh/PR-565/1 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-565/

Job d2l-zh/PR-565/2 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-565/

Job d2l-zh/PR-565/3 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-565/

Job d2l-zh/PR-565/4 is complete.
Check the results at http://preview.d2l.ai/d2l-zh/PR-565/

authors: mli xiaotinghe


text:
feat: allow this to be used as a nuxt module

@regenrek Would you send me a public or no-reply email address so I can attribute you in this PR? :slightly_smiling_face:

repo: danielroe/nuxt-composition-api


text:
Use correct variable in code example

Thanks!

authors: DiodonHystrix danschultzer

repo: danschultzer/pow


text:
Add cloudbees logo and info

assuming this referred to using jenkins, if so, unnecessary as GH-actions more powerful solution and at least here was using travis ci which replaced that need.

authors: dantwining hazendaz

repo: dantwining/whitespace-maven-plugin


text:
Option to list guilds by name instead of owner's guild in the GUI.

Alternatively; allow resorting and hiding of sections so you can display whatever you want in whatever order.

repo: darbyjack/Guilds-Plugin


text:
Dartpad complains about null-safety errors whether or not the null-safety toggle is turned on

Thanks for the report!
This issue was fixed earlier today. See https://github.com/dart-lang/dart-pad/issues/1784 for some of the backstory and https://github.com/dart-lang/dart-services/pull/680 for the fix.

authors: alan-knight domesticmouse

repo: dart-lang/dart-pad


text:
Search service to use TaskScheduler, plus backend and handler tests.

PTAL. I've updated this PR with the latest TaskScheduler. I've got a few tries on how to make the first listing of packages be complete and then trigger the first merge, eventually settled with this counter + fake Task approach. Not proud of it, but the other versions were even more crappier.

PTAL. Couple of major changes:

fixed the loadDocuments() index issue
removed the isLocalDevMode flag
removed the global state, but counting seems to be the simplest synchronization mechanism for marking the end of the first scan, so using it for that purpose. removed the extra dummy task, that was unnecessary.

There are slight differences with the task source here and in the analyzer, once we have both working I'll merge their code, but I'd rather keep them separate for the time being.

Agreed most of it, but there is a constraint there at the moment: the ducene on-disk-index is sync only (with the currently deployed package version), and unusable for our purposes. Until a new version is created, we are going to build the index each time we create a new service.

Actually not just each time we create a new service (or rather deploy a new version to the "search" service). AppEngine also sometimes just kills VMs and restarts them. So basically on every VM start it will re-index all packages.
It's fine for now if it rebuilds it every time. But once we switch over from custom search api, then we should have the index backed up and ready for serving on VM restarts.

authors: isoos mkustermann

repo: dart-lang/pub-dartlang-dart


text:
Upgrade to shelf 0.6.0

Resolved with cec0e5a2dc02a933625f463875a94cd99033d3e1
Thanks!

Thanks!!

authors: Andersmholmgren kevmoo sethladd


text:
Avoid name apply in dot-graph

LGTM.

authors: jcrist mrocklin

repo: dask/dask


text:
Create a github action that builds the collector container.

See this workflow https://github.com/davidmaceachern/rust-web-template/actions?query=workflow%3ADocker for successful status.

repo: davidmaceachern/rust-web-template


text:
Refactor MediaTypedDecoder

See issue #478

repo: dcos/cosmos


text:
DCOS-6226 Replaced failure chart with disk allocation

Reviewer: @daiyiwhale

❤❤❤❤❤❤❤❤❤❤❤❤❤❤

authors: MatApple mesosphere-web mlunoe

repo: dcos/dcos-ui


text:
DBZ-1868 Validate commit messages in PR

Not sure what to think about that tbh. It seems overly formalistic, what about quick typo fixes for instance?

@gunnarmorling The recent version supports one of three format

DBZ-xxx text
[release] text
[jenkins-jobs] text

So to alleviate the concern - we can either introduce [docs] tag or in case of fixes we can just ignore the failing sanity check and merge

just ignore the failing sanity check and merge

Ok, if that's an option for the occasional quick typo fix, that's fine for
me. But introducing [docs] is good, too, for slightly longer doc fixes
still not warranting a JIRA issue.

I must admit I'd prefer either one or the other option but not both.

Let's accept the failing check then every now and then, as e.g. external contributors won't know about the [docs] prefix when sending a typo fix.

@gunnarmorling I agree, if you are happy with it please merge and I'll introduce the same action for incubator repo

Done.

authors: gunnarmorling jpechane

repo: debezium/debezium


text:
DBZ-1245 Fix empty heartbeat message test

LGTM; can you merge it once CI has passed? Thanks!


text:
cpu argmax fix

Refer to this link for build results (access rights to CI server needed):
/job/nd4j_PR/30/


text:
Added support to accept address and channel as args from command line

This change accepts channel as first arg and address of crazyflie as second arg from the user.

repo: dennisss/cfbridge


text:
Use readthedocs style to make Sphinx documentation

Fixed in 396a1054744a3cd193d7d1a8fe88d70fe90ad674
See: http://gcloud-python-bigtable.readthedocs.org/en/latest/

repo: dhermes/gcloud-python-bigtable


text:
Program error: Failed to load interface for ‘Data.DList’

Did you manage to fix this? If so, are the steps you took already on https://github.com/digital-asset/ghcide/blob/master/docs/Setup.md? If not, care to add them?

authors: ndmitchell shivamashtikar

repo: digital-asset/ghcide


text:
Enforce max_local_storage_nodes of 1

@dannyroberts

repo: dimagi/commcarehq-ansible


text:
Fixed #26577 -- Disabled implicit wait of Selenium tests where appropriate.

Buildbot, test on selenium.

I can't say for sure if this is the best solution but it seem okay for now at least.

I'll merge it as it seems to help Selenium tests to pass.

authors: charettes timgraham

repo: django/django


text:
Make average line length example more concise

I really like this example. How about adding it to the example code roulette as well?

Is there a way to share the source code between the different examples? Or perhaps we should swap this one with the rounding one>

Btw I just realized that we probably need to update the MD5 hash:
https://github.com/dlang/dlang.org/blob/master/js/run-main-website.js
Imho this is a really annoying approach and we get rid of this approach entirely and store the STDIN in the DOM as well. This manual hashing approach wouldn't scale anyways if we go with https://github.com/dlang/dlang.org/pull/1709

Is there a way to share the source code between the different examples?

From js/dlang.js:
        // [your code here] rotation for index.html
        var $examples = $('.your-code-here-extra > pre');
        if ($examples.length) {
            var n = Math.floor(Math.random() * ($examples.length+1));
            if (n)
                $('#your-code-here-default > pre').replaceWith($examples[n-1]);
        }

So in theory just adding another $(EXTRA_EXAMPLE should work...

Or perhaps we should swap this one with the rounding one?

I would leave it in the roulette for now as we only have two examples at the moment.
Maybe we can steal a couple from the DTour (or other)?

Btw I just realized that we probably need to update the MD5 hash:
Imho this is a really annoying approach and we get rid of this approach entirely and store the STDIN in the DOM as well. This manual hashing approach wouldn't scale anyways if we go with #1709

And a lot of chunk is gone: https://github.com/dlang/dlang.org/pull/1709/commits/44cbc937104d2c1529bc020f5856b8ab47366453 (#1709)

So what's left for me to do? Copy & paste the example to the top?

So what's left for me to do? Copy & paste the example to the top?

Yep, but better do this as a separate PR, so that this one isn't blocked
(I don't know how long it will take for #1709 to get in ...)

So what's left for me to do? Copy & paste the example to the top?

Once you have rebased your PR, you should be able to do this :)

@wilzbach done. @CyberShadow @aG0aep6G what do you think?

I would leave it in the roulette for now as we only have two examples at the moment.
Maybe we can "steal" a couple from the DTour (or other sources)?

https://github.com/dlang/dlang.org/pull/1755

Ping @wilzbach  @CyberShadow is this good to go?

Thanks @CyberShadow!

authors: ZombineDev wilzbach


text:
Реализовать возможность установки модуля как плагина для DLE 13

https://github.com/dle-modules/DLE-BlockPro/releases/tag/6.0.0

repo: dle-modules/DLE-BlockPro


text:
Release/tag new version X (TBD)

Depends on #10.

repo: dmfs/uri-toolkit


text:
[pl] add index page for polish translation

@doomspork I've updated polish translation and removed list of languages from index page

Perfect @kdebowski!  Thank you so much for your contribution

authors: doomspork kdebowski

repo: doomspork/elixir-school