text:
How to internationalize our programs?

This is tricky. There is support for localization, but there is not currently any support for bundling localization resources with your program.
There is a mechanism by which you can kind of make this work, though, by manually instantiating your own L10nManager that points to a specific set of string files; take a look in druid/src/localization.rs to get a sense of how this works.
This does not handle other aspects of internationalization, such as number or date formatting, which is firmly in the "one day" category.

But everything in druid/src/localization.rs other than LocalizedString are private. We cannot use any of them.

Currently it seems you can only use LocalizedString::with_args to build your localization manually. You probably need to build wheels again by yourself if you want to have something ergonomic to work with.

hi all, we finished first revision of the higher level API based on FluentBundle - it's in fluent-fallback and binds with l10nregistry-rs. I documented the resource manager here: https://github.com/linebender/druid/issues/397#issuecomment-897971712
For Localization class you may explore how we structure the "generic" one - https://searchfox.org/mozilla-central/source/dom/webidl/Localization.webidl and then extend for DOM bindings needs for our UI - https://searchfox.org/mozilla-central/source/dom/webidl/DOMLocalization.webidl
I also recommend my notes on how I believe UI should generally hook in localization bindings - https://github.com/raphlinus/crochet/issues/7 and https://github.com/unicode-org/message-format-wg/issues/118
The latter comes from a Unicode WG where we work on standardization of MessageFormat 2.0 which hopefully will be a straight superset of Fluent and we'll provide automated migration tools and the higher level APIs should work without changes.

Thanks @zbraniecki, will take a look!

source: gharchive/issue

repo: linebender/druid

license_type: permissive

license_source: github-api


text:
Release 0.14.0

Coverage increased (+0.5%) to 71.348% when pulling 045ba63fbbb892b9abb3b233b6213f8a8ad82c62 on eatonphil:release-0.14.0 into 2cde12db9274d203d9356a21d3b1b60e0b0822d3 on linode:master.

I haven't given this much testing yet. Test thoroughly!

Coverage increased (+0.5%) to 71.348% when pulling e8961b75df32663b85e3502af9199e8cec01728e on eatonphil:release-0.14.0 into 2cde12db9274d203d9356a21d3b1b60e0b0822d3 on linode:master.

Coverage increased (+0.5%) to 71.375% when pulling 53bd026b64857cdfeb5984f8d7e84cba0eb509c8 on eatonphil:release-0.14.0 into 726e35dc473b56b3d26fd10d00510087011c4bfe on linode:master.

source: gharchive/pull-request

authors: coveralls eatonphil

repo: linode/manager


text:
Add dependency requirement for CLightning

Codecov Report

Merging #111 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   32.46%   32.46%
=======================================
  Files          27       27
  Lines        1500     1500
=======================================
  Hits          487      487
  Misses       1013     1013

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6bcff0...dfc3897. Read the comment docs.

authors: RohanKapurDEV codecov-io

repo: lnbits/lnbits

license: MIT


text:
Change heartcheck required dependency version to 2.0.0

since heartcheck 2.0 added support for ruby 2.7 and dropped for some older ones, would be nice to do it in this PR too, and also chance the changelog ;)

authors: phsacramento pmnhaes

repo: locaweb/heartcheck-sidekiq

license: mit

license_source: bigquery


text:
Added CreateColorSeries.py, a translation of the C++ version

@lorensen Just merged the python version. I see you picked some typos in CreateLookupTableVTKYellow

repo: lorensen/VTKExamples


text:
Update Dockerfile to golang 1.12 and update alpine

Bump! 🙏

repo: lrills/helm-unittest


text:
Refactor using libahtse

In the ahtse branch

Fixed in 9ef8d1b


text:
请问是否支持kotlin呢？

支持

repo: luckybilly/AutoRegister


text:
Instead of .chart.plot we should have .plot

part of https://github.com/luna/Dataframes/issues/90

repo: luna/Dataframes


text:
Fix snapshots on CEPH

Fails completely unfortunately.

authors: brauner stgraber

repo: lxc/lxd


text:
Add Okta intel module.

@achantavy addressed feedback. Please approve

Looks like the CI linter is complaining.  To fix, rerun make test_lint (or just run make to rerun the whole suite if that doesn't work).

@ecdavis Mind doing another pass when free?

authors: achantavy sachafaust

repo: lyft/cartography


text:
增加“关闭时最小化到托盘”的设置

我去，刚发现这个托盘还有一些bug，，回头我再修下吧。。

authors: LasyIsLazy lyswhut

repo: lyswhut/lx-music-desktop


text:
[WIP] Extend the the file cleanup manager to handle inactive filesets from shards no longer owned

Coverage increased (+0.2%) to 77.994% when pulling 95c69303d1518b65b87e8f244707660249bf63de on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage decreased (-0.03%) to 77.768% when pulling 2ebee0d1bbafc1fb48586461a4587f1757e0eaa4 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage decreased (-0.03%) to 77.768% when pulling 2ebee0d1bbafc1fb48586461a4587f1757e0eaa4 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage increased (+0.04%) to 77.836% when pulling 16f9e4ee3fc30a0c55748cdf8c051e1b2e649286 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage increased (+0.04%) to 77.836% when pulling 16f9e4ee3fc30a0c55748cdf8c051e1b2e649286 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage increased (+0.03%) to 77.832% when pulling 6f841971732d1287b1161d9c68b6cb0a10e50138 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage increased (+0.05%) to 77.849% when pulling 6f841971732d1287b1161d9c68b6cb0a10e50138 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage increased (+0.05%) to 77.849% when pulling 6f841971732d1287b1161d9c68b6cb0a10e50138 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Overall looks great, perhaps we should also write an integration test?  There's a few in integration/ that aren't too insanely complex that could be copied and slightly altered I think.

Coverage decreased (-0.8%) to 76.955% when pulling 9c8c71150a35277515d4d748ec2cf44bc77bc6b7 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage decreased (-0.8%) to 76.955% when pulling 9c8c71150a35277515d4d748ec2cf44bc77bc6b7 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage decreased (-0.8%) to 77.006% when pulling 9c8c71150a35277515d4d748ec2cf44bc77bc6b7 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage decreased (-0.7%) to 77.101% when pulling 9c8c71150a35277515d4d748ec2cf44bc77bc6b7 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage decreased (-0.06%) to 77.739% when pulling 28de4ab28524c2d09c09cbf3e7e8c7eb73536a94 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage increased (+0.01%) to 77.81% when pulling 28de4ab28524c2d09c09cbf3e7e8c7eb73536a94 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage increased (+0.1%) to 77.899% when pulling 5db3baa34e4e8bcc7c10f3e58913c1c931d572f8 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage increased (+0.1%) to 77.927% when pulling 5db3baa34e4e8bcc7c10f3e58913c1c931d572f8 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage increased (+0.07%) to 77.866% when pulling 5db3baa34e4e8bcc7c10f3e58913c1c931d572f8 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage increased (+0.4%) to 78.166% when pulling 55284b897524b4401978a31c081a02e8769e8dbd on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage increased (+0.3%) to 78.118% when pulling 935cd7c8feef76a1d6e37082620a7a7d3eb35d6a on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage increased (+0.3%) to 78.118% when pulling cec237369ee8526ecbafe37e1cc7dde6c7510690 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage increased (+0.3%) to 78.118% when pulling cec237369ee8526ecbafe37e1cc7dde6c7510690 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage increased (+0.2%) to 78.006% when pulling da00ef3cf3eb2d286116d93837713a05ce00ef94 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage increased (+0.3%) to 78.124% when pulling a2215cda4b6047cb55d44560ac80b95470062d48 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage increased (+0.3%) to 78.118% when pulling 7f60b67f7043bb7c59c11cbbb54321c99c7f8af3 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage increased (+0.3%) to 78.143% when pulling 5e29d672bf107179f37c1fec1e61c982937729ad on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

Coverage decreased (-0.7%) to 77.127% when pulling b71289787375664debb177ceea1441279154ed38 on katezaps/cleanup-filesets-after-node-is-deleted into 1642e26885813f9ab876597f07df70e40c2b84da on master.

fixes #304

authors: coveralls katezaps robskillington


text:
how to filter the field that value is empty

It's not the plugin's job to determine which fields you intend to serialize.
You could try using jQuery.filter to remove inputs that have an empty value, then call serializeObject
$('#my-form :input').filter(function() { return this.val() !== ''; }).serializeObject();

authors: foxinmy macek

repo: macek/jquery-serialize-object


text:
feat: additional details to the boilerplates' README files to prevent user from some problems

r? @ustulation
(maidsafe_highfive has picked a reviewer for you, use r? to override)

authors: bochaco maidsafe-highfive


text:
Add MIP13c3-SP4

LGTM. Adding to the conception branch.  Review and status change to RFC to follow.

repo: makerdao/mips


text:
Allow other (external) solutions for OCR instead of the local Tesseract instance

Implementing Factory Pattern for different OCR Solutions.
Tesseract (simple)
Tesseract (with East Text Detection)
External OCR Service (returning Tesseract Data Objects)

East was implemented as an option, but no general Interface for other services has been implemented so far.

repo: manykarim/robotframework-doctestlibrary


text:
Add ClearRows() method to Grid

Changing name to RemoveRows based on https://github.com/marcusolsson/tui-go/pull/16.

repo: marcusolsson/tui-go


text:
Client: Prepare HeroContext boilreplate

Done.

repo: marek-hanzal/DeRivean


text:
fix(util): fix get_value_at_path for None values

Codecov Report

Merging #53 (e36904f) into main (cb9a0dc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            8         8
  Lines          369       374    +5
=========================================
+ Hits           369       374    +5

Impacted Files
Coverage Δ

src/event_processor/exceptions.py
100.00% <100.00%> (ø)

src/event_processor/filters.py
100.00% <100.00%> (ø)

src/event_processor/util.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb9a0dc...e36904f. Read the comment docs.

authors: codecov-commenter marier-nico

repo: marier-nico/event-processor


text:
make the BeanPropertyMatcher available from the generated sources somehow without adding external dependencies!

Maybe with a decompiler like the following? ^^ https://bitbucket.org/mstrobel/procyon/

Using external dependencies now, because it's more reliable

repo: marmer/java-test-helper-generator


text:
Always run CI checks

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@6104ddc). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 6d01ae4 differs from pull request most recent head d4a897c. Consider uploading reports for the commit d4a897c to get more accurate results

@@            Coverage Diff             @@
##             develop       #9   +/-   ##
==========================================
  Coverage           ?   26.36%
  Complexity         ?       36
==========================================
  Files              ?       14
  Lines              ?      220
  Branches           ?       27
==========================================
  Hits               ?       58
  Misses             ?      157
  Partials           ?        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6104ddc...d4a897c. Read the comment docs.

authors: codecov-commenter matbadev

repo: matbadev/dabirva


text:
clarify delivery concurrency is per client

Coverage remained the same at 96.998% when pulling 4ab42d8ae32b62325108d32346cf66f73fedee73 on behrad:clarifyConcurrency into a66ae34904d990f21080edcc482f0d2358d75c70 on mcollina:master.

This is not true. Delivery concurrency is for the whole broker, and the limit is on the fan in, not on the fan out.

and how this is achieved by conn.setMaxListeners(opts.concurrency * 2) ?

@mcollina Can you clarify me on this man?

A piece of code is probably worth more :).
conn.setMaxListeners(opts.concurrency * 2)
is needed to avoid a bad warning. Nothing more. It's set to twice the max concurrency, just because I had to account for QoS 1/2 messages.
regarding the actual concurrency limit, this is is:
https://github.com/mcollina/mqemitter/blob/master/mqemitter.js#L97-L114

It is also invoked in mqemitter-redis: https://github.com/mcollina/mqemitter-redis/blob/master/mqemitter-redis.js#L33.

Not it makes sense, thank you :)
implementation shows the limit is number of parallel publish matchings done inside the broker, however each publish may match any number of clients :)

Would you mind sending a PR against the README? It might be helpful to others.

implementation shows the limit is number of parallel publish matchings done inside the broker, however each publish may match any number of clients :)

and this means the max number of messages delivered concurrently may be higher than conncurrency!? in current implementation. Yes?

concurrency is the number of unique messages being delivered, not considering the number of clients we are delivering them to.

concurrency is the number of unique messages being delivered, not considering the number of clients we are delivering them to.

But here https://github.com/mcollina/mqemitter/blob/master/mqemitter.js#L126 current is incremented per _do, despite the actual matches size!!!

there is no check on the matches, the check is on the message that is being published, not on the messages it is being delivered.

the check is on the message that is being published, not on the messages it is being delivered.

Exactly! and hence we need to emphasize the word unique message, and may be change the word delivered to forwarded or published since delivered increases the chance for ambiguous.

Published is a good term I think. PR?

👍 Yup, will create one.

authors: behrad coveralls mcollina

repo: mcollina/aedes


text:
Add TOC in repo with long README

Not an issue anymore since GitHub now support TOC as a menu icon automagically :D

repo: meilisearch/devrel

license: Unlicense


text:
Handle pagination for gitlab

Closing this one in favor of https://github.com/merico-dev/lake/pull/60

repo: merico-dev/lake


text:
Readiness check for HDFS

Can one of the admins verify this patch?

retest this please

@NimaVaziri:  Can you add the requested comment and rebase?  Would like to get this in.

Oh the comments are now included, unless you prefer them to be more detailed.

@gabrielhartmann given that the other problem we ran into isn't necessarily related to readiness checks, unless you have more comments, this should be good to go

@gabrielhartmann addressed comments

@NimaVaziri:  LGTM.  Can you resolve the merge conflicts please?

retest this please

retest this please

authors: NimaVaziri gabrielhartmann mesosphere-ci nickbp triclambert

repo: mesosphere/dcos-commons


text:
testing, ignore

Can one of the admins verify this patch?

authors: jeditest mesosphere-ci

repo: mesosphere/marathon


text:
Make it an oh-my-zsh theme?

:+1:  This would be awesome :).

+1

+1

+1

+1

+1

+1

+1
There is a workout about this issue https://github.com/robbyrussell/oh-my-zsh/issues/4288

+1

:+1:

I realise this is an old issue but I wanted to add to it. I think that git-rader should be a separate plugin but can tell oh-my-zsh that it exists then any theme that has some kind of git segment could instead use git-rader over any internal implementation, that way they can integrate it with there theme's.
That way you can use whatever theme you want and still have access to this wonderful plugin, plus  if you add an api for appearance it would fit in easier.

Look at all these +1s man

Yup, too bad I don't use Oh-my-zsh and so can't reliably do this. You could though if you want, I'll happily accept a pull request for any changes needed.

authors: Mayccoll Thermatix ahmetalpbalkan bumaociyuan eibreans halcyon hasantayyar michaeldfallen oryband robertmircea roidriscoll shkm therzka

repo: michaeldfallen/git-radar


text:
Feature/readme

Add more features in README.md

authors: fariasmateuss michelonsouza

repo: michelonsouza/encrypt-storage


text:
[WIP] Fixing private email login

You have a go mod conflict

@asim work in progress, don't merge as it's broken

authors: asim crufter

repo: micro/platform


text:
Added a few more api endpoints

@aquint thanks! Will take a look and if it's ok, merge! Can you share your email address?

Great! Thanks for the repo, you can reach me at anthonyquinton92@gmail.com

Hi, @aquint !
asset.js
I have created an integration test for this resource https://gist.github.com/Alua-Kinzhebayeva/7385bcdbc91c7814d815, and removed
Asset.prototype.all = function(parentId, params, callback) {
var url, _ref;
if (typeof params === 'function') {
_ref = [callback, params], params = _ref[0], callback = _ref[1];
}
url = "" + this.prefix + "/" + parentId + this.child + "?" + params;
  return this.resource.get(url, "" + this.slug , callback);
};

Redefinition of Asset.prototype.all breaks logic for “/admin/themes/828155753/assets.json: Listing theme assets only returns metadata about each asset. You need to request assets individually in order to get their contents.”. When we call /admin/themes/828155753/assets.json it returns  us “assets”.  With new function it will try to find “asset”.
I guess it’s been done to handle other invocations of “/admin/themes/828155753/assets.json” which return “asset”. If you don’t mind me suggesting, what if we define separate function(s) for cases with “asset”?
metafield.js
I have created integration test metafield_test.js https://gist.github.com/Alua-Kinzhebayeva/f892eead5da0f2bf4bec
createForShop passed successfully, but deleteFromShop fails due to wrong url  "https://test.myshopify.com/admin//metafields/721389482.json" .
This line  breaks the url: "url = this.resource.queryString("" + this.prefix + "/" + this.child + "/" + id);" If we change url to "url = this.resource.queryString("" + this.prefix + this.child + "/" + id);", it will fix it.
And minor things are console.log(s) left from debugging/testing. Removing them from Resource.js/Base_child.js would have been brilliant.
P.S. if you decide to run tests I was talking about, you would need jsons. I got them from API pages like https://docs.shopify.com/api/asset#index

@Alua-Kinzhebayeva if you agree, I will close this PR.

@alexandresaiz sure

Closing due to previously mentioned reasons.

authors: Alua-Kinzhebayeva alexandresaiz aquint

repo: microapps/Nodify


text:
Bump CHANGELOG to 4.5.2

Coverage remained the same at 65.147% when pulling 3bfb7cf0b86083fa63602343298f4186bf3ed358 on compulim:bump-changelog-4.5.2 into 08468b33f5825ab31e6ed88f27fee275492a3c87 on microsoft:master.

authors: compulim coveralls

repo: microsoft/BotFramework-WebChat


text:
Update Well-Architected Framework

Clean up

Clean up

repo: microsoft/PartnerResources


text:
Add new MeasureIfAllZeros operation.

@tcNickolas: I've gone on and added this operation as per your feedback, please let me know if it addresses your usecase before I merge it in. Thanks!

@cgranade, could you please submit an issue for an API review of the proposed operation. We can then schedule it for API review in order to complete this PR. If the PR is no longer of interest, we can close it alternatively. Thanks

@cgranade, could you please submit an issue for an API review of the proposed operation. We can then schedule it for API review in order to complete this PR. If the PR is no longer of interest, we can close it alternatively. Thanks

Sounds good, can do that. I think this also originally came your suggestion, @tcNickolas, if you'd prefer to file the issue?

@cgranade I'll admit I have no recollection of suggesting this... My best guess it had something to do with checking whether the oracles modify their input registers, this could've been something I did two years ago?
I think it will be better if you do the proposal - from the comments it looks like you had thoughts on offering different variants of this operation rather than just one? And then I chime in on the API review step

authors: cgranade msoeken tcNickolas

repo: microsoft/QuantumLibraries


text:
Allow #call_or_* to bubble up any result attribute beginning with 'error'

The Travis CI failure is "no environment variables set". Something I did wrong?

@wkotzan-avant I'm not sure, I haven't seen that error before.

done

👍

authors: mikenichols wkotzan-avant

repo: mikenichols/actionizer


text:
Update README.markdown

The target directory is created if it doesn't exist https://github.com/mislav/git-deploy/blob/master/lib/git_deploy.rb#L29

This is the log i get when running git deploy setup -r test
[master][~/Projects/Play/TestProject] git deploy setup -r test
[test] $ sudo -p 'sudo password: ' mkdir -p www/gitdeploy && \
  sudo -p 'sudo password: ' chown $USER www/gitdeploy
sudo: no tty present and no askpass program specified
[test] $ chmod g+ws www/gitdeploy && \
  cd www/gitdeploy && \
  git init --shared && \
  git config --bool receive.denyNonFastForwards false && \
  git config receive.denyCurrentBranch ignore
chmod: cannot access `www/gitdeploy': No such file or directory

Because necessary permissions might not be in place. sudo can be turned off, too, I think. check the code
Sent from my iPhone
On Feb 1, 2012, at 16:42, Henrik Bjørnskovreply@reply.github.com wrote:

Is there any reason to why it would sudo ?

Reply to this email directly or view it on GitHub:
https://github.com/mislav/git-deploy/pull/21#issuecomment-3760783

authors: henrikbjorn mislav

repo: mislav/git-deploy


text:
Merge resources

Also, we'll need to figure out how to fix/update all of those broken tests. For now it's OK though, since we're in the fragile early stages of our development.

authors: cjduffett troycrews

repo: mitre/ptmerge


text:
Use pkg-config on linux & simplify  C-API

any feedback on this?

There seems to be no interest in maintaining, so I withdraw my changes for now...

repo: moovweb/rubex


text:
Fix typo in wsgi file.

r+

authors: akatsoulas johngian

repo: mozilla/mozillians


text:
timeouts

Not sure what the original use case was. Maybe restart a worker if it's hanging?

repo: mrsonne/hubit


text:
fix: correct typos

Good find and thanks for the fix!


text:
rc in tuple

LGTM

authors: cclauss nadgowdas

repo: nadgowdas/cargo


text:
Update to JsonMapper 2.0.0

Thank you very much! :tada: :rocket:

authors: DannyvdSluijs namelivia

repo: namelivia/travelperk-http-php


text:
Use Maven Properties

https://cwiki.apache.org/confluence/display/MAVEN/Maven+Properties+Guide

repo: namioka/eclipselink-example


text:
Pyicloud updated their code to be 2sa instead of 2fa. Fixing on this end as well

Ah, great. Could you please add a callable(requires_2sa) line to provide backwards compatibility with previous versions of pyicloud? Thanks!

okay, it's pushed.

Whoops, I gave you the wrong suggestion. We needed to use hasattr instead of callable. I pushed the fix: 43026e6b3f18d75b3b628ad58ff3190df59d05fa
Thanks for letting me know about that change!

authors: dillanmills ndbroadbent


text:
feat: add lock/burn tx confirm number

Codecov Report

Merging #101 (af68b63) into main (bb5917e) will decrease coverage by 3.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   40.60%   37.28%   -3.32%
==========================================
  Files          23       17       -6
  Lines        1921     1695     -226
  Branches       48        0      -48
==========================================
- Hits          780      632     -148
+ Misses       1141     1063      -78

Impacted Files
Coverage Δ

...ain-modules/eth-contracts/contracts/test/ERC20.sol

...th-contracts/contracts/libraries/MultisigUtils.sol

...les/eth-contracts/contracts/libraries/SafeMath.sol

...ules/eth-contracts/contracts/libraries/Address.sol

...in-modules/eth-contracts/contracts/ForceBridge.sol

...es/eth-contracts/contracts/libraries/SafeERC20.sol

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb5917e...af68b63. Read the comment docs.

authors: codecov-commenter mkxbl

repo: nervosnetwork/force-bridge


text:
feat: update code-snippet v1.5.0 for GAFeature/update code snippet

Can one of the admins verify this patch?

ok to test

authors: jungeun-cho seonim-ryu


text:
Shared styles don't support opacity

Shared Text Styles does support opacity, but only if you set it in the color picker. Like here:

Closing this for now.

Didn't think of trying that... 🤦♂ Thanks!

authors: nilshoenson vedranzidanik

repo: nilshoenson/shared-text-styles


text:
NPOI can not copy/paste formula in Word,how to save a formula in Word?

Is Word supporting formula? I don't know that.

Is Word supporting formula? I don't know that.

authors: charlilezar tonyqus

repo: nissl-lab/npoi


text:
update project url on PyPI

@mdeff thank you!

authors: mdeff searchivarius

repo: nmslib/nmslib


text:
Error: dlopen(bin-osx/webgl.node).  Library not loaded: @rpath/glew.dylib

Hello,
I ran this demo on macOS, but the following error occurred, how can I solve it?
Error: dlopen(/webgl-raub/bin-osx/webgl.node, 1): Library not loaded: @rpath/glew.dylib
Referenced from: /Users/Carl/WorkSpace/GitHub/electron/webgl-raub/bin-osx/webgl.node
Reason: image not found

Hello. Please check if that file exists under /Users/Carl/WorkSpace/GitHub/electron/webgl-raub/node_modules/deps-opengl-raub/bin-osx/glew.dylib, or anywhere under the project directory at all.
If it is not there, the library might have failed to install properly. And if it is there, it might be a result of some system-specific changes in OSX. I can't actually test this as I don't have an OSX device. And also I can't validate it with CI as it doesn't have a visual interface available for GL to run on.
Although, the module is known to have worked under OSX. I wonder if you could try it on any other OSX machine as well. I will also ask my friend who has one to try running this.
P.S.: Does it have anything to do with electron in your directory path anyway?

authors: raub wufangcan


text:
Ignore fs module when used with webpack/browserify

Could you elaborate on what problem this solves? It doesn't seem to impact file size, for example.

Without this entry you have to have fs module installed, which is not needed if its used only in browser. So webpack/browserify just ignores this dependency when packaged for browser, because of this browser entry.
In other words it does not require you to npm install fs if you don't use it. Does it answer the question?
Other projects that work in browser and node.js use it for this purpose, here is example: https://github.com/kangax/fabric.js/blob/master/package.json

Thanks for the extra explanation! Merged.

authors: fdb jardakotesovec


text:
fix typo

Thanks!


text:
docs: fix link to plugin tutorial

Thanks @paulrberg. Always a pleasure to receive these PRs

PS: I'll also add a redirect in our site

authors: alcuadrado paulrberg

repo: nomiclabs/hardhat-ts-plugin-boilerplate


text:
CI for Node

Initializes with two players

repo: nrgcode/github-actions-for-ci


text:
The pause button should not be near the end exam button

Closing this, because I can't see us getting any further with it.

repo: numbas/Numbas


text:
[T5A1][F09-B2] Bernard Tan Ke Xuan

Some comments added. Please close the PR after reading comments.

authors: bernardtankx jeffryhartanto


text:
Update repos for latest reference

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: ha.yoon:x: ScreamBunha.yoon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant ScreamBun


text:
buildkite: use stable agents for daily longtests

@kostko check again please, i added another commit after your review

repo: oasislabs/oasis-core


text:
both operands of "===" should be AnyObject

This eliminates the compiler error. But does it eliminate the root cause? That is, should $0 be Any Object?

The correct fix for this would be to change the extension to:
extension Sequence where Element: AnyObject
While the iterator also uses the Element associated type and that one is constrained to be equal to the Sequence's Element type, the type system only checks the Sequence's Element type in this case, so it can't establish that every element of the Sequence is also an AnyObject anyway when only the Iterator's Element is specified.
Hope that makes sense.

authors: EdgarDegas PatrickWeigel tkrajacic

repo: objcio/core-data


text:
Forest fire model

https://github.com/jjasont/forest-fire-PH4505

@amjankowska wrzuciłabyś na GH to co masz do tej pory? doszlifujemy wspólnie :)

authors: StanczakDominik avocadit okmechak

repo: okmechak/SocSIM


text:
Add script to reconcile remote and local claims

@dhaiducek What function does this script add?  Can we add some doc for it?

Ah, yes. Documentation is key--I'll write some up.

authors: dhaiducek gurnben

repo: open-cluster-management/lifeguard


text:
bump version to 2.1.6

/lgtm


text:
did this paper can download "FishNet: A Versatile Network Backbone for Image Region and Pixel Level Prediction“?

Hi,
FishNet will be included and updated later in mmdet. Both the paper and the code will be released in the late Oct.
Thank you for your interest.

Hi,
FishNet will be included and updated later in mmdet. Both the paper and the code will be released in the late Oct.
Thank you for your interest.
where is the fishnet?

authors: kevin-ssy mlinxiang sunpeng981712364

repo: open-mmlab/mmdetection


text:
Permission fix

Makes sense, looks like we messed up the massive copy&paste that got us sensible error messages rather than weird failures.

authors: apopple stewart-ibm

repo: open-power/op-test-framework


text:
add Bzzz666 to students list

Many thanks for enrolling @Bzzz666 ! :tada: :smile:

@Bzzz666
I updated the manner to enrolling in our course to be more scalable.
Can you create your profile here again?
Sorry for that, but in that way will be much more easy for all of us :smile:


text:
MIT license for pixellink and changelog

@benhoff , thanks for your time and help!

authors: benhoff nmanovic

repo: opencv/cvat


text:
Registration fee

Pull Request Test Coverage Report for Build 354

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 95.899%

Totals

Change from base Build 352:
0.3%

Covered Lines:
3601

Relevant Lines:
3755

💛  - Coveralls

authors: bdmbdsm coveralls


text:
WIP: Uninst restart sidecar

This is a second implementation instead of https://github.com/openshift/hive/pull/1099 but I cannot yet get it to work. The file watcher doesn't seem to see any changes, it seems to be restarting itself, but it never kills the deprovision pod.

This is a second implementation instead of #1099 but I cannot yet get it to work. The file watcher doesn't seem to see any changes, it seems to be restarting itself, but it never kills the deprovision pod.

If it is working properly, I do not think that the sidecar container should ever restart.

This is a second implementation instead of #1099 but I cannot yet get it to work. The file watcher doesn't seem to see any changes, it seems to be restarting itself, but it never kills the deprovision pod.

If it is working properly, I do not think that the sidecar container should ever restart.

Oops, ignore that. I think it does restart when the PID changes.

Got past problem 1 which was mounting the cred secret into the filewatch container, it actually expects the files to be in the container with the pid we will kill.
Unfortunately problem 2 looks worse, this code appears to be written for processes that never end, it will kill the pid but the pod stays up and that container just restarts. If the deprovision is successful, the file watcher goes into an infinite loop looking for the pid that no longer exists. There's no way to exit this as far as I can see. We're going to need to patch it or write our own filewatcher module. Maybe copy and modify.

Giving up on this approach, it's been days of attempts and I still can't get the IPC right even after forking library-go's watcher and trying to modify it for non-permanent processes (and I haven't found a way yet that I think they'll accept and works). Latest progress is in this branch but the code still can't detect when the process is completed, it's probably fixable but it's gone on way too long.

authors: dgoodwin staebler

repo: openshift/hive


text:
Deploy on Openshift ignores any choices made previously after Sign-In button is pressed

should be fixed now the state is stored in the url wizard/launchpad-new-project/3/<encoded-state>

I think this might be fixed, but let's be sure when we re-enable auth.

It is fixed. Good job!

authors: ALRubinger edewit gastaldi

repo: openshiftio/launchpad-frontend


text:
Unified macros for defining static bignums

This looks good to me.  @dot-asm and @ekasper , what do you think?  I like that it replaces cut/paste with a unified approach.

While converting bn_consts might be good idea, bn_pack2 implementation is not right. It was already shown that packing by 0x##af is error-prone, see RT3165 and 2df9ec01d563f9cc2deab07e8c3391059d476592. On  we see mention of ##ULL in bn_pack2, but not here. ULL is getting archaic, but it seems that it was corrected already after feedback on the list[?].
As for "might be". What is suggestion for bn_const.c exactly? To replace call to BN_bin2bn with call to BN_copy or BN_dup. This means that we don't win anything in memory footprint (nor "protect" the said constants by placing them to read-only segment). But we loose something. Comparing RFC text and code (or re-pasting from RFC through regexp) text becomes more challenging than it is now. What I'm saying is that it makes lesser sense [to me] to change bn_const.c unless we win something tangible, e.g. ensure that BN_get_* callers can handle BN_FLG_STATIC_DATA and return pointers to the original data instead of making copies.
Then I would also be reluctant to accept patch verbatim, but re-implement constant transform part myself. Because eyeballing can't catch bit replacements.  I'm not saying that there are any, but it probably inappropriate to assume that there may not be one. Nothing personal @huangqinjin. Unless of course it's confirmed that changing any bit in any constant in question triggers 'make test' failure. And I can't confirm this. While unification is a worthy goal critical BN constants has this unpleasant inertia :-(

As per comments from @dot-asm, this patch is not accepted so closing.

authors: dot-asm huangqinjin mattcaswell richsalz

repo: openssl/openssl


text:
Create region-ip-list.sh

Thank you for contributing to openstack/osops-tools-contrib!
openstack/osops-tools-contrib uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.

authors: fnzv openstack-gerrit

repo: openstack/osops-tools-contrib


text:
FW-527. Port CC1200dk

Why closing this PR? Please re-open so I can go through your code.

Thomas,
I wanted to add just the files related to the cc1200dk and not those of
silabs-32wg.
I just did another pull request.
Regards
2016-08-10 17:49 GMT+02:00 Thomas Watteyne notifications@github.com:

Why closing this PR? Please re-open so I can go through your code.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/openwsn-berkeley/openwsn-fw/pull/279#issuecomment-238910565,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKY91C6VPRelM1grjNwreXZbSqy7zNmNks5qefLvgaJpZM4JhLuu
.

--
Jonathan Muñoz
PhD student at Gridbee Communications & INRIA Paris
+33 (0) 6 59 05 93 83

sounds good. It's a good idea to add a description of wat the PR is, and a comment if you decide to close it.

repo: openwsn-berkeley/openwsn-fw


text:
Updates to gradle 2.13

lgtm
any particular new feature you are after?

Sorry I should have mentioned. Mainly this is maintenance, ie not falling
too far behind. Also there's supposedly a performance improvement. I'll
check logs to see if that helped at all.

performance has been erradic in general, so this might not change things on that note.

reverting this. Even with latest idea, the project no longer imports properly. will rev-lock for now.

authors: adriancole yurishkuro

repo: openzipkin/zipkin


text:
compilation of guestRegexp does not account for metacharacters

closed in #979

repo: oragono/oragono


text:
Add supports for Symfony 4

Coverage decreased (-3.03%) to 96.97% when pulling f60fb9fafba3562e43a1b970cf0d2d2280dd88ea on mcg-web:symfony_4 into cd76661539b17617c4e23999a891c1936cc162da on overblog:master.

Coverage remained the same at 100.0% when pulling 86834ab6353f3e89e11362f79a58b0358ac7feb2 on mcg-web:symfony_4 into cd76661539b17617c4e23999a891c1936cc162da on overblog:master.

Coverage remained the same at 100.0% when pulling 22d3b159d392431bee94d9bd682657cb5e11fa57 on mcg-web:symfony_4 into cd76661539b17617c4e23999a891c1936cc162da on overblog:master.

Coverage remained the same at 100.0% when pulling e91486f010e90fb78eac35e5c54f92ef67f62f88 on mcg-web:symfony_4 into cd76661539b17617c4e23999a891c1936cc162da on overblog:master.

authors: coveralls mcg-web

repo: overblog/dataloader-bundle


text:
LDAP support

@miremond @mmoayyed -> LDAP support (using Ldaptive)

:+1: This is good. Most of the code is very familiar to me, and I had one small comment.

Sorry, could not look at this earlier. Good job @leleuj

authors: leleuj miremond mmoayyed


text:
Add @PATCH annotation to support HTTP PATCH method

@uschi2000 @markelliot
We use PATCH methods on our server, so this adds support for annotations here. I'm more confident that this makes sense in http-remoting, but if not we can just include this in our API project as well.
DropWizard and OkHttp both support this, so the addition of this annotation is sufficient to properly support this from a client perspective (and verified that in unit test and against local server).

Cool, so I think the annotation ought to live in its own project, though, or to use this annotation on a server project we end up taking the dependency on the clients project.

Got it -- will make the change for the next review

Moved the PATCH file to its own project. Also, found that DropWizard basically implements this exact same annotation in the same way in io.dropwizard.jersey.PATCH. This change may still be relevant since asking all clients to import DropWizard doesn't make much sense, but just FYI.

Interesting. I guess we could actually skip adding this since users who want PATCH can use it successfully by defining this annotation or borrowing dropwizard's. Less clear that we should be including it given there's another library out there?

Since the annotation is so small/easy to define, I'm not opposed to leaving it to clients to do it. For an API project like mine I don't think I want to pull in io.dropwizard.jersey just for the annotation, but fine re-defining it. PATCH is also probably rare enough amongst our projects right now that it doesn't really matter. Will close this out for now, but may be worth re-considering if we find numerous projects having to re-define it.

Yep, makes sense, thanks.

authors: markelliot nmiyake

repo: palantir/http-remoting


text:
feat: lists now have proper count when the list is filtered

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: panter/ra-data-prisma


text:
Release 1.1.0

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #28   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           3      3
  Lines          48     48
  Branches       12     12
=====================================
  Hits           48     48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4663666...f5c20d1. Read the comment docs.

authors: andrenarchy codecov-io

repo: paperhive/envfefe


text:
Gallery tweak

hmm, this isn't the branch i thought it was.

repo: participedia/frontend


text:
Front-End UploadFile Add

Current coverage is 51.27%

Merging #58 into master will not affect coverage as of 15602ab

@@            master     #58   diff @@
======================================
  Files          113     113
  Stmts         1295    1295
  Branches        94      94
  Methods
======================================
  Hit            664     664
  Partial         17      17
  Missed         614     614

Review entire Coverage Diff as of 15602ab

Powered by Codecov. Updated on successful CI builds.

authors: Calgooon codecov-io

repo: pbremer/ice-cream-manager


text:
GITW/TDO summary displays improperly for Xfers

Pull request #126

repo: pdarg/tmlpstats


text:
CSV output of query: use extension?

No. Create a table from the query and use its CSV output.

repo: pekrau/Pleko


text:
[BACKLOG-12233] Change PDI icons

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f ui/build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f ui/build.xml jacoco-integration checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  ui/package-res/ui/images/CNC.png
  ui/package-res/ui/images/CNC.svg
  ui/package-res/ui/images/CNC_tree.png
  ui/package-res/ui/images/CNC_tree.svg
  ui/package-res/ui/images/slave.png
  ui/package-res/ui/images/slave.svg

authors: AlexanderBuloichik wingman-pentaho

repo: pentaho/pentaho-kettle


text:
Improve performance by memoization technique

Not so much improvement than expected..let me close 🤔


text:
release 0.12.1

Hi @estebanlm . I think it should be 0.13.0 because it is not minor change.

oks

I tried an image with this PR integrated and go no problem.

authors: dionisiydk estebanlm jecisc

repo: pharo-ide/Calypso


text:
[#7654] Async support SDK

How about renaming the package name for the java SDK?

Maybe I will do it like below.
import com.navercorp.pinpoint.sdk.v1.concurrent.xxx;

I plan to use the delegate pattern as much as possible.
    public void test1() {

        ExecutorService executorService = TraceExecutors.wrapExecutorService(Executors.newSingleThreadExecutor());

        executorService.execute(TraceRunnable.wrap(new Runnable() {
            @Override
            public void run() {
                // action
            }
        }));
    }

However, ForkJoin class has a problem that cannot be delegation
    public class ForkJoinPool extends AbstractExecutorService {
              public <T> ForkJoinTask<T> submit(Callable<T> task) {
              }
    }

There is also a way to use Annotation. This does not require any SDK dependency.
// If the annotation class name is configurable, no SDK dependencies are required.
profiler.trace.asynctrace.classname=x.y.z.AsyncTrace

@AsyncTrace
public class MyRunnable implement Runnable {
     public void run() {
         // action
     }
}

repo: pinpoint-apm/pinpoint


text:
Update release notes and product snapshot for v1.2.2

@zhongz is added to the review. #Closed

Thanks @bingosummer

authors: bingosummer jncd

repo: pivotal-cf/docs-azure


text:
replace DEA references with appropriate Diego equivalents

All the changes from cwlbraa were "manually" merged (i.e. copied) into the pre-release branch of this docs-ops-guide repo. This is why it this request appears as "Closed" instead of "Merged", even though the content has been added.

authors: cwlbraa jncd

repo: pivotal-cf/docs-ops-guide


text:
persist api

Coverage decreased (-1.06%) to 96.591% when pulling 07917f8a94f12c194144b6bfb264047839b843d9 on persist-api into e8db5fbad738cd3836c1a4d50ca7714d3a150c17 on master.

Coverage decreased (-1.06%) to 96.591% when pulling 0b87f4e95c6482d152b1aecccf67647093ad96b8 on persist-api into e8db5fbad738cd3836c1a4d50ca7714d3a150c17 on master.

Coverage decreased (-1.06%) to 96.591% when pulling 07917f8a94f12c194144b6bfb264047839b843d9 on persist-api into e8db5fbad738cd3836c1a4d50ca7714d3a150c17 on master.

authors: codyspring coveralls

repo: playsavage/savagedb


text:
Crud update filtering draft

Ah also, just had one more though: Let's also somehow include the actual available TypeScript types that are generated for a sample data model: https://www.prisma.io/docs/reference/tools-and-interfaces/prisma-client/crud#type-1

🔥🔥🔥

authors: mhwelander nikolasburk


text:
[PoC] JTAG support

Now the JTAG driver uses SPI for one specific case: long byte-wise transfers. This includes:

JTAG chain scans
ECP5 SRAM programming
ECP5 flash programming
ECP5 flash readout

In all the other cases the bitbang mode is used.
With ecpdap and --freq 50000 it uses 27MHz TCK frequency and SRAM programming speed is about 1MByte/s.

repo: probe-rs/hs-probe-firmware


text:
include fs2-rabbit-testkit in root aggregate so that it gets published

There you go 0.0.0+1-8778c704-SNAPSHOT :)

Thanks!

authors: bpholt gvolpe


text:
Remove a few non-deferred stringifications

LGTM

I thought I had a good regex for tracking these down but it didn't find these ones!

authors: alexwlchan fasaxc

repo: projectcalico/calico


text:
Ipam

@robbrockbank Could you take a look at this? Still work to do on the tests but would be good for you to take a look.

LGTM, I don't have anything.
Obviously there are a few tweaks required when we have actual releases of stuff, but otherwise this looks good.

@robbrockbank I plan to merge this as soon as I get the tests passing. Do you want to take a final look before I do?

LGTM (very minor comments)

authors: robbrockbank tomdee

repo: projectcalico/libnetwork-plugin


text:
Different fonts supported for header, week and day By IvoPintodaSilva

Closing in favor of #782

authors: anasanasanas tevjef


text:
Fix CI failures for pypy3.

@Skeen Something has broken here and I haven't the knowledge of asgi/twisted to figure out what. Would you mind taking a look?


text:
[DO NOT MERGE] (FACT-1272) Create facts schema translation tooling

CLA signed by all contributors.

repo: puppetlabs/facter


text:
(FACT-2220) Add Aix disks fact

CLA signed by all contributors.

jenkins please test this on aix61-POWERa

jenkins please test this on aix61-POWERa

authors: oanatmaria puppetcla


text:
Generalize unions

:+1:

authors: garyb hdgarrood

repo: purescript/purescript-maps


text:
[NO-ISSUE] Updated to rc2 images

Good point, in that case I'll probably close this PR and do that in a separate branch.

repo: purestorage/pso-csi


text:
added a userID arguement to the SU token generation helper

I'm going to hold off merging this until the auth work around su tokens has been finalised, this may not be needed.

repo: pusher/chatkit-server-go


text:
Workshop leaders info

deployed


text:
作者大大，现在是停止维护了么，文档进不去了

没有停止维护，文档恢复了，谢谢反馈。

文档又挂了

最近有点忙，有问题加我微信进群聊吧，元旦后着手恢复。 @Coneboy-k

authors: Coneboy-k mengxianglong123 qbhy

repo: qbhy/poster-generater


text:
Implement JSON serialization protocol for common channels

Done.

woo

Automerge cancelled: A status check is failing.

Windows build failed with no output.

That's the threading flake that @c-poole is working on. Just re-start it.

Automerge cancelled: There are merge conflicts.

authors: CirqBot Strilanc kevinsung mpharrigan

repo: quantumlib/Cirq


text:
想问下，那个manage.py在哪里啊？

你好，这是一个app，因为不是一个单独的django项目，所以没有manage.py


text:
Add query parameter to toggle biolink hierarchy traversal

Batching (#149) will help alleviate the computational headaches, and KPs should universally support biolink inference soon.

repo: ranking-agent/strider


text:
Единый дизайн (текстуры и скины)

тайлсет уровня ,скин врага ,скин игрока , скин факела


text:
Fixed bug where onRemove would only be used if onSet is also defined

Great catch thanks for the fix!

authors: eXon iszak

repo: reactivestack/cookies


text:
Added links to the Profiler deep-dive YouTube video

Meh 😄 I'll revert or modify if there are later suggestions.


text:
refs fix for swif 3

hello, @nguyenvandungb
You can use version 2.02 for swift3

repo: recruit-lifestyle/Smile-Lock


text:
Finished adding quote resquest handling functions

Why does it keep complaining the diff with no diff?

                               common::IMA_ML_STUB.to_string()

                               common::IMA_ML_STUB.to_string()

FWIW, I think it was probably a whitespace (tabs vs. spaces) issue, but glad you got it resolved.

repo: redhat-university-partnerships/keylime


text:
Add url link to releases page to readme

@ISSOtm Took me a few attempt to get the rst syntax correct (I probably should have gone with a newline :)). I believe you can squash the commits in the merge on GitHub, will that work?

Yes, that will. I'm going to merge without further review because the changes are fairly small.

(Checkpatch is failing because one interim commit has some trailing whitespace, but this will get absorbed by the Squash and merge, I checked by squashing locally.)

repo: rednex/rgbds


text:
docs: helm addon proposal

I added updates to this doc based on using Helmfile if anyone would like to re-reviewing. I think the only controversial thing might be shipping rendered yaml in the airgap case instead of archived charts.

I think this served it's purpose, this feature has been in beta for some time, and we need to decide if we want to remove or promote.

repo: replicatedhq/kURL


text:
use a git source for refinerycms-testing gem only if we specify edge

I am reopening this pull request with a clean history forked from resolve/refinerycms - there was probably an issue with the fork I had done the work on since prior to today I was working on enmasse-entertainment's fork.

repo: resolve/refinerycms


text:
Rhasspy dockerfile still uses 2.5.7

Fixed now with 2.5.10, thanks!

authors: synesthesiam thetic

repo: rhasspy/hassio-addons


text:
Mention 'debinate build' alongside init, package, clean

I'd prefer build to stay in its own section for now because it encompasses things outside of the Python use case.

authors: Brent-Knight-BL rholder

repo: rholder/debinate


text:
#86 - Test to ensure milliseconds are ignored as ISO 8601 specify

Fixes #329

LGTM.

thanks, @apupier !

authors: apupier rhuss

repo: rhuss/jolokia


text:
Features 4, 5, & 6

@sblack4 Are you not going to address the health_check_path then? I'm surprised you're requesting re-review without that changing.

@sblack4 Are you not going to address the health_check_path then? I'm surprised you're requesting re-review without that changing.

@smiller171 copied from my reply above

I like the idea of codifying that logic but if I forget that TCP can't have a health check I'd rather have it throw an error and remind me, not silently fix it for me. It's not like it gives me the option of not specifying health_check.path. Because it's an object I'll have to pass something in.

@smiller171 copied from my reply above

I like the idea of codifying that logic but if I forget that TCP can't have a health check I'd rather have it throw an error and remind me, not silently fix it for me. It's not like it gives me the option of not specifying health_check.path. Because it's an object I'll have to pass something in.

I missed that reply, and agree with your conclusion.

I missed that reply, and agree with your conclusion.

repo: rhythmictech/terraform-aws-alb-ecs-task


text:
lesson 2 _ test 2

Thanks

repo: ring-lang/ring


text:
Hotfix/removes unused arg

All good @jhuliano ! :+1:

authors: jhuliano rmariuzzo


text:
use "escapeshellarg" (1.3.5 release)

See #110

repo: rosell-dk/webp-convert


text:
Typo: Contibuting => Contributing

You're welcome. RTD rocks, keep on the good work !


text:
Macro uses

The statements proposal mentions the use of macros in statements.
We need to cover a few different cases here: macros with () as statements ("use them like a function call"), macros with () as expressions ("use them like a function call"), macros with {} as statements ("use them like a block"), and macros with {} as expressions ("don't").

The interesting (difficult) question is how to format the 'argument' to a macro, since these can be any sequence of tokens.

@nrc True.  And that then raises the question of how opinionated we want to be on that.
I see two options: either we suggest style for what kinds of tokens you should use in a macro, or we don't and have to write a style that allows an arbitrary bag of tokens.
I'd lean towards the latter to avoid becoming too prescriptive about macros.  And we can argue that sufficiently popular and widespread macros may need special-cases in rustfmt.

One such common case which could warrant dedicated handling is vec!. Because from a user's point of view, it does the same thing as an array constructor, it should be formatted identically.

In several other issues we've said that certain kinds of macro should follow their formatting. I want to note an exception here (and perhaps some more in the future):
when formatting a macro use, Rustfmt should not insert or remove trailing commas (or other punctuation) because these can be semantically significant in macros.

@nrc Agreed, though we should also recommend in the style guidelines that function-like and initializer-like macros should accept trailing commas.

Closed by #110

authors: HadrienG2 joshtriplett nrc

repo: rust-lang-nursery/fmt-rfcs


text:
Added more changes, replaces #546

Thanks!

authors: adamnemecek sebcrozet

repo: rustsim/nalgebra


text:
merge -> assign

@AmilKey mind doing a rebase?

@stefanpenner done

@AmilKey you missed another merge on line 144.

Closing this in favor of the refactoring done in #40.
Thanks for the PR though! Keep 'em coming!

authors: AmilKey scalvert stefanpenner

repo: rwjblue/ember-lifeline


text:
SAK-41622 Update cloud-content to jclouds 2.1.2

I'm testing the new version locally, set as WIP.

Verified in my local environment, works as expected.

repo: sakaiproject/sakai


text:
Add instruction following

Basic instruction following has been added; folding into main develop branch.

repo: salvucci/think


text:
Fixed #484

Amazing, thanks @idok! This is great news! I don't know why coveralls is even reporting that as a problem. @Snugug could you just force merge this anyway? I don't have access to temporarily disable it.

I have no idea why that failed. Temporary disabled.
@idok Please look through our contributing guidelines and ensure that your PR matches our process (specifically developer cert of origin)

Thankyou @idok

authors: DanPurdy Snugug idok

repo: sasstools/sass-lint


text:
bump util, lm, and zinc

Forward-porting the TestConsoleLogger into develop as a part of #4616.

repo: sbt/sbt


text:
Fix #2357: Implement printing for ir.PropertyDef

Review by @sjrd

That's all.

Updated

LGTM

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3104/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4030/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/3103/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/4029/
Test PASSed.

authors: gzm0 scala-jenkins sjrd

repo: scala-js/scala-js


text:
Clarify PGP key usage

逼比

逼比


text:
added my name to guestbook.md

Thank you!

authors: AliciaTsai seankross

repo: seankross/the-unix-workbench


text:
Implement week view

Fixed in caaddeb


text:
FragmentEndpoint: Fragments loosing transitions after configuration change

Closed with prototype 0.2.0 #49

repo: sellmair/kompass


text:
Add Dataloader on a per-request chaching basis

prefetching dev.apollodata.com/react/prefetching.html

todo: research on prefetching and dataloader (same or totally different concepts)

It's quite different. Dataloader helps to avoid duplicated request
For example when fetching a list of projects with the author the author could be the same. Instead of doing 10 requests to fetch the author with dataloader we can make sure to fetch only one. In fact dataloader will fetch all the authors and properly inject them to the right project.

repo: serverless/serverless-graphql-apollo


text:
Better errors

https://doc.rust-lang.org/book/error-handling.html#error-handling-with-a-custom-type
Be smarter with the error.

repo: sevagh/pqrs


text:
Reworked GCP support for multinode CI.

Sigh. This pull request is against the wrong branch.

repo: shakenfist/shakenfist


text:
[fix] gws/facility: show readable items (m42)

Coverage increased (+0.08%) to 79.499% when pulling a518245f39a8f153553a3987725511edce3cabb7 on tany:gws-m42 into 57957a745d710637c760cd60a4926f16e280cc7f on shirasagi:master.

authors: coveralls tany

repo: shirasagi/shirasagi


text:
awesome library! shall we need option to disable VolumeMeter value blink?

Thanks. Instead of adding an option to enable/disable it, I removed the blink function in volume meter totally. For all widgets, there is actually an Alert function now which you can use to display a blinking alert dialog on and off.

that's awesome, thanks.

authors: postgetme shzlw

repo: shzlw/zeu


text:
Turn off prints

Have a flag that turns off printing

repo: sifive/Kami


text:
Added driver auto generation directions

I pushed a couple commits to get this to line up more with the current version of the library and the interfaces. If you guys could take a look and provide feedback, that'd be great.
Also, I completely changed the example that used to show how to set a CFLAG to parameterize the base address of the PIO block because that doesn't make sense anymore with the driver code and autogenerated BSP. https://github.com/sifive/block-pio-sifive/pull/22/commits/79a015fee3f13d42c6ea9c28524235377fed734e Please take a look at that as well.

authors: richardxia sistillson

repo: sifive/block-pio-sifive


text:
add response builder

Codecov Report

Merging #39 into master will increase coverage by 0.41%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #39      +/-   ##
============================================
+ Coverage     92.73%   93.14%   +0.41%
- Complexity       96      100       +4
============================================
  Files            16       17       +1
  Lines           234      248      +14
============================================
+ Hits            217      231      +14
  Misses           17       17

Impacted Files
Coverage Δ
Complexity Δ

src/Builder/ResponseBuilder.php
100.00% <100.00%> (ø)
4.00 <4.00> (?)

src/EventListener/HTTPErrorListener.php
100.00% <100.00%> (ø)
4.00 <0.00> (ø)

src/EventListener/ResponseTransformListener.php
100.00% <100.00%> (ø)
6.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 394d788...25a1ba9. Read the comment docs.

authors: codecov-io simon-schubert

repo: simon-schubert/terry-api


text:
Catch up to latest jQuery commits

That's correct... it being a jQuery fork, there's a default template that I didn't bother to delete or remove.

repo: skuid/jquery


text:
Extract error handling to middleware

I assume the idea here is to delegate error handling to a middleware else to PHP itself outside of the Slim app context. For the middleware, do we intend for that to be a diagnostic-type error handler that reports the stack trace? Or did we intend for that to be a production-ready middleware (e.g. "something went wrong, we're on it")? Or perhaps two separate middlewares?
/cc @akrabat @silentworks @geggleto

In my own experiences having 2 middlewares turn out to be impractical because it would mean having to build 2 different "HTTP stacks" (list of middlewares & routes) for dev or prod.
If that's of any interest here is what I did: a single error handler middleware that would ask a responder to generate a response: the responder injected in the middleware would depend on DIC configuration (https://github.com/stratifyphp/error-handler-module/tree/master/src/ErrorResponder). That implies not instantiating the middleware directly but rather relying on a DIC, else we are back to the problem I mentioned above.

@mnapoli That's a good point.

I'd like to apply middleware after error handler is triggered.
My use case is adding CORS headers in REST API.
At this moment I can easily add middleware to group routes, but when returing response Not Found, I have to add CORS headers within error handler.
I'm mentioning it here is because I believe that wrapping middleware around error handlers by makes more sense to me thatn wrapping error handlers around middleware.

authors: codeguy mnapoli piotr-cz

repo: slimphp/Slim


text:
slight performance improvement by caching regex

Just curious, have you run any benchmarks on this? I would be really surprised if V8/spidermonkey don't optimize this out already.

I only did it because it's getting run in a loop (especially if you have a
deep DOM). It's definitely "slight" but overall it is faster:
http://jsperf.com/regex-performance-testing/16

I'm officially surprised. Thanks!

authors: philfreo slindberg

repo: slindberg/jquery-scrollparent


text:
TypeScript definitions

Looks good to me, thanks!

I am not a typescript user, but after some testing I found a few issues with these definitions:

Nothing.length = 2 // Cannot assign to 'length' because it is a constant or a read-only property. - it should be assignable though, this is related to all props
Nothing.anyProperty = {} // Type '{}' is not assignable to type 'INothing'. - any property should allow assigning to anything
(p1: any, p2: any, p3: any, ...): INothing - all these declarations can be replaced by (...args: any[]): INothing
Nothing().call() // Expected at least 1 arguments, but got 0. - should allow any number of arguments

As a summary, I think it's better to replace all TS declarations with something like this:
export declare const Nothing: any
export declare function toBool (p: any): boolean
export declare function isNothing (p: any): boolean
export declare function isSomething (p: any): boolean
export declare function serialize (p: object): string
export declare function deserialize (p: string): object

Otherwise, it's too restrictive and has a lot of edge-cases.

1-4 cases good catches and should be fixed.
export declare const Nothing: any

I think it's bad idea. any so weak. It's almost equal to case, where no definitions totally.
Better to pick Nothing as particular nominal type and operate with it.
export declare function toBool (p: any): boolean
export declare function isNothing (p: any): boolean
export declare function isSomething (p: any): boolean

This has the meaning for older TypeScript versions without conditional types. Now, with conditional types and Nothing as particular nominal type, you can achieve more robust behavior from compiler.

Ok, I investigate 1-4 problems:

It's native lib.d.ts TypeScript definition and can't be fixed:

interface Function {
    readonly length: number;
}

Interface INothing extended from Function interface, because it callable.

Seems TypeScript not support co/contr-variance of interface properties, like FlowType. It assume "mono-type" on input/output. In our case it INothing. This can be easy fixed via Nothing.anyProp = {} as any. So popular practice.

It's understand, ok.

This related to (1). Also lib.d.ts, thisArg required.

interface Function {
    call(this: Function, thisArg: any, ...argArray: any[]): any;
}

My opinion, a little embarrassing (2) case. But it's not problem for extended TypeScript user.
If it discouraged you, feel free to use own suggestion with any

Thanks for the explanation! I guess I'll do the change as the current definitions have too strict restrictions in some cases, IMHO.

authors: darky slmgc

repo: slmgc/Nothing


text:
Sane splitting

This PR removes the behavior to split commands by whitespace by default. Instead it introduces two now ways to do that:

A Split newtype wrapper around &str.
Allowing to use str::split, str::split_whitespace or str::split_acsii_whitespace.

I think I'd like to only add one of the two options. Any opinions, which one?
Also, I'm not super happy with this overall. I think that e.g. cmd!("command --foo", some_argument, "--some-config true"); is just much better than cmd!("command --foo".split(' '), some_argument, "--some-config true".split(' '));. :/

This PR removes the behavior to split commands by whitespace by default. Instead it introduces two now ways to do that:

A Split newtype wrapper around &str.
Allowing to use str::split, str::split_whitespace or str::split_acsii_whitespace.

I think I'd like to only add one of the two options. Any opinions, which one?

I think I like Split a little bit more, since it's consistent with everything else in the library. However, .split can be used with different delimiters, which might be useful, and it doesn't require learning a new thing. I'm torn. I would probably add both, since I don't think there's a huge downside, but if I had to only add one it would be .split.

Also, I'm not super happy with this overall. I think that e.g. cmd!("command --foo", some_argument, "--some-config true"); is just much better than cmd!("command --foo".split(' '), some_argument, "--some-config true".split(' '));. :/

You could also write it like this:
cmd!("command", "--foo", some_argument, "--some-config", "true");

I agree that this is a little worse, but I suspect that string splitting bugs will be inevitable otherwise, and will be difficult to track down, and crop up unexpectedly. For example, a utility is only tested with paths without spaces, but a user then uses it with paths with spaces, triggering splitting and causing bugs.

An additional way that users can avoid needing to split strings is by using = to separate options and values, if the command supports it:
cmd!("command", "--foo", some_argument, "--some-config=true");

I agree that this is a little worse, but I suspect that string splitting bugs will be inevitable otherwise, and will be difficult to track down, and crop up unexpectedly. For example, a utility is only tested with paths without spaces, but a user then uses it with paths with spaces, triggering splitting and causing bugs.

Yeah, I completely agree. This is especially bad in a language like rust where programmers rely on the type system to catch bugs like that.
I'm pretty convinced we should merge this.

I think this looks good!

I had some thoughts about the clones, but I think those are really only performance concerns, so I'll open an issue.

authors: casey soenkehahn

repo: soenkehahn/cradle


text:
Include contribution guidelines e.g. how to create issue, pull requests (or new features), code conventions etc. (can be part of documentation or in the README)

Close by #151.

authors: DevasenaInupakutika rgaiacs

repo: softwaresaved/fat


text:
Typo: "cahced" (cached)

Hi @DazWilkin, thanks for the contribution! It looks like this PR resolves https://github.com/solo-io/wasme/issues/77, could you please add a changelog file for the next release (0.0.21)? The folder for that release is here - https://github.com/solo-io/wasme/tree/master/changelog/v0.0.21, the type of this change would be "FIX". Let me know if you have any questions.

Done

authors: DazWilkin Sodman

repo: solo-io/wasme


text:
Com 742

Tu peux faire en sorte que ca ne se wrap pas dans les select stp ?

Desolee je viens de voir autre chose, si l'adresse est trop longue on ne voit pas la fin sur mobile

authors: cmolle sophiemoustard


text:
Log

#2

repo: sornas/mum


text:
Wrote more tests

Pull Request Test Coverage Report for Build 75

23 of 28 (82.14%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+10.9%) to 68.781%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

awesimsoss/awesim.py
23
28
82.14%

Totals

Change from base Build 74:
10.9%

Covered Lines:
824

Relevant Lines:
1198

💛  - Coveralls

repo: spacetelescope/awesimsoss


text:
Fix party tests

BK stuff still failing!

repo: spatialos/online-services


text:
Import errs package

requre go 1.13

repo: spiegel-im-spiegel/mklink


text:
fixed management.context-path placeholder name

@jpuzzler Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@jpuzzler Thank you for signing the Contributor License Agreement!

authors: jpuzzler pivotal-issuemaster

repo: spring-cloud/spring-cloud-consul


text:
Add CheckStyle, travis; Fix Outbound, Add Tests

Since we are here already we can upgrade to sonarqube plugin:
The 'sonar-runner' plugin has been deprecated and is scheduled to be removed in Gradle 3.0. please use the official plugin from SonarQube (http://docs.sonarqube.org/display/SONAR/Analyzing+with+Gradle).

Pushed - I'll open an issue to move those utility methods.

Merging...
But wrapper should be run during Gradle upgrade anyway.

Merged as https://github.com/spring-projects/spring-integration-kafka/commit/8fc05005d1615b9cb2ece736147c204e29eae1cb

authors: artembilan garyrussell


text:
testing mmap

discarded

repo: sscit/rel


text:
Add temperature support for MCCGQ11LM

The MCCGQ01LM uses the same adapter but does not seem to have a temperature sensor. So I think think a separate adapter is needed. Already have it running on my setup and I could make it a pr if you want. Note that the temperature reading is about 4 degrees to high on both my MCCGQ11LM.

Didn't think about the dependency, makes sense to create a different adapter then.. will you take care of this @d-EScape?
I also have some deviations in temperature on some devices, some have +3, some -4, but this can be managed in the configuration.yaml via the temperature_calibration feature.

Good tip about calibration, thanks. Didn’t think of that.
I will push a pr this weekend.

I submitted PR #566
You should probably close this one, otherwise they might both be merged.

Onsolete due to PR 566

Implemented in #458

authors: d-EScape martin-g-it stas-demydiuk


text:
chore: try upgrading solidity to 0.7.4?

blockers:

we need a new image on circle with upgraded solidity (easy, and done)
ethereum-waffle/compile@latest only installs solc@0.6. It throws errors if I try and force it to use 0.7.x via yarn resolutions. We get the errors on importing solc: so setting USE_NATIVE_SOLC=true is not a successful workaround (and would require all devs to install native solc anyway).

see #2895 for an alternative approach, which leans on the incoming hardhatpackage.

Should we close in favour of https://github.com/statechannels/statechannels/pull/2895 then?

yeah

authors: andrewgordstewart geoknee

repo: statechannels/statechannels


text:
Feature: save the scope of the user when he authorizes an app

Closing this branch because there is a simpler way to do that.
See store-scope-2 branch

repo: steemit/steemconnect


text:
entry/2019-12-17

This MR will close #260

repo: stephencweiss/personal-blog


text:
removed routes

IBM Cloud toolchain: Delivery Pipeline deployed products to prod, including commit e51c2166d4bfcdab8ffdf1bf09d8e2b7f4314eab

IBM Cloud toolchain: Delivery Pipeline deployed products to dev, including commit e51c2166d4bfcdab8ffdf1bf09d8e2b7f4314eab


text:
Fix bors

bors r+

ping

r+

repo: stiiifff/substrate-deps


text:
noor.html

Should be in src


text:
Updated Foluwa and contributors.md

fixed


text:
Disable html5 validation

I'm trying to understand the reasons of this change. Could you please elaborate a bit? Thanks.

I guess hason want to disable html5 validation to show users server validation messages.

But it will be confused developers because main purpose of this project is show best practices way, so they should not disable html5 validation in his projects.

What about to add comment at the beginning of form open tag (or I think better in form type) with tip that developers could use  'novalidate' => 'novalidate' } } or 'required' => false attributes if they want to see and check server validation messages?
@hason What do you think?

@bocharsky-bw I like your proposal to add a help note about this. I've done that in #100. Thanks.

Closing it in favor of #100

authors: bocharsky-bw hason javiereguiluz

repo: symfony/symfony-demo


text:
updates fixable message

Hi, thank you for your contribution.
                    Unfortunatelly, this repository is read-only. It's a split from our main monorepo repository.
                    We'd like to kindly ask you to move the contribution there - https://github.com/symplify/symplify.
                    We'll check it, review it and give you feed back right way.
                    Thank you

Hi, thank you for your contribution.
                    Unfortunatelly, this repository is read-only. It's a split from our main monorepo repository.
                    We'd like to kindly ask you to move the contribution there - https://github.com/symplify/symplify.
                    We'll check it, review it and give you feed back right way.
                    Thank you

authors: TomasVotruba jeroen-van-dijk

repo: symplify/easy-coding-standard


text:
fix: replace non exist site link to blog post

Thanks

repo: symplify/symplify


text:
Jest canvas snapshot serializer

IMO this pull request is old and should be closed.

closing as stale

authors: UziTech jmeinke nemanjasovic


text:
allow to render named parameters

I love how small of a change it actually was in Mojo.pm :) Lovely, thank you!

authors: tadzik ufobat

repo: tadzik/Template-Mojo


text:
Fix wrong directory path in explanation.

Thanks!

repo: tako-black/learnyoureact


text:
Removed unused template

Coverage remained the same at 64.893% when pulling 34003845f22acb05005399d5f1b42af3aaeabbc0 on laurpulk:remove-hellotemplate into 2229f5d462b0de48d2c896be7ed9b53f41c1f158 on tdd-pingis:master.

authors: coveralls laurpulk

repo: tdd-pingis/tdd-pingpong


text:
Fix camelCase of userLogin in the docs.

@luckydonald No, only userlogin in lowercase works. The case is usually ignored, but this is a special method where this is not possible. Please have a look at the respective code.

@luckydonald No, only userlogin in lowercase works. The case is usually ignored, but this is a special method where this is not possible. Please have a look at the respective code.

In that case it should be changed in the code to be camelCase. It really doesn't make sense to have a single endpoint work differently to all the others.

In that case it should be changed in the code to be camelCase. It really doesn't make sense to have a single endpoint work differently to all the others.

It's a bit of a mixture between an endpoint and the /bot or /user path part. I think having it lowercase is fine

It's a bit of a mixture between an endpoint and the /bot or /user path part. I think having it lowercase is fine

@code1mountain
If it would be /user/login I'd be all on board with you.
Most users would expect it to be like the telegram docs do it, camelCase.
The ability for lower case has not been documented, and are not widely known or used.

@code1mountain
If it would be /user/login I'd be all on board with you.
Most users would expect it to be like the telegram docs do it, camelCase.
The ability for lower case has not been documented, and are not widely known or used.

@luckydonald In the official docs of bot api is stated that all the methods names are case insensitive

@luckydonald In the official docs of bot api is stated that all the methods names are case insensitive

@skrtdev Ah yes. Indeed. Missed that. Still, I'd rather keep it similar to the documentation's casing.

@skrtdev Ah yes. Indeed. Missed that. Still, I'd rather keep it similar to the documentation's casing.

@giuseppeM99 merge?

@giuseppeM99 merge?

@andrew-ld the build failed (because GitHub), I just restarted it. Wait until it's completed.

@andrew-ld the build failed (because GitHub), I just restarted it. Wait until it's completed.

authors: MarcoBuster andrew-ld code1mountain luckydonald skrtdev

repo: tdlight-team/tdlight-telegram-bot-api


text:
database backup tasks

would be super awesome to add rolling backup functionality - save last 5 or 10 or whatever to somewhere.  Also to upload to AWS maybe? We'd need to find a place to put amazon credentials

:anchor:

authors: boatrite samsonasu


text:
Criar uma classe Deck

ok

repo: tenoriomatheus/PokerGameServer


text:
Travis CI: Make no change at all... Why do the tests fail??

Passes on retest


text:
Title of paper as clickable link

added commit to fix ubuntu sanity failure (line-too-long)

repo: tensorflow/tensorflow


text:
fix for Docker for Mac with 1.13

@rnorth locally build green as well

Nice! I'll test locally and aim to release ASAP.

authors: bsideup rnorth

repo: testcontainers/testcontainers-java


text:
Phoenix jjk

I'm not an authorized user to merge, but I added my review.

authors: PedalheadPHX bryce-turner


text:
Fix docblock comments

thanks :)

repo: themsaid/forge-sdk


text:
Fix

:tada: This PR is included in version 1.0.0-alpha.19 :tada:
The release is available on:

GitHub release
v1.0.0-alpha.19
v1.0.0-alpha.19

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
v1.0.0
v1.0.0

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
v1.0.0
v1.0.0

Your semantic-release bot :package::rocket:

repo: thygesteffensen/PowerAutomateMockUp


text:
feat: upgrade to probot v11.0.6

/hold
Do you integrate test these changes locally?

Do you integrate test these changes locally?

OK, let me test it.

To fix the typedi v0.9.1 upgrade issue，we temporarily use { fallbackOnErrors: true }.
Reference: https://github.com/typeorm/typeorm/issues/7267

To fix the typedi v0.9.1 upgrade issue，we temporarily use { fallbackOnErrors: true }.
Reference: typeorm/typeorm#7267

I think we can just keep the original version until that issue is fixed, because I don't know if there are any other issues yet.

I think we can just keep the original version until that issue is fixed, because I don't know if there are any other issues yet.

But you have updated typedi to v0.9.1 for a long time ago, or we need to downgrade it to v0.8.0.

But you have updated typedi to v0.9.1 for a long time ago, or we need to downgrade it to v0.8.0.

That is a misoperation, because I have already encountered this problem in the community and I have already rolled it.

OK, I will roll it back to v0.8.0.

But you have updated typedi to v0.9.1 for a long time ago, or we need to downgrade it to v0.8.0.

That is a misoperation, because I have already encountered this problem in the community bot and I have already rolled it.

cc: https://github.com/ti-community-infra/ti-community-bot/pull/207

Finish basic function test:

https://github.com/bot-sandbox/ti-challenge-bot-test/issues/13
https://github.com/bot-sandbox/ti-challenge-bot-test/pull/15#issuecomment-789538554

/unhold
I will take a look tomorrow.

🤣 This looks like an old bug: https://github.com/ti-community-infra/ti-challenge-bot/pull/291/commits/83d9dd4e626be9294aa48f523cbf51e0af537312
There may still be some problems with the current code. I need to spend some time to test it. When I tested ti-challenge-bot before, there was only one warehouse data, so it was not tested.

🤣 This looks like anancient bug: 83d9dd4
There may still be some problems with the current code. I need to spend some time to test it. When I tested ti-challenge-bot before, there was only one warehouse data, so it was not tested.

Sorry for the shit code I wrote.

/hold

@hi-rustin, I found that the picked_at time cannot be saved during the pick-up operation. The problem is caused by the toISOString function.
challengeIssue.pickedAt = new Date().toISOString();

new Date().toLocaleString()：2021-3-5 4:00:54 ├F10: PM┤  , which can't update to database.

new Date().toISOString()：2021-03-05T08:05:36.683Z. which can be updated, but exist timezone problem.

* which can be updated, but exist timezone problem.

Which kind of timezone problem?

Which kind of timezone problem?

I wrote wrong just now.
If we uniformly use UTC time in the database, there will be no problem. The standard time is stored in the data database, and it needs to be converted to local time when displayed on the front end.

/unhold
Ready to review.

repo: ti-community-infra/ti-challenge-bot

license: ISC


text:
Circleci project setup

Circleci test

d


text:
Make scripts pass with Standard JS code style 16.0.1

Thanks :-)

authors: d-r-q fenryxo

repo: tiliado/nuvola-app-yandex-music


text:
fix: Fix readme

Thanks for your contribution! :tada: :+1:

authors: gaocegege pokerfaceSad

repo: tkestack/elastic-jupyter-operator


text:
Fix copy; add some tests

Codecov Report

Merging #78 into master will decrease coverage by 0.75%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage    83.9%   83.15%   -0.76%
==========================================
  Files          17       17
  Lines        1112     1092      -20
==========================================
- Hits          933      908      -25
- Misses        179      184       +5

Impacted Files
Coverage Δ

src/processes.jl
90.2% <100%> (+2.09%)
:arrow_up:

src/reduce.jl
70.17% <0%> (-26.5%)
:arrow_down:

src/core.jl
68.21% <0%> (-0.18%)
:arrow_down:

src/show.jl
94.87% <0%> (-0.05%)
:arrow_down:

src/library.jl
93.48% <0%> (-0.02%)
:arrow_down:

src/dreduce.jl
100% <0%> (ø)
:arrow_up:

src/progress.jl
91.46% <0%> (+2.69%)
:arrow_up:

src/comprehensions.jl
90% <0%> (+20.76%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23624bf...1bd599e. Read the comment docs.

authors: codecov-io tkf


text:
Add some sway-specic fields

Try swayipc-rs instead, it works for i3 as well

authors: ammgws lbonn


text:
wayland: implement modifiers

The use case for this is to be able to implement keybindings such as
Ctrl-Shift-L etc. If you merge caps lock state into shift, then
Ctrl-Capslock-L would be equivalent to Ctrl-Shift-L which i believe is
wrong. As I implemented it ModifiersState.shift is only true when left or
right shift is held down.
On Fri, Mar 3, 2017 at 3:01 PM Victor Berger notifications@github.com
wrote:

@vberger commented on this pull request.
In src/api/wayland/keyboard.rs
https://github.com/tomaka/winit/pull/148#discussion_r104241615:

@@ -37,8 +38,19 @@ impl wayland_kbd::Handler for KbdHandler {
};
let vkcode = key_to_vkey(rawkey, keysym);
let mut guard = eviter.lock().unwrap();

// TODO implement ModifiersState

       guard.push_back(Event::KeyboardInput(state, rawkey as u8, vkcode, ModifiersState::default()));

       guard.push_back(

           Event::KeyboardInput(

               state,

               rawkey as u8,

               vkcode,

               ModifiersState {

                   shift: mods.shift ^ mods.caps_lock,

Actually, the X11 backend does not merge shift and caps lock modifiers.
This is IMO sensible, as most keymaps on linux react differently to shift
and caps lock.
However, the X11 backend here simply discards the caps lock state...
@rigtorp https://github.com/rigtorp did you chose this same behaviour
for all platforms?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tomaka/winit/pull/148#discussion_r104241615, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAK3a_sM4KcLRvinJJmns_V3LcyRkJBjks5riH-tgaJpZM4MRkxJ
.

Okay, I see. I'll mimmick that then.

authors: rigtorp vberger

repo: tomaka/winit


text:
Fix memory leaks & Fruther settings cleaning

I will merge this request when you have responded to my questions about branch renaming.
David

No question so far
Note : There is a load of changes upcoming , in order to fix the current setup.

do you understand what I mean about the branch renaming ?
You will have to send any more changes you have made, I merge them, then you make no changes, advise me you are ready, I will make the branch name change, you will then need to checkout the netsync branch.
If you refuse to communicate it will all go wrong, do you understand ?
David

Please , don't get angry at every message.
(a) I have never got any "question" from you about branching.
(b) This is enormous work to clean the code and make things a bit more usable to add capabilities
Branch :No, this must be the master. The code need complete overhaul et this is what is in this PR

(a) I have never got any "question" from you about branching.

Please see the message I posted at the end of 'discussion' in your last pull request -
https://github.com/tomboy-notes/tomboy-ng/pull/178
And duplicated in the issues list -
https://github.com/tomboy-notes/tomboy-ng/issues/141#issuecomment-622615247

(b) This is enormous work to clean the code and make things a bit more usable to add capabilities

Enormous indeed, but IMHO unnecessary.

Branch :No, this must be the master. The code need complete overhaul et this is what is in this PR

You cannot be allowed to submit code to Master. The one pull request you sent that targeted master that I (stupidly) let through took me a day to correct. Your code is alpha code, there is no way it belongs in master. End users and distro maintainers download that code and expect a working system. Code needs to be well tested before it goes to master.
At present you are sending pull requests to 'release', a branch I made to try and get 0.28 out but you targeted before I could even use it !  People expect stable, tested code in branches with names like 'master' and 'release'.  Yours is not stable, tested code.
I am sorry, I do think your whole approach is wrong.  You have submitted at most a few hundred lines of code that actually deal with the problem you are trying to solve. Instead, you jump around changing existing, working code that makes the whole project unstable.
I pushed my early attempt to  connect to grauphel (to master only, I don't push to your branch), its in experimental/netsync.  If you look at that, you will see how its possible to try to solve the target problems without being distracted by irrelivent things. I made little or no progress because I could not get OAuth to work but it shows you how to do focus on the target problem.
I am still waiting for you to advise me when I can rename your branch.
David

David
This PR implements Nextcloud from A to Z. You have it in front of you.
It cleans also all the inconsistencies in the code, including :
(a) Putting a proper standardized approach common to all "trans' : loading
data from remote in memory instead of copying useless filed
(b) Making the code able to handle multiple ServerID for sync without
breaking (i.e. one manifest per ServerID)
(c) Removing incorrect direct access to management data (NoteMetaData)
(d) Streamlining Clash management (improper loops)
(e) Adding the " Make copy" as in old tomboy
(f) Separating properly what belngs to local from what is from transport data
So you have the solution
It does need further testing , but the core changed are in place and
Nextcloud is working
On 4 May 2020 01:05:12 davidbannon notifications@github.com wrote:

(a) I have never got any "question" from you about branching.
Please see the message I posted at the end of 'discussion' in your last
pull request -
#178
And duplicated in the issues list -
#141 (comment)
(b) This is enormous work to clean the code and make things a bit more
usable to add capabilities
Enormous indeed, but IMHO unnecessary.
Branch :No, this must be the master. The code need complete overhaul et
this is what is in this PR
You cannot be allowed to submit code to Master. The one pull request you
sent that targeted master that I (stupidly) let through took me a day to
correct. Your code is alpha code, there is no way it belongs in master. End
users and distro maintainers download that code and expect a working
system. Code needs to be well tested before it goes to master.
At present you are sending pull requests to 'release', a branch I made to
try and get 0.28 out but you targeted before I could even use it ! People
expect stable, tested code in branches with names like 'master' and
'release'. Yours is not stable, tested code.
I am sorry, I do think your whole approach is wrong. You have submitted at
most a few hundred lines of code that actually deal with the problem you
are trying to solve. Instead, you jump around changing existing, working
code that makes the whole project unstable.
I pushed my early attempt to connect to grauphel (to master only, I don't
push to your branch), its in experimental/netsync. If you look at that, you
will see how its possible to try to solve the target problems without being
distracted by irrelivent things. I made little or no progress because I
could not get OAuth to work but it shows you how to do focus on the target
problem.
I am still waiting for you to advise me when I can rename your branch.
David
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Not to mention that I did not spent my weekend on this "for fun" or "for pride" or for any philosophical reasons, as you seems to accuse me of, but just because I need the nextcloud part to work.
Same as when you go to dentist, before replacing a teeth, you need to remove the old broken stuff. In this case, the numbers of broken parts was huge.
Please let's move forward .
I will continue testing next week-end, and provide additional commits.
About your 0.28, then branch out the actual master to a "0.28" branch in order to release it, and let the master move on new development. This is the normal way to work with Git

authors: davidbannon grosjo

repo: tomboy-notes/tomboy-ng


text:
Add clebsch_factors_iso and strength_factor methods

Pull Request Test Coverage Report for Build 173

105 of 105 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 92.095%

Totals

Change from base Build 166:
0.6%

Covered Lines:
1468

Relevant Lines:
1594

💛  - Coveralls

authors: coveralls tommyogden

repo: tommyogden/maxwellbloch


text:
修复composer包配置信息导致项目依赖冲突问题。

PHP Fatal error:  Uncaught TypeError: Argument 2 passed to PHPUnit_Framework_TestResult::addError() must be an instance of Exception, instance of Error given, called in /home/travis/build/toplan/phpsms/vendor/phpunit/phpunit/src/Framework/TestSuite.php on line 699 and defined in /home/travis/build/toplan/phpsms/vendor/phpunit/phpunit/src/Framework/TestResult.php:195

@toplan 这个要被merge吗？laravel 5.3 冲突 ，"jeremeamia/superclosure": "~2.2",   本地安装到了 2.3

authors: liyu001989 manlao medz

repo: toplan/phpsms


text:
Sphinx test

I approve.

repo: toros-astro/ProperImage


text:
Update pubspec dependencies to work with newest flutter version

@toufikzitouni could you please push the new version.

oops forgot about that. Just pushed to pub

Thanks

authors: The-Redhat toufikzitouni


text:
Add "City from" column in speaker list

We probably need to be able to customize which column should be showed. I am not sure of the best way to do that...

The transportation feature have been removed in v2

authors: bouttier numahell

repo: toulibre/PonyConf


text:
Small fixes

Codecov Report

Merging #94 into master will increase coverage by 0.61%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   88.24%   88.86%   +0.61%
==========================================
  Files          55       55
  Lines        1157     1167      +10
  Branches      113      114       +1
==========================================
+ Hits         1021     1037      +16
+ Misses         89       84       -5
+ Partials       47       46       -1

Impacted Files
Coverage Δ

...ivago/cluecumber/filesystem/FileSystemManager.java
52.94% <ø> (ø)
:arrow_up:

...mber/json/postprocessors/ElementPostProcessor.java
66.66% <100%> (+1.85%)
:arrow_up:

...ava/com/trivago/cluecumber/json/pojo/Argument.java
100% <100%> (ø)
:arrow_up:

...com/trivago/cluecumber/CluecumberReportPlugin.java
86.79% <0%> (+14.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad80983...58161dc. Read the comment docs.

authors: codecov-io laxersaz

repo: trivago/cluecumber-report-plugin


text:
Successfully use Filecoin Shipyard's Filscan Block Explorer with CLI

Looking into this project more, I don't believe this is worth the effort. Since you can use #694 to see the blocks, and more so use Ganache UI, I don't think using Filscan with Ganache is an applicable use case. Closing for now

Looking into this project more, I don't believe this is worth the effort. Since you can use #694 to see the blocks, and more so use Ganache UI, I don't think using Filscan with Ganache is an applicable use case. Closing for now

repo: trufflesuite/ganache-core


text:
Update README.md

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   84.29%   84.29%
=======================================
  Files          11       11
  Lines        1197     1197
=======================================
  Hits         1009     1009
  Misses        188      188

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c99361...529fdce. Read the comment docs.

Cimer :stuck_out_tongue:

authors: codecov-io jobot0 tsileo

repo: tsileo/little-boxes


text:
Restructure folder hierarchy

Source Code
~/tf2-mobile-pose-estimation
   ├── config
   |   ├── dataset
   |   ├── model
   |   └── output
   ├── data_loader
   |
   ├── models
   |
   ├── train.py
   ├── common.py
   ├── requirements.txt

Dataset
~/datasets
   ├── coco2017
   |   ├── train2017
   |   ├── valid2017
   |   └── annotations_trainval2017
   |       ├── person_keypoints_train2017.json
   |       └── person_keypoints_val2017.json
   ├── ai_challenger
   |   ├── train
   |   |   ├── images
   |   |   └── annotation.json
   |   ├── valid
   |   |   ├── images
   |   |   └── annotation.json
   |   └── README.md

Output
~/outputs
   ├── experiment001
   |   ├── logs
   |   |   ├── events.out.tfevents.1590810750.nipa2020-0851.12023.14386.v2
   |   ├── saved_models
   |   ├── tflite_models
   |   ├── coreml_models
   |   └── README.md
   ├── experiment002
   ├── experiment003