text:
race in test: TestIssue2746

TestIssue2746
WARNING: DATA RACE
Read by goroutine 171:
  github.com/coreos/etcd/raft.(*node).step()
      /Users/xiangli/go/src/github.com/coreos/etcd/raft/node.go:415 +0x7b
  github.com/coreos/etcd/raft.(*node).Propose()
      /Users/xiangli/go/src/github.com/coreos/etcd/raft/node.go:390 +0x152
  github.com/coreos/etcd/etcdserver.(*EtcdServer).sync.func1()
      /Users/xiangli/go/src/github.com/coreos/etcd/etcdserver/server.go:860 +0x98

Previous write by goroutine 7:
  github.com/coreos/etcd/raft.(*node).run()
      /Users/xiangli/go/src/github.com/coreos/etcd/raft/node.go:328 +0xf66

Goroutine 171 (running) created at:
  github.com/coreos/etcd/etcdserver.(*EtcdServer).sync()
      /Users/xiangli/go/src/github.com/coreos/etcd/etcdserver/server.go:862 +0x2a5
  github.com/coreos/etcd/etcdserver.(*raftNode).start.func1()
      /Users/xiangli/go/src/github.com/coreos/etcd/etcdserver/raft.go:229 +0x1296

Goroutine 7 (running) created at:
  github.com/coreos/etcd/raft.StartNode()
      /Users/xiangli/go/src/github.com/coreos/etcd/raft/node.go:203 +0x827
  github.com/coreos/etcd/etcdserver.startNode()
      /Users/xiangli/go/src/github.com/coreos/etcd/etcdserver/raft.go:315 +0xbb5
  github.com/coreos/etcd/etcdserver.NewServer()
      /Users/xiangli/go/src/github.com/coreos/etcd/etcdserver/server.go:320 +0x4318
  github.com/coreos/etcd/integration.(*member).Launch()
      /Users/xiangli/go/src/github.com/coreos/etcd/integration/cluster.go:543 +0x72
  github.com/coreos/etcd/integration.(*cluster).Launch.func1()
      /Users/xiangli/go/src/github.com/coreos/etcd/integration/cluster.go:141 +0x2e

@xiang90 which test is this?

@heyitsanthony Sorry. Updated.

WARNING: DATA RACE
Read by goroutine 465:
  github.com/coreos/etcd/etcdserver/stats.(*ServerStats).BecomeLeader()
      /Users/xiangli/go/src/github.com/coreos/etcd/etcdserver/stats/server.go:145 +0x37
  github.com/coreos/etcd/etcdserver.(*raftNode).start.func1()
      /Users/xiangli/go/src/github.com/coreos/etcd/etcdserver/raft.go:173 +0x684

Previous write by goroutine 347:
  github.com/coreos/etcd/etcdserver/stats.(*ServerStats).RecvAppendReq()
      /Users/xiangli/go/src/github.com/coreos/etcd/etcdserver/stats/server.go:105 +0xb8
  github.com/coreos/etcd/etcdserver.(*EtcdServer).Process()
      /Users/xiangli/go/src/github.com/coreos/etcd/etcdserver/server.go:503 +0x3c7
  github.com/coreos/etcd/rafthttp.startPeer.func1()
      /Users/xiangli/go/src/github.com/coreos/etcd/rafthttp/peer.go:144 +0x169

Goroutine 465 (running) created at:
  github.com/coreos/etcd/etcdserver.(*raftNode).start()
      /Users/xiangli/go/src/github.com/coreos/etcd/etcdserver/raft.go:234 +0x329
  github.com/coreos/etcd/etcdserver.(*EtcdServer).run()
      /Users/xiangli/go/src/github.com/coreos/etcd/etcdserver/server.go:529 +0x1f5

Goroutine 347 (finished) created at:
  github.com/coreos/etcd/rafthttp.startPeer()
      /Users/xiangli/go/src/github.com/coreos/etcd/rafthttp/peer.go:151 +0xa8d
  github.com/coreos/etcd/rafthttp.(*Transport).AddPeer()
      /Users/xiangli/go/src/github.com/coreos/etcd/rafthttp/transport.go:234 +0x4f2
  github.com/coreos/etcd/etcdserver.NewServer()
      /Users/xiangli/go/src/github.com/coreos/etcd/etcdserver/server.go:431 +0x317a
  github.com/coreos/etcd/integration.(*member).Launch()
      /Users/xiangli/go/src/github.com/coreos/etcd/integration/cluster.go:543 +0x72
  github.com/coreos/etcd/integration.(*cluster).Launch.func1()
      /Users/xiangli/go/src/github.com/coreos/etcd/integration/cluster.go:141 +0x2e

another one

repo: coreos/etcd


text:
etcd-tester: use Hash method to get both revision and hash

/cc @xiang90

lgtm

Will push this to https://github.com/coreos/etcd/pull/4504.
Thanks!

source: gharchive/pull-request

license_type: permissive

license_source: github-api


text:
Env file gets overridden by the systemd service

/run/flanneld/options.env
works fine for the first time, but when I reboot it's all gone

@aabed Can you describe your environment a little more? This is the systemd service file included in CoreOS right? Which version of Coreos did you see this problem on?

/run is usually tmpfs so will be gone on a reboot. If you want settings to persist, you will need to use /etc.

Closing as I'm not sure what the issue is. @aabed Please reopen if you're still having a problem here.

source: gharchive/issue

authors: aabed eyakubovich tomdee

repo: coreos/flannel

license_source: bigquery


text:
Document template units

I believe multiple instances for an unit should be possibly started using a single service file, such as:
fleetctl start --num 2 hello.service

Note: discussed in #302

The example above hangs for me as well.  bash expansion appears to be working
core@ztest01 ~ $ cat hello\@.service
[Service]
ExecStartPre=/bin/echo "hello world from %n"
ExecStart=/bin/sleep 600

core@ztest01 ~ $ fleetctl --version
fleetctl version 0.9.0

core@ztest01 ~ $ fleetctl start hello@{1..3}.service
^C       #hangs here till ctrl-c

core@ztest01 ~ $ echo {1..3}
1 2 3

core@ztest01 ~ $ fleetctl start hello@4.service
# hangs here as well

authors: gdoteof tiagoboldt

repo: coreos/fleet


text:
Etcd Registry clarity - Self hosted Kubernetes

I am unable to understand or find the /registry directory within the self hosted example, where the api server keeps all its state. Perhaps this is due to container linux etcd client being 2.3.7 or have i misunderstood.
cat ./etcdctl.sh
export ETCDCTL_CERT_FILE=/opt/bootkube/assets/tls/etcd-client.crt
export ETCDCTL_KEY_FILE=/opt/bootkube/assets/tls/etcd-client.key
export ETCDCTL_TRUSTED_CA_FILE=/opt/bootkube/assets/tls/etcd-peer.crt
export ETCDCTL_CA_FILE=/opt/bootkube/assets/tls/etcd-ca.crt
export ETCDCTL_PEERS=https://node1.example.com:2379

source ./etcdctl.sh

etcdctl ls --recursive
/coreos.com
/coreos.com/updateengine
/coreos.com/updateengine/rebootlock
/coreos.com/updateengine/rebootlock/semaphore

Expected to see "/registry.../"

This seems to be my own generic misunderstanding with K8 as I get the same issue with self hosted etcd-operator

repo: coreos/matchbox


text:
should create-servicemonitor-job.yaml use a newer version of coreos image

installing the prometheus operator using helm will spin up a 'prometheus-operator-create-sm-job' though the helm hook. This pulls quay.io/coreos/hyperkube:v1.7.6_coreos.0 (210.3 MB) just to run:
./kubectl apply -f /tmp/servicemonitor/servicemonitor-operator.yaml
Unfortunately this sometimes is slow, which makes helm run over the default 300s --timeout and the install/upgrade fails. The bad part here is that it leave the cluster in a bad state - the sm-job won#t be deleted and further installs will fail. While this should be fixed on the helm side, two questions:

why aren't you using helms crd-install hook?
https://github.com/helm/helm/blob/master/docs/charts_hooks.md#defining-a-crd-with-the-crd-install-hook

what about bumping to the latest coreos image v1.10.5_coreos.0 (188.9 MB), the one you are using is ~ 2 year old.

@caiobegotti I think part of the slowness to respond to this issue is that the helm charts have been in the process of being migrated to https://github.com/helm/charts. This is now complete, could you see if this fixes your issue. Please be aware, there are significant changes to the way the chart is deployed between here and helm/charts

Thanks. I'll have to figure how to change our bazel.io build rules to work with the new setup, as there are no binary releases (or are there releases to a storage bucket like the previous https://s3-eu-west-1.amazonaws.com/coreos-charts/stable/)?

The charts come from the official helm repository now (https://kubernetes-charts.storage.googleapis.com/)

Thanks for your help. I don't see any jobs in the new helm charts anymore. Hence closing this :)

Seem that things got also rename on the way. Is there a migration doc?
# this one got a lot bigger
https://s3-eu-west-1.amazonaws.com/coreos-charts/stable/prometheus-operator-0.0.29.tgz
-> https://storage.googleapis.com/kubernetes-charts/prometheus-operator-0.1.6.tgz

# whats the new version here?
https://s3-eu-west-1.amazonaws.com/coreos-charts/stable/kube-prometheus-0.0.105.tgz
-> ???

# this looks like a huge change in the version
https://s3-eu-west-1.amazonaws.com/coreos-charts/stable/prometheus-0.0.51.tgz
-> https://storage.googleapis.com/kubernetes-charts/prometheus-7.3.3.tgz

authors: ensonic vsliouniaev

repo: coreos/prometheus-operator


text:
kube-prometheus - Grafana Password Secret can only be admin

What did you do?
Changed password for grafana
What did you expect to see?
I expected to login, but I could only login if I made the password admin
What did you see instead? Under which circumstances?
Environment
Cloud

Kubernetes version information:

1.8.1

Kubernetes cluster kind:

KubeSpray

Manifests:

cluster-monitoring

Prometheus Operator Logs:
Dont even know what this is ^

insert Prometheus Operator logs relevant to the issue here

I can only use value of "admin" for grafana password in kube secrets or else I can'y login.

How did you generate the base64 encoded string for this? You need to make sure to not have a line break in there.
The command we use to generate it is:
echo -n <password> | base64 --wrap=0

Hmmm let me give that a shot, most likely my issue.
On Nov 1, 2017 12:57 PM, "Frederic Branczyk" notifications@github.com
wrote:

How did you generate the base64 encoded string for this? You need to make
sure to not have a line break in there.
The command we use to generate it is:
echo -n  | base64 --wrap=0
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/coreos/prometheus-operator/issues/716#issuecomment-341168315,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQTJt21jfQBN8l_5jCouErAgKVa4xVIwks5syKLzgaJpZM4QJ8sV
.

@brancz We shall never talk about this again...
So I do have one last question. I read the grafana watcher README and I'm still not sure what it does. It watches the configmap for changes to the dashboards and reloads them into grafana? Or when you change a dashboard in grafana it saves it to the configmap for persistence?
Great work on this by the way. Super easy to get great monitoring out of the box. I'm going to adjust some metrics and submit a PR.

No worries, it took me some time to figure it out on the first try as well when I was just seeing base64 encoded strings it's hard to catch a line-break :slightly_smiling_face: .
The grafana-watcher actually has nothing to do with Kubernetes, it just plays well into the way Kubernetes does things. The grafana-watcher just watches files and directories for changes and provisions the Grafana instances with the datasources and dashboards from the files. If any files changes, all dashboards are truncated, and re-provisioned. We do this as it allows us to operate Grafana in a declarative way, where we can scale Grafana up and down depending on our need, without the trouble of running a mysql database or equivalent, just to save some dashboard definitions globally. The operational side is one thing and it also allows us to check in the dashboards into version control, that way we can do reviews for the dashboards before applying them through CI or whatever tooling you choose to use. Lastly, we (or rather a very hard working community) recently converted the Grafana dashboard json definitions to use grafanalib, which allows us to define the dashboards as python code, and ultimately allow us to write abstractions above graphs as they are 98% of the time exactly the same with a different query.
Note that we've been talking with Grafana and they're actually working on getting most of this functionality of the grafana-watcher directly integrated into Grafana (slightly different but same end result), so hopefully in the future we won't need to maintain the grafana-watcher, but until then it's a way to fast forward into the future :slightly_smiling_face: .

@brancz
Kube-prometheus has grafana-watcher set to look at a configmap, but I thought that was static, a 1 time mapping when the pod is created? So if you did update the config map you would still have to kill that pod to get grafana-watcher to update grafana?

The grafana-watcher actually watches file-system events, because when a ConfigMap gets updated, it gets re-mounted into a Pod, triggering the file-system events, which makes grafana-watcher re-provision the "local" Grafana instance.

This makes updating Grafana dashboards very easy, as a CI pipeline just applies the ConfigMap with dashboards, and the grafana-watcher ensures the Grafana instance ends up in the correct state, without having to worry about the existing state currently present in the Grafana instance.

@brancz Ahhh I didn't know that config map values got reloaded live into pods. Neat =). Thanks for being so helpful.
I did change some metrics in the included dashboards to be more "fitting"  and my api response time and scheduler charts didn't work at all with kubernetes 1.8.1 one. Should I submit a PR?

@brancz
Before

After

Couple things like that ^

Generally yes, all contributions are welcome :slightly_smiling_face:, the exact queries we'll have to review to ensure that they are still appropriate.

authors: brancz shadycuz


text:
Updated comments in rule files on how to use regexp-assemble.py

This PR accompanies #2422.

I hope you will continue to unify the regexp-assembly script documentation :).
Now I'm using this regex to catch the build instruction in the CRS Rules-doc script:
        self.re_buildinst = re.compile("To rebuild the (regexp|regular expression)")

It would be good to see that each description uses the same syntax. Thanks :).

Thanks guys! I've changed the comment a bit but I think I got them all this time.
I don't think there's any merit in having "word list" in two places, it doesn't add any useful information, IMO.

Meeting decision March 7: @RedXanadu already reviewed. @franbuehler and @airween are added as reviewers.

We discussed this in the previous meeting:

#2423 depends on https://github.com/coreruleset/coreruleset/pull/2422 that still needs a review by @franbuehler and @airween.

Adding do-not-merge label.

Removing the do-not-merge label since #2422 has been merged in the meantime.
The merging of this PR is critical for the v.4-RC.

Removing the do-not-merge label since #2422 has been merged in the meantime.

The script which builds the CRSDoc structure uses heavily these comments. Let me check the modifications with that before the merge.

Very good. Thanks.

Removing the do-not-merge label since #2422 has been merged in the meantime.

The script which builds the CRSDoc structure uses heavily these comments. Let me check the modifications with that before the merge.

Thanks, I wasn't aware of that.

The modified rules are fine.
But I found few rules where the build instructions are in some old format (what I don't handle either in the crsdoc script).
@theseion do you think you can change these lines too?
932300
932310
932320
932301
932311
932321
Thanks!

Thanks @airween, nicely spotted. I also found another lingering one (934120). I hope I got them all now.

I hope I got them all now.

Sorry, after I grabbed you commit, I found a new one occurrence:
930100.

That one has to stay that way for now. There's no good way at the moment to do it differently. I'm working on some enhancements to regexp-assemble that will take care of that.

authors: airween dune73 franbuehler theseion

repo: coreruleset/coreruleset


text:
cornerstoneTools.calculateSUV BUG

const injectionStartTimeInSeconds = fracToDec(startTime.fractionalSeconds) + startTime.seconds + startTime.minutes * 60 + startTime.hours * 60 * 60;
should be modified to
const injectionStartTimeInSeconds = fracToDec(startTime.fractionalSeconds || 0) + startTime.seconds + startTime.minutes * 60 + startTime.hours * 60 * 60;

@yagni, transferred :+1:

repo: cornerstonejs/cornerstoneTools

license: mit


text:
New Tool: DICOM Overlays (C.9 Overlays)

Hi,
Does cornerstone supports displaying DICOM overlays ? (C.9 Overlays - http://dicom.nema.org/dicom/2013/output/chtml/part03/sect_C.9.html)
It doesn't show in my tests.
Thank you!

I removed the cornerstone PR (cornerstonejs/cornerstone#347)
and created an overlays tool - https://github.com/cornerstonejs/cornerstoneTools/pull/788
The tool is very simple having only enable and disable
Hope this helps :)

I've created a feature branch for us to iterate on the cornerstone-tools portion of this tool:

feature/overlay-tool

When new code is merged, a release is cut and tagged on NPM for @cornerstonejs/tools@feature-overlay-tool
I have a CodeSandbox up that is using the cornerstoneWADOImageLoader and cornerstoneTools branches that pertain to this feature:
https://codesandbox.io/s/1qj7j8op0l

@kofifus, here's an update:

The image loader now stores the information in overlayPlaneModule
The tool retrieves the data from the overlayPlaneModule and finds 2 overlays in our test DICOM
When disabled, the image shows 2-lines of text. When enabled, the image shows no new lines of text

Here is what I am able to see in a desktop viewer:

I haven't found a viewer yet that shows all 6-lines, but I only have a few installed locally.

Can you send me a link to download the dicom image pls ?

It's a bit higher up in this thread. JD shared it: https://github.com/cornerstonejs/cornerstoneTools/issues/780#issuecomment-459419571

Updated Sandbox: https://codesandbox.io/s/1qj7j8op0l
This is the PR that fixed things up: https://github.com/cornerstonejs/cornerstoneTools/pull/826

The code i provided should read all six layers as we render all six in our viewer. I’ll try to have a look at this this week

Possibly the other layers are in the presentation state (see https://github.com/cornerstonejs/cornerstoneTools/issues/780#issuecomment-459419871) which cornerstone does not support ?

Yep, that’s the case.

cool, I believe this can be closed :)

@all-contributors please add @jdnarvaez for sharing his code for Overlays

@jdnarvaez - in https://gist.github.com/jdnarvaez/3368ac3e4f7f4eb14bc5f453f8a1ed1b#file-graphicoverlays-js-L38 you again call setTransform after calling just above, can you pls explain what is the purpose of the second call ? Thanks!

@kofifus the transform is first set to the coordinates of the current canvas, then it it is saved, then it is set to 1:1 scaling, then reset to the previous scaling. This allows us to draw the overlays in a uniform coordinate system, so that any transformations or scaling by the user are also applied to the overlays

authors: dannyrb jdnarvaez kofifus


text:
Missing Visual Studio csproj file.

For Visual Studio IDE the csproj file is missing. Can you please provide the file. Thanks. Jaime

No comments.

No comments

license: MIT


text:
Wrong "Aktualisierung"-Date after reboot if Date/Time was changed before to a future date

Describe the bug
-i changed the date to a future date several times to get bonus in a game-app (Terarium)
-i switched back to automatical time
-then i restarted the handy
-then i started the Corona-App
-Now it says: "Aktualisiert Morgen, 14:13"
Expected behaviour
Show the last update date/time which cannot be in the future
Steps to reproduce the issue
Close Corona-App
Set Date to manual
Change one or two days back
Start the Cortona App
Now it shows "Morgen" or "Übermorgen"

Technical details

Mobile device:
Huawei Mate 10 Pro
Android version: 10

We strongly not modify the date of your device. The wrong date in the Risikoermittlung ist not a big problem you will only see a wrong refresh time. But wrong date/time will cause problem in the ssl chain and also it will cause the creation of multiple TEK per day which leads to submit problem.

Why does it not simply show an error if the date is in the future which is never possible?

Is it correct that it could be possible that the App detects a positive beacon twice when changing the date backwards? This could then lead to a higher displayed risk if the two positive Hashs are submited twice.
Or more then twice if changing time 20x one hour back followed by an Update.

Because the app is relying on the OS information which should provide the correct date. We could double check with a external provider but we cannot correct the date of the OS and it is more important to have exposure check than a correct time.
I think the os stores RPIs based on the id not on the date/time they collect it.

Possible alternative:
Is the return of getTimeInMillis() also changing when the date is changed? Or is this timer running hardcoded on the processor?

Related to:

https://github.com/corona-warn-app/cwa-wishlist/issues/88
https://github.com/corona-warn-app/cwa-app-ios/issues/1097

Hello @buergerapp, thank you for your feedback.
As @daimpi already mentioned there is already a wishlist entry for this issue here:
Active time is easy to fake #88
To keep our GitHub issues cleaner I will close this issue.
Best regards,
SG
Corona-Warn-App Open Source Team

authors: buergerapp daimpi svengabr thomasaugsten

repo: corona-warn-app/cwa-app-android


text:
New "Most asked questions" section in FAQ

Draft PR to create the new section in FAQ page. Still in progress.

Was this requested by the RKI/BMG?
Because in general FAQ means: "Frequently Asked Questions". Creating a new section which is titled "Most asked questions" does not really makes sense, IHMO. Instead the most frequently asked questions should be moved to the top & the FAQ should be clarified!

@Ein-Tim This was a request: A summary of the most common questions. The name of the section is tentative, it was initially "Top 10 questions". Suggestions welcome. Enjoy Friday evening and the weekend!

@dsarkar Ah, okay.
I will think about it again. Enjoy the weekend!

@dsarkar
Perhaps it would be better to start this off as an issue that we could discuss next week?
We should understand where these questions have come from exactly and how to best integrate them into the existing FAQs without overloading the user.
The FAQs are already very long and I often find it difficult to locate information that I know is there.
I think also that there should be some consideration given to removing unneeded information (see also https://github.com/corona-warn-app/cwa-website/issues/2032 "Which versions to describe in FAQs?").  Anything which is only relevant to CWA 1.x and earlier 2.x versions should be removed.

Since this PR is in draft status I will not comment on details at the moment and I will wait until it is marked ready for review. Here are some general suggestions:
Suggestions

If there is going to be a list, then use the same titles as:

https://digitaler-impfnachweis-app.de/en/faq "Current most frequently asked questions"
https://digitaler-impfnachweis-app.de/faq "Die aktuell häufigsten Fragen"

Limit the number of such articles in the list (less than 10)

Only have one article on each subject. If there is already an article on the subject in the main body of the existing FAQs, then combine the text into one article and move it to the new list.

If the new proposed text covers a description of how the app works which is already described in a section at the top level of https://www.coronawarn.app, then combine the texts, choose the best place to display the information and only include it one time. The main page already includes sections:

"This is how the app works best"
"How does the app work?"

Don't link to other articles by displaying a literal URL e.g. https://www.coronawarn.app/de/faq/#check_in. Instead use text such as the title of the article or its section heading to construct a hyperlink. Make all hyperlinks relative, not absolute.

In addition consider enhancing the in-app documentation. The description of the app's functionality displayed in the "Overview" menu item is very basic and in the meantime it is quite incomplete, due to functionality which has been added over the past 18 months. Putting this information into an FAQ instead of into the in-app documentation is an inferior workaround.

Just one detail point though:
There are a lot of instances of

Abb. 1.

 which don't make sense in this context.

@Ein-Tim
There is something technically wrong with this PR on GitHub. I'm not sure what is going wrong!

@MikeMcC399
Yes, this should be looked into before further changes are made!

@brifemu
The PR needs to be cleanly rebased on master. There are major merge conflicts.

I have added my failed comments from this PR to the new PR #2313.
This PR can be closed now.

authors: Ein-Tim MikeMcC399 brifemu dsarkar

repo: corona-warn-app/cwa-website


text:
Ignore assets with GitHub linguist

GitHub will specifiy this Project as HTML. Because i have added the assets to .gitattributes
Official Information

Repo: github/linguist

I've done

Add src/assets to .gitattributes

Thanks a lot - never knew how to influence this categorisation. You got to love how almost each contribution by the community teaches you something new. Thank you all so much!


text:
FAQ: Change from 10 minute contact duration to 5 minutes

Closes https://github.com/corona-warn-app/cwa-website/issues/914

I just learned today not to mix the 5min time-frame with the 15min threshold. The 5min relates to the total technical active scanning time realized by the ENF, but the 15min threshold is the (currently) defined "relevant contact time" that is also used by the health authorities to decide whether or not a contact is qualified as "contacted" - but we have this and other documents currently on review already. Latest target date is mid of March.

@MikeMcC399 Thanks for the review. I created a separate issue #917.

@dsarkar
I also created a separate issue #918 regarding the reference materials.
Many thanks for correcting the typos which were not part of your changes! :+1

authors: GisoSchroederSAP MikeMcC399 dsarkar


text:
🛑 FashionLady.ro is down

In 04f98e3, FashionLady.ro (https://fashionlady.ro) was down:

HTTP code: 403
Response time: 978 ms

Resolved: FashionLady.ro is back up in 7befab1 after 10 minutes.


text:
Implement purging of old profiler hits

Currently the profiler requests coming into gateway are not purged in any way, so it can be a memory hog.
There should be a call to action on frontend (profiler page) for the purge.
Frontend:

[ ] simple call to backend endpoint and list clear

Backend:

[x] endpoint for profiler hits purging
[ ] automatic profiler hits cleanup

Done, handling status of all here: https://github.com/cortezaproject/corteza/issues/522

repo: cortezaproject/corteza


text:
undefined: NewRouter

Hello, in first thanks for your tutorial :)
I have a problem when try execute go run main.go I get message # command-line-arguments ./main.go:10: undefined: NewRouter.

Hi. go run doesn't work well with multi file projects. Use 'go build' and then run the generated executable.

Thanks!! go run * or go build works fine.

Is it okay to work this way with go with multiple files in the project? This is a question I've been asking myself since I started learning go. I thought it would be necessary to always create packages for each thing, for example the router file, I thought I would have to create an internal package to be using go the correct way. Thank you for your help!

authors: kalelc leogaletti pollonamid

repo: corylanou/tns-restful-json-api


text:
admin event preference panel

About the PR

adds an event preference panel that allows admins to see the event preferences of a player's current selected character through the eventpreferences <name> command
currently only accessible through a command, can be added if needed or if it's wanted via context menu, admin menu, etc.
Why / Balance

while working on the character panel, i figured that there will be situations that an admin would only want to see a player's event preferences without the additional features that will be present in the character panel
whether or not this gets merged or is needed, the xaml file will be reused for the characterpanel itself
Technical details

implemented with Eui, a player's character current character profile is fetched and the current active preferences is gotten from the profile every time that the Eui is opened via command or (hopefully) otherwise
a new EventPreferences control was added under in the Content.Client._CD.Admin.UI namespace as well, allowing this portion of the UI to be easily reused
Media

Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

nada
Changelog

for admins: added an event preference panel that allows game admins to view the event preferences of a player via the eventpreferences command

something fucked up with the pushing the FUCKK

no longer dying yippioe

Looking at this again, I would rather preferences not show up if they are not enabled. I think red vs. green could cause a bit of confusion because people commonly associate antags with red. Given that it is a two line change I am just going to make it myself so this gets merged.

oh that works too, thank you


text:
Restructure selectors again

Selectors were a mess in my opinion, basically the same code copied in sample_selection and feature_selection all over the place. Here's how I amended it.
Everything still inherits from GreedySelector, which has an added axis component to tell it which axis to do the selecting over. This remedies nearly every difference between feature and sample selection.
From there, I made templates for CUR, FPS, PCovCUR, and PCovFPS in skcosmo/_selection which ascribe all behavior other than this axis parameter. That way, in skcosmo/sample_selection and skcosmo/feature_selection, we need only add the axis.
I also rewrote the docs to consolidate and simplify.

Do we still want/need separate classes for sample/features selection then? Or should we point the users to do FPS(axis=0) for samples selection and FPS(axis=1) for feature selection?

To be honest I’m split. On one hand, we may run into a moment to speed up FS/SS independently and they will diverge, but on the other hand, there is so much repeat code.

On Apr 8, 2021, at 3:44 PM, Guillaume Fraux @.***> wrote:
Do we still want/need separate classes for sample/features selection then? Or should we point the users to do FPS(axis=0) for samples selection and FPS(axis=1) for feature selection?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/cosmo-epfl/scikit-cosmo/pull/93#issuecomment-815836966, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALKVP3THM43V2GH2T6DGI7TTHWXNRANCNFSM42S4EJLA.

authors: Luthaf rosecers

repo: cosmo-epfl/scikit-cosmo


text:
feat: refactor the node key as version + path

ref: #571, #608
Context
As discussed in #608, it suggests the node key format as version + path instead of hash.  It introduces a new way to get new nodes and orphans and remove the root and orphans from storage.
What does this PR do?

Refactor the node key with version + path
Remove the root store
Include #646

@cool-develope can you give a short summary of all the changes in the pr in the description

/prbot describe

This PR has two problems, the export/import is not working with the original version.
It violates #660.

repo: cosmos/iavl


text:
Move verifyMisbehaviour to misbehaviour_handle.go for 06-solomachine

Summary
verifyMisbehaviour should be placed in misbehaviour_handle.go

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

Hello, I am looking to contribute on this issue.

repo: cosmos/ibc-go


text:
feat: multi payload packets

Support for atomic multiple payloads in a single packet.
TODO: Fill out more information.

We probably need not support this until ibc-go does

authors: gjermundgaraba srdtrk

repo: cosmos/solidity-ibc-eureka


text:
Rename and move TmSession files to a new folder

Description:

We should move all the TmSession... files to a components/session folder. They are technicaly not common shared components
Also there's no need for the Tm prefix

Consider #1313

closing and moving this issue to #1780

authors: faboweb fedekunze

repo: cosmos/voyager


text:
fix: added dependency installation to pages-deploy.yml

CI currently does not install the Jekyll theme Gem. This causes the following error when trying to run the CI for GitHub Pages.
Error:  The jekyll-theme-chirpy theme could not be found.

This PR adds this to the workflow.

CI currently does not install the Jekyll theme Gem.

I doubt this. bundle install is done in ruby/setup-ruby.

I stand corrected. Apologies.


text:
After first commit only shows --- layout: home # Index page ---

Checklist

[x] I have read the tutorials and know the correct effect of the functional design.
[x] There are no similar question on existing issues (including closed ones).
[x] I searched the Internet for related problems, but still couldn't solve it.
[x] My question is based on the latest code of master branch.

Description

In github-pages "username".github.io this is what is shown:
--- layout: home # Index page ---
and keep getting an error on deploy
`- _site/404.html
Ran on 9 files!

image has no src or srcset attribute (line 1)

_site/about/index.html

image has no src or srcset attribute (line 1)

_site/archives/index.html

image has no src or srcset attribute (line 1)

_site/categories/index.html

image has no src or srcset attribute (line 1)

_site/index.html

image has no src or srcset attribute (line 1)

_site/tags/index.html

image has no src or srcset attribute (line 1)

HTML-Proofer found 6 failures!
Error: Process completed with exit code 1.`
what I could be doing wrong? On selfhosting works normally

Why was this closed? I'm facing the same problem.

me too

authors: Can1425 gloryVine thevinirocks


text:
Inconsistency about indexing same key and value between SQLite and cbforest

In case of emitting same key and value, cbforet does not index it, however SQLite indexes it. Following is sample map function. key and value is never changed whenever document is updated.
com.couchbase.lite.View view = mDatabase.getView("tasks");
if (view.getMap() == null) {
    Mapper map = new Mapper() {
        @Override
        public void map(Map<String, Object> document, Emitter emitter) {
            if ("task".equals(document.get("type"))) {
                List<Object> keys = new ArrayList<Object>();
                keys.add(document.get("list_id"));
                keys.add(document.get("created_at"));
                emitter.emit(keys, null);
            }
        }
    };
    view.setMap(map, "1.0");
}

For 1.3.0 release, we fixed this in ToDoLite.
https://github.com/couchbase/couchbase-lite-java-core/issues/1367

TODO: Write Unit Test - Correct more info

Unit Test: https://github.com/couchbase/couchbase-lite-android/commit/9b78bd99a14ae41debdcb7a1df915a278e33c0e7?diff=unified
Steps:

Create View which map function emit same key and value for unique document.
Create Live Query from View
Create document
Update document

SQLite: Live Query notify twice
ForestDB: Live Query notify once
Reason: ForestDB does not emit if both key and value is same with previous one.

Which behavior would be considered correct?  If the information has not changed, then has the query actually been updated?

@borrrden we could discuss this during next sprint planning?

Correct for each DB

authors: borrrden djpongh hideki

repo: couchbase/couchbase-lite-java-core


text:
Add USE method dashboard

Add a System-level USE method1 dashboard, showing Utilization, Saturation & Errors for each high-level resource.
Inspired by https://www.circonus.com/2017/08/system-monitoring-with-the-use-dashboard/.

looks good

authors: dave-finlay daverigby

repo: couchbaselabs/promtimer


text:
Added Patreon icon but missing permissions

I worked on adding the Patreon icon, but when I go to publish my branch and create a PR, I receive the following error:
You don't have permissions to push to "couetilc/react-social-icons" on GitHub. Would you like to create a fork and push to it instead?
Could I either be granted permissions, or could someone with permissions add the icon? Steps are:

Update package.json to include "./patreon": "./dist/icons/patreon.js",
Create patreon.json file in the db folder with the following contents:

{
  "color": "#000000",
  "path": "M 52.8531 23.4586 C 52.8449 17.7383 48.3906 13.0488 43.1625 11.359 C 36.6711 9.259 28.1098 9.5625 21.9109 12.4855 C 14.3996 16.032 12.0398 23.7977 11.9523 31.5414 C 11.8812 37.9098 12.5156 54.6797 21.9738 54.8 C 29.0039 54.8875 30.0512 45.8312 33.3023 41.4699 c 2.3133 -3.1035 5.2937 -3.9785 8.9605 -4.8863 c 6.3027 -1.5613 10.5984 -6.5352 10.5902 -13.125 z m 0 0"
}

Here are screenshots showing resulting changes, and unit tests passed:

Hi @DSD3V , to create a PR, fork this repo, apply your changes, and then open a PR against this repo with your new commits.
Take a look at GitHub's documentation outlining their workflow in this regard https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/about-forks
Thank you for contributing.

PR here

repo: couetilc/react-social-icons


text:
Fix publishing.

Previously, publishing was set up to rely on sbt plugins installed globally.
Instead, we should install all plugins required explicitly, without relying on
implicit globals.
Additionally, we rely on dependencies that only work on Java 1.8, and Scala 2.11
so we will only publish Scala 2.11+.

LGTM.

authors: josh-newman saeta

repo: coursera/courscala


text:
Reducing coursier dependencies

This issue is going to be highly controversial and may not even be considered due to the conflict of some of the design aims of coursier, essentially the issue is about removing dependencies which are either very large (scalaz) or create circular dependencies with libraries that may want to use coursier (ammonite-terminal, @lihaoyi is considering making ammonite use coursier)
If coursier's aims are to be included in tools like SBT/ammonite (and others) by default, the dependencies need to be made as small as possible. Scalaz unfortunately, due to its monolithic design, weighs in at around 10mb.
There are obviously replacements for Scalaz (the other extreme would be just using the stdlib, which has Future), but this obviously means that the core of coursier isn't going to be completely "pure" (from a pure functional programming POV), i.e.

The cache module handles caching of the metadata and artifacts themselves, and is less so pure than the core module, in the sense that it happily does IO as a side-effect (always wrapped in Task, and naturally favoring immutability for all that's kept in memory).

Other solutions can include using cats instead of Scalaz (cats core is currently much smaller, weighing at 2.7mb currently). Either that, or using an internal solution to replace the areas that Scalaz is being used for (i.e. Task)
Also using Future instead of Task can possibly provide performance improvements since a lot of high performance HTTP libraries (dispatch with netty or akka-http) are backed by Future's

How's about using shaded jars to avoid any conflict instead? https://github.com/sbt/sbt-assembly#shading

If its possible to use proguard/shading successfully than it would definitely help. Shading will help with the ammonite issue, not sure how effective proguard is at reducing binary size for things like Scalaz (can anyone here comment on that?)

@mdedetrich It's not controversial at all! I even tried to similar things in circe recently (https://github.com/travisbrown/circe/pull/28), without succeeding in convincing its author.
Dropping the ammonite-terminal dependency is no brainer. I used at first because I didn't know to what extent I would have to use its features, nor if what I was using was stable or not (so the dependency gives free updates), but it turns out coursier doesn't use much from it.
From scalaz, coursier mainly uses Monad in core and Task in cache, and EitherT in the both of them.
I see two ways of dropping the scalaz (or cats) dependency in the future:

a porcelain module should be added soon, without scalaz explicitly appearing in its API. This module could shade/proguard the main dependencies of coursier, to get a not-too-heavyweight library. To get an idea of its size, the current cli module is published proguarded (https://oss.sonatype.org/content/repositories/releases/com/github/alexarchambault/coursier-cli_2.11/1.0.0-M8/coursier-cli_2.11-1.0.0-M8-standalone.jar), and weights about 1.6 MB. Not having scala-library in it could be 200-300 kB less.
stop depending on either scalaz or cats, and implement our own basic functional stuff, like fs2 does. This may actually be the less heavyweight choice, if ever the former one turns out impractical.

There are a few higher priority things I'd like to do before that, for a 1.0 final (some stability fixes, and integration tests). But that should be the next thing to do IMO.

Is this a duplicate of #25?

@nafg More or less... This one is more general. https://github.com/alexarchambault/coursier/issues/25 is only about substituting cats to scalaz.

I'd also really like to see a slimmer coursier as it means it can be used as a generic deployment tool without having to bootstrap itself, and we could potentially distribute an assembly/proguarded jar with its full source code with the various ensime clients.

@fommil Bootstrapping should be better now (since 1.0.0-M10, maybe M9). It only downloads a single proguarded ~1.5 MB JAR, instead of ~25 MB of JARs previously.

definitely an improvement, but as a longer term goal getting the size of that 1.5MB jar down even further would be good :smile:

Just to weigh in on this…  We've been making various attempts to use Coursier at Verizon, getting closer each time, but our latest thrust was foiled by none other than dependency hell.  Specifically, we have a plugin dependency that uses argonaut under the surface, which in turn depends on Scalaz 7.1.  Since Coursier depends on Scalaz 7.2, this results in a conflict (which is evicted in favor of 7.2) that ultimately generates a bytecode validation error in the dependent plugin.
Dependencies suck a lot.  I wish I had a good solution, but certainly the situation right now is not ideal.

@djspiewak Would having the plugins switch to argonaut 6.1a be an option? It basically has the same API as 6.1, but depends on scalaz 7.2.

@alexarchambault That's what we're working on.  It is an option in our case, but might not be in others.

@alexarchambault has been publicly on board with removing scalaz as a dependency: sbt/librarymanagement#190 (comment)
This is a prerequisite for sbt starting to ship with coursier support itself (not a plugin).
From a cursory look at the code it seems that the main usages are Task, /, EitherT. It's not an impossible task to replace these.
The question is: What should it be replaced with?
From my point of view there are a few options:

Copy the parts of Scalaz that are actually used.
Rewrite the parts that are actually used with types that enhance stdlib functionality.
Use another functional library, for example cats.

In my view 3. does not improve the dependency situation much.
So 1. and 2. are more promising.
I'm not sure however, how easy it is to take a part of scalaz and copy it without having to bring in a huge chunk of the rest of the library.
On the other hand, writing a replacement might also be a never-ending project, as the devil is probably in the details.
One approach could be to go type by type, ie. set the goal to remove a single type first and learn from the experiences of doing that. For example, we could introduce a coursier.concurrent.Task and see how far we get.
WDYT?

How many lines of code is Task?
On Wed, Feb 7, 2018, 10:02 AM Leonard Ehrenfried notifications@github.com
wrote:

@alexarchambault https://github.com/alexarchambault has been publicly
on board with removing scalaz as a dependency: sbt/librarymanagement#190
https://github.com/sbt/librarymanagement/pull/190 (comment)
This is a prerequisite for sbt starting to ship with coursier support
itself (not a plugin).
From a cursory look at the code it seems that the main usages are Task, /,
EitherT. It's not an impossible task to replace these.
The question is: What should it be replaced with?
From my point of view there are a few options:

Copy the parts of Scalaz that are actually used.
Rewrite the parts that are actually used with types that enhance
stdlib functionality.
Use another functional library, for example cats.

In my view 3. does not improve the dependency situation much.
So 1. and 2. are more promising.
I'm not sure however, how easy it is to take a part of scalaz and copy it
without having to bring in a huge chunk of the rest of the library.
On the other hand, writing a replacement might also be a never-ending
project, as the devil is probably in the details.
One approach could be to go type by type, ie. set the goal to remove a
single type first and learn from the experiences of doing that. For
example, we could introduce a coursier.concurrent.Task and see how far we
get.
WDYT?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/coursier/coursier/issues/175#issuecomment-363796305,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGAUDOFNHbp6BLXJTaTtf3D_x32IMvlks5tSbsagaJpZM4HiaaK
.

@leonardehrenfried I'll handle that issue. For the core module, I'll likely use SHIMs for Monad, EitherT, maybe Nondeterminism, with the bare minimum methods (I tried some time ago, it seemed to work fine…).
Then maybe a type class in cache abstracting over Task, and, if possible, a Future-backed implementation of it. And cats-effect and scalaz-concurrent modules with cats / scalaz implementations for it.

coursier 1.1.x (only released via milestones) doesn't depend on scalaz anymore. The coursier and coursier-cache modules should basically only depend on scala-library and scala-xml.

authors: alexarchambault djspiewak fommil leonardehrenfried mdedetrich nafg ngbinh

repo: coursier/coursier


text:
support of SHA-256 checksums

I need to use SHA-256 hashes for checksums. Adding a custom checksumURL to Artifact would allow me to do this, but eventually the validation fails with a ChecksumFormatError as only md5 and sha1 hashes seem to be supported here.
Would it be possible to introduce support for this somehow?

Fixed by https://github.com/coursier/coursier/issues/625.

authors: alexarchambault gabor-aranyossy


text:
FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory

Hello coussej,
I am testing your code "at limits" (more than 300 tags) but after a while, I receive the following error. It seems to be related with the total memory used by "opclogger.db".
In the moment of this error, this file had 198.019kb which is a lot of memory.
Could you have a look? Thank you a lot.
`
at C:\Program Files\node-opcua-logger-master\node_modules\influx\index.js:67:23
at InfluxRequest._parseCallback (C:\Program Files\node-opcua-logger-master\node_modules\influx\lib\InfluxRequest.js:122:10)
at Request._callback (C:\Program Files\node-opcua-logger-master\node_modules\influx\lib\InfluxRequest.js:111:10)
at Request.self.callback (C:\Program Files\node-opcua-logger-master\node_modules\request\request.js:185:22)
at Request.emit (events.js:189:13)
at Request. (C:\Program Files\node-opcua-logger-master\node_modules\request\request.js:1161:10)
at Request.emit (events.js:189:13)
at IncomingMessage. (C:\Program Files\node-opcua-logger-master\node_modules\request\request.js:1083:12)
at Object.onceWrapper (events.js:277:13)
at IncomingMessage.emit (events.js:194:15)
<--- Last few GCs --->
[34036:00000148C03AD2C0]  1206855 ms: Mark-sweep 1008.2 (1067.6) -> 1008.2 (1034.6) MB, 746.0 / 0.0 ms  (average mu = 0.476, current mu = 0.000) last resort GC in old space requested
[34036:00000148C03AD2C0]  1207602 ms: Mark-sweep 1008.2 (1034.6) -> 1008.2 (1034.6) MB, 747.0 / 0.0 ms  (average mu = 0.306, current mu = 0.000) last resort GC in old space requested
<--- JS stacktrace --->
==== JS stack trace =========================================
0: ExitFrame [pc: 0000024CF41079E0]

Security context: 0x01975e19e6e9
1: byteLength(aka byteLength) [000002C1B21F80D9] [buffer.js:~509] [pc=0000024CF55BD137](this=0x002ecd2026f1 ,string=0x007524a2e0f9 <Very long string[202771045]>,encoding=0x01975e1be311 <String[4]: utf8>)
2: arguments adaptor frame: 3->2
3: from [000002394879E8E9] [buffer.js:~199] [pc=0000024CF55C85CF](this=0x02c1b21d2b29 <JSFunction ...
FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
1: 00007FF77538F04A v8::internal::GCIdleTimeHandler::GCIdleTimeHandler+5114
2: 00007FF77536A0C6 node::MakeCallback+4518
3: 00007FF77536AA30 node_module_register+2032
4: 00007FF7755F20EE v8::internal::FatalProcessOutOfMemory+846
5: 00007FF7755F201F v8::internal::FatalProcessOutOfMemory+639
6: 00007FF775B12BC4 v8::internal::Heap::MaxHeapGrowingFactor+9556
7: 00007FF775B110CB v8::internal::Heap::MaxHeapGrowingFactor+2651
8: 00007FF7756CCA3B v8::internal::Factory::AllocateRawWithImmortalMap+59
9: 00007FF7756CF4ED v8::internal::Factory::NewRawTwoByteString+77
10: 00007FF7758D9AA8 v8::internal::Smi::SmiPrint+536
11: 00007FF7755E582B v8::internal::StringHasher::UpdateIndex+219
12: 00007FF77560AB26 v8::String::Utf8Length+22
13: 00007FF77535370C node::Buffer::New+4332
14: 0000024CF41079E0
C:\Program Files\node-opcua-logger-master>
`

Hi there!
300 tags should not be 'at limits' 😄we've had cases with 1000s that had no issues. Unless you are running on limited hardware? What are the specs of the system?
May I also ask you which versions of NodeJS and specifically the influx library you are using?

Thank you for your answer. More than 1000??? wow....I promise I will try!!
My hardware specs are:
Intel Xeon CPU E3-1225 v5 @ 3.30Ghz
RAM 8,00 GB
Windows 10 64b
Node js version 10.15.3
Influxdb library: How can I check this?
I think is something related to opclogger.db wich doesn't stop growing and growing.
I also have 2 questions....regarding functionality:

If I have 10 machines with 200variables each, do you recommend to use only one instance of opclogger and one influxdb o do you recommend to create one instance per machine.
I understand poll and suscribe but, regarding your experience, which method do you recommend?

I have also developed an excel macro to convert Kepware csv export into "config.toml" format. If you are interested I can share it with you. It was a pain to write one by one.
Please, tell me if you need some help.

You can check the influx lib version in node_modules/influx/package.json.
Can you also post the settings of your config.toml file?
Another question, are you getting any data written to influx? The buffer data should only grow if the logger is not able to write anything to the database, and thus starts buffering.
(we have experienced some issues with the current implementation of buffering, but I hope to trickle down some of the improvements of our commercial version back to the OS one soon. In either case, they should not pose an issue on this scale.)

Hello,
influxdb package v4.1.0
config.txt
Regarding influxdb is has registered data until it failed. What I could see now is that Chronograf was freezed, also grafana.....after influxdb restart, they started working. Could be something related influxdb?
Thank you!!

Hello,
I have reproduced the error and, before out of memory issue I receive this error:
opclogger Error: {"error":"partial write: unable to parse 'PC_SPC.actPartProgram,equipment=IL_PAR01,opcstatus=Good value=" M169 ;pump reset\r\n G4F2\r\n /M170 ;pump on if not skip block\r\nEndif\r\n\r\n$MC_ORI_IPO_WITH_G_CODE=0\r\nNEWCONF\r\n\r\nM150H4 ;OEE integer DB210\r\n\r\nLog_Action("WJet part program started = "\u003c\u003c$P_PROG[0])\r\n\r\nM17\r\n" 1558951473842': bad timestamp dropped=0"}
The value of this tag is a very long string.

Hi alex, it seems that influx is not able to parse the incoming points. Probably something goes wrong with encoding/decoding to the influx line protocol because of the value of your string tag.
Can you just check and see if the logging works as expected without including this tag, and deleting the buffer database? This version of the logger keep retrying to send the data to influx when it fails, but in this case this means an endless loop while the buffer database keeps growing, hence the memory error.

repo: coussej/node-opcua-logger


text:
New icons for different views of map

Is your feature request related to a problem? Please describe.
In the three views of the map : District, States or Cities ( that I assume) is quite unclear as it lacks a proper labels or icons

Further the functionality of each is quite not clear as the icons aren't standardized
Describe the solution you'd like
New icons and hover labels for the icons , Specifically ones that make the purpose of the view more clear

/claim

Closing due to inactivity

authors: DantrazTrev Priyam1464 shuklaayush


text:
ArcGIS pagination

This pull request is to replace #835; I'm trying to address @jzohrab's comment about not updating the cache submodule, but to be honest, I can't see when it was done, or how to undo it.
This would address #832.
All scrapers were migrated and eye-tested.
I've defined a transition date so that we don't get cache misses when building timeseries. In this PR the date's been changed:
const ARCGIS_PAGINATION_DEPLOY_DATE = '2020-04-25'

Please take a look if you haven't already looked at the old one. (Nothing's changed here other than bringing it up to date with master and changing the deploy date.

Hi @shaperilio , my cache review was for this change:

You can (should be able to!) get rid of that by checking this branch out and updating that reference so it's referring to the same sha as in master.  Ping if issues. :-)

@camjc does this relate to the JP problem you noted?

fyi @shaperilio and anyone else -- I've pulled parts of this over to Li in (wip) PR https://github.com/covidatlas/li/pull/193, and implemented it for JP.  @shaperilio I reused your work for that, thanks.  We still have to implement the paging for all the scrapers that Emilio did in this PR, so I'm leaving this open until I create another issue in Li.

New issue in Li https://github.com/covidatlas/li/issues/350 covers the work in this PR, so I'm closing this one here.  Thank you very much @shaperilio ! z

authors: jzohrab lazd shaperilio

repo: covidatlas/coronadatascraper


text:
Refactor src/events/scraper/load-cache/index.js

Change API to take the loader, and add tests.  Passing in the loader object rather than a boolean should clarify flow.  Can also standardize on throwing instead of returning false,

How will this make life better?

Clearer code path

How big is this change (small/med/large/really large)?

Small

How complicated is it?

Medium.  Code exists and works, but IMO is hard to follow.

What's the test plan?

Dependency inject for unit testing to simulate cache fall through.
e.g:

async function load(params, loader) { ... }

async function loadCache(params) {
  if (isLocal) {
    try {
      let result = await load(params, localLoader)
      return result
    }
    catch {
      ... cache miss
    }
  }

  // S3 load
  try {
    let result = await load(params, S3Loader)
    return result
  }
  catch {
    ... failure
  }
}

Opened PR https://github.com/covidatlas/li/pull/232 for this.  I started adding tests but due to the multiple execution paths and exit conditions it became messy -- I'd still like to get those tests in but this PR is a good start.

repo: covidatlas/li


text:
provider pages with "-" in provider name don't show data

http://localhost:3000/evusheld?provider=Chi-Health-Hospital-mercy-Corning&zip=50841

fixed this a week or two ago

repo: covidsafe-fyi/evusheld


text:
ionic ios integration

I am attempting to use this plugin in an ios application.  From what I can tell it looks like this plugin is currently broken for ios, with no clearly documented fix.
Swift Version: 3.1
Ionic-cli Version: 3.0.0-rc.2
OSx Version: 10.12.4

Steps to reproduce:
ionic start test
cd test
ionic cordova plugin add cordova-plugin-geofence

Open config.xml and add:
    <preference name="UseLegacySwiftLanguageVersion" value="true" />
    <preference name="swift-version" value="2.3" />

run:
ionic cordova platform add ios
ionic cordova run ios

Result:
dump.txt
I realize that this is obviously related to #215 #211 and #222.  I would have no problem 4.) Go into xCode & find edit > convert > To Current Swift Syntax, but I am unable to follow this instruction.
How to I open these files in xcode?  /test/plugins/cordova-plugin-geofence/src/ios doesn't have a .xcodeproj file so xCode won't open those files.
I tried replacing those files following the instruction here, but re-running ionic cordova run ios had no effect, even when I remove the contents completely.
I'm also seeing the same issue with the ionic2 sample, but with no resolution there either.
Based on the comments I'm seeing, I'm sure someone has a fix to this issue, It just hasn't been clearly posted yet.

I've fixed this issue for my project by switching to a fork of this project.
ionic cordova plugin add https://github.com/ypelud/cordova-plugin-geofence
sudo ionic cordova platform rm ios
ionic cordova platform add ios

I haven't done extensive testing to see if all functionality is the same, but I'm hopeful.  Hopefully someday @ypelud's fork will be merged so the project compiles out of the box.

For the record the xcodeproj for ionic projects is located in <project_name>/platforms/ios/<project_name>/ and the specific files are in <project_name>/platforms/ios/<project_name>/Plugins/cordova-plugin-geofence

here is the procedure that eventually worked for me:
ionic cordova start testApp
cd testApp/platforms/ios/testApp/Plugins/cordova-plugin-geofence

replace the files there with the files here
open  testApp/platforms/ios/testApp/.xcodeproj in xcode
edit->convert->to current swift syntax
build-> fails
find offending line and replace with
return self.number?.intValue

ionic cordova run ios

repo: cowbell/cordova-plugin-geofence


text:
Highlight selected node, its links, and its children in a dagre-d3

I want to Highlight selected node, its links, and its children in a dagre-d3..
Can any one help on this feature?

I have the same needs.

me too

authors: alanhg ceerqingting varsha123


text:
Changes (mostly to the frontend) for cross-platform use

Overview
Code changes to run on non-Windows (e.g. macOS, Linux) platforms, with some minor tidying and supporting additions elsewhere.
Subject to (stress-)testing, this should close #40.
Almost all changes concern cross-platform, rather than Windows-specific, approaches to handling file and folder paths, for the most part using pathlib.
Other changes:

Switch to webbrowser to open the frontend in the user's default browser, in place of the previous use of a Windows-specific system call: os.system('start ...')
New 'requirements.txt', to pip install any dependencies prior to running
Minor corrections, cleaning and tidying elsewhere

Approach
Focus on getting the following to run:

run_file.py, which runs FTT from the terminal
Backend_FTT.py, which starts the browser-based GUI to run FTT and examine model results

Note that the aim was to make changes that addressed runtime errors only, rather than just blanket replace all instances. There are various functions in Backend_FTT.py that have been left alone for this reason, even if the corrections are (probably) safe and obvious.
Also note that the EXTRACT and GAMMA tabs have not been tested, pending further developments to those parts of the model and frontend.
Untouched functions, of which there are ten, have the following comment immediately below their function signature:
# TODO: Still to review for cross-platform compatibility
Tests
Tests involved alternately running python Backend_FTT.py in:

Windows Command Prompt, to check expected behaviour and that this behaviour remained after any code changes
Windows Subsystem for Linux, running Ubuntu 20.04, to test on a non-Windows platform

Outputs and behaviour appear to be preserved between the two versions, as well as compared to the original fork (admittedly, to this non-FTT specialist).

@sgulati26 has been able to run the model using the front-end and it produces the same results as running it on a Windows machine.
I'll leave the formal review to one of the Mac users.

@jp-camecon did some further tests on Windows to check for issues. Things look to be working as normal/before.
So we're just waiting for (at least) one Mac user to test this independently.

@jk694exe or @zoeberger : both of you have a Mac, right? Do you have time to test this?

We just had someone with a Mac successfully run the model from the front-end in an EEIST2 FTT training session. Might still want a more formal review before merging though.

When trying to run the Backend.py file from a Mac, there is an issue with the "start" command (cf picture).
When I tried to use the equivalent for Mac (i.e. "open"), it created an issue with the thread object (cf picture).

@zoeberger: in case you missed Chris' message.

authors: Femkemilene cormacmlynch ct-camecon pv-camecon zoeberger


text:
http query string parser bug

Greetings!
Class boost::network::uri::details::key_value_sequence< T > has bug when valid sequence "...param_name=&next_param_name=..." (empty value) isn't parsed.
Best regards

Is this is still in open?

authors: maxim-ky susnux

repo: cpp-netlib/cpp-netlib


text:
News - Creation Form Changes

On the News List page, there should be a single button/link that takes you to creation page.
On that creation page the user should have to choose News, Video, Link, etc. A simple single list of links/buttons to each creation form.
Initially, only poll moderators and superusers can create polls.  Will be opened up to all users at some future date.

[x] Interstitial page /news/create or something like that just to display the links/buttons to create each type
[x] Only show poll adding option to superusers and moderators

@frankwiles @gregnewman Question about the intermediary page for news creation: as a user, I think that having this two stage flow is a bit cumbersome and could generate a "old site" vibe. While this may be a desired goal, I wanted to triple check if the following wouldn't be a better flow:

From the "Submit News" link-button in the news list, take the user to a page that will have buttons for creating each type of News, but when clicked, the corresponding form is revealed instead of taking the user to yet another page.

The difference would be that all forms would be returned in the response but hidden until the user chooses a news type. Implementation wise, this is indeed a bit more involved but I'm raising it because it feels like better UX (unless we eventually do some partial template rendering in which case we could just fetch the specific news creation form on demand).

@nessita I believe (@frankwiles confirm please) that what you describe is our desired flow. We can preload the forms in that template and using alpine or htmx reveal the proper form/fields.  If we had one form with all the fields I can toggle the display of certain fields based on what button was clicked.  Happy to chat about it if you all want.

You're correct it's a better UI/UX, but that's not what is wanted.
We want (I'm paraphrasing URLs here):

/news/ to be the ListView of all approved News items
/news/add/ to be the interstitial page which is just a list of links/buttons to the individual news creation pages
/news/add/link/ - actual Link form
(repeat for all news types)

It's clunky, but it's what we're doing.

You're correct it's a better UI/UX, but that's not what is wanted.
We want (I'm paraphrasing URLs here):
* /news/ to be the ListView of all approved News items

* /news/add/ to be the interstitial page which is just a list of links/buttons to the individual news creation pages

* /news/add/link/ - actual Link form

* (repeat for all news types)

It's clunky, but it's what we're doing.

Thanks for the clarification! No worries, the PR I proposed is trivial to adapt to this schema. On it!

authors: frankwiles gregnewman nessita

repo: cppalliance/temp-site


text:
Fixed NullOperators test with random DataTypes.

The issue was that in case of an ObjectType if then GeoShapeType was selected for the value
to insert, the Map representing the GeoShape was Immutable causing ValueNormalizer to fail.

Codecov Report

Merging #6307 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #6307      +/-   ##
============================================
+ Coverage     83.21%   83.27%   +0.05%
- Complexity    12811    12820       +9
============================================
  Files          1480     1480
  Lines         48472    48472
  Branches       5918     5918
============================================
+ Hits          40336    40365      +29
+ Misses         5380     5347      -33
- Partials       2756     2760       +4

Impacted Files
Coverage Δ
Complexity Δ

...exceptions/GroupByOnArrayUnsupportedException.java
66.66% <0%> (-33.34%)
1% <0%> (-1%)

...ate/operation/merge/RamAccountingPageIterator.java
94.44% <0%> (-5.56%)
8% <0%> (-1%)

...va/io/crate/data/join/NestedLoopBatchIterator.java
95.55% <0%> (-4.45%)
22% <0%> (-1%)

...otocols/postgres/RetryOnFailureResultReceiver.java
88.46% <0%> (-3.85%)
10% <0%> (-1%)

...main/java/io/crate/blob/v2/BlobIndicesService.java
72.22% <0%> (-2.78%)
22% <0%> (-1%)

.../src/main/java/io/crate/blob/RemoteDigestBlob.java
78.57% <0%> (-1.79%)
8% <0%> (ø)

...te/operation/scalar/cast/CastFunctionResolver.java
96.05% <0%> (-1.32%)
10% <0%> (-1%)

.../operation/collect/sources/ShardCollectSource.java
83.08% <0%> (-1%)
29% <0%> (-1%)

...er/src/main/java/io/crate/sql/tree/AstVisitor.java
32.3% <0%> (ø)
42% <0%> (ø)
:arrow_down:

...o/crate/executor/transport/ShardUpsertRequest.java
89.75% <0%> (ø)
32% <0%> (ø)
:arrow_down:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4978206...6fab5c3. Read the comment docs.

authors: codecov-io matriv

repo: crate/crate


text:
Copy config.yml in Dockerfile

in Dockerfile file, doesn't it need config.yml to be copied?
By adding the line below just before the last line.
COPY --from=builder /go/src/github.com/crate/crate_adapter/config.yml .

I think you're right, see also https://github.com/gianlucanatali/crate-prometheus-test/blob/master/crate-prometheus-adapter/Dockerfile#L10

Dear Haytham and Fabian,
your suggestion has been implemented by @chaudum on behalf of 88611dae.
With kind regards,
Andreas.

authors: Haybu amotl fabianbaier

repo: crate/cratedb-prometheus-adapter


text:
Uncaught TypeError: Cannot read property 'match' of undefined

Using latest flogger, and got two issues:
I am getting the error from subject, but the flogger returns valid output:
Flogger gem
$ gem list flog

*** LOCAL GEMS ***

flog (4.4.0)

Flog output
$ cat app/services/classification/class_param.rb | flog -aqm
    45.0: flog total
    15.0: flog/method average

    31.0: Classification::ClassParam#enc   -:3
     9.3: Classification::ClassParam#hashed_class_parameters -:31
     4.7: Classification::ClassParam#class_parameters -:25
$ echo "$?"
0

Standard error report
Atom Version: 1.8.0
System: "Fedora release
Thrown From: flogger package, v0.3.1
Stack Trace
Uncaught TypeError: Cannot read property 'match' of undefined
At /home/shim/.atom/packages/flogger/lib/flog-adapter.coffee:7

TypeError: Cannot read property 'match' of undefined
    at parse (/home/shim/.atom/packages/flogger/lib/flog-adapter.coffee:7:29)
    at BufferedProcess.exit (/home/shim/.atom/packages/flogger/lib/flog-adapter.coffee:29:19)
    at triggerExitCallback (/usr/lib64/atom/src/buffered-process.js:215:47)
    at /usr/lib64/atom/src/buffered-process.js:222:18
    at Socket.<anonymous> (/usr/lib64/atom/src/buffered-process.js:100:18)
    at emitOne (events.js:95:20)
    at Socket.emit (events.js:182:7)
    at Pipe._onclose (net.js:477:12)

Commands
     -0:03.8.0 command-palette:toggle (atom-text-editor.editor.is-focused.mini)
     -0:00.9.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:00.9.0 flogger:toggle (atom-text-editor.editor)

Config
{
  "core": {
    "disabledPackages": [
      "goto",
      "symbols-view",
      "autocomplete-ctags",
      "atom-ctags"
    ],
    "excludeVcsIgnoredPaths": false,
    "ignoredNames": [
      "tmp",
      ".tx",
      "locale",
      "log",
      "reports",
      ".*",
      "coverage",
      ".git/",
      "apipie-cache/",
      "tags",
      "fulltags"
    ],
    "packagesWithKeymapsDisabled": [
      "flogger"
    ],
    "projectHome": "~/Documents/my_proj"
  },
  "flogger": {
    "flogCommand": "/home/my_user/.rvm/gems/ruby-2.2.1@rails4/bin/flog",
    "highThreshold": 25,
    "mediumThreshold": 20
  }
}

Installed Packages
# User
flogger, v0.3.1
language-plantuml, v0.2.0
last-cursor-position, v0.9.0
linter, v1.11.14
linter-erb, v1.0.2
linter-rubocop, v0.4.7
pigments, v0.31.2
plantuml-viewer, v0.7.0
project-manager, v2.9.7
tab-switcher, v1.5.3

# Dev
No dev packages

I am wondering if atom is invoking a different flog version, or has an incorrect path. That error would only occur if flog were getting back only one line of output.

After a bit of hacking and trial and error, I remembered that I have patched the flog-adapter.coffee to ignore error codes.
After patching the adapter file a bit more, I was able to get the error out to console.
My problem was that I was using rvm, and in non-interactive shells it's disabled by default.
I fixed the issue by creating a small shell script that loaded rvm and invoked flog:
#! /bin/sh

source $(/home/shim/.rvm/bin/rvm 2.2.1@rails4 do rvm env --path)

flog "$@"

Now everything works as a charm.

authors: ShimShtein crazymykl

repo: crazymykl/flogger


text:
[BUG] An existing VM start asks for a pull-secret (when not provided) which leads to a possible interruption of the startup flow

Running the next flow we end up on an unreachable state for the Microshift cluster:
$ crc config set preset microshift
$ crc start -p pull-secret
$ crc stop

Start the cluster without setting the pullsecret, it asks for the pull secret
$ crc start
...
CRC requires a pull secret to download content from Red Hat.
You can copy it from the Pull Secret section of https://console.redhat.com/openshift/create/local.
? Please enter the pull secret
...

Note: it seems the VM being existing, got started in the background, and due to the pull-secret question is not completely finalized. The regular OCP flow omits this question.
Abort the operation with [Ctrl + c]
Start the cluster with the pull secret
This operation completes in 5 seconds as successfully
$crc start -p pull-secret

Now cluster is unusable, check the state
$ crc status
CRC VM:          Running
MicroShift:      Unreachable (v4.13.3)
RAM Usage:       445MB of 3.902GB
Disk Usage:      4.707GB of 16.1GB (Inside the CRC VM)
Cache Usage:     35.05GB
Cache Directory: /home/ariobolo/.crc/cache

So this can be condensed as:
PS> crc start
# Abort the operation
[Ctrl + C]
PS> crc start -p pull-secret
PS> crc status
...
MicroShift:      Unreachable (v4.13.3)

Unable to repro with the pull-secret-file option:
PS> crc start
WARN A new version (2.25.0) has been published on https://developers.redhat.com/content-gateway/file/pub/openshift-v4/clients/crc/2.25.0/crc-windows-installer.zip
INFO Checking minimum RAM requirements
INFO Checking if running in a shell with administrator rights
INFO Checking Windows release
INFO Checking Windows edition
INFO Checking if Hyper-V is installed and operational
INFO Checking if Hyper-V service is enabled
INFO Checking if crc-users group exists
INFO Checking if current user is in crc-users and Hyper-V admins group
INFO Checking if vsock is correctly configured
INFO Checking if the daemon task is installed
INFO Checking if the daemon task is running
INFO Checking admin helper service is running
INFO Loading bundle: crc_microshift_hyperv_4.13.0_amd64...
CRC requires a pull secret to download content from Red Hat.
You can copy it from the Pull Secret section of https://console.redhat.com/openshift/create/local.
? Please enter the pull secret
Failed to ask for pull secret: interrupt
PS> crc config set pull-secret-file C:\Users\gbraad\Downloads\pull-secret (1).txt
Successfully configured pull-secret-file to C:\Users\gbraad\Downloads\pull-secret
PS> crc start
WARN A new version (2.25.0) has been published on https://developers.redhat.com/content-gateway/file/pub/openshift-v4/clients/crc/2.25.0/crc-windows-installer.zip
INFO Checking minimum RAM requirements
INFO Checking if running in a shell with administrator rights
INFO Checking Windows release
INFO Checking Windows edition
INFO Checking if Hyper-V is installed and operational
INFO Checking if Hyper-V service is enabled
INFO Checking if crc-users group exists
INFO Checking if current user is in crc-users and Hyper-V admins group
INFO Checking if vsock is correctly configured
INFO Checking if the daemon task is installed
INFO Checking if the daemon task is running
INFO Checking admin helper service is running
INFO Loading bundle: crc_microshift_hyperv_4.13.0_amd64...
INFO Creating CRC VM for MicroShift 4.13.0...
INFO Generating new SSH key pair...
INFO Starting CRC VM for microshift 4.13.0...
INFO CRC instance is running with IP 127.0.0.1
INFO CRC VM is running
INFO Updating authorized keys...
INFO Check internal and public DNS query...
INFO Check DNS query from host...
INFO Starting Microshift service... [takes around 1min]
INFO Waiting for kube-apiserver availability... [takes around 2min]
INFO Adding microshift context to kubeconfig...
Started the MicroShift cluster.

Use the 'oc' command line interface:
  PS> & crc oc-env | Invoke-Expression
  PS> oc COMMAND
PS> crc status
CRC VM:          Running
MicroShift:      Running (v4.13.0)
RAM Usage:       919.5MB of 3.902GB
Disk Usage:      4.822GB of 16.1GB (Inside the CRC VM)
Cache Usage:     20.72GB
Cache Directory: C:\Users\gbraad\.crc\cache

In the initial phase:
$ crc start -p pull-secret
$ crc stop

was the cluster in that case correctly operational? Without the crc status command I can not be sure about this, as it might well be an issue with the pull-secret-file itself.

Need more information as I can not repro with these steps:
I did notice the following
PS> crc stop
INFO Stopping the instance, this may take a few minutes...
Stopped the instance
PS> crc status
CRC VM:          Running
MicroShift:      Stopped (v4.13.0)
RAM Usage:       449.3MB of 3.902GB
Disk Usage:      4.859GB of 16.1GB (Inside the CRC VM)
Cache Usage:     20.72GB
Cache Directory: C:\Users\gbraad\.crc\cache
PS> crc start -p "C:\Users\gbraad\Downloads\pull-secret (1).txt"
WARN A new version (2.25.0) has been published on https://developers.redhat.com/content-gateway/file/pub/openshift-v4/clients/crc/2.25.0/crc-windows-installer.zip
INFO Loading bundle: crc_microshift_hyperv_4.13.0_amd64...
INFO A CRC VM for MicroShift 4.13.0 is already running
Started the MicroShift cluster.

Use the 'oc' command line interface:
  PS> & crc oc-env | Invoke-Expression
  PS> oc COMMAND

So that means the cluster didn't really stop, did this happen somehow... or did the stop fail before?
PS> crc stop -f
INFO Stopping the instance, this may take a few minutes...
Stopped the instance
PS> crc status
CRC VM:          Stopped
MicroShift:      Stopped (v4.13.0)
RAM Usage:       0B of 0B
Disk Usage:      0B of 0B (Inside the CRC VM)
Cache Usage:     20.72GB
Cache Directory: C:\Users\gbraad\.crc\cache
PS> crc start -p "C:\Users\gbraad\Downloads\pull-secret (1).txt"
WARN A new version (2.25.0) has been published on https://developers.redhat.com/content-gateway/file/pub/openshift-v4/clients/crc/2.25.0/crc-windows-installer.zip
INFO Checking minimum RAM requirements
INFO Checking if running in a shell with administrator rights
INFO Checking Windows release
INFO Checking Windows edition
INFO Checking if Hyper-V is installed and operational
INFO Checking if Hyper-V service is enabled
INFO Checking if crc-users group exists
INFO Checking if current user is in crc-users and Hyper-V admins group
INFO Checking if vsock is correctly configured
INFO Checking if the daemon task is installed
INFO Checking if the daemon task is running
INFO Checking admin helper service is running
INFO Loading bundle: crc_microshift_hyperv_4.13.0_amd64...
INFO Starting CRC VM for microshift 4.13.0...
INFO CRC instance is running with IP 127.0.0.1
INFO CRC VM is running
INFO Check internal and public DNS query...
INFO Check DNS query from host...
INFO Starting Microshift service... [takes around 1min]
INFO Waiting for kube-apiserver availability... [takes around 2min]
INFO Adding microshift context to kubeconfig...
Started the MicroShift cluster.

Use the 'oc' command line interface:
  PS> & crc oc-env | Invoke-Expression
  PS> oc COMMAND
PS> crc status
CRC VM:          Running
MicroShift:      Running (v4.13.0)
RAM Usage:       928.2MB of 3.902GB
Disk Usage:      4.927GB of 16.1GB (Inside the CRC VM)
Cache Usage:     20.72GB
Cache Directory: C:\Users\gbraad\.crc\cache

works as expected as the scenario described. So need more information about the pull-secret-file used or if the status in between the runs was an incomplete stop?

I am able to reproduce on linux
 ➜  crc git:(main) crc status
Machine does not exist. Use 'crc start' to create it

⠀ ➜  crc git:(main) crc start -p ~/Downloads/pull-secret
INFO Checking if running as non-root
INFO Checking if running inside WSL2
INFO Checking if crc-admin-helper executable is cached
INFO Checking if running on a supported CPU architecture
INFO Checking if crc executable symlink exists
INFO Checking minimum RAM requirements
INFO Checking if Virtualization is enabled
INFO Checking if KVM is enabled
INFO Checking if libvirt is installed
INFO Checking if user is part of libvirt group
INFO Checking if active user/process is currently part of the libvirt group
INFO Checking if libvirt daemon is running
INFO Checking if a supported libvirt version is installed
INFO Checking if crc-driver-libvirt is installed
INFO Checking crc daemon systemd socket units
INFO Checking if systemd-networkd is running
INFO Checking if NetworkManager is installed
INFO Checking if NetworkManager service is running
INFO Checking if dnsmasq configurations file exist for NetworkManager
INFO Checking if the systemd-resolved service is running
INFO Checking if /etc/NetworkManager/dispatcher.d/99-crc.sh exists
INFO Checking if libvirt 'crc' network is available
INFO Checking if libvirt 'crc' network is active
INFO Loading bundle: crc_microshift_libvirt_4.13.6_amd64...
INFO Creating CRC VM for MicroShift 4.13.6...
INFO Generating new SSH key pair...
INFO Starting CRC VM for microshift 4.13.6...
INFO CRC instance is running with IP 192.168.130.11
INFO CRC VM is running
INFO Updating authorized keys...
INFO Configuring shared directories
INFO Check internal and public DNS query...
INFO Check DNS query from host...
INFO Starting Microshift service... [takes around 1min]
INFO Waiting for kube-apiserver availability... [takes around 2min]
INFO Adding microshift context to kubeconfig...
Started the MicroShift cluster.

Use the 'oc' command line interface:
  $ eval $(crc oc-env)
  $ oc COMMAND

⠀ ➜  crc git:(main) crc stop
INFO Stopping the instance, this may take a few minutes...
Stopped the instance

⠀ ➜  crc git:(main) crc status
CRC VM:          Stopped
MicroShift:      Stopped (v4.13.6)
RAM Usage:       0B of 0B
Disk Usage:      0B of 0B (Inside the CRC VM)
Cache Usage:     30.03GB
Cache Directory: /home/anjan/.crc/cache

⠀ ➜  crc git:(main) crc start
INFO Checking if running as non-root
INFO Checking if running inside WSL2
INFO Checking if crc-admin-helper executable is cached
INFO Checking if running on a supported CPU architecture
INFO Checking if crc executable symlink exists
INFO Checking minimum RAM requirements
INFO Checking if Virtualization is enabled
INFO Checking if KVM is enabled
INFO Checking if libvirt is installed
INFO Checking if user is part of libvirt group
INFO Checking if active user/process is currently part of the libvirt group
INFO Checking if libvirt daemon is running
INFO Checking if a supported libvirt version is installed
INFO Checking if crc-driver-libvirt is installed
INFO Checking crc daemon systemd socket units
INFO Checking if systemd-networkd is running
INFO Checking if NetworkManager is installed
INFO Checking if NetworkManager service is running
INFO Checking if dnsmasq configurations file exist for NetworkManager
INFO Checking if the systemd-resolved service is running
INFO Checking if /etc/NetworkManager/dispatcher.d/99-crc.sh exists
INFO Checking if libvirt 'crc' network is available
INFO Checking if libvirt 'crc' network is active
INFO Loading bundle: crc_microshift_libvirt_4.13.6_amd64...
INFO Starting CRC VM for microshift 4.13.6...
INFO CRC instance is running with IP 192.168.130.11
INFO CRC VM is running
INFO Configuring shared directories
INFO Check internal and public DNS query...
INFO Check DNS query from host...
INFO Starting Microshift service... [takes around 1min]
CRC requires a pull secret to download content from Red Hat.
You can copy it from the Pull Secret section of https://console.redhat.com/openshift/create/local.
? Please enter the pull secret
interrupt
⠀ ➜  crc git:(main) crc start -p ~/Downloads/pull-secret
INFO Loading bundle: crc_microshift_libvirt_4.13.6_amd64...
INFO A CRC VM for MicroShift 4.13.6 is already running
Started the MicroShift cluster.

Use the 'oc' command line interface:
  $ eval $(crc oc-env)
  $ oc COMMAND
⠀ ➜  crc git:(main) crc status
CRC VM:          Running
MicroShift:      Unreachable (v4.13.6)
RAM Usage:       438.1MB of 3.84GB
Disk Usage:      4.798GB of 16.1GB (Inside the CRC VM)
Cache Usage:     30.03GB
Cache Directory: /home/anjan/.crc/cache

PS> crc config set pull-secret-file C:\Users\gbraad\Downloads\pull-secret (1).txt

This step is not part of the flow, does it has any impact on the keyring? @gbraad , also the failure was shown to @anjannath and @praveenkumar as part of a meeting

On Windows I am not able to reproduce this as described. I followed the exact instructions, and tried to otherwise repro it (as with the set config). But I can not get this unles the VM was only in a tristate: the VM was still running.
I believe it is unclear WHEN you break the pull-secret. Did you actuall provide the pull-secret amd let the start happen... or you  interrupted it at the point you are supposed to provide he pull-secret?
When no pull-secret is provided by cancel:
? Please enter the pull secret
interrupt

the VM does not start in my case.

I interrupt when it is suppose I should provide it

In short, you do not provide any pull-secret.
? Please enter the pull secret
interrupt

in that case, can you provide a crc status before the start with the pull-secret? I am curious if something got started somehow.

@anjannath you tested on Linux, @praveenkumar on macOS and @adrianriobo on Linux?

@adrianriobo Linux and Mac, so I assume on Windows was failing too...now I am running it on Windows ...
btw can we change back the issue name?

@adrianriobo The run https://github.com/crc-org/crc/issues/3801#issuecomment-1692735570 only was able to get into a 5 sec startup time for the crc start, as in that case the VM is started (running), but the cluster is not functional. I am therefore not conviced we have found the issue.

Thanks for the call. It seems to be related to 'existing VM' that was a side-effect. It already starts in the background for the Microshift preset, and in the meantime also asks for the pull-secret.
So when the crc start is given without -p, it will start the VM. This can be observed with another temrinal and running crc status. This means that the pull-secret question allows a break in the startup-flow. In short, it was waiting for the pull-secret to resume the startup (as in the regular OCP flow we do not ask for this; the VM already recorded the info).

We will perform a startHost and follow this up with bundle checks like:
https://github.com/crc-org/crc/blob/557ec94acb65317acda3d89a4d07ef1248c33581/pkg/crc/machine/start.go#L551-L552
and part of the sart we ask for a pull-secret:
https://github.com/crc-org/crc/blob/557ec94acb65317acda3d89a4d07ef1248c33581/pkg/crc/machine/start.go#L295-L302
somehow we have determined that on the Microshift preset this is also necessary on the exist-side? Not sure where this is enforced

somehow we have determined that on the Microshift preset this is also necessary on the exist-side?

It's a bug in microshift, sI filed https://github.com/crc-org/crc/issues/3619 a while ago.

This is the direct result of this: so in a way a duplicate.

on the other hand, this also describes a more general issue, which is not pull-secret related:

Abort the operation with [Ctrl + c]
Start the cluster with the pull secret
This operation completes in 5 seconds as successfully

If the startup is interrupted with ctrl+c, or because of an error, ... subsequent crc start won't detect/recover from it.

Right, this is the issue I also talked about, however the move having this execute in the daemon might resolve this. As in that case a stop or interrupt will trigger the cancel operation: https://github.com/crc-org/crc/blob/557ec94acb65317acda3d89a4d07ef1248c33581/pkg/crc/machine/sync.go#L31-L32
the other issue is that stop on Windows is not reliable anymore.

In Openshift it doesn't fail because we first check if pull secret exist but here in microshift we are not doing it so hence this bug.
diff --git a/pkg/crc/machine/start.go b/pkg/crc/machine/start.go
index febd16..8ea5c4 100644
--- a/pkg/crc/machine/start.go
+++ b/pkg/crc/machine/start.go
@@ -1050,12 +1050,16 @@ func addPodmanSystemConnections(c *types.ConnectionDetails) error {

 func startMicroshift(ctx context.Context, sshRunner *crcssh.Runner, ocConfig oc.Config, pullSec cluster.PullSecretLoader) error {
        logging.Infof("Starting Microshift service... [takes around 1min]")
-       content, err := pullSec.Value()
-       if err != nil {
-               return err
-       }
-       if err := sshRunner.CopyDataPrivileged([]byte(content), "/etc/crio/openshift-pull-secret", 0600); err != nil {
-               return err
+
+       // If pull secret already present in the VM, then no need to copy it again.
+       if _, _, err := sshRunner.RunPrivileged("Checking if pull secret already present in the VM", "test", "-f", "/etc/crio/openshift-pull-secret"); err != nil {
+               content, err := pullSec.Value()
+               if err != nil {
+                       return err
+               }
+               if err := sshRunner.CopyDataPrivileged([]byte(content), "/etc/crio/openshift-pull-secret", 0600); err != nil {
+                       return err
+               }
        }
        if _, _, err := sshRunner.RunPrivileged("Starting microshift service", "systemctl", "start", "microshift"); err != nil {
                return err

This is the 'ensure' mechanism, right?

This is the 'ensure' mechanism, right?

yes, for pull secret which I think more pressing than kubeconfig file steps.

In that case, this is a duplicate of #3619 and can be closed, unless there are objections. The stop issue on Windows is a seperate problem.

/close
Duplicate of #3619

authors: adrianriobo anjannath cfergeau gbraad praveenkumar

repo: crc-org/crc


text:
[BUG] errors after increasing memory and cpu on M2 mac

General information

OS: macOS
Hypervisor: vfkit
Did you run crc setup before starting it (Yes)
Running CRC on: Laptop

CRC version
CRC version: 2.28.0+e1f42d
OpenShift version: 4.13.14
Podman version: 4.4.4

CRC status
DEBU CRC version: 2.28.0+e1f42d
DEBU OpenShift version: 4.13.14
DEBU Podman version: 4.4.4
DEBU Running 'crc status'
CRC VM:          Stopped
OpenShift:       Stopped (v4.13.14)
RAM Usage:       0B of 0B
Disk Usage:      0B of 0B (Inside the CRC VM)
Cache Usage:     37.64GB
Cache Directory: /Users/will.holtam@gembaadvantage.com/.crc/cache

CRC config
- consent-telemetry                     : no

Host Operating System
ProductName:		macOS
ProductVersion:		14.0
BuildVersion:		23A344

Steps to reproduce

Install crc on M2 mac OS v14
Change default configuration settings to increase memory and cpu (attempted values from cpus=8 and memory=15000 and lower)
After multiple errors then attempt to go back to default configuration.
Get error below

Expected
CRC and OpenShift to be running with now issues. The ability to increase the memory and cpu allocated to 8 cpus and 15000 memory.
Actual
Either I get a go panic error:
INFO 4 operators are progressing: image-registry, network, openshift-controller-manager, service-ca
DEBU panic: runtime/cgo: misuse of an invalid Handle
DEBU
DEBU goroutine 17 [running, locked to thread]:
DEBU runtime/cgo.Handle.Value(...)
DEBU 	/Users/runner/hostedtoolcache/go/1.20.5/x64/src/runtime/cgo/handle.go:124
DEBU github.com/Code-Hex/vz/v3.shouldAcceptNewConnectionHandler(0x14000032060?, 0x0?, 0x14000000001?)
DEBU 	/Users/runner/go/pkg/mod/github.com/!code-!hex/vz/v3@v3.0.6/socket.go:231 +0x11c

OR I get a timeout error:
ERRO Cluster is not ready: cluster operators are still not stable after 12m30.490641416s
INFO Adding crc-admin and crc-developer contexts to kubeconfig...
DEBU Using address: api.crc.testing:6443
DEBU Dialing to 127.0.0.1:6443
ERRO Cannot update kubeconfig: read tcp 127.0.0.1:53411->127.0.0.1:6443: read: connection reset by peer
Started the OpenShift Cluster.

After which when running crc status; CRC VM is RUNNING; but OpenShift is Unreachable.
OR I get:
fault   0x0
DEBU error: Temporary error: ssh command errror:
command : timeout 5s oc get secret --context admin --cluster crc --kubeconfig /opt/kubeconfig
err             : Process exited with status 2
 - sleeping 1s
Failed to update kubeadmin user password: Temporary error: ssh command error:
command : timeout 5s oc get secret --context admin --cluster crc --kubeconfig /opt/kubeconfig
err             : Process exited with status 127

DEBU error: Temporary error: ssh command errror:
command : timeout 5s oc get secret --context admin --cluster crc --kubeconfig /opt/kubeconfig
err             : Process exited with status 2

After this, the terminal hangs.
Logs
Before gather the logs try following if that fix your issue
$ crc delete -f
$ crc cleanup
$ crc setup
$ crc start --log-level debug

This is the result of attempting the above commands:
https://gist.github.com/WilliamHoltam/a6a511f8caff4f6e309fc90c220104f9

DEBU panic: runtime/cgo: misuse of an invalid Handle
DEBU
DEBU goroutine 17 [running, locked to thread]:
DEBU runtime/cgo.Handle.Value(...)
DEBU 	/Users/runner/hostedtoolcache/go/1.20.5/x64/src/runtime/cgo/handle.go:124
DEBU github.com/Code-Hex/vz/v3.shouldAcceptNewConnectionHandler(0x14000032060?, 0x0?, 0x14000000001?)
DEBU 	/Users/runner/go/pkg/mod/github.com/!code-!hex/vz/v3@v3.0.6/socket.go:231 +0x11c

This is a vfkit bug which is  fixed by https://github.com/crc-org/vfkit/commit/17449d26252b59aca5f479c1245b815230dd89ae but I haven't made a release/added the fix to crc yet.
The other errors you are seeing could be related to a hard to reproduce bug in our network stack. You can try to kill all crc processes and try again.

Thank you for your help @cfergeau.
I just attempted to kill all crc processes and try again, and this was the result:
DEBU error: Temporary error: pull secret not updated to disk - sleeping 2s
DEBU retry loop: attempt 15
DEBU Running SSH command: <hidden>
DEBU SSH command failed
DEBU non-retriable error: failed to read /var/lib/kubelet/config.json file: ssh command error:
command : sudo cat /var/lib/kubelet/config.json
err     : wait: remote command exited without exit status or exit signal
:
DEBU Error closing ssh client: close tcp 127.0.0.1:50777->127.0.0.1:2222: use of closed network connection
Failed to update pull secret on the disk: Temporary error: pull secret not updated to disk (x15)
failed to read /var/lib/kubelet/config.json file: ssh command error:
command : sudo cat /var/lib/kubelet/config.json
err     : wait: remote command exited without exit status or exit signal

A subsequent attempt is also hitting what I think is the same vfkit bug you mentioned:
https://gist.github.com/WilliamHoltam/fa71fcacc6f178c7075a92994405c057

First time I see this one, it seems to be happening in oc rather than in vfkit so I don't think it's the same.

Just tested on an M2 with custom config and cluster is running, so I can not reproduce it:
ec2-user@Mac-mini ~ % crc status
CRC VM:          Running
OpenShift:       Running (v4.13.14)
RAM Usage:       6.797GB of 15.31GB
Disk Usage:      18.9GB of 32.68GB (Inside the CRC VM)
Cache Usage:     37.64GB
Cache Directory: /Users/ec2-user/.crc/cache
ec2-user@Mac-mini ~ % crc config view
- consent-telemetry                     : no
- cpus                                  : 8
- memory                                : 15000
ec2-user@Mac-mini ~ % sw_vers
ProductName:		macOS
ProductVersion:		13.5.2
BuildVersion:		22G91
ec2-user@Mac-mini ~ % uname -a
Darwin Mac-mini.local 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul  5 22:21:53 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6020 arm64
ec2-user@Mac-mini ~ % sysctl machdep.cpu.brand_string
machdep.cpu.brand_string: Apple M2 Pro

Oh dear, well that's bad news for me I guess 😂 .
I attempted fully uninstalling crc by running crc delete, then deleting /usr/local/bin/crc and the crc cache location as well as killing all crc processes. I'm not 100% sure if I managed to get everything.
I then reinstalled crc and ran crc setup and crc start and ended up with a new error:
DEBU error: Temporary error: pull secret not updated to disk - sleeping 2s
DEBU retry loop: attempt 14
DEBU Running SSH command: <hidden>
DEBU SSH command failed
DEBU non-retriable error: failed to read /var/lib/kubelet/config.json file: ssh command error:
command : sudo cat /var/lib/kubelet/config.json
err     : Process exited with status 139 from signal SEGV
: /usr/libexec/grepconf.sh: line 3: 11777 Illegal instruction     (core dumped) grep -qsi "^COLOR.*none" /etc/GREP_COLORS
/usr/libexec/grepconf.sh: line 3: 12054 Illegal instruction     (core dumped) grep -qsi "^COLOR.*none" /etc/GREP_COLORS
/usr/libexec/grepconf.sh: line 3: 12373 Illegal instruction     (core dumped) grep -qsi "^COLOR.*none" /etc/GREP_COLORS
Failed to update pull secret on the disk: Temporary error: pull secret not updated to disk (x14)
failed to read /var/lib/kubelet/config.json file: ssh command error:
command : sudo cat /var/lib/kubelet/config.json
err     : Process exited with status 139 from signal SEGV
: /usr/libexec/grepconf.sh: line 3: 11777 Illegal instruction     (core dumped) grep -qsi "^COLOR.*none" /etc/GREP_COLORS
/usr/libexec/grepconf.sh: line 3: 12054 Illegal instruction     (core dumped) grep -qsi "^COLOR.*none" /etc/GREP_COLORS
/usr/libexec/grepconf.sh: line 3: 12373 Illegal instruction     (core dumped) grep -qsi "^COLOR.*none" /etc/GREP_COLORS

When I reinstall it says that it has to upgrade CRC; so I think I'm not doing a full uninstall. Do you have instructions for how to completely uninstall CRC on mac so that I can start clean?

Typically I would:
crc cleanup
rm -rf ~/.crc

That should be enough for cleanup everything
Is it possible after you cleaned up 2.28.0 you got some old binary which is being used...which is the output now for crc version ?
Also just in case I just tested on a M2 with sonoma and again it is running:
ec2-user@Mac-mini ~ % crc status
CRC VM:          Running
OpenShift:       Running (v4.13.14)
RAM Usage:       6.529GB of 9.353GB
Disk Usage:      19.2GB of 32.68GB (Inside the CRC VM)
Cache Usage:     37.64GB
Cache Directory: /Users/ec2-user/.crc/cache
ec2-user@Mac-mini ~ % sw_vers
ProductName:		macOS
ProductVersion:		14.0
BuildVersion:		23A344

CRC version: 2.28.0+e1f42d
OpenShift version: 4.13.14
Podman version: 4.4.4

It decided so work for a day, but now I'm hitting the same bugs again. It's 1/5 chance whether or not it starts successfully on my machine; the behaviour isn't predictable

I would suspect problems with the machine or OS itself. Not much we can do, as we can reproduce this on multiple machines.

authors: WilliamHoltam adrianriobo cfergeau gbraad


text:
Sorting problem

We ran sift.js with the following code:
var sift = require('sift');
console.log(sift({}, [ 23, 42 ]));

The expected output is:
[ 23, 42 ]

The actual output is:
[ 42, 23 ]

We tracked this down to the following lines. If you comment them out, everything works as expected, but probably there's some meaning behind their existence ;-)
So, the question is how to deal with this issue properly? Any hints?
We would be happy to provide a pull request (e.g. to make sorting optional), but we wanted to make sure first that we are doing the right thing, before doing things right ;-))

@crcn The new version seems to work fine. :+1:
Is the logic that caused the original issue clear? Can you elaborate a bit on that for me?
I'm wondering if I should lock my package.json to use a specific version that I know to work (0.2.3), or if it's fairly certain that this won't happen again when trying to solve the issue that caused the original regression; i.e. I can rely on silent updates; e.g. ~0.2.

The original implementation was created on the idea that MongoDB automatically sorts results based on a search query. However, that doesn't seem to be the case, so I wouldn't expect this to be an issue again in any future version of sift.js.

authors: Redsandro crcn goloroden


text:
Python 3 release open issues

[ ] Need to fix Geotiff write out when the tiles are not contiguous
[ ] Need mechanism to pass parameters through compute manager to demprocessor
[ ] Need a helper function to compute everything needed to run any of the process functions
[ ] Need to fix the order of operations for the edge-fixing so that each tile is at least visited once before any other tile is processed a second time. That just gets 99% of the tile-to-tile errors

Just checking - was the development branch a working python3+ version or still a work in progress that now now been archived? pyDEM seems to be the one of the only good options, though perhaps not converted to python3 yet? Are there alternatives you might suggest?

For basic single-tile TWI processing, the develop branch should meet your Python3 needs.
I'm also happy to accept merge requests to the main branch to make a pip-installable Python3 version of PyDEM, I just don't have time to work on it myself.

See #25 . Finally had time to release Python 3 version. Should by up on PYPI soon.

authors: bgriffen mpu-creare

repo: creare-com/pydem