text:
Export Carbon components, add Sass support

Summary

A broad first pass at proxying carbon components by re-exporting them from our package. Allows users of this package to use it standalone, without having to manage Carbon packages as peer dependencies.
This is just a first pass to get things operational, I'll update #355 with work we still need to complete after this PR.

Change List (commits, features, bugs, etc)

Move all Carbon deps to be hard deps, not peer or dev.
Export most Carbon components from our package (some have naming collisions with our current components and we need to rectify those)
Import Accordion storybook story for use in our storybook, as an example of what we'll do with all 'stock' Carbon components.
Add Sass compilation

New .scss entrypoint alongside the .js one
This compiles all to one .css file placed in ./lib for consumers

Refactor AddCard styling from styled-components to sass as an example of how to do so for the remaining components

Related Issues

#355

Acceptance Test (how to verify the PR)

View the storybook, should have a new accordion story
Can validate the rollup build works by running yarn, though travis should do this as well.

This also provides the groundwork for #370, we'll just need to refactor the components away from styled-components.

@davidicus pushed a fix for those. Re added the global width: 100% and removed the styling overriding carbon defaults for add tile/clickable tile.

:tada: This PR is included in version 2.0.0-beta.4 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: IBM/carbon-addons-iot-react


text:
feat(table): provide StatefulTable and reducers for other teams to use

Summary

Created a StatefulTable component that has all the actions built in to it.  (This was previously being done in Storybook code)

Change List (commits, features, bugs, etc)

Upgraded to React 16.8 for HOOKS!
Created a tableReducer that can be reused with Redux.  Currently use it for the StatefulTable component
lots of testcases needed to cover the reducer code and StatefulTable component

Related Issues

Closes IBM/carbon-addons-iot-react#48
Closes IBM/carbon-addons-iot-react#49

Acceptance Test (how to verify the PR)

Run through the StatefulTable story and check all the major capabilities.

:tada: This PR is included in version 1.16.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.16.0 :tada:
The release is available on npm package (@release-1.x dist-tag)
Your semantic-release bot :package::rocket:

source: gharchive/pull-request

license_type: permissive

license_source: github-api


text:
upload uninstall_cnmon.sh for 2.2 release

verified the script works for both 2.1 and 2.2

I approve this PR.


text:
ScenarioDbManager/AutoScenarioDbTable - replace_scenario_in_db error

ScenarioDbManager.replace_scenario_in_db  throws error "'NoneType' object has no attribute 'delete'" when using AutoScenarioDbTable.
Use case:

ScenarioDbManager using AutoScenarioDbTable
Create a Schema
Upload zip file with scenarios

Problem is that scdb.create_schema() doesn't actually create a table for a AutoScenarioDbTable.
Next, the replace_scenario_in_db calls _delete_scenario_from_db, which is trying to delete the table that doesn't yet exist.
Proposed fix:

Only delete table if it exists

Update:
This happens for the second scenario we're inserting:

Table DOES exist in DB (has been dynamically created when the first scenario was inserted, but
db_table.table_metadata doesn't exist (i.e. None). Which can cause all kinds of issues where we need that to generate the SQLAlchemy SQL.

Question in SQLAlchemy: if pd.DataFrame.to_sql without a existing table definition, can we still get the table_metadata?

Bug is fixed by doing reflection (v0.5.4.1b). Make sure the metadata_obj is defined for the schema.
In AutoScenarioDbTable._reflect_db_table:
Implemented: table = Table(self.db_table_name, metadata_obj, autoload_with=engine), where metadata_obj is the object created at initialization (with the schema info)
Alternative: table = Table(self.db_table_name, MetaData(schema=schema), autoload_with=engine)

source: gharchive/issue

repo: IBM/dse-decision-optimization-utilities


text:
Implement Backup to COS Support

PR summary

Fixes: <! -- link to issue -->
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

:tada: This PR is included in version 0.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

repo: IBM/hpdb-go-sdk


text:
Adding new fields for 1.22 default compatibility

For: https://github.ibm.com/IBMPrivateCloud/roadmap/issues/62661

It looks good to me, but @bitscuit @Daniel-Fan can you pls take a look and merge?
It is safe to merge with EDB 1.18 version being used.

authors: giacomoch pgodowski

repo: IBM/ibm-common-service-operator


text:
1.2.0 Release Readme Fix

Fixed some syntax issues and one grammar issue.

Thanks for the pull request, our build/release process means we can't get this merged directly, but I'll include it into our upcoming 1.4.2 release.

repo: IBM/ibm-cos-sdk-js


text:
Failed to run a LangChain Agent with LLM based on ibm-generative-ai (using LangchainInterface)

Version Information

Python 3.11
Package Version: 0.5.1
Operating System: MacOS

What is the expected behavior?
I expect the code to work with ibm-generative-ai LLM as it works with OpenAI LLM.
Please provide a unit test that demonstrates the bug.
import os
from genai import Credentials
from genai.schemas import GenerateParams, ReturnOptions
from genai.extensions.langchain import LangChainInterface
BAM LLM
llm = LangChainInterface(
model="meta-llama/llama-2-70b-chat",
params=GenerateParams(
min_new_tokens=1,
max_new_tokens=200,
temperature=0.15,
top_k=20,
top_p=1.0,
#
decoding_method='sample',
#
stop_sequences=None,
repetition_penalty=1.15,
return_options=ReturnOptions(
generated_tokens=True,
token_logprobs=True,
# input_tokens=True,
# top_n_tokens=5
)
),
credentials=Credentials(
api_key=os.getenv("GENAI_KEY", None),
api_endpoint=os.getenv("GENAI_API", None)
)
)
Agent Tools
from langchain.agents import load_tools, initialize_agent, AgentType, AgentExecutor
from langchain.tools import StructuredTool, tool
tools = load_tools(
tool_names=[
'ddg-search',  # pip install duckduckgo-search
'llm-math',  # pip install numexpr
],
llm=llm
)
Agent
agent = initialize_agent(
tools=tools,
llm=llm,
agent=AgentType.CHAT_ZERO_SHOT_REACT_DESCRIPTION,
verbose=True,
handle_parsing_errors=True
)
user_query = 'What is CVSS score of CVE-2021-44228? What is the severity of the score?'
Debug
from langchain_core.tracers import langchain
langchain.debug = True
Run Agent
agent.run(user_query)
What is the actual behavior?

Entering new AgentExecutor chain...
Could not parse LLM output: Answer:

(Note: The current year is 2023.)
Observation: Invalid or incomplete response
Other notes on how to reproduce the issue?
Any possible solutions?
Can you identify the location in the GENAI source code where the problem exists?
If the bug is confirmed, would you be willing to submit a PR?
Yes / No (Help can be provided if you need assistance submitting a PR)

Hey @aviadjo,
The issue you mentioned isn't directly tied to the ibm-generative-ai library but rather to the LLMs you're using.
The prompt the LLM receives is quite complex and the LLM has to respond in the exact format described in the prompt generated by Lanchain depending on what tools you are using.
Sometimes, less well-trained LLMs might not provide responses in the exact format required. In such instances, Langchain cannot parse them, resulting in the message:  Could not parse LLM output. You can observe how the response is parsed here.
To make it work I would try to change the params or try another model like meta-llama/llama-2-70b and give it a few tries.

Thank you, I changed to meta-llama/llama-2-70b model and it worked!

authors: David-Kristek aviadjo

repo: IBM/ibm-generative-ai


text:
Image Request: Grafana upgrade to 9.5.13

Software Name
Grafana
Software Version
9.5.13 (to address CVE-2023-4822 with classification "high")
Software Value
Beautiful popular dashboards.
Requestors Role
Just verified that it builds with my Dockerfile (that I can share when necessary)
Please Note
I also dropped some packages like ````curl``` from the image because scanners were concerned about it. Also changed to not run as root as that's also considered bad practice.

I have multiple customers who also rely on this dependency.  Is there any update as to when this update will be made available?

We'll take a look and estimate an update for this.  I don't currently have a timeframe for an upgrade, but we'll try to get something soon.

If you're not afraid to take gifts from strangers, you might like this one
docker pull rvdheij/grafana:9.5.13
Be aware that it runs the grafana process not as root anymore, so you may have to chown things in a persistent volume.

I just wanted to provide an update..
As of now, I have updated the unix services in all currently hosted Grafana images on icr. Currently, the ICR vulnerability manager shows these images as having 0 security issues. With that said, I am aware that most (with few exceptions) versions of Grafana < 10.2.2 are deemed to be insecure when referencing the link attached to this issue.
I have been attempting to build version 10.2.2 but have found some minor issues when resolving dependencies needed for the front-end portion of the build process - which I am currently debugging. I am hopeful to upload a working 10.2.2 version of Grafana within this week.

Thank you for the update!

No problem!
Grafana version 10.2.2 is now uploaded on icr icr.io/ibmz/grafana:10.2.2
Please reference our official index for the appropriate pull string that includes the sha256 value.
Thank you to @rvdheij for the pointers - you were very helpful!
I'll close this for now, but if there are any issues with the image feel free to reopen or create a new one.

Thank you!

authors: JoshWisniewski00 jbostian korpx-z rvdheij

repo: IBM/ibm-z-oss-hub


text:
feat: Generate new events with complex arrays

This pull request add the generation of events for two new topics:
PRODUCT.RETURNS: events for return requests that include several products
PRODUCT.REVIEWS: events for product reviews
NB: The JAR with dependencies is currently committed in my branch for testing purposes. It is not intended to be merged.

I feel sorry for Loosehanger that they're getting products returned every 30 seconds, but otherwise this all looks great :-)
Please can you remove the jars from the target folder (which I know you were already planning to do) and I'll approve/merge

I have changed a little bit the default frequency for the return request and product review events :-)
I have also removed the JARs in the target folder.


text:
Currently unsupported HTTP authentication protocol type 'http' and scheme 'bearer' in OAS

Am not able to generate schema from openapi 3.0.1 spec when using bearer scheme. Getting below error
Error: UNSUPPORTED_HTTP_SECURITY_SCHEME - Currently unsupported HTTP authentication protocol type 'http' and scheme 'bearer' in OAS
I have my security scheme defined as below:
  securitySchemes:
    bearerAuth:
      type: http
      scheme: bearer
      bearerFormat: JWT

Is there any alternative way to fix this?

Finally got it running. Did following changes:
Change security scheme type to apiKey
securitySchemes:
    bearerAuth:
      type: apiKey
      in: header
      name: Authorization

Create oas options object
let oasOptions = {
            strict:true,
        headers: {
            'X-Origin': 'GraphQL'
        },
        tokenJSONpath: '$.jwt'
    };

Pass object as a param:
const { schema, report } = await createGraphQLSchema(usersSwagger,oasOptions);
Add middleware to append jwt in request:
router.use(function (req, res, next) {
        // put the jwt back into the request so oasgraph can use it for
        // the context of each request via the tokenJSONPath option
        if (req.headers && req.headers.authorization) {
            req.jwt = req.headers.authorization.replace(/^Bearer /, '');
            console.log('----------->>',req.jwt);
        }
        next();
    });

We now have a bearer token viewer thanks to @cancan101. I will now close this issue.

authors: Alan-Cha AnirudhaGohokar

repo: IBM/openapi-to-graphql

license: MIT


text:
Rollout callbacks

Related Issue
closes #129
Related PRs
This PR is not dependent on any other PR
What this PR does / why we need it
why we need it > please check https://github.com/IBM/oper8/issues/129.
what this PR does:

Added two callbacks, after_deploy_unsuccessful and after_verify_unsuccessful. They are executed at Rollout.rollout depending on the deployment/verification results.
Added tests for those new two callbacks at tests/test_rollout_manager.py
Added development environment setup instructions at CONTRIBUTING.md
Updated tox.ini and scripts/run_tests.sh to only execute the part of the tests when needed. (Test commands are described at CONTRIBUTING.md)

Details:
after_deploy_unsuccessful is executed when Phase 1: Deploy Graph is not completed. after_verify_unsuccessful is executed when Phase1 and Phase2 are completed but Phase3 is not. They could be used when you want to run some callback functions when deployment or verification fails.
Tests:
Verified formatting and linting are passed:
$ tox -e fmt,lint
...
All checks passed!
  fmt: OK (7.42=setup[2.62]+cmd[4.80] seconds)
  lint: OK (0.98=setup[0.60]+cmd[0.39] seconds)
  congratulations :) (8.54 seconds)

Verifies that all tests have been passed:
$ tox -e py312

Detailed test results
======================================================================== test session starts =========================================================================
platform darwin -- Python 3.12.1, pytest-8.3.3, pluggy-1.5.0
cachedir: .tox/py312/.pytest_cache
rootdir: /Users/yuki462/Codes/github-ibm-repos/forked/oper8-yuki462
configfile: pyproject.toml
plugins: cov-5.0.0, timeout-2.3.1
collected 856 items

tests/dag/test_completion_state.py .                                                                                [  0%]
tests/dag/test_graph.py .........                                                                                [  1%]
tests/dag/test_node.py .........                                                                                [  2%]
tests/dag/test_runner.py ...............                                                                                [  3%]
tests/deploy_manager/test_dry_run_deploy_manager.py ..............................................................                                             [ 11%]
tests/deploy_manager/test_openshift_deploy_manager.py ...............................................................                                          [ 18%]
tests/deploy_manager/test_owner_references.py ..........                                                                                [ 19%]
tests/deploy_manager/test_replace_utils.py ...........                                                                                [ 21%]
tests/temporary_patch/test_temporary_patch_component.py ..............                                                                                [ 22%]
tests/temporary_patch/test_temporary_patch_controller.py ..........                                                                                [ 23%]
tests/test_component.py .................................                                                                                [ 27%]
tests/test_config.py .................                                                                                [ 29%]
tests/test_controller.py .........................                                                                                [ 32%]
tests/test_decorator.py ....                                                                                [ 33%]
tests/test_exceptions.py ............                                                                                [ 34%]
tests/test_main.py ..................                                                                                [ 36%]
tests/test_patch.py .....................                                                                                [ 39%]
tests/test_patch_strategic_merge.py .................                                                                                [ 41%]
tests/test_reconcile.py ..........................................................................................                                             [ 51%]
tests/test_rollout_manager.py ................                                                                                [ 53%]
tests/test_session.py ........................                                                                                [ 56%]
tests/test_setup_vcs.py ......                                                                                [ 56%]
tests/test_status.py .............................................                                                                                [ 62%]
tests/test_utils.py ................                                                                                [ 64%]
tests/test_vcs.py ..................                                                                                [ 66%]
tests/test_verify_resources.py ..............................................                                                                                [ 71%]
tests/watch_manager/ansible_watch_manager/modules/test_k8s_application.py .............                                                                        [ 73%]
tests/watch_manager/ansible_watch_manager/modules/test_log_rotator.py .                                                                                [ 73%]
tests/watch_manager/ansible_watch_manager/test_ansible_watch_manager.py ..............                                                                         [ 74%]
tests/watch_manager/python_watch_manager/filters/test_common_filters.py ..                                                                                [ 75%]
tests/watch_manager/python_watch_manager/filters/test_filters.py ..........                                                                                [ 76%]
tests/watch_manager/python_watch_manager/filters/test_manager.py .......                                                                                [ 76%]
tests/watch_manager/python_watch_manager/leader_election/test_annotation.py .....                                                                              [ 77%]
tests/watch_manager/python_watch_manager/leader_election/test_init.py ....                                                                                [ 78%]
tests/watch_manager/python_watch_manager/leader_election/test_lease.py ......                                                                                [ 78%]
tests/watch_manager/python_watch_manager/leader_election/test_life.py .......                                                                                [ 79%]
tests/watch_manager/python_watch_manager/test_python_watch_manager.py .....                                                                                [ 80%]
tests/watch_manager/python_watch_manager/test_reconcile_process_entrypoint.py ...                                                                              [ 80%]
tests/watch_manager/python_watch_manager/threads/test_heartbeat.py ...                                                                                [ 80%]
tests/watch_manager/python_watch_manager/threads/test_reconcile_thread.py ......                                                                               [ 81%]
tests/watch_manager/python_watch_manager/threads/test_timer_thread.py ..                                                                                [ 81%]
tests/watch_manager/python_watch_manager/threads/test_watch_thread.py ..........                                                                               [ 82%]
tests/watch_manager/python_watch_manager/utils/test_pwm_util_common.py ..........                                                                              [ 84%]
tests/watch_manager/test_dry_run_watch_manager.py .....                                                                                [ 84%]
tests/watch_manager/test_watch_manager_base.py .....                                                                                [ 85%]
tests/x/datastores/cos/test_cos_connection.py ........................                                                                                [ 88%]
tests/x/datastores/postgres/test_pg_factory.py .                                                                                [ 88%]
tests/x/datastores/postgres/test_postgres_connection.py .........................                                                                              [ 91%]
tests/x/datastores/redis/test_redis_connection.py ...........                                                                                [ 92%]
tests/x/datastores/redis/test_redis_factory.py ..                                                                                [ 92%]
tests/x/datastores/redis/test_redis_interfaces.py .                                                                                [ 92%]
tests/x/datastores/test_factory_base.py ...................                                                                                [ 94%]
tests/x/utils/test_abc_static.py .....                                                                                [ 95%]
tests/x/utils/test_common.py ..                                                                                [ 95%]
tests/x/utils/test_deps_annotation.py ..................                                                                                [ 97%]
tests/x/utils/test_tls.py .                                                                                [ 98%]
tests/x/utils/test_tls_context.py ............                                                                                [ 99%]
tests/x/utils/tls_context/test_internal.py ....                                                                                [ 99%]
tests/x/utils/tls_context/test_tls_preconditions.py .                                                                                [100%]

---------- coverage: platform darwin, python 3.12.1-final-0 ----------
Name                                                                       Stmts   Miss  Cover
----------------------------------------------------------------------------------------------
oper8/__init__.py                                                             11      0   100%
oper8/__main__.py                                                             65      0   100%
oper8/_version.py                                                             11     11     0%
oper8/cmd/__init__.py                                                          4      0   100%
oper8/cmd/base.py                                                              8      0   100%
oper8/cmd/check_heartbeat.py                                                  29      0   100%
oper8/cmd/run_operator_cmd.py                                                 90      1    99%
oper8/cmd/setup_vcs_cmd.py                                                    18      1    94%
oper8/component.py                                                           173      0   100%
oper8/config/__init__.py                                                       7      0   100%
oper8/config/config.py                                                         9      0   100%
oper8/config/validation.py                                                   124      0   100%
oper8/constants.py                                                            15      0   100%
oper8/controller.py                                                           94      3    97%
oper8/dag/__init__.py                                                          4      0   100%
oper8/dag/completion_state.py                                                 29      0   100%
oper8/dag/graph.py                                                            52      0   100%
oper8/dag/node.py                                                             94      0   100%
oper8/dag/runner.py                                                          135      0   100%
oper8/decorator.py                                                            19      0   100%
oper8/deploy_manager/__init__.py                                               4      0   100%
oper8/deploy_manager/base.py                                                  21      0   100%
oper8/deploy_manager/dry_run_deploy_manager.py                               282      5    98%
oper8/deploy_manager/kube_event.py                                            15      0   100%
oper8/deploy_manager/openshift_deploy_manager.py                             343     15    96%
oper8/deploy_manager/owner_references.py                                      40      0   100%
oper8/deploy_manager/replace_utils.py                                         59      4    93%
oper8/exceptions.py                                                           35      0   100%
oper8/log_format.py                                                           19      9    53%
oper8/managed_object.py                                                       29      0   100%
oper8/patch.py                                                                37      0   100%
oper8/patch_strategic_merge.py                                                71      0   100%
oper8/reconcile.py                                                           366      1    99%
oper8/rollout_manager.py                                                     148     13    91%
oper8/session.py                                                             154      0   100%
oper8/setup_vcs.py                                                           113      0   100%
oper8/status.py                                                              160      4    98%
oper8/temporary_patch/temporary_patch_component.py                            54      0   100%
oper8/temporary_patch/temporary_patch_controller.py                           36      0   100%
oper8/test_helpers/__init__.py                                                 0      0   100%
oper8/test_helpers/helpers.py                                                339    236    30%
oper8/test_helpers/kub_mock.py                                               409    345    16%
oper8/test_helpers/oper8x_helpers.py                                          22     22     0%
oper8/test_helpers/pwm_helpers.py                                            102    102     0%
oper8/utils.py                                                               113      1    99%
oper8/vcs.py                                                                 129      3    98%
oper8/verify_resources.py                                                     91      0   100%
oper8/version.py                                                               5      5     0%
oper8/watch_manager/__init__.py                                                6      0   100%
oper8/watch_manager/ansible_watch_manager/__init__.py                          1      0   100%
oper8/watch_manager/ansible_watch_manager/ansible_watch_manager.py           128      0   100%
oper8/watch_manager/ansible_watch_manager/modules/k8s_application.py          83      7    92%
oper8/watch_manager/ansible_watch_manager/modules/log_rotator.py               8      0   100%
oper8/watch_manager/base.py                                                   48      3    94%
oper8/watch_manager/dry_run_watch_manager.py                                  47      1    98%
oper8/watch_manager/python_watch_manager/__init__.py                           1      0   100%
oper8/watch_manager/python_watch_manager/filters/__init__.py                   3      0   100%
oper8/watch_manager/python_watch_manager/filters/common.py                    48      3    94%
oper8/watch_manager/python_watch_manager/filters/filters.py                  121      0   100%
oper8/watch_manager/python_watch_manager/filters/manager.py                   76      5    93%
oper8/watch_manager/python_watch_manager/leader_election/__init__.py          17      1    94%
oper8/watch_manager/python_watch_manager/leader_election/annotation.py        60      5    92%
oper8/watch_manager/python_watch_manager/leader_election/base.py              80     11    86%
oper8/watch_manager/python_watch_manager/leader_election/dry_run.py           12      0   100%
oper8/watch_manager/python_watch_manager/leader_election/lease.py             48      3    94%
oper8/watch_manager/python_watch_manager/leader_election/life.py              46      3    93%
oper8/watch_manager/python_watch_manager/python_watch_manager.py              66      7    89%
oper8/watch_manager/python_watch_manager/reconcile_process_entrypoint.py     140     41    71%
oper8/watch_manager/python_watch_manager/threads/__init__.py                   5      0   100%
oper8/watch_manager/python_watch_manager/threads/base.py                      32      1    97%
oper8/watch_manager/python_watch_manager/threads/heartbeat.py                 35      0   100%
oper8/watch_manager/python_watch_manager/threads/reconcile.py                213     23    89%
oper8/watch_manager/python_watch_manager/threads/timer.py                     74      4    95%
oper8/watch_manager/python_watch_manager/threads/watch.py                    169     22    87%
oper8/watch_manager/python_watch_manager/utils/__init__.py                     4      0   100%
oper8/watch_manager/python_watch_manager/utils/common.py                      40      0   100%
oper8/watch_manager/python_watch_manager/utils/constants.py                    5      0   100%
oper8/watch_manager/python_watch_manager/utils/log_handler.py                 27      3    89%
oper8/watch_manager/python_watch_manager/utils/types.py                      112      3    97%
oper8/x/__init__.py                                                            0      0   100%
oper8/x/datastores/__init__.py                                                 6      0   100%
oper8/x/datastores/connection_base.py                                         25      0   100%
oper8/x/datastores/cos/__init__.py                                             2      0   100%
oper8/x/datastores/cos/connection.py                                         111      1    99%
oper8/x/datastores/cos/factory.py                                              5      0   100%
oper8/x/datastores/cos/interfaces.py                                          32     32     0%
oper8/x/datastores/factory_base.py                                           103      0   100%
oper8/x/datastores/interfaces.py                                              19      0   100%
oper8/x/datastores/postgres/__init__.py                                        2      0   100%
oper8/x/datastores/postgres/connection.py                                    107      1    99%
oper8/x/datastores/postgres/factory.py                                         5      0   100%
oper8/x/datastores/postgres/interfaces.py                                      7      7     0%
oper8/x/datastores/redis/__init__.py                                           2      0   100%
oper8/x/datastores/redis/connection.py                                       107      2    98%
oper8/x/datastores/redis/factory.py                                            5      0   100%
oper8/x/datastores/redis/interfaces.py                                        30      1    97%
oper8/x/oper8x_component.py                                                   30      5    83%
oper8/x/utils/__init__.py                                                      0      0   100%
oper8/x/utils/abc_static.py                                                   20      0   100%
oper8/x/utils/common.py                                                       95     14    85%
oper8/x/utils/constants.py                                                     6      0   100%
oper8/x/utils/deps_annotation.py                                             103      0   100%
oper8/x/utils/tls.py                                                          32      1    97%
oper8/x/utils/tls_context/__init__.py                                          2      0   100%
oper8/x/utils/tls_context/factory.py                                          37      0   100%
oper8/x/utils/tls_context/interface.py                                        20      0   100%
oper8/x/utils/tls_context/internal.py                                         87      0   100%
oper8/x/utils/tls_context/public.py                                           11      0   100%
----------------------------------------------------------------------------------------------
TOTAL                                                                       6953    991    86%
Coverage HTML written to dir htmlcov

Required test coverage of 85.0% reached. Total coverage: 85.75%

================================================================== 856 passed in 107.99s (0:01:47) ===================================================================
  py312: OK (112.90=setup[2.46]+cmd[110.43] seconds)
  congratulations :) (113.02 seconds)

If applicable**

[x] this PR contains documentation
[x] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

What gif most accurately describes how I feel towards this PR?

@gabe-l-hart
I have applied all of your suggested commits and verified that all tests pass. Thank you for the review!
$ tox -e py312
...
Required test coverage of 85.0% reached. Total coverage: 85.80%

================================================================== 856 passed in 104.89s (0:01:44) ===================================================================
  py312: OK (108.59=setup[2.08]+cmd[106.52] seconds)
  congratulations :) (108.70 seconds)


text:
fix: bump java core to 9.15.2

PR summary
This PR bumps the java core version to the latest
PR Checklist
Please make sure that your PR fulfills the following requirements:

[ ] The commit message follows the Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

:tada: This PR is included in version 0.22.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

authors: ibm-devx-sdk padamstx

repo: IBM/platform-services-java-sdk


text:
Update applypatch-280.sh

add transactoin-manager patching into the hotfix.
https://github.ibm.com/ProjectAbell/abell-tracking/issues/39506

test with installation of 280.
localhost:2.8.0 l$ ./applypatch-280.sh
This is hub
Kafka already 3.6.0 for AMQ 2.6.0-2
Saved transaction-manager deployment
Patching transaction-manager deployment...
deployment.apps/transaction-manager patched
Saving original guardian-configmap yaml
Updating default data mover pod resource settings...
configmap/guardian-configmap data updated
configmap/guardian-configmap data updated
configmap/guardian-configmap data updated
configmap/guardian-configmap data updated
configmap/guardian-configmap data updated
configmap/guardian-configmap data updated

repo: IBM/storage-fusion


text:
While building the code first time it throws the following error

riginoommen-mac:template-graphql-typescript riginoommen$ npm run build

> template-graphql-typescript@1.0.0 prebuild /Users/riginoommen/study/template-graphql-typescript
> npm run clean

> template-graphql-typescript@1.0.0 clean /Users/riginoommen/study/template-graphql-typescript
> rimraf dist

> template-graphql-typescript@1.0.0 build /Users/riginoommen/study/template-graphql-typescript
> tsc

test/pact-publish.ts:3:31 - error TS2307: Cannot find module '@pact-foundation/pact'.

3 import {VerifierOptions} from '@pact-foundation/pact';
                                ~~~~~~~~~~~~~~~~~~~~~~~

test/pact-verify.ts:3:41 - error TS2307: Cannot find module '@pact-foundation/pact'.

3 import {Verifier, VerifierOptions} from '@pact-foundation/pact';
                                          ~~~~~~~~~~~~~~~~~~~~~~~

Found 2 errors.

riginoommen-mac:template-graphql-typescript riginoommen$ npm run build

> template-graphql-typescript@1.0.0 prebuild /Users/riginoommen/study/template-graphql-typescript
> npm run clean

> template-graphql-typescript@1.0.0 clean /Users/riginoommen/study/template-graphql-typescript
> rimraf dist

> template-graphql-typescript@1.0.0 build /Users/riginoommen/study/template-graphql-typescript
> tsc

test/pact-publish.ts:3:31 - error TS2307: Cannot find module '@pact-foundation/pact'.

3 import {VerifierOptions} from '@pact-foundation/pact';
                                ~~~~~~~~~~~~~~~~~~~~~~~

test/pact-verify.ts:3:41 - error TS2307: Cannot find module '@pact-foundation/pact'.

3 import {Verifier, VerifierOptions} from '@pact-foundation/pact';
                                          ~~~~~~~~~~~~~~~~~~~~~~~

Found 2 errors.

When i try to install the @pact-foundation/pact it shows error after the postinstall

not reproducible

authors: csantanapr riginoommen

repo: IBM/template-graphql-typescript


text:
[Feet Drawing] How could I draw the Feet?

I walked through the code to find 'feet keypoints' showed bellow:
https://github.com/IDEA-Research/DWPose/blob/3dca5db79d9f9ffdd378753ddf6ec66535aace88/ControlNet-v1-1-nightly/annotator/dwpose/__init__.py#L58
But I could not find any method drawing the feet...
drawing body, hands, face here
Is there anyone could kindly help me out of this issue.
I don't know how to define 'edges' (like in draw_handpose ) for feet, or maybe I can draw feet by draw_handpose?

Hi, hope everything is fine for you.
I am also working on the foot issue, and luckily i find some other repos that have the foot draw code at here:
https://github.com/novitalabs/AnimateAnyone/blob/ee2cf9e7d2a4d8aea33152624ffee239d1705c8d/src/dwpose/__init__.py#L35
which might solve your problem.

repo: IDEA-Research/DWPose


text:
🛑 IDR (image 2895051) is down

In 1751fc1, IDR (image 2895051) (https://idr.openmicroscopy.org/webclient/?show=image-2895051) was down:

HTTP code: 0
Response time: 0 ms

Resolved: IDR (image 2895051) is back up in 3ffe5af after 14 minutes.

repo: IDR/upptime


text:
fix(comp:table): default selectable column shouldn't show ellipsis

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines
[x] Tests for the changes have been added/updated or not needed
[x] Docs and demo have been added/updated or not needed

What is the current behavior?
表格配置 ellipsis 后，selectable 列显示省略号
What is the new behavior?
增加默认selectable列宽度，避免默认selectable列显示省略号
Other information

dup #1245

repo: IDuxFE/idux


text:
Implement outstanding wind resource assessment data model refinements and extensions

Refine naming convention in the schema to cover data availability: #33.
Include measurement station weights in the turbine wind resource assessment: #47.
Update README to include recommendation to use best practice for data integrity and security: #5.
Make a range of minor refinements to data models, which were outstanding from the schema review.

Hi @AlinaBurmesterRWE, thank you very much. I fixed that typo and will merge now.

Hi @jonssonchristian, I am through the review. There is only one typo in the example of the README (year was not matching), other than that nice to read and interesting to see the new weighting set up.


text:
113 AMED-CREST manual entries to disease or donor_health_status

some entries in the old column donor_health_status have been filled manually and cannot be automatically assigned to the new columns resulting from #70
see list: list_EpiRR_tofill_healthstatus.txt

ask again

have been discussed, some mistakes have been resolved

repo: IHEC/epimap-metadata-harmonization


text:
Let the ui consumes data from the webservice

At the moment, the ui loads its data from a local json file.
The task is to connect the ui with the webservice.

Duplicated with #30

repo: IIDP/OSTMap

license_source: bigquery


text:
chore(fmt): update pre-commit deps

Description

Updates pre-commit deps.
Moreover, precommit runs now on all PRs automatically. See: https://pre-commit.ci/
You can trigger a re-run on a pull request by commenting pre-commit.ci run (must appear on a line by itself) - see below.
Related Issue

N/A
Checklist

[X] I've formatted the PR title in accordance with the structure of the conventional commit messages.
[X] I've updated the code style using pre-commit if needed.
[X] I've updated or supplemented the documentation as needed.
[X] I've read the CODE_OF_CONDUCT.md document.
[X] I've read the CONTRIBUTING.md guide.

pre-commit.ci run

pre-commit.ci run

seems like the superlinter has problems with snakefmt

authors: alethomas thomasbtf

repo: IKIM-Essen/uncovar


text:
🛑 namescape tagger is down

In 8653739, namescape tagger (https://ner.namescape.nl/namescape/ui) was down:

HTTP code: 503
Response time: 442 ms

Resolved: namescape tagger is back up in 3f0a14c.

repo: INL/ivdnt-statusoverzicht


text:
The thebe integration ("Run code") does not work

Binder is fine but the alternative thebe launcher does not work: the is no output display in cells, just forever "Waiting for kernel..." the kernel starts but the files are not where they are expected to be:

FileNotFoundError: [Errno 2] No such file or directory: '../datasets/adult-census.csv'

Full traceback:

---------------------------------------------------------------------------
FileNotFoundError                         Traceback (most recent call last)
Cell In [1], line 3
      1 import pandas as pd
----> 3 adult_census = pd.read_csv("../datasets/adult-census.csv")

File /srv/conda/envs/notebook/lib/python3.10/site-packages/pandas/util/_decorators.py:211, in deprecate_kwarg.<locals>._deprecate_kwarg.<locals>.wrapper(*args, **kwargs)
    209     else:
    210         kwargs[new_arg_name] = new_arg_value
--> 211 return func(*args, **kwargs)

File /srv/conda/envs/notebook/lib/python3.10/site-packages/pandas/util/_decorators.py:317, in deprecate_nonkeyword_arguments.<locals>.decorate.<locals>.wrapper(*args, **kwargs)
    311 if len(args) > num_allow_args:
    312     warnings.warn(
    313         msg.format(arguments=arguments),
    314         FutureWarning,
    315         stacklevel=find_stack_level(inspect.currentframe()),
    316     )
--> 317 return func(*args, **kwargs)

File /srv/conda/envs/notebook/lib/python3.10/site-packages/pandas/io/parsers/readers.py:950, in read_csv(filepath_or_buffer, sep, delimiter, header, names, index_col, usecols, squeeze, prefix, mangle_dupe_cols, dtype, engine, converters, true_values, false_values, skipinitialspace, skiprows, skipfooter, nrows, na_values, keep_default_na, na_filter, verbose, skip_blank_lines, parse_dates, infer_datetime_format, keep_date_col, date_parser, dayfirst, cache_dates, iterator, chunksize, compression, thousands, decimal, lineterminator, quotechar, quoting, doublequote, escapechar, comment, encoding, encoding_errors, dialect, error_bad_lines, warn_bad_lines, on_bad_lines, delim_whitespace, low_memory, memory_map, float_precision, storage_options)
    935 kwds_defaults = _refine_defaults_read(
    936     dialect,
    937     delimiter,
   (...)
    946     defaults={"delimiter": ","},
    947 )
    948 kwds.update(kwds_defaults)
--> 950 return _read(filepath_or_buffer, kwds)

File /srv/conda/envs/notebook/lib/python3.10/site-packages/pandas/io/parsers/readers.py:605, in _read(filepath_or_buffer, kwds)
    602 _validate_names(kwds.get("names", None))
    604 # Create the parser.
--> 605 parser = TextFileReader(filepath_or_buffer, **kwds)
    607 if chunksize or iterator:
    608     return parser

File /srv/conda/envs/notebook/lib/python3.10/site-packages/pandas/io/parsers/readers.py:1442, in TextFileReader.__init__(self, f, engine, **kwds)
   1439     self.options["has_index_names"] = kwds["has_index_names"]
   1441 self.handles: IOHandles | None = None
-> 1442 self._engine = self._make_engine(f, self.engine)

File /srv/conda/envs/notebook/lib/python3.10/site-packages/pandas/io/parsers/readers.py:1729, in TextFileReader._make_engine(self, f, engine)
   1727     is_text = False
   1728     mode = "rb"
-> 1729 self.handles = get_handle(
   1730     f,
   1731     mode,
   1732     encoding=self.options.get("encoding", None),
   1733     compression=self.options.get("compression", None),
   1734     memory_map=self.options.get("memory_map", False),
   1735     is_text=is_text,
   1736     errors=self.options.get("encoding_errors", "strict"),
   1737     storage_options=self.options.get("storage_options", None),
   1738 )
   1739 assert self.handles is not None
   1740 f = self.handles.handle

File /srv/conda/envs/notebook/lib/python3.10/site-packages/pandas/io/common.py:857, in get_handle(path_or_buf, mode, encoding, compression, memory_map, is_text, errors, storage_options)
    852 elif isinstance(handle, str):
    853     # Check whether the filename is to be opened in binary mode.
    854     # Binary mode does not support 'encoding' and 'newline'.
    855     if ioargs.encoding and "b" not in ioargs.mode:
    856         # Encoding
--> 857         handle = open(
    858             handle,
    859             ioargs.mode,
    860             encoding=ioargs.encoding,
    861             errors=errors,
    862             newline="",
    863         )
    864     else:
    865         # Binary mode
    866         handle = open(handle, ioargs.mode)

FileNotFoundError: [Errno 2] No such file or directory: '../datasets/adult-census.csv'

@lesteve found out that this is probably caused by this bug in jupyter-book:

https://github.com/executablebooks/jupyter-book/issues/1304

Shall we find a way disable the thebe launcher instead?

I confirm the working directory is the home folder of the docker container:

As a stop-gap solution, we can probably remove the thebe integration via https://jupyterbook.org/en/stable/interactive/thebe.html#activate-thebe

I opened #670 to disable thebe integration

authors: lesteve ogrisel

repo: INRIA/scikit-learn-mooc


text:
Reanalysis of 1-second data sets which are NOT new

year 2020 anaylsis:
new uploads: ['NGK', 'PPT', 'TTB', 'VSS', 'WNG']
Problem1: neither NGK nor TTB, VSS or WNG are new (actually they are from July 2022)
PPT from 24.01.2023
Probelm2: NGK producing strange report

The "new" data sets has parameters as follows:
{'amount': 366, 'type': '.cdf', 'lastmodified': 1658880000.0, 'obscode': 'NGK', 'rootdir': '/mnt/second/step120S/2020_step1/NGK', 'flag': None, 'moddict': {'NGK_20200101_000000_pt1s_4.cdf': 1658880000.0, 'NGK_20200102_000000_pt1s_4.cdf': 1658880000.0, 'NGK_20200103_000000_pt1s_4.cdf': 1658880000.0, 'NGK_20200104_000000_pt1s_4.cdf':  ...
The previoulsy uploaded data set looks like:
{'amount': 366, 'type': '.cdf', 'lastmodified': 1658924760.0, 'obscode': 'NGK', 'rootdir': '/mnt/second/step120S/2020_step1/NGK', 'flag': None, 'moddict': {'NGK_20200101_000000_pt1s_4.cdf': 1658924100.0, 'NGK_20200102_000000_pt1s_4.cdf': 1658924100.0, 'NGK_20200103_000000_pt1s_4.cdf': 1658924100.0, 'NGK_20200104_000000_pt1s_4.cdf': ....
Converting the UNIX timestamps shows something like:
datetime.fromtimestamp(1658924100.0)
datetime.datetime(2022, 7, 27, 14, 15)
datetime.fromtimestamp(1658880000.0)
datetime.datetime(2022, 7, 27, 2, 0)
So there is a ~12hour difference and I have no idea where it comes from. The "modification" happened around 26.01.2023, but neither the Observatory nor me changed anything, which would also be difficult without changing the modification time towards January 2023. Unlike other files from other observatories, files from NGK dont have creation times (only hours). Is it a server issue?

The strange report is actually not strange but not understandable as is. This has been changed for version 1.0.7.
Before:
Issue : did not meet criteria
After:
Warning: IMOS41 confirmed but no F values provided

In order to mask this issue, file comparison will be done only on daily accuracy, active since 30.01.2023. Close this issue if no further problems occur...

repo: INTERMAGNET/IMBOT


text:
🛑 IOGT CLOUD is down

In 17b311f, IOGT CLOUD ($CLOUD_SERVER) was down:

HTTP code: 530
Response time: 734 ms

Resolved: IOGT CLOUD is back up in a15f1ee.

repo: IOGT/upptime


text:
Add CC BY-SA 4.0

#28 does not really look good to me, because the files are not actually markdown, but just plain text. So I'm adding this, with the style built based on the original license in the Creative Commons website.
P.S.: It seems this repository is inactive, but someone might benefit from PRs as well. I hope it gets merged soon, however. :)

See also https://github.com/idleberg/Creative-Commons-Markdown - got to catch'em all!

authors: machitgarha millette

repo: IQAndreas/markdown-licenses

license: unlicense


text:
Add README.md

Add retries

Кажется ветка дублирует один из коммитов из мастера.

Поправила

authors: Nunkyl nicl-nno

repo: ITMO-NSS-team/NSS-Ops


text:
Problem with URDF_USE_SELF_COLLISION flag

https://github.com/ITMORobotics/itmobotics_sim/blob/b336d91c8395f92126e78e5207f8994a9a55bf62/src/itmobotics_sim/pybullet_env/pybullet_robot.py#L292
Usage URDF_USE_SELF_COLLISION can create some BUGs, like mini jumping off model or incorrect model control.
Please add an option to disable URDF_USE_SELF_COLLISION

And here, useFixedBase needs to add an option too

Resolved in PR #17


text:
Reproduce problem regarding the edge of the picture and generated mesh

Thanks for sharing the great work!
When I was tried to reproduce your work, I found there is some blurring in the edge of the prediction image like following:

This image is generated by using the checkpoint you provided in the github.
And when I  used the checkpoint trained with the DTU dataset by the bash script script/train_dtu.sh I still got the blurring images predicitons.

And I observed some inconsistency in the mesh (inconsistency betwent the checkpoint you provided in the github and the checkpoint after trained locally).

The left mesh is generated by the checkpoint you provided in the github, and the right one is generated by the model I trained locally.
Right now, I am confused with if there is some problems with my environment?
Or there will be some difference when running the code for several times?

Hi, we also have such blur at edges. This is because the input images are too sparse. In our case, the training is quite stable and converges fast. there is no explicit difference between multiple trainings.

Hi, we also have such blur at edges. This is because the input images are too sparse. In our case, the training is quite stable and converges fast. there is no explicit difference between multiple trainings.

Thanks for the information.
Then, I will check the training part of my code.

authors: FangjinhuaWang RenieWell

repo: IVRL/VolRecon


text:
ConfigurationDbContext missing ApiScopes

Hi,
I'm about to implement a WebAPI for managing IdentityServer4.
I just failed to manage the ApiScopes because they have no DbSet in the ConfigurationDbContext. Should i create a pull request or do you have doubts?
My first attempt to manage IdentityServer was to use the stores (which would be much cleaner imo), but the IClientStore is missing a "FindAll" method. Then I started using the context.
While writing this I found out that if I start contributing to this project, I could also add this missing method to the ClientStore...
What do you think?
Kind regards,
Raphael

I just failed to manage the ApiScopes because they have no DbSet in the ConfigurationDbContext.

What does this mean? Also, ApiScope is a collection on ApiResource, which is available on the ConfigurationDbContext.

My first attempt to manage IdentityServer was to use the stores (which would be much cleaner imo), but the IClientStore is missing a "FindAll" method.

The IdentityServer store APIs are not meant to manage the data. They simply model what access IdentityServer needs to the data.

authors: brockallen muena


text:
CorsPolicyService not being called

I'm trying to use a custom policyservice, but it is never being called:
Our experience is similar to what is described in a previous issue: https://github.com/IdentityServer/IdentityServer4/issues/3075
The implementation of ICorsPolicyService is simple:
public class VerjiCorsPolicyService : ICorsPolicyService
    {
        private readonly string[] _corsOrigins;

        public VerjiCorsPolicyService(string[] corsOrigins)
        {
            _corsOrigins = corsOrigins.Select(o => o.Replace("http://", "").Replace("*.", "")).Distinct().ToArray();
        }

        public async Task<bool> IsOriginAllowedAsync(string origin)
        {
            if (_corsOrigins.Any(o => o.EndsWith(origin)))
            {
                return true;
            }

            return false;

        }
    }

I've made sure to register the service before IdentityServer:
            var verjiCorsService= new VerjiCorsPolicyService(corsOrigins);
            services.AddSingleton<ICorsPolicyService>(verjiCorsService);

The log says:
31 Oct 2019 10:42:48.295
 CorsPolicyService did not allow origin: https://admros.staging.wc.verji.io
31 Oct 2019 10:42:48.295
 Origin https://admros.staging.wc.verji.io is allowed: false
31 Oct 2019 10:42:48.292
 CORS request made for path: /.well-known/openid-configuration from origin: https://admros.staging.wc.verji.io

But IsOriginAllowedAsyncis never called.
Is there some other way we should register the custom policy service to make it take effect?

Register it after - I don't recall if we use TryAdd or not for our default.

Thanks for your reply,
I was able to make it work by registering the service after IdentityServer as you suggested.
But only after removing the standard Asp.Net Core CORS configuration (AddCors+AddPolicy/UseCors).
So something is not right with either IdentityServer or the docs (or both). According to the docs in the section Mixing IdentityServer’s CORS policy with ASP.NET Core’s CORS policies, it should be possible to have both standard AspNet Core CORS alongside a custom ICorsPolicyService if you register the custom service prior to IdentityServer. We could not make that work.
Since I am only hosting IdentityServer in this service I don't really need to mix the two, so I will continue using our custom implementation of ICorsPolicyService.
(Strangely, using only the standard AspNet Core CORS setup seemed to work (I could log in), but I kept getting those messages in the logs that CORS failed.)
Now with the custom cors service, the log messages are normal.
Thanks,
Thor A. Johansen
Rosberg AS

authors: brockallen thoraj


text:
Intrspection - Secret validation is failing

version:IdentityServer4 2.4  IdentityModel 3.10.7 IdentityServer4.AccessTokenValidation 2.7.0
error:IsActive = 'response.IsActive' threw an exception of type 'System.InvalidOperationException'
(https://user-images.githubusercontent.com/13866292/68379571-156f8980-0189-11ea-8069-838098866150.png)
(https://user-images.githubusercontent.com/13866292/68379396-bad62d80-0188-11ea-9240-43054c5e0f67.png)

Not enough information.
Read the docs about introspection/reference tokens first.

Not enough information.
Read the docs about introspection/reference tokens first.
I don't know what went wrong?
(https://user-images.githubusercontent.com/13866292/68455313-072b7700-0236-11ea-8dae-915b78d98364.png)

Any update on the issue? closing for now - feel free to re-open if it needs further discussion.

authors: cqxiaoxie leastprivilege


text:
SignInAsync no longer sets time

The resolution to #2650 removed a number of extension methods for SignInAsync, many of which set AuthenticationTime with:
var clock = context.GetClock();
[...]
AuthenticationTime = clock.UtcNow.UtcDateTime

The suggested replacement quickstart code doesn't set the time:
var isuser = new IdentityServerUser(user.SubjectId)
{
    DisplayName = user.Username
};

await HttpContext.SignInAsync(isuser, props);

Might this not be an issue worth fixing?

IIRC if the time is missing it is filled in by the authentication service - and that becomes the auth_time claim.
Is there a problem?


text:
Training Data

Hi Ido,
Could you please share the training data for ERGO-II? Also, is the training data for the previous ERGO model is same as ERGO-II?
Thank you,

Hi, ERGO-II training data is the same as ERGO training data (however we utilized more features).
There are two main databases:
McPAS - http://friedmanlab.weizmann.ac.il/McPAS-TCR/
VDJdb - https://vdjdb.cdr3.net/search
See the paper for more details.
Ido

Hi, thanks for the reply. Could you please share the negative dataset? I am trying to generate the negative set as described in the paper but unable to do so.

The pickle files in the samples directory include also the negative examples.
https://github.com/IdoSpringer/ERGO-II/tree/master/Samples

Thank you so much. It solved the issue. Also, could you please tell if metrics such as aur-PR, MCC were used to evaluate the model performance?

No, we evaluated the model performance on several tasks using (only) ROC AUC as detailed in the manuscript.

Thank you.

Hi @IdoSpringer , could you please tell if using only AUC ROC as a metric on a 1:5 imbalanced dataset is misleading? ideally for imbalanced datasets, AUC-PR and MCC are better metrics.

We do not believe that ROC AUC is misleading, but this is the only metric that we used. You may check other metrics.

Sure, Thank you so much for your reply.

Hi @IdoSpringer , could you tell what steps I must follow to replicate the results in the  ERGO-II paper? Thanks

authors: IdoSpringer xinformatics

repo: IdoSpringer/ERGO-II


text:
WS::Instance& WS::Instance::singleton(): Assertion `isConstructed()' failed.

intro-dependencies.txt
install-log.txt
meson-log.txt
gst-launch-1.0: ../src/ws.cpp:316: static WS::Instance& WS::Instance::singleton(): Assertion `isConstructed()' failed.
Ubuntu 20.04.2 LTS, 64 Bit x86
Any ideas where to even start?

Maybe start with a backtrace of the crash.

authors: aris-t philn

repo: Igalia/WPEBackend-fdo


text:
🛑 MTA7 is down

In e0dc092, MTA7 ($MTA7) was down:

HTTP code: 0
Response time: 0 ms

Resolved: MTA7 is back up in 624ea85 after 12 minutes.

repo: Ilger-Supporto/Uptime


text:
scons installs when it shouldn't

Maybe this is a known issue? When I do scons without any install or build arg, it compiles everything as expected, but it also installs all the python bindings (e.g _Gaffer.so), which I wouldn't expect.

Not sure if this is just with the IE config or not...

repo: ImageEngine/gaffer


text:
add jpeg quality options

The default Pillow jpeg settings default to quality 75 and don't use the optimize setting. This PR adds the defaults
        self.jpgQuality = 90
        self.jpgOptimize = True
        self.jpgSubsampling = 2

which results in the following improvements:
Original:

With higher quality settings:

Obviously this does increase file sizes; so I've added this as configuration that can be overridden if the user wishes.

Thank-you for your contribution!
Question: why those values specifically?  Why not leave the library at the default values, and let the end user choose whether they wish to change from the library's default?
Also, please update the README.md to add these items to the "Configuration file parameters" section.
If you'd like, you could also add a Contributors section to the README.md file as well if you wish your contribution to be noted in some way.

Thank-you for your contribution!

of course!

Question: why those values specifically? Why not leave the library at the default values, and let the end user choose whether they wish to change from the library's default?

Because the defaults for jpeg are ugly.

Also, please update the README.md to add these items to the "Configuration file parameters" section.

Ah, good call.

If you'd like, you could also add a Contributors section to the README.md file as well if you wish your contribution to be noted in some way.

Will do!

Question: why those values specifically? Why not leave the library at the default values, and let the end user choose whether they wish to change from the library's default?

Because the defaults for jpeg are ugly.

While that may be true, but as you noted, that results in a bigger file.  I'm presuming that someone is choosing to use jpg because they don't want the fidelity (and resultant file size) of png.  So I'm preferring to use the library's default values, but have your code to have the ability to change those settings so that you can choose to make your files bigger, but better quality.

Superceded by PR #21

authors: Imagix matjam


text:
Update URL in package info and fix typos

It seems to have been changed at some point. It'll redirect anyway, but it seems worth doing.

I've also been fixing typos as I go through the documentation

The vastly incomplete documentation :P

authors: alexdewar dalonsoa

repo: ImperialCollegeLondon/guikit


text:
Support for ICD9-CM Codes?

Is it possible to support ICD9-CM codes?
I was just trying to use these codes from ICD9-CM and the mapping didn't produce any kind of mapping:

ID
ICD9CM CODE
DESCRIPTION
CLASS
KIND

44826258
V76.2
Screening for malignant neoplasms of cervix
Measurement
Non-Standard

44828600
V72.31
Routine gynecological examination
Procedure
Non-Standard

44822669
V15.89
Other specified personal history presenting hazards to health
Observation
Non-Standard

Hello @TheCedarPrince,
Thanks for pointing this out!
The codes you specified are actually already supported by the package, but it is required (for all codes) that you remove all punctuation before trying to convert them (we try to stick to the CDC data source as much as possible).
So in order to convert your codes, you should do:
using ICD_GEMs

I_9_sources = ["V762", "V7231", "V1589"]

I10_sources_converted_codes = execute_applied_mapping(GEM_I9_I10_dictionary, I_9_sources)

And this produces:
6-element Vector{String}:
 "Z124"
 "Z01411"
 "Z01419"
 "Z779"
 "Z9284"
 "Z9289"

Note that the output has no punctuation too.
We will update the README and the docs to better clarify it.

Ah thanks!
I didn't realize that was the case - my apologies.
Great that this "just works"!
I'll close the issue!


text:
Inchoo_PHP7_Helper_Data class not found

When the compilation is on for Mag 1.9, I have getting the fatal error Inchoo_PHP7_Helper_Data class not found and when I didable the compilation from admin System -> tools, it is not showing any error. Can anyone sort this error?

I'm getting the same error.
I have however removed Inchoo PHP7, there is no reference to any of it in our files.
I have cleared all caches, restarted php and varnish.

authors: ajayshukla craigcarnell

license: mit


text:
Add support for (inlined) destructors

There isn't a way I'm aware of to convince MSVC or Clang to export an line destructor without modifying its definition.
Destructors were disabled from module definition generation entirely (even non-inline ones) in the prototype and it's unclear exactly why that is.
Worth noting: Virtual destructors are always available in the output.

Found out why destructors were disabled. clang_Cursor_getMangling returns the wrong mangling for destructors on Windows. You have to use clang_Cursor_getCXXManglings instead. In theory constructors have the same problem, but Microsoft's mangling doesn't differ between different types of constructors.

Details from my notes:

This originally came up because Clang is returning the wrong mangling for the ImFont destructor. Clang returns ??_DImFont@@QEAAXXZ, but the exported symbol is ??1ImFont@@QEAA@XZ.
Looking at mangleCXXDtorType, the difference between the two is that ?_D is for a vbase destructor and ?1 is for a normal destructor.
We use clang_Cursor_getMangling to get the mangling. This function is effectively implemented by ASTNameGenerator::Implementation::writeName, which for function declarations is implemented by writeFuncOrVarName which for a destructor always uses the Dtor_Complete destructor type, which will be the ?_D mangling.
Looking at libclang, there's a separate clang_Cursor_getCXXManglings which returns multiple strings. This function effectively calls ASTNameGenerator::Implementation::getAllManglings. With a Microsoft ABI this will only return a single value for destructors, Dtor_Base (which is the ?1 version we expected.)

Between 756b9697bf9bad49c8eb0d5ffa180e2a676cdc52 and 23c4edd67e41fa762ffcf033b91899c1c8c4977e, I am calling this done.
Better support for deletion is tracked by https://github.com/InfectedLibraries/Biohazrd/issues/159
Improving friendliness of constructing/destructing C++ objects is tracked by https://github.com/InfectedLibraries/Biohazrd/issues/161

repo: InfectedLibraries/Biohazrd


text:
🛑 Home Assistant Arco is down

In bc82c5a, Home Assistant Arco (https://peque.duckdns.org/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Home Assistant Arco is back up in 60ca123 after 39 minutes.

repo: Infinitte/upptime


text:
Infinite loop for IOS user with native Facebook app and not logged on Safari

Many users have this problem: they remain stuck in an infinite loop between webview and the request to log in with their Facebook app.
This happened usually if they are not logged in on Safari.
My guess is that this refers to the 5th paragraph of the IOS implementation instruction
https://developers.facebook.com/docs/facebook-login/ios?locale=en_US

This code initializes the SDK when your app launches, and allows the SDK to handle logins and sharing from the native Facebook app when you perform a Login or Share action. Otherwise, the user must be logged into Facebook to use the in-app browser to log in.

Especially I think it could be the part linked to the SceneDelegate not present maybe?
Thanks

Hey. Do you have SceneDelegate in your app?

Hi! Thank you for the answer, no in my app I don't have a SceneDelegate. Sorry if my guess doesn't make sense. What do you think could be the problem?

I found the solution. The problem was the implementation of the package
flutter-braintree
that has this issue
https://github.com/pikaju/flutter-braintree/issues/122
Thanks for the attention,the bug can be closed

authors: greymag nicolobozzato


text:
Mob Imprisonment Tool Crash

Industrial Foregoing Version: 1.12.2-1.12.11-235
TeslaCoreLib Version: 1.12.2-1.0.15
Crash happens when right-clicking a cow with the tool, upon reopening world tool is still empty and cow is still there
Crashlog (If Any):
crash-2020-11-25_17.20.11-client.txt

:wave: Sorry but Industrial Foregoing has ended support for version 1.12. I'm closing this issue as it will no longer be updated for that version. Thanks for playing with the mod.

:wave: Sorry but Industrial Foregoing has ended support for version 1.12. I'm closing this issue as it will no longer be updated for that version. Thanks for playing with the mod.


text:
Crear carpeta backend

Se creo la carpeta backend que contiene los siguientes archivos:

recetas.db : base de datos donde se encuentran todas las recetas con sus respectivos ingredientes y categorías.
recetas.py : programa para administrar mejor la base de datos (recetas.db), creando el esquema de la base de datos, y en donde  se seguirán agregando más funciones que sean necesarias.
models.py : programa donde se encuentra el controlador de la base de datos (SQLAlchemy) que se va a usar.
app.py : programa para correr el servidor web con Flask y donde en un futuro se agregaran los endpoints necesarios.

Viene muy bien! Bien estructurado el bsckend

authors: hernancontigiani tatianacarcamoreula

repo: InoveProyectos/almacen


text:
Add missing tournament format

Type of Issue

[ ] Bug
[X] Feature Request
[ ] Documentation
[ ] Other

Description
We need to organize a meeting with the tournament team and gets every tournament format they need.

As for today's meeting with the tournaments team, it is not a priority. The following formats are already covered and are sufficient:

Pool
Round Swiss
Tree


text:
next() returns null on fixed date

I'm using this library with kotlinx-datetime. I would like to schedule a task once at a specified time, but when I execute the code that task runs immediately
import dev.inmo.krontab.KronScheduler
import dev.inmo.krontab.builder.buildSchedule
import dev.inmo.krontab.doOnce
import dev.inmo.krontab.nextOrNow
import kotlinx.datetime.Clock
import kotlinx.datetime.LocalDateTime
import kotlinx.datetime.TimeZone
import kotlinx.datetime.toLocalDateTime
import kotlin.time.Duration.Companion.seconds

suspend fun main() {
  ((Clock.System.now().also {
    println("now:\t\t\t${it.toString().replace("T", "\t\t ")}")
  }) + 6.seconds).toLocalDateTime(TimeZone.UTC)
    .also { println("should run at:\t${it.toString().replace("T", "\t\t ")}") }
    .toCron()
    .also {
      println("next:\t\t\t${it.next()?.toStringDefault()}")
      println("nextOrNow:\t\t${it.nextOrNow().toStringDefault()}")
    }
    .doOnce {
      println("Hello at\t\t${it.toStringDefault()}")
    }
}

fun LocalDateTime.toCron(): KronScheduler = buildSchedule {
  seconds { at(second) }
  minutes { at(minute) }
  hours { at(hour) }
  dayOfMonth { at(dayOfMonth) }
  months { at(monthNumber) }
  years { at(year) }
}

output:
now:			2022-05-29	 10:33:18.742564200Z
should run at:		2022-05-29	 10:33:24.742564200
next:			null
nextOrNow:		Sun, 29 May 2022 10:33:19 UTC
Hello at		Sun, 29 May 2022 10:33:19 UTC

If I comment out years { at(year) } or dayOfMonth { at(dayOfMonth) } I think there's a infinite loop
If I comment out months { at(monthNumber) } code works fine at scheduled time
Where is the problem?

Hello :) If I correctly understand, you are trying to setup fixed date with all possible fields. In that case will exist only one non nullable next result - that date. Besides, you will be able to get that result only when you will pass as a now in scheduler the date before. You are using doOnce which, as I remember, getting DateTime.now() and this one will always be greater that the one you have used to setup kron scheduler. As a result, you are getting null :)

you will be able to get that result only when you will pass as a now in scheduler the date before

I'm not sure to understand you mean for this sentence. How can I pass a now value?

getting DateTime.now() and this one will always be greater that the one you have used to setup kron scheduler. As a result, you are getting null :)

DateTime.now() should be always lower than the date I setup in kron block (eg: now < tomorrow)

Could you provide a working example by editing code above or this is not feasible with this library?

I got your point, will take a look closer a little bit later

Will be fixed with release of 0.7.3. Sorry for the delay :(

Firstly, thanks
Tried build 0.7.3-branch_0.7.3-build118 and I had to minus 1 both day of month and month number
So now January = 0 and first day of month = 0?

Firstly, thanks
Tried build 0.7.3-branch_0.7.3-build118 and I had to minus 1 both day of month and month number So now January = 0 and first day of month = 0?

Yes :) by design it should be like this, but thank you for your report, I have fixed the issue

authors: DVDAndroid InsanusMokrassar

repo: InsanusMokrassar/krontab


text:
Failed to build itk-wasm because ITK does not export ITKModuleExternal.cmake

Description
I tried to build itk-wasm after having built ITK. It fails at the cmake .. step since it cannot fine ITKModuleExternal.cmake. The issue has been reported here:
https://github.com/InsightSoftwareConsortium/itk-wasm/issues/933
Steps to Reproduce
Build ITK on Ubuntu 22 with cmake .. && make && sudo make install and then build itk-wasm with cmake ... Here are the revisions:
ITK: aaa43159aa5510fd514c71823b6b9c86b1f01212`` itk-wasm: b1289e36d0b2483c8687d9325fb16ed604be4b15`
Expected behavior
The itk-wasm build would pass the cmake ..step.
Actual behavior
It fails to fine ITKModuleExternal.cmake. Log is here:
https://github.com/InsightSoftwareConsortium/itk-wasm/issues/933
Reproducibility
Deterministic.
Versions
Revision SHAs have been given above.
Environment
Ubuntu 22 on an amd64.

I tried building the v5.3.0 tag, with cmake -DITK_WRAP_PYTHON=ON. Same problem. ITKModuleExternal.cmake does not get installed after sudo make install.

https://github.com/InsightSoftwareConsortium/itk-wasm/issues/933 is the right place for this issue. I built ITK yesterday on Ubuntu 22.04 with GCC 11.4 without any issues.

I also ITK fine. Just not itk-wasm.
From what I understand implicitly in your answer, the file ITKModuleExternal.cmake is not supposed to be published from ITK and made available to itk-wasm via the standard location for cmake files.
I find that clumsy. Or, more likely, I fail to understand the underlying issue that prevents from getting ITKModuleExternal.cmake published.

authors: dzenanz gl-yziquel

repo: InsightSoftwareConsortium/ITK


text:
Calling python itk.meshread on the linked file causes itk to segfault.

Description
Calling python itk.meshread on the linked file causes itk to segfault.
Steps to Reproduce
Download
https://github.com/uncbiag/OAI_analysis_2/blob/oh-no/meshR.vtk
import itk
itk.imread("meshR.vtk")

Actual behavior
>>> itk.meshread("Downloads/meshR.vtk")
zsh: segmentation fault  python
(base) hastings@hastingss-air ~ % /Users/hastings/opt/anaconda3/lib/python3.8/multiprocessing/resource_tracker.py:216:     UserWarning: resource_tracker: There appear to be 1 leaked semaphore objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '

Reproducibility
I have reproduced on mac and linux 100%
Versions
I have seen this on itk 5.3.0
Environment
Mac and linux, with the default pip install itk
Additional Information

Quick and easy reproduction: https://colab.research.google.com/drive/1n1t0525CigneZ--2QTxSsiPsKXQ6LKaP?usp=sharing
(There is no output when it segfaults, the notebook just restarts with an error message)

The reader is choking on the presence of OFFSETS, which is because VTK changed the format:
https://github.com/Kitware/VTK/commit/7f76b9e97b1a05cfe4fcd5f9af58f0d7a385b639
which is currently undocumented:
https://gitlab.kitware.com/vtk/vtk/-/issues/17989

Also: https://discourse.vtk.org/t/legacy-polydata-file-compatibility/5354/11

authors: HastingsGreer thewtex


text:
STYLE: Update Python Examples to conform to PEP 8

I've updated the Python Examples to conform to the PEP 8
Python Style Guide for code.  I used the pycodestyle package
and pycharm's reformat tool.  Any pycodestyle warnings that
pycharn did not resolve were fixed by hand.

PR Checklist

[x] No API changes were made (or the changes have been approved)
[x] No major design changes were made (or the changes have been approved)
[ ] Added test (or behavior not changed)
[ ] Updated API documentation (or API not changed)
[ ] Added license to new files (if any)
[ ] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
[ ] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

Did you close the PR on purpose or accidentally?


text:
DOC: Use Doxygen syntax to create automatic links to members

Use Doxygen syntax to create automatic links to members.
According to the relevant Doxygen documentation:
https://doxygen.nl/manual/autolink.html
PR Checklist

[X] No API changes were made (or the changes have been approved)
[X] No major design changes were made (or the changes have been approved)
[X] Updated API documentation (or API not changed)

Similar to #3650, can be merged after that one and prior to #3648 and #3649, as this one is less extensive and hopefully less problematic than the latter two.

/azp ITK.macOS

\azp ITK.macOS

/azp ITK.macOS

/azp run ITK.macOS

Jon, merge when appropriate.

These are now linked, exactly as expected from the Doxygen documentation ! Hurray ! We now have a working example for cross-class member documentation linking in ITK :tada: :fireworks:.

authors: dzenanz jhlegarreta


text:
Switch to a more modular way of representing Blocks

So I have kind of a design problem right now, that is blocking progress on many fronts: Riverbed's current way of representing a Block doesn't scale. Not in terms of performances - performances are great - but in terms of code.
At the moment Blocks are represented with a flat Rust enum and I don't think it's the correct choice for representing blocks anymore.
I want Ores to enter a "depleted state" once harvested, and regenerate after a certain amount of time passed. I want wood Logs and Planks to have variations for the wood type. I also want blocks with color variations, etc.
If I were to code this using a flat Enum like I'm currently doing, we would have:
enum Block {
    IronOre,
    IronOreDepleted,
    GoldOre,
    GoldOreDepleted,
    CopperOre,
    CopperOreDepleted,
    ...
}

Anywhere I need to write ore depletion logic, I would need to map all the ore variants individually and duplicate my code, and the same goes for wood variants, etc.
I currently see 2 ways of making the situation better:
1. keep the enum but make it not flat
this would look like:
enum Ore {
    Iron,
    Gold,
    Copper,
    ...
}

enum Block {
    Ore { kind: Ore, depleted: bool }
    ...
}

It seems like the most natural extension of the current system, it's more limited than solution .2 but it would alleviate my issue.
2. switch to a composition pattern
I don't know how this would look like, but basically you could have a block made of components such as "ore::iron" and  "depleted", then you could just operate on the components similar to what ECS does. This seems interesting but challenging to implement.
challenges
in both case there are a few challenges to address:

block size in the palette would get bigger, we might need a block ↔ id conversion
deserialization (for craft recipes, texture filenames) would be harder, the system needs to be expanded somehow

To guide the reflection, here's a common operation I will want to do:

Get an archetype from an ID, modify the archetype (ex: add a "depleted" property on an ore), get the ID corresponding to the modified archetype

There is also the problem of representing this with data (craft recipes, texture file names, etc.) that we need to think about...

Another specific issue I'm seeing is that it's hard to specify a generic craft recipe like "Wood → 4 Planks" implying that if you use Acacia Wood you will get 4 Acacia Planks for example.

Something that could work in the "components" direction would be this:
enum Ore {
    Copper,
    Iron,
    Gold,
    Diamond,
}

enum Stone {
    Basalt,
    Granite,
    Limestone,
}

enum Wood {
    Acacia,
    Birch,
    Oak,
    Spruce
}

enum Soil {
    Dirt,
    Sand,
    Mud,
}

enum BlockComponent {
    Air,
    Soil(Soil),
    Ore(Ore),
    Stone(Stone),
    Wood(Wood),
    Log,
    Plank,
    Depleted,
}

And a block would just be a list of BlockComponents ... This would be easy to manipulate but also overly permissive (the system would allow a Sand Log and many blocks that don't make sense)

I managed to implement Serialization with the component system by ordering the components according to their order in the enum definition; this way I can put "Depleted" in front of "Ore(Ore)" for example and a block with "Depleted, Ore(Ore::IronOre)" components would serialize into DepletedIronOre. Sadly, this conflicts with Deserialization because #[untagged] variant of an enum needs to be placed last :(

And It's done :)
With the help of @kokounet we set up a build script that generates the Block enum for us !
The definition of blocks is stored in assets/data/blocks.def, here's an example illustrating the block definition syntax:
set Wood {
    Birch,
    Oak,
    Sequoia,
}

block {Wood}Log
block {Wood}Planks

blocks.def is then parsed into an Intermediate Representation which then gets translated into Rust code by crates/riverbed_block_def, the first internal crate of Riverbed !
This example above would produce the following code:
pub enum BlockFamily {
    Wood
}

pub enum Wood {
    Birch,
    Oak,
    Sequoia
}

enum Block {
    BirchLog,
    BirchPlanks,
    OakLog,
    OakPlanks,
    SequoiaLog,
    SequoiaPlanks,
}

impl Block {
    pub fn families(&self) -> Vec<BlockFamily> {
        match self {
            Block::BirchLog => vec![BlockFamily::Wood],
            Block::BirchPlanks => vec![BlockFamily::Wood],
            // etc.
        }
    }
}

This allows us to define blocks and block families in a very concise way, making it really easy to add whole families of blocks (ex:  a new type of wood) at once, while keeping a flat enum structure, which we struggled to do initially.
It can easily be extended to support components if needed (we could impl a "components" function that returns the components making up each block)

repo: Inspirateur/riverbed


text:
ListBindingSectionController did not use the current cell

New issue checklist

[ X] I have reviewed the README and documentation
[ X] I have searched existing issues and this is not a duplicate

General information
IGLIstKit 3.4 iOS 13 Xcode 5 Swift
Debug information
I did some testing for ListBindSectionController, I am a little bit surprised that when we call update if anything we need to update, iglistkit did not try to grab the same visible cell which the section controller binds to. Instead, it try to reuse other cells. Would it be better to get visible cell and directly call bindViewModel  on the same cell?
The only downside I can see is that if cell height needs to change, it wont be able to deal with it

Would it be better to get visible cell and directly call bindViewModel on the same cell?

Sounds like a bad idea here, since the whole point of ListBindSectionController is to avoid reusing other cells for updates. Could u share me some sample code so I can help further? How many items do you have for you BindSection?

repo: Instagram/IGListKit


text:
QGIS not installing

All seems to work fine, except at the end we see that installomator does not install QGIS:
ERROR : qgis-pr : ERROR: Error verifying /Volumes/QGIS.app/QGIS.app error:
/Volumes/QGIS.app/QGIS.app: rejected (invalid destination for symbolic link in bundle)

when you download the app manually and run spctl -a -vvv /Volumes/QGIS.app/QGIS.app do you get the same error?

so the good news is: it is not an Installomator problem.
The Gatekeeper verification of the app is failing and Installomator is rejecting it because of that. You will have to get in touch with the vendor to fix their signing and notarization.

authors: peterlbk scriptingosx

repo: Installomator/Installomator


text:
Estimate time required to convert simulation utils

simulation/helpers_add_interventions
simulation/helpers_sim_setup

Define estimate to convert the following files to emodpy. I output should include a list of issues broken into easy to manage components.

I'm done with the first pass (took about a week, but with other work). I need some help from Sharon/Zhaowei and have some questions for the researchers and I think it can be wrapped up in a couple of more days and be ready for testing. Helpers_sim_setup has the most unfinished stuff while helpers_add_interventions is finished, but has comments/questions

there was also a add_vaccdrug_campaigns.py that needed to be converted as it's being used you helpers_add_interventions, it also has some comments/questions.

PR: https://github.com/InstituteforDiseaseModeling/emodpy-snt/pull/21

authors: devclinton stitova-idm

repo: InstituteforDiseaseModeling/emodpy-snt


text:
RGB32->RGB32 composition with tile has incorrect result

with 2019 R4 release on Ubuntu 18.04 sample_multi_transcode, if we use RGB32->RGB32 for composition with tiles, there will be some garbge between the input videos.  if we use NV12->RGB32 for composition even also with tiles, no issues.

will attach the par file later.

Could it be Surface pitch alignment?

@joojler , where is the par file? If you have rooted cause this issue as we discussed offline, could I close this issue? Thanks a lot in advance!

Hi Furong, this is the par file i used.
-i::h264 /home/work/video/3.h264 -join -hw -dec_postproc -async 4 -o::sink -vpp_comp_dst_x 200 -vpp_comp_dst_y 100 -vpp_comp_dst_w 560 -vpp_comp_dst_h 340 -ext_allocator -vpp_comp_tile_id 0
-i::h264 /home/work/video/3.h264 -join -hw -dec_postproc -async 4 -o::sink -vpp_comp_dst_x 1160 -vpp_comp_dst_y 100 -vpp_comp_dst_w 560 -vpp_comp_dst_h 340 -ext_allocator -vpp_comp_tile_id 0
-i::h264 /home/work/video/4.h264 -join -hw -dec_postproc -async 4 -o::sink -vpp_comp_dst_x 200 -vpp_comp_dst_y 640 -vpp_comp_dst_w 560 -vpp_comp_dst_h 340 -ext_allocator -vpp_comp_tile_id 1
-i::h264 /home/work/video/4.h264 -join -hw -dec_postproc -async 4 -o::sink -vpp_comp_dst_x 1160 -vpp_comp_dst_y 640 -vpp_comp_dst_w 560 -vpp_comp_dst_h 340 -ext_allocator -vpp_comp_tile_id 1
-vpp_comp_num_tiles 2 -vpp_comp_only 4 -w 1920 -h 1080 -async 4 -threads 2 -join -hw  -i::source -ext_allocator -ec::rgb4 -rdrm-HDMIA

Assigned this issue to Jason.

Hi joojler,
I am focused on this issue mainly, so could you give me 3.h264 and 4.h264 files?

hi all,
the root  cause is output_background_color unset, and I submit the patch at: https://git-ccr-1.devtools.intel.com/gerrit/#/c/182217/
After syncing with James, the issue is fixed, but maybe need more test cases to verify. thanks.

Rooted caused by @yuqinw .

https://github.com/Intel-Media-SDK/MediaSDK/commit/18781d3be243748b9b80f5055401c1fa402353f6 fixed this issue and merged.

Hence close this issue. Please feel free to let us know if any further questions.

authors: FurongZhang joojler yuqinw

repo: Intel-Media-SDK/MediaSDK


text:
Large PSNR quality regression in AVC transcoding results

Between following commits...
good:

2020-08-03 03-01-27 d4f52ee695e62ac2c2aa7747780a2bc8c81c7fba:  clarify the huc enabling in readme (media-driver)
2020-08-03 16-23-24 0b6996f73f525713284b48669a972f1d6fb1b3e0: [ted] Add README and use only installed binaries (media-sdk)

bad:

2020-08-04 05-39-58 e5c783546000ad0c50d0892d773cadffe60832bb: correct the reference capibility for gen11 and gen12 (media-driver)
2020-08-04 14-42-44 399b893f45e8a2f4470f2e29051c057fa52db767: [smt] Update for possible memory leak fix in raw input case (media-sdk)

PSNR values for AVC transcoding results dropped significantly, and there was a small drop also in SSIM values.
Because there's no drop for same transcoding tests with FFmpeg VA-API, regression is most likely due to MSDK change, not media-driver one.  In the same 1-day time interval, PSNR increased a bit for 10-bit 4K HEVC, so it's not all bad.
Transcoding tests on which I track quality, and their PSNR changes are following:

+3% PSNR / +0.9% SSIM (HEVC):
sample_multi_transcode -i::h265 Netflix_FoodMarket_4096x2160_10bit_420_100mbs_600.h265 -o::h265 4K20.h265 -b 20000 -u 4 -n 300 -async 4 -hw
0% PSNR / SSIM (AVC):
sample_multi_transcode -i::h264 720x480p_30.00_4mb_h264_cabac_180s.264 -o::h264 SD03.h264 -b 2000 -u 4 -n 4800 -async 4 -hw
-12% PSNR / -0.9% SSIM (AVC):
sample_multi_transcode -i::h264 1280x720p_29.97_10mb_h264_cabac.264 -o::h264 HD20.h264 -b 2000 -u 4 -n 2400 -async 4 -hw
-22% PSNR / -2.8% SSIM (AVC):
sample_multi_transcode -i::mpeg2 1920x1080i_29.97_20mb_mpeg2_high.mpv -o::h264 HD17i7.h264 -b 6000 -u 7 -n 2400 -async 4 -hw

It seems that the PSNR drop increases with AVC transcoding resolution.  There was no change in AVC transcoding performance, so this is a just quality regression.
Quality metrics are calculated using FFmpeg:

PSNR: ffmpeg -i <input> -i <output> -an -vframes <transcoded_frames-1> -filter_complex psnr -f null -
SSIM:  ffmpeg -i <input> -i <output> -an -vframes <transcoded_frames-1> -filter_complex ssim -f null -

(FFmpeg is used for this because it supports compressed inputs and and because, it's much faster than the "metrics_calc_lite" from Intel-Media-SDK/tools repo. Audio is disabled, as that triggers some time-wise FFmpeg frame alignment issue, and last frame is ignored to avoid other quality error calculation artifact.)
I have results only for GEN9 devices, but the drop is visible on all of them (BXT, GLK, SKL GT2 & GT4e, KBL, CML).

Hi @eero-t,
I tried to reproduce this issue on different MediaSDK commits but on the same media-driver commit. I took 3 commits: (8378db0e67cd47893b9dd46ba716835a1530b055, 00185631f74eb9b9817bad88b68e66b70053a56e and 0b6996f73f525713284b48669a972f1d6fb1b3e0) and several streams with different resolution.
I used parameters that you used in command line: -b 2000 -u 4 -n 2400 -async 4 -hw and -b 6000 -u 7 -n 2400 -async 4 -hw
And after transcoding I measured PSNR using the same command line for ffmpeg. All the time on different parameters PSNR was always the same for all 3 commits.
Can you please compare PSNR and SSIM on different media-driver commits (bad and good) but on the same MediaSDK commit? If issue is not reproducible in this case can you please share your stream?

After some testing, the regression turns out to be some change in the MediaSDK "sample_multi_transcode" program, not in the libraries it uses.
Note: the differences I reported are for the PSNR "average" value (when comparing the other values for the "HD17i7" case, especially PSNR 'y' & 'min' values have dropped hugely, while 'max' is still about same and 'u' & 'v' are fairly close).

Hi @eero-t ,
Seems we can't reproduce the issue locally. But you're saying the regression is obvious. Can you please attach resulted encoded files for a good and buggy case?

I've sent link to the files privately, but I think the change in FFmpeg output actually tells what's the bug with "sample_multi_transcode":
 Input #0, mpegvideo, from 'input/1920x1080i_29.97_20mb_mpeg2_high.mpv':
   Duration: 00:01:59.91, bitrate: 20000 kb/s
     Stream #0:0: Video: mpeg2video (Main), yuv420p(tv, bottom first), 1920x1080 [SAR 1:1 DAR 16:9], 20000 kb/s, 29
.97 fps, 29.97 tbr, 1200k tbn, 59.94 tbc
@@ -44,19 +44,19 @@
       cpb: bitrate max/min/avg: 20000000/0/0 buffer size: 9781248 vbv_delay: N/A
 Input #1, h264, from 'HD17i7.h264':
   Duration: N/A, bitrate: N/A
-    Stream #1:0: Video: h264 (High), yuv420p(bottom first), 1920x1080 [SAR 1:1 DAR 16:9], 29.97 fps, 29.97 tbr, 1200k tbn, 59.94 tbc
+    Stream #1:0: Video: h264 (High), yuv420p(bottom first), 1920x1080 [SAR 1:1 DAR 16:9], 30 fps, 30 tbr, 1200k tbn, 60 tbc

=> New "sample_multi_transcode" changes the output to 30 FPS, so that it doesn't any more match input.  This explains why the smallest (30FPS) video didn't show any regression.
From my earlier quality testing using FFmpeg, it doesn't seem to do a simple frame-by-frame comparison.  I think it compares frames which timestamps have closest match (maybe even averages successive frames based on their time offsets?). With the 30.0 - 29.97 FPS skew, input video will be left one frame behind the output video every 1000 frames.

New "sample_multi_transcode" changes the output to 30 FPS, so that it doesn't any more match input

This is known issue, patch for it is on review: #2296
Can you please apply this patch and check PSNR/SSIM one more time?

It's indeed might be ffmpeg specific behavior of metrics calculation. But generally encoded files are really different  (i'm looking at HD17i7-bad.h264 and HD17i7-good.h264). Difference starts at frame #222.  Slightly different MVs, slightly different MB types. QPs, GOP's, ref lists are the same. Interesting...

authors: aobolensk dmitryermilov eero-t


text:
Modify pom.xml to add RPMem shuffle as a sub project

Add RPMem shuffle as a sub project in OAP's pom
The RPMem is added as a module.
For now, the RPMem shuffle can be packaged specifically with:
mvn package -pl com.intel.oap:oap-rpmem-shuffle -amd package -DskipTests

Does this mean we need to update the docs about how to build RPMem-shuffle?
instead of doing it under oap-shuffle/RPMem-shuffle folder, need to issue this command in oap folder?

Does this mean we need to update the docs about how to build RPMem-shuffle?
instead of doing it under oap-shuffle/RPMem-shuffle folder, need to issue this command in oap folder?

Either way is workable, for user who wants to use RPMem shuffle, she can build it at ${oap-root-folder} or ${oap-root-folder}/opa-shuffle/RPMem-shuffle, and if in the latter folder, the build command is exactly the same as before.

LGTM.

authors: Eugene-Mark Jian-Zhang

repo: Intel-bigdata/OAP