text:
Improve error message: Cannot find an overload for "" and the argument count: "".

This long-standing error message in PowerShell is accurate, but deceiving, because it doesn't indicate that the caller may have utilized the incorrect method signature. Even though I've been writing PowerShell code for 10+ years, this one still trips me up on a regular basis.
Can we improve the error message to include some more useful information that can point the developer the right direction? For example: "Cannot find a valid method overload for "" and the arguments: "String, Int, CustomDatatype".
I'm open to other ideas, just wanted to call this out.
Cheers,
Trevor Sullivan

It's possible, but I think a little tricky - a good first fix for somebody wanting a deeper understanding of how we use the DLR and dynamic call sites.

Where should that someone look in that case?

Start here:
https://github.com/PowerShell/PowerShell/blob/a2268ab3ecb6c1addffbedba0606aa6c95809dd4/src/System.Management.Automation/engine/runtime/Binding/Binders.cs#L6623
The (possibly) tricky part is generating a correct binding restriction here:
https://github.com/PowerShell/PowerShell/blob/a2268ab3ecb6c1addffbedba0606aa6c95809dd4/src/System.Management.Automation/engine/runtime/Binding/Binders.cs#L6680
I actually might be mistaken - we might already generate good binding restrictions for the error case - but it is something you have to understand before knowing your code is correct.

authors: lzybkr pcgeek86 powercode


text:
Powershell icon is blurry in PSCore 6.1.0 Preview 3

Name                           Value
----                           -----
PSVersion                      6.1.0-preview.3
PSEdition                      Core
GitCommitId                    v6.1.0-preview.3
OS                             Microsoft Windows 10.0.17692
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

A bit trivial I know but worth asking the art people to get an icon at the proper size 😁. Screenshot above is on a Surface Book.

Close as stale issue.

Close as stale issue.

source: gharchive/issue

authors: iSazonov mikemaccana

repo: PowerShell/PowerShell

license: MIT

license_type: permissive

license_source: github-api


text:
Make the new, future no-profile CLI for use in shebang lines implement other CLI fixes too

Follow-up from a conversation with @SteveL-MSFT in #7989.
PowerShell's existing CLI has a number of problems, relating to:

(a) unconditionally dot-sourcing $PROFILE, making for unpredictable execution environments - see #992
(b) parameter syntax and parsing, both in general and with respect to fitting into the Unix world - see #3743

Update: One of the problems in the linked post may get fixed int the existing CLI, via a new parameter, namely if the experimental PSCommandWithArgs feature becomes a stable one.

(c) unhelpful mapping of PowerShell's output streams to the outside world's standard streams - see #7989

The existing CLI cannot be fixed so as not to break backward compatibility, but it was agreed that (a) would be fixed by way of a new, separate executable/symlink, notably for use in shebang lines of stand-alone shell scripts on Unix-like platforms.
More broadly, however, this new CLI is an opportunity to fix (b) and (c) as well, which would go a long way toward endearing PowerShell to CLI-savvy Unix users.
Essentially, it would provide a new CLI that is a well-behaved cross-platform citizen with sane defaults.
(As such the profile-loading behavior should mimic Bash's - only load $PROFILE in interactive shells by default).
Note: The new behavior needn't be a separate binary: The behavior variation could be triggered by invocation via symlink whose name indicates the need to apply alternate behavior, at least on Unix-like platforms. (Invoking .NET Core executables via symlinks on Windows is not yet supported, but will hopefully come in .NET Core 3.0 - see https://github.com/dotnet/core-setup/issues/4080)
Given the then-broader scope, the originally proposed name pwsh-np needs revising, however.
Environment data
Written as of:
PowerShell Core 6.1.0

Whatever name we choose, we also need to consider pwsh-np-preview

I don't understand, @SteveL-MSFT: why *-preview?

@mklement0 we want to maintain a consistent separation of the stable and preview releases so I would think we'd have pwsh, pwsh-preview like we have today, along with pwsh-np and pwsh-np-preview

Ah, of course, thanks @SteveL-MSFT.
Any thoughts on a suitable new name that respects the scope and intent of the changes?
psh, perhaps? (OK, just kidding).
Naming is tricky, because the name should be kept short, so I fear it'll come down to documenting things well.
pwshc? (with the c representing a (proper) CLI).

Hey @SteveL-MSFT,  It isn't clear in this issue, could you please specify if/when/where the Streams output to the associated File Descriptors from #7989 will show up.  I'm very interested in this feature and was quite sad when I realized it didn't already exist :(.
Thanks for your contributions!

@mklement0 Thanks for collecting these issues in one meta-issue. All of the linked issue have been closed but there is room for more discussion. The WG reviewed this and decided it would be better served by moving this issue to a GitHub Discussion where the community can help us with requirements and decisions for a future solution.

authors: SteveL-MSFT mklement0 sdwheeler tbakerweb


text:
Projects out of date

Some of the GitHub projects need to be updated/closed.

/cc @SteveL-MSFT @joeyaiello

We'll do a mass cleanup and also produce a roadmap as we get closer to end of 6.2 before we start 6.3

This needs to be fixed still

authors: RDIL SteveL-MSFT iSazonov


text:
Use PowerShell to stop Syncing OneDrive folders

I am looking for a PowerShell script that stops syncing OneDrive folders.
I.e. I want to trigger the Stop Sync encircled using PS:

@ShehzadUIT The repo is for development only. For support please use forums or/and stackoverflow.com

authors: ShehzadUIT iSazonov


text:
Update CHANGELOG.md

It's what Joey shared in our Team channel. I only fixed a few spelling issues.

Note that failures are expected as I updated the release versions in docs but the corresponding packages are not released yet.

source: gharchive/pull-request


text:
Update CODEOWNERS file to reduce noise

PR Summary
Update the CODEOWNERS file to reduce noise and remove people not actively working on the project.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

@adityapatwardhan CI still ran


text:
SiteName is still required as of 2.15.0.0

Sitename is being passed as an empty string when not included instead of $Null.
Line 135 of the file MSFT_xADDomainController.psm1
Is currently:
if ($SiteName -ne $null)
and needs to be modified to:
if ($SiteName -ne $null -and $Sitename -ne “”)

fixed in
MSFT_xADDomainController.txt

Pull request submitted with fix

Fixed by #133

repo: PowerShell/xActiveDirectory

license: mit

license_source: bigquery


text:
XDnsServerAdZone: Removing or Fixing Call to New-CimSession

Currently we only have winrm configured to listen on loopback ONLY with the following below settings

Unfortunately the XDnsServerAdZone DSC resource creates a new-cimsession in the Get-TargetResource function.  This ends up resolving to the ip of the nic of the machine.  Therefore the cimsession to connect will fail since it's not connecting VIA loopback address configured above for the winrm listener. Below is the error i'm getting

Could not evaluate: Cannot validate argument on parameter 'CimSession'. The argument is null or empty. Provide an argument that is not null or empty, and then try the command again

1.) Why is New-CimSession even needed here? can it be removed?
2.) If New-CimSession cannot be removed can we allow passing in of the ip to create the cimsession for?

I can confirm the same error message even with no winrm constraints in place.

@greggoindenver Do you have any ideas as to why a new-cimsession is being used in this dsc resource?

@corydwood Maybe you could shed some light on this

New-CimSession is being used to allow creating zones on remote DNS servers and/or using specific credentials for creating the zone on either the local server or a remote server.
The code could be changed to only use New-CimSession if the ComputerName or Credential parameters are used. I can look into doing that, but may not be able to get to it for a few days.

Also, it looks like #49 broke this resource as the Set-TargetResource function relies on the CimSession property being returned by the call to Get-TargetResource.

@corydwood I might be able to get around to doing this as well.. Cannot promise anything depend on how my schedule goes.

We have the same problem with version 1.8.0.0. Version 1.7.0.0 works fine.

Has there been any further status on this issue?

+1, same repro

@corydwood, @TraGicCode : Have either of you been able to reproduce this error?  I tried it again today on a different machine.  I can create forward zones, but not reverse zones.

I had the same issue "Cannot validate argument on parameter 'CimSession'"
Workaround was to comment out the CimSession (line 240)
C:\Program Files\WindowsPowerShell\Modules\xDnsServer\1.9.0.0\DSCResources\MSFT_xDnsServerADZone\MSFT_xDnsServerADZone.psm1

Should only add the CimSession parameter if the computername attribute was set on the resource.

@johlju , I'm cc'ing you on this to hopefully get some feedback on this before i dive in and start working on a PR to fix this issue.

Is there an accepted pattern for having a surrogate node apply dsc configurations on itself that connect to some other node in which the resource should be managed? For example this module allows specifying credentials + computer name in which it will connect to and try and manage a xDnsServerAdZone resource.  Id there any example in any known DSC Resources in the wild you know of that has this feature?

If using a CIMSession is considered acceptable then should it be returned from Get-TargetResource?  Also what about the schema file as #44 is attempting to do?

Thanks.

@TraGicCode

The resource SqlAG and SqlAGReplica in SqlServerDsc does something similar to find the primary replica. If the current node is not the primary replica and a change is needed, it will connect to the primary replica of the Always On cluster, since the change can only be done on the primary replica. It connects the same way using the SMO object model, which in this case can be compared to New-CIMSession. It connects the same regardless if it is the target node or one of the other nodes in the AlwaysOn cluster.

Each  *-TargetResource should start it's own CIM session. I say this because each property returned by Get-TargetResource should have at least a read-only property in the schema.mof. I don't think returning a CIMSession object is good practice (or even possible as a read-only property).

@TraGicCode to solve this issue, using New-CimSession only when ComputerName  is assigned a value seems okay to me. It feels to me like it is a breaking change though, what do you think? Not a problem, just needs to be "tagged" accordingly. Read about breaking changes https://github.com/PowerShell/DscResources/blob/master/CONTRIBUTING.md#breaking-changes
Regarding that the target node connects to a different server. Normally I would expect this to be run on the DNS server itself, and there would be no need for a ComputerName parameter. But since there is a ComputerName parameter there is probably a scenario where it is needed. Curious, does can anyone give an example for such a scenario where one need to run this on a different server than the DNS server?

If there need to be a specific account that needs to be used to run the configuration then the built-in credential parameter PSDscRunAsCredential could be used to run the resource as another user than SYSTEM. Then there should be be no need to specify the credential parameter? But for using this in WMF 4.0 then Credential parameter need to be specified to use New-CImSession with -Credential parameter.

@johlju I don't think this would be a breaking change since it was working previously and as pointed out #49 broke this unknowingly.
The solution you are proposing i'm okay with implementing as it seems like the original author of this @corydwood was proposing the same solution.
I do have a couple of more questions in the regards:

What versions of WMF/Powershell should be supported in DSC modules that exist in the DSC resource kit?

Both WMF4 and WMF5?

I asked the question before as well, the respons to my question was that if it is possible to keep WMF 4.0 support, then that would be a good thing, but it is not a requirement.
In SqlServerDsc we are only supporting WMF 5.x since to support for WMF 4.0 would have been to much work. In SqlServerDsc we actually removed some WMF 4.0 support to remove technical debt and support more WMF 5.x scenarios (like support for built-in PsDscRunAsCredential). Maybe some resource in SqlServerDsc work on WMF 4.0, but that is nothing that is tested.
In this case, try to keep WMF 4.0 support if possible, but if that will result in more technical debt (new know issues that can be solved) then I would say to remove WMF 4.0. But that would be a breaking change. At the end it's up to the DSC community, should we keep WMF 4.0 or not for this resource module?

authors: Sawal72 TraGicCode corydwood ejleroy greggoindenver johlju jpuskar

repo: PowerShell/xDnsServer


text:
Fixes multiple PSScriptAnalyzer issues

Pull Request (PR) description
Fixes multiple PSScriptAnalyzer issues. Specifically, fixes all instances of PSAvoidTrailingWhitespace, PSAvoidGlobalVars, PSAvoidUsingConvertToSecureStringWithPlainText, PSUseSingularNouns, and fixes many instances of PSUseDeclaredVarsMoreThanAssignments.
This Pull Request (PR) fixes the following issues
Not positive exactly what the following issue is tracking, but if the intention of it is just to remove non-suppressed globals, then this PR does just that.
https://github.com/PowerShell/xExchange/issues/234
Task list

[x] Added an entry under the Unreleased section in the CHANGELOG.md? Entry
should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md?
[ ] Resource parameter descriptions added/updated in README.md, schema.mof
and comment-based help?
[ ] Comment-based help added/updated?
[ ] Localization strings added/updated in all localization files as appropriate?
[ ] Examples appropriately added/updated?
[x] Unit tests added/updated?
See DSC Resource Testing Guidelines.
[x] Integration tests added/updated (where possible)?
See DSC Resource Testing Guidelines.
[x] New/changed code adheres to
DSC Resource Style Guidelines
and Best Practices?

This change is

Codecov Report

Merging #278 into dev will increase coverage by 1.16%.
The diff coverage is 26.08%.

@@           Coverage Diff            @@
##             dev    #278      +/-   ##
========================================
+ Coverage   1.45%   2.62%   +1.16%
========================================
  Files         36      38       +2
  Lines       3974    4422     +448
========================================
+ Hits          58     116      +58
- Misses      3916    4306     +390

Impacted Files
Coverage Δ

...rtualDirectory/MSFT_xExchMapiVirtualDirectory.psm1
2.7% <ø> (ø)
:arrow_up:

...ientAccessServer/MSFT_xExchClientAccessServer.psm1
1.28% <ø> (+0.01%)
:arrow_up:

...MSFT_xExchImapSettings/MSFT_xExchImapSettings.psm1
2.77% <ø> (ø)
:arrow_up:

...irectory/MSFT_xExchPowerShellVirtualDirectory.psm1
2.12% <ø> (ø)
:arrow_up:

...portService/MSFT_xExchMailboxTransportService.psm1
1.17% <ø> (ø)
:arrow_up:

...FT_xExchWaitForADPrep/MSFT_xExchWaitForADPrep.psm1
1.01% <ø> (ø)
:arrow_up:

...urces/MSFT_xExchUMService/MSFT_xExchUMService.psm1
3.84% <ø> (ø)
:arrow_up:

...MalwareScanning/MSFT_xExchAntiMalwareScanning.psm1
3.57% <ø> (ø)
:arrow_up:

...chTransportService/MSFT_xExchTransportService.psm1
0.31% <ø> (ø)
:arrow_up:

...ces/MSFT_xExchWaitForDAG/MSFT_xExchWaitForDAG.psm1
3.57% <ø> (ø)
:arrow_up:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb6fc94...f79bcdb. Read the comment docs.

Any chance someone can do a code review on this one? Thanks.

@mhendric I have on my list, didn't have time yesterday or today. This week definitely! 🙂

Set-TargetResource should not return a value, so Out-Nullshould not be necessary? Throughout all tests.

You are correct. Fixed.

No password is set here, is this correct?

That's correct. For test purposes, Exchange doesn't care whether you give a valid password or not, so I decided to just remove it altogether.

@mhendric Awesome work as usually! Left this one for you to merge.

authors: codecov-io johlju mhendric

repo: PowerShell/xExchange


text:
xSQLServerSetup: Provide support for using Cluster Shared Volumes as installation points

Details of the scenario you try and problem that is occurring:
Currently the resource does not support the use of Cluster Shared Volumes for installation points. The disks are not mapped due to the logic looking at the drive letter of the path, which for CSVs is C:.
The DSC configuration that is using the resource (as detailed as possible):
Any cluster installation configuration where CSVs are used.
Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
SQL Server 2016 and Windows Server 2016
Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev

I've got this one in progress.

repo: PowerShell/xSQLServer


text:
Add entropy-blocking wrapper

This wrapper class would wrap another EntropyCountingRandom and wait for the entropy to be above a given (zero or negative) threshold before returning any data.
EntropyBlockingRandomWrapper is now implemented, but the following steps remain:

[x] Fix test failures in EntropyBlockingRandomWrapper on Java 7 branch.
[x] Test a nextBytes() call that's large enough to need reseeding partway through.
[x] Add an EntropyBlockingSplittableRandomAdapter class.
[x] Check mutation-test results for missing test cases.

Done in 4.1.0.


text:
Option to inline all assets

An option inline all assets (CSS/JavaScript) would be great. This way the files could be totally independent moved and copied around without worrying that all the appropriate asset folders have to be present.

@PragTob can I take this one?

Sure thing :)

@PragTob please close this one.

I always forget 😅

authors: PragTob elpikel


text:
Cursor warps for no reason

Hi,
Lately I have been having issues with the cursor occasionally warping short distances without any eye movement (using eViacam and EyeTracker 4C).  It seems to jump just outside the warp radius, sometimes several times in a row--I will be looking at an icon, but before I can click, the cursor will jump off it; I will look away and look back to reset the cursor, then it will jump off (often in exactly the same direction) again, even though me eyes have not moved and I am still staring intently at the thing i am trying to click.  The issue seems to happen more frequently closer to the edges of the screen, so it may have something to do with hardware limitations of the EyeTracker (although my monitor is within the supported range).  I tried re-calibrating the eye tracker, and that seemed to fix the issue for about five minutes before it started happening again.  Any ideas on why this may be happening or what I can do about it?  It does not happen all the time, and I can usually click what I need on at least the second or third try, but it would be nice to be able to get things the first time.  Like I said, closer the middle of the screen, this almost never happens.

Yes @caspark is right the debug overlay helps here. The EyeX is less accurate at the edges of the screen. You can verify this in the calibration mode. Also make sure EyeX has big white dots instead of small grey ones for your eyes. The accuracy goes down when you sit too far from the screen. Adjusting the warp threshold can help too. I set mine high enough that it doesn't randomly warp, and I use my head rotation to make up for the gap around the corners. That's easier for me than retrying 2-3 times. Closing because that's all I can think of right now. If you find a good technique feel free to share  it though.

repo: PrecisionGazeMouse/PrecisionGazeMouse


text:
Decouple px-vis-pie and pie-chart

px-vis-pie owns too much of the logic of the chart. We need to decouple:

tooltip
popover
title

and bring them back in control of the chart itself

done in latest master. will close on release

Fixed with 1.0.0 release

repo: PredixDev/px-vis-pie-chart


text:
Troubleshooting on multistore

Hello !
I spotted a problem in multistore with the "selector" type with the "Category" collection.
Here is the detail :

The multistore mode is activated (id_shop 1 and id_shop 2)
The products are common between the shops
The category is common between stores
I created a block:

$blocks[] = [
     'name' => $this->l('Products from category'),
     'description' => $this->l('Products from category'),
     'code' => 'featured_product',
     'tab' => 'general',
     'icon' => 'GiftIcon',
     'need_reload' => true,
     'templates' => [
         'default' => 'module:'.$this->name.'/views/templates/blocks/slider-products.tpl'
     ],
     'config' => [
         'fields' => [
             'category' => [
                 'type' => 'selector',
                 'label' => 'Category',
                 'collection' => 'Category',
                 'default' => '2',
                 'selector' => '{id} - {name}'
             ],
             'title' => [
                 'type' => 'text',
                 'default' => 'Our products',
                 'label' => 'Title'
             ]
         ],
     ],
];

Result :

On the id_shop 1 store, the products of the category are well reported
On the id_shop 2 store, the blocks.extra.products is false

I tried to trace the track I have the impression that there is a blockage in the formatFieldSelector function see in Configuration::get(), but I can't find a conclusive track...
Do you have an idea ?
Thanks in advance !

Hi. Sorry for this issue.
I actually can't check this week
I'll make some tests next week. If i have the same issue i'll fix it.
Maybe that context is not send to controller. I'll let you know.

Hello,
I've been looking into this a bit, I noticed that when creating a block in the ps_configuration table the row is added with the main shop id.
I tried to remove the shop id in the column id_shop to put NULL and my block appears well in the 2 shops.
If I use prettyblock in a different shop context, prettyblock does not work (displays "loading"). Maybe this is related?
I hope I'm clear in what I'm saying.

Hello,
I've been looking into this a bit, I noticed that when creating a block in the ps_configuration table the row is added with the main shop id.
I tried to remove the shop id in the column id_shop to put NULL and my block appears well in the 2 shops.
If I use prettyblock in a different shop context, prettyblock does not work (displays "loading"). Maybe this is related?
I hope I'm clear in what I'm saying.

The "loading" issue is because the iframe displaying your website is loading with a different url than the current shop context so it gets blocked by crossorigin policies, at least this is what I noticed in my case.

authors: PrestaSafe adn34 cyrielle-vuillemin

repo: PrestaSafe/prettyblocks


text:
Fix query "BIGINT UNSIGNED value is out of range"

Questions
Answers

Description
Fix query error with a result of a white dashboard widget and a error log PHP Warning:  Invalid argument supplied for foreach() in /modules/dashproducts/dashproducts.php on line 219 and a SQL error with message "BIGINT UNSIGNED value is out of range in 'prestashop_db.od.product_quantity - prestashop_db.od.product_quantity_refunded - prestashop_db.od.product_quantity_return - prestashop_db.od.product_quantity_reinjected'". Fixed by casting the values on the SUM aggregator function

Type
Bugfix

BC breaks
No

Depreactions
I hope no

Fixed ticket
n/d

How to test
PS 1.7.8.2, PHP 7.4.27, 10.5.13-MariaDB, bestproducts v2.1.1

Hi @PierreRambaud, the reason is this widget on the dashboard appear white.

Also, checking the log files to erase any possible warning or error, always loading the dashboard index page produce a error log with this warning:
PHP Warning: Invalid argument supplied for foreach() in /modules/dashproducts/dashproducts.php on line 219
Checking what happen on that line, is because the code don't have nothing to check if the query return false, expecting that always work. Debugging that query using the Db::getInstance()->getMsgError() says:
BIGINT UNSIGNED value is out of range in 'prestashop_db.od.product_quantity - prestashop_db.od.product_quantity_refunded - prestashop_db.od.product_quantity_return - prestashop_db.od.product_quantity_reinjected'
Checking on the internet why that query throw that, is caused by dont CASE as signed the values (maybe about the query on dashproducts are taking negatives values for stock, or maybe nulls, or I don't know). The thing is that in all examples through stackoverflow recommend that all agreggate functions (SUM on this case) that use inside then a math formula (that has 4 values substraction between them) must be with the CASE as SIGNED. With that, not only the warning dissapear, also the query return values again and the widget on the dashboard is working again.
My installation is like the latest for everything:

PrestaShop 1.7.8.2
PHP 7.4.27
MariaDB 10.5.13 (2021-11-08)
bestproducts v2.1.1

repo: PrestaShop/dashproducts


text:
Remove optional parameter before required parameter

Questions
Answers

Description?
declaring a function with an optional parameter before a required parameter is deprecated in PHP 8.1, this PR aims to fix this deprecation.

Type?
improvement

BC breaks?
no

Deprecations?
no

Fixed ticket?

How to test?
Nothing should have changed

QA: You could test sorting of the blocks

Thank you @atomiix

authors: PierreRambaud atomiix kpodemski


text:
Adding GitHub actions covering Travis steps

We complete the test & build process with GitHub actions, replacing in the future the Travis jobs and being used as a reference for other modules
ToDo:

[ ] Squash all commits to avoid the same title in 20 commits

The artifact seems to be good!
Please squash your commits then we're good to go :raised_hands:

Closing to avoid too many notifications


text:
[1.12.2] Eating Cyclic Hearts seems to have no effect on the player

Minecraft 1.12.2 & Cyclic 1.10.3
Single player
Describe problem
Eating the cyclic hearts seems to have no effect on the player except a minor saturation restoration as if you were eating any normal food. Eating it at half health did not heal any hearts as well, and my health bar stayed at 10 hearts, I jumped into lava to confirm. The difficulty was on Hard if it matters. Am I using this item correctly?
(If this is a suggestion and not a bug report, delete all this and just write your suggestion!)

Ahh ouch, it's a fairly large custom pack I've been working on for the past 3 months, glancing quickly at the modlist at the possible mods that might affect hearts:
Betweenlands
Baubley Heart Canisters
Mantle (handles the changing heart colors like how TiC used to do it)
Nutrition (it's additional hearts though seems to be compatible with Mantle)
I might be missing a couple but those 4 seem to be it at the moment.

It depends how they are written. Cyclic goes "you eat a thing, ok take your current hearts and add +1" so its usually fairly compatible, ive used it with nutrition and mantle before, others not so much.
What some mods may do is something like
"What does my mod logic say the players health should be? is it 10 hearts? ok set that now" and run that at regular intervals.  So when you eat a heart and go to 11, some other mod will be like "nope fix that".
Not anybodys fault really just how it works.  So you could either
A) disable the heart items from Cyclic in config file and let other systems take over
B) find out what mod is conflicting, and make a bug report there

Sounds like we figured this out, and its just a matter of mods doing the same thing in different ways.
I will mark as fixed by config, if theres any issues with only Cyclic, open them up anytime!

repo: PrinceOfAmber/Cyclic


text:
Tablet/mobile style issues

Catch-all for style issues deemed minor enough that they weren't required for closing the other style tickets.

Mobile:

Collections tiles not aligned correctly--left margin is too tight, right margin is too wide.

The advisory board heading on the contributor page is smaller than individual contributor titles which is jarring to me because I know it's supposed to be a section heading; likely confusing to others. In the design it looks like it is the same size and there is more space above it.

need to re-evaluate how many of these are still a problem.

@mnaydan do you have a sense of how many of these were captured by the more specific issues we're testing now? it seems like at least 5, 6, 8, 9, 10 for mobile and 2 for tablet are mentioned specifically in other issues.
some of them might no longer be issues as well, not sure

For mobile
1 is still a problem (collections tiles not centered on main page) but not important enough to me if you don't have time
2 I don't care about anymore
3 is still a discrepancy b/w the designs and prod but I don't care about fixing it
4 is fixed
5 and 6 are captured in other user stories
7 is so minor I don't care
8 is captured in another user story (and fixed)
9-10 are captured in other user stories
I don't have my tablet with me to check. Will get back to you on this.

altered the font size slightly for these cards so hopefully they should all now fit - I realized there are collections in here that I don't have locally to test with because they were created recently, hence the discrepancy

All solved I believe - unless @mnaydan  still cares to fix 1,2 and 7?

authors: mnaydan rlskoeser thatbudakguy wafaisfahany

repo: Princeton-CDH/ppa-django


text:
is there any pre-trained models

The data for training is large. Is there a pre-trained model?

The celeba dataset is less than 5 GB, which is not very large.
I do not provide pre-trained model.

The tar file of cropped and aligned images is less than 5gb, but the original one is much larger.
I have provided the preprocess.py for preprocessing the original images. So you might have to download the original celeba dataset. Sorry!

Thanks a lot.

authors: Prinsphield gaoyangyiqiao

repo: Prinsphield/ELEGANT


text:
add Vue support

Vue SFCs look like this:

Actually it's just a special HTML. See: https://vuejs.org/v2/guide/single-file-components.html

I'm not sure I'm in favor of this addition. Vue is not a language is it? It does not even have a special syntax?
What issue is this PR supposed to fix? It it to be able to add class language-vue to code blocks?

@Golmote Yeah... Sort of like that.

@mAAdhaTTah I'm not worried about the filesize, we have minified versions to deal with this (obtw it appears to be missing from this PR). I'm worried about the semantics...
I went through the VueJS doc, and I see it has a Mustache-like template syntax. If we were to add a component for this (maybe it could handle multiple templating languages depending on how similar they are), we could then consider it a "language". But just adding vue as a alias for markup seems not appropriate to me.

@Golmote I agree with you.

For example, the current markup definition doesn't handle this well:
<div>{{ look_at_me }}</div>

authors: Golmote riophae

repo: PrismJS/prism


text:
✨UI FIX✨

I can refactor this page.Can you please assign me this work.

@PriyaGhosal  can you please assign me this task , i would like to fix this issue and resolve it.

@T-Rahul-prabhu-38 Thanks for creating the issue in BuddyTrail!!! The issue has been assigned to you.
Before you start working on your PR, please make sure to:

⭐ Star the repository if you haven't already.
Pull the latest changes to avoid any merge conflicts.
Attach before & after screenshots in your PR for clarity.
Include the issue number in your PR description for better tracking.

Contributors will start at Level 1, and their level will increase based on the quality and quantity of their contributions. The more effort and value you bring, the faster you'll progress. Put forth your best effort to unlock new levels and opportunities!
I'm excited to see your contribution as part of GSSOC EXTENDED 2024! 🎉
Don't forget to follow me on GitHub for more updates.
Happy open-source contributing! 🚀

i had another idea

if i add a local storage base for this will the level be buffed to 3?
local storage base can be proved to be very useful for getting user credentials back and even to store JWT's during authentication and login.

repo: PriyaGhosal/BuddyTrail


text:
[Enhancement] About Page Redesigned

Related Issue
Fixes:  #797
Description
I've updated the webpage and separated the html and css into 2 individual files for better readability.
I am participating in hacktoberfest @PriyaGhosal

Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
Before:

After:

Checklist:

[x] I have made this change from my own.
[x] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

@zeropse Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile!
Great contribution ! 🎉

authors: PriyaGhosal zeropse


text:
AttributeError: module 'tensorflow.contrib.tpu' has no attribute 'InputPipelineConfig'

这个问题是什么原因呢

这个问题是什么原因呢

请问一下您解决了这个问题了吗？

可能是版本问题，方便提供一下环境吗？

repo: ProHiryu/bert-chinese-ner


text:
Automate publishing

Automate publishing to ease publishing an update for contributors.
Resources:

https://code.visualstudio.com/api/working-with-extensions/bundling-extension
https://github.com/xdebug/vscode-php-debug

Implemented in https://github.com/ProVerif/vscode-proverif-language-service/pull/17

Worked for release v1.2.3, hence closing this issue.


text:
Chasing Reference Cycles...

In isolating reference cycle leaks in my own Procedures, based on CKProcedure and NetworkProcedure, I discovered a couple unsafe callbacks I was using and was able to eliminate them. I used the "Debug Memory Graph" feature in Xcode 8.
While doing this I was seeing some graphs that I could not explain: memory being used in the ProcedureKit framework after some Procedures had finished successfully.
Instead of looking more at my own code, I decided I would just see what happens if I look at the graph when running only a single test in the ProcedureKitCloudTests - CKFetchRecordsOperationTests.
Two significant Xcode screen shots are the result that I cannot explain. They're taken right after ProcedureKitTestCase tearDown is invoked.
I am afraid that in looking at the graphs here I may be chasing a problem that may not actually exist.
Question: what's the best debugging strategy for making sure that everything is cleared up after every execution of a Procedure?

An additional item: I didn't make any changes to the ProcedureKit framework other than inserting the following into the TestCKFetchRecordsOperation
    deinit {
        print("Deinit: \(String(describing: type(of: self)))")
    }

Note that I could see this method being invoked to clean up the initial, un-queued, CloudKitProcedure that is replaced in the final 7 cases of CloudKitProcedureFetchRecordChangesOperationTests. Once queued, I'm not seeing any de-initialization. A good example should have been test__error_which_retries_using_retry_after_key() because the the Procedure is supposed to have been queued again after a simulated failure.
I repeat that my question revolves around monitoring the proper clean-up of Procedures once submitted and complete. Is there a way to do this properly in the event that XCTest doesn't have the proper hooks?

Hi,
Last time I checked, there were still some false-positives that could be triggered with certain patterns of Swift code / data structures + the Memory Graph Debugger / Leaks instrument. (These could show as both properly-attributed objects and unattributed memory allocations.) Where we can, we've worked around these false-positives, but some still exist. I'll check again with Xcode 8.3.2.
There are a few shared singleton objects in the ProcedureKit framework, so some of those entries are expected from that standpoint. (LogManager, ExclusivityManager, etc.)
In general: A lot that happens inside the framework is asynchronous and occurs on background queues/threads, which means that pausing at an arbitrary point from the perspective of the main thread (ex. after tearDown is invoked for a specific test) does not necessarily guarantee that things will be fully cleaned up, nor that they won't eventually be cleaned up.
For example, here's what happens when a Procedure finishes (abridged version):

WillFinish observers / overrides are called
The Procedure sets isFinished to true with appropriate KVO notifications <-- At this point, the Queue treats the Procedure as finished and, once the internals handle the KVO notification, it should release its reference to the Procedure, which is probably not the last reference
DidFinish observers / overrides are called

The call to finish(withErrors:) is asynchronous - so it very well may return before some or all of the above has occurred.
And just because the Procedure is "finished" (i.e. isFinished is true), doesn't mean the framework isn't still processing it in a background thread / queue (DidFinish observers or otherwise). So a legitimate reference to the Procedure may still exist.
There are a lot of complexities in this area, and I'm afraid I don't have an easy / perfect solution to offer to help with debugging. In general, waiting some lengthy period of time (wall-clock seconds) after the Procedure has finished and all DidFinish observers have been called might be one route that is helpful. You probably don't want to block the main thread while waiting, though - because in certain circumstances that could prevent cleanup of certain resources.

All the above said, looking at the CloudKitProcedure tests, it looks like some of the test classes are missing tearDown overrides that release the tested CloudKitProcedure as part of tearDown. (It should be released when the next test occurs and resets the cloudkit variable, though.) So that's probably confounding what you're seeing.

Thanks for your immediate feedback!
I understand that the framework does have some number of singleton objects. Those don't concern me at all, it's just the growth of objects in the graph that I really worry about.
I just made a change to tearDown() in the CloudKitProcedureFetchRecordOperationTests to set the cloudkit property back to nil before calling super.tearDown().
That said, I am still noticing that the graph is still showing a lot of references to CKProcedure<TestCKFetchRecordsOperation> instances. I'll be anxiously awaiting further updates and/or advice. I really want to isolate real issues from phantom issues and my issue from those that might exist in the framework.

Question: if your notion about wall-time is correct, then would you imagine that upping the CKErrorRetryAfterKey in test__error_which_retries_using_retry_after_keyto a large number  (the CloudKit standard is 3 seconds I believe) should that result in the clean up of the failed cloudkit procedure instance since it's being replaced with a new instance? I can try that test too if you think it might have an impact.

I'm also looking into whether there's an unexpected delay related to the TimeoutObserver that is internally added to the CloudKitProcedure. Will respond when I have more.

authors: StephenDaedalus swiftlyfalling

repo: ProcedureKit/ProcedureKit


text:
Add possibility to expose DispatchQueue from EventQueue for RxSwift Scheduler

We are using in project RxSwift and ProcedureKit and I unable to access to DispatchQueue to create
SerialDispatchQueueScheduler in RxSwift for observer.
// ProcedureKit
public class EventQueue {
   fileprivate let queue: DispatchQueue
   public init(label: String, qos: DispatchQoS = .default) {
        self.queue = DispatchQueue(label: label)
  }
  ...
}

// RXSwift
public class SerialDispatchQueueScheduler : SchedulerType {
  init(serialQueue: DispatchQueue, leeway: DispatchTimeInterval =  DispatchTimeInterval.nanoseconds(0)) {
        configuration = DispatchQueueConfiguration(queue: serialQueue, leeway: leeway)
    }
  ...
}

Solutions1 (more appropriate way) :
Create init with custom queue in EventQueue class
Solution2 (simple solution):
Change fileprivate to public property for queue property
I can create PR if need

Hi @evilutioner - this is interesting. In theory, it's not an issue to change this property to public.
But, just stepping back a second, can you elaborate on how you want to combine usage of ProcedureKit and RXSwift? My hunch is that you're going to do something like...
protocol SchedulerProvider {
    var scheduler: SchedulerType { get }
}

extension Procedure: SchedulerProvider {
    var scheduler: SchedulerType {
        return SerialDispatchQueueScheduler(serialQueue: eventQueue.dispatchQueue)
    }
}

But, just wondering how you're then going to use this?

@swiftlyfalling any thoughts on this?

I can show two ways of using scheduler or not using:
class MyOperation: Procedure {
    override func execute1() {
        _ = observable.subscribe(onNext: {
            // some work
        }).observeOn(myScheduler)
    }

    override func execute2() {
        _ = observable.subscribe(onNext: {
             self.eventQueue.asyncDispatch { in
                // some work
            }
        })
    }
}

Okay, so you'd have some base Procedure subclass which can be initialised (or injected) with an observable, and its execute method is one of the two above. And then presumably in the // some work you call finish() to end the procedure.
I haven't worked on a project which mixes the two frameworks/paradigms. Certainly interesting from a can we do it perspective. I'm not entirely sure that it's a good idea, but that's a different discussion.
Of the two approaches above - I much prefer option two, as it requires no changes to the access controls in ProcedureKit as it stands. I'm guessing you would prefer option 1 - but what is the motivation behind that? What makes option 1 "better"?

@danthorpe

What makes option 1 "better"?

Solution 1 can prevent user to escape use you abstract layer. It can be such way:
override func execute() {
        // some work
             self.eventQueue.queue.async {
                // some work
            }
    }

I think, however, that if the DispatchQueue is exposed, it is a potential problem as it will be possible to dispatch work items onto the queue by-passing the lock with guarantees serial behaviour. So, while SerialDispatchQueueScheduler is "serial" it would effectively mean that the underlying DispatchQueue has two serial "queues".
Perhaps a better approach is to make EventQueue conform to SchedulerType - is it a base class, or a protocol?

Please, explain how to do this, you can have a look to protocol:
public protocol SchedulerType: ImmediateSchedulerType {
    var now : RxTime {
        get
    }
    func scheduleRelative<StateType>(_ state: StateType, dueTime: RxTimeInterval, action: @escaping (StateType) -> Disposable) -> Disposable
    func schedulePeriodic<StateType>(_ state: StateType, startAfter: RxTimeInterval, period: RxTimeInterval, action: @escaping (StateType) -> StateType) -> Disposable
}

public protocol ImmediateSchedulerType {
    func schedule<StateType>(_ state: StateType, action: @escaping (StateType) -> Disposable) -> Disposable
}

Looks like it's a protocol (https://github.com/ReactiveX/RxSwift/blob/master/RxSwift/SchedulerType.swift), why not add:
extension ProcedureKit.EventQueue: RxSwift.SchedulerType {

    func schedule<StateType>(_ state: StateType, action: @escaping (StateType) -> Disposable) -> Disposable {
        // TODO: ??
    }

    func scheduleRelative<StateType>(_ state: StateType, dueTime: RxTimeInterval, action: @escaping (StateType) -> Disposable) -> Disposable {
        // TODO: ??
    }

    func schedulePeriodic<StateType>(_ state: StateType, startAfter: RxTimeInterval, period: RxTimeInterval, action: @escaping (StateType) -> StateType) -> Disposable {
        // TODO: ??
    }
}

And use the public API of EventQueue to fulfil these RxSwift APIs.

Potentially, we could support all of this in a ProcedureKit+RxSwift mini-framework.

IMHO It's overkill

Can I make simple PR and resolve this issue?

Yeah, you can submit a PR, and it'll get discussed. But I'm pretty sure that we will not want to expose the underlying DispatchQueue - the whole purpose of EventQueue is to protect that dispatch queue.
You may not see it as an issue for your project, but I need to consider all framework consumers.

Implementation of that extension, would effectively be similar to https://github.com/ReactiveX/RxSwift/blob/53cd723d40d05177e790c8c34c36cec7092a6106/RxSwift/Schedulers/Internal/DispatchQueueConfiguration.swift

How to created  DispatchSource from EventQueue?
let timer = DispatchSource.makeTimerSource(queue: queue)

Yeah, that might be tricky without PK modifications.

Implementation of that extension, would effectively be similar to https://github.com/ReactiveX/RxSwift/blob/53cd723d40d05177e790c8c34c36cec7092a6106/RxSwift/Schedulers/Internal/DispatchQueueConfiguration.swift

Thanks, I will try

@danthorpe
Could you make function makeTimerSource as public ?
func makeTimerSource(flags: DispatchSource.TimerFlags = []) -> DispatchSourceTimer { }

Yeah, we can do this.

Yeah, we can do this.

Thanks!

[...] I'm pretty sure that we will not want to expose the underlying DispatchQueue - the whole purpose of EventQueue is to protect that dispatch queue.
You may not see it as an issue for your project, but I need to consider all framework consumers.

Just to highlight, I concur with the above.
A lot of the internal / private parts of ProcedureKit (especially related to the nature of how Procedures / events are executed, synchronized and dispatched) are not exposed for very considered reasons.
(An important goal is making it much harder for framework consumers to end up creating deadlocks / thread-safety issues through use of the public API.)
Haven't had a chance yet to dig into alternative possibilities to what's been suggested.

Closing this for now.

authors: danthorpe evilutioner swiftlyfalling


text:
[GAME] Iterator für Components in Entity

Für Eventhandler aus #197 ist es nötig, dass Entity-Instanzen aus dem Dungeon-Kontext in die DSL überführt werden. Dafür muss dynamisch für eine Entity-Instanz ermittelt werden, welche Components in der Entity enthalten sind.
Aktuell erfordert dies, alle im DSL-Typsystem geladenen Datentypen nach Components zu durchsuchen und für jedes Component per isPresent()-Aufruf zu überprüfen, ob die Komponent in der Entität enthalten ist. Das ist ziemlich umständlich.
Daher sollte ein Iterator für die Komponenten einer Entität implementiert werden.

@AMatutat kein Assignee?

Für Eventhandler aus #197 ist es nötig, dass Entity-Instanzen aus dem Dungeon-Kontext in die DSL überführt werden. Dafür muss dynamisch für eine Entity-Instanz ermittelt werden, welche Components in der Entity enthalten sind.
Aktuell erfordert dies, alle im DSL-Typsystem geladenen Datentypen nach Components zu durchsuchen und für jedes Component per isPresent()-Aufruf zu überprüfen, ob die Komponent in der Entität enthalten ist. Das ist ziemlich umständlich.
Daher sollte ein Iterator für die Komponenten einer Entität implementiert werden.

@malt-r Ich bin mir nicht sicher, aber das klingt für mich, als ob Du einen Stream deiner Entitäten machen möchtest und mit einem flatMap die gewünschte Component rausholst und dann in einem finalen foreach über die verbleibenen Components im Stream gehen willst und die gewünschte Operation auf die über die Component erreichbaren Entitäten anwenden willst? Oder liege ich da grad ganz weit daneben?

@AMatutat kein Assignee?

Bin mir nicht sicher ob ich das mache ohne an eine SHK abdrücke. Eigentlich können die das auch, aber high prio. Falls sich einer der @Programmiermethoden/codrs berufen fühlt, kann er/sie sich das schnappen. Ich assigne mir das um, wenn ich es aktiv angehe.

@AMatutat Vorher sollte aber geklärt werden, was wirklich gebraucht wird. Wir arbeiten aktuell vor allem mit Streams - Iterable scheint mir irgendwie so halb parallel zu liegen.

@AMatutat Vorher sollte aber geklärt werden, was wirklich gebraucht wird. Wir arbeiten aktuell vor allem mit Streams - Iterable scheint mir irgendwie so halb parallel zu liegen.

@malt-r hmm jetzt wo er es sagt, vielleicht willst du auch einfach einen Stream über alle Components? Also quasi über das Value-Set der HashMap. Dann müsstest du dir natürlich noch selbst raussuchen, welchen Typ das jeweilige Component hat (aber das ist ja ein stumpfes, getClass)

Das funktioniert wahrscheinlich genau so gut für mich. Irgendeine Möglichkeit, über die enthaltenen Components zu iterieren (in welcher Form auch immer), würde mir da schon weiterhelfen. Wenn im Rest der Codebasis aktuell eher mit streams gearbeitet wird, dann sollten wir das wahrscheinlich hier auch weiter durchziehen.

authors: AMatutat cagix malt-r

repo: Programmiermethoden/Dungeon


text:
3d_segmentation/brats_segmentation_3d.ipynb TypeError: got an unexpected keyword argument 'threshold' for AsDiscrete transform

Describe the bug
The argument threshold is not expected when calling the transform AsDiscrete cell 8 in the tutorial.
To Reproduce
Steps to reproduce the behavior:

Go to 3d_segmentation/brats_segmentation_3d.ipynb
Run code cells up to the number 8, the bug should come up.

Expected behavior
That the transformation could work with the specified threshold, probably is just a matter of renaming the argument to logit_thresh?
Screenshots

Environment (please complete the following information):

OS: MacOS 12.01
Python version 3.9.7
MONAI version 0.7.0
CUDA/cuDNN version: (N/A) CPU
GPU models and configuration: (N/A)

Hi! The updated version of Monai - 0.8.0 was able to fix this issue.

authors: gvigkannan sebastianffx

repo: Project-MONAI/tutorials


text:
Change drag marker to refresh route on drag not click

Currently refresh of route happens on.releasee make it on.drag
/cc @danpat

Consider putting a small timer in on.drag to prevent rapid dragging flooding the server with requests.  Only update the route when the timer expires, and renew the timer whenever on.drag occurs.  Something like 75-100ms should be almost unnoticeable and would greatly reduce the number of requests during dragging.

Something like:
  var drag_timeout;
  on.drag(function() {
     clearTimeout(drag_timeout);
     drag_timeout = setTimeout(function() { updateRoute(); }, 100);
  });

@danpat - LRM has an option for routeWhileDragging and routeDragInterval, which I've set to true and 100 but I'm not sure it's overriding properly but it's showing up as false in my js/osrm.bundle.js ... see anything I'm missing here?

@danpat - Fixed https://github.com/Project-OSRM/osrm-frontend-v2/commit/dc7608f91db0697e0a84cb94d703ceed5c89d87d! Needs to be set twice in control and plan.

authors: amyleew danpat


text:
CPU workload rising while staying in the same position

I had a problem where the app would slow down more and more with time while not changing the scene. At first I thought this was a problem with my memory management, but through the help of a colleague we found that in SceneLocationView.swift there is an array SceneLocationEstimates that gets a new value added every second in addSceneLocationEstimate.
There is functionality that gets called to cull this array again(removeOldLocationEstimates), but it only filters out estimates that are more than a specified radius removed from the current location.
This means, if the user stays in the same place the array keeps growing and eventually slowing down the app through the constant sorting.
Capping the array size and constantly removing old elements fixes this issue for me.

@KaiKruschel - Would you please submit a PR for this issue?

authors: KaiKruschel intere

repo: ProjectDent/ARKit-CoreLocation


text:
Cookbook guide is inconsistent with latest template

The section Update repository-specific text currently says that "tags" and "thumbnail" should be edited in _config.yml but these fields are actually in _gallery_info.yml.

Also I think this line is not needed and should be removed:
Edit the notebooks/how-to-cite.md file with your Cookbook title in the line, “The material in is licensed …”

because the boilerplate text is just "The material in this Project Pythia Cookbook is licensed ..." and that's good enough for most.

In general I think that some of the steps in the Cookbook guide can be reordered. I don't think it makes sense to ask people to fill out the CITATION.cff file until after content development. The guide should focus on getting people building content as painlessly and possible, and then follow up with additional steps for getting the Cookbook reviewed and listed on the Gallery.

One more point: when the repo is transferred to ProjectPythia org, there are quite a few URLs that need updating across multiple files. In many ways it would be simpler to encourage people to reverse the order: transfer the repo immediately, before running the trigger-replace-links action.
We should encourage people to see parking the repo in the ProjectPythia org just a simple way to express intentions to eventually have the work appear in the Pythia gallery, as well as inviting collaboration.
Review and acceptance into the gallery is an entirely separate step.

I will attempt a PR that reorders the instructions and resolves the inconsistencies noted above.

Our current guide also says nothing about the testing and publishing infrastructure, and how to interact with Pull Requests, previews, etc. I'm adding detail about this to the revised guide.


text:
Lernelement Darstellung in DetailSection überarbeiten

User Story
Als Benutzerrolle möchte ich Funktionalität sodass Wert für den Nutzer
Akzeptanzkriterien

[ ] Häkchen vor Lernelemente rausnehmen
[ ] Grünes Häkchen über Lernelement-Icon legen
[ ] Lernelement-Typ in Klammern rausnehmen
[ ] Punkte rechtsbündig darstellen

Definition of Ready

[ ] User Story ist klein genug für Sprint
[ ] User Story ist für jeden beteiligten Entwickler klar verständlich
[ ] User Story Aufwand ist geschätzt
[ ] User Story hat Akzeptanzkriterien
[ ] User Story hat einen Mehrwert für das Produkt oder die Entwicklung
[ ] User Story Ursprung ist bekannt (Stakeholder)
[ ] User Story ist Release zugewiesen

Definition of Done

[ ] Alle Akzeptanzkriterien sind erfüllt
[ ] Die Implementierung ist gepusht
[ ] Die Codekonventionen sind eingehalten
[ ] Eine Code Review wurde durchgeführt (oder in Paired Programming gearbeitet)
[ ] Unittestabdeckung muss größer 92% sein
[ ] Alle Tests müssen bestanden sein
[ ] Technische Dokumentation innerhalb der Realisierung wurde, falls nötig, erstellt (Quellcode)
[ ] Benutzerdokumentation wurde, falls nötig, angelegt (Wiki)
[ ] Dokumentation des Vorgehens wurde, falls nötig, angelegt (Zenhub Kommentar)
[ ] UML Aktivitätsdiagramm wurde erstellt bzw. aktualisiert falls nötig
[ ] Changelog des jeweiligen Release wurde aktualisiert, falls erforderlich (Wiki)
[ ] Es gibt keine bekannten Bugs
[ ] Die Realisierung der User Story wurde erfolgreich durch den Product Owner abgenommen

Hey team! Please add your planning poker estimate with Zenhub @DerKatsche @Lizardguard


text:
Meetings zu Standardisiertem Workflow und Doku dazu

User Story
Als Benutzerrolle möchte ich Funktionalität sodass Wert für den Nutzer
Akzeptanzkriterien

[ ] An Vorbesprechung teilnehmen
[ ] An Hauptbesprechung teilnehmen
[ ] Anforderungen aus Meetings ableiten
[ ] Ergebnisse dokumentieren

Definition of Ready

[ ] User Story ist klein genug für Sprint
[ ] User Story ist für jeden Beteiligten klar verständlich
[ ] User Story Aufwand ist geschätzt
[ ] User Story hat Akzeptanzkriterien
[ ] User Story hat einen Mehrwert für das Produkt oder die Entwicklung
[ ] User Story Ursprung ist bekannt (Stakeholder)
[ ] User Story ist Release zugewiesen

Definition of Done

[ ] Alle Akzeptanzkriterien sind erfüllt
[ ] Die Ergebnisse der Recherche wurden von mindestens einer anderen Person gereviewt (oder in Paired Researching gearbeitet)
[ ] Dokumentation wurde, falls nötig, angelegt (Wiki)
[ ] Dokumentation des Vorgehens wurde angelegt (Zenhub Kommentar)
[ ] Research wurde, falls möglich, in UML Klassendiagrammen bzw. Komponentendiagrammen getestet
[ ] Die Realisierung der User Story wurde erfolgreich durch den Product Owner abgenommen

Hey team! Please add your planning poker estimate with Zenhub @DerKatsche @philgei @splican


text:
ENH: Environment Analysis - Time Zones

Pull request type
Please check the type of change your PR introduces:

[x] Code base additions (bugfix, features)
[ ] Code maintenance (refactoring, formatting, renaming, tests)
[ ] ReadMe, Docs and GitHub maintenance
[ ] Other (please describe):

Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:

Code base additions (for bug fixes / features):

[ ] Tests for the changes have been added
[ ] Docs have been reviewed and added / updated if needed
[x] Lint (black rocketpy) has passed locally and any fixes were made
[x] All tests (pytest --runslow) have passed locally

What is the current behavior?

Currently, every datetime used and printed/plotted by the EnvironmentAnalysis class is in UTC.
What is the new behavior?

Now, the user can specify which timezone he prefers to use. This can be specially useful to display results in a timezone which is easier to understand.
Does this introduce a breaking change?

[ ] Yes
[x] No

Here is a comparison between wind roses generated considering UTC (top figure) and local (UTC-6 in Spaceport America, bottom figure) time zones:

repo: Projeto-Jupiter/RocketPy


text:
Added a new standard report "Small Molecule Peak Boundaries" …

… for use in export of peak boundaries for small molecule documents, and updated the peak boundary import code to handle small molecule information.

It is a problem for testing which switches languages without restarting the
process, and so leaves static values unchanged. It is a classic mistake we
have had to fix often to maintain our ability to run multiple tests under
translated languages in the same test run.
On Fri, Mar 4, 2022 at 8:21 AM Brian Pratt @.***> wrote:

@.**** commented on this pull request.
In pwiz_tools/Skyline/Model/ImportPeakBoundaries.cs
https://github.com/ProteoWizard/pwiz/pull/2018#discussion_r819711826:

@@ -99,6 +99,16 @@ public enum Field { modified_peptide, filename, apex_time, start_time, end_time,
public static int[] REQUIRED_NO_CHROM { get { return REQUIRED_FIELDS.Take(2).ToArray(); }}

     // ReSharper disable LocalizableElement

   public static readonly string[] PEPTIDE_SYNONYMS = new[]

   {

       "PeptideModifiedSequence", "ModifiedSequence", "FullPeptideName", "EG.ModifiedSequence", ColumnCaptions.PeptideModifiedSequence, ColumnCaptions.ModifiedSequence

   };

   public static readonly string[] MOLECULE_SYNONYMS = new[]

I'm not sure that's a problem - don't we require a restart when user
changes the language setting? Here is is running japanese, in testrunner.exe
[image: image]
https://user-images.githubusercontent.com/1200761/156799984-8def2820-b492-4fa5-8923-81ae3926584f.png
—
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/2018#discussion_r819711826,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYBWUDIF2KGIOM6GFW37O3U6IZ75ANCNFSM5P3RSYRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because your review was requested.Message ID:
@.***>

Noted, thanks.

FWIW where I've bothered to think about L10N column headers, I've gone all in and made it recognize all supported languages so a en-US process can handle CSV output from a ja (etc) process. Arguably overkill here.

I think that is a good direction for us to be heading. Thanks, Brian. Last year, I also improved our transition list / assay library import to successfully recognize and import CSV files from any locale (comma separated or semi-colon separated) regardless of the current system locale. More agnosticism in recognizing the file formats users may provide us is a good thing.

Maybe it would be good to write a function "GetLocalizedColumnNames" which returns all of the localized forms of a particular column name:
        private static IEnumerable<string> GetLocalizedColumnNames(string invariantName)
        {
            return CultureUtil.AvailableDisplayLanguages()
                .Select(culture => ColumnCaptions.ResourceManager.GetString(invariantName, culture))
                .Prepend(invariantName);
        }

Then you could do:
                    var headers = new List<string>(
                        GetLocalizedColumnNames(nameof(ColumnCaptions.PeptideModifiedSequence))
                            .Concat(GetLocalizedColumnNames(ColumnCaptions.ModifiedSequence))
                            .Concat(new[] {"FullPeptideName", "EG.ModifiedSequence"})
                            .Distinct()
                    );

Probably is a bug. Looks like only MSAmanadaWrapper uses the disposable.
CallWithCulture looks cool. I just went looking because I figured we must
have implemented something for this. Apparently we have implemented 2 ways.
I prefer the one Nick suggests for your case. You probably ought to fix
Viki's as well.
On Fri, Mar 4, 2022 at 3:38 PM nickshulman @.***> wrote:

@.**** commented on this pull request.
In pwiz_tools/Skyline/Model/ImportPeakBoundaries.cs
https://github.com/ProteoWizard/pwiz/pull/2018#discussion_r819984748:

             {

               "Molecule", "MoleculeName", ColumnCaptions.Molecule, ColumnCaptions.MoleculeName

           };

               var headers = new List<string>()

               {

                   "Molecule", "MoleculeName"

               };

               // Also recognize column captions in all supported display languages

               var currentUICulture = Thread.CurrentThread.CurrentUICulture;

               foreach (var culture in CultureUtil.AvailableDisplayLanguages())

               {

                   Thread.CurrentThread.CurrentUICulture = culture;

I always use the method "LocalizationHelper.CallWithCulture" instead of
"CurrentCultureSetter".
—
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/2018#discussion_r819984748,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYBWUHNEHFHAIRK6LTQPEDU6KNIRANCNFSM5P3RSYRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because your review was requested.Message ID:
@.***>

You probably ought to fix Viki's as well.

OK, will do.

Maybe it would be good to write a function "GetLocalizedColumnNames" which returns all of the localized forms of a particular column name...

That's less code, which is usually a good thing, but I don't think it's nearly as readable as the current implementation.

I prefer the one Nick suggests for your case.

I dunno, the using thing is nice here because I'm not calling a function with a return value. It reads pretty cleanly.

Fine with me. Just trying to make sure we reuse code where appropriate.
On Fri, Mar 4, 2022 at 4:19 PM Brian Pratt @.***> wrote:

I prefer the one Nick suggests for your case.
I dunno, the using thing is nice here because I'm not calling a function
with a return value. It reads pretty cleanly.
—
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/2018#issuecomment-1059620365,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYBWUEDXG63SNWMOUO4CJ3U6KSB3ANCNFSM5P3RSYRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because your review was requested.Message ID:
@.***>

authors: brendanx67 bspratt nickshulman

repo: ProteoWizard/pwiz


text:
Add support for Enums #29

I like to use enums in Python so this seemed important to me, I added a few ways to use enums to the tests.
The only thing missing would be being able to use enums as keys for dicts that seemed a lot more complicated so I didn't implement this. Although right now I think only strings and ints can be used for that either way.
I was waiting in line for a coffee for like 30m so I hacked this together on my phone, I hope the tests actually pass 😅

Thanks for your contribution!
I'll look into getting CI to run on pull requests as well. You're the first, so this part of the infrastructure hadn't been tested before.
It's good to see elaborate test cases as well. One thing that seems to be missing from the tests though is checking the error handling. For example, does the library produce a useful error message if the JSON value isn't a string, or if it is a string but it doesn't exist as a member of the enum?
Should the mapping from JSON string to Python enum member be done case-sensitive or case-insensitive? From your test case, it seems you expect case-insensitive matching, but I don't see anything in the code that implements that.

Should the mapping from TOML string to Python enum member be done case-sensitive or case-insensitive? From your test case, it seems you expect case-insensitive matching, but I don't see anything in the code that implements that.

Actually, it seems you're trying to match enum members by their value ("red", 1) rather than by their name (RED, ONE).
I tend to think of the names as the interface of the enum and the value as something that is mainly used for debugging. In that perspective, it would be better to match on the names instead of values. But I don't know whether everyone uses enums in Python like that.
When enum.auto() is used, the value does not have any meaning, so we should be matching those on name. However, I don't think there is any way to determine whether auto() was used through introspection of the Enum subtype. Therefore I think we have to support mapping by name in any case.
Then the question remains whether we also want to support mapping by value. I'm leaning towards "no", to keep things simple. But if there is a compelling use case that can't be handled with mapping by name, I can be persuaded otherwise.

Thanks for the review! I'll look into the requested changes later or tomorrow!

Then the question remains whether we also want to support mapping by value. I'm leaning towards "no", to keep things simple. But if there is a compelling use case that can't be handled with mapping by name, I can be persuaded otherwise.

Mapping by name you mean to always expose the key as a string inside the TOML?
One use case I often face and the primary reason why I wanted enum support in the first place is a toml where you have a pre defined set of values (could probably also be solved with typing.Literal) aka
# this only accepts pre defined values
# I am only consuming this (or maybe also updating) but this is defined by a different app
state = 3
# same concept
mode = "install"

In this case having dataclass binder use values like
state = "OFF"
mode = "INSTALL"

Is not helping me at least. The structure/values of this toml are pre defined I merely don't want to handle strings or ints on my end.
If I am both consumer and producer of the TOML I am also not sure if using the enum key names is useful because if I'd want that I could just name them this way in my enum values IMHO

Then the question remains whether we also want to support mapping by value. I'm leaning towards "no", to keep things simple. But if there is a compelling use case that can't be handled with mapping by name, I can be persuaded otherwise.

Mapping by name you mean to always expose the key as a string inside the TOML?

Yes. Let's modify the color enum from the unit test to make the name and value more distinct:
class Color(Enum):
    RED = "#f00"
    GREEN = "#0f0"
    BLUE = "#00f"

In this case, mapping by name would mean mapping the TOML string "RED" (or also "red" if we map case-insensitive) to Color.RED. Mapping by value would mean mapping the TOML string "#f00" to Color.RED.

One use case I often face and the primary reason why I wanted enum support in the first place is a toml where you have a pre defined set of values (could probably also be solved with typing.Literal) aka

Adding support for typing.Literal could be useful; I've filed that under #45.

# this only accepts pre defined values
# I am only consuming this (or maybe also updating) but this is defined by a different app
state = 3
# same concept
mode = "install"

In this case having dataclass binder use values like
state = "OFF"
mode = "INSTALL"

Is not helping me at least. The structure/values of this toml are pre defined I merely don't want to handle strings or ints on my end.

Ah, this is a use case I hadn't considered: if the TOML format is fixed and uses integers or strings that are not valid Python identifiers, then indeed matching by value is useful.
Maybe we could use IntEnum, IntFlag and StrEnum to force matching by value? That would be similar to how those enumeration subtypes operate within Python itself.
For example with this code:
from dataclasses import dataclass
from enum import Enum, IntEnum, auto

class Verbosity(Enum):
    QUIET = auto()
    NORMAL = auto()
    DETAILED = auto()

class IntVerbosity(IntEnum):
    QUIET = 0
    NORMAL = 1
    DETAILED = 2

@dataclass
class Settings:
    verbose_name: Verbosity
    verbose_value: IntVerbosity

The corresponding TOML would look like this:
verbose-name = 'quiet'
verbose-value = 2

Note that StrEnum was introduced in Python 3.11, so it won't be available in 3.10. However, if we support case-insensitive name mapping, that would probably be sufficient in the majority of cases. It is the integer case that benefits most from value mapping and IntEnum and IntFlag have been around since the enum module got added to the standard library.

If I am both consumer and producer of the TOML I am also not sure if using the enum key names is useful because if I'd want that I could just name them this way in my enum values IMHO

There are scenarios in which name matching is useful:

when the enum class already exists and is using auto() for its values
when the enum's values are of a type unsupported by TOML
when the enum's values have a meaning inside the program but shouldn't be considered part of its public interface, like the RED = "#f00" example, where the exact RGB value assigned might change in the future

Since both name matching and value matching are useful, the question becomes how to support both while keeping the behavior of dataclass-binder predictable to the user. Would using IntEnum, IntFlag and StrEnum to select value matching be a workable solution for you?

That would indeed work for me and I agree having the ability to use keys seems very useful! I'm just not sure yet as to what is more intuitive for the user because I don't think using the specialized sub classes to differentiate between keys/values is something I'd expect, they also have some other implications in their usage that might be unwanted. The values of auto are also highly predictable (counting upwards starting with 1 or in case of string enums just the key in lower case), probably wouldn't want to use this when you actively care about the values (consuming foreign toml).
I think we should decide for one of these two cases to be the default (key vs value) and have the other available through either a different base class or a decorator making this choice deliberate.
For example if values where default (names are just examples)
class Color(Enum, BindEnumKey):
    RED = "#f00"
    #....

# or

@bind_enum_key(case_sensisitive=True)
class Color(Enum):
    RED = "#f00"
    #....

I do like being able to configure the behavior via decorators.
We could also force users to annotate all enums and reject them if they haven't defined this behavior explicitly
@bind_enum(as="key", case_sensisitive=True)
class Color(Enum):
    RED = "#f00"
    #....

Downside is that this is special behavior for dataclass binder, although some way of annotating this seems sensible 🤔

That would indeed work for me and I agree having the ability to use keys seems very useful! I'm just not sure yet as to what is more intuitive for the user because I don't think using the specialized sub classes to differentiate between keys/values is something I'd expect, they also have some other implications in their usage that might be unwanted.

With IntEnum/IntFlag/StrEnum, the user communicates that the values are important. So I think matching by value when these types are used is likely to produce the behavior the user is looking for.

The values of auto are also highly predictable (counting upwards starting with 1 or in case of string enums just the key in lower case), probably wouldn't want to use this when you actively care about the values (consuming foreign toml).

Indeed: while the values are predictable, by using auto() the user expresses that they don't really care about the values and that the values might change in future versions of the software. So in those situations matching by name would make more sense.

I think we should decide for one of these two cases to be the default (key vs value) and have the other available through either a different base class or a decorator making this choice deliberate.
...
Downside is that this is special behavior for dataclass binder, although some way of annotating this seems sensible 🤔

So far I've managed to avoid introducing any new syntax for dataclasses in dataclass-binder. I'm not sure this is feasible forever, but I'd like to keep it to a minimum:

to reduce the amount of new syntax that people who write new dataclasses have to learn
to increase the chance of existing dataclasses working with dataclass-binder with no or minimal changes
to make the dataclasses easier to read by people who don't necessarily know all the details of the binding process
to have the option to support other dataclass-like solutions in the future (such as attrs)

In some cases the behavior comes naturally, such as dataclass fields without defaults being mandatory in TOML. However, in the case of selecting name versus value matching for enumerations, I don't think a very intuitive solution exists. I hope that "IntEnum/IntFlag/StrEnum for value matching" is at least intuitive enough that people will have an easier time remembering it after reading the docs.
I'm not certain that using conventions rather than explicit annotations is the right way to go, but it is consistent with the way the library has been designed so far, so I'd like to give it a try.

So far I've managed to avoid introducing any new syntax for dataclasses in dataclass-binder. I'm not sure this is feasible forever, but I'd like to keep it to a minimum:
* to reduce the amount of new syntax that people who write new dataclasses have to learn

* to increase the chance of existing dataclasses working with `dataclass-binder` with no or minimal changes

* to make the dataclasses easier to read by people who don't necessarily know all the details of the binding process

* to have the option to support other dataclass-like solutions in the future (such as `attrs`)

In some cases the behavior comes naturally, such as dataclass fields without defaults being mandatory in TOML. However, in the case of selecting name versus value matching for enumerations, I don't think a very intuitive solution exists. I hope that "IntEnum/IntFlag/StrEnum for value matching" is at least intuitive enough that people will have an easier time remembering it after reading the docs.
I'm not certain that using conventions rather than explicit annotations is the right way to go, but it is consistent with the way the library has been designed so far, so I'd like to give it a try.

I actually very much appreciate this.
I pushed the changes, StrEnum, IntEnum and IntFlag all inherit ReprEnum so this seemed like a good candidate

@mthuurne Any more changes you would like to see?

Sorry for the delay.

I pushed the changes, StrEnum, IntEnum and IntFlag all inherit ReprEnum so this seemed like a good candidate

ReprEnum was introduced in 3.11, while dataclass-binder supports 3.10 as well, so we need an alternative code path for 3.10. I created one in commit 5c32aa35079b53a938e541ff127039552d4e489c, maybe you could cherry-pick that?
I couldn't get CI to work on this PR, but it should now be enabled for future PRs. So I ran the tests locally and got one failing test case and two lines missing test coverage. I'll add comments on the specific lines.

Sorry for the delay, I was a bit busy.

Hey! Thanks for the review, I have added the requested changes :)

@mthuurne Is there a timeline when this PR can be merged? As far I can see, there will be no blockers curently?

authors: atomicptr mthuurne wyleung

repo: ProtixIT/dataclass-binder


text:
Hotfix - Do not display ad in inbox

Temporary fix for #209
Short description of what this resolves:
The inbox used to display a big ad on login.
Changes proposed in this pull request:
The ad is now hidden by default.

Test fail on some localization test:
Chrome Headless 80.0.3987.0 (Linux x86_64) i18n loader should load french i18n translations on a browser set to fr FAILED

However, it was already failing on 93d6a228a, so I'll assume that it's not my fault.

There appears to be no more checks on this pull request. Is there anything else that is required by the maintainers for this pull request to be merged?

authors: darigovresearch stefanrua

repo: ProtonMail/WebClient


text:
How do I play Erect songs

What is your question?
How do I play Erect songs

figured it out

repo: Psych-Slice/P-Slice


text:
respiArt ventilator project

A potential candidate to add - my project respiArt on github.
https://github.com/artur-iluk/respiArt
Prototype is working. in README ther is a  description and link to youtube movie.
Artur Iluk

I'm new on github, and I don't know exactly how is works.
Could you explain me, what does it mean what issue is closed? It was
mentioned, that new projects can be suggested by creating new issue.
Closing the issue means that project will not be included on the list? Why?
Best regards
Artur
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Wolny
od wirusów. www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
pon., 13 kwi 2020 o 00:40 Avinash Baskaran notifications@github.com
napisał(a):

Closed #76 https://github.com/PubInv/covid19-vent-list/issues/76.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PubInv/covid19-vent-list/issues/76#event-3225522390,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APECQTAVZ2KWJLUPFG6OAKTRMI7NTANCNFSM4MGN75NQ
.

Artur,
Thank you very much for reaching out to clarify! Your respiArt device was added to the list (currently #30): https://docs.google.com/spreadsheets/d/1inYw5H4RiL0AC_J9vPWzJxXCdlkMLPBRdPgEVKF8DZw/edit?ts=5e8d0ab8#gid=0
I was personally very impressed by its packaging, functionality and user interface. If you release any updates to your project, please add another "issue" requesting re-evaluation. Thanks again for your efforts and good luck.

An issue is closed when there is no more work to be done. In this case, it
was closed because we added it; in some cases it might be closed the issue
is not actionable.
On Mon, Apr 13, 2020 at 12:44 PM Avinash Baskaran notifications@github.com
wrote:

Artur,
Thank you very much for reaching out to clarify! Your respiArt device was
added to the list (currently #30
https://github.com/PubInv/covid19-vent-list/issues/30):
https://docs.google.com/spreadsheets/d/1inYw5H4RiL0AC_J9vPWzJxXCdlkMLPBRdPgEVKF8DZw/edit?ts=5e8d0ab8#gid=0
I was personally very impressed by its packaging, functionality and user
interface. If you release any updates to your project, please add another
"issue" requesting re-evaluation. Thanks again for your efforts and good
luck.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/PubInv/covid19-vent-list/issues/76#issuecomment-613009075,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABINEH2KIR2P6OIMVDJKCB3RMNFRTANCNFSM4MGN75NQ
.

--
Robert L. Read, PhD
Twitter: @RobertLeeRead @pubinvention
Public Invention: https://www.pubinv.org
Join Our Mailing list: pubinv@googlegroups.com
YouTube: https://www.youtube.com/channel/UCJQg_dkDY3KTP1ybugYwReg
Medium: https://medium.com/@RobertLeeRead

Thank you for explanation.
Two remarks:

You can put as a contact point my email.
There is some community support on Slack.com, but in polish language:
https://app.slack.com/client/T0105JVDQTZ/C0103A4DCBE
A few people is helping me in that project.

I will keep you informed.
Best regards
Artur
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Wolny
od wirusów. www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
pon., 13 kwi 2020 o 19:44 Avinash Baskaran notifications@github.com
napisał(a):

Artur,
Thank you very much for reaching out to clarify! Your respiArt device was
added to the list (currently #30
https://github.com/PubInv/covid19-vent-list/issues/30):
https://docs.google.com/spreadsheets/d/1inYw5H4RiL0AC_J9vPWzJxXCdlkMLPBRdPgEVKF8DZw/edit?ts=5e8d0ab8#gid=0
I was personally very impressed by its packaging, functionality and user
interface. If you release any updates to your project, please add another
"issue" requesting re-evaluation. Thanks again for your efforts and good
luck.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PubInv/covid19-vent-list/issues/76#issuecomment-613009075,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APECQTCDUSWLVPYU63OSAS3RMNFRRANCNFSM4MGN75NQ
.

If you can give us an English title for your community (the slack team), we
will add that to our page (not the spreadsheet) under the "Communities"
section and note that it is Polish-language oriented.
On Mon, Apr 13, 2020 at 2:08 PM Artur Iluk notifications@github.com wrote:

Thank you for explanation.
Two remarks:

You can put as a contact point my email.
There is some community support on Slack.com, but in polish language:
https://app.slack.com/client/T0105JVDQTZ/C0103A4DCBE
A few people is helping me in that project.

I will keep you informed.
Best regards
Artur
<
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail

Wolny
od wirusów. www.avast.com
<
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail

<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
pon., 13 kwi 2020 o 19:44 Avinash Baskaran notifications@github.com
napisał(a):

Artur,
Thank you very much for reaching out to clarify! Your respiArt device was
added to the list (currently #30
https://github.com/PubInv/covid19-vent-list/issues/30):

https://docs.google.com/spreadsheets/d/1inYw5H4RiL0AC_J9vPWzJxXCdlkMLPBRdPgEVKF8DZw/edit?ts=5e8d0ab8#gid=0

I was personally very impressed by its packaging, functionality and user
interface. If you release any updates to your project, please add another
"issue" requesting re-evaluation. Thanks again for your efforts and good
luck.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/PubInv/covid19-vent-list/issues/76#issuecomment-613009075
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/APECQTCDUSWLVPYU63OSAS3RMNFRRANCNFSM4MGN75NQ
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/PubInv/covid19-vent-list/issues/76#issuecomment-613046842,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABINEH55UIFF53CHO7L2QTLRMNPKRANCNFSM4MGN75NQ
.

--
Robert L. Read, PhD
Twitter: @RobertLeeRead @pubinvention
Public Invention: https://www.pubinv.org
Join Our Mailing list: pubinv@googlegroups.com
YouTube: https://www.youtube.com/channel/UCJQg_dkDY3KTP1ybugYwReg
Medium: https://medium.com/@RobertLeeRead

authors: RobertLRead artur-iluk avinashbaskaran


text:
Make header check more robust

Issue:

If a user has any extra whitespace in their header value, opening the file fails to map some headers.

Fix:

Perform header comparison by removing all whitespace, lowering each string, and then checking the equality.
This provides a more robust way to map columns from a user inputted file.

@hellothisisMatt I approved this, then had to revert it on further testing.
On the surface this seems to avoid miss-match on fields with extra spaces in labels.  But the algorithm for aligning data columns to template still must run - and it currently depends on exact string match.  See main.js mapMatrixToGrid function unmappedHeaders code.  So that code needs to be changed too, otherwise each space-mismatched header column of info won't be uploaded. I think that is the only other point in code that pays attention to uploaded file's exact field names, but I'm not sure.
A less UI friendly approach would be just to issue a report/warning of fields that differ only by spaces, and have user manually change this in file before reuploading.  But this isn't as nice as changing mapMatrixToGrid().

Hey @ddooley, thanks for the reply. I can have a look at making unmappedHeaders required changes as well.

authors: ddooley hellothisisMatt


text:
Add wiki images

Overview
I need to add screenshots to the documentation in the wiki. This PR uploads the images I need for the Getting Started Gude.

Added images directly to wiki instead.

repo: PublicMapping/districtbuilder


text:
Add italian linguage

I've translated the English version of PufferPanel to Italian. I hope you appreciate it.

Thank you!

We're welcome.

authors: aadeg puffrfish

repo: PufferPanel/PufferPanel


text:
Correct formatting to send request to API

Pull Request Template
script name - check_weather
What have you Changed
Correct formatting to send request to API by updating the f-string storage
Issue no.(must) - #277
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me.
[x] One Change in one Pull Request
[x] My file is in proper folder
[x] I am following clean code and Documentation and my code is well linted with flake8.
[x] I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.
Join Us on Discord:- https://discord.gg/JfbK3bS
acknowledgement

[x] I have tested the script and distributing it under MIT license.

This PR addresses the issues in issue #277. Please review and accept.

repo: Py-Contributors/awesomeScripts


text:
Don't remove re-exported imports

mypy has the concept of "re-export"ing a module by importing it and giving it the same name in the as dotted name:
https://mypy.readthedocs.io/en/stable/config_file.html#confval-implicit_reexport
from whatever import thing as thing

thing may not be used, but it needs to stay, since it is being exported. (This is primarily to allow for moving a definition but maintaining backwards compatibility).
It'd be great if autoflake doesn't remove these.

I imagine we'd need to get this into pyflakes so pyflakes doesn't report the issue for us.
There's some history on why this isn't supported by pyflakes though: https://github.com/PyCQA/pyflakes/issues/474

Oh yeah whoops. I should've known better :facepalm:

authors: fsouza thejcannon

repo: PyCQA/autoflake


text:
Incompatibility with black

def x():
    """aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.

    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
    https://aaaaaaaaaa.aaaaaaa/aaaaaaaaaa/aaaaa/aaaaaaaa.aaaaaa?aaaaaa=aaaaaaaaa

    aaaa aaa aaa aaaaaaaaaaaaa aaaaaaaaa aaaaaaaa aaaaaaaaaaaa aaa aaa aaaaaaa aaaaa
    """

Docformatter and Black will infinitely reformat each other's work on this example. Docformatter will insert a whitespace-only line after the line starting with https://, and Black will remove it.
Note that I am using 99 line length for black and 99 summary and description wrap for Docformatter (with black mode)

Oops, this was with an old version, I think this has been fixed.

repo: PyCQA/docformatter


text:
Macro for importing python classes

If I understand correctly the exact layout is not required anymore for defining PyTypeInfo.
Would it be possible to have an import_class! macro similar to import_exception!?

Yes absolutely!
I hadn't really made much progress with this, however I started some time ago playing around with such a macro in https://github.com/davidhewitt/pyo3-pytypes
Perhaps you'd be interested in helping bring that library to a workable state?

authors: davidhewitt kszucs


text:
"Variant or associated item not found in Enum" when a variant is disabled through a feature

Bug Description
When using Cargo features to conditionally enable enum variants, #[pyclass] tries to wrap disabled variants, which causes the compilation to fail.
Steps to Reproduce
Try to compile this code without enabling optional_feature:
#[pyclass]
enum Enum {
    AlwaysAvailable,
    #[cfg (feature = "optional_feature")]
    OptionalVariant,
}

This fails with error:
error[E0599]: no variant or associated item named `OptionalVariant` found for enum `Enum` in the current scope
   --> src\lib.rs:5:5
    |
  2 |      enum Enum {
    |  ____------------
    | |    |
    | |    variant or associated item `OptionalVariant` not found for this enum
  3 | |       AlwaysAvailable,
  4 | |       #[cfg (feature = "optional_feature")]
  5 | |       OptionalVariant,
    | |      -^^^^^^^^^^^^^^^ variant or associated item not found in `Enum`
    | |______|
    |

For more information about this error, try `rustc --explain E0599`.

(the code works fine when optional_feature is enabled)
Backtrace
No response
Your operating system and version
Windows 10 & ArchLinux
Your Python version (python --version)
Python 3.11.7
Your Rust version (rustc --version)
rustc 1.80.0 (051478957 2024-07-21)
Your PyO3 version
0.20.3
How did you install python? Did you use a virtualenv?
Installer + virtualenv
Additional Info
No response

Thanks for the report - looks like we're missing handling for #[cfg] inside our enum code. There are other places in the proc-macros where we handle cfgs, so it should be possible to do similar here. PR welcome!

Hi, I'm a long time fan of PyO3 and I'm interested about learning some more about how it works. I've come up with a fix for this bug in the case of simple enums: https://github.com/PyO3/pyo3/compare/main...jeff-k:pyo3:enum-feature-variants
I see in the pyimpl.rs and module.rs modules that the solution is to propagate the cfg attributes to the generated code, so that's what I've done.
Here's a test case that could go in tests/test_field_cfg.rs:
#[pyclass(eq, eq_int)]
#[derive(PartialEq)]
enum CfgSimpleEnum {
    #[cfg(any())]
    pub DisabledVariant,
    #[cfg(not(any()))]
    pub EnabledVariant,
}

#[test]
fn test_cfg_simple_enum() {
    Python::with_gil(|py| {
        let simple = py.get_type::<CfgSimpleEnum>();
        pyo3::py_run!(py, simple, r#"
            assert hasattr(simple, "EnabledVariant")
            assert not hasattr(simple, "DisabledVariant")
        "#);
    })
}

This should fix this specific bug, but motivates a similar fix for complex enums. I'd be happy to be assigned this task.
Thanks for the amazing crate.

@jeff-k sounds perfect and thank you for both the appreciation and contribution. If you're willing to open a PR, I'll gladly review. 🙏

Fixed in #4509

authors: davidhewitt jeberger jeff-k


text:
missing FromPy impl for PyObject

Fails with following message:
error[E0277]: the trait bound `pyo3::object::PyObject: pyo3::conversion::FromPy<num_bigint::bigint::BigInt>` is not satisfied
 --> src/lib.rs:8:1
  |
8 | #[pymethods]
  | ^^^^^^^^^^^^ the trait `pyo3::conversion::FromPy<num_bigint::bigint::BigInt>` is not implemented for `pyo3::object::PyObject`
  |
  = help: the following implementations were found:
            <pyo3::object::PyObject as pyo3::conversion::FromPy<&'a T>>
            <pyo3::object::PyObject as pyo3::conversion::FromPy<()>>
            <pyo3::object::PyObject as pyo3::conversion::FromPy<bool>>
            <pyo3::object::PyObject as pyo3::conversion::FromPy<f32>>
          and 3 others
  = note: required because of the requirements on the impl of `pyo3::conversion::IntoPy<pyo3::object::PyObject>` for `num_bigint::bigint::BigInt`
  = note: required because of the requirements on the impl of `pyo3::derive_utils::IntoPyResult<num_bigint::bigint::BigInt>` for `num_bigint::bigint::BigInt`
  = note: required by `pyo3::derive_utils::IntoPyResult::into_py_result`

error: aborting due to previous error

🌍 Environment

Your operating system and version:
Ubuntu 18.04
Your python version:
cpython 3.6.8
How did you install python (e.g. apt or pyenv)? Did you use a virtualenv?:
apt + virtualenv
Your rust version (rustc --version):
rustc 1.40.0-nightly (032a53a06 2019-10-03)
Are you using the latest pyo3 version? Have you tried using latest master (replace version = "0.x.y" with git = "https://github.com/PyO3/pyo3")?
Using commit 89b7c7e3

💥 Reproducing
run cargo build with following files:
Cargo.toml:
[package]
name = "pyo3-bigint"
version = "0.1.0"
edition = "2018"
publish = false

[lib]
name = "pyo3_bigint"
crate-type = ["rlib", "cdylib"]

[dependencies]
num-bigint = "0.2"
pyo3 = { git = "https://github.com/PyO3/pyo3", features = ["extension-module", "num-bigint"] }

src/lib.rs:
use pyo3::prelude::*;
use num_bigint::BigInt;

#[pyclass(name=MyClass, module="pyo3_bigint")]
#[derive(Clone)]
struct MyClass {}

#[pymethods]
impl MyClass {
    #[staticmethod]
    fn f(v: BigInt) -> BigInt {
        v
    }
}

#[pymodule]
fn pyo3_bigint(_py: Python, m: &PyModule) -> PyResult<()> {
    m.add_class::<MyClass>()?;
    Ok(())
}

Implemented in #622

authors: kngwyu programmerjake


text:
Removes PyPSA-Eur as a Submodule

Changes proposed in this Pull Request

Remove PyPSA-EUR as a submodule in the workflow (copy_config, prepare_network)

Checklist

[x] I tested my contribution locally and it seems to work fine.
[x] Code and workflow changes are sufficiently documented.
[ ] Changed dependencies are added to envs/environment.yaml.
[ ] Changes in configuration options are added in all of config.default.yaml.
[ ] Changes in configuration options are also documented in doc/configtables/*.csv.

lgtm! It ran fine on my machine. You may want to delete the actual workflow/scripts/subworkflows/pypsa-eur folder as well? (I did my test run with it deleted)

oh, actually. I get this warning while building the docs? But we can sort that out afterwards as well, as im not sure it was actually caused by this PR?
WARNING: autodoc: failed to import module 'retrieve_eia_data'; the following exception was raised:
No module named 'retrieve_eia_data'

Opps okay I just merged

oh, actually. I get this warning while building the docs? But we can sort that out afterwards as well, as im not sure it was actually caused by this PR?
WARNING: autodoc: failed to import module 'retrieve_eia_data'; the following exception was raised:
No module named 'retrieve_eia_data'

I fixed this in the docs... looks like an old error from when we switched completely too gridemissions. Will PR with my docs update

repo: PyPSA/pypsa-usa