text:
llvmPackages_git: remove

There are no maintainers for this as shown by it still being at llvm 15 and it's unnecessary work to apply all changes to it.
It has not been a git version for a long time and often lags behind the latest stable llvm
Here are all the differences between the current base(15) of _git and 15 https://gist.github.com/Artturin/c39265ecaeea523cd7224fc7b7632371
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

I went through all the diffs and there are no changes missing for 15, only changes missing from _git

llvmPackages_git  was added following this discussion https://github.com/NixOS/nixpkgs/issues/114828

Probably shouldn't kill llvmPackages_git. Since LLVM 17, I've been using it as a template for the next LLVM version. Once 18 is merged, I plan on trying to keep llvmPackages_git more up to date and I even am aiming to make everything common.

authors: Artturin RossComputerGuy


text:
compass: use bundlerEnv

Description of changes

Closes #201322
Things done

Using bundlerEnv and adapting the Gemfile to make it work.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 272045 run on x86_64-linux 1

1 package built:

compass

Runs fine, lgtm

source: gharchive/pull-request

authors: WolfangAukang pbsds

repo: NixOS/nixpkgs

license: MIT

license_type: permissive

license_source: github-api


text:
libxml2: 2.11.5 → 2.12.3

Description of changes
https://discourse.gnome.org/t/libxml2-2-12-3-released/18513
https://discourse.gnome.org/t/libxml2-2-12-2-released/18363
https://discourse.gnome.org/t/libxml2-2-12-1-released/18159
https://discourse.gnome.org/t/libxml2-2-12-0-released/18063
https://gitlab.gnome.org/GNOME/libxml2/-/compare/v2.11.5...v2.12.3

Changes in includes in public headers.
Python 3.12 support.
Lot of cleanups.

Supersedes: https://github.com/NixOS/nixpkgs/pull/269060
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Yeah, looks like with 2.12.3, the patches from #269060 are no longer necessary. (Built gnome-builder and inkscape successfully.)

I'm not sure but I think it broke at least apacheHttpd and inkscape:
apache-httpd> mod_xml2enc.c: In function 'sniff_encoding':
apache-httpd> mod_xml2enc.c:212:53: error: unknown type name 'xmlChar'
apache-httpd>   212 |         ctx->xml2enc = xmlDetectCharEncoding((const xmlChar*)ctx->buf,
apache-httpd>       |                                                     ^~~~~~~

inkscape> /build/inkscape-1.3.2_2023-11-25_091e20ef0f/src/object/uri.cpp: In constructor 'Inkscape::URI::URI(const gchar*, const char*)':
inkscape> /build/inkscape-1.3.2_2023-11-25_091e20ef0f/src/object/uri.cpp:86:9: error: 'xmlFree' was not declared in this scope; did you mean 'xmlFreeURI'?
inkscape>    86 |         xmlFree(full);
inkscape>       |         ^~~~~~~
inkscape>       |         xmlFreeURI

Weird. I built Inkscape on this branch successfully. In the worst case, we can backport the patches from https://github.com/NixOS/nixpkgs/pull/269060

Pushed the patches to staging-next.

apacheHttpd and inkscape build successfully on staging-next now. Thank you!

authors: jtojnar trofi


text:
python311Packages.whois: 0.99.27 -> 0.99.3

Diff: https://github.com/DannyCork/python-whois/compare/refs/tags/0.99.27...0.99.3
Changelog: https://github.com/DannyCork/python-whois/releases/tag/0.99.3
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 276881 run on x86_64-linux 1

6 packages built:

dnstwist
dnstwist.dist
python310Packages.whois
python310Packages.whois.dist
python311Packages.whois
python311Packages.whois.dist


text:
fastnlo-toolkit,python311Packages.fastnlo-toolkit: rename from fastnl…

…o_toolkit
Description of changes
part of #245383
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 278569 run on x86_64-linux 1

3 packages built:

fastnlo-toolkit
python310Packages.fastnlo-toolkit
python311Packages.fastnlo-toolkit


text:
portfolio: 0.67.1 -> 0.67.2

Description of changes
https://github.com/portfolio-performance/portfolio/compare/0.67.1...0.67.2
Tested my default porfolio checks, those looked fine to me.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 284619 run on x86_64-linux 1

1 package built:

portfolio


text:
aflplusplus: 4.09c -> 4.10c

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/AFLplusplus/AFLplusplus/releases.
meta.description for aflplusplus is: A heavily enhanced version of AFL, incorporating many features
and improvements from the community
meta.homepage for aflplusplus is: https://aflplus.plus
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.10c with grep in /nix/store/bp7r74f1aj2nr4izm2yd7gynf7ac1glx-aflplusplus-4.10c
found 4.10c in filename of file in /nix/store/bp7r74f1aj2nr4izm2yd7gynf7ac1glx-aflplusplus-4.10c

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
aflplusplus

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/bp7r74f1aj2nr4izm2yd7gynf7ac1glx-aflplusplus-4.10c \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A aflplusplus https://github.com/r-ryantm/nixpkgs/archive/bf06413ada397f596c092a88f1573fed0435f133.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/bf06413ada397f596c092a88f1573fed0435f133#aflplusplus

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bp7r74f1aj2nr4izm2yd7gynf7ac1glx-aflplusplus-4.10c
ls -la /nix/store/bp7r74f1aj2nr4izm2yd7gynf7ac1glx-aflplusplus-4.10c/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

aflplusplus

Maintainer pings
cc @risicle @Mindavi for testing.

Build logs look good, so I think this is quite a safe update. Probably worth considering updating the used LLVM version, but not a big priority now.

authors: Mindavi r-ryantm


text:
python311Packages.{httpx-auth, httpx-socks}: update

Description of changes
Update and fix build,
see https://hydra.nixos.org/build/249248396
https://hydra.nixos.org/build/249257941

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 288046 run on x86_64-linux 1

4 packages marked as broken and skipped:

python312Packages.httpx-auth
python312Packages.httpx-auth.dist
python312Packages.httpx-socks
python312Packages.httpx-socks.dist

6 packages built:

python311Packages.httpx-auth
python311Packages.httpx-auth.dist
python311Packages.httpx-socks
python311Packages.httpx-socks.dist
searxng
searxng.dist

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python311Packages.httpx-socks.dist:

got build log for '/nix/store/jcmk9nncxxmjrvkl8s6yxdjam431xp79-python3.11-httpx-socks-0.8.1-dist' from 'daemon'
When evaluating attribute ‘python311Packages.httpx-socks.dist’:
warning: unused-argument
Unused argument: curio.
Near pkgs/development/python-modules/httpx-socks/default.nix:4:3:
  |
4 | , curio
  |   ^

warning: unused-argument
Unused argument: sniffio.
Near pkgs/development/python-modules/httpx-socks/default.nix:16:3:
   |
16 | , sniffio
   |   ^

python311Packages.httpx-socks:

got build log for '/nix/store/jwb1d057xg0aa8x9c7lc6r6z4mxc8rbd-python3.11-httpx-socks-0.8.1' from 'daemon'
When evaluating attribute ‘python311Packages.httpx-socks’:
warning: unused-argument
Unused argument: curio.
Near pkgs/development/python-modules/httpx-socks/default.nix:4:3:
  |
4 | , curio
  |   ^

warning: unused-argument
Unused argument: sniffio.
Near pkgs/development/python-modules/httpx-socks/default.nix:16:3:
   |
16 | , sniffio
   |   ^


text:
rye: 0.22.0 -> 0.23.0

Description of changes
Changelog: https://github.com/mitsuhiko/rye/releases/tag/0.23.0

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 288646 run on x86_64-linux 1

1 package built:

rye

Result of nixpkgs-review pr 288646 run on aarch64-linux 1

1 package built:

rye

Result of nixpkgs-review pr 288646 run on aarch64-darwin 1

1 package built:

rye

Result of nixpkgs-review pr 288646 run on x86_64-darwin 1

1 package built:

rye


text:
Fix magic-wormhole

Motivation for this change
Fixes magic-wormhole by adding some required dependencies and making some necessary upgrades to some packages.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Tested the changes in this branch with nix-shell -p nox --run "nox-review wip --against HEAD~4", but it seems there are some build errors not related to this change, those packages were broken anyway. Not sure if there are some build errors actually caused by these changes.
How can there be so many broken packages? Shouldn't nox-review provide quite good protection against it? I guess packages can break if there happens some conflicting changes in separate branches and then they are both merged. But these failures seem like the package definition is broken itself.
@FRidh Btw, you had upgraded magic-wormhole package from 0.9.2 to 0.10.2. Did you actually manage to build it? It broke for me at least, but this should fix it.

Thanks for the feedback, I'll make those fixes.
About the package upgrades, I understand you, but I don't think that's a good approach. I believe it makes the total workload much greater for everybody. Now I have a problem that I can't test my changes to package X because some package Y is in a broken state. And when I try to fix Y, I can't do it because some other package Z is also broken. I think it would be much less work for everybody if the person writing the package upgrade also made sure it worked (to some extent at least). If someone doesn't have time for that, perhaps he/she can ask others. For instance, the actual package maintainer probably and if none of those, some other group of general package maintainers. Or if there's a lot packages to upgrade, perhaps some call for that: one issue listing everything that should be upgraded and then pinging everyone that's a potential volunteer and then the work can be shared in that issue. Or something better. Anyway, I deeply appreciate your significant efforts for nixpkgs.

I did the fixes you suggested.

Regarding the bunch of other broken Python packages. I can take a look at them at some point. But is there a way to know if someone else working on the same packages? Doesn't make sense for many people to work on fixing the same packages..

Unless people make a mention of it in a issue or PR, no. In any case, it doesn't happen often that people work on fixing the same (Python) packages.
Please, base your work on https://github.com/NixOS/nixpkgs/pull/28884 and open a PR to that PR. I intend to get everything in in one big merge and then merge it into 17.09 as well.

Nice, I'll do that. Thanks.

authors: FRidh jluttine


text:
wivrn: init at 0.11

Description of changes
Adds WiVRn
https://github.com/NixOS/nixpkgs/pull/278126#issuecomment-1975239007

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I am currently unable to get WiVRn/OpenComposite to work.
I've followed the guides here and here (while adapting them to fit my system) but games refuse to launch. If someone else is able to get results from it, let me know.

I did manage to get it to work so it appears that the module is functional. I will open the PR for review.

"WIVRN_USE_NVENC" is set to false until I can figure out this build error: /nix/store/p0p56gzz837fgmfd7lyisghcd7x2fdlc-binutils-2.40/bin/ld: cannot find -lnvidia-encode: No such file or directory

WIVRN_USE_NVENC is set to false until I can figure out this build error: /nix/store/p0p56gzz837fgmfd7lyisghcd7x2fdlc-binutils-2.40/bin/ld: cannot find -lnvidia-encode: No such file or directory

Looks like it comes with the nvidia driver, not sure why are they trying to link it directly. I wonder if nvidia distributes the "stub" libraries for nvenc
❯ ls /run/opengl-driver/lib/libnvidia-encode.so.550.54.14  -l
lrwxrwxrwx 4 root root 105 Jan  1  1970 /run/opengl-driver/lib/libnvidia-encode.so.550.54.14 -> /nix/store/b0cwmgcn3qiziwcqsfmf6frpfll8nx6l-nvidia-x11-550.54.14-6.1.80/lib/libnvidia-encode.so.550.54.14

Updated with requested changes

Oops, didn't get notifications for comments on those 2 open requests. Will work on those tomorrow.

hi, I think this should only be done after this v0.11 is merged, but here's v0.12

As we only use vendorMonado.src below, we should be able to get rid of this completely and only keep the pinned Monado source (the value of fetchFromGitLab) in a variable

We need wivrn and monado to implement find_package support...

I see things are in flux again so I'll hold off on the hw testing a bit longer (^:

Didn't know changing the name of the branch would just close the PR but I guess that makes sense. Anyways, I reopened the same PR here: https://github.com/NixOS/nixpkgs/pull/299830

authors: PassiveLemon SomeoneSerge ckiee


text:
firefly-iii: init at 6.1.13, nixos/firefly-iii: init

Description of changes
We already have a PR for firefly-iii which has not been merged in #184362. This is an attempt to push in the latest version of a package without using composer2nix and using the latest instructions from the docs.
From the github repo:

"Firefly III" is a (self-hosted) manager for your personal finances. It can help you keep track of your expenses and income, so you can spend less and save more. Firefly III supports the use of budgets, categories and tags. Using a bunch of external tools, you can import data. It also has many neat financial reports available.
Firefly III should give you insight into and control over your finances. Money should be useful, not scary. You should be able to see where it is going, to feel your expenses and to... wow, I'm going overboard with this aren't I?
But you get the idea: this is your money. These are your expenses. Stop them from controlling you. I built this tool because I started to dislike money. Having money, not having money, paying bills with money, you get the idea. But no more. I want to feel "safe", whatever my balance is. And I hope this tool can help you. I know it helps me.

I'd love to get some feedback for this because I've only tested this on my machines with sqlite and postgres. While the module should setup sqlite on its own, the postgres and mysql databases have to be created by the user. There is no web-server setup included in this module either.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I would suggest adding a nginx enable option for ease of use. This is the ngixn setup that works for me:
services.nginx = mkIf cfg.enableNginx {
      enable = true;
      recommendedTlsSettings = mkDefault true;
      recommendedOptimisation = mkDefault true;
      recommendedGzipSettings = mkDefault true;
      virtualHosts.${cfg.virtualHost} = {
        root = "${package}/public";
        locations = {
          "/" = {
            tryFiles = "$uri $uri/ /index.php?$query_string";
            index = "index.php";
            extraConfig = ''
              sendfile off;
            '';
          };
          "~ \.php$" = {
            extraConfig = ''
              include ${config.services.nginx.package}/conf/fastcgi_params ;
              fastcgi_param SCRIPT_FILENAME $request_filename;
              fastcgi_param modHeadersAvailable true; #Avoid sending the security headers twice
              fastcgi_pass unix:${config.services.phpfpm.pools.firefly-iii.socket};
            '';
          };
        };
      };

@PatrickDaG I didn't do this because I believe that these configurations can vary quite a bit between different deployments and because I'm not sure whether nixos wants to privilege nginx over, say, caddy or apache. I know that a lot of projects setup nginx but I've not found it to be universal across web-apps.
And, of course, that also brings up the question of whether we should also setup mysql or postgres if the user sets that in the config.
However, if you believe strongly about this I'll add an nginx option as well.

I think a baseline working setup for nginx is nice to have, even if people deploy differently as it can show which endpoints exist and which extra config you may need. Of course, it would be preferable to have that for all web servers, the same as it would be the best to have automatic setup for any database people may choose.
But for the sake of maintainability I would say it's enough if you setup the software stack you use and if someone wants a complete setup for e.g., Postgres and Apache, they can always post their own pull request.
If you have a very special nginx setup and thus no need for an option as part of the module I can also offer to help maintain that part.  I would use this option, making it easier to maintain, and then you don't have to maintain things you may not need.

@PatrickDaG Let me add the nginx option and push this again in a bit. I might also have a way of building the package from source (though it leaves a few translations out).

Well. Funny coincidence, I was also just trying to get a build from source to work: This seems to work but as you said I think some translations are missing as well as some javascript
Only in result_old/public/v1/js: app.js
Only in result_old/public/v1/js: app.js.LICENSE.txt
Only in result_old/public/v1/js: app_vue.js
Only in result_old/public/v1/js: app_vue.js.LICENSE.txt
Only in result_old/public/v1/js: create_transaction.js
Only in result_old/public/v1/js: create_transaction.js.LICENSE.txt
Only in result_old/public/v1/js: edit_transaction.js
Only in result_old/public/v1/js: edit_transaction.js.LICENSE.txt
Only in result_old/public/v1/js: profile.js
Only in result_old/public/v1/js: profile.js.LICENSE.txt
Only in result_old/public/v1/js/webhooks: create.js
Only in result_old/public/v1/js/webhooks: create.js.LICENSE.txt
Only in result_old/public/v1/js/webhooks: edit.js
Only in result_old/public/v1/js/webhooks: edit.js.LICENSE.txt
Only in result_old/public/v1/js/webhooks: index.js
Only in result_old/public/v1/js/webhooks: index.js.LICENSE.txt
Only in result_old/public/v1/js/webhooks: show.js
Only in result_old/public/v1/js/webhooks: show.js.LICENSE.txt

So far with my short tests it seems to work, but I'm fully confident.

So turns out that's only because those files are built when the develop branch gets built. It shouldn't be a problem until the next version (6.1) comes along.

@PatrickDaG I've made all the requisite changes to this, I think. Please do go over it and see if I've missed anything. If you'd like to be added as a maintainer please tell me, I shall add you and then mark this as ready for review.

@SuperSandro2000 I think I'm satisfied with this at my end. Would appreciate a once over and maybe some more testing.

@drupol Is there anything else I need to do here before this is ready for a merge?

Hey @savyajha,
thank you, for your great work packing firelfy-iii for us! I already tried to set it up using your module and might provide some little feedback on this:
In the current implementation nix fails (even when bundled nginx is not used) without setting the parameter firefly-iii.virtualHost. Especially when using a reverse proxy, a default value of localhost just works fine in my setups.
… while evaluating the option `firefly.services.firefly-iii.virtualHost':
error: The option `firefly.services.firefly-iii.virtualHost' is used but not defined.

Also app.js got delivered without correct mime-type, so the web app is broken when the X-Content-Type-Options: nosniff header is set. I'm still working out what's causing it, maybe someone else will stumble across it.

@PatrickDaG Can you let me know what these options are? While I’ve been dogfooding this module, I might not have covered everything. I was also of the opinion that the defaults (set my the application itself) are sensible.
I will get the changes into a PR this weekend.

I think the mime-type mismatch is actually a 404 not found. In the old version of this package the app.js was not built correctly leading to nginx returning a 404 which has mime-type html resulting in the error you see. I've just tested the newest version, and it seems to be fixed.

I can confirm updating from 6.1.13 -> 6.1.15 fixes the app.js issue.

authors: PatrickDaG savyajha stackcoder


text:
changelog-d: fix build

Build failed with
Error: Setup: Encountered missing or private dependencies:
base >=4.11.1.0 && <4.12 || >=4.12.0.0 && <4.13 || >=4.13.0.0 && <4.14 ||
>=4.14.0.0 && <4.15 || >=4.16.1.0 && <4.17 || >=4.17.0.0 && <4.18

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Updating it also fixes the problem.
This works:
nix-shell ./maintainers/scripts/update.nix --argstr package changelog-d

so I wonder why it wasn't auto updated.
RFC 140 doesn't affect automatic updates, right? This update script does change a file outside the by-name directory.

No idea about that. In any case I think having doJailbreak is a good thing to have by default, it prevents it breaking potentially for every deep dependency update.

I suggest moving this override to pkgs/development/haskell/configuration-common.nix. Otherwise the Haskell package fails to build and our infrastructure apparently can't deal with broken non-hackage packages: https://github.com/NixOS/nixpkgs/pull/307204#discussion_r1601145335

authors: infinisil ncfavier roberth


text:
python3Packages.opnieuw: init at 3.0.0

Description of changes
Opnieuw is a Python retry library. This PR adds it to the Python package set.

GitHub repo: https://github.com/channable/opnieuw
Blog post introducing the lib

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@GrahamcOfBorg build python3Packages.opnieuw

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 303324

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.opnieuw
python311Packages.opnieuw.dist
python312Packages.opnieuw
python312Packages.opnieuw.dist

x86_64-darwin

:white_check_mark: 4 packages built:

python311Packages.opnieuw
python311Packages.opnieuw.dist
python312Packages.opnieuw
python312Packages.opnieuw.dist

aarch64-darwin

:white_check_mark: 4 packages built:

python311Packages.opnieuw
python311Packages.opnieuw.dist
python312Packages.opnieuw
python312Packages.opnieuw.dist

authors: Scrumplex arianvp duijf


text:
mydumper: 0.14.1-1 -> 0.16.7-5

Description of changes
changelog is here: https://github.com/mydumper/mydumper/releases
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.
... (I don't know what I'm doing! Any and all feedback is more than welcome). 🐶🧪🥼

since this PR: mydumper has updated again, but now its docs are in a submodule and I can't figure out how to build them

@adamdicarlo0 can you merge this or should it wait for @Izorkin ? 🙏

Error build:
error: builder for '/nix/store/xqx91k2hvv3nr99qz15g8c1j0923gcvf-source.drv' failed with exit code 1;
       last 18 log lines:
       >
       > trying https://github.com/mydumper/mydumper/archive/refs/tags/v0.16.3-6
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       >   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       > curl: (22) The requested URL returned error: 404
       >
       > trying .tar.gz
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       >   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: .tar.gz
       > Warning: Problem : timeout. Will retry in 1 seconds. 3 retries left.
       >   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: .tar.gz
       > Warning: Problem : timeout. Will retry in 2 seconds. 2 retries left.
       >   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: .tar.gz
       > Warning: Problem : timeout. Will retry in 4 seconds. 1 retries left.
       >   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: .tar.gz
       > error: cannot download source from any mirror
       For full logs, run 'nix log /nix/store/xqx91k2hvv3nr99qz15g8c1j0923gcvf-source.drv'.
error: 1 dependencies of derivation '/nix/store/1ll46j0ixhd3i4ckdpp11371bd1f5py6-mydumper-0.16.3-6.drv' failed to build

Draft patch:
diff --git a/pkgs/tools/backup/mydumper/default.nix b/pkgs/tools/backup/mydumper/default.nix
index 34c8da0117db..cac23e24d960 100644
--- a/pkgs/tools/backup/mydumper/default.nix
+++ b/pkgs/tools/backup/mydumper/default.nix
@@ -1,5 +1,6 @@
-{ lib, stdenv, fetchFromGitHub, cmake, pkg-config, sphinx, glib, pcre
+{ lib, stdenv, fetchFromGitHub, cmake, pkg-config, sphinx, glib, pcre, pcre2
 , libmysqlclient, libressl, zlib, zstd, nix-update-script, testers
+, util-linux, libselinux, libsepol
 , versionCheckHook, mydumper, }:

 stdenv.mkDerivation rec {
@@ -20,7 +21,7 @@ stdenv.mkDerivation rec {
   nativeInstallCheckInputs = [ versionCheckHook ];
   doInstallCheck = true;

-  buildInputs = [ glib pcre libmysqlclient libressl zlib zstd ];
+  buildInputs = [ glib pcre pcre2 libmysqlclient libressl zlib zstd util-linux libselinux libsepol ];

   cmakeFlags = [
     "-DCMAKE_SKIP_BUILD_RPATH=ON"

Some commits can be squashed into a single commit.
Is it possible to not use nixfmt yet (at your discretion)? The original variant formatting is more comfortable for me to read.

ok I did some un-formatting and squashing. Thanks for the feedback!

ok I did some un-formatting and squashing. Thanks for the feedback!

Commits d62d68a, 2d6d209, 7e2fd70 and cb0c0a6 can be squashed to 8bcee9c

@michaelglass I don't have write access, I'm just a rando who uses mydumper 😁  thank you @Izorkin for reviewing!

@Izorkin how's this?

I'm getting a build error again:
error: builder for '/nix/store/ryf4g236bpl9nxn8l0gnsnigwf45jkzf-mydumper-0.16.7-5.drv' failed with exit code 2;
       last 25 log lines:
       > [ 77%] Building C object CMakeFiles/myloader.dir/src/myloader_worker_schema.c.o
       > [ 79%] Building C object CMakeFiles/mydumper.dir/src/mydumper_arguments.c.o
       > [ 81%] Building HTML documentation with Sphinx
       > [ 83%] Building C object CMakeFiles/myloader.dir/src/myloader_worker_loader.c.o
       > [ 84%] Building C object CMakeFiles/mydumper.dir/src/common_options.c.o
       > [ 86%] Building C object CMakeFiles/mydumper.dir/src/mydumper_char_chunks.c.o
       > [ 88%] Building C object CMakeFiles/mydumper.dir/src/mydumper_integer_chunks.c.o
       > [ 90%] Building C object CMakeFiles/myloader.dir/src/myloader_worker_post.c.o
       > [ 92%] Building C object CMakeFiles/mydumper.dir/src/mydumper_partition_chunks.c.o
       > [ 94%] Building C object CMakeFiles/mydumper.dir/src/mydumper_file_handler.c.o
       > [ 96%] Linking C executable myloader
       > [ 96%] Built target myloader
       > /build/source/src/mydumper_write.c: In function 'write_result_into_file':
       > /build/source/src/mydumper_write.c:703:17: error: 'write_column_into_string' may be used uninitialized [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wmaybe-uninitialized-Werror=maybe-uninitialized8;;]
       >   703 |                 write_row_into_string(conn, dbt, row, fields, lengths, num_fields, escaped, statement_row, write_column_into_string);
       >       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       > /build/source/src/mydumper_write.c:637:10: note: 'write_column_into_string' was declared here
       >   637 |   void (*write_column_into_string)(MYSQL *, gchar **, MYSQL_FIELD , gulong ,GString *, GString *, struct function_pointer * );
       >       |          ^~~~~~~~~~~~~~~~~~~~~~~~
       > cc1: all warnings being treated as errors
       > make[2]: *** [CMakeFiles/mydumper.dir/build.make:342: CMakeFiles/mydumper.dir/src/mydumper_write.c.o] Error 1
       > make[1]: *** [CMakeFiles/Makefile2:108: CMakeFiles/mydumper.dir/all] Error 2
       > make[1]: *** Waiting for unfinished jobs....
       > [ 96%] Built target doc_html
       > make: *** [Makefile:136: all] Error 2
       For full logs, run 'nix log /nix/store/ryf4g236bpl9nxn8l0gnsnigwf45jkzf-mydumper-0.16.7-5.drv'.

whoops didn't check against linux this time. Now it looks like it works (and one of the old CFLAGS doesn't appear to be necessary anymore)

@Izorkin bumped to the newest version again, fixed docs, (and this time I tested against linux 🙈)

is ofborg stuck? should I nudge it with git commit --amend --no-edit ?

I guess this is a bigger ofborg issue. I think this has accurate data https://nix.ci/stats.php and it looks like aarch64-darwin is backed up and maybe stuck. @Izorkin do you have guidance as whether I should wait or mark the aarch64-darwin build as broken?

There is a possibility that it may work on aarch64-darwin architecture. But I can't check it.

it certainly builds on aarch64-darwin (on my own machine). I'm just curious about getting this merged, because it looks like ofborg's aarch64-darwin infra is unhappy.

@NixOS/nixpkgs-merge-bot merge

authors: Izorkin adamdicarlo0 michaelglass


text:
python311Packages.pyhanko: 0.21.0 -> 0.25.1

Description of changes
Diff: https://github.com/MatthiasValvekens/pyHanko/compare/refs/tags/v0.21.0...v0.25.1
Changelog: https://github.com/MatthiasValvekens/pyHanko/blob/v0.25.1/docs/changelog.rst

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 328129 run on x86_64-linux 1

4 packages built:

python311Packages.pyhanko
python311Packages.pyhanko.dist
python311Packages.xhtml2pdf
python311Packages.xhtml2pdf.dist


text:
signal-desktop: 7.16.0 -> 7.17.0; signal-desktop-beta: 7.17.0-beta.1 ->7.18.0-beta.1

Description of changes
Closes #330655
https://github.com/signalapp/Signal-Desktop/releases/tag/v7.17.0
https://github.com/signalapp/Signal-Desktop/releases/tag/v7.18.0-beta.1

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 330661 run on x86_64-linux 1

3 packages built:

nixpkgs-manual
signal-desktop
signal-desktop-beta

authors: Gliczy equirosa


text:
gitlab-ci-local: 4.52.2 -> 4.53.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for gitlab-ci-local is: Run gitlab pipelines locally as shell executor or docker executor
meta.homepage for gitlab-ci-local is: https://github.com/firecow/gitlab-ci-local
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.53.0 with grep in /nix/store/rfcrdg8v8s0zwvfdcg0aidz7f5y8yn05-gitlab-ci-local-4.53.0
found 4.53.0 in filename of file in /nix/store/rfcrdg8v8s0zwvfdcg0aidz7f5y8yn05-gitlab-ci-local-4.53.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

gitlab-ci-local

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/rfcrdg8v8s0zwvfdcg0aidz7f5y8yn05-gitlab-ci-local-4.53.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gitlab-ci-local https://github.com/r-ryantm/nixpkgs/archive/417697da63f5a62c93fb7df5cf0143ca9aa2b5f4.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/417697da63f5a62c93fb7df5cf0143ca9aa2b5f4#gitlab-ci-local

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/rfcrdg8v8s0zwvfdcg0aidz7f5y8yn05-gitlab-ci-local-4.53.0
ls -la /nix/store/rfcrdg8v8s0zwvfdcg0aidz7f5y8yn05-gitlab-ci-local-4.53.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

gitlab-ci-local

Maintainer pings
cc @pineapplehunter for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge

authors: pineapplehunter r-ryantm


text:
haskellPackages.network: fix build on x86_64-darwin

I don’t know how this is able to build currently, but it requires at least the 10.15 SDK to build on x86_64-darwin due to requiring IP_RECVTOS.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Same as the other PRs re: nixfmt-check.


text:
heimdal: remove absolute path to pwd, replace patchPhase with postPa…

…tch to not break patches

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This PR may be useful, but it does not resolve the linked issue for me. I've injected this PR into my flake env here: 3b3bbae1e15d645a547a44c6d207938a98f51444 but still see the same build error.

Result of nixpkgs-review pr 347760 run on aarch64-darwin 1

5 packages failed to build:

heimdal
heimdal.dev
heimdal.info
heimdal.man
openvas-smb

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 347760

x86_64-linux

:x: 4 packages failed to build:

citrix_workspace (citrix_workspace_24_05_0)
citrix_workspace_23_09_0
citrix_workspace_23_11_0
citrix_workspace_24_02_0

:white_check_mark: 5 packages built:

heimdal
heimdal.dev
heimdal.info
heimdal.man
openvas-smb

aarch64-linux

:white_check_mark: 5 packages built:

heimdal
heimdal.dev
heimdal.info
heimdal.man
openvas-smb

x86_64-darwin

:x: 5 packages failed to build:

heimdal
heimdal.dev
heimdal.info
heimdal.man
openvas-smb

aarch64-darwin

:x: 5 packages failed to build:

heimdal
heimdal.dev
heimdal.info
heimdal.man
openvas-smb

@ofborg build heimdal.passthru.tests

Could you rename the commits to be prefixed with heimdal instead? kerberos could easily be misinterpreted as the MIT variant

Builds fine locally and only changing the commit can't drip of ofborg.
I am going ahead and merging this to fix the linux build. We fix the darwin build in the other PR.


text:
hackage: update all-cabal-hashes snapshot

I'm not sure how to test this but if somebody can point me to how, I'm happy to do so.
Motivation for this change
I'd like more up-to-date hackage packages available from callHackage
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

cc @peti

Thanks @peti
Please see also #34871

I've added a small script that will update the hash every couple of says in master. I haven't automated anything to that extend in any of the release branches, though.

authors: adisbladis gwils peti


text:
bitwarden-cli: 2024.9.0 -> 2024.10.0

Diff: https://github.com/bitwarden/clients/compare/cli-v2024.9.0...cli-v2024.10.0
Changelog: https://github.com/bitwarden/clients/releases/tag/cli-v2024.10.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@dotlambda Mind changing this PR to update bitwarden-cli to 2024.11.0 released November 14th?

Result of nixpkgs-review pr 350601 run on aarch64-darwin 1

1 package failed to build:

bitwarden-cli

See https://github.com/NixOS/nixpkgs/pull/340138 for the Darwin build.

The Darwin build fails with
npm error ld: warning: dylib (/nix/store/lzzd5jgybnpfj86xkcpnd54xgwc4m457-libcxx-16.0.6/lib/libc++.dylib) was built for newer macOS version (11.0) than being linked (10.7)
npm error ld: warning: object file (Release/obj.target/validation/src/validation.o) was built for newer macOS version (11.0) than being linked (10.7)
npm error fatal error: /nix/store/82ap3f2iqvb2ysjhqkd95k8h9r3y12f6-cctools-1010.6/bin/lipo: /private/tmp/nix-build-bitwarden-cli-2024.11.0.drv-0/validation-f7f5b1/validation-x86_64.out and /private/tmp/nix-build-bitwarden-cli-2024.11.0.drv-0/validation-38c91b/validation-arm64.out have the same architectures (arm64) and can't be in the same fat output file

authors: afh dotlambda


text:
dua: re-enable tests

Re-enable tests and disable expected-to-fail testcases
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 353146

x86_64-darwin

:white_check_mark: 1 package built:

dua

aarch64-darwin

:white_check_mark: 1 package built:

dua

Superseded by https://github.com/NixOS/nixpkgs/pull/353603


text:
simple64: add desktop file

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I wasn't sure how to deal with the icon field, your solution is indeed better.
Thanks for your insight!


text:
python3Packages.pyramid-multiauth: fix build

ZHF: https://github.com/NixOS/nixpkgs/issues/352882 Work on both python 311 and 312.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@NickCao pytest Work.

@ofborg build python311Packages.pyramid-multiauth python312Packages.pyramid-multiauth

@ofborg build python312Packages.pyramid-multiauth


text:
onthespot: 0.5 -> 1.0.2

Changes to a maintained fork of onthespot.
https://github.com/justin025/onthespot/releases/tag/v1.0.2
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Looks nice, thank you!
Would be nice if you could split up the commit into several ones like onthespot: modernize package, onthespot: add XYZ as maintainer etc

When trying to run the client I get
[nix-shell:~/.cache/nixpkgs-review/pr-356878]$ ./results/onthespot/bin/onthespot-cli
Traceback (most recent call last):
  File "/nix/store/4z48icnrwszkr2yrb3k6cgmakb3iivbd-onthespot-1.0.2/bin/..onthespot-cli-wrapped-wrapped", line 6, in <module>
    from onthespot.cli import main
  File "/nix/store/4z48icnrwszkr2yrb3k6cgmakb3iivbd-onthespot-1.0.2/lib/python3.12/site-packages/onthespot/__init__.py", line 7, in <module>
    from .gui.mainui import MainWindow
  File "/nix/store/4z48icnrwszkr2yrb3k6cgmakb3iivbd-onthespot-1.0.2/lib/python3.12/site-packages/onthespot/gui/mainui.py", line 9, in <module>
    from ..utils import is_latest_release, open_item
  File "/nix/store/4z48icnrwszkr2yrb3k6cgmakb3iivbd-onthespot-1.0.2/lib/python3.12/site-packages/onthespot/utils.py", line 8, in <module>
    from librespot.core import Session
  File "/nix/store/6xpywqzd46wcw111pk7642ixnfbx0jnk-python3.12-librespot-0.0.9/lib/python3.12/site-packages/librespot/__init__.py", line 3, in <module>
    from librespot.proto.Keyexchange_pb2 import BuildInfo, Platform, Product, ProductFlags
  File "/nix/store/6xpywqzd46wcw111pk7642ixnfbx0jnk-python3.12-librespot-0.0.9/lib/python3.12/site-packages/librespot/proto/Keyexchange_pb2.py", line 31, in <module>
    _descriptor.EnumValueDescriptor(
  File "/nix/store/qs1dq3148cidflfqkl7nlg8qij0m77ja-python3.12-protobuf-5.28.3/lib/python3.12/site-packages/google/protobuf/descriptor.py", line 920, in __new__
    _message.Message._CheckCalledFromGeneratedFile()
TypeError: Descriptors cannot be created directly.
If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0.
If you cannot immediately regenerate your protos, some other possible workarounds are:
 1. Downgrade the protobuf package to 3.20.x or lower.
 2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).

More information: https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates

That's weird, I did set that environment variable.


text:
gearlever: 2.1.0 -> 2.3.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for gearlever is: Manage AppImages with ease
meta.homepage for gearlever is: https://mijorus.it/projects/gearlever
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.3.1 with grep in /nix/store/lwhnnbqqhn4hz81162cdlq92vk66c5az-gearlever-2.3.1
found 2.3.1 in filename of file in /nix/store/lwhnnbqqhn4hz81162cdlq92vk66c5az-gearlever-2.3.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

gearlever

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lwhnnbqqhn4hz81162cdlq92vk66c5az-gearlever-2.3.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gearlever https://github.com/r-ryantm/nixpkgs/archive/de5fd8a3f6ea97f35c31697be8a1a43ceb40a42d.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/de5fd8a3f6ea97f35c31697be8a1a43ceb40a42d#gearlever

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lwhnnbqqhn4hz81162cdlq92vk66c5az-gearlever-2.3.1
ls -la /nix/store/lwhnnbqqhn4hz81162cdlq92vk66c5az-gearlever-2.3.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

gearlever

Maintainer pings
cc @Aleksanaa for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for gearlever is: Manage AppImages with ease
meta.homepage for gearlever is: https://mijorus.it/projects/gearlever
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.3.2 with grep in /nix/store/nmkmhvyw5g8fvvi381l1zpy8g26fkd8q-gearlever-2.3.2
found 2.3.2 in filename of file in /nix/store/nmkmhvyw5g8fvvi381l1zpy8g26fkd8q-gearlever-2.3.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

gearlever

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/nmkmhvyw5g8fvvi381l1zpy8g26fkd8q-gearlever-2.3.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gearlever https://github.com/r-ryantm/nixpkgs/archive/a245f4f94574a6c78ba8d244ef5145caf2e452a0.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/a245f4f94574a6c78ba8d244ef5145caf2e452a0#gearlever

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/nmkmhvyw5g8fvvi381l1zpy8g26fkd8q-gearlever-2.3.2
ls -la /nix/store/nmkmhvyw5g8fvvi381l1zpy8g26fkd8q-gearlever-2.3.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

gearlever

Maintainer pings
cc @Aleksanaa for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@ofborg build gearlever

authors: Aleksanaa r-ryantm


text:
Revert "workflows/eval: Add the eval summary as a comment"

This reverts commit 38003ce53b4815bb1bc0250c3fd8de0da741faf9.
I am already overwhelmed with github notifications and this makes the situation even worse.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Ideally it should only output one comment and then modify it continuously. The position it appears should be relatively high so will not be folded by GitHub.

Ideally it should only output one comment and then modify it continuously. The position it appears should be relatively high so will not be folded by GitHub.

It only updates the last comment already. Still when I open a pull request, I will now always get a notification even if no human has responded to my PR.

I will now always get a notification even if no human has responded to my PR.

Yeah. Annoying.
Is there any way to have the bot post the eval results into the PR description / body, maybe replacing a special placeholder in the template?

Don't think github actions have currently permissions to do that.

gh pr edit <NUMBER>  --body "BODY" should work?

I will now always get a notification even if no human has responded to my PR.

Yeah. Annoying.
Is there any way to have the bot post the eval results into the PR description / body, maybe replacing a special placeholder in the template?

Don't think github actions have currently permissions to do that.

gh pr edit <NUMBER> --body "BODY" should work?

Ok. Maybe you can try this in a follow up pull request.

I will now always get a notification even if no human has responded to my PR.

Yeah. Annoying.
Is there any way to have the bot post the eval results into the PR description / body, maybe replacing a special placeholder in the template?

It's possible https://github.com/NixOS/nixpkgs/commit/eff1eee5df763b8d61bcfb1212e1b88a50c42ca1
Demo https://github.com/azuwis/nixpkgs/pull/10

Are you still receiving notifications about those edits or do those happen "silently"?

No notifications.
For reference https://stackoverflow.com/questions/38986589/does-github-send-a-notification-when-an-issue-comment-is-edited

No, you do not get a notification if a comment, issue title, or description is edited or even deleted.

@mention should also get no notifications for edits, according to this:

Per my experiments, if edit a comment to add a @mention, the mentioned user will receive the notification, but only once, regardless of how many edits are done afterward and whether they are @mentioned or not.

Perhaps we can create a commit status instead, I think that's also what ofborg does: https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#create-a-commit-status

I've made a version that add the eval summary to the Things done lists of the PR template https://github.com/NixOS/nixpkgs/compare/master...azuwis:nixpkgs:push-rnzsmkkzkums, example:

25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.
Eval summary

package: added 0, removed 0, changed 61
rebuild: linux 0, darwin 61

Demo https://github.com/azuwis/nixpkgs/pull/15
I think it's pretty elegant, no notifications, occupy only a little space.
Before opening a PR, I'd like to know what you think.

@azuwis I'm not a huge fan, because at least in a lot of my PRs I completely remove the checkmarks and rewrite appropriate ones myself, and I don't really want CI to mess with that, especially when rebuild count is irrelevant anyways. Also it just seems conceptually wrong, the comment is user-written and not meant for CI output. I'm also concerned on what happens when a user updates the description around the same time as CI, that seems reconcilable, but that shouldn't even be a concern imo.

The data is already available in the summary page for the eval jobs, so arguably a commit status... would not be any more visible than that?

It takes two button presses to get to the summary page (the first one gets you to the details page, and then finding where the summary is is not obvious), while with a commit status it would be a single click that can lead to any page. And people are already used to that from ofborg.

Perhaps we can create a commit status instead, I think that's also what ofborg does: https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#create-a-commit-status

Good idea, implemented in https://github.com/NixOS/nixpkgs/pull/361973

authors: Aleksanaa Mic92 azuwis infinisil


text:
silx: 2.1.1 -> 2.1.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for silx is: Software to support data assessment, reduction and analysis at synchrotron radiation facilities
meta.homepage for silx is: https://github.com/silx-kit/silx
meta.changelog for silx is: https://github.com/silx-kit/silx/blob/main/CHANGELOG.rst
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.1.2 with grep in /nix/store/0f0ff1ig58m6li9nlrd4mkjw2g1xxgrj-silx-2.1.2
found 2.1.2 in filename of file in /nix/store/0f0ff1ig58m6li9nlrd4mkjw2g1xxgrj-silx-2.1.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

silx

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/0f0ff1ig58m6li9nlrd4mkjw2g1xxgrj-silx-2.1.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A silx https://github.com/r-ryantm/nixpkgs/archive/29ba792f88bcbb974b57cffd74f616583ffef981.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/29ba792f88bcbb974b57cffd74f616583ffef981#silx

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/0f0ff1ig58m6li9nlrd4mkjw2g1xxgrj-silx-2.1.2
ls -la /nix/store/0f0ff1ig58m6li9nlrd4mkjw2g1xxgrj-silx-2.1.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 2 packages built:

silx
silx.dist

Maintainer pings
cc @pmiddend for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge

authors: pmiddend r-ryantm


text:
heroku: 9.5.0 -> 10.0.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for heroku is: Everything you need to get started using Heroku
meta.homepage for heroku is: https://devcenter.heroku.com/articles/heroku-cli
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 10.0.0 with grep in /nix/store/7yx14jd1clxlpqa7jfnmc1jibf626var-heroku-10.0.0
found 10.0.0 in filename of file in /nix/store/7yx14jd1clxlpqa7jfnmc1jibf626var-heroku-10.0.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

heroku

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7yx14jd1clxlpqa7jfnmc1jibf626var-heroku-10.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A heroku https://github.com/r-ryantm/nixpkgs/archive/4d8e60341a4ce6ddd8ba396d4dbf8bb10e2b19db.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/4d8e60341a4ce6ddd8ba396d4dbf8bb10e2b19db#heroku

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7yx14jd1clxlpqa7jfnmc1jibf626var-heroku-10.0.0
ls -la /nix/store/7yx14jd1clxlpqa7jfnmc1jibf626var-heroku-10.0.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

heroku

Maintainer pings
cc @aflatter @mirdhyn for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 364283

aarch64-darwin

:white_check_mark: 1 package built:

heroku

authors: r-ryantm wegank


text:
rednotebook: 2.3 -> 2.4

Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:

built on NixOS
ran /nix/store/0z5hqf7lmzgynw5vgliy7848dr7p6fis-rednotebook-2.4/bin/rednotebook -h got 0 exit code
ran /nix/store/0z5hqf7lmzgynw5vgliy7848dr7p6fis-rednotebook-2.4/bin/rednotebook --help got 0 exit code
ran /nix/store/0z5hqf7lmzgynw5vgliy7848dr7p6fis-rednotebook-2.4/bin/rednotebook --version and found version 2.4
ran /nix/store/0z5hqf7lmzgynw5vgliy7848dr7p6fis-rednotebook-2.4/bin/rednotebook -h and found version 2.4
ran /nix/store/0z5hqf7lmzgynw5vgliy7848dr7p6fis-rednotebook-2.4/bin/rednotebook --help and found version 2.4
found 2.4 with grep in /nix/store/0z5hqf7lmzgynw5vgliy7848dr7p6fis-rednotebook-2.4
found 2.4 in filename of file in /nix/store/0z5hqf7lmzgynw5vgliy7848dr7p6fis-rednotebook-2.4

cc @orivej for review

Failure on x86_64-darwin (full log)
Attempted: rednotebook
Partial log (click to expand)
applying patch /nix/store/wq4j9cc5fsrg7fm5g2p0kk3wx65q01cm-PR-152650-2.patch
patching file Source/PlatformGTK.cmake
patching file Source/cmake/OptionsGTK.cmake
Hunk #1 succeeded at 434 (offset 10 lines).
patching file Tools/gtk/gtkdoc.py
Hunk #1 FAILED at 322.
1 out of 1 hunk FAILED -- saving rejects to file Tools/gtk/gtkdoc.py.rej
builder for '/nix/store/y69gmrqwlgljmsg6hihqckyn1ybqblvm-webkitgtk-2.18.6.drv' failed with exit code 1
cannot build derivation '/nix/store/rlpnsqqzyn3lx93gwsidvpj816gj6b0c-rednotebook-2.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/rlpnsqqzyn3lx93gwsidvpj816gj6b0c-rednotebook-2.4.drv' failed

Failure on x86_64-linux (full log)
Attempted: rednotebook
Partial log (click to expand)
make[1]: *** [Makefile:16339: all-recursive] Error 1
make[1]: Leaving directory '/build/NetworkManager-1.10.4'
make: *** [Makefile:6746: all] Error 2
builder for '/nix/store/w16a2sspzsknag3qpwprh7n8311lf1hg-network-manager-1.10.4.drv' failed with exit code 2
cannot build derivation '/nix/store/rndjdmf1gkyipxlfi7lywvybb2rzgnwl-libproxy-0.4.15.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hr9gqvvbicapypgad1fhk74jgpbma7ax-glib-networking-2.54.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/52qn8b742r9q2397yc66iwp1gswm2hi7-geoclue-2.4.7.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/anq1msg4fsimmbm3ykmbwx3y17wng0av-webkitgtk-2.18.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gxqn6xm0shsvpgbpqns1l5gvsdy7rc9a-rednotebook-2.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/gxqn6xm0shsvpgbpqns1l5gvsdy7rc9a-rednotebook-2.4.drv' failed

Failure on aarch64-linux (full log)
Attempted: rednotebook
Partial log (click to expand)
make[1]: *** [Makefile:16339: all-recursive] Error 1
make[1]: Leaving directory '/build/NetworkManager-1.10.4'
make: *** [Makefile:6746: all] Error 2
builder for '/nix/store/sjv378pq7z13gnzdacb28cyg7bg1c3m1-network-manager-1.10.4.drv' failed with exit code 2
cannot build derivation '/nix/store/hxr738cagz1c9vpvzrjl3m4cr43qp5sl-libproxy-0.4.15.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kmy2f4diqsfhhacmd349kck4p440p82g-glib-networking-2.54.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/b242mjxvm3dpgqmc5wapinqcwvbahwli-geoclue-2.4.7.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/2hj6ck3mv439xxki0grvnfxciv7489ng-webkitgtk-2.18.6.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qqdslp5j8iyfj21jdwhrm9zc7bbr9mkb-rednotebook-2.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/qqdslp5j8iyfj21jdwhrm9zc7bbr9mkb-rednotebook-2.4.drv' failed

Closing in favor of @r-ryantm doing these.

authors: GrahamcOfBorg ryantm


text:
backintime-qt4: package is broken

the install phase writes into /nix :
<snip>
install -d
/nix/store/1kc8xcni0wp4y35vafh03rdxvqkrsxvl-backintime-qt4-1.1.24/../etc/dbus-1/system.d
install --mode=644 net.launchpad.backintime.serviceHelper.conf
/nix/store/1kc8xcni0wp4y35vafh03rdxvqkrsxvl-backintime-qt4-1.1.24/../etc/dbus-1/system.d
<snap>

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Thanks


text:
getdns: 1.4.1 -> 1.4.2

Motivation for this change
Simple version bump to latest.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg biuld getdns

@GrahamcOfBorg  build getdns stubby

Success on x86_64-darwin (full log)
Attempted: getdns, stubby
Partial log (click to expand)
make[1]: Leaving directory '/private/tmp/nix-build-stubby-0.2.3.drv-0/source'
post-installation fixup
gzipping man pages under /nix/store/gjlbnydzm0lg90740927izbw90nnahlr-stubby-0.2.3/share/man/
strip is /nix/store/yyak5sjv68n9vdgnkd2cb5djk1l9sqj5-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/gjlbnydzm0lg90740927izbw90nnahlr-stubby-0.2.3/bin  /nix/store/gjlbnydzm0lg90740927izbw90nnahlr-stubby-0.2.3/sbin
patching script interpreter paths in /nix/store/gjlbnydzm0lg90740927izbw90nnahlr-stubby-0.2.3
/nix/store/gjlbnydzm0lg90740927izbw90nnahlr-stubby-0.2.3/sbin/stubby-setdns-macos.sh: interpreter directive changed from "/bin/bash" to "/nix/store/9gghkkqhn6v7dvpf2319qvrxkkw03vwr-bash-4.4-p19/bin/bash"
moving /nix/store/gjlbnydzm0lg90740927izbw90nnahlr-stubby-0.2.3/sbin/* to /nix/store/gjlbnydzm0lg90740927izbw90nnahlr-stubby-0.2.3/bin
/nix/store/35bjz5vfdjjds3sgkxxppmy7vc67i4l4-getdns-1.4.2
/nix/store/gjlbnydzm0lg90740927izbw90nnahlr-stubby-0.2.3

Success on aarch64-linux (full log)
Attempted: getdns, stubby
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/p886bnj0xk86qpyg7ngll8yrgh8xnqvm-stubby-0.2.3
shrinking /nix/store/p886bnj0xk86qpyg7ngll8yrgh8xnqvm-stubby-0.2.3/bin/stubby
gzipping man pages under /nix/store/p886bnj0xk86qpyg7ngll8yrgh8xnqvm-stubby-0.2.3/share/man/
strip is /nix/store/qg2agrqkf240s656d207zqhipl0bc2id-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p886bnj0xk86qpyg7ngll8yrgh8xnqvm-stubby-0.2.3/bin
patching script interpreter paths in /nix/store/p886bnj0xk86qpyg7ngll8yrgh8xnqvm-stubby-0.2.3
checking for references to /build in /nix/store/p886bnj0xk86qpyg7ngll8yrgh8xnqvm-stubby-0.2.3...
/nix/store/6b6bc49a66v0zc6qyvh53176i8k1v2a4-getdns-1.4.2
/nix/store/p886bnj0xk86qpyg7ngll8yrgh8xnqvm-stubby-0.2.3

Success on x86_64-linux (full log)
Attempted: getdns, stubby
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/07lng3yc1xpzhd29q70l8mg8l1wm7740-stubby-0.2.3
shrinking /nix/store/07lng3yc1xpzhd29q70l8mg8l1wm7740-stubby-0.2.3/bin/stubby
gzipping man pages under /nix/store/07lng3yc1xpzhd29q70l8mg8l1wm7740-stubby-0.2.3/share/man/
strip is /nix/store/21ymadblbmsbb2bk4q7gl4kjasp8zmgd-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/07lng3yc1xpzhd29q70l8mg8l1wm7740-stubby-0.2.3/bin
patching script interpreter paths in /nix/store/07lng3yc1xpzhd29q70l8mg8l1wm7740-stubby-0.2.3
checking for references to /build in /nix/store/07lng3yc1xpzhd29q70l8mg8l1wm7740-stubby-0.2.3...
/nix/store/5d36nc0b6dr4dykx3yjg6hd639l59mfl-getdns-1.4.2
/nix/store/07lng3yc1xpzhd29q70l8mg8l1wm7740-stubby-0.2.3

authors: GrahamcOfBorg leenaars xeji


text:
nixos/manual: document WPA2 enterprise configuration when declaratively configuring wifi networks

Motivation for this change
Today, when configuring a WPA2 network for my machine I was confused as I didn't find a reference in the manual. As such networks are often used it should be explicitly documented there I think.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@Mic92 I updated the change, fixed the typo and added a warning regarding the md4 hash.


text:
uhd: 3.12.0.0 -> 3.13.0.1

Motivation for this change
UHD fails auto update due to multiple sources
CC @bjornfor @fpletz @tomberek for testing
Changelog: https://github.com/EttusResearch/uhd/releases/
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build soapyuhd gnuradio-with-packages

@GrahamcOfBorg build soapyuhd

@GrahamcOfBorg build gnuradio-with-packages


text:
nodePackages: init openstf

Hello,
This commit introduce npm package for openstf.io.
Node v10 is not yet supported by STF, so it's defined only for node v8.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@matthew-piziak, is it still "change only json, do not regenerate *.nix", or I need to generate?

@jollheef That's right. @ryantm can you take a look? I can regenerate after it's merged.

@matthew-piziak 👍

Regenerating…

authors: jollheef matthew-piziak ryantm


text:
Improve ergonomics of clwrapper

Motivation for this change
lispPackages.clwrapper is a useful package for creating nix derivations that support a variety of lisp compilers.  Instead of running the compiler directly (and thus depending on a specific one), you use the common-lisp.sh script to actually invoke the compiler.  Neat!  Unfortunately, not all functionality is exposed conveniently.  For example, if you want to get your compiler to load a file, you need to jump through some hoops.  Right now, the easiest way to do that is to source cl-wrapper.sh and use the variables it sets.
Over in https://github.com/bradleyjensen/ql2nix, I to source cl-wrapper.sh during a buildPhase.  Unfortunately, cl-wrapper.sh always returns a non-zero exit code when NIX_LISP_SKIP_CODE is the empty string.  So, I had to hack around it by tossing a || true into my buildPhase.  This PR corrects that.
This PR also makes clwrapper work with CCL.  The common-lisp.sh script passes in the path to the ccl symlink rather than the path to the actual executable binary.  That causes cl-wrapper.sh to fail to recognize the implementation.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build lispPackages.iolib


text:
nixos/dconf: cleanup

Motivation for this change
I really just want the modules to set environment.variables.GIO_EXTRA_MODULES
so we can do away with it entirely one day :smile:
Perhaps I should do this for gvfs also.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Thanks @jtojnar, will have a PR for gvfs later today.


text:
mono-zeroconf: remove broken package

Motivation for this change
No dependencies within nixpkgs, and the package has not built successfully since 2018-04-29 according to Hydra[1]. Last upstream release was in 2009, and last upstream git commit in 2013.
[1] https://hydra.nixos.org/build/100604053
@NixOS/backports if you're interested for #68361
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

backported in ea623c7ef8ccc43b642cb7b81a5ce3379719c888

authors: delroth worldofpeace


text:
jalv: 1.6.2 -> 1.6.4

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/jalv/versions.
meta.description for jalv is: '"A simple but fully featured LV2 host for Jack"'.
meta.homepage for jalv is: '"http://drobilla.net/software/jalv"

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

directory tree listing: https://gist.github.com/18a63220f81d1d12c74eb36bb311ae8b

du listing: https://gist.github.com/89000a5779364486bc8531a7f1e5da81

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
jalv

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7cyhqsp5xbnm9fqmxkr5y7yvwnvby1dw-jalv-1.6.4 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A jalv https://github.com/r-ryantm/nixpkgs/archive/c5c0e475b208d9bd680abe33278cd09a84ad482d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7cyhqsp5xbnm9fqmxkr5y7yvwnvby1dw-jalv-1.6.4
ls -la /nix/store/7cyhqsp5xbnm9fqmxkr5y7yvwnvby1dw-jalv-1.6.4/bin

cc @cillianderoiste for testing.

Could you please have a look at this, @cillianderoiste?

@cillianderoiste I'm closing for now, but it'd most likely be great if the update could be submitted to nixpkgs :)

authors: Ekleog JohnAZoidberg r-ryantm