text:
python3Packages.responses: 0.13.4 -> 0.14.0

Motivation for this change
Update to latest upstream release 0.14.0
Change log: https://github.com/getsentry/responses/releases/tag/0.14.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 137356 run on x86_64-linux 1

26 packages marked as broken and skipped:

python38Packages.arviz
python38Packages.dask-xgboost
python38Packages.dm-sonnet
python38Packages.graph_nets
python38Packages.mlxtend
python38Packages.optuna
python38Packages.pygbm
python38Packages.pymc3
python38Packages.pywick
python38Packages.rl-coach
python38Packages.shap
python38Packages.sklearn-deap
python38Packages.skorch
python39Packages.arviz
python39Packages.dask-xgboost
python39Packages.dm-sonnet
python39Packages.graph_nets
python39Packages.mlxtend
python39Packages.optuna
python39Packages.pygbm
python39Packages.pymc3
python39Packages.pywick
python39Packages.rl-coach
python39Packages.shap
python39Packages.sklearn-deap
python39Packages.skorch

26 packages failed to build and already failed to build on hydra master:

paperless-ng: log was empty
python38Packages.baselines: log was empty
python38Packages.edward: log was empty
python38Packages.graspologic: log was empty
python38Packages.mask-rcnn: log was empty
python38Packages.pytorch-metric-learning: log was empty
python38Packages.scikit-optimize: log was empty
python38Packages.scikit-tda: log was empty
python38Packages.spacy: log was empty
python38Packages.spacy-transformers: log was empty
python38Packages.textacy: log was empty
python38Packages.tflearn: log was empty
python38Packages.umap-learn: log was empty
python39Packages.baselines: log was empty
python39Packages.edward: log was empty
python39Packages.graspologic: log was empty
python39Packages.mask-rcnn: log was empty
python39Packages.pytorch-metric-learning: log was empty
python39Packages.scikit-optimize: log was empty
python39Packages.scikit-tda: log was empty
python39Packages.spacy: log was empty
python39Packages.spacy-transformers: log was empty
python39Packages.textacy: log was empty
python39Packages.tflearn: log was empty
python39Packages.umap-learn: log was empty
tts: log was empty

1 package failed to build and are new build failure:

gpt2tc: log was empty

413 packages built:

apio
beancount (python39Packages.beancount)
beets
beetsExternalPlugins.alternatives
beetsExternalPlugins.copyartifacts
beetsExternalPlugins.extrafiles
brutalmaze
buildbot (python39Packages.buildbot)
buildbot-full (python39Packages.buildbot-full)
buildbot-ui (python39Packages.buildbot-ui)
corsair (python39Packages.corsair-scan)
deja-dup
detect-secrets (python39Packages.detect-secrets)
duplicity
duply
dvc-with-remotes
dyndnsc
eolie
errbot
fava
fdroidserver
gcalcli
git-annex-remote-googledrive
home-assistant
kitty
kmymoney
ledger2beancount
lexicon
lieer
matrix-dl
matrix-synapse
matrix-synapse-plugins.matrix-synapse-mjolnir-antispam
matrixcli
mopidy-spotify-tunigo
nixops
ntfy
opsdroid
privacyidea
python38Packages.PyRMVtransport
python38Packages.aiojobs
python38Packages.aiorun
python38Packages.amcrest
python38Packages.aria2p
python38Packages.asyncstdlib
python38Packages.asyncwhois
python38Packages.bash_kernel
python38Packages.batchgenerators
python38Packages.bayesian-optimization
python38Packages.beancount
python38Packages.beancount_docverif
python38Packages.buildbot
python38Packages.buildbot-full
python38Packages.buildbot-ui
python38Packages.celery
python38Packages.censys
python38Packages.certauth
python38Packages.chirpstack-api
python38Packages.cirq
python38Packages.cirq-google
python38Packages.cnvkit
python38Packages.confuse
python38Packages.corsair-scan
python38Packages.dask-glm
python38Packages.dask-ml
python38Packages.denonavr
python38Packages.dependency-injector
python38Packages.detect-secrets
python38Packages.digital-ocean
python38Packages.django-raster
python38Packages.djmail
python38Packages.drivelib
python38Packages.fastapi
python38Packages.fixerio
python38Packages.flit
python38Packages.flitBuildHook
python38Packages.flower
python38Packages.furo
python38Packages.gcsfs
python38Packages.gensim
python38Packages.globus-sdk
python38Packages.goobook
python38Packages.google-api-core
python38Packages.google-api-python-client
python38Packages.google-auth
python38Packages.google-auth-httplib2
python38Packages.google-auth-oauthlib
python38Packages.google-cloud-access-context-manager
python38Packages.google-cloud-appengine-logging
python38Packages.google-cloud-asset
python38Packages.google-cloud-automl
python38Packages.google-cloud-bigquery
python38Packages.google-cloud-bigquery-datatransfer
python38Packages.google-cloud-bigquery-logging
python38Packages.google-cloud-bigtable
python38Packages.google-cloud-container
python38Packages.google-cloud-core
python38Packages.google-cloud-datacatalog
python38Packages.google-cloud-dataproc
python38Packages.google-cloud-datastore
python38Packages.google-cloud-dlp
python38Packages.google-cloud-dns
python38Packages.google-cloud-error-reporting
python38Packages.google-cloud-firestore
python38Packages.google-cloud-iam
python38Packages.google-cloud-iam-logging
python38Packages.google-cloud-iot
python38Packages.google-cloud-kms
python38Packages.google-cloud-language
python38Packages.google-cloud-logging
python38Packages.google-cloud-monitoring
python38Packages.google-cloud-org-policy
python38Packages.google-cloud-os-config
python38Packages.google-cloud-pubsub
python38Packages.google-cloud-redis
python38Packages.google-cloud-resource-manager
python38Packages.google-cloud-runtimeconfig
python38Packages.google-cloud-secret-manager
python38Packages.google-cloud-securitycenter
python38Packages.google-cloud-spanner
python38Packages.google-cloud-speech
python38Packages.google-cloud-storage
python38Packages.google-cloud-tasks
python38Packages.google-cloud-testutils
python38Packages.google-cloud-texttospeech
python38Packages.google-cloud-trace
python38Packages.google-cloud-translate
python38Packages.google-cloud-videointelligence
python38Packages.google-cloud-vision
python38Packages.google-cloud-websecurityscanner
python38Packages.google-resumable-media
python38Packages.googlemaps
python38Packages.grip
python38Packages.gspread
python38Packages.habitipy
python38Packages.hdbscan
python38Packages.herepy
python38Packages.hmmlearn
python38Packages.hyppo
python38Packages.ibm-cloud-sdk-core
python38Packages.ibm-watson
python38Packages.ignite
python38Packages.imbalanced-learn
python38Packages.ipfshttpclient
python38Packages.json-logging
python38Packages.jupyterlab
python38Packages.jupyterlab_server
python38Packages.jupytext
python38Packages.kmapper
python38Packages.kubernetes
python38Packages.librosa
python38Packages.lightgbm
python38Packages.loca
python38Packages.mapbox
python38Packages.matrix-api-async
python38Packages.matrix-client
python38Packages.mlrose
python38Packages.moto
python38Packages.mwclient
python38Packages.nbconflux
python38Packages.nilearn
python38Packages.oauthenticator
python38Packages.openapi-core
python38Packages.openrouteservice
python38Packages.openshift
python38Packages.osmnx
python38Packages.pathy
python38Packages.persim
python38Packages.pot
python38Packages.ppscore
python38Packages.pydrive
python38Packages.pyfxa
python38Packages.pynndescent
python38Packages.pyro-ppl
python38Packages.pysaml2
python38Packages.pytenable
python38Packages.pytest-cid
python38Packages.python-forecastio
python38Packages.python-twitch-client
python38Packages.python-twitter
python38Packages.pytorch (python38Packages.pytorchWithoutCuda)
python38Packages.pytorch-lightning
python38Packages.pyvera
python38Packages.qiskit
python38Packages.qiskit-aqua
python38Packages.qiskit-ignis
python38Packages.responses
python38Packages.ripser
python38Packages.rising
python38Packages.sapi-python-client
python38Packages.scikit-bio
python38Packages.scikit-learn
python38Packages.scikit-survival
python38Packages.seqeval
python38Packages.simple-salesforce
python38Packages.slack-sdk
python38Packages.slackclient
python38Packages.slicer
python38Packages.slowapi
python38Packages.smart-open
python38Packages.solo-python
python38Packages.sphinx-inline-tabs
python38Packages.surt
python38Packages.tensorboardx
python38Packages.test-tube
python38Packages.threadpoolctl
python38Packages.tldextract
python38Packages.torchgpipe
python38Packages.torchvision
python38Packages.tunigo
python38Packages.twitch-python
python38Packages.upcloud-api
python38Packages.vilfo-api-client
python38Packages.vowpalwabbit
python38Packages.weboob
python38Packages.woob
python38Packages.word2vec
python38Packages.xgboost
python38Packages.zulip
python39Packages.PyRMVtransport
python39Packages.aiojobs
python39Packages.aiorun
python39Packages.amcrest
python39Packages.aria2p
python39Packages.asyncstdlib
python39Packages.asyncwhois
python39Packages.bash_kernel
python39Packages.batchgenerators
python39Packages.bayesian-optimization
python39Packages.beancount_docverif
python39Packages.celery
python39Packages.censys
python39Packages.certauth
python39Packages.chirpstack-api
python39Packages.cirq
python39Packages.cirq-google
python39Packages.cnvkit
python39Packages.confuse
python39Packages.dask-glm
python39Packages.dask-ml
python39Packages.denonavr
python39Packages.dependency-injector
python39Packages.digital-ocean
python39Packages.django-raster
python39Packages.djmail
python39Packages.drivelib
python39Packages.fastapi
python39Packages.fixerio
python39Packages.flit
python39Packages.flitBuildHook
python39Packages.flower
python39Packages.furo
python39Packages.gcsfs
python39Packages.gensim
python39Packages.globus-sdk
python39Packages.goobook
python39Packages.google-api-core
python39Packages.google-api-python-client
python39Packages.google-auth
python39Packages.google-auth-httplib2
python39Packages.google-auth-oauthlib
python39Packages.google-cloud-access-context-manager
python39Packages.google-cloud-appengine-logging
python39Packages.google-cloud-asset
python39Packages.google-cloud-automl
python39Packages.google-cloud-bigquery
python39Packages.google-cloud-bigquery-datatransfer
python39Packages.google-cloud-bigquery-logging
python39Packages.google-cloud-bigtable
python39Packages.google-cloud-container
python39Packages.google-cloud-core
python39Packages.google-cloud-datacatalog
python39Packages.google-cloud-dataproc
python39Packages.google-cloud-datastore
python39Packages.google-cloud-dlp
python39Packages.google-cloud-dns
python39Packages.google-cloud-error-reporting
python39Packages.google-cloud-firestore
python39Packages.google-cloud-iam
python39Packages.google-cloud-iam-logging
python39Packages.google-cloud-iot
python39Packages.google-cloud-kms
python39Packages.google-cloud-language
python39Packages.google-cloud-logging
python39Packages.google-cloud-monitoring
python39Packages.google-cloud-org-policy
python39Packages.google-cloud-os-config
python39Packages.google-cloud-pubsub
python39Packages.google-cloud-redis
python39Packages.google-cloud-resource-manager
python39Packages.google-cloud-runtimeconfig
python39Packages.google-cloud-secret-manager
python39Packages.google-cloud-securitycenter
python39Packages.google-cloud-spanner
python39Packages.google-cloud-speech
python39Packages.google-cloud-storage
python39Packages.google-cloud-tasks
python39Packages.google-cloud-testutils
python39Packages.google-cloud-texttospeech
python39Packages.google-cloud-trace
python39Packages.google-cloud-translate
python39Packages.google-cloud-videointelligence
python39Packages.google-cloud-vision
python39Packages.google-cloud-websecurityscanner
python39Packages.google-resumable-media
python39Packages.googlemaps
python39Packages.grip
python39Packages.gspread
python39Packages.habitipy
python39Packages.hdbscan
python39Packages.herepy
python39Packages.hmmlearn
python39Packages.hyppo
python39Packages.ibm-cloud-sdk-core
python39Packages.ibm-watson
python39Packages.ignite
python39Packages.imbalanced-learn
python39Packages.ipfshttpclient
python39Packages.json-logging
python39Packages.jupyterlab
python39Packages.jupyterlab_server
python39Packages.jupytext
python39Packages.kmapper
python39Packages.kubernetes
python39Packages.librosa
python39Packages.lightgbm
python39Packages.loca
python39Packages.mapbox
python39Packages.matrix-api-async
python39Packages.matrix-client
python39Packages.mlrose
python39Packages.moto
python39Packages.mwclient
python39Packages.nbconflux
python39Packages.nilearn
python39Packages.oauthenticator
python39Packages.openapi-core
python39Packages.openrouteservice
python39Packages.openshift
python39Packages.osmnx
python39Packages.pathy
python39Packages.persim
python39Packages.pot
python39Packages.ppscore
python39Packages.pydrive
python39Packages.pyfxa
python39Packages.pynndescent
python39Packages.pyro-ppl
python39Packages.pysaml2
python39Packages.pytenable
python39Packages.pytest-cid
python39Packages.python-forecastio
python39Packages.python-twitch-client
python39Packages.python-twitter
python39Packages.pytorch (python39Packages.pytorchWithoutCuda)
python39Packages.pytorch-lightning
python39Packages.pyvera
python39Packages.qiskit
python39Packages.qiskit-aqua
python39Packages.qiskit-ignis
python39Packages.responses
python39Packages.ripser
python39Packages.rising
python39Packages.sapi-python-client
python39Packages.scikit-bio
python39Packages.scikit-learn
python39Packages.scikit-survival
python39Packages.seqeval
python39Packages.simple-salesforce
python39Packages.slack-sdk
python39Packages.slackclient
python39Packages.slicer
python39Packages.slowapi
python39Packages.smart-open
python39Packages.solo-python
python39Packages.sphinx-inline-tabs
python39Packages.surt
python39Packages.tensorboardx
python39Packages.test-tube
python39Packages.threadpoolctl
python39Packages.tldextract
python39Packages.torchgpipe
python39Packages.torchvision
python39Packages.tunigo
python39Packages.twitch-python
python39Packages.upcloud-api
python39Packages.vilfo-api-client
python39Packages.vowpalwabbit
python39Packages.weboob
python39Packages.woob
python39Packages.word2vec
python39Packages.xgboost
python39Packages.zulip
qutebrowser
s3ql
sewer
snakemake
sourcehut.buildsrht
sourcehut.coresrht
sourcehut.dispatchsrht
sourcehut.gitsrht
sourcehut.hgsrht
sourcehut.hubsrht
sourcehut.listssrht
sourcehut.mansrht
sourcehut.metasrht
sourcehut.pastesrht
sourcehut.todosrht
tebreak
theharvester
twitch-chat-downloader
urlwatch
wlc
zulip-term


text:
libquotient: 0.6.8 -> 0.6.9

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/quotient-im/libQuotient/releases.
meta.description for libquotient is: "A Qt5 library to write cross-platform clients for Matrix"
meta.homepage for libquotient is: "https://matrix.org/docs/projects/sdk/quotient"
meta.changelog for libquotient is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

Warning: no invocation of /nix/store/8wipf38fpr989miidly0hn63f94fj818-libquotient-0.6.9/bin/quotest had a zero exit code or showed the expected version

Warning: no invocation of /nix/store/8wipf38fpr989miidly0hn63f94fj818-libquotient-0.6.9/bin/.quotest-wrapped had a zero exit code or showed the expected version

0 of 2 passed binary check by having a zero exit code.

0 of 2 passed binary check by having the new version present in output.

found 0.6.9 with grep in /nix/store/8wipf38fpr989miidly0hn63f94fj818-libquotient-0.6.9

found 0.6.9 in filename of file in /nix/store/8wipf38fpr989miidly0hn63f94fj818-libquotient-0.6.9

directory tree listing: https://gist.github.com/ed2519cbde521982e6454dc3858f7956

du listing: https://gist.github.com/654eddaadb5a533c5c8e8ebf7dba0a39

Rebuild report (if merged into master) (click to expand)

545 total rebuild path(s)

172 package rebuild(s)

171 x86_64-linux rebuild(s)
143 i686-linux rebuild(s)
93 x86_64-darwin rebuild(s)
138 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
alembic
aliza
apacheHttpdPackages.mod_tile
apacheHttpdPackages_2_4.mod_tile
argocd
basex
bjumblr
blender
bluejeans-gui
breezy
bschaffl
cabal2nix
clair
clickshare-csc1
clmagma
cloudcompare
createrepo_c
darwin.trash
dash
dell-530cdn
deltachat-desktop
dep2nix
devpi-client
diffoscope
diffoscopeMinimal
dnsproxy
doodle
drawio
dsseries
dtrx
duckdb
ec2-utils
epkowa
epm
epson-201106w
epson-workforce-635-nx625-series
epson_201207w
esbuild
flatpak-builder
flyctl
gbenchmark
gdal
git-cliff
gitui
gmt
gnunet
gnunet-gtk
gplates
grass
gutenprintBin

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8wipf38fpr989miidly0hn63f94fj818-libquotient-0.6.9 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libquotient https://github.com/r-ryantm/nixpkgs/archive/ac70c0ba3aa1977b628a8fd289b1f9c2c0fca995.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8wipf38fpr989miidly0hn63f94fj818-libquotient-0.6.9
ls -la /nix/store/8wipf38fpr989miidly0hn63f94fj818-libquotient-0.6.9/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @colemickens for testing.

Again, https://github.com/ryantm/nixpkgs-update/issues/253.

Result of nixpkgs-review pr 137840 run on x86_64-linux 1

3 packages built:

libquotient
neochat
quaternion

source: gharchive/pull-request

repo: NixOS/nixpkgs

license: MIT

license_type: permissive

license_source: github-api


text:
dbeaver: 21.2.0 -> 21.2.2

Motivation for this change
Update to latest release https://dbeaver.io/2021/09/19/dbeaver-21-2-1/ and https://dbeaver.io/2021/10/03/dbeaver-21-2-2/.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Ci and nixpkgs-review fail
https://github.com/NixOS/nixpkgs/pull/138613/checks?check_run_id=3654848325

hmm strange, now i get "wNXpHSzFCo9QavbbyIj8Q/9IMxymG9A4dn3aZsyblYs="/12wmkg66dnkxfqwd06x63hrlizs3zj4cinznd988y2n55hfykmf0 as the outputHash for the dependencies as well.
comparing the "old" and "new" maven-deps output: diff.txt

Maven is not deterministic hence why we need the FOD.


text:
r-documentation: discuss hydra builds

Motivation for this change
The Hydra build of R packages is extremely useful for finding broken packages.
Currently it is only mentioned in some PRs and issues.
This PR puts the hydra build result URL into the language docs.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

So there are three tiers of packages:

Core packages: we shouldn't merge into master if these are not building
Easy fix packages: packages that just require a few lines in default.nix, we should be aiming to fix these before merging into master, but in a pinch they can be marked broken, unlike core packages.
Hard fix packages: R_cache, and packages depending on it, needed a bit of thought and investigation to get them working. These packages can be marked as broken, and fixed later.

Deciding what counts as a core package is another question. Certainly, packages we use from Nix to maintain R are candidates. Hub Packages could be too. We could look at CRAN downloads to find popular packages, and support the top X.
I'm not sure exactly what we are trying to achieve with "core" packages though. The average R user should have all their packages working? We can update the package set with the current state in master? Personally, I would just fix any packages I use, and any packages that people asked for in a PR or issue, but just once. That will cover most packages.

Looking over this discussion, I see two factors: how hard it is to fix, and whether anyone needs it.
If someone, including ourselves, needs it, we will want to fix it even if it is hard.
If noone is asking for it, then only fix it if it is easy, otherwise mark it as broken.

If noone is asking for it, then only fix it if it is easy, otherwise mark it as broken.

How would we collect those requests (and make sure they are not missed)?

The other option is to add some kind of email contact to the Nix R language documentation. I can't imagine any inexperienced nix user getting R packages to work without referring to it, or finding it if they really want R to work.

I'm not sure exactly what we are trying to achieve with "core" packages though. The average R user should have all their packages working? We can update the package set with the current state in master? Personally, I would just fix any packages I use, and any packages that people asked for in a PR or issue, but just once. That will cover the most popular packages without fixing everything.

Core packages wouldn't be useful until we're generating automatic update PRs, they would form one necessary checks. Apart from that the concept probably isn't that useful. With hydra giving us good visibility of the ecosystem we can now aim to keep the failure rate low (currently 94% building!) when we consider doing a manual merge.

How would we collect those requests (and make sure they are not missed)?

Github issues are probably the best way.

In nixpkgs, they are very easy to miss. Adding documentation to mention certain maintainers when opening an issue may help.

I should notice anything that mentions rPackages, but certainly pinging maintainers would be the most reliable way. We currently do not have an R team (https://github.com/NixOS/nixpkgs/blob/master/maintainers/team-list.nix) and if we were to document anything we should create one rather than mentioning specific individuals to make it easier to adjust in future.

The other option is to add some kind of email contact to the Nix R language documentation.

I don't think we should go down this path, the community is centered around github rather than email.

[...] In nixpkgs, they are very easy to miss.

Yes, totally agree; this is what prompted my question. Three more options I have been thinking about:

a 'permanent' GitHub issue the maintainers and interested users could subscribe to
currently, the 'Nix Data Science' Matrix channel (https://app.element.io/#/room/#datascience:nixos.org) is low-volume enough for things not to get lost. That could change in the future, of course (and that would even be great). BTW: Said channel might also be a good place to have discussions like this.
establish a specific GitHub issue-label for such requests and make sure everyone knows about it, including newbies

I was going to mention promoting the matrix rooms for support. https://matrix.to/#/#datascience:nixos.org is sufficiently on topic and as @phirsch says quite low traffic. If R conversation grows sufficiently another room could be created.

I've not worked on the maintainer & meta data aspects yet as I was expecting the BioC & R bumps, which happened the past week. The tree is looking pretty healthy on hydra so I don't see a reason not to merge into master soon. If you want to give it a quick test @PhDyellow @phirsch let me know and I'll hold off for a bit.
We should merge some documentation describing the r-updates branch soon though, there is some confusion as to where fixes should be merged (e.g., #144744).

Added maintainer tagging: https://github.com/NixOS/nixpkgs/commit/f5cac4067c1e53a70fa8975371ad7c10ecec3359
I'll look into creating an aggregate jobset for hydra consisting of maintained packages, so it's easy to see when they break. If you want to add yourself as a maintainer to any packages just make a PR :).

authors: PhDyellow jbedo phirsch


text:
pulseaudio nixos module: run as systemd user service instead

Things done:

[X] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
Built on platform(s)

[X] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Most of the desktop environments will spawn pulseaudio, but we can instead simply run it as a systemd service instead.
This patch also makes the system wide service run in foreground as recommended by upstream and allows it to use sd_notify to signal ready instead of reading a pid written to a file.
The user version has been tested with KDE and works fine there.
The system-wide version runs, but I haven't actually used it. Upstream does not recommend running in this mode.

Thanks

authors: joachifm peterhoeg


text:
macchina: 1.1.6 -> 5.0.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/Macchina-CLI/macchina/releases.
meta.description for macchina is: "A fast, minimal and customizable system information fetcher"
meta.homepage for macchina is: "https://github.com/Macchina-CLI/macchina"
meta.changelog for macchina is: "https://github.com/Macchina-CLI/macchina/releases/tag/v5.0.2"
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/nix/store/xpf6mrbfhyicad85hdffp7znfknmn61a-macchina-5.0.2/bin/macchina passed the binary check.
1 of 1 passed binary check by having a zero exit code.
1 of 1 passed binary check by having the new version present in output.
found 5.0.2 with grep in /nix/store/xpf6mrbfhyicad85hdffp7znfknmn61a-macchina-5.0.2
found 5.0.2 in filename of file in /nix/store/xpf6mrbfhyicad85hdffp7znfknmn61a-macchina-5.0.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
macchina

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/xpf6mrbfhyicad85hdffp7znfknmn61a-macchina-5.0.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A macchina https://github.com/r-ryantm/nixpkgs/archive/40cf9eae71bbc0a6200a149602cc44cd31c2185d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/xpf6mrbfhyicad85hdffp7znfknmn61a-macchina-5.0.2
ls -la /nix/store/xpf6mrbfhyicad85hdffp7znfknmn61a-macchina-5.0.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

macchina

Maintainer pings
cc @414owen for testing.

Result of nixpkgs-review pr 144443 run on x86_64-linux 1

1 package built:

macchina

authors: figsoda r-ryantm


text:
btcpayserver: 1.3.6 -> 1.3.7

Things done:

Tested with the nix-bitcoin VM test.

Notes for reviewers:
You can verify GPG signatures with refetch=1 pkgs/applications/blockchains/btcpayserver/update.sh.
cc @prusnak @nixbitcoin

@GrahamcOfBorg build btcpayserver

authors: erikarvstedt prusnak


text:
OpenSfM: init at 0.5.2

Motivation for this change
Adds OpenSfM - an opensource structure from motion (reconstruction of a sparse 3d point cloud from images, similar to nixpkgs#colmap) framework maintained by Mapillary
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/672

I've found this suffers from spurious segfaults when using HAHOG descriptors or when using multithreading or just randomly when computing depthmaps, so I'm converting this into a draft until I'm done with debugging

No more disabled tests, and no segfaults!
I've bumped this to the (unreleased) 0.5.2 because the last release appeared to have some cxx standard issues that are only pronounced when using the new ceres (std::integer_sequence<>...), hotfixing which would've left a bunch of runtime errors.
I think the derivation is ready to be merged. Now that everything works I would reach out the upstream developers: hopefully they'd be willing to cooperate and remove the need for all the patches I've introduced. If that works out, I'll open a follow-up PR to remove the ad hoc hacks and ensure integration with nixpkgs-update

One more thing, I've been checking shebangs manually as follows:
nix build .#python3Packages.opensfm
./result/bin/opensfm_run_all ${opensfm-src}/data/berlin # modifies data/berlin in-place

(there's been a lot of issues with shebangs)
How should I automate this sort of a test?

Checked this on darwin: it builds, but the tests crash:
 python3.8-OpenSfM> collecting ... objc[4817]: Class CaptureDelegate is implemented in both /nix/store/w9gqadll6frp6sw913hlq5r0cylhzrqm-opencv-4.5.2/lib/libopencv_videoio.4.5.dylib (0x108d92630) and /nix/store/iffy67h7fw84ba9n25nw68is7wzhc4nr-opencv-4.5.2/lib/libopencv_videoio.4.5.dylib (0x129ef9630). One of the two will be used. Which one is undefined.
...
python3.8-OpenSfM> [libprotobuf ERROR google/protobuf/descriptor_database.cc:641] File already exists in database: opencv-caffe.proto
python3.8-OpenSfM> [libprotobuf FATAL google/protobuf/descriptor.cc:1371] CHECK failed: GeneratedDatabase()->Add(encoded_file_descriptor, size):
python3.8-OpenSfM> libc++abi.dylib: terminating with uncaught exception of type google::protobuf::FatalException: CHECK failed: GeneratedDatabase()->Add(encoded_file_descriptor, size):
python3.8-OpenSfM> Fatal Python error: Aborted

Does anyone have an idea what's this about?
Full logs: https://github.com/SomeoneSerge/pkgs/runs/4880547540?check_suite_focus=true#step:6:2419

[x] darwin runtime errors were caused by having two builds of opencv in the closure - fixed
[x] some tests had to be disabled for darwin until https://github.com/mapillary/OpenSfM/issues/874 has been fixed

Actually, is it at all a good idea to have something as big and brittle as opencv4 in propagatedBuildInputs?

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 152957 run on x86_64-linux 1

2 packages built:

python310Packages.opensfm
python39Packages.opensfm


text:
qtwebkit: use python38 to build instead of python2

Motivation for this change
python38 appears to work just as well, so it seems better to use that rather
than python2.  This also resolves some build flakiness seen due to parallel
invocations of python2 that are fixed in python3.
Note that the scripts aren't compatible with python39 or later, some patching
would be required to resolve that.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build libsForQt512.qtwebkit

Thanks!

authors: gbpdt ttuegel veprbl


text:
linuxKernel.kernels.linux_5_16: 5.16.11 -> 5.16.12

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/linux/versions.
meta.description for linuxKernel.kernels.linux_5_16 is: "The Linux kernel (with patches: bridge-stp-helper, request-key-helper)"
meta.homepage for linuxKernel.kernels.linux_5_16 is: "https://www.kernel.org/"
meta.changelog for linuxKernel.kernels.linux_5_16 is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 5.16.12 with grep in /nix/store/2z9i2l2l70gk679wrf08ga7dv6gkybn1-linux-5.16.12

found 5.16.12 in filename of file in /nix/store/2z9i2l2l70gk679wrf08ga7dv6gkybn1-linux-5.16.12

Rebuild report (if merged into master) (click to expand)

404 total rebuild path(s)

404 package rebuild(s)

404 x86_64-linux rebuild(s)
0 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
bpftools
linux-manual
linuxKernel.kernels.linux_5_16
linuxKernel.kernels.linux_latest_libre
linuxKernel.kernels.linux_testing
linuxKernel.packages.linux_5_16.acpi_call
linuxKernel.packages.linux_5_16.akvcam
linuxKernel.packages.linux_5_16.anbox
linuxKernel.packages.linux_5_16.apfs
linuxKernel.packages.linux_5_16.asus-ec-sensors
linuxKernel.packages.linux_5_16.asus-wmi-sensors
linuxKernel.packages.linux_5_16.batman_adv
linuxKernel.packages.linux_5_16.bbswitch
linuxKernel.packages.linux_5_16.broadcom_sta
linuxKernel.packages.linux_5_16.can-isotp
linuxKernel.packages.linux_5_16.chipsec
linuxKernel.packages.linux_5_16.cpupower
linuxKernel.packages.linux_5_16.cryptodev
linuxKernel.packages.linux_5_16.ddcci-driver
linuxKernel.packages.linux_5_16.dddvb
linuxKernel.packages.linux_5_16.digimend
linuxKernel.packages.linux_5_16.dpdk
linuxKernel.packages.linux_5_16.dpdk-kmods
linuxKernel.packages.linux_5_16.ena
linuxKernel.packages.linux_5_16.evdi
linuxKernel.packages.linux_5_16.facetimehd
linuxKernel.packages.linux_5_16.fwts-efi-runtime
linuxKernel.packages.linux_5_16.gcadapter-oc-kmod
linuxKernel.packages.linux_5_16.hid-nintendo
linuxKernel.packages.linux_5_16.hyperv-daemons
linuxKernel.packages.linux_5_16.intel-speed-select
linuxKernel.packages.linux_5_16.isgx
linuxKernel.packages.linux_5_16.it87
linuxKernel.packages.linux_5_16.ixgbevf
linuxKernel.packages.linux_5_16.jool
linuxKernel.packages.linux_5_16.kernel
linuxKernel.packages.linux_5_16.kvmfr
linuxKernel.packages.linux_5_16.liquidtux
linuxKernel.packages.linux_5_16.lttng-modules
linuxKernel.packages.linux_5_16.mba6x_bl
linuxKernel.packages.linux_5_16.mbp2018-bridge-drv
linuxKernel.packages.linux_5_16.mwprocapture
linuxKernel.packages.linux_5_16.mxu11x0
linuxKernel.packages.linux_5_16.ndiswrapper
linuxKernel.packages.linux_5_16.netatop
linuxKernel.packages.linux_5_16.nvidia_x11
linuxKernel.packages.linux_5_16.nvidia_x11_beta
linuxKernel.packages.linux_5_16.nvidia_x11_legacy340
linuxKernel.packages.linux_5_16.nvidia_x11_legacy390
linuxKernel.packages.linux_5_16.nvidia_x11_legacy470

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/2z9i2l2l70gk679wrf08ga7dv6gkybn1-linux-5.16.12 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A linuxKernel.kernels.linux_5_16 https://github.com/r-ryantm/nixpkgs/archive/0f167264389ffa073c94055d6c1d5cdb4ddc6a79.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/2z9i2l2l70gk679wrf08ga7dv6gkybn1-linux-5.16.12
ls -la /nix/store/2z9i2l2l70gk679wrf08ga7dv6gkybn1-linux-5.16.12/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @TredwellGit @ma27 @nequissimus @alyssais @thoughtpolice for testing.

Part of #162481 (https://github.com/NixOS/nixpkgs/pull/162481/commits/14c00448661bc251db70c0ef315cc9be3ccdf5a1)


text:
grml-zsh-config: 0.19.1 -> 0.19.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/grml-zsh-config/versions.
meta.description for grml-zsh-config is: "grml's zsh setup"
meta.homepage for grml-zsh-config is: "https://grml.org/zsh/"
meta.changelog for grml-zsh-config is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.19.2 in filename of file in /nix/store/bmc4z0fz8pinxh58fk1r5s2mkmch46c9-grml-zsh-config-0.19.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
grml-zsh-config

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/bmc4z0fz8pinxh58fk1r5s2mkmch46c9-grml-zsh-config-0.19.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A grml-zsh-config https://github.com/r-ryantm/nixpkgs/archive/10a3c1b93d844588acedfb32672e20861d9befd8.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bmc4z0fz8pinxh58fk1r5s2mkmch46c9-grml-zsh-config-0.19.2
ls -la /nix/store/bmc4z0fz8pinxh58fk1r5s2mkmch46c9-grml-zsh-config-0.19.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

grml-zsh-config

Maintainer pings
cc @msteen @rvolosatovs for testing.

Result of nixpkgs-review pr 166319 run on x86_64-linux 1

1 package built:

grml-zsh-config

authors: WolfangAukang r-ryantm


text:
python-modules/sip: do not generate manylinux wheels on powerpc64le

Description of changes
This is an alternative fix suggested by @tpwrules here for #168083.  Instead of changing the pythonHostPlatform used when building  python, we instead refuse to generate manylinux-family wheels.
This commit allows PyQt5 to build on powerpc64le.
Closes 168083.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin
[X] powerpc64le-linux

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Marking as draft per @tpwrules indication that https://github.com/NixOS/nixpkgs/pull/168083 is a better solution.

Closed by #168083


text:
nixos/minidlna: add user and group options

Description of changes
This allows the selection of a user/group to use for running the MiniDLNA daemon.  The minidlna user/group no longer gets created when a different user/group is used.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

Tested on NixOS (x86_64-linux) via nixos-rebuild -I path/to/nixpkgs

[x] Using the default minidlna user/group
[x] Using a custom user/group

Rebased to make this change mergeable.  Tested on NixOS.

Please squash commits.

Squashed.

Hm, one of the CI checks is failing.

authors: bjornfor earldouglas


text:
edk2: 202202 -> 202205

Description of changes
changelog: https://github.com/tianocore/edk2/releases/tag/edk2-stable202205
fixes https://nvd.nist.gov/vuln/detail/CVE-2021-38578.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 180733 run on aarch64-linux 1

1 package marked as broken and skipped:

OVMFFull

2 packages built:

OVMF
edk2

Result of nixpkgs-review pr 180733 run on x86_64-linux 1

4 packages built:

OVMF
OVMFFull
edk2
quickemu

authors: wamserma whentze


text:
python310Packages.pyswitchbot: 0.18.7 -> 0.18.10

Description of changes
https://github.com/Danielhiversen/pySwitchbot/releases/tag/0.18.10

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 186828 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.switchbot
python310Packages.pyswitchbot
python39Packages.pyswitchbot


text:
wordbook: init at unstable-2022-08-30

Description of changes
https://github.com/fushinari/Wordbook
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

[nix-shell:~/.cache/nixpkgs-review/pr-194581]$ ./results/wordbook/bin/wordbook
Traceback (most recent call last):
  File "/nix/store/29rqd0jhnzfinxm21gqp5bwnlk76272i-wordbook-unstable-2022-08-30/bin/.wordbook-wrapped", line 44, in <module>
    from wordbook.main import Application
  File "/nix/store/29rqd0jhnzfinxm21gqp5bwnlk76272i-wordbook-unstable-2022-08-30/share/wordbook/wordbook/main.py", line 9, in <module>
    gi.require_version("Gdk", "4.0")
  File "/nix/store/gwq3inwc86axcxb82jpwkzci3hjpw1xd-python3.10-pygobject-3.42.2/lib/python3.10/site-packages/gi/__init__.py", line 126, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace Gdk not available

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/664

authors: chuangzhu nixos-discourse zendo


text:
srvc: 0.8.0 -> 0.9.0

Description of changes

Add changelog
Add webfs check input for use by the tests
Pass env var to disable test timeout. Remove the patch that did this.
https://github.com/insilica/rs-srvc/blob/v0.9.0/CHANGELOG.md

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Thanks. I've updated with those changes


text:
Xfce 4.18

Description of changes
Update xfce
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 206282 run on x86_64-linux 1

5 packages marked as broken and skipped:

xfce.thunar-bare
xfce.xfce4-embed-plugin
xfce.xfce4-hardware-monitor-plugin
xfce.xfce4-namebar-plugin
xmonad_log_applet_xfce

4 packages failed to build:

xfce.xfce4-cpufreq-plugin
xfce.xfce4-cpugraph-plugin
xfce.xfce4-sensors-plugin
xfce.xfce4-volumed-pulse

58 packages built:

caffeine-ng
lightdm-gtk-greeter
pragha
xfce.catfish
xfce.exo
xfce.garcon
xfce.gigolo
xfce.libxfce4ui
xfce.libxfce4util
xfce.mousepad
xfce.orage
xfce.parole
xfce.ristretto
xfce.thunar
xfce.thunar-archive-plugin
xfce.thunar-dropbox-plugin
xfce.thunar-media-tags-plugin
xfce.thunar-volman
xfce.tumbler
xfce.xfburn
xfce.xfce4-appfinder
xfce.xfce4-battery-plugin
xfce.xfce4-clipman-plugin
xfce.xfce4-datetime-plugin
xfce.xfce4-dev-tools
xfce.xfce4-dict
xfce.xfce4-dockbarx-plugin
xfce.xfce4-eyes-plugin
xfce.xfce4-fsguard-plugin
xfce.xfce4-genmon-plugin
xfce.xfce4-i3-workspaces-plugin
xfce.xfce4-mailwatch-plugin
xfce.xfce4-mpc-plugin
xfce.xfce4-netload-plugin
xfce.xfce4-notes-plugin
xfce.xfce4-notifyd
xfce.xfce4-panel
xfce.xfce4-panel-profiles
xfce.xfce4-power-manager
xfce.xfce4-pulseaudio-plugin
xfce.xfce4-screensaver
xfce.xfce4-screenshooter
xfce.xfce4-session
xfce.xfce4-settings
xfce.xfce4-systemload-plugin
xfce.xfce4-taskmanager
xfce.xfce4-terminal
xfce.xfce4-time-out-plugin
xfce.xfce4-timer-plugin
xfce.xfce4-verve-plugin
xfce.xfce4-weather-plugin
xfce.xfce4-whiskermenu-plugin
xfce.xfce4-windowck-plugin
xfce.xfce4-xkb-plugin
xfce.xfconf
xfce.xfdashboard
xfce.xfdesktop
xfce.xfwm4

Result of nixpkgs-review pr 206282 run on x86_64-linux 1

7 packages marked as broken and skipped:

catfish
lightdm_gtk_greeter
xfce.thunar-bare
xfce.xfce4-embed-plugin
xfce.xfce4-hardware-monitor-plugin
xfce.xfce4-namebar-plugin
xmonad_log_applet_xfce

62 packages built:

caffeine-ng
lightdm-gtk-greeter
pragha
xfce.catfish
xfce.exo
xfce.garcon
xfce.gigolo
xfce.libxfce4ui
xfce.libxfce4util
xfce.mousepad
xfce.orage
xfce.parole
xfce.ristretto
xfce.thunar
xfce.thunar-archive-plugin
xfce.thunar-dropbox-plugin
xfce.thunar-media-tags-plugin
xfce.thunar-volman
xfce.tumbler
xfce.xfburn
xfce.xfce4-appfinder
xfce.xfce4-battery-plugin
xfce.xfce4-clipman-plugin
xfce.xfce4-cpufreq-plugin
xfce.xfce4-cpugraph-plugin
xfce.xfce4-datetime-plugin
xfce.xfce4-dev-tools
xfce.xfce4-dict
xfce.xfce4-dockbarx-plugin
xfce.xfce4-eyes-plugin
xfce.xfce4-fsguard-plugin
xfce.xfce4-genmon-plugin
xfce.xfce4-i3-workspaces-plugin
xfce.xfce4-mailwatch-plugin
xfce.xfce4-mpc-plugin
xfce.xfce4-netload-plugin
xfce.xfce4-notes-plugin
xfce.xfce4-notifyd
xfce.xfce4-panel
xfce.xfce4-panel-profiles
xfce.xfce4-power-manager
xfce.xfce4-pulseaudio-plugin
xfce.xfce4-screensaver
xfce.xfce4-screenshooter
xfce.xfce4-sensors-plugin
xfce.xfce4-session
xfce.xfce4-settings
xfce.xfce4-systemload-plugin
xfce.xfce4-taskmanager
xfce.xfce4-terminal
xfce.xfce4-time-out-plugin
xfce.xfce4-timer-plugin
xfce.xfce4-verve-plugin
xfce.xfce4-volumed-pulse
xfce.xfce4-weather-plugin
xfce.xfce4-whiskermenu-plugin
xfce.xfce4-windowck-plugin
xfce.xfce4-xkb-plugin
xfce.xfconf
xfce.xfdashboard
xfce.xfdesktop
xfce.xfwm4

@ofborg test xfce

authors: PedroHLC bobby285271 muscaln


text:
olaris-server: 0.4.0 -> unstable-2022-06-11

Description of changes
As called out in the linked issue below, olaris-server has a runtime dependency on ffmpeg. Unfortunately, 0.4.0 requires a custom fork of ffmpeg. While we could fetch the upstream compiled artefact or build it ourselves, the former was unpalatable and the latter prohibitively difficult. As such, we have bumped to the, yet to be released, tip of the default branch, which has merged support for upstream ffmpeg.
Fixes #207877
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1605

Result of nixpkgs-review pr 207884 run on x86_64-linux 1

1 package built:

olaris-server

authors: kevincox nixos-discourse urandom2


text:
fcrackzip: init at 1.0

patch adapted from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=430387

forgot to commit all-packages.nix. Fixed


text:
python310Packages.python-homewizard-energy: 1.3.1 -> 1.7.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.python-homewizard-energy is: Library to communicate with HomeWizard Energy devices
meta.homepage for python310Packages.python-homewizard-energy is: https://github.com/DCSBL/python-homewizard-energy
meta.changelog for python310Packages.python-homewizard-energy is: https://github.com/DCSBL/python-homewizard-energy/releases/tag/v1.5.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.5.0 with grep in /nix/store/lnygwiwl544lafhhvabng3yrz83zsyhs-python3.10-python-homewizard-energy-1.5.0
found 1.5.0 in filename of file in /nix/store/lnygwiwl544lafhhvabng3yrz83zsyhs-python3.10-python-homewizard-energy-1.5.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
home-assistant-component-tests.homewizard
python310Packages.python-homewizard-energy
python311Packages.python-homewizard-energy

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/lnygwiwl544lafhhvabng3yrz83zsyhs-python3.10-python-homewizard-energy-1.5.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.python-homewizard-energy https://github.com/r-ryantm/nixpkgs/archive/388220433b1f33bb2638bce2fded1e014b050fd9.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/lnygwiwl544lafhhvabng3yrz83zsyhs-python3.10-python-homewizard-energy-1.5.0
ls -la /nix/store/lnygwiwl544lafhhvabng3yrz83zsyhs-python3.10-python-homewizard-energy-1.5.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

home-assistant-component-tests.homewizard

2 packages built:

python310Packages.python-homewizard-energy
python311Packages.python-homewizard-energy

Maintainer pings
cc @fabaff for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.python-homewizard-energy is: Library to communicate with HomeWizard Energy devices
meta.homepage for python310Packages.python-homewizard-energy is: https://github.com/DCSBL/python-homewizard-energy
meta.changelog for python310Packages.python-homewizard-energy is: https://github.com/DCSBL/python-homewizard-energy/releases/tag/v1.6.1
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.6.1 with grep in /nix/store/l9jn1xrczi8qzxjjnhna5p54l3qgy95i-python3.10-python-homewizard-energy-1.6.1
found 1.6.1 in filename of file in /nix/store/l9jn1xrczi8qzxjjnhna5p54l3qgy95i-python3.10-python-homewizard-energy-1.6.1

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
home-assistant-component-tests.homewizard
python310Packages.python-homewizard-energy
python311Packages.python-homewizard-energy

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/l9jn1xrczi8qzxjjnhna5p54l3qgy95i-python3.10-python-homewizard-energy-1.6.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.python-homewizard-energy https://github.com/r-ryantm/nixpkgs/archive/ea4fe6d6ca15620ee5d05eeab862f80e159faa60.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/l9jn1xrczi8qzxjjnhna5p54l3qgy95i-python3.10-python-homewizard-energy-1.6.1
ls -la /nix/store/l9jn1xrczi8qzxjjnhna5p54l3qgy95i-python3.10-python-homewizard-energy-1.6.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

home-assistant-component-tests.homewizard

2 packages built:

python310Packages.python-homewizard-energy
python311Packages.python-homewizard-energy

Maintainer pings
cc @fabaff for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.python-homewizard-energy is: Library to communicate with HomeWizard Energy devices
meta.homepage for python310Packages.python-homewizard-energy is: https://github.com/DCSBL/python-homewizard-energy
meta.changelog for python310Packages.python-homewizard-energy is: https://github.com/DCSBL/python-homewizard-energy/releases/tag/v1.7.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.7.0 with grep in /nix/store/dkj5xc22qf858n5m1pwv0dzwvvd30c9h-python3.10-python-homewizard-energy-1.7.0
found 1.7.0 in filename of file in /nix/store/dkj5xc22qf858n5m1pwv0dzwvvd30c9h-python3.10-python-homewizard-energy-1.7.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
home-assistant-component-tests.homewizard
python310Packages.python-homewizard-energy
python311Packages.python-homewizard-energy

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dkj5xc22qf858n5m1pwv0dzwvvd30c9h-python3.10-python-homewizard-energy-1.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.python-homewizard-energy https://github.com/r-ryantm/nixpkgs/archive/1fa87e20dddbb5e6f7df3bdf6ca774c3ccf79b16.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dkj5xc22qf858n5m1pwv0dzwvvd30c9h-python3.10-python-homewizard-energy-1.7.0
ls -la /nix/store/dkj5xc22qf858n5m1pwv0dzwvvd30c9h-python3.10-python-homewizard-energy-1.7.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

home-assistant-component-tests.homewizard

2 packages built:

python310Packages.python-homewizard-energy
python311Packages.python-homewizard-energy

Maintainer pings
cc @fabaff for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.python-homewizard-energy is: Library to communicate with HomeWizard Energy devices
meta.homepage for python310Packages.python-homewizard-energy is: https://github.com/DCSBL/python-homewizard-energy
meta.changelog for python310Packages.python-homewizard-energy is: https://github.com/DCSBL/python-homewizard-energy/releases/tag/v1.8.0
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.8.0 with grep in /nix/store/msdl9fs70np603k6wddp5m03m2nbhdh4-python3.10-python-homewizard-energy-1.8.0
found 1.8.0 in filename of file in /nix/store/msdl9fs70np603k6wddp5m03m2nbhdh4-python3.10-python-homewizard-energy-1.8.0

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
home-assistant-component-tests.homewizard
python310Packages.python-homewizard-energy
python311Packages.python-homewizard-energy

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/msdl9fs70np603k6wddp5m03m2nbhdh4-python3.10-python-homewizard-energy-1.8.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.python-homewizard-energy https://github.com/r-ryantm/nixpkgs/archive/de48d66b6e36def100a2585e3470b0d302f0925c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/msdl9fs70np603k6wddp5m03m2nbhdh4-python3.10-python-homewizard-energy-1.8.0
ls -la /nix/store/msdl9fs70np603k6wddp5m03m2nbhdh4-python3.10-python-homewizard-energy-1.8.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

home-assistant-component-tests.homewizard

2 packages built:

python310Packages.python-homewizard-energy
python311Packages.python-homewizard-energy

Maintainer pings
cc @fabaff for testing.


text:
belle-sip: 5.1.55 -> 5.2.16

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/belle-sip/versions.
meta.description for belle-sip is: Modern library implementing SIP (RFC 3261) transport, transaction and dialog layers. Part of the Linphone project.
meta.homepage for belle-sip is: https://linphone.org/technical-corner/belle-sip
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 5.2.16 with grep in /nix/store/xdkas8jw3g9m1q73bn6873rh9cdj02np-belle-sip-5.2.16
found 5.2.16 in filename of file in /nix/store/xdkas8jw3g9m1q73bn6873rh9cdj02np-belle-sip-5.2.16

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

4 package rebuild(s)

First fifty rebuilds by attrpath
belle-sip
liblinphone
lime
linphone

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/xdkas8jw3g9m1q73bn6873rh9cdj02np-belle-sip-5.2.16 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A belle-sip https://github.com/r-ryantm/nixpkgs/archive/2b9695bc790d44cdeebef2a5e36d09ff4f2f55ce.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/xdkas8jw3g9m1q73bn6873rh9cdj02np-belle-sip-5.2.16
ls -la /nix/store/xdkas8jw3g9m1q73bn6873rh9cdj02np-belle-sip-5.2.16/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages built:

belle-sip
liblinphone
lime
linphone

Maintainer pings
cc @jluttine for testing.

@ofborg build lime linphone liblinphone belle-sip

authors: r-ryantm wegank


text:
DNS related changes

Motivation for this change
I decided to migrate my homeserver to NixOS and found a few things still missing from nixpkgs.
This PR mainly focuses on the DNS stack, changes are:

DNSChain: fixed the broken node package and improved the service
PDNS Recursor: added a package and a nixos module
Namecoind: modified the server so that it can run even with the default config
DNScrypt: added a nixos module for the wrapper server and updated the proxy package

Things done

[x] Tested using sandboxing (I tested individually each commits in a VM and the whole changes in a real machine)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

I think it should be possible to pull these commits separately if you think it's too much for a single PR.

@rnhmjoj usually distincts packages updates are splitted in multiple PR.
You PR mix package creation with package update and refactoring.
IMHO, your changeset could be merged faster splitted in 4 PR (dnschain, power dns, namecoind, dnscrypt)

Ok, thanks. I'll split the PR.


text:
rhc: 1.36.4 -> 1.38.7

Fix: CVE-2016-10173
Motivation for this change
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

👍 thank you!

authors: Szczyp grahamc


text:
Linux kernels 2023 04 05

Description of changes
Upstream only for now because GitHub is rate limiting me.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@OfBorg test kernel-generic

@ofborg test kernel-generic.linux_4_14 kernel-generic.linux_4_19 kernel-generic.linux_5_4 kernel-generic.linux_5_10 kernel-generic.linux_5_15

https://github.com/ofborg test kernel-generic.linux_4_14 kernel-generic.linux_4_19 kernel-generic.linux_5_4 kernel-generic.linux_5_10 kernel-generic.linux_5_15 kernel-generic.linux_5_15_hardened kernel-generic.linux_5_4_hardened  kernel-generic.linux_6_1_hardened


text:
python310Packages.jiwer: fix build

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

https://github.com/NixOS/nixpkgs/pull/224907/commits/844c403e101757b522ff1f4081d9574374b6a1e8 as part of https://github.com/NixOS/nixpkgs/pull/224907 was filed first

authors: dotlambda wegank


text:
rawtherapee: 5.0-r1 -> 5.0-r1-gtk2

Motivation for this change
Bugfixes and some improvements.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

The GTK2 version of RawTherapee is on life support. It won't be maintained going forward and GTK3 is what is being currently developed and deployed.
Why stick to GTK2?

@paperdigits right now it's a workaround. I tried the gtk3 version (it builds fine after replacing a few dependencies) but looks horrible for some reason (missing themes, icons, etc. - I'm not entirely sure what causes this) and I didn't have the time to hunt down these issues.
That said, I'd accept a PR to switch to the gtk3 version any time.

@2chilled Any thoughts on my comment earlier? I'm not sure if there's a point in adding this suffix at all - to me it seems like it doesn't provide any benefit (as it doesn't really matter in nixpkgs if a package depends on gtk2 or gtk3 - dependencies are handled transparently)

@the-kenny the GTK3 version needs at least GTK 3.22 for the theme to work. I was thinking that the version of GTK was <3.22, but I didn't have time to investigate.
I've been trying to get photography related tools all up-to-date, as I'd like to switch my editing machine to NixOS :)

@paperdigits Our rawtherapee is up to date, and I'm sure we can switch to the gtk3 branch at some point :) What other tools are you using in your workflow (personal interest here)?

@the-kenny Cool, I'll keep working on the gtk3 until it looks right.
I'm using Darktable, RawTherapee, Hugin/enfuse (which isn't built with openMP/GPU support by default in nix), Geeqie, G'MIC, and GIMP 2.9.x (currently not packaged). Less frequently I use Luminance HDR. I need to get DisplayCAL, and HDR Merge packaged. If you have interest in photography, please join us at https://discuss.pixls.us -- many devs and users of all sorts of FOSS programs there.

Seems like we have support for gtk 3.22 now, so I'll try a gtk3 build.
@the-kenny I'll remove the suffix to keep nix-env -u healthy. Thanks for pointing that out.

@the-kenny @paperdigits gtk3 version works and looks very nice on my system!

Trying it now!

Sorry for the late response. I had to mnually adjust the font size from 10 down to 8, but I'm quite sure that's caused by me using this font size for the gtk2 build (gtk2 likely isn't high-dpi compatible).
LGTM, merging now.

@2chilled this is awesome! Thank you!

authors: 2chilled paperdigits the-kenny


text:
wuzz: 2017-02-09 -> 0.2.0

Motivation for this change
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Closing this for https://github.com/NixOS/nixpkgs/pull/23002


text:
nixos-generate-config: Fix generated hostPlatform.system

Description of changes
While the intent of the code was correct, the system string can not be used in the substituteAll function.
Should fix the issue raised in https://github.com/NixOS/nixpkgs/pull/228133#issuecomment-1586193645

Root cause https://github.com/NixOS/nixpkgs/issues/237216

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Good detective work, and thanks for the quick fix.
Confirmed this resolves the issue I observed.

authors: roberth tpwrules


text:
wine: fix gstreamer on WoW builds

Description of changes
Fixes  #132352.
This is so dirty...
Tested The Elder Scrolls IV: Oblivion.
(For some reason, it only works when launched through the launcher, and not directly.)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

When there are two invocations of buildPhase, dirty takes more…


text:
steampipe: 0.20.10 -> 0.20.11

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/steampipe/versions.
meta.description for steampipe is: select * from cloud;
meta.homepage for steampipe is: https://steampipe.io/
meta.changelog for steampipe is: https://github.com/turbot/steampipe/blob/v0.20.11/CHANGELOG.md
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.20.11 with grep in /nix/store/d7vxn82kbmfbrwhicy900a120vax8x0c-steampipe-0.20.11
found 0.20.11 in filename of file in /nix/store/d7vxn82kbmfbrwhicy900a120vax8x0c-steampipe-0.20.11

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
steampipe

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/d7vxn82kbmfbrwhicy900a120vax8x0c-steampipe-0.20.11 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A steampipe https://github.com/r-ryantm/nixpkgs/archive/163832681ea15f5f7646a19b61670d031f58d198.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/d7vxn82kbmfbrwhicy900a120vax8x0c-steampipe-0.20.11
ls -la /nix/store/d7vxn82kbmfbrwhicy900a120vax8x0c-steampipe-0.20.11/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

steampipe

Maintainer pings
cc @hardselius for testing.

Result of nixpkgs-review pr 252856 run on x86_64-linux 1

1 package built:

steampipe

authors: matthiasbeyer r-ryantm


text:
aflplusplus: 4.06c -> 4.08c

Description of changes
Changelogs:

https://github.com/AFLplusplus/AFLplusplus/releases/tag/v4.08c
https://github.com/AFLplusplus/AFLplusplus/releases/tag/4.07c (skipped)

Commits aflplusplus-qemu sub-component (doesn't do releases):

https://github.com/AFLplusplus/qemuafl/commit/a8582925c5ecc8a58e96f36bddc724aa177926ed
https://github.com/AFLplusplus/qemuafl/commit/b0abbe2e74ed74ff6ff25b5ea3110d27ba978001

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux (not supported by package)
[ ] x86_64-darwin (not supported by package)
[ ] aarch64-darwin (not supported by package)

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)

Partially: I tested the core binaries (afl-fuzz + the compiler wrappers). This package has a lot of executables and I don't even know how to use half of them. I at least validated that they all start and print help.

23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Would be great if you could also update the qemu fork for afl (it's called qemu.nix beside the default.nix). Logs for the build look good and I guess you did some light testing, so I think that's good. Don't have time to test the next few weeks, so I trust your judgment regarding how well it works.

Ah yeah, I didn't notice the second fetchFromGitHub there -- updated! Only two commits were added in this repository since (added links in main post of this PR), both of which only affect PPC, so we probably don't have to do a lot of testing for the qemu part.

Doing some light testing on the qemu mode right now: seems to be working well! :) Interestingly enough this is actually finding quite a lot of new edges that my previous instrumentation based runs didn't manage to find. Perhaps it's because the qemu variant will likely also see paths taken in e.g. libc whereas the instrumentation based variant would be oblivious to those. It's also not nearly as slow as I had expected. Maybe I should do more qemu based fuzzing in the future. :upside_down_face:


text:
cmsis-pack-manager: propagate cffi properly

Without this patch, pyocd fails (nix run nixpkgs#pyocd) because
cffi is not propagated properly along with cmsis-pack-manager:
$ nix run nixpkgs#pyocd
Traceback (most recent call last):
[…]
pkg_resources.DistributionNotFound: The 'cffi' distribution was not found and is required by cmsis-pack-manager

Description of changes

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Pinging pyocd maintainers @frogamic and @sbruder

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2721

Issue is moot.

authors: nixos-discourse samueltardieu


text:
pharo: 5.0 -> 6.0 [work in progress]

Update Pharo for the 6.0 release. This includes a new upstream VM package, with a new build procedure, and separate 32-bit/64-bit variants.
This branch mostly done but with a little work still in progress:

[x] Create new set of VM packages:

[x] pharo-cog32: 32-bit VM for legacy cog images.
[x] pharo-spur32: 32-bit VM for Pharo 6 (and late Pharo 5.)
[x] pharo-spur64: 64-bit VM for Pharo 6 (and late Pharo 5.) Experimental!
[x] pharo: Multi-VM wrapper that automatically selects a suitable VM based on the image being opened.

[x] Upgrade spur VM to the new OpenSmalltalk version and build process. This is the standard one now.
[ ] Upgrade spur VM source to the latest version recommended by upstream.
[ ] Fix filename conflicts when installing multiple VM packages (use separate Nix outputs for supporting files?)
[ ] Check that desktop integration (icons, image file opening, etc) works.
[ ] Itegrate improvements from #25681.
[x] Mark pharo-launcher as unmaintained. (Seems to require coordinating with upstream developers, who have some multi-VM selection logic on the Smalltalk side, and on reflection I don't have time for this.)

cc @Balletie
Motivation for this change
Support the latest Pharo VM in order to run the latest Pharo images.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

@0xABAB Thanks for the reviews! I have pushed some fixes intended to address them. Aside: I would find it helpful if the Nixpkgs Contributors Guide would provide a rationale for these somewhere. I don't immediately understand the difference between * and ./* or why it is necessary to quote nix store paths.

@Balletie Could you be tempted to rebase your changes on this branch and PR them?

I spent a little time trying to use multiple outputs to reduce the amount of symlinkage into the environment. I am not sure why but I didn't make that work. I intended to leave that as-is for the purposes of this PR and I don't think that it poses a practical problem. Could be improved in the future when I have more experience with multiple outputs.

@Balletie Good question about use cases. It's important since this package only provides the VM which is not useful unless you combine it with an image. So where does the image come from, and how do you make sure the image and VM are compatible?
My premise on this branch is that you are downloading images from the internet, e.g. Pharo 5, Pharo 6, Pharo 7 preview, Moose 6, Moose 6.1, DrGeo, etc, and you often have no special knowledge of which VM is required (and don't care - you just want to run the image.) So in this case the wrapper script does the right thing by making sure all VMs are available and selecting the appropriate one.
(Could be that those images are often distributed together with "appropriate" VMs but those will be binaries that you can't simply run on NixOS out of the box.)
Note: There are many Pharo images in the wild, and each one works with only one of the cog32/spur32/spur64 variants, so any time we drop a VM variant we are limiting the set of images that can be opened.

I'll try to rebase tomorrow.
Regarding the comment about the use case: I was trying to say that maybe we should remove the  build-vm-legacy.nix file, since it won't be used anymore after your changes, no?

maybe we should remove the build-vm-legacy.nix file, since it won't be used anymore after your changes, no?

Oops! I actually missed committing the file where it is referenced, vms.nix. Added in 4ed1d53. Guess I need to start paying attention to the Travis result. Had assumed the red was a false-negative.

I pushed an update to the latest recommended version of the spur VM (based on feedback on the pharo-dev mailing list since upstream are not making actual source releases nowadays.) The 64-bit VM is now not working properly with my usual test image but I propose to simply live with this for now, since 64-bit support is still an experimental feature and I don't know how stable and compatible it is supposed to be. Hope to fix it with a future PR.

I decided to skip testing the desktop integration (icons, open on double-click, etc.) My NixOS desktop is not working that well - can't open a file browser in xfce for some reason - and I don't have the time to troubleshoot that (I don't use any of that stuff myself anyway.)

Travis-CI is reporting a build error but I don't understand its report. Can somebody please help me to decipher it?

@lukego You can cherry pick from my pharo6-for-nixpkgs branch. That way this PR can stay open.

Thanks @0xABAB for the approval. I think it makes sense to land imperfect code and improve it incrementally. (I've already spent about a week on this, spread out over a couple of months, trying to understand what has been happening with the upstream project and coordinate with their release plans. And there is still a lot of that work to do in order to create Pharo images within Nix. Hurts a bit :))
@Balletie I merged your branch, thanks! Sorry about the wait, I did not immediately realize that you had created a new branch with the changes rebased. Thank you for that.
Is this branch ready to merge then? I am fine with any rebasing/squashing/etc that anybody wants to do / wants me to do.

... Since this PR is still open I will continue to push my Pharo related fixes here. The latest is a downgrade to gcc 4.8 to work-around a segfault crash when forking a subprocess (2b3dcfa
). Have to revisit this when upstream work out what is happening there.
I have reached out for help with identifying a suitable test suite for the VM to find this problems more proactively.

@lukego If you believe the packaging is done, just contact e.g. Mic92 with a request to merge (I already thought it was good enough to merge earlier).
The reason Pharo crashes with newer compilers is because newer compilers tend to exploit C semantics, and in particular undefined behavior, better. Pharo programmers used fork without understanding what it does (next to some other out of bounds issue being present).
So, while many people would traditionally point at the compiler for being wrong with the argument that the old compiler did work, this line of reasoning is false. I fully expect the same problems on other platforms, if not today, then tomorrow.
I would not recommend anyone to run anything important on Pharo, because of the referenced bug.
In our packaging it would be nice to have a marker like "known to exhibit nasal daemons for programs with known undefined behavior", but unfortunately I expect that most people in this community would consider such a feature to be too harsh.

Closing in a huff because I am annoyed by the unsolicited disparaging comments about the software that I am packaging.

@0xABAB Please bear with me for a bit. I am frustrated because I don't understand the process for contributing to nixpkgs (what is a "merge request"? who is "Mic92"?) and I don't enjoy the feedback you are giving me (feels a bit gratuitously negative to me and I am not sure if/how I am supposed to respond in this context i.e. on a PR that I have open.)
I am just looking for the lowest friction way to share the work that I am doing on packaging Pharo in order to avoid duplication by other people who want to use it too.

@lukego please don't be discouraged!
https://github.com/NixOS/nixpkgs/issues/27258#issuecomment-314057285

I understand from #27298 that this branch may be rebased/squashed on the way into the repo. That's fine.

@lukego merged. Thank you

This pull request has been mentioned on Nix community. There might be relevant details there:
https://discourse.nixos.org/t/code-of-conduct-or-whatever/2134/1

authors: 0xABAB Balletie eqyiel joachifm lukego nixos-discourse