text:
Syntax errors given for valid extensions

The AWS Tools extension for Azure Pipelines (https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.aws-vsts-tools) allows tasks like this to be specified in azure-pipelines.yml:
Deploy to AWS Elastic Beanstalk

task: BeanstalkDeployApplication@1
inputs:
awsCredentials: 'AWS'
regionName: 'eu-west-2'
applicationName: 'HelloWorld'
environmentName: 'Helloworld-env'
applicationType: 'aspnetCoreWindows'
logRequest: true
logResponse: true

However, this generates 13 syntax errors as the plug-in is evidently not aware of this task type.  A similar thing happens with the SonarQube extension (https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarqube).  I can't find any way to turn these syntax errors off; therefore the tool is not much use to me at the moment.

Thanks for the report. It's not obvious, but this is a dupe of #226.

authors: ed-graham vtbassmatt

repo: microsoft/azure-pipelines-vscode


text:
[Bug] Key Vault Secrets loaded multiple times

Environment

Spring boot starter:
azure-keyvault-secrets-spring-boot-starter

OS Type: Windows

Java version:

1.8

Summary
When used with another configuration provider the key vault values are loaded multiple times. I see the values load 4 times, though someone else sees 8.
Initially reported here, https://github.com/Azure/AppConfiguration/issues/306, but seems to be a Key Vault issue.
Reproduce steps
https://github.com/saragluna/demo-appconfiguration-kv

start the application and hit http://localhost:8080
wait for a minute
Update the value of the config. messages property in app configuration from azure portal.
Hit http://localhost:8080 again and the application will refresh the app configuration.
While refreshing, I am able to monitor the logs and it fetches the key-vault value azure.cosmosdb.key several time, 8 times to be exact.

Expected Results
The values are loaded only once.
Actual Results
The key vault values are loaded multiple times, in large stores this results in a very long startup/refresh times.

Hi, mrm9084,
(cc @yiliuTo, FYI.)
This is because when app configure refreshes it will trigger out the context refreshing, and key vaults reload as well. It repeats for multiple times is due to we have more than one context. Now it seems our current behavior of app configure refreshing is not reasonable, we will continue looking into it.

Hi @mrm9084 , the reason why key vault values load multiple times is as what @chenrujun talked about, it is unavoidable in the process of spring context refreshing. However, we have a PR to cache key vault values and then when the environment reads key vault property source, these values are cached locally instead of being requested from the server, which will save the total refresh time.

Internally tracked at https://dev.azure.com/azure-spring-integration/spring-integration-private/_workitems/edit/190

if this part of 2.3.2 release?

Hi @AbhijeetAvaghade The associated PR wasn't included in 2.3.2 release, and we plan to release it in 2.3.3 version.

source: gharchive/issue

authors: AbhijeetAvaghade chenrujun edburns mrm9084 yiliuTo

repo: microsoft/azure-spring-boot

license: MIT

license_type: permissive

license_source: github-api


text:
Cannot create PostgreSql when using Sealed Secrets

When creating a PostgreSql server using k8s manifests/kubectl, if the login secret was created by Sealed Secrets (or has existing ownerReferences), the server is never created. An error like this is written to the controller logs:
2022-05-25 18:56:41.1055 | ERROR | Failed to prepare the login secret Microsoft.SqlServer.Controller.Plugin.PostgreSql.OwnershipException: Child resource <postgres-name>-login-secret is already owned by SealedSecret <postgres-name>-login-secret (ID ...)

This makes it difficult to use in GitOps scenarios. Is there a workaround available?

/cc @twright-msft
Hey @jacobdanovitch, thank you for opening the issue!
Since this is not a Jumpstart scenario or ArcBox-related issue, I will go ahead and close it.
The Azure Arc Jumpstart team does not handle Azure Arc core product issues, bugs and feature requests and will try to assist on a best effort basis. For a core product issue or feature request/feedback, please create an official Azure support ticket or general feedback request.

authors: jacobdanovitch likamrat


text:
Error Messsage upon opening ADS

Azure Data Studio Version:

Steps to Reproduce:

Open ADS
Error message pops up:

from developer tools console:

path is:
file:///Applications/Azure Data Studio - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js
Note: I also updated to Big Sur yesterday, not sure if that is related or not.

@chlafreniere This seems to be coming from NotebookModel https://github.com/microsoft/azuredatastudio/blob/main/src/sql/workbench/services/notebook/browser/models/notebookModel.ts#L1111

@cssuh is there a notebook that you have open when ADS starts up?
This error can technically be due to numerous different issues, but in reality, often implies that there's an issue with a Python install.
@lucyzhang929 as FYI

@chlafreniere yes I have the DRI notebook open when ADS starts up.  Just closed the notebook and reopened and the error does not show in that scenario.

Interesting. So does this repro every time that you have the DRI notebook open when ADS starts?
From: Christopher Suh @.>
Date: Friday, May 14, 2021 at 1:03 PM
To: microsoft/azuredatastudio @.>
Cc: Chris LaFreniere @.>, Mention @.>
Subject: Re: [microsoft/azuredatastudio] Error Messsage upon opening ADS (#15486)
@chlafrenierehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fchlafreniere&data=04|01|chlafren%40microsoft.com|4e4ead698b394069dba608d91713623d|72f988bf86f141af91ab2d7cd011db47|1|0|637566194285144461|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=BCtb%2FpR3o18lQvRofny9J9ld6ecMsJ%2BpRoMu8cfBhuE%3D&reserved=0 yes I have the DRI notebook open when ADS starts up. Just closed the notebook and reopened and the error does not show in that scenario.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fazuredatastudio%2Fissues%2F15486%23issuecomment-841472636&data=04|01|chlafren%40microsoft.com|4e4ead698b394069dba608d91713623d|72f988bf86f141af91ab2d7cd011db47|1|0|637566194285154419|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=gnuG3lvcUn2a58WIAB9Hr0Rti%2FbCaSkmMv5ix0ANbCo%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJUALQNCM3BJ6TW37SDV5V3TNV62FANCNFSM4445YHSQ&data=04|01|chlafren%40microsoft.com|4e4ead698b394069dba608d91713623d|72f988bf86f141af91ab2d7cd011db47|1|0|637566194285154419|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=cEre0eRf7zUiZyl%2FtCAsB7zxqDqB%2F6P6lprnZXDZZSo%3D&reserved=0.

Yes, it has happened every time - if I start without an editor open, then the error only shows up once I open the DRI notebook.

I'd suggest running the "Reinstall Notebook Dependencies" command pallette task and see if that fixes it for you, @cssuh

That didn't seem to work, I think this is an issue with Big Sur because I am not able to run it in ADS 1.28 (latest public release) either.

@cssuh are you still seeing this?

This is the error I'm getting now, but from talking to other people who upgraded to Big Sur, it seems to be isolated to  my machine.

Closing issues without repro on current builds.  Please reactive if you're still impacted by this issue.

authors: Charles-Gagnon chlafreniere cssuh kburtram

repo: microsoft/azuredatastudio


text:
A11y_AzureDataStudioAAE_PostgreSQl Hyperscale server groups_Deployment Prerequisite_ScreenReader: Screenreader announces wrong information while navigating through column header with help of arrow key.

https://user-images.githubusercontent.com/85863999/127468222-78990828-6a0b-458b-9886-0bd4d9aa7cd5.mp4
Actual:
While navigation through 'required tools' table with help of arrow key and focus is on 'Tool' column header. NVDA announces 'Tool clickable ', but it is not clickable element. NVDA announces wrong information.
Similar issue is observed with JAWS.
Similar issue is observed with this 'Azure Sql Managed Instance- Deployment Prerequisite' scenario
Expected:
While navigation through 'required tools' table with help of arrow key and focus is on 'Tool' column header. NVDA should announce 'Tool' only, NVDA should not announce wrong information.
GitHubTags: #A11yMAS;#A11yTCS;#A11ySev2;#SH_AzureDataStudio_AAE_Jun2021;#SQL Azure Data Studio;#Win10;#FTP;#DesktopApp;#STP;#WCAG1.3.1;#NVDA;#Jaws;#AINotInScope;
Environment Details:
Application Name: Azure Data Studio-AAE
Windows Version: Win10
Screen reader: NVDA(2020.2), Jaws(2020.2008.24)
Repro Steps:

Launch the application-Azure Data Studio-Insiders and install extension Azure arc and Azure data ClI
Connect to Azure Arc Controller
Tab till "Connection" and tab to see more button
Tab till "New Deployment" and press enter
Tab to PostgreSQl Hyperscale server groups and press enter on select button
Start NVDA
Enter into table and go till tool header with help of arrow keys
Check how nvda is announcing the information

User Impact:
Screenreader user will get wrong information.
“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

@alanrenmsft So it looks like this is an issue coming from slickgrid - its attaching a click handler to the header row : https://github.com/kburtram/SlickGrid/blob/master/slick.grid.js#L380
Which then causes screenreaders to announce it as "clickable".
So we may have to dig into that to see if we can remove the click handler in cases like this where it doesn't seem to be necessary.
I'll try to look at it at some point, but if you have time to look into it as well that would be great.

@Charles-Gagnon are you able to reproduce the issue? I am not able to make NVDA go to the table header.

@alanrenmsft This is in text mode (insert + space). I can repro this. Are you able to take a look at this one? I can probably find some time this week if you're busy with other stuff.

Closing as not repro

GitHub Tags: #Closed;


text:
Unable to see Azure Databases in Servers Group

Issue Type: Bug
Version: 1.32.0-insider
Commit: 07ad50670efc204f399ebbe7ca10f2e29169cda8
Date: 2021-07-28T05:39:45.938Z
VS Code: 1.56.0
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Darwin x64 20.5.0
Using Azure Data Studio Insiders, I am unable to expand any of my Azure SQL Databases (vCore-based). I am able to connect and open a new query window and issue statements against the databases located on the Azure SQL Database, but I can't see any of the databases in the Server Explorer window. This happens across multiple Azure SQL Database(s) hosted in different Azure Subscriptions.
I believe this to be an issue with the latest insiders build as yesterday this all worked as expected.
Azure Data Studio version: azuredatastudio-insiders 1.32.0-insider (07ad50670efc204f399ebbe7ca10f2e29169cda8, 2021-07-28T05:39:45.938Z)
OS version: Darwin x64 20.5.0
Extensions (9)

Extension
Author (truncated)
Version

admin-pack
Mic
0.0.2

agent
Mic
0.47.0

dacpac
Mic
1.8.0

import
Mic
1.3.1

profiler
Mic
0.11.0

query-history
Mic
0.1.0

schema-compare
Mic
1.11.0

sql-database-projects
Mic
0.11.0

azdata-sanddance
msr
3.3.0

(1 theme extensions excluded)

Here you go. For what it is worth, I installed the non-insiders build (version 1.31.0) and do not experience the issue with that version.
Console.log
ApplicationLogs.zip

@tlentine Thanks for posting the logs. To be clear, you can see the server in the explorer but not the databases inside it?

That is correct. I can connect to the server, I can open a query window and see the list of databases in the drop down list, but in the explorer I am not able to expand the tree and see any of the databases on the servers I connect to.

@tlentine Thanks for the reply! What kind of server is it? It will help me look into the problem in more detail.

It happens across different Azure SQL Database servers (vCore based). Connecting to SQL Server on my local network works as expected. It is only failing with Azure SQL Databases.

@tlentine, this issue appears to be fixed in the latest insider version of Azure Data Studio 1.41.0-insider. Please try the latest insider version and see whether this is fixed for you: https://github.com/microsoft/azuredatastudio#try-out-the-latest-insiders-build-from-main-branch

authors: abist lewis-sanchez tlentine


text:
Saved credentials are not read anymore as the new format excludes applicationName

Azure Data Studio Version: 1.44-RC1
OS Version: Windows 11

Steps to Reproduce:

Try to connect a connection with saved credentials
Password not loaded

This is related with recent change to introduce support for custom 'Application Name' as it's no longer considered a 'special type' and therefore not included in credential key. I was able to compare the new string missing 'applicationName' which is a design decision and application name shouldn't have been added to the credential key in the first place.

To mitigate this, we need to migrate saved passwords to new format to avoid losing saved credentials upon upgrade.

Closing as fix is now merged


text:
Dashboard: Errors when dragging widgets

SQL Operations Studio Version: master

Steps to Reproduce:

Open any server or database dashboard.
Edit the widget configuration by moving around the widget by dragging the widgets towards the bottom of the page.

Expected - Nothing happens and the widgets get moved placed at the bottom.
Actual - The widget either gets placed at the bottom with a silent error in the background -
ERROR
zone-node.js:2280
TypeError: Cannot read property 'setScrollDimensions' of undefined
zone-node.js:2280
ERROR CONTEXT
zone-node.js:2280
DebugContext_ {view: Object, nodeIndex: 0, nodeDef: Object, elDef: Object, elView: Object}

OR
The widget just vanishes from the dashboard and can't be retrieved back.

Closing out older issues.  This should be addressed by dashboard refactor in-progress.

authors: abist kburtram


text:
Fix KEY_UP Eventing in Link Callout Dialog

Addresses #15167.
I'm not a huge fan of this solution, but I haven't found a better way to do this. Any suggestions welcome 😄.
In actionbar.ts, it handles both KEY_DOWN and KEY_UP events. I checked the past 3 releases, and this functionality is broken in all of those releases while in split/md mode, so I'm fairly convinced that this has just never worked.

Pull Request Test Coverage Report for Build 840779004

3 of 9 (33.33%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.0009%) to 43.536%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/contrib/notebook/browser/calloutDialog/linkCalloutDialog.ts
3
9
33.33%

Totals

Change from base Build 840396184:
0.0009%

Covered Lines:
26521

Relevant Lines:
55438

💛  - Coveralls

It feels like we should only be handling one of those events for most things, so this might more be an issue with actionbar (or is this in the VS Code)? Where are the two different events being handled that's causing the problem?

It feels like we should only be handling one of those events for most things, so this might more be an issue with actionbar (or is this in the VS Code)? Where are the two different events being handled that's causing the problem?

It's in actionbar:
https://github.com/microsoft/azuredatastudio/blob/ba6bfbb6145ea38770a08bad9cffb588c1582f4e/src/sql/base/browser/ui/taskbar/actionbar.ts#L101
https://github.com/microsoft/azuredatastudio/blob/ba6bfbb6145ea38770a08bad9cffb588c1582f4e/src/sql/base/browser/ui/taskbar/actionbar.ts#L73
One of my goals was to keep this change localized as much as possible, given that we're in ask mode. Not sure if that can be accomplished changing actionbar itself (the file hasn't been touched in ~7 months) 🤒

@Charles-Gagnon any thoughts here?

#15484 to track investigating removal of KEY_UP listener.

source: gharchive/pull-request

authors: Charles-Gagnon chlafreniere coveralls


text:
procps-ng: suppress debug messages to console by default

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

During normal use, many low level debug messages are printing to the console which is causing usability issues for the user.
To deal with this, install a sysctl configuration to run on boot which will change the default kernel printk value to "4 4 1 7".
/etc/sysctl.d is supplied by systemd, so we need to also have a weak recommends on systemd. This is not a full requires because it would induce a circular dependency, and would pull in systemd in situations where it may not be truly required (i.e., inside minimal container images).
Signed-off-by: Chris Co chrco@microsoft.com
Does this affect the toolchain?

YES
Associated issues

Links to CVEs
Test Methodology

Buddy Build: 524643

Converting back to draft. Updating this change to supply the conf file from systemd package instead of procps-ng package

repo: microsoft/azurelinux


text:
Saulparedes/fix setuptools build

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

What does the PR accomplish, why was it needed?
Fix build break after merging https://github.com/microsoft/azurelinux/pull/7981. Not sure what happened here but something related to the tarball name changed since the last time I ran buddy build on that PR and today when I merged it.
Buddy build showing this package failing to build on 3.0-dev: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=533411&view=logs&j=bac295d9-f2e0-5165-e63e-e76f383e1a27&t=11f6dde0-e75e-52b2-fbf0-d83a00678fa3&l=1417
Buddy build passing using this PR: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=533438&view=results
Change Log

python-setuptools_scm

Does this affect the toolchain?

NO
Test Methodology

buddy build: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=533438&view=logs&s=6a6799ac-ca2b-5697-fcd7-5222f9e18e81

You can rename the source to #/%{srcname}-%{version}.tar.gz on
https://github.com/microsoft/azurelinux/blob/693e529f77f1a7a7cad5ff0162861f2ce1c9e3de/SPECS/python-setuptools_scm/python-setuptools_scm.spec#L15
That would read the signature file correctly.
I am not sure how you have uploaded the tar.gz to source blob, but it would need to uploaded as setuptools_scm-8.0.3.tar.gz

Hey Neha. The correct URL seems to be https://files.pythonhosted.org/packages/af/54/0a75c590c1aa1908c1036de783c0b7136d8fe4beb8ce4c52e4d92b9e9ca7/setuptools-scm-8.0.3.tar.gz (with dash -)

It doesn't work with https://files.pythonhosted.org/packages/af/54/0a75c590c1aa1908c1036de783c0b7136d8fe4beb8ce4c52e4d92b9e9ca7/setuptools_scm-8.0.3.tar.gz (with underscore _)

So still not clear on how it worked for me before (maybe they renamed it in files.pythonhosted !?), but looking now and the source url/tarball name should be setuptools-scm-8.0.3.tar.gz

You can rename the source to #/%{srcname}-%{version}.tar.gz on
https://github.com/microsoft/azurelinux/blob/693e529f77f1a7a7cad5ff0162861f2ce1c9e3de/SPECS/python-setuptools_scm/python-setuptools_scm.spec#L15
That would read the signature file correctly.
I am not sure how you have uploaded the tar.gz to source blob, but it would need to uploaded as setuptools_scm-8.0.3.tar.gz

Thanks @neha170 ! The correct URL seems to be https://files.pythonhosted.org/packages/af/54/0a75c590c1aa1908c1036de783c0b7136d8fe4beb8ce4c52e4d92b9e9ca7/setuptools-scm-8.0.3.tar.gz (with dash -)
It doesn't work with https://files.pythonhosted.org/packages/af/54/0a75c590c1aa1908c1036de783c0b7136d8fe4beb8ce4c52e4d92b9e9ca7/setuptools_scm-8.0.3.tar.gz (with underscore _)
So still not clear on how it worked for me before (maybe they renamed it in files.pythonhosted !?), but looking now and the source url/tarball name should be setuptools-scm-8.0.3.tar.gz

You can rename the source in your spec. We do that often in our specs. Sample https://github.com/microsoft/azurelinux/blob/9e14f6c5217039af709ae8122f9ca8a504a80878/SPECS/abseil-cpp/abseil-cpp.spec#L9


text:
replacedialogasync vs BeginDialogAsyc

🚨 The issue tracker is not for questions 🚨
If you have a question, please ask it on https://stackoverflow.com/questions/tagged/botframework
Greetings.
I did not find a clear answer to this question, so I post it here in case any of you have the time to answer
thanks tons,
Geo

Hello @gtejeda
It looks like you're trying to ask a question. I'm happy to help, but we prefer to keep how-to questions on Stack Overflow. Please read this help document to know how to ask a good question to make sure you can get a good answer.
In the meantime, I can tell you that the difference between ReplaceDialogAsync and BeginDialogAsync is that ReplaceDialogAsync ends the current dialog on the stack so that it will not be resumed after the new dialog, while BeginDialogAsync adds a new dialog on top of the current dialog on the stack so that it does get resumed afterward. You can read more about dialogs here: https://docs.microsoft.com/en-us/azure/bot-service/bot-builder-concept-dialog
I'm closing this issue now.

authors: gtejeda v-kydela

repo: microsoft/botbuilder-dotnet


text:
Clm/storage update test

This is a clone of:
https://github.com/microsoft/botbuilder-dotnet/pull/1711
The goal is to run the automated build system to make sure everything passes.

Pull Request Test Coverage Report for Build 64718

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.111%

Totals

Change from base Build 64616:
0.0%

Covered Lines:
4379

Relevant Lines:
6158

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll
:x: 2 Binary Compatibility issues for Microsoft.Bot.Builder.Azure

MembersMustExist : Member 'Microsoft.Bot.Builder.Azure.AzureBlobStorage..ctor(Microsoft.WindowsAzure.Storage.CloudStorageAccount, System.String)' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'Microsoft.Bot.Builder.Azure.AzureBlobTranscriptStore..ctor(Microsoft.WindowsAzure.Storage.CloudStorageAccount, System.String)' does not exist in the implementation but it does exist in the contract.

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll

That binary compat issue isn't good. I don't see how we can take this, given the Type / Signature changes.

Ok, how can this be resolved? The storage library has been completely re-namespaced as of 10.x. So CloudStorageAccount is now in Microsoft.Azure.Storage.

authors: cleemullins coveralls edboykin-insight fuselabs


text:
QnaMaker: rename Prompt -> QnaMakerPrompt

Fixes #2809

Pull Request Test Coverage Report for Build 84898

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.011%

Totals

Change from base Build 84883:
0.0%

Covered Lines:
8178

Relevant Lines:
10759

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

authors: carlosscastro coveralls fuselabs


text:
TurnContext is not properly populated in chats

Versions
What package version of the SDK are you using: 4.13.6
What nodejs version are you using: 18.14.0
What browser version are you using: Chrome latest
What os are you using: MacOS
Describe the bug
The TurnContext received by the botframework e.g. in getSignInComposeExtension is not properly populated when invoking from a chat.
E.g. the theme property in turnContext.activity.value.context.theme is always "default" whereas when invoking from a conversation context, it is properly populate with the current theme the user has selected.
To Reproduce

Invoke any bot action from a chat
Inspect turnContext received in your nodeJS environment
Look at e.g. turnContext.activity.value.context.theme
See that it is not properly populated

Expected behavior
The turnContext should be properly populated with the correct values, as it does in conversation contexts.
Additional context
This bug was found in the context of this client js sdk issue: https://github.com/OfficeDev/microsoft-teams-library-js/issues/888

Thanks @LeonYasoon, I'm looking into this.

Hi @LeonYasoon,
.theme property and getSignInComposeExtension does not appear to be related to Bot Framework SDK code.

How did you create your bot?
Are you able to provide a minimal .zip bot sample that reproduces this issue?

Closing due to inactivity. @LeonYasoon, please re-open and provide additional information requested above. Thanks!

authors: LeonYasoon ramfattah

repo: microsoft/botbuilder-js


text:
fix: CG security alert for axios 0.19.0, 0.21.1

Fixes #minor
Description
axios is vulnerable to Inefficient Regular Expression Complexity
Severity high.
https://fuselabs.visualstudio.com/SDK_v4/_componentGovernance/112352/alert/5622360?typeId=10220548
https://fuselabs.visualstudio.com/SDK_v4/_componentGovernance/112352/alert/4224550?typeId=10220548
https://fuselabs.visualstudio.com/SDK_v4/_componentGovernance/112352/alert/5846780?typeId=10220548
Specific Changes
Update @azure/ms-rest-js devDependency to the latest, 2.6.0. This eliminates the axios dependency altogether.
Remove unused dependencies.

Changing axios versions is a breaking change as we have code that exposes axios options to consumers of the SDK, so keep that in mind (cc @mrivera-ms).

Rechecking for the axios vulnerability shows it to no longer be present:
C:\src\botbuilder-js>npm ls axios
botbuilder-js@4.13.0 C:\src\botbuilder-js
-- @azure/ms-rest-js@1.9.1   -- axios@0.21.4

authors: BruceHaley joshgummersall


text:
Send proactive message without saving Conversation reference

Is your feature request related to a problem? Please describe.
We are trying to build some automation and send messages as a bot. For example, the github PR is open for too long, send bot message to the reviewer.
I see this example to cache the conversation reference: https://github.com/microsoft/BotBuilder-Samples/blob/main/samples/python/16.proactive-messages/bots/proactive_bot.py#L10
However, this implementation just isn't resilient. E.g., what if my bot server crashed, how to I keep the conversation references? We can certainly build something to make it fault tolerant, but that adds unnecessary complexity.
In fact, we do have the user id, but we can't construct a conversation reference from solely the user id + bot id.
Describe the solution you'd like
I'd like to have the Bot framework support creating/retrieving conversation reference on the fly given the user id. E.g.,
conversation_reference = ConversationReference(user_id=user_id, ...)
Describe alternatives you've considered
This API seems to be promising: https://docs.microsoft.com/en-us/graph/api/userscopeteamsappinstallation-get-chat?view=graph-rest-1.0&tabs=http
However, I can't get the accessToken from the SDK (it requires the TurnContext, which is again a problem for proactive scenarios)
Additional context

the following snippet works for me to send proactive messages to the user:
`
config = DefaultConfig()
adapter = CloudAdapter(ConfigurationBotFrameworkAuthentication(config))
recipient = ChannelAccount(id=${aadObjectId})
bot = ChannelAccount(id=config.APP_ID)
activity_reply = Activity(
type=ActivityTypes.message,
channel_id="msteams",
from_property=bot,
recipient=recipient,
text="Hello!",
)
conversation_params = ConversationParameters(
bot=bot,
members=[recipient],
activity=activity_reply,
channel_data={"tenant": {"id": "${tenantID}"}},
)
await adapter.create_conversation(
bot_app_id=config.APP_ID,
callback=lambda turn_context: turn_context.send_activity(activity_reply),
conversation_parameters=conversation_params,
channel_id="msteams",
service_url="https://smba.trafficmanager.net/teams/",
)
`

Yes, for Teams

Can you tell how to modify this to send a reply message on a post on teams.
(If I store the initial ids like ActivityId and any other attribute if needed in some database)

This issue should be opened in the Teams Samples repo:  https://github.com/OfficeDev/Microsoft-Teams-Samples
Closing this since I don't have the ability to transfer.  I did open an issue in that repo.

authors: Shashank22082002 kostyaplis tracyboehrer ydmztang

repo: microsoft/botbuilder-python


text:
Add Web Chat 4.6 updates

Summarizes 4.6 updates to Web Chat. Feedback welcome.

@Kaiqb ping - I don't have the ability to add reviewers.

Manually merged changes.

authors: Kaiqb corinagum

repo: microsoft/botframework


text:
Add Swagger-UI Visualization to playground

[x] Shorten playground sharing URL with sample name reference when it is referred to a known sample file
[x] Playground: support swagger-ui visualization
Playground link https://cadlplayground.z22.web.core.windows.net/prs/716/

Quick warning. The Graph team would not be using Swagger as it's an OpenAPI-specific component. As we are using CSDL as our output, would there be a way to easily deactivate the Swagger UI component?

The sample query link should be its own PR will only those changes. Can you revert. This PR otherwise was good to merge.

authors: MaximRouiller dtuyishime timotheeguerin

repo: microsoft/cadl


text:
POSSIBILITA' DI STABILIRE QUANTITA' CIFRE DOPO LA VIRGOLA E CONSEGUENTE ARROTONDAMENTO -5=0 +5=1

ho fatto l'iscrizione per questo problema che non riesco a risolvere nella calcolatrice
di Microsoft

Faccio un lavoro di contabilità per il quale mi bastano numeri con due ordini dopo la virgola e con l'arrotondamento come spiegato.

I think this suggestion is the same idea as #485.

repo: microsoft/calculator


text:
Teams JS Citations Patch

Teams AI just released a new patch for the JS Teams citations experience fixing an issue of citations not rendering/working as expected.
Ryan Bliss was running the custom agent copilot lab yesterday and the update helped with him getting a data.response.context issue being always undefined. Switching to the @microsoft/teams-ai@1.5.3 and openai@4.68.2 packages helped address this.
I'm not sure if other people have run into this issue, but I wanted to share it here.

Thanks for posting @Carter425 - this solved my problem on the Copilot camp B3 citations lab

thanks @Carter425 for bringing this up. We'll be updating the lab source codes however, our labs start from scratch using Teams Toolkit, therefore these versions should be updated in Teams Toolkit templates too. cc/ @therealjohn

authors: Carter425 aycabas tinsheep

repo: microsoft/copilot-camp


text:
Feature: Support C++20 std::format for cppwinrt types (e.g. winrt::hstring)

Version
No response
Summary
std::format is a new C++ language feature that has some nice features for producing strings with data bound to them.  It is possible to write std::formatter implementations that support additional types so that they can be natively used with std::format without requiring manual adaptation such as calling .c_str().
It would be nice if the various cppwinrt types, especially winrt::hstring had a formatter implementation so they work natively.  Bonus points if things like winrt::hresult or winrt::hresult_error also could be printed easily.
Reproducible example
winrt::hstring myString{ L"MyString" };
std::format("My string is {0}", myString);

Expected behavior
Compiles and prints "My string is MyString"
Actual behavior
Build break
1>C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.40.33807\include\format(3567,23): error C2039: 'parse': is not a member of 'std::formatter<std::_Compile_time_parse_format_specs::_FormattedType,std::_Compile_time_parse_format_specs::_CharT>'
1>c:\source\repos\EmptyCppwinrtProgram\EmptyCppwinrtProgram\main.cpp(47,37): error C3615: consteval function 'std::_Compile_time_parse_format_specs' cannot result in a constant expression

Additional comments
No response

There is a formatter for winrt::hstring already - however since hstrings are wide, you need a corresponding wide format string. This should work: std::format(L"My string is {0}", myString);

You're right.  Not sure how I missed that 🤦.
I see this in <winrt/base.h>
#ifdef __cpp_lib_format
template<>
struct std::formatter<winrt::hstring, wchar_t> : std::formatter<std::wstring_view, wchar_t> {};
#endif

authors: dmachaj sylveon

repo: microsoft/cppwinrt


text:
RISC-V Support

I know there are issues[1..] in the specific repos for RISC-V bring up, but I'm hoping that there's a meta issue to show the progress of the bring up.
What incentivised me to make this issue is that RISC-V International has asked its members if there is anything missing from their "Ecosystem Landscape", dotnet is one glaring omission.
https://lists.riscv.org/g/allmem/message/220
One of the stipulations is that there is

Note that the submission form requires a link to a website/whitepaper/other proof of RISC-V support (existing, not just planned)

I'm lead to believe that several pieces have been merged and bring some support, but I haven't seen any evidence of RISC-V support outside of those pull requests.
Any help documenting the status and submitting an update proposal would be much appreciated.

https://github.com/dotnet/runtime/issues/36748
https://github.com/dotnet/runtime/issues/75749
https://github.com/dotnet/runtime/issues/84834

I'm going to move to the runtime repo since anything would start there.

@danmoseley yeah I was hoping to have a "meta" issue that overarches all the components of dotnet for the RISC-V platform, runtime, compiler, debugger etc etc

There doesn't seem to be much interest in .NET open source IoT platforms, which is likely the target market for RISC-V at the moment.

I'd have to politely disagree with this sentiment 🙂
I would suggest the nanoFramework would be more suitable for the domain you're interested in, which already has (some? all?) support for RISC-V.
With server grade RISC-V machines (rack mount 1U too) due out next month, having the full blown dotnet experience would be highly desirable. Including Dev and deployment.

I'd have to politely disagree with this sentiment slightly_smiling_face

Ah, well yeah I know its desirable.  It's just this was posted on Microsofts repo, and there doesn't seem to be much interest from Microsoft to support RISC-V right now.  Community efforts, which are showing signs of picking up, is slow.
There are some interesting low powered RISC-V SOC devises appearing, notably the BL808 which sit between MCUs and CPU's, which would be ideal for IoT, and full .NET (instead of nanoFramework).

@danmoseley yeah I was hoping to have a "meta" issue that overarches all the components of dotnet for the RISC-V platform, runtime, compiler, debugger etc etc

Yep of course it's fine to continue here, just wanted to point out that the committer folks usually involved in this kind of discussion (like @jkotas) are all generally in the other repo.

https://github.com/dotnet/runtime/issues/36748 is currently the best place to track overall progress of the RISC-V .NET port and ask questions about it.

authors: 0xStuart archanox danmoseley jkotas

repo: microsoft/dotnet


text:
eBPF tutorial is out of date - Hooks and arguments

The Hooks and arguments section is out of date. It still says the context data is in https://github.com/microsoft/ebpf-for-windows/blob/main/libs/api_common/windows_platform_common.cpp which is no longer true.

@jsturtevant was this addressed in PR #1414?  If so, can this be closed now?

Clearing triaged tag since this didn't mark "help wanted" or get assigned to anyone, but might be fixed in 1414 so good to review/update in triage meeting.

authors: Alan-Jowett dthaler

repo: microsoft/ebpf-for-windows


text:
Setup - Unable to setup via pip on Windows machine and few other installation questions

Topic
FarmVibes.AI setup
Ask away!
@rafaspadilha @renatolfc - Is having a Linux based system such as Ubuntu or WSL is a hard requirement?
I have a windows 11 machine and I have been un-successful

installing vibe_core package through pip install src/vibe_core command, It usually stuck at the step, unable to build wheel for vibe-core error
At the same time, I was not able to create a venv using micromamba, it also fails at the same step with similar error.

I use Python on Windows for many projects and I have never been limited by this. Due to some security reasons it is impossible for me to get WSL on my corporate machine. So I have live with this limitation for the time being.
So, there are two scenarios:-

Installing a VM - Do we need a Linux or WSL to work through this? Because, how would one connect to Jupyter SERVER running on a VM through their local machines if one is unable to install these python modules or notebook related environment on our local machine?
Via AKS - Even to connect to a AKS backed installation, how would one connect to its Jupyter server via a notebook running on ones local if they are unable to install?
-  In your documentation to use Cloud Shell, I was able to install it via this approach, however problem comes if I lose this cloud shell because of hibernation/termination of shell. Since the installation process install a lot of configuration files to work with client = get_default_vibe_client("remote") like calls, once a shell is lost you basically lose all configuation you got during installation thereby rendering and connecting with installation tricky and with workarounds.

On a side note to clear some doubts:-
How would you connect to let say Jupyter server running on either types(VM or AKS) if one is unsuccessful to install required packages? Can you please help/guide how would the process looks like?
Regards,
Chetan

Hello @csharma2309.

Do we need a Linux or WSL to work through this?

No. But building local clusters on Windows hosts is not supported.

I use Python on Windows for many projects and I have never been limited by this.

In the following, I'm using Python installed with winget install python and I'm also assuming a PowerShell session. Please adapt the steps accordingly.
It might be the case that your local copy of pip needs upgrading. I'd recommend creating a new virtualenv (with python -m venv venv), activating it (with venv\Scripts\Activate.ps1) and upgrading pip (with pip install --upgrade pip).
After you've done that, please try installing vibe_core with
pip install -e "git+https://github.com/microsoft/farmvibes-ai.git#egg=vibe_core&subdirectory=src/vibe_core"

I've just followed the above steps in a brand new machine and the farmvibes-ai command was installed successfully. Here's a step-by-step log of the above instructions:

...

In general, if you are having issues with the steps we shared, it helps a lot to share logs or screenshots or some sort of description of what exactly you tried and how it fails fails.
From the description of your error, I am assuming your local pip copy is too old to support installs with pyproject.toml files (which we use in our setup process).

Thanks @renatolfc for providing detailed steps. I followed these steps and I was able to install farmvibes-ai and it was accessible.
I also upgraded before running these commands. I have tried many solutions through stackoverflow before posting here. None of them worked.
Now other question is now when I am installing a particular env to run a notebook via micromamba, I am getting following errors.
  copying lib\cartopy\tests\mpl\baseline_images\mpl\test_ticks\yticks_cylindrical.png -> build\lib.win-amd64-cpython-38\cartopy\tests\mpl\baseline_images\mpl\test_ticks
  copying lib\cartopy\tests\mpl\baseline_images\mpl\test_ticks\yticks_no_transform.png -> build\lib.win-amd64-cpython-38\cartopy\tests\mpl\baseline_images\mpl\test_ticks
  creating build\lib.win-amd64-cpython-38\cartopy\tests\mpl\baseline_images\mpl\test_web_services
  copying lib\cartopy\tests\mpl\baseline_images\mpl\test_web_services\wms.png -> build\lib.win-amd64-cpython-38\cartopy\tests\mpl\baseline_images\mpl\test_web_services
  copying lib\cartopy\tests\mpl\baseline_images\mpl\test_web_services\wmts.png -> build\lib.win-amd64-cpython-38\cartopy\tests\mpl\baseline_images\mpl\test_web_services
  creating build\lib.win-amd64-cpython-38\cartopy\data
  creating build\lib.win-amd64-cpython-38\cartopy\data\raster
  creating build\lib.win-amd64-cpython-38\cartopy\data\raster\natural_earth
  copying lib\cartopy\data\raster\natural_earth\50-natural-earth-1-downsampled.png -> build\lib.win-amd64-cpython-38\cartopy\data\raster\natural_earth
  copying lib\cartopy\data\raster\natural_earth\images.json -> build\lib.win-amd64-cpython-38\cartopy\data\raster\natural_earth
  creating build\lib.win-amd64-cpython-38\cartopy\data\raster\sample
  copying lib\cartopy\data\raster\sample\Miriam.A2012270.2050.2km.jpg -> build\lib.win-amd64-cpython-38\cartopy\data\raster\sample
  copying lib\cartopy\data\raster\sample\Miriam.A2012270.2050.2km.README.txt -> build\lib.win-amd64-cpython-38\cartopy\data\raster\sample
  creating build\lib.win-amd64-cpython-38\cartopy\data\netcdf
  copying lib\cartopy\data\netcdf\HadISST1_SST_update.nc -> build\lib.win-amd64-cpython-38\cartopy\data\netcdf
  copying lib\cartopy\data\netcdf\HadISST1_SST_update.README.txt -> build\lib.win-amd64-cpython-38\cartopy\data\netcdf
  creating build\lib.win-amd64-cpython-38\cartopy\data\shapefiles
  creating build\lib.win-amd64-cpython-38\cartopy\data\shapefiles\gshhs
  copying lib\cartopy\data\shapefiles\gshhs\README.TXT -> build\lib.win-amd64-cpython-38\cartopy\data\shapefiles\gshhs
  creating build\lib.win-amd64-cpython-38\cartopy\data\shapefiles\gshhs\c
  copying lib\cartopy\data\shapefiles\gshhs\c\GSHHS_c_L1.dbf -> build\lib.win-amd64-cpython-38\cartopy\data\shapefiles\gshhs\c
  copying lib\cartopy\data\shapefiles\gshhs\c\GSHHS_c_L1.shp -> build\lib.win-amd64-cpython-38\cartopy\data\shapefiles\gshhs\c
  copying lib\cartopy\data\shapefiles\gshhs\c\GSHHS_c_L1.shx -> build\lib.win-amd64-cpython-38\cartopy\data\shapefiles\gshhs\c
  creating build\lib.win-amd64-cpython-38\cartopy\data\shapefiles\gshhs\l
  copying lib\cartopy\data\shapefiles\gshhs\l\GSHHS_l_L2.dbf -> build\lib.win-amd64-cpython-38\cartopy\data\shapefiles\gshhs\l
  copying lib\cartopy\data\shapefiles\gshhs\l\GSHHS_l_L2.shp -> build\lib.win-amd64-cpython-38\cartopy\data\shapefiles\gshhs\l
  copying lib\cartopy\data\shapefiles\gshhs\l\GSHHS_l_L2.shx -> build\lib.win-amd64-cpython-38\cartopy\data\shapefiles\gshhs\l
  creating build\lib.win-amd64-cpython-38\cartopy\tests\lakes_shapefile
  copying lib\cartopy\tests\lakes_shapefile\ne_110m_lakes.dbf -> build\lib.win-amd64-cpython-38\cartopy\tests\lakes_shapefile
  copying lib\cartopy\tests\lakes_shapefile\ne_110m_lakes.shp -> build\lib.win-amd64-cpython-38\cartopy\tests\lakes_shapefile
  copying lib\cartopy\tests\lakes_shapefile\ne_110m_lakes.shx -> build\lib.win-amd64-cpython-38\cartopy\tests\lakes_shapefile
  copying lib\cartopy\io\srtm.npz -> build\lib.win-amd64-cpython-38\cartopy\io
  running build_ext
  building 'cartopy.trace' extension
  creating build\temp.win-amd64-cpython-38
  creating build\temp.win-amd64-cpython-38\Release
  creating build\temp.win-amd64-cpython-38\Release\lib
  creating build\temp.win-amd64-cpython-38\Release\lib\cartopy
  "C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\14.33.31629\bin\HostX86\x64\cl.exe" /c /nologo /O2 /W3 /GL /DNDEBUG /MD -I. -I./lib/cartopy -IC:\Users\chetan.sharma\AppData\Locj
  trace.cpp
  lib/cartopy/trace.cpp(767): fatal error C1083: Cannot open include file: 'geos_c.h': No such file or directory
  error: command 'C:\\Program Files\\Microsoft Visual Studio\\2022\\Professional\\VC\\Tools\\MSVC\\14.33.31629\\bin\\HostX86\\x64\\cl.exe' failed with exit code 2
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for cartopy
Successfully built vibe-core
Failed to build cartopy
ERROR: Could not build wheels for cartopy, which is required to install pyproject.toml-based projects
critical libmamba pip failed to install packages

Hi. That new error is a bit more complicated. What notebook env is that?

Hello @csharma2309,
I found the root cause of the issue, and it is due to us specifying a pip dependency when it should have been a conda-forge dependency when on Windows.
I'll submit a patch later, but right now, to fix your environment, save the following patch to a file (for example fix.diff) and apply it with git apply fix.diff.
This should fix your environment while we don't open a PR with the fix.
diff --git a/notebooks/env.yaml b/notebooks/env.yaml
index 6fc0228d..c4bc145e 100644
--- a/notebooks/env.yaml
+++ b/notebooks/env.yaml
@@ -4,6 +4,7 @@ channels:
   - defaults
 dependencies:
   - python==3.8.*
+  - cartopy~=0.21.0
   - geopandas~=0.11.1
   - ipython~=8.5.0
   - ipywidgets~=8.0.2
@@ -19,5 +20,4 @@ dependencies:
   - scikit-image~=0.20.0
   - pip:
       - ../src/vibe_core
-      - cartopy~=0.21.0
       - xarray~=2022.10.0

@renatolfc - thanks for the update. I will try this tomorrow and will update this thread! Much appreciate your help

@chetan2309, any update on this end?

repo: microsoft/farmvibes-ai


text:
Fix for progress bar accessibility trait bug

Platforms Impacted

[x] iOS
[ ] macOS

Description of changes
When selecting the progress bar in the UIKit demo, VoiceOver would say "button", but nothing would happen in the SwiftUI demo. It appears this had nothing to do with the progress bar, but it was the TableViewCell in the UIKit demo that has accessibility traits set to button by default which is what VoiceOver was reading out. The updatesFrequently trait was added to the progress bar.
Verification

Before
After

https://user-images.githubusercontent.com/106181067/180839351-93739efb-d23d-4f5a-ad8e-31d583a62af6.mov
https://user-images.githubusercontent.com/106181067/180839514-f1098094-fdc4-4f7f-b3e0-bd72a7109963.mov

Pull request checklist
This PR has considered:

[ ] Light and Dark appearances
[ ] iOS supported versions (all major versions greater than or equal current target deployment version)
[x] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
[ ] iPad Pointer interaction
[ ] SwiftUI consumption (validation or new demo scenarios needed)
[ ] Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow

please attach video for before and after

@laminesm : the after video doesn't seem to have any different behavior?

what's Apple native activity indicator behavior? and how can we mimic it? as a back up plan, we do have localized string ""Accessibility.ActivityIndicator.Animating.label" ?

authors: harrieshin laminesm

repo: microsoft/fluentui-apple


text:
Using Sphinx for docs/web

Closes #325

Codecov Report

Merging #343 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   91.33%   91.33%
=======================================
  Files          57       57
  Lines        3242     3242
  Branches      634      634
=======================================
  Hits         2961     2961
  Misses        146      146
  Partials      135      135

Flag
Coverage Δ

#unittests
91.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02f310a...1f9a5a9. Read the comment docs.

@interesaaat - I opened #344 about the weirdness with torch that caused this morning's pipeline battle.
I think that if we merge this to master that the final step of the pipeline will fire (name: Deploy to GitHub pages).

authors: codecov-io ksaur

repo: microsoft/hummingbird


text:
Inshellisense with oh-my-bash stops working after the first executed command

Describe the bug
While entering the first command, the window with suggestion appears. Once I pick any subcommand/flag, it turns off and does not work for the next input. After inshellisense started working with this fix: https://github.com/microsoft/inshellisense/pull/200, it turned out that it worked just for a single command.
To Reproduce
Steps to reproduce the behavior:

Install oh-my-bash and latest inshellisense (9907244548ee0a2a5890206cdf060bf1e7b5c065)
Write the part of the first command, the window with suggestion appears, select any of these, press enter to call it.
Write another command, this time the window does not appear anymore.

Expected behavior
Inshellisense should support all commands when the session is live.
Environment

OS: Windows 11, running Debian in WSL2
Output of is --version: 0.0.1-rc.9, but running commit 9907244548ee0a2a5890206cdf060bf1e7b5c065
Nodejs Version: v18.19.0
Shell: bash + oh-my-bash
Shell Version: 5.2.15(1)-release (x86_64-pc-linux-gnu)

Additional context
I recorded a small sample and uploaded it on YouTube to make it easier to get what's happening, here's the link: https://youtu.be/L30cOTPP14E

For reference, this is what I think is happening:
I have setup hooks to inject the inshellisense prompt bytes into the prompt for every case except for when a $PROMPT_COMMAND decides to re-write $PS1 after the precmd hook is triggered.

@whiskeyo let me know if you run into any other issues

I got the same issue. How did you fixed that @cpendery ?

Same for me with zsh/omz.

Same for me with zsh/omz, WSL2 - Ubuntu 24.10. With W11 pwsh and oh-my-posh it works like a charm.

This should be fixed in 0.0.1-rc.17 which I'll be releasing soon. Please let me know if it doesn't work after upgrading and making all the changes recommended by is doctor

@cpendery
Still happening on 0.0.1-rc.18 with oh-my-zsh while using powerlevel10k.
After the first command is sent it doesn't show anymore.

@cpendery Still happening on 0.0.1-rc.18 with oh-my-zsh while using powerlevel10k. After the first command is sent it doesn't show anymore.

Can you paste your .zshrc here? It might be the instant prompt from powerlevel10k or the ordering of your configs that is causing the issue

authors: IgorMCesar cdevacc1 cpendery kruzyk whiskeyo

repo: microsoft/inshellisense


text:
Schema link not found - .pbir visualContainer 1.4.0

Apologies if this is not the correct way to raise this issue.
As of the November update, Power BI forces visual.json files to use:
{
    "$schema": "https://developer.microsoft.com/json-schemas/fabric/item/report/definition/visualContainer/1.4.0/schema.json",
    ...
}

But this schema is unavailable, breaking code completion, etc.
I'm guessing the 1.40 version has not been pushed to developer.microsoft.com, or is not open to the public :(
(I have not yet checked every other schema to know if any other schema links are currently broken, so the issue might extend beyond visualContainer 1.4.0)
Cheers :)

Hooray, the schema has been made public, so this issue is now resolved.
Cheers :)

repo: microsoft/json-schemas


text:
[Feature request] Is there a release date for the FromConfiguration method to come back?

Context / Scenario
In my project, I was using the KernelMemoryBuilder.FromConfiguration extension method, but after a package update I can't do it anymore.
I saw the method has been reduced and is now present in the package named "Microsoft.KernelMemory.Service". The thing is I can't find the nuget package for my project so I can't use the method anymore.
What happened?
You already responded to me that the Service project where the method is is not deployed. I already tried to import only the data I need but it requires to copy all the Service project.
Importance
a fix would make my life easier
Platform, Language, Versions
.net, last Microsoft.KernelMemory.Core version
Relevant log output
No response

See https://github.com/microsoft/kernel-memory/issues/283

authors: MaxenceBoucquez dluc

repo: microsoft/kernel-memory


text:
Python - support for headers inspection

see #2963 and related pull requests

depends on #3430

Resolved by https://github.com/microsoft/kiota-http-python/pull/255

authors: baywet samwelkanda

repo: microsoft/kiota


text:
Add support for links in diagnostics

VS Code added API to support links in diagnostics. We should investigate if we adopt this in LSP.

I'm currently showing urls via diagnostics, they are just not linked.

Relevant VS Code issue is microsoft/vscode#11847

Is there any further updates on this feature-request?

I think the current state is it being proposed via https://github.com/microsoft/vscode-languageserver-node/commit/fa9ccc4f2eff73d6b0e96bb59086fb8fba4eb88c
https://github.com/microsoft/vscode-languageserver-node#3160-next1-protocol-510-next1-json-rpc-620-next1-client-and-620-next1-server

This got implemented and is documented in the 3.16 spec.

authors: KamasamaK Razzeee dbaeumer dvandra

repo: microsoft/language-server-protocol


text:
Installation & Setup

Description
Referring to the installation instructions, I had to make m365proxy executable with chmod +x on the file
Expected behaviour
File is executable after unzipping it
or
the documentation is updated
Actual behaviour
Executable is opened showing executable code in a "windows"
Steps to reproduce
Download osx64, unzip it
Microsoft 365 Developer Proxy Version
0.12.1
Operating system (environment)
macOS
Shell
zsh
Additional Info
No response

Thank you for letting us know @ferrarirosso 👍
Apologies for the inconvenience. We will get the instructions updated.

Added a new step to the macOS instructions to make the file an executable.
Thanks again for reporting @ferrarirosso 👍

@garrytrinder thx !

authors: ferrarirosso garrytrinder


text:
Create MS owned demo environment

[ ] Create MIP environment
[ ] Create Purview environment
[ ] Create PBI Auditing
[ ] Create PBI environment
[ ] Create M365 environment (inc Teams/SP/mailboxes)
[ ] Create File Share
[ ] Create Data Lake and Databases

Created the MIP Environment Demo environment. Will build out with additional classification schema once defined.


text:
BlazorWebView & WindowsAppSDK - WebView2 DLL missmatch

This issue has been moved from a ticket on Developer Community.

[severity:I’m unable to use this version]
We are developing an WPF Blazor Hybrid app. The app also makes use of various features provided by the WindowsAppSDK library. Since we updated the WindowsAppSDK to version 1.6 the BlazorWebView cannot be instantiated anymore due to the following runtime exception:
System.Windows.Markup.XamlParseException
  HResult=0x80131501
  Message='The invocation of the constructor on type 'Microsoft.AspNetCore.Components.WebView.Wpf.BlazorWebView' that matches the specified binding constraints threw an exception.' Line number '15' and line position '10'.
  Source=PresentationFramework
  StackTrace:
   at System.Windows.Markup.XamlReader.RewrapException(Exception e, IXamlLineInfo lineInfo, Uri baseUri)
   at System.Windows.Markup.WpfXamlLoader.Load(XamlReader xamlReader, IXamlObjectWriterFactory writerFactory, Boolean skipJournaledProperties, Object rootObject, XamlObjectWriterSettings settings, Uri baseUri)
   at System.Windows.Markup.WpfXamlLoader.LoadBaml(XamlReader xamlReader, Boolean skipJournaledProperties, Object rootObject, XamlAccessLevel accessLevel, Uri baseUri)
   at System.Windows.Markup.XamlReader.LoadBaml(Stream stream, ParserContext parserContext, Object parent, Boolean closeStream)
   at System.Windows.Application.LoadComponent(Object component, Uri resourceLocator)
   at BlazorWpf1.MainWindow.InitializeComponent() in C:\Users\jonas\Downloads\BlazorWpf1\BlazorWpf1\MainWindow.xaml:line 1

  This exception was originally thrown at this call stack:

Inner Exception 1:
FileNotFoundException: Could not load file or assembly 'Microsoft.Web.WebView2.Wpf, Version=1.0.2592.51, Culture=neutral, PublicKeyToken=2a8ab48044d2601e'. The system cannot find the file specified.

The following two NuGet packages that we are using seem to be causing this conflict:
<ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.Components.WebView.Wpf" Version="8.0.92" />
    <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.6.240923002" />
</ItemGroup>

The following findings where the result of our own investigation of the problem:

When removing the reference to the WindowsAppSDK the BlazorWebView can be instantiated
A DLL Microsoft.Web.WebView2.Wpf is not present in the binary folder, a DLL Microsoft.Web.WebView2.Core is present
Version 1.5 of the WindowsAppSDK does work without a problem (this is our current workaround to fallback to the old version)
The VisualStudio version used for compilation seems to have an impact (see below)
The following BlogPost states changes in the way the WebView is used in the WindowsAppSDK. Could this be related?https://blogs.windows.com/windowsdeveloper/2024/09/04/whats-new-in-windows-app-sdk-1-6/

We noticed that the VisualStudio update also has an influence. With version 17.10 the project with the lastest versions of the libraries could not be compiled and raised the compilation error:
Severity	Code	Description	Project	File	Line	Suppression State	Details
Error (active)		This version of the Windows App SDK requires Microsoft.Windows.SDK.NET.Ref 10.0.17763.38 or later.
    Please update to .NET SDK 6.0.134, 6.0.426, 8.0.109, 8.0.305 or 8.0.402 (or later).
    Or add a temporary Microsoft.Windows.SDK.NET.Ref reference which can be added with:
        <PropertyGroup>
            <WindowsSdkPackageVersion>10.0.17763.38</WindowsSdkPackageVersion>
        </PropertyGroup>

Updating to 17.11 fixed the compilation error but the runtime error remained. With VisualStudio Version 17.10, adding the WindowsSdkPackageVersion tag in the project file as states in the compiler error message allowed for successful compilation but the runtime error remains.
The problem can be reproduced by the following steps:

Follow the steps of the official tutorial for a minimal WPF BlazorHybrid app: https://learn.microsoft.com/en-us/aspnet/core/blazor/hybrid/tutorials/wpf?view=aspnetcore-8.0
Add a Package reference to the Microsoft.WindowsAppSDK version 1.6+
Set the target framework of the project to at least net8.0-windows10.0.17763.0
Run the app to provoke the error

Attached is a premade sample project to reproduce the problem:
BlazorWpf1.zip

Original Comments
Feedback Bot on 10/29/2024, 07:48 PM:
We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

@codendone is this error something you've encountered before?

From the logs, it looks like you are using an older WebView2 SDK Microsoft.Web.WebView2.Wpf, Version=1.0.2592.51. Can you please try with the latest SDKs https://www.nuget.org/packages/Microsoft.Web.WebView2/1.0.2895-prerelease OR https://www.nuget.org/packages/Microsoft.Web.WebView2/1.0.2849.39

authors: karkarl oggy22 vsfeedback

repo: microsoft/microsoft-ui-xaml


text:
ListView does not report IsOffscreen correctly

Describe the bug

ListView is not correctly reporting when it is offscreen.
Steps to reproduce the bug

Repro can be achieve by creating an empty UWP app and adding a single element to it:
    <ListView Margin="500,500,0,0">
        <ListView.Items>
            <ListViewItem Content="Test" />
            <ListViewItem Content="Test" />
        </ListView.Items>
    </ListView>

Resizing the window to move the list view out of bounds will cause AccessibilityInsights to report an issue: the ListView's IsOffscreen property is not set to true.
Additional context

Copied from internal bug

FYI: The Accessibility Insights team has received a bug based on this issue: https://github.com/microsoft/axe-windows/issues/387
We believe the error is not a false positive, and will reference this issue. Glad you have a bug for this!

Hi, any progress with this issue, or fix plan?

Hi @YuliKl , this bug is auto closed by BOT. Could you please create a new bug and provide tracking ID. Thanks!

@PadminiGariki does this still repro? There have been fixes in WinUI3 for this and I do not see it repro in WinUI3 Gallery ListView page anymore.

authors: RobGallo YuliKl aniketr99 giladtaase ranjeshj


text:
xaml generate wrong code when bind  Windows.Foundation.Size type in TwoWay mode

GetDataRoot().Attributes().as<::winrt::Velkhana::ImageGaussianBlurData>().kSize().Width(static_cast<float>(obj5.Value()));

compile error(because width is not a function):
error C2064: term does not evaluate to a function taking 1 arguments

Width is a member variable and not a property accessor. The correct code should be: GetDataRoot().Attributes().as<::winrt::Velkhana::ImageGaussianBlurData>().kSize().Width = static_cast<float>(obj5.Value());

Width is a member variable and not a property accessor. The correct code should be: GetDataRoot().Attributes().as<::winrt::Velkhana::ImageGaussianBlurData>().kSize().Width = static_cast<float>(obj5.Value());

yeah,you are right!(. ❛ ᴗ ❛.)

Hi @shelllet could you provide us with more details about your repro (what your markup looks like and the data structure that it is binding to) so we can be sure we fix the right thing? Thanks!

Ok, I will take three minutes and upload a demo to siumlate this errror.

Hi @shelllet could you provide us with more details about your repro (what your markup looks like and the data structure that it is binding to) so we can be sure we fix the right thing? Thanks!

https://github.com/shelllet/TwoWayMode/tree/master

Thanks!

Please don't forget to fix  Wndows.Foundation.Rect type, etc.

authors: Jaiganeshkumaran alwu-msft shelllet


text:
MUX-CI submits multiple Helix jobs with the same name, preventing access to the logs

E.g.
https://dev.azure.com/ms/microsoft-ui-xaml/_build/results?buildId=20226&view=logs
Cannot access the Helix logs for the main test pass as they got overwritten by the NuGet tests logs.

Have a fix here:
user/kmahone/helixtesttype
Testing the fix here:
https://dev.azure.com/ms/microsoft-ui-xaml/_build/results?buildId=20271


text:
NumberBox: Heaps of bug fixes

Now validates input when the Text() property changes. Also, the Text() property is now updated in SetTextToValue().
Maximum is now coerced to be >= Minimum.
Trims whitespace from input strings so that " 5 " now evaluates to 5 instead of an error.
Only sends ValueChanged once instead of twice if input is invalid.
Replaces the text even if Value hasn't changed (e.g. if Value is 5, user types "2+3", text should still be replaced with "5")
Header is now an object instead of a string. Also added HeaderTemplate as a property.
When the control gets focus, it selects the text in the textbox. On evaluation, the caret moves to the end of the string.

Added tests for all of the above, as well as a better test for custom NumberFormatter that proves alternate decimal characters work.

@StephenLPeters, can you take a look? :)


text:
[Accessibility] Color Contrast: Color contrast ratio for numbers in light theme in the editor is 4.48:1 < 4.5:1

monaco-editor version: 0.14.3
Browser: Chrome, version 72.0.3
OS: Windows 10
Steps or JS usage snippet reproducing the issue:

Use the light theme for monaco editor.
Inspect the color contrast for number values in json.

This is less than the required contrast according to aria-rules which is 4.5:1

The editor ships with a high contrast theme. The embedder can use it when desired, the editor switches to it when the OS has high contrast, and the end user can activate it via F1 > Toggle High Contrast Theme. See more at https://github.com/microsoft/monaco-editor/wiki/Accessibility-Guide-for-Integrators

This has been fixed in the meantime, but my comment above is incorrect.
The default color of number tokens inside the editor has been changed to #098658 which has a contrast ratio of 4.599 against #fffffe. The fix is available in the latest monaco editor realease.

repo: microsoft/monaco-editor


text:
[Bug] hideUnchangedRegions feature not supported in Monaco editor

Reproducible in vscode.dev or in VS Code Desktop?

[X] Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

[ ] Not reproducible in the monaco editor playground

Monaco Editor Playground Link
Playground link
Monaco Editor Playground Code
const originalModel = monaco.editor.createModel(
	/* set from `originalModel`: */ `[
  {
    "_id": "651d1c1e7375a78f810eb946",
    "index": 0,
    "guid": "23d98f76-46b2-499b-b4e0-1b4dbb94461e",
    "isActive": true,
    "balance": "$2,805.46",
    "picture": "http://placehold.it/32x32",
    "age": 29,
    "eyeColor": "green",
    "address": "717 Borinquen Pl, Deputy, Arkansas, 7694",
    "about": "Aliquip eu consectetur consequat sint sit amet labore culpa ea consectetur non. Ea tempor minim Lorem ad sint non anim amet reprehenderit. Est enim officia quis aliqua sunt eiusmod. Veniam enim est esse eiusmod aute excepteur et ex labore enim id deserunt. Id nulla cupidatat dolor anim aute id. Aute sint exercitation et ipsum consectetur incididunt quis aute magna ad do.\r\n",
    "registered": "2020-02-13T12:45:41 -06:-30",
    "latitude": -81.908386,
    "longitude": 29.700776,
    "tags": [
      "cupidatat",
      "laborum",
      "ex",
      "tempor",
      "non",
      "aliquip",
      "labore"
    ],
    "friends": [
      {
        "id": 0,
        "name": "Charlene Kelley",
        "gender": 0
      },
      {
        "id": 1,
        "name": "Frieda Yang",
        "gender": 1
      },
      {
        "id": 2,
        "name": "Marietta Olson",
        "gender": 2
      }
    ],
    "greeting": "Hello, undefined! You have 5 unread messages.",
    "favoriteFruit": "banana"
  }
]`,
	"json"
);
const modifiedModel = monaco.editor.createModel(
	/* set from `modifiedModel`: */ `[
  {
    "_id": "651d1c1e7375a78f810eb946",
    "index": 0,
    "guid": "23d98f76-46b2-499b-b4e0-1b4dbb94461e",
    "isActive": true,
    "balance": "$2,805.46",
    "picture": "http://placehold.it/32x32",
    "age": 29,
    "eyeColor": "green",
    "address": "717 Borinquen Pl, Deputy, Arkansas, 7694",
    "about": "labore culpa ea consectetur non. Ea tempor minim Lorem ad sint non anim amet reprehenderit. Est enim officia quis aliqua sunt eiusmod. Veniam enim est esse eiusmod aute excepteur et ex labore enim id deserunt. Id nulla cupidatat dolor anim aute id. Aute sint exercitation et ipsum consectetur incididunt quis aute magna ad do.\r\n",
    "registered": "2020-02-13T12:45:41 -06:-30",
    "latitude": -81.908386,
    "longitude": 29.700776,
    "tags": [
      "cupidatat",
      "laborum",
      "ex",
      "tempor",
      "non",
      "aliquip",
      "labore"
    ],
    "friends": [
      {
        "id": 0,
        "name": "Charlene Kelley",
        "gender": 0
      },
      {
        "id": 1,
        "name": "Frieda Yang",
        "gender": 1
      },
      {
        "id": 2,
        "name": "Marietta Olson",
        "gender": 2
      }
    ],
    "greeting": "Hello, undefined! You have 5 unread messages.",
    "favoriteFruit": "banana"
  }
]`,
	"json"
);

const diffEditor = monaco.editor.createDiffEditor(
	document.getElementById("container"),
	{
		originalEditable: false,
		folding: true,
        hideUnchangedRegions: {
			enabled: true,
			revealLineCount: 40,
			minimumLineCount: 1,
			contextLineCount: 1

		}
}

);
diffEditor.setModel({
	original: originalModel,
	modified: modifiedModel,
});

Reproduction Steps
add hideUnchangedRegions flag in the diff editor constructor
Actual (Problematic) Behavior
The code does not hide the unchanged regions
Expected Behavior
the editor should hide the unchanged parts as it does in vs code
Additional Context
No response

Any help on the above will be appreciated

This works in the latest dev version.

@hediet   still not working in 0.45.0-dev-20231025

It works here: https://microsoft.github.io/monaco-editor/playground.html?source=v0.44.0#XQAAAAKNDAAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscxN8ZDRgmSatbNyrNa50VLHWwDOn0YI7IfU0xJ0CGYU1vRtgnKPmZzQcQ1F9I-F9YcvQUj8HivueDk6xk10aTwPyPDY1IBeJL_Xrbs1KKyeqLKZPBn0ReUGdf3GCX0E5fOjobC1gO-Gs_tWPtf8Kc2pyFEsuajrzISjO__HXK0zh1WHy05Ke7FkVtouSZxeCTxyFvUHefvs3mpLifnyfnk6CRHqeeI6IeV4eEKZYFmCOuCIdU8HMNnrqgRp_qKa3ZXMWA-KsVsQ4qfGKl110NcSnumZteetmavGeLroTfjOrTRfzT2UqEq3A_W9RIOLvllWCYqiHy9KA0Tlu1LEr1f5NMBrH7OnhEKlCIRGRIaVVF-kd-x0YTxjir1s0g_y8dPbtkVea0aZ5beVgodYeATvKuknPafnO0iKq43aApM0pqC51z_vqbGgwf-1yNpntqJ6qXXNlTHytqXhaixzjMYft9acJJcUjqcqp2z9uQgzDOjDJokQastD9TjjcNQS8OHR68PqE-kiSDjVhMJpRgosVUHvSbP_-VKLDLzPvG1KW4fRShNCvfggYv7VUhyDN_aDQMqhH4k8ADPJrBp48iT_xK_S498unqGbE_vKqtfsXAoB9lI2xZCJBjmoQPyM9DgyOPTv6djeySo6mGaaj7bnLqsXYZY52ih8umPbu8PBMKgtMuydkRnuuLl5msUmWCVGPghmGLSSTm0QwjryyoR5L2FYs0XZc42_ntbCzpfnuGUX8GCHIh8U-JAiRZBjjGHqO3CjFu4fWfs13lyFfhcYQk18x0cm7TPCpB0j72pgZwdOVfqmsHcrmhWGI2MUJBcFyccalt5R8RLn7JkMGuyn-h5MPwGUaAVOU8mgbqaDOcg3fKt4dUIghWrm-oUpVdaK-RYIu1UmgV8L1GpwCUMS1sinFl7XV2BF7E1_L69pkTsItJWBD-EakYdmEZ4Qp01XozkOmaAAO6Apt91CfSjxrXO_yHcj3Nv7HxK2YkxMq3-vlomh5Zm4IbhfEsV9sSKcj1MC_Mo4cIFzt_bvk6sNoRD4V32PJBGEdVgRpDqdALVrPc_MKzOlHZocpW7Hh7dsp2Ou6kfSGComSIv3GJXKK3ucuzK9WWfUN-RK83eS0RVVtqTCqnfpqgn1ZASB6m5oSl1WmscmbUEHpIUL2aXcgyb1LnWRKmiM89UTBU-9sgRLGO3EZ_7LAFDAdB_f6EE--Q_bB7epIQswK4D8ZKBNzb8HUGz0u6Mfpcf_ixn_w

authors: HitendraSinghRathore hediet naivefun


text:
Job management error: 404 page not found

Hi i am facing issue , please guide me
*Describe the issue
authorName: default
experimentName: example_dist_pytorch
trialConcurrency: 1
maxExecDuration: 1h
maxTrialNum: 1
trainingServicePlatform: kubeflow
searchSpacePath: search_space.json
useAnnotation: false
tuner:
#choice: TPE, Random, Anneal, Evolution, BatchTuner, MetisTuner, GPTuner
builtinTunerName: TPE
classArgs:
optimize_mode: maximize
trial:
codeDir: .
master:
replicas: 1
command: python3 dist_mnist.py
gpuNum: 0
cpuNum: 1
memoryMB: 4096
image: tensorflow/tensorflow
worker:
replicas: 1
command: python3 dist_mnist.py
gpuNum: 0
cpuNum: 1
memoryMB: 4096
image: mapler/pytorch-cpu:latest
kubeflowConfig:
operator: pytorch-operator
apiVersion: v1
storage:
keyVault:
vaultName:
name:
azureStorage:
accountName:
azureShare:
NNI Log
[2021-09-06 09:57:09] INFO (NNIDataStore) Datastore initialization done
[2021-09-06 09:57:09] INFO (RestServer) RestServer start
[2021-09-06 09:57:09] INFO (RestServer) RestServer base port is 5000
[2021-09-06 09:57:09] INFO (main) Rest server listening on: http://0.0.0.0:5000
[2021-09-06 09:57:09] INFO (NNIManager) Setup training service...
[2021-09-06 09:57:10] INFO (KubernetesTrainingService) Construct Kubeflow training service.
[2021-09-06 09:57:12] INFO (NNIManager) Starting experiment: u1MHS9zi
[2021-09-06 09:57:12] INFO (NNIManager) Setup tuner...
[2021-09-06 09:57:12] INFO (NNIManager) Change NNIManager status from: INITIALIZED to: RUNNING
[2021-09-06 09:57:12] INFO (NNIManager) Add event listeners
[2021-09-06 09:57:12] INFO (KubernetesTrainingService) Run Kubeflow training service.
[2021-09-06 09:57:12] INFO (RestServer) RestServer start
[2021-09-06 09:57:12] INFO (RestServer) RestServer base port is 5001
[2021-09-06 09:57:12] INFO (KubernetesTrainingService) Kubeflow Training service rest server listening on: http://0.0.0.0:5001
[2021-09-06 09:57:13] INFO (NNIManager) NNIManager received command from dispatcher: ID,
[2021-09-06 09:57:13] INFO (NNIManager) NNIManager received command from dispatcher: TR, {"parameter_id": 0, "parameter_source": "algorithm", "parameters": {"batch_size": 32, "hidden_size": 128, "lr": 0.0001}, "parameter_index": 0}
[2021-09-06 09:57:17] INFO (NNIManager) submitTrialJob: form: { sequenceId: 0,
hyperParameters:
{ value:
'{"parameter_id": 0, "parameter_source": "algorithm", "parameters": {"batch_size": 32, "hidden_size": 128, "lr": 0.0001}, "parameter_index": 0}',
index: 0 } }
[2021-09-06 09:57:17] INFO (KubernetesTrainingService) Construct Kubeflow training service.
[2021-09-06 09:57:20] ERROR (NNIManager) Error: 404 page not found
at _request (/media/sladmin/nlp_disk/Kruthika/nni/venv/lib/python3.6/site-packages/nni_node/node_modules/kubernetes-client/lib/backends/request.js:189:25)
at Request.request [as _callback] (/media/sladmin/nlp_disk/Kruthika/nni/venv/lib/python3.6/site-packages/nni_node/node_modules/kubernetes-client/lib/backends/request.js:148:14)
at Request.self.callback (/media/sladmin/nlp_disk/Kruthika/nni/venv/lib/python3.6/site-packages/nni_node/node_modules/request/request.js:185:22)
at Request.emit (events.js:198:13)
at Request.<anonymous> (/media/sladmin/nlp_disk/Kruthika/nni/venv/lib/python3.6/site-packages/nni_node/node_modules/request/request.js:1154:10)
at Request.emit (events.js:198:13)
at IncomingMessage.<anonymous> (/media/sladmin/nlp_disk/Kruthika/nni/venv/lib/python3.6/site-packages/nni_node/node_modules/request/request.js:1076:12)
at Object.onceWrapper (events.js:286:20)
at IncomingMessage.emit (events.js:203:15)
at endReadableNT (_stream_readable.js:1145:12)

[2021-09-06 09:57:20] INFO (NNIManager) Change NNIManager status from: RUNNING to: ERROR

Yes this is solved. thank you for the help.

what was the problem? I got a same problem

authors: juniroc kruthikakr

repo: microsoft/nni


text:
[Help] [iOS example] Failed to launch the app w/ Type Error of output arg

Following #161, I am running the iOS example according to its README.
I opened MyVoice.xcworkspace in Xcode, made some slight modifications to make it compile, and ran it.
I am getting Type Error: Type (tensor(bool)) of output arg (onnx::adamw.updated_flag::5) of node (onnx::AdamWOptimizer::6) does not match expected type (tensor(int64)) and a blank screen.
Full relevant error.
MyVoice/TrainView.swift:25: Fatal error: 'try!' expression unexpectedly raised an error: Error Domain=onnxruntime Code=1 "/Users/runner/work/1/s/orttraining/orttraining/training_api/optimizer.cc:239 void onnxruntime::training::api::Optimizer::Initialize(const std::string &, const std::vector<std::shared_ptr<IExecutionProvider>> &, gsl::span<OrtCustomOpDomain *const>) [ONNXRuntimeError] : 1 : FAIL : Load model from /Users/sichanghe/Library/Developer/CoreSimulator/Devices/CB79BDAB-7D81-43FC-8440-FE4B95955A60/data/Containers/Bundle/Application/02A3121A-4522-497A-8677-0BD7A416F48D/MyVoice.app/optimizer_model.onnx failed:Type Error: Type (tensor(bool)) of output arg (onnx::adamw.updated_flag::5) of node (onnx::AdamWOptimizer::6) does not match expected type (tensor(int64)).
" UserInfo={NSLocalizedDescription=/Users/runner/work/1/s/orttraining/orttraining/training_api/optimizer.cc:239 void onnxruntime::training::api::Optimizer::Initialize(const std::string &, const std::vector<std::shared_ptr<IExecutionProvider>> &, gsl::span<OrtCustomOpDomain *const>) [ONNXRuntimeError] : 1 : FAIL : Load model from /Users/sichanghe/Library/Developer/CoreSimulator/Devices/CB79BDAB-7D81-43FC-8440-FE4B95955A60/data/Containers/Bundle/Application/02A3121A-4522-497A-8677-0BD7A416F48D/MyVoice.app/optimizer_model.onnx failed:Type Error: Type (tensor(bool)) of output arg (onnx::adamw.updated_flag::5) of node (onnx::AdamWOptimizer::6) does not match expected type (tensor(int64)).
}
2023-09-06 13:14:29.936987+0800 MyVoice[95643:1836341] MyVoice/TrainView.swift:25: Fatal error: 'try!' expression unexpectedly raised an error: Error Domain=onnxruntime Code=1 "/Users/runner/work/1/s/orttraining/orttraining/training_api/optimizer.cc:239 void onnxruntime::training::api::Optimizer::Initialize(const std::string &, const std::vector<std::shared_ptr<IExecutionProvider>> &, gsl::span<OrtCustomOpDomain *const>) [ONNXRuntimeError] : 1 : FAIL : Load model from /Users/sichanghe/Library/Developer/CoreSimulator/Devices/CB79BDAB-7D81-43FC-8440-FE4B95955A60/data/Containers/Bundle/Application/02A3121A-4522-497A-8677-0BD7A416F48D/MyVoice.app/optimizer_model.onnx failed:Type Error: Type (tensor(bool)) of output arg (onnx::adamw.updated_flag::5) of node (onnx::AdamWOptimizer::6) does not match expected type (tensor(int64)).
" UserInfo={NSLocalizedDescription=/Users/runner/work/1/s/orttraining/orttraining/training_api/optimizer.cc:239 void onnxruntime::training::api::Optimizer::Initialize(const std::string &, const std::vector<std::shared_ptr<IExecutionProvider>> &, gsl::span<OrtCustomOpDomain *const>) [ONNXRuntimeError] : 1 : FAIL : Load model from /Users/sichanghe/Library/Developer/CoreSimulator/Devices/CB79BDAB-7D81-43FC-8440-FE4B95955A60/data/Containers/Bundle/Application/02A3121A-4522-497A-8677-0BD7A416F48D/MyVoice.app/optimizer_model.onnx failed:Type Error: Type (tensor(bool)) of output arg (onnx::adamw.updated_flag::5) of node (onnx::AdamWOptimizer::6) does not match expected type (tensor(int64)).
}

Screenshot.

@baijumeswani, does this have anything to do with the change in onnxruntime-training-cpu?

ping

Hi. You should use the same version of onnxruntime for both offline tooling and training so that the model created in the offline tooling is in sync with what the onnxruntime version is expecting during training.
This change went in in https://github.com/microsoft/onnxruntime/pull/17085. Try to use a version of ort either both after that or both before that.

@baijumeswani, thanks for your explanation. However, since I installed the nightly version of the offline tooling following your instruction, how should I change the iOS part? I presume that I need to change this pod, but to what:
https://github.com/microsoft/onnxruntime-training-examples/blob/d7c2a836229de200168687c17147ac0714bc65e8/on_device_training/mobile/ios/Podfile#L9

One of two options:

Build the iOS pod from source. You can follow instructions here: https://onnxruntime.ai/docs/build/training.html#build-instructions-for-the-training-phase
Wait for onnxruntime 1.16 to be released. I think the pod will be released in the next week or so.

So, at this stage, it seems that ONNX Runtime training is still highly experimental to me. Maybe I can get this demo working, but not quite for extensive use. Let me wait for 1.16.

ONNX Runtime 1.16 is the first ort release for training on iOS. This is also the reason we have made it available as a python package on macos starting 1.16.

I see. This is literally the start. I shall be more patient.

Can confirm that the app works using ONNX Runtime 1.16 🎉!
Steps.
I installed ONNX Runtime Training on my Mac following the instructions on ONNX Runtime home page (changed slightly to remove a bug):
$ pip3 install cerberus flatbuffers h5py numpy onnx packaging protobuf sympy setuptools
  pip3 install -i https://aiinfra.pkgs.visualstudio.com/PublicPackages/_packaging/ORT/pypi/simple/ onnxruntime-training-cpu

Regenerated the artifact files:
python3 artifacts_gen.py

Changed the Podfile:
- pod 'onnxruntime-training-objc', '1.16.0-dev+20230721002.fa4712c'
+ pod 'onnxruntime-training-objc', '~>1.16.0'

Reinstalled the pod:
pod install --repo-update

I also needed to remove my developer key to make the app build and run on my phone.
It then successfully trained and inferred, but got quit "because of memory" issue after I attempted to train a second voice.

The next step for me is to figure out how to get and set the model parameters so I can use it to do federated learning. Any hints on that, @baijumeswani?
Thanks.

For extracting the model parameters as a contiguous buffer (for federated learning scenarios), have a look at these two functions:

toBufferWithTrainable:error:
fromBufferWithValue:error:

Awesome. Thanks for the help!

authors: SichangHe baijumeswani

repo: microsoft/onnxruntime-training-examples


text:
Create aten_normal_float_float | feat(torchlib)

Fixes the new test error caused by torch-nightly

Merging for now. Will follow up if needed.

repo: microsoft/onnxscript


text:
[Test] Hack to enable optimizer/rewriter integration into dynamo_export

Stack from ghstack (oldest at bottom):

-> #1334
#1340

To test in torchbench.
Somehow lintrunner changed unrelated files in this commit.

Closing as not needed. Test benchmark has completed.


text:
Job list permission

Organization Name:
Advantech

Short summary about the issue/question:
Invalid permission for browsing job page.
Brief what process you are following:

Have multiple non-admin user accounts

Login openpai webportal as one of the non-admin user. All jobs created by admin and non-admin can be browsed

Non admin permission should only browse his-own job instead of all jobs though the non-admin user can only stop his own jobs.

How to reproduce it:
The above 3 steps.

OpenPAI Environment:

OpenPAI version:
v1.0.1
OS (e.g. from /etc/os-release):
ubuntu 16.04

This is by design. All users can browse other users’ jobs.

authors: JosephKang fanyangCS

repo: microsoft/pai


text:
[BUG] Browser.CloseAsync takes 30 seconds for Chromium

Context:

Playwright Version: 1.35.0
Operating System: Windows 10 Pro 22H2
.NET version: 4.8
Browser: Chromium

Code Snippet
using System;
using System.Diagnostics;
using System.Threading.Tasks;
using Microsoft.Playwright;

namespace PlaywrightBrowserCloseBug
{
    internal class Program
    {
        public async static Task Main(string[] args)
        {
            var sw = Stopwatch.StartNew();
            var pw = await Playwright.CreateAsync();
            Console.WriteLine($"Playwright started within {sw.Elapsed.TotalSeconds:N0} seconds");
            sw.Restart();
            var chromium = await pw.Chromium.LaunchAsync(new BrowserTypeLaunchOptions() {Headless = false});
            Console.WriteLine($"Chromium started within {sw.Elapsed.TotalSeconds:N0} seconds");
            sw.Restart();
            await chromium.CloseAsync();
            Console.WriteLine($"Chromium closed within {sw.Elapsed.TotalSeconds:N0} seconds");
        }
    }
}

Output

Playwright started within 1 seconds
Chromium started within 0 seconds
Chromium closed within 30 seconds

Describe the bug
Closing a chromium browser takes 30 seconds. I can also see that the process remain for 30 seconds. When I do the same with Microsoft Edge it immediatly closes the browser.

I unfortunately can't reproduce on my machine. I tried on macOS and Windows 11. Is your device managed? Does it contain any cooperate software or are the special security policies applied?

authors: hakito mxschmitt

repo: microsoft/playwright-dotnet


text:
Dynamically load wlanApi functions

Goals
Dynamically load wlanApi functions to remove the dependency on wlanApi.dll.
This allows proxy_wifi to run on SKU where wlanApi isn't available (server for isntance).
Technical Details
Functions from wlanAPI are dynamically loaded using LoadLibraryEx and GetProcAddress. through a wapper class DynamicFunction.
The stubs that were used to run unit tests on the pipeline have been removed, they are not needed anymore.
Testing
A unit test is added to confirm the executable will run (it might fail to load functions and throw on server SKU)
Reviewer Focus
With dynamically loaded functions, WIL wapper can't be used anymore.
I haven't found a way to build a smart pointer using a dynamically loaded function for its cleanup without being very hacky.
Any idea? (wil::scope_exit is used for now).
Checklist

[x] All targets compile successfully
[x] Changes have been formated with clang-format
[x] Newly added code include doxygen-style comments
[x] Unit tests are succeeding

Issue while testing: fails to start if Wi-Fi is not connected. Need to investigate if this is related.

can we verify this on a system without wlanapi to see how the exception propagates up to the caller?

can we verify this on a system without wlanapi to see how the exception propagates up to the caller?

        try
        {
            wlansvc = std::make_shared<Wlansvc::WlanApiWrapperImpl>();
        }
        catch(...)
        {
            LOG_CAUGHT_EXCEPTION_MSG("Failed to get a Wlansvc handle. Will only support fake networks.");
        }
        return MakeWlansvcOperationHandler(wlansvc, std::move(fakeNetworkCallback), pObserver);

All failures when creating the wrapper are caught here. A test already validates that creating an operation handler with a no wlansvc wrapper works, and another one checks that creating the wrapper when wlansvc isn't present won't result in  a fail fast (unit tests are running on server in the pipeline)

Issue while testing: fails to start if Wi-Fi is not connected. Need to investigate if this is related.

Solved: pointers need to be initialized now that they aren't smart anymore...

authors: guhetier keith-horton


text:
fix npm i makecode / makecode-browser

fix https://github.com/microsoft/pxt-mkc/issues/97
the build over there just npm i's makecode(-node), and since the core dep is out of date that resulted in a bad build with nothing built https://www.npmjs.com/package/makecode-core/v/0.0.1

Is there a script that auto updates those dependencies?

I'm not certain why this didn't kick off a release for makecode / makecode-browser; do we only detect .ts changes and create releases off those, so package.json isn't enough?
re: auto update the deps, I'm not exactly sure how that would work as it automatically creates releases; it seems to run the release builds in a valid order (makecode-core -> makecode & makecode-browser after) so maybe we preemptively bump package.json when we know that it will release updates?

authors: jwunderl pelikhan

repo: microsoft/pxt-mkc


text:
Pylance fails to resolve type of boto3.client method

With the boto3-stubs package installed, Pylance is failing to correctly parse the sample code from (at least) the CloudWatchLogs module:
from boto3.session import Session

from mypy_boto3_logs.client import CloudWatchLogsClient

def get_client() -> CloudWatchLogsClient:
    return Session().client("logs")  # "Type of  of 'client' is partially unknown"

(contents of Overload have been snipped to fit)
Type of "client" is partially unknown
  Type of "client" is "Overload[(service_name: Literal['logs'], region_name: str | None = ..., api_version: str | None = ..., use_ssl: bool | None = ..., verify: bool | str | None = ..., endpoint_url: str | None = ..., aws_access_key_id: str | None = ..., aws_secret_access_key: str | None = ..., aws_session_token: str | None = ..., config: Config | None = ...) -> CloudWatchLogsClient, (service_name: Literal['lookoutequipment'], region_name: str | None = ..., api_version: str | None = ..., use_ssl: bool | None = ..., verify: bool | str | None = ..., endpoint_url: str | None = ..., aws_access_key_id: str | None = ..., aws_secret_access_key: str | None = ..., aws_session_token: str | None = ..., config: Config | None = ...) -> Unknown, (service_name: Literal['lookoutmetrics'], region_name: str | None = ..., api_version: str | None = ..., use_ssl: bool | None = ..., verify: bool | str | None = ..., endpoint_url: str | None = ..., aws_access_key_id: str | None = ..., aws_secret_access_key: str | None = ..., aws_session_token: str | None = ..., config: Config | None = ...) -> Unknown, (service_name: Literal['lookoutvision'], region_name: str | None = ..., api_version: str | None = ..., use_ssl: bool | None = ..., verify: bool | str | None = ..., endpoint_url: str | None = ..., aws_access_key_id: str | None = ..., aws_secret_access_key: str | None = ..., aws_session_token: str | None = ..., config: Config | None = ...) -> Unknown, (service_name: Literal['machinelearning'], region_name: str | None = ..., api_version: str | None = ..., use_ssl: bool | None = ..., verify: bool | str | None = ..., endpoint_url: str | None = ..., aws_access_key_id: str | None = ..., aws_secret_access_key: str | None = ..., aws_session_token: str | None = ..., config: Config | None = ...) -> Unknown]"

I can see the requisite overload for the "logs" literal there, so my assumption is that this is an issue with Pylance and not the mypy package, but I'm not very familiar with the syntax here:
 (service_name: Literal['logs'], region_name: str | None = ..., api_version: str | None = ..., use_ssl: bool | None = ..., verify: bool | str | None = ..., endpoint_url: str | None = ..., aws_access_key_id: str | None = ..., aws_secret_access_key: str | None = ..., aws_session_token: str | None = ..., config: Config | None = ...) -> CloudWatchLogsClient

Environment:

Pylance v2022.5.1
Type checking mode "strict"
boto3-stubs 1.22.13

I believe these just means that not all there code paths return a known type. Its a issue to log in the boto3-stubs repo.

The stub files in boto3-stubs are modularized. When you install boto3-stubs by itself, you are not installing the stubs for all of the various boto3 submodules. The client call is an overload that returns various types imported from boto3 submodules. If you want to eliminate the Type of 'client' is partially unknown error, you will need to install stubs for all of the boto3 submodules. I'm not sure if there's a way to do that automatically. Please consult the boto3 documentation.
If you don't want to install all of the boto3-stubs submodules (there's a lot of them after all!) but still want to use strict type checking, you could add a # type: ignore or # pyright: ignore[reportUnknownMemberType] to the end of that line.

@erictraut I have tried to install every service, and the issue still occurs, I believe you have closed this issue prematurely.
Even if every service wasn't installed, there is a specific overload that covers my call and it isn't Unknown -- so why would Pylance call this partially unknown?

@bschnurr No control paths should be evaluated at the call site; only the stubs should be used.

why would Pylance call this partially unknown?

A symbol is flagged as partially unknown if any portion of its type cannot be determined. In this particular case, the symbol client is an overloaded method. If any of the overload signatures reference an input parameter or return type that is unknown, the overall type is considered partially unknown. Unknown input parameter types within an overload signature can be especially problematic because they can lead to incorrect overload matching, so it's important for pylance to inform you about partially unknown types in this case.
I presume that you have enabled "strict" type checking? Was that your intent? If you enable strict type checking, you may find that you need to work around limitations in library or stub types. If it wasn't your intent to enable strict type checking, you might find that "basic" type checking is preferable. If you really are intent on enabling all of the strict checks, you can suppress this particular error if you're confident that it's not an issue for your use case.

I presume that you have enabled "strict" type checking? Was that your intent?
Yes I have strict enabled.  I wanted libraries I'm producing to have no warnings or errors under that mode.

A symbol is flagged as partially unknown if any portion of its type cannot be determined.
I see, thanks for the clarification.  I would have thought that the error would have been generated at the stub site and not a call site that wasn't using an unknown type, but I expect there's good reason for that.

Re: how this happens with boto3-stub's modular nature, do you have guidance on how that package could be fixed to be compliant in strict mode without all modules installed?
Feel free to close this issue with your reply. Thanks!

The problem is caused by the fact that all of the objects in the boto3 framework are funneled through a single massive overloaded create function. This is very atypical. I can't think of any other Python libraries that do this. Most libraries have you call constructors directly rather than going through a polymorphic wrapper function like this.

authors: bschnurr erictraut jarruda

repo: microsoft/pylance-release


text:
How to run "estimator -c configuration.yaml" on Ubuntu ?

It works om WinOS.
But I do not know where is estimator, and how to run "estimator -c configuration.yaml" on Ubuntu.
Thanks
On Jupyter,
! cd ./examples
! estimator -c estimator/estimator_config.yaml

/bin/sh: 1: estimator: not found

Hi, it works on Ubuntu too. Please make sure that you have installed Qlib successfully.

Got it, thank you

authors: bxdd pan-cai

repo: microsoft/qlib


text:
Added Integration agenda for #16

Updated main README file with session details for Integration

@vitoc may we please add Aswin and Gogo to the repository as reviewers?

@vitoc may we please add Aswin and Gogo to the repository as reviewers?

Added :)

authors: miguelarcilla vitoc

repo: microsoft/saaslab


text:
factory: add AMD executor

The executor default to the intel one.
An option to select the executor already exist but it is not used.
This PR adds two options for the executor: 'x86-64-intel' and 'x86-64-amd'.

Hey. Thanks, all looks good. Could you also apply the patch below? It's a sanity check that compares the current configuration with the cpuinfo output.
diff --git a/src/x86/x86_config.py b/src/x86/x86_config.py
index ca5abf9..cb9f1cd 100644
--- a/src/x86/x86_config.py
+++ b/src/x86/x86_config.py
@@ -8,6 +8,10 @@ from typing import List

 # x86_option_values attribute MUST be the first attribute in the file
 x86_option_values = {
+    'executor': [
+        'x86-64-intel',
+        'x86-64-amd',
+    ],
     'executor_mode': [
         'P+P',
         'F+R',
diff --git a/src/x86/x86_executor.py b/src/x86/x86_executor.py
index 6eee5ca..c349c3c 100644
--- a/src/x86/x86_executor.py
+++ b/src/x86/x86_executor.py
@@ -171,6 +171,16 @@ class X86Executor(Executor):

 class X86IntelExecutor(X86Executor):

+    def __init__(self):
+        self.LOG = Logger()
+        vendor = subprocess.run(
+            "grep 'vendor_id' /proc/cpuinfo", shell=True, capture_output=True).stdout.decode()
+        if "Intel" not in vendor:
+            self.LOG.error(
+                "Attempting to run Intel executor on a non-Intel CPUs!\n"
+                "Change the `executor` configuration option to the appropriate vendor value.")
+        super().__init__()
+
     def set_vendor_specific_features(self):
         write_to_sysfs_file("1" if "BR" in CONF.permitted_faults else "0",
                             "/sys/x86_executor/enable_mpx")
@@ -178,5 +188,15 @@ class X86IntelExecutor(X86Executor):

 class X86AMDExecutor(X86Executor):

+    def __init__(self):
+        self.LOG = Logger()
+        vendor = subprocess.run(
+            "grep 'vendor_id' /proc/cpuinfo", shell=True, capture_output=True).stdout.decode()
+        if "AMD" not in vendor:
+            self.LOG.error(
+                "Attempting to run AMD executor on a non-AMD CPUs!\n"
+                "Change the `executor` configuration option to the appropriate vendor value.")
+        super().__init__()
+
     def set_vendor_specific_features(self):
         pass

authors: OleksiiOleksenko van-ema

repo: microsoft/sca-fuzzer