text:
Sourcemap for XXX points to missing source files for node modules warning

Environment
Web, Svelte, Vite, @sentry/vite-plugin
"@sveltejs/vite-plugin-svelte": "^1.1.0",
I treid to hide this
sentryVitePlugin({
        org: 'dogbase',
        project: 'dogbase-production',
        authToken: env.VITE_APP_SENTRY_AUTH_TOKEN,
				silent: true, // This will suppress all logs from the Sentry plugin
        errorHandler: (error) => {
          console.warn('Sentry Plugin Error:', error);
          // This will log the error as a warning but allow the build to continue
        },
        sourcemaps: {
          // Specify which build artifacts should be uploaded to Sentry
          assets: './dist/**',
          ignore: ['./node_modules/**'],
        },
      }),

Expected Result
Not see the followig

Actual Result
What actually happened. Maybe a screenshot/recording? Maybe some logs?

@chargome here
import { defineConfig, loadEnv } from 'vite'
import { svelte } from '@sveltejs/vite-plugin-svelte'
import { sentryVitePlugin } from '@sentry/vite-plugin'
import './src/vite-env.d'

export default defineConfig(({ mode }) => {
  // Load environment variables based on the current mode
  const env = loadEnv(mode, process.cwd(), '')

  return {
    build: {
      sourcemap: true, // Source map generation must be turned on
      target: 'ESNext',

    },
    plugins: [
			//warningHandlerPlugin(),
      svelte(),
      sentryVitePlugin({
        org: env.VITE_APP_SENTRY_ORG,
        project: env.VITE_APP_SENTRY_PROJECT,
        authToken: env.VITE_APP_SENTRY_AUTH_TOKEN,
				//silent: true, // This will suppress all logs from the Sentry plugin
        /*
				errorHandler: (error) => {
          console.warn('Sentry Plugin Error:', error);
          // This will log the error as a warning but allow the build to continue
        },
        sourcemaps: {
          // Specify which build artifacts should be uploaded to Sentry
          assets: './dist/**',
          ignore: ['./node_modules/**'],
        },
				*/
      }),
    ],
    optimizeDeps: { exclude: ['svelte-navigator'] },
  }
})

Hi, can you elaborate why you relate this issue to Sentry? :)
I don't think the error message comes from anything relating to us: https://github.com/search?type=code&q="points+to+missing+source+files"+org%3Agetsentry+
I think it's vite: https://github.com/vitejs/vite/blob/adf379963a2c21544b244c04b664b788bc9cb7a5/packages/vite/src/node/server/sourcemap.ts#L81

Yes your correct sorry about that

authors: isAlmogK lforst


text:
Transaction.set_data() does not work

The following code
import sentry_sdk
from sentry_sdk import start_transaction

sentry_sdk.init(traces_sample_rate=1.0, dsn=...)
with start_transaction(op="GetDatasets", name='DUMMY') as span:
    span.set_data('foo', 'bar')
    print('foo')

will silently discard the data set in the transaction as it is only currently supported by child spans, not the transaction despite the transaction inheriting from span. One solution to fix this would be to make Transaction.set_data() raise an exception as it should not be used, but I think the best path forward would be to add actual support to extra data in Transaction.
I think this will require changes in the API thought.

This is more than a year old, but for sake of completeness, you can see in our specs how the API is meant to be used. You should use with_transaction and then with_span and set the data on the span.

Re-opening this issue after an internal conversation. Summary below
FYI @evanpurkhiser
https://github.com/evanpurkhiser/venmo-auto-cashout/blob/master/venmo_auto_cashout/cli.py#L105-L111
        tran.set_data(
            "transactions",
            [
                {"payer": t.payer.display_name, "amount": t.amount, "note": t.note}
                for t in eligable_transactions

Transaction data not shown in product and also not in JSON, due to reason above.
same as original issue, discussion was again around that this is not the cOrReCt way to use set_data, but then "why do we allow it?". Checking the original implementation @untitaker gave the input "Yes set_data only works on spans and there's no reason we can't change that"

Any plans to address this?
It would be useful for transaction.set_data() to "work" instead of being silently discarded, so consider this a +1.

This is not yet on our roadmap, but we keep it in the backlog. It will happen someday.

source: gharchive/issue

authors: antonpirker eddyg remilapeyre sl0thentr0py smeubank

repo: getsentry/sentry-python

license: MIT

license_type: permissive

license_source: github-api


text:
getting an error when loading a type='Map' chart

Hi I'm getting the follow error trying to run a type='Map'
Error: Map is unknown chart type.
at Object.initChart (http://localhost:4300/0.chunk.js:591:15)
at ChartComponent.init (http://localhost:4300/0.chunk.js:277:38)
at ChartComponent.ngAfterViewInit (http://localhost:4300/0.chunk.js:283:14)
at DebugAppView.View_DashboardDemographicComponent0.detectChangesInternal (/DashboardModule/DashboardDemographicComponent/component.ngfactory.js:316:73)
etc
This is when i write:  <chart type="Map" [options]="optionsMap"></chart>
The other charts are loading , ok.

Looks like you have not plugged maps module. See the appropriate readme section

add missing module to the highcharts factory. I got this error when i was missing require('highcharts/modules/map')(hc);
Here is my code

export function highchartsFactory() {
    const hc = require('highcharts');
    require('highcharts/modules/heatmap')(hc);
    require('highcharts/modules/map')(hc);
    require('highcharts/modules/drilldown')(hc);
    require('highcharts/modules/exporting')(hc);
    require('highcharts/modules/offline-exporting')(hc);
    require('highcharts/modules/export-data')(hc);
    return hc;
}

Add the highchartsFactory to the providers
providers: [
        {
            provide: HighchartsStatic,
            useFactory: highchartsFactory
        }
    ],

authors: gevgeny sanketsw xavierclotet

license: mit

license_source: bigquery


text:
Implement texture swizzling

https://www.opengl.org/registry/specs/ARB/texture_swizzle.txt
I guess this should be part of the TextureInfo

How do we want to think about this?
We do have swizzle as a part of the texture shader resource (format::Swizzle) but we could also set it up as part of the tex::SamplerInfo. However, Swizzle is strictly a OpenGL texture parameter and does not play well with the gfx Sampler abstraction. Another way of doing it is to make it a part of the tex::Descriptor.
Anyhow, I  suggest we use a nomenclature similar to  VkComponentSwizzle enums although that is very different than the existing formulation of format::Swizzle.
What do you think?

We can't have it in SamplerInfo since (as you mentioned), it's a texture parameter, not sampler one. So we just need to use that format::Swizzle, make it a part of the texture descriptor (used to create textures on the low level), and actually update the graphics backends to take it into account.
As for changing the nomenclature - I suppose it's just using R,G,B,A instead of X,Y,Z,W - I'd be totally fine with that change.
There is a problem though with adapting the type system for the texture views. The type of SRVs and UAVs currently is formed like this:
type View = $container< <$channel as ChannelTyped>::ShaderType >;

If we mix swizzling in, the ShaderType stays unchanged, but the $container is no longer valid - the swizzle makes everything accessible as 4-component container.
One of the radical ways to fix that is to remove the container entirely from the view type:
my_view: gfx::ShaderResource<f32> = "t_MyView"; // notice `f32` instead of some `[f32; 3]`

We can make sure the backend treats it compatible with the shader requesting any kind of container (vec2, vec3, vec4, or just a scalar).

Swizzling now in master. I don't think it's worth to add it for pre-ll.

authors: cmr ebaklund kvark msiglreith

repo: gfx-rs/gfx


text:
[mtl] Borrowed commands

PR checklist:

[ ] make succeeds (on *nix)
[x] make reftests succeeds
[x] tested examples with the following backends:

r? @gfx-rs/metallists
This PR attempts to have lightweight software commands that don't take any heap space or own ObjC objects. In most cases, where a command list is live-recorded and executed once, this should reduce the amount of work we do per command, which is especially important if those commands are thrown away (e.g. because we are not inside a render pass).
My expectation would be to see an improvement in #2161 due to us doing less work. The actual results are somewhat shocking: with v-sync enabled I'm getting the same 59-60 fps as usual. With v-sync OFF, I'm getting between 25 and 50 fps now (which is lower than the previous 50-70). Not sure what's going on, the instrumental profile doesn't give a clue. Please check out the code.

It might be the power management playing tricks with me. When plugged in (as opposed to 50% battery), I see stable 60-70fps. Just in case, I double-checked the version before my PR, and it doesn't appear faster. It's roughly the same (which is also kinda concerning), maybe a few frames per second less. With this in mind, removing the WIP tag, open for reviews.

Thank you for a detailed review! :heart:
Concerns are addressed, let's proceed.
bors r=grovesNL

Bors retry

On Jun 22, 2018, at 00:20, Josh Groves notifications@github.com wrote:
@grovesNL approved this pull request.
CI failure is unrelated:
info: downloading component 'rustc'
error: failed to parse url: 1.28.0-nightly (662c70a59 2018-06-21)/2018-06-22/rustc-nightly-x86_64-unknown-linux-gnu.tar.xz
info: caused by: relative URL without a base
The command "curl -sSf https://sh.rustup.rs | sh -s -- --default-toolchain=$TRAVIS_RUST_VERSION -y" failed and exited with 1 during .
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

bors retry

bors r=grovesNL

Bors r=grovesNL

On Jun 22, 2018, at 15:15, bors[bot] notifications@github.com wrote:
Build failed
continuous-integration/travis-ci/push
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Bors retry

On Jun 22, 2018, at 15:15, bors[bot] notifications@github.com wrote:
Build failed
continuous-integration/travis-ci/push
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

bors retry

bors r=grovesNL

source: gharchive/pull-request


text:
Source other ignore files from .agignore

Teams sharing dotfiles currently can't share ignore preferences but retain their own personal global overrides. An example of this would be the team having their .agignore configuration, and then individual team members adding their own personal preferences in .agignore.local.
Adding this issue to discuss if adding the ability to source further ignore files from .agignore to support shared and personal preferences is feasible.

Did you try putting patterns in ~/.agignore?

The issue I'm trying to get around is that ~/.agignore is shared by the team, and so I was hoping to be able to declare a second file that could be sourced that would be under each team member's personal control.

The .agignore in each person's home directory is shared?! I'm sure there must be a misunderstanding.

authors: geoffharcourt ggreer


text:
PatchCheck.py does not detect you did not configure "BaseTools/Scripts/SetupGit.py (Bugzilla Bug 2767)

This issue was created automatically with bugzilla2github
Bugzilla Bug 2767
Date: 2020-05-26T00:07:45+00:00
From: ajfish
To:   mdkinney
CC:   edk2+bugs+int+994+563148131503455288, nobody
Last updated: 2020-05-26T21:45:53+00:00

Comment 12705
Date: 2020-05-26 00:07:45 +0000
From: ajfish

Industry Specification: ---
Target OS: ---

I was configuring a system to do edk2 contribution and I did not run BaseTools/Scripts/SetupGit.py and my patch got rejected, but PatchCheck.py passed.
This seems like a bad bug in PatchCheck.py

Comment 12713
Date: 2020-05-26 21:45:53 +0000
From: nobody <>
What means the patch got rejected?
What change is required in PatchCheck.py to fix this issue?


text:
ghiden.github.io/angucomplete-alt examples page is broken

Hi, I've got this error in console
Mixed Content: The page at 'https://ghiden.github.io/angucomplete-alt/#example14' was loaded over HTTPS, but requested an insecure script 'http://ajax.googleapis.com/ajax/libs/angularjs/1.4.6/angular.min.js'. This request has been blocked; the content must be served over HTTPS

:tada:

repo: ghiden/angucomplete-alt


text:
Add Rating Feature for Anime

-Introducing a rating feature for anime would enable users to share their opinions and may contribute to the platform's community-driven content evaluation systems maybe.

Implement moderation tools to ensure the integrity and accuracy of anime ratings, such as flagging inappropriate or misleading ratings.
In conclusion, I believe that adding a rating feature for anime content would significantly enrich the user experience

I believe this is something you should implement in your own application.
This is only a scraper adding such functionality to this api will require it to have its own database and user authentication.


text:
Pagination with grunt-assemble

Is there a plugin or magic I can use to add pagination within assemble?

Any ideas how to do the pagination please?

repo: ghost-town/grunt-init-assemble


text:
reconcile-aws-template

add implementation for IAm service - which will create and delete IAm roles
add implementation for the AWSMachineTempalte reconciler
trying to make several small PRs from https://github.com/giantswarm/capa-iam-controller/pull/1 to make them more easy to review

waiting on https://github.com/giantswarm/capa-iam-controller/pull/10 and https://github.com/giantswarm/capa-iam-controller/pull/9 so I can rebase and have green CI

repo: giantswarm/capa-iam-controller


text:
Extend automation to include latest CLI versions

This PR adds the updating of the latest gsctl version to the automation. Along with it, there are these additional changes:

The kubectl gs version is also fetched and shown in docs.
The script is executed in docker, reducing dependencies.

@ubergesundheit @stone-z RFR 💐

repo: giantswarm/docs


text:
Add VPA for Kyverno Plugin and enable by default

Closes https://github.com/giantswarm/giantswarm/issues/26402

Does it make sense to bump kyverno-plugin?

Oh sorry, I meant bump the number of replicas as indicated in the issue.
I'm fine without having VPA on Kyverno itself, I think we do have VPA in just one cluster so far. The tests should be fine.
I did not remember about the massive change in 1.10, you are right we will need to rework the controllers then. Should I remove the Kyverno VPA? Or do we keep it until 1.10?

I meant bump the number of replicas as indicated in the issue.

Oh gotcha. Let's leave it as is for now

Should I remove the Kyverno VPA? Or do we keep it until 1.10?

I'd drop it personally. If people really want to VPA Kyverno then we can always come back and add it but I'd rather not encourage that right now

authors: fhielpos stone-z

repo: giantswarm/kyverno-app


text:
Tweak grizzly settings to accomodate pending pods

Task
Tweak grizzly settings to accomodate all pending pods.
TODOs:

[ ] Use m5.2xlarge instance type for all control plane nodes;
[ ] Double the number of worker nodes accross all of the machine pools;
[ ] Every machine pool must have at least 2 nodes.

Background
There are a lot of pending pods on grizzly because there aren't enough available resources:
❯ kubectl --context gs-grizzly get pods -A --field-selector status.phase=Pending
NAMESPACE         NAME                                                            READY   STATUS     RESTARTS   AGE
flux-giantswarm   kustomize-controller-6d49d46d9c-d8ctb                           0/1     Pending    0          73m
giantswarm        athena-77c67d4c54-d6xjm                                         0/1     Pending    0          6m29s
giantswarm        athena-77c67d4c54-fcbpt                                         0/1     Pending    0          6m31s
giantswarm        aws-vpc-operator-5d774b6ff8-vbhtn                               0/1     Pending    0          6m30s
giantswarm        deletion-blocker-operator-667fd57d44-r9z27                      0/1     Pending    0          6m31s
giantswarm        dex-f65bc79cd-mgfgh                                             0/1     Pending    0          6m30s
giantswarm        dns-operator-aws-848d8f8d65-fk9nt                               0/1     Pending    0          6m30s
giantswarm        falco-app-2cg8m                                                 0/1     Pending    0          6m24s
giantswarm        falco-app-cnl84                                                 0/1     Pending    0          6m30s
giantswarm        falco-app-falco-exporter-244fh                                  0/1     Pending    0          16m
giantswarm        falco-app-falco-exporter-rzhlq                                  0/1     Pending    0          50m
giantswarm        falco-app-tls48                                                 0/1     Pending    0          56m
giantswarm        node-operator-7b47d9d5d8-2mjjn                                  0/1     Pending    0          6m31s
giantswarm        organization-operator-55c76cfdd8-vq4r6                          0/1     Pending    0          6m31s
giantswarm        rbac-operator-788fdc866d-p7fp2                                  0/1     Pending    0          6m30s
giantswarm        scan-vulnerabilityreport-6d876df6fc-g5tgg                       0/3     Pending    0          67s
giantswarm        scan-vulnerabilityreport-75d77d7dfb-m2lnx                       0/2     Pending    0          2s
giantswarm        trivy-0                                                         0/1     Pending    0          14d
kube-system       vertical-pod-autoscaler-admission-controller-556558c8d9-bfqnn   0/1     Pending    0          6m31s
kube-system       vertical-pod-autoscaler-recommender-67b5d54d5f-ngw6l            0/1     Pending    0          6m30s
monitoring        macropower-analytics-panel-server-745f8f5989-bszbs              0/1     Pending    0          6m31s
monitoring        oauth2-proxy-757c9bb77f-rmnc8                                   0/1     Pending    0          6m30s
monitoring        promxy-app-87dd79d64-rtqm7                                      0/2     Pending    0          6m29s
monitoring        promxy-app-87dd79d64-tznkc                                      0/2     Pending    0          6m30s
monitoring        silence-operator-dff7b9944-59jz8                                0/1     Pending    0          12m
monitoring        silence-operator-sync-27830195-5zsqv                            0/1     Init:0/1   0          2s
org-giantswarm    dextest04-app-operator-66f9cf6d5b-lpprb                         0/1     Pending    0          66m
org-giantswarm    grizzly-app-operator-574dfc86f9-9lh5v                           0/1     Pending    0          67m
org-giantswarm    k1ng-app-operator-769d47984b-zv4d2                              0/1     Pending    0          66m
org-giantswarm    mari1-app-operator-6cd6d6979f-cgjtj                             0/1     Pending    0          67m
org-giantswarm    t03372532-app-operator-85dcfbc6c6-7mxbl                         0/1     Pending    0          58m
org-giantswarm    t033931133-app-operator-7b9458687d-4vzkh                        0/1     Pending    0          16m

@AverageMarcus was suggesting having a single node pool for the worker nodes I think. Can we have a single node pool spread across multiple AZs?

@fiunchinho the main thing is making sure that there is a node pool with more than a single replica. Otherwise all nodes get rolled at the same time.

The management cluster has 3 machine pool:
❯ k --context gs-grizzly -n org-giantswarm get machinepools -A | grep -i grizzly
org-giantswarm   grizzly-def00a             grizzly      2          ScalingUp   14d     v1.23.13
org-giantswarm   grizzly-def00b             grizzly      1          Running     14d     v1.23.13
org-giantswarm   grizzly-def00c             grizzly      1          ScalingUp   14d     v1.23.13

I mixed it with our test workload clusters which have only one machine pool.
I updated the issue to mention that the number of worker nodes should be doubled.

Can we have a single node pool spread across multiple AZs? I see that we can specify a list of AZs in the nodepool definition so I'm guessing it's possible to have a single nodepool

Yes that also works. The problem you have then is cluster-autoscaler (when we have it) wont be able to balance AZs anymore

We agreed to not increase the size of the control plane nodes because the issue should be fixed just by adding additional worker nodes.

authors: AverageMarcus alex-dabija fiunchinho

repo: giantswarm/roadmap


text:
Access API Server Internal Load Balancer from CP nodes via the second NIC

Is your feature request related to a problem? Please describe.

When deploying private CAPZ clusters, CAPZ is deploying an internal load balancer (ILB) which is used for accessing the API server.
Due to how Azure ILB works, a control plane node (ILB's backend machine) trying to access the API server via the ILB's frontend IP will fail to do so because of hairpin routing issue. As Azure docs mention it here:

Outbound flow from a backend VM to a frontend of an internal Load Balancer will fail.

More elaborate explanation and a sample setup that simulates the issue can be found here.
In a nutshell, a machine behind the ILB cannot access other machines behind the ILB by going via the ILB itself (at least not out of the box).
Due to this problem, in the current alpha implementation of CAPZ provider support, we have mitigated this issue by modifying the /etc/hosts file on the control plane nodes in a way that is described below.
For example, for the workload cluster hellowc with base domain example.com, the following line is added to /etc/hosts file on control plane machines:
127.0.0.1   apiserver.hellowc.example.com apiserver

The above line is added to control plane machines in two different ways:

For the first control plane machine, the /etc/hosts file is modified before executing kubeadm init (done with preKubeadmCommands in KubeadmControlPlane resource).

This way the first control plane machine is accessing only its own local API server replica.

First all other control plane machines, the /etc/hosts file is modified after executing kubeadm join (done with postKubeadmCommands in KubeadmControlPlane resource).

This way the other control plane machines are accessing API server still via ILB before and while joining the cluster. This means that a certain percentage of API server requests, those that get routed via ILB to the same machine, will fail.
After other machines have joined the cluster, they will access its own local API server replica.

With the aforementioned mitigation, all control plane nodes are accessing API Server only locally, which means that high availability of control plane is reduced overall, as it does not work from the point of view of a control plane node (since all control plane nodes access only their own local API server replicas).
The current mitigation described above is not bulletproof and, as described, has its downsides.
Describe the solution you'd like

There are 3 different solutions that are suggested here as possible workarounds for the above described issue.
Proposed solution here is to add second NIC (network interface) to the control plane nodes and route all requests to ILB via that NIC.
Roughly speaking, there are two things to be done here.
First, add the second NIC to every control plane node.
CAPZ has support for specifying multiple network interfaces (NICs), so these can be specified in KubeadmControlPlane's AzureMachineTemplate.
And second, route all request to ILB frontend IP via the second NIC.
Here it says:

Configure local (O/S level) static route forcing traffic destined to the LB VIP out of the secondary NIC

This can be accomplished in a few different ways:

With preKubeadmCommands in KubeadmControlPlane, similarly to the current mitigation.
For Flatcar with Ignition, which can be customized in KubeadmControlPlane. See Network configuration with networkd to get an idea, checkout there an example for configuring static routes.

If possible, the solution is implemented directly in the upstream CAPZ project.
Describe alternatives you've considered

There are other alternative solutions that are described here:

Creating load balancer with Floating IP (direct server return, abbr. DSR) enabled, see more details here. This has some similar downsides as our current mitigation.

All API server requests from the control plane node would be served only by local API server replica.
Destination IP for all network packets would be ILB's frontend IP. OTOH, with DSR disabled (default behavior), the packet delivered to the ILB's backend machine (control plane nodes) would have a destination IP address of the ILB's backend machine IP itself (IP of control plane node).

Using Application Gateway as described here.

Additional cost.
It has known non-trivial performance issues, see official GitHub issue here and a blog post here which describes the issue as a "fundamental design flaw".

Additional context

Upstream links:

A Slack thread in Kubernetes Slack that describes the mitigation that we currently have in place (modifying /etc/hosts file).

Lets keep in mind we'll need to update cilium configuration if we have multiple NICs to ensure we use the right one for the kube-proxy replacement - https://docs.cilium.io/en/v1.11/gettingstarted/kubeproxy-free/#nodeport-devices-port-and-bind-settings

@T-Kukawka could you check if this one is still relevant? it is for CAPZ

@gawertm it is on our board so we will re-check this once we actually touch CAPZ again

authors: T-Kukawka gawertm nprokopic primeroz


text:
Create unit test / CI

Perform CI (purest) for code reviews. I am not entirely sure about how to do that for Jupyter notebook (.ipynb) but was reading around the internet and it seems like catching the error when converting it to .py file is the way to go.

Also pep3 lint test

[x] Create flake8 (pep8) lint test whenever pull-request occurs. This applies to all .py file. See #30
[ ] Create flake8 for Jupyter notebook

I think since we are not building a package or library, it doesn’t make send to do too much testing. At this point pep8  linting and if the codes run without error, that should be a good starting point.

Finally found the solution to deal with module, testing and version control with notebooks. The nbdev package of fast.ai provides such a solution. See https://www.fast.ai/2019/12/02/nbdev/
It also generates documentations so that you can read the notebook like a HTML page with figs and etc. I guess that's how fast.ai courses are built.
We could potentially use this tool to build up a static markdown page as a textbook-like page.

There are two other solutions that are closely related to the above development: https://github.com/jupyterlab/jupyterlab-git and https://www.reviewnb.com
Might be interesting to think about version control with this as well

Finally, we can imagine going all colab. If notebooks can work out to be the main way to go and we use colab as our prefer 'IDE', nbdev + colab is a possible way to standardise everything.
See https://forums.fast.ai/t/using-nbdev-with-google-colab/61755/12


text:
Accessor improvements

This PR extends the the accessor by adding overloads to math functions for the accessor references, so conj() can be called directly on an accessor with a custom reference. Tests for both the math functions and for all functionalities for the references was also added.
Additionally, the functions as_cuda_range and as_hip_range were added to help with the conversion std::complex -> thrust::complex.
TODO:

[x] Merge #677
~Merge #719~ (Edit: no longer necessary since #719 does not use any accessor functionality)
[x] Adopt merged code to this PR by removing work-arounds (done for #677)
[x] Clean up commit history
[x] Instead of overloading the math functions (real, conj, ...), use a helper struct (unpack or similar) to determine the actual return type of the Ginkgo math functions (and remove the overloads from the reference objects).

format!

format!

repo: ginkgo-project/ginkgo


text:
Added a placeholder for FrontEnd.

Creating a placeholder PR for Front End. Do not merge yet.

Description 📜
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes #52.

Type of change 📝

[ ] Audio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
[ ] Video (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
[x] Documentation (Content Creation in the form of codes or tutorials)
[ ] Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

[ ] Android Dev (Flutter, Java, Kotlin)
[ ] Backend Dev (Java, .NET, Python)
[ ] C/CPP
[ ] Competitive Programming
[ ] Cyber Security
[ ] DSA
[ ] Database
[ ] Datascience with Python
[ ] Datascience with R
[x] Frontend Dev (HTML, CSS, JS)
[ ] Frontend Dev (React, Angular, Vue)
[ ] Golang
[ ] Interview Prep
[ ] Java
[ ] JavaScript
[ ] MERN
[ ] Machine Learning
[ ] Open Source
[ ] Python
[ ] Rust
[ ] Statistics
[ ] UI/UX

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

LGTM 👍🏻

@praveenscience  I think you need to create PR for your branch i.e FEWD

@Aryamanz29 Ah, got it! :)

authors: Aryamanz29 ghulamyazdani praveenscience

repo: girlscript/winter-of-contributing


text:
RFC: Adds coercion instances: Coe Nat Interval and Coe Rat Interval

Some more careful thinking is needed about what effects adding coercions has and if all of them are desirable.
Closes #7

I think you need to change the Nat one to be NatCast, per https://leanprover-community.github.io/mathlib4_docs/Init/Data/Cast.html#NatCast. Can you add an IntCast one at the same time? Hopefully the NatCast change will fix the ambiguity issue.

I used IntCast and NatCast. Which ambiguity issue did you mean?
Do you agree with the goal that "if an expression which can be interpreted as Interval and as Real, the interpretations should be in an approx relationship"? I would perhaps try to add some tests.

authors: adomasbaliuka girving

repo: girving/interval


text:
Resetting the Popup Boxes

I started using the app to create Timelapse of various satellite images and it has been very useful in understanding the spatiotemporal changes. I would like to give a suggestion that may enhance better user experience.

While drawing polygon, for each click, the lat-long popup box creates an obstacle. Each time the box needs to be closed to select the next point. Moreover, the Finish | Delete Last Point | Cancel box hides some areas. Zooming in sometimes helps in this issue, but I think shortening or realigning these two boxes can make it easier in selecting the AOI.

Thank you for the suggestion. Thank lat-lon popup has been disabled. I have no control over the Finish | Delete Last Point | Cancel box. You can use the Fullscreen button to make the map view larger if needed.

authors: GOItPadma giswqs

repo: giswqs/streamlit-geospatial


text:
Related Issues not found  Please contact @Meloor to initialize the comment

博客地址：https://meloor.gitee.io/
OAuth 配置两个url都是https://meloor.gitee.io/
yml配置
gitalk:   enable: true   client_id:    client_secret:    repo: BlogTalks #写仓库名 BlogTalks   owner: Meloor   admin: Meloor
Ps: 我的博客是用的giteepage, 评论仓库在github名字是BlogTals

博客名是BlogTalks

仓库名是BlogTalks, 仓库在github

我跟你一样 兄弟

兄弟 换这个集成吧 --> https://www.jianshu.com/p/b9e73c881729
gitee部署的hexo集成GitHub提供的评论系统，感觉是回调链接跳转那里的问题

解决办法:
设置:
admin: [Meloor]
接下来，需要gitalk的admin用户(你这里是Meloor)到你网站的某一个具体文章页面授权github登陆，可完成初始化。

解决办法:
设置:
admin: [Meloor]
接下来，需要gitalk的admin用户(你这里是Meloor)到你网站的某一个具体文章页面授权github登陆，可完成初始化。

能麻烦说详细一点吗？”设置“是在哪里？

解决办法:
设置:
admin: [Meloor]
接下来，需要gitalk的admin用户(你这里是Meloor)到你网站的某一个具体文章页面授权github登陆，可完成初始化。

能麻烦说详细一点吗？”设置“是在哪里？

解决办法:
设置:
admin: [Meloor]
接下来，需要gitalk的admin用户(你这里是Meloor)到你网站的某一个具体文章页面授权github登陆，可完成初始化。

能麻烦说详细一点吗？”设置“是在哪里？

兄弟你解决了吗？我也约到这个毛病了，实在搞不定我就换成Valine 算了

解决办法:
设置:
admin: [Meloor]
接下来，需要gitalk的admin用户(你这里是Meloor)到你网站的某一个具体文章页面授权github登陆，可完成初始化。

能麻烦说详细一点吗？”设置“是在哪里？

兄弟你解决了吗？我也约到这个毛病了，实在搞不定我就换成Valine 算了

设置，是指下面的代码:
const gitalk = new Gitalk({
  clientID: 'GitHub Application Client ID',
  clientSecret: 'GitHub Application Client Secret',
  repo: 'GitHub repo',      // The repository of store comments,
  owner: 'GitHub repo owner',
  admin: ['Meloor'],
  id: location.pathname,      // Ensure uniqueness and length less than 50
  distractionFreeMode: false  // Facebook-like distraction free mode
})

gitalk.render('gitalk-container')

官方文档提到的配置~

设置，是指下面的代码:
const gitalk = new Gitalk({
  clientID: 'GitHub Application Client ID',
  clientSecret: 'GitHub Application Client Secret',
  repo: 'GitHub repo',      // The repository of store comments,
  owner: 'GitHub repo owner',
  admin: ['Meloor'],
  id: location.pathname,      // Ensure uniqueness and length less than 50
  distractionFreeMode: false  // Facebook-like distraction free mode
})

gitalk.render('gitalk-container')

官方文档提到的配置~

authors: Meloor leeksisn wuyingxue1230 xiaomingaZz yanglr

repo: gitalk/gitalk


text:
Windows batch file to create documentation

This is the windows batch file script for those who want to run it via windows command line to generate documentation.

AI Code Review is in progress (usually takes <10 minutes unless it's a very large PR).

authors: BitoAgent bitoandy

repo: gitbito/AI-Automation


text:
powertools seems not to be working

$ ssh -l admin -p 29418 localhost plugin ls
Password authentication
Password:
╔═══╤════════════╤═════════╤═════════╤═══════════════════╗
║ # │ Id         │ Version │ State   │ Path              ║
╠═══╪════════════╪═════════╪═════════╪═══════════════════╣
║ 1 │ powertools │ 1.3.0   │ STARTED │ /powertools-1.3.0 ║
╚═══╧════════════╧═════════╧═════════╧═══════════════════╝

Trying to get help for the "users" command reports an error:
$ ssh -l admin -p 29418 localhost users --help
Password authentication
Password:
Gitblit: users: not found

What am I doing wrong here?
BTW, the README.md does neither has a command to get a list of all commands nor the actual command list, added by the powertools plugin.

Looking at the following ASCIICinema clip explained the mistake:
https://asciinema.org/a/9342

repo: gitblit/gitblit-powertools-plugin


text:
pptx.shapes not recognised by Typescript

Hello
I'm trying to add shapes in a project with typescript, but the entity .shapes in pptx is not recognised.
This simple code
const pptSlide = pptx.addSlide(slide.title);
pptSlide.addShape(pptx.shapes.RECTANGLE, {});

results in:
any
Property 'shapes' does not exist on type 'PptxGenJS'.ts(2339)

I see the there's a collection of shapes (PowerPointShapes), but maybe this collection is not included in the types declaration?

I am still facing this issue in version 3.12.0. Below are the error i am getting. i am using angular version 8.2
847  export type Coord = number | ${number}%
error TS2339: Property 'shapes' does not exist on type 'PptxGenJS'.
 error TS2559: Type 'string' has no properties in common with type 'ShapeLineProps'.

authors: abhinavek dasilvaluis

repo: gitbrent/PptxGenJS


text:
🛑 invidious.privacydev.net is down

In 83ab114, invidious.privacydev.net (https://invidious.privacydev.net/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: invidious.privacydev.net is back up in 0bacc85 after 5 minutes.

repo: gitetsu/invidious-instances-upptime


text:
🛑 search.mascotboi.xyz is down

In 5a38318, search.mascotboi.xyz (https://search.mascotboi.xyz/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: search.mascotboi.xyz is back up in d22950d after 44 minutes.

repo: gitetsu/librex-instances-upptime


text:
🛑 search.mascotboi.xyz is down

In aa8bc5c, search.mascotboi.xyz (https://search.mascotboi.xyz/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: search.mascotboi.xyz is back up in acca77c after 18 minutes.


text:
🛑 whoogle.lunar.icu is down

In bd01669, whoogle.lunar.icu (https://whoogle.lunar.icu) was down:

HTTP code: 0
Response time: 0 ms

Resolved: whoogle.lunar.icu is back up in cdc910f after 13 minutes.

repo: gitetsu/whoogle-instances-upptime


text:
🛑 whoogle.privacydev.net is down

In 5dab95c, whoogle.privacydev.net (https://whoogle.privacydev.net) was down:

HTTP code: 0
Response time: 0 ms

Resolved: whoogle.privacydev.net is back up in 54d5907 after 6 minutes.


text:
🛑 wwg.vern.cc is down

In 6272f1d, wwg.vern.cc (https://wg.vern.cc) was down:

HTTP code: 0
Response time: 0 ms

Resolved: wwg.vern.cc is back up in ab56ef2.


text:
Capture and Process Diagnostic and Metric Summary Output in codeql-action/analyze@v2

I am currently utilizing the github/codeql-action/analyze@v2 action to execute CodeQL analysis within my GitHub Actions workflow. While the action successfully generates diagnostic and metric summary output, I am facing challenges in capturing and processing this output to make decisions regarding the success or failure of the workflow based on critical or warning data.
I have attempted various approaches, such as printing the returned output for debugging purposes and inspecting the log files, but unfortunately, I have not been able to locate any stored logs or find a reliable method to capture the necessary information.
one of the logic I tried
- name: Perform CodeQL Analysis
  id: codeql
  uses: github/codeql-action/analyze@v2
  with:
    category: "/language:${{matrix.language}}"

- name: Print Output
  run: |
    echo "CodeQL Analysis Output: ${{ steps.codeql.outputs }}"
    echo "${{ steps.codeql.outputs }}"
    echo "${{ steps.codeql.outputs['db-locations'] }}"
    echo "${{ steps.codeql.outputs['sarif-id'] }}"

I would greatly appreciate any guidance or suggestions.
Thanks!

So, you are looking to fail the codeql analysis workflow if there are any alerts that are discovered? This is not the typical way that the workflow is run. Usually, after analysis, all alerts are sent up to the code scanning back end so that duplicated alerts, false positive alerts, ignored alerts, etc can be ignored. There is another check run that will fail if codeql finds any true positive alerts.
It sounds like you are trying to do something different. Can you explain what your goals are?

Let me explain more clearly. My codeql analysis produces below summary diagnostic & metric data
Analysis produced the following diagnostic data:

|                    Diagnostic                     |       Summary        |
+---------------------------------------------------+----------------------+
| Python extraction warnings                        | 1 result (1 warning) |
| Could not process some files due to syntax errors | 1 result (1 warning) |
| Successfully extracted Python files               | 60 results           |

Analysis produced the following metric data:

|                         Metric                          | Value  |
+---------------------------------------------------------+--------+
| Total lines of user written Python code in the database |   1477 |
| Total lines of Python code in the database              | 126978 |

Now, my objective is to fail the workflow based on the generated summary data. I have attempted to implement an additional step that captures the output and applies regular expressions to identify any critical or warning messages within the diagnostic or metric data which is not working. In the provided example analysis, I would identify warnings in the "Python extraction warnings" and "Could not process some files due to syntax errors" sections, resulting in the workflow being failed.
The step I had added which doesn't work:
   - name: Perform CodeQL Analysis
      id: codeql
      uses: github/codeql-action/analyze@v2
      with:
        category: "/language:${{matrix.language}}"

   - name: Check for critical or warnings
      run: |
      # Retrieve the number of critical issues from the CodeQL analysis results
        critical_issues=$(jq '.annotations[] | select(.properties.severity == "critical")' "${{ steps.codeql.outputs.codeql-results }}")

      # Fail the build if there are critical issues
        if [[ $critical_issues ]]; then
          echo "Critical issues detected:"
          echo "$critical_issues"
          exit 1
        fi

Additionally, I would like to emphasize that despite my efforts, I have been unable to find a suitable solution to capture and process the diagnostic and metric summary data in order to determine whether the workflow should fail or not based on the presence of critical or warning messages. Therefore, I am seeking guidance and assistance from the team to help me achieve this desired outcome.

Thanks for the explanation. Just to be sure I'm understanding, your goal is to fail the workflow if there are any extractor warnings?
I will ask the people involved with diagnostic information on the best way forward.

In the analyze action, set the output parameter as an input in the with block. This will determine the directory where the SARIF is saved. Once you have that, in the next step, use jq to look for toolExecutionNotifications with level: warning or level: error.
Be aware, though, that diagnostic information is generally meant to be internal. Sometimes there will be warnings or messages around things that are unrelated to the code being extracted.
In general, messages like Could not process some files due to syntax errors are things that are better tracked by using a source code linter. Perhaps a more robust way of handling this situation is to run a python linter like ruff as part of CI.

authors: aeisenberg swakhil-strobes

repo: github/codeql-action


text:
Environment variable docs are inconsistent about GITHUB_ prefix

The Naming Conventions for Environment Variables documentation says:

Note: GitHub reserves the GITHUB_ environment variable prefix for internal use by GitHub. Setting an environment variable or secret with the GITHUB_ prefix will result in an error.

However, the example in jobs.<job_id>.steps[*].env sets a GITHUB_TOKEN environment variable. Which is correct?

Thanks for opening an issue @nex3! I'll triage this for the team to take a look 👀

Thanks for opening an issue @nex3! I'll triage this for the team to take a look 👀

Hi @nex3 - Many thanks for raising this issue. 👍
Both of the pages you refer to are correct. The GITHUB_ name is reserved for use by GitHub. One such use is the GITHUB_TOKEN secret that allows you to reference an automatically created GitHub App installation access token in an Actions workflow, as shown in the example on the second page you refer to.
For more information about GITHUB_TOKEN see: https://docs.github.com/en/actions/reference/authentication-in-a-workflow
I'm going to close this issue, but thanks for checking this with us and, of course, if you'd like to discuss this more please get back to us.

@hubwriter The issue is that the example in jobs.<job_id>.steps[*].env doesn't just reference the GITHUB_TOKEN secret, it actually sets an environment variable named GITHUB_TOKEN to the value of that secret, which is forbidden according to the environment variable docs.

@nex3 - Thanks for coming back about that. 👍🎖
I think we need to change the env var name here: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstepsenv
I'll get that confirmed here and then we can ask for a community quick fix of that page.

The text in the note box is incorrect. The GITHUB_TOKEN environment variable is often set in a workflow, and we have examples of this in the documentation. I've tested setting environment variables in workflows and using the GITHUB_ prefix does not result in an error. However, if you try to set a value to the default ones listed in the table here, the assignment does not work.
So we should remove the note on that page and replace it with a statement about trying to reuse the names of the default env vars.
i.e. in content/actions/reference/environment-variables.md, change:
{% note %}

**Note:** {% data variables.product.prodname_dotcom %} reserves the `GITHUB_` environment variable
prefix for internal use by {% data variables.product.prodname_dotcom %}.
Setting an environment variable or secret with the `GITHUB_` prefix will result in an error.

{% endnote %}

to a simple paragraph (rather than a note):
When you set a custom environment variable, you cannot use any of the default environment variable names
listed above with the prefix `GITHUB_`. If you attempt to override the value of one of these default
environment variables, the assignment is ignored.

@nex3 - Many thanks again for raising this, and for coming back when I incorrectly closed the issue. Kudos to you for bringing this to our attention.

authors: hubwriter janiceilene nex3

repo: github/docs


text:
Document jobs.<job_id>.defaults.run.working-directory

Documents jobs.<job_id>.defaults.run.shell
Refactors a number of elements into data.reusables
Adds warning that working-directory must exist

Why:
Closes: #31346

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[ ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[ ] For content changes, I have completed the self-review checklist.

@jsoref Hello! 👋 Let us know once this PR is ready for review

I suspect it's ready now (I needed that one rendering to figure out dashes...)

@jsoref Roger that! I'll move this to "ready for review" status and triage for review shortly 👍


text:
spelling error in the short-description

straming -> streaming
Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[ ] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[x] Suggesting edits to an existing topic or collection
[ ] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288)
[x] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[ ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ ] My folder contains a *.png image (if applicable) and index.md
[ ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

there was a tiny spelling error

Thanks again @mahtab-nejati!

authors: MikeMcQuaid mahtab-nejati

repo: github/explore


text:
Update ExtJS.gitignore

Reasons for making this change:
Ignore folders .sencha and sass/example

@devgaspa any links to StackOverflow discussions or other documentation about this change?

In fact these files should remain on git. thanks!

authors: devgaspa shiftkey

repo: github/gitignore


text:
Custom listenerMiddleware Problem

Hi All,
I'm working on an additional security layer feature for hubot involving two factor authentication with Verisign VIP and am just battling to get my head around how hubot and middleware work.
My middleware code seems to work as expected when chatting directly to hubot (private message) but it's not working correctly when it receives messages from users in a room.
Here is my middleware code:
module.exports = (robot) ->

  robot.listenerMiddleware (context, next, done) ->

    allowed_commands = [ "help", "ping" ]
    # Grab just the command issued, eg "ping" and not "hubot ping"
    command = context.response.message.text.slice(10)

    # Allow if any of our excluded commands are issued otherwise deny
    if command in allowed_commands
      next(done)
    else
      context.response.send "That command is not allowed"
      done()

My aim with the code above is:

if "hubot help" or "hubot ping" is issued, run it as normal...
if anything else is issued to hubot, deny and stop

Testing from a private chat message with hubot:
dave> hubot blah
hubot> That command is not allowed

dave> hubot ping
hubot> pong!

That worked just the way I expected it too: allow certain commands and deny the rest.
Now a test from a chat room to hubot:
dave> hubot blah
hubot> That command is not allowed

Great, just as expected but now when I try issue an allowed command I get the following:
dave> hubot ping
hubot> That command is not allowed
hubot> That command is not allowed

This is my problem. I'm not sure why it's not allowing that command or why it's sending a double response back. I'm using Hubot 2.18.0 and the hubot-hipchat adapter 2.12.0
Unfortunately my coffeescript and coding skills are not great. If anyone could shed some light on this problem or possibly point me in the right direction I'd really appreciate it!
Thanks!
Dave

Managed to solve this one. There were 2 issues.
When I issued something like this to hubot:
dave> hubot blah

In a room, context.response.message.text is:
hubot blah

While in a private message to hubot, context.response.message.text is:
Hubot:  blah

So to grab just the command issued to hubot, I had to check if it was issued from a room first and if so then apply a different slice..
    # Strip the first characters so we're left with just the command issued...
    if context.response.message.user.room?
      # hubot blah
      command = context.response.message.text.slice(6)
    else
      # Hubot:  blah
      command = context.response.message.text.slice(8)

Now it works the same for a room or a private message.
The next issue was where it was returning "That command is not allowed" twice in a room. This was solved by dropping the last done().
For anyone interested, here's the full middleware code I'm using to intercept messages and first check if a user has verified with 2 factor authentication before the command runs. There are any pieces which work together here but this is just the middleware I'm using:
  # Catch all attempted commands and first check that the user is verified before allowing them
  # to run any commands. If not verified, tell them how it's done...

  robot.listenerMiddleware (context, next, done) ->

    name = context.response.message.user.name
    user = robot.brain.userForName(name)

    # Exclude some commands as all users need to be able to use verification funtions
    excluded_commands = [ "status", "users", "help", "ping" ]

    # Verify needs some regex magic...
    regex_verify = /// ^                # begin of line
      verify                            # the word "verify"
      .                                 # followed by a single space
      [0-9.]{6}                         # then exactly 6 digits, can also use [0-9][0-9][0-9][0-9][0-9]
      ///i                              # end

    # Strip the first characters so we're left with just the command issued...
    if context.response.message.user.room?
      # hubot blah
      command = context.response.message.text.slice(6)
    else
      # Hubot:  blah
      command = context.response.message.text.slice(8)

    # Allow if any core commands are issued
    if command in excluded_commands or command.match regex_verify
      next (done)
    else
      # Allow if user is currently verified
      if user.vip_status == "verified"
        next (done)
      else
        # Deny if user is not verified
        if user.vip_status == "never" or user.vip_status == "failed" or user.vip_status == "expired"
          context.response.send "Bot access denied. You need to verify first using two-factor authentication before I can trust you."
          context.response.send "To verify, type: #{robot.name} verify <your 6 digit OTP number>"

Thanks!
Dave

@michaelansel I would really love to see how you guys are handling this with 2 factor authentication! :)

Didn't get a chance to respond right away, but a few comments:

Use robot.respondPattern(/(.*)/).match(context.response.message.text) (or something pretty close to that), not sure it is official API, but I promise it is better than using slice.
You should be calling done when denying access. If you are seeing double responses, figure out why rather than breaking the API (and potentially any other middleware). Adding in receiveMiddleware is one way to get a lot of debugging information (hooks into message processing before listener matching occurs, so you can see if there are double messages coming from the adapter or if you just have multiple listeners matching, which triggers multiple executions of the middleware stack).
Take a look at these docs if you haven't already: https://hubot.github.com/docs/patterns/#restricting-access-to-commands
The 2FA code I wrote is kinda gross (hence no open source yet), but I ended up separating out validation completely like it looks like you have. Currently unwritten is token expiration. I would recommend doing something like robot.auth.hasValidSecondFactor(user) and shoving all the logic in there. Building an API for that is somewhere on my backlog, but maybe just hacking in whatever (like what you have) is fine. I need more hours in my life... 😓

Overall, I think this is a great use of middleware. Good luck!

Thanks for sharing this @justdaver!
(Also, thanks for posting how you solved your problems, since that's always helpful!)

Thanks @cycomachead no problem, much appreciated! When I've completed this project I'll upload all the bits and pieces that work together with it, hopefully someone out there might find it useful :)

Thank you for taking the time to respond to my post and include some great tips @michaelansel :) Really appreciate that. I'm busy ironing out some of the bugs and reworking a few things as you suggested, once done I'll post my solution and see if anyone finds it useful.
Please let us know when you code up a hubot module to help us all find more hours in our lives :laughing:

authors: cycomachead justdaver michaelansel

repo: github/hubot


text:
"Who are we helping" metric

Some InnerSource projects essentially provide platform capabilities for the organisation, meaning that they "only" have internal teams as customers. Understanding and talking about the customer value and business value of these platforms sometimes can be tricky.
With a bit of a workaround though it becomes easier: Look at issues and PRs created and check which team (filtered down to e.g. product teams with external customers) the reporter is assigned to. Then provide aggregate information on how many times each of these teams was unblocked by solved issues and how many times such teams were able to unblock themselves with PRs.

Wow, this would certainly be interesting!
When you mention "teams" would that correlate to teams in a github organization or are you thinking that would connect to some type of active directory system that could be queried for a username's team membership?

Active directory would be lovely. But as a first approximation I believe regular GitHub teams could already be helpful. While those can be cluttered, I can imagine that one could provide a whitelist of team names to use for this so that anything like "I love Open Source" GitHub teams that my user may be part of in that organisation can be filtered away (though come to think of it, it would be interesting if it's the open source lovers that produce more PRs internally also ;) )

Awesome InnerSource metric in the making here :)
I can imagine this to be a helpful metric for many people.
Worth noting that the "who are we helping" could be a combination of
a) who is using the project (similar to the dependents view in GitHub)
b) who is opening issues/PRs on our repo

Note for myself - someone pointed out a step in between that might be helpful here:
https://github.com/marketplace/actions/team-labeler-action ... adds team labels to PRs which can then likely could be used in a later step to compute statistics per team/label.

Looking into this a bit more - the action above seems to rely on it's users to feed it with the github user/ team relationship. So in addition to keeping users in the right teams on github one would also need to update that configuration.
In an ideal world, I would like to only feed in team names to consider and commenters found only check if their team matches one of the pre-configured team names.
The trouble with that though: The GitHub REST API seems to only allow retrieving entire team+members data, but I see no link from a pr/issue comment -> user -> team. The workaround I found online also relies on retrieving the entire team-membership data up-front. Am I missing something here? Otherwise I'd try to make team names to consider configurable, retrieve team membership up-front (though for large organisations this could mean trouble) and continue from there.

Some InnerSource projects essentially provide platform capabilities for the organisation, meaning that they 'only' have internal teams as customers. Understanding and communicating the customer value and business value of these platforms can sometimes be tricky.

https://a-a-ron.github.io/innersource-completed-pluralsight/rollout-checklists/ ... also details several InnerSource related metrics that are based on a notion of identifying where PRs are coming from.

authors: MaineC singha04 spier zkoppert

repo: github/issue-metrics


text:
Feature Request: Invite team members to organization if they are not a member yet

Currently team sync can only add users to a team if they are already a member of the organization.
Is it possible to have the team sync app also invite members if they are not a member yet?

Yes, this is definitely something that can be added :thumbs:

This was implemented in #76, but needs to be documented

implemented by #80

needs documentation

authors: primetheus stoe

repo: github/ldap-teamsync


text:
Cococapods enumeration using cocoapods plugin

closes https://github.com/github/licensed/issues/636
This PR adds support for cocoapods without introducing a direct dependency on the cocoapods-core gem.  See the linked issue for full context, with a TL;DR that the additional nested dependency version requirements on common gems included from cocoapods-core made it difficult for downstream licensed users to install licensed alongside other usages of those same dependencies.
As an alternative approach to taking a direct dependency on the cocoapods-core gem, I created a pod CLI plugin at jonabc/cocoapods-dependencies-list which outputs dependency information as JSON.  The plugin was made pretty specifically for licensed but I suppose it's possible for the data output to be used by other tools as well.  I searched rubygems for a plugin that might already support licensed's usage but it looked like all existing plugins output graph visualizations of dependencies.
This PR uses the new plugin to enumerate cocoapods dependencies without taking any hard dependencies on cocoapods gems.

cc @LouisBoudreau FYI I'm going to merge this and put out a new release of licensed with cocoapods enabled.  If you have cocoapods projects that you were planning to use licensed for, could you give the new release a try when it's out and let m know how everything works out between licensed, the cocoapods plugin, or anything else related to this integration?

repo: github/licensed


text:
Change default branch to master

This should be more obvious to people unfamiliar with GitHub Pages.

Merging despite flaky HTML proofer link detection failure.


text:
gitleaks detect consistently reports wrong commit information for some secrets

Describe the bug
gitleaks detect consistently reports the wrong commit information (Commit, Author, Email, Date, Message) for many findings.
The StartLine, EndLine, StartColumn, EndColumn, Match, Secret, and File are all correct.
We've observed this across several unrelated repositories.
(speculation) It looks like there may be a bug with parsing the git logs, as the Message field looks like it's appending git log information from the CORRECT commit. For example, in the example below, the commit message gitleaks detect reports is:
Merge branch 'BLAKE3' of github.com:BoloniniD/ClickHouse into BLAKE3

commit 645e156af6b362145fad82d714f8e70a5b5a55a8
Author: Meena Renganathan <Meena.Renganathan@ibm.com>
Date:   Wed Apr 6 14:50:10 2022 -0700

Updated the boringssl-cmake to match the latest broingssl module update

but the message for f6ded7a51cf917bdb44097066fab608c0facde5b is just
Merge branch 'BLAKE3' of github.com:BoloniniD/ClickHouse into BLAKE3

but if we git log 645e156af6b362145fad82d714f8e70a5b5a55a8 (id taken from the "leaked" Message), we have:
commit 645e156af6b362145fad82d714f8e70a5b5a55a8
Author: Meena Renganathan <Meena.Renganathan@ibm.com>
Date:   Wed Apr 6 14:50:10 2022 -0700

    Updated the boringssl-cmake to match the latest broingssl module update

To Reproduce

Clone https://github.com/nicholas-gitgoat/ClickHouse
Run gitleaks detect -r gitleaks.json

Should have output similar to below
9:00AM WRN warning: exhaustive rename detection was skipped due to too many files.
9:00AM WRN warning: you may want to set your diff.renameLimit variable to at least 1128 and retry the command.
9:00AM INF 74007 commits scanned.
9:00AM INF scan completed in 2m5s
9:00AM WRN leaks found: 849

Edit: Use gitleaks detect -s /home/nicholas/Projects/ClickHouse/ -r gitleaks.json --log-opts="^645e156af6^ 645e156af6 f6ded7a51cf917bdb44097066fab608c0facde5b" for a quicker scan that doesn't take 2 minutes, and also reproduces the issue

Open gitleaks.json and search for the Fingerprint f6ded7a51cf917bdb44097066fab608c0facde5b:contrib/boringssl-cmake/crypto_test_data.cc:generic-api-key:2897

{
  "Description": "Generic API Key",
  "StartLine": 2897,
  "EndLine": 2897,
  "StartColumn": 8277,
  "EndColumn": 8326,
  "Match": "key.y = 1e77f842b1ae0fcd9929d394161d41e14614ff750\"",
  "Secret": "1e77f842b1ae0fcd9929d394161d41e14614ff750",
  "File": "contrib/boringssl-cmake/crypto_test_data.cc",
  "SymlinkFile": "",
  "Commit": "f6ded7a51cf917bdb44097066fab608c0facde5b",
  "Entropy": 3.7105815,
  "Author": "BoloniniD",
  "Email": "denis@bolonin.ru",
  "Date": "2022-04-06T22:07:38Z",
  "Message": "Merge branch 'BLAKE3' of github.com:BoloniniD/ClickHouse into BLAKE3\n\ncommit 645e156af6b362145fad82d714f8e70a5b5a55a8\nAuthor: Meena Renganathan \u003cMeena.Renganathan@ibm.com\u003e\nDate:   Wed Apr 6 14:50:10 2022 -0700\n\nUpdated the boringssl-cmake to match the latest broingssl module update",
  "Tags": [],
  "RuleID": "generic-api-key",
  "Fingerprint": "f6ded7a51cf917bdb44097066fab608c0facde5b:contrib/boringssl-cmake/crypto_test_data.cc:generic-api-key:2897"
}

Open f6ded7a51cf917bdb44097066fab608c0facde5b:contrib/boringssl-cmake/crypto_test_data.cc and search for key.y = 1e77f842b1ae0fcd9929d394161d41e14614ff750"
4a) You can do git show f6ded7a51cf917bdb44097066fab608c0facde5b:contrib/boringssl-cmake/crypto_test_data.cc and in less use /key.y = 1e77f842b1ae0fcd9929d394161d41e14614ff750" to search.

You will get no results.

If you go to the specified StartLine (2897), you will find an empty line:

2896 static const size_t kLen57 = 465;
2897
2898 static const char *kData57[] = {

Expected behavior
Instead, for this specific finding, we would expect it to report Commit: "645e156af6b362145fad82d714f8e70a5b5a55a8"
Using that commit id, and looking in that file (git show 645e156af6b362145fad82d714f8e70a5b5a55a8:contrib/boringssl-cmake/crypto_test_data.cc) we find the exact Match, exactly where it's supposed to be.
Screenshots
N/A
Basic Info (please complete the following information):

OS: Xubuntu 23.10 (Linux 6.5.0-15-generic)
Gitleaks Version: 8.16.0-1ubuntu0.1

Additional context
You can find each instance of it reporting the wrong commit in a gitleaks report by searching for \n\ncommit.
cc @zricethezav

It MIGHT be related to #1028, but I have confirmed: in the example I provide above, the secret was introduced in 645e156af6b362145fad82d714f8e70a5b5a55a8, which is not a merge commit.

Okay, it's a similar but different issue from #1028.
The issue is that the header being returned is:
commit f6ded7a51cf917bdb44097066fab608c0facde5b
Merge: b2cf1cd0de 0254477421
Author: BoloniniD <denis@bolonin.ru>
Date:   Thu Apr 7 01:07:38 2022 +0300

    Merge branch 'BLAKE3' of github.com:BoloniniD/ClickHouse into BLAKE3

commit 645e156af6b362145fad82d714f8e70a5b5a55a8
Author: Meena Renganathan <Meena.Renganathan@ibm.com>
Date:   Wed Apr 6 14:50:10 2022 -0700

    Updated the boringssl-cmake to match the latest broingssl module update

So, all the diffs for 645e156af6b362145fad82d714f8e70a5b5a55a8 are being attributed to f6ded7a51cf917bdb44097066fab608c0facde5b.
I fix will have to be made to https://github.com/gitleaks/go-gitdiff

Hi @nicholas-arnica,
Thank you for opening this issue an providing plenty of detail, especially instructions on reproducing the behavior. This is truly a rockstar issue right here.
I'll start digging into this issue this week.

hi everyone, do you know the workaround for it?

Another example that I stumbled upon. (Wasn't there another issue for this that I commented in?
The reported path doesn't exist in 7815ce1d3197c4cd18d7a3b3aaf09d6fd22b278b.
Finding
Finding:     kind: Secret
metadata:
  name: environment
  namespace: kube-system
type: Opaque
data:
                        elasticsearch-password: Y2hhbmdlbWU=
Secret:      elasticsearch-password: Y2hhbmdlbWU=
RuleID:      kubernetes-secret-yaml
Entropy:     4.350209
File:        cluster/addons/fluentd-elasticsearch/env-secret.yaml
Line:        2
Commit:      84e0326eb1f108f0d7aa2e9e48fb0c4a8edb4bd5
Author:      Kubernetes Submit Queue
Email:       k8s-merge-robot@users.noreply.github.com
Date:        2017-08-02T19:46:57Z
Fingerprint: 84e0326eb1f108f0d7aa2e9e48fb0c4a8edb4bd5:cluster/addons/fluentd-elasticsearch/env-secret.yaml:kubernetes-secret-yaml:2

Commit Log
commit 7815ce1d3197c4cd18d7a3b3aaf09d6fd22b278b
Merge: 64a984bb626 be747993585
Author: Kubernetes Submit Queue <k8s-merge-robot@users.noreply.github.com>
Date:   Wed Aug 2 12:03:42 2017 -0700

    Merge pull request #50029 from cblecker/cblecker-hack-owners

    Automatic merge from submit-queue

    Add cblecker to hack/ owners

    This PR adds myself to the approvers list for `hack/`. I've been helping do a bunch of improvements here over the past few months, and want to continue doing so.

    I solemnly promise to use approval powers for good, and only approve things that I know are safe and within my area of expertise!

    ```release-note
    NONE
    ```
    /cc @ixdy @sttts @fejta @spxtr

commit 0ed0f02c7622ee2403992560ae00b10ab3bcb6ee
Author: Arve Knudsen <arve.knudsen@gmail.com>
Date:   Mon Jul 10 20:09:29 2017 +0200

    Upgrade Elasticsearch/Kibana to 5.5.1 and use official Kibana image

diff --git a/cluster/addons/fluentd-elasticsearch/env-secret.yaml b/cluster/addons/fluentd-elasticsearch/env-secret.yaml
new file mode 100644
index 00000000000..9e045135463
--- /dev/null
+++ b/cluster/addons/fluentd-elasticsearch/env-secret.yaml
@@ -0,0 +1,8 @@
+apiVersion: v1
+kind: Secret
+metadata:
+  name: environment
+  namespace: kube-system
+type: Opaque
+data:
+  elasticsearch-password: Y2hhbmdlbWU=

authors: egorbeliy nicholas-arnica rgmz zricethezav

repo: gitleaks/gitleaks


text:
🛑 CS-WEB is down

In 6857ee6, CS-WEB (https://cs.iotlabx.xyz) was down:

HTTP code: 0
Response time: 0 ms

Resolved: CS-WEB is back up in 679d592 after 16 minutes.

repo: gitsrc/upptime


text:
The calling order of event handlers is non-deterministic

It can be seen that (in events.go) the event handlers are called in a separate goroutine. Therefore, there is no guarantee of the order of the handlers being called.
This is especially harmful to keyboard events. Consider this situation: some characters are pasted to the terminal and so a bunch of keyboard events are generated in a short time, but the order of the corresponding handlers being called are kind of random. If the program is a text editor, the actual pasted text will be shuffled.
To fix the problem, event handlers should be called synchrously. A separate goroutine can always be created in the event handler if needed.
PS: The order of keyboard events seemed to be preserved after I changed two go statements (in evtKbd() and (*EvtStream) Loop()) to simple synchrounous function calls.

+1

@z-rui can you share the code changes you made?  I am trying to accept strings pasted from the clipboard but the characters arrived in scrambled order, and I suspect it is caused by the issue you've described here.

diff --git a/events.go b/events.go
index 177bbb4..3ff7fdd 100644
--- a/events.go
+++ b/events.go
@@ -126,7 +126,7 @@ func hookTermboxEvt() {
                e := termbox.PollEvent()

                for _, c := range sysEvtChs {
-                       go func(ch chan Event) {
+                       func(ch chan Event) {
                                ch <- crtTermboxEvt(e)
                        }(c)
                }
@@ -236,7 +236,7 @@ func (es *EvtStream) Loop() {
                case "/sig/stoploop":
                        return
                }
-               go func(a Event) {
+               func(a Event) {
                        es.RLock()
                        defer es.RUnlock()
                        if pattern := es.match(a.Path); pattern != "" {

Thank you @z-rui your patch fixed the problem for me.

authors: hasryan wanzysky z-rui

repo: gizak/termui


text:
refactor nodegen: support sequence operators

Pull Request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?
Tests do not support sequence operators.
This task emerged from implementing a sequence operator.
Issue Number: #336
What is the new behavior?

Tests support sequence operators

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

This PR is suggestion for a refactored nodegen. Adding support for sequence operators would have been challenging to implement. Now, there is a template for each family of files making the control flow more streamlined.
Some improvements include removing make_node() and nodegen no longer messes up existing Cairo files. Furthermore, nodegen is able to re-generate more tests than before and the failing tests seem to be edited manually to pass.

Looks great!! Thanks for this great improvement @TsBauer

authors: TsBauer raphaelDkhn

repo: gizatechxyz/orion


text:
Incorrect Number of Packages Shown

The packages page says they're are 258 packages when there are only 240 packages listed.

My main suspicion is that the reserved packages list is throwing things off. The query used to retrive the number of packages there are seems to account for deprecated packages but not the hidden packages.

Thank you.

repo: gleam-lang/packages


text:
🛑 Schoelcher is down

In 176df8c, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in f25f23e.

repo: glefait/martinique-public-websites


text:
🛑 Schoelcher is down

In 989d444, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in b641a81.


text:
🛑 Schoelcher is down

In eca1124, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 0af6066 after 5 minutes.


text:
🛑 Schoelcher is down

In 0236fa9, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 15d3755 after 5 minutes.


text:
🛑 Office du tourisme du centre de la Martinique is down

In 244152d, Office du tourisme du centre de la Martinique (https://tourisme-centre.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Office du tourisme du centre de la Martinique is back up in a35e2aa after 4 minutes.


text:
🛑 Mission locale du centre de la Martinique is down

In 572b7c2, Mission locale du centre de la Martinique (https://www.milcem.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Mission locale du centre de la Martinique is back up in e7414b1.


text:
🛑 Saint-Pierre is down

In 021d25c, Saint-Pierre (https://saintpierre-mq.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Saint-Pierre is back up in d906afd after 5 minutes.


text:
🛑 Schoelcher is down

In 713b52e, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 8aab573.


text:
🛑 Schoelcher is down

In 1cbd519, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in ad9cd09.


text:
🛑 Schoelcher is down

In 641a5b4, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 3a8e433.


text:
🛑 Schoelcher is down

In 4ef9058, Schoelcher (https://www.mairie-schoelcher.fr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Schoelcher is back up in 604f616.


text:
Implimentation of glfwGetWindowSizeLimits

I was creating a wrapper class for GLFWwindow and noticed that there is currently no way to obtain the minimum and maximum sizes of the window despite the information being stored in the underlying _GLFWwindow structure.

As per the documentation, the minimum size for any window is 1 in either width or height components. See
the docs for GLFWCreateWindow(). I'm not sure why you would need to "obtain" it if it already known and immutable. I'm not sure about retrieving the maximum window dimensions though.

repo: glfw/glfw

license: Zlib


text:
Command-tabbing fix

The new code uses presentation options to properly configure the application for fullscreen operation when appropriate.
Also, the window id is supplied as a parameter to the orderFront, makeKeyAndOrderFront, and orderOut calls instead of nil, which I believe is more correct.

Closed due to lack of activity.

I don't see how closing the pull request will help achieve anything. The owners of GLFW are busy and as long as it's an open pull request it's on a list of things to consider pulling in. The code you've added seem good to me so just keep it open and wait.

What @Shimmen said.

@Shimmen I appreciate your thoughts.
While I really like the clean and easy to use interface that GLFW provides, at its current level of development it's not suitable for my projects.  So, in my work, I use SDL (www.libsdl.org).
SDL provides a superset of the functionality of GLFW.  In fact, you could easily implement GLFW as a thin layer on top of SDL and (1) you'd get lots of additional functionality such as joystick events, proper hat switch and joystick trackball support, game controller support, touch device and gesture support, message boxes, etc. and (2) it would work on more platforms including iOS and Android.
With the PRs that I've submitted to GLFW, I've tried to address some of these deficiencies such as hat switch support #906 and joystick axis and button event support #856.  However, even at a more complete level of development, GLFW still would not provide the same level of cross-platform support that SDL does.  So, I never expected to benefit from these changes personally.
So, my real intention in making these PRs was to try to contribute, to try to do something useful that would help others.  However, when weeks and months go by and my PRs receive no activity, they serve no purpose except as persistent reminders that my time and energy has been spent fruitlessly.
So, while I appreciate your perspective, there's really no benefit for me not to close inactive PRs.

GLFW isn't a replacement for SDL2 and has never tried to be. I also can't in my spare time keep up with a project that has paid full-time developers and the backing of Valve and Epic. SDL2 is an excellent choice and I'm certainly not going to argue against it.
Thank you for your PRs; I'll get to them as soon as I can. Some of them are significant API additions and so require uninterrupted time for review in a way that I haven't had lately.

I love GLFW and its clean interface, and I would gladly use it exclusively if it did what I needed.  For instance, I can easily live without the PRs I submitted for joystick button and axis events and for hat switch support, but I need the fullscreen functionality on macOS that I submitted with this PR.  So, please don't misunderstand my comments comparing SDL and GLFW.  Again, I prefer GLFW but I use SDL because I have to.
You've done a great job shepherding GLFW and I understand how important that role is for the quality of GLFW.  Of course your time is limited for such a demanding task.  And, of course, there's no way that one person could compete against the resources that SDL has.  However, I don't think that you're taking full advantage of the power of the open source community.
There are people who are willing to help you.  That's the fundamental idea behind open source, namely that we can do more together than we can individually.  It's important for code quality to maintain strict control, but it also can be tremendously beneficial to use the resources that are available to you with the open source community.  For instance, you might consider taking on one or more partners to help you maintain GLFW.  Another idea might be to host one or more experimental branches that contain PRs with only preliminary approval and use feedback from the community to evaluate their effectiveness and quality.  I believe that the code that I submitted with this PR is correct, but it hasn't been tested on any other Macs; also, as you say, the code that I submitted with the other PRs made significant API changes.  If PRs like these were included into one or more experimental branches, you might be able to use the feedback regarding them to make evaluations -- rather than having to laboriously evaluate everything by yourself -- before incorporating them into releases or into the main branch.
These are just a couple of ideas off the top of my head.  And, of course, I am not yet an expert with GitHub, so they may not be as feasible as I think.  Nevertheless, I firmly believe in the value of the open source community and the idea that we can do more when we work together.  So, I would encourage you to try take more advantage of the help that is available to you.

I've thought of another way that would make it easier to let people submit code, namely by bracketing their code changes with #ifdef / #endif directives.  For example, I could have easily bracketed the changes with this PR using #ifdef GLFW_COMMAND_TABBING_FIX so that the new code would be enabled only if GLFW_COMMAND_TABBING_FIX is defined in the main header file.  The code that I included with this PR was purely additional, so for changes that modify existing code you could have them keep the original code after an #else.  In the main header file, the #define statements for the macros could be commented out (with additional comments referring to the original PR) by default so that they are enabled only if people wish to use or test the new functionality leaving the original release functionality intact.
Using this type of approach, it should generally be relatively easy to confirm that changes are properly bracketed by #ifdef / #else / #endif directives when reviewing changed files on GitHub.  And when the time comes to integrate, modify, or remove the changed code, it should also be easy to accomplish with a global search.
Using this type of approach would make it easy to let people help and reduce your burden since your review would consist of a general understanding of the changes -- rather than having to make such a time-intensive review like you described above -- with a specific focus on confirming that new code is correctly bracketed by directives before you approve it.  You could clearly define the standards you want in documentation, and refuse to accept PRs until they meet those standards.  Then, like I mentioned in my previous comment, you can use feedback from people who do enable such changes to evaluate their merit and effectiveness.
I think this idea is better than the two ideas I mentioned previously since it should be very easy to accomplish this simply by (1) adding preliminary documentation regarding coding standards and how to properly bracket code changes and (2) taking advantage of the simplicity of GitHub's changed file viewer.

(Slip of the Comment button, part two follows)
There's often no way for a contributor to predict when a PR will save time without asking, so if you haven't already written a working fix, that's what I recommend you do. Open an issue and describe the problem, like you would for a PR. Of course, if the code is already written for your own immediate needs, make a PR of it.
Even PRs that don't save time are invaluable measured in egoboo, because someone cared enough about the project to take the time to develop and submit it, and I try to give egoboo back by keeping the original commit (possibly squashed) and adding credits even if large portions need rewriting. Others provide new knowledge, insights or even coding style changes that then spread throughout the project long after the submitter moved on to other ones. There are many examples of this.
So in summary, suggestions and feedback on existing and future features is great, both before and after they're merged. Helping people with common problems here or on the forum is great. Writing, discussing, testing and reviewing PRs is great. There is no ordering here. I'd put them all in first place if I could.

Then there's the elephant-in-the-room of me being pretty useless at interacting with people and giving them the recognition they deserve, which I know has cost the project both previous and potential contributors. Again, sorry about that. I'm working on it and may one day hand over the reins for that reason.

@elmindreda, I want to apologize.  Clearly I have no idea what goes into maintaining a project like GLFW.  I thought about this only from my own perspective, namely that I tried to write the highest quality code that I could, and where I made API changes, that they matched existing GLFW standards, both for the code -- including coding style, function names and signatures, variables names, behavior, etc. -- and for the documentation comments.  My goal was to make my changes indistinguishable from original GLFW code and documentation.  So, without understanding the context of what actually goes into maintaining GLFW, I thought that what I had written would make a real contribution, and when it didn't go anywhere, I felt like I had wasted my time.
There is also the issue that I would really prefer to use GLFW rather than SDL, and when my PRs didn't go anywhere, particularly this one, it meant that I would have to maintain the additional code that I needed and manually re-integrate it every time I wanted to re-update to the master branch so that I could get the latest enhancements and bug fixes.
Another problem that I had was that every time I wanted to submit a new PR, I had to delete my existing repository and re-fork GLFW.  I just recently started to get a feel for branching (for a PR that I submitted to another project), but I am still not terribly proficient with GitHub.  So, if there is a way that I could have written new PRs against the master branch without having to re-fork -- or to merge GLFW's master branch back into a branch in my own fork so that I could keep up with changes that way -- I haven't yet found it.
I kept copies of all of the changed code on my hard drive.  So, if you can't merge these PRs into GLFW if and when you choose since I closed them (I can see that the commits and file changes are still here even though the original repositories have been deleted), please let me know and I will start over and resubmit them.
As for the experimental branches, I had no idea that you were already doing this.  The place that I would have looked for them is in the README on the front page (I know there are many branches under the branching tab, but I hadn't looked there because I thought they were just from other forks of GLFW rather than officially maintained branches, but I just took a look and found out that all 17 are yours).  Perhaps they would still get more traction if you had a section on actively developed branches in the README with the branch name and a brief description of its purpose along with a request for feedback.
Thank you for all the hard work that you do maintaining GLFW.  And, again, I apologize for my complete lack of understanding about how much work goes into it.

I want to apologize.

There's no need to apologize and it was unfair of me to rant at you.

I tried to write the highest quality code that I could, and where I made API changes, that they matched existing GLFW standards, both for the code -- including coding style, function names and signatures, variables names, behavior, etc. -- and for the documentation comments. My goal was to make my changes indistinguishable from original GLFW code and documentation.

From what I can tell looking through them now, you succeeded. My rant wasn't directed at your pending code, which I haven't yet reviewed. I've also already merged two of your PRs, earlier this year, and both of them have been included in releases without causing complaints, so that shouldn't worry you.

So, without understanding the context of what actually goes into maintaining GLFW, I thought that what I had written would make a real contribution, and when it didn't go anywhere, I felt like I had wasted my time.

That is my fault and I apologize, to you and everyone else I've kept waiting. As a consequence of this thread I'll try setting aside some time (hopefully) each week to give initial feedback on at least one outstanding PR. That still won't be an instant response, but it shouldn't be months either.

[...] when my PRs didn't go anywhere, particularly this one, it meant that I would have to maintain the additional code that I needed and manually re-integrate it every time I wanted to re-update to the master branch so that I could get the latest enhancements and bug fixes.
Another problem that I had was that every time I wanted to submit a new PR, I had to delete my existing repository and re-fork GLFW. I just recently started to get a feel for branching (for a PR that I submitted to another project), but I am still not terribly proficient with GitHub. So, if there is a way that I could have written new PRs against the master branch without having to re-fork -- or to merge GLFW's master branch back into a branch in my own fork so that I could keep up with changes that way -- I haven't yet found it.

I don't know exactly what you know, so I'll probably explain things you know and leave out details you don't, but here goes...
One shouldn't ever have to re-fork. After you've forked this repo (or if you have a fork again, just keep it, it's fine and almost infinitely fixable), put all the changes for a given PR in a separate, non-master branch. Then open a PR from that branch. You may already have been doing that bit; I can't tell as GitHub lost that information when you deleted your fork. If your branch contains many commits that are really parts of the same change, squash them to a single commit before making the PR. It'll make it easier for everyone to work with.
Any changes you make to that branch (and only that branch) from then on will automatically update the PR, but if you don't need to update it for your own needs you can just leave it alone until I get to merging it. Once a PR has been reviewed and accepted, I'll start maintaining and periodically rebasing an experimental branch while it's being prepared for merging (current examples include preedit-ime and egldevice), but I won't do that for not-yet-accepted ones.
As for getting new changes, add a remote for this repo (let's call it upstream for now) to the local copy of your fork and fetch from it when you want new stuff. Then either rebase, merge or reset-and-merge your master branch (origin/master), which I'm guessing you want to contain the merged changes from one or more of your PRs, using the remote master (upstream/master). There are many possible models here.
If we switch places for a moment, I'd probably rebase each PR branch onto upstream/master, reset origin/master to upstream/master merge each refreshed PR branch into origin/master and then use that for my daily work until the PRs are merged. If the PR changes are isolated and uncomplicated like this one, I could probably skip the rebasing. That's just an example off the top of my head and there are probably better ways. It's been a while since I had to maintain simultaneous PRs for a single project.
The GitHub help has plenty of hands-on sections on every part of this and there are tons of tutorials out there that cater to different learning preferences.

I kept copies of all of the changed code on my hard drive. So, if you can't merge these PRs into GLFW if and when you choose since I closed them (I can see that the commits and file changes are still here even though the original repositories have been deleted), please let me know and I will start over and resubmit them.

You don't even need to do that. I have a line in my local .git/config that fetches and caches all PRs as remote branches. This used to be easier to find in the GitHub help, but for anyone curious, the line is:
fetch = +refs/pull/*/head:refs/remotes/origin/pr/*

This lets me work with any existing PR even when offline, or in cases like this when the source disappears.

As for the experimental branches, I had no idea that you were already doing this. The place that I would have looked for them is in the README on the front page (I know there are many branches under the branching tab, but I hadn't looked there because I thought they were just from other forks of GLFW rather than officially maintained branches

Branches created in forks won't ever appear in the branch list of this repo, even though you get all of the branches of this repo when you fork. Even when you make PRs of your own branches, they can only target branches that I or another maintainer has already created here.

Perhaps they would still get more traction if you had a section on actively developed branches in the README with the branch name and a brief description of its purpose along with a request for feedback.

That's useful feedback and definitely worth a try. Thank you. I don't think I want to maintain an actual list in the README (too much update noise and risk of stale information), but I'll mention their existence and describe some of the work flow around them. If anyone would like to maintain a branch list with descriptions in the wiki, let me know and I'll arrange write permission.

This used to be easier to find in the GitHub help

Just checking, but is this it?

I am still not terribly proficient with GitHub

@IntellectualKitty, if you haven't already read it, I extremely highly recommend this article about how git can be seen as a purely functional data structure; I think it helps a ton with becoming comfortable doing advanced git-fu (and using GitHub is a natural extension of that).

@shurcooL Yup, that's the page.

@elmindreda and @shurcooL Thanks for all of your help.  I only just recently started branching like @elmindreda suggested, well after the PRs I submitted to GLFW however.  I'm afraid that much of @elmindreda 's comments are still a bit over my head (although the article on git as a purely functional data structure helped).
The main problem I've been having is that I've been using the web interface exclusively, thinking that it did everything.  I always try to be careful to avoid downloading malicious software, and I thought that the "GitHub Desktop" that shows up when I hit the "Clone or download" button was a toolbar that would install in my browser.  However, when I started researching how to get new changes back into my PRs after I last wrote, I finally found out that git is a command-line tool that does immensely more than the web interface.
@elmindreda I'll probably have to go back over your comments a few more times, but now that I know that there is a command-line interface, I think I'll be able to get up to speed fairly quickly.

authors: IntellectualKitty Shimmen elmindreda shurcooL


text:
🛑 APP is down

In 25503bc, APP ($SITE_5) was down:

HTTP code: 0
Response time: 0 ms

Resolved: APP is back up in 5448cc2.

repo: glo-markoaular/status-navigate


text:
SDTM to FHIR transformation (conceptual)

Outcome: Table with SDTM resource and column names mapped to FHIR resources and attributes
In Nov 2023, the team decided to use FHIR as the data layer for ISARIC 3.0. Reasons why we chose it over SDTM/OMOP:

SDTM: This is the existing schema and is difficult to extend as SDTM terminology is controlled by CDISC
OMOP: Issues with dates (have to specify full date, which we do not have), uses their own terminology (mapped to SNOMED/ICD/...), but can be extended.

Full reasoning is in this document: TODO
As part of this process, we are mapping existing SDTM resources to FHIR terminology.

Rationale for selection of FHIR as the central data model;
ISARIC_ARCH_FHIR.docx

authors: abhidg sadiekelly

repo: globaldothealth/isaric


text:
Quita la relacion de Producto, Medida, Rubro, Transportista, Cliente y Proveedor con Empresa

#297
#302

@k31kur0n0

[ ] Los productos deben duplicarse, no merge

[ ] Desvincular transportista de sucursal

[ ] Desvincular Cliente (con su CC asociada) de sucursal

[ ] Desvincular Proveedor (con su CC asociada) de sucursal

[ ] En el alta de Pedido, cuando el envio es "Retira en Sucursal", el pedido debe vincularse con la sucursal de retiro seleccionada

@k31kur0n0 Setear en el script el cliente Consumidor Final del MINORISTA como predeterminado

@k31kur0n0

No verifica disponibilidad de stock cuando el producto no tiene cantidad en una sucursal
En la vista de faltantes no muestra la cantidad si no tiene disponibilidad en esa sucursal

@k31kur0n0

[ ] Aplicar regla de negocio: cantidad por bulto para activar bonificacion
[ ] Cambiar el concepto de producto destacado por "Oferta" con %
[ ] Eliminar el input de descuento en busqueda de productos

@k31kur0n0 No actualiza la cantidad de producto en el alta de factura compra cuando el producto no tiene cantidad en esa sucursal

@k31kur0n0

[ ] La cantidad de resultados de productos sin filtros no es correcta
[ ] En la vista de detalle producto debe cambiar el concepto de Destacado por Oferta y permtir ingresar el %
[ ] Al tildar un producto como sin limite, desabilitar el combobox de sucursal
[ ] Al eliminar todos los productos del minorista, podemos quitar tambien todas las medidas y rubros del minorista. Tambien vamos a eliminar proveedores del minorista
[ ] Crear script para backup de productos y proveedores del minorista antes de eliminar
[ ] Cambiar el orden de las columnas en el listado de productos para que quede: Cant. Disponible, Otras Sucursales, Cant. x Bulto, Sin Limite, Cant Minima
[ ] Cambiar el nombre de la column Cant. Disponible por "Stock". Tambien en buscar productos
[ ] Se deforma la vista de buscar productos cuando oculta el input de bonificacion
[ ] La columna de renglones en punto de venta debe decir "% Bonificacion" en vez de descuento
[ ] Error al tener renglones cargados en el punto de venta y cambiar de cliente y/o quitar producto
[ ] Al modificar la bonificacion de cliente en el modal de punto de venta, no recalcula los renglones
[ ] Error al agregar producto buscando por codigo

@k31kur0n0

[ ] Agregar calculo inverso para oferta
[ ] Cambiar la regla de negocio para que aplique el % de oferta SOLO si cumple con la cantidad por bulto (debe cubrir el caso del 2x1)

@k31kur0n0

[ ] Quitar el atributo y toda la logica de fecha vencimiento en PEDIDO

@k31kur0n0

[ ] Error en la ultima linea del script que quita fecha vencimiento

[ ] Agregar al texto del mail que se envia por alta de pedido: "Le enviaremos otro aviso cuando su pedido este facturado y listo para el tipo de envio seleccionado"
Al facturar el pedido, enviar un nuevo mail con el texto: "Su pedido Nº 1234567 fué facturado y esta listo para [retiro en la sucursal X] [para enviar al domicilio X]"

[ ] Error al intentar ingresar una ND

[ ] Agregar mensaje de aviso si intenta crear una Nota sobre un comprobante que NO se genero en la sucursal seleccionada

repo: globo-technology/sic-api


text:
Support Laravel 8

Add support for Laravel 8
Drop support for Laravel 5.8 and lower
Drop support for PHP 7.1 and lower

fix #67

repo: glorand/laravel-model-settings