text:
v2.0.0 RC

@kayladnls @localheinz @hannesvdvreken

:+1: glad it's ready for tagging a release candidate! Good work.

@codeguy be interested to get your opinions on this from the perspective of interoperability if you have any time?

@hannesvdvreken https://packagist.org/packages/league/route#2.0.0-RC1

@philipobenito c/p the example docs and /prefix/example isn't routing correctly. Getting League\Route\Http\Exception\NotFoundException

Could you check out your REQUEST_URI for me please?
On Mon, Oct 5, 2015 at 4:38 PM, Kayla Daniels notifications@github.com
wrote:

@philipobenito c/p the example docs and /prefix/example isn't routing correctly. Getting League\Route\Http\Exception\NotFoundException
Reply to this email directly or view it on GitHub:
https://github.com/thephpleague/route/pull/73#issuecomment-145574147

Zend\Diactoros\Uri Object
(
    [allowedSchemes:protected] => Array
        (
            [http] => 80
            [https] => 443
        )

    [scheme:Zend\Diactoros\Uri:private] =>
    [userInfo:Zend\Diactoros\Uri:private] =>
    [host:Zend\Diactoros\Uri:private] =>
    [port:Zend\Diactoros\Uri:private] =>
    [path:Zend\Diactoros\Uri:private] => /prefix/example
    [query:Zend\Diactoros\Uri:private] =>
    [fragment:Zend\Diactoros\Uri:private] =>
    [uriString:Zend\Diactoros\Uri:private] =>
)

nvm @philipobenito I think I got it working.

Ah cool, what was the issue?
On Mon, Oct 5, 2015 at 6:23 PM, Kayla Daniels notifications@github.com
wrote:

nvm @philipobenito I think I got it working.
Reply to this email directly or view it on GitHub:
https://github.com/thephpleague/route/pull/73#issuecomment-145604363

I was testing in on cli by setting the uri on the request object. Which fails because there's no schema or host.

I would strongly suggest rebasing this into a smaller number of commits and using The Rules for your commit messages.

I'm also strongly against the idea of ContainerAwareTrait and any code that calls new outside of factories. This library would be much better if it did not depend on league/container.

@shadowhand

ContainerAware* are for use within factories.
The whole package is essentially a factory where in a lot of cases objects have to be created.
How is the quality of the library diminished by the inclusion of something that the default strategies depend on? The point is that it is already more difficult than it was to use out of the box, I'm not gonna make it even more so.

If you start with the assumption that the strategies need the container, then you will not be able to see how to make it work without them. This is the same general problem that all containers have... "when your own tool is a hammer..."

@shadowhand those points are pretty moot, the router does not force you to do anything, however, it provides an interface to get people started. Remember, you cannot assume that everybody knows what you know. With this in mind, route provides a little convenience out of the box. Otherwise, it would be unusable without a much higher barrier to entry.
a) you do not have to use league/container, b) you do not have to use any container. I am not forcing you to use a container.

@philipobenito of course you are... composer.json says that league/container is required to use this package.

@shadowhand out of the box it is required for the intended use, however, it is extensible enough for you to not have to actually use it. I'll reiterate again, this is for convenience to users who may not be comfortable enough to build their own strategies etc.
As for users such as yourself who don't want the library to be opinionated in any way of how it builds class based controllers, my question would be, why are you using league/route instead of just using FastRoute?

Primary because league/route makes it easier to work with FastRoute. I wanted to use this package for spark but we ended up rolling a custom router because of the container dependency (and because it wasn't PSR-7 ready).

@shadowhand well that is the point, it makes it a little easier, if it didn't there would be no reason for this package to exist.

In which case, why not choose to minimize the dependencies and avoid the container dependency entirely?

@shadowhand because it also aims to encourage people to use dependency injection throughout their projects. That is the point of the strategies, and each strategy works out of the box. However, very very easy to build your own strategy that does not use a container. This is something I've said to you before, your use cases are not necessarily the same as other peoples, the intended use of the default set up of this package is with the container. However, I understand some people do not want to use one, therefore, it is very easy not to.

If the container is not required than it should be a suggests dependency instead of requires.

It is required... out of the box... but... you don't have to use it if you don't want to, it really is that simple! It provides a tool that is required for the package to work as is. However, and I don't know how many times I can reiterate this, if you are of the opinion you don't want to use it, then don't. Would you really say that removing the container because you don't want to use it would be a better option for the package than leaving it in for the much larger user base who do want to use it?

Libraries that do not require a container are better for everyone. I guess you don't see it that way.

@shadowhand I both agree and disagree. This library, by default, is opinionated on how objects are built (again, it allows you not to adhere to this opinion), therefore, a container is a good idea, however, that is not the issue here, the issue is barrier to entry. By excluding it, I am alienating anybody who is not comfortable setting that stuff up for themselves.

So just to end the above conversation as it is in no way productive.
Including the container by default is a conscious decision to allow the built in strategies to be used out of the box. This is a trade-off between doing some of the work for the user and doing none of the work for the user. It is an option for people who do not want to use a full stack framework but do not want to do all the heavy lifting themselves. It sits somewhere in the middle of Laravel or similar and FastRoute or similar without being considered a micro framework such as Slim or Silex.
By removing the container, along with that I have to remove the current strategies that are included or change them to just invoke a callable. At that point, there is no need for this package to exist as that is what FastRoute does. It is a trivial extension of a non-trivial package to lower the barrier of entry and promote package driven development and a couple of design patterns/methods that will make your life a little easier while allowing you to write good code.
All this being said, as opinionated as the package is out of the box, it is extensible enough for you to ignore the defaults completely and do as little or as much as you like, if you want it to have no opinions at all, my advice would be to build something similar that works for you on top of FastRoute or similar.
A specific example of this would be @codeguy considering league/route for the new version of Slim. It has functionality that is not needed by Slim, therefore, a decision was made to replace it with FastRoute directly. This would be my advice to anybody who is so strongly opinionated about how the dispatch of a controller should be handled. Otherwise, build a strategy, ignore the container completely, and it will not be used.

To be honest I would rather see container-interop as a dependency rather
than league/container, because container-interop provides interfaces in a
PSR-like style, and thus leaving implementation to be chosen. While
league/container isn't a very heavy DI container library, it does
"contaminate" the dependency graph with an implementation that the
developer might not want to use.
I believe that a library, especially one like this, should only depend on
bare necessities.
On Oct 12, 2015 5:16 PM, "Phil Bennett" notifications@github.com wrote:

So just to end the above conversation as it is in no way productive.
Including the container by default is a conscious decision to allow the
built in strategies to be used out of the box. This is a trade-off between
doing some of the work for the user and doing none of the work for the
user. It is an option for people who do not want to use a full stack
framework but do not want to do all the heavy lifting themselves. It sits
somewhere in the middle of Laravel or similar and FastRoute or similar
without being considered a micro framework such as Slim or Silex.
By removing the container, along with that I have to remove the current
strategies that are included or change them to just invoke a callable. At
that point, there is no need for this package to exist as that is what
FastRoute does. It is a trivial extension of a non-trivial package to lower
the barrier of entry and promote package driven development and a couple of
design patterns/methods that will make your life a little easier while
allowing you to write good code.
All this being said, as opinionated as the package is out of the box, it
is extensible enough for you to ignore the defaults completely and do as
little or as much as you like, if you want it to have no opinions at all,
my advice would be to build something similar that works for you on top of
FastRoute or similar.
A specific example of this would be @codeguy https://github.com/codeguy
considering league/route for the new version of Slim. It has functionality
that is not needed by Slim, therefore, a decision was made to replace it
with FastRoute directly. This would be my advice to anybody who is so
strongly opinionated about how the dispatch of a controller should be
handled. Otherwise, build a strategy, ignore the container completely, and
it will not be used.
—
Reply to this email directly or view it on GitHub
https://github.com/thephpleague/route/pull/73#issuecomment-147430836.

It's probably not very useful to add yet another voice to this discussion :stuck_out_tongue:

To be honest I would rather see container-interop as a dependency rather than league/container

Yes and no. I agree, except for one thing: There is a call method on league/container's implementation that is used to auto inject stuff. By using that, it needs league/container as a hard dependency.
There is a possibility though to split off strategies into separate packages so that the basic strategies are included but the ones with auto injection (which requires the league/container) and others can be separate packages. Like tactician-container.

@hannesvdvreken I actually toyed with this idea but ended up deciding against it, mainly because of the reasons above whereas if that was to happen I'm not sure of the use for this package as it stands. Those strategies as an extra package could just as easily be written as an extension to FastRoute, which is then a mirror of what league/route is. It's a never ending circle so I decided on the make it easier by default without going overboard with the option to change anything you want to.

@thebigb although league/container is included, the code itself is only dependent on container-interop interfaces so that they can be swapped out, the argument here is whether league/container should be included for use by default. The reason that it is, and the reason that it will stay this way is to make the package easier to use for anybody who just wants to install and go.

Docs....

authors: cringer hannesvdvreken kayladnls philipobenito shadowhand thebigb


text:
Update linter.py to fix #33

As ian4hu pointed out in #33, Linter.which() called from within the HtmlTidy class definition resulted in an early invocation situation in which a fail test resulted for Linter's settings, paths in particular, prior to any setting being cached.
Changes to fix this.

Moved to SublimeLinter-html-tidy.

source: gharchive/pull-request

repo: therealmarv/SublimeLinter-html-tidy

license: MIT

license_type: permissive

license_source: github-api


text:
Formatting newlines (eg in large SQL queries)

First off, thank you! I was so happy to see this and that it was so easy. Also, I see that part of your motivation is being a fan of error wrapping and stacktraces, which is part of why I'm currently switching out the logging code in my project.
So I wonder if there's a way to make the newlines in my pgx display? This is an example fragment:
3:02PM INF > Exec commandTag=DO pid=2930363 sql=DO $$\n BEGIN\n CREATE TABLE IF NOT EXISTS http_sessions (\n ...
Is it something that this package can do? Or is it something I need to change in pgx or zap itself? Thanks for any tips ✨

This is an interesting feature request. Thank you. I am a little limited by needing to work through the zap type interfaces (e.g., their zap.String() method doesn't accept arguments) but I may be able to get something working through zap.Interface(prettyconsole.StringBlock(yourString)) or similar.
Heads up, I've just started a new job and I don't have a huge amount of spare time at the moment, but soon I will be using this library for work again, and I'll definitely have the mental capacity to hone this on my weekends.

Perhaps the prettylogger could take configuration of a list of "safe" keys and run addIndentedString on those keys instead, which would make the strings output similarly to the error outputs.

Added in 0922045, and released in v0.4.0. Check out Readme for usage and a visual of how it looks.

this is great for other fields, but how can I get it to apply to the message field. This is the only field where \n etc don't get formatted correctly

BTW, @thessem thanks for doing that, it looks great! I'm not working in that codebase anymore so haven't been able to check it out myself yet, but hopefully will have another chance soon.

source: gharchive/issue

authors: danielriddellsh thessem tombh

repo: thessem/zap-prettyconsole


text:
Metadata API: Rewrite comments

Try to keep dostrings and comments to the point, avoid mentioning
details if they are not necessary or are likely to become outdated
and try to minimize number of comment lines.
Signed-off-by: Jussi Kukkonen jkukkonen@vmware.com

Last push: Modified Role docstring based on review

squashed joshuas suggestions (thanks!), then added another commit to improve the DelegatedRole docstring: It explains all of the options that exist in broad terms and expects reader to lookup the details (like what exactly is a "target path hash") elsewhere, and tries to make it clearer that the attributes are mutually exclusive.

repo: theupdateframework/tuf


text:
add event sequence options to hotspot connector so can trigger audio then jump to page

Question on forums and my example with custom code https://xerte.org.uk/index.php/en/forum/developers/3279-creating-a-hotspot-to-play-sound-and-then-move-to-another-page
If you add both a sound and a destination page option the current code only plays the sound. The OP wanted a sound to play e.g. key and door opening and then jump to the destination e.g. for escape room.
At the moment if you add a Text option for the hotspot as well as a destination page then again only one of them works e.g. the text window displays but the page doesn't navigate to the destination when you close that window. I could foresee a scenario where you might want the sound to play, then the pop-up and then when the pop-up is closed navigate to the destination e.g. an option to sequence the resulting actions.

At the moment you can add many optional properties to a hotspot but only one of these will be used. In priority order, these are: video, audio, image, text, iframe, new window, external destination page and finally destination (internal page).
I think for most of those, if you wanted to have some content shown and then move to a destination page afterwards the best thing to do would be to use the text option, add the content there (even if video etc. as you could add embed code) and then add a link at bottom of text that took you to destination page. Not sure from user experience point of view it would be great to move page when you click close button as that seems counterintuitive. The only one that couldn't be set up like that would be sound - so auto playing sound when hotspot clicked and then moving to destination page/showing extra content after audio finished. Adding new functionality to page to allow this for audio wouldn't be too hard.

repo: thexerteproject/xerteonlinetoolkits


text:
Fix: Flush the file buffer after writing to the file

Proposed changes
This may(!!!) solve #1241.
Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue
#1241
Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[x] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

This may(!!!) solve https://github.com/thin-edge/thin-edge.io/issues/1241.

Indeed!

I don't know of any way that you could reliably check for it in this instance. However, flushing is always correct in this case, so whether it fixes the tests or not, it should get included imo.

authors: TheNeikos didier-wenzek matthiasbeyer


text:
[Ecosystem Wallets] Adds the ability to connect to an ecosystem wallet with an integrator ID

import { inAppWallet } from "thirdweb/wallets";
const wallet = inAppWallet({
  integratorId: "...",
});

PR-Codex overview
This PR adds integrator ID support for connecting to ecosystem wallets in the thirdweb package.
Detailed summary

Added integratorId parameter to inAppWallet function
Updated types to include integratorId
Modified wallet creation options to include integratorId
Updated authentication and wallet connectors to support integratorId
Added integratorId to various functions and classes in the wallet module

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Codecov Report
Attention: Patch coverage is 47.82609% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 62.45%. Comparing base (5031e44) to head (cc2fb35).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           ecosystem-wallets    #3141      +/-   ##
=====================================================
- Coverage              62.45%   62.45%   -0.01%
=====================================================
  Files                    807      807
  Lines                  60490    60509      +19
  Branches                3238     3238
=====================================================
+ Hits                   37778    37789      +11
- Misses                 22042    22050       +8
  Partials                 670      670

Flag
Coverage Δ

*Carryforward flag

legacy_packages
65.61% <ø> (ø)

Carriedforward from 5031e44

packages
61.75% <47.82%> (-0.01%)
:arrow_down:

*This pull request uses carry forward flags. Click here to find out more.

Files
Coverage Δ

packages/thirdweb/src/wallets/create-wallet.ts
53.54% <100.00%> (+0.66%)
:arrow_up:

...web/src/wallets/in-app/core/authentication/type.ts
100.00% <100.00%> (ø)

...s/thirdweb/src/wallets/in-app/core/wallet/index.ts
29.52% <0.00%> (-0.87%)
:arrow_down:

...eb/src/wallets/in-app/core/authentication/index.ts
59.23% <12.50%> (-1.44%)
:arrow_down:

/release-pr

/release-pr

/release-pr

authors: codecov-commenter gregfromstl

repo: thirdweb-dev/js


text:
fix(react): update social button styling and behavior logic

Problem solved
Short description of the bug fixed or feature added
Changes made

[ ] Public API changes: list the public API changes made if any
[ ] Internal API changes: explain the internal logic changes

How to test

[ ] Automated tests: link to unit test file
[ ] Manual tests: step by step instructions on how to test

Contributor NFT
Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.
Address:

PR-Codex overview
The focus of this PR is to enhance the social login options in the web wallet interface by adjusting the layout and icon sizes based on the number of social logins available.
Detailed summary

Added "facebook" as a social login option
Adjusted layout based on the number of social logins
Dynamically changed icon sizes
Modified the display and gap styles
Updated the social login button labels based on the number of login methods

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#3867  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gregfromstl and the rest of your teammates on  Graphite


text:
Sidebars cleanup

Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
This PR focuses on restructuring sidebar layouts across different components and pages in the dashboard.
Detailed summary

Removed unnecessary components and files related to sidebar layouts.
Updated sidebar layouts in various components and pages for consistency.
Introduced a new SidebarLayout component for improved organization of sidebar links and content.

The following files were skipped due to too many changes: apps/dashboard/src/app/(dashboard)/dashboard/connect/DashboardConnectLayout.tsx, apps/dashboard/src/pages/dashboard/settings/notifications.tsx, apps/dashboard/src/app/(dashboard)/dashboard/connect/ecosystem/create/EcosystemCreatePage.tsx, apps/dashboard/src/pages/dashboard/settings/api-keys/[id].tsx, apps/dashboard/src/pages/dashboard/settings/api-keys/index.tsx, apps/dashboard/src/pages/dashboard/contracts/publish.tsx, apps/dashboard/src/pages/dashboard/settings/devices.tsx, apps/dashboard/src/pages/publish/[...paths].tsx, apps/dashboard/src/pages/dashboard/contracts/deploy.tsx, apps/dashboard/src/@/components/blocks/SidebarLayout.stories.tsx, apps/dashboard/.storybook/preview.tsx, apps/dashboard/src/pages/dashboard/connect/analytics.tsx, apps/dashboard/src/app/(dashboard)/dashboard/connect/layout.tsx, apps/dashboard/src/pages/dashboard/connect/in-app-wallets.tsx, apps/dashboard/src/pages/dashboard/settings/storage.tsx, apps/dashboard/src/app/(dashboard)/trending/page.tsx, apps/dashboard/src/pages/dashboard/connect/account-abstraction.tsx, apps/dashboard/src/app/account/layout.tsx, apps/dashboard/src/@/components/blocks/MobileSidebar.tsx, apps/dashboard/src/@/components/blocks/Sidebar.tsx, apps/dashboard/src/core-ui/sidebar/contracts.tsx, apps/dashboard/src/pages/explore/index.tsx, apps/dashboard/src/core-ui/sidebar/settings.tsx, apps/dashboard/src/components/pages/publish.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#4534  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on  Graphite


text:
Future-proof the hero banner image for all sites

Description
Simplify the hero banner background image loading.
Context
Much of the other framework sites we build use the same base code. Ideally, we want to spin up new frameworks with minimal coding. Image rendering shouldn't need additional coding.
With the change, whenever new frameworks are added with images following the same naming convention as existing ones, we won't have to touch any code.
Requirements
This enhancement makes the hero banner image load based on the framework chosen by either:

simplifying this code from

export function getBackgroundImage(siteName: string) {
	switch (siteName) {
		case "react":
			return "/hero-background-react.png"
		case "angular":
			return "/hero-background-angular.png"
		case "vue":
			return "/hero-background-vue.png"
		default:
			return ""
	}
}

to
export const getBackgroundImage = (siteName: string) => `/hero-background-${siteName}.png`;

or by deleting the hero-images.ts file altogether and including the template string directly into the component:

// hero.tsx
<img
	src={`/hero-background-${siteName}.png`}
	alt=""
	className={heroBackgroundStyle}
/>

#388


text:
How to use this library?

Hello, sorry for posting issue. I don't understand how to use this kit. I have put <link> stylesheet in ui.html file, then I tried to make a full html page in ui.html and put these tags in <head /> then I tried to copy css from node_modules directly to ui.html and reference it as href="./css/figma-plugin-ds.css" but Figma seems to ignore any links and iframe is displayed as base64

This is the popup that appears with plugin

<link rel="stylesheet" href="https://unpkg.com/figma-plugin-ds@1.0.1/dist/figma-plugin-ds.css"> is working

nvm I started using webpack which inlines css into ui.html

repo: thomas-lowry/figma-plugin-ds


text:
fix: pass correct options to tsc

Fixes https://github.com/thomaschaaf/esbuild-plugin-tsc/issues/6

Is there anything preventing this from being merged. It's been open for over a month.

authors: ArsenyYankovsky BrutalSimplicity

repo: thomaschaaf/esbuild-plugin-tsc


text:
🛑 Portainer-NBG is down

In 3cd821b, Portainer-NBG ($URL_PORTAINER_DE) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Portainer-NBG is back up in f0551e0 after 8 minutes.

repo: thomasmerz/upptime


text:
Latest versions don't work with multiple ThrowsExactly in Assert.Multiple

To reproduce:
  [Test]
  public async Task TestException ()
  {
    using (Assert.Multiple ())
    {
      await Assert.That (
        static () => throw new InvalidOperationException ()
      ).ThrowsExactly <InvalidOperationException> ();
      await Assert.That (
        static () => throw new InvalidOperationException ()
      ).ThrowsExactly <InvalidOperationException> ();
    }
  }

In TUnit 0.4.49, the test is successful.
In later versions, the following error is thrown:

One or more errors occurred. ((This exception may or may not have been caught) System.InvalidOperationException: Hello World) ((This exception may or ...

One or more errors occurred. ((This exception may or may not have been caught) System.InvalidOperationException: Hello World) >((This exception may or may not have been caught) System.InvalidOperationException: Hello World)
at TUnit.Assertions.AssertionScope.Dispose()
at TestException() in xxx
at TestException()
at TUnit.Core.AsyncConvert.Convert(Func1 action)    at TUnit.Core.DiscoveredTest1.ExecuteTest(CancellationToken cancellationToken)
at TUnit.Engine.Helpers.Timings.Record(String name, TestContext context, Func1 action)    at TUnit.Engine.Services.TestInvoker.Invoke(DiscoveredTest discoveredTest, CancellationToken cancellationToken, List1 cleanupExceptions)
at TUnit.Engine.Services.TestInvoker.Invoke(DiscoveredTest discoveredTest, CancellationToken cancellationToken, List1 cleanupExceptions)    at TUnit.Engine.Services.SingleTestExecutor.ExecuteTestMethodWithTimeout(DiscoveredTest discoveredTest, CancellationToken cancellationToken, List1 cleanupExceptions)
at TUnit.Engine.Services.SingleTestExecutor.ExecuteWithCancellationTokens(DiscoveredTest discoveredTest, List1 cleanupExceptions)    at TUnit.Engine.Services.SingleTestExecutor.ExecuteWithRetries(DiscoveredTest discoveredTest, List1 cleanupExceptions)
at TUnit.Engine.Services.SingleTestExecutor.ExecuteWithRetries(DiscoveredTest discoveredTest, List`1 cleanupExceptions)
at TUnit.Engine.Services.SingleTestExecutor.ExecuteTestInternalAsync(DiscoveredTest test, ITestExecutionFilter filter, ExecuteRequestContext context, Boolean isStartedAsDependencyForAnotherTest)
at TUnit.Engine.Services.SingleTestExecutor.ExecuteTestInternalAsync(DiscoveredTest test, ITestExecutionFilter filter, ExecuteRequestContext context, Boolean isStartedAsDependencyForAnotherTest)
at TUnit.Engine.Services.SingleTestExecutor.ExecuteTestInternalAsync(DiscoveredTest test, ITestExecutionFilter filter, ExecuteRequestContext context, Boolean isStartedAsDependencyForAnotherTest)
at TUnit.Engine.Services.TestsExecutor.ProcessTest(DiscoveredTest test, ITestExecutionFilter filter, ExecuteRequestContext context, CancellationToken cancellationToken)

Thanks for the report! Should be fixed in v0.4.71

@thomhurst Thank you Tom, it's working now.

repo: thomhurst/TUnit


text:
BTC Pool deposit, shows no shares after.

Bitcoin / RUNE Pool deposit issue
Issue description
This morning the cap was raised and I attempted to deposit some bitcoin & RUNE into the pool.  Not my full balance, just 0.00294477 BTC.
The transaction indicated a failure regarding fees.   I didn't capture a screen shot, I figured to just adjust my deposit amount so I closed the window.  But the wallet then shows 0.00094452.  At the time no history showed and I figured with so many trying to deposit I'd wait till after the cap closed.  Now history shows a deposit, but the wallet does not show I have shares in the pool.  I did check the web version and it also shows I have no shares.
This shows the history screen shot

This shows the wallet balances

This shows the transaction

I realized I cropped the memo field:  Memo(s)
ADD:BTC.BTC:thor1ktzsxh6a8jey0rtzsmj23a9rx7ujtklsqn9xrh
'copy hash' function from transaction page:
A259A698475706E07DFEC77E2A2648ECDA72BB1F4CD3BD6F565F68792BBDCD49
Your Environment

ASGARDEX desktop version:
0.3.3
Operating system and version:
Windows 10
Transaction hash(es):
A259A698475706E07DFEC77E2A2648ECDA72BB1F4CD3BD6F565F68792BBDCD49
Wallet address(es):
BTC: bc1qk22cc653tl0wuxk9cfm6tj0w0dpe4zd5a02dqm
THOR:  thor1ktzsxh6a8jey0rtzsmj23a9rx7ujtklsqn9xrh

By looking into https://thornode.thorchain.info/thorchain/pool/BTC.BTC/liquidity_providers you still have pending assets
	{
		"asset": "BTC.BTC",
		"rune_address": "thor1ktzsxh6a8jey0rtzsmj23a9rx7ujtklsqn9xrh",
		"asset_address": "bc1qk22cc653tl0wuxk9cfm6tj0w0dpe4zd5a02dqm",
		"last_add_height": 1010683,
		"units": "0",
		"pending_rune": "0",
		"pending_asset": "294477",
		"pending_tx_Id": "A259A698475706E07DFEC77E2A2648ECDA72BB1F4CD3BD6F565F68792BBDCD49",
		"rune_deposit_value": "0",
		"asset_deposit_value": "0"
	},

It seems your deposit was not successful due a failing tx on RUNE side. To recover your pending assets, pls follow steps as described in a previous message: https://github.com/thorchain/asgardex-electron/issues/1520#issuecomment-857489215

The transaction indicated a failure regarding fees. I didn't capture a screen shot,
Maybe it shows the error (failing RUNE tx) mentioned above...?

Guess I just needed to wait longer.   I had checked before I submitted this ticket via the web exchange page and it was showing no deposits and no pending.
I checked again just now and it shows the bitcoin and I did get a successful withdraw response.
OK to close this one.
Thank you

authors: Zunthras veado

repo: thorchain/asgardex-electron


text:
[Settings] Tweak Wallet Settings UI

[x] Re-organize order ACCOUNT MANAGEMENT + WALLET MANAGEMENT
[x] Remove borders
[x] Resize containers of 1. + 2. to 100% width
[x] Align containers to be vertical align with titles
[x] Add more padding between accounts

Closes #1680


text:
Status of the project

Hello! 👋 Thanks for publishing your package.  Last commit was more than one year ago and there are few open issues without answer. And I'm just curious about the status of the project. Is it stable enough that there are no changes needed, or is it abandoned? Does someone use it on production?

Wow, this has been open for a while.
We use it internally in production for multiple projects and the library can be considered stable.
However we have just released a fix related to ECC signatures (so the asic container sets the correct signature algorithm for ECC certificates). This is probably something you want in your project if you are using pyasice for Estonian IDs.

repo: thorgate/pyasice

license: ISC


text:
tvg: support stroke miterlimit property.

implement the miterlimit property that was introduced by 44a750ee5db79008388ae18c853e54365130cdba
Issue: https://github.com/thorvg/thorvg/issues/1490

LGTM
./svg2tvg  miterlimit_test.svg
[L] TVG_SAVER (../thorvg-git/src/savers/tvg/tvgTvgSaver.cpp 157): miterlimit_test.tvg,
compressed: 1120 -> 447, saved rate: 60.09%
Generated TVG file : miterlimit_test.tvg

authors: capnm hermet

repo: thorvg/thorvg


text:
Add Missing Swingame Functionalities Documentation

Description
Documentation on the functionalities Splashkit is missing from Swingame, an old game engine made by Swinburne University that Splashkit is built off of. This document aims to gather the collection missing functions, primarily focusing on collision logic and a splash screen procedure, to be implemented with a Splashkit animation.
Type of change

[x] Documentation (new)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have commented my code in hard-to-understand areas
[x] I have made corresponding changes to the documentation

The documentation does an excellent job of pointing out and documenting the features that Swingame missing but that Splashkit might provide, with a special emphasis on collision logic. It is easy to understand and has a clear, well-organized structure with separate sections. One of the good things is that the thorough explanations of missing functions include important details that will help with future development.

repo: thoth-tech/documentation


text:
Updates to use scope and to use to: in routing generator template

Currently the routings generated with rails generate clearance:routes has a few outdated and redundant syntaxes. This PR updates two following things.

Abandons clearance/xxx syntax and use scope module: :clearance do ... end
Removes old hash-rockets and use to: xxx syntax.

Users frequently update these to point to their overridden controllers. This would require them to either:

Move the customized route out of the module block, thus separating it from where it might make more sense when read.
Re-use the existing controller name by re-opening the clearance controller class and leaving the routes unchanged.

I think I'd prefer the redundancy in the routes. What do you think?

I'm going to close this based on an inclination to prefer "let's keep this easier to modify for users after it's been installed" observation from the last comment.

authors: IzumiSy derekprior mjankowski

repo: thoughtbot/clearance

license: mit

license_source: bigquery


text:
Attributes with similar name root don't use default values

edit: Sorry, I think this belongs in factory_girl_rails: https://github.com/thoughtbot/factory_girl_rails/issues/173
I have a model, Scheduler, with two fields with similar names, schedule(a hash with datetime information) and schedule_id (a random alphanumeric ID).  If I try to explicitly set schedule when calling FactoryGirl.create(:scheduler), schedule_id gets set to nil.  There is some issue with both of these attributes in my factory having the same root name, schedule.  I verified this by refactoring schedule_id to be scheid in my entire codebase, which caused the factory to generate Scheduler objects correctly.
Here is a slightly simplified but complete example of the use case:
# Runner Factory
FactoryGirl.define do
  factory :runner, class: Runner do
    _id { Moped::BSON::ObjectId.new }
    run_id { IDHelper::generate_id }
    run  { {"on_datetime" => "2015-03-24T10:55:00Z"} }
    created_at { Time.now }
    updated_at { Time.now }
  end
end

Standard use case:
run1 = FactoryGirl.create(:runner)
puts "run1 is #{run1.inspect}"

result:
run1 is #<Runner _id: 55e88028f53aab3a50000012, _type: nil, created_at: 2015-09-03 17:15:20 UTC, updated_at: 2015-09-03 17:15:20 UTC, run_id: "2874e9f4ae394dadaa89dc7790a5de32", run: {"on_datetime"=>"2015-03-24T10:55:00Z"}>

In some cases, I need to override the on_datetime attribute:
on_datetime_tomorrow = {"on_datetime"=>(Time.now.utc + 1).iso8601()}
run1 = FactoryGirl.create(:runner, run: on_datetime_tomorrow)
puts "run1 is #{run1.inspect}"

This properly updates on_datetime, but it causes the run_id evaluate to nil:
run1 is #<Runner _id: 55e880a0f53aab49b0000012, _type: nil, created_at: 2015-09-03 17:17:20 UTC, updated_at: 2015-09-03 17:17:20 UTC, run_id: nil, run: {"on_datetime"=>"2015-09-03T17:17:21Z"}>

This is a duplicate of the Factory Girl issue, #734


text:
Install Qt 5 instead of Qt 4

We install Qt because it is a dependency of Capybara Webkit.

Qt 4 is several years old and contains a version of WebKit with many
serious defects. Support for Qt 4 will be dropped in any future
feature releases and is not supported by the capybara-webkit team.

https://github.com/thoughtbot/capybara-webkit/wiki/Installing-Qt-and-compiling-capybara-webkit

@jferris What are your opinions on this?
Another thought I've had is maybe Qt should be removed from Laptop, relying on project-specific dependency declaration of Qt for Capybara Webkit.
For example, we sometimes have this line in our bin/setup script:
# Install Homebrew dependencies
if [ -x "$(command -v brew)" ]; then
  brew bundle
fi

And the project also contains a Brewfile like:
tap "homebrew/versions"

brew "heroku-toolbelt"
brew "postgresql", restart_service: :changed
brew "qt55"

@jferris Any opinions on this?

I think the idea is to install common dependencies, right? I think everybody on the team will eventually need Qt right now, because it's used on common tools like the blog or web site, and basically every Rails application.
If we decide to move towards project brewfiles, it seems like most of laptop's dependencies would be removed, except for editing tools like Git and Vim, right?
Unfortunately, I don't think there's currently a way to install a working Qt version on Sierra using Homebrew.

I made some changes here based on latest Homebrew QT changes and current Capybara Webkit wiki. I've tested it on my machine and it seems to be working nicely.
Could I get another review?

authors: croaky jferris

repo: thoughtbot/laptop


text:
Target multiple breakpoints

Hey, hope this isn't a dumb question. I'd really love to be able to do:
$mobile: new-breakpoint(...)
$custom: new-breakpoint(..)
@include media($mobile,$custom) {
//some styles
}
Is there a way to achieve this currently? I looked at the docs but it doesn't appear to be possible. Thanks so much for your time. Bourbon Neat is the best thing since sliced bread! xoxo.

what about @samueljseay request, any updates?

+1 I'm in the same boat, the current neat library doesn't seem to address this in a way that also supports new-breakpoint. I'll have to keep 12 columns across breakpoints and define the column span in individual locations instead.

+1 here

+1, that should REALLY be implemented!

We'll be accepting PR's if anyone wants to implement this.

https://github.com/postcss/postcss
On Wed, Jun 3, 2015 at 11:47 AM, Reda Lemeden notifications@github.com
wrote:

We'll be accepting PR's if anyone wants to implement this.
—
Reply to this email directly or view it on GitHub
https://github.com/thoughtbot/neat/issues/132#issuecomment-108250689.

@cmnstmntmn Not sure that's helpful.

Hey guys, still need to add column support and all the rest but would something like this be headed in the right direction?
http://sassmeister.com/gist/663615b7ddbd80965d84

+1

+1

Some great comments here. Since we are working on further changes, I'm going to close this for now.

authors: RazzyJohnson arkjoseph cmnstmntmn grrowl kaishin mbesto renatodex samueljseay whmii

repo: thoughtbot/neat


text:
Broken normalize import when yarn isn't installed

Ran into this when it seemed like suspenders created a new project without any errors:
File to import not found or unreadable: normalize.css/normalize.
I had to track down how normalize was installed by digging into the source code. Seems like a preliminary check for a yarn installation might be necessary.

I just tried to use Suspenders and I have to admit to disappointment. If it is supposed to help people launch a new app quickly with lots of bells and whistles attached it simply doesn't work. First there are a load of "hidden" ENV variables to add in both staging and production, which are then incompatible with SENDGRID ENV variables supplied by Heroku. After that it simply falls over with this normalize issue above, so now I'm giving up and going back to the old "rails new" instead. A pity. It shows promise but it simply doesn't work out of the box and after three hours of hacking around I'm giving up.

Anyone ever find a fix for this? i'm having the same issue.

If you want to use yarn to retrieve assets, you have to install it first from https://yarnpkg.com/en/docs/install. Otherwise, you can remove the @import 'normalize.css/normalize' line from application.css

I just tried to use Suspenders and I have to admit to disappointment. If it is supposed to help people launch a new app quickly with lots of bells and whistles attached it simply doesn't work. First there are a load of "hidden" ENV variables to add in both staging and production, which are then incompatible with SENDGRID ENV variables supplied by Heroku. After that it simply falls over with this normalize issue above, so now I'm giving up and going back to the old "rails new" instead. A pity. It shows promise but it simply doesn't work out of the box and after three hours of hacking around I'm giving up.

Feel free to contribute :)

I think a note in the readme might suffice. I was thinking we could also add run "yarn --version" to check for a yarn installation in one of the generators and display installation instructions if nothing is found.

I'm also hitting this issue.

I had to add nodejs as a buildpack BEFORE the ruby one on heroku. No need for webpacker 🤔 .
Take a look at https://github.com/thoughtbot/suspenders/issues/930

Suspenders is now on Rails 6, which uses yarn and webpacker by default. If you don't have yarn installed it will print:
Yarn not installed. Please download and install Yarn from https://yarnpkg.com/lang/en/docs/install/

I just saw this error again when trying to deploy a newly created application to Heroku. I am using yarn, but normalize still isn't available. I think this is because the suspenders:stylesheet_base generator does not run by default when the application is created. We should move the normalize import into that generator.

Actually, this was the same problem. Something was up with my yarn install. It was still confusing, so I will leave this issue open. I wonder if we can fail right away with a more obvious message if yarn is not installed?

This might be rendered obsolete by #1135. We now check if Node is installed via #1201 and #1202.

authors: ACPK anhari composerinteralia delphaber stevepolitodesign swedishpotato

repo: thoughtbot/suspenders


text:
Fix timed method in Delta implementation for axis::Key

Aaaand again. Now the problem has been spotted in gltf example.

Now also includes fix for mouse wheel

repo: three-rs/three


text:
Development testing clients

Docker client

Codecov Report

Merging #435 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #435   +/-   ##
============================================
  Coverage        63.72%   63.72%
============================================
  Files               79       79
  Lines             3948     3948
============================================
  Hits              2516     2516
  Misses            1432     1432

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a323379...4393408. Read the comment docs.

authors: Dina-Abd-Elrahman codecov-commenter

repo: threefoldtech/js-ng


text:
Error in  SyncerFactory test

Test Location
/sandbox/code/github/threefoldtech/jumpscaleX_core/JumpscaleCore/tools/syncer/SyncerFactory.py
Error
JSX> j.tools.syncer.test()
Thu 30 10:16:23 nts/ssh/SSHClient.py - 168 - file_copy                          : EXCEPTION:
    Couldn't send /tmp/jumpscale/jumpscale/tmpt372v35k to /tmp/script_competent_wright.sh even though /tmp/ exists. Error:
        None
--TRACEBACK------------------
<stdin> in <module>
    1
/sandbox/lib/jumpscale/Jumpscale/tools/syncer/SyncerFactory.py in test
    37    s.sync(monitor=True)
/sandbox/lib/jumpscale/Jumpscale/tools/syncer/Syncer.py in sync
    270    if sshclient.executor.container_check:
/sandbox/lib/jumpscale/Jumpscale/clients/ssh/SSHClientBase.py in executor
    40    self._executor = j.tools.executor.ssh_get(self)
/sandbox/lib/jumpscale/Jumpscale/tools/executor/ExecutorFactory.py in ssh_get
    41    return self.get(name="ssh_%s" % sshclient.name, type="ssh", connection_name=sshclient.name)
/sandbox/lib/jumpscale/Jumpscale/core/BASECLASSES/JSConfigsBCDB.py in get
    113    jsconfig = self._create(name=name, **kwargs)
/sandbox/lib/jumpscale/Jumpscale/core/BASECLASSES/JSConfigsBCDB.py in _create
    95    jsconfig = jsconfig_klass(parent=self, jsxobject=jsxobject, **kwargs_to_class)
/sandbox/lib/jumpscale/Jumpscale/core/BASECLASSES/JSBase.py in __init__
    46    self._init(**kwargs)
/sandbox/lib/jumpscale/Jumpscale/tools/executor/ExecutorBase.py in _init
    41    self.load()
/sandbox/lib/jumpscale/Jumpscale/tools/executor/ExecutorBase.py in load
    48    eos = self._env_on_system
/sandbox/lib/jumpscale/Jumpscale/tools/executor/ExecutorBase.py in _env_on_system
    486    rc, out, err = self.execute(C, showout=False, interactive=False, replace=False)
/sandbox/lib/jumpscale/Jumpscale/tools/executor/ExecutorBase.py in execute
    203    debug=debug,
/sandbox/lib/jumpscale/Jumpscale/tools/executor/ExecutorBase.py in _cmd_process
    285    self.file_write(dest, script)
/sandbox/lib/jumpscale/Jumpscale/tools/executor/ExecutorSSH.py in file_write
    94    return self.sshclient.file_write(path=path, content=content, mode=mode)
/sandbox/lib/jumpscale/Jumpscale/clients/ssh/SSHClient.py in file_write
    119    self.file_copy(temp, path)
/sandbox/lib/jumpscale/Jumpscale/clients/ssh/SSHClient.py in file_copy
    168    f"Couldn't send {local_file} to {remote_file} even though {destination} exists. Error: {e}"
-----------------------------

Need to fix this first: https://github.com/threefoldtech/jumpscaleX_core/issues/489


text:
Add telemetry

Telemetry is needed to gain insight in how the application is behaving. There are 2 kinds we are interested in: traces and metrics. For metrics, we want information regarding the async runtime and system it's running on (to see how changes in the system reflect on changes in the application and vise versa), and general stats such as transmitted packets, dropped packets, etc... For traces, it would be ideal if we can capture traces for entire packet flows (sending, forwarding, receiving), once again to verify how this behaves in various scenarios.

After some deliberation, no further work will be done here for now. Logging is sufficient to trace individual packets as it stands (if the needed verbosity is enabled), and to track system changes. Metrics won't provide any additional insights. Especially since #12, all standard network tools are available (such as ping and traceroute). This can be reopened in the future should the need arise.

repo: threefoldtech/mycelium


text:
Kubernetes: got a deployment error after a successful deployment

Description
After deploying a kubernetes cluster i got the following error even though the cluster was deployed successfully.
Failed to deploy K8s. Please contact our support with the message 'Cannot read properties of undefined (reading 'data')'.

Everything in the cluster is working fine and i was able to ssh to the master and workers without any issues and executing kubectl get nodes in the master returns that the status of all workers is Ready

Deployment Details: https://gist.github.com/mohamedamer453/2462e7b4217f7998405de44312c04b27
Environment

Network: Devnet
Weblets Version: 830c472
Gridproxy Version: v1.8.0-rc2

Verified on Devnet,
Tried to deploy multiple instance of the Kubernetes master and error wasn't reproduicble,

repo: threefoldtech/tfgrid-sdk-ts


text:
feat: handle network offline/online

We should show a toast for user telling him connection is offline when it is and another one to tell him connection restored

verified on devnet
version : f530d72

https://github.com/threefoldtech/tfgrid-sdk-ts/assets/110984055/c591bac8-2f14-4cf7-9f06-c1dd760e8681
https://app.testlodge.com/a/26076/projects/40893/suites/234374?expand_section=422331#case_4250319


text:
Add user's menu to the sidebar

Free template doesn't include the user menu in the sidebar.
Build user menu using the paid template component as reference.
Evaluate if it's worth it to implement Vue behavior as well.

Closed by #165

repo: threefunkymonkeys/funky-world-cup


text:
Run Zero123 under 13GB RAM

Trying to run zero123 on Colab free tier fails because loading the model uses up all 12.7GB of RAM and crashes. Using some techniques to avoid loading the full model into RAM on the way to the GPU will unlock broader use of this exciting model.

Hi, @generatorman. We are actively addressing this issue, and you can refer to this pull request for more details.  You can also consider reducing the num_ray_samples to 256 and downsampling the resolution of images by adjusting the width and height parameters.

Thank you for the response. The PR you linked to seems related to VRAM usage - the issue I'm facing is with RAM. For example, running the following command quickly uses up 13GB of RAM and crashes, without using any VRAM at all.
!python launch.py --config configs/zero123.yaml --train --gpu 0 system.renderer.num_samples_per_ray=256 data.width=64 data.height=64
So currently it's bottlenecked by RAM usage rather than VRAM usage. Is there any quick fix I could apply?

I think loading the zero123 guidance model requires lots of RAM. To address this, you could consider modify torch.load(..., map_location='cpu') command to torch.load(..., map_location='cuda:0), which could potentially alleviate the memory consumption. Another alternative solution is to load an fp16 model instead of an fp32 model.

@generatorman Honestly, you're going to need plenty of RAM and VRAM to run this kind of model. It's inevitable at this stage. Over time the efficiency of the code will probably improve, but for now, you need a good GPU and a powerful system.
I recommend we close this issue for now.

Any idea what the minimum model would be required?

24GB is not enough, I run it on nvidia A10, it failed as OOM:
return self._call_impl(*args, **kwargs)
File "/home/dreamer/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/home/dreamer/.local/lib/python3.10/site-packages/torch/nn/modules/conv.py", line 460, in forward
return self._conv_forward(input, self.weight, self.bias)
File "/home/dreamer/.local/lib/python3.10/site-packages/torch/nn/modules/conv.py", line 456, in _conv_forward
return F.conv2d(input, weight, bias, self.stride,
torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 96.00 MiB. GPU 0 has a total capacty of 22.02 GiB of which 85.19 MiB is free. Process 22828 has 21.93 GiB memory in use. Of the allocated memory 19.16 GiB is allocated by PyTorch, and 299.45 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF

It seems 40GB VRAM is enough. I run it on A100 40G successfully.
 | Name       | Type                          | Params
-------------------------------------------------------------
0 | geometry   | ImplicitVolume                | 12.6 M
1 | material   | DiffuseWithPointLightMaterial | 0
2 | background | SolidColorBackground          | 0
3 | renderer   | NeRFVolumeRenderer            | 0
-------------------------------------------------------------
12.6 M    Trainable params
0         Non-trainable params
12.6 M    Total params
50.450    Total estimated model params size (MB)
[INFO] Validation results will be saved to outputs/zero123/[64, 128, 256]_1_clipdrop-background-removal.png_prog0@20231028-091058/save
[INFO] Loading Zero123 ...
LatentDiffusion: Running in eps-prediction mode
DiffusionWrapper has 859.53 M params.
Keeping EMAs of 688.
making attention of type 'vanilla' with 512 in_channels
Working with z of shape (1, 4, 32, 32) = 4096 dimensions.
making attention of type 'vanilla' with 512 in_channels
100%|███████████████████████████████████████| 890M/890M [00:56<00:00, 16.6MiB/s]
[INFO] Loaded Zero123!
/home/dreamer/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/connectors/data_connector.py:441: The 'train_dataloader' does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` to `num_workers=11` in the `DataLoader` to improve performance.
/home/dreamer/.local/lib/python3.10/site-packages/pytorch_lightning/trainer/connectors/data_connector.py:441: The 'val_dataloader' does not have many workers which may be a bottleneck. Consider increasing the value of the `num_workers` argument` to `num_workers=11` in the `DataLoader` to improve performance.
Epoch 0: |                                                        | 174/? [01:52<00:00,  1.55it/s, train/loss=12.50]Epoch 0: |                                                        | 175/? [01:52<00:00,  1.55it/s, train/loss=11.20]Epoch 0: |                                                        | 200/? [02:10<00:00,  1.53it/s, train/loss=11.20]

@davideuler I wondered if the peak of the VRAM varied a lot when you ran the code. I am using A6000 48G VRAM and running into the OOM at step 400 or so.
RuntimeError: /tmp/pip-req-build-zhms_45x/include/tiny-cuda-nn/gpu_memory.h:584 cuMemCreate(&m_handles.back(), n_bytes_to_allocate, &prop, 0) failed: CUDA_ERROR_OUT_OF_MEMORY
Epoch 0: |          | 415/? [03:30<00:00,  1.97it/s, train/loss=15.70]

authors: DSaurus claforte davideuler generatorman suptimq y22ma

repo: threestudio-project/threestudio


text:
test: print branch/leaf_stage seed on stderr

Print to stderr the seed used in the branch and leaf stage tests to make the tests easily reproducible locally

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#570  👈 (View in Graphite)
#566 : 1 other dependent PR (#567 )
#565
#564
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

repo: thrumdev/nomt


text:
[Maintenance] typo in docs for special tokens

dataloader.rst
Special tokens are counted as valid vocabularies.
->  Special tokens are counted as frequent vocabularies.

另外  field中 denseLabel和sparse label标题需要下调一级

repo: thu-coai/cotk


text:
Push notifications won't work after importing the settings from K-9 Mail on Android 15

Checklist

[X] I have used the search function to see if someone else has already submitted the same bug report.
[X] I will describe the problem with as much detail as possible.

App
Thunderbird for Android
App version
8.1
Where did you get the app from?
Google Play
Android version
15
Device model
Google Pixel 8a
Steps to reproduce

You already use K-9 Mail and IMAP push notifications
Install Thunderbird Mobile
Import settings from the K-9 Mail
Enable access to contacts and notifications
Send an email to your email account

Expected behavior
Push notifications will work as in K-9 Mail
Actual behavior
Push notifications doesn't work. On Android 15 it didn't display the push notification screen settings.
The workaround was to switch the notifications from push to poll and back in the Thunderbird settings. After that it displayed the push notification screen settings and everything works now.
Note that the same import steps worked fine on Android 12 device and the push notifications worked immediately as expected.
Logs
No response

I do not receive push notifications at all, even when set up manually.
I have K9 and Thunderbird. Both with enabled push notifications on the inbox folder. Both set up manually with the same account.
Push works on K9.
Push does not work on Thunderbird.

Thunderbird v8.0
K-9 v8.1
Thanks for the hint. I just installed Thunderbird from F-Droid. There it is the most recent version. This might already be fixed in 8.1?
Disabling push and enabling it again does not do anything. The same for the sync function (which I have no idea what that is)

There is something wrong on the recent Android versions.

Damn! This is it!
I was running K-9 on Android 8.1 but Thunderbird on Android 15.
Now I have both apps installed on Android 8.1 and push notifications now work for both. So there is a bug, but limited to newer Android versions.

Just to give as much information as possible: I now updated to Thunderbird 8.1 on Android 15 and could not get push to work - therefore different from what @pvones reports. Thunderbird already has permission to send notifications. New Emails also do not show up (push) when the inbox page is opened / in the foreground.
This issue is mainly about push not working when settings were imported from K-9. For me they do not work at all. So the scope is somewhat different.

Oh my god. Update: Push notifications now do work after I granted Thunderbird permission to "schedule alarms". I explicitly did not want to do that because I saw no need nor connection.

Interesting, I don't have the Thunderbird app listed in the special apps setting for alarms, but it works anyway (on Google Pixel).
Android is just a one big mess :-(

Same problem here.
Thunderbird 8.1 from F-Droid running on Oneplus 6 with lineageOS 21 (Android 14), I've imported my settings from thunderbird desktop.
Reminders and alarms activated, push is activated for all inbox folders, still I don't get any notification beyond "waiting for new email". Energy saving features of course deactivated. K9 mail worked flawlessly before.

After every app update or phone update, push no longer works. Once I have opened the app, it works again. Until the next time. Settings are all as recommended, I don't change anything before or after the updates.

I have same problem there.
My thunderbider version is 8.1, install form play store. And my Android version is 14, I imported settings form desktop with QR code.
The thunderbird was asked me for the notification permission, but I wasn't receive any notification. I was tired to find and open alaem permission but I can't find it in permission list.

Same situation with thunderbird 8.2 on Android 14, settings imported from desktop, and all tips above have been done (push enabled, alarm and reminders granted, etc.)

I was tired to find and open alaem permission but I can't find it in permission list.

That's the problem. Even the permission was set and the push notifications works correctly, Thunderbird isn't listed in the applications with the Alarm permission (Android 15).

authors: HIM049 PhoenixIV capitano799 carmenTuT dusscloud pvones

repo: thunderbird/thunderbird-android


text:
IMAP IDLE push stops working when device switches networks

Checklist

[x] I have used the search function to see if someone else has already submitted the same bug report.
[x] I will describe the problem with as much detail as possible.

App
Thunderbird for Android
App version
8.0b5
Where did you get the app from?
Google Play
Android version
15
Device model
Pixel 6a
Steps to reproduce

Reboot device for a fresh start
Make sure both Wifi and Mobile data are active
Make sure "Waiting for new emails" notification is active
Make sure IMAP IDLE push is working by sending yourself a "test" message
You should receive an instant notification
Turn off  Wifi and send yourself another "test" message (from a different device)*
Notification does not appear and email is not in the message index
Turn Wifi back on and send yourself another "test" message.
Still no notification.
Open Thunderbird and pull down to refresh
Emails appear
Send yourself yet another "test" message
Still no email
Go to "App info" for Thunderbird and "Force stop" the app
Reopen Thunderbird
Now send one last "test" message
Now the message appears

All messages to yourself are sent from a different device

Other info:  Changing the interval for "Refresh IMAP IDLE connection" does not change this wrong behavior
Expected behavior
IMAP IDLE should remain active and email notifications should be delivered instantly
Actual behavior
Receiving email and notifications stop when device switches networks
Logs
Log attached.
thunderbird_logs.txt

The log doesn't show any obvious errors. IMAP connections seem to be re-established and the IDLE command is issued.
The app downloaded a bunch of messages, but didn't generate notifications because the messages have been marked as read on the server (see K9NotificationStrategy: No notification: Message is marked as read lines in the log). This is intended behavior.

That is odd, because when I refresh by pulling down, I do see new unread messages appear. Is there any more info I can generate that may be useful?

There's a lot of traffic in the log. It's hard to tell if everything is working like it should or not. Maybe disable periodic sync and push for all accounts but one. Then perform the steps to reproduce and write down the current time for each step. For the new messages use numbered subject lines. That should make it easier to correlate the information in the log.
When sending the messages make sure you don't have another client running that will mark them as read.

Just a quick update. After turning off sync and just keeping push enabled seems to have fixed my issues. At some point when the push and sync settings moved to folders, sync somehow got re-enabled for me I guess. At any rate, I'm not seeing this issue anymore and is now behaving like K-9 used to. I'm going to close this issue. If I run across this again, I'll re-open. Thanks!

I am still able to reproduce this issue almost daily with the 8.1 version. Pixel 8a with Android 15.

authors: J0nnyMak0 cketti pvones


text:
Generating an address displays a different string for a moment

I think this is a small snag introduced in #278.
The QR image displays the string "No address yet" for a split second while the actual first address is computed.
https://user-images.githubusercontent.com/39974688/231176470-ff084bf3-c20f-4acb-8987-f27da82c0b6d.mov

I am sorry but I didn't get the issue. Can you elaborate on how we know where is the "No address yet" displayed?

DId you mean the QR that was visible for a split second, when scanned, gives "No address yet" ?

authors: thunderbiscuit yellowHatpro

repo: thunderbiscuit/padawan-wallet


text:
TransR代码种读取new_method目录下的文件

没有找到这个目录，请问这个目录中的文件是用来做什么的？

读取的是TransE train好的model文件，TransR需要使用TransE进行初始化。

repo: thunlp/KR-EAR


text:
使用 gogocode-plugin-vue 转换代码，css样式错乱

version: 0.2.28
playground demo: 使用 cli，当前线上版本的 playground 无法做到
your description: 在使用 gogocode-plugin-vue 转换 vue2 代码到 vue3 时，.vue 文件中的 scss 样式部分会被压缩，无法保持正常的格式化。现在的问题是，如果 scss 中包含注释块，那么转出来的格式就是不正确的，例子如下

转换前

转换后

这个问题我查了一下，根源是转换规则中的 transition 部分，使用了 css-tree 来解析 css，而本身 css-tree 是不支持保留格式输出的，可以看下官方 issue 讨论

repo: thx/gogocode


text:
STOP_LOSS_LIMIT & TAKE_PROFIT

Hi tiagosiebler,
I have wrote an Algo, I am struggling to implement to following. I want to create a STOP_LOSS_LIMIT order and when that one is succesful, it should create a TAKE_PROFIT inmediately.
I have the following params;
    let type = "STOP_LOSS_LIMIT";
    let side = "BUY"
    let quantity = dataObject.amountCoin;
    let price = dataObject.entryPrice;
    let stopPrice = dataObject.stopPrice;

How do I set a STOP_LOSS_LIMIT order on Futures market.. I set my leverage and margin type (isolated) already. That works like a charm. But I can't create the above order.
And how do I set a the following order TAKE_PROFIT ?
// let typeProfit = 'TAKE_PROFIT';
// let sideProfit = 'SELL';
// let takeProfitPrice = dataObject.exitPrice;
// // -------------------------------------------
// params2 = { 'stopPrice': takeProfitPrice }

I can't seem to figure out howto. Could you explain please?
Regards,
The Alpha Centauri Ninja

I've admittedly not used this mechanism as I just use limit reduce orders for TPs. Did you figure this out? Sounds like a useful example to add. If you're still stuck you could try asking how the request should look in the binance API telegram:
https://t.me/binance_api_english

Hi TiagoSiebler,
I managed the following:
/api/v3/order?symbol=VETUSDT&side=BUY&type=STOP_LOSS_LIMIT&timeInForce=GTC&quantity=825&price=0.1131&stopPrice=0.1120&newOrderRespType=RESULT&timestamp=1633422601488&signature=83d725fb12ac4e1c37778e45013c766951f58c95e40a99866f0523aeb01df1fe&recvWindow=60000
However I get the following error back : data: { code: -1022, msg: 'Signature for this request is not valid.' }
I manage to create the signature the following way:
serverTime = await binance.futuresTime();

let query_string = `timestamp=${serverTime}`
let secretKey = crypto.signature(query_string);

------------ FUNCTION IMPORT ---------------------
const apiSecret = process.env.EXCHANGE_SECRET_KEY
function signature(query_string) {
return crypto
.createHmac('sha256', apiSecret)
.update(query_string)
.digest('hex');
}

Do you have an idea what I am doing wrong?
Regards,
Ninja

Difficult to say with a fresh implementation. Why not use the library for this? If it's just api/v3/order for spot markets, then this should be the method:
const binanceApi = new MainClient({
  ...,
  recvWindow: 60000,
})

try {
  const result = await binanceApi.submitNewOrder({
    symbol: 'VETUSDT',
    side: 'BUY',
    type: 'STOP_LOSS_LIMIT',
    timeInForce: 'GTC',
    quantity: 825,
    price: 0.1131,
    stopPrice: 0.1120,
    newOrderRespType: 'RESULT',
  });
} catch (e) {
  // log/handle error
}

Thanks, I will try that :D

Is this resolved?

Can USDMClient  use STOP_LOSS_LIMIT config ?  if new orrder request activated with stop_price & profit_price ?

STOP_LOSS_LIMIT

@ChenYCL the futures docs does not mention STOP_LOSS_LIMIT as a type for new orders, so maybe not. You can try asking in the binance api support channel on telegram: https://t.me/binance_api_english

STOP_LOSS_LIMIT

@ChenYCL the futures docs does not mention STOP_LOSS_LIMIT as a type for new orders, so maybe not. You can try asking in the binance api support channel on telegram: https://t.me/binance_api_english

Thank you. Is there a way to add take profit & stop loss in  orders?
eg. new order use market type and get orderId reponse.

Perhaps using batch orders (treating them as separate orders):
https://binance-docs.github.io/apidocs/futures/en/#place-multiple-orders-trade
In my case I manually maintain/cancel/replace a TP limit order anytime I see a position update from the user data websocket.
For API/workflow questions not specific to only this connector though I really recommend asking in the api telegram community I've linked to above. You're more likely to get that kind of guidance there. Once you know which parameters to use with which endpoint, you can make those API calls using this connector.

Perhaps using batch orders (treating them as separate orders): https://binance-docs.github.io/apidocs/futures/en/#place-multiple-orders-trade
In my case I manually maintain/cancel/replace a TP limit order anytime I see a position update from the user data websocket.
For API/workflow questions not specific to only this connector though I really recommend asking in the api telegram community I've linked to above. You're more likely to get that kind of guidance there. Once you know which parameters to use with which endpoint, you can make those API calls using this connector.

👍 ok,i think it can achieve my goal, make new order then websocket get message .

authors: AlphaCentauriNinja ChenYCL tiagosiebler

repo: tiagosiebler/binance


text:
Binance APIs in the frontend & CORS

Hi, i'm using this library on browser. I know its intented for backend use but i'm prototyping and would to use it in browser.
I'm using
const client= new MainClient({
api_key: '*******',
api_secret: '*****',
beautifyResponses: true
})
client.testNewOrder(buyOrderRequest)
but i get following CORS errors.

Should the POST request contains an Access-Control-Request-Headers header for "x-mbx-apikey" header?
Looking into binance dev area it seems it's possible to make browser side calls only for public apis.
Can you confim? I'm thinking i could use a local proxy to forward local browser calls to binance server instead?
for example with cors-anywhere npm module

When directly making a request from a browser to a backend (in this case binance is the backend), CORS should be addressed by the backend. The backend essentially defines what is acceptable - in this case binance's APIs are not configured to accept this header (among many other CORS headers binance's APIs sadly are not configured for).
Bybit suffers the same limitation. Using your own CORS proxy is certainly an option (but not a public one), but safer would be to have these kind of API calls be triggered by your own backend. Some explanations here from a similar discussion in my bybit connector (which works very similarly):
https://github.com/tiagosiebler/bybit-api/issues/79#issuecomment-780756907
I would also recommend nudging binance about this - perhaps increased demand will nudge them enough to prioritise configuring their APIs for CORS. Hope this helps.

ok thanks. I used "cors-anywhere" npm package temporarily and it let me forward request to api.binance.com
Now i have another problem: url is not well encoded on newOrderTest as shown below:

so the api returns 400 bad request because url query params are maformed

Are you on the latest version? This was fixed in #180. v2.0.21 or above.

Also, once you get up and running, it'd be useful for others if you could write some kind of tutorial or high level summary on how to get this working in the browser (incl cors-anywhere implementation). Even a lazy example repo would be helpful.

Hi, did you manage to make it work correctly?
I think my signature is ok but the fact the call is from frontend is the issue.
I tried cors-anywhere and http-proxy-middleware.
I can't manage to have the proper response :(

Hi, did you manage to make it work correctly? I think my signature is ok but the fact the call is from frontend is the issue. I tried cors-anywhere and http-proxy-middleware. I can't manage to have the proper response :(

My recommendation is to make signed requests through a backend (this way your API keys are also not exposed to the browser). This would avoid the CORS limitation from binance as well as reduce risk to those API keys, although it would mean maintaining some backend APIs that your frontend can use. You would also need to consider rate limits, since your backend would be making API calls (likely from the same IP), although you would see this with cors-anywhere too.

tiagosiebler and sergiocard thank you for your help!
Before I set cors-anywhere wrong.
It works now and I have a proper response from Binance! 🥳

authors: niebieskiRydz sergiocard tiagosiebler


text:
configurando o ambiente do desevolviemnto

-VScode
-Organizar as pastas do pacote python
-adicinar os meta arquivos
-tomar o pacote instavel

[ ] -VScode
[ ] -Organizar as pastas do pacote python
[ ] -adicinar os meta arquivos
[ ] -tomar o pacote instavel

license: Unlicense


text:
🌐 Add Chinese translation for docs/zh/docs/deployment/https.md

as title

📝 Docs preview for commit a96292b488cbc317f660279a2ff3dd9efa778f11 at: https://649a08ee219954094e357f72--fastapi.netlify.app

It seems this was covered in another PR, so I'll now close this one, but thanks for the effort! :rocket: :cake:

repo: tiangolo/fastapi


text:
Allow to set custom scheme for 4xx responses

Code from https://github.com/tiangolo/fastapi/pull/437 checks for custom schemas on response,
but it missed the fact that all codes are uppercased in https://github.com/tiangolo/fastapi/blob/master/fastapi/openapi/utils.py#L196

Thanks for your contribution @tsouvarev ! :tada: :cake: :rocket:

authors: tiangolo tsouvarev


text:
🛑 TICKETS.BJ is down

In 017005f, TICKETS.BJ (https://tickets.bj) was down:

HTTP code: 0
Response time: 0 ms

Resolved: TICKETS.BJ is back up in 1474c49 after 1 hour, 55 minutes.

repo: tickets/upptime


text:
Restructure logging to be more SOLID

After discussion how to make logging system more SOLID, we have agreed on the first points: having a logger, which will be used by modules, and a loggable interface, which should be conformed to in the domain where we want to log. This guarantees some basic consistency in the logging usage.

Add TidalLogger
Add TidalLoggable
Add Logging dependency in Common

Next:

Update Auth to use the new API from this PR
Add logging in Player

This pull request introduces a logging framework to the project by adding a new TidalLogger struct and TidalLoggable protocol, along with necessary dependencies. These changes aim to standardize and simplify logging across the codebase.
Logging Framework Integration:

Added TidalLoggable Protocol: Introduced a protocol defining requirements for loggable objects, including properties for logging message, metadata, log level, and source. (Sources/Common/Logger/TidalLoggable.swift)
Added TidalLogger Struct: Created a struct to provide a convenient API for logging, including methods to log messages at different levels and handle TidalLoggable objects. (Sources/Common/Logger/TidalLogger.swift)
Updated Package Dependencies: Added the Logging dependency to the Common target in the Package.swift file to support the new logging framework. (Package.swift)

My only comment, for the future, not now, would be to have some kind of short guidelines on how much can we/should we log, what data is ok to log, when to use .trace vs .debug etc

Totally, we do need guidelines. There are some recommended by Apple regarding levels, so potentially we could use that. But we still need to agree on this and general guidelines of usage.

repo: tidal-music/tidal-sdk-ios


text:
用一个 express 服务器来提供静态文件，从而统计下载量

目前应该是直接作为静态文件直接提供下载，如果用一个服务器程序挡一下，就可以统计下载量、访问量，存到本地 tiddlers/文件夹里的一个json文件里，就可以在网页上展示下载量了

Matomo, Google Analysis, 百度统计等可以为网站埋点

有服务器都不需要他们了，而且他们无法统计下载量

repo: tiddly-gittly/TiddlyWiki-CPL


text:
feat: add MapProjectorInfo

Related Links

https://github.com/autowarefoundation/autoware.universe/pull/3200

Description

add tier4 map msgs pacakge

add MapProjectorInfo to publish the information of the map projector

Remarks

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[x] Code is properly formatted
[x] Assign PR to reviewer

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code is properly formatted
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[x] All open points are addressed and tracked via issues or tickets
[ ] Write release notes

CI Checks

Build and test for PR: Required to pass before the merge.
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@mitsudome-r Hi, I'm adding the protector type message for the map loader to publish, can you review it?


text:
io/linux: Add support for using block devices as datafiles

Tested on my local machine.
Currently, this does not check that tigerbeetle format is not overwriting an existing datafile.
I'm not entirely sure what the semantics for tigerbeetle format on block devices should be.
Some thoughts:

a confirmation dialog could be good? but not good for scripting, though the standard solution there is to add another command line argument (but then we have to rework the interface which is maybe worth it)
it's hard to detect whether we're overwriting stuff at all, since I don't think we have a tigerbeetle datafile magic

it's hard to detect whether we're overwriting stuff at all, since I don't think we have a tigerbeetle datafile magic

This worries me a bit - things like someone accidentally overwriting their filesystem (or TigerBeetle datafile) by specifying the wrong data path.
Maybe a good enough solution would be to check that the first X MB are zero'd? That way, we don't need our own magic, and we don't need an override (if they want to script it, they can use dd as part of the same script too).

@sm2n after chatting a bit more with Joran, if we're on a block device, we can check that the first superblock_zone_size of a device is zero'd:

It'll ensure that the block device is not directly TigerBeetle.
It'll be very likely to catch any cases where there's an existing other filesystem.
In the case of there being a partition table (eg, two partitions, one starting at 0MB, one at 1024MB) and the operator tries to format the raw disk (/dev/sda) while a partition later is TigerBeetle (/dev/sda2) it'll be blocked by the MBR/GPT existing.

I like the solution of checking if the superblock is empty. I ended up pasting @cb22's summary of the solution into the code, since I thought it was well written.
Now the code does actually check if the superblock is empty.

@sm2n we've just rewritten our git history:
https://github.com/tigerbeetle/tigerbeetle/commit/d7c3f4654ea7c65b6d141be33dadd29e869c3984
Please rebase the changes on top of new main, and sorry for the inconvenience!

No big deal, 30s in interactive rebase did it.

Let’s merge it, to gauge our benchmark variance before dropping balance indexes!

repo: tigerbeetle/tigerbeetle


text:
add ClickHouse support

Please add ClickHouse support.
https://hub.docker.com/r/yandex/clickhouse-server/

@plakhin  I made a branch if you want to check it out. https://github.com/K03413R/takeout.git

@mattstauffer  This can be closed. Pr #159 added this.

@mattstauffer  This can be closed. Pr #159 added this.

hanks @grantjanecek!

hanks @grantjanecek!

authors: K03413R grantjanecek mattstauffer plakhin

repo: tighten/takeout


text:
Rebase nuttx

Rebase NuttX again to latest upstream master.
Temporarily disable the Athena HW crypto block from v2 and pi bootloaders, as nuttx size has grown so much that it doesn't fit otherwise. This needs to be resolved

OK, merging, thanks!


text:
storage: reduce scheduler msgs

What have you changed? (mandatory)
This PR reduces scheduler msgs, also offloads some functions from scheduler to workers.
What are the type of the changes? (mandatory)

Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)
Unit tests and integration tests.
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No.
Refer to a related PR or issue link (optional)
#3581 , #3551 and #3582
Benchmark result if necessary (optional)
Combining these changes #3581, #3551 and #3582, QPS is improved from 40672.1 to 49144.5, and avg latnecy is reduced from 100.6ms to 83.5ms.

/run-all-tests

/run-all-tests

/run-all-tests

repo: tikv/tikv


text:
raftstore: delay replica read when applying snapshot

Signed-off-by: 5kbpers tangminghua@pingcap.com

What have you changed?
When a peer is applying a snapshot, it will clean up the data of the region and ingest the snapshot file.
If a replica read happens between the two operations, the empty data will be returned.
This PR delays all replica reads when the peer is applying snapshot.
What is the type of the changes?

Bugfix (a change which fixes an issue)

How is the PR tested?

Unit test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No.
Does this PR affect tidb-ansible?
No.

/test


text:
copr: tablescan support common handle encoding

Signed-off-by: Iosmanthus Teng myosmanthustree@gmail.com

What problem does this PR solve?
This pull request enables BatchTableScanExecutor to handle common handles embedded in a row key. Common handles are datums whose column id is passed from TiDB via an array named primary_columns_id. This pull request extracts the datum from the row key and fills them into a row.
Check List
Tests

Unit test (WIP)

Release note

BatchTableScanExecutor supports common handle encoding.

LGTM

/run-all-tests

@zhongzc PTAL

/merge

/merge

authors: breeswish coocood iosmanthus


text:
Fix test_security_status_service_with_cn test

Signed-off-by: Xintao hunterlxt@live.com

What problem does this PR solve?
Problem Summary:
https://github.com/tikv/tikv/pull/8064 removed some uri paths from the list to be checked CN. But this test use /metrics which don't need be checked. Let's use /region and it should be checked.
Another issue is after @sticnarf's future update, the future will return a result rather than an item itself.
Release note

Fix test_security_status_service_with_cn unit test

LGTM

/merge

/merge

authors: hunterlxt sticnarf yiwu-arbug zhouqiang-cl


text:
Engine: support sample dictionary compression

What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
Sampling dictionary compression may enhance the compression rate when using small data blocks.
Refer: https://github.com/facebook/rocksdb/wiki/Dictionary-Compression
What is changed and how it works?
Update rocksdb and add new parameters to config rocksdb to enable sample dictionary compression.
Related changes

PR to update doc

Release note

Support sample dictionary compression

/rebuild

/rebuild

/rebuild

/rebuild

/rebuild

What problem does this PR solve?
Issue Number: close #xxx
close #8721

Problem Summary:
Sampling dictionary compression may enhance the compression rate when using small data blocks.
Refer: https://github.com/facebook/rocksdb/wiki/Dictionary-Compression
What is changed and how it works?
Update rocksdb and add new parameters to config rocksdb to enable sample dictionary compression.
Related changes

PR to update doc

Release note

Support sample dictionary compression

RocksDB bottom level compression fixed to be zstd. Support dictionary compression at bottom level.

Let's move forward with this one.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: ZhenhanGong:x: hunterlxtYou have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: ZhenhanGong:x: hunterlxtYou have signed the CLA already but the status is still pending? Let us recheck it.

Set bottommost compression to zstd can improve the compression ratio of L6.

Looking good overall. Please also send PR to update docs.

/run-all-tests

/merge

@hunterlxt can you help update the release note to the following?
- rocksdb: Fix bottommost level compression ratio lower than expected by forcing the bottommost level to use ZStd compression by default

/run-cherry-picker

release-5.0-rc is checked out after this PR merged. The cherry-pick is not required.

It turns out this PR was already included in release-5.0-rc branch.

authors: CLAassistant ZhenhanGong hunterlxt yiwu-arbug you06


text:
resolved_ts: add endpoint

Signed-off-by: 5kbpers tangminghua@pingcap.com

What problem does this PR solve?
Problem Summary:
Add endpoint for resolved ts.
What is changed and how it works?
What's Changed:

Add endpoint
Add rts_id to apply::ObserveCmd for temporarily being compatible with CDC
Run resolved ts worker when starting TiKV server

Check List
Tests

Unit test
Integration test

Release note

N/A

Please resolve the conflict.

/merge

/merge

/merge

/merge

/hold

/merge cancel
/unhold

@5kbpers consistent failures. PTAL~

/run-all-tests

/merge

authors: 5kbpers NingLin-P hi-rustin


text:
Stuck on running

Before raising an issue
Have you installed all required dependencies? See the installation instructions for details.
Yes, and the run test shows test successful.
Describe the bug
When I click run, it is always stuck on running, without any output.
Screenshots

Console output
Visit the jupyter plugin settings page and click the Run test button (available from version 0.2.0). Then copy and paste the output from the developer tools console here.
created new client for doc test-document using interpreter /Users/du/opt/anaconda3/bin/python
plugin:obsidian-jupyter:3146 INFO:obsidian-jupyter:started server for document test-document

plugin:obsidian-jupyter:3146 INFO:obsidian-jupyter:received request: {"id":"32e88402-630b-4892-a001-ca67efd65f3c","body":{"command":"execute","source":"1 + 1"}}

plugin:obsidian-jupyter:3146 INFO:traitlets:Executing notebook with kernel:

plugin:obsidian-jupyter:3146 INFO:obsidian-jupyter:sent response: {"id": "32e88402-630b-4892-a001-ca67efd65f3c", "body": "
\n
\n
In [1]:
\n
\n
\n

1 + 1\n

\n\n
\n
\n
\n\n
\n
\n\n\n
\n\n
Out[1]:
\n\n\n\n\n
\n
2
\n
\n\n
\n\n
\n
\n\n
\n \n\n"}

plugin:obsidian-jupyter:3135 received response {id: '32e88402-630b-4892-a001-ca67efd65f3c', body: '<div class="cell border-box-sizing code_cell rende…2
\n
\n\n
\n\n
\n
\n\n
\n \n\n'}
plugin:obsidian-jupyter:3339 Received response

In [1]:

1 + 1

Out[1]:

2

plugin:obsidian-jupyter:3146 INFO:obsidian-jupyter:shutting down kernel...

plugin:obsidian-jupyter:3146 INFO:obsidian-jupyter:exiting...

Python dependencies
Run pip freeze from the console. Then copy and paste the output here.
created new client for doc test-document using interpreter /Users/du/opt/anaconda3/bin/python
plugin:obsidian-jupyter:3146 INFO:obsidian-jupyter:started server for document test-document

plugin:obsidian-jupyter:3146 INFO:obsidian-jupyter:received request: {"id":"06b1514d-1d89-47ed-bd7d-16c1a6656150","body":{"command":"execute","source":"1 + 1"}}

plugin:obsidian-jupyter:3146 INFO:traitlets:Executing notebook with kernel:

plugin:obsidian-jupyter:3146 INFO:obsidian-jupyter:sent response: {"id": "06b1514d-1d89-47ed-bd7d-16c1a6656150", "body": "
\n
\n
In [1]:
\n
\n
\n

1 + 1\n

\n\n
\n
\n
\n\n
\n
\n\n\n
\n\n
Out[1]:
\n\n\n\n\n
\n
2
\n
\n\n
\n\n
\n
\n\n
\n \n\n"}

plugin:obsidian-jupyter:3135 received response {id: '06b1514d-1d89-47ed-bd7d-16c1a6656150', body: '<div class="cell border-box-sizing code_cell rende…2
\n
\n\n
\n\n
\n
\n\n
\n \n\n'}
plugin:obsidian-jupyter:3339 Received response

In [1]:

1 + 1

Out[1]:

2

plugin:obsidian-jupyter:3146 INFO:obsidian-jupyter:shutting down kernel...

plugin:obsidian-jupyter:3146 INFO:obsidian-jupyter:exiting...

It looks like the YAML metadata in your document sets the interpreter path to the literal interpreter-path such that the plugin cannot find the python executable. Could you try rerunning the script without the YAML header?

authors: dutry tillahoffmann

repo: tillahoffmann/obsidian-jupyter


text:
How to disable camera cell?

Can't seem to disable the camera cell in the selection

Hi,  @jemzubiri
TLPhotosPickerConfigure
configure.usedCameraButton = false

@jemzubiri
    let viewController = TLPhotosPickerViewController()
    var configure = TLPhotosPickerConfigure()
    configure.usedCameraButton = false
    **viewController.configure = configure**

Completely missed that. Thank you so much!

authors: jemzubiri tilltue

repo: tilltue/TLPhotoPicker


text:
Uncaught TypeError: Cannot read property 'appendChild' of null

We are using the ember-plupload plugin and have noticed that when quickly switching between routes that have components rendering {{plupload}} we get an error originating in moxie.js L#2387.
It attempts to call container.appendChild(shimContainer) on that line and generates a "Uncaught TypeError: Cannot read property 'appendChild' of null" error.
My best guess is it has something to do with Ember component lifecycle events and the component (container?) being destroyed before plupload gets to this line.

Sounds about right.

Is there a way to preempt this behavior to prevent the error on our side?

Ugh. Probably the solution is sprinkle in checks for if (this.isDestroyed) in the component hooks

+1

Ugh. Probably correct. A PR is welcome

authors: JosephHalter bdmac tim-evans

repo: tim-evans/ember-plupload


text:
Adding version attribute

Ticket: #1005
Reviewer: @jarednova
Issue

There is no way to get the current version of Timber
Solution

Add static property with current version number
Impact

No impact
Usage

Timber::$version
Considerations

We could use a function, but just makes more sense for it to be an attribute
Testing

Not included

Coverage remained the same at 87.977% when pulling 28f1282c9b7ac7c8580f3868d06507644ea41cd6 on cjb-version-attribute into 7ae6337f1811b2a274dc43c6434e48b464ec7746 on master.

Coverage remained the same at 87.977% when pulling 4ab02bf4c799ef0b2d4f6f88a74afe4fa09c3068 on cjb-version-attribute into 05973f2367e6652398d852c2a6f12c32ea30c862 on master.

Coverage remained the same at 87.977% when pulling 4ab02bf4c799ef0b2d4f6f88a74afe4fa09c3068 on cjb-version-attribute into 05973f2367e6652398d852c2a6f12c32ea30c862 on master.

lookin' good!

authors: connorjburton coveralls jarednova

repo: timber/timber


text:
Switch from :uuid to :elixir_uuid

The :uuid library has changed it's name to :elixir_uuid. This causes a conflict error when building our app since other libraries depend on :elixir_uuid:
==> Release failed, during .boot generation:
        Duplicated modules:
    	'Elixir.UUID' specified in elixir_uuid and uuid

BTW.
I can make a PR with that but locally tests are failing due to:
** (EXIT from #PID<0.204.0>) shutdown: :econnrefused

@timbuchwaldt Any suggestions how to handle it?

Hey, sorry for the slow response.
I just updated to 0.6.1 -> All dependencies updated.

repo: timbuchwaldt/exmqttc


text:
Incorrect OPEN_TRUNK documentation

For my TMX (2018.26 3bbd9fd), the OPEN_TRUNK documentation seemed to be off. After fiddling, I found that the suggested URL parameter "which_trunk" should actually be in the posted JSON body.
POST https://owner-api.teslamotors.com/api/1/vehicles/XXXXXXX/command/trunk_open with JSON body:
{
  "which_trunk": "rear"
}

In the URL, XXXXXXX is your vehicle ID, of course.

Can you make a PR to fix it?

I am not familiar with the syntax (assuming it's https://github.com/timdorr/model-s-api/blob/master/apiary.apib I'd need to fix). Judging from this file alone, it does not specify whether which_trunk is a GET or POST data variable - from the docs page itself, though, it modifies the URL.

It's listed as a POST:

Open Trunk/Frunk [POST /api/1/vehicles/{vehicle_id}/command/trunk_open]

Unfortunately, API Blueprint doesn't really make JSON POST data easy to express. I'm looking at rewriting the docs into just a static site, so the format is just plain Markdown at that point.
I think it's correct, just wonky with the expressiveness of the format.

authors: coenvdwel timdorr

repo: timdorr/model-s-api