text:
Approx margin has surprising edge-case behaviour with precise values

Description
If you use Approx and margin with precisely-representable values, and the value is precisely Approx +- margin, the test fails. The documentation states:

margin serves to set the the absolute value by which a result can be erroneous before it is rejected. By default set to 0.0.

My understanding of this is that if the result is erroneous by precisely the margin, then it should not be rejected.
Steps to reproduce
#define CATCH_CONFIG_MAIN
#include "catch.hpp"

TEST_CASE( "Approx with exactly-representable margin" )
{
    CHECK( 0.25f == Approx( 0.0f ).margin( 0.25f ) );

    CHECK( 0.0f == Approx( 0.25f ).margin( 0.25f ) );
    CHECK( 0.5f == Approx( 0.25f ).margin( 0.25f ) );

    CHECK( 245.0f == Approx( 245.25f ).margin( 0.25f ) );
    CHECK( 245.5f == Approx( 245.25f ).margin( 0.25f ) );
}

Current result: All five assertions fail.
Expected result: All five assertions pass.
Extra information

Catch version: v1.9.6
Operating System: CentOS 7 Linux on AMD64
Compiler+version: g++ "Red Hat 4.8.5-4" (stock) and g++ Red Hat 6.2.1-3 (devtoolset-6)

The current implementation only accepts values that are off by less than margin.
I can see how that is not reflected by the docs, and having the margin be inclusive is likely a better idea, but it could be a breaking change, so we will need some time to decide.

I think that the right value would be achieved by margin( epsilonVal + epsilonVal * std::numeric_limits<decltype( epsilonVal )>::epsilon() ). If that's correct (my floating-point math is a little weak) then perhaps a new method (marginInclusive?) could be added that sets m_margin to the above, and hence avoids breaking backwards compatibility.
TEST_CASE( "Approx with exactly-representable margin and epsilon added" )
{
    CHECK( 0.25f == Approx( 0.0f ).margin( 0.25f + std::numeric_limits<float>::epsilon() * 0.25f ) );

    CHECK( 0.0f == Approx( 0.25f ).margin( 0.25f + std::numeric_limits<float>::epsilon() * 0.25f  ) );
    CHECK( 0.5f == Approx( 0.25f ).margin( 0.25f + std::numeric_limits<float>::epsilon() * 0.25f ) );

    CHECK( 245.0f == Approx( 245.25f ).margin( 0.25f + std::numeric_limits<float>::epsilon() * 0.25f ) );
    CHECK( 245.5f == Approx( 245.25f ).margin( 0.25f + std::numeric_limits<float>::epsilon() * 0.25f ) );
}

passed.

0.0 == Approx( 0.0 )
fails too !

CHECK( 0.25f == Approx( 0.0f ).margin( 0.25f + std::numeric_limits::epsilon() * 0.25f ) );
SHOOT ME NOW :D
when testing is more complicated than what is tested :D

I am consolidating the Approx issues into one, #980.

authors: TBBle horenmar pip010


text:
Improve junit xml for jenkins

This pull request improves the junit xml output in the following ways

The output isn't significantly different for TEST_CASEs with and without SECTIONs
With "-#" test results will be grouped by [#filename] in jenkins test results UI
The test suite name will be used for grouping too

Addressing these three issues ensures that the test results are logically organized in the jenkins test results UI.
This adresses #922 and maybe #320.
I've split the PR up in three tiny commits to ease review.

I will have to think about this.
In general I agree with the changes, but it is not a change that can be done trivially. Both xml and junit reporters are meant to be consumable by outside tools, so changing their output is potentially breaking change.

This could indeed break things. The best option is perhaps to make a "junit2" reporter with the new behaviour. That is what I have done in my own project. It could also be called "junit-jenkins". The change that encodes the test suite name in the classname attribute as a java package justify this name, I think.
I can alter the pull request to do this.

I thought about it a bit more, and decided to do two things:

I am going to merge the changes to the default junit reporter in Catch 2 branch. Since it is a major release, breaking changes are expected and this should be an improvements for most people.

I am going to link this PR from reporter documentation, so other people using Jenkins can make the changes for themselves, until Catch 2 is released.

I definitely do not want to add another reporter that is included in Catch by default, and single, relatively small, change is probably not worth a stand-alone reporter if it is going to be merged in (hopefully close) future.

I see the changes have been merged to branch dev-modernize, so closing pull request.

source: gharchive/pull-request

authors: horenmar tsondergaard

repo: philsquared/Catch

license_type: permissive

license_source: github-api


text:
Take into account instances when hashing

We do not hash instances because they cause cycles.

Fixed in c8f7771c6bfc7ae18a24f851f29942a1a9b7a50e

source: gharchive/issue

repo: phischu/fragnix

license_source: bigquery


text:
Drop InterlockedBool

It is internal and seems not to be used at all. Unless, I'm mistaken, this is dead code. Just as BuildEventArgsReaderProxy. See #258

@phmonte Can we drop this unused code?

@Corniel Yes, can I do the merge or are there still any pending commits?

This is all.

authors: Corniel phmonte

repo: phmonte/Buildalyzer

license: MIT


text:
为什么我的win版本安装了只能看腾讯的，找不到别的网站入口

为什么我的win版本安装了只能看腾讯的，找不到别的网站入口，而且线路也没有

我也是哎，我win10的系统

能截个图看一下么？
@lwmxiaobei @llRabbit

同样的问题，而且没有可以选择的线路，win7系统

小白刚入手，能教教我怎么运行吗

我的也是，关闭了，然后重启下就应该有了
2018-07-16
li2480456
发件人：stardown1 notifications@github.com
发送时间：2018-07-16 09:37
主题：Re: [phobal/ivideo] 为什么我的win版本安装了只能看腾讯的，找不到别的网站入口 (#20)
收件人："phobal/ivideo"ivideo@noreply.github.com
抄送："Subscribed"subscribed@noreply.github.com
小白刚入手，能教教我怎么运行吗
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

不是，主要我找不着怎么运行这种项目

解压以后找到这个文件，执行就可以了
2018-07-16
li2480456
发件人：stardown1 notifications@github.com
发送时间：2018-07-16 09:46
主题：Re: [phobal/ivideo] 为什么我的win版本安装了只能看腾讯的，找不到别的网站入口 (#20)
收件人："phobal/ivideo"ivideo@noreply.github.com
抄送："King.Li"li2480456@163.com,"Comment"comment@noreply.github.com
不是，主要我找不着怎么运行这种项目
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

解压了都是一些js文件和不可执行的文件，是可以直接运行吗

你可以把源码下载下来自己编译一下，可以编译成安装包
| |
冯博
web前端开发工程师
|
|
众安在线
邮箱：phobal@126.com
|
签名由 网易邮箱大师 定制
在2018年07月16日 10:03，stardown1 写道：
解压了都是一些js文件和不可执行的文件，是可以直接运行吗
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

那请问这种项目要用什么编译呢

晚一点我写一个步骤放在 README 里去
| |
冯博
web前端开发工程师
|
|
众安在线
邮箱：phobal@126.com
|
签名由 网易邮箱大师 定制
在2018年07月16日 10:09，stardown1 写道：
那请问这种项目要用什么编译呢
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

好的
多谢啦

authors: Chen235 JoinWorld llRabbit lwmxiaobei phobal stardown1

repo: phobal/ivideo


text:
Laravel 5.0

This is a running list of items that need to be addressed for the upcoming Laravel 5.0 release

Create Table Command should autodetect, and/or give the option of where to place the migration file

done

repo: phoenix-labs/eloquent-meta

license: mit


text:
Raiden Shogun doesn't charge attack | Sprint also not working?

This could be me just misusing the actions, but:
on-long-press = a~
doesn't seem to cause raiden to charge attack, but chain autos.
Also, it seems using sprint with s doesn't seem to work either. Couldn't find anything in issues, so posting here in case.
edit; a~ doesn't also seem to work on Tartaglia during his melee stance.

This issue was fixed in v28.
Have a go :)

sprint still not working. im testing it with hu tao. i did this to test
[hu_tao]
on-long-press = s

well there was a typo mistake
and it will be fixed in v29 asap

authors: mmaine phonowell thu2468

repo: phonowell/genshin-impact-script


text:
Dragging window triggers swipe event and changes photos

If you grab the title bar and move it around some while in slideshow view the photo will change.

heh, oh GTK views. I should probably just remove the swipe gestures and work on a bigger framework for gesture / keyboard / mouse bindings (although the swipe to change is really useful...).

I'm unable to reproduce this; can you give me exact GTK version? (also, does it happen with Wayland and X?)

authors: SamWhited campaul

repo: photoshell/photoshell


text:
detect url in caption ?

in bot telegram api For text messages we have entity type for detect url, mention, text_mention. But! For photo,video with caption how we detect url,mention.? In other hand how can we use entity type in caption of photo,video?

Entities are there only for cases when updating messages (that are either html formated or use markdown) so it can be reformatted properly.
There is no such thing for caption, you will have to write a regex for this...

thanks.

Entities are there only for cases when updating messages (that are either html formated or use markdown) so it can be reformatted properly.
@jacklul I'm trying to reformat an edited message, but without success. How can I use the entities to properly reformat?

@KilluaFein proof of concept:
   private function parseEntitiesString($text, $entities)
    {
        $global_incr = 0;
        foreach ($entities as $entity) {
            if ($entity->getType() == 'italic') {
                $start = $global_incr + $entity->getOffset();
                $end = 1 + $start + $entity->getLength();

                $text = $this->mb_substr_replace($text, '_', $start, 0);
                $text = $this->mb_substr_replace($text, '_', $end, 0);

                $global_incr = $global_incr + 2;
            } elseif ($entity->getType() == 'bold') {
                $start = $global_incr + $entity->getOffset();
                $end = 1 + $start + $entity->getLength();

                $text = $this->mb_substr_replace($text, '*', $start, 0);
                $text = $this->mb_substr_replace($text, '*', $end, 0);

                $global_incr = $global_incr + 2;
                } elseif ($entity->getType() == 'code') {
                $start = $global_incr + $entity->getOffset();
                $end = 1 + $start + $entity->getLength();

                $text = $this->mb_substr_replace($text, '`', $start, 0);
                $text = $this->mb_substr_replace($text, '`', $end, 0);

                $global_incr = $global_incr + 2;
                } elseif ($entity->getType() == 'pre') {
                $start = $global_incr + $entity->getOffset();
                $end = 3 + $start + $entity->getLength();

                $text = $this->mb_substr_replace($text, '```', $start, 0);
                $text = $this->mb_substr_replace($text, '```', $end, 0);

                $global_incr = $global_incr + 6;
            } elseif ($entity->getType() == 'text_link') {
                $start = $global_incr + $entity->getOffset();
                $end = 1 + $start + $entity->getLength();
                $url = '(' . $entity->getUrl() . ')';

                $text = $this->mb_substr_replace($text, '[', $start, 0);
                $text = $this->mb_substr_replace($text, ']' . $url, $end, 0);

                $global_incr = $global_incr + 2 + mb_strlen($url);
            } elseif ($entity->getType() == 'code') {
                $start = $global_incr + $entity->getOffset();

                $text = mb_substr($text, 0, $start);
            }
        }

        return $text;
    }

Never managed to make it work for 100% cases.
Multibyte characters break offsets.

Multibyte characters break offsets.

Like emoji, right?
and what is mb_substr_replace()?

offset and length are UTF-16 encoded, maybe a way to convert to UTF-8 to solve this?

mb_XXX functions are for multi-byte strings (mb I guess).
It took me a lot of time thinking on this and I NEVER found a solution to properly get it to work.

public static function processEntities (string $_text, array $_message_raw): string
    {
        $preset = [
            'bold'      => '%text',
            'italic'    => '%text',
            'text_link' => '%text',
            'code'      => '%text',
            'pre'       => '
%text
',
        ];

        if (!isset ($_message_raw['entities']))
        {
            return $_text;
        }

        $iterationText = $_text;
        $globalDiff    = 0;
        foreach ($_message_raw['entities'] as $entity)
        {
            $type   = $entity['type'];
            $offset = $entity['offset'] + $globalDiff;
            $length = $entity['length'];

            $pBefore = \mb_substr ($iterationText, 0, $offset);
            $pText   = \mb_substr ($iterationText, $offset, $length);
            $pAfter  = \mb_substr ($iterationText, ($offset + $length));

            // Note: str_replace() works good with utf-8 in the last php versions.
            if (isset ($preset[$type]))
            {
                // Get pattern from the preset.
                $replacedContent = $preset[$type];

                // First, replace url, in that rare case, if in the text will be the %text macros.
                if (!empty ($entity['url']))
                {
                    $replacedContent = \str_replace ('%url', $entity['url'], $replacedContent);
                }

                // Replace main text.
                $replacedContent = \str_replace ('%text', $pText, $replacedContent);

                $newText       = $pBefore . $replacedContent . $pAfter;
                $globalDiff    += (\mb_strlen ($newText) - \mb_strlen ($iterationText));
                $iterationText = $newText;
            }
        }

        return $iterationText;
    }

I believe the point of this issue is to have a way to edit and reformat messags using entities field, because these do not contain formating we have to use 'entities' field for that, I never managed to create a function that could parse this and put into message string correctly because of multibyte strings...
One of simpliest examples would be button under a message that removes or add text to the message while keeping message contents (and that content cannot be obtained/generated in any other way than grabbing it from Message object).

Any news on this issue? Emojis + text formatting using entities info (offset, length)

I have a working version, needs some further testing and then I'll release it :+1:

My latest experiment, try this class, and use it like:
$entity_decoder = new EntityDecoder($message, 'markdown'); // or 'html'
$decoded_text   = $entity_decoder->decode();

<?php

use Longman\TelegramBot\Entities\Message;
use Longman\TelegramBot\Entities\MessageEntity;

class EntityDecoder
{
    private $entities;
    private $text;
    private $style;
    private $without_cmd;
    private $offset_correction;

    /**
     * @param Message $message     Message object to reconstruct Entities from.
     * @param string  $style       Either 'html' or 'markdown'.
     * @param bool    $without_cmd If the bot command should be included or not.
     */
    public function __construct(Message $message, string $style = 'html', bool $without_cmd = false)
    {
        $this->entities    = $message->getEntities();
        $this->text        = $message->getText($without_cmd);
        $this->style       = $style;
        $this->without_cmd = $without_cmd;
    }

    public function decode(): string
    {
        if (empty($this->entities)) {
            return $this->text;
        }

        $this->fixBotCommandEntity();

        // Reverse entities and start replacing bits from the back, to preserve offset positions.
        foreach (array_reverse($this->entities) as $entity) {
            $this->text = $this->decodeEntity($entity, $this->text);
        }

        return $this->text;
    }

    protected function fixBotCommandEntity(): void
    {
        // First entity would be the bot command, remove if necessary.
        $first_entity = reset($this->entities);
        if ($this->without_cmd && $first_entity->getType() === 'bot_command') {
            $this->offset_correction = ($first_entity->getLength() + 1);
            array_shift($this->entities);
        }
    }

    /**
     * @param MessageEntity $entity
     *
     * @return array
     */
    protected function getOffsetAndLength(MessageEntity $entity): array
    {
        static $text_byte_counts;

        if (!$text_byte_counts) {
            // https://www.php.net/manual/en/function.str-split.php#115703
            $str_split_unicode = preg_split('/(.)/us', $this->text, -1, PREG_SPLIT_NO_EMPTY | PREG_SPLIT_DELIM_CAPTURE);

            // Generate an array of UTF-16 encoded string lengths, which is necessary
            // to correct the offset and length values of special characters, like Emojis.
            $text_byte_counts = array_map(function ($char) {
                return strlen(mb_convert_encoding($char, 'UTF-16', 'UTF-8')) / 2;
            }, $str_split_unicode);
        }

        $offset = $entity->getOffset() - $this->offset_correction;
        $length = $entity->getLength();

        $offset += $offset - array_sum(array_slice($text_byte_counts, 0, $offset));
        $length += $length - array_sum(array_slice($text_byte_counts, $offset, $length));

        return [$offset, $length];
    }

    /**
     * @param string $style
     * @param string $type
     *
     * @return string
     */
    protected function getFiller(string $style, string $type): string
    {
        $fillers = [
            'html'     => [
                'text_mention' => '%1$s',
                'text_link'    => '%1$s',
                'bold'         => '%s',
                'italic'       => '%s',
                'code'         => '%s',
                'pre'          => '
%s
',
            ],
            'markdown' => [
                'text_mention' => '[%1$s](tg://user?id=%2$s)',
                'text_link'    => '[%1$s](%2$s)',
                'bold'         => '*%s*',
                'italic'       => '_%s_',
                'code'         => '`%s`',
                'pre'          => '```%s```',
            ],
        ];

        return $fillers[$style][$type] ?? '';
    }

    /**
     * Decode an entity into the passed string.
     *
     * @param MessageEntity $entity
     * @param string        $text
     *
     * @return string
     */
    private function decodeEntity(MessageEntity $entity, string $text): string
    {
        [$offset, $length] = $this->getOffsetAndLength($entity);

        $text_bit = $this->getTextBit($entity, $offset, $length);

        // Replace text bit.
        return mb_substr($text, 0, $offset) . $text_bit . mb_substr($text, $offset + $length);
    }

    /**
     * @param MessageEntity $entity
     * @param int           $offset
     * @param int           $length
     *
     * @return false|string
     */
    private function getTextBit(MessageEntity $entity, $offset, $length)
    {
        $type     = $entity->getType();
        $filler   = $this->getFiller($this->style, $type);
        $text_bit = mb_substr($this->text, $offset, $length);

        switch ($type) {
            case 'text_mention':
                $text_bit = sprintf($filler, $text_bit, $entity->getUser()->getId());
                break;
            case 'text_link':
                $text_bit = sprintf($filler, $text_bit, $entity->getUrl());
                break;
            case 'bold':
            case 'italic':
            case 'code':
            case 'pre':
                $text_bit = sprintf($filler, $text_bit);
                break;
            default:
                break;
        }

        return $text_bit;
    }
}

My latest experiment, which I'll pack into a small package when it works 100%.

Tested and do not see problems. A lot of emojis and different formatting works ok at the first glance.

All code snippets in this thread utterly fail on underline text inside spoilers.

authors: KilluaFein Oreolek f77 jacklul noplanman rsdsoft sefidpardazesh

repo: php-telegram-bot/core


text:
Fix issue #518 - Properly Save Chat IDs

Fixing #518 issue, happening because of PDO not able to save large ints.

Oops, wrong


text:
🛑 phpMyFAQ Homepage is down

In 9536aab, phpMyFAQ Homepage (https://www.phpmyfaq.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: phpMyFAQ Homepage is back up in 0702622.


text:
🛑 phpMyFAQ Password Hash Generator Tool is down

In a7c668b, phpMyFAQ Password Hash Generator Tool (https://password.phpmyfaq.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: phpMyFAQ Password Hash Generator Tool is back up in aef9800 after 4 minutes.


text:
🛑 phpMyFAQ Demo is down

In 8471f3c, phpMyFAQ Demo (https://demo.phpmyfaq.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: phpMyFAQ Demo is back up in 3822f46 after 12 minutes.


text:
mix format

mix formatしただけです
mix test.watchはもちろん通っています

tabが残っている

repo: piacerex/smallex


text:
npm publish

The latest version on npm is 0.4.0, the current version is 1.0.0.  Please npm publish to update npm.
https://www.npmjs.com/package/angular-fontawesome

👍

Sorry this took so long! Enjoy using the name @picardy/angular-fontawesome.

Alright, after some finagling, 1.0.0 should be available under the original name angular-fontawesome. Let us know if y'all have any issues pulling it down!

authors: TheSharpieOne neeckeloo tuckbick

repo: picardy/angular-fontawesome


text:
IOS - I don't want a white screen to appear when the screen is all the way down.

I don't want a white screen to appear when the screen is all the way down.
'disallowOverScroll: true'
I gave the above option, but it doesn't work.
Is there another way?

Same here

authors: dodatw woochans


text:
Trying to access array offset on value of type null

Hi guys,
first of: Thanks for creating and maintaining Pico. It's so great! Thanks!
Just one thing:  My error.log gets filled with a good amount of following lines:
[Sun Feb 09 13:11:30.006957 2020] [php7:notice] [pid 1200] [client a.b.c.d:59702] PHP Notice:  Trying to access array offset on value of type null in /path/to/pico/vendor/erusev/parsedown-extra/ParsedownExtra.php on line 338, referer: https://what.ever.tld
Is there something for me to fix (or at least as a workaround, to hide) it?
I've pico-2.1.1 installed.  If you need additional info, let me know.
--
Thomas

Unfortunately we currently got some issues with Parsedown in general, not sure about a solution yet... :unamused:
In the meantime you could exclude E_NOTICE errors from being logged. Add the following to your PHP config. I highly recommend doing this for Pico only!
error_reporting = E_ALL & ~E_DEPRECATED & ~E_STRICT & ~E_NOTICE

You can either add this to your virtual-host-specific php.ini or, alternatively, if you're running Apache with mod_php, you can also use .htaccess like the following:
php_value error_reporting "E_ALL & ~E_DEPRECATED & ~E_STRICT & ~E_NOTICE"

E_ALL & ~E_DEPRECATED & ~E_STRICT & ~E_NOTICE reads as: report (and possibly also log) all errors except E_DEPRECATED (i.e. deprecation warnings), E_STRICT (i.e. strict coding warnings) and E_NOTICE (i.e. coding notices; this is what you're seeing). Excluding E_DEPRECATED and E_STRICT is recommended in production in general.

Thanks for the quick reply.  I used the virtual-host approach in .htaccess.
Works perfect so far :-)

Labelling this as type: Bug and status: Resolved. I've just created Pico v3.0.0-alpha.1 resolving this issue by upgrading (resp. "downgrading" for Parsedown, even though that's not really true either, it's a weird situation...) Pico's dependencies. See https://github.com/picocms/Pico/issues/534#issuecomment-605638655 for more info. If you're going to try it out, please let me know about your experiences.

Hey PhrozenByte
I installed the 3.0.0-alpha1 on my Webspace and added the learn2 Theme, which includes the PageList-Plugin.
It works fine, but after installing the PicoEditor i get this message:
Notice: Trying to access array offset on value of type null in /www/htdocs/domain.de/plugins/PicoPagesList/PicoPagesList.php on line 67
But the Editor is still working.
Thanks for your great small CMS :-)

This is an issue with the plugin PicoPagesList and different from the issue mentioned above (what indeed is an issue with Pico's core resp. one of Pico's dependencies). Please let the plugin developer know about this (rather small, but nevertheless) issue. You should experience this issue no matter the Pico version (i.e. with both Pico 2.1 and Pico 3.0.0-alpha.1). Anyway, even though it's a different issue you can still follow the same instructions as above to hide it: https://github.com/picocms/Pico/issues/528#issuecomment-583852719

I will do so.
Thanks for your quick reply.

authors: KoljaL PhrozenByte ernibert

repo: picocms/Pico


text:
Feature request

Please dont get this wrong, pico is already good as it is, i'm just asking 2 QoL features i sincerely miss since switched from utorrent.
One is the ability to open/run file straight from the torrent window, like in utorrent where i torrented some animes and i can just double click the file in the "file tab list" and the video start playing.
The other one is the ability to rename file while in torrent dialogue option when you clicked torrent/magnet link, some animes are still in japanese characters and in utorrent i can just copypaste the english name inside the torrent dialogue window and the file names changed.
Please consider these 2 features, best regards to pico.

+1, I will switch from qBittorrent with high probability after these features

repo: picotorrent/picotorrent


text:
导航栏部分，在谷歌当中是左对齐，但是IE11中却是两端对齐

这部分的代码是怎样的呢？

和官网的Navbar是一样的，IE11打开官网也是一样的问题

已经在 v0.2.12 中修复。线上文档更新：https://picturepan2.github.io/spectre/layout.html#navbar。


text:
Can't create a new repo working

Testing with this repo:
https://github.com/amm554/MD_Mus_musculus/
When I double click on my assigned issue in SlicerMorphoDepot, this error is generated:
exouser@instance-55:/$ vglrun -d egl ~/Slicer/Slicer
libpng warning: iCCP: profile 'ICC Profile': 'CMYK': invalid ICC profile color space
libpng warning: iCCP: known incorrect sRGB profile
Switch to module:  "Welcome"
Switch to module:  "MorphoDepot"
('[{"number":1,"repository":{"name":"MD_Mus_musculus","nameWithOwner":"amm554/MD_Mus_musculus"},"title":"segment skull"},{"number":7,"repository":{"name":"MD_E15","nameWithOwner":"pieper/MD_E15"},"title":"Test MorphoDepot prototype"},{"number":46,"repository":{"name":"MorphoCloudWorkflow","nameWithOwner":"MorphoCloud/MorphoCloudWorkflow"},"title":"Screen resolution limitation in xfce4 "},{"number":45,"repository":{"name":"MorphoCloudWorkflow","nameWithOwner":"MorphoCloud/MorphoCloudWorkflow"},"title":"Missing packages to support R/devtools"},{"number":44,"repository":{"name":"MorphoCloudWorkflow","nameWithOwner":"MorphoCloud/MorphoCloudWorkflow"},"title":"Better openGl performance in CPU nodes"},{"number":31,"repository":{"name":"Morphology-analysis","nameWithOwner":"hdr-bgnn/Morphology-analysis"},"title":"color legend"}]\n', None)
('[{"name":"MD_E15"},{"name":"MorphoCloudWorkflow"},{"name":"fake_tutorial"},{"name":"MorphoCloudPortal"},{"name":"SlicerMorphR"},{"name":"Slicer"},{"name":"exosphere"},{"name":"pyRserve"},{"name":"nnmouse"},{"name":"scanner_stuff"},{"name":"mouse_CT_atlas"},{"name":"SlicerMorph_Rexamples"},{"name":"MONAILabel"},{"name":"Tutorials"},{"name":"demo"},{"name":"scanner_logs"},{"name":"dummy"},{"name":"ProjectWeek"},{"name":"fatih"},{"name":"rtd-tutorial"},{"name":"SlicerMorph"},{"name":"terms"},{"name":"blog"},{"name":"Scripts"},{"name":"test_images"},{"name":"bgnn_related"},{"name":"MMLLM"},{"name":"monai-deepedit"},{"name":"VolImportModule"},{"name":"SampleData"}]\n', None)
('', None)
("Cloning into '/home/exouser/Documents/MD_Mus_musculus'...\nremote: Repository not found.\nfatal: repository 'https://github.com/muratmaga/MD_Mus_musculus.git/' not found\nfailed to run git: exit status 128\n", None)
Traceback (most recent call last):
  File "/media/volume/MyData/SlicerMorphoDepot/MorphoDepot/MorphoDepot.py", line 209, in onItemDoubleClicked
    self.logic.loadIssue(issue, repoDirectory)
  File "/media/volume/MyData/SlicerMorphoDepot/MorphoDepot/MorphoDepot.py", line 273, in loadIssue
    self.localRepo = git.Repo(localDirectory)
  File "/home/exouser/Slicer/lib/Python/lib/python3.9/site-packages/git/repo/base.py", line 215, in __init__
    raise NoSuchPathError(epath)
git.exc.NoSuchPathError: /home/exouser/Documents/MD_Mus_musculus
QXcbConnection: XCB error: 3 (BadWindow), sequence: 1752, resource id: 14691971, major code: 40 (TranslateCoords), minor code: 0

It appears if made the fork my participant account (muratmaga), but not sure why it is generating the repository not found error?

OK, there must be a timing issue. because second time I tried it downloaded the volume. So perhaps we need to add some delay? Or an error catch (that it tries until the forked repo becomes available).

It all worked well (that is up to PR submission). I think the basics are sorted out. Doing without branch protection and not adding people as collaborators are going to simplify things...

It'll be hard to debug a timing issue, but I added a check that if this fails a dialog box will suggest retrying in a few seconds.

authors: muratmaga pieper

repo: pieper/SlicerMorphoDepot


text:
Fixed segfault when performing pier list sub command

Description
The latest update to prettytable-rs@0.10.0 resolves a critical issue that caused pier to crash when executing the pier list subcommand. Previously, using prettytable-rs@0.8.0 led to a segmentation fault, disrupting the functionality of pier for users. With this patch, users can now safely use the pier list command without encountering crashes.
This PR resolves #94
PS: All the test cases are working fine 👍🏼

@thekodeking thanks for the contribution and for fixing issue #94! 🥇

I'll merge this in and push a new Crates version asap.

authors: BenSchZA thekodeking

repo: pier-cli/pier


text:
🛑 www.pik.farm is down

In 57984fa, www.pik.farm (https://pik.farm) was down:

HTTP code: 0
Response time: 0 ms

Resolved: www.pik.farm is back up in 046728f after 30 minutes.

repo: pikfarm/PikfarmStatus


text:
🛑 Blog URL is down

In 4963cb2, Blog URL (http://blog.pik.farm) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Blog URL is back up in 4293db1 after 30 minutes.


text:
No mention of FIDO2 passkeys as a passwordless authentication mechanism

FIDO2 Passkey is the new way to authenticate users in Identity Providers:
Apple
Google
Microsoft
Implementation should follow WebAuthN guidelines: https://webauthn.io/

https://thecopenhagenbook.com/webauthn
?

my bad

authors: identitymonk pilcrowonpaper

repo: pilcrowonpaper/copenhagen


text:
Travis CI test failures: undefined: pql.GoCover_0

Getting some odd test failures in Travis CI on the Go master branch. Seems related to:
https://github.com/golang/go/issues/22679
Expected behavior
Travis CI passes tests on master.
Actual behavior
travis@travis-job-pilosa-pilosa-98558692:~/gopath/src/github.com/pilosa/pilosa$ $HOME/gopath/bin/goveralls -service=travis-ci -ignore "internal/internal.go,internal/public.pb.go,internal/private.pb.go"
exit status 2: warning: no packages being tested depend on matches for pattern github.com/pilosa/pilosa/cmd
warning: no packages being tested depend on matches for pattern github.com/pilosa/pilosa/cmd/pilosa
warning: no packages being tested depend on matches for pattern github.com/pilosa/pilosa/ctl
warning: no packages being tested depend on matches for pattern github.com/pilosa/pilosa/gossip
warning: no packages being tested depend on matches for pattern github.com/pilosa/pilosa/server
warning: no packages being tested depend on matches for pattern github.com/pilosa/pilosa/statsd
warning: no packages being tested depend on matches for pattern github.com/pilosa/pilosa/test
# github.com/pilosa/pilosa (testmain)
/tmp/go-build684054744/b001/_testmain.go:449:59: undefined: pql.GoCover_5
/tmp/go-build684054744/b001/_testmain.go:451:62: undefined: pql.GoCover_6
/tmp/go-build684054744/b001/_testmain.go:453:63: undefined: pql.GoCover_7
/tmp/go-build684054744/b001/_testmain.go:455:61: undefined: pql.GoCover_8
FAIL    github.com/pilosa/pilosa [build failed]

Edit: I was able to reproduce with go test:
travis@travis-job-pilosa-pilosa-98558692:~/gopath/src/github.com/pilosa/pilosa$ go test -v -covermode=count -coverprofile=coverage.out github.com/pilosa/pilosa/pql
# github.com/pilosa/pilosa/pql (testmain)
/tmp/go-build565279668/b001/_testmain.go:61:59: undefined: pql.GoCover_0
/tmp/go-build565279668/b001/_testmain.go:63:59: undefined: pql.GoCover_1
/tmp/go-build565279668/b001/_testmain.go:65:62: undefined: pql.GoCover_2
/tmp/go-build565279668/b001/_testmain.go:67:63: undefined: pql.GoCover_3
FAIL    github.com/pilosa/pilosa/pql [build failed]
travis@travis-job-pilosa-pilosa-98558692:~/gopath/src/github.com/pilosa/pilosa$ go version
go version devel +fa1f52c5f6 Tue Nov 14 05:39:45 2017 +0000 linux/amd64

Steps to reproduce the behavior
Start travis-ci.com in debug mode, ssh to host, run make vendor, followed by the test command:
$HOME/gopath/bin/goveralls -service=travis-ci -ignore "internal/internal.go,internal/public.pb.go,internal/private.pb.go"

Information about your environment (OS/architecture, CPU, RAM, cluster/solo, configuration, etc.)
Travis CI
travis@travis-job-pilosa-pilosa-98558692:~/gopath/src/github.com/pilosa/pilosa$ go version
go version devel +fa1f52c5f6 Tue Nov 14 05:39:45 2017 +0000 linux/amd64

Let's wait on this one a bit and see if the go team fixes this.

authors: codysoyland travisturner

repo: pilosa/pilosa


text:
Bitly doesn't work with 2 factor auth

Ref: Conversation #4357 / Kevin

Should be OK now as using OAuth

repo: pilotmoon/PopClip-Extensions


text:
Add CMake gitignore.

Adds the github provided CMake ignore list to the bottom of .gitignore.

Pretty sure all cmake output should be confined to its build.* directories, but it can't hurt to have these anyway to guard against this stuff creeping in! Thank you!

authors: Gadgetoid shane-powell


text:
Awesome philosophy

This module has an awesome philosophy - love it.
I stopped installing npm modules a good while ago, trying to make do with what the runtime has, even if lacking a bit of bells and whistles in favor of zero-dependency, super fast builds and boots. It's awesome.
These are the kinds of modules that I want to install. tries to make do with what's there, 0 bloat, known APIs, gets the job done, cya.
The only thing I (might) do different is drop support for older devices/browsers if it makes a difference in file/sizes maintenance and be alert to feature creep -  but I guess you guys know better.
Just dropping buy, no issues. Thanks.

:heart: Thanks @nicholaswmin! :smile:

authors: nicholaswmin pimterry

repo: pimterry/loglevel


text:
[Feature] Obtain F score directly from the chat engine

Is this your first time submitting a feature request?

[X] I have searched the existing issues, and I could not find an existing issue for this feature
[X] I am requesting a straightforward extension of existing functionality

Describe the feature
I am able to get the F score using the knowledge base query object:
query_result = knowledge_base.query([Query(text=query)]) f_score = f"{query_result[0].documents[0].score * 100:.2f}%"
However, I cannot do the same when I use the chat engine directly because the following response object has no score component.
   response = chat_engine.chat(         messages=[UserMessage(content=query)],     )
Would appreciate it if we could get the F score in the response body of the chat engine as well.
Describe alternatives you've considered
The alternative is to go directly to the knowledge base query method, but that misses out on the benefits that the context engine and chat engine provide.
Who will this benefit?
Everyone who wants to understand the F score of their query to benchmark performance and approximate confidence level in the output.
Are you interested in contributing this feature?
Sure, but would appreciate guidance (pair programming maybe?)
Anything else?
No response

hi @NB-123
How do you see the score represented? when you are using knowledge base directly, you basically have the documents the returned from the search, hence you get score for each, with the "chat" you are getting the model response, then what should the score be representing? is it the score of the documents that returned? or the ones the model used (assuming we know exactly which)
what would be ideal request -> response in your mind?

repo: pinecone-io/canopy


text:
Example for posting an album

Please follow the guide below

Issues submitted without this template format will be ignored.
Rlease read them carefully and answer completely.
Do not post screenshots of error messages or code.
Put an x into all the boxes [ ] relevant to your issue (==> [x] no spaces).
Use the Preview tab to see how your issue will actually look like.
Issues about reverse engineering is out of scope and will be closed without response.
Any mention of spam-like actions or spam-related tools/libs/etc is strictly not allowed.

Before submitting an issue, make sure you have:

[ ] Updated to the lastest version v1.6.0
[ ] Read the README and docs
[ ] Searched the bugtracker for similar issues including closed ones
[ ] Reviewed the sample code in tests and examples

Which client are you using?

[x ] app (instagram_private_api/)
[x ] web (instagram_web_api/)

Describe your Question/
Can someone show me how I can post an album? Is there an example? Would be very happy if someone could help me out
Best
sali

Please review the documentation before submitting an issue.

Before submitting an issue, make sure you have:

[ ] Updated to the lastest version v1.6.0
[ ] Read the README and docs
[ ] Searched the bugtracker for similar issues including closed ones
[ ] Reviewed the sample code in tests and examples

authors: SaliZumberi ping


text:
topsql: introduce sql exec count and sql duration

Signed-off-by: mornyx mornyx.z@gmail.com

What is changed and how it works?

Add two metrics: sql_exec_count and sql_duration.
Implement write and query for new metrics.
Enhance integration tests of TopSQL.

Related PR

https://github.com/pingcap/tipb/pull/250

PTAL, Thanks~
/cc @crazycs520 @zhongzc @breeswish

Writing and reading for ExecCount and DurationSum are supported now, we need to support Duration on this basis. cc @zhongzc

/lgtm

/merge

authors: mornyx zhongzc

repo: pingcap/ng-monitoring


text:
parser: add IsTrueWithKeepNull flag

What problem does this PR solve?
https://github.com/pingcap/tidb/pull/19639
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes

Need to cherry-pick to the release branch 3.0,4.0

LGTM

repo: pingcap/parser


text:
Ready is Ready-Only, should only have getters.

The Ready struct should not allow values to be mutated, it should only provide immutable getters.
https://github.com/pingcap/raft-rs/blob/1e0741a9aea3b242d33dadc46245ad611e7e7aa4/src/raw_node.rs#L84-L121
It's possible to do this by writing functions that return immutable borrows of the contained values, or using a crate like https://crates.io/crates/getset which will write them for you.

After adding getter, shall we remove pub modifier? It would be a breaking change then.

@siddontang
ok. I'll working on this.

authors: Hoverbear Ryan-Git

repo: pingcap/raft-rs


text:
The return type of plus, minus, and multiply is different from tidb

TiFlash:
https://github.com/pingcap/tics/blob/3893c2ac05f57d9c7542755c1673462c4f6c6d78/dbms/src/DataTypes/NumberTraits.h#L72-L75
MySQL doc:

In the case of -, +, and *, the result is calculated with BIGINT (64-bit) precision if both operands are integers.
If both operands are integers and any of them are unsigned, the result is an unsigned integer. For subtraction, if the NO_UNSIGNED_SUBTRACTION SQL mode is enabled, the result is signed even if any operand is unsigned.
If any of the operands of a +, -, /, *, % is a real or string value, the precision of the result is the precision of the operand with the maximum precision.

operand_1
operand_2
TiDB
TiFlash

signed int8
unsigned int8
unsigned int64
signed int16

also TiFlash has no overflow check for int plus/minus/multiply.

@windtalker does this issue still exist?

Yes, I think it still exists.

Yes, I think it still exists.

It could be another low-hanging fruits.

repo: pingcap/tiflash


text:
cherry-pick simple protocol to release-7.5 branch

Cherry-pick simple protocol to release-7.5 to meet user requirement.

[x] Cherrypick schemaStorage refactor
[x] Cherrypick Simple Protocol encoder and decoder
[x] Cherrypick Simple Protocol related configuration
[ ] Cherrypick Bootstrap Function logic
[ ] Cherrypick row checksum function changes
[ ] Cherrypick simple protocol integration test cases

Finish by #10898

repo: pingcap/tiflow


text:
filter (ticdc): add dml expression filter

What problem does this PR solve?

Issue Number: ref #6160
What is changed and how it works?
Add strcut dmlExprFilter to pkg/filter, it is a part of cdc row filter.
Note: This PR will not change any behavior of cdc, it only:

Add strcut dmlExprFilter.
Add a filter config struct EventFilterRule to pkg/config/filter.go.
Add a field RowChangedDatums to model.RowChangedEvent to facilitate dmlExprFilter's function.

Check List
Tests

Unit test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note

None

Codecov Report

Merging #6215 (cc71266) into master (ef587e6) will decrease coverage by 0.3404%.
The diff coverage is 63.1546%.

Flag
Coverage Δ

cdc
63.9396% <66.7506%> (-0.7450%)
:arrow_down:

dm
51.8997% <49.6350%> (+0.0106%)
:arrow_up:

engine
62.5211% <54.3478%> (-0.0129%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #6215        +/-   ##
================================================
- Coverage   58.4193%   58.0788%   -0.3405%
================================================
  Files           711        714         +3
  Lines         84205      83681       -524
================================================
- Hits          49192      48601       -591
- Misses        30540      30711       +171
+ Partials       4473       4369       -104

/merge

/run-kafka-tests

/run-verify
/run-kafka-integration-tests

/run-verify
/run-integration-yesys

/run-integration-tests

authors: asddongmen codecov-commenter


text:
Removes the custom dispatcher function

Removed this as a preference for the autogenerated one from ACTION and on_notify annotations added in the header.
I can create a separate PR for the singleton constructor/destructor thing that I mentioned earlier

Can you remove the second commit from this pull request please, so that I can merge the original one.
I'm not sure about the constructor / destructor changes yet.

authors: dallasjohnson jona-wilmsmann

repo: pinknetworkx/atomicassets-contract


text:
Does thrift plugin support custom thrift transport？

Hi team：
I have added the pinpoint agent to my thrift application, but I can only get part of trace info like undering image. There is no thrift server trace info. My application use custom thrift transports, I want to know whether custom transports affects pinpoint thrift plugin trace thrift server? And if yes, How could I extend the thrift plugin to support custom thrift component?

Pinpoint cannot trace custom thrift transport.
If you need tracking, please refer to the plugin development guide.
https://pinpoint-apm.gitbook.io/pinpoint/documents/plugin-dev-guide

Thanks for your response.
I hava referred to the plugin developer guide, and successesfully got the result as shown below, I wanna know whether the result is correct, because in my application, event “readMessageend“ should be followed by further method and thrift calls， but here are no further trace data。

There doesn't seem to be any problem.
https://github.com/pinpoint-apm/pinpoint/tree/master/plugins/user#compatibility-setting
If you want to trace your business logic, you might want to refer to the setup above.

repo: pinpoint-apm/pinpoint


text:
Unit tests don't pass on Linux

After cloning and running yarn install, I tried running the tests and about half of them fail:
> yarn run test
yarn run v1.16.0
$ yarn run build
$ rm -rf build && mkdir build && babel src --out-dir build
src/Client.js -> build/Client.js
src/LintRunner.js -> build/LintRunner.js
src/LintWorker.js -> build/LintWorker.js
src/Server.js -> build/Server.js
src/cli.js -> build/cli.js
src/cliUtils.js -> build/cliUtils.js
src/commands/check.js -> build/commands/check.js
src/commands/connect.js -> build/commands/connect.js
src/commands/index.js -> build/commands/index.js
src/commands/stop.js -> build/commands/stop.js
src/startServer.js -> build/startServer.js
src/util.js -> build/util.js
$ jest tests --runInBand
 FAIL  tests/file-deletion/__tests__/file-deletion.test.js
  ● Properly updates the cache upon deleting a file

    expect(received).toBeDefined()

    Expected value to be defined, instead received
      undefined

      at Object.<anonymous> (tests/file-deletion/__tests__/file-deletion.test.js:36:25)
          at new Promise (<anonymous>)
      at Promise.resolve.then.el (node_modules/p-map/index.js:42:16)

 FAIL  tests/failure/__tests__/failure.test.js
  ● Properly lints and returns errors with server

    expect(received).toBeDefined()

    Expected value to be defined, instead received
      undefined

      at Object.<anonymous> (tests/failure/__tests__/failure.test.js:26:25)
          at new Promise (<anonymous>)
      at Promise.resolve.then.el (node_modules/p-map/index.js:42:16)

 FAIL  tests/warning/__tests__/warning.test.js
  ● Properly lints and returns errors with server

    expect(received).toEqual(expected)

    Expected value to equal:
      StringContaining "warning  Unexpected var, use let or const instead  no-var"
    Received:
      ""

      at Object.<anonymous> (tests/warning/__tests__/warning.test.js:27:37)
          at new Promise (<anonymous>)
      at Promise.resolve.then.el (node_modules/p-map/index.js:42:16)

 FAIL  tests/subfolders/__tests__/subfolders.test.js
  ● Properly lints and returns errors with server

    expect(received).toBeDefined()

    Expected value to be defined, instead received
      undefined

      at Object.<anonymous> (tests/subfolders/__tests__/subfolders.test.js:26:25)
          at new Promise (<anonymous>)
      at Promise.resolve.then.el (node_modules/p-map/index.js:42:16)

 FAIL  tests/suppress-warnings/__tests__/suppress-warnings.test.js
  ● Properly lints and returns errors with server

    expect(received).toBeDefined()

    Expected value to be defined, instead received
      undefined

      at Object.<anonymous> (tests/suppress-warnings/__tests__/suppress-warnings.test.js:19:20)
          at new Promise (<anonymous>)
      at Promise.resolve.then.el (node_modules/p-map/index.js:42:16)

 FAIL  tests/fail-on-warning/__tests__/fail-on-warning.test.js
  ● Properly lints and returns errors with server

    expect(received).toBeDefined()

    Expected value to be defined, instead received
      undefined

      at Object.<anonymous> (tests/fail-on-warning/__tests__/fail-on-warning.test.js:17:25)
          at new Promise (<anonymous>)
      at Promise.resolve.then.el (node_modules/p-map/index.js:42:16)

 FAIL  tests/success/__tests__/success.test.js
  ● Properly lints and returns errors with server

    expect(received).toBeDefined()

    Expected value to be defined, instead received
      undefined

      at Object.<anonymous> (tests/success/__tests__/success.test.js:26:20)
          at new Promise (<anonymous>)
      at Promise.resolve.then.el (node_modules/p-map/index.js:42:16)

 FAIL  tests/stop/__tests__/stop.test.js
  ● Server is properly killed after the stop command

    expect(received).toBeDefined()

    Expected value to be defined, instead received
      undefined

      at Object.<anonymous> (tests/stop/__tests__/stop.test.js:25:20)
          at new Promise (<anonymous>)
      at Promise.resolve.then.el (node_modules/p-map/index.js:42:16)

Unable to find `.esprintrc` file. Exiting...
 PASS  tests/noconfig/__tests__/noconfig.test.js

Test Suites: 8 failed, 1 passed, 9 total
Tests:       8 failed, 7 passed, 15 total
Snapshots:   0 total
Time:        17.438s
Ran all test suites matching "tests".
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Hey @kaiyoma, what version of Node are you running?
yarn run test currently results in some tests failing when run under Node v10+ due to an outdated sub-dependency (weak).
This is something I plan to address along with other outdated dependencies in an upcoming PR.
In the meantime, yarn run test should pass if run with Node 9. I'm not aware of any Linux-specific issue. But thanks for reporting and feel free to followup if you find there is an issue other than with the Node version.

We run Node 10.16 in our project. I've also encountered test failures on Windows, so you're probably right that nothing here is specific to Linux.
It would be really great if you could address outdated dependencies. I filed https://github.com/pinterest/esprint/issues/92 yesterday and while working on https://github.com/pinterest/esprint/pull/94 I noticed that a lot of dependencies are out of date. Up until you released the new version the other day, my team was maintaining a local fork of the project to fix all these problems, but clearly it would be much better if all these improvements went into mainline.
We find esprint really useful, but the project feels a bit dilapidated at the moment and could definitely use some love and attention to bring it into 2019. Let me know if you need any more help/info.
Off the top of my head:

Unit tests fail on most/all operating systems
Dependencies are very outdated
yarn audit reports security vulnerabilities
Travis builds are failing
Lots of PRs are stuck in limbo

We upgraded all our dependencies and validated the tests now pass on Ubuntu and MacOS. Please retry on the latest version of esprint.

Passing on Linux, but still failing pretty badly on Windows:
yarn run v1.22.5
$ yarn run build
$ rm -rf build && mkdir build && babel src --out-dir build
Successfully compiled 12 files with Babel (1481ms).
$ jest tests --runInBand
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
 FAIL  tests/file-deletion/__tests__/file-deletion.test.js (10.14 s)
  ● Properly updates the cache upon deleting a file

    TypeError: Cannot read property 'stdout' of undefined

      40 |   const newResults = runEsprint(path.join(__dirname, '..'));
      41 |   const newExpectedResults = expect.stringContaining('');
    > 42 |   expect(newResults.error.stdout.toString()).toEqual(newExpectedResults);
         |                           ^
      43 | });

      at Object.<anonymous> (tests/file-deletion/__tests__/file-deletion.test.js:42:27)

'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
 FAIL  tests/fix/__tests__/fix.test.js (7.275 s)
  ● Fixes lint errors with server

    expect(received).toBeDefined()

    Received: undefined

      32 |   expect(results.error).toBeUndefined();
      33 |   expect(fixtureContents).not.toEqual(fs.readFileSync(fixture, utf8));
    > 34 |   expect(getPid()).toBeDefined();
         |                    ^
      35 | });
      36 |
      37 | test('Fixes lint errors without server', () => {

      at Object.<anonymous> (tests/fix/__tests__/fix.test.js:34:20)

'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
 FAIL  tests/failure/__tests__/failure.test.js (6.24 s)
  ● Properly lints and returns errors with server

    expect(received).toBeDefined()

    Received: undefined

      26 |   expect(results.error).toBeDefined();
      27 |   expect(results.error.stdout.toString()).toEqual(expectedError);
    > 28 |   expect(getPid()).toBeDefined();
         |                    ^
      29 | });
      30 |
      31 | test('Properly lints and returns errors without server', () => {

      at Object.<anonymous> (tests/failure/__tests__/failure.test.js:28:20)

'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
 FAIL  tests/warning/__tests__/warning.test.js (6.268 s)
  ● Properly lints and returns errors with server

    expect(received).toBeDefined()

    Received: undefined

      26 |   expect(results.error).toBeUndefined();
      27 |   expect(results.stdout.toString()).toEqual(expectedError);
    > 28 |   expect(getPid()).toBeDefined();
         |                    ^
      29 | });
      30 |
      31 | test('Properly lints and returns errors without server', () => {

      at Object.<anonymous> (tests/warning/__tests__/warning.test.js:28:20)

'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
 FAIL  tests/subfolders/__tests__/subfolders.test.js (6.403 s)
  ● Properly lints and returns errors with server

    expect(received).toBeDefined()

    Received: undefined

      26 |   expect(results.error).toBeDefined();
      27 |   expect(results.error.stdout.toString()).toEqual(expectedError);
    > 28 |   expect(getPid()).toBeDefined();
         |                    ^
      29 | });
      30 |
      31 | test('Properly lints and returns errors without server', () => {

      at Object.<anonymous> (tests/subfolders/__tests__/subfolders.test.js:28:20)

'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
 FAIL  tests/suppress-warnings/__tests__/suppress-warnings.test.js (6.195 s)
  ● Properly lints and returns errors with server

    expect(received).toBeDefined()

    Received: undefined

      17 |   expect(results.error).toBeUndefined();
      18 |   expect(results.stdout.toString()).not.toEqual(unexpectedError);
    > 19 |   expect(getPid()).toBeDefined();
         |                    ^
      20 | });
      21 |
      22 | test('Properly lints and returns errors without server', () => {

      at Object.<anonymous> (tests/suppress-warnings/__tests__/suppress-warnings.test.js:19:20)

'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
 FAIL  tests/fail-on-warning/__tests__/fail-on-warning.test.js (6.549 s)
  ● Properly lints and returns errors with server

    expect(received).toBeDefined()

    Received: undefined

      17 |   expect(results.error).toBeDefined();
      18 |   expect(results.error.stdout.toString()).toEqual(expectedError);
    > 19 |   expect(getPid()).toBeDefined();
         |                    ^
      20 | });
      21 |
      22 | test('Properly lints and returns errors without server', () => {

      at Object.<anonymous> (tests/fail-on-warning/__tests__/fail-on-warning.test.js:19:20)

'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
 FAIL  tests/ignored/__tests__/ignored.test.js
  ● Properly lints and returns errors with server

    expect(received).toBeDefined()

    Received: undefined

      24 |   const results = runEsprint(path.join(__dirname, '..'));
      25 |   expect(results.error).not.toBeDefined();
    > 26 |   expect(getPid()).toBeDefined();
         |                    ^
      27 | });
      28 |
      29 | test('Properly lints and returns errors without server', () => {

      at Object.<anonymous> (tests/ignored/__tests__/ignored.test.js:26:20)

'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
 FAIL  tests/success/__tests__/success.test.js (6.108 s)
  ● Properly lints and returns errors with server

    expect(received).toBeDefined()

    Received: undefined

      24 |   const results = runEsprint(path.join(__dirname, '..'));
      25 |   expect(results.error).toBeUndefined();
    > 26 |   expect(getPid()).toBeDefined();
         |                    ^
      27 | });
      28 |
      29 | test('Properly lints and returns errors without server', () => {

      at Object.<anonymous> (tests/success/__tests__/success.test.js:26:20)

'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
'lsof' is not recognized as an internal or external command,
operable program or batch file.
 FAIL  tests/stop/__tests__/stop.test.js
  ● Server is properly killed after the stop command

    expect(received).toBeDefined()

    Received: undefined

      23 | test('Server is properly killed after the stop command', () => {
      24 |   runEsprint(path.join(__dirname, '..'));
    > 25 |   expect(getPid()).toBeDefined();
         |                    ^
      26 |   runEsprint(path.join(__dirname, '..'), 'stop');
      27 |   expect(getPid()).toBeUndefined();
      28 | });

      at Object.<anonymous> (tests/stop/__tests__/stop.test.js:25:20)

 RUNS  tests/noconfig/__tests__/noconfig.test.js

(the tests seem to hang at this point)

authors: christianvuerings fvgs kaiyoma

repo: pinterest/esprint


text:
Which Go compiler versions should Pion support?

This issue was 'inspired' by https://github.com/pion/transport/pull/200 created by @jech which has the effect of broadening the range of Go compiler versions that Pion can be built with. I felt the question of Go compiler support is best answered with substantial community input as it impacts past and future contributors to Pion, as well as third-party software that uses Pion as a dependency.
The core question is: which versions of the Go toolchain should Pion support? Right now there is no clear answer (i.e. nothing is stated explicitly in the docs), and the Pion codebase itself offers a number of contradictory answers:

Pion's CI system tests builds only against 1.17 and 1.18. This is consistent with Go's own support for the current major version, plus the last version, of the toolchain. This means that, in practice, committed changes are only guaranteed to work on 1.17 and 1.18.
go.mod in the main repo targets go 1.13. Some of the other packages e.g. pion/transport target go 1.12 in the go.mod.
Recent changes e.g. inclusion of optimised assembly for crypto functions currently use syntax only available in 1.16 onwards.

The point was raised that the Go toolchain advances faster than some Linux distros are updated, so it is possible/likely that people are developing primary with Go toolchain releases that are now unsupported/EOL.
Some possible options:

We synchronize Pion's support for the Go toolchain with Go's own support schedule, i.e. current version + last major version only. This is effectively what's done by Pion's current CI system, and so this 'change' is simply to state that 1.17 and 1.18 are the only supported Go toolchain releases. We can choose to enforce this in go.mod or not do so, and state that Pion may compile under earlier versions of Go but we do not test or support such usage.
We make a decision to broaden support to e.g. current + last + last-but-one + last-but-two. If we do this we should change Pion's CI process to also build and test under 1.16 and 1.15. This might reveal breakages either due to Go features in use in the codebase that were not supported in 1.15/1.16, or due to compiler bugs whose fixes were not marked for backport. This might be fine, or might open a 'can of worms' - it is hard to tell.

What are people's views on this?

Until recently, Pion has been using a system that apparently works for everyone:

people would submit improvements to Pion, without going out of their way to ensure it works with older copilers;
occasionally, somebody would notice that Pion no longer works on a version of Go that they still care about, and submit a fix;
occasionally, we'd remove obsolete code when we're reasonably sure that nobody cares any longer.

Here's an example of a perfectly friendly exchange fixing breakage on an older version: https://github.com/pion/ice/pull/361.
This system has been working well, and has allowed people who care about older compilers to use a recent version of Pion, which is good for the project since it gets timely testing.  I don't understand why you have suddenly decided to replace it with something different, that is obviously causing pointless friction and that would cause me to stick to an older version of Pion.

@jech - I'm not sure I understand.

I don't understand why you have suddenly decided to replace it with something different

This is exactly what I am not doing. Per my post in pion/transport I do not think that any single individual (including myself) should be making unilateral decisions on versioning policy, because these decisions potentially have wide community impact. That's why I am asking for broader views (beyond me and you), so that whatever the consensus is, we can codify it so there is no ambiguity, and both future contributors and Pion users know what compilers we support.
My point is not that anything done to date is wrong, rather, because we don't have anything written down on what this project's policy is on compiler support, there is the ongoing risk that two people disagree on what the policy actually is. What is happening now is a good example of what I want to avoid in the future. So, I am asking for broader views on what our policy should be, so we can write it down, and then there is no ambiguity. I am not 'replacing it with something different', and in fact I do not have any views on what the policy should be. I would hope this is clear from my above post when I presented a number of different options, without expressing any preference myself. My sole wish is that, as a community, we agree 'a view' and then write it down, so there is no ambiguity.
@Sean-Der, @davidzhao and others - I would appreciate your views.

@adriancable I understand the wish to have an agreement as a community on what compilers Pion supports and I think that what @jech described above worked well in the past. One problem I see with this approach is that it is somewhat unclear when contributors are allowed to use new language features, which most of the time is not a big issue, but might be one soon, now that both of the last supported compiler versions support generics. I don't know how much they are actually used, so maybe that is nothing to worry about, but in the worst case, I think we may lose contributors by requiring them to implement patches without using new language features.
I think we should certainly avoid situations such as in pion/transport where the code is incompatible with what is declared in go.mod.

@mengelbart - thanks for this - I don't have any issue with @jech's proposal for a system at all, but I think we (A) need to reconcile it with what happens on the contributor/CI side, which is currently that we only build and test for 1.17 and 1.18 (this may be 1.18 and 1.19 by now), and (B) write it down. My issue is not with any specific policy but with 'folklore' policies in general that are not written down. This just causes confusion, unless you have been following how things work at Pion for a long time. We shouldn't make 'learning folklore' a requirement to contribute to Pion.
I absolutely agree that code should not use language features that are not supported by what is declared in go.mod. (In the interest of transparency, I am guilty of this in at least one place in pion/transport.) My uncertainty is that there are 2 ways to fix this - remove the language features, or bump the version in go.mod. The former is what @jech would like and appears in line with the 'folklore' policy in effect. The latter would enable us to sync up the module versions with what we actually support, i.e. what the Pion CI system builds and tests against (1.17/1.18).
If we are happy with the policy that @jech described then please let's write it down! We also need to make it consistent with what the CI system does. Some possible wording we could add to the README that might achieve both things:

Pion aims to match Go's own policies on toolchain version support, that is, the current and previous major versions of the compiler. At the time of writing this means that Pion supports Go versions 1.18 and 1.17 (probably 1.19 and 1.18 by now). Pion's CI system builds and tests against these Go versions.
We recognize that older versions of Go are still in use by developers. We cannot guarantee compatibility with EOL versions of the Go toolchain, because we do not build or test against these compiler versions. However, if you do have an issue building or running with an EOL compiler version and have a fix for this, we are open to accepting PRs (provided that they do not break compatibility with supported versions of the toolchain).

Thoughts?

Repeating parts of what I just wrote on pion/transport#200:
I'm running Galène (which depends on this project) as a production server on Debian stable which ships Go 1.15. Since this is a production environment I'd very much prefer to stick with the Go version it was shipped with (which has full security support) rather than using the one from backports (which may or may not get security updates).
If there's significant effort required to continue supporting a Go version for the lifetime of Debian stable (usually about 2 years) I can understand you'd prefer not to. I'll update to Go 1.18 from backports in that case. But at the very least the build should fail in a way that makes it obvious the reason for the failure is that I need a more recent Go version.

Jumping into this late. Been thinking about this one for a bit.
I support having an official "version policy" around Go version support. My reasons are:

set clarity and expectations for contributors around compatibility expectations
stating what we won't support will reduce the perceived difficulty of contributing
it'd be hugely beneficial to adopt a version where newer features like generics could be used. we don't want Pion to be a project to be forever stuck on 1.15.

It's important to make the distinction that this is a developer-impacting decision that does not impact the end-users. As with all Go binaries, there are no dependencies on having a particular toolchain installed for end-users.
What are reasons for folks that develop with Pion to keep using Go 1.15/1.16?

@davidzhao - one of the reasons I have heard is that Linux distros don't tend to update their Go toolchain as often as they could/should.
I'm not sure how much of a practical block this really is, though. The Go toolchain has been designed to be simple to install and update (copy and paste one command line into the terminal). @jech - do you know from Galene users why some people don't want to use more modern / supported versions of Go?

I'm sorry, but I don't have either the time or the inclination to have this discussion.
In the meantime, however, compilation under gccgo is still broken.  So please either apply pion/transport#200 or provide a different but tested fix yourself

@jech - that's a shame. This discussion started, I believe, as a consequence of Galene users being frustrated by the inability to compile under older versions. If you 'drop out' at this point and we lose an understanding of this data point, it makes it harder to make good decisions (= more likely we will continue in this holding pattern for longer than we need to).

This discussion started, I believe, as a consequence of Galene users...

I'm pretty sure that's not the case.  You started this discussion single-handed, thus creating a problem where there was none.

@jech - it's actually the opposite. By actually defining a toolchain support policy we will save people a lot of work in the future (e.g. writing code using generics, and then being told after the fact it isn't allowed). If anyone else feels that I am causing extra work for everyone, they haven't yet said so, so I will disregard that particular comment for the time being, but am always open to hear views from others.

This was discussed at the Pion quarterly meeting in Slack. Consensus was that 1.19 would be an acceptable upgrade

1.19 is what Debian stable is at. This seems to be the platform where users are stuck on older versions
1.19 does give us some features that people are excited for

@edaniels If you are interested want to make https://github.com/pion/.goassets/blob/master/scripts/lint-go-mod-version.sh fail the build. I can help make the PRs across all the repos if you like!
Happy to take the issue myself, but this seemed like something you were passionate about

Yup I'll give it a stab. May need help but I'll lyk

Done! go.mod version is 1.19 across all the repos.
Thank you so much for doing this @edaniels !

Woo! Tag teamed!

authors: Sean-Der adriancable davidzhao edaniels jech mengelbart silbe

repo: pion/webrtc


text:
Update the global configuration location and fix 2 typos in readme

2 refinements on README.md:

Remove the invalid path segment '/project' from the global configuration location: home/project => home.
And fix 2 typos in it.

Thanks :heart:
Unfortunately I have bad news, this library hasn't been maintained for couple years and is terribly out of sync(some things may work but I would expect some apis to be broken). I'm working on bringing it up to speed with latest api. If you have time and want to take a look at implementing any apis calls that would be sweet.

I think the lib is very useful and convenient(👍 ) for me (and others)  to easily access github from cli.
And currently I am so interested in Ruby related development, so I am sure I will be glad that I will take a chance to be involved in the lib development.
Is there any roadmap or the api list that we need to update or implement? I would take some as the starting point to contribute to that.
I just met with the lib yesterday and didn't try many commands, so I will take a full view and understanding of the lib this week, and I will try to find something broken to fix that.

Sounds fantastic!
The library relies on the github_api gem which has majority of official GitHub api implemented see. I will update this library to use v0.14.0 that was released few days ago.
As a way of cross referencing I use the official GitHub api docs which will show you possible parameters, response types etc...
All the current commands can be found here. And the best one to start with would be probably the search command as this is broken for people reporting problems on the issue tracker see
Everything that is current is in the master and I will not step on your tones changing api as I have quite a lot of things to change in the library regarding all the plumbing.
I will add chat client tomorrow so that you can catch me there as well in case you have any questions.

Great, thanks for the useful info. I will take time to go through the related links when I'm off work today and reach you back if I have questions then.
I will definitely take the search issue and try to fix this this weekend.

authors: piotrmurach zhenglaizhang


text:
Bump web dependencies

What this PR does / why we need it:
Bump outdated web dependencies
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

🚀 🚀 🚀
/approve

/changelog

authors: cakecatz khanhtc1202 nghialv

repo: pipe-cd/pipe


text:
Remove metrics arg from service manifest used to install Piped on Cloud Run

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/changelog


text:
support enable piped to add asdf plugin with git repo

What would you like to be added:
enable piped to add asdf plugin with git repo
externalTools:
  - package: "aws-sam-cli"
    version: "1.77.0"

externalTools:
  - asdfPluginName: aws-sam-cli
    asdfPluginRepo: https://github.com/amrox/asdf-pyapp.git
    version: 1.77.0

Why is this needed:

Closed due to asdf removal

repo: pipe-cd/pipecd


text:
Rename the title of Running Version column to Artifact Versions

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

Nice catch!
/approve

authors: knanao nghialv


text:
Remove CreateContTransformStmt

We're leaving this in for now because it's how we specify the transform's trigger function, if any. Moving forward, we'll need to specify any custom trigger functions with a regular CREATE TRIGGER statement.
For these, we'll recognize that the trigger is being created on a CT, and we'll populate the CT's metadata appropriately and any optimized execution paths (e.g. pipeline_stream_insert) will still work instead of always going through the regular trigger execution path.

https://github.com/pipelinedb/pipelinedb/pull/1917 actually removes this. The only thing remaining is the CreateContTransformStmt grammar.

repo: pipelinedb/pipelinedb


text:
Crash when opening images

App is crashing when clicking on "Images", on ubuntu server 16.04
$ docker-dashboard
TypeError: Cannot read property '0' of null
    at images.forEach.s (/usr/lib/node_modules/docker-dashboard/lib/widget-images.js:26:23)
    at Array.forEach (native)
    at Object.self.docker.listImages [as callback] (/usr/lib/node_modules/docker-dashboard/lib/widget-images.js:23:10)
    at /usr/lib/node_modules/docker-dashboard/node_modules/dockerode/lib/docker.js:460:12
    at Modem.buildPayload (/usr/lib/node_modules/docker-dashboard/node_modules/docker-modem/lib/modem.js:259:7)
    at IncomingMessage.<anonymous> (/usr/lib/node_modules/docker-dashboard/node_modules/docker-modem/lib/modem.js:218:14)
    at emitNone (events.js:91:20)
    at IncomingMessage.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:974:12)
    at _combinedTickCallback (internal/process/next_tick.js:80:11)

Same for me!

eric-hansen fix this issue， we will publish it to the next version， thanks！

authors: itwars lionep pipiliang

repo: pipiliang/docker-dashboard