text:
PHP 8.0 support

Hey there, thanks for maintaining this package!
seems this project is built without PHP 8.0 support. I think the only reason this fails is because the composer.json file is locked to PHP ^7.2. Want me to submit a pull?

Oh sorry, I just noticed that it got released in June. My bad


text:
Fix build under MSVC

MSVC defines macros named min and max which conflict with
std::min/std::max.

I've seen the #55, but I think the way I did it is way better, because it doesn't require users to have extra knowledge how to build with this library (i.e. extra compiler flags when building theirs code).
And I personally consider macros with names such as min/max to be very harmful and I don't want to have them anywhere near my code.

I'm not sure this scales.  @zhangxy988 has probably thought about this more deeply than I.

Sorry for the late reply. As I stated in https://github.com/abseil/abseil-cpp/issues/34#issuecomment-337633532, I think this is an issue that should be addressed at the build system level rather than at source code level. I am willing to hear about the situations where

you can't add NOMINMAX flag in the build system.
you don't want NOMINMAX in some translation units.
These are the cases I think we need source-code-level remedy.

For example when building code that has pure C parts in it, and you would like to use those min/max (in pure C code). At the same time I wouldn't want to have those min/max defined for C++ code.
If this issue seems minor then I don't really have problems with leaving it like this.

So quick summary:
Downside of #define NOMINMAX at every #include <windows.h>:

This needs to be done EVERYWHERE in the code base and is thus not scalable. It's even not feasible in some cases where you don't own the code you depend on.
If it's not done EVERYWHERE, it depends on the header inclusion order: the first #include <windows.h> in a translation unit needs to have NOMINMAX defined before it.

Downside of using -DNOMINMAX compiler flag at build system level:

Requires some knowledge at build-system level and some work to add the compiler flag.
In cases where NOMINMAX is unwanted, special handling are needed, i.e. -UNOMINMAX for some translation units. I don't think these cases are restricted to pure C code.

In practice, our internal toolchain has been fine just having -DNOMINMAX as a compiler flag and in some rare case where it's not needed, we have -UNOMINMAX at package level or target level to suppress it.
IMO, I dislike the downside of #define NOMINMAX in source code more than -DNOMINMAX, and that's why I am reluctant to accept this PR. Here is an option I want to explore:

see if I can remove #include <windows.h> from headers in Abseil, so Abseil doesn't "pollute" the users code.
for .cc files, maybe we can add #define NOMINMAX if std::min|max is used to make it more friendly for users who don't want to add -DNOMINMAX.

My goal is to keep this as a patch of limited scope rather than promoting it as a best practice. The recommended way is still -DNOMINMAX at build system level. I'll investigate more and get back to your.

Thanks for productive discussion. I see your point and I don't insist on getting this PR through.
And I agree, removing #include <windows.h> from headers is the best option.
I would like to share our experience with you.
At our company inclusion paired with #define NOMINMAX actually scales better than defining it in a build system. The reason is a person who writes platform specific code usually knows better than a person who writes build scripts.
Situation: a) a linux developer changes build scripts a bit alongside with source code changes, b) sends them to review, c) his code is accepted, d) CI rejects builds since code doesn't compile on MSVC, e) linux developer in question spends another day or two to fix build problems (since he's not that familiar with MSVC and cannot build it locally).
PS: should I close this PR?

@umogSlayer : thanks for sharing the situation in your company. I am not sure I understand it fully and clearly:

The build scripts: Are they shared by all platforms? Does each platform has its own build configurations? If a global -DNOMINMAX exist for Windows build, I don't understand how a Linux developer could possibly break Window build, by removing -DNOMINMAX accidentally maybe?
"The reason is a person who writes platform specific code usually knows better than a person who writes build scripts" I don't fully agree. The build configuration for each platform should be maintained by developers working on the specific platform. In other words, build scripts/system configuration should be platform-specific.

Please feel free to close this PR as it is not likely to be accepted as is.
I will look into the alternative option I proposed above https://github.com/abseil/abseil-cpp/pull/61#issuecomment-352815372.
And we can continue this discussion either here (if you prefer) or in #34 .

source: gharchive/pull-request

authors: tituswinters umogSlayer zhangxy988

repo: abseil/abseil-cpp

license_type: permissive

license_source: bigquery


text:
Avoid directly accessing allocator members

C++11 introduced allocator_traits and since C++17 some allocator members have been deprecated.
These few lines produced thousands of lines of warnings and explanations on MSVC when compiled with /std:c++17.

This file contains a polyfill of std::allocator_traits. Changing the implementation to call std::allocator_traits would defeat the purpose. It seems that MSVC is warning about a type not owned by the standard library.
Can you take the discussion to #722 with a repro?

authors: bstaletic derekmauro


text:
Error maps from the API return as [object Object]

Seems related to #20 and #29. Also related to phoenixframework/phoenix#3323.
It seems like the various createFooError(errorMessage)s and the various upstream handlers all expect errorMessage to be a string. If my API returns a map instead we get [object Object].
In the other ticket I filed, I post a solution for preprocessing the error message into a string. However, I was wondering if it's reasonable to just check for stringiness in this library, and call JSON.serialize on the message if it's not a string?
A simple example would be changing createRequestError() to be:
const createRequestError = message =>
  new Error(`request: ${typeof message === 'string' ? JSON.stringify(message) : message}`)

(Would obviously benefit from more abstraction!)

Message must be string by spec.
We could consider adding support to extensions.

Duplicate of #29 (Let's follow the discussion there)

source: gharchive/issue

repo: absinthe-graphql/absinthe-socket

license: MIT

license_source: github-api


text:
Using newer version of academicicons?

I wanted to include my MathOverflow profile in my sidebar. Luckily there is a version of the logo in the newest (1.8.6) version of Academicicons. However, doing the obvious thing, which is copying the updated Academicicons files into assets/css and assets/fonts and adding
{% if author.mathoverflow %}

 MathOverflow

{% endif %}

to _includes/author-profile.html doesn't seem to work. The link shows up fine, but the icon doesn't.

I have a similar question. I'd like to use a Mastodon logo but it doesn't seem to be pulling from the current fontawesome

I am trying to do something like this. I want to add my InspireHEP handle to the sidebar, and it seems to be avaiable from academicicons, but it is not showing up. Does anyone know of a solution?

Now that the #TwitterMigration is happening, it'd be great to include a #Mastodon icon among the social-media links and to do so with the  feature that allows for #Mastodon verification.

This appears to have been addressed, and Mastodon icon has been added to the template as well.

I'm not seeing the icon after updating _config.yml, author-profile.html, _utilities, and _variables. Is it something I'm doing? Or not doing?

@stevenov How did you update the files? Do they have the same changes as 066dc22?

I downloaded the two .scss files into my local repo and copy-and-pasted the if-author.mastodon line into my existing author-profile.html, and then I pushed everything. You can see my Mastodon link; just no icon. Thanks!

@stevenov There was an update to the font library as well at f776953, try adding that and see if it works.

I downloaded the new _syntax.scss into my repo and pushed, but still no icon.

@stevenov Since there's been quite a few updates in the past couple days it's quite likely that I'm blanking on which one you would need, however the icon is working as expected with the stock template so it's hard for me to say what might be going on without taking a closer look at your code. You might want to start a thread over in the discussion since that should get more attention - as it is I'm the only one that gets notifications on updated to closed issues.

authors: Tom-Dee esselltwo nilsanilsson rjzupkoii stevenov

license: mit


text:
Página de Gonzalo

Gonzalo

Bien Hecho


text:
🛑 accubits.com is down

In fba0bf9, accubits.com (https://accubits.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: accubits.com is back up in af9bf92 after 16 hours, 8 minutes.

repo: accubits-nightswatch/upptime


text:
Export UTF-8

When I export from PMB the result messes up special characters. (Mac), i.e.:
Das MÃ¤rchen
for
Das Märchen
Could that be fixed on the server side?
See:
https://php-de.github.io/jumpto/utf-8/

apis is exporting in utf-8
use libre-office

True. I did open in Excel and then in LibreOffice and that messed it up already

repo: acdh-oeaw/apis-core


text:
🛑 AceBlock Swagger UI is down

In 0091cd0, AceBlock Swagger UI ($ACEBLOCK_SWAGGER_UI) was down:

HTTP code: 0
Response time: 0 ms

Resolved: AceBlock Swagger UI is back up in eb7f12f.

repo: aceblockID/monitoring


text:
🛑 AceBlock Swagger UI is down

In 5464589, AceBlock Swagger UI ($ACEBLOCK_SWAGGER_UI) was down:

HTTP code: 0
Response time: 0 ms

Resolved: AceBlock Swagger UI is back up in 0db132a.


text:
Update README.md

I’ve tested it works with iPadOS 14 and iPadOS 15 on iPad Air 2.

So there may not have an iOS-side check?

Interesting, we previously got reports that it was non-functional past iPadOS/iOS 13.
Decided to look closely, so grabbed iPadOS 15.7:

https://updates.cdn-apple.com/2022FallFCS/fullrestores/012-39076/45719613-AE30-429D-8F8F-011022F33E7F/iPad_64bit_TouchID_15.7_19H12_Restore.ipsw

Checked in the dyld, don't see such reference:
/Volumes/SkySecuritySydney19H12.J81J82J96J97OS/System/Library/Caches/com.apple.dyld/dyld_shared_cache_arm64

If you're able to reliably connect with the iPad5,3, I believe the README can be adjusted.
Thank you for the testing and PR.

repo: acidanthera/FeatureUnlock


text:
Tests working

ARuleMiner is now Miner.
Powerup and Info fields added to Miner.
FPGrowth now efficiently saves metrics when an FPTree is a list and it is sure to be generating only frequent itemsets.
Tests run smoothly.
Benchmark.

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:

authors: codecov-commenter mauro-milella


text:
Acorn install fails to check NginX Ingress Controller IngressCapability

$ acorn install --cluster-domain sbx.huma.com --ingress-class-name nginx --acorn-dns disabled
  ✔  Running Pre-install Checks
  ✔  Installing ClusterRoles
  ✔  Installing APIServer and Controller (image ghcr.io/acorn-io/acorn:v0.2.0)
  ✔  Waiting for controller deployment to be available
  ✔  Waiting for API server deployment to be available
  •  WARNING:  Post-install checks failed. Use `acorn check` to debug or `acorn install --checks=false` to skip
                 IngressCapability: Ingress not ready (test timed out)
  ✔  Installation done
$ acorn --version
acorn version v0.2.0+8dd7a3bb

ingress-nginx-controller log:
I0906 10:55:26.861215       8 event.go:282] Event(v1.ObjectReference{Kind:"Pod", Namespace:"external-system", Name:"ingress-nginx-controller-568764d844-wkbf8", UID:"4a6cd3d9-5fbc-42ca-9782-d651484f9642", AP
IVersion:"v1", ResourceVersion:"531066", FieldPath:""}): type: 'Normal' reason: 'RELOAD' NGINX reload triggered due to a change in configuration
W0906 10:56:05.525960       8 controller.go:1083] Service "acorn-system/acorn-ingress-test" does not have any active Endpoint.
I0906 10:56:05.572188       8 admission.go:149] processed ingress via admission controller {testedIngressLength:1 testedIngressTime:0.047s renderingIngressLength:1 renderingIngressTime:0s admissionTime:18.6
kBs testedConfigurationSize:0.047}
I0906 10:56:05.572229       8 main.go:101] "successfully validated configuration, accepting" ingress="acorn-system/acorn-ingress-test"
I0906 10:56:05.579031       8 store.go:420] "Ignoring ingress because of error while validating ingress class" ingress="acorn-system/acorn-ingress-test" error="ingress does not contain a valid IngressClass"
I0906 10:57:02.175674       8 store.go:390] "Ignoring ingress because of error while validating ingress class" ingress="acorn-system/acorn-ingress-test" error="ingress does not contain a valid IngressClass"

Versions:

K8s Rev: v1.23.8-gke.400
acorn version v0.2.0+8dd7a3bb
k8s.gcr.io/ingress-nginx/controller:v1.1.1 CHART ingress-nginx-4.0.15

@iwilltry42 assigning this to you. If a --ingress-class-name is passed as part of the install, it should be used/respected in the ingress test

Thanks for the report @denist-huma!

Thanks for the headsup!
Unfortunately, in my tests, ingress-nginx was quite slow to configure an IP, so I also had to raise the test timeout to 1 minute (took ~40s in my tests).
PR incoming :+1:

validation: PASS

authors: cjellick denist-huma iwilltry42 meldafrawi

repo: acorn-io/acorn


text:
Revert "skip tests for pypi release"

Reverts acryldata/datahub#138

@anshbansal why'd we revert this? Did it cause issues somewhere?

@hsheth2
yes it caused some codegen to not be there. So this probably needs more work. Try installing v0.9.5.1rc3 and use it to get version and you'll see the error.
One great things was this. It only took ~2mins to get the rc release done without the tests rather than ~26 mins. So if someone gets chance to work on this it can improve the CLI release time.

Got it - I think we just need to make sure ./gradlew :metadata-ingestion:codegen runs prior to the release
Likely won't be 2 minutes, but we can probably get it down to ~10

repo: acryldata/datahub


text:
Issue with multiple-db configuration

i saw config about below:
# the database configuration
db.instances=mongo,sql
# db1 configurations
db.mongo.impl=act.db.morphia.MorphiaPlugin
db.mongo.uri=mongodb://localhost/myapp
db.sql.impl=act.db.ebean.EbeanPlugin
db.url=jdbc:h2:./myapp
db.ddl.createOnly=true

The db.mongo.uri should be changed to db.mongo.url
The other thing is I tried to configure mysql db along with mongo db config, however console throws h2 driver class not found exception.

i change uri to url , this program is running. but i saw the second problem.
when my db.properties file config as below:
db.instances=db1,db2
db.db1.impl=act.db.ebean.EbeanPlugin
db.db1.driver=com.mysql.jdbc.Driver
db.db1.url=jdbc:mysql://127.0.0.1:3306/test1
db.db1.username=root
db.db1.password=root
db.db2.impl=act.db.ebean.EbeanPlugin
db.db2.driver=com.mysql.jdbc.Driver
db.db2.url=jdbc:mysql://127.0.0.1:3306/test2
db.db2.username=root
db.db2.password=root
and my entites blew:
@DB("db1")
@Entity(name = "va")
public class VirtualAccount{
@Id
private Long id;
@Index(unique = true)
public String ownerId;
// balance in cents
public int balance;
}
@DB("db2")
@Entity(name = "va2")
public class VirtualAccount2{
@Id
private Long id;
@Index(unique = true)
public String ownerId;
// balance in cents
public int balance;
}
but act start db will create two tables va and va2 also in test1 and test2.
so what wrong with this problem. perhaps, i will see va in test1 and va2 in test2 is right.
so pls check this problem.

@wangdanqing what is the actframework version and what is ebean version?

<dependency>
    <groupId>org.actframework</groupId>
    <artifactId>act</artifactId>
    <version>1.4.12</version>
    <scope>provided</scope>
</dependency>
<dependency>
    <groupId>org.actframework</groupId>
    <artifactId>act-ebean</artifactId>
    <version>1.0.2</version>
</dependency>

repo: actframework/act-doc


text:
Culture: Impostor Syndrome

https://en.wikipedia.org/wiki/Impostor_syndrome

How to combat e.g. On boarding buddies
https://memecrunch.com/meme/310L0/first-locate-your-exit-buddy


text:
Could someone post a screenshot of traits.Modes device on google home android?

I cannnot make it work, And I want to see what it looks like on the Google home app page. Is it a dropdown or something?
Thanks

There's no touch controls for the Modes trait.

repo: actions-on-google/smart-home-nodejs


text:
macos-14 deploys "RELEASE_ARM64_VMAPPLE arm64"

Description
macos-14 deploys "RELEASE_ARM64_VMAPPLE arm64" ; expected is "RELEASE_X86_64 x86_64".
ARM64 has lower floating point precision compared to X86, and tests fail due to this.
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[X] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Current runner version: '2.319.1'
Operating System
   macOS
   14.6.1
   23G93
Runner Image
   Image: macos-14-arm64
   Version: 20240915.3
   Included Software: https://github.com/actions/runner-images/blob/macos-14-arm64/20240915.3/images/macos/macos-14-arm64-Readme.md
   Image Release: https://github.com/actions/runner-images/releases/tag/macos-14-arm64%2F20240915.3
Runner Image Provisioner
   2.0.384.1+6d6c56aa16f1b9c7dd7935df5d63980397e44def](https://github.com/panchaBhuta/converter/actions/runs/10882030283/job/30192192682)
Is it regression?
no
Expected behavior
macos-13 (success) :: expect similar OS for macOS-14 image
https://github.com/panchaBhuta/converter/actions/runs/10882030283/job/30192194614

Actual behavior
macos-14 (fails)
https://github.com/panchaBhuta/converter/actions/runs/10882030283/job/30192192682
In the logs , on 3rd step "Get Version" ; command "uname -a" revels that its ARM64.
Check screen shot below for reference.

Repro steps
https://github.com/panchaBhuta/converter/actions/runs/10882030283/job/30192192682
re-run the job "Build (macos-14, default)"

Hey @panchaBhuta!
It's expected behaviour. Please follow the doc: https://github.com/actions/runner-images?tab=readme-ov-file#available-images
macos-13 is Intel-based, when macos-14 is arm64-based. Other architectures available via macos-13-xlarge and macos-14-large, respectively.

authors: erik-bershel panchaBhuta

repo: actions/runner-images


text:
[macOS] Perform a full clone of vcpkg instead of depth=1

Description
The vcpkg versioning features rely on retrieving information from its git repository history. This means users need a deep clone to access earlier versions and baselines.
See https://github.com/microsoft/vcpkg/blob/master/docs/users/versioning.md#builtin-baseline for one of the user-facing points that requires specifying a git commit id from the history
Related issue:
https://github.com/actions/virtual-environments/pull/4272
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run macos110

repo: actions/virtual-environments


text:
Get and update user profile

close #14
PR Description

Implement "Get User Profile" Endpoint

Any logged-in user can access the profile of other users.

Implement "Update User Profile" Endpoint

Add UserProfile Entity

Create a UserProfile entity and establish a mapping with the User entity.

Create UserProfileService

Add a service to manage the logic for the "Get" and "Update" user profile endpoints.

Ensure UserProfile Exists for All Users

Add a UserProfile for all existing users who don’t have one.
Ensure the registration process automatically creates a UserProfile for any new users.

شغال عندي فال local واللهي

I'm encountering an error indicating that no user profile exists. When I checked the user_profiles table in the database, I found it has 0 rows. I believe the issue lies in the V5_Create_user_profile_to_all_inserted_users.sql script.

Try to execute the script first.

repo: activecourses/upwork-clone-backend


text:
[2.0] Switch Dataset.delete to Dataset.del

🚀 🚀 Pull Request
Checklist:

[x]  My code follows the style guidelines of this project and the Contributing document
[x]  I have commented my code, particularly in hard-to-understand areas
[x]  I have kept the coverage-rate up
[x]  I have performed a self-review of my own code and resolved any problems
[x]  I have checked to ensure there aren't any other open Pull Requests for the same change
[ ]  I have described and made corresponding changes to the relevant documentation
[x]  New and existing unit tests pass locally with my changes

Changes
Switch to python's built-in deletion syntax del ds. Note that this destroys the name and a NameError will occur if you try to further access the object. A static Dataset.delete(path) is also provided for utility; we may consider replacing this with an overwrite flag in the future.

https://docs.python.org/2/reference/datamodel.html#object.__del__
I totally misused del. This patch is bugged. I'll put up an alternate fix soon

repo: activeloopai/Hub


text:
DB client API should not exit(0)

bad bad!
https://github.com/actonlang/acton/blob/main/backend/client_api.c#L610
not sure if it needs to exit at all? but at the very least, exit with 1 or something, so we know something bad happened...

It should not exit at all, as this is meant as an error msg handler for socket operations (such as attempting to write on a socket closed by the other end). In these cases, the RTS should not exit at all. I pushed a similar change yesterday in https://github.com/actonlang/acton/pull/574 (on the server side), so just remove the exit() altogether on the client side as well.

authors: aagapi plajjan

repo: actonlang/acton


text:
libuv related crash in TestDbApps.test_app_resume_tcp_server

test_app_resume_tcp_server sometimes produces a libiv-related RTS crash in the server actor.
To repro, run:
for i in $(seq 1000)
do
python3 test_db.py TestDbApps.test_app_resume_tcp_server
if [ $? -gt 0 ] ; then break ; fi ; done
(optionally disable @flakey around test_app_resume_tcp_server function first to prevent retries).
gdb backtrace in ddb_test_server:
Outcome

(gdb) bt
#0  0x00000000004d5c7a in uv_write2 ()
#1  0x000000000040ce8b in net$$TCPListenConnection$write$local (__self__=0x20e8d40, data=0x20e9cb0, c$cont=0x20e9cf0)
    at stdlib/src/net.ext.c:337
#2  0x000000000040e13d in net$$l$9lambda$__call__ (p$self=0x20e9bf0, c$cont=0x20e9cf0) at stdlib/out/types/net.c:280
#3  0x0000000000437e20 in wt_work_cb (ev=0x57c378 <work_ev+120>) at rts/rts.c:1338
#4  0x00000000004d0ce9 in uv.run_check ()
#5  0x00000000004ce4d4 in uv_run ()
#6  0x0000000000439037 in main_loop (idx=0x1) at rts/rts.c:1486
#7  0x00007f78e3c3b609 in start_thread (arg=<optimized out>) at pthread_create.c:477
#8  0x00007f78e3a02163 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Culprit line of code in rts.c:

#3  0x0000000000437e20 in wt_work_cb (ev=0x57c378 <work_ev+120>) at rts/rts.c:1338
1338	        $R r = cont->$class->__call__(cont, val);

Expectation

Actor should not crash

Assigning to @plajjan

I don't seem to be able to reproduce this. I only get other errors. Nonetheless, I've written a change which I imagine could help with the above situation.
In case you run into it again, I think the interesting value is __self__->client for the above net$$TCPListenConnection$write$local function. After #917 it should be invalidated (-1) after resume. You probably had some garbage value which lead to segfault... still weird I don't see that though.

Okay, I've hit this now after running with a new test script... and got a fix upcoming in #922.

Pretty sure this is fixed by #922. At least things have changed enough with #922 and other PRs that it's time to rerun in order to reproduce this error.


text:
unable to login

Hello,
I am using mg ismart to connect to MG hector petrol suv.
But it keeps throwing the following error:
"Failed to authenticate, please check your credentials."
I am sure the username/credentials are fine, because I am able to login to my mobile app.
Please help.

Hi,
Do you have special characters on your password? If that's the case, you need to change it on the iSmart app, as the API does not allow special characters.

Hi, I am not able to set a password without special character in ismart. It says atleast one special character is a must.

That's quite odd. Some time ago I could change the password and do not use special characters.
I'm sorry, but I cannot help on that right now. I was checking again and the API does not accept symbols. Let me see if I mind a workaround, but does not seem something easy.

Sure thank you 👍
On Wed, 23 Oct, 2024, 1:44 pm Alvaro Duarte, @.***>
wrote:

That's quite odd. Some time ago I could change the password and do not use
special characters.
I'm sorry, but I cannot help on that right now. I was checking again and
the API does not accept symbols. Let me see if I mind a workaround, but
does not seem something easy.
—
Reply to this email directly, view it on GitHub
https://github.com/ad-ha/mg-saic-ha/issues/12#issuecomment-2431251646,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BMKXSTQJ5FMJ2CFI66UTFWLZ45LGNAVCNFSM6AAAAABQM7VPECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZRGI2TCNRUGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

I will close this as it is not an actual issue from the integration, but a bug from the API.
Cheers

repo: ad-ha/mg-saic-ha


text:
Markdown w komentarzach na mikro nie działa

Jeżeli komentarz zawiera blok kodu wykorzystujący trzy znaki apostrofu, to jest interpretowany jako pojedyncza linia. Przykładowy komentarz http://4programmers.net/Mikroblogi/View/15256#comment-15284

Poprawka juz lezy na gitcie

authors: Koziolek adam-boduch

repo: adam-boduch/coyote


text:
CSS only tooltips

As discussed

Merged

authors: adamcooke rglyall

repo: adamcooke/staytus


text:
Create Password protected archive

Create Password protected archive

When it commented in I have gotten an objectdisposed exception when trying to write the stream

This was easier than I thought.  I'll probably make a fresh branch and use what you did and figure out the disposal issue too.
Thanks for the code!

Did you have time to look into my pull request?

I've started working on it here: https://github.com/adamhathcock/sharpcompress/compare/master...zip_encryption
There are still issue around fixing the headers of a zip when creating.

Thanks for your great work. Did you see that i have added another feature in my pull request?
A feature to add empty folders.
By the way ist there alreay a way to read archivecomments? I only found a way to set them..

Please make different branches and pull requests for fixes/features.  I don't get notified of new commits in existing pull requests.

Really looking forward to getting this feature, thanks!

I've been working on this in a branch, it wasn't as straight forward as I thought to get it implemented correctly.  I may pick it up again soon if I get time (which is unlikely)
https://github.com/adamhathcock/sharpcompress/tree/zip_encryption

authors: Genae adamhathcock dos-ise

repo: adamhathcock/sharpcompress


text:
Command line parameter not being escaped correctly, can't handle spaces in path

I was trying out the alpha package and hit a problem:
C:\Users\Brandon\.nuget\packages\minver\1.0.0-alpha.3\build\MinVer.targets(12,5): error MSB3073: The command "dotnet C:\Users\Brandon\.nuget\packages\minver\1.0.0-alpha.3\build\MinVer.Cli.dll C:\Users\Brandon\Documents\Visual Studio 2017\Projects\ConsoleApp141\ConsoleApp141 > "obj\Debug\netcoreapp2.1\min-ver-879a2.txt"" exited with code -532462766.

Unhandled Exception: System.Exception: Path 'C:\Users\Brandon\Documents\Visual' doesn't point at a valid workdir.
   at MinVer.Versioner.GetVersion(String path) in C:\projects\min-ver\MinVer\Versioner.cs:line 21
   at MinVer.Cli.Program.Main(String[] args) in C:\projects\min-ver\MinVer.Cli\Program.cs:line 14

Looks like the parameters being passed to the dotnet command in the targets file need to be updated to account for potential spaces in the paths.

Thanks for catching this. Would you like to send a PR?

@adamralph Done: #44

authors: adamralph bording

repo: adamralph/min-ver


text:
How to integrate?

How do i put it on my website?

Just include log.js (or log.min.js using a <script> tag. That’s it!

Just include log.js (or log.min.js) using a <script> tag. That’s it!

authors: RDIL adamschwartz

repo: adamschwartz/log


text:
🛑 mastodon-relay.moew.science is down

In 6225f33, mastodon-relay.moew.science (https://mastodon-relay.moew.science/actor) was down:

HTTP code: 0
Response time: 0 ms

Resolved: mastodon-relay.moew.science is back up in a4d7952 after 12 minutes.


text:
🛑 relay.chocoflan.net is down

In 3ed6cae, relay.chocoflan.net (https://relay.chocoflan.net/actor) was down:

HTTP code: 0
Response time: 0 ms

Resolved: relay.chocoflan.net is back up in 765daea after 9 minutes.


text:
🛑 relay.wagnersnetz.de is down

In 0e7bfeb, relay.wagnersnetz.de (https://relay.wagnersnetz.de/actor) was down:

HTTP code: 0
Response time: 0 ms

Resolved: relay.wagnersnetz.de is back up in 16855a1.


text:
🛑 relay.wagnersnetz.de is down

In 1a659c5, relay.wagnersnetz.de (https://relay.wagnersnetz.de/actor) was down:

HTTP code: 0
Response time: 0 ms

Resolved: relay.wagnersnetz.de is back up in 4ecbdbb.


text:
🛑 mastodon-relay.moew.science is down

In cebd33f, mastodon-relay.moew.science (https://mastodon-relay.moew.science/actor) was down:

HTTP code: 502
Response time: 1182 ms

Resolved: mastodon-relay.moew.science is back up in 84fefeb.


text:
🛑 relay.froth.zone is down

In 87e799a, relay.froth.zone (https://relay.froth.zone/actor) was down:

HTTP code: 0
Response time: 0 ms

Resolved: relay.froth.zone is back up in b4fc4f2.


text:
🛑 mastodon-relay.moew.science is down

In b6c723a, mastodon-relay.moew.science (https://mastodon-relay.moew.science/actor) was down:

HTTP code: 502
Response time: 545 ms

Resolved: mastodon-relay.moew.science is back up in 5c3f514.


text:
🛑 relay.national-defence.network is down

In 0b43290, relay.national-defence.network (https://relay.national-defence.network/actor) was down:

HTTP code: 0
Response time: 0 ms

Resolved: relay.national-defence.network is back up in 71dc925 after 28 minutes.


text:
🛑 relay.mstdn.live is down

In de45c8e, relay.mstdn.live (https://relay.mstdn.live/actor) was down:

HTTP code: 0
Response time: 0 ms

Resolved: relay.mstdn.live is back up in bca90ac after 35 minutes.


text:
please rename your user class

Hi,
having a class User in the pusher package clashes very often with app specific User classes when not prefixing on import. How about a PusherUser as name for that?

Hi @logemann , thank you for the feedback. I'll be updating/refactoring this library soon, and I'll take your suggestion into account.

authors: adaojunior logemann

repo: adaojunior/pusher


text:
Removed the use of the meta package and modernized the code.

Removed the use of the meta package and modernized the code.

Hi @pmundt - I wanted to send you this PR to help modernize the code. Please consider merging this. Thanks for building this nice and useful package.

repo: adaptant-labs/vin-decoder-dart


text:
The same paywall is available for free trial information in the Android native SDK, but not in flutter SDK 2.6.2

The following is printed information for the Android SDK
AdaptyPaywallProduct(vendorProductId=test_yearly, localizedTitle=Test Yearly Product , localizedDescription=, paywallName=test paywall, paywallABTestName=test paywall, variationId=7b63310d-cf9e-482c-9d72-da1386997378, price=Price(amount=469, localizedString=HK$469.00, currencyCode=HKD, currencySymbol=$), subscriptionDetails=com.adapty.models.AdaptyProductSubscriptionDetails@cee6a6b, productDetails=ProductDetails{jsonString='{"productId":"test_yearly","type":"subs","title":"Test Yearly Product ","name":"Test Yearly Product","localizedIn":["en-US"],"skuDetailsToken":"AEuhp4IYoRAXUMYl779VSZrqCIxvVjl4EZztjfK_2VVJcYblStRX_fbmQmWgz4xvm_gt","subscriptionOfferDetails":[{"offerIdToken":"AUj\/Yhil146KKInjGLramQRWsVgKrCK1IKTkvOVYhVz7CatEGsTAZVN3IkOHotmc1Cy8cR0RMSIpzCDv0\/e09LP\/qboDPBCVQkpNocXH6CV1ZnYgOoTPa9EU2MW6t+s2Xia3z5KHYmj7fjKZL3z14580El6pcIaL","basePlanId":"yearly-test","offerId":"test-yearly-freetrial","pricingPhases":[{"priceAmountMicros":0,"priceCurrencyCode":"HKD","formattedPrice":"免費","billingPeriod":"P1W","recurrenceMode":2,"billingCycleCount":1},{"priceAmountMicros":469000000,"priceCurrencyCode":"HKD","formattedPrice":"HK$469.00","billingPeriod":"P1Y","recurrenceMode":1}],"offerTags":[]},{"offerIdToken":"AUj\/YhhGJ1XQJZ3tCKpx\/o6ojGB48z2xdN1irXQv37ksjNLZXlXwaaArqeSAHu6pZOp3gSB2OSAFtiUT0Nxc4jHUt4rQaaVCH\/730nv38pExCKqCcLMVjYxP1g==","basePlanId":"yearly-test","pricingPhases":[{"priceAmountMicros":469000000,"priceCurrencyCode":"HKD","formattedPrice":"HK$469.00","billingPeriod":"P1Y","recurrenceMode":1}],"offerTags":[]}]}', parsedJson={"productId":"test_yearly","type":"subs","title":"Test Yearly Product ","name":"Test Yearly Product","localizedIn":["en-US"],"skuDetailsToken":"AEuhp4IYoRAXUMYl779VSZrqCIxvVjl4EZztjfK_2VVJcYblStRX_fbmQmWgz4xvm_gt","subscriptionOfferDetails":[{"offerIdToken":"AUj\/Yhil146KKInjGLramQRWsVgKrCK1IKTkvOVYhVz7CatEGsTAZVN3IkOHotmc1Cy8cR0RMSIpzCDv0\/e09LP\/qboDPBCVQkpNocXH6CV1ZnYgOoTPa9EU2MW6t+s2Xia3z5KHYmj7fjKZL3z14580El6pcIaL","basePlanId":"yearly-test","offerId":"test-yearly-freetrial","pricingPhases":[{"priceAmountMicros":0,"priceCurrencyCode":"HKD","formattedPrice":"免費","billingPeriod":"P1W","recurrenceMode":2,"billingCycleCount":1},{"priceAmountMicros":469000000,"priceCurrencyCode":"HKD","formattedPrice":"HK$469.00","billingPeriod":"P1Y","recurrenceMode":1}],"offerTags":[]},{"offerIdToken":"AUj\/YhhGJ1XQJZ3tCKpx\/o6ojGB48z2xdN1irXQv37ksjNLZXlXwaaArqeSAHu6pZOp3gSB2OSAFtiUT0Nxc4jHUt4rQaaVCH\/730nv38pExCKqCcLMVjYxP1g==","basePlanId":"yearly-test","pricingPhases":[{"priceAmountMicros":469000000,"priceCurrencyCode":"HKD","formattedPrice":"HK$469.00","billingPeriod":"P1Y","recurrenceMode":1}],"offerTags":[]}]}, productId='test_yearly', productType='subs', title='Test Yearly Product', productDetailsToken='AEuhp4IYoRAXUMYl779VSZrqCIxvVjl4EZztjfK_2VVJcYblStRX_fbmQmWgz4xvm_gt', subscriptionOfferDetails=[com.android.billingclient.api.ProductDetails$SubscriptionOfferDetails@f5e14e5, com.android.billingclient.api.ProductDetails$SubscriptionOfferDetails@38adbba]})
Below is the print information for flutter SDK
[(vendorProductId: test_yearly, localizedDescription: , localizedTitle: Test Yearly Product, regionCode: null, isFamilyShareable: false, paywallVariationId: 7b63310d-cf9e-482c-9d72-da1386997378, paywallABTestName: test paywall, paywallName: test paywall, price: (amount: 469.0, currencyCode: HKD, currencySymbol: $, localizedString: HK$469.00), subscriptionDetails: (subscriptionGroupIdentifier: null, subscriptionPeriod: (unit: AdaptyPeriodUnit.year, numberOfUnits: 1), localizedSubscriptionPeriod: 1年, introductoryOffer: [], promotionalOffer: null, androidOfferId: null, androidBasePlanId: yearly-test, androidOfferTags: [], renewalType: AdaptyRenewalType.autorenewable, _androidIntroductoryOfferEligibility: AdaptyEligibility.ineligible))]

Experiencing the same issue. The Android free trial is not shown in 2.6.2.
We had to revert back to 2.4.4.
Any news on when 2.6.x has the Android Offers?

Hi @LuoChengAndroid
Could you please check whether you've added an offer to the paywall? Since a product can be purchased with various of its offers or with no offer at all, it's important to specify an offer on the specific paywall

Hi @LuoChengAndroid
Could you please check whether you've added an offer to the paywall? Since a product can be purchased with various of its offers or with no offer at all, it's important to specify an offer on the specific paywall

The same paywall is available for free trial information in the Android native SDK, but not in flutter SDK 2.6.2。
I have provided the corresponding printing information above，I'm sure the offer was added to the paywall

@LuoChengAndroid did you test both cases with the same Google account? Could you please double check that the account you test Flutter with is eligible for the free trial according to Play Market? The printed info looks like either the offer was not present on the paywall, or was not eligible on the Google side for this test account

I used the same account to test two SDKS, and the result was that flutter SDK did not have corresponding data. I also used other accounts to test, and the result was the same: the offer information was in the Android SDK, but not in the flutter SDK

@LuoChengAndroid Could you please send the logs of this flow from Flutter SDK (that start with "Adapty_v2.6.2" – it's important) to support@adapty.io?

@LuoChengAndroid Could you please send the logs of this flow from Flutter SDK (that start with "Adapty_v2.6.2" – it's important) to support@adapty.io? Please also add the link to the issue in your email so that we know the context

The email has been sent

@LuoChengAndroid Thank you, replied

Can you please share the solution? I am still facing this issue!

@Arcturus5404 Is the Google account you're testing on eligible for the trial? From version 2.4.4 to 2.6.2, we migrated the Billing Library from v4 to v6, and starting from version 5, it doesn't return offers that a user is not eligible for.

Does that also mean that if I already tested this offer before, my test account is not eligible anymore?

@Arcturus5404 It depends on the way the offer is configured in the Play Console. You can test with an offer that has Developer determined eligibility criteria.

I'm using
Adapty flutter sdk V2.7.0 right now
I discovered something when I was debugging the code，
But I'm not very good at Kotlin，
I hope you can check it out

When this function is called, it changes when the result is converted

[image: image.png]

This is the data for one of the products

[image: image.png]

After the conversion, flutter returns something like this

[image: image.png]

This is obviously missing a lot of data, like subscriptionOfferDetails, but
I don't know how to find it
please
vladd-g @.***> 于2023年10月7日周六 18:40写道：

@Arcturus5404 https://github.com/Arcturus5404 Is the Google account
you're testing on eligible for the trial? From version 2.4.4 to 2.6.2, we
migrated the Billing Library from v4 to v6, and starting from version 5, it
doesn't return offers that a user is not eligible for.
—
Reply to this email directly, view it on GitHub
https://github.com/adaptyteam/AdaptySDK-Flutter/issues/93#issuecomment-1751678171,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYU4MGP7FZ7JUP5LDC26ZNTX6EWQ7AVCNFSM6AAAAAA34M7NB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRGY3TQMJXGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

@LuoChengAndroid the images are not visible, could you please edit the comment and attach them?

@LuoChengAndroid the images are not visible, could you please edit the comment and attach them?

I am very sorry, I have completed the picture, now you can see

This is obviously missing a lot of data, like subscriptionOfferDetails

It's a part of the native Product implementation from the Billing Library that isn't passed to the Flutter side; the relevant offer info is passed differently.

@LuoChengAndroid like you did on the second screenshot, could you please evaluate product.subscriptionDetails?.introductoryOfferEligibility on the product that, you suppose, lacks the offer data? and product.subscriptionDetails?.introductoryOfferPhases

If this data is not going to be passed to the flutter side, how do I
get it from the flutter side? I'd like to get the free trial data from
flutter

pricingPhases":[{"priceAmountMicros":0,"priceCurrencyCode":"HKD","formattedPrice":"免費","billingPeriod":"P1W","recurrenceMode":2,"billingCycleCount":1},{"priceAmountMicros":468000000,"priceCurrencyCode":"HKD","formattedPrice":"HK$468.00","billingPeriod":"P1Y","recurrenceMode":1}],"offerTags":[]},{"offerIdToken":"AUj/YhiHf0osugXZ6nRQC0OMnOy7Y1umoKw2sCZR58a2uFxlTdRuxbzMUFMnBjNUBz9sgPtPJmCQXpRYE5PtoG8PltOesOGZAHLqwt/hpmyBPlw=","basePlanId":"yearly","pricingPhases":[{"priceAmountMicros":468000000,"priceCurrencyCode":"HKD","formattedPrice":"HK$468.00","billingPeriod":"P1Y","recurrenceMode":1}]
I can get two data in Android, but I can't get the first free data in
flutter

vladd-g @.***> 于2023年10月8日周日 18:14写道：

This is obviously missing a lot of data, like subscriptionOfferDetails
It's a part of the native Product implementation from the Billing Library
that isn't passed to the Flutter side; the relevant offer info is passed
differently.
—
Reply to this email directly, view it on GitHub
https://github.com/adaptyteam/AdaptySDK-Flutter/issues/93#issuecomment-1751985359,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AYU4MGOTEMVBPHMOJ4RS54TX6J4JRAVCNFSM6AAAAAA34M7NB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRHE4DKMZVHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

I don't quite understand what you mean by evaluation. I just want to
get the free trial data of the product in the flutter side. When
debugging the code, it exists in the Android side, but I don't know
how to get it in the flutter side
I'm sorry I may have caused you some trouble, but I'm trying to figure it out
vladd-g @.***> 于2023年10月8日周日 18:27写道：

@LuoChengAndroid like you did on the second screenshot, could you please evaluate product.subscriptionDetails?.introductoryOfferEligibility on the product that, you suppose, lacks the offer data? and product.subscriptionDetails?.introductoryOfferPhases
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@LuoChengAndroid like you did on the second screenshot, could you please evaluate on the product that, you suppose, lacks the offer data? and product.subscriptionDetails?.introductoryOfferEligibility``product.subscriptionDetails?.introductoryOfferPhases

I checked these two data, and it shows that my account has no permission, but V2.4.4 version shows that I have permission, which makes me very confused, maybe there is something wrong with the configuration of our Google Play Console, I need to investigate first, thank you very much for your work

@vladd-g
hi,
We checked our configuration and found nothing wrong
I then called the Google billing v6.0.1 SDK and found that a free trial was available
Below I tested the same subscription product using the same account
The payment page awakened by the Google billing v6.0.1 SDK is used here

The payment page awakened by the adapty Android V2.6.2 SDK is used here

The adapty flutter V2.7.0 SDK is used here to wake up the payment page

Only the Google billing v6.0.1 SDK is available for a free trial
I don't know why this is happening, it's confusing to me

@LuoChengAndroid

The payment page awakened by the adapty Android V2.6.2 SDK is used here

It's the native Android SDK (not Flutter), right? Could you please filter the native logs with "Adapty_v2.6.2" and try finding the following line: Offer YOUR_OFFER_ID was not found for the base plan YOUR_BASE_PLAN_ID for the product YOUR_PRODUCT_ID (parts in caps are placeholders)
I suppose your offer id is either missing in the Paywall, or doesn't equal to the one from Play Console

@LuoChengAndroid

The payment page awakened by the adapty Android V2.6.2 SDK is used here

It's the native Android SDK (not Flutter), right? Could you please filter the native logs with "Adapty_v2.6.2" and try finding the following line: (parts in caps are placeholders)Offer YOUR_OFFER_ID was not found for the base plan YOUR_BASE_PLAN_ID for the product YOUR_PRODUCT_ID
I suppose your offer id is either missing in the Paywall, or doesn't equal to the one from Play Console

It is a native Android SDK, sorry I did not find the corresponding prompt in the related log

@LuoChengAndroid On the screenshot I see "offer_id":null for both products
Could you please specify the offer in the paywall in Adapty dashboard?

@vladd-g
Could you please specify the offer in the paywall in Adapty dashboard?
Thank you very much.  I have informed my O&M colleagues to add corresponding content in the Adapty dashboard, and I will verify it as soon as possible

@vladd-g
Thank you very much for getting the free trial information. Forgive me for not having the right to manage the Adapty dashboard, and my colleagues don't know about these changes. Now everything is OK

authors: Arcturus5404 LuoChengAndroid vladd-g

repo: adaptyteam/AdaptySDK-Flutter


text:
only execute if repo adessoag/devblog

fix #146

For more flexibility we could also determine execution on the existence of an environment-variable/github-secret. That on existence we execute and on the forks it isnt existing, but for testing and developing you can put it in.
@acetous What do you say?

Wir können das erstmal so machen. Schöner wäre natürlich, auf eine valide Konfiguration zu schauen. Das Testen von dem jekyll2cms würde das ja vereinfachen. ;)

authors: acetous silasmahler

repo: adessoAG/devblog


text:
Fixes a memory leak issue caused by Adhearsion::Translator::Asterisk

Ensure the components are deregistered from Adhearsion::Translator::Asterisk
once the call is ended. For more details see
https://github.com/adhearsion/punchblock/pull/250

@benlangfeld prepared the memory leak fix for adhearsion 3

Thanks @serioja90. Unfortunately it looks like the tests are failing for an unrelated reason, and we'll need to fix that before we can merge any more changes to develop.

repo: adhearsion/adhearsion


text:
Unlink seed from prompt not working in IMG2IMG after update

When using Auto1111 if you toggle "Unlink seed from prompt" the prompt will still remain the same through generations. This wasn't happening prior to updating the extension earlier today.
To Reproduce
Steps to reproduce the behaviour, include the prompt you used if applicable:

Go to IMG2IMG tab (batch in my case)
Advanced Options / Toggle unlink seed from prompt
Put a prompt with a wildcard (I'm using prompts for example)
Notice the prompt doesn't change even though it is supposed to be unlinked. In the past it would randomly pull another prompt from the wildcard set.

Also mention which checkboxes have been set.
Are you using a local install or a colab?
Local install / Auto1111 but prior to the recent update that changed the way Hires fix functions
If a colab, which one?
Expected behaviour
When, "Unlink seed from prompt" is toggled in Batch IMG2IMG wildcards should cycle through different prompts while running (not remain the same for each generation).
Additional context
Thanks for all your hard work.

Turns out this was something on my side. Did a fresh install and working fine in earlier and current Auto version. Sorry/thx

repo: adieyal/sd-dynamic-prompts


text:
Parameterized prompts with more than one parameter do not display evaluated prompt

What's wrong
My prompt looks like this:
${subject=!he-man}
${features=!with immaculate shoulder-length blonde hair}
${details=!with a fervent look in his eye}
${pose=!brandishing a sword above his head}
${setting=!a rocky crevasse}
${background=!greyskull castle looms in the background}

__promptgeek/prompt()__

I iterated over immediate evaluation (ie ! vs no !) and invoking the prompt vs not invoking it (ie prompt() vs prompt).  I'm still left with metadata that looks like this:
Prompt: ${subject=!he-man}
${features=!with immaculate shoulder-length blonde hair}
${details=!with a fervent look in his eye}
${pose=!brandishing a sword above his head}
${setting=!a rocky crevasse}
${background=!greyskull castle looms in the background}
__promptgeek/prompt()__
Steps: 16 | Seed: 1362315855 | Sampler: DPM++ 2M Karras | CFG scale: 6 | Size: 768x768 | Parser: Full parser | Model: sd15_photorealistic_juggernaut_aftermath | Model hash: ba12f15e72 | VAE: vae-ft-mse-840000-ema-pruned | Latent sampler: UniPC | Image CFG scale: 6 | Denoising strength: 0.3 | Refiner start: 0.5 | Secondary steps: 20 | Version: 42c6147 | Pipeline: Original | Operations: "txt2img | hires" | CFG Rescale phi: 0 | Hires upscale: 1.5 | Hires steps: 20 | Hires upscaler: 4x-UltraSharp | Score: 6.97

The promptgeek prompt looks like this:
      __photorealistic/style__ photo of ${subject},
      ${features},
      ${details},
      ${pose},
      ${action},
      __photorealistic/framing__,
      ${setting},
      ${background},
      __photorealistic/lighting__,
      __photorealistic/camera/angle__,
      __photorealistic/camera/properties/shot_on**__,
      {1-$$__photorealistic/camera/properties/film_type__
        |__photorealistic/camera/properties/lens__
        |__photorealistic/camera/properties/filters_and_effects__},
      {3::_|1::in the style of __photorealistic/photographer__}

What works
When I comment out all of the other variables besides the subject, it works as expected:

instant photo photo of he-man,

head shot,

soft fill lighting,
shot from a Dutch angle,
shot on Hasselblad 500CM,
Fujicolor Pro
  ,soft focus,
photorealistic,photographer

Steps: 16, Seed: 2639461381, Sampler: DPM++ 2M Karras, CFG scale: 6, Size: 768x768, Parser: Full parser, Model: sd15_photorealistic_era09_v10, Model hash: d03946b93d, VAE: vae-ft-mse-840000-ema-pruned, Latent sampler: UniPC, Image CFG scale: 6, Denoising strength: 0.3, Refiner start: 0.5, Secondary steps: 20, Version: 42c6147, Pipeline: Original, Operations: "txt2img, hires", CFG Rescale phi: 0, Hires upscale: 1.5, Hires steps: 20, Hires upscaler: 4x-UltraSharp, Score: 7.07, Hashes: {"vae": "735e4c3a44", "model": "d03946b93d"}

Re-enabling any of the other parameters causes the issue to happen again.
Without the actual resolved prompt being displayed, I have no idea what the prompt was that generated the image.

I've got a new finding on this issue.  Turning on "Write prompts to file" will cause the prompt metadata to not only show up in the file, but to be correctly embedded in the generation as well.

What do you think would be a more reasonable approach to dealing with this:

More explicit error message in the console
Warning in the console and defaulting values to an empty string
3

I think the parameterized invocation syntax template(x=abc) should accept multiple parameters.
The behavior of parameters should be documented
Throw an exception if any required parameters are missing that prevents the generation from proceeding


text:
I have corrected Sign Up for Newsletters page

Issues Identification
Closes: #542
Description
Summary
A brief description of what this pull request does and why it is needed.
Details
Include any detailed information about the changes in this pull request.
Types of Changes
Please check the boxes that apply

[X] Bugfix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist
Please check the boxes that apply

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] My changes do not break the current system and pass all existing test cases
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes

Screenshots

Additional Information
Please provide any other information that is relevant to this pull request.

@aditya-bhaumik thankyou somuch

repo: aditya-bhaumik/Pathsphere


text:
Help with creating embeddings from networkx graph edgelist

I'm trying to create embeddings for an edge list I have using networkx and node2vec. My edge list looks as follows:
1 2
1 6
...
450 230
...
601 602

It's an unweighted undirected graph, basically, and is stored in a text file. I'm trying to convert this to a graph using:
nx_G = nx.read_edgelist(args.input, delimiter=' ', create_using=nx.DiGraph())
The read_edgelist functions reads the nodes properly, and embeddings are being created. However, in the embeddings file, the nodes aren't numbered 1 through 606 (these are the node values in my edge list): instead, they are 14 in number, with digits from 0-9 and some special characters as the node values instead for which the embeddings have been created. That is, instead of reading an entire number of more than one digit (say 29) as a single node, it is simply reading 2 and calculating embeddings for it. I do not understand why this is happening and would appreciate some insight. Is there any condition that the nodes must have single-digit or single-character names?

I solved this by commenting out the following line in main.py:
walks = [map(str, walk) for walk in walks]


text:
API Validation: GetAllAssetAdministrationShellsByAssetId missing

In case of API validation " AssetAdministrationShellRepositoryServiceSpecification/SSP-002", GetAllAssetAdministrationShells with query parameter AssetId API call is missing.

Fixed. However, I had to include this in the GetAllAssetAdministrationShells operation, since OpenAPI spec defines it that way.

authors: juileetikekar otto-ifak

repo: admin-shell-io/aas-test-engines


text:
🛑 Covid Portal is down

In 54472d3, Covid Portal (http://covid19.interieur.gov.ma/Operation_ATTADAMON.aspx) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Covid Portal is back up in 4afe36a.

repo: adnane-X-tebbaa/DownTime-Score


text:
Fixing mini resource card for tablet and mobile size

The tablet and mobile size not showing properly in sidekick
Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

https://louisa-mini-resource-card--adobe-io-website--adobe.hlx.live/tools/sidekick/library.html?plugin=blocks&path=/tools/sidekick/blocks/miniresourcecard&index=0

repo: adobe/adobe-io-website


text:
CIF-1608 - Category Carousel Component

enhanced featured category list component to category carousel
rebranded featured category list component as Category Carousel
added unit tests for category carousel client library

Related Issue
CIF-1608
How Has This Been Tested?
Manually, karma tetst.
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] I have added tests to cover my changes and the overall coverage did not decrease.
[X] All unit tests pass on CircleCi.
[X] I ran all tests locally and they pass.

@mhaack , I think both points are valid. Actually I've been investigating an other solution too which would address both points and go beyond but opened these PRs on Friday to closely match the solution that we discussed on the technical grooming.
After all this I'm certainly in favor of a more comprehensive redesign where we clarify better backwards compatibility concerns and strategy for evolving the components.

After all this I'm certainly in favor of a more comprehensive redesign where we clarify better backward compatibility concerns and strategy for evolving the components.
... what does this mean? Are you closing this PR an create a new one?

I can close this and create a new PRs (all 3 will be different), we can discuss it in the grooming tomorrow.

authors: LSantha mhaack

repo: adobe/aem-core-cif-components


text:
Fix Sites content tree while opening rule editor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

Closing please create a branch in the same repo. Also, add test cases

repo: adobe/aem-core-forms-components


text:
feat(modelmanager): enable asynchronous initialization of modelmanager

initializeAsync: Alternative for ModelManager.initialize for asynchronous initialization of model manager
Can be used within default SPA and remote app as well
Order of preference for determining url for fetching root model for initialization:

path passed as config on ModelManager.initializeAsync
Value of meta property cq:pagemodel_root_url,if set
Currently open url path (for default SPA)

Sample usage: Before render of the application -
ModelManager.initializeAsync({
    modelClient: {customModelClient},                                 //optional
    path: "/content/we-retail-journal/react/en.model.json" //optional
});

I am good with the contribution. Please consider my questions and suggestions

authors: pfauchere sharanyavinod

repo: adobe/aem-spa-page-model-manager


text:
Adding Artifact override rule required for mvn dependency with classification

for fix https://github.com/adobe/aemanalyser-maven-plugin/issues/208

Changes LGTM, but it would be good if one of @cziegeler @karlpauls or @bosschaert could also take a look.

not 100% sure, but I agree that this change looks good :)

authors: abhishekgarg18 cziegeler rombert

repo: adobe/aemanalyser-maven-plugin


text:
Find in Files clear error message

Fix for #9974
Tests run:

jshint
tests under Debug->run tests
Tests to recreate issue and confirming that it is not seen.

Can someone please review this ?

IMO it may not be a good idea to pass private UI elements. It would be better to keep them segregated and communicate through events

@prksingh  Yes that sounds like a better approach to take. I will make the changes. Thanks for the suggestion and review.

Travis CI build failed stating cla-check-pull error? Do I have to re-sign CLA agreement ?

The error appears to be different from a Cla-check-fail. I have restarted this build

The build failed again. Its not a cla-check fail though as far as I understand. The error message is: ""API rate limit exceeded ..." Are you in a subnet maybe that is pinging the github server for many requests?

Does that depend on my internet connection ? Not sure. I see jshint failure in files that I havent changed.

No, it does not depend on your internet connection.
You won't see the JSHint failures any longer if you merge in the latest upstream/master.

All is well now!

authors: MarcelGerber prksingh sriram-dev

repo: adobe/brackets


text:
static html from the code bus with selectors no longer works

Description
Due to recent changes https://github.com/adobe/helix-html-pipeline/pull/471 static html served via the cod bus that contains a selector fails to load with a 404
To Reproduce
Steps to reproduce the behavior:

add a static html file to code bus with a selector, something like /blocks/my-block/my-block.selector.html
attempt to access that file
see 404 response with invalid path error

Expected behavior
static html should be served as expected
Version:
run: $ hlx --version
Additional context
See thread with customer at https://adobe-dx-support.slack.com/archives/C03GXBSC72T/p1704214470859999
they are fixing on their side to work around regression, so unsure if we must fix this or not. But I do think we should at least try to make sure the cli behaves the same to avoid customer confusion

Looking into this a bit more, I think what happened is that these requests never used to make it to this service? Now that they do, they are failing the path info checks.
I think the path info check could be simplified to just:
 // only support selectors with html
  if (info.selector) {
    return info.extension === '.html';
  }

but that would require changing a few other tests to match that expectation.
@tripodsan curious for your thoughts.

fixed

authors: shsteimer tripodsan

repo: adobe/helix-html-pipeline


text:
@react-aria/slider: allow direction to be passed as a parameter in useSlider and useSliderThumb

🙋 Feature Request
Currently, useSlider and useSliderThumb use useLocale to get direction. I'd like to request a direction (or dir) parameter to be able pass in useSlider and useSliderThumb so that we don't need to reply on useLocale to get the direction for LTR/RTL.
🤔 Expected Behavior
If the direction parameter is provided, it override the direction of useLocale.
😯 Current Behavior
Current behavior is that we must use <I18nProvider> to specify locale for the direction.
💁 Possible Solution
Add an optional dir parameter in useSlider and useSliderThumb.
/**
 * Provides behavior and accessibility for a thumb of a slider component.
 *
 * @param opts Options for this Slider thumb.
 * @param state Slider state, created via `useSliderState`.
 * @param dir Direction for this Slider thumb.
 */
export function useSliderThumb(
  opts: SliderThumbOptions,
  state: SliderState,
  dir?: Direction
): SliderThumbAria {
  const { index, isRequired, isDisabled, validationState, trackRef, inputRef } =
    opts;

  const isVertical = opts.orientation === "vertical";

  let { direction } = useLocale();

  direction = dir ?? direction;
  ...
}

Same for useSlider. So we can use our theme direction.
const theme = useTheme();
const { thumbProps, inputProps } = useSliderThumb(
   {
     index,
     trackRef,
     inputRef
   },
   state,
   theme.direction
);

🔦 Context
Our system is using ThemeProvider with theme direction directly, it's difficult to convert direction to locale and use <I18nProvider>, so we can't make the useSlider and useSliderThumb work correctly for RTL. It would be great that if they have direction parameter to be more flexible to use.
I am not sure if there is any other way to make them work correctly for RTL, except using <I18nProvider>. Please let me know if there is a better way to do that.
If this proposed change makes sense to you guys, I am happy to prepare the pull request. Thank you. 🙇♀

I'm not sure I follow your concern. Is it that we don't support enough scripts and langs? https://github.com/adobe/react-spectrum/blob/3bfb608810e3dee8a091c43f11450648e93a2c96/packages/%40react-aria/i18n/src/utils.ts#L14
Why are you going this direction convert direction to locale? I think I'm not understanding enough about your application if the direction is determining the locale.
Can you just make one I18nProvider at the root of your application and pass it the locale being used and let it determine RTL?
Otherwise we'd need to support this in a lot of components and you'd need to remember which ones to pass it to. Since this is something you should only need to figure out once, it'd be better if it was on the context.

@snowystinger, thanks for your reply.
Sorry, I didn't make it clear. We are not building the application but we are offering something like component library. Our component library currently only supports having direction for LTR/RTL, so if an application uses our library, it needs to provide the direction in our context provider. In our library, what we get is direction only and it's difficult to convert direction to locale and then use I18nProvider.
I understand that you will support this in many components. If we want to have it on the context, I wonder if it's possible that the direction in I18nProvider can be overridden?

That would definitely be better. I'm still not certain we want to allow for a direction that is against the locale though. I'll bring it up with the team.

The locale is used for many things though, not just direction. E.g. number formatting is locale dependent. I imagine you'll need that in your library, if not now, then at some point in the future. It would be ideal if you could add it to your own  provider. Only setting the direction without setting the locale might cause all sorts of weirdness.
A temporary workaround in case that's not possible would be to hard code two locales depending on the direction.
let locale = direction === 'rtl' ? 'ar' : 'en';

Closing and we can reopen if it's still a problem.

authors: devongovett jeanpan ktabors snowystinger

repo: adobe/react-spectrum


text:
ListView UI bug fixes and updates

Closes #2611
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:
Verify the following TableView highlight selection mode visual changes:

There is now a blue border at the top of the row when you focus the top row of the TableView
The corners of the border of the first and last row are now rounded to match the TableView container
The far left and right borders of a selected row should be blue now. They should only be in view if you are scrolled all the way to the left and right

Verify the following ListView visual changes:

everything mentioned in #2611 except for the animations (haven't figured that out yet)
hovering over ListView row text should show the default cursor

For both TableView and ListView:

the row focus indicator on the left should be sticky now (e.g. if you scroll to the right it should remain in view)
See:

https://reactspectrum.blob.core.windows.net/reactspectrum/69997814091462f4bafa6d5a8f81ba0a1aec0395/storybook/index.html?path=/story/tableview--selectionstyle-highlight
https://reactspectrum.blob.core.windows.net/reactspectrum/69997814091462f4bafa6d5a8f81ba0a1aec0395/storybook/index.html?path=/story/tableview--selectionstyle-highlight-onaction
https://reactspectrum.blob.core.windows.net/reactspectrum/69997814091462f4bafa6d5a8f81ba0a1aec0395/storybook/index.html?path=/story/tableview--selectionmode-none-onaction

Note slight gap between the left/right border and the bottom border of the listview outline. This was done to prevent double borders from happening when two adjacent rows are selected and to prevent slight wiggles when selecting/deselecting that adjacent row
🧢 Your Project:
RSP

Things not yet handled:

Still can't get the checkbox animations to work in ListView
Haven't implemented the position fixed indicator in highlight selection TableView when you scroll the body

Gonna punt on the checkbox transition for now

@reidbarber yep, that is pre-existing, out of scope for this PR but def should get filed somewhere if it isn't

^ Safari

bleh, looking into it

@ktabors thanks for the RTL catch, pushed changes. The bottom border overlapping for the last row is pre-existing and a hard fix since there isn't a good way (that I can tell) to distinguish between that problematic case and a case where the last row doesn't overlap with the container bottom (e.g. a TableView/ListView that has a container taller than the amount of content such that the last row is actually in the middle of the container and thus should have a bottom border)

The borders on the bottom edge don't line up

Should TableView and ListView match for checkbox selection? I thought we discussed making them both have the blue border?

In ListView, the background animates from gray to blue, but the border does not. In TableView, neither animate. We should make them match.

The borders on the bottom edge don't line up

I wonder if for the top and bottom "borders", we could use inset box shadows. Something like .5px for the selected, and .5px for above/below. There may be some unwanted side effects I'm overlooking, but it might be worth looking into.

The borders on the bottom edge don't line up
Urgh, I think I'll have to get rid of the top borders for the ListView rows have then except for the bottom one, and do the same box shadow approach as TableView to make it consistent. Lemme give that a shot

Should TableView and ListView match for checkbox selection? I thought we discussed making them both have the blue border?
Gotcha, I got confused by the XD file but that makes sense since TableView is emphasized

In ListView, the background animates from gray to blue, but the border does not. In TableView, neither animate. We should make them match.
I'll make ListView match TableView then

Ugh, looks like something broke with the merge from main, works in the build link before it. Thanks for the catch, I'll take a look

Noticing an odd artifact, border colors seem to be different/faded? particular in the first and last rows
https://reactspectrum.blob.core.windows.net/reactspectrum/69997814091462f4bafa6d5a8f81ba0a1aec0395/storybook/index.html?path=/story/listview--selection-single-checkbox-isquiet

@ktabors

Just confirming two this as not issues. Do we need to round the corners on highlight selection on the first and last rows? I assume no, but checking.

Good catch, I forgot to rename the vars for TableView css. Should be fixed now

And I assume we don't care about these pixels showing up at 400% because it works and this is just visual.

I'm of the mind to ignore that for now since that is a result of the cell focus ring in TableView having rounded corners whereas the row has rectangular corners. Can handle it in a TableView css update later but feels out of scope for this PR IMO
@snowystinger

Noticing an odd artifact, border colors seem to be different/faded? particular in the first and last rows https://reactspectrum.blob.core.windows.net/reactspectrum/69997814091462f4bafa6d5a8f81ba0a1aec0395/storybook/index.html?path=/story/listview--selection-single-checkbox-isquiet  vs

Can't seem to reproduce on my end (maybe my eyes suck lol). Maybe a monitor thing?

vs

It was on my non high dpi monitor. Maybe that was why

Sticky positioned focus indicator doesn't stick in Safari

@snowystinger which story and repro steps? I'm seeing it work fine in the "many rows and columns" and highlight selection TableView story when keyboard focusing and scrolling to the right:

Note for other reviewers: talked w/ @snowystinger regarding the sticky indicator issue on Safari, looks to be happening on Safari 15 but not on 14. Will see if I can fix, the sticky checkboxes are broken as well

Initial investigation reveals that removing paint from the VirtualizerItem contain style resolves the issue of the sticky elements in the TableView not sticking. I'm still uncertain why paint breaks this for Safari but it is worth noting that css contain support was added in Safari 15.4 . I believe paint is part of the contain style for performance reasons, not entirely sure though.

For reference, filed a webkit bug here: https://bugs.webkit.org/show_bug.cgi?id=239357

authors: LFDanLu devongovett reidbarber snowystinger


text:
Update react types

Closes https://github.com/adobe/react-spectrum/issues/5157
Also handles https://github.com/orgs/adobe/projects/19/views/4?pane=issue&itemId=41163780
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

looks good aside from the undefined.JSX.Element showing up in the docs

looks good aside from the undefined.JSX.Element showing up in the docs

fixed

authors: devongovett snowystinger


text:
feat(link)!: migrate link to core tokens

Description

Update windows high contrast mode
Update YAML examples
Remove t-shirt sizes
Add Static White and Static Black variants

How and where has this been tested?

Tested locally referencing the Batch 2 XD file.
Tested WHCM with forced colors in Chrome Emulation

Screenshots

To-do list

[x] If my change impacts other components, I have tested to make sure they don't break.
[x] If my change impacts documentation, I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have tested these changes in Windows High Contrast mode.

[ ] This pull request is ready to merge.

VRT is: https://spectrum-visual-regression.ci.corp.adobe.com/view/Spectrum CSS/job/css-vrt-test/40/
1504 link.zip

VRT is: https://spectrum-visual-regression.ci.corp.adobe.com/view/Spectrum CSS/job/css-vrt-test/40
1504 link.zip

I added missing mod tokens and updated whcm styles

Released beta:
4.0.0-beta.0
@yosevu can you open an PR against the SWC repo with this update?

authors: bernhard-adobe pfulton yosevu

repo: adobe/spectrum-css


text:
MWPW-157999 - [Table] Add-on content

As a Milo Engineer, I want to add functionality to Milo table block so I can add design features from this design.

New features Include:

Rendering additional 'add-on' content in the table headers:
The table header decorator function requires that the content be written in a specific order. This PR introduces an additional method of inserting content into the header columns. Utilizing additional rows that are titled with an ADDON key. To use, add the position, order, and optional tag name separated by underscores to the row titles in these additional header rows and the table block will handle the rest. Example: ADDON_BODY_AFTER_PROMO.

Rendering label/badge styles in the table body:
To provide support for this design we needed to be able to create a custom element style in the table body. We did this by authoring the desired content with the quote style in word. When using add-on content the table block will style any blockquote content in the row titles to be styled like a label/badge.

Resolves: MWPW-157999
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/sarchibeque/table/add-on?martech=off

After: https://sartxi-mwpw-157999-table-addon--milo--adobecom.hlx.page/drafts/sarchibeque/table/add-on?martech=off

Before: https://main--milo--adobecom.hlx.page/drafts/sarchibeque/table/add-on-greentext?martech=off

After: https://sartxi-mwpw-157999-table-addon--milo--adobecom.hlx.page/drafts/sarchibeque/table/add-on-greentext?martech=off

Looking good. Few super minor design things to touch on if you think there worth it.

The addon-label icon can get pretty close to the text, maybe give it a little margin-start.
The table-title-text is italic, though it is authored w/ an<em>, so maybe its just a doc mistake.

Should both this content use the same authoring style (quote or code, etc) since it looks similar? maybe it's diff enough, just a though.

Looking good. Few super minor design things to touch on if you think there worth it.

The addon-label icon can get pretty close to the text, maybe give it a little margin-start.
The table-title-text is italic, though it is authored w/ an<em>, so maybe its just a doc mistake.

 Should both this content use the same authoring style (quote or code, etc) since it looks similar? maybe it's diff enough, just a though. Oop, the font color too on these looks a lil off.

Okay I have addressed your findings, thanks!

test loc workflow and add any exceptions in the htmlFlow for cell keys ADDON etc

Thanks for the reminders, I will make sure get them done!

Sub-Task for localization workflow updates
Sub-Task for authoring documentation

authors: Sartxi ryanmparrish

repo: adobecom/milo


text:
joinRaw inside the belongsToMany

I create a belongsToMany relationship in the lucid models, like the diagram shown below:

However i put the car name on the car_name table which includes
car_name_id integer -- primary key
car_id integer -- foreign key to car table
name string -- value
language string -- language

when I join them in the controller, it seems have something wrong with it
Under the CarController.js
var language = params.language
var ret = await User.query().with('car', function(builder){
builder.select([
  'a.name',
  'car.model'
])
builder.joinRaw('LEFT JOIN car_name as a on a.car_id=car.id and a.language=?', [language])
}).first()

However, an error show below
Error: select car.a.name, car.car.model from car LEFT JOIN car_name as a on a.car_id=car.id and a.language='en' inner join car_user on car.id = car_user.car_id where user.user_id in (1, 2, 3)
it seems that car is auto added as the prefix in the select statement
As i tried to remove the builder.select() method and it's work,
but i still need to support multi language in here
how can i do that?

Hey @hinng0302! 👋
Could you create a repository with some code so I can reproduce this issue on my own?

sure! @RomainLanz
https://github.com/hinng0302/simple_adonis_joinRaw
I just created a sample for this issue.
// params.language will support different language for example: english, german, french
http://localhost:3333/get_all_users/car/language/:language

any luck?

repo: adonisjs/adonis-lucid


text:
Parse data from TRSS url

TKG Parse data from TRSS url

related:https://github.com/adoptium/TKG/issues/558

Grinder links:
TARGET: sanity.functional
mac:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/42270/
win:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/42271/
aarch64_linux:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/42272/console
s390x_linux:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/42268/
Attempting to get test duration data from TRSS.
12:31:40  curl --silent --max-time 120 -L -k https://trssrtp1.fyre.ibm.com/api/getTestAvgDuration?limit=10&jdkVersion=11&impl=j9&platform=s390x_linux&group=functional&level=sanity -o /home/jenkins/workspace/Grinder/aqa-tests/TKG/response.json
12:31:45  Response data written to file: /home/jenkins/workspace/Grinder/aqa-tests/TKG/response.json
12:31:45  Response Data: {"testListTime":[15134729.416666664],"testLists":[[{"_id":"cmdLineTester_criu_nonPortableRestore_10","avgDuration":2045327.3333333333},{"_id":"testJITServer_2","avgDuration":812512.6666666666},{"_id":"testJITServer_1","avgDuration":704608.6666666666},{"_id":"testJITServer_0","avgDuration":703974.3333333334},{"_id":"cmdLineTester_criu_nonPortableRestore_3","avgDuration":297062},{"_id":"cmdLineTester_criu_nonPortableRestore_4","avgDuration":281803.3333333333},{"_id":"cmdLineTester_GCRegressionTests_3","avgDuration":277104.3333333333},{"_id":"cmdLineTester_GCRegressionTests_2","avgDuration":266454.3333333333},{"_id":"cmdLineTester_GCRegressionTests_1","avgDuration":264064.3333333333},{"_id":"cmdLineTester_GCRegressionTests_0","avgDuration":263644},{"_id":"cmdLineTester_criu_nonPortableRestore_9","avgDuration":235436},{"_id":"cmdLineTester_criu_nonPortableRestore_7","avgDuration":220314.33333333334},{"_id":"cmdLineTester_criu_nonPortableRestore_0","avgDuration":207269.33333333334},{"_id":"cmdLineTester_criu_nonPortableRestore_2","avgDuration":198845},{"_id":"cmdLineTester_criu_nonPortableRestore_5","avgDuration":198723.66666666666},

repo: adoptium/TKG


text:
Added churn testsuite

churn testsuite is powerful suite to test individual GCs in OpenJDK
As it is added heere, it tests all GCs in given version of jdk.
Initial pass is https://ci.adoptium.net/view/Test_grinder/job/Grinder/8946/
As it is now - for review process, it runs for some 20 seconds - that means aprox 4 seconds per GC, which i moreover useless. In GH actions (https://github.com/rh-openjdk/churn/actions) I run it  on all platforms for aprox 3 minutes per GC, whcih is still moreover useless.
Exept running as it is, it can also run in disabled compressed oops mode. Not sure if it is required here. To run both, should be easy.  To make it configurable.. not sure...
Few questions:

the site generates archive full of logs, which are sueprusefull in case of failure. How to propagate them? Or maybe it is done correctly? If so how to see them in grinder?-)
what is acceptable time for you to  run churn? I left in comment suggesting 5hours for all GCS (so aprox 1hour per gc - close to be usefull)
there is archive with results for jtreg plugin. It contains single juni xml file. Can it be somehow publised?
Are you ok with running all gcs in one task?

the individual GCs are reported separately in both logs archive and in junit xml file
it woudl be nice to have them reported as individual taps or at least individual targets or somethng liek that.. but It is not strightforward to select correct set of GCs per JDK, so I would rather remain in current ALL
Despite I would liek to see above, I'm not sure it is possible. The logs from several hours long run are huge

Grinder with disabled compressed oops https://ci.adoptium.net/view/Test_grinder/job/Grinder/8948/

* the site generates archive full of logs, which are sueprusefull in case of failure. How to propagate them? Or maybe it is done correctly? If so how to see them in grinder?-)

It seems I'm handling resutls correctly. The only disadvantage of run in grinder is, that logs got packed second time. I will fix this in the usptream runner.

Hello! Bit more bussy day then expected:(

I had remvoed the disbaled coompressed ops variant, and left it to the framework to deal with it. If you would guide me a bit more, I will adjsut upstream to honor your setup I believe
I had renamed the targets and split them as you suggested
the results seems correct now
answer to iminent question is that it will fail ig the GC is msising, or not test, if there is additional GC. Any suggestion on the vendors which gamble so much with GCs? Simialrly with default GC.

Currently the decision is based simply on jdk major version, I can add more, or add some custom wrapper

re: https://github.com/adoptium/aqa-tests/pull/5101#issuecomment-1966681217 - great, chat with you tomorrow about final steps

pls do not merge (yet). The https://github.com/adoptium/aqa-tests/commit/050fb07dd56547b55b6728a7bbbea0cd04643705 is missbehavg in my test setup. But maybe my testsetup is wrong

re: https://github.com/adoptium/aqa-tests/pull/5101#issuecomment-1969259343 - I will convert this to Draft state, until all reviews and testing is completed (that way it can not get merged prematurely)

The https://github.com/adoptium/aqa-tests/commit/050fb07dd56547b55b6728a7bbbea0cd04643705 , overwritten as https://github.com/adoptium/aqa-tests/commit/2249bc0ddbadfd0c2040597a78fa285ef048717d now works.
Am now updating readme to reflect the state. Will lift draft (thanx for setting it up) once done
Two new questions

the suite now generates next to jtreg archive also nice tap file. Is any special step needed to make it visible?

https://ci.adoptium.net/view/Test_grinder/job/Grinder/8994/ do not publish them

if any GC fails, or (in case of churn_custom) user put in ninsense, it will make the job red.

Is it ok, or should some other logic be added, to make it unstable?

Will this suite ( I guess the churn_5h_allGCs target) be part of any regular aqa runs in public jenkins?

if so, to which, if not by default, but is desired can I add it somewhere?

The 050fb07 , overwritten as 2249bc0 now works.
Am now updating readme to reflect the state. Will lift draft (thanx for setting it up) once done
Two new questions
* the suite now generates next to jtreg archive also nice tap file. Is any special step needed to make it visible?

  * https://ci.adoptium.net/view/Test_grinder/job/Grinder/8994/ do not publish them

hmm.. https://ci.adoptium.net/view/Test_grinder/job/Grinder/8994/tapResults/they are here! thoughts? I'm not sure what I did...

re: https://github.com/adoptium/aqa-tests/pull/5101#issuecomment-1969567366 - you did not need to do anything, our test pipelines always generate TAP files that include all test targets ( all <test><testCaseName> ... </test> entries defined in playlists).  It is a feature of our TKG layer to create the TAP file, and a feature of our Jenkins groovy scripts to then attach the TAP files to the Jenkins job as an artifact.

if any GC fails, or (in case of churn_custom) user put in ninsense, it will make the job red.
Is it ok, or should some other logic be added, to make it unstable?

Yes, we will add this test target with a disable tag, since it is there to support development, it can be used in Grinder jobs, and will be skipped in automated / regular test runs.

Will this suite ( I guess the churn_5h_allGCs target) be part of any regular aqa runs in public jenkins?
if so, to which, if not by default, but is desired can I add it somewhere?

Yes, it will get run against our EA builds which get triggered whenever a new upstream tag is available (so approximately weekly for each JDK version).  Since we are adding this into dev level, and system group, the 2 enabled test targets in your playlist, churn_1m_allGCs and churn_5h_allGCs, will get run in our *dev.system* test jobs.  I have asked you to restrict the test targets to just eclipse and redhat vendors for now, as I do not want to impact other vendors test execution times and also do not think other vendors are shipping with Shenandoah enabled.

re: #5101 (comment) - you did not need to do anything, our test pipelines always generate TAP files that include all test targets ( all <test><testCaseName> ... </test> entries defined in playlists). It is a feature of our TKG layer to create the TAP file, and a feature of our Jenkins groovy scripts to then attach the TAP files to the Jenkins job as an artifact.

Well, yes. With all pros and cons. There is usually one tap file, which consider the whole testsuite as on test.  Then find properly what really run/failed inside is quite a detective task(but most liekly it is lack of my insight). Where the one default generated tap file is awesome feature, the suites usually generates much better outputs, and should be allowed to publish it.
In this case, the tap file churn generates is pretty good, and as the tkg toolchain is picking up all taps, it is pretty usable (feel free to correct me, or tell me to not generate it).

if any GC fails, or (in case of churn_custom) user put in ninsense, it will make the job red.
Is it ok, or should some other logic be added, to make it unstable?

Yes, we will add this test target with a disable tag, since it is there to support development, it can be used in Grinder jobs, and will be skipped in automated / regular test runs.

Will this suite ( I guess the churn_5h_allGCs target) be part of any regular aqa runs in public jenkins?
if so, to which, if not by default, but is desired can I add it somewhere?

Yes, it will get run against our EA builds which get triggered whenever a new upstream tag is available (so approximately weekly for each JDK version). Since we are adding this into dev level, and system group, the 2 enabled test targets in your playlist, churn_1m_allGCs and churn_5h_allGCs, will get run in our *dev.system* test jobs.

Thanx!

I have asked you to restrict the test targets to just eclipse and redhat vendors for now, as I do not want to impact other vendors test execution times and also do not think other vendors are shipping with Shenandoah enabled.

IIRC, shenandoah is enabled everywhere except jdk8 by default, so they would need to manually disable it during build.   But why would anybody disable best GC around?
In case of shenandoah, especially because of its 'not-present' in jdk8, I will make it more dynamic. I can exclude GCs from default list based on :XX listings Will elaborate. It do not need to block this PR, only once it is created, other vendors may be onboarded.

It do not need to block this PR, only once it is created, other vendors may be onboarded.
Yes, my thought with all of my review comments was to get the PR in and then come back later to adjust after we have run it for a while at the project.

There is usually one tap file, which consider the whole testsuite as on test. Then find properly what really run/failed inside is quite a detective task(but most liekly it is lack of my insight). Where the one default generated tap file is awesome feature, the suites usually generates much better outputs, and should be allowed to publish it.  In this case, the tap file churn generates is pretty good, and as the tkg toolchain is picking up all taps, it is pretty usable (feel free to correct me, or tell me to not generate it).

The TAP file is produced to 'normalize' test results from all suites.  Having TAP files that do something different moves us away from normalization.  For more granular information, we would look to test suites producing some sort of JUnit style output and then also present that.

There is usually one tap file, which consider the whole testsuite as on test. Then find properly what really run/failed inside is quite a detective task(but most liekly it is lack of my insight). Where the one default generated tap file is awesome feature, the suites usually generates much better outputs, and should be allowed to publish it.  In this case, the tap file churn generates is pretty good, and as the tkg toolchain is picking up all taps, it is pretty usable (feel free to correct me, or tell me to not generate it).

The TAP file is produced to 'normalize' test results from all suites. Having TAP files that do something different moves us away from normalization. For more granular information, we would look to test suites producing some sort of JUnit style output and then also present that.

I see. The churn generates both tap file and packed junit file. So Your recomndation is to stop generating tap file? (no problem on my side, only I liked it :) )

It do not need to block this PR, only once it is created, other vendors may be onboarded.

Yes, my thought with all of my review comments was to get the PR in and then come back later to adjust after we have run it for a while at the project.

Sure. Thank you very much! Highly appreciated.

I had followed you review everywhere except the CHURN_DURATION. How do you feel about it?
I think we may enable more venodrs, but it is up to you, the requested chnage is done
readme updated
custom tap is no longer geenrated (/me very sad)
GH actions are passing all three OSes. But it is msys2 for windows on them, in grinder it is cygwin, and it fails there. Thoughts?
no mac run finished up to now (still waiting for executor).

thus saying, I would :

 		<platformRequirementsList>
 			<platformRequirements>os.linux</platformRequirements>
-			<platformRequirements>os.win</platformRequirements>
-			<platformRequirements>os.osx</platformRequirements>
 		</platformRequirementsList>

wdyt?
Do you se enay more obstacles?

The tests might need to move to system/ folder instead of functional/ folder if we'd like to trigger the tests automatically as part of jenkins test builds of dev.system. It  does work in grinder under functional/ folder as in grinder we can manually set buildList=functional/churn, however in jenkins dev.system jobs buildList=system.

The tests might need to move to system/ folder instead of functional/ folder if we'd like to trigger the tests automatically as part of jenkins test builds of dev.system. It does work in grinder under functional/ folder as in grinder we can manually set buildList=functional/churn, however in jenkins dev.system jobs buildList=system.

Good catch, we started off with this in functional group, but because it is a stress/load test, it is more appropriate to add it to system, so better to shift the churn folder into the system folder. +1

GH actions are passing all three OSes. But it is msys2 for windows on them, in grinder it is cygwin, and it fails there. Thoughts?

Does the test require MVN? The output says 07:15:38  + which mvn 07:15:38  which: no mvn  so no classes generated and failed.

GH actions are passing all three OSes. But it is msys2 for windows on them, in grinder it is cygwin, and it fails there. Thoughts?

Does the test require MVN? The output says 07:15:38 + which mvn 07:15:38 which: no mvn  so no classes generated and failed.

Default build system is maven. But if it is not found, javac would do. So that is this case, it is compiled directly by javac.

I see. It's a issue with window path and cygwin path.
+ E:/workspace/Grinder/jdkbinary/j2sdk-image/bin/javac -d /cygdrive/e/workspace/Grinder/aqa-tests/functional/churn/churn/target/classes ./org/jboss/churn/LogHistogram.java ./org/jboss/churn/TestRunner.java ./org/jboss/churn/WorkItem.java ./org/jboss/churn/WorkItemMap.java
07:15:40  + pushd /cygdrive/e/workspace/Grinder/aqa-tests/functional/churn/churn/target/classes
07:15:40  E:/workspace/Grinder/aqa-tests/\functional\churn\churn\run.sh: line 183: pushd: /cygdrive/e/workspace/Grinder/aqa-tests/functional/churn/churn/target/classes: No such file or directory

You might need to use cygpth -w to print Windows form of directory of /cygdrive/e/workspace/Grinder/aqa-tests/functional/churn/churn/target/classes and probably other cygwin paths too.

Mac looks good https://ci.adoptium.net/view/Test_grinder/job/Grinder/9033/console

For cygwin "$OS" =~ CYGWIN*  you might need to use cygpth -w to print Windows form of directory of /cygdrive/e/workspace/Grinder/aqa-tests/functional/churn/churn/target/classes and also for any other cygwin paths.

Right yiou are, https://github.com/rh-openjdk/churn/pull/24 was all waht was needed. Rerunning windows.
Thanx a lot for info of mack! saved me some search :)

It do not need to block this PR, only once it is created, other vendors may be onboarded.

Yes, my thought with all of my review comments was to get the PR in and then come back later to adjust after we have run it for a while at the project.

Sure. Thank you very much! Highly appreciated.
* I had followed you review everywhere except the CHURN_DURATION. How do you feel about it?

* I think we may enable more venodrs, but it is up to you, the requested chnage is done

* readme updated

* custom tap is no longer geenrated (/me very sad)

* GH actions are passing all three OSes. But it is msys2 for windows on them, in grinder it is cygwin, and it [fails](https://ci.adoptium.net/view/Test_grinder/job/Grinder/9034/tapResults/) there. Thoughts?

* no mac run finished up to now (still waiting for executor).

  * thus saying, I would :

 		<platformRequirementsList>
 			<platformRequirements>os.linux</platformRequirements>
-			<platformRequirements>os.win</platformRequirements>
-			<platformRequirements>os.osx</platformRequirements>
 		</platformRequirementsList>

^ no longer necessary.

wdyt?
Do you se enay more obstacles?

I guess the disable of  churn_custom target will happen as last thing in this commit once everything else is tunned

Rerunning windows.

The new failure was related with migration from functional to system, I'm hitting the same issue with reproducible comparing tests. I can take a look next Monday.

Gosh. Rerunning windows here: https://ci.adoptium.net/view/Test_grinder/job/Grinder/9038/
mac: https://ci.adoptium.net/view/Test_grinder/job/Grinder/9039/
linux: https://ci.adoptium.net/view/Test_grinder/job/Grinder/9040/

@sophia-guo  TY!
@smlambert  one approval reached, do you have any more hints?

authors: judovana smlambert sophia-guo

repo: adoptium/aqa-tests


text:
Add bisheng jdk8 configuration on Aarch64Linux to enable kae

As the title says, just add a configuration.

I've just tried to build with that option and it seems to result in compilation failures - is that expected at the moment? These are the first errors but there are a lot more in the log - is this expected? I would be reluctant to approve this if it will destabilise the builds
/home/sxa/openjdk-build/build-farm/workspace/build/src/jdk/src/share/native/java/lang/fdlibm/src/e_asin.c: In function '__j__ieee754_asin':
/home/sxa/openjdk-build/build-farm/workspace/build/src/jdk/src/share/native/java/lang/fdlibm/src/e_asin.c:101:15: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
             } else
               ^~~~

could I check the full log?

repo: adoptium/ci-jenkins-pipelines


text:
added test case for Test UserGroupsClient , iter_group_members Definations

for below Issue
https://github.com/adorton-adobe/user-sync.py/issues/23

@shasibhusanJena - please don't merge PRs until Kevin and I have had a chance to review.

You are absolutely correct, I wanted to do only pull request, but somehow I clicked on the merge button.
I will go with this best on next commit.

authors: adorton-adobe shasibhusanJena