text:
I can't scan the ean 13 code

I can't scan the produced ean-13 barcode. This is my code:
`include 'barcode.php';
$format = 'png';
$symbology = 'ean-13-pad';
$data = '978020137963';
$options = '';
$generator = new barcode_generator();
$name = "test";
/* Create bitmap image. */
$image = $generator->render_image($symbology, $data, $options);
header( "Content-type: image/png" );
imagepng($image);
$save = strtolower($name) .".png";
chmod($save,0755);
imagepng($image, $save, 0, NULL);
imagedestroy($image);
`

I think u r missing the last check Digit!
so far as I see it generates barcodes with the numbers you type in but it do not calculate the checkout for the end!

include 'barcode.php';

$generator = new barcode_generator();

if (!empty($_POST["barcode"])) {
	$code= $_POST["barcode"];
	$targetPath = __DIR__ .'\barcode';
        $format='png';
        $symbology='ean-13-PAD';
        $options= '';
        $name = "test";

       file_put_contents( 'C:\temp\logs\debug_barcodes_' . time() . '.log', var_export( $code, true), FILE_APPEND);

	if (!is_dir($targetPath)) {
	   file_put_contents(  'C:\temp\logs\debug_barcodes_' . time() . '.log' . time() . '.log', var_export( ' No Directory - Creating One - '.
           $targetPath, true), FILE_APPEND);
            mkdir($targetPath, 0777, true);
    } else {
		chmod($targetPath,0755);
	        file_put_contents(  'C:\temp\logs\debug_barcodes_' . time() . '.log', var_export(' NOT CREATING  DIRECTORY AS  ****** IT
              ALREADY EXISTS ****** '. $targetPath, true), FILE_APPEND);
	}

	/* Generate PNG and write to file. */

	header("Content-Type:image/$format");
	$image = $generator->render_image($symbology, $code, $options);
	$save = strtolower($name).".png";
	chmod($save,0755);
        imagepng($image, $save, 0, NULL);
        imagedestroy($image);
	//$svg = $generator->render_svg($symbology,$code,$options);
        //echo $svg;
	///file_put_contents($targetPath , $svg);

 }

source: gharchive/issue

authors: ambientguitar cwstrmnn hASebUh

repo: kreativekorp/barcode

license: MIT

license_type: permissive

license_source: github-api


text:
Json files for OCD

HI are the train.json and val.json files available?
_convert_dict: true
_fields:
  annotations: /media/data/philipp_data/COCOstuff/annotations_virtualhome_compatible/train.json
  batch_size: 16
  checkpoint: null
  git: 6910dabbb50d4b103bbd85df6f5a78fff1834161
  imagedir: /media/data/philipp_data/COCOstuff/images/train/
  imbalance_reweighting: false
  learning_rate: 1.0e-05
  num_classes: 15
  num_decoder_heads: 8
  num_decoder_layers: 6
  test_annotations: /media/data/philipp_data/COCOstuff/annotations_virtualhome_compatible/val.json
  test_imagedir: /media/data/philipp_data/COCOstuff/images/val/
  uncertainty_gate_type: learned
  uncertainty_threshold: 0.0
  weighted_prediction: false
_locked: false
_type_safe: true```

all annotation files for train and test are uploaded now. See README page for download link

repo: kreimanlab/WhenPigsFlyContext


text:
CameraView ignore ZOffset

I set CameraView and Panel like below and I expect 'over' panel will be over on top, but it's not.
<App>
	<Panel Background="#00f">
		<NativeViewHost>
			<CameraView ux:Name="cameraView" Facing="Back"/>
		</NativeViewHost>
		<Panel ux:Name="over" Y="0" Height="50%" Background="#0f0" ZOffset="3"/>
	</Panel>
</App>

Preview on destktop

Preview on Android

Mistake. Layers have to be in <NativeViewHost/> to be overlaid.
Sorry!

repo: krisk/Fuse

license_source: bigquery


text:
q.allDone - a combination of q.all and q.allSettled

Although it's pretty straightforward to monkey path the library, I've noticed a need for a function like the one below.
/**
 * A combination of q.allSettled and q.all. It works like q.allSettled in the sense that
 * the promise is not rejected until all promises have finished and like q.all in that it
 * is rejected with the first encountered rejection and resolves with an array of "values".
 *
 * The rejection is always an Error.
 * @param promises
 * @returns {*|promise}
 */
q.allDone = function (promises) {
    var deferred = q.defer();
    q.allSettled(promises)
        .then(function (results) {
            var i,
                values = [];
            for (i = 0; i < results.length; i += 1) {
                if (results[i].state === 'rejected') {
                    deferred.reject(new Error(results[i].reason));
                    return;
                } else if (results[i].state === 'fulfilled') {
                    values.push(results[i].value);
                } else {
                    deferred.reject(new Error('Unexpected promise state ' + results[i].state));
                    return;
                }
            }
            deferred.resolve(values);
        });

    return deferred.promise;
};

I find this useful. I have it as a common utility in my projects.

authors: pmeijer ramongilmoreno

repo: kriskowal/q

license: mit


text:
Line is below Bars

Hi, I'm using multiChart and I have a problem that the line is below the bars.
Is there any way to change the order that the line will be in front ?

The reason is because i cant see the line tooltips when it below the bars...
Thanks

Hello oshri551,
I used the following code to reorder the elements in the DOM, so that the lines appear behind the bars
// Puts the lines at the forefront in the Incidents multichart
// The timeout lets nvd3 the time to draw the graph```
setTimeout((function() {
  d3.select('#my-chart.lines1Wrap').moveToFront();
}), 100);

d3.selection.prototype.moveToFront = function() {
  return this.each(function() {
    this.parentNode.appendChild(this);
  });
};


text:
fix: stop Utils#createTopic trying to create topic if admin client gets closed

Type of change

Bugfix

Description
Break out of the createTopic creation loop if the RetriableException message indicates that the Admin client is closed.  This prevents a thread pointlessly spinning in the background, failing forever.
Please describe your pull request
Additional Context
Why are you making this pull request?
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

@SamBarker what do you think to committing this change?  I think in the long term, the Kafka Client needs a fix, but this would improve the behaviour in the meanwhile.

I'll comment the nastiness with a note about https://issues.apache.org/jira/browse/KAFKA-15507. Hopefully we can kill the code one day.

source: gharchive/pull-request


text:
Review documentation

Go over our documentation and check we have covered:

user activities like security configuration.
concepts approachable for new users

Generate further tickets if we find gaps. Could be a good group activity.

We are going to follow up on this in another channel.

authors: k-wall robobario

repo: kroxylicious/kroxylicious


text:
Switch to Angular CLI build process

Upgrading the library to newer versions of Angular is painful because it was created at a time when the Angular CLI was not around.
Switching the current manual build process using tsc, ngc and rollup to the Angular CLI should hopefully lead to easier upgrades.

The demo already uses the Angular CLI, but fails the build system migration because it does not have a tsconfig.json.
It might make sense to migrate over both the library and the demo to a clean new Angular CLI project.


text:
Not displaying

I set it up like below
#if DEBUG
	LifetimeTracker.setup(onUpdate: LifetimeTrackerDashboardIntegration(visibility: .alwaysVisible, style: .bar).refreshUI)
#endif

and its not working

Me too!

+1

iOS version?

Xcode 12.2
On Sun, 29 Nov 2020 at 10:52 AM Krzysztof Zabłocki notifications@github.com
wrote:

iOS/Xcode version?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/krzysztofzablocki/LifetimeTracker/issues/66#issuecomment-735357312,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADM4W6MFQZTRBQ6HEYBSBPLSSH4TTANCNFSM4S7Z3F4Q
.

Did you implement LifetimeTrackable at least once ? It doesn't show if you don't have any LifetimeTrackable

+1

+1
I've implemented LifetimeTrackable and setup lifetimeConfiguration and it still doesn't show up.

My Xcode version is 14.1 and I use pods 1.8.1
I have added the integration code in SceneDelegate:
func scene(_ scene: UIScene, willConnectTo session: UISceneSession, options connectionOptions: UIScene.ConnectionOptions) {

        guard let windowScene = (scene as? UIWindowScene) else { return }
        let window = UIWindow(windowScene: windowScene)
        let viewController = ViewController()
        window.rootViewController = viewController
        self.window = window
        #if DEBUG
        LifetimeTracker.setup( onUpdate: LifetimeTrackerDashboardIntegration(visibility: .alwaysVisible,style: .bar).refreshUI)
        #endif
        window.makeKeyAndVisible()
    }

I add a button on my ViewController to create leaks
class ViewController: UIViewController, LifetimeTrackable {
    static var lifetimeConfiguration: LifetimeConfiguration {
        return LifetimeConfiguration(maxCount: 1, groupName: "VC")
    }

    override init(nibName nibNameOrNil: String?, bundle nibBundleOrNil: Bundle?) {
        super.init(nibName: nibNameOrNil, bundle: nibBundleOrNil)
        trackLifetime()
    }

    required init?(coder: NSCoder) {
        super.init(coder: coder)
        trackLifetime()
    }

    override func viewDidLoad() {
        super.viewDidLoad()
        addButton()
    }

    func addButton() {
        button.setTitle("Create Leaks", for: .normal)
        button.addTarget(self, action: #selector(createLeaks), for: .touchUpInside)
        view.addSubview(button)
        button.snp.makeConstraints {
            $0.width.equalTo(100)
            $0.height.equalTo(20)
            $0.center.equalToSuperview()
        }
    }

    @objc func createLeaks() {
        var a: AClass? = .init()
        var b: BClass? = .init()
        a?.b = b
        b?.a = a
        a = nil
        b = nil
    }

    private let button = UIButton()

}

The two classes simply look like this:
class AClass {
    var b: BClass?
    deinit {
        print("A deinits")
    }
}

class BClass {
    var a: AClass?
    deinit {
        print("B deinits")
    }
}

When I click the button the visual notification doesn't show up.

You are not leaking the object you are tracking (VC)

I see. I tried to track the leaking objects like this
class AClass: LifetimeTrackable {
    static var lifetimeConfiguration: LifetimeConfiguration {
        return LifetimeConfiguration(maxCount: 1, groupName: "AClass")
    }

    init() {
        trackLifetime()
    }

    var b: BClass?

    deinit {
        print("A deinits")
    }
}

class BClass: LifetimeTrackable {
    static var lifetimeConfiguration: LifetimeConfiguration {
        return LifetimeConfiguration(maxCount: 1, groupName: "BClass")
    }

    init() {
        trackLifetime()
    }

    var a: AClass?

    deinit {
        print("B deinits")
    }
}

But it crashes as soon as I click the button because 'Could not find a storyboard named 'BarDashboard' in bundle'. Do I have to do other settings to make it work?

Try pinning 1.8.0 instead of newest tag, since there seems to be some regression in 1.8.1

1.8.0 works fine
Thanks~

Hi. I've been faced with the same issue.
Xcode Version - 14.3
Swift Language Version - Swift 5
LifetimeTracker Version - 1.8.0 (Swift Package Manager)
In SceneDelegate file,
#if DEBUG         LifetimeTracker.setup(onUpdate: LifetimeTrackerDashboardIntegration(visibility: .alwaysVisible, style: .circular).refreshUI)     #endif
In ViewController file,
    static var lifetimeConfiguration: LifetimeConfiguration {
        return LifetimeConfiguration(maxCount: 1, groupName: "VC")
    }

    override init(nibName nibNameOrNil: String?, bundle nibBundleOrNil: Bundle?) {
        super.init(nibName: nibNameOrNil, bundle: nibBundleOrNil)
        trackLifetime()
    }

    required init?(coder: NSCoder) {
        super.init(coder: coder)
        trackLifetime()
    }

Dashboard never appears 😢
I need some help.

There was initial showing bug that I just fixed in 1.8.2

authors: PinYuanChen ajacquelin elemanhillary elemanhillary-zz eunbijang krzysztofzablocki mickaelhero moo611 plusend

repo: krzysztofzablocki/LifetimeTracker


text:
Error Domain=NSCocoaErrorDomain Code=4 "“SwiftTemplate” couldn’t be moved to “Mock.swifttemplate”

Hi,
I have a following issue with Xcode 10.2, Mac OS Mojave 10.14.4, and Sourcery 0.16.0.
$ sourcery --config mocky.yml

error: Error Domain=NSCocoaErrorDomain Code=4 "“SwiftTemplate” couldn’t be moved to “Mock.swifttemplate” because either the former doesn’t exist, or the folder containing the latter doesn’t exist." UserInfo={NSSourceFilePathErrorKey=/var/folders/5b/qxxx85bn0qq9yr6zqdvxv66r0000gp/T/SwiftTemplate/0.16.0/.build/debug/SwiftTemplate, NSUserStringVariant=(
    Move
), NSDestinationFilePath=/Users/brannpark/Library/Caches/Sourcery/Mock.swifttemplate/5Dp3a9vTHHHYxDu9t5KHfVXiVAsjOAEWk3HrPc2Gnbg%3D, NSFilePath=/var/folders/5b/qxxx85bn0qq9yr6zqdvxv66r0000gp/T/SwiftTemplate/0.16.0/.build/debug/SwiftTemplate, NSUnderlyingError=0x7fe69eac3a00 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}
Error Domain=NSCocoaErrorDomain Code=4 "“SwiftTemplate” couldn’t be moved to “Mock.swifttemplate” because either the former doesn’t exist, or the folder containing the latter doesn’t exist." UserInfo={NSSourceFilePathErrorKey=/var/folders/5b/qxxx85bn0qq9yr6zqdvxv66r0000gp/T/SwiftTemplate/0.16.0/.build/debug/SwiftTemplate, NSUserStringVariant=(
    Move
), NSDestinationFilePath=/Users/brannpark/Library/Caches/Sourcery/Mock.swifttemplate/5Dp3a9vTHHHYxDu9t5KHfVXiVAsjOAEWk3HrPc2Gnbg%3D, NSFilePath=/var/folders/5b/qxxx85bn0qq9yr6zqdvxv66r0000gp/T/SwiftTemplate/0.16.0/.build/debug/SwiftTemplate, NSUnderlyingError=0x7fe69eac3a00 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}%

I tried to clean ~/Library/Caches/Sourcery, /var/folders/5b/qxxx85bn0qq9yr6zqdvxv66r0000gp/T/SwiftTemplate, but nothing helped.
The SourceFile(or directory?) "/var/folders/5b/qxxx85bn0qq9yr6zqdvxv66r0000gp/T/SwiftTemplate/0.16.0/.build/debug/SwiftTemplate" does not exist on that path. I have no idea how to fix it.
sourcery --config mocky.yml --disableCache  also makes error with following stacktrace.
2019-04-03 18:51:06.232 sourcery[67652:12198726] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'launch path not accessible'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007fff2eaeccf9 __exceptionPreprocess + 256
	1   libobjc.A.dylib                     0x00007fff59681a17 objc_exception_throw + 48
	2   CoreFoundation                      0x00007fff2eaecb2b +[NSException raise:format:] + 201
	3   Foundation                          0x00007fff30cd299f -[NSConcreteTask launchWithDictionary:error:] + 1291
	4   sourcery                            0x000000010186f313 $SSo6NSTaskC13SourcerySwiftE10runCommand33_97A733547C26B01DA3FEDC2EDE49AED9LL4path9arguments11environment20currentDirectoryPathAC13ProcessResultAELLVSS_SaySSGSDyS2SG0R3Kit0R0VSgtKFZTf4xnnnd_n + 1923
	5   sourcery                            0x000000010186a10b $S13SourcerySwift0B8TemplateC6renderySSypKF + 907
	6   sourcery                            0x00000001017a44b2 $S13SourcerySwift0B8TemplateC0A9Framework0C00A0AdEP6renderySS0A7Runtime0C7ContextCKFTW + 66
	7   sourcery                            0x00000001017c43c9 $S17SourceryFramework9GeneratorO8generate_8template9argumentsSS0A7Runtime5TypesC_AA8Template_pSDySSSo8NSObjectCGtKFZ + 425
	8   sourcery                            0x00000001017a981a $S8SourceryAAC8generate33_DB5C4364BFA94633EE953DD412A08C30LL_16forParsingResult10outputPathSS0A9Framework8Template_p_0A7Runtime5TypesC5types_SaySS4file_SDySSSo8_NSRangeVG6rangesSDyS2SG12indentationstG12inlineRangest0N3Kit0N0VtKF + 826
	9   sourcery                            0x00000001017b9cf2 $S8SourceryAAC8generate33_DB5C4364BFA94633EE953DD412A08C30LL6source13templatePaths6output13parsingResultyAA6SourceO_AA0L0VAA6OutputV0A7Runtime5TypesC5types_SaySS4file_SDySSSo8_NSRangeVG6rangesSDyS2SG12indentationstG12inlineRangesttKFy0A9Framework8Template_pKXEfU_Tf4nnxn_n + 98
	10  sourcery                            0x00000001017ba2d1 $S8SourceryAAC8generate33_DB5C4364BFA94633EE953DD412A08C30LL6source13templatePaths6output13parsingResultyAA6SourceO_AA0L0VAA6OutputV0A7Runtime5TypesC5types_SaySS4file_SDySSSo8_NSRangeVG6rangesSDyS2SG12indentationstG12inlineRangesttKFTf4dxnnnn_n + 881
	11  sourcery                            0x00000001017bb6c6 $S8SourceryAAC12processFiles_14usingTemplates6output10forceParseSayAA13FolderWatcherO5LocalCGSgAA6SourceO_AA5PathsVAA6OutputVSaySSGtKF0A7Runtime5TypesC5types_SaySS4file_SDySSSo8_NSRangeVG6rangesSDyS2SG12indentationstG12inlineRangestANKcfU1_Tf4nnnxn_n + 3542
	12  sourcery                            0x00000001017bc663 $S8SourceryAAC12processFiles_14usingTemplates6output10forceParseSayAA13FolderWatcherO5LocalCGSgAA6SourceO_AA5PathsVAA6OutputVSaySSGtKFTf4nxnnn_n + 1843
	13  sourcery                            0x0000000101783048 $S8Sourcery6runCLIyyFySb_S4bSay7PathKit0D0VGA3f2ESaySSGAgEtcfU_ + 2232
	14  sourcery                            0x0000000101783680 $SS5bSay7PathKit0A0VGA3d2CSaySSGAeCs5Error_pIegyyyyyggggnnggnzo_S5bA4d2c2eCsAF_pIegnnnnnnnnnnnnnnzo_TR032$S8Sourcery6runCLIyyFySb_S4bSay7A27Kit0D0VGA3f2ESaySSGAgEtcfU_Tf3nnnnnnnnnnnnnnpf_n + 80
	15  sourcery                            0x00000001016ee346 $S9Commander7commandyAA11CommandType_px_q_q0_q1_q2_q3_q4_q5_q6_q7_q8_q9_q10_q11_y05ValueD0Qz_ADQy_ADQy0_ADQy1_ADQy2_ADQy3_ADQy4_ADQy5_ADQy6_ADQy7_ADQy8_ADQy9_ADQy10_ADQy11_tKctAA18ArgumentDescriptorRzAaSR_AaSR0_AaSR1_AaSR2_AaSR3_AaSR4_AaSR5_AaSR6_AaSR7_AaSR8_AaSR9_AaSR10_AaSR11_r12_lFyAA0F6ParserCKcfU_ + 4518
	16  sourcery                            0x00000001016ee657 $S9Commander7commandyAA11CommandType_px_q_q0_q1_q2_q3_q4_q5_q6_q7_q8_q9_q10_q11_y05ValueD0Qz_ADQy_ADQy0_ADQy1_ADQy2_ADQy3_ADQy4_ADQy5_ADQy6_ADQy7_ADQy8_ADQy9_ADQy10_ADQy11_tKctAA18ArgumentDescriptorRzAaSR_AaSR0_AaSR1_AaSR2_AaSR3_AaSR4_AaSR5_AaSR6_AaSR7_AaSR8_AaSR9_AaSR10_AaSR11_r12_lFyAA0F6ParserCKcfU_TA + 279
	17  sourcery                            0x00000001016db343 $S9Commander16AnonymousCommandVAA0C4TypeA2aDP3runyyAA14ArgumentParserCKFTW + 51
	18  sourcery                            0x00000001016db793 $S9Commander11CommandTypePAAE3runys5NeverOSSSgF + 403
	19  sourcery                            0x000000010178278a $S8Sourcery6runCLIyyF + 2314
	20  sourcery                            0x00000001017811fd main + 61
	21  libdyld.dylib                       0x00007fff5aeaf3d5 start + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException

Any idea?

lets move this discussion to the existing ticket because this is duplicate of #745

authors: brannpark krzysztofzablocki

repo: krzysztofzablocki/Sourcery


text:
Egen formatter for logstash

Kopiert fra og gjort på samme måte som for digiorden.

LGTM :+1:

authors: danielannan jarleborsheim

repo: ks-no/fiks-protokoll-validator


text:
Remove cluster level list/watch for configmaps, serviceaccounts, secrets

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3467
Fixes #366
Type of changes
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[ ] Test A

[ ] Test B

Logs

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

Remove cluster level list/watch for configmaps, serviceaccounts, secrets

@israel-hdez Can you help test whether this fixes the out-of-memory issue ?

@israel-hdez Can you help test whether this fixes the out-of-memory issue ?

@sivanantha321 I still replicating the setup. I tried today, and my cluster died while on it.
I'll re-try on my Friday.

@sivanantha321 Could you point me to where you removed the list calls for secrets? Perhaps I missed it somewhere but I only see the removal from manifests.

We are not using list calls in the code base.

I've just replicated the OOMKill with master branch to ensure I have the needed setup.
I used a script from @skonto available in this gist: https://gist.github.com/skonto/188b2c45c5af449629caaa69a190392c, with a minor modification: edit line 3 to NC=64, because that was enough in my environment.
I'm now trying the code changes in this PR.

I confirm the kserve-controller pod no longer crashes with OOMKill.
I'll do code review soon.
Notice that I only tried around Secrets which is what I reported in #3467. I didn't try the other resources.

We are not using list calls in the code base.

I meant "list/watch for secrets" as described in the PR title but thanks I got it now.

/lgtm

Per request in prow comment:
/assign @rachitchauhan43

I pinged Rachit previously.
But now I'm also pinging @yuzisun in case Rachit is not available.

Looks like lots of imports reorganization happened in this PR. @sivanantha321 : Possible to add as an action itself that fails if imports are not as per standard in go files ?

Also, @israel-hdez , if we have reproducibility, what do you think of adding a test case to make sure regression always catches such issues  ?

Also, @israel-hdez , if we have reproducibility, what do you think of adding a test case to make sure regression always catches such issues ?

@rachitchauhan43 I do know how to reproduce, but IMO that should be solved under its own ticket, because we would need to find a way to replicate within CI -- I crashed my dev cluster a few times before I could replicate successfully, so what I did on my device may not be suitable for GitHub Actions. And, of course, we would need to ensure all relevant code paths are covered.

Also, @israel-hdez , if we have reproducibility, what do you think of adding a test case to make sure regression always catches such issues ?

@rachitchauhan43 I do know how to reproduce, but IMO that should be solved under its own ticket, because we would need to find a way to replicate within CI -- I crashed my dev cluster a few times before I could replicate successfully, so what I did on my device may not be suitable for GitHub Actions. And, of course, we would need to ensure all relevant code paths are covered.

Actually, I think contributors and reviewers should be careful when a watch or list privilege is being added to the RBAC role ---and this cannot be covered by tests.
This PR is around ConfigMaps, ServiceAccounts and Secrets and is already removing the no longer needed privileges. But any resource that the controller is watching may lead to an OOMKill, if the watch/informer fills the available memory.

Looks like lots of imports reorganization happened in this PR. @sivanantha321 : Possible to add as an action itself that fails if imports are not as per standard in go files ?

We can do it in a separate PR as many files requires reorganization.

Looks like lots of imports reorganization happened in this PR. @sivanantha321 : Possible to add as an action itself that fails if imports are not as per standard in go files ?

We can do it in a separate PR as many files requires reorganization.

Sure, I meant that only. Don't want to have multi-purpose PR.

Also, @israel-hdez , if we have reproducibility, what do you think of adding a test case to make sure regression always catches such issues ?

@rachitchauhan43 I do know how to reproduce, but IMO that should be solved under its own ticket, because we would need to find a way to replicate within CI -- I crashed my dev cluster a few times before I could replicate successfully, so what I did on my device may not be suitable for GitHub Actions. And, of course, we would need to ensure all relevant code paths are covered.

Agreed.  Please create separate ISsue for that.

/lgtm

repo: kserve/kserve


text:
Bump ubi8 tag to 8.8

chore: update ubi8-minimal to latest version, 8.8. Vulnerabities fixed:

RHSA-2023:7165: cups security and bug fix update (Moderate)
RHSA-2023:7151: python3 security update (Moderate)
RHSA-2023:7176: python-pip security update (Moderate)
RHSA-2023:7151: python3 security update (Moderate)
RHSA-2023:7190: avahi security update (Moderate)
RHSA-2023:7112: shadow-utils security and bug fix update (Low)

Motivation
Modifications
Result

@njhill This is still missing a /lgtm (using a handlebar)

authors: israel-hdez spolti

repo: kserve/modelmesh


text:
Shift Down breaks the selected text

select: Comment a1 = new Comment(1, null);
Shift Down
result: null);, Comment a1 = new Comment(1

Shifter (mis)categorizes this selection as a comma-separated list and sorts the items alphabetically.
Please let me know which sort of alteration (and categorization of the selection) you would expect on this selection, maybe it helps me improve shifter.

Oh yeah I forgot that it sorts, I expected this result: Comment a0 = new Comment(0, null);
I also forgot that such result can be produced by "my" String Manipulation plugin :-)
Making sorting and incrementing work together for any case in one action is impossible. You would have to introduce an action which would only increment any number occurrences - which might be something that nobody needs :)

authors: krasa kstenschke

repo: kstenschke/shifter-plugin


text:
Grid Width

how can I set the width of the grid?
And 'possible to set the width also in relation with the width of the page? so that the cells can move to the next line if you end up out the window?
thanks

you can use the param of the demo like this:
$('.gridly').gridly({
base: 60, // px
gutter: 8, // margin  px
columns: 12 // width;This is not strictly a wide
});
you can try it

repo: ksylvest/jquery-gridly


text:
🛑 Jenkins is down

In 24d5ba7, Jenkins (http://build.chelsea.kt.co.kr) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Jenkins is back up in 61b7621.

Resolved: Jenkins is back up in 61b7621.

repo: kt-chelsea/status


text:
Shippable support

Do you have any plan to support Shippable?

I don't for the moment. I suppose the generic way to set repo_token does work in usual CI services.
Do you have any issue on Shippable?

When building on Shippable, the plugin detected the environment is Travis while it is not. I'm not sure why but Shippable does have these environment variables:
export TRAVIS=true;
export SHIPPABLE=true;

What does Shippable have for CI_NAME env var? If you can override it as shippable, then it should work correctly..

I'm using 2.0.1x. I did override it with Shippable but it doesn't work.
On Fri, Jul 10, 2015 at 9:26 PM Yoshiya Hinosawa notifications@github.com
wrote:

What does Shippable have for CI_NAME env var? If you can override it as
shippable, then it should work correctly..
—
Reply to this email directly or view it on GitHub
https://github.com/kt3k/coveralls-gradle-plugin/issues/46#issuecomment-120421940
.


text:
Implement the basic Liar's Dice game

The general rules of the game should follow the first variant present on wikipedia. AdB -> (A+1)dB | Ad(B+1) | (A+1)d(B+1)
Implement the betting choices the player can do every turn as clickable buttons.
Make a nice animation for shaking the dice inside a cup.

Closing due to rebasing everything

license: Unlicense


text:
[2.0.0] 공지 공유하기

개요
기능에 대한 설명 도입부
공지 공유하기
1.x 버전과 동일하게.
다만 딥링크 지원 여부 서버와 논의 하기
디자인
스크린샷이나 다이어그램
기대효과 (선택사항)
대안 (선택사항)

https://github.com/ku-ring/package-activityui
forked package dependency 추가

repo: ku-ring/ios-app


text:
Tensorboard

I think that the tensorboard API needs  re-design: why?

Now the Api exposes 3 types of start board, if we will add comparisons between pipelines/jobs/nodes/tasks you will have to add more APis, or maybe it will be impossible to do it because the API is relying on the route params.
Need to fetch/store from 3 different etcd paths to get all boards, if we will add comparison you need more paths, how you will stop board with comparison if you only rely on pipelineName, jobid, taskid?
On client - you need to call to 3 different apis for same thing.
If we show list of tensorboards, and the user want to stop one of them, it is very unintuitive to choose which API he should call to, because there are 3 types.
if you don’t rely on boardId how you will stop a comparison board? How you will find it on etcd? Impossible.

I suggest:

Need to rely only on boardId.
To check if board already exists get all boards and find it by params.
Need to make the API more agile to compare jobs, pipelines, nodes, tasks.

There should be only one API for start tensorboard, this API should accept a list of

PipelineName

NodeName - list
JobId -list
TaskId - list

and return boardId.
Avoiding the need for boardId now will cost much more later.
Also “Keep it simple” - Like there is no stop raw pipeline, stop cron pipeline or stop stored pipeline, there shouldn’t be for boards.

Algorithm run Test
File: pipeline_tests.js
describe: "pipeline Types"
need to add test to create board and validate that it was created properly

Test
description

type = raw tensor
execute tensor pipeline

repo: kube-HPC/hkube


text:
chore(deps): update CI workflows to use Nodejs v20

[x] Wait until azure/setup-kubectl@v4 is available

upload-artifact/v4 breaking changes:

Uploading to the same named Artifact multiple times.
Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.
https://github.com/actions/upload-artifact

Will have to do a followup.

There are still some actions using Nodejs v16, and a refactor might be needed for action-cond.

repo: kube-logging/telemetry-controller


text:
kube-vip v0.7.0 broken the control plane load balancing

Describe the bug
After upgrade to kube-vip v0.7.0 from v0.6.4，kube-vip will be exited with error with enabled control plane load balancing.
To Reproduce
Steps to reproduce the behavior:
Enable lb_enable and upgrade to v0.7.0 from v0.6.4
Expected behavior
Works without errors.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS/Distro: Debian 12
Kubernetes Version: K3S v1.27.8+k3s2
Kube-vip Version: v0.7.0

Kube-vip.yaml:
If Possible add in your kube-vip manifest (please remove anything that is confidential)
apiVersion: apps/v1
kind: DaemonSet
metadata:
  creationTimestamp: null
  labels:
    app.kubernetes.io/name: kube-vip-ds
    app.kubernetes.io/version: v0.7.0
  name: kube-vip-ds
  namespace: kube-system
spec:
  selector:
    matchLabels:
      app.kubernetes.io/name: kube-vip-ds
  template:
    metadata:
      creationTimestamp: null
      labels:
        app.kubernetes.io/name: kube-vip-ds
        app.kubernetes.io/version: v0.7.0
    spec:
      affinity:
        nodeAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
            nodeSelectorTerms:
            - matchExpressions:
              - key: node-role.kubernetes.io/master
                operator: Exists
            - matchExpressions:
              - key: node-role.kubernetes.io/control-plane
                operator: Exists
      containers:
      - args:
        - manager
        env:
        - name: vip_arp
          value: "true"
        - name: port
          value: "6443"
        - name: vip_interface
          value: enp1s0
        - name: vip_cidr
          value: "32"
        - name: cp_enable
          value: "true"
        - name: cp_namespace
          value: kube-system
        - name: vip_ddns
          value: "false"
        - name: svc_enable
          value: "true"
        - name: svc_leasename
          value: plndr-svcs-lock
        - name: svc_election
          value: "true"
        - name: vip_leaderelection
          value: "true"
        - name: vip_leasename
          value: plndr-cp-lock
        - name: vip_leaseduration
          value: "5"
        - name: vip_renewdeadline
          value: "3"
        - name: vip_retryperiod
          value: "1"
        - name: lb_enable
          value: "true"
        - name: lb_port
          value: "6443"
        - name: lb_fwdmethod
          value: local
        - name: address
          value: 192.168.1.50
        - name: prometheus_server
          value: :2112
        - name: EGRESS_CLEANUP
          value: 'true'
        - name: egress_withnftables
          value: 'true'
        image: plndr/kube-vip-iptables:v0.7.0
        imagePullPolicy: Always
        name: kube-vip
        resources: {}
        securityContext:
          capabilities:
            add:
            - NET_ADMIN
            - NET_RAW
      hostNetwork: true
      serviceAccountName: kube-vip
      tolerations:
      - effect: NoSchedule
        operator: Exists
      - effect: NoExecute
        operator: Exists
  updateStrategy: {}
status:
  currentNumberScheduled: 0
  desiredNumberScheduled: 0
  numberMisscheduled: 0
  numberReady: 0

Additional context
Logs v0.7.0
time="2024-02-09T04:40:55Z" level=info msg="Starting kube-vip.io [v0.7.0]"
time="2024-02-09T04:40:55Z" level=info msg="namespace [kube-system], Mode: [ARP], Features(s): Control Plane:[true], Services:[true]"
time="2024-02-09T04:40:55Z" level=info msg="prometheus HTTP server started"
time="2024-02-09T04:40:55Z" level=info msg="Starting Kube-vip Manager with the ARP engine"
time="2024-02-09T04:40:55Z" level=info msg="beginning watching services, leaderelection will happen for every service"
time="2024-02-09T04:40:55Z" level=info msg="(svcs) starting services watcher for all namespaces"
time="2024-02-09T04:40:55Z" level=info msg="Beginning cluster membership, namespace [kube-system], lock name [plndr-cp-lock], id [dmz-app-master-1]"
I0209 04:40:55.564441       1 leaderelection.go:250] attempting to acquire leader lease kube-system/plndr-cp-lock...
time="2024-02-09T04:40:55Z" level=info msg="Node [dmz-app-master-2] is assuming leadership of the cluster"
time="2024-02-09T04:40:55Z" level=info msg="(svc election) service [rsyslog-forwarder], namespace [rsyslog], lock name [kubevip-rsyslog-forwarder], host id [dmz-app-master-1]"
I0209 04:40:55.601144       1 leaderelection.go:250] attempting to acquire leader lease rsyslog/kubevip-rsyslog-forwarder...
I0209 04:40:55.612949       1 leaderelection.go:260] successfully acquired lease rsyslog/kubevip-rsyslog-forwarder
time="2024-02-09T04:40:55Z" level=info msg="(svcs) adding VIP [[192.168.1.60]] for [rsyslog/rsyslog-forwarder]"
time="2024-02-09T04:40:55Z" level=info msg="[service] synchronised in 12ms"
I0209 04:41:01.744223       1 leaderelection.go:260] successfully acquired lease kube-system/plndr-cp-lock
time="2024-02-09T04:41:01Z" level=info msg="Node [dmz-app-master-1] is assuming leadership of the cluster"
time="2024-02-09T04:41:01Z" level=info msg="Starting IPVS LoadBalancer"
time="2024-02-09T04:41:01Z" level=info msg="IPVS Loadbalancer enabled for 1.2.1"
time="2024-02-09T04:41:01Z" level=info msg="Gratuitous Arp broadcast will repeat every 3 seconds for [192.168.1.50]"
time="2024-02-09T04:41:01Z" level=info msg="Kube-Vip is watching nodes for control-plane labels"
time="2024-02-09T04:41:01Z" level=error msg="Error querying backends file does not exist"
time="2024-02-09T04:41:01Z" level=error msg="Unable to create an IPVS service, ensure IPVS kernel modules are loaded"
time="2024-02-09T04:41:01Z" level=fatal msg="IPVS service error: netlink receive: invalid argument"

Logs v0.6.4
time="2024-02-09T06:42:41Z" level=info msg="Starting kube-vip.io [v0.6.4]"
time="2024-02-09T06:42:41Z" level=info msg="namespace [kube-system], Mode: [ARP], Features(s): Control Plane:[true], Services:[true]"
time="2024-02-09T06:42:41Z" level=info msg="prometheus HTTP server started"
time="2024-02-09T06:42:41Z" level=info msg="Starting Kube-vip Manager with the ARP engine"
time="2024-02-09T06:42:41Z" level=info msg="beginning watching services, leaderelection will happen for every service"
time="2024-02-09T06:42:41Z" level=info msg="(svcs) starting services watcher for all namespaces"
time="2024-02-09T06:42:41Z" level=info msg="Beginning cluster membership, namespace [kube-system], lock name [plndr-cp-lock], id [dmz-app-master-3]"
I0209 06:42:41.232585       1 leaderelection.go:250] attempting to acquire leader lease kube-system/plndr-cp-lock...
I0209 06:42:41.257512       1 leaderelection.go:260] successfully acquired lease kube-system/plndr-cp-lock
time="2024-02-09T06:42:41Z" level=info msg="Node [dmz-app-master-3] is assuming leadership of the cluster"
time="2024-02-09T06:42:41Z" level=info msg="Starting IPVS LoadBalancer"
time="2024-02-09T06:42:41Z" level=info msg="IPVS Loadbalancer enabled for 1.2.1"
time="2024-02-09T06:42:41Z" level=info msg="Gratuitous Arp broadcast will repeat every 3 seconds for [192.168.1.50]"
time="2024-02-09T06:42:41Z" level=info msg="Kube-Vip is watching nodes for control-plane labels"
time="2024-02-09T06:42:41Z" level=error msg="Error querying backends file does not exist"
time="2024-02-09T06:42:41Z" level=info msg="Created Load-Balancer services on [192.168.1.50:6443]"
time="2024-02-09T06:42:41Z" level=info msg="Added backend for [192.168.1.50:6443] on [192.168.1.51:6443]"
time="2024-02-09T06:42:41Z" level=info msg="Added backend for [192.168.1.50:6443] on [192.168.1.52:6443]"
time="2024-02-09T06:42:41Z" level=info msg="Added backend for [192.168.1.50:6443] on [192.168.1.53:6443]"
time="2024-02-09T06:42:41Z" level=info msg="(svc election) service [rsyslog-forwarder], namespace [rsyslog], lock name [kubevip-rsyslog-forwarder], host id [dmz-app-master-3]"
I0209 06:42:41.279595       1 leaderelection.go:250] attempting to acquire leader lease rsyslog/kubevip-rsyslog-forwarder...
time="2024-02-09T06:42:41Z" level=info msg="(svc election) new leader elected: dmz-app-master-2"

May be linked to #752

With v0.7.0, I am encountering the same error too.

We upgraded the ipvs package (thanks dependabot)… we probably will just revert this change. Apologies for now.

authors: W0n9 ityaad thebsdbox

repo: kube-vip/kube-vip


text:
Optimize KB dockerfile

Signed-off-by: JoeyHwong joeyhwong@gknow.cn

/lgtm
/approve

authors: JoeyHwong-gk llhuii

repo: kubeedge/sedna


text:
Append builder: Image tag is the same even though base image is different

I used the append builder to build an image and then changed the base image and rebuilt.
In both cases the image URI was the same.
gcr.io/code-search-demo/fairing-job:BEF9445D

Is this expected? I would have expected unique image tags for each build if the base image changed.

Is this expected? I would have expected unique image tags for each build if the base image changed.

The image tag is generated by getting CRC for the preprocessor output https://github.com/kubeflow/fairing/blob/master/fairing/utils.py#L28 that doesn't depend on the base image.
@r2d4 what is the ideal solution here?

The correct solution is to reference images by their digest

I think this may have been user error on my part. I may not have been sending files to the builder (no output from preprocessor) and that's why the CRC was the same.

repo: kubeflow/fairing


text:
prediction endpoint url is wrong when using ClusterIP

/kind bug
from kubeflow.fairing import PredictionEndpoint
endpoint = PredictionEndpoint(HousingServe, input_files=['trained_ames_model.dat', "requirements.txt"],
                              docker_registry=DOCKER_REGISTRY,
                              service_type='ClusterIP',
                              backend=BackendClass(build_context_source=BuildContext))
endpoint.create()

We get endpoint results.
Deploying the endpoint.
Cluster endpoint: http://fairing-service-srwh2.kubeflow-anonymous.svc.cluster.local
Prediction endpoint: http://fairing-service-srwh2.kubeflow-anonymous.svc.cluster.local

if we run following command, it will hang there.
# Get sample data and query endpoint
(train_X, train_y), (test_X, test_y) = read_input("ames_dataset/train.csv")
endpoint.predict_nparray(test_X)

The problem is right url should be
http://fairing-service-srwh2.kubeflow-anonymous.svc.cluster.local:5000/predict
If we change to this config, prediction works well.
endpoint.url='http://fairing-service-n8qv2.kubeflow-anonymous.svc.cluster.local:5000/predict'
endpoint.predict_nparray(test_X)

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

I will file a PR to fix this issue


text:
support elastic training

elastic training design doc:  https://mp.weixin.qq.com/s/93Fb1cyAJ3tuzTwwwC4CUQ
I'm pushing volcano support elastic scheduler with pr  https://github.com/volcano-sh/volcano/pull/1884
in order to support elastic training, operator should collaborate with volcano

operator set podgroup.minMember = elasticPolicy.min
operator ensures that there are a total of elasticPolicy.max pods anytime. in detail, if volcano delete a pod when scaling down, operator should create a new pod  in the same time.

in order to support elastic training, operator needs to make the following changes

support elasticPolicy field(done)
in elastic mode, there are no master, all pods are workers. rank = 0 worker is master (done)
set podgroup.minMember = elasticPolicy.min (not support)
in elastic mode, if there is a elastic job whose  elasticPolicy.min is 5 and elasticPolicy.max is 10, if there is a failed pod, it is ok for job continue to run. so we should change the successPolicy and failPolicy of job(not support)
whether in elastic mode or not, ensure that the master(rank = 0 worker) starts before the workers （not support in elastic mode）

/cc @kubeflow/wg-training-leads

Are we referring elastic training with PyTorchJob or this proposal is applied to all training jobs?
when re-creating the pod deleted/evicted by volcano or any other scheduler, any requirement for the new pod like pod name, pod spec remaining the same as the deleted/evicted one?
For non-elastic mode, why should we ensure worker with rank 0 start before other workers?

@zw0610

it works only in the allreduce model, it may be work on ps model（like tensorflow）, but I haven't thought about it
yes,  pod spec should remain the same as the deleted/evicted one
in pytorch scenario, worker with rank 0(we call it master)  is used as Service Registry,  worker connect to master to find other workers, every worker have an env MASTER_ADDR=xxx-worker-0

authors: gaocegege qiankunli zw0610

repo: kubeflow/training-operator


text:
add selector in Deployment spec

This change is

/assign @lluunn
@lluunn Please would you take a look at this change. I've chosen you since you made the last major update to the TFJob page.

@fai555 Please would you sign the CLA and then add a comment on this CL, as requested by the googlebot above.

/ok-to-test

/lgtm
/approve

@fai555 Please would you sign the CLA and then add a comment on this CL, as requested by the googlebot above. The PR will not merge until the CLA is signed.

@googlebot recheck CLA

authors: fai555 lluunn sarahmaddox

repo: kubeflow/website


text:
Fix typo in kubeflow-on-multinode-cluster doc

instal to install

This change is

/assign @mastrogiovanni

/assign @sarahmaddox

Thanks @muik!
/ok-to-test
/lgtm
/approve

authors: muik sarahmaddox


text:
Kubeless kafka-trigger-controller performance

What happened:
The kafka-trigger-controller seems to fire kubeless functions at up to 5 qps. I have made some simple functions that do not process data or even write out to console. Simply return event.data; Still, the function call rate does not ever exceed 5 qps. I am using Prometheus and Grafana for monitoring.
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Use the out of the box kafka installation as shown in the Kubeless docs. Create a simple function that simply logs or returns the data being passed in the function. I have not been able to see it exceed 5 qps.
Here is an example below:
module.exports = {
        consume: (event, context) => {
//              console.log(event.data);
                return event.data;
        }

}

Anything else we need to know?:
Environment:

Kubernetes version:

Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.0", GitCommit:"fc32d2f3698e36b93322a3465f63a14e9f0eaead", GitTreeState:"clean", BuildDate:"2018-03-26T16:55:54Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.4", GitCommit:"5ca598b4ba5abb89bb773071ce452e33fb66339d", GitTreeState:"clean", BuildDate:"2018-06-06T08:00:59Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

Kubeless version:

Kubeless version: v0.6.0

Observe identical behavior, 1668 function invocations in 333 seconds is exactly 5 qps
I have 3 different functions, invoked at different rates, the combined rate is throttled at 5 qps
I am using kafka-trigger-controller logs and Kafka console consumer to monitor
Client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.3", GitCommit:"d2835416544f298c919e2ead3be3d0864b52323b", GitTreeState:"clean", BuildDate:"2018-02-07T12:22:21Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.7", GitCommit:"dd5e1a2978fd0b97d9b78e1564398aeea7e7fe92", GitTreeState:"clean", BuildDate:"2018-04-18T23:58:35Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Kubeless version: v1.0.0-alpha.7

There could two possible causes for this issue:

Something wrong in the Kafka configuration.
Lack of parallelization when sending requests to the final function from the Kafka consumer (code here: https://github.com/kubeless/kafka-trigger/blob/master/pkg/event-consumers/kafka/kafka-consumer.go#L91).

I would say that's probably the second option. I have created a branch to check that. Could you test it? For doing so edit your current deployment (kubectl edit deployment -n kubeless kafka-trigger-controller) and change the image to bitnami/kafka-trigger-controller:build-3d1b2c3a-7ca8-4fd7-a6f6-816e54737852? (this is the CI job that generated that image: https://circleci.com/gh/kubeless/kafka-trigger/119)

Hi,
So I did test out the new branch that you linked. And at first it did not change anything (still getting 5 qps). But once I scaled the kafka-trigger-controller it would scale with 5 qps per each kafka-trigger pod. So 5 qps by default, 10 qps with 2 kakfa-trigger-controller pods, and 15 qps with 3. I have not tested this with the regular non-parallelized build.

That was not what I was expecting, with the modified version a single trigger-controller should be able to send more queries per second. I will try to reproduce the environment and investigate what can be the bottleneck.

I have been checking this issue. I have modified the image to mark the offset of the message just after receiving a message. That means that the consumer will be ready to receive the next message without waiting for it to be delivered to the function. The new image ID is: bitnami/kafka-trigger-controller:build-1631f2e8-7486-4c96-a849-21c75dd145a6
Apart from that, if you want to be able to receive more qps you need to:

Increase the number of partitions in a topic. If you use the command kubeless topic create to create a topic this sets the number of partitions to 1. If you want to receive messages in parallel you need to use a bigger number. This can be done directly executing this command in the Kafka container: /opt/bitnami/kafka/bin/kafka-topics.sh --zookeeper zookeeper.kubeless:2181 --replication-factor 1 --partitions 5 --create --topic <your_topic_id>
Increase the number of consumers. As you mention, you can increase the number of consumers scaling the kafka-trigger-controller deployment.

This post can help to clarify the relation between the topics, messages, partitions and consumers: https://stackoverflow.com/questions/25602359/kafka-how-to-consume-one-topic-parallel

So I tested out this new image ID, and I also increases the partitions to 5.
What I found is that I still get 5 qps on 1 pod of kafka-trigger-controller. But scaling it up does not increase qps like before. The logs from the newer pods that were deployed from scaling show it is not receiving and pushing messages. I am not sure, but this may be due to the fact that the orignal kafka-trigger-controller pod was manually set to a partiion of 5, while the newly spawned ones are set to the default value of 1.
I hope this helps.

@dap332 I haven't changed how the consumers are initialized so the partitions should be the same. The only thing I changed is that the messages are now handled in a goroutine that is run in parallel. Note that partitions are set when creating the topic, can you verify if the topic you are using have partitions set to 5?
Also we have released a version with the patch: can you try comparing the versions v1.0.0-alpha.9 and v1.0.0-beta.0? Can you check that if upgrading the version and using the same topic the kafka-trigger-controller behaves differently?

bitnami/kafka-trigger-controller:v1.0.0-alpha.8, partitions = 5

Pod Scalings
Kafka-trigger-controller: 1
Predict (function) : 3
Kafka – 1
Zoo – 1
QPS: 5

Pod Scalings
Kafka-trigger-controller: 3
Predict (function) : 3
Kafka – 1
Zoo – 1
QPS: 5

Kafka-trigger-controller logs from an inactive controller:
$ kubectl -n kubeless logs -f --tail=25 kafka-trigger-controller-6959dcd4cd-w5jtq
time="2018-09-20T15:22:36Z" level=info msg="Running Kafka controller version: "
time="2018-09-20T15:22:36Z" level=info msg="Starting Kafka Trigger controller" controller=kafka-trigger-controller
time="2018-09-20T15:22:36Z" level=info msg="Processing update to function object predict Namespace: sentiment" controller=kafka-trigger-controller
time="2018-09-20T15:22:36Z" level=info msg="We got a Kafka trigger  predict-trigger that function predict need to be associated so create Kafka consumer" controller=kafka-trigger-controller
time="2018-09-20T15:22:36Z" level=info msg="Creating Kafka consumer for the function predict associated with for trigger predict-trigger"
time="2018-09-20T15:22:36Z" level=info msg="Created Kafka consumer for the function predict associated with for trigger predict-trigger"
time="2018-09-20T15:22:36Z" level=info msg="Successfully created Kafka consumer for Function: predict" controller=kafka-trigger-controller
time="2018-09-20T15:22:36Z" level=info msg="Successfully processed update to function object predict Namespace: sentiment" controller=kafka-trigger-controller
time="2018-09-20T15:22:36Z" level=info msg="Started Kakfa consumer Broker: kafka.kubeless:9092, Topic: test-topic, Function: predict, consumerID: sentiment_predict-trigger_predict_test-topic"
time="2018-09-20T15:22:36Z" level=info msg="Kafka Trigger controller caches are synced and ready" controller=kafka-trigger-controller
time="2018-09-20T15:22:36Z" level=info msg="Processing update to Kafka Trigger: sentiment/predict-trigger" controller=kafka-trigger-controller
time="2018-09-20T15:22:36Z" level=info msg="Consumer for function predict associated with trigger predict-trigger already exists, so just returning"
time="2018-09-20T15:22:36Z" level=info msg="Processed change to Kafka trigger: predict-trigger Namespace: sentiment" controller=kafka-trigger-controller
time="2018-09-20T15:22:37Z" level=info msg="Rebalanced: &{Type:rebalance start Claimed:map[] Released:map[] Current:map[]}\n"
time="2018-09-20T15:22:37Z" level=info msg="Rebalanced: &{Type:rebalance OK Claimed:map[test-topic:[3 4]] Released:map[] Current:map[test-topic:[3 4]]}\n"
time="2018-09-20T15:22:44Z" level=info msg="Rebalanced: &{Type:rebalance start Claimed:map[] Released:map[] Current:map[test-topic:[3 4]]}\n"
time="2018-09-20T15:22:44Z" level=info msg="Rebalanced: &{Type:rebalance OK Claimed:map[test-topic:[]] Released:map[test-topic:[]] Current:map[test-topic:[3 4]]}\n"

I tested it with the alpha version and I still see it maxing out to 5 qps with partition set to 5. And what is even more interesting is, that when scaling the kafka-trigger-controller to 3, only one is actively processing messages while the others rebalance upon deployment and wait.
I have no name!@kafka-0:/$ /opt/bitnami/kafka/bin/kafka-topics.sh --zookeeper zookeeper.kubeless:2181 --describe --topic test-topic
Topic:test-topic	PartitionCount:5	ReplicationFactor:1	Configs:
	Topic: test-topic	Partition: 0	Leader: 1001	Replicas: 1001	Isr: 1001
	Topic: test-topic	Partition: 1	Leader: 1001	Replicas: 1001	Isr: 1001
	Topic: test-topic	Partition: 2	Leader: 1001	Replicas: 1001	Isr: 1001
	Topic: test-topic	Partition: 3	Leader: 1001	Replicas: 1001	Isr: 1001
	Topic: test-topic	Partition: 4	Leader: 1001	Replicas: 1001	Isr: 1001

bitnami/kafka-trigger-controller:v1.0.0-beta.0, partition = 5

Pod Scalings
Kafka-trigger-controller: 1
Predict (function) : 3
Kafka – 1
Zoo – 1
QPS: 5

Pod Scalings
Kafka-trigger-controller: 3
Predict (function) : 3
Kafka – 1
Zoo – 1
QPS: 5

Similar logs from an inactive kafka-trigger-controller. When scaled on one pod is active, the rest sit idle it seems.

I'm observing similar behavior with the NATS trigger, and it has the same non-parallel critical section inside the trigger controller. Really each processed message should kick off a goroutine and immediately ACK back to the stream, since there's no failure handling right now anyway.

Any progress on this ?

repo: kubeless/kubeless


text:
fix network policy issues

[x] Make sure you have followed Kube-OVN Code Style.

What type of this PR

Bug fixes

Which issue(s) this PR fixes:
Fixes network policy e2e failure.
https://github.com/kubeovn/kube-ovn/actions/runs/4691717677/jobs/8316548978
WHAT

🤖 Generated by Copilot at 48d55fe
This pull request enhances the network policy and security group controller and the ovnClient by adding a new method to set ports of a port group in one transaction, and using it to optimize the performance and reduce the network traffic. It also updates the interface, implementation, and test cases of the PortGroup type in the pkg/ovs package, and improves the log messages and error handling in the controller.

🤖 Generated by Copilot at 48d55fe

ovnClient sets ports
Network policies improved
Winter of bugs ends

HOW

🤖 Generated by Copilot at 48d55fe

Add a variable E2E_BUILD_FLAGS to simplify and unify the build flags for the end-to-end tests in the Makefile.e2e file (link, link, link, link, link, link, link, link, link, link, link)
Add a new method PortGroupSetPorts to the PortGroup and OvnClient interfaces and implementations in the pkg/ovs package, to set the ports of a port group in one transaction (link, link, link, link, link, link)
Add a new field npKeyMutex to the Controller type in the pkg/controller package, to synchronize the access to network policies by different workers (link, link)
Use the npKeyMutex to lock and unlock the network policy key before updating or deleting the network policy in the handleUpdateNp and handleDeleteNp functions in the pkg/controller/network_policy.go file (link, link)
Replace the calls to PortGroupAddPorts and PortGroupResetPorts with the call to PortGroupSetPorts in the handleUpdateNp and updateDenyAllSgPorts functions in the pkg/controller/network_policy.go and pkg/controller/security_group.go files, to optimize the performance and reduce the network traffic (link, link, link)
Simplify the code and improve the readability and performance by moving or avoiding unnecessary variable declarations and assignments in the handleUpdateNp function in the pkg/controller/network_policy.go file (link, link)
Improve the readability and debuggability of the error and log messages by adding the network policy name to the messages in the processNextUpdateNpWorkItem and handleAddOrUpdatePod functions in the pkg/controller/network_policy.go and pkg/controller/pod.go files (link, link)

@gugulee Please review.

repo: kubeovn/kube-ovn


text:
Add ports config to DaemonSet yaml. Closes #741

This PR fixes the missing ports config in the DaemonSet Yaml file. Closes #741

lgtm

authors: PaulusTM jackfrancis

repo: kubereboot/kured


text:
Root CA bundle

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1298
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Root CA bundle

/retest

/retest

/retest

kron4eg force-pushed the kron4eg:1298-ca-bundle branch from 492d568 to 753f677 2 minutes ago

that's just a rebase

repo: kubermatic/kubeone


text:
WIP: Support for Kubernetes v1.28

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
What type of PR is this?

/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:

Support for Kubernetes v1.28

Documentation:

TBD

/test all

/test pull-machine-controller-e2e-gce

/test pull-machine-controller-e2e-gce pull-machine-controller-e2e-azure

/test pull-machine-controller-e2e-kubevirt

/retest

/approve
/lgtm

repo: kubermatic/machine-controller


text:
Update openstack resources

This PR updates the relevant resources (cluster, nodedeployment, ssh_key) and adds data sources for these elements.

I added required options that have been lately been added to the KKP, i.e. instance_ready_check_period, opa, mla, octavia
I added data sources for cluster, project, sshkey, nodedeployment and the most relevant the kubeconfig. These elements were completely missing from v0.1.0
I added the relevant tests for the added resources and work with this provider for weeks. So far, I didn't run into any crashes. For basic usage, this version is far more stable than the current provider.
Update of a cluster and node deployment works by changing the kubernetes version setting.
I changed the ID definition of Terraform because encoding datacenter and project and cluster ID in a Terraform ID is wrong. Now, the IDs TF uses internally are more clear and not encoded. i.e. cluster_id = cluster_id that TF uses to identify a resource.
Added support for Flatcar image
Several bug fixes that led to critical TF errors

Fixes #36
This PR is an initial step into the right direction to keep the Terraform repo useful. KKP is cool but without proper usage of its API, it's almost not usable in an automated way. Terraform provider is critical such that Kubernetes clusters can be integrated into InfrastructureAsCode deployments.
I would like to see this PR merged and that a new version is released, i.e. 0.2.0
Can you please review this PR such that users can use an upstream supported Kubermatic TF provider.
Thanks in advance!

/assign @kron4eg @zreigz
Have a look at this PR.
I think this is a huge step forward in the terraform-provider-kubermatic repo. I am looking forward to your feedback.
Totally in the spirit of the open-source community, I'd like to share the changes with Upstream such that everybody can support of my improvements. 👍

/ok-to-test

@Happy2C0de thanks a lot for this PR. I have to switch my context to review and test this PR. I will try to do this tomorrow

@Happy2C0de thanks a lot for this PR. I have to switch my context to review and test this PR. I will try to do this tomorrow

Thanks that you will have a look at this PR @zreigz
Sure, come back to me when I can support you with this. Furthermore, I added a section to the CONTRIBUTING.md because it is not very well explained in TF documentation how one can locally build and use a provider.

@Happy2C0de thanks a lot for this PR. I've tested it. Looks good
/lgtm
/approve

@zreigz Thanks for merging this PR! Do you think we could get a new release?

@judge-red yes :+1:

authors: Happy2C0de judge-red zreigz


text:
Bump up golang.org/x/net dep to v0.33.0

What this PR does / why we need it:
Update golang.org/x/net package dependancy to v0.33.0
NONE

/assign @carlbraganza

/retest

Its failing for dep in grpc-health-probe, we'll have to wait for the next release with the fix


text:
master: update release-tools

Squashed 'release-tools/' changes from d24254f..78c0fb7
78c0fb7 Merge pull request #208 from jsafrane/skip-selinux
36e433e Skip SELinux tests in CI by default
348d4a9 Merge pull request #207 from RaunakShah/reviewers
1efc272 Merge pull request #206 from RaunakShah/update-prow
7d410d8 Changes to csi prow to run e2e tests in sidecars
cfa5a75 Merge pull request #203 from humblec/test-vendor
4edd1d8 Add RaunakShah to CSI reviewers group
7ccc959 release tools update to 1.19
git-subtree-dir: release-tools
git-subtree-split: 78c0fb714fa4448b29962a0f34fa18b7b7d97ae6
Fixes https://github.com/kubernetes-csi/csi-driver-host-path/issues/376
NONE

/lgtm

authors: jsafrane xing-yang


text:
Add kpod diff command

kpod diff reports on the changes in the filesystem between a container, layer, or image and its parent
Signed-off-by: Ryan Cole rcyoalne@gmail.com

The functionality in this PR meets (actually exceeds, since docker can only do this with containers) the functionality in docker diff.  Once https://github.com/containers/storage/issues/82 is taken care of, we can add the option to compare two (potentially unrelated) containers/layers/images.
After this is merged I'll also add the option to save the diff as a tarball or apply the diff

@rhatdan PTAL

I'm getting the following error in my integration checks:
/test/test_runner.sh

++ time bats --tap .

/tmp/bats.7825.src: line 41: syntax error: unexpected end of file

/usr/local/libexec/bats-exec-suite: line 20: let: count+=: syntax error: operand expected (error token is "+=")

What does it mean?

@mrunalp @runcom Can this be merged?

@14rcole Doesn't it have to pass the E2E tests?

retest

@14rcole Could you repush this so we can get the tests to fire.  Should be able to merge this, but need tests to run.

Will do

@mrunalp @runcom PTAL Looks like it is ready to merge.

LGTM. One nit that can be addressed later. Also, we should add tests later that check that the output is as expected but that depends on kpod run so we can wait.

authors: 14rcole mrunalp rhatdan

repo: kubernetes-incubator/cri-o


text:
Promote v0.26.0 docker image

Promote the v0.26.0 image in test-infra once the Helm chart update merges (https://github.com/kubernetes-sigs/descheduler/issues/1020)

Promotion PR opened at https://github.com/kubernetes-sigs/descheduler/issues/1036

repo: kubernetes-sigs/descheduler


text:
support inTree removal scenario for nodes without .ko files

Modprobe will fail with error in case it cannot find an appropriate .ko file when asked to remove a kernel module. With in-tree removal scenario, modporbe search path is /lib/modules on the host, and not the worker image.
This PR contains the following:

Adding FileExists function that check the presence of a file under
a search path based on a regexp
in worker flow, in case in-tree removal scenario is requisted, worker
will verify if the requested .ko file(s) are present on the host,
remove from the request missing files and will proceed with the
removal scenario for the rest
unit-test

Codecov Report
Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.56%. Comparing base (fa23a9b) to head (b4f0e64).
Report is 122 commits behind head on main.

Files with missing lines
Patch %
Lines

internal/utils/filesystem_helper.go
69.23%
2 Missing and 2 partials :warning:

internal/worker/worker.go
86.66%
1 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #903      +/-   ##
==========================================
- Coverage   79.09%   72.56%   -6.54%
==========================================
  Files          51       65      +14
  Lines        5109     4487     -622
==========================================
- Hits         4041     3256     -785
- Misses        882     1045     +163
  Partials      186      186

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/lgtm


text:
Fix minor typos

Signed-off-by: Anil Kumar Vishnoi vishnoianil@gmail.com

/lgtm
/approve
Thanks @vishnoianil

authors: astoycos vishnoianil

repo: kubernetes-sigs/kpng


text:
Pod group stuck in QuotaReserved after deactivated

What happened:
A pod-group workload is stuck in QuotaReserved=True, with Evicted=False, after reaching the backoffLimit, when no replacement pods are sent.
This is likely because of this check
https://github.com/kubernetes-sigs/kueue/blob/ae5aaca92c5bff3c4bf06a0cbe3df2ecd72523fe/pkg/controller/jobframework/reconciler.go#L382
The pod group is considered suspended if there are no replacement pods.
That causes the reconciler to return before this:
https://github.com/kubernetes-sigs/kueue/blob/ae5aaca92c5bff3c4bf06a0cbe3df2ecd72523fe/pkg/controller/jobframework/reconciler.go#L417-L418
What you expected to happen:
The Evicted condition to transition to True.
How to reproduce it (as minimally and precisely as possible):

Install kueue with the following config:

    waitForPodsReady:
      enable: true
      timeout: 30s
      requeuingStrategy:
        timestamp: Eviction
        backoffLimitCount: 1

Apply examples/admin/single-clusterqueue-setup.yaml

Run this pod:

apiVersion: v1
kind: Pod
metadata:
  name: pod-in-group
  labels:
    kueue.x-k8s.io/queue-name: user-queue
    kueue.x-k8s.io/pod-group-name: "sample-group"
  annotations:
    kueue.x-k8s.io/pod-group-total-count: "1"
spec:
  restartPolicy: Never
  nodeSelector:
    foo: doesnotexist
  containers:
  - name: sleep
    image: busybox
    command: ["sh", "-c", 'echo "hello world from the leader pod" && sleep 3']
    resources:
      requests:
        cpu: 3

Anything else we need to know?:
This issue is likely fixed with #2131, so we need to cherry-pick it to the 0.6 release.
But we should also add an integration test for the pod integration that exercises the case of not sending replacement pods.
Environment:

Kubernetes version (use kubectl version):
Kueue version (use git describe --tags --dirty --always): gcr.io/k8s-staging-kueue/kueue:v20240501-v0.6.2-12-g0a69bb7
Cloud provider or hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

/assign @trasc
Please check if the issue is fixed with https://github.com/kubernetes-sigs/kueue/pull/2131 and cherry-pick with an accompanying integration test.

/assign

I also looked at this and can confirm that https://github.com/kubernetes-sigs/kueue/pull/2131 is the culprit.
As for cherry-picking, we probably also will need to include: https://github.com/kubernetes-sigs/kueue/pull/2172, and https://github.com/kubernetes-sigs/kueue/pull/2171.

@mimowo I think #2171 not required, because it's fixing #1955 (for this line https://github.com/kubernetes-sigs/kueue/pull/1955/files#diff-60dd240c20adbd6a189d018d1c216c2d296730f446c341d8bf449fa6657964ffR202).

Ah, ok so https://github.com/kubernetes-sigs/kueue/pull/2171 is fixing code which is only in 0.7. In that case only https://github.com/kubernetes-sigs/kueue/pull/2172

authors: alculquicondor mbobrovskyi mimowo

repo: kubernetes-sigs/kueue


text:
Adapt scalability range spec to the CI results

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adapt scalability  test range spec to the observed CI results.
Which issue(s) this PR fixes:

Relates to #1912
Special notes for your reviewer:
Does this PR introduce a user-facing change?

None

/test all

/test pull-kueue-test-scheduling-perf-main

/test pull-kueue-test-scheduling-perf-main

/test pull-kueue-test-scheduling-perf-main

/test pull-kueue-test-scheduling-perf-main

/test pull-kueue-test-scheduling-perf-main

/test pull-kueue-test-scheduling-perf-main

/test pull-kueue-test-scheduling-perf-main


text:
Automated cherry pick of #3010: Use Note instead Warning on the LendingLimit is enabled by default info.

Cherry pick of #3010 on website.
#3010: Use Note instead Warning on the LendingLimit is enabled by default info.
For details on the cherry pick process, see the cherry pick requests page.
NONE

/assign @alculquicondor

/close
Let's leave it like this so that we don't further complicate the future merge process

authors: alculquicondor mbobrovskyi


text:
[preemption] Two step preemption.

What type of PR is this?
/kind feature

What this PR does / why we need it:
Split the preemption process in two,  target selection and issuing, the first step can be use to check if preemption is possible without issuing preemption to any admitted workloads.
Which issue(s) this PR fixes:

Relates to  #420
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/cc

/hold
for #805, so that we don't complicate cherry-picks

/hold
for #805, so that we don't complicate cherry-picks

There is no conflict or dependency between them, however  I don't have a problem holding it for now.

/remove-kind feature
/kind cleanup

There is no conflict or dependency between them, however I don't have a problem holding it for now

sounds good. But there will be new tests, so that will also be helpful.

/retest

/retest

I'm working on fixing the test infra https://github.com/kubernetes/test-infra/pull/29631

/test pull-kueue-test-integration-main

/unhold
#805 is now merged

/test pull-kueue-test-integration-main
/test pull-kueue-test-unit-main

/retest

/retest

/retest

/retest

/lgtm

Maybe we should remove the lint check from unit tests? It's already done in verify

Yes, can you open that PR?
Similarly for integration and E2E

Sure.

Opened: #823

After: https://github.com/kubernetes-sigs/kueue/pull/823
/test pull-kueue-verify-main

Oops. we haven't yet fixed pull-kueue-verify-main .

/hold
Maybe, fixed by #824

authors: alculquicondor tenzen-y trasc


text:
We should not import from k8s/kubernetes.

What type of PR is this?
/kind cleanup

What this PR does / why we need it
k8s/Kubernetes is not a library to import packages from. The project publishes APIs for people to use but these utilities don't seem to be in those locations.
This PR removes k8s/kubernetes by reusing the utilites we use.
Which issue(s) this PR fixes

Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?

NONE

/lgtm
/approve

repo: kubernetes-sigs/lws


text:
Reconcile namespace and singleton in tandem

Passes the namespace object to the reconcile function to allow it to
be modified at the same time as the singleton. This will enable more
sophisticated reconciliations including self-service namespace creation
and adding labels to the namespace to indicate ancestry.
Tested: existing integ tests; manual with subsequent commits.
See https://github.com/adrianludwin/multi-tenancy/commits/self-serve for the full context of this PR

/assign @rjbez17

/lgtm
/approve

repo: kubernetes-sigs/multi-tenancy


text:
[wip] create simplified kubectl ref

Built simple, single page kubectl command reference
TODO:

Description, Usage, Examples text: important note, embedded links, embedded lists, preserve newlines and whitespace. Convert Markdown snippets to HTML (goldmark), then run through golang template.Html.
Examples
Overall page styling needs more work
Remove static-includes directory and files; update setup script
Verify static assets, update stylesheet as needed
Flags are presorted (alphabetical); does this need additional verification
Table captions (Aria)
Simplified Makefile
See issue #118.

@kbhawkey Is this still a WIP? Can we kick it in and iterate over it?

@kbhawkey Is this still a WIP? Can we kick it in and iterate over it?

@tengqm , This is sort of a WIP. I started to work on cleaning up the Examples section, but have not gotten back to it yet. I was not sure if there was any interest in this PR.
I am definitely in favor a new process and UI for this reference.
If the examples were fixed, then I would consider this PR less of a WIP. There are a lot of style tweaks that could be made, but I am happy with the basic way the docs generate.
The description text, examples text, and description text of flags needs to be cleaned up (Markdown, odd formatting, etc.). I will reopen my k8s/website PR which shows the full reference built using the code from this PR. Have a look again and let me know.
Do you have other ideas?

/reopen

@kbhawkey You are right we need to tune the look&feel of examples. There are other things to tune as well, such as the style for the left navigator. I was hoping that we can make it auto-hiding.
As a useful option, I'd vote for getting this in, even if it is not favored by the website team.

Since it has been some time, I will look at the state of the changes (and changes I made but did not merge in yet).
Yes, I agree to iterate and move these changes along.

Before adding this in, is there time (v1.18 release) to get the reference to a point where it is no longer a draft and is an acceptable replacement for the current kubectl command reference (granted I think the current ref is difficult to use and looks outdated).

Placing a hold on this again.
/hold

/close

authors: kbhawkey tengqm

repo: kubernetes-sigs/reference-docs


text:
Tune comment parser for asterisks

This is a followup for #269

One question, other changes look good.
/lgtm
/hold

/hold cancel

Thanks @tengqm .
/lgtm


text:
Geth

Thank you for contributing to kubernetes/charts. Before you submit this PR we'd like to
make sure you are aware of our technical requirements and best practices:

https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements
https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices

For a quick overview across what we will look at reviewing your PR, please read
our review guidelines:

https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md

Following our best practices right from the start will accelerate the review process and
help get your PR merged quicker.
When updates to your PR are requested, please add new commits and do not squash the
history. This will make it easier to identify new changes. The PR will be squashed
anyways when it is merged. Thanks.

/assign @scottrigby

/assign @unguiculus

/ok-to-test

@unguiculus please review changes

@unguiculus we have merged master, but we cant fix cla issue. Do you have any info about reason of failed check?
govale (author of PR) have not maintained this chart already. May be I need recreate pull request from my account?
Thank you.

authors: daniel-yavorovich govale unguiculus

repo: kubernetes/charts


text:
1.4 subdirectory causes glide to fail

When using the following glide.yaml, glide is unable to update or install the client-go to the "1.4" subdirectory under the root.
`
package: github.com/30x/postgres-k8s/cli
import:

package: github.com/spf13/cobra
vcs: git
package: k8s.io/client-go
version: v1.4.0
`

This causes the following error.
[ERROR]	Error scanning k8s.io/client-go/kubernetes: open /Users/apigee/.glide/cache/src/https-k8s.io-client-go/kubernetes: no such file or directory [ERROR]	This error means the referenced package was not found. [ERROR]	Missing file or directory errors usually occur when multiple packages [ERROR]	share a common dependency and the first reference encountered by the scanner [ERROR]	sets the version to one that does not contain a subpackage needed required [ERROR]	by another package that uses the shared dependency. Try setting a [ERROR]	version in your glide.yaml that works for all packages that share this [ERROR]	dependency. [ERROR]	Error scanning k8s.io/client-go/pkg/api: open /Users/apigee/.glide/cache/src/https-k8s.io-client-go/pkg/api: no such file or directory [ERROR]	This error means the referenced package was not found. [ERROR]	Missing file or directory errors usually occur when multiple packages [ERROR]	share a common dependency and the first reference encountered by the scanner [ERROR]	sets the version to one that does not contain a subpackage needed required [ERROR]	by another package that uses the shared dependency. Try setting a [ERROR]	version in your glide.yaml that works for all packages that share this [ERROR]	dependency.
Is it possible to remove the 1.4 subdirectory on the tag?

That's a legacy issue. When we first started client-go, we used subdirectories for versioning (because we tried to support go get). Future versions won't have the subdirectories.
If I cut a v2.0.0-alpha.0, will that solve your problem? I think you were developing on master? The v1.4 has multiple problems.

That will probably help.  What I really need is a stable 1.4 client against a 1.4.x k8s sytem.
I've been using it so far, and it's been great.  The only blocker I'm hitting is the lack of ability to run the remote commands, since this wrapper doesn't appear to exist in the client lib.
https://github.com/kubernetes/kubernetes/blob/master/pkg/client/unversioned/remotecommand/remotecommand.go#L82
Ultimately I need to be able to execute remote commands in addition to creating replica sets, PV and query pod status.  If you can cut a v2.0.0-alpha.0, I'll give that a try.

The v2.0.0-alpha.0 will work with 1.4.x k8s system. The client-go version doesn't imply the compatibility with the k8s system, see https://github.com/kubernetes/client-go#compatibility-client-go---kubernetes-clusters.

Made an alpha release. https://github.com/kubernetes/client-go/tree/v2.0.0-alpha.0

Because it's an alpha release, we might make more breaking change to the release-2.0 branch.

@tnine if you remove your existing vendored copy of  client-go, tell glide to fetch the 1.4.0 tag, and update the import paths in your application code, things should work again.
FWIW, note that client-go 1.5 is compatible with Kubernetes 1.4 as well.

I assume the issue is resolved. Please reopen if you need more help.

authors: caesarxuchao timoreimann tnine

repo: kubernetes/client-go


text:
Add Informer examples

Demonstrates a basic controller watching Pod events in a cluster.
Tested against kubernetes 1.4.5 on GKE.
attn @caesarxuchao
cc @mkobetic @ibawt @lxfontes

This change is

Sorry for the delay on revisiting this. All the comments/review should be addressed at this point I think.

Thanks @wfarr. Sorry, I didn't get time reviewing it earlier.
I only two nits left. Could you squash though? I'll merge it then. Thanks again.

sorry for the intrusion but is there any plan on getting this merged ?

example is no longer correct as per the latest code. clientset.CoreClient was deprecated in favour of clientset.Core().RestClient() iirc

@wfarr @caesarxuchao are you guys still on it ? I will try this example to see if it works. Would love if you can revive this and get this in and some more examples like this on usage of controller framework cc @smarterclayton

I don't really have the time to keep polishing this example up. If someone else wants to pick this up and push it across the finish line, feel free to do so.
Internally at Shopify, we're still making use of more or less the same constructs with good success using v2.0.0 of the client.

@mbohlool would you have time to polishing this example? It's almost there. Thanks.

@caesarxuchao Sure, assigned it to myself to follow up on it. Will send another PR with polished example.

I think the canonical location for these examples is currently the main
repo, so that they will be continuously tested correctly. If you have time
to send another PR (which is VERY much appreciated, btw), that would be the
best place to send it. (in the staging/src/k8s.io/client-go/examples
directory.)
On Thu, Mar 2, 2017 at 1:57 PM, Mehdy Bohlool notifications@github.com
wrote:

@caesarxuchao https://github.com/caesarxuchao Sure, assigned it to
myself to follow up on it. Will send another PR with polished example.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/client-go/pull/30#issuecomment-283795386,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAnglmYXa5pa1qeQrahL6Fue9LUst8anks5rhztWgaJpZM4KqAUT
.

I'll be able to publish mine early next week, and I'll link back and once it's available.

@timothysc can you clarify your comment? Are you going to send a PR for this example?

@mbohlool I can link to a repo once I open it up.  Still doing some vetting atm.

@timothysc the PR should be send to main kubernetes repo. I am still confused about your comments but assuming you are writing re-writing this example to address comments.

In https://github.com/kubernetes/client-go/pull/30#issuecomment-280194655 @ideahitme wrote:

example is no longer correct as per the latest code. clientset.CoreClient to be replaced by clientset.Core().RestClient() iirc

Fixed in https://github.com/kubernetes/kubernetes/commit/c89391bd578bd5709927b047522ccf8b7f33c3d2

In https://github.com/kubernetes/client-go/pull/30#issuecomment-283798994 @lavalamp  wrote:

I think the canonical location for these examples is currently the main repo...

I've opened a new PR https://github.com/kubernetes/kubernetes/pull/44446 and attempted to address the remaining code review comments.

closing this in favor of kubernetes/kubernetes#44446

authors: caesarxuchao ideahitme krmayankk lavalamp mbohlool timothysc wallrj wfarr


text:
Allow synchronization between Keystone projects and K8s namespaces

To improve integration between keystone and k8s it's recommended
to add a possibility to synchronize projects/namespaces.
In other words, if the user belongs to the project in Keystone, then when
attempting to authenticate in Kubernetes using k8s-keystone-auth, a k8s
namespace with the same name as the project id will automatically be
created for him.
To enable the feature new argument "--syncconfig" was added to the
k8s-keystone-auth binary, that should point to a file with sync configuration.
If set, new namespace will be automatically created when the user is
authenticated in Keystone.
To work correctly also "--kubeconfig" must be set.
fixes: #192

Hi, @Fedosin do you mind rebasing this change on #197? Since the --kubeconfig option is already supported in that patch and the code structure has been polished a lot.

@lingxiankong done :) thank you for your work, it helps a lot!

/test cloud-provider-openstack-acceptance-test-standalone-cinder

is this ready to merge @Fedosin ? looks like some more stuff left over above

Yes, it's still WIP and requires some updates. I just uploaded the code so that @zioproto could test it. But now, when #197 is merged, I am able to add the required changes.
If you have ideas what else we can add to the config, please share :)

/hold
Until ready to merge. Thanks for you work on this @Fedosin

I tested this PR and it works for me. The namespace is created automatically.

/hold cancel

/test cloud-provider-openstack-acceptance-test-keystone-authentication-authorization

/test cloud-provider-openstack-acceptance-test-keystone-authentication-authorization

/test cloud-provider-openstack-acceptance-test-keystone-authentication-authorization

/test cloud-provider-openstack-acceptance-test-keystone-authentication-authorization

/test cloud-provider-openstack-acceptance-test-flexvolume-cinder
/test cloud-provider-openstack-acceptance-test-standalone-cinder
/test cloud-provider-openstack-format
/approve

/test cloud-provider-openstack-acceptance-test-csi-cinder
/test cloud-provider-openstack-acceptance-test-k8s-cinder
/test cloud-provider-openstack-unittest

/test cloud-provider-openstack-unittest

/test cloud-provider-openstack-acceptance-test-csi-cinder
/test cloud-provider-openstack-acceptance-test-k8s-cinder

/test cloud-provider-openstack-acceptance-test-csi-cinder

/test cloud-provider-openstack-acceptance-test-k8s-cinder

/test cloud-provider-openstack-acceptance-test-e2e-conformance

/lgtm

/approve
/lgtm

authors: Fedosin dims hogepodge lingxiankong mrhillsman zioproto

repo: kubernetes/cloud-provider-openstack


text:
[service-loadbalancer] Acl Match

Hey,
I tried to set serviceloadbalancer/lb.aclMatch: "-i /" for one of my service.
But in the haproxy frontend configuration, it still uses the service name: "/service-name" (not "/").
Is it a bug?
Thanks,
Philmod

Any help here?

Anything I could try to debug this?

repo: kubernetes/contrib


text:
fix sig-node kubernetes contributor award 2024

This PR fixed the question of https://github.com/kubernetes/contributor-site/pull/552.
See https://github.com/kubernetes/contributor-site/pull/552/files#r1875198047.

/cc @tokt
/assign @jberkus @mfahlandt
cc @ffromani
I opened the PR to fix the description of sig-node award.

/approve

/lgtm

authors: jberkus pacoxu tokt

repo: kubernetes/contributor-site


text:
fixing shell variable references

There are also two other bugs:

uname -m returns x86_64 for me, but there is only dm-v1.2-darwin-amd64.zip on http://get-dm.storage.googleapis.com
line 32 doesn't work because the file inside the zip is not named dm, but something like dm-darwin-amd64.

Thanks, @guoshimin.
Yes, those other bugs bit me too. See the fixes I made in release-1.2.1. They need to come over to master.

authors: guoshimin jackgr

repo: kubernetes/deployment-manager


text:
Allow unnamed repositories

When doing operations such as helm fetch and install, it would be useful if helm allowed to specify a repo URL instead of a locally configured repo name.
Something similar to
helm fetch https://charts.foo.com fancy-package

which would install the default version of fancy-package from charts.foo.com.
Doing this makes it easier to use from scripts, since you don't need the extra step of naming and configuring a repo locally.

Could also reuse the docker-style naming
helm fetch charts.foo.com/fancy-package

I think this could be a very useful feature for CI/CD stuff and may even be a good starter feature for a new contributor. I know you'd have to change things in a few places, but the logic wouldn't be hard. Should we label this as a starter?

Some decision about how the command line arguments should look should take place before labelling as a starter issue.

FWIW, I think the best way to handle this is to add a --repo option to install and fetch.
helm fetch --repo=https://charts.foo.com fancy-package

I agree. That would allow the most flexibility both now and in the future.

Assigned to @sushilkm . For some reason, the gh box won't let me assign it the normal way.

Closed in #2300

authors: kragniz technosophos thomastaylor312

repo: kubernetes/helm


text:
Issue with k8s.io/docs/tasks/access-application-cluster/configure-access-multiple-clusters/

This is a...

[ ] Feature Request
[X] Bug Report

Problem:
More information is required to help new users out at their first steps with Kubectl with a real kubernetes cluster. I have just arrived at this page:
https://kubernetes.io/docs/tasks/access-application-cluster/configure-access-multiple-clusters/
from here: https://kubernetes.io/docs/tasks/tools/install-kubectl/
This is my first run through with anything that's beyond the interactive tutorials.
Making a config file describing our cluster(s) and contexts to suit our needs wasn't difficult.
Then I'm lost where it's asking for ca files etc, where do these come from when I have just brought up new cluster(s) with juju/conjure-up? Conjure-up failed, but I was able to bring up canonical-kubernetes using juju -> see https://github.com/conjure-up/conjure-up/issues/1150 for a description of how I ended up where I am.
I assume that if conjure-up had completed successfully, I'd not be in this situation and I'd have the kubectl setup already?
What's the server IP supposed to be in this case? Load balancer? Kubernetes master? (I think this is the load balancer based of an educated guess about an https url and the load balancer having port 443 open ;) )
Proposed Solution:

Clarify where the ca file and other credentials come from in the case of a new kubernetes cluster
Clarify what the "server" address means

Page to Update:
https://kubernetes.io/docs/tasks/access-application-cluster/configure-access-multiple-clusters/
https://kubernetes.io/docs/tasks/tools/install-kubectl/

After much searching, I found the critical information I was missing here:
https://kubernetes.io/docs/getting-started-guides/ubuntu/installation/#interacting-with-the-cluster
Because of the slightly odd route I've taken to get here, with conjure up failing part way through then using juju to do the deployment again from the start, I have probably read all the docs in the wrong order!
Perhaps linking to this article would help those who are in a similar situation to me in future?


text:
k8smeetup-kubectl-overview-2017-7-15

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.8 Features: set Milestone to 1.8 and Base Branch to release-1.8
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: Please check the “Allow edits from maintainers” box (see image below) to
allow reviewers to fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.

This change is

/cc @tengqm @zhangxiaoyu-zidif @markthink

@zjj2wry
welcome here to translate...

@tengqm
it's your turn to review...

@zhangxiaoyu-zidif updated, thanks

please fix that minor error then LGTM

@zhangxiaoyu-zidif updated, thanks for review work :-)


text:
Fix resource graphs in grafana dashboards

What type of PR is this?
/kind bug

What this PR does / why we need it:
Two graphs with "scope=resource" had actually scope set to "namespace"
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/lgtm
/approve

authors: marseel mborsz

repo: kubernetes/perf-tests


text:
Issue with k8s.io/id/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/

This is a Bug Report

Problem:
The page is empty in website, although it's in the master branch
Proposed Solution:
The page should show
Page to Update:
https://kubernetes.io/id/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes

/language id

this has been fixed by upstream issue sometime back, closing

repo: kubernetes/website


text:
[zh] translate blog "Don't Panic: Kubernetes and Docker"

This is a Feature Request
translate /blog/_posts/2020-12-02-dont-panic-kubernetes-and-docker.md
What would you like to be added
content/zh/blog/_posts/2020-12-02-dont-panic-kubernetes-and-docker.md
/assign
/language zh

/triage accepted
/kind feature

authors: tengqm zhiguo-lu


text:
Learn Kubernetes Basics

### Tasks

@developerjeph Hi, Could you please share the details on the issue you would like to report or the assistance you require? Kindly provide details in the https://github.com/kubernetes/website/issues/44452#issue-2050983235 of the issue.
/triage needs-information

There's no response from author regarding this empty issue since 2 weeks. Feel free to open a new issue @developerjeph if you are really facing any issue.
/close not-planned

authors: aj11anuj developerjeph dipesh-rawat


text:
Issue with k8s.io/docs/tutorials/kubernetes-basics/cluster-interactive/

This is a...
Bug Report

[ ] Feature Request
[ x] Bug Report

Problem:
At the and of the Interactive Tutorial - Creating a Cluster the Summary button returns the following error
he webpage at https://docs.google.com/forms/d/e/1FAIpQLScMbLRAbaZ8NleOFYRrepdIwCbhClHK3abu3SgzMn1KT_H5iA/viewform?entry.434419381=Module 1 might be temporarily down or it may have moved permanently to a new web address.
Proposed Solution:
unknown
Page to Update:
https://kubernetes.io/docs/tutorials/kubernetes-basics/cluster-interactive/

Thank you for reporting this. We're keeping an eye on forms and it's uptime.

/close

authors: BenHall joeyjoeyjoeyjoey


text:
follow up from https://github.com/kubernetes/website/pull/10958

and a bit of additional example work
Signed-off-by: Joe Heck heckj@mac.com

/assign kbhawkey
/assign bradamant3

@kbhawkey hmmm - guess I can't assign, so I'll just 👋 and let you know this is here as follow-up per your suggestions in my earlier PR. Thanks for taking the time to really dig into it!

/lgtm

authors: heckj tengqm


text:
open dual stack feature gate for apiserver is needed

according to https://github.com/kubernetes/website/pull/19682#issuecomment-602279846, I open this pr.

apiserver should open dual stack feature gate
iptables with dual stack is supported since kubernernetes 1.18

/cc @jimangel

@pacoxu the documentation merge for v1.18 has happened. Can you rebase against master and update the merge base for this PR?

This content is still relevant based on https://github.com/kubernetes/website/pull/19682#issuecomment-610062502.
/reopen

The repository that submitted this pull request has been deleted.

Well, shoot.

authors: aojea pacoxu sftim zacharysarah


text:
Adding SIG-Windows Spotlight blog post with images.

This is a blog post that is a part of the Kubernetes Upstream Marketing team's work to profile SIGs. The post features SIG-Windows - what they do and who they are. It has been reviewed by the Kubernetes Upstream Marketing Team's editor @mbbroberg.

love this kaslin :) has the windows folks reviewed, too?

love this kaslin :) have the windows folks reviewed, too?

I've invited them to review it on this PR. They should get to it later today hopefully.

This feedback is mostly nits.
@celestehorgan you're planning to join the Naming WG so maybe you can answer: how important is it that this blog article uses “control plane” rather than “master”? Should that detail block a merge?

Thanks for the suggestions! I've accepted and committed them.

/sig windows

It's a great read. Happy to :+1: after a windows team gives a final look. Congrats on your first PR @kaslin!

/lgtm
/approve
@kubernetes/sig-windows-misc can you take a look?

my bad folks. i added some comment to the hackmd last night. once incorporated, i can approve this

@michmike incorporated your changes from the hackmd. Thank you for the feedback! Sorry for the delay. I was out for the holiday weekend. If these changes look good, it should be good to go.

@michmike incorporated your changes from the hackmd. Thank you for the feedback! Sorry for the delay. I was out for the holiday weekend. If these changes look good, it should be good to go.

thanks for the update. i didn't have time to re-read the whole thing, but i skimmed it and it looks good to me
/lgtm
/approve

authors: kaslin mbbroberg michmike parispittman sftim zparnold


text:
Typo fix in basic-stateful-set.md

Typo fix in basic-stateful-set.md

@mohansethu1983 :wave: any chance you're able to sign the CLA? If there's no response on this PR over the next 7 days, the next reviewer may close the PR.
Let me know if we can help! Thanks!

/check-cla

@mohansethu1983 👋 Please feel free to reopen this PR when you're ready to sign the CLA.
/close

authors: jimangel kbhawkey mohansethu1983 zacharysarah


text:
Update overview.md

/hold
This PR is not for master.

/hold
This PR is not for master.

https://github.com/k8smeetup/website-tasks/issues/3431我是在这个页面接的任务

@Sophy417 That repo has been deprecated for a long time... Sorry if this is confusing.

@Sophy417 The whole zh localization team work is now part of the kubernetes/website repo. Just search issues here with label language/zh.

/hold
This PR is not for master.

那是应该提交到哪个分支吗？是对哪个分支版本的修正吗？

If you are fixing bugs on an old branch, propose your PR to that specific branch, say release-1.16.
If you are working on the master branch, submit your PR to master instead.
We don't actively work on old/archived versions, although critical bug fixes are still accepted.

If you are fixing bugs on an old branch, propose your PR to that specific branch, say release-1.16.
If you are working on the master branch, submit your PR to master instead.
We don't actively work on old/archived versions, although critical bug fixes are still accepted.

好的


text:
[zh] Resync and fix kube-scheduler reference

Preview: https://deploy-preview-26182--kubernetes-io-master-staging.netlify.app/zh/docs/reference/command-line-tools-reference/kube-scheduler/

Preview: https://deploy-preview-26182--kubernetes-io-master-staging.netlify.app/zh/docs/reference/command-line-tools-reference/kube-scheduler/

/lgtm

/lgtm

authors: pigletfly tengqm


text:
fix default value of nodefs.inodesFree on linux

Reference PR: https://github.com/kubernetes/website/pull/25934

/lgtm

/lgtm

/approve

/unhold

hold cancel

/hold cancel

authors: Cweiping celestehorgan tengqm


text:
[fr] Deleted reference to removed file

en PR https://github.com/kubernetes/website/pull/28087/files
/assign @remyleone

cc @remyleone

/lgtm
/approve

authors: Arhell remyleone


text:
Added Note for Deprecation of Flexvolume

Issue #30180
Description : marked flexVolume deprecated for v1.23
Changed to branch dev-1.23 for pr https://github.com/kubernetes/website/pull/30216

/cc @jlbutler

/assign @ramrodo

/lgtm

/approve

authors: chetak123 jlbutler ramrodo reylejano


text:
Remove support for seccomp annotations

We do not mention the annotation any more since it will be removed in v1.25.0.
Refers to https://github.com/kubernetes/enhancements/issues/135
Kubernetes PR: https://github.com/kubernetes/kubernetes/pull/109819

/hold
pending merge of https://github.com/kubernetes/kubernetes/pull/109819

/milestone 1.25
/cc @kcmartin

@sftim updated the PR according to the changes in https://github.com/kubernetes/kubernetes/pull/109819, PTAL

https://github.com/kubernetes/kubernetes/pull/109819 merged
cancelling hold
/unhold

re-applying lgtm from this comment
/lgtm
/approve

authors: reylejano saschagrunert sftim


text:
[ko] Update outdated files in dev-1.24-ko.2 (M42-M43)

M42 ~ M43 까지, workloads/pods 아래 페이지와 관련된 변경사항들을 반영하였습니다.
M42. content/en/docs/concepts/workloads/pods/init-containers.md | 1(+XS) 0(-)
M43. content/en/docs/concepts/workloads/pods/pod-topology-spread-constraints.md | 9(+XS) 8(-)
지난 PR이 베이스 브랜치가 잘못 설정되어있었어서 클로즈 후 재 오픈한 PR입니다.

@NAMU1105 감사합니다! 한 가지 의견을 남겼습니다. 확인 부탁드리며, 반영하실 때 squash까지 수행해 주시면 될 것 같습니다. 😊 /assign

완료했습니다! 꼼꼼히 봐주시고 기다려주셔서 감사합니다

ref #35734

@NAMU1105
한글 브랜치 관리를 위한 노력에 감사드립니다!!
/lgtm
/approve


text:
[zh-cn]sync docs/contribute

Fix https://github.com/kubernetes/website/issues/39984

@tengqm I added syncing of more files in this commit for the issue:https://github.com/kubernetes/website/issues/39984

/approve

CI is failed temporarily. Run the following commands to reset the CI flow:
git reset
git commit --amend --no-edit
git push -f

authors: my-git9 tengqm windsonsea