text:
Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter adguard for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.adguard
   -
ERRORS:

[ ] :heavy_exclamation_mark: [E026] "{'engines': {'node'>='18'}}" is required at package.json, "{'engines':{'node'>='18'}}" is recommended
[ ] :heavy_exclamation_mark: [E405] Icon must be in the following path: https://raw.githubusercontent.com/iobroker-community-adapters/ioBroker.adguard/main/admin/; correct sources-dist.json
[ ] :heavy_exclamation_mark: [E407] Meta URL must be equal to https://raw.githubusercontent.com/iobroker-community-adapters/ioBroker.adguard/main/io-package.json; correct sources-dist.json
[ ] :heavy_exclamation_mark: [E426] Icon must be in the following path: https://raw.githubusercontent.com/iobroker-community-adapters/ioBroker.adguard/main/admin/; correct sources-dist-stable.json
[ ] :heavy_exclamation_mark: [E428] Meta URL must be equal to https://raw.githubusercontent.com/iobroker-community-adapters/ioBroker.adguard/main/io-package.json; correct sources-dist-stable.json

WARNINGS:

[ ] :eyes: [W135] "common.tier" is required in io-package.json. Please check https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/objectsschema.md#adapter.
[ ] :eyes: [W181] "common.license" in io-package.json is deprecated. Please define object "common.licenseInformation"
[ ] :eyes: [W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".
[ ] :eyes: [W521] "gulp" found at devDependencies at package.json but no "gulpfile.js" found. Is this dependency really required?
[ ] :eyes: [W953] .npmignore found - consider using package.json object "files" instead.

:thumbsup: No suggestions found
Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:
@iobroker-bot recheck
or
@iobroker-bot recreate
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
Note: This issue replaces issue #585
@mcm1957 for evidence
Last update at Sat, 19 Oct 2024 08:30:57 GMT based on commit 2873e7463f12f629813714d716e1f20cfe0235df
ioBroker.repochecker 3.1.3

@ioBroker-Bot recheck

@ioBroker-Bot recheck


text:
New Cases

Wäre es möglich yesterdayCases und yesterdayDeaths zu implementieren?

Die API gibt diese Zahlen leider nicht her.

koennte man als Berechnung einbauen ... hmm wen richtig bedarf kann man drüber nachdenken ich habe jetzt erstmal die Städte und kreise richtig eingebunden

Ich habe mir ein kleines Java-Script gebaut, welches ich per Chronjob einmal pro Tag ausführen lasse. Mit diesem Cronjob werden kurz vor 0 Uhr nachts (ab ca. 22 Uhr kommen eh keine neuen Zahlen mehr rein) dann die todaycases nach neuinfizierte geschrieben. Diese loggt dann bei Änderung automatisch in die SQL-Datenbank, so dass ich dann eine Liste von täglich infizierten habe, die ich über Flot im Balkendiagramm ausgeben kann.

@Kampfratte würdest du dieses Script zur Verfügung stellen? Danke!

createState('javascript.0.Corvid-19.Neuinfizierte', 0, {unit: "", name: "neu Infizierte D", type: "number", role: "value"});
schedule('58 23 * * *', function (Corvid) {
var neue1 = getState('coronavirus-statistics.0.Germany.todayCases').val;
setState('javascript.0.Corvid-19.Neuinfizierte', (neue1), true);

});
Das ist alles.

@ Danke

@Kampfratte
Das wird so aber nur bedingt funktionieren, da auch Werte nach 0h noch rein kommen. Liegt an der Zeitzonen der jeweiligen Länder.
Z.b. gestern kam die letzte Aktualisierung erst um 01.49h:

@Scrounger mir ging es dabei nur um die Zahlen in Deutschland. Nicht weltweit.

da ich die Daten nicht consequent zu zeit x als vorigen tage bestempeln kan werde ich es auch nicht im adapter integrieren (währe schein Funktionalität)
Man kann sich mit script oder Daten logging behelfen wo gewuenst.

source: gharchive/issue

authors: DutchmanNL Kampfratte Scrounger lapidu

license: MIT

license_type: permissive

license_source: github-api


text:
Adapter startet nicht durch

Guten Tag,
der Adapter startet einfach nicht richtig seit dem update.
Habe bereits mehrmals versucht diesen neu zu installieren aber jedes mal startet er nur bis

mihome-vacuum.0
2023-11-07 18:33:37.476
info
IOT enabled, create state

mihome-vacuum.0
2023-11-07 18:33:37.378
info
State value to set for "mihome-vacuum.0.deviceInfo.wifi_signal" has to be type "number" but received type "string"

mihome-vacuum.0
2023-11-07 18:33:37.274
warn
This object will not be created in future versions. Please report this to the developer.

mihome-vacuum.0
2023-11-07 18:33:37.271
warn
Object mihome-vacuum.0.deviceInfo.wifi_signal is invalid: Default value has to be type "number" but received type "string"

mihome-vacuum.0
2023-11-07 18:33:37.162
info
starting. Version 4.0.0 in /opt/iobroker/node_modules/iobroker.mihome-vacuum, node: v18.17.1, js-controller: 5.0.12

bin ehr Laie und kann den Fehler nicht finden.
Bin für jede Hilfe echt dankbar .

Bitte debug log hier posten, so kann man nichts erkennen

mihome-vacuum.0
2023-11-07 20:15:04.009
debug
Helo message Timeout

mihome-vacuum.0
2023-11-07 20:14:52.007
debug
Helo message Timeout

mihome-vacuum.0
2023-11-07 20:14:40.003
debug
Helo message Timeout

mihome-vacuum.0
2023-11-07 20:14:28.002
debug
Helo message Timeout

mihome-vacuum.0
2023-11-07 20:14:15.999
debug
Helo message Timeout

mihome-vacuum.0
2023-11-07 20:14:03.995
debug
Helo message Timeout

mihome-vacuum.0
2023-11-07 20:13:51.993
debug
Helo message Timeout

mihome-vacuum.0
2023-11-07 20:13:51.993
debug
Helo message Timeout

mihome-vacuum.0
2023-11-07 20:13:49.989
debug
server started on 0.0.0.0:53421

mihome-vacuum.0
2023-11-07 20:13:49.982
info
IOT enabled, create state

mihome-vacuum.0
2023-11-07 20:13:49.977
debug
MIIO: Config: ip:192.168.178.45 token: 4a70436c75XXXXXXXXX

mihome-vacuum.0
2023-11-07 20:13:49.976
debug
Create State for deviceInfounsupported

mihome-vacuum.0
2023-11-07 20:13:49.975
debug
Create State for deviceInfowifi_signal

mihome-vacuum.0
2023-11-07 20:13:49.975
debug
Create State for deviceInfofw_ver

mihome-vacuum.0
2023-11-07 20:13:49.974
debug
Create State for deviceInfomodel

mihome-vacuum.0
2023-11-07 20:13:49.973
debug
Create State for deviceInfomac

mihome-vacuum.0
2023-11-07 20:13:49.972
debug
Create State for deviceInfo

mihome-vacuum.0
2023-11-07 20:13:49.934
debug
load Map creator... true

mihome-vacuum.0
2023-11-07 20:13:49.831
info
starting. Version 4.0.0 in /opt/iobroker/node_modules/iobroker.mihome-vacuum, node: v18.17.1, js-controller: 5.0.12

mihome-vacuum.0
2023-11-07 20:13:49.283
debug
Plugin sentry Initialize Plugin (enabled=true)

mihome-vacuum.0
2023-11-07 20:13:49.170
debug
States connected to redis: 127.0.0.1:9000

mihome-vacuum.0
2023-11-07 20:13:49.097
debug
States create User PubSub Client

mihome-vacuum.0
2023-11-07 20:13:49.096
debug
States create System PubSub Client

mihome-vacuum.0
2023-11-07 20:13:49.076
debug
Redis States: Use Redis connection: 127.0.0.1:9000

mihome-vacuum.0
2023-11-07 20:13:49.031
debug
Objects connected to redis: 127.0.0.1:9001

mihome-vacuum.0
2023-11-07 20:13:49.019
debug
Objects client initialize lua scripts

mihome-vacuum.0
2023-11-07 20:13:48.962
debug
Objects create User PubSub Client

mihome-vacuum.0
2023-11-07 20:13:48.960
debug
Objects create System PubSub Client

mihome-vacuum.0
2023-11-07 20:13:48.957
debug
Objects client ready ... initialize now

mihome-vacuum.0
2023-11-07 20:13:48.906
debug
Redis Objects: Use Redis connection: 127.0.0.1:9001

Was ist das denn für ein mdell?

s5 max

Dein robbi scheint nicht erreichbar. Firewall? Gerät ausgeschaltet, oder nicht im netzwerk/wlan?

über handy app gehts ohne probleme auch meine fritzbox meckert nicht

halt stop mit CMD kann ich ihn nicht anpingen

Kannst du mal schauen, ob es noch einen zombie prozess auf dem iobroker server läuft? Aber eigentlich kann es nicht sein, weil er sonst wegem dem port meckern würde.

wie finde ich diesen zombie prozess

oha hab den Fehler gefunden .
Mein Mädel ....     hat in der app rumgespielt und den robotor geupdated iwie muss er sich dort verhaspelt haben... auf jeden fall hat er sich zwar angemeldet an der Fritzbox aber anscheind auch nicht richtig . habe den roboter und die fritzbox neu gestartet jetzt komuniziert er wieder mit mir.
manchmal sollte man nicht so kompliziert denken .
Sry
Trotzdem danke für deine schnelle reaktion und zeit.

Gerne, kein problem. Schön, das er wieder mit dir spielt...

authors: SidvsKaliman dirkhe


text:
Refactor API

We have decided to separate the server from the frontend. In this code, I have added all the server content.
Also, I have modify the .gitignore file to prevent upload unnecessary folders.

This PR will be closed due to changes in the database selected. We are going to use DyanmoDB in place of C*

source: gharchive/pull-request

repo: ioet/cmd-server


text:
Notificaciones push de escritorio con One Signal

Hola equipo de ion-book,
Desde hace unos meses que los sigo y encuentro muy buenos sus artículos. Propongo que para complementar el artículo de Lavano sobre notificaciones push para móviles, agreguen uno para enviar las notificaciones a escritorio, pensando en tener en version web una app en ionic3
Quedo atento a sus comentarios
Saludos
Matías Álvarez Sabaté

Hola @matiasAS !
Lo tendre en cuenta para nuestros proximos artículo, es un tema que tambien me interesa

Si @nicobytes seria muy útil, sobre todo en mi caso que como tu sabes sigo con mi proyecto de tesis, y que como lo he dicho en el canal de slack, es web y movil
Gracias!!

authors: matiasAS nicobytes

repo: ion-book/blog-ngclassroom


text:
Ion-button on changing icon button disappears.

I am using Ionic4 with vueJs. I have a button with star icon inside. When I add color to this star icon then button disappear.
Steps:

Open view then star color is dependent on data variable isMarkedFavorite.
Call function to toggle value of isMarkedFavorite.
Icon disappears

Value of isMarkedFavorite is working fine true/false but when value changes icon disappears.
  <ion-button>
    <ion-icon  :class="{markedfavorite: isMarkedFavorite}" name="star"></ion-icon>
  </ion-button>

.markedfavorite {
    color: #ffdb1a !important;
}

Ionic Info
https://unpkg.com/@ionic/core@4.0.0-beta.11/dist/ionic.js

I have to use below code (using v-show instead of class and v-if) to get it working:
<ion-button fill="solid" color="secondary" v-on:click="markItemAsFav(settings);">
        <ion-icon v-show="isMarkedFavorite" class="markedfavorite" name="star"></ion-icon>
        <ion-icon v-show="!isMarkedFavorite" name="star"></ion-icon>
      </ion-button>

repo: ionic-team/ionic


text:
this.platform.exitApp(); doesn't work for ionic v4.1.2

Originally posted by @Riyaz0001 in https://github.com/ionic-team/ionic/issues/14803#issuecomment-421638592
This is Working only in login Page .Other Pages just going back to previous page

Feature request is: Add exitApp() to Platform again to close a cordova app

Sorry but I am closing the issue since it does not follow the issue template and does not explain what are the expectations.
Closing an app programmatically is not possible, the only way is to crash the app, and Apple could reject your app if you do that on purpose.

authors: manigujjula manucorporat paulstelzer


text:
bug: ion-item > inputs are all disabled if a child of ion-item is

Bug Report
Ionic version:

[x] 4.6
Current behavior:
Let's pretend a ion-item have some input childs like ion-checkbox or ion-input. If one of the child input is [disabled]="true", the whole ion-item is disabled too.
Expected behavior:
The parent should not be responsable for child disability.
Steps to reproduce:
Just have a ion-item with some child inputs.
Related code:
<ion-item>
    <ion-checkbox [disabled]="true"></ion-checkbox>
    <ion-input type="text" [disabled]="false"></ion-input>
</ion-item>

One of the child is disabled, so ion-item is disabled too.
Other information:
I used this workaround to keep the ion-item "not disabled".
ion-content {
  ion-item {
    pointer-events: auto;
  }
}

It seems like the .item-interactive-disabled  class is responsible for this behavior.
Ionic info:

Ionic:

   Ionic CLI                     : 5.2.1
   Ionic Framework               : @ionic/angular 4.6.0
   @angular-devkit/build-angular : 0.800.6
   @angular-devkit/schematics    : 8.0.6
   @angular/cli                  : 8.0.6
   @ionic/angular-toolkit        : 2.0.0

Cordova:

   Cordova CLI       : 9.0.0 (cordova-lib@9.0.1)
   Cordova Platforms : android 8.0.0
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 4.1.1, (and 7 other plugins)

Utility:

   cordova-res : 0.3.0 (update available: 0.5.1)
   native-run  : not installed

System:

   NodeJS : v11.14.0 (/usr/bin/node)
   npm    : 6.9.2
   OS     : Linux 5.0

Fixed by dfa2b13c3a408c6288acc38ce5de480ff04c88fc, this will be in the 4.6.1 release, please follow along on this issue: https://github.com/ionic-team/ionic/issues/18655. Thank you!

authors: Dinath brandyscarney


text:
There is no hot update plugin to replace the unavailable cordobia-hot-code-push

Is there a hot update plug-in to replace the unavailable cordobia-hot-code-push?
for ionic5 react

Thanks for the issue. Please see my response here: https://github.com/ionic-team/ionic/issues/21131#issuecomment-619996951.


text:
ionic html5 video tag

hi, i have a problem with using html5 video tag.
The code is vey simple, like this:
<p>
  <video width="100%" controls src="http://192.168.1.130:8080/fast4j/ueditor/jsp/upload/video/20160922/1474535781986094632.mp4" type="video/mp4"></video>
</p>

When i use command with 'ionic serve', it's running ok.
But i installed apk to android device, it doesn't work. After a few minutes, it's progressing, but has no video & no voice.

Hello, thanks for using Ionic! What version of Android is your device running?

Hi, My device's android version is 6.0.

I try my best, now, running on the android device is ok.
But it doesn't running on the ios device.

enviroment as shown:

iphone 6s plus
ios 9.3.5
it can not be played.

@meiyalei No problem in Ionic and yes Platform IOS see https://forum.ionicframework.com/t/ios-background-audio-works-on-emulator-not-on-device/12948/2 or add plugin cordova-plugin-backgroundaudio

@meiyalei would you mind trying our fork of the WKWebView plugin and seeing if that fixes the issue for you? Thanks!

sorry,i have tried it. But it doesn't be played.
In the video source there is a play button,  is a triangle with a slash.

The html5 video label like this:

mp4:
video codec  -> h.264 avc
audio codec  -> aac
it's my code and video source configuration. Have something wrong with it ?

Hello, I am very sorry for the delay on this! After reviewing this issue again it seems like the issue is because your loading the video from an unsecure http url. iOS only allows requests to https url's. I would recommend making sure that you access assets only from https url's. Thanks for using Ionic!

Can any one helped me? really I need to fix issue. video is not showing in ionic 3 while it is working in  simulter and also same code working with ionic 2. Please see below my following code:-
HTML code:

config.xml:

scss:
.bg-vid {
position: absolute;
top: 50%;
left: 50%;
min-width: 100%;
min-height: 100%;
width: auto;
height: 100%;
z-index: -100;
-webkit-transform: translateX(-50%) translateY(-50%);
-moz-transform: translateX(-50%) translateY(-50%);
-ms-transform: translateX(-50%) translateY(-50%);
-o-transform: translateX(-50%) translateY(-50%);
transform: translateX(-50%) translateY(-50%);
background-size: cover;
}
Thanks in adavanced

authors: enestdharam jgw96 meiyalei ramonornela


text:
需要中文文档

请增加一份中文文档吧

@zhanchi88 This is not in our current plan.

repo: ionicfirebaseapp/getwidget


text:
Adjust bokeh_plot() args

Add required bokeh_plot() arg "time", and remove unused arg "var_name".

@MeanLowDrew don't have enough tests implement to check this change. If you are still interested in getting this one in do you mind adding one? I will try to test this locally and, if that required some bokeh pinning, I'll update the PR and merge it.

authors: MeanLowDrew ocefpaf


text:
Auto Labels

Labels should be automatically added to invocations based on agent usage.
See: https://github.com/iopipe/launchpad/issues/46

Blocked by #97, since there will need to be so many new labels to be tested the way the current code is, it will just be a giant mess testing it.

Waiting for #97, but I can work on this and rebase whatever changes happen since there should be no conflicts at all.

Working on this in #108 .

authors: XerTheSquirrel kolanos

repo: iopipe/iopipe-java


text:
[atom s3] Add display image mode

https://github.com/iory/riberry?tab=readme-ov-file#displaying-images-on-atom-s3
I added a mode to the Atom S3 to ensure the feature for displaying images in the README works correctly.

When AtomS3 is DisplayImageMode but /display_image param is not set, AtomS3 LCD is black.
Can you add "Waiting for ..." message during mode transition waiting time?
Please look at https://github.com/iory/riberry/pull/53

When mode is changed, all lcd data is deleted by atoms3lcd.resetLcdData();.
https://github.com/iory/riberry/blob/7096d2c0a9e1dca7373c57f08796d25af1e44d42/firmware/atom_s3_i2c_display/src/main.cpp#L41

Thanks for your review.
I added class variable mode_changed and by using it display Waiting for ... message

repo: iory/riberry


text:
Refactor send functions

Description
I see multiple issues with our send functions. Let's use this issue to discuss them and eventually split it up in multiple issues if needed:

Our basic send function is called send_amount. And our "advanced" or send output function is called send (although in the bindings we call it send_outputs/sendOutputs). I think it should be the other way around:
You want to send something without any fancy stuff? Use send.
You need more advanced outputs? Use send_outputs

SendAmountParams:
a) Do we really need that as it's own object, class struct? Can't the send function be send(amount, address, options)?
b) If we keep it, can we rename the var to something else than output in the examples? It's confusing 😆 . Let's call it params or something

Are you planning to do it yourself in a pull request?
No.

Our basic send function is called send_amount. And our "advanced" or send output function is called send (although in the bindings we call it send_outputs/sendOutputs). I think it should be the other way around:
You want to send something without any fancy stuff? Use send.
You need more advanced outputs? Use send_outputs

We agree, we'll change it.

SendAmountParams:
a) Do we really need that as it's own object, class struct? Can't the send function be send(amount, address, options)?
b) If we keep it, can we rename the var to something else than output in the examples? It's confusing 😆 . Let's call it params or something

We don't really agree, there is more to SendAmountParams than just amount and address. Also these functions take an array of SendAmountParams and not a single amount/address tuple.

We don't really agree, there is more to SendAmountParams than just amount and address. Also these functions take an array of SendAmountParams and not a single amount/address tuple.

But why can't the other options be part of "options"?
In most cases people probably just want to do something like send(10, "rms...") and for the 10% edge cases we provide something like send(10, "rms...", Options::new().with_expiration())

Please have a look at #725 and comment on it whether you'ld be okay with it. I don't think merging the other params with the transaction options is a good idea, though.

Before closing this issue bindings still need to be updated with this https://github.com/iotaledger/iota-sdk/pull/725

authors: Alex6323 Dr-Electron Thoralf-M thibault-martinez

repo: iotaledger/iota-sdk


text:
Testnet indexer request takes multiple seconds

Bug description
I noticed that transactions are loaded pretty slowly on the explorer, one has to wait usually multiple seconds (5-10-15) for them to appear on the bottom of either the Pacakge/Object view page or on the Checkpoint page.
Looking at the monitoring dashboard, the cause of the slow loading is the huge response time from the indexer instance. On the attached screenshot you can see the spike that occured when this explorer page was opened:

The red line marks the indexer metric.
The blue line is the access node with JSON RPC, not relevant for this problem.
What takes time during the explorer page load is loading transactions that are part of the checkpoint. As you can see, these are simple consensus txs, nothing fancy, and there are only 4, so I suspect that the problem is either some setup/config on the machines or the lack of pruning.

A first inquiry suggests the following:

iotax_queryTransactionBlocks (filters txs by checkpoint id) performs consistently with what is reported here (~14,15 sec)
A naive 1+N query (iota_getCheckpoint + iota_getTransactionBlocks) performs much better (~4s) but still has large latency.
GraphQL responds rapidly{
  checkpoint(id: {sequenceNumber: 10843159}) {
    transactionBlocks {
      nodes {
        digest
        sender {
          address
        }
        gasInput {
          gasPrice
          gasBudget
        }
        effects {
          status
          errors
          timestamp
          objectChanges {
            edges {
              node {
                idCreated
                idDeleted
              }
            }
          }
        }
      }
    }
  }
}

So it seems that we can seek to optimize the query in the indexer JSON-RPC server, following the call in the graphQL server.

Replicated the slowness on local setup by artificially increasing indexer DB size to contain ~20M records (I believe it's a bit above 40M on testnet now) in transactions table.
Calling:
curl 'localhost:9005/'   -H 'content-type: application/json'   --data-raw '{
      "jsonrpc":"2.0",
      "id":4,
      "method":"iotax_queryTransactionBlocks",
      "params":[{"filter":{"Checkpoint":"10"},"options":{"showEffects":true,"showInput":true}},null,20,true]}'

Makes diesel generate and execute a query similar to the following:
SELECT *
FROM transactions
WHERE checkpoint_sequence_number = 10
ORDER by tx_sequence_number DESC;

which is slow (~40s) because of missing index on checkpoint_sequence_number (the only index is tx_sequence_number).
I didn't deeply investigate what graphql does internally, but since the entrypoint of the query is the checkpoin object, I assume that it may start looking at the checkpoints table, get transaction ids from there and then go for transactions table.
Such approach would be very fast, even without additional indexes.
The following query takes only 0.1s, producing the same results as the query above.
SELECT *
FROM transactions
WHERE tx_sequence_number between (
	select min_tx_sequence_number from checkpoints where sequence_number = 10
) and (
	select max_tx_sequence_number from checkpoints where sequence_number = 10
)
ORDER BY tx_sequence_number DESC;

Creating the index:
CREATE INDEX transactions_checkpoint_sequence_number ON public.transactions USING btree (checkpoint_sequence_number)

makes the original query perform really fast (<0.01s) and also speeds up iotax_queryTransactionBlocks endpoint to around 0.3s.

I didn't deeply investigate what graphql does internally, but since the entrypoint of the query is the checkpoint object, I assume that it may start looking at the checkpoints table, get transaction ids from there and then go for transactions table.
Such approach would be very fast, even without additional indexes.

Ideally we would like to avoid adding a new index, as it will affect insertion time and hence transaction effects latency with the current setting.
So this solution seems like a good candidate. I would suggest that you resolve the query used by GraphQL to match the performance.

This patch might be relevant too.

What graphql is doing is:
First it gets the range of transaction ids for given checkpoint via query:
SELECT network_total_transactions
FROM checkpoints
WHERE sequence_number IN (16, 17)
ORDER BY network_total_transactions ASC;

It queries for network_total_transactions of checkpoint that is being queried, and one checkpoint before it.
Which is followed by a second query:
SELECT *
FROM transactions
WHERE tx_sequence_number >= 63
  AND tx_sequence_number < 67
ORDER BY tx_sequence_number ASC
LIMIT 22;

which is using values from the previous one to filter tx_sequence_number.
I wonder why it's not using the min_tx_sequence_number and max_tx_sequence_number, but otherwise the approach seems to be very similar to the one suggested in https://github.com/iotaledger/iota/issues/4516#issuecomment-2550983123 and in the upstream patch.

authors: kodemartin lzpap tomxey

repo: iotaledger/iota


text:
🛑 备用KMS激活服务器 06 is down

In a855ec5, 备用KMS激活服务器 06 (s06.ikms.eu.org) was down:

HTTP code: 0
Response time: 0 ms

Resolved: 备用KMS激活服务器 06 is back up in 4604014 after 13 minutes.

repo: iougemini/ikms-uptime


text:
Move ast.h class definitions into ast.cpp

We do inline definitions in a couple places but that number is starting to grow. We should really define these methods in the .cpp so it doesn't take forever to recompile bpftrace if you modify the ast code.
See src/ast/ast.h and src/ast/ast.cpp.

Can I grab this one?

Sorry, taking this one. Working on #1047 and it made sense to do this first.

Not a problem. Thank you!

authors: danobi vladdy

repo: iovisor/bpftrace

license_source: bigquery


text:
Fix compilation

There was a non-backward compatible change to  appendToQueryString in servant https://github.com/haskell-servant/servant/pull/1432
This PR adds intermediate conversion from Text to ByteString.

Thanks https://github.com/ip1981/openweathermap/commit/d625bb9213bc78730f98c556d59813b444235fc4

license: WTFPL


text:
Spawn each observer on a new thread

Or as a new node?
Also the diagnostics topic has the prefix as the observer's name.

Already running on a separate thread. Nothing to be done here:
https://github.com/ipa-hsd/rosgraph_monitor/blob/051b177cc1b5239115b3432966532e4f992f39b9/src/rosgraph_monitor/observer.py#L30-L44
@ipa-kut


text:
CMake Build Fails to Download Eigen

Following the build instructions on macOS, I obtain the following error:
error: downloading 'http://bitbucket.org/eigen/eigen/get/3.3.7.tar.bz2' failed
status_code: 22
status_string: "HTTP response code said error"
Navigating the to the quoted URL, Bitbucket reports that:
Repository unavailable
Bitbucket no longer supports Mercurial repositories.

Looks like Eigen had moved over to GitLab, and we need to update the CMake download.

I updated the problematic dependencies. Could you please try with the latest commit?

The latest commit fixes the Eigen issue in my tests -- thanks for the super quick fix!

authors: breannansmith zfergus

repo: ipc-sim/IPC


text:
Cannot upload directory

Uploading is currently broken when dropping a directory

Just for the record, I've added it to https://github.com/ipfs-shipyard/ipfs-companion/issues/342

I believe this has been fixed under other issues. Please feel free to re-open if needed.

Still open: hoped to delegate sharing to webui, so never got to fixing the sharing page bundled with Companion.

authors: alanshaw jessicaschilling lidel

repo: ipfs-shipyard/ipfs-companion


text:
Fatal crash when trying to open directories

I'm repeatedly killing Desktop when trying to select the following options under Advanced:

Open Logs Directory
Open Repository Directory
Open Configuration File

Specifications

OS: darwin
IPFS Desktop Version: 0.13.0
Electron Version: 9.3.2
Chrome Version: 83.0.4103.122

Error
TypeError: shell.openItem is not a function
    at click (/Applications/IPFS Desktop.app/Contents/Resources/app.asar/src/tray.js:141:32)
    at MenuItem.click (electron/js2c/browser_init.js:65:1624)
    at Function.executeCommand (electron/js2c/browser_init.js:73:1102)

I can confirm the same error on Linux.
Specifications

OS: linux
IPFS Desktop Version: 0.13.0
Electron Version: 9.3.2
Chrome Version: 83.0.4103.122

Error
TypeError: shell.openItem is not a function
    at click (/home/lidel/tmp/test-13/ipfs-desktop-0.13.0-rc3/ipfs-desktop-0.13.0-linux-x64/resources/app.asar/src/tray.js:141:32)
    at MenuItem.click (electron/js2c/browser_init.js:65:1624)
    at Function.executeCommand (electron/js2c/browser_init.js:73:1102)

Potential duplicate: https://github.com/ipfs-shipyard/ipfs-desktop/issues/1677

authors: jessicaschilling lidel

repo: ipfs-shipyard/ipfs-desktop


text:
Which browsers/versions do we support?

Our JS community guidelines say what Node version we support, but what about browsers?

We use @babel/preset-env, which means we don't have to worry about not using new language features, but I believe it sometimes polyfills depending on support in the current runtime which can lead to problems where detecting native support for something is required (e.g. see the section "Using ES2017 async functions" -> https://caolan.github.io/async/ (can't deep link, sorry)).

@vmx has found this list in the Aegir source code:
exports.browserslist = [
  '>1%',
  'last 2 versions',
  'Firefox ESR',
  'not ie < 11'
]

It was last updated 9 months ago - worth adding to our contributing docs?

This website provides handy visualization what the current browserslist really means:

https://browserl.ist/?q=>1%25%2C+last+2+versions%2C+Firefox+ESR%2C+not+ie+<+11

last 2 versions may be a problematic entry – it pulls in some fringe vendors with less than 1% of market penetration,  which in turn introduces polyfils for them.

without last 2 versions: https://browserl.ist/?q=>1%25%2C+Firefox+ESR%2C+not+ie+<+11

For anyone searching through old issues, the list of supported platforms is here: https://github.com/ipfs/community/blob/master/CONTRIBUTING_JS.md#supported-platforms

authors: achingbrain lidel

repo: ipfs/community


text:
"fragment hints" or "web seeding"

Is your feature request related to a problem? Please describe.
The "problem" this solves is that of wanting IPFS to serve as a back up for a file against its web host going down, while simultaneously using the web host (or, perhaps, multiple web hosts) as a back up in the case of no-one seeding the file in IPFS (or all currently-seeding peers being inaccessible).
Describe the solution you'd like
Two possible solutions; either/or would be great:

The IPFS Companion add-on should attempt to fetch the following file from IPFS, at least in the case of the link itself going HTTP 404/403/410/451 or being hijacked (as its referent site has been, though the following link is at least valid for now):
https://s3.amazonaws.com/files.cloudprivacy.net/ssl-mitm.pdf#:~:x-ipfs-path=/ipfs/QmVSSCvbYX8XHVcf2kqrpGGmH5PdCbgAP11CCJXrrJQ2yJ
The IPFS Companion add-on should attempt to treat Amazon AWS and the other named servers as "web seed"-like peers when attempting to fetch the following URL:
https://ipfs.io/ipfs/QmVSSCvbYX8XHVcf2kqrpGGmH5PdCbgAP11CCJXrrJQ2yJ?filename=ssl-mitm.pdf#:~:x-ipfs-webseed=https%3A//s3.amazonaws.com/files.cloudprivacy.net/ssl-mitm.pdf&x-ipfs-webseed=https%3A//crysp.uwaterloo.ca/courses/cs458/W11-lectures/local/files.cloudprivacy.net/ssl-mitm.pdf&x-ipfs-webseed=https%3A//static.banky.club/shitposter.club/af4ff1a87cec1d73451b030c9c6efbf3f04bc44f0e5e14ebc9b227eb8e03c97e.pdf

Describe alternatives you've considered

Requesting the CDN in question add in x-ipfs-path headers to static files
Hosting it somewhere that includes the appropriate /ipfs slug in the path
Actually seeding the file myself with an IPFS node

Obviously, the webseed-hints wouldn't necessarily need to be kept client-side; they could just as well be comprised by a real URL parameter, which might provide some additional flexibility for future improvements.

here's another suggestion in the same vein:
this fantastic explainer by Ashley Valentijn of Syracuse University

re ipfs://ipfs/bafkreie4wgpls4g5ewmbu25mfeaojmx7zvgwpcpasdmo432iul3

Thank you for brainstorming! Some thoughts / questions (if i missed the mark, please elaborate more):

(1) This flow is tricky, because:

data could be imported to IPFS with custom parameters (different chunks, different hash function, different DAG type)
CID of data imported with default parameters would not match.
Including parameter space in URL is not an option, as one could create DAG by hand, outside of parameters in go-ipfs.
The only way to have all the data to deterministically verify a HTTP response is if the web seed is a CAR file. This is still a good idea :+1: but not sure how useful given someone needs to create a CAR via ipfs dag export

(2)  Is the idea here to fetch from IPFS rather than original URL if user agent support IPFS?

If so, why not link to https://cf-ipfs.com/ipfs/QmVSSCvbYX8XHVcf2kqrpGGmH5PdCbgAP11CCJXrrJQ2yJ?filename=ssl-mitm.pdf, which will work over HTTP and if ipfs-companion is present get loaded from local node?

(3) iiuc not feasible for various reasons

IPFS CID is not a hash of a file, but a hash of a root node of a DAG
There is no web extension API that would allow us to do this in a performant way (requires script injection on every  page)
If you want content integrity verification, you use /ipfs/{cid} paths or DNSLink, and ipfs-companion redirects them to local node, which does the verification natively.

[/ipfs/QmV…2yJ?filename=…&x-ipfs-webseed=…] is tricky, because…data could be imported to IPFS with custom parameters (different chunks, different hash function, different DAG type); CID of data imported with default parameters would not match (including parameter space in URL is not an option, as one could create DAG by hand, outside of parameters in go-ipfs).

Torrents also have different chunking parameters that can lead to different URNs for the same exact file (or even fs-tree), and yet solved web-seeding / leeching from "dumb" HTTP servers without provisioning for said parameters in the URI scheme.
While (as with BitTorrent) active/"real"/software peers will be required to bootstrap the structure of the file (i.e. fetching non-leaf data), once the software has constructed a mapping of the chunkspace onto an fs-tree, it's then clear to pull at least the leaf nodes from HTTP servers. (Admittedly, a ~0.5MiB PDF wasn't a great prototypical example of this, since most people will be able to snap the whole file up in an instant in the same order of time it takes to fetch the metadata.)

[https://cf-ipfs.com/ipfs/QmVSSCvbYX8XHVcf2kqrpGGmH5PdCbgAP11CCJXrrJQ2yJ?filename=ssl-mitm.pdf] will work over HTTP and if ipfs-companion is present get loaded from local node

Per the OP, that (currently) breaks whenever no IPFS client happens to be seeding (pinning) the file at the moment, even if the file's canonical location is still OK. A client supporting x-ipfs-webseed parameters would at least have the possibility not to be left in the dark should the seeding peer drop out mid-transfer.

[ is] not feasible [because] …There is no web extension API that would allow us to do this in a performant way (requires script injection on every page)

I proposed that in light of [#1050]: given that linkification is seemingly deemed acceptable, the particular rubicon of touching pages isn't a blocker—checking links for a specific attribute should be far more performant than scrubbing all text nodes for excerpts that look like IPFS URIs anyway.

authors: JamesTheAwesomeDude lidel

repo: ipfs/ipfs-companion


text:
[gui error report] Error: invalid ip address

👉 Please describe what you were doing when this error happened.
Specifications

OS: win32 10.0.19045
IPFS Desktop Version: 0.30.2
Electron Version: 19.1.9
Chrome Version: 102.0.5005.167

Error
Error: invalid ip address
    at ip2bytes (C:\Users\uu\AppData\Local\Programs\IPFS Desktop\resources\app.asar\node_modules\multiaddr\src\convert.js:108:11)
    at Function.convertToBytes [as toBytes] (C:\Users\uu\AppData\Local\Programs\IPFS Desktop\resources\app.asar\node_modules\multiaddr\src\convert.js:73:14)
    at C:\Users\uu\AppData\Local\Programs\IPFS Desktop\resources\app.asar\node_modules\multiaddr\src\codec.js:109:35
    at Array.map (<anonymous>)
    at stringTuplesToTuples (C:\Users\uu\AppData\Local\Programs\IPFS Desktop\resources\app.asar\node_modules\multiaddr\src\codec.js:103:17)
    at stringToBytes (C:\Users\uu\AppData\Local\Programs\IPFS Desktop\resources\app.asar\node_modules\multiaddr\src\codec.js:221:13)
    at Object.fromString (C:\Users\uu\AppData\Local\Programs\IPFS Desktop\resources\app.asar\node_modules\multiaddr\src\codec.js:231:10)
    at new Multiaddr (C:\Users\uu\AppData\Local\Programs\IPFS Desktop\resources\app.asar\node_modules\multiaddr\src\index.js:56:26)
    at multiaddr (C:\Users\uu\AppData\Local\Programs\IPFS Desktop\resources\app.asar\node_modules\multiaddr\src\index.js:621:10)%0

@RICHDAD07 Can you please provide more information about what you were doing when you received this error?
Also, if you could provide your log files that may help us figure out more about what's happening.

repo: ipfs/ipfs-desktop


text:
Fix broken link to 1st paper

The link to "S/Kademlia: A Practicable Approach Towards Secure Key-Based Routing" is broken. This fixes it with a new url.
Maybe we should just host these on IPFS?

Now just using the archive.org version.

authors: Stebalien heimann

repo: ipfs/reading-list


text:
ipinfo cli crashes when manually entering bulk data

What I did.

I typed: ipinfo bulk
I typed 8.8.8.8
I pressed CTRL+D

What did I expect
The results
What happened?
$ ipinfo bulk
** manual input mode **
Enter all IPs, one per line:
8.8.8.8
panic: interface conversion: interface {} is *interface {}, not *ipinfo.Core

goroutine 1 [running]:
github.com/ipinfo/go/v2/ipinfo.(*Client).GetIPStrInfoBatch(0xc0000256c0, 0xc000055ce0, 0x1, 0x1, 0x0, 0x0, 0x0, 0x0, 0x3, 0xc00001a1b0, ...)
        /home/mslm/dev/ipinfo/cli/vendor/github.com/ipinfo/go/v2/ipinfo/batch.go:288 +0x285
github.com/ipinfo/go/v2/ipinfo.(*Client).GetIPInfoBatch(0xc0000256c0, 0xc000180000, 0x1, 0x2710, 0x0, 0x0, 0x0, 0x0, 0x19, 0xc00007e180, ...)
        /home/mslm/dev/ipinfo/cli/vendor/github.com/ipinfo/go/v2/ipinfo/batch.go:260 +0x17a
main.cmdBulk(0x7ffe894f0483, 0x4)
        /home/mslm/dev/ipinfo/cli/ipinfo/cmd_bulk.go:93 +0x449
main.main()
        /home/mslm/dev/ipinfo/cli/ipinfo/main.go:57 +0x398

Solved in https://github.com/ipinfo/cli/releases/tag/ipinfo-1.1.2

authors: MrSeccubus UmanShahzad

repo: ipinfo/cli


text:
🛑 NowBoarding (tokyo) is down

In 683644c, NowBoarding (tokyo) (https://tokyo.nowboarding.club/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: NowBoarding (tokyo) is back up in 73d0e15 after 10 minutes.

repo: iplanwebsites/up


text:
🛑 NowBoarding (tokyo) is down

In 33aade7, NowBoarding (tokyo) (https://tokyo.nowboarding.club/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: NowBoarding (tokyo) is back up in da63afe after 10 minutes.


text:
🛑 Invitation (og.invt.co - v1) is down

In 32177b6, Invitation (og.invt.co - v1) (https://og.invt.co/felix.png?fontSize=%40felix&theme=light&md=1&images=https%3A%2F%2Flh3.googleusercontent.com%2Fa-%2FAOh14GjUk2VKmkWxpgWZgY0CXWRFi_k6t7f2MBSsfSxR%3Ds96-c) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Invitation (og.invt.co - v1) is back up in 3083324.


text:
🛑 Kicking (recu) is down

In 7773706, Kicking (recu) (https://recu.kickinglotus.com/) was down:

HTTP code: 403
Response time: 85 ms

Resolved: Kicking (recu) is back up in f1cd804.


text:
Fix typo in setup process

There's a typo in the setup process that tells the user Login with yout mobile app credentials fixed here.
I also change the title of the prompt to make it clearer that this is an for air purifier.

Thanks for fixing the typo.

authors: gunnaraas iprak

repo: iprak/winix


text:
Add: Benin TV

Channel Name
Benin TV
Alternative Names (optional)
SRTB
Network (optional)
No response
Owners (optional)
Societe de Radio et de Television du Benin
Country
BJ
Subdivision (optional)
No response
City (optional)
Cotonou
Broadcast Area
c/BJ
Languages
fra
Categories (optional)
general
NSFW
FALSE
Launched (optional)
No response
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
https://srtb.bj/benintv/
Logo
https://i0.wp.com/sesameinfo.bj/wp-content/uploads/2023/11/ortb-1.jpg?resize=512%2C470&ssl=1
Notes
No response

Same channel as "ORTB.bj"
Maybe we should add "Benin TV" as an alternative name.

Agreed: feel free to change; as for the Juniors, I'll close it.

repo: iptv-org/database

license: Unlicense


text:
Edit: Viva Cinema

Channel ID (required)
VivaCinema.ph
Channel Name
Viva Cinema
Alternative Names
No response
Network
Viva Television
Owners
Viva Entertainment, Inc.
Country
PH
Subdivision
PH-MNL
City
Manila
Broadcast Area
Quezon City
Languages
tag;eng
Categories
ent;general
NSFW
None
Launched
No response
Closed
No response
Replaced By
No response
Website
https://www.cignal.tv
Logo
No response
Notes
No response

Please update your request:

commas cannot be used in the owner name
broadcast area code is incorrect
category id is incorrect

https://github.com/iptv-org/database/blob/master/CONTRIBUTING.md#channels

authors: Margoux-bit freearhey


text:
Registering custom picklers for a tree of classes

Hi, like working with the pickle part of Pyrolite for Apache Spark / Cassandra / Python integration. However, as I'm using / touching Scala / Cassandra code I need to add some custom picklers and constructors. That's obvious of course, but things would be a lot easier and above all, less error prone if I could register a pickler for an entire tree of classes at once by registering it for a parent class / interface.
To illustrate the issue: in order to support pickling Scala maps, it's easy to write a single simple implementation of net.razorvine.pickle.IObjectPickler. However it has to be registered to every possible specialization of scala.collection.Map. In practice that means registering it for scala.collection.immutable.Map.Map1 and scala.collection.immutable.Map.Map2, etc.
Another example is java.nio.ByteBuffer. The actual objects you'd probably see flying around are of the type java.nio.HeapByteBuffer, which is a package protected class. So you'd have to register pickler something like:
Pickler.registerCustomPickler(Class.forName("java.nio.HeapByteBuffer"), ByteBufferPickler)

while
Pickler.registerCustomPickler(classOf[ByteBuffer], ByteBufferPickler)

should capture just any specialization of ByteBuffer.
Cheers!

I can see the value of such a change.  Should perhaps also be done for the Serpent serializer if this finds its way in the Pickle serializer.

Would it be sufficient if the distinction was made on the basis of registering an interface (to capture all implementing classes) and a specific class (to capture just that one specific class)?

I would think so, yes! Perhaps there are cases where you'd want to catch an inheritance tree based on a root class ... might be an issue.

Just released new version of Serpent as well (1.13) with this feature corrected for Java and .NET

nice!

authors: frensjan irmen

repo: irmen/Pyrolite

license: mit


text:
HTTP API must be able to recover if iRODS server is restarted

API needs to be able to recover.

I've confirmed that the HTTP API crashes if the iRODS server disappears.
We need to investigate why the connection pool didn't refresh the connections or provide a dedicated solution for the HTTP API.

Hmm.   Yes, time for some logging...

We likely need to set a signal handler for SIGPIPE in the HTTP API and tweak the connection handling code in the iRODS libs for this issue.
Unfortunately, that means a new version of the iRODS server would be needed.

authors: korydraughn trel


text:
Add Apache 2.0 license file to project root

Proposed Changes
Add Apache 2.0 license file to project root.

Good catch! Linked the license file in the Readme.

repo: ironcore-dev/libvirt-provider


text:
refactor to use position parameter

change to autodetect if uuid or ulid is given.

Pull Request Test Coverage Report for Build 1225924899

19 of 36 (52.78%)  changed or added relevant lines in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+19.4%) to 51.852%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

cmd/ulid_uuid/ulid_uuid.go
19
36
52.78%

Files with Coverage Reduction
New Missed Lines
%

cmd/ulid_uuid/ulid_uuid.go
3
51.85%

Totals

Change from base Build 1224895878:
19.4%

Covered Lines:
42

Relevant Lines:
81

💛  - Coveralls

authors: coveralls ironpinguin


text:
Request to Restore Removed Methods in Version 3.0

https://github.com/irychen/keepalive-for-react/commit/b1f5c4d7190b96eb10d89afcfd60d6dc1320a0f7#diff-70a1ac362f8ce87279cb4b0a5f1e37dc0d615d5eea5b5570df550d861b9041ecL127-L151
getCaches、removeCache、cleanAllCache 以及 cleanOtherCache 在 3.0 版本被删除了，但是在多 tab 管理中需要用到这些方法，请求恢复这些被删除的方法。

当前有 destroy 方法了，似乎只需要提供 getCaches 方法就行了，其他的方法可以自己实现。

这些因为考虑到，很多场景会误用的情况，因此在3.0版本将其移除，比如getCaches是个异步数据返回，无法保障数据的实时性渲染，因此在多标签页处理上，只需要自己定义tab数据数组即可，不需要对getCaches形成依赖，另外destroy方法调用也不是必须要的，在tab切换和打开新的tab当满足一定条件比如max达到数量之后Keepalive组件会自动将其销毁，因此建议只需要对自己定义的tabs数据数组进行增加和删除即可。
These were removed in version 3.0 due to the consideration that many scenarios might misuse them. For example, getCaches is an asynchronous data return, which cannot guarantee the real-time rendering of data. Therefore, in handling multiple tabs, you only need to define your own tab data array and do not need to depend on getCaches. Additionally, calling the destroy method is not mandatory; when switching tabs and opening new tabs, the Keepalive component will automatically destroy them once certain conditions are met, such as reaching the maximum count. Therefore, it is recommended to simply add and delete from your custom tab data array.

如果无法手动销毁缓存，关闭一个 tab 然后再次打开上次的内容还存在，对于应用来讲这应该是 bug 了，我认为手动销毁还是必须的，getCaches 是异步的也没啥问题，有的话直接销毁，没有缓存直接忽略就可以了。

这样的话确实会这样，因为缓存还在，不过大多数情况影响不大。getCaches和其他方法会加个补丁在下个小版本更新

authors: condorheroblog irychen

repo: irychen/keepalive-for-react


text:
remove unused variables & cycles

Another pass at #374, fixing issues with certain bundlers like Rollup (see #365).

Thanks for the PR, we're also running into this issue, would love to see it merged.

No longer relevant in v9.

authors: Stanzilla eventualbuddha isaacs

repo: isaacs/node-glob

license: isc


text:
freeze CLIP TextEncoder

Hi, the paper pointed out that we should freeze the text encoder of CLIP during training. I wonder how to achieve it and where is the corrresponding code. Thanks!

In my understanding (though I'm not an author), the optimizer selects which parameters to be updated.
https://github.com/isl-org/lang-seg/blob/main/modules/lsegmentation_module.py#L119-L175
Because these lines do not select CLIP parameters (self.net.clip_pretrained), they are frozen.

Thanks @soskek for answering this!
Best wishes for your research! @Ahnsun

authors: Ahnsun Boyiliee soskek

repo: isl-org/lang-seg


text:
🛑 Nutreo.isolucion.co is down

In 92861a2, Nutreo.isolucion.co (https://Nutreo.isolucion.co) was down:

HTTP code: 503
Response time: 148 ms

Resolved: Nutreo.isolucion.co is back up in c974a69.

repo: isolucionco/EstadoIsolucionHosting


text:
Reducing the number of NEA sampling points

https://github.com/lucerlab/GMM-NEA
Questions that I thought about during Štěpán's talk:

Is estimation based on the semiempirical method reliable for cases where spectra widths differ from the reference?
ML for NEA - preferable to optimal sampling or vice versa?
ML for NEA - how to deal with multiple excited states?
How does it differ from the approach published by Barbatti?

Note: stda apparently works well (used at BASF)

https://github.com/grimme-lab/stda
https://github.com/grimme-lab/xtb4stda/

repo: ispg-group/aiidalab-ispg


text:
[HELP!] Coverage with source-maps for pre-compiled typescript code

I am running typescript mocha tests for pre-compiled typescript code (that is there are both typescript and javascript tests, they require from dist, not from src).
The reason to do it this way is because tsconfig for the project is different from tsconfig for the tests - there are several reasons to keep it this way...
I tried:

--exclude-after-remap=false (it is mentioned here: https://www.npmjs.com/package/nyc#source-map-support-for-pre-instrumented-codebases)
@istanbuljs/nyc-config-typescript
sourceMap: true/false

package.json excerpt:
{
  "scripts": {
    "test-spec": "TS_NODE_PROJECT=spec/tsconfig.json mocha -r source-map-support/register -r ts-node/register spec/{**/,}*.spec.{js,ts} -R dot",
    "test-cov": "nyc --exclude-after-remap=false npm run test-spec"
  },
  "nyc": {
    "extends": "@istanbuljs/nyc-config-typescript",
    "exclude": [
      "**/spec/**",
      "node_modules"
    ],
    "require": [
      "ts-node/register"
    ],
    "reporter": [
      "lcov",
      "text-summary",
      "html"
    ],
    "sourceMap": true
  }
}

If I configure it to include only typescript source files, then the coverage report is empty.
There should be some way to configure it to use source maps in dist folder, but I cannot figure it out - I tried different combinations of options but they all seem to assume that I import typescript source files from mocha tests...
Thank you!

Just to add, if mocha tests are pure JS, istanbul shows coverage using available source maps:
"test-spec": "mocha spec/{**/,}*.spec.js -R dot"

So maybe the problem is to make mocha or ts-node to take these source maps into account and to pass them through?

@epoberezkin Did you find a working solution?

I'm having the same problem, tried with sourceMaps: true, inlineSourceMaps: true for tsconfig, tried adding -r source-map-support/register to both nyc or node process. None of the combinations seem to work. I alwasy get coverage for the dist files.

Full disclosure: I haven't spent the time to really understand the problem nor its root cause, but I've managed to get instrumentation working on JS output from the TypeScript, including proper resolution of the source-code filenames from source-maps. My setup is a bit special, since I have a mono-repo structure with tests defined outside of my library package, but I think this should work equally well if ran when tests are co-located with the test files:

I cannot get it working if setting all: true, so this must be false or left out entirely.
I need to include both:

dist/** (containing .js, .d.ts and .js.map files) and
src/** (containing .ts files)

Might or might not be relevant to know that all code in packages/my-lib/dist use CommonJS modules - I haven't tested with ESM.

This is my current configuration:
// integration-tests/tests/.nycrc.json
{
  "cwd": "../..",
  "include": [
    "packages/my-lib/dist/**",
    "packages/my-lib/src/**"
  ]
}

Notice that I use cwd to navigate directory up to allow the package/my-lib to be included relative to the root of my repo.
@rohit-gohri I managed to fix your reproduction, by deleting the all: true from the .nycrc file.

It looks like we had a similar setup and I just found a solution.
/
|-- dist
    |-- (compiled application code here)
|-- src
    |-- (typescript source code here)
|-- test
    |-- dist
        |-- src
            |-- (compiled application code + source map here)
        |-- test
            |-- (compiled test code + source map here)
    |-- (typescript test code here)
    |-- tsconfig.json (for tests)
|-- tsconfig.json
|-- .mocharc.json
|-- .nycrc.json

So basically we had the compiled application code in 2 places; whenever I tried to get typescript coverage based on pre-compiled tests, it showed me 0% coverage no matter the configuration.
After I did the following steps, the problem got magically solved:

rename test/tsconfig.json to tsconig.test.json at root of the project
ditch test/dist and start compiling test code along with application code to dist at project root, while preserving the same structure as before with dist/src and dist/test separation
update nyc & mocha configs according to the path changes

Maybe the fact that application code is present in a nested directory and/or in 2 places at the same time is somehow confusing nyc? Anyway hope my story helps someone :)

authors: LeoKotschenreuther dimatomp epoberezkin kraenhansen rohit-gohri

repo: istanbuljs/nyc


text:
lcov report visualization incorrect

Expected Behavior
Lines that are covered should not appear in red.
Observed Behavior
Lines that are covered sometimes appear in red.
Bonus Points! Code (or Repository) that Reproduces Issue
a.js
import React from 'react';

class A extends React.Component {
  a() {
    const b = 1;
  }
  render() {
    return
Blah
;
  }
}
export default A;

a_spec.js
import React from 'react';
import ReactTestUtils from 'react-addons-test-utils';

import A from './a';

describe.only('', () => {
  it('renders', () => {
    const renderer = ReactTestUtils.createRenderer();
    renderer.render();
  });
});

package.json
{
  "babel": {
    "presets": [
      "es2015",
      "react"
    ]
  },
  "description": "Testing an issue with the coverage output",
  "dependencies": {
    "babel-preset-es2015": "^6.22.0",
    "babel-preset-react": "^6.22.0",
    "babel-register": "^6.22.0",
    "mocha": "^3.2.0",
    "nyc": "^10.1.2",
    "react": "^15.4.2",
    "react-addons-test-utils": "^15.4.2",
    "react-dom": "^15.4.2"
  },
  "license": "UNLICENSED",
  "name": "coverage_test",
  "nyc": {
    "reporter": [
      "lcov",
      "text"
    ]
  },
  "repository": "gist:8a2bd8d15cf49b9d770f3fcde222c779",
  "scripts": {
    "test": "nyc mocha --compilers js:babel-register a_spec.js"
  }
}

Running npm test after installing the above files produces the following visualization for the coverage of a.js:

Note that the render function is definitely called and the visualization even shows line 8 as being executed 1 time. I'm not sure if this is a problem directly with nyc, or istanbul, or with an external library, but I figured I'd start here. Below are the contents of the text-lcov output when I run ./node_modules/.bin/nyc report --reporter=text-lcov
TN:
SF:/Users/bboe/Desktop/nyc/a.js
FNF:0
FNH:0
DA:1,1
DA:5,0
DA:8,1
LF:3
LH:2
BRF:0
BRH:0
end_of_record
TN:
SF:/Users/bboe/Desktop/nyc/a_spec.js
FN:6,(anonymous_1)
FN:7,(anonymous_2)
FNF:2
FNH:2
FNDA:1,(anonymous_1)
FNDA:1,(anonymous_2)
DA:1,1
DA:2,1
DA:4,1
DA:6,1
DA:7,1
DA:8,1
DA:9,1
LF:7
LH:7
BRF:0
BRH:0
end_of_record

Note: If I replace const b = 1; with some other statements like return; then the problem goes away.
Forensic Information
Operating System: Mac OS Sierra
Environment Information:
v6.2.1
3.10.4
https://gist.github.com/bboe/5ae951b6cf213ba3b1458f5573244edb

Looks to me like you're missing babel-plugin-istanbul. Could you try installing and configuring it as documented, and hopefully you'll be in better place? :)

@JaKXz that solved it. Thanks! It's incredible how close to accurate it was without that plugin.

@bboe I'd love for it to be 100% accurate without the plugin, but we've never quite nailed the source-map remapping -- not quite sure where in the stack the lines get shuffled.

authors: JaKXz bboe bcoe


text:
NYC doesn't work well with PM2

Please use the template provided below, when reporting bugs:
Here in Sealights, we develop a SAAS quality dashboard that shows among the rest Coverage Information for end-2-end tests.
As part of the development of our NodeJS agent, we are using NYC and we have noticed that it doesn't play well with PM2. We have issues with its Cluster Mode & Logs of the application under test.
Expected Behavior
PM2 supports "Cluster Mode" which allow several node JS processes to share the same port number.
When used with NYC, it is expected that the functionallity work as useusal, meaning, allow to start few instances of the same microservice on the same network port.
In addition, when using "pm2 logs" we expect to see the logs of the application under test.
Observed Behavior

Only a single instance of the microservice is loaded successfully. Other instances get 'port already in use' message.
Using "pm2 logs" shows no output of the application under test.

Forensic Information
Operating System: the operating system you observed the issue on.
CentOS Linux release 7.2.1511 (Core)
Environment Information: information about your project's environment, see instructions below:
v6.5.0
5.0.3
@sealights/sl-cloud-api-gateway@1.0.169 /opt/sealights/node_modules/@sealights/sl-cloud-api-gateway
├── UNMET DEPENDENCY @sealights/sl-cloud-infra@^1.0.311
├── UNMET DEPENDENCY @sealights/swagger-restify@^1.1.1
├── UNMET DEPENDENCY @types/mongodb@^2.1.37
├── UNMET DEPENDENCY @types/mongoose@^4.7.3
├── UNMET DEPENDENCY columnify@^1.5.4
├── UNMET DEPENDENCY jsonwebtoken@^7.1.7
├── UNMET DEPENDENCY jwk-to-pem@^1.2.6
├── UNMET DEPENDENCY md5@^2.2.1
├── UNMET DEPENDENCY on-finished@^2.3.0
├── UNMET DEPENDENCY on-headers@^1.0.1
├── UNMET DEPENDENCY request@^2.74.0
├── UNMET DEPENDENCY restify@^4.0.3
└── UNMET DEPENDENCY restify-jwt@^0.4.0

Please note that when istanbul was used (without nyc) everything worked correctly. I assume it is related to 'spawn-wrap'?

spawn-wrap would be my first suspect as well. I've never seen it used in clusters.
I would try implementing a no-op spawn-wrap wrapper,  and use it to wrap some trivial cluster implementation. If stuff breaks, we know this needs to be fixed up stream

@jamestalmage  - thanks for your answer. So basically, you suggest that I'll implement the no-op spawn, replace the module in the node_modules so nyc will pick it up and try to run the cluster?

@nadavye @jamestalmage If you isolate the problem to spawn-wrap, I'd be happy to introduce a --no-spawn-wrap flag to nyc that disables it for you; just let me know where you ended up debugging this issue.

Hi, any chance someone looked into this?

Hi Guys,
Any update on this?
Have you had a chance to look at @RoniSegal  reproduction?

Ping

Guys, is there a chance to get some info about how to add this flag? Which area should be modified?
It will allow us to try and resolve that by ourselves.

authors: RoniSegal bcoe jamestalmage nadavye


text:
istioctl produces unhelpful error message when using a incorrectly formatted file

@kyessenov commented on Tue Aug 29 2017
@kyessenov commented on Mon Jun 19 2017
@saturnism commented on Mon Jun 19 2017
E.g.,
istioctl create -f guestbook-service-retry.yaml
Error: the server rejected our request for an unknown reason

However, when you turn on verbose mode, you can see the server side error:
...
I0619 17:33:00.227081   92174 request.go:991] Response Body: cannot parse proto message: unknown field "uri" in istio_proxy_v1_config.MatchCondition

I believe this has been fixed elsewhere and this Issue can be closed.
I built a version of istioctl with both client side validation checks commented out.
istioctl create -f tests/e2e/tests/galley/testdata/networking-v1alpha3-DestinationRule-invalid.yaml
Error: admission webhook "pilot.validation.istio.io" denied the request: configuration is invalid: 2 errors occurred:

* empty domain name not allowed
*  is not a valid IP

authors: esnible kyessenov

repo: istio/istio


text:
Istio 1.2.0 attempts to create a certmanager CRD even when certManager set to disable

This is a regression on https://github.com/istio/istio/issues/12467
with certmanager.enabled=false, you still get a certmanager crd produced (certificates.certmanager.k8s.io).

I'm not seeing this one:
$ helm template install/kubernetes/helm/istio-init --name istio --namespace istio-system --set certmanager.enabled=false | grep certmanager
# Source: istio-init/templates/configmap-crd-certmanager-10.yaml
# Source: istio-init/templates/configmap-crd-certmanager-11.yaml
# Source: istio-init/templates/job-crd-certmanager-10.yaml
# Source: istio-init/templates/job-crd-certmanager-11.yaml

$ helm template install/kubernetes/helm/istio-init --name istio --namespace istio-system --set certmanager.enabled=true | grep certmanager
# Source: istio-init/templates/configmap-crd-certmanager-10.yaml
  name: istio-crd-certmanager-10
  crd-certmanager-10.yaml: |-
      name: clusterissuers.certmanager.k8s.io
... more crd stuff ...

Did I do something differently than you?

@Stono can you add a reproducer?
Can you specify the version of helm in use (helm version)?
Thanks

Sure thing, give me 5.

Ahhh this one was user error.  My apologies.

OK for the sake of debugging here, we set certmanager.enabled on the istio chart to disable all of the certmanager templates in there.
In 1.2.0 it looks like the CRD was added to istio-init, and as a result we also need to set certmanager.enabled on the istio-init install too.

authors: Stono howardjohn sdake


text:
Merge operator and installer charts

operator has a fork of the installer charts under data/charts. This was necessary to progress when not all values in the charts were supported. Also there were some issues with charts in installer (e.g. missing yaml separators).
The time is now right to merge these two, fix any outstanding issues in the installer repo and use the installer charts as the source of truth.
This task is to diff the two sets of charts, merge back any changes and figure out the right way to include istio/installer repo. Probably the way is to fix the charts at a version in go.mod and update this as we go along.

Also there were some issues with charts in installer (e.g. missing yaml separators).

DO you mean this issue: https://github.com/istio/istio/issues/15370

Yes, exactly. Those are both subtasks of this I'd say.
I think there may be some other minor issues. I remember fixing some stuff but I didn't have time then to push it back up to istio/installer.

authors: morvencao ostromart


text:
unable to apply multiple certificates in istio-ingressgateway while hosting multiple site using same single gateway

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities/
To ask questions about how to use Istio, please visit https://discuss.istio.io
)
Bug description
Affected product area (please put an X in all that apply)
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[x] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
as mentioned in offical documnetation https://archive.istio.io/v1.1/docs/tasks/traffic-management/secure-ingress/sds/
I followed same procedure to host mult-site using multiple certificate but failed to apply both.
for ex:-
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
name: gateway
spec:
selector:
istio: ingressgateway # use Istio default gateway implementation
servers:
port:
number: 80
name: http-abc
protocol: HTTP
tls:
httpsRedirect: true # sends 301 redirect for http requests
hosts:
"abc.com"
port:
number: 443
name: https-abc
protocol: HTTPS
tls:
mode: SIMPLE
credentialName: "abc-credential"
hosts:
"abc.com"
port:
number: 80
name: http-xyz
protocol: HTTP
tls:
httpsRedirect: true # sends 301 redirect for http requests
hosts:
"xyz.com"
port:
number: 443
name: https-xyz
protocol: HTTPS
tls:
mode: SIMPLE
credentialName: "xyz-credential"
hosts:
"xyz.com"
both the certificates are uploaded in istio-system namespace as TLS/secret but it can only works for first one i.e abc-credential and unable to works for xyz-credential.
Please let me know if anyone find solution for it.

https://istio.io/news/2019/announcing-1.1-eol/ 1.1 is deprecated. Please file bug separately if you observe this in 1.2
/cc @JimmyCYJ  just FYI.


text:
wiki should include information on how to update the charts

The wiki should have the same info found here: https://github.com/istio/istio/blob/master/manifests/UPDATING-CHARTS.md
@sdake recommended this issue be created and assigned to him.

There should be an additional blurb on how to test. Particularly, it seems it best that you build istioctl. As per @dgn make istioctl and then use the binary in out/.


text:
istioctl install got Invalid value: must be unique error

When I local run perf benchmark script, I got the following error message:
+ /Users/carolynprh/tools/perf/istio-install/tmp/istio-1.7-alpha.b95950afe673141d1438311f152a8dcfb866c4dd/bin/istioctl install --skip-confirmation -d /Users/carolynprh/tools/perf/istio-install/tmp/istio-1.7-alpha.b95950afe673141d1438311f152a8dcfb866c4dd/manifests -f istioctl_profiles/default-overlay.yaml
✔ Istio core installed
✔ Istiod installed
- Processing resources for Egress gateways, Ingress gateways.                   2020-08-18T05:52:56.675350Z	error	installer	failed to create "Deployment/istio-system/istio-ingressgateway": Deployment.apps "istio-ingressgateway" is invalid: spec.template.spec.containers[0].volumeMounts[7].mountPath: Invalid value: "/etc/istio/ingressgateway-certs": must be unique
✔ Egress gateways installed
✘ Ingress gateways encountered an error: failed to create "Deployment/istio-system/istio-ingressgateway": Deployment.apps "istio-ingressgateway" is invalid: spec.template.spec.containers[0].volumeMounts[7].mountPath: Invalid value: "/etc/istio/ingressgateway-certs": must be unique
- Pruning removed resources                                                     Error: failed to install manifests: errors occurred during operation

this line is somehow duplicated: https://github.com/istio/tools/blob/master/perf/istio-install/istioctl_profiles/default-overlay.yaml#L75

cc @ostromart @sdake @esnible

perf side fix: https://github.com/istio/tools/pull/1177

@ostromart I suspect the user was expecting volumeMounts to merge differently, or uniquely.  Should the overlay functions merge by default, never merge, or have ad-hoc bespoke merge logic?
I accept we can never write IstioOperator analysis that always detects if Kubernetes will reject it, but should we attempt to write spot checks for common problems?  I am thinking of something declarative, like notUnique() -> “Volume mount directories must be unique, you have {{}}“.

authors: carolynhu esnible


text:
'istioctl bug-report', when it doesn't work, is a mystery

When I run istioctl bug-report (using my own build from master), no output happens for 83 seconds.
When it starts, consider outputting a message like "generating bug report" so the user knows it isn't waiting for input.
Unless there is some reason (such as doing many things in parallel) it should output the major phase it is in to show progress.  (Later we can have progress bars.)
After 83 seconds, I see
2020-09-09T19:35:00.648643Z	error	previous terminated container "istio-proxy" in pod "cli1" not found, kubectl error: exit status 1
stderr:
error: error converting JSON to YAML: yaml: control characters are not allowed (repeated 1 times)
stdout:

This is not helpful.

It should have kept going
It should have prefixed the message with what it was trying to do when it failed.

I tried it today and it immediately started showing me the first few messages with output and finished in a couple of seconds.
$ istioctl bug-report

Target cluster context: kind-istio-testing

Running with the following config:

istio-namespace: istio-system
full-secrets: false
timeout (mins): 30
include: {  }
exclude: { Namespaces:kube-system,kube-public }
end-time: 2020-10-14 20:19:50.52619405 +0530 IST

The following Istio control plane revisions/versions were found in the cluster:
Revision default:
&version.MeshInfo{
    {
        Component: "pilot",
        Info:      version.BuildInfo{Version:"1.8-alpha.637d3a46f697557bd508904cecf71cb5e8129791", GitRevision:"637d3a46f697557bd508904cecf71cb5e8129791", GolangVersion:"", BuildStatus:"Clean", GitTag:"1.8-alpha.637d3a46f697557bd508904cecf71cb5e8129791"},
    },
}

The following proxy revisions/versions were found in the cluster:
Revision default: Versions {1.8-alpha.637d3a46f697557bd508904cecf71cb5e8129791}

Fetching proxy logs for the following containers:

istio-system/istio-ingressgateway/istio-ingressgateway-5cf694469b-2677k/istio-proxy
istio-system/istiod/istiod-7c65b8f5cf-rssbd/discovery
local-path-storage/local-path-provisioner/local-path-provisioner-78776bfc44-pf6bv/local-path-provisioner

Fetching Istio control plane information from cluster.

Running istio analyze on namespace istio-system.
Running istio analyze on namespace local-path-storage.

Creating archive at /home/shaansar/Projects/src/istio.io/istio/bug-report.tgz.
Cleaning up temporary files in /tmp/bug-report.
Done.


text:
ipv6: zipkin blocks initialization, leading to 15s pod startup

2021-09-30T17:13:42.414531Z     debug   envoy upstream  cm init: adding: cluster=zipkin primary=1 secondary=0
2021-09-30T17:13:54.432344Z     debug   envoy upstream  DNS refresh rate reset for zipkin.istio-system, (failure) refresh rate 30000 ms
2021-09-30T17:13:54.432374Z     debug   envoy upstream  initializing Primary cluster zipkin completed
2021-09-30T17:13:54.432379Z     debug   envoy init      init manager Cluster zipkin contains no targets
2021-09-30T17:13:54.432382Z     debug   envoy init      init manager Cluster zipkin initialized, notifying ClusterImplBase
2021-09-30T17:13:54.432398Z     debug   envoy upstream  adding TLS cluster zipkin
2021-09-30T17:13:54.432433Z     debug   envoy upstream  cm init: init complete: cluster=zipkin primary=0 secondary=0

I do not have zipkin.istio-system in my cluster. Its not clear why it blocks in ipv6 but not ipv4.
On ipv4:
2021-09-30T17:16:55.730687Z     debug   envoy upstream  cm init: adding: cluster=zipkin primary=1 secondary=0
2021-09-30T17:16:55.758091Z     debug   envoy upstream  DNS refresh rate reset for zipkin.istio-system, (failure) refresh rate 30000 ms

021-09-30T17:25:45.037345372Z [INFO] [fd00:10:244::1b]:48582 - 43153 "A IN zipkin.istio-system.corp.google.com. tcp 53 false 65535" NOERROR - 0 28.456477717s
2021-09-30T17:25:45.037386782Z [ERROR] plugin/errors: 2 zipkin.istio-system.corp.google.com. A: dial tcp [2001:4860:4860::8888]:53: i/o timeout

Might not be universal - seems like my underlying host dns config is not being ipv6 friendly

caused by https://github.com/moby/moby/issues/20559, cannot even curl google.com on ipv6

sudo ip6tables -t nat -A POSTROUTING -s $(docker network inspect kind | jq .[0].IPAM.Config[1].Subnet -r) ! -o docker0 -j MASQUERADE fixes it. Would consider it fixed but should check if CI is impacted.

afaik port forwarding does not go through iptables at all. Maybe I am misunderstanding?

For issue: https://github.com/istio/istio/issues/34358,  I agree that there are some business with k8s runtime thing, but I have upgraded my containerd version, and also edited /etc/hosts, and still not okay, I also compared the port-forward source code between kubectl and Istio, but can not find out much more detail, I'm confusing why.

fixed by https://github.com/istio/istio/commit/07000b416069041a550334929d504cd2a87c6e27

authors: howardjohn zhlsunshine


text:
Pilot root CA file change does not update sidecar mutatingwebhook caBundle

Bug Description
When using istio-csr as the identity solution for istio, we disable citadel and load the TLS cert for pilot as well as the root of trust CA from a configmap .
The current logic for Webhookpatcher and the backing Watcher seems to be notified of filesystem changes through an istiodCertWatcher keycertbundle.watcher.
This watcher seems to not have implemented looking at CA file but only at key and cert, forcing a restart of pilot for the caBundle to be correct and causing a lot of confusion with "unknown certificate authority" error.
This can manifest to users, if upgrading to use istio-csr from self-signed or external "plug-in" CA or if doing a break-glass root rotation (which requires a brief period of having both roots eg: https://blog.christianposta.com/diving-into-istio-1-6-certificate-rotation/).
There is a TODO note which demonstrates that support for the ca syncing was always lacking in the webhook patcher  (since that block initialises the watcher the patcher subscribes to):
https://github.com/istio/istio/blob/2a5e10406d790acba2e054bf3f0d83dfd7f0e97f/pilot/pkg/bootstrap/certcontroller.go#L228
Bear in mind our requirement are a little unusual,  we can easily just add logic under that block to watch the CAFile on disk, but one has to remember that in our scenario we have citadel off with ENABLE_CA_SERVER=false.
So we need to ensure that all other CA methods are not inadvertently affected by this change as well.
I will submit a tentative PR to address above issue.
The wider issue that would be great to solve on top of this one is automatic re-issuance of certificate for sidecars themselves when CA changes either when detected through this path or through a change in the plugin-in ("cacerts" method) thus making the CA mechanisms truly extensible and great to operate but that can be the subject of another PR :)
Version
tested on latest istio 1.12.4
and kind environment 1.21

Additional Information
No response

The wider issue that would be great to solve on top of this one is automatic re-issuance of certificate for sidecars themselves when CA changes either when detected through this path or through a change in the plugin-in ("cacerts" method) thus making the CA mechanisms truly extensible and great to operate but that can be the subject of another PR :)

Curious, in your case, isn't re-issuance of workload cert controlled by cert manager instead of istio?

authors: SpectralHiss bianpengyuan


text:
k8s service exportTo annotation not working on gateways

Bug Description
in previous versions of istio you could add exportTo annotation to a Kubernetes service and it would be removed from service discovery on gateways.  Not it appears the annotation does not work in gateways in 1.16
Example
apiVersion: v1
kind: Service
metadata:
  name: frontend
  labels:
    app: frontend
    service: frontend
  annotations:
    networking.istio.io/exportTo: "."
spec:
  ports:
  - port: 8080
    name: http
  - port: 9080
    name: http2-grpc
  selector:
    app: frontend
    version: v1

▶ istioctl pc cluster deploy/istio-ingressgateway.istio-system
SERVICE FQDN                                            PORT      SUBSET     DIRECTION     TYPE           DESTINATION RULE
BlackHoleCluster                                        -         -          -             STATIC
agent                                                   -         -          -             STATIC
frontend.app.svc.cluster.local                          8080      -          outbound      EDS
frontend.app.svc.cluster.local                          9080      -          outbound      EDS
istio-egressgateway.istio-system.svc.cluster.local      80        -          outbound      EDS
istio-egressgateway.istio-system.svc.cluster.local      443       -          outbound      EDS
istio-ingressgateway.istio-system.svc.cluster.local     80        -          outbound      EDS
istio-ingressgateway.istio-system.svc.cluster.local     443       -          outbound      EDS
istio-ingressgateway.istio-system.svc.cluster.local     15021     -          outbound      EDS
istio-ingressgateway.istio-system.svc.cluster.local     15443     -          outbound      EDS
istio-ingressgateway.istio-system.svc.cluster.local     31400     -          outbound      EDS
istiod.istio-system.svc.cluster.local                   443       -          outbound      EDS
istiod.istio-system.svc.cluster.local                   15010     -          outbound      EDS
istiod.istio-system.svc.cluster.local                   15012     -          outbound      EDS
istiod.istio-system.svc.cluster.local                   15014     -          outbound      EDS
kube-dns.kube-system.svc.cluster.local                  53        -          outbound      EDS
kube-dns.kube-system.svc.cluster.local                  9153      -          outbound      EDS
kubernetes.default.svc.cluster.local                    443       -          outbound      EDS
metrics-server.kube-system.svc.cluster.local            443       -          outbound      EDS
prometheus_stats                                        -         -          -             STATIC
sds-grpc                                                -         -          -             STATIC
xds-grpc                                                -         -          -             STATIC
zipkin                                                  -         -          -             STRICT_DNS

Steps to reproduce
istioctl install -y --set profile=demo

kubectl create ns app

kubectl label ns app istio-injection=enabled

kubectl apply -f app.yaml -n app

istioctl pc cluster deploy/istio-ingressgateway.istio-system | grep frontend

kubectl apply -n app -f - <<EOF
apiVersion: v1
kind: Service
metadata:
  name: frontend
  labels:
    app: frontend
    service: frontend
  annotations:
    networking.istio.io/exportTo: "."
spec:
  ports:
  - port: 8080
    name: http
  - port: 9080
    name: http2-grpc
  selector:
    app: frontend
    version: v1
EOF

istioctl pc cluster deploy/istio-ingressgateway.istio-system

app.yaml
apiVersion: v1
kind: Service
metadata:
  name: frontend
  labels:
    app: frontend
    service: frontend
spec:
  ports:
  - port: 8080
    name: http
  - port: 9080
    name: http2-grpc
  selector:
    app: frontend
    version: v1
---
apiVersion: v1
kind: ServiceAccount
metadata:
  name: frontend
  labels:
    account: frontend
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: frontend-v1
  labels:
    app: frontend
    version: v1
spec:
  replicas: 1
  selector:
    matchLabels:
      app: frontend
      version: v1
  template:
    metadata:
      labels:
        app: frontend
        version: v1
    spec:
      serviceAccountName: frontend
      containers:
      - name: frontend
        image: ghcr.io/nmnellis/istio-echo:latest
        imagePullPolicy: IfNotPresent
        ports:
        - containerPort: 8080
        args:
          - --name
          - frontend-v1
          - --port
          - "8080"
          - grpc
          - "9080"
          - --version
          - v1
          - --cluster
          - cluster-1

Version
▶ istioctl version
client version: 1.16.0
control plane version: 1.16.0
data plane version: 1.16.0 (3 proxies)

Additional Information
bug-report.tar.gz

Does it still work for sidecar?

I can not reproduce on master latest commit

Also not reproduce on 1.16.0

I did reproduce this

authors: dddddai hzxuzhonghu nmnellis


text:
Per-pod native sidecar enablement

(This is used to request new product features, please visit https://github.com/istio/istio/discussions for questions on using Istio)
Describe the feature request
We’d like the ability to control which pods use native sidecars, as we run a multi-cluster setup, and not all clusters are running new-enough kubernetes (1.28). Ideally this would be an annotation on the pod spec.
Describe alternatives you've considered
Waiting until all of our workload clusters are running k8s 1.28
Affected product area (please put an X in all that apply)
[ ] Ambient
[ ] Docs
[ ] Dual Stack
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

https://github.com/istio/istio/issues/48794 could also solve your probably in a different manner. But per-pod is probably also useful

I think there are (at least) two somewhat natural options for said per-pod enablement (for arguments sake, let's call it injectNativeSidecar):

Add it to proxyConfig, similar to HoldApplicationUntilProxyStarts
Create a new annotation, similar to sidecar.istio.io/rewriteAppHTTPProbers

Do you have a strong preference between them? I have a slight preference towards the annotation, as proxyConfig is already somewhat of a pain to merge in our tooling, but if required would be fine.

My current assumption is native sidecars are going to something that we want ~universally, and we just have some transition pain due to versions. Based on that, a more temporary solution (annotation) seems appropriate. I would call it sidecar.istio.io/native-sidecar: true/false perhaps (the 'sidecar' bit is repeated which is a bit awkward, but 'native' on its own is odd as well).

note to self, use nativeSidecar instead of native-sidecar

Even if native sidecars are going to be most likely something enabled on the whole cluster long-term, it's important to allow people to enable a few pods initially so they can test the stability. Keep in mind that this is still a beta feature of K8s and it is risky to set the whole cluster without previous testing.

Even if native sidecars are going to be most likely something enabled on the whole cluster long-term, it's important to allow people to enable a few pods initially so they can test the stability. Keep in mind that this is still a beta feature of K8s and it is risky to set the whole cluster without previous testing.

This was implemented in https://github.com/istio/istio/pull/53490 so you should be able to do this.
FWIW, its not easy but you can always test out global settings like this with Istio canary installs as well.

authors: AndresPinerosZen dwj300 howardjohn


text:
[release-1.6] Add sideEffects field to webhook

This is an automated cherry-pick of #24109

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.6
6bc7f6f1e7a496ab8187338f36d2816368eb39c6
link
/test unit-tests_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

authors: istio-testing jacob-delgado


text:
add support of revision for operator commands

remaining work for: https://github.com/istio/istio/issues/23479

@richardwxn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
76ec5750df752b0f1e5516926471afac31b9cb24
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
76ec5750df752b0f1e5516926471afac31b9cb24
link
/test release-notes_istio

lint_istio
76ec5750df752b0f1e5516926471afac31b9cb24
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
76ec5750df752b0f1e5516926471afac31b9cb24
link
/test lint_istio

release-notes_istio
524d70f7cf7f438c3e90e79d99b96fc0db350861
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
76ec5750df752b0f1e5516926471afac31b9cb24
link
/test lint_istio

release-notes_istio
524d70f7cf7f438c3e90e79d99b96fc0db350861
link
/test release-notes_istio

gencheck_istio
524d70f7cf7f438c3e90e79d99b96fc0db350861
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
524d70f7cf7f438c3e90e79d99b96fc0db350861
link
/test release-notes_istio

gencheck_istio
524d70f7cf7f438c3e90e79d99b96fc0db350861
link
/test gencheck_istio

lint_istio
524d70f7cf7f438c3e90e79d99b96fc0db350861
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
524d70f7cf7f438c3e90e79d99b96fc0db350861
link
/test gencheck_istio

lint_istio
524d70f7cf7f438c3e90e79d99b96fc0db350861
link
/test lint_istio

release-notes_istio
1ab87a62d3b29f666c19fee44122ccef2be58f5d
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
524d70f7cf7f438c3e90e79d99b96fc0db350861
link
/test gencheck_istio

release-notes_istio
1ab87a62d3b29f666c19fee44122ccef2be58f5d
link
/test release-notes_istio

lint_istio
1ab87a62d3b29f666c19fee44122ccef2be58f5d
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
1ab87a62d3b29f666c19fee44122ccef2be58f5d
link
/test release-notes_istio

lint_istio
1ab87a62d3b29f666c19fee44122ccef2be58f5d
link
/test lint_istio

integ-operator-controller-tests_istio
1ab87a62d3b29f666c19fee44122ccef2be58f5d
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
1ab87a62d3b29f666c19fee44122ccef2be58f5d
link
/test lint_istio

integ-operator-controller-tests_istio
1ab87a62d3b29f666c19fee44122ccef2be58f5d
link
/test integ-operator-controller-tests_istio

release-notes_istio
6a31874f9a2b293dc389db13558d03d6b91264fc
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
1ab87a62d3b29f666c19fee44122ccef2be58f5d
link
/test lint_istio

integ-operator-controller-tests_istio
1ab87a62d3b29f666c19fee44122ccef2be58f5d
link
/test integ-operator-controller-tests_istio

release-notes_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
1ab87a62d3b29f666c19fee44122ccef2be58f5d
link
/test lint_istio

integ-operator-controller-tests_istio
1ab87a62d3b29f666c19fee44122ccef2be58f5d
link
/test integ-operator-controller-tests_istio

release-notes_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test release-notes_istio

gencheck_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
1ab87a62d3b29f666c19fee44122ccef2be58f5d
link
/test integ-operator-controller-tests_istio

release-notes_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test release-notes_istio

gencheck_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test gencheck_istio

lint_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
1ab87a62d3b29f666c19fee44122ccef2be58f5d
link
/test integ-operator-controller-tests_istio

release-notes_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test release-notes_istio

gencheck_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test gencheck_istio

lint_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test lint_istio

unit-tests_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test gencheck_istio

lint_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test lint_istio

unit-tests_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test unit-tests_istio

release-notes_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test unit-tests_istio

release-notes_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test release-notes_istio

lint_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@richardwxn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
de7170fcfc3082156dd7146b559dc13b2bc18085
link
/test lint_istio

release-notes_istio
37c4396f64b743f58efd2698c7f8d395fc4456d5
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In response to a cherrypick label: new pull request created: #25729

@howardjohn ok created a PR to add them. Thanks for reminding.

authors: istio-testing richardwxn