text:
Add CoScale as monitoring solution for ACS with Kubernetes.

@fryckbos,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@rgardler @dlepow Hi Ross or Dan. This pull request has new content for Container Service. Can you or someone on your team work to move the content to the private repo and then close this pull request? Thanks.

@fryckbos - Thanks for the contribution! We'll be happy to migrate this over to our private repo and start the publishing process there. Before we do, a couple suggestions: 1. Please provide more background on CoScale features/benefits (and link to features), perhaps compared with other monitoring solutions. 2. Provide image of what customer sees when they successfully deploy and use product. See these article for examples::
https://docs.microsoft.com/en-us/azure/container-service/container-service-monitoring-dynatrace
https://docs.microsoft.com/en-us/azure/container-service/container-service-kubernetes-sysdig
@squillace @sauryadas - FYI

Thanks for the quick response. I have added a bit more information about CoScale and I also added some screenshots. Let me know if there are other things you would like me to add / change.

@fryckbos - Thanks for adding the information and screenshots. I'll close this PR and migrate the content  over to our private repo. I'll plan to reach out to you in a few days to have a look again before we publish.
#please-close

@dlepow Excellent, looking forward to it !

authors: dlepow fryckbos jomolnar msftclas


text:
Add setup for portability offline

LGTM.

The project won't open now if someone doesn't have wix installed. Can this be in a separate solution?

@JJVertical Did you still want to get this in?

@dotnet-bot test this please (ci test)

@dotnet-bot test this please (ci test)

FYI it looks like you'll need to resolve the conflicts first (since your pre-conflict commit has no build.ps1)

@dotnet-bot test this please (random check, ignore)

I'm going to close this for now. Please reopen if you want to fix the merge issues.

source: gharchive/pull-request

authors: JJVertical conniey mmitche twsouthwick

repo: Microsoft/dotnet-apiport

license: mit

license_type: permissive

license_source: bigquery


text:
Updates package 'AngleSharp' to version '0.11.0'

@brendankowitz it would probably make sense for you to look at this one.

authors: MicrosoftHealthService johnstairs

repo: Microsoft/fhir-server

license: MIT

license_source: github-api


text:
conditional ignore platform pinning for legacy PS handler.

looks good

authors: TingluoHuang ericsciple

repo: Microsoft/vsts-agent


text:
test issue

bob@contoso.com

source: gharchive/issue


text:
Add preview flag to kafka ESP doc

@dhgoelmsft : Thanks for your contribution! The author, @mamccrea, has been notified to review your proposed change.

#sign-off

authors: PRMerger19 dhgoelmsft mamccrea

repo: MicrosoftDocs/azure-docs


text:
Update copy-activity-log.md

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.It's easy to access the private repo version of your articles in GitHub. Just add -pr to the URL, as follows:
Public repo URL: https://github.com/MicrosoftDocs/azure-docs
Private repo URL: https://github.com/MicrosoftDocs/azure-docs-pr
We have closed this pull request. Please resubmit the updates through the private repo. For more information, [see the contributor guide].(https://docs.microsoft.com/en-us/contribute/)


text:
Update TOC.md

OPS Build status updates of commit 351cc88:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

repo: MicrosoftDocs/mixed-reality


text:
Feature/home page text

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: xaviermignot sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

authors: msftclas xaviermignot


text:
Feature/home page text

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: kumarravi85 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


text:
Updating DumpMachine to reflect new output.

Docs Build status updates of commit bfe80f6:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/libraries/standard/diagnostics.md
:warning:Warning

Details

articles/techniques/testing-and-debugging.md
:warning:Warning

Details

articles/libraries/standard/diagnostics.md

[Warning] 2 invalid cross reference(s) "<xref:Microsoft.Quantum.Simulation.QuantumSimulator>", "<xref:Microsoft.Quantum.Simulation.ToffoliSimulator>".

articles/techniques/testing-and-debugging.md

Line 155: [Warning] Invalid file link:(~/media/unit-test-output.png).
Line 300: [Warning] Invalid file link:(~/media/qubit_id.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 77e9623:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/libraries/standard/diagnostics.md
:warning:Warning

Details

articles/techniques/testing-and-debugging.md
:warning:Warning

Details

articles/libraries/standard/diagnostics.md

[Warning] 2 invalid cross reference(s) "<xref:Microsoft.Quantum.Simulation.QuantumSimulator>", "<xref:Microsoft.Quantum.Simulation.ToffoliSimulator>".

articles/techniques/testing-and-debugging.md

Line 155: [Warning] Invalid file link:(~/media/unit-test-output.png).
Line 300: [Warning] Invalid file link:(~/media/qubit_id.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 6116277:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/techniques/testing-and-debugging.md
:warning:Warning

Details

articles/libraries/standard/diagnostics.md
:white_check_mark:Succeeded

articles/libraries/standard/toc.yml
:white_check_mark:Succeeded

articles/techniques/testing-and-debugging.md

Line 155: [Warning] Invalid file link:(~/media/unit-test-output.png).
Line 300: [Warning] Invalid file link:(~/media/qubit_id.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 251fe4a:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/techniques/testing-and-debugging.md
:warning:Warning

Details

articles/libraries/standard/diagnostics.md
:white_check_mark:Succeeded

articles/libraries/standard/toc.yml
:white_check_mark:Succeeded

articles/techniques/testing-and-debugging.md

Line 155: [Warning] Invalid file link:(~/media/unit-test-output.png).
Line 300: [Warning] Invalid file link:(~/media/qubit_id.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 7c8a178:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/techniques/testing-and-debugging.md
:warning:Warning

Details

articles/libraries/standard/diagnostics.md
:white_check_mark:Succeeded

articles/libraries/standard/toc.yml
:white_check_mark:Succeeded

articles/techniques/testing-and-debugging.md

Line 155: [Warning] Invalid file link:(~/media/unit-test-output.png).
Line 300: [Warning] Invalid file link:(~/media/qubit_id.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 19dde52:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/techniques/testing-and-debugging.md
:warning:Warning

Details

articles/libraries/standard/diagnostics.md
:white_check_mark:Succeeded

articles/libraries/standard/toc.yml
:white_check_mark:Succeeded

articles/techniques/testing-and-debugging.md

Line 155: [Warning] Invalid file link:(~/media/unit-test-output.png).
Line 300: [Warning] Invalid file link:(~/media/qubit_id.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 81953ff:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/techniques/testing-and-debugging.md
:warning:Warning

Details

articles/libraries/standard/diagnostics.md
:white_check_mark:Succeeded

articles/libraries/standard/toc.yml
:white_check_mark:Succeeded

articles/techniques/testing-and-debugging.md

Line 155: [Warning] Invalid file link:(~/media/unit-test-output.png).
Line 300: [Warning] Invalid file link:(~/media/qubit_id.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit a79bc6f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/techniques/testing-and-debugging.md
:warning:Warning

Details

articles/libraries/standard/diagnostics.md
:white_check_mark:Succeeded

articles/libraries/standard/toc.yml
:white_check_mark:Succeeded

articles/techniques/testing-and-debugging.md

Line 155: [Warning] Invalid file link:(~/media/unit-test-output.png).
Line 300: [Warning] Invalid file link:(~/media/qubit_id.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 57aa340:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/techniques/testing-and-debugging.md
:warning:Warning

Details

articles/libraries/standard/diagnostics.md
:white_check_mark:Succeeded

articles/libraries/standard/toc.yml
:white_check_mark:Succeeded

articles/techniques/testing-and-debugging.md

Line 155: [Warning] Invalid file link:(~/media/unit-test-output.png).
Line 300: [Warning] Invalid file link:(~/media/qubit_id.png).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

repo: MicrosoftDocs/quantum-docs-pr


text:
Update nf-wuapi-iupdatedownloadcontent-get_downloadurl.md

Thanks for the additional info and for submitting feedback via Feedback Hub. Since there have been no changes to the implementation of this method and the product team cannot reproduce the issue you're seeing, I'm closing this pull request.
In case it helps, you may also find these resources helpful:

Microsoft Q&A offers relevant and timely answers to your technical problems from a community of experts and Microsoft engineers.
For community assistance with development questions, there are our forums, and StackOverflow.
The Windows developer support site explains other support options.
For developer issues, or suspected product bugs, there's Microsoft Support; a support engineer will look at the repro and see whether the issue is a Microsoft product bug, or something else. If it's a bug with a Microsoft product then the ticket will be free of charge.

authors: mcleanbyron sfonteneau

repo: MicrosoftDocs/sdk-api


text:
Update PrototypeBoards.md

Docs Build status updates of commit 7cc42ff:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/tutorials/quickstarter/PrototypeBoards.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 3e51b23:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/Downloads.md
:white_check_mark:Succeeded

windows-iotcore/tutorials/quickstarter/PrototypeBoards.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

repo: MicrosoftDocs/windows-iotcore-docs


text:
Create robflyrc

Hi @robflyrc it looks like you did everything right except you need to include ".yml" extension on your filename to trigger the workflow that processes your request. If you repeat the steps and include the .yml extension on your filename, your request should be processed by the workflow within ~1-3 minutes. Thanks!

authors: afewell robflyrc


text:
mp2 correlation post HF

Done (see Pull Request #68 )

authors: gevahn shannonhouck


text:
DIIS fixed

Nice!

authors: adabbott jeherr


text:
Javadoc for SolUiScreen

Hooray Jenkins reported success with all tests good!

Hooray Jenkins reported success with all tests good!

Actually, after some brief testing, I discovered a crash when firing up the ships engine that is not present in develop
com.badlogic.gdx.utils.GdxRuntimeException: java.lang.AssertionError: Attempted to loop a sound without a parent object: core:medEngineWork2
	at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:127)
Caused by: java.lang.AssertionError: Attempted to loop a sound without a parent object: core:medEngineWork2
	at org.destinationsol.game.sound.OggSoundManager.play(OggSoundManager.java:164)
	at org.destinationsol.game.sound.OggSoundManager.play(OggSoundManager.java:137)
	at org.destinationsol.game.particle.DSParticleEmitter.setWorking(DSParticleEmitter.java:237)
	at org.destinationsol.game.particle.PartMan.updateAllHullEmittersOfType(PartMan.java:104)
	at org.destinationsol.game.ship.ShipEngine.update(ShipEngine.java:43)
	at org.destinationsol.game.ship.hulls.Hull.update(Hull.java:113)
	at org.destinationsol.game.ship.SolShip.update(SolShip.java:228)
	at org.destinationsol.game.ObjectManager.update(ObjectManager.java:94)
	at org.destinationsol.game.SolGame.update(SolGame.java:277)
	at org.destinationsol.SolApplication.update(SolApplication.java:158)
	at org.destinationsol.SolApplication.safeUpdate(SolApplication.java:133)
	at org.destinationsol.SolApplication.render(SolApplication.java:112)
	at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:215)
	at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:120)

How the heck have I managed to break sounds by adding javadoc to rendering related class?

@Adrijaned

How the heck have I managed to break sounds by adding javadoc to rendering related class?

In fairness your "javadoc" PRs tend to do a fair bit more than just javadoc ... :D
This one has some fun method removals in addition to the rename, but I cannot replicate the issue @NicholasBatesNZ mentioned so maybe it was a workspace issue from a little ways back. Tried to provoke several of the ships configured with that asset and all appeared well.
Merging! :shipit:

authors: Adrijaned Cervator GooeyHub NicholasBatesNZ

repo: MovingBlocks/DestinationSol


text:
Allow outer circle styling

Thanks for the PR
I'm curious, what did you use the outer styling for?

Hi Christoph
I needed to add shadow/elevation to the outer circle:
outerCircleStyle={{                         shadowRadius: 3,                         shadowOffset: { width: 0, height: 0 },                         shadowOpacity: 0.4,                         shadowColor: 'black',                         elevation: 3,                         top: 5                     }}

Thanks, I guess that 'll be useful for more people, I'll merge

authors: MrToph marcoj

repo: MrToph/react-native-progress-circle


text:
Support jquery element as selector  in addBinding method

What's the use case for this? Why would you ever need to pass your own elements?

An object could be created dynamically and binded later. I often create objects with backbone view at runtime.
var element1 =
Backbone.view.extend({
tagName : 'input',
....
render : function(){
return this;
}
)}

return Backbone.View.extend({
render : function(){
this.element1 = new element1;
this.$el.append(this.element1.render().el);
this.addBinding(null, this.element1, 'author');
return this;
}

You got the idea..

I'm not sure I see this as useful. Why aren't you using the normal bindings api?
Also, when would element1 ever need to be selected independently from its parent view? Why is a selector string not good enough here?

You should really be building views like this:
var InputView = Backbone.View.extend({
  tagName: 'input'
  ...
});

var FormView = Backbone.View.extend({
  tagName: 'form',
  bindings: {
    'input': 'author'
  },
  render: function() {
    this.$el.append((new InputView()).render().$el);
    this.stickit();
    return this;
  }
});

Input element could have more complex code which make it easier to be itself a View. For example, if it contain auto-complete feature with his own collection and model.

When a form is complex, I prefer sometime have multiple views rather that a big one.

When a form is complex, I prefer sometime have multiple views rather that a big one.

Yes, absolutely. There's nothing stopping you from passing models around in your view (new InputView({model: this.model}) or new InputView({model: this.authorModel})). In fact, that's recommended. But you really shouldn't be passing around arbitrary elements like this.
Views should almost exclusively care only about their child elements, not sibling elements. If you allow passing arbitrary elements around you break this concept. If you only care about child elements (as selector strings do currently) than this isn't a concern.

Ok I understand what you mean. I though it could be convenient to add this but maybe I'm wrong.
My personnal project is  a dynamic forms generator who create fields from parameters passed to the view. They are dynamically generated and linked to the model. Maybe I should append them before calling stickbit. I actually generate them, bind them.. and finally, when rendering, append them.
Excuse my english, not my native language as you probably imagine.

No worries! Hopefully I understood your point.
I'm not sure Stickit is the best technology for making an arbitrary form creator, but if your form creator must be dynamic, you could do some variation of your code above, just with a string selector instead of passing the element.
I'll have a think about a way to possibly add this feature in the future, that hopefully won't break addBinding's contract too much.

I'm currently in need of this feature - or something that gives me a little more control over the element(s) being selected. Here is my scenario:
I have a recursive view. Using stickit to bind to '[name=foo]' binds multiple times to my foo input for children. Children at the second level end up with 2 bindings, children at the 3rd level end up with 3 bindings, etc.
I tried setting '> div > [name=foo]' as my selector. I don't like that solution as it makes my code rather brittle. a slight change to the HTML will break things. However, that workaround didn't work anyway. I'm in need of something a little more powerful for selecting an element.

authors: akre54 guroot rwhitmire


text:
add heroku deploy button

Hey there,
Thanks for submitting a pull request. I'm sure others will find this helpful.
I'll have a look a bit later to ensure that everything would work as expected.
Thanks,
Nathan

I've tweaked some things before merging @rzlamrr
Please refer to git history.


text:
Allow to disable sentry wrapper from Env Variable + parse boolean values

lgtm thanks!

authors: kevgliss mprzytulski

repo: Netflix-Skunkworks/raven-python-lambda


text:
add latest netflix article about zuul2

Thanks, merged.

authors: IgorPerikov artgon

repo: Netflix/zuul


text:
Fixed #188 by replacing deprecated pandas function

Hello @mdenker! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file elephant/neo_tools.py:

Line 50:80: E501 line too long (86 > 79 characters)

Coverage decreased (-17.3%) to 69.722% when pulling 1b54b35948c7276398589847ae8f9d138c8a1f3a on INM-6:fix/188 into c6ffc3b2a589b6b44f6c193b64052e201d9b034a on NeuralEnsemble:master.

This PR was merged and extended into cumulativ fix #203 to test CI pass.

authors: coveralls mdenker pep8speaks

repo: NeuralEnsemble/elephant


text:
Memory efficient and faster implementation of ASSET pmat analytical

Coverage increased (+0.002%) to 89.639% when pulling ffed3d7df2591ea5db1c9ab71c57749c85321efe on INM-6:opt/asset-pmat into f20f071d487b6cb841ee1ad172e346c5bb8f13ab on NeuralEnsemble:master.

authors: coveralls dizcza


text:
deleted a comma

Too out-dated.

repo: NeuroDataDesign/mgcpy


text:
Introduce refactored ZK-compliant interface

Done with #38


text:
README.md: update description of the project

While you are at it: I've just found a typo: Purism Librem 15v3, should be a 13, not 15. That's why you see brackets instead of the right link.

repo: NixOS/nixos-hardware


text:
Fix navbar bugs

It doesn't work with other languages

Should be fixed...

repo: NyaaPantsu/nyaa


text:
cache node packages on appveyor and travis

ping @Nyalab

thanks for your PR, what purpose does it serve? isn't the cache regenerated for each branch?

@Nyalab there's no need to re-download these packages everytime, NPM is slow enough as it is. I was hoping this would speed up the build and prevent some unnecessary downloads.

@Nyalab what do you think?

ping @Nyalab

authors: Nyalab thijstriemstra

repo: Nyalab/caniuse-api


text:
merge master into live-based

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


text:
OP-598 ~ Removes dependency on kahadb used by FitNesse.

All is well.

repo: OSGP/Shared


text:
Add Security Policy on how we handle reports

@wetneb Yes, GitHub does have that security option for secret reporting.  I'll change that and point it to the openrefine-coredev mailing list.  I also had the same question and concerned but thought I'd start with this simple template as they suggest and then get the coredev team's feedback.  Let me update this...

repo: OpenRefine/OpenRefine


text:
fix: prevent infinite loop in linting script

Lol, thanks.

authors: PaulRBerg TomAFrench

repo: PaulRBerg/solidity-template


text:
feat(staff api): add systems query method

Closing as this PR also includes this change https://github.com/PlaceOS/drivers/pull/118/files#diff-1a28c1c70020d17eb6d6afab478e3845666e08aec46581f81419f46e7f18a9afR62-R80

repo: PlaceOS/drivers


text:
Add/to or create an images table while calling make_magic_plots

@njarboe, this is done and seems to be working.  I made a modified program new_make_magic_plots.py that will create image records and combine them with an existing images table if one is available.  Otherwise, it will create a new images table.  I have tested on 10 or so contributions and everything seems to work as expected, but we will probably find some more errors running it on the server.   If you can run it without replacing the existing plots, that might be best!

Plots have been running. Should be done this evening or tomorrow.

Found a bug in my code and needed to restart. I'll let you know when it's done.

Sounds good — I will expect to work on any errors found on Monday.

On Jun 21, 2019, at 10:07 AM, njarboe notifications@github.com wrote:
Found a bug in my code and needed to restart. I'll let you know when it's done.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub https://github.com/PmagPy/PmagPy/issues/352?email_source=notifications&email_token=AAOAMISTVNIEF3TQ2INCAIDP3UDG5A5CNFSM4FAAY4T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYJA7QQ#issuecomment-504500162, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOAMITZKC3VUP4VUGHJ65TP3UDG5ANCNFSM4FAAY4TQ.

The plots are done and the log is at http://34.236.167.37/plots/batchPlotsLog.txt
I saw only 4 Traceback errors. You can see the other files created in the plots/$MAGICID directories.

@ltauxe, you could check my fix for dayplot_magic in commit https://github.com/PmagPy/PmagPy/commit/bf0ab2936d38433733c816ad1c5dd2ee2023979c.
I was getting an error with contribution 14743 where the Bc list had no data and caused an error.  I just did the simplest possible fix but maybe some deeper logic should be used/fixed.

@njarboe, I fixed the two issues I found in the log.  Today is my last day of work for a while -- feel free to use the new_make_magic_plots if you want as it seems to be working!  I may also be available for small fixes here and there.

it seems to work as advertised.
lisa

On Jun 26, 2019, at 1:15 PM, Lori J notifications@github.com wrote:
@ltauxe https://github.com/ltauxe, you could check my fix for dayplot_magic in commit bf0ab29 https://github.com/PmagPy/PmagPy/commit/bf0ab2936d38433733c816ad1c5dd2ee2023979c.
I was getting an error with contribution 14743 https://earthref.org/MagIC/14743 where the Bc list had no data and caused an error. I just did the simplest possible fix but maybe some deeper logic should be used/fixed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/PmagPy/PmagPy/issues/352?email_source=notifications&email_token=AABKWDLHQOG3ELALRNQU43DP4PE5TA5CNFSM4FAAY4T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYUV7RA#issuecomment-506027972, or mute the thread https://github.com/notifications/unsubscribe-auth/AABKWDNO6RUUQOI5JUR7HBLP4PE5TANCNFSM4FAAY4TQ.

@njarboe, are you using new_make_magic_plots.py currently on the server?

Once #602 is solved, I will rename new_make_magic_plots to make_magic_plots and get rid of the old make_magic_plots.

I've renamed new_make_magic_plots --> make_magic_plots and removed the old version.

Changed server programs to use make_magic_plots again.

authors: ltauxe moonshoes87 njarboe

repo: PmagPy/PmagPy


text:
#49 日志改了级别不管用

能生效

能生效，有问题新开issue

authors: imuge kauchy tedyyan

repo: QOSGroup/qos


text:
cell details missing for multi sig levels

done and merged #1157

repo: Quantipy/quantipy


text:
Feature/switch lane

Azért a counteres implementációt csináltam végül, mert minden stackoverflow válaszban azt találtam, hogy a másodperc alatti felbontású időmérés megbízható módja más linuxon és windowson.... a sime clock() elvileg nem annyira jó.

Ez így szerintem teljesen okés, annyi hogy légyszi a kezdő curly braceket - { - egy sorba rakod ahogy volt? 😄 tudom, C-ben inkább a külön sorba rakás szokás, de most mindenhol egy sorban van. Az is oké nekem ha mindenhol átalakítod külön sorosra, csak egységes legyen 😁

Persze :D Igazából csak a case-ek behúzását akartam módosítani, és utolag láttam hogy a nyitó kapcsos mindenhol úgy van. Viszont akkor a case-t is visszateszem, a switch-hez képest egy-el beljebb.


text:
Add status checks to deploy command

I'm lazy so I may just toss in the @octokit/rest library to handle the api calls I don't want to manually write in nasty coffeescript. Not sure why that's how this thing works but fine, if that's how it be, then it do 🙄

repo: RealGeeks/hubot-deploy


text:
WIP Quarkus 1.3.0

Don't merge, I want to run the PR tests to see if this slows down on Github Actions also.

repo: RedHatInsights/custom-policies-engine


text:
Harsha added

Hi, thank you for your PR.
These changes are not relevant to the course content, since they are user-specific, and would break the learning material. Consequently, the changes would break the learning process for future students.
Please keep the changes in your fork, and continue the course with your fork. I am going to close this PR.
If you believe this to be an error, feel free to reach out, or open a new PR with further explanation.

authors: harshapyati m-czernek


text:
Fix travis osx

testing, not ready for merge

repo: RobotLocomotion/director


text:
half star is possible?

Currently it is not, will be added in the next version.

authors: JuanMelendres RodainaMohamed

repo: RodainaMohamed/ionic-rating


text:
Add chris caldwell to Contributors list

@ImmutableGlitch, I'm quite elated your first PR. I wanna build this in to a web app that addresses various problems faced by first time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I accepted it?
All the best for your future endeavours.

Thanks for the tutorial, it is well written and easy to follow! The only problems I have is with git. I'm not sure when to use certain commands, as well as what conventions are to be followed. For example with branches and merges. It felt great finally making a PR with it being accepted. I can now try to contribute to OSS :+1:

@ImmutableGlitch: Awesome to hear that. I hope we've explained what the commands used in this tutorial does enough.
Also we have added a list of famous projects with beginner level issues to the end of tutorial. Could you look through it and reply if it was useful to carry on with your open source contributions

authors: ImmutableGlitch Roshanjossey

repo: Roshanjossey/first-contributions


text:
Add touletan to Contributors list

Hi  @touletan, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

authors: Roshanjossey touletan


text:
Added copy text according to the tabs names

this looks ok for me - as it is only documentation update

authors: SAPMontreal joseegm

repo: SAP/techne


text:
chore: enable auto deploy to gh-pages

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant adrian-bobev


text:
skip chapter comment added

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

authors: CLAassistant marcuscbehrens

repo: SAPDocuments/Tutorials


text:
add very basic continous deployment

Ok, third time may be the charm...

repo: Scouterna/skojjt


text:
Add info on how to use the API to readme.

This will eventually be done, however it will be in the Wiki pages or the projects github page.

repo: Scroojalix/NPCManager


text:
updated podspec to supporty tvOS and watchOS

Hey @bsdspas, it doesn't look like XMLParsing as currently accepting any PRs. I have a fork of it called XMLCoder that updates the podspec for tvOS and watchOS, adds support for Swift 5.1 and a few other useful features. Hope you find it useful and I'd be very happy to accept any possible contributions!

authors: MaxDesiatov bsdspas

repo: ShawnMoore/XMLParsing


text:
Create CHANGELOG

LGTM

authors: SanoopC brianmhiggins

repo: SiftScience/sift-android


text:
DO NOT MERGE : Move files poc

Download Artifacts :

win-ia32
win-x64
linux-x64

authors: SocialGroovyBot cberthou

repo: SocialGouv/archifiltre


text:
Support Event de-duplication and time-window recycling

pie in the sky, no requirement.

authors: bhuvan-rk jxstanford

repo: Solinea/goldstone-server


text:
social media links update

Thanks @99sumedha!

repo: SustainableEducationFoundation/LiveWeb


text:
Add overview of gnpy & "vision statement" to Readme

Summary
We believe that openly sharing ideas, specifications, and other intellectual property is the key to maximizing innovation and reducing complexity
PSE WG Charter
Goal is to build an end-to-end simulation environment which defines the network models of the optical device transfer functions and their parameters. This environment will provide validation of the optical performance requirements for the TIP OLS building blocks.
The model may be approximate or complete depending on the network complexity. Each model shall be validated against the proposed network scenario.
The environment must be able to process network models from multiple vendors, and also allow users to pick any implementation in an open source framework.
The PSE will influence and benefit from the innovation of the DTC, API, and OLS working groups.
The PSE represents a step along the journey towards multi-layer optimization.

Features
GNPY simulation of an amplified optical link

Background
Data Centers are built upon interchangeable, highly standardized node and network architectures rather than a sum of isolated solutions. This also translates to optical networking. It leads to a push in enabling multi-vendor optical network by disaggregating HW and SW functions and focussing on interoperability. In this paradigm, the burden of responsability for ensuring the performance of such disaggregated open optical systems falls on the operators. Consequently, operators and vendors are collaborating in defining control models that can be readily used by off-the-shelf controllers. However, node and network models are only part of the answer. To take reasonable decisions, controllers need to incorporate logic to simulate and assess optical performance. Hence, a vendor-independent optical quality estimator is required. Given its vendor-agnostic nature, such an estimator needs to be driven by a consortium of operators, system and component suppliers.
Founded in February 2016, the Telcominfraproject (TIP)is an engineering-focused initiative which is operator driven, but features collaboration across operators, suppliers, developers, integrators, and startups with the goal of disaggregating the traditional network deployment approach. The group’s ultimate goal is to help provide better connectivity for communities all over the world as more people come on-line and demand more bandwidth- intensive experiences like video, virtual reality and augmented reality. Within TIP, the Open Optical Packet Transport (OOPT) project group is chartered with unbundling monolithic packet-optical network technologies in order to unlock innovation and support new, more flexible connectivity paradigms. The key to unbundling is the ability to accurately plan and predict the performance of optical line systems based on an accurate simulation of optical parameters. Under that OOPT umbrella, the Physical Simulation Environment (PSE) working group set out to disrupt the planning landscape by providing an open source simulation model which can be used freely across multiple vendor implementations.

authors: dutc ggrammel

repo: Telecominfraproject/gnpy


text:
Create Pool workflow: if user selects EC and 2+1, why do we still see Replicas?

duplicate of https://github.com/Tendrl/dashboard/issues/237

@julienlim @Tendrl/qe The bug is fixed from UI team. Please verify on the new build[1] available.
[1]. tendrl-dashboard-1.2.1-04_17_2017_17_24_12.noarch.rpm

Closing the issue as the fix is available

repo: Tendrl/dashboard


text:
You got a star the moment I saw Python as the language

Thanks. and I'll fix the issue soon :)


text:
Fix isort

@anapaulagomes I hope you don't mind me spamming with those things. :)

No worries. :) Is it ready to be reviewed? @amureki

@anapaulagomes yeah. Pydocstyle seems to add quite some new checks, so it fails in plenty of places. We'll check it separately later.

authors: amureki anapaulagomes

repo: Thermondo/django-heroku-connect


text:
Install bulma

Using antd instead cc @tronicdata

repo: Tokyo-Buffalo/pow-wow-calendar


text:
refactor: backend improvements

:tada: This PR is included in version 0.10.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

repo: TomaszKandula/TokanPages


text:
Is their anything in PHP similar to these codes?

There is indeed a Laravel version of this code. Check out the full tutorial for more information too.

authors: philnash rakesh-ideal

repo: TwilioDevEd/airtng-flask


text:
Fix a typo in the readme

Thanks!

authors: TyOverby neongreen

repo: TyOverby/bincode


text:
Update deps

Thank you!

authors: TylorS kibin

repo: TylorS/most-subject


text:
Z index

Looking good! What if the state line was one or two shades lighter?

I made the borders lighter

authors: amrhoades jread-usgs

repo: USGS-VIZLAB/hurricane-irma


text:
drop CIDA website, rename OWI website

Just GA table changes, so self-merging

repo: USGS-VIZLAB/internal-analytics


text:
For options show aliases in help if available

:tada: This issue has been resolved in version 4.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

repo: VamshiKrishnaAlladi/cli-max


text:
Anravins helpt

and i approve this message

repo: WaleTeam/porty


text:
fix rollback/commit transaction bugs and optimize experience.

Codecov Report

Merging #98 into dev will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##               dev     #98      +/-   ##
==========================================
- Coverage     4.59%   4.55%   -0.05%
  Complexity      26      26
==========================================
  Files           22      22
  Lines         1979    1998      +19
  Branches       237     240       +3
==========================================
  Hits            91      91
- Misses        1871    1890      +19
  Partials        17      17

Impacted Files
Coverage Δ
Complexity Δ

...rc/main/java/com/webank/wecross/console/Shell.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...va/com/webank/wecross/console/common/HelpInfo.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

.../com/webank/wecross/console/common/JlineUtils.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

.../com/webank/wecross/console/routine/TwoPcImpl.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...n/java/com/webank/wecross/console/rpc/RPCImpl.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2f5bc3...eb60b1f. Read the comment docs.

authors: codecov-commenter kyonRay

repo: WeBankFinTech/WeCross-Console


text:
(xa_config): Seperate xa_config to evidence and asset

Codecov Report

Merging #423 (c4c08b2) into release-1.0.0 (21d7068) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-1.0.0     #423   +/-   ##
================================================
  Coverage            14.98%   14.98%
  Complexity             397      397
================================================
  Files                  180      180
  Lines                 8074     8074
  Branches               664      664
================================================
  Hits                  1210     1210
  Misses                6777     6777
  Partials                87       87

repo: WeBankFinTech/WeCross


text:
Type validation via when clause in functions

continuation the discussion from #1
I think types should be checked by dialyzer, especially since there is no way for checking it at compile time by macros. The best we can do, is to properly generate typespecs for each case (which is not being done yet) and for each constructor.
I also think, the most important features of this lib are it's compile-time warnings. I'm afraid adding a feature that would work only in some cases will bring more harm than good (the when clause would work only when using from!/1 constructor but not when using from/1).
Being explicit should be the default, and this is one of Elixir's goals. That's why user can always define their own constructors which will add things like function gaurds and the user will have the notion that functions run at run-time so there will be no compile-time warnings in this case.
That explicitness is also why I'm currently thinking about making the dynamically built constructors (based on union tag's name) to be disabled by default, and adding more explicit constructor (also a macro) that would work like this:
defmodule  Result do
  use DiscUnion
  @type value() :: any()
  @type error_msg :: String.t
  @type last_value :: any()
  defunion Ok in value | Error in last_value * error_msg
end

defmodule X do
  require Result

  def x do
    Result.c Ok, 123
    Result.c! Error, 0, "FUBAR"
  end
end

The difference between c constructor and from/1 constructors is the former one has varying number of parameters, which depends on number of arguments each case has and the later one is designed mainly for interacting with statements that return a tuple (a defacto main encapsulation technique used in the BEAM). Making the bang-functions overridable, giving users the ability to create their own versions, with what ever validations they want.

Hmm I like the explicit constructor, still think a 'when' validation would work well on them to enforce that the right information is stuffed into the type.  But I am liking how that syntax works there.  I might recommend trying to enforce use Result instead of require that way you can add more macro's at inclusion time if the need arises later (a basic __using__ that just require's it is fine to start with).
And yeah, I am a fan of tagged tuples over map/structs myself, but I'm an old erlang programmer myself.  ^.^

The biggest problem I have with the guards idea is this:
Result.c! with when gaurd will have consistent validations: both, case checking and when
guard, would be done at run-time.
But Result.c would have a mixed validation:

at compile-time: validation of case tag name and number of params
at run-time: validation done by the when clause

This mixed validation is where I have mixed feelings (pun intended :wink:).

I might recommend trying to enforce use Result instead of require that way you can add more macro's at inclusion time if the need arises later

That's a good idea! Shorter to type and might can be handy someday.

And yeah, I am a fan of tagged tuples over map/structs myself, but I'm an old erlang programmer myself. ^.^

Here we have both! :smile:
Struct as a commin type for the entire union and a container for cases, which are tagged tuples. Using structs has also another reason: protocols! This gives the ability to combine unions with libraries like expede/witchcraft, slogsdon/elixir-control or rob-brown/MonadEx.
I will leave this open, because I'm not 100% sure about this yet. Even @josevalim was asking about this in elixir-lang/elixir#925.

This mixed validation is where I have mixed feelings (pun intended :wink:).

I personally like the mixed validation, as this is a dynamically typed language there is no way to enforce types internally at compile-time, so I take whatever and everything that I can get.  :-)

This gives the ability to combine unions with libraries like expede/witchcraft, slogsdon/elixir-control or rob-brown/MonadEx.

Ooo, a couple libraries I've not not come across  yet, thanks!

I will leave this open, because I'm not 100% sure about this yet. Even @josevalim was asking about this in elixir-lang/elixir#925.

Fascinating read, interesting to see that he and I are on the same page.  What I would like is that the constructors for the types had when clauses that we could optionally apply (thus can fully control what types are inside a given case).  That means we have less 'when' matching on the case/match itself since we know that the incoming bound is already correct (no need to when is_integer(something) when we already know it is that by the constructor), plus it is ALWAYS better to die on the constructor instead of the matcher (so we know 'who' is at fault, instead of just that a fault happened).  Excepting Elixir becoming fully typed (oh I wish!) I am instead a fan of putting when clauses on near everything.  Hmm...

Excepting Elixir becoming fully typed (oh I wish!)

Probably won't happen. Better check out j14159/mlfe, but they will have one big problem: static typing on messages from outside.

That means we have less 'when' matching on the case/match itself since we know that the incoming bound is already correct (no need to when is_integer(something) when we already know it is that by the constructor

Except you wouldn't! Not unless macro constructors are removed, and I actually think they have the biggest value here - more compile time warnings! Look here, and let's assume that when clauses are supported:
defmodule  Result do # same as above
  ...
end

defmodule X do
  def x do
    val = 1
    Result.c! Ok, val # This is a function call. Once evaluated, returns either
                      # a %Result{case: {Ok, 1}} struct or raises an error if case
                      # tag or param are not valid - param is validated via guards

    Result.c Ok, val # This is equivalent to typing %Result{case: {Ok, val}}
                     # This is a macro, so the struct is put in place of the call
                     # during compilation. So any `when` gaurd clause could not
                     # be ran cause you cant put guards into a struct and the
                     # value of `val` is known only at run-time

    # now let's make a typo!
    Result.c! Eror, :wat # Would rise an error only at run-time
    Result.c Eror, :wat  # Would rise straight away at compile-time.
  end
end

That means we have less 'when' matching on the case/match

You can still achieve that by creating your own constructor functions!*
defmodule Result do
  use DiscUnion, dyn_constructors: false

  defunion Ok in any | Error in any

  def ok(any), :do c Ok, any
  def error(reason) when is_atom(reason) do
    c Error, reason
  end
end

*Once this c constructor is implemented :smile:

... plus it is ALWAYS better to die on the constructor instead of the matcher (so we know 'who' is at fault, instead of just that a fault happened)

That's why I think that user-built constructors are the way to go here.
The most frequent use cases I see for discriminated union is creating collections of identifiers. Like in here: X4lldux/ex_json_schema@bff986de90d5954cc6daef6babfc60221029497e/lib/ex_json_schema/validator/error.ex or for creating a collection of CQRS/ES events. With that many variants simple human error will be more frequent - like typos or case omissions - than a wrongly passed case param. At least this is what I believe. For now, I still need to implement the c constructor generate more typespecs.

Probably won't happen. Better check out j14159/mlfe, but they will have one big problem: static typing on messages from outside.

That actually seems like a pretty easy issue to resolve, some kind of 'cast'er that returns a Result for Ok theWantedType or Error reason.  Will have to design the receive differently, match based on structure then enforce based on type, hence why you always have to handle an Ok/Error result because no putting it back on the mailbox transparently (which is often bad design anyway, so it is good to enforce that out).

Sent too soon, continuing...

Except you wouldn't! Not unless macro constructors are removed, and I actually think they have the biggest value here - more compile time warnings! Look here, and let's assume that when clauses are supported:

I would honestly be fine with removing them from match guards.  Match guards get integrated into a single function with a head case structure anywhere and I tend to try to follow that pattern already anyway.  However, there is a way to work around that by defining a custom def that could integrate such a macro'd when clause into the main clause.  Not hard to make but would turn your example into:
# From this:
def func(Result.c(Ok, val)), do: nil
# To this:
defsomething func(Result.c(Ok, val)), do: nil

The most frequent use cases I see for discriminated union is creating collections of identifiers

Yeah that would be the big use-case for me as well, I have a lot of areas where enforced checking like this would save me a lot of hassle.

I would honestly be fine with removing them from match guards. Match guards get integrated into a single function with a head case structure anywhere and I tend to try to follow that pattern already anyway. However, there is a way to work around that by defining a custom def that could integrate such a macro'd when clause into the main clause. Not hard to make but would turn your example into:

Don't quite understand your message here. Can you rephrase that? By those "macro constructors" I meant those autogenerated macros  for each union, from/1, dynamic constructors and that future c macro.

That actually seems like a pretty easy issue to resolve

I think it's not. Type check they implemented, infers based on what it can find in the code. Now, what would happen to messages sent from outside - say a :DOWN message sent by the BEAM; typechecker has no way of knowing this message can be sent. They even say it them selfs:

If you spawn a function which nowhere in its call graph posesses a receive block, the pid will be typed as undefined, which means all message sends to that process will be a type error.


text:
docker: support ubuntu 16.04

Should you execute the command apt-get update before install ?

Should you execute the command apt-get update before install ?

thanks for your review, this is a mistake.

authors: neverchanje wangdehu

repo: XiaoMi/pegasus


text:
Add foldlWhile, foldlWhile1, satisfy, satisfyMaybe

Thank you!

authors: Yuras nikita-volkov

repo: Yuras/scanner


text:
Randbats: Ensure that Genesect's forme matches its drive if it has one

Randbats should be able to generate any forme of any Pokémon... this'll need to be fixed at some point.

Randbats should be able to generate any forme of any Pokémon... this'll need to be fixed at some point.

You do know that Genesect form is literally a sprite difference and being stuck with a coverage move it doesn't need at the loss of an item? People complained about these shitty Genesect sets and so they were removed. Formes with actual differences I can agree with.

Yes, I also know that Unown is strictly outclassed by like any other Pokémon.

I don't know, it seems wrong to just not use a Pokémon at all just because it's bad.

I don’t think you understand how seriously Random Battle is taken. People play this competitively. We’re already forced to use f’n joke sets.
It’s not even a Pokémon. It’s literally an item. Every Pokémon is in Randoms (except I think Castform-Snow but I can fix that).

Maybe the default should be Battle Factory. :|
You can play competitively with suboptimal Pokémon. That always seemed like the point of randbat to me.

We do have suboptimal sets, or sets that you don’t see competitively you could say. Douse Drive isn’t optimal, for example. But it isn’t a literal handicap on Genesect as the other Drives are.
If you want the default format to emphasize the official Smogon tiers more, then yes, Battle Factory should be default. But I think Random Battle appeals to the casual audience more. While we try to make it competitive, it’s still fun at the same time. We’re not Battle Factory level of strictness, and not Challenge Cup level of randomness.

https://dex.pokemonshowdown.com/moves/technoblast
Techno Blast was buffed to 120 power, so it's not strictly outclassed by Thunderbolt and Flamethrower and Ice Beam anymore. It might be weaker than other sets but it still seems like a Pokémon to me.
I hope we're not also excluding Darmanitan-Z and Meloetta-P on the grounds that they're weaker than other sets.

I've played over 2000 games of Gen 7 Randbats and I've never seen a Darm-Z.

Meloetta-P is actually a good set, it's always been in.

It seems the best way to deal is just to raise the level on handicap sets if they're that much of a handicap.

Incidentally, I've heard Belly Drum Darm-Z can be interesting. Not a great set but has some surprise value, and sometimes that's the best you can do in randbats.

Absolutely not. That's akin to complex bans, they'll be no end. In addition, levels would be arbitrarily picked.
I wouldn't be completely opposed to Darmantian-Zen. I'll see if I can come up with a decent set.

I mean, we're talking about tiering formes separately, a time-honored tradition.

And imo way better than ability bans and move bans.

authors: MacChaeger TheImmortal Zarel

repo: Zarel/Pokemon-Showdown


text:
typo :)

Thank you! @b1nary

repo: abergs/ubuntuonwindows

license: unlicense


text:
Explore webpack-command to replace webpack-cli

It went pretty smooth for the seed.
https://github.com/abraham/nutmeg-seed/pull/130

repo: abraham/nutmeg-cli


text:
Add PHP Composer example

@Crease29 Can you rebase this PR?

Done. Would you mind if I re-order the examples in that file by alphabet?

Hi @joshmgross, thanks for the link! I didn't know that yet!
Is the directory ~/.composer/cache/files available in the container? If so, I'd change the path in the examples.md 🙂

~/.composer/cache/files should be available

On windows ~/.composer/cache/files will not work as cache directory on windows will be
C:\Users\runneradmin\AppData\Local\Composer\files
So for a cross platform solution cache directory can be found using.
composer config cache-files-dir

@shivammathur Thanks!
@Crease29
You can use that value with an action output, like:
- name: Get Composer Cache Directory
  id: composer-cache
  run: |
    echo "::set-output name=dir::$(composer config cache-files-dir)"
- uses: actions/cache@preview
  with:
    path: ${{ steps.composer-cache.outputs.dir }}
    key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
    restore-keys: |
      ${{ runner.os }}-composer-

I've verified that the composer config cache-files-dir command works on all hosted runners.

Ubuntu: /home/runner/.composer/cache/files
Windows: C:/Users/runneradmin/AppData/Local/Composer/files
Mac: /Users/runner/.composer/cache/files

Thank you all for your contributions to this PR! I adjusted my changes now.
Two things that I saw in that file:

I'd like to re-order the examples alphabetically.
The Yarn and Nuget examples also use ~ as home directory identifier. Should that be updated to a cross-platform solution as well?

@Crease29 Thanks!
@hugovk re-ordered the examples here: https://github.com/actions/cache/pull/52 (Looks like that's caused merge conflicts for this PR)

The Yarn and Nuget examples also use ~ as home directory identifier. Should that be updated to a cross-platform solution as well?

~ is valid in those cases as they're still under the home directory, whereas this is under ~/AppData/Local on Windows

Alright, I squashed my commits. Should be all fine now 🙂

authors: Crease29 joshmgross ruudk shivammathur

repo: actions/cache


text:
CI for Node

Initializes with two players

repo: acunamv/github-actions-for-ci


text:
Fix typo in name of Changelog file

Good spot, thanks!

authors: adamgreig johkra


text:
Create README

I am actively updating my branch of this script so that it does two basic things:

Works across all altcoins or testnets based on the first character
Allows for a system of character substitutions which expands the base-58 hash addresses to be much more readable.   I use this to great effect on https://dime.cash/doge and can even create complex "sendmany" messages such as:

https://chain.so/tx/DOGE/fae43b9d044c74bc63b606a05ef95932b246a4001addd1091009e387e6010c80
I am not a great python scripter, but more of a hacker.  Maybe you would be interested in updating unspendable.py to integrate some of my ideas.
The reason why I chose to work with dogecoin was because a message system built on proof-of-burn is significantly less expensive that with bitcoin.
I also am a bit of a newbie when it comes to pull requests on github.
Thanks

authors: johnrigler kenorb

repo: adamkrellenstein/unspendable


text:
Add new linter rules

Can you resolve the conflicts?

authors: CedrikNikita mradkov

repo: aeternity/aepp-raendom

license: ISC


text:
Update config.yml

Not needed any longer as deployment of 0.11.0 ok.
@acidsennui Thanks for the proposed changes though, may be reused for next release. Tracked as https://www.pivotaltracker.com/story/show/156798908

authors: acidsennui lucafavatella

repo: aeternity/epoch


text:
Added method to set label on the "Use" button on Still shot Preview

I think it'd be better to replace the name of current labelUseVideo method, instead of creating a new method and property... something like labelConfirm, let's see what people think...

Would also prefer if it only had one method, would suggest adding labelConfirm and mark labelUseVideo as @Deprecated

Made some changes if you can check if it would be sufficient @afollestad

I find it perfect now... just for the changes in MainActivity.java, I'd left it with defaults.

I guess you can but BaseCaptureActivity:522 shouldn't compensate for this you should not need to set the default text
  public int labelConfirm() {
        return getIntent().getIntExtra(CameraIntentKey.LABEL_CONFIRM, useStillshot() ? R.string.mcam_use_stillshot : R.string.mcam_use_video);
    }

Thanks guys!

authors: afollestad mowcixo wscheffer

repo: afollestad/material-camera


text:
add osx support

So, from your PR, the only difference between linux and darwin shell is one line, on linux:
const ioctlReadTermios = syscall.TCGETS

and on darwin:
const ioctlReadTermios = syscall.TIOCGETA

Is this PR a WIP or do you wanted to just show me the tested version that works on osx?

yes that is the only difference. it is up to you what to do. i tested the change and it works.

@Eiffel-Alpine, I incorporated your changes and added you to changelog https://github.com/ai-traders/dojo/releases/tag/0.3.2. From now on, Dojo will be cross compiled and there will be two binaries released: one for Linux and one for Darwin.

authors: Eiffel-Alpine xmik

repo: ai-traders/dojo


text:
(temp fix) don't treat warnings as errors on GDALOpen()

This PR is superseded by #20

repo: airbusgeo/godal


text:
add requirements.txt with paho + locustio

:+1:


text:
Navigation: View Experiences

@jhlink I have made the changes in all files. Could you take a look at them?

@jhlink I think I've resolved the merge conflicts. Is it good to merge now?

@anoura12 I'll take a look later today!

PR is good. Merging.

repo: alan-turing-institute/AutSPACEs


text:
set js syntax highlighting for readme codeblock examples

Done, thanks!

:+1:

authors: alexkuz tunnckoCore

repo: alexkuz/jss-css


text:
opus_packet_loss missing from opus.c "Configuration options" comment

Thanks.

repo: alfredh/baresip


text:
First release to production

@allykrupina, would also be great if you would add label, project, and milestone to make this pull request fully comprehensive

authors: allykrupina dasha-korotkykh

repo: allykrupina/homepage


text:
improving README: explanation of contents

:+1:

authors: robyoung tommorris

repo: alphagov/digitalmarketplace-utils


text:
Update config flag function descriptions and add ped config flags enum

Note: Accidentally some CRLFs were converted to LF

I'm not entirely convinced that such enum like here is worth adding, when it's much likely to change every GTA update and yet it's not complete list

I'm not entirely convinced that such enum like here is worth adding, when it's much likely to change every GTA update and yet it's not complete list

Do the names change? I don't think so, isn't it?

I'm not entirely convinced that such enum like here is worth adding, when it's much likely to change every GTA update and yet it's not complete list

They haven't changed before so I don't think they will ever change, I mean why would they. I think it's fine to add an enum like that even if it's not complete.

Internally it was confirmed, that only one flag works.
So if you want still to make changes to this PR:

remove link to wiki
remove enum
change flag parameter type from string to that string literal

Alright, good to know.
Fixed that so far with two side notes:

I renamed PedConfigFlags to PedConfigFlag for a more precise naming
string | PedConfigFlag type is needed as some JS/TS (trans-)compiler do not substitute enum values when ignoring the alt-client module (e.g. when using bundlers).

Enum for this one flag isn't needed, just replace it with string literal, as only one flag is valid for this function

Enum for this one flag isn't needed, just replace it with string literal, as only one flag is valid for this function

@Lhoerion I get your point, though I think it is more clever to "outsource" the flags to another datatype, because then it would be more easily to maintain (e.g. adding or removing flags).

It actually not related to ped at all, just some random global flags

Not sure where did you get name, but the only existing flag is DISABLE_PED_PROP_KNOCK_OFF

Not sure where did you get name, but the only existing flag is DISABLE_PED_PROP_KNOCK_OFF. It globally disables knock off for all peds

@vadzz-dev sauce: https://wiki.altv.mp/wiki/GTA:Ped_Config_Flags

This function is not related to that list in any way. It was made for random stuff that can't be achieved with natives

This function is not related to that list in any way. It was made for random stuff that can't be achieved with natives

@vadzz-dev Then the documentation was bad all the time. I fix that in a second

@vadzz-dev Then the documentation was bad all the time. I fix that in a second

It wasn't bad

authors: LeonMrBonnie Lhoerion TheMysteriousVincent vadzz-dev

repo: altmp/altv-types


text:
[SMALLFIX] close ioer to avoid Java warning

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/5809/
Test PASSed.

Out of curiosity, what tooling do you use to check for the resource leaks / Java 6 incompatibility?

LGTM +1

Eclipse shows the Java 6 incompatibilities as errors, and the resource leaks as warnings

authors: AmplabJenkins aaudiber jsimsa

repo: amplab/tachyon


text:
Add CODATA-RDA blog

@benbrecht Congrats on contributing your first blog post! :100:

authors: anelda benbrecht

repo: anelda/escalator-sadilar


text:
Significant speed improvement on opening typeahead

Remove changes to dist, then squash commits then rebase.

I don't see any differences between this and #1139 (which seems to be in better shape anyway) so I'm going to close this.

authors: timgl user378230 wesleycho

repo: angular-ui/ui-select


text:
feat(form): do not prevent submission if action attribute present

[angular.js] IgorMinar pushed 3 new commits to master: http://git.io/jEkZEA

authors: IgorMinar vojtajina


text:
Remove plugin doc support for shadowed collections

This functionality is critical to the UX, keeping it in.  May impact #212

repo: ansible/ansible-navigator


text:
3.5.x 版本升级 g

@simaQ @dengfuping 这次升级有哪些改动，现在导致下面的 DEMO 运行报错，v3.5.15是ok的
https://codesandbox.io/s/g2-3x-g-c8kr5?file=/src/index.js

@zqlu @dengfuping 主要就是升级了 G，看这个应该是 G 导致的，小岳岳看一看

@zqlu G 的改动是支持 CSS Transform，不过为了避免影响已有业务，现在需要手动开启。参考这个 PR: https://github.com/antvis/g/pull/520

应该和 antvis/g#520 无关，因为 G2 这边升级了 G 的中间版本号，直接从 ~3.3.6 升级到了 3.4.9，中间版本的变更之前一直没有被 G2 感知。

@zqlu 中间的修改时长跨度比较大，不太好排查问题，而直接回滚会影响 CSS Transform 相关的业务。能否帮忙在 G2 这边定位下是什么问题呢，看下最终传到 G 这边的属性是什么样的？ @simaQ

@simaQ @dengfuping  看了下，
在 https://github.com/antvis/g/blob/d1b1f7f039e4ccb583a70fd70af6950386daf378/src/shapes/path.js#L293 这里报错；
Path shape 的 attrs
{
  "opacity": 1,
  "fillOpacity": 1,
  "strokeOpacity": 1,
  "matrix": [1, 0, 0, 0, 1, 0, 0, 0, 1],
  "lineWidth": 2,
  "startArrow": false,
  "endArrow": false,
  "stroke": "#1890FF",
  "strokeStyle": "#1890FF",
  "fill": null,
  "fillStyle": null,
  "path": [["M", 1138.75, 312]]
}

@zqlu 👍，我晚点修复下。

@dengfuping 有空跟进下这个？ 不然现在依赖3.x的用户重新install后都会有这个问题

@zqlu 3.4.10 版本修复了这一问题。

authors: dengfuping simaQ zqlu


text:
some further clean-up

Looks good. I like the use of comma operator in allocate.

authors: aoh jo-he

repo: aoh/owl-lisp


text:
Exclude internal classes from generated javadoc

Merged in https://github.com/aol/cyclops-react/pull/339

repo: aol/cyclops-react


text:
CAMEL-13791: incoming message: Add QoS Information into a header

I'll merge tomorrow. Thanks @Fabryprog

Merged on master. Thanks.

authors: Fabryprog oscerd

repo: apache/camel


text:
FALCON-2187 Refactoring to move entity xsd and jxb bindings to a new nmodule

+1 for the changes. This might need some changes to falcon-regression. Please raise a JIRA for the same.

Created the jira : https://issues.apache.org/jira/browse/FALCON-2192

authors: pallavi-rao sandeepSamudrala

repo: apache/falcon


text:
HBASE-24285 Move to hbase-thirdparty-3.3.0

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

_ Patch Compile Tests _

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m 40s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

_ Other Tests _

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

19m 37s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1605

Optional Tests
dupname asflicense hadoopcheck xml

uname
Linux b45e24068e9b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3781ac9dac

Max. process+thread count
76 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 36s
master passed

+1 :green_heart:
compile
3m  0s
master passed

+1 :green_heart:
shadedjars
5m 44s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 17s
root in master failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 26s
the patch passed

+1 :green_heart:
compile
3m  2s
the patch passed

+1 :green_heart:
javac
3m  2s
the patch passed

+1 :green_heart:
shadedjars
5m 39s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 16s
root in the patch failed.

_ Other Tests _

-1 :x:
unit
187m 35s
root in the patch failed.

217m 39s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1605

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 99d23b76b31d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3781ac9dac

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/1/testReport/

Max. process+thread count
3158 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 53s
master passed

+1 :green_heart:
compile
2m 13s
master passed

+1 :green_heart:
shadedjars
4m 59s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  1s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 21s
the patch passed

+1 :green_heart:
compile
2m 15s
the patch passed

+1 :green_heart:
javac
2m 15s
the patch passed

+1 :green_heart:
shadedjars
4m 53s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 55s
the patch passed

_ Other Tests _

-1 :x:
unit
274m 20s
root in the patch failed.

303m 10s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1605

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 1510baf83011 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 3781ac9dac

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/1/testReport/

Max. process+thread count
5531 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

The backup failures are regular flakies (backup seems abandoned). Reran the build to see if failures at all related.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

_ Patch Compile Tests _

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
hadoopcheck
11m 20s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

_ Other Tests _

+1 :green_heart:
asflicense
0m 18s
The patch does not generate ASF License warnings.

18m 40s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1605

Optional Tests
dupname asflicense hadoopcheck xml

uname
Linux f2014f85dc17 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 13f36d9db3

Max. process+thread count
76 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 26s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 58s
master passed

+1 :green_heart:
compile
3m  7s
master passed

+1 :green_heart:
shadedjars
6m  0s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 22s
root in master failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 42s
the patch passed

+1 :green_heart:
compile
3m  9s
the patch passed

+1 :green_heart:
javac
3m  9s
the patch passed

+1 :green_heart:
shadedjars
5m 58s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 23s
root in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
261m 39s
root in the patch passed.

293m 51s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1605

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 069505b46a88 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 13f36d9db3

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/2/testReport/

Max. process+thread count
4220 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 25s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 21s
master passed

+1 :green_heart:
compile
2m 39s
master passed

+1 :green_heart:
shadedjars
5m 29s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 15s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 56s
the patch passed

+1 :green_heart:
compile
2m 37s
the patch passed

+1 :green_heart:
javac
2m 37s
the patch passed

+1 :green_heart:
shadedjars
5m 30s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
387m 32s
root in the patch passed.

420m 25s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1605

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b7649c2ff6af 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 13f36d9db3

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/2/testReport/

Max. process+thread count
3890 (vs. ulimit of 12500)

modules
C: . U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1605/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

I think #1611 can then be closed, or?

Sure, I'll cherry-pick this and close #1611.

authors: Apache-HBase petersomogyi saintstack

repo: apache/hbase


text:
Ignite gg 13067

Closing temporary (test-only) PR. Feel free to reopen if needed.

authors: dkarachentsev dspavlov

repo: apache/ignite


text:
dubbo-spring-boot-starter 不兼容 spring-boot 2.1.1

What's error message?

My test works, however, dubbo-spring-boot-starter 0.2.1 will upgrade Spring Boot 2.1.1.RELEASE

authors: hanwb-code mercyblitz


text:
Add incubator disclaimer to Fluo Parent POM

+1

+1

authors: ctubbsii keith-turner mikewalch

repo: apache/incubator-fluo


text:
added filter on databaseView that filters databases based on access in roles

Looks like there's a lot of unwanted changes in this PR

If you could explained to me the unwanted to changes or the way you would prefer I implement the filter that would be helpful. I previously just followed @mistercrunch directions that were suggested (https://github.com/apache/incubator-superset/issues/5207#issuecomment-436886833).

@xrmx I believe I understand what you mean by unwanted changes. Will remove unwanted file changes.

Codecov Report

Merging #6356 into master will increase coverage by 0.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master    #6356      +/-   ##
==========================================
+ Coverage   77.33%   77.34%   +0.01%
==========================================
  Files          67       67
  Lines        9578     9587       +9
==========================================
+ Hits         7407     7415       +8
- Misses       2171     2172       +1

Impacted Files
Coverage Δ

superset/security.py
75.87% <100%> (+0.21%)
:arrow_up:

superset/views/core.py
74.87% <71.42%> (-0.02%)
:arrow_down:

superset/connectors/druid/models.py
82.59% <0%> (+0.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ffb48c...7be9bf2. Read the comment docs.

Minor comment, otherwise LGTM

@mistercrunch I went ahead and made the suggestion changes and also updated the tests accordingly.

Hi folks, is there anything that can be contributed to integrate the changes from this PR?

Please rebase / fix conflicts

Not stale

A similar PR has been merged already, closing https://github.com/apache/incubator-superset/blob/8c17c1927937362a22c07d1362f00992e56621a1/superset/views/core.py#L203-L208

Kind of salty that this PR has been open for 8 months and changes that were asked were fixed months ago as well. But I guess if someone else beat me to the punch of getting the same changes in... glad the security issue is fixed.

@pbr0ck3r it's hard for maintainers to keep up with the pace of this repository and the volume of information that gets through here. I wish all PRs and issues would get the attention they deserve.
But I don't think I get notifications when new commits are added to a PR, so I'd recommend commenting/tagging on the PR once comments are addressed. I process most of my notifications, though I'll miss a certain percentage, but if there's no notifications there's no chance maintainers will catch things.

authors: codecov-io mistercrunch pbr0ck3r tomaszj xrmx

repo: apache/incubator-superset


text:
fixes #1673: Fix tenant update

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/799/
Test PASSed.

authors: asfgit nir-sopher

repo: apache/incubator-trafficcontrol


text:
当数据包长度很大时, 压缩的数据包长度仍然超过m_compressMsgBodyOverHowmuch的值时，重试发送时，仍然会压缩，但是消费端只解压一次，数据就错了。

@hydong01 This issue has been resolved，please use the latest version.

repo: apache/rocketmq