text:
ExponentialRetryPolicy materializes GetIntervals()

The constructor of ExponentialRetryPolicy materializes the IEnumerable<TimeSpan> returned from GetIntervals(). This seems directly opposed to its nature:

It is an iterator function.
It treats Int32.MaxValue as unlimited.

When using retryLimit: Int32.MaxValue, which GetIntervals() explicitly special-cases, the loop is infinite (until ToArray() tries to allocate an array that is too large).
Even when avoiding Int32.MaxValue, when trying to accommodate a very large number of attempts, the materialized array can take a lot of memory, when the intervals could just be calculated on-the-fly. Materialization also incurs a lot of calls to Random.Next() that would otherwise have been amortized over the lifetime of the policy instance.
A good alternative property type to TimeSpan[] might be IEnumerator<TimeSpan>, since it enforces forward-only behavior. It is a public property, unfortunately, so I'm not sure how far the impact reaches.
I ran into this issue when I was trying to use exponential message retries in MassTransit 7.0.7.

As a side-note, there also seems to be the potential for a bug in the _retryLimit == int.MaxValue special case in GetIntervals():
Random random = new Random();
for (int i = 0; _retryLimit == int.MaxValue || i < _retryLimit; i++)
{
	int num = (int)Math.Min((double)_minInterval + Math.Pow(2.0, i) * (double)random.Next(_lowInterval, _highInterval), _maxInterval);
	yield return TimeSpan.FromMilliseconds(num);
}

When i wraps around, i will be negative, resulting in negative time spans, if I'm not mistaken. Next, i will be small again (0, 1, 2, ...), resulting in shorter time spans than were returned before, when i was large.
_retryLimit == int.MaxValue seems to indicate the intent of supporting infinite retries (for which I salute you). The use of a ulong as the loop variable might help to avoid the wrap-around troubles.

Yeah, it's a sharp tool. Specifying a retry limit that high is, well, not recommended.

FYI, I finally got around to cleaning this up a bit.

Is it intentional that exceeding _maxInterval short-circuits the loop on line 68?
I'm pondering what my expectations would be. It's fairly easy to specify a maxInterval that is reached more quickly than a given retryLimit, due the the former's exponential nature.
If I specify maxInterval=TimeSpan.FromSeconds(60) and retryLimit=100, then I would honestly expect 100 retries if necessary. After all, to me, the retryLimit is something I am taking clear control over, whereas the maxInterval is just a maximum, where I expect things to scale in between in some exponential fashion.
Currently, to achieve the exact retryLimit I am specifying, I have to (A) know the scaling formula and (B) predict the result of the random generator.
I would expect one of two scenarios:

Either maxInterval is reached at some attempt (for example at attempt number 10) and then stays at my given ceiling for the remaining attempts;
or the intervals gradually scale up to maxInterval, i.e. they scale more slowly.

Since the second option gets rather convoluted with being exponential, I would actually expect the first.
Might that make more sense than specifying a maxInterval and retryLimit where only one of them is going to end up being the determining factor?

Did you miss something? It still retries up to the RetryLimit. Once the delta reaches the maximum interval, it stops calculating and just uses that max interval for each subsequent retry.

I did miss something! I'm guessing this is what causes the behavior you describe:
delta = (int)Math.Min(_minInterval + Math.Pow(2, i) * random.Next(_lowInterval, _highInterval), _maxInterval);
So the delta never exceeds _maxInterval.
My confusion stemmed from the loop containing that line:
for (var i = 0; i < RetryLimit && delta < _maxInterval; i++)
It has a termination condition once delta reaches _maxInterval. I'm wondering if that condition can be hit at all.

It does, and the unit tests verify it.

I stand corrected.

No worries, appreciate the concern to recheck the logic!

authors: Timovzl phatboyg

repo: phatboyg/GreenPipes


text:
Define eu usecase

closes #157

Need to check what happens when nc files with different year ranges are opened correctly.

source: gharchive/pull-request

authors: SarahAlidoost sverhoeven

repo: phenology/springtime

license_type: permissive

license_source: github-api


text:
replace Layouts with PostLayouts

Layouts is not defined among the context, but PostLayouts is. I guess it might be easier to understand while the layouts array has the same variable name, no matter Layouts or PostLayouts.

I have updated docs in #1111 and it's fixed there! Thanks!

authors: MoOx YuyingWu

repo: phenomic/phenomic

license: mit

license_source: bigquery


text:
Create new desktop app testing methods

Since the installer builder is now going to be the desktop app, with many major changes. This means that we need to methods and procedures to doing these tests.
Things that may/may not be needed:

Test template, as tests will likely be less frequent and possibly on request
Alterations/rewrite of QA book section.

New/Changed Aspects:

How many sims/what sims should be tested
What non sim aspects should be tested (locale, zooming, etc.)
Should old versions be kept
How often should routine tests be done (likely depends in part on how often builds happen)
How many/what platforms should be done
How will these builds be accessed to test

@KatieWoe, I recently installed Ubuntu (the most common Linux distribution) on my Linux laptop. If we ever need non-VM Linux testing for the Desktop app, I can do it.

@KatieWoe, I recently installed Ubuntu (the most common Linux distribution) on my Linux laptop. If we ever need non-VM Linux testing for the Desktop app, I can do it.

Great! At the moment, if I recall correctly, they may be having trouble getting a Linux distribution made, so no need at the moment.

Great! At the moment, if I recall correctly, they may be having trouble getting a Linux distribution made, so no need at the moment.

Most things here have been worked out. A test template will be made for https://github.com/phetsims/qa/issues/1143

source: gharchive/issue

authors: KatieWoe muedli

repo: phetsims/qa

license: MIT


text:
Failing to suggest correctly for array.len() and thread_rng().gen_range()

Hi,
First of all I'd like to say I am very new to Rust, but racer, alongside Atom plugins and the rust-lang.org/book, have so far made the learning process a pleasure - thank you.
racer has been exceptionally useful, however whilst working through "the book" I have noticed the occasional situation where it seems to fail to suggest where I might expect it.
Please see a small example program below:
extern crate rand;
use rand::Rng;
fn main() {
    let days = ["Monday", "Tuesday", "Wednesday", "Thursday", "Friday", "Saturday", "Sunday"];
    let num_days = days.len();  // Why doesn't .len code-complete in racer?
    //------------------^
    println!("num_days = {}", num_days);
    let rnd_day_idx = rand::thread_rng().gen_range(0, num_days);  // Why doesn't .gen_range code-complete in racer?
    //-----------------------------------^
    let rnd_day = days[rnd_day_idx];
    println!("Randomly-chosen day idx {} is {}", rnd_day_idx, rnd_day);
}

This program compiles and runs successfully; however when I try to auto-complete at the locations marked by the comments, I get the following output:
racer_test$ racer complete 5 25 src/main.rs
PREFIX 24,25,l
- Could not match expr node type: ExprVec([expr(4294967295: "      "), expr(4294967295: "       "), expr(4294967295: "         "), expr(4294967295: "        "), expr(4294967295: "      "), expr(4294967295: "        "), expr(4294967295: "      ")])
END

And:
racer_test$ racer complete 8 42 src/main.rs
PREFIX 41,42,g
MATCH gen,420,7,~/.cargo/registry/src/github.com-88ac128001ac3a9a/rand-0.3.14/src/lib.rs,Function,fn gen<T: Rand>(&mut self) -> T where Self: Sized
MATCH gen_weighted_bool,480,7,~/.cargo/registry/src/github.com-88ac128001ac3a9a/rand-0.3.14/src/lib.rs,Function,fn gen_weighted_bool(&mut self, n: u32) -> bool where Self: Sized
END

I'm just curious as to whether this is a known issue and what the cause of it is, so I know what to look out for in the future; or, perhaps this could instead be caused by an incorrect local setup?
Many thanks!

Hi, original poster here. (Apologies if replying to self is frowned upon.)
If it turns out the issues in my original post are in fact expected behaviour, I was just wondering whether anyone instead could point me towards some info that details what is and is not supported by racer?
I've had a quick look through the pages here at gihub but I couldn't find any obvious list of current limitations or planned future work.
I guess in the end all I'm really after is some kind of reassurance that I have my system setup correctly and that the limitations I'm seeing are the same as everyone else.
Thanks!

Seems like two different bugs. You could call it expected yes (racer isn't good at type inference) but it's a bug nonetheless.

Hey, thanks for the info @bluss. I wondered whether they might be two separate issues, but I wasn't sure whether they could also be symptomatic of the same underlying problem.
I'm not sure whether to keep this Issue open or not. If this is something that's simply outside the scope of racer then I'm happy for this to be closed.
Thanks again for the reply!

@thoughton Racer should definitely be providing completions here. As @bluss mentioned, racer's type inference could use some love.

Ahha, thanks @jwilm! In that case I will leave this open then. :-)
I really wish I could help somehow, but like I said, I'm afraid I'm very much a Rust beginner right now.

authors: bluss jwilm thoughton

repo: phildawes/racer


text:
Feat/edit category delete

Heyho. I added the functionality that u can delete categories.
If you delete one category & no standard category exist, i create a new standard category

LGTM! Nice design btw, i like it :)

repo: philmetscher/capstone-project


text:
Pull request Akhil_SYSC5807

By submitting this pull request I confirm I've read and complied with the below requirements.

[ x] I have read the Contribution guidelines and I am confident that my PR reflects them.
[x ] I have followed the coding guidelines for this project.
[x ] My code follows the skeleton code structure.
[ x] This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.

Pull request Akhil_SYSC5807


text:
Audio on iPhone 8/X

Hello,
the audio doesn't seem to work on either iPhone 8 or X . Has anyone encountered this?
Thanks!

Audio not working on iPhone 7+, iOS v11.1.2, either.

Hi all,I also meet this issue.  iPhone X version is 11.4.1

Is there any solution to fix this issue? thx

It does work... sometimes. Somehow. I got it working one day.. and then changed something, and it stopped working. Seems to have something to do with the surrounding markup, or which event handlers you have floating around. I don’t know. :-(

you need run a audio element by click or touchstart event firstly.

 // 手动启动audio，解除新的ios audio不能自动播放的问题
var audio = document.createElement('audio')
audio.autoplay = 'autoplay'
audio.volume = 0
audio.src = 't.aac'
// 手动触发audiocontext,让其从suspended变为running模式
_this.player.audioOut.unlock(function() {
    console.log('unlock success');
});

Before playing audio, you should break the restriction in modern mobile web browser first?
How to break it? Interact with the browser via vaild user interaction described at here.

repo: phoboslab/jsmpeg


text:
psh: ping: remove info about min interval

Description

JIRA: CI-350
Motivation and Context

Based on:
https://github.com/phoenix-rtos/phoenix-rtos-project/issues/851
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

[x] Already covered by automatic testing.
[ ] New test added: (add PR link here).
[ ] Tested by hand on: (list targets here).

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing linter checks and tests passed.
[x] My changes generate no new compilation warnings for any of the targets.

Special treatment

[ ] This PR needs additional PRs to work (list the PRs, preferably in merge-order).
[ ] I will merge this PR by myself when appropriate.

Please add Fixes phoenix-rtos/phoenix-rtos-project#851 in the commit message body to automatically pin the PR to the issue (and automatically close it when the PR would be merged).
Other than that, LGTM.

@nalajcie Done

repo: phoenix-rtos/phoenix-rtos-utils


text:
Specifying and accessing a specific number of non-option arguments

Hi  Paul,
I have a challenge to specify a command-line that has some options and exactly
a single non-option argument. This is the specification of the non-option
argument.
OptionSpec key = parser.nonOptions("nbr key").ofType(String.class).describedAs("key");
After parsing a command-line with more than one non-option argument, an
MultipleArgumentsForOptionException
with the message
"Found multiple arguments for option [arguments], but you asked for only one"
was thrown when I have called
options.valueOf(key)
If I would have called
options.valuesOf(key).get(0)
the erroneous use of the command with more than a single non-option agument
remains undiscovered.
A similar inconsistency occures, if the non-option argument is missing.
options.valueOf(key)
returns null
options.valuesOf(key).get(0)
throws an IndexOutOfboundsException.
My question is the following: How can I specify a fixed number of non-option
arguments in a way that access after parsing of an invalid command-line always
throws an OptionException with a meaningful message?
In the past you did work on issue #17 and you did introduce the methods
at(Lea|Mo)st to NonOptionArgumentSpec with the commit
Please explain the reason why these methods were never released?
Kind regards
Sven

@XSven To be honest, I can't remember the reason for not ultimately including this functionality. I'm willing to look into re-introducing it.

Yes please do so. Please consider the following:
From my perspective optional non-option arguments should be transformed to option arguments that means options should be invented for optional non-option arguments. Therefore I would expect only a fixed number and not a range of non-option arguments. The only exception I could think about is if the last non-option argument is a variable list like e.g. a list of files.

@XSven What about asking for the non-option args like this, and validating the count yourself?
OptionSpec<String> nonOptions =
    parser.nonOptions("nbr key").describedAs("key");

OptionSet options = parser.parse(args);

List<String> values = options.values(nonOptions);
if (values.size() != 1) {
    // fail
}

This seems like a straightforward path to what you want to accomplish, that doesn't over-complicate JOpt Simple's API.
I'm not sure that adding enforced multiplicity of non-option arguments adds enough value to warrant the additional API surface area.

Hi Paul,
my design approach for command-line arguments of a program is the following: I am inventing options with or without option arguments for all the "option"al arguments that I want to pass to my program. I am considering all remaining command-line arguments as mandatory non-option arguments. I thought I could specify these mandatory arguments using the nonOptions() method once per mandatory
argument. My expectation was that the parse() method fails with an OptionException, if one of my mandatory non-option argument is missing.
Now I have browsed the JOpt Simple examples again and it seems that I have misunderstood
something. One example shows the
OptionSpec files = parser.nonOptions().ofType( File.class );
specification. I thought this is a specification of one single mandatory non-option file argument but it's not. I don't want to code around JOpt Simple to meet my expectations. Therfore I was glad to see the Commit you have made to address the issue #17. In the end I am astonished that enforced multiplicity is missing. For me mandatory arguments have the same signifiance as optional arguments (==options).
Kind regards
Sven

@XSven Please have a look at the pull request above and let me know whether this meets your needs. This would go into a 5.1 release. Thanks!

I'm closing this issue -- haven't gotten any feedback regarding the PR, and upon further reflection, I'm not convinced that adding this functionality is a must to have in jopt-simple. If necessary, a programmer can check the cardinality of non-option arguments by hand and raise an exception if violated.

authors: XSven pholser

repo: pholser/jopt-simple


text:
CLI throws EMFILE error

After upgrading to v5.0.0-0.28.1, phonegap serve would throw this error when I connected with a device:
[phonegap] starting app server...
[phonegap] listening on 192.168.16.16:3000
[phonegap]
[phonegap] ctrl-c to stop the server
[phonegap]

events.js:72
        throw er; // Unhandled 'error' event
              ^

Error: EMFILE, open 'path/to/a/file`

I fixed this by following the advice in this blog post.
ulimit -n returned 1024 originally. I set it to 2560 and I'm now able to connect to the server again without it crashing out.
It might be worth exploring https://www.npmjs.com/package/graceful-fs, as suggested in the linked blog post.

Thanks for letting everyone know how to solve this issue @caseypt.
I believe it's related to the gaze module that watches for changed files. Depending on your system's available memory and the project size, the error can appear. Sometimes a system reboot solves it, but increasing the ulimit is the best option.

authors: caseypt mwbrooks

repo: phonegap/phonegap-cli


text:
Cannot get push notifications when I deploy to phone

I've managed to get the plugin working for Android, pretty seamlessly (thanks guys for building it!) but am having a hell of a time getting it working in iOS. I've managed to get the app built and deploy to my phone using xCode but when I send a push notification using Firebase notification console nothing shows up on the phone.
I've turned the "push notification" tab in xCode to on. I have a GoogleService-Info.plist in my working directory and I have code in my controller to handle push notifications (and they're received correctly in the controller in Android).
Could you guys let me know what other common things I might be missing that's preventing me from receiving notifications in app and what strategies I could use to debug this?
Thanks again for building it and maintaining it for the community.

Some extra info in case it's helpful: when I start my app it does successfully ask me for permission to accept push notifications. So I think the plugin is working in some sense. But it's just not seeing the messages from Firebase. I'm guessing some signing issue is happening but I'm not sure where to start looking for how to fix this

I finally figured it out. It was a certificate issue. I'm a part of a dev team and there were several certificates, plus I needed to use the development certificate, then convert it to p12 format to test using Pusher. Many steps later I finally got a push notification to show up on my phone. STill quite amazed how much more convoluted and difficult this is for iOS versus Android. Thanks once again for the plugin guys

As with 80% of the issues on iOS, this was a certificate one... I wish we could aleviate this kind of trouble.

Thanks @fredgalvao ! Yes, I wish this had been much easier. Android took less than an hour. Figuring out iOS took days.
Quick question for you: do you know if I build a release candidate of my Ionic app and sign with a production certificate whether I can use Pusher to test push notifications when I deploy locally to my phone (so I can be sure it's working before submitting to the app store)?
thanks

IIRC (I'm not the one who messes around full-time on iOS on my project), you need to setup your AdHoc certificate/provisioning profile, so that you can "properly sign" for push functionality without using production context.
Other than that I'm as lost as you.

authors: fredgalvao vijayb

repo: phonegap/phonegap-plugin-push


text:
Question: Notification icon color problem

Plugin 2.0.0 with cli-7.1.0
On Android 8.1 the status bar icon is white and getting grey if swiping down.
But on Android 8.0, 7.x  the icon is still the original color.
So on this test i use a material icon:

Sorry to be a jerk but I'm now closing issues that don't follow the issue submission guidelines. This plugin takes a lot of work to maintain and I can't afford the time required to solicit the required info from everyone.
I'm closing this issue but please feel free to re-open the issue if you provide the requested details from the new issue submission guidelines.
https://github.com/phonegap/phonegap-plugin-push/blob/master/.github/ISSUE_TEMPLATE.md

after on device ready:
const push = PushNotification.init({
"android": {
"senderID": "123456789"
},
i also try
"android": {
"senderID": "123456789",
icon: 'icon',
iconColor: 'blue'
},
Android 8.1 on a Nexus 6P the icon is  white in status bar and change color on swiping down.
Android 7.x and 8.0 (Galaxy Note8, S7 etc.)  the color is not changing by swiping down the status bar

On a Note 5 with Android 5.1.1

Maybe the plugin does not distinguish which android version
because each android behaves differently
at this point i can use the status bar icon only safely on android 8.1

I am seeing the same thing on a Galaxy S8 running Oreo.
Expected Behaviour
Icon color in drawer as specfied in init (see sample code).
Actual Behaviour
Correct color shows. Label is in the color specified as color, but the icon is white as shown in screenshot above.
Other notifications do have colored icons. Looks like this changed with Android Oreo.
Reproduce Scenario (including but not limited to)
Receive push notification in background.
Steps to Reproduce

Initialize plugin with color and iconColor
Put app in background
Send push notification to device

Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 8.0.0
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Samsung Galaxy S8
Cordova CLI version and cordova platform version
cordova-cli 8.0.0
cordova-android 6.3.0
Plugin version
phonegap-plugin-push 2.1.2 "PushPlugin"
Sample Push Data Payload
registration_id=e7pPCpffZYA:APA91bHvswOsd6Y_G7AFW29-rjYvBFDT0yETLBtRhowm9u8m-h3d6e7WLY-o_dm7b94MWIxn5h5A3DFE7fAgSpAHSMGj24vY4g4dxAKwBUAETSagNTXvvQf7w-90f-iGPxlCXQ7-XiiV&delay_while_idle=0&data.title=AppName&data.message=test+me
Sample Code that illustrates the problem
PushNotification.init({
    android: {
        icon: 'notify',
        color: '#42B884',
        iconColor: '#42B884'
    },
    ios: {
        alert: true,
        badge: true,
        sound: true
    }
});

Logs taken while reproducing problem
n/a

found the solution - but this will work only a few month
i unspecified the targetsdk so phonegap build usw sdk-26
with targetsdk 25 the notification icon will work properly
but some say that the playstore except only sdk-26 after August

Has anyone found another workaround? Google Play does indeed require API level 26.
FWIW; we’re only getting report of this issue with Samsung devices. Everything is working fine when testing with a Pixel.

I'm also experiencing this issue with targeting to Api 26 thats required from google..
I'v been testing it with Samsung device as @EtienneLem mentioned..
Anyone solved this issue?

I am also having problems with this white icon only - Samsung Galaxy S8
any idea how to solve it?

authors: EtienneLem Marix1 gregor-srdic itsikhar macdonst matthijsbierman


text:
Create a bug where game mouse events do not execute

Description
If you specify the parent div to create the canvas and the div creates the Game during the transform animation, the mouse event will not execute. Mouse events cannot be executed unless you change the width and height of the div or manually change the size of the browser window.（如果指定了创建canvas的父级div，并且这个div在执行transform动画的过程中创建了Game，那么鼠标事件无法执行。除非更改一下div的宽高或者手动更改浏览器窗口的大小，鼠标事件才能执行。）
<!DOCTYPE html>

  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=no"/>

Thank you for taking the time to report this issue. However, I'm afraid I'm going to close it, as in this situation I feel it's well beyond the scope of what Phaser should be responsible for - if you are applying CSS transforms, then it's your responsibility to ensure that Phaser is activated / updated after they have completed.

authors: photonstorm siyuanqiao

repo: photonstorm/phaser


text:
RenderTexture would not update texture size on resize

This PR Fixes a bug
Describe the changes below:
If the texture size is not updated on resize() then the subsequent calls to draw() or drawFrames() will produce a distorted output.

👍

authors: photonstorm yhwh


text:
Print texture key in warning for zero frames

This PR

Adds a new feature

You couldn't tell which texture it was warning about.

👍

authors: photonstorm samme


text:
Update client-common.rst

Missing semicolon

Thanks

authors: cnovak joelwurtz

repo: php-http/documentation


text:
All group members

Hi,
I want to create a command to check if all members inside a group have the name with a specific pattern so I need to have the full memebers list.
How can I achieve this?
Can I only check the newEntry of a group through this library?
Thank you ^^

Bots API does not have any function that would fetch the full members list. You can do that with userbot though (a bot running under regular TG account).
Your best bet would have to make the bot track all the users that enter and exit the group from it's creation.

authors: Shyghar jacklul

repo: php-telegram-bot/core


text:
🛑 phpMyFAQ Password Hash Generator Tool is down

In dd42f8a, phpMyFAQ Password Hash Generator Tool (https://password.phpmyfaq.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: phpMyFAQ Password Hash Generator Tool is back up in 467b5ff.


text:
🛑 phpMyFAQ Demo is down

In 706e9c5, phpMyFAQ Demo (https://demo.phpmyfaq.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: phpMyFAQ Demo is back up in edc9b6e after 9 minutes.


text:
🛑 phpMyFAQ Password Hash Generator Tool is down

In 97c3808, phpMyFAQ Password Hash Generator Tool (https://password.phpmyfaq.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: phpMyFAQ Password Hash Generator Tool is back up in 053b431 after 3 minutes.


text:
🛑 phpMyFAQ Homepage is down

In 8e2c184, phpMyFAQ Homepage (https://www.phpmyfaq.de) was down:

HTTP code: 0
Response time: 0 ms

Resolved: phpMyFAQ Homepage is back up in f526dd8.


text:
Gradle DSL method not found: 'google()'

I got this error in android stuidio.
Gradle DSL method not found: 'google()'

i also got this error .my react-native and gradle versions are:
react-native: 0.35
buildscript {
repositories {
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:2.3.2'
}
}
distributionUrl=https://services.gradle.org/distributions/gradle-3.3-all.zip

repo: phuochau/react-native-thumbnail


text:
split up theorems implying conjunctions of properties

Opening as a proof of concept...

I marked a couple theorems as redundant, there are likely more we could easily identify as redundant with this proposal. Per #232 I used deprecatedBy but had to comment out that data so the tests would pass.

With my experiment editing StackExchange network posts to update URLs, my feelings on preserving URLs have softened somewhat, particularly as we've broken URLs before (search syntax changed at some point) and it wasn't hard to fix those cases.

New theorem numbers were chosen to ensure no conflicts (and to make writing things easier by only needing to change one digit to split T000abc to T001abc or T002abc. I'm not married to these however and can do a full search/replace to update these IDs to be at the end of our current list.
I do think that the issue of bringing together related theorems is a problem that cannot be fully solved by numbering things nicely, at least, not while also promising to avoid renumbering existing things.

I understand that we don't want to renumber existing theorems, but thought it would be good to group new ones together.  Leaving it up to you then.  I'll take a closer look at the contents.

I think the only remaining thing is T04.

I think it's done, but now we should consider compactifying the theorem IDs.

Great.  Let me take one last quick look and I'll approve.

Interesting, I clicked on "Squash and merge" (first time for me) and it shows the text of the combined commit, allowing to change it, like removing the irrelevant intermediate commit descritions, like "fix typos", update specific theorem, etc.  I then clicked on Cancel.  Leaving it up to you, but feel free to trim down the overall commit msg to make the git history easier to read.

Sorry, too late.

authors: StevenClontz prabau

repo: pi-base/data


text:
Discrete implies locally Euclidean

After noticing that the singleton space was deduced as not locally Euclidean (yet no other discrete space was), I decided to not just alter the culprit T171 but also be bold and add a theorem that says that discrete spaces are locally Euclidean. While none of my textbooks seem to say this explicitly, I believe it to be standard practice and I was certainly taught that any countable discrete space is a manifold since $\mathbb R^0$ is the singleton. A citation for this would be an improvement, however. Adding this theorem also obsoletes T84, so I deleted it. I also verified that all other properties currently implied by locally Euclidean already hold for discrete spaces, so no other theorems need to be altered.

Thank you very much for your contribution.  We really appreciate it.
One thing is clear, the definition of Locally Euclidean (https://topology.pi-base.org/properties/P000123) in pi-base was a little sloppy as it did not specify the allowed values for $n$.  At first sight, it seems reasonable to allow $n=0$. I'll look at it in more details later today and give some comments.

We need to clarify the definition of locally Euclidean (https://topology.pi-base.org/properties/P000123).  Can you change the text to "... for some integer $n\ge 0" ?  And also add an explanatory sentence like the following for example:

In the case $n=0$, the point having a neighborhood homeomorphic to $\mathbb R^0=\{0\}$ means it is an isolated point.

IMPORTANT: Note that the way things are phrased, the local dimension $n$ is allowed to vary from point to point.  And hence similarly for what is considered a topological manifold (P124).  There is some discussion of this in https://en.wikipedia.org/wiki/Manifold.  Most sources, but not all, assume a more restrictive definition where $n$ is constant and talk about an "$n$-manifold" for example.  It seems fine to me to keep the more general definition in pi-base, especially for "locally Euclidean" without extra qualifier.  Lee (https://mathscinet.ams.org/mathscinet/relay-station?mr=2766102) uses the terminology "locally Euclidean of dimension $n$", which explicitly specifies the constant dimension.
@StevenClontz Any comments on the above?

T171 [locally Euclidean + multiple points ==> not hyperconnected]: your proposed result is fine.  But I would change the justification slightly.  No need to mention P50 here.  How about something along the lines of: If there is a point with an open nbhd homeo to an open subset of ... with $n\ge 1$, ... (same as before). Otherwise, every point is isolated and the space is discrete.  But there are at least two points, so ...

T434: typo: "is an open ..." --> "has an open ..."

T435: not valid given (1) above

T84 [discrete ==> locally arc connected] can be removed as it follows from the new T171 and T82 [locally Euclidean ==> locally arc connected].  But it seems it would be useful to add to T82 part of the justification that used to be in T84.  Something like this for example:

Note that in the case $n=0$ the point $x$ is isolated and its open neighborhood $\{x\}$ is vacuously {P38} by definition.

FYI Lee (mentioned above) explicitly allows $n=0$ in various definitions and mentions the connection with discrete spaces, but it also makes the dimension explicitly constant.  If we wanted a reference, one could possibly add https://en.wikipedia.org/wiki/Manifold as a background reference for https://topology.pi-base.org/properties/P000123, which does mention the case $n=0$ in passing and talks about non-constant dimension in general.

Thanks for the suggestions! I did notice that detail about how, as locally Euclidean was worded, the dimension was permitted to vary, but I suppose I dismissed it as ambiguous in favor of the more common version. Using a more general definition sounds perfectly fine though. Mostly I'm glad to be clarifying the definition given, whatever it ends up being.

@StevenClontz So it does not fall through the cracks, when you get the chance, we'd appreciate your input on the above, specifically the definition of Locally Euclidean.

https://en.wikipedia.org/wiki/Wikipedia:Be_bold

😁 love it - thanks for your time making a contribution @danflapjax !
And thanks for the ping @prabau - these are all in the queue but I added some last-minute travel this weekend. Will put some time on this particular PR right now.

Okay, right now the biggest blocker for this PR is editing https://topology.pi-base.org/properties/P000123 to clearly state what we're assuming here.
I think it seems clear that we should allow $n\geq 0$, so the proposed fix (replacing non-empty with multiple points) is important.
What's less clear is whether we should be fixing the dimension $n$ at the space level, or point level. I'd like to give preference to a contributor that's more likely to use the definition than myself. (We can always add the other property later if it's needed.) So I think it's your call @danflapjax - the only requirement I'd make is that we want a reasonable citation to the literature that aligns with your call. Can you update the PR to include appropriate edits to P123, adding the citation?
Aside: we should probably add "manifold" as an alias to P123.

For both "locally Euclidean" and "topological manifold" there could be two terminologies, one without qualifier:

"locally Euclidean"
"manifold"

and one with qualifier specifying the dimension up front:

"locally Euclidean of dimension $n$" (as used in Lee for example)
"$n$-manifold" (as in Munkres p. 225 for example)
"$n$-dimensional topological manifold", "$n$-dimensional manifold", "$n$-manifold" (all in Lee p. 39)

"locally Euclidean" without qualifier would mean no specific dimension specified (and the local dimension can vary from point to point).  But given a space $X$ that is locally Euclidean in this sense, for example a "manifold", each of its subsets $X_n$ of points with local dimension $n$ is open, and $X$ is the topological direct sum of the $X_n$.  So we don't lose anything essential by restricting ourselves to cases where the dimension is fixed up front.
But in that case, we should change the names slightly to make that clear.  For example:

"topological $n$-manifold"
"locally $n$-Euclidean"

The $n$ is understood to be fixed up front, so constant over the whole space.
I would be in favor of this change where the dimension is constant everywhere.  But the names also need to be changed accordingly.
In addition:

not add "Manifold" as an alias for "locally Euclidean"
for Topological manifold (https://topology.pi-base.org/properties/P000124), change "A locally Euclidean space that is Hausdorff and second-countable" to "A {P123} space that is {P3} and {P27}".  That will make it easier to navigate to the relevant properties from that page.
P124: also fix the page for Munkres (it's page 225 and not 316).
Add Lee to the refs for locally $n$-Euclidean
Add Lee to the refs for topological manifold
Add https://en.wikipedia.org/wiki/Manifold to the refs for topological manifold

What do you guys think?

Thanks @prabau - I missed the second-countable requirement for a manifold due to the wording of that wiki article. (Actually I just made an edit to the first paragraph on Wikipedia to be clear that the local Euclidean property is necessary but not sufficient.)
I'm okay with any of the following (modulo all of @prabau's suggestions e.g. adding citations):

Leave P124 as "topological manifold" and P123 as "locally Euclidean", and clarify that the dimension can vary at each point.
Rename P123 as "topological $n$-manifold" and P123 as "locally $n$-Euclidean", and clarify that the dimension must be the same across the space.
Add "topological $n$-manifold" and "locally $n$-Euclidean" as new properites, and make all the necessary clarifications on all four properties.

Which of the three is up to @danflapjax if they're still interested and can update the PR appropriately in the next week. If not, it can be up to whoever gets around to putting a bow on this first. :-)

Actually I just made an edit to the first paragraph on Wikipedia to be clear that the local Euclidean property is necessary but not sufficient

and of course it was reverted 🙄

Implemented as #539, thanks again @danflapjax!

Thanks @danflapjax for the improvement to pi-base.  Feel free to share other contributions in the future or mention things that should be fixed.  We appreciate it.

authors: StevenClontz danflapjax prabau


text:
🛑 YSF REF is down

In b57009d, YSF REF (https://ysf.freedmr.it) was down:

HTTP code: 500
Response time: 764 ms

Resolved: YSF REF is back up in a3441a9 after 27 minutes.

repo: picchiosat/HBLink-Uptime


text:
feat(task):dashboard ui card with table set state from redux

dashboard ui
dashboard state with redux
change init task id to unixtime

LGTM!

repo: pichead/nextjs-todo-redux


text:
Add states support to search input with rtl support

Added some styles into _form-alt-input-types.scss and some docs into the forms.html to cover states with rtl support.
Before: https://codepen.io/hayatbiralem/pen/VwrJZva?editors=0100
After: https://codepen.io/hayatbiralem/pen/KKyjpeJ?editors=0100
Fixes #173

Thank you, @hayatbiralem.
Your PR is very helpful. I will merge it the the dev branch. It will be shipped in the next release.
I made some changes:

Simplified CSS code with padding-inline-start.
IE does not support it, but we already use *-inline-start in several places anyway for lightness and maintainability.
Simplified example in the docs

For consistency with the other input types, because otherwise, it would be necessary to add complete examples for all the fields.
For simpler and lighter documentation.

Note: We'll have a complete example for RTL - as soon as I take the time to do the PR review.
https://github.com/picocss/examples/pull/5

authors: hayatbiralem lucaslarroche

repo: picocss/pico


text:
TC08 short pointers?

Just a quick question because I'm unsure of how the driver is implemented below the wrapper: the C# wrapper for the TC08 uses a short as a file handle, but wouldn't an IntPtr or SafeHandle be what a .NET developer would expect to see?

Hi @InvisibleWaves, thanks for your question. The driver uses a signed 16-bit integer for the handle parameter so we have used a short. Here is the definition from the C header file for the driver:
PREF0 PREF1 int16_t PREF2 PREF3(usb_tc08_open_unit) (   void );
You could use short or Int16.
Hope this helps.

authors: InvisibleWaves hsmistry

repo: picotech/picosdk-c-sharp-examples

license: ISC


text:
Add an About dialog

We should add an About dialog under Help -> About that shows the current version of PicoTorrent, along with the Git commitish, build date and contributor information.

It would be nice with license information as well.

authors: patriksvensson vktr

repo: picotorrent/picotorrent


text:
🛑 Blog URL is down

In 3048693, Blog URL (http://blog.pik.farm) was down:

HTTP code: 429
Response time: 159 ms

Resolved: Blog URL is back up in a5a37c6.

repo: pikfarm/PikfarmStatus


text:
🛑 Stripe Test Endpoint URL is down

In 246b2d6, Stripe Test Endpoint URL ($STRIPETESTAPI) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Stripe Test Endpoint URL is back up in 9bbb6e0 after 18 minutes.


text:
🛑 Stripe Endpoint URL is down

In 31940c7, Stripe Endpoint URL ($STRIPEAPI) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Stripe Endpoint URL is back up in 752e961 after 46 minutes.


text:
🛑 Stripe Endpoint URL is down

In 84abf35, Stripe Endpoint URL ($STRIPEAPI) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Stripe Endpoint URL is back up in 44c013d after 1 hour, 9 minutes.


text:
websdk连接到七牛云房间服务器的websocket断开了，close后会自动重连吗？

一定要刷新页面，再重新进入房间吗？

因为网络原因signal断了SDK会尝试重连，不需要刷新页面。
收到 disconnect code 10004 时可以尝试重新走 joinRoom 逻辑
参考文档：
https://doc.qnsdk.com/rtn/web/docs/api_track_mode_session#22_6

那如果连接断开前我监听了各种事件，在sdk重连过程中，其他用户发布流取消发布流的这些事件，会不会在重连成功后监听到呢？同理，在重连超时后再次joinRoomWithToken又会如何呢？

sdk重连后房间的变化连成功后能监听到。
disconnect触发之后（包括重连超时）会释放房间的所有信息，之后再 joinRoom 和上一次 joinRoom 没啥联系

简单来说，websocket 断开有 2 种状态：

断开后 SDK 会自动尝试重连，此时处于重连状态，可以通过 room-state-change 这个事件感知
之后如果 SDK 重连失败（超时或者其他原因），会抛出 disconnect ，此时房间已经处于不可恢复的断开状态了，SDK 会清空释放整个房间（但是你的事件监听不会被释放）

所以如果你在超时后再次重新 joinRoom 是没有问题的，事实上 Demo 也是这么做的

简单来说，websocket 断开有 2 种状态：

断开后 SDK 会自动尝试重连，此时处于重连状态，可以通过 room-state-change 这个事件感知
之后如果 SDK 重连失败（超时或者其他原因），会抛出 disconnect ，此时房间已经处于不可恢复的断开状态了，SDK 会清空释放整个房间（但是你的事件监听不会被释放）

所以如果你在超时后再次重新 joinRoom 是没有问题的，事实上 Demo 也是这么做的

第二种情况，监听事件一直不会被释放吗？还是监听到disconnect事件后执行完回调函数后再释放监听事件？

房间对象的监听事件除非用户手动调用 off/removeAllListeners 之类的方法释放，否则 SDK 是不会释放的。

okk, 谢谢两位大佬。

authors: cuyl disoul qugemingzizhenmafan

repo: pili-engineering/QNRTC-Web


text:
Crash on start

When I start the app, it immediately crashes again.
Pixel 2XL
Android 12
19-20220612-microG-taimen
com.pilot51.voicenotify Version 1.2.0

Did you update an existing installation? If so and if you don't mind losing your settings, could you go to the Voice Notify app info in Android settings and clear data and try launching the app again?

I have the same problem with a new install of the latest version from F-Droid on two devices.
Moto G8 Plus. Android 10 (stock ROM)
Samsung Galaxy Tab S2. Android 10 (custom ROM)

I have reinstalled it.
I just tried the old version. It seems to work.
With the current version, I have now discovered an error message when I start it:
Error: text-to-speech could not be initialised.

Sounds like a duplicate of #80 which I've been unable to reproduce in emulators or my Moto x4 with Android 9.
v1.2.0 is basically to get something out the door and republish it on Google Play (which has been in review for the last 5 days). Far from perfect but I hope it gets the ball rolling on this whole motivation thing.

Here's a logcat extract from my Moto G8 Plus if it helps:
https://pastebin.com/QMBv6M6N

Thanks, logcats are definitely helpful!
Appears to be caused by an NPE at Common:63.
Evidently I wasn't thinking when I converted that function to Kotlin. No idea why I expected that preference to never be null.
I'll fix it probably Friday evening or Saturday (when I have time outside of work).

authors: pilot51 tibbsbrookside toas-koas


text:
Voice notify turns itself on by itself

I haven't figured out when it happens yet, but voice notify definitely turns itself on by itself every once in a while. It wasn't a problem back when the permission was handled by android, which makes sense, but it has been since the "suspended" feature was added.

I could use more information to reproduce. Could you give a ballpark for how often "every once in a while" is? If you could figure out what triggers it, that would be a huge help.
The suspend feature was added in 2013 with commit 46cd6e1, so I doubt that has anything to do with it.
Do you mean it wasn't a problem when permissions were requested at install instead of runtime? That was done in early 2022 with commit 870b1a3 because the old way was deprecated. A whole bunch of other behind-the-scenes changes happened with that release (v1.2.0), so I'm not surprised if the regression happened somewhere in that mess.


text:
Proposal: replace all linear algebra code with linalg.h

I recommend replacing all linear algebra code with this header:
https://github.com/sgorsten/linalg
It is public domain and very complete. It is all implemented using templates so it supports any type.
For example using linalg.h, vec2.hpp can be completely replaced by the following:
#include <linalg.h>
typedef linalg::vec<float, 2> vec2;

and perhaps a few syntactic changes where vec2 is used.

We’ve a few reservations about replacing the existing code with template-driven functions, since:

they make it harder to predict what impact code might have on the binary size
templates make for some of the most opaque and confusing C++ errors for beginners
it’s too easy to do something unintentional like accidentally leak doubles all over the codebase - the template will handle this gracefully and slow down the code
relying on a third party library may close the door to future blit-specific use of SIMD or FPU instructions for optimisation

Writing our own functions may seem bonkers, but it makes the API simpler and more suited to Blit’s original target- a limited embedded system.
We’ll definitely look over this to find gaps in our API- and encourage anyone advanced enough to use this library in lieu of ours.
There are good cases for the use of this library to be sure- but I don’t think it aligns with our intentions for the Blit API at the moment.

I'm not really convinced by any of these reasons.

Code size will be unaffected because everything is inline in both cases, but use of constexpr will probably end up reducing code size since more can be calculated at compile time.

Templates have the same promotion rules as regular code, but use of explicit makes it more strict than the current implementation. Either way, there is no way to accidentally promote a vector type and the templated functions won't let you mix them. This won't compile:

linalg::vec<float, 3> v;
linalg::mul(v, 3.0);

But this will:
linalg::vec<float, 3> v;
linalg::mul(v, 3.0f);

FPU will be used automatically by the standard library when compiling with -ffast-math -fno-math-errno and Cortex M7 has no float SIMD.

Filling in the gaps of the current implementation will be quite a task because there is so much missing from it. You'll either end up with the same thing, or 96 overloaded versions of the same thing if you try to do it without templates.

That just leaves the error message problem, but that is just the nature of C++ and I don't think there is anything you can do about that.


text:
Get block cache usage size

Get block cache usage size.
crocksdb_get_options  not return rocksdb::Options for default cf but return rocksdb::DBOptions, so we implement get_options by get_options_cf.
@siddontang @BusyJay PTAL

@BusyJay PTAL

@BusyJay PTAL

@hhkbp2 PTAL

Rest LGTM

PTAL @hhkbp2

LGTM

repo: pingcap/rust-rocksdb


text:
backend/local: do not retry epochNotMatch error when ingest sst

What problem does this PR solve?

add retry for SplitAndScatterRegionByRanges since it may caused by region leader changes
do not directly retry ingest if the return error is EpochNotMatch because tikv will check the epoch in SstMeta and the newest Region info, but we can change the epoch in SstMeta
retry ingest if the error is Raft raft: proposal dropped, because this means there is a leader transfer for this region
downgrade some log level from Error to Warn, since they are retryable
fix a bug in backend/log that cause scan region by range return one more region that does not intersect with the range  if the range end key is prefix of the region start key

What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects
Related changes
Release Note

fix several trivial bugs when ingesting sst files in local backend

Please add release note.

/run-all-tests

authors: glorv overvenus

repo: pingcap/tidb-lightning


text:
Fix some issues on S3

What problem does this PR solve?
Issue Number: ref #6827
Problem Summary: When config s3.root as '/', listPrefix alway return empty when deployed with AWS S3.
What is changed and how it works?

Don't prepend s3.root to prefix when it is '/';
Specify ingest range in ingestSegmentDataIntoSegmentUsingSplit;
Fix unstable test;

Check List
Tests

[ ] Unit test
[ ] Integration test
[x] Manual test (add detailed scripts or steps below)

deploy a cluster on AWS and config s3.root as '/', then check in the log whether the listPrefix works normally.

[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-integration-test

/merge

/hold

/unhold

/run-unit-test

authors: JaySon-Huang Lloyd-Pottiger lidezhu

repo: pingcap/tiflash


text:
WIP network(engine): return network usage by GetJob

What problem does this PR solve?

Issue Number: close #xxx
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

/run-engine-integration-test

/run-engine-integration-test

Codecov Report

Merging #7776 (8f0443a) into master (b0f5a0b) will increase coverage by 5.0149%.
The diff coverage is 50.8620%.

:exclamation: Current head 8f0443a differs from pull request most recent head 76d7fdd. Consider uploading reports for the commit 76d7fdd to get more accurate results

Additional details and impacted files

Flag
Coverage Δ

dm
52.3438% <82.3529%> (+0.1968%)
:arrow_up:

engine
64.3136% <100.0000%> (+0.0291%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #7776        +/-   ##
================================================
+ Coverage   55.0067%   60.0217%   +5.0149%
================================================
  Files           415        812       +397
  Lines         52739      93926     +41187
================================================
+ Hits          29010      56376     +27366
- Misses        20957      32659     +11702
- Partials       2772       4891      +2119

/run-engine-integration-test

/run-engine-integration-test

/run-engine-integration-test

/cc @lance6716 @maxshuang @GMHDBJD

Rest LGTM.

/run-verify

/merge

/run-all-tests

/run-all-tests

/run-verify

authors: buchuitoudegou codecov-commenter lance6716 maxshuang

repo: pingcap/tiflow


text:
txn execution(Write-Write conflict case) slows down after refactoring scheduler

The test is https://github.com/pingcap/tidb/blob/master/store/tikv/isolation_test.go#L93
It took <10s before while 40s+ after refactor.

Didn't re-produce it after the branch been merged to master, so close it.

repo: pingcap/tikv


text:
coprocessor, dag: add IfJson, IfNullJson signature and some flags.

Add two signatures: IfJson and IfNullJson. And use some new flags instead of Decimal to pass extra information about Json fields.

LGTM

authors: BusyJay hicqu


text:
util: add file name and line number for box error

So we can inspect what causes the problem instead of seeing a context-less error.

@wentaoxu @zhangjinpeng1987 please make sure that tidb-client doesn't depend on the format of error message.

LGTM, ticlient only rely on the error message like this strings.Contains(err.Error(), "try again later"), I think this is not related.

LGTM

/run-integration-tests

authors: BusyJay siddontang wentaoxu


text:
BatchWrite: update multi-table api

What problem does this PR solve?
update multi-table api: TiContext -> SparkSession
What is changed and how it works?
val df1 = spark.sql(s"select * from $inputTable1")
val df2 = spark.sql(s"select * from $inputTable2")

val data = Map(DBTable(outputDatabase, outputTable1) -> df1, DBTable(outputDatabase, outputTable2) -> df2)

// writing data to multi-tables
TiBatchWrite.write(
  data,
  spark,
  Map(
    "tidb.addr" -> "127.0.0.1",
    "tidb.port" -> "4000",
    "tidb.user"-> "root",
    "tidb.password" -> "")

/run-all-tests tikv=v3.0.14 tidb=v3.0.14 pd=v3.0.14

/run-all-tests tikv=v3.0.14 tidb=v3.0.14 pd=v3.0.14

/run-all-tests tikv=v3.0.14 tidb=v3.0.14 pd=v3.0.14

repo: pingcap/tispark


text:
🛑 pinkstrings.synology.me is down

In 508fc85, pinkstrings.synology.me (https://pinkstrings.synology.me:5001) was down:

HTTP code: 0
Response time: 0 ms

Resolved: pinkstrings.synology.me is back up in 74258ba.

repo: pinkstrings/upptime


text:
Tooltip: Disable forcus trap

Summary
There was an overlooked case during Floating-UI integration. Tooltip didn't need FloatingFocusManager. Tooltip is not an accessible component.
Default values of new props hideWhenReferenceHidden and disableFocusTrap are now passed at the component props level. Previously the defaults set at Contents component level. This change makes it more obvious how the components behave. The default value now also displayed in the docs.
For the context, this is the table of components classified by accessiblity features:

Checklist

[ ] Added unit and Flow Tests
[ ] Added documentation + accessibility tests
[ ] Verified accessibility: keyboard & screen reader interaction
[ ] Checked dark mode, responsiveness, and right-to-left support
[ ] Checked stakeholder feedback (e.g. Gestalt designers, relevant feature teams)

For context
https://github.com/pinterest/gestalt/assets/10593890/e2e2e16c-66c5-4c4c-8f8e-6dc9a4be8585

authors: AlbertCarreras diyorbek

repo: pinterest/gestalt


text:
Support per-record headers

Kafka 0.11.0.0 supports per-record headers.
This is a two-fold request:

Save the additional header metadata.
Use the header metadata to filter which messages to save.

This is probably a useful feature.  Do you have a proposal on how to support the optional header fields?

authors: HenryCaiHaiying chonton

repo: pinterest/secor


text:
Looks like OstrichAdminService is looking for build.properties in com…

…/pinterest/
secor/common/monitoring folder.
So create files in that folder

Landed.


text:
Link should not end with an equal sign

Hello,
I know its not really an snappass problem, but when sending links via Microsoft Outlook 2016 (don't know if other versions are affected) the html link will ignore the = at the end of the http link. So the recipient needs to copy the link manually:

I'm also bumping into this problem. What workarounds are people using?

From this question on stack overflow, it looks like replacing the equal sign with the escaped equivalent %3D should do the trick.
http://example.com/service/access=12snssamhsdh%3D

authors: Stephan1984 bryanpost nichochar

repo: pinterest/snappass


text:
Allow use of REDIS_URL env var

If present, REDIS_URL is used instead of REDIS_HOST, REDIS_PORT, and SNAPPASS_REDIS_DB to configure the Redis client object.
Document this new env var in the README

Addresses #28
I have used this change, along with adding gunicorn to requirements.txt and adding a Procfile, to successfully deploy snappass to Heroku (which supplies a REDIS_URL env var) for personal use. The latter changes are perhaps too specialized to warrant a PR, but I agree that handling REDIS_URL would be of general use.

LGTM!

LGTM, thanks for the PR @dwinston

authors: dwinston jparise nichochar


text:
Increased log level for deploy_board.webapp.security

99% of production log is generated by logger.debug("Redirect oauth for authentication!, url = " + url).
Increased the log level to INFO and bumped other log points to INFO.

Verified that the log was gone.

repo: pinterest/teletraan


text:
Cleanups

I've spent some time auditing the code base for gaining a better understanding.
Here are a few cleanups and refactorings.
The PR includes no functional changes.

@cnderrauber Do you mind reviewing this PR?

Really great changes @stv0g. Really inspired by your work on this. Working on older code bases is hard, and you are making it look easy. Great to see the refactoring/typo clean ups.
In a few cases the changes seem subjective (you have a naming scheme you prefer vs others). Unless we create tooling that makes the new way official I would caution against changes like that.
In the future someone will just come and make the changes back to the way it was before.

This is my reasoning around some changes. I don't feel strongly around any of these, but I think worth discussing
* raddr -> rAddr - Makes it more readable with casing. Like that change!
* srcAddr -> sAddr - I think it makes the code harder to understand. `src` is more self explanatory then `s`
* buffer -> buff, muxs -> muxes - Neutral change. The churn on the code does make it harder to bisect in the future though.

Hi @Sean-Der,
thanks a lot for your quick feedback :) I really appreciate it. I know its a lot of noise for a maintainer of such a big project.
Let me explain my reasoning for some of the changed variable names. Similarly to you, I don't feel strongly about any of those.
However, something I value is consistency which was also one of the main motivation for these changes.
And it triggers my OCD (which is probably a good thing for open-source projects.. So I am happy to tidy up the code-base :D)

srcAddr -> sAddr - I think it makes the code harder to understand. src is more self explanatory then s

Agreed. I will change it to srcAddr.

raddr -> rAddr - Makes it more readable with casing. Like that change!

To satisfy my demand for consistency, I thought about naming it remAddr. However, I disliked it and went for the shorter rAddr. Hence, for consistency reasons also for sAddr. Yeah, sorry I know its nitpicking. But I am also happy with srcAddr / rAddr..

In a few cases the changes seem subjective (you have a naming scheme you prefer vs others).
Unless we create tooling that makes the new way official I would caution against changes like that.

Yes that is a good point. In my case the tooling is a spell checker extension for VSCode which complains about capitalizations like portmin but succeeds to check camel case wording like portMin.
We could probably add a spell checker into the CI pipeline, however I think it would produce a lot of false positives and demotivate contributors which are annoyed by failing CI checks.
(E.g. The commit message linter is another example of such an annoyance in my opinion.. Maybe it just takes a bit to get used to it.. But I see almost all first-time contributors stumble over it..)
And another good tool for refactoring code like this is the Go VSCode extension as it makes it really easy to perform project wide refactorings and helps a lot with which code navigation.

@Sean-Der I think I addressed all your comments.
Let me know, if you want me to change something else 😃

I think this is great, thanks @stv0g !
Keep these changes coming :) I like the nitpicking, no one wants nits!

repo: pion/ice


text:
The track of the client frequently corresponds to onended events

Your environment.

Version: v2.1.16
Browser: chrome
Other Information
I used pion to implement the janus server of the go, and the OnTrack implementation is as follows:

peerConnection.OnTrack(func(track *webrtc.Track, receiver *webrtc.RTPReceiver) {
		go func() {
			ticker := time.NewTicker(time.Second * 3)
			for range ticker.C {
				err := peerConnection.WriteRTCP([]rtcp.Packet{&rtcp.PictureLossIndication{MediaSSRC: track.SSRC()}})
				if err != nil {
					log.Err(err).Msg("VIDEOCALL, called write rtcp error")
					return
				}
			}
		}()

		var trackTemp *webrtc.Track
		if track.PayloadType() == called.offerVideoCode.PayloadType {
			trackTemp = called.videoTrack
		} else if track.PayloadType() == called.offerAudioCode.PayloadType {
			trackTemp = called.audioTrack
		} else {
			return
		}

		for {
			rtp, err := track.ReadRTP()
			if err != nil {
				log.Err(err).Msg("VIDEOCALL, calling read RTP error")
				return
			}
			rtp.SSRC = trackTemp.SSRC()
			if writeErr := trackTemp.WriteRTP(rtp); writeErr != nil {
				log.Err(err).Msg("VIDEOCALL, calling read RTP error")
				return
			}
		}
	})

My question：The client alternates the corresponding track.onended and track.onunmute events，
event.track.onended = function(ev) {
	Janus.log("Remote track muted/removed:", ev);
	if(config.remoteStream) {
		config.remoteStream.removeTrack(ev.target);
		pluginHandle.onremotestream(config.remoteStream);
	}
};
event.track.onmute = event.track.onended;
event.track.onunmute = function(ev) {
	Janus.log("Remote track flowing again:", ev);
	try {
		config.remoteStream.addTrack(ev.target);
		pluginHandle.onremotestream(config.remoteStream);
	} catch(e) {
		Janus.error(e);
	};
};

What did you do?
I don't know if this is a BUG, how should I solve it? thank you!!
What did you expect?
What happened?

Closing for inactivity.
If you have questions I am available here or on Slack
thanks!

repo: pion/webrtc


text:
fix link to github :P

fix the link to the github rn its a 404 :)
Description
Reference issue
Fixes #...

Thank you so much @puppycodes
We just changed about 30 mins ago, good catch :)

authors: Sean-Der puppycodes

repo: pion/website


text:
Run missing go mod update

What this PR does / why we need it:
Which issue(s) this PR fixes:
Follow PR https://github.com/pipe-cd/pipecd/pull/4355
Does this PR introduce a user-facing change?:
NONE

Merge this change with upgrade go version to 1.20.5

repo: pipe-cd/pipecd


text:
suggestion: button bound onClick event

Mail 和 MailOpen 图标可以分别绑定 onClick readMail 和 unreadMail 事件
https://github.com/pipijoe/xryder-web/blob/main/src/page/mailbox/index.tsx

没有理解你的意思，能否给个代码示例？

就是邮件页面中的与只是一个是否已读的指示并没有具体的功能
我是这样解决的，但是后端或许需要编写相应的unread接口
                                            {selectedMail?.id === mail.id && mail.hasRead ? (
                                                <MailOpen className="h-4 w-4 text-muted-foreground" onClick={() => {
                                                    unreadMail({id: mail.id});
                                                    mail.hasRead = false;
                                                }}/>
                                            ) : (
                                                <Mail className="h-4 w-4 text-blue-500" onClick={() => {
                                                    readMail({id: mail.id});
                                                    mail.hasRead = true;
                                                }}/>
                                            )}

            unreadMail: async (params) => {
                set({error: null});
                try {
                    const data = await api.put('/mails/' + params.id +'/unread');
                    if (data.data.code === 1) {
                        set((state) => ({
                            mails: state.mails.map(m => m.id === params.id ? {...m, hasRead: false} : m),
                            account: {...state.account, newMails: state.account.newMails +1 }
                        }));
                    }
                } catch (error) {
                    if (error instanceof Error) {
                        set({error: error.message});
                    }
                }
            },

这个收件箱的设计思路是，收到的邮件默认都是未读状态，当第一次点击后会变成已读（更新数据库邮件状态）。邮件的2个图标根据返回的邮件状态是否为已读来显示。 @Pleasurecruise

authors: Pleasurecruise pipijoe

repo: pipijoe/xryder-web


text:
Multi-API Keys

I'm wondering how I can set multiple API keys in .env.wtfis

Hi @k0da101 , do you mean multiple keys for the same service? It's not supported at the moment. What use case do you have in mind?

I signed up for the same service with multiple accounts, so I have multiple API keys, and I thought to use them all

Going to consider this an enhancement, but it will probably take me a while to get to this one. Thanks for the suggestion!

repo: pirxthepilot/wtfis


text:
Fix for announce_route.erb

By default cURL seems to wait indefinitely for the reply,
resulting in an unreachable API.

This won't run through CI until we merge https://github.com/pivotal-cf-experimental/kubo-deployment/pull/113

authors: jhvhs pivotal-jwinters

repo: pivotal-cf-experimental/kubo-release


text:
Add a quota system

Currency system for database privileges, e.g. grants with a quotum on the maximum number of times they are used, and/or the number of bytes stored, etc.

Miners would receive quotum which they can then trade to other users. Additionally quotum can be 'pre-mined' in the configuration block (block 1).

See #30, incentives table.

repo: pixelspark/catena


text:
Multiply Full Shader Missing b_ on dest, src

https://github.com/pixijs/pixi-picture/blob/1ee67f1a9c34f82f468a37e29381679c1013506c/src/ShaderParts.ts#L117
This is causing the compilation to fail.
pixi.js:18380 precision mediump float;
#define SHADER_NAME pixi-shader-8
varying vec2 vTextureCoord;

uniform sampler2D uSampler;
uniform sampler2D uBackdrop;

void main(void)
{
   vec4 b_src = texture2D(uSampler, vTextureCoord);
   vec4 b_dest = texture2D(uBackdrop, vTextureCoord);
   vec4 b_res = b_dest;

   if (dest.a > 0.0) {
   b_res.rgb = (dest.rgb / dest.a) * ((1.0 - src.a) + src.rgb);
   b_res.a = min(src.a + dest.a - src.a * dest.a, 1.0);
   b_res.rgb *= mult.a;
}

   gl_FragColor = b_res;
}

Here's the errors:
compileProgram @ pixi.js:18380
pixi.js:18381 ERROR: 0:16: 'dest' : undeclared identifier
ERROR: 0:16: 'a' :  field selection requires structure or vector on left hand side
ERROR: 0:17: 'dest' : undeclared identifier
ERROR: 0:17: 'rgb' :  field selection requires structure or vector on left hand side
ERROR: 0:17: 'dest' : undeclared identifier
ERROR: 0:17: 'a' :  field selection requires structure or vector on left hand side
WARNING: 0:17: '/' : Zero divided by zero during constant folding generated NaN
ERROR: 0:17: 'src' : undeclared identifier
ERROR: 0:17: 'a' :  field selection requires structure or vector on left hand side
ERROR: 0:17: 'src' : undeclared identifier
ERROR: 0:17: 'rgb' :  field selection requires structure or vector on left hand side
ERROR: 0:17: '=' : dimension mismatch
ERROR: 0:17: 'assign' : cannot convert from 'const highp float' to 'mediump 3-component vector of float'
ERROR: 0:18: 'src' : undeclared identifier
ERROR: 0:18: 'a' :  field selection requires structure or vector on left hand side
ERROR: 0:18: 'dest' : undeclared identifier
ERROR: 0:18: 'a' :  field selection requires structure or vector on left hand side
ERROR: 0:18: 'src' : undeclared identifier
ERROR: 0:18: 'a' :  field selection requires structure or vector on left hand side
ERROR: 0:18: 'dest' : undeclared identifier
ERROR: 0:18: 'a' :  field selection requires structure or vector on left hand side
ERROR: 0:19: 'mult' : undeclared identifier
ERROR: 0:19: 'a' :  field selection requires structure or vector on left hand side

I didnt test that multiply , just copied from private fork of pixi. Thanks for noticing that. I'll make PR tomorrow, or you can make it :)

btw, that MULTIPLY is supposed to work the same way it works in flash - transparent multiplied by image gives the same image, not black version of image

I think @ivanpopelyshev recently fixed MULTIPLY again.

authors: ShukantPal ivanpopelyshev kins-dev

repo: pixijs/pixi-picture


text:
Demos not working

Browser's throwing:
main.js:104 Uncaught TypeError: Cannot read property 'flush' of undefined
at update (main.js:104)
update @ main.js:104
I use Chrome

Thank you ! The thing is, I use this demo with "pixijs.download/dev/pixi.js" which is latest dev. It means guys broke something in dev again. It should work if you copy the demo and use with latest stable :)
I'll look what did they break today or tomorrow.

Oh, its broken only for Canvas2d mode.

This is an old ticket, so I'm not sure if the demos have been fixed since the initial posting, but looks like they are broken again (or still!).

Adding visibility

Adding visibility ^2

authors: ivanpopelyshev jamespohalloran m0dE madroneropaulo psyfreak

repo: pixijs/tilemap


text:
[BUG] signature not found after restarting my computer 2 times

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
i restarted 2 times and signature not found is fixed are there any more solution?

No, there's nothing more I can tell you other than what was stated in the Wiki page.

authors: pizzaboxer relasdas

repo: pizzaboxer/bloxstrap


text:
React native version update issue

Hi,
Library was working fine . But when upgraded the react native version to "0.60.1"  suddenly it stopped working. Please help me to fix it
Arun

Hi, can you provide some more information? Any traces?

It's working without any issues in 0.60.1 and 0.61.2

authors: arunkrishnang86 iamchathu pladaria

repo: pladaria/reconnecting-websocket


text:
Support no_std environments that can't ship an allocator

I'm working on some rust firmware and we are considering the use of flatbuffers. I know that the official flatc requires alloc. However, we  are targetting devices that don't have enough flash space for that.
Is there any interest in having the ability to use something like heapless::Vec in planus? Its a bit of a stretch but I thought I would ask.

Yes, there is definitely interest! I'd even go as far as say that it was one of the original motivations for creating planus.
I think the deserialize code should already work fine without alloc. The serialize code so probably need some work, since the API doesn't support failing allocations.
Perhaps it would be good enough to put the error handling as a field on the builder instead of returning a Result?

as a field on the builder

Not sure what you meant by that 👀

I am considering the problem of how to check for errors while serializing. Ideally a builder that could fail would have an API like this:
fn build_table(builder: &mut planus::Builder) -> Result<planus::Offset<MyTable>> {
    let offset = MyTable::builder().field_a(17).finish(&mut builder)?;
    Ok(offset)
}

However for builders that cannot fail, having to do error handling for non-existing errors is annoying. We could probably solve this with generic associated types, if we were willing to wait until we can bump our MSRV to rust 1.65.
Alternatively we could change the API slightly to look like this:
fn build_table(builder: &mut planus::Builder) -> Result<planus::Offset<MyTable>> {
    let offset = MyTable::builder().field_a(17).finish(&mut builder);
    builder.check_for_errors()?;
    Ok(offset)
}

I would opt for the first one over the second, I don't find the second's flow of errors to be idiomatic.
I'm in no rush, I would suggest waiting until GATs if you have features from there you need

authors: TethysSvensson TheButlah

repo: planus-org/planus


text:
Failing test case for boxing with full args support

This commit f6a3e26 contains a test case that fails with some improper interaction between boxing and arguments instrumentation. It's pulled from the 220-Aug22 branch, I need to investigate what's going on more.

This is actually fixed already. PR #410 pulls in the test case to the test suite.

repo: plasma-umass/Stopify


text:
Looking for a feature and how it works

I have found the following message in an issue :
https://github.com/plataformatec/devise/issues/1285#issuecomment-2530297
I would like to be able to have two different controllers for the same user model (normal login and doorkeeper login) but I do not know how this feature work. Where can I find explanations about it, or an example?

@bsylvain You may want to take a look at devise-doorkeeper gem or the doorkeeper devise wki.
Please use the mailing list or StackOverflow for questions/help, where a wider community will be able to help you. We reserve the issues tracker for issues only.

authors: bsylvain ulissesalmeida

repo: plataformatec/devise


text:
Just to share a heading/title capitalization rule according to some English academic writing guidelines

background note
According to the grammatical correctness or standard provided by Chicago Manual of Style or Modern Language Association, conjunctions, articles and prepositions words should not be capitalized in a title or heading, whereas Gregg Reference Manual stipulates that any word longer than 3 letters should be capitalized. Here I follow the former.
what I did
I collected all the conjunctions, articles and prepositions words in English, as comprehensive as I was able, and wrote up a simple program to process them into a rule that recognized by the linter plugin.
usage
You can paste below the rule in the code block into Obsidian Setting - Linter - Heading - Lowercase Words.
That's done. Please let me know if anyone finds this helpful! And for the developers, feel free to integrate this as a default value of that field (just in case if you find this helpful). Thank you for developing this linter. It indeed made my life easier. ❤
a, an, the, aboard, about, abt., above, abreast, absent, across, after, against, along, aloft, alongside, amid, amidst, mid, midst, among, amongst, anti, apropos, around, round, as, aslant, astride, at, @, atop, ontop, bar, barring, before, B4, behind, below, beneath, neath, beside, besides, between, 'tween, beyond, but, by, chez, circa, c., ca., come, concerning, contra, counting, cum, despite, spite, down, during, effective, ere, except, excepting, excluding, failing, following, for, 4, from, in, including, inside, into, less, like, minus, modulo, mod, near, nearer, nearest, next, notwithstanding, of, o', off, offshore, on, onto, opposite, out, outside, over, o'er, pace, past, pending, per, plus, post, pre, pro, qua, re, regarding, respecting, sans, save, saving, short, since, sub, than, through, thru, throughout, thruout, till, times, to, t', 2, touching, toward, towards, under, underneath, unlike, until, unto, up, upon, versus, vs., v., via, vice, vis-à-vis, wanting, with, w/, w., c̄, within, w/i, without, 'thout, w/o, abroad, adrift, aft, afterward, afterwards, ahead, apart, ashore, aside, away, back, backward, backwards, beforehand, downhill, downstage, downstairs, downstream, downward, downwards, downwind, east, eastward, eastwards, forth, forward, forwards, heavenward, heavenwards, hence, henceforth, here, hereby, herein, hereof, hereto, herewith, home, homeward, homewards, indoors, inward, inwards, leftward, leftwards, north, northeast, northward, northwards, northwest, now, onward, onwards, outdoors, outward, outwards, overboard, overhead, overland, overseas, rightward, rightwards, seaward, seawards, skywards, skyward, south, southeast, southwards, southward, southwest, then, thence, thenceforth, there, thereby, therein, thereof, thereto, therewith, together, underfoot, underground, uphill, upstage, upstairs, upstream, upward, upwards, upwind, west, westward, westwards, when, whence, where, whereby, wherein, whereto, wherewith, although, because, considering, given, granted, if, lest, once, provided, providing, seeing, so, supposing, though, unless, whenever, whereas, wherever, while, whilst, ago, according to, as regards, counter to, instead of, owing to, pertaining to, at the behest of, at the expense of, at the hands of, at risk of, at the risk of, at variance with, by dint of, by means of, by virtue of, by way of, for the sake of, for sake of, for lack of, for want of, from want of, in accordance with, in addition to, in case of, in charge of, in compliance with, in conformity with, in contact with, in exchange for, in favor of, in front of, in lieu of, in light of, in the light of, in line with, in place of, in point of, in quest of, in relation to, in regard to, with regard to, in respect to, with respect to, in return for, in search of, in step with, in touch with, in terms of, in the name of, in view of, on account of, on behalf of, on grounds of, on the grounds of, on the part of, on top of, with a view to, with the exception of, à la, a la, as soon as, as well as, close to, due to, far from, in case, other than, prior to, pursuant to, regardless of, subsequent to, as long as, as much as, as far as, by the time, in as much as, inasmuch, in order to, in order that, even, provide that, if only, whether, whose, whoever, why, how, or not, whatever, what, both, and, or, not only, but also, either, neither, nor, just, rather, no sooner, such, that, yet

Thanks for adding this here. I can update the default values for the rule though I am not sure I would retain the symbols since they should not be affected by the Linter anyways (i.e. @ stays as @ when made uppercase or lowercase).

This has been added as the new default. Thanks for providing it!

authors: lethefrost pjkaufman

repo: platers/obsidian-linter


text:
Properly escape markdown characters in clang-tidy comments

Hi @platisd I would like to propose another PR that should fix an issue with markdown formatting in clang-tidy reviews. Consider the difference between comments in this pull request (without proposed changes) and this (with these changes). In the first case the #include <cmath> part is displayed incorrectly.

Also I fixed some issues found by pylint - mostly cosmetic.

repo: platisd/clang-tidy-pr-comments


text:
Refactor axis events

@Geeber ref #19
This simplifies how buttons are handled - now they are simple boolean inputs which generate :button/press, :button/release, and :button/hold events with no :value. Note that hold replaces repeat.
Axes are now treated as a different class of input with a real number input value. Whenever the input is not the default state, axes emit :axis/direction events with :axis and :value entries.
I tested by plugging in the SNES controller and working through all the modes in the local simulation. Do you want to pick up the branch and add the explicit d-pad code? I left a TODO comment to show you where I think it should go.

Finally got around to pushing my changes (from our December project night) and reviewing yours. LGTM! :shipit:

Zack approves this merger.
On Wed, Feb 25, 2015 at 9:29 PM, Greg Look notifications@github.com wrote:

Merged #20 https://github.com/playasophy/wonderdome/pull/20.
—
Reply to this email directly or view it on GitHub
https://github.com/playasophy/wonderdome/pull/20#event-242268972.

authors: Geeber greglook zFleischman

repo: playasophy/wonderdome

license: unlicense


text:
Implement ground-projected skydome

We have a solution in some examples, but it'd be great to make it integrated in the Engine (and Editor) to make it easy to use.
https://twitter.com/willeastcott/status/1579461802555215874?lang=en-GB

The projected skybox approach that used geometry to project the skybox is perhaps overkill for this feature. I would just like to (initially) see basic controls to 'fix' the ground projection for certain skyboxes (so exposing attributes like 'Tripod Height' etc).

authors: mvaligursky willeastcott

repo: playcanvas/engine


text:
scalafmt-core 3.0.1 (was 3.0.0)

Updates org.scalameta:scalafmt-core from 3.0.0 to 3.0.1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, semver-patch

Superseded by #441.

repo: playframework/twirl


text:
🛑 Lindas Kingdoms is down

In f62d601, Lindas Kingdoms (https://lindas.admin.ch/query?query=PREFIX rdf%3A <http%3A%2F%2Fwww.w3.org%2F1999%2F02%2F22-rdf-syntax-ns%23>
SELECT DISTINCT %3Fk (SAMPLE(%3Fs1) as %3Fs)%0AWHERE%20%7B%0A%20%20%3Fs1%20a%20%3Chttp%3A%2F%2Ffilteredpush.org%2Fontologies%2Foa%2FdwcFP%23TaxonName%3E%3B%0A%20%20%3Chttp%3A%2F%2Frs.tdwg.org%2Fdwc%2Fterms%2Fkingdom%3E%20%3Fk.%0A%7D%0AGROUP%20BY%20%3Fk) was down:

HTTP code: 502
Response time: 853 ms

Resolved: Lindas Kingdoms is back up in 7387ed3 after 5 minutes.

repo: plazi/monitoring


text:
Fail to run plugin after plz init plugin go-proto

With plz 17.3.0, after running plz init plugin go-proto, I got the error:
    ///go_proto//build_defs:go_proto
Parsed build file plz-out/subrepos/plugins/go_proto/build_defs/BUILD but it doesn't contain target go_proto (depended on by //:all)

Version of the plugin is v0.2.0.
Forcing version 23b5f5c11c7ee4a00e56f871e3abe3e568bfc8ef makes it works. It seems that this is fixed by #6.
Is it possible to release a new version of this plugin?

Yup sure thing! Sorry about that.

authors: Tatskaari sfirmery

repo: please-build/go-proto-rules


text:
$value not resolving in message templates

Hi,
  @MinLength(
      2, {
        message: (args: ValidationArguments) => {
          if (args.value.length < 2) {
            return "$value is too short, minimum length is $constraint1 characters $property";
          }
        }
      })
  first: string = ''

The $value interpolation is not being resolved in the returned messages.  $constraint1 and $property are resolved.
Cheers

are you sure about this issue? I cannot reproduce it - see test cases

authors: pleerock st-clair-clarke

repo: pleerock/class-validator


text:
Rationale for not supporting "required" session params?

It seems like @Session(<param>, { required: <true|false> }) should work to be consistent with @Param, @QueryParam, @Body, etc.
I can maybe understand why @Session({ required: false }) isn't supported, but even so I think it's unnecessarily opinionated to not support the required option on session params.

@Param defaults to required and there is no option to control it.

@Session is required because when we demand session object, it must exist (working session middleware). Also @Session(propertyName) is required because you inject it to read a property like user, to perform login just use @Session and assign session.prop = value.
Can you show me the use case when you want something from session but you maybe don't want it so it can be undefined?

@19majkel94 yea sure. We have several endpoints that can be hit whether or not you have a session. If you have a session, it uses the customer ID from your session to fetch and layer in additional customer-specific data into the response.

You're right, I forgot that routing-controllers can be also used for MVC apps, not only REST API where you return 404 if user has no access to the resource (is not logged in). In case of rendering view, you can e.g. render home page for guest and personalized for user in the same action handler, so optional parameter makes sense there. But @Session should stay required as it will be empty object even for guests, undefined only if there's no express-session middleware installed.
Will do the fix today 😉

@19majkel94 awesome, thanks! My use case is actually just a REST API. It is essentially a proxy that sits in front of our product search service and layers in customer-specific product data from a redis cache into the response if you have a valid session.

repo: pleerock/routing-controllers


text:
Some files starting with dot are not added in a new addon created with generator-volto

Describe the bug
Although the template has several files that start with a dot, such as .dockerignore, .editorconfig, etc., only .gitignore is added.
To Reproduce
Steps to reproduce the behavior:
npm install -g @plone/generator-volto
yo @plone/volto test-volto
cd test-volto
yo @plone/volto:addon myaddon

Expected behavior
All files that start with dot in the template must be in the generated addon
Software (please complete the following information):

OS: Ubuntu 22
Volto Version : 17.11.5

Additional context
It looks like .gitignore was added after @instification 's PR: https://github.com/plone/volto/pull/5258

Hi @wesleybl
The generator doesn't automatically include dotfiles when copying the template over.
The code that copies over the dotfiles is here:
https://github.com/plone/volto/blob/4a0580a518756f0cfcbb79fed7d175e84f12453f/packages/generator-volto/generators/addon/index.js#L207-L229
So only the .github/workflows .yarn/releases and .gitignore get copied over at the moment.
I'm afraid I don't know why it doesn't just copy the whole template including ignore files, I suspect it might not be possible to do it that way and all dotfiles will need to be manually added in index.js

@wesleybl yeah my change seems to have stopped the other dotfiles coming through.
I have made a fix in #5724 which should resolve the issue

authors: instification wesleybl

repo: plone/volto


text:
feat(Url.js): add getFieldURL helper function to get the url value of a field based on its structure

https://github.com/plone/volto/issues/2252
This pr adds a simple helper function that can be used to get the url of a field.
The field can have the following structures:
I.
buttonLink: {
   url: '/some/path'
}

II.
buttonLink: {
  "@id": '/some/path'
}

III.
buttonLink: {
   "@type": "URL",
   value: '/some/path'
}

It is meant to be used alongside a new deserialization method of URL type fields, like this one from here https://github.com/plone/plone.restapi/pull/1595.
Usage:
getFieldURL(buttonLink)  // '/some/path'

@sneridagh I added unit tests, can you take a look now?


text:
Dash Cytoscape Phylogeny

Issue for app: #28
App pull request

[ ] This is a new app
[x] I am improving an existing app (redesigns/code "makeovers")

About

Playground deployment URL (new version): https://dash-playground.plotly.host/dash-cytoscape
Current gallery app URL: https://dash-gallery.plotly.host/cytoscape-phylogeny/

Workflow

[ ] I have created a branch in the appropriate monorepo, and the
elements necessary for successful deployment are in place.
[ ] If the app is a redesigned and/or restyled version of an
existing gallery app, I've summarized the changes requested in the
appropriate Streambed issue and confirm that they have been applied.
[ ] If the app is on the Dash Gallery portal, I have added a link to
the GitHub repository for the source code in the portal description.
[ ] If the app is a reimplementation of a Python gallery app for the
DashR gallery, the app in this PR mimics, as closely as possible,
the style and functionality of the existing app.=
[ ] I have removed all Google Analytics code from the app's
assets/ folder.

The pre-review review
I have addressed all of the following questions:

[ ] Does everything in my code serve some purpose? (I have removed
any dead and/or irrelevant code.)
[ ] Does everything in my code have a clear purpose? (My code is
readable and, where it isn't, it has been commented appropriately.)]
[ ] Am I reinventing the wheel? (I have used appropriate packages to
lessen the volume of code that needs to be maintained.)

@chriskfwoo That would be a good idea!

authors: ronniebugia shammamah

repo: plotly/dash-sample-apps


text:
🛑 Pierced Arrows is down

In 3df106b, Pierced Arrows (https://www.piercedarrows.nl) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Pierced Arrows is back up in 4552b5a after 12 minutes.


text:
🛑 Pierced Arrows is down

In 90debc4, Pierced Arrows (https://www.piercedarrows.nl) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Pierced Arrows is back up in 2a8f9a8 after 15 minutes.


text:
🛑 Dick Pluim.com is down

In a714b34, Dick Pluim.com (https://dickpluim.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Dick Pluim.com is back up in 6a622a7 after 24 minutes.


text:
Setup for development on mac

I am getting set up locally for development and there is one test that is failing.
I am following the mac clang commands in .travis.yml. I have installed python3 from homebrew.
$ python3 --version
Python 3.6.4

All seemed to work, besides this one test failure:
$ python3 setup.py test
test_module (__main__.TestModule) ... ok
test_function (__main__.TestFunction) ... ok
test_void (__main__.TestVoid) ... ok
test_any (__main__.TestAny) ... ok
test_fixed_dim_assign (__main__.TestFixedDim) ... ok
test_fixed_dim_empty (__main__.TestFixedDim) ... ok
test_fixed_dim_overflow (__main__.TestFixedDim) ... skipped 'mach_vm_map message defeats the purpose of this test'
test_fixed_dim_subscript (__main__.TestFixedDim) ... ok
test_fortran_assign (__main__.TestFortran) ... ok
test_fortran_empty (__main__.TestFortran) ... ok
test_fortran_overflow (__main__.TestFortran) ... skipped 'mach_vm_map message defeats the purpose of this test'
test_fortran_subscript (__main__.TestFortran) ... ok
test_var_dim_assign (__main__.TestVarDim) ... ok
test_var_dim_empty (__main__.TestVarDim) ... ok
test_var_dim_overflow (__main__.TestVarDim) ... ok
test_symbolic_dim_raise (__main__.TestSymbolicDim) ... ok
test_ellipsis_dim_raise (__main__.TestEllipsisDim) ... ERROR
test_tuple_assign (__main__.TestTuple) ... ok
test_tuple_empty (__main__.TestTuple) ... ok
test_tuple_overflow (__main__.TestTuple) ... ok
test_record_assign (__main__.TestRecord) ... ok
test_record_empty (__main__.TestRecord) ... ok
test_record_overflow (__main__.TestRecord) ... ok
test_ref_assign (__main__.TestRef) ... ok
test_ref_empty (__main__.TestRef) ... ok
test_ref_empty_view (__main__.TestRef) ... ok
test_ref_indexing (__main__.TestRef) ... ok
test_constr_assign (__main__.TestConstr) ... ok
test_constr_empty (__main__.TestConstr) ... ok
test_constr_empty_view (__main__.TestConstr) ... ok
test_constr_indexing (__main__.TestConstr) ... ok
test_nominal (__main__.TestNominal) ... ok
test_scalar_kind (__main__.TestScalarKind) ... ok
test_categorical_assign (__main__.TestCategorical) ... ok
test_categorical_empty (__main__.TestCategorical) ... ok
test_fixed_string_kind (__main__.TestFixedStringKind) ... ok
test_fixed_string (__main__.TestFixedString) ... ok
test_fixed_string_assign (__main__.TestFixedString) ... ok
test_fixed_string_empty (__main__.TestFixedString) ... ok
test_fixed_string_overflow (__main__.TestFixedString) ... ok
test_fixed_bytes_kind (__main__.TestFixedBytesKind) ... ok
test_fixed_bytes_assign (__main__.TestFixedBytes) ... ok
test_fixed_bytes_empty (__main__.TestFixedBytes) ... ok
test_fixed_bytes_overflow (__main__.TestFixedBytes) ... ok
test_string (__main__.TestString) ... ok
test_string_assign (__main__.TestString) ... ok
test_string_empty (__main__.TestString) ... ok
test_bytes_assign (__main__.TestBytes) ... ok
test_bytes_empty (__main__.TestBytes) ... ok
test_char (__main__.TestChar) ... ok
test_bool (__main__.TestBool) ... ok
test_signed_kind (__main__.TestSignedKind) ... ok
test_signed (__main__.TestSigned) ... ok
test_unsigned_kind (__main__.TestUnsignedKind) ... ok
test_unsigned (__main__.TestUnsigned) ... ok
test_float_kind (__main__.TestFloatKind) ... ok
test_float16 (__main__.TestFloat) ... ok
test_float32 (__main__.TestFloat) ... ok
test_float64 (__main__.TestFloat) ... ok
test_complex_kind (__main__.TestComplexKind) ... ok
test_complex128 (__main__.TestComplex) ... ok
test_complex32 (__main__.TestComplex) ... ok
test_complex64 (__main__.TestComplex) ... ok
test_primitive_empty (__main__.TestPrimitive) ... ok
test_typevar (__main__.TestTypevar) ... ok
test_bytes (__main__.TestTypeInference) ... ok
test_complex128 (__main__.TestTypeInference) ... ok
test_float64 (__main__.TestTypeInference) ... ok
test_int64 (__main__.TestTypeInference) ... ok
test_optional (__main__.TestTypeInference) ... ok
test_record (__main__.TestTypeInference) ... ok
test_string (__main__.TestTypeInference) ... ok
test_tuple (__main__.TestTypeInference) ... ok
test_indexing (__main__.TestIndexing) ... ok
test_subview (__main__.TestIndexing) ... ok
test_sequence (__main__.TestSequence) ... ok
test_hash (__main__.TestAPI) ... ok
test_short_value (__main__.TestAPI) ... ok
test_repr (__main__.TestRepr) ... ok
test_endian (__main__.TestBuffer) ... ok
test_from_buffer (__main__.TestBuffer) ... ok
test_readonly (__main__.TestBuffer) ... ok
test_array_definition (__main__.LongIndexSliceTest) ... ok
test_chained_indices_slices (__main__.LongIndexSliceTest) ... ok
test_fixed_mixed_indices_slices (__main__.LongIndexSliceTest) ... ok
test_slices (__main__.LongIndexSliceTest) ... ok
test_slices_brute_force (__main__.LongIndexSliceTest) ... skipped 'use --all argument to enable these tests'
test_subarray (__main__.LongIndexSliceTest) ... ok
test_var_mixed_indices_slices (__main__.LongIndexSliceTest) ... ok

======================================================================
ERROR: test_ellipsis_dim_raise (__main__.TestEllipsisDim)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "python/test_xnd.py", line 484, in test_ellipsis_dim_raise
    t = ndt(ss)
ValueError: 1:6: syntax error, unexpected ELLIPSIS

----------------------------------------------------------------------
Ran 89 tests in 61.487s

FAILED (errors=1, skipped=3)

Thanks, xnd was out of sync with the recent commit https://github.com/plures/ndtypes/commit/1a15985d5f31b7a17cde975d61651628c16fc095 .
I think it should be fixed now.  Unfortunately this will probably happen more often in the future.

@skrah Your new commit fixed it, thanks.

authors: saulshanabrook skrah

repo: plures/xnd