text:
Why do I need to specify the token for open-source projects?

From here, it sounds like the token should not be required:

Note: public Travis-CI repos do not need this config file since Coveralls can get the information via their API (using access token exchange).

But if I don't specify the token, I get this error when running on Travis:
coveralls.exception.CoverallsException: Not on TravisCI. You have to provide either repo_token in .coveralls.yml or set the COVERALLS_REPO_TOKEN env var.

Our project is https://github.com/RaRe-Technologies/smart_open

In order for us to detect that we're running in TravisCI (and process the job accordingly, eg. without a token), we need access to the TRAVIS environment variable -- it looks like your tox.ini file does not pass through the values we need here (since tox blacklists all environment variables by default). Adding the following to the relevant tox job config should do the trick:
passenv = TRAVIS TRAVIS_*

Please see this page in our documentation for more info!

Thank you for the reply!
May I suggest you put this information in your README? It's buried a little too deep for someone unfamiliar with coveralls.io and your particular project (I realize they're separate). Here's the path I took when looking for docs:

https://docs.coveralls.io/ (has links to various languages)
https://docs.coveralls.io/python (has links to two projects, one of them yours, "Instructions in README’s.")
https://github.com/coveralls-clients/coveralls-python
Couldn't find any other helpful links to click, so went to https://github.com/coveralls-clients/coveralls-python/issues/new

A link from your README to https://coveralls-python.readthedocs.io would be helpful. The coveralls.io docs should probably point there too, as opposed to your github repo.

@mpenkov good call! The bottom line of our README is

For more information and usage instructions, see our documentation.

but that's definitely a bit small and hard to find. I'll make sure to highlight this a bit more (or feel free to submit a PR, if you're so inclined!).
Unfortunately, I don't have control over any of the coveralls.io docs directly; I'm not actually sure they keep that up to date and I see they link to all other project's Github repos instead of docs as well... ah well, just gives us an even better reason to make sure this is all included in the README directly!

The bottom line of our README is

Wow, I totally missed that.
I'll make a PR.

authors: TheKevJames mpenkov

repo: coveralls-clients/coveralls-python


text:
Adding scroll to top button (w/ animation) to all pages

Description of PR

Scroll Buttons for Home, Demographics and State pages1
Uses Feather Icons (w/ color palette from App.scss)
Animated Scroll
Scroll Button only appears when user has scrolled down the page

1Button is implemented for the Essentials page too but that'll feature in a later release
Type of PR

[x] Bugfix
[ ] New feature

Relevant Issues
Fixes issue #1273
Note: Saw PR #1274 already solves the issue but I preempted more issues being raised for the other pages. Also the animation fits in well
Checklist

[x] Compiles and passes lint tests
[x] Properly formatted
[x] Tested on desktop
[x] Tested on phone

Screenshots
Home

Patients DB

State (eg. MH)

Hey, thanks for the PR! Would like a discussion and an approval in the issue referenced before moving forward with a PR.

source: gharchive/pull-request

authors: aswaathb jeremyphilemon

license: MIT

license_type: permissive

license_source: github-api


text:
Remove user-declared default, copy and move constructors

The defaulted move constructor prevents implicit declaration of the copy assignment operator, which results in compiler errors since std::promise requires it.
All 3 user-declared methods removed here are implicitly declared by the compiler anyway, so no need to default them in the first place.
Relates to #547

Thanks!

authors: glynos rcdailey

repo: cpp-netlib/cpp-netlib


text:
Remove contact form page

See #208 for the initial bug report.
Tasks

Make the contact form work

Background

A few different CSRF issues were reported the last week of April
Most were fixed in https://github.com/cppalliance/boost.org/pull/240
I checked the contact form today and it still gives a CSRF error:

Per meeting today, we aren't using this page

source: gharchive/issue

repo: cppalliance/temp-site


text:
Won't install on Cygwin

I'm trying to install on windows 10 using cygwin. I've tried 2 methods:

The "official" one, at https://cpputest.github.io/, which errors error: AC_CONFIG_MACRO_DIRS([m4]) conflicts with ACLOCAL_AMFLAGS=-I m4 when I run autoreconf .. -i (which, if I've understood correctly, should have been fixed)
Following this set of unofficial instructions, which becomes useless when running make says *** No targets specified and no makefile found.  Stop..

Any solutions?

I did a quick google for you related to (1). Could you check this: https://stackoverflow.com/questions/47582762/ac-config-macro-dirsbuild-aux-m4-conflicts-with-aclocal-amflags-i-build-aux

Running dos2unix Makefile.am in the cpputest directory fixed it, now it complains that 'configure.ac' or 'configure.in' is required, even though there's a configure.ac right besides it.

Do the same ? It seems your line endings are messed up... but not understand why that is.

Can you run the autoreconf from the directory that the files are instead of the ..

worked, thanks!

repo: cpputest/cpputest

license_source: bigquery


text:
Issues 522 523 524

Fixed CCM metric evaluation. Graph components search now realized in java.

@iMaks99 did you try to run mvn clean install -Pqulice?

repo: cqfn/jpeek


text:
ini setting opcache_validate_timestamps doesn't seem to work

Description
I've set opcache_validate_timestamps to true through nitro iniset and confirmed it's in the config. I've applied and restarted a number of times but it doesn't seem to take effect. The ENV PHP_OPCACHE_VALIDATE_TIMESTAMPS is also 0 in the phpinfo()
Adding a .user.ini with the follow does enable it:
[opcache]
opcache.validate_timestamps=1

Steps to reproduce

Set opcache_validate_timestamps to true using nitro iniset. Accept to apply immediately.
Create phpinfo() & check local value for opcache.validate_timestamps.

Additional info

Nitro version: 2.0.8
Docker version: 20.10.10, build b485636

@darrylhein I provided a PR where this setting is working correctly, probably will be released in the future. For the time being you could checkout my branch, based on current version 2.0.9, which has the fix in it.
Note: it will require you to build Nitro yourself.

Just tagged 2.0.10 with this change!
Let me know if this is still an issue for you!

repo: craftcms/nitro


text:
Alert stretches horizontally across entire window

I'm testing the plugin  using this code
$.alert({    type: 'red',    title: 'Error',    content: 'This is the error message' ,    buttons: {    okay: {  text: 'OK', btnClass: 'btn-blue'  }    } });
I get an alert window that stretches across the entire browser window. Why would this happen? I haven't modified any of the css.

Do you have Bootstrap installed ?

authors: craftpip galcott

repo: craftpip/jquery-confirm


text:
viewport.follow scaling issue

Possible bug reported in forum post

The problem is that .follow doesn't have .scale in account when it calculates how much it have to displace the viewport to center the entity. I've solved the problem with a custom center method, bound to the 'enterFrame' event of the centered entity:

  this.centerViewport = function(entity) {
    Crafty.viewport.y = (4/3 * Crafty.viewport.height / 2 / Crafty.viewport._scale) - entity.y;
    Crafty.viewport.x = (Crafty.viewport.width / 2 / Crafty.viewport._scale) - entity.x;
  }

I haven't investigated yet. Is this a bug or intended behaviour?

This should have been fixed with #934 now, if you encounter any more problems with it feel free to reopen this issue.

Crafty.viewport.follow doesn't center screen after Crafty.viewport.scale() is called. Solution: Listen for ViewportScale event in addition to Change event to trigger center on entity.

Crafty.viewport.follow doesn't center screen after viewport transformations

fixed with 871ae034d3a46d9eb5dece6ea03e0f74c861346d

repo: craftyjs/Crafty

license: mit


text:
Slow query

CREATE TABLE
IF NOT EXISTS projects (
 id text PRIMARY KEY NOT NULL,
 name text NOT NULL,
 begin_date text,
 end_date text
)WITHOUT ROWID;

I have about 10k row and want select 100 row using the following query
SELECT * FROM projects WHERE id IN ("id1","id2",...,"id100")

In android 7 phone with 8 core cpu and 8Gig RAM(Also iOS device) (in release mode) . the query take about 2 sec but when I run the query in desktop PC in same database it take only 80ms
I also remove WITHOUT ROWID clause for test

@craftzdog please reply

Can you reproduce it with a native implementation?
I'd like to know if it's a problem of SQLite itself for mobile.
Because as you can see in the code, it just bridges API calls.

Fixed by changing schema


text:
CI and Sandbox: Temporarily remove use of uv

uv provided some hiccups in dependency resolutions, so we are trying without, in order to check if this improves the situation, or if it's unrelated.

GH-32
GH-35

Most prominently, the update to a higher version of pandas still does not succeed after many cycles to make it so.

GH-27

So sorry to bother but for my own prioritization, are you able to share the resolution that didn't succeed? Is it:
cratedb-toolkit[datasets]==0.0.29
ipyleaflet<0.20
kaleido<0.3
llvmlite>=0.40
pandas<2.1
pandas<2.3
plotly<5.25
pycaret>=3,<3.4
pydantic<3
refinitiv-data<1.7
sqlalchemy<2.1
sqlalchemy-cratedb==0.40.1

Dear Charlie,
thanks a stack for your reply, and sorry for missing it.

for my own prioritization

TLDR; Any issues on our ends have been resolved well. @zanieb educated us about https://github.com/astral-sh/uv/issues/8157, but I am no longer sure this was even the problem here. Thank you both for your time and diligence on supporting us and tracking this back.
With kind regards,
Andreas.
Details
The issue has been resolved and we swapped uv back in per GH-39. The problem originated because of the constraint limit pandas<2.1, which, when resolved per GH-27, did no longer cause any issues, afair.

able to share the resolution that didn't succeed?

Because you are listing pandas<2.1, I guess your enumeration is on the right track. Please note, however:

You are listing pandas twice, as you also included pandas<2.3.
Please also note we added and changed constraints about llvmlite, pycaret, and kaleido while trying to resolve woes on CI, see GH-29, GH-32, GH-33, GH-35.

Conclusion
Wrapping up, I think the noise was more about our own sillyness than about a serious issue we observed with uv. If you think our constellation of dependencies can support you to work on https://github.com/astral-sh/uv/issues/8157, please let us know any time. We can easily travel back in time of the repository history to get you a dependency dump using pipdeptree, or any other incantation of uv with relevant debug options you may advise.

authors: amotl charliermarsh

repo: crate/academy-fundamentals-course


text:
Don't wrap queries in object IS NULL in another BooleanQuery

Seems to improve performance a bit:
Q: SELECT count(*) FROM few_null WHERE o IS NOT NULL;
C: 1
| Version |         Mean ±    Stdev |        Min |     Median |         Q3 |        Max |
|   V1    |     1330.532 ± 1027.441 |      7.224 |    920.727 |   2204.921 |   2549.247 |
|   V2    |      752.898 ±  554.113 |      3.360 |    625.463 |   1086.822 |   1818.410 |
├---------┴-------------------------┴------------┴------------┴------------┴------------┘
|               -  55.45%                           -  38.19%
There is a 86.50% probability that the observed difference is not random, and the best estimate of that difference is 55.45%
The test has no statistical significance

Q: SELECT count(*) FROM many_null WHERE o IS NOT NULL;
C: 1
| Version |         Mean ±    Stdev |        Min |     Median |         Q3 |        Max |
|   V1    |     2512.322 ± 1464.079 |    286.413 |   1942.338 |   4013.377 |   4079.917 |
|   V2    |     2301.180 ± 1474.545 |    640.924 |   1676.863 |   3881.117 |   3944.891 |
├---------┴-------------------------┴------------┴------------┴------------┴------------┘
|               -   8.77%                           -  14.67%
There is a 24.83% probability that the observed difference is not random, and the best estimate of that difference is 8.77%
The test has no statistical significance

System/JVM Metrics (durations in ms, byte-values in MB)
    |    YOUNG GC            |       OLD GC           |      HEAP         |     ALLOC
    |  cnt      avg      max |  cnt      avg      max |  initial     used |     rate      total
 V1 |  147     2.10     1.22 |    0     0.00     0.00 |     4295      880 |  8856.30     337434
 V2 |  138     2.04     1.38 |    0     0.00     0.00 |     4295      733 | 11518.92     347249

many_null case looks like worth adding into crate/crate-benchmarks@440fca3?

Yes there is a PR for that: https://github.com/crate/crate-benchmarks/pull/283

Thx, Are you backporting this as a fix? (changelog entry missing)

May plan was to merge this only to master and instead backport https://github.com/crate/crate/pull/13960

repo: crate/crate


text:
Cc/comb docs fix

A lot of my changes will no longer apply without a lot of diff analysis. I'm doing some documentation work over the next week or so anyway, so will just resubmit.
This is what survived.

I think this has squashed @mfussenegger but I must admit I'm a tad confused by this one :/

Can you keep the lines wrapped at 80 chars? Otherwise ack

Odd @mfussenegger I have a code wrap set in my editor. I will check.

Yes I do @mfussenegger Can you show me an example where you think / are sure it's over 80 chars?

Try now @mfussenegger

I think this is resolved @mfussenegger I guess that's the issue with an automated line breaker, it doesn't appreciate subtlety… Though of course it now means you also have a line that's longer than 80 characters, I assume that's what you want.

yep that's okay.
ack

Squashed @mfussenegger

authors: ChrisChinchilla mfussenegger


text:
crawlab 重启之后，重启前 pending 的任务无法继续执行

Bug 描述
当我重启crawlab之后，在重启之前处于pending的任务无法成功调度，一直处于pending状态。
复现步骤
该 Bug 复现步骤如下

保证当前tasks列表中有pending的任务，且node为空
重启master和worker节点
重启成功后pending的任务会一直pending

期望结果
重启crawlab之后，之前处于pending的任务可以继续调度执行。

@ma-pony hey!
I would appreciate if you provide relevant translation for your issue in ENG.
I'm not sure if Google Translator handle it properly.
Thanks)

@ma-pony hey! I would appreciate if you provide relevant translation for your issue in ENG. I'm not sure if Google Translator handle it properly. Thanks)

Thanks for the suggestion！

@ma-pony thanks for your translation.
Have the same issues. In my case I have > 400 scheduled tasks and lot of them staying in pending state and never executed.
Seems like Redis queues don't clear in proper way.

@ma-pony thanks for your translation. Have the same issues. In my case I have > 400 scheduled tasks and lot of them staying in pending state and never executed. Seems like Redis queues don't clear in proper way.

I have 6k+ scheduled tasks...

@ma-pony 6k+ scheduled tasks it is impressive.
What kind of Crawlab installation you using Docker based or Kubernetes and what kind of infrastructure you using.
Could you please share some details?

@ma-pony 6k+ scheduled tasks it is impressive. What kind of Crawlab installation you using Docker based or Kubernetes and what kind of infrastructure you using. Could you please share some details?

https://docs.crawlab.cn/en/guide/installation/kubernetes.html
four 8C16G  machines, deployed using k8s, one master node and six worker node， with worker configured with 4C16G and master configured with 6C12G

authors: ma-pony oleksa-dev

repo: crawlab-team/crawlab


text:
README.md updates

Behaviour
Thanks for creating this project. I'd like to share user feedback and some proposals for documentation improvement.
Issue 1
The --load option in README.md is missing before the created image samba:local can be used with docker-compose up. Additionally, the default tag can be overruled as I'd like to push to my local registry:
git clone https://github.com/crazy-max/docker-samba.git
cd docker-samba

# Build image and output to docker (default)
-docker buildx bake
+docker buildx bake --load
+
+# To override the default tag samba:local, set environment variable
+DEFAULT_TAG=<username>samba:<tag> docker buildx bake --load

Issue 2

Copy the content of folder examples/compose in /var/samba/ on your host for example.

This is confusing, because any directory on the host can be used. Proposal to remove the sentence, or update to copy examples/compose to any location on the host.
Issue 3
Volumes of the shared directories are missing. It is recommended to save the data on the host and not inside the container. For example, the path setting in config.yml is the path inside the container, not the host. (Maybe confusing for beginners)
Proposal to update the README.md and docker-compose.yml to:
version: "3.5"

services:
  samba:
    image: registry.erwinw.nl/erriez/docker-samba-cm:latest
    container_name: samba
    restart: always
    network_mode: host
+    volumes:
+      - $PWD/data:/data
+      - $PWD/samba/foo:/samba/foo
+      - $PWD/samba/public:/samba/public
+      - $PWD/samba/share:/samba/share

Issue 4
Missing documentation password_file: /run/secrets/baz_password in config.yml.
Proposal to add link to the official documentation how to create a secure password file: https://www.samba.org/samba/docs/current/man-html/smbpasswd.8.html
Is it possible to create a secure password with this container? A suggestion to share the password file via the volume data/.
Issue 5
User baz is currently not used in docker-compose.yml. It would be nice to create an example share with read/write permission for two users, for example in config.yml:
+  - name: foo-baz
+    path: /samba/foo-baz
+    browsable: yes
+    readonly: no
+    guestok: no
+    validusers: foo,baz
+    writelist: foo,baz
+    veto: no

Issue 6
Missing explanation veto in config.yml. What is the purpose of this setting?
Issue 7
The network is exposed to the host in docker-compose.yml with network_mode: host. However, port 445 for SMB3 is sufficient as NetBIOS ports / multicast are no longer used. Proposal to change to:
version: "3.5"

services:
  samba:
    image: registry.erwinw.nl/erriez/docker-samba-cm:latest
    container_name: samba
    restart: always
-    network_mode: host
+    ports:
+      - 445:445

Configuration

Docker version (type docker --version) : Not relevant.
Docker compose version if applicable (type docker-compose --version) : Not relevant.
Platform (Debian 9, Ubuntu 18.04, ...) : Ubuntu 20.04 server ARM64 (Samba Server), Windows 10 client, Ubuntu 20.04 client
System info (type uname -a) : Not relevant.
Include all necessary configuration files : docker-compose.yml, .env, ...

@Erriez

Issue 1

The image will be already loaded to Docker for the default image-local target, no need to add the --load flag:
$ docker buildx bake --print
{
  "target": {
    "image-local": {
      "context": ".",
      "dockerfile": "Dockerfile",
      "tags": [
        "samba:local"
      ],
      "output": [
        "type=docker"
      ]
    }
  }
}

Issue 2

Yeah that's just an example, feel free to open a PR with:

update to copy examples/compose to any location on the host.

Issue 3

Good point, the example should be updated.

Issue 4

password_file is a secret that will be used by smbpasswd in the entrypoint script and not a generated SMB sessions file.

Issue 5

Agree we could do that, feel free to open a PR.

Issue 6

veto setting is a list of predefined files and directories that are neither visible nor accessible.
More info https://www.samba.org/samba/docs/current/man-html/smb.conf.5.html#VETOFILES

Issue 7

Indeed this is enough. I guess I used that while testing avahi support. Should be fixed.

Issue 1

Answered: You're right, it builds samba:local and I overlooked this. Great!

Issue 4

Answered: It loads a password_file configured in /data/config.yml with username and password on separate lines. I assume it is in plain text as the smbpasswd --help shows -s use stdin for password prompt. Explanation of this file format is missing in the README.md.

Issue 6

Ok, now I understand how it works:
https://www.samba.org/samba/docs/current/man-html/smb.conf.5.html#VETOFILES
A PR can improve remaining issues.

authors: Erriez crazy-max

repo: crazy-max/docker-samba


text:
OPPO R11 Android 7.1.1 相机拍照后/选择相册照片后，重新退回到拍照/选择相册

OPPO R11 Android 7.1.1 相机拍照后/选择相册照片后，重新退回到拍照/选择相册，按2次返回键后才能进入裁剪页面

已解决

repo: crazycodeboy/TakePhoto


text:
[integration-test] disk-resize test failing on openshift CI

Recently (since ~4 sprints back) on the CI disk-resize integration test is failing, it does succeed always upon a retry

@anjannath can you put the logs or the link to failled CI job?

yes, here's the link to the logs: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/crc-org_crc/3769/pull-ci-crc-org-crc-main-integration-crc/1684072012844109824

As per job history https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/pull-ci-crc-org-crc-main-integration-crc this is not looking good (3 success out of 20 runs). @jsliacan Are you planning to take a look into this?

Yes yes, I put it on the list in planning yesterday.

I don't think this is an issue anymore after #3821 went in, let's reopen if the issue re-emerges.

authors: anjannath jsliacan praveenkumar

repo: crc-org/crc


text:
A better way to find globally installed packages

...also echoes an info string when there is nothing to do

...waiting for CI tests to complete

needs more work, obviously

repo: creationix/nvm


text:
[Docs]: Docs feel outdated

Contact Details
hellotimi@proton.me
Description
The documentation feels outdated and has lots of typo errors, the docs would need to be

- Carefully updated, not many words to be changed.
- Add an interactive demo to the docs if applicable.
- Make the docs easier to understand.
- Add sign-up process.
- Add a process on how to upload a file.

Docs Version
Currently, the docs are on v1

Screenshots
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

#7 Improved docs

repo: creative-tutorials/stashblob


text:
Generate new author and category pages automatically.

Is your feature request related to a problem? Please describe.
Category and author pages have to be added manually for new authors and categories despite having enough information to generate basic pages automatically. This makes the process of adding a new blog post take longer. See the instructions on https://opensource.creativecommons.org/community/write-a-blog-post/, we could reduce a couple of steps.
Describe the solution you'd like
Whenever Lektor builds its static files, it should create missing author or category files for new blog posts.
Describe alternatives you've considered
Keep doing it manually like we do now, but that's a pain.

Hello @kgodey , I am an Outreachy applicant. Please may I work on this issue?

Sure @SamOdum, I see you've commented on a couple of other issues on this repo as well, please pick one issue at a time so that others have a chance too. Let me know which one you want to tackle first and I'll mark that one as in progress.

Hi @kgodey ! I'am an outreachy applicant , i have just received your mail according to the other project that is already in progress. Please is it possible for me to work on this one ?

Yes, go ahead

Thank you @Kriti
Envoyé depuis Yahoo Mail pour Android
Le lun., oct. 21, 2019 à 18:02, Kriti Godeynotifications@github.com a écrit :
Yes, go ahead
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi @kgodey ! I thought that generate new author were about something like that. But i discovered that it is already available through admin interface. Now ,i don't know whether i should create a link to a page  that allows an author to fill its informations directly and to involve category. please Ma i'm a bit confused , need your help .

@chimenekouomogne We don't always use the Lektor admin interface to write posts. When a new blog post entry is created with an unknown author username in the author field (e.g. if this entry was created and there was no makkoncept author file present), it would be great for the corresponding author folder and file (like here to get created automatically. Only the username field can be automatically created, the rest of the fields should not be present.

Hi @kriti ! I have modified the file author.html so that when you want to create a new blog post, you can only enter your username in the file.lr

Here are the results. As you can see, for a new author , only his username and post are display. For an old author, his name and his post are display. Please is that what you wanted me to do ?

Hi @kgodey ! i have face too dificulties while making pull request to this site .  but i have done it on my github link :
https://github.com/chimenekouomogne/creativecommons.github.io-source.

Hi @kgodey ! please here is a link for my final application :
https://docs.google.com/document/d/1Gr-xw99jg_wgqOXVNm4hd5lglhRS4trWqDWVFAXgnGA/edit?pli=1#

hi @chimenekouomogne, sorry for the delay on getting back to you on this. Your work does not address this issue, but after thinking about it, I don't think this issue makes sense to implement at this time anyway.
We want people to be thoughtful about adding new authors and categories and this issue would automatically generate missing authors/categories, which would make errors harder to catch.
I'm going to close the issue.

authors: SamOdum chimenekouomogne kgodey


text:
Update dependencies

Update js dependencies to latest versions.
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhrub Updated vocabulary to the latest and storybook packages to the following:
 @storybook/addon-backgrounds  ^5.3.19  →  ^6.0.15
 @storybook/addon-docs         ^5.3.19  →  ^6.0.15
 @storybook/addon-knobs        ^5.3.19  →  ^6.0.15
 @storybook/addon-viewport     ^5.3.19  →  ^6.0.15
 @storybook/vue                ^5.3.19  →  ^6.0.15

repo: creativecommons/vue-vocabulary


text:
Proposal: Pluggable AuthN/AuthZ

Business Background and Requirements

we need flexibility because we assume every enterprise company has a slightly different Identity/Auth setup
we want to be compatible with (and prefer) standards and best practices, but at the same time allow highly-customized solutions as well
we assume different users have different needs for

Authentication: LDAP, OAuth2, simple basic Auth...
Authorization: smaller setups require something as simple as "every authenticated user can view, some people can write". More complex setup will require a very fine-graid auth "users of group foo can read a.b.c and a.b.e, but not a.b.d, but can write only a.b.e

Proposed Solution
tl;dr:

both Authentication (AuthN) and Authorization (AuthZ) are fully pluggable
we'll start with very simple "plugins" like

No Auth (for AuthN)
Basic Auth with fixed config (for AuthN)
Every Authenticated user is authorzied (for AuthZ)
etc.

we will extend it with more elaborate plugins like OAuth2/OpenIDConnect (for AuthN) and Role-Based-Access (RBAC) for AuthZ later
there is a minimal interface between AuthN and AuthZ to reduce coupling
overall inspired by Kubernetes, especially plugin "Role Based Access Control"

Architectural Components, Boundaries and Interfaces

The following components are available (also see diagram)
Incoming Request
Any request that comes in from the outside (wether it's REST or GraphQL) will go through both the Authentication and Authorization middleware.
Authentication Middleware (fixed, not pluggable)

The first middleware to be called. It receives the whole request.
It calls the Authentication plugin with  request *http.Request
It receives authenticated bool, authInfo AuthInfo
if it received authenticated == false, it aborts the request, returns a response with HTTP Status 401
it received authenticated == true, it continues by calling the next middleware, the Authorization middleware with authInfo AuthInfo

Authentication Plugin

has access to the full request (`*http.Request)
decides based on configuration and the request whether the user is authenticated
MUST extract a username string
SHOULD extract a group string
CAN extract additionalData interface{}
MUST return authenticated bool, authInfo{ username, group, additionalData}

Authorization Middleware (fixed, not pluggable)

is called by the Authentication Middleware
only if Authentication was successful
It calls the Authorization plugin with authInfo, resourcePath string, action string
It receives authorized bool, err error
if it received authorized == false, it aborts the request, returns a response with HTTP Status 403 and includes the error message, .e.g. User 'JohnDoe@gmail.com' does not have permission to READ Things.City
it received authorized == true, it continues with the intended action.

Authorization Plugin

has access to everything the Authentication Plugin extracted, i.e. authInfo{ username, group, additionalData}
has access to a description of the desired resource and the desired action, i.e. READ Local.Things.Cities
MUST decide based on available info and configuration whether the user is authorized to perform the desired action

Original Request Handler

unchanged, only called if both Authentication and Authorization were successful

Proposed Connectors
Authentication
Anonymous Access
If this plugin is activated every single request will be authenticated as user anonymous in group anonymous. Should be combined with an AuthZ plugin that gives anonymous some rights.
Basic Auth
If this plugin is activated every single request will be asked for a username and password. This will be validated against a configuration file. It will store plain-text passwords and is considered a simple tool to get started, but not a fully secure solution. Will resolve with the username and map this user to a preconfigured group. A configuration file for this plugin could look like
user,group,password
johndoe,admin,s3cr3tp4$$w0rd

OpenID connect
Expects a JWT to be sent as part of the request headers. Validates it against the token issuer specified in the configuration. Extracts subject (or other configurable field) as username, tries to extract a group if set in the token.
A possible configuration for this plugin could look like
# openid-config.yml
issuer: http://my-identity-provider.com
audience: my-weaviate
usernameClaim: sub
groupClaim: group

Authorization
Anonymous Plugin
A plugin with very few configuration options, can be set to either give users of the group anonymous full access or read-only access.
Simple Matrix (similar to RBAC, but more primitive)
A plugin that can map authenticated users or groups to allowed actions, but not configurable at runtime. Configuration could look something like
# matrix-auth.yml
- username: johndoe@gmail.com
  resourcePath: ["Things", "City"]
  actions: ["read", "write"]
- group: anonymous
  resourcePath: ["Actions", "*"]
  actions: ["read"]

Explanation:

JohnDoe can read and write all Things.City, but cannot read or write any other Thing or Action
Users in the group anonymous can read all Actions, but not write any. They can't read or write Things

RBAC
Same as Matrix, but configurable at runtime through API
Potential delivery Roadmap

Remove current Key-based system
Start with making the authentication pluggable, but ignore AuthZ. As part of this build the most simple authenticator, such as "Anonymous Access"
Add another simple authenticator, such as "Basic Auth"
Make Authorization pluggable, start with very simple authorizer, such as "Anonymous Access"
Slowly implement Matrix Plugin (can in turn happen in many iterations)
Replace Matrix Plugin with full RBAC solution that can be configured via API

Some thoughts @etiennedi,

Maybe it is smart to remove the key-based system asap. This allows people to use Weaviate asap.
I'm all for the proposed setup.
We have different authentication for P2P nodes.

Considering the major building blocks of this proposal accepted. Details can be ironed out down the line. Therefore closing this issue and opening two new issues to reflect Authentication and Authorization.

authors: bobvanluijt etiennedi

repo: creativesoftwarefdn/weaviate


text:
Workers do not reconnect after TRANSIENT_FAILURE

It looks like workers do not reconnect after a TRANSIENT_FAILURE with the pure JS Grpc implementation.
My hypothesis about this is that the channel goes to TRANSIENT_FAILURE, and it takes another gRPC call before the channel state switches.
In order to deal with this, I am changing the GrpcClient failure logic to wait for 5 seconds on a TRANSIENT_FAILURE, then resolve to reconnected and unblock further operations.

Yeah, this is still an issue. It looks like this with DEBUG level logging:
00:06:50.898 | zeebe |  [cloud-test-task] DEBUG: Long poll loop. this.longPoll: 30s
00:06:50.900 | zeebe |  [cloud-test-task] INFO: Stalled on Grpc Error
00:06:50.900 | zeebe |  [cloud-test-task] INFO: Grpc Error: 14 UNAVAILABLE: Connection dropped
00:06:50.900 | zeebe |  [cloud-test-task] DEBUG: Start watching Grpc channel...
00:06:50.900 | zeebe |  [cloud-test-task] INFO: Grpc Channel State: IDLE
00:06:50.901 | zeebe |  [cloud-test-task] DEBUG: {"code":14,"details":"Connection dropped","metadata":{"internalRepr":{},"options":{}}}
00:06:50.901 | zeebe |  [cloud-test-task] DEBUG: Stream ended after 27.449 seconds
00:06:50.901 | zeebe |  [cloud-test-task] DEBUG: Activating Jobs...
00:06:50.901 | zeebe |  [cloud-test-task] DEBUG: Grpc Channel state: IDLE
00:06:50.901 | zeebe |  [cloud-test-task] DEBUG: Long poll loop. this.longPoll: 30s
00:07:22.152 | zeebe |  [cloud-test-task] DEBUG: {"code":0,"details":"","metadata":{"internalRepr":{},"options":{}}}
00:07:22.152 | zeebe |  [cloud-test-task] DEBUG: Stream ended after 31.254 seconds
00:07:22.152 | zeebe |  [cloud-test-task] DEBUG: Activating Jobs...
00:07:22.153 | zeebe |  [cloud-test-task] DEBUG: Long poll loop. this.longPoll: 30s

Same here. I try to deploy a WorkflowInstance with the zeebe brocker being down:
11:57:03.917 | zeebe |  INFO: [topology]: 14 UNAVAILABLE: No connection established
11:57:03.920 | zeebe |  INFO: [createWorkflowInstance]: 14 UNAVAILABLE: No connection established
11:57:04.923 | zeebe |  INFO: [topology]: Attempt 2 (max: 50).
11:57:04.926 | zeebe |  INFO: [topology]: 14 UNAVAILABLE: No connection established
11:57:04.933 | zeebe |  INFO: [createWorkflowInstance]: Attempt 2 (max: 50).
11:57:04.937 | zeebe |  INFO: [createWorkflowInstance]: 14 UNAVAILABLE: No connection established
...

Then I start the brocker but zeebe-node never reconnect.

Fixed in 0.23.0

repo: creditsenseau/zeebe-client-node-js


text:
Avoid users having to cast resource handlers to raw types

Reviewer checklist

[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage increased (+0.02%) to 99.614% when pulling b345518e90182dcaf6e167cdf942de60c77a7699 on avoid_raw into babc4881cd781709ea41e6684161b4166c26295e on main.

authors: big-andy-coates coveralls

repo: creek-service/creek-service


text:
[WIP] Implement lazy scaling and shifting for VectorDict

Draft PR related to this and that comment, implements lazy scaling and shifting for VectorDict.
First 2 commits are preparation, just look at the 3rd one for the implementation.
Benchmarks below use .keys() to force the evaluation of the lazy part so it's comparable to the non-lazy implementation (copy at each operation).
from creme import utils
x = {i: i for i in range(100)}
y = utils.VectorDict(x)

# this PR
%timeit y.keys()
106 ns ± 0.0774 ns per loop (mean ± std. dev. of 7 runs, 10000000 loops each)
%timeit y + 1
139 ns ± 0.337 ns per loop (mean ± std. dev. of 7 runs, 10000000 loops each)
%timeit (y + 1).keys()
6 µs ± 32.9 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)
%timeit (y ** 2 / 2 + 1).keys()
31.1 µs ± 107 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)
%timeit (2 * y + 3 * y).keys()
14.2 µs ± 42.2 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)

# previous PR #351, should be similar to master
%timeit y.keys()
108 ns ± 0.132 ns per loop (mean ± std. dev. of 7 runs, 10000000 loops each)
%timeit y + 1
5.08 µs ± 20.2 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)
%timeit (y + 1).keys()
5.13 µs ± 12.9 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each)
%timeit (y ** 2 / 2 + 1).keys()
35.6 µs ± 106 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)
%timeit (2 * y + 3 * y).keys()
20.5 µs ± 86.5 ns per loop (mean ± std. dev. of 7 runs, 10000 loops each)

We can see it's a bit faster for complex operations but it's not huge and it makes other operations a bit slower.
Also it hurts maintainability.
Maybe some custom methods as mentioned here would be a better option although a wrapper would be needed to get the same expressions with numpy arrays.

Thanks Bruno.
As you hinted at, I don't think that there's more cons than pros. It is an interesting topic nonetheless, and certainly one where I should spend more time looking at. In a way, numpy sort of has the same problem, right? That's why numexpr was created. Maybe that if we grow bigger, there might some justification to spend more time here and dedicate effort towards a tidy module that is dedicated to VectorDict. I don't know.
But anyway, things are very good right now, no need to throw the kitchen sink at the problem, at least that's how things seem to me.

Indeed numpy has the same problem although since it's pretty fast already it's a bit less of an issue. I will close this one then and maybe this can be revisited in the future with an option that can deal with both arrays and dictionaries, potentially on the lines of numexpr.

authors: MaxHalford brcharron

repo: creme-ml/creme


text:
[help wanted] on CSS Libraries / Modules Preparation

Hi Snel Community.
First of all: Congratulations!! I love Snel.
I use it in some fun open source projects with some of my students.
We are wondering what would be the best way to use assets like https://illright.github.io/attractions/ or svelte-frappe-charts via Snel...
I tried

trex --custom svelte-frappe-charts=https://cdn.skypack.dev/svelte-frappe-charts

which lead to

Could anyone give us any hints on that?
Michael

what do you think of the following approach: https://www.npmjs.com/package/svelte-adapter-deno ?

after stumbling over ...

etc. we have just decided to implement the relatively simple CSS on our side instead of using a UI Kit --> closing this issue.

repo: crewdevio/Snel


text:
Show header navigation in its entiety on Safari

fixes #65

@bhujoshi please add a hacktoberfest-accepted label to this if all good. Or add hacktoberfest as a topic to your repo.

@ashokaditya thanks a lot for sending a fix. I added hacktoberfest as a topic.
Can you please add more details on what is the issue and why do we have to add it to all the screen components?
Seems really unmaintainable to add it to all the components right?

@kamalkishor1991 thanks for following up.
So as I see it the Safari bug is due to the fact that there's a max-width set on top of the app content at the View node which is shared for native and web apps. The rest of the app is configured via React Navigation
that have components mapped to corresponding route names. If this was not the case I could have encapsulated these components into a top component and added the styles to only that. But doing that would be a big change.
So I went with a smaller change. The idea was to then render the app content in its full width (which is within the top View) and add a max-width restriction to the content that renders below the header. Mot using React Navigation and writing a custom navigation component would be a better approach in my opinion. But this is also a big change.

@ashokaditya thanks for the explanation,  I still don't understand why it is only a problem with safari. Can you send me an email and I can add you to the slack group to discuss this more?
email: kkjoshi.it@gmail.com

@kamalkishor1991 thanks for asking the relevant questions which led me to look into it bit closer. I found a simpler more maintainable fix after all. At least compared to the previous one. Essentially React Navigation adds styles that Safari renders differently than Chrome or Firefox. This fix overrides the react navigation style, particularly overflow so that the header is visible in its entirety.

Looks good. Thanks

👍 thanks @kamalkishor1991

repo: croma-app/croma-react


text:
rustc ICE when building with cross

xargo CI is failing with a strange ICE:
thread 'rustc' panicked at 'failed to lookup `SourceFile` in new context', src/librustc_middle/ty/query/on_disk_cache.rs:456:17

note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.44.0-nightly (3712e11a8 2020-04-12) running on x86_64-unknown-linux-gnu

note: compiler flags: -C debuginfo=2 -C incremental --crate-type bin

note: some of the compiler flags provided by cargo are hidden

error: could not compile `xargo`.

The ICE occurs not always in the same place, but replacing cross by cargo makes it go away. I have no idea what is going on.

Looks like this is fixed now, whether through rustc or cross changes I do not know.

Actually no it's not solved.
This currently means we cannot land any xargo PRs.

Setting export CARGO_INCREMENTAL=0 seems to work around the issue.

I tried the cross test command locally and cannot reproduce this, neither on stable nor on nightly.

I never used cross myself so I'm afraid I can't help much here... I just inherited this as part of the existing xargo CI setup that I barely understand.^^

This isn't replicating for me, and I believe this is probably related to the incremental compilation issues that Rust was having and then mostly fixed? I'm very unsure of that, but I can't seem to replicate this issue anymore. I've tried also using a nightly very close to yours and the latest xargo.
$ TARGET=armv7-unknown-linux-gnueabihf
$ rustc +nightly-2020-04-12 --version
rustc 1.44.0-nightly (e82734e56 2020-04-11)
$ cross +nightly-2020-04-12 run --bin xargo --target $TARGET -- -V
Warning: using older rustc `1.44.0-nightly (e82734e56 2020-04-11)` for the target. Current active rustc on the host is `rustc 1.63.0-nightly (ca122c7eb 2022-06-13)`.
 > Update with `rustup update --force-non-host nightly-2020-04-12-x86_64-unknown-linux-gnu`
    Finished dev [unoptimized + debuginfo] target(s) in 0.24s
     Running `/linux-runner armv7 /target/armv7-unknown-linux-gnueabihf/debug/xargo -V`
xargo 0.3.26 (2b00127 2022-06-01)
cargo 1.44.0-nightly (390e8f245 2020-04-07)

xargo CI also cannot reproduce any more. Our CI was ported from Travis to GHA since then so that might be a factor, but anyway it probably makes sense to close this issue and reopen if the problem ever arises again.

authors: Alexhuszagh RalfJung reitermarkus

repo: cross-rs/cross


text:
Don't try to build the Unix domain socket example on Windows

Usually when building, you'd just run make or ninja. This fails horribly on the uds example in Windows. It can be resolved by disabling building all examples, but it's a nice sanity check to make sure nothing in the build tree is broken and we have all dependencies of autobahn-cpp properly set up (since it's a header-only library we need to build something to check that).

ah yes, perfect. UDS won't run on windows. thanks for cleaning that up!

authors: oberstet robinlinden

repo: crossbario/autobahn-cpp


text:
Go Templating does not appear to be applied to resulting object

I'm very new to Crossplane and Composition Functions - this is probably the result of a typo or a trivial misunderstanding, but I've double-checked my work and can't see anything wrong with it, so I'm hoping that the very act of asking will help me realize my mistake 🫠
What happened?
Where I've used {{ .desired.composite.resource.spec.<field name> }} in Composition definitions, expecting the field to be plumbed through into the resulting Composite Resource, instead the string <no value> [sic] is inserted.
(Only tested so far on Vault Policies as that is the only Provider I've installed and tested. I can confirm that creating Vault Policies via direct application of a manifest works as expected)
How can we reproduce it?
Full reproduction instructions from scratch are in this repo. Assuming you have a cluster set up with Crossplane, Providers, etc. all set up (and, in particular, with a ProviderConfig named vault-provider-config for the Vault Provider), do the following:
$ kubectl apply -f -<<- EOF
apiVersion: apiextensions.crossplane.io/v1
kind: CompositeResourceDefinition
metadata:
  name: xapplicationvaultpolicies.crossplane-demo.legalzoom.com
spec:
  group: crossplane-demo.legalzoom.com
  names:
    kind: XApplicationVaultPolicy
    plural: xapplicationvaultpolicies
  versions:
    - name: v1alpha1
      served: true
      referenceable: true
      schema:
        openAPIV3Schema:
          type: object
          properties:
            spec:
              type: object
              properties:
                serviceName:
                  type: string
EOF

$ kubectl apply -f - <<- EOF
apiVersion: apiextensions.crossplane.io/v1
kind: Composition
metadata:
  name: vault-policy-example
spec:
  compositeTypeRef:
    apiVersion: crossplane-demo.legalzoom.com/v1alpha1
    kind: XApplicationVaultPolicy
  mode: Pipeline
  pipeline:
    - step: create-policies
      functionRef:
        name: function-go-templating
      input:
        apiVersion: gotemplating.fn.crossplane.io/v1beta1
        kind: GoTemplate
        source: Inline
        inline:
          template: |
            apiVersion: vault.vault.upbound.io/v1alpha1
            kind: Policy
            metadata:
              annotations:
                gotemplating.fn.crossplane.io/composition-resource-name: dev-team-policy
            spec:
              forProvider:
                name: "dev-team-policy-for-{{- .desired.composite.resource.spec.serviceName -}}"
                policy: "path \"secret/{{- .desired.composite.resource.spec.serviceName -}}\" { capabilities = [\"update\"] }"
              providerConfigRef:
                name: vault-provider-config
    - step: automatically-detect-ready-composed-resources
      functionRef:
        name: function-auto-ready
EOF

$ kubectl apply -f - <<- EOF
apiVersion: crossplane-demo.legalzoom.com/v1alpha1
kind: XApplicationVaultPolicy
metadata:
  name: application-vault-policy-for-service-1
spec:
  serviceName: my-service-1
EOF

(I've tried the templating both with and without the leading and trailing dashes - i.e. {{- .desired.[...] -}} and {{ .desired.[...] }} - same outcome both ways)
Expectation - Creation of:

A xapplicationvaultpolicies.crossplane-demo.legalzoom.com named application-vault-policy-for-service-1
A policies.vault.vault.upbound.io named dev-team-policy-for-my-service-1
A Vault Policy named dev-team-policy-for-my-service-1, with policy text path "secret/my-service-1" { capabilities = ["update"] }

Actuality - Resultant Vault Policy is named dev-team-policy-for-<no value>, with policy text path "secret/<no value>" { capabilities = "update"] }
What environment did it happen in?

Function version: v0.3.0
Running on kind local Kubernetes cluster
kubectl version --short:

Client Version: v1.27.3
Kustomize Version: v5.0.1
Server Version: v1.27.3

OS: MacOS 13.6.2
Kernel: Darwin ML-LWW96P4V61 22.6.0 Darwin Kernel Version 22.6.0: Thu Nov  2 07:43:57 PDT 2023; root:xnu-8796.141.3.701.17~6/RELEASE_ARM64_T6000 arm64

Huh - I checked the examples, changed my template to use {{ .observed.composite.[…] }} throughout, and now it’s working as expected. So now my question becomes…why? At the time I create the Composite, isn’t the observed state nil (nothing should be observed before it’s created!) and the desired state is what I have declared should be created?

I think this is more of a general Crossplane Functions question rather than a specific question about this function, so I'll take it to the Slack and mark this issue as resolved.


text:
[Bug]: Crossplane does not detect drift in IP rules of storage account

Is there an existing issue for this?

[X] I have searched the existing issues

Affected Resource(s)
storage.azure.upbound.io/v1beta2
Resource MRs required to reproduce the bug
apiVersion: storage.azure.upbound.io/v1beta2
kind: Account
metadata:
  name: storage-account
spec:
  managementPolicies: ["Create", "Observe", "Update"]
  forProvider:
    accountKind: StorageV2
    accountReplicationType: ZRS
    accountTier: Standard
    publicNetworkAccessEnabled: false
    allowNestedItemsToBePublic: false
    sharedAccessKeyEnabled: false
    defaultToOauthAuthentication: true
    isHnsEnabled: false
    networkRules:
      ipRules: []
    blobProperties:
      containerDeleteRetentionPolicy:
        days: 7
      deleteRetentionPolicy:
        days: 7
    location: "my_region"
    resourceGroupNameRef:
      name: "resource_group"
  providerConfigRef:
    name: workload-identity-provider-config

Steps to Reproduce
Create a storage account managed resource with an empty ipRules list.
What happened?
The entire ipRules parameter is removed from the spec, and I believe this means reconciliation will not check for drift for this config. When setting an empty list you want the list to be empty, however, resource drift will not be caught as the controller never sees this drift because the empty list is not in the desired state.
Relevant Error Output Snippet
no error message, just unwanted resource drift in Azure.

Crossplane Version
1.18
Provider Version
1.9.0
Kubernetes Version
1.30.5
Kubernetes Distribution
AKS
Additional Info
No response

I see this, which I suppose means that the list will not be included if empty.
https://github.com/crossplane-contrib/provider-upjet-azure/blob/1c2747024373a1374841630c2a7c063ad54f4dd1/apis/storage/v1beta2/zz_account_types.go#L1297

repo: crossplane-contrib/provider-upjet-azure


text:
[WebAPI] Fix lint error in webgl tests

Fix TRAILING WHITESPACE
sed -i 's/[ \t]*$//' /path/to/file
Fix INDENT TABS
sed -i 's/	/ /g' /path/to/file
Fix CR AT EOL
sed -i 's/\r/\n/g' /path/to/file

BUG=https://crosswalk-project.org/jira/browse/CTS-1692

@zqzhang , @Honry
Ptal, thanks a lot!

@zqzhang , @Honry
Ptal, thanks a lot!

Too many files changed in one PR to review, it's better to split it into two by test suite.

PTAL, thanks a lot~!

LGTM

authors: Honry renchenglei

repo: crosswalk-project/crosswalk-test-suite


text:
Refine destroy order in XWalkContent.java

BUG=XWALK-6840
XWalk would destroy contentViewRenderView first and then cleanupReference which points
other native object such as exitFullScreen, it will use contentViewRenderView
when in full screen. So app would cause crash. The correct behavior is that exit full
screen first and then destroy contentViewRenderView.

Your commit message contains zero information about why this is being done, it is all being explained only in the pull request message. "destroy" is being misspelled as "destory", and the call is actually called onDestroy.

LGTM.

@lincsoon @fujunwei @rakuco Please have a review, thanks!

authors: chuan9 fujunwei rakuco

repo: crosswalk-project/crosswalk


text:
[build] Remove disabling of c++0x for C files.

c++0x is enabled only for C++ after #454
BUG=XWALK-3678

lgtm, thanks

authors: Hagith rakuco


text:
License for plugin

Would you mind providing the license for this plugin as separate file checked into the repo e.g. LICENSE.txt or as part of the README.md file?

Done, added apache license file.

authors: bmuschko crotwell

repo: crotwell/gradle-macappbundle


text:
Can we predict without an Edge map?

Thank you for making such brilliant work publicly available.
Is it possible to predict using only WF images ?
The procedure is create an edge map using SRRF plugin is very confusing.

I tried to create edge map using napari-NanoPYX.
But without the right set of parameters, I will never be able to get it right.
Can you please provide the parameters you used ?

repo: crrayna/SFSRM


text:
Dates get returned twice

Hello, I have a calendar that send's some date params and they get sent twice, Any idea about what I am doing wrong?
here is an example, you will see the duplication in the console after the second selection, For some reason the first time you select its not duplicated.
http://codepen.io/rgbskills/pen/RKXqEa?editors=0010
Thank you very much in advance :)

Hi again :)
It seems to be this line
datepicker.maxSelections = 7;
i guess this modification calls the onSelect method which seems to be a bug!
Will look at it asap...
In the meantime you can just avoid setting maxSelections since it isn't necessary anyways

#14

authors: crsten rgbskills

repo: crsten/datepickk


text:
fix(cleanup): allow deletion to proceed without config map

Welcome to Cryostat! 👋
Before contributing, make sure you have:

[x] Read the contributing guidelines
[x] Linked a relevant issue which this PR resolves
[x] Linked any other relevant issues, PR's, or documentation, if any
[x] Resolved all conflicts, if any
[x] Rebased your branch PR on top of the latest upstream main branch
[x] Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
[x] Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #584
Description of the change:
The main change is to move the lock config map creation after handling the finalizer logic. The rest of the patch is additional test assurances that this doesn't break the name conflict handling introduced in #545.
Motivation for the change:
This fixes the namespace deletion bug that's present in 2.3.0.
How to manually test:
Ensure that deleting a conflicting CR doesn't delete/modify the original Cryostat installation:

Deploy operator into cryostat-operator-system

$ make deploy OPERATOR_IMG=quay.io/ebaron/cryostat-operator:namespace-del-fix-01

Create namespace c

$ kubectl create namespace c

Create Cryostat

apiVersion: operator.cryostat.io/v1beta1
kind: Cryostat
metadata:
  name: cryostat-sample
  namespace: c
spec:
  minimal: false
  enableCertManager: true
  reportOptions:
    replicas: 0

Create ClusterCryostat

apiVersion: operator.cryostat.io/v1beta1
kind: ClusterCryostat
metadata:
  name: cryostat-sample
spec:
  minimal: false
  enableCertManager: true
  installNamespace: c
  targetNamespaces:
  - c
  reportOptions:
    replicas: 0

Observe finalizer on ClusterCryostat

$ kubectl get clustercryostat cryostat-sample -o jsonpath='{.metadata.finalizers}'
["operator.cryostat.io/cryostat.finalizer"]

Delete ClusterCryostat

$ kubectl delete clustercryostat cryostat-sample

Check that ClusterRoleBinding and ConsoleLink were not deleted

$ kubectl get clusterrolebinding cryostat-22ca2798ad950a2953c096d484826501ddbae477d771250523c5523d9bd5a842
NAME                                                                        ROLE                                     AGE
cryostat-22ca2798ad950a2953c096d484826501ddbae477d771250523c5523d9bd5a842   ClusterRole/cryostat-operator-cryostat   46s
$ kubectl get consolelink cryostat-22ca2798ad950a2953c096d484826501ddbae477d771250523c5523d9bd5a842
NAME                                                                        TEXT       URL                                                                 MENU   AGE
cryostat-22ca2798ad950a2953c096d484826501ddbae477d771250523c5523d9bd5a842   Cryostat   https://cryostat-sample-cryostat-operator-system.apps.example.com          80s

Check that additionalCORSAllowedOrigins entry is still present in APIServer config:

$ kubectl get apiserver cluster -o jsonpath='{.spec.additionalCORSAllowedOrigins}'
["https://cryostat-sample-cryostat-operator-system\\.apps\\.example\\.com"]

Check that the namespace deletion bug is fixed:

Scale down the operator deployment

$ kubectl scale --replicas=0 deploy cryostat-operator-controller-manager
deployment.apps/cryostat-operator-controller-manager scaled

In another terminal, delete the namespace

$ kubectl delete namespace c
namespace "c" deleted
# hangs...

Scale the operator deployment back up

$ kubectl scale --replicas=1 deploy cryostat-operator-controller-manager
deployment.apps/cryostat-operator-controller-manager scaled

After some time, the namespace deletion proceeds

The main change is to move the lock config map creation after handling the finalizer logic.

I'm still trying to wrap my head around this because it seems like it should work, but it also seems like it could cause other issues to perform other logic before acquiring the lock. But, the test case worked as expected in crc too. In this case since the only other logic is either adding a finalizer or acting on the finalizer, that doesn't need mutex locking since it shouldn't cause conflicts elsewhere in the object graph. Maybe at worst you end up trying to delete the same object twice?

The objects that require finalizer logic should never conflict because of the following:

The ClusterRoleBinding and ConsoleLink have a prefix matching their Kind. For Cryostat the name is of the form cryostat-namespacedNameHash, for ClusterCryostat it's clustercryostat-namespacedNameHash.
The APIServer additionalCORSAllowedOrigins. This one uses the value of status.applicationURL from the CR to determine what to remove from the list of URLs. Since the lock config map creation occurs much before this field is set, only the first of the conflicting CRs can have this value set.

As for adding the finalizer to the CR, that's also fine since it only affects the CR itself and even CRs that fail to "acquire" the lock CR can still be finalized. The ClusterRoleBinding and ConsoleLink won't exist and there will be no URL to remove from the APIServer config. These would all be no-ops.

authors: andrewazores ebaron

repo: cryostatio/cryostat-operator


text:
Upgrade vm to be compatible with byzantium

Is your feature request related to a problem? Please describe.
It's better to follow the evm version.
Describe the solution you'd like
Update protocal version
Describe alternatives you've considered
Keep status quo
Additional context
cita-vm is based on the byzantium version.

Will use cita-vm.
It's another plan.

repo: cryptape/cita


text:
fix invalid link

conflict

conflict

什么意思

authors: ouwenkg zhouyun-zoe

repo: cryptape/citahub-docs


text:
Request settlement of bit asset

This needs to be added so that holders of bit assets can reliably convert their assets to BTS.

It really needed. What about having "Advanced" button and when users click the button, Borrow USD and Settlement USD are shown?

I think I need clarification here in order to UX this. Which screens are we talking about. Is this where we can settle up short positions?

I've added it as a modal, triggered by clicking on the Settle button that you can see in the background. I also rearranged the table a little cause I felt it fit better like that, but feel free to suggest another arrangement @wmbutler
Could probably use a bit of help text too.

authors: clayop svk31 wmbutler

repo: cryptonomex/graphene-ui


text:
Support for 4.06

The opam package for ocamllint requires ocaml-version < "4.04.0". Is this due to AST changes? Any chances an update is easy? I'd be willing to do the legwork if this repo is still active.

Any updates on making a new release with OMP? And 4.06 + 4.07 targets?

I think #25 was almost ready, not sure why I didn't finish the PR.

authors: XVilka baileyparker emillon

repo: cryptosense/ocamllint


text:
PCRE2 "fast path" API

Feature Request
Follow up to https://github.com/crystal-lang/crystal/issues/3852#issuecomment-943968239, currently regexes are compiled with JIT mode enabled, which provides a good boost in performance. However PCRE(2) also has another fast path API that avoids some sanity checks and can offer an additional 10%+ boost. E.g.
Crystal 1.8.0-dev [91d418738] (2023-03-03)

LLVM: 14.0.6
Default target: x86_64-pc-linux-gnu

$ ./bin/crystal run --release bench.cr
          starts_with?  15.97M ( 62.63ns) (± 3.00%)  0.0B/op   2.53× slower
              matches?  27.47M ( 36.40ns) (±11.41%)  0.0B/op   1.47× slower
fast path starts_with?  37.19M ( 26.89ns) (± 5.33%)  0.0B/op   1.09× slower
    fast path matches?  40.37M ( 24.77ns) (± 3.83%)  0.0B/op        fastest

The catch is not all regexes can be used in this context, or may even benefit from it, so it doesn't make sense to globally enable it like we did JIT mode.
It would be nice if there was some way to force a particular regex pattern to use this "fast path" API for cases where you know that pattern will be used a lot, or within a hot path. The first thought that come to mind is just some extra boolean ivar used to determine which method to call. Alternatively it could be added into the Regex::Options enum to allow regex literals to also be used. However, given this is somewhat related to #11320 in that it's PCRE(2) specific it may not ultimately be worth implementing, tho at least worth discussing.
WDYT?

I looked into what PHP does and they apparently use this by default that is if pcre.jit option is enabled, which it is by default, and the pattern was compiled successfully with a non-zero JIT size:
https://github.com/php/php-src/blob/43c71dfe52c4dda9ef971321995363b7e966b401/ext/pcre/php_pcre.c#L807-L828
I was a bit confused on how they got the PCRE2_ANCHORED option to work given the docs say its not supported at match time. I then noticed they're ONLY passing the NO_UTF_CHECK to jit_compile and realized I think it works for them because they don't have to deal with the notion of match time options since you have to pass the whole pattern which would be all defined at compile time.
So in short, it may be enough to just check the passed options in match_data and if they do not contain any unsupported options, use the fast path API, otherwise use the normal flow.

That could be a viable path to explore. However I'm not sure how much such an external match-time check differs from the checks in pcre2_match itself. But maybe there is something to gain. It certainly wouldn't hurt to try.
Under the premise that such a change can have subtle intricacies, I'd suggest to defer that until after the initial transition to PCRE2 is carried out (i.e. provisionally targeting the 1.9 or 1.10 release).

However I'm not sure how much such an external match-time check differs from the checks in pcre2_match itself.

In a simple benchmark I put together, quite a lot. Like up to 30% in some cases. The main reasoning is we're already passing the subject size, Crystal strings are already UTF-8, and Crystal strings are \0 terminated when passed to C libs. The latter two are things it checks for, probably among others. In the end its a drop in replacement to jit_match, bar needing to support the handful of unsupported match time options.
But yea, waiting a bit sounds good to me :+1:.

repo: crystal-lang/crystal


text:
Command 'crystal docs' provides unfriendly error message

Version:
Crystal 0.27.2 (2019-02-05)
LLVM: 6.0.1
Default target: x86_64-apple-macosx
Running 'crystal docs' in any Crystal project (or any other directory) outputs the following error:
  from Crystal::ASTNode+@Crystal::ASTNode#accept<Crystal::TopLevelVisitor>:Nil
  from Crystal::TopLevelVisitor#visit<Crystal::Expressions>:Bool
  from Crystal::ASTNode+@Crystal::ASTNode#accept<Crystal::TopLevelVisitor>:Nil
  from Crystal::Program#top_level_semantic<Crystal::ASTNode+>:Tuple(Crystal::ASTNode+, Crystal::TypeDeclarationProcessor)
  from Crystal::Compiler#top_level_semantic<Array(Crystal::Compiler::Source)>:Crystal::Compiler::Result
  from Crystal::Command#run:(Bool | Crystal::Compiler::Result | Nil)
  from __crystal_main
  from main
Caused by: can't find file './src/**' relative to '.' (Crystal::CrystalPath::Error)
  from Crystal::Program#find_in_path<String, (String | Nil)>:Array(String)
  from Crystal::ASTNode+@Crystal::ASTNode#accept<Crystal::TopLevelVisitor>:Nil
  from Crystal::TopLevelVisitor#visit<Crystal::Expressions>:Bool
  from Crystal::ASTNode+@Crystal::ASTNode#accept<Crystal::TopLevelVisitor>:Nil
  from Crystal::Program#top_level_semantic<Crystal::ASTNode+>:Tuple(Crystal::ASTNode+, Crystal::TypeDeclarationProcessor)
  from Crystal::Compiler#top_level_semantic<Array(Crystal::Compiler::Source)>:Crystal::Compiler::Result
  from Crystal::Command#run:(Bool | Crystal::Compiler::Result | Nil)
  from __crystal_main
  from main
Error: you've found a bug in the Crystal compiler. Please open an issue, including source code that will allow us to reproduce the bug: https://github.com/crystal-lang/crystal/issues```

Duplicate of #7385 , fixed in #7386

authors: asterite spencerking


text:
Reading from FiFo pipe blocks execution of other fibers

steps to reproduce:
create a pipe with
mkfifo piope
you can put stuff into the pipe from a different terminal with for example
cat > piope and if you use cat pipe to read the pipe, it works as expected. But the following Crystal program hangs, and never executes the second fiber.
f = File.open("piope","a+")
spawn do
  loop do
    f.gets
  end
end

spawn do
  puts "-"
  loop do
    puts "+"
    sleep(1)
  end
end

sleep()

Crystal version 0.30.1 on Debian testing

Somebody wants to try on master with and without MT? :)

I already did: the other fiber runs well with MT. But I think the pipe fiber shouldn't block. I debugged it and it seems the LibC.read call just hangs. But I know nothing about pipes to understand why that happens.

Can you try setting f.blocking = false? File.open currently opens the files in blocking mode since it makes no sense to use non-blocking for regular files (the calls to read/write are always blocking in POSIX).

Can you try setting f.blocking = false? File.open currently opens the files in blocking mode since it makes no sense to use non-blocking for regular files (the calls to read/write are always blocking in POSIX).

Yes, that does in fact make it work.
Thats not a bug after all then I guess?

@waj Is there a problem if we open files in non-blocking mode by default?

@asterite I was about to say no but then I found this commit: https://github.com/crystal-lang/crystal/commit/6943331da87c240c719d04fb8281f9b959586c38

@waj Is this is still an issue, 4 yrs l8r?

@Sija what do you mean by "this"? non-blocking IO for files? Standard IO operations over filesystem descriptors are always blocking, no matter what you do. They are always "ready" to read and write. To solve this maybe we should use aio APIs for files: http://man7.org/linux/man-pages/man7/aio.7.html

@waj By this I was referring to your commit comment (epoll raises warnings in Linux)

@waj Is this is still an issue, 4 yrs l8r?

I did not get any warnings when I add file.blocking = false.
This is on Kernel 5.2

@mavu Is that for the pipe or just for any regular files? I think the warning happened on regular files.

works for me with regular files too, but needs an additional sleep(1) in the first fiber after the f.gets or the output seems only to be the :yes from the first loop, but I think that is to be expected?

@mavu gets returns nil when it reaches the EOF, so you should break the loop in that case

Regarding this issue, I've been discussing with @asterite and we think that it would be great if Crystal sets the mode to non-blocking if the opened file is a FIFO (or any other fd type that can be used in non-blocking mode).
We could use fstat to check the type of file right after open and set the blocking mode accordingly.
One problem I found is that if "r" mode is used while opening the FIFO then the open call blocks until there is another process at the other end of the pipe. That behaviour seems to be quite difficult to mimic with non-blocking operations, because until open returns there is no fd to use in libevent (epoll and kevent). If O_NONBLOCK is used in the open call it returns immediately without waiting for a writer on the other end.
In other words we always try to make these APIs to behave like blocking from the fibers point of view but non-blocking for the entire process, but seems like it might not be possible for these.
Any ideas?

I would rather File could handle all file related cases but we could add a Pipe class for this.
Pipe.open("piope", "a+")

I just stumbled upon this, with something like File.open("/dev/tty", &.read_char) blocking the whole thread since files are always opened as blocking, even character devices (oops).
Since 2019 it seems that IO::FileDescriptor was changed to handle special files (sockets, pipes, character devices), but File still forces the blocking mode (oops). Passing blocking: nil instead of blocking: true in the File.new constructor fixes the issue for existing character devices (such as /dev/tty).
Yet, trying to open a FIFO file stills block the whole thread, because open(2) blocks until there is another thread/process that also opened the file for read/write.
To fix the problem, we'd need to open the file with O_NONBLOCK directly, and can't delay the decision to after we called open(2). The difficulty is that the file doesn't necessarily exist beforehand.

authors: Sija asterite jhass mavu waj wontruefree ysbaddaden


text:
Add method to get an array of types a module is included in

module Foo
end

module Baz
  module Tar
    include Baz
  end
end

abstract class Parent
end

class Bar < Parent
  include Foo
  include Baz
end

struct Str
  include Baz
end

struct Gen(T)
  include Baz
end

abstract struct AStr
  include Baz
end

abstract class ACla
  include Baz
end

class SubT(T)
  include Baz
end

class ChildT(T) < SubT(T)
end

{{Baz.all_includers.map &.name.stringify}} # => ["Baz::Tar", "Bar", "Str", "Gen(T)", "AStr", "ACla", "SubT(T)"]

Questions:

~How do I test this?~
~Are there any other types that can include a module i should try?~
~Any other ideas for a better name?~

I also noticed that types with generics include the generic type vars in their name.  I would have thought Gen(T) would have just been Gen...not sure if this is intended or not.
EDIT:  I added it to macros.cr, will include that in feedback fixes.

Awesome. this will be quite useful if merged. I cant think of anything off the top of my head that also includes modules.

idea: you could make a macro that generates a bunch of arbitrary modules to test

Any use case for this?

Mainly as a compliment to #subclassess.  ATM only way to get an array of types is using that.  This allows for using modules to achieve a similar effect if inheritance isn't the best solution.
Ref https://forum.crystal-lang.org/t/type-all-includers/254

How well does this work with querying generic modules?

@RX14 Seems to work fine.
module Bar(T)
end

module Foo
  include Bar(String)
end

module Baz
  include Bar(Bool)
end

{{Bar.all_includers.map &.name.stringify}} # => ["Foo", "Baz"]

I think the main issue is what happens if a module is included by a generic type. It's probably the same issue we have with subclasses. That's why I'm not sure how and whether this should be added to the macro methods.

module Bar(T)
end

class Test(T)
  include Bar(T)
end

{{Bar.all_includers.map &.name.stringify}} # => ["Test(T)"]

Is what seems to happen.  Same thing as #subclasses.

module Bar(T)
end

class Test(T)
  include Bar(T)
end

{{Bar.all_includers.map &.name.stringify}} # => ["Test(T)"]

Is what seems to happen. Same thing as #subclasses.

I think this is acceptable behavior.

Anything left to do here?

Bump, this should be good to review.

Also FWIW, https://github.com/crystal-lang/crystal/pull/8483 will allow you to skip the generic type vars of the module (for both this and #subclasses/#all_subclasses (ref: https://github.com/crystal-lang/crystal/pull/8133#issuecomment-529950943)

@asterite @RX14 @bcardiff Anyone able to do another review of this?  Would be :100: if this could make it into 0.32.0.

I want ary or brian to sign off on this.

After working with this locally a bit I'm starting to think I should rename it to #includers, since this only returns types that directly include the module, not children of those types.
I'll push that tonight.

@asterite @bcardiff Bump


text:
Modify !ta plug in for professor role

add professor role for this plugin.

I work on this sometime this week now that I know how to use the DB, gonna overhaul the TA plugin

authors: curtishelsel tanndlin

repo: cs-discord-at-ucf/lion


text:
Feature/update models

References #228
This branch implements adding request models and updating the device model to have c# object types instead of using bson types. This is done in preparation for the storage provider changes to make the integration easier as well as to make the backend easier to work with in general.

Are you planning on merging this in to the feature, and then merging it in with the other pr?

Are you planning on merging this in to the feature, and then merging it in with the other pr?

I'm planning on abandoning the other pr. It will stay up until all its pieces are implemented and then it will be closed without merging it in.

Are you planning on merging this in to the feature, and then merging it in with the other pr?

I'm planning on abandoning the other pr. It will stay up until all its pieces are implemented and then it will be closed without merging it in.

Ok, I've actually made a PR that is branching from your original PR, which is why I'm concerned.

Are you planning on merging this in to the feature, and then merging it in with the other pr?

I'm planning on abandoning the other pr. It will stay up until all its pieces are implemented and then it will be closed without merging it in.

Ok, I've actually made a PR that is branching from your original PR, which is why I'm concerned. I think it might be ok to just continue on your other PR.

In that case I think we can first merge my sub pr-s into feature/s2, merge your's into #228, and then merge feature/s2 into #228. Finally merge #228 back into feature/s2


text:
Euclidean space and multidimensional Lebesgue

Second attempt at this PR, I had a problem with my fork so I started again

Also, we need to add
Static = "0.3"

near this line:
https://github.com/cscherrer/MeasureTheory.jl/blob/9e59beb75d36b909a1a99ab942117523b0ad4800/Project.toml#L45

Sorry, I mistakenly put both the gamma dist and the euclidean space in the PR. Still new at open source :innocent:

Sorry, I mistakenly put both the gamma dist and the euclidean space in the PR. Still new at open source innocent

Haha yeah I saw that. It's ok, we don't need to be to picky, especially when the changes are mostly localized like this. :)

authors: cscherrer gdalle


text:
Button Recipe Incorrect

The Button Recipe does not work from the example: https://park-ui.com/docs/panda/components/button
A number of the styling values come out as "invalid values", such as borderRadius as L2. Should that not be an integer + "px" value?

This is the expected result

This is the actual result

This is the copy and pasted recipe from the example
import { defineRecipe } from '@pandacss/dev'

export const button = defineRecipe({
  className: 'button',
  base: {
    alignItems: 'center',
    appearance: 'none',
    borderRadius: 'l2',
    cursor: 'pointer',
    display: 'inline-flex',
    fontWeight: 'semibold',
    minWidth: '0',
    justifyContent: 'center',
    outline: 'none',
    transitionDuration: 'normal',
    transitionProperty: 'background, border-color, color, box-shadow',
    transitionTimingFunction: 'default',
    userSelect: 'none',
    verticalAlign: 'middle',
    whiteSpace: 'nowrap',
    _hidden: {
      display: 'none',
    },
  },
  defaultVariants: {
    variant: 'solid',
    size: 'md',
  },
  variants: {
    variant: {
      solid: {
        background: 'accent.default',
        color: 'accent.fg',
        _hover: {
          background: 'accent.emphasized',
        },
        _focusVisible: {
          outlineOffset: '2px',
          outline: '2px solid',
          outlineColor: 'border.accent',
        },
        _disabled: {
          color: 'fg.disabled',
          background: 'gray.a3',
          cursor: 'not-allowed',
          _hover: {
            color: 'fg.disabled',
            background: 'gray.a3',
          },
        },
      },
      outline: {
        borderWidth: '1px',
        borderColor: 'border.default',
        _hover: {
          background: 'gray.a2',
        },
        _disabled: {
          borderColor: 'border.disabled',
          color: 'fg.disabled',
          cursor: 'not-allowed',
          _hover: {
            background: 'transparent',
            borderColor: 'border.disabled',
            color: 'fg.disabled',
          },
        },
        _focusVisible: {
          outlineOffset: '2px',
          outline: '2px solid',
          outlineColor: 'border.outline',
        },
        _selected: {
          background: 'gray.a3',
        },
      },
      ghost: {
        color: 'fg.default',
        _hover: {
          background: 'gray.a3',
        },
        _selected: {
          background: 'gray.a3',
        },
        _disabled: {
          color: 'fg.disabled',
          cursor: 'not-allowed',
          _hover: {
            background: 'transparent',
            color: 'fg.disabled',
          },
        },
        _focusVisible: {
          outline: '2px solid',
          outlineColor: 'border.outline',
        },
      },
      link: {
        verticalAlign: 'baseline',
        _disabled: {
          color: 'border.disabled',
          cursor: 'not-allowed',
          _hover: {
            color: 'border.disabled',
          },
        },
        height: 'auto!',
        px: '0!',
        minW: '0!',
      },
    },
    size: {
      xs: {
        h: '8',
        minW: '8',
        textStyle: 'xs',
        px: '3',
        gap: '2',
        '& svg': {
          fontSize: 'md',
          width: '4',
          height: '4',
        },
      },
      sm: {
        h: '9',
        minW: '9',
        textStyle: 'sm',
        px: '3.5',
        gap: '2',
        '& svg': {
          width: '4',
          height: '4',
        },
      },
      md: {
        h: '10',
        minW: '10',
        textStyle: 'sm',
        px: '4',
        gap: '2',
        '& svg': {
          width: '5',
          height: '5',
        },
      },
      lg: {
        h: '11',
        minW: '11',
        textStyle: 'md',
        px: '4.5',
        gap: '2',
        '& svg': {
          width: '5',
          height: '5',
        },
      },
      xl: {
        h: '12',
        minW: '12',
        textStyle: 'md',
        px: '5',
        gap: '2.5',
        '& svg': {
          width: '5',
          height: '5',
        },
      },
      '2xl': {
        h: '16',
        minW: '16',
        textStyle: 'lg',
        px: '7',
        gap: '3',
        '& svg': {
          width: '6',
          height: '6',
        },
      },
    },
  },
})

I did not do the installation. https://park-ui.com/docs/panda/overview/getting-started

repo: cschroeter/park-ui


text:
Fix issue allowing circumvention of security checks

An issue allowed students to create a custom ClassLoader and load raw bytecode. This code could then circumvent all static and dynamic security checks.

LGTM!!
Maurício Aniche
Author of Effective Software Testing: A Developer's Guide
https://www.effective-software-testing.com
https://www.mauricioaniche.com
On Mon, Dec 26, 2022 at 7:12 PM Martin Mladenov @.***>
wrote:

@martinmladenov https://github.com/martinmladenov requested your review
on: #151 https://github.com/cse1110/andy/pull/151 Fix issue allowing
circumvention of security checks.
—
Reply to this email directly, view it on GitHub
https://github.com/cse1110/andy/pull/151#event-8112193667, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAYTTHGXSI2M6UVCH4B7H3WPHNZ7ANCNFSM6AAAAAATJZ4H4A
.
You are receiving this because your review was requested.Message ID:
@.***>

authors: martinmladenov mauricioaniche


text:
New release?

We had to drop this library from package-sets due to it using an old version of sized-vectors.
I see that it has been updated to the latest, so I think cutting a new release should be enough to add it again to the set. I'll hold off for some days before tagging a new package set release, so there's some time to add it back there without breaking changes for downstream users

Good point. I've created a new release and pushed it to GH and bower.
The version is v1.0.0

@csicar thank you!

authors: csicar f-f

repo: csicar/purescript-sized-matrices


text:
Show Jenkins status

Based on the pull https://github.com/cgoncas/arquillian-extension-liferay/pull/17 by @mdelapenya

Just started reviewing :) :octocat: Sent from GH.

authors: cgoncas csierra

repo: csierra/arquillian-extension-liferay


text:
Create section and segments page and component

Lo-fi wireframes

Refer to Section & Segments panel on Admin lofi wireframes, and create section component.
Reminder that we're using Chakra's UI kit! Here's their documentation.

Hi @janehvo, this is Jaedyn. I see that I was assigned this task on the sprint sheet. Could you assign it to me in github as well? Thanks!

/cib section and segments page and component

Branch 11-section-and-segments-page-and-component created!

authors: astraljdc ctc-devops janehvo parsakmt

repo: ctc-uci/oc-habitats-frontend


text:
#1432 导致我的配置流程失效

我看一些人会需要 apollo 配置能覆盖本地的，并且在最新版本中还“修复”了这个问题。
但其实我一直在利用这个特性来实现本地开发修改隔离，方便开发时开发人员自行修改，如果使用 -D 毕竟不是那么方便，本地配置可能很多。只要打包的时候将这个本地配置剔除出去就行了，线上所有配置还走 apollo 即可。结果 1.1 改策略之后我本地就不能覆盖远程配置了，希望能提供一种选项能退回之前方式，或者你们有什么最佳实践分享一下？

本地开发可以使用本地开发模式。
不建议在项目中通过配置文件覆盖，因为比较容易把本地配置文件误提交到远端仓库。

我确实把本地开发模式给忘了，一直没用过。
不过您说的误提交，

如果是指提交到远程仓库之后会导致其余环境下 apollo 的配置也会被覆盖的话，并不会。
如果是指提交到远程仓库后会导致干扰其它的人本地配置的话，确实是，但本地开发模式也有同样的问题，这种事情无法避免。
本地开发模式倒是能解决，但问题是一大坨配置又塞到源码里面了，原本只需要“继承” apollo 的绝大部分配置，需要修改的地方手动覆盖即可（与你们的 public ns 思路一致），现在则变成了本地配置与 apollo 不能并存，本地想要修改，就不能用 apollo，这是不是不太合适呢？

可以有个增加一个dev环境，数据取自本地文件，不提交到后端，那样就可以相互隔离了。
发自我的 iPhone

在 2018年10月13日，11:10，hexinzhe notifications@github.com 写道：
我确实把本地开发模式给忘了，一直没用过。
不过您说的误提交，
如果是指提交到远程仓库之后会导致其余环境下 apollo 的配置也会被覆盖的话，并不会。
如果是指提交到远程仓库后会导致干扰其它的人本地配置的话，确实是，但本地开发模式也有同样的问题，这种事情无法避免。
本地开发模式倒是能解决，但问题是一大坨配置又塞到源码里面了，原本只需要“继承” apollo 的绝大部分配置，需要修改的地方手动覆盖即可（与你们的 public ns 思路一致），现在则变成了本地配置与 apollo 不能并存，本地想要修改，就不能用 apollo，这是不是不太合适呢？
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@qmwu2000 不太明白，我的意思是本地开发模式不能复用 apollo 的配置，没有想要完全隔离呀

@hexinzhe
我指的误提交是指代码中的配置文件如果优先级高于apollo，那么一旦这些文件随代码提交之后，在实际运行的时候就会生效，从而导致问题。
所以，对于本地开发的临时配置，一般是通过其它外部化的方式解决，比如-D参数，比如本地模式中的本地配置文件等，这类方式杜绝了本地配置错误随代码提交的可能。
还有一种方式是每个开发都在apollo上创建一个集群，然后本地server.properties中指定idc=对应的集群名字，也能实现开发之间互不影响。

ok，明白，我也看到之前有别人提到这个问题，但是这种情况很好解决，这个配置文件不打到包里就行了，不管是配置 maven 生命周期还是配置 ci 流程都好办，并且还是个一劳永逸的操作。如果因此就在本地禁止 apollo，好像有点因噎废食吧。
至于您说的方法，是可以解决我说的问题，但也过于麻烦了。相比之下可能还不如本地开发模式来的方便。
所以我还是倾向于继续应用我原本这种方式。

没毛病，多引了一个 namespaces：apollo.bootstrap.namespaces=application-dev,application，然后 pom 里面添加一个复制任务
<copy todir="${project.build.outputDirectory}/META-INF/config/">
    <fileset dir="${project.build.outputDirectory}/">
        <include name="application-dev.properties"/>
     </fileset>
 </copy>

就可以了。

多谢各位了

authors: hexinzhe nobodyiam qmwu2000

repo: ctripcorp/apollo


text:
是否考虑开放所有对应接口，使得能在界面上完成的动作，都可以通过程序完成

我们在进行devops的开发，所有的环境通过cmdb、docker自动化生成、销毁，但是每个环境产生的访问地址，资源密码等等都会有所不同，需要能够通过程序自动化完成，手工维护的效率太低。大部分的接口都有，就是生成集群环境的，可以考虑增加进去，最大限度开放掉

这是个值得考虑的建议，目前apollo的openapi也是部分实现了自动化的能力。不过完全开放所有接口，通过程序完成所有的操作，对于大部分apollo的用户而言价值并不大，所以如确有实际需求的话，欢迎提交PR。

authors: kinsight nobodyiam


text:
Spring Security简单认证改造问题

背景：
公司大部分都是业务人员，不想接入SSO，直接用Spring Security简单认证，但是这个登录只有管理员可以修改用户信息，希望普通用户登录后可以自己修改个人信息；
改造：
1、修改static/views/common/nav.html
用户退出：
{{'Common.Nav.Logout' | translate }}
下增加：
{{'Common.Nav.UserManage' | translate }}
user-manage-comm.html 直接拷贝的 user-manage.html
2、修改 static/scripts/services/UserService.js，增加 update_comm_user
appService.service('UserService', ['$resource', '$q', function ($resource, $q) {
var user_resource = $resource('', {}, {
load_user: {
method: 'GET',
url: '/user'
},
find_users: {
method: 'GET',
url: '/users'
},
create_or_update_user: {
method: 'POST',
url: '/users'
},
update_comm_user: {
method: 'POST',
url: '/userscomm'
}
});
return {
load_user: function () {
var finished = false;
var d = $q.defer();
user_resource.load_user({},
function (result) {
finished = true;
d.resolve(result);
},
function (result) {
finished = true;
d.reject(result);
});
return d.promise;
},
find_users: function (keyword) {
var d = $q.defer();
user_resource.find_users({
keyword: keyword
},
function (result) {
d.resolve(result);
},
function (result) {
d.reject(result);
});
return d.promise;
},
createOrUpdateUser: function (user) {
var d = $q.defer();
user_resource.create_or_update_user({}, user,
function (result) {
d.resolve(result);
},
function (result) {
d.reject(result);
});
return d.promise;
},
updateCommUser: function (user) {
var d = $q.defer();
user_resource.update_comm_user({}, user,
function (result) {
d.resolve(result);
},
function (result) {
d.reject(result);
});
return d.promise;
}
}
}]);
3、修改 com/ctrip/framework/apollo/portal/spi/springsecurity/SpringSecurityUserService.java，增加
@Transactional
public void updateComm(UserPO user) {
String username = user.getUsername();
User userDetails = new User(username, encoder.encode(user.getPassword()), authorities);

if (userDetailsManager.userExists(username)) {
  userDetailsManager.updateUser(userDetails);
  UserPO managedUser = userRepository.findByUsername(username);
  managedUser.setEmail(user.getEmail());

  userRepository.save(managedUser);
}

}
4、修改 com/ctrip/framework/apollo/portal/controller/UserInfoController.java 增加
@PostMapping("/userscomm")
public void updateCommUser(@RequestBody UserPO user) {
if (StringUtils.isContainEmpty(user.getUsername(), user.getPassword())) {
throw new BadRequestException("Username and password can not be empty.");
}
if (userService instanceof SpringSecurityUserService) {
  ((SpringSecurityUserService) userService).updateComm(user);
} else {
  throw new UnsupportedOperationException("Create or update user operation is unsupported");
}

}
5、经过上面步骤，此时普通用户可以修改用户信息，但是希望只能修改自己的信息，所以希望用户名文本框是带回回显只读，并绑定user.username，但是 directive  导入的userName无法赋值，文本框是空值，自己写的例子可以，但是apollo工程中修改/user-manage-comm.html 用户名文本框就不行。
方法一：
修改 /user-manage-comm.html

或

方法二：
修改 /user-manage-comm.html

修改 static/scripts/controller/UserController.js
$scope.user={}   改为 $scope.user={"username":$scope.userName};
6、将上面方法二
修改 static/scripts/controller/UserController.js
$scope.user={}   改为 $scope.user={"username":"zhangsan"};
这样文本框可以回显
请各位指教。

上面说的两种方式的测试


text:
加载自定义的本地配置

我看了一下 defaultConfig，可以加载 resource文件。
但是业务上还不能满足我的想法，我想修改下defaultconfig的加载方法 来达到我的目的，
有没有办法不修改源代码完成呢？

第一种方法是实现自己的spi，实现自己的ConfigFactory，这样就可以注入自己的Config实现。
第二种方式适用于使用Spring的情况，Apollo本身是作为Spring的一个Property Source的，你也可以把自己本地的配置作为一个Property Source插入到Spring里面。

感谢

authors: fenghlkevin nobodyiam


text:
Polymer build fails

module.js:549
    throw err;
    ^

Error: Cannot find module 'babel-core'
    at Function.Module._resolveFilename (module.js:547:15)
    at Function.Module._load (module.js:474:25)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/work/platform-doc/polymer-build/node_modules/polymer-build/lib/optimize-streams.js:16:22)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)

https://github.com/Polymer/polymer-build/issues/305

repo: cuba-platform/documentation


text:
To-Do Tasks for Static Groups

Overall Sketch for the Dates/Goals of this Project
Compiler Tasks

Finish the static-inlining stuff by 5/1. This will allow us to compile the "static islands" into a single static group, which can then be turned into a dynamic group using the compile-static pass we've already created.
Giving the static-inlining more opportunities to work. This includes: a) "group promotion": inferring the static latency of dynamic groups and turning them into static groups. b) "control promotion": turning dynamic control operators that contain static groups into static control operators. E.g., seq { static_foo; static_bar; dyn_baz } to seq { static seq { static_foo; static_bar }; dyn_baz }. c) "control rearrangement" rearranging the control operators to improve the hardware (e.g., something like static-par-conv or merge-static-par. We should think about if these will actually be helpful for the static inlining + compile static pass, though.
Allow other passes to use static information to improve: e.g., live range analysis & sharing can use static information.
Potential new passes: "auto parallelization". Potentially instantiate new hardware in order to find increased parallelization opportunities in the design. register-unsharing pass can be a helpful starting point.
Frontend Tasks
CIRCT
Other potential frontends: PolySA, HeteroCL, SpMV.
We should probably work on the frontends after we've done the basics of the static compilation and optimizations (static inlining, group + control promotion) but before we do the more advanced optimizations (e..g, "auto-parllalization).

CONCRETE TO-DOS
A tracker for the "to-do" tasks for Static Groups. Some are definitely bigger than others, and we should probably add issues as they come up. Right now, this is just a preliminary list. @paili0628 feel free to add more in case I forgot any.
Note that much of the existing code will break once we turn the assignments field of static groups from assignments type -> static_assignment type, which is something we are keeping in mind.
Shorter Term (to do once we get the IR fully formed)

[ ] Passes that visit Enables might want to visit StatcEnables. This is a case by case basis, but some of the passes that apply operations to groups should apply them to static groups as well
[x] There is some code duplication in LiveRangeAnalysis, Well Formed, and Reaching Definitions. Once we get the IR fully figured out, we should figure out the best way to reduce this duplicate code.
[x] Add a latency field for static groups
[x] Rewrite the MergeStaticPar and StaticParConv passes to operate on static groups (once we have defined latency fields). Also, CollapseControl should work on static pars/seqs.
[ ] group2invoke should handle static groups. But we first need to define StaticInvoke + other static control in the IR.
[x] group2seq is weird w/ static groups. How do we infer the latency of the split groups? We can leave it to infer-static-timing, but then, would that mean turning the static groups into 2 non-static groups?...
[ ] Possibly create aliases for Guard<StaticTiming> into something like StaticGuard, Assignment<StaticTiming> into StaticAssignment.
[ ] Turn Nothing into (). The main thing is getting pretty printing right.
[ ] compute_static should be fundamentally changed to turn regular control into static control when possible. Rn it just adds attributes, but we want to do more ideally.

Longer Term (to do once we implement static groups correctly)

[ ] Python Library (and other frontends) should be rewritten
[x] We should change infer-static-timing to change groups -> static groups, instead of adding an attribute

I have another task but I'm not sure if it's short term or long term? The compile-sync pass does not take in static control now. We need to figure out what type of synchronization we want for static control.

Ah, that makes sense!! Cool!!!

group2seq is weird w/ static groups. How do we infer the latency of the split groups? We can leave it to infer-static-timing, but then, would that mean turning the static groups into 2 non-static groups?...

We've decided to not split apart static groups since its just the inverse transform of static inline

Once we're done with the Static groups milestone, we'll go over this again and create issues from all the relevant bullet points and close this tracker

@calebmkim @paili0628 can y'all go over this and update it?

authors: calebmkim paili0628 rachitnigam sampsyo

repo: cucapra/calyx


text:
Document how to build the interactive playground

🤔 What's changed?
I've documented how to build and run a local instance of the interactive playground
I've also added the build to CI
⚡ What's your motivation?
We want to make sure it doesn't break, and that it's rebuilt with the latest dependency upgrades whenever we release.
🏷 What kind of change is this?

:bank: Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

It's failing on Windows - I think we need to use cross-env, or just not run build:try on windows...

repo: cucumber/cucumber-expressions


text:
[react] Fix storybook issue

Summary
After the upgrade to Storybook 6, it was not possible to render the <FilteredResults> component anymore in StoryBook (and potentially other stuff were broken, like the html-formatter). This should be fixed by now.
To be honest, I still don't get why I had to change:
constructor(private readonly gherkinQuery: GherkinQuery) {}

to
private readonly gherkinQuery: GherkinQuery

constructor(gherkinQuery: GherkinQuery) {
   this.gherkinQuery = gherkinQuery
 }

as both syntax are supposed to be equivalent. But with the original (and shorter) syntax, GherkinQuery was getting undefined in the TagSearch object ...
I also updated the acceptance test we have to be more realistic, so:

it uses <FilteredResults> as the rendered component (like html-formatterdoes)
it does not "share"  gherkin query with fake-cucumber. We now render all the messages in a separate function and feed that to the different queries (once again, like what we do in html-formatter)

Details

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

[ ] The change has been ported to Java.
[ ] The change has been ported to Ruby.
[x] The change has been ported to JavaScript.
[ ] The change has been ported to Go.
[ ] The change has been ported to .NET.
[ ] I've added tests for my code.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have updated the CHANGELOG accordingly.

@vincent-psarga you might be able to find a workaround in https://github.com/storybookjs/storybook/issues/11255

I think this one is outdated - storybook seems to be working fine now.

authors: aslakhellesoy vincent-psarga

repo: cucumber/cucumber


text:
gherkin/java:Support unicode colon as separator.

Summary
Support unicode fullwidth colon as title separator.
Details

Motivation and Context

i18n not only keyword translate,but also punctuate。
Why only colon?because it is title line separator, no syntax meaning.
Original issue post here :https://github.com/cucumber/gherkin/issues/220
How Has This Been Tested?
The change not break exists test.
New test case add in ParserTest.java

Types of changes

[x] Bug fix (non-breaking change which fixes an issue).

Checklist:

[x] I've added tests for my code.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Thanks! Can you please add tests using the new separator?

@aslakhellesoy Is this mergeable? It looks cool.

All other implementations must be updated with the same change before this is mergeable.
In order to reduce duplication in tests, please delete the unit test and add an acceptance test in /gherkin/testdata/good instead.

Done.

matchTitleLine or startsWithTitleKeyword need refactor , because matchTitleLine use separator.length()

How to sync changes in other languages

This PR has gone stale in the light of #425. If you still want this, please make a PR against the gherkin/go codebase.

authors: aslakhellesoy lxbzmy olleolleolle