text:
Add ES8/ES2017 target

Hi there,
please consider this as a start for es8/es2017 target. Fixes #10768.

Hi @andrejbaran, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

thanks @andrejbaran for the contribution. a few comments. also cc @rbuckton

In theory trailing commas should also be preserved in the output for fidelity with target: es2017. Is that being too pedantic? I can't imagine any scenarios where it would matter.

In theory trailing commas should also be preserved in the output for fidelity with target: es2017. Is that being too pedantic? I can't imagine any scenarios where it would matter.

yes, but the implementation today would make this a bit hard to achieve, not sure if there is much value though.

I can't imagine any scenarios where it would matter.

Thinking about it more, at least one scenario comes to mind: ES feature detection. Not sure how useful that is in practice (NB the linked repo has 0 stars). Probably safe to ignore until someone raises an actual issue.

Thanks for the review @mhegazy i'll get back to it tonight and will let you know

@mhegazy It turned out to be little more complicated than I anticipated, please review again. I have also renamed es7 to es2016 for consistency? (maybe es6 should be renamed too, dunno but I believe es2015 is preferred)

@mhegazy @rbuckton @sandersn Review the changes pls. I also made the change from ES6 -> ES2015 through out the code so the naming scheme for ES versions is as consistent as possible. Let me know if that's not desired as I realise it's not the purpose of this PR, but since this PR kind of kicked off the consolidation I went for all in. Again let me know if you're not ok with it (since it's quite a big change)

@rbuckton any comments?

I concur with @sandersn that there are a number of unnecessarily duplicated tests. I need to go through them to see which ones are unneeded. Other than that, :+1:

@sandersn @rbuckton sorry about that,  I thought it would be good to have them for es2017, but didn't find time to dig deeper.

@rbuckton done

thanks @andrejbaran! waiting on the travis, it has been 🐌 sloooow 🐌 today

Travis CI looks to be running behind. Once the build passes I'll merge the pull request. Thanks @andrejbaran for the contribution!

@andrejbaran My appologies, can you take a look at the merge conflict?

@rbuckton should be ok now

Many thanks guys!

authors: andrejbaran mhegazy msftclas rbuckton yortus


text:
Don't emit an empty template head literal if there's a template span with a non-empty literal.

Fixes #1570

Great work @Arnavion! I'm going to sign off :+1:.
@mhegazy should make the final call on this.

:+1:

Thanks!
@DanielRosenwasser @mhegazy Any chance of getting this and #1577 in 1.4 too?

Unfortunately not, we're almost converged on 1.4, but I expect 1.5 to be released soon after anyway.

@DanielRosenwasser Seems this was force-pushed out of master?

This is bad. Let me try to resolve the issue.

@Arnavion should be fixed now.

@DanielRosenwasser Just noticed release-1.4 was also force-pushed back from ead4625 to ae0caed Every other branch is fine AFAICT

Thanks so much for catching that! I'll take care of that immediately.

source: gharchive/pull-request

authors: Arnavion DanielRosenwasser mhegazy

repo: Microsoft/TypeScript

license_type: permissive

license_source: github-api


text:
Linking .so in VS on WSL with Ubuntu

I tried linking a dynamic lib, as one would usually do on Windows, but it doesn't work. The lib files are in the project folder.
So I'm thinking, should I specify the paths as accessing from WSL, or what should I do ?

This is not WSL actionable and there were no takers on the question.

source: gharchive/issue

authors: Eichenherz therealkenc

repo: Microsoft/WSL

license: MIT


text:
Update active-directory-accessmanagement-groups-with-advanced-rules.md

Updated to reflect license requirements

Hi @RobdeJong, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Rob de Jong). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@RobdeJong : Thanks for your contribution to the Azure documentation! The author, @curtand, has been notified to review your proposed change.

#sign-off

authors: PRmerger RobdeJong curtand msftclas

repo: Microsoft/azure-docs


text:
PublishCodeCoverageResults should support .coverage files

Environment

Server - Azure Pipelines

Issue Description
The PublishCodeCoverageResults task does not currently support Visual Studio .coverage files. I use Cake Build instead of the built in tasks and want to use PublishCodeCoverageResults to publish my code coverage results.

A thousand times yes! This issue was raised before and never made sense to me. VSTest task somehow manages to publish .coverage files that VSTS understands - so we should be able to do it as well!

authors: RehanSaeed xenalite

repo: Microsoft/azure-pipelines-tasks


text:
bump version and cleanup readme

@yungez @yaweiw

@ZhijunZhao,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

authors: ZhijunZhao msftclas

repo: Microsoft/azure-spring-boot


text:
Create multiple mscorlib repro in IL instead of cs

This repro is complicated in CS and requires a build machine with VS 2013 to build correctly. Encoding the multiple mscorlib in IL simplifies this greatly.

LGTM

@mjrousos I added a ps1 script to rebuild all the IL so those not sure how to use ilasm can see how to do it for the repros. Is it true that ilasm is not deterministic? I can't find that documented, but it always produces different results, so I added that as a note in there.

@mmitche We're seeing build failures on OSX CI builds - is this a known issue (both active PRs are hitting this on this repo)

@twsouthwick Yeah.  the lab where the OSX machines is located has some failing hardware that needs replacement.  There is no ETA on a fix at the moment.

thanks @mmitche . We'll ignore them for now, then

Also, @twsouthwick, regarding the different the non-deterministic ilasm output, this is expected. PE files include a 4-byte timestamp in their header indicating when the file was created. Whenever we re-create the assemblies, that will be different. The rest of the file should be unchanged.

authors: mjrousos mmitche twsouthwick

repo: Microsoft/dotnet-apiport

license: mit

license_source: bigquery


text:
Allow specifying app os, platform and display name for automated creation

Added following optional parameters
app_display_name(if not specified, will use app_name value as default)
app_os
app_platform
If this parameters specified, upload action will automatically create new app if it was not found without prompting user.
This will simplify plugin usage in CI environments.
Closes #58
Demo:
appcenter_upload(
  api_token: ENV["TEST_APPCENTER_API_TOKEN"],
  owner_name: ENV["TEST_APPCENTER_OWNER_NAME"],
  app_name: "my-new-app-center-app",
  app_display_name: "My New App Center App",
  app_os: "Android",
  app_platform: "Java",
  apk: "./fastlane/app-release.apk"
)

Output:

it doesn't create an app if it was found

@jphenow Yes it is covered. In all test cases where it is assumed that an application is found, there is no stub for creating an application request - therefore, if it is caused, the test fails due to an unregistered request

repo: Microsoft/fastlane-plugin-appcenter


text:
Application Insights in code

Description
Rather than relying on App Service's Application Insights support (which does not yet support asp.net core 2.2), we App Insights directly from code, passing in the instrumentation key as a config setting.
Related issues
Addresses #368
Testing
Verified telemetry is flowing.

I would propose adding this to Startup.cs instead:
services.AddApplicationInsightsTelemetry(Configuration);

Apparently user secrets are not read by UseApplicationInsights(), https://github.com/Microsoft/ApplicationInsights-aspnetcore/issues/695

authors: hansenms johnstairs

repo: Microsoft/fhir-server


text:
complete rewrite of the traversal approach

Change to use explicit "maps" rather than trying to come up with some algorithm.  Maps are really traversal graphs that filter the edges that can be traversed

Explicit is good and easy.  You can look at a map and just know what it will do.
Can handle basically infinite complexity in traversal patterns.  One can start with a basic map and then tweak nodes as needed.
still allows some programmatic control.  Nodes in the map can be functions
reference maps by name and scenario so the user experience is still declarative
removed some concepts (e.g., relationship, transitivity types) that were particularly mind bending

Downsides

Explicit route enumeration is boring.  Some helper functions.  More could be done.
Brittle (more and less). If a new entity type is added, all the maps need to be updated.  Tedious but at the same time, good as the new entity may introduce cycles or some strangeness.

Hi @jeffmcaffer, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Jeff McAffer). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

authors: jeffmcaffer msftclas

repo: Microsoft/ghcrawler


text:
How to setup ripple?

Hey, I'd like to use ripple in my project at HAMK university of applied sciences, but it seems that the .zip doesn't include the .exe file for installation, how do I install it otherwise?
Thanks in advance!

This is the source code of ripple ,you have to build the project to use it , you must install required K4W SDK to get started.
In  case you just need an exe and want to build on top of that , let me know your requirements and we can discuss this over a skype call.

The documentation folder contains a video file showing the installer file. I am searching for the same but unable to find it anywhere.

You have to build the project and you can get Ripple executables.
On Wed, Mar 9, 2016 at 3:38 AM, Kulbhushan-Chand notifications@github.com
wrote:

The documentation folder contains a video file showing the installer file.
I am searching for the same but unable to find it anywhere.
—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/kinect-ripple/issues/2#issuecomment-194256041
.

--
Smarth Behl

Thanks, but Build results in number of errors.
So, Is it possible to get the executable shown in the video in the documentation folder?

Please write an e-mail to smbehl@microsoft.com  regarding your requirement
and what you need to use this project for.
I will help you with executable and some sample applications
On Wed, Mar 9, 2016 at 9:26 PM, Kulbhushan-Chand notifications@github.com
wrote:

Thanks, but Build results in number of errors.
So, Is it possible to get the executable shown in the video in the
documentation folder?
—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/kinect-ripple/issues/2#issuecomment-194677484
.

--
Smarth Behl

I have mailed you. Waiting for your kind reply.

The issue was resolved offline

authors: Kulbhushan-Chand Outlaw94 smarth

repo: Microsoft/kinect-ripple


text:
Questions in a world of blue

This closes #361 and #353.

Hi @DaveyBiggers, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (David Bignell (Brook Street)). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

authors: DaveyBiggers msftclas

repo: Microsoft/malmo


text:
After updating to version 2.0.181011001, the appbarbutton reveal border only covers a part of the control

After updating the WinUI library to the version mentioned in the title, the following markup:
<CommandBar DefaultLabelPosition="Collapsed">
	<CommandBar.PrimaryCommands>
		<AppBarButton Icon="Add" Label="Add"/>
	</CommandBar.PrimaryCommands>
</CommandBar>

leads to the reveal border only partially covering the button:

with the previous WinUI version it looked like this:

This happens on Windows version 1809 (17763.55) and corresponding SDK. Please note that this styling issue also seems to appear without the WinUI library added to the project (it was fine on Windows version 1803 without WinUI) and that the older WinUI version was apparently able to fix it.

Thanks for your feedback! We have a fix pending for this but it was not included in this update. We should have an update published this week with the fix.

Thank you very much for the quick reply. This also seems to be an issue with the default platform styles on Windows 1809. Will it be fixed there as well?

this is the best thing about winui library @jevansaks  we can get quick fixes in the platform controls this way, also it would be even faster if community can also actively contribute to the code, would that be possible soon?

We just pushed https://www.nuget.org/packages/Microsoft.UI.Xaml/2.0.181018003 with a fix. Can you try that?

@touseefbsb we're excited about it too! We are working on a plan for contributions. I will share more details about it when we're ready. For now we hope to be able to at least be more responsive to community issues and requests like this. Keep it coming!

I can confirm that the update has fixed this issue. Thank you very much. Please also fix the corresponding style in Windows as soon as possible because it is a really bad developer experience if the default styles are broken.

Absolutely. The fix should also be in a Windows Insider flight soon.

authors: jevansaks lhak touseefbsb

repo: Microsoft/microsoft-ui-xaml


text:
Cross-Targeting "rebuild" doesn't cause Build target to run

In most projects, the Rebuild target is just
<Target Name="Rebuild"
        DependsOnTargets="Clean;Build" />

Or very similar.
In the "outer" build of a crosstargeting build, however, it's defined differently
  <Target Name="Rebuild" DependsOnTargets="_SetRebuildInnerTarget;DispatchToInnerBuilds" />
  <Target Name="_SetRebuildInnerTarget">
    <PropertyGroup>
      <InnerTargets>Rebuild</InnerTargets>
    </PropertyGroup>
  </Target>

This forwards the "rebuild" command to each of the inner builds. That works fine, but it means that it's hard for a build extension to hook onto the outer build, because it's not guaranteed that the Build target will run. That caused problems like https://github.com/NuGet/Home/issues/4475, where an AfterTargets="Build" was (confusingly) not firing on rebuild.

cc @nguerrera

This needs to be fixed at the same time as https://github.com/Microsoft/msbuild/issues/1065. Should we just have one issue noting both things that need to be addressed.

Yes, definitely. Closing this as a dupe.

authors: nguerrera rainersigwald

repo: Microsoft/msbuild


text:
Incorrect value for MSBuildExtensionsPath when using Microsoft.Build.dll in 64bits

Using the following project:
https://github.com/emmanuelguerin/dotnet-builder/tree/bug64bits
When running the project in 32 bits mode using MsBuild inside Visual Studio 2017 Entreprise 15.2 (build configuration Debug32), the build script returns correct MSBuildExtensionsPath value:
Extension Path: C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild

When running the project in 64 bits mode (build configuration Debug) and using the DLL inside:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\15.0\Bin\amd64, the MSBuildExtensionsPath variable is incorrectly initialized to:
Extension Path: C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\MSBuild

Please find a propose patch to solve the problem.
Also, as a workaround, one can create a valid instance of the BuildEnvironment singleton using the following code:
public static void Init() {
   var assembly = Assembly.Load(new AssemblyName("Microsoft.Build"));
   if (!Environment.Is64BitProcess)
     return;

  // This code is a workaround so that MSBuild works in 64 bits mode
  var singletonClass = assembly.GetType("Microsoft.Build.Shared.BuildEnvironmentHelper+BuildEnvironmentHelperSingleton");
  singletonClass.TypeInitializer.Invoke(null, null);
  var singletonField = singletonClass.GetField("s_instance");
  var buildEnvironmentClass = assembly.GetType("Microsoft.Build.Shared.BuildEnvironment");
  var visualStudioMode = Enum.Parse(assembly.GetType("Microsoft.Build.Shared.BuildEnvironmentMode"),
                "VisualStudio");
  var constructor = buildEnvironmentClass.GetConstructors()[0];
  var newEnvironment = constructor.Invoke(new[]
  {
    visualStudioMode,
    Path.Combine(@"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\msbuild.exe"),
    false, false, @"C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise"
  });
  singletonField.SetValue(null, newEnvironment);
}


text:
Project Sdk property not optional on Unix?

Some time ago we migrated our projects to the new build system. (The main csproj see here: https://github.com/icsharpcode/ILSpy/blob/master/ICSharpCode.Decompiler/ICSharpCode.Decompiler.csproj)
(Note: On Windows we use ILSpy.sln on Unix we use ICSharpCode.Decompiler.Console.sln)
This works perfectly fine on Windows, however when we try to open/build the project on mac/unix. VSmac and msbuild cannot open the project unless the Sdk="Microsoft.NET.Sdk" is added, however, when we add that on Windows as well, we get some warnings.

\ILSpy\ICSharpCode.Decompiler\ICSharpCode.Decompiler.csproj(3,3): warning MSB4011: "C:\Program Files\dotnet\sdk\2.0.0\Sdks\Microsoft.NET.Sdk\Sdk\Sdk.props" cannot be imported again. It was already imported at "\ILSpy\ICSharpCode.Decompiler\ICSharpCode.Decompiler.csproj". This is most likely a build authoring error. This subsequent import will be ignored.

Seems like #1392 is not fully supported on Unix.
Is there a way to define the Sdk attribute conditionally (in one single file)? Using a separate csproj file per platform is not a usable workaround as all msbuild projects in the same directory use obj\project.assets.json and conflict with each other (among other problems we've experienced...).

The VS Mac bug is currently being tracked on bugzilla.
Ignoring VS Mac for now, is there a problem with just using msbuild from the command line if this commit is reverted?

I hit other issues trying to build ILSpy.sln with msbuild/mac on the command line. With these changes changes I was able to get it to almost build. But there is other stuff that needs to be fixed in the projects before it will build completely, AFAICS.

@radical ILSpy.sln is not indented for use on Unix as it contains WPF projects.
@mrward removing the conditions on the imports fixes the build. Not sure why I needed to add them before. Thanks for the reference on bugzilla.

authors: mrward radical siegfriedpammer


text:
Why Microsoft.Build.dll not strong-named in nupkg?

I can't use this assembly in my project due to it not strong-named. Can you add this feature in future releases?

What nupkg are you using? It's signed in the latest from our MyGet feed.

I use this:
https://www.nuget.org/packages/MSBuild/

Ah, I see. That's not our package--we haven't published an official NuGet package for our full-Framework assemblies.
Please reference MSBuild from its installed location (or the GAC). That should also reduce confusion at runtime, because the open-source MSBuild version is 14.1 instead of 14.0 like the official version.
I'll look into getting that package de-listed from NuGet to avoid this confusion in the future.

I can't use MSBuild 14.0 version, because some classes are missing or internal (SolutionFile, ProjectInSolution) instead of 14.1.
Is there any way to get signed 14.1?

We'll be publishing official MSBuild packages to NuGet org today.

@MAX-POLKOVNIK, see https://github.com/Microsoft/msbuild/issues/926#issuecomment-242828030 for the list of packages that has been published.

authors: MAX-POLKOVNIK jasonwilliams200OK jeffkl rainersigwald


text:
PHP throws "undefined symbol: SQLGetInstalledDrivers"

PHP Driver version or file name
sqlsrv-5.3.0
pdo_sqlsrv-5.3.0

Client operating system
CentOS Linux release 7.5.1804 (Core)
PHP version
PHP 7.1.20 (cli) (built: Jul 19 2018 10:10:15) ( NTS )
Microsoft ODBC Driver version
Name        : msodbcsql17
Arch        : x86_64
Version     : 17.2.0.1
Release     : 1

Problem description
After following the RedHat 7 guide (https://docs.microsoft.com/en-us/sql/connect/php/installation-tutorial-linux-mac?view=sql-server-2017#installing-the-drivers-on-red-hat-7) php throws the following warnings:
# php -v
PHP Warning:  PHP Startup: Unable to load dynamic library '/usr/lib64/php/modules/sqlsrv.so' - /usr/lib64/php/modules/sqlsrv.so: undefined symbol: SQLGetInstalledDrivers in Unknown on line 0
PHP Warning:  PHP Startup: Unable to load dynamic library '/usr/lib64/php/modules/pdo_sqlsrv.so' - /usr/lib64/php/modules/pdo_sqlsrv.so: undefined symbol: SQLGetInstalledDrivers in Unknown on line 0
PHP Warning:  PHP Startup: Unable to load dynamic library '/usr/lib64/php/modules/ixed.5.4.lin' - /usr/lib64/php/modules/ixed.5.4.lin: undefined symbol: _zend_hash_index_update_or_next_insert in Unknown on line 0
PHP 7.1.20 (cli) (built: Jul 19 2018 10:10:15) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2018 Zend Technologies

Trying to execute a PHP script using the drivers results in:
Fatal error: Uncaught Error: Call to undefined function sqlsrv_connect()

Repro code or steps to reproduce
I'm not sure how to reproduce this issue as I've setup the driver successfully on two Debian 9 systems.
Please let me know if you require any additional information.

@yitam I'm having same problem also. Does sqlsrv module work with Centos 6 and PHP 7.2 ? this is the production server of my client :(

No @solcre  we support Red Hat 7 / CentOS 7 but not CentOS 6.

@yitam is there any workaround to make it work in CentOS 6 ? I've seen some threads around but not sure if they are trustable sources.

I'm afraid you will have to compile the drivers yourself, possibly with pecl, phpize, etc.
The ODBC drivers do support both Red Hat 6 and 7

Thanks for your quick reply @yitam. I manually upgraded gcc to be able to compile the drivers myself. But the extensions are throwing some error. Here is the log:
[01-Aug-2018 00:13:18 UTC] PHP Warning:  PHP Startup: Unable to load dynamic library 'sqlsrv.so' (tried: /opt/cpanel/ea-php72/root/usr/lib64/php/modules/sqlsrv.so (/opt/cpanel/ea-php72/root/usr/lib64/php/modules/sqlsrv.so: undefined symbol: _ZSt24__throw_out_of_range_fmtPKcz), /opt/cpanel/ea-php72/root/usr/lib64/php/modules/sqlsrv.so.so (/opt/cpanel/ea-php72/root/usr/lib64/php/modules/sqlsrv.so.so: cannot open shared object file: No such file or directory)) in Unknown on line 0
[01-Aug-2018 00:13:18 UTC] PHP Warning:  PHP Startup: Unable to load dynamic library 'pdo_sqlsrv.so' (tried: /opt/cpanel/ea-php72/root/usr/lib64/php/modules/pdo_sqlsrv.so (/opt/cpanel/ea-php72/root/usr/lib64/php/modules/pdo_sqlsrv.so: undefined symbol: _ZSt24__throw_out_of_range_fmtPKcz), /opt/cpanel/ea-php72/root/usr/lib64/php/modules/pdo_sqlsrv.so.so (/opt/cpanel/ea-php72/root/usr/lib64/php/modules/pdo_sqlsrv.so.so: cannot open shared object file: No such file or directory)) in Unknown on line 0
[01-Aug-2018 00:13:18 UTC] PHP Warning:  PHP Startup: Unable to load dynamic library 'sqlsrv.so' (tried: /opt/cpanel/ea-php72/root/usr/lib64/php/modules/sqlsrv.so (/opt/cpanel/ea-php72/root/usr/lib64/php/modules/sqlsrv.so: undefined symbol: _ZSt24__throw_out_of_range_fmtPKcz), /opt/cpanel/ea-php72/root/usr/lib64/php/modules/sqlsrv.so.so (/opt/cpanel/ea-php72/root/usr/lib64/php/modules/sqlsrv.so.so: cannot open shared object file: No such file or directory)) in Unknown on line 0
[01-Aug-2018 00:13:18 UTC] PHP Warning:  PHP Startup: Unable to load dynamic library 'pdo_sqlsrv.so' (tried: /opt/cpanel/ea-php72/root/usr/lib64/php/modules/pdo_sqlsrv.so (/opt/cpanel/ea-php72/root/usr/lib64/php/modules/pdo_sqlsrv.so: undefined symbol: _ZSt24__throw_out_of_range_fmtPKcz), /opt/cpanel/ea-php72/root/usr/lib64/php/modules/pdo_sqlsrv.so.so (/opt/cpanel/ea-php72/root/usr/lib64/php/modules/pdo_sqlsrv.so.so: cannot open shared object file: No such file or directory)) in Unknown on line 0

@yitam just in case it helps:
root@whm [/home/apiclientes/public_html]# g++ -v
Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/usr/local/libexec/gcc/x86_64-unknown-linux-gnu/4.9.3/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: ./configure --disable-multilib --enable-languages=c,c++
Thread model: posix
gcc version 4.9.3 (GCC)
root@whm [/home/apiclientes/public_html]# gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/local/libexec/gcc/x86_64-unknown-linux-gnu/4.9.3/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: ./configure --disable-multilib --enable-languages=c,c++
Thread model: posix
gcc version 4.9.3 (GCC)

Hi @yitam,
I upgraded from PHP 5.6 (could've been 5.3) to 7.1. I couldn't find any left overs from the previous version.
# php --ini
PHP Warning:  PHP Startup: Unable to load dynamic library '/usr/lib64/php/modules/sqlsrv.so' - /usr/lib64/php/modules/sqlsrv.so: undefined symbol: SQLGetInstalledDrivers in Unknown on line 0
PHP Warning:  PHP Startup: Unable to load dynamic library '/usr/lib64/php/modules/pdo_sqlsrv.so' - /usr/lib64/php/modules/pdo_sqlsrv.so: undefined symbol: SQLGetInstalledDrivers in Unknown on line 0
PHP Warning:  PHP Startup: Unable to load dynamic library '/usr/lib64/php/modules/ixed.5.4.lin' - /usr/lib64/php/modules/ixed.5.4.lin: undefined symbol: _zend_hash_index_update_or_next_insert in Unknown on line 0
Configuration File (php.ini) Path: /etc
Loaded Configuration File:         /etc/php.ini
Scan for additional .ini files in: /etc/php.d
Additional .ini files parsed:      /etc/php.d/20-bz2.ini,
/etc/php.d/20-calendar.ini,
/etc/php.d/20-ctype.ini,
/etc/php.d/20-curl.ini,
/etc/php.d/20-dom.ini,
/etc/php.d/20-exif.ini,
/etc/php.d/20-fileinfo.ini,
/etc/php.d/20-ftp.ini,
/etc/php.d/20-gd.ini,
/etc/php.d/20-gettext.ini,
/etc/php.d/20-iconv.ini,
/etc/php.d/20-json.ini,
/etc/php.d/20-ldap.ini,
/etc/php.d/20-mbstring.ini,
/etc/php.d/20-mcrypt.ini,
/etc/php.d/20-mysqlnd.ini,
/etc/php.d/20-odbc.ini,
/etc/php.d/20-pdo.ini,
/etc/php.d/20-phar.ini,
/etc/php.d/20-posix.ini,
/etc/php.d/20-shmop.ini,
/etc/php.d/20-simplexml.ini,
/etc/php.d/20-snmp.ini,
/etc/php.d/20-sockets.ini,
/etc/php.d/20-sqlite3.ini,
/etc/php.d/20-sqlsrv.ini,
/etc/php.d/20-sysvmsg.ini,
/etc/php.d/20-sysvsem.ini,
/etc/php.d/20-sysvshm.ini,
/etc/php.d/20-tokenizer.ini,
/etc/php.d/20-xml.ini,
/etc/php.d/20-xmlwriter.ini,
/etc/php.d/20-xsl.ini,
/etc/php.d/30-mysqli.ini,
/etc/php.d/30-pdo_mysql.ini,
/etc/php.d/30-pdo_odbc.ini,
/etc/php.d/30-pdo_sqlite.ini,
/etc/php.d/30-pdo_sqlsrv.ini,
/etc/php.d/30-wddx.ini,
/etc/php.d/30-xmlreader.ini,
/etc/php.d/40-ssh2.ini,
/etc/php.d/40-zip.ini,
/etc/php.d/sourceguardian.ini

Aren't those the exact instructions from https://docs.microsoft.com/en-us/sql/connect/php/installation-tutorial-linux-mac?view=sql-server-2017#installing-the-drivers-on-red-hat-7 or am I missing something?
Anyway I tried them and it boiled down to:
Package php-7.1.20-1.el7.remi.x86_64 already installed and latest version
Package php-pdo-7.1.20-1.el7.remi.x86_64 already installed and latest version
Package php-xml-7.1.20-1.el7.remi.x86_64 already installed and latest version
Package 1:php-pear-1.10.5-6.el7.remi.noarch already installed and latest version
Package php-devel-7.1.20-1.el7.remi.x86_64 already installed and latest version
Package gcc-c++-4.8.5-28.el7_5.1.x86_64 already installed and latest version
Package gcc-4.8.5-28.el7_5.1.x86_64 already installed and latest version
Nothing to do

I tried compiling them myself using the pecl download way described in the docs mentioned above.
The dev tools were already upgraded:
Package devtoolset-7-7.1-4.el7.x86_64 already installed and latest version

# make
/.../
Libraries have been installed in:
   /root/sqlsrv-5.3.0/modules

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
     during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
     during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
----------------------------------------------------------------------

Build complete.
Don't forget to run 'make test'.

# make install
Installing shared extensions:     /usr/lib64/php/modules/

This still results in PHP Warning:  PHP Startup: Unable to load dynamic library '/usr/lib64/php/modules/sqlsrv.so' - /usr/lib64/php/modules/sqlsrv.so: undefined symbol: SQLGetInstalledDrivers in Unknown on line 0
I disabled SourceGuardian for now as I'm not sure whether I need it.

Hi @matthenning, yes the instructions are almost the same, except for one line and how to get the devtools.
A few more questions to try to understand what the problem is:

What's your unixODBC version? (odbcinst --j) -- any unixODBC related env variables set up?
Did you do this sudo yum install unixODBC-devel?
I saw this "Libraries have been installed in: /root/sqlsrv-5.3.0/modules" -- did you compile everything as the root user? Or did you do sudo pecl download?
What's the output of sudo pear version? Is it linked with the latest PHP version (php -v)?
Locate where your ODBC driver is installed odbcinst -q -d -n "ODBC Driver 17 for SQL Server" and then do something like this ldd /opt/microsoft/msodbcsql17/lib64/libmsodbcsql-17.2.so.0.1

HI @solcre , you might need to seek help somewhere else. As I mentioned before, we don't support Red Hat 6 / CentOS 6.

Hi @matthenning, try compiling this simple c program. If your unixODBC was installed properly, it should work.

Hi @matthenning, please ignore my previous message. I accidentally closed this issue. Anyway, try to compile this simple c program. If unixODBC was installed properly in your system, it should work.
#include <odbcinst.h>
#include <string.h>

int main()
{
    char szBuf[2001] = {'\0'};     // use a large enough buffer size
    WORD cbBufMax = 2000;
    WORD cbBufOut;
    char *pszBuf = szBuf;
    BOOL result;

    // get all the names of the installed drivers delimited by null characters
    result = SQLGetInstalledDrivers(szBuf, cbBufMax, &cbBufOut);

    do
    {
        printf("driver: %s\n", pszBuf);

        // get the next driver
        pszBuf = strchr(pszBuf, '\0') + 1;
    }
    while (pszBuf[1] != '\0');
}

To compile and run this test, do the followings:
gcc -o mytest simple.c -lodbcinst
./mytest

Because I have both ODBC 13 and 17, the output of mytest is:
driver: ODBC Driver 13 for SQL Server
driver: ODBC Driver 17 for SQL Server

Please give this a try.

Hi @yitam,
looks like there is something wrong with my odbc installation.
# ./mytest
./mytest: symbol lookup error: ./mytest: undefined symbol: SQLGetInstalledDrivers

# odbcinst -j
unixODBC 2.3.1
odbcinst: symbol lookup error: odbcinst: undefined symbol: odbcinst_system_file_name

Yes
Everything ran as the root user, not via sudo
PEAR Version: 1.10.5

# odbcinst -q -d -n "ODBC Driver 17 for SQL Server"
Segmentation fault

I'm not really sure where to start troubleshooting this.
Yum looks fine:
# yum info unixODBC-devel

Installed Packages
Name        : unixODBC-devel
Arch        : x86_64
Version     : 2.3.1
Release     : 11.el7
Size        : 186 k
Repo        : installed
From repo   : BaseOS
Summary     : Development files for programs which will use the unixODBC library
URL         : http://www.unixODBC.org/
License     : GPLv2+ and LGPLv2+
Description : The unixODBC package can be used to access databases through ODBC
            : drivers. If you want to develop programs that will access data through
            : ODBC, you need to install this package.

Available Packages
Name        : unixODBC-devel
Arch        : i686
Version     : 2.3.1
Release     : 11.el7
Size        : 54 k
Repo        : BaseOS/x86_64
Summary     : Development files for programs which will use the unixODBC library
URL         : http://www.unixODBC.org/
License     : GPLv2+ and LGPLv2+
Description : The unixODBC package can be used to access databases through ODBC
            : drivers. If you want to develop programs that will access data through
            : ODBC, you need to install this package.

Hi @matthenning
I agree. Something is wrong with unixODBC and/or MS ODBC driver installation. Please consider uninstalling them both first.
To remove MS ODBC 17, do yum remove -y msodbcsql17
If you happen to have older versions of MS ODBC, also do yum remove -y msodbcsql
If you have installed mssql-tools, then yum remove -y mssql-tools
Then do the following:
yum remove -y unixODBC unixODBC-devel
yum -y clean all

After all this, doing odbcinst -j should return something like
bash: /usr/bin/odbcinst: No such file or directory
To reinstall, please follow the MS ODBC 17 installation instructions
Note that unixODBC will be installed by the package manager because it's a dependency.
When you're done, please try odbcinst -j and odbcinst -q -d -n "ODBC Driver 17 for SQL Server"

Hi @yitam,
thank you for your effort.
Sadly I'm running into the same issue.
We decided to order new VMs and set them up from scratch, as I inherited the current ones and they seem fubar.
I'll give a short feedback after I'm done whether this was in isolated issue or if it occured on the fresh system, too.

The setup went flawlessly on the fresh VMs.
I think we can close this issue.
Thank you again for your help. It's greatly appreciated.

authors: matthenning solcre yitam

repo: Microsoft/msphpsql


text:
'Login failed for user' when connecting to a docker hosted SQLServer instance

Driver version or jar name
mssql-jdbc-7.0.0.jre8.jar
SQL Server version
(Using docker)
Microsoft SQL Server 2017 (RTM-CU9) (KB4341265) - 14.0.3030.27 (X64)
Jun 29 2018 18:02:47
Copyright (C) 2017 Microsoft Corporation
Express Edition (64-bit) on Linux (Ubuntu 16.04.4 LTS)
Client operating system
Microsoft Windows Version 1803 (17134.112)
Java/JVM version
java version "1.8.0_181"
Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode)
Table schema
None
Problem description
I'm using liquibase, a database change migration tool, to update my databases. I tried to execute the migrations using a mssql docker image. When trying to connect the following exception occurs:
liquibase.exception.DatabaseException: liquibase.exception.DatabaseException: com.microsoft.sqlserver.jdbc.SQLServerException: Login failed for user 'sa'. ClientConnectionId:5cbf9253-ffe6-4b3f-a9b7-fb7f2eaa04e6
        at liquibase.integration.commandline.CommandLineUtils.createDatabaseObject(CommandLineUtils.java:132)
        at liquibase.integration.commandline.Main.doMigration(Main.java:953)
        at liquibase.integration.commandline.Main.run(Main.java:191)
        at liquibase.integration.commandline.Main.main(Main.java:129)
Caused by: liquibase.exception.DatabaseException: com.microsoft.sqlserver.jdbc.SQLServerException: Login failed for user 'sa'. ClientConnectionId:5cbf9253-ffe6-4b3f-a9b7-fb7f2eaa04e6
        at liquibase.database.DatabaseFactory.openConnection(DatabaseFactory.java:254)
        at liquibase.database.DatabaseFactory.openDatabase(DatabaseFactory.java:149)
        at liquibase.integration.commandline.CommandLineUtils.createDatabaseObject(CommandLineUtils.java:97)
        ... 3 common frames omitted
Caused by: com.microsoft.sqlserver.jdbc.SQLServerException: Login failed for user 'sa'. ClientConnectionId:5cbf9253-ffe6-4b3f-a9b7-fb7f2eaa04e6
        at com.microsoft.sqlserver.jdbc.SQLServerException.makeFromDatabaseError(SQLServerException.java:254)
        at com.microsoft.sqlserver.jdbc.TDSTokenHandler.onEOF(tdsparser.java:258)
        at com.microsoft.sqlserver.jdbc.TDSParser.parse(tdsparser.java:104)
        at com.microsoft.sqlserver.jdbc.SQLServerConnection.sendLogon(SQLServerConnection.java:4772)
        at com.microsoft.sqlserver.jdbc.SQLServerConnection.logon(SQLServerConnection.java:3581)
        at com.microsoft.sqlserver.jdbc.SQLServerConnection.access$000(SQLServerConnection.java:81)
        at com.microsoft.sqlserver.jdbc.SQLServerConnection$LogonCommand.doExecute(SQLServerConnection.java:3541)
        at com.microsoft.sqlserver.jdbc.TDSCommand.execute(IOBuffer.java:7240)
        at com.microsoft.sqlserver.jdbc.SQLServerConnection.executeCommand(SQLServerConnection.java:2869)
        at com.microsoft.sqlserver.jdbc.SQLServerConnection.connectHelper(SQLServerConnection.java:2395)
        at com.microsoft.sqlserver.jdbc.SQLServerConnection.login(SQLServerConnection.java:2042)
        at com.microsoft.sqlserver.jdbc.SQLServerConnection.connectInternal(SQLServerConnection.java:1889)
        at com.microsoft.sqlserver.jdbc.SQLServerConnection.connect(SQLServerConnection.java:1120)
        at com.microsoft.sqlserver.jdbc.SQLServerDriver.connect(SQLServerDriver.java:700)
        at liquibase.database.DatabaseFactory.openConnection(DatabaseFactory.java:246)
        ... 5 common frames omitted

Logging in using Sql Server Management Studio works fine as well as creating a database in the docker container using sqlcmd.exe with the same credentials.
If I execute the same batch file against a locally installed SQL Server (2016 - I don't have a newer version installed) it is working fine. But I can't get it to run against the SQL Server in the docker container.
I can't figure out what's the problem here.
Expected behavior and actual behavior
Logging in using the same credentials as with SSMS or SQLCMD should work via jdbc.
Repro code
I created a small sample that leads to the exception here:
https://github.com/papauorg/mssql-jdbc-login-sample/tree/master
1.) Start the docker container (latest mssql-image) using docker-compose up
2.) Execute the liquibase batch file (that's using the jdbc driver) RunLiquibaseAgainstDocker.bat
Could you please have a look at this? Would be great if you could tell me if i'm doing something wrong, here?
Thanks,
Philipp

@papauorg : As per my understanding you are using latest stable MSSQL JDBC driver (mssql-jdbc-7.0.0.jre8.jar). You able to work with liquibase success with your locally installed SQL Server 2016. While with docker instance it is failing.
Can you remove MSSQL_PID=Express from your docker-compose.yml file ?
Please let us know after removing setting for Express Edition

Hi @papauorg
I tested with your repro, and turns out, JDBC Driver is able to connect successfully with 0.0.0.0 as servername while ODBC driver cannot identify 0.0.0.0 then. This is due to the way docker maps ports to host machines. It uses 0.0.0.0 to map the port unless hostname is specified.
You can make a small change in docker-compose.yml by specifying ports as below:
ports:
     - "127.0.0.1:1434:1433"

Also, specify same host in RunLiquidbaseAgainstDocker.bat ServerName=127.0.0.1 so that ODBC Driver can identify it. The JDBC Driver can resolve host 127.0.0.1 to localhost for connecting to this server but ODBC Driver cannot do so. Explicitly specifying host IP address makes it work for both drivers.

@cheenamalhotra :  I believe @papauorg is talking about JDBC driver. Although ServerName & ports changes might be helpful to user.

Hi @cheenamalhotra,
your suggested changes are working fine. Thank you!
Just for me to understand correctly, you said that docker maps the ports to 0.0.0.0 if no hostname is specified. That means in the sample this is what happens. And that the JDBC driver is able to connect to 0.0.0.0 while the ODBC driver is not. Wouldn't that mean, that the sample should behave in the opposite way than it does, when not specifying 127.0.0.1:1434:1433? Meaning that the liquibase/jdbc should have worked but not the SQLCMD.exe?

Ah, understood! Thanks again.

authors: cheenamalhotra nsidhaye papauorg

repo: Microsoft/mssql-jdbc


text:
[loc][Query][Node.js] Localizability of 0; "NodeHeader"

Hi,
we have a question from a translator. Could you help please?
Source:
Node
File Name:
localize\ENU\Microsoft.NodejsTools.dll
Resource ID:
0; "NodeHeader"
Query:
We assume this is the general concept here, please confirm or advise.

Yeah, that just says "Node.js" and doesn't need to be translated.

Thanks for confirmation

authors: PDostalek paulvanbrenk

repo: Microsoft/nodejstools


text:
npm window contrast messed up in dark theme

Seems to be fixed in NTVS 1.2 Alpha

authors: mjbvz mousetraps


text:
Npm install dialog & one function analysis

This removes the dialog to confirm the npm package installation after creating a new project as per #40 and fixes up a string when the analyzer only analyses a single function as per #39

:shipit:

authors: mousetraps paulvanbrenk


text:
Job metrics: taskrolelevelmetrics, tasklevelmetrics are missing

Now, taskrolelevelmetrics, tasklevelmetrics are missing.
http://10.151.40.179/view.html?username=hayua&jobName=Vortex-mpi-ADLS-singlebox-20181213

You can click on that red corner and it will show error: 414 Request-URI Too Large. This has been fixed in #1717 .

These three pages will show value from the same metrics but using different aggregation method:
The first page avg all metrics from one job.
The second page avg over task role level from one job.
The second page avg over task level from one job.

Clarify user's purpose:

taskrolelevelmetrics: want to see metrics aggregating by taskRoles. If there are two role master and slave, it could display different pages for each.
tasklevelmetrics: metrics by tasks, could see each container's metrics.

This is exactly what these pages will display if no bug.

@Anbang-Hu, as @xudifsd mentioned, it's bug. We fixed but haven't released yet.

repo: Microsoft/pai


text:
block category should be inverted

Always use inverted style to emphasize colors

@pelikhan Can you explain the what inverted means here?

This is driven by individual white label site requirements. Closing this for now.

authors: abchatra pelikhan

repo: Microsoft/pxt


text:
Only include poweredby images when flag is set.

set @includePoweredByImages: true in target site.variables in order to include these files.
Fixes https://github.com/Microsoft/pxt/issues/4016
Couldn't find any way to test in less if a file exists.

Looks like I accidentally checked in an identical commit. Closing.


text:
Facebook 0.58.6 merge (with conflicts)

Merge facebook's 0.58.6 branch into ours.
Description of changes
Merge their fork into this branch. Merge conflicts are nearly all left in although I removed merge conflicts in about a dozen files or so already.
I'll keep fixing up the iOS/Mac merge conflicts and then shift to cross-plat files, but don't have a build environment to build/test Android or Windows, so help would be appreciated there.

/azp run

authors: HeyImChris acoates-ms

repo: Microsoft/react-native


text:
user property for version and upgrade spring framework to 5.0.5

Microsoft/azure-spring-boot#312

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #79   +/-   ##
=======================================
  Coverage   76.52%   76.52%
=======================================
  Files          31       31
  Lines         720      720
  Branches       98       98
=======================================
  Hits          551      551
  Misses        118      118
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f22bff3...3494cd8. Read the comment docs.

authors: codecov-io sophiaso

repo: Microsoft/spring-data-documentdb


text:
Mention where to log issues in README.md

README.md should list https://github.com/Microsoft/TypeScript as the place to log issues if a type definition is being published incorrectly

Clarification: The generated readme.md file we publish, not the local repo's readme

There are different set of issues, and i am not sure where should these be logged...

there are definition issues, accuracy, noImplcitAny, strictNullChecks, etc.. these are caused by declaration file content, which lives on DT.
publish issues, like version mismatch, invalid dependency, package names, etc..
language issues, like conflicting declaration issues, can not merge types in certain context, how a file should be authored, or uses, etc..

I believe 2, and 3 are the minority, the majority of issues fall in 1. so the link should be to definitely typed instead.

Good point, I agree.

authors: RyanCavanaugh mhegazy

repo: Microsoft/types-publisher


text:
在中文环境下的严重问题：如果vs没有安装英文语言包，有些库编译无法通过。如果系统没有英文语言包，vs默认不安装英文包

在中文环境下的严重问题：如果vs没有安装英文语言包，有些库编译无法通过。如果系统没有英文语言包，vs默认不安装英文包

I happen to know Chinese so I can translate this issue. Basically it is saying in a Chinese version Windows, if the English language pack is not installed, vcpkg compilation will fail

look this CMake 3.9 Generates build.ninja failed on Non-Engish Windows

i have solve this problem

@how0723 Please let us know how you solve the problem so if people run into the same problem in the future they will know how to solve it.

ok. install English language pack for your windows system. then install English language pack for your vs2017 or vs2015.

repo: Microsoft/vcpkg


text:
Jenkins testing

Try and enable Jenkins testing.

@dotnet-bot test ci please

repo: Microsoft/visualfsharp


text:
[WIP] Fix completion for double ticked module values

This fixes https://github.com/Microsoft/visualfsharp/issues/97

It works for backticked (BTW, what is the right name for such identifiers?) identifiers, except provided ones. I've explored everything in PropInfo.ProvidedProp here https://github.com/Microsoft/visualfsharp/blob/master/src/fsharp/NameResolution.fs#L215 and it does not contain neither backticked name nor any flag saying that it has such a name.
/cc @dsyme

All fixed.

If these are all fixed can WIP be removed from the title?

authors: saul vasily-kirichenko


text:
failed to connect to server [127.0.0.1:27017] on first connect [MongoError: connect ECONNREFUSED 127.0.0.1:27017]

Repro steps:

Action: cosmosDB.attachDatabaseAccount
Error type: Error
Error Message: failed to connect to server [127.0.0.1:27017] on first connect [MongoError: connect ECONNREFUSED 127.0.0.1:27017]
Version: 0.8.0
OS: linux

Closing due to lack of response.

authors: LarisaLub PrashanthCorp

repo: Microsoft/vscode-cosmosdb


text:
JSON schema support for .jscsrc

From @scottaddie on November 22, 2015 4:23
Prior to the 0.10.1 release, the following settings were baked into the editor:
    // Control whether jshint is enabled for JavaScript files or not.
"jshint.enable": true,

// The jshint options object to provide args to the jshint command.
"jshint.options": {},

Now that there's an official JSHint extension, the following schema support should be added by it rather than including it into the editor:
    {
        "fileMatch": [
            "/.jshintrc"
        ],
        "url": "http://json.schemastore.org/jshintrc"
    },

I'd argue the same point regarding the JSCS extension. It should add the following to the settings, rather than baking it into the editor:
    {
        "fileMatch": [
            "/.jscsrc"
        ],
        "url": "http://json.schemastore.org/jscsrc"
    }

Copied from original issue: Microsoft/vscode#433

thanks @scottaddie !

authors: chrisdias dbaeumer

repo: Microsoft/vscode-jscs


text:
[BUG] Finding installed modules failed SyntaxError: Unexpected end of JSON input

I got error whenever I open my package.json in the editor:
Finding installed modules failed SyntaxError: Unexpected end of JSON input

When disabled your extension error disappeared.

My Scripts:
    "precommit": "yarn run lint & yarn run tsc",
    "prepush": "yarn run test",
    "rebuild": "yarn run clean && yarn && yarn run build",
    "clean": "rm -rf node_modules dist",
    "dev": "webpack-dev-server --config configs/webpack.config.js",
    "build": "NODE_ENV=production webpack -p --config configs/prod.config.js --colors",
    "prod": "webpack-dev-server --config configs/webpack.config.js",
    "lint": "tslint 'client/**/*.ts' 'client/**/*.tsx'",
    "tsc": "tsc -p client/ --noEmit",
    "test": "jest --config ./jest.config.json",
    "test:update": "jest -u  --config ./jest.config.json",
    "docker:build": "docker build -t mad_app_image .",
    "docker:run": "docker run --rm --name mad-app -p 3000:3000 mad_app_image",
    "docker": "npm run docker:build && npm run docker:run"
  },

@piotrwitek thanks for the issue report. Published a new version with the fix to the marketplace.

@egamma Thanks for fast response but the issue is not fixed, updated to 0.1.3 and still exactly the same error

@piotrwitek can you please attach the full package.json, so that I can reproduce your exception please.

@piotrwitek one more thought do you have npm installed or do you only use yarn? The validation calls npm ls which assumes that npm is installed.

Could reproduce the issue when 'npm' is not installed. The code no handles this case gracefully. Published version 0.1.4 to the marketplace.

@egamma Thanks, seems like 0.1.4 fixed exception.
Regarding your questions:

I have npm and npm ls is working fine.
Your fix seems to just handle the exception, isn't that getInstalledModules logic is not handling something that it have raised exception in the first place?

@piotrwitek yes, the fix is brute force and swallows all exceptions that happen when running npm ls --depth 0 --json.
This includes 1) spawning the process fails or 2) the returned JSON cannot be parsed. I could reproduce 1) but I failed to reproduce 2). For that I'd need your package.json  or the output your get when you run  npm ls --depth 0 --json in the folder with the package.json that is causing trouble.

@egamma Cool, Here you go:
{
  "name": "mad-app",
  "version": "0.1.0",
  "private": true,
  "description": "Description",
  "author": "Piotr Witek <piotr.witek@shipwallet.com> (http://piotrwitek.github.io)",
  "license": "SEE LICENSE IN LICENSE.md",
  "engines": {
    "node": ">=6.9.0"
  },
  "scripts": {
    "precommit": "yarn run lint & yarn run tsc",
    "prepush": "yarn run test",
    "clean": "rm -rf node_modules dist",
    "build": "NODE_ENV=production webpack --config configs/prod.config.js",
    "rebuild": "yarn run clean && yarn && yarn run build",
    "prod": "webpack-dev-server --config configs/webpack.config.js",
    "dev": "webpack-dev-server --config configs/webpack.config.js",
    "lint": "tslint 'client/**/*.ts' 'client/**/*.tsx'",
    "tsc": "tsc -p client/ --noEmit",
    "test": "jest --config ./jest.config.json",
    "test:update": "jest -u  --config ./jest.config.json",
    "docker:build": "docker build -t mad_app_image .",
    "docker:run": "docker run --rm --name mad-app -p 3000:3000 mad_app_image",
    "docker": "npm run docker:build && npm run docker:run"
  },
  "dependencies": {
    "@blueprintjs/core": "^1.4.0",
    "antd": "^2.5.2",
    "blaze": "^3.2.0",
    "classnames": "2.2.5",
    "jwt-decode": "2.1.0",
    "react": "^15.4.1",
    "react-dom": "^15.4.1",
    "react-icons": "2.2.1",
    "react-redux": "^4.4.6",
    "react-router": "3.0.0",
    "react-router-redux": "4.0.7",
    "react-select": "^1.0.0-rc.2",
    "redux": "^3.6.0",
    "redux-actions": "^1.2.0",
    "redux-thunk": "^2.1.0",
    "reselect": "2.5.4",
    "seamless-immutable": "6.3.0",
    "uuid": "^3.0.1",
    "whatwg-fetch": "2.0.1"
  },
  "devDependencies": {
    "@types/dom4": "1.5.20",
    "@types/enzyme": "^2.5.39",
    "@types/expect": "^1.13.31",
    "@types/jest": "^16.0.1",
    "@types/jwt-decode": "1.4.28",
    "@types/node": "^6.0.52",
    "@types/react": "^0.14.51",
    "@types/react-dom": "0.14.19",
    "@types/react-hot-loader": "^3.0.0",
    "@types/react-redux": "^4.4.34",
    "@types/react-router": "^2.0.40",
    "@types/react-router-redux": "^4.0.35",
    "@types/react-select": "^1.0.36",
    "@types/redux-actions": "^0.8.34",
    "@types/redux-thunk": "2.1.32",
    "@types/seamless-immutable": "6.1.2",
    "@types/whatwg-fetch": "^0.0.33",
    "compression": "1.6.2",
    "connect-history-api-fallback": "1.3.0",
    "copy-webpack-plugin": "^4.0.1",
    "css-loader": "^0.26.1",
    "css-modules-require-hook": "4.0.5",
    "enzyme": "2.6.0",
    "expect": "^1.20.2",
    "express": "4.14.0",
    "extract-text-webpack-plugin": "^2.0.0-beta.4",
    "file-loader": "0.9.0",
    "html-webpack-plugin": "^2.24.1",
    "http-proxy": "^1.16.2",
    "husky": "0.11.9",
    "image-webpack-loader": "^3.1.0",
    "jest": "^17.0.3",
    "json-loader": "0.5.4",
    "less": "^2.7.1",
    "less-loader": "^2.2.3",
    "node-sass": "^3.13.0",
    "react-addons-css-transition-group": "^15.4.1",
    "react-addons-test-utils": "^15.4.1",
    "react-hot-loader": "3.0.0-beta.6",
    "react-test-renderer": "^15.4.1",
    "redbox-react": "^1.3.3",
    "redux-logger": "^2.7.4",
    "sass-loader": "4.0.2",
    "source-map-loader": "0.1.5",
    "style-loader": "0.13.1",
    "ts-jest": "^17.0.3",
    "ts-loader": "^1.3.3",
    "tslint": "^4.1.1",
    "typescript": "^2.1.4",
    "url-loader": "0.5.7",
    "webpack": "^2.2.0-rc.1",
    "webpack-dev-server": "^2.2.0-rc.0"
  }
}

npm-ls.txt

@piotrwitek thanks.
In my setup (without yarn installed) I cannot reproduce the error.  The screenshot below illustrates the result of a validation (I've manually uninstalled the antd module to force a validation warning).
The exception happens when the output from npm ls --depth 0 --json cannot be parsed as JSON.  I noticed that yarn doesn't provide the --json command line argument. Speculation, if yarn sets up an alias for npm then this could happen. I'll try to reproduce with yarn installed.

@egamma I've seen your lib uses npm bin name to run commands, and when I use which npm I only got npm path, so it makes it impossible to run yarn in such set up, we can repel such scenario.
Other thing is, if you look at npm-ls.txt dump I have attached above, there you will see some error in the returned json somewhere at the end.
The error is due to UNMET PEER DEP for  webpack2.2.0-rc.1, while in reality it shouldn't happened because it don't seem to have any peers set-up in package json.
I don't know if you already noticed that, but it would be the first place I would investigate.

@piotrwitek
I've modified the code so that it requires yournpm-ls.txt as JSON instead of running npm -ls, and the code could handle the JSON without any issues. This indicates that the problem isn't an issue of the JSON, but the way the output from the spawned process is read.
I've changed the code to do JSON parsing on the close event instead of the exit event. According the docs, it is possible that stdout still is open when exit is called. This is the change.
I've attached a new version as a VSIX and would appreciate if you can try out whether this addresses the issue.
vscode-npm-script-0.1.4.zip
To try it:

extract the file
rename the extension from zip to vsix
install the extension from the extension viewlets menu's 'Install VSIX' command (see below)

Regarding the 'unmet peer dep' the validation currently doesn't handle missing peer dependencies so this errors are ignored. Adding warnings for unmet peer dependencies would make sense.

@egamma I done the test.
When using custom extension I got this error:
[npm-script-runner] Cannot validate the package.json TypeError: Cannot read property 'version' of undefined
Even when I empty my entire package.json it's still showing this strange error.

@piotrwitek thanks for trying and for your patience.
I've verified that the attached vsix works fine in my setup. I've attached a new version of the vsix that dumps the stack trace to the console when this exception happens. Can you please try again?
vscode-npm-script-0.1.4.zip
Here are the steps:

manually uninstall the existing npm-script-runner
rename the attached .zip to .vsix and install it as above
when the exception occurs then open the Developer Tools: Help>Toggle Developer Tools and switch to the Console tab. The stack trace of the exception should show up there (see below)

Even when I empty my entire package.json it's still showing this strange error.

This was caused by the assumption that a package.json has a least a name attribute.  This is fixed but it looks like a separate issue than the one you reported above:

[npm-script-runner] Cannot validate the package.json TypeError: Cannot read property 'version' of undefined

@egamma cool, I gonna test it later today so stay tuned :)

@piotrwitek it is not yet publishd to the marketplace, but here is the vsix with the fixes. Thanks in advance for checking. If there is the exception pls open the Dev tools console.
vscode-npm-script-0.1.4.zip
To install same steps as above https://github.com/Microsoft/vscode-npm-scripts/issues/27#issuecomment-268224592

No problem, here is the stacktrace:
TypeError: Cannot read property 'version' of undefined
    at forEach.each (/Users/piotrek/.vscode/extensions/eg2.vscode-npm-script-0.1.4/out/src/main.js:283:61)
    at Array.forEach (native)
    at getDiagnostic (/Users/piotrek/.vscode/extensions/eg2.vscode-npm-script-0.1.4/out/src/main.js:275:41)
    at /Users/piotrek/.vscode/extensions/eg2.vscode-npm-script-0.1.4/out/src/main.js:234:38
    at next (<anonymous>)
    at fulfilled (/Users/piotrek/.vscode/extensions/eg2.vscode-npm-script-0.1.4/out/src/main.js:4:58)

@piotrwitek thanks this is helpful.
This means that npm ls has found a dependency with an invalid version, but when I use a JSON parser  to locate the source position of a dependency in the JSON file it cannot find it. I know how to protect against this case, but I'd me more interested in finding the root cause of this failure.
I've tried to create such a situation but I failed up to now. It seems that it is easy for you ;-). Therefore can please attach the package.json and the output from npm ls --depth 0 --json when this happens? I've analysed the output from npm-ls that you attached in this comment https://github.com/Microsoft/vscode-npm-scripts/issues/27#issuecomment-267852412 but this output did not have an 'invalid' installed version of a dependency.

@egamma yes I can help you with that.
I'm not sure how to hook up a debugger to the extension in running vs code, so I could set a breakpoint, is there a way to do that? Could you point me to some article with example how to do it?

@piotrwitek thanks for your offer, but before we do the extension debugging step (which is well supported), let's do one more thing. Now, that we know where the problem is, I've instrumented the code to print out for which module the source range cannot be located. The module name of the problematic dependency is printed to the console. Therefore can you please:

install this version (0.1.5) of the extension attached below
open the package.json that triggered the exception before
open the console in the dev tools and you should see the print out of the module name
can you please include this module name, and the corresponding excerpt of the package.json in a comment.
also include the snippet from npm ls --depth 0 --json with the invalid warning for this module, e.g.

    "jwt-decode": {
      "version": "2.1.0",
      "from": "jwt-decode@2.1.0",
      "resolved": "https://registry.npmjs.org/jwt-decode/-/jwt-decode-2.1.0.tgz",
      "invalid": true,
      "problems": [
        "invalid: jwt-decode@2.1.0 C:\\Users\\egamma\\Projects\\tries\\npm-script-test\\node_modules\\jwt-decode"
      ]
    },

vscode-npm-script-0.1.5.zip

Done, the problem was:

[npm-script] Could not locate "invalid" dependency 'rc-select' in package.json
I found rc-select package folder in node_modules root to be empty (so no package.json was found inside)
rc-select was also located in antd node_modules, but correctly installed there with all contents
after removing node_modules and reinstalling with npm install - fixed the issue

I believe the problem was that if package.json of module is missing then this extension was throwing a null exception due to deep object property access, without properly checking if they exist.
Adding error handling for deep property access should fix the future issues.
Now extension was working fine without exception, so I believe you have already fixed that in 0.1.5

@piotrwitek thanks for going through this with me and helping me to make the code more robust.
I was assuming that an invalid entry in an npm ls JSON report always has a version property, but in the case of an empty package directory, the version cannot be determined and npm correctly reports an error and there is no version property.
I've published the new version 0.1.5 to the market place. To get future updates of the module, you need to uninstall the manually installed extension and install it from the extension viewlet again.

@egamma no problem that was cool, I learned something new about VS Code! :) BR

authors: egamma piotrwitek

repo: Microsoft/vscode-npm-scripts


text:
Long Python lists are not shortened when printed in terminal

It seems long Python objects are not truncated when printed in the terminal in interactive mode, such as lists for example. This is problematic when dealing with large objects, as it takes a long time to print them in the console and might lead the system to crash.
Steps to reproduce:

Initialize a long Python list
Print it in the editor

Expected behavior:

Should truncate the outputs to print to something reasonable.

Acutal behavior:

Prints the whole object regardless of size.

Example code (e.g. type in VS Code, select all, press Shift + Enter):
import numpy as np
a = np.random.normal(size = 10**7)
a.tolist()

I'm not sure the extension should be making decisions on what data to truncate. Instead, it is probably best to dutifully try to process anything the user throws at it.
How would we be able to decide where to truncate and leave all necessary data (for debugging/etc...) in place?
My assertion is that the user knows best, we trust their judgement, and if something is being sent out to the editor that is too big/too noisy then the user will find a way to best filter that data for their needs.
@brettcannon / @DonJayamanne do you have any thoughts on this one? Otherwise I suggest we close as 'as designed' here perhaps.

@d3r3kk : I think the decision of whether to print a list whole or not is quite easy: if it's above a certain size, then it should be shortened by default, as it happens in e.g. jupyter, spider, and others. In these same IDEs it's still possible to print a whole list by iterating over its elements, although ideally in vscode there could be a setting to manage that.
And if you are debugging and want to inspact a variable, I think it's not nice to have a list of millions of entries being printed into the screen, rendering vscode unusable for a while (perhaps needing a forced termination and restart) and taking unreasonable system resources.

I'm closing this issue as the debugger should not truncate text sent to the terminal. That's not the role of the debugger.
the debugger should always display exactly what is sent to the terminal, any changes to that would fall out of scope.

authors: DonJayamanne d3r3kk david-cortes

repo: Microsoft/vscode-python


text:
Use MagicPython as a dependency

We had discussed adding MagicPython as a dependency but I don't know where it ended up.

Let's just add it. If we want the users to have the best experience when installing this extension, then we must add this as a dependency.

Hmm, not sure whether an extension can add another extension as a dependency. Based on the documentation it should be possible, however the documentation only mentions extension dependencies in the context of Extension Packs
No way to test this either, installing locally from a vsix does not install dependencies (not even with extension packs downloaded from the marketplace).
Will look into this.

If that turns out to be true then the wording is misleading for the setting itself at the top of that page as it doesn't suggest an extension that does stuff can't have dependencies.

Todo: Test creating a dummy extension (under my name) publish into market place with extension dependency to confirm this works as expected. Based on this I can file either one of the following issues against VS Code:

Extension dependencies doesn't work for standard extensions
Question - How to enable CI tests on travis with extension dependency

To help manage our issues and to better communicate what the team plans to work on we are closing issues that we don't plan to work on but would accept a pull request from a volunteer for. To be clear, closing this issue does not mean we won't consider a pull request for this enhancement as outlined in our contributing guide, just that the development team has no plans to work on it themselves.

authors: DonJayamanne brettcannon


text:
Lay down LS localization suppression file on Linux

https://github.com/Microsoft/python-language-server/issues/170
In order to better support Linux containers please add the following to Microsoft.Python.LanguageServer.runtimeconfig.json in the LS folder on Linux:
{
  "runtimeOptions": {
    "configProperties": {
      "System.Globalization.Invariant": true
    }
  }
}

Even better if this can be done only in containers so we don't lose potential localization on Linux in general. It is not appropriate for the LS to suppress localization in general (consider Visual Studio, for example).

Duplicate of #5043

authors: DonJayamanne MikhailArkhipov


text:
Spell check not working

Hi,
I installed this today and it's not working. I checked through the files in the .vscode file and everything seems to be in-place. I'm i skipping a step or do I have something else to activate? Thanks-Adolfo

Hi Adoflo,
Is the spell check extension still not working for you?  There shouldn't be any extra steps besides restarting VS Code.  You don't see any spelling checks when you open a Markdown file?

Greg

Hi Greg,
Thanks for the response. No, I get no errors or spellcheck. It shows up under installed extensions and I'm not getting any errors.
Thanks - Adolfo

Hi,
Sorry you are having issues, one question that may help narrow this down is what language are you using (default support is markdown/text only).  You can change the supported languages but those are the ones we start with.
Other than that I'm a little stumped so may need a little more detail on a file that is not working (a screenshot of the file content).
Definitely want to help so let me know.
Sean
p.s. I'm on holiday at the moment but will work to be pretty responsive.

@seanmcbreen Please enjoy your holiday! We can go over it when your back. Let me know...Thanks - Adolfo

It says "LanguageID: plaintext not suported for spell checking." for me.

fixed by adding https://github.com/Microsoft/vscode-spell-check/blob/master/.vscode/spell.json to the .vscode dir

Hopefully this is all resolved now so good luck.  Re-open if not.

repo: Microsoft/vscode-spell-check


text:
Git viewlet flashing like a discotheque

Open git viewlet, have some changes in index, open diff view
add a comit message, cmd + enter
notice the diff view and viewlet flashing

It's pronounced advantage.

Actually diff viewlet is also flasshing like crazy when I do any git operation. Also outside of vscode, like doing a git pull makes me feel like I am in the 70s

cc @alexandrudima @jrieken
This started happening with the recent tokens work in the editor. What happens is that the git extension thinks something might've changed, due to a FS event inside .git folder. It then notifies the API that all the text documents which it has provided content for have possible changed. The API asks the extension "so what's that new content?" Git spawns itself to retrieve the content and return it, which happens to never change in this scenario.
There are a few possible fixes:

Before firing the onDidChange for text documents, the git extension should first retrieve their content and only fire the event for the ones that actually changed.
@jrieken: The MainThreadDocuments could not set the model's contents if they haven't changed.
@alexandrudima: The editor could be less aggressive in re-tokenizing in case the contents haven't really changed.

Let me know your thoughts.

@joaomoreno The editor retokenizes if setValue() is called. Do not call setValue() if the contents didn't change. There was code in the gitland which checked for that (in a low memory pressure mode, via IRawText), perhaps that code got deleted?

That code doesn't exist anymore. The content comes through the text document provider API now.
IRawText gives me the content split into lines, which is hard to compare with the full content I have in a single string. How cheap is model.getValue()?

We can implement something that works for all virtual documents, like splitting and comparing lines

When virtual document didn't change, despite them sending a change event, I won't touch the underlying text document anymore.

Awesomesauce 🍻 Thanks!

authors: alexandrudima isidorn joaomoreno jrieken

repo: Microsoft/vscode


text:
while i use the second monitor, there is a problem about color.

VSCode Version: Code 1.9.0 (27240e71ef390bf2d66307e677c2a333cebf75af, 2017-02-02T08:23:30.856Z)
OS Version: Darwin x64 16.3.0
Extensions:

Extension
Author
Version

insertnumbers
Asuka
0.9.1

calculate
acarreiro
1.1.0

Bookmarks
alefragnani
0.10.2

code-runner
formulahendry
0.6.7

CppSnippets
hars
0.0.6

cpptools
ms-vscode
0.10.0

Steps to Reproduce:

Are you see the different,  all color theme have this problem when i use the second monitor in mac.

Noticed this as well, initially thought it had to do with the HDMI connection, but after trying with DisplayPort, it still happens. Running OSX as well.

#12473

authors: Ziao bpasero rcbcerwin


text:
Scrolling skipping

When I scroll using my touchpad, the scrolling regularly gets "stuck" and hangs for a minute, then jumps to where it should have been. This has been happening for at least a week, though I can't remember exactly for how long.

VSCode Version: Code 1.9.1 (f9d0c687ff2ea7aabd85fb9a43129117c0ecf519, 2017-02-09T00:26:45.394Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author
Version

path-intellisense
christian-kohler
1.2.0

python
donjayamanne
0.5.8

beautify
HookyQR
0.8.6

MagicPython
magicstack
1.0.6

mssql
ms-mssql
0.2.1

csharp
ms-vscode
1.7.0

PowerShell
ms-vscode
0.9.0

partial-diff
ryu1kn
0.2.0

vscode-sql-beautify
sensourceinc
0.0.4

Steps to Reproduce:

Open any file
Scroll using touchpad.

What type of laptop do you have?

Surface Book (i7, 16GB, 512GB config) on Windows 1607 build 14393.693.

https://github.com/Microsoft/vscode/issues/13612 and https://github.com/Microsoft/vscode/issues/12637

authors: bpasero jim256 roblourens


text:
Scrolling position is not synchronising in node loaded scripts

Ref: #23283

VSCode Version: 1.11.0
OS Version: Win10
Node Protocol: inspect and legacy

Steps to Reproduce:

Initiate remote debugging session.
Set a breakpoint in any of the <node_internals> file and hit it.
Close the file without any scrolling after the breakpoint was hit.
Open the same script via Debug: Open Loaded Script.

The opened script is scrolled to the top, whereas expected to scrolled to the same line, where it stayed after step 3.
Hitting the breakpoint, then navigating to another file and back also resets the scrolling position.

dup of https://github.com/Microsoft/vscode/issues/22420

authors: michelkaporin weinand


text:
Text may blurry on Windows

VSCode Version: 1.13.0
OS Version: Windows 10 Version 1703

Steps to Reproduce:

See GIF.

See also: #26800

I found that this problem and the general issue of "blurry fonts" completely goes away for me if locate Code.exe in the Windows Explorer, right-click and select the Compatiblity tab, and then check "Disable display scaling on high DPI settings".
The text is then completely sharp within VS Code and the editor text "flickering" issue that sometimes occurs when hovering the mouse over certain UI elements (as seen in @ArianeLu's captures) no longer occurs.
YMMV.

This is an upstream issue (possibly within Chromium), and there are no known workarounds that we could implement on our side. This means there is no possible code change for us to do in VS Code sources to improve things.
To keep the number of issues in our inbox at a manageable level, we’re closing issues that have been on the backlog for a long time but haven’t gained traction or that are not actionable. Thank you for your time and understanding.

authors: ArianeLu alexandrudima mattflix


text:
Run to cursor doesn't work as as expected

Repro:

Add some code similar like following:
Int FuncTest(int i)
{
int j=10;
int results=i+j;
return results;
}

int main()
{
int input;
int results=0;
cout<<"type an integer to continue:"<<endl;
cin>>input;
results=FuncTest(20);
cout<<"results"<<results<<endl;
return 0;
}

Set a breakpoint at line
line: "cout<<"type an integer to continue:"<<endl;" in main()
F5
Move to line "cin>>input;", and right click to select "Run to cursor"

Observe:
"Run to cursor" context menu still pop up there, and

It only takes effect after I move over the mouse to another place.
It only takes effect after I select the "Run to cursor" once again, and an addtional breakpoint was added in current line "cin>>input".

Note:  I am using a VM created from hyper-v, and this happens very frequently, however, I cannot repro this every time.

@richardzeng1985 let me know what C++ extension you are using and I will move this issue over.

@richardzeng1985 please file this issue against the C++ extension you are using.


text:
Debugger blocked when stepping over(OSX)

VSCode Version: Code 1.18.1 (929bacba01ef658b873545e26034d1a8067445e9, 2017-11-16T18:23:26.125Z)
OS Version: Darwin x64 16.7.0
Extensions:

Extension
Author (truncated)
Version

vscode-docker
Pet
0.0.22

code-settings-sync
Sha
2.8.6

project-manager
ale
0.23.0

npm-intellisense
chr
1.3.0

path-intellisense
chr
1.4.2

vscode-eslint
dba
1.4.3

githistory
don
0.2.3

ReactCodeSnippets
haz
1.2.1

diff-tool
jin
0.0.1

python
ms-
0.8.0

azure-account
ms-
0.2.2

debugger-for-chrome
msj
3.5.0

node-modules-resolve
nau
1.0.2

vscode-icons
rob
7.18.1

require-complete
sen
0.1.0

Align
ste
0.2.0

react-redux-es6-snippets
tim
2.1.0

beauty
yhp
0.0.2

Steps to Reproduce:

Start debugger, set breakpoint, launch request, breakpoint reached
Click on F10(step over), instead of going to next line it jumps to next breakpoint. If no breakpoint is set in the function then vscode remains in an uncertain state, with step over, step into and step out disabled(greyed-out) as if it waits for other requests, but the server does not send back the response. If I reload the debugger it releases the request and the server continues with the code processing.

Reproduces without extensions: Yes

+1

What version of node.js are you using?

node:8.2-alpine with docker swarm

The result of a "Step Over" is not always a stop in the next line.
If there is a breakpoint somewhere in the code being stepped over, the debugger will break there.
And if the code being stepped over contains a loop (e.g. a server) then the debugger will not break at all.

The problem appeared when VSCode was updated. Until then step over functioned normally, just like debugging in Chrome.
Now if I click on step over it never breaks on the next line. If there is another breakpoint later in the function it breaks there(expected), otherwise it continues the rest of the function.
The same thing happens on my colleague's mac.
I'm surprised this does not happen to other people.
Is there a way for me to upload the
vscode-node-debug2.txt

https://github.com/Microsoft/vscode/issues/24678
it seems that 'smartStep:true' was the issue. I removed the line from the launch config and now it works.
Still, this issue started after the latest vscode update.

Are you debugging sourcemapped code? It should always step over code that doesn't have sourcemaps.

Probably not. It is a nodejs project run inside a docker container with pm2.

How does your launch config look like?

        {
            "type": "node",
            "request": "attach",
            "name": "local-Rest",
            "address": "127.0.0.1",
            "port": 5858,
            "restart": true,
            "protocol": "inspector",
            "smartStep": "true",
            "sourceMaps": false,
            "localRoot": "${workspaceRoot}/server",
            "remoteRoot": "/opt/mo/server"
        },

I removed the smartStep line and now it steps over normally again.

Like https://github.com/Microsoft/vscode/issues/24678 says, smartStep only is for use with sourcemapped files. If you aren't using sourcemaps then this sounds like correct behavior.

authors: meetzoo razvip91 roblourens weinand


text:
Enhancement : Jump to next/prev block

Could you implement this feature inside the Editor ?
jump with the cursor vertically across space separated blocks, skipping empty lines.
This helps to quickly navigate thru our code, it's possible in many editors.

Thanks !

It's a good extension candidate, AFAIK Vim extension implements this feature.

I'm too busy next weeks to read the VSCode API doc and build an extension :/
Could be very quick for anyone who already knows how to build one. Who wants ?  @rebornix

authors: Aarbel rebornix


text:
cannot download .deb from site

VSCode Version: 1.18
OS Version: ubuntu 17

Steps to Reproduce:

https://code.visualstudio.com/
Download link does not work

This site can’t be reached

az764295.vo.msecnd.net’s server DNS address could not be found.
DNS_PROBE_FINISHED_NXDOMAIN

Works for me, maybe it's an issue with your network?

authors: Tyriar bnovf


text:
Regression: Search with regular expressions is broken.

VSCode Version: 1.19.1
OS Version: Debian Testing / Ubuntu 16.04

Steps to Reproduce:

Create a file with the following text in it:

// Copyright 2017 MyProject
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//     http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

Go to the Search tab, enable regex search, and type:
// Copyright 2017[\s\S]*the License.

--->> vscode doesn't find anything.
--->> It should find the entire text above.
Reproduces without extensions: Yes.

The dot in your search expression must be escaped to match your example text.
But regardless, the regexp search seems to be limited to single lines

Multiline search isn't supported, this isn't a regression: https://github.com/Microsoft/vscode/issues/13155

authors: nyri roblourens testing-in-chrome


text:
[Bug] Using the Tab key to indent messes the code

VSCode Version:  0.10.8 (0.10.8)
OS Version: OS X EL Capitan 10.11

Steps to Reproduce:

Select the try block in following the code
Hit tab
Hit Command+z

Code:
function discoverTimeZone(lead, phone) {
    try {
        lead.timezone = timezoneHelper.getTimeZoneForNumber(lead[phone]);
    } catch (e) {
        lead.penalty = 1;
    }
}

This bug happens in other pieces of code, there is no way of undo the change with Command+z which makes it even worse. Command+Shift+z also does not help.
The workaround is to pray you saved the file in the right time, close the file from the recent files, pray once more, and open the file again.

Its even worse when the block of code is bigger, the code is left much more messed up. The above example you can still make sense of whats left of the code.

Updating vscode will fix this issue. I think it was this one: https://github.com/Microsoft/vscode/issues/2829

authors: Tyriar pedroassis


text:
code crashed with SIGSEGV in __start_google_malloc()

VSCode Version: 1.21.0-1520420608
OS Version: Ubuntu 18.04

Steps to Reproduce:

Install VS Code from .deb package
Attempt to launch VS Code

Does this issue occur when all extensions are disabled?: Yes

@flexiondotorg have you seen anything like this happening on Ubuntu 18.04? This is the first time I've seen mention of "__start_google_malloc"

I'm experiencing this crash as well, VSCode 1.21.1 on Ubuntu 17.10, but I've found a workaround at https://divideandconquer.se/2017/11/23/workaround-for-crashing-electronatom-applications/

The workaround is starting VSCode using GTK2_RC_FILES= code

Thanks for the info @bartvanheukelom. I'll close this off as it seems to be a problem with Ubuntu/GTK2 and we'll be moving to GTK3 soon.

FYI @bpasero

@davidgu @bartvanheukelom does it reproduce with https://az764295.vo.msecnd.net/exploration/cf078a8a932cd399f9e475b5ad4226bbc93543ab/code-exploration-1.22.0-1522130024_amd64.tar.gz ?

authors: Tyriar bartvanheukelom bpasero davidgu


text:
Explore to update to Electron 2.0.x

Hey!
We are in the process of updating VSCode’s Electron version to a new major release (from 1.7.x to 2.0.x). For that reason we would like to get some testers onto this version, which we currently not plan to distribute via insiders but as a separate install that can be run side-by-side with other installs. This install is separate with regards to everything (settings, keybindings, extensions), so it will not touch any of your existing configuration.
Builds

Windows x64: Download
Windows ia32: Download
macOS: Download
Linux (deb): Download
Linux (rpm): Download

Feel free to file issues as you see them, thanks 👍

I created a side-by-side install (with orange icon :large_orange_diamond:!) so that we do not tamper with stable or insiders data. It even supports auto-updates (except for Linux) as we push more changes to our adoption branch. These bits are from last week friday and should be as stable as our insider releases:
Windows x64: https://az764295.vo.msecnd.net/exploration/395608d787740e20d207d278c4d1494995a719a9/VSCodeSetup-x64-1.22.0-exploration.exe
Windows ia32: https://az764295.vo.msecnd.net/exploration/395608d787740e20d207d278c4d1494995a719a9/VSCodeSetup-ia32-1.22.0-exploration.exe
macOS: https://az764295.vo.msecnd.net/exploration/395608d787740e20d207d278c4d1494995a719a9/VSCode-darwin-exploration.zip
Linux (deb): https://az764295.vo.msecnd.net/exploration/395608d787740e20d207d278c4d1494995a719a9/code-exploration_1.22.0-1520951054_amd64.deb
Linux (rpm): https://az764295.vo.msecnd.net/exploration/395608d787740e20d207d278c4d1494995a719a9/code-exploration-1.22.0-1520951202.el7.x86_64.rpm

How do I test this thing? I just upgraded to Nvidia 390.42 and this seems to have fixed my X crash issue but I'm keen to help test out this branch. Is there a tag or branch to check out to get these builds? I run Arch so debs and rpms are not relevant to my system.

What's the main difference(s), to look out for?

Works for me, so far, with all my favorite extensions, themes, and user settings.
Where would I copy over snippets etc. from Insiders to this one?

@l0k1verloren this build is from branch https://github.com/Microsoft/vscode/tree/tyriar/electron-2.0.x. Best way to test it is to use it for daily development and report back if you encounter any issues 👍
@smlombardi visually nothing should change really. On Linux, since GTK3 is now used (over GTK2) some file dialogs and menus will likely look different.
You will have to manually copy settings and keybindings over to this build as nothing is shared. Just open the files in one instance and copy the contents over to the other.

I switched to the tyriar/electron-2.0.x branch and built and ran it and it seemed normal (exceept nice gtk3 file dialog) but then when it opened a folder nothing rendered and the menus didn't respond.

@l0k1verloren on what Linux distribution are you? can you show a screenshot or video what you see?

uname -a Linux monolith 4.15.9-1-ck #1 SMP PREEMPT Tue Mar 13 11:27:38 EET 2018 x86_64 GNU/Linux
Antergos Linux (Arch), fully up to date as at right now.
Initial startup:

After opening a (golang) repository folder:

@Tyriar on this GTK2 vs GTK3 issue if you have any ideas.

@l0k1verloren and this works fine with VS Code stable? Do you see any output in the developer console (Help > Toggle Developer Tools > Console) when you bring up the dialog?

Something is off with the menu bar colors for me - it's white on light grey with the Breeze GTK3 theme.

@K900 this Electron update comes with a change of GTK2 to GTK3, so I am expecting visual changes in native menus and file dialogs. Can you share a screenshot? Does it look different from other application menus?

It's not an issue in, say, gtk3-demo:

@K900 can you confirm that you are not seeing this with Code stable?

Everything is fine on stable (GTK2), yeah.

@K900 have you seen this issue with other applications on your machine?

@l0k1verloren do you have Chrome installed? I wonder if you could try the file dialog there to see if it fails too (File > Open File).

Chrome doesn't have a menu bar, does it? Firefox does have a menu bar, but it uses the Firefox theme colors. All the GTK3 demo apps use the correct colors.

@K900 yeah good point, how does the context menu in VSCode look like, is it also using bad colors?

The context menu is fine, it's just the menu bar that's using the wrong font color.

@K900 does it also reproduce if you are not using any special theme?

Happy to report it (2018-03-13T14:22:28) seems to work very nicely on Debian testing with Adwaita Dark themed GTK3 and it's nice to see the old GTK2 parts gone. The only minor cosmetic thing I noticed is that the editor background color is dark greyish on lines with text and a few more after file end but then turns black. The same applies to the line number pane. Looking forward to this major update of this excellent editor.

@bpasero what do you mean by "special" theme? Just default Adwaita?

@K900 I thought "Breeze GTK3 theme" was a special theme you enabled
@bjornharrtell can you show me a screenshot of that?

Breeze is just a GTK theme like any other, it's styled to look like the default KDE Breeze style for Qt. I can try it with the default GTK3 theme that GNOME uses.

@K900 yes please. any hints how I can install that theme into Ubuntu 17 or 16?

You should be able to just apt install breeze-gtk IIRC, though it's been a while since I last used Ubuntu on a desktop. I'll test with some other themes later and see what I can find.

@K900 what Linux distribution are you on?

Arch testing, everything up to date. Also, it does look correct (dark background, light text) with the default GTK3 theme, so it might be a Breeze bug.

@basarat ：Nice to accept the beta version!
Well……I wanna know more about this (NOT ONLY listed below):

Are you willing to upgrade Nodejs to version 8.9.X? Or have you got a similar plan to publish a new version of re-writing Electron with the big changed version of Nodejs (example: When the specific version of Nodejs isn't maintained, that's the time maybe you will consider upgrade VSC)?

Any other new plans of new features/big changes?

@MaleDong this update (Electron 2.0.x) is coming with node.js 8.9.3. As for other plans you can always check our Roadmap.

Looking forward to this update making it into the insiders / stable build because it fixes the font rendering issues I have been facing on Linux (I'm using Ubuntu 18.04). The text is much crisper and I no longer see  blue lines between the characters (see screenshots).
I haven't really used this version for doing any work, but the menus look fine.
Exploration version:

Insiders version:

@HendrikThePendric the font rendering issue can be traced back to https://bugs.chromium.org/p/skia/issues/detail?id=6663 and I think it has been fixed on electron 1.7.x series so that issue should hopefully go away before vscode migrates to electron 2.x.

@HendrikThePendric @bjornharrtell yes this will come in through the Electron 1.7.12 update that I just merged.

@bpasero I saw insiders is now running on electron 1.7.12. It looks a lot better indeed. Fonts are sharp but colors are still a bit flat. In this electron 2.0 branch the colors are looking much better:
Insiders on electron 1..7.12

Exploration version

@HendrikThePendric interesting, I was not aware of any color changes in fonts to be honest.

Looking forward to full gtk3 support. Much better integration with the system. Why trying this build I noticed an issue with spacing in dialog boxes.

I feel the buttons are too large. And Primary and secondary text should be aligned. And maybe use suggested Icon style for Restart button.
Here is an example following elementary HIG (Gnome also follows a similar approach)

Finally one more thing I would like to see is csd support.
OS Info:
elementaryOS 0.4 Loki
(Default theme)

@arshubham thanks for the feedback. the dialogs are not under VSCode control though and I suggest you report this over at Electron repository so that we get attention from there: https://github.com/atom/electron

@K900 @l0k1verloren can you retry the issues you saw with our new drop: https://az764295.vo.msecnd.net/exploration/51470c58bd748e1689ba3d82811fe3df9efa72d4/code-exploration-1.22.0-1521641787_amd64.tar.gz

The toolbar coloring issue seems to be fixed for me. Thanks!

I love the gtk3! :) Though oddly the file/folder open doesn't allow me to create sidebar shortcuts. I think there might be more than a few issues you guys wanna raise with the electrum 2 repo.
I should also just add that my issues with crashing electron apps was completely solved by rolling back my arch distro to the current packages as at december 31. I suspect nvidia but it could also be the kernel causing the X crash issue. Nvidia is the prime suspect for me now, after just fixing a friend's son's gaming machine that had started completely bombing out and restarting during GPU accelerated apps - probably the linux kernel handles the driver fault more gracefully only dropping me back to lightdm but I'm not upgrading my nvidia driver for quite some time now as a result. The issue is very serious and it was distracting me terribly from doing my work.

Closing, thanks for feedback (still keep it coming if any). We plan to merge this work early in next months sprint.

Reopening as this continues for April via https://github.com/Microsoft/vscode/pull/47289. The exploration builds are running again with Electron 2.0.0-beta.7.

@bpasero Can we expect performance improvements?

The build download links are dead, any new ones?

@farid-fari I fixed the links, please try again

Integrated terminal is bugged a bit, the more text it has the slower it gets, To repro it just type in help and try to use it, it becomes very unresponsive. (This was tested on Fedora 27 x64)

@cra0zy and you are not seeing this in Code stable?

Not seeing it in stable.

This seems to be the Linux manifestation of https://github.com/electron/electron/issues/12042 then.

Tested on another Linux device and the same thing occurs there, so its a global Linux x64 problem it seems.

@cra0zy any difference if you run "code --disable-gpu" from the command line?

None.

Is Electron 2.0 supposed to bring capabilities of theming on menu bar and context menu in order to have them dark when using dark theme? If yes, it's not working:

@Geobert no

@Geobert the effect relating to dark themes is for a system running a GTK+3 theme, not for Windows. On windows Electron uses the windows file and other dialogs and windows menus. On Linux this issue of mixed theming is because of the main GUI running GTK+3 but Electron using GTK+2 and is a common issue. There is ways to override the GTK+2 theme with dark but it does not flip on the 'dark theme' toggle, which only affects GTK+3

Thanks for the explanation!

This will fix the High sierra native tabs issue. https://github.com/electron/electron/issues/10657#issuecomment-382007214

Hi, could you please update the exploration builds so that they are based on the April release? I would like to use the exploration version to develop an extension with a webview and a dependency that requires node 8. Currently the webview api is missing from these builds and node 8 is missing from the stable release.

@christianvoigt the exploration build is really up to date. It should get updated automatically. What OS are you on?

ah ok. That's strange. Because if I run the webview-sample I get "Running the contributed command: 'catCoding:start' failed." And the Output Log (Extension Host) shows the following error:
[error] TypeError: vscode.window.createWebviewPanel is not a function
Running the webview-sample in my normal VS Code installation works fine. I am on OSX.

@christianvoigt this is the link to the latest exploration build on macOS: https://az764295.vo.msecnd.net/exploration/163e64ca7bbd0a69c727cfd9f5610e7546207a71/VSCode-darwin-exploration.zip

Thank you! With the latest build it is working. So I for some reason the automatic update did not work I guess.

I downloaded this exploration build and took it for a spin.  Specifically, I wanted to check out the native tabs on High Sierra.  The Native Tabs functionality is not fixed, even with Electron 2 in the build*.
I tested the contributed phoenixgao build some time ago and it worked.  @bpasero I'm recalling some comments over there - is the key here that the Electron package must be built on a High Sierra machine?  If so, how can this ever be fixed properly?
High Sierra 10.13.2 (17C88)
Version 1.24.0-exploration (1.24.0-exploration)

(not exactly the same as before either, now the native 'Add New Tab' plus sign doesn't show on the far right of the bogus full-width tab).

@johnelm Electron did NOT fix this issue properly. As soon as a new macOS version is released, the issue will show up again. I would suggest to join me in blaming the "fix" here: https://github.com/electron/electron/issues/10657#issuecomment-382054649

Merged to master.

Reverted this change again, too many bugs...

@bpasero In my opinion, Would you please think about update to Electron 3.x directly?
Electron 3.0.x is now in beta , I think there is no need to take time to adopt 2.0.x.
Thanks.

@LiPengfei19820619 we're looking at that as well, it's probably a little naive to assume there won't be just as many issues adopting it too though.

@Tyriar Yes, I Know. I don't think it would be an easy work. I appreciate all your job,
As I have been using VS Code for a long time, and I wish VS Code would be  better and better.

@bpasero @Tyriar  So how do you want to handle this issue differently than the approach of the last iteration?

Merged into master, the latest Insiders is on 2.0.5 https://github.com/Microsoft/vscode/pull/54873

authors: Geobert HendrikThePendric K900 LiPengfei19820619 MaleDong Tyriar arshubham bjornharrtell bpasero christianvoigt cra0zy farid-fari jens1o johnelm l0k1verloren smlombardi tushar-singh


text:
Uncaught TypeError: Cannot read property 'beginFrame' of undefined

Issue Id: 12ca1213-b307-9bdf-d410-7c1a071af500Versions - 1.24.0-  92754223624dcbe9aca0e5ca3ba8a53808b122b6-  a8816968fed45b2cf2ecd67dd3a1678c819d19b3Stack TypeError: Cannot read property 'beginFrame' of undefined    at TextRenderLayer.onGridChanged (\node_modules.asar\vscode-xterm\lib\renderer\TextRenderLayer.js:143:24)/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts#481:25    at \node_modules.asar\vscode-xterm\lib\renderer\Renderer.js:154:60    at Array.forEach (native)    at Renderer._renderRows (\node_modules.asar\vscode-xterm\lib\renderer\Renderer.js:154:28)    at RenderDebouncer._innerRefresh (\node_modules.asar\vscode-xterm\lib\utils\RenderDebouncer.js:29:14)    at \node_modules.asar\vscode-xterm\lib\utils\RenderDebouncer.js:24:88

Upstream PR is out: https://github.com/Microsoft/vscode/issues/51663

You can review via code review of the PR

authors: Tyriar vscodeerrors


text:
Implement interface snippet does not show.

So, I was configuring my project to work with typescript, when after creating tsconfig.json and eslint.json files, after creating a simple interface and trying to implement it in a class suddenly I notice that the yellow bulb appears but only with the option of moving my class to another file but no the implement snippet, What Am I doing wrong?
I already installed tslint extension, tried reloading and disabling and nothing works.

Is there a red squiggly indicating that the interface is not implemented properly? Please share some example code

Yeah.
Here is my Example code.
export interface IExample {
     add(data: any): void;
     delete(id: number): void
}

And a Class that implements it.
export class SampleClase implements IExample {
}

After that, the yellow bulb that suggests to implement all the methods does not appear.

I'm unable to repo this. Can you please test that example in the latest vscode build

authors: OttoChamo mjbvz


text:
Extension API: Event when text editor is moved to another position/group

vscodevim requires a unique ID for each editor. We are currently generating this ID based off of the document's filename and position (ie. viewColumn). However, we'd need to keep this ID up-to-date as the user moves the document to a new position.
As per @bpasero in https://github.com/Microsoft/vscode/issues/51001#issuecomment-397534057, the existing onDidChangeTextEditorViewColumn event only fires when:
* you move the group (containing all editors) to another position in the grid
* you close a group and as a result the position of other groups changes (e.g. close a group to the left of the current one)

We do not fire an event if you drag a single editor tab out of a group into another group. But this behaviour is totally unrelated to us moving to a grid model, it has always been like that for the reasons I mentioned earlier.

What I am requesting is an event that an extension can register on to be notified anytime an editor changes position in the grid.

/duplciate of #15178

authors: jpoon jrieken