text:
trigger push when networks change

fixes https://github.com/istio/istio/issues/30054 by checking for a diff in the networks for a given service that was updated. If there is any difference, we trigger a push.
This does not cover what happens if the label was on a Service and was then removed. It's difficult to tell which network the label was previously, so we don't know which network to remove this gateway from.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
a9b42f2d4919bfe38ecb33605878a7a180ee404e
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
a9b42f2d4919bfe38ecb33605878a7a180ee404e
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for the quick fix!

Thanks for the quick fix!

I think this is not right unless i understand something wrongly. Full push doesn't mean the eds would be regenerated.
		builder := NewEndpointBuilder(clusterName, proxy, push)
		if marshalledEndpoint, f := eds.Server.Cache.Get(builder); f {
			resources = append(resources, marshalledEndpoint)
			cached++
		} else {
			l := eds.Server.generateEndpoints(builder)

I think this is not right unless i understand something wrongly. Full push doesn't mean the eds would be regenerated.
		builder := NewEndpointBuilder(clusterName, proxy, push)
		if marshalledEndpoint, f := eds.Server.Cache.Get(builder); f {
			resources = append(resources, marshalledEndpoint)
			cached++
		} else {
			l := eds.Server.generateEndpoints(builder)

@hzxuzhonghu I think since we don't set ConfigsUpdated on req we will clear the cache: https://github.com/istio/istio/blob/38f5f0d13309c982194d339b7dc3dd18018d3927/pilot/pkg/xds/ads.go#L795. It's a bit difficult to selectively clear the cache based on which network had gateways change, because a single eds cluster can be part of several networks.

@hzxuzhonghu I think since we don't set ConfigsUpdated on req we will clear the cache: https://github.com/istio/istio/blob/38f5f0d13309c982194d339b7dc3dd18018d3927/pilot/pkg/xds/ads.go#L795. It's a bit difficult to selectively clear the cache based on which network had gateways change, because a single eds cluster can be part of several networks.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test release-notes_istio

gencheck_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test release-notes_istio

gencheck_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test release-notes_istio

gencheck_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test gencheck_istio

lint_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test release-notes_istio

gencheck_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test gencheck_istio

lint_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

added a test that actually triggers eds before/after the gateway is added, to make sure we cover the caching logic

added a test that actually triggers eds before/after the gateway is added, to make sure we cover the caching logic

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test gencheck_istio

lint_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test lint_istio

release-notes_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test gencheck_istio

lint_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test lint_istio

release-notes_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test gencheck_istio

lint_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test lint_istio

release-notes_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test release-notes_istio

unit-tests_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test gencheck_istio

lint_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test lint_istio

release-notes_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test release-notes_istio

unit-tests_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test gencheck_istio

release-notes_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test release-notes_istio

unit-tests_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test unit-tests_istio

lint_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
45a5136796f69850878261cf9169be1fef91bdf7
link
/test gencheck_istio

release-notes_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test release-notes_istio

unit-tests_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test unit-tests_istio

lint_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test release-notes_istio

unit-tests_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test unit-tests_istio

lint_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test lint_istio

gencheck_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test release-notes_istio

unit-tests_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test unit-tests_istio

lint_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test lint_istio

gencheck_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test unit-tests_istio

lint_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test lint_istio

gencheck_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test gencheck_istio

release-notes_istio
962e4fe736f26084f2cdc14d7c7b72e9941e7994
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test unit-tests_istio

lint_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test lint_istio

gencheck_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test gencheck_istio

release-notes_istio
962e4fe736f26084f2cdc14d7c7b72e9941e7994
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test unit-tests_istio

gencheck_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test gencheck_istio

release-notes_istio
962e4fe736f26084f2cdc14d7c7b72e9941e7994
link
/test release-notes_istio

lint_istio
962e4fe736f26084f2cdc14d7c7b72e9941e7994
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test unit-tests_istio

gencheck_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test gencheck_istio

release-notes_istio
962e4fe736f26084f2cdc14d7c7b72e9941e7994
link
/test release-notes_istio

lint_istio
962e4fe736f26084f2cdc14d7c7b72e9941e7994
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test unit-tests_istio

release-notes_istio
962e4fe736f26084f2cdc14d7c7b72e9941e7994
link
/test release-notes_istio

lint_istio
962e4fe736f26084f2cdc14d7c7b72e9941e7994
link
/test lint_istio

gencheck_istio
962e4fe736f26084f2cdc14d7c7b72e9941e7994
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
39476c490c0b8d7688d47661eb8749d3971920d8
link
/test unit-tests_istio

release-notes_istio
962e4fe736f26084f2cdc14d7c7b72e9941e7994
link
/test release-notes_istio

lint_istio
962e4fe736f26084f2cdc14d7c7b72e9941e7994
link
/test lint_istio

gencheck_istio
962e4fe736f26084f2cdc14d7c7b72e9941e7994
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
962e4fe736f26084f2cdc14d7c7b72e9941e7994
link
/test lint_istio

release-notes_istio
7c561222e8c8d27706e5f658c608488fbb35c106
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
962e4fe736f26084f2cdc14d7c7b72e9941e7994
link
/test lint_istio

release-notes_istio
7c561222e8c8d27706e5f658c608488fbb35c106
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

good to know that

good to know that

@stevenctl: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevenctl: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

In response to a cherrypick label: #30070 failed to apply on top of branch "release-1.9":
Applying: trigger push when networks change
Applying: add reason
Applying: lint
Applying: e2e unit test
Using index info to reconstruct a base tree...
M	pilot/pkg/model/push_context.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/model/push_context.go
CONFLICT (content): Merge conflict in pilot/pkg/model/push_context.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 e2e unit test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: #30070 failed to apply on top of branch "release-1.9":
Applying: trigger push when networks change
Applying: add reason
Applying: lint
Applying: e2e unit test
Using index info to reconstruct a base tree...
M	pilot/pkg/model/push_context.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/model/push_context.go
CONFLICT (content): Merge conflict in pilot/pkg/model/push_context.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 e2e unit test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #30185

In response to a cherrypick label: new issue created for failed cherrypick: #30185

In response to a cherrypick label: #30070 failed to apply on top of branch "release-1.8":
Applying: trigger push when networks change
Applying: add reason
Applying: lint
Applying: e2e unit test
Using index info to reconstruct a base tree...
M	pilot/pkg/model/push_context.go
M	pilot/pkg/serviceregistry/kube/controller/fake.go
M	pilot/pkg/xds/fake.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/xds/fake.go
CONFLICT (content): Merge conflict in pilot/pkg/xds/fake.go
Auto-merging pilot/pkg/serviceregistry/kube/controller/fake.go
Auto-merging pilot/pkg/model/push_context.go
CONFLICT (content): Merge conflict in pilot/pkg/model/push_context.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 e2e unit test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to a cherrypick label: new issue created for failed cherrypick: #31484

authors: hzxuzhonghu istio-testing stevenctl


text:
Add client go update

Add client-go to update_deps.sh as it is an istio.io dependency
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[X] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any changes that may affect Istio users.

@jacob-delgado: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
a2dfb4522be0285ffcb40a6a0bc6d15f9f9d7678
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jacob-delgado: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
a2dfb4522be0285ffcb40a6a0bc6d15f9f9d7678
link
/test gencheck_istio

unit-tests_istio
a2dfb4522be0285ffcb40a6a0bc6d15f9f9d7678
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jacob-delgado: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-multicluster-tests_istio
6a8057190fa673019bda5b98fe7996d1ae4f8047
link
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster-tests_istio

source: gharchive/pull-request

authors: istio-testing jacob-delgado

repo: istio/istio

license_type: permissive

license_source: github-api


text:
operator: add resourcequotas in clusterrole

Please provide a description of this PR:
part of fixes: https://github.com/istio/istio/issues/41159
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

Can you edit the body of your PR? This is a partial fix. Change it from fixes to part of

Not sure this is super safe... resourceQuota is a SUPER high privilege. Can we really just force all users into using this?

The operator is already highly privileged. https://kubernetes.io/docs/concepts/policy/resource-quotas/ Looks safe to me

Not sure this is super safe... resourceQuota is a SUPER high privilege. Can we really just force all users into using this?

what about remove this, users should configure this manual?

I'd like someone that has an interest in the operator to review this. It doesn't seem great from a security perspective to me, but I think the whole operator is flawed from a security perspective so maybe I am biased :-)

I'd like someone that has an interest in the operator to review this. It doesn't seem great from a security perspective to me, but I think the whole operator is flawed from a security perspective so maybe I am biased :-)

I agree with the point about security perspective.
IMO, something not working is worser.

I'd like someone that has an interest in the operator to review this. It doesn't seem great from a security perspective to me, but I think the whole operator is flawed from a security perspective so maybe I am biased :-)

I agree with the point about security perspective. IMO, something not working is worser.

Not sure this is super safe... resourceQuota is a SUPER high privilege. Can we really just force all users into using this?

what about remove this, users should configure this manual?

I do not feel grant operator controller resourcequota is no worse than the current permissions. If you all agree with that, I think I am ok with this permission addition.

I do not feel grant operator controller resourcequota is no worse than the current permissions. If you all agree with that, I think I am ok with this permission addition

Fair enough

I do not feel grant operator controller resourcequota is no worse than the current permissions. If you all agree with that, I think I am ok with this permission addition

Fair enough

Thanks john.

In response to a cherrypick label: new pull request created: #41945

In response to a cherrypick label: new pull request created: #41946

In response to a cherrypick label: new pull request created: #41947

authors: howardjohn istio-testing litong01 upodroid zirain


text:
[release-1.13] Fix GetKubernetesVersion

Please provide a description of this PR:
#41822

A note that 1.13 is EOL so we wouldn't build any more patch releases.

authors: ericvn hzxuzhonghu


text:
Add configurable priorityClassName to Gateway

Add the ability to configure the priorityClassName in the "gateway" helm chart.
Signed-off-by: Derrik Campau dcampau@vmware.com
Please provide a description of this PR:

Hi @erismaster. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

I updated the docs here to remove the statement that helm is being deprecated. I did a similar change in a prior PR but missed this one.
Also, do I need to add this key into profiles/default.yaml? I see that there is a "gateways" section but that seems to line up with the older "gateways" chart, rather than the "gateway" chart.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

authors: erismaster istio-testing


text:
Cleanup legacy ENABLE_LEGACY_LB_ALGORITHM_DEFAULT flag

This has been around for 1 year and was added for backwards compat opt-out; time to remove

/retest

Should this have been removed without an alternative for setting mesh policy? LEAST_REQUEST in rare scenarios can result in poorer performance than ROUND_ROBIN, especially in scenarios where a service hosts endpoints with varying endpoint latency compared to round robin. While the LB algorithm can be specified in DestinationRule, the need to apply the LoadBalancing algorithm to every single DestinationRule creates a new problem in and of itself that adds unnecessary complexity compared to an option from the administrators of Istiod.
Those who opted-out using the env variable may like to keep it in perpetuity and it would probably be better to move it from an env var to a separate configuration rather than removing the possibility altogether.

As mentioned the env is only intended during transition period. Also as you mentioned the change is needed only in rare cases - why can't you use Round Robin for such cases with a single/few DR changes?

As mentioned the env is only intended during transition period. Also as you mentioned the change is needed only in rare cases - why can't you use Round Robin for such cases with a single/few DR changes?
The problem lies with discovery and configurability.

We could look at service metrics and identify ones with varying latency for that specific issue but there may be other patterns which work with round robin and not with least connections.
As the cluster maintainers of Istio and service owners usually have separate domains of understanding where workload owners are responsible for custom DestinationRules they deploy. Verification of workloads falls upon a service owner when developed + deployed. When the default (cluster admin responsibility) is changed that responsibility is shifted to the team performing the upgrade and maintaining the deployed Istio version. In large clusters, while we can scan all DR it is infeasible to always be up to date on the traffic specifics of each service, similar to as how as a maintainer of Istio it is impossible to know how the traffic patterns of all applications running Istio in the wild. Or if a service owner is unaware of the change notes and deploys a new DestinationRule that overwrites the default system DestinationRule without knowing the update has changed the default LB policy and the update is gradually rolling out to the cluster. As a result many issues are only found upon change/upgrade and in environments with specific traffic patterns (i.e. if production has traffic that is not simulated in a pre-production environment).
On the note of the transition period, I can understand it the env var being transitory, but as for load balancing configuration it seems that anyone who opted to use the legacy flag would have kept it until it was no longer supported. This just pushed the investigation into dealing with incompatible workloads until the upgrade where the configurability was removed. A configuration of the default behavior seems like a reasonable tradeoff to changing the default behavior without being able to guarantee its compatibility with all existing workloads. We would be in the same scenario if LEAST_CONN was the old default and we changed to ROUND_ROBIN. Or if we removed the ability to enable localityLoadBalancing from meshConfig and required a DestinationRule to enable it without DestinationRule inheritance/merging.
Of course, using a DR to configure is the solution here but the problem is caused in totality by changing the default + having no way to configure the default. The result is that a cluster upgrade is now tied with workload semantics that were previously verified during workload development and ultimately complicates upgrades in larger deployments.

but the problem is caused in totality by changing the default + having no way to configure the default.

but the problem is caused in totality by changing the default + having no way to configure the default.

It was never intended to make the default configurable at Mesh wide. I do not think ROUND ROBIN was the right default. As you mentioned any default across mesh has issues with this specific config and depend on workloads.That is why we introduced that env var and kept it for 4 releases so that there are no surprises. When you started using the env flag, you should have planned for DR changes if the default is not appropriate for you and not wait till the upgrade that removed it.

I think that it’s reasonable that the default was changed if it was determined round robin was an insufficient default. However least conns has issues as a default as we have observed in our clusters as well. Like I mentioned before I think the change of default is more of an issue than the actual default itself.
Sure it’s accurate and fair to day there were 4 releases to work on the issue but the best solution for those 4 releases was changing the default to the legacy behavior. However, the problem is the same 4 releases ago or now. There is no good alternative to reverting the default lb algorithm rather than hunting down every single workload that is incompatible in its current state with the new default.
I would be inclined to say that providing the ability to alter the default is a sound decision because it is low effort compared to pushing users to find workarounds and the reason we have lb options is so that users may control the algorithm that suits them best. If a cluster is more suited to a specific algorithm it seems only reasonable that the cluster admin should be able to make that decision knowing their own circumstances.

authors: Minh-Ng howardjohn ramaraochavali


text:
Fix tracing in postsubmit tests

Please provide a description of this PR:
Should be the last pass of this.
I tested with the following script (key was setting nonuser to get the failure we are seeing before the fix):
#!/bin/bash
set -o nounset

  if [[ -n "${PULL_NUMBER:-}" ]]
   then
    set +o nounset
    url="https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/${REPO_OWNER}_${REPO_NAME}/${PULL_NUMBER}/${JOB_NAME}/${BUILD_ID},"
  else
    set +o nounset
    url="https://prow.istio.io/view/gs/istio-prow/pr-logs/${JOB_NAME}/${BUILD_ID},"
  fi
set -o nounset
echo ${url}

  echo "ci.pipeline.run.pull_number=${PULL_NUMBER:-none},"

Another change could be to change the first :- to a := which will actually set PULL_NUMBER to empty and we can remove the later :-none.


text:
[WIP] Test that multiple external services works as well

This PR adds a test case to pilot's e2e tests which checks that defining multiple external services works as well.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ronenschafferibm
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: yutongz
If they are not already assigned, you can assign the PR to them by writing /assign @yutongz in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @ronenschafferibm. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

Is this to test SNI or simply multiple external services? If it's the former, it seems to me that sni_hosts should include multiple URLs to justify the test.

@ronenschafferibm: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

authors: baodongli ijsnellf istio-testing ronenschafferibm


text:
Add myself to reviewers/owners.

It seems I don't have permissions to merge.
NONE

/tickle

authors: andraxylia costinm


text:
Add support for default expressions in template definitions

We should make it possible for template authors to specify default expressions for individual fields in a template definitions. If the instance defined by the operator doesn't include the given field, Mixer will use the default expression automatically.
This provides a way to have extremely low-cost instances where all the defaults are assumed. It also makes a better story when adding new fields to existing templates without having to update configs.

One thing is unclear to me. Expression's vocabulary is owned by the operator, they can choose to define their own attributes config and therefore the expressions used by the template developer might just not work. Which would mean with every template there should be an equivalent attributes config that expresses the vocabulary of attributes used in the default value expression.
WDYT ?

We've adopted a largely generic attribute vocabulary at this point, so I think it's reasonable for these templates to be expressed in terms of this generic vocab.

This issue was moved to istio/istio#1631

source: gharchive/issue

authors: geeknoid guptasu

license_source: bigquery


text:
istioctl should default to namespace of current context

istioctl defaults --namespace to k8s.io/client-go/pkg/api.NamespaceDefault which is the constant "default".
istioctl SHOULD use the namespace from the kubectl context.  This is the namespace you see when you do kubectl config view --output jsonpath='{.contexts[?(@.name == "'$(kubectl config current-context)'")]..namespace}'
Otherwise a user who is using a namespace other than default must do --namespace XYX on every operation.

please refile to https://github.com/istio/galley, which is the new home for istioctl

Issue moved to istio/galley #4 via ZenHub

authors: esnible kyessenov

repo: istio/pilot


text:
[WIP] Envoy v2 API support

What this PR does / why we need it:
Moving to Envoy V2 API
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1257
Special notes for your reviewer:
Release note:

NONE

This is a WIP and long ways to go.

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
8fb8de112f6795e12eae37c5cf0c93692e494f8d
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The .protos are from here, right?: https://github.com/envoyproxy/data-plane-api
Is there a way we can reference them instead of copying them?

I think @rshriram is nudging in my direction to set-up bazel for that ;)

Hey man, I am just trying to get things working in my gogland IDE. :P. And I did my due diligence on bazel for 2 hrs and failed as expected :P.

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
ff7cdba58f70230a17bdd905ca062939eeed60af
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

authors: ijsnellf istio-testing kyessenov rshriram


text:
benchmarks: benchmark various levels of concurrency

Additionally, properly shutdown ztunnel in tests. This ensures we do not have a bunch of stale ztunnels when we have multiple tests (noticed since now we have a lot of them)

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

test_ztunnel
4b2e5a5868cec563b1cbbe92ccfbe5ae0b351972
link
true
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

authors: howardjohn istio-testing

repo: istio/ztunnel


text:
Drain: allow more dynamic configuration

tl;dr: allow us to set one value for "draining" from the user
perspective, which sets both spec.terminationGracePeriodSeconds and
ztunnel's drain period.
TBH, this isn't super valuable without
https://github.com/kubernetes/kubernetes/pull/125746, since Helm could
just do the math, but its nice to future proof?.

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all


text:
Avoid redundant DNS requests

This modifies the approach described in https://github.com/istio/ztunnel/pull/672. Attempting to clarify some things we had discussed offline.

@nmittler: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

test_ztunnel
bda68d542b600584969e76209aec05d877f7a459
link
true
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Closing this, since it was just meant for discussion.

authors: istio-testing nmittler


text:
接口调用超时处理,prql超时处理

Branch name (分支名)
main
Bug description (缺陷描述)
No response

没有复现问题

repo: isxcode/spark-yun


text:
Integrationen können mit StreamingTemplateV02 nicht genutzt werden

Describe the bug
Im digiwf-connector tritt eine InvalidFormatException bei Benutzung des StreamingTemplatesV02 auf.
Caused by: com.fasterxml.jackson.databind.exc.InvalidFormatException: Cannot deserialize value of type `java.util.Date` from String "2023-06-12T13:27:59.466+02": not a valid representation (error: Failed to parse Date value '2023-06-12T13:27:59.466+02': Unparseable date: "2023-06-12T13:27:59.466+02")

Der Fehler tritt seit dem Workaround: https://github.com/it-at-m/digiwf-core/commit/3a05ca93c2ee3ac61f2250ccc6642403e1c58e16 auf. Vermutlich ist das Problem, dass die Engine und der Connector jeweils unterschiedliche Datums Formate bei der Json Serialisierung/Deserialisierung verwenden.

https://github.com/it-at-m/digiwf-core/pull/445

repo: it-at-m/digiwf-core

license: MIT


text:
#571: add tests for date picker

Description
Short description or comments
Reference
Issues #571

Ich schaue nochmal nach ob ich das auf on input ändere

Validation für on input mit aufgenommen

Wird ein Datum eingegeben und danach wieder gelöscht, kann das Formular nicht gespeichert werden, auch wenn das Feld kein Pflichtfeld ist.

authors: StephanStrehlerCGI lehju


text:
[Change request to #3211]

Description of a Change request:
Minor changes in AC #8
Acceptance Criteria
8. Allowed special characters !"#$%&'()*+,-./:;<=>?@[]^_`{|}~". Quantity of characters from 1 to 8000.
Impact of Change
#3211
Epic: #3194

Minor changes in AC #6

authors: DimaKarma VlasenkoYuliia

repo: ita-social-projects/GreenCity


text:
[API] [Friend list] [/friends/not-friends-yet] The response has a status 400 instead of 200 when entering ']', '{', '^', '`' symbols in the search field

Environment: Windows 10 Pro, Postman
Reproducible: always
Build found: 23.09.2023
Preconditions
The user is logged in, and the token is gotten.
Steps to reproduce

Send the request: GET greencity.greencity.social/friends/not-friends-yet?name={parameter}
(1 e.g. {parameter}: ']'
2 e.g. {parameter}: '['
3 e.g. {parameter}: '^'
4 e.g. {parameter}: '`'
5 e.g. {parameter}: '{'
6 e.g. {parameter}: '}'
7 e.g. {parameter}: '|')
Check a response.

Actual result
The status code is 400 Bad Request.

Expected result
The status code is 200 OK. The response has an empty array.
User story and test case links
User story #1003

Tomcat Server version 8.5+ cant decode special characters, we cant solve this problem until Tomcat in newer version solve it!

This bug is not reproduced

authors: HrushaNataliia Roksana77 VadimasikKPI ryhaldenys


text:
[A006] PROD: anomalia axis2...

Buongiorno
con una mutazione AIRE via WS A006 riceviamo il seguente errore "axis2ns22731:Server"
dati chiamata
      <idOperazioneComune>99852</idOperazioneComune>
      <codMittente>043043</codMittente>
      <codDestinatario>ANPR02</codDestinatario>
      <operazioneRichiesta>A006</operazioneRichiesta>
      <dataOraRichiesta>2019-10-14T13:58:12.286+02:00</dataOraRichiesta>
      <tipoInvio>PROD</tipoInvio>

risposta ricevuta
      <faultcode>axis2ns22731:Server</faultcode>
      <faultstring>Internal Error</faultstring>
      <detail/>

Resto in attesa
Grazie
Stefano by PAL

Il problema è capitato solo su questa operazione, in modo sporadico, oppure generalizzato?
Abbiamo aggiunto delle trace, potreste riprovare?
Grazie in anticipo per la collaborazione.
Saluti
Assistenza ANPR

Un problema simile, in realtà, è successo anche il giorno precedente
sempre con lo stesso comune e tipo operazione.
L'errore è apparso durante l'iscrizione di 2 soggetti all'estero della stessa famiglia
e riceviamo l'errore sempre con il secondo soggetto.
ecco i dati errati di una chiamata precedente
che poi è stata eseguita in un secondo momento è andata a buon fine
      <codMittente>043043</codMittente>
      <idOperazioneComune>99852</idOperazioneComune>
      <codDestinatario>ANPR02</codDestinatario>
      <operazioneRichiesta>A006</operazioneRichiesta>
      <dataOraRichiesta>2019-10-14T13:58:12.286+02:00</dataOraRichiesta>
      <tipoInvio>PROD</tipoInvio>

risposta
      <faultcode>axis2ns22731:Server</faultcode>
      <faultstring>Internal Error</faultstring>
      <detail/>

Infine un altro errore similare
l'avevo segnalato con questa issue
https://github.com/italia/anpr/issues/1665

Grazie delle informazioni, ma avete provato e vi è capitato ancora dopo la nostra prima risposta? (15 ottobre alle 18 circa?)
Come detto abbiamo effettuato qualche piccolo tuning.

Non ci risultano altri casi dopo l'aggiornamento, in assenza di riscontro chiudiamo la issue.
Saluti
Assistenza ANPR

No, non ho altre segnalazioni in merito
e purtroppo, nemmeno informazioni sulle tempistiche.
Stefano

authors: StefanoGuidetti mttfranci

repo: italia/anpr


text:
Uniformare e unire le sezioni Entity Statement e Configuration

abbiamo delle ripetizioni relative a "Entity Statement e Configuration" in it/configurazione_federazione.html e nel file entity_statement_entity_configuration.rst
obiettivo: evitare di fare differenze e disseminare le stesse informazioni o parti di queste in sezioni diverse.
è necessario configurare delle sezioni chiare e uniche per ogni entità

repo: italia/spid-cie-oidc-docs


text:
Richiesta verifica metadati Comune di Meolo

Buongiorno,
Si richiede la verifica dei metadati per conto del Comune di Meolo.
https://www.comune.meolo.ve.it/c027022/spid-metadata.xml
Il servizio in oggetto è realizzato con eGovernment Halley già validato in precedenza per altri clienti.

Il Metadata è stato deployato presso gli IdP e da essi caricato.

authors: AntonioGiovanniSchiavone halleyveneto

repo: italia/spid


text:
🛑 GPTW CARCA is down

In fdacb06, GPTW CARCA (https://greatplacetoworkcarca.com/es) was down:

HTTP code: 0
Response time: 0 ms

Resolved: GPTW CARCA is back up in 0efc5c8 after 16 minutes.

repo: itbm-services/projects


text:
Replace automated reconnecting with button in UI

Not only does this simplify the implementation a bit, it also gives
the user more control and a way of actioning an error state. It is
also more efficient because we don't try to re-connect in an endless
loop.
When disconnected:

When connected:

If maker goes down for a few minutes, the user will get fed up and annoyed after a few unsuccessful attempts at reconnecting.

Same argument could be made for the current solution. The website just says "Maker status: Offline" without giving the user any explanation why and no way of doing anything about it. Sounds pretty annoying to me :)

On the other hand, if we kept reconnecting, we could notify the user with a push notification that it's back online!

But with the current solution, the user doesn't know that retries are happening!
I am not against automated retries but at least from an engineering perspective, and endless loop with a constant timeout is a pretty bad solution.

repo: itchysats/itchysats


text:
Improve docs around dvclice/dvc.yaml

Try to make more obvious the differences between the auto-generated dvclive/dvc.yaml, a dvc.yaml pipeline, and the dvcyaml argument of Live.

Related: https://discord.com/channels/485586884165107732/563406153334128681/1122890201862262916

Also related: need to clarify that dvclive folder should be git-tracked, especially since other trackers usually add some similar folder that gets gitignored.

authors: daavoo dberenbaum


text:
Better logo image

It would be cool to have a nicer image for Slownik's logo.
Perhaps a mix of Polish and American flags. Or Polish Eagle on top of globe, UN-style?

Needs to look awesome when sharing links in social media, especially Facebook, Twitter and WhatsApp.

repo: itsff/polonijny

license: mit


text:
Stuck after Logged as ...

v10:44:19 | [MAIN/SUCCESS] | Logged on as ******

bot is awaiting for commands. If u sure that u sent command - check logs and send it to me (if any errors)

repo: itskekoff/discord-server-copy


text:
The min and max limits can be broken by selecting the year

The min/max limits only appear to affect the ability to select months within the current year. It's still possible to use the year selection arrows to go beyond the min/max limits (if they are set).

Fixed in v0.1.9

authors: ittus mjflint

repo: ittus/vue-monthly-picker


text:
ERROR failed to download from ... Double check that the given VERSION is valid

Hi, this looks like a repeat of #115.
I can download the server via my web browser or via wget with no issue.
I've tried running as root and as user.
I am using LATEST for the VERSION environment variable, but I have tried manually specifying 1.19.81.01
DEBUG Output:

DEBU[0000] Using /data to match uid and gid
DEBU[0000] Resolved UID=1000 from match path
DEBU[0000] Resolved GID=998 from match path
+ curlArgs=(-v)
++ id -a
++ ls -ld /data
+ echo 'DEBUG: running as uid=1000 gid=998 groups=998 with drwxrwsr-x+ 5 1000 998 4096 May  7 21:27 /data'
DEBUG: running as uid=1000 gid=998 groups=998 with drwxrwsr-x+ 5 1000 998 4096 May  7 21:27 /data
++ pwd
+ echo '       current directory is /data'
+ downloadPage=https://www.minecraft.net/en-us/download/server/bedrock
       current directory is /data
+ [[ TRUE != TRUE ]]
+ case ${VERSION^^} in
+ echo 'Looking up latest version...'
+ lookupVersion serverBedrockLinux
+ platform=serverBedrockLinux
+ for i in {1..3}
Looking up latest version...
++ restify --user-agent=itzg/minecraft-bedrock-server --headers 'accept-language:*' --attribute=data-platform=serverBedrockLinux https://www.minecraft.net/en-us/download/server/bedrock
++ jq -r '.[0].href'
+ DOWNLOAD_URL=https://minecraft.azureedge.net/bin-linux/bedrock-server-1.19.81.01.zip
+ [[ -n https://minecraft.azureedge.net/bin-linux/bedrock-server-1.19.81.01.zip ]]
+ break 2
+ [[ -z https://minecraft.azureedge.net/bin-linux/bedrock-server-1.19.81.01.zip ]]
+ [[ https://minecraft.azureedge.net/bin-linux/bedrock-server-1.19.81.01.zip =~ http.*/.*-(.*)\.zip ]]
+ VERSION=1.19.81.01
+ rm -f restify.err
+ '[' '!' -f bedrock_server-1.19.81.01 ']'
+ [[ ! -n https://minecraft.azureedge.net/bin-linux/bedrock-server-1.19.81.01.zip ]]
+ [[ /tmp != /tmp ]]
++ basename https://minecraft.azureedge.net/bin-linux/bedrock-server-1.19.81.01.zip
+ TMP_ZIP=/tmp/bedrock-server-1.19.81.01.zip
+ echo 'Downloading Bedrock server version 1.19.81.01 ...'
+ curl -v -o /tmp/bedrock-server-1.19.81.01.zip -fsSL https://minecraft.azureedge.net/bin-linux/bedrock-server-1.19.81.01.zip
Downloading Bedrock server version 1.19.81.01 ...
*   Trying 23.56.238.91:443...
* Connected to minecraft.azureedge.net (23.56.238.91) port 443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*  CAfile: /etc/ssl/certs/ca-certificates.crt
*  CApath: /etc/ssl/certs
} [5 bytes data]
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
} [512 bytes data]
* TLSv1.3 (IN), TLS handshake, Server hello (2):
{ [122 bytes data]
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
{ [29 bytes data]
* TLSv1.3 (IN), TLS handshake, Certificate (11):
{ [2627 bytes data]
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
{ [80 bytes data]
* TLSv1.3 (IN), TLS handshake, Finished (20):
{ [52 bytes data]
* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
} [1 bytes data]
* TLSv1.3 (OUT), TLS handshake, Finished (20):
} [52 bytes data]
* SSL connection using TLSv1.3 / TLS_AES_256_GCM_SHA384
* ALPN, server accepted to use h2
* Server certificate:
*  subject: C=US; ST=WA; L=Redmond; O=Microsoft Corporation; CN=*.azureedge.net
*  start date: Jul 27 23:19:41 2022 GMT
*  expire date: Jul 22 23:19:41 2023 GMT
*  subjectAltName: host "minecraft.azureedge.net" matched cert's "*.azureedge.net"
*  issuer: C=US; O=Microsoft Corporation; CN=Microsoft Azure ECC TLS Issuing CA 01
*  SSL certificate verify ok.
* Using HTTP2, server supports multi-use
* Connection state changed (HTTP/2 confirmed)
* Copying HTTP/2 data in stream buffer to connection buffer after upgrade: len=0
} [5 bytes data]
* Using Stream ID: 1 (easy handle 0x55e1d65472e0)
} [5 bytes data]
> GET /bin-linux/bedrock-server-1.19.81.01.zip HTTP/2
> Host: minecraft.azureedge.net
> user-agent: curl/7.74.0
> accept: */*
>
{ [5 bytes data]
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
{ [265 bytes data]
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
{ [265 bytes data]
* old SSL session ID is stale, removing
{ [5 bytes data]
* Connection state changed (MAX_CONCURRENT_STREAMS == 100)!
} [5 bytes data]
< HTTP/2 200
< content-length: 81096423
< content-type: application/octet-stream
< content-md5: 8lQjOhDE61Cwz3MKa/40WA==
< last-modified: Thu, 27 Apr 2023 15:44:59 GMT
< accept-ranges: bytes
< etag: "0x8DB47365B6BA508"
< server: Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0
< x-ms-request-id: abc20167-f01e-0139-1723-793027000000
< x-ms-version: 2014-02-14
< x-ms-lease-status: unlocked
< x-ms-lease-state: available
< x-ms-blob-type: BlockBlob
< date: Sun, 07 May 2023 21:27:46 GMT
<
{ [5 bytes data]

* transfer closed with 60155656 bytes remaining to read
} [5 bytes data]
* stopped the pause stream!
* Connection #0 to host minecraft.azureedge.net left intact
curl: (18) transfer closed with 60155656 bytes remaining to read
+ echo 'ERROR failed to download from https://minecraft.azureedge.net/bin-linux/bedrock-server-1.19.81.01.zip'
+ echo '      Double check that the given VERSION is valid'
+ exit 2
ERROR failed to download from https://minecraft.azureedge.net/bin-linux/bedrock-server-1.19.81.01.zip
      Double check that the given VERSION is valid

Thanks!

Since it worked in the browser, then there is not a bug in the container startup. In that case it must be a networking issue in your docker installation or closer to the server host.
Where did you run wget?
The debug output shows the curl command that was used, so that's what you should have been re-trying.
Make sure to re-pull the image and debug/investigate your network while running:
docker run --rm --entrypoint curl itzg/minecraft-bedrock-server -v -o /tmp/bedrock-server-1.19.81.01.zip -fsSL https://minecraft.azureedge.net/bin-linux/bedrock-server-1.19.81.01.zip

authors: LewisSpring itzg

repo: itzg/docker-minecraft-bedrock-server


text:
RCON: Startup Commands

Enhancement Type
A completely new feature
Describe the enhancement
Using something like the Autopause feature, we should be able to add something very similar to wait for Java process to exist, and then use the rcon-cli and inject rcon commands on start.
AC: Allow for commands to be passed in from something similar too -e RCON_START_COMMANDS and have commands run on server startup.
# wait for java process to be started
while :
do
  if java_process_exists ; then
    break
  fi
  sleep 0.1
done

  # save world
  rcon-cli save-all >/dev/null

PR https://github.com/itzg/docker-minecraft-server/pull/1391

repo: itzg/docker-minecraft-server


text:
Custom STOP_SERVER_ANNOUNCE_DELAY command

Enhancement Type
A completely new feature
Describe the enhancement
Being able to provide a custom command to be ran when it is announced that the server will stop (configurable using STOP_SERVER_ANNOUNCE_DELAY, documented here), instead of the default /say Server shutting down in x seconds would be a great addition.

Great suggestion.

authors: ItsNiceCraft itzg


text:
2D microscopy tutorial broken: No subject files found.

Issue description
The 2-class 2D microscopy tutorial here doesn't work anymore on the master branch. I get the following error:
2023-01-23 12:02:11.020 | WARNING  | ivadomed.loader.bids_dataframe:create_bids_dataframe:135 - No subject files were found in 'data_axondeepseg_sem' dataset. Skipping dataset.
Traceback (most recent call last):
  File "/home/herman/.conda/envs/ivadomed_venv/bin/ivadomed", line 33, in <module>
    sys.exit(load_entry_point('ivadomed', 'console_scripts', 'ivadomed')())
  File "/home/herman/Documents/NEUROPOLY_21/ivadomed/ivadomed/main.py", line 623, in run_main
    run_command(context=context,
  File "/home/herman/Documents/NEUROPOLY_21/ivadomed/ivadomed/main.py", line 398, in run_command
    bids_df = BidsDataframe(loader_params, path_output, derivatives=True,
  File "/home/herman/Documents/NEUROPOLY_21/ivadomed/ivadomed/loader/bids_dataframe.py", line 72, in __init__
    self.create_bids_dataframe()
  File "/home/herman/Documents/NEUROPOLY_21/ivadomed/ivadomed/loader/bids_dataframe.py", line 147, in create_bids_dataframe
    raise RuntimeError("No subject files found. Check selection of parameters in config.json"
RuntimeError: No subject files found. Check selection of parameters in config.json and datasets compliance with BIDS specification.

Steps to reproduce
Follow the 2-class microscopy tutorial. Error happens when we run the training config.
Environment
System description
Linux

Last time I did training with ivadomed was a few months ago, so I knew this bug was recently introduced. After a quick investigation, it seems the problem started with this commit 5b2e3131: Remove force indexing of microscopy and update ct (#1203).
I'll investigate further but in the meantime, I'd like to know if this problem is isolated or if someone can reproduce by simply trying the microscopy 2D tutorial on the master branch. We only want to see if the training starts (more specifically if the dataset is properly loaded), so it should take less than 15 minutes to assess.

Update: microscopy was indeed integrated in pybids 0.15.2 (as mentioned by Marie-Hélène in #1203) but the bids-validator package only supports it since 1.9.0. I had version 1.7.2 installed in my environment. Re-installing the whole environment did not help; I had to manually update bids-validator myself. This kind of pip sorcery is always annoying... I assumed deleting the environment and re-installing from scratch would install the latest versions available for all dependencies, but it doesn't. (bids-validator is a dependency of pybids and they didn't pin a version)
TL;DR Fixed by updating bids-validator to >1.9.0

Hello,
So I am getting the same error as you but with BIDS_validator -1.10.0. Has anyone else had the same issue?
It defintely looks to be an update thing as I tried to run a previously working training folder and got the same error there too.
Best,
Michael

Hello @hermancollin, So running pip list | grep bids
bids-validator          1.10.0
pybids                  0.15.5

But I still get the same error as before
2023-02-07 08:51:06.122 | WARNING  | ivadomed.loader.bids_dataframe:create_bids_dataframe:135 - No subject files were found in 'drive/MyDrive/microglia_Ivadomed/testBIDS' dataset. Skipping dataset.
Traceback (most recent call last):
  File "/usr/local/bin/ivadomed", line 8, in <module>
    sys.exit(run_main())
  File "/usr/local/lib/python3.7/site-packages/ivadomed/main.py", line 628, in run_main
    overlap_2d=args.overlap_2d if args.overlap_2d else None)
  File "/usr/local/lib/python3.7/site-packages/ivadomed/main.py", line 399, in run_command
    split_method=context.get(ConfigKW.SPLIT_DATASET).get(SplitDatasetKW.SPLIT_METHOD))
  File "/usr/local/lib/python3.7/site-packages/ivadomed/loader/bids_dataframe.py", line 72, in __init__
    self.create_bids_dataframe()
  File "/usr/local/lib/python3.7/site-packages/ivadomed/loader/bids_dataframe.py", line 147, in create_bids_dataframe
    raise RuntimeError("No subject files found. Check selection of parameters in config.json"
RuntimeError: No subject files found. Check selection of parameters in config.json and datasets compliance with BIDS specification.

Also the BIDS folder and config file for my attempt can be found here.
https://we.tl/t-5iVIL5wl9t
Thank you again for all your help and prompt replies!
Best,
Michael

authors: GrimmSnark hermancollin

repo: ivadomed/ivadomed


text:
Fixing issues in estimate uncertainty tutorial

Checklist
GitHub

[x] I've given this PR a concise, self-descriptive, and meaningful title
[x] I've linked relevant issues in the PR body
[x] I've applied the relevant labels to this PR
[x] I've assigned a reviewer

PR contents

[x] I've consulted ivadomed's internal developer documentation to ensure my contribution is in line with any relevant design decisions
[ ] I've added relevant tests for my contribution
[x] I've updated the relevant documentation for my changes, including argparse descriptions, docstrings, and ReadTheDocs tutorial pages

Description

Estimate uncertainty tutorial has few error which include:

minor text error where words have been duplicated in a sentence
paths do be set in configuration file are incorrect

This PR will fix these issues.
Linked issues

Will fix #931 and #935

Pull Request Test Coverage Report for Build 1195227575

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.737%

Totals

Change from base Build 1194669758:
0.0%

Covered Lines:
4293

Relevant Lines:
6069

💛  - Coveralls

authors: copperwiring coveralls


text:
SolidJS adapter context provider may re-render children sometimes when paired with Suspense

Version
5.3.4
Describe the bug
In the SolidJS adapter, you use:
return createComponent(I18nContext.Provider, { value: ctx, children: () => props.children })

which defines children as a function.
This has similar behavior to:
<Show when={...}>
{ value => ... }
</Show>

which will re-render the entire child tree when the given value changes. I don't fully understand exactly what changes, but as shown below it causes double-rendering.
Reproduction
See HERE for a minimal recreation (check the console to see it re-rendering components) using the same Provider technique as in existing typesafe-i18n.
If you instead change children() to get children() to make it a getter, SolidJS treats it much better and does not re-render.
Logs
No response
Config
No response
Additional information
No response

Just got confirmation from Ryan (SolidJS creator) on Discord that using a getter is indeed the correct way, so that PR should be ideal.

Thanks @novacrazy for investigating and providing the fix!
The issue is resolved in version 5.3.5

authors: ivanhofer novacrazy


text:
Type 'SPPermissions.Permission' has no member 'camera' so on

iOS Version 14.5.1
SPPermissions version 6.0.9
Installed via Cocoapods

i copy code from the example, but i has met this issue from my side, can u help me to check why have this happen?

Good day!
Provide please full file which you use and podspec too.

Good day!
Provide please full file which you use and podspec too.
Hi, sorry for the i missing the pods
here is which i installed from cocoapods
pod 'SPPermissions'
here is which file i import
import SPPermissions
the above it's all i used in the code

Yes, you missing other modules. Here full info. Please, close issue if not actual.

thank you so much.

authors: PacoPacoPakitor ivanvorobei

repo: ivanvorobei/SPPermissions


text:
希望table增加分页

分页应该是个很普遍的需求。

分页在iview官方文档有实例，您可以参考一下，后期我们也会加进来

repo: iview/iview-admin


text:
update of uCD list following SSAP UCD check

while checking SSAP UCD words  , we propose to fix some UCD terms in the list

meta.curation  change flag to S

phys.size   change definition

instr.fov represents a geometrical shape on the sky covered by an observing instrument.
Table columns should be specified unambiguously to designate what is measured or represented in the column value:
phys.angSize;instr.fov , phys.area;instr.fov , pos.outline;instr.fov
other SSAP UCD also for revision . see table attached
SSAP_appendixD_UCDCheckmL+Seb.pdf

SSAP UCD are also proposed for revision . see table attached
SSAP_appendixD_UCDCheckmL+Seb.pdf

Are these supposed to be compatible with UCDList 1.4? Several entries contain meta.curation in the secondary position, but meta.curation is marked P in UCDList 1.4.

No, meta.curation flag update can be planned for EN UCDList1.5.
The suggestions for SSAP updates in the document, imply that meta.curation becomes a more general term than identity of publisher.
so be changed to S or Q .
Q;Q terms have no logic to be combined so S would be more convenient.

On Thu, Sep 09, 2021 at 10:17:47AM -0700, Mireille LOUYS wrote:

No, meta.curation flag update can be planned for EN UCDList1.5.
The suggestions for SSAP updates in the document, imply that meta.curation becomes a more general term than identity of publisher.
so be changed to S or Q .
Q;Q terms have no logic to be combined so S would be more convenient.

As a general principle, I'd be very wary of transitions from P to S,
as that will make any previous use of the atom invalid, which is
a bad thing in almost all cases (essentially, unless the previous
meaning was really broken beyond repair).  Also, semantically, a
generalisation of a concept cannot make it flip from P to S, as that
would necessarily mean certain parts of the previous extension were
be dropped (a generalisation only enlarges the extension).
I mention in passing that making meta.curation S will again break
existing SSAP, as its utype ssa:Curation.Publisher is currently
associated with the UCD "meta.curation".
As to avoiding Q-Q because there's no implied order, I'd say that's
not really something to worry about.  Basically, making an atom Q
means "it can work both as a main descriptor and as a qualifier".
Writing definitions such that that works is tricky but not
impossible.
Of course, "meta.ref.ivoid;meta.curation" then really means something
else than "meta.curation;meta.ref.ivoid".   The question is: what?  My
UCD explainer produces for the first:
Identity of man/organization responsible for the data related to an
identifier as recommended in the IVOA (dereferenceable)
So... with my current code this comes out as the folks that maintain
an an identifier.  Ahem.  I'd suggest that's a bug, as it should
arguably by "identifier of the folks how do the curation".  Patches
to
http://svn.ari.uni-heidelberg.de/svn/gavo/hdinputs/ucds/res/ucdexplainer.py
are welcome.  For the second UCD, it's
Related to an identifier as recommended in the ivoa
(dereferenceable) identity of man/organization responsible for the
data
That that sentence is broken indicates my code fails with
meta.ref.ivoid on a wider scale.  What I'd say the explanation ought
to work out to is what the explainer put out as first thing: it's
infos on the curation of IVOA identifiers.  Whether that's a thing
commonly used in tables I doubt, but, really, the extension of that
compound concept pretty plainly is what in Registry we call an
Authority, and I don't see anything wrong in admitting such a concept
in UCDs.
In closing: Can we change the "man" in the meta.curation definition
to "person"?

version UCDList1.5 solves this issue
it states a position Q for meta.curation and recommends meta.id;meta.curation for identifying a person or an organization responsible for curation.

authors: loumir mbtaylor msdemlei

repo: ivoa-std/UCDList


text:
Bug : Kinesis Enhanced Shard-Level metrics not showing on a per shard basis

After enabling Enhanced Shard-Level metrics for Kinesis, all I see in Prometheus is :
aws_kinesis_incoming_records_sum{dimension_StreamName="test-stream",instance="xx.xx.xx.xx:xx",job="cloudwatch-exporter-kinesis",name="arn:aws:kinesis:us-west-1:XXXXXXXX:stream/test-stream",namespace="exporters",pod="cloudwatch-exporter-kinesis-xxxxxxxx",region="us-west-1"}
I would be expecting the dimension ShardId to be added as a label to the metric.
The YACE is already collecting the ShardId dimension in its ListMetricsResponse (seen from a --debug enabled exporter).
      <member>
        <Namespace>AWS/Kinesis</Namespace>
        <MetricName>IncomingRecords</MetricName>
        <Dimensions>
          <member>
            <Name>ShardId</Name>                       <------
            <Value>shardId-000000000003</Value>
          </member>
          <member>
            <Name>StreamName</Name>
            <Value>test-stream</Value>
          </member>
        </Dimensions>
      </member>

Here is my config.
discovery:
  jobs:
  - type: kinesis
    enableMetricData: true
    regions:
      - us-west-1
    roleArn: arn:aws:iam::XXXXXXXXXXXX:role/CwRead
    metrics:
      - name: IncomingRecords
        statistics:
        - Sum
        period: 60
        length: 300
      - name: IncomingBytes
        statistics:
        - Sum
        period: 60
        length: 300

I also tried adding awsDimensions to the config, but when I do, I am not receiving any data in Prometheus :
    awsDimensions:
      - ShardId
      - StreamName

I am doing all this because AWS does not expose a metric showing the amount of shards there is in a Kinesis Stream. The amount of open shard is useful to determine if your Stream's shard count is sufficient, to know if the amount of shard should be scaled or downscaled. To my knowledge, the only way to get the shard count would be via the Enhanced Shard-Level Metrics. If there is another easier way to do this, I would also be happy. Maybe adding the open shard count to the metric aws_kinesis_info ?

@Bachib - I am using below config and its working for me .
jobs:
  - type: kinesis
    regions:
     - ap-northeast-1
     - us-east-1
     - eu-west-1
    awsDimensions:
     - ShardId
    metrics:
      - name: IteratorAgeMilliseconds
        statistics:
        - Average
        period: 600
        length: 600
      - name: IncomingRecords
        statistics:
        - Average
        period: 600
        length: 600

Closing this. If it is still a problem please reopen the issue. Thank you!

authors: Bachib ishantkumar thomaspeitz

repo: ivx/yet-another-cloudwatch-exporter


text:
ESP32 support

Hello, i'm trying to use your library on esp32.I use obd.begin(Serial2, RX_PIN, TX_PIN) and pins: rx 13 and tx :32. But Serial2 default pins are 16 and 17.Even if i use the default hardware pins the rx pin is not pull up even if i mod the cpp file to INPUT_PULLUP on rx pin.
On the other side AltsoftSerial is not compatible with esp32.The alternative option for esp32 is SoftwareSerial ,
So is it possible to add software serial option for eps32 ?
Thank you in advance!
PS. Also debug option not working on eps32 (cant compile).It will perfect if all functions of library will be working on this MCU

Interesting, so some pointers and ideas...

Even if i use the default hardware pins the rx pin is not pull up even
it could be that the pullup of the ESP32 is weak, on the rx pin you should just be able to use an external pullup to make it stronger.

During the initialisation, the serial port is actually disabled and the k-line is toggled like a gpio here. I'm not sure how the ESP32 works, and whether disabling the serial port actually allows the pins to be used as true GPIO pins. The arduino DUE for example also did not behave correctly when I originally wrote this library and I ended up with these lines just to toggle the pin functionality between serial and gpio mode. Maybe the ESP32 needs something similar.
Another thing you may run into is that the baud rate is a pretty odd number that may not be handled well by the esp32?

So is it possible to add software serial option for eps32

SoftwareSerial, or any other serial should work, if you modify the defines here you should be able to easily plug in any other object that supports the required methods. May be easiest to just copy the OBD9141.h and OBD9141.cpp files into your project directory to ensure they're compiled with your changes.

Also debug option not working on eps32 (cant compile).

Odd, what's the error? It's just doing printing and it should all be arduino-compatible printing.

Thank you iwanders for your fast reply!
Before i explain what changes i made, i have to note that i use arduino core 1.0.6 to compile my sketchs not ESP-IDF.
So i modified the defines in OBD9141.h ,add :
#ifdef  OBD9141_USE_ESP32
#include <SoftwareSerial.h>
#define OBD_SERIAL_DATA_TYPE SoftwareSerial
i modified also the OBD9141.cpp file  :
pinMode(this->rx_pin, INPUT_PULLUP);  (Input Pullup)
Then check while init process,  i had digital output on tx (0x33) and echo on rx.So pull up on rx worked fine.
The next step is to check on car.The crazy thing is that my car is peugeot 206 1.1cc like the one tistructor issue with (KWP Slow init with v1 != v2)   :)))  So i'll check with a car that use ISO9141 Protocol to be sure.
Last thing about debug:
when i uncomment  #define OBD9141_DEBUG i get this errors (sorry for the long list) :
C:\Users\USER\Documents\Arduino\libraries\OBD9141-master\src\OBD9141.cpp: In member function 'uint8_t OBD9141::request(void*, uint8_t)':
C:\Users\USER\Documents\Arduino\libraries\OBD9141-master\src\OBD9141.cpp:179:65: error: no matching function for call to 'min(uint8_t&, int)'
for (uint8_t i=0; i < min(answer_length, OBD9141_BUFFER_SIZE); i++){
^
In file included from c:\users\user\appdata\local\arduino15\packages\esp32\tools\xtensa-esp32-elf-gcc\1.22.0-97-gc752ad5-5.2.0\xtensa-esp32-elf\include\c++\5.2.0\algorithm:62:0,
from C:\Users\USER\AppData\Local\Arduino15\packages\esp32\hardware\esp32\1.0.6\cores\esp32/Arduino.h:142,
from C:\Users\USER\Documents\Arduino\libraries\OBD9141-master\src\OBD9141.h:8,
from C:\Users\USER\Documents\Arduino\libraries\OBD9141-master\src\OBD9141.cpp:5:
c:\users\user\appdata\local\arduino15\packages\esp32\tools\xtensa-esp32-elf-gcc\1.22.0-97-gc752ad5-5.2.0\xtensa-esp32-elf\include\c++\5.2.0\bits\stl_algo.h:3451:5: note: candidate: template<class _Tp, class _Compare> _Tp std::min(std::initializer_list<_Tp>, _Compare)
min(initializer_list<_Tp> __l, _Compare __comp)
^
c:\users\user\appdata\local\arduino15\packages\esp32\tools\xtensa-esp32-elf-gcc\1.22.0-97-gc752ad5-5.2.0\xtensa-esp32-elf\include\c++\5.2.0\bits\stl_algo.h:3451:5: note:   template argument deduction/substitution failed:
C:\Users\USER\Documents\Arduino\libraries\OBD9141-master\src\OBD9141.cpp:179:65: note:   mismatched types 'std::initializer_list<_Tp>' and 'unsigned char'
for (uint8_t i=0; i < min(answer_length, OBD9141_BUFFER_SIZE); i++){
^
In file included from c:\users\user\appdata\local\arduino15\packages\esp32\tools\xtensa-esp32-elf-gcc\1.22.0-97-gc752ad5-5.2.0\xtensa-esp32-elf\include\c++\5.2.0\algorithm:62:0,
from C:\Users\USER\AppData\Local\Arduino15\packages\esp32\hardware\esp32\1.0.6\cores\esp32/Arduino.h:142,
from C:\Users\USER\Documents\Arduino\libraries\OBD9141-master\src\OBD9141.h:8,
from C:\Users\USER\Documents\Arduino\libraries\OBD9141-master\src\OBD9141.cpp:5:
c:\users\user\appdata\local\arduino15\packages\esp32\tools\xtensa-esp32-elf-gcc\1.22.0-97-gc752ad5-5.2.0\xtensa-esp32-elf\include\c++\5.2.0\bits\stl_algo.h:3445:5: note: candidate: template _Tp std::min(std::initializer_list<_Tp>)
min(initializer_list<_Tp> __l)
^
c:\users\user\appdata\local\arduino15\packages\esp32\tools\xtensa-esp32-elf-gcc\1.22.0-97-gc752ad5-5.2.0\xtensa-esp32-elf\include\c++\5.2.0\bits\stl_algo.h:3445:5: note:   template argument deduction/substitution failed:
C:\Users\USER\Documents\Arduino\libraries\OBD9141-master\src\OBD9141.cpp:179:65: note:   mismatched types 'std::initializer_list<_Tp>' and 'unsigned char'
for (uint8_t i=0; i < min(answer_length, OBD9141_BUFFER_SIZE); i++){
^
In file included from c:\users\user\appdata\local\arduino15\packages\esp32\tools\xtensa-esp32-elf-gcc\1.22.0-97-gc752ad5-5.2.0\xtensa-esp32-elf\include\c++\5.2.0\algorithm:61:0,
from C:\Users\USER\AppData\Local\Arduino15\packages\esp32\hardware\esp32\1.0.6\cores\esp32/Arduino.h:142,
from C:\Users\USER\Documents\Arduino\libraries\OBD9141-master\src\OBD9141.h:8,
from C:\Users\USER\Documents\Arduino\libraries\OBD9141-master\src\OBD9141.cpp:5:
c:\users\user\appdata\local\arduino15\packages\esp32\tools\xtensa-esp32-elf-gcc\1.22.0-97-gc752ad5-5.2.0\xtensa-esp32-elf\include\c++\5.2.0\bits\stl_algobase.h:243:5: note: candidate: template<class _Tp, class _Compare> const _Tp& std::min(const _Tp&, const _Tp&, _Compare)
min(const _Tp& __a, const _Tp& __b, _Compare __comp)
^
c:\users\user\appdata\local\arduino15\packages\esp32\tools\xtensa-esp32-elf-gcc\1.22.0-97-gc752ad5-5.2.0\xtensa-esp32-elf\include\c++\5.2.0\bits\stl_algobase.h:243:5: note:   template argument deduction/substitution failed:
C:\Users\USER\Documents\Arduino\libraries\OBD9141-master\src\OBD9141.cpp:179:65: note:   deduced conflicting types for parameter 'const _Tp' ('unsigned char' and 'int')
for (uint8_t i=0; i < min(answer_length, OBD9141_BUFFER_SIZE); i++){
^
In file included from c:\users\user\appdata\local\arduino15\packages\esp32\tools\xtensa-esp32-elf-gcc\1.22.0-97-gc752ad5-5.2.0\xtensa-esp32-elf\include\c++\5.2.0\algorithm:61:0,
from C:\Users\USER\AppData\Local\Arduino15\packages\esp32\hardware\esp32\1.0.6\cores\esp32/Arduino.h:142,
from C:\Users\USER\Documents\Arduino\libraries\OBD9141-master\src\OBD9141.h:8,
from C:\Users\USER\Documents\Arduino\libraries\OBD9141-master\src\OBD9141.cpp:5:
c:\users\user\appdata\local\arduino15\packages\esp32\tools\xtensa-esp32-elf-gcc\1.22.0-97-gc752ad5-5.2.0\xtensa-esp32-elf\include\c++\5.2.0\bits\stl_algobase.h:195:5: note: candidate: template const _Tp& std::min(const _Tp&, const _Tp&)
min(const _Tp& __a, const _Tp& __b)
^
c:\users\user\appdata\local\arduino15\packages\esp32\tools\xtensa-esp32-elf-gcc\1.22.0-97-gc752ad5-5.2.0\xtensa-esp32-elf\include\c++\5.2.0\bits\stl_algobase.h:195:5: note:   template argument deduction/substitution failed:
C:\Users\USER\Documents\Arduino\libraries\OBD9141-master\src\OBD9141.cpp:179:65: note:   deduced conflicting types for parameter 'const _Tp' ('unsigned char' and 'int')
for (uint8_t i=0; i < min(answer_length, OBD9141_BUFFER_SIZE); i++){

when i uncomment #define OBD9141_DEBUG i get this errors (sorry for the long list)

I edited your comment, you can open code blocks with triple backticks on a line (`) and close them again with three backticks, edit your comment to see how I made it more readable.
Only the first part of the error is really important here, the key is min(uint8_t&, int). The min() call here in the library is based on the ones arduino supports, which probably also provide overloads for min(int, int), the toolchain you are you using only supports the templated min function and because we pass in two different arguments the template argument deduction (so what type the compiler uses for the function) fails because the arguments are different types. You can probably fix this by changing it such that an explicit template argument is provided:
for (uint8_t i=0; i < min<uint8_t>(answer_length, OBD9141_BUFFER_SIZE); i++)

If that doesn't work, we can also cast the first argument to be similar to the second, the second is a define of an integer, so it defaults to int, in that case we would do:
for (uint8_t i=0; i < min(static_cast<int>(answer_length), OBD9141_BUFFER_SIZE); i++)

Hopefully this unblocks you and allows you to use the debug functionality, hopefully it can help you get things working!

Everythink worked perfectly : successfully connected to obd2 and Debuging runing corect;y !! For Debuging is use <uint8_t> for min.
Thank you very much for your help :)

@hulktech , I filed  #36 to remove the min() function call altogether, I think it is redundant, see the description of the PR. It'd be appreciated if you could test that branch / version of the file just to have a second sanity check besides my own.
(Also, great it's all working now, I'm always happy to hear people successfully use this library ^_^)

After i had replaced the line 179 ,the compiler completed successfully ,also checked on a vehicle and work correctly with debug mode of course.
Nice work.

I've merged #36, closing this issue as things are reported working and we've improved the library to make it more portable. Thanks @hulktech for reaching out.

authors: hulktech iwanders


text:
🛑 05Takagi is down

In 1f91048, 05Takagi (https://lixingyong.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: 05Takagi is back up in cd13a65.

repo: iwyang/check


text:
🛑 28mao is down

In 3bd6b6d, 28mao (https://meuicat.com/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: 28mao is back up in 169b7a5.


text:
🛑 05Takagi is down

In 24580d7, 05Takagi (https://lixingyong.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: 05Takagi is back up in 7c39902 after 9 minutes.


text:
🛑 Takagi is down

In 01330c9, Takagi (https://lixingyong.com) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Takagi is back up in 614fcee.


text:
🛑 21Eurkon is down

In 04704e5, 21Eurkon (https://blog.eurkon.com/) was down:

HTTP code: 0
Response time: 0 ms

Resolved: 21Eurkon is back up in 37d594d after 9 minutes.


text:
When I use UIViewController instead of UINavigationController scan doesn't work

I don't have UINavigationController in my app and instead of navigationController.push(qr) I am using present(qr) and then scan doesn't work.
Any help?
Thank you!

This issue

I found the issue..
Probably "AVCaptureInputPortFormatDescriptionDidChange" behaves differently when a ViewController is pushed to navigationController and when is presented.
When a ViewController is presented, QRScannerView frame is (0, 0, 0, 0) in viewDidLoad and it changes on viewDidLayoutSubviews so I posted a notification there:
nc.post(name: Notification.Name("viewDidLayoutSubviews"), object: nil)
and then in setupCameraSession(), changed the observer name from "AVCaptureInputPortFormatDescriptionDidChange" to "viewDidLayoutSubviews":
nc.addObserver(forName: NSNotification.Name("viewDidLayoutSubviews"), object: nil, queue: nil, using: {[weak self] (noti) in guard let sf = self else{ return } metaOutput.rectOfInterest = sf.previewLayer!.metadataOutputRectConverted(fromLayerRect: sf.squareView.frame) })
nc variable is defined at the top of the class QRScannerViewController
let nc = NotificationCenter.default

Just like your comment, the observer get AVCaptureInputPortFormatDescriptionDidChange notification before
method viewDidLayoutSubviews called.
So i add
view.setNeedsLayout()
view.layoutIfNeeded()

in setUpLayers(),and a present demo is available now.
Thank you for your feedback，the version of 0.0.9 may fix this issue .

authors: izhoubin nshapkar

repo: izhoubin/QRScanner


text:
Large groups (~200) no longer loading

Checklist

[X] I am able to reproduce the bug with the latest version.
[X] I made sure that there are no existing issues - open or closed - which I could contribute my information to.
[X] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
[X] This issue contains only one bug, that only occurs in Squawker

Affected version
3.8.3
Steps to reproduce the bug

Add at least 200 profiles to a group
Click on the group name

Expected behavior
Show the posts of the content profiles. The group was working as expected until yesterday.
Actual behavior
Blank content, no posts are shown.
Screenshots/Screen recordings
No response
Logs
No response
Affected Android/Custom ROM version
Android 14
Affected device model
Galaxy A54
Additional information
No response

Hi,
I think it's not about the group size.
I ve got one with less than ten accounts inside and i'm encountering this issue too.

Started working again, don't know what happened.

authors: Go-rom autogris

repo: j-fbriere/squawker


text:
Text.Gigaparsec.Combinator and Text.Gigaparsec.Expr

We still need support for the suite of expression parsing combinators ported from DPfPC/thesis, and the remaining combinators from parsley.combinator to be ported over. These need documentation and tests as well.

Partially completed via #10


text:
final changes before merge

Updated PR with changes to the other notebooks.

The other notebooks were already up to date in origin.

repo: j-nystrom/bayesian-biodiversity


text:
script refactoring

Move scripts to top-level directory
Allow autocomplete for test directory
Add -u flag to set to warn on unbound environment variables

lgtm with comments


text:
maintenance

chore(deps-dev): Bump @semantic-release/npm from 8.0.0 to 8.0.3
chore(deps): Bump azure/setup-helm from 1 to 2.0
chore(deps): Bump actions/setup-node from 2.4.0 to 2.5.1
chore(deps): Bump actions/cache from 2.1.6 to 2.1.7

:tada: This PR is included in version 1.3.1 :tada:
The release is available on:

v1.3.1
GitHub release

Your semantic-release bot :package::rocket:

repo: jBouyoud/helm-config-scheme


text:
SceneComposer null obj after first use.

SDK 3.2, win 7. Onboard graphic intel i3.
SceneComposer only works for me the first time it is opened. If I then close the j3o, run the game and exit game, afterwards I open the j3o again, the second time there are two viewports inside the SceneComposer tab. The second viewport upper right corner is centered in the tab window and works but the first one is still behind it and does not work.
Opening and closing the j3o after this point will result in yet another window opening inside the SceneComposer tab in the same way as reported above that is unseen in the viewport.
Some buffer is not being cleared it looks like.

Cant edit the original post since MS took over and no longer supports their own browser so have to add more details in second post.
Sometimes, reseting the windows will clear things up but eventually this no longer works. Once the reset stops working, I get exceptions that just say Null obj when closing the SceneComposer.

Can't edit the original post since MS took over and no longer supports their own browser so have to add more details in second post. I hate M$.
Sometimes, reseting the windows will clear things up but eventually this no longer works. Once the reset stops working, I get exceptions that just say Null obj when closing the SceneComposer.
I get these kind of errors in the log,
WARNING [org.openide.filesystems.Ordering]: Not all children in Windows2/Modes/navigator/ marked with the position attribute: [SceneExplorerTopComponent.wstcref, FilterExplorerTopComponent.wstcref], but some are: [navigatorTC.wstcref]
WARNING [com.jme3.system.awt.AwtPanel]: OGL: DrawGraphics was null.

repo: jMonkeyEngine/sdk


text:
Why just support swift?

pls support Objective-C

The UI component is pretty much outdated, since similar functionality can be found natively in the SDK.

authors: DevSuen jVirus

repo: jVirus/drawer-view


text:
Volume module doesn't react after headphones plugging in/out

I'm having a little issue with the volume module
Before the headphones plug in, volume changes are still reflected on the module. But after the plug, the module doesn't react to the changes at all: the volume number doesn't increase, the bar doesn't move,etc.. Reloading the bar seems to fix the problem, but after the headphones unplugged, the module doesn't react again.
I also read on the wiki about the volume module config, which involves headphone and headphone-id, but I can't seem to get it work.
I'm new to GitHub, so I hope I can learn more from you guys. Thank you.

Can you post the output of:
$ amixer scontrols
$ amixer controls

Here:
amixer scontrols:
Simple mixer control 'Master',0
Simple mixer control 'Capture',0

amixer controls:
numid=4,iface=MIXER,name='Master Playback Switch'
numid=3,iface=MIXER,name='Master Playback Volume'
numid=2,iface=MIXER,name='Capture Switch'
numid=1,iface=MIXER,name='Capture Volume'

You doesn't seem to have any handlers for the headphone jack, which means the headphone specific parts of the module won't work. Try removing the headphone parts from the config and see if it works.

Just removed all the headphone-related lines but the module still doesn't react after headphone plug/unplug. This is my current volume module:
[module/volume]
type = internal/volume

format-volume = <label-volume><bar-volume>

label-volume =
label-volume-foreground = ${root.foreground}

label-muted =  sound muted
label-muted-foreground = #55

bar-volume-width = 20
bar-volume-foreground-0 = #55aa55
bar-volume-foreground-1 = #55aa55
bar-volume-foreground-2 = #55aa55
bar-volume-foreground-3 = #55aa55
bar-volume-foreground-4 = #55aa55
bar-volume-foreground-5 = #f5a70a
bar-volume-foreground-6 = #ff5555
bar-volume-gradient = false
bar-volume-indicator = │
bar-volume-indicator-font = 2
bar-volume-indicator-foreground = #ff
bar-volume-fill = ─
bar-volume-fill-font = 2
bar-volume-empty = ─
bar-volume-empty-font = 2
bar-volume-empty-foreground = #55

Do you get any error/warning messages?

Are there any particular debugging steps? If the error appears right on-screen then I think I don't see any. It's like the module can't detect the headphone events because there's no seperate handlers for it. Increasing the volume for Master should have increase the headphone volume anyway, but apparently the module doesn't think so.

The messages are printed to stderr, so you should see them in your terminal.

I pipe the messages to error.log here by running another instance of the bar:
polybar|warn:  No monitor specified, using "eDP-1"
polybar|warn:  The config parameter `bar/example.dock` is deprecated, use `bar/example.override-redirect` instead.
polybar|warn:  The config parameter `bar/example.border-bottom` is deprecated, use `bar/example.border-bottom-size` instead.
polybar|error: Disabling module "battery" (reason: No suitable way to get current capacity value)
polybar|warn:  Systray selection already managed (window=0x1400010)
polybar|warn:  Termination signal received, shutting down...

It seems like there's nothing related to the volume module.

Could you run $ alsactl monitor and alter the volume with/without the headphones to see what events you get

Here:
alsactl monitor without headphones (increase volume then decrease):
card 1, #22 (2,0,0,Master Playback Volume,0) VALUE
card 1, #1 (2,0,0,Speaker Playback Volume,0) VALUE
card 1, #3 (2,0,0,Bass Speaker Playback Volume,0) VALUE
card 1, #1 (2,0,0,Speaker Playback Volume,0) VALUE
card 1, #3 (2,0,0,Bass Speaker Playback Volume,0) VALUE
card 1, #35 (2,0,0,PCM Playback Volume,0) VALUE
card 1, #1 (2,0,0,Speaker Playback Volume,0) VALUE
card 1, #35 (2,0,0,PCM Playback Volume,0) VALUE
card 1, #1 (2,0,0,Speaker Playback Volume,0) VALUE
card 1, #35 (2,0,0,PCM Playback Volume,0) VALUE
card 1, #22 (2,0,0,Master Playback Volume,0) VALUE
card 1, #1 (2,0,0,Speaker Playback Volume,0) VALUE

alsactl monitor with headphones (increase volume then decrease):
card 1, #22 (2,0,0,Master Playback Volume,0) VALUE
card 1, #5 (2,0,0,Headphone Playback Volume,0) VALUE
card 1, #35 (2,0,0,PCM Playback Volume,0) VALUE
card 1, #5 (2,0,0,Headphone Playback Volume,0) VALUE
card 1, #35 (2,0,0,PCM Playback Volume,0) VALUE
card 1, #5 (2,0,0,Headphone Playback Volume,0) VALUE
card 1, #35 (2,0,0,PCM Playback Volume,0) VALUE
card 1, #22 (2,0,0,Master Playback Volume,0) VALUE
card 1, #5 (2,0,0,Headphone Playback Volume,0) VALUE
card 1, #35 (2,0,0,PCM Playback Volume,0) VALUE

And when you remove the headphones, do you get the same events as before? Check the id (card 1, #<id>)

Yes all id's are the same after plug/unplug.

Do you have the script alsa-info.sh ? If so, please post the generated log created by running it.

Here's the log after running alsa-info.sh
alsa-info.txt

@jaagr Just wanna update on the situation. I was able to create a custom module that reacts perfectly to the headphone events by combining with the volume script of i3blocks. The custom module & i3blocks' volume script is attached below:
[module/customvol]
type = custom/script
exec = ~/.config/i3blocks/volume 5 pulse
label = %output%
tail = true
interval = 0

~/.config/i3blocks/volume:

#!/bin/bash
# Copyright (C) 2014 Julien Bonjean <julien@bonjean.info>
# Copyright (C) 2014 Alexander Keller <github@nycroth.com>

# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.

# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.

# You should have received a copy of the GNU General Public License
# along with this program.  If not, see <http://www.gnu.org/licenses/>.

#------------------------------------------------------------------------

# The second parameter overrides the mixer selection
# For PulseAudio users, use "pulse"
# For Jack/Jack2 users, use "jackplug"
# For ALSA users, you may use "default" for your primary card
# or you may use hw:# where # is the number of the card desired
MIXER="default"
[ -n "$(lsmod | grep pulse)" ] && MIXER="pulse"
[ -n "$(lsmod | grep jack)" ] && MIXER="jackplug"
MIXER="${2:-$MIXER}"

# The instance option sets the control to report and configure
# This defaults to the first control of your selected mixer
# For a list of the available, use `amixer -D $Your_Mixer scontrols`
SCONTROL="${BLOCK_INSTANCE:-$(amixer -D $MIXER scontrols |
                  sed -n "s/Simple mixer control '\([A-Za-z ]*\)',0/\1/p" |
                  head -n1
                )}"

# The first parameter sets the step to change the volume by (and units to display)
# This may be in in % or dB (eg. 5% or 3dB)
STEP="${1:-5%}"

#------------------------------------------------------------------------

capability() { # Return "Capture" if the device is a capture device
  amixer -D $MIXER get $SCONTROL |
    sed -n "s/  Capabilities:.*cvolume.*/Capture/p"
}

volume() {
  amixer -D $MIXER get $SCONTROL $(capability)
}

format() {
  perl_filter='if (/.*\[(\d+%)\] (\[(-?\d+.\d+dB)\] )?\[(on|off)\]/)'
  perl_filter+='{CORE::say $4 eq "off" ? "MUTE" : "'
  # If dB was selected, print that instead
  perl_filter+=$([[ $STEP = *dB ]] && echo '$3' || echo '$1')
  perl_filter+='"; exit}'
  perl -ne "$perl_filter"
}

#------------------------------------------------------------------------

case $BLOCK_BUTTON in
  1) pavucontrol ;;
  3) amixer -q sset Master toggle ;;  # right click, mute/unmute
  4) amixer -q sset Master 5%+ unmute ;; # scroll up, increase
  5) amixer -q sset Master 5%- unmute ;; # scroll down, decrease
esac

volume | format

Hope my information is useful to you.

Install the pavucontrol application and in your settings, select the exit option for the phones.

@IzacCF I can't find any exit option in the pavucontrol app. Can you be more specific?

In the "output devices" tab, do you have this option?
Here it is in Portuguese, it is unnecessary to send an application print.

There are only "Mute audio", "Lock channels together" and "Set as fallback" with the Advanced option being "Latency offset".

It's that?
https://community.linuxmint.com/img/screenshots/pavucontrol.png
Does your application have the "Output devices" tab?

Yes I do have the "Output Devices" tab in pavucontrol:

Pretty sure I installed the correct application: Link
OS: Arch Linux 4.9.6-1 x64

If the headset works, but polybar can not control, I think there is an incompatibility.
And I apologize for my English.

Fixed. A reinstallation of the whole system fixed the issue.
...Nah, actually this is what I did on the new system (that I haven't done on the old):
Change the value of defaults.ctl.card and defaults.pcm.card from 0 to 1 then reboot. This makes amixer scontrols to output much more details:
Simple mixer control 'Master',0
Simple mixer control 'Headphone',0
Simple mixer control 'Speaker',0
Simple mixer control 'PCM',0
Simple mixer control 'Mic',0
Simple mixer control 'Mic Boost',0
Simple mixer control 'IEC958',0
Simple mixer control 'IEC958 Default PCM',0
Simple mixer control 'Capture',0
Simple mixer control 'Auto-Mute Mode',0
Simple mixer control 'Internal Mic',0
Simple mixer control 'Internal Mic Boost',0
Simple mixer control 'Loopback Mixing',0

And the volume module reacts to the headphone plugs again.

authors: IzacCF jaagr khoacao96

repo: jaagr/polybar


text:
Font formatting tags break on format-prefix when using color variables.

Based off of the sample configurations:
[module/cpu]
type = internal/cpu
interval = 2
format = <bar-load>
format-prefix = %{T3} %{T-}
format-prefix-foreground = %{colors.blue}

Results in

%{r}%{F%{colors.blue} T3} %{T- F#65737E T2}%{T2}%{T2}%{T2}%{T2}%{T2}%{T- F- T-}

This works as expected for the battery, network and filesystem modules where format-xxx-prefix is used.

Side note: Is it important to close formatting tags at the end of elements? I have noticed no difference in leaving them open when formatting to the end of a line. Like I do over here.

NOT a bug...
My simple typo. If anybody is having the same problem, remember variables have dollar signs $.
Sorry for the noise.


text:
Add HTML Title

No html titles currently. Definitely need those.

Temporarily added single title shared across all pages.