text:
flatpak-builder: 1.2.3 -> 1.4.2

Description of changes
Changelog: https://github.com/flatpak/flatpak-builder/releases/tag/1.4.2
Closes: https://github.com/NixOS/nixpkgs/issues/279784
I replaced the old build tool with meson, as recommended by upstream. Needed to adapt appstream to build with compose support, so flatpak-builder can use it. Also, updated the patch to fix paths and modified the test one, and also removed unused parts.
Btw should I set a withCompose in appstream and make it optional?

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3265

I cancelled the nixpkgs-review at 400 successful builds, These changes looks very good to me.
Would you be interested in maintaining this package? It's okay to say no

Yeah, I can maintain it.

The tarball provided is using an old/incomplete version of the libglnx, I'm talking with upstream about this to see what can be done.

Result of nixpkgs-review pr 280152 run on x86_64-linux 1

7 packages marked as broken and skipped:

gnomeExtensions.easyScreenCast
golden-cheetah-bin
lua52Packages.nfd
lua53Packages.nfd
lua54Packages.nfd
luaPackages.nfd
textpieces

1 package blacklisted:

appimage-run-tests

8 packages failed to build:

badlion-client
catnip-gtk4
collision
fractal
pureref
radicle-upstream
rtfm
surge

765 packages built:

Sylk
adapta-gtk-theme
adwsteamgtk
ajour
alfis
altair
alvr
amberol
anytype
appimage-run
appstream
appstream.dev
appstream.installedTests
apx-gui
arduino-ide
ashpd-demo
audio-sharing
authenticator
autokey
autokey.dist
bada-bib
banking
baobab (gnome.baobab)
bazecor
beekeeper-studio
beeper
bespokesynth
bespokesynth-with-vst2
betterdiscord-installer
blackbox-terminal
blanket
bloomrpc
blueberry
blueprint-compiler
boatswain
bookworm
bootstrap-studio
bottles
bottles-unwrapped
breath-theme
budgie.budgie-control-center
budgie.budgie-control-center.debug
budgie.budgie-desktop
budgie.budgie-desktop-with-plugins
budgie.budgie-gsettings-overrides
budgie.magpie
budgie.magpie.debug
budgie.magpie.dev
budgie.magpie.devdoc
budgiePlugins.budgie-analogue-clock-applet
budgiePlugins.budgie-user-indicator-redux
buttercup-desktop
caido
cambalache
caprine-bin
cartridges
cavalier
celeste
celluloid
cemu
chatty
chess-clock
chromatic
chrysalis
cider
cinnamon.cinnamon-common
cinnamon.cinnamon-gsettings-overrides
cinnamon.cinnamon-screensaver
cinnamon.cinnamon-session
cinnamon.muffin
cinnamon.muffin.dev
cinnamon.muffin.man
cinnamon.nemo
cinnamon.nemo-fileroller
cinnamon.nemo-python
cinnamon.nemo-with-extensions
cinnamon.nemo.dev
cinnamon.pix
cinnamon.warpinator
cinnamon.xapp
cinnamon.xapp.dev
cinnamon.xreader
cinnamon.xviewer
citations
citra-canary
citra-nightly
clairvoyant
clapper
codux
colloid-kde
colloid-kde.sddm
confy
conjure
contrast
cozy-drive
crypto-org-wallet
curtail
d-spy
d-spy.dev
d-spy.lib
davinci-resolve
davinci-resolve-studio
deepin.dde-launchpad
deja-dup
delfin
denaro
denemo
deskreen
devdocs-desktop
dialect
diebahn
dino
dippi
done
door-knocker
dropbox-cli
dropbox-cli.nautilusExtension
dynamic-wallpaper
eartag
easyeffects
easyeffects.debug
eiciel
eiciel.nautilusExtension
elastic
electron-mail
electronplayer
emblem
emulsion-palette
endeavour
epiphany (gnome.epiphany)
errands
evince (gnome.evince)
evince.dev (gnome.evince.dev)
evince.devdoc (gnome.evince.devdoc)
eyedropper
fclones-gui
firefly-desktop
flare-signal
flatpak
flatpak-builder
flatpak-builder.doc
flatpak-builder.installedTests
flatpak-builder.man
flatpak.dev
flatpak.devdoc
flatpak.doc
flatpak.installedTests
flatpak.man
flexoptix-app
flowtime
fluent-reader
fluffychat
fluffychat.debug
fluffychat.pubcache
fm
foliate
forge-sparks
fragments
framesh
fretboard
fspy
furtherance
g4music
gamemode
gamemode.dev
gamemode.lib
gamemode.man
geopard
giara
glide-media-player
glom
glom.dev
glom.devdoc
glom.doc
glom.lib
gnome-browser-connector
gnome-builder
gnome-builder.devdoc
gnome-console
gnome-decoder
gnome-extension-manager
gnome-feeds
gnome-firmware
gnome-frog
gnome-network-displays
gnome-obfuscate
gnome-podcasts
gnome-secrets
gnome-solanum
gnome-tecla
gnome-text-editor
gnome-tour
gnome-usage
gnome.file-roller
gnome.ghex
gnome.ghex.dev
gnome.ghex.devdoc
gnome.gnome-bluetooth
gnome.gnome-bluetooth.dev
gnome.gnome-bluetooth.devdoc
gnome.gnome-bluetooth.man
gnome.gnome-calculator
gnome.gnome-calendar
gnome.gnome-characters
gnome.gnome-chess
gnome.gnome-clocks
gnome.gnome-contacts
gnome.gnome-control-center
gnome.gnome-control-center.debug
gnome.gnome-flashback
gnome.gnome-font-viewer
gnome.gnome-initial-setup
gnome.gnome-logs
gnome.gnome-mahjongg
gnome.gnome-maps
gnome.gnome-music
gnome.gnome-panel-with-modules
gnome.gnome-session
gnome.gnome-session.debug
gnome.gnome-session.sessions
gnome.gnome-shell
gnome.gnome-shell.debug
gnome.gnome-shell.devdoc
gnome.gnome-software
gnome.gnome-sound-recorder
gnome.gnome-sudoku
gnome.gnome-terminal
gnome.gnome-tweaks
gnome.gnome-weather
gnome.gpaste
gnome.metacity
gnome.mutter
gnome.mutter.debug
gnome.mutter.dev
gnome.mutter.devdoc
gnome.mutter.man
gnome.mutter43 (pantheon.mutter)
gnome.mutter43.debug (pantheon.mutter.debug)
gnome.mutter43.dev (pantheon.mutter.dev)
gnome.mutter43.devdoc (pantheon.mutter.devdoc)
gnome.mutter43.man (pantheon.mutter.man)
gnome.nautilus
gnome.nautilus-python
gnome.nautilus-python.dev
gnome.nautilus-python.devdoc
gnome.nautilus-python.doc
gnome.nautilus.dev
gnome.nautilus.devdoc
gnome.nixos-gsettings-overrides
gnome.polari
gnome.sushi
gnome.zenity
gnomeExtensions.easyeffects-preset-selector
gnomeExtensions.gsconnect
gnomeExtensions.gsconnect.installedTests
gnomeExtensions.gtk4-desktop-icons-ng-ding
gnonograms
gpu-viewer
gradience
grapejuice
grapejuice.dist
graphite-kde-theme
gtkcord4
gtranslator
halftone
hamsket
headlines
health
helio-workstation
helvum
heroic
hifile
hoppscotch
hqplayer-desktop
hqplayer-desktop.doc
hypnotix
icon-library
identity
imaginer
immersed-vr
impression
iotas
irccloud
jan
jbrowse
jetbrains-toolbox
joplin-desktop
junction
karlender
kchat
kdePackages.appstream-qt (qt6Packages.appstream-qt ,yuzuPackages.appstream-qt)
kdePackages.appstream-qt.dev (qt6Packages.appstream-qt.dev ,yuzuPackages.appstream-qt.dev)
kdePackages.appstream-qt.installedTests (qt6Packages.appstream-qt.installedTests ,yuzuPackages.appstream-qt.installedTests)
kdePackages.breeze
kdePackages.breeze-gtk
kdePackages.breeze-gtk.debug
kdePackages.breeze-gtk.dev
kdePackages.breeze.debug
kdePackages.breeze.dev
kdePackages.breeze.qt5
kdePackages.discover
kdePackages.discover.debug
kdePackages.discover.dev
kdePackages.flatpak-kcm
kdePackages.flatpak-kcm.debug
kdePackages.flatpak-kcm.dev
kdePackages.frameworkintegration
kdePackages.frameworkintegration.debug
kdePackages.frameworkintegration.dev
kdePackages.kdeplasma-addons
kdePackages.kdeplasma-addons.debug
kdePackages.kdeplasma-addons.dev
kdePackages.kwin
kdePackages.kwin.debug
kdePackages.kwin.dev
kdePackages.oxygen
kdePackages.oxygen.debug
kdePackages.oxygen.dev
kdePackages.oxygen.qt5
kdePackages.plasma-browser-integration
kdePackages.plasma-browser-integration.debug
kdePackages.plasma-browser-integration.dev
kdePackages.plasma-desktop
kdePackages.plasma-desktop.debug
kdePackages.plasma-desktop.dev
kdePackages.plasma-integration
kdePackages.plasma-integration.debug
kdePackages.plasma-integration.dev
kdePackages.plasma-integration.qt5
kdePackages.plasma-mobile
kdePackages.plasma-mobile.debug
kdePackages.plasma-mobile.dev
kdePackages.plasma-pa
kdePackages.plasma-pa.debug
kdePackages.plasma-pa.dev
kdePackages.plasma-workspace
kdePackages.plasma-workspace.debug
kdePackages.plasma-workspace.dev
kdePackages.powerdevil
kdePackages.powerdevil.debug
kdePackages.powerdevil.dev
keet
khronos
kodelife
kodi-cli
kodiPackages.libretro-2048
kodiPackages.libretro-fuse
kodiPackages.libretro-genplus
kodiPackages.libretro-mgba
kodiPackages.libretro-nestopia
kodiPackages.libretro-snes9x
kodiPackages.steam-launcher
komikku
kooha
lact
lan-mouse
latte-dock
layan-kde
lbry
ldtk
ledger-live-desktop
lens
libadwaita
libadwaita.dev
libadwaita.devdoc
libpanel
libpanel.dev
libpanel.devdoc
libretro.atari800
libretro.beetle-gba
libretro.beetle-lynx
libretro.beetle-ngp
libretro.beetle-pce
libretro.beetle-pce-fast
libretro.beetle-pcfx
libretro.beetle-psx
libretro.beetle-psx-hw
libretro.beetle-saturn
libretro.beetle-supafaust
libretro.beetle-supergrafx
libretro.beetle-vb
libretro.beetle-wswan
libretro.blastem
libretro.bluemsx
libretro.bsnes
libretro.bsnes-hd
libretro.bsnes-mercury
libretro.bsnes-mercury-balanced
libretro.bsnes-mercury-performance
libretro.citra
libretro.desmume
libretro.desmume2015
libretro.dolphin
libretro.dosbox
libretro.dosbox-pure
libretro.easyrpg
libretro.eightyone
libretro.fbalpha2012
libretro.fbneo
libretro.fceumm
libretro.flycast
libretro.fmsx
libretro.freeintv
libretro.fuse
libretro.gambatte
libretro.genesis-plus-gx
libretro.gpsp
libretro.gw
libretro.handy
libretro.hatari
libretro.mame
libretro.mame2000
libretro.mame2003
libretro.mame2003-plus
libretro.mame2010
libretro.mame2015
libretro.mame2016
libretro.melonds
libretro.mesen
libretro.mesen-s
libretro.meteor
libretro.mgba
libretro.mrboom
libretro.mupen64plus
libretro.neocd
libretro.nestopia
libretro.np2kai
libretro.nxengine
libretro.o2em
libretro.opera
libretro.parallel-n64
libretro.pcsx-rearmed
libretro.pcsx2
libretro.picodrive
libretro.play
libretro.ppsspp
libretro.prboom
libretro.prosystem
libretro.puae
libretro.quicknes
libretro.same_cdi
libretro.sameboy
libretro.scummvm
libretro.smsplus-gx
libretro.snes9x
libretro.snes9x2002
libretro.snes9x2005
libretro.snes9x2005-plus
libretro.snes9x2010
libretro.stella
libretro.stella2014
libretro.swanstation
libretro.tgbdual
libretro.thepowdertoy
libretro.tic80
libretro.twenty-fortyeight
libretro.vba-m
libretro.vba-next
libretro.vecx
libretro.virtualjaguar
libretro.yabause
libsForQt5.applet-window-appmenu (plasma5Packages.applet-window-appmenu)
libsForQt5.appstream-qt (plasma5Packages.appstream-qt)
libsForQt5.appstream-qt.dev (plasma5Packages.appstream-qt.dev)
libsForQt5.appstream-qt.installedTests (plasma5Packages.appstream-qt.installedTests)
libsForQt5.bismuth (plasma5Packages.bismuth)
libsForQt5.discover (plasma5Packages.discover)
libsForQt5.flatpak-kcm (plasma5Packages.flatpak-kcm)
libsForQt5.kde-cli-tools (plasma5Packages.kde-cli-tools)
libsForQt5.kdeplasma-addons (plasma5Packages.kdeplasma-addons)
libsForQt5.kdev-php (plasma5Packages.kdev-php)
libsForQt5.kdev-python (plasma5Packages.kdev-python)
libsForQt5.kdevelop (plasma5Packages.kdevelop)
libsForQt5.kdevelop-unwrapped (plasma5Packages.kdevelop-unwrapped)
libsForQt5.khotkeys (plasma5Packages.khotkeys)
libsForQt5.khotkeys.bin (plasma5Packages.khotkeys.bin)
libsForQt5.khotkeys.dev (plasma5Packages.khotkeys.dev)
libsForQt5.kinfocenter (plasma5Packages.kinfocenter)
libsForQt5.kmenuedit (plasma5Packages.kmenuedit)
libsForQt5.krohnkite (plasma5Packages.krohnkite)
libsForQt5.kwin-dynamic-workspaces (plasma5Packages.kwin-dynamic-workspaces)
libsForQt5.kwin-tiling (plasma5Packages.kwin-tiling)
libsForQt5.kzones (plasma5Packages.kzones)
libsForQt5.parachute (plasma5Packages.parachute)
libsForQt5.plasma-bigscreen (plasma5Packages.plasma-bigscreen)
libsForQt5.plasma-browser-integration (plasma5Packages.plasma-browser-integration)
libsForQt5.plasma-desktop (plasma5Packages.plasma-desktop)
libsForQt5.plasma-disks (plasma5Packages.plasma-disks)
libsForQt5.plasma-disks.bin (plasma5Packages.plasma-disks.bin)
libsForQt5.plasma-disks.dev (plasma5Packages.plasma-disks.dev)
libsForQt5.plasma-mobile (plasma5Packages.plasma-mobile)
libsForQt5.plasma-remotecontrollers (plasma5Packages.plasma-remotecontrollers)
libsForQt5.plasma-workspace (plasma5Packages.plasma-workspace)
libsForQt5.plasma-workspace.dev (plasma5Packages.plasma-workspace.dev)
libsForQt5.powerdevil (plasma5Packages.powerdevil)
libsForQt5.systemsettings (plasma5Packages.systemsettings)
libsForQt5.systemsettings.bin (plasma5Packages.systemsettings.bin)
libsForQt5.systemsettings.dev (plasma5Packages.systemsettings.dev)
libsForQt5.xdg-desktop-portal-kde (plasma5Packages.xdg-desktop-portal-kde)
lightdm-slick-greeter
lightly-boehs
lightly-qt
listen1
livecaptions
lorem
losslesscut-bin
loupe
lua51Packages.nfd
luajitPackages.nfd
ludusavi
lunar-client
lunatask
lutris
lutris-free
lxi-tools-gui
malcontent-ui
malcontent-ui.dev
malcontent-ui.lib
mangohud
mangohud.doc
mangohud.man
marktext
mate.marco
mate.mate-applets
mate.mate-control-center
mate.mate-indicator-applet
mate.mate-media
mate.mate-netbook
mate.mate-notification-daemon
mate.mate-panel
mate.mate-power-manager
mate.mate-screensaver
mate.mate-sensors-applet
mate.mate-settings-daemon-wrapped
mate.mate-tweak
mate.mate-tweak.dist
mate.mate-utils
mathpix-snipping-tool
megaglest
mendeley
mepo
metadata-cleaner
meteo
miru
mission-center
mobilecoin-wallet
mockoon
mojave-gtk-theme
molotov
monitor
monophony
motrix
mousai
mousam
mqttx
museeks
muzika
mycrypto
nautilus-open-any-terminal
nautilus-open-any-terminal.dist
nautilus-open-in-blackbox
neo4j-desktop
netease-cloud-music-gtk
newsflash
nordic
nordic.sddm
nosql-workbench
notable
notejot
notesnook
notion-app-enhanced
nuclear
open-scq30
openlens
openraPackages_2019.engines.bleed
openraPackages_2019.engines.playtest
openra_2019 (openraPackages_2019.engines.release)
openraPackages_2019.mods.ca
openraPackages_2019.mods.d2
openraPackages_2019.mods.dr
openraPackages_2019.mods.gen
openraPackages_2019.mods.kknd
openraPackages_2019.mods.mw
openraPackages_2019.mods.ra2
openraPackages_2019.mods.raclassic
openraPackages_2019.mods.rv
openraPackages_2019.mods.sp
openraPackages_2019.mods.ss
openraPackages_2019.mods.ura
openraPackages_2019.mods.yr
osu-lazer-bin
overskride
oversteer
p3x-onenote
paleta
pantheon.appcenter
pantheon.elementary-code
pantheon.elementary-feedback
pantheon.elementary-greeter
pantheon.elementary-gsettings-schemas
pantheon.elementary-onboarding
pantheon.elementary-photos
pantheon.elementary-session-settings
pantheon.epiphany
pantheon.file-roller-contract
pantheon.gala
pantheon.sideload
pantheon.switchboard-plug-a11y
pantheon.switchboard-plug-about
pantheon.switchboard-plug-applications
pantheon.switchboard-plug-bluetooth
pantheon.switchboard-plug-mouse-touchpad
pantheon.switchboard-plug-pantheon-shell
pantheon.switchboard-plug-power
pantheon.switchboard-plug-security-privacy
pantheon.switchboard-with-plugs
pantheon.wingpanel
pantheon.wingpanel-applications-menu
pantheon.wingpanel-indicator-a11y
pantheon.wingpanel-indicator-bluetooth
pantheon.wingpanel-indicator-datetime
pantheon.wingpanel-indicator-keyboard
pantheon.wingpanel-indicator-network
pantheon.wingpanel-indicator-nightlight
pantheon.wingpanel-indicator-notifications
pantheon.wingpanel-indicator-power
pantheon.wingpanel-indicator-session
pantheon.wingpanel-indicator-sound
pantheon.wingpanel-with-indicators
paper-clip
paper-plane
parabolic
parsec-bin
parsify
passes
pdfmm
pentobi
phoc
phosh
phosh-mobile-settings
pika-backup
planify
plata-theme
plexamp
plots
plots.dist
plugdata
pods
polypane
portfolio-filemanager
prismlauncher
prismlauncher-qt5
prismlauncher-qt5-unwrapped
prismlauncher-unwrapped
protontricks
protontricks.dist
protonup-qt
pwvucontrol
python311Packages.xapp
python312Packages.xapp
qogir-kde
raider
rambox
raven-reader
read-it-later
remnote
requestly
resources
retroarch
retroarchBare
retroarchFull
rnote
rymcast
saleae-logic-2
satty
sbclPackages.cl-gtk4_dot_adw
schemes
session-desktop
setzer
sfizz
shipwright
shortwave
showmethekey
simplex-chat-desktop
smile
snapshot
snippetpixie
sonixd
spacedrive
spot
spotify
spotifywm
ssb-patchwork
station
steam (steamPackages.steam-fhsenv)
steam-rom-manager
steam-small (steamPackages.steam-fhsenv-small)
steamPackages.steam-fhsenv-without-steam
sticky
svp
switcheroo
symbolic-preview
sysprof
sysprof.dev
sysprof.lib
tagger
tailor-gui
tangram
telegraph
tev
text-engine
tilix
timeshift
timeshift-minimal
timeshift-unwrapped
timeular
todoist-electron
touchosc
trayscale
trezor-suite
trigger-control
tuba
tusk
tutanota-desktop
upscayl
utterly-nord-plasma
vala-language-server
valent
vcv-rack
via
vial
video-trimmer
vimPlugins.vCoolor-vim
vimix-gtk-themes
wacomtablet
warp
watchmate
webfontkitgenerator
whatip
whitesur-gtk-theme
whitesur-kde
wifi-qr
wifi-qr.man
wike
winetricks
wingpanel-indicator-ayatana
wl-color-picker
wootility
wordbook
xdg-desktop-portal
xdg-desktop-portal-gnome
xdg-desktop-portal-gtk
xdg-desktop-portal-xapp
xdg-desktop-portal.installedTests
xed-editor
xfce.xfce4-screenshooter
xfce.xfce4-screenshooter.dev
xlights
xmonad_log_applet_mate
xplayer
ytmdesktop
zecwallet-lite
zettlr
zrythm
zulip

All failing packages also fail on hydra except:

catnip-gtk4: timeout
fractal: timeout
surge: failing check during build

LGTM

Could you retarget the PR to staging? Make sure to mark it as draft first in case your master is ahead of staging, so lots of people don't get pinged for review by ofborg

Could you retarget the PR to staging? Make sure to mark it as draft first in case your master is ahead of staging, so lots of people don't get pinged for review by ofborg

Done.

source: gharchive/pull-request

authors: arthsmn nixos-discourse pbsds

repo: NixOS/nixpkgs

license: MIT

license_type: permissive

license_source: github-api


text:
fetchgit: Support fetching signed tags over dumb http transport

Description of changes
Support fetching annotated (eg: signed) tags from dumb-http-transport git remotes.
Testing advice welcome!  It seems like these tests depend upon live internet services, which seems not-great!  Currently, it only depends upon github.com, which many other nixpkgs things also rely on, and github.com has pretty good capacity and availability.  But I don't immediately see a way to test this change against github.com because github dropped support for dumb http fetching in 2011.  I've included a test against my own humble home server here to demonstrate how this change corrects the defect, but my humble home server does not have the capacity and availability of github.com!  I'm wary of leaving this test case in, lest any unavailability of my humble home server cause spurious flaky test failures for others.  :(
Output of the test case failing without the fix:
$ nix-build . -A tests.fetchgit.dumb-http-signed-tag
this derivation will be built:
  /nix/store/by82f6l6xq9242r1v1gq6855i2y5mqhg-dumb-http-signed-tag-source-salted-mglyr7v5dxa5.drv
building '/nix/store/by82f6l6xq9242r1v1gq6855i2y5mqhg-dumb-http-signed-tag-source-salted-mglyr7v5dxa5.drv'...
exporting https://git.scottworley.com/pub/git/pinch (rev v3.0.14) into /nix/store/7886l42bijhly4k816zdnpy5gcp4h36d-dumb-http-signed-tag-source-salted-mglyr7v5dxa5
Initialized empty Git repository in /nix/store/7886l42bijhly4k816zdnpy5gcp4h36d-dumb-http-signed-tag-source-salted-mglyr7v5dxa5/.git/
fatal: dumb http transport does not support shallow capabilities
fatal: dumb http transport does not support shallow capabilities
From https://git.scottworley.com/pub/git/pinch
 * [new branch]      master     -> origin/master
 * [new tag]         1.0        -> 1.0
 ...
 * [new tag]         2.1.0      -> 2.1.0
 * [new tag]         2.1.1      -> 2.1.1
 * [new tag]         v3.0.0     -> v3.0.0
 * [new tag]         v3.0.1     -> v3.0.1
 * [new tag]         v3.0.10    -> v3.0.10
 * [new tag]         v3.0.11    -> v3.0.11
 * [new tag]         v3.0.12    -> v3.0.12
 * [new tag]         v3.0.13    -> v3.0.13
 * [new tag]         v3.0.14    -> v3.0.14
 * [new tag]         v3.0.2     -> v3.0.2
 ...
 * [new tag]         v3.0.9     -> v3.0.9
Unrecognized git object type: tag
Unable to checkout refs/tags/v3.0.14 from https://git.scottworley.com/pub/git/pinch.
error: builder for '/nix/store/by82f6l6xq9242r1v1gq6855i2y5mqhg-dumb-http-signed-tag-source-salted-mglyr7v5dxa5.drv' failed with exit code 1;

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

It looks like the problem was introduced in #104714.  FYI: @thomasjm @primeos
I think this PR will fix #115145. FYI: @eduardosm
I think this PR will fix #126848. FYI: @sternenseemann

Testing advice welcome!
You turn the test into a NixOS test, then you could spin up a local http server and test against that directly. That is a lot more involved though. I'll leave it to you.

@ofborg build tests.fetchgit

authors: chkno nrdxp sternenseemann