text:
RedirectToAction with Non-English Characters in Parameters and Authentication Causes Error

By default Asp.Net Core encodes non-english characters in view.
Let's create a very simple controller:
public class HomeController : Controller
{
	public IActionResult Index(Parameters param)
	{
		return View(param);
	}

	public IActionResult ToIndex(Parameters param)
	{
		return RedirectToAction("Index", param);
	}

	public class Parameters
	{
		public String Name { get; set; }
	}
}

and a very simple View, which greets a user:
@model TestNonEngLetters.Controllers.HomeController.Parameters
<!DOCTYPE html>
<html>
    <head>
        <meta charset="utf-8" />
        <title>Test</title>
    </head>
    <body>
        Hello, @Model.Name!
    </body>
</html>

If Name contains non-english characters (e.g. Jörn) it gets encoded:
<!DOCTYPE html>
<html>
    <head>
        <meta charset="utf-8" />
        <title>Test</title>
    </head>
    <body>
        Hello, Jörn!
    </body>
</html>

If we don't want this kind of encoding there is a way to turn it off. We need to add this line of code to Startup.cs:
services.Configure<WebEncoderOptions>(options => options.TextEncoderSettings = new TextEncoderSettings(UnicodeRanges.All));

Now our html becomes pretty good:
<!DOCTYPE html>
<html>
    <head>
        <meta charset="utf-8" />
        <title>Test</title>
    </head>
    <body>
        Hello, Jörn!
    </body>
</html>

Our Startup.cs looks like this:
public class Startup
{
	public void ConfigureServices(IServiceCollection services)
	{
		//services.AddAuthentication(CookieAuthenticationDefaults.AuthenticationScheme);

		services.AddMvc();
		services.Configure<WebEncoderOptions>(options => options.TextEncoderSettings = new TextEncoderSettings(UnicodeRanges.All));
	}

	public void Configure(IApplicationBuilder app, IHostingEnvironment env)
	{
		if (env.IsDevelopment())
		{
			app.UseDeveloperExceptionPage();
		}

		app.UseMvc(routes =>
		{
			routes.MapRoute(
				name: "default",
				template: "{controller=Home}/{action=Index}/{id?}");
		});
	}
}

Let's invoke our ToIndex action, that must redirect us back to Index:
public IActionResult ToIndex(Parameters param)
{
	return RedirectToAction("Index", param);
}

So we invoke page http://localhost:2616/Home/ToIndex?Name=Jörn and receive expected 302 response with location=/?Name=J%C3%B6rn http header.
Everything works just fine... until we add authentication to our project. See the commented line in Startup.cs?
//services.AddAuthentication(CookieAuthenticationDefaults.AuthenticationScheme);

Let's uncomment it and invoke our ToIndex action again.
And what we get?
InvalidOperationException: Invalid non-ASCII or control character in header: 0x00F6

    Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.FrameHeaders.ThrowInvalidHeaderCharacter(char ch)
    Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.FrameHeaders.ValidateHeaderCharacters(string headerCharacters)
    Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.FrameHeaders.ValidateHeaderCharacters(StringValues headerValues)
    Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.FrameResponseHeaders.SetValueFast(string key, StringValues value)
    Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.FrameHeaders.Microsoft.AspNetCore.Http.IHeaderDictionary.set_Item(string key, StringValues value)
    Microsoft.AspNetCore.Http.Internal.DefaultHttpResponse.Redirect(string location, bool permanent)
    Microsoft.AspNetCore.Mvc.Internal.RedirectToActionResultExecutor.Execute(ActionContext context, RedirectToActionResult result)
    Microsoft.AspNetCore.Mvc.RedirectToActionResult.ExecuteResult(ActionContext context)
    Microsoft.AspNetCore.Mvc.ActionResult.ExecuteResultAsync(ActionContext context)
    Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker+<InvokeResultAsync>d__19.MoveNext()
    System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker+<InvokeNextResultFilterAsync>d__24.MoveNext()
    System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Rethrow(ResultExecutedContext context)
    Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Next(ref State next, ref Scope scope, ref object state, ref bool isCompleted)
    Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker+<InvokeNextResourceFilter>d__22.MoveNext()
    System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Rethrow(ResourceExecutedContext context)
    Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Next(ref State next, ref Scope scope, ref object state, ref bool isCompleted)
    Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker+<InvokeFilterPipelineAsync>d__17.MoveNext()
    System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker+<InvokeAsync>d__15.MoveNext()
    System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    Microsoft.AspNetCore.Builder.RouterMiddleware+<Invoke>d__4.MoveNext()
    System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
    System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
    Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware+<Invoke>d__7.MoveNext()

it looks like now, when authentication module is in place, asp.net core is not able to set location header correctly.
So, maybe we have chosen the wrong way to deal with encoding of non-english characters or is it a bug in framework itself?

Thanks for contacting us, @busyscout. Can you please share a sample repro project with us to investigate?

@dougbu, can you please investigate this? Thanks

@busyscout within MVC, a UrlEncoder instance ensures invalid characters are not present in the generated URL. Because you're completely disabling the encoder, FrameHeaders.ValidateHeaderCharacters(...) fails. Recommend enabling only the specific Unicode ranges of particular interest, not using UnicodeRanges.All.
Please also see https://docs.microsoft.com/en-us/aspnet/core/security/cross-site-scripting#encoding-url-parameters which specifically mentions problems with including user data directly in a URL.

I want to disable encoding of non-english characters in generated html. Not in url. Because encoded symbols make my page 2 times bigger in kilobytes. And it seems to me, that there is no right way to do it. I think, it is an architectual issue in framework itself.
And if you look at the code I've provided - no url is created by hand, I use standard method RedirectToAction - and this method raises exception. And it works correctly until we add authentication module to mvc, that is strange. Seems to me there is some problem in auth module.

authors: busyscout dougbu mkArtakMSFT

repo: aspnet/Mvc


text:
ModelState not updating when using JsonPatchDocument.ApplyTo(T, ModelStateDictionary)

From @TheWillieWonkaOfCode on January 19, 2017 21:26
I was playing around with a REST service in ASP.NET Core MVC and found this issue.
Here is my model:
    public class Test
    {
        public int Id { get; set; }

        [Required]
        [StringLength(10, MinimumLength = 1)]
        public string FirstName { get; set; }

        [Required]
        [StringLength(10, MinimumLength = 1)]
        public string LastName { get; set; }

        public Test Copy()
        {
            Test newTest = new Test()
            {
                Id = this.Id,
                FirstName = FirstName,
                LastName = this.LastName
            };

            return newTest;
        }
    }

Here is my POST:
        [HttpPost]
        public IActionResult Create([FromBody] Test item)
        {
            if (item == null) return BadRequest();
            if (!ModelState.IsValid) return BadRequest();

            TestItems.Add(item);

            return CreatedAtRoute("GetTest", new { id = item.Id }, item);
        }

The validation fails correctly based on the attributes on the model.
Here is my PATCH (I have put comments around the issue):
       [HttpPatch("{id}")]
       public IActionResult Patch(string id, [FromBody] JsonPatchDocument<Test> patch)
       {
           int theId;
           if (!int.TryParse(id, out theId)) return BadRequest();
           if (patch == null) return BadRequest();

           Test item = TestItems.GetById(theId);
           if (item == null) return NotFound();

           // This is documented that it's supposed to update the ModelState, but it doesn't appear to do that
           // and the model is always valid even if the updated values are not valid. The ModelState object
           // only contains the id that was passed, it is not validating the parts in the patch instance. V1.1
           // is not GA yet, so it may just be unfinished code.
           patch.ApplyTo(item, ModelState);
           // I shouldn't need to make this call, but the ModelState isn't updated by the ApplyTo call.
           // This correctly updates the ModelState with the errors.
           TryValidateModel(item);
           if (!ModelState.IsValid) return BadRequest();

           TestItems.Update(item);
           return new NoContentResult();
       }

I tried sending a replace for the FirstName to an empty string, and to a string that was too long. In both cases, the ModelState was unchanged after the call to ApplyTo. I added the call to TryValidateModel and that caused the ModelState to then be updated with errors.
Copied from original issue: aspnet/Home#1907

Thanks @rynowak. @TheWillieWonkaOfCode, we're closing this issue as it seems it has been answered. If you believe that your concerns hasn't been addressed, please reply with more details and we'll continue the discussion.

For which use case is this ModelState parameter of ApplyTo() designed at all? Just alone for the test operation?
For example I have a class to patch which might throw a PermissionDeniedException on setting some of the properties for which some of the users have not the required rights. But this only ends in a JsonSerializationException with my own Exception wrapped inside InnerException. I would have expected that the ModelState would reflect this error. Or maybe that the overload with Action<JsonPatchError> logErrorAction argument would call that callback. But nada.

source: gharchive/issue

authors: Eilon mkArtakMSFT springy76

license_type: permissive

license_source: github-api


text:
Fix #1579 - Bind top-level collections as an empty collection

This change treats 'top-level' collection-type models similarly to
top-level POCO model - namely that they will always be instantiated even
if there's no data to put inside.

@dougbu updated with some unit tests

:watch:

@dougbu Addressed most feedback, have one idea we should discuss.

Updated. Moved the model-creation down into the CollectionModelBinder classes.

:shipit:

source: gharchive/pull-request

authors: dougbu rynowak


text:
[Patch] Copy-pasting an item in an RCL project adds junk to the project file

Issue tracking possibly porting this fix for 2.1.x.

Approved for 2.1.3.

Approved for 2.1.3.

Am I good to merge the corresponding PR?

Yes.

Waiting on @ryanbrandenburg \ @natemcmaster to confirm when the branches are ready for 2.1.3 patch stuff.

We are not yet ready for 2.1.3 last I heard. I'll send mail to the team when release/2.1 branches are open for 2.1.3 work.

80483f08df1212b42a1b3bd45c407e75a5f15a5b
d25a2687e8fe183491b9ae99f9a62dee349af532

authors: NTaylorMullen muratg natemcmaster pranavkm

repo: aspnet/Razor


text:
Razor: Pad Helpers (@helper)

In the existing Razor implementation we did not pad razor helper statements due to our dependency on Visual Basic.
Now that we have a CodeTree we can implement this feature.
| 87 | 10183 | Reported By: N. Taylor Mullen |

Note: not performing accurate padding results in a bad editor experience where { and } are auto completed with bad indents.


text:
Razor Page templates use fully qualified name

From @Rick-Anderson on August 1, 2017 20:7
The constructor uses the FQN when it's not necessary. For example:
See Pages/Movie/Index.cshtml.cs
using RazorPagesMovie.Models; is in the template.
To repro - follow the Razor Pages tutorial
Copied from original issue: aspnet/Templates#858

This should be fixed in the latest version.

authors: mlorbetske vijayrkn

repo: aspnet/Scaffolding

license: MIT


text:
Update Universe failure

Just an FYI, pushing this to unblock the CI.

[10:51:04]
ASSEMBLY_INFORMATIONAL_VERSION_MISMATCH @ tools/any/any/System.Buffers.dll: The managed assembly informational version '4.6.26130.01 @BuiltBy: dlab-DDVSOWINAGE053 @SrcCode: https://github.com/dotnet/corefx/tree/5b5eacfce3a62712ceb67dfb51128221b0fce137' does not match the package version '2.1.0-preview2-1339' for package dotnet-aspnet-codegenerator.
[10:51:04]

[10:51:04]
ASSEMBLY_INFORMATIONAL_VERSION_MISMATCH @ tools/any/any/System.Memory.dll: The managed assembly informational version '4.6.26130.01 @BuiltBy: dlab-DDVSOWINAGE053 @SrcCode: https://github.com/dotnet/corefx/tree/5b5eacfce3a62712ceb67dfb51128221b0fce137' does not match the package version '2.1.0-preview2-1339' for package dotnet-aspnet-codegenerator.
[10:51:04]

[10:51:04]
ASSEMBLY_INFORMATIONAL_VERSION_MISMATCH @ tools/any/any/System.Numerics.Vectors.dll: The managed assembly informational version '4.6.26130.01 @BuiltBy: dlab-DDVSOWINAGE053 @SrcCode: https://github.com/dotnet/corefx/tree/5b5eacfce3a62712ceb67dfb51128221b0fce137' does not match the package version '2.1.0-preview2-1339' for package dotnet-aspnet-codegenerator.
[10:51:04]

[10:51:04]
ASSEMBLY_INFORMATIONAL_VERSION_MISMATCH @ tools/any/any/System.Runtime.CompilerServices.Unsafe.dll: The managed assembly informational version '4.0.0.0' does not match the package version '2.1.0-preview2-1339' for package dotnet-aspnet-codegenerator.
[10:51:04]

[10:51:04]
Justification: Assembly built by another project but bundled in our nupkg.
[10:51:04]

[10:51:04]
ASSEMBLY_FILE_VERSION_MISMATCH @ tools/any/any/System.Runtime.CompilerServices.Unsafe.dll: The managed assembly file version '4.0.0.0' does not match the package version '2.1.0-preview2-1339' for package dotnet-aspnet-codegenerator.
[10:51:04]

[10:51:04]
Justification: Assembly built by another project but bundled in our nupkg.
[10:51:04]

[10:51:04]
ASSEMBLY_VERSION_MISMATCH @ tools/any/any/System.Runtime.CompilerServices.Unsafe.dll: The managed assembly version '4.0.4.0' does not match the package version '2.1.0.0' for package dotnet-aspnet-codegenerator.
[10:51:04]

[10:51:04]
Justification: Assembly built by another project but bundled in our nupkg.
[10:51:04]

[10:51:04]
ASSEMBLY_INFORMATIONAL_VERSION_MISMATCH @ tools/any/any/runtimes/unix/lib/netcoreapp2.0/System.Buffers.dll: The managed assembly informational version '4.6.26130.01 @BuiltBy: dlab-DDVSOWINAGE053 @SrcCode: https://github.com/dotnet/corefx/tree/5b5eacfce3a62712ceb67dfb51128221b0fce137' does not match the package version '2.1.0-preview2-1339' for package dotnet-aspnet-codegenerator.
[10:51:04]

[10:51:04]
ASSEMBLY_INFORMATIONAL_VERSION_MISMATCH @ tools/any/any/runtimes/win/lib/netcoreapp2.0/System.Buffers.dll: The managed assembly informational version '4.6.26130.01 @BuiltBy: dlab-DDVSOWINAGE053 @SrcCode: https://github.com/dotnet/corefx/tree/5b5eacfce3a62712ceb67dfb51128221b0fce137' does not match the package version '2.1.0-preview2-1339' for package dotnet-aspnet-codegenerator.
[10:51:04]

[10:51:04]
Unnecessary exclusion in dotnet-aspnet-codegenerator
Issue: NEUTRAL_RESOURCES_LANGUAGE
Instance: tools/any/any/System.Buffers.dll
[10:51:04]

[10:51:04]
Processing package set 'Default' with 0 package(s)
[10:51:04]

[10:51:04]
Analyzing Microsoft.VisualStudio.Web.CodeGeneration (2.1.0-preview2-1339)
[10:51:04]

[10:51:04]
No issues found with package Microsoft.VisualStudio.Web.CodeGeneration (2.1.0-preview2-1339)
[10:51:04]

[10:51:04]
Analyzing Microsoft.VisualStudio.Web.CodeGeneration.Contracts (2.1.0-preview2-1339)
[10:51:04]

[10:51:04]
No issues found with package Microsoft.VisualStudio.Web.CodeGeneration.Contracts (2.1.0-preview2-1339)
[10:51:04]

[10:51:04]
Analyzing Microsoft.VisualStudio.Web.CodeGeneration.Core (2.1.0-preview2-1339)
[10:51:04]

[10:51:04]
No issues found with package Microsoft.VisualStudio.Web.CodeGeneration.Core (2.1.0-preview2-1339)
[10:51:04]

[10:51:04]
Analyzing Microsoft.VisualStudio.Web.CodeGeneration.Design (2.1.0-preview2-1339)
[10:51:04]
Identity | Identity.DefaultUI.WebSite -> C:\b\w\7471ab17b6f47b37\modules\Identity\test\WebSites\Identity.DefaultUI.WebSite\bin\Debug\net461\Identity.DefaultUI.WebSite.exe
[10:51:04]

[10:51:04]
Skipping signing rule request verification for C:\b\w\7471ab17b6f47b37\modules\AzureIntegration\artifacts\build\Microsoft.AspNetCore.AzureAppServicesIntegration.2.1.0-preview2-1339.nupkg
[10:51:04]

[10:51:04]
No issues found with package Microsoft.AspNetCore.AzureAppServicesIntegration (2.1.0-preview2-1339)
[10:51:04]

[10:51:04]
Analyzing Microsoft.Extensions.ApplicationModelDetection (2.1.0-preview2-1339)
[10:51:05]

[10:51:05]
Skipping signing rule request verification for C:\b\w\7471ab17b6f47b37\modules\AzureIntegration\artifacts\build\Microsoft.Extensions.ApplicationModelDetection.2.1.0-preview2-1339.nupkg
[10:51:05]

[10:51:05]
No issues found with package Microsoft.Extensions.ApplicationModelDetection (2.1.0-preview2-1339)
[10:51:05]

[10:51:05]
Processing package set 'Default' with 0 package(s)
[10:51:05]

[10:51:05]
Analyzing Microsoft.AspNetCore.ApplicationInsights.HostingStartup (2.1.0-preview2-1339)
[10:51:05]

[10:51:05]
Skipping signing rule request verification for C:\b\w\7471ab17b6f47b37\modules\Scaffolding\artifacts\build\Microsoft.VisualStudio.Web.CodeGeneration.Design.2.1.0-preview2-1339.nupkg
[10:51:05]

[10:51:05]
No issues found with package Microsoft.VisualStudio.Web.CodeGeneration.Design (2.1.0-preview2-1339)
[10:51:05]

[10:51:05]
Analyzing Microsoft.VisualStudio.Web.CodeGeneration.EntityFrameworkCore (2.1.0-preview2-1339)
[10:51:05]

[10:51:05]
No issues found with package Microsoft.VisualStudio.Web.CodeGeneration.EntityFrameworkCore (2.1.0-preview2-1339)
[10:51:05]

[10:51:05]
Analyzing Microsoft.VisualStudio.Web.CodeGeneration.Templating (2.1.0-preview2-1339)
[10:51:05]

[10:51:05]
No issues found with package Microsoft.VisualStudio.Web.CodeGeneration.Templating (2.1.0-preview2-1339)
[10:51:05]

[10:51:05]
Analyzing Microsoft.VisualStudio.Web.CodeGeneration.Utils (2.1.0-preview2-1339)
[10:51:05]

[10:51:05]
Skipping signing rule request verification for C:\b\w\7471ab17b6f47b37\modules\AzureIntegration\artifacts\build\Microsoft.AspNetCore.ApplicationInsights.HostingStartup.2.1.0-preview2-1339.nupkg
[10:51:05]

[10:51:05]
No issues found with package Microsoft.AspNetCore.ApplicationInsights.HostingStartup (2.1.0-preview2-1339)
[10:51:05]

[10:51:05]
Analyzing Microsoft.AspNetCore.AzureAppServices.HostingStartup (2.1.0-preview2-1339)
[10:51:05]
Identity | IdentitySample.DefaultUI -> C:\b\w\7471ab17b6f47b37\modules\Identity\samples\IdentitySample.DefaultUI\bin\Release\net461\IdentitySample.DefaultUI.exe
[10:51:05]

[10:51:05]
No issues found with package Microsoft.VisualStudio.Web.CodeGeneration.Utils (2.1.0-preview2-1339)
[10:51:05]

[10:51:05]
Analyzing Microsoft.VisualStudio.Web.CodeGenerators.Mvc (2.1.0-preview2-1339)
[10:51:05]

[10:51:05]
No issues found with package Microsoft.VisualStudio.Web.CodeGenerators.Mvc (2.1.0-preview2-1339)
[10:51:05]
Showing JSON for ignore content:
[10:51:05]
{
[10:51:05]
"dotnet-aspnet-codegenerator": {
[10:51:05]
"Exclusions": {
[10:51:05]
"ASSEMBLY_INFORMATIONAL_VERSION_MISMATCH": {
[10:51:05]
"tools/any/any/System.Buffers.dll": "Enter justification",
[10:51:05]
"tools/any/any/System.Memory.dll": "Enter justification",
[10:51:05]
"tools/any/any/System.Numerics.Vectors.dll": "Enter justification",
[10:51:05]
"tools/any/any/runtimes/unix/lib/netcoreapp2.0/System.Buffers.dll": "Enter justification",
[10:51:05]
"tools/any/any/runtimes/win/lib/netcoreapp2.0/System.Buffers.dll": "Enter justification"
[10:51:05]
}
[10:51:05]
}
[10:51:05]
}
[10:51:05]
}
[10:51:05]

[10:51:05]

[10:51:05]
SUMMARY: 0 error(s) and 5 warning(s) found
[10:51:05]

Can you make sure it builds locally with new primitives package?

authors: pakrym ryanbrandenburg


text:
Update to 4.5.0 builds of corefx packages

Follow up to https://github.com/aspnet/Coherence-Signed/issues/657. We should additionally update repos to reference 4.5.0 version of CoreFx packages.

cc @ryanbrandenburg

authors: natemcmaster pranavkm

repo: aspnet/Universe


text:
Update param name to match IWebHookHandler

This class doesn't seem to use the param, so shouldn't effect anything but it should be consistently named.

Hi @alindgren, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

Incorporated: e1b04c9463ae632f65b164a1ab390f62099f8411 Thanks!

authors: HenrikFrystykNielsen alindgren dnfclas

repo: aspnet/WebHooks

license_source: bigquery


text:
getting started with installation and development

made a few changes in readme file. created requirements.txt listing all the dependencies

Thank you .. 😋

authors: KulkarniSuraj asprazz


text:
Fatal error: >> Please run "bower install" before continuing.

Prompt always ask to install bower before running grunt command.
git clone git://github.com/assemble/boilerplate-bootstrap.git
Cloning into 'boilerplate-bootstrap'...
remote: Counting objects: 838, done.
remote: Total 838 (delta 0), reused 0 (delta 0)
Receiving objects: 100% (838/838), 2.88 MiB | 471.00 KiB/s, done.
Resolving deltas: 100% (319/319), done.
Checking connectivity... done.
MacBook-Pro-de-fernando:blog2015 fernandomonteiro$ npm install
MacBook-Pro-de-fernando:blog2015 fernandomonteiro$ grunt
Fatal error: >> Please run "bower install" before continuing.
MacBook-Pro-de-fernando:blog2015 fernandomonteiro$ bower install
MacBook-Pro-de-fernando:blog2015 fernandomonteiro$ grunt
Fatal error: >> Please run "bower install" before continuing.

Looks like you skipped this step.

@doowb Ok, i´ll try again. Thanks

Have same issue. Same output. What step was skipped?

@doowb ...
started with brand new empty directory from step 1.
the step:
npm i && git clone git://github.com/twbs/bootstrap.git "vendor/bootstrap" && cd Vendor/bootstrap && npm i
is yelling:
fatal: destination path 'vendor/bootstrap' already exists and is not an empty directory.

in the gruntfile.js
if(!grunt.file.exists('vendor/bootstrap/_config.yml')) {
grunt.fail.fatal('>> Please run "bower install" before continuing.');
}
if the file _config.yml is not in the vendor/bootstrap directory it will display the error to overcome this you need to copy the file _config.yml from the root directory into the  /vendor/bootstrap/ dirctory.

authors: Daniel-Peder cschweda doowb newaeonweb pacav69

repo: assemble/boilerplate-bootstrap

license: mit


text:
space in route

Hi!
First, great module, works very well.
I've run into one thing and I've tried a number of things but can't seem to get through it.  I'm doing a query on a user name in neo4j and the name contains a space.  This gets turned into %20 in the url but it doesn't seem to get turned back to a space.
I just want to validate that this is as expected, the route does not parse out the % values to actual characters to pass into the cypher query.  If that's the case, any suggestions as I don't want to recreate the data set to remove all spaces in all properties.
Thanks!

Hi @rogueturnip
Could you please provide a more concrete example including some code? Are you facing this on a GET request with url params?

Sure, thanks for following up.  What I'm trying to is look for a user node by name so I created:
app.defineApi({
method: 'GET',
route: '/users/:name',
cyperQueryFile: '.src/users/name.cyp'
})
Then I try to query like this
get /users/John%20Smith
I don't believe the %20 is being changed back to a space and I'm not having my Cypher query work.  It works when I use the Neo4j browser and enter in "John Smith"
Thanks!

I just tested this on the starter kit and it seems to be working, see below:
./src/article/index.js
app.defineAPI({
    method: 'GET',
    route: '/articles/:skip/:john',
    preProcess: logValues,
    cypherQueryFile: './src/article/articles.cyp'
});

Note the usage of logValues as preProcess, this helps with seeing the values passed to the endpoint in console.
import {logValues} from 'koa-neo4j/debug';

./src/article/articles.cyp
RETURN $john

Result

I suggest that you use logValues as per this example and investigate further what is actually happening.

Thanks!  I'll check this out!

@rogueturnip has this issue been resolved?

Yes it has, thanks, I'll close the issue.

authors: keyvan-m-sadeghi rogueturnip


text:
Раздел кошельков

Добавление, редактирвоание, удаление, вывод списка.

Готово


text:
Vocal tract length perturbation

Implemented VLTP as introduced in http://www.cs.toronto.edu/~hinton/absps/perturb.pdf. Adopted from the numpy code here: https://github.com/makcedward/nlpaug/blob/master/nlpaug/model/audio/vtlp.py
Additional notes:

Only supports single channel for now
At the moment, the entire batch will use one (randomized) warp factor
Added a sanity test case

Fixes #115

Thanks for the pull request :) I'll find time to review this

I added VTLP to the demo script and added a speech example there:
https://github.com/akashrajkn/torch-audiomentations/pull/1
I listened to the outputs, and it very much resembles a band stop filter. Is that what you intended? I've attached the sounds in this zip:
vtlp_demo_output.zip
And I have another question: is this a different technique? https://www.isca-speech.org/archive/pdfs/interspeech_2019/kim19_interspeech.pdf

I'm trying to learn about what Vocal Tract Length Perturbation is. Reading the paper, I get the idea that it's about frequency warping

For VTLP, we generate a random warp factor α for each utterance, and warp the freqency axis, such that a frequency f is mapped to a new frequency f ′

But I don't see frequencies getting re-mapped in the spectrogram gif I posted above
I also found this video online:
https://www.youtube.com/watch?v=vCDnfUM6gn8
Could you try to enlighten me? Do you have some reference examples of what VTLP should sound like? Am I missing something, or is there a bug in your implementation?

I understand that this transform does not support stereo/multichannel audio yet. Is that right?

[ ] That is right. I will modify it to support stereo audio

Is that the case here, or is it enough to just use the sample_rate you get from forward calls?

[ ] You are right, it is not required in the init function. I'll change it accordingly

And I have another question: is this a different technique? https://www.isca-speech.org/archive/pdfs/interspeech_2019/kim19_interspeech.pdf

I wasn't aware of this paper, I will read it and get back to you

Do you have some reference examples of what VTLP should sound like?

[ ] I postponed adding tests in this PR. I will add some reference examples

Am I missing something, or is there a bug in your implementation?

I think maybe there is an issue with my implementation. I will check it out and comment here (probably on the weekend)

Closing for inactivity. Feel free to suggest a reopen later if the work gets picked up again

repo: asteroid-team/torch-audiomentations


text:
[docs] Clarify that new rules should be added to RuleGroup::Preview.

In the contributing page, clarify that new rules must be added to RuleGroup::Preview when mapping their code.

Thanks!

authors: charliermarsh clemux

repo: astral-sh/ruff


text:
==3.11.* doesn't satisfy Python>=3.11,<4

requires-python = "==3.11.*" doesn't satisfy Python>=3.11,<4 for a project that depends on it, while requires-python = ">=3.11, <4" does an resolves without problem.
Example:
[project]
name = "warehouse"
version = "1.0.0"
requires-python = "==3.11.*"
# requires-python = ">=3.11, <4"
dependencies = [
  "linehaul",
]

$ cargo run -q -- lock --preview
  × No solution found when resolving dependencies:
  ╰─▶ Because the requested Python version (>=3.11.dev0, <3.12.dev0) does not satisfy Python>=3.11,<4 and all versions of linehaul depend
      on Python>=3.11,<4, we can conclude that all versions of linehaul cannot be used.
      And because only the following versions of linehaul are available:
          linehaul==1.0.0
          linehaul==1.0.1
      and warehouse==1.0.0 depends on linehaul, we can conclude that warehouse==1.0.0 cannot be used.
      And because only warehouse==1.0.0 is available and warehouse depends on warehouse, we can conclude that the requirements are
      unsatisfiable.

      hint: The `Requires-Python` requirement (>=3.11.dev0, <3.12.dev0) defined in your `pyproject.toml` includes Python versions that
      are not supported by your dependencies (e.g., all versions of linehaul only supports >=3.11, <4). Consider using a more restrictive
      `Requires-Python` requirement (like >=3.11, <4).

We should of course fix this but like... it's... technically... correct? I think?
==3.11.* includes versions like 3.11.0dev0, but >=3.11 does not.

The easy solution is to ignore pre, post, dev, and local segments when comparing Requires-Python.

authors: charliermarsh konstin

repo: astral-sh/uv


text:
universal-lock: if we write file paths to a lock file, we need to make them portable

While working on #4266, I realized that the file paths we write to a lock file are platform specific. Specifically, on Windows, we use \ as a path separator, while on Unix, we use / as a path separator. I believe this implies that if developers on Windows and Unix work on the same project, they will generate different lock files. This is, I believe, untenable.
I think we either need to find a way to not write file paths to a lock file at all (this is what Cargo does), or we need to ensure we normalize all file paths into a portable representation.
It's not clear to me that the latter is strictly possible in all cases, but I think we are always writing Unix paths to requirements.txt by either converting \ to /, or using file URLs.

See also https://github.com/astral-sh/uv/pull/3804

In the interim, should we just call to_slash on the paths? That library exists for this purpose IIRC.

Closed by #4324.
We should perhaps still explore the design space of "don't write paths to a lock file," but Charlie makes the point that this would require reading the pyproject.toml in order to understand the lock file. I believe, at present, the lock file is "hermetic," which could be conceivably useful (and it is at least conceptually simpler). My very vague thinking on the matter at present is the following:

I wouldn't be surprised if we wind up needing to read pyproject.toml and give up the hermetic lock file approach for some other reason. But I don't know what that reason is yet.
I have a nagging suspicion that even by converting paths to Unix paths, there are still some cases that we'll get wrong in the sense that it isn't portable. But I'm finding it difficult to articulate those cases since, even if the paths aren't in the lock file, they have to be somewhere (like pyproject.toml, which needs to be valid UTF-8 and thus inherently already prevents some kinds of file paths from being expressible as-is).

authors: BurntSushi charliermarsh zanieb


text:
Provide an APE installer instead of curling scripts?

Being easy to install is key for uv usage to spread.
The installation story is simple, yet still have a few gotchas:

An upstream issue in PowerShell permissions (https://github.com/astral-sh/uv/issues/2286)
The fact curl is not installed out of the box on many distros (including ubuntu) and that installing it requires a different command for each distro.
You have to choose between several installation methods.

While this will not trip a developer, it will likely at the very least slow down a student or a biologist.
Having an .exe for windows, a dev/rpm for linux and a dmg for Mac would be ideal, but a lot of work. Maybe there is an alternative.
In the last few years, Justine Tunney made APE (https://justine.lol/ape.html), a format that creates an executable that works universally on Windows, Mac and Linux.
It could be worth exploring to provide a single executable as an installer for all major platforms.
It's not guaranteed that it would be the perfect streamlined solution, as it could come with other challenges such as signing and security policies. Indeed, scripts have less restrictions than executable on most platforms.
What's more, because the rust story for API is incomplete (https://github.com/ahgamut/rust-ape-example), that would mean writing it in C, which I understand can be a big blocker.
This is not a feature request as much as it is way to open the discussion around that topic.

Ok, I made some experiments, but there is a blocker: on some linux distros, including Ubuntu, you might get errors relating to run-detectors due to binfmt_misc registrations.
Now each user can fix that by adding an additional registration for the APE file format but it requires an incantation of 4 arcanes commands, which, while easy to just copy-paste, are not an improvement compared to curl installation. Especially since it would be more trivial to just tell people:

download the script
chmox +x
sh it

If they don't have curl.
So I don't think that's a good solution.
I'm closing this, you have enough tickets as it is.


text:
Water Sensor reporting wrong value

The problem
Hi,
i have a G7160 Dishwasher and a WCI870 Whasing maschine and the same problem with both.
When the washing machine or dishwasher starts, the water consumption sensor briefly indicates a water consumption of 8L, then it drops to 0L and then begins to transmit the actual consumption.
The 8L are then added to the total consumption in the Energy Dashboard.
Thx in advance
Version of miele integration having the issue?
miele-v0.1.13
Version of Home Assistant Core having the issue?
Home Assistant 2023.5.3
Anything in the logs that might be useful for us?
No response
Additional information

Well, it is not clear what is happening here. Is it always 8 as initial spike? Or is the 8 the last value from previous washing session? The sensor just displays the value that is read from the API.

It is always the same 8L spike on both machines. No matter what the last sensor reading was.

That's odd. I also have a WCI870 but it shows no spikes.

There is no obvious reason that the sensor should show anything else than what is reported by the API. You can try to capture a debug log from the three dot menu in the Miele card in integrations page. Start the debug, wait a minute and then start your appliance and then turn it off after a couple of minutes. With a little luck the log might reveal the cause of the problem.

I started the dishwasher again, but this time for the first time the sensor did not record a spike. I'll take a closer look at it over the next few days. Nevertheless, I have created a debug log and post it here, although nothing unusual happened this time.
home-assistant_miele_2023-05-21T17-29-12.986Z.log
config_entry-miele-e0089fa20e4379770b39460eae7fa5e9.json.txt

Hi @AtrejaAlwinnen,
Can you check the reported state of appliance status sensor and of energy consumption sensor at the time of that spike?
The only assumption that this integration makes for water/energy sensors is to report 0 when appliance is in status off, on (idle), programmed, waiting to start. This because Miele API returns a null eco-feedback object in these cases and value 0 is used to reset the cycle of total increasing sensors on HA.
This has the side effect that, if you turn off the appliance and then you turn it on again while it is running a program, you get that spike. But you should get the same behaviour also on energy consumption sensor. If you set appliance in paused state, you should get normal behaviour instead.
Another possibility is that Miele API reports 0 for some unknown reason. In the past it happened that it randomly reported null eco-feedback object when the appliance was running, but it's a lot of time that I don't see this, so I think it has been fixed.
Andrea

Hi aturri,
the spikes also appear in the power consumption sensor. I hadn't noticed that until now.
When the dishwasher was started for the second time yesterday, when there was no spike in water consumption, there was also no spike in power consumption.
The sipkes occur exactly at the time when the appliance status changes from off to on.

Hi @AtrejaAlwinnen,
Can you provide the history graph of these sensors at the time of spike?

appliance status sensor
appliance switch
water/energy consumption

Like this:

So I can understand what happened 😁
Thanks
Andrea

Hi Andrea,
thanks for looking at this
here is a screenshot of the sensors:

Hi @AtrejaAlwinnen,
this confirms what I thought: the appliance has been turned off while it was running a program. Then, it has been turned on and its status went from "off" to "running". Normally, the appliance follows "off" -> "on" -> "programmed" -> "running".
I think that this strange behaviour is caused by the fact that when appliance is turned on again, on Miele API, the previous consumption is reported for a while (spike) and then it starts back from 0. If this is true, there is no way to filter out the spike on HA integration and it's a problem related to API.
In order to confirm this, you should try doing the following:

start a new program, let water come in and consume some energy
turn appliance off and get device diagnostic data log (n.1)
turn appliance on (we should see the spike)
get device diagnostic data log as the consumption goes to 0 (n.2)
get device diagnostic data log as the consumption increases (n.3)

This should prove that the consumption is back to 0 when appliance is restarted.
Andrea

I ran into a few problems while trying to follow the steps.

I started a program and waited a bit.
Disabled the Miele integration but could no longer download diagnostic data from the dishwasher.
Miele integration activated again but the dishwasher is not connected. It is also offline in the Miele app.

I'll try again tomorrow with the washing machine.
Many thanks for the help if the problem is that e.g. Home Assistant shouldn't be restarted while the dishwasher or washing machine is running, that's absolutely fine for me. :)

@AtrejaAlwinnen Why did you disable the integration?

No, "appliance" means the device. "Household appliances" is the collective term for dishwashers, washing machines etc.

So, the dishwasher is running again.
I was unable to reproduce the spike issue again. I've tried several times with both devices, but now everything works fine. Maybe it really had something to do with the fact that I restarted HA several times when setting up the sensors, which caused spikes in the sensor process.
Many thanks to everyone who took the time and made the effort to look into this.

This is a long-standing problem with the Miele API and/or devices. 😒
Up until today I have been using https://github.com/HomeAssistant-Mods/home-assistant-miele for getting my Miele devices into HA, but for some reason the integration has stopped working for me, so today I installed this one instead.
I initially implemented energy and water consumption sensors in the other integration. But as I seem to be consistently hit by this issue, I also spent a considerable amount of time debugging it in https://github.com/HomeAssistant-Mods/home-assistant-miele/pull/69. I even tried to contact Miele about it but never got any response. Back then, part of the problem was the API returning null from time to time while a program was running, but it's nice to hear that that problem might have been solved.
The fix in https://github.com/HomeAssistant-Mods/home-assistant-miele/pull/69 worked around the issues most of the time ~1.5 years ago, but I think some HA integration refactoring or Miele API change made it ineffective and it started causing problems more often again some time ago.
Two screenshots from today with two spikes for my dishwasher using this integration, the first one for energy and the second one for water consumption:

authors: AtrejaAlwinnen astrandb aturri mundschenk-at slovdahl

repo: astrandb/miele


text:
CI execute some job twice if a label added in PR

Describe the bug
Create a PR and add a label you can see couple jobs for Markdown-link-check
Version

Astro: [e.g. 0.6.0]
OS: [eg. Debian]

To Reproduce
Steps to reproduce the behavior:

Write the DAG  '...'
Create connection '....'
Run using  '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Closed by https://github.com/astronomer/astro-sdk/pull/928

authors: kaxil pankajastro

repo: astronomer/astro-sdk


text:
CI: Get list of the slowest 30 test durations

Uses https://docs.pytest.org/en/latest/how-to/usage.html#profiling-test-execution-duration to get a list of slowest 30 tests for which the durations is over 1.0s long.
This is a small change but will help identify if a test takes too long. Found a need to do that while working on https://github.com/astro-projects/astro/pull/367 and https://github.com/astro-projects/astro/pull/370

@kaxil, that's very interesting. I didn't know about this feature!
Even though we're using "pytest>=6.0", which should support this feature, the CI didn't seem particularly happy with it; any thoughts about it? It may relate to how pytest parses the config on the pyproject.toml.
nox > pytest tests/test_example_dags.py -k sqlite --cov=src --cov-report=xml --cov-branch
ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]
pytest: error: argument --durations: invalid int value: '30 --durations-min=1.0' (via addopts config)

nox > Command pytest tests/test_example_dags.py -k sqlite --cov=src --cov-report=xml --cov-branch failed with exit code 4

@tatiana fixed :)

That's great, @kaxil , thank you! :tada:
What is causing the current tests to fail? It seems they are passing in main, it would be great to address the root cause of the issue before merging this PR.

That's great, @kaxil , thank you! 🎉 What is causing the current tests to fail? It seems they are passing in main, it would be great to address the root cause of the issue before merging this PR.

It's the one I posted on Slack about:
E       sqlalchemy.exc.ProgrammingError: (snowflake.connector.errors.ProgrammingError) 090153 (22000): 01a46079-0604-a49f-0000-682108eb3a66: The result set size exceeded the max number of rows(10000) supported for SHOW statements. Use LIMIT option to limit result set to a smaller number.
E       [SQL: SHOW /* sqlalchemy:get_table_names */ TABLES IN astroflow_ci]
E       (Background on this error at: http://sqlalche.me/e/14/f405)

But I don't think we should hold this PR for that failure, it is completely unrelated, this PR barely does not impact the library just gives us the slowest test.

authors: kaxil tatiana


text:
Field Still Show Even Have Visible = false

Expected Behavior

Actual Behavior

Steps to Reproduce the Problem

Add derive macro #[graphql(visible = false)] in the field

Specifications

Version: 3.0.26
Platform: Ubuntu 21
Subsystem:

The visible property only hides this field from introspection, but does not affect querying it.

Thank you for the clarification

repo: async-graphql/async-graphql


text:
Deadlock with recursive task::block_on

When calling task::block_on recursively, the executor seems to dead-lock even when the recursion depth is much smaller than num cpus.
Sample code (deadlocks on a 8-cpu machine):
#[async_std::test]
async fn test_async_deadlock() {
    use std::future::Future;
    use futures::FutureExt;
    fn nth(n: usize) -> impl Future<Output=usize> + Send {
        async move {
            async_std::task::block_on(async move {

                if n == 0 {
                    0
                } else {
                    let fut = async_std::task::spawn(nth(n-1)).boxed();
                    fut.await + 1
                }

            })
        }
    }
    let input = 2;
    assert_eq!(nth(input).await, input);
}

It seems that the test should deadlock when input >= num_cpus, but even when input=2, on a 8-cpu machine this seems to deadlock.  Is this expected behaviour?  Interestingly, input = 1 (which does involve a recursive call) does not deadlock.  If the block_on is removed, the test indeed passes for large input values.
Aside:  it would be great if the executor could detect block_on called within the pool processor threads, and spawn more threads.  The block_on could be considered an explicit hint that the particular worker is probably going to block.

I believe this should work with the new scheduler: https://github.com/async-rs/async-std/pull/631
Can you try running this program again with async-std from the new-scheduler branch?

@stjepang Absolutely!  Works in the new-scheduler branch.

Still there is some problem with recursive block_on.
It says in the document that

Calling this function is similar to spawning a thread and immediately joining it, except an asynchronous task will be spawned.

But it is not true.
use async_std::{stream, sync, task};

use futures::select;
use futures::{FutureExt, StreamExt};

use std::time::Duration;

fn main() {
    let (close_tx, close_rx) = sync::channel::<()>(1);
    task::spawn(async move {
        task::sleep(Duration::from_secs(1)).await;
        let _tx = close_tx;
        println!("close_tx should be dropped");
    });
    task::block_on(async move {
        let mut close_rx = close_rx.fuse();
        select! {
            _ = work().fuse() => (),
            _ = close_rx.next() => (),
        }
    });
}

async fn work() {
    let interval1 = stream::interval(Duration::from_millis(3000));
    let interval2 = stream::interval(Duration::from_millis(2000));
    // task::block_on(async move {
    //     let mut interval1 = interval1.fuse();
    //     let mut interval2 = interval2.fuse();
    //     loop {
    //         select! {
    //             _ = interval1.next() => {
    //                 println!("interval1");
    //             },
    //             _ = interval2.next() => {
    //                 println!("interval2");
    //             },
    //         }
    //     }
    // });
    task::spawn(async move {
        let mut interval1 = interval1.fuse();
        let mut interval2 = interval2.fuse();
        loop {
            select! {
                _ = interval1.next() => {
                    println!("interval1");
                },
                _ = interval2.next() => {
                    println!("interval2");
                },
            }
        }
    })
    .await;
}

In the code above, if we replace the spawn-then-await with block_on, the program will never exit, which is true for both the new scheduler and the old one.
In my use case, I have to use block_on because the Future I am dealing with is non-Send.

@kylerky I think you're example could be simplified as:
#[async_std::test]
async fn block_on() {
    use async_std::{task, future::{timeout, pending}};
    use std::time::Duration;
    task::block_on(async {
        let _ = timeout(
            Duration::from_secs(1),
            async {
                task::block_on(pending::<()>())
            }
        ).await;
    });
}

The reason it never finishes it because the inner block_on is stuck on a never ending Task.  I believe the equivalent threading-based code is:
std::thread::spawn(|| {
    loop {}
}).join();

Once the above statement runs, both the spawned thread, and the parent thread can't be stopped unless the whole process itself aborts or exits.  See how to terminate or suspend a rust thread.  As suggested in the link, you could use (async variant of) channels or other communication to signal the timeout to the inner task, to make it exit.
An issue with the current scheduler is that it uses a slot as an optimization.  This does not seem to play nicely with block_on.  When spawning from within a block_on construct, the spawned Task gets placed inside this slot, and it can never be stolen by other processors (i.e. stealers) hence creating deadlocks.

@rmanoka Thanks for your explanation.
I find it a surprise that tasks spawned by block_on cannot be stolen because I just assume that every tasks can. I think this should at least be documented.
Also, the problem is that block_on, I think, is the only way to spawn non-Send futures in async-std. If it is used in a library, we may easily end up with a recursion like the ones above.

Since block_on accepts futures that are not Send,  they are anyway not safe to be off-loaded to other threads, and hence are never stolen by the other processing threads.  I meant that even spawn from within block_on do not get stolen;  it doesn't happen in the example you posted though.

By being stolen, I do no mean offloading the task to a different thread.
In the spawn version, when one of the intervals goes to sleep, the control yields to the the executor and it can select to run the close_rx or work, where it can select between the two intervals.
However, in the recursive block_on version, the executor will only select between the two intervals. So I understand this as the inner block_on cannot be stolen and close_rx never gets a chance to run.

@rmanoka

An issue with the current scheduler is that it uses a slot as an optimization. This does not seem to play nicely with block_on. When spawning from within a block_on construct, the spawned Task gets placed inside this slot, and it can never be stolen by other processors (i.e. stealers) hence creating deadlocks.

Is this still true?
My mental model is that async_std::task::spawn will put any spawned task into some big happy pool of tasks that are handled by the executor threads.
But if I understand what you're saying correctly, spawn happening from within a async_std::task::block_on are special and are effectively "orphaned" if they are not finished by the time block_on exits.
It seems like a quite severe restriction that should at the very least be clearly documented.

Is this still true?

It's not true anymore. More info: https://github.com/stjepang/smol/issues/177#issuecomment-649035605

@algesten In the latest release (1.6.3), async-std no longer accepts the above example and panics if spawn is called inside block_on.  However, using either smol::block_on or futures_lite::block_on does work (for input smaller than #cores).

@rmanoka
on 1.6.4 it doesn't panic anymore, but it does deadlock once again with block_on inside spawn, when i have 1 core.
smol on the other hand works perfectly on one cpu with same block_on/spawn/block_on recursion, even with 4 smol threads. perhaps it would lock up on deeper recursion with a bunch of heavy tasks, i dunno.
moreover, smol has an unbounded sync channel with try_send, so you don't even need to call block_on inside other tasks, because you can just communicate from sync context into async normally.
i'm jumping async_std for smol, personally.

@installgentoo This is fantastic!  The use-case for block_on (possibly inside a task) comes from the async-scoped crate, where unfortunately, the only safe abstraction we could think of was to block_on a particular future (and the call might be happening inside a task).  I think the deadlock for arbitrary depths of recursion may unfortunately not be avoidable unless the executor dynamically spawns more worker threads.
I'm closing this as the original issue has been solved.  Shout out to the authors of this and the smol crate for working on this!

@rmanoka By the way, smol::Executor can now spawn non-'static futures, while having a safe and sound API: https://docs.rs/smol/1.2.1/smol/struct.Executor.html#method.spawn

@stjepang this is awesome!  Just clarifying: to spawn a Future: 'a , I'll need to create a new Executor<'a>, correct?  The motivation behind async-scoped was to provide something like crossbeam scope, but for tasks and hopefully not spawning new threads for each task.

Yes, exactly - you can think of Executor<'a> as a scope that is allowed to borrow anything with lifetime 'a. Note that Executor<'a> is something you need to "drive" yourself with run() or tick() - it won't run tasks by itself. There are no threads involved unless you spawn your own threads and then call run() on them.
This design makes it possible to do lots of interesting things - here's a scoped executor with task priorities:
https://github.com/stjepang/async-executor/blob/master/examples/priority.rs

That is a very elegant abstraction!

authors: algesten installgentoo kylerky rmanoka stjepang

repo: async-rs/async-std


text:
Rename stream_extend to extend

I've renamed this method to be more consistent with the standard library and re-exported the Extend trait in our prelude.

@yoshuawuyts How do you feel about these ideas (all of them are independent of each other)?

We don't put our Extend into the prelude so that synchronous foo.extend(bar); still works.

Instead of doing stream::Extend::extend(&mut foo, bar).await, first import with use async_std::stream::Extend::extend and then do extend(&mut foo, bar).await.

Or, perhaps even re-export a convenience method called extend into the stream module so that one can do stream::extend(&mut foo, bar).await.

Here's an idea: what if both std::iter::extend() and async_std::stream::extend() existed?
That'd be nice and would make sync/async versions convenient and symmetrical at the same time :)
Let's discuss this offline one more time (briefly) and make a final decision. Thanks for clarifying motivation for this change last time we discussed it, that was helpful!


text:
Show how to generate Java data models that overwrite hashCode method

What to solve
Depending on what you want to use the data models for, you might stumble upon a scenario where you want the models to overwrite hashCode method.
This can be done by including the preset JAVA_COMMON_PRESET and providing the option hashCode. By default, if no options are present, all support functions are included.
Use the following code in the example:
generator = new JavaGenerator({
  presets: [
    {
      preset: JAVA_COMMON_PRESET,
      options: {
        equal: false,
        hashCode: true,
        classToString: false
      }
    }
  ]
});

Duplicate the folder https://github.com/asyncapi/modelina/tree/master/examples/TEMPLATE and rename it to java-generate-hashcode. Update any relevant documentation.

Some folks want more specific tasks to complete, or use this if you get stuck - CLICK ME

This issue is specially designed for first-time contributors, that want to contribute their very first code. If you are accustomed to how to solve issues in AsyncAPI, you can skip some of the steps.
What to know before getting started
Before actually getting started with solving the issue, there are a few things that need to be set up:

Make sure you familiarize yourself with our code-of-conduct and contributor guidelines
We work on forks of repositories and branches in forks, if you are unsure how to set this up you can follow the guide on our git-workflow setup.

Feel free to reach out either here in the issue, or on slack under #tooling if you have any questions or are stuck, we will gladly help.
Getting started
This is a task list, that you copy into your PR description to ensure everything is included, this list walks you through each step as to how to solve this issue. It assumes that you have already set up your fork and branch and are ready to commit code.

[ ] Duplicate the folder https://github.com/asyncapi/modelina/tree/master/examples/TEMPLATE and rename it to java-generate-hashcode. This will give you a good base to start out with.
[ ] Adapt the documentation about the feature and ensure the example are linked correctly.

The docs that need to change are the following: docs/languages/Java.md#include-hashcode-function-for-the-class
The documentation must reference an actual example that is tested and contain no code itself. It is because the docs will inevitably become desynchronized and display incorrect code.

[ ] Adapt the examples overview to include your new example.
[ ] Now it is time to adapt the test code (in examples/java-generate-hashcode/index.spec.ts) and the implementation (in examples/java-generate-hashcode/index.ts).
[ ] Make sure that the test succeeds, by standing in the new example folder and execute npm run test.
[ ] Make sure that there are no linting errors, by standing in the root folder and execute npm run lint.
[ ] Create your PR, by selecting your branch that should be merged with the master branch - https://github.com/asyncapi/modelina/compare
[ ] It is good practice to double-check your PR before requesting a review from someone else, the same way you read an assignment before handing it in.

Do you have any examples I can check for reference?
We have currently 4 example documentations that you can look for guidance on how to achieve the desired output:

How to add logging to the library
Generate models from AsyncAPI documents
Generate models from JSON Schema draft 7 documents
Generate an interface instead of class

Happy Hacktoberfest, everyone! ✨✨ Feel free to reach out to me for any questions you may have about adding documentation on these open issues. 🙂
Tag me in your AsyncAPI Doc PRs 📄, my GitHub handle is /alequetzalli 🐙.

authors: alequetzalli jonaslagoni

repo: asyncapi/modelina


text:
How to make a relase jar

Hello
i've succefully compiled https://github.com/ata4/disunity
with the command: mvn packageand i got in the 4 folders of the project the compiled jars but no one if them is runnable.
How do i make the relase jar?

I don't have a build script for that yet. The fat jar "disunity-dist-0.4.0-SNAPSHOT.jar" contains everything that is required. The GUI, for example, can be started with java -cp disunity-dist-0.4.0-SNAPSHOT.jar info.ata4.disunity.gui.DisUnityGui. I guess I'll update the old launcher scripts to run these commands.

ok thanks :)

How to run a command line interface?
I tried with java -cp disunity-dist-0.4.0-SNAPSHOT.jar info.ata4.disunity.cli.DisUnityCli but I get following error:
Error: Could not find or load main class info.ata4.disunity.cli.DisUnityCli

I met the same problem with @mersadk
$ cd ~/Github/disunity
$ mvn package
$ java -cp disunity-dist-0.4.0-SNAPSHOT.jar info.ata4.disunity.gui.DisUnityGui

Error: Could not find or load main class info.ata4.disunity.cli.DisUnityCli

$ java -version
java version "1.8.0_66"
Java(TM) SE Runtime Environment (build 1.8.0_66-b17)
Java HotSpot(TM) 64-Bit Server VM (build 25.66-b17, mixed mode)
$ mvn -v
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T00:41:47+08:00)
Maven home: /usr/local/Cellar/maven/3.3.9/libexec
Java version: 1.8.0_66, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_66.jdk/Contents/Home/jre
Default locale: zh_CN, platform encoding: UTF-8
OS name: "mac os x", version: "10.11.2", arch: "x86_64", family: "mac"

authors: ata4 luckcolors mersadk yuyangame

license: unlicense


text:
✨ [Feature request]: Add the number badge to the comment icon

Is your feature request related to a problem? Please describe.
Currently, each of the plays has a way to provide and view comments

It will be great if the icon indicates the number of comments a play has.
Describe the solution you'd like
The solution is to use the GitHub GraphQL API to fetch the number of discussions for a discussion id and show as a badge. The JSX part of the code is already there but commented.
Describe alternatives you've considered
If we can't show the number, let us at least indicate if the play has a comment or not with a visual clue.
Additional context
Read more about the comment system implementation from here: https://blog.greenroots.info/comment-system-using-react-and-github-discussions

@atapas how the number of comments should be displayed?
As on hovering the icon or to the side of icon (this will look odd in my opinion).

@atapas how the number of comments should be displayed?
As on hovering the icon or to the side of icon (this will look odd in my opinion).

That part of the code of showing the number is already in place. You can uncomment it in the jsx file and see. It appears like a badge on the icon.
Next, part of the issue, we need to figure out how to get the comment count for a play.

I am pretty new to React, but I think I can work on this issue, can someone assign it to me?

authors: ashutoshdhande atapas k3yss

repo: atapas/react-play


text:
feat: :sparkles: add pwa support

Description
Add PWA support with next-pwa being install
Fixes # (issue)
Closes #39
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Run lighthouse and check if the requirements are checked for PWA
Checklist:

[ ] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@niteshseram
Thanks a lot for taking the issue and making the app better. Please feel free to pick up more, contribute more. I wish you a great #Hactoberfest ahead. You will be added to the contribution list right after we merge this PR. Don't forget to share about your contribution publicly and provide your support with a star ⭐.
Great work 🔥 !!!!

authors: atapas niteshseram

repo: atapas/webapis-playground


text:
🛑 Wedding HTTPS is down

In 029b29b, Wedding HTTPS ($WEDDINGHTTPS) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Wedding HTTPS is back up in db74f4c.

repo: atatkin/milos-uptime


text:
🛑 Wedding HTTPS is down

In b3d9873, Wedding HTTPS ($WEDDINGHTTPS) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Wedding HTTPS is back up in 4c476d8.


text:
🛑 Wedding HTTPS is down

In 46b0e5e, Wedding HTTPS ($WEDDINGHTTPS) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Wedding HTTPS is back up in 7c9e9ab.


text:
🛑 Wedding HTTPS is down

In 37ec79f, Wedding HTTPS ($WEDDINGHTTPS) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Wedding HTTPS is back up in e94c00a.


text:
🛑 Wedding HTTPS is down

In 0f2b56e, Wedding HTTPS ($WEDDINGHTTPS) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Wedding HTTPS is back up in cb910a0.


text:
🛑 Wedding HTTPS is down

In 03ed53c, Wedding HTTPS ($WEDDINGHTTPS) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Wedding HTTPS is back up in 36ac101.


text:
🛑 Wedding HTTPS is down

In a53d5ee, Wedding HTTPS ($WEDDINGHTTPS) was down:

HTTP code: 0
Response time: 0 ms

Resolved: Wedding HTTPS is back up in 928efee.


text:
Bamboo agent: add additional volumes and mounts

Pull request description
Provides support for additional volume and volume mounts for bamboo-agent as described in issue https://github.com/atlassian/data-center-helm-charts/issues/530
Checklist

[ ] I have added unit tests
[ ] I have applied the change to all applicable products
[ ] The E2E test has passed (use e2e label)
[ ] (Atlassian only) Internal Bamboo CI is passing

@timmy59100 can you also sign CLA please?

I put the wrong email in the CLA, i requested a change from the team but didn't hear anything.

@timmy59100 we're planning a release soon and I'll be happy to include merge your PR so that changes make it to the new release. Were you able to sort out CLA issues?

@bianchi2 No, I didn't hear from the team. Should I make a new pull request with the correct email?

@timmy59100 yes, please. Also, please make sure you use the latest main branch in your fork. Thanks

repo: atlassian/data-center-helm-charts


text:
Add analyzer workflow and fix analyzer issues

Overview
solve https://github.com/atn832/cloud_firestore_mocks/issues/117
Review Points

I separted alanyzer workflow from unit test workflow, because I want to show the workflow commit status besides unit tests.
follow https://pub.dev/packages/pedantic analysis_options which has been already commited.

CI has passed.
I would be graceful if you would review.

Thank you so much for adding all those workflows. They will make PRs cleaner and easier to review.


text:
Menu dropdowns in Themes panel aren't aligned

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
The drop downs to choose the UI and Syntax themes in the Themes panel in Settings are misaligned when the window is below a certain width. See attached screenshots.
Normal alignment

Wrong alignment

Steps to Reproduce

Open the Themes panel in Settings.
Shrink the window to less than approximately 1260 pixels wide.

Reproduces how often: [What percentage of the time does it reproduce?]
Every time.
Versions
Atom 1.20.0
Electron 1.6.9
Chrome 56.0.2924.87
Node 7.4.0
MacOS 10.12.6

Yikes!  @andrewmccullough could you please reopen this on the atom/settings-view repo?  Thanks so much :bow:.

repo: atom/atom


text:
Uncaught Error: EPERM: operation not permitted, lstat 'D:/mocha\extensions'

Reproduction

Move/drag a folder into another.

Notes

This may be an issue with my disk.

Atom: 1.32.0 x64
Electron: 2.0.9
OS: Microsoft Windows 10 Pro
Thrown From: Atom Core
Stack Trace
Uncaught Error: EPERM: operation not permitted, lstat 'D:\mocha\extensions'
At fs.js:1661

Error: EPERM: operation not permitted, lstat 'D:\mocha\extensions'
    at Proxy.realpathSync (fs.js:1661:15)
    at Proxy.fs.realpathSync (ELECTRON_ASAR.js:336:29)
    at TreeView.t.exports.TreeView.moveEntry (~/AppData/Local/atom/app-1.32.0/resources/app/static/<embedded>:14:916471)
    at TreeView.t.exports.TreeView.onDrop (~/AppData/Local/atom/app-1.32.0/resources/app/static/<embedded>:14:922260)
    at HTMLDivElement.<anonymous> (~/AppData/Local/atom/app-1.32.0/resources/app/static/<embedded>:14:896171)

Commands
     -5:19.5.0 core:confirm (input.hidden-input)
  2x -5:11.3.0 core:save (input.hidden-input)
     -1:01.8.0 core:move-left (input.hidden-input)
  3x -1:01.3.0 core:backspace (input.hidden-input)
     -0:58.9.0 core:save (input.hidden-input)
     -0:54.1.0 core:move-left (input.hidden-input)
     -0:53.6.0 editor:newline (input.hidden-input)
  4x -0:53 core:backspace (input.hidden-input)
 17x -0:47.8.0 core:move-left (input.hidden-input)
     -0:46.4.0 core:move-right (input.hidden-input)
     -0:46.1.0 core:backspace (input.hidden-input)
     -0:44.9.0 core:save (input.hidden-input)
     -0:43.8.0 core:backspace (input.hidden-input)
 16x -0:43.3.0 core:move-right (input.hidden-input)
     -0:41.7.0 core:backspace (input.hidden-input)
     -0:40.9.0 core:save (input.hidden-input)

Non-Core Packages
platformio-ide-terminal 2.8.4

Seems like I deleted the folder in the terminal, but atom still had it on the list.

Thanks for contributing!
We noticed that based on the stack trace, this looks like a duplicate of https://github.com/atom/tree-view/issues/1282 so you can subscribe there for updates if you'd like.

Seems like I deleted the folder in the terminal, but atom still had it on the list.

Thanks for the detail :+1:

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


text:
Add an event for text backspace and deletion

Summary
Add a new event for text backspaces and deletions. Something like TextEditor::onWill/DidBackspace/Delete().
Motivation
Events exist for inserting text, but not for deleting text. Packages that need to act when text is deleted need to resort to methods such as monkey-patching the delete and backspace methods.
Describe alternatives you've considered
The new event could be TextEditor::onWill/DidDelete(backspace) rather than having two separate events for backspace and delete.
Additional context
bracket-matcher currently has to monkey-patch backspace: https://github.com/atom/bracket-matcher/blob/8a3bd1e347b02d8ad0c30ffa1a80836d9625a234/lib/bracket-matcher.js#L19

Hey, we noticed this was related to https://github.com/atom/atom/issues/18950 ... seems like this should be one RFC that explains the general theory?

Sure.


text:
Error building atom on Arch Linux

[connexo@archgott atom]$ script/build
Node: v0.12.0
npm: v2.5.1
Installing build modules...
child_process: customFds option is deprecated, use stdio instead.
child_process: customFds option is deprecated, use stdio instead.
child_process: customFds option is deprecated, use stdio instead.
Installing apm...
child_process: customFds option is deprecated, use stdio instead.
child_process: customFds option is deprecated, use stdio instead.
child_process: customFds option is deprecated, use stdio instead.
module.js:356
Module._extensions[extension](this, filename);
^
Error: /home/connexo/packages/atom/apm/node_modules/atom-package-manager/node_modules/git-utils/build/Release/git.node: undefined symbol: node_module_register
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Object. (/home/connexo/packages/atom/apm/node_modules/atom-package-manager/node_modules/git-utils/lib/git.js:8:16)
at Object. (/home/connexo/packages/atom/apm/node_modules/atom-package-manager/node_modules/git-utils/lib/git.js:359:4)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)

See https://github.com/atom/atom/issues/3385

The page you suggested tells me to do script/clean before script/build. I did, with the same resulting error.

@franktopel Have you tried using the required version of node (v0.10.x):
https://github.com/atom/atom/blob/master/docs/build-instructions/linux.md#requirements

Same problem on Ubuntu 14.10 with io.js 1.2

@amiuhle what commit did you try and build?

Tried on both v0.180.0 and v0.181.0

authors: amiuhle franktopel izuzak kevinsawicki


text:
Tooltip should fade on keybaord event 17431

Description of the Change
Fix #17431 by adding an event listener that listens for keydown events and hides a tooltip when a user types.
Alternate Designs

Initially I had attached the event listener in the tooltip file instead of the tooltip manager, but I placed in the latter because that's where the hiding tooltips on resized lived as well.

Why Should This Be In Core?
Because it fixes a problem in core and most default editors have this feature.
Benefits
It fixes an issue where users may want to see the workspace they're typing in, but a tooltip is hiding it.
Possible Drawbacks
It adds an additional event listener for each tooltip.
Verification Process
I modified the existing tooltip-manager spec to include a new test for this feature, ran the test suite, and also manually tested it by reproducing the steps listed in #17431.
Applicable Issues
#17431

Thanks very much for the awesome contribution! :tada:

authors: cacheflow lee-dohm


text:
Add zh-tw translation of docs-translations/zh-TW/tutorial/online-offline-events.md

As title.
Thanks.

:sparkles: Thanks!

authors: jlord lockys

repo: atom/electron


text:
Add initial config schema

PR to add a config schema that will be used to make this theme adjustable once https://github.com/atom/atom/pull/4153 lands.
@simurai What do you think the options should be saturation and contrast?
Closes #5

Awesome! I added saturation and contrast as <select>s:

One day we could replace them with input range sliders.
Or maybe just have a single color picker that does everything at once. Currently saturation and brightness gets ignored and only the hue is used.

Do the settings colors actually update for you? It looks like packages that use the theme's ui-variables.less keep the default color that is originally defined here: https://github.com/atom/one-dark-ui/blob/master/styles/ui-variables.less#L6 and not the one changed in the settings.

The buttons and the config menu works because it gets overridden from the theme. I guess we could override the whole settings in the theme, but would be impossible to do for all community packages. Could the packages be reloaded with the new color too, or is that problematic (performance or so)?

Pretty cool stuff. I've been having the same issues simurai describes (in isotope-hi), wondered why some screens wouldn't update with syntax theme changes. I think all stylesheets need to be recompiled with changes to either syntax-variables or ui-variables because package are free to use both and it gets weird otherwise.
Super awesome stuff guys ✨

It looks like packages that use the theme's ui-variables.less keep the default color

Yeah, noticing this too, looking into it today.

Closing this out, see https://github.com/atom/atom/pull/4153 for more details.

authors: braver kevinsawicki simurai

repo: atom/one-dark-ui


text:
Move to end of file?

I'm trying to use the normal vim keymap to jump to the end of file. But couldn't find it. g g is mapped to "move to the start of file", and G is mapped to "move to beginning of line". But in vim, G is used to "jump to the end of file" ([Moving around] (http://vim.wikia.com/wiki/Moving_around)). I also didn't find a MoveToEndOfFile method like MoveToStartOfFile in motions/general-motions.coffee that I can use to replace the mapping in vim-mode.cson.  I'm not familiar with CoffeeScript, any pointer in how to implement the move to end of file is appreciated!! (Currently I'm using command-down key).
Thanks!

@stormspirit By default G should move to the end of the file. What are you seeing it do? If it isn't working, could you share the output of the keybinding-resolver (Key Binding Resolver: Toggle from the command palette) when you type that key?

This is the screenshot, it looks like it recognized it as lower-case 'g' instead of 'G' (The caps lock is on, I made sure that). Also, I see that caps lock is recognized first ("Key Binding Resolver: capslock").

The behavior is that pressing 'G' does nothing, (because it thinks it's a 'g' and waiting for next key?)

Does G work when pressing shift-g?  It's just capslock that causes it to go wrong?

shift-g works!!

@stormspirit, how did you get shift-g to work?  I have this in my vim-mode.cson file:
'g g': 'vim-mode:move-to-start-of-file'
But there is no key mapping for 'G'. In fact, my key binding resolver comes up empty for both 'g' and 'shift-G'.

As stated in the README, this package is no longer maintained and is deprecated. We recommend that people use the vim-mode-plus package instead. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!

authors: bronson lee-dohm maxbrunsfeld signothefish stormspirit

repo: atom/vim-mode


text:
Switch over to LittleFS

SPIFFS seems to be a bit broken (doesn't always seem to be able to save data).
Let's try switching to LittleFS: https://github.com/joltwallet/esp_littlefs

This seems to be a lot more complicated than I initially thought. There isn't official support for LittleFS in the ESP32 and platformio doesn't have out of the box support for building LittleFS filesystems when using the ESP32.

Hi Chris. There is official support for LittleFS, unfortunately in Core 2.0.0 which is not availble right now directly in pio. You can do some workarounds. For example:

You can use Lorol's LITTLEFS library (Library name has changed in the Core for ESP8266 compatibility)
You can use small patch to filesystem build tools. The patch consists of two steps: one is simple python script:

Import("env")
env.Replace( MKSPIFFSTOOL=env.get("PROJECT_DIR") + '/tools/mklittlefs/mklittlefs' )

the script is named littlefsbuilder.py, and I'm using it like this (in the platformio.ini):
extra_scripts =
  ./tools/littlefsbuilder/littlefsbuilder.py

You have to install mklittlefs tool into tools/mklittlefs/ subdirectory.
You can give it a try.

Tempted to wait on this one until platformio has official support - I'm a bit worried about how to make it work cross platform.


text:
Upload mw sandbox audio

Code-review checklist

Documentation

[ ] Interfaces describe how other programmers would use them.
[ ] Code that is not obvious has documentation describing why
that code is the way it is.

Addresses pivotal tracker story #128146381

Changes moveable words sandbox 'check answer' text to 'save file'

Sends most recently recorded audio file back to qbank

Looks fine.

repo: atomicjolt/OpenAssessmentsClient


text:
Switch to JS configs

These are recommended now. Also, prettier can format them with the extension list (it seems .rc files are weird for that) + format .ts extension

I was gonna propose that :)
You can also change .prettierc to .prettierrc.json

authors: KubaJastrz atomiks


text:
Default to local deployment, not PCF or K8s

this is the fastest; it will let people ttry things the most quickly.
tell them how ot try PCF (theirs) or K8s (ours) as well.
cc @johnsonr because we ttalked abou thtis

can you tell thtere is somehting wrong witth the t key on my laptop?

duplicate of #163
Too bad Slack wasn't working for me or we'd have created htis tthere wiht Atomist and not had the duplication problem

frustrating: I copied the event out of the sdm log, and pasted it into a test. Tthe test behaves as desired.

repo: atomist/github-sdm


text:
Improved logging on stm32 platform

Introduces configureable logging with maximum log level, optional colorization by level, and optional source file and line numers with log messages (always on for ERROR messages), as described in stm32 section of Build Instructions.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

On closer examination of the other platforms, I believe all of the platforms except esp32 could benefit from making this part of libAtomVM instead of just for the stm32 port, at least the rp2040 and generic_unix ports. I would be more that happy to modify the PR if that sounds like something we are interested in.

repo: atomvm/AtomVM


text:
at_c: Breaking Changes Tracker

### Breaking Changes to make
- [ ] https://github.com/atsign-foundation/at_c/issues/154
- [ ] https://github.com/atsign-foundation/at_c/issues/140
- [ ] https://github.com/atsign-foundation/at_c/issues/225

Added #225

reopening this issue to track:

authors: JeremyTubongbanua XavierChanth


text:
fix: add sync unit test cases

- What I did

Contains the sync service unit tests

- How I did it

Implemented unit tests to verify the sync service functionality

- How to verify it

The unit tests should cover the functionality of sync service

The tests with the commented-out code are waiting for those features/behaviour to be implemented on the client side and will fail with the current client behaviour. When the client code matches the expected behaviour we can enable those tests, as per my knowledge these features are being worked on currently.
Reg the invalid-key-based tests, our Keystore is straight-out rejecting those keys making it impossible to insert those keys. One approach worth trying would be manually opening the hive boxes, inserting the keys and then asserting the conditions; which would bypass any validations. Will try working this approach out, or any other approach that I can think of or find.

authors: kalluriramkumar srieteja


text:
Streaming

Describe the solution you'd like

Ability for one atSign to stream encrypted info to one other atSign
(later) ability to stream encrypted data to multiple other atSigns

Hey @cconstab and @nickelskevin please can you ad in a more detailed set of requirements / constraints here please?

Moving to PR48. Invested 3SP in PR47 on analysis, presentation and review.

I wanted to see what we have now with the Murali demo.. But will detail the needs also..

I wanted to see what we have now with the Murali demo.. But will detail the needs also..

@cconstab
Please use this branch of at client
https://github.com/atsign-foundation/at_client_sdk/tree/stream_transfer_issue
at_client/test/samples/stream_receiver.dart
at_client/test/samples/stream_sender.dart
with server branch
https://github.com/atsign-foundation/at_server/tree/stream_transfer_issue

Thank you!

Going to reduce the estimate here to 5SP as that looks like the most we can invest during PR51 given our focus on the core encryption projects (secure element support, and future-proofing)

@murali-shris
The stream verb was originally targeted at providing a stream/socket connection from one atsign to another. As implemented I think things got confused with files. This is probably due to work we had at the time with atMospherePro.
Could I use what we have here for a socket at each end ? And a "file" that never ends ?
I suspect not
The same mechanism is probably fine but socket and one end to a socket the other was my ultimate goal... This could also be a stream from an atSign to another..
Lets discuss..
@nickelskevin please add comments too if you have any to add..

@cconstab will come with a diagram/requirements and follow up arch call is needed

https://docs.google.com/presentation/d/1V3-xLj8ve5eStjrDMxBGUp3LhyKanmjr6aInmhDDoms/edit?pli=1#slide=id.g112867c3eab_0_0

Some demo code is now in Colin Snippets (atCompany repo) Soon to be opensourced..

Current limitations in stream verb:

Supports only streaming files
If the file is large, memory footprint on client will be huge since we are reading entire file and passing to stream
Secondary server is used as a relay server to transmit data from sender client to receiver client

To explore:

Support different stream types video ,audio, text, file etc.,
if there is possibility to connect sender socket to receiver socket directly, explore options
Read on webRTC, STUN, TURN, ICE concepts
Refer implementation sshrvd on how it relays data between client to device. Encrypt/decrypt the stream and not entire file content in one go.

authors: cconstab gkc murali-shris


text:
Stream resume

- What I did
- How I did it
- How to verify it
- Description for the changelog

closing this PR since a new PR is raised to trunk


text:
[Feat] Add API support for core features

Refactor API structure
Add API support for existing CLI flags
Add Keystone token and RBAC

What is the purpose of this pull request?: To enhance the Armada API and introduce features already present in the CLI.
What issue does this pull request address?: Fixes #54
Notes for reviewers to consider:
Specific reviewers for pull request: @gardlt @theyer @sh8121att

This is a good start just some nit pick.

repo: att-comdev/armada


text:
打包时插件有问题

A problem occurred configuring project ':RNDeviceInfo'.

Could not resolve all dependencies for configuration ':RNDeviceInfo:_debugCompile'.
Could not find com.google.android.gms:play-services-gcm:8.3.0.
Searched in the following locations:
file:/C:/Users/Administrator/.m2/repository/com/google/android/gms/play-services-gcm/8.3.0/play-services-gcm-8.3.0.pom
file:/C:/Users/Administrator/.m2/repository/com/google/android/gms/play-services-gcm/8.3.0/play-services-gcm-8.3.0.jar
https://jcenter.bintray.com/com/google/android/gms/play-services-gcm/8.3.0/play-services-gcm-8.3.0.pom
https://jcenter.bintray.com/com/google/android/gms/play-services-gcm/8.3.0/play-services-gcm-8.3.0.jar
file:/E:/works/rn/gitphoto/reading/node_modules/node_modules/react-native/android/com/google/android/gms/play-services-gcm/8.3.0/play-services-gcm-8.3.0.pom
file:/E:/works/rn/gitphoto/reading/node_modules/node_modules/react-native/android/com/google/android/gms/play-services-gcm/8.3.0/play-services-gcm-8.3.0.jar
file:/D:/codes/android-sdk-windows/extras/android/m2repository/com/google/android/gms/play-services-gcm/8.3.0/play-services-gcm-8.3.0.pom
file:/D:/codes/android-sdk-windows/extras/android/m2repository/com/google/android/gms/play-services-gcm/8.3.0/play-services-gcm-8.3.0.jar
Required by:
reading:RNDeviceInfo:unspecified
原因在此
https://github.com/rebeccahughes/react-native-device-info/issues/78

额，我并没有用gms……我打包都是正常的，没遇到过这个错误

@Richard-Cao 你是用苹果打包吗？

是的，mac

authors: Richard-Cao codeHui

repo: attentiveness/reading


text:
Improve Ruby implementations

Updates the ruby implementations for performance and more idiomatic code, while keeping the sprit of the C translation intact. Sudoku especially improves under YJIT on cruby 3.3.

Sudoku indeed gets much faster, but I have to revert matmul as the new version is slower.

New matmul version up at #62

authors: attractivechaos nixme


text:
Combined ready and data arrays in seg_queue

This combines the ready block and the data block in seq queue. Combining these has some good cache properties -

Loads of the ready variable in pull will likely read the data into the cache, and same with loads of the data in push.
Writes to the data and ready variable may well be combined.
Elements are farther apart in the cache, so writes from pushers won't invalidate reads from pullers as much.

In my basic (and somewhat variable) tests, this saw performance gains of:

mpmc: 5-15% increase
spmc: 0-5% increase
spsc: 15-35% increase

Also, this version is generally more consistent performance-wise probably due to less cache thrashing.

Sorry for the slow review -- this looks good! I'm happy to merge after a rebase.

Just rebased!

Lovely, and nice perf wins. Thanks again for your help with the library!

authors: aturon schets

repo: aturon/crossbeam


text:
irreps analysis with the NAC option

Dear Dr. Togo
I'm using phonopy together with abinit to calculate phonon dispersions. However, there seem to be two problems.

With the --nac option, the mesh and band calculations produce quite different phonon frequencies at the gamma point. Can I know why are they different?
The gamma-point phonon frequencies in the irreps analysis output file is not changing with the the --nac option and always stay with the zero Born effective charge values. Then how to analyze the raman/infrared activity once the --nac option is included?
Thanks a lot for your help!

Wishes
Shang

You can use --nac and --q-direction simultaneously to break symmetry at Gamma.

I will close this issue.

Dear Professor Togo,
Can I ask a question related to this issue? By including --nac and --q-direction command line options as you suggested above, I did indeed manage to get LO-TO splitting in both band.yaml and irreps.yaml files, but in mesh.yaml, for each irreducible representation, the LO mode is still degenerate with the two TO modes at gamma point. I think this leads to incorrect projected density of states. Can you please let me know how I can handle this issue?
Many thanks,
Wei

It is the effect at non-zero q-point but at limit of q->0. So I have no idea how to include at Gamma point for mesh case as implementation.

authors: atztogo pastle weixie4

repo: atztogo/phonopy


text:
"Failed to launch chrome! spawn"

I'm using the latest version of vs code and chrome dev as well. Whenever I try to view HTML code via browser preview I get the error below.  Any resolutions?
C:\Users\name\AppData\Local\Google\Chrome Dev\Application\chrome.exe" ENOENT

What path do you have Google Chrome installed at?

Chrome would install its self to the user appdata folder in windows 10. I changed the path in browser view settings to that path but still had the same issues. I've figured the error is a permissions issue since appdata is a protected folder within the users folder.
I resolved the issue by using my mac pro to develop in. I've had no issues since then, thanks!

repo: auchenberg/vscode-browser-preview


text:
Is there a way to analyse an image, not a video?

For a project, I need to analyse images for facial features. I wondered if this library is able to do so, and not just videos.
The best solution I have so far is to create a video with the image moving left-to-right, and rotating left-to-right, up-and-down. but that is dirty.

It is possible to use images as well, take a look at some of the examples, for instance this : https://auduno.github.io/clmtrackr/clm_image.html

Odd.
I was using this image for testing:

Sometimes it converges, but not really and sometimes it fails.

And locally, the results is quite funny:

authors: AmitMY auduno

repo: auduno/clmtrackr


text:
Pytorch lightning

Merging code from the PyTorch Lightning refactor into main.

I may have made a mistake here.

repo: augustwester/gflownet


text:
Adding idea rejected domain event

Closes #23 issue

Pull Request Test Coverage Report for Build 88

7 of 7 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 86:
0.0%

Covered Lines:
145

Relevant Lines:
145

💛  - Coveralls

authors: coveralls victormonserrat

repo: aulasoftwarelibre/gata


text:
Secondary node_modules folder under aurelia-bootstrapper-webpack folder

The npm install process is currently adding an additional nested node_modules folder containing aurelia-loader-webpack under the node_modules/aurelia-bootstrapper-webpack folder.
Result;
./node_modules/aurelia-bootstrapper-webpack/node_modules/aurelia-loader-webpack/[loader files]

You need to be using npm 3 or run the dedupe. See the webpack skeleton for instructions.

authors: EisenbergEffect jsobell

repo: aurelia/bootstrapper-webpack