text:
Detect changes to StatelessWidget/StatefulWidget base class in hot reload

Steps to Reproduce
Make a class that extends StatelessWidget.
flutter run
Change your class to extend StatefulWidget
Hot-reload
Result: Assertion failure in StatelessElement.widget (or StatefulElement.update if you're going the other direction). Hot-restarting fixes the issue.
Suggestion: We should detect this case and show a helpful error message that suggests hot-restarting, or ideally just rebuild the parts of the app that need to be rebuilt.
/cc @Hixie @jason-simmons @sethladd
Related bugs: #9771 #9761
Logs
══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following assertion was thrown building _ModalScopeStatus(active):
type 'MyHomePage' is not a subtype of type 'StatelessWidget' of 'function result' where
The following assertion was thrown building _ModalScopeStatus(active):
  MyHomePage is from
type 'MyHomePage' is not a subtype of type 'StatelessWidget' of 'function result' where
  /Users/jackson/Library/Developer/CoreSimulator/Devices/5F90A4C3-6F80-446A-88CB-5394635BF8EF/data/Containers/Data/Application/03A8AB58-F47E-454A-8742-818E868A855D/tmp/scope_exampleCOE3SC/scope_example/lib/main.dart
  MyHomePage is from
  StatelessWidget is from package:flutter/src/widgets/framework.dart
  /Users/jackson/Library/Developer/CoreSimulator/Devices/5F90A4C3-6F80-446A-88CB-5394635BF8EF/data/Containers/Data/Application/03A8AB58-F47E-454A-8742-818E868A855D/tmp/scope_exampleCOE3SC/scope_example/lib/main.dart
  StatelessWidget is from package:flutter/src/widgets/framework.dart
Either the assertion indicates an error in the framework itself, or we should provide substantially
more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
Either the assertion indicates an error in the framework itself, or we should provide substantially
more information in this error message to help you determine and fix the underlying cause.
  https://github.com/flutter/flutter/issues/new
In either case, please report this assertion by filing a bug on GitHub:
  https://github.com/flutter/flutter/issues/new
When the exception was thrown, this was the stack:
#0      StatelessElement.widget (package:flutter/src/widgets/framework.dart:3196:39)
#1      Element.updateChild (package:flutter/src/widgets/framework.dart:2290:17)
#2      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#3      Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#2      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#3      Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#4      ProxyElement.update (package:flutter/src/widgets/framework.dart:3392:5)
#5      Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#6      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#7      Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#8      StatelessElement.update (package:flutter/src/widgets/framework.dart:3206:5)
#9      Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#10     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#9      Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#11     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#12     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#10     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#13     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#11     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#12     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#14     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#13     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#15     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#16     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#14     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#17     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#15     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#16     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#18     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#19     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#17     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#20     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#18     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#21     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#19     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#22     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#20     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#23     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#21     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#22     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#24     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#23     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#25     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#26     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#24     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#25     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#27     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#26     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#28     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#29     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#27     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#30     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#28     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#31     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#32     StatelessElement.update (package:flutter/src/widgets/framework.dart:3206:5)
#29     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#33     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#30     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#34     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#35     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#31     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#32     StatelessElement.update (package:flutter/src/widgets/framework.dart:3206:5)
#36     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#33     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#34     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#37     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#35     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#38     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#36     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#39     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#37     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#40     ProxyElement.update (package:flutter/src/widgets/framework.dart:3392:5)
#38     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#41     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#42     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#39     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#40     ProxyElement.update (package:flutter/src/widgets/framework.dart:3392:5)
#43     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#44     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#41     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#45     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#42     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#46     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#43     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#47     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#44     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#48     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#49     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#45     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#50     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#46     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#51     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#47     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#52     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#53     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#48     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#54     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#49     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#55     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#56     RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:3818:32)
#50     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#57     MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4200:17)
#51     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#58     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#52     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#53     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#59     _TheatreElement.update (package:flutter/src/widgets/overlay.dart:507:16)
#60     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#54     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#61     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#55     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#62     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#56     RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:3818:32)
#63     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#57     MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4200:17)
#64     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#58     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#65     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#59     _TheatreElement.update (package:flutter/src/widgets/overlay.dart:507:16)
#66     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#60     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#67     ProxyElement.update (package:flutter/src/widgets/framework.dart:3392:5)
#61     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#68     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#62     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#69     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#70     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#63     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#64     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#71     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#65     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#72     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#73     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#66     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#74     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#67     ProxyElement.update (package:flutter/src/widgets/framework.dart:3392:5)
#75     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#76     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#68     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#69     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#77     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#70     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#78     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#71     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#79     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#80     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#72     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#73     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#81     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#74     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#82     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#75     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#83     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#76     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#84     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#85     StatelessElement.update (package:flutter/src/widgets/framework.dart:3206:5)
#77     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#86     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#78     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#87     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#88     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#79     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#89     ProxyElement.update (package:flutter/src/widgets/framework.dart:3392:5)
#80     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#90     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#91     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#81     StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#92     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#93     ProxyElement.update (package:flutter/src/widgets/framework.dart:3392:5)
#82     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#94     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#83     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#95     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#96     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#84     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#97     ProxyElement.update (package:flutter/src/widgets/framework.dart:3392:5)
#98     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#85     StatelessElement.update (package:flutter/src/widgets/framework.dart:3206:5)
#99     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#86     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#100    Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#87     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#88     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#101    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#102    Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#89     ProxyElement.update (package:flutter/src/widgets/framework.dart:3392:5)
#103    StatelessElement.update (package:flutter/src/widgets/framework.dart:3206:5)
#90     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#104    Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#105    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#91     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#106    Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#107    StatelessElement.update (package:flutter/src/widgets/framework.dart:3206:5)
#92     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#108    Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#93     ProxyElement.update (package:flutter/src/widgets/framework.dart:3392:5)
#109    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#94     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#110    Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#95     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#111    StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#112    Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#96     Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#113    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#97     ProxyElement.update (package:flutter/src/widgets/framework.dart:3392:5)
#114    Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#115    ProxyElement.update (package:flutter/src/widgets/framework.dart:3392:5)
#98     Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#116    Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#99     SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4092:14)
#117    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#100    Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#118    Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#119    StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#101    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#120    Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#102    Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#121    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#122    Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#103    StatelessElement.update (package:flutter/src/widgets/framework.dart:3206:5)
#123    ProxyElement.update (package:flutter/src/widgets/framework.dart:3392:5)
#124    Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#104    Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#125    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#126    Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#105    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#127    StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#128    Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#106    Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#129    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#130    Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#107    StatelessElement.update (package:flutter/src/widgets/framework.dart:3206:5)
#131    BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:1898:33)
#108    Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#132    BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding&WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:360:20)
#133    BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:170:5)
#109    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#134    BindingBase&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:685:15)
#135    BindingBase&SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:633:9)
#110    Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#136    BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding.scheduleWarmUpFrame.<anonymous closure> (package:flutter/src/rendering/binding.dart:247:20)
#111    StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#138    _Timer._runTimers (dart:isolate-patch/timer_impl.dart:366)
#112    Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#139    _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:394)
#113    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#140    _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:151)
#114    Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#115    ProxyElement.update (package:flutter/src/widgets/framework.dart:3392:5)
(elided one frame from package dart:async-patch)
#116    Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
════════════════════════════════════════════════════════════════════════════════════════════════════
#117    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#118    Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#119    StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#120    Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#121    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#122    Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#123    ProxyElement.update (package:flutter/src/widgets/framework.dart:3392:5)
#124    Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#125    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#126    Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#127    StatefulElement.update (package:flutter/src/widgets/framework.dart:3281:5)
#128    Element.updateChild (package:flutter/src/widgets/framework.dart:2298:15)
#129    ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3156:16)
#130    Element.rebuild (package:flutter/src/widgets/framework.dart:3045:5)
#131    BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:1898:33)
#132    BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding&WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:360:20)
#133    BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:170:5)
#134    BindingBase&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:685:15)
#135    BindingBase&SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:633:9)
#136    BindingBase&SchedulerBinding&GestureBinding&ServicesBinding&RendererBinding.scheduleWarmUpFrame.<anonymous closure> (package:flutter/src/rendering/binding.dart:247:20)
#138    _Timer._runTimers (dart:isolate-patch/timer_impl.dart:366)
#139    _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:394)
#140    _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:151)
(elided one frame from package dart:async-patch)
════════════════════════════════════════════════════════════════════════════════════════════════════
Another exception was thrown: type 'MyHomePage' is not a subtype of type 'StatelessWidget' of 'function result' where
Another exception was thrown: type 'MyHomePage' is not a subtype of type 'StatelessWidget' of 'function result' where
Another exception was thrown: type 'MyHomePage' is not a subtype of type 'StatelessWidget' of 'function result' where
Another exception was thrown: 'package:flutter/src/widgets/framework.dart': Failed assertion: line 4112 pos 12: 'renderObject.child == child': is not true.
Another exception was thrown: 'package:flutter/src/widgets/framework.dart': Failed assertion: line 1896 pos 16: '!_dirtyElements[index]._active || _dirtyElements[index]._debugIsInScope(context)': is not true.
Reloaded 1 of 427 libraries in 788ms.

Run flutter analyze and attach any output of that command also.
Flutter Doctor
[✓] Flutter (on Mac OS X 10.12.4 16E195, channel unknown)
• Flutter at /Users/jackson/git/flutter
• Framework revision 1d726bbeb5 (2 days ago), 2017-05-02 12:53:03 -0700
• Engine revision da8ebf40bd
• Tools Dart version 1.23.0-dev.11.11
[✓] Android toolchain - develop for Android devices (Android SDK 25.0.2)
• Android SDK at /Users/jackson/Library/Android/sdk/
• Platform android-25, build-tools 25.0.2
• ANDROID_HOME = /Users/jackson/Library/Android/sdk/
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version: OpenJDK Runtime Environment (build 1.8.0_112-release-b06)
[-] iOS toolchain - develop for iOS devices (Xcode 8.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 8.3.1, Build version 8E1000a
• ios-deploy 1.9.1
✗ libimobiledevice is incompatible with the installed Xcode version. To update, run:
brew update
brew uninstall --ignore-dependencies libimobiledevice
brew install --HEAD libimobiledevice
• CocoaPods version 1.0.1
[✓] Android Studio (version 2.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Gradle version 3.2
• Java version: OpenJDK Runtime Environment (build 1.8.0_112-release-b06)
[✓] IntelliJ IDEA Community Edition (version 2016.3.4)
• Dart plugin version 163.13137
• Flutter plugin version 0.1.11.2
[✓] Connected devices
•               • 14710ae2e8497590643751c5532d907ed1ff2eed • ios • iOS  ()
• iPhone 7 Plus • 5F90A4C3-6F80-446A-88CB-5394635BF8EF     • ios • iOS 10.3 (simulator)

@a-siva is this something we could handle in hot reload?

One way to solve this would be to change the runtimeType of a class when its inheritance changes. This would make us think that the widget had changed and we'd automatically blow it away and recreate it. The trick would be doing this without increasing the cost of runtimeType in general.

@Hixie at least maybe throw a more informative error that tells us to do a rebuild vs a hot-reload? It's over a year later and making these same changes resulted in my googling the error only to find this conversation. :) Thanks for the work you guys are doing!

authors: Hixie adriancmurray collinjackson mit-mit


text:
preview of prefer_asserts_in_initializer_list lint

2 new lints are coming in linter (prefer_asserts_in_initializer_list and prefer_const_constructors_in_immutables - names might change).
The first one lints asserts in contructor that can be move to initializer list. It allows to show that the asserts are done on parameters. It also improves the probabilty that the prefer_const_constructors_in_immutables rule lints the constructor to become a const constructor.
Is it something that is interessing to enable in flutter ? wdyt ?
(note: I use something similar to detect what immutable class could be const)

source: gharchive/pull-request

repo: flutter/flutter

license_type: permissive

license_source: github-api


text:
Roll Flutter Engine from 1b132e44194d to 88fda68f454a (2 revisions)

https://github.com/flutter/engine/compare/1b132e44194d...88fda68f454a
2023-02-04 skia-flutter-autoroll@skia.org Roll Skia from 5d8a7ed8acfe to 8de8c6287254 (1 revision) (flutter/engine#39382)
2023-02-04 skia-flutter-autoroll@skia.org Roll Skia from f083b79aa388 to 5d8a7ed8acfe (3 revisions) (flutter/engine#39381)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


text:
[flutter_releases] Flutter stable 3.7.7 Framework Cherrypicks

Flutter stable 3.7.7 Framework
Scheduled Cherrypicks

Codesigning tests should not run on presubmit. Ignoring for this PR.


text:
Use 24-hour validation if 24-hour dials are used (#141610)

Replace MediaQuery.alwaysUse24HourFormatOf(context) with use24HourDials boolean.
If system clock uses 12-hour and Flutter locale uses 24-hours time picker would show 24-hour dials but use 12-hours clock to parse hours. Valid time eg. 20:00 would not pass input validation.
Testing requires intl support and mocking MediaQuery#alwaysUse24HourFormat result. time_picker_test.dart didn't seem to allow this easily. Actual fix was simple but I'm unable to write unit test for it.
Change was manually tested
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
https://github.com/flutter/flutter/issues/141610
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Non breaking change
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@MitchellGoodwin Unfortunately it is not that simple.

MediaQuery that is provided a MediaQueryData with alwaysUse24HourFormat set to false enable the test to work?

alwaysUse24HourFormat is false by default because of default locale. To write test for this you need you first be using 24-hour locale and then wrap MediaQuery to return with alwaysUse24HourFormat set to false. So you would need to install intl package and provice Locale to MaterialApp. I could not find precedent about this in unit tests

Hello @jukkaleh-atoz. If you need to wrap a specific local around specific media query, would Localizations.override work for this case? I do see that we don't seem to test localizations that often in the tests. Then under that localization override you can include the right media query.

Hey @jukkaleh-atoz  thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to re-open or submit a new PR if you have the time to address the review comments. Thanks!

authors: MitchellGoodwin Piinks jukkaleh-atoz


text:
Roll engine 5088735e5f54..568841923653 (2 commits)

https://github.com/flutter/engine/compare/5088735e5f54...568841923653
git log 5088735e5f54f7fb34215b6665cb4da1fd8f075d..568841923653c9048fbae97eac7e269d32ebf2e7 --no-merges --oneline
568841923 Disable build_ios due to large queue times. (flutter/engine#8204)
629072277 Merge only gpu and platform threads for platform views, fix deadlock. (flutter/engine#8045)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5139884858671104

Commit queue failed; closing this roll.


text:
Add a Flutter for web issue template

Add an issue template specific to Flutter's web support

This would prevent web issues from getting front line triage (because the way we drive what gets triage is by a search that excludes already-triaged bugs). Given that there is very little here that is unique to web issues, I'm concerned that this would actually overall be a net negative as it would mean web bugs get fewer labels and less front line processing.
That said, we can certainly add this temporarily while we wait for triage to resume. If you land this, please keep a note of all the places where you link to this template so that we can change them all to the the bug template when we are doing triage normally again.

@Hixie – so you DON'T want a template?

Happy to reuse Flutter's existing triage system. It would be very helpful to have issues get the platform-web label asap so it lands on the Web team's plate quicker. Would Flutter's triage process facilitate that?

I could go either way on this, as described above. I don't have a strong opinion. Long term I'd rather rely on front line triage. @kf6gpe tells me that will be going again soon.

authors: Hixie kevmoo yjbanov


text:
Roll engine 540fc977bb6b..509aa53a1dea (5 commits)

git@github.com:flutter/engine.git/compare/540fc977bb6b...509aa53a1dea
git log 540fc977bb6b..509aa53a1dea --no-merges --oneline
2019-10-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia 55f9cba6e2e7..f22c57ddcc8c (1 commits) (flutter/engine#13136)
2019-10-15 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from xRgq0... to Jv4XM... (flutter/engine#13135)
2019-10-15 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Lk7iT... to i5xD1... (flutter/engine#13134)
2019-10-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia 858cf233ef71..55f9cba6e2e7 (3 commits) (flutter/engine#13133)
2019-10-15 bkonyi@google.com Roll src/third_party/dart 70a7ef3f58..50f7ae9c5d (18 commits)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/5530118809714688

Commit queue failed; closing this roll.


text:
Roll engine e7b69ced2e24..f5250ec9b1ef (2 commits)

https://github.com/flutter/engine/compare/e7b69ced2e24...f5250ec9b1ef
git log e7b69ced2e24..f5250ec9b1ef --first-parent --oneline
2019-12-06 iska.kaushik@gmail.com [fuchsia] SnapToNextPhase refactor + add tests and documentation (flutter/engine#14158)
2019-12-06 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from VKso5... to 9C6UA... (flutter/engine#14161)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Trybots failed. These were the failed builds: https://github.com/flutter/flutter/runs/338471225

Commit queue failed; closing this roll.


text:
Roll engine e7b69ced2e24..f5250ec9b1ef (2 commits)

https://github.com/flutter/engine/compare/e7b69ced2e24...f5250ec9b1ef
git log e7b69ced2e24..f5250ec9b1ef --first-parent --oneline
2019-12-06 iska.kaushik@gmail.com [fuchsia] SnapToNextPhase refactor + add tests and documentation (flutter/engine#14158)
2019-12-06 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from VKso5... to 9C6UA... (flutter/engine#14161)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Trybots failed. These were the failed builds: https://github.com/flutter/flutter/runs/338810553

Commit queue failed; closing this roll.


text:
Roll engine 2e2a9e192d3d..7381ca8ddfe8 (3 commits)

https://github.com/flutter/engine/compare/2e2a9e192d3d...7381ca8ddfe8
git log 2e2a9e192d3d..7381ca8ddfe8 --first-parent --oneline
2020-03-05 cyril7@gmail.com Avoid generating VSYNC trace events from Flutter common code. (flutter/engine#16248)
2020-03-05 52682268+fluttergithubbot@users.noreply.github.com Roll src/third_party/skia f6ed96d1c23b..d2f18734aa84 (5 commits) (flutter/engine#16955)
2020-03-05 52682268+fluttergithubbot@users.noreply.github.com Roll src/third_party/dart 8e5354dccb64..d1d89c8ce1a1 (10 commits) (flutter/engine#16954)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Commit queue failed; closing this roll.


text:
update template so that it formats correctly

@devoncarew

lgtm!

Thank you!  I'm interested in us seeing if we can adopt dart-fmt within Flutter as well, or what the changes would need to be to make that possible.  Thanks for making our template dart-fmt clean!  FYI @Hixie

Yeah, from the bugs, I assumed that adding commas to the starter template, and wrapping dartfmt w/ the flutter tool, were something we were planning on doing.

authors: danrubel devoncarew eseidelGoogle


text:
drive: Support an environment-specified VM service URL

If a URL is not explicitly specified by the test author, check for an
environment-specified URL before falling back to the default value.

/cc @yjbanov

LGTM

authors: cbracken yjbanov


text:
[versions] roll to latest test

Fixes https://github.com/flutter/flutter/issues/77856
Roll to latest package:test, test_core, test_api

  error • A value of type 'String?' can't be assigned to a variable of type 'String' • packages/flutter_test/test/widget_tester_test.dart:76:30 • invalid_assignment
  error • A value of type 'String?' can't be assigned to a variable of type 'String' • packages/flutter_test/test/widget_tester_test.dart:99:30 • invalid_assignment
  error • A value of type 'String?' can't be assigned to a variable of type 'String' • packages/flutter_test/test/widget_tester_test.dart:117:30 • invalid_assignment

So this can't actually land, until we figure out what we want to do about the version change.

all dependencies are updated

Now blocked by https://github.com/flutter/plugins/pull/3769

Looks like its all going to pass

authors: jmagman jonahwilliams


text:
Roll Engine from eb94e4f595b6 to 68df2f5f3c24 (5 revisions)

https://github.com/flutter/engine/compare/eb94e4f595b6...68df2f5f3c24
2021-09-23 dnfield@google.com Remove obsolete instructions from scenario_app readme, pass depfile correctly. (flutter/engine#28732)
2021-09-23 skia-flutter-autoroll@skia.org Roll Dart SDK from eba0c93d96de to 1d7f47bf04d8 (1 revision) (flutter/engine#28818)
2021-09-23 31977171+ColdPaleLight@users.noreply.github.com Delete is_background_view from FlutterJNI (flutter/engine#28566)
2021-09-23 i@huangyuhui.net Linux texture support (flutter/engine#24916)
2021-09-23 bdero@google.com Remove outdated unused element suppressions (flutter/engine#28775)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC garyq@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


text:
Made child param required in Opacity widget

Made child param in Opacity widget required
We don't need the widget transparency without child
List which issues are fixed by this PR. You must list at least one issue.
https://github.com/flutter/flutter/issues/91321
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I signed the CLA.
[X] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Gold has detected about 3 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/91517

what other steps need to be taken to accept the changes?

Closing this in favor of https://github.com/flutter/flutter/pull/91350.

authors: Konoshenko goderbauer skia-gold


text:
[CupertinoActivityIndicator] Add color parameter

Fixes https://github.com/flutter/flutter/issues/26556
Description
This color parameter to CupertinoActivityIndicator, if it is null, the default color is used.

minimal code sample
import 'package:flutter/cupertino.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return CupertinoApp(
      title: 'Cupertino App',
      theme: const CupertinoThemeData(
        brightness: Brightness.light,
      ),
      home: CupertinoPageScaffold(
        navigationBar: const CupertinoNavigationBar(
          middle: Text('Cupertino App Bar'),
        ),
        child: Center(
          child: Row(
            mainAxisAlignment: MainAxisAlignment.spaceEvenly,
            crossAxisAlignment: CrossAxisAlignment.center,
            children: [
              Column(
                mainAxisAlignment: MainAxisAlignment.spaceEvenly,
                children: const [
                  CupertinoActivityIndicator(
                  ),
                  CupertinoActivityIndicator(
                    radius: 25,
                  ),
                  CupertinoActivityIndicator(
                    radius: 100,
                  ),
                ],
              ),
              Column(
                mainAxisAlignment: MainAxisAlignment.spaceEvenly,
                children: const [
                  CupertinoActivityIndicator(
                    color: CupertinoColors.systemPurple,
                  ),
                  CupertinoActivityIndicator(
                    color: CupertinoColors.systemPurple,
                    radius: 25,
                  ),
                  CupertinoActivityIndicator(
                    color: CupertinoColors.systemPurple,
                    radius: 100,
                  ),
                ],
              ),
              Column(
                mainAxisAlignment: MainAxisAlignment.spaceEvenly,
                children: const [
                  CupertinoActivityIndicator(
                    color: CupertinoColors.systemPurple,
                                        animating: false,

                  ),
                  CupertinoActivityIndicator(
                    color: CupertinoColors.systemPurple,
                    radius: 25,
                                        animating: false,

                  ),
                  CupertinoActivityIndicator(
                    color: CupertinoColors.systemPurple,
                    radius: 100,
                    animating: false,
                  ),

                ],
              ),
            ],
          ),
        ),
      ),
    );
  }
}

Preview
https://user-images.githubusercontent.com/48603081/138094111-b464d2a9-f447-4a50-972b-f67e60ef235b.mp4
Golden images

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Drive-by comments: the color passed in via the widget could be a CupertinoDynamicColor so it needs to be resolved before used by the painter. Also I'm not sure if we want to add more things to CupertinoThemeData @HansMuller ?

CupertinoThemeData is currently quite minimal and should probably stay that way.  Evolving CupertinoThemeData organically, as needs show up, doesn't really scale well (consider Material's ThemeData).

@HansMuller
Can we merge this without the theme? I have reverted the Cupertino Theme Data changes

Gold has detected about 1 new digest(s) on patchset 11.
View them at https://flutter-gold.skia.org/cl/github/92172

Gold has detected about 1 new digest(s) on patchset 12.
View them at https://flutter-gold.skia.org/cl/github/92172

@HansMuller
One new golden is added as the indicator is too small for direct color sampling, made the other changes :)

@TahaTesser : @LongCatIsLooong  is correct, we need to handle and test the case where the CupertinoActivityIndicator's color is a CupertinoDynamicColor like CupertinoColors.systemBlue.  So:
activeColor:  CupertinoDynamicColor.maybeResolve(widget.color, context)
  ?? CupertinoDynamicColor.resolve(_kActiveTickColor, context)

Gold has detected about 1 new digest(s) on patchset 13.
View them at https://flutter-gold.skia.org/cl/github/92172

@TahaTesser : @LongCatIsLooong is correct, we need to handle and test the case where the CupertinoActivityIndicator's color is a CupertinoDynamicColor like CupertinoColors.systemBlue. So:
activeColor:  CupertinoDynamicColor.maybeResolve(widget.color, context)
  ?? CupertinoDynamicColor.resolve(_kActiveTickColor, context)

Done

authors: HansMuller TahaTesser skia-gold


text:
Improve sync*/async* opt outs

Following up on suggestion from https://github.com/flutter/flutter/pull/95200#issuecomment-992856888
In trying to write an explanation for the example I realized it would really be better refactored to not use async* anyway, so I did that. I updated the two remaining usages of sync* to have explanations.
I shortened the text suggested to make it a little easier to keep under 80 cols in normal comments.

This is great. I suggest documenting the magic string in the style guide if you haven't already.

authors: Hixie dnfield


text:
Use horizontal dots on iOS menu button

As required by
https://material.io/guidelines/platforms/platform-adaptation.html#platform-adaptation-platform-recommendations.

LGTM, but fails Travis due to the cranky is check.

authors: abarth cbracken


text:
[local_auth]Fix lock out alert message iOS

Description
Fixed an issue with an alertMessage crashing the application after failing to authenticate with fingerprint 5 times (3 + 2) on iOS
Related Issues
Fixes:
flutter/flutter#57129
flutter/flutter#48140
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Can anyone approve this PR? It is super necessary since the error is 100% replicable

Format is failing. I can't seem to install the formatting tools. Someone pick it up and format it?

Same for me, can't install the formatting tools.
May anybody check it please ?

i have sam as issue,
please merger this PR
thanks

Please put some urgency into this PR, its reproducible

I have sam as issue.
Any update?

Any updates on this? The app still crashes after the 5th attempt.

When will this PR be merged!???  Touch ID on iOS is definitely crashing.

When will this PR be merged!???  Touch ID on iOS is definitely crashing.

Any updates on this?

Any updates on this?

Thanks for the submission! We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.
The underlying issue here is that evaluatePolicy:localizedReason:reply:'s callback can be called on any thread; this PR one specific bug related to that, but there's other code—notably the replies to the Flutter engine—in that codepath that should also be done on the main thread, so the dispatch needs to be moved up a level.
@severance88 Are you still interested in working on this? If so, you can adjust it as described above. If not, I can take over this PR to make the necessary changes (and look into adding a test).

The fix ended up being more involved as other methods were impacted, and there was additional refactoring for testability, so I ended up making a new PR. Closing in favor of https://github.com/flutter/plugins/pull/3778.
Thanks again for the initial pass at a fix!

authors: ShvetsDima TMSantos ajviera fransboumans severance88 silverhsu1120 stuartmorgan trunghieuvn yaizudamashii

repo: flutter/plugins


text:
Standardize copyright year

Standardizes all first-party copyrights on a single year, as is done in flutter/flutter and flutter/engine. All code now uses 2013, which is the earliest year that was in any existing copyright notice.
The script checks now enforce the exact format of first-party licenses and copyrights.
Fixes https://github.com/flutter/flutter/issues/78448
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
[x] I signed the CLA.
[ ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[ ] I updated CHANGELOG.md to add a description of the change.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[x] All existing and new tests are passing.

The first commit has the script changes; all subsequent commits are the mechanical replacements.


text:
[camera_platform_interface] Take picture with max resolution interface

This PR is related to the PR, https://github.com/flutter/plugins/pull/3854.
To add an argument to camera plugin, camera_platform_interface should be modified too.
List which issues are fixed by this PR. You must list at least one issue.
https://github.com/flutter/plugins/pull/3854
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[ ] I updated CHANGELOG.md to add a description of the change.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This PR is mistake.

please remove this PR


text:
Fix Dart 2 issues in firebase plugins

Fixes https://github.com/flutter/flutter/issues/15027

/fyi @mravn-google I have fixed all firebase_* plugins except firebase_database where test crashes and I don't have time for it right now.

Looks like Travis isn't happy:
Checking project firebase_auth...
  error - Missing parameter type for 'v' at lib/firebase_auth.dart:111:71 - (strong_mode_implicit_dynamic_parameter)
  info - Specify type annotations at lib/firebase_auth.dart:111:71 - (always_specify_types)
  info - Avoid using `as` at lib/firebase_auth.dart:111:77 - (avoid_as)

I have fixed more issues. Where I fixed the plugin code itself I bumped version in pubspec and added an entry to CHANGELOG.
Now all the tests except one test in firebase_database pass. The test in firebase_database fails due to https://github.com/dart-lang/sdk/issues/28498.
@mravn-google please take another quick look

@tvolkert Travis seems to be stuck on one of the Shards - do you know if there is a way to nudge it?

I restarted the job.

Now, I am getting errors in the files I did not edit :-/ I am just gonna push it as is.

It looks like dartfmt has been updated with some improvements, but it's yielding an error because our existing formatted code isn't formatted correctly anymore.

When will this be available through pub? Not seeing 0.4.7 yet
https://pub.dartlang.org/packages/firebase_auth#-versions-tab-

Sorry, that was an omission on my part. Version 0.4.7 has just been published.

authors: cdock1029 mraleph mravn-google tvolkert


text:
[google_maps_flutter] Make objects inheriting MapsObjectId equal

Currently, using an object of the class extending MarkerId results in on-tap and on-drag gestures to fail. The reason for this is that the MapsObjectId class checks the runtimeTypes of the object in the bool operator == and they are not equal (one is the actual extended class, the other that comes over the method channel is always MarkerId (see the comment for more details). This changes checking the runtimeType to is check.
I think that checking for an actual runtimeType instead of preserving inheritance is a bit of an overkill because what the MapsObjectId really is, is just a "string value holder". Thus, I think we should allow objects that are not actually of the same class but are related according to inheritance be equal (but I might be wrong if there is a special reason for checking runtimeType).
Fixing this issue.
flutter/tests repo left intact.
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the [CLA].
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
[x] I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] All existing and new tests are passing.

Thanks for the submission!

I might be wrong if there is a special reason for checking runtimeType

I'm not sure what you mean by "a special reason"; it's a standard part of implementing equality operators in Dart. Why would we need a special reason to do the standard thing?

I think that checking for an actual runtimeType instead of preserving inheritance is a bit of an overkill because what the MapsObjectId really is, is just a "string value holder".

MapsObjectId is just an identifier, yes. But if the type of the other thing is not a MapsObjectId, then we don't know what it is, and therefore can't say it's equal. Maybe it's an identifier and some other data, for instance, and those two things certainly aren't equal. (And weird things start to happen with commutativity if we pretend they are.)
I'm going to close this, as this isn't a change we want to make; the current definition of equality is correct.

Yeah, I might have misused a word "special", my appologies.
What I was trying to say is that if we have a similar analogy, class Person and class User extends Person. Person has a field String personalIdentifier, but then User has another String uuid for example. Now, in terms of a Person "concept", the Users and Persons are equal if they have the same personalIdentifier. They are, in fact, both Person. However, in terms of User "concept", a uuid is also added into an account for comparison. I gave a bad example, but could not come up with a better one before my morning coffee.
I do agree, however, that checking the runtimeType is the standard way to go, but then as mentioned in the comments on issue, I think the class should either be sealed (probably better) or when adding markers to the map we should check for the runtimeType to be equal MarkerId. Because currently, we are letting users extend the MarkerId and pass the inherited object as a MarkerId, although we know that it is not going to work.

authors: campovski stuartmorgan


text:
Roll Flutter from b2672fe8355f to 458f129b889c (30 revisions)

https://github.com/flutter/flutter/compare/b2672fe8355f...458f129b889c
2022-12-01 engine-flutter-autoroll@skia.org d75b7ce37 Roll Skia from 06801a30fc86 to bfc7c3a83dc0 (4 revisions) (flutter/engine#38004) (flutter/flutter#116365)
2022-12-01 engine-flutter-autoroll@skia.org 31f099c21 Roll Skia from 4418e5468ee2 to 06801a30fc86 (1 revision) (flutter/engine#38003) (flutter/flutter#116361)
2022-12-01 engine-flutter-autoroll@skia.org 52054a327 Roll Fuchsia Mac SDK from C4DamROwkxoF0YXyS... to hODX8Qi_7J5kwKp4S... (flutter/engine#38002) (flutter/flutter#116354)
2022-12-01 engine-flutter-autoroll@skia.org Roll Plugins from a431b35bfa0b to 89ad5a9d6a33 (7 revisions) (flutter/flutter#116356)
2022-12-01 garyq@google.com Reland "Upgrade targetSdkVersion and compileSdkVersion to 33" (flutter/flutter#116146)
2022-12-01 engine-flutter-autoroll@skia.org 677549602 Roll Skia from 767175530c11 to 4418e5468ee2 (3 revisions) (flutter/engine#37999) (flutter/flutter#116335)
2022-12-01 engine-flutter-autoroll@skia.org 51356bf89  [Impeller] Implement 'ui.Image.toByteData()' (flutter/engine#37709) (flutter/flutter#116321)
2022-12-01 engine-flutter-autoroll@skia.org 441229a95 Roll Skia from 2a75bac61922 to 767175530c11 (4 revisions) (flutter/engine#37994) (flutter/flutter#116318)
2022-12-01 jmccandless@google.com Revert "iOS 16 context menu (#115805)" (flutter/flutter#116312)
2022-12-01 engine-flutter-autoroll@skia.org 3c1de6882 Fix typo on avoid_backing_store_cache param doc (flutter/engine#37985) (flutter/flutter#116313)
2022-12-01 36861262+QuncCccccc@users.noreply.github.com Added controller and onSelected properties to DropdownMenu (flutter/flutter#116259)
2022-12-01 engine-flutter-autoroll@skia.org Roll Flutter Engine from be4c7e2955c8 to 99b000e1e111 (2 revisions) (flutter/flutter#116310)
2022-12-01 tessertaha@gmail.com Add Material 3 Slider example (flutter/flutter#115638)
2022-11-30 engine-flutter-autoroll@skia.org be4c7e295 Roll Skia from d378c7817d8a to 2a75bac61922 (2 revisions) (flutter/engine#37989) (flutter/flutter#116309)
2022-11-30 58190796+MitchellGoodwin@users.noreply.github.com Update CupertinoContextMenu to iOS 16 visuals (flutter/flutter#110616)
2022-11-30 thkim1011@users.noreply.github.com [gen_l10n] Improvements to gen_l10n (flutter/flutter#116202)
2022-11-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from d8f151e24fda to f8dc855ddb40 (2 revisions) (flutter/flutter#116305)
2022-11-30 102626803+drewroengoogle@users.noreply.github.com Add release_build parameter (flutter/flutter#116307)
2022-11-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from ff3a7789f45a to d8f151e24fda (2 revisions) (flutter/flutter#116301)
2022-11-30 christopherfujino@gmail.com Track entire web build directory size in web_size__compile_test (flutter/flutter#115682)
2022-11-30 christopherfujino@gmail.com [flutter_tools] add deprecation message for "flutter format" (flutter/flutter#116145)
2022-11-30 danny@tuppeny.com [flutter_tools] Forward app.webLaunchUrl event from Flutter to DAP clients (flutter/flutter#116275)
2022-11-30 engine-flutter-autoroll@skia.org ff3a7789f ubuntu version (flutter/engine#37948) (flutter/flutter#116300)
2022-11-30 engine-flutter-autoroll@skia.org e00aeef24 Roll Fuchsia Mac SDK from ECusE22sNK6IbnL6L... to C4DamROwkxoF0YXyS... (flutter/engine#37983) (flutter/flutter#116295)
2022-11-30 chillers@google.com Revert "Fix Slider semantic node size (#115285)" (flutter/flutter#116294)
2022-11-30 eilidhsouthren@gmail.com M3 snackbar [re-land] (flutter/flutter#116218)
2022-11-30 christopherfujino@gmail.com add debug trace when compiling dart2js (flutter/flutter#116238)
2022-11-30 engine-flutter-autoroll@skia.org 0f17acdaf Roll Skia from 8f4f340f830c to bd9a7f3485b4 (3 revisions) (flutter/engine#37978) (flutter/flutter#116291)
2022-11-30 tessertaha@gmail.com [Reland] Add Material 3 support for TabBar (flutter/flutter#116283)
2022-11-30 engine-flutter-autoroll@skia.org Roll Flutter Engine from d5690468da0f to 1bda5f8c094d (5 revisions) (flutter/flutter#116290)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-plugins
Please CC dit@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Plugins: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


text:
Question: is it possible to get stream of model events?

I'm usig flutter_bloc and I want to listen to user's changes. How can I do that?
final repository = GetIt.instance.get<Repository<AppUser>>();

repository.watchOne(user.id) => _CastError (Null check operator used on a null value)
repository.watchOneNotifier(user.id) => _CastError (Null check operator used on a null value)

At some point I assumed clients all use Riverpod and stopped testing with other libraries like Provider, GetIt or bloc.
You could try repository.remoteAdapter.watchOneNotifier(...) but note that you will have to pass the model's key that you can obtain via DataModel.keyFor(model).

source: gharchive/issue

license: MIT


text:
FSA : GitRepository object fails to clone private github repo.

Hi,
We are facing issues when using FSA with ArgoCD. Upon creating ArgoCD application thru UI with a private github repo, the GitRepository instance shows error that its not able to clone the repo.
How to pass the github credentials in case of FSA when we select to "User Flux subsystem" and "auto-create Flux resources"?

@chanwit fyi.

Thanks @chanwit . closing this ticket for now.

repo: flux-subsystem-argo/flamingo


text:
StatefulSet deployed via a Flux HelmRelease are not displayed in the UI.

Hi,
We use flux 2.2.3 and Flamingo v2.10.2+81e8dc2.dirty
We use flamingo generate-app to create the argo app. It work perfectly well for HelmRelease containing a Deployment but for HelmRelease containing StatefulSet everything is displayed in the Flamingo UI except the StatefulSet.
Regards,

I am also having resources not showing when using flamingo generate-app from a helm-release. I am using the ingress-nginx chart. The resources used to show when creating the app (this stopped showing yesterday, and I have tried redeploying it all). All that is shown in the UI is the helmReop and helmRelease objects, but nothing else (the resources are created in Kubernetes)

Same Problem here. Tried a lot of HelmCharts with different kind of resources but they won't be shown. We are using flux 2.3.0 and Flamingo v2.10.5-fl.23-main-5958964b

Same here, we use flamingo  v2.10.2-fl.23-main-d2c9a8cb and flux 2.3.0. Is there any way to deploy pods/deployments and other resources deployed by helm releases?

Also having the same problem of only the HelmRelease object being shown in the UI but not the objects that are managed by said HelmRelease.
Interestingly enough, if you turn on orphaned resources detection in the associated Argo project it shows that the application contains a bunch of orphaned resources, presumably the ones that are not shown in the UI.

I scaled down all pods (except redis) in argocd namespace, then scaled them up, now I am able to see the pods created by helmreleases and kustomizations. I am using 2.10.5 release of flamingo.

If you downgrade flux to version 2.2.2 the resources will be shown in Flamingo (v2.10.5-fl.23-main-5958964b).

authors: ThatGinger135 gopaljayanthi hirenko-v jan-delaet pmialon rehabyte


text:
Add TokenVariable to github

See https://github.com/weaveworks/eksctl/pull/2561#discussion_r474129903

Codecov Report

Merging #49 into master will increase coverage by 0.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   55.41%   56.07%   +0.66%
==========================================
  Files          24       24
  Lines        1126      913     -213
==========================================
- Hits          624      512     -112
+ Misses        468      361     -107
- Partials       34       40       +6

Impacted Files
Coverage Δ

github/auth.go
81.53% <ø> (-3.28%)
:arrow_down:

github/client_organizations.go
62.50% <0.00%> (-7.50%)
:arrow_down:

github/client_repositories_org.go
55.10% <0.00%> (-5.25%)
:arrow_down:

github/resource_repository.go
79.56% <0.00%> (-1.52%)
:arrow_down:

github/util.go
50.00% <0.00%> (-1.36%)
:arrow_down:

github/resource_organization.go
83.33% <0.00%> (-0.67%)
:arrow_down:

gitprovider/util.go
100.00% <0.00%> (ø)

gitprovider/enums.go
100.00% <0.00%> (ø)

gitprovider/errors.go
0.00% <0.00%> (ø)

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a8194...aa61d27. Read the comment docs.

authors: codecov-commenter michaelbeaumont

repo: fluxcd/go-git-providers


text:
adding tests for getExtFromSchema

Tests Scenario: Extension Present
This scenario tests that the schema contains a valid extension with a setter, then verifies that the function correctly extracts the extension from the schema and returns it without an error.
Tests Scenario: Extension Not Present
This scenario tests the function when the schema does not contain any extension & verifies that the function returns nil without an error when no extension is found in the schema.

@stefanprodan good morning, hope you are well can you please take a look?

repo: fluxcd/image-automation-controller


text:
source-controller non-leader replica left in not-ready state

in reference to: https://github.com/fluxcd/source-controller/issues/326
Ok, but source-controller is the only flux component that actually does this.  I thought that was the whole purpose of the leader election thing...
Personally, I don't care about the prom alerts.  Those can be silenced.  Filling up the event log with reams of flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-579b5cc8c9-2mvw8 -- Readiness probe failed: Get "http://10.64.183.82:9090/": dial tcp 10.64.183.82:9090: connect:; however, is not.  (particularly on managed clusters where event retention is non-configurable (lifespan of a mayfly in a hurricane))
⇶ flux check 2>&1 | grep -v ready
► checking prerequisites
✗ flux 0.31.2 <0.31.4 (new version is available, please upgrade)
✔ Kubernetes 1.22.9-eks-a64ea69 >=1.20.6-0
► checking controllers
► ghcr.io/fluxcd/helm-controller:v0.22.1
► ghcr.io/fluxcd/image-automation-controller:v0.23.4
► ghcr.io/fluxcd/image-reflector-controller:v0.19.2
► ghcr.io/fluxcd/kustomize-controller:v0.26.1
► ghcr.io/fluxcd/notification-controller:v0.24.0
► ghcr.io/fluxcd/source-controller:v0.25.8

⇶ k get pod
NAME                                       READY   STATUS    RESTARTS   AGE
charts-7754c6d999-9vwq6                    1/1     Running   0          2d19h
charts-7754c6d999-tkxhv                    1/1     Running   0          22h
helm-controller-6c784449bf-dxg6n           1/1     Running   0          12m
helm-controller-6c784449bf-mcjk4           1/1     Running   0          12m
kustomize-controller-6cdbcbf75f-d5jgq      1/1     Running   0          12m
kustomize-controller-6cdbcbf75f-m5wqx      1/1     Running   0          12m
notification-controller-6b46b479f8-gdgw6   1/1     Running   0          12m
notification-controller-6b46b479f8-rf84v   1/1     Running   0          12m
source-controller-579b5cc8c9-s2wwz         1/1     Running   0          20m

helm-controller initial logs:
dxg6n
{"level":"info","ts":"2022-07-18T17:25:20.136Z","logger":"controller-runtime.metrics","msg":"Metrics server is starting to listen","addr":":8080"}
{"level":"info","ts":"2022-07-18T17:25:20.137Z","logger":"setup","msg":"starting manager"}
{"level":"info","ts":"2022-07-18T17:25:20.138Z","msg":"Starting server","path":"/metrics","kind":"metrics","addr":"[::]:8080"}
{"level":"info","ts":"2022-07-18T17:25:20.139Z","msg":"Starting server","kind":"health probe","addr":"[::]:9440"}
I0718 17:25:20.239472       7 leaderelection.go:248] attempting to acquire leader lease flux-system/helm-controller-leader-election...

mcjk4
{"level":"info","ts":"2022-07-18T17:25:16.734Z","logger":"controller-runtime.metrics","msg":"Metrics server is starting to listen","addr":":8080"}
{"level":"info","ts":"2022-07-18T17:25:16.735Z","logger":"setup","msg":"starting manager"}
{"level":"info","ts":"2022-07-18T17:25:16.735Z","msg":"Starting server","kind":"health probe","addr":"[::]:9440"}
{"level":"info","ts":"2022-07-18T17:25:16.736Z","msg":"Starting server","path":"/metrics","kind":"metrics","addr":"[::]:8080"}
I0718 17:25:16.836564       7 leaderelection.go:248] attempting to acquire leader lease flux-system/helm-controller-leader-election...
I0718 17:25:22.253167       7 leaderelection.go:258] successfully acquired lease flux-system/helm-controller-leader-election

crickets...

Hey @gladiatr72, have you noticed anything else in the logs in terms of errors?
My first guess would be to check the resource limits (CPU and Memory) and resource saturation, as I have seen they causing the controller to misbehave without a proper reason - or reasonable error messages.
Are you using the defaults values?
Would you also be able to share what type of sources (and quantity) you have configured in your setup?

Sure
⇶ k get deployments.apps -n flux-system source-controller -o jsonpath={.spec.template.spec.containers[0].resources} | jq -M .

{
  "limits": {
    "cpu": "1",
    "memory": "1Gi"
  },
  "requests": {
    "cpu": "50m",
    "memory": "64Mi"
  }
}

The controller is not misbehaving.  From the referenced ticket it is working as intended.
⇶ k get deployments.apps
NAME                          READY   UP-TO-DATE   AVAILABLE   AGE
charts                        2/2     2            2           153d
helm-controller               2/2     2            2           154d
kustomize-controller          2/2     2            2           154d
notification-controller       2/2     2            2           154d
source-controller             1/2     2            1           154d

flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused

The issue is in regards to the fluxv2 source controller being the only fluxv2 controller that uses a failed
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused

readiness check to manage
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused
flux-system -- 0s -- Warning -- Unhealthy -- pod/source-controller-84dcf54c8-xlq4h -- Readiness probe failed: Get "http://10.64.177.148:9090/": dial tcp 10.64.177.148:9090: connect: connection refused

leadership; whereas the kustomize, helm and notification controllers' secondary pods con ready go into passive state and participating in a leadership election every once in awhile.
I understand why those bits might not have been added to the source-controller, but #326 leaves one with the impression that it is not being considered as a thing that needs doing.

The other part of what you asked for: current environment has 3 git sources and 1 helm repository with ~2 dozen charts

If we would allow for standby pods to become ready, then consumers like kustomize and helm controller will not be able to fetch the source artifacts, standby pods don’t replicate the storage from the primary but kube proxy will randomly route calls to them.

authors: gladiatr72 pjbgf stefanprodan

repo: fluxcd/source-controller


text:
Provide EnvoyFilter exclude config for sidecar deployment

Is your feature request related to a problem? Please describe.
In our sidecar deployment mode, we should ideally exclude all agent traffic (etcd, prometheus, and other agents).
Describe the solution you'd like
Provide additional istioconfig template (add to existing helm chart) that  injects this additional config as part of sidecar deployment.
cc: @hdkshingala can help with any devops related sub-tasks.

Prioritizing this after https://github.com/fluxninja/aperture/issues/479, as current situation (ext authz enabled for internal traffic) is not ideal, but also not problematic. Thus fixing it is only "nice to have". Unassigning.

authors: harjotgill krdln

repo: fluxninja/aperture


text:
리스트 추가 요청입니다🙃🙂

Slack Nickname: Tia

앗 티아님은 이슈 기각입니다... 풀리퀘오 올려주세요(엄근진)

authors: TIAHWANG flynnpark

repo: flynnpark/nomadcoders-github-list


text:
Inline execution event data can be offloaded to cloud blobstore

Signed-off-by: Katrina Rogan katroganGH@gmail.com
TL;DR
Inline event data can now configured to be offloaded rather than saved in the flyteadmin db.
In the future we can explore an async write approach for this code path.
Type

[ ] Bug Fix
[x] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[ ] Smoke tested
[x] Unit tests added
[x] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
fixes https://github.com/flyteorg/flyte/issues/1789
Follow-up issue
NA

PTAL @EngHabu

In the future we can explore an async write approach for this code path

I do not think this is possible with the durability guarantees. We may use potentially a faster more expensive store

PTAL @EngHabu

@EngHabu sorry, one more time? (had merge conflicts)

PTAL @EngHabu

repo: flyteorg/flyteadmin


text:
Flyway does not print DBMS_OUTPUT logs in debug mode

What version of Flyway are you using?
Flyway 4.1.1
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)
Command line
What database are you using (type & version)?
Oracle 11g
What operating system are you using?
RHEL 5.x
What did you do?
(Please include the content causing the issue, any relevant configuration settings, and the command you ran)
create or replace procedure getcount(cout out number)
is
begin
dbms_output.enable();
select count(*) into cout from users;
end;
/
declare
cout number;
begin
getcount(cout);
DBMS_OUTPUT.PUT_LINE('count: ' || cout);
end;
/
What did you expect to see?
I expect flyway to print as like below:
count : 100
I was able to get the above output if I provide "SET SERVEROUTPUT ON" before executing the sql using Oracle SQL developer. I also do understand that command is a client specific one. Is it a right ask to get a similar command in flyway to get the output logs. ?
What did you see instead?
DEBUG: Scanning for SQL callbacks ...
DEBUG: Scanning for filesystem resources at 'sql' (Prefix: '', Suffix: '')
DEBUG: Scanning for resources in path: sql (sql)
DEBUG: Found filesystem resource: sql/V1_12_9__create_procedure_select_v2.sql
DEBUG: Schema "test" already exists. Skipping schema creation.
DEBUG: Locking table "test"."schema_version"...
DEBUG: Lock acquired for table "test"."schema_version"
DEBUG: Scanning for filesystem resources at 'sql' (Prefix: 'V', Suffix: '')
DEBUG: Scanning for resources in path: sql (sql)
DEBUG: Found filesystem resource: sql/V1_12_9__create_procedure_select_v2.sql
DEBUG: Scanning for filesystem resources at 'sql' (Prefix: 'R', Suffix: '')
DEBUG: Scanning for resources in path: sql (sql)
DEBUG: Filtering out resource: sql/V1_12_9__create_procedure_select_v2.sql (filename: V1_12_9__create_procedure_select_v2.sql)
Current version of schema "test": 1.12.3
DEBUG: Found statement at line 1: create or replace procedure getcount(cout out number)
is
begin
select count(*) into cout from users;
end;
DEBUG: Found statement at line 8: declare
cout number;
begin
getcount(cout);
DBMS_OUTPUT.PUT_LINE('count: ' || cout);
end;
Migrating schema "test" to version 1.12.9 - create procedure select v2.sql
DEBUG: Executing SQL: create or replace procedure getcount(cout out number)
is
begin
select count(*) into cout from users;
end;
DEBUG: Update Count: 0
DEBUG: Executing SQL: declare
cout number;
begin
getcount(cout);
DBMS_OUTPUT.PUT_LINE('count: ' || cout);
end;
DEBUG: Successfully completed migration of schema "test" to version 1.12.9 - create procedure select v2.sql
DEBUG: MetaData table "test"."schema_version" successfully updated to reflect changes
DEBUG: Locking table "test"."schema_version"...
DEBUG: Lock acquired for table "test"."schema_version"
Successfully applied 1 migration to schema "test" (execution time 00:01.098s).

Hey @axelfontaine , thank you for acknowledging and tagging it for the next release. It would be much helpful for our automation team.!

@umapathy08 We unfortunately have to bump this to 5.1, but I can guarantee you it is coming then as it is a natural extension to #1845

We did manage to fit it in after all.
Duplicate of #1845.

Hi Axel, how is this a duplicate of #1845? The DBMS output isn't mentioned in the issue?
I've tried with the simplest I can
DECLARE
BEGIN
DBMS_OUTPUT.put_line('hello');
END;
/
and the only 'hello' in the output is from the 'Found statement' and the 'Executing sql' statement. I thought the actual DBMS_OUTPUT woudl appear seperately in the log? This way we can build up sql dynamically on the fly and output it just before we execute it to see what's actually executing.
thanks,
Mark.

@markgargan You need to have a SET SERVEROUTPUT ON statement first in your script (support for this was added in #1845). After that DBMS_OUTPUT will be displayed as expected. This is identical to the SQL*Plus behavior.

Thanks for lightning response Axel, fair play to you! I tried this earlier and got the exception below. Script is the same as above except with the SET SERVEROUTPUT ON on the line above the declare.
Flyway version: 5.0.7
Oracle driver version: 12.1.0.1
Statement  : SET SERVEROUTPUT ON
DECLARE
BEGIN
DBMS_OUTPUT.put_line('hello');
END;
    at org.flywaydb.maven.AbstractFlywayMojo.execute(AbstractFlywayMojo.java:603)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    ... 19 more

Caused by: java.sql.SQLSyntaxErrorException: ORA-00922: missing or invalid option
Thanks,
Mark.

@markgargan Please file a new issue for this with steps to reproduce.

authors: axelfontaine markgargan umapathy08

repo: flyway/flyway


text:
ERROR: Unable to connect to the database. Configure the url, user and password! When running flyway migrate

Which version and edition of Flyway are you using?
9.3.0
If this is not the latest version, can you reproduce the issue with the latest one as well? (Many bugs are fixed in newer releases and upgrading will often resolve the issue)
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Command-line
Which database are you using? (Type & version)
Postgresql 11.16
Which operating system are you using?
Windows
What did you do? (Please include the content causing the issue, any relevant configuration settings, the SQL statement(s) that failed (if any), and the command you ran)
I updated the conf file with these settings. The credentials are definitely correct as these are the same credentials used by my django app backend to connect to the db.
flyway.url= jdbc:postgresql://localhost:5432/postgres
flyway.password=password
flyway.user=postgres
type command flyway migrate -X
Put file V1__Create_product_table.sql in sql folder
What did you expect to see?
migration success
What did you see instead?

Can you confirm if this is an issue in your example in your issue, but there appears to be a space between your = and your jdbc:postgresql://localhost:5432/postgres for flyway.url?
flyway.url= jdbc:postgresql://localhost:5432/postgres should look like flyway.url=jdbc:postgresql://localhost:5432/postgres

No, in my conf file there was no space.Double confirmed this and the error is still the same. Are there any JREs or drivers i need to install additionally in my environment to get it running?

Yes that's the default config file & I added my config there...

Could you give us a copy of your config file to validate as the section given in the issue is not as suggested before?

same error here, then I realized it is due to the location of the conf
try to move your
C:\User\sookyee.lim\Downloads\flyway-commandline-9.3.0-windows-x64\flyway-9.3.0\conf\flyway.conf
to
C:\User\sookyee.lim\Downloads\flyway-commandline-9.3.0-windows-x64\flyway-9.3.0\flyway.conf

I have moved the config file one level up and it still doesn't seem to work. One question, if my pgadmin has a master password and i didn't configure a password with my db, what password should i put in the config file?

The password you would require is likely the password generated during the initialisation of your DB which should have been outputted in the logs during initialisation.

Could you provide a minimal reproduction project?
It's likely your configuration is in the wrong place, as this is something many more people would encounter if it was a Flyway issue, so we'll be closing this until we can get a reproduction

authors: Barry-RG DoodleBobBuffPants jiannan-lu-kana sookyee


text:
test issue tracker

is this a good way to track issues ?

updating

issue closed

repo: fmadio/issues


text:
Fix rust-analyzer error test

When adding this project to RustRover IDE or VS Code rust-analyzer runs on project sync. It fails with this message:
error[E0308]: mismatched types
   --> /home/okhsunrog/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/test/src/test_result.rs:102:18
    |
101 |         None => match status.signal() {
    |                       --------------- this expression has type `Option<i32>`
102 |             Some(libc::SIGABRT) => TestResult::TrFailed,
    |                  ^^^^^^^^^^^^^ expected `i32`, found `usize`

I suggest adding harness = false to disable these checks.
You can take a look here, for example:
https://github.com/rust-lang/rust/issues/125714
https://github.com/esp-rs/esp-idf-template/commit/d084765561bd827d94eece13dedec90e97928e99
The commit in my branch fixes the issue.

LGTM, thanks!

Sure, I'll fix it

fixed

authors: fmckeogh okhsunrog

repo: fmckeogh/usb-pd-rs


text:
[Trie] - Trie implementation using map

Issue Link: https://github.com/fnplus/interview-techdev-guide/issues/155
This PR adds a trie implementation using Maps. The implementation covers the search and insert capability into trie

In which language are u working?

C++

@Rapheal-Jones : Thanks for Contributing

authors: Rapheal-Jones jenistenxavier sgbcoder

repo: fnplus/interview-techdev-guide


text:
🛑 Contaboo is down

In bef50c7, Contaboo (https://contabo.com) was down:

HTTP code: 403
Response time: 512 ms

Resolved: Contaboo is back up in 19f2f28 after 9 hours.

repo: fnzv/status


text:
🛑 Contaboo is down

In 2cbedbf, Contaboo (https://contabo.com) was down:

HTTP code: 403
Response time: 3819 ms

Resolved: Contaboo is back up in 481620a after 30 minutes.